* NEWS, MH-E-NEWS: Update for MH-E release 8.2.93.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
52968808
AS
12011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2
0a6a104b
AS
3 * lread.c (read_integer): Unread even EOF character.
4 (read1): Likewise. Properly record start position of symbol.
5
52968808
AS
6 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7 symbol character follows.
8
9e381cdd
PE
92011-07-17 Paul Eggert <eggert@cs.ucla.edu>
10
11 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12 This works around a problem with the previous change to Fcopy_file.
13 Recent glibc declares fchown with __attribute__((warn_unused_result)),
14 and without this change, GCC might complain about discarding
15 fchown's return value.
16
b5641435
JB
172011-07-16 Juanma Barranquero <lekktu@gmail.com>
18
19 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
20
a8031457
PE
212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
22
23 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
24
dd889327
LMI
252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
26
750c33f7
LMI
27 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
28 it's used from the C level.
29
dd889327
LMI
30 * process.c: Use the same condition for POLL_FOR_INPUT in both
31 keyboard.c and process.c (bug#1858).
32
87e86684
LM
332011-07-09 Lawrence Mitchell <wence@gmx.li>
34
35 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
36 (Fgnutls_boot): Use it.
37
64348f40
AS
382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
39
40 * doc.c (Fsubstitute_command_keys): Revert last change.
41
1d698799
LMI
422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
43
f863868c
LMI
44 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
45 quotes the next character, and doesn't affect other longer
46 sequences (bug#8935).
47
1d698799
LMI
48 * lread.c (syms_of_lread): Clarify that is isn't only
49 `eval-buffer' and `eval-defun' that's affected by
50 `lexical-binding' (bug#8460).
51
aa4b6df6
EZ
522011-07-15 Eli Zaretskii <eliz@gnu.org>
53
54 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
55 bidi redisplay when a line includes both an image and is
56 truncated.
57
5d856da6
PE
582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
59
ad6042bb
PE
60 Fix minor problems found by static checking.
61 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
62 (elsz): Now a signed constant, not a size_t var. We prefer signed
63 types to unsigned, to avoid integer comparison confusion. Without
64 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
65 "cannot optimize loop, the loop counter may overflow", a symptom
66 of the confusion.
f00bbb22 67 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
68 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
69
6468f31c
LMI
702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
71
49080b10
LMI
72 * search.c (Fre_search_backward): Mention `case-fold-search' in
73 all the re_search_* functions (bug#8138).
74
6468f31c
LMI
75 * keyboard.c (Fopen_dribble_file): Document when the file is
76 closed (bug#8056).
77
c965adc5
EZ
782011-07-14 Eli Zaretskii <eliz@gnu.org>
79
df9733bf
EZ
80 * bidi.c (bidi_dump_cached_states): Fix format of displaying
81 bidi_cache_idx.
82
0bb23927
EZ
83 Support bidi reordering of display and overlay strings.
84 * xdisp.c (compute_display_string_pos)
85 (compute_display_string_end): Accept additional argument STRING.
86 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
87 (reseat_to_string): Initialize bidi_it->string.s and
88 bidi_it->string.schars.
89 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
90 NULL (avoids a crash in bidi_paragraph_init). Initialize
91 itb.string.lstring.
92 (init_iterator): Call bidi_init_it only of a valid
93 buffer position was specified. Initialize paragraph_embedding to
94 L2R.
95 (reseat_to_string): Initialize the bidi iterator.
96 (display_string): If we need to ignore text properties of
97 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
98 original value of -1 will not work with bidi.)
99 (compute_display_string_pos): First arg is now struct
100 `text_pos *'; all callers changed. Support display properties on
101 Lisp strings.
102 (compute_display_string_end): Support display properties on Lisp
103 strings.
104 (init_iterator, reseat_1, reseat_to_string): Initialize the
105 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
106 when iterating on a string not from display properties).
107 (compute_display_string_pos, compute_display_string_end): Fix
108 calculation of the object to scan. Fixes an error when using
109 arrow keys.
110 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
111 base_level_stop; instead, set base_level_stop to BEGV. Fixes
112 crashes in vertical-motion.
113 (next_element_from_buffer): Improve commentary for when
114 the iterator is before prev_stop.
115 (init_iterator): Initialize bidi_p from the default value of
116 bidi-display-reordering, not from buffer-local value. Use the
117 buffer-local value only if initializing for buffer iteration.
118 (handle_invisible_prop): Support invisible properties on strings
119 that are being bidi-reordered.
120 (set_iterator_to_next): Support bidi reordering of C strings and
121 Lisp strings.
122 (next_element_from_string): Support bidi reordering of Lisp
123 strings.
124 (handle_stop_backwards): Support Lisp strings as well.
125 (display_string): Support display of R2L glyph rows. Use
126 IT_STRING_CHARPOS when displaying from a Lisp string.
127 (init_iterator): Don't initialize it->bidi_p for strings
128 here.
129 (reseat_to_string): Initialize it->bidi_p for strings here.
130 (next_element_from_string, next_element_from_c_string)
131 (next_element_from_buffer): Add xassert's for correspondence
132 between IT's object being iterated and it->bidi_it.string
133 structure.
134 (face_before_or_after_it_pos): Support bidi iteration.
135 (next_element_from_c_string): Handle the case of the first string
136 character that is not the first one in the visual order.
137 (get_visually_first_element): New function, refactored from common
138 parts of next_element_from_buffer, next_element_from_string, and
139 next_element_from_c_string.
140 (tool_bar_lines_needed, redisplay_tool_bar)
141 (display_menu_bar): Force left-to-right direction. Add a FIXME
142 comment for making that be controlled by a user option.
143 (push_it, pop_it): Save and restore the state of the
144 bidi iterator. Save and restore the bidi_p flag.
145 (pop_it): Iterate out of display property for string iteration as
146 well.
147 (iterate_out_of_display_property): Support iteration over strings.
148 (handle_single_display_spec): Set up it->bidi_it for iteration
149 over a display string, and call bidi_init_it.
150 (handle_single_display_spec, next_overlay_string)
151 (get_overlay_strings_1, push_display_prop): Set up the bidi
152 iterator for displaying display or overlay strings.
153 (forward_to_next_line_start): Don't use the shortcut if
154 bidi-iterating.
155 (back_to_previous_visible_line_start): If handle_display_prop
156 pushed the iterator stack, restore the internal state of the bidi
157 iterator by calling bidi_pop_it same number of times.
158 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
159 and we are bidi-iterating, don't decrement the iterator position;
160 instead, set the first_elt flag in the bidi iterator, to produce
161 the same effect.
162 (reseat_1): Remove redundant setting of string_from_display_prop_p.
163 (push_display_prop): xassert that we are iterating a buffer.
164 (push_it, pop_it): Save and restore paragraph_embedding member.
165 (handle_single_display_spec, next_overlay_string)
166 (get_overlay_strings_1, reseat_1, reseat_to_string)
167 (push_display_prop): Set up the `unibyte' member of bidi_it.string
168 correctly. Don't assume unibyte strings are not bidi-reordered.
169 (compute_display_string_pos)
170 (compute_display_string_end): Fix handling the case of C string.
171 (push_it, pop_it): Save and restore from_disp_prop_p.
172 (handle_single_display_spec, push_display_prop): Set the
173 from_disp_prop_p flag.
174 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
175 (pop_it): Call iterate_out_of_display_property only if we are
176 popping after iteration over a string that came from a display
177 property. Fix a typo in popping stretch info. Add an assertion
178 for verifying that the iterator position is in sync with the bidi
179 iterator.
180 (handle_single_display_spec, get_overlay_strings_1)
181 (push_display_prop): Fix initialization of paragraph direction for
182 string when that of the parent object is not yet determined.
183 (reseat_1): Call bidi_init_it to resync the bidi
184 iterator with IT's position. (Bug#7616)
185 (find_row_edges): If ROW->start.pos gives position
186 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
187 (handle_stop, back_to_previous_visible_line_start, reseat_1):
188 Reset the from_disp_prop_p flag.
189 (SAVE_IT, RESTORE_IT): New macros.
190 (pos_visible_p, face_before_or_after_it_pos)
191 (back_to_previous_visible_line_start)
192 (move_it_in_display_line_to, move_it_in_display_line)
193 (move_it_to, move_it_vertically_backward, move_it_by_lines)
194 (try_scrolling, redisplay_window, display_line): Use them when
195 saving a temporary copy of the iterator and restoring it back.
196 (back_to_previous_visible_line_start, reseat_1)
197 (init_iterator): Empty the bidi cache "stack".
198 (move_it_in_display_line_to): If iterator ended up at
199 EOL, but we never saw any buffer positions smaller than
200 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
201 motion in bidi-reordered lines.
202 (move_it_in_display_line_to): Record prev_method and prev_pos
203 immediately before the call to set_iterator_to_next. Fixes cursor
204 motion in bidi-reordered lines with stretch glyphs and strings
205 displayed in margins. (Bug#8133) (Bug#8867)
206 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
207 TO_CHARPOS.
208 (pos_visible_p): Support positions in bidi-reordered lines. Save
209 and restore bidi cache.
210
211 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
212 (bidi_paragraph_info): Delete unused struct.
213 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
214 (bidi_cache_start): New variable.
215 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
216 to zero.
217 (bidi_cache_fetch_state, bidi_cache_search)
218 (bidi_cache_find_level_change, bidi_cache_iterator_state)
219 (bidi_cache_find, bidi_peek_at_next_level)
220 (bidi_level_of_next_char, bidi_find_other_level_edge)
221 (bidi_move_to_visually_next): Compare cache index with
222 bidi_cache_start rather than with zero.
223 (bidi_fetch_char): Accept new argument STRING; all callers
224 changed. Support iteration over a string. Support strings with
225 display properties. Support unibyte strings. Fix the type of
226 `len' according to what STRING_CHAR_AND_LENGTH expects.
227 (bidi_paragraph_init, bidi_resolve_explicit_1)
228 (bidi_resolve_explicit, bidi_resolve_weak)
229 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
230 iteration over a string.
231 (bidi_set_sor_type, bidi_resolve_explicit_1)
232 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
233 can now be zero (for strings); special values 0 and -1 were
234 changed to -1 and -2, respectively.
235 (bidi_char_at_pos): New function.
236 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
237 Call it instead of FETCH_MULTIBYTE_CHAR.
238 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
239 initialized to valid values.
240 (bidi_init_it): Don't initialize charpos and bytepos with invalid
241 values.
242 (bidi_level_of_next_char): Allow the sentinel "position" to pass
243 the test for valid cached positions. Fix the logic for looking up
244 the sentinel state in the cache. GCPRO the Lisp string we are
245 iterating.
246 (bidi_push_it, bidi_pop_it): New functions.
247 (bidi_initialize): Initialize the bidi cache start stack pointer.
248 (bidi_cache_ensure_space): New function, refactored from part of
249 bidi_cache_iterator_state. Don't assume the required size is just
250 one BIDI_CACHE_CHUNK away.
251 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
252 (bidi_count_bytes, bidi_char_at_pos): New functions.
253 (bidi_cache_search): Don't assume bidi_cache_last_idx is
254 always valid if bidi_cache_idx is valid.
255 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
256 is valid if it's going to be used.
257 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
258 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
259 (bidi_cache_find_level_change, bidi_cache_ensure_space)
260 (bidi_cache_iterator_state, bidi_cache_find)
261 (bidi_find_other_level_edge, bidi_cache_start_stack): All
262 variables related to cache indices are now EMACS_INT.
263
0bb23927
EZ
264 * dispextern.h (struct bidi_string_data): New structure.
265 (struct bidi_it): New member `string'. Make flag members be 1-bit
266 fields, and put them last in the struct.
267 (compute_display_string_pos, compute_display_string_end): Update
268 prototypes.
269 (bidi_push_it, bidi_pop_it): Add prototypes.
270 (struct iterator_stack_entry): New members bidi_p,
271 paragraph_embedding, and from_disp_prop_p.
272 (struct it): Member bidi_p is now a bit field 1 bit wide.
273 (bidi_shelve_cache, bidi_unshelve_cache): Declare
274 prototypes.
275
276 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
277 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
278 and vector-like objects.
279
280 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
281 cache around display iteration.
282
283 * window.c (Fwindow_end, window_scroll_pixel_based)
284 (displayed_window_lines, Frecenter): Save and restore the bidi
285 cache around display iteration.
286
3bbd2265
LMI
2872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
288
289 * editfns.c (Fdelete_region): Clarify the use of the named
290 parameters (bug#6788).
291
adc47434
MR
2922011-07-14 Martin Rudalics <rudalics@gmx.at>
293
294 * indent.c (Fvertical_motion): Set and restore w->pointm when
295 saving and restoring the window's buffer (Bug#9006).
296
837c31f8
LMI
2972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
298
299 * editfns.c (Fstring_to_char): Clarify just what is returned
300 (bug#6576). Text by Eli Zaretskii.
301
ac389d0c
JB
3022011-07-13 Juanma Barranquero <lekktu@gmail.com>
303
304 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
305
0be0ce47
EZ
3062011-07-13 Eli Zaretskii <eliz@gnu.org>
307
308 * buffer.c (mmap_find): Fix a typo.
309
cd18e7e3
JB
3102011-07-13 Johan Bockgård <bojohan@gnu.org>
311
312 Fix execution of x selection hooks.
313 * xselect.c (Qx_lost_selection_functions)
314 (Qx_sent_selection_functions): New vars.
315 (syms_of_xselect): DEFSYM them.
316 (x_handle_selection_request): Pass Qx_sent_selection_functions
317 rather than Vx_sent_selection_functions to Frun_hook_with_args.
318 (x_handle_selection_clear,x_clear_frame_selections):
319 Pass Qx_lost_selection_functions rather than
320 Vx_lost_selection_functions to Frun_hook_with_args.
321
47ea7f44
PE
3222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
323
ac389d0c 324 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
325 The old code sometimes used this field without initializing it.
326
47ea7f44
PE
327 * alloc.c (gc_sweep): Don't read past end of array.
328 In theory, the old code could also have corrupted Emacs internals,
329 though it'd be very unlikely.
330
bc985c87
AS
3312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
332
333 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 334 argument. (Bug#4026)
bc985c87 335
0cf34688
LMI
3362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
337
b3dadd76
LMI
338 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
339 key" (bug#4257).
340
0cf34688
LMI
341 * window.c (Fset_window_start): Doc fix (bug#4199).
342 (Fset_window_hscroll): Ditto.
343
270768cd
PE
3442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
345
077e3dda 346 Fix minor new problems caught by GCC 4.6.1.
270768cd 347 * term.c (init_tty): Remove unused local.
490011a6 348 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 349 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 350 not used otherwise.
270768cd 351
b1f58454
CY
3522011-07-12 Chong Yidong <cyd@stupidchicken.com>
353
354 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
355
22b9578d
LMI
3562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
357
6e70ab07
LMI
358 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
359 are the mini-buffer and the echo area (bug#3320).
360
22b9578d
LMI
361 * term.c (init_tty): Remove support for supdup, c10 and perq
362 terminals, which are no longer supported (bug#1482).
363
8974cc9f
JB
3642011-07-10 Johan Bockgård <bojohan@gnu.org>
365
366 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
367
a560d974
JD
3682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
369
370 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
371 for non-popups (Bug#3642).
372
1dae0f0a
AS
3732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
374
268c2c36 375 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 376 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
377 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
378 * cm.c (losecursor): Likewise.
1dae0f0a
AS
379 * data.c (fmod): Likewise.
380 * dispnew.c (swap_glyphs_in_rows): Likewise.
381 * emacs.c (memory_warning_signal): Likewise.
382 * floatfns.c (float_error): Likewise.
383 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
384 (otf_open, font_otf_capability, generate_otf_features)
385 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
386 Likewise.
387 * image.c (pbm_read_file): Likewise.
388 * indent.c (string_display_width): Likewise.
389 * intervals.c (check_for_interval, search_for_interval)
390 (inc_interval_count, count_intervals, root_interval)
391 (adjust_intervals_for_insertion, make_new_interval): Likewise.
392 * lread.c (defalias): Likewise.
268c2c36 393 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
394 * regex.c (set_image_of_range_1, set_image_of_range)
395 (regex_grow_registers): Likewise.
396 * sysdep.c (strerror): Likewise.
397 * termcap.c (valid_filename_p, tprint, main): Likewise.
398 * tparam.c (main): Likewise.
399 * unexhp9k800.c (run_time_remap, save_data_space)
400 (update_file_ptrs, read_header, write_header, calculate_checksum)
401 (copy_file, copy_rest, display_header): Likewise.
402 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
403 Likewise.
404 * xdisp.c (check_it): Likewise.
405 * xfaces.c (register_color, unregister_color, unregister_colors):
406 Likewise.
407 * xfns.c (print_fontset_result): Likewise.
408 * xrdb.c (member, fatal, main): Likewise.
409
99033785
PE
4102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
411
412 Fix minor problems found by static checking (Bug#9031).
413 * chartab.c (char_table_set_range, map_sub_char_table):
414 Remove unused locals.
415 (uniprop_table): Now static.
416 * composite.c (_work_char): Remove unused static var.
417
9cb2ac56
JB
4182011-07-09 Juanma Barranquero <lekktu@gmail.com>
419
420 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
421
f25661f0
JD
4222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
423
424 * gtkutil.c (qttip_cb): Remove code without function.
425
8278c4fe
EZ
4262011-07-09 Eli Zaretskii <eliz@gnu.org>
427
428 * w32.c (pthread_sigmask): New stub.
429
1692ae2d 4302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 431
8a6ebd58 432 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
433 sigprocmask is portable only for single-threaded applications, and
434 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
435 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
436 (LIBES): Use it.
437 * callproc.c (Fcall_process):
438 * process.c (create_process):
439 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
440 Use pthread_sigmask, not sigprocmask.
123403e4 441
1b854618
JD
4422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
443
444 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
445 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
446 wrong (Bug#8591).
447
3fe4b549
JD
4482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
449
0ce7e563
JD
450 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
451 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
452 (xg_hide_tooltip): Fix comment.
453
3fe4b549
JD
454 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
455 in registerServicesMenuSendTypes.
456 (validRequestorForSendType): Don't check ns_return_types.
457
458 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
459 ns_return_type.
460
5df75e47
JR
4612011-07-08 Jason Rumney <jasonr@gnu.org>
462
463 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
464 frame struct members of non-existent frames (Bug#6284).
465
699c10bd
JD
4662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
467
4393663b
JD
468 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
469 variable firstTime not needed on OSX >= 10.6.
470 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
471 >= 10.5. Use setKnobProportion, setDoubleValue.
472
473 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
474 (MAC_OS_X_VERSION_10_5): Define if not defined.
475 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
476 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
477 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
478
479 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
480 cString and lossyCString on OSX >= 10.4
481
482 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
483 sizeToFit on OSX >= 10.2.
484
485 * nsimage.m (allocInitFromFile): Don't use deprecated method
486 bestRepresentationForDevice on OSX >= 10.6.
487
488 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
489 to avoid warning.
490
491 * emacs.c: Declare unexec_init_emacs_zone.
492
a63e0781
JD
493 * nsgui.h: Fix compiler warning about gnulib redefining verify.
494
699c10bd
JD
495 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
496
497 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
498 on svcsMenu (Bug#8842).
499
500 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
501 ns_return_types.
502 (Fns_list_services): Just return Qnil on 10.6, code not working there.
503
504 * nsterm.m (QUTF8_STRING): Declare.
505 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
506 (validRequestorForSendType): Return type is (id).
507 Change indexOfObjectIdenticalTo to indexOfObject.
508 Check if we have local selection before returning self (Bug#8842).
509 (writeSelectionToPasteboard): Put local selection into paste board
510 if we have a local selection (Bug#8842).
511 (syms_of_nsterm): DEFSYM QUTF8_STRING.
512
513 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
514 (ns_get_local_selection): Declare.
515
54e10184
LMI
5162011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
517
9888ff71
LMI
518 * keymap.c (describe_map_tree): Don't insert a double newline at
519 the end of the buffer (bug#1169) and return whether we inserted
520 something.
521
54e10184
LMI
522 * callint.c (Fcall_interactively): Change "reading args" to
523 "providing args" to try to clarify what it does (bug#1010).
524
15fa4783
KH
5252011-07-07 Kenichi Handa <handa@m17n.org>
526
527 * composite.c (composition_compute_stop_pos): Ignore a static
528 composition starting before CHARPOS (Bug#8915).
529
530 * xdisp.c (handle_composition_prop): Likewise.
531
a8815b00
EZ
5322011-07-07 Eli Zaretskii <eliz@gnu.org>
533
534 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
535 (Bug#9015)
536
ef7b981d 5372011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
538
539 * character.h (unicode_category_t): New enum type.
540
541 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
542 (Qchar_code_property_table): New variable.
543 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
544 (UNIPROP_COMPRESSED_FORM_P): New macros.
545 (char_table_ascii): Uncompress the compressed values.
546 (sub_char_table_ref): New arg is_uniprop. Callers changed.
547 Uncompress the compressed values.
ac389d0c 548 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
549 (char_table_ref_and_range): Uncompress the compressed values.
550 (sub_char_table_set): New arg is_uniprop. Callers changed.
551 Uncompress the compressed values.
552 (sub_char_table_set_range): Args changed. Callers changed.
553 (char_table_set_range): Adjuted for the above change.
554 (map_sub_char_table): Delete args default_val and parent. Add arg
555 top. Give decoded values to a Lisp function.
556 (map_char_table): Adjusted for the above change. Give decoded
557 values to a Lisp function. Gcpro more variables.
558 (uniprop_table_uncompress)
559 (uniprop_decode_value_run_length): New functions.
560 (uniprop_decoder, uniprop_decoder_count): New variables.
561 (uniprop_get_decoder, uniprop_encode_value_character)
562 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
563 New functions.
564 (uniprop_encoder, uniprop_encoder_count): New variables.
565 (uniprop_get_encoder, uniprop_table)
566 (Funicode_property_table_internal, Fget_unicode_property_internal)
567 (Fput_unicode_property_internal): New functions.
568 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
569 Sunicode_property_table_internal, Sget_unicode_property_internal,
570 and Sput_unicode_property_internal. Defvar_lisp
571 char-code-property-alist.
572
573 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
574 Vunicode_category_table.
575
576 * font.c (font_range): Adjusted for the change of
577 Vunicode_category_table.
578
76b397fb
DN
5792011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
580
581 * m/iris4d.h: Remove file, move contents ...
582 * s/irix6-5.h: ... here.
583
22b4128e
PE
5842011-07-06 Paul Eggert <eggert@cs.ucla.edu>
585
586 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
587 * alloc.c (mark_buffer):
588 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
589 (clone_per_buffer_values): Don't assume that
22b4128e
PE
590 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
591 This isn't true in general, and it's particularly not true
592 if Emacs is configured with --with-wide-int.
593 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
594 New macros, used in the buffer.c change.
595
869795d6
JD
5962011-07-05 Jan Djärv <jan.h.d@swipnet.se>
597
598 * xsettings.c: Use both GConf and GSettings if both are available.
599 (store_config_changed_event): Add comment.
600 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
601 (store_tool_bar_style_changed): New functions.
602 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
603 (struct xsettings): Move font inside HAVE_XFT.
604 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
605 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
606 Move inside HAVE_XFT.
607 (something_changed_gsettingsCB): Renamed from something_changedCB.
608 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
609 also.
610 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
611 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
612 (something_changed_gconfCB): Renamed from something_changedCB.
613 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
614 (parse_settings): Move check for font inside HAVE_XFT.
615 (read_settings, apply_xft_settings): Add comment.
616 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
617 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
618 call store_font_name_changed.
619 (xft_settings_event): Add comment.
620 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
621 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
622 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
623 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
624 (xsettings_initialize): Call init_gsettings last.
625 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
626 comment.
627
d8ed26bd
PE
6282011-07-05 Paul Eggert <eggert@cs.ucla.edu>
629
630 Random fixes. E.g., (random) never returned negative values.
631 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
632 subseconds part to the entropy, as that's a bit more random.
633 Prefer signed to unsigned, since the signedness doesn't matter and
634 in general we prefer signed. When given a limit, use a
635 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
636 latter isn't right if USE_2_TAGS_FOR_INTS.
637 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
638 not 0..VALMASK. Don't discard "excess" bits that random () returns.
639
cabf1cac
SM
6402011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
641
642 * textprop.c (text_property_stickiness):
643 Obey Vtext_property_default_nonsticky.
644 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
645 * w32fns.c (syms_of_w32fns):
646 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
647
6e9b2be9
PE
6482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
649
650 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
651 This is more efficient than Ffile_directory_p and avoids a minor race.
652
90186c68
LMI
6532011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
654
7c301272
LMI
655 * buffer.c (Foverlay_put): Say what the return value is
656 (bug#7835).
657
c4f2d8d4
LMI
658 * fileio.c (barf_or_query_if_file_exists): Check first if the file
659 is a directory before asking whether to use the file name
660 (bug#7564).
ad637907
LMI
661 (barf_or_query_if_file_exists): Make the "File is a directory"
662 error be more correct.
c4f2d8d4 663
90186c68
LMI
664 * fns.c (Frequire): Remove the mention of the .gz files, since
665 that's installation-specific, but keep the mention of
666 `get-load-suffixes'.
667
da64016e
PE
6682011-07-04 Paul Eggert <eggert@cs.ucla.edu>
669
670 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
671 Report string overflow if the output is too long.
672
7d47b580
JB
6732011-07-04 Juanma Barranquero <lekktu@gmail.com>
674
a555cb87
JB
675 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
676 (syms_of_gnutls): Remove duplicate DEFSYM for
677 Qgnutls_bootprop_verify_hostname_error, an error for
678 Qgnutls_bootprop_verify_error (which is no longer used).
679
7d47b580
JB
680 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
681 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
682 Also (re)move comments that are misplaced or no longer relevant.
683
1e49bfab
LMI
6842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
685
686 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
687
1485f4c0
CY
6882011-07-03 Chong Yidong <cyd@stupidchicken.com>
689
690 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
691 and background color parameters if they have been changed.
692
a9ab721e
LMI
6932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
694
695 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
696
cf7cff57
PE
6972011-07-03 Paul Eggert <eggert@cs.ucla.edu>
698
2e13213d
PE
699 * xsettings.c (SYSTEM_FONT): Define only when used.
700 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
701
cf7cff57
PE
702 * keymap.c (access_keymap_1): Now static.
703
7a8e04f7
CY
7042011-07-02 Chong Yidong <cyd@stupidchicken.com>
705
706 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
707 leave any prefix arg for the up event (Bug#1586).
708
61352f62
LMI
7092011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
710
69bb1ef7
LMI
711 * lread.c (syms_of_lread): Mention single symbols defined by
712 `defvar' or `defconst' (bug#7154).
713
61352f62 714 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 715 (Frequire): Mention get-load-suffixes.
61352f62 716
28545e04
MR
7172011-07-02 Martin Rudalics <rudalics@gmx.at>
718
719 * window.h (window): Remove clone_number slot.
720 * window.c (Fwindow_clone_number, Fset_window_clone_number):
721 Remove.
722 (make_parent_window, make_window, saved_window)
723 (Fset_window_configuration, save_window_save): Don't deal with
724 clone numbers.
725 * buffer.c (Qclone_number): Remove declaration.
726 (sort_overlays, overlay_strings): Don't deal with clone numbers.
727
3349e122
SM
7282011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
729
730 Add multiple inheritance to keymaps.
731 * keymap.c (Fmake_composed_keymap): New function.
732 (Fset_keymap_parent): Simplify.
733 (fix_submap_inheritance): Remove.
734 (access_keymap_1): New function extracted from access_keymap to handle
735 embedded parents and handle lists of maps.
736 (access_keymap): Use it.
737 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
738 (Fcopy_keymap): Handle embedded parents.
739 (Fcommand_remapping, define_as_prefix): Simplify.
740 (Fkey_binding): Simplify.
741 (syms_of_keymap): Move minibuffer-local-completion-map,
742 minibuffer-local-filename-completion-map,
743 minibuffer-local-must-match-map, and
744 minibuffer-local-filename-must-match-map to Elisp.
745 (syms_of_keymap): Defsubr make-composed-keymap.
746 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
747 (parse_menu_item): Trivial simplification.
748
3279eb87
GM
7492011-07-01 Glenn Morris <rgm@gnu.org>
750
751 * Makefile.in (SETTINGS_LIBS): Fix typo.
752
4550efdf
KI
7532011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
754
755 * coding.c (Fencode_coding_string): Record the last coding system
756 used, as the function doc string says (bug#8738).
757
0949d2b6
JD
7582011-07-01 Jan Djärv <jan.h.d@swipnet.se>
759
760 * xsettings.c (store_monospaced_changed): Take new font as arg and
761 check for change against current_mono_font.
762 (EMACS_TYPE_SETTINGS): Remove this and related defines.
763 (emacs_settings_constructor, emacs_settings_get_property)
764 (emacs_settings_set_property, emacs_settings_class_init)
765 (emacs_settings_init, gsettings_obj): Remove.
766 (something_changedCB): New function for HAVE_GSETTINGS.
767 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
768 with value as argument.
769 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
770 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 771 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
772 "changed".
773
774 * xgselect.c: Add defined (HAVE_GSETTINGS).
775 (xgselect_initialize): Ditto.
776
777 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
778 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
779 xg_select.
780
bbc6b304
PE
7812011-07-01 Paul Eggert <eggert@cs.ucla.edu>
782
783 * eval.c (struct backtrace): Simplify and port the data structure.
784 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
785 signed bit field, as this assumption is not portable and it makes
786 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
787 "char debug_on_exit : 1" as this is not portable either; instead,
788 use the portable "unsigned int debug_on_exit : 1". Remove unused
789 member evalargs. Remove obsolete comments about cc bombing out.
790
9851bfc5
JD
7912011-06-30 Jan Djärv <jan.h.d@swipnet.se>
792
51bb811f 793 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
794 Let HAVE_GSETTINGS override HAVE_GCONF.
795 (store_monospaced_changed): New function.
796 (EMACS_SETTINGS): A new type derived from GObject to handle
797 GSettings notifications.
798 (emacs_settings_constructor, emacs_settings_get_property)
799 (emacs_settings_set_property, emacs_settings_class_init):
800 New functions.
801 (gsettings_client, gsettings_obj): New variables.
802 (GSETTINGS_SCHEMA): New define.
803 (something_changedCB): Call store_monospaced_changed.
804 (init_gsettings): New function.
805 (xsettings_initialize): Call init_gsettings.
806 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
807 to NULL.
808
809 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
810 GCONF_CFLAGS/LIBS.
811
5386012d
MR
8122011-06-29 Martin Rudalics <rudalics@gmx.at>
813
814 * window.c (resize_root_window, grow_mini_window)
815 (shrink_mini_window): Rename Qresize_root_window to
816 Qwindow_resize_root_window and Qresize_root_window_vertically to
817 Qwindow_resize_root_window_vertically.
818
f13e0b08
PE
8192011-06-28 Paul Eggert <eggert@cs.ucla.edu>
820
821 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
822
94515237
JB
8232011-06-27 Juanma Barranquero <lekktu@gmail.com>
824
825 * makefile.w32-in: Redesign dependencies so they reflect more
826 clearly which files are directly included by each source file,
827 and not through other includes.
828
e43b6e43
MR
8292011-06-27 Martin Rudalics <rudalics@gmx.at>
830
831 * buffer.c (Qclone_number): Declare static and DEFSYM it.
832 (sort_overlays, overlay_strings): When an overlay's clone number
833 matches the window's clone number process the overlay even if
834 the overlay's window property doesn't match the current window.
835
d68443dc
MR
836 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
837 (Fwindow_hchild): Rename to Fwindow_left_child.
838 (Fwindow_next): Rename to Fwindow_next_sibling.
839 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
840 (resize_window_check): Rename to window_resize_check.
841 (resize_window_apply): Rename to window_resize_apply.
842 (Fresize_window_apply): Rename to Fwindow_resize_apply.
843 (Fdelete_other_windows_internal, resize_frame_windows)
844 (Fsplit_window_internal, Fdelete_window_internal)
845 (grow_mini_window, shrink_mini_window)
846 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 847
c7e73be5
JD
8482011-06-26 Jan Djärv <jan.h.d@swipnet.se>
849
850 * emacsgtkfixed.h: State that this is only used with Gtk+3.
851 (emacs_fixed_set_min_size): Remove.
852 (emacs_fixed_new): Take frame as argument.
853
854 * emacsgtkfixed.c: State that this is only used with Gtk+3.
855 (_EmacsFixedPrivate): Remove minwidth/height.
856 Add struct frame *f.
857 (emacs_fixed_init): Initialize priv->f.
858 (get_parent_class, emacs_fixed_set_min_size): Remove.
859 (emacs_fixed_new): Set priv->f to argument.
860 (emacs_fixed_get_preferred_width)
861 (emacs_fixed_get_preferred_height): Use min_width/height from
862 frames size_hint to set minimum and natural (Bug#8919).
863 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
864 and use min_width/height from frames size_hint to set
865 min_width/height (Bug#8919).
866
867 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
868 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
869 Fix indentation.
c7e73be5 870
cf99dcf8
EZ
8712011-06-26 Eli Zaretskii <eliz@gnu.org>
872
873 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
874 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
875 called at ZV.
876
029529ac
CY
8772011-06-26 Chong Yidong <cyd@stupidchicken.com>
878
879 * process.c (wait_reading_process_output): Bypass select if
880 waiting for a cell while ignoring keyboard input, and input is
881 pending. Suggested by Jan Djärv (Bug#8869).
882
7a7ef429
PE
8832011-06-25 Paul Eggert <eggert@cs.ucla.edu>
884
885 Use gnulib's dup2 module instead of rolling our own.
886 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
887
11fdef7d 8882011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
889
890 * dispnew.c (scrolling_window): Before scrolling, turn off a
891 mouse-highlight in the window being scrolled.
892
cd3520a4
JB
8932011-06-24 Juanma Barranquero <lekktu@gmail.com>
894
895 Move DEFSYM to lisp.h and use everywhere.
896
897 * character.h (DEFSYM): Move declaration...
898 * lisp.h (DEFSYM): ...here.
899
900 * gnutls.c:
901 * minibuf.c:
902 * w32menu.c:
903 * w32proc.c:
904 * w32select.c: Don't include character.h.
905
906 * alloc.c (syms_of_alloc):
907 * buffer.c (syms_of_buffer):
908 * bytecode.c (syms_of_bytecode):
909 * callint.c (syms_of_callint):
910 * casefiddle.c (syms_of_casefiddle):
911 * casetab.c (init_casetab_once):
912 * category.c (init_category_once, syms_of_category):
913 * ccl.c (syms_of_ccl):
914 * cmds.c (syms_of_cmds):
915 * composite.c (syms_of_composite):
916 * dbusbind.c (syms_of_dbusbind):
917 * dired.c (syms_of_dired):
918 * dispnew.c (syms_of_display):
919 * doc.c (syms_of_doc):
920 * editfns.c (syms_of_editfns):
921 * emacs.c (syms_of_emacs):
922 * eval.c (syms_of_eval):
923 * fileio.c (syms_of_fileio):
924 * fns.c (syms_of_fns):
925 * frame.c (syms_of_frame):
926 * fringe.c (syms_of_fringe):
927 * insdel.c (syms_of_insdel):
928 * keymap.c (syms_of_keymap):
929 * lread.c (init_obarray, syms_of_lread):
930 * macros.c (syms_of_macros):
931 * msdos.c (syms_of_msdos):
932 * print.c (syms_of_print):
933 * process.c (syms_of_process):
934 * search.c (syms_of_search):
935 * sound.c (syms_of_sound):
936 * syntax.c (init_syntax_once, syms_of_syntax):
937 * terminal.c (syms_of_terminal):
938 * textprop.c (syms_of_textprop):
939 * undo.c (syms_of_undo):
940 * w32.c (globals_of_w32):
941 * window.c (syms_of_window):
942 * xdisp.c (syms_of_xdisp):
943 * xfaces.c (syms_of_xfaces):
944 * xfns.c (syms_of_xfns):
945 * xmenu.c (syms_of_xmenu):
946 * xsettings.c (syms_of_xsettings):
947 * xterm.c (syms_of_xterm): Use DEFSYM.
948
4228cf16
TZ
9492011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
950
cd3520a4 951 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 952
7fcccf1e
PE
9532011-06-23 Paul Eggert <eggert@cs.ucla.edu>
954
7efb4e0e
PE
955 Integer and buffer overflow fixes (Bug#8873).
956
ff5844ad
PE
957 * print.c (printchar, strout): Check for string overflow.
958 (PRINTPREPARE, printchar, strout):
959 Don't set size unless allocation succeeds.
960
90532f02
PE
961 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
962 for sizes. Check for string overflow more accurately.
963 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
964
6d84508d
PE
965 * macros.c: Integer and buffer overflow fixes.
966 * keyboard.h (struct keyboard.kbd_macro_bufsize):
967 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
968 Use ptrdiff_t, not int, for sizes.
969 Don't increment bufsize until after realloc succeeds.
970 Check for size-calculation overflow.
971 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
972
437b2cb4
PE
973 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
974
8b9ac8b4
PE
975 * lread.c: Integer overflow fixes.
976 (read_integer): Radix is now EMACS_INT, not int,
977 to improve quality of diagnostics for out-of-range radices.
978 Calculate buffer size correctly for out-of-range radices.
979 (read1): Check for integer overflow in radices, and in
980 read-circle numbers.
82cb60d3
PE
981 (read_escape): Avoid int overflow.
982 (Fload, openp, read_buffer_size, read1)
983 (substitute_object_recurse, read_vector, read_list, map_obarray):
984 Use ptrdiff_t, not int, for sizes.
985 (read1): Use EMACS_INT, not int, for sizes.
20270765 986 Check for size overflow.
8b9ac8b4 987
7fcccf1e
PE
988 * image.c (cache_image): Check for size arithmetic overflow.
989
bfbbd7e7
PE
990 * lread.c: Integer overflow issues.
991 (saved_doc_string_size, saved_doc_string_length)
992 (prev_saved_doc_string_size, prev_saved_doc_string_length):
993 Now ptrdiff_t, not int.
994 (read1): Don't assume doc string length fits in int. Check for
995 out-of-range doc string lengths.
996 (read_list): Don't assume file position fits in int.
39019e54 997 (read_escape): Check for hex character overflow.
bfbbd7e7 998
4e323265
LL
9992011-06-22 Leo Liu <sdl.web@gmail.com>
1000
1001 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1002 Move to minibuffer.el.
1003
85fece3e
PE
10042011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1005
20b84ce9 1006 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1007 The following patches are for when GLYPH_DEBUG && !XASSERT.
1008 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1009 * dispnew.c (flush_stdout):
1010 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1011 Mark as externally visible.
1012 * dispnew.c (check_window_matrix_pointers): Now static.
1013 * dispnew.c (window_to_frame_vpos):
1014 * xfns.c (unwind_create_frame):
1015 * xterm.c (x_check_font): Remove unused local.
1016 * scroll.c (CHECK_BOUNDS):
1017 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1018 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1019 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1020 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1021 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1022 Now static.
1023 (debug_method_add): Use va_list and vsprintf rather than relying
1024 on undefined behavior with wrong number of arguments.
1025 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1026 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1027 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1028 since we're not interested in debugging glyphs with old libraries.
1029 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1030 GCC 4.6.0's static checking.
1031
0766b489
PE
10322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1033
31fd4b32
PE
1034 Integer overflow and signedness fixes (Bug#8873).
1035 A few related buffer overrun fixes, too.
1036
b79e8648
PE
1037 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1038
0766b489
PE
1039 * dispextern.h (struct face.stipple):
1040 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1041 (x_bitmap_mask, x_allocate_bitmap_record)
1042 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1043 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1044 (x_create_bitmap_from_xpm_data):
1045 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1046 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1047 (.bitmaps_last):
1048 * xfaces.c (load_pixmap):
1049 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1050 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1051 (.bitmaps_last, struct x_output.icon_bitmap):
1052 Use ptrdiff_t, not int, for bitmap indexes.
1053 (x_allocate_bitmap_record): Check for size overflow.
1054 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1055
b081724f
PE
1056 Use ptrdiff_t, not int, for overlay counts.
1057 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1058 * editfns.c (overlays_around, get_pos_property):
1059 * textprop.c (get_char_property_and_overlay):
1060 * xdisp.c (next_overlay_change, note_mouse_highlight):
1061 * xfaces.c (face_at_buffer_position):
21514da7
PE
1062 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1063 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1064 (Fnext_overlay_change, Fprevious_overlay_change)
1065 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1066 Use ptrdiff_t, not int, for sizes.
21514da7 1067 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1068
3de73e5e
PE
1069 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1070
2606c57b
PE
1071 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1072 (x_session_initialize): Do not assume string length fits in int.
1073
aaafe47a
PE
1074 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1075 This is unlikely, but can occur if DPI is outlandish.
1076
2674ddc8 1077 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1078 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1079
28154962
PE
1080 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1081 * xrdb.c (magic_file_p, search_magic_path):
1082 Omit last arg SUFFIX; it was always 0. All callers changed.
1083 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1084
7de51af5
PE
1085 * xfont.c (xfont_match): Avoid need for strlen.
1086
25ed6cc3
PE
1087 * xfns.c: Don't assume strlen fits in int.
1088 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1089
4eab31dd
PE
1090 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1091 not unsigned long, as we prefer signed integers. All callers changed.
1092 Detect integer overflow in repeat count.
1093 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1094 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1095
171e2a58
PE
1096 * termcap.c: Don't assume sizes fit in int and never overflow.
1097 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1098 (gobble_line): Check for size-calculation overflow.
1099
ad39faca 1100 * minibuf.c (Fread_buffer):
6e5bb2dc 1101 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1102 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1103 Don't assume string length fits in int.
1104
52c61c22 1105 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1106 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1107
b5b8c9e5
PE
1108 * font.c: Don't assume string length fits in int.
1109 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1110 Use ptrdiff_t, not int.
ccd6111c
PE
1111 (font_intern_prop): Don't assume string length fits in int.
1112 Don't assume integer property fits in fixnum.
1113 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1114
882f0d81 1115 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1116 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1117 Reformulate so as not to need the command string.
1118 Invoke gzip -cd rather than gunzip, as it's more portable.
1119 (lock_info_type, lock_file_1, lock_file):
1120 Don't assume pid_t and time_t fit in unsigned long.
1121 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1122 (current_lock_owner): Prefer signed type for sizes.
1123 Use memcpy, not strncpy, where memcpy is what is really wanted.
1124 Don't assume (via atoi) that time_t and pid_t fit in int.
1125 Check for time_t and/or pid_t out of range, e.g., via a network share.
1126 Don't alloca where an auto var works fine.
1127
93f4cf88
PE
1128 * fileio.c: Fix some integer overflow issues.
1129 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1130 Don't assume string length fits in int.
1131 (directory_file_name): Don't assume string length fits in long.
1132 (make_temp_name): Don't assume pid fits in int, or that its print
1133 length is less than 20.
1134
f3e92b69
PE
1135 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1136
1bfdaf10
PE
1137 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1138
35016e9a
PE
1139 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1140
3d1e65a1
PE
1141 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1142 We prefer signed integers, even for size calculations.
1143
0b963a93
PE
1144 * emacs.c: Don't assume string length fits in 'int'.
1145 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1146 (main): Don't invoke strlen when not needed.
1147
573f4b54
PE
1148 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1149 (XD_DEBUG_MESSAGE): Don't waste a byte.
1150
989f33ba
PE
1151 * callproc.c (getenv_internal_1, getenv_internal)
1152 (Fgetenv_internal):
965d34eb
PE
1153 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1154
e4d29b33
PE
1155 * lread.c (invalid_syntax): Omit length argument.
1156 All uses changed. This doesn't fix a bug, but it simplifies the
1157 code away from its former Hollerith-constant appearance, and it's
1158 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1159 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1160
eb49b136
PE
1161 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1162 This didn't break anything, but it didn't help either.
1163 It's confusing to put a bogus integer in a place where the actual
1164 value does not matter.
9f62aeb1 1165 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1166 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1167
15375a22
PE
1168 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1169 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1170 implementation.
b61cc01c
PE
1171 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1172 We prefer signed types, and the value cannot exceed the EMACS_INT
1173 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1174 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1175 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1176 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1177
53b2623d
PE
1178 * indent.c (sane_tab_width): New function.
1179 (current_column, scan_for_column, Findent_to, position_indentation)
1180 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1181 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1182
51cab52b 1183 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1184
f2ed8a70
PE
1185 * lisp.h (lint_assume): New macro.
1186 * composite.c (composition_gstring_put_cache):
1187 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1188
abe80cc6
PE
1189 * editfns.c, insdel.c:
1190 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1191
b02c740e
PE
1192 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1193
ebc96716
PE
1194 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1195
b4e50fa0 1196 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1197 Use much-faster test for byte-length change.
311d5d7c 1198 Don't assume string byte-length fits in 'int'.
a4cf38e4 1199 Check that character arg fits in 'int'.
85461888 1200 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1201
c0c1ee9f
PE
1202 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1203
a498d7f4
PE
1204 * fns.c (concat): Catch string overflow earlier.
1205 Do not rely on integer wraparound.
1206
51cab52b
PE
1207 * dispextern.h (struct it.overlay_strings_charpos)
1208 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1209 * xdisp.c (forward_to_next_line_start)
1210 (back_to_previous_visible_line_start)
1211 (reseat_at_next_visible_line_start, next_element_from_buffer):
1212 Don't arbitrarily truncate the value of 'selective' to int.
1213
76031fad
PE
1214 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1215
5eb55db9
PE
1216 * composite.c: Don't truncate sizes to 'int'.
1217 (composition_gstring_p, composition_reseat_it)
1218 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1219 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1220 not EMACS_UINT, for indexes.
5eb55db9 1221
0703a717
PE
1222 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1223
d6202519
PE
1224 * buffer.c: Include <verify.h>.
1225 (struct sortvec.priority, struct sortstr.priority):
8961a454 1226 Now EMACS_INT, not int.
c20998a7 1227 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1228 (struct sortstr.size, record_overlay_string)
1229 (struct sortstrlist.size, struct sortlist.used):
1230 Don't truncate size to int.
1231 (record_overlay_string): Check for size-calculation overflow.
d6202519 1232 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1233
d5a19415
JM
12342011-06-22 Jim Meyering <meyering@redhat.com>
1235
029529ac 1236 Don't leak an XBM-image-sized buffer
d5a19415
JM
1237 * image.c (xbm_load): Free the image buffer after using it.
1238
a9041e6c
PE
12392011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1240
1241 Port to Sun C.
1242 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1243 that Sun C diagnosed.
1244 * fns.c (secure_hash): Fix pointer signedness issue.
1245 * intervals.c (static_offset_intervals): New function.
1246 (offset_intervals): Use it.
1247
7f3f739f
LL
12482011-06-21 Leo Liu <sdl.web@gmail.com>
1249
1250 * deps.mk (fns.o):
1251 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1252 sha512.h.
1253
1254 * fns.c (secure_hash): Rename from crypto_hash_function and change
1255 the first arg to accept symbols.
5b66d427 1256 (Fsecure_hash): New primitive.
7f3f739f
LL
1257 (syms_of_fns): New symbols.
1258
76147d94
DD
12592011-06-20 Deniz Dogan <deniz@dogan.se>
1260
1261 * process.c (Fset_process_buffer): Clarify return value in
1262 docstring.
1263
7d7d0045
CY
12642011-06-18 Chong Yidong <cyd@stupidchicken.com>
1265
1266 * dispnew.c (add_window_display_history): Use BVAR.
1267
1268 * xdisp.c (debug_method_add): Use BVAR.
1269 (check_window_end, dump_glyph_matrix, dump_glyph)
1270 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1271
1272 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1273 Likewise.
1274
1275 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1276 check till after the cache is created in init_frame_faces.
1277
ff2bc410
SM
12782011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1279
1280 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1281
28177add
PE
12822011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1283
dd3482fe
PE
1284 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1285 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1286 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1287
393d71f3 1288 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1289 * fileio.c (Finsert_file_contents):
1290 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1291 Remove the old (too-loose) buffer overflow checks.
1292 They weren't needed, since make_gap checks for buffer overflow.
1293 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1294 The old code merely checked for Emacs fixnum overflow, and relied
1295 on undefined (wraparound) behavior. The new code avoids undefined
1296 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1297
2e6813b0 1298 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1299 Tune. Don't use wider integers than needed. Don't use alloca.
1300 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1301
599a9e4f
PE
1302 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1303
99561444
PE
1304 * insdel.c, lisp.h (buffer_overflow): New function.
1305 (insert_from_buffer_1, replace_range, replace_range_2):
1306 * insdel.c (make_gap_larger):
1307 * editfns.c (Finsert_char):
1308 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1309
28177add
PE
1310 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1311
e69dafad
PE
13122011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1313
a7af7fde 1314 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1315
b1c46f02
PE
1316 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1317 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1318
e69dafad
PE
1319 * fileio.c: Don't assume EMACS_INT fits in off_t.
1320 (emacs_lseek): New static function.
1321 (Finsert_file_contents, Fwrite_region): Use it.
1322 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1323
566684ea
PE
1324 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1325
e6966cd6
PE
1326 * fns.c: Don't overflow int when computing a list length.
1327 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1328 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1329 truncation on 64-bit hosts. Check for QUIT every
1330 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1331 faster and is responsive enough.
1332 (Flength): Report an error instead of overflowing an integer.
1333 (Fsafe_length): Return a float if the value is not representable
1334 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1335 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1336 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1337
dd0b0efb
PE
1338 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1339 (header_size, word_size): New constants.
1340 (allocate_vectorlike): Don't check size overflow here.
1341 (allocate_vector): Check it here instead, since this is the only
1342 caller of allocate_vectorlike that could cause overflow.
1343 Check that the new vector's length is representable as a fixnum.
1344
86fe5cfe
PE
1345 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1346 The previous code was bogus. For example, next_almost_prime (32)
1347 returned 39, which is undesirable as it is a multiple of 3; and
1348 next_almost_prime (24) returned 25, which is a multiple of 5 so
1349 why was the code bothering to check for multiples of 7?
1350
80e88859
PE
1351 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1352
4a2f0ad6
PE
1353 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1354
f66c7cf8
PE
1355 Variadic C functions now count arguments with ptrdiff_t.
1356 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1357 Back then I didn't know that the Emacs coding style prefers signed int.
1358 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1359 were being counted with int, which may truncate counts on 64-bit
1360 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1361 * lisp.h (struct Lisp_Subr.function.aMANY)
1362 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1363 Arg counts are now ptrdiff_t, not size_t.
1364 All variadic functions and their callers changed accordingly.
1365 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1366 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1367 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1368 * callint.c (Fcall_interactively): Check arg count for overflow,
1369 to avoid potential buffer overrun. Use signed char, not 'int',
1370 for 'varies' array, so that we needn't bother to check its size
1371 calculation for overflow.
1372 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1373 * eval.c (apply_lambda):
1374 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1375 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1376 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1377
a1759b76
PE
1378 * callint.c (Fcall_interactively): Don't use index var as event count.
1379
d96be9fc
PE
1380 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1381 * mem-limits.h (SIZE): Remove; no longer used.
1382
a690a978 1383 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1384
578c21e6
PE
1385 Remove unnecessary casts.
1386 * xterm.c (x_term_init):
1387 * xfns.c (x_set_border_pixel):
1388 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1389 These aren't needed now that we assume ANSI C.
1390
96f53c6c
PE
1391 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1392 It's more likely to cause problems (due to unsigned overflow)
1393 than to cure them.
1394
83c77d31
PE
1395 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1396
ee2079f1
PE
1397 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1398
6da65536
PE
1399 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1400
7147c4a4
PE
1401 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1402
193e32d9
PE
1403 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1404
e5533da6
PE
1405 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1406
9910e595
PE
1407 GLYPH_CODE_FACE returns EMACS_INT, not int.
1408 * dispextern.h (merge_faces):
1409 * xfaces.c (merge_faces):
01103c44
PE
1410 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1411 Don't assume EMACS_INT fits in int.
9910e595 1412
2638320e
PE
1413 * character.h (CHAR_VALID_P): Remove unused parameter.
1414 * fontset.c, lisp.h, xdisp.c: All uses changed.
1415
045eb8d9
PE
1416 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1417
c1f134b5
PE
1418 * fns.c (concat): Minor tuning based on overflow analysis.
1419 This doesn't fix any bugs. Use int to hold character, instead
1420 of constantly refetching from Emacs object. Use XFASTINT, not
1421 XINT, for value known to be a character. Don't bother comparing
1422 a single byte to 0400, as it's always less.
1423
395fcb93 1424 * floatfns.c (Fexpt):
327eeec8
PE
1425 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1426
abbd3d23
PE
1427 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1428 for characters.
1429
684a03ef
PE
1430 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1431
0fed43f3
PE
1432 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1433 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1434 incorrectly succeed when S was a string, because 4294967386 was
1435 truncated before it was used.
1436
8fd02eb7
PE
1437 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1438 Otherwise, an out-of-range integer could cause undefined behavior
1439 on a 64-bit host.
1440
f8c86b69
PE
1441 * composite.c: Use int, not EMACS_INT, for characters.
1442 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1443 EMACS_INT, for values that are known to be in character range.
1444 This doesn't fix any bugs but is the usual style inside Emacs and
1445 may generate better code on 32-bit machines.
1446
34206dd2
PE
1447 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1448 This is for reasons similar to the recent CHAR_STRING fix.
1449 * charset.c (Fencode_char): Check that character arg is actually
1450 a character. Pass an int to ENCODE_CHAR.
1451 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1452 wider than 'int', as a compile-time check to prevent future regressions
1453 in this area.
1454
c5958d4c 1455 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1456
1457 Make sure a 64-bit char is never passed to CHAR_STRING.
1458 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1459 by silently ignoring the top 32 bits, allowing some values
1460 that were far too large to be valid characters.
1461 * character.h: Include <verify.h>.
1462 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1463 arguments are no wider than unsigned, as a compile-time check
1464 to prevent future regressions in this area.
1465 * data.c (Faset):
01103c44 1466 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1467 (Fsubst_char_in_region):
1468 * fns.c (concat):
1469 * xdisp.c (decode_mode_spec_coding):
1470 Adjust to CHAR_STRING's new requirement.
1471 * editfns.c (Finsert_char, Fsubst_char_in_region):
1472 * fns.c (concat): Check that character args are actually
1473 characters. Without this test, these functions did the wrong
1474 thing with wildly out-of-range values on 64-bit hosts.
1475
d37ca623
PE
1476 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1477 These casts should not be needed on 32-bit hosts, either.
1478 * keyboard.c (read_char):
1479 * lread.c (Fload): Remove casts to unsigned.
1480
ea204efb
PE
1481 * lisp.h (UNSIGNED_CMP): New macro.
1482 This fixes comparison bugs on 64-bit hosts.
1483 (ASCII_CHAR_P): Use it.
1484 * casefiddle.c (casify_object):
01103c44 1485 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1486 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1487 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1488 * dispextern.h (FACE_FROM_ID):
1489 * keyboard.c (read_char): Use UNSIGNED_CMP.
1490
41cb286c
PE
1491 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1492 not to EMACS_INT, to avoid GCC warning.
1493
4a1b9832
PE
1494 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1495
55daad71
PE
1496 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1497 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1498 isn't needed on 32-bit machines.
8f95c75c 1499
01103c44
PE
1500 * buffer.c (Fgenerate_new_buffer_name):
1501 Use EMACS_INT for count, not int.
0ceccced 1502 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1503
1504 * data.c (Qcompiled_function): Now static.
1505
c6f072e7
PE
1506 * window.c (window_body_lines): Now static.
1507
20ce5912
PE
1508 * image.c (gif_load): Rename local to avoid shadowing.
1509
9c4c5f81
PE
1510 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1511 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1512 * alloc.c (make_save_value): Integer argument is now of type
1513 ptrdiff_t, not int.
1514 (mark_object): Use ptrdiff_t, not int.
1515 * lisp.h (pD): New macro.
1516 * print.c (print_object): Use it.
1517
c0c5c8ae
PE
1518 * alloc.c: Use EMACS_INT, not int, to count objects.
1519 (total_conses, total_markers, total_symbols, total_vector_size)
1520 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1521 (total_free_floats, total_floats, total_free_intervals)
1522 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1523 Now EMACS_INT, not int. All uses changed.
1524 (Fgarbage_collect): Compute overall total using a double, so that
1525 integer overflow is less likely to be a problem. Check for overflow
1526 when converting back to an integer.
5a25e253
PE
1527 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1528 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1529 These were 'int' variables that could overflow on 64-bit hosts;
1530 they were never used, so remove them instead of repairing them.
211a0b2a 1531 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1532 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1533 Previously, this ceilinged at INT_MAX, but that doesn't work on
1534 64-bit machines.
e46bb31a 1535 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1536
c78baabf 1537 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1538 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1539 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1540 when a (possibly-narrower) signed value would do just as well.
1541 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1542
c9d624c6
PE
1543 * alloc.c: Catch some string size overflows that we were missing.
1544 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1545 for convenience in STRING_BYTES_MAX.
1546 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1547 The definition here is exact; the one in lisp.h was approximate.
1548 (allocate_string_data): Check for string overflow. This catches
1549 some instances we weren't catching before. Also, it catches
1550 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1551 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1552 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1553
c9d624c6
PE
1554 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1555 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1556 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1557
353032ce
PE
1558 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1559
2bccce07
PE
1560 * alloc.c (Fmake_string): Check for out-of-range init.
1561
0ac30604
SM
15622011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1563
1564 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1565
c195f2de
JD
15662011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1567
1568 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1569 xg_get_default_scrollbar_width.
1570
1571 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1572 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1573 (style_changed_cb): Call update_theme_scrollbar_width and call
1574 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1575 all frames (Bug#8505).
1576 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1577 Call gtk_window_set_resizable if HAVE_GTK3.
1578 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1579 and height if HAVE_GTK3 (Bug#8505).
1580 (scroll_bar_width_for_theme): New variable.
1581 (update_theme_scrollbar_width): New function.
1582 (xg_get_default_scrollbar_width): Move code to
1583 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1584 (xg_initialize): Call update_theme_scrollbar_width.
1585
1586 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1587
1588 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1589
e10ac9f1
MR
15902011-06-12 Martin Rudalics <rudalics@gmx.at>
1591
1592 * frame.c (make_frame): Call other_buffer_safely instead of
1593 other_buffer.
1594
1595 * window.c (temp_output_buffer_show): Call display_buffer with
1596 second argument Vtemp_buffer_show_specifiers and reset latter
1597 immediately after the call.
1598 (Vtemp_buffer_show_specifiers): New variable.
1599 (auto_window_vscroll_p, next_screen_context_lines)
1600 (Vscroll_preserve_screen_position): Remove leading asterisks from
1601 doc-strings.
1602
2d3c217e 16032011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1604
7b7f97e8 1605 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1606 * buffer.c (Qclone_number): Remove for now, as it's unused.
1607 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1608 (record_buffer): Remove unused local.
1609 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1610 (set_frame_buffer_list): Remove; unused.
1611 * frame.h (other_visible_frames): Remove decl.
1612 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1613 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1614 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1615 if HAVE_GPM.
1616 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1617 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1618 Define only if HAVE_GPM.
1619 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1620 (update_hints_inhibit): Remove; never set. All uses removed.
1621 * widgetprv.h (emacsFrameClassRec): Remove decl.
1622 * window.c (delete_deletable_window): Now returns void, since it
1623 wasn't returning anything.
1624 (compare_window_configurations): Remove unused locals.
1625 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1626 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1627 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1628 the same widths as pointers. This follows up on the 2011-05-06 patch.
1629 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1630 * xterm.h: Likewise.
1631 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1632
1384b89e
JB
16332011-06-12 Juanma Barranquero <lekktu@gmail.com>
1634
1635 * makefile.w32-in: Update dependencies.
1636 (LISP_H): Add lib/intprops.h.
1637
1100a63c
CY
16382011-06-11 Chong Yidong <cyd@stupidchicken.com>
1639
1640 * image.c (gif_load): Add animation frame delay to the metadata.
1641 (syms_of_image): Use DEFSYM. New symbol `delay'.
1642
6198ccd0
MR
16432011-06-11 Martin Rudalics <rudalics@gmx.at>
1644
1645 * window.c (delete_deletable_window): Re-add.
1646 (Fset_window_configuration): Rewrite to handle dead buffers and
1647 consequently deletable windows.
1648 (window_tree, Fwindow_tree): Remove. Supply functionality in
1649 window.el.
1650 (compare_window_configurations): Simplify code.
1651
b6e3633c
AS
16522011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1653
1ab0dee5
AS
1654 * image.c (imagemagick_load_image): Fix type mismatch.
1655 (Fimagemagick_types): Likewise.
1656
b6e3633c
AS
1657 * window.h (replace_buffer_in_windows): Declare.
1658
9397e56f
MR
16592011-06-11 Martin Rudalics <rudalics@gmx.at>
1660
1661 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1662 Qclone_number. Remove external declaration of Qdelete_window.
1663 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1664 code.
1665 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1666 Qbuffer_list_update_hook if allowed.
1667 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1668 buffer list implementation.
1669 (other_buffer_safely): New function.
1670 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1671 calls to replace_buffer_in_windows and
1672 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1673 if allowed.
1674 (record_buffer): Inhibit quitting and rewrite using quittable
1675 functions. Run Qbuffer_list_update_hook if allowed.
1676 (Frecord_buffer, Funrecord_buffer): New functions.
1677 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1678 switch-to-buffer to window.el.
1679 (bury-buffer): Move to window.el.
1680 (Vbuffer_list_update_hook): New variable.
1681
1682 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1683 section.
1684
1685 * window.h (resize_frame_windows): Move up in code.
1686 (Fwindow_frame): Remove EXFUN.
1687 (replace_buffer_in_all_windows): Remove prototype.
1688 (replace_buffer_in_windows_safely): Add prototype.
1689
1690 * window.c: Declare Qdelete_window static again. Move down
1691 declaration of select_count.
1692 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1693 (Fother_window): Move to window.el.
1694 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1695 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1696 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1697 window.el.
1698 (replace_buffer_in_windows): Implement by calling
1699 Qreplace_buffer_in_windows.
1700 (replace_buffer_in_all_windows): Remove with some functionality
1701 moved into replace_buffer_in_windows_safely.
1702 (replace_buffer_in_windows_safely): New function.
1703 (select_window_norecord, select_frame_norecord): Move in front
1704 of run_window_configuration_change_hook. Remove now obsolete
1705 declarations.
1706 (Fset_window_buffer): Rewrite doc-string. Call
1707 Qrecord_window_buffer.
1708 (keys_of_window): Move binding for other-window to window.el.
1709
b50691aa
CY
17102011-06-11 Chong Yidong <cyd@stupidchicken.com>
1711
1712 * dispextern.h (struct image): Replace data member, whose int_val
1713 and ptr_val fields were not used by anything, with a single
1714 lisp_val object.
1715
1716 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1717 (gif_clear_image, gif_load, imagemagick_load_image)
1718 (gs_clear_image, gs_load): Callers changed.
1719
3f754b86
PE
17202011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1721
cca69397
PE
1722 * buffer.h: Include <time.h>, for time_t.
1723 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1724
109e28d0
PE
1725 Fix minor problems found by static checking.
1726
60737f02
PE
1727 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1728
4b66faf3
PE
1729 Make identifiers static if they are not used in other modules.
1730 * data.c (Qcompiled_function, Qframe, Qvector):
1731 * image.c (QimageMagick, Qsvg):
1732 * minibuf.c (Qmetadata):
1733 * window.c (resize_window_check, resize_root_window): Now static.
1734 * window.h (resize_window_check, resize_root_window): Remove decls.
1735
109e28d0
PE
1736 * window.c (window_deletion_count, delete_deletable_window):
1737 Remove; unused.
46a4ce9e
PE
1738 (window_body_lines): Now static.
1739 (Fdelete_other_windows_internal): Mark vars as initialized.
1740 Make sure 'resize_failed' is initialized.
1741 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1742 (resize_window_apply): Remove unused local.
1743 * window.h (delete_deletable_window): Remove decl.
1744
109e28d0 1745 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1746 (imagemagick_load_image): Fix pointer signedness problem by changing
1747 last arg from unsigned char * to char *. All uses changed.
1748 Also, fix a local for similar reasons.
1749 Remove unused locals. Remove locals to avoid shadowing.
1750 (fn_rsvg_handle_free): Remove; unused.
1751 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1752 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1753
3f754b86
PE
1754 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1755
2547adb1
CY
17562011-06-10 Chong Yidong <cyd@stupidchicken.com>
1757
1758 * image.c (gif_load): Fix omitted cast error introduced by
1759 2011-06-06 change.
1760
2c8e37d4
MR
17612011-06-10 Martin Rudalics <rudalics@gmx.at>
1762
1763 * window.h (resize_proportionally, orig_total_lines)
1764 (orig_top_line): Remove from window structure.
1765 (set_window_height, set_window_width, change_window_heights)
1766 (Fdelete_window): Remove prototypes.
1767 (resize_frame_windows): Remove duplicate declaration.
1768
440a42e3
EZ
17692011-06-10 Eli Zaretskii <eliz@gnu.org>
1770
1771 * window.h (resize_frame_windows, resize_window_check)
1772 (delete_deletable_window, resize_root_window)
1773 (resize_frame_windows): Declare prototypes.
1774
1775 * window.c (resize_window_apply): Make definition be "static" to
1776 match the prototype.
1777
562dd5e9
MR
17782011-06-10 Martin Rudalics <rudalics@gmx.at>
1779
1780 * window.c: Remove declarations of Qwindow_size_fixed,
1781 window_min_size_1, window_min_size_2, window_min_size,
1782 size_window, window_fixed_size_p, enlarge_window, delete_window.
1783 Remove static from declaration of Qdelete_window, it's
1784 temporarily needed by Fbury_buffer.
1785 (replace_window): Don't assign orig_top_line and
1786 orig_total_lines.
1787 (Fdelete_window, delete_window): Remove. Window deletion is
1788 handled by window.el.
1789 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1790 Fdelete_window calls with calls to Qdelete_window.
1791 (Fdelete_other_windows): Remove. Deleting other windows is
1792 handled by window.el.
1793 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1794 handled in window.el.
1795 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1796 Window minimum sizes are handled in window.el.
1797 (shrink_windows, size_window, set_window_height)
1798 (set_window_width, change_window_heights, window_height)
1799 (window_width, CURBEG, CURSIZE, enlarge_window)
1800 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1801 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1802 handled in window.el.
1803 (make_dummy_parent): Rename to make_parent_window and give it a
1804 second argument horflag.
1805 (make_window): Don't set resize_proportionally any more.
1806 (Fsplit_window): Remove. Windows are split in window.el.
1807 (save_restore_action, save_restore_orig_size)
1808 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1809 Resize mini windows in window.el.
1810 (grow_mini_window, shrink_mini_window): Implement by calling
1811 Qresize_root_window_vertically, resize_window_check and
1812 resize_window_apply.
1813 (saved_window, Fset_window_configuration, save_window_save): Do
1814 not handle orig_top_line, orig_total_lines, and
1815 resize_proportionally.
1816 (window_min_height, window_min_width): Move to window.el.
1817 (keys_of_window): Move bindings for delete-other-windows,
1818 split-window, delete-window and enlarge-window to window.el.
1819
1820 * buffer.c: Temporarily extern Qdelete_window.
1821 (Fbury_buffer): Temporarily call Qdelete_window instead of
1822 Fdelete_window (Fbury_buffer will move to window.el soon).
1823
1824 * frame.c (set_menu_bar_lines_1): Remove code handling
1825 orig_top_line and orig_total_lines.
1826
1827 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1828 set_window_height but set heights directly.
1829 (change_frame_size_1): Use resize_frame_windows.
1830
1831 * xdisp.c (init_xdisp): Don't use set_window_height but set
1832 heights directly.
1833
1834 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1835 resize_frame_windows instead of change_window_heights and run
1836 run_window_configuration_change_hook.
1837
1838 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1839 instead of change_window_heights and run
1840 run_window_configuration_change_hook.
1841
1a13852e
MR
18422011-06-09 Martin Rudalics <rudalics@gmx.at>
1843
1844 * window.c (replace_window): Rename second argument REPLACEMENT to
1845 NEW. New third argument SETFLAG. Rewrite.
1846 (delete_window, make_dummy_parent): Call replace_window with
1847 third argument 1.
1848 (window_list_1): Move down in code.
1849 (run_window_configuration_change_hook): Move set_buffer part
1850 before select_frame_norecord part in order to unwind correctly.
1851 Rename count1 to count.
1852 (recombine_windows, delete_deletable_window, resize_root_window)
1853 (Fdelete_other_windows_internal)
1854 (Frun_window_configuration_change_hook, make_parent_window)
1855 (resize_window_check, resize_window_apply, Fresize_window_apply)
1856 (resize_frame_windows, Fsplit_window_internal)
1857 (Fdelete_window_internal, Fresize_mini_window_internal): New
1858 functions.
1859 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1860
f3d1777e
MR
18612011-06-08 Martin Rudalics <rudalics@gmx.at>
1862
496e208e
MR
1863 * window.h (window): Add some new members to window structure -
1864 normal_lines, normal_cols, new_total, new_normal, clone_number,
1865 splits, nest, prev_buffers, next_buffers.
1866 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1867 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1868
f3d1777e
MR
1869 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1870 Remove.
496e208e
MR
1871 (make_dummy_parent): Set new members of windows structure.
1872 (make_window): Move down in code. Handle new members of window
1873 structure.
1874 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1875 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1876 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1877 (Fset_window_prev_buffers, Fwindow_next_buffers)
1878 (Fset_window_next_buffers, Fset_window_clone_number): New
1879 functions.
1880 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1881 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1882 Doc-string fixes.
1883 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1884 Argument WINDOW can be now internal window too.
1885 (Fwindow_use_time): Move up in code.
1886 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1887 Rewrite doc-string.
1888 (Fset_window_configuration, saved_window)
1889 (Fcurrent_window_configuration, save_window_save): Handle new
1890 members of window structure.
b9e809c2
MR
1891 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1892 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1893 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1894 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1895 Qget_mru_window, Qresize_root_window,
1896 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1897 Qauto_buffer_name; staticpro them.
f3d1777e 1898
abde8f8c
MR
18992011-06-07 Martin Rudalics <rudalics@gmx.at>
1900
1901 * window.c (Fwindow_total_size, Fwindow_left_column)
1902 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1903 (Fwindow_list_1): New functions.
1904 (window_box_text_cols): Replace with window_body_cols.
1905 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1906 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1907 (delete_window, Fset_window_configuration): Call
1908 delete_all_subwindows with window as argument.
1909 (delete_all_subwindows): Take a window as argument and not a
1910 structure. Rewrite.
190b47e6
MR
1911 (window_loop): Remove handling of GET_LRU_WINDOW and
1912 GET_LARGEST_WINDOW.
1913 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1914
1915 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1916 window_box_text_cols. delete_all_subwindows now takes a
1917 Lisp_Object as argument.
abde8f8c
MR
1918
1919 * indent.c (compute_motion, Fcompute_motion): Use
1920 window_body_cols instead of window_box_text_cols.
1921
fa8a67e6
MR
1922 * frame.c (delete_frame): Call delete_all_subwindows with root
1923 window as argument.
1924
a54e3482
DC
19252011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1926
1927 * fns.c (Fputhash): Document return value.
1928
60002bf5
CY
19292011-06-06 Chong Yidong <cyd@stupidchicken.com>
1930
1931 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1932
0c671da6 19332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1934
b862a52a 1935 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1936
be44ca6c
PE
1937 Check for overflow when converting integer to cons and back.
1938 * charset.c (Fdefine_charset_internal, Fdecode_char):
1939 Use cons_to_unsigned to catch overflow.
1940 (Fencode_char): Use INTEGER_TO_CONS.
1941 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1942 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1943 * data.c (long_to_cons, cons_to_long): Remove.
1944 (cons_to_unsigned, cons_to_signed): New functions.
1945 These signal an error for invalid or out-of-range values.
1946 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1947 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1948 * font.c (Ffont_variation_glyphs):
1949 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1950 * lisp.h: Include <intprops.h>.
1951 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1952 (cons_to_signed, cons_to_unsigned): New decls.
1953 (long_to_cons, cons_to_long): Remove decls.
1954 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1955 (Fprimitive_undo): Use CONS_TO_INTEGER.
1956 * xfns.c (Fx_window_property): Likewise.
1957 * xselect.c: Include <limits.h>.
1958 (x_own_selection, selection_data_to_lisp_data):
1959 Use INTEGER_TO_CONS.
1960 (x_handle_selection_request, x_handle_selection_clear)
1961 (x_get_foreign_selection, Fx_disown_selection_internal)
1962 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1963 (lisp_data_to_selection_data): Use cons_to_unsigned.
1964 (x_fill_property_data): Use cons_to_signed.
1965 Report values out of range.
1966
d1f3d2af
PE
1967 Check for buffer and string overflow more precisely.
1968 * buffer.h (BUF_BYTES_MAX): New macro.
1969 * lisp.h (STRING_BYTES_MAX): New macro.
1970 * alloc.c (Fmake_string):
1971 * character.c (string_escape_byte8):
1972 * coding.c (coding_alloc_by_realloc):
1973 * doprnt.c (doprnt):
1974 * editfns.c (Fformat):
1975 * eval.c (verror):
1976 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1977 since they may not be the same number.
1978 * editfns.c (Finsert_char):
1979 * fileio.c (Finsert_file_contents):
1980 Likewise for BUF_BYTES_MAX.
1981
dd52fcea
PE
1982 * image.c: Use ptrdiff_t, not int, for sizes.
1983 (slurp_file): Switch from int to ptrdiff_t.
1984 All uses changed.
1985 (slurp_file): Check that file size fits in both size_t (for
1986 malloc) and ptrdiff_t (for sanity and safety).
1987
7f9bbdbb
PE
1988 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1989 if b->modtime has its maximal value.
1990
dfe18f82
PE
1991 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1992
84acfcf0
PE
1993 Don't assume time_t can fit into int.
1994 * buffer.h (struct buffer.modtime): Now time_t, not int.
1995 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1996 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1997
ccd9a01a
PE
1998 Minor fixes for signed vs unsigned integers.
1999 * character.h (MAYBE_UNIFY_CHAR):
2000 * charset.c (maybe_unify_char):
2001 * keyboard.c (read_char, reorder_modifiers):
2002 XINT -> XFASTINT, since the integer must be nonnegative.
2003 * ftfont.c (ftfont_spec_pattern):
2004 * keymap.c (access_keymap, silly_event_symbol_error):
2005 XUINT -> XFASTINT, since the integer must be nonnegative.
2006 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2007 since it makes no difference and we prefer signed.
2008 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2009 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2010 nonnegative.
2011
d6d100dd
SM
20122011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2013
2014 * window.h (Fwindow_frame): Declare.
2015
2b6148e4
PE
20162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2019 (SPARE_MEMORY): Always define.
2020 (LARGE_REQUEST): Remove.
2021 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2022
f230ecc9
MR
20232011-06-06 Martin Rudalics <rudalics@gmx.at>
2024
727e958e
MR
2025 * lisp.h: Move EXFUNS for Fframe_root_window,
2026 Fframe_first_window and Fset_frame_selected_window to window.h.
2027
2028 * window.h: Move EXFUNS for Fframe_root_window,
2029 Fframe_first_window and Fset_frame_selected_window here from
2030 lisp.h.
2031
2032 * frame.c (Fwindow_frame, Fframe_first_window)
2033 (Fframe_root_window, Fframe_selected_window)
2034 (Fset_frame_selected_window): Move to window.c.
2035 (Factive_minibuffer_window): Move to minibuf.c.
2036 (Fother_visible_frames_p): New function.
2037
2038 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2039
f230ecc9
MR
2040 * window.c (decode_window, decode_any_window): Move up in code.
2041 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2042 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2043 (Fwindow_buffer): Move up and rewrite doc-string.
2044 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2045 (Fwindow_prev): New functions.
727e958e
MR
2046 (Fwindow_frame): Move here from frame.c. Accept any window as
2047 argument.
2048 (Fframe_root_window, Fframe_first_window)
2049 (Fframe_selected_window): Move here from frame.c. Accept frame
2050 or arbitrary window as argument. Update doc-strings.
2051 (Fminibuffer_window): Move up in code.
2052 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2053 (Fset_frame_selected_window): Move here from frame.c.
2054 Marginal rewrite.
727e958e
MR
2055 (Fselected_window, select_window, Fselect_window): Move up in
2056 code. Minor doc-string fixes.
f230ecc9 2057
4d09bcf6
PE
20582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2061 Do not assume that spare memory exists; that assumption is valid
2062 only if SYSTEM_MALLOC.
2063 (LARGE_REQUEST): New macro, so that the issue of large requests
2064 is separated from the issue of spare memory.
2065
810928a2
AS
20662011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2067
172418ad
AS
2068 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2069 format. (Bug#8806)
2070
43f862f7
AS
2071 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2072
810928a2
AS
2073 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2074 before statements.
2075
a059fe24
JD
20762011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2077
2078 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2079
2080 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2081
2082 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2083 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2084
989bf368
JB
20852011-06-05 Juanma Barranquero <lekktu@gmail.com>
2086
2087 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2088
4b80f674
CY
20892011-06-04 Chong Yidong <cyd@stupidchicken.com>
2090
2091 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2092 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2093 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2094 New error handlers.
4b80f674
CY
2095 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2096 Obey Vx_select_enable_clipboard_manager. Catch errors in
2097 x_clipboard_manager_save (Bug#8779).
2098 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2099 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2100
99a33b77 21012011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2102
2103 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2104
99a33b77 21052011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2106
2107 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2108 in the current matrix if keep_current_p is non-zero.
2109
8264569d
EZ
21102011-06-04 Eli Zaretskii <eliz@gnu.org>
2111
2112 * bidi.c (bidi_level_of_next_char): Fix last change.
2113
57f97249
EZ
21142011-06-03 Eli Zaretskii <eliz@gnu.org>
2115
fec2107c 2116 Support bidi reordering of text covered by display properties.
57f97249 2117
fec2107c
EZ
2118 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2119 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2120 (bidi_cache_search, bidi_cache_iterator_state)
2121 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2122 (bidi_level_of_next_char, bidi_move_to_visually_next):
2123 Support character positions inside a run of characters covered by a
fec2107c
EZ
2124 display string.
2125 (bidi_paragraph_init, bidi_resolve_explicit_1)
2126 (bidi_level_of_next_char): Call bidi_fetch_char and
2127 bidi_fetch_char_advance instead of FETCH_CHAR and
2128 FETCH_CHAR_ADVANCE.
2129 (bidi_init_it): Initialize new members.
2130 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2131 definitions.
2132 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2133 instead of using explicit *_CHAR codes.
d6d100dd
SM
2134 (bidi_resolve_explicit, bidi_resolve_weak):
2135 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2136 bidirectional text is supported only in multibyte buffers.
2137 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2138 it to initialize the frame_window_p member of struct bidi_it.
2139 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2140 (bidi_resolve_explicit, bidi_resolve_weak)
2141 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2142 bidi_it->nchars is non-positive.
2143 (bidi_level_of_next_char): Don't try to lookup the cache for the
2144 next/previous character if nothing is cached there yet, or if we
2145 were just reseat()'ed to a new position.
c40e2fb2 2146
0e14fe90
EZ
2147 * xdisp.c (set_cursor_from_row): Set start and stop points
2148 according to the row's direction when priming the loop that looks
2149 for the glyph on which to display cursor.
2150 (single_display_spec_intangible_p): Function deleted.
2151 (display_prop_intangible_p): Reimplement to call
2152 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2153 Accept 3 additional arguments needed by handle_display_spec.
2154 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2155 values: lists, `(when COND...)' forms, etc.
2156 (single_display_spec_string_p): Support property values that are
2157 lists with the argument STRING its top-level element.
2158 (display_prop_string_p): Fix the condition for processing a
2159 property that is a list to be consistent with handle_display_spec.
fec2107c 2160 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2161 last portion of handle_display_prop.
2162 (compute_display_string_pos): Accept additional argument
2163 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2164 value of a `display' property is a "replacing spec".
2165 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2166 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2167 the display property, but just return a value indicating whether
2168 the display property will replace the characters it covers.
2169 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2170 frame_window_p members of struct bidi_it.
d6d100dd
SM
2171 (compute_display_string_pos, compute_display_string_end):
2172 New functions.
fec2107c
EZ
2173 (push_it): Accept second argument POSITION, where pop_it should
2174 jump to continue iteration.
2175 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2176
fec2107c
EZ
2177 * keyboard.c (adjust_point_for_property): Adjust the call to
2178 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2179
2180 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2181 (bidi_init_it): Update prototypes.
2182 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2183 (compute_display_string_pos, compute_display_string_end):
2184 Declare prototypes.
fec2107c
EZ
2185 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2186 EMACS_INT.
fc6f18ce 2187
40087514 21882011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2189
57f53182
PE
2190 Malloc failure behavior now depends on size of allocation.
2191 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2192 * lisp.h: Change signatures accordingly.
2193 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2194 All callers changed. (Bug#8762)
2195
2196 * gnutls.c: Use Emacs's memory allocators.
2197 Without this change, the gnutls library would invoke malloc etc.
2198 directly, which causes problems on non-SYNC_INPUT hosts, and which
2199 runs afoul of improving memory_full behavior. (Bug#8761)
2200 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2201 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2202 xfree instead of the default malloc, realloc, free.
2203 (Fgnutls_boot): No need to check for memory allocation failure,
2204 since xmalloc does that for us.
2205
ac32cd99 2206 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2207 * category.c (hash_get_category_set):
2208 * ccl.c (ccl_driver):
2209 * charset.c (Fdefine_charset_internal):
2210 * charset.h (struct charset.hash_index):
2211 * composite.c (get_composition_id, gstring_lookup_cache)
2212 (composition_gstring_put_cache):
2213 * composite.h (struct composition.hash_index):
2214 * dispextern.h (struct image.hash):
2215 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2216 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2217 (hashfn_equal, hashfn_user_defined, make_hash_table)
2218 (maybe_resize_hash_table, hash_lookup, hash_put)
2219 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2220 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2221 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2222 * image.c (make_image, search_image_cache, lookup_image)
2223 (xpm_put_color_table_h):
2224 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2225 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2226 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2227 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2228 * alloc.c (allocate_vectorlike):
2229 Check for overflow in vector size calculations.
2230 * ccl.c (ccl_driver):
2231 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2232 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2233 need to be updated by these changes.
40087514
PE
2234 * fns.c (make_hash_table, maybe_resize_hash_table):
2235 Check for integer overflow with large hash tables.
0de4bb68
PE
2236 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2237 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2238 (SXHASH_REDUCE): New macro.
2239 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2240 Use it instead of discarding useful hash info with large hash values.
2241 (sxhash_float): New function.
2242 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2243 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2244 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2245 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2246 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2247 Adjust signatures to match updated version of code.
2248 (consing_since_gc): Now EMACS_INT, since a single hash table can
2249 use more than INT_MAX bytes.
2250
698d32e2
DN
22512011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2252
2253 Make it possible to build with GCC-4.6+ -O2 -flto.
2254
2255 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2256
fd6fa53f
SM
22572011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2258
2259 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2260 Call minibuffer-inactive-mode.
2261
864db017
JB
22622011-05-31 Juanma Barranquero <lekktu@gmail.com>
2263
2264 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2265 Update dependencies.
2266
2ad0baf4
DN
22672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2268
2269 * data.c (init_data): Remove code for UTS, this system is not
2270 supported anymore.
2271
4fcc2638
DN
22722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2273
2274 Don't force ./temacs to start in terminal mode.
2275
2276 * frame.c (make_initial_frame): Initialize faces in all cases, not
2277 only when CANNOT_DUMP is defined.
2278 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2279
c56e0fd5
DN
22802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2281
2282 * dispnew.c (add_window_display_history): Use const for the string
2283 pointer. Remove declaration, not needed.
2284
333d54da 22852011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2286
55d4c1b2 2287 Use 'inline', not 'INLINE'.
333d54da 2288 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2289 * alloc.c, fontset.c (INLINE): Remove.
2290 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2291 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2292 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2293 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2294 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2295
738db178
DN
22962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2297
2298 Make it possible to run ./temacs.
2299
2300 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2301 syms_of_callproc does the same thing. Remove test for
2302 "initialized", do it in the caller.
2303 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2304
620c53a6
SM
23052011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2306
2307 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2308 (read_minibuf): Use get_minibuffer.
2309 (syms_of_minibuf): Use DEFSYM.
2310 (Qmetadata): New var.
2311 * data.c (Qbuffer): Don't make it static.
2312 (syms_of_data): Use DEFSYM.
2313
e003a292
PE
23142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2317 (CCL_CODE_MIN): New macro.
2318
ed008a6d
PE
23192011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2320
3687c2ef
PE
2321 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2322
ed008a6d
PE
2323 * eval.c (Qdebug): Now static.
2324 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2325 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2326 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2327
d66c4c7c
CY
23282011-05-29 Chong Yidong <cyd@stupidchicken.com>
2329
2330 * image.c: Various fixes to ImageMagick code comments.
2331 (Fimagemagick_types): Doc fix.
2332
5fbc2025
PE
23332011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2334
0196f88a
PE
2335 Minor fixes prompted by GCC 4.6.0 warnings.
2336
2337 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2338
5fbc2025
PE
2339 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2340 (x_clipboard_manager_save_all): Move extern decl to ...
2341 * xterm.h: ... here, so that it can be checked for consistency.
2342
1dd3c2d9
CY
23432011-05-29 Chong Yidong <cyd@stupidchicken.com>
2344
2345 * xselect.c (x_clipboard_manager_save_frame)
2346 (x_clipboard_manager_save_all): New functions.
2347 (Fx_clipboard_manager_save): Lisp function deleted.
2348
2349 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2350 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2351
2352 * xterm.h: Update prototype.
2353
5ba6571d
WX
23542011-05-28 William Xu <william.xwl@gmail.com>
2355
2356 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2357 exiting (Bug#8239).
2358
3eaff834
JM
23592011-05-28 Jim Meyering <meyering@redhat.com>
2360
e1900994 2361 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2362 * fns.c (to_uchar): Define.
2363 (crypto_hash_function): Use it to convert some newly-signed
2364 variables to unsigned, to avoid sign-extension bugs. For example,
2365 without this change, (md5 "truc") would evaluate to
2366 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2367 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2368 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2369
0f6990a7
PE
23702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2371
2372 Integer overflow fixes.
c8a9ca5a 2373
08686060
PE
2374 * dbusbind.c: Serial number integer overflow fixes.
2375 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2376 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2377 to hold a serial number that is too large for a fixnum.
2378 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2379 Check for serial numbers out of range. Decode any serial number
59568bf0 2380 that was so large that it became a float. (Bug#8722)
08686060 2381
2d1fc3c7
PE
2382 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2383 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2384 Use XFASTINT rather than XUINT when numbers are nonnegative.
2385 (xd_append_arg, Fdbus_method_return_internal):
2386 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2387 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2388 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2389 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2390 (Bug#8722)
2d1fc3c7 2391
c8a9ca5a
PE
2392 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2393
519e1d69
PE
2394 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2395
30569699
PE
2396 ccl: add integer overflow checks
2397 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2398 (IN_INT_RANGE): New macros.
2399 (ccl_driver): Use them to check for integer overflow when
2400 decoding a CCL program. Many of the new checks are whether XINT (x)
2401 fits in int; it doesn't always, on 64-bit hosts. The new version
2402 doesn't catch all possible integer overflows, but it's an
847044ea 2403 improvement. (Bug#8719)
30569699 2404
c11285dc
PE
2405 * alloc.c (make_event_array): Use XINT, not XUINT.
2406 There's no need for unsigned here.
2407
fdccd48e
PE
2408 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2409 This follows up to the 2011-05-06 change that substituted uintptr_t
2410 for EMACS_INT. This case wasn't caught back then.
2411
37910ab2
PE
2412 Rework Fformat to avoid integer overflow issues.
2413 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2414 now (part of C89). Include <verify.h>.
2415 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2416 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2417 (Fformat): Avoid the prepass trying to compute sizes; it was only
2418 approximate and thus did not catch overflow reliably. Instead, walk
2419 through the format just once, formatting and computing sizes as we go,
2420 checking for integer overflow at every step, and allocating a larger
2421 buffer as needed. Keep track separately whether the format is
2422 multibyte. Keep only the most-recently calculated precision, rather
2423 than them all. Record whether each argument has been converted to
2424 string. Use EMACS_INT, not int, for byte and char and arg counts.
2425 Support field widths and precisions larger than INT_MAX. Avoid
2426 sprintf's undefined behavior with conversion specifications such as %#d
2427 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2428 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2429 formatting out-of-range floating point numbers with int
9173deec 2430 formats. (Bug#8668)
37910ab2 2431
2e6578fb
PE
2432 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2433
0ae6bdee
PE
2434 * data.c: Avoid integer truncation in expressions involving floats.
2435 * data.c: Include <intprops.h>.
2436 (arith_driver): When there's an integer overflow in an expression
2437 involving floating point, convert the integers to floating point
2438 so that the resulting value does not suffer from catastrophic
2439 integer truncation. For example, on a 64-bit host (* 4
2440 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2441 Do not rely on undefined behavior after integer overflow.
2442
de883a70
PE
2443 merge count_size_as_multibyte, parse_str_to_multibyte
2444 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2445 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2446 Check for integer overflow.
2447 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2448 since it's now a duplicate of the other. This is more of
2449 a character than a buffer op, so better that it's in character.c.
2450 * fns.c, print.c: Adjust to above changes.
2451
2ff916cb
PE
24522011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2453
2454 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2455
f1b54466
PE
24562011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2457
fb1ac845
PE
2458 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2459 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2460 (x_clipboard_manager_save): Now static.
2461 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2462
f1b54466
PE
2463 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2464 (crypto_hash_function): Now static.
2465 Fix pointer signedness problems. Avoid unnecessary initializations.
2466
a9f737ee
CY
24672011-05-27 Chong Yidong <cyd@stupidchicken.com>
2468
2469 * termhooks.h (Vselection_alist): Make it terminal-local.
2470
2471 * terminal.c (create_terminal): Initialize it.
2472
2473 * xselect.c: Support for clipboard managers.
2474 (Vselection_alist): Move to termhooks.h as terminal-local var.
2475 (LOCAL_SELECTION): New macro.
2476 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2477 (symbol_to_x_atom): Remove gratuitous arg.
2478 (x_handle_selection_request, lisp_data_to_selection_data)
2479 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2480 (x_own_selection, x_get_local_selection, x_convert_selection):
2481 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2482 (some_frame_on_display): Delete unused function.
2483 (Fx_own_selection_internal, Fx_get_selection_internal)
2484 (Fx_disown_selection_internal, Fx_selection_owner_p)
2485 (Fx_selection_exists_p): New optional frame arg.
2486 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2487 (x_handle_selection_clear): Don't treat other terminals with the
2488 same keyboard specially. Use the terminal-local Vselection_alist.
2489 (x_clear_frame_selections): Use Frun_hook_with_args.
2490
2491 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2492
2493 * xterm.h: Add support for those atoms.
2494
e067f0c1
CY
24952011-05-26 Chong Yidong <cyd@stupidchicken.com>
2496
2497 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2498 (converted_selections, conversion_fail_tag): New global variables.
2499 (x_selection_request_lisp_error): Free the above.
2500 (x_get_local_selection): Remove unnecessary code.
2501 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2502 of converted selections stored in converted_selections.
2503 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2504 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2505 (x_convert_selection): New function.
2506 (x_handle_selection_event): Simplify.
2507 (x_get_foreign_selection): Don't ignore incoming requests while
2508 waiting for an answer; this will fail when we implement
2509 SAVE_TARGETS, and seems unnecessary anyway.
2510 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2511 (Vx_sent_selection_functions): Doc fix.
2512
0f4aebc0
LL
25132011-05-26 Leo Liu <sdl.web@gmail.com>
2514
2515 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2516
e61124cd
YM
25172011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2518
2519 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2520
2521 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2522 for fringe update if it has periodic bitmap.
ac389d0c 2523 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2524 and fringe_bitmap_periodic_p.
2525
2526 * fringe.c (get_fringe_bitmap_data): New function.
2527 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2528 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2529 row. Mark glyph row for fringe update if periodicity changed.
2530
2531 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2532 for fringe update unless it has periodic bitmap.
2533
f16d9837
KH
25342011-05-25 Kenichi Handa <handa@m17n.org>
2535
2536 * xdisp.c (get_next_display_element): Set correct it->face_id for
2537 a static composition.
2538
e1b90ef6
LL
25392011-05-24 Leo Liu <sdl.web@gmail.com>
2540
2541 * deps.mk (fns.o):
2542 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2543
2544 * fns.c (crypto_hash_function, Fsha1): New function.
2545 (Fmd5): Use crypto_hash_function.
2546 (syms_of_fns): Add Ssha1.
2547
7400048f
PE
25482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 * gnutls.c: Remove unused macros.
2551 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2552 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2553 Remove macros that are defined and never used.
2554 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2555
abb71cf4
CY
25562011-05-22 Chong Yidong <cyd@stupidchicken.com>
2557
2558 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2559 (Fx_get_selection_internal): Minor cleanup.
2560 (Fx_own_selection_internal): Rename arguments for consistency with
2561 select.el.
2562
6307db39
PE
25632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2564
2565 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2566
f3d4e0a4
CY
25672011-05-22 Chong Yidong <cyd@stupidchicken.com>
2568
2569 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2570
4d8ade89
YM
25712011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2572
2573 * dispnew.c (scrolling_window): Don't exclude the case that the
2574 last enabled row in the desired matrix touches the bottom boundary.
2575
32078c8d
GM
25762011-05-21 Glenn Morris <rgm@gnu.org>
2577
2578 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2579 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2580 and add some more files.
32078c8d 2581
7285dc67
EZ
25822011-05-20 Eli Zaretskii <eliz@gnu.org>
2583
2584 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2585 report_file_error introduced by the change from 2011-05-07.
2586
89d1bd22
PE
25872011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 * systime.h (Time): Define only if emacs is defined.
2590 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2591 where the include path doesn't have X11/X.h by default. See
2592 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2593
e23640bb 25942011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2595
2596 * composite.c (find_automatic_composition): Fix previous change.
2597
b9704ad9
GM
25982011-05-20 Glenn Morris <rgm@gnu.org>
2599
2600 * lisp.mk: New file, split from Makefile.in.
2601 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2602 (shortlisp): Remove.
2603 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2604
4a720484
GM
26052011-05-19 Glenn Morris <rgm@gnu.org>
2606
2607 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2608 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2609 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2610 (lisp): Set the order to that of loadup.el.
2611 (shortlisp): Make it a copy of $lisp.
2612 (SOME_MACHINE_LISP): Remove.
2613 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2614 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2615
a28d4396
KH
26162011-05-18 Kenichi Handa <handa@m17n.org>
2617
2618 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2619 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2620 (find_automatic_composition): Mostly rewrite for efficiency.
2621
a2b1fa8e
JB
26222011-05-18 Juanma Barranquero <lekktu@gmail.com>
2623
2624 * makefile.w32-in: Update dependencies.
2625
8e1f5610
CS
26262011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2627
2628 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2629 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2630
7025ee00 26312011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2632
cdfa6eab
PE
2633 Fix some integer overflow issues, such as string length overflow.
2634
06d6db33
PE
2635 * insdel.c (count_size_as_multibyte): Check for string overflow.
2636
2b4560a8
PE
2637 * character.c (lisp_string_width): Check for string overflow.
2638 Use EMACS_INT, not int, for string indexes and lengths; in
2639 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2640 the resulting string length overflows an EMACS_INT; instead,
2641 report a string overflow if no precision given. When checking for
2642 precision exhaustion, use a check that cannot possibly have
2643 integer overflow. (Bug#8675)
2644 * character.h (lisp_string_width): Adjust to new signature.
2645
cb93f9be
PE
2646 * alloc.c (string_overflow): New function.
2647 (Fmake_string): Use it. This doesn't change behavior, but saves
2648 a few bytes and will simplify future changes.
2649 * character.c (string_escape_byte8): Likewise.
2650 * lisp.h (string_overflow): New decl.
2651
1a1f3366
PE
2652 Fixups, following up to the user-interface timestamp change.
2653 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2654 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2655 * msdos.c (mouse_get_pos): Likewise.
2656 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2657 * w32gui.h (Time): Define by including "systime.h" rather than by
2658 declaring it ourselves. (Bug#8664)
2659
d4e3e4d3
PE
2660 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2661 * image.c (clear_image_cache): Likewise.
2662
f6a24d19
PE
2663 * term.c (term_mouse_position): Don't assume time_t wraparound.
2664
08dc5ae6
PE
2665 Be more systematic about user-interface timestamps.
2666 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2667 and sometimes 'EMACS_UINT', to represent these timestamps.
2668 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2669 This makes the code easier to follow, and makes it easier to catch
2670 integer overflow bugs such as Bug#8664.
2671 * frame.c (Fmouse_position, Fmouse_pixel_position):
2672 Use Time, not unsigned long, for user-interface timestamps.
2673 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2674 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2675 * keyboard.h (last_event_timestamp): Likewise.
2676 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2677 * menu.h (xmenu_show): Likewise.
2678 * term.c (term_mouse_position): Likewise.
2679 * termhooks.h (struct input_event.timestamp): Likewise.
2680 (struct terminal.mouse_position_hook): Likewise.
2681 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2682 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2683 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2684 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2685 what it was before.
2686 * menu.h, termhooks.h: Include "systime.h", for Time.
2687
8e55734a
PE
2688 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2689 Don't assume that the difference between two unsigned long values
2690 can fit into an integer. At this point, we know button_down_time
2691 <= event->timestamp, so the difference must be nonnegative, so
2692 there's no need to cast the result if double-click-time is
2693 nonnegative, as it should be; check that it's nonnegative, just in
2694 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2695 apart (about 25 days). (Bug#8664)
8e55734a 2696
841f1b75 2697 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2698 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2699
3e26f69c
PE
2700 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2701 that always fit in int. Use a sentinel instead of a counter, to
2702 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2703 * frame.h (struct frame): Use int for menu_bar_items_used
2704 instead of EMACS_INT, since it always fits in int.
3e26f69c 2705
5cc152c0
PE
2706 * menu.c (grow_menu_items): Check for int overflow.
2707
d89eb65e
PE
2708 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2709
5235bd3e
PE
2710 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2711 Before, the code was not consistent. These values cannot exceed
2712 2**31 - 1 so there's no need to make them unsigned.
2713 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2714 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2715 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2716 as modifiers.
2717 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2718
bc827e23
PE
2719 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2720 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2721 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2722 presumably because the widths might not match.
2723
78eb494e
PE
2724 * window.c (size_window): Avoid needless test at loop start.
2725
04f2d78b
CB
27262011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2727
2728 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2729
d2fc7e3d 27302011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2731
2732 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2733
d2fc7e3d 27342011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2735
2736 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2737 `width' to `bar_area_x' and `bar_area_width', respectively.
2738 (x_scroll_run): Take account of fringe background extension.
2739
04f2d78b
CB
2740 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2741 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2742 `bar_area_width', respectively.
2743 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2744 background extension.
2745
79b70037
GM
27462011-05-10 Jim Meyering <meyering@redhat.com>
2747
2748 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2749
2f142cc5
JB
27502011-05-10 Juanma Barranquero <lekktu@gmail.com>
2751
2752 * image.c (Finit_image_library): Return t for built-in image types,
2753 like pbm and xbm. (Bug#8640)
2754
57679c86
AS
27552011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2756
2757 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2758
888c9e86
EZ
27592011-05-07 Eli Zaretskii <eliz@gnu.org>
2760
b0512a1d
EZ
2761 * w32console.c (Fset_screen_color): Doc fix.
2762 (Fget_screen_color): New function.
2763 (syms_of_ntterm): Defsubr it.
2764
7285dc67
EZ
2765 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2766 unlink the temporary file if Fcall_process didn't create it in the
2767 first place.
2768 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2769 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2770 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2771 cue to call_process_cleanup not to close that handle.
2772
4d3fcc8e
BK
27732011-05-07 Ben Key <bkey76@gmail.com>
2774
2775 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2776 one of two shell specific rules, either bootstrap-temacs-CMD or
2777 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2778 to the previous implementation of the bootstrap-temacs rule.
2779 The bootstrap-temacs-CMD rule is similar to the previous
2780 implementation of the bootstrap-temacs rule except that it
2781 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2782 variable.
2783
2784 These changes, along with some changes to nt/configure.bat,
2785 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2786 earlier fix to add support for --cflags and --ldflags options
2787 that include quotes so that it works whether make uses cmd or
2788 sh as the shell.
2789
b4289b64
MA
27902011-05-06 Michael Albinus <michael.albinus@gmx.de>
2791
2792 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2793 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2794 is a constant.
2795 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2796 a string. Handle both cases.
2797 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2798 (Fdbus_register_method): Use Qinvalid_function.
2799
af4c0e28
JB
28002011-05-06 Juanma Barranquero <lekktu@gmail.com>
2801
2802 * makefile.w32-in: Update dependencies.
2803 (LISP_H): Add inttypes.h and stdin.h.
2804 (PROCESS_H): Add unistd.h.
2805
c51453d9
EZ
28062011-05-06 Eli Zaretskii <eliz@gnu.org>
2807
2808 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2809 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2810
8ff0ac3c 28112011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2812
4c4b566b
PE
2813 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2814
aab2b9b5
PE
2815 * term.c (vfatal): Remove stray call to va_end.
2816 It's not needed and the C Standard doesn't allow it here anyway.
2817
c378da0b
PE
2818 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2819 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2820
288b08c7
PE
2821 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2822 bytes.
2823
e3601888
PE
2824 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2825
db6c0e74
PE
2826 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2827
dd5963ea
PE
2828 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2829
88c9450f
PE
2830 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2831
2f9442b8
PE
2832 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2833
c032b5f8
PE
2834 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2835 * charset.c (Fdefine_charset_internal): Don't initialize
2836 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2837 32-bit int (Bug#8600).
a108c10b
PE
2838
2839 * lread.c (read_integer): Be more consistent with string-to-number.
2840 Use string_to_number to do the actual conversion; this avoids
2841 rounding errors and fixes some other screwups. Without this fix,
2842 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2843 (digit_to_number): Move earlier, for benefit of read_integer.
2844 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2845 not a digit in any supported base. (Bug#8602)
a108c10b 2846
ad5f9eea
PE
2847 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2848
aec1708a
PE
2849 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2850 to match comment at start of function. This also removes a
2851 GCC warning about overflow in a 32+64-bit port.
2852
47be4ab5
PE
2853 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2854
371cac43
PE
2855 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2856 Reported by Stefan Monnier in
2857 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2858 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2859 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2860
d01a7826
PE
2861 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2862 (EMACS_UINTPTR): Likewise, with uintptr_t.
2863
7fd47d5c
PE
2864 * lisp.h: Prefer 64-bit EMACS_INT if available.
2865 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2866 on 32-bit hosts that have 64-bit int, so that they can access
2867 large files.
122b0c86
PE
2868 However, temporarily disable this change unless the temporary
2869 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2870
8727937b
PE
2871 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2872
8ac068ac
PE
2873 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2874 This removes an assumption that EMACS_INT and long are the same
2875 width as pointers. The assumption is true for Emacs porting targets
2876 now, but we want to make other targets possible.
2877 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2878 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2879 In the rest of the code, change types of integers that hold casted
2880 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2881 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2882 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2883 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2884 No need to cast type when ORing.
2885 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2886 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2887 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2888 assume EMACS_INT is the same width as char *.
2889 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2890 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2891 Remove no-longer-needed casts.
2892 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2893 (xg_tool_bar_help_callback, xg_make_tool_item):
2894 Use EMACS_INTPTR to hold an integer
2895 that will be cast to void *; this can avoid a GCC warning
2896 if EMACS_INT is not the same width as void *.
2897 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2898 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2899 (current_message_1, set_message_1):
2900 Use a local to convert to proper width without a cast.
2901 * xmenu.c (dialog_selection_callback): Likewise.
2902
ede49d71
PE
2903 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2904 Also, don't assume VALBITS / RAND_BITS is less than 5,
2905 and don't rely on undefined behavior when shifting a 1 left into
2906 the sign bit.
2907 * lisp.h (get_random): Change signature to match.
2908
2f30ecd0
PE
2909 * lread.c (hash_string): Use size_t, not int, for hash computation.
2910 Normally we prefer signed values; but hashing is special, because
2911 it's better to use unsigned division on hash table sizes so that
2912 the remainder is nonnegative. Also, size_t is the natural width
2913 for hashing into memory. The previous code used 'int', which doesn't
2914 retain enough info to hash well into very large tables.
2915 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2916
2a866e7b
PE
2917 * dbusbind.c: Don't possibly lose pointer info when converting.
2918 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2919 Use XPNTR rather than XHASH, so that the high-order bits of
2920 the pointer aren't lost when converting through void *.
2921
51639eac
PE
2922 * eval.c (Fautoload): Don't double-shift a pointer.
2923
92394119
PE
2924 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2925
dbdb9a7c
JB
29262011-05-06 Juanma Barranquero <lekktu@gmail.com>
2927
2928 * gnutls.c (DEF_GNUTLS_FN):
2929 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2930
db7a0b4f
AS
29312011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2932
2933 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2934 marker. (Bug#8610)
2935
f7ff1b0f 29362011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2937
2938 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2939 New version that can reserve upto 2GB of heap space.
2940
f7ff1b0f 29412011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2942
2943 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2944
639c109b
TZ
29452011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2946
2947 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2948 `gnutls_certificate_set_x509_key_file'.
2949
d2127135
JB
29502011-05-05 Juanma Barranquero <lekktu@gmail.com>
2951
2952 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2953 Update dependencies.
2954
e968f4f3
JB
29552011-05-04 Juanma Barranquero <lekktu@gmail.com>
2956
2957 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2958 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2959 Remove unused parameter `fildes'.
2960 * process.c (read_process_output, send_process): Don't pass it.
2961
84d358f0
JB
29622011-05-04 Juanma Barranquero <lekktu@gmail.com>
2963
2964 Fix previous change: the library cache is defined in w32.c.
2965 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2966 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2967
0898ca10
JB
29682011-05-04 Juanma Barranquero <lekktu@gmail.com>
2969
2970 Implement dynamic loading of GnuTLS on Windows.
2971
2972 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2973 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2974 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2975 Declare.
2976
2977 * gnutls.c (Qgnutls_dll): Define.
2978 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2979 (gnutls_*): Declare function pointers.
2980 (init_gnutls_functions): New function to initialize function pointers.
2981 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2982 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2983 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2984 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2985 (emacs_gnutls_write, emacs_gnutls_read)
2986 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2987 (Fgnutls_available_p): New function.
2988 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2989 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2990 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2991
2992 * image.c: Include w32.h.
2993 (Vimage_type_cache): Delete.
2994 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2995 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2996 (w32_delayed_load): Move to w32.c.
2997
2998 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2999
3000 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3001 (w32_delayed_load): Move from image.c. When loading a library, record
3002 its filename in the :loaded-from property of the library id.
3003 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3004 Initialize and staticpro them.
3005 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3006
3007 * process.c: Include lisp.h before w32.h, not after.
3008 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3009 instead of gnutls_record_check_pending.
3010
3011 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3012
ff4de4aa
TZ
30132011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3014
3015 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3016 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3017 as passed in.
3018
abe95abb
JD
30192011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3020
3021 * xterm.c (x_set_frame_alpha): Do not set property on anything
3022 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3023
e16e55d4
JB
30242011-05-02 Juanma Barranquero <lekktu@gmail.com>
3025
3026 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3027
bafcf6a5
JB
30282011-05-02 Juanma Barranquero <lekktu@gmail.com>
3029
3030 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3031 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3032 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3033 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3034 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3035 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3036 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3037 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3038 (Qgnutls_bootprop_callbacks_verify): Make static.
3039
e7a6747f
AS
30402011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3041
19ed11ba
AS
3042 * callproc.c: Indentation fixup.
3043
e7a6747f 3044 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3045 (wait_for_termination, interruptible_wait_for_termination):
3046 Move after wait_for_termination_1.
e7a6747f 3047
1ef14cb4
LMI
30482011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3049
3050 * sysdep.c (interruptible_wait_for_termination): New function
3051 which is like wait_for_termination, but allows keyboard
3052 interruptions.
3053
3054 * callproc.c (Fcall_process): Add (:file "file") as an option for
3055 the STDOUT buffer.
3056 (Fcall_process_region): Ditto.
3057
330d880c
EZ
30582011-04-30 Eli Zaretskii <eliz@gnu.org>
3059
8db90b73
EZ
3060 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3061 rather than `XVECTOR (FOO)->size'.
3062
330d880c
EZ
3063 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3064 inttypes.h, as a gnulib replacement is used if it not available in
3065 system headers.
3066
15cbd324
EZ
30672011-04-21 Eli Zaretskii <eliz@gnu.org>
3068
3069 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3070 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3071 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3072
3073 * coding.c (coding_alloc_by_realloc): Error out if destination
3074 will grow beyond MOST_POSITIVE_FIXNUM.
3075 (decode_coding_emacs_mule): Abort if there isn't enough place in
3076 charbuf for the composition carryover bytes. Reserve an extra
3077 space for up to 2 characters produced in a loop.
3078 (decode_coding_iso_2022): Abort if there isn't enough place in
3079 charbuf for the composition carryover bytes.
3080
30812011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3082
ae940cca
EZ
3083 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3084 aborting when %lld or %lll format is passed.
3085 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3086 %llo or %llx format is passed. (Bug#8545)
3087
03ab8921
EZ
3088 * window.c (window_scroll_line_based): Use a marker instead of
3089 simple variables to record original value of point. (Bug#7952)
3090
afda1437
EZ
3091 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3092 produced by %s or %c overflows available buffer space. (Bug#8545)
3093
f76dee0c
PE
30942011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3097 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3098
fdc5744d
JB
30992011-04-28 Juanma Barranquero <lekktu@gmail.com>
3100
3101 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3102
638f053a
JB
31032011-04-28 Juanma Barranquero <lekktu@gmail.com>
3104
3105 * keyboard.c (Qdelayed_warnings_hook): Define.
3106 (command_loop_1): Run `delayed-warnings-hook'
3107 if Vdelayed_warnings_list is non-nil.
3108 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3109 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3110
d178f871
EZ
31112011-04-28 Eli Zaretskii <eliz@gnu.org>
3112
3113 * doprnt.c (doprnt): Don't return value smaller than the buffer
3114 size if the message was truncated. (Bug#8545).
3115
b124fd93
JB
31162011-04-28 Juanma Barranquero <lekktu@gmail.com>
3117
3118 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3119 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3120
e810457d
PE
31212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3124
ea51cceb
JB
31252011-04-27 Juanma Barranquero <lekktu@gmail.com>
3126
3127 * makefile.w32-in: Update dependencies.
3128
94dcfacf
EZ
31292011-04-27 Eli Zaretskii <eliz@gnu.org>
3130
3131 Improve `doprnt' and its usage. (Bug#8545)
3132 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3133 `format_end'. Remove support for %l as a conversion specifier.
3134 Don't use xrealloc. Improve diagnostics when the %l size modifier
3135 is used. Update the commentary.
3136
3137 * eval.c (verror): Simplify calculation of size_t.
3138
3139 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3140 messages.
3141
f61f41d7
PE
31422011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3143
3144 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3145 change.
3146
96fb4434
PE
31472011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3150 This makes this file independent of the recent pseudovector change.
3151
671875da 31522011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3153
69e9b5a3
PE
3154 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3155
b5f869a7 3156 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3157 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3158 Remove unused local.
c8926152 3159 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3160
841a1577 3161 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3162 GCC 4.6.0 optimizes based on type-based alias analysis.
3163 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3164 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3165 != &v->size, and therefore "v->size = 1; b->size = 2; return
3166 v->size;" must therefore return 1. This assumption is incorrect
3167 for Emacs, since it type-puns struct Lisp_Vector * with many other
3168 types. To fix this problem, this patch adds a new type struct
f904488f 3169 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3170 and pseudovectors, and helps optimizing compilers not get fooled
3171 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3172 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3173 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3174 the size member.
eab3844f
PE
3175 (XSETPVECTYPE): Rewrite in terms of new macro.
3176 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3177 This is a bit clearer, and further avoids the possibility of
3178 undesirable aliasing.
3179 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3180 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3181 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3182 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3183 (ASIZE): Now uses header.size rather than size.
3184 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3185 to avoid the hassle of writing XVECTOR (foo)->header.size.
3186 (struct vectorlike_header): New type.
eab3844f
PE
3187 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3188 object, to help avoid aliasing.
3189 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3190 (SUBRP): Likewise, since Lisp_Subr is a special case.
3191 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3192 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3193 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3194 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3195 changed to be "header.size" and "header.next".
3196 * buffer.h (struct buffer): Likewise.
3197 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3198 * frame.h (struct frame): Likewise.
3199 * process.h (struct Lisp_Process): Likewise.
3200 * termhooks.h (struct terminal): Likewise.
3201 * window.c (struct save_window_data, struct saved_window): Likewise.
3202 * window.h (struct window): Likewise.
3203 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3204 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3205 * buffer.c (init_buffer_once): Likewise.
3206 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3207 special case.
3208 * process.c (Fformat_network_address): Use local var for size,
3209 for brevity.
3210
0df1eac5
PE
3211 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3212
847ab9d1 3213 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3214 * data.c (atof): Remove decl; no longer used or needed.
3215 (digit_to_number): Move to lread.c.
3216 (Fstring_to_number): Use new string_to_number function, to be
3217 consistent with how the Lisp reader treats infinities and NaNs.
3218 Do not assume that floating-point numbers represent EMACS_INT
3219 without losing information; this is not true on most 64-bit hosts.
3220 Avoid double-rounding errors, by insisting on integers when
3221 parsing non-base-10 numbers, as the documentation specifies.
3222 * lisp.h (string_to_number): New decl, replacing ...
3223 (isfloat_string): Remove.
bc0a5c13 3224 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3225 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3226 appears to have been a coding error. Similarly, do not accept
3227 strings like +-1e0 as floating point numbers. Do not report
3228 overflow for integer overflows unless the base is not 10 which
3229 means we have no simple and reliable way to continue.
3230 Break out the floating-point parsing into a new
3231 function string_to_number, so that Fstring_to_number parses
3232 floating point numbers consistently with the Lisp reader.
04f2d78b 3233 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3234 (E_CHAR, EXP_INT): Remove, replacing with ...
3235 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3236 (string_to_number): New function, replacing isfloat_string.
3237 This function checks for valid syntax and produces the resulting
3238 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3239 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3240 so that overflow for non-base-10 numbers is reported only when
3241 there's no portable and simple way to convert to floating point.
452f4150 3242
67769ffc
PE
3243 * textprop.c (set_text_properties_1): Rewrite for clarity,
3244 and to avoid GCC warning about integer overflow.
3245
c20db43f
PE
3246 * intervals.h (struct interval): Use EMACS_INT for members
3247 where EMACS_UINT might cause problems. See
3248 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3249 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3250 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3251 All uses changed.
37aa2f85
PE
3252 (offset_intervals): Tell GCC not to worry about length overflow
3253 when negating a negative length.
c20db43f 3254
2538aa2f
PE
3255 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3256 (overrun_check_free): Likewise.
3257
f2d3008d
PE
3258 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3259 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3260 word size.
3261
ec8df744
PE
3262 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3263 (gnutls_make_error): Rename local to avoid shadowing.
3264 (gnutls_emacs_global_deinit): ifdef out; not used.
3265 (Fgnutls_boot): Use const for pointer to readonly storage.
3266 Comment out unused local. Fix pointer signedness problems.
3267
640ee02d
PE
3268 * lread.c (openp): Don't stuff size_t into an 'int'.
3269 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3270 about possible signed overflow.
3271
6048fb2a
PE
3272 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3273 (GDK_KEY_g): Don't define if already defined.
3274 (xg_prepare_tooltip): Avoid pointer signedness problem.
3275 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3276
fa3c87e1
PE
3277 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3278 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3279
2172544b
PE
3280 * xfns.c (Fx_window_property): Simplify a bit,
3281 to make a bit faster and to avoid GCC 4.6.0 warning.
3282 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3283
9b821a21
PE
3284 * fns.c (internal_equal): Don't assume size_t fits in int.
3285
3c616cfa
PE
3286 * alloc.c (compact_small_strings): Tighten assertion a little.
3287
c2982e87
PE
3288 Replace pEd with more-general pI, and fix some printf arg casts.
3289 * lisp.h (pI): New macro, generalizing old pEd macro to other
3290 conversion specifiers. For example, use "...%"pI"d..." rather
3291 than "...%"pEd"...".
3292 (pEd): Remove. All uses replaced with similar uses of pI.
3293 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3294 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3295 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3296 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3297 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3298 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3299 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3300 64-bit hosts.
3301 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3302 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3303 * print.c (safe_debug_print, print_object): Likewise.
3304 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3305 to int.
6f04d126
PE
3306 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3307 avoiding the 0 flag, which is not portable.
c2982e87
PE
3308 * process.c (Fmake_network_process): Use pI to avoid cast.
3309 * region-cache.c (pp_cache): Likewise.
3310 * xdisp.c (decode_mode_spec): Likewise.
3311 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3312 behavior on 64-bit hosts with printf arg.
6f04d126 3313 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3314 (x_stop_queuing_selection_requests): Likewise.
3315 (x_get_window_property): Don't truncate byte count to an 'int'
3316 when tracing.
0b432f21 3317
5e073ec7
PE
3318 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3319 here, since it parses constructs like leading '-' and spaces,
3320 which are not wanted; and it overflows with large numbers.
3321 Instead, simply match F[0-9]+, which is what is wanted anyway.
3322
36372bf9
PE
3323 * alloc.c: Remove unportable assumptions about struct layout.
3324 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3325 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3326 (allocate_vectorlike, make_pure_vector): Use the new macros,
3327 plus offsetof, to remove unportable assumptions about struct layout.
3328 These assumptions hold on all porting targets that I know of, but
3329 they are not guaranteed, they're easy to remove, and removing them
3330 makes further changes easier.
3331
0b432f21
PE
3332 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3333 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3334 (string_overrun_cookie): Now const. Use initializers that
3335 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3336 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3337 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3338 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3339 multiple of sizeof (EMACS_INT); it need not be, if
3340 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3341 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3342
895009e1
JB
33432011-04-26 Juanma Barranquero <lekktu@gmail.com>
3344
3345 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3346
6a7a1b0b
TZ
33472011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3348
3349 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3350 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3351 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3352
841a1577 33532011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3354
3355 * lisp.h (Qdebug): List symbol.
895009e1 3356 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3357 * keyboard.c (debug-on-event): New variable.
3358 (handle_user_signal): Break into debugger when debug-on-event
3359 matches the current signal symbol.
3360
f2d3ba6f
DN
33612011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3362
3363 * alloc.c (check_sblock, check_string_bytes)
3364 (check_string_free_list): Convert to standard C.
3365
42ce4c63
TZ
33662011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3367
3368 * w32.c (emacs_gnutls_push): Fix typo.
3369
825cd63c
EZ
33702011-04-25 Eli Zaretskii <eliz@gnu.org>
3371
fb11d64d
EZ
3372 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3373 "cast to pointer from integer of different size".
3374
825cd63c
EZ
3375 Improve doprnt and its use in verror. (Bug#8545)
3376 * doprnt.c (doprnt): Document the set of format control sequences
3377 supported by the function. Use SAFE_ALLOCA instead of always
3378 using `alloca'.
3379
3380 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3381 is one byte too soon. Don't use xrealloc; instead xfree and
3382 xmalloc anew.
3383
e061a11b
TZ
33842011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3385
3386 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3387 callbacks stage.
3388
3389 * gnutls.c: Renamed global_initialized to
3390 gnutls_global_initialized. Added internals for the
3391 :verify-hostname-error, :verify-error, and :verify-flags
3392 parameters of `gnutls-boot' and documented those parameters in the
3393 docstring. Start callback support.
9173deec
JB
3394 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3395 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3396 on error. Return error code.
e061a11b
TZ
3397 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3398 (emacs_gnutls_read): Likewise.
3399 (Fgnutls_boot): Return handshake error code.
3400 (emacs_gnutls_handle_error): New function.
3401 (wsaerror_to_errno): Likewise.
3402
3403 * w32.h (emacs_gnutls_pull): Add prototype.
3404 (emacs_gnutls_push): Likewise.
3405
3406 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3407 (emacs_gnutls_push): Likewise.
3408
34092011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3410
3411 * process.c (wait_reading_process_output): Check if GnuTLS
3412 buffered some data internally if no FDs are set for TLS
3413 connections.
3414
3415 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3416 (LIBS): Link to USER_LIBS.
3417 ($(BLD)/gnutls.$(0)): New target.
3418
fa6996bc
EZ
34192011-04-24 Eli Zaretskii <eliz@gnu.org>
3420
eb35682e
EZ
3421 * xdisp.c (handle_single_display_spec): Rename the
3422 display_replaced_before_p argument into display_replaced_p, to
3423 make it consistent with the commentary. Fix typos in the
3424 commentary.
3425
e2ad650c
EZ
3426 * textprop.c (syms_of_textprop): Remove dead code.
3427 (copy_text_properties): Delete obsolete commentary about an
3428 interface that was deleted long ago. Fix typos in the description
3429 of arguments.
3430
1b2de274
EZ
3431 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3432 to changes in oldXMenu/XMenu.h from 2011-04-16.
3433 <menu_help_message, prev_menu_help_message>: Constify.
3434 (IT_menu_make_room): menu->help_text is now `const char **';
3435 adjust.
3436
3437 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3438 to changes in oldXMenu/XMenu.h from 2011-04-16.
3439 (struct XMenu): Declare `help_text' `const char **'.
3440
3441 * xfaces.c <Qunspecified>: Make extern again.
3442
3443 * syntax.c: Include sys/types.h before including regex.h, as
3444 required by Posix.
3445
762b15be
EZ
3446 * doc.c (get_doc_string): Improve the format passed to `error'.
3447
3448 * doprnt.c (doprnt): Improve commentary.
3449
3450 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3451
3452 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3453 them with etags.
3454
f1052e5d
EZ
3455 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3456 changes in globals.h immediately force recompilation.
762b15be
EZ
3457 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3458 $(CURDIR)/s/ms-w32.h.
3459 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3460
fa6996bc
EZ
3461 * character.c (Fchar_direction): Function deleted.
3462 (syms_of_character): Don't defsubr it.
3463 <char-direction-table>: Deleted.
3464
e6c3da20
EZ
34652011-04-23 Eli Zaretskii <eliz@gnu.org>
3466
3467 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3468 * doprnt.c: Include limits.h.
3469 (SIZE_MAX): New macro.
04f2d78b
CB
3470 (doprnt): Return a size_t value. 2nd arg is now size_t.
3471 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3472 Improve overflow protection. Support `l' modifier for integer
3473 conversions. Support %l conversion. Don't assume an EMACS_INT
3474 argument for integer conversions and for %c.
3475
3476 * lisp.h (doprnt): Restore prototype.
3477
3478 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3479 $(SRC)/character.h.
3480
3481 * Makefile.in (base_obj): Add back doprnt.o.
3482
3483 * deps.mk (doprnt.o): Add back prerequisites.
3484 (callint.o): Depend on character.h.
3485
3486 * eval.c (internal_lisp_condition_case): Include the handler
3487 representation in the error message.
3488 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3489 when breaking from the loop.
3490
3491 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3492
3493 * callint.c (Fcall_interactively): When displaying error message
3494 about invalid control letter, pass the character's codepoint, not
3495 a pointer to its multibyte form. Improve display of the character
3496 in octal and display also its hex code.
3497
3498 * character.c (char_string): Use %x to display the (unsigned)
3499 codepoint of an invalid character, to avoid displaying a bogus
3500 negative value.
3501
3502 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3503 `error', not SYMBOL_NAME itself.
3504
3505 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3506 character arguments to `error'.
3507
3508 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3509 to `error' in error message about FINAL_CHAR argument. Make sure
3510 FINAL_CHAR is a character, and use %c when it is passed as
3511 argument to `error'.
3512
4ffd0d6b 35132011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3514
3515 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3516
3517 * w32.c: Include <time.h>.
3518 (sys_localtime): New function.
3519
4ffd0d6b 35202011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3521
3522 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3523
4ffd0d6b 3524 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3525
4ffd0d6b 35262011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3527
4ffd0d6b
GM
3528 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3529 zombies (Bug#8467).
aac0c6e3 3530
04c56954
EZ
35312011-04-19 Eli Zaretskii <eliz@gnu.org>
3532
3533 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3534 gl_state.e_property when gl_state.object is Qt.
3535
3536 * insdel.c (make_gap_larger): Remove limitation of buffer size
3537 to <= INT_MAX.
3538
16a43933
CY
35392011-04-18 Chong Yidong <cyd@stupidchicken.com>
3540
3541 * xdisp.c (lookup_glyphless_char_display)
3542 (produce_glyphless_glyph): Handle cons cell entry in
3543 glyphless-char-display.
3544 (Vglyphless_char_display): Document it.
3545
3546 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3547 glyphless-char-display.
3548
4581706e
CY
35492011-04-17 Chong Yidong <cyd@stupidchicken.com>
3550
3551 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3552
3553 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3554
3555 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3556 definition for no-X builds.
3557
4887c6e2 35582011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3559
fd35b6f9
PE
3560 Static checks with GCC 4.6.0 and non-default toolkits.
3561
5c1ccb01
PE
3562 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3563
006c5daa
PE
3564 * process.c (keyboard_bit_set): Define only if SIGIO.
3565 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3566 (send_process): Repair possible setjmp clobbering.
3567
efc736d3
PE
3568 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3569
4e2fe2e6
PE
3570 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3571
f97334a2
PE
3572 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3573
4e75f29d
PE
3574 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3575 Define only if needed.
3576
90efadd1
PE
3577 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3578 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3579 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3580
3c647824
PE
3581 * dispextern.h (struct redisplay_interface): Rename param
3582 to avoid shadowing.
e264f262 3583 * termhooks.h (struct terminal): Likewise.
761383f4 3584 * xterm.c (xembed_send_message): Likewise.
3c647824 3585
b58c5c4a
PE
3586 * insdel.c (make_gap_smaller): Define only if
3587 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3588
cad59032
PE
3589 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3590 it.
3591
c339dc2e
PE
3592 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3593 so that we aren't warned about unused symbols.
3594
91a3e27b
PE
3595 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3596
399c71d3 3597 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3598
8ffc96f5
PE
3599 * xfns.c (x_real_positions): Mark locals as initialized.
3600
eef9bc79
PE
3601 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3602
098db9dd
PE
3603 * xterm.c: Fix problems found by static analysis with other toolkits.
3604 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3605 (x_dispatch_event): Declare static if USE_GTK, and
3606 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3607 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3608 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3609 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3610 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3611
eb18f6cc
PE
3612 * xmenu.c (menu_help_callback): Pointer type fixes.
3613 Use const pointers when pointing at readonly data. Avoid pointer
3614 signedness clashes.
3615 (FALSE): Remove unused macro.
3616 (update_frame_menubar): Remove unused decl.
3617
1fe72bf8
PE
3618 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3619
60d9e1db
PE
3620 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3621 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3622 (single_menu_item): Rename local to avoid shadowing.
3623
39261c26
PE
3624 * keyboard.c (make_lispy_event): Remove unused local var.
3625
018c5e19
PE
3626 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3627 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3628
63d2b86e
PE
3629 * bitmaps: Change bitmaps from unsigned char back to the X11
3630 compatible char. Avoid the old compiler warnings about
3631 out-of-range initializers by using, for example, '\xab' rather
3632 than 0xab.
3633
aefd87e1
PE
3634 * xgselect.c (xgselect_initialize): Check vs interface
3635 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3636
bf501fb9
PE
3637 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3638
e9829fdf
PE
3639 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3640 to read-only memory.
3641
1086c095
PE
3642 * fns.c (vector): Remove; this old hack is no longer needed.
3643
2baccd04 3644 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3645 Remove unused var.
dde42981 3646 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3647
72391843 3648 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3649
436c16df 3650 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3651 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3652 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3653
92bb796d 3654 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3655 (x_term_init): Remove local to avoid shadowing.
92bb796d 3656
764430a3 3657 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3658
3659 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3660 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3661
d1dfb56c
EZ
36622011-04-16 Eli Zaretskii <eliz@gnu.org>
3663
c4354cb4
EZ
3664 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3665
d1dfb56c
EZ
3666 Fix regex.c, syntax.c and friends for buffers > 2GB.
3667 * syntax.h (struct gl_state_s): Declare character position members
3668 EMACS_INT.
3669
3670 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3671
04f2d78b
CB
3672 * textprop.c (verify_interval_modification, interval_of):
3673 Declare arguments EMACS_INT.
d1dfb56c
EZ
3674
3675 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3676 EMACS_INT.
3677
3678 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3679
3680 * indent.c (Fvertical_motion): Local variable it_start is now
3681 EMACS_INT.
3682
3683 * regex.c (re_match, re_match_2, re_match_2_internal)
3684 (bcmp_translate, regcomp, regexec, print_double_string)
3685 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3686 (re_compile_pattern, re_exec): Declare arguments and local
3687 variables `size_t' and `ssize_t' and return values `regoff_t', as
3688 appropriate.
3689 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3690 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3691 <compile_stack_type>: `size' and `avail' are now `size_t'.
3692
3693 * regex.h <regoff_t>: Use ssize_t, not int.
3694 (re_search, re_search_2, re_match, re_match_2): Arguments that
3695 specify buffer/string position and length are now ssize_t and
3696 size_t. Return type is regoff_t.
3697
613052cd
BK
36982011-04-16 Ben Key <bkey76@gmail.com>
3699
3700 * nsfont.m: Fixed bugs in ns_get_family and
3701 ns_descriptor_to_entity that were caused by using free to
3702 deallocate memory blocks that were allocated by xmalloc (via
3703 xstrdup). This caused Emacs to crash when compiled with
3704 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3705 --enable-checking=xmallocoverrun). xfree is now used to
3706 deallocate these memory blocks.
3707
4170f62f 37082011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3709
71b41406
PE
3710 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3711
9587a89d
PE
3712 emacs_write: Accept and return EMACS_INT for sizes.
3713 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3714 et seq.
3715 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3716 Accept and return EMACS_INT.
3717 (emacs_gnutls_write): Return the number of bytes written on
3718 partial writes.
3719 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3720 (emacs_read, emacs_write): Remove check for negative size, as the
3721 Emacs source code has been audited now.
9587a89d
PE
3722 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3723 (emacs_read, emacs_write): Use it.
273a5f82
PE
3724 * process.c (send_process): Adjust to the new signatures of
3725 emacs_write and emacs_gnutls_write. Do not attempt to store
3726 a byte offset into an 'int'; it might overflow.
9587a89d 3727 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3728
3e047f51
PE
3729 * sound.c: Don't assume sizes fit in 'int'.
3730 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3731 Return EMACS_INT, not int.
3e047f51 3732 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3733 Accept EMACS_INT, not int.
3734 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3735 record read return values.
3736
cc39a9db
BK
37372011-04-15 Ben Key <bkey76@gmail.com>
3738
c9d0ec6d
JB
3739 * keyboard.c (Qundefined): Don't declare static since it is used
3740 in nsfns.m.
3741 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3742 static since they are used in nsfont.m.
cc39a9db 3743
6c60eb9f
SM
37442011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3745
3746 * process.c (Qprocessp): Don't declare static.
3747 * lisp.h (Qprocessp): Declare again.
3748
7990b61a
JB
37492011-04-15 Juanma Barranquero <lekktu@gmail.com>
3750
3751 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3752
5d4cb038
PE
37532011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3754
8bd7b830 3755 Improve C-level modularity by making more things 'static'.
cd64ea1d 3756
e3b27b31
PE
3757 Don't publish debugger-only interfaces to other modules.
3758 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3759 (verify_bytepos, count_markers): Move decls to the only modules
3760 that need them.
3761 * region-cache.h (pp_cache): Likewise.
3762 * window.h (check_all_windows): Likewise.
3763 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3764
5d4cb038
PE
3765 * sysdep.c (croak): Now static, if
3766 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3767 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3768
3769 * alloc.c (refill_memory_reserve): Now static if
3770 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3771 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3772
e87b6180
PE
3773 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3774 Define only if USE_LUCID.
3775
ac64929e
PE
3776 * xrdb.c (x_customization_string, x_rm_string): Now static.
3777
6f37259d
PE
3778 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3779 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3780
1683e3ab
PE
3781 * xdisp.c (draw_row_with_mouse_face): Now static.
3782 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3783
de9c2632
PE
3784 * window.h (check_all_windows): Mark externally visible.
3785
2b96acb7
PE
3786 * window.c (window_deletion_count): Now static.
3787
3788 * undo.c: Make symbols static if they're not exported.
3789 (last_undo_buffer, last_boundary_position, pending_boundary):
3790 Now static.
3791
50436f33
PE
3792 * textprop.c (interval_insert_behind_hooks): Now static.
3793 (interval_insert_in_front_hooks): Likewise.
3794
64520e5c
PE
3795 * term.c: Make symbols static if they're not exported.
3796 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3797 (max_frame_lines, tty_set_terminal_modes):
3798 (tty_reset_terminal_modes, tty_turn_off_highlight):
3799 (get_tty_terminal): Now static.
3800 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3801 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3802 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3803 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3804 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3805
1fa53021
PE
3806 * sysdep.c: Make symbols static if they're not exported.
3807 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3808 Now static.
3809 (sigprocmask_set, full_mask): Remove; unused.
3810 (wait_debugging): Mark as visible.
3811 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3812 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3813
d4b43b22
PE
3814 * syntax.c (syntax_temp): Define only if !__GNUC__.
3815
b7c513d0
PE
3816 * sound.c (current_sound_device, current_sound): Now static.
3817
989b29ad
PE
3818 * search.c (searchbufs, searchbuf_head): Now static.
3819
13a55a78
PE
3820 * scroll.c (scroll_cost): Remove; unused.
3821 * dispextern.h (scroll_cost): Remove decl.
3822
de68a1fc
PE
3823 * region-cache.h (pp_cache): Mark as externally visible.
3824
40ccffa6
PE
3825 * process.c: Make symbols static if they're not exported.
3826 (process_tick, update_tick, create_process, chan_process):
3827 (Vprocess_alist, proc_buffered_char, datagram_access):
3828 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3829 (deactivate_process): Mark defn as static, as well as decl.
3830 * lisp.h (create_process): Remove decl.
3831 * process.h (chan_process, Vprocess_alist): Remove decls.
3832
ad64fc97
PE
3833 * print.c: Make symbols static if they're not exported.
3834 (print_depth, new_backquote_output, being_printed, print_buffer):
3835 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3836 (print_interval, print_number_index, initial_stderr_stream):
3837 Now static.
3838 * lisp.h (Fprinc): Remove decl.
3839 (debug_output_compilation_hack): Mark as externally visible.
3840
adddb265
PE
3841 * sysdep.c (croak): Move decl from here to syssignal.h.
3842 * syssignal.h (croak): Put it here, so the API can be checked when
3843 'croak' is called from dissociate_if_controlling_tty.
3844
1717ede2
PE
3845 * minibuf.c: Make symbols static if they're not exported.
3846 (minibuf_save_list, choose_minibuf_frame): Now static.
3847 * lisp.h (choose_minibuf_frame): Remove decl.
3848
fa5fb2bc
PE
3849 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3850
1e3890d1
PE
3851 * lread.c: Make symbols static if they're not exported.
3852 (read_objects, initial_obarray, oblookup_last_bucket_number):
3853 Now static.
3854 (make_symbol): Remove; unused.
3855 * lisp.h (initial_obarray, make_symbol): Remove decls.
3856
8a1414fa
PE
3857 * keyboard.c: Make symbols static if they're not exported.
3858 (single_kboard, recent_keys_index, total_keys, recent_keys):
3859 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3860 (this_single_command_key_start, echoing, last_auto_save):
3861 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3862 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3863 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3864 (Vlispy_mouse_stem, double_click_count):
3865 Now static.
3866 (force_auto_save_soon): Define only if SIGDANGER.
3867 (ignore_mouse_drag_p): Now static if
3868 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3869 (print_help): Remove; unused.
3870 (stop_character, last_timer_event): Mark as externally visible.
3871 * keyboard.h (ignore_mouse_drag_p): Declare only if
3872 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3873 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3874 * lisp.h (echoing): Remove decl.
3875 (force_auto_save_soon): Declare only if SIGDANGER.
3876 * xdisp.c (redisplay_window): Simplify code, to make it more
3877 obvious that ignore_mouse_drag_p is not accessed if !defined
3878 USE_GTK && !defined HAVE_NS.
3879
93ea6e8f
PE
3880 * intervals.c: Make symbols static if they're not exported.
3881 (merge_properties_sticky, merge_interval_right, delete_interval):
3882 Now static.
3883 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3884
77382fcc
PE
3885 * insdel.c: Make symbols static if they're not exported.
3886 However, leave prepare_to_modify_buffer alone. It's never
3887 called from outside this function, but that appears to be a bug.
3888 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3889 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3890 (adjust_after_replace_noundo): Remove; unused.
3891 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3892 (signal_before_change): Remove decls.
77382fcc 3893
9306c32e
PE
3894 * indent.c (val_compute_motion, val_vmotion): Now static.
3895
cd44d2eb
PE
3896 * image.c: Make symbols static if they're not exported.
3897 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3898 if USE_GTK.
3899 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3900 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3901
ad9a7a06
PE
3902 * fringe.c (standard_bitmaps): Now static.
3903 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3904
81626931
PE
3905 * frame.c: Make symbols static if they're not exported.
3906 (x_report_frame_params, make_terminal_frame): Now static.
3907 (get_frame_param): Now static, unless HAVE_NS.
3908 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3909 (x_get_resource_string): Remove; not used.
3910 * frame.h (make_terminal_frame, x_report_frame_params):
3911 (x_get_resource_string); Remove decls.
3912 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3913 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3914
239f9db9
PE
3915 * font.c, fontset.c: Make symbols static if they're not exported.
3916 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3917 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3918 * font.c (font_close_object): Now static.
3919 * font.h (font_close_object): Remove.
3920 * fontset.c (FONTSET_OBJLIST): Remove.
3921 (free_realized_fontset) #if-0 the body, which does nothing.
3922 (face_suitable_for_char_p): #if-0, as it's never called.
3923 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3924 * xfaces.c (face_at_string_position):
3925 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3926 since 0 is always ASCII.
3927
dfcf3579
PE
3928 * fns.c (weak_hash_tables): Now static.
3929
5045092b
PE
3930 * fileio.c: Make symbols static if they're not exported.
3931 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3932 (Vwrite_region_annotation_buffers): Now static.
3933
57a96f5c
PE
3934 * eval.c: Make symbols static if they're not exported.
3935 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3936 * lisp.h (backtrace_list): Remove decl.
3937
35f08c38
PE
3938 * emacs.c: Make symbols static if they're not exported.
3939 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3940 (fatal_error_code, fatal_error_signal_hook, standard_args):
3941 Now static.
3942 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3943 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3944 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3945 * lisp.h (fatal_error_signal_hook): Remove decl.
3946 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3947
f44bd759
PE
3948 * editfns.c: Move a (normally-unused) function to its only use.
3949 * editfns.c, lisp.h (get_operating_system_release): Remove.
3950 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3951 worth the hassle of breaking this out.
3952
b532497d
PE
3953 * xterm.c: Make symbols static if they're not exported.
3954 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3955 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3956 (x_destroy_window, x_delete_display):
3957 Now static.
3958 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3959 (x_mouse_leave): Remove; unused.
3960 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3961 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3962 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3963 Remove decls.
3964 (x_mouse_leave): Declare only if WINDOWSNT.
3965 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3966 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3967 USE_X_TOOLKIT.
3968
1675728f
PE
3969 * ftxfont.c: Make symbols static if they're not exported.
3970 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3971 HAVE_FREETYPE.
3972 * font.h (ftxfont_driver): Likewise.
3973
e4cebfca
PE
3974 * xfns.c: Make symbols static if they're not exported.
3975 (x_last_font_name, x_display_info_for_name):
3976 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3977 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3978 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3979 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3980 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3981 (last_show_tip_args): Now static.
3982 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3983 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3984 (x_screen_planes): Remove; unused.
3985 * dispextern.h (x_screen_planes): Remove decl.
3986
5bf46f05
PE
3987 * dispnew.c: Make symbols static if they're not exported.
3988 * dispextern.h (redraw_garbaged_frames, scrolling):
3989 (increment_row_positions): Remove.
3990 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3991 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3992 Now static.
3993 (redraw_garbaged_frames): Remove; unused.
3994
435f4c28
PE
3995 * xfaces.c: Make symbols static if they're not exported.
3996 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3997 Remove decls.
3998 * xterm.h (defined_color): Remove decls.
3999 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4000 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4001 (menu_face_changed_default, defined_color, free_realized_face):
4002 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4003 (ascii_face_of_lisp_face): Remove; unused.
4004
8524aef3
PE
4005 * xdisp.c: Make symbols static if they're not exported.
4006 * dispextern.h (scratch_glyph_row, window_box_edges):
4007 (glyph_to_pixel_coords, set_cursor_from_row):
4008 (get_next_display_element, set_iterator_to_next):
4009 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4010 (show_mouse_face): Remove decls
4011 * frame.h (message_buf_print): Likewise.
4012 * lisp.h (pop_message, set_message, check_point_in_composition):
4013 Likewise.
4014 * xterm.h (set_vertical_scroll_bar): Likewise.
4015 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4016 (message_buf_print, scratch_glyph_row, displayed_buffer):
4017 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4018 (get_next_display_element, show_mouse_face, window_box_edges):
4019 (frame_to_window_pixel_xy, check_point_in_composition):
4020 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4021 (glyph_to_pixel_coords): Remove; unused.
4022
16390cd2
PE
4023 * dired.c (file_name_completion): Now static.
4024
4025 * dbusbind.c (xd_in_read_queued_messages): Now static.
4026
a25f4dfa
PE
4027 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4028 * data.c (circular_list_error): Remove.
4029
14a9c8df
PE
4030 * commands.h (last_point_position, last_point_position_buffer):
4031 (last_point_position_window): Remove decls.
4032 * keyboard.c: Make these variables static.
4033
04f2d78b
CB
4034 * coding.h (coding, code_convert_region, encode_coding_gap):
4035 Remove decls.
74ab6df5
PE
4036 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4037 (iso_code_class, detect_coding, code_convert_region): Now static.
4038 (encode_coding_gap): Remove; unused.
4039
38dfbee1
PE
4040 * chartab.c (chartab_chars, chartab_bits): Now static.
4041
a2cb4e63
PE
4042 * charset.h (charset_iso_8859_1): Remove decl.
4043 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4044 Now static.
4045
127198fd
PE
4046 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4047 * ccl.c (Vccl_program_table): Now static.
4048 (check_ccl_update): Remove; unused.
4049
d85b608f
PE
4050 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4051 * category.h: ... from here.
4052 * category.c (check_category_table, set_category_set): Now static.
4053
31cd66f3
PE
4054 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4055 * lisp.h: Remove these decls.
4056
c358e587
PE
4057 * buffer.c (buffer_count): Remove unused var.
4058
e78aecca
PE
4059 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4060 so that it's not optimized away.
4061 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4062 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4063 exported only to the debugger.
4064
e192d7d3 4065 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4066 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4067
92470028
PE
4068 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4069 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4070 was inaccessible from Lisp.
4071 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4072 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4073
244ed907
PE
4074 alloc.c: Import and export fewer symbols, and remove unused items.
4075 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4076 is defined.
4077 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4078 it's not optimized away by whole-program optimization.
4079 (message_enable_multibyte, free_misc): Remove.
4080 (catchlist, handlerlist, mark_backtrace):
4081 Declare only if BYTE_MARK_STACK.
4082 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4083 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4084 (message_enable_multibyte): Remove decl.
4085 (free_misc, interval_free_list, float_block, float_block_index):
4086 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4087 (cons_free_list, last_marked_index):
4088 Now static.
4089 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4090 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4091 (mark_backtrace): Define only if BYTE_MARK_STACK.
4092 * xdisp.c (message_enable_multibyte): Now static.
4093
61c2b50e 4094 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4095 This makes it easier for human readers (and static analyzers)
4096 to see whether these variables are used from other modules.
4097 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4098 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4099 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4100 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4101 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4102 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4103 * xmenu.c, xselect.c:
4104 Declare Q* vars static if they are not used in other modules.
4105 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4106 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4107 Remove decls of unexported vars.
4108 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4109
95c82688
PE
4110 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4111
16a97296
PE
4112 Make Emacs functions such as Fatom 'static' by default.
4113 This makes it easier for human readers (and static analyzers)
4114 to see whether these functions can be called from other modules.
4115 DEFUN now defines a static function. To make the function external
4116 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4117 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4118 (Finit_image_library):
16a97296
PE
4119 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4120 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4121 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4122 Remove decls, since these functions are now static.
4123 (Funintern, Fget_internal_run_time): New decls, since these functions
4124 were already external.
95c82688 4125
16a97296
PE
4126 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4127 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4128 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4129 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4130 * keyboard.c, keymap.c, lread.c:
4131 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4132 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4133 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4134 Mark functions with DEFUE instead of DEFUN,
4135 if they are used in other modules.
4136 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4137 decls for now-static functions.
4138 * buffer.h (Fdelete_overlay): Remove decl.
4139 * callproc.c (Fgetenv_internal): Mark as internal.
4140 * composite.c (Fremove_list_of_text_properties): Remove decl.
4141 (Fcomposition_get_gstring): New forward static decl.
4142 * composite.h (Fcomposite_get_gstring): Remove decl.
4143 * dired.c (Ffile_attributes): New forward static decl.
4144 * doc.c (Fdocumntation_property): New forward static decl.
4145 * eval.c (Ffetch_bytecode): New forward static decl.
4146 (Funintern): Remove extern decl; now in .h file where it belongs.
4147 * fileio.c (Fmake_symbolic_link): New forward static decl.
4148 * image.c (Finit_image_library): New forward static decl.
4149 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4150 * intervals.h (Fprevious_property_change):
4151 (Fremove_list_of_text_properties): Remove decls.
4152 * keyboard.c (Fthis_command_keys): Remove decl.
4153 (Fcommand_execute): New forward static decl.
4154 * keymap.c (Flookup_key): New forward static decl.
4155 (Fcopy_keymap): Now static.
4156 * keymap.h (Flookup_key): Remove decl.
4157 * process.c (Fget_process): New forward static decl.
4158 (Fprocess_datagram_address): Mark as internal.
4159 * syntax.c (Fsyntax_table_p): New forward static decl.
4160 (skip_chars): Remove duplicate decl.
4161 * textprop.c (Fprevious_property_change): New forward static decl.
4162 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4163 Now internal.
4164 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4165 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4166
785bbd42
PE
4167 * editfns.c (Fformat): Remove unreachable code.
4168
8b913b57
AS
41692011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4170
4171 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4172 change. (Bug#8496)
4173
a6744a35
EZ
41742011-04-13 Eli Zaretskii <eliz@gnu.org>
4175
4176 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4177 when at ZV. (Bug#8487)
4178
e7974947
AS
41792011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4180
baad03f0
AS
4181 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4182 (Bug#8437)
4183 * keyboard.c (parse_tool_bar_item): Likewise.
4184 * sound.c (sound_cleanup, alsa_close): Likewise.
4185 * termcap.c (tgetent): Likewise.
4186 * xfns.c (x_default_font_parameter): Likewise.
4187 * xsettings.c (read_and_apply_settings): Likewise.
4188
e7974947
AS
4189 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4190 (overrun_check_free): Protoize.
4191
28272684
PE
41922011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4193
4194 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4195 since callers should never pass a negative size.
4196 Change the signature to match that of plain 'read' and 'write'; see
4197 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4198 * lisp.h: Update prototypes of emacs_write and emacs_read.
4199
11997c76
EZ
42002011-04-11 Eli Zaretskii <eliz@gnu.org>
4201
4202 * xdisp.c (redisplay_window): Don't try to determine the character
4203 position of the scroll margin if the window start point w->startp
e896f03c 4204 is outside the buffer's accessible region. (Bug#8468)
11997c76 4205
8a2cbd72
EZ
42062011-04-10 Eli Zaretskii <eliz@gnu.org>
4207
4208 Fix write-region and its subroutines for buffers > 2GB.
4209 * fileio.c (a_write, e_write): Modify declaration of arguments and
4210 local variables to support buffers larger than 2GB.
4211 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4212
4213 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4214 argument, local variables, and return value.
4215
4216 * lisp.h: Update prototypes of emacs_write and emacs_read.
4217
4218 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4219
4073e537 42202011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4221
1ebfdcb6
PE
4222 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4223
b2ded58d
PE
4224 Fix more problems found by GCC 4.6.0's static checks.
4225
7d66342c
PE
4226 * xdisp.c (vmessage): Use a better test for character truncation.
4227
bbf47d44
PE
4228 * charset.c (load_charset_map): <, not <=, for optimization,
4229 and to avoid potential problems with integer overflow.
9248994d 4230 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4231 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4232 * editfns.c (Fformat): Likewise.
1e69125e 4233 * syntax.c (skip_chars): Likewise.
3befa583 4234
e3019616
PE
4235 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4236 This also lets GCC 4.6.0 generate slightly better loop code.
4237
becfa255
PE
4238 * callint.c (Fcall_interactively): <, not <=, for optimization.
4239 (Fcall_interactively): Count the number of arguments produced,
4240 not the number of arguments given. This is simpler and lets GCC
4241 4.6.0 generate slightly better code.
4242
dae0cd48
PE
4243 * ftfont.c: Distingish more carefully between FcChar8 and char.
4244 The previous code passed unsigned char * to a functions like
4245 strlen and xstrcasecmp that expect char *, which does not
4246 conform to the C standard.
4247 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4248 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4249 char * when the C standard requires it.
4250
76032d70
PE
4251 * keyboard.c (read_char): Remove unused var.
4252
eb3f1cc8
PE
4253 * eval.c: Port to Windows vsnprintf (Bug#8435).
4254 Include <limits.h>.
4255 (SIZE_MAX): Define if the headers do not.
4256 (verror): Do not give up if vsnprintf returns a negative count.
4257 Instead, grow the buffer. This ports to Windows vsnprintf, which
4258 does not conform to C99. Problem reported by Eli Zaretskii.
4259 Also, simplify the allocation scheme, by avoiding the need for
4260 calling realloc, and removing the ALLOCATED variable.
4261
70476b54
PE
4262 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4263
12020a9e
PE
4264 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4265 But keep the doprint source code for now, as we might revamp it
4266 and use it again (Bug#8435).
ea6c7ae6
PE
4267 * lisp.h (doprnt): Remove.
4268 * Makefile.in (base_obj): Remove doprnt.o.
4269 * deps.mk (doprnt.o): Remove.
4270
5fdb398c
PE
4271 error: Print 32- and 64-bit integers portably (Bug#8435).
4272 Without this change, on typical 64-bit hosts error ("...%d...", N)
4273 was used to print both 32- and 64-bit integers N, which relied on
4274 undefined behavior.
4275 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4276 New macro.
4277 * lisp.h (error, verror): Mark as printf-like functions.
4278 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4279 Report overflow in size calculations when allocating printf buffer.
4280 Do not truncate output string at its first null byte.
4281 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4282 Truncate the output at a character boundary, since vsnprintf does not
4283 do that.
4284 * charset.c (check_iso_charset_parameter): Convert internal
4285 character to string before calling 'error', since %c now has the
4286 printf meaning.
4287 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4288 overflow when computing char to be passed to 'error'. Do not
4289 pass Lisp_Object to 'error'; pass the integer instead.
4290 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4291 formatted with plain %d.
4292
b189fa66
PE
4293 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4294
bff87ef0
PE
4295 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4296
7e2cac20
PE
4297 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4298
ce4d90b5
PE
4299 * xterm.c (x_catch_errors): Remove duplicate declaration.
4300
266c9547
PE
4301 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4302
79c49ad2
PE
4303 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4304
368f4090
JM
43052011-04-10 Jim Meyering <meyering@redhat.com>
4306
4307 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4308 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4309 return ssize_t not "int", and use size_t as the buffer length.
4310 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4311 * gnutls.h: Update declarations.
4312 * process.c (read_process_output): Use ssize_t, to match.
4313 (send_process): Likewise.
4314
a32d4040
CY
43152011-04-09 Chong Yidong <cyd@stupidchicken.com>
4316
4317 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4318
8546720e 43192011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4320
04f2d78b
CB
4321 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4322 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4323
8546720e
GM
4324 * xterm.c (handle_one_xevent):
4325 * xmenu.c (create_and_show_popup_menu):
4326 * xselect.c (x_decline_selection_request)
4327 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4328
0a2f5c1a 43292011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4330
4331 Fix some uses of `int' instead of EMACS_INT.
4332 * search.c (string_match_1, fast_string_match)
4333 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4334 (scan_buffer, find_next_newline_no_quit)
4335 (find_before_next_newline, search_command, Freplace_match)
4336 (Fmatch_data): Make some `int' variables be EMACS_INT.
4337
4338 * xdisp.c (display_count_lines): 3rd argument and return value now
4339 EMACS_INT. All callers changed.
4340 (pint2hrstr): Last argument is now EMACS_INT.
4341
4342 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4343 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4344 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4345 (decode_coding_utf_16, decode_coding_emacs_mule)
4346 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4347 (decode_coding_ccl, decode_coding_charset)
4348 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4349 (decode_coding_iso_2022, decode_coding_emacs_mule)
4350 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4351 <char_offset, last_offset>: Declare EMACS_INT.
4352 (encode_coding_utf_8, encode_coding_utf_16)
4353 (encode_coding_emacs_mule, encode_invocation_designation)
4354 (encode_designation_at_bol, encode_coding_iso_2022)
4355 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4356 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4357 Declare EMACS_INT.
4358 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4359 (encode_invocation_designation): Last argument P_NCHARS is now
4360 EMACS_INT.
4361 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4362 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4363
4364 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4365 All users changed.
4366
4367 * ccl.c (Fccl_execute_on_string): Declare some variables
4368 EMACS_INT.
4369
8546720e 43702011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4371
4372 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4373
4e19a977
CS
43742011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4375
4376 * process.c (Fformat_network_address): Doc fix.
4377
87302331
R
43782011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4379
4380 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4381
cbb59342
CY
43822011-04-08 Chong Yidong <cyd@stupidchicken.com>
4383
4384 * keyboard.c (read_char): Call Lisp function help-form-show,
4385 instead of using internal_with_output_to_temp_buffer.
4386 (Qhelp_form_show): New var.
e0d38eeb 4387 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4388
4389 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4390
4391 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4392
e67a13ab
CY
43932011-04-06 Chong Yidong <cyd@stupidchicken.com>
4394
04f2d78b
CB
4395 * process.c (Flist_processes): Remove to Lisp.
4396 (list_processes_1): Delete.
e67a13ab 4397
973f782d
EZ
43982011-04-06 Eli Zaretskii <eliz@gnu.org>
4399
7c106b1e
EZ
4400 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4401
973f782d
EZ
4402 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4403
41cf7d1a 44042011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4405
ca23cc88
PE
4406 Fix more problems found by GCC 4.6.0's static checks.
4407
f390e2d5
PE
4408 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4409
42eea0d0
PE
4410 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4411
b69769da 4412 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4413
f9541e84
PE
4414 * xdisp.c (vmessage): Mark as a printf-like function.
4415
13841b55
PE
4416 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4417
c136c10f
PE
4418 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4419
5e2d4a30
PE
4420 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4421 printf-like functions.
4422 (tiff_load): Add casts to remove these marks before passing them
4423 to system-supplied API.
4424
583f48b9
PE
4425 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4426
b25d760e
PE
4427 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4428 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4429 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4430 directly, rather than having caller test rule sign. This avoids
4431 some unnecessary tests.
4432 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4433 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4434 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4435
bc7b6697 4436 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4437 (xfont_open): Avoid unnecessary tests.
bc7b6697 4438
27ccc379
PE
4439 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4440
dcd5c89a
PE
4441 * composite.h, composite.c (composition_gstring_put_cache):
4442 Use EMACS_INT, not int, for length.
4443
b13a45c6
PE
4444 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4445 breaking out part of COMPOSITION_DECODE_RULE.
4446 (COMPOSITION_DECODE_RULE): Use it.
4447 * composite.c (get_composition_id): Remove unused local vars,
4448 by using the new macro.
4449
1e792e4d
PE
4450 * textprop.c (set_text_properties_1): Change while to do-while,
4451 since the condition is always true at first.
4452
dc6c6455 4453 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4454 (interval_deletion_adjustment): Return unsigned value.
4455 All uses changed.
dc6c6455 4456
aba7731a
PE
4457 * process.c (list_processes_1, create_pty, read_process_output):
4458 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4459 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4460 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4461 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4462 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4463
fdfc4bf3
PE
4464 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4465
fca8fe46 4466 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4467 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4468
06a0259a 4469 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4470 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4471 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4472
e7b9e80f
PE
4473 * print.c (print_error_message): Avoid int overflow.
4474
56201685
PE
4475 * font.c (font_list_entities): Redo for clarity,
4476 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4477
78834453 4478 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4479 (font_score): Avoid potential overflow in diff calculation.
78834453 4480
0bc0b309 4481 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4482 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4483
e610eaca
PE
4484 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4485
b895abce
PE
4486 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4487 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4488 can always succeed if overflow has undefined behavior.
4489
1f1d9321 4490 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4491 (wordify): Omit three unnecessary tests.
1f1d9321 4492
c59478bc
PE
4493 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4494 All callers changed. This avoids the need for an unused var.
4495
79b73827
PE
4496 * casefiddle.c (casify_region): Remove var that is set but not used.
4497
a4db5dfe
PE
4498 * dired.c (file_name_completion): Remove var that is set but not used.
4499
43aae36e
PE
4500 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4501
2a47c44d 4502 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4503 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4504
a37c69bf
PE
4505 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4506 Check for integer overflow on size calculations.
4507
328ab8e7
PE
4508 * buffer.c (Fprevious_overlay_change): Remove var that is set
4509 but not used.
4510
e5a2a5cb
PE
4511 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4512 Remove vars that are set but not used.
8d84a6eb 4513 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4514 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4515
a60e5f68
PE
4516 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4517
f661cb61 4518 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4519 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4520
f0397f5a
PE
4521 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4522 that are set but not used.
4523
8664db06 4524 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4525 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4526
6abdaa4a
PE
4527 * xselect.c (x_get_local_selection, x_handle_property_notify):
4528 Remove vars that are set but not used.
4529
0ce7538d 4530 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4531 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4532
9ae848fc
PE
4533 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4534 Remove var that is set but not used.
0b918413
PE
4535 (scroll_bar_windows_size): Now size_t, not int.
4536 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4537 Check for overflow.
9ae848fc 4538
a5a62657
PE
4539 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4540 (map_tty_color) [!defined MSDOS]: Likewise.
4541
5c5cdd39
PE
4542 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4543
66ebf983
PE
4544 * coding.c: Remove vars that are set but not used.
4545 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4546 All callers changed.
4547 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4548 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4549 (decode_coding_charset): Remove vars that are set but not used.
4550
1be4d761
PE
4551 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4552 that is set but not used.
4553
47553fa8
PE
4554 * print.c (print_object): Remove var that is set but not used.
4555
1f7196bf 4556 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4557 The gnulib version avoids calling malloc in the usual case,
4558 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4559 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4560 * filelock.c (current_lock_owner): Likewise.
4561 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4562 * sysdep.c: Include allocator.h, careadlinkat.h.
4563 (emacs_no_realloc_allocator): New static constant.
4564 (emacs_readlink): New function.
fdb61804
PE
4565 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4566 ../lib/careadlinkat.h.
d1fdcab7 4567
f84c17c7
SM
45682011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4569
4570 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4571 first non-nil return value).
4572
ef3862ad
JD
45732011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4574
4575 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4576 if not defined (Bug#8403).
4577
376a7006
JB
45782011-04-02 Juanma Barranquero <lekktu@gmail.com>
4579
4580 * xdisp.c (display_count_lines): Remove parameter `start',
4581 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4582 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4583 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4584 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4585 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4586 and thereabouts. All callers changed.
4587 (get_per_char_metric): Remove parameter `f', unused since
4588 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4589
6ca3801d
JM
45902011-04-02 Jim Meyering <meyering@redhat.com>
4591
4592 do not dereference NULL upon failed strdup
4593 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4594 (ns_get_family): Likewise.
4595
d8e2b5ba
JB
45962011-04-02 Juanma Barranquero <lekktu@gmail.com>
4597
4598 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4599
8c74fcbd
JD
46002011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4601
4602 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4603 later (Bug#8403).
4604
7200d79c
SM
46052011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4606
03408648 4607 Add lexical binding.
7200d79c 4608
03408648
SM
4609 * window.c (Ftemp_output_buffer_show): New fun.
4610 (Fsave_window_excursion):
4611 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4612
4613 * lread.c (lisp_file_lexically_bound_p): New function.
4614 (Fload): Bind Qlexical_binding.
4615 (readevalloop): Remove `evalfun' arg.
4616 Bind Qinternal_interpreter_environment.
4617 (Feval_buffer): Bind Qlexical_binding.
4618 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4619 Mark as dynamic.
4620 (syms_of_lread): Declare `lexical-binding'.
4621
4622 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4623
4624 * keyboard.c (eval_dyn): New fun.
4625 (menu_item_eval_property): Use it.
ca105506
SM
4626
4627 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4628
03408648
SM
4629 * fns.c (concat, mapcar1): Accept byte-code-functions.
4630
4631 * eval.c (Fsetq): Handle lexical vars.
4632 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4633 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4634 (FletX, Flet): Obey lexical binding.
4635 (Fcommandp): Handle closures.
4636 (Feval): New `lexical' arg.
4637 (eval_sub): New function extracted from Feval. Use it almost
4638 everywhere where Feval was used. Look up vars in lexical env.
4639 Handle closures.
4640 (Ffunctionp): Move from subr.el.
4641 (Ffuncall): Handle closures.
4642 (apply_lambda): Remove `eval_flags'.
4643 (funcall_lambda): Handle closures and new byte-code-functions.
4644 (Fspecial_variable_p): New function.
4645 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4646 but without exporting it to Lisp.
23aba0ea 4647
23aba0ea 4648 * doc.c (Fdocumentation, store_function_docstring):
03408648 4649 * data.c (Finteractive_form): Handle closures.
23aba0ea 4650
03408648
SM
4651 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4652 interactive spec.
ba83908c 4653
04f2d78b
CB
4654 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4655 New byte-codes.
03408648
SM
4656 (exec_byte_code): New function extracted from Fbyte_code to handle new
4657 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4658
03408648 4659 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4660
03408648 4661 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4662
e2abce01
JB
46632011-03-31 Juanma Barranquero <lekktu@gmail.com>
4664
4665 * xdisp.c (redisplay_internal): Fix prototype.
4666
63696a73 46672011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4668
63696a73 4669 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4670 (try_scrolling): Use it when setting scroll_limit.
4671 Limit scrolling to 100 screen lines.
63696a73
EZ
4672 (redisplay_window): Even when falling back on "recentering",
4673 position point in the window according to scroll-conservatively,
4674 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4675
4676 (try_scrolling): When point is above the window, allow searching
4677 as far as scroll_max, or one screenful, to compute vertical
4678 distance from PT to the scroll margin position. This prevents
4679 try_scrolling from unnecessarily failing when
4680 scroll-conservatively is set to a value slightly larger than the
4681 window height. Clean up the case of PT below the margin at bottom
4682 of window: scroll_max can no longer be INT_MAX. When aggressive
4683 scrolling is in use, don't let point enter the opposite scroll
4684 margin as result of the scroll.
4685 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4686 threshold of 100 lines for never-recentering scrolling.
4687
e4cc2dfc
JB
46882011-03-31 Juanma Barranquero <lekktu@gmail.com>
4689
4690 * dispextern.h (move_it_by_lines):
4691 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4692 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4693 (message_log_check_duplicate): Remove parameters `prev_bol' and
4694 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4695 (redisplay_internal): Remove parameter `preserve_echo_area',
4696 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4697
4698 * indent.c (Fvertical_motion):
4699 * window.c (window_scroll_pixel_based, Frecenter):
4700 Don't pass `need_y_p' to `move_it_by_lines'.
4701
1c470562
SM
47022011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4703
44f230aa
SM
4704 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4705 steal a few bits to be more compact.
4706 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4707 Remove unneeded casts.
4708
1c470562
SM
4709 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4710
888adce9
ZK
47112011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4712
4713 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4714 binding" message (bug#7967).
4715
f838ed7b
PE
47162011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4717
77861b95
PE
4718 Fix more problems found by GCC 4.6.0's static checks.
4719
de6dbc14
PE
4720 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4721 Remove unused local var.
4722
f838ed7b
PE
4723 * editfns.c (Fmessage_box): Remove unused local var.
4724
792c7b2b
PE
4725 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4726 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4727 Omit unused local vars.
c499e557 4728 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4729 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4730 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4731 Omit unused local var.
4732
ba0165e1
PE
4733 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4734 Don't assume string length fits in int.
32ad8845 4735 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4736 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4737
3c59b4c9
PE
4738 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4739 instead of alloca (Bug#8344).
4740
a3eed478 4741 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4742 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4743
eb4d412d
PE
4744 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4745
1658b401
PE
4746 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4747 concerns.
4748
4749 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4750
4751 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4752
9a2c6e05
PE
4753 * keyboard.c (syms_of_keyboard): Use the same style as later
4754 in this function when indexing through an array. This also
4755 works around GCC bug 48267.
4756
03d0a109
PE
4757 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4758
44f730c8
PE
4759 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4760
fe75f926
PE
4761 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4762 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4763
ffa8c828
PE
4764 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4765 This avoids undefined behavior on integer overflow, and is a bit
4766 more convenient anyway since it is compared to a size_t variable.
4767
c5101a77
PE
4768 Variadic C functions now count arguments with size_t, not int.
4769 This avoids an unnecessary limitation on 64-bit machines, which
4770 caused (substring ...) to crash on large vectors (Bug#8344).
4771 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4772 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4773 All variadic functions and their callers changed accordingly.
c5101a77
PE
4774 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4775 * data.c (arith_driver, float_arith_driver): Likewise.
4776 * editfns.c (general_insert_function): Likewise.
4777 * eval.c (struct backtrace.nargs, interactive_p)
4778 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4779 (funcall_lambda, mark_backtrace): Likewise.
4780 * fns.c (concat): Likewise.
4781 * frame.c (x_set_frame_parameters): Likewise.
4782 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4783 0 if not found, not -1. All callers changed.
4784
dd3f25f7
PE
4785 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4786 (stack_copy_size): Now size_t, not int.
4787 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4788
461c2ab9
JB
47892011-03-28 Juanma Barranquero <lekktu@gmail.com>
4790
4791 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4792 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4793 All callers changed.
4794
4795 * lisp.h (multibyte_char_to_unibyte):
4796 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4797 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4798 * character.h (CHAR_TO_BYTE8):
4799 * cmds.c (internal_self_insert):
4800 * editfns.c (general_insert_function):
4801 * keymap.c (push_key_description):
4802 * search.c (Freplace_match):
4803 * xdisp.c (message_dolog, set_message_1): All callers changed.
4804
f6d62986
SM
48052011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4806
4807 * keyboard.c (safe_run_hook_funcall): New function.
4808 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4809 don't set the hook to nil, but remove the offending function instead.
4810 (Qcommand_hook_internal): Remove, unused.
4811 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4812 Vcommand_hook_internal.
4813
4814 * eval.c (enum run_hooks_condition): Remove.
4815 (funcall_nil, funcall_not): New functions.
4816 (run_hook_with_args): Call each function through a `funcall' argument.
4817 Remove `cond' argument, now redundant.
4818 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4819 (Frun_hook_with_args_until_failure): Adjust accordingly.
4820 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4821
1db5b1ad
JB
48222011-03-28 Juanma Barranquero <lekktu@gmail.com>
4823
4824 * dispextern.h (string_buffer_position): Remove declaration.
4825
4826 * print.c (strout): Remove parameter `multibyte', unused since
4827 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4828
4829 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4830 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4831 All callers changed.
4832
4833 * w32.c (_wsa_errlist): Use braces for struct initializers.
4834
4835 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4836 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4837 All callers changed.
4838 (string_buffer_position): Likewise. Also, make static (it's never
4839 used outside xdisp.c).
4840 (cursor_row_p): Remove parameter `w', unused since
4841 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4842 (decode_mode_spec): Remove parameter `precision', introduced during
4843 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4844 All callers changed.
4845
5ffb62aa
JD
48462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4847
4848 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4849
461c2ab9 48502011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4851
4852 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4853 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4854 (ns_update_auto_hide_menu_bar): New functions.
4855 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4856 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4857 ns_constrain_all_frames.
4858 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4859 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4860
5c380ffb
JD
48612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4862
4863 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4864
9af30bdf
GM
48652011-03-27 Glenn Morris <rgm@gnu.org>
4866
4867 * syssignal.h: Replace RETSIGTYPE with void.
4868 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4869 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4870 Replace SIGTYPE with void everywhere.
4871 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4872 * s/template.h (SIGTYPE): Remove commented out definition.
4873
e2abce01
JB
48742011-03-26 Eli Zaretskii <eliz@gnu.org>
4875
4876 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4877 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4878
f868cd8a
JB
48792011-03-26 Juanma Barranquero <lekktu@gmail.com>
4880
59eb0929
JB
4881 * w32.c (read_unc_volume): Use parameter `henum', instead of
4882 global variable `wget_enum_handle'.
4883
4884 * keymap.c (describe_vector): Remove parameters `indices' and
4885 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4886 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4887
f868cd8a
JB
4888 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4889
4890 * keyboard.c (timer_check): Remove parameter `do_it_now',
4891 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4892 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4893 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4894
4895 * keyboard.c (read_char):
4896 * w32menu.c (w32_menu_display_help):
4897 * xmenu.c (show_help_event, menu_help_callback):
4898 Adjust calls to `show_help_echo'.
4899
4900 * gtkutil.c (xg_maybe_add_timer):
4901 * keyboard.c (readable_events):
4902 * process.c (wait_reading_process_output):
4903 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4904
4905 * insdel.c (adjust_markers_gap_motion):
4906 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4907 (gap_left, gap_right): Don't call it.
4908
2ecf6fdb
CY
49092011-03-25 Chong Yidong <cyd@stupidchicken.com>
4910
4911 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4912 incurred during fontification.
4913
6b1f9ba4
JB
49142011-03-25 Juanma Barranquero <lekktu@gmail.com>
4915
4916 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4917 (DEFVAR_PER_BUFFER): Don't pass it.
4918
4919 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4920 (scrolling_window): Don't pass it.
4921
0f4a96b5
JB
49222011-03-25 Juanma Barranquero <lekktu@gmail.com>
4923
4924 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4925
4926 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4927 and `suffix'.
4928 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4929 of variables specific to SELinux and computation of `encoded_absname'.
4930
4931 * image.c (XPutPixel): Remove unused variable `height'.
4932
4933 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4934
4935 * unexw32.c (get_section_info): Remove unused variable `section'.
4936
4937 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4938 (system_process_attributes): Remove unused variable `sess'.
4939 (sys_read): Remove unused variable `err'.
4940
4941 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4942 (w32_wnd_proc): Remove unused variable `isdead'.
4943 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4944 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4945 (x_create_tip_frame): Remove unused variable `tem'.
4946
4947 * w32inevt.c (w32_console_read_socket):
4948 Remove unused variable `no_events'.
4949
4950 * w32term.c (x_draw_composite_glyph_string_foreground):
4951 Remove unused variable `width'.
4952
1149507c
JB
49532011-03-24 Juanma Barranquero <lekktu@gmail.com>
4954
4955 * w32term.c (x_set_glyph_string_clipping):
4956 Don't pass uninitialized region to CombineRgn.
4957
9c88f339
JB
49582011-03-23 Juanma Barranquero <lekktu@gmail.com>
4959
4960 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4961 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4962 (Fx_close_connection): Remove unused variable `i'.
4963
4964 * w32font.c (w32font_draw): Return number of glyphs.
4965 (w32font_open_internal): Remove unused variable `i'.
4966 (w32font_driver): Add missing initializer.
4967
4968 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4969 (fill_in_menu): Remove unused variable `items_added'.
4970
4971 * w32term.c (last_mouse_press_frame): Remove static global variable.
4972 (w32_clip_to_row): Remove unused variable `f'.
4973 (x_delete_terminal): Remove unused variable `i'.
4974
4975 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4976 (NOTHING): Remove unused static global variable.
4977 (uniscribe_check_otf): Remove unused variable `table'.
4978 (uniscribe_font_driver): Add missing initializers.
4979
dee091a3
JD
49802011-03-23 Julien Danjou <julien@danjou.info>
4981
4982 * term.c (Fsuspend_tty, Fresume_tty):
4983 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4984 * window.c (temp_output_buffer_show):
4985 * insdel.c (signal_before_change):
4986 * frame.c (Fhandle_switch_frame):
4987 * fileio.c (Fdo_auto_save):
4988 * emacs.c (Fkill_emacs):
4989 * editfns.c (save_excursion_restore):
4990 * cmds.c (internal_self_insert):
4991 * callint.c (Fcall_interactively):
4992 * buffer.c (Fkill_all_local_variables):
4993 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4994 Use Frun_hooks.
0f4a96b5 4995 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4996 unconditionnaly since it does the check itself.
4997
2c520ab5 49982011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4999
c9c49752
PE
5000 Fix more problems found by GCC 4.5.2's static checks.
5001
8abc3f12
PE
5002 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5003 the first time through the loop, since we know p0 < p1 then.
5004 This also avoids a gcc -Wstrict-overflow warning.
5005
a2d26660
PE
5006 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5007 leading to a memory leak, possible in functions like
5008 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5009 of objects (Bug#8318).
a2d26660 5010
916c72e9
PE
5011 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5012 that could (at least in theory) be that large.
5013
19ab8a18
PE
5014 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5015 This is less likely to overflow, and avoids undefined behavior if
5016 overflow does occur. All callers changed. Use strtoul to scan
5017 for the unsigned long integer.
b7cbbd6f
PE
5018 (pint2hrstr): Simplify and tune code slightly.
5019 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5020
f0641eff
PE
5021 * scroll.c (do_scrolling): Work around GCC bug 48228.
5022 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5023
7f650bb9
PE
5024 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5025 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5026 (validate_x_resource_name): Simplify count usage.
5027 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5028
37dd57d1
PE
5029 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5030 fail (Bug#8306).
81e56e61 5031
699979fc 5032 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5033
401bf9b4
PE
5034 * process.c (Fmake_network_process): Use socklen_t, not int,
5035 where POSIX says socklen_t is required in portable programs.
5036 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5037 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5038 (Fmake_network_process, server_accept_connection):
5039 (wait_reading_process_output, read_process_output):
5040 Likewise.
5041
b93aacde
PE
5042 * process.c: Rename or move locals to avoid shadowing.
5043 (list_processes_1, Fmake_network_process):
5044 (read_process_output_error_handler, exec_sentinel_error_handler):
5045 Rename or move locals.
4dc343ee 5046 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5047 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5048 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5049 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5050 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5051
af8a867c 5052 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5053 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5054 Include tparam.h instead, since it declares them.
af8a867c
PE
5055 * cm.h (PC): Remove extern decl; tparam.h now does this.
5056 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5057 * terminfo.c: Include tparam.h, to check interfaces.
5058 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5059 (tparam): Adjust signature to match interface in tparam.h;
5060 this removes some undefined behavior. Check that outstring and len
5061 are zero, which they always are with Emacs.
5062 * tparam.h (PC, BC, UP): New extern decls.
5063
0248044d 5064 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5065 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5066
8ff096c1 5067 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5068 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5069 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5070 (ftfont_list): Remove unused local.
49eaafba
PE
5071 (get_adstyle_property, ftfont_pattern_entity):
5072 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5073 Rename locals to avoid shadowing.
8ff096c1 5074
e2be39f6
PE
5075 * xfont.c (xfont_list_family): Mark var as initialized.
5076
c9735e30
PE
5077 * xml.c (make_dom): Now static.
5078
8f5201ae
PE
5079 * composite.c (composition_compute_stop_pos): Rename local to
5080 avoid shadowing.
b246f932
PE
5081 (composition_reseat_it): Remove unused locals.
5082 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5083 (composition_update_it): Mark var as initialized.
11b61122
PE
5084 (find_automatic_composition): Mark vars as initialized,
5085 with a FIXME (Bug#8290).
8f5201ae 5086
760fbc2c
PE
5087 character.h: Rename locals to avoid shadowing.
5088 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5089 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5090 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5091 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5092 to avoid shadowing.
5093
ff08eb85
PE
5094 * textprop.c (property_change_between_p): Remove; unused.
5095
fc7bf025
PE
5096 * intervals.c (interval_start_pos): Now static.
5097
235d7abc
PE
5098 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5099
44f230aa
SM
5100 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5101 Rename locals to avoid shadowing.
3e7d6594 5102
50060332
PE
5103 * sound.c (wav_play, au_play, Fplay_sound_internal):
5104 Fix pointer signedness.
d01f234b 5105 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5106 (wav_play): Initialize a variable to 0, to prevent undefined
5107 behavior (Bug#8278).
50060332 5108
c4fc4e30
PE
5109 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5110
918436ed
PE
5111 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5112
c939f91b
PE
5113 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5114 clobbering (Bug#8298).
b9c7f648
PE
5115 * sysdep.c (sys_subshell): Likewise.
5116 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5117
6bd8c144
PE
5118 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5119 This should get cleaned up, so that child_setup has the
5120 same signature on all platforms.
5121
7710357c 5122 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5123 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5124
c59da222
CY
51252011-03-22 Chong Yidong <cyd@stupidchicken.com>
5126
5127 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5128 not to be necessary, and produces flickering.
5129
66b87493
GM
51302011-03-20 Glenn Morris <rgm@gnu.org>
5131
5132 * config.in: Remove file.
5133
45b6f6d5
JB
51342011-03-20 Juanma Barranquero <lekktu@gmail.com>
5135
5136 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5137 are now in src/globals.h.
5138 (syms_of_minibuf): Remove spurious & from previous change.
5139
3ec03f7e
LL
51402011-03-20 Leo <sdl.web@gmail.com>
5141
5142 * minibuf.c (completing-read-function): New variable.
5143 (completing-read-default): Rename from completing-read.
5144 (completing-read): Call completing-read-function.
5145
b14e3e21
CY
51462011-03-19 Juanma Barranquero <lekktu@gmail.com>
5147
5148 * xfaces.c (Fx_load_color_file):
5149 Read color file from absolute filename (bug#8250).
5150
f2b726e6
JB
51512011-03-19 Juanma Barranquero <lekktu@gmail.com>
5152
5153 * makefile.w32-in: Update dependencies.
5154
09f6ff02
EZ
51552011-03-17 Eli Zaretskii <eliz@gnu.org>
5156
5157 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5158
29a6015a
PE
51592011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5160
a3a6c54e
PE
5161 Fix more problems found by GCC 4.5.2's static checks.
5162
b766f867
PE
5163 * process.c (make_serial_process_unwind, send_process_trap):
5164 (sigchld_handler): Now static.
5165
be02381c
PE
5166 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5167 That way, the code declares only the vars that it needs.
5168 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5169 * s/cygwin.h (PTY_ITERATION): Likewise.
5170 * s/darwin.h (PTY_ITERATION): Likewise.
5171 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5172
57048744
PE
5173 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5174 * process.c (allocate_pty): Don't declare stb unless it's needed.
5175
7914961c 5176 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5177 (CONSTANTLIM): Remove; unused.
5178 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5179 Define only if needed.
7914961c 5180
b3967b18
PE
5181 * unexelf.c (unexec): Name an expression,
5182 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5183 Use a different way to cause a compilation error if anyone uses
5184 n rather than nn, a way that does not involve shadowing.
73366a00 5185 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5186
29a6015a
PE
5187 * deps.mk (unexalpha.o): Remove; unused.
5188
43cfc33e 5189 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5190 * unexec.h: New file.
ce701a33
PE
5191 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5192 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5193 Depend on unexec.h.
5194 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5195 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5196 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5197 Change as necessary to match prototype in unexec.h.
ce701a33 5198
01f44d5a
PE
5199 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5200 shadowing.
4f63c6bb 5201 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5202
a6670b0b
PE
5203 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5204 Rename locals to avoid shadowing.
5205
cef2010d 5206 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5207 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5208
d4d7173a
PE
5209 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5210
f08b802a
PE
5211 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5212 warning when compiling print.c.
5213
3ddb0639
PE
5214 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5215 instead of using an uninitialized var.
5ad03b97 5216 (font_sort_entities): Mark var as initialized.
3ddb0639 5217
170a2692
PE
5218 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5219
e663c700
PE
5220 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5221 pointers to constants.
89bc529a 5222 (font_parse_fcname): Remove unused vars.
7b81e2d0 5223 (font_delete_unmatched): Now static.
ea838e10 5224 (font_get_spec): Remove; unused.
13a547c6
PE
5225 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5226 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5227 Rename or move locals to avoid shadowing.
e663c700 5228
2a80c887 5229 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5230 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5231
1384fa33 5232 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5233 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5234
8b2c52e9
PE
5235 * alloc.c (mark_backtrace): Move decl from here ...
5236 * lisp.h: ... to here, so that it can be checked.
5237
475545b5 5238 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5239 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5240 (lisp_indirect_variable): Name an expression,
5241 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5242 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5243
b1349114 5244 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5245 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5246 Use const pointer when appropriate.
b1349114 5247
a2928364
PE
5248 * lisp.h (get_system_name, get_operating_system_release):
5249 Move decls here, to check interfaces.
5250 * process.c (get_operating_system_release): Move decl to lisp.h.
5251 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5252 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5253 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5254 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5255 (Fformat_time_string, Fencode_time, Finsert_char):
5256 (Ftranslate_region_internal, Fformat):
5257 Rename or remove local vars to avoid shadowing.
9710023e 5258 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5259
a415e694
PE
5260 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5261 avoid shadowing.
5262
8ef4622d
PE
5263 * lisp.h (eassert): Check that the argument compiles, even if
5264 ENABLE_CHECKING is not defined.
5265
946f9a5b
PE
5266 * data.c (Findirect_variable): Name an expression, to avoid
5267 gcc -Wbad-function-cast warning.
112396d6 5268 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5269 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5270 (Fmake_variable_buffer_local, Fmake_local_variable):
5271 Mark variables as initialized.
52746918 5272 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5273
e5aab7e7 5274 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5275 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5276 Rename locals to avoid shadowing.
dff45157
PE
5277 (mark_stack): Move local variables into the #ifdef region where
5278 they're used.
7bc26fdb
PE
5279 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5280 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5281 needed otherwise.
5282 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5283 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5284 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5285
e5aab7e7
PE
5286 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5287 avoids undefined behavior in theory.
5288
4da60324
PE
5289 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5290
88043301
PE
5291 Use functions, not macros, for up- and down-casing (Bug#8254).
5292 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5293 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5294 to use the following functions instead of these macros.
5295 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5296 EMACS_INT, since callers assume the returned value fits in int.
5297 (upcase1): Likewise, for UPCASE_TABLE.
5298 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5299 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5300 the race-condition problem in the old DOWNCASE.
88043301 5301
19ed5445
PE
5302 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5303 Rename locals to avoid shadowing.
5304 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5305 (regex_compile, re_search_2, re_match_2_internal):
5306 Remove unused local vars.
952db0d7
PE
5307 (FREE_VAR): Rewrite so as not to use empty "else",
5308 which gcc can warn about.
da053e48 5309 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5310 (RETALLOC_IF): Define only if needed.
5311 (WORDCHAR_P): Likewise. This one is never needed, but is used
5312 only in a comment talking about a compiler bug, so put inside
5313 the #if 0 of that comment.
5314 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5315 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5316 Remove; unused.
19ed5445 5317
1f3561e4 5318 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5319 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5320 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5321
ded6f8f7
PE
5322 * search.c (simple_search): Remove unused var.
5323
dbd37a95
PE
5324 * dired.c (compile_pattern): Move decl from here ...
5325 * lisp.h: ... to here, so that it can be checked.
5326 (struct re_registers): New forward decl.
5327
7e47afad
PE
5328 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5329
85f24f61
PE
5330 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5331 All uses changed.
5332 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5333 Rename locals to avoid shadowing.
5671df8f 5334 (Fvertical_motion): Mark locals as initialized.
85f24f61 5335
181aa2be 5336 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5337 (casify_region): Mark local as initialized.
181aa2be 5338
930d429c
PE
5339 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5340
7082eac6
PE
5341 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5342 New macros, so that the caller can use some names other than
5343 gcpro1, gcpro2, etc.
5344 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5345 of the new macros.
5346 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5347 argument, for consistency with GCPRO2_VAR, etc: it is now the
5348 prefix of the variable, not the variable itself. All uses
5349 changed.
38b2c076
PE
5350 * dired.c (directory_files_internal, file_name_completion):
5351 Rename locals to avoid shadowing.
5352
15206ed9
PE
5353 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5354 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5355 dired.c's scmp function, had undefined behavior.
5356 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5357 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5358 * buffer.h: ... to here, because these macros use current_buffer,
5359 and the new implementation with inline functions needs to have
5360 current_buffer in scope now, rather than later when the macros
5361 are used.
5362 (downcase, upcase1): New static inline functions.
5363 (DOWNCASE, UPCASE1): Reimplement using these functions.
5364 This avoids undefined behavior in expressions like
5365 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5366 from race conditions in accessing the global variables
5367 case_temp1 and case_temp2.
5368 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5369 * lisp.h (case_temp1, case_temp2): Remove their decls.
5370 * character.h (ASCII_CHAR_P): Move from here ...
5371 * lisp.h: ... to here, so that the inline functions mentioned
5372 above can use them.
5373
4a6bea26
PE
5374 * dired.c (directory_files_internal_unwind): Now static.
5375
f14b7e14
PE
5376 * fileio.c (file_name_as_directory, directory_file_name):
5377 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5378 Now static.
2893f146
PE
5379 (file_name_as_directory): Use const pointers when appropriate.
5380 (Fexpand_file_name): Likewise. In particular, newdir might
5381 point at constant storage, so make it a const pointer.
fd4ead52 5382 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5383 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5384 signedness issues.
f839df0c
PE
5385 (Fset_file_times, Finsert_file_contents, auto_save_error):
5386 Rename locals to avoid shadowing.
f14b7e14 5387
5716756e 5388 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5389 (Ftry_completion, Fall_completions): Rename or remove locals
5390 to avoid shadowing.
5716756e 5391
b4c3046a
PE
5392 * marker.c (bytepos_to_charpos): Remove; unused.
5393
b45db522
PE
5394 * lisp.h (verify_bytepos, count_markers): New decls,
5395 so that gcc does not warn that these functions aren't declared.
5396
85876d07
PE
5397 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5398 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5399 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5400 (copy_text): Remove unused local var.
85876d07 5401
03d78a21 5402 * filelock.c (within_one_second): Now static.
b3dd38ab 5403 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5404
5df8f01b
PE
5405 * buffer.c (fix_overlays_before): Mark locals as initialized.
5406 (fix_start_end_in_overlays): Likewise. This function should be
5407 simplified by using pointers-to-pointers, but that's a different
5408 matter.
b1d876f1 5409 (switch_to_buffer_1): Now static.
8f54f30a
PE
5410 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5411 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5412
a70072c9 5413 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5414 Fix pointer signedness issue.
edced198
PE
5415 (sys_subshell): Mark local as volatile if checking for lint,
5416 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5417 (MAXPATHLEN): Define only if needed.
a70072c9 5418
a0977c44
PE
5419 * process.c (serial_open, serial_configure): Move decls from here ...
5420 * systty.h: ... to here, so that they can be checked.
5421
a884fdcc
PE
5422 * fns.c (get_random, seed_random): Move extern decls from here ...
5423 * lisp.h: ... to here, so that they can be checked.
5424
604efe86 5425 * sysdep.c (reset_io): Now static.
b8950c94 5426 (wait_for_termination_signal): Remove; unused.
604efe86 5427
38fc62d9
PE
5428 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5429 (copy_keymap_item, append_key, push_text_char_description):
5430 Now static.
1004a21a 5431 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5432 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5433 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5434 (describe_map_tree):
5435 Rename locals to avoid shadowing.
38fc62d9 5436
2f2650da
PE
5437 * keyboard.c: Declare functions static if they are not used elsewhere.
5438 (echo_char, echo_dash, cmd_error, top_level_2):
5439 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5440 (read_char, kbd_buffer_get_event, make_lispy_position):
5441 (make_lispy_event, make_lispy_movement, apply_modifiers):
5442 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5443 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5444 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5445 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5446 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5447
a053e86c 5448 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5449 (mark_kboards): Move decl here ...
5450 * alloc.c (mark_kboards): ... from here.
a053e86c 5451
4752793e
PE
5452 * lisp.h (force_auto_save_soon): New decl.
5453
74f10ca7 5454 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5455 (DEFINE_DUMMY_FUNCTION): New macro.
5456 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5457 Use it.
c03cd23f
PE
5458 (main): Add casts to avoid warnings
5459 if GCC considers string literals to be constants.
74f10ca7 5460
022e70d4
PE
5461 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5462
59d6fe83
PE
5463 * dbusbind.c: Pointer signedness fixes.
5464 (xd_signature, xd_append_arg, xd_initialize):
5465 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5466 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5467 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5468 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5469
78320123
PE
5470 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5471 if GCC considers string literals to be constants.
49cebcca 5472 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5473
35ac2a97
SM
54742011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5475
fb103ca9
SM
5476 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5477 (print_preprocess, print_object): New macro to fix last change.
5478
35ac2a97
SM
5479 * print.c (print_preprocess): Don't forget font objects.
5480
62973b41
JB
54812011-03-16 Juanma Barranquero <lekktu@gmail.com>
5482
5483 * emacs.c (USAGE3): Doc fixes.
5484
0e48bb22
AS
54852011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5486
5487 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5488 structure.
5489
7684e57b
JB
54902011-03-14 Juanma Barranquero <lekktu@gmail.com>
5491
5492 * lisp.h (VWindow_system, Qfile_name_history):
5493 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5494 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5495 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5496
5497 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5498 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5499
5500 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5501 * w32console.c (detect_input_pending, read_input_pending)
5502 (encode_terminal_code):
5503 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5504 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5505 (w32_system_caret_y, Qfile_name_history):
5506 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5507 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5508 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5509 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5510 * w32proc.c (Qlocal, report_file_error):
5511 * w32term.c (Vwindow_system, updating_frame):
5512 * w32uniscribe.c (initialized, uniscribe_font_driver):
5513 Remove unneeded extern declarations.
5514
2aa46d6c
CY
55152011-03-14 Chong Yidong <cyd@stupidchicken.com>
5516
c96bbc66 5517 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5518
cffc6f3b
CY
55192011-03-13 Chong Yidong <cyd@stupidchicken.com>
5520
5521 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5522 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5523 These macros can no longer be used for assignment.
5524
44f230aa
SM
5525 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5526 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5527 (record_buffer_markers, fetch_buffer_markers): New functions for
5528 recording and fetching special buffer markers.
5529 (set_buffer_internal_1, set_buffer_temp): Use them.
5530
5531 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5532
5533 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5534
5535 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5536 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5537
5538 * xdisp.c (hscroll_window_tree):
5539 (reconsider_clip_changes): Use PT instead of BUF_PT.
5540
d251f04b
EZ
55412011-03-13 Eli Zaretskii <eliz@gnu.org>
5542
5543 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5544 $(EMACS_ROOT)/lib/intprops.h.
5545
f0c77cd1
PE
55462011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5547
3eca4629
PE
5548 Fix more problems found by GCC 4.5.2's static checks.
5549
7c86ee98
PE
5550 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5551 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5552 (xg_free_frame_widgets): Make it clear that a local variable is
5553 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5554 (gdk_window_get_screen): Make it clear that this macro is needed
5555 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5556 (int_gtk_range_get_value): New function, which avoids a diagnostic
5557 from gcc -Wbad-function-cast.
5558 (xg_set_toolkit_scroll_bar_thumb): Use it.
5559 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5560 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5561 (get_utf8_string, xg_get_file_with_chooser):
5562 Rename locals to avoid shadowing.
5563 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5564
41729b81
PE
5565 * xgselect.c (xg_select): Remove unused var.
5566
f0c77cd1
PE
5567 * image.c (four_corners_best): Mark locals as initialized.
5568 (gif_load): Initialize transparent_p to zero (Bug#8238).
5569 Mark another local as initialized.
ec6cf4c6 5570 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5571
ce0ad53d 5572 * image.c (clear_image_cache): Now static.
d5d5a617 5573 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5574 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5575 (x_edge_detection): Remove unnecessary cast that
5576 gcc -Wbad-function-cast diagnoses.
2037898d 5577 (gif_load): Fix pointer signedness.
6ae141d6
PE
5578 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5579 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5580
33383987 55812011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5582
d32df629
PE
5583 Improve quality of tests for time stamp overflow.
5584 For example, without this patch (encode-time 0 0 0 1 1
5585 1152921504606846976) returns the obviously-bogus value (-948597
5586 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5587 reports time overflow. See
5588 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5589 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5590 * editfns.c: Include limits.h and intprops.h.
5591 (TIME_T_MIN, TIME_T_MAX): New macros.
5592 (time_overflow): Move earlier, to before first use.
5593 (hi_time, lo_time): New functions, for an accurate test for
5594 out-of-range times.
5595 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5596 (Fget_internal_run_time): Don't assume time_t fits in int.
5597 (make_time): Use list2 instead of Fcons twice.
5598 (Fdecode_time): More accurate test for out-of-range times.
5599 (check_tm_member): New function.
5600 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5601 (lisp_time_argument): Don't rely on undefined left-shift and
5602 right-shift behavior when checking for time stamp overflow.
8be6f318 5603
fe31d94c
PE
5604 * editfns.c (time_overflow): New function, refactoring common code.
5605 (Fformat_time_string, Fdecode_time, Fencode_time):
5606 (Fcurrent_time_string): Use it.
5607
8be6f318
PE
5608 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5609 * dired.c (make_time): Move to ...
5610 * editfns.c (make_time): ... here.
5611 * systime.h: Note the move.
5612
09d9db2c 56132011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5614
126bc0dc
YM
5615 * fringe.c (update_window_fringes): Remove unused variables.
5616
c47cbdfd
YM
5617 * unexmacosx.c (copy_data_segment): Also copy __got section.
5618 (Bug#8223)
5619
7ac80be9
EZ
56202011-03-12 Eli Zaretskii <eliz@gnu.org>
5621
c96bbc66 5622 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5623 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5624 Constify `char *' arguments and their references according to
5625 prototypes in tparam.h.
5626
ecb0f94d 5627 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5628
7ac80be9
EZ
5629 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5630 Adapt all references accordingly.
5631
5632 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5633
ef1fd07e
TT
56342011-03-11 Tom Tromey <tromey@redhat.com>
5635
5636 * buffer.c (syms_of_buffer): Remove obsolete comment.
5637
7ef4b50c
EZ
56382011-03-11 Eli Zaretskii <eliz@gnu.org>
5639
5640 * termhooks.h (encode_terminal_code): Declare prototype.
5641
5642 * msdos.c (encode_terminal_code): Don't declare prototype.
5643
5644 * term.c (encode_terminal_code): Now external again, used by
5645 w32console.c and msdos.c.
5646
44f230aa
SM
5647 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5648 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5649
4b1ec863 56502011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5651
1714f52b 5652 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5653
4b1ec863
PE
5654 * fringe.c (update_window_fringes): Mark locals as initialized
5655 (Bug#8227).
5656 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5657
524c7aa6
PE
5658 * alloc.c (mark_fringe_data): Move decl from here ...
5659 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5660 to check its interface.
5661 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5662
a5c0af81 5663 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5664 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5665 (fontset_font): Mark local as initialized.
a9a06e0b 5666 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5667
b4716021
PE
5668 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5669
811e9bac 5670 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5671 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5672 (x_own_selection, Fx_disown_selection_internal): Rename locals
5673 to avoid shadowing.
5674 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5675
7e3ab302
PE
5676 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5677 so that the caller can use some name other than gcpro1.
5678 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5679 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5680 (Fx_backspace_delete_keys_p):
5681 Use them to avoid shadowing, and rename vars to avoid shadowing.
5682 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5683 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5684 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5685 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5686 Remove unused locals.
7e3ab302
PE
5687 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5688 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5689 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5690 macros.
f78faa98 5691
e2b13473
PE
5692 * xterm.h (x_mouse_leave): New decl.
5693
77f23912
PE
5694 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5695 Remove unused functions.
cdf4ba58
PE
5696 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5697 (x_calc_absolute_position): Now static.
7411c686 5698 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5699 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5700 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5701 unless they are used.
38d0b34a
PE
5702 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5703 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5704 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5705 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5706 (x_error_catcher, x_connection_closed, x_error_handler):
5707 (x_error_quitter, xembed_send_message, x_iconify_frame):
5708 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5709 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5710 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5711
44f230aa
SM
5712 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5713 Rename or move locals to avoid shadowing.
6b463e58 5714 (tty_defined_color, merge_face_heights): Now static.
5967d051 5715 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5716 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5717 does not deduce is never used uninitialized.
73719eba
PE
5718 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5719 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5720
426994c3 5721 * terminal.c (store_terminal_param): Now static.
5489860b 5722
032f1620 5723 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5724 (set_frame_menubar): Remove unused local.
d4323972 5725 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5726 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5727 since they might point to immutable storage.
281585b0
PE
5728 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5729 since it's unused otherwise.
032f1620 5730
367c19e5 5731 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5732 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5733 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5734 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5735 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5736 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5737 does not deduce are never used uninitialized.
70739cbe 5738
07b48fa9
PE
5739 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5740
8868a238 5741 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5742 * window.c (window_loop, size_window):
5743 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5744
7e5cf297 5745 * window.c (display_buffer): Now static.
d6550a9f
PE
5746 (size_window): Mark variables that gcc -Wuninitialized
5747 does not deduce are never used uninitialized.
a586633d
PE
5748 * window.h (check_all_windows): New decl, to forestall
5749 gcc -Wmissing-prototypes diagnostic.
5b555da1 5750 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5751
f6095868
PE
5752 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5753 shadowing.
5754 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5755 Include <limits.h>.
5756 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5757 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5758 (load_charset_map): Mark variables that gcc -Wuninitialized
5759 does not deduce are never used uninitialized.
53df7c11 5760 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5761
f38b440c
PE
5762 * coding.c (coding_set_source, coding_set_destination):
5763 Use "else { /* comment */ }" rather than "else /* comment */;"
5764 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5765 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5766 a block, when the outer 'i' will do.
5767 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5768 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5769 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5770 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5771 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5772 Rename locals to avoid shadowing.
5773 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5774 * coding.c (emacs_mule_char, encode_invocation_designation):
5775 Now static, since they're not used elsewhere.
413bb2db 5776 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5777 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5778 (decode_coding_emacs_mule): Mark variables that gcc
5779 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5780 (detect_coding_iso_2022): Initialize a local variable that might
5781 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5782 this initialization is needed. (Bug#8211)
5f58e762
PE
5783 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5784 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5785 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5786 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5787 Remove unused macros.
f38b440c 5788
232b38b9 5789 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5790 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5791 * character.c (string_count_byte8): Likewise.
232b38b9 5792
fb90da1b
PE
5793 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5794 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5795
fb93dbc2
PE
5796 * chartab.c (copy_sub_char_table): Now static, since it's not used
5797 elsewhere.
5c156ace
PE
5798 (sub_char_table_ref_and_range, char_table_ref_and_range):
5799 Rename locals to avoid shadowing.
bbcd0949 5800 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5801
7d3b3862 5802 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5803 (BIDI_BOB): Remove unused macro.
7d3b3862 5804
6be7d3da
PE
5805 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5806 deduce are never used uninitialized.
c2ed9c8b 5807 * term.c (encode_terminal_code): Likewise.
6be7d3da 5808
75f8807f 5809 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5810
50938595
PE
5811 * tparam.h: New file.
5812 * term.c, tparam.h: Include it.
5813 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5814 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5815 Move these decls to tparam.h, and make them agree with what
5816 is actually in tparam.c. The previous trick of using incompatible
5817 decls in different modules does not conform to the C standard.
5818 All callers of tparam changed to use tparam's actual API.
5819 * tparam.c (tparam1, tparam, tgoto):
5820 Use const pointers where appropriate.
5821
fbceeba2
PE
5822 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5823 * cm.h (struct cm): Likewise.
5824 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5825 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5826 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5827 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5828 (turn_on_face, init_tty): Likewise.
5829 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5830
7f3f1250
PE
5831 * term.c (term_mouse_position): Rename local to avoid shadowing.
5832
e6ca6543
PE
5833 * alloc.c (mark_ttys): Move decl from here ...
5834 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5835
c40f8d15
AS
58362011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5837
5838 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5839
cfe0661d
JB
58402011-03-09 Juanma Barranquero <lekktu@gmail.com>
5841
5842 * search.c (compile_pattern_1): Remove argument regp, unused since
5843 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5844 (compile_pattern): Don't pass it.
5845
0afb4571
J
58462011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5847
5848 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5849 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5850 for ! HAVE_GTK3.
5851 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5852
5853 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5854
5855 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5856 gdk_window_get_screen, gdk_window_get_geometry,
5857 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5858 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5859 (xg_get_pixbuf_from_pixmap): New function.
5860 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5861 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5862 Call xg_get_pixbuf_from_pixmap instead of
5863 gdk_pixbuf_get_from_drawable.
5864 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5865 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5866 (xg_check_special_colors): Use GtkStyleContext and its functions
5867 for HAVE_GTK3.
5868 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5869 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5870 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5871 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5872 Call gtk_widget_get_preferred_size.
0afb4571
J
5873 (xg_frame_resized): gdk_window_get_geometry only takes 5
5874 parameters.
44f230aa
SM
5875 (xg_win_to_widget, xg_event_is_for_menubar):
5876 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5877 (xg_set_widget_bg): New function.
5878 (delete_cb): New function.
895009e1 5879 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5880 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5881 (xg_set_background_color): Call xg_set_widget_bg.
5882 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5883 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5884 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5885 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5886 if ! HAVE_GTK3.
5887 (update_frame_tool_bar): Call gtk_widget_hide.
5888 (xg_initialize): Use GDK_KEY_g.
5889
5890 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5891 if ! HAVE_GTK3
5892 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5893
5894 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5895 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5896 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5897
1c2cc4ef
JB
58982011-03-08 Juanma Barranquero <lekktu@gmail.com>
5899
5900 * w32xfns.c (select_palette): Check success of RealizePalette against
5901 GDI_ERROR, not zero.
5902
33383987 5903See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5904
5905;; Local Variables:
5906;; coding: utf-8
aac0c6e3
MR
5907;; End:
5908
33383987 5909 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5910
5911 This file is part of GNU Emacs.
5912
5913 GNU Emacs is free software: you can redistribute it and/or modify
5914 it under the terms of the GNU General Public License as published by
5915 the Free Software Foundation, either version 3 of the License, or
5916 (at your option) any later version.
5917
5918 GNU Emacs is distributed in the hope that it will be useful,
5919 but WITHOUT ANY WARRANTY; without even the implied warranty of
5920 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5921 GNU General Public License for more details.
5922
5923 You should have received a copy of the GNU General Public License
5924 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.