Disallow windows on dead frames in decode_any_window.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6e5d1c12
CY
12012-07-21 Chong Yidong <cyd@gnu.org>
2
3 * window.c (decode_any_window): Signal an error if the window is
4 on a dead frame (Bug#11984).
5
9928463d
DA
62012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
7
8 Add indirection counting to speed up Fkill_buffer.
9 * buffer.h (struct buffer): New member.
10 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
11 (Fmake_indirect_buffer): Set indirection counter to -1, increment
12 base buffer indirection counter.
13 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
14 (Fkill_buffer): Adjust indirection counters as needed, don't walk
15 through buffer list if indirection counter is 0.
16
f8643a6b
DA
172012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
18
19 Extend the value returned by Fgarbage_collect with heap statistics.
20 * alloc.c (Qheap): New symbol.
21 (syms_of_alloc): DEFSYM it.
22 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
23 (Fmemory_free): Remove.
24 (syms_of_alloc): Don't defsubr it.
25 * buffer.c (Fcompact_buffer): Remove.
26 (syms_of_buffer): Don't defsubr it.
27
dac616ff
DA
282012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Make maybe_gc inline.
31 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
32 * lisp.h (consing_since_gc, gc_relative_threshold)
33 (memory_full_cons_threshold): Revert declaration.
34 (maybe_gc): Remove prototype, define as inline.
35 * alloc.c: Remove old commented-out code.
36 (consing_since_gc, gc_relative_threshold)
37 (memory_full_cons_threshold): Revert to global.
38 (maybe_gc): Remove.
39
d7ea76b4
DA
402012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
41
42 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
43 * lisp.h (build_unibyte_string): New function.
44 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
45 * sysdep.c, w32fns.c, xfns.c: Use it.
46 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
47 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
48 Adjust users accordingly.
49 * font.h (font_open_by_name): Adjust prototype.
50
765e61e3
DA
512012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
52
53 Cleanup calls to Fgarbage_collect.
54 * lisp.h (maybe_gc): New prototype.
55 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
56 Remove declarations.
57 * alloc.c (maybe_gc): New function.
58 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
59 Make them static.
60 * bytecode.c (MAYBE_GC): Use maybe_gc.
61 * eval.c (eval_sub, Ffuncall): Likewise.
62 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
63 to avoid dependency from auto-save feature.
64
52b852c7
PE
652012-07-19 Paul Eggert <eggert@cs.ucla.edu>
66
67 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
68 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
69 'for_each_per_buffer_object_at'.
70 All uses changed. It's better to use upper-case for macros that
71 cannot be implemented as functions, to give the reader a clue
72 that they're special.
73
5db81e33
SM
742012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
75
76 * alloc.c (Fgarbage_collect): Tweak docstring.
77
5b835e1d
DA
782012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
79
80 Tweak the value returned from Fgarbage_collect again.
81 * alloc.c (Fgarbage_collect): New return value, as confirmed in
82 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
83 Adjust documentation.
84 (total_vector_bytes): Rename to total_vector_slots, adjust
85 accounting.
86 (total_free_vector_bytes): Rename to total_free_vector_slots,
87 adjust accounting.
88 (Qstring_bytes, Qvector_slots): New symbols.
89 (syms_of_alloc): DEFSYM them.
90
9cd47b72
DA
912012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
92
93 Buffer compaction primitive which may be used from Lisp.
94 * buffer.c (compact_buffer, Fcompact_buffer): New function.
95 (syms_of_buffer): Register Fcompact_buffer.
96 * alloc.c (Fgarbage_collect): Use compact_buffer.
97 * buffer.h (compact_buffer): New prototype.
98 (struct buffer_text): New member.
99
d17337e5
DA
1002012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
101
102 New macro to iterate over all buffers, miscellaneous cleanups.
103 * lisp.h (all_buffers): Remove declaration.
104 * buffer.h (all_buffers): Add declaration, with comment.
105 (for_each_buffer): New macro.
106 * alloc.c (Fgarbage_collect, mark_object): Use it.
107 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
108 (init_buffer): Likewise.
109 * data.c (Fset_default): Likewise.
110 * coding.c (code_conversion_restore): Remove redundant check
111 for dead buffer.
112 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
113
60cfd278
AS
1142012-07-18 Andreas Schwab <schwab@linux-m68k.org>
115
116 Fix bug that created negative-length intervals.
117 * intervals.c (merge_interval_right, merge_interval_left):
118 Do not zero out this interval if it is absorbed by its children,
119 as this interval's total length doesn't change in that case. See
120 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
121
d06714cb
PE
1222012-07-18 Paul Eggert <eggert@cs.ucla.edu>
123
83713154
PE
124 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
125 when invoking (make-bool-vector N t) and N is a positive
126 multiple of 8 -- the last 8 bits were mistakenly cleared.
127
d06714cb
PE
128 Remove some struct layout assumptions in bool vectors.
129 * alloc.c (bool_header_size): New constant.
130 (header_size, word_size): Move earlier, as they're now used earlier.
131 Use 'word_size' in a few more places, where it's appropriate.
132 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
133 padding before the data member of a bool vector.
134 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
135 than doing the check by hand with an abort ().
136
464d5a5e
SM
1372012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
138
5fbc0409
SM
139 * eval.c (Fdefvar): Don't check constants since we only set the var if
140 it's not yet defined anyway (bug#11904).
141
464d5a5e
SM
142 * lisp.h (last_undo_boundary): Declare new var.
143 * keyboard.c (command_loop_1): Set it.
144 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
145 were auto-added by the command loop (bug#11774).
146
8dc2e44a
AS
1472012-07-18 Andreas Schwab <schwab@linux-m68k.org>
148
149 * w32font.c (Qsymbol): Remove local definition.
150 (syms_of_w32font): Don't DEFSYM it.
151
169925ec
DA
1522012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Fix sweep_vectors to handle large bool vectors correctly.
155 * alloc.c (sweep_vectors): Account total_vector_bytes for
156 bool vectors larger than VBLOCK_BYTES_MAX.
157
5fbfb018
CY
1582012-07-18 Chong Yidong <cyd@gnu.org>
159
160 * frame.c (x_set_frame_parameters): Revert bogus change introduced
161 in 2012-05-25 commit by Paul Eggert (Bug#11738).
162
3ab6e069
DA
1632012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
164
165 Return more descriptive data from Fgarbage_collect.
166 Suggested by Stefan Monnier in
167 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
168 * alloc.c (bounded_number): New function.
169 (total_buffers, total_vectors): New variable.
170 (total_string_size): Rename to total_string_bytes, adjust users.
171 (total_vector_size): Rename to total_vector_bytes, adjust users.
172 (sweep_vectors): Account total_vectors and total_vector_bytes.
173 (Fgarbage_collect): New return value. Adjust documentation.
174 (gc_sweep): Account total_buffers.
175 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
176 (VECTOR_SIZE): Remove.
177 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
178 (Qinterval, Qmisc): New symbols.
179 (syms_of_data): Initialize them.
180 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
181 (Qcons, Qbuffer): New declarations.
182
6d02fe5b
PE
1832012-07-17 Paul Eggert <eggert@cs.ucla.edu>
184
185 * alloc.c (Fmemory_free): Account for memory-free's own storage.
186 Round up, not down. Improve doc.
187
b7ffe040
DA
1882012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Restore old code in allocate_string_data to avoid Faset breakage.
191 Reported by Julien Danjou <julien@danjou.info> in
192 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
193 * alloc.c (allocate_string_data): Restore old code with minor
194 adjustments, fix comment to explain this subtle issue.
195
4dc7c8d5
SM
1962012-07-17 Eli Zaretskii <eliz@gnu.org>
197
198 Remove FILE_SYSTEM_CASE.
199 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
200
201 * fileio.c (FILE_SYSTEM_CASE): Don't define.
202 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
203 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
204 call-process-region passes it through expand-file-name.
205
206 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
207
2082012-07-17 Andreas Schwab <schwab@linux-m68k.org>
209
210 Fix crash when creating indirect buffer (Bug#11917)
211 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
212 Don't handle unbound variables specially if non-zero.
213 (Fbuffer_local_variables): Pass zero.
214 (clone_per_buffer_values): Pass non-zero.
215
2162012-07-17 Andreas Schwab <schwab@linux-m68k.org>
217
218 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
219 to make the loop interruptible.
220
2212012-07-17 Andreas Schwab <schwab@linux-m68k.org>
222
223 * gnutls.c (emacs_gnutls_handshake): Only retry if
224 GNUTLS_E_INTERRUPTED.
225
cce7fefc
DA
2262012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
227
228 Cleanup and convert miscellaneous checks to eassert.
229 * alloc.c (mark_interval): Fix comment, partially rephrase
230 old comment from intervals.h (see below).
231 * intervals.c (find_interval, adjust_intervals_for_insertion)
232 (delete_interval, adjust_intervals_for_deletion)
233 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
234 Convert to eassert.
235 (adjust_intervals_for_insertion, make_new_interval):
236 Remove obsolete and unused code.
237 * intervals.h (struct interval): Remove obsolete comment.
238 * textprotp.c (erase_properties): Remove unused code.
239 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
240 (Fremove_list_of_text_properties): Convert to eassert.
241
9ea10cc3
CY
2422012-07-17 Chong Yidong <cyd@gnu.org>
243
244 * editfns.c (Finsert_char): Doc fix.
245
3900d5de
DA
2462012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
247
248 Fix previous change to make Fmemory_free always accurate.
249 * alloc.c (make_interval): Update total_free_intervals.
250 (make_float): Likewise for total_free_floats.
251 (free_cons, Fcons): Likewise for total_free_conses.
252 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
253 Likewise for total_free_vector_bytes.
254 (Fmake_symbol): Likewise for total_free_symbols.
255 (bytes_free): Remove.
256
7098646f
DA
2572012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
258
259 Simple free memory accounting feature.
260 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
261 (sweep_vectors): Accumulate size of free vectors.
262 (Fgarbage_collect): Setup bytes_free.
263 (Fmemory_free): New function.
264 (syms_of_alloc): Register it.
265
22657b40
DA
2662012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
267
268 Cleanup overlays checking.
269 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
270 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
271 eassert and OVERLAYP.
272 (sort_overlays): Change to use OVERLAYP.
273
ddfc8813
RK
2742012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
275
276 * editfns.c (Finsert_char): Make it interactive, and make the
277 second arg optional. Copy interactive spec and docstring from
278 ucs-insert.
279
7c26cf3c
PE
2802012-07-17 Paul Eggert <eggert@cs.ucla.edu>
281
282 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
283 Unlike the other wrapped functions, fabs has an unspecified
284 effect on errno.
285
5d127af9
JD
2862012-07-16 Jan Djärv <jan.h.d@swipnet.se>
287
288 * nsterm.m (keyDown): Interpret flags without left/right bits
289 as the left key (Bug#11670).
290
6a0dd1d7
DA
2912012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Remove empty and useless init functions.
294 * lisp.h (init_character_once, init_fns, init_image)
295 (init_filelock, init_sound): Remove prototype.
296 * character.c (init_character_once): Remove.
297 * filelock.c (init_filelock): Likewise.
298 * fns.c (init_fns): Likewise.
299 * image.c (init_image): Likewise.
300 * sound.c (init_sound): Likewise.
301 * emacs.c (main): Adjust accordingly.
302
7a6136fd
DA
3032012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
304
305 * gtkutil.h: Tiny cleanups.
306 (use_old_gtk_file_dialog): Remove useless declaration.
307 (xg_uses_old_file_dialog): Add suggested const attribute.
308
ce811ad9
EZ
3092012-07-15 Eli Zaretskii <eliz@gnu.org>
310
311 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
312 (bidi_paragraph_init): Use it to limit search forward for a strong
313 directional character in abnormally large paragraphs full of
314 neutral or weak characters. (Bug#11943)
315
c9adfeaa
SF
3162012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
317
318 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
319 the toolbar (Bug#9451).
320 (xg_make_tool_item): Give the widget event box a transparent
321 background.
322
fff62aa9
DA
3232012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
324
325 Cleanup basic allocation variables and functions.
326 * alloc.c (ignore_warnings, init_intervals, init_float)
327 (init_cons, init_symbol, init_marker): Remove.
328 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
329 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
330 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
331 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
332 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
333 (staticidx, init_alloc_once, init_strings, free_ablock):
334 Remove redundant initialization.
335 * fns.c (init_weak_hash_tables): Remove.
336 * lisp.h (init_weak_hash_tables): Remove prototype.
337
9730daca
DA
3382012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
339
340 Use zero_vector where appropriate.
341 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
342 accordingly.
343 * lisp.h (zero_vector): New declaration.
344 * font.c (null_vector): Remove.
345 (syms_of_font): Remove initialization and staticpro.
346 (font_list_entities, font_find_for_lface): Change to use zero_vector.
347 * keymap.c (Faccessible_keymaps): Likewise.
348
2e2d2a13
LL
3492012-07-15 Leo Liu <sdl.web@gmail.com>
350
351 * fringe.c: Fix typo in comments.
352
cd276f6e
LL
3532012-07-14 Leo Liu <sdl.web@gmail.com>
354
355 * fringe.c: Add a new bitmap exclamation-mark.
356
5a1131d9
EZ
3572012-07-14 Eli Zaretskii <eliz@gnu.org>
358
359 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
360
361 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
362 (HAVE_MENUS): Don't define, defined by editing config.in with
363 msdos/sed2v2.inp.
364 (GMALLOC_INHIBIT_VALLOC): Don't define.
365 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
366
22e983b7
JB
3672012-07-14 Juanma Barranquero <lekktu@gmail.com>
368
369 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
370
5b3f250f
GM
3712012-07-14 Glenn Morris <rgm@gnu.org>
372
373 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
374 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
375 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
376
33d63ff4
GM
3772012-07-13 Glenn Morris <rgm@gnu.org>
378
5b633342
GM
379 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
380
33d63ff4
GM
381 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
382 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
383
b55b9f85
JD
3842012-07-13 Jan Djärv <jan.h.d@swipnet.se>
385
0dc8cf50
JD
386 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
387 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
388 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
389 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
390 where appropriate.
391 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
392 as boolean expression.
393 (x_set_window_size): Remove unused variable toolbar.
394 (ns_get_color_default, ns_mod_to_lisp): Remove.
395 (ns_mouse_position): Remove unused variables xchar and ychar.
396 (ns_compute_glyph_string_overhangs): Remove unused variable face.
397 (ns_set_vertical_scroll_bar): Remove unused variable count.
398 (ns_delete_terminal): Remove unused variable i.
399 (ns_term_init): Remove unused variables r, g and b.
400 (mouseDown): Remove unused variable window.
401 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
402 (initFrameFromEmacs): Remove unused variable vbextra.
403 (mouseEntered): Remove unused variables p and dpyinfo.
404 (mouseExited): Remove unused variables p and r.
405 (ns_define_frame_cursor, ns_clear_frame_area)
406 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
407 (menuDown): Assign [sender tag] to variable and cast the variable.
408
409 * nsterm.h (menuDown): Add id as type to argument sender.
410 (ns_display_info_for_name): Add Lisp_Object argument.
411 (ns_term_init): Add Lisp_Object argument.
412 (ns_map_event_to_object): Add void argument.
413 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
414 prototype with arguments and only declare if __OBJC__.
415 (nxatoms_of_nsselect): Add void argument.
416 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
417 (ns_alloc_autorelease_pool): Add void argument.
418 (ns_release_autorelease_pool): Add void* argument.
419 (ns_get_defaults_value): Add const char* argument.
420
421 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
422 (initFromContents): Use SSDATA where appropriate.
423 (ns_update_menubar): Add braces to ambigous if-else.
424 (initWithTitle): Put () around assignment in if statement.
425 (ns_menu_show): Remove unused variables window and keymap.
426 (update_frame_tool_bar): Remove unused variable selected_p.
427 (initWithContentRect): Remove unused variable this_cmd_name.
428
429 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
430 appropriate.
431 (setXBMColor): Remove unused variable len.
432 (setPixmapData): Put () around assignment in loop statement.
433
434 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
435 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
436 where appropriate.
437 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
438 around assignment in loop statement.
439 (nsfont_open): Remove unused variable i.
440 (nsfont_open): Remove unused variable len.
441 (nsfont_draw): Remove unused variable cs.
442
443 * nsfns.m (x_set_icon_name, ns_set_name_internal)
444 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
445 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
446 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
447 (Fns_font_name, Fns_perform_service)
448 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
449 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
450 (ns_set_name): Remove unused variable view.
451 (x_set_menu_bar_lines): Remove unused variable olines.
452 (x_set_tool_bar_lines): Remove unused variable root_window.
453 (Fns_list_colors): Put () around assignment in while statement.
454 (Fns_perform_service): Remove unused variable len.
455 (Fns_display_usable_bounds): Remove unused variable top.
456 (syms_of_nsfns): Remove unused variable i.
457
b55b9f85
JD
458 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
459 memcpy (Bug#11907).
460
ed9265fc 4612012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
462
463 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
464 and free it with DestroyExceptionInfo (Bug#11558).
465
ef099b57
JB
4662012-07-13 Juanma Barranquero <lekktu@gmail.com>
467
468 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
469 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
470 Set here, not in nt/config.nt.
471
ea814a5d
EZ
4722012-07-13 Eli Zaretskii <eliz@gnu.org>
473
474 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
475 cursor overflow into the last glyph on display line when the right
476 fringe is off. (Bug#11832)
477
1a952767
PE
4782012-07-13 Paul Eggert <eggert@cs.ucla.edu>
479
480 * xdisp.c (produce_special_glyphs): Now static.
481 * dispextern.h (produce_special_glyphs): Remove decl.
482
983188fd
GM
4832012-07-13 Glenn Morris <rgm@gnu.org>
484
32fb4bb6
GM
485 * s/bsd-common, s/cygwin.h: Remove empty files.
486 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
487
983188fd
GM
488 * s/usg5-4-common.h (USG, USG5):
489 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
490 * s/sol2-6.h (SOLARIS2):
491 * s/irix6-5.h (IRIX6_5):
492 * s/hpux10-20.h (USG, USG5, HPUX):
493 * s/gnu-linux.h (USG, GNU_LINUX):
494 * s/freebsd.h (BSD_SYSTEM):
495 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
496 * s/cygwin.h (CYGWIN):
497 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
498 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
499
d1e68667 5002012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
501
502 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 503
6de0e799
GM
5042012-07-13 Glenn Morris <rgm@gnu.org>
505
739ae010
GM
506 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
507
dbee5793
GM
508 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
509
6de0e799
GM
510 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
511 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
512
b82da769
GM
5132012-07-12 Glenn Morris <rgm@gnu.org>
514
4fae5a7a 515 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
516
517 * process.c (init_process_emacs): Rename from init_process.
518 The old name is also the name of a Mach system call.
519 * lisp.h, emacs.c: Update for this name change.
520 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
521 longer needed.
522
5a979817
EZ
5232012-07-12 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
526 memmove call that removes glyphs covered by the left truncation
527 glyph. Improve commentary.
528 (display_line): Fix display of continuation glyphs on GUI frames
529 when the right fringe is turned off and variable-size fonts are
530 used in the window. Move the code that appends a stretch glyph to
531 produce_special_glyphs, so that it could be used for truncation
532 and continuation glyphs alike.
533 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
534 glyph of a suitably computed width, to align the special glyphs at
535 the window margin. Code moved from display_line. (Bug#11832)
536
3e91a053
GM
5372012-07-12 Glenn Morris <rgm@gnu.org>
538
ba9e4b84
GM
539 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
540
541 * s/gnu-linux.h, s/hpux10-20.h:
542 Do not unconditionally define HAVE_XRMSETDATABASE.
543
3e91a053
GM
544 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
545
b300b1f4
PE
5462012-07-12 Paul Eggert <eggert@cs.ucla.edu>
547
548 Fix typos that broke OS X build.
549 Reported by Randal L. Schwartz in
550 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
551 * nsterm.m (ns_timeout): Add missing local decl.
552 (ns_get_color): snprintf -> sprintf, to fix typo.
553
6e777848
GM
5542012-07-12 Glenn Morris <rgm@gnu.org>
555
3f922c37
GM
556 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
557 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
558 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
559 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
560
0ab7b23a
GM
561 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
562 Move PTY_OPEN to configure.
563
6e777848
GM
564 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
565 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
566 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
567
4a7edc24
DA
5682012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
569
570 Use empty_unibyte_string where applicable.
571 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
572 * lread.c (read1): Likewise.
573 * xsettings.c (syms_of_xsettings): Likewise.
574
308aab79
GM
5752012-07-12 Glenn Morris <rgm@gnu.org>
576
42bd1719
GM
577 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
578 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
579 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
580 * s/hpux10-20.h (RUN_TIME_REMAP):
581 * s/bsd-common.h (TABDLY): Move to configure.
582
583 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
584
585 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
586
ea0bbd17 587 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 588 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
589
590 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 591
308aab79
GM
592 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
593 * s/template.h: Move NARROWPROTO to configure.
594
ee1cf5cf
GM
5952012-07-11 Glenn Morris <rgm@gnu.org>
596
30fe9bf4
GM
597 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
598 unused since 2011-01-17 change to systty.h.
599
ee1cf5cf
GM
600 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
601 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
602 Move HAVE_PTYS and HAVE_SOCKETS to configure.
603
63e47e07
PE
6042012-07-11 Paul Eggert <eggert@cs.ucla.edu>
605
606 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
607
c43fb4c3
GM
6082012-07-11 Glenn Morris <rgm@gnu.org>
609
610 * s/darwin.h, s/gnu-linux.h, s/template.h:
611 Move INTERRUPT_INPUT to configure.
612
e8df9267
DA
6132012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
614
615 Minor adjustments to interning code.
616 * lisp.h (intern, intern_c_string): Redefine as static inline
617 wrappers for intern_1 and intern_c_string_1, respectively.
618 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
619 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
620 Vobarray checking.
e8df9267
DA
621 * font.c (font_intern_prop): Likewise. Adjust comment.
622 * w32font.c (intern_font_name): Likewise.
623
34348bd4
AS
6242012-07-11 Andreas Schwab <schwab@linux-m68k.org>
625
d96a1e0c
AS
626 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
627
34348bd4
AS
628 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
629 of Fcar/Fcdr if possible.
630 * font.c (check_otf_features): Likewise.
631 * fontset.c (Fnew_fontset): Likewise.
632 * gnutls.c (Fgnutls_boot): Likewise.
633 * minibuf.c (read_minibuf): Likewise.
634 * msdos.c (IT_set_frame_parameters): Likewise.
635 * xmenu.c (Fx_popup_dialog): Likewise.
636 * w32menu.c (Fx_popup_dialog): Likewise.
637
c8add24e
GM
6382012-07-11 Glenn Morris <rgm@gnu.org>
639
4b575b3c
GM
640 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
641 since nothing has defined it on these platforms.
642
09f4e3b0
GM
643 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
644 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
645
172bedef
GM
646 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
647 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
648 Move CLASH_DETECTION to configure.
649
249685df
GM
650 * s/gnu.h: Remove file, which is now empty.
651
c8add24e
GM
652 * s/gnu.h, s/gnu-linux.h:
653 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
654
b41253a3
JW
6552012-07-11 John Wiegley <johnw@newartisans.com>
656
657 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
658 function attribute, so we only use it if it exists in the
659 compiler.
660
d923b542
DA
6612012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
662
663 Avoid call to strlen in fast_c_string_match_ignore_case.
664 * search.c (fast_c_string_match_ignore_case): Change to use
665 length argument. Adjust users accordingly.
666 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
667
5ebbef1d
PE
6682012-07-11 Paul Eggert <eggert@cs.ucla.edu>
669
bb352260
PE
670 Assume mkdir, rmdir.
671 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
672 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
673
57054ddd
PE
674 Assume rename.
675 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
676
b747d3f7
PE
677 Assume perror.
678 * s/hpux10-20.h (HAVE_PERROR): Remove.
679 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
680 Remove dummy definition, as this problem was obsolete long ago.
681
5ebbef1d
PE
682 Assume strerror.
683 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
684
984e7f30
DA
6852012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
686
687 Avoid calls to strlen in font processing functions.
688 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 689 (font_open_by_name): Change to use length argument. Adjust
984e7f30 690 users accordingly.
d923b542
DA
691 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
692 Adjust prototypes.
693 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
694 Change to return ptrdiff_t.
984e7f30
DA
695 (xfont_list_pattern, xfont_match): Use length returned by
696 xfont_decode_coding_xlfd.
697 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
698
20e94fdd
GM
6992012-07-11 Glenn Morris <rgm@gnu.org>
700
9d596af3
GM
701 * s/darwin.h, s/freebsd.h, s/netbsd.h:
702 Move DONT_REOPEN_PTY to configure.
703
20e94fdd
GM
704 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
705 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
706
e99a530f
PE
7072012-07-10 Paul Eggert <eggert@cs.ucla.edu>
708
22ffb973
PE
709 Remove "#define unix" that is no longer needed (Bug#11905).
710 * s/aix4-2.h (unix): Remove; no longer needed.
711
e9a9ae03
PE
712 EMACS_TIME simplification (Bug#11875).
713 This replaces macros (which typically do not work in GDB)
714 with functions, typedefs and enums, making the code easier to debug.
715 The functional style also makes code easier to read and maintain.
716 * systime.h: Include <sys/time.h> on all hosts, not just if
717 WINDOWSNT, since 'struct timeval' is needed in general.
718 (EMACS_TIME): Now a typedef, not a macro.
719 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
720 not macros.
721 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
722 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
723 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
724 (EMACS_TIME_LE): Now functions, not macros.
725 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
726 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
727 which are not functions. All uses rewritten to use:
728 (make_emacs_time): New function.
729 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
730 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
731 not functions. All uses rewritten to use the following, respectively:
732 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
733 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 734 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
735 * fileio.c (Fcopy_file):
736 * xterm.c (XTflash): Get the current time closer to when it's used.
737 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
738
ffacb126
PE
739 * bytecode.c (targets): Suppress -Woverride-init warnings.
740
e99a530f
PE
741 Simplify by avoiding confusing use of strncpy etc.
742 * doc.c (Fsnarf_documentation):
743 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
744 * frame.c (Fmake_terminal_frame):
745 * gtkutil.c (get_utf8_string):
746 * lread.c (openp):
747 * nsmenu.m (ns_update_menubar):
748 * regex.c (regerror):
749 Prefer memcpy to strncpy and strncat when either will do.
750 * fileio.c (Fsubstitute_in_file_name):
751 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
752 (menu_separator_name_p):
753 * nsmenu.m (ns_update_menubar):
754 Prefer memcmp to strncmp when either will do.
755 * nsterm.m: Include <ftoastr.h>.
756 (ns_get_color):
757 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
758 Prefer snprintf to strncpy.
759 * nsterm.m (ns_term_init):
760 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
761 * nsterm.m (ns_term_init):
762 Avoid the need for strncpy, by using build_string or
763 make_unibyte_string directly. Use dtoastr, not snprintf.
764 * process.c (Fmake_network_process): Diagnose service names that
765 are too long, rather than silently truncating them or creating
766 non-null-terminated names.
767 (Fnetwork_interface_info): Likewise, for interface names.
768 * sysdep.c (system_process_attributes) [GNU_LINUX]:
769 Prefer sprintf to strncat.
770 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
771 Prefer vsnprintf to vsprintf + strncpy.
772
c59592b3
GM
7732012-07-10 Glenn Morris <rgm@gnu.org>
774
775 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
776 Clarify fallback case.
777
7d7bbefd
DA
7782012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
779
780 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
781 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
782 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 783 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
784 where argument type is known to be a Lisp_Cons.
785
3a4c8000
TT
7862012-07-10 Tom Tromey <tromey@redhat.com>
787
788 * bytecode.c (BYTE_CODE_THREADED): New macro.
789 (BYTE_CODES): New macro. Replaces all old byte-code defines.
790 (enum byte_code_op): New type.
791 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
792 (exec_byte_code): Use them. Use token threading when applicable.
793
2a0213a6
DA
7942012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
795
796 Optimize pure C strings initialization.
797 * lisp.h (make_pure_string): Fix prototype.
798 (build_pure_c_string): New function, defined as static inline. This
799 provides a better opportunity to optimize away calls to strlen when
800 the function is called with compile-time constant argument.
801 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
802 argument, adjust users accordingly. Use build_pure_c_string where
803 appropriate.
804 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
805 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
806 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
807
cb1caeaf
DA
8082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
809
810 Avoid calls to strlen in miscellaneous functions.
811 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
812 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
813 * lread.c (openp): Likewise.
814
c293e30c
DA
8152012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
816
817 Avoid calls to strlen in path processing functions.
818 * fileio.c (file_name_as_directory): Add comment. Change to add
819 srclen argument and return the length of result. Adjust users
820 accordingly.
821 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 822 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
823 users accordingly.
824 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
825
9e059e3f
GM
8262012-07-10 Glenn Morris <rgm@gnu.org>
827
d02eb359
GM
828 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
829 Move PENDING_OUTPUT_COUNT definition to configure.
830
882cf227
GM
831 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
832 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
833 * s/gnu.h (DATA_START): Move definitions to configure.
834
af6e839f
GM
835 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
836 We include usg5-4-common.h, which defines them both.
837
40289a12
GM
838 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
839 O_RDONLY already includes it).
840
9e059e3f
GM
841 Stop ns builds setting the EMACSLOADPATH environment variable.
842 * nsterm.m (ns_load_path): Rename from ns_init_paths.
843 Now it does not set EMACSLOADPATH, just returns the load-path string.
844 * nsterm.h: Update accordingly.
845 * lread.c [HAVE_NS]: Include nsterm.h.
846 (init_lread) [HAVE_NS]: Use ns_load_path.
847 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
848
7c4e8ec0
GM
8492012-07-09 Glenn Morris <rgm@gnu.org>
850
d4f600ff
GM
851 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
852 since the included bsd-common.h does so.
853
cbb31951
GM
854 Stop ns builds setting the EMACSPATH environment variable.
855 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
856 (ns_init_paths): Do not set EMACSPATH.
857 * nsterm.h (ns_exec_path): Add it.
858 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
859 Use ns_exec_path.
860
7c4e8ec0
GM
861 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
862
26bccfae
PE
8632012-07-09 Paul Eggert <eggert@cs.ucla.edu>
864
a0bee46f
PE
865 * process.c (wait_reading_process_output): 'waitchannels' was unset
866 when read_kbd || !NILP (wait_for_cell); fix this.
867
5994c183
PE
868 Add GCC-style 'const' attribute to functions that can use it.
869 * character.h (char_resolve_modifier_mask):
870 * keyboard.h (make_ctrl_char):
871 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
872 (init_character_once, next_almost_prime, init_fns, init_image)
873 (flush_pending_output, init_sound):
874 * mem-limits.h (start_of_data):
875 * menu.h (finish_menu_items):
876 Add ATTRIBUTE_CONST.
877 * emacs.c (DEFINE_DUMMY_FUNCTION):
878 Declare the dummy function with ATTRIBUTE_CONST.
879 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
880 Add decls with ATTRIBUTE_CONST.
881
26bccfae
PE
882 Minor improvements to make_formatted_string.
883 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
884 where int is good enough, as vsprintf returns an int.
885 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
886
a8290ec3
DA
8872012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
888
889 Use make_formatted_string to avoid double length calculation.
890 * lisp.h (make_formatted_string): New prototype.
891 * alloc.c (make_formatted_string): New function.
892 * buffer.c (Fgenerate_new_buffer_name): Use it.
893 * dbus.c (syms_of_dbusbind): Likewise.
894 * editfns.c (Fcurrent_time_zone): Likewise.
895 * filelock.c (get_boot_time): Likewise.
896 * frame.c (make_terminal_frame, set_term_frame_name)
897 (x_report_frame_params): Likewise.
898 * image.c (gs_load): Likewise.
899 * minibuf.c (get_minibuffer): Likewise.
900 * msdos.c (dos_set_window_size): Likewise.
901 * process.c (make_process): Likewise.
902 * xdisp.c (ensure_echo_area_buffers): Likewise.
903 * xsettings.c (apply_xft_settings): Likewise.
904
d01ba2f1
GM
9052012-07-09 Glenn Morris <rgm@gnu.org>
906
907 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
908 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
909 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
910 * nsterm.h (ns_etc_directory): Add it.
911 * callproc.c [HAVE_NS]: Include nsterm.h.
912 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
913
f1f924b6
DA
9142012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
915
916 Move marker debugging code under MARKER_DEBUG.
917 * marker.c (MARKER_DEBUG): Move marker debugging code under
918 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
919 for bootstrap with --enable-checking (~3x slowdown reported
920 by Juanma Barranquero <lekktu@gmail.com>).
921 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
922
ab531b66
PE
9232012-07-08 Paul Eggert <eggert@cs.ucla.edu>
924
925 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
926 See <http://bugs.gnu.org/11825#29>.
927
c4b3bc8a
EZ
9282012-07-08 Eli Zaretskii <eliz@gnu.org>
929
930 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
931 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
932 (display_line): Add commentary about displaying truncation glyphs
933 on GUI frames.
934 (produce_special_glyphs): Move here from term.c.
935
936 * term.c (produce_special_glyphs): Move to xdisp.c.
937
938 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
939 section.
c4b3bc8a 940
b676b881
AS
9412012-07-07 Andreas Schwab <schwab@linux-m68k.org>
942
f17c5273
AS
943 * xdisp.c (display_line): Avoid warning about implicit declaration
944 of FRAME_FONT.
945
298819b9
AS
946 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
947
b676b881
AS
948 * lisp.h: Remove empty conditional.
949
6045c4fd
PE
9502012-07-07 Paul Eggert <eggert@cs.ucla.edu>
951
b3350bf9
PE
952 * lread.c (load_path_check): Now static.
953
6045c4fd
PE
954 Fix some minor --with-ns problems found by static checking.
955 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
956 (x_set_font) [!HAVE_X_WINDOWS]:
957 * image.c (xpm_load_image) [HAVE_NS]:
958 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
959 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
960 Remove unused local.
961 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
962 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
963 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
964 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
965 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
966 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
967 Fix pointer signedness problem.
968 * xfaces.c (FRAME_X_FONT_TABLE):
969 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
970
929e7845
GM
9712012-07-07 Glenn Morris <rgm@gnu.org>
972
973 * lread.c (load_path_check): New function, split from init_lread.
974 (init_lread): Reorganize. Motivation:
975 If EMACSLOADPATH is set, check/warn about that rather than the
976 defaults, which we are not going to use. Hence we can remove
977 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
978 Don't warn if site-lisp directories are missing.
979 If not installed, start from a blank load-path, since
980 PATH_LOADSEARCH refers to the eventual installation directories.
981
58dd0aa4
EZ
9822012-07-07 Eli Zaretskii <eliz@gnu.org>
983
984 Support truncation and continuation glyphs on GUI frames, when
985 fringes are disabled. (Bug#11832)
986 * xdisp.c (init_iterator): Get dimensions of truncation and
987 continuation glyphs even if on GUI frames. Adjust
988 it->last_visible_x on GUI frames when the left or right fringes,
989 or both, are absent.
990 (start_display, move_it_in_display_line_to): Handle the case of a
991 GUI frame without a fringe to display continuation or truncation
992 glyphs.
993 (insert_left_trunc_glyphs): Support GUI frames: make sure
994 truncation glyphs overwrite enough glyphs from the current line to
995 have sufficient space in pixels.
996 (display_line): Support truncation and continuation glyphs on GUI
997 frames. If some spare pixels are left on the line after inserting
998 the truncation glyphs, fill that space with a stretch glyph of a
999 suitably computed width.
1000
1001 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1002 produce_glyphs, to support GUI sessions.
1003
31571fd7
PE
10042012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1005
5a16b9bc
PE
1006 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1007
f3047c75
PE
1008 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1009
31571fd7
PE
1010 Do not require float-time's arg to fit in time_t (Bug#11825).
1011 This works better on hosts where time_t is unsigned, and where
1012 float-time is applied to the (negative) difference between two times.
1013 * editfns.c (decode_time_components): Last arg is now double *,
1014 not int *, and means to store all the result as a double, without
1015 worrying about whether the seconds part fits in time_t.
1016 All callers changed.
1017 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1018 All callers changed.
1019 (Ffloat_time): Do not fail merely because the specified time falls
1020 outside of time_t range.
1021
4516fbef
GM
10222012-07-07 Glenn Morris <rgm@gnu.org>
1023
1024 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1025 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1026 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1027
07adc2c6
JB
10282012-07-07 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1031 Update dependencies.
1032
1033 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1034
fd573f31
PE
10352012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1036
fee5959d
PE
1037 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1038 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1039 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1040 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1041 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1042 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1043
fd573f31
PE
1044 * xfont.c (compare_font_names): Redo to omit the need for casts.
1045
ddadbc0e
AS
10462012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1047
fca8d6b6
AS
1048 * xfns.c (Fx_change_window_property): Doc fix.
1049 * w32fns.c (Fx_change_window_property): Doc fix.
1050
ddadbc0e
AS
1051 * w32fns.c (Fx_window_property): Accept the same arguments as the
1052 X Windows version. Doc fix.
1053 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1054
ed9265fc 10552012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1056 Eli Zaretskii <eliz@gnu.org>
1057
1058 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1059 Windows-specific code from nt/config.nt moved here.
1060 Obsolete settings removed.
1061
216ee680
PE
10622012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * process.c: Avoid unnecessary calls to gettime.
1065 (wait_reading_process_output): Don't get the time of day
1066 when gobbling data immediately and not waiting, as there's no need
1067 for it in that case. This removes a FIXME.
1068
bdd091e4
JD
10692012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1070
1071 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1072 is defined (Bug#11768).
1073
9d44f8ce
DA
10742012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1075
1076 Fix marker debugging code.
1077 * marker.c (byte_char_debug_check): Do not perform the check
1078 if buffer is not multibyte.
090bd7cb
JB
1079 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1080 Call byte_char_debug_check with correct arguments.
9d44f8ce 1081
90fc4786
DA
10822012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1085 * marker.c (byte_char_debug_check, count_markers):
1086 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1087 (byte_debug_flag): Remove.
1088 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1089 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1090
7b7ae965
DA
10912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1092
4e57b342
DA
1093 Avoid code repetition in marker-related functions.
1094 * marker.c (attach_marker): New function.
1095 (Fset_marker, set_marker_restricted, set_marker_both)
1096 (set_marker_restricted_both): Use it.
1097 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1098 Consistently rename charno to charpos.
1099 (marker_position): Add eassert.
1100 (marker_byte_position): Convert to eassert.
1101
11022012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1103
1104 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1105 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1106 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1107
657924ff
DA
11082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1109
1110 Introduce fast path for the widely used marker operation.
1111 * alloc.c (build_marker): New function.
1112 * lisp.h (build_marker): New prototype.
1113 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1114 * composite.c (autocmp_chars): Likewise.
1115 * editfns.c (buildmark): Remove.
1116 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1117 (save_restriction_save): Use build_marker.
1118 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1119 * window.c (save_window_save): Likewise.
1120
041a49a6
DA
11212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 Do not use Fdelete_overlay in delete_all_overlays
1124 to avoid redundant calls to unchain_overlay.
1125 * buffer.c (drop_overlay): New function.
1126 (delete_all_overlays, Fdelete_overlay): Use it.
1127 * minibuf.c (get_minibuffer): Fix comment.
1128
7dca65a4
PE
11292012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 Port to OpenBSD 5.1 amd64.
1132 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1133 This is needed for OpenBSD, and should be harmless on all BSD systems.
1134 Also, include <sys/sysctl.h>, as it should be available on all
1135 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1136 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1137 use p_pid member, not kp_proc.pid.
1138
8eb876e2
GM
11392012-07-06 Glenn Morris <rgm@gnu.org>
1140
1141 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1142
38182d90
PE
11432012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1144
1145 More xmalloc and related cleanup.
1146 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1147 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1148 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1149 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1150 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1151 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1152 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1153 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1154 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1155 * xterm.c:
1156 Omit needless casts involving void * pointers and allocation.
1157 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1158 as the former is more robust if P's type is changed.
1159 Prefer xzalloc to xmalloc + memset 0.
1160 Simplify malloc-or-realloc to realloc.
1161 Don't worry about xmalloc returning a null pointer.
1162 Prefer xstrdup to xmalloc + strcpy.
1163 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1164 growing it.
1165 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1166 alloca of a constant.
1167
6dd5a677
EZ
11682012-07-05 Eli Zaretskii <eliz@gnu.org>
1169
1170 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1171 hscroll is larger than the line width. Fixes long and futile
1172 looping inside extend_face_to_end_of_line (on a TTY) producing
1173 glyphs that are not needed and thrown away.
1174
6b312f0f
DA
11752012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1176
1177 * marker.c (set_marker_restricted_both): Simplify by using
1178 clip_to_bounds.
1179
f520ef9b
PE
11802012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1183
383b7c95
JD
11842012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1185
1186 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1187 not defined (Bug#11768).
1188 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1189 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1190 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1191 followed by gtk_box_set_homogeneous (Bug#11768).
1192 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1193 (update_theme_scrollbar_width, xg_create_scroll_bar):
1194 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1195 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1196 (is_box_type): New function (Bug#11768).
1197 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1198 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1199 with default display (Bug#11768).
1200
d6e7bf45
EZ
12012012-07-05 Eli Zaretskii <eliz@gnu.org>
1202
1203 * xdisp.c (window_hscroll_limited): New function.
1204 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1205 coordinates when window's hscroll is set to insanely large
1206 values. (Bug#11857)
1207
431391ec
JB
12082012-07-05 Juanma Barranquero <lekktu@gmail.com>
1209
1210 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1211 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1212
23f86fce
DA
12132012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1214
1215 Cleanup xmalloc.
1216 * lisp.h (xzalloc): New prototype. Omit needless casts.
1217 * alloc.c (xzalloc): New function. Omit needless casts.
1218 * charset.c: Omit needless casts. Convert all calls to
1219 xmalloc with following memset to xzalloc.
1220 * dispnew.c: Likewise.
1221 * fringe.c: Likewise.
1222 * image.c: Likewise.
1223 * sound.c: Likewise.
1224 * term.c: Likewise.
1225 * w32fns.c: Likewise.
1226 * w32font.c: Likewise.
1227 * w32term.c: Likewise.
1228 * xfaces.c: Likewise.
1229 * xfns.c: Likewise.
1230 * xterm.c: Likewise.
1231 * atimer.c: Omit needless casts.
1232 * buffer.c: Likewise.
1233 * callproc.c: Likewise.
1234 * ccl.c: Likewise.
1235 * coding.c: Likewise.
1236 * composite.c: Likewise.
1237 * doc.c: Likewise.
1238 * doprnt.c: Likewise.
1239 * editfns.c: Likewise.
1240 * emacs.c: Likewise.
1241 * eval.c: Likewise.
1242 * filelock.c: Likewise.
1243 * fns.c: Likewise.
1244 * gtkutil.c: Likewise.
1245 * keyboard.c: Likewise.
1246 * lisp.h: Likewise.
1247 * lread.c: Likewise.
1248 * minibuf.c: Likewise.
1249 * msdos.c: Likewise.
1250 * print.c: Likewise.
1251 * process.c: Likewise.
1252 * region-cache.c: Likewise.
1253 * search.c: Likewise.
1254 * sysdep.c: Likewise.
1255 * termcap.c: Likewise.
1256 * terminal.c: Likewise.
1257 * tparam.c: Likewise.
1258 * w16select.c: Likewise.
1259 * w32.c: Likewise.
1260 * w32reg.c: Likewise.
1261 * w32select.c: Likewise.
1262 * w32uniscribe.c: Likewise.
1263 * widget.c: Likewise.
1264 * xdisp.c: Likewise.
1265 * xmenu.c: Likewise.
1266 * xrdb.c: Likewise.
1267 * xselect.c: Likewise.
1268
0497dc44
PE
12692012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1270
1271 * fileio.c (time_error_value): Check the right error number.
1272 Problem reported by Troels Nielsen in
1273 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1274
356e7178
PE
12752012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1276
4e71fd89
PE
1277 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1278 This should be fixed in a better way; see Eli Zaretskii in
1279 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1280 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1281
f0941253
PE
1282 * fileio.c (time_error_value): Rename from special_mtime.
1283 The old name's problems were noted by Eli Zaretskii in
1284 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1285
065c9eb4
PE
1286 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1287 This variable's comment says Emacs needs at least one GDB-visible
1288 symbol of type enum pvec_type, to work around GDB problems.
1289 The symbol's value doesn't matter.
1290
356e7178
PE
1291 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1292 that causes compilation to fail on pre-C99 compilers.
1293
ed9265fc 12942012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1295
1296 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1297 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1298
3884d954
DA
12992012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1300
d209e2fb 1301 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1302 headers for buffer_defaults and buffer_local_symbols.
1303 Reported by Juanma Barranquero <lekktu@gmail.com>.
1304
ee28be33
SM
13052012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1306
1307 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1308 * lisp.h (enum pvec_type): Use fewer bits.
1309 (PSEUDOVECTOR_SIZE_BITS): New constant.
1310 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1311 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1312 change in pvec_type.
1313 (PSEUDOVECTOR_TYPEP): New macro.
1314 (TYPED_PSEUDOVECTORP): Use it.
1315 * fns.c (internal_equal): Adapt code to extract pvectype.
1316 * emacs.c (gdb_pvec_type): Update type.
1317 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1318 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1319 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1320 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1321 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1322 abusing vector->header.next.nbytes.
1323 (live_vector_p): Use PVEC_TYPE.
1324 (mark_object): Adapt code to extract pvectype. Use switch.
1325
c7f2cd7f
PE
13262012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1327
1328 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1329 Tighten new eassert a bit.
1330
8ce70ed2
DA
13312012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1332
1333 Fix compilation with --enable-gcc-warnings and -O1
1334 optimization level.
1335 * doprnt.c (doprnt): Change type of tem to int, initialize
1336 to avoid compiler warning. Add eassert.
1337 * search.c (simple_search): Initialize match_byte to avoid
1338 compiler warning. Add eassert.
1339
dea7f1e5
PE
13402012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1341
24a212eb
PE
1342 Avoid weird behavior with large horizontal scrolls.
1343 Without this change, for example, large hscroll values would
1344 mess up Emacs's display on Fedora 15 x86, presumably due to
1345 overflows in int calculations in the display code.
1346 Also, if buffers had long lines, Emacs would freeze.
1347 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1348 (set_window_hscroll): New function, containing the old guts of
1349 Fset_window_hscroll. Return the clipped value.
1350 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1351 This avoids the need to check against PTRDIFF_MAX.
1352
dea7f1e5
PE
1353 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1354
76046526
DA
13552012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1356
1357 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1358
39adff0d
PE
13592012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1360
63807d47
PE
1361 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1362 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1363 since GCC 4.4.6 issues a bogus warning for them.
1364
39adff0d
PE
1365 Fix bugs in file timestamp newness comparisons.
1366 * fileio.c (Ffile_newer_than_file_p):
1367 * lread.c (Fload): Use full timestamp resolution of files,
1368 not just the 1-second resolution, so that files that are only
1369 slightly newer still count as newer.
1370 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1371 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1372
dbeed9a6
PE
13732012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 * fileio.c: Improve handling of file time marker. (Bug#11852)
1376 (special_mtime): New function.
1377 (Finsert_file_contents, Fverify_visited_file_modtime):
1378 Use it to set special mtime values consistently.
1379
636334d6
AS
13802012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1381
1382 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1383 marker for non-existing file. (Bug#11852)
1384
e2017fe2
GM
13852012-07-03 Glenn Morris <rgm@gnu.org>
1386
1387 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1388 and did not make it into globals.h).
1389
404dbd37
TT
13902012-07-03 Tom Tromey <tromey@redhat.com>
1391
1392 * window.c (Fset_window_margins, Fset_window_fringes)
1393 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1394 * textprop.c (Fprevious_property_change): No longer static.
1395 * syntax.c (Fsyntax_table_p): No longer static.
1396 * process.c (Fget_process, Fprocess_datagram_address): No longer
1397 static.
1398 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1399 * keyboard.c (Fcommand_execute): No longer static.
1400 Remove EXFUN.
1401 * insdel.c (Fcombine_after_change_execute): No longer static.
1402 * image.c (Finit_image_library): No longer static.
1403 * fileio.c (Fmake_symbolic_link): No longer static.
1404 * eval.c (Ffetch_bytecode): No longer static.
1405 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1406 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1407 No longer static.
404dbd37
TT
1408 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1409 static.
1410 * dired.c (Ffile_attributes): No longer static.
1411 * composite.c (Fcomposition_get_gstring): No longer static.
1412 * callproc.c (Fgetenv_internal): No longer static.
1413
1414 * ccl.h: Remove EXFUNs.
1415 * buffer.h: Remove EXFUNs.
1416 * dispextern.h: Remove EXFUNs.
1417 * intervals.h: Remove EXFUNs.
1418 * fontset.h: Remove EXFUN.
1419 * font.h: Remove EXFUNs.
1420 * dosfns.c (system_process_attributes): Remove EXFUN.
1421 * keymap.h: Remove EXFUNs.
1422 * lisp.h: Remove EXFUNs.
1423 * w32term.h: Remove EXFUNs.
1424 * window.h: Remove EXFUNs.
1425 * xsettings.h: Remove EXFUN.
1426 * xterm.h: Remove EXFUN.
1427
8e4fd1e1
GM
14282012-07-03 Glenn Morris <rgm@gnu.org>
1429
1430 * lisp.h (Frandom): Make it visible to C.
1431 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1432 buffer for invisible buffers. (Bug#1229)
1433
ca95b3eb
DA
14342012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1437 values which aren't power of 2.
1438 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1439 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1440 accordingly.
1441
7555c33f
SM
14422012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1443
1444 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1445
1446 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1447
d12e8f5a
DA
14482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1449
1450 * alloc.c (allocate_vector_block): Remove redundant
1451 calls to mallopt if DOUG_LEA_MALLOC is defined.
1452 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1453 avoid calls to mallopt if zero_vector is returned.
1454
296094c3
DA
14552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1456
1457 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1458 is enabled, avoid dereferencing NULL current_sblock if
1459 running undumped.
1460
36429c89
DA
14612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1462
1463 Cleanup basic buffer management.
1464 * buffer.h (struct buffer): Change layout to use generic vector
1465 marking code. Fix some comments. Change type of 'clip_changed'
1466 to bitfield. Remove unused #ifndef old.
1467 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1468 (GET_OVERLAYS_AT): Fix indentation.
1469 (for_each_per_buffer_object_at): New macro.
1470 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1471 (Fbuffer_local_variables): Use it.
1472 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1473 * alloc.c (allocate_buffer): Adjust to match new layout of
1474 struct buffer. Fix comment.
1475 (mark_overlay): New function.
1476 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1477 Lisp area of struct buffer.
1478 (mark_object): Use it. Adjust marking of misc objects
1479 and related comments.
1480
3b3e4cac
PE
14812012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1484 wrapper that is not needed because the wrapped code is a no-op (zero
1485 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1486 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1487
cf5c0175
DA
14882012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1489
1490 * alloc.c (mark_buffer): Simplify. Remove prototype.
1491 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1492 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1493 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1494 redundant calls to mark_vectorlike for bool vectors.
1495
ca26824c
GM
14962012-06-30 Glenn Morris <rgm@gnu.org>
1497
2e4c5312
GM
1498 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1499
ca26824c
GM
1500 * epaths.in (PATH_SITELOADSEARCH): New.
1501 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1502 This is rather than relying on --enable-locallisppath elements
1503 having "site-lisp" in their names. (Bug#10208#25, 11658)
1504
0d23c240
EZ
15052012-06-30 Eli Zaretskii <eliz@gnu.org>
1506
c9240d7a
EZ
1507 * w32proc.c (sys_select): Accept and ignore one more argument.
1508
1509 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1510
0d23c240 1511 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1512 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1513
1514 * sysdep.c: Don't include dos.h and dosfns.h.
1515
1516 * process.c (sys_select):
1517 * msdos.c (sys_select): Accept one more argument and ignore it.
1518
1519 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1520 adapt data types and code to that.
1521
1522 * dosfns.c:
1523 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1524 which clashes with the gnulib function of the same name.
1525
af5a5a98
AS
15262012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1527
c5e4379c
AS
1528 * font.c (font_style_to_value, font_style_symbolic)
1529 (font_prop_validate_style): Add type checks for values in
1530 font_style_table.
1531
af5a5a98
AS
1532 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1533 argument.
1534 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1535 uses.
1536
8d38f461
EZ
15372012-06-29 Eli Zaretskii <eliz@gnu.org>
1538
2e5a6631
EZ
1539 * xdisp.c (try_window_id): Undo last change.
1540
8d38f461
EZ
1541 * w32.c (getwd): Adjust commentary about startup_dir.
1542 (init_environment): Always call sys_access, even in non-MSVC
1543 builds. Don't chdir to the directory of the Emacs executable.
1544 This undoes code from 1997 which was justified by the need to
1545 "avoid conflicts when removing and renaming directories". But its
1546 downside was that every relative file name was being interpreted
1547 relative to the directory of the Emacs executable, which can never
1548 be TRT. In particular, it broke sys_access when called with
1549 relative file names.
1550 (sys_access): Map GetLastError to errno.
1551
2af3565e
DA
15522012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1553
1554 * window.h (struct window): Change type of 'fringes_outside_margins'
1555 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1556 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1557 Adjust comment.
1558 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1559 to ptrdiff_t.
1560
c8d3a25c 15612012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1562
c8d3a25c
GM
1563 * gnutls.c (emacs_gnutls_handshake):
1564 Add QUIT to make the loop interruptible.
57570cd3 1565
c8d3a25c 15662012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1567
c8d3a25c
GM
1568 * charset.c (init_charset): Make lack of etc/charsets fatal.
1569
3e984ee8
DA
15702012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1571
1572 * editfns.c (region_limit): Fix type mismatch.
1573
ef884f23
DA
15742012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1575
1576 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1577 undefined. Convert from xassert to eassert.
1578 * nsmenu.m: Convert from xassert to eassert.
1579 * nsterm.m: Likewise.
1580
7d7e0027
SM
15812012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1582
1583 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1584
aa754e6a
PE
15852012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 Avoid integer overflow on scroll-left and scroll-right.
1588 * window.c (HSCROLL_MAX): New macro.
1589 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1590 overflow when requested scroll falls outside ptrdiff_t range.
1591
80b00b08
DA
15922012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1593
1594 * window.h (struct window): Change type of 'hscroll',
1595 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1596 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1597 Adjust users accordingly.
1598 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1599 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1600 from EMACS_INT to ptrdiff_t.
1601 (make_window): Omit redundant initialization.
1602
62b2bcf6
JB
16032012-06-28 Juanma Barranquero <lekktu@gmail.com>
1604
1605 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1606
45942c7d
DA
16072012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1608
1609 * window.h (struct window): Change type of 'use_time' and
1610 'sequence_number' from Lisp_Object to int.
1611 * frame.c (make_frame): Adjust users accordingly.
1612 * print.c (print_object): Likewise.
1613 * window.c (select_window, Fwindow_use_time, make_parent_window)
1614 (make_window): Likewise.
1615
e509cfa6
DA
16162012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1617
1618 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1619 enabled with --enable-checking=[all,glyphs] configure option.
1620 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1621 adjust comments accordingly.
1622 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1623 undefined, adjust comments accordingly.
1624 * image.c: Likewise.
1625 * scroll.c: Likewise.
1626 * w32fns.c: Likewise.
1627 * w32term.c: Likewise.
1628 * xdisp.c: Likewise.
1629 * xfaces.c: Likewise.
1630 * xfns.c: Likewise.
1631 * xterm.c: Likewise.
1632
a54e2c05
DA
16332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1634
1635 Generalize run-time debugging checks.
1636 * dispextern.h (XASSERTS): Remove.
1637 * fontset.c (xassert): Remove.
1638 Convert from xassert to eassert.
1639 * alloc.c: Convert from xassert to eassert.
1640 * bidi.c: Likewise.
1641 * dispnew.c: Likewise.
1642 * fns.c: Likewise.
1643 * fringe.c: Likewise.
1644 * ftfont.c: Likewise.
1645 * gtkutil.c: Likewise.
1646 * image.c: Likewise.
1647 * keyboard.c: Likewise.
1648 * menu.c: Likewise.
1649 * process.c: Likewise.
1650 * scroll.c: Likewise.
1651 * sound.c: Likewise.
1652 * term.c: Likewise.
1653 * w32console.c: Likewise.
1654 * w32fns.c: Likewise.
1655 * w32term.c: Likewise.
1656 * window.c: Likewise.
1657 * xdisp.c: Likewise.
1658 * xfaces.c: Likewise.
1659 * xfns.c: Likewise.
1660 * xselect.c: Likewise.
1661 * xterm.c: Likewise.
1662
1ec4b7b2
SM
16632012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1664
1665 * fns.c (maybe_resize_hash_table): Output message when growing the
1666 purify-hashtable.
1667
2014308a
DA
16682012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1669
1670 * alloc.c (allocate_string_data): Remove dead code.
1671 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1672 avoid GCC warning about unused macro.
1673
246155eb
DA
16742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1675
1676 * alloc.c (allocate_string): Omit intervals initialization.
1677 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1678 as in make_pure_string and make_pure_c_string.
1679
43184b7b
DA
16802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1681
d209e2fb 1682 * alloc.c (allocate_string): Fix last change.
43184b7b 1683
3fe6dd74
DA
16842012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1685
d209e2fb 1686 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1687 to memset, add explicit initialization where appropriate.
1688
1ba6038a
GM
16892012-06-27 Glenn Morris <rgm@gnu.org>
1690
1691 * lisp.mk (lisp): Remove paths.elc.
1692
c89926a5
CY
16932012-06-27 Chong Yidong <cyd@gnu.org>
1694
1695 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1696
ed6b3510
JW
16972012-06-26 John Wiegley <johnw@newartisans.com>
1698
1ec4b7b2 1699 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1700 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1701
ed6b3510
JW
1702 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1703 when building with Clang.
1704
8edd4a2b
SM
17052012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1706
1707 * eval.c (Fapply): Allow calling it with a single argument.
1708
f6f62d1b
EZ
17092012-06-26 Eli Zaretskii <eliz@gnu.org>
1710
1711 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1712 _stricmp and _strnicmp.
1713 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1714
62efea5e
DA
17152012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1716
1717 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1718 allocated window.
1719 (allocate_process): Likewise for new process.
8edd4a2b 1720 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1721 (allocate_frame): Likewise.
1722 * frame.c (make_frame): Omit redundant initialization.
1723 * window.c (make_parent_window): Use memset.
1724 (make_window): Omit redundant initialization.
1725 * process.c (make_process): Omit redundant initialization.
1726 * terminal.c (create_terminal): Likewise.
1727
42997f4d
DA
17282012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1729
1730 * term.c (delete_tty): Remove redundant call to memset.
1731
1130ecfc
DA
17322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1733
1734 * alloc.c: Remove build_string.
1735 * lisp.h: Define build_string as static inline. This provides
1736 a better opportunity to optimize away calls to strlen when the
1737 function is called with compile-time constant argument.
1738 * image.c (imagemagick_error): Convert to build_string.
1739 * w32proc.c (sys_spawnve): Likewise.
1740 * xterm.c (x_term_init): Likewise.
1741
cf38a720
PE
17422012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1743
99027bdd
PE
1744 Use sprintf return value instead of invoking strlen on result.
1745 In the old days this wasn't portable, since some sprintf
1746 implementations returned char *. But they died out years ago and
1747 Emacs already assumes sprintf returns int.
1748 Similarly for float_to_string.
1749 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1750 * ccl.c (ccl_driver):
1751 * character.c (string_escape_byte8):
1752 * data.c (Fnumber_to_string):
1753 * doprnt.c (doprnt):
1754 * print.c (print_object):
1755 * xdisp.c (message_dolog):
1756 * xfns.c (syms_of_xfns):
1757 Use sprintf or float_to_string result to avoid need to call strlen.
1758 * data.c (Fnumber_to_string):
1759 Use make_unibyte_string, since the string must be ASCII.
1760 * lisp.h, print.c (float_to_string): Now returns int length.
1761 * term.c (produce_glyphless_glyph):
1762 Use sprintf result rather than recomputing it.
1763
cf38a720
PE
1764 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1765 * Makefile.in (ALL_CFLAGS):
1766 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1767 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1768
3511c784
DA
17692012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1770
0a08eb21 1771 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1772 strcasecmp if available.
1773 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1774
fb7da12e
AS
17752012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1776
1777 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1778 Avoid comma operator.
1779 * menu.c (push_submenu_start, push_submenu_end)
1780 (push_left_right_boundary, push_menu_pane): Likewise.
1781 * msdos.c (dos_rawgetc): Likewise.
1782
afa2ffd8
DA
17832012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1784
1785 * xfns.c (xic_create_fontsetname): Remove redundant calls
1786 to memset.
1787
b3b4476b
PE
17882012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1789
4495ff38
PE
1790 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1791 sprintf already null-terminates its output.
1792
b3b4476b
PE
1793 * xfns.c (x_window): Remove redundant cast.
1794
b00876c9
DA
17952012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1796
1797 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1798 `const char *' to `char *' to avoid compiler warning.
1799
d188e26b
PE
18002012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1801
885d1d74
PE
1802 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1803 instead of truncating it to 63 (admittedly a generous limit).
1804
d188e26b
PE
1805 * process.c: Fix spelling and caps in comments.
1806
e2f560b1
DN
18072012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1808
e86db54b 1809 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1810 * sysdep.c (setpgrp): Remove definition, not used in this file.
1811
7583a3a1
JB
18122012-06-24 Juanma Barranquero <lekktu@gmail.com>
1813
1814 * makefile.w32-in: Update dependencies.
1815
696056c2
EZ
18162012-06-24 Eli Zaretskii <eliz@gnu.org>
1817
1818 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1819 (SYSTIME_H): Add nt/inc/sys/time.h.
1820
1821 * systime.h [WINDOWSNT]: Include sys/time.h.
1822
1823 * s/ms-w32.h (struct timespec): Definition moved from
1824 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1825
845ca893
PE
18262012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1827
1828 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1829 * buffer.h (buffer_slot_type_mismatch):
1830 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1831 * eval.c (unwind_to_catch):
1832 * image.c (my_png_error, my_error_exit):
1833 * keyboard.c (quit_throw_to_read_char, user_error)
1834 (Fexit_recursive_edit, Fabort_recursive_edit):
1835 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1836 (wrong_type_argument, buffer_overflow, __executable_start)
1837 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1838 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1839 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1840 (fatal):
1841 (child_setup) [!DOS_NT]:
1842 * lread.c (end_of_file_error, invalid_syntax):
1843 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1844 * puresize.h (pure_write_error):
1845 * search.c (matcher_overflow):
1846 * sound.c (sound_perror, alsa_sound_perror):
1847 * sysdep.c, syssignal.h (croak):
1848 * term.c (maybe_fatal, vfatal):
1849 * textprop.c (text_read_only):
1850 * undo.c (user_error):
1851 * unexmacosx.c (unexec_error):
1852 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1853 Use _Noreturn rather than NO_RETURN.
1854 No need for separate decl merely because of _Noreturn.
1855 * sound.c (sound_warning, parse_sound):
1856 Remove unnecessary forward decls.
1857
f1dd8073
PE
18582012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1861 * lisp.h (WAIT_READING_MAX): New macro.
1862 * dispnew.c (Fsleep_for, sit_for):
1863 * keyboard.c (kbd_buffer_get_event):
1864 * process.c (Faccept_process_output):
1865 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1866 This improves on the previous patch, which introduced a bug
1867 when time_t is unsigned and as wide as intmax_t.
1868 See <http://bugs.gnu.org/9000#51>.
1869
b82c1755
EZ
18702012-06-23 Eli Zaretskii <eliz@gnu.org>
1871
1872 * dispnew.c (sit_for, Fsleep_for):
1873 * keyboard.c (kbd_buffer_get_event):
1874 * process.c (Faccept_process_output): Avoid compiler warnings when
1875 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1876
ca300656
JB
18772012-06-23 Juanma Barranquero <lekktu@gmail.com>
1878
049ec95b
JB
1879 * makefile.w32-in: Update dependencies.
1880
ca300656
JB
1881 * w32.c (ltime): Add return type and declare static.
1882 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1883
db7b8d06
PE
18842012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1885
1886 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1887 Privately reported by Herbert J. Skuhra.
1888 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1889 All uses changed.
1890 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1891 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1892
0bd8297f
EZ
18932012-06-23 Eli Zaretskii <eliz@gnu.org>
1894
96512555
EZ
1895 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1896 last argument of make_unibyte_string.
1897
0bd8297f
EZ
1898 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1899 language ID in the event parameters.
1900
1901 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1902 event.code, not the obscure "character set ID".
1903
63def6b6
CY
19042012-06-23 Chong Yidong <cyd@gnu.org>
1905
1906 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1907
e8a02204
EZ
19082012-06-23 Eli Zaretskii <eliz@gnu.org>
1909
388cdec0
EZ
1910 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1911 * w32.c (fdutimens): New function.
1912
1913 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1914
1915 * s/ms-w32.h (pselect): Redirect to sys_select.
1916
1917 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1918
e8a02204
EZ
1919 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1920 in the logic of incrementing and decrementing the value of
1921 use_relocatable_buffers.
1922
d054f3fb
PE
19232012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1926 Privately reported by Herbert J. Skuhra.
1927 [__FreeBSD__]: Remove "*/" typo after "#include".
1928 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1929 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1930 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1931 Don't assume EMACS_TIME and struct timeval are the same type.
1932
d35af63c
PE
19332012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1934
1935 Support higher-resolution time stamps (Bug#9000).
1936 The time stamps are only nanosecond-resolution at the C level,
1937 since that's the best that any real-world system supports now.
1938 But they are picosecond-resolution at the Lisp level, as that's
1939 easy, and leaves room for future OS improvements.
1940
1941 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1942 (LIBES): Use it.
1943
1944 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1945 Don't get current time unless it's needed.
1946
1947 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1948 now provides it if it's absent.
1949 (start_atimer): Port to higher-res time stamps.
1950 Check for time stamp overflow. Don't get current time more
1951 often than is needed.
1952
1953 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1954 Include systime.h, not time.h.
1955 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1956
1957 * dired.c: Include stat-time.h.
1958 (Ffile-attributes): File times now have higher resolution.
1959
1960 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1961 (struct image): Timestamp now has higher resolution.
1962
1963 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1964 has at least microseconds now. All uses removed.
1965 (update_frame, update_single_window, update_window, update_frame_1)
1966 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1967
1968 * editfns.c (time_overflow): Now extern.
1969 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1970 (float-time, Fformat_time_string, Fcurrent_time_string)
1971 (Fcurrent_time_zone): Accept and generate higher-resolution
1972 time stamps.
1973 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1974 (decode_time_components, lisp_seconds_argument): New functions.
1975 (make_time): Now static.
1976 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1977 Report an error if the time is invalid, rather than having the caller
1978 do that.
1979
1980 * fileio.c: Include <stat-time.h>
1981 (Fcopy_file): Copy higher-resolution time stamps.
1982 Prefer to set the time stamp via a file descriptor if that works.
1983 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1984 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1985 (Fvisited_file_modtime, Fset_visited_file_modtime):
1986 Support higher-resolution time stamps.
1987
1988 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1989
1990 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1991
1992 * image.c (prepare_image_for_display, clear_image_cache)
1993 (lookup_image): Port to higer-resolution time stamps.
1994
1995 * keyboard.c (start_polling, bind_polling_period):
1996 Check for time stamp overflow.
1997 (read_char, kbd_buffer_get_event, timer_start_idle)
1998 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1999 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2000 Port to higher-resolution time stamps. Do not assume time_t is signed.
2001 (decode_timer): New function. Timers are now vectors of length 9,
2002 not 8, to accommodate the picosecond component.
2003 (timer_check_2): Use it.
2004
2005 * nsterm.m (select_timeout, timeval_subtract): Remove.
2006 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2007 as they're a bit more accurate and handle overflow better.
2008 (ns_select): Change prototype to be compatible with pselect.
2009 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2010 * nsterm.h (ns_select): Adjust prototype.
2011
2012 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2013 us-resolution time stamps.
2014 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2015
2016 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2017
2018 * lisp.h (time_overflow): New decl.
2019 (wait_reading_process_output): First arg is now intmax_t, not int,
2020 to accommodate larger waits.
2021
2022 * process.h (struct Lisp_Process.read_output_delay):
2023 Now counts nanoseconds, not microseconds.
2024 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2025 EMACS_HAS_USECS.
2026 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2027 (wait_reading_process_output):
2028 Port to ns-resolution time stamps.
2029 (Faccept_process_output, wait_reading_process_output):
2030 Check for time stamp overflow. Do not assume time_t is signed.
2031 (select_wrapper): Remove; we now use pselect.
2032 (Fprocess_attributes): Now generates ns-resolution time stamps.
2033
2034 * sysdep.c: Include utimens.h. Don't include utime.h
2035 or worry about struct utimbuf; gnulib does that for us now.
2036 (gettimeofday): Remove; gnulib provides a substitute.
2037 (make_timeval): New function.
2038 (set_file_times): Now sets ns-resolution time stamps.
2039 New arg FD; all uses changed.
2040 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2041 (system_process_attributes):
2042 Now returns ns-resolution time stamp. All uses changed.
2043 Check for time stamp overflow.
2044
2045 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2046 provides a substitute now.
2047
2048 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2049 since it guarantees struct timespec.
2050 (EMACS_TIME): Now struct timespec, so that we can support
2051 ns-resolution time stamps.
2052 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2053 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2054 (EMACS_USECS): Remove.
2055 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2056 so multiply the arg by 1000 before storing it.
2057 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2058 New macros.
2059 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2060 Port to ns-resolution time stamps.
2061 (EMACS_TIME_NEG_P): Remove; replaced by....
2062 (EMACS_TIME_SIGN): New macro.
2063 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2064 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2065 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2066 (make_timeval, make_lisp_time, decode_time_components): New decls.
2067 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2068 that it mishandled time_t overflow. You can't compare by subtracting!
2069 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2070 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2071
2072 * term.c: Include <sys/time.h>.
2073 (timeval_to_Time): New function, for proper overflow wraparound.
2074 (term_mouse_position, term_mouse_click): Use it.
2075
2076 * undo.c (record_first_change): Support higher-resolution time stamps
2077 in the undo buffer.
2078 (Fprimitive_undo): Use them when restoring time stamps.
2079
2080 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2081 (w32_get_internal_run_time):
2082 Port to higher-resolution Emacs time stamps.
2083 (ltime): Now accepts single 64-bit integer, as that's more convenient
2084 for callers.
2085
2086 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2087
2088 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2089 for compatibility with pselect. Support ns-resolution time stamps.
2090
2091 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2092
2093 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2094 Check for time stamp overflow, and support ns-resolution time stamps.
2095
2096 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2097 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2098 (timeval_subtract): Remove; no longer needed.
2099 (XTflash, XTring_bell, x_wait_for_event):
2100 Port to ns-resolution time stamps. Don't assume time_t is signed.
2101
b6a92dfe
CY
21022012-06-22 Chong Yidong <cyd@gnu.org>
2103
2104 * xdisp.c (x_consider_frame_title): Revert last change.
2105
d251c37c
EZ
21062012-06-22 Eli Zaretskii <eliz@gnu.org>
2107
2108 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2109 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2110 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2111 staticidx goes up to 1597 out of 1600 = 0x640.)
2112
f10deafb
PE
21132012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2114
2115 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2116 Otherwise, the umask might be mistakenly 0 while handling input signals.
2117
ec6de1e2
SM
21182012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2119
2120 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2121
28be1ada
DA
21222012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2123
2124 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2125 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2126 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2127 access to `contents' member of Lisp_Vector objects with AREF and ASET
2128 where appropriate.
2129
c6bf3022
CY
21302012-06-19 Chong Yidong <cyd@gnu.org>
2131
2132 * frame.c (delete_frame): When selecting a frame on a different
2133 text terminal, do not alter the terminal's top-frame.
2134
2135 * xdisp.c (format_mode_line_unwind_data): Record the target
2136 frame's selected window and its terminal's top-frame.
2137 (unwind_format_mode_line): Restore them.
2138 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2139 Callers changed.
2140 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2141 since tty frames can be explicitly named.
2142 (prepare_menu_bars): Likewise.
2143
2144 * term.c (Ftty_top_frame): New function.
2145
defd4196
PE
21462012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 Port byte-code-meter to modern targets.
2149 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2150 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2151 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2152 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2153 (METER_1, METER_2): Simplify.
2154
1053a871
SM
21552012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2156
2157 * data.c (Fdefalias): Return `symbol' (bug#11686).
2158
b7e8d081
MR
21592012-06-18 Martin Rudalics <rudalics@gmx.at>
2160
2161 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2162 gets killed during executing of this function (Bug#11665).
2163 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2164 (Vkill_buffer_query_functions): In doc-string say that functions
2165 run by this hook should not change the current buffer.
2166
7ea2b339
PE
21672012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2168
2169 Fix recently-introduced process.c problems found by static checking.
2170 * process.c (write_queue_push, write_queue_pop, send_process):
2171 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2172 (write_queue_pop): Fix pointer signedness problem.
2173 (send_process): Remove unused local.
2174
96a313a1
CY
21752012-06-17 Chong Yidong <cyd@gnu.org>
2176
2177 * xdisp.c (redisplay_internal): No need to redisplay terminal
2178 frames that are not on top.
2179
20ca2e94
TN
21802012-06-17 Troels Nielsen <bn.troels@gmail.com>
2181
2182 * process.c (make_process): Initialize write_queue.
2183 (write_queue_push, write_queue_pop): New functions.
2184 (send_process): Use them to maintain correct ordering of process
2185 writes (Bug#10815).
2186
9a900ca9
PE
21872012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2188
310fbfa8
PE
2189 * lisp.h (eassert): Assume C89 or later.
2190 This removes the need for CHECK.
2191 (CHECK): Remove. Its comments about always evaluating its
2192 argument were confusing, as 'eassert' typically does not evaluate
2193 its argument.
2194
27bb1ca4
PE
2195 * coding.c (produce_chars): Use ptrdiff_t, not int.
2196
9a900ca9
PE
2197 * xterm.c (x_draw_underwave): Check for integer overflow.
2198 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2199
41b7f8bc 22002012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2201
2202 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2203 referenced (Bug#11583).
2204
9b0e3eba
AA
22052012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2206
2207 Implement wave-style variant of underlining.
2208 * dispextern.h (face_underline_type): New enum.
2209 (face): Add field for underline type.
2210 * nsterm.m (ns_draw_underwave): New function.
2211 (ns_draw_text_decoration): Use it.
2212 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2213 New functions.
2214 (x_draw_glyph_string): Use them.
2215 * xfaces.c (Qline, Qwave): New Lisp objects.
2216 (check_lface_attrs, merge_face_ref)
1053a871
SM
2217 (Finternal_set_lisp_face_attribute, realize_x_face):
2218 Handle wave-style underline face attributes.
9b0e3eba
AA
2219 * xterm.c (x_draw_underwave): New function.
2220 (x_draw_glyph_string): Use it.
2221
0fb52f11
JB
22222012-06-16 Juanma Barranquero <lekktu@gmail.com>
2223
2224 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2225 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2226 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2227 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2228 ($(BLD)/w32select.$(O)): Update dependencies.
2229
e5560ff7
AS
22302012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2231
2232 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2233 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2234 * character.c (_fetch_multibyte_char_p): Remove.
2235 * alloc.c: Include "character.h" before "buffer.h".
2236 * bidi.c: Likewise.
2237 * buffer.c: Likewise.
2238 * bytecode.c: Likewise.
2239 * callint.c: Likewise.
2240 * callproc.c: Likewise.
2241 * casefiddle.c: Likewise.
2242 * casetab.c: Likewise.
2243 * category.c: Likewise.
2244 * cmds.c: Likewise.
2245 * coding.c: Likewise.
2246 * composite.c: Likewise.
2247 * dired.c: Likewise.
2248 * dispnew.c: Likewise.
2249 * doc.c: Likewise.
2250 * dosfns.c: Likewise.
2251 * editfns.c: Likewise.
2252 * emacs.c: Likewise.
2253 * fileio.c: Likewise.
2254 * filelock.c: Likewise.
2255 * font.c: Likewise.
2256 * fontset.c: Likewise.
2257 * fringe.c: Likewise.
2258 * indent.c: Likewise.
2259 * insdel.c: Likewise.
2260 * intervals.c: Likewise.
2261 * keyboard.c: Likewise.
2262 * keymap.c: Likewise.
2263 * lread.c: Likewise.
2264 * macros.c: Likewise.
2265 * marker.c: Likewise.
2266 * minibuf.c: Likewise.
2267 * nsfns.m: Likewise.
2268 * nsmenu.m: Likewise.
2269 * print.c: Likewise.
2270 * process.c: Likewise.
2271 * regex.c: Likewise.
2272 * region-cache.c: Likewise.
2273 * search.c: Likewise.
2274 * syntax.c: Likewise.
2275 * term.c: Likewise.
2276 * textprop.c: Likewise.
2277 * undo.c: Likewise.
2278 * unexsol.c: Likewise.
2279 * w16select.c: Likewise.
2280 * w32fns.c: Likewise.
2281 * w32menu.c: Likewise.
2282 * window.c: Likewise.
2283 * xdisp.c: Likewise.
2284 * xfns.c: Likewise.
2285 * xmenu.c: Likewise.
2286 * xml.c: Likewise.
2287 * xselect.c: Likewise.
2288
2f07e6af
EZ
22892012-06-16 Eli Zaretskii <eliz@gnu.org>
2290
1053a871
SM
2291 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2292 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2293 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2294 row.
2295 (handle_face_prop): Use chunk-relative overlay string index when
2296 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2297 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2298 the rightmost. (Bug#11720)
2f07e6af 2299
29b83cec
AS
23002012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2301
2302 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2303 (CATEGORY_MEMBER): Enforce 1/0 value.
2304 * category.c (_temp_category_set): Remove.
2305
4c5501e9
EZ
23062012-06-16 Eli Zaretskii <eliz@gnu.org>
2307
2308 * window.c (Fdelete_other_windows_internal)
2309 (Fdelete_window_internal): Don't access frame's mouse highlight
2310 info of the initial frame. (Bug#11677)
2311
2b570124
PE
23122012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2313
e93864f9
PE
2314 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2315 Assume USE_2_TAGS_FOR_INTS.
2316 (xreload): Adjust $tagmask width to match recent lisp.h change.
2317
2b570124
PE
2318 Simplify lisp.h in minor ways that should not affect code.
2319 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2320 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2321 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2322 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2323 (INTTYPEBITS): New macro, for clarity.
2324 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2325 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2326 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2327 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2328 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2329
81755f69
JB
23302012-06-13 Juanma Barranquero <lekktu@gmail.com>
2331
2332 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2333
16192a57
GM
23342012-06-13 Glenn Morris <rgm@gnu.org>
2335
2336 * s/bsd-common.h (BSD4_3):
2337 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2338
646b5f55
AS
23392012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2340
2341 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2342 instead of union.
2343 (XLI, XIL): Define.
1053a871
SM
2344 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2345 Use them.
2346 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2347 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2348 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2349 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2350 * frame.c (delete_frame): Remove outdated comment.
2351 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2352 USE_LISP_UNION_TYPE.
2353 (Fw32_unregister_hot_key): Likewise.
2354 (Fw32_toggle_lock_key): Likewise.
2355 * w32menu.c (add_menu_item): Likewise.
2356 (w32_menu_display_help): Use XIL instead of checking
2357 USE_LISP_UNION_TYPE.
2358 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2359 (init_heap): Likewise.
2360 * w32term.c (w32_read_socket): Update comment.
2361
1d3823c9
GM
23622012-06-13 Glenn Morris <rgm@gnu.org>
2363
c62ff706
GM
2364 * s/usg5-4-common.h, src/s/unixware.h:
2365 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2366
1d3823c9
GM
2367 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2368
bfe3e0a2
PE
23692012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2370
2371 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2372 * alloc.c (make_number) [!defined make_number]:
2373 Remove, as lisp.h always defines this now.
2374 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2375 (roundup_size): Verify that it is a power of 2.
2376 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2377 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2378 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2379 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2380 USE_LSB_TAG now is always defined to be either 0 or 1.
2381 All uses changed.
2382 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2383 code works fine either way, and efficiency is not a concern here,
2384 as the union type is for debugging, not for production.
2385 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2386 Use an inline function on all platforms when using the union type,
2387 since this is simpler and 'static inline' can be used portably
2388 within Emacs now.
2389 (LISP_INITIALLY_ZERO): New macro.
2390 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2391 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2392
45fa9c0f
GM
23932012-06-12 Glenn Morris <rgm@gnu.org>
2394
b4492cba
GM
2395 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2396
2397 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2398
45fa9c0f
GM
2399 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2400 Move BROKEN_SIGIO to configure.
2401
2402 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2403 Move NO_TERMIO to configure.
2404
0e25d334
CY
24052012-06-12 Chong Yidong <cyd@gnu.org>
2406
2407 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2408 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2409 MagickExportImagePixels is undefined.
2410
43682bb6
PE
24112012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2412
2413 * image.c (imagemagick_load_image): Remove unused label.
2414
a9be7d2b
GM
24152012-06-11 Glenn Morris <rgm@gnu.org>
2416
2417 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2418 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2419 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2420 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2421
3017f87f
SM
24222012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2423
2424 * alloc.c (make_byte_code): New function.
2425 (Fmake_byte_code): Use it. Don't purify here.
2426 * lread.c (read1): Use it as well to avoid extra allocation.
2427
1b9b4cf4
CY
24282012-06-11 Chong Yidong <cyd@gnu.org>
2429
2430 * image.c (imagemagick_load_image): Implement transparency.
2431
95988fcf
AS
24322012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2433
2434 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2435 account for preceding backslashes. (Bug#11663)
2436
cd4eb164
CY
24372012-06-09 Chong Yidong <cyd@gnu.org>
2438
2439 * term.c: Support italics in capable terminals (Bug#9652).
2440 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2441 (turn_on_face): Output using TS_enter_italic_mode if available.
2442 Don't handle unused blinking and alt-charset cases.
2443 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2444 and tty_alt_charset_p cases.
2445 (tty_capable_p, init_tty): Support italics.
2446
2447 * termchar.h (struct tty_display_info): Add field for italics.
2448 Remove unused blink field.
2449
2450 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2451 Handle slant.
2452
2453 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2454 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2455 tty_alt_charset_p. Add tty_italic_p.
2456
ff88beb8
MA
24572012-06-09 Michael Albinus <michael.albinus@gmx.de>
2458
2459 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2460 dbus_type_is_basic if available.
2461 (xd_extract_signed, xd_extract_unsigned): Rename from
2462 extract_signed and extract_unsigned, respectively. Adapt callers.
2463
44286096
CY
24642012-06-09 Chong Yidong <cyd@gnu.org>
2465
1682701f
CY
2466 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2467
44286096
CY
2468 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2469 case (Bug#9752).
2470
d86feb17
PE
24712012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2472
2473 * xdisp.c (vmessage): Treat frame message as multibyte.
2474 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2475 would generate the diagnostic "Making \302\247 buffer-local while
2476 let-bound!".
2477
d5c20fe8
EZ
24782012-06-08 Eli Zaretskii <eliz@gnu.org>
2479
2480 * dispnew.c (showing_window_margins_p): Undo last change, which
2481 was done due to an inadvertent commit.
2482 (adjust_frame_glyphs_for_frame_redisplay): Do call
2483 showing_window_margins_p.
2484
513749ee
SM
24852012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2486
2487 * eval.c (Fmake_var_non_special): New primitive.
2488 (syms_of_eval): Defsubr it.
2489 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2490
d4a8f5c1
JB
24912012-06-08 Juanma Barranquero <lekktu@gmail.com>
2492
2493 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2494 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2495
8bbbc977
EZ
24962012-06-08 Eli Zaretskii <eliz@gnu.org>
2497
2498 * alloc.c (allocate_vectorlike): Fix last change.
2499
f3372c87
DA
25002012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2501
2502 Block-based vector allocation of small vectors.
2503 * lisp.h (struct vectorlike_header): New field `nbytes',
2504 adjust comment accordingly.
2505 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2506 to denote vector blocks. Adjust users (live_vector_p,
2507 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2508 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2509 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2510 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2511 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2512 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2513 (roundup_size): New constant.
2514 (struct vector_block): New data type.
2515 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2516 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2517 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2518 (sweep_vectors): New functions.
2519 (allocate_vectorlike): Return `zero_vector' as the only vector of
2520 0 items. Allocate new vector from block if vector size is less than
2521 or equal to VBLOCK_BYTES_MAX.
2522 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2523 (init_alloc_once): Add call to init_vectors.
2524
4f18a4ed
SM
25252012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2526
2527 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2528
86f158bc
PE
25292012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 * doprnt.c (doprnt): Truncate multibyte char correctly.
2532 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2533 would mishandle a string argument "Xc" if X was a multibyte
2534 character of length 2: it would truncate after X's first byte
2535 rather than including all of X.
2536
c5cfcbe0
CY
25372012-06-06 Chong Yidong <cyd@gnu.org>
2538
2539 * buffer.c (word_wrap): Doc fix.
2540
c05cf390
PE
25412012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2542
2543 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2544
0c3461de
GM
25452012-06-03 Glenn Morris <rgm@gnu.org>
2546
2547 * xdisp.c (tool-bar-style): Doc fix.
2548
c71232db
UM
25492012-06-03 Ulrich Müller <ulm@gentoo.org>
2550
2551 * Makefile.in (PAXCTL): Define.
2552 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2553 binary via PaX flags if the paxctl utility is available.
2554 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2555 Restore PaX flags to their default. (Bug#11398)
2556
383f7350
CY
25572012-06-03 Chong Yidong <cyd@gnu.org>
2558
2559 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2560 buffer (Bug#11226).
2561
5f2c76c6
CY
25622012-06-03 Chong Yidong <cyd@gnu.org>
2563
2564 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2565 (note_mode_line_or_margin_highlight): If there is no help echo,
2566 use mode-line-default-help-echo. Handle the case where the mouse
2567 position is past the end of the mode line string.
2568
2569 * buffer.c (buffer_local_value_1): New function, split from
2570 Fbuffer_local_value; can return Qunbound.
2571 (Fbuffer_local_value): Use it.
2572 (Vmode_line_format): Docstring tweaks.
2573
773d47f6
PE
25742012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 * sysdep.c (system_process_attributes): Improve comment.
2577
f2d6a3df
SM
25782012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2579
2580 * keyboard.c: Export real-this-command to Elisp.
2581 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2582 and DEFVAR it. Update all users.
2583
63810350
PE
25842012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2585
7bd5c1f4
PE
2586 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2587
63810350
PE
2588 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2589 Convert pctcpu and pctmem to Lisp float properly.
2590 Let the compiler fold better, as 100.0/0x8000 is exact.
2591
a2821611
AS
25922012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2593
2594 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2595 cons_block.
2596
5fceba1d
PE
25972012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2600
c98ff5dd
DA
26012012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2602
2603 For a 'struct window', replace some Lisp_Object fields to
2604 bitfields where appropriate, remove unused fields.
2605 * window.h (struct window): Remove unused 'last_mark_x' and
2606 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2607 change it's type from Lisp_Object to bitfield.
2608 Change type of 'force_start', 'optional_new_start',
2609 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2610 fields from Lisp_Object to bitfield. Adjust users accordingly.
2611
ca34e0be
PE
26122012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 Pacify gcc -Wdouble-precision when using Xaw.
2615 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2616 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2617 Use 'float' consistently, rather than 'float' in most places
2618 and 'double' in a couple of places.
2619
efc00ab1 26202012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2621
2622 * xdisp.c (handle_stop): Detect whether we have overlay strings
2623 loaded by testing it->current.overlay_string_index to be
2624 non-negative, instead of checking whether n_overlay_strings is
2625 positive. (Bug#11587)
2626
efc00ab1 26272012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2628
2629 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2630
2631 * doc.c (Fsubstitute_command_keys): Doc fix.
2632
efc00ab1 26332012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2634
2635 * search.c (search_buffer): Remove calls to
2636 r_alloc_inhibit_buffer_relocation, as it is now called by
2637 maybe_unify_char, which was the cause of relocation of buffer text
2638 in bug#11519.
2639
efc00ab1 26402012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2641
2642 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2643 for the duration of call to load_charset, to avoid problems with
2644 callers of maybe_unify_char that access buffer text through C
2645 pointers.
2646
2647 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2648 decrement the inhibition flag, instead of just setting or
2649 resetting it.
2650
ba93a187
PE
26512012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2652
2653 Remove obsolete '#define static' cruft.
2654 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2655 This #undef was "temporary" in 2000; it is no longer needed
2656 now that '#define static' has gone away.
2657 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2658 (gray_bitmap_bits): Remove; no longer needed.
2659 All uses replaced with definiens.
2660 * xterm.c: Include "bitmaps/gray.xbm".
2661
9e4bf381
PE
26622012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 Clean up __executable_start, monstartup when --enable-profiling.
2665 The following changes affect the code only when profiling.
2666 * dispnew.c (__executable_start): Rename from safe_bcopy.
2667 Define only on platforms that need it.
2668 * emacs.c: Include <sys/gmon.h> when profiling.
2669 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2670 (__executable_start): Remove decl, since lisp.h does it now.
2671 (safe_bcopy): Remove decl; no longer has that name.
2672 (main): Coalesce #if into single bit of code, for simplicity.
2673 Cast pointers to uintptr_t, since standard libraries want integers
2674 and not pointers.
2675 * lisp.h (__executable_start): New decl.
2676
32d72c2f
GM
26772012-05-31 Glenn Morris <rgm@gnu.org>
2678
2679 * image.c (Fimagemagick_types): Doc fix.
2680
baac5bc7
JM
26812012-05-30 Jim Meyering <meyering@redhat.com>
2682
2683 * callproc.c (Fcall_process_region): Include directory component
2684 in mkstemp error message (Bug#11586).
2685
72cb32cf
PE
26862012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2687
2688 * alloc.c, lisp.h (make_pure_vector): Now static.
2689
61b108cc
SM
26902012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2691
2692 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2693 Move to byte-run.el.
2694 (Fautoload): Do the hash-doc more carefully.
2695 * data.c (Fdefalias): Purify definition, except for keymaps.
2696 (Qdefun): Move from eval.c.
2697 * lisp.h (Qdefun): Remove.
2698 * lread.c (read1): Tiny simplification.
2699
471fe23d
TN
27002012-05-29 Troels Nielsen <bn.troels@gmail.com>
2701
934f3f58 2702 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2703 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2704 Bug#9642, but explicitly check that the buffer the overlay would
2705 be moved to is live and rearrange lines to make sure that errors
2706 will not put the overlay in an inconsistent state.
2707 (Fdelete_overlay): Cosmetics.
2708
85d0efd1
EZ
27092012-05-28 Eli Zaretskii <eliz@gnu.org>
2710
2711 * w32term.c (my_bring_window_to_top): New function.
2712 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2713 could be different from the original one.
2714 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2715 (Bug#11513)
2716
2717 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2718 by calling BringWindowToTop.
2719
2720 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2721 (WM_EMACS_END): Increase by one.
2722
da92a98c
PE
27232012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2724
2725 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2726 This avoids undefined behavior that might cause the eassert
2727 to not catch an out-of-range value.
2728
74d1f848
JB
27292012-05-28 Juanma Barranquero <lekktu@gmail.com>
2730
2731 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2732 Update dependencies.
2733
9e1a06fc
EZ
27342012-05-27 Eli Zaretskii <eliz@gnu.org>
2735
2736 * bidi.c (bidi_mirror_char): Fix last change.
2737
f3dd7312
AS
27382012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2739
2740 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2741 when referring to sectname field in printf format.
2742
81899c91
PE
27432012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2744
57b81a9f
PE
2745 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2746 Only r_alloc_inhibit_buffer_relocation needed to be added;
2747 the others were already declared.
2748
81899c91
PE
2749 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2750 before checking whether it's out of range. Put the check inside
2751 eassert. See
2752 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2753
33017faf 27542012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2755
2756 * callproc.c (Fcall_process): Restore a line that was accidentally
2757 commented out in the 2011-02-13 change (bug#11547).
2758
33017faf 27592012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2760
2761 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2762 defined on ralloc.c.
2763
2764 * buffer.c [REL_ALLOC]: Remove prototypes of
2765 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2766 they are now on lisp.h.
2767
2768 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2769
2770 * search.c (search_buffer): Use it to inhibit relocation of buffer
2771 text while re_search_2 is doing its job, because re_search_2 is
2772 passed C pointers to buffer text. (Bug#11519)
2773
23415acf
EZ
2774 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2775 Update value to 24.
2776
44e27368
EZ
2777 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2778 state after an additional call to move_it_in_display_line_to, keep
2779 the values of it->max_ascent and it->max_descent found for the
2780 entire line.
2781 (pos_visible_p): Revert the comparison against bottom_y to what it
2782 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2783 (Bug#11464)
2784
c1892f11
PE
27852012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 Fix coding-related core dumps with gcc -ftrapv.
2788 The code was computing A - B, where A and B are pointers, and B is
2789 random garbage. This can lead to core dumps on platforms that
2790 have special pointer registers, and it also leads to core dumps on
2791 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2792 A - B only when B is initialized properly.
2793 * coding.c (coding_set_source, coding_set_destination): Return void.
2794 (coding_change_source, coding_change_destinations): New functions,
2795 with the old behaviors of coding_set_source and coding_set_destination.
2796 All callers that need an offset changed to use these new functions.
2797
eb7afdad
GM
27982012-05-26 Glenn Morris <rgm@gnu.org>
2799
2800 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2801
f12fdf02
EZ
28022012-05-26 Eli Zaretskii <eliz@gnu.org>
2803
53a63be6 2804 Extend mouse support on W32 text-mode console.
61b108cc
SM
2805 * xdisp.c (draw_row_with_mouse_face):
2806 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2807
eb3f6f01 2808 * w32console.c: Include window.h.
61b108cc
SM
2809 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2810 New functions.
eb3f6f01
EZ
2811 (initialize_w32_display): Initialize mouse-highlight data.
2812
53a63be6
EZ
2813 * w32inevt.c: Include termchar.h and window.h.
2814 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2815 moves, call note_mouse_highlight. If help_echo changed, call
2816 gen_help_event to produce help-echo message in the echo area.
2817 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2818 highlight info.
2819
4cfd81f6
PE
28202012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 * lread.c (read1): Simplify slightly to avoid an overflow warning
2823 with GCC 4.7.0 on x86-64.
2824
4446092a
EZ
28252012-05-26 Eli Zaretskii <eliz@gnu.org>
2826
2827 * bidi.c (bidi_mirror_char): Revert last change: an int is
2828 definitely wide enough here.
2829
42b2a986 28302012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2831
42b2a986 2832 Fix integer width and related bugs (Bug#9874).
eb106a49 2833 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2834 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2835 (string_bytes, check_sblock, allocate_string_data):
2836 (compact_small_strings, Fmake_bool_vector, make_string)
2837 (make_unibyte_string, make_multibyte_string)
2838 (make_string_from_bytes, make_specified_string)
2839 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2840 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2841 (mark_vectorlike):
2842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2843 (allocate_pseudovector):
2844 Use int, not EMACS_INT, where int is wide enough.
2845 (inhibit_garbage_collection, Fgarbage_collect):
2846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2847 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2848 int might not be wide enough.
2849 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2850 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2851 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2852 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2853 (bidi_level_of_next_char, bidi_move_to_visually_next):
2854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2855 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2856 (Fkill_buffer, Fset_buffer_major_mode)
2857 (advance_to_char_boundary, Fbuffer_swap_text)
2858 (Fset_buffer_multibyte, overlays_at, overlays_in)
2859 (overlay_touches_p, struct sortvec, record_overlay_string)
2860 (overlay_strings, recenter_overlay_lists)
2861 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2862 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2863 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2864 (Foverlay_recenter, last_overlay_modification_hooks_used)
2865 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2867 (validate_region): Omit unnecessary test for b <= e,
2868 since that's guaranteed by the previous test.
d311d28c
PE
2869 (adjust_overlays_for_delete): Avoid pos + length overflow.
2870 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2871 (report_overlay_modification):
2872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2873 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2874 Omit pointer cast, which isn't needed anyway, and doesn't work
2875 after the EMACS_INT -> ptrdiff_t change.
02481186 2876 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2877 * buffer.h: Adjust decls to match defn changes elsewhere.
2878 (struct buffer_text, struct buffer):
2879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2880 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2881 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2882 not int, to avoid needless 32-bit limit on 64-bit hosts.
2883 (exec_byte_code): Use tighter memory-full test, one that checks
2884 for alloca overflow. Don't compute the address of the object just
2885 before an array, as that's not portable. Use EMACS_INT, not
2886 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2887 * callint.c (Fcall_interactively):
2888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2889 * callproc.c (call_process_kill, Fcall_process):
2890 Don't assume pid_t fits into an Emacs fixnum.
2891 (call_process_cleanup, Fcall_process, child_setup):
2892 Don't assume pid_t fits into int.
2893 (call_process_cleanup, Fcall_process, delete_temp_file)
2894 (Fcall_process_region):
2895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2896 (Fcall_process): Simplify handling of volatile integers.
2897 Use int, not EMACS_INT, where int will do.
2898 * casefiddle.c (casify_object, casify_region, operate_on_word)
2899 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2901 (casify_object): Avoid integer overflow when overallocating buffer.
2902 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2903 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2904 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2905 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2906 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2907 integers are now checked earlier. All uses replaced with XINT.
2908 (ccl_driver):
2909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2910 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2911 (ccl_driver, Fregister_code_conversion_map):
2912 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2913 (resolve_symbol_ccl_program): Check that vector header is in range.
2914 Always copy the vector, so that we can check its contents reliably
2915 now rather than having to recheck each instruction as it's being
2916 executed. Check that vector words fit in 'int'.
2917 (ccl_get_compiled_code, Fregister_ccl_program)
2918 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2919 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2920 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2921 contents are in range.
2922 (Fccl_execute_on_string): Check that status is in range.
2923 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2924 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2925 Accept and return EMACS_INT, not int, because callers can pass values
2926 out of 'int' range.
2927 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2928 (multibyte_chars_in_text, parse_str_as_multibyte)
2929 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2930 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2931 (string_escape_byte8, Fget_byte):
2932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2933 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2934 avoid mishandling large integers.
2935 * character.h: Adjust decls to match defn changes elsewhere.
2936 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2937 (Ffind_charset_region):
2938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2939 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2940 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2941 Don't assume fixnum fits in int.
d311d28c
PE
2942 (load_charset_map_from_vector, Fmap_charset_chars):
2943 Remove now-unnecessary CHECK_NATNUMs.
2944 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2945 Don't rely on undefined behavior with signed left shift overflow.
2946 Don't assume unsigned int fits into fixnum, or that fixnum fits
2947 into unsigned int. Don't require max_code to be a valid fixnum;
2948 that's not true for gb10830 4-byte on a 32-bit host. Allow
2949 invalid_code to be a cons, for the same reason. Require code_offset
2950 to be a character. Avoid int overflow if max_char is close
2951 to INT_MAX.
2952 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2953 this is intended anyway and avoids some undefined behavior.
2954 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2955 INDEX_TO_CODE_POINT, as that's what it expects.
2956 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2957 * charset.h (DECODE_CHAR): Return int, not unsigned;
2958 this is what was intended anyway, and it avoids undefined behavior.
2959 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2960 integer-overflow issues.
2961 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2962 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2963 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2964 * chartab.c (Fmake_char_table, Fset_char_table_range)
2965 (uniprop_get_decoder, uniprop_get_encoder):
2966 Don't assume fixnum fits in int.
2967 * cmds.c (move_point): New function, that does the gist of
2968 Fforward_char and Fbackward_char, but does so while checking
2969 for integer overflow more accurately.
c96e5d6a 2970 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2971 (Fforward_line, Fend_of_line, internal_self_insert)
2972 (internal_self_insert):
2973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2974 Fix a FIXME, by checking for integer overflow when calculating
2975 target_clm and actual_clm.
2976 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2977 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2978 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2979 (coding_alloc_by_making_gap, alloc_destination)
2980 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2981 (encode_coding_utf_16, detect_coding_emacs_mule)
2982 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2983 (detect_coding_iso_2022, decode_coding_iso_2022)
2984 (encode_invocation_designation, encode_designation_at_bol)
2985 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2986 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2987 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2988 (encode_coding_ccl, encode_coding_raw_text)
2989 (detect_coding_charset, decode_coding_charset)
2990 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2991 (produce_composition, produce_charset, produce_annotation)
2992 (decode_coding, handle_composition_annotation)
2993 (handle_charset_annotation, consume_chars, decode_coding_gap)
2994 (decode_coding_object, encode_coding_object, detect_coding_system)
2995 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2996 (code_convert_region, code_convert_string)
8f50130c
PE
2997 (Fdefine_coding_system_internal)
2998 (coding_set_source, coding_set_destination):
d311d28c
PE
2999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3000 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3001 (Fdefine_coding_system_internal):
3002 Don't assume fixnums fit in int.
3003 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3004 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3005 (Funencodable_char_position, Fcheck_coding_systems_region)
3006 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3008 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3009 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3010 Don't access memory outside of the args array.
d311d28c 3011 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3012 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3013 result of ENCODE_CHAR.
d311d28c
PE
3014 * coding.h: Adjust decls to match defn changes elsewhere.
3015 (struct coding_system):
3016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3017 * composite.c (get_composition_id, find_composition)
3018 (run_composition_function, update_compositions)
3019 (compose_text, composition_gstring_put_cache)
3020 (composition_gstring_p, composition_gstring_width)
3021 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3022 (composition_compute_stop_pos, composition_reseat_it)
3023 (composition_update_it, struct position_record)
3024 (find_automatic_composition, composition_adjust_point)
3025 (Fcomposition_get_gstring, Ffind_composition_internal):
3026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3027 (update_compositions):
3028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3029 * composite.h: Adjust decls to match defn changes elsewhere.
3030 (struct composition):
3031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3032 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3033 Do not attempt to compute the address of the object just before a
3034 buffer; this is not portable.
3035 (Faref, Faset):
3036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3037 (Faset): Use int, not EMACS_INT, where int is wide enough.
3038 (Fstring_to_number): Don't assume fixnums fit in int.
3039 (Frem): Don't assume arg is nonnegative.
3040 * dbusbind.c (xd_append_arg): Check for integers out of range.
3041 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3042 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3043 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3044 (xd_get_connection_references): Return ptrdiff_t, not int.
3045 All uses changed.
3046 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3047 (xd_read_message_1):
3048 Use int, not unsigned, where the dbus API uses int.
3049 (Fdbus_message_internal): Don't overflow mtype.
3050 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3051 * dired.c (directory_files_internal, file_name_completion, scmp)
3052 (file_name_completion_stat):
3053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3054 (file_name_completion): Don't overflow matchcount.
3055 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3056 * dispextern.h: Adjust decls to match defn changes elsewhere.
3057 (struct text_pos, struct glyph, struct bidi_saved_info)
3058 (struct bidi_string_data, struct bidi_it, struct composition_it)
3059 (struct it):
3060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3061 (struct display_pos, struct composition_it, struct it):
3062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3063 * dispnew.c (increment_matrix_positions)
3064 (increment_row_positions, mode_line_string)
3065 (marginal_area_string):
3066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3067 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3069 (duration_to_sec_usec): New function, to check for overflow better.
3070 (Fsleep_for, sit_for): Use it.
3071 * doc.c (get_doc_string, store_function_docstring):
3072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3073 (get_doc_string, Fsnarf_documentation):
3074 Use int, not EMACS_INT, where int is wide enough.
3075 (get_doc_string):
3076 Use SAFE_ALLOCA, not alloca.
3077 Check for overflow when converting EMACS_INT to off_t.
3078 * doprnt.c (doprnt):
3079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3080 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3081 Don't assume uid_t fits into fixnum.
3082 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3083 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3084 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3085 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3086 (general_insert_function)
3087 (Finsert_char, make_buffer_string, make_buffer_string_both)
3088 (update_buffer_properties, Fbuffer_substring)
3089 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3090 (Fsubst_char_in_region, check_translation)
3091 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3092 (transpose_markers, Ftranspose_regions):
3093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3094 (clip_to_bounds): Move to lisp.h as an inline function).
3095 (Fconstrain_to_field): Don't assume integers are nonnegative.
3096 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3097 (Fsubst_char_in_region, Fsave_restriction):
3098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3099 (Femacs_pid): Don't assume pid_t fits into fixnum.
3100 (lo_time): Use int, not EMACS_INT, when int suffices.
3101 (lisp_time_argument): Check for usec out of range.
3102 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3103 (Fuser_login_name, Fuser_full_name): Signal an error
3104 if a uid argument is out of range, rather than relying on
3105 undefined behavior.
c8d5c857
PE
3106 (Fformat_time_string): Remove now-unnecessary check.
3107 lisp_time_argument checks for out-of-range usec now.
243e0530 3108 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3109 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3110 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3111 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3112 (init_cmdargs, Fdump_emacs):
3113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3114 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3115 the bottom (typically) 32 bits of the fixnum.
3116 * eval.c (specpdl_size, call_debugger):
3117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3118 (when_entered_debugger, Fbacktrace_debug):
3119 Don't assume fixnum can fit in int.
3120 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3121 the object just before a buffer; this is not portable.
3122 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3123 (grow_specpdl, unbind_to):
3124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3125 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3126 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3127 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3128 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3129 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3131 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3132 (a_write, e_write):
3133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3134 (Fcopy_file, non_regular_nbytes, read_non_regular)
3135 (Finsert_file_contents):
3136 Use int, not EMACS_INT, where int is wide enough.
3137 (READ_BUF_SIZE): Verify that it fits in int.
3138 (Finsert_file_contents): Check that counts are in proper range,
3139 rather than assuming fixnums fit into ptrdiff_t etc.
3140 Don't assume fixnums fit into int.
125b3835 3141 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3142 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3143 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3144 (string_char_to_byte, string_byte_to_char)
3145 (string_make_multibyte, string_to_multibyte)
3146 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3147 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3148 (substring_both, Fdelete, internal_equal, Ffillarray)
3149 (Fclear_string, mapcar1)
3150 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3151 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3152 (larger_vector, make_hash_table, maybe_resize_hash_table)
3153 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3154 (Fmaphash, secure_hash):
3155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3156 (concat): Check for string index and length overflow.
3157 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3158 (Frequire):
3159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3160 (larger_vector): New API (vec, incr_min, size_max) replaces old
3161 one (vec, new_size, init). This catches size overflow.
3162 INIT was removed because it was always Qnil.
3163 All callers changed.
3164 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3165 the upper bound on a hash table index size.
3166 (make_hash_table, maybe_resize_hash_table): Use it.
3167 (secure_hash): Computer start_byte and end_byte only after
3168 they're known to be in ptrdiff_t range.
3169 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3170 (Ffont_get_glyphs, Ffont_at):
3171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3172 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3173 (Flist_fonts, Fopen_font):
3174 Don't assume fixnum can fit in int.
3175 (check_gstring): Don't assume index can fit in int.
3176 (font_match_p): Check that fixnum is a character, not a nonnegative
3177 fixnum, since the later code needs to stuff it into an int.
3178 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3179 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3180 conversion overflow issues.
3181 (Fopen_font): Check for integer out of range.
3182 (Ffont_get_glyphs): Don't assume index can fit in int.
3183 * font.h: Adjust decls to match defn changes elsewhere.
3184 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3185 integer overflow.
3186 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3187 printmax_t, where ptrdiff_t is wide enough.
3188 (Finternal_char_font):
3189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3190 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3191 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3192 (Fset_frame_position, x_set_frame_parameters)
3193 (x_set_line_spacing, x_set_border_width)
3194 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3195 Check that fixnums are in proper range for system types.
3196 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3198 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3199 Use SAFE_ALLOCA_LISP, not alloca.
3200 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3201 intptr_t is wide enough.
3202 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3203 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3204 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3205 Check for fixnum out of range.
3206 * ftfont.c (ftfont_list): Don't assume index fits in int.
3207 Check that fixnums are in proper range for system types.
3208 (ftfont_shape_by_flt):
3209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3210 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3212 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3213 Check that fixnums are in proper range for system types.
3214 * gnutls.h: Adjust decls to match defn changes elsewhere.
3215 * gtkutil.c (xg_dialog_run):
3216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3217 (update_frame_tool_bar):
3218 Check that fixnums are in proper range for system types.
3219 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3220 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3221 * indent.c (last_known_column, last_known_column_point):
3222 (current_column_bol_cache):
3223 (skip_invisible, current_column, check_display_width):
3224 (check_display_width, scan_for_column, current_column_1)
3225 (Findent_to, Fcurrent_indentation, position_indentation)
3226 (indented_beyond_p, Fmove_to_column, compute_motion):
3227 (Fcompute_motion, Fvertical_motion):
3228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3229 (last_known_column_modified): Use EMACS_INT, not int.
3230 (check_display_width):
3231 (Fcompute_motion):
3232 Check that fixnums and floats are in proper range for system types.
3233 (compute_motion): Don't assume index or fixnum fits in int.
3234 (compute_motion, Fcompute_motion):
3235 Use int, not EMACS_INT, when it is wide enough.
3236 (vmotion): Omit local var start_hpos that is always 0; that way
3237 we don't need to worry about overflow in expressions involving it.
3238 * indent.h: Adjust decls to match defn changes elsewhere.
3239 (struct position):
3240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3241 Use int, not EMACS_INT, where int is wide enough.
3242 Remove unused members ovstring_chars_done and tab_offset;
3243 all uses removed.
3244 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3245 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3246 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3247 (make_gap, copy_text, insert, insert_and_inherit)
3248 (insert_before_markers, insert_before_markers_and_inherit)
3249 (insert_1, count_combining_before, count_combining_after)
3250 (insert_1_both, insert_from_string)
3251 (insert_from_string_before_markers, insert_from_string_1)
3252 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3253 (adjust_after_replace, adjust_after_insert, replace_range)
3254 (replace_range_2, del_range, del_range_1, del_range_byte)
3255 (del_range_both, del_range_2, modify_region)
3256 (prepare_to_modify_buffer, signal_before_change)
3257 (signal_after_change, Fcombine_after_change_execute):
3258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3259 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3260 (balance_an_interval, split_interval_right, split_interval_left)
3261 (find_interval, next_interval, update_interval)
3262 (adjust_intervals_for_insertion, delete_node, delete_interval)
3263 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3264 (static_offset_intervals, offset_intervals)
3265 (merge_interval_right, merge_interval_left, make_new_interval)
3266 (graft_intervals_into_buffer, temp_set_point_both)
3267 (temp_set_point, set_point, adjust_for_invis_intang)
3268 (set_point_both, move_if_not_intangible, get_property_and_range)
3269 (get_local_map, copy_intervals, copy_intervals_to_string)
3270 (compare_string_intervals, set_intervals_multibyte_1):
3271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3272 * intervals.h: Adjust decls to match defn changes elsewhere.
3273 (struct interval):
3274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3275 * keyboard.c (this_command_key_count, this_single_command_key_start)
3276 (before_command_key_count, before_command_echo_length, echo_now)
3277 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3278 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3279 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3280 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3282 (last_non_minibuf_size, last_point_position, echo_truncate)
3283 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3284 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3285 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3286 (stuff_buffered_input):
3287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3288 (last_auto_save, command_loop_1, read_char):
3289 Use EMACS_INT, not int, to avoid integer overflow.
3290 (record_char): Avoid overflow in total_keys computation.
3291 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3292 * keyboard.h: Adjust decls to match defn changes elsewhere.
3293 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3294 (Fkey_description, Fdescribe_vector, Flookup_key):
3295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3296 (click_position): New function, to check that positions are in range.
3297 (Fcurrent_active_maps):
3298 (describe_command):
3299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3300 (Faccessible_keymaps, Fkey_description):
3301 (preferred_sequence_p):
3302 Don't assume fixnum can fit into int.
3303 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3304 Check for integer overflow in size calculations.
3305 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3306 avoid mishandling large integers.
3307 * lisp.h: Adjust decls to match defn changes elsewhere.
3308 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3309 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3310 (struct Lisp_Marker):
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3312 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3313 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3314 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3315 All callers changed.
3316 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3317 Assume the arg has valid form, since it always does.
3318 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3319 unsigned integer system type.
3320 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3321 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3323 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3324 (duration_to_sec_usec): New decl.
3325 * lread.c (read_from_string_index, read_from_string_index_byte)
3326 (read_from_string_limit, readchar, unreadchar, openp)
3327 (read_internal_start, read1, oblookup):
3328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3329 (Fload, readevalloop, Feval_buffer, Feval_region):
3330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3331 (openp): Check for out-of-range argument to 'access'.
3332 (read1): Use int, not EMACS_INT, where int is wide enough.
3333 Don't assume fixnum fits into int.
6efdadfd 3334 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3335 (read_filtered_event): Use duration_to_sec_usec
3336 to do proper overflow checking on durations.
d311d28c
PE
3337 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3338 in size calculation.
3339 (Fexecute_kbd_macro):
3340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3341 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3342 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3343 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3344 (set_marker_both, set_marker_restricted_both, marker_position)
3345 (marker_byte_position, Fbuffer_has_markers_at):
3346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3347 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3348 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3349 It now merely ensures that the menu is large enough, without
3350 necessarily growing it, as this avoids some integer overflow issues.
3351 All callers changed.
3352 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3354 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3355 Use SAFE_ALLOCA_LISP, not alloca.
3356 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3357 to EMACS_INT. Check that fixnums are in proper range for system types.
3358 * minibuf.c (minibuf_prompt_width, string_to_object)
3359 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3360 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3362 (get_minibuffer, read_minibuf_unwind):
3363 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3364 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3365 this simplifies overflow checking. All callers changed.
3366 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3367 (Ftest_completion):
3368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3369 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3370 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3371 Check that fixnums are in proper range for system types.
3372 (Fx_create_frame, Fx_show_tip):
3373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3374 * nsfont.m (ns_findfonts, nsfont_list_family):
3375 Don't assume fixnum fits in long.
3376 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3378 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3379 wide enough.
17fdb222 3380 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3382 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3383 (PRINTDECLARE, PRINTPREPARE):
3384 (strout, print_string):
3385 (print, print_preprocess, print_check_string_charset_prop)
3386 (print_object):
3387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3388 (PRINTDECLARE):
3389 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3391 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3392 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3393 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3394 (print_error_message): Use SAFE_ALLOCA, not alloca.
3395 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3396 (print_depth, new_backquote_output, print_number_index):
3397 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3398 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3399 (Fset_process_window_size, Fformat_network_address)
3400 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3401 (sigchld_handler):
d311d28c 3402 Check that fixnums are in proper range for system types.
d44287d4 3403 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3404 Check for process-ids out of pid_t range rather than relying on
3405 undefined behavior.
e4d81efc 3406 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3407 (Fformat_network_address, read_process_output, send_process)
3408 (Fprocess_send_region, status_notify):
3409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3410 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3411 (wait_reading_process_output, read_process_output, exec_sentinel):
3412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3413 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3414 (Faccept_process_output): Use duration_to_sec_usec to do proper
3415 overflow checking on durations.
dde14581
PE
3416 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3417 Don't assume pid_t fits in int.
02481186
PE
3418 * process.h (struct Lisp_Process): Members tick and update_tick
3419 are now of type EMACS_INT, not int.
b62b53e8
PE
3420 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3421 configured --with-wide-int.
d311d28c
PE
3422 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3423 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3424 * search.c (looking_at_1, string_match_1):
3425 (fast_string_match, fast_c_string_match_ignore_case)
3426 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3427 (scan_newline, find_before_next_newline, search_command)
3428 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3429 (set_search_regs, wordify):
3430 (Freplace_match):
3431 (Fmatch_data):
3432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3433 (string_match_1, search_buffer, set_search_regs):
3434 (Fmatch_data):
3435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3436 (wordify): Check for overflow in size calculation.
3437 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3438 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3439 Check that fixnums are in proper range for system types.
3440 * sound.c (struct sound_device)
3441 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3443 (Fplay_sound_internal):
3444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3445 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3446 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3447 (Fparse_partial_sexp):
3448 Don't assume fixnums can fit in int.
3449 (struct lisp_parse_state, find_start_pos, find_start_value)
3450 (find_start_value_byte, find_start_begv)
3451 (update_syntax_table, char_quoted, dec_bytepos)
3452 (find_defun_start, prev_char_comend_first, back_comment):
3453 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3454 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3456 (Finternal_describe_syntax_value): Check that match_lisp is a
3457 character, not an integer, since the code stuffs it into int.
3458 (scan_words, scan_sexps_forward):
3459 Check that fixnums are in proper range for system types.
3460 (Fforward_word):
3461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3462 (scan_sexps_forward):
3463 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3464 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3465 * syntax.h: Adjust decls to match defn changes elsewhere.
3466 (struct gl_state_s):
3467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3468 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3469 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3470 * sysdep.c (wait_for_termination_1, wait_for_termination)
3471 (interruptible_wait_for_termination, mkdir):
3472 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3473 (emacs_read, emacs_write):
3474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3475 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3476 and double all fit in int.
d311d28c
PE
3477 * term.c (set_tty_color_mode):
3478 Check that fixnums are in proper range for system types.
3479 * termhooks.h (struct input_event):
3480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3481 * textprop.c (validate_interval_range, interval_of)
3482 (Fadd_text_properties, set_text_properties_1)
3483 (Fremove_text_properties, Fremove_list_of_text_properties)
3484 (Ftext_property_any, Ftext_property_not_all)
3485 (copy_text_properties, text_property_list, extend_property_ranges)
3486 (verify_interval_modification):
3487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3488 (Fnext_single_char_property_change)
3489 (Fprevious_single_char_property_change):
3490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3491 (copy_text_properties):
3492 Check for integer overflow in index calculation.
d311d28c
PE
3493 * undo.c (last_boundary_position, record_point, record_insert)
3494 (record_delete, record_marker_adjustment, record_change)
3495 (record_property_change):
3496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3497 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3499 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3500 (Fx_hide_tip, Fx_file_dialog):
3501 * w32menu.c (set_frame_menubar):
3502 Use ptrdiff_t, not int, for consistency with rest of code.
3503 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3504 (select_window, Fdelete_other_windows_internal)
3505 (window_scroll_pixel_based, window_scroll_line_based)
3506 (Frecenter, Fset_window_configuration):
3507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3508 (Fset_window_hscroll, run_window_configuration_change_hook)
3509 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3510 (Fscroll_other_window, Frecenter):
d311d28c
PE
3511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3512 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3513 Don't assume fixnum fits in int.
3514 (Fset_window_scroll_bars):
3515 Check that fixnums are in proper range for system types.
3516 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3517 (string_pos, c_string_pos, number_of_chars, init_iterator)
3518 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3519 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3520 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3521 (face_before_or_after_it_pos, handle_invisible_prop)
3522 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3523 (display_prop_intangible_p, string_buffer_position_lim)
3524 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3525 (get_overlay_strings_1, get_overlay_strings)
3526 (iterate_out_of_display_property, forward_to_next_line_start)
3527 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3528 (get_next_display_element, set_iterator_to_next)
3529 (get_visually_first_element, compute_stop_pos_backwards)
3530 (handle_stop_backwards, next_element_from_buffer)
3531 (move_it_in_display_line_to, move_it_in_display_line)
3532 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3533 (add_to_log, message_dolog, message_log_check_duplicate)
3534 (message2, message2_nolog, message3, message3_nolog
3535 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3536 (current_message_1, truncate_echo_area, truncate_message_1)
3537 (set_message, set_message_1, store_mode_line_noprop)
3538 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3539 (text_outside_line_unchanged_p, check_point_in_composition)
3540 (reconsider_clip_changes)
3541 (redisplay_internal, set_cursor_from_row, try_scrolling)
3542 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3543 (redisplay_window, find_last_unchanged_at_beg_row)
3544 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3545 (trailing_whitespace_p, find_row_edges, display_line)
3546 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3547 (display_mode_element, store_mode_line_string)
3548 (pint2str, pint2hrstr, decode_mode_spec)
3549 (display_count_lines, display_string, draw_glyphs)
3550 (x_produce_glyphs, x_insert_glyphs)
3551 (rows_from_pos_range, mouse_face_from_buffer_pos)
3552 (fast_find_string_pos, mouse_face_from_string_pos)
3553 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3555 (safe_call, init_from_display_pos, handle_fontified_prop)
3556 (handle_single_display_spec, load_overlay_strings)
3557 (with_echo_area_buffer, setup_echo_area_for_printing)
3558 (display_echo_area, echo_area_display)
3559 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3560 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3561 (redisplay_window, dump_glyph_row, display_mode_line)
3562 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3563 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3565 (handle_single_display_spec, build_desired_tool_bar_string)
3566 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3567 (get_specified_cursor_type):
3568 Check that fixnums are in proper range for system types.
3569 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3570 (Flookup_image_map):
3571 Don't assume fixnums fit in int.
3572 (compare_overlay_entries):
3573 Avoid mishandling comparisons due to subtraction overflow.
3574 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3575 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3576 (handle_tool_bar_click):
3577 Use int, not unsigned, since we prefer signed and the signedness
3578 doesn't matter here.
3579 (get_next_display_element, next_element_from_display_vector):
3580 Use int, not EMACS_INT, when int is wide enough.
3581 (start_hourglass): Use duration_to_sec_usec to do proper
3582 overflow checking on durations.
3583 * xfaces.c (Fbitmap_spec_p):
3584 Check that fixnums are in proper range for system types.
3585 (compare_fonts_by_sort_order):
3586 Avoid mishandling comparisons due to subtraction overflow.
3587 (Fx_family_fonts, realize_basic_faces):
3588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3589 (Fx_family_fonts):
3590 Don't assume fixnum fits in int.
3591 Use SAFE_ALLOCA_LISP, not alloca.
3592 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3593 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3594 (face_at_buffer_position, face_for_overlay_string)
3595 (face_at_string_position):
3596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3597 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3598 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3599 (Fx_show_tip):
3600 Check that fixnums are in proper range for system types.
3601 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3602 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3604 (Fx_change_window_property): Don't assume fixnums fit in int.
3605 * xfont.c (xfont_chars_supported):
3606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3607 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3608 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3610 * xml.c (parse_region):
3611 * xrdb.c (magic_file_p):
3612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3613 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3614 (x_get_local_selection, x_reply_selection_request)
3615 (x_handle_selection_request, wait_for_property_change):
3616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3617 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3618 short is wide enough.
3619 (x_send_client_event): Don't assume fixnum fits in int.
3620 * xterm.c (x_x_to_emacs_modifiers):
3621 Don't assume EMACS_INT overflows nicely into int.
3622 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3623 may come from Lisp.
3624 (handle_one_xevent): NATNUMP can eval its arg twice.
3625 (x_connection_closed):
3626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3627 * xterm.h: Adjust decls to match defn changes elsewhere.
3628 (struct scroll_bar): Use struct vectorlike_header
3629 rather than rolling our own approximation.
3630 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3631
c6574eb5
GM
36322012-05-25 Glenn Morris <rgm@gnu.org>
3633
3634 * lisp.mk (lisp): Update for more files being compiled now.
3635
e8d32c7e
SM
36362012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3637
48def666
SM
3638 * lread.c: Remove `read_pure' which makes no difference.
3639 (read_pure): Remove var.
3640 (unreadpure): Remove function.
3641 (readevalloop): Don't call read_list with -1 flag.
3642 (read1, read_vector): Don't test read_pure any more.
3643 (read_list): Simplify.
3644
e8d32c7e
SM
3645 * fileio.c, character.h: Minor style tweaks.
3646
4b2addb7
DA
36472012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3648
3649 * window.h (clip_changed): Remove useless declaration.
3650
584461b2
JB
36512012-05-22 Juanma Barranquero <lekktu@gmail.com>
3652
3653 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3654 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3655
34374650
PE
36562012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 Remove src/m/*.
3659 This directory predates autoconf and is no longer needed nowadays.
3660 Move its few remaining bits of functionality to where they're needed.
3661 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3662 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3663 * m/template.h: Remove.
3664 * Makefile.in (M_FILE): Remove. All uses removed.
3665 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3666 * lisp.h (USE_LSB_TAG):
3667 * mem-limits.h (EXCEEDS_LISP_PTR):
3668 Use VAL_MAX, not VALBITS, in #if.
3669 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3670 (EMACS_UINT): Define unconditionally now.
3671 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3672 (BITS_PER_EMACS_INT): New constants, replacing
3673 what used to be in config.h, but not useful in #if.
3674 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3675 define them any more.
3676 (VAL_MAX): New macro.
3677 (VALMASK): Use it.
3678 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3679 BITS_PER_EMACS_INT, in #if.
3680 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3681 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3682 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3683 * s/ms-w32.h (DATA_START):
3684 Move here from removed file m/intel386.h.
3685 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3686 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3687
261cb4bb
PE
36882012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 Assume C89 or later.
3691 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3692 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3693 (xrealloc):
3694 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3695 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3696 * textprop.c, tparam.c (NULL): Remove.
3697 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3698 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3699 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3700 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3701 * xterm.c (input_signal_count): Assume volatile works.
3702
ff23cd9f
KB
37032012-05-21 Ken Brown <kbrown@cornell.edu>
3704
3705 * xgselect.c (xg_select): Fix first argument in call to 'select'
3706 (bug#11508).
3707
1b170bc6
KB
37082012-05-20 Ken Brown <kbrown@cornell.edu>
3709
3710 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3711 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3712
b2f4d39f
KB
37132012-05-19 Ken Brown <kbrown@cornell.edu>
3714
3715 * xfns.c (x_in_use): Remove `static' qualifier.
3716 * xterm.h (x_in_use): Declare.
3717 * xgselect.c: Include xterm.h.
3718 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3719 and `display_arg' (bug#9754).
3720
003fdae2
PE
37212012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3722
9232a6d9
PE
3723 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3724
003fdae2
PE
3725 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3726 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3727
784b56e2
EZ
37282012-05-18 Eli Zaretskii <eliz@gnu.org>
3729
3730 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3731
3732 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3733 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3734
3735 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3736 reference to image_cache->refcount.
3737 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3738
a0a79cde
JL
37392012-05-17 Juri Linkov <juri@jurta.org>
3740
3741 * search.c (Fword_search_regexp, Fword_search_backward)
3742 (Fword_search_forward, Fword_search_backward_lax)
3743 (Fword_search_forward_lax): Move functions to isearch.el
3744 (bug#10145, bug#11381).
3745
b0572523
PE
37462012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3747
3748 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3749
9660f5fc
SM
37502012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3751
3752 * lread.c (init_obarray): Declare Qt and Qnil as special.
3753
4374de83
GM
37542012-05-14 Glenn Morris <rgm@gnu.org>
3755
3756 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3757 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3758
dc44c39a
PE
37592012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3760
078c97cb
PE
3761 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3762
dc44c39a
PE
3763 * unexaix.c: Port to more-recent AIX compilers.
3764 (report_error, report_error_1, make_hdr, copy_sym)
3765 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3766 Make arguments const char *, not char *, to avoid violations of C
3767 standard and to fix some AIX warnings reported by Gilles Pion.
3768
e18afed7 37692012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3770
3771 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3772 already have overlays loaded.
3773 (handle_single_display_spec): Before returning without displaying
3774 fringe bitmap, synchronize the bidi iterator with the main display
3775 iterator, by calling iterate_out_of_display_property.
3776 (iterate_out_of_display_property): Detect buffer iteration by
3777 testing that it->string is a Lisp string.
3778 (get_next_display_element): When the current object is exhausted,
3779 and there's something on it->stack, call set_iterator_to_next to
3780 proceed with what's on the stack, instead of returning zero.
3781 (set_iterator_to_next): If called at the end of a Lisp string,
3782 proceed to consider_string_end without incrementing string
3783 position. Don't increment display vector index past the end of
3784 the display vector. (Bug#11417)
c8fb9dc6
EZ
3785 (pos_visible_p): Don't report a position visible when move_it_to
3786 stopped at the last line of window, which happens to be scanned
3787 backwards by the bidi iteration. (Bug#11464)
ac268e67 3788
e18afed7 37892012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3790
3791 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3792 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3793 are on a TTY, and thus unable to display on the fringes.
3794 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3795 so we need to signal to the caller that this is a "replacing"
3796 display spec. This fixes display when the spec is invalid or we
3797 are on a TTY.
3798
e18afed7 37992012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3800
3801 * unexaix.c (make_hdr): Fix typo in prototype.
3802 This bug broke the build on AIX. Problem reported by Gilles Pion.
3803
9d0a235a
MA
38042012-05-14 Michael Albinus <michael.albinus@gmx.de>
3805
3806 * keyboard.c (kbd_buffer_get_event): Read special events also in
3807 batch mode. (Bug#11415)
3808
9e6b06ed
GM
38092012-05-12 Glenn Morris <rgm@gnu.org>
3810
3811 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3812
c1a1d7a3
EZ
38132012-05-12 Eli Zaretskii <eliz@gnu.org>
3814
3815 * lisp.mk (lisp): Add newcomment.elc.
3816
3fe7cdc8
GM
38172012-05-12 Glenn Morris <rgm@gnu.org>
3818
3819 * Makefile.in (MKDIR_P): New, set by configure.
3820 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3821
53f7d2c0
PE
38222012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3823
3824 Remove unused function hourglass_started.
3825 * dispextern.h (hourglass_started):
3826 * w32fns.c (hourglass_started):
3827 * xdisp.c (hourglass_started): Remove.
3828
75aafb17
JB
38292012-05-10 Juanma Barranquero <lekktu@gmail.com>
3830
3831 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3832 Update dependencies.
3833
12959e8e
PE
38342012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3835
97107e2e
PE
3836 * xgselect.c (xg_select): Put maxfds+1 into a var.
3837 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3838
12959e8e
PE
3839 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3840
836d29b3
DA
38412012-05-10 Dave Abrahams <dave@boostpro.com>
3842
3843 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3844 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3845
5cb67954
MA
38462012-05-09 Michael Albinus <michael.albinus@gmx.de>
3847
3848 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3849 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3850 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3851 Initialize xd_registered_buses.
3852
3478ec45
PE
38532012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3854
b263a6b0
PE
3855 Untag more efficiently if USE_LSB_TAG.
3856 This is based on a proposal by YAMAMOTO Mitsuharu in
3857 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3858 For an admittedly artificial (nth 8000 longlist) benchmark on
3859 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3860 Emacs's overall text size by 1%.
3861 * lisp.h (XUNTAG): New macro.
3862 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3863 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3864 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3865 * eval.c (Fautoload):
3866 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3867 * frame.h (XFRAME): Use XUNTAG.
3868
3478ec45
PE
3869 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3870 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3871 Remove unportable assumptions about print widths of types like
3872 dbus_uint32_t.
3873 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3874 intptr_t when converting between pointer and integer, to avoid GCC
3875 warnings about wrong width.
3876
666b903b 38772012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3878
3879 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3880 stack for each reader_thread, instead of defaulting to 8MB
3881 determined by the linker. This avoids failures in creating
3882 subprocesses on Windows 7, see the discussion in this thread:
3883 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3884
b120cc17
JC
38852012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3886
3887 Fix up display of the *Minibuf-0* buffer in the mini window.
3888 * keyboard.c (read_char): Don't clear the echo area if there's no
3889 message to clear.
3890 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3891 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3892
9a4b36f8
MA
38932012-05-07 Michael Albinus <michael.albinus@gmx.de>
3894
3895 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3896 batch mode.
3897
e5f9458f
CY
38982012-05-06 Chong Yidong <cyd@gnu.org>
3899
3900 * lisp.mk (lisp): Update.
3901
eceeb5fc 39022012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3903
3904 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3905
71873e2b
SM
39062012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3907
3908 * data.c (PUT_ERROR): New macro.
3909 (syms_of_data): Use it. Add new error type `user-error'.
3910 * undo.c (user_error): New function.
3911 (Fprimitive_undo): Use it.
3912 * print.c (print_error_message): Adjust print style for `user-error'.
3913 * keyboard.c (user_error): New function.
3914 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3915
ab0fa4e4
PE
39162012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3917
3918 Do not limit current-time-string to years 1000..9999.
3919 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3920 (Fcurrent_time_string): Support any year that is supported by the
3921 underlying localtime representation. Don't use asctime, as it
3922 has undefined behavior for years outside the range -999..9999.
3923
7ed806a7
PE
39242012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3925
3926 Fix race conditions involving setenv, gmtime, localtime, asctime.
3927 Without this fix, interrupts could mess up code that uses these
3928 nonreentrant functions, since setting TZ invalidates existing
3929 tm_zone or tzname values, and since most of these functions return
3930 pointers to static storage.
3931 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3932 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3933 Grow the critical sections to include not just invoking
3934 localtime/gmtime, but also accessing these functions' results
3935 including their tm_zone values if any, and any related TZ setting.
3936 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3937 so that the struct tm is saved in the critical section.
3938 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3939 motivated by the fact that memory allocation needs to be outside
3940 the critical section.
3941
0c16dfed
DA
39422012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3943
3944 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3945 with RESET_INTERVAL.
3946
3947 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3948 Remove duplicated buffer name initialization.
3949
3f83ace8
JM
39502012-05-02 Jim Meyering <jim@meyering.net>
3951
3952 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3953
c7b8541e
JM
3954 * xfns.c (x_window): Use xstrdup (Bug#11375).
3955
90207a15 39562012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3957
3958 * xdisp.c (pos_visible_p): If already at a newline from the
3959 display string before the 'while' loop, don't walk back the glyphs
3960 from it3.glyph_row. Solves assertion violation when the display
3961 string begins with a newline (egg.el). (Bug#11367)
3962
b593d6a9
AH
39632012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3964
3965 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3966 Move to simple.el.
3967
4737362e
GM
39682012-05-01 Glenn Morris <rgm@gnu.org>
3969
99cf43f9
GM
3970 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3971 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3972 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3973 All were removed before 23.1.
3974
9311dcff
GM
3975 * dispnew.c: Remove HAVE_LIBNCURSES test;
3976 it is always true on relevant platforms.
3977
4d5c6349
GM
3978 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3979 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3980
4737362e
GM
3981 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3982
74dd3a6b
AS
39832012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3984
3985 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3986 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3987 Remove.
3988
13c379ee
PE
39892012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3990
3991 Do not avoid creating empty evaporating overlays (Bug#9642).
3992 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3993 That is, do not delete an evaporating overlay if it becomes
3994 empty after its bounds are adjusted to fit within its buffer.
3995 This fix caused other problems, and I'm reverting it until we get
3996 to the bottom of them.
3997
a8e7d6d7 39982012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3999
4000 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4001
a8e7d6d7 40022012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4003
4004 * xdisp.c (pos_visible_p): If the window start position is beyond
4005 ZV, start the display from buffer beginning. Prevents assertion
4006 violation in init_iterator when the minibuffer window is scrolled
4007 via the scroll bar.
4008
4009 * window.c (window_scroll_pixel_based): Likewise.
4010
a8e7d6d7 40112012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4012
4013 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4014
a8e7d6d7 40152012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4016
4017 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4018 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4019
a8e7d6d7 40202012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4021
b593d6a9
AH
4022 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4023 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4024
1c6900d9
EZ
40252012-04-26 Eli Zaretskii <eliz@gnu.org>
4026
4c3fa1d9
EZ
4027 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4028 display element, check also the underlying string or buffer
4029 character. (Bug#11341)
4030
1c6900d9
EZ
4031 * w32menu.c: Include w32heap.h.
4032 (add_menu_item): If the call to AppendMenuW (via
4033 unicode_append_menu) fails, disable Unicode menus only if we are
4034 running on Windows 9X/Me.
4035
42bf8205
AS
40362012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4037
4038 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4039 (xgetint): Add missing shift for LSB tags.
4040
b1bac16e
MR
40412012-04-24 Martin Rudalics <rudalics@gmx.at>
4042
4043 * keyboard.c (read_char): Don't wipe echo area for select window
4044 events: These might get delayed via `mouse-autoselect-window'
4045 (Bug#11304).
4046
d69621cc
JB
40472012-04-24 Juanma Barranquero <lekktu@gmail.com>
4048
4049 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4050 manipulation of :loaded-from data.
4051
02fd101b
JB
40522012-04-23 Juanma Barranquero <lekktu@gmail.com>
4053
4054 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4055 now a cons (bug#11311).
4056
888bec30
PE
40572012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4058
89a438bd
PE
4059 Do not create empty overlays with the evaporate property (Bug#9642).
4060 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4061 if it becomes empty after its bounds are adjusted to fit within
4062 its buffer. Without this fix, in a nonempty buffer (let ((o
4063 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4064 yields an empty overlay that has the evaporate property, which is
4065 not supposed to happen.
4066
1068fe4d
PE
4067 Fix minor GTK3 problems found by static checking.
4068 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4069 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4070 (struct _EmacsFixedClass, emacs_fixed_get_type):
4071 Move decls here from emacsgtkfixed.h, since they needn't be public.
4072 (emacs_fixed_get_type): Now static.
4073 (emacs_fixed_class_init): Omit unused local.
4074 (emacs_fixed_child_type): Remove; unused.
4075 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4076 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4077 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4078 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4079 (EMACS_FIXED_GET_CLASS): Remove; unused.
4080 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4081
888bec30
PE
4082 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4083 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4084
de85e130
PE
40852012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4086
d0baac98 4087 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4088 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4089 (__malloc_size_t, __malloc_ptrdiff_t):
4090 Remove. All uses removed, replaced by the definiens if needed,
4091 since we can assume C89 or better now.
4092 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4093 (protect_malloc_state, align, get_contiguous_space)
4094 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4095 (malloc_atfork_handler_child, malloc_enable_thread)
4096 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4097 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4098 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4099 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4100 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4101 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4102 Define using prototypes, not old style.
4103 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4104 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4105 (align): Don't assume that signed integer overflow wraps around.
4106 Omit unused local var.
4107 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4108 (_free_internal_nolock, memalign, mallochook, reallochook):
4109 Omit no-longer-needed casts.
4110 (valloc): Use getpagesize, not __getpagesize.
4111 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4112 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4113
de85e130
PE
4114 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4115
dcbf5805
MA
41162012-04-22 Michael Albinus <michael.albinus@gmx.de>
4117
4118 Move functions from C to Lisp. Make non-blocking method calls
4119 the default. Implement further D-Bus standard interfaces.
4120
4121 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4122 (QCdbus_request_name_allow_replacement)
4123 (QCdbus_request_name_replace_existing)
4124 (QCdbus_request_name_do_not_queue)
4125 (QCdbus_request_name_reply_primary_owner)
4126 (QCdbus_request_name_reply_in_queue)
4127 (QCdbus_request_name_reply_exists)
4128 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4129 (QCdbus_registered_serial, QCdbus_registered_method)
4130 (QCdbus_registered_signal): New Lisp objects.
4131 (XD_DEBUG_MESSAGE): Use sizeof.
4132 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4133 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4134 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4135 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4136 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4137 (xd_signature, xd_append_arg): Allow float for integer types.
4138 (xd_get_connection_references): New function.
b593d6a9
AH
4139 (xd_get_connection_address): Rename from xd_initialize.
4140 Return cached address.
dcbf5805
MA
4141 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4142 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4143 level.
4144 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4145 Return number of refcounts.
dcbf5805
MA
4146 (Fdbus_get_unique_name): Make stronger parameter check.
4147 (Fdbus_message_internal): New defun.
4148 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4149 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4150 (Fdbus_send_signal, Fdbus_register_service)
4151 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4152 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4153 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4154 (Vdbus_compiled_version, Vdbus_runtime_version)
4155 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4156 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4157 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4158 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4159 Adapt docstring.
dcbf5805 4160
52828e02
PE
41612012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4162
da05bc4c
PE
4163 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4164 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4165 Do not assume ptrdiff_t is the same width as 'int'.
4166
52828e02
PE
4167 * alloc.c: Handle unusual debugging option combinations.
4168 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4169 since the two debugging options are incompatible.
4170 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4171 is defined.
4172 (mem_init, mem_insert, mem_insert_fixup):
4173 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4174 (NEED_MEM_INSERT): Remove; no longer needed.
4175
f01769f9
LL
41762012-04-22 Leo Liu <sdl.web@gmail.com>
4177
4178 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4179
5790543d
PE
41802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4181
4182 * sysdep.c [__FreeBSD__]: Minor cleanups.
4183 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4184 Use Emacs indenting style more consistently. Avoid some casts.
4185 Use 'double' consistently rather than mixing 'float' and 'double'.
4186
b91b7e4d
EW
41872012-04-21 Eduard Wiebe <usenet@pusto.de>
4188
b593d6a9
AH
4189 * sysdep.c (list_system_processes, system_process_attributes):
4190 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4191
6114eb15
AS
41922012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4193
4194 * lisp.mk (lisp): Update.
4195
2f38dff7
PE
41962012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4197
4198 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4199 It is never used otherwise.
4200
4ae29f89
SM
42012012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4202
4203 * print.c (print_preprocess): Only check print_depth if print-circle
4204 is nil.
4205 (print_object): Check for cycles even when print-circle is nil and
4206 print-gensym is t, but only check print_depth if print-circle is nil.
4207
f30d612a
CY
42082012-04-20 Chong Yidong <cyd@gnu.org>
4209
4210 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4211 set the status to "failed" and ensure that sentinel is run.
4212
c07a4c0b 42132012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4214
4215 * process.c (Fset_process_inherit_coding_system_flag)
4216 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4217 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4218
c07a4c0b 42192012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4220
4221 * xdisp.c (string_buffer_position_lim): Limit starting position to
4222 BEGV.
4223 (set_cursor_from_row): If called for a mode-line or header-line
4224 row, return zero immediately.
4225 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4226 farther than the first row after the header line, if any.
4227 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4228 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4229
c07a4c0b 42302012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4231
4ae29f89
SM
4232 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4233 (bug#11238).
ad3a2b41 4234
c07a4c0b 42352012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 42362012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4237
4238 configure: new option --enable-gcc-warnings (Bug#11207)
4239 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4240 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4241 (ALL_CFLAGS): Use new macros rather than old.
4242 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4243 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4244 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4245 -Wunused-result, -Wunused-variable. This should go away once
4246 the Emacs and Gnulib regex code is merged.
4247 (xmalloc, xrealloc): Now static.
4248
aba027e8
PE
42492012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 * dired.c (Fsystem_groups): Remove unused local.
4252
e5a36063
GM
42532012-04-17 Glenn Morris <rgm@gnu.org>
4254
4255 * dired.c (Fsystem_users): Doc fix.
4256
316411f0
DA
42572012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4258
4259 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4260 (syms_of_dired): Add them.
4261
9426aba4
PE
42622012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4263
b62a57be
PE
4264 Fix minor alloc.c problems found by static checking.
4265 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4266 New extern decls, to avoid calling undeclared functions.
4267 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4268 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4269 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4270 (NEED_MEM_INSERT): New macro.
4271 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4272 Remove one incorrect comment and fix another.
b62a57be 4273
3539f31f
PE
4274 Fix minor ralloc.c problems found by static checking.
4275 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4276 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4277 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4278 (r_alloc_sbrk): Now static.
4279
a041960a
PE
4280 Improve ralloc.c interface checking.
4281 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4282 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4283 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4284 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4285 [REL_ALLOC]: ... to here, to check interface.
4286 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4287 Remove decls. This fixes an "It stinks!".
4288
9426aba4
PE
4289 * alloc.c (which_symbols): Fix alignment issue / type clash.
4290
d55c12ed
AS
42912012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4292
4293 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4294 (struct Lisp_Misc_Any): Likewise.
4295 (struct Lisp_Free): Likewise.
4296 * alloc.c (union aligned_Lisp_Symbol): Define.
4297 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4298 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4299 (union aligned_Lisp_Misc): Define.
4300 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4301 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4302 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4303
b948ce8b
PE
43042012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4305
4306 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4307 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4308 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4309 * s/netbsd.h, s/sol2-6.h:
4310 Remove definition of GC_MARK_STACK, since the default now works.
4311 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4312 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4313 no longer the default.
4314 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4315
35dc09a1 43162012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4317
35dc09a1
GM
4318 * lread.c (lisp_file_lexically_bound_p):
4319 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4320
35dc09a1
GM
43212012-04-14 Eli Zaretskii <eliz@gnu.org>
4322
4323 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4324 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4325
43262012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4327
4328 * nsterm.m (constrainFrameRect): Always constrain when there is only
4329 one screen (Bug#10962).
4330
bcd86815
KB
43312012-04-13 Ken Brown <kbrown@cornell.edu>
4332
4333 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4334
c25df26e
RT
43352012-04-13 Reuben Thomas <rrt@sc3d.org>
4336
4337 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4338
0fc59f1e
DC
43392012-04-11 Daniel Colascione <dancol@dancol.org>
4340
4341 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4342 against is gone. It's better to use vfork now so that when Cygwin
4343 gains a new, working vfork, we use it automatically (bug#10398).
4344
de8c03dc
SM
43452012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4346
4347 * window.c (save_window_save): Obey window-point-insertion-type.
4348
2f097256
GM
43492012-04-11 Glenn Morris <rgm@gnu.org>
4350
4351 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4352
453b951e
SM
43532012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4354
4355 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4356
75f1671a 43572012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4358
4359 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4360 (force_quit_count): New var.
4361 (handle_interrupt): Use it.
4362
2a8ce227
JB
43632012-04-10 Juanma Barranquero <lekktu@gmail.com>
4364
4365 * w32.c (w32_delayed_load): Record the full path of the library
4366 being loaded (bug#10424).
4367
935396c0
GM
43682012-04-09 Glenn Morris <rgm@gnu.org>
4369
05920a43
GM
4370 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4371 not just in the obarray, before snarfing them. (Bug#11036)
4372
935396c0
GM
4373 * Makefile.in ($(leimdir)/leim-list.el):
4374 Pass EMACS rather than BUILT_EMACS.
4375
a18ecafa
TZ
43762012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4377
4378 * process.c (make_process):
4379 * process.h: Add integer `gnutls_handshakes_tried' member to
4380 process struct.
4381
6bbef4e5
JC
4382 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4383 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4384
4385 * gnutls.c (gnutls_log_function2i): Convenience log function.
4386 (emacs_gnutls_read): Use new log functions,
4387 `gnutls_handshakes_tried' process member, and
4388 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4389 attempts per process (connection).
4390
b4d3bc10
CY
43912012-04-09 Chong Yidong <cyd@gnu.org>
4392
4393 * eval.c (Fuser_variable_p, user_variable_p_eh)
4394 (lisp_indirect_variable): Functions deleted.
4395 (Fdefvar): Caller changed.
4396
4397 * callint.c (Finteractive, Fcall_interactively):
4398 * minibuf.c (Fread_variable): Callers changed.
4399
70f4d973
EZ
44002012-04-09 Eli Zaretskii <eliz@gnu.org>
4401
4402 * xdisp.c (set_cursor_from_row): If the display string appears in
4403 the buffer at position that is closer to point than the position
4404 after the display string, display the cursor on the first glyph of
4405 the display string. Fixes cursor display when a 'display' text
4406 property immediately follows invisible text. (Bug#11094)
4407
cb3c2e3e
PE
44082012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4409
4410 composite.c: use 'double' consistently
4411 * composite.c (get_composition_id): Use 'double' consistently
4412 instead of converting 'float' to 'double' and vice versa; this is
4413 easier to understand and avoids a GCC warning.
4414
fd06db5d
GM
44152012-04-09 Glenn Morris <rgm@gnu.org>
4416
50fe702a
GM
4417 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4418 preparation for dumping it with emacs. (Bug#4789)
4419 (leimdir): New variable.
4420 ($(leimdir)/leim-list.el): New rule.
4421 (emacs$(EXEEXT)): Depend on leim-list.el.
4422
fd06db5d
GM
4423 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4424 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4425 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4426
55c131ee
AS
44272012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4428
4429 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4430 proper alignment.
4431
9209588f
JB
44322012-04-07 Juanma Barranquero <lekktu@gmail.com>
4433
4434 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4435 Remove unused local variable.
4436
e3fb2efb
PE
44372012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4438
4439 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4440 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4441 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4442 objects, as mark_maybe_pointer will catch them otherwise.
4443 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4444 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4445
b5385551
PE
44462012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 Fix typo that broke non-Windows builds.
4449 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4450
9078ead6
EZ
44512012-04-07 Eli Zaretskii <eliz@gnu.org>
4452
4453 Support building on MS-Windows with libxml2.
4454
4455 * makefile.w32-in (OBJ2): Add xml.$(O).
4456 (GLOBAL_SOURCES): Add xml.c.
4457 ($(BLD)/xml.$(O)): New dependency list.
4458
4459 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4460 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4461 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4462 [!WINDOWSNT]: New macros.
4463 (init_libxml2_functions, libxml2_loaded_p): New functions.
4464 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4465 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4466 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4467 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4468 linked in).
6bbef4e5
JC
4469 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4470 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4471 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4472
4473 * emacs.c: Don't include libxml/parser.h.
4474 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4475 xmlCleanupParser directly.
4476
4477 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4478
3811fdf3
EZ
44792012-04-07 Eli Zaretskii <eliz@gnu.org>
4480
4481 * indent.c (Fvertical_motion): If there is a display string at
4482 point, use it.vpos to compute how many lines to backtrack after
4483 move_it_to point. (Bug#11133)
4484
2f8e16b2
EZ
44852012-04-06 Eli Zaretskii <eliz@gnu.org>
4486
4487 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4488 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4489 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4490 macros related to unification of CJK characters. For the details,
4491 see the discussion following the message here:
4492 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4493
3d439cd1
CY
44942012-04-04 Chong Yidong <cyd@gnu.org>
4495
4496 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4497
8bc53d00
EZ
44982012-04-01 Eli Zaretskii <eliz@gnu.org>
4499
4500 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4501 instead of alloca. (Bug#11138)
4502
3b0512a3
AS
45032012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4504
4505 * w32menu.c (is_simple_dialog): Properly check lisp types.
4506 (Bug#11141)
4507
8427ddd2
EZ
45082012-03-31 Eli Zaretskii <eliz@gnu.org>
4509
979022ef
EZ
4510 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4511 position we get to after a call to move_it_to fails the
4512 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4513 only if we wind up in a string from display property. (Bug#11063)
4514
a6b1c7cc
EZ
4515 * window.c (Fdelete_other_windows_internal): Invalidate the row
4516 and column information about mouse highlight, so that redisplay
4517 restores it after reallocating the glyph matrices. (Bug#7464)
4518
8427ddd2
EZ
4519 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4520 string comes from a `display' text property, use the buffer
4521 position of that property as if we actually saw that position in
4522 the row's glyphs.
697ba24b
EZ
4523 (move_it_by_lines): Remove the assertion that
4524 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4525 violated when there's a before-string at the beginning of a line.
4526 (Bug#11063)
8427ddd2 4527
65a0a738
EZ
45282012-03-30 Eli Zaretskii <eliz@gnu.org>
4529
4530 * xdisp.c (append_space_for_newline): If the default face was
4531 remapped, use the remapped face for the appended newline.
4532 (extend_face_to_end_of_line): Use the remapped default face for
4533 extending the face to the end of the line.
4534 (display_line): Call extend_face_to_end_of_line when the default
4535 face was remapped. (Bug#11068)
4536
581355cc
EZ
45372012-03-29 Eli Zaretskii <eliz@gnu.org>
4538
4539 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4540
e8fc049f
SM
45412012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4542
4543 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4544
4fb9a543
GM
45452012-03-27 Glenn Morris <rgm@gnu.org>
4546
4547 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4548 Doc fixes.
4549
679910f1
KH
45502012-03-26 Kenichi Handa <handa@m17n.org>
4551
4552 * dispextern.h (struct glyph): Fix previous change. Change the
4553 bit length of glyphless.ch to 25 (Bug#11082).
4554
90d49b7f
CY
45552012-03-26 Chong Yidong <cyd@gnu.org>
4556
4557 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4558 (command_loop_1): Use it; inhibit selection update for
4559 handle-select-window too (Bug#8996).
4560
f514f6f0
FP
45612012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4562
e8fc049f 4563 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4564
bf43fa51
KH
45652012-03-25 Kenichi Handa <handa@m17n.org>
4566
4567 * dispextern.h (struct glyph): Change the bit length of
4568 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4569
8a0c01dd
EZ
45702012-03-24 Eli Zaretskii <eliz@gnu.org>
4571
4572 * s/ms-w32.h (tzname): Include time.h before redirecting to
4573 _tzname. Fixes the MSVC build. (Bug#9960)
4574
7d1c3a76
AS
45752012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4576
8ed79523
AS
4577 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4578 characters.
4579
7d1c3a76
AS
4580 * xterm.c (XTread_socket): Only modify handling_signal if
4581 !SYNC_INPUT. (Bug#11080)
4582
e99a9b8b
EZ
45832012-03-23 Eli Zaretskii <eliz@gnu.org>
4584
4585 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4586 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4587 when fetching a multibyte character consumes more bytes than
4588 CHAR_BYTES returns, due to unification of CJK characters in
4589 string_char. (Bug#11073)
4590
5063c0e1
TN
45912012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4592
4593 * process.c (wait_reading_process_output): Handle pty disconnect
4594 by refraining from sending oneself a SIGCHLD (bug#10933).
4595
9f851fbd
CY
45962012-03-22 Chong Yidong <cyd@gnu.org>
4597
4598 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4599
5063c0e1 4600 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4601 Mark string as coming from a prefix property.
4602 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4603 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4604
fb5b8aca
CY
46052012-03-21 Chong Yidong <cyd@gnu.org>
4606
4607 * xfaces.c (Vface_remapping_alist): Doc fix.
4608
62356a1b
EZ
46092012-03-20 Eli Zaretskii <eliz@gnu.org>
4610
4611 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4612 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4613 Doc fixes.
62356a1b 4614
025de85b
CY
46152012-03-20 Chong Yidong <cyd@gnu.org>
4616
4617 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4618 to reflect default non-nil value of redisplay-dont-pause.
4619
4827f94e
KH
46202012-03-19 Kenichi Handa <handa@m17n.org>
4621
4622 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4623 it fit in a valid range (Bug#11003).
4624
e50a24a2
EZ
46252012-03-18 Eli Zaretskii <eliz@gnu.org>
4626
4627 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4628 that is not from display property, accept the row as a "cursor
4629 row" if one of the string's character has a non-nil `cursor'
4630 property. Fixes cursor positioning when there are newlines in
4631 overlay strings, e.g. in icomplete.el. (Bug#11035)
4632
9af5ed87
PE
46332012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4636
d1f55f16
CY
46372012-03-12 Chong Yidong <cyd@gnu.org>
4638
4639 * eval.c (inhibit_lisp_code): Rename from
4640 inhibit_window_configuration_change_hook; move from window.c.
4641
4642 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4643 * window.c (run_window_configuration_change_hook)
4644 (syms_of_window): Callers changed.
4645
66c5eebd
CY
46462012-03-11 Chong Yidong <cyd@gnu.org>
4647
413df973
CY
4648 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4649
66c5eebd
CY
4650 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4651
1de11f56
CY
46522012-03-10 Chong Yidong <cyd@gnu.org>
4653
4654 * frame.c (other_visible_frames): Don't assume the selected frame
4655 is visible (Bug#10955).
4656
cae07000
SM
46572012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4658
4659 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4660
89c94350
JD
46612012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4662
4663 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4664 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4665 zero (Bug#10954).
4666
999dd333
GM
46672012-03-03 Glenn Morris <rgm@gnu.org>
4668
01a6dcc8 4669 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4670
de0100f2
EZ
46712012-03-02 Eli Zaretskii <eliz@gnu.org>
4672
4673 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4674 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4675 (redisplay_window, next_element_from_string): Fix typos in
4676 comments.
3e441275
EZ
4677 (redisplay_window): Pass to move_it_vertically the margin in
4678 pixels, not in screen lines.
de0100f2 4679
96a72ee9
GM
46802012-03-02 Glenn Morris <rgm@gnu.org>
4681
4682 * buffer.c (buffer-list-update-hook): Doc fix.
4683
312508d7
EZ
46842012-02-29 Eli Zaretskii <eliz@gnu.org>
4685
4686 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4687 push_it before setting up the iterator for the first overlay
4688 string, even if we have an empty string loaded.
4689 (next_overlay_string): If there's an empty string on the iterator
4690 stack, pop the stack. (Bug#10903)
4691
27f3c637
PE
46922012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4693
4694 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4695 Suggested by Stefan Monnier in
4696 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4697 * alloc.c (widen_to_Lisp_Object): New static function.
4698 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4699 and widening them to Lisp_Objects. This would work even if
4700 USE_LSB_TAG is defined and wide integers are used, which might
4701 happen in a future version of Emacs.
4702
3c9dfce6
CY
47032012-02-25 Chong Yidong <cyd@gnu.org>
4704
fa74b241
CY
4705 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4706 Doc fix.
4707
3c9dfce6
CY
4708 * xselect.c (Fx_selection_exists_p): Doc fix.
4709 (x_clipboard_manager_save_all): Print an informative message
4710 before saving to clipboard manager.
4711
9486df08
CY
47122012-02-24 Chong Yidong <cyd@gnu.org>
4713
4714 * keyboard.c (process_special_events): Handle all X selection
4715 requests in kbd_buffer, not just the next one (Bug#8869).
4716
f01d3321
CY
47172012-02-23 Chong Yidong <cyd@gnu.org>
4718
4719 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4720 call when setting menu-bar-lines and tool-bar-lines parameters.
4721 (unwind_create_frame_1): New helper function.
4722
4723 * window.c (inhibit_window_configuration_change_hook): New var.
4724 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4725 (syms_of_window): Initialize it.
f01d3321 4726
86b847b6
CY
47272012-02-22 Chong Yidong <cyd@gnu.org>
4728
4729 * xterm.c (x_draw_image_relief): Add missing type check for
4730 Vtool_bar_button_margin (Bug#10743).
4731
a59225b1
CY
47322012-02-21 Chong Yidong <cyd@gnu.org>
4733
4734 * fileio.c (Vfile_name_handler_alist): Doc fix.
4735
4736 * buffer.c (Fget_file_buffer): Protect against invalid file
4737 handler return value.
4738
310f5bd4
PE
47392012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4740
cb3a28cc
PE
4741 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4742 when computing $valmask.
4743
310f5bd4
PE
4744 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4745 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4746 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4747 It's useless in that case, and it can cause problems on hosts
4748 that allocate halves of EMACS_INT values separately.
4749 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4750 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4751 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4752 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4753 it avoids undefined behavior on hosts where shifting right by more
4754 than the word width has undefined behavior.
4755
2375c96a
CY
47562012-02-19 Chong Yidong <cyd@gnu.org>
4757
4758 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4759 (Funhandled_file_name_directory, Ffile_name_as_directory)
4760 (Fdirectory_file_name, Fexpand_file_name)
4761 (Fsubstitute_in_file_name): Protect against invalid file handler
4762 return values (Bug#10845).
4763
3eb49e71
EZ
47642012-02-18 Eli Zaretskii <eliz@gnu.org>
4765
4766 * .gdbinit (pitx): Fix incorrect references to fields of the
4767 iterator stack.
4768
7b926f3f
CY
47692012-02-17 Chong Yidong <cyd@gnu.org>
4770
4771 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4772
11273115
PE
47732012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4774
4775 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4776 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4777
c3a70e2b
CY
47782012-02-15 Chong Yidong <cyd@gnu.org>
4779
4780 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4781 marked as special. Also, starting docstrings with * is obsolete.
4782
0ca43699
AS
47832012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4784
4785 * gnutls.c (emacs_gnutls_write): Fix last change.
4786
2e8f3c56
LI
47872012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4788
4789 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4790 send_process.
4791
af70074f
SM
47922012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4793
4794 * keymap.c (Fsingle_key_description): Handle char ranges.
4795
95986d52
CY
47962012-02-12 Chong Yidong <cyd@gnu.org>
4797
afd83bd1
CY
4798 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4799 as that creates a dangerous corner case.
4800
95986d52
CY
4801 * window.c (Fdelete_window_internal): Invalidate the mouse
4802 highlight (Bug#9904).
4803
bd7da63e
GM
48042012-02-12 Glenn Morris <rgm@gnu.org>
4805
4806 * xselect.c (Fx_own_selection_internal)
4807 (Fx_get_selection_internal, Fx_disown_selection_internal)
4808 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4809 * nsselect.m (Fx_own_selection_internal)
4810 (Fx_disown_selection_internal, Fx_selection_exists_p)
4811 (Fx_selection_owner_p, Fx_get_selection_internal):
4812 Sync docs and argument specs with the xselect.c versions.
4813
77abcbc2
LI
48142012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4815
4816 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4817
90b671e2
EZ
48182012-02-11 Eli Zaretskii <eliz@gnu.org>
4819
1c0ca0b7
EZ
4820 * w32select.c (Fx_selection_exists_p): Sync doc string and
4821 argument list with xselect.c. (Bug#10783)
4822
4823 * w16select.c (Fx_selection_exists_p): Sync doc string and
4824 argument list with xselect.c. (Bug#10783)
90b671e2 4825
49241268
GM
48262012-02-10 Glenn Morris <rgm@gnu.org>
4827
4828 * fns.c (Fsecure_hash): Doc fix.
4829
f998bbe7 48302012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4831
4832 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4833
0992bd9c
CY
48342012-02-07 Chong Yidong <cyd@gnu.org>
4835
4836 * buffer.c (Fbuffer_local_variables)
4837 (buffer_lisp_local_variables): Handle unbound vars correctly;
4838 don't let Qunbound leak into Lisp.
4839
af008560
GM
48402012-02-07 Glenn Morris <rgm@gnu.org>
4841
dd605cc4
GM
4842 * image.c (Fimagemagick_types): Doc fix.
4843
af008560
GM
4844 * image.c (imagemagick-render-type): Change it from a lisp object
4845 to an integer. Move the doc here from the lisp manual.
4846 Treat all values not equal to 0 the same.
4847
1449fa1d
CY
48482012-02-06 Chong Yidong <cyd@gnu.org>
4849
4850 * doc.c (store_function_docstring): Avoid applying docstring of
4851 alias to base function (Bug#2603).
4852
3723ec07
AS
48532012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4854
4855 * .gdbinit (pp1, pv1): Remove redundant defines.
4856 (pr): Use pp.
4857
79c1cc1e
CY
48582012-02-04 Chong Yidong <cyd@gnu.org>
4859
4860 * nsterm.m: Declare a global (Bug#10694).
4861
d7f29f8e
EZ
48622012-02-04 Eli Zaretskii <eliz@gnu.org>
4863
cae07000
SM
4864 * w32.c (get_emacs_configuration_options):
4865 Include --enable-checking, if specified, in the return value.
d7f29f8e 4866
3b95a6f9
MR
48672012-02-04 Martin Rudalics <rudalics@gmx.at>
4868
4869 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4870 after rounding frame sizes. (Bug#9723)
4871
d6fa96a6
EZ
48722012-02-04 Eli Zaretskii <eliz@gnu.org>
4873
4874 * keyboard.c (adjust_point_for_property): Don't position point
4875 before BEGV. (Bug#10696)
4876
df0b2940
PE
48772012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4878
4879 Handle overflow when computing char display width (Bug#9496).
4880 * character.c (char_width): Return EMACS_INT, not int.
4881 (char_width, c_string_width): Check for overflow when
4882 computing the width; this is possible now that individual
4883 characters can have unbounded width. Problem introduced
4884 by merge from Emacs 23 on 2012-01-19.
4885
6bee44d6
MA
48862012-02-02 Michael Albinus <michael.albinus@gmx.de>
4887
4888 * dbusbind.c (Fdbus_register_method): Mention the return value
4889 :ignore in the docstring.
4890
44f92739
GM
48912012-02-02 Glenn Morris <rgm@gnu.org>
4892
1b9f60cc
GM
4893 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4894
44f92739
GM
4895 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4896 Unconditionally set to t. (Bug#10673)
4897 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4898 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4899 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4900
c5d3843c
KH
49012012-02-02 Kenichi Handa <handa@m17n.org>
4902
4903 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4904 0, do not call append_composite_glyph.
4905
159462d4 49062012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4907
4908 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4909 NULL (Bug#6988).
4910 (x_produce_glyphs): If the component of a composition is a null
4911 string, set it->pixel_width to 1 to avoid zero-width glyph.
4912
78cef877
EZ
49132012-02-01 Eli Zaretskii <eliz@gnu.org>
4914
4915 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4916 first 2 arguments are identical. This makes inserting large
4917 output from a subprocess an order of magnitude faster on
4918 MS-Windows, where all sbrk'ed memory is always contiguous.
4919
97897668
GM
49202012-01-31 Glenn Morris <rgm@gnu.org>
4921
4922 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4923 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4924 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4925
31fd3586
GM
49262012-01-29 Glenn Morris <rgm@gnu.org>
4927
4928 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4929
0e24a8b2
CY
49302012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4931
4932 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4933
cc0adcb0
CY
49342012-01-28 Chong Yidong <cyd@gnu.org>
4935
4936 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4937
acc28cb9
CY
49382012-01-26 Chong Yidong <cyd@gnu.org>
4939
9c69cfb7
CY
4940 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4941
acc28cb9
CY
4942 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4943 repeat counts (Bug#10507).
4944
48da7392
GM
49452012-01-26 Glenn Morris <rgm@gnu.org>
4946
4947 * lread.c (syms_of_lread): Doc fix.
4948
14af5f7f
CY
49492012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4950
4951 * coding.c (encode_designation_at_bol): Change return value to
4952 EMACS_INT.
4953
0b21c100
CY
49542012-01-25 Chong Yidong <cyd@gnu.org>
4955
4956 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4957
3c2907f7
CY
49582012-01-21 Chong Yidong <cyd@gnu.org>
4959
4960 * floatfns.c (Fcopysign): Make the second argument non-optional,
4961 since nil is not allowed anyway.
4962
959ad23f
AS
49632012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4964
4965 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4966 (send_process): Likewise.
4967
34a02f46
MR
49682012-01-19 Martin Rudalics <rudalics@gmx.at>
4969
4970 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4971 (Vwindow_persistent_parameters): Do not use Qstate.
4972 Rewrite doc-strings.
34a02f46 4973
1259009a 49742012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4975
4976 * character.c (char_width): New function.
70d4fdf6
GM
4977 (Fchar_width, c_string_width, lisp_string_width):
4978 Use char_width (Bug#9496).
25ed9e61 4979
6a6ee00d
MR
49802012-01-16 Martin Rudalics <rudalics@gmx.at>
4981
4982 * window.c (Vwindow_persistent_parameters): New variable.
4983 (Fset_window_configuration, save_window_save): Handle persistent
4984 window parameters.
4985
c85efaf7
EZ
49862012-01-14 Eli Zaretskii <eliz@gnu.org>
4987
4988 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4989 thrashing the stack of the thread. (Bug#9087)
4990
5944709e
PE
49912012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4992
4993 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4994
e71f5d99
EZ
49952012-01-11 Eli Zaretskii <eliz@gnu.org>
4996
4997 * xdisp.c (rows_from_pos_range): Handle the case where the
4998 highlight ends on a newline. (Bug#10464)
4999 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5000 he end column for display of highlight that ends on a newline
5001 before a R2L line.
5002
ce316182
GM
50032012-01-11 Glenn Morris <rgm@gnu.org>
5004
5005 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5006 from load-path also when installation-directory is nil. (Bug#10208)
5007
5b43da69
GM
50082012-01-10 Glenn Morris <rgm@gnu.org>
5009
74cc8ff9
GM
5010 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5011
7d8d6e4e
GM
5012 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5013 Update template values to be closer to their typical values these days.
5b43da69 5014
a0db8d43
EZ
50152012-01-09 Eli Zaretskii <eliz@gnu.org>
5016
5017 * xdisp.c (rows_from_pos_range): Accept additional argument
5018 DISP_STRING, and accept any glyph in a row whose object is that
5019 string as eligible for mouse highlight. Fixes mouse highlight of
5020 display strings from overlays. (Bug#10464)
5021
9a0115ab 50222012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5023
b9110d6a 5024 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5025 * fileio.c (auto_saving_dir_umask): New static var.
5026 (Fmake_directory_internal): Use it.
5027 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5028 creating the directory. The old code temporarily assigns
5029 too-generous permissions to the directory.
5030 (do_auto_save_eh): Clear it.
b9110d6a 5031 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5032 that the var is always cleared.
5033
6c1bd3f3
EZ
50342012-01-07 Eli Zaretskii <eliz@gnu.org>
5035
5036 * search.c (scan_buffer): Pass character positions to
5037 know_region_cache, not byte positions. (Bug#6540)
5038
069d2b50
L
50392012-01-07 LynX <_LynX@bk.ru> (tiny change)
5040
5041 * w32.c (sys_rename): Report EXDEV when rename of a directory
5042 fails because the target is on another logical disk. (Bug#10284)
5043
75bf0d33
DB
50442012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5045
5046 * xterm.c (x_embed_request_focus): New function.
5047
5048 * xterm.h: Add prototype.
5049
5050 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5051
1c6e5a32
GM
50522012-01-05 Glenn Morris <rgm@gnu.org>
5053
5054 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5055
651e947e
EZ
50562012-01-01 Eli Zaretskii <eliz@gnu.org>
5057
5058 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5059 Load gnutls_transport_set_lowat only if GnuTLS version is below
5060 2.11.1.
5061 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5062 GnuTLS versions below 2.11.1.
5063
3778cdd8
AL
50642011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5065
5066 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5067 to the doc string advising against its use for altering the way
5068 windows are scrolled.
5069
0e5317f7
KH
50702011-12-28 Kenichi Handa <handa@m17n.org>
5071
5072 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5073 coding-system ASCII compatible only when it does not produce BOM
5074 on encoding (Bug#10383).
5075
93d5ca1f
JD
50762011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5077
5078 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5079 can scroll.
5080 (create_and_show_popup_menu): Always use menu_position_func for
5081 Gtk3 (Bug#10361).
5082
ca22b785
AS
50832011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5084
5085 * callint.c (Fcall_interactively): Don't truncate prompt string.
5086
d048e1e6
EZ
50872011-12-23 Eli Zaretskii <eliz@gnu.org>
5088
5089 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5090 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5091 resumed from there (after widening). (Bug#10360)
d048e1e6 5092
5ccaba1f
JD
50932011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5094
5095 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5096
204ee57f
JD
50972011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5098
b81d40f0
JB
5099 * nsterm.m (x_free_frame_resources):
5100 Release f->output_data.ns->miniimage.
204ee57f
JD
5101 (ns_index_color): Fix indentation. Do not retain
5102 color_table->colors[i].
5103
5104 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5105 before returning.
5106
5107 * nsfns.m (x_set_background_color): Assign return value from
5108 ns_index_color to face-background instead of NSColor*.
5109 (ns_implicitly_set_icon_type): Fix indentation.
5110 Change assignment in for loop to comparison.
5111
5112 * emacs.c (ns_pool): New variable.
5113 (main): Assign ns_pool.
5114 (Fkill_emacs): Call ns_release_autorelease_pool.
5115
5116 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5117 autorelease fdesc, release fdAttrs and tdict.
5118 (ns_get_covering_families): Release charset.
5119 (ns_findfonts): Release NSFontDescriptor created with new.
5120 (ns_uni_to_glyphs): Fix indentation.
5121 (setString): Release attrStr before assigning new value.
5122
c803b2b7
JD
51232011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5124
678f4426
JD
5125 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5126 and NS_IMPL_COCOA.
5127 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5128 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5129
cd394be1 51302011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5131
5fecd5fc
JD
5132 * nsterm.m (ns_term_init): Subscribe for notifications
5133 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5134 to method trackingNotification in EmacsMenu.
5135
5136 * nsmenu.m (trackingMenu): New variable.
3771cb17 5137 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5138 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5139 from Aquamacs (Bug#7030).
678f4426
JD
5140
51412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5142
c803b2b7
JD
5143 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5144 (symbol_to_nsstring): Fix indentation.
5145 (ns_symbol_to_pb): New function.
cae07000
SM
5146 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5147 (Fns_rotate_cut_buffers_internal): Remove.
5148 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5149 Fns_store_cut_buffer_internal.
5150 (ns_get_foreign_selection, Fx_own_selection_internal)
5151 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5152 (Fns_get_selection_internal, Fns_store_selection_internal):
5153 Use ns_symbol_to_pb and check if return value is nil.
5154 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5155 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5156 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5157 renamed to Sns_store_selection_internal.
5158 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5159 and remove this function.
5160 (ns_handle_selection_clear): Remove, never used.
5161 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5162 here.
5163
e1b01a3a
KB
51642011-12-17 Ken Brown <kbrown@cornell.edu>
5165
5166 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5167 GID is unknown (Bug#10257).
5168
2adb6e85
PE
51692011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5170
5171 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5172 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5173 which caused a build failure on GNU/Linux IA-64. This problem was
5174 introduced by my 2011-10-07 patch.
5175
d1d7b339
JL
51762011-12-15 Juri Linkov <juri@jurta.org>
5177
5178 * image.c (imagemagick_error): New function. (Bug#10112)
5179 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5180 Use `imagemagick_error' where ImageMagick functions return
5181 `MagickFalse'.
5182 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5183 proper order.
5184
100d5755
KH
51852011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5186
5187 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5188 fill background (Bug#8992).
5189
454592a6
MR
51902011-12-13 Martin Rudalics <rudalics@gmx.at>
5191
5192 * window.c (Vwindow_combination_resize)
5193 (Vwindow_combination_limit): Use t instead of non-nil in
5194 doc-strings.
61d4b438
MR
5195 (Vrecenter_redisplay): Add first sentence of doc-string on
5196 separate line.
53524d93 5197 (Frecenter): Fix doc-string typo.
454592a6 5198
3633e3aa
KH
51992011-12-11 Kenichi Handa <handa@m17n.org>
5200
5201 * coding.c (Funencodable_char_position): Pay attention to the
5202 buffer text relocation (Bug#9389).
5203
7b9d523a 52042011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5205
7b9d523a
JD
5206 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5207 gtk_init (Bug#10100).
5208
b73189c6
EZ
52092011-12-10 Eli Zaretskii <eliz@gnu.org>
5210
5211 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5212 IT->string is nil. (Bug#10263)
5213
f7dfe5d6
JD
52142011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5215
83faebb4
JD
5216 * nsterm.h (x_free_frame_resources): Declare.
5217
f7dfe5d6
JD
5218 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5219 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5220
5221 * nsterm.h (ns_get_defaults_value): Declare.
5222
5223 * nsterm.m (ns_default): Call ns_get_defaults_value.
5224
7cd4e72c
EZ
52252011-12-09 Eli Zaretskii <eliz@gnu.org>
5226
5227 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5228 (Bug#10170)
5229
b34d7317
YM
52302011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5231
5232 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5233 that where the value of an _OBJC_* symbol points to is in the .bss
5234 section (Bug#10240).
5235
76470ad1
KH
52362011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5237
5238 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5239 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5240
745fff94
KH
52412011-12-08 Kenichi Handa <handa@m17n.org>
5242
5243 * ftfont.c (get_adstyle_property): Fix previous change
5244 (Bug#10233).
5245
6e44397c
JB
52462011-12-07 Juanma Barranquero <lekktu@gmail.com>
5247
5248 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5249 dirs from the default value of EMACSLOADPATH (bug#10208).
5250
7efa6272
GM
52512011-12-07 Glenn Morris <rgm@gnu.org>
5252
5253 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5254 installation and source directories as well. (Bug#10208)
5255
f6fc4d87
CY
52562011-12-06 Chong Yidong <cyd@gnu.org>
5257
5258 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5259
2bf26180
GM
52602011-12-06 Glenn Morris <rgm@gnu.org>
5261
5262 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5263 as an error, not just -1. (Bug#10217)
5264
3a6ad4f0
CY
52652011-12-05 Chong Yidong <cyd@gnu.org>
5266
5267 * keyboard.c (process_special_events): New function.
5268 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5269
75a3b399
PE
52702011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5271
5272 * coding.c (encode_designation_at_bol): Don't use uninitialized
5273 local variable (Bug#9318).
5274
c3c9e25e
KH
52752011-12-05 Kenichi Handa <handa@m17n.org>
5276
5277 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5278 return Qnil (Bug#8046, Bug#10193).
5279
5eb05ea3
KH
52802011-12-05 Kenichi Handa <handa@m17n.org>
5281
5282 * coding.c (encode_designation_at_bol): New args charbuf_end and
5283 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5284 (coding_set_source): Return how many bytes coding->source was
5285 relocated.
5286 (coding_set_destination): Return how many bytes
5287 coding->destination was relocated.
5288 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5289 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5290
52912011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5292
5293 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5294 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5295 macro (Bug#9318).
5296
52972011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5298
5299 The following changes are to fix Bug#9318.
5300
a79703f5 5301 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5302 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5303 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5304 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5305
7dbda6df
JB
53062011-12-05 Juanma Barranquero <lekktu@gmail.com>
5307
5308 * lisp.h (process_quit_flag): Fix external declaration.
5309
6d5eb5b0
SM
53102011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5311
5312 Don't macro-inline non-performance-critical code.
5313 * eval.c (process_quit_flag): New function.
5314 * lisp.h (QUIT): Use it.
5315
a0c3fad0
JD
53162011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5317
5318 * nsfns.m (get_geometry_from_preferences): New function.
5319 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5320
6c07aac2
AS
53212011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5322
5323 * emacs.c (Qkill_emacs): Define.
5324 (syms_of_emacs): Initialize it.
5325 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5326 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5327 (quit_throw_to_read_char): Add parameter `from_signal'.
5328 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5329 * lisp.h (QUIT): Call Fkill_emacs if requested.
5330
c052ead4
JD
53312011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5332
5333 * widget.c (update_wm_hints): Return if wmshell is null.
5334 (widget_update_wm_size_hints): New function.
5335
5336 * widget.h (widget_update_wm_size_hints): Declare.
5337
5338 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5339 widget_update_wm_size_hints (Bug#10104).
5340
9e49252b
EZ
53412011-12-03 Eli Zaretskii <eliz@gnu.org>
5342
5343 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5344 before a newline, prepare the bidi iterator for consuming the
5345 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5346 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5347
02b16839
JL
53482011-12-02 Juri Linkov <juri@jurta.org>
5349
5350 * search.c (Fword_search_regexp): New Lisp function created from
5351 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5352 (Fword_search_backward, Fword_search_forward)
5353 (Fword_search_backward_lax, Fword_search_forward_lax):
5354 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5355 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5356
0068070e
SM
53572011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5358
5359 * fileio.c (Finsert_file_contents): Move after-change-function call
5360 to before the "handled:" label, since all "goto handled" appear in
5361 cases where the *-change-functions have already been properly called
5362 (bug#10117).
5363
3360a3fc
AS
53642011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5365
5366 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5367 waiting for input. (Bug#10169)
5368
73d6c093
EZ
53692011-11-30 Eli Zaretskii <eliz@gnu.org>
5370
5371 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5372 verifies glyph row's hash code--we have just reallocated the
5373 glyphs, so their contents can be complete garbage. (Bug#10164)
5374
febe6bea
JB
53752011-11-30 Juanma Barranquero <lekktu@gmail.com>
5376
5377 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5378
801a4313
EZ
53792011-11-30 Eli Zaretskii <eliz@gnu.org>
5380
5381 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5382 attributes are tested _before_ calling verify_row_hash, to protect
5383 against GCC re-ordering of the tests. (Bug#10164)
5384
2b56b87e
JD
53852011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5386
5387 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5388
5389 * xterm.c (handle_one_xevent): Only set async_visible and friends
5390 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5391 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5392 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5393
dbf31225
PE
53942011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5395
5396 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5397 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5398 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5399 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5400 All uses changed to use GCPRO1 etc.
5401 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5402 Revert to old implementation (i.e., before 2011-03-11).
5403
1305621b
YM
54042011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5405
5406 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5407 of scroll runs so as to avoid assigning disabled bogus rows and
5408 unnecessary graphics copy operations.
5409
8c9afb46
EZ
54102011-11-27 Eli Zaretskii <eliz@gnu.org>
5411
5412 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5413 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5414 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5415 (malloc, free, realloc, calloc): Redirect to e_* only when
5416 compiling Emacs.
5417
5418 * lisp.h (GCTYPEBITS): Move before first use.
5419 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5420 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5421 this macro definition.
5422
5423 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5424 _MSC_VER.
5425
54e9e3bf
JD
54262011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5427
6d5eb5b0
SM
5428 * gtkutil.c (xg_create_frame_widgets):
5429 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5430 present with Gtk+ 2.0.
5431
83aca1cb
PE
54322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5433
5434 * fileio.c (Finsert_file_contents): Undo previous change; see
5435 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5436
5b76caa4
PE
54372011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5438
5439 Rename locals to avoid shadowing.
5440 * fileio.c (Finsert_file_contents):
5441 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5442 * process.c (wait_reading_process_output):
5443 Rename inner 'proc' to 'p' to avoid shadowing.
5444 Indent for consistency with usual Emacs style.
5445
8c535114
EZ
54462011-11-25 Eli Zaretskii <eliz@gnu.org>
5447
5448 * xdisp.c (redisplay_window): If cursor row is not fully visible
5449 after recentering, and scroll-conservatively is set to a large
5450 number, scroll window by a few more lines to make the cursor fully
5451 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5452 (start_display): Don't move to the next line if the display should
5453 start at a newline that is part of a display vector or an overlay
5454 string. (Bug#10119)
8c535114 5455
fa4fdb5c
JL
54562011-11-24 Juri Linkov <juri@jurta.org>
5457
5458 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5459 after the `MagickPingImage' call. (Bug#10112)
5460
90ec88df
CY
54612011-11-23 Chong Yidong <cyd@gnu.org>
5462
5463 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5464
56e2e794
MR
54652011-11-23 Martin Rudalics <rudalics@gmx.at>
5466
5467 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5468 making another buffer current. (Bug#10114)
5469
b6e64c41
GM
54702011-11-23 Glenn Morris <rgm@gnu.org>
5471
5472 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5473
6b21de18
CY
54742011-11-23 Chong Yidong <cyd@gnu.org>
5475
5476 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5477 using it (Bug#5984).
5478
b12cd789
EZ
54792011-11-22 Eli Zaretskii <eliz@gnu.org>
5480
5481 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5482 and header-lines, as they don't have one computed for them.
5483 (Bug#10098)
5484
5485 * .gdbinit (prow): Make displayed values more self-explaining.
5486 Add row's hash code.
5487
261b6fd4
LMI
54882011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5489
5490 * process.c (wait_reading_process_output): Fix asynchrounous
5491 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5492 (wait_reading_process_output): Add comment and URL.
261b6fd4 5493
e7cfd277
JD
54942011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5495
5496 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5497
a9b9b7f5
CY
54982011-11-21 Chong Yidong <cyd@gnu.org>
5499
5500 * window.c (Fnext_window, Fprevious_window): Doc fix.
5501
b0d15b4f
SM
55022011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5503
5504 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5505
fe7a3057
JB
55062011-11-20 Juanma Barranquero <lekktu@gmail.com>
5507
5508 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5509
d2999b1a
MR
55102011-11-20 Martin Rudalics <rudalics@gmx.at>
5511
5512 * window.c (Fset_window_combination_limit): Rename argument
5513 STATUS to LIMIT.
5514 (Vwindow_combination_limit): Remove "status" from doc-string.
5515
d5ff9cd0
AS
55162011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5517
5518 * m/ibms390.h: Remove.
5519 * m/ibms390x.h: Don't include "ibms390.h".
5520
a5bb9bd3
SM
55212011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5522
5523 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5524 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5525
cd1181db
JB
55262011-11-20 Juanma Barranquero <lekktu@gmail.com>
5527
5528 * casetab.c (Fset_case_table):
5529 * charset.c (Fcharset_after): Fix typos.
5530
615a3b8d 55312011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5532
17e845af
PE
5533 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5534 Otherwise, valgrind does not work on some platforms.
5535 Problem reported by Andreas Schwab in
6a0bf43d
PE
5536 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5537 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5538 is set, removing the need for VIRT_ADDRESS_VARIES.
5539 (PURE_P): Use a more-efficient implementation that needs just one
5540 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5541 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5542 to 4 (xorl, subq, cmpq, setbe).
5543 * alloc.c (pure): Always extern now, since that's the
5544 VIRT_ADDR_VARIES behavior.
5545 (PURE_POINTER_P): Use a single comparison, not two, for
5546 consistency with the new puresize.h.
5547 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5548 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5549 Remove VIRT_ADDR_VARIES no longer needed.
5550
f8fe6f96
EZ
55512011-11-19 Eli Zaretskii <eliz@gnu.org>
5552
5553 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5554 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5555 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5556 behave as if the cursor position were at the window margin.
5557
5558 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5559 and the cursor position is out of bounds, behave as if the cursor
5560 position were at the window margin. (Bug#10075)
5561
df05a53c
CY
55622011-11-18 Chong Yidong <cyd@gnu.org>
5563
5564 * window.c (Fwindow_combination_limit): Make first argument
5565 non-optional, since it is meaningless for live windows like the
5566 selected window.
61ccba97 5567
2071918e
DA
55682011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5569
5570 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5571
b50a28de
SM
55722011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5573
5574 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5575 (graft_intervals_into_buffer): Simplify.
5576
015137db
EZ
55772011-11-18 Eli Zaretskii <eliz@gnu.org>
5578
5579 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5580 hash values of the two rows.
5581 (copy_row_except_pointers): Preserve the used[] arrays and the
5582 hash values of the two rows. (Bug#10035)
68c95424 5583 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5584
5585 * xdisp.c (row_hash): New function, body extracted from
5586 compute_line_metrics.
5587 (compute_line_metrics): Call row_hash, instead of computing the
5588 hash code inline.
5589
5590 * dispnew.c (verify_row_hash): Call row_hash for computing the
5591 hash code of a row, instead of duplicating code from xdisp.c.
5592
5593 * dispextern.h (row_hash): Add prototype.
5594
a2addb04
TH
55952011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5596
5597 * frame.c (delete_frame): Don't delete the terminal when the last
5598 X frame is closed if emacs is built with GTK toolkit.
5599
df85d315
JB
56002011-11-17 Juanma Barranquero <lekktu@gmail.com>
5601
5602 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5603
a0c2d0ae
MR
56042011-11-17 Martin Rudalics <rudalics@gmx.at>
5605
5606 * window.c (Vwindow_splits): Rename to
5607 Vwindow_combination_resize. Suggested by Juri Linkov.
5608 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5609 of Vwindow_splits.
5610
58179cce
JB
56112011-11-16 Juanma Barranquero <lekktu@gmail.com>
5612
7877f373
JB
5613 * nsfns.m (Fns_font_name):
5614 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5615
b6f67890
MR
56162011-11-16 Martin Rudalics <rudalics@gmx.at>
5617
5618 * window.h (window): Rename slot "nest" to "combination_limit".
5619 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5620 (Fset_window_nest): Rename to Fset_window_combination_limit.
5621 (Vwindow_nest): Rename to Vwindow_combination_limit.
5622 (recombine_windows, make_parent_window, make_window)
5623 (Fsplit_window_internal, saved_window)
5624 (Fset_window_configuration, save_window_save): Rename all
5625 occurrences of window_nest to window_combination_limit.
5626
c7015153
JB
56272011-11-15 Juanma Barranquero <lekktu@gmail.com>
5628
5629 * image.c (imagemagick_load_image): Fix typo.
5630
322ad6ec
EZ
56312011-11-14 Eli Zaretskii <eliz@gnu.org>
5632
5633 * xdisp.c (display_line): Move the call to
5634 highlight_trailing_whitespace before the call to
5635 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5636 faces of all the glyphs to compute ROW's hash value.
5637 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5638
f067b8ec
JB
56392011-11-14 Juanma Barranquero <lekktu@gmail.com>
5640
5641 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5642 just return (bug#10044).
5643
1e5b2111
EZ
56442011-11-12 Eli Zaretskii <eliz@gnu.org>
5645
7ef3cbd5
EZ
5646 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5647 with user-defined heap size. Bump the default size of the temacs
5648 heap to 27MB, to avoid memory warning when running temacs.
5649 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5650
1e5b2111
EZ
5651 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5652 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5653 (verify_row_hash) [XASSERTS]: New function.
5654 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5655 that the hash value of glyph rows is correct.
1e5b2111 5656
89d61221
MR
56572011-11-12 Martin Rudalics <rudalics@gmx.at>
5658
5659 * window.h (window): Remove splits slot.
5660 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5661 (Fdelete_other_windows_internal, make_parent_window)
5662 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5663 (Fset_window_configuration, save_window_save): Don't deal with
5664 split status of windows.
5665 (saved_window): Remove splits slot.
5666 (Vwindow_splits): Rewrite doc-string.
5667
97f18cc8
JD
56682011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5669
5670 * xfns.c (unwind_create_frame):
5671 * nsfns.m (unwind_create_frame):
5672 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5673 Vframe_list (Bug#9999).
5674
22a648b4
DA
56752011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5676
0b381c7e 5677 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5678
659afede
KH
56792011-11-11 Kenichi Handa <handa@m17n.org>
5680
5681 * callproc.c (Fcall_process): Set the member dst_multibyte of
5682 process_coding.
5683
9ac0394b
KH
56842011-11-11 Johan Bockgård <bojohan@gnu.org>
5685
5686 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5687 avoid a crash (bug#9496).
5688
2fbdc249
CY
56892011-11-09 Chong Yidong <cyd@gnu.org>
5690
5691 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5692 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5693
ac6b1f81
PE
56942011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5695
5696 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5697
09db192c
PE
56982011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5699
5700 Avoid some portability problems by eschewing 'extern inline' functions.
5701 The trivial performance wins aren't worth the portability hassles; see
5702 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5703 et seq.
5704 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5705 (window_box_width, window_box_left, window_box_left_offset)
5706 (window_box_right, window_box_right_offset): Undo previous change,
5707 by removing the "extern"s.
5708 * intervals.c (adjust_intervals_for_insertion)
5709 (adjust_intervals_for_deletion): Undo previous change,
5710 making these static again.
5711 (offset_intervals, temp_set_point_both, temp_set_point)
5712 (copy_intervals_to_string): No longer inline.
5713 * xdisp.c (window_text_bottom_y, window_box_width)
5714 (window_box_height, window_box_left_offset)
5715 (window_box_right_offset, window_box_left, window_box_right)
5716 (window_box): No longer inline.
5717
105216ed
CY
57182011-11-08 Chong Yidong <cyd@gnu.org>
5719
5720 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5721 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5722 Signal an error if not a live window.
105216ed
CY
5723 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5724 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5725
ae9e237f
JB
57262011-11-07 Juanma Barranquero <lekktu@gmail.com>
5727
5728 * lisp.h (syms_of_abbrev): Remove declaration.
5729 Reported by CHENG Gao <chenggao@royau.me>.
5730
c7aa8333
EZ
57312011-11-07 Eli Zaretskii <eliz@gnu.org>
5732
5733 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5734 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5735 of temacs in GUI mode.
5736
be7f5545
MR
57372011-11-07 Martin Rudalics <rudalics@gmx.at>
5738
5739 * window.h: Declare delete_all_child_windows instead of
5740 delete_all_subwindows.
5741 * window.c (Fwindow_nest, Fset_window_nest)
5742 (Fset_window_new_total, Fset_window_new_normal)
5743 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5744 (delete_all_subwindows): Rename to delete_all_child_windows.
5745 (Fdelete_other_windows_internal, Fset_window_configuration):
5746 Call delete_all_child_windows instead of delete_all_subwindows.
5747 * frame.c (delete_frame): Call delete_all_child_windows instead
5748 of delete_all_subwindows.
5749
ca78dc43
PE
57502011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5751
5752 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5753 This is also needed for porting to any host where GC_MARK_STACK is
5754 not GC_MAKE_GCPROS_NOOPS.
5755 (which_symbols): Use it.
5756
a0241d01
KH
57572011-11-07 Kenichi Handa <handa@m17n.org>
5758
5759 * coding.c (coding_set_destination): Check coding->src_pos only
5760 when coding->src_object is a buffer (bug#9910).
5761
5762 * process.c (send_process): Set the member src_multibyte of coding
5763 to 0 (bug#9911) when sending a unibyte text.
5764
5765 * callproc.c (Fcall_process): Set the member src_multibyte of
5766 process_coding to 0 (bug#9912).
5767
a64bfdfa 57682011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5769
5770 * xmenu.c (cleanup_widget_value_tree): New function.
5771 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5772 calling free_menubar_widget_value_tree directly (Bug#9830).
5773
cb41b32a
PE
57742011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5775
5776 Fix some portability problems with 'inline'.
5777 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5778 (window_box_width, window_box_left, window_box_left_offset)
5779 (window_box_right, window_box_right_offset): Declare extern.
5780 Otherwise, these inline functions do not conform to C99 and
5781 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5782 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5783 * intervals.c (adjust_intervals_for_insertion)
5784 (adjust_intervals_for_deletion): Now extern, because otherwise the
5785 extern inline functions 'offset_intervals' couldn't refer to it.
5786 (static_offset_intervals): Remove.
5787 (offset_intervals): Rewrite using the old contents of
5788 static_offset_intervals. The old version didn't conform to C99
5789 because an extern inline function contained a reference to an
5790 identifier with static linkage.
5791
b7041366
AS
57922011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5793
5794 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5795 GC.
5796
88a37c4d
EZ
57972011-11-06 Eli Zaretskii <eliz@gnu.org>
5798
5799 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5800 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5801 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5802 return Qleft_to_right.
5803
49745b39
CY
58042011-11-06 Chong Yidong <cyd@gnu.org>
5805
5806 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5807 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5808 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5809 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5810 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5811 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5812 (Fwindow_vscroll): Doc fix.
5813 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5814 argument, since it makes no sense to pass a live window and for
5815 consistency with window-child.
5816
1f05cd82
CS
58172011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5818
5819 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5820 support MSVC.
5821
22610910
JR
58222011-11-05 Jason Rumney <jasonr@gnu.org>
5823
5824 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5825 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5826 fonts (Bug#6029).
5827 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5828 bitwise arithmetic preventing use of unicode-sip and non-truetype
5829 opentype fonts.
5830
a06776b2
EZ
58312011-11-05 Eli Zaretskii <eliz@gnu.org>
5832
3ad924ba
EZ
5833 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5834 "emacs"-only part.
5835
a06776b2
EZ
5836 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5837 initialization code to keep similarity to xfns.c after changes
5838 from 2011-11-05.
5839
c9e7db78
JD
58402011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5841
a97f8f3f
JD
5842 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5843 (unwind_create_frame): New function (Bug#9943).
5844 (Fx_create_frame): Restructure code to be more similar to the one in
5845 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5846 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5847 Move terminal->reference_count++ just before making the frame official
5848 (Bug#9943).
5849
5850 * nsterm.m (x_free_frame_resources): New function.
5851 (x_destroy_window): Move code to x_free_frame_resources.
5852
c9e7db78 5853 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5854 (Fx_create_frame, x_create_tip_frame):
5855 Move terminal->reference_count++ just before making the frame
75f1671a 5856 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5857 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5858
a6fc3b5c
EZ
58592011-11-05 Eli Zaretskii <eliz@gnu.org>
5860
5861 Support MSVC build with newer versions of Visual Studio.
5862 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5863 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5864 nt/gmake.defs.
5865
5866 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5867 which are not supported by MSVC.
5868 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5869 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5870 bitfields.
5871 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5872 types in bitfields.
5873 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5874
5875 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5876
58179cce 58772011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5878
5879 Support MSVC build with newer versions of Visual Studio.
5880 * w32.c: Don't include w32api.h for MSVC.
5881 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5882
5883 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5884 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5885 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5886 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5887 e_* cousins.
5888 (alloca) [_MSC_VER]: Define to _alloca.
5889
5890 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5891
5892 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5893
a58c13ed
EZ
58942011-11-04 Eli Zaretskii <eliz@gnu.org>
5895
5896 * xdisp.c (note_mouse_highlight): If either of
5897 previous/next-single-property-change returns nil, treat that as
5898 the beginning or the end of the buffer. (Bug#9955)
5899
fe0b6370
JD
59002011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5901
a58c13ed 5902 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5903 label is not null (Bug#9951).
5904 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5905 may be NULL.
5906
89bd5ee1
EZ
59072011-11-04 Eli Zaretskii <eliz@gnu.org>
5908
5909 * window.c (Fwindow_body_size): Mention in the doc string that the
5910 return value is in frame's canonical units. (Bug#9949)
5911
84c3edb9
EZ
59122011-11-03 Eli Zaretskii <eliz@gnu.org>
5913
4e2fb5c7
EZ
5914 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5915
84c3edb9 5916 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5917 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5918 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5919
bc17a887
EZ
59202011-11-01 Eli Zaretskii <eliz@gnu.org>
5921
5922 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5923 Don't stop backward scan on the continuation glyph, even though
5924 its CHARPOS is positive.
6d5eb5b0
SM
5925 (mouse_face_from_buffer_pos, note_mouse_highlight):
5926 Rename cover_string to disp_string.
bc17a887 5927
4ee88440
MR
59282011-11-01 Martin Rudalics <rudalics@gmx.at>
5929
5930 * window.c (temp_output_buffer_show): Don't use
5931 Vtemp_buffer_show_specifiers.
5932 (Vtemp_buffer_show_specifiers): Remove unused variable.
5933
c2ff3c02
EZ
59342011-10-30 Eli Zaretskii <eliz@gnu.org>
5935
5936 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5937 past the beginning of the current glyph matrix.
5938
58179cce 59392011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5940
5941 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5942 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5943 HAVE_GTK3 (Bug#9869).
b77a6a7f 5944
3b574623
JD
5945 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5946 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5947
b77a6a7f
JD
5948 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5949
5950 * xterm.c: Declare x_handle_net_wm_state to return int.
5951 (handle_one_xevent): Check if we are iconified but don't have
5952 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5953 (get_current_wm_state): Return non-zero if not hidden,
5954 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5955 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5956 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5957 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5958
196e41e4
PE
59592011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5960
5961 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5962 so that this new function doesn't get optimized away by a
5963 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5964
021f2e1a
AS
59652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5966
5967 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5968
8b058d44
EZ
59692011-10-29 Eli Zaretskii <eliz@gnu.org>
5970
5971 Fix the `xbytecode' command.
5972 * .gdbinit (xprintbytestr): New command.
b50a28de 5973 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5974 (xbytecode): Print the byte-code string as well.
5975
4452fb80
EZ
59762011-10-29 Kim Storm <storm@cua.dk>
5977
8b058d44
EZ
5978 * alloc.c (which_symbols): New function.
5979
21b72067
AS
59802011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5981
5982 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5983 line. (Bug#9903)
5984
83ed7b5c
GM
59852011-10-29 Glenn Morris <rgm@gnu.org>
5986
5987 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5988 Not clear what it was for, and it causes various bugs. (Bug#9839)
5989
5a7a728b
EZ
59902011-10-28 Eli Zaretskii <eliz@gnu.org>
5991
5992 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5993 possible random value that matches one of those tested as
5994 condition to clear the mouse face.
5995
d3d0842f
CY
59962011-10-28 Chong Yidong <cyd@gnu.org>
5997
5998 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5999
31b39d13
DN
60002011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6001
6002 * window.c (make_window): Initialize phys_cursor_on_p.
6003
9aba6043
SM
60042011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6005
6006 * lisp.h (struct Lisp_Symbol): Update comments.
6007
c20992f4
JB
60082011-10-28 Juanma Barranquero <lekktu@gmail.com>
6009
6010 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6011
db4f02f2
EZ
60122011-10-28 Eli Zaretskii <eliz@gnu.org>
6013
6014 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6015 <oslsachem@gmail.com> for helping to debug this.
6016
6017 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6018 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6019 (g_b_init_get_glyph_outline_w): New static variables.
6020 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6021 (GetGlyphOutlineW_Proc): New typedefs.
6022 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6023 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6024 New functions.
6025 (w32font_open_internal, compute_metrics):
6026 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6027 instead of calling the "wide" APIs directly.
6028
6029 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6030
6031 * w32.h (syms_of_w32font): Add prototype.
6032
87e68db4
JB
60332011-10-27 Juanma Barranquero <lekktu@gmail.com>
6034
6035 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6036 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6037 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6038 (Fmove_to_window_line): Doc fix.
6039
435c1d67
CY
60402011-10-27 Chong Yidong <cyd@gnu.org>
6041
6042 * process.c (make_process): Set gnutls_state to NULL.
6043
6044 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6045 non-NULL, regardless of GNUTLS_INITSTAGE.
6046 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6047 an error. Set process slots as soon as we allocate them.
6048
6049 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6050
9c6c6f49
CY
60512011-10-27 Chong Yidong <cyd@gnu.org>
6052
9aba6043
SM
6053 * gnutls.c (emacs_gnutls_deinit): New function.
6054 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6055 (Fgnutls_deinit, Fgnutls_boot): Use it.
6056
6057 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6058 (deactivate_process): Call emacs_gnutls_deinit.
6059
657d08d3
JB
60602011-10-27 Juanma Barranquero <lekktu@gmail.com>
6061
6062 * image.c (x_create_x_image_and_pixmap):
6063 * w32.c (sys_rename, w32_delayed_load):
6064 * w32font.c (fill_in_logfont):
6065 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6066
5430d399
JB
60672011-10-26 Juanma Barranquero <lekktu@gmail.com>
6068
6069 * w32fns.c (w32_default_color_map): New function,
6070 extracted from Fw32_default_color_map.
a7ef684b 6071 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6072
fe0055fa
PE
60732011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6074
6075 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6076
e6346438
SM
60772011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6078
6079 * keyboard.c (test_undefined): New function (bug#9751).
6080 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6081
e112cc37
ET
60822011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6083
6084 * sysdep.c (init_sys_modes): Fix the check for the controlling
6085 terminal (Bug#6649).
6086
7b5d6677
EZ
60872011-10-20 Eli Zaretskii <eliz@gnu.org>
6088
6089 * dispextern.h (struct bidi_it): New member next_en_type.
6090
6091 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6092 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6093 current character, check also for next_en_type being WEAK_EN.
6094 (bidi_resolve_weak): Don't enter the expensive loop if the current
6095 position is before next_en_pos. Record the bidi type of the first
6096 non-ET, non-BN character we find, in addition to its position.
6097 (bidi_level_of_next_char): Invalidate next_en_type when
6098 next_en_pos is over-stepped.
6099
7da0b018
PE
61002011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6101
6102 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6103 * editfns.c: Rewrite current-time-zone so that it invokes
6104 the equivalent of (format-time-string "%Z") to get the time zone name.
6105 This fixes a bug when the time zone name contains characters that
6106 need converting from the system time locale to Emacs internal format.
6107 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6108 that patch fixed format-time-string to do the conversion, but
6109 I forgot to fix current-time-zone.
6110 (format_time_string): New function, containing most of
6111 what Fformat_time_string used to contain.
6112 (Fformat_time_string): Rewrite in terms of format_time_string.
6113 This doesn't change this function's behavior.
6114 (current-time-zone): Rewrite to use format_time_string.
6115 This fixes the bug reported by Michael Schierl in
6116 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6117 Jason Rumney's 2007-06-07 change worked around this bug, but
6118 didn't fix it.
6119 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6120
8547b010
EZ
61212011-10-19 Eli Zaretskii <eliz@gnu.org>
6122
6123 * xdisp.c (start_display): If the character at POS is displayed
6124 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6125 (try_window_reusing_current_matrix): If a line ends in a display
6126 vector or the next line starts in a display vector, continue
6127 redrawing the window even though the character position of
6128 start_row was reached.
8547b010
EZ
6129 (Bug#9771, part 2)
6130
4e948d15
CY
61312011-10-18 Chong Yidong <cyd@gnu.org>
6132
6133 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6134 with nobreak-char-display too.
6135
4787455f
EZ
61362011-10-18 Eli Zaretskii <eliz@gnu.org>
6137
6138 Fix part 3 of bug#9771.
6139 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6140 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6141 non-neutral characters if the current character is a paragraph
6142 separator (a.k.a. Newline). This avoids running the same
6143 expensive loop twice, once when we consume the preceding newline
6144 and the other time when the line actually needs to be displayed.
6145 Avoid the loop when we see neutrals on the base embedding level
6146 following a character whose directionality is the same as the
6147 paragraph's. This avoids running the expensive loop when a line
6148 ends in a long sequence of neutrals, like control characters.
6149 Add assertion against STRONG_AL type. Slightly rearrange code
6150 that determines the type of a neutral given the first non-neutral
6151 that follows it.
6152 (bidi_level_of_next_char): Set next_en_pos to zero when
6153 invalidating its info.
6154
2c91f553
EZ
61552011-10-17 Eli Zaretskii <eliz@gnu.org>
6156
6157 * xdisp.c (push_display_prop): Determine whether to record string
6158 or buffer position by IT->string, not by IT->method. Allow
6159 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6160 (move_it_vertically_backward): Don't look for character position
6161 immediately after the newline when in a continuation line.
6162 (Bug#9771, part 1)
2c91f553 6163
c7b08b0d
MR
61642011-10-15 Martin Rudalics <rudalics@gmx.at>
6165
6166 * window.c (coordinates_in_window): Rewrite and delabelize
6167 vertical border check. (Bug#5357) (Bug#9618)
6168
6b02f655
SM
61692011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6170
6171 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6172 errors in XSetWindowBorder (bug#9310).
6173
81d40c92
DA
61742011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6175
6176 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6177 avoid crash when xmalloc overrun checking is enabled.
6178
d4172c3b
EZ
61792011-10-13 Eli Zaretskii <eliz@gnu.org>
6180
6181 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6182 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6183 cursor motion with <left> and <right> arrow keys.
6184
6185 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6186 some callers set that themselves.
6187
b00eea75
EZ
61882011-10-12 Eli Zaretskii <eliz@gnu.org>
6189
6190 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6191 display string and the previous row comes from the same string and
6192 is empty. (Bug#9739) (Bug#9738)
6193
8fe012c4
SM
61942011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6195
6196 * doc.c (get_doc_string): Encode file name (bug#9735).
6197
0074aef2
EZ
61982011-10-12 Eli Zaretskii <eliz@gnu.org>
6199
79beb178
EZ
6200 * bidi.c (bidi_level_of_next_char):
6201 * xdisp.c (get_visually_first_element): Remove old incorrect
6202 comments regarding the Unicode Line Separator character.
6203
0074aef2
EZ
6204 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6205
6e4b3fbe
DA
62062011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6207
6208 * alloc.c (Fgc_status): Do not access beyond zombies array
6209 boundary if nzombies > MAX_ZOMBIES.
6210 * alloc.c (dump_zombies): Add missing format specifier.
6211
0324f3af
PE
62122011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6213
b5525cac
PE
6214 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6215 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6216
0324f3af
PE
6217 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6218 Some packages use them to denote characters with modifiers.
6219
e9b5f888
AS
62202011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6221
6222 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6223 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6224 matching a pp-number. Rename parameter var to var1.
6225
127827c0
SM
62262011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6227
6228 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6229
c8fd3bd0
GM
62302011-10-08 Glenn Morris <rgm@gnu.org>
6231
6232 * callint.c (Fcall_interactively): Give a more explicit error for the
6233 'c' case with a non-character input. (Bug#8479)
6234
352ec8ff
EZ
62352011-10-08 Eli Zaretskii <eliz@gnu.org>
6236
03669ccb
EZ
6237 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6238 lines.
7061c986
EZ
6239 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6240 lines that are hscrolled on the left.
03669ccb 6241
352ec8ff
EZ
6242 * dispnew.c (buffer_posn_from_coords): Account for a possible
6243 presence of header-line. (Bug#4426)
6244
a66cfb1c
SM
62452011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6246
6b02f655
SM
6247 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6248 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6249
7c5ee88e
PE
62502011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6251
6252 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6253 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6254 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6255 this makes Emacs dump core during garbage collection on rare
6256 occasions. sizeof is obviously inferior to offsetof here, so
6257 stick with offsetof.
6258 (GC_POINTER_ALIGNMENT): New macro.
6259 (mark_memory): Omit 3rd (offset) arg; caller changed.
6260 Don't assume EMACS_INT alignment is the same as pointer alignment.
6261
df1bbe5b
SM
62622011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6263
6264 * keyboard.c (read_key_sequence_remapped): New var.
6265 (read_key_sequence): Compute remapping in the right buffer.
6266 (command_loop_1): Use read_key_sequence's remapping directly.
6267
51553db6
SM
62682011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6269
32c1fffd
SM
6270 * dired.c (file_name_completion): Don't expand file name.
6271 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6272 before checking file name handler.
6273
51553db6
SM
6274 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6275 they've been requested explicitly (bug#9591).
6276
b6bd1599 62772011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6278
6279 * keymap.c (Fsingle_key_description): Use make_specified_string
6280 instead of build_string to build string from push_key_description.
6281 (Bug#5193)
6282
f701dc2a
PE
62832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6284
4222c55d
PE
6285 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6286 This fixes a Y2038 bug on 64-bit hosts.
6287 * buffer.c (reset_buffer):
6288 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6289 (Fclear_buffer_auto_save_failure):
6290 Use 0, not -1, to represent an unset failure time, since time_t
6291 might not be signed.
6292
f701dc2a
PE
6293 Remove dependency on glibc malloc internals.
6294 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6295 Move back here from lisp.h, but with their new implementations.
6296 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6297 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6298 * charset.c (charset_table_init): New static var.
6299 (syms_of_charset): Use it instead of xmalloc. This removes a
6300 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6301 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6302 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6303 Move back to alloc.c.
6304 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6305 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6306
9ceebf39
JD
63072011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6308
6309 * nsterm.m (windowDidResize): Call x_set_window_size only when
6310 ns_in_resize is true. Otherwise set pixelwidth/height and
6311 call change_frame_size (Bug#9628).
6312
cb993c58
PE
63132011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6314
3930c88b
PE
6315 Port --enable-checking=all to Fedora 14 x86-64.
6316 * charset.c (syms_of_charset): Also account for glibc malloc's
6317 internal overhead when calculating the initial malloc maximum.
6318
cb993c58
PE
6319 Port --enable-checking=all to Fedora 14 x86.
6320 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6321 Move to lisp.h.
6322 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6323 (overrun_check_realloc, overrun_check_free):
6324 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6325 That way, xmalloc returns a properly-aligned pointer even if
6326 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6327 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6328 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6329 into account when calculating the initial malloc maximum.
6330 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6331 Move here from alloc.c, so that charset.c can use it too.
6332 Properly align; the old code wasn't right for common 32-bit hosts
6333 when configured with --enable-checking=all.
6334 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6335 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6336
31bed486
EZ
63372011-09-29 Eli Zaretskii <eliz@gnu.org>
6338
04c70788 6339 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6340 use EDOM.
6341
fbcaa2f3
EZ
63422011-09-28 Eli Zaretskii <eliz@gnu.org>
6343
6344 * xdisp.c (compute_display_string_end): If there's no display
6345 string at CHARPOS, return -1.
6346
6347 * bidi.c (bidi_fetch_char): When compute_display_string_end
6348 returns a negative value, treat the character as a normal
6349 character not covered by a display string. (Bug#9624)
6350
a239d4e9
JB
63512011-09-28 Juanma Barranquero <lekktu@gmail.com>
6352
6353 * lread.c (Fread_from_string): Fix typo in docstring.
6354
88652fd5
EZ
63552011-09-27 Eli Zaretskii <eliz@gnu.org>
6356
6357 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6358 newline, reseat the iterator instead of bidi-iterating there one
6359 character at a time. (Bug#9610)
32c1fffd
SM
6360 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6361 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6362
ed497dd4
AS
63632011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6364
6365 * lread.c (readevalloop): Use correct code for NBSP.
6366 (read1): Likewise. (Bug#9608)
6367
b2bf61aa
MA
63682011-09-25 Michael Albinus <michael.albinus@gmx.de>
6369
6370 * dbusbind.c (Fdbus_register_signal): When service is not
6371 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6372
32bbb17c
GM
63732011-09-25 Glenn Morris <rgm@gnu.org>
6374
6375 * buffer.c (truncate-lines): Doc fix.
6376
94e0933e
CY
63772011-09-24 Chong Yidong <cyd@stupidchicken.com>
6378
6379 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6380 (Fset_window_next_buffers): Doc fix.
6381
cddde921
GM
63822011-09-24 Glenn Morris <rgm@gnu.org>
6383
6384 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6385
1260aef1
PE
63862011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6387
25b4bfa0
PE
6388 Fix minor problems found by static checking.
6389 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6390 * indent.c (Fvertical_motion): Fix == vs = typo.
6391
e3cbd34b
EZ
63922011-09-24 Eli Zaretskii <eliz@gnu.org>
6393
a66cfb1c
SM
6394 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6395 Default value is now t. Doc fix.
6bf7006f 6396
e3cbd34b 6397 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6398 logic when moving up, not only when moving down. Fix the
e3cbd34b 6399 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6400 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6401
6402 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6403 CHARPOS is covered by a display string which includes newlines.
6404 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6405 is covered by a display string with embedded newlines.
6406
a3de0cbd
MA
64072011-09-24 Michael Albinus <michael.albinus@gmx.de>
6408
6409 * dbusbind.c (Fdbus_register_signal): Add match rule to
6410 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6411 (Fdbus_register_method, Vdbus_registered_objects_table):
6412 Fix docstring.
a3de0cbd 6413
b260039d
JM
64142011-09-24 Jim Meyering <meyering@redhat.com>
6415
32c1fffd 6416 do not ignore write error for any output size
b260039d
JM
6417 The previous change was incomplete.
6418 While it makes emacs --batch detect the vast majority of stdout
6419 write failures, errors were still ignored whenever the output size is
6420 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6421 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6422 && echo FAIL: ignored write error
6423 FAIL: ignored write error
6424 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6425 && echo FAIL: ignored write error
6426 FAIL: ignored write error
6427 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6428
8eca8a7c
AS
64292011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6430
6431 * emacs.c (Fkill_emacs): In noninteractive mode exit
6432 non-successfully if a write error occurred on stdout. (Bug#9574)
6433
3341db62
EZ
64342011-09-21 Eli Zaretskii <eliz@gnu.org>
6435
6436 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6437 the xassert test.
6438
6439 * dispextern.h (struct it): Update the comment documenting what
6440 can it->OBJECT be.
6441
8c203dbf
EZ
64422011-09-20 Eli Zaretskii <eliz@gnu.org>
6443
6444 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6445 a display string, extend search for cursor position to end of row.
6446 (find_row_edges): If the row ends in a newline from a display
6447 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6448 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6449 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6450 non-empty line. Fixes confusing cursor motion with arrow keys at
6451 the beginning of a line that starts with whitespace.
8c203dbf 6452
a4824228
LMI
64532011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6454
6455 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6456 (bug#9493).
6457
33ed493b
CY
64582011-09-18 Chong Yidong <cyd@stupidchicken.com>
6459
6460 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6461 boolean (Bug#9154).
6462
56cd55c8
EZ
64632011-09-18 Eli Zaretskii <eliz@gnu.org>
6464
6465 * xdisp.c (display_line): Record maximum and minimum buffer
6466 positions even if no glyphs were produced (e.g., by a zero-width
6467 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6468 buffer positions that will be removed from the glyph row because
6469 they don't fit.
c02dcedf
EZ
6470 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6471 column is beyond frame width: don't subtract 1 "pixel" when
6472 computing width of the stretch.
3e62b7e0
EZ
6473 (reseat_at_next_visible_line_start): Undo the change made on
6474 2011-09-17 that saved paragraph information and restored it after
6475 the call to `reseat'. (Bug#9545)
56cd55c8 6476
5ed99d36 64772011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6478
6479 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6480 and turn window cursor on if cleared (Bug#9415).
6481
5ed99d36 64822011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6483
6484 * search.c (boyer_moore): Take unibyte characters from pattern
6485 literally. (Bug#9458)
6486
9bade7b2
EZ
64872011-09-18 Eli Zaretskii <eliz@gnu.org>
6488
6489 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6490
e5e9d610
PE
64912011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6492
87e4427a
PE
6493 Fix minor problem found by static checking.
6494 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6495 initialized, to pacify gcc -Wuninitialized.
6496
e5e9d610
PE
6497 * fileio.c: Report proper errno when syscall falls.
6498 (Finsert_file_contents): Save and restore errno,
6499 so that report_file_error outputs the correct diagnostic.
6500 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6501
a1674f0b
EZ
65022011-09-18 Eli Zaretskii <eliz@gnu.org>
6503
6504 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6505
fbfb6dd4
EZ
65062011-09-17 Eli Zaretskii <eliz@gnu.org>
6507
6508 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6509 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6510
bb187662
EZ
65112011-09-17 Eli Zaretskii <eliz@gnu.org>
6512
1137e8b8 6513 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6514 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6515
6516 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6517 (bidi_find_paragraph_start): Search back for paragraph beginning
6518 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6519 (bidi_move_to_visually_next): Only trigger paragraph-related
6520 computations when the last character is a newline or at EOB, not
6521 just any NEUTRAL_B. (Bug#9470)
6522
bb187662
EZ
6523 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6524 truncated lines if point is covered by a display string. (Bug#9524)
6525
2e621251
PE
65262011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6527
6528 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6529 (cons_to_x_long): New function.
6530 (lisp_data_to_selection_data): Use it. Correct the test for
6531 short-versus-long data; it was negated. Break out of vector
6532 loop, for efficiency, when a long datum is discovered.
6533
91a15bc6
SM
65342011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6535
6536 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6537
b41c3a35
EZ
65382011-09-16 Eli Zaretskii <eliz@gnu.org>
6539
6540 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6541 GCC PR/17406) by declaring this function with external scope.
6542
7812ba2d
PE
65432011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6544
6545 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6546 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6547
cf7edc2a
AS
65482011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6549
6550 * editfns.c (Fformat): Correctly handle text properties on "%%".
6551
bd01620e
EZ
65522011-09-15 Eli Zaretskii <eliz@gnu.org>
6553
6554 * xterm.c (x_draw_composite_glyph_string_foreground):
6555 * w32term.c (x_draw_composite_glyph_string_foreground):
6556 * term.c (encode_terminal_code):
6557 * composite.c (composition_update_it, get_composition_id):
6558 * xdisp.c (get_next_display_element)
6559 (fill_composite_glyph_string): Add comments about special meaning
6560 of TAB characters in a composition.
6561
a02719a3
PE
65622011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6563
6564 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6565 This occurs when processing a multibyte format.
6566 Problem reported by Wolfgang Jenker.
a02719a3 6567
72589a3c
JB
65682011-09-15 Johan Bockgård <bojohan@gnu.org>
6569
6570 * xdisp.c (try_cursor_movement): Only check for exact match if
6571 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6572
1c14176c
PE
65732011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6574
6575 Remove unused external symbols.
6576 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6577 * xdisp.c (calc_pixel_width_or_height): Now static.
6578 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6579 * indent.c (check_display_width):
6580 * w32term.c: Fix comment to match code.
6581 * xterm.c, xterm.h (x_catching_errors): Remove.
6582
d2eea5b5
PE
65832011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6584
6585 * xselect.c: Use signed conversions more consistently (Bug#9498).
6586 (selection_data_to_lisp_data): Assume incoming selection data are
6587 signed integers, not unsigned. This is to be consistent with
6588 outgoing selection data, which was modified to use signed integers
6589 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6590 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6591 expects long, not unsigned long.
6592
46888499
EZ
65932011-09-14 Eli Zaretskii <eliz@gnu.org>
6594
6595 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6596 computation of loop end. Reported by Johan Bockgård
6597 <bojohan@gnu.org>.
6598
ef8ef9fb
CY
65992011-09-13 Chong Yidong <cyd@stupidchicken.com>
6600
6601 * frame.c (Fother_visible_frames_p): Function deleted.
6602
fa819fed
EZ
66032011-09-12 Eli Zaretskii <eliz@gnu.org>
6604
6605 * indent.c (compute_motion): Process display vector front to back
6606 rather than the other way around. (Bug#2496)
6607
2ba8e008
SM
66082011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6609
6610 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6611
20f53c69
CY
66122011-09-11 Chong Yidong <cyd@stupidchicken.com>
6613
6614 * minibuf.c (Fread_from_minibuffer): Doc fix.
6615
d562d7a4
EZ
66162011-09-11 Eli Zaretskii <eliz@gnu.org>
6617
6618 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6619 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6620
1c4d7f3d
LMI
66212011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6622
6623 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6624 value for non-existent files.
6625
b885bf36
EZ
66262011-09-11 Eli Zaretskii <eliz@gnu.org>
6627
6628 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6629 set its "size" to -1. This will set the modtime_size field of
6630 the corresponding buffer to -1, which is what
6631 verify-visited-file-modtime expects for files that do not exist.
6632 (Bug#9139)
6633
6612f0bf
PE
66342011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6635
6636 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6637 here ...
6638 * lisp.h: ... from here. push_key_description is no longer
6639 defined in keyboard.c, so its declaration should not be in
6640 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6641 logically belongs with push_key_description.
6642
dfb3f755
PE
66432011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6644
6645 * buffer.h: Include <sys/types.h> instead of <time.h>.
6646 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6647 Problem reported by Herbert J. Skuhra.
6648
3134906c
LMI
66492011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6650
6651 * xml.c (parse_region): Make the parsing work for
6652 non-comment-starting XML files again (bug#9144).
6653
8d903f4e
AS
66542011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6655
6656 * image.c (gif_load): Fix calculation of bottom and right corner.
6657 (Bug#9468)
6658
80ad64f4
EZ
66592011-09-10 Eli Zaretskii <eliz@gnu.org>
6660
6661 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6662 redisplay in small windows.
6663
208a048d
EZ
66642011-09-09 Eli Zaretskii <eliz@gnu.org>
6665
6666 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6667
9b1c252e
MR
66682011-09-08 Martin Rudalics <rudalics@gmx.at>
6669
6670 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6671 Operate on live windows only.
6672
2949f33b
JB
66732011-09-08 Juanma Barranquero <lekktu@gmail.com>
6674
6675 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6676
e08dcafd
EZ
66772011-09-07 Eli Zaretskii <eliz@gnu.org>
6678
6679 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6680 only under bidi iteration.
6681
115b96bd
JD
66822011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6683
6684 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6685
c8199d0f
PE
66862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6687
6688 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6689 Without this fix, the command to link temacs failed due to an
6690 undefined symbol __builtin_isnan. This is because
6691 /usr/include/iso/math_c99.h #defines isnan(x) to
6692 __builtin_isnan(x), but the bundled gcc, which identifies itself
6693 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6694 a __builtin_isnan.
6695 * floatfns.c (isnan): #undef, and then #define to a clone of
6696 what's in data.c.
6697 (Fisnan): Always define, since it's always available now.
6698 (syms_of_floatfns): Always define isnan at the Lisp level.
6699
e39b275c 67002011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6701
6702 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6703
b2db44d9 67042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6705
f4af5137 6706 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6707 The previous code assumed that file offsets (off_t values) fit in
6708 EMACS_INT variables, which is not true on typical 32-bit hosts.
6709 The code messed up by falsely reporting buffer overflow in cases
6710 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6711 when "big" contains more than 2**29 bytes, even though this
6712 inserts just one byte and does not overflow the buffer.
6713 (Finsert_file_contents): Store file offsets as off_t
6714 values, not as EMACS_INT values. Check for overflow when
6715 converting between EMACS_INT and off_t. When checking for
6716 buffer overflow or for overlap, take the offsets into account.
6717 Don't use EMACS_INT for small values where int suffices.
6718 When checking for overlap, fix a typo: ZV was used where
6719 ZV_BYTE was intended.
6720 (Fwrite_region): Don't assume off_t fits into 'long'.
6721 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6722
ecfc0a49
MA
67232011-09-05 Michael Albinus <michael.albinus@gmx.de>
6724
6725 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6726
6511acf2 67272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6728
0999621a 6729 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6730
6731 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6732 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6733 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6734 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6735 (modify_event_symbol): Do not assume that the length of
6736 name_alist_or_stem is safe to alloca and fits in int.
6737 (Fexecute_extended_command): Likewise for function name and binding.
6738 (Frecursion_depth): Wrap around reliably on integer overflow.
6739 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6740 since some callers pass EMACS_INT values.
6741 (Fsingle_key_description): Don't crash if symbol name contains more
6742 than MAX_ALLOCA bytes.
6743 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6744 (get_minibuffer): Arg is now EMACS_INT, not int.
6745 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6746 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6747 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6748
2be7d702
PE
6749 * dbusbind.c (signature_cat): New function.
6750 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6751 Do not overrun buffer; instead, report string overflow.
6752
9d1df220
PE
6753 * dispnew.c (add_window_display_history): Don't overrun buffer.
6754 Truncate instead; this is OK since it's just a log.
6755
33ef5c64
PE
6756 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6757 even if the time zone offset is outlandishly large.
6758 Don't mishandle offset == INT_MIN.
6759
66c6fdd5
PE
6760 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6761 when creating daemon; the previous buffer-overflow check was incorrect.
6762
d749b01b
PE
6763 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6764 which has the guts of the old verror function.
6765
b5cd1905
PE
6766 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6767 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6768
6e1a67fb
PE
6769 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6770 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6771 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6772 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6773 length of string rather than counting it via multiple sprintfs;
6774 that's simpler and more reliable.
c21721cc
PE
6775 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6776 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6777 sprintf, in case result does not fit in int.
6778
c57b67fc
PE
6779 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6780 (fontset_from_font): Print it.
6781
8a401434
PE
6782 * frame.c (tty_frame_count): Now printmax_t, not int.
6783 (make_terminal_frame, set_term_frame_name): Print it.
6784 (x_report_frame_params): In X, window IDs are unsigned long,
6785 not signed long, so print them as unsigned.
6786 (validate_x_resource_name): Check for implausibly long names,
6787 and don't assume name length fits in 'int'.
6788 (x_get_resource_string): Don't blindly alloca invocation name;
6789 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6790 not fit in int.
6791
6e1a67fb
PE
6792 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6793 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6794 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6795
0df02bf3
PE
6796 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6797 Use esprintf, not sprintf, in case result does not fit in int.
6798
48e30793
PE
6799 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6800 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6801 it as a large positive number.
6802 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6803 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6804
a66ff6d8
PE
6805 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6806 in case result does not fit in int.
6807
aca216ff
PE
6808 * print.c (float_to_string): Detect width overflow more reliably.
6809 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6810 buffer overrun. Don't assume list length fits in 'int'. Treat
6811 print length of 0 as 0, not as infinity; to be consistent with other
6812 uses of print length in this function. Don't overflow print length
6813 index. Don't assume hash table size fits in 'long', or that
6814 vectorlike size fits in 'unsigned long'.
6815
31c286f7
PE
6816 * process.c (make_process): Use printmax_t, not int, to format
6817 process-name gensyms.
6818
55e5faa1
PE
6819 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6820
80f2e268
PE
6821 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6822 to avoid potential buffer overrun.
6823
670741ab
PE
6824 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6825 if X resource line is longer than 512 bytes.
6826
b7163a50
PE
6827 * xfns.c (x_window): Make sprintf buffer a bit bigger
6828 to avoid potential buffer overrun.
6829
ae58ff1f
PE
6830 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6831
c43c8a6a
PE
6832 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6833
3f8236f4
PE
68342011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6835
53e9fe90 6836 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6837 Without these, Emacs silently mishandles large integers sometimes.
6838 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6839 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6840
6511acf2
PE
6841 * xdisp.c (try_window_id): Check Emacs fixnum range before
6842 converting to 'int'.
806add1d 6843
6511acf2 6844 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6845 Check that an Emacs fixnum is in range before assigning it to 'int'.
6846 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6847 values converted from Emacs fixnums.
6848 (Frecenter): Don't wrap around a line count if it is out of 'int'
6849 range; instead, treat it as an extreme value.
6850 (Fset_window_configuration, compare_window_configurations):
6851 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6852
6511acf2
PE
6853 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6854 that can exceed INT_MAX. Check that EMACS_INT value is in range
6855 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6856 (match_limit): Don't assume that a fixnum can fit in 'int'.
6857
6511acf2 6858 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6859 exceed INT_MAX.
6860
6511acf2 6861 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6862 (Fvertical_motion): Don't wrap around LINES values that don't fit
6863 in 'int'. Instead, treat them as extreme values. This is good
6864 enough for windows, which can't have more than INT_MAX lines anyway.
6865
fcb901a7
LMI
68662011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6867
0f2f6b6d
LMI
6868 * Require libxml/parser.h to avoid compilation warning.
6869
fcb901a7
LMI
6870 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6871
6872 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6873 since this reportedly can destroy thread storage.
6874
6e20a0d4
CY
68752011-08-30 Chong Yidong <cyd@stupidchicken.com>
6876
6877 * syntax.c (find_defun_start): Update all cache variables if
6878 exiting early (Bug#9401).
6879
148ae00e
EZ
68802011-08-30 Eli Zaretskii <eliz@gnu.org>
6881
f6cfbd8f
EZ
6882 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6883
148ae00e
EZ
6884 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6885 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6886 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6887
6888 * term.c (tty_append_glyph): New function.
6889 (produce_stretch_glyph): Static function and its prototype deleted.
6890
a66cfb1c
SM
6891 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6892 Add prototypes.
148ae00e 6893
c4a07a4c
PE
68942011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6895
6896 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6897 when checking :margin (Bug#9390).
6898 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6899 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6900 so that the name doesn't mislead. All uses changed.
6901
6bc8cd65
JB
69022011-08-28 Johan Bockgård <bojohan@gnu.org>
6903
6904 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6905 set_tty_hooks.
6906
dca4927e
EZ
69072011-08-27 Eli Zaretskii <eliz@gnu.org>
6908
6909 * xdisp.c (move_it_to): Don't bail out early when reaching
6910 position beyond to_charpos, if we are scanning backwards.
6911 (move_it_vertically_backward): When DY == 0, make sure we get to
6912 the first character in the line after the newline.
6913
f2cad773
PE
69142011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6915
6916 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6917 (ccl_driver): Do not generate an out-of-range pointer.
6918 (Fccl_execute_on_string): Remove unnecessary check for
6919 integer overflow, noted by Stefan Monnier in
6920 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6921 Remove a FIXME that didn't need fixing.
6922 Simplify the newly-introduced buffer reallocation code.
6923
0cae2cdb
JB
69242011-08-27 Juanma Barranquero <lekktu@gmail.com>
6925
6926 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6927
5fc295a4 69282011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6929
70c60eb2 6930 Integer and memory overflow issues (Bug#9196).
726e0ab1 6931
d31850da
PE
6932 * doc.c (get_doc_string): Rework so that
6933 get_doc_string_buffer_size is the actual buffer size, rather than
6934 being 1 less than the actual buffer size; this makes xpalloc more
6935 convenient.
6936
a69fbedb
PE
6937 * image.c (x_allocate_bitmap_record, cache_image):
6938 * xselect.c (Fx_register_dnd_atom):
6939 Simplify previous changes by using xpalloc.
6940
fe5c5d37
PE
6941 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6942 since either will do and ptrdiff_t is convenient with xpalloc.
6943
0065d054
PE
6944 * charset.c (charset_table_size)
6945 (struct charset_sort_data.priority): Now ptrdiff_t.
6946 (charset_compare): Don't overflow if priorities differ greatly.
6947 (Fsort_charsets): Don't assume list length fits in int.
6948 Check for size-calculation overflow when allocating sort data.
6949 (syms_of_charset): Allocate an initial charset table that is
6950 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6951
6952 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6953
6954 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6955 The actual value is always <= INT_MAX, and leaving it unsigned made
6956 overflow checking harder.
6957
6958 * dispextern.h (struct glyph_matrix.rows_allocated)
6959 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6960 with xpalloc. The values are still always <= INT_MAX.
6961
6962 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6963
6964 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6965 (SAFE_NALLOCA): New macro.
6966
6967 * region-cache.c (struct boundary.pos, find_cache_boundary)
6968 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6969 (set_cache_region, invalidate_region_cache)
6970 (revalidate_region_cache, know_region_cache, region_cache_forward)
6971 (region_cache_backward, pp_cache):
6972 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6973 so that ptrdiff_t * can be passed to xpalloc.
6974 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6975 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6976 (pp_cache): Don't assume cache_len fits in int.
6977 * region-cache.h: Adjust extern decls to match.
6978
6979 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6980 EMACS_INT, since either will do, for xpalloc.
6981
6982 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6983 (xnmalloc, xnrealloc, xpalloc): New functions.
6984
726e0ab1
PE
6985 * bidi.c (bidi_shelve_header_size): New constant.
6986 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6987 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6988
51f30bc5 6989 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6990 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6991 (overlay_strings):
6992 Don't update size of array until after memory allocation succeeds,
6993 because xmalloc/xrealloc may not return.
0065d054
PE
6994 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6995 now that we have proper integer overflow checking.
6996 (record_overlay_string, overlay_strings): Catch overflows when
6997 calculating size of overlay_str_buf.
726e0ab1 6998
0065d054
PE
6999 * callproc.c (Fcall_process): Check for size overflow when
7000 calculating size of args2.
7001 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7002 Normally we prefer signed values, but sticking with ptrdiff_t would
7003 require adding more-complicated checks.
726e0ab1
PE
7004
7005 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7006 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7007 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7008 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7009
7010 * character.c (Fstring): Check for size-calculation overflow.
7011
7012 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7013 unnecessary integer overflow. Check for size overflow.
7014 (encode_coding_object): Don't update size until xmalloc succeeds.
7015
7016 * composite.c (get_composition_id): Check for overflow in glyph
7017 length calculations.
7018
7019 Integer and memory overflow fixes for display code.
7020 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7021 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7022 (scrolling_window): Check for overflow in size calculations.
7023 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7024 Don't assume glyph table len fits in int.
7025 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7026 (row_table_size): Now ptrdiff_t, not int.
7027 (scrolling_window): Avoid overflow in size calculations.
7028 Don't update size until allocation succeeds.
7029 * fns.c (concat): Check for overflow in size calculations.
7030 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7031 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7032 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7033
7034 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7035 (get_doc_string): Check for size calculation overflow.
7036 Don't update size until allocation succeeds.
7037 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7038 EMACS_INT, where ptrdiff_t will do.
7039 (Fsubstitute_command_keys): Check for string overflow.
7040
7041 * editfns.c (set_time_zone_rule): Don't assume environment length
7042 fits in int.
7043 (message_length): Now ptrdiff_t, not int.
7044 (Fmessage_box): Don't update size until allocation succeeds.
7045 Don't assume message length fits in int.
7046 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7047
0065d054
PE
7048 * emacs.c (main): Do not reallocate argv, since there is a null at
7049 the end that can be overwritten, and this way there's no need to
7050 worry about size-calculation overflow.
7051 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7052
7053 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7054 alloc succeeds.
7055 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7056
7057 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7058 (x_set_scroll_bar_width, x_figure_window_size):
7059 Check for integer overflow.
7060 (x_set_alpha): Do not assume XINT fits in int.
7061
7062 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7063 This is for the members text_lines, text_cols, total_lines, total_cols,
7064 where the system imposes an 'int' limit.
7065
7066 * fringe.c (Fdefine_fringe_bitmap):
7067 Don't update size until alloc works.
7068
7069 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7070 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7071
7072 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7073 Check for size-calculation overflow.
7074 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7075 do, as we prefer signed integers.
7076 (id_to_widget.max_size, id_to_widget.used)
7077 (xg_store_widget_in_map, xg_remove_widget_from_map)
7078 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7079 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7080 Use and return ptrdiff_t, not int.
7081 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7082 * gtkutil.h: Change prototypes to match the above.
7083
7084 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7085 are duplicate now that they've been promoted to lisp.h.
7086 (x_allocate_bitmap_record, x_alloc_image_color)
7087 (make_image_cache, cache_image, xpm_load):
7088 Don't update size until alloc is done.
7089 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7090 (x_detect_edges):
3256efce 7091 Check for size calculation overflow.
726e0ab1
PE
7092 (ct_colors_allocated_max): New constant.
7093 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7094 overflow.
3256efce 7095
726e0ab1
PE
7096 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7097 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7098 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7099 Use ptrdiff_t, not int, to count maps.
7100 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7101 calculations. Don't update size until allocation succeeds.
7102 Redo calculations to avoid overflow.
726e0ab1
PE
7103 * keyboard.h: Change prototypes to match the above.
7104
7105 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7106 to count maps.
7107 (current_minor_maps): Check for size calculation overflow.
7108 * keymap.h: Change prototypes to match the above.
7109
7110 * lread.c (read1, init_obarray): Don't update size until alloc done.
7111
7112 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7113 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7114
726e0ab1
PE
7115 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7116 Now ptrdiff_t, not int.
7117 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7118 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7119
7120 * process.c (Fnetwork_interface_list): Check for overflow
7121 in size calculation.
7122
7123 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7124
7125 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7126 overflow. Don't bother calling xmalloc when xrealloc will do.
7127
7128 * search.c (Freplace_match): Check for size calculation overflow.
7129 (Fset_match_data): Don't assume list lengths fit in 'int'.
7130
7131 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7132 for command line length. Do not attempt to address one before the
7133 beginning of an array, as that's not portable.
7134
7135 * term.c (max_frame_lines): Remove; unused.
7136 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7137 not int.
7138 (encode_terminal_code, calculate_costs): Check for size
7139 calculation overflow.
7140 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7141 table lengths and related sizes. Don't update size until alloc
7142 done. Redo calculations to avoid overflow.
7143 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7144
7145 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7146 subtracting pointers.
7147 (gobble_line): Check for overflow more carefully. Don't update size
7148 until alloc done.
7149
7150 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7151 Don't update size until alloc done.
7152 Redo size calculations to avoid overflow.
7153 Check for size calculation overflow.
0065d054 7154 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7155
7156 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7157 Use ptrdiff_t, not int, for sizes.
7158 (store_mode_line_noprop_char): Don't update size until alloc done.
7159
0065d054
PE
7160 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7161 Use ptrdiff_t, not int, for sizes.
7162 (Finternal_make_lisp_face, cache_face):
7163 Check for size calculation overflow.
7164 (cache_face): Treat size calculation overflows as if they were
7165 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7166
7167 * xfns.c (x_encode_text, x_set_name_internal)
7168 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7169 sizes, since they can exceed INT_MAX in size. Check for size
7170 calculation overflow.
7171
0065d054
PE
7172 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7173 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7174 Don't update size until alloc done.
7175
0065d054 7176 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7177 as sprintf is limited to int lengths.
1d526e2f 7178
252c5ee1
PE
7179 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7180 (X_LONG_MIN): New macros.
864d7ce7
PE
7181 Use them to make the following changes clearer.
7182 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7183 This change doesn't affect the value now, but it may help remind
7184 future maintainers not to raise the value too much later.
7185 (SELECTION_QUANTUM): Remove, replacing with ...
7186 (selection_quantum): ... new function, which avoids overflow.
7187 All uses changed.
7188 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7189 assumption that selection length fits in 'int'.
7190 (x_reply_selection_request, x_handle_selection_request)
7191 (x_get_window_property, receive_incremental_selection)
7192 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7193 (lisp_data_to_selection_data, clean_local_selection_data):
7194 Use ptrdiff_t, not int, to record length of selection.
7195 (x_reply_selection_request, x_get_window_property)
7196 (receive_incremental_selection, x_property_data_to_lisp):
7197 Redo calculations to avoid overflow.
7198 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7199 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7200 something.
7201 (x_get_window_property, receive_incremental_selection)
7202 (lisp_data_to_selection_data, x_property_data_to_lisp):
7203 Check for size-calculation overflow.
7204 (x_get_window_property, receive_incremental_selection)
7205 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7206 Don't store size until memory allocation succeeds.
7207 (x_get_window_property): Plug memory leak on memory exhaustion.
7208 Don't double-block input; malloc is safe here. Don't assume 2**34
7209 - 4 fits in unsigned long. Add an xassert to check
7210 XGetWindowProperty overflow. Be more careful about overflow
7211 calculations, and distinguish size from memory overflow better.
7212 (receive_incremental_selection): When tracing, don't assume
7213 unsigned int is less than INT_MAX.
7214 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7215 harmful) conversions of unsigned short to int.
7216 (lisp_data_to_selection_data): Don't assume that integers
7217 in the range -65535 through -1 fit in an X unsigned short.
7218 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7219 result parameters unless successful. Rely on cons_to_unsigned
7220 to report problems with elements; the old code wasn't right anyway.
7221 (x_check_property_data): Check for int overflow; we cannot use
7222 a wider type due to X limits.
7223 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7224
726e0ab1 7225 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7226
0065d054
PE
7227 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7228 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7229 (x_color_cells): Don't store size until memory allocation succeeds.
7230 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7231 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7232 (x_term_init): Don't assume length fits in int (sprintf is limited
7233 to int size).
bc18e09d 7234
ebfa62c0
PE
7235 Use ptrdiff_t for composition IDs.
7236 * character.c (lisp_string_width):
7237 * composite.c (composition_table_size, n_compositions)
7238 (get_composition_id, composition_gstring_from_id):
7239 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7240 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7241 * window.c (Frecenter):
7242 Use ptrdiff_t, not int, for composition IDs.
7243 * composite.c (get_composition_id): Check for integer overflow.
7244 * composite.h: Adjust prototypes to match the above changes.
7245
d3411f89
PE
7246 Use ptrdiff_t for hash table indexes.
7247 * category.c (hash_get_category_set):
7248 * ccl.c (ccl_driver):
7249 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7250 * coding.c (coding_system_charset_list, detect_coding_system):
7251 * coding.h (struct coding_system.id):
7252 * composite.c (get_composition_id, gstring_lookup_cache):
7253 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7254 * image.c (xpm_get_color_table_h):
7255 * lisp.h (hash_lookup, hash_put):
7256 * minibuf.c (Ftest_completion):
7257 Use ptrdiff_t for hash table indexes, not int (which is too
7258 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7259 32-bit --with-wide-int hosts).
7260
e097a6fa
PE
7261 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7262 Add a FIXME comment about memory leaks.
7263 (syms_of_charset): Don't assume xmalloc returns.
7264
5637687f
PE
7265 Don't assume that stated character widths fit in int.
7266 * character.c (Fchar_width, c_string_width, lisp_string_width):
7267 * character.h (CHAR_WIDTH):
7268 * indent.c (MULTIBYTE_BYTES_WIDTH):
7269 Use sanitize_char_width to avoid undefined and/or bad behavior
7270 with outlandish widths.
a66cfb1c 7271 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7272 now that we have two such functions. All uses changed.
7273 (sanitize_char_width): New inline function.
7274
a2271ba2
PE
7275 Don't assume that tab-width fits in int.
7276 * character.h (sanitize_width): New inline function.
7277 (SANE_TAB_WIDTH): New macro.
7278 (ASCII_CHAR_WIDTH): Use it.
7279 * indent.c (sane_tab_width): Remove. All uses replaced by
7280 SANE_TAB_WIDTH (current_buffer).
7281 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7282
18c52557
PE
7283 * fileio.c: Integer overflow issues with file modes.
7284 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7285
caeeedc1
PE
7286 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7287 Remove unreachable code.
7288 (read_hex, load_charset_map_from_file): Check for integer overflow.
7289
6df6ae42 7290 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7291 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7292 (x_send_scroll_bar_event): Likewise. Check that the size does not
7293 exceed limits imposed by XClientMessageEvent, as well as the usual
7294 ptrdiff_t and size_t limits.
7295
b13995db
PE
7296 * keyboard.c: Overflow, signedness and related fixes.
7297 (make_lispy_movement): Use same integer type in forward decl
7298 that is used in the definition.
7299 (read_key_sequence, keyremap_step):
7300 Change bufsize argument back to int, undoing my 2011-03-30 change.
7301 We prefer signed types, and int is wide enough here.
7302 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7303 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7304 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7305 length, not size_t. Use ptrdiff_t for index, not int.
7306 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7307 possibility of integer overflow.
7308
13464394
PE
7309 Overflow, signedness and related fixes for images.
7310
7311 * dispextern.h (struct it.stack[0].u.image.image_id)
7312 (struct_it.image_id, struct image.id, struct image_cache.size)
7313 (struct image_cache.used, struct image_cache.ref_count):
7314 * gtkutil.c (update_frame_tool_bar):
7315 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7316 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7317 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7318 * nsmenu.m (update_frame_tool_bar):
7319 * xdisp.c (calc_pixel_width_or_height):
7320 * xfns.c (image_cache_refcount):
7321 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7322 on typical 64-bit hosts.
7323
7324 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7325 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7326 Omit unnecessary casts to int.
7327 (parse_image_spec): Check that integers fall into 'int' range
7328 when the callers expect that.
7329 (image_ascent): Redo ascent calculation to avoid int overflow.
7330 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7331 (lookup_image): Remove unnecessary tests.
7332 (xbm_image_p): Locals are now of int, not EMACS_INT,
7333 since parse_image_check makes sure they fit into int.
7334 (png_load, gif_load, svg_load_image):
7335 Prefer int to unsigned where either will do.
7336 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7337 old tiff_error_handler and tiff_warning_handler.
7338 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7339 stack buffer overflows. It uses only the features of vsnprintf
7340 that are common to both POSIX and native Microsoft.
7341 (tiff_error_handler, tiff_warning_handler): Use it.
7342 (tiff_load, gif_load, imagemagick_load_image):
7343 Don't assume :index value fits in 'int'.
7344 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7345 (imagemagick_load_image): Check that crop parameters fit into
7346 the integer types that MagickCropImage accepts. Don't assume
7347 Vimagemagick_render_type has a nonnegative value. Don't assume
7348 size_t fits in 'long'.
7349 (gs_load): Use printmax_t to print the widest integers possible.
7350 Check for integer overflow when computing image height and width.
7351
c11821d4
EZ
73522011-08-26 Eli Zaretskii <eliz@gnu.org>
7353
7354 * xdisp.c (redisplay_window): Don't force window start if point
7355 will be invisible in the resulting window. (Bug#9324)
7356
0c95fcf7
EZ
73572011-08-25 Eli Zaretskii <eliz@gnu.org>
7358
7359 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7360 the display spec is of the form `(space ...)'.
7361 (handle_display_spec): Return the value returned by
7362 handle_single_display_spec, not just 1 or zero.
7363 (handle_single_display_spec): If the display spec is of the form
7364 `(space ...)', and specifies display in the text area, return 2
7365 rather than 1.
fee65a97 7366 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7367 accurately, and prefer exact match for point under bidi.
7368 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7369
7370 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7371 into disp_prop; all users changed.
7372
7373 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7374 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7375 for the text covered by the display property.
7376
e4ed06f1
CY
73772011-08-25 Chong Yidong <cyd@stupidchicken.com>
7378
7379 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7380 Change return value to nil.
7381 (Frecord_buffer): Delete unused function.
7382
f67cdd7f
EZ
73832011-08-24 Eli Zaretskii <eliz@gnu.org>
7384
5980d4c6
EZ
7385 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7386 buffers, return left-to-right.
8610fe8b
EZ
7387 (set_cursor_from_row): Consider candidate row a win if its glyph
7388 represents a newline and point is on that newline. Fixes cursor
7389 positioning on the newline at EOL of R2L text within L2R
7390 paragraph, and vice versa.
7391 (try_cursor_movement): Check continued rows, in addition to
7392 continuation rows. Fixes unwarranted scroll when point enters a
7393 continued line of R2L text within an L2R paragraph, or vice versa.
7394 (cursor_row_p): Consider the case of point being equal to
7395 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7396 from the end of a short line to the beginning of a continued line
7397 of R2L text within L2R paragraph.
7398 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7399 composed characters.
5980d4c6 7400
f67cdd7f
EZ
7401 * bidi.c (bidi_check_type): Use xassert.
7402 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7403 members.
7404
bca633fb
EZ
74052011-08-23 Eli Zaretskii <eliz@gnu.org>
7406
7407 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7408 a character.
7409
4a5885a7
CY
74102011-08-23 Chong Yidong <cyd@stupidchicken.com>
7411
7412 * nsfont.m (ns_otf_to_script): Fix typo.
7413
0902a04e
KH
74142011-08-22 Kenichi Handa <handa@m17n.org>
7415
7416 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7417 extra slot even if the purpose is char-code-property-table.
7418
1a2e6670
EZ
74192011-08-23 Eli Zaretskii <eliz@gnu.org>
7420
8ddde651
EZ
7421 * xdisp.c (redisplay_window): When computing centering_position,
7422 account for the height of the header line. (Bug#8874)
7423
425cc014
EZ
7424 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7425 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7426 candidate is selected by the mouse, and that candidate has a
7427 composed character under the mouse.
7428
1a2e6670
EZ
7429 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7430 coordinates reported by pos-visible-in-window-p for a composed
7431 character in column zero.
7432
8b76d6f8
SM
74332011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7434
7435 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7436
dac347dd
EZ
74372011-08-22 Eli Zaretskii <eliz@gnu.org>
7438
7439 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7440 consider it a hit if to_charpos is anywhere in the range of the
7441 composed buffer positions.
7442
e013fb34
CY
74432011-08-22 Chong Yidong <cyd@stupidchicken.com>
7444
7445 * image.c (gif_load): Don't assume that each subimage has the same
7446 dimensions as the base image. Handle disposal method that is
7447 "undefined" by the gif spec (Bug#9335).
7448
bd1ba3e8
CY
74492011-08-20 Chong Yidong <cyd@stupidchicken.com>
7450
7451 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7452 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7453
54a1215b
EZ
74542011-08-19 Eli Zaretskii <eliz@gnu.org>
7455
823564e5
EZ
7456 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7457 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7458 from an Org mode buffer to a Speedbar frame.
7459
54a1215b
EZ
7460 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7461 a composition, take its buffer position from IT->cmp_it.charpos.
7462 Fixes cursor positioning at the beginning of a line that begins
7463 with a composed character.
7464
9778ebcc
EZ
74652011-08-18 Eli Zaretskii <eliz@gnu.org>
7466
0be6ee06
EZ
7467 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7468 character bidirectional type, use STRONG_L instead. Fixes crashes
7469 in a buffer produced by `describe-categories'.
7470
9778ebcc
EZ
7471 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7472 members before the level stack, so they would be saved and
7473 restored when copying iterator state. Fixes incorrect reordering
7474 around TABs covered by display properties.
7475
156bffbe
AS
74762011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7477
6b02f655 7478 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7479
72ad093b
CY
74802011-08-17 Chong Yidong <cyd@stupidchicken.com>
7481
7482 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7483 (internal_condition_case_2, internal_condition_case_n):
7484 Remove unnecessary aborts (Bug#9081).
72ad093b 7485
35774242
EZ
74862011-08-17 Eli Zaretskii <eliz@gnu.org>
7487
7488 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7489 has no `load' handler, try opening the file locally. (Bug#9311)
7490
db76dd85
KB
74912011-08-16 Ken Brown <kbrown@cornell.edu>
7492
7493 * gmalloc.c: Expand comment.
7494
b215eee5
EZ
74952011-08-16 Eli Zaretskii <eliz@gnu.org>
7496
7497 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7498 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7499
a4579d33
KB
75002011-08-16 Ken Brown <kbrown@cornell.edu>
7501
7502 Fix memory allocation problems in Cygwin build (Bug#9273).
7503
7504 * unexcw.c ( __malloc_initialized): Declare external variable.
7505 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7506
8b76d6f8
SM
7507 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7508 New variables.
a4579d33
KB
7509 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7510 dumped emacs.
7511 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7512 in the static heap.
7513 [CYGWIN] (special_realloc): New function.
7514 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7515 requests to realloc storage in the static heap.
7516
3ebec551
PE
75172011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7518
7519 * bidi.c (bidi_initialize): Remove unused local.
7520
9fd8be00
EZ
75212011-08-15 Eli Zaretskii <eliz@gnu.org>
7522
6b02f655
SM
7523 * bidimirror.h:
7524 * biditype.h: Remove file.
7525 * makefile.w32-in ($(BLD)/bidi.$(O)):
7526 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7527
7528 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7529
7530 * chartab.c: Improve commentary for the uniprop_table API.
7531
32413314
EZ
7532 * bidi.c (bidi_paragraph_init): Support zero value of
7533 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7534 (bidi_initialize): Use uniprop_table instead of including
7535 biditype.h and bidimirror.h.
32413314 7536
9fd8be00
EZ
7537 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7538 coordinates of the iterator when restoring from ppos_it.
7539 (Bug#9296)
7540
5cf2b69b
KH
75412011-08-14 Kenichi Handa <handa@m17n.org>
7542
7543 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7544 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7545
daf17d00
EZ
75462011-08-14 Eli Zaretskii <eliz@gnu.org>
7547
7548 * xdisp.c (move_it_in_display_line_to): Don't invoke
7549 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7550 ppos_it. Fixes vertical cursor motion when line beginning is
7551 covered by an image. (Bug#9296)
7552
08e3161a
JD
75532011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7554
7555 * nsterm.h (ns_run_ascript): Declare.
7556 (NSAPP_DATA2_RUNASSCRIPT): Define.
7557
7558 * nsfns.m (as_script, as_result, as_status): New static variables.
7559 (ns_run_ascript): New function.
5e617bc2 7560 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7561 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7562 the event loop. Get status from as_status (Bug#7276).
7563
7564 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7565 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7566 the event loop (Bug#7276).
7567
a3720aa2
AS
75682011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7569
7570 * gnutls.c (QCgnutls_bootprop_priority)
7571 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7572 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7573 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7574 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7575 (QCgnutls_bootprop_verify_hostname_error)
7576 (QCgnutls_bootprop_callbacks_verify): Rename from
7577 Qgnutls_bootprop_..., all uses changed.
7578
7579 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7580 uses changed.
7581
0a0d27fb
PE
75822011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7583
19d5c50c
PE
7584 * xfaces.c (Qframe_set_background_mode): Now static.
7585 * dispextern.h (Qframe_set_background_mode): Remove decl.
7586
0a0d27fb
PE
7587 * process.c (Fnetwork_interface_info): Declare local only if needed.
7588
377538cb
JD
75892011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7590
7591 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7592 (Fnetwork_interface_list): Allocate in increments of bytes instead
7593 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7594 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7595 sockaddr.
7596 (struct ifflag_def): notrailers is smart on OSX.
7597 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7598 Get hardware address with getifaddrs if available.
7599
08fff70c
EZ
76002011-08-12 Eli Zaretskii <eliz@gnu.org>
7601
7602 * xdisp.c (iterate_out_of_display_property): xassert that
7603 IT->position is set to within IT->object's boundaries. Break from
7604 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7605 when IT->position is set up wrongly due to some bug.
7606 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7607 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7608 entry. Force push_it to save on the stack the current
7609 buffer/string position, to be restored by pop_it. Fix flags in
7610 the iterator structure wrt the object coming from a display
7611 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7612 properties. (Bug#9284)
7613
7be1c708 76142011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7615
7be1c708
CY
7616 * fontset.c (fontset_get_font_group): Add proper type checks.
7617 (Bug#9172)
aac0c6e3 7618
7be1c708 76192011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7620
7be1c708
CY
7621 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7622 and LC_VERSION_MIN_MACOSX.
7623 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7624 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7625
97bb72a6
EZ
76262011-08-08 Eli Zaretskii <eliz@gnu.org>
7627
7628 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7629 no-display-properties-and-no-overlays under bidi display.
7630 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7631 properties and overlays.
97bb72a6 7632
d5617611
CY
76332011-08-08 Chong Yidong <cyd@stupidchicken.com>
7634
37e11a63
CY
7635 * editfns.c (Fset_time_zone_rule): Document relationship with the
7636 setenv function.
7637
d5617611
CY
7638 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7639 the font entity extracted from the cache (Bug#8109).
7640
58872834
CY
76412011-08-07 Chong Yidong <cyd@stupidchicken.com>
7642
7643 * composite.c (autocmp_chars): Don't reset point. That is done by
7644 restore_point_unwind (Bug#5984).
7645
75bfc667
JL
76462011-08-07 Juri Linkov <juri@jurta.org>
7647
7648 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7649 to show the arg `TIME' instead of `TIMEVAL'.
7650
d1410150
EZ
76512011-08-06 Eli Zaretskii <eliz@gnu.org>
7652
7653 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7654 display property strides EOL and includes a newline, as in
7655 longlines-mode. (Bug#9254)
75b771e4
EZ
7656 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7657 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7658
7659 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7660 is non-zero, even if the data buffer is NULL. Fixes a crash in
7661 vertical-motion with longlines-mode. (Bug#9254)
7662
35928349
EZ
76632011-08-05 Eli Zaretskii <eliz@gnu.org>
7664
ec7cc85b
EZ
7665 * bidi.c <bidi_cache_total_alloc>: Now static.
7666 (bidi_initialize): Initialize bidi_cache_total_alloc.
7667
8b76d6f8 7668 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7669 cache. (Bug#9221)
7670
7671 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7672 amount allocated this far in `bidi_cache_total_alloc'.
7673 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7674 non-zero, only free the data buffer without restoring the cache
7675 contents. All callers changed.
7676
7677 * dispextern.h (bidi_unshelve_cache): Update prototype.
7678
7679 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7680 (move_it_in_display_line, move_it_to)
7681 (move_it_vertically_backward, move_it_by_lines): Replace the call
7682 to xfree to an equivalent call to bidi_unshelve_cache.
7683 (move_it_in_display_line_to): Fix logic of returning
412b6358 7684 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7685
e2e2423b
EZ
76862011-08-05 Eli Zaretskii <eliz@gnu.org>
7687
7688 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7689 came from a string character with a `cursor' property. (Bug#9229)
7690
ae9e757a
JD
76912011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7692
7693 * Makefile.in (LIB_PTHREAD): New variable.
7694 (LIBES): Add LIB_PTHREAD (Bug#9216).
7695
7696 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7697 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7698
213bd7f2
AS
76992011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7700
6b02f655 7701 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7702
99aaf75f
JD
77032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7704
7705 * xterm.c (x_find_topmost_parent): New function.
7706 (x_set_frame_alpha): Find topmost parent window with
7707 x_find_topmost_parent and set the property there also (bug#9181).
7708 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7709
c74e9d86
PE
77102011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7711
7712 * callproc.c (Fcall_process): Avoid vfork clobbering
7713 the local vars buffer, coding_systems, current_dir.
7714
640c8776
SM
77152011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7716
7717 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7718
f26d0e4c
PE
77192011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7720
8a10d76c
PE
7721 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7722 so that it is not optimized away.
7723
f26d0e4c
PE
7724 * xdisp.c (compute_display_string_pos): Remove unused local.
7725
55439c61
EZ
77262011-08-02 Eli Zaretskii <eliz@gnu.org>
7727
7728 Fix slow cursor motion and scrolling in large buffers with
7729 selective display, like Org Mode buffers. (Bug#9218)
7730
7731 * dispextern.h (struct bidi_it): New member disp_prop_p.
7732
7733 * xdisp.c: Remove one-slot cache of display string positions.
7734 (compute_display_string_pos): Accept an additional argument
5e617bc2 7735 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7736 for a display string or property. If found, set DISP_PROP_P
7737 non-zero.
7738
7739 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7740 DISP_PROP_P, and pass it to compute_display_string_pos.
7741 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7742 non-zero. All callers of bidi_fetch_char changed.
7743
fb33fa43
SM
77442011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7745
7746 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7747
b099e063
DM
77482010-12-03 Don March <don@ohspite.net>
7749
7750 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7751 last character M-[char] is translated to ESC [char] (bug#7541).
7752
5cc7f7af
KH
77532011-08-02 Kenichi Handa <handa@m17n.org>
7754
d0fffa3f 7755 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7756
7757 * chartab.c (uniprop_table): Make it non-static.
7758
525d5e6e
EZ
77592011-08-01 Eli Zaretskii <eliz@gnu.org>
7760
7761 * xdisp.c (forward_to_next_line_start): Accept additional argument
7762 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7763 on the newline.
7764 (reseat_at_next_visible_line_start): Use the bidi iterator state
7765 returned by forward_to_next_line_start to restore the state of
7766 it->bidi_it after backing up to previous newline. (Bug#9212)
7767
31011111
AS
77682011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7769
7770 * regex.c (re_comp): Protoize.
7771 (re_exec): Fix return type.
7772 (regexec): Fix type of `ret'. (Bug#9203)
7773
476371c4
PE
77742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7775
e5d76069
PE
7776 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7777 This is needed if max-image-size is a floating-point number.
7778
9a79b20c
AS
77792011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7780
7781 * print.c (print_object): Print empty symbol as ##.
7782
7783 * lread.c (read1): Read ## as empty symbol.
7784
d8c2fa78
AA
77852011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7786
7787 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7788 setting frame foreground color (Bug#9175).
7789 (x_set_background_color): Likewise.
7790
ffe57a7a
AA
7791 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7792 contents (Bug#9176).
7793 (EmacsTooltip -init): Remove bezels and add shadows to
7794 tooltip windows.
7795
bf3492a5
AA
7796 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7797 or scroll bar (Bug#8470).
7798
d55e9c53
AA
7799 * nsfont.m (nsfont_open): Remove assignment to voffset and
7800 unnecessary vars hshink, expand, hd, full_height, min_height.
7801 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7802
7803 * nsterm.h (nsfont_info): Remove voffset field.
7804
d8c2fa78 78052011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7806
7807 Implement strike-through and overline on NextStep (Bug#8863).
7808
7809 * nsfont.m (nsfont_open): Use underline position provided by font,
7810 instead of hard-coded value of 2.
7811 (nsfont_draw): Call ns_draw_text_decoration instead.
7812
7813 * nsterm.h: Add declaration for ns_draw_text_decoration.
7814
7815 * nsterm.m (ns_draw_text_decoration): New function for drawing
7816 underline, overline, and strike-through.
7817 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7818 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7819 accommodate underlining, etc.
4843aac3 7820
4cc60b9b
EZ
78212011-07-28 Eli Zaretskii <eliz@gnu.org>
7822
bc7ece87
EZ
7823 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7824 default.
4cc60b9b 7825
476371c4
PE
78262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7827
66606eea
PE
7828 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7829 Without this fix, if a signal arrives just after memory fills up,
7830 'malloc' might be invoked reentrantly.
7831
476371c4
PE
7832 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7833 In other words, assume that every image size is allowed, on non-X
7834 hosts. This assumption is probably wrong, but it lets Emacs compile.
7835
f3fcc40d
AS
78362011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7837
7838 * regex.c (re_iswctype): Convert return values to boolean.
7839
350c992f
EZ
78402011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7841
7842 * xdisp.c (compute_display_string_pos): Don't use cached display
7843 string position if the buffer had its restriction changed.
7844 (Bug#9184)
7845
5266b4bb
PE
78462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7847
7848 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7849
2573a837 78502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7851
41f55ccd 7852 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7853
39e378da
PE
7854 * bidi.c: Integer size and overflow fixes.
7855 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7856 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7857 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7858 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7859 (bidi_find_other_level_edge):
7860 Use ptrdiff_t instead of EMACS_INT where either will do.
7861 This works better on 32-bit hosts configured --with-wide-int.
7862 (bidi_cache_ensure_space): Check for size-calculation overflow.
7863 Use % rather than repeated addition, for better worst-case speed.
7864 Don't set bidi_cache_size until after xrealloc returns, because it
7865 might not return.
7866 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7867 (bidi_cache_ensure_space): Also check that the bidi cache size
7868 does not exceed that of the largest Lisp string or buffer. See Eli
7869 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7870
5e927815
PE
7871 * alloc.c (__malloc_size_t): Remove.
7872 All uses replaced by size_t. See Andreas Schwab's note
7873 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7874
ca4aa935
PE
7875 * image.c: Improve checking for integer overflow.
7876 (check_image_size): Assume that f is nonnull, since
7877 it is always nonnull in practice. This is one less thing to
7878 worry about when checking for integer overflow later.
7879 (x_check_image_size): New function, which checks for integer
7880 overflow issues inside X.
7881 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7882 This removes the need for a memory_full check.
7883 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7884 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7885 (xbm_read_bitmap_data): Change locals back to 'int', since
7886 their values must fit in 'int'.
7887 (xpm_load_image, png_load, tiff_load):
7888 Invoke x_create_x_image_and_pixmap earlier,
7889 to avoid much needless work if the image is too large.
7890 (tiff_load): Treat overly large images as if
7891 x_create_x_image_and_pixmap failed, not as malloc failures.
7892 (gs_load): Use x_check_image_size.
7893
5f8f9cc2
PE
7894 * gtkutil.c: Omit integer casts.
7895 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7896 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7897
5adf60bc
PE
7898 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7899
c8907a93
PE
7900 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7901 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7902 would wrongly return t on a 64-bit host.
7903
e3c25c68
PE
7904 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7905 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7906 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7907 and therefore cause GCC to emit a bogus diagnostic in some cases.
7908
3f791afe
PE
7909 * image.c: Integer signedness and overflow and related fixes.
7910 This is not an exhaustive set of fixes, but it's time to
7911 record what I've got.
7912 (lookup_pixel_color, check_image_size): Remove redundant decls.
7913 (check_image_size): Don't assume that arbitrary EMACS_INT values
7914 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7915 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7916 (tiff_load, imagemagick_load_image):
7917 Check for overflow in size calculations.
7918 (x_create_x_image_and_pixmap): Remove unnecessary test for
7919 xmalloc returning NULL; that can't happen.
7920 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7921 (xpm_color_bucket): Use better integer hashing function.
7922 (xpm_cache_color): Don't possibly over-allocate memory.
7923 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7924 (gif_memory_source):
7925 Use ptrdiff_t, not int or size_t, to record sizes.
7926 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7927 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7928 either works, as we prefer signed integers.
7929 (tiff_read_from_memory, tiff_write_from_memory):
7930 Return tsize_t, not size_t, since that's what the TIFF API wants.
7931 (tiff_read_from_memory): Don't fail simply because the read would
7932 go past EOF; instead, return a short read.
7933 (tiff_load): Omit no-longer-needed casts.
7934 (Fimagemagick_types): Don't assume size fits into 'int'.
7935
3cc5a532
PE
7936 Improve hashing quality when configured --with-wide-int.
7937 * fns.c (hash_string): New function, taken from sxhash_string.
7938 Do not discard information about ASCII character case; this
7939 discarding is no longer needed.
7940 (sxhash-string): Use it. Change sig to match it. Caller changed.
7941 * lisp.h: Declare it.
7942 * lread.c (hash_string): Remove, since we now use fns.c's version.
7943 The fns.c version returns a wider integer if --with-wide-int is
7944 specified, so this should help the quality of the hashing a bit.
7945
b312a492
PE
7946 * emacs.c: Integer overflow minor fix.
7947 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7948 Define only if GNU_LINUX.
7949 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7950
dfd153ae
PE
7951 * dispnew.c: Integer signedness and overflow fixes.
7952 Remove unnecessary forward decls, that were a maintenance hassle.
7953 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7954 All uses changed.
7955 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7956 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7957 (prepare_desired_row, line_draw_cost):
7958 Use int, not unsigned, where either works.
7959 (save_current_matrix, restore_current_matrix):
7960 Use ptrdiff_t, not size_t, where either works.
7961 (init_display): Check for overflow more accurately, and without
7962 relying on undefined behavior.
7963
a81d11a3
PE
7964 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7965 Remove, replacing with the new symbols in lisp.h. All uses changed.
7966 * fileio.c (make_temp_name):
7967 * filelock.c (lock_file_1, lock_file):
7968 * xdisp.c (message_dolog):
7969 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7970 Use pMd etc. instead.
7971 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7972 replacing the pWIDE etc. symbols removed from editfns.c.
7973
3300e6fd
PE
7974 * keyboard.h (num_input_events): Now uintmax_t.
7975 This is (very slightly) less likely to mess up due to wraparound.
7976 All uses changed.
7977
fd05c7e9
PE
7978 * buffer.c: Integer signedness fixes.
7979 (alloc_buffer_text, enlarge_buffer_text):
7980 Use ptrdiff_t rather than size_t when either will do, as we prefer
7981 signed integers.
7982
903fe15d
PE
7983 * alloc.c: Integer signedness and overflow fixes.
7984 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7985 (__malloc_size_t): Default to size_t, not to int.
7986 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7987 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7988 Prefer ptrdiff_t to size_t when either would do, as we prefer
7989 signed integers.
7990 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7991 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7992 Now const. Initialize with values that are in range even if char
7993 is signed.
7994 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7995 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7996 These functions do the right thing with sizes > 2**32.
7997 (check_depth): Now ptrdiff_t, not int.
7998 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7999 Adjust to new way of storing sizes. Check for size overflow bugs
8000 in rest of code.
8001 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8002 slightly wrong anyway, as it missed one instance of
8003 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8004 (refill_memory_reserve): Omit needless cast to size_t.
8005 (mark_object_loop_halt): Mark as externally visible.
8006
ac82cc6a
PE
8007 * xselect.c: Integer signedness and overflow fixes.
8008 (Fx_register_dnd_atom, x_handle_dnd_message):
8009 Use ptrdiff_t, not size_t, since we prefer signed.
8010 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8011 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8012 x_dnd_atoms_size and x_dnd_atoms_length.
8013
c2d1e36d
PE
8014 * doprnt.c: Prefer signed to unsigned when either works.
8015 * eval.c (verror):
8016 * doprnt.c (doprnt):
8017 * lisp.h (doprnt):
8018 * xdisp.c (vmessage):
8019 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8020 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8021 prefer signed arithmetic to avoid comparison confusion.
8022 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8023 but is a bit tricky.
8024
0e926e56
PE
8025 Assume freestanding C89 headers, string.h, stdlib.h.
8026 * data.c, doprnt.c, floatfns.c, print.c:
8027 Include float.h unconditionally.
8028 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8029 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8030 * regex.c: Likewise for stddef.h, string.h.
8031 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8032 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8033 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8034 (STDC_HEADERS): Remove obsolete defines.
8035 * sysdep.c: Include limits.h unconditionally.
8036
9cfdb3ec
PE
8037 Assume support for memcmp, memcpy, memmove, memset.
8038 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8039 * regex.c (memcmp, memcpy):
8040 Remove; we assume C89 now.
8041
8042 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8043 (__malloc_safe_bcopy): Remove; no longer needed.
8044
cf950e6b 8045 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8046 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8047 well either way, and we prefer signed to unsigned.
8048
dbf38e02
LMI
80492011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8050
8051 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8052 closes the connection while we're reading (bug#9182).
8053
d6f0886c 80542011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8055
d6f0886c
JD
8056 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8057 are specified (Bug#9168).
24e0f6b1 8058
2eb1f9e6
PE
80592011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8060
8061 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8062 Found by GCC static checking and --with-wide-int on a 32-bit host.
8063
22381272 80642011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8065
8066 * xdisp.c (compute_display_string_pos): Fix logic of caching
8067 previous display string position. Initialize cached_prev_pos to
8068 -1. Fixes slow-down at the beginning of a buffer.
8069
f25e39b4
EZ
80702011-07-24 Eli Zaretskii <eliz@gnu.org>
8071
8072 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8073 for attrs[LFACE_FONTSET_INDEX].
8074
04c4b52e
PE
80752011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8076
8077 * xml.c (parse_region): Remove unused local
8078 that was recently introduced.
8079
c1734fbd
EZ
80802011-07-23 Eli Zaretskii <eliz@gnu.org>
8081
be18c5a5
EZ
8082 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8083 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8084
c1734fbd
EZ
8085 * xdisp.c (move_it_in_display_line_to): Record the best matching
8086 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8087 exit if none of the characters scanned was an exact match.
8088 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8089 when exact match is impossible due to invisible text, and the
8090 lines are truncated.
8091
a258d627
JD
80922011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8093
8094 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8095 for OSX >= 10.7.
8096
b6d5a689
EZ
80972011-07-22 Eli Zaretskii <eliz@gnu.org>
8098
0f74f785
EZ
8099 Fix a significant slow-down of cursor motion with C-n, C-p,
8100 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8101 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8102 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8103 (next_element_from_buffer): Call compute_stop_pos_backwards to
8104 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8105 base_level_stop.
8106 (reseat): Don't look for prev_stop, as that could mean a very long
8107 run.
8108 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8109 <cached_disp_overlay_modiff>: Cache for last found display string
8110 position.
551918c1 8111 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8112 about the same buffer in the same area of character positions, and
8113 the buffer wasn't changed since the time the display string
8114 position was cached.
551918c1 8115
b2d0c91a
EZ
81162011-07-22 Eli Zaretskii <eliz@gnu.org>
8117
8118 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8119 is an integer, which is important for empty lines. (Bug#9149)
8120
043604ee
CY
81212011-07-22 Chong Yidong <cyd@stupidchicken.com>
8122
8123 * frame.c (Fmodify_frame_parameters): In tty case, update the
8124 default face if necessary (Bug#4238).
8125
da4adb04
CY
81262011-07-21 Chong Yidong <cyd@stupidchicken.com>
8127
8128 * editfns.c (Fstring_to_char): No need to explain what a character
8129 is in the docstring (Bug#6576).
8130
9abd0532
LMI
81312011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8132
8133 * xml.c (parse_region): Make sure we always return a tree.
8134
36881d16
HK
81352011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8136
8137 * xml.c (parse_region): If a document contains only comments,
8138 return that, too.
8139
1e98674d
LMI
81402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8141
8142 * xml.c (make_dom): Return comments, too.
8143
590bd467
PE
81442011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8145
8146 Port to OpenBSD.
8147 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8148 and the surrounding thread.
8149 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8150 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8151 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8152 timer goes off.
8153 * s/openbsd.h (BROKEN_SIGIO): Define.
8154 * unexelf.c (unexec) [__OpenBSD__]:
8155 Don't update the .mdebug section of the Alpha COFF symbol table.
8156
f41628b2
LMI
81572011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8158
8159 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8160 (bug#8460).
8161
b59b67c5
PE
81622011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8163
15e3a074
PE
8164 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8165 This fixes some race conditions on the permissions of any newly
8166 created file.
8167
41bed37d
PE
8168 * alloc.c (valid_pointer_p): Use pipe, not open.
8169 This fixes some permissions issues when debugging.
8170
b59b67c5
PE
8171 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8172 If fchown fails to set both uid and gid, try to set just gid,
8173 as that is sometimes allowed. Adjust the file's mode to eliminate
8174 setuid or setgid bits that are inappropriate if fchown fails.
8175
925a6be7
SM
81762011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8177
8178 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8179 to compare Lisp_Objects.
8180 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8181 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8182 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8183
52968808
AS
81842011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8185
0a6a104b
AS
8186 * lread.c (read_integer): Unread even EOF character.
8187 (read1): Likewise. Properly record start position of symbol.
8188
52968808
AS
8189 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8190 symbol character follows.
8191
9e381cdd
PE
81922011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8193
8194 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8195 This works around a problem with the previous change to Fcopy_file.
8196 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8197 and without this change, GCC might complain about discarding
8198 fchown's return value.
8199
b5641435
JB
82002011-07-16 Juanma Barranquero <lekktu@gmail.com>
8201
8202 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8203
a8031457
PE
82042011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8205
8206 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8207
dd889327
LMI
82082011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8209
750c33f7
LMI
8210 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8211 it's used from the C level.
8212
dd889327
LMI
8213 * process.c: Use the same condition for POLL_FOR_INPUT in both
8214 keyboard.c and process.c (bug#1858).
8215
87e86684
LM
82162011-07-09 Lawrence Mitchell <wence@gmx.li>
8217
8218 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8219 (Fgnutls_boot): Use it.
8220
64348f40
AS
82212011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8222
8223 * doc.c (Fsubstitute_command_keys): Revert last change.
8224
1d698799
LMI
82252011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8226
f863868c
LMI
8227 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8228 quotes the next character, and doesn't affect other longer
8229 sequences (bug#8935).
8230
1d698799
LMI
8231 * lread.c (syms_of_lread): Clarify that is isn't only
8232 `eval-buffer' and `eval-defun' that's affected by
8233 `lexical-binding' (bug#8460).
8234
aa4b6df6
EZ
82352011-07-15 Eli Zaretskii <eliz@gnu.org>
8236
8237 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8238 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8239
5d856da6
PE
82402011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8241
ad6042bb
PE
8242 Fix minor problems found by static checking.
8243 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8244 (elsz): Now a signed constant, not a size_t var. We prefer signed
8245 types to unsigned, to avoid integer comparison confusion. Without
8246 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8247 "cannot optimize loop, the loop counter may overflow", a symptom
8248 of the confusion.
f00bbb22 8249 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8250 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8251
6468f31c
LMI
82522011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8253
49080b10
LMI
8254 * search.c (Fre_search_backward): Mention `case-fold-search' in
8255 all the re_search_* functions (bug#8138).
8256
6468f31c
LMI
8257 * keyboard.c (Fopen_dribble_file): Document when the file is
8258 closed (bug#8056).
8259
c965adc5
EZ
82602011-07-14 Eli Zaretskii <eliz@gnu.org>
8261
df9733bf
EZ
8262 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8263 bidi_cache_idx.
8264
0bb23927
EZ
8265 Support bidi reordering of display and overlay strings.
8266 * xdisp.c (compute_display_string_pos)
8267 (compute_display_string_end): Accept additional argument STRING.
8268 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8269 (reseat_to_string): Initialize bidi_it->string.s and
8270 bidi_it->string.schars.
8271 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8272 NULL (avoids a crash in bidi_paragraph_init).
8273 Initialize itb.string.lstring.
0bb23927
EZ
8274 (init_iterator): Call bidi_init_it only of a valid
8275 buffer position was specified. Initialize paragraph_embedding to
8276 L2R.
8277 (reseat_to_string): Initialize the bidi iterator.
8278 (display_string): If we need to ignore text properties of
8279 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8280 original value of -1 will not work with bidi.)
8281 (compute_display_string_pos): First arg is now struct
8282 `text_pos *'; all callers changed. Support display properties on
8283 Lisp strings.
8284 (compute_display_string_end): Support display properties on Lisp
8285 strings.
8286 (init_iterator, reseat_1, reseat_to_string): Initialize the
8287 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8288 when iterating on a string not from display properties).
640c8776
SM
8289 (compute_display_string_pos, compute_display_string_end):
8290 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8291 arrow keys.
8292 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8293 base_level_stop; instead, set base_level_stop to BEGV.
8294 Fixes crashes in vertical-motion.
0bb23927
EZ
8295 (next_element_from_buffer): Improve commentary for when
8296 the iterator is before prev_stop.
8297 (init_iterator): Initialize bidi_p from the default value of
8298 bidi-display-reordering, not from buffer-local value. Use the
8299 buffer-local value only if initializing for buffer iteration.
8300 (handle_invisible_prop): Support invisible properties on strings
8301 that are being bidi-reordered.
8302 (set_iterator_to_next): Support bidi reordering of C strings and
8303 Lisp strings.
8304 (next_element_from_string): Support bidi reordering of Lisp
8305 strings.
8306 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8307 (display_string): Support display of R2L glyph rows.
8308 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8309 (init_iterator): Don't initialize it->bidi_p for strings
8310 here.
8311 (reseat_to_string): Initialize it->bidi_p for strings here.
8312 (next_element_from_string, next_element_from_c_string)
8313 (next_element_from_buffer): Add xassert's for correspondence
8314 between IT's object being iterated and it->bidi_it.string
8315 structure.
8316 (face_before_or_after_it_pos): Support bidi iteration.
8317 (next_element_from_c_string): Handle the case of the first string
8318 character that is not the first one in the visual order.
8319 (get_visually_first_element): New function, refactored from common
8320 parts of next_element_from_buffer, next_element_from_string, and
8321 next_element_from_c_string.
8322 (tool_bar_lines_needed, redisplay_tool_bar)
8323 (display_menu_bar): Force left-to-right direction. Add a FIXME
8324 comment for making that be controlled by a user option.
8325 (push_it, pop_it): Save and restore the state of the
8326 bidi iterator. Save and restore the bidi_p flag.
8327 (pop_it): Iterate out of display property for string iteration as
8328 well.
8329 (iterate_out_of_display_property): Support iteration over strings.
8330 (handle_single_display_spec): Set up it->bidi_it for iteration
8331 over a display string, and call bidi_init_it.
8332 (handle_single_display_spec, next_overlay_string)
8333 (get_overlay_strings_1, push_display_prop): Set up the bidi
8334 iterator for displaying display or overlay strings.
8335 (forward_to_next_line_start): Don't use the shortcut if
8336 bidi-iterating.
8337 (back_to_previous_visible_line_start): If handle_display_prop
8338 pushed the iterator stack, restore the internal state of the bidi
8339 iterator by calling bidi_pop_it same number of times.
8340 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8341 and we are bidi-iterating, don't decrement the iterator position;
8342 instead, set the first_elt flag in the bidi iterator, to produce
8343 the same effect.
8344 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8345 (push_display_prop): xassert that we are iterating a buffer.
8346 (push_it, pop_it): Save and restore paragraph_embedding member.
8347 (handle_single_display_spec, next_overlay_string)
8348 (get_overlay_strings_1, reseat_1, reseat_to_string)
8349 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8350 correctly. Don't assume unibyte strings are not bidi-reordered.
8351 (compute_display_string_pos)
8352 (compute_display_string_end): Fix handling the case of C string.
8353 (push_it, pop_it): Save and restore from_disp_prop_p.
8354 (handle_single_display_spec, push_display_prop): Set the
8355 from_disp_prop_p flag.
8356 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8357 (pop_it): Call iterate_out_of_display_property only if we are
8358 popping after iteration over a string that came from a display
8359 property. Fix a typo in popping stretch info. Add an assertion
8360 for verifying that the iterator position is in sync with the bidi
8361 iterator.
8362 (handle_single_display_spec, get_overlay_strings_1)
8363 (push_display_prop): Fix initialization of paragraph direction for
8364 string when that of the parent object is not yet determined.
8365 (reseat_1): Call bidi_init_it to resync the bidi
8366 iterator with IT's position. (Bug#7616)
8367 (find_row_edges): If ROW->start.pos gives position
8368 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8369 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8370 Reset the from_disp_prop_p flag.
8371 (SAVE_IT, RESTORE_IT): New macros.
8372 (pos_visible_p, face_before_or_after_it_pos)
8373 (back_to_previous_visible_line_start)
8374 (move_it_in_display_line_to, move_it_in_display_line)
8375 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8376 (try_scrolling, redisplay_window, display_line): Use them when
8377 saving a temporary copy of the iterator and restoring it back.
8378 (back_to_previous_visible_line_start, reseat_1)
8379 (init_iterator): Empty the bidi cache "stack".
8380 (move_it_in_display_line_to): If iterator ended up at
8381 EOL, but we never saw any buffer positions smaller than
8382 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8383 motion in bidi-reordered lines.
8384 (move_it_in_display_line_to): Record prev_method and prev_pos
8385 immediately before the call to set_iterator_to_next. Fixes cursor
8386 motion in bidi-reordered lines with stretch glyphs and strings
8387 displayed in margins. (Bug#8133) (Bug#8867)
8388 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8389 TO_CHARPOS.
640c8776
SM
8390 (pos_visible_p): Support positions in bidi-reordered lines.
8391 Save and restore bidi cache.
0bb23927
EZ
8392
8393 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8394 (bidi_paragraph_info): Delete unused struct.
8395 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8396 (bidi_cache_start): New variable.
8397 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8398 to zero.
8399 (bidi_cache_fetch_state, bidi_cache_search)
8400 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8401 (bidi_cache_find, bidi_peek_at_next_level)
8402 (bidi_level_of_next_char, bidi_find_other_level_edge)
8403 (bidi_move_to_visually_next): Compare cache index with
8404 bidi_cache_start rather than with zero.
8405 (bidi_fetch_char): Accept new argument STRING; all callers
8406 changed. Support iteration over a string. Support strings with
8407 display properties. Support unibyte strings. Fix the type of
8408 `len' according to what STRING_CHAR_AND_LENGTH expects.
8409 (bidi_paragraph_init, bidi_resolve_explicit_1)
8410 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8411 (bidi_level_of_next_char, bidi_move_to_visually_next):
8412 Support iteration over a string.
0bb23927
EZ
8413 (bidi_set_sor_type, bidi_resolve_explicit_1)
8414 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8415 can now be zero (for strings); special values 0 and -1 were
8416 changed to -1 and -2, respectively.
8417 (bidi_char_at_pos): New function.
8418 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8419 Call it instead of FETCH_MULTIBYTE_CHAR.
8420 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8421 initialized to valid values.
8422 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8423 values.
8424 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8425 the test for valid cached positions. Fix the logic for looking up
8426 the sentinel state in the cache. GCPRO the Lisp string we are
8427 iterating.
8428 (bidi_push_it, bidi_pop_it): New functions.
8429 (bidi_initialize): Initialize the bidi cache start stack pointer.
8430 (bidi_cache_ensure_space): New function, refactored from part of
8431 bidi_cache_iterator_state. Don't assume the required size is just
8432 one BIDI_CACHE_CHUNK away.
8433 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8434 (bidi_count_bytes, bidi_char_at_pos): New functions.
8435 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8436 always valid if bidi_cache_idx is valid.
8437 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8438 is valid if it's going to be used.
8439 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8440 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8441 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8442 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8443 (bidi_find_other_level_edge, bidi_cache_start_stack):
8444 All variables related to cache indices are now EMACS_INT.
c965adc5 8445
0bb23927
EZ
8446 * dispextern.h (struct bidi_string_data): New structure.
8447 (struct bidi_it): New member `string'. Make flag members be 1-bit
8448 fields, and put them last in the struct.
640c8776
SM
8449 (compute_display_string_pos, compute_display_string_end):
8450 Update prototypes.
0bb23927
EZ
8451 (bidi_push_it, bidi_pop_it): Add prototypes.
8452 (struct iterator_stack_entry): New members bidi_p,
8453 paragraph_embedding, and from_disp_prop_p.
8454 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8455 (bidi_shelve_cache, bidi_unshelve_cache):
8456 Declare prototypes.
0bb23927
EZ
8457
8458 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8459 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8460 and vector-like objects.
8461
8462 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8463 cache around display iteration.
8464
8465 * window.c (Fwindow_end, window_scroll_pixel_based)
8466 (displayed_window_lines, Frecenter): Save and restore the bidi
8467 cache around display iteration.
8468
3bbd2265
LMI
84692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8470
8471 * editfns.c (Fdelete_region): Clarify the use of the named
8472 parameters (bug#6788).
8473
adc47434
MR
84742011-07-14 Martin Rudalics <rudalics@gmx.at>
8475
8476 * indent.c (Fvertical_motion): Set and restore w->pointm when
8477 saving and restoring the window's buffer (Bug#9006).
8478
837c31f8
LMI
84792011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8480
8481 * editfns.c (Fstring_to_char): Clarify just what is returned
8482 (bug#6576). Text by Eli Zaretskii.
8483
ac389d0c
JB
84842011-07-13 Juanma Barranquero <lekktu@gmail.com>
8485
8486 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8487
0be0ce47
EZ
84882011-07-13 Eli Zaretskii <eliz@gnu.org>
8489
8490 * buffer.c (mmap_find): Fix a typo.
8491
cd18e7e3
JB
84922011-07-13 Johan Bockgård <bojohan@gnu.org>
8493
8494 Fix execution of x selection hooks.
8495 * xselect.c (Qx_lost_selection_functions)
8496 (Qx_sent_selection_functions): New vars.
8497 (syms_of_xselect): DEFSYM them.
8498 (x_handle_selection_request): Pass Qx_sent_selection_functions
8499 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8500 (x_handle_selection_clear,x_clear_frame_selections):
8501 Pass Qx_lost_selection_functions rather than
8502 Vx_lost_selection_functions to Frun_hook_with_args.
8503
47ea7f44
PE
85042011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8505
ac389d0c 8506 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8507 The old code sometimes used this field without initializing it.
8508
47ea7f44
PE
8509 * alloc.c (gc_sweep): Don't read past end of array.
8510 In theory, the old code could also have corrupted Emacs internals,
8511 though it'd be very unlikely.
8512
bc985c87
AS
85132011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8514
8515 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8516 argument. (Bug#4026)
bc985c87 8517
0cf34688
LMI
85182011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8519
b3dadd76
LMI
8520 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8521 key" (bug#4257).
8522
0cf34688
LMI
8523 * window.c (Fset_window_start): Doc fix (bug#4199).
8524 (Fset_window_hscroll): Ditto.
8525
270768cd
PE
85262011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8527
077e3dda 8528 Fix minor new problems caught by GCC 4.6.1.
270768cd 8529 * term.c (init_tty): Remove unused local.
490011a6 8530 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8531 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8532 not used otherwise.
270768cd 8533
b1f58454
CY
85342011-07-12 Chong Yidong <cyd@stupidchicken.com>
8535
8536 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8537
22b9578d
LMI
85382011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8539
6e70ab07
LMI
8540 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8541 are the mini-buffer and the echo area (bug#3320).
8542
22b9578d
LMI
8543 * term.c (init_tty): Remove support for supdup, c10 and perq
8544 terminals, which are no longer supported (bug#1482).
8545
8974cc9f
JB
85462011-07-10 Johan Bockgård <bojohan@gnu.org>
8547
8548 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8549
a560d974
JD
85502011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8551
8552 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8553 for non-popups (Bug#3642).
8554
1dae0f0a
AS
85552011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8556
268c2c36 8557 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8558 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8559 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8560 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8561 * data.c (fmod): Likewise.
8562 * dispnew.c (swap_glyphs_in_rows): Likewise.
8563 * emacs.c (memory_warning_signal): Likewise.
8564 * floatfns.c (float_error): Likewise.
8565 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8566 (otf_open, font_otf_capability, generate_otf_features)
8567 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8568 Likewise.
8569 * image.c (pbm_read_file): Likewise.
8570 * indent.c (string_display_width): Likewise.
8571 * intervals.c (check_for_interval, search_for_interval)
8572 (inc_interval_count, count_intervals, root_interval)
8573 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8574 * lread.c (defalias): Likewise.
268c2c36 8575 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8576 * regex.c (set_image_of_range_1, set_image_of_range)
8577 (regex_grow_registers): Likewise.
8578 * sysdep.c (strerror): Likewise.
8579 * termcap.c (valid_filename_p, tprint, main): Likewise.
8580 * tparam.c (main): Likewise.
8581 * unexhp9k800.c (run_time_remap, save_data_space)
8582 (update_file_ptrs, read_header, write_header, calculate_checksum)
8583 (copy_file, copy_rest, display_header): Likewise.
8584 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8585 Likewise.
8586 * xdisp.c (check_it): Likewise.
8587 * xfaces.c (register_color, unregister_color, unregister_colors):
8588 Likewise.
8589 * xfns.c (print_fontset_result): Likewise.
8590 * xrdb.c (member, fatal, main): Likewise.
8591
99033785
PE
85922011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8593
8594 Fix minor problems found by static checking (Bug#9031).
8595 * chartab.c (char_table_set_range, map_sub_char_table):
8596 Remove unused locals.
8597 (uniprop_table): Now static.
8598 * composite.c (_work_char): Remove unused static var.
8599
9cb2ac56
JB
86002011-07-09 Juanma Barranquero <lekktu@gmail.com>
8601
8602 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8603
f25661f0
JD
86042011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8605
8606 * gtkutil.c (qttip_cb): Remove code without function.
8607
8278c4fe
EZ
86082011-07-09 Eli Zaretskii <eliz@gnu.org>
8609
8610 * w32.c (pthread_sigmask): New stub.
8611
1692ae2d 86122011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8613
8a6ebd58 8614 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8615 sigprocmask is portable only for single-threaded applications, and
8616 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8617 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8618 (LIBES): Use it.
8619 * callproc.c (Fcall_process):
8620 * process.c (create_process):
8621 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8622 Use pthread_sigmask, not sigprocmask.
123403e4 8623
1b854618
JD
86242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8625
8626 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8627 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8628 wrong (Bug#8591).
8629
3fe4b549
JD
86302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8631
0ce7e563
JD
8632 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8633 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8634 (xg_hide_tooltip): Fix comment.
8635
3fe4b549
JD
8636 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8637 in registerServicesMenuSendTypes.
8638 (validRequestorForSendType): Don't check ns_return_types.
8639
8640 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8641 ns_return_type.
8642
5df75e47
JR
86432011-07-08 Jason Rumney <jasonr@gnu.org>
8644
22610910
JR
8645 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8646 SH_SHOW for hidden windows (Bug#5482).
8647
5df75e47
JR
8648 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8649 frame struct members of non-existent frames (Bug#6284).
8650
699c10bd
JD
86512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8652
4393663b
JD
8653 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8654 variable firstTime not needed on OSX >= 10.6.
8655 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8656 >= 10.5. Use setKnobProportion, setDoubleValue.
8657
8658 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8659 (MAC_OS_X_VERSION_10_5): Define if not defined.
8660 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8661 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8662 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8663
8664 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8665 cString and lossyCString on OSX >= 10.4.
4393663b 8666
58179cce 8667 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8668 sizeToFit on OSX >= 10.2.
8669
8670 * nsimage.m (allocInitFromFile): Don't use deprecated method
8671 bestRepresentationForDevice on OSX >= 10.6.
8672
8673 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8674 to avoid warning.
8675
8676 * emacs.c: Declare unexec_init_emacs_zone.
8677
a63e0781
JD
8678 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8679
699c10bd
JD
8680 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8681
8682 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8683 on svcsMenu (Bug#8842).
8684
8685 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8686 ns_return_types.
8687 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8688
8689 * nsterm.m (QUTF8_STRING): Declare.
8690 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8691 (validRequestorForSendType): Return type is (id).
8692 Change indexOfObjectIdenticalTo to indexOfObject.
8693 Check if we have local selection before returning self (Bug#8842).
8694 (writeSelectionToPasteboard): Put local selection into paste board
8695 if we have a local selection (Bug#8842).
8696 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8697
8698 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8699 (ns_get_local_selection): Declare.
8700
54e10184
LMI
87012011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8702
9888ff71
LMI
8703 * keymap.c (describe_map_tree): Don't insert a double newline at
8704 the end of the buffer (bug#1169) and return whether we inserted
8705 something.
8706
54e10184
LMI
8707 * callint.c (Fcall_interactively): Change "reading args" to
8708 "providing args" to try to clarify what it does (bug#1010).
8709
15fa4783
KH
87102011-07-07 Kenichi Handa <handa@m17n.org>
8711
8712 * composite.c (composition_compute_stop_pos): Ignore a static
8713 composition starting before CHARPOS (Bug#8915).
8714
8715 * xdisp.c (handle_composition_prop): Likewise.
8716
a8815b00
EZ
87172011-07-07 Eli Zaretskii <eliz@gnu.org>
8718
8719 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8720 (Bug#9015)
8721
ef7b981d 87222011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8723
8724 * character.h (unicode_category_t): New enum type.
8725
8726 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8727 (Qchar_code_property_table): New variable.
8728 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8729 (UNIPROP_COMPRESSED_FORM_P): New macros.
8730 (char_table_ascii): Uncompress the compressed values.
8731 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8732 Uncompress the compressed values.
ac389d0c 8733 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8734 (char_table_ref_and_range): Uncompress the compressed values.
8735 (sub_char_table_set): New arg is_uniprop. Callers changed.
8736 Uncompress the compressed values.
8737 (sub_char_table_set_range): Args changed. Callers changed.
8738 (char_table_set_range): Adjuted for the above change.
8739 (map_sub_char_table): Delete args default_val and parent. Add arg
8740 top. Give decoded values to a Lisp function.
640c8776 8741 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8742 values to a Lisp function. Gcpro more variables.
8743 (uniprop_table_uncompress)
8744 (uniprop_decode_value_run_length): New functions.
8745 (uniprop_decoder, uniprop_decoder_count): New variables.
8746 (uniprop_get_decoder, uniprop_encode_value_character)
8747 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8748 New functions.
8749 (uniprop_encoder, uniprop_encoder_count): New variables.
8750 (uniprop_get_encoder, uniprop_table)
8751 (Funicode_property_table_internal, Fget_unicode_property_internal)
8752 (Fput_unicode_property_internal): New functions.
8753 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8754 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8755 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8756 char-code-property-alist.
8757
640c8776 8758 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8759 Vunicode_category_table.
8760
640c8776 8761 * font.c (font_range): Adjust for the change of
c805dec0
KH
8762 Vunicode_category_table.
8763
76b397fb
DN
87642011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8765
8766 * m/iris4d.h: Remove file, move contents ...
8767 * s/irix6-5.h: ... here.
8768
22b4128e
PE
87692011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8770
8771 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8772 * alloc.c (mark_buffer):
8773 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8774 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8775 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8776 This isn't true in general, and it's particularly not true
8777 if Emacs is configured with --with-wide-int.
8778 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8779 New macros, used in the buffer.c change.
8780
869795d6
JD
87812011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8782
8783 * xsettings.c: Use both GConf and GSettings if both are available.
8784 (store_config_changed_event): Add comment.
8785 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8786 (store_tool_bar_style_changed): New functions.
5e617bc2 8787 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8788 (struct xsettings): Move font inside HAVE_XFT.
8789 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8790 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8791 Move inside HAVE_XFT.
640c8776 8792 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8793 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8794 also.
8795 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8796 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8797 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8798 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8799 (parse_settings): Move check for font inside HAVE_XFT.
8800 (read_settings, apply_xft_settings): Add comment.
8801 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8802 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8803 call store_font_name_changed.
8804 (xft_settings_event): Add comment.
8805 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8806 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8807 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8808 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8809 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8810 (xsettings_get_system_font, xsettings_get_system_normal_font):
8811 Add comment.
869795d6 8812
d8ed26bd
PE
88132011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8814
8815 Random fixes. E.g., (random) never returned negative values.
8816 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8817 subseconds part to the entropy, as that's a bit more random.
8818 Prefer signed to unsigned, since the signedness doesn't matter and
8819 in general we prefer signed. When given a limit, use a
8820 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8821 latter isn't right if USE_2_TAGS_FOR_INTS.
8822 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8823 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8824
cabf1cac
SM
88252011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8826
8827 * textprop.c (text_property_stickiness):
8828 Obey Vtext_property_default_nonsticky.
8829 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8830 * w32fns.c (syms_of_w32fns):
8831 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8832
6e9b2be9
PE
88332011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8834
8835 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8836 This is more efficient than Ffile_directory_p and avoids a minor race.
8837
90186c68
LMI
88382011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8839
7c301272
LMI
8840 * buffer.c (Foverlay_put): Say what the return value is
8841 (bug#7835).
8842
c4f2d8d4
LMI
8843 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8844 is a directory before asking whether to use the file name
8845 (bug#7564).
ad637907
LMI
8846 (barf_or_query_if_file_exists): Make the "File is a directory"
8847 error be more correct.
c4f2d8d4 8848
90186c68
LMI
8849 * fns.c (Frequire): Remove the mention of the .gz files, since
8850 that's installation-specific, but keep the mention of
8851 `get-load-suffixes'.
8852
da64016e
PE
88532011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8854
8855 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8856 Report string overflow if the output is too long.
8857
7d47b580
JB
88582011-07-04 Juanma Barranquero <lekktu@gmail.com>
8859
a555cb87
JB
8860 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8861 (syms_of_gnutls): Remove duplicate DEFSYM for
8862 Qgnutls_bootprop_verify_hostname_error, an error for
8863 Qgnutls_bootprop_verify_error (which is no longer used).
8864
7d47b580
JB
8865 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8866 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8867 Also (re)move comments that are misplaced or no longer relevant.
8868
1e49bfab
LMI
88692011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8870
8871 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8872
1485f4c0
CY
88732011-07-03 Chong Yidong <cyd@stupidchicken.com>
8874
8875 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8876 and background color parameters if they have been changed.
8877
a9ab721e
LMI
88782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8879
8880 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8881
cf7cff57
PE
88822011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8883
2e13213d
PE
8884 * xsettings.c (SYSTEM_FONT): Define only when used.
8885 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8886
cf7cff57
PE
8887 * keymap.c (access_keymap_1): Now static.
8888
7a8e04f7
CY
88892011-07-02 Chong Yidong <cyd@stupidchicken.com>
8890
8891 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8892 leave any prefix arg for the up event (Bug#1586).
8893
61352f62
LMI
88942011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8895
69bb1ef7
LMI
8896 * lread.c (syms_of_lread): Mention single symbols defined by
8897 `defvar' or `defconst' (bug#7154).
8898
61352f62 8899 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8900 (Frequire): Mention get-load-suffixes.
61352f62 8901
28545e04
MR
89022011-07-02 Martin Rudalics <rudalics@gmx.at>
8903
8904 * window.h (window): Remove clone_number slot.
8905 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8906 Remove.
8907 (make_parent_window, make_window, saved_window)
8908 (Fset_window_configuration, save_window_save): Don't deal with
8909 clone numbers.
8910 * buffer.c (Qclone_number): Remove declaration.
8911 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8912
3349e122
SM
89132011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8914
8915 Add multiple inheritance to keymaps.
8916 * keymap.c (Fmake_composed_keymap): New function.
8917 (Fset_keymap_parent): Simplify.
8918 (fix_submap_inheritance): Remove.
8919 (access_keymap_1): New function extracted from access_keymap to handle
8920 embedded parents and handle lists of maps.
8921 (access_keymap): Use it.
8922 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8923 (Fcopy_keymap): Handle embedded parents.
8924 (Fcommand_remapping, define_as_prefix): Simplify.
8925 (Fkey_binding): Simplify.
8926 (syms_of_keymap): Move minibuffer-local-completion-map,
8927 minibuffer-local-filename-completion-map,
8928 minibuffer-local-must-match-map, and
8929 minibuffer-local-filename-must-match-map to Elisp.
8930 (syms_of_keymap): Defsubr make-composed-keymap.
8931 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8932 (parse_menu_item): Trivial simplification.
8933
3279eb87
GM
89342011-07-01 Glenn Morris <rgm@gnu.org>
8935
8936 * Makefile.in (SETTINGS_LIBS): Fix typo.
8937
4550efdf
KI
89382011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8939
8940 * coding.c (Fencode_coding_string): Record the last coding system
8941 used, as the function doc string says (bug#8738).
8942
0949d2b6
JD
89432011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8944
8945 * xsettings.c (store_monospaced_changed): Take new font as arg and
8946 check for change against current_mono_font.
8947 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8948 (emacs_settings_constructor, emacs_settings_get_property)
8949 (emacs_settings_set_property, emacs_settings_class_init)
8950 (emacs_settings_init, gsettings_obj): Remove.
8951 (something_changedCB): New function for HAVE_GSETTINGS.
8952 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8953 with value as argument.
8954 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8955 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8956 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8957 "changed".
8958
8959 * xgselect.c: Add defined (HAVE_GSETTINGS).
8960 (xgselect_initialize): Ditto.
8961
8962 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8963 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8964 xg_select.
8965
bbc6b304
PE
89662011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8967
8968 * eval.c (struct backtrace): Simplify and port the data structure.
8969 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8970 signed bit field, as this assumption is not portable and it makes
8971 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8972 "char debug_on_exit : 1" as this is not portable either; instead,
8973 use the portable "unsigned int debug_on_exit : 1". Remove unused
8974 member evalargs. Remove obsolete comments about cc bombing out.
8975
9851bfc5
JD
89762011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8977
51bb811f 8978 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8979 Let HAVE_GSETTINGS override HAVE_GCONF.
8980 (store_monospaced_changed): New function.
8981 (EMACS_SETTINGS): A new type derived from GObject to handle
8982 GSettings notifications.
8983 (emacs_settings_constructor, emacs_settings_get_property)
8984 (emacs_settings_set_property, emacs_settings_class_init):
8985 New functions.
8986 (gsettings_client, gsettings_obj): New variables.
8987 (GSETTINGS_SCHEMA): New define.
8988 (something_changedCB): Call store_monospaced_changed.
8989 (init_gsettings): New function.
8990 (xsettings_initialize): Call init_gsettings.
8991 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8992 to NULL.
8993
640c8776 8994 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8995 GCONF_CFLAGS/LIBS.
8996
5386012d
MR
89972011-06-29 Martin Rudalics <rudalics@gmx.at>
8998
8999 * window.c (resize_root_window, grow_mini_window)
9000 (shrink_mini_window): Rename Qresize_root_window to
9001 Qwindow_resize_root_window and Qresize_root_window_vertically to
9002 Qwindow_resize_root_window_vertically.
9003
f13e0b08
PE
90042011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9005
9006 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9007
94515237
JB
90082011-06-27 Juanma Barranquero <lekktu@gmail.com>
9009
9010 * makefile.w32-in: Redesign dependencies so they reflect more
9011 clearly which files are directly included by each source file,
9012 and not through other includes.
9013
e43b6e43
MR
90142011-06-27 Martin Rudalics <rudalics@gmx.at>
9015
9016 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9017 (sort_overlays, overlay_strings): When an overlay's clone number
9018 matches the window's clone number process the overlay even if
9019 the overlay's window property doesn't match the current window.
9020
d68443dc
MR
9021 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9022 (Fwindow_hchild): Rename to Fwindow_left_child.
9023 (Fwindow_next): Rename to Fwindow_next_sibling.
9024 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9025 (resize_window_check): Rename to window_resize_check.
9026 (resize_window_apply): Rename to window_resize_apply.
9027 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9028 (Fdelete_other_windows_internal, resize_frame_windows)
9029 (Fsplit_window_internal, Fdelete_window_internal)
9030 (grow_mini_window, shrink_mini_window)
9031 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9032
c7e73be5
JD
90332011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9034
9035 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9036 (emacs_fixed_set_min_size): Remove.
9037 (emacs_fixed_new): Take frame as argument.
9038
9039 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9040 (_EmacsFixedPrivate): Remove minwidth/height.
9041 Add struct frame *f.
9042 (emacs_fixed_init): Initialize priv->f.
9043 (get_parent_class, emacs_fixed_set_min_size): Remove.
9044 (emacs_fixed_new): Set priv->f to argument.
9045 (emacs_fixed_get_preferred_width)
9046 (emacs_fixed_get_preferred_height): Use min_width/height from
9047 frames size_hint to set minimum and natural (Bug#8919).
9048 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9049 and use min_width/height from frames size_hint to set
9050 min_width/height (Bug#8919).
9051
9052 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9053 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9054 Fix indentation.
c7e73be5 9055
cf99dcf8
EZ
90562011-06-26 Eli Zaretskii <eliz@gnu.org>
9057
9058 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9059 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9060 called at ZV.
9061
029529ac
CY
90622011-06-26 Chong Yidong <cyd@stupidchicken.com>
9063
9064 * process.c (wait_reading_process_output): Bypass select if
9065 waiting for a cell while ignoring keyboard input, and input is
9066 pending. Suggested by Jan Djärv (Bug#8869).
9067
7a7ef429
PE
90682011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9069
9070 Use gnulib's dup2 module instead of rolling our own.
9071 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9072
11fdef7d 90732011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9074
9075 * dispnew.c (scrolling_window): Before scrolling, turn off a
9076 mouse-highlight in the window being scrolled.
9077
cd3520a4
JB
90782011-06-24 Juanma Barranquero <lekktu@gmail.com>
9079
9080 Move DEFSYM to lisp.h and use everywhere.
9081
9082 * character.h (DEFSYM): Move declaration...
9083 * lisp.h (DEFSYM): ...here.
9084
9085 * gnutls.c:
9086 * minibuf.c:
9087 * w32menu.c:
9088 * w32proc.c:
9089 * w32select.c: Don't include character.h.
9090
9091 * alloc.c (syms_of_alloc):
9092 * buffer.c (syms_of_buffer):
9093 * bytecode.c (syms_of_bytecode):
9094 * callint.c (syms_of_callint):
9095 * casefiddle.c (syms_of_casefiddle):
9096 * casetab.c (init_casetab_once):
9097 * category.c (init_category_once, syms_of_category):
9098 * ccl.c (syms_of_ccl):
9099 * cmds.c (syms_of_cmds):
9100 * composite.c (syms_of_composite):
9101 * dbusbind.c (syms_of_dbusbind):
9102 * dired.c (syms_of_dired):
9103 * dispnew.c (syms_of_display):
9104 * doc.c (syms_of_doc):
9105 * editfns.c (syms_of_editfns):
9106 * emacs.c (syms_of_emacs):
9107 * eval.c (syms_of_eval):
9108 * fileio.c (syms_of_fileio):
9109 * fns.c (syms_of_fns):
9110 * frame.c (syms_of_frame):
9111 * fringe.c (syms_of_fringe):
9112 * insdel.c (syms_of_insdel):
9113 * keymap.c (syms_of_keymap):
9114 * lread.c (init_obarray, syms_of_lread):
9115 * macros.c (syms_of_macros):
9116 * msdos.c (syms_of_msdos):
9117 * print.c (syms_of_print):
9118 * process.c (syms_of_process):
9119 * search.c (syms_of_search):
9120 * sound.c (syms_of_sound):
9121 * syntax.c (init_syntax_once, syms_of_syntax):
9122 * terminal.c (syms_of_terminal):
9123 * textprop.c (syms_of_textprop):
9124 * undo.c (syms_of_undo):
9125 * w32.c (globals_of_w32):
9126 * window.c (syms_of_window):
9127 * xdisp.c (syms_of_xdisp):
9128 * xfaces.c (syms_of_xfaces):
9129 * xfns.c (syms_of_xfns):
9130 * xmenu.c (syms_of_xmenu):
9131 * xsettings.c (syms_of_xsettings):
9132 * xterm.c (syms_of_xterm): Use DEFSYM.
9133
4228cf16
TZ
91342011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9135
cd3520a4 9136 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9137
7fcccf1e
PE
91382011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9139
7efb4e0e
PE
9140 Integer and buffer overflow fixes (Bug#8873).
9141
ff5844ad
PE
9142 * print.c (printchar, strout): Check for string overflow.
9143 (PRINTPREPARE, printchar, strout):
9144 Don't set size unless allocation succeeds.
9145
90532f02
PE
9146 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9147 for sizes. Check for string overflow more accurately.
9148 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9149
6d84508d
PE
9150 * macros.c: Integer and buffer overflow fixes.
9151 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9152 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9153 Use ptrdiff_t, not int, for sizes.
9154 Don't increment bufsize until after realloc succeeds.
9155 Check for size-calculation overflow.
9156 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9157
437b2cb4
PE
9158 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9159
8b9ac8b4
PE
9160 * lread.c: Integer overflow fixes.
9161 (read_integer): Radix is now EMACS_INT, not int,
9162 to improve quality of diagnostics for out-of-range radices.
9163 Calculate buffer size correctly for out-of-range radices.
9164 (read1): Check for integer overflow in radices, and in
9165 read-circle numbers.
82cb60d3
PE
9166 (read_escape): Avoid int overflow.
9167 (Fload, openp, read_buffer_size, read1)
9168 (substitute_object_recurse, read_vector, read_list, map_obarray):
9169 Use ptrdiff_t, not int, for sizes.
9170 (read1): Use EMACS_INT, not int, for sizes.
20270765 9171 Check for size overflow.
8b9ac8b4 9172
7fcccf1e
PE
9173 * image.c (cache_image): Check for size arithmetic overflow.
9174
bfbbd7e7
PE
9175 * lread.c: Integer overflow issues.
9176 (saved_doc_string_size, saved_doc_string_length)
9177 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9178 Now ptrdiff_t, not int.
9179 (read1): Don't assume doc string length fits in int. Check for
9180 out-of-range doc string lengths.
9181 (read_list): Don't assume file position fits in int.
39019e54 9182 (read_escape): Check for hex character overflow.
bfbbd7e7 9183
4e323265
LL
91842011-06-22 Leo Liu <sdl.web@gmail.com>
9185
9186 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9187 Move to minibuffer.el.
9188
85fece3e
PE
91892011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9190
20b84ce9 9191 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9192 The following patches are for when GLYPH_DEBUG && !XASSERT.
9193 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9194 * dispnew.c (flush_stdout):
9195 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9196 Mark as externally visible.
9197 * dispnew.c (check_window_matrix_pointers): Now static.
9198 * dispnew.c (window_to_frame_vpos):
9199 * xfns.c (unwind_create_frame):
9200 * xterm.c (x_check_font): Remove unused local.
9201 * scroll.c (CHECK_BOUNDS):
9202 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9203 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9204 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9205 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9206 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9207 Now static.
9208 (debug_method_add): Use va_list and vsprintf rather than relying
9209 on undefined behavior with wrong number of arguments.
9210 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9211 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9212 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9213 since we're not interested in debugging glyphs with old libraries.
9214 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9215 GCC 4.6.0's static checking.
9216
0766b489
PE
92172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9218
31fd4b32
PE
9219 Integer overflow and signedness fixes (Bug#8873).
9220 A few related buffer overrun fixes, too.
9221
b79e8648
PE
9222 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9223
0766b489
PE
9224 * dispextern.h (struct face.stipple):
9225 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9226 (x_bitmap_mask, x_allocate_bitmap_record)
9227 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9228 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9229 (x_create_bitmap_from_xpm_data):
9230 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9231 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9232 (.bitmaps_last):
9233 * xfaces.c (load_pixmap):
9234 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9235 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9236 (.bitmaps_last, struct x_output.icon_bitmap):
9237 Use ptrdiff_t, not int, for bitmap indexes.
9238 (x_allocate_bitmap_record): Check for size overflow.
9239 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9240
b081724f
PE
9241 Use ptrdiff_t, not int, for overlay counts.
9242 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9243 * editfns.c (overlays_around, get_pos_property):
9244 * textprop.c (get_char_property_and_overlay):
9245 * xdisp.c (next_overlay_change, note_mouse_highlight):
9246 * xfaces.c (face_at_buffer_position):
21514da7
PE
9247 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9248 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9249 (Fnext_overlay_change, Fprevious_overlay_change)
9250 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9251 Use ptrdiff_t, not int, for sizes.
21514da7 9252 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9253
3de73e5e
PE
9254 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9255
2606c57b
PE
9256 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9257 (x_session_initialize): Do not assume string length fits in int.
9258
aaafe47a
PE
9259 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9260 This is unlikely, but can occur if DPI is outlandish.
9261
2674ddc8 9262 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9263 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9264
28154962
PE
9265 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9266 * xrdb.c (magic_file_p, search_magic_path):
9267 Omit last arg SUFFIX; it was always 0. All callers changed.
9268 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9269
7de51af5
PE
9270 * xfont.c (xfont_match): Avoid need for strlen.
9271
25ed6cc3
PE
9272 * xfns.c: Don't assume strlen fits in int.
9273 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9274
4eab31dd
PE
9275 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9276 not unsigned long, as we prefer signed integers. All callers changed.
9277 Detect integer overflow in repeat count.
9278 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9279 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9280
171e2a58
PE
9281 * termcap.c: Don't assume sizes fit in int and never overflow.
9282 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9283 (gobble_line): Check for size-calculation overflow.
9284
ad39faca 9285 * minibuf.c (Fread_buffer):
6e5bb2dc 9286 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9287 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9288 Don't assume string length fits in int.
9289
52c61c22 9290 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9291 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9292
b5b8c9e5
PE
9293 * font.c: Don't assume string length fits in int.
9294 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9295 Use ptrdiff_t, not int.
ccd6111c
PE
9296 (font_intern_prop): Don't assume string length fits in int.
9297 Don't assume integer property fits in fixnum.
9298 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9299
882f0d81 9300 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9301 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9302 Reformulate so as not to need the command string.
9303 Invoke gzip -cd rather than gunzip, as it's more portable.
9304 (lock_info_type, lock_file_1, lock_file):
9305 Don't assume pid_t and time_t fit in unsigned long.
9306 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9307 (current_lock_owner): Prefer signed type for sizes.
9308 Use memcpy, not strncpy, where memcpy is what is really wanted.
9309 Don't assume (via atoi) that time_t and pid_t fit in int.
9310 Check for time_t and/or pid_t out of range, e.g., via a network share.
9311 Don't alloca where an auto var works fine.
9312
93f4cf88
PE
9313 * fileio.c: Fix some integer overflow issues.
9314 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9315 Don't assume string length fits in int.
9316 (directory_file_name): Don't assume string length fits in long.
9317 (make_temp_name): Don't assume pid fits in int, or that its print
9318 length is less than 20.
9319
f3e92b69
PE
9320 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9321
1bfdaf10
PE
9322 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9323
35016e9a
PE
9324 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9325
3d1e65a1
PE
9326 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9327 We prefer signed integers, even for size calculations.
9328
0b963a93
PE
9329 * emacs.c: Don't assume string length fits in 'int'.
9330 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9331 (main): Don't invoke strlen when not needed.
9332
573f4b54
PE
9333 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9334 (XD_DEBUG_MESSAGE): Don't waste a byte.
9335
989f33ba
PE
9336 * callproc.c (getenv_internal_1, getenv_internal)
9337 (Fgetenv_internal):
965d34eb
PE
9338 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9339
e4d29b33
PE
9340 * lread.c (invalid_syntax): Omit length argument.
9341 All uses changed. This doesn't fix a bug, but it simplifies the
9342 code away from its former Hollerith-constant appearance, and it's
9343 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9344 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9345
eb49b136
PE
9346 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9347 This didn't break anything, but it didn't help either.
9348 It's confusing to put a bogus integer in a place where the actual
9349 value does not matter.
9f62aeb1 9350 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9351 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9352
15375a22
PE
9353 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9354 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9355 implementation.
b61cc01c
PE
9356 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9357 We prefer signed types, and the value cannot exceed the EMACS_INT
9358 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9359 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9360 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9361 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9362
53b2623d
PE
9363 * indent.c (sane_tab_width): New function.
9364 (current_column, scan_for_column, Findent_to, position_indentation)
9365 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9366 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9367
51cab52b 9368 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9369
f2ed8a70
PE
9370 * lisp.h (lint_assume): New macro.
9371 * composite.c (composition_gstring_put_cache):
9372 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9373
abe80cc6
PE
9374 * editfns.c, insdel.c:
9375 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9376
b02c740e
PE
9377 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9378
ebc96716
PE
9379 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9380
b4e50fa0 9381 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9382 Use much-faster test for byte-length change.
311d5d7c 9383 Don't assume string byte-length fits in 'int'.
a4cf38e4 9384 Check that character arg fits in 'int'.
85461888 9385 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9386
c0c1ee9f
PE
9387 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9388
a498d7f4
PE
9389 * fns.c (concat): Catch string overflow earlier.
9390 Do not rely on integer wraparound.
9391
51cab52b
PE
9392 * dispextern.h (struct it.overlay_strings_charpos)
9393 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9394 * xdisp.c (forward_to_next_line_start)
9395 (back_to_previous_visible_line_start)
9396 (reseat_at_next_visible_line_start, next_element_from_buffer):
9397 Don't arbitrarily truncate the value of 'selective' to int.
9398
76031fad
PE
9399 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9400
5eb55db9
PE
9401 * composite.c: Don't truncate sizes to 'int'.
9402 (composition_gstring_p, composition_reseat_it)
9403 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9404 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9405 not EMACS_UINT, for indexes.
5eb55db9 9406
0703a717
PE
9407 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9408
d6202519
PE
9409 * buffer.c: Include <verify.h>.
9410 (struct sortvec.priority, struct sortstr.priority):
8961a454 9411 Now EMACS_INT, not int.
c20998a7 9412 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9413 (struct sortstr.size, record_overlay_string)
9414 (struct sortstrlist.size, struct sortlist.used):
9415 Don't truncate size to int.
9416 (record_overlay_string): Check for size-calculation overflow.
d6202519 9417 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9418
d5a19415
JM
94192011-06-22 Jim Meyering <meyering@redhat.com>
9420
029529ac 9421 Don't leak an XBM-image-sized buffer
d5a19415
JM
9422 * image.c (xbm_load): Free the image buffer after using it.
9423
a9041e6c
PE
94242011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9425
9426 Port to Sun C.
9427 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9428 that Sun C diagnosed.
9429 * fns.c (secure_hash): Fix pointer signedness issue.
9430 * intervals.c (static_offset_intervals): New function.
9431 (offset_intervals): Use it.
9432
7f3f739f
LL
94332011-06-21 Leo Liu <sdl.web@gmail.com>
9434
9435 * deps.mk (fns.o):
9436 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9437 sha512.h.
9438
9439 * fns.c (secure_hash): Rename from crypto_hash_function and change
9440 the first arg to accept symbols.
5b66d427 9441 (Fsecure_hash): New primitive.
7f3f739f
LL
9442 (syms_of_fns): New symbols.
9443
76147d94
DD
94442011-06-20 Deniz Dogan <deniz@dogan.se>
9445
9446 * process.c (Fset_process_buffer): Clarify return value in
9447 docstring.
9448
7d7d0045
CY
94492011-06-18 Chong Yidong <cyd@stupidchicken.com>
9450
9451 * dispnew.c (add_window_display_history): Use BVAR.
9452
9453 * xdisp.c (debug_method_add): Use BVAR.
9454 (check_window_end, dump_glyph_matrix, dump_glyph)
9455 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9456
9457 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9458 Likewise.
9459
9460 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9461 check till after the cache is created in init_frame_faces.
9462
ff2bc410
SM
94632011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9464
9465 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9466
28177add
PE
94672011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9468
dd3482fe
PE
9469 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9470 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9471 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9472
393d71f3 9473 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9474 * fileio.c (Finsert_file_contents):
9475 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9476 Remove the old (too-loose) buffer overflow checks.
9477 They weren't needed, since make_gap checks for buffer overflow.
9478 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9479 The old code merely checked for Emacs fixnum overflow, and relied
9480 on undefined (wraparound) behavior. The new code avoids undefined
9481 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9482
2e6813b0 9483 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9484 Tune. Don't use wider integers than needed. Don't use alloca.
9485 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9486
599a9e4f
PE
9487 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9488
99561444
PE
9489 * insdel.c, lisp.h (buffer_overflow): New function.
9490 (insert_from_buffer_1, replace_range, replace_range_2):
9491 * insdel.c (make_gap_larger):
9492 * editfns.c (Finsert_char):
9493 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9494
28177add
PE
9495 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9496
e69dafad
PE
94972011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9498
4baa020d 9499 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9500
b1c46f02
PE
9501 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9502 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9503
e69dafad
PE
9504 * fileio.c: Don't assume EMACS_INT fits in off_t.
9505 (emacs_lseek): New static function.
9506 (Finsert_file_contents, Fwrite_region): Use it.
9507 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9508
566684ea
PE
9509 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9510
e6966cd6
PE
9511 * fns.c: Don't overflow int when computing a list length.
9512 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9513 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9514 truncation on 64-bit hosts. Check for QUIT every
9515 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9516 faster and is responsive enough.
9517 (Flength): Report an error instead of overflowing an integer.
9518 (Fsafe_length): Return a float if the value is not representable
9519 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9520 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9521 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9522
dd0b0efb
PE
9523 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9524 (header_size, word_size): New constants.
9525 (allocate_vectorlike): Don't check size overflow here.
9526 (allocate_vector): Check it here instead, since this is the only
9527 caller of allocate_vectorlike that could cause overflow.
9528 Check that the new vector's length is representable as a fixnum.
9529
86fe5cfe
PE
9530 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9531 The previous code was bogus. For example, next_almost_prime (32)
9532 returned 39, which is undesirable as it is a multiple of 3; and
9533 next_almost_prime (24) returned 25, which is a multiple of 5 so
9534 why was the code bothering to check for multiples of 7?
9535
80e88859
PE
9536 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9537
4a2f0ad6
PE
9538 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9539
f66c7cf8
PE
9540 Variadic C functions now count arguments with ptrdiff_t.
9541 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9542 Back then I didn't know that the Emacs coding style prefers signed int.
9543 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9544 were being counted with int, which may truncate counts on 64-bit
9545 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9546 * lisp.h (struct Lisp_Subr.function.aMANY)
9547 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9548 Arg counts are now ptrdiff_t, not size_t.
9549 All variadic functions and their callers changed accordingly.
9550 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9551 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9552 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9553 * callint.c (Fcall_interactively): Check arg count for overflow,
9554 to avoid potential buffer overrun. Use signed char, not 'int',
9555 for 'varies' array, so that we needn't bother to check its size
9556 calculation for overflow.
9557 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9558 * eval.c (apply_lambda):
9559 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9560 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9561 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9562
a1759b76
PE
9563 * callint.c (Fcall_interactively): Don't use index var as event count.
9564
d96be9fc
PE
9565 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9566 * mem-limits.h (SIZE): Remove; no longer used.
9567
a690a978 9568 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9569
578c21e6
PE
9570 Remove unnecessary casts.
9571 * xterm.c (x_term_init):
9572 * xfns.c (x_set_border_pixel):
9573 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9574 These aren't needed now that we assume ANSI C.
9575
96f53c6c
PE
9576 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9577 It's more likely to cause problems (due to unsigned overflow)
9578 than to cure them.
9579
83c77d31
PE
9580 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9581
ee2079f1
PE
9582 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9583
6da65536
PE
9584 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9585
7147c4a4
PE
9586 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9587
193e32d9
PE
9588 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9589
e5533da6
PE
9590 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9591
9910e595
PE
9592 GLYPH_CODE_FACE returns EMACS_INT, not int.
9593 * dispextern.h (merge_faces):
9594 * xfaces.c (merge_faces):
01103c44
PE
9595 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9596 Don't assume EMACS_INT fits in int.
9910e595 9597
2638320e
PE
9598 * character.h (CHAR_VALID_P): Remove unused parameter.
9599 * fontset.c, lisp.h, xdisp.c: All uses changed.
9600
045eb8d9
PE
9601 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9602
c1f134b5
PE
9603 * fns.c (concat): Minor tuning based on overflow analysis.
9604 This doesn't fix any bugs. Use int to hold character, instead
9605 of constantly refetching from Emacs object. Use XFASTINT, not
9606 XINT, for value known to be a character. Don't bother comparing
9607 a single byte to 0400, as it's always less.
9608
395fcb93 9609 * floatfns.c (Fexpt):
327eeec8
PE
9610 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9611
abbd3d23
PE
9612 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9613 for characters.
9614
684a03ef
PE
9615 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9616
0fed43f3
PE
9617 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9618 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9619 incorrectly succeed when S was a string, because 4294967386 was
9620 truncated before it was used.
9621
8fd02eb7
PE
9622 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9623 Otherwise, an out-of-range integer could cause undefined behavior
9624 on a 64-bit host.
9625
f8c86b69
PE
9626 * composite.c: Use int, not EMACS_INT, for characters.
9627 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9628 EMACS_INT, for values that are known to be in character range.
9629 This doesn't fix any bugs but is the usual style inside Emacs and
9630 may generate better code on 32-bit machines.
9631
34206dd2
PE
9632 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9633 This is for reasons similar to the recent CHAR_STRING fix.
9634 * charset.c (Fencode_char): Check that character arg is actually
9635 a character. Pass an int to ENCODE_CHAR.
9636 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9637 wider than 'int', as a compile-time check to prevent future regressions
9638 in this area.
9639
c5958d4c 9640 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9641
9642 Make sure a 64-bit char is never passed to CHAR_STRING.
9643 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9644 by silently ignoring the top 32 bits, allowing some values
9645 that were far too large to be valid characters.
9646 * character.h: Include <verify.h>.
9647 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9648 arguments are no wider than unsigned, as a compile-time check
9649 to prevent future regressions in this area.
9650 * data.c (Faset):
01103c44 9651 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9652 (Fsubst_char_in_region):
9653 * fns.c (concat):
9654 * xdisp.c (decode_mode_spec_coding):
9655 Adjust to CHAR_STRING's new requirement.
9656 * editfns.c (Finsert_char, Fsubst_char_in_region):
9657 * fns.c (concat): Check that character args are actually
9658 characters. Without this test, these functions did the wrong
9659 thing with wildly out-of-range values on 64-bit hosts.
9660
d37ca623
PE
9661 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9662 These casts should not be needed on 32-bit hosts, either.
9663 * keyboard.c (read_char):
9664 * lread.c (Fload): Remove casts to unsigned.
9665
ea204efb
PE
9666 * lisp.h (UNSIGNED_CMP): New macro.
9667 This fixes comparison bugs on 64-bit hosts.
9668 (ASCII_CHAR_P): Use it.
9669 * casefiddle.c (casify_object):
01103c44 9670 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9671 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9672 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9673 * dispextern.h (FACE_FROM_ID):
9674 * keyboard.c (read_char): Use UNSIGNED_CMP.
9675
41cb286c
PE
9676 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9677 not to EMACS_INT, to avoid GCC warning.
9678
4a1b9832
PE
9679 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9680
55daad71
PE
9681 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9682 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9683 isn't needed on 32-bit machines.
8f95c75c 9684
01103c44
PE
9685 * buffer.c (Fgenerate_new_buffer_name):
9686 Use EMACS_INT for count, not int.
0ceccced 9687 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9688
9689 * data.c (Qcompiled_function): Now static.
9690
c6f072e7
PE
9691 * window.c (window_body_lines): Now static.
9692
20ce5912
PE
9693 * image.c (gif_load): Rename local to avoid shadowing.
9694
9c4c5f81
PE
9695 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9696 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9697 * alloc.c (make_save_value): Integer argument is now of type
9698 ptrdiff_t, not int.
9699 (mark_object): Use ptrdiff_t, not int.
9700 * lisp.h (pD): New macro.
9701 * print.c (print_object): Use it.
9702
c0c5c8ae
PE
9703 * alloc.c: Use EMACS_INT, not int, to count objects.
9704 (total_conses, total_markers, total_symbols, total_vector_size)
9705 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9706 (total_free_floats, total_floats, total_free_intervals)
9707 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9708 Now EMACS_INT, not int. All uses changed.
9709 (Fgarbage_collect): Compute overall total using a double, so that
9710 integer overflow is less likely to be a problem. Check for overflow
9711 when converting back to an integer.
5a25e253
PE
9712 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9713 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9714 These were 'int' variables that could overflow on 64-bit hosts;
9715 they were never used, so remove them instead of repairing them.
211a0b2a 9716 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9717 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9718 Previously, this ceilinged at INT_MAX, but that doesn't work on
9719 64-bit machines.
e46bb31a 9720 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9721
c78baabf 9722 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9723 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9724 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9725 when a (possibly-narrower) signed value would do just as well.
9726 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9727
c9d624c6
PE
9728 * alloc.c: Catch some string size overflows that we were missing.
9729 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9730 for convenience in STRING_BYTES_MAX.
9731 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9732 The definition here is exact; the one in lisp.h was approximate.
9733 (allocate_string_data): Check for string overflow. This catches
9734 some instances we weren't catching before. Also, it catches
9735 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9736 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9737 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9738
c9d624c6
PE
9739 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9740 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9741 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9742
353032ce
PE
9743 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9744
2bccce07
PE
9745 * alloc.c (Fmake_string): Check for out-of-range init.
9746
0ac30604
SM
97472011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9748
9749 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9750
c195f2de
JD
97512011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9752
9753 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9754 xg_get_default_scrollbar_width.
9755
9756 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9757 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9758 (style_changed_cb): Call update_theme_scrollbar_width and call
9759 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9760 all frames (Bug#8505).
9761 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9762 Call gtk_window_set_resizable if HAVE_GTK3.
9763 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9764 and height if HAVE_GTK3 (Bug#8505).
9765 (scroll_bar_width_for_theme): New variable.
9766 (update_theme_scrollbar_width): New function.
9767 (xg_get_default_scrollbar_width): Move code to
9768 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9769 (xg_initialize): Call update_theme_scrollbar_width.
9770
9771 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9772
9773 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9774
e10ac9f1
MR
97752011-06-12 Martin Rudalics <rudalics@gmx.at>
9776
9777 * frame.c (make_frame): Call other_buffer_safely instead of
9778 other_buffer.
9779
9780 * window.c (temp_output_buffer_show): Call display_buffer with
9781 second argument Vtemp_buffer_show_specifiers and reset latter
9782 immediately after the call.
9783 (Vtemp_buffer_show_specifiers): New variable.
9784 (auto_window_vscroll_p, next_screen_context_lines)
9785 (Vscroll_preserve_screen_position): Remove leading asterisks from
9786 doc-strings.
9787
2d3c217e 97882011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9789
7b7f97e8 9790 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9791 * buffer.c (Qclone_number): Remove for now, as it's unused.
9792 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9793 (record_buffer): Remove unused local.
9794 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9795 (set_frame_buffer_list): Remove; unused.
9796 * frame.h (other_visible_frames): Remove decl.
9797 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9798 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9799 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9800 if HAVE_GPM.
9801 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9802 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9803 Define only if HAVE_GPM.
9804 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9805 (update_hints_inhibit): Remove; never set. All uses removed.
9806 * widgetprv.h (emacsFrameClassRec): Remove decl.
9807 * window.c (delete_deletable_window): Now returns void, since it
9808 wasn't returning anything.
9809 (compare_window_configurations): Remove unused locals.
9810 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9811 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9812 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9813 the same widths as pointers. This follows up on the 2011-05-06 patch.
9814 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9815 * xterm.h: Likewise.
9816 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9817
1384b89e
JB
98182011-06-12 Juanma Barranquero <lekktu@gmail.com>
9819
9820 * makefile.w32-in: Update dependencies.
9821 (LISP_H): Add lib/intprops.h.
9822
1100a63c
CY
98232011-06-11 Chong Yidong <cyd@stupidchicken.com>
9824
9825 * image.c (gif_load): Add animation frame delay to the metadata.
9826 (syms_of_image): Use DEFSYM. New symbol `delay'.
9827
6198ccd0
MR
98282011-06-11 Martin Rudalics <rudalics@gmx.at>
9829
9830 * window.c (delete_deletable_window): Re-add.
9831 (Fset_window_configuration): Rewrite to handle dead buffers and
9832 consequently deletable windows.
9833 (window_tree, Fwindow_tree): Remove. Supply functionality in
9834 window.el.
9835 (compare_window_configurations): Simplify code.
9836
b6e3633c
AS
98372011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9838
1ab0dee5
AS
9839 * image.c (imagemagick_load_image): Fix type mismatch.
9840 (Fimagemagick_types): Likewise.
9841
b6e3633c
AS
9842 * window.h (replace_buffer_in_windows): Declare.
9843
9397e56f
MR
98442011-06-11 Martin Rudalics <rudalics@gmx.at>
9845
9846 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9847 Qclone_number. Remove external declaration of Qdelete_window.
9848 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9849 code.
640c8776
SM
9850 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9851 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9852 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9853 buffer list implementation.
9854 (other_buffer_safely): New function.
9855 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9856 calls to replace_buffer_in_windows and
9857 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9858 if allowed.
9859 (record_buffer): Inhibit quitting and rewrite using quittable
9860 functions. Run Qbuffer_list_update_hook if allowed.
9861 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9862 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9863 Move switch-to-buffer to window.el.
9397e56f
MR
9864 (bury-buffer): Move to window.el.
9865 (Vbuffer_list_update_hook): New variable.
9866
9867 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9868 section.
9869
9870 * window.h (resize_frame_windows): Move up in code.
9871 (Fwindow_frame): Remove EXFUN.
9872 (replace_buffer_in_all_windows): Remove prototype.
9873 (replace_buffer_in_windows_safely): Add prototype.
9874
9875 * window.c: Declare Qdelete_window static again. Move down
9876 declaration of select_count.
9877 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9878 (Fother_window): Move to window.el.
9879 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9880 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9881 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9882 window.el.
9883 (replace_buffer_in_windows): Implement by calling
9884 Qreplace_buffer_in_windows.
9885 (replace_buffer_in_all_windows): Remove with some functionality
9886 moved into replace_buffer_in_windows_safely.
9887 (replace_buffer_in_windows_safely): New function.
9888 (select_window_norecord, select_frame_norecord): Move in front
9889 of run_window_configuration_change_hook. Remove now obsolete
9890 declarations.
640c8776
SM
9891 (Fset_window_buffer): Rewrite doc-string.
9892 Call Qrecord_window_buffer.
9397e56f
MR
9893 (keys_of_window): Move binding for other-window to window.el.
9894
b50691aa
CY
98952011-06-11 Chong Yidong <cyd@stupidchicken.com>
9896
9897 * dispextern.h (struct image): Replace data member, whose int_val
9898 and ptr_val fields were not used by anything, with a single
9899 lisp_val object.
9900
9901 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9902 (gif_clear_image, gif_load, imagemagick_load_image)
9903 (gs_clear_image, gs_load): Callers changed.
9904
3f754b86
PE
99052011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9906
cca69397
PE
9907 * buffer.h: Include <time.h>, for time_t.
9908 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9909
109e28d0
PE
9910 Fix minor problems found by static checking.
9911
60737f02
PE
9912 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9913
4b66faf3
PE
9914 Make identifiers static if they are not used in other modules.
9915 * data.c (Qcompiled_function, Qframe, Qvector):
9916 * image.c (QimageMagick, Qsvg):
9917 * minibuf.c (Qmetadata):
9918 * window.c (resize_window_check, resize_root_window): Now static.
9919 * window.h (resize_window_check, resize_root_window): Remove decls.
9920
109e28d0
PE
9921 * window.c (window_deletion_count, delete_deletable_window):
9922 Remove; unused.
46a4ce9e
PE
9923 (window_body_lines): Now static.
9924 (Fdelete_other_windows_internal): Mark vars as initialized.
9925 Make sure 'resize_failed' is initialized.
9926 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9927 (resize_window_apply): Remove unused local.
9928 * window.h (delete_deletable_window): Remove decl.
9929
109e28d0 9930 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9931 (imagemagick_load_image): Fix pointer signedness problem by changing
9932 last arg from unsigned char * to char *. All uses changed.
9933 Also, fix a local for similar reasons.
9934 Remove unused locals. Remove locals to avoid shadowing.
9935 (fn_rsvg_handle_free): Remove; unused.
9936 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9937 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9938
3f754b86
PE
9939 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9940
2547adb1
CY
99412011-06-10 Chong Yidong <cyd@stupidchicken.com>
9942
9943 * image.c (gif_load): Fix omitted cast error introduced by
9944 2011-06-06 change.
9945
2c8e37d4
MR
99462011-06-10 Martin Rudalics <rudalics@gmx.at>
9947
9948 * window.h (resize_proportionally, orig_total_lines)
9949 (orig_top_line): Remove from window structure.
9950 (set_window_height, set_window_width, change_window_heights)
9951 (Fdelete_window): Remove prototypes.
9952 (resize_frame_windows): Remove duplicate declaration.
9953
440a42e3
EZ
99542011-06-10 Eli Zaretskii <eliz@gnu.org>
9955
9956 * window.h (resize_frame_windows, resize_window_check)
9957 (delete_deletable_window, resize_root_window)
9958 (resize_frame_windows): Declare prototypes.
9959
9960 * window.c (resize_window_apply): Make definition be "static" to
9961 match the prototype.
9962
562dd5e9
MR
99632011-06-10 Martin Rudalics <rudalics@gmx.at>
9964
9965 * window.c: Remove declarations of Qwindow_size_fixed,
9966 window_min_size_1, window_min_size_2, window_min_size,
9967 size_window, window_fixed_size_p, enlarge_window, delete_window.
9968 Remove static from declaration of Qdelete_window, it's
9969 temporarily needed by Fbury_buffer.
9970 (replace_window): Don't assign orig_top_line and
9971 orig_total_lines.
9972 (Fdelete_window, delete_window): Remove. Window deletion is
9973 handled by window.el.
640c8776
SM
9974 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9975 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9976 (Fdelete_other_windows): Remove. Deleting other windows is
9977 handled by window.el.
9978 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9979 handled in window.el.
9980 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9981 Window minimum sizes are handled in window.el.
9982 (shrink_windows, size_window, set_window_height)
9983 (set_window_width, change_window_heights, window_height)
9984 (window_width, CURBEG, CURSIZE, enlarge_window)
9985 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9986 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9987 handled in window.el.
9988 (make_dummy_parent): Rename to make_parent_window and give it a
9989 second argument horflag.
9990 (make_window): Don't set resize_proportionally any more.
9991 (Fsplit_window): Remove. Windows are split in window.el.
9992 (save_restore_action, save_restore_orig_size)
9993 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9994 Resize mini windows in window.el.
9995 (grow_mini_window, shrink_mini_window): Implement by calling
9996 Qresize_root_window_vertically, resize_window_check and
9997 resize_window_apply.
640c8776
SM
9998 (saved_window, Fset_window_configuration, save_window_save):
9999 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10000 resize_proportionally.
10001 (window_min_height, window_min_width): Move to window.el.
10002 (keys_of_window): Move bindings for delete-other-windows,
10003 split-window, delete-window and enlarge-window to window.el.
10004
10005 * buffer.c: Temporarily extern Qdelete_window.
10006 (Fbury_buffer): Temporarily call Qdelete_window instead of
10007 Fdelete_window (Fbury_buffer will move to window.el soon).
10008
10009 * frame.c (set_menu_bar_lines_1): Remove code handling
10010 orig_top_line and orig_total_lines.
10011
10012 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10013 set_window_height but set heights directly.
10014 (change_frame_size_1): Use resize_frame_windows.
10015
10016 * xdisp.c (init_xdisp): Don't use set_window_height but set
10017 heights directly.
10018
640c8776
SM
10019 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10020 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10021 run_window_configuration_change_hook.
10022
10023 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10024 instead of change_window_heights and run
10025 run_window_configuration_change_hook.
10026
1a13852e
MR
100272011-06-09 Martin Rudalics <rudalics@gmx.at>
10028
10029 * window.c (replace_window): Rename second argument REPLACEMENT to
10030 NEW. New third argument SETFLAG. Rewrite.
10031 (delete_window, make_dummy_parent): Call replace_window with
10032 third argument 1.
10033 (window_list_1): Move down in code.
10034 (run_window_configuration_change_hook): Move set_buffer part
10035 before select_frame_norecord part in order to unwind correctly.
10036 Rename count1 to count.
10037 (recombine_windows, delete_deletable_window, resize_root_window)
10038 (Fdelete_other_windows_internal)
10039 (Frun_window_configuration_change_hook, make_parent_window)
10040 (resize_window_check, resize_window_apply, Fresize_window_apply)
10041 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10042 (Fdelete_window_internal, Fresize_mini_window_internal):
10043 New functions.
1a13852e
MR
10044 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10045
f3d1777e
MR
100462011-06-08 Martin Rudalics <rudalics@gmx.at>
10047
496e208e
MR
10048 * window.h (window): Add some new members to window structure -
10049 normal_lines, normal_cols, new_total, new_normal, clone_number,
10050 splits, nest, prev_buffers, next_buffers.
10051 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10052 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10053
f3d1777e
MR
10054 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10055 Remove.
496e208e
MR
10056 (make_dummy_parent): Set new members of windows structure.
10057 (make_window): Move down in code. Handle new members of window
10058 structure.
10059 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10060 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10061 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10062 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10063 (Fset_window_next_buffers, Fset_window_clone_number):
10064 New functions.
496e208e
MR
10065 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10066 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10067 Doc-string fixes.
10068 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10069 Argument WINDOW can be now internal window too.
10070 (Fwindow_use_time): Move up in code.
10071 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10072 Rewrite doc-string.
10073 (Fset_window_configuration, saved_window)
10074 (Fcurrent_window_configuration, save_window_save): Handle new
10075 members of window structure.
b9e809c2
MR
10076 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10077 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10078 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10079 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10080 Qget_mru_window, Qresize_root_window,
10081 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10082 Qauto_buffer_name; staticpro them.
f3d1777e 10083
abde8f8c
MR
100842011-06-07 Martin Rudalics <rudalics@gmx.at>
10085
10086 * window.c (Fwindow_total_size, Fwindow_left_column)
10087 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10088 (Fwindow_list_1): New functions.
10089 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10090 (Fwindow_width, Fscroll_left, Fscroll_right):
10091 Use window_body_cols instead of window_box_text_cols.
10092 (delete_window, Fset_window_configuration):
10093 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10094 (delete_all_subwindows): Take a window as argument and not a
10095 structure. Rewrite.
190b47e6
MR
10096 (window_loop): Remove handling of GET_LRU_WINDOW and
10097 GET_LARGEST_WINDOW.
10098 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10099
10100 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10101 window_box_text_cols. delete_all_subwindows now takes a
10102 Lisp_Object as argument.
abde8f8c 10103
640c8776
SM
10104 * indent.c (compute_motion, Fcompute_motion):
10105 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10106
fa8a67e6
MR
10107 * frame.c (delete_frame): Call delete_all_subwindows with root
10108 window as argument.
10109
a54e3482
DC
101102011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10111
10112 * fns.c (Fputhash): Document return value.
10113
60002bf5
CY
101142011-06-06 Chong Yidong <cyd@stupidchicken.com>
10115
10116 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10117
0c671da6 101182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10119
b862a52a 10120 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10121
be44ca6c
PE
10122 Check for overflow when converting integer to cons and back.
10123 * charset.c (Fdefine_charset_internal, Fdecode_char):
10124 Use cons_to_unsigned to catch overflow.
10125 (Fencode_char): Use INTEGER_TO_CONS.
10126 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10127 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10128 * data.c (long_to_cons, cons_to_long): Remove.
10129 (cons_to_unsigned, cons_to_signed): New functions.
10130 These signal an error for invalid or out-of-range values.
10131 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10132 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10133 * font.c (Ffont_variation_glyphs):
10134 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10135 * lisp.h: Include <intprops.h>.
10136 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10137 (cons_to_signed, cons_to_unsigned): New decls.
10138 (long_to_cons, cons_to_long): Remove decls.
10139 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10140 (Fprimitive_undo): Use CONS_TO_INTEGER.
10141 * xfns.c (Fx_window_property): Likewise.
10142 * xselect.c: Include <limits.h>.
10143 (x_own_selection, selection_data_to_lisp_data):
10144 Use INTEGER_TO_CONS.
10145 (x_handle_selection_request, x_handle_selection_clear)
10146 (x_get_foreign_selection, Fx_disown_selection_internal)
10147 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10148 (lisp_data_to_selection_data): Use cons_to_unsigned.
10149 (x_fill_property_data): Use cons_to_signed.
10150 Report values out of range.
10151
d1f3d2af
PE
10152 Check for buffer and string overflow more precisely.
10153 * buffer.h (BUF_BYTES_MAX): New macro.
10154 * lisp.h (STRING_BYTES_MAX): New macro.
10155 * alloc.c (Fmake_string):
10156 * character.c (string_escape_byte8):
10157 * coding.c (coding_alloc_by_realloc):
10158 * doprnt.c (doprnt):
10159 * editfns.c (Fformat):
10160 * eval.c (verror):
10161 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10162 since they may not be the same number.
10163 * editfns.c (Finsert_char):
10164 * fileio.c (Finsert_file_contents):
10165 Likewise for BUF_BYTES_MAX.
10166
dd52fcea
PE
10167 * image.c: Use ptrdiff_t, not int, for sizes.
10168 (slurp_file): Switch from int to ptrdiff_t.
10169 All uses changed.
10170 (slurp_file): Check that file size fits in both size_t (for
10171 malloc) and ptrdiff_t (for sanity and safety).
10172
7f9bbdbb
PE
10173 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10174 if b->modtime has its maximal value.
10175
dfe18f82
PE
10176 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10177
84acfcf0
PE
10178 Don't assume time_t can fit into int.
10179 * buffer.h (struct buffer.modtime): Now time_t, not int.
10180 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10181 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10182
ccd9a01a
PE
10183 Minor fixes for signed vs unsigned integers.
10184 * character.h (MAYBE_UNIFY_CHAR):
10185 * charset.c (maybe_unify_char):
10186 * keyboard.c (read_char, reorder_modifiers):
10187 XINT -> XFASTINT, since the integer must be nonnegative.
10188 * ftfont.c (ftfont_spec_pattern):
10189 * keymap.c (access_keymap, silly_event_symbol_error):
10190 XUINT -> XFASTINT, since the integer must be nonnegative.
10191 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10192 since it makes no difference and we prefer signed.
10193 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10194 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10195 nonnegative.
10196
d6d100dd
SM
101972011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10198
10199 * window.h (Fwindow_frame): Declare.
10200
2b6148e4
PE
102012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10202
10203 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10204 (SPARE_MEMORY): Always define.
10205 (LARGE_REQUEST): Remove.
10206 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10207
f230ecc9
MR
102082011-06-06 Martin Rudalics <rudalics@gmx.at>
10209
727e958e
MR
10210 * lisp.h: Move EXFUNS for Fframe_root_window,
10211 Fframe_first_window and Fset_frame_selected_window to window.h.
10212
10213 * window.h: Move EXFUNS for Fframe_root_window,
10214 Fframe_first_window and Fset_frame_selected_window here from
10215 lisp.h.
10216
10217 * frame.c (Fwindow_frame, Fframe_first_window)
10218 (Fframe_root_window, Fframe_selected_window)
10219 (Fset_frame_selected_window): Move to window.c.
10220 (Factive_minibuffer_window): Move to minibuf.c.
10221 (Fother_visible_frames_p): New function.
10222
10223 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10224
f230ecc9
MR
10225 * window.c (decode_window, decode_any_window): Move up in code.
10226 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10227 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10228 (Fwindow_buffer): Move up and rewrite doc-string.
10229 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10230 (Fwindow_prev): New functions.
727e958e
MR
10231 (Fwindow_frame): Move here from frame.c. Accept any window as
10232 argument.
10233 (Fframe_root_window, Fframe_first_window)
10234 (Fframe_selected_window): Move here from frame.c. Accept frame
10235 or arbitrary window as argument. Update doc-strings.
10236 (Fminibuffer_window): Move up in code.
10237 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10238 (Fset_frame_selected_window): Move here from frame.c.
10239 Marginal rewrite.
727e958e
MR
10240 (Fselected_window, select_window, Fselect_window): Move up in
10241 code. Minor doc-string fixes.
f230ecc9 10242
4d09bcf6
PE
102432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10244
10245 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10246 Do not assume that spare memory exists; that assumption is valid
10247 only if SYSTEM_MALLOC.
10248 (LARGE_REQUEST): New macro, so that the issue of large requests
10249 is separated from the issue of spare memory.
10250
810928a2
AS
102512011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10252
172418ad
AS
10253 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10254 format. (Bug#8806)
10255
43f862f7
AS
10256 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10257
810928a2
AS
10258 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10259 before statements.
10260
a059fe24
JD
102612011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10262
10263 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10264
10265 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10266
10267 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10268 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10269
989bf368
JB
102702011-06-05 Juanma Barranquero <lekktu@gmail.com>
10271
10272 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10273
4b80f674
CY
102742011-06-04 Chong Yidong <cyd@stupidchicken.com>
10275
10276 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10277 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10278 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10279 New error handlers.
4b80f674
CY
10280 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10281 Obey Vx_select_enable_clipboard_manager. Catch errors in
10282 x_clipboard_manager_save (Bug#8779).
10283 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10284 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10285
99a33b77 102862011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10287
10288 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10289
99a33b77 102902011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10291
10292 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10293 in the current matrix if keep_current_p is non-zero.
10294
8264569d
EZ
102952011-06-04 Eli Zaretskii <eliz@gnu.org>
10296
10297 * bidi.c (bidi_level_of_next_char): Fix last change.
10298
57f97249
EZ
102992011-06-03 Eli Zaretskii <eliz@gnu.org>
10300
fec2107c 10301 Support bidi reordering of text covered by display properties.
57f97249 10302
fec2107c
EZ
10303 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10304 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10305 (bidi_cache_search, bidi_cache_iterator_state)
10306 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10307 (bidi_level_of_next_char, bidi_move_to_visually_next):
10308 Support character positions inside a run of characters covered by a
fec2107c
EZ
10309 display string.
10310 (bidi_paragraph_init, bidi_resolve_explicit_1)
10311 (bidi_level_of_next_char): Call bidi_fetch_char and
10312 bidi_fetch_char_advance instead of FETCH_CHAR and
10313 FETCH_CHAR_ADVANCE.
10314 (bidi_init_it): Initialize new members.
10315 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10316 definitions.
10317 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10318 instead of using explicit *_CHAR codes.
d6d100dd
SM
10319 (bidi_resolve_explicit, bidi_resolve_weak):
10320 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10321 bidirectional text is supported only in multibyte buffers.
10322 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10323 it to initialize the frame_window_p member of struct bidi_it.
10324 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10325 (bidi_resolve_explicit, bidi_resolve_weak)
10326 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10327 bidi_it->nchars is non-positive.
10328 (bidi_level_of_next_char): Don't try to lookup the cache for the
10329 next/previous character if nothing is cached there yet, or if we
10330 were just reseat()'ed to a new position.
c40e2fb2 10331
0e14fe90
EZ
10332 * xdisp.c (set_cursor_from_row): Set start and stop points
10333 according to the row's direction when priming the loop that looks
10334 for the glyph on which to display cursor.
10335 (single_display_spec_intangible_p): Function deleted.
10336 (display_prop_intangible_p): Reimplement to call
10337 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10338 Accept 3 additional arguments needed by handle_display_spec.
10339 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10340 values: lists, `(when COND...)' forms, etc.
10341 (single_display_spec_string_p): Support property values that are
10342 lists with the argument STRING its top-level element.
10343 (display_prop_string_p): Fix the condition for processing a
10344 property that is a list to be consistent with handle_display_spec.
fec2107c 10345 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10346 last portion of handle_display_prop.
10347 (compute_display_string_pos): Accept additional argument
10348 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10349 value of a `display' property is a "replacing spec".
10350 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10351 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10352 the display property, but just return a value indicating whether
10353 the display property will replace the characters it covers.
10354 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10355 frame_window_p members of struct bidi_it.
d6d100dd
SM
10356 (compute_display_string_pos, compute_display_string_end):
10357 New functions.
fec2107c
EZ
10358 (push_it): Accept second argument POSITION, where pop_it should
10359 jump to continue iteration.
10360 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10361
fec2107c
EZ
10362 * keyboard.c (adjust_point_for_property): Adjust the call to
10363 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10364
10365 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10366 (bidi_init_it): Update prototypes.
10367 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10368 (compute_display_string_pos, compute_display_string_end):
10369 Declare prototypes.
fec2107c
EZ
10370 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10371 EMACS_INT.
fc6f18ce 10372
40087514 103732011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10374
57f53182
PE
10375 Malloc failure behavior now depends on size of allocation.
10376 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10377 * lisp.h: Change signatures accordingly.
10378 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10379 All callers changed. (Bug#8762)
10380
10381 * gnutls.c: Use Emacs's memory allocators.
10382 Without this change, the gnutls library would invoke malloc etc.
10383 directly, which causes problems on non-SYNC_INPUT hosts, and which
10384 runs afoul of improving memory_full behavior. (Bug#8761)
10385 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10386 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10387 xfree instead of the default malloc, realloc, free.
10388 (Fgnutls_boot): No need to check for memory allocation failure,
10389 since xmalloc does that for us.
10390
ac32cd99 10391 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10392 * category.c (hash_get_category_set):
10393 * ccl.c (ccl_driver):
10394 * charset.c (Fdefine_charset_internal):
10395 * charset.h (struct charset.hash_index):
10396 * composite.c (get_composition_id, gstring_lookup_cache)
10397 (composition_gstring_put_cache):
10398 * composite.h (struct composition.hash_index):
10399 * dispextern.h (struct image.hash):
10400 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10401 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10402 (hashfn_equal, hashfn_user_defined, make_hash_table)
10403 (maybe_resize_hash_table, hash_lookup, hash_put)
10404 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10405 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10406 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10407 * image.c (make_image, search_image_cache, lookup_image)
10408 (xpm_put_color_table_h):
10409 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10410 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10411 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10412 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10413 * alloc.c (allocate_vectorlike):
10414 Check for overflow in vector size calculations.
10415 * ccl.c (ccl_driver):
10416 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10417 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10418 need to be updated by these changes.
40087514
PE
10419 * fns.c (make_hash_table, maybe_resize_hash_table):
10420 Check for integer overflow with large hash tables.
0de4bb68
PE
10421 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10422 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10423 (SXHASH_REDUCE): New macro.
10424 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10425 Use it instead of discarding useful hash info with large hash values.
10426 (sxhash_float): New function.
10427 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10428 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10429 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10430 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10431 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10432 Adjust signatures to match updated version of code.
10433 (consing_since_gc): Now EMACS_INT, since a single hash table can
10434 use more than INT_MAX bytes.
10435
698d32e2
DN
104362011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10437
10438 Make it possible to build with GCC-4.6+ -O2 -flto.
10439
10440 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10441
fd6fa53f
SM
104422011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10443
10444 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10445 Call minibuffer-inactive-mode.
10446
864db017
JB
104472011-05-31 Juanma Barranquero <lekktu@gmail.com>
10448
10449 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10450 Update dependencies.
10451
2ad0baf4
DN
104522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10453
10454 * data.c (init_data): Remove code for UTS, this system is not
10455 supported anymore.
10456
4fcc2638
DN
104572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10458
10459 Don't force ./temacs to start in terminal mode.
10460
10461 * frame.c (make_initial_frame): Initialize faces in all cases, not
10462 only when CANNOT_DUMP is defined.
10463 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10464
c56e0fd5
DN
104652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10466
10467 * dispnew.c (add_window_display_history): Use const for the string
10468 pointer. Remove declaration, not needed.
10469
333d54da 104702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10471
55d4c1b2 10472 Use 'inline', not 'INLINE'.
333d54da 10473 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10474 * alloc.c, fontset.c (INLINE): Remove.
10475 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10476 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10477 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10478 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10479 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10480
738db178
DN
104812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10482
10483 Make it possible to run ./temacs.
10484
10485 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10486 syms_of_callproc does the same thing. Remove test for
10487 "initialized", do it in the caller.
10488 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10489
620c53a6
SM
104902011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10491
10492 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10493 (read_minibuf): Use get_minibuffer.
10494 (syms_of_minibuf): Use DEFSYM.
10495 (Qmetadata): New var.
10496 * data.c (Qbuffer): Don't make it static.
10497 (syms_of_data): Use DEFSYM.
10498
e003a292
PE
104992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10500
10501 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10502 (CCL_CODE_MIN): New macro.
10503
ed008a6d
PE
105042011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10505
3687c2ef
PE
10506 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10507
ed008a6d
PE
10508 * eval.c (Qdebug): Now static.
10509 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10510 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10511 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10512
d66c4c7c
CY
105132011-05-29 Chong Yidong <cyd@stupidchicken.com>
10514
10515 * image.c: Various fixes to ImageMagick code comments.
10516 (Fimagemagick_types): Doc fix.
10517
5fbc2025
PE
105182011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10519
0196f88a
PE
10520 Minor fixes prompted by GCC 4.6.0 warnings.
10521
10522 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10523
5fbc2025
PE
10524 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10525 (x_clipboard_manager_save_all): Move extern decl to ...
10526 * xterm.h: ... here, so that it can be checked for consistency.
10527
1dd3c2d9
CY
105282011-05-29 Chong Yidong <cyd@stupidchicken.com>
10529
10530 * xselect.c (x_clipboard_manager_save_frame)
10531 (x_clipboard_manager_save_all): New functions.
10532 (Fx_clipboard_manager_save): Lisp function deleted.
10533
10534 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10535 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10536
10537 * xterm.h: Update prototype.
10538
5ba6571d
WX
105392011-05-28 William Xu <william.xwl@gmail.com>
10540
10541 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10542 exiting (Bug#8239).
10543
3eaff834
JM
105442011-05-28 Jim Meyering <meyering@redhat.com>
10545
e1900994 10546 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10547 * fns.c (to_uchar): Define.
10548 (crypto_hash_function): Use it to convert some newly-signed
10549 variables to unsigned, to avoid sign-extension bugs. For example,
10550 without this change, (md5 "truc") would evaluate to
10551 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10552 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10553 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10554
0f6990a7
PE
105552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10556
10557 Integer overflow fixes.
c8a9ca5a 10558
08686060
PE
10559 * dbusbind.c: Serial number integer overflow fixes.
10560 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10561 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10562 to hold a serial number that is too large for a fixnum.
10563 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10564 Check for serial numbers out of range. Decode any serial number
59568bf0 10565 that was so large that it became a float. (Bug#8722)
08686060 10566
2d1fc3c7
PE
10567 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10568 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10569 Use XFASTINT rather than XUINT when numbers are nonnegative.
10570 (xd_append_arg, Fdbus_method_return_internal):
10571 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10572 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10573 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10574 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10575 (Bug#8722)
2d1fc3c7 10576
c8a9ca5a
PE
10577 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10578
519e1d69
PE
10579 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10580
6df6ae42 10581 ccl: Add integer overflow checks.
30569699
PE
10582 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10583 (IN_INT_RANGE): New macros.
10584 (ccl_driver): Use them to check for integer overflow when
10585 decoding a CCL program. Many of the new checks are whether XINT (x)
10586 fits in int; it doesn't always, on 64-bit hosts. The new version
10587 doesn't catch all possible integer overflows, but it's an
847044ea 10588 improvement. (Bug#8719)
30569699 10589
c11285dc
PE
10590 * alloc.c (make_event_array): Use XINT, not XUINT.
10591 There's no need for unsigned here.
10592
fdccd48e
PE
10593 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10594 This follows up to the 2011-05-06 change that substituted uintptr_t
10595 for EMACS_INT. This case wasn't caught back then.
10596
37910ab2
PE
10597 Rework Fformat to avoid integer overflow issues.
10598 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10599 now (part of C89). Include <verify.h>.
10600 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10601 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10602 (Fformat): Avoid the prepass trying to compute sizes; it was only
10603 approximate and thus did not catch overflow reliably. Instead, walk
10604 through the format just once, formatting and computing sizes as we go,
10605 checking for integer overflow at every step, and allocating a larger
10606 buffer as needed. Keep track separately whether the format is
10607 multibyte. Keep only the most-recently calculated precision, rather
10608 than them all. Record whether each argument has been converted to
10609 string. Use EMACS_INT, not int, for byte and char and arg counts.
10610 Support field widths and precisions larger than INT_MAX. Avoid
10611 sprintf's undefined behavior with conversion specifications such as %#d
10612 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10613 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10614 formatting out-of-range floating point numbers with int
9173deec 10615 formats. (Bug#8668)
37910ab2 10616
2e6578fb
PE
10617 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10618
0ae6bdee
PE
10619 * data.c: Avoid integer truncation in expressions involving floats.
10620 * data.c: Include <intprops.h>.
10621 (arith_driver): When there's an integer overflow in an expression
10622 involving floating point, convert the integers to floating point
10623 so that the resulting value does not suffer from catastrophic
10624 integer truncation. For example, on a 64-bit host (* 4
10625 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10626 Do not rely on undefined behavior after integer overflow.
10627
de883a70
PE
10628 merge count_size_as_multibyte, parse_str_to_multibyte
10629 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10630 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10631 Check for integer overflow.
10632 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10633 since it's now a duplicate of the other. This is more of
10634 a character than a buffer op, so better that it's in character.c.
10635 * fns.c, print.c: Adjust to above changes.
10636
2ff916cb
PE
106372011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10638
10639 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10640
f1b54466
PE
106412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10642
fb1ac845
PE
10643 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10644 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10645 (x_clipboard_manager_save): Now static.
10646 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10647
f1b54466
PE
10648 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10649 (crypto_hash_function): Now static.
10650 Fix pointer signedness problems. Avoid unnecessary initializations.
10651
a9f737ee
CY
106522011-05-27 Chong Yidong <cyd@stupidchicken.com>
10653
10654 * termhooks.h (Vselection_alist): Make it terminal-local.
10655
10656 * terminal.c (create_terminal): Initialize it.
10657
10658 * xselect.c: Support for clipboard managers.
10659 (Vselection_alist): Move to termhooks.h as terminal-local var.
10660 (LOCAL_SELECTION): New macro.
10661 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10662 (symbol_to_x_atom): Remove gratuitous arg.
10663 (x_handle_selection_request, lisp_data_to_selection_data)
10664 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10665 (x_own_selection, x_get_local_selection, x_convert_selection):
10666 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10667 (some_frame_on_display): Delete unused function.
10668 (Fx_own_selection_internal, Fx_get_selection_internal)
10669 (Fx_disown_selection_internal, Fx_selection_owner_p)
10670 (Fx_selection_exists_p): New optional frame arg.
10671 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10672 (x_handle_selection_clear): Don't treat other terminals with the
10673 same keyboard specially. Use the terminal-local Vselection_alist.
10674 (x_clear_frame_selections): Use Frun_hook_with_args.
10675
10676 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10677
10678 * xterm.h: Add support for those atoms.
10679
e067f0c1
CY
106802011-05-26 Chong Yidong <cyd@stupidchicken.com>
10681
10682 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10683 (converted_selections, conversion_fail_tag): New global variables.
10684 (x_selection_request_lisp_error): Free the above.
10685 (x_get_local_selection): Remove unnecessary code.
10686 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10687 of converted selections stored in converted_selections.
10688 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10689 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10690 (x_convert_selection): New function.
10691 (x_handle_selection_event): Simplify.
10692 (x_get_foreign_selection): Don't ignore incoming requests while
10693 waiting for an answer; this will fail when we implement
10694 SAVE_TARGETS, and seems unnecessary anyway.
10695 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10696 (Vx_sent_selection_functions): Doc fix.
10697
0f4aebc0
LL
106982011-05-26 Leo Liu <sdl.web@gmail.com>
10699
10700 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10701
e61124cd
YM
107022011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10703
10704 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10705
10706 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10707 for fringe update if it has periodic bitmap.
ac389d0c 10708 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10709 and fringe_bitmap_periodic_p.
10710
10711 * fringe.c (get_fringe_bitmap_data): New function.
10712 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10713 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10714 row. Mark glyph row for fringe update if periodicity changed.
10715
10716 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10717 for fringe update unless it has periodic bitmap.
10718
f16d9837
KH
107192011-05-25 Kenichi Handa <handa@m17n.org>
10720
10721 * xdisp.c (get_next_display_element): Set correct it->face_id for
10722 a static composition.
10723
e1b90ef6
LL
107242011-05-24 Leo Liu <sdl.web@gmail.com>
10725
10726 * deps.mk (fns.o):
10727 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10728
10729 * fns.c (crypto_hash_function, Fsha1): New function.
10730 (Fmd5): Use crypto_hash_function.
10731 (syms_of_fns): Add Ssha1.
10732
7400048f
PE
107332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10734
10735 * gnutls.c: Remove unused macros.
10736 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10737 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10738 Remove macros that are defined and never used.
10739 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10740
abb71cf4
CY
107412011-05-22 Chong Yidong <cyd@stupidchicken.com>
10742
10743 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10744 (Fx_get_selection_internal): Minor cleanup.
10745 (Fx_own_selection_internal): Rename arguments for consistency with
10746 select.el.
10747
6307db39
PE
107482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10749
10750 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10751
f3d4e0a4
CY
107522011-05-22 Chong Yidong <cyd@stupidchicken.com>
10753
10754 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10755
4d8ade89
YM
107562011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10757
10758 * dispnew.c (scrolling_window): Don't exclude the case that the
10759 last enabled row in the desired matrix touches the bottom boundary.
10760
32078c8d
GM
107612011-05-21 Glenn Morris <rgm@gnu.org>
10762
10763 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10764 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10765 and add some more files.
32078c8d 10766
7285dc67
EZ
107672011-05-20 Eli Zaretskii <eliz@gnu.org>
10768
10769 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10770 report_file_error introduced by the change from 2011-05-07.
10771
89d1bd22
PE
107722011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10773
10774 * systime.h (Time): Define only if emacs is defined.
10775 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10776 where the include path doesn't have X11/X.h by default. See
10777 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10778
cd394be1 107792011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10780
10781 * composite.c (find_automatic_composition): Fix previous change.
10782
b9704ad9
GM
107832011-05-20 Glenn Morris <rgm@gnu.org>
10784
10785 * lisp.mk: New file, split from Makefile.in.
10786 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10787 (shortlisp): Remove.
10788 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10789
4a720484
GM
107902011-05-19 Glenn Morris <rgm@gnu.org>
10791
10792 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10793 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10794 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10795 (lisp): Set the order to that of loadup.el.
10796 (shortlisp): Make it a copy of $lisp.
10797 (SOME_MACHINE_LISP): Remove.
10798 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10799 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10800
a28d4396
KH
108012011-05-18 Kenichi Handa <handa@m17n.org>
10802
10803 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10804 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10805 (find_automatic_composition): Mostly rewrite for efficiency.
10806
a2b1fa8e
JB
108072011-05-18 Juanma Barranquero <lekktu@gmail.com>
10808
10809 * makefile.w32-in: Update dependencies.
10810
8e1f5610
CS
108112011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10812
10813 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10814 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10815
7025ee00 108162011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10817
cdfa6eab
PE
10818 Fix some integer overflow issues, such as string length overflow.
10819
06d6db33
PE
10820 * insdel.c (count_size_as_multibyte): Check for string overflow.
10821
2b4560a8
PE
10822 * character.c (lisp_string_width): Check for string overflow.
10823 Use EMACS_INT, not int, for string indexes and lengths; in
10824 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10825 the resulting string length overflows an EMACS_INT; instead,
10826 report a string overflow if no precision given. When checking for
10827 precision exhaustion, use a check that cannot possibly have
10828 integer overflow. (Bug#8675)
10829 * character.h (lisp_string_width): Adjust to new signature.
10830
cb93f9be
PE
10831 * alloc.c (string_overflow): New function.
10832 (Fmake_string): Use it. This doesn't change behavior, but saves
10833 a few bytes and will simplify future changes.
10834 * character.c (string_escape_byte8): Likewise.
10835 * lisp.h (string_overflow): New decl.
10836
1a1f3366
PE
10837 Fixups, following up to the user-interface timestamp change.
10838 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10839 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10840 * msdos.c (mouse_get_pos): Likewise.
10841 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10842 * w32gui.h (Time): Define by including "systime.h" rather than by
10843 declaring it ourselves. (Bug#8664)
10844
d4e3e4d3
PE
10845 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10846 * image.c (clear_image_cache): Likewise.
10847
f6a24d19
PE
10848 * term.c (term_mouse_position): Don't assume time_t wraparound.
10849
08dc5ae6
PE
10850 Be more systematic about user-interface timestamps.
10851 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10852 and sometimes 'EMACS_UINT', to represent these timestamps.
10853 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10854 This makes the code easier to follow, and makes it easier to catch
10855 integer overflow bugs such as Bug#8664.
10856 * frame.c (Fmouse_position, Fmouse_pixel_position):
10857 Use Time, not unsigned long, for user-interface timestamps.
10858 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10859 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10860 * keyboard.h (last_event_timestamp): Likewise.
10861 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10862 * menu.h (xmenu_show): Likewise.
10863 * term.c (term_mouse_position): Likewise.
10864 * termhooks.h (struct input_event.timestamp): Likewise.
10865 (struct terminal.mouse_position_hook): Likewise.
10866 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10867 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10868 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10869 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10870 what it was before.
10871 * menu.h, termhooks.h: Include "systime.h", for Time.
10872
8e55734a
PE
10873 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10874 Don't assume that the difference between two unsigned long values
10875 can fit into an integer. At this point, we know button_down_time
10876 <= event->timestamp, so the difference must be nonnegative, so
10877 there's no need to cast the result if double-click-time is
10878 nonnegative, as it should be; check that it's nonnegative, just in
10879 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10880 apart (about 25 days). (Bug#8664)
8e55734a 10881
841f1b75 10882 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10883 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10884
3e26f69c
PE
10885 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10886 that always fit in int. Use a sentinel instead of a counter, to
10887 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10888 * frame.h (struct frame): Use int for menu_bar_items_used
10889 instead of EMACS_INT, since it always fits in int.
3e26f69c 10890
5cc152c0
PE
10891 * menu.c (grow_menu_items): Check for int overflow.
10892
d89eb65e
PE
10893 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10894
5235bd3e
PE
10895 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10896 Before, the code was not consistent. These values cannot exceed
10897 2**31 - 1 so there's no need to make them unsigned.
10898 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10899 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10900 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10901 as modifiers.
10902 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10903
bc827e23
PE
10904 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10905 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10906 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10907 presumably because the widths might not match.
10908
78eb494e
PE
10909 * window.c (size_window): Avoid needless test at loop start.
10910
04f2d78b
CB
109112011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10912
10913 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10914
d2fc7e3d 109152011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10916
10917 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10918
d2fc7e3d 109192011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10920
10921 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10922 `width' to `bar_area_x' and `bar_area_width', respectively.
10923 (x_scroll_run): Take account of fringe background extension.
10924
04f2d78b
CB
10925 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10926 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10927 `bar_area_width', respectively.
10928 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10929 background extension.
10930
79b70037
GM
109312011-05-10 Jim Meyering <meyering@redhat.com>
10932
10933 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10934
2f142cc5
JB
109352011-05-10 Juanma Barranquero <lekktu@gmail.com>
10936
10937 * image.c (Finit_image_library): Return t for built-in image types,
10938 like pbm and xbm. (Bug#8640)
10939
57679c86
AS
109402011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10941
10942 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10943
888c9e86
EZ
109442011-05-07 Eli Zaretskii <eliz@gnu.org>
10945
b0512a1d
EZ
10946 * w32console.c (Fset_screen_color): Doc fix.
10947 (Fget_screen_color): New function.
10948 (syms_of_ntterm): Defsubr it.
10949
7285dc67
EZ
10950 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10951 unlink the temporary file if Fcall_process didn't create it in the
10952 first place.
10953 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10954 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10955 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10956 cue to call_process_cleanup not to close that handle.
10957
4d3fcc8e
BK
109582011-05-07 Ben Key <bkey76@gmail.com>
10959
10960 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10961 one of two shell specific rules, either bootstrap-temacs-CMD or
10962 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10963 to the previous implementation of the bootstrap-temacs rule.
10964 The bootstrap-temacs-CMD rule is similar to the previous
10965 implementation of the bootstrap-temacs rule except that it
10966 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10967 variable.
10968
10969 These changes, along with some changes to nt/configure.bat,
10970 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10971 earlier fix to add support for --cflags and --ldflags options
10972 that include quotes so that it works whether make uses cmd or
10973 sh as the shell.
10974
b4289b64
MA
109752011-05-06 Michael Albinus <michael.albinus@gmx.de>
10976
10977 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10978 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10979 is a constant.
10980 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10981 a string. Handle both cases.
10982 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10983 (Fdbus_register_method): Use Qinvalid_function.
10984
af4c0e28
JB
109852011-05-06 Juanma Barranquero <lekktu@gmail.com>
10986
10987 * makefile.w32-in: Update dependencies.
10988 (LISP_H): Add inttypes.h and stdin.h.
10989 (PROCESS_H): Add unistd.h.
10990
c51453d9
EZ
109912011-05-06 Eli Zaretskii <eliz@gnu.org>
10992
10993 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10994 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10995
8ff0ac3c 109962011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10997
4c4b566b
PE
10998 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10999
aab2b9b5
PE
11000 * term.c (vfatal): Remove stray call to va_end.
11001 It's not needed and the C Standard doesn't allow it here anyway.
11002
c378da0b
PE
11003 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11004 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11005
288b08c7
PE
11006 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11007 bytes.
11008
e3601888
PE
11009 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11010
db6c0e74
PE
11011 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11012
dd5963ea
PE
11013 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11014
88c9450f
PE
11015 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11016
2f9442b8
PE
11017 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11018
c032b5f8
PE
11019 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11020 * charset.c (Fdefine_charset_internal): Don't initialize
11021 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11022 32-bit int (Bug#8600).
a108c10b
PE
11023
11024 * lread.c (read_integer): Be more consistent with string-to-number.
11025 Use string_to_number to do the actual conversion; this avoids
11026 rounding errors and fixes some other screwups. Without this fix,
11027 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11028 (digit_to_number): Move earlier, for benefit of read_integer.
11029 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11030 not a digit in any supported base. (Bug#8602)
a108c10b 11031
ad5f9eea
PE
11032 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11033
aec1708a
PE
11034 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11035 to match comment at start of function. This also removes a
11036 GCC warning about overflow in a 32+64-bit port.
11037
47be4ab5
PE
11038 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11039
371cac43
PE
11040 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11041 Reported by Stefan Monnier in
11042 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11043 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11044 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11045
d01a7826
PE
11046 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11047 (EMACS_UINTPTR): Likewise, with uintptr_t.
11048
7fd47d5c
PE
11049 * lisp.h: Prefer 64-bit EMACS_INT if available.
11050 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11051 on 32-bit hosts that have 64-bit int, so that they can access
11052 large files.
122b0c86
PE
11053 However, temporarily disable this change unless the temporary
11054 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11055
8727937b
PE
11056 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11057
8ac068ac
PE
11058 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11059 This removes an assumption that EMACS_INT and long are the same
11060 width as pointers. The assumption is true for Emacs porting targets
11061 now, but we want to make other targets possible.
11062 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11063 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11064 In the rest of the code, change types of integers that hold casted
11065 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11066 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11067 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11068 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11069 No need to cast type when ORing.
11070 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11071 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11072 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11073 assume EMACS_INT is the same width as char *.
11074 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11075 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11076 Remove no-longer-needed casts.
11077 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11078 (xg_tool_bar_help_callback, xg_make_tool_item):
11079 Use EMACS_INTPTR to hold an integer
11080 that will be cast to void *; this can avoid a GCC warning
11081 if EMACS_INT is not the same width as void *.
11082 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11083 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11084 (current_message_1, set_message_1):
11085 Use a local to convert to proper width without a cast.
11086 * xmenu.c (dialog_selection_callback): Likewise.
11087
ede49d71
PE
11088 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11089 Also, don't assume VALBITS / RAND_BITS is less than 5,
11090 and don't rely on undefined behavior when shifting a 1 left into
11091 the sign bit.
11092 * lisp.h (get_random): Change signature to match.
11093
2f30ecd0
PE
11094 * lread.c (hash_string): Use size_t, not int, for hash computation.
11095 Normally we prefer signed values; but hashing is special, because
11096 it's better to use unsigned division on hash table sizes so that
11097 the remainder is nonnegative. Also, size_t is the natural width
11098 for hashing into memory. The previous code used 'int', which doesn't
11099 retain enough info to hash well into very large tables.
11100 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11101
2a866e7b
PE
11102 * dbusbind.c: Don't possibly lose pointer info when converting.
11103 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11104 Use XPNTR rather than XHASH, so that the high-order bits of
11105 the pointer aren't lost when converting through void *.
11106
51639eac
PE
11107 * eval.c (Fautoload): Don't double-shift a pointer.
11108
92394119
PE
11109 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11110
dbdb9a7c
JB
111112011-05-06 Juanma Barranquero <lekktu@gmail.com>
11112
11113 * gnutls.c (DEF_GNUTLS_FN):
11114 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11115
db7a0b4f
AS
111162011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11117
11118 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11119 marker. (Bug#8610)
11120
cd394be1 111212011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11122
11123 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11124 New version that can reserve upto 2GB of heap space.
11125
f7ff1b0f 111262011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11127
11128 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11129
639c109b
TZ
111302011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11131
11132 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11133 `gnutls_certificate_set_x509_key_file'.
11134
d2127135
JB
111352011-05-05 Juanma Barranquero <lekktu@gmail.com>
11136
11137 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11138 Update dependencies.
11139
e968f4f3
JB
111402011-05-04 Juanma Barranquero <lekktu@gmail.com>
11141
11142 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11143 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11144 Remove unused parameter `fildes'.
11145 * process.c (read_process_output, send_process): Don't pass it.
11146
84d358f0
JB
111472011-05-04 Juanma Barranquero <lekktu@gmail.com>
11148
11149 Fix previous change: the library cache is defined in w32.c.
11150 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11151 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11152
0898ca10
JB
111532011-05-04 Juanma Barranquero <lekktu@gmail.com>
11154
11155 Implement dynamic loading of GnuTLS on Windows.
11156
11157 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11158 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11159 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11160 Declare.
11161
11162 * gnutls.c (Qgnutls_dll): Define.
11163 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11164 (gnutls_*): Declare function pointers.
11165 (init_gnutls_functions): New function to initialize function pointers.
11166 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11167 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11168 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11169 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11170 (emacs_gnutls_write, emacs_gnutls_read)
11171 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11172 (Fgnutls_available_p): New function.
11173 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11174 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11175 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11176
11177 * image.c: Include w32.h.
11178 (Vimage_type_cache): Delete.
11179 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11180 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11181 (w32_delayed_load): Move to w32.c.
11182
11183 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11184
11185 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11186 (w32_delayed_load): Move from image.c. When loading a library, record
11187 its filename in the :loaded-from property of the library id.
11188 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11189 Initialize and staticpro them.
11190 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11191
11192 * process.c: Include lisp.h before w32.h, not after.
11193 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11194 instead of gnutls_record_check_pending.
11195
11196 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11197
ff4de4aa
TZ
111982011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11199
11200 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11201 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11202 as passed in.
11203
abe95abb
JD
112042011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11205
11206 * xterm.c (x_set_frame_alpha): Do not set property on anything
11207 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11208
e16e55d4
JB
112092011-05-02 Juanma Barranquero <lekktu@gmail.com>
11210
11211 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11212
bafcf6a5
JB
112132011-05-02 Juanma Barranquero <lekktu@gmail.com>
11214
11215 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11216 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11217 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11218 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11219 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11220 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11221 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11222 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11223 (Qgnutls_bootprop_callbacks_verify): Make static.
11224
e7a6747f
AS
112252011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11226
19ed11ba
AS
11227 * callproc.c: Indentation fixup.
11228
e7a6747f 11229 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11230 (wait_for_termination, interruptible_wait_for_termination):
11231 Move after wait_for_termination_1.
e7a6747f 11232
1ef14cb4
LMI
112332011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11234
11235 * sysdep.c (interruptible_wait_for_termination): New function
11236 which is like wait_for_termination, but allows keyboard
11237 interruptions.
11238
11239 * callproc.c (Fcall_process): Add (:file "file") as an option for
11240 the STDOUT buffer.
11241 (Fcall_process_region): Ditto.
11242
330d880c
EZ
112432011-04-30 Eli Zaretskii <eliz@gnu.org>
11244
8db90b73
EZ
11245 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11246 rather than `XVECTOR (FOO)->size'.
11247
330d880c
EZ
11248 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11249 inttypes.h, as a gnulib replacement is used if it not available in
11250 system headers.
11251
15cbd324
EZ
112522011-04-21 Eli Zaretskii <eliz@gnu.org>
11253
11254 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11255 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11256 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11257
11258 * coding.c (coding_alloc_by_realloc): Error out if destination
11259 will grow beyond MOST_POSITIVE_FIXNUM.
11260 (decode_coding_emacs_mule): Abort if there isn't enough place in
11261 charbuf for the composition carryover bytes. Reserve an extra
11262 space for up to 2 characters produced in a loop.
11263 (decode_coding_iso_2022): Abort if there isn't enough place in
11264 charbuf for the composition carryover bytes.
11265
112662011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11267
ae940cca
EZ
11268 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11269 aborting when %lld or %lll format is passed.
11270 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11271 %llo or %llx format is passed. (Bug#8545)
11272
03ab8921
EZ
11273 * window.c (window_scroll_line_based): Use a marker instead of
11274 simple variables to record original value of point. (Bug#7952)
11275
afda1437
EZ
11276 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11277 produced by %s or %c overflows available buffer space. (Bug#8545)
11278
f76dee0c
PE
112792011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11280
11281 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11282 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11283
fdc5744d
JB
112842011-04-28 Juanma Barranquero <lekktu@gmail.com>
11285
11286 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11287
638f053a
JB
112882011-04-28 Juanma Barranquero <lekktu@gmail.com>
11289
11290 * keyboard.c (Qdelayed_warnings_hook): Define.
11291 (command_loop_1): Run `delayed-warnings-hook'
11292 if Vdelayed_warnings_list is non-nil.
11293 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11294 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11295
d178f871
EZ
112962011-04-28 Eli Zaretskii <eliz@gnu.org>
11297
11298 * doprnt.c (doprnt): Don't return value smaller than the buffer
11299 size if the message was truncated. (Bug#8545).
11300
b124fd93
JB
113012011-04-28 Juanma Barranquero <lekktu@gmail.com>
11302
11303 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11304 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11305
e810457d
PE
113062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11307
11308 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11309
ea51cceb
JB
113102011-04-27 Juanma Barranquero <lekktu@gmail.com>
11311
11312 * makefile.w32-in: Update dependencies.
11313
94dcfacf
EZ
113142011-04-27 Eli Zaretskii <eliz@gnu.org>
11315
11316 Improve `doprnt' and its usage. (Bug#8545)
11317 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11318 `format_end'. Remove support for %l as a conversion specifier.
11319 Don't use xrealloc. Improve diagnostics when the %l size modifier
11320 is used. Update the commentary.
11321
11322 * eval.c (verror): Simplify calculation of size_t.
11323
11324 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11325 messages.
11326
f61f41d7
PE
113272011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11328
11329 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11330 change.
11331
96fb4434
PE
113322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11333
11334 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11335 This makes this file independent of the recent pseudovector change.
11336
671875da 113372011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11338
69e9b5a3
PE
11339 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11340
b5f869a7 11341 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11342 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11343 Remove unused local.
c8926152 11344 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11345
841a1577 11346 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11347 GCC 4.6.0 optimizes based on type-based alias analysis.
11348 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11349 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11350 != &v->size, and therefore "v->size = 1; b->size = 2; return
11351 v->size;" must therefore return 1. This assumption is incorrect
11352 for Emacs, since it type-puns struct Lisp_Vector * with many other
11353 types. To fix this problem, this patch adds a new type struct
f904488f 11354 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11355 and pseudovectors, and helps optimizing compilers not get fooled
11356 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11357 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11358 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11359 the size member.
eab3844f
PE
11360 (XSETPVECTYPE): Rewrite in terms of new macro.
11361 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11362 This is a bit clearer, and further avoids the possibility of
11363 undesirable aliasing.
11364 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11365 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11366 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11367 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11368 (ASIZE): Now uses header.size rather than size.
11369 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11370 to avoid the hassle of writing XVECTOR (foo)->header.size.
11371 (struct vectorlike_header): New type.
eab3844f
PE
11372 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11373 object, to help avoid aliasing.
11374 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11375 (SUBRP): Likewise, since Lisp_Subr is a special case.
11376 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11377 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11378 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11379 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11380 changed to be "header.size" and "header.next".
11381 * buffer.h (struct buffer): Likewise.
11382 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11383 * frame.h (struct frame): Likewise.
11384 * process.h (struct Lisp_Process): Likewise.
11385 * termhooks.h (struct terminal): Likewise.
11386 * window.c (struct save_window_data, struct saved_window): Likewise.
11387 * window.h (struct window): Likewise.
11388 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11389 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11390 * buffer.c (init_buffer_once): Likewise.
11391 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11392 special case.
11393 * process.c (Fformat_network_address): Use local var for size,
11394 for brevity.
11395
0df1eac5
PE
11396 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11397
847ab9d1 11398 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11399 * data.c (atof): Remove decl; no longer used or needed.
11400 (digit_to_number): Move to lread.c.
11401 (Fstring_to_number): Use new string_to_number function, to be
11402 consistent with how the Lisp reader treats infinities and NaNs.
11403 Do not assume that floating-point numbers represent EMACS_INT
11404 without losing information; this is not true on most 64-bit hosts.
11405 Avoid double-rounding errors, by insisting on integers when
11406 parsing non-base-10 numbers, as the documentation specifies.
11407 * lisp.h (string_to_number): New decl, replacing ...
11408 (isfloat_string): Remove.
bc0a5c13 11409 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11410 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11411 appears to have been a coding error. Similarly, do not accept
11412 strings like +-1e0 as floating point numbers. Do not report
11413 overflow for integer overflows unless the base is not 10 which
11414 means we have no simple and reliable way to continue.
11415 Break out the floating-point parsing into a new
11416 function string_to_number, so that Fstring_to_number parses
11417 floating point numbers consistently with the Lisp reader.
04f2d78b 11418 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11419 (E_CHAR, EXP_INT): Remove, replacing with ...
11420 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11421 (string_to_number): New function, replacing isfloat_string.
11422 This function checks for valid syntax and produces the resulting
11423 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11424 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11425 so that overflow for non-base-10 numbers is reported only when
11426 there's no portable and simple way to convert to floating point.
452f4150 11427
67769ffc
PE
11428 * textprop.c (set_text_properties_1): Rewrite for clarity,
11429 and to avoid GCC warning about integer overflow.
11430
c20db43f
PE
11431 * intervals.h (struct interval): Use EMACS_INT for members
11432 where EMACS_UINT might cause problems. See
11433 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11434 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11435 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11436 All uses changed.
37aa2f85
PE
11437 (offset_intervals): Tell GCC not to worry about length overflow
11438 when negating a negative length.
c20db43f 11439
2538aa2f
PE
11440 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11441 (overrun_check_free): Likewise.
11442
f2d3008d
PE
11443 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11444 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11445 word size.
11446
ec8df744
PE
11447 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11448 (gnutls_make_error): Rename local to avoid shadowing.
11449 (gnutls_emacs_global_deinit): ifdef out; not used.
11450 (Fgnutls_boot): Use const for pointer to readonly storage.
11451 Comment out unused local. Fix pointer signedness problems.
11452
640ee02d
PE
11453 * lread.c (openp): Don't stuff size_t into an 'int'.
11454 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11455 about possible signed overflow.
11456
6048fb2a
PE
11457 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11458 (GDK_KEY_g): Don't define if already defined.
11459 (xg_prepare_tooltip): Avoid pointer signedness problem.
11460 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11461
fa3c87e1
PE
11462 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11463 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11464
2172544b
PE
11465 * xfns.c (Fx_window_property): Simplify a bit,
11466 to make a bit faster and to avoid GCC 4.6.0 warning.
11467 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11468
9b821a21
PE
11469 * fns.c (internal_equal): Don't assume size_t fits in int.
11470
3c616cfa
PE
11471 * alloc.c (compact_small_strings): Tighten assertion a little.
11472
c2982e87
PE
11473 Replace pEd with more-general pI, and fix some printf arg casts.
11474 * lisp.h (pI): New macro, generalizing old pEd macro to other
11475 conversion specifiers. For example, use "...%"pI"d..." rather
11476 than "...%"pEd"...".
11477 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11478 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11479 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11480 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11481 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11482 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11483 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11484 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11485 64-bit hosts.
11486 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11487 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11488 * print.c (safe_debug_print, print_object): Likewise.
11489 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11490 to int.
6f04d126
PE
11491 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11492 avoiding the 0 flag, which is not portable.
c2982e87
PE
11493 * process.c (Fmake_network_process): Use pI to avoid cast.
11494 * region-cache.c (pp_cache): Likewise.
11495 * xdisp.c (decode_mode_spec): Likewise.
11496 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11497 behavior on 64-bit hosts with printf arg.
6f04d126 11498 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11499 (x_stop_queuing_selection_requests): Likewise.
11500 (x_get_window_property): Don't truncate byte count to an 'int'
11501 when tracing.
0b432f21 11502
5e073ec7
PE
11503 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11504 here, since it parses constructs like leading '-' and spaces,
11505 which are not wanted; and it overflows with large numbers.
11506 Instead, simply match F[0-9]+, which is what is wanted anyway.
11507
36372bf9
PE
11508 * alloc.c: Remove unportable assumptions about struct layout.
11509 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11510 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11511 (allocate_vectorlike, make_pure_vector): Use the new macros,
11512 plus offsetof, to remove unportable assumptions about struct layout.
11513 These assumptions hold on all porting targets that I know of, but
11514 they are not guaranteed, they're easy to remove, and removing them
11515 makes further changes easier.
11516
0b432f21
PE
11517 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11518 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11519 (string_overrun_cookie): Now const. Use initializers that
11520 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11521 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11522 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11523 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11524 multiple of sizeof (EMACS_INT); it need not be, if
11525 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11526 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11527
895009e1
JB
115282011-04-26 Juanma Barranquero <lekktu@gmail.com>
11529
11530 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11531
6a7a1b0b
TZ
115322011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11533
11534 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11535 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11536 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11537
841a1577 115382011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11539
11540 * lisp.h (Qdebug): List symbol.
895009e1 11541 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11542 * keyboard.c (debug-on-event): New variable.
11543 (handle_user_signal): Break into debugger when debug-on-event
11544 matches the current signal symbol.
11545
f2d3ba6f
DN
115462011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11547
11548 * alloc.c (check_sblock, check_string_bytes)
11549 (check_string_free_list): Convert to standard C.
11550
42ce4c63
TZ
115512011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11552
11553 * w32.c (emacs_gnutls_push): Fix typo.
11554
825cd63c
EZ
115552011-04-25 Eli Zaretskii <eliz@gnu.org>
11556
fb11d64d
EZ
11557 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11558 "cast to pointer from integer of different size".
11559
825cd63c
EZ
11560 Improve doprnt and its use in verror. (Bug#8545)
11561 * doprnt.c (doprnt): Document the set of format control sequences
11562 supported by the function. Use SAFE_ALLOCA instead of always
11563 using `alloca'.
11564
11565 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11566 is one byte too soon. Don't use xrealloc; instead xfree and
11567 xmalloc anew.
11568
e061a11b
TZ
115692011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11570
11571 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11572 callbacks stage.
11573
11574 * gnutls.c: Renamed global_initialized to
11575 gnutls_global_initialized. Added internals for the
11576 :verify-hostname-error, :verify-error, and :verify-flags
11577 parameters of `gnutls-boot' and documented those parameters in the
11578 docstring. Start callback support.
9173deec
JB
11579 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11580 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11581 on error. Return error code.
e061a11b
TZ
11582 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11583 (emacs_gnutls_read): Likewise.
11584 (Fgnutls_boot): Return handshake error code.
11585 (emacs_gnutls_handle_error): New function.
11586 (wsaerror_to_errno): Likewise.
11587
11588 * w32.h (emacs_gnutls_pull): Add prototype.
11589 (emacs_gnutls_push): Likewise.
11590
11591 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11592 (emacs_gnutls_push): Likewise.
11593
115942011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11595
11596 * process.c (wait_reading_process_output): Check if GnuTLS
11597 buffered some data internally if no FDs are set for TLS
11598 connections.
11599
11600 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11601 (LIBS): Link to USER_LIBS.
11602 ($(BLD)/gnutls.$(0)): New target.
11603
fa6996bc
EZ
116042011-04-24 Eli Zaretskii <eliz@gnu.org>
11605
eb35682e
EZ
11606 * xdisp.c (handle_single_display_spec): Rename the
11607 display_replaced_before_p argument into display_replaced_p, to
11608 make it consistent with the commentary. Fix typos in the
11609 commentary.
11610
e2ad650c
EZ
11611 * textprop.c (syms_of_textprop): Remove dead code.
11612 (copy_text_properties): Delete obsolete commentary about an
11613 interface that was deleted long ago. Fix typos in the description
11614 of arguments.
11615
1b2de274
EZ
11616 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11617 to changes in oldXMenu/XMenu.h from 2011-04-16.
11618 <menu_help_message, prev_menu_help_message>: Constify.
11619 (IT_menu_make_room): menu->help_text is now `const char **';
11620 adjust.
11621
11622 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11623 to changes in oldXMenu/XMenu.h from 2011-04-16.
11624 (struct XMenu): Declare `help_text' `const char **'.
11625
11626 * xfaces.c <Qunspecified>: Make extern again.
11627
11628 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11629 required by POSIX.
1b2de274 11630
762b15be
EZ
11631 * doc.c (get_doc_string): Improve the format passed to `error'.
11632
11633 * doprnt.c (doprnt): Improve commentary.
11634
11635 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11636
11637 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11638 them with etags.
11639
f1052e5d
EZ
11640 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11641 changes in globals.h immediately force recompilation.
762b15be
EZ
11642 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11643 $(CURDIR)/s/ms-w32.h.
11644 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11645
fa6996bc
EZ
11646 * character.c (Fchar_direction): Function deleted.
11647 (syms_of_character): Don't defsubr it.
11648 <char-direction-table>: Deleted.
11649
e6c3da20
EZ
116502011-04-23 Eli Zaretskii <eliz@gnu.org>
11651
11652 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11653 * doprnt.c: Include limits.h.
11654 (SIZE_MAX): New macro.
04f2d78b
CB
11655 (doprnt): Return a size_t value. 2nd arg is now size_t.
11656 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11657 Improve overflow protection. Support `l' modifier for integer
11658 conversions. Support %l conversion. Don't assume an EMACS_INT
11659 argument for integer conversions and for %c.
11660
11661 * lisp.h (doprnt): Restore prototype.
11662
11663 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11664 $(SRC)/character.h.
11665
11666 * Makefile.in (base_obj): Add back doprnt.o.
11667
11668 * deps.mk (doprnt.o): Add back prerequisites.
11669 (callint.o): Depend on character.h.
11670
11671 * eval.c (internal_lisp_condition_case): Include the handler
11672 representation in the error message.
11673 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11674 when breaking from the loop.
11675
11676 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11677
11678 * callint.c (Fcall_interactively): When displaying error message
11679 about invalid control letter, pass the character's codepoint, not
11680 a pointer to its multibyte form. Improve display of the character
11681 in octal and display also its hex code.
11682
11683 * character.c (char_string): Use %x to display the (unsigned)
11684 codepoint of an invalid character, to avoid displaying a bogus
11685 negative value.
11686
11687 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11688 `error', not SYMBOL_NAME itself.
11689
11690 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11691 character arguments to `error'.
11692
11693 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11694 to `error' in error message about FINAL_CHAR argument. Make sure
11695 FINAL_CHAR is a character, and use %c when it is passed as
11696 argument to `error'.
11697
4ffd0d6b 116982011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11699
11700 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11701
11702 * w32.c: Include <time.h>.
11703 (sys_localtime): New function.
11704
4ffd0d6b 117052011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11706
11707 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11708
4ffd0d6b 11709 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11710
4ffd0d6b 117112011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11712
4ffd0d6b
GM
11713 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11714 zombies (Bug#8467).
aac0c6e3 11715
04c56954
EZ
117162011-04-19 Eli Zaretskii <eliz@gnu.org>
11717
11718 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11719 gl_state.e_property when gl_state.object is Qt.
11720
11721 * insdel.c (make_gap_larger): Remove limitation of buffer size
11722 to <= INT_MAX.
11723
16a43933
CY
117242011-04-18 Chong Yidong <cyd@stupidchicken.com>
11725
11726 * xdisp.c (lookup_glyphless_char_display)
11727 (produce_glyphless_glyph): Handle cons cell entry in
11728 glyphless-char-display.
11729 (Vglyphless_char_display): Document it.
11730
11731 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11732 glyphless-char-display.
11733
4581706e
CY
117342011-04-17 Chong Yidong <cyd@stupidchicken.com>
11735
11736 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11737
11738 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11739
11740 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11741 definition for no-X builds.
11742
4887c6e2 117432011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11744
fd35b6f9
PE
11745 Static checks with GCC 4.6.0 and non-default toolkits.
11746
5c1ccb01
PE
11747 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11748
006c5daa
PE
11749 * process.c (keyboard_bit_set): Define only if SIGIO.
11750 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11751 (send_process): Repair possible setjmp clobbering.
11752
efc736d3
PE
11753 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11754
4e2fe2e6
PE
11755 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11756
f97334a2
PE
11757 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11758
4e75f29d
PE
11759 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11760 Define only if needed.
11761
90efadd1
PE
11762 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11763 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11764 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11765
3c647824
PE
11766 * dispextern.h (struct redisplay_interface): Rename param
11767 to avoid shadowing.
e264f262 11768 * termhooks.h (struct terminal): Likewise.
761383f4 11769 * xterm.c (xembed_send_message): Likewise.
3c647824 11770
b58c5c4a
PE
11771 * insdel.c (make_gap_smaller): Define only if
11772 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11773
cad59032
PE
11774 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11775 it.
11776
c339dc2e
PE
11777 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11778 so that we aren't warned about unused symbols.
11779
91a3e27b
PE
11780 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11781
399c71d3 11782 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11783
8ffc96f5
PE
11784 * xfns.c (x_real_positions): Mark locals as initialized.
11785
eef9bc79
PE
11786 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11787
098db9dd
PE
11788 * xterm.c: Fix problems found by static analysis with other toolkits.
11789 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11790 (x_dispatch_event): Declare static if USE_GTK, and
11791 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11792 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11793 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11794 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11795 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11796
eb18f6cc
PE
11797 * xmenu.c (menu_help_callback): Pointer type fixes.
11798 Use const pointers when pointing at readonly data. Avoid pointer
11799 signedness clashes.
11800 (FALSE): Remove unused macro.
11801 (update_frame_menubar): Remove unused decl.
11802
1fe72bf8
PE
11803 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11804
60d9e1db
PE
11805 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11806 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11807 (single_menu_item): Rename local to avoid shadowing.
11808
39261c26
PE
11809 * keyboard.c (make_lispy_event): Remove unused local var.
11810
018c5e19
PE
11811 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11812 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11813
63d2b86e
PE
11814 * bitmaps: Change bitmaps from unsigned char back to the X11
11815 compatible char. Avoid the old compiler warnings about
11816 out-of-range initializers by using, for example, '\xab' rather
11817 than 0xab.
11818
aefd87e1
PE
11819 * xgselect.c (xgselect_initialize): Check vs interface
11820 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11821
bf501fb9
PE
11822 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11823
e9829fdf
PE
11824 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11825 to read-only memory.
11826
1086c095
PE
11827 * fns.c (vector): Remove; this old hack is no longer needed.
11828
2baccd04 11829 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11830 Remove unused var.
dde42981 11831 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11832
72391843 11833 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11834
436c16df 11835 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11836 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11837 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11838
92bb796d 11839 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11840 (x_term_init): Remove local to avoid shadowing.
92bb796d 11841
764430a3 11842 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11843
11844 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11845 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11846
d1dfb56c
EZ
118472011-04-16 Eli Zaretskii <eliz@gnu.org>
11848
c4354cb4
EZ
11849 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11850
d1dfb56c
EZ
11851 Fix regex.c, syntax.c and friends for buffers > 2GB.
11852 * syntax.h (struct gl_state_s): Declare character position members
11853 EMACS_INT.
11854
11855 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11856
04f2d78b
CB
11857 * textprop.c (verify_interval_modification, interval_of):
11858 Declare arguments EMACS_INT.
d1dfb56c
EZ
11859
11860 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11861 EMACS_INT.
11862
11863 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11864
11865 * indent.c (Fvertical_motion): Local variable it_start is now
11866 EMACS_INT.
11867
11868 * regex.c (re_match, re_match_2, re_match_2_internal)
11869 (bcmp_translate, regcomp, regexec, print_double_string)
11870 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11871 (re_compile_pattern, re_exec): Declare arguments and local
11872 variables `size_t' and `ssize_t' and return values `regoff_t', as
11873 appropriate.
11874 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11875 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11876 <compile_stack_type>: `size' and `avail' are now `size_t'.
11877
11878 * regex.h <regoff_t>: Use ssize_t, not int.
11879 (re_search, re_search_2, re_match, re_match_2): Arguments that
11880 specify buffer/string position and length are now ssize_t and
11881 size_t. Return type is regoff_t.
11882
613052cd
BK
118832011-04-16 Ben Key <bkey76@gmail.com>
11884
11885 * nsfont.m: Fixed bugs in ns_get_family and
11886 ns_descriptor_to_entity that were caused by using free to
11887 deallocate memory blocks that were allocated by xmalloc (via
11888 xstrdup). This caused Emacs to crash when compiled with
11889 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11890 --enable-checking=xmallocoverrun). xfree is now used to
11891 deallocate these memory blocks.
11892
4170f62f 118932011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11894
71b41406
PE
11895 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11896
9587a89d
PE
11897 emacs_write: Accept and return EMACS_INT for sizes.
11898 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11899 et seq.
11900 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11901 Accept and return EMACS_INT.
11902 (emacs_gnutls_write): Return the number of bytes written on
11903 partial writes.
11904 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11905 (emacs_read, emacs_write): Remove check for negative size, as the
11906 Emacs source code has been audited now.
9587a89d
PE
11907 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11908 (emacs_read, emacs_write): Use it.
273a5f82
PE
11909 * process.c (send_process): Adjust to the new signatures of
11910 emacs_write and emacs_gnutls_write. Do not attempt to store
11911 a byte offset into an 'int'; it might overflow.
9587a89d 11912 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11913
3e047f51
PE
11914 * sound.c: Don't assume sizes fit in 'int'.
11915 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11916 Return EMACS_INT, not int.
3e047f51 11917 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11918 Accept EMACS_INT, not int.
11919 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11920 record read return values.
11921
cc39a9db
BK
119222011-04-15 Ben Key <bkey76@gmail.com>
11923
c9d0ec6d
JB
11924 * keyboard.c (Qundefined): Don't declare static since it is used
11925 in nsfns.m.
11926 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11927 static since they are used in nsfont.m.
cc39a9db 11928
6c60eb9f
SM
119292011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11930
11931 * process.c (Qprocessp): Don't declare static.
11932 * lisp.h (Qprocessp): Declare again.
11933
7990b61a
JB
119342011-04-15 Juanma Barranquero <lekktu@gmail.com>
11935
11936 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11937
5d4cb038
PE
119382011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11939
8bd7b830 11940 Improve C-level modularity by making more things 'static'.
cd64ea1d 11941
e3b27b31
PE
11942 Don't publish debugger-only interfaces to other modules.
11943 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11944 (verify_bytepos, count_markers): Move decls to the only modules
11945 that need them.
11946 * region-cache.h (pp_cache): Likewise.
11947 * window.h (check_all_windows): Likewise.
11948 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11949
5d4cb038
PE
11950 * sysdep.c (croak): Now static, if
11951 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11952 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11953
11954 * alloc.c (refill_memory_reserve): Now static if
11955 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11956 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11957
e87b6180
PE
11958 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11959 Define only if USE_LUCID.
11960
ac64929e
PE
11961 * xrdb.c (x_customization_string, x_rm_string): Now static.
11962
6f37259d
PE
11963 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11964 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11965
1683e3ab
PE
11966 * xdisp.c (draw_row_with_mouse_face): Now static.
11967 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11968
de9c2632
PE
11969 * window.h (check_all_windows): Mark externally visible.
11970
2b96acb7
PE
11971 * window.c (window_deletion_count): Now static.
11972
11973 * undo.c: Make symbols static if they're not exported.
11974 (last_undo_buffer, last_boundary_position, pending_boundary):
11975 Now static.
11976
50436f33
PE
11977 * textprop.c (interval_insert_behind_hooks): Now static.
11978 (interval_insert_in_front_hooks): Likewise.
11979
64520e5c
PE
11980 * term.c: Make symbols static if they're not exported.
11981 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11982 (max_frame_lines, tty_set_terminal_modes):
11983 (tty_reset_terminal_modes, tty_turn_off_highlight):
11984 (get_tty_terminal): Now static.
11985 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11986 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11987 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11988 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11989 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11990
1fa53021
PE
11991 * sysdep.c: Make symbols static if they're not exported.
11992 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11993 Now static.
11994 (sigprocmask_set, full_mask): Remove; unused.
11995 (wait_debugging): Mark as visible.
11996 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11997 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11998
d4b43b22
PE
11999 * syntax.c (syntax_temp): Define only if !__GNUC__.
12000
b7c513d0
PE
12001 * sound.c (current_sound_device, current_sound): Now static.
12002
989b29ad
PE
12003 * search.c (searchbufs, searchbuf_head): Now static.
12004
13a55a78
PE
12005 * scroll.c (scroll_cost): Remove; unused.
12006 * dispextern.h (scroll_cost): Remove decl.
12007
de68a1fc
PE
12008 * region-cache.h (pp_cache): Mark as externally visible.
12009
40ccffa6
PE
12010 * process.c: Make symbols static if they're not exported.
12011 (process_tick, update_tick, create_process, chan_process):
12012 (Vprocess_alist, proc_buffered_char, datagram_access):
12013 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12014 (deactivate_process): Mark defn as static, as well as decl.
12015 * lisp.h (create_process): Remove decl.
12016 * process.h (chan_process, Vprocess_alist): Remove decls.
12017
ad64fc97
PE
12018 * print.c: Make symbols static if they're not exported.
12019 (print_depth, new_backquote_output, being_printed, print_buffer):
12020 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12021 (print_interval, print_number_index, initial_stderr_stream):
12022 Now static.
12023 * lisp.h (Fprinc): Remove decl.
12024 (debug_output_compilation_hack): Mark as externally visible.
12025
adddb265
PE
12026 * sysdep.c (croak): Move decl from here to syssignal.h.
12027 * syssignal.h (croak): Put it here, so the API can be checked when
12028 'croak' is called from dissociate_if_controlling_tty.
12029
1717ede2
PE
12030 * minibuf.c: Make symbols static if they're not exported.
12031 (minibuf_save_list, choose_minibuf_frame): Now static.
12032 * lisp.h (choose_minibuf_frame): Remove decl.
12033
fa5fb2bc
PE
12034 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12035
1e3890d1
PE
12036 * lread.c: Make symbols static if they're not exported.
12037 (read_objects, initial_obarray, oblookup_last_bucket_number):
12038 Now static.
12039 (make_symbol): Remove; unused.
12040 * lisp.h (initial_obarray, make_symbol): Remove decls.
12041
8a1414fa
PE
12042 * keyboard.c: Make symbols static if they're not exported.
12043 (single_kboard, recent_keys_index, total_keys, recent_keys):
12044 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12045 (this_single_command_key_start, echoing, last_auto_save):
12046 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12047 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12048 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12049 (Vlispy_mouse_stem, double_click_count):
12050 Now static.
12051 (force_auto_save_soon): Define only if SIGDANGER.
12052 (ignore_mouse_drag_p): Now static if
12053 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12054 (print_help): Remove; unused.
12055 (stop_character, last_timer_event): Mark as externally visible.
12056 * keyboard.h (ignore_mouse_drag_p): Declare only if
12057 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12058 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12059 * lisp.h (echoing): Remove decl.
12060 (force_auto_save_soon): Declare only if SIGDANGER.
12061 * xdisp.c (redisplay_window): Simplify code, to make it more
12062 obvious that ignore_mouse_drag_p is not accessed if !defined
12063 USE_GTK && !defined HAVE_NS.
12064
93ea6e8f
PE
12065 * intervals.c: Make symbols static if they're not exported.
12066 (merge_properties_sticky, merge_interval_right, delete_interval):
12067 Now static.
12068 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12069
77382fcc
PE
12070 * insdel.c: Make symbols static if they're not exported.
12071 However, leave prepare_to_modify_buffer alone. It's never
12072 called from outside this function, but that appears to be a bug.
12073 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12074 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12075 (adjust_after_replace_noundo): Remove; unused.
12076 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12077 (signal_before_change): Remove decls.
77382fcc 12078
9306c32e
PE
12079 * indent.c (val_compute_motion, val_vmotion): Now static.
12080
cd44d2eb
PE
12081 * image.c: Make symbols static if they're not exported.
12082 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12083 if USE_GTK.
12084 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12085 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12086
ad9a7a06
PE
12087 * fringe.c (standard_bitmaps): Now static.
12088 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12089
81626931
PE
12090 * frame.c: Make symbols static if they're not exported.
12091 (x_report_frame_params, make_terminal_frame): Now static.
12092 (get_frame_param): Now static, unless HAVE_NS.
12093 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12094 (x_get_resource_string): Remove; not used.
12095 * frame.h (make_terminal_frame, x_report_frame_params):
12096 (x_get_resource_string); Remove decls.
12097 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12098 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12099
239f9db9
PE
12100 * font.c, fontset.c: Make symbols static if they're not exported.
12101 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12102 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12103 * font.c (font_close_object): Now static.
12104 * font.h (font_close_object): Remove.
12105 * fontset.c (FONTSET_OBJLIST): Remove.
12106 (free_realized_fontset) #if-0 the body, which does nothing.
12107 (face_suitable_for_char_p): #if-0, as it's never called.
12108 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12109 * xfaces.c (face_at_string_position):
12110 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12111 since 0 is always ASCII.
12112
dfcf3579
PE
12113 * fns.c (weak_hash_tables): Now static.
12114
5045092b
PE
12115 * fileio.c: Make symbols static if they're not exported.
12116 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12117 (Vwrite_region_annotation_buffers): Now static.
12118
57a96f5c
PE
12119 * eval.c: Make symbols static if they're not exported.
12120 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12121 * lisp.h (backtrace_list): Remove decl.
12122
35f08c38
PE
12123 * emacs.c: Make symbols static if they're not exported.
12124 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12125 (fatal_error_code, fatal_error_signal_hook, standard_args):
12126 Now static.
12127 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12128 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12129 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12130 * lisp.h (fatal_error_signal_hook): Remove decl.
12131 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12132
f44bd759
PE
12133 * editfns.c: Move a (normally-unused) function to its only use.
12134 * editfns.c, lisp.h (get_operating_system_release): Remove.
12135 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12136 worth the hassle of breaking this out.
12137
b532497d
PE
12138 * xterm.c: Make symbols static if they're not exported.
12139 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12140 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12141 (x_destroy_window, x_delete_display):
12142 Now static.
12143 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12144 (x_mouse_leave): Remove; unused.
12145 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12146 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12147 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12148 Remove decls.
12149 (x_mouse_leave): Declare only if WINDOWSNT.
12150 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12151 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12152 USE_X_TOOLKIT.
12153
1675728f
PE
12154 * ftxfont.c: Make symbols static if they're not exported.
12155 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12156 HAVE_FREETYPE.
12157 * font.h (ftxfont_driver): Likewise.
12158
e4cebfca
PE
12159 * xfns.c: Make symbols static if they're not exported.
12160 (x_last_font_name, x_display_info_for_name):
12161 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12162 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12163 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12164 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12165 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12166 (last_show_tip_args): Now static.
12167 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12168 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12169 (x_screen_planes): Remove; unused.
12170 * dispextern.h (x_screen_planes): Remove decl.
12171
5bf46f05
PE
12172 * dispnew.c: Make symbols static if they're not exported.
12173 * dispextern.h (redraw_garbaged_frames, scrolling):
12174 (increment_row_positions): Remove.
12175 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12176 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12177 Now static.
12178 (redraw_garbaged_frames): Remove; unused.
12179
435f4c28
PE
12180 * xfaces.c: Make symbols static if they're not exported.
12181 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12182 Remove decls.
12183 * xterm.h (defined_color): Remove decls.
12184 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12185 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12186 (menu_face_changed_default, defined_color, free_realized_face):
12187 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12188 (ascii_face_of_lisp_face): Remove; unused.
12189
8524aef3
PE
12190 * xdisp.c: Make symbols static if they're not exported.
12191 * dispextern.h (scratch_glyph_row, window_box_edges):
12192 (glyph_to_pixel_coords, set_cursor_from_row):
12193 (get_next_display_element, set_iterator_to_next):
12194 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12195 (show_mouse_face): Remove decls
12196 * frame.h (message_buf_print): Likewise.
12197 * lisp.h (pop_message, set_message, check_point_in_composition):
12198 Likewise.
12199 * xterm.h (set_vertical_scroll_bar): Likewise.
12200 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12201 (message_buf_print, scratch_glyph_row, displayed_buffer):
12202 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12203 (get_next_display_element, show_mouse_face, window_box_edges):
12204 (frame_to_window_pixel_xy, check_point_in_composition):
12205 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12206 (glyph_to_pixel_coords): Remove; unused.
12207
16390cd2
PE
12208 * dired.c (file_name_completion): Now static.
12209
12210 * dbusbind.c (xd_in_read_queued_messages): Now static.
12211
a25f4dfa
PE
12212 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12213 * data.c (circular_list_error): Remove.
12214
14a9c8df
PE
12215 * commands.h (last_point_position, last_point_position_buffer):
12216 (last_point_position_window): Remove decls.
12217 * keyboard.c: Make these variables static.
12218
04f2d78b
CB
12219 * coding.h (coding, code_convert_region, encode_coding_gap):
12220 Remove decls.
74ab6df5
PE
12221 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12222 (iso_code_class, detect_coding, code_convert_region): Now static.
12223 (encode_coding_gap): Remove; unused.
12224
38dfbee1
PE
12225 * chartab.c (chartab_chars, chartab_bits): Now static.
12226
a2cb4e63
PE
12227 * charset.h (charset_iso_8859_1): Remove decl.
12228 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12229 Now static.
12230
127198fd
PE
12231 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12232 * ccl.c (Vccl_program_table): Now static.
12233 (check_ccl_update): Remove; unused.
12234
d85b608f
PE
12235 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12236 * category.h: ... from here.
12237 * category.c (check_category_table, set_category_set): Now static.
12238
31cd66f3
PE
12239 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12240 * lisp.h: Remove these decls.
12241
c358e587
PE
12242 * buffer.c (buffer_count): Remove unused var.
12243
e78aecca
PE
12244 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12245 so that it's not optimized away.
12246 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12247 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12248 exported only to the debugger.
12249
e192d7d3 12250 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12251 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12252
92470028
PE
12253 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12254 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12255 was inaccessible from Lisp.
12256 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12257 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12258
244ed907
PE
12259 alloc.c: Import and export fewer symbols, and remove unused items.
12260 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12261 is defined.
12262 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12263 it's not optimized away by whole-program optimization.
12264 (message_enable_multibyte, free_misc): Remove.
12265 (catchlist, handlerlist, mark_backtrace):
12266 Declare only if BYTE_MARK_STACK.
12267 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12268 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12269 (message_enable_multibyte): Remove decl.
12270 (free_misc, interval_free_list, float_block, float_block_index):
12271 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12272 (cons_free_list, last_marked_index):
12273 Now static.
12274 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12275 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12276 (mark_backtrace): Define only if BYTE_MARK_STACK.
12277 * xdisp.c (message_enable_multibyte): Now static.
12278
61c2b50e 12279 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12280 This makes it easier for human readers (and static analyzers)
12281 to see whether these variables are used from other modules.
12282 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12283 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12284 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12285 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12286 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12287 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12288 * xmenu.c, xselect.c:
12289 Declare Q* vars static if they are not used in other modules.
12290 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12291 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12292 Remove decls of unexported vars.
12293 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12294
95c82688
PE
12295 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12296
16a97296
PE
12297 Make Emacs functions such as Fatom 'static' by default.
12298 This makes it easier for human readers (and static analyzers)
12299 to see whether these functions can be called from other modules.
12300 DEFUN now defines a static function. To make the function external
12301 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12302 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12303 (Finit_image_library):
16a97296
PE
12304 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12305 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12306 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12307 Remove decls, since these functions are now static.
12308 (Funintern, Fget_internal_run_time): New decls, since these functions
12309 were already external.
95c82688 12310
16a97296
PE
12311 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12312 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12313 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12314 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12315 * keyboard.c, keymap.c, lread.c:
12316 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12317 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12318 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12319 Mark functions with DEFUE instead of DEFUN,
12320 if they are used in other modules.
12321 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12322 decls for now-static functions.
12323 * buffer.h (Fdelete_overlay): Remove decl.
12324 * callproc.c (Fgetenv_internal): Mark as internal.
12325 * composite.c (Fremove_list_of_text_properties): Remove decl.
12326 (Fcomposition_get_gstring): New forward static decl.
12327 * composite.h (Fcomposite_get_gstring): Remove decl.
12328 * dired.c (Ffile_attributes): New forward static decl.
12329 * doc.c (Fdocumntation_property): New forward static decl.
12330 * eval.c (Ffetch_bytecode): New forward static decl.
12331 (Funintern): Remove extern decl; now in .h file where it belongs.
12332 * fileio.c (Fmake_symbolic_link): New forward static decl.
12333 * image.c (Finit_image_library): New forward static decl.
12334 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12335 * intervals.h (Fprevious_property_change):
12336 (Fremove_list_of_text_properties): Remove decls.
12337 * keyboard.c (Fthis_command_keys): Remove decl.
12338 (Fcommand_execute): New forward static decl.
12339 * keymap.c (Flookup_key): New forward static decl.
12340 (Fcopy_keymap): Now static.
12341 * keymap.h (Flookup_key): Remove decl.
12342 * process.c (Fget_process): New forward static decl.
12343 (Fprocess_datagram_address): Mark as internal.
12344 * syntax.c (Fsyntax_table_p): New forward static decl.
12345 (skip_chars): Remove duplicate decl.
12346 * textprop.c (Fprevious_property_change): New forward static decl.
12347 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12348 Now internal.
12349 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12350 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12351
785bbd42
PE
12352 * editfns.c (Fformat): Remove unreachable code.
12353
8b913b57
AS
123542011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12355
12356 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12357 change. (Bug#8496)
12358
a6744a35
EZ
123592011-04-13 Eli Zaretskii <eliz@gnu.org>
12360
12361 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12362 when at ZV. (Bug#8487)
12363
e7974947
AS
123642011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12365
baad03f0
AS
12366 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12367 (Bug#8437)
12368 * keyboard.c (parse_tool_bar_item): Likewise.
12369 * sound.c (sound_cleanup, alsa_close): Likewise.
12370 * termcap.c (tgetent): Likewise.
12371 * xfns.c (x_default_font_parameter): Likewise.
12372 * xsettings.c (read_and_apply_settings): Likewise.
12373
e7974947
AS
12374 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12375 (overrun_check_free): Protoize.
12376
28272684
PE
123772011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12378
12379 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12380 since callers should never pass a negative size.
12381 Change the signature to match that of plain 'read' and 'write'; see
12382 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12383 * lisp.h: Update prototypes of emacs_write and emacs_read.
12384
11997c76
EZ
123852011-04-11 Eli Zaretskii <eliz@gnu.org>
12386
12387 * xdisp.c (redisplay_window): Don't try to determine the character
12388 position of the scroll margin if the window start point w->startp
e896f03c 12389 is outside the buffer's accessible region. (Bug#8468)
11997c76 12390
8a2cbd72
EZ
123912011-04-10 Eli Zaretskii <eliz@gnu.org>
12392
12393 Fix write-region and its subroutines for buffers > 2GB.
12394 * fileio.c (a_write, e_write): Modify declaration of arguments and
12395 local variables to support buffers larger than 2GB.
12396 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12397
12398 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12399 argument, local variables, and return value.
12400
12401 * lisp.h: Update prototypes of emacs_write and emacs_read.
12402
12403 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12404
4073e537 124052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12406
1ebfdcb6
PE
12407 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12408
b2ded58d
PE
12409 Fix more problems found by GCC 4.6.0's static checks.
12410
7d66342c
PE
12411 * xdisp.c (vmessage): Use a better test for character truncation.
12412
bbf47d44
PE
12413 * charset.c (load_charset_map): <, not <=, for optimization,
12414 and to avoid potential problems with integer overflow.
9248994d 12415 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12416 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12417 * editfns.c (Fformat): Likewise.
1e69125e 12418 * syntax.c (skip_chars): Likewise.
3befa583 12419
e3019616
PE
12420 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12421 This also lets GCC 4.6.0 generate slightly better loop code.
12422
becfa255
PE
12423 * callint.c (Fcall_interactively): <, not <=, for optimization.
12424 (Fcall_interactively): Count the number of arguments produced,
12425 not the number of arguments given. This is simpler and lets GCC
12426 4.6.0 generate slightly better code.
12427
dae0cd48
PE
12428 * ftfont.c: Distingish more carefully between FcChar8 and char.
12429 The previous code passed unsigned char * to a functions like
12430 strlen and xstrcasecmp that expect char *, which does not
12431 conform to the C standard.
12432 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12433 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12434 char * when the C standard requires it.
12435
76032d70
PE
12436 * keyboard.c (read_char): Remove unused var.
12437
eb3f1cc8
PE
12438 * eval.c: Port to Windows vsnprintf (Bug#8435).
12439 Include <limits.h>.
12440 (SIZE_MAX): Define if the headers do not.
12441 (verror): Do not give up if vsnprintf returns a negative count.
12442 Instead, grow the buffer. This ports to Windows vsnprintf, which
12443 does not conform to C99. Problem reported by Eli Zaretskii.
12444 Also, simplify the allocation scheme, by avoiding the need for
12445 calling realloc, and removing the ALLOCATED variable.
12446
70476b54
PE
12447 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12448
12020a9e
PE
12449 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12450 But keep the doprint source code for now, as we might revamp it
12451 and use it again (Bug#8435).
ea6c7ae6
PE
12452 * lisp.h (doprnt): Remove.
12453 * Makefile.in (base_obj): Remove doprnt.o.
12454 * deps.mk (doprnt.o): Remove.
12455
5fdb398c
PE
12456 error: Print 32- and 64-bit integers portably (Bug#8435).
12457 Without this change, on typical 64-bit hosts error ("...%d...", N)
12458 was used to print both 32- and 64-bit integers N, which relied on
12459 undefined behavior.
61bdb816 12460 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12461 * lisp.h (error, verror): Mark as printf-like functions.
12462 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12463 Report overflow in size calculations when allocating printf buffer.
12464 Do not truncate output string at its first null byte.
12465 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12466 Truncate the output at a character boundary, since vsnprintf does not
12467 do that.
12468 * charset.c (check_iso_charset_parameter): Convert internal
12469 character to string before calling 'error', since %c now has the
12470 printf meaning.
12471 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12472 overflow when computing char to be passed to 'error'. Do not
12473 pass Lisp_Object to 'error'; pass the integer instead.
12474 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12475 formatted with plain %d.
12476
b189fa66
PE
12477 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12478
bff87ef0
PE
12479 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12480
7e2cac20
PE
12481 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12482
ce4d90b5
PE
12483 * xterm.c (x_catch_errors): Remove duplicate declaration.
12484
266c9547
PE
12485 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12486
79c49ad2
PE
12487 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12488
368f4090
JM
124892011-04-10 Jim Meyering <meyering@redhat.com>
12490
12491 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12492 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12493 return ssize_t not "int", and use size_t as the buffer length.
12494 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12495 * gnutls.h: Update declarations.
12496 * process.c (read_process_output): Use ssize_t, to match.
12497 (send_process): Likewise.
12498
a32d4040
CY
124992011-04-09 Chong Yidong <cyd@stupidchicken.com>
12500
12501 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12502
8546720e 125032011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12504
04f2d78b
CB
12505 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12506 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12507
8546720e
GM
12508 * xterm.c (handle_one_xevent):
12509 * xmenu.c (create_and_show_popup_menu):
12510 * xselect.c (x_decline_selection_request)
12511 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12512
0a2f5c1a 125132011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12514
12515 Fix some uses of `int' instead of EMACS_INT.
12516 * search.c (string_match_1, fast_string_match)
12517 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12518 (scan_buffer, find_next_newline_no_quit)
12519 (find_before_next_newline, search_command, Freplace_match)
12520 (Fmatch_data): Make some `int' variables be EMACS_INT.
12521
12522 * xdisp.c (display_count_lines): 3rd argument and return value now
12523 EMACS_INT. All callers changed.
12524 (pint2hrstr): Last argument is now EMACS_INT.
12525
12526 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12527 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12528 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12529 (decode_coding_utf_16, decode_coding_emacs_mule)
12530 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12531 (decode_coding_ccl, decode_coding_charset)
12532 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12533 (decode_coding_iso_2022, decode_coding_emacs_mule)
12534 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12535 <char_offset, last_offset>: Declare EMACS_INT.
12536 (encode_coding_utf_8, encode_coding_utf_16)
12537 (encode_coding_emacs_mule, encode_invocation_designation)
12538 (encode_designation_at_bol, encode_coding_iso_2022)
12539 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12540 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12541 Declare EMACS_INT.
12542 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12543 (encode_invocation_designation): Last argument P_NCHARS is now
12544 EMACS_INT.
12545 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12546 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12547
12548 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12549 All users changed.
12550
12551 * ccl.c (Fccl_execute_on_string): Declare some variables
12552 EMACS_INT.
12553
8546720e 125542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12555
12556 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12557
4e19a977
CS
125582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12559
12560 * process.c (Fformat_network_address): Doc fix.
12561
87302331
R
125622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12563
ee7683eb 12564 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12565
cbb59342
CY
125662011-04-08 Chong Yidong <cyd@stupidchicken.com>
12567
12568 * keyboard.c (read_char): Call Lisp function help-form-show,
12569 instead of using internal_with_output_to_temp_buffer.
12570 (Qhelp_form_show): New var.
e0d38eeb 12571 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12572
12573 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12574
12575 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12576
e67a13ab
CY
125772011-04-06 Chong Yidong <cyd@stupidchicken.com>
12578
04f2d78b
CB
12579 * process.c (Flist_processes): Remove to Lisp.
12580 (list_processes_1): Delete.
e67a13ab 12581
973f782d
EZ
125822011-04-06 Eli Zaretskii <eliz@gnu.org>
12583
7c106b1e
EZ
12584 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12585
973f782d
EZ
12586 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12587
41cf7d1a 125882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12589
ca23cc88
PE
12590 Fix more problems found by GCC 4.6.0's static checks.
12591
f390e2d5
PE
12592 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12593
42eea0d0
PE
12594 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12595
b69769da 12596 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12597
f9541e84
PE
12598 * xdisp.c (vmessage): Mark as a printf-like function.
12599
13841b55
PE
12600 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12601
c136c10f
PE
12602 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12603
5e2d4a30
PE
12604 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12605 printf-like functions.
12606 (tiff_load): Add casts to remove these marks before passing them
12607 to system-supplied API.
12608
583f48b9
PE
12609 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12610
b25d760e
PE
12611 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12612 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12613 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12614 directly, rather than having caller test rule sign. This avoids
12615 some unnecessary tests.
12616 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12617 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12618 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12619
bc7b6697 12620 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12621 (xfont_open): Avoid unnecessary tests.
bc7b6697 12622
27ccc379
PE
12623 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12624
dcd5c89a
PE
12625 * composite.h, composite.c (composition_gstring_put_cache):
12626 Use EMACS_INT, not int, for length.
12627
b13a45c6
PE
12628 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12629 breaking out part of COMPOSITION_DECODE_RULE.
12630 (COMPOSITION_DECODE_RULE): Use it.
12631 * composite.c (get_composition_id): Remove unused local vars,
12632 by using the new macro.
12633
1e792e4d
PE
12634 * textprop.c (set_text_properties_1): Change while to do-while,
12635 since the condition is always true at first.
12636
dc6c6455 12637 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12638 (interval_deletion_adjustment): Return unsigned value.
12639 All uses changed.
dc6c6455 12640
aba7731a
PE
12641 * process.c (list_processes_1, create_pty, read_process_output):
12642 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12643 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12644 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12645 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12646 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12647
fdfc4bf3
PE
12648 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12649
fca8fe46 12650 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12651 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12652
06a0259a 12653 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12654 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12655 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12656
e7b9e80f
PE
12657 * print.c (print_error_message): Avoid int overflow.
12658
56201685
PE
12659 * font.c (font_list_entities): Redo for clarity,
12660 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12661
78834453 12662 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12663 (font_score): Avoid potential overflow in diff calculation.
78834453 12664
0bc0b309 12665 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12666 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12667
e610eaca
PE
12668 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12669
b895abce
PE
12670 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12671 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12672 can always succeed if overflow has undefined behavior.
12673
1f1d9321 12674 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12675 (wordify): Omit three unnecessary tests.
1f1d9321 12676
c59478bc
PE
12677 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12678 All callers changed. This avoids the need for an unused var.
12679
79b73827
PE
12680 * casefiddle.c (casify_region): Remove var that is set but not used.
12681
a4db5dfe
PE
12682 * dired.c (file_name_completion): Remove var that is set but not used.
12683
43aae36e
PE
12684 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12685
2a47c44d 12686 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12687 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12688
a37c69bf
PE
12689 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12690 Check for integer overflow on size calculations.
12691
328ab8e7
PE
12692 * buffer.c (Fprevious_overlay_change): Remove var that is set
12693 but not used.
12694
e5a2a5cb
PE
12695 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12696 Remove vars that are set but not used.
8d84a6eb 12697 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12698 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12699
a60e5f68
PE
12700 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12701
f661cb61 12702 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12703 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12704
f0397f5a
PE
12705 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12706 that are set but not used.
12707
8664db06 12708 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12709 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12710
6abdaa4a
PE
12711 * xselect.c (x_get_local_selection, x_handle_property_notify):
12712 Remove vars that are set but not used.
12713
0ce7538d 12714 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12715 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12716
9ae848fc
PE
12717 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12718 Remove var that is set but not used.
0b918413
PE
12719 (scroll_bar_windows_size): Now size_t, not int.
12720 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12721 Check for overflow.
9ae848fc 12722
a5a62657
PE
12723 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12724 (map_tty_color) [!defined MSDOS]: Likewise.
12725
5c5cdd39
PE
12726 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12727
66ebf983
PE
12728 * coding.c: Remove vars that are set but not used.
12729 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12730 All callers changed.
12731 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12732 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12733 (decode_coding_charset): Remove vars that are set but not used.
12734
1be4d761
PE
12735 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12736 that is set but not used.
12737
47553fa8
PE
12738 * print.c (print_object): Remove var that is set but not used.
12739
1f7196bf 12740 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12741 The gnulib version avoids calling malloc in the usual case,
12742 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12743 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12744 * filelock.c (current_lock_owner): Likewise.
12745 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12746 * sysdep.c: Include allocator.h, careadlinkat.h.
12747 (emacs_no_realloc_allocator): New static constant.
12748 (emacs_readlink): New function.
fdb61804
PE
12749 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12750 ../lib/careadlinkat.h.
d1fdcab7 12751
f84c17c7
SM
127522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12753
12754 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12755 first non-nil return value).
12756
ef3862ad
JD
127572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12758
12759 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12760 if not defined (Bug#8403).
12761
376a7006
JB
127622011-04-02 Juanma Barranquero <lekktu@gmail.com>
12763
12764 * xdisp.c (display_count_lines): Remove parameter `start',
12765 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12766 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12767 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12768 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12769 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12770 and thereabouts. All callers changed.
12771 (get_per_char_metric): Remove parameter `f', unused since
12772 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12773
6ca3801d
JM
127742011-04-02 Jim Meyering <meyering@redhat.com>
12775
12776 do not dereference NULL upon failed strdup
12777 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12778 (ns_get_family): Likewise.
12779
d8e2b5ba
JB
127802011-04-02 Juanma Barranquero <lekktu@gmail.com>
12781
12782 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12783
8c74fcbd
JD
127842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12785
12786 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12787 later (Bug#8403).
12788
7200d79c
SM
127892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12790
03408648 12791 Add lexical binding.
7200d79c 12792
03408648
SM
12793 * window.c (Ftemp_output_buffer_show): New fun.
12794 (Fsave_window_excursion):
12795 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12796
12797 * lread.c (lisp_file_lexically_bound_p): New function.
12798 (Fload): Bind Qlexical_binding.
12799 (readevalloop): Remove `evalfun' arg.
12800 Bind Qinternal_interpreter_environment.
12801 (Feval_buffer): Bind Qlexical_binding.
12802 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12803 Mark as dynamic.
12804 (syms_of_lread): Declare `lexical-binding'.
12805
12806 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12807
12808 * keyboard.c (eval_dyn): New fun.
12809 (menu_item_eval_property): Use it.
ca105506
SM
12810
12811 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12812
03408648
SM
12813 * fns.c (concat, mapcar1): Accept byte-code-functions.
12814
12815 * eval.c (Fsetq): Handle lexical vars.
12816 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12817 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12818 (FletX, Flet): Obey lexical binding.
12819 (Fcommandp): Handle closures.
12820 (Feval): New `lexical' arg.
12821 (eval_sub): New function extracted from Feval. Use it almost
12822 everywhere where Feval was used. Look up vars in lexical env.
12823 Handle closures.
12824 (Ffunctionp): Move from subr.el.
12825 (Ffuncall): Handle closures.
12826 (apply_lambda): Remove `eval_flags'.
12827 (funcall_lambda): Handle closures and new byte-code-functions.
12828 (Fspecial_variable_p): New function.
12829 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12830 but without exporting it to Lisp.
23aba0ea 12831
23aba0ea 12832 * doc.c (Fdocumentation, store_function_docstring):
03408648 12833 * data.c (Finteractive_form): Handle closures.
23aba0ea 12834
03408648
SM
12835 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12836 interactive spec.
ba83908c 12837
04f2d78b
CB
12838 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12839 New byte-codes.
03408648
SM
12840 (exec_byte_code): New function extracted from Fbyte_code to handle new
12841 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12842
03408648 12843 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12844
03408648 12845 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12846
e2abce01
JB
128472011-03-31 Juanma Barranquero <lekktu@gmail.com>
12848
12849 * xdisp.c (redisplay_internal): Fix prototype.
12850
63696a73 128512011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12852
63696a73 12853 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12854 (try_scrolling): Use it when setting scroll_limit.
12855 Limit scrolling to 100 screen lines.
63696a73
EZ
12856 (redisplay_window): Even when falling back on "recentering",
12857 position point in the window according to scroll-conservatively,
12858 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12859
12860 (try_scrolling): When point is above the window, allow searching
12861 as far as scroll_max, or one screenful, to compute vertical
12862 distance from PT to the scroll margin position. This prevents
12863 try_scrolling from unnecessarily failing when
12864 scroll-conservatively is set to a value slightly larger than the
12865 window height. Clean up the case of PT below the margin at bottom
12866 of window: scroll_max can no longer be INT_MAX. When aggressive
12867 scrolling is in use, don't let point enter the opposite scroll
12868 margin as result of the scroll.
12869 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12870 threshold of 100 lines for never-recentering scrolling.
12871
e4cc2dfc
JB
128722011-03-31 Juanma Barranquero <lekktu@gmail.com>
12873
12874 * dispextern.h (move_it_by_lines):
12875 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12876 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12877 (message_log_check_duplicate): Remove parameters `prev_bol' and
12878 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12879 (redisplay_internal): Remove parameter `preserve_echo_area',
12880 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12881
12882 * indent.c (Fvertical_motion):
12883 * window.c (window_scroll_pixel_based, Frecenter):
12884 Don't pass `need_y_p' to `move_it_by_lines'.
12885
1c470562
SM
128862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12887
44f230aa
SM
12888 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12889 steal a few bits to be more compact.
12890 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12891 Remove unneeded casts.
12892
1c470562
SM
12893 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12894
888adce9
ZK
128952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12896
12897 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12898 binding" message (bug#7967).
12899
f838ed7b
PE
129002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12901
77861b95
PE
12902 Fix more problems found by GCC 4.6.0's static checks.
12903
de6dbc14
PE
12904 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12905 Remove unused local var.
12906
f838ed7b
PE
12907 * editfns.c (Fmessage_box): Remove unused local var.
12908
792c7b2b
PE
12909 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12910 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12911 Omit unused local vars.
c499e557 12912 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12913 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12914 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12915 Omit unused local var.
12916
ba0165e1
PE
12917 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12918 Don't assume string length fits in int.
32ad8845 12919 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12920 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12921
3c59b4c9
PE
12922 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12923 instead of alloca (Bug#8344).
12924
a3eed478 12925 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12926 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12927
eb4d412d
PE
12928 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12929
1658b401
PE
12930 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12931 concerns.
12932
12933 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12934
12935 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12936
9a2c6e05
PE
12937 * keyboard.c (syms_of_keyboard): Use the same style as later
12938 in this function when indexing through an array. This also
12939 works around GCC bug 48267.
12940
03d0a109
PE
12941 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12942
44f730c8
PE
12943 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12944
fe75f926
PE
12945 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12946 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12947
ffa8c828
PE
12948 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12949 This avoids undefined behavior on integer overflow, and is a bit
12950 more convenient anyway since it is compared to a size_t variable.
12951
c5101a77
PE
12952 Variadic C functions now count arguments with size_t, not int.
12953 This avoids an unnecessary limitation on 64-bit machines, which
12954 caused (substring ...) to crash on large vectors (Bug#8344).
12955 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12956 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12957 All variadic functions and their callers changed accordingly.
c5101a77
PE
12958 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12959 * data.c (arith_driver, float_arith_driver): Likewise.
12960 * editfns.c (general_insert_function): Likewise.
12961 * eval.c (struct backtrace.nargs, interactive_p)
12962 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12963 (funcall_lambda, mark_backtrace): Likewise.
12964 * fns.c (concat): Likewise.
12965 * frame.c (x_set_frame_parameters): Likewise.
12966 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12967 0 if not found, not -1. All callers changed.
12968
dd3f25f7
PE
12969 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12970 (stack_copy_size): Now size_t, not int.
12971 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12972
461c2ab9
JB
129732011-03-28 Juanma Barranquero <lekktu@gmail.com>
12974
12975 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12976 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12977 All callers changed.
12978
12979 * lisp.h (multibyte_char_to_unibyte):
12980 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12981 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12982 * character.h (CHAR_TO_BYTE8):
12983 * cmds.c (internal_self_insert):
12984 * editfns.c (general_insert_function):
12985 * keymap.c (push_key_description):
12986 * search.c (Freplace_match):
12987 * xdisp.c (message_dolog, set_message_1): All callers changed.
12988
f6d62986
SM
129892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12990
12991 * keyboard.c (safe_run_hook_funcall): New function.
12992 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12993 don't set the hook to nil, but remove the offending function instead.
12994 (Qcommand_hook_internal): Remove, unused.
12995 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12996 Vcommand_hook_internal.
12997
12998 * eval.c (enum run_hooks_condition): Remove.
12999 (funcall_nil, funcall_not): New functions.
13000 (run_hook_with_args): Call each function through a `funcall' argument.
13001 Remove `cond' argument, now redundant.
13002 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13003 (Frun_hook_with_args_until_failure): Adjust accordingly.
13004 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13005
1db5b1ad
JB
130062011-03-28 Juanma Barranquero <lekktu@gmail.com>
13007
13008 * dispextern.h (string_buffer_position): Remove declaration.
13009
13010 * print.c (strout): Remove parameter `multibyte', unused since
13011 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13012
13013 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13014 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13015 All callers changed.
13016
13017 * w32.c (_wsa_errlist): Use braces for struct initializers.
13018
13019 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13020 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13021 All callers changed.
13022 (string_buffer_position): Likewise. Also, make static (it's never
13023 used outside xdisp.c).
13024 (cursor_row_p): Remove parameter `w', unused since
13025 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13026 (decode_mode_spec): Remove parameter `precision', introduced during
13027 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13028 All callers changed.
13029
5ffb62aa
JD
130302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13031
13032 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13033
461c2ab9 130342011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13035
13036 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13037 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13038 (ns_update_auto_hide_menu_bar): New functions.
13039 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13040 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13041 ns_constrain_all_frames.
13042 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13043 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13044
5c380ffb
JD
130452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13046
13047 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13048
9af30bdf
GM
130492011-03-27 Glenn Morris <rgm@gnu.org>
13050
13051 * syssignal.h: Replace RETSIGTYPE with void.
13052 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13053 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13054 Replace SIGTYPE with void everywhere.
13055 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13056 * s/template.h (SIGTYPE): Remove commented out definition.
13057
e2abce01
JB
130582011-03-26 Eli Zaretskii <eliz@gnu.org>
13059
13060 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13061 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13062
f868cd8a
JB
130632011-03-26 Juanma Barranquero <lekktu@gmail.com>
13064
59eb0929
JB
13065 * w32.c (read_unc_volume): Use parameter `henum', instead of
13066 global variable `wget_enum_handle'.
13067
13068 * keymap.c (describe_vector): Remove parameters `indices' and
13069 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13070 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13071
f868cd8a
JB
13072 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13073
13074 * keyboard.c (timer_check): Remove parameter `do_it_now',
13075 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13076 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13077 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13078
13079 * keyboard.c (read_char):
13080 * w32menu.c (w32_menu_display_help):
13081 * xmenu.c (show_help_event, menu_help_callback):
13082 Adjust calls to `show_help_echo'.
13083
13084 * gtkutil.c (xg_maybe_add_timer):
13085 * keyboard.c (readable_events):
13086 * process.c (wait_reading_process_output):
13087 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13088
13089 * insdel.c (adjust_markers_gap_motion):
13090 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13091 (gap_left, gap_right): Don't call it.
13092
2ecf6fdb
CY
130932011-03-25 Chong Yidong <cyd@stupidchicken.com>
13094
13095 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13096 incurred during fontification.
13097
6b1f9ba4
JB
130982011-03-25 Juanma Barranquero <lekktu@gmail.com>
13099
13100 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13101 (DEFVAR_PER_BUFFER): Don't pass it.
13102
13103 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13104 (scrolling_window): Don't pass it.
13105
0f4a96b5
JB
131062011-03-25 Juanma Barranquero <lekktu@gmail.com>
13107
13108 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13109
13110 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13111 and `suffix'.
13112 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13113 of variables specific to SELinux and computation of `encoded_absname'.
13114
13115 * image.c (XPutPixel): Remove unused variable `height'.
13116
13117 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13118
13119 * unexw32.c (get_section_info): Remove unused variable `section'.
13120
13121 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13122 (system_process_attributes): Remove unused variable `sess'.
13123 (sys_read): Remove unused variable `err'.
13124
13125 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13126 (w32_wnd_proc): Remove unused variable `isdead'.
13127 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13128 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13129 (x_create_tip_frame): Remove unused variable `tem'.
13130
13131 * w32inevt.c (w32_console_read_socket):
13132 Remove unused variable `no_events'.
13133
13134 * w32term.c (x_draw_composite_glyph_string_foreground):
13135 Remove unused variable `width'.
13136
1149507c
JB
131372011-03-24 Juanma Barranquero <lekktu@gmail.com>
13138
13139 * w32term.c (x_set_glyph_string_clipping):
13140 Don't pass uninitialized region to CombineRgn.
13141
9c88f339
JB
131422011-03-23 Juanma Barranquero <lekktu@gmail.com>
13143
13144 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13145 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13146 (Fx_close_connection): Remove unused variable `i'.
13147
13148 * w32font.c (w32font_draw): Return number of glyphs.
13149 (w32font_open_internal): Remove unused variable `i'.
13150 (w32font_driver): Add missing initializer.
13151
13152 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13153 (fill_in_menu): Remove unused variable `items_added'.
13154
13155 * w32term.c (last_mouse_press_frame): Remove static global variable.
13156 (w32_clip_to_row): Remove unused variable `f'.
13157 (x_delete_terminal): Remove unused variable `i'.
13158
13159 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13160 (NOTHING): Remove unused static global variable.
13161 (uniscribe_check_otf): Remove unused variable `table'.
13162 (uniscribe_font_driver): Add missing initializers.
13163
dee091a3
JD
131642011-03-23 Julien Danjou <julien@danjou.info>
13165
13166 * term.c (Fsuspend_tty, Fresume_tty):
13167 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13168 * window.c (temp_output_buffer_show):
13169 * insdel.c (signal_before_change):
13170 * frame.c (Fhandle_switch_frame):
13171 * fileio.c (Fdo_auto_save):
13172 * emacs.c (Fkill_emacs):
13173 * editfns.c (save_excursion_restore):
13174 * cmds.c (internal_self_insert):
13175 * callint.c (Fcall_interactively):
13176 * buffer.c (Fkill_all_local_variables):
13177 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13178 Use Frun_hooks.
0f4a96b5 13179 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13180 unconditionally since it does the check itself.
dee091a3 13181
2c520ab5 131822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13183
c9c49752
PE
13184 Fix more problems found by GCC 4.5.2's static checks.
13185
8abc3f12
PE
13186 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13187 the first time through the loop, since we know p0 < p1 then.
13188 This also avoids a gcc -Wstrict-overflow warning.
13189
a2d26660
PE
13190 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13191 leading to a memory leak, possible in functions like
13192 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13193 of objects (Bug#8318).
a2d26660 13194
916c72e9
PE
13195 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13196 that could (at least in theory) be that large.
13197
19ab8a18
PE
13198 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13199 This is less likely to overflow, and avoids undefined behavior if
13200 overflow does occur. All callers changed. Use strtoul to scan
13201 for the unsigned long integer.
b7cbbd6f
PE
13202 (pint2hrstr): Simplify and tune code slightly.
13203 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13204
f0641eff
PE
13205 * scroll.c (do_scrolling): Work around GCC bug 48228.
13206 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13207
7f650bb9
PE
13208 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13209 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13210 (validate_x_resource_name): Simplify count usage.
13211 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13212
37dd57d1
PE
13213 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13214 fail (Bug#8306).
81e56e61 13215
699979fc 13216 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13217
401bf9b4
PE
13218 * process.c (Fmake_network_process): Use socklen_t, not int,
13219 where POSIX says socklen_t is required in portable programs.
13220 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13221 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13222 (Fmake_network_process, server_accept_connection):
13223 (wait_reading_process_output, read_process_output):
13224 Likewise.
13225
b93aacde
PE
13226 * process.c: Rename or move locals to avoid shadowing.
13227 (list_processes_1, Fmake_network_process):
13228 (read_process_output_error_handler, exec_sentinel_error_handler):
13229 Rename or move locals.
4dc343ee 13230 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13231 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13232 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13233 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13234 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13235
af8a867c 13236 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13237 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13238 Include tparam.h instead, since it declares them.
af8a867c
PE
13239 * cm.h (PC): Remove extern decl; tparam.h now does this.
13240 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13241 * terminfo.c: Include tparam.h, to check interfaces.
13242 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13243 (tparam): Adjust signature to match interface in tparam.h;
13244 this removes some undefined behavior. Check that outstring and len
13245 are zero, which they always are with Emacs.
13246 * tparam.h (PC, BC, UP): New extern decls.
13247
0248044d 13248 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13249 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13250
8ff096c1 13251 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13252 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13253 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13254 (ftfont_list): Remove unused local.
49eaafba
PE
13255 (get_adstyle_property, ftfont_pattern_entity):
13256 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13257 Rename locals to avoid shadowing.
8ff096c1 13258
e2be39f6
PE
13259 * xfont.c (xfont_list_family): Mark var as initialized.
13260
c9735e30
PE
13261 * xml.c (make_dom): Now static.
13262
8f5201ae
PE
13263 * composite.c (composition_compute_stop_pos): Rename local to
13264 avoid shadowing.
b246f932
PE
13265 (composition_reseat_it): Remove unused locals.
13266 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13267 (composition_update_it): Mark var as initialized.
11b61122
PE
13268 (find_automatic_composition): Mark vars as initialized,
13269 with a FIXME (Bug#8290).
8f5201ae 13270
760fbc2c
PE
13271 character.h: Rename locals to avoid shadowing.
13272 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13273 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13274 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13275 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13276 to avoid shadowing.
13277
ff08eb85
PE
13278 * textprop.c (property_change_between_p): Remove; unused.
13279
fc7bf025
PE
13280 * intervals.c (interval_start_pos): Now static.
13281
235d7abc
PE
13282 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13283
44f230aa
SM
13284 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13285 Rename locals to avoid shadowing.
3e7d6594 13286
50060332
PE
13287 * sound.c (wav_play, au_play, Fplay_sound_internal):
13288 Fix pointer signedness.
d01f234b 13289 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13290 (wav_play): Initialize a variable to 0, to prevent undefined
13291 behavior (Bug#8278).
50060332 13292
c4fc4e30
PE
13293 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13294
918436ed
PE
13295 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13296
c939f91b
PE
13297 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13298 clobbering (Bug#8298).
b9c7f648
PE
13299 * sysdep.c (sys_subshell): Likewise.
13300 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13301
6bd8c144
PE
13302 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13303 This should get cleaned up, so that child_setup has the
13304 same signature on all platforms.
13305
7710357c 13306 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13307 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13308
c59da222
CY
133092011-03-22 Chong Yidong <cyd@stupidchicken.com>
13310
13311 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13312 not to be necessary, and produces flickering.
13313
66b87493
GM
133142011-03-20 Glenn Morris <rgm@gnu.org>
13315
13316 * config.in: Remove file.
13317
45b6f6d5
JB
133182011-03-20 Juanma Barranquero <lekktu@gmail.com>
13319
13320 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13321 are now in src/globals.h.
13322 (syms_of_minibuf): Remove spurious & from previous change.
13323
cd394be1 133242011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13325
13326 * minibuf.c (completing-read-function): New variable.
13327 (completing-read-default): Rename from completing-read.
13328 (completing-read): Call completing-read-function.
13329
b14e3e21
CY
133302011-03-19 Juanma Barranquero <lekktu@gmail.com>
13331
13332 * xfaces.c (Fx_load_color_file):
13333 Read color file from absolute filename (bug#8250).
13334
f2b726e6
JB
133352011-03-19 Juanma Barranquero <lekktu@gmail.com>
13336
13337 * makefile.w32-in: Update dependencies.
13338
09f6ff02
EZ
133392011-03-17 Eli Zaretskii <eliz@gnu.org>
13340
13341 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13342
29a6015a
PE
133432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13344
a3a6c54e
PE
13345 Fix more problems found by GCC 4.5.2's static checks.
13346
b766f867
PE
13347 * process.c (make_serial_process_unwind, send_process_trap):
13348 (sigchld_handler): Now static.
13349
be02381c
PE
13350 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13351 That way, the code declares only the vars that it needs.
13352 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13353 * s/cygwin.h (PTY_ITERATION): Likewise.
13354 * s/darwin.h (PTY_ITERATION): Likewise.
13355 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13356
57048744
PE
13357 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13358 * process.c (allocate_pty): Don't declare stb unless it's needed.
13359
7914961c 13360 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13361 (CONSTANTLIM): Remove; unused.
13362 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13363 Define only if needed.
7914961c 13364
b3967b18
PE
13365 * unexelf.c (unexec): Name an expression,
13366 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13367 Use a different way to cause a compilation error if anyone uses
13368 n rather than nn, a way that does not involve shadowing.
73366a00 13369 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13370
29a6015a
PE
13371 * deps.mk (unexalpha.o): Remove; unused.
13372
43cfc33e 13373 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13374 * unexec.h: New file.
ce701a33
PE
13375 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13376 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13377 Depend on unexec.h.
13378 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13379 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13380 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13381 Change as necessary to match prototype in unexec.h.
ce701a33 13382
01f44d5a
PE
13383 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13384 shadowing.
4f63c6bb 13385 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13386
a6670b0b
PE
13387 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13388 Rename locals to avoid shadowing.
13389
cef2010d 13390 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13391 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13392
d4d7173a
PE
13393 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13394
f08b802a
PE
13395 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13396 warning when compiling print.c.
13397
3ddb0639
PE
13398 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13399 instead of using an uninitialized var.
5ad03b97 13400 (font_sort_entities): Mark var as initialized.
3ddb0639 13401
170a2692
PE
13402 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13403
e663c700
PE
13404 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13405 pointers to constants.
89bc529a 13406 (font_parse_fcname): Remove unused vars.
7b81e2d0 13407 (font_delete_unmatched): Now static.
ea838e10 13408 (font_get_spec): Remove; unused.
13a547c6
PE
13409 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13410 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13411 Rename or move locals to avoid shadowing.
e663c700 13412
2a80c887 13413 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13414 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13415
1384fa33 13416 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13417 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13418
8b2c52e9
PE
13419 * alloc.c (mark_backtrace): Move decl from here ...
13420 * lisp.h: ... to here, so that it can be checked.
13421
475545b5 13422 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13423 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13424 (lisp_indirect_variable): Name an expression,
13425 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13426 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13427
b1349114 13428 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13429 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13430 Use const pointer when appropriate.
b1349114 13431
a2928364
PE
13432 * lisp.h (get_system_name, get_operating_system_release):
13433 Move decls here, to check interfaces.
13434 * process.c (get_operating_system_release): Move decl to lisp.h.
13435 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13436 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13437 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13438 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13439 (Fformat_time_string, Fencode_time, Finsert_char):
13440 (Ftranslate_region_internal, Fformat):
13441 Rename or remove local vars to avoid shadowing.
9710023e 13442 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13443
a415e694
PE
13444 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13445 avoid shadowing.
13446
8ef4622d
PE
13447 * lisp.h (eassert): Check that the argument compiles, even if
13448 ENABLE_CHECKING is not defined.
13449
946f9a5b
PE
13450 * data.c (Findirect_variable): Name an expression, to avoid
13451 gcc -Wbad-function-cast warning.
112396d6 13452 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13453 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13454 (Fmake_variable_buffer_local, Fmake_local_variable):
13455 Mark variables as initialized.
52746918 13456 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13457
e5aab7e7 13458 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13459 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13460 Rename locals to avoid shadowing.
dff45157
PE
13461 (mark_stack): Move local variables into the #ifdef region where
13462 they're used.
7bc26fdb
PE
13463 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13464 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13465 needed otherwise.
13466 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13467 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13468 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13469
e5aab7e7
PE
13470 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13471 avoids undefined behavior in theory.
13472
4da60324
PE
13473 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13474
88043301
PE
13475 Use functions, not macros, for up- and down-casing (Bug#8254).
13476 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13477 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13478 to use the following functions instead of these macros.
13479 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13480 EMACS_INT, since callers assume the returned value fits in int.
13481 (upcase1): Likewise, for UPCASE_TABLE.
13482 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13483 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13484 the race-condition problem in the old DOWNCASE.
88043301 13485
19ed5445
PE
13486 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13487 Rename locals to avoid shadowing.
13488 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13489 (regex_compile, re_search_2, re_match_2_internal):
13490 Remove unused local vars.
952db0d7
PE
13491 (FREE_VAR): Rewrite so as not to use empty "else",
13492 which gcc can warn about.
da053e48 13493 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13494 (RETALLOC_IF): Define only if needed.
13495 (WORDCHAR_P): Likewise. This one is never needed, but is used
13496 only in a comment talking about a compiler bug, so put inside
13497 the #if 0 of that comment.
13498 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13499 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13500 Remove; unused.
19ed5445 13501
1f3561e4 13502 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13503 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13504 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13505
ded6f8f7
PE
13506 * search.c (simple_search): Remove unused var.
13507
dbd37a95
PE
13508 * dired.c (compile_pattern): Move decl from here ...
13509 * lisp.h: ... to here, so that it can be checked.
13510 (struct re_registers): New forward decl.
13511
7e47afad
PE
13512 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13513
85f24f61
PE
13514 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13515 All uses changed.
13516 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13517 Rename locals to avoid shadowing.
5671df8f 13518 (Fvertical_motion): Mark locals as initialized.
85f24f61 13519
181aa2be 13520 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13521 (casify_region): Mark local as initialized.
181aa2be 13522
930d429c
PE
13523 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13524
7082eac6
PE
13525 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13526 New macros, so that the caller can use some names other than
13527 gcpro1, gcpro2, etc.
13528 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13529 of the new macros.
13530 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13531 argument, for consistency with GCPRO2_VAR, etc: it is now the
13532 prefix of the variable, not the variable itself. All uses
13533 changed.
38b2c076
PE
13534 * dired.c (directory_files_internal, file_name_completion):
13535 Rename locals to avoid shadowing.
13536
15206ed9
PE
13537 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13538 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13539 dired.c's scmp function, had undefined behavior.
13540 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13541 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13542 * buffer.h: ... to here, because these macros use current_buffer,
13543 and the new implementation with inline functions needs to have
13544 current_buffer in scope now, rather than later when the macros
13545 are used.
13546 (downcase, upcase1): New static inline functions.
13547 (DOWNCASE, UPCASE1): Reimplement using these functions.
13548 This avoids undefined behavior in expressions like
13549 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13550 from race conditions in accessing the global variables
13551 case_temp1 and case_temp2.
13552 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13553 * lisp.h (case_temp1, case_temp2): Remove their decls.
13554 * character.h (ASCII_CHAR_P): Move from here ...
13555 * lisp.h: ... to here, so that the inline functions mentioned
13556 above can use them.
13557
4a6bea26
PE
13558 * dired.c (directory_files_internal_unwind): Now static.
13559
f14b7e14
PE
13560 * fileio.c (file_name_as_directory, directory_file_name):
13561 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13562 Now static.
2893f146
PE
13563 (file_name_as_directory): Use const pointers when appropriate.
13564 (Fexpand_file_name): Likewise. In particular, newdir might
13565 point at constant storage, so make it a const pointer.
fd4ead52 13566 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13567 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13568 signedness issues.
f839df0c
PE
13569 (Fset_file_times, Finsert_file_contents, auto_save_error):
13570 Rename locals to avoid shadowing.
f14b7e14 13571
5716756e 13572 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13573 (Ftry_completion, Fall_completions): Rename or remove locals
13574 to avoid shadowing.
5716756e 13575
b4c3046a
PE
13576 * marker.c (bytepos_to_charpos): Remove; unused.
13577
b45db522
PE
13578 * lisp.h (verify_bytepos, count_markers): New decls,
13579 so that gcc does not warn that these functions aren't declared.
13580
85876d07
PE
13581 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13582 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13583 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13584 (copy_text): Remove unused local var.
85876d07 13585
03d78a21 13586 * filelock.c (within_one_second): Now static.
b3dd38ab 13587 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13588
5df8f01b
PE
13589 * buffer.c (fix_overlays_before): Mark locals as initialized.
13590 (fix_start_end_in_overlays): Likewise. This function should be
13591 simplified by using pointers-to-pointers, but that's a different
13592 matter.
b1d876f1 13593 (switch_to_buffer_1): Now static.
8f54f30a
PE
13594 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13595 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13596
a70072c9 13597 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13598 Fix pointer signedness issue.
edced198
PE
13599 (sys_subshell): Mark local as volatile if checking for lint,
13600 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13601 (MAXPATHLEN): Define only if needed.
a70072c9 13602
a0977c44
PE
13603 * process.c (serial_open, serial_configure): Move decls from here ...
13604 * systty.h: ... to here, so that they can be checked.
13605
a884fdcc
PE
13606 * fns.c (get_random, seed_random): Move extern decls from here ...
13607 * lisp.h: ... to here, so that they can be checked.
13608
604efe86 13609 * sysdep.c (reset_io): Now static.
b8950c94 13610 (wait_for_termination_signal): Remove; unused.
604efe86 13611
38fc62d9
PE
13612 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13613 (copy_keymap_item, append_key, push_text_char_description):
13614 Now static.
1004a21a 13615 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13616 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13617 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13618 (describe_map_tree):
13619 Rename locals to avoid shadowing.
38fc62d9 13620
2f2650da
PE
13621 * keyboard.c: Declare functions static if they are not used elsewhere.
13622 (echo_char, echo_dash, cmd_error, top_level_2):
13623 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13624 (read_char, kbd_buffer_get_event, make_lispy_position):
13625 (make_lispy_event, make_lispy_movement, apply_modifiers):
13626 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13627 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13628 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13629 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13630 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13631
a053e86c 13632 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13633 (mark_kboards): Move decl here ...
13634 * alloc.c (mark_kboards): ... from here.
a053e86c 13635
4752793e
PE
13636 * lisp.h (force_auto_save_soon): New decl.
13637
74f10ca7 13638 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13639 (DEFINE_DUMMY_FUNCTION): New macro.
13640 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13641 Use it.
c03cd23f
PE
13642 (main): Add casts to avoid warnings
13643 if GCC considers string literals to be constants.
74f10ca7 13644
022e70d4
PE
13645 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13646
59d6fe83
PE
13647 * dbusbind.c: Pointer signedness fixes.
13648 (xd_signature, xd_append_arg, xd_initialize):
13649 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13650 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13651 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13652 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13653
78320123
PE
13654 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13655 if GCC considers string literals to be constants.
49cebcca 13656 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13657
35ac2a97
SM
136582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13659
fb103ca9
SM
13660 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13661 (print_preprocess, print_object): New macro to fix last change.
13662
35ac2a97
SM
13663 * print.c (print_preprocess): Don't forget font objects.
13664
62973b41
JB
136652011-03-16 Juanma Barranquero <lekktu@gmail.com>
13666
13667 * emacs.c (USAGE3): Doc fixes.
13668
0e48bb22
AS
136692011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13670
13671 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13672 structure.
13673
7684e57b
JB
136742011-03-14 Juanma Barranquero <lekktu@gmail.com>
13675
13676 * lisp.h (VWindow_system, Qfile_name_history):
13677 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13678 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13679 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13680
13681 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13682 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13683
13684 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13685 * w32console.c (detect_input_pending, read_input_pending)
13686 (encode_terminal_code):
13687 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13688 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13689 (w32_system_caret_y, Qfile_name_history):
13690 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13691 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13692 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13693 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13694 * w32proc.c (Qlocal, report_file_error):
13695 * w32term.c (Vwindow_system, updating_frame):
13696 * w32uniscribe.c (initialized, uniscribe_font_driver):
13697 Remove unneeded extern declarations.
13698
2aa46d6c
CY
136992011-03-14 Chong Yidong <cyd@stupidchicken.com>
13700
c96bbc66 13701 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13702
cffc6f3b
CY
137032011-03-13 Chong Yidong <cyd@stupidchicken.com>
13704
13705 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13706 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13707 These macros can no longer be used for assignment.
13708
44f230aa
SM
13709 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13710 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13711 (record_buffer_markers, fetch_buffer_markers): New functions for
13712 recording and fetching special buffer markers.
13713 (set_buffer_internal_1, set_buffer_temp): Use them.
13714
13715 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13716
13717 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13718
13719 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13720 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13721
13722 * xdisp.c (hscroll_window_tree):
13723 (reconsider_clip_changes): Use PT instead of BUF_PT.
13724
d251f04b
EZ
137252011-03-13 Eli Zaretskii <eliz@gnu.org>
13726
13727 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13728 $(EMACS_ROOT)/lib/intprops.h.
13729
f0c77cd1
PE
137302011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13731
3eca4629
PE
13732 Fix more problems found by GCC 4.5.2's static checks.
13733
7c86ee98
PE
13734 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13735 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13736 (xg_free_frame_widgets): Make it clear that a local variable is
13737 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13738 (gdk_window_get_screen): Make it clear that this macro is needed
13739 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13740 (int_gtk_range_get_value): New function, which avoids a diagnostic
13741 from gcc -Wbad-function-cast.
13742 (xg_set_toolkit_scroll_bar_thumb): Use it.
13743 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13744 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13745 (get_utf8_string, xg_get_file_with_chooser):
13746 Rename locals to avoid shadowing.
13747 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13748
41729b81
PE
13749 * xgselect.c (xg_select): Remove unused var.
13750
f0c77cd1
PE
13751 * image.c (four_corners_best): Mark locals as initialized.
13752 (gif_load): Initialize transparent_p to zero (Bug#8238).
13753 Mark another local as initialized.
ec6cf4c6 13754 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13755
ce0ad53d 13756 * image.c (clear_image_cache): Now static.
d5d5a617 13757 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13758 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13759 (x_edge_detection): Remove unnecessary cast that
13760 gcc -Wbad-function-cast diagnoses.
2037898d 13761 (gif_load): Fix pointer signedness.
6ae141d6
PE
13762 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13763 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13764
33383987 137652011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13766
d32df629
PE
13767 Improve quality of tests for time stamp overflow.
13768 For example, without this patch (encode-time 0 0 0 1 1
13769 1152921504606846976) returns the obviously-bogus value (-948597
13770 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13771 reports time overflow. See
13772 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13773 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13774 * editfns.c: Include limits.h and intprops.h.
13775 (TIME_T_MIN, TIME_T_MAX): New macros.
13776 (time_overflow): Move earlier, to before first use.
13777 (hi_time, lo_time): New functions, for an accurate test for
13778 out-of-range times.
13779 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13780 (Fget_internal_run_time): Don't assume time_t fits in int.
13781 (make_time): Use list2 instead of Fcons twice.
13782 (Fdecode_time): More accurate test for out-of-range times.
13783 (check_tm_member): New function.
13784 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13785 (lisp_time_argument): Don't rely on undefined left-shift and
13786 right-shift behavior when checking for time stamp overflow.
8be6f318 13787
fe31d94c
PE
13788 * editfns.c (time_overflow): New function, refactoring common code.
13789 (Fformat_time_string, Fdecode_time, Fencode_time):
13790 (Fcurrent_time_string): Use it.
13791
8be6f318
PE
13792 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13793 * dired.c (make_time): Move to ...
13794 * editfns.c (make_time): ... here.
13795 * systime.h: Note the move.
13796
09d9db2c 137972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13798
126bc0dc
YM
13799 * fringe.c (update_window_fringes): Remove unused variables.
13800
c47cbdfd
YM
13801 * unexmacosx.c (copy_data_segment): Also copy __got section.
13802 (Bug#8223)
13803
7ac80be9
EZ
138042011-03-12 Eli Zaretskii <eliz@gnu.org>
13805
c96bbc66 13806 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13807 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13808 Constify `char *' arguments and their references according to
13809 prototypes in tparam.h.
13810
ecb0f94d 13811 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13812
7ac80be9
EZ
13813 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13814 Adapt all references accordingly.
13815
13816 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13817
ef1fd07e
TT
138182011-03-11 Tom Tromey <tromey@redhat.com>
13819
13820 * buffer.c (syms_of_buffer): Remove obsolete comment.
13821
7ef4b50c
EZ
138222011-03-11 Eli Zaretskii <eliz@gnu.org>
13823
13824 * termhooks.h (encode_terminal_code): Declare prototype.
13825
13826 * msdos.c (encode_terminal_code): Don't declare prototype.
13827
13828 * term.c (encode_terminal_code): Now external again, used by
13829 w32console.c and msdos.c.
13830
44f230aa
SM
13831 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13832 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13833
4b1ec863 138342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13835
1714f52b 13836 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13837
4b1ec863
PE
13838 * fringe.c (update_window_fringes): Mark locals as initialized
13839 (Bug#8227).
13840 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13841
524c7aa6
PE
13842 * alloc.c (mark_fringe_data): Move decl from here ...
13843 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13844 to check its interface.
13845 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13846
a5c0af81 13847 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13848 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13849 (fontset_font): Mark local as initialized.
a9a06e0b 13850 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13851
b4716021
PE
13852 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13853
811e9bac 13854 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13855 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13856 (x_own_selection, Fx_disown_selection_internal): Rename locals
13857 to avoid shadowing.
13858 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13859
7e3ab302
PE
13860 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13861 so that the caller can use some name other than gcpro1.
13862 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13863 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13864 (Fx_backspace_delete_keys_p):
13865 Use them to avoid shadowing, and rename vars to avoid shadowing.
13866 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13867 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13868 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13869 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13870 Remove unused locals.
7e3ab302
PE
13871 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13872 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13873 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13874 macros.
f78faa98 13875
e2b13473
PE
13876 * xterm.h (x_mouse_leave): New decl.
13877
77f23912
PE
13878 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13879 Remove unused functions.
cdf4ba58
PE
13880 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13881 (x_calc_absolute_position): Now static.
7411c686 13882 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13883 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13884 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13885 unless they are used.
38d0b34a
PE
13886 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13887 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13888 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13889 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13890 (x_error_catcher, x_connection_closed, x_error_handler):
13891 (x_error_quitter, xembed_send_message, x_iconify_frame):
13892 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13893 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13894 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13895
44f230aa
SM
13896 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13897 Rename or move locals to avoid shadowing.
6b463e58 13898 (tty_defined_color, merge_face_heights): Now static.
5967d051 13899 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13900 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13901 does not deduce is never used uninitialized.
73719eba
PE
13902 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13903 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13904
426994c3 13905 * terminal.c (store_terminal_param): Now static.
5489860b 13906
032f1620 13907 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13908 (set_frame_menubar): Remove unused local.
d4323972 13909 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13910 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13911 since they might point to immutable storage.
281585b0
PE
13912 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13913 since it's unused otherwise.
032f1620 13914
367c19e5 13915 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13916 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13917 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13918 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13919 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13920 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13921 does not deduce are never used uninitialized.
70739cbe 13922
07b48fa9
PE
13923 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13924
8868a238 13925 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13926 * window.c (window_loop, size_window):
13927 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13928
7e5cf297 13929 * window.c (display_buffer): Now static.
d6550a9f
PE
13930 (size_window): Mark variables that gcc -Wuninitialized
13931 does not deduce are never used uninitialized.
a586633d
PE
13932 * window.h (check_all_windows): New decl, to forestall
13933 gcc -Wmissing-prototypes diagnostic.
5b555da1 13934 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13935
f6095868
PE
13936 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13937 shadowing.
13938 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13939 Include <limits.h>.
13940 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13941 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13942 (load_charset_map): Mark variables that gcc -Wuninitialized
13943 does not deduce are never used uninitialized.
53df7c11 13944 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13945
f38b440c
PE
13946 * coding.c (coding_set_source, coding_set_destination):
13947 Use "else { /* comment */ }" rather than "else /* comment */;"
13948 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13949 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13950 a block, when the outer 'i' will do.
13951 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13952 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13953 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13954 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13955 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13956 Rename locals to avoid shadowing.
13957 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13958 * coding.c (emacs_mule_char, encode_invocation_designation):
13959 Now static, since they're not used elsewhere.
413bb2db 13960 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13961 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13962 (decode_coding_emacs_mule): Mark variables that gcc
13963 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13964 (detect_coding_iso_2022): Initialize a local variable that might
13965 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13966 this initialization is needed. (Bug#8211)
5f58e762
PE
13967 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13968 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13969 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13970 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13971 Remove unused macros.
f38b440c 13972
232b38b9 13973 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13974 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13975 * character.c (string_count_byte8): Likewise.
232b38b9 13976
fb90da1b
PE
13977 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13978 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13979
fb93dbc2
PE
13980 * chartab.c (copy_sub_char_table): Now static, since it's not used
13981 elsewhere.
5c156ace
PE
13982 (sub_char_table_ref_and_range, char_table_ref_and_range):
13983 Rename locals to avoid shadowing.
bbcd0949 13984 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13985
7d3b3862 13986 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13987 (BIDI_BOB): Remove unused macro.
7d3b3862 13988
6be7d3da
PE
13989 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13990 deduce are never used uninitialized.
c2ed9c8b 13991 * term.c (encode_terminal_code): Likewise.
6be7d3da 13992
75f8807f 13993 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13994
50938595
PE
13995 * tparam.h: New file.
13996 * term.c, tparam.h: Include it.
13997 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13998 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13999 Move these decls to tparam.h, and make them agree with what
14000 is actually in tparam.c. The previous trick of using incompatible
14001 decls in different modules does not conform to the C standard.
14002 All callers of tparam changed to use tparam's actual API.
14003 * tparam.c (tparam1, tparam, tgoto):
14004 Use const pointers where appropriate.
14005
fbceeba2
PE
14006 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14007 * cm.h (struct cm): Likewise.
14008 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14009 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14010 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14011 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14012 (turn_on_face, init_tty): Likewise.
14013 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14014
7f3f1250
PE
14015 * term.c (term_mouse_position): Rename local to avoid shadowing.
14016
e6ca6543
PE
14017 * alloc.c (mark_ttys): Move decl from here ...
14018 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14019
c40f8d15
AS
140202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14021
14022 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14023
cfe0661d
JB
140242011-03-09 Juanma Barranquero <lekktu@gmail.com>
14025
14026 * search.c (compile_pattern_1): Remove argument regp, unused since
14027 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14028 (compile_pattern): Don't pass it.
14029
0afb4571
J
140302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14031
14032 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14033 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14034 for ! HAVE_GTK3.
14035 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14036
14037 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14038
14039 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14040 gdk_window_get_screen, gdk_window_get_geometry,
14041 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14042 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14043 (xg_get_pixbuf_from_pixmap): New function.
14044 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14045 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14046 Call xg_get_pixbuf_from_pixmap instead of
14047 gdk_pixbuf_get_from_drawable.
14048 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14049 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14050 (xg_check_special_colors): Use GtkStyleContext and its functions
14051 for HAVE_GTK3.
14052 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14053 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14054 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14055 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14056 Call gtk_widget_get_preferred_size.
0afb4571
J
14057 (xg_frame_resized): gdk_window_get_geometry only takes 5
14058 parameters.
44f230aa
SM
14059 (xg_win_to_widget, xg_event_is_for_menubar):
14060 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14061 (xg_set_widget_bg): New function.
14062 (delete_cb): New function.
895009e1 14063 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14064 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14065 (xg_set_background_color): Call xg_set_widget_bg.
14066 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14067 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14068 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14069 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14070 if ! HAVE_GTK3.
14071 (update_frame_tool_bar): Call gtk_widget_hide.
14072 (xg_initialize): Use GDK_KEY_g.
14073
14074 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14075 if ! HAVE_GTK3
14076 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14077
14078 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14079 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14080 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14081
1c2cc4ef
JB
140822011-03-08 Juanma Barranquero <lekktu@gmail.com>
14083
14084 * w32xfns.c (select_palette): Check success of RealizePalette against
14085 GDI_ERROR, not zero.
14086
33383987 14087See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14088
14089;; Local Variables:
14090;; coding: utf-8
aac0c6e3
MR
14091;; End:
14092
2f097256 14093 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14094
14095 This file is part of GNU Emacs.
14096
14097 GNU Emacs is free software: you can redistribute it and/or modify
14098 it under the terms of the GNU General Public License as published by
14099 the Free Software Foundation, either version 3 of the License, or
14100 (at your option) any later version.
14101
14102 GNU Emacs is distributed in the hope that it will be useful,
14103 but WITHOUT ANY WARRANTY; without even the implied warranty of
14104 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14105 GNU General Public License for more details.
14106
14107 You should have received a copy of the GNU General Public License
14108 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.