Avoid calls to strlen in path processing functions.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c293e30c
DA
12012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Avoid calls to strlen in path processing functions.
4 * fileio.c (file_name_as_directory): Add comment. Change to add
5 srclen argument and return the length of result. Adjust users
6 accordingly.
7 (directory_file_name): Fix comment. Change to add srclen argument,
8 swap 1nd and 2st arguments to obey the common convention. Adjust
9 users accordingly.
10 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
11
9e059e3f
GM
122012-07-10 Glenn Morris <rgm@gnu.org>
13
af6e839f
GM
14 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
15 We include usg5-4-common.h, which defines them both.
16
40289a12
GM
17 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
18 O_RDONLY already includes it).
19
9e059e3f
GM
20 Stop ns builds setting the EMACSLOADPATH environment variable.
21 * nsterm.m (ns_load_path): Rename from ns_init_paths.
22 Now it does not set EMACSLOADPATH, just returns the load-path string.
23 * nsterm.h: Update accordingly.
24 * lread.c [HAVE_NS]: Include nsterm.h.
25 (init_lread) [HAVE_NS]: Use ns_load_path.
26 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
27
7c4e8ec0
GM
282012-07-09 Glenn Morris <rgm@gnu.org>
29
d4f600ff
GM
30 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
31 since the included bsd-common.h does so.
32
cbb31951
GM
33 Stop ns builds setting the EMACSPATH environment variable.
34 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
35 (ns_init_paths): Do not set EMACSPATH.
36 * nsterm.h (ns_exec_path): Add it.
37 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
38 Use ns_exec_path.
39
7c4e8ec0
GM
40 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
41
26bccfae
PE
422012-07-09 Paul Eggert <eggert@cs.ucla.edu>
43
a0bee46f
PE
44 * process.c (wait_reading_process_output): 'waitchannels' was unset
45 when read_kbd || !NILP (wait_for_cell); fix this.
46
5994c183
PE
47 Add GCC-style 'const' attribute to functions that can use it.
48 * character.h (char_resolve_modifier_mask):
49 * keyboard.h (make_ctrl_char):
50 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
51 (init_character_once, next_almost_prime, init_fns, init_image)
52 (flush_pending_output, init_sound):
53 * mem-limits.h (start_of_data):
54 * menu.h (finish_menu_items):
55 Add ATTRIBUTE_CONST.
56 * emacs.c (DEFINE_DUMMY_FUNCTION):
57 Declare the dummy function with ATTRIBUTE_CONST.
58 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
59 Add decls with ATTRIBUTE_CONST.
60
26bccfae
PE
61 Minor improvements to make_formatted_string.
62 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
63 where int is good enough, as vsprintf returns an int.
64 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
65
a8290ec3
DA
662012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
67
68 Use make_formatted_string to avoid double length calculation.
69 * lisp.h (make_formatted_string): New prototype.
70 * alloc.c (make_formatted_string): New function.
71 * buffer.c (Fgenerate_new_buffer_name): Use it.
72 * dbus.c (syms_of_dbusbind): Likewise.
73 * editfns.c (Fcurrent_time_zone): Likewise.
74 * filelock.c (get_boot_time): Likewise.
75 * frame.c (make_terminal_frame, set_term_frame_name)
76 (x_report_frame_params): Likewise.
77 * image.c (gs_load): Likewise.
78 * minibuf.c (get_minibuffer): Likewise.
79 * msdos.c (dos_set_window_size): Likewise.
80 * process.c (make_process): Likewise.
81 * xdisp.c (ensure_echo_area_buffers): Likewise.
82 * xsettings.c (apply_xft_settings): Likewise.
83
d01ba2f1
GM
842012-07-09 Glenn Morris <rgm@gnu.org>
85
86 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
87 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
88 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
89 * nsterm.h (ns_etc_directory): Add it.
90 * callproc.c [HAVE_NS]: Include nsterm.h.
91 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
92
f1f924b6
DA
932012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
94
95 Move marker debugging code under MARKER_DEBUG.
96 * marker.c (MARKER_DEBUG): Move marker debugging code under
97 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
98 for bootstrap with --enable-checking (~3x slowdown reported
99 by Juanma Barranquero <lekktu@gmail.com>).
100 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
101
ab531b66
PE
1022012-07-08 Paul Eggert <eggert@cs.ucla.edu>
103
104 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
105 See <http://bugs.gnu.org/11825#29>.
106
c4b3bc8a
EZ
1072012-07-08 Eli Zaretskii <eliz@gnu.org>
108
109 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
110 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
111 (display_line): Add commentary about displaying truncation glyphs
112 on GUI frames.
113 (produce_special_glyphs): Move here from term.c.
114
115 * term.c (produce_special_glyphs): Move to xdisp.c.
116
117 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
118 section.
c4b3bc8a 119
b676b881
AS
1202012-07-07 Andreas Schwab <schwab@linux-m68k.org>
121
f17c5273
AS
122 * xdisp.c (display_line): Avoid warning about implicit declaration
123 of FRAME_FONT.
124
298819b9
AS
125 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
126
b676b881
AS
127 * lisp.h: Remove empty conditional.
128
6045c4fd
PE
1292012-07-07 Paul Eggert <eggert@cs.ucla.edu>
130
b3350bf9
PE
131 * lread.c (load_path_check): Now static.
132
6045c4fd
PE
133 Fix some minor --with-ns problems found by static checking.
134 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
135 (x_set_font) [!HAVE_X_WINDOWS]:
136 * image.c (xpm_load_image) [HAVE_NS]:
137 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
138 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
139 Remove unused local.
140 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
141 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
142 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
143 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
144 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
145 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
146 Fix pointer signedness problem.
147 * xfaces.c (FRAME_X_FONT_TABLE):
148 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
149
929e7845
GM
1502012-07-07 Glenn Morris <rgm@gnu.org>
151
152 * lread.c (load_path_check): New function, split from init_lread.
153 (init_lread): Reorganize. Motivation:
154 If EMACSLOADPATH is set, check/warn about that rather than the
155 defaults, which we are not going to use. Hence we can remove
156 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
157 Don't warn if site-lisp directories are missing.
158 If not installed, start from a blank load-path, since
159 PATH_LOADSEARCH refers to the eventual installation directories.
160
58dd0aa4
EZ
1612012-07-07 Eli Zaretskii <eliz@gnu.org>
162
163 Support truncation and continuation glyphs on GUI frames, when
164 fringes are disabled. (Bug#11832)
165 * xdisp.c (init_iterator): Get dimensions of truncation and
166 continuation glyphs even if on GUI frames. Adjust
167 it->last_visible_x on GUI frames when the left or right fringes,
168 or both, are absent.
169 (start_display, move_it_in_display_line_to): Handle the case of a
170 GUI frame without a fringe to display continuation or truncation
171 glyphs.
172 (insert_left_trunc_glyphs): Support GUI frames: make sure
173 truncation glyphs overwrite enough glyphs from the current line to
174 have sufficient space in pixels.
175 (display_line): Support truncation and continuation glyphs on GUI
176 frames. If some spare pixels are left on the line after inserting
177 the truncation glyphs, fill that space with a stretch glyph of a
178 suitably computed width.
179
180 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
181 produce_glyphs, to support GUI sessions.
182
31571fd7
PE
1832012-07-07 Paul Eggert <eggert@cs.ucla.edu>
184
5a16b9bc
PE
185 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
186
f3047c75
PE
187 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
188
31571fd7
PE
189 Do not require float-time's arg to fit in time_t (Bug#11825).
190 This works better on hosts where time_t is unsigned, and where
191 float-time is applied to the (negative) difference between two times.
192 * editfns.c (decode_time_components): Last arg is now double *,
193 not int *, and means to store all the result as a double, without
194 worrying about whether the seconds part fits in time_t.
195 All callers changed.
196 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
197 All callers changed.
198 (Ffloat_time): Do not fail merely because the specified time falls
199 outside of time_t range.
200
4516fbef
GM
2012012-07-07 Glenn Morris <rgm@gnu.org>
202
203 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
204 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
205 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
206
07adc2c6
JB
2072012-07-07 Juanma Barranquero <lekktu@gmail.com>
208
209 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
210 Update dependencies.
211
212 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
213
fd573f31
PE
2142012-07-06 Paul Eggert <eggert@cs.ucla.edu>
215
fee5959d
PE
216 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
217 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
218 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
219 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
220 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
221 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
222
fd573f31
PE
223 * xfont.c (compare_font_names): Redo to omit the need for casts.
224
ddadbc0e
AS
2252012-07-06 Andreas Schwab <schwab@linux-m68k.org>
226
fca8d6b6
AS
227 * xfns.c (Fx_change_window_property): Doc fix.
228 * w32fns.c (Fx_change_window_property): Doc fix.
229
ddadbc0e
AS
230 * w32fns.c (Fx_window_property): Accept the same arguments as the
231 X Windows version. Doc fix.
232 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
233
f247498e
JB
2342012-07-06 Juanma Barranquero <lekktu@gmail.com>
235 Eli Zaretskii <eliz@gnu.org>
236
237 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
238 Windows-specific code from nt/config.nt moved here.
239 Obsolete settings removed.
240
216ee680
PE
2412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
242
243 * process.c: Avoid unnecessary calls to gettime.
244 (wait_reading_process_output): Don't get the time of day
245 when gobbling data immediately and not waiting, as there's no need
246 for it in that case. This removes a FIXME.
247
bdd091e4
JD
2482012-07-06 Jan Djärv <jan.h.d@swipnet.se>
249
250 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
251 is defined (Bug#11768).
252
9d44f8ce
DA
2532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
254
255 Fix marker debugging code.
256 * marker.c (byte_char_debug_check): Do not perform the check
257 if buffer is not multibyte.
090bd7cb
JB
258 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
259 Call byte_char_debug_check with correct arguments.
9d44f8ce 260
90fc4786
DA
2612012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
262
263 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
264 * marker.c (byte_char_debug_check, count_markers):
265 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
266 (byte_debug_flag): Remove.
267 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
268 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
269
7b7ae965
DA
2702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
271
4e57b342
DA
272 Avoid code repetition in marker-related functions.
273 * marker.c (attach_marker): New function.
274 (Fset_marker, set_marker_restricted, set_marker_both)
275 (set_marker_restricted_both): Use it.
276 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
277 Consistently rename charno to charpos.
278 (marker_position): Add eassert.
279 (marker_byte_position): Convert to eassert.
280
2812012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
282
283 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 284 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 285 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 286
657924ff
DA
2872012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Introduce fast path for the widely used marker operation.
290 * alloc.c (build_marker): New function.
291 * lisp.h (build_marker): New prototype.
292 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
293 * composite.c (autocmp_chars): Likewise.
294 * editfns.c (buildmark): Remove.
295 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
296 (save_restriction_save): Use build_marker.
297 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
298 * window.c (save_window_save): Likewise.
299
041a49a6
DA
3002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
301
302 Do not use Fdelete_overlay in delete_all_overlays
303 to avoid redundant calls to unchain_overlay.
304 * buffer.c (drop_overlay): New function.
305 (delete_all_overlays, Fdelete_overlay): Use it.
306 * minibuf.c (get_minibuffer): Fix comment.
307
7dca65a4
PE
3082012-07-06 Paul Eggert <eggert@cs.ucla.edu>
309
310 Port to OpenBSD 5.1 amd64.
311 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
312 This is needed for OpenBSD, and should be harmless on all BSD systems.
313 Also, include <sys/sysctl.h>, as it should be available on all
314 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
315 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
316 use p_pid member, not kp_proc.pid.
317
8eb876e2
GM
3182012-07-06 Glenn Morris <rgm@gnu.org>
319
320 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
321
38182d90
PE
3222012-07-05 Paul Eggert <eggert@cs.ucla.edu>
323
324 More xmalloc and related cleanup.
325 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
326 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
327 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
328 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
329 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
330 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
331 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
332 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
333 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
334 * xterm.c:
335 Omit needless casts involving void * pointers and allocation.
336 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
337 as the former is more robust if P's type is changed.
338 Prefer xzalloc to xmalloc + memset 0.
339 Simplify malloc-or-realloc to realloc.
340 Don't worry about xmalloc returning a null pointer.
341 Prefer xstrdup to xmalloc + strcpy.
342 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
343 growing it.
344 * keyboard.c (apply_modifiers_uncached): Prefer local array to
345 alloca of a constant.
346
6dd5a677
EZ
3472012-07-05 Eli Zaretskii <eliz@gnu.org>
348
349 * xdisp.c (display_line): Fix horizontal pixel coordinates when
350 hscroll is larger than the line width. Fixes long and futile
351 looping inside extend_face_to_end_of_line (on a TTY) producing
352 glyphs that are not needed and thrown away.
353
6b312f0f
DA
3542012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
355
356 * marker.c (set_marker_restricted_both): Simplify by using
357 clip_to_bounds.
358
f520ef9b
PE
3592012-07-05 Paul Eggert <eggert@cs.ucla.edu>
360
361 * editfns.c (region_limit): Simplify by using clip_to_bounds.
362
383b7c95
JD
3632012-07-05 Jan Djärv <jan.h.d@swipnet.se>
364
365 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
366 not defined (Bug#11768).
367 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
368 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
369 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
370 followed by gtk_box_set_homogeneous (Bug#11768).
371 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
372 (update_theme_scrollbar_width, xg_create_scroll_bar):
373 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
374 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
375 (is_box_type): New function (Bug#11768).
376 (xg_tool_item_stale_p): Call is_box_type.
5293d758 377 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
378 with default display (Bug#11768).
379
d6e7bf45
EZ
3802012-07-05 Eli Zaretskii <eliz@gnu.org>
381
382 * xdisp.c (window_hscroll_limited): New function.
383 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
384 coordinates when window's hscroll is set to insanely large
385 values. (Bug#11857)
386
431391ec
JB
3872012-07-05 Juanma Barranquero <lekktu@gmail.com>
388
389 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
390 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
391
23f86fce
DA
3922012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
393
394 Cleanup xmalloc.
395 * lisp.h (xzalloc): New prototype. Omit needless casts.
396 * alloc.c (xzalloc): New function. Omit needless casts.
397 * charset.c: Omit needless casts. Convert all calls to
398 xmalloc with following memset to xzalloc.
399 * dispnew.c: Likewise.
400 * fringe.c: Likewise.
401 * image.c: Likewise.
402 * sound.c: Likewise.
403 * term.c: Likewise.
404 * w32fns.c: Likewise.
405 * w32font.c: Likewise.
406 * w32term.c: Likewise.
407 * xfaces.c: Likewise.
408 * xfns.c: Likewise.
409 * xterm.c: Likewise.
410 * atimer.c: Omit needless casts.
411 * buffer.c: Likewise.
412 * callproc.c: Likewise.
413 * ccl.c: Likewise.
414 * coding.c: Likewise.
415 * composite.c: Likewise.
416 * doc.c: Likewise.
417 * doprnt.c: Likewise.
418 * editfns.c: Likewise.
419 * emacs.c: Likewise.
420 * eval.c: Likewise.
421 * filelock.c: Likewise.
422 * fns.c: Likewise.
423 * gtkutil.c: Likewise.
424 * keyboard.c: Likewise.
425 * lisp.h: Likewise.
426 * lread.c: Likewise.
427 * minibuf.c: Likewise.
428 * msdos.c: Likewise.
429 * print.c: Likewise.
430 * process.c: Likewise.
431 * region-cache.c: Likewise.
432 * search.c: Likewise.
433 * sysdep.c: Likewise.
434 * termcap.c: Likewise.
435 * terminal.c: Likewise.
436 * tparam.c: Likewise.
437 * w16select.c: Likewise.
438 * w32.c: Likewise.
439 * w32reg.c: Likewise.
440 * w32select.c: Likewise.
441 * w32uniscribe.c: Likewise.
442 * widget.c: Likewise.
443 * xdisp.c: Likewise.
444 * xmenu.c: Likewise.
445 * xrdb.c: Likewise.
446 * xselect.c: Likewise.
447
0497dc44
PE
4482012-07-05 Paul Eggert <eggert@cs.ucla.edu>
449
450 * fileio.c (time_error_value): Check the right error number.
451 Problem reported by Troels Nielsen in
452 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
453
356e7178
PE
4542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
455
4e71fd89
PE
456 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
457 This should be fixed in a better way; see Eli Zaretskii in
458 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
459 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
460
f0941253
PE
461 * fileio.c (time_error_value): Rename from special_mtime.
462 The old name's problems were noted by Eli Zaretskii in
463 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
464
065c9eb4
PE
465 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
466 This variable's comment says Emacs needs at least one GDB-visible
467 symbol of type enum pvec_type, to work around GDB problems.
468 The symbol's value doesn't matter.
469
356e7178
PE
470 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
471 that causes compilation to fail on pre-C99 compilers.
472
95f61aa2
JB
4732012-07-04 Juanma Barranquero <lekktu@gmail.com>
474
475 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
476 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
477
3884d954
DA
4782012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
479
d209e2fb 480 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
481 headers for buffer_defaults and buffer_local_symbols.
482 Reported by Juanma Barranquero <lekktu@gmail.com>.
483
ee28be33
SM
4842012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
485
486 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
487 * lisp.h (enum pvec_type): Use fewer bits.
488 (PSEUDOVECTOR_SIZE_BITS): New constant.
489 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
490 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
491 change in pvec_type.
492 (PSEUDOVECTOR_TYPEP): New macro.
493 (TYPED_PSEUDOVECTORP): Use it.
494 * fns.c (internal_equal): Adapt code to extract pvectype.
495 * emacs.c (gdb_pvec_type): Update type.
496 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
497 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
498 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
499 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
500 (sweep_vectors): Use it. Use local var `total_bytes' instead of
501 abusing vector->header.next.nbytes.
502 (live_vector_p): Use PVEC_TYPE.
503 (mark_object): Adapt code to extract pvectype. Use switch.
504
c7f2cd7f
PE
5052012-07-04 Paul Eggert <eggert@cs.ucla.edu>
506
507 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
508 Tighten new eassert a bit.
509
8ce70ed2
DA
5102012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
511
512 Fix compilation with --enable-gcc-warnings and -O1
513 optimization level.
514 * doprnt.c (doprnt): Change type of tem to int, initialize
515 to avoid compiler warning. Add eassert.
516 * search.c (simple_search): Initialize match_byte to avoid
517 compiler warning. Add eassert.
518
dea7f1e5
PE
5192012-07-04 Paul Eggert <eggert@cs.ucla.edu>
520
24a212eb
PE
521 Avoid weird behavior with large horizontal scrolls.
522 Without this change, for example, large hscroll values would
523 mess up Emacs's display on Fedora 15 x86, presumably due to
524 overflows in int calculations in the display code.
525 Also, if buffers had long lines, Emacs would freeze.
526 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
527 (set_window_hscroll): New function, containing the old guts of
528 Fset_window_hscroll. Return the clipped value.
529 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
530 This avoids the need to check against PTRDIFF_MAX.
531
dea7f1e5
PE
532 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
533
76046526
DA
5342012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
535
536 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
537
39adff0d
PE
5382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
539
63807d47
PE
540 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
541 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
542 since GCC 4.4.6 issues a bogus warning for them.
543
39adff0d
PE
544 Fix bugs in file timestamp newness comparisons.
545 * fileio.c (Ffile_newer_than_file_p):
546 * lread.c (Fload): Use full timestamp resolution of files,
547 not just the 1-second resolution, so that files that are only
548 slightly newer still count as newer.
549 * fileio.c (Ffile_newer_than_file_p): Don't assume file
550 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
551
dbeed9a6
PE
5522012-07-03 Paul Eggert <eggert@cs.ucla.edu>
553
554 * fileio.c: Improve handling of file time marker. (Bug#11852)
555 (special_mtime): New function.
556 (Finsert_file_contents, Fverify_visited_file_modtime):
557 Use it to set special mtime values consistently.
558
636334d6
AS
5592012-07-03 Andreas Schwab <schwab@linux-m68k.org>
560
561 * fileio.c (Finsert_file_contents): Properly handle st_mtime
562 marker for non-existing file. (Bug#11852)
563
e2017fe2
GM
5642012-07-03 Glenn Morris <rgm@gnu.org>
565
566 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
567 and did not make it into globals.h).
568
404dbd37
TT
5692012-07-03 Tom Tromey <tromey@redhat.com>
570
571 * window.c (Fset_window_margins, Fset_window_fringes)
572 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
573 * textprop.c (Fprevious_property_change): No longer static.
574 * syntax.c (Fsyntax_table_p): No longer static.
575 * process.c (Fget_process, Fprocess_datagram_address): No longer
576 static.
577 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
578 * keyboard.c (Fcommand_execute): No longer static.
579 Remove EXFUN.
580 * insdel.c (Fcombine_after_change_execute): No longer static.
581 * image.c (Finit_image_library): No longer static.
582 * fileio.c (Fmake_symbolic_link): No longer static.
583 * eval.c (Ffetch_bytecode): No longer static.
584 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
585 * doc.c (Fdocumentation_property, Fsnarf_documentation):
586 No longer static.
404dbd37
TT
587 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
588 static.
589 * dired.c (Ffile_attributes): No longer static.
590 * composite.c (Fcomposition_get_gstring): No longer static.
591 * callproc.c (Fgetenv_internal): No longer static.
592
593 * ccl.h: Remove EXFUNs.
594 * buffer.h: Remove EXFUNs.
595 * dispextern.h: Remove EXFUNs.
596 * intervals.h: Remove EXFUNs.
597 * fontset.h: Remove EXFUN.
598 * font.h: Remove EXFUNs.
599 * dosfns.c (system_process_attributes): Remove EXFUN.
600 * keymap.h: Remove EXFUNs.
601 * lisp.h: Remove EXFUNs.
602 * w32term.h: Remove EXFUNs.
603 * window.h: Remove EXFUNs.
604 * xsettings.h: Remove EXFUN.
605 * xterm.h: Remove EXFUN.
606
8e4fd1e1
GM
6072012-07-03 Glenn Morris <rgm@gnu.org>
608
609 * lisp.h (Frandom): Make it visible to C.
610 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
611 buffer for invisible buffers. (Bug#1229)
612
ca95b3eb
DA
6132012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
614
615 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
616 values which aren't power of 2.
617 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
618 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
619 accordingly.
620
7555c33f
SM
6212012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
622
623 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
624
625 * alloc.c (mark_object): Revert part of last patch to use `switch'.
626
d12e8f5a
DA
6272012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
628
629 * alloc.c (allocate_vector_block): Remove redundant
630 calls to mallopt if DOUG_LEA_MALLOC is defined.
631 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
632 avoid calls to mallopt if zero_vector is returned.
633
296094c3
DA
6342012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
635
636 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
637 is enabled, avoid dereferencing NULL current_sblock if
638 running undumped.
639
36429c89
DA
6402012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
641
642 Cleanup basic buffer management.
643 * buffer.h (struct buffer): Change layout to use generic vector
644 marking code. Fix some comments. Change type of 'clip_changed'
645 to bitfield. Remove unused #ifndef old.
646 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
647 (GET_OVERLAYS_AT): Fix indentation.
648 (for_each_per_buffer_object_at): New macro.
649 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
650 (Fbuffer_local_variables): Use it.
651 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
652 * alloc.c (allocate_buffer): Adjust to match new layout of
653 struct buffer. Fix comment.
654 (mark_overlay): New function.
655 (mark_buffer): Use it. Use mark_vectorlike to mark normal
656 Lisp area of struct buffer.
657 (mark_object): Use it. Adjust marking of misc objects
658 and related comments.
659
3b3e4cac
PE
6602012-07-02 Paul Eggert <eggert@cs.ucla.edu>
661
662 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
663 wrapper that is not needed because the wrapped code is a no-op (zero
664 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
665 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
666
cf5c0175
DA
6672012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
668
669 * alloc.c (mark_buffer): Simplify. Remove prototype.
670 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 671 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
672 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
673 redundant calls to mark_vectorlike for bool vectors.
674
ca26824c
GM
6752012-06-30 Glenn Morris <rgm@gnu.org>
676
2e4c5312
GM
677 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
678
ca26824c
GM
679 * epaths.in (PATH_SITELOADSEARCH): New.
680 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
681 This is rather than relying on --enable-locallisppath elements
682 having "site-lisp" in their names. (Bug#10208#25, 11658)
683
0d23c240
EZ
6842012-06-30 Eli Zaretskii <eliz@gnu.org>
685
c9240d7a
EZ
686 * w32proc.c (sys_select): Accept and ignore one more argument.
687
688 * w32.c (emacs_gnutls_pull): Call select with one more argument.
689
0d23c240 690 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 691 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
692
693 * sysdep.c: Don't include dos.h and dosfns.h.
694
695 * process.c (sys_select):
696 * msdos.c (sys_select): Accept one more argument and ignore it.
697
698 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
699 adapt data types and code to that.
700
701 * dosfns.c:
702 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
703 which clashes with the gnulib function of the same name.
704
af5a5a98
AS
7052012-06-30 Andreas Schwab <schwab@linux-m68k.org>
706
c5e4379c
AS
707 * font.c (font_style_to_value, font_style_symbolic)
708 (font_prop_validate_style): Add type checks for values in
709 font_style_table.
710
af5a5a98
AS
711 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
712 argument.
713 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
714 uses.
715
8d38f461
EZ
7162012-06-29 Eli Zaretskii <eliz@gnu.org>
717
2e5a6631
EZ
718 * xdisp.c (try_window_id): Undo last change.
719
8d38f461
EZ
720 * w32.c (getwd): Adjust commentary about startup_dir.
721 (init_environment): Always call sys_access, even in non-MSVC
722 builds. Don't chdir to the directory of the Emacs executable.
723 This undoes code from 1997 which was justified by the need to
724 "avoid conflicts when removing and renaming directories". But its
725 downside was that every relative file name was being interpreted
726 relative to the directory of the Emacs executable, which can never
727 be TRT. In particular, it broke sys_access when called with
728 relative file names.
729 (sys_access): Map GetLastError to errno.
730
2af3565e
DA
7312012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
732
733 * window.h (struct window): Change type of 'fringes_outside_margins'
734 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 735 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
736 Adjust comment.
737 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
738 to ptrdiff_t.
739
c8d3a25c 7402012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 741
c8d3a25c
GM
742 * gnutls.c (emacs_gnutls_handshake):
743 Add QUIT to make the loop interruptible.
57570cd3 744
c8d3a25c 7452012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 746
c8d3a25c
GM
747 * charset.c (init_charset): Make lack of etc/charsets fatal.
748
3e984ee8
DA
7492012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
750
751 * editfns.c (region_limit): Fix type mismatch.
752
ef884f23
DA
7532012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
754
755 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
756 undefined. Convert from xassert to eassert.
757 * nsmenu.m: Convert from xassert to eassert.
758 * nsterm.m: Likewise.
759
7d7e0027
SM
7602012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
761
762 * editfns.c (region_limit): Clip to narrowing (bug#11770).
763
aa754e6a
PE
7642012-06-28 Paul Eggert <eggert@cs.ucla.edu>
765
766 Avoid integer overflow on scroll-left and scroll-right.
767 * window.c (HSCROLL_MAX): New macro.
768 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
769 overflow when requested scroll falls outside ptrdiff_t range.
770
80b00b08
DA
7712012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
772
773 * window.h (struct window): Change type of 'hscroll',
774 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
775 'last_modified' and 'last_overlay_modified' to EMACS_INT.
776 Adjust users accordingly.
777 * xdisp.c (try_cursor_movement): Replace type check with eassert.
778 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
779 from EMACS_INT to ptrdiff_t.
780 (make_window): Omit redundant initialization.
781
62b2bcf6
JB
7822012-06-28 Juanma Barranquero <lekktu@gmail.com>
783
784 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
785
45942c7d
DA
7862012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
787
788 * window.h (struct window): Change type of 'use_time' and
789 'sequence_number' from Lisp_Object to int.
790 * frame.c (make_frame): Adjust users accordingly.
791 * print.c (print_object): Likewise.
792 * window.c (select_window, Fwindow_use_time, make_parent_window)
793 (make_window): Likewise.
794
e509cfa6
DA
7952012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
796
797 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
798 enabled with --enable-checking=[all,glyphs] configure option.
799 Fix GLYPH_DEBUG usage assuming that it may be undefined,
800 adjust comments accordingly.
801 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
802 undefined, adjust comments accordingly.
803 * image.c: Likewise.
804 * scroll.c: Likewise.
805 * w32fns.c: Likewise.
806 * w32term.c: Likewise.
807 * xdisp.c: Likewise.
808 * xfaces.c: Likewise.
809 * xfns.c: Likewise.
810 * xterm.c: Likewise.
811
a54e2c05
DA
8122012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
813
814 Generalize run-time debugging checks.
815 * dispextern.h (XASSERTS): Remove.
816 * fontset.c (xassert): Remove.
817 Convert from xassert to eassert.
818 * alloc.c: Convert from xassert to eassert.
819 * bidi.c: Likewise.
820 * dispnew.c: Likewise.
821 * fns.c: Likewise.
822 * fringe.c: Likewise.
823 * ftfont.c: Likewise.
824 * gtkutil.c: Likewise.
825 * image.c: Likewise.
826 * keyboard.c: Likewise.
827 * menu.c: Likewise.
828 * process.c: Likewise.
829 * scroll.c: Likewise.
830 * sound.c: Likewise.
831 * term.c: Likewise.
832 * w32console.c: Likewise.
833 * w32fns.c: Likewise.
834 * w32term.c: Likewise.
835 * window.c: Likewise.
836 * xdisp.c: Likewise.
837 * xfaces.c: Likewise.
838 * xfns.c: Likewise.
839 * xselect.c: Likewise.
840 * xterm.c: Likewise.
841
1ec4b7b2
SM
8422012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * fns.c (maybe_resize_hash_table): Output message when growing the
845 purify-hashtable.
846
2014308a
DA
8472012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
848
849 * alloc.c (allocate_string_data): Remove dead code.
850 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
851 avoid GCC warning about unused macro.
852
246155eb
DA
8532012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
854
855 * alloc.c (allocate_string): Omit intervals initialization.
856 * alloc.c (make_uninit_multibyte_string): Initialize intervals
857 as in make_pure_string and make_pure_c_string.
858
43184b7b
DA
8592012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
860
d209e2fb 861 * alloc.c (allocate_string): Fix last change.
43184b7b 862
3fe6dd74
DA
8632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
864
d209e2fb 865 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
866 to memset, add explicit initialization where appropriate.
867
1ba6038a
GM
8682012-06-27 Glenn Morris <rgm@gnu.org>
869
870 * lisp.mk (lisp): Remove paths.elc.
871
c89926a5
CY
8722012-06-27 Chong Yidong <cyd@gnu.org>
873
874 * doc.c (Fsubstitute_command_keys): Fix punctuation.
875
ed6b3510
JW
8762012-06-26 John Wiegley <johnw@newartisans.com>
877
1ec4b7b2 878 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
879 on Mac OS X Lion: __mod_init_func and __mod_term_func.
880
ed6b3510
JW
881 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
882 when building with Clang.
883
8edd4a2b
SM
8842012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
885
886 * eval.c (Fapply): Allow calling it with a single argument.
887
f6f62d1b
EZ
8882012-06-26 Eli Zaretskii <eliz@gnu.org>
889
890 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
891 _stricmp and _strnicmp.
892 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
893
62efea5e
DA
8942012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
895
896 * alloc.c (allocate_window): Zero out non-Lisp part of newly
897 allocated window.
898 (allocate_process): Likewise for new process.
8edd4a2b 899 (allocate_terminal): Change to use offsetof.
62efea5e
DA
900 (allocate_frame): Likewise.
901 * frame.c (make_frame): Omit redundant initialization.
902 * window.c (make_parent_window): Use memset.
903 (make_window): Omit redundant initialization.
904 * process.c (make_process): Omit redundant initialization.
905 * terminal.c (create_terminal): Likewise.
906
42997f4d
DA
9072012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
908
909 * term.c (delete_tty): Remove redundant call to memset.
910
1130ecfc
DA
9112012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
912
913 * alloc.c: Remove build_string.
914 * lisp.h: Define build_string as static inline. This provides
915 a better opportunity to optimize away calls to strlen when the
916 function is called with compile-time constant argument.
917 * image.c (imagemagick_error): Convert to build_string.
918 * w32proc.c (sys_spawnve): Likewise.
919 * xterm.c (x_term_init): Likewise.
920
cf38a720
PE
9212012-06-26 Paul Eggert <eggert@cs.ucla.edu>
922
99027bdd
PE
923 Use sprintf return value instead of invoking strlen on result.
924 In the old days this wasn't portable, since some sprintf
925 implementations returned char *. But they died out years ago and
926 Emacs already assumes sprintf returns int.
927 Similarly for float_to_string.
928 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
929 * ccl.c (ccl_driver):
930 * character.c (string_escape_byte8):
931 * data.c (Fnumber_to_string):
932 * doprnt.c (doprnt):
933 * print.c (print_object):
934 * xdisp.c (message_dolog):
935 * xfns.c (syms_of_xfns):
936 Use sprintf or float_to_string result to avoid need to call strlen.
937 * data.c (Fnumber_to_string):
938 Use make_unibyte_string, since the string must be ASCII.
939 * lisp.h, print.c (float_to_string): Now returns int length.
940 * term.c (produce_glyphless_glyph):
941 Use sprintf result rather than recomputing it.
942
cf38a720
PE
943 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
944 * Makefile.in (ALL_CFLAGS):
945 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
946 * gmalloc.c, regex.c: Include <config.h> unconditionally.
947
3511c784
DA
9482012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
949
0a08eb21 950 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
951 strcasecmp if available.
952 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
953
fb7da12e
AS
9542012-06-25 Andreas Schwab <schwab@linux-m68k.org>
955
956 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
957 Avoid comma operator.
958 * menu.c (push_submenu_start, push_submenu_end)
959 (push_left_right_boundary, push_menu_pane): Likewise.
960 * msdos.c (dos_rawgetc): Likewise.
961
afa2ffd8
DA
9622012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
963
964 * xfns.c (xic_create_fontsetname): Remove redundant calls
965 to memset.
966
b3b4476b
PE
9672012-06-25 Paul Eggert <eggert@cs.ucla.edu>
968
4495ff38
PE
969 * gtkutil.c (get_utf8_string): Remove redundant assignment.
970 sprintf already null-terminates its output.
971
b3b4476b
PE
972 * xfns.c (x_window): Remove redundant cast.
973
b00876c9
DA
9742012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
975
976 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
977 `const char *' to `char *' to avoid compiler warning.
978
d188e26b
PE
9792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
980
885d1d74
PE
981 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
982 instead of truncating it to 63 (admittedly a generous limit).
983
d188e26b
PE
984 * process.c: Fix spelling and caps in comments.
985
e2f560b1
DN
9862012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
987
e86db54b 988 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
989 * sysdep.c (setpgrp): Remove definition, not used in this file.
990
7583a3a1
JB
9912012-06-24 Juanma Barranquero <lekktu@gmail.com>
992
993 * makefile.w32-in: Update dependencies.
994
696056c2
EZ
9952012-06-24 Eli Zaretskii <eliz@gnu.org>
996
997 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
998 (SYSTIME_H): Add nt/inc/sys/time.h.
999
1000 * systime.h [WINDOWSNT]: Include sys/time.h.
1001
1002 * s/ms-w32.h (struct timespec): Definition moved from
1003 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1004
845ca893
PE
10052012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1008 * buffer.h (buffer_slot_type_mismatch):
1009 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1010 * eval.c (unwind_to_catch):
1011 * image.c (my_png_error, my_error_exit):
1012 * keyboard.c (quit_throw_to_read_char, user_error)
1013 (Fexit_recursive_edit, Fabort_recursive_edit):
1014 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1015 (wrong_type_argument, buffer_overflow, __executable_start)
1016 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1017 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1018 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1019 (fatal):
1020 (child_setup) [!DOS_NT]:
1021 * lread.c (end_of_file_error, invalid_syntax):
1022 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1023 * puresize.h (pure_write_error):
1024 * search.c (matcher_overflow):
1025 * sound.c (sound_perror, alsa_sound_perror):
1026 * sysdep.c, syssignal.h (croak):
1027 * term.c (maybe_fatal, vfatal):
1028 * textprop.c (text_read_only):
1029 * undo.c (user_error):
1030 * unexmacosx.c (unexec_error):
1031 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1032 Use _Noreturn rather than NO_RETURN.
1033 No need for separate decl merely because of _Noreturn.
1034 * sound.c (sound_warning, parse_sound):
1035 Remove unnecessary forward decls.
1036
f1dd8073
PE
10372012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1040 * lisp.h (WAIT_READING_MAX): New macro.
1041 * dispnew.c (Fsleep_for, sit_for):
1042 * keyboard.c (kbd_buffer_get_event):
1043 * process.c (Faccept_process_output):
1044 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1045 This improves on the previous patch, which introduced a bug
1046 when time_t is unsigned and as wide as intmax_t.
1047 See <http://bugs.gnu.org/9000#51>.
1048
b82c1755
EZ
10492012-06-23 Eli Zaretskii <eliz@gnu.org>
1050
1051 * dispnew.c (sit_for, Fsleep_for):
1052 * keyboard.c (kbd_buffer_get_event):
1053 * process.c (Faccept_process_output): Avoid compiler warnings when
1054 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1055
ca300656
JB
10562012-06-23 Juanma Barranquero <lekktu@gmail.com>
1057
049ec95b
JB
1058 * makefile.w32-in: Update dependencies.
1059
ca300656
JB
1060 * w32.c (ltime): Add return type and declare static.
1061 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1062
db7b8d06
PE
10632012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1066 Privately reported by Herbert J. Skuhra.
1067 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1068 All uses changed.
1069 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1070 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1071
0bd8297f
EZ
10722012-06-23 Eli Zaretskii <eliz@gnu.org>
1073
96512555
EZ
1074 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1075 last argument of make_unibyte_string.
1076
0bd8297f
EZ
1077 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1078 language ID in the event parameters.
1079
1080 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1081 event.code, not the obscure "character set ID".
1082
63def6b6
CY
10832012-06-23 Chong Yidong <cyd@gnu.org>
1084
1085 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1086
e8a02204
EZ
10872012-06-23 Eli Zaretskii <eliz@gnu.org>
1088
388cdec0
EZ
1089 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1090 * w32.c (fdutimens): New function.
1091
1092 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1093
1094 * s/ms-w32.h (pselect): Redirect to sys_select.
1095
1096 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1097
e8a02204
EZ
1098 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1099 in the logic of incrementing and decrementing the value of
1100 use_relocatable_buffers.
1101
d054f3fb
PE
11022012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1105 Privately reported by Herbert J. Skuhra.
1106 [__FreeBSD__]: Remove "*/" typo after "#include".
1107 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1108 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1109 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1110 Don't assume EMACS_TIME and struct timeval are the same type.
1111
d35af63c
PE
11122012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1113
1114 Support higher-resolution time stamps (Bug#9000).
1115 The time stamps are only nanosecond-resolution at the C level,
1116 since that's the best that any real-world system supports now.
1117 But they are picosecond-resolution at the Lisp level, as that's
1118 easy, and leaves room for future OS improvements.
1119
1120 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1121 (LIBES): Use it.
1122
1123 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1124 Don't get current time unless it's needed.
1125
1126 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1127 now provides it if it's absent.
1128 (start_atimer): Port to higher-res time stamps.
1129 Check for time stamp overflow. Don't get current time more
1130 often than is needed.
1131
1132 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1133 Include systime.h, not time.h.
1134 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1135
1136 * dired.c: Include stat-time.h.
1137 (Ffile-attributes): File times now have higher resolution.
1138
1139 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1140 (struct image): Timestamp now has higher resolution.
1141
1142 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1143 has at least microseconds now. All uses removed.
1144 (update_frame, update_single_window, update_window, update_frame_1)
1145 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1146
1147 * editfns.c (time_overflow): Now extern.
1148 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1149 (float-time, Fformat_time_string, Fcurrent_time_string)
1150 (Fcurrent_time_zone): Accept and generate higher-resolution
1151 time stamps.
1152 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1153 (decode_time_components, lisp_seconds_argument): New functions.
1154 (make_time): Now static.
1155 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1156 Report an error if the time is invalid, rather than having the caller
1157 do that.
1158
1159 * fileio.c: Include <stat-time.h>
1160 (Fcopy_file): Copy higher-resolution time stamps.
1161 Prefer to set the time stamp via a file descriptor if that works.
1162 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1163 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1164 (Fvisited_file_modtime, Fset_visited_file_modtime):
1165 Support higher-resolution time stamps.
1166
1167 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1168
1169 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1170
1171 * image.c (prepare_image_for_display, clear_image_cache)
1172 (lookup_image): Port to higer-resolution time stamps.
1173
1174 * keyboard.c (start_polling, bind_polling_period):
1175 Check for time stamp overflow.
1176 (read_char, kbd_buffer_get_event, timer_start_idle)
1177 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1178 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1179 Port to higher-resolution time stamps. Do not assume time_t is signed.
1180 (decode_timer): New function. Timers are now vectors of length 9,
1181 not 8, to accommodate the picosecond component.
1182 (timer_check_2): Use it.
1183
1184 * nsterm.m (select_timeout, timeval_subtract): Remove.
1185 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1186 as they're a bit more accurate and handle overflow better.
1187 (ns_select): Change prototype to be compatible with pselect.
1188 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1189 * nsterm.h (ns_select): Adjust prototype.
1190
1191 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1192 us-resolution time stamps.
1193 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1194
1195 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1196
1197 * lisp.h (time_overflow): New decl.
1198 (wait_reading_process_output): First arg is now intmax_t, not int,
1199 to accommodate larger waits.
1200
1201 * process.h (struct Lisp_Process.read_output_delay):
1202 Now counts nanoseconds, not microseconds.
1203 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1204 EMACS_HAS_USECS.
1205 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1206 (wait_reading_process_output):
1207 Port to ns-resolution time stamps.
1208 (Faccept_process_output, wait_reading_process_output):
1209 Check for time stamp overflow. Do not assume time_t is signed.
1210 (select_wrapper): Remove; we now use pselect.
1211 (Fprocess_attributes): Now generates ns-resolution time stamps.
1212
1213 * sysdep.c: Include utimens.h. Don't include utime.h
1214 or worry about struct utimbuf; gnulib does that for us now.
1215 (gettimeofday): Remove; gnulib provides a substitute.
1216 (make_timeval): New function.
1217 (set_file_times): Now sets ns-resolution time stamps.
1218 New arg FD; all uses changed.
1219 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1220 (system_process_attributes):
1221 Now returns ns-resolution time stamp. All uses changed.
1222 Check for time stamp overflow.
1223
1224 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1225 provides a substitute now.
1226
1227 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1228 since it guarantees struct timespec.
1229 (EMACS_TIME): Now struct timespec, so that we can support
1230 ns-resolution time stamps.
1231 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1232 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1233 (EMACS_USECS): Remove.
1234 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1235 so multiply the arg by 1000 before storing it.
1236 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1237 New macros.
1238 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1239 Port to ns-resolution time stamps.
1240 (EMACS_TIME_NEG_P): Remove; replaced by....
1241 (EMACS_TIME_SIGN): New macro.
1242 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1243 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1244 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1245 (make_timeval, make_lisp_time, decode_time_components): New decls.
1246 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1247 that it mishandled time_t overflow. You can't compare by subtracting!
1248 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1249 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1250
1251 * term.c: Include <sys/time.h>.
1252 (timeval_to_Time): New function, for proper overflow wraparound.
1253 (term_mouse_position, term_mouse_click): Use it.
1254
1255 * undo.c (record_first_change): Support higher-resolution time stamps
1256 in the undo buffer.
1257 (Fprimitive_undo): Use them when restoring time stamps.
1258
1259 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1260 (w32_get_internal_run_time):
1261 Port to higher-resolution Emacs time stamps.
1262 (ltime): Now accepts single 64-bit integer, as that's more convenient
1263 for callers.
1264
1265 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1266
1267 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1268 for compatibility with pselect. Support ns-resolution time stamps.
1269
1270 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1271
1272 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1273 Check for time stamp overflow, and support ns-resolution time stamps.
1274
1275 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1276 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1277 (timeval_subtract): Remove; no longer needed.
1278 (XTflash, XTring_bell, x_wait_for_event):
1279 Port to ns-resolution time stamps. Don't assume time_t is signed.
1280
b6a92dfe
CY
12812012-06-22 Chong Yidong <cyd@gnu.org>
1282
1283 * xdisp.c (x_consider_frame_title): Revert last change.
1284
d251c37c
EZ
12852012-06-22 Eli Zaretskii <eliz@gnu.org>
1286
1287 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1288 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1289 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1290 staticidx goes up to 1597 out of 1600 = 0x640.)
1291
f10deafb
PE
12922012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1295 Otherwise, the umask might be mistakenly 0 while handling input signals.
1296
ec6de1e2
SM
12972012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1298
1299 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1300
28be1ada
DA
13012012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1302
1303 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1304 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1305 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1306 access to `contents' member of Lisp_Vector objects with AREF and ASET
1307 where appropriate.
1308
c6bf3022
CY
13092012-06-19 Chong Yidong <cyd@gnu.org>
1310
1311 * frame.c (delete_frame): When selecting a frame on a different
1312 text terminal, do not alter the terminal's top-frame.
1313
1314 * xdisp.c (format_mode_line_unwind_data): Record the target
1315 frame's selected window and its terminal's top-frame.
1316 (unwind_format_mode_line): Restore them.
1317 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1318 Callers changed.
1319 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1320 since tty frames can be explicitly named.
1321 (prepare_menu_bars): Likewise.
1322
1323 * term.c (Ftty_top_frame): New function.
1324
defd4196
PE
13252012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 Port byte-code-meter to modern targets.
1328 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1329 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1330 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1331 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1332 (METER_1, METER_2): Simplify.
1333
1053a871
SM
13342012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1335
1336 * data.c (Fdefalias): Return `symbol' (bug#11686).
1337
b7e8d081
MR
13382012-06-18 Martin Rudalics <rudalics@gmx.at>
1339
1340 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1341 gets killed during executing of this function (Bug#11665).
1342 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1343 (Vkill_buffer_query_functions): In doc-string say that functions
1344 run by this hook should not change the current buffer.
1345
7ea2b339
PE
13462012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 Fix recently-introduced process.c problems found by static checking.
1349 * process.c (write_queue_push, write_queue_pop, send_process):
1350 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1351 (write_queue_pop): Fix pointer signedness problem.
1352 (send_process): Remove unused local.
1353
96a313a1
CY
13542012-06-17 Chong Yidong <cyd@gnu.org>
1355
1356 * xdisp.c (redisplay_internal): No need to redisplay terminal
1357 frames that are not on top.
1358
20ca2e94
TN
13592012-06-17 Troels Nielsen <bn.troels@gmail.com>
1360
1361 * process.c (make_process): Initialize write_queue.
1362 (write_queue_push, write_queue_pop): New functions.
1363 (send_process): Use them to maintain correct ordering of process
1364 writes (Bug#10815).
1365
9a900ca9
PE
13662012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1367
310fbfa8
PE
1368 * lisp.h (eassert): Assume C89 or later.
1369 This removes the need for CHECK.
1370 (CHECK): Remove. Its comments about always evaluating its
1371 argument were confusing, as 'eassert' typically does not evaluate
1372 its argument.
1373
27bb1ca4
PE
1374 * coding.c (produce_chars): Use ptrdiff_t, not int.
1375
9a900ca9
PE
1376 * xterm.c (x_draw_underwave): Check for integer overflow.
1377 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1378
41b7f8bc 13792012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1380
1381 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1382 referenced (Bug#11583).
1383
9b0e3eba
AA
13842012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1385
1386 Implement wave-style variant of underlining.
1387 * dispextern.h (face_underline_type): New enum.
1388 (face): Add field for underline type.
1389 * nsterm.m (ns_draw_underwave): New function.
1390 (ns_draw_text_decoration): Use it.
1391 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1392 New functions.
1393 (x_draw_glyph_string): Use them.
1394 * xfaces.c (Qline, Qwave): New Lisp objects.
1395 (check_lface_attrs, merge_face_ref)
1053a871
SM
1396 (Finternal_set_lisp_face_attribute, realize_x_face):
1397 Handle wave-style underline face attributes.
9b0e3eba
AA
1398 * xterm.c (x_draw_underwave): New function.
1399 (x_draw_glyph_string): Use it.
1400
0fb52f11
JB
14012012-06-16 Juanma Barranquero <lekktu@gmail.com>
1402
1403 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1404 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1405 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1406 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1407 ($(BLD)/w32select.$(O)): Update dependencies.
1408
e5560ff7
AS
14092012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1410
1411 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1412 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1413 * character.c (_fetch_multibyte_char_p): Remove.
1414 * alloc.c: Include "character.h" before "buffer.h".
1415 * bidi.c: Likewise.
1416 * buffer.c: Likewise.
1417 * bytecode.c: Likewise.
1418 * callint.c: Likewise.
1419 * callproc.c: Likewise.
1420 * casefiddle.c: Likewise.
1421 * casetab.c: Likewise.
1422 * category.c: Likewise.
1423 * cmds.c: Likewise.
1424 * coding.c: Likewise.
1425 * composite.c: Likewise.
1426 * dired.c: Likewise.
1427 * dispnew.c: Likewise.
1428 * doc.c: Likewise.
1429 * dosfns.c: Likewise.
1430 * editfns.c: Likewise.
1431 * emacs.c: Likewise.
1432 * fileio.c: Likewise.
1433 * filelock.c: Likewise.
1434 * font.c: Likewise.
1435 * fontset.c: Likewise.
1436 * fringe.c: Likewise.
1437 * indent.c: Likewise.
1438 * insdel.c: Likewise.
1439 * intervals.c: Likewise.
1440 * keyboard.c: Likewise.
1441 * keymap.c: Likewise.
1442 * lread.c: Likewise.
1443 * macros.c: Likewise.
1444 * marker.c: Likewise.
1445 * minibuf.c: Likewise.
1446 * nsfns.m: Likewise.
1447 * nsmenu.m: Likewise.
1448 * print.c: Likewise.
1449 * process.c: Likewise.
1450 * regex.c: Likewise.
1451 * region-cache.c: Likewise.
1452 * search.c: Likewise.
1453 * syntax.c: Likewise.
1454 * term.c: Likewise.
1455 * textprop.c: Likewise.
1456 * undo.c: Likewise.
1457 * unexsol.c: Likewise.
1458 * w16select.c: Likewise.
1459 * w32fns.c: Likewise.
1460 * w32menu.c: Likewise.
1461 * window.c: Likewise.
1462 * xdisp.c: Likewise.
1463 * xfns.c: Likewise.
1464 * xmenu.c: Likewise.
1465 * xml.c: Likewise.
1466 * xselect.c: Likewise.
1467
2f07e6af
EZ
14682012-06-16 Eli Zaretskii <eliz@gnu.org>
1469
1053a871
SM
1470 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1471 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1472 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1473 row.
1474 (handle_face_prop): Use chunk-relative overlay string index when
1475 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1476 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1477 the rightmost. (Bug#11720)
2f07e6af 1478
29b83cec
AS
14792012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1480
1481 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1482 (CATEGORY_MEMBER): Enforce 1/0 value.
1483 * category.c (_temp_category_set): Remove.
1484
4c5501e9
EZ
14852012-06-16 Eli Zaretskii <eliz@gnu.org>
1486
1487 * window.c (Fdelete_other_windows_internal)
1488 (Fdelete_window_internal): Don't access frame's mouse highlight
1489 info of the initial frame. (Bug#11677)
1490
2b570124
PE
14912012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1492
e93864f9
PE
1493 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1494 Assume USE_2_TAGS_FOR_INTS.
1495 (xreload): Adjust $tagmask width to match recent lisp.h change.
1496
2b570124
PE
1497 Simplify lisp.h in minor ways that should not affect code.
1498 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1499 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1500 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1501 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1502 (INTTYPEBITS): New macro, for clarity.
1503 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1504 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1505 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1506 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1507 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1508
81755f69
JB
15092012-06-13 Juanma Barranquero <lekktu@gmail.com>
1510
1511 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1512
16192a57
GM
15132012-06-13 Glenn Morris <rgm@gnu.org>
1514
1515 * s/bsd-common.h (BSD4_3):
1516 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1517
646b5f55
AS
15182012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1519
1520 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1521 instead of union.
1522 (XLI, XIL): Define.
1053a871
SM
1523 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1524 Use them.
1525 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1526 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1527 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1528 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1529 * frame.c (delete_frame): Remove outdated comment.
1530 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1531 USE_LISP_UNION_TYPE.
1532 (Fw32_unregister_hot_key): Likewise.
1533 (Fw32_toggle_lock_key): Likewise.
1534 * w32menu.c (add_menu_item): Likewise.
1535 (w32_menu_display_help): Use XIL instead of checking
1536 USE_LISP_UNION_TYPE.
1537 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1538 (init_heap): Likewise.
1539 * w32term.c (w32_read_socket): Update comment.
1540
1d3823c9
GM
15412012-06-13 Glenn Morris <rgm@gnu.org>
1542
c62ff706
GM
1543 * s/usg5-4-common.h, src/s/unixware.h:
1544 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1545
1d3823c9
GM
1546 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1547
bfe3e0a2
PE
15482012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1549
1550 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1551 * alloc.c (make_number) [!defined make_number]:
1552 Remove, as lisp.h always defines this now.
1553 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1554 (roundup_size): Verify that it is a power of 2.
1555 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1556 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1557 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1558 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1559 USE_LSB_TAG now is always defined to be either 0 or 1.
1560 All uses changed.
1561 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1562 code works fine either way, and efficiency is not a concern here,
1563 as the union type is for debugging, not for production.
1564 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1565 Use an inline function on all platforms when using the union type,
1566 since this is simpler and 'static inline' can be used portably
1567 within Emacs now.
1568 (LISP_INITIALLY_ZERO): New macro.
1569 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1570 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1571
45fa9c0f
GM
15722012-06-12 Glenn Morris <rgm@gnu.org>
1573
b4492cba
GM
1574 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1575
1576 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1577
45fa9c0f
GM
1578 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1579 Move BROKEN_SIGIO to configure.
1580
1581 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1582 Move NO_TERMIO to configure.
1583
0e25d334
CY
15842012-06-12 Chong Yidong <cyd@gnu.org>
1585
1586 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1587 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1588 MagickExportImagePixels is undefined.
1589
43682bb6
PE
15902012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1591
1592 * image.c (imagemagick_load_image): Remove unused label.
1593
a9be7d2b
GM
15942012-06-11 Glenn Morris <rgm@gnu.org>
1595
1596 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1597 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1598 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1599 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1600
3017f87f
SM
16012012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1602
1603 * alloc.c (make_byte_code): New function.
1604 (Fmake_byte_code): Use it. Don't purify here.
1605 * lread.c (read1): Use it as well to avoid extra allocation.
1606
1b9b4cf4
CY
16072012-06-11 Chong Yidong <cyd@gnu.org>
1608
1609 * image.c (imagemagick_load_image): Implement transparency.
1610
95988fcf
AS
16112012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1612
1613 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1614 account for preceding backslashes. (Bug#11663)
1615
cd4eb164
CY
16162012-06-09 Chong Yidong <cyd@gnu.org>
1617
1618 * term.c: Support italics in capable terminals (Bug#9652).
1619 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1620 (turn_on_face): Output using TS_enter_italic_mode if available.
1621 Don't handle unused blinking and alt-charset cases.
1622 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1623 and tty_alt_charset_p cases.
1624 (tty_capable_p, init_tty): Support italics.
1625
1626 * termchar.h (struct tty_display_info): Add field for italics.
1627 Remove unused blink field.
1628
1629 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1630 Handle slant.
1631
1632 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1633 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1634 tty_alt_charset_p. Add tty_italic_p.
1635
ff88beb8
MA
16362012-06-09 Michael Albinus <michael.albinus@gmx.de>
1637
1638 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1639 dbus_type_is_basic if available.
1640 (xd_extract_signed, xd_extract_unsigned): Rename from
1641 extract_signed and extract_unsigned, respectively. Adapt callers.
1642
44286096
CY
16432012-06-09 Chong Yidong <cyd@gnu.org>
1644
1682701f
CY
1645 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1646
44286096
CY
1647 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1648 case (Bug#9752).
1649
d86feb17
PE
16502012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 * xdisp.c (vmessage): Treat frame message as multibyte.
1653 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1654 would generate the diagnostic "Making \302\247 buffer-local while
1655 let-bound!".
1656
d5c20fe8
EZ
16572012-06-08 Eli Zaretskii <eliz@gnu.org>
1658
1659 * dispnew.c (showing_window_margins_p): Undo last change, which
1660 was done due to an inadvertent commit.
1661 (adjust_frame_glyphs_for_frame_redisplay): Do call
1662 showing_window_margins_p.
1663
513749ee
SM
16642012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1665
1666 * eval.c (Fmake_var_non_special): New primitive.
1667 (syms_of_eval): Defsubr it.
1668 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1669
d4a8f5c1
JB
16702012-06-08 Juanma Barranquero <lekktu@gmail.com>
1671
1672 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1673 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1674
8bbbc977
EZ
16752012-06-08 Eli Zaretskii <eliz@gnu.org>
1676
1677 * alloc.c (allocate_vectorlike): Fix last change.
1678
f3372c87
DA
16792012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1680
1681 Block-based vector allocation of small vectors.
1682 * lisp.h (struct vectorlike_header): New field `nbytes',
1683 adjust comment accordingly.
1684 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1685 to denote vector blocks. Adjust users (live_vector_p,
1686 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1687 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1688 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1689 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1690 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1691 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1692 (roundup_size): New constant.
1693 (struct vector_block): New data type.
1694 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1695 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1696 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1697 (sweep_vectors): New functions.
1698 (allocate_vectorlike): Return `zero_vector' as the only vector of
1699 0 items. Allocate new vector from block if vector size is less than
1700 or equal to VBLOCK_BYTES_MAX.
1701 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1702 (init_alloc_once): Add call to init_vectors.
1703
4f18a4ed
SM
17042012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1705
1706 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1707
86f158bc
PE
17082012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 * doprnt.c (doprnt): Truncate multibyte char correctly.
1711 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1712 would mishandle a string argument "Xc" if X was a multibyte
1713 character of length 2: it would truncate after X's first byte
1714 rather than including all of X.
1715
c5cfcbe0
CY
17162012-06-06 Chong Yidong <cyd@gnu.org>
1717
1718 * buffer.c (word_wrap): Doc fix.
1719
c05cf390
PE
17202012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1721
1722 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1723
0c3461de
GM
17242012-06-03 Glenn Morris <rgm@gnu.org>
1725
1726 * xdisp.c (tool-bar-style): Doc fix.
1727
c71232db
UM
17282012-06-03 Ulrich Müller <ulm@gentoo.org>
1729
1730 * Makefile.in (PAXCTL): Define.
1731 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1732 binary via PaX flags if the paxctl utility is available.
1733 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1734 Restore PaX flags to their default. (Bug#11398)
1735
383f7350
CY
17362012-06-03 Chong Yidong <cyd@gnu.org>
1737
1738 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1739 buffer (Bug#11226).
1740
5f2c76c6
CY
17412012-06-03 Chong Yidong <cyd@gnu.org>
1742
1743 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1744 (note_mode_line_or_margin_highlight): If there is no help echo,
1745 use mode-line-default-help-echo. Handle the case where the mouse
1746 position is past the end of the mode line string.
1747
1748 * buffer.c (buffer_local_value_1): New function, split from
1749 Fbuffer_local_value; can return Qunbound.
1750 (Fbuffer_local_value): Use it.
1751 (Vmode_line_format): Docstring tweaks.
1752
773d47f6
PE
17532012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 * sysdep.c (system_process_attributes): Improve comment.
1756
f2d6a3df
SM
17572012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1758
1759 * keyboard.c: Export real-this-command to Elisp.
1760 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1761 and DEFVAR it. Update all users.
1762
63810350
PE
17632012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1764
7bd5c1f4
PE
1765 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1766
63810350
PE
1767 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1768 Convert pctcpu and pctmem to Lisp float properly.
1769 Let the compiler fold better, as 100.0/0x8000 is exact.
1770
a2821611
AS
17712012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1772
1773 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1774 cons_block.
1775
5fceba1d
PE
17762012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1779
c98ff5dd
DA
17802012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1781
1782 For a 'struct window', replace some Lisp_Object fields to
1783 bitfields where appropriate, remove unused fields.
1784 * window.h (struct window): Remove unused 'last_mark_x' and
1785 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1786 change it's type from Lisp_Object to bitfield.
1787 Change type of 'force_start', 'optional_new_start',
1788 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1789 fields from Lisp_Object to bitfield. Adjust users accordingly.
1790
ca34e0be
PE
17912012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 Pacify gcc -Wdouble-precision when using Xaw.
1794 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1795 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1796 Use 'float' consistently, rather than 'float' in most places
1797 and 'double' in a couple of places.
1798
efc00ab1 17992012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1800
1801 * xdisp.c (handle_stop): Detect whether we have overlay strings
1802 loaded by testing it->current.overlay_string_index to be
1803 non-negative, instead of checking whether n_overlay_strings is
1804 positive. (Bug#11587)
1805
efc00ab1 18062012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1807
1808 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1809
1810 * doc.c (Fsubstitute_command_keys): Doc fix.
1811
efc00ab1 18122012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1813
1814 * search.c (search_buffer): Remove calls to
1815 r_alloc_inhibit_buffer_relocation, as it is now called by
1816 maybe_unify_char, which was the cause of relocation of buffer text
1817 in bug#11519.
1818
efc00ab1 18192012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1820
1821 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1822 for the duration of call to load_charset, to avoid problems with
1823 callers of maybe_unify_char that access buffer text through C
1824 pointers.
1825
1826 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1827 decrement the inhibition flag, instead of just setting or
1828 resetting it.
1829
ba93a187
PE
18302012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1831
1832 Remove obsolete '#define static' cruft.
1833 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1834 This #undef was "temporary" in 2000; it is no longer needed
1835 now that '#define static' has gone away.
1836 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1837 (gray_bitmap_bits): Remove; no longer needed.
1838 All uses replaced with definiens.
1839 * xterm.c: Include "bitmaps/gray.xbm".
1840
9e4bf381
PE
18412012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 Clean up __executable_start, monstartup when --enable-profiling.
1844 The following changes affect the code only when profiling.
1845 * dispnew.c (__executable_start): Rename from safe_bcopy.
1846 Define only on platforms that need it.
1847 * emacs.c: Include <sys/gmon.h> when profiling.
1848 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1849 (__executable_start): Remove decl, since lisp.h does it now.
1850 (safe_bcopy): Remove decl; no longer has that name.
1851 (main): Coalesce #if into single bit of code, for simplicity.
1852 Cast pointers to uintptr_t, since standard libraries want integers
1853 and not pointers.
1854 * lisp.h (__executable_start): New decl.
1855
32d72c2f
GM
18562012-05-31 Glenn Morris <rgm@gnu.org>
1857
1858 * image.c (Fimagemagick_types): Doc fix.
1859
baac5bc7
JM
18602012-05-30 Jim Meyering <meyering@redhat.com>
1861
1862 * callproc.c (Fcall_process_region): Include directory component
1863 in mkstemp error message (Bug#11586).
1864
72cb32cf
PE
18652012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * alloc.c, lisp.h (make_pure_vector): Now static.
1868
61b108cc
SM
18692012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1870
1871 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1872 Move to byte-run.el.
1873 (Fautoload): Do the hash-doc more carefully.
1874 * data.c (Fdefalias): Purify definition, except for keymaps.
1875 (Qdefun): Move from eval.c.
1876 * lisp.h (Qdefun): Remove.
1877 * lread.c (read1): Tiny simplification.
1878
471fe23d
TN
18792012-05-29 Troels Nielsen <bn.troels@gmail.com>
1880
934f3f58 1881 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1882 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1883 Bug#9642, but explicitly check that the buffer the overlay would
1884 be moved to is live and rearrange lines to make sure that errors
1885 will not put the overlay in an inconsistent state.
1886 (Fdelete_overlay): Cosmetics.
1887
85d0efd1
EZ
18882012-05-28 Eli Zaretskii <eliz@gnu.org>
1889
1890 * w32term.c (my_bring_window_to_top): New function.
1891 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1892 could be different from the original one.
1893 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1894 (Bug#11513)
1895
1896 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1897 by calling BringWindowToTop.
1898
1899 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1900 (WM_EMACS_END): Increase by one.
1901
da92a98c
PE
19022012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1905 This avoids undefined behavior that might cause the eassert
1906 to not catch an out-of-range value.
1907
74d1f848
JB
19082012-05-28 Juanma Barranquero <lekktu@gmail.com>
1909
1910 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1911 Update dependencies.
1912
9e1a06fc
EZ
19132012-05-27 Eli Zaretskii <eliz@gnu.org>
1914
1915 * bidi.c (bidi_mirror_char): Fix last change.
1916
f3dd7312
AS
19172012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1918
1919 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1920 when referring to sectname field in printf format.
1921
81899c91
PE
19222012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1923
57b81a9f
PE
1924 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1925 Only r_alloc_inhibit_buffer_relocation needed to be added;
1926 the others were already declared.
1927
81899c91
PE
1928 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1929 before checking whether it's out of range. Put the check inside
1930 eassert. See
1931 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1932
33017faf 19332012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1934
1935 * callproc.c (Fcall_process): Restore a line that was accidentally
1936 commented out in the 2011-02-13 change (bug#11547).
1937
33017faf 19382012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1939
1940 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1941 defined on ralloc.c.
1942
1943 * buffer.c [REL_ALLOC]: Remove prototypes of
1944 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1945 they are now on lisp.h.
1946
1947 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1948
1949 * search.c (search_buffer): Use it to inhibit relocation of buffer
1950 text while re_search_2 is doing its job, because re_search_2 is
1951 passed C pointers to buffer text. (Bug#11519)
1952
23415acf
EZ
1953 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1954 Update value to 24.
1955
44e27368
EZ
1956 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1957 state after an additional call to move_it_in_display_line_to, keep
1958 the values of it->max_ascent and it->max_descent found for the
1959 entire line.
1960 (pos_visible_p): Revert the comparison against bottom_y to what it
1961 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1962 (Bug#11464)
1963
c1892f11
PE
19642012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 Fix coding-related core dumps with gcc -ftrapv.
1967 The code was computing A - B, where A and B are pointers, and B is
1968 random garbage. This can lead to core dumps on platforms that
1969 have special pointer registers, and it also leads to core dumps on
1970 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1971 A - B only when B is initialized properly.
1972 * coding.c (coding_set_source, coding_set_destination): Return void.
1973 (coding_change_source, coding_change_destinations): New functions,
1974 with the old behaviors of coding_set_source and coding_set_destination.
1975 All callers that need an offset changed to use these new functions.
1976
eb7afdad
GM
19772012-05-26 Glenn Morris <rgm@gnu.org>
1978
1979 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1980
f12fdf02
EZ
19812012-05-26 Eli Zaretskii <eliz@gnu.org>
1982
53a63be6 1983 Extend mouse support on W32 text-mode console.
61b108cc
SM
1984 * xdisp.c (draw_row_with_mouse_face):
1985 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1986
eb3f6f01 1987 * w32console.c: Include window.h.
61b108cc
SM
1988 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1989 New functions.
eb3f6f01
EZ
1990 (initialize_w32_display): Initialize mouse-highlight data.
1991
53a63be6
EZ
1992 * w32inevt.c: Include termchar.h and window.h.
1993 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1994 moves, call note_mouse_highlight. If help_echo changed, call
1995 gen_help_event to produce help-echo message in the echo area.
1996 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1997 highlight info.
1998
4cfd81f6
PE
19992012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * lread.c (read1): Simplify slightly to avoid an overflow warning
2002 with GCC 4.7.0 on x86-64.
2003
4446092a
EZ
20042012-05-26 Eli Zaretskii <eliz@gnu.org>
2005
2006 * bidi.c (bidi_mirror_char): Revert last change: an int is
2007 definitely wide enough here.
2008
42b2a986 20092012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2010
42b2a986 2011 Fix integer width and related bugs (Bug#9874).
eb106a49 2012 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2013 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2014 (string_bytes, check_sblock, allocate_string_data):
2015 (compact_small_strings, Fmake_bool_vector, make_string)
2016 (make_unibyte_string, make_multibyte_string)
2017 (make_string_from_bytes, make_specified_string)
2018 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2019 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2020 (mark_vectorlike):
2021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2022 (allocate_pseudovector):
2023 Use int, not EMACS_INT, where int is wide enough.
2024 (inhibit_garbage_collection, Fgarbage_collect):
2025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2026 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2027 int might not be wide enough.
2028 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2029 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2030 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2031 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2032 (bidi_level_of_next_char, bidi_move_to_visually_next):
2033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2034 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2035 (Fkill_buffer, Fset_buffer_major_mode)
2036 (advance_to_char_boundary, Fbuffer_swap_text)
2037 (Fset_buffer_multibyte, overlays_at, overlays_in)
2038 (overlay_touches_p, struct sortvec, record_overlay_string)
2039 (overlay_strings, recenter_overlay_lists)
2040 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2041 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2042 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2043 (Foverlay_recenter, last_overlay_modification_hooks_used)
2044 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2046 (validate_region): Omit unnecessary test for b <= e,
2047 since that's guaranteed by the previous test.
d311d28c
PE
2048 (adjust_overlays_for_delete): Avoid pos + length overflow.
2049 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2050 (report_overlay_modification):
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2053 Omit pointer cast, which isn't needed anyway, and doesn't work
2054 after the EMACS_INT -> ptrdiff_t change.
02481186 2055 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2056 * buffer.h: Adjust decls to match defn changes elsewhere.
2057 (struct buffer_text, struct buffer):
2058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2059 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2060 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2061 not int, to avoid needless 32-bit limit on 64-bit hosts.
2062 (exec_byte_code): Use tighter memory-full test, one that checks
2063 for alloca overflow. Don't compute the address of the object just
2064 before an array, as that's not portable. Use EMACS_INT, not
2065 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2066 * callint.c (Fcall_interactively):
2067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2068 * callproc.c (call_process_kill, Fcall_process):
2069 Don't assume pid_t fits into an Emacs fixnum.
2070 (call_process_cleanup, Fcall_process, child_setup):
2071 Don't assume pid_t fits into int.
2072 (call_process_cleanup, Fcall_process, delete_temp_file)
2073 (Fcall_process_region):
2074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2075 (Fcall_process): Simplify handling of volatile integers.
2076 Use int, not EMACS_INT, where int will do.
2077 * casefiddle.c (casify_object, casify_region, operate_on_word)
2078 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2080 (casify_object): Avoid integer overflow when overallocating buffer.
2081 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2082 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2083 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2084 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2085 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2086 integers are now checked earlier. All uses replaced with XINT.
2087 (ccl_driver):
2088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2089 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2090 (ccl_driver, Fregister_code_conversion_map):
2091 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2092 (resolve_symbol_ccl_program): Check that vector header is in range.
2093 Always copy the vector, so that we can check its contents reliably
2094 now rather than having to recheck each instruction as it's being
2095 executed. Check that vector words fit in 'int'.
2096 (ccl_get_compiled_code, Fregister_ccl_program)
2097 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2098 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2099 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2100 contents are in range.
2101 (Fccl_execute_on_string): Check that status is in range.
2102 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2103 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2104 Accept and return EMACS_INT, not int, because callers can pass values
2105 out of 'int' range.
2106 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2107 (multibyte_chars_in_text, parse_str_as_multibyte)
2108 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2109 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2110 (string_escape_byte8, Fget_byte):
2111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2112 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2113 avoid mishandling large integers.
2114 * character.h: Adjust decls to match defn changes elsewhere.
2115 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2116 (Ffind_charset_region):
2117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2118 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2119 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2120 Don't assume fixnum fits in int.
d311d28c
PE
2121 (load_charset_map_from_vector, Fmap_charset_chars):
2122 Remove now-unnecessary CHECK_NATNUMs.
2123 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2124 Don't rely on undefined behavior with signed left shift overflow.
2125 Don't assume unsigned int fits into fixnum, or that fixnum fits
2126 into unsigned int. Don't require max_code to be a valid fixnum;
2127 that's not true for gb10830 4-byte on a 32-bit host. Allow
2128 invalid_code to be a cons, for the same reason. Require code_offset
2129 to be a character. Avoid int overflow if max_char is close
2130 to INT_MAX.
2131 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2132 this is intended anyway and avoids some undefined behavior.
2133 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2134 INDEX_TO_CODE_POINT, as that's what it expects.
2135 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2136 * charset.h (DECODE_CHAR): Return int, not unsigned;
2137 this is what was intended anyway, and it avoids undefined behavior.
2138 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2139 integer-overflow issues.
2140 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2141 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2142 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2143 * chartab.c (Fmake_char_table, Fset_char_table_range)
2144 (uniprop_get_decoder, uniprop_get_encoder):
2145 Don't assume fixnum fits in int.
2146 * cmds.c (move_point): New function, that does the gist of
2147 Fforward_char and Fbackward_char, but does so while checking
2148 for integer overflow more accurately.
c96e5d6a 2149 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2150 (Fforward_line, Fend_of_line, internal_self_insert)
2151 (internal_self_insert):
2152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2153 Fix a FIXME, by checking for integer overflow when calculating
2154 target_clm and actual_clm.
2155 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2156 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2157 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2158 (coding_alloc_by_making_gap, alloc_destination)
2159 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2160 (encode_coding_utf_16, detect_coding_emacs_mule)
2161 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2162 (detect_coding_iso_2022, decode_coding_iso_2022)
2163 (encode_invocation_designation, encode_designation_at_bol)
2164 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2165 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2166 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2167 (encode_coding_ccl, encode_coding_raw_text)
2168 (detect_coding_charset, decode_coding_charset)
2169 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2170 (produce_composition, produce_charset, produce_annotation)
2171 (decode_coding, handle_composition_annotation)
2172 (handle_charset_annotation, consume_chars, decode_coding_gap)
2173 (decode_coding_object, encode_coding_object, detect_coding_system)
2174 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2175 (code_convert_region, code_convert_string)
8f50130c
PE
2176 (Fdefine_coding_system_internal)
2177 (coding_set_source, coding_set_destination):
d311d28c
PE
2178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2179 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2180 (Fdefine_coding_system_internal):
2181 Don't assume fixnums fit in int.
2182 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2183 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2184 (Funencodable_char_position, Fcheck_coding_systems_region)
2185 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2187 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2188 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2189 Don't access memory outside of the args array.
d311d28c 2190 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2191 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2192 result of ENCODE_CHAR.
d311d28c
PE
2193 * coding.h: Adjust decls to match defn changes elsewhere.
2194 (struct coding_system):
2195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2196 * composite.c (get_composition_id, find_composition)
2197 (run_composition_function, update_compositions)
2198 (compose_text, composition_gstring_put_cache)
2199 (composition_gstring_p, composition_gstring_width)
2200 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2201 (composition_compute_stop_pos, composition_reseat_it)
2202 (composition_update_it, struct position_record)
2203 (find_automatic_composition, composition_adjust_point)
2204 (Fcomposition_get_gstring, Ffind_composition_internal):
2205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2206 (update_compositions):
2207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2208 * composite.h: Adjust decls to match defn changes elsewhere.
2209 (struct composition):
2210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2211 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2212 Do not attempt to compute the address of the object just before a
2213 buffer; this is not portable.
2214 (Faref, Faset):
2215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2216 (Faset): Use int, not EMACS_INT, where int is wide enough.
2217 (Fstring_to_number): Don't assume fixnums fit in int.
2218 (Frem): Don't assume arg is nonnegative.
2219 * dbusbind.c (xd_append_arg): Check for integers out of range.
2220 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2221 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2222 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2223 (xd_get_connection_references): Return ptrdiff_t, not int.
2224 All uses changed.
2225 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2226 (xd_read_message_1):
2227 Use int, not unsigned, where the dbus API uses int.
2228 (Fdbus_message_internal): Don't overflow mtype.
2229 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2230 * dired.c (directory_files_internal, file_name_completion, scmp)
2231 (file_name_completion_stat):
2232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2233 (file_name_completion): Don't overflow matchcount.
2234 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2235 * dispextern.h: Adjust decls to match defn changes elsewhere.
2236 (struct text_pos, struct glyph, struct bidi_saved_info)
2237 (struct bidi_string_data, struct bidi_it, struct composition_it)
2238 (struct it):
2239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2240 (struct display_pos, struct composition_it, struct it):
2241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2242 * dispnew.c (increment_matrix_positions)
2243 (increment_row_positions, mode_line_string)
2244 (marginal_area_string):
2245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2246 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2248 (duration_to_sec_usec): New function, to check for overflow better.
2249 (Fsleep_for, sit_for): Use it.
2250 * doc.c (get_doc_string, store_function_docstring):
2251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2252 (get_doc_string, Fsnarf_documentation):
2253 Use int, not EMACS_INT, where int is wide enough.
2254 (get_doc_string):
2255 Use SAFE_ALLOCA, not alloca.
2256 Check for overflow when converting EMACS_INT to off_t.
2257 * doprnt.c (doprnt):
2258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2259 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2260 Don't assume uid_t fits into fixnum.
2261 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2262 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2263 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2264 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2265 (general_insert_function)
2266 (Finsert_char, make_buffer_string, make_buffer_string_both)
2267 (update_buffer_properties, Fbuffer_substring)
2268 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2269 (Fsubst_char_in_region, check_translation)
2270 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2271 (transpose_markers, Ftranspose_regions):
2272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2273 (clip_to_bounds): Move to lisp.h as an inline function).
2274 (Fconstrain_to_field): Don't assume integers are nonnegative.
2275 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2276 (Fsubst_char_in_region, Fsave_restriction):
2277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2278 (Femacs_pid): Don't assume pid_t fits into fixnum.
2279 (lo_time): Use int, not EMACS_INT, when int suffices.
2280 (lisp_time_argument): Check for usec out of range.
2281 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2282 (Fuser_login_name, Fuser_full_name): Signal an error
2283 if a uid argument is out of range, rather than relying on
2284 undefined behavior.
c8d5c857
PE
2285 (Fformat_time_string): Remove now-unnecessary check.
2286 lisp_time_argument checks for out-of-range usec now.
243e0530 2287 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2288 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2289 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2290 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2291 (init_cmdargs, Fdump_emacs):
2292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2293 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2294 the bottom (typically) 32 bits of the fixnum.
2295 * eval.c (specpdl_size, call_debugger):
2296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2297 (when_entered_debugger, Fbacktrace_debug):
2298 Don't assume fixnum can fit in int.
2299 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2300 the object just before a buffer; this is not portable.
2301 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2302 (grow_specpdl, unbind_to):
2303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2304 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2305 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2306 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2307 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2308 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2310 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2311 (a_write, e_write):
2312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2313 (Fcopy_file, non_regular_nbytes, read_non_regular)
2314 (Finsert_file_contents):
2315 Use int, not EMACS_INT, where int is wide enough.
2316 (READ_BUF_SIZE): Verify that it fits in int.
2317 (Finsert_file_contents): Check that counts are in proper range,
2318 rather than assuming fixnums fit into ptrdiff_t etc.
2319 Don't assume fixnums fit into int.
125b3835 2320 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2321 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2322 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2323 (string_char_to_byte, string_byte_to_char)
2324 (string_make_multibyte, string_to_multibyte)
2325 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2326 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2327 (substring_both, Fdelete, internal_equal, Ffillarray)
2328 (Fclear_string, mapcar1)
2329 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2330 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2331 (larger_vector, make_hash_table, maybe_resize_hash_table)
2332 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2333 (Fmaphash, secure_hash):
2334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2335 (concat): Check for string index and length overflow.
2336 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2337 (Frequire):
2338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2339 (larger_vector): New API (vec, incr_min, size_max) replaces old
2340 one (vec, new_size, init). This catches size overflow.
2341 INIT was removed because it was always Qnil.
2342 All callers changed.
2343 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2344 the upper bound on a hash table index size.
2345 (make_hash_table, maybe_resize_hash_table): Use it.
2346 (secure_hash): Computer start_byte and end_byte only after
2347 they're known to be in ptrdiff_t range.
2348 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2349 (Ffont_get_glyphs, Ffont_at):
2350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2351 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2352 (Flist_fonts, Fopen_font):
2353 Don't assume fixnum can fit in int.
2354 (check_gstring): Don't assume index can fit in int.
2355 (font_match_p): Check that fixnum is a character, not a nonnegative
2356 fixnum, since the later code needs to stuff it into an int.
2357 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2358 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2359 conversion overflow issues.
2360 (Fopen_font): Check for integer out of range.
2361 (Ffont_get_glyphs): Don't assume index can fit in int.
2362 * font.h: Adjust decls to match defn changes elsewhere.
2363 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2364 integer overflow.
2365 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2366 printmax_t, where ptrdiff_t is wide enough.
2367 (Finternal_char_font):
2368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2369 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2370 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2371 (Fset_frame_position, x_set_frame_parameters)
2372 (x_set_line_spacing, x_set_border_width)
2373 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2374 Check that fixnums are in proper range for system types.
2375 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2377 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2378 Use SAFE_ALLOCA_LISP, not alloca.
2379 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2380 intptr_t is wide enough.
2381 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2382 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2383 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2384 Check for fixnum out of range.
2385 * ftfont.c (ftfont_list): Don't assume index fits in int.
2386 Check that fixnums are in proper range for system types.
2387 (ftfont_shape_by_flt):
2388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2389 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2391 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2392 Check that fixnums are in proper range for system types.
2393 * gnutls.h: Adjust decls to match defn changes elsewhere.
2394 * gtkutil.c (xg_dialog_run):
2395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2396 (update_frame_tool_bar):
2397 Check that fixnums are in proper range for system types.
2398 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2399 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2400 * indent.c (last_known_column, last_known_column_point):
2401 (current_column_bol_cache):
2402 (skip_invisible, current_column, check_display_width):
2403 (check_display_width, scan_for_column, current_column_1)
2404 (Findent_to, Fcurrent_indentation, position_indentation)
2405 (indented_beyond_p, Fmove_to_column, compute_motion):
2406 (Fcompute_motion, Fvertical_motion):
2407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2408 (last_known_column_modified): Use EMACS_INT, not int.
2409 (check_display_width):
2410 (Fcompute_motion):
2411 Check that fixnums and floats are in proper range for system types.
2412 (compute_motion): Don't assume index or fixnum fits in int.
2413 (compute_motion, Fcompute_motion):
2414 Use int, not EMACS_INT, when it is wide enough.
2415 (vmotion): Omit local var start_hpos that is always 0; that way
2416 we don't need to worry about overflow in expressions involving it.
2417 * indent.h: Adjust decls to match defn changes elsewhere.
2418 (struct position):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2420 Use int, not EMACS_INT, where int is wide enough.
2421 Remove unused members ovstring_chars_done and tab_offset;
2422 all uses removed.
2423 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2424 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2425 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2426 (make_gap, copy_text, insert, insert_and_inherit)
2427 (insert_before_markers, insert_before_markers_and_inherit)
2428 (insert_1, count_combining_before, count_combining_after)
2429 (insert_1_both, insert_from_string)
2430 (insert_from_string_before_markers, insert_from_string_1)
2431 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2432 (adjust_after_replace, adjust_after_insert, replace_range)
2433 (replace_range_2, del_range, del_range_1, del_range_byte)
2434 (del_range_both, del_range_2, modify_region)
2435 (prepare_to_modify_buffer, signal_before_change)
2436 (signal_after_change, Fcombine_after_change_execute):
2437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2438 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2439 (balance_an_interval, split_interval_right, split_interval_left)
2440 (find_interval, next_interval, update_interval)
2441 (adjust_intervals_for_insertion, delete_node, delete_interval)
2442 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2443 (static_offset_intervals, offset_intervals)
2444 (merge_interval_right, merge_interval_left, make_new_interval)
2445 (graft_intervals_into_buffer, temp_set_point_both)
2446 (temp_set_point, set_point, adjust_for_invis_intang)
2447 (set_point_both, move_if_not_intangible, get_property_and_range)
2448 (get_local_map, copy_intervals, copy_intervals_to_string)
2449 (compare_string_intervals, set_intervals_multibyte_1):
2450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2451 * intervals.h: Adjust decls to match defn changes elsewhere.
2452 (struct interval):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2454 * keyboard.c (this_command_key_count, this_single_command_key_start)
2455 (before_command_key_count, before_command_echo_length, echo_now)
2456 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2457 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2458 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2459 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2460 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2461 (last_non_minibuf_size, last_point_position, echo_truncate)
2462 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2463 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2464 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2465 (stuff_buffered_input):
2466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2467 (last_auto_save, command_loop_1, read_char):
2468 Use EMACS_INT, not int, to avoid integer overflow.
2469 (record_char): Avoid overflow in total_keys computation.
2470 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2471 * keyboard.h: Adjust decls to match defn changes elsewhere.
2472 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2473 (Fkey_description, Fdescribe_vector, Flookup_key):
2474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2475 (click_position): New function, to check that positions are in range.
2476 (Fcurrent_active_maps):
2477 (describe_command):
2478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2479 (Faccessible_keymaps, Fkey_description):
2480 (preferred_sequence_p):
2481 Don't assume fixnum can fit into int.
2482 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2483 Check for integer overflow in size calculations.
2484 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2485 avoid mishandling large integers.
2486 * lisp.h: Adjust decls to match defn changes elsewhere.
2487 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2488 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2489 (struct Lisp_Marker):
2490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2491 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2492 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2493 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2494 All callers changed.
2495 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2496 Assume the arg has valid form, since it always does.
2497 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2498 unsigned integer system type.
2499 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2500 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2502 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2503 (duration_to_sec_usec): New decl.
2504 * lread.c (read_from_string_index, read_from_string_index_byte)
2505 (read_from_string_limit, readchar, unreadchar, openp)
2506 (read_internal_start, read1, oblookup):
2507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2508 (Fload, readevalloop, Feval_buffer, Feval_region):
2509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2510 (openp): Check for out-of-range argument to 'access'.
2511 (read1): Use int, not EMACS_INT, where int is wide enough.
2512 Don't assume fixnum fits into int.
6efdadfd 2513 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2514 (read_filtered_event): Use duration_to_sec_usec
2515 to do proper overflow checking on durations.
d311d28c
PE
2516 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2517 in size calculation.
2518 (Fexecute_kbd_macro):
2519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2520 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2521 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2522 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2523 (set_marker_both, set_marker_restricted_both, marker_position)
2524 (marker_byte_position, Fbuffer_has_markers_at):
2525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2526 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2527 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2528 It now merely ensures that the menu is large enough, without
2529 necessarily growing it, as this avoids some integer overflow issues.
2530 All callers changed.
2531 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2533 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2534 Use SAFE_ALLOCA_LISP, not alloca.
2535 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2536 to EMACS_INT. Check that fixnums are in proper range for system types.
2537 * minibuf.c (minibuf_prompt_width, string_to_object)
2538 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2539 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2541 (get_minibuffer, read_minibuf_unwind):
2542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2543 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2544 this simplifies overflow checking. All callers changed.
2545 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2546 (Ftest_completion):
2547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2548 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2549 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2550 Check that fixnums are in proper range for system types.
2551 (Fx_create_frame, Fx_show_tip):
2552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2553 * nsfont.m (ns_findfonts, nsfont_list_family):
2554 Don't assume fixnum fits in long.
2555 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2557 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2558 wide enough.
17fdb222 2559 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2560 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2561 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2562 (PRINTDECLARE, PRINTPREPARE):
2563 (strout, print_string):
2564 (print, print_preprocess, print_check_string_charset_prop)
2565 (print_object):
2566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2567 (PRINTDECLARE):
2568 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2570 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2571 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2572 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2573 (print_error_message): Use SAFE_ALLOCA, not alloca.
2574 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2575 (print_depth, new_backquote_output, print_number_index):
2576 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2577 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2578 (Fset_process_window_size, Fformat_network_address)
2579 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2580 (sigchld_handler):
d311d28c 2581 Check that fixnums are in proper range for system types.
d44287d4 2582 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2583 Check for process-ids out of pid_t range rather than relying on
2584 undefined behavior.
e4d81efc 2585 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2586 (Fformat_network_address, read_process_output, send_process)
2587 (Fprocess_send_region, status_notify):
2588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2589 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2590 (wait_reading_process_output, read_process_output, exec_sentinel):
2591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2592 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2593 (Faccept_process_output): Use duration_to_sec_usec to do proper
2594 overflow checking on durations.
dde14581
PE
2595 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2596 Don't assume pid_t fits in int.
02481186
PE
2597 * process.h (struct Lisp_Process): Members tick and update_tick
2598 are now of type EMACS_INT, not int.
b62b53e8
PE
2599 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2600 configured --with-wide-int.
d311d28c
PE
2601 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2602 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2603 * search.c (looking_at_1, string_match_1):
2604 (fast_string_match, fast_c_string_match_ignore_case)
2605 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2606 (scan_newline, find_before_next_newline, search_command)
2607 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2608 (set_search_regs, wordify):
2609 (Freplace_match):
2610 (Fmatch_data):
2611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2612 (string_match_1, search_buffer, set_search_regs):
2613 (Fmatch_data):
2614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2615 (wordify): Check for overflow in size calculation.
2616 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2617 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2618 Check that fixnums are in proper range for system types.
2619 * sound.c (struct sound_device)
2620 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2622 (Fplay_sound_internal):
2623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2624 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2625 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2626 (Fparse_partial_sexp):
2627 Don't assume fixnums can fit in int.
2628 (struct lisp_parse_state, find_start_pos, find_start_value)
2629 (find_start_value_byte, find_start_begv)
2630 (update_syntax_table, char_quoted, dec_bytepos)
2631 (find_defun_start, prev_char_comend_first, back_comment):
2632 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2633 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2635 (Finternal_describe_syntax_value): Check that match_lisp is a
2636 character, not an integer, since the code stuffs it into int.
2637 (scan_words, scan_sexps_forward):
2638 Check that fixnums are in proper range for system types.
2639 (Fforward_word):
2640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2641 (scan_sexps_forward):
2642 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2643 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2644 * syntax.h: Adjust decls to match defn changes elsewhere.
2645 (struct gl_state_s):
2646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2647 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2648 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2649 * sysdep.c (wait_for_termination_1, wait_for_termination)
2650 (interruptible_wait_for_termination, mkdir):
2651 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2652 (emacs_read, emacs_write):
2653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2654 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2655 and double all fit in int.
d311d28c
PE
2656 * term.c (set_tty_color_mode):
2657 Check that fixnums are in proper range for system types.
2658 * termhooks.h (struct input_event):
2659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2660 * textprop.c (validate_interval_range, interval_of)
2661 (Fadd_text_properties, set_text_properties_1)
2662 (Fremove_text_properties, Fremove_list_of_text_properties)
2663 (Ftext_property_any, Ftext_property_not_all)
2664 (copy_text_properties, text_property_list, extend_property_ranges)
2665 (verify_interval_modification):
2666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2667 (Fnext_single_char_property_change)
2668 (Fprevious_single_char_property_change):
2669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2670 (copy_text_properties):
2671 Check for integer overflow in index calculation.
d311d28c
PE
2672 * undo.c (last_boundary_position, record_point, record_insert)
2673 (record_delete, record_marker_adjustment, record_change)
2674 (record_property_change):
2675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2676 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2678 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2679 (Fx_hide_tip, Fx_file_dialog):
2680 * w32menu.c (set_frame_menubar):
2681 Use ptrdiff_t, not int, for consistency with rest of code.
2682 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2683 (select_window, Fdelete_other_windows_internal)
2684 (window_scroll_pixel_based, window_scroll_line_based)
2685 (Frecenter, Fset_window_configuration):
2686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2687 (Fset_window_hscroll, run_window_configuration_change_hook)
2688 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2689 (Fscroll_other_window, Frecenter):
d311d28c
PE
2690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2691 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2692 Don't assume fixnum fits in int.
2693 (Fset_window_scroll_bars):
2694 Check that fixnums are in proper range for system types.
2695 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2696 (string_pos, c_string_pos, number_of_chars, init_iterator)
2697 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2698 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2699 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2700 (face_before_or_after_it_pos, handle_invisible_prop)
2701 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2702 (display_prop_intangible_p, string_buffer_position_lim)
2703 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2704 (get_overlay_strings_1, get_overlay_strings)
2705 (iterate_out_of_display_property, forward_to_next_line_start)
2706 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2707 (get_next_display_element, set_iterator_to_next)
2708 (get_visually_first_element, compute_stop_pos_backwards)
2709 (handle_stop_backwards, next_element_from_buffer)
2710 (move_it_in_display_line_to, move_it_in_display_line)
2711 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2712 (add_to_log, message_dolog, message_log_check_duplicate)
2713 (message2, message2_nolog, message3, message3_nolog
2714 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2715 (current_message_1, truncate_echo_area, truncate_message_1)
2716 (set_message, set_message_1, store_mode_line_noprop)
2717 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2718 (text_outside_line_unchanged_p, check_point_in_composition)
2719 (reconsider_clip_changes)
2720 (redisplay_internal, set_cursor_from_row, try_scrolling)
2721 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2722 (redisplay_window, find_last_unchanged_at_beg_row)
2723 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2724 (trailing_whitespace_p, find_row_edges, display_line)
2725 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2726 (display_mode_element, store_mode_line_string)
2727 (pint2str, pint2hrstr, decode_mode_spec)
2728 (display_count_lines, display_string, draw_glyphs)
2729 (x_produce_glyphs, x_insert_glyphs)
2730 (rows_from_pos_range, mouse_face_from_buffer_pos)
2731 (fast_find_string_pos, mouse_face_from_string_pos)
2732 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2734 (safe_call, init_from_display_pos, handle_fontified_prop)
2735 (handle_single_display_spec, load_overlay_strings)
2736 (with_echo_area_buffer, setup_echo_area_for_printing)
2737 (display_echo_area, echo_area_display)
2738 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2739 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2740 (redisplay_window, dump_glyph_row, display_mode_line)
2741 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2742 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2744 (handle_single_display_spec, build_desired_tool_bar_string)
2745 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2746 (get_specified_cursor_type):
2747 Check that fixnums are in proper range for system types.
2748 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2749 (Flookup_image_map):
2750 Don't assume fixnums fit in int.
2751 (compare_overlay_entries):
2752 Avoid mishandling comparisons due to subtraction overflow.
2753 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2754 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2755 (handle_tool_bar_click):
2756 Use int, not unsigned, since we prefer signed and the signedness
2757 doesn't matter here.
2758 (get_next_display_element, next_element_from_display_vector):
2759 Use int, not EMACS_INT, when int is wide enough.
2760 (start_hourglass): Use duration_to_sec_usec to do proper
2761 overflow checking on durations.
2762 * xfaces.c (Fbitmap_spec_p):
2763 Check that fixnums are in proper range for system types.
2764 (compare_fonts_by_sort_order):
2765 Avoid mishandling comparisons due to subtraction overflow.
2766 (Fx_family_fonts, realize_basic_faces):
2767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2768 (Fx_family_fonts):
2769 Don't assume fixnum fits in int.
2770 Use SAFE_ALLOCA_LISP, not alloca.
2771 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2772 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2773 (face_at_buffer_position, face_for_overlay_string)
2774 (face_at_string_position):
2775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2776 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2777 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2778 (Fx_show_tip):
2779 Check that fixnums are in proper range for system types.
2780 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2781 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2783 (Fx_change_window_property): Don't assume fixnums fit in int.
2784 * xfont.c (xfont_chars_supported):
2785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2786 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2787 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2789 * xml.c (parse_region):
2790 * xrdb.c (magic_file_p):
2791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2792 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2793 (x_get_local_selection, x_reply_selection_request)
2794 (x_handle_selection_request, wait_for_property_change):
2795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2796 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2797 short is wide enough.
2798 (x_send_client_event): Don't assume fixnum fits in int.
2799 * xterm.c (x_x_to_emacs_modifiers):
2800 Don't assume EMACS_INT overflows nicely into int.
2801 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2802 may come from Lisp.
2803 (handle_one_xevent): NATNUMP can eval its arg twice.
2804 (x_connection_closed):
2805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2806 * xterm.h: Adjust decls to match defn changes elsewhere.
2807 (struct scroll_bar): Use struct vectorlike_header
2808 rather than rolling our own approximation.
2809 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2810
c6574eb5
GM
28112012-05-25 Glenn Morris <rgm@gnu.org>
2812
2813 * lisp.mk (lisp): Update for more files being compiled now.
2814
e8d32c7e
SM
28152012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2816
48def666
SM
2817 * lread.c: Remove `read_pure' which makes no difference.
2818 (read_pure): Remove var.
2819 (unreadpure): Remove function.
2820 (readevalloop): Don't call read_list with -1 flag.
2821 (read1, read_vector): Don't test read_pure any more.
2822 (read_list): Simplify.
2823
e8d32c7e
SM
2824 * fileio.c, character.h: Minor style tweaks.
2825
4b2addb7
DA
28262012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2827
2828 * window.h (clip_changed): Remove useless declaration.
2829
584461b2
JB
28302012-05-22 Juanma Barranquero <lekktu@gmail.com>
2831
2832 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2833 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2834
34374650
PE
28352012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 Remove src/m/*.
2838 This directory predates autoconf and is no longer needed nowadays.
2839 Move its few remaining bits of functionality to where they're needed.
2840 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2841 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2842 * m/template.h: Remove.
2843 * Makefile.in (M_FILE): Remove. All uses removed.
2844 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2845 * lisp.h (USE_LSB_TAG):
2846 * mem-limits.h (EXCEEDS_LISP_PTR):
2847 Use VAL_MAX, not VALBITS, in #if.
2848 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2849 (EMACS_UINT): Define unconditionally now.
2850 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2851 (BITS_PER_EMACS_INT): New constants, replacing
2852 what used to be in config.h, but not useful in #if.
2853 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2854 define them any more.
2855 (VAL_MAX): New macro.
2856 (VALMASK): Use it.
2857 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2858 BITS_PER_EMACS_INT, in #if.
2859 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2860 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2861 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2862 * s/ms-w32.h (DATA_START):
2863 Move here from removed file m/intel386.h.
2864 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2865 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2866
261cb4bb
PE
28672012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2868
2869 Assume C89 or later.
2870 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2871 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2872 (xrealloc):
2873 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2874 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2875 * textprop.c, tparam.c (NULL): Remove.
2876 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2877 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2878 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2879 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2880 * xterm.c (input_signal_count): Assume volatile works.
2881
ff23cd9f
KB
28822012-05-21 Ken Brown <kbrown@cornell.edu>
2883
2884 * xgselect.c (xg_select): Fix first argument in call to 'select'
2885 (bug#11508).
2886
1b170bc6
KB
28872012-05-20 Ken Brown <kbrown@cornell.edu>
2888
2889 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2890 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2891
b2f4d39f
KB
28922012-05-19 Ken Brown <kbrown@cornell.edu>
2893
2894 * xfns.c (x_in_use): Remove `static' qualifier.
2895 * xterm.h (x_in_use): Declare.
2896 * xgselect.c: Include xterm.h.
2897 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2898 and `display_arg' (bug#9754).
2899
003fdae2
PE
29002012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2901
9232a6d9
PE
2902 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2903
003fdae2
PE
2904 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2905 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2906
784b56e2
EZ
29072012-05-18 Eli Zaretskii <eliz@gnu.org>
2908
2909 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2910
2911 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 2912 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
2913
2914 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2915 reference to image_cache->refcount.
2916 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2917
a0a79cde
JL
29182012-05-17 Juri Linkov <juri@jurta.org>
2919
2920 * search.c (Fword_search_regexp, Fword_search_backward)
2921 (Fword_search_forward, Fword_search_backward_lax)
2922 (Fword_search_forward_lax): Move functions to isearch.el
2923 (bug#10145, bug#11381).
2924
b0572523
PE
29252012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2926
2927 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2928
9660f5fc
SM
29292012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2930
2931 * lread.c (init_obarray): Declare Qt and Qnil as special.
2932
4374de83
GM
29332012-05-14 Glenn Morris <rgm@gnu.org>
2934
2935 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2936 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2937
dc44c39a
PE
29382012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2939
078c97cb
PE
2940 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2941
dc44c39a
PE
2942 * unexaix.c: Port to more-recent AIX compilers.
2943 (report_error, report_error_1, make_hdr, copy_sym)
2944 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2945 Make arguments const char *, not char *, to avoid violations of C
2946 standard and to fix some AIX warnings reported by Gilles Pion.
2947
e18afed7 29482012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2949
2950 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2951 already have overlays loaded.
2952 (handle_single_display_spec): Before returning without displaying
2953 fringe bitmap, synchronize the bidi iterator with the main display
2954 iterator, by calling iterate_out_of_display_property.
2955 (iterate_out_of_display_property): Detect buffer iteration by
2956 testing that it->string is a Lisp string.
2957 (get_next_display_element): When the current object is exhausted,
2958 and there's something on it->stack, call set_iterator_to_next to
2959 proceed with what's on the stack, instead of returning zero.
2960 (set_iterator_to_next): If called at the end of a Lisp string,
2961 proceed to consider_string_end without incrementing string
2962 position. Don't increment display vector index past the end of
2963 the display vector. (Bug#11417)
c8fb9dc6
EZ
2964 (pos_visible_p): Don't report a position visible when move_it_to
2965 stopped at the last line of window, which happens to be scanned
2966 backwards by the bidi iteration. (Bug#11464)
ac268e67 2967
e18afed7 29682012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2969
2970 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2971 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2972 are on a TTY, and thus unable to display on the fringes.
2973 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2974 so we need to signal to the caller that this is a "replacing"
2975 display spec. This fixes display when the spec is invalid or we
2976 are on a TTY.
2977
e18afed7 29782012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2979
2980 * unexaix.c (make_hdr): Fix typo in prototype.
2981 This bug broke the build on AIX. Problem reported by Gilles Pion.
2982
9d0a235a
MA
29832012-05-14 Michael Albinus <michael.albinus@gmx.de>
2984
2985 * keyboard.c (kbd_buffer_get_event): Read special events also in
2986 batch mode. (Bug#11415)
2987
9e6b06ed
GM
29882012-05-12 Glenn Morris <rgm@gnu.org>
2989
2990 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2991
c1a1d7a3
EZ
29922012-05-12 Eli Zaretskii <eliz@gnu.org>
2993
2994 * lisp.mk (lisp): Add newcomment.elc.
2995
3fe7cdc8
GM
29962012-05-12 Glenn Morris <rgm@gnu.org>
2997
2998 * Makefile.in (MKDIR_P): New, set by configure.
2999 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3000
53f7d2c0
PE
30012012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 Remove unused function hourglass_started.
3004 * dispextern.h (hourglass_started):
3005 * w32fns.c (hourglass_started):
3006 * xdisp.c (hourglass_started): Remove.
3007
75aafb17
JB
30082012-05-10 Juanma Barranquero <lekktu@gmail.com>
3009
3010 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3011 Update dependencies.
3012
12959e8e
PE
30132012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3014
97107e2e
PE
3015 * xgselect.c (xg_select): Put maxfds+1 into a var.
3016 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3017
12959e8e
PE
3018 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3019
836d29b3
DA
30202012-05-10 Dave Abrahams <dave@boostpro.com>
3021
3022 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3023 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3024
5cb67954
MA
30252012-05-09 Michael Albinus <michael.albinus@gmx.de>
3026
3027 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3028 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3029 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3030 Initialize xd_registered_buses.
3031
3478ec45
PE
30322012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3033
b263a6b0
PE
3034 Untag more efficiently if USE_LSB_TAG.
3035 This is based on a proposal by YAMAMOTO Mitsuharu in
3036 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3037 For an admittedly artificial (nth 8000 longlist) benchmark on
3038 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3039 Emacs's overall text size by 1%.
3040 * lisp.h (XUNTAG): New macro.
3041 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3042 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3043 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3044 * eval.c (Fautoload):
3045 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3046 * frame.h (XFRAME): Use XUNTAG.
3047
3478ec45
PE
3048 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3049 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3050 Remove unportable assumptions about print widths of types like
3051 dbus_uint32_t.
3052 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3053 intptr_t when converting between pointer and integer, to avoid GCC
3054 warnings about wrong width.
3055
666b903b 30562012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3057
3058 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3059 stack for each reader_thread, instead of defaulting to 8MB
3060 determined by the linker. This avoids failures in creating
3061 subprocesses on Windows 7, see the discussion in this thread:
3062 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3063
b120cc17
JC
30642012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3065
3066 Fix up display of the *Minibuf-0* buffer in the mini window.
3067 * keyboard.c (read_char): Don't clear the echo area if there's no
3068 message to clear.
3069 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3070 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3071
9a4b36f8
MA
30722012-05-07 Michael Albinus <michael.albinus@gmx.de>
3073
3074 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3075 batch mode.
3076
e5f9458f
CY
30772012-05-06 Chong Yidong <cyd@gnu.org>
3078
3079 * lisp.mk (lisp): Update.
3080
eceeb5fc 30812012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3082
3083 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3084
71873e2b
SM
30852012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3086
3087 * data.c (PUT_ERROR): New macro.
3088 (syms_of_data): Use it. Add new error type `user-error'.
3089 * undo.c (user_error): New function.
3090 (Fprimitive_undo): Use it.
3091 * print.c (print_error_message): Adjust print style for `user-error'.
3092 * keyboard.c (user_error): New function.
3093 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3094
ab0fa4e4
PE
30952012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3096
3097 Do not limit current-time-string to years 1000..9999.
3098 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3099 (Fcurrent_time_string): Support any year that is supported by the
3100 underlying localtime representation. Don't use asctime, as it
3101 has undefined behavior for years outside the range -999..9999.
3102
7ed806a7
PE
31032012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 Fix race conditions involving setenv, gmtime, localtime, asctime.
3106 Without this fix, interrupts could mess up code that uses these
3107 nonreentrant functions, since setting TZ invalidates existing
3108 tm_zone or tzname values, and since most of these functions return
3109 pointers to static storage.
3110 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3111 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3112 Grow the critical sections to include not just invoking
3113 localtime/gmtime, but also accessing these functions' results
3114 including their tm_zone values if any, and any related TZ setting.
3115 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3116 so that the struct tm is saved in the critical section.
3117 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3118 motivated by the fact that memory allocation needs to be outside
3119 the critical section.
3120
0c16dfed
DA
31212012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3122
3123 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3124 with RESET_INTERVAL.
3125
3126 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3127 Remove duplicated buffer name initialization.
3128
3f83ace8
JM
31292012-05-02 Jim Meyering <jim@meyering.net>
3130
3131 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3132
c7b8541e
JM
3133 * xfns.c (x_window): Use xstrdup (Bug#11375).
3134
90207a15 31352012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3136
3137 * xdisp.c (pos_visible_p): If already at a newline from the
3138 display string before the 'while' loop, don't walk back the glyphs
3139 from it3.glyph_row. Solves assertion violation when the display
3140 string begins with a newline (egg.el). (Bug#11367)
3141
b593d6a9
AH
31422012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3143
3144 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3145 Move to simple.el.
3146
4737362e
GM
31472012-05-01 Glenn Morris <rgm@gnu.org>
3148
99cf43f9
GM
3149 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3150 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3151 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3152 All were removed before 23.1.
3153
9311dcff
GM
3154 * dispnew.c: Remove HAVE_LIBNCURSES test;
3155 it is always true on relevant platforms.
3156
4d5c6349
GM
3157 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3158 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3159
4737362e
GM
3160 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3161
74dd3a6b
AS
31622012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3163
3164 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3165 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3166 Remove.
3167
13c379ee
PE
31682012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3169
3170 Do not avoid creating empty evaporating overlays (Bug#9642).
3171 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3172 That is, do not delete an evaporating overlay if it becomes
3173 empty after its bounds are adjusted to fit within its buffer.
3174 This fix caused other problems, and I'm reverting it until we get
3175 to the bottom of them.
3176
a8e7d6d7 31772012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3178
3179 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3180
a8e7d6d7 31812012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3182
3183 * xdisp.c (pos_visible_p): If the window start position is beyond
3184 ZV, start the display from buffer beginning. Prevents assertion
3185 violation in init_iterator when the minibuffer window is scrolled
3186 via the scroll bar.
3187
3188 * window.c (window_scroll_pixel_based): Likewise.
3189
a8e7d6d7 31902012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3191
3192 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3193
a8e7d6d7 31942012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3195
3196 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3197 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3198
a8e7d6d7 31992012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3200
b593d6a9
AH
3201 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3202 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3203
1c6900d9
EZ
32042012-04-26 Eli Zaretskii <eliz@gnu.org>
3205
4c3fa1d9
EZ
3206 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3207 display element, check also the underlying string or buffer
3208 character. (Bug#11341)
3209
1c6900d9
EZ
3210 * w32menu.c: Include w32heap.h.
3211 (add_menu_item): If the call to AppendMenuW (via
3212 unicode_append_menu) fails, disable Unicode menus only if we are
3213 running on Windows 9X/Me.
3214
42bf8205
AS
32152012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3216
3217 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3218 (xgetint): Add missing shift for LSB tags.
3219
b1bac16e
MR
32202012-04-24 Martin Rudalics <rudalics@gmx.at>
3221
3222 * keyboard.c (read_char): Don't wipe echo area for select window
3223 events: These might get delayed via `mouse-autoselect-window'
3224 (Bug#11304).
3225
d69621cc
JB
32262012-04-24 Juanma Barranquero <lekktu@gmail.com>
3227
3228 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3229 manipulation of :loaded-from data.
3230
02fd101b
JB
32312012-04-23 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3234 now a cons (bug#11311).
3235
888bec30
PE
32362012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3237
89a438bd
PE
3238 Do not create empty overlays with the evaporate property (Bug#9642).
3239 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3240 if it becomes empty after its bounds are adjusted to fit within
3241 its buffer. Without this fix, in a nonempty buffer (let ((o
3242 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3243 yields an empty overlay that has the evaporate property, which is
3244 not supposed to happen.
3245
1068fe4d
PE
3246 Fix minor GTK3 problems found by static checking.
3247 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3248 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3249 (struct _EmacsFixedClass, emacs_fixed_get_type):
3250 Move decls here from emacsgtkfixed.h, since they needn't be public.
3251 (emacs_fixed_get_type): Now static.
3252 (emacs_fixed_class_init): Omit unused local.
3253 (emacs_fixed_child_type): Remove; unused.
3254 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3255 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3256 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3257 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3258 (EMACS_FIXED_GET_CLASS): Remove; unused.
3259 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3260
888bec30
PE
3261 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3262 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3263
de85e130
PE
32642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3265
d0baac98 3266 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3267 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3268 (__malloc_size_t, __malloc_ptrdiff_t):
3269 Remove. All uses removed, replaced by the definiens if needed,
3270 since we can assume C89 or better now.
3271 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3272 (protect_malloc_state, align, get_contiguous_space)
3273 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3274 (malloc_atfork_handler_child, malloc_enable_thread)
3275 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3276 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3277 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3278 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3279 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3280 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3281 Define using prototypes, not old style.
3282 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3283 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3284 (align): Don't assume that signed integer overflow wraps around.
3285 Omit unused local var.
3286 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3287 (_free_internal_nolock, memalign, mallochook, reallochook):
3288 Omit no-longer-needed casts.
3289 (valloc): Use getpagesize, not __getpagesize.
3290 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3291 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3292
de85e130
PE
3293 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3294
dcbf5805
MA
32952012-04-22 Michael Albinus <michael.albinus@gmx.de>
3296
3297 Move functions from C to Lisp. Make non-blocking method calls
3298 the default. Implement further D-Bus standard interfaces.
3299
3300 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3301 (QCdbus_request_name_allow_replacement)
3302 (QCdbus_request_name_replace_existing)
3303 (QCdbus_request_name_do_not_queue)
3304 (QCdbus_request_name_reply_primary_owner)
3305 (QCdbus_request_name_reply_in_queue)
3306 (QCdbus_request_name_reply_exists)
3307 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3308 (QCdbus_registered_serial, QCdbus_registered_method)
3309 (QCdbus_registered_signal): New Lisp objects.
3310 (XD_DEBUG_MESSAGE): Use sizeof.
3311 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3312 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3313 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3314 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3315 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3316 (xd_signature, xd_append_arg): Allow float for integer types.
3317 (xd_get_connection_references): New function.
b593d6a9
AH
3318 (xd_get_connection_address): Rename from xd_initialize.
3319 Return cached address.
dcbf5805
MA
3320 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3321 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3322 level.
3323 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3324 Return number of refcounts.
dcbf5805
MA
3325 (Fdbus_get_unique_name): Make stronger parameter check.
3326 (Fdbus_message_internal): New defun.
3327 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3328 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3329 (Fdbus_send_signal, Fdbus_register_service)
3330 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3331 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3332 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3333 (Vdbus_compiled_version, Vdbus_runtime_version)
3334 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3335 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3336 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3337 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3338 Adapt docstring.
dcbf5805 3339
52828e02
PE
33402012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3341
da05bc4c
PE
3342 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3343 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3344 Do not assume ptrdiff_t is the same width as 'int'.
3345
52828e02
PE
3346 * alloc.c: Handle unusual debugging option combinations.
3347 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3348 since the two debugging options are incompatible.
3349 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3350 is defined.
3351 (mem_init, mem_insert, mem_insert_fixup):
3352 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3353 (NEED_MEM_INSERT): Remove; no longer needed.
3354
f01769f9
LL
33552012-04-22 Leo Liu <sdl.web@gmail.com>
3356
3357 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3358
5790543d
PE
33592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * sysdep.c [__FreeBSD__]: Minor cleanups.
3362 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3363 Use Emacs indenting style more consistently. Avoid some casts.
3364 Use 'double' consistently rather than mixing 'float' and 'double'.
3365
b91b7e4d
EW
33662012-04-21 Eduard Wiebe <usenet@pusto.de>
3367
b593d6a9
AH
3368 * sysdep.c (list_system_processes, system_process_attributes):
3369 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3370
6114eb15
AS
33712012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3372
3373 * lisp.mk (lisp): Update.
3374
2f38dff7
PE
33752012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3378 It is never used otherwise.
3379
4ae29f89
SM
33802012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3381
3382 * print.c (print_preprocess): Only check print_depth if print-circle
3383 is nil.
3384 (print_object): Check for cycles even when print-circle is nil and
3385 print-gensym is t, but only check print_depth if print-circle is nil.
3386
f30d612a
CY
33872012-04-20 Chong Yidong <cyd@gnu.org>
3388
3389 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3390 set the status to "failed" and ensure that sentinel is run.
3391
c07a4c0b 33922012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3393
3394 * process.c (Fset_process_inherit_coding_system_flag)
3395 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3396 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3397
c07a4c0b 33982012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3399
3400 * xdisp.c (string_buffer_position_lim): Limit starting position to
3401 BEGV.
3402 (set_cursor_from_row): If called for a mode-line or header-line
3403 row, return zero immediately.
3404 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3405 farther than the first row after the header line, if any.
3406 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3407 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3408
c07a4c0b 34092012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3410
4ae29f89
SM
3411 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3412 (bug#11238).
ad3a2b41 3413
c07a4c0b 34142012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 34152012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3416
3417 configure: new option --enable-gcc-warnings (Bug#11207)
3418 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3419 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3420 (ALL_CFLAGS): Use new macros rather than old.
3421 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3422 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3423 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3424 -Wunused-result, -Wunused-variable. This should go away once
3425 the Emacs and Gnulib regex code is merged.
3426 (xmalloc, xrealloc): Now static.
3427
aba027e8
PE
34282012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3429
3430 * dired.c (Fsystem_groups): Remove unused local.
3431
e5a36063
GM
34322012-04-17 Glenn Morris <rgm@gnu.org>
3433
3434 * dired.c (Fsystem_users): Doc fix.
3435
316411f0
DA
34362012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3437
3438 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3439 (syms_of_dired): Add them.
3440
9426aba4
PE
34412012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3442
b62a57be
PE
3443 Fix minor alloc.c problems found by static checking.
3444 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3445 New extern decls, to avoid calling undeclared functions.
3446 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3447 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3448 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3449 (NEED_MEM_INSERT): New macro.
3450 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3451 Remove one incorrect comment and fix another.
b62a57be 3452
3539f31f
PE
3453 Fix minor ralloc.c problems found by static checking.
3454 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3455 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3456 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3457 (r_alloc_sbrk): Now static.
3458
a041960a
PE
3459 Improve ralloc.c interface checking.
3460 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3461 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3462 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3463 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3464 [REL_ALLOC]: ... to here, to check interface.
3465 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3466 Remove decls. This fixes an "It stinks!".
3467
9426aba4
PE
3468 * alloc.c (which_symbols): Fix alignment issue / type clash.
3469
d55c12ed
AS
34702012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3471
3472 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3473 (struct Lisp_Misc_Any): Likewise.
3474 (struct Lisp_Free): Likewise.
3475 * alloc.c (union aligned_Lisp_Symbol): Define.
3476 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3477 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3478 (union aligned_Lisp_Misc): Define.
3479 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3480 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3481 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3482
b948ce8b
PE
34832012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3484
3485 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3486 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3487 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3488 * s/netbsd.h, s/sol2-6.h:
3489 Remove definition of GC_MARK_STACK, since the default now works.
3490 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3491 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3492 no longer the default.
3493 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3494
35dc09a1 34952012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3496
35dc09a1
GM
3497 * lread.c (lisp_file_lexically_bound_p):
3498 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3499
35dc09a1
GM
35002012-04-14 Eli Zaretskii <eliz@gnu.org>
3501
3502 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3503 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3504
35052012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3506
3507 * nsterm.m (constrainFrameRect): Always constrain when there is only
3508 one screen (Bug#10962).
3509
bcd86815
KB
35102012-04-13 Ken Brown <kbrown@cornell.edu>
3511
3512 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3513
c25df26e
RT
35142012-04-13 Reuben Thomas <rrt@sc3d.org>
3515
3516 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3517
0fc59f1e
DC
35182012-04-11 Daniel Colascione <dancol@dancol.org>
3519
3520 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3521 against is gone. It's better to use vfork now so that when Cygwin
3522 gains a new, working vfork, we use it automatically (bug#10398).
3523
de8c03dc
SM
35242012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3525
3526 * window.c (save_window_save): Obey window-point-insertion-type.
3527
2f097256
GM
35282012-04-11 Glenn Morris <rgm@gnu.org>
3529
3530 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3531
453b951e
SM
35322012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3533
3534 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3535
75f1671a 35362012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3537
3538 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3539 (force_quit_count): New var.
3540 (handle_interrupt): Use it.
3541
2a8ce227
JB
35422012-04-10 Juanma Barranquero <lekktu@gmail.com>
3543
3544 * w32.c (w32_delayed_load): Record the full path of the library
3545 being loaded (bug#10424).
3546
935396c0
GM
35472012-04-09 Glenn Morris <rgm@gnu.org>
3548
05920a43
GM
3549 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3550 not just in the obarray, before snarfing them. (Bug#11036)
3551
935396c0
GM
3552 * Makefile.in ($(leimdir)/leim-list.el):
3553 Pass EMACS rather than BUILT_EMACS.
3554
a18ecafa
TZ
35552012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3556
3557 * process.c (make_process):
3558 * process.h: Add integer `gnutls_handshakes_tried' member to
3559 process struct.
3560
6bbef4e5
JC
3561 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3562 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3563
3564 * gnutls.c (gnutls_log_function2i): Convenience log function.
3565 (emacs_gnutls_read): Use new log functions,
3566 `gnutls_handshakes_tried' process member, and
3567 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3568 attempts per process (connection).
3569
b4d3bc10
CY
35702012-04-09 Chong Yidong <cyd@gnu.org>
3571
3572 * eval.c (Fuser_variable_p, user_variable_p_eh)
3573 (lisp_indirect_variable): Functions deleted.
3574 (Fdefvar): Caller changed.
3575
3576 * callint.c (Finteractive, Fcall_interactively):
3577 * minibuf.c (Fread_variable): Callers changed.
3578
70f4d973
EZ
35792012-04-09 Eli Zaretskii <eliz@gnu.org>
3580
3581 * xdisp.c (set_cursor_from_row): If the display string appears in
3582 the buffer at position that is closer to point than the position
3583 after the display string, display the cursor on the first glyph of
3584 the display string. Fixes cursor display when a 'display' text
3585 property immediately follows invisible text. (Bug#11094)
3586
cb3c2e3e
PE
35872012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 composite.c: use 'double' consistently
3590 * composite.c (get_composition_id): Use 'double' consistently
3591 instead of converting 'float' to 'double' and vice versa; this is
3592 easier to understand and avoids a GCC warning.
3593
fd06db5d
GM
35942012-04-09 Glenn Morris <rgm@gnu.org>
3595
50fe702a
GM
3596 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3597 preparation for dumping it with emacs. (Bug#4789)
3598 (leimdir): New variable.
3599 ($(leimdir)/leim-list.el): New rule.
3600 (emacs$(EXEEXT)): Depend on leim-list.el.
3601
fd06db5d
GM
3602 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3603 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3604 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3605
55c131ee
AS
36062012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3607
3608 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3609 proper alignment.
3610
9209588f
JB
36112012-04-07 Juanma Barranquero <lekktu@gmail.com>
3612
3613 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3614 Remove unused local variable.
3615
e3fb2efb
PE
36162012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3619 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3620 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3621 objects, as mark_maybe_pointer will catch them otherwise.
3622 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3623 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3624
b5385551
PE
36252012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3626
3627 Fix typo that broke non-Windows builds.
3628 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3629
9078ead6
EZ
36302012-04-07 Eli Zaretskii <eliz@gnu.org>
3631
3632 Support building on MS-Windows with libxml2.
3633
3634 * makefile.w32-in (OBJ2): Add xml.$(O).
3635 (GLOBAL_SOURCES): Add xml.c.
3636 ($(BLD)/xml.$(O)): New dependency list.
3637
3638 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3639 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3640 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3641 [!WINDOWSNT]: New macros.
3642 (init_libxml2_functions, libxml2_loaded_p): New functions.
3643 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3644 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3645 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3646 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3647 linked in).
6bbef4e5
JC
3648 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3649 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3650 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3651
3652 * emacs.c: Don't include libxml/parser.h.
3653 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3654 xmlCleanupParser directly.
3655
3656 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3657
3811fdf3
EZ
36582012-04-07 Eli Zaretskii <eliz@gnu.org>
3659
3660 * indent.c (Fvertical_motion): If there is a display string at
3661 point, use it.vpos to compute how many lines to backtrack after
3662 move_it_to point. (Bug#11133)
3663
2f8e16b2
EZ
36642012-04-06 Eli Zaretskii <eliz@gnu.org>
3665
3666 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3667 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3668 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3669 macros related to unification of CJK characters. For the details,
3670 see the discussion following the message here:
3671 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3672
3d439cd1
CY
36732012-04-04 Chong Yidong <cyd@gnu.org>
3674
3675 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3676
8bc53d00
EZ
36772012-04-01 Eli Zaretskii <eliz@gnu.org>
3678
3679 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3680 instead of alloca. (Bug#11138)
3681
3b0512a3
AS
36822012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3683
3684 * w32menu.c (is_simple_dialog): Properly check lisp types.
3685 (Bug#11141)
3686
8427ddd2
EZ
36872012-03-31 Eli Zaretskii <eliz@gnu.org>
3688
979022ef
EZ
3689 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3690 position we get to after a call to move_it_to fails the
3691 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3692 only if we wind up in a string from display property. (Bug#11063)
3693
a6b1c7cc
EZ
3694 * window.c (Fdelete_other_windows_internal): Invalidate the row
3695 and column information about mouse highlight, so that redisplay
3696 restores it after reallocating the glyph matrices. (Bug#7464)
3697
8427ddd2
EZ
3698 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3699 string comes from a `display' text property, use the buffer
3700 position of that property as if we actually saw that position in
3701 the row's glyphs.
697ba24b
EZ
3702 (move_it_by_lines): Remove the assertion that
3703 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3704 violated when there's a before-string at the beginning of a line.
3705 (Bug#11063)
8427ddd2 3706
65a0a738
EZ
37072012-03-30 Eli Zaretskii <eliz@gnu.org>
3708
3709 * xdisp.c (append_space_for_newline): If the default face was
3710 remapped, use the remapped face for the appended newline.
3711 (extend_face_to_end_of_line): Use the remapped default face for
3712 extending the face to the end of the line.
3713 (display_line): Call extend_face_to_end_of_line when the default
3714 face was remapped. (Bug#11068)
3715
581355cc
EZ
37162012-03-29 Eli Zaretskii <eliz@gnu.org>
3717
3718 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3719
e8fc049f
SM
37202012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3721
3722 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3723
4fb9a543
GM
37242012-03-27 Glenn Morris <rgm@gnu.org>
3725
3726 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3727 Doc fixes.
3728
679910f1
KH
37292012-03-26 Kenichi Handa <handa@m17n.org>
3730
3731 * dispextern.h (struct glyph): Fix previous change. Change the
3732 bit length of glyphless.ch to 25 (Bug#11082).
3733
90d49b7f
CY
37342012-03-26 Chong Yidong <cyd@gnu.org>
3735
3736 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3737 (command_loop_1): Use it; inhibit selection update for
3738 handle-select-window too (Bug#8996).
3739
f514f6f0
FP
37402012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3741
e8fc049f 3742 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3743
bf43fa51
KH
37442012-03-25 Kenichi Handa <handa@m17n.org>
3745
3746 * dispextern.h (struct glyph): Change the bit length of
3747 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3748
8a0c01dd
EZ
37492012-03-24 Eli Zaretskii <eliz@gnu.org>
3750
3751 * s/ms-w32.h (tzname): Include time.h before redirecting to
3752 _tzname. Fixes the MSVC build. (Bug#9960)
3753
7d1c3a76
AS
37542012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3755
8ed79523
AS
3756 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3757 characters.
3758
7d1c3a76
AS
3759 * xterm.c (XTread_socket): Only modify handling_signal if
3760 !SYNC_INPUT. (Bug#11080)
3761
e99a9b8b
EZ
37622012-03-23 Eli Zaretskii <eliz@gnu.org>
3763
3764 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3765 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3766 when fetching a multibyte character consumes more bytes than
3767 CHAR_BYTES returns, due to unification of CJK characters in
3768 string_char. (Bug#11073)
3769
5063c0e1
TN
37702012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3771
3772 * process.c (wait_reading_process_output): Handle pty disconnect
3773 by refraining from sending oneself a SIGCHLD (bug#10933).
3774
9f851fbd
CY
37752012-03-22 Chong Yidong <cyd@gnu.org>
3776
3777 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3778
5063c0e1 3779 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3780 Mark string as coming from a prefix property.
3781 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3782 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3783
fb5b8aca
CY
37842012-03-21 Chong Yidong <cyd@gnu.org>
3785
3786 * xfaces.c (Vface_remapping_alist): Doc fix.
3787
62356a1b
EZ
37882012-03-20 Eli Zaretskii <eliz@gnu.org>
3789
3790 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3791 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3792 Doc fixes.
62356a1b 3793
025de85b
CY
37942012-03-20 Chong Yidong <cyd@gnu.org>
3795
3796 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3797 to reflect default non-nil value of redisplay-dont-pause.
3798
4827f94e
KH
37992012-03-19 Kenichi Handa <handa@m17n.org>
3800
3801 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3802 it fit in a valid range (Bug#11003).
3803
e50a24a2
EZ
38042012-03-18 Eli Zaretskii <eliz@gnu.org>
3805
3806 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3807 that is not from display property, accept the row as a "cursor
3808 row" if one of the string's character has a non-nil `cursor'
3809 property. Fixes cursor positioning when there are newlines in
3810 overlay strings, e.g. in icomplete.el. (Bug#11035)
3811
9af5ed87
PE
38122012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3815
d1f55f16
CY
38162012-03-12 Chong Yidong <cyd@gnu.org>
3817
3818 * eval.c (inhibit_lisp_code): Rename from
3819 inhibit_window_configuration_change_hook; move from window.c.
3820
3821 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3822 * window.c (run_window_configuration_change_hook)
3823 (syms_of_window): Callers changed.
3824
66c5eebd
CY
38252012-03-11 Chong Yidong <cyd@gnu.org>
3826
413df973
CY
3827 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3828
66c5eebd
CY
3829 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3830
1de11f56
CY
38312012-03-10 Chong Yidong <cyd@gnu.org>
3832
3833 * frame.c (other_visible_frames): Don't assume the selected frame
3834 is visible (Bug#10955).
3835
cae07000
SM
38362012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3837
3838 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3839
89c94350
JD
38402012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3841
3842 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3843 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3844 zero (Bug#10954).
3845
999dd333
GM
38462012-03-03 Glenn Morris <rgm@gnu.org>
3847
01a6dcc8 3848 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3849
de0100f2
EZ
38502012-03-02 Eli Zaretskii <eliz@gnu.org>
3851
3852 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3853 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3854 (redisplay_window, next_element_from_string): Fix typos in
3855 comments.
3e441275
EZ
3856 (redisplay_window): Pass to move_it_vertically the margin in
3857 pixels, not in screen lines.
de0100f2 3858
96a72ee9
GM
38592012-03-02 Glenn Morris <rgm@gnu.org>
3860
3861 * buffer.c (buffer-list-update-hook): Doc fix.
3862
312508d7
EZ
38632012-02-29 Eli Zaretskii <eliz@gnu.org>
3864
3865 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3866 push_it before setting up the iterator for the first overlay
3867 string, even if we have an empty string loaded.
3868 (next_overlay_string): If there's an empty string on the iterator
3869 stack, pop the stack. (Bug#10903)
3870
27f3c637
PE
38712012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3874 Suggested by Stefan Monnier in
3875 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3876 * alloc.c (widen_to_Lisp_Object): New static function.
3877 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3878 and widening them to Lisp_Objects. This would work even if
3879 USE_LSB_TAG is defined and wide integers are used, which might
3880 happen in a future version of Emacs.
3881
3c9dfce6
CY
38822012-02-25 Chong Yidong <cyd@gnu.org>
3883
fa74b241
CY
3884 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3885 Doc fix.
3886
3c9dfce6
CY
3887 * xselect.c (Fx_selection_exists_p): Doc fix.
3888 (x_clipboard_manager_save_all): Print an informative message
3889 before saving to clipboard manager.
3890
9486df08
CY
38912012-02-24 Chong Yidong <cyd@gnu.org>
3892
3893 * keyboard.c (process_special_events): Handle all X selection
3894 requests in kbd_buffer, not just the next one (Bug#8869).
3895
f01d3321
CY
38962012-02-23 Chong Yidong <cyd@gnu.org>
3897
3898 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3899 call when setting menu-bar-lines and tool-bar-lines parameters.
3900 (unwind_create_frame_1): New helper function.
3901
3902 * window.c (inhibit_window_configuration_change_hook): New var.
3903 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3904 (syms_of_window): Initialize it.
f01d3321 3905
86b847b6
CY
39062012-02-22 Chong Yidong <cyd@gnu.org>
3907
3908 * xterm.c (x_draw_image_relief): Add missing type check for
3909 Vtool_bar_button_margin (Bug#10743).
3910
a59225b1
CY
39112012-02-21 Chong Yidong <cyd@gnu.org>
3912
3913 * fileio.c (Vfile_name_handler_alist): Doc fix.
3914
3915 * buffer.c (Fget_file_buffer): Protect against invalid file
3916 handler return value.
3917
310f5bd4
PE
39182012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3919
cb3a28cc
PE
3920 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3921 when computing $valmask.
3922
310f5bd4
PE
3923 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3924 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3925 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3926 It's useless in that case, and it can cause problems on hosts
3927 that allocate halves of EMACS_INT values separately.
3928 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3929 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3930 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3931 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3932 it avoids undefined behavior on hosts where shifting right by more
3933 than the word width has undefined behavior.
3934
2375c96a
CY
39352012-02-19 Chong Yidong <cyd@gnu.org>
3936
3937 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3938 (Funhandled_file_name_directory, Ffile_name_as_directory)
3939 (Fdirectory_file_name, Fexpand_file_name)
3940 (Fsubstitute_in_file_name): Protect against invalid file handler
3941 return values (Bug#10845).
3942
3eb49e71
EZ
39432012-02-18 Eli Zaretskii <eliz@gnu.org>
3944
3945 * .gdbinit (pitx): Fix incorrect references to fields of the
3946 iterator stack.
3947
7b926f3f
CY
39482012-02-17 Chong Yidong <cyd@gnu.org>
3949
3950 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3951
11273115
PE
39522012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3955 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3956
c3a70e2b
CY
39572012-02-15 Chong Yidong <cyd@gnu.org>
3958
3959 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3960 marked as special. Also, starting docstrings with * is obsolete.
3961
0ca43699
AS
39622012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3963
3964 * gnutls.c (emacs_gnutls_write): Fix last change.
3965
2e8f3c56
LI
39662012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3967
3968 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3969 send_process.
3970
af70074f
SM
39712012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3972
3973 * keymap.c (Fsingle_key_description): Handle char ranges.
3974
95986d52
CY
39752012-02-12 Chong Yidong <cyd@gnu.org>
3976
afd83bd1
CY
3977 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3978 as that creates a dangerous corner case.
3979
95986d52
CY
3980 * window.c (Fdelete_window_internal): Invalidate the mouse
3981 highlight (Bug#9904).
3982
bd7da63e
GM
39832012-02-12 Glenn Morris <rgm@gnu.org>
3984
3985 * xselect.c (Fx_own_selection_internal)
3986 (Fx_get_selection_internal, Fx_disown_selection_internal)
3987 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3988 * nsselect.m (Fx_own_selection_internal)
3989 (Fx_disown_selection_internal, Fx_selection_exists_p)
3990 (Fx_selection_owner_p, Fx_get_selection_internal):
3991 Sync docs and argument specs with the xselect.c versions.
3992
77abcbc2
LI
39932012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3994
3995 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3996
90b671e2
EZ
39972012-02-11 Eli Zaretskii <eliz@gnu.org>
3998
1c0ca0b7
EZ
3999 * w32select.c (Fx_selection_exists_p): Sync doc string and
4000 argument list with xselect.c. (Bug#10783)
4001
4002 * w16select.c (Fx_selection_exists_p): Sync doc string and
4003 argument list with xselect.c. (Bug#10783)
90b671e2 4004
49241268
GM
40052012-02-10 Glenn Morris <rgm@gnu.org>
4006
4007 * fns.c (Fsecure_hash): Doc fix.
4008
f998bbe7 40092012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4010
4011 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4012
0992bd9c
CY
40132012-02-07 Chong Yidong <cyd@gnu.org>
4014
4015 * buffer.c (Fbuffer_local_variables)
4016 (buffer_lisp_local_variables): Handle unbound vars correctly;
4017 don't let Qunbound leak into Lisp.
4018
af008560
GM
40192012-02-07 Glenn Morris <rgm@gnu.org>
4020
dd605cc4
GM
4021 * image.c (Fimagemagick_types): Doc fix.
4022
af008560
GM
4023 * image.c (imagemagick-render-type): Change it from a lisp object
4024 to an integer. Move the doc here from the lisp manual.
4025 Treat all values not equal to 0 the same.
4026
1449fa1d
CY
40272012-02-06 Chong Yidong <cyd@gnu.org>
4028
4029 * doc.c (store_function_docstring): Avoid applying docstring of
4030 alias to base function (Bug#2603).
4031
3723ec07
AS
40322012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4033
4034 * .gdbinit (pp1, pv1): Remove redundant defines.
4035 (pr): Use pp.
4036
79c1cc1e
CY
40372012-02-04 Chong Yidong <cyd@gnu.org>
4038
4039 * nsterm.m: Declare a global (Bug#10694).
4040
d7f29f8e
EZ
40412012-02-04 Eli Zaretskii <eliz@gnu.org>
4042
cae07000
SM
4043 * w32.c (get_emacs_configuration_options):
4044 Include --enable-checking, if specified, in the return value.
d7f29f8e 4045
3b95a6f9
MR
40462012-02-04 Martin Rudalics <rudalics@gmx.at>
4047
4048 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4049 after rounding frame sizes. (Bug#9723)
4050
d6fa96a6
EZ
40512012-02-04 Eli Zaretskii <eliz@gnu.org>
4052
4053 * keyboard.c (adjust_point_for_property): Don't position point
4054 before BEGV. (Bug#10696)
4055
df0b2940
PE
40562012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 Handle overflow when computing char display width (Bug#9496).
4059 * character.c (char_width): Return EMACS_INT, not int.
4060 (char_width, c_string_width): Check for overflow when
4061 computing the width; this is possible now that individual
4062 characters can have unbounded width. Problem introduced
4063 by merge from Emacs 23 on 2012-01-19.
4064
6bee44d6
MA
40652012-02-02 Michael Albinus <michael.albinus@gmx.de>
4066
4067 * dbusbind.c (Fdbus_register_method): Mention the return value
4068 :ignore in the docstring.
4069
44f92739
GM
40702012-02-02 Glenn Morris <rgm@gnu.org>
4071
1b9f60cc
GM
4072 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4073
44f92739
GM
4074 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4075 Unconditionally set to t. (Bug#10673)
4076 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4077 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4078 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4079
c5d3843c
KH
40802012-02-02 Kenichi Handa <handa@m17n.org>
4081
4082 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4083 0, do not call append_composite_glyph.
4084
159462d4 40852012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4086
4087 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4088 NULL (Bug#6988).
4089 (x_produce_glyphs): If the component of a composition is a null
4090 string, set it->pixel_width to 1 to avoid zero-width glyph.
4091
78cef877
EZ
40922012-02-01 Eli Zaretskii <eliz@gnu.org>
4093
4094 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4095 first 2 arguments are identical. This makes inserting large
4096 output from a subprocess an order of magnitude faster on
4097 MS-Windows, where all sbrk'ed memory is always contiguous.
4098
97897668
GM
40992012-01-31 Glenn Morris <rgm@gnu.org>
4100
4101 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4102 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4103 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4104
31fd3586
GM
41052012-01-29 Glenn Morris <rgm@gnu.org>
4106
4107 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4108
0e24a8b2
CY
41092012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4110
4111 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4112
cc0adcb0
CY
41132012-01-28 Chong Yidong <cyd@gnu.org>
4114
4115 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4116
acc28cb9
CY
41172012-01-26 Chong Yidong <cyd@gnu.org>
4118
9c69cfb7
CY
4119 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4120
acc28cb9
CY
4121 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4122 repeat counts (Bug#10507).
4123
48da7392
GM
41242012-01-26 Glenn Morris <rgm@gnu.org>
4125
4126 * lread.c (syms_of_lread): Doc fix.
4127
14af5f7f
CY
41282012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4129
4130 * coding.c (encode_designation_at_bol): Change return value to
4131 EMACS_INT.
4132
0b21c100
CY
41332012-01-25 Chong Yidong <cyd@gnu.org>
4134
4135 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4136
3c2907f7
CY
41372012-01-21 Chong Yidong <cyd@gnu.org>
4138
4139 * floatfns.c (Fcopysign): Make the second argument non-optional,
4140 since nil is not allowed anyway.
4141
959ad23f
AS
41422012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4143
4144 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4145 (send_process): Likewise.
4146
34a02f46
MR
41472012-01-19 Martin Rudalics <rudalics@gmx.at>
4148
4149 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4150 (Vwindow_persistent_parameters): Do not use Qstate.
4151 Rewrite doc-strings.
34a02f46 4152
1259009a 41532012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4154
4155 * character.c (char_width): New function.
70d4fdf6
GM
4156 (Fchar_width, c_string_width, lisp_string_width):
4157 Use char_width (Bug#9496).
25ed9e61 4158
6a6ee00d
MR
41592012-01-16 Martin Rudalics <rudalics@gmx.at>
4160
4161 * window.c (Vwindow_persistent_parameters): New variable.
4162 (Fset_window_configuration, save_window_save): Handle persistent
4163 window parameters.
4164
c85efaf7
EZ
41652012-01-14 Eli Zaretskii <eliz@gnu.org>
4166
4167 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4168 thrashing the stack of the thread. (Bug#9087)
4169
5944709e
PE
41702012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4173
e71f5d99
EZ
41742012-01-11 Eli Zaretskii <eliz@gnu.org>
4175
4176 * xdisp.c (rows_from_pos_range): Handle the case where the
4177 highlight ends on a newline. (Bug#10464)
4178 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4179 he end column for display of highlight that ends on a newline
4180 before a R2L line.
4181
ce316182
GM
41822012-01-11 Glenn Morris <rgm@gnu.org>
4183
4184 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4185 from load-path also when installation-directory is nil. (Bug#10208)
4186
5b43da69
GM
41872012-01-10 Glenn Morris <rgm@gnu.org>
4188
74cc8ff9
GM
4189 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4190
7d8d6e4e
GM
4191 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4192 Update template values to be closer to their typical values these days.
5b43da69 4193
a0db8d43
EZ
41942012-01-09 Eli Zaretskii <eliz@gnu.org>
4195
4196 * xdisp.c (rows_from_pos_range): Accept additional argument
4197 DISP_STRING, and accept any glyph in a row whose object is that
4198 string as eligible for mouse highlight. Fixes mouse highlight of
4199 display strings from overlays. (Bug#10464)
4200
9a0115ab 42012012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4202
b9110d6a 4203 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4204 * fileio.c (auto_saving_dir_umask): New static var.
4205 (Fmake_directory_internal): Use it.
4206 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4207 creating the directory. The old code temporarily assigns
4208 too-generous permissions to the directory.
4209 (do_auto_save_eh): Clear it.
b9110d6a 4210 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4211 that the var is always cleared.
4212
6c1bd3f3
EZ
42132012-01-07 Eli Zaretskii <eliz@gnu.org>
4214
4215 * search.c (scan_buffer): Pass character positions to
4216 know_region_cache, not byte positions. (Bug#6540)
4217
069d2b50
L
42182012-01-07 LynX <_LynX@bk.ru> (tiny change)
4219
4220 * w32.c (sys_rename): Report EXDEV when rename of a directory
4221 fails because the target is on another logical disk. (Bug#10284)
4222
75bf0d33
DB
42232012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4224
4225 * xterm.c (x_embed_request_focus): New function.
4226
4227 * xterm.h: Add prototype.
4228
4229 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4230
1c6e5a32
GM
42312012-01-05 Glenn Morris <rgm@gnu.org>
4232
4233 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4234
651e947e
EZ
42352012-01-01 Eli Zaretskii <eliz@gnu.org>
4236
4237 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4238 Load gnutls_transport_set_lowat only if GnuTLS version is below
4239 2.11.1.
4240 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4241 GnuTLS versions below 2.11.1.
4242
3778cdd8
AL
42432011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4244
4245 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4246 to the doc string advising against its use for altering the way
4247 windows are scrolled.
4248
0e5317f7
KH
42492011-12-28 Kenichi Handa <handa@m17n.org>
4250
4251 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4252 coding-system ASCII compatible only when it does not produce BOM
4253 on encoding (Bug#10383).
4254
93d5ca1f
JD
42552011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4256
4257 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4258 can scroll.
4259 (create_and_show_popup_menu): Always use menu_position_func for
4260 Gtk3 (Bug#10361).
4261
ca22b785
AS
42622011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4263
4264 * callint.c (Fcall_interactively): Don't truncate prompt string.
4265
d048e1e6
EZ
42662011-12-23 Eli Zaretskii <eliz@gnu.org>
4267
4268 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4269 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4270 resumed from there (after widening). (Bug#10360)
d048e1e6 4271
5ccaba1f
JD
42722011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4273
4274 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4275
204ee57f
JD
42762011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4277
b81d40f0
JB
4278 * nsterm.m (x_free_frame_resources):
4279 Release f->output_data.ns->miniimage.
204ee57f
JD
4280 (ns_index_color): Fix indentation. Do not retain
4281 color_table->colors[i].
4282
4283 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4284 before returning.
4285
4286 * nsfns.m (x_set_background_color): Assign return value from
4287 ns_index_color to face-background instead of NSColor*.
4288 (ns_implicitly_set_icon_type): Fix indentation.
4289 Change assignment in for loop to comparison.
4290
4291 * emacs.c (ns_pool): New variable.
4292 (main): Assign ns_pool.
4293 (Fkill_emacs): Call ns_release_autorelease_pool.
4294
4295 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4296 autorelease fdesc, release fdAttrs and tdict.
4297 (ns_get_covering_families): Release charset.
4298 (ns_findfonts): Release NSFontDescriptor created with new.
4299 (ns_uni_to_glyphs): Fix indentation.
4300 (setString): Release attrStr before assigning new value.
4301
c803b2b7
JD
43022011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4303
678f4426
JD
4304 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4305 and NS_IMPL_COCOA.
4306 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4307 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4308
cd394be1 43092011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4310
5fecd5fc
JD
4311 * nsterm.m (ns_term_init): Subscribe for notifications
4312 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4313 to method trackingNotification in EmacsMenu.
4314
4315 * nsmenu.m (trackingMenu): New variable.
3771cb17 4316 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4317 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4318 from Aquamacs (Bug#7030).
678f4426
JD
4319
43202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4321
c803b2b7
JD
4322 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4323 (symbol_to_nsstring): Fix indentation.
4324 (ns_symbol_to_pb): New function.
cae07000
SM
4325 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4326 (Fns_rotate_cut_buffers_internal): Remove.
4327 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4328 Fns_store_cut_buffer_internal.
4329 (ns_get_foreign_selection, Fx_own_selection_internal)
4330 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4331 (Fns_get_selection_internal, Fns_store_selection_internal):
4332 Use ns_symbol_to_pb and check if return value is nil.
4333 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4334 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4335 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4336 renamed to Sns_store_selection_internal.
4337 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4338 and remove this function.
4339 (ns_handle_selection_clear): Remove, never used.
4340 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4341 here.
4342
e1b01a3a
KB
43432011-12-17 Ken Brown <kbrown@cornell.edu>
4344
4345 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4346 GID is unknown (Bug#10257).
4347
2adb6e85
PE
43482011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4349
4350 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4351 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4352 which caused a build failure on GNU/Linux IA-64. This problem was
4353 introduced by my 2011-10-07 patch.
4354
d1d7b339
JL
43552011-12-15 Juri Linkov <juri@jurta.org>
4356
4357 * image.c (imagemagick_error): New function. (Bug#10112)
4358 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4359 Use `imagemagick_error' where ImageMagick functions return
4360 `MagickFalse'.
4361 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4362 proper order.
4363
100d5755
KH
43642011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4365
4366 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4367 fill background (Bug#8992).
4368
454592a6
MR
43692011-12-13 Martin Rudalics <rudalics@gmx.at>
4370
4371 * window.c (Vwindow_combination_resize)
4372 (Vwindow_combination_limit): Use t instead of non-nil in
4373 doc-strings.
61d4b438
MR
4374 (Vrecenter_redisplay): Add first sentence of doc-string on
4375 separate line.
53524d93 4376 (Frecenter): Fix doc-string typo.
454592a6 4377
3633e3aa
KH
43782011-12-11 Kenichi Handa <handa@m17n.org>
4379
4380 * coding.c (Funencodable_char_position): Pay attention to the
4381 buffer text relocation (Bug#9389).
4382
7b9d523a 43832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4384
7b9d523a
JD
4385 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4386 gtk_init (Bug#10100).
4387
b73189c6
EZ
43882011-12-10 Eli Zaretskii <eliz@gnu.org>
4389
4390 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4391 IT->string is nil. (Bug#10263)
4392
f7dfe5d6
JD
43932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4394
83faebb4
JD
4395 * nsterm.h (x_free_frame_resources): Declare.
4396
f7dfe5d6
JD
4397 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4398 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4399
4400 * nsterm.h (ns_get_defaults_value): Declare.
4401
4402 * nsterm.m (ns_default): Call ns_get_defaults_value.
4403
7cd4e72c
EZ
44042011-12-09 Eli Zaretskii <eliz@gnu.org>
4405
4406 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4407 (Bug#10170)
4408
b34d7317
YM
44092011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4410
4411 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4412 that where the value of an _OBJC_* symbol points to is in the .bss
4413 section (Bug#10240).
4414
76470ad1
KH
44152011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4416
4417 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4418 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4419
745fff94
KH
44202011-12-08 Kenichi Handa <handa@m17n.org>
4421
4422 * ftfont.c (get_adstyle_property): Fix previous change
4423 (Bug#10233).
4424
6e44397c
JB
44252011-12-07 Juanma Barranquero <lekktu@gmail.com>
4426
4427 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4428 dirs from the default value of EMACSLOADPATH (bug#10208).
4429
7efa6272
GM
44302011-12-07 Glenn Morris <rgm@gnu.org>
4431
4432 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4433 installation and source directories as well. (Bug#10208)
4434
f6fc4d87
CY
44352011-12-06 Chong Yidong <cyd@gnu.org>
4436
4437 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4438
2bf26180
GM
44392011-12-06 Glenn Morris <rgm@gnu.org>
4440
4441 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4442 as an error, not just -1. (Bug#10217)
4443
3a6ad4f0
CY
44442011-12-05 Chong Yidong <cyd@gnu.org>
4445
4446 * keyboard.c (process_special_events): New function.
4447 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4448
75a3b399
PE
44492011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4450
4451 * coding.c (encode_designation_at_bol): Don't use uninitialized
4452 local variable (Bug#9318).
4453
c3c9e25e
KH
44542011-12-05 Kenichi Handa <handa@m17n.org>
4455
4456 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4457 return Qnil (Bug#8046, Bug#10193).
4458
5eb05ea3
KH
44592011-12-05 Kenichi Handa <handa@m17n.org>
4460
4461 * coding.c (encode_designation_at_bol): New args charbuf_end and
4462 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4463 (coding_set_source): Return how many bytes coding->source was
4464 relocated.
4465 (coding_set_destination): Return how many bytes
4466 coding->destination was relocated.
4467 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4468 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4469
44702011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4471
4472 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4473 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4474 macro (Bug#9318).
4475
44762011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4477
4478 The following changes are to fix Bug#9318.
4479
a79703f5 4480 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4481 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4482 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4483 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4484
7dbda6df
JB
44852011-12-05 Juanma Barranquero <lekktu@gmail.com>
4486
4487 * lisp.h (process_quit_flag): Fix external declaration.
4488
6d5eb5b0
SM
44892011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4490
4491 Don't macro-inline non-performance-critical code.
4492 * eval.c (process_quit_flag): New function.
4493 * lisp.h (QUIT): Use it.
4494
a0c3fad0
JD
44952011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4496
4497 * nsfns.m (get_geometry_from_preferences): New function.
4498 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4499
6c07aac2
AS
45002011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4501
4502 * emacs.c (Qkill_emacs): Define.
4503 (syms_of_emacs): Initialize it.
4504 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4505 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4506 (quit_throw_to_read_char): Add parameter `from_signal'.
4507 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4508 * lisp.h (QUIT): Call Fkill_emacs if requested.
4509
c052ead4
JD
45102011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4511
4512 * widget.c (update_wm_hints): Return if wmshell is null.
4513 (widget_update_wm_size_hints): New function.
4514
4515 * widget.h (widget_update_wm_size_hints): Declare.
4516
4517 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4518 widget_update_wm_size_hints (Bug#10104).
4519
9e49252b
EZ
45202011-12-03 Eli Zaretskii <eliz@gnu.org>
4521
4522 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4523 before a newline, prepare the bidi iterator for consuming the
4524 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4525 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4526
02b16839
JL
45272011-12-02 Juri Linkov <juri@jurta.org>
4528
4529 * search.c (Fword_search_regexp): New Lisp function created from
4530 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4531 (Fword_search_backward, Fword_search_forward)
4532 (Fword_search_backward_lax, Fword_search_forward_lax):
4533 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4534 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4535
0068070e
SM
45362011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4537
4538 * fileio.c (Finsert_file_contents): Move after-change-function call
4539 to before the "handled:" label, since all "goto handled" appear in
4540 cases where the *-change-functions have already been properly called
4541 (bug#10117).
4542
3360a3fc
AS
45432011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4544
4545 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4546 waiting for input. (Bug#10169)
4547
73d6c093
EZ
45482011-11-30 Eli Zaretskii <eliz@gnu.org>
4549
4550 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4551 verifies glyph row's hash code--we have just reallocated the
4552 glyphs, so their contents can be complete garbage. (Bug#10164)
4553
febe6bea
JB
45542011-11-30 Juanma Barranquero <lekktu@gmail.com>
4555
4556 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4557
801a4313
EZ
45582011-11-30 Eli Zaretskii <eliz@gnu.org>
4559
4560 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4561 attributes are tested _before_ calling verify_row_hash, to protect
4562 against GCC re-ordering of the tests. (Bug#10164)
4563
2b56b87e
JD
45642011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4565
4566 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4567
4568 * xterm.c (handle_one_xevent): Only set async_visible and friends
4569 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4570 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4571 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4572
dbf31225
PE
45732011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4574
4575 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4576 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4577 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4578 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4579 All uses changed to use GCPRO1 etc.
4580 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4581 Revert to old implementation (i.e., before 2011-03-11).
4582
1305621b
YM
45832011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4584
4585 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4586 of scroll runs so as to avoid assigning disabled bogus rows and
4587 unnecessary graphics copy operations.
4588
8c9afb46
EZ
45892011-11-27 Eli Zaretskii <eliz@gnu.org>
4590
4591 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4592 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4593 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4594 (malloc, free, realloc, calloc): Redirect to e_* only when
4595 compiling Emacs.
4596
4597 * lisp.h (GCTYPEBITS): Move before first use.
4598 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4599 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4600 this macro definition.
4601
4602 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4603 _MSC_VER.
4604
54e9e3bf
JD
46052011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4606
6d5eb5b0
SM
4607 * gtkutil.c (xg_create_frame_widgets):
4608 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4609 present with Gtk+ 2.0.
4610
83aca1cb
PE
46112011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4612
4613 * fileio.c (Finsert_file_contents): Undo previous change; see
4614 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4615
5b76caa4
PE
46162011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4617
4618 Rename locals to avoid shadowing.
4619 * fileio.c (Finsert_file_contents):
4620 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4621 * process.c (wait_reading_process_output):
4622 Rename inner 'proc' to 'p' to avoid shadowing.
4623 Indent for consistency with usual Emacs style.
4624
8c535114
EZ
46252011-11-25 Eli Zaretskii <eliz@gnu.org>
4626
4627 * xdisp.c (redisplay_window): If cursor row is not fully visible
4628 after recentering, and scroll-conservatively is set to a large
4629 number, scroll window by a few more lines to make the cursor fully
4630 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4631 (start_display): Don't move to the next line if the display should
4632 start at a newline that is part of a display vector or an overlay
4633 string. (Bug#10119)
8c535114 4634
fa4fdb5c
JL
46352011-11-24 Juri Linkov <juri@jurta.org>
4636
4637 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4638 after the `MagickPingImage' call. (Bug#10112)
4639
90ec88df
CY
46402011-11-23 Chong Yidong <cyd@gnu.org>
4641
4642 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4643
56e2e794
MR
46442011-11-23 Martin Rudalics <rudalics@gmx.at>
4645
4646 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4647 making another buffer current. (Bug#10114)
4648
b6e64c41
GM
46492011-11-23 Glenn Morris <rgm@gnu.org>
4650
4651 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4652
6b21de18
CY
46532011-11-23 Chong Yidong <cyd@gnu.org>
4654
4655 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4656 using it (Bug#5984).
4657
b12cd789
EZ
46582011-11-22 Eli Zaretskii <eliz@gnu.org>
4659
4660 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4661 and header-lines, as they don't have one computed for them.
4662 (Bug#10098)
4663
4664 * .gdbinit (prow): Make displayed values more self-explaining.
4665 Add row's hash code.
4666
261b6fd4
LMI
46672011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4668
4669 * process.c (wait_reading_process_output): Fix asynchrounous
4670 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4671 (wait_reading_process_output): Add comment and URL.
261b6fd4 4672
e7cfd277
JD
46732011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4674
4675 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4676
a9b9b7f5
CY
46772011-11-21 Chong Yidong <cyd@gnu.org>
4678
4679 * window.c (Fnext_window, Fprevious_window): Doc fix.
4680
b0d15b4f
SM
46812011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4682
4683 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4684
fe7a3057
JB
46852011-11-20 Juanma Barranquero <lekktu@gmail.com>
4686
4687 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4688
d2999b1a
MR
46892011-11-20 Martin Rudalics <rudalics@gmx.at>
4690
4691 * window.c (Fset_window_combination_limit): Rename argument
4692 STATUS to LIMIT.
4693 (Vwindow_combination_limit): Remove "status" from doc-string.
4694
d5ff9cd0
AS
46952011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4696
4697 * m/ibms390.h: Remove.
4698 * m/ibms390x.h: Don't include "ibms390.h".
4699
a5bb9bd3
SM
47002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4701
4702 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4703 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4704
cd1181db
JB
47052011-11-20 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * casetab.c (Fset_case_table):
4708 * charset.c (Fcharset_after): Fix typos.
4709
615a3b8d 47102011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4711
17e845af
PE
4712 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4713 Otherwise, valgrind does not work on some platforms.
4714 Problem reported by Andreas Schwab in
6a0bf43d
PE
4715 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4716 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4717 is set, removing the need for VIRT_ADDRESS_VARIES.
4718 (PURE_P): Use a more-efficient implementation that needs just one
4719 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4720 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4721 to 4 (xorl, subq, cmpq, setbe).
4722 * alloc.c (pure): Always extern now, since that's the
4723 VIRT_ADDR_VARIES behavior.
4724 (PURE_POINTER_P): Use a single comparison, not two, for
4725 consistency with the new puresize.h.
4726 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4727 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4728 Remove VIRT_ADDR_VARIES no longer needed.
4729
f8fe6f96
EZ
47302011-11-19 Eli Zaretskii <eliz@gnu.org>
4731
4732 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4733 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4734 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4735 behave as if the cursor position were at the window margin.
4736
4737 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4738 and the cursor position is out of bounds, behave as if the cursor
4739 position were at the window margin. (Bug#10075)
4740
df05a53c
CY
47412011-11-18 Chong Yidong <cyd@gnu.org>
4742
4743 * window.c (Fwindow_combination_limit): Make first argument
4744 non-optional, since it is meaningless for live windows like the
4745 selected window.
61ccba97 4746
2071918e
DA
47472011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4748
4749 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4750
b50a28de
SM
47512011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4752
4753 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4754 (graft_intervals_into_buffer): Simplify.
4755
015137db
EZ
47562011-11-18 Eli Zaretskii <eliz@gnu.org>
4757
4758 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4759 hash values of the two rows.
4760 (copy_row_except_pointers): Preserve the used[] arrays and the
4761 hash values of the two rows. (Bug#10035)
68c95424 4762 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4763
4764 * xdisp.c (row_hash): New function, body extracted from
4765 compute_line_metrics.
4766 (compute_line_metrics): Call row_hash, instead of computing the
4767 hash code inline.
4768
4769 * dispnew.c (verify_row_hash): Call row_hash for computing the
4770 hash code of a row, instead of duplicating code from xdisp.c.
4771
4772 * dispextern.h (row_hash): Add prototype.
4773
a2addb04
TH
47742011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4775
4776 * frame.c (delete_frame): Don't delete the terminal when the last
4777 X frame is closed if emacs is built with GTK toolkit.
4778
df85d315
JB
47792011-11-17 Juanma Barranquero <lekktu@gmail.com>
4780
4781 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4782
a0c2d0ae
MR
47832011-11-17 Martin Rudalics <rudalics@gmx.at>
4784
4785 * window.c (Vwindow_splits): Rename to
4786 Vwindow_combination_resize. Suggested by Juri Linkov.
4787 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4788 of Vwindow_splits.
4789
58179cce
JB
47902011-11-16 Juanma Barranquero <lekktu@gmail.com>
4791
7877f373
JB
4792 * nsfns.m (Fns_font_name):
4793 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4794
b6f67890
MR
47952011-11-16 Martin Rudalics <rudalics@gmx.at>
4796
4797 * window.h (window): Rename slot "nest" to "combination_limit".
4798 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4799 (Fset_window_nest): Rename to Fset_window_combination_limit.
4800 (Vwindow_nest): Rename to Vwindow_combination_limit.
4801 (recombine_windows, make_parent_window, make_window)
4802 (Fsplit_window_internal, saved_window)
4803 (Fset_window_configuration, save_window_save): Rename all
4804 occurrences of window_nest to window_combination_limit.
4805
c7015153
JB
48062011-11-15 Juanma Barranquero <lekktu@gmail.com>
4807
4808 * image.c (imagemagick_load_image): Fix typo.
4809
322ad6ec
EZ
48102011-11-14 Eli Zaretskii <eliz@gnu.org>
4811
4812 * xdisp.c (display_line): Move the call to
4813 highlight_trailing_whitespace before the call to
4814 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4815 faces of all the glyphs to compute ROW's hash value.
4816 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4817
f067b8ec
JB
48182011-11-14 Juanma Barranquero <lekktu@gmail.com>
4819
4820 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4821 just return (bug#10044).
4822
1e5b2111
EZ
48232011-11-12 Eli Zaretskii <eliz@gnu.org>
4824
7ef3cbd5
EZ
4825 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4826 with user-defined heap size. Bump the default size of the temacs
4827 heap to 27MB, to avoid memory warning when running temacs.
4828 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4829
1e5b2111
EZ
4830 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4831 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4832 (verify_row_hash) [XASSERTS]: New function.
4833 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4834 that the hash value of glyph rows is correct.
1e5b2111 4835
89d61221
MR
48362011-11-12 Martin Rudalics <rudalics@gmx.at>
4837
4838 * window.h (window): Remove splits slot.
4839 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4840 (Fdelete_other_windows_internal, make_parent_window)
4841 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4842 (Fset_window_configuration, save_window_save): Don't deal with
4843 split status of windows.
4844 (saved_window): Remove splits slot.
4845 (Vwindow_splits): Rewrite doc-string.
4846
97f18cc8
JD
48472011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4848
4849 * xfns.c (unwind_create_frame):
4850 * nsfns.m (unwind_create_frame):
4851 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4852 Vframe_list (Bug#9999).
4853
22a648b4
DA
48542011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4855
0b381c7e 4856 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4857
659afede
KH
48582011-11-11 Kenichi Handa <handa@m17n.org>
4859
4860 * callproc.c (Fcall_process): Set the member dst_multibyte of
4861 process_coding.
4862
9ac0394b
KH
48632011-11-11 Johan Bockgård <bojohan@gnu.org>
4864
4865 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4866 avoid a crash (bug#9496).
4867
2fbdc249
CY
48682011-11-09 Chong Yidong <cyd@gnu.org>
4869
4870 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4871 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4872
ac6b1f81
PE
48732011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4874
4875 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4876
09db192c
PE
48772011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4878
4879 Avoid some portability problems by eschewing 'extern inline' functions.
4880 The trivial performance wins aren't worth the portability hassles; see
4881 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4882 et seq.
4883 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4884 (window_box_width, window_box_left, window_box_left_offset)
4885 (window_box_right, window_box_right_offset): Undo previous change,
4886 by removing the "extern"s.
4887 * intervals.c (adjust_intervals_for_insertion)
4888 (adjust_intervals_for_deletion): Undo previous change,
4889 making these static again.
4890 (offset_intervals, temp_set_point_both, temp_set_point)
4891 (copy_intervals_to_string): No longer inline.
4892 * xdisp.c (window_text_bottom_y, window_box_width)
4893 (window_box_height, window_box_left_offset)
4894 (window_box_right_offset, window_box_left, window_box_right)
4895 (window_box): No longer inline.
4896
105216ed
CY
48972011-11-08 Chong Yidong <cyd@gnu.org>
4898
4899 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4900 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4901 Signal an error if not a live window.
105216ed
CY
4902 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4903 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4904
ae9e237f
JB
49052011-11-07 Juanma Barranquero <lekktu@gmail.com>
4906
4907 * lisp.h (syms_of_abbrev): Remove declaration.
4908 Reported by CHENG Gao <chenggao@royau.me>.
4909
c7aa8333
EZ
49102011-11-07 Eli Zaretskii <eliz@gnu.org>
4911
4912 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4913 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4914 of temacs in GUI mode.
4915
be7f5545
MR
49162011-11-07 Martin Rudalics <rudalics@gmx.at>
4917
4918 * window.h: Declare delete_all_child_windows instead of
4919 delete_all_subwindows.
4920 * window.c (Fwindow_nest, Fset_window_nest)
4921 (Fset_window_new_total, Fset_window_new_normal)
4922 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4923 (delete_all_subwindows): Rename to delete_all_child_windows.
4924 (Fdelete_other_windows_internal, Fset_window_configuration):
4925 Call delete_all_child_windows instead of delete_all_subwindows.
4926 * frame.c (delete_frame): Call delete_all_child_windows instead
4927 of delete_all_subwindows.
4928
ca78dc43
PE
49292011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4930
4931 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4932 This is also needed for porting to any host where GC_MARK_STACK is
4933 not GC_MAKE_GCPROS_NOOPS.
4934 (which_symbols): Use it.
4935
a0241d01
KH
49362011-11-07 Kenichi Handa <handa@m17n.org>
4937
4938 * coding.c (coding_set_destination): Check coding->src_pos only
4939 when coding->src_object is a buffer (bug#9910).
4940
4941 * process.c (send_process): Set the member src_multibyte of coding
4942 to 0 (bug#9911) when sending a unibyte text.
4943
4944 * callproc.c (Fcall_process): Set the member src_multibyte of
4945 process_coding to 0 (bug#9912).
4946
a64bfdfa 49472011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4948
4949 * xmenu.c (cleanup_widget_value_tree): New function.
4950 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4951 calling free_menubar_widget_value_tree directly (Bug#9830).
4952
cb41b32a
PE
49532011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4954
4955 Fix some portability problems with 'inline'.
4956 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4957 (window_box_width, window_box_left, window_box_left_offset)
4958 (window_box_right, window_box_right_offset): Declare extern.
4959 Otherwise, these inline functions do not conform to C99 and
4960 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4961 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4962 * intervals.c (adjust_intervals_for_insertion)
4963 (adjust_intervals_for_deletion): Now extern, because otherwise the
4964 extern inline functions 'offset_intervals' couldn't refer to it.
4965 (static_offset_intervals): Remove.
4966 (offset_intervals): Rewrite using the old contents of
4967 static_offset_intervals. The old version didn't conform to C99
4968 because an extern inline function contained a reference to an
4969 identifier with static linkage.
4970
b7041366
AS
49712011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4972
4973 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4974 GC.
4975
88a37c4d
EZ
49762011-11-06 Eli Zaretskii <eliz@gnu.org>
4977
4978 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4979 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4980 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4981 return Qleft_to_right.
4982
49745b39
CY
49832011-11-06 Chong Yidong <cyd@gnu.org>
4984
4985 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4986 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4987 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4988 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4989 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4990 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4991 (Fwindow_vscroll): Doc fix.
4992 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4993 argument, since it makes no sense to pass a live window and for
4994 consistency with window-child.
4995
1f05cd82
CS
49962011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4997
4998 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4999 support MSVC.
5000
22610910
JR
50012011-11-05 Jason Rumney <jasonr@gnu.org>
5002
5003 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5004 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5005 fonts (Bug#6029).
5006 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5007 bitwise arithmetic preventing use of unicode-sip and non-truetype
5008 opentype fonts.
5009
a06776b2
EZ
50102011-11-05 Eli Zaretskii <eliz@gnu.org>
5011
3ad924ba
EZ
5012 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5013 "emacs"-only part.
5014
a06776b2
EZ
5015 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5016 initialization code to keep similarity to xfns.c after changes
5017 from 2011-11-05.
5018
c9e7db78
JD
50192011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5020
a97f8f3f
JD
5021 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5022 (unwind_create_frame): New function (Bug#9943).
5023 (Fx_create_frame): Restructure code to be more similar to the one in
5024 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5025 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5026 Move terminal->reference_count++ just before making the frame official
5027 (Bug#9943).
5028
5029 * nsterm.m (x_free_frame_resources): New function.
5030 (x_destroy_window): Move code to x_free_frame_resources.
5031
c9e7db78 5032 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5033 (Fx_create_frame, x_create_tip_frame):
5034 Move terminal->reference_count++ just before making the frame
75f1671a 5035 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5036 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5037
a6fc3b5c
EZ
50382011-11-05 Eli Zaretskii <eliz@gnu.org>
5039
5040 Support MSVC build with newer versions of Visual Studio.
5041 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5042 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5043 nt/gmake.defs.
5044
5045 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5046 which are not supported by MSVC.
5047 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5048 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5049 bitfields.
5050 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5051 types in bitfields.
5052 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5053
5054 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5055
58179cce 50562011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5057
5058 Support MSVC build with newer versions of Visual Studio.
5059 * w32.c: Don't include w32api.h for MSVC.
5060 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5061
5062 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5063 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5064 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5065 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5066 e_* cousins.
5067 (alloca) [_MSC_VER]: Define to _alloca.
5068
5069 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5070
5071 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5072
a58c13ed
EZ
50732011-11-04 Eli Zaretskii <eliz@gnu.org>
5074
5075 * xdisp.c (note_mouse_highlight): If either of
5076 previous/next-single-property-change returns nil, treat that as
5077 the beginning or the end of the buffer. (Bug#9955)
5078
fe0b6370
JD
50792011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5080
a58c13ed 5081 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5082 label is not null (Bug#9951).
5083 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5084 may be NULL.
5085
89bd5ee1
EZ
50862011-11-04 Eli Zaretskii <eliz@gnu.org>
5087
5088 * window.c (Fwindow_body_size): Mention in the doc string that the
5089 return value is in frame's canonical units. (Bug#9949)
5090
84c3edb9
EZ
50912011-11-03 Eli Zaretskii <eliz@gnu.org>
5092
4e2fb5c7
EZ
5093 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5094
84c3edb9 5095 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5096 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5097 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5098
bc17a887
EZ
50992011-11-01 Eli Zaretskii <eliz@gnu.org>
5100
5101 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5102 Don't stop backward scan on the continuation glyph, even though
5103 its CHARPOS is positive.
6d5eb5b0
SM
5104 (mouse_face_from_buffer_pos, note_mouse_highlight):
5105 Rename cover_string to disp_string.
bc17a887 5106
4ee88440
MR
51072011-11-01 Martin Rudalics <rudalics@gmx.at>
5108
5109 * window.c (temp_output_buffer_show): Don't use
5110 Vtemp_buffer_show_specifiers.
5111 (Vtemp_buffer_show_specifiers): Remove unused variable.
5112
c2ff3c02
EZ
51132011-10-30 Eli Zaretskii <eliz@gnu.org>
5114
5115 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5116 past the beginning of the current glyph matrix.
5117
58179cce 51182011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5119
5120 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5121 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5122 HAVE_GTK3 (Bug#9869).
b77a6a7f 5123
3b574623
JD
5124 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5125 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5126
b77a6a7f
JD
5127 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5128
5129 * xterm.c: Declare x_handle_net_wm_state to return int.
5130 (handle_one_xevent): Check if we are iconified but don't have
5131 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5132 (get_current_wm_state): Return non-zero if not hidden,
5133 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5134 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5135 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5136 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5137
196e41e4
PE
51382011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5139
5140 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5141 so that this new function doesn't get optimized away by a
5142 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5143
021f2e1a
AS
51442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5145
5146 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5147
8b058d44
EZ
51482011-10-29 Eli Zaretskii <eliz@gnu.org>
5149
5150 Fix the `xbytecode' command.
5151 * .gdbinit (xprintbytestr): New command.
b50a28de 5152 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5153 (xbytecode): Print the byte-code string as well.
5154
4452fb80
EZ
51552011-10-29 Kim Storm <storm@cua.dk>
5156
8b058d44
EZ
5157 * alloc.c (which_symbols): New function.
5158
21b72067
AS
51592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5160
5161 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5162 line. (Bug#9903)
5163
83ed7b5c
GM
51642011-10-29 Glenn Morris <rgm@gnu.org>
5165
5166 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5167 Not clear what it was for, and it causes various bugs. (Bug#9839)
5168
5a7a728b
EZ
51692011-10-28 Eli Zaretskii <eliz@gnu.org>
5170
5171 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5172 possible random value that matches one of those tested as
5173 condition to clear the mouse face.
5174
d3d0842f
CY
51752011-10-28 Chong Yidong <cyd@gnu.org>
5176
5177 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5178
31b39d13
DN
51792011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5180
5181 * window.c (make_window): Initialize phys_cursor_on_p.
5182
9aba6043
SM
51832011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5184
5185 * lisp.h (struct Lisp_Symbol): Update comments.
5186
c20992f4
JB
51872011-10-28 Juanma Barranquero <lekktu@gmail.com>
5188
5189 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5190
db4f02f2
EZ
51912011-10-28 Eli Zaretskii <eliz@gnu.org>
5192
5193 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5194 <oslsachem@gmail.com> for helping to debug this.
5195
5196 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5197 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5198 (g_b_init_get_glyph_outline_w): New static variables.
5199 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5200 (GetGlyphOutlineW_Proc): New typedefs.
5201 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5202 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5203 New functions.
5204 (w32font_open_internal, compute_metrics):
5205 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5206 instead of calling the "wide" APIs directly.
5207
5208 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5209
5210 * w32.h (syms_of_w32font): Add prototype.
5211
87e68db4
JB
52122011-10-27 Juanma Barranquero <lekktu@gmail.com>
5213
5214 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5215 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5216 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5217 (Fmove_to_window_line): Doc fix.
5218
435c1d67
CY
52192011-10-27 Chong Yidong <cyd@gnu.org>
5220
5221 * process.c (make_process): Set gnutls_state to NULL.
5222
5223 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5224 non-NULL, regardless of GNUTLS_INITSTAGE.
5225 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5226 an error. Set process slots as soon as we allocate them.
5227
5228 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5229
9c6c6f49
CY
52302011-10-27 Chong Yidong <cyd@gnu.org>
5231
9aba6043
SM
5232 * gnutls.c (emacs_gnutls_deinit): New function.
5233 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5234 (Fgnutls_deinit, Fgnutls_boot): Use it.
5235
5236 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5237 (deactivate_process): Call emacs_gnutls_deinit.
5238
657d08d3
JB
52392011-10-27 Juanma Barranquero <lekktu@gmail.com>
5240
5241 * image.c (x_create_x_image_and_pixmap):
5242 * w32.c (sys_rename, w32_delayed_load):
5243 * w32font.c (fill_in_logfont):
5244 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5245
5430d399
JB
52462011-10-26 Juanma Barranquero <lekktu@gmail.com>
5247
5248 * w32fns.c (w32_default_color_map): New function,
5249 extracted from Fw32_default_color_map.
a7ef684b 5250 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5251
fe0055fa
PE
52522011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5255
e6346438
SM
52562011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5257
5258 * keyboard.c (test_undefined): New function (bug#9751).
5259 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5260
e112cc37
ET
52612011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5262
5263 * sysdep.c (init_sys_modes): Fix the check for the controlling
5264 terminal (Bug#6649).
5265
7b5d6677
EZ
52662011-10-20 Eli Zaretskii <eliz@gnu.org>
5267
5268 * dispextern.h (struct bidi_it): New member next_en_type.
5269
5270 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5271 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5272 current character, check also for next_en_type being WEAK_EN.
5273 (bidi_resolve_weak): Don't enter the expensive loop if the current
5274 position is before next_en_pos. Record the bidi type of the first
5275 non-ET, non-BN character we find, in addition to its position.
5276 (bidi_level_of_next_char): Invalidate next_en_type when
5277 next_en_pos is over-stepped.
5278
7da0b018
PE
52792011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5282 * editfns.c: Rewrite current-time-zone so that it invokes
5283 the equivalent of (format-time-string "%Z") to get the time zone name.
5284 This fixes a bug when the time zone name contains characters that
5285 need converting from the system time locale to Emacs internal format.
5286 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5287 that patch fixed format-time-string to do the conversion, but
5288 I forgot to fix current-time-zone.
5289 (format_time_string): New function, containing most of
5290 what Fformat_time_string used to contain.
5291 (Fformat_time_string): Rewrite in terms of format_time_string.
5292 This doesn't change this function's behavior.
5293 (current-time-zone): Rewrite to use format_time_string.
5294 This fixes the bug reported by Michael Schierl in
5295 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5296 Jason Rumney's 2007-06-07 change worked around this bug, but
5297 didn't fix it.
5298 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5299
8547b010
EZ
53002011-10-19 Eli Zaretskii <eliz@gnu.org>
5301
5302 * xdisp.c (start_display): If the character at POS is displayed
5303 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5304 (try_window_reusing_current_matrix): If a line ends in a display
5305 vector or the next line starts in a display vector, continue
5306 redrawing the window even though the character position of
5307 start_row was reached.
8547b010
EZ
5308 (Bug#9771, part 2)
5309
4e948d15
CY
53102011-10-18 Chong Yidong <cyd@gnu.org>
5311
5312 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5313 with nobreak-char-display too.
5314
4787455f
EZ
53152011-10-18 Eli Zaretskii <eliz@gnu.org>
5316
5317 Fix part 3 of bug#9771.
5318 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5319 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5320 non-neutral characters if the current character is a paragraph
5321 separator (a.k.a. Newline). This avoids running the same
5322 expensive loop twice, once when we consume the preceding newline
5323 and the other time when the line actually needs to be displayed.
5324 Avoid the loop when we see neutrals on the base embedding level
5325 following a character whose directionality is the same as the
5326 paragraph's. This avoids running the expensive loop when a line
5327 ends in a long sequence of neutrals, like control characters.
5328 Add assertion against STRONG_AL type. Slightly rearrange code
5329 that determines the type of a neutral given the first non-neutral
5330 that follows it.
5331 (bidi_level_of_next_char): Set next_en_pos to zero when
5332 invalidating its info.
5333
2c91f553
EZ
53342011-10-17 Eli Zaretskii <eliz@gnu.org>
5335
5336 * xdisp.c (push_display_prop): Determine whether to record string
5337 or buffer position by IT->string, not by IT->method. Allow
5338 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5339 (move_it_vertically_backward): Don't look for character position
5340 immediately after the newline when in a continuation line.
5341 (Bug#9771, part 1)
2c91f553 5342
c7b08b0d
MR
53432011-10-15 Martin Rudalics <rudalics@gmx.at>
5344
5345 * window.c (coordinates_in_window): Rewrite and delabelize
5346 vertical border check. (Bug#5357) (Bug#9618)
5347
6b02f655
SM
53482011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5349
5350 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5351 errors in XSetWindowBorder (bug#9310).
5352
81d40c92
DA
53532011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5354
5355 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5356 avoid crash when xmalloc overrun checking is enabled.
5357
d4172c3b
EZ
53582011-10-13 Eli Zaretskii <eliz@gnu.org>
5359
5360 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5361 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5362 cursor motion with <left> and <right> arrow keys.
5363
5364 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5365 some callers set that themselves.
5366
b00eea75
EZ
53672011-10-12 Eli Zaretskii <eliz@gnu.org>
5368
5369 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5370 display string and the previous row comes from the same string and
5371 is empty. (Bug#9739) (Bug#9738)
5372
8fe012c4
SM
53732011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5374
5375 * doc.c (get_doc_string): Encode file name (bug#9735).
5376
0074aef2
EZ
53772011-10-12 Eli Zaretskii <eliz@gnu.org>
5378
79beb178
EZ
5379 * bidi.c (bidi_level_of_next_char):
5380 * xdisp.c (get_visually_first_element): Remove old incorrect
5381 comments regarding the Unicode Line Separator character.
5382
0074aef2
EZ
5383 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5384
6e4b3fbe
DA
53852011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5386
5387 * alloc.c (Fgc_status): Do not access beyond zombies array
5388 boundary if nzombies > MAX_ZOMBIES.
5389 * alloc.c (dump_zombies): Add missing format specifier.
5390
0324f3af
PE
53912011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5392
b5525cac
PE
5393 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5394 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5395
0324f3af
PE
5396 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5397 Some packages use them to denote characters with modifiers.
5398
e9b5f888
AS
53992011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5400
5401 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5402 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5403 matching a pp-number. Rename parameter var to var1.
5404
127827c0
SM
54052011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5406
5407 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5408
c8fd3bd0
GM
54092011-10-08 Glenn Morris <rgm@gnu.org>
5410
5411 * callint.c (Fcall_interactively): Give a more explicit error for the
5412 'c' case with a non-character input. (Bug#8479)
5413
352ec8ff
EZ
54142011-10-08 Eli Zaretskii <eliz@gnu.org>
5415
03669ccb
EZ
5416 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5417 lines.
7061c986
EZ
5418 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5419 lines that are hscrolled on the left.
03669ccb 5420
352ec8ff
EZ
5421 * dispnew.c (buffer_posn_from_coords): Account for a possible
5422 presence of header-line. (Bug#4426)
5423
a66cfb1c
SM
54242011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5425
6b02f655
SM
5426 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5427 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5428
7c5ee88e
PE
54292011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5430
5431 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5432 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5433 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5434 this makes Emacs dump core during garbage collection on rare
5435 occasions. sizeof is obviously inferior to offsetof here, so
5436 stick with offsetof.
5437 (GC_POINTER_ALIGNMENT): New macro.
5438 (mark_memory): Omit 3rd (offset) arg; caller changed.
5439 Don't assume EMACS_INT alignment is the same as pointer alignment.
5440
df1bbe5b
SM
54412011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5442
5443 * keyboard.c (read_key_sequence_remapped): New var.
5444 (read_key_sequence): Compute remapping in the right buffer.
5445 (command_loop_1): Use read_key_sequence's remapping directly.
5446
51553db6
SM
54472011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5448
32c1fffd
SM
5449 * dired.c (file_name_completion): Don't expand file name.
5450 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5451 before checking file name handler.
5452
51553db6
SM
5453 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5454 they've been requested explicitly (bug#9591).
5455
b6bd1599 54562011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5457
5458 * keymap.c (Fsingle_key_description): Use make_specified_string
5459 instead of build_string to build string from push_key_description.
5460 (Bug#5193)
5461
f701dc2a
PE
54622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5463
4222c55d
PE
5464 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5465 This fixes a Y2038 bug on 64-bit hosts.
5466 * buffer.c (reset_buffer):
5467 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5468 (Fclear_buffer_auto_save_failure):
5469 Use 0, not -1, to represent an unset failure time, since time_t
5470 might not be signed.
5471
f701dc2a
PE
5472 Remove dependency on glibc malloc internals.
5473 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5474 Move back here from lisp.h, but with their new implementations.
5475 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5476 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5477 * charset.c (charset_table_init): New static var.
5478 (syms_of_charset): Use it instead of xmalloc. This removes a
5479 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5480 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5481 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5482 Move back to alloc.c.
5483 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5484 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5485
9ceebf39
JD
54862011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5487
5488 * nsterm.m (windowDidResize): Call x_set_window_size only when
5489 ns_in_resize is true. Otherwise set pixelwidth/height and
5490 call change_frame_size (Bug#9628).
5491
cb993c58
PE
54922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5493
3930c88b
PE
5494 Port --enable-checking=all to Fedora 14 x86-64.
5495 * charset.c (syms_of_charset): Also account for glibc malloc's
5496 internal overhead when calculating the initial malloc maximum.
5497
cb993c58
PE
5498 Port --enable-checking=all to Fedora 14 x86.
5499 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5500 Move to lisp.h.
5501 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5502 (overrun_check_realloc, overrun_check_free):
5503 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5504 That way, xmalloc returns a properly-aligned pointer even if
5505 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5506 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5507 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5508 into account when calculating the initial malloc maximum.
5509 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5510 Move here from alloc.c, so that charset.c can use it too.
5511 Properly align; the old code wasn't right for common 32-bit hosts
5512 when configured with --enable-checking=all.
5513 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5514 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5515
31bed486
EZ
55162011-09-29 Eli Zaretskii <eliz@gnu.org>
5517
04c70788 5518 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5519 use EDOM.
5520
fbcaa2f3
EZ
55212011-09-28 Eli Zaretskii <eliz@gnu.org>
5522
5523 * xdisp.c (compute_display_string_end): If there's no display
5524 string at CHARPOS, return -1.
5525
5526 * bidi.c (bidi_fetch_char): When compute_display_string_end
5527 returns a negative value, treat the character as a normal
5528 character not covered by a display string. (Bug#9624)
5529
a239d4e9
JB
55302011-09-28 Juanma Barranquero <lekktu@gmail.com>
5531
5532 * lread.c (Fread_from_string): Fix typo in docstring.
5533
88652fd5
EZ
55342011-09-27 Eli Zaretskii <eliz@gnu.org>
5535
5536 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5537 newline, reseat the iterator instead of bidi-iterating there one
5538 character at a time. (Bug#9610)
32c1fffd
SM
5539 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5540 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5541
ed497dd4
AS
55422011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5543
5544 * lread.c (readevalloop): Use correct code for NBSP.
5545 (read1): Likewise. (Bug#9608)
5546
b2bf61aa
MA
55472011-09-25 Michael Albinus <michael.albinus@gmx.de>
5548
5549 * dbusbind.c (Fdbus_register_signal): When service is not
5550 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5551
32bbb17c
GM
55522011-09-25 Glenn Morris <rgm@gnu.org>
5553
5554 * buffer.c (truncate-lines): Doc fix.
5555
94e0933e
CY
55562011-09-24 Chong Yidong <cyd@stupidchicken.com>
5557
5558 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5559 (Fset_window_next_buffers): Doc fix.
5560
cddde921
GM
55612011-09-24 Glenn Morris <rgm@gnu.org>
5562
5563 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5564
1260aef1
PE
55652011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5566
25b4bfa0
PE
5567 Fix minor problems found by static checking.
5568 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5569 * indent.c (Fvertical_motion): Fix == vs = typo.
5570
e3cbd34b
EZ
55712011-09-24 Eli Zaretskii <eliz@gnu.org>
5572
a66cfb1c
SM
5573 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5574 Default value is now t. Doc fix.
6bf7006f 5575
e3cbd34b 5576 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5577 logic when moving up, not only when moving down. Fix the
e3cbd34b 5578 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5579 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5580
5581 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5582 CHARPOS is covered by a display string which includes newlines.
5583 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5584 is covered by a display string with embedded newlines.
5585
a3de0cbd
MA
55862011-09-24 Michael Albinus <michael.albinus@gmx.de>
5587
5588 * dbusbind.c (Fdbus_register_signal): Add match rule to
5589 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5590 (Fdbus_register_method, Vdbus_registered_objects_table):
5591 Fix docstring.
a3de0cbd 5592
b260039d
JM
55932011-09-24 Jim Meyering <meyering@redhat.com>
5594
32c1fffd 5595 do not ignore write error for any output size
b260039d
JM
5596 The previous change was incomplete.
5597 While it makes emacs --batch detect the vast majority of stdout
5598 write failures, errors were still ignored whenever the output size is
5599 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5600 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5601 && echo FAIL: ignored write error
5602 FAIL: ignored write error
5603 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5604 && echo FAIL: ignored write error
5605 FAIL: ignored write error
5606 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5607
8eca8a7c
AS
56082011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5609
5610 * emacs.c (Fkill_emacs): In noninteractive mode exit
5611 non-successfully if a write error occurred on stdout. (Bug#9574)
5612
3341db62
EZ
56132011-09-21 Eli Zaretskii <eliz@gnu.org>
5614
5615 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5616 the xassert test.
5617
5618 * dispextern.h (struct it): Update the comment documenting what
5619 can it->OBJECT be.
5620
8c203dbf
EZ
56212011-09-20 Eli Zaretskii <eliz@gnu.org>
5622
5623 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5624 a display string, extend search for cursor position to end of row.
5625 (find_row_edges): If the row ends in a newline from a display
5626 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5627 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5628 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5629 non-empty line. Fixes confusing cursor motion with arrow keys at
5630 the beginning of a line that starts with whitespace.
8c203dbf 5631
a4824228
LMI
56322011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5633
5634 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5635 (bug#9493).
5636
33ed493b
CY
56372011-09-18 Chong Yidong <cyd@stupidchicken.com>
5638
5639 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5640 boolean (Bug#9154).
5641
56cd55c8
EZ
56422011-09-18 Eli Zaretskii <eliz@gnu.org>
5643
5644 * xdisp.c (display_line): Record maximum and minimum buffer
5645 positions even if no glyphs were produced (e.g., by a zero-width
5646 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5647 buffer positions that will be removed from the glyph row because
5648 they don't fit.
c02dcedf
EZ
5649 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5650 column is beyond frame width: don't subtract 1 "pixel" when
5651 computing width of the stretch.
3e62b7e0
EZ
5652 (reseat_at_next_visible_line_start): Undo the change made on
5653 2011-09-17 that saved paragraph information and restored it after
5654 the call to `reseat'. (Bug#9545)
56cd55c8 5655
5ed99d36 56562011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5657
5658 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5659 and turn window cursor on if cleared (Bug#9415).
5660
5ed99d36 56612011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5662
5663 * search.c (boyer_moore): Take unibyte characters from pattern
5664 literally. (Bug#9458)
5665
9bade7b2
EZ
56662011-09-18 Eli Zaretskii <eliz@gnu.org>
5667
5668 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5669
e5e9d610
PE
56702011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5671
87e4427a
PE
5672 Fix minor problem found by static checking.
5673 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5674 initialized, to pacify gcc -Wuninitialized.
5675
e5e9d610
PE
5676 * fileio.c: Report proper errno when syscall falls.
5677 (Finsert_file_contents): Save and restore errno,
5678 so that report_file_error outputs the correct diagnostic.
5679 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5680
a1674f0b
EZ
56812011-09-18 Eli Zaretskii <eliz@gnu.org>
5682
5683 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5684
fbfb6dd4
EZ
56852011-09-17 Eli Zaretskii <eliz@gnu.org>
5686
5687 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5688 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5689
bb187662
EZ
56902011-09-17 Eli Zaretskii <eliz@gnu.org>
5691
1137e8b8 5692 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5693 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5694
5695 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5696 (bidi_find_paragraph_start): Search back for paragraph beginning
5697 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5698 (bidi_move_to_visually_next): Only trigger paragraph-related
5699 computations when the last character is a newline or at EOB, not
5700 just any NEUTRAL_B. (Bug#9470)
5701
bb187662
EZ
5702 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5703 truncated lines if point is covered by a display string. (Bug#9524)
5704
2e621251
PE
57052011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5706
5707 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5708 (cons_to_x_long): New function.
5709 (lisp_data_to_selection_data): Use it. Correct the test for
5710 short-versus-long data; it was negated. Break out of vector
5711 loop, for efficiency, when a long datum is discovered.
5712
91a15bc6
SM
57132011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5714
5715 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5716
b41c3a35
EZ
57172011-09-16 Eli Zaretskii <eliz@gnu.org>
5718
5719 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5720 GCC PR/17406) by declaring this function with external scope.
5721
7812ba2d
PE
57222011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5725 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5726
cf7edc2a
AS
57272011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5728
5729 * editfns.c (Fformat): Correctly handle text properties on "%%".
5730
bd01620e
EZ
57312011-09-15 Eli Zaretskii <eliz@gnu.org>
5732
5733 * xterm.c (x_draw_composite_glyph_string_foreground):
5734 * w32term.c (x_draw_composite_glyph_string_foreground):
5735 * term.c (encode_terminal_code):
5736 * composite.c (composition_update_it, get_composition_id):
5737 * xdisp.c (get_next_display_element)
5738 (fill_composite_glyph_string): Add comments about special meaning
5739 of TAB characters in a composition.
5740
a02719a3
PE
57412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5742
5743 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5744 This occurs when processing a multibyte format.
5745 Problem reported by Wolfgang Jenker.
a02719a3 5746
72589a3c
JB
57472011-09-15 Johan Bockgård <bojohan@gnu.org>
5748
5749 * xdisp.c (try_cursor_movement): Only check for exact match if
5750 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5751
1c14176c
PE
57522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5753
5754 Remove unused external symbols.
5755 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5756 * xdisp.c (calc_pixel_width_or_height): Now static.
5757 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5758 * indent.c (check_display_width):
5759 * w32term.c: Fix comment to match code.
5760 * xterm.c, xterm.h (x_catching_errors): Remove.
5761
d2eea5b5
PE
57622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5763
5764 * xselect.c: Use signed conversions more consistently (Bug#9498).
5765 (selection_data_to_lisp_data): Assume incoming selection data are
5766 signed integers, not unsigned. This is to be consistent with
5767 outgoing selection data, which was modified to use signed integers
5768 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5769 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5770 expects long, not unsigned long.
5771
46888499
EZ
57722011-09-14 Eli Zaretskii <eliz@gnu.org>
5773
5774 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5775 computation of loop end. Reported by Johan Bockgård
5776 <bojohan@gnu.org>.
5777
ef8ef9fb
CY
57782011-09-13 Chong Yidong <cyd@stupidchicken.com>
5779
5780 * frame.c (Fother_visible_frames_p): Function deleted.
5781
fa819fed
EZ
57822011-09-12 Eli Zaretskii <eliz@gnu.org>
5783
5784 * indent.c (compute_motion): Process display vector front to back
5785 rather than the other way around. (Bug#2496)
5786
2ba8e008
SM
57872011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5788
5789 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5790
20f53c69
CY
57912011-09-11 Chong Yidong <cyd@stupidchicken.com>
5792
5793 * minibuf.c (Fread_from_minibuffer): Doc fix.
5794
d562d7a4
EZ
57952011-09-11 Eli Zaretskii <eliz@gnu.org>
5796
5797 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5798 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5799
1c4d7f3d
LMI
58002011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5801
5802 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5803 value for non-existent files.
5804
b885bf36
EZ
58052011-09-11 Eli Zaretskii <eliz@gnu.org>
5806
5807 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5808 set its "size" to -1. This will set the modtime_size field of
5809 the corresponding buffer to -1, which is what
5810 verify-visited-file-modtime expects for files that do not exist.
5811 (Bug#9139)
5812
6612f0bf
PE
58132011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5814
5815 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5816 here ...
5817 * lisp.h: ... from here. push_key_description is no longer
5818 defined in keyboard.c, so its declaration should not be in
5819 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5820 logically belongs with push_key_description.
5821
dfb3f755
PE
58222011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5823
5824 * buffer.h: Include <sys/types.h> instead of <time.h>.
5825 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5826 Problem reported by Herbert J. Skuhra.
5827
3134906c
LMI
58282011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5829
5830 * xml.c (parse_region): Make the parsing work for
5831 non-comment-starting XML files again (bug#9144).
5832
8d903f4e
AS
58332011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5834
5835 * image.c (gif_load): Fix calculation of bottom and right corner.
5836 (Bug#9468)
5837
80ad64f4
EZ
58382011-09-10 Eli Zaretskii <eliz@gnu.org>
5839
5840 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5841 redisplay in small windows.
5842
208a048d
EZ
58432011-09-09 Eli Zaretskii <eliz@gnu.org>
5844
5845 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5846
9b1c252e
MR
58472011-09-08 Martin Rudalics <rudalics@gmx.at>
5848
5849 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5850 Operate on live windows only.
5851
2949f33b
JB
58522011-09-08 Juanma Barranquero <lekktu@gmail.com>
5853
5854 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5855
e08dcafd
EZ
58562011-09-07 Eli Zaretskii <eliz@gnu.org>
5857
5858 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5859 only under bidi iteration.
5860
115b96bd
JD
58612011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5862
5863 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5864
c8199d0f
PE
58652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5866
5867 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5868 Without this fix, the command to link temacs failed due to an
5869 undefined symbol __builtin_isnan. This is because
5870 /usr/include/iso/math_c99.h #defines isnan(x) to
5871 __builtin_isnan(x), but the bundled gcc, which identifies itself
5872 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5873 a __builtin_isnan.
5874 * floatfns.c (isnan): #undef, and then #define to a clone of
5875 what's in data.c.
5876 (Fisnan): Always define, since it's always available now.
5877 (syms_of_floatfns): Always define isnan at the Lisp level.
5878
e39b275c 58792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5880
5881 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5882
b2db44d9 58832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5884
f4af5137 5885 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5886 The previous code assumed that file offsets (off_t values) fit in
5887 EMACS_INT variables, which is not true on typical 32-bit hosts.
5888 The code messed up by falsely reporting buffer overflow in cases
5889 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5890 when "big" contains more than 2**29 bytes, even though this
5891 inserts just one byte and does not overflow the buffer.
5892 (Finsert_file_contents): Store file offsets as off_t
5893 values, not as EMACS_INT values. Check for overflow when
5894 converting between EMACS_INT and off_t. When checking for
5895 buffer overflow or for overlap, take the offsets into account.
5896 Don't use EMACS_INT for small values where int suffices.
5897 When checking for overlap, fix a typo: ZV was used where
5898 ZV_BYTE was intended.
5899 (Fwrite_region): Don't assume off_t fits into 'long'.
5900 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5901
ecfc0a49
MA
59022011-09-05 Michael Albinus <michael.albinus@gmx.de>
5903
5904 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5905
6511acf2 59062011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5907
0999621a 5908 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5909
5910 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5911 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5912 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5913 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5914 (modify_event_symbol): Do not assume that the length of
5915 name_alist_or_stem is safe to alloca and fits in int.
5916 (Fexecute_extended_command): Likewise for function name and binding.
5917 (Frecursion_depth): Wrap around reliably on integer overflow.
5918 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5919 since some callers pass EMACS_INT values.
5920 (Fsingle_key_description): Don't crash if symbol name contains more
5921 than MAX_ALLOCA bytes.
5922 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5923 (get_minibuffer): Arg is now EMACS_INT, not int.
5924 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5925 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5926 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5927
2be7d702
PE
5928 * dbusbind.c (signature_cat): New function.
5929 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5930 Do not overrun buffer; instead, report string overflow.
5931
9d1df220
PE
5932 * dispnew.c (add_window_display_history): Don't overrun buffer.
5933 Truncate instead; this is OK since it's just a log.
5934
33ef5c64
PE
5935 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5936 even if the time zone offset is outlandishly large.
5937 Don't mishandle offset == INT_MIN.
5938
66c6fdd5
PE
5939 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5940 when creating daemon; the previous buffer-overflow check was incorrect.
5941
d749b01b
PE
5942 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5943 which has the guts of the old verror function.
5944
b5cd1905
PE
5945 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5946 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5947
6e1a67fb
PE
5948 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5949 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5950 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5951 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5952 length of string rather than counting it via multiple sprintfs;
5953 that's simpler and more reliable.
c21721cc
PE
5954 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5955 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5956 sprintf, in case result does not fit in int.
5957
c57b67fc
PE
5958 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5959 (fontset_from_font): Print it.
5960
8a401434
PE
5961 * frame.c (tty_frame_count): Now printmax_t, not int.
5962 (make_terminal_frame, set_term_frame_name): Print it.
5963 (x_report_frame_params): In X, window IDs are unsigned long,
5964 not signed long, so print them as unsigned.
5965 (validate_x_resource_name): Check for implausibly long names,
5966 and don't assume name length fits in 'int'.
5967 (x_get_resource_string): Don't blindly alloca invocation name;
5968 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5969 not fit in int.
5970
6e1a67fb
PE
5971 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5972 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5973 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5974
0df02bf3
PE
5975 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5976 Use esprintf, not sprintf, in case result does not fit in int.
5977
48e30793
PE
5978 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5979 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5980 it as a large positive number.
5981 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5982 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5983
a66ff6d8
PE
5984 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5985 in case result does not fit in int.
5986
aca216ff
PE
5987 * print.c (float_to_string): Detect width overflow more reliably.
5988 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5989 buffer overrun. Don't assume list length fits in 'int'. Treat
5990 print length of 0 as 0, not as infinity; to be consistent with other
5991 uses of print length in this function. Don't overflow print length
5992 index. Don't assume hash table size fits in 'long', or that
5993 vectorlike size fits in 'unsigned long'.
5994
31c286f7
PE
5995 * process.c (make_process): Use printmax_t, not int, to format
5996 process-name gensyms.
5997
55e5faa1
PE
5998 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5999
80f2e268
PE
6000 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6001 to avoid potential buffer overrun.
6002
670741ab
PE
6003 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6004 if X resource line is longer than 512 bytes.
6005
b7163a50
PE
6006 * xfns.c (x_window): Make sprintf buffer a bit bigger
6007 to avoid potential buffer overrun.
6008
ae58ff1f
PE
6009 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6010
c43c8a6a
PE
6011 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6012
3f8236f4
PE
60132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6014
53e9fe90 6015 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6016 Without these, Emacs silently mishandles large integers sometimes.
6017 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6018 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6019
6511acf2
PE
6020 * xdisp.c (try_window_id): Check Emacs fixnum range before
6021 converting to 'int'.
806add1d 6022
6511acf2 6023 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6024 Check that an Emacs fixnum is in range before assigning it to 'int'.
6025 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6026 values converted from Emacs fixnums.
6027 (Frecenter): Don't wrap around a line count if it is out of 'int'
6028 range; instead, treat it as an extreme value.
6029 (Fset_window_configuration, compare_window_configurations):
6030 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6031
6511acf2
PE
6032 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6033 that can exceed INT_MAX. Check that EMACS_INT value is in range
6034 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6035 (match_limit): Don't assume that a fixnum can fit in 'int'.
6036
6511acf2 6037 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6038 exceed INT_MAX.
6039
6511acf2 6040 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6041 (Fvertical_motion): Don't wrap around LINES values that don't fit
6042 in 'int'. Instead, treat them as extreme values. This is good
6043 enough for windows, which can't have more than INT_MAX lines anyway.
6044
fcb901a7
LMI
60452011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6046
0f2f6b6d
LMI
6047 * Require libxml/parser.h to avoid compilation warning.
6048
fcb901a7
LMI
6049 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6050
6051 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6052 since this reportedly can destroy thread storage.
6053
6e20a0d4
CY
60542011-08-30 Chong Yidong <cyd@stupidchicken.com>
6055
6056 * syntax.c (find_defun_start): Update all cache variables if
6057 exiting early (Bug#9401).
6058
148ae00e
EZ
60592011-08-30 Eli Zaretskii <eliz@gnu.org>
6060
f6cfbd8f
EZ
6061 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6062
148ae00e
EZ
6063 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6064 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6065 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6066
6067 * term.c (tty_append_glyph): New function.
6068 (produce_stretch_glyph): Static function and its prototype deleted.
6069
a66cfb1c
SM
6070 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6071 Add prototypes.
148ae00e 6072
c4a07a4c
PE
60732011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6074
6075 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6076 when checking :margin (Bug#9390).
6077 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6078 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6079 so that the name doesn't mislead. All uses changed.
6080
6bc8cd65
JB
60812011-08-28 Johan Bockgård <bojohan@gnu.org>
6082
6083 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6084 set_tty_hooks.
6085
dca4927e
EZ
60862011-08-27 Eli Zaretskii <eliz@gnu.org>
6087
6088 * xdisp.c (move_it_to): Don't bail out early when reaching
6089 position beyond to_charpos, if we are scanning backwards.
6090 (move_it_vertically_backward): When DY == 0, make sure we get to
6091 the first character in the line after the newline.
6092
f2cad773
PE
60932011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6094
6095 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6096 (ccl_driver): Do not generate an out-of-range pointer.
6097 (Fccl_execute_on_string): Remove unnecessary check for
6098 integer overflow, noted by Stefan Monnier in
6099 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6100 Remove a FIXME that didn't need fixing.
6101 Simplify the newly-introduced buffer reallocation code.
6102
0cae2cdb
JB
61032011-08-27 Juanma Barranquero <lekktu@gmail.com>
6104
6105 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6106
5fc295a4 61072011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6108
70c60eb2 6109 Integer and memory overflow issues (Bug#9196).
726e0ab1 6110
d31850da
PE
6111 * doc.c (get_doc_string): Rework so that
6112 get_doc_string_buffer_size is the actual buffer size, rather than
6113 being 1 less than the actual buffer size; this makes xpalloc more
6114 convenient.
6115
a69fbedb
PE
6116 * image.c (x_allocate_bitmap_record, cache_image):
6117 * xselect.c (Fx_register_dnd_atom):
6118 Simplify previous changes by using xpalloc.
6119
fe5c5d37
PE
6120 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6121 since either will do and ptrdiff_t is convenient with xpalloc.
6122
0065d054
PE
6123 * charset.c (charset_table_size)
6124 (struct charset_sort_data.priority): Now ptrdiff_t.
6125 (charset_compare): Don't overflow if priorities differ greatly.
6126 (Fsort_charsets): Don't assume list length fits in int.
6127 Check for size-calculation overflow when allocating sort data.
6128 (syms_of_charset): Allocate an initial charset table that is
6129 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6130
6131 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6132
6133 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6134 The actual value is always <= INT_MAX, and leaving it unsigned made
6135 overflow checking harder.
6136
6137 * dispextern.h (struct glyph_matrix.rows_allocated)
6138 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6139 with xpalloc. The values are still always <= INT_MAX.
6140
6141 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6142
6143 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6144 (SAFE_NALLOCA): New macro.
6145
6146 * region-cache.c (struct boundary.pos, find_cache_boundary)
6147 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6148 (set_cache_region, invalidate_region_cache)
6149 (revalidate_region_cache, know_region_cache, region_cache_forward)
6150 (region_cache_backward, pp_cache):
6151 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6152 so that ptrdiff_t * can be passed to xpalloc.
6153 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6154 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6155 (pp_cache): Don't assume cache_len fits in int.
6156 * region-cache.h: Adjust extern decls to match.
6157
6158 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6159 EMACS_INT, since either will do, for xpalloc.
6160
6161 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6162 (xnmalloc, xnrealloc, xpalloc): New functions.
6163
726e0ab1
PE
6164 * bidi.c (bidi_shelve_header_size): New constant.
6165 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6166 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6167
51f30bc5 6168 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6169 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6170 (overlay_strings):
6171 Don't update size of array until after memory allocation succeeds,
6172 because xmalloc/xrealloc may not return.
0065d054
PE
6173 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6174 now that we have proper integer overflow checking.
6175 (record_overlay_string, overlay_strings): Catch overflows when
6176 calculating size of overlay_str_buf.
726e0ab1 6177
0065d054
PE
6178 * callproc.c (Fcall_process): Check for size overflow when
6179 calculating size of args2.
6180 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6181 Normally we prefer signed values, but sticking with ptrdiff_t would
6182 require adding more-complicated checks.
726e0ab1
PE
6183
6184 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6185 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6186 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6187 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6188
6189 * character.c (Fstring): Check for size-calculation overflow.
6190
6191 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6192 unnecessary integer overflow. Check for size overflow.
6193 (encode_coding_object): Don't update size until xmalloc succeeds.
6194
6195 * composite.c (get_composition_id): Check for overflow in glyph
6196 length calculations.
6197
6198 Integer and memory overflow fixes for display code.
6199 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6200 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6201 (scrolling_window): Check for overflow in size calculations.
6202 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6203 Don't assume glyph table len fits in int.
6204 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6205 (row_table_size): Now ptrdiff_t, not int.
6206 (scrolling_window): Avoid overflow in size calculations.
6207 Don't update size until allocation succeeds.
6208 * fns.c (concat): Check for overflow in size calculations.
6209 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6210 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6211 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6212
6213 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6214 (get_doc_string): Check for size calculation overflow.
6215 Don't update size until allocation succeeds.
6216 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6217 EMACS_INT, where ptrdiff_t will do.
6218 (Fsubstitute_command_keys): Check for string overflow.
6219
6220 * editfns.c (set_time_zone_rule): Don't assume environment length
6221 fits in int.
6222 (message_length): Now ptrdiff_t, not int.
6223 (Fmessage_box): Don't update size until allocation succeeds.
6224 Don't assume message length fits in int.
6225 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6226
0065d054
PE
6227 * emacs.c (main): Do not reallocate argv, since there is a null at
6228 the end that can be overwritten, and this way there's no need to
6229 worry about size-calculation overflow.
6230 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6231
6232 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6233 alloc succeeds.
6234 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6235
6236 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6237 (x_set_scroll_bar_width, x_figure_window_size):
6238 Check for integer overflow.
6239 (x_set_alpha): Do not assume XINT fits in int.
6240
6241 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6242 This is for the members text_lines, text_cols, total_lines, total_cols,
6243 where the system imposes an 'int' limit.
6244
6245 * fringe.c (Fdefine_fringe_bitmap):
6246 Don't update size until alloc works.
6247
6248 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6249 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6250
6251 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6252 Check for size-calculation overflow.
6253 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6254 do, as we prefer signed integers.
6255 (id_to_widget.max_size, id_to_widget.used)
6256 (xg_store_widget_in_map, xg_remove_widget_from_map)
6257 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6258 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6259 Use and return ptrdiff_t, not int.
6260 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6261 * gtkutil.h: Change prototypes to match the above.
6262
6263 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6264 are duplicate now that they've been promoted to lisp.h.
6265 (x_allocate_bitmap_record, x_alloc_image_color)
6266 (make_image_cache, cache_image, xpm_load):
6267 Don't update size until alloc is done.
6268 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6269 (x_detect_edges):
3256efce 6270 Check for size calculation overflow.
726e0ab1
PE
6271 (ct_colors_allocated_max): New constant.
6272 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6273 overflow.
3256efce 6274
726e0ab1
PE
6275 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6276 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6277 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6278 Use ptrdiff_t, not int, to count maps.
6279 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6280 calculations. Don't update size until allocation succeeds.
6281 Redo calculations to avoid overflow.
726e0ab1
PE
6282 * keyboard.h: Change prototypes to match the above.
6283
6284 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6285 to count maps.
6286 (current_minor_maps): Check for size calculation overflow.
6287 * keymap.h: Change prototypes to match the above.
6288
6289 * lread.c (read1, init_obarray): Don't update size until alloc done.
6290
6291 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6292 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6293
726e0ab1
PE
6294 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6295 Now ptrdiff_t, not int.
6296 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6297 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6298
6299 * process.c (Fnetwork_interface_list): Check for overflow
6300 in size calculation.
6301
6302 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6303
6304 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6305 overflow. Don't bother calling xmalloc when xrealloc will do.
6306
6307 * search.c (Freplace_match): Check for size calculation overflow.
6308 (Fset_match_data): Don't assume list lengths fit in 'int'.
6309
6310 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6311 for command line length. Do not attempt to address one before the
6312 beginning of an array, as that's not portable.
6313
6314 * term.c (max_frame_lines): Remove; unused.
6315 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6316 not int.
6317 (encode_terminal_code, calculate_costs): Check for size
6318 calculation overflow.
6319 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6320 table lengths and related sizes. Don't update size until alloc
6321 done. Redo calculations to avoid overflow.
6322 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6323
6324 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6325 subtracting pointers.
6326 (gobble_line): Check for overflow more carefully. Don't update size
6327 until alloc done.
6328
6329 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6330 Don't update size until alloc done.
6331 Redo size calculations to avoid overflow.
6332 Check for size calculation overflow.
0065d054 6333 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6334
6335 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6336 Use ptrdiff_t, not int, for sizes.
6337 (store_mode_line_noprop_char): Don't update size until alloc done.
6338
0065d054
PE
6339 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6340 Use ptrdiff_t, not int, for sizes.
6341 (Finternal_make_lisp_face, cache_face):
6342 Check for size calculation overflow.
6343 (cache_face): Treat size calculation overflows as if they were
6344 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6345
6346 * xfns.c (x_encode_text, x_set_name_internal)
6347 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6348 sizes, since they can exceed INT_MAX in size. Check for size
6349 calculation overflow.
6350
0065d054
PE
6351 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6352 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6353 Don't update size until alloc done.
6354
0065d054 6355 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6356 as sprintf is limited to int lengths.
1d526e2f 6357
252c5ee1
PE
6358 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6359 (X_LONG_MIN): New macros.
864d7ce7
PE
6360 Use them to make the following changes clearer.
6361 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6362 This change doesn't affect the value now, but it may help remind
6363 future maintainers not to raise the value too much later.
6364 (SELECTION_QUANTUM): Remove, replacing with ...
6365 (selection_quantum): ... new function, which avoids overflow.
6366 All uses changed.
6367 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6368 assumption that selection length fits in 'int'.
6369 (x_reply_selection_request, x_handle_selection_request)
6370 (x_get_window_property, receive_incremental_selection)
6371 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6372 (lisp_data_to_selection_data, clean_local_selection_data):
6373 Use ptrdiff_t, not int, to record length of selection.
6374 (x_reply_selection_request, x_get_window_property)
6375 (receive_incremental_selection, x_property_data_to_lisp):
6376 Redo calculations to avoid overflow.
6377 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6378 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6379 something.
6380 (x_get_window_property, receive_incremental_selection)
6381 (lisp_data_to_selection_data, x_property_data_to_lisp):
6382 Check for size-calculation overflow.
6383 (x_get_window_property, receive_incremental_selection)
6384 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6385 Don't store size until memory allocation succeeds.
6386 (x_get_window_property): Plug memory leak on memory exhaustion.
6387 Don't double-block input; malloc is safe here. Don't assume 2**34
6388 - 4 fits in unsigned long. Add an xassert to check
6389 XGetWindowProperty overflow. Be more careful about overflow
6390 calculations, and distinguish size from memory overflow better.
6391 (receive_incremental_selection): When tracing, don't assume
6392 unsigned int is less than INT_MAX.
6393 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6394 harmful) conversions of unsigned short to int.
6395 (lisp_data_to_selection_data): Don't assume that integers
6396 in the range -65535 through -1 fit in an X unsigned short.
6397 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6398 result parameters unless successful. Rely on cons_to_unsigned
6399 to report problems with elements; the old code wasn't right anyway.
6400 (x_check_property_data): Check for int overflow; we cannot use
6401 a wider type due to X limits.
6402 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6403
726e0ab1 6404 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6405
0065d054
PE
6406 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6407 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6408 (x_color_cells): Don't store size until memory allocation succeeds.
6409 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6410 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6411 (x_term_init): Don't assume length fits in int (sprintf is limited
6412 to int size).
bc18e09d 6413
ebfa62c0
PE
6414 Use ptrdiff_t for composition IDs.
6415 * character.c (lisp_string_width):
6416 * composite.c (composition_table_size, n_compositions)
6417 (get_composition_id, composition_gstring_from_id):
6418 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6419 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6420 * window.c (Frecenter):
6421 Use ptrdiff_t, not int, for composition IDs.
6422 * composite.c (get_composition_id): Check for integer overflow.
6423 * composite.h: Adjust prototypes to match the above changes.
6424
d3411f89
PE
6425 Use ptrdiff_t for hash table indexes.
6426 * category.c (hash_get_category_set):
6427 * ccl.c (ccl_driver):
6428 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6429 * coding.c (coding_system_charset_list, detect_coding_system):
6430 * coding.h (struct coding_system.id):
6431 * composite.c (get_composition_id, gstring_lookup_cache):
6432 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6433 * image.c (xpm_get_color_table_h):
6434 * lisp.h (hash_lookup, hash_put):
6435 * minibuf.c (Ftest_completion):
6436 Use ptrdiff_t for hash table indexes, not int (which is too
6437 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6438 32-bit --with-wide-int hosts).
6439
e097a6fa
PE
6440 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6441 Add a FIXME comment about memory leaks.
6442 (syms_of_charset): Don't assume xmalloc returns.
6443
5637687f
PE
6444 Don't assume that stated character widths fit in int.
6445 * character.c (Fchar_width, c_string_width, lisp_string_width):
6446 * character.h (CHAR_WIDTH):
6447 * indent.c (MULTIBYTE_BYTES_WIDTH):
6448 Use sanitize_char_width to avoid undefined and/or bad behavior
6449 with outlandish widths.
a66cfb1c 6450 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6451 now that we have two such functions. All uses changed.
6452 (sanitize_char_width): New inline function.
6453
a2271ba2
PE
6454 Don't assume that tab-width fits in int.
6455 * character.h (sanitize_width): New inline function.
6456 (SANE_TAB_WIDTH): New macro.
6457 (ASCII_CHAR_WIDTH): Use it.
6458 * indent.c (sane_tab_width): Remove. All uses replaced by
6459 SANE_TAB_WIDTH (current_buffer).
6460 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6461
18c52557
PE
6462 * fileio.c: Integer overflow issues with file modes.
6463 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6464
caeeedc1
PE
6465 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6466 Remove unreachable code.
6467 (read_hex, load_charset_map_from_file): Check for integer overflow.
6468
6df6ae42 6469 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6470 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6471 (x_send_scroll_bar_event): Likewise. Check that the size does not
6472 exceed limits imposed by XClientMessageEvent, as well as the usual
6473 ptrdiff_t and size_t limits.
6474
b13995db
PE
6475 * keyboard.c: Overflow, signedness and related fixes.
6476 (make_lispy_movement): Use same integer type in forward decl
6477 that is used in the definition.
6478 (read_key_sequence, keyremap_step):
6479 Change bufsize argument back to int, undoing my 2011-03-30 change.
6480 We prefer signed types, and int is wide enough here.
6481 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6482 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6483 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6484 length, not size_t. Use ptrdiff_t for index, not int.
6485 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6486 possibility of integer overflow.
6487
13464394
PE
6488 Overflow, signedness and related fixes for images.
6489
6490 * dispextern.h (struct it.stack[0].u.image.image_id)
6491 (struct_it.image_id, struct image.id, struct image_cache.size)
6492 (struct image_cache.used, struct image_cache.ref_count):
6493 * gtkutil.c (update_frame_tool_bar):
6494 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6495 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6496 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6497 * nsmenu.m (update_frame_tool_bar):
6498 * xdisp.c (calc_pixel_width_or_height):
6499 * xfns.c (image_cache_refcount):
6500 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6501 on typical 64-bit hosts.
6502
6503 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6504 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6505 Omit unnecessary casts to int.
6506 (parse_image_spec): Check that integers fall into 'int' range
6507 when the callers expect that.
6508 (image_ascent): Redo ascent calculation to avoid int overflow.
6509 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6510 (lookup_image): Remove unnecessary tests.
6511 (xbm_image_p): Locals are now of int, not EMACS_INT,
6512 since parse_image_check makes sure they fit into int.
6513 (png_load, gif_load, svg_load_image):
6514 Prefer int to unsigned where either will do.
6515 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6516 old tiff_error_handler and tiff_warning_handler.
6517 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6518 stack buffer overflows. It uses only the features of vsnprintf
6519 that are common to both POSIX and native Microsoft.
6520 (tiff_error_handler, tiff_warning_handler): Use it.
6521 (tiff_load, gif_load, imagemagick_load_image):
6522 Don't assume :index value fits in 'int'.
6523 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6524 (imagemagick_load_image): Check that crop parameters fit into
6525 the integer types that MagickCropImage accepts. Don't assume
6526 Vimagemagick_render_type has a nonnegative value. Don't assume
6527 size_t fits in 'long'.
6528 (gs_load): Use printmax_t to print the widest integers possible.
6529 Check for integer overflow when computing image height and width.
6530
c11821d4
EZ
65312011-08-26 Eli Zaretskii <eliz@gnu.org>
6532
6533 * xdisp.c (redisplay_window): Don't force window start if point
6534 will be invisible in the resulting window. (Bug#9324)
6535
0c95fcf7
EZ
65362011-08-25 Eli Zaretskii <eliz@gnu.org>
6537
6538 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6539 the display spec is of the form `(space ...)'.
6540 (handle_display_spec): Return the value returned by
6541 handle_single_display_spec, not just 1 or zero.
6542 (handle_single_display_spec): If the display spec is of the form
6543 `(space ...)', and specifies display in the text area, return 2
6544 rather than 1.
fee65a97 6545 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6546 accurately, and prefer exact match for point under bidi.
6547 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6548
6549 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6550 into disp_prop; all users changed.
6551
6552 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6553 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6554 for the text covered by the display property.
6555
e4ed06f1
CY
65562011-08-25 Chong Yidong <cyd@stupidchicken.com>
6557
6558 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6559 Change return value to nil.
6560 (Frecord_buffer): Delete unused function.
6561
f67cdd7f
EZ
65622011-08-24 Eli Zaretskii <eliz@gnu.org>
6563
5980d4c6
EZ
6564 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6565 buffers, return left-to-right.
8610fe8b
EZ
6566 (set_cursor_from_row): Consider candidate row a win if its glyph
6567 represents a newline and point is on that newline. Fixes cursor
6568 positioning on the newline at EOL of R2L text within L2R
6569 paragraph, and vice versa.
6570 (try_cursor_movement): Check continued rows, in addition to
6571 continuation rows. Fixes unwarranted scroll when point enters a
6572 continued line of R2L text within an L2R paragraph, or vice versa.
6573 (cursor_row_p): Consider the case of point being equal to
6574 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6575 from the end of a short line to the beginning of a continued line
6576 of R2L text within L2R paragraph.
6577 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6578 composed characters.
5980d4c6 6579
f67cdd7f
EZ
6580 * bidi.c (bidi_check_type): Use xassert.
6581 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6582 members.
6583
bca633fb
EZ
65842011-08-23 Eli Zaretskii <eliz@gnu.org>
6585
6586 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6587 a character.
6588
4a5885a7
CY
65892011-08-23 Chong Yidong <cyd@stupidchicken.com>
6590
6591 * nsfont.m (ns_otf_to_script): Fix typo.
6592
0902a04e
KH
65932011-08-22 Kenichi Handa <handa@m17n.org>
6594
6595 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6596 extra slot even if the purpose is char-code-property-table.
6597
1a2e6670
EZ
65982011-08-23 Eli Zaretskii <eliz@gnu.org>
6599
8ddde651
EZ
6600 * xdisp.c (redisplay_window): When computing centering_position,
6601 account for the height of the header line. (Bug#8874)
6602
425cc014
EZ
6603 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6604 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6605 candidate is selected by the mouse, and that candidate has a
6606 composed character under the mouse.
6607
1a2e6670
EZ
6608 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6609 coordinates reported by pos-visible-in-window-p for a composed
6610 character in column zero.
6611
8b76d6f8
SM
66122011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6613
6614 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6615
dac347dd
EZ
66162011-08-22 Eli Zaretskii <eliz@gnu.org>
6617
6618 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6619 consider it a hit if to_charpos is anywhere in the range of the
6620 composed buffer positions.
6621
e013fb34
CY
66222011-08-22 Chong Yidong <cyd@stupidchicken.com>
6623
6624 * image.c (gif_load): Don't assume that each subimage has the same
6625 dimensions as the base image. Handle disposal method that is
6626 "undefined" by the gif spec (Bug#9335).
6627
bd1ba3e8
CY
66282011-08-20 Chong Yidong <cyd@stupidchicken.com>
6629
6630 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6631 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6632
54a1215b
EZ
66332011-08-19 Eli Zaretskii <eliz@gnu.org>
6634
823564e5
EZ
6635 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6636 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6637 from an Org mode buffer to a Speedbar frame.
6638
54a1215b
EZ
6639 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6640 a composition, take its buffer position from IT->cmp_it.charpos.
6641 Fixes cursor positioning at the beginning of a line that begins
6642 with a composed character.
6643
9778ebcc
EZ
66442011-08-18 Eli Zaretskii <eliz@gnu.org>
6645
0be6ee06
EZ
6646 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6647 character bidirectional type, use STRONG_L instead. Fixes crashes
6648 in a buffer produced by `describe-categories'.
6649
9778ebcc
EZ
6650 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6651 members before the level stack, so they would be saved and
6652 restored when copying iterator state. Fixes incorrect reordering
6653 around TABs covered by display properties.
6654
156bffbe
AS
66552011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6656
6b02f655 6657 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6658
72ad093b
CY
66592011-08-17 Chong Yidong <cyd@stupidchicken.com>
6660
6661 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6662 (internal_condition_case_2, internal_condition_case_n):
6663 Remove unnecessary aborts (Bug#9081).
72ad093b 6664
35774242
EZ
66652011-08-17 Eli Zaretskii <eliz@gnu.org>
6666
6667 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6668 has no `load' handler, try opening the file locally. (Bug#9311)
6669
db76dd85
KB
66702011-08-16 Ken Brown <kbrown@cornell.edu>
6671
6672 * gmalloc.c: Expand comment.
6673
b215eee5
EZ
66742011-08-16 Eli Zaretskii <eliz@gnu.org>
6675
6676 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6677 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6678
a4579d33
KB
66792011-08-16 Ken Brown <kbrown@cornell.edu>
6680
6681 Fix memory allocation problems in Cygwin build (Bug#9273).
6682
6683 * unexcw.c ( __malloc_initialized): Declare external variable.
6684 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6685
8b76d6f8
SM
6686 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6687 New variables.
a4579d33
KB
6688 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6689 dumped emacs.
6690 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6691 in the static heap.
6692 [CYGWIN] (special_realloc): New function.
6693 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6694 requests to realloc storage in the static heap.
6695
3ebec551
PE
66962011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6697
6698 * bidi.c (bidi_initialize): Remove unused local.
6699
9fd8be00
EZ
67002011-08-15 Eli Zaretskii <eliz@gnu.org>
6701
6b02f655
SM
6702 * bidimirror.h:
6703 * biditype.h: Remove file.
6704 * makefile.w32-in ($(BLD)/bidi.$(O)):
6705 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6706
6707 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6708
6709 * chartab.c: Improve commentary for the uniprop_table API.
6710
32413314
EZ
6711 * bidi.c (bidi_paragraph_init): Support zero value of
6712 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6713 (bidi_initialize): Use uniprop_table instead of including
6714 biditype.h and bidimirror.h.
32413314 6715
9fd8be00
EZ
6716 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6717 coordinates of the iterator when restoring from ppos_it.
6718 (Bug#9296)
6719
5cf2b69b
KH
67202011-08-14 Kenichi Handa <handa@m17n.org>
6721
6722 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6723 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6724
daf17d00
EZ
67252011-08-14 Eli Zaretskii <eliz@gnu.org>
6726
6727 * xdisp.c (move_it_in_display_line_to): Don't invoke
6728 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6729 ppos_it. Fixes vertical cursor motion when line beginning is
6730 covered by an image. (Bug#9296)
6731
08e3161a
JD
67322011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6733
6734 * nsterm.h (ns_run_ascript): Declare.
6735 (NSAPP_DATA2_RUNASSCRIPT): Define.
6736
6737 * nsfns.m (as_script, as_result, as_status): New static variables.
6738 (ns_run_ascript): New function.
5e617bc2 6739 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6740 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6741 the event loop. Get status from as_status (Bug#7276).
6742
6743 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6744 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6745 the event loop (Bug#7276).
6746
a3720aa2
AS
67472011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6748
6749 * gnutls.c (QCgnutls_bootprop_priority)
6750 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6751 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6752 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6753 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6754 (QCgnutls_bootprop_verify_hostname_error)
6755 (QCgnutls_bootprop_callbacks_verify): Rename from
6756 Qgnutls_bootprop_..., all uses changed.
6757
6758 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6759 uses changed.
6760
0a0d27fb
PE
67612011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6762
19d5c50c
PE
6763 * xfaces.c (Qframe_set_background_mode): Now static.
6764 * dispextern.h (Qframe_set_background_mode): Remove decl.
6765
0a0d27fb
PE
6766 * process.c (Fnetwork_interface_info): Declare local only if needed.
6767
377538cb
JD
67682011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6769
6770 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6771 (Fnetwork_interface_list): Allocate in increments of bytes instead
6772 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6773 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6774 sockaddr.
6775 (struct ifflag_def): notrailers is smart on OSX.
6776 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6777 Get hardware address with getifaddrs if available.
6778
08fff70c
EZ
67792011-08-12 Eli Zaretskii <eliz@gnu.org>
6780
6781 * xdisp.c (iterate_out_of_display_property): xassert that
6782 IT->position is set to within IT->object's boundaries. Break from
6783 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6784 when IT->position is set up wrongly due to some bug.
6785 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6786 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6787 entry. Force push_it to save on the stack the current
6788 buffer/string position, to be restored by pop_it. Fix flags in
6789 the iterator structure wrt the object coming from a display
6790 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6791 properties. (Bug#9284)
6792
7be1c708 67932011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6794
7be1c708
CY
6795 * fontset.c (fontset_get_font_group): Add proper type checks.
6796 (Bug#9172)
aac0c6e3 6797
7be1c708 67982011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6799
7be1c708
CY
6800 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6801 and LC_VERSION_MIN_MACOSX.
6802 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6803 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6804
97bb72a6
EZ
68052011-08-08 Eli Zaretskii <eliz@gnu.org>
6806
6807 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6808 no-display-properties-and-no-overlays under bidi display.
6809 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6810 properties and overlays.
97bb72a6 6811
d5617611
CY
68122011-08-08 Chong Yidong <cyd@stupidchicken.com>
6813
37e11a63
CY
6814 * editfns.c (Fset_time_zone_rule): Document relationship with the
6815 setenv function.
6816
d5617611
CY
6817 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6818 the font entity extracted from the cache (Bug#8109).
6819
58872834
CY
68202011-08-07 Chong Yidong <cyd@stupidchicken.com>
6821
6822 * composite.c (autocmp_chars): Don't reset point. That is done by
6823 restore_point_unwind (Bug#5984).
6824
75bfc667
JL
68252011-08-07 Juri Linkov <juri@jurta.org>
6826
6827 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6828 to show the arg `TIME' instead of `TIMEVAL'.
6829
d1410150
EZ
68302011-08-06 Eli Zaretskii <eliz@gnu.org>
6831
6832 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6833 display property strides EOL and includes a newline, as in
6834 longlines-mode. (Bug#9254)
75b771e4
EZ
6835 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6836 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6837
6838 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6839 is non-zero, even if the data buffer is NULL. Fixes a crash in
6840 vertical-motion with longlines-mode. (Bug#9254)
6841
35928349
EZ
68422011-08-05 Eli Zaretskii <eliz@gnu.org>
6843
ec7cc85b
EZ
6844 * bidi.c <bidi_cache_total_alloc>: Now static.
6845 (bidi_initialize): Initialize bidi_cache_total_alloc.
6846
8b76d6f8 6847 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6848 cache. (Bug#9221)
6849
6850 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6851 amount allocated this far in `bidi_cache_total_alloc'.
6852 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6853 non-zero, only free the data buffer without restoring the cache
6854 contents. All callers changed.
6855
6856 * dispextern.h (bidi_unshelve_cache): Update prototype.
6857
6858 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6859 (move_it_in_display_line, move_it_to)
6860 (move_it_vertically_backward, move_it_by_lines): Replace the call
6861 to xfree to an equivalent call to bidi_unshelve_cache.
6862 (move_it_in_display_line_to): Fix logic of returning
412b6358 6863 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6864
e2e2423b
EZ
68652011-08-05 Eli Zaretskii <eliz@gnu.org>
6866
6867 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6868 came from a string character with a `cursor' property. (Bug#9229)
6869
ae9e757a
JD
68702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6871
6872 * Makefile.in (LIB_PTHREAD): New variable.
6873 (LIBES): Add LIB_PTHREAD (Bug#9216).
6874
6875 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6876 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6877
213bd7f2
AS
68782011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6879
6b02f655 6880 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6881
99aaf75f
JD
68822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6883
6884 * xterm.c (x_find_topmost_parent): New function.
6885 (x_set_frame_alpha): Find topmost parent window with
6886 x_find_topmost_parent and set the property there also (bug#9181).
6887 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6888
c74e9d86
PE
68892011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6890
6891 * callproc.c (Fcall_process): Avoid vfork clobbering
6892 the local vars buffer, coding_systems, current_dir.
6893
640c8776
SM
68942011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6895
6896 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6897
f26d0e4c
PE
68982011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6899
8a10d76c
PE
6900 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6901 so that it is not optimized away.
6902
f26d0e4c
PE
6903 * xdisp.c (compute_display_string_pos): Remove unused local.
6904
55439c61
EZ
69052011-08-02 Eli Zaretskii <eliz@gnu.org>
6906
6907 Fix slow cursor motion and scrolling in large buffers with
6908 selective display, like Org Mode buffers. (Bug#9218)
6909
6910 * dispextern.h (struct bidi_it): New member disp_prop_p.
6911
6912 * xdisp.c: Remove one-slot cache of display string positions.
6913 (compute_display_string_pos): Accept an additional argument
5e617bc2 6914 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6915 for a display string or property. If found, set DISP_PROP_P
6916 non-zero.
6917
6918 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6919 DISP_PROP_P, and pass it to compute_display_string_pos.
6920 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6921 non-zero. All callers of bidi_fetch_char changed.
6922
fb33fa43
SM
69232011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6924
6925 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6926
b099e063
DM
69272010-12-03 Don March <don@ohspite.net>
6928
6929 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6930 last character M-[char] is translated to ESC [char] (bug#7541).
6931
5cc7f7af
KH
69322011-08-02 Kenichi Handa <handa@m17n.org>
6933
d0fffa3f 6934 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6935
6936 * chartab.c (uniprop_table): Make it non-static.
6937
525d5e6e
EZ
69382011-08-01 Eli Zaretskii <eliz@gnu.org>
6939
6940 * xdisp.c (forward_to_next_line_start): Accept additional argument
6941 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6942 on the newline.
6943 (reseat_at_next_visible_line_start): Use the bidi iterator state
6944 returned by forward_to_next_line_start to restore the state of
6945 it->bidi_it after backing up to previous newline. (Bug#9212)
6946
31011111
AS
69472011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6948
6949 * regex.c (re_comp): Protoize.
6950 (re_exec): Fix return type.
6951 (regexec): Fix type of `ret'. (Bug#9203)
6952
476371c4
PE
69532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6954
e5d76069
PE
6955 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6956 This is needed if max-image-size is a floating-point number.
6957
9a79b20c
AS
69582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6959
6960 * print.c (print_object): Print empty symbol as ##.
6961
6962 * lread.c (read1): Read ## as empty symbol.
6963
d8c2fa78
AA
69642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6965
6966 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6967 setting frame foreground color (Bug#9175).
6968 (x_set_background_color): Likewise.
6969
ffe57a7a
AA
6970 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6971 contents (Bug#9176).
6972 (EmacsTooltip -init): Remove bezels and add shadows to
6973 tooltip windows.
6974
bf3492a5
AA
6975 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6976 or scroll bar (Bug#8470).
6977
d55e9c53
AA
6978 * nsfont.m (nsfont_open): Remove assignment to voffset and
6979 unnecessary vars hshink, expand, hd, full_height, min_height.
6980 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6981
6982 * nsterm.h (nsfont_info): Remove voffset field.
6983
d8c2fa78 69842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6985
6986 Implement strike-through and overline on NextStep (Bug#8863).
6987
6988 * nsfont.m (nsfont_open): Use underline position provided by font,
6989 instead of hard-coded value of 2.
6990 (nsfont_draw): Call ns_draw_text_decoration instead.
6991
6992 * nsterm.h: Add declaration for ns_draw_text_decoration.
6993
6994 * nsterm.m (ns_draw_text_decoration): New function for drawing
6995 underline, overline, and strike-through.
6996 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6997 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6998 accommodate underlining, etc.
4843aac3 6999
4cc60b9b
EZ
70002011-07-28 Eli Zaretskii <eliz@gnu.org>
7001
bc7ece87
EZ
7002 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7003 default.
4cc60b9b 7004
476371c4
PE
70052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7006
66606eea
PE
7007 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7008 Without this fix, if a signal arrives just after memory fills up,
7009 'malloc' might be invoked reentrantly.
7010
476371c4
PE
7011 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7012 In other words, assume that every image size is allowed, on non-X
7013 hosts. This assumption is probably wrong, but it lets Emacs compile.
7014
f3fcc40d
AS
70152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7016
7017 * regex.c (re_iswctype): Convert return values to boolean.
7018
350c992f
EZ
70192011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7020
7021 * xdisp.c (compute_display_string_pos): Don't use cached display
7022 string position if the buffer had its restriction changed.
7023 (Bug#9184)
7024
5266b4bb
PE
70252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7026
7027 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7028
2573a837 70292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7030
41f55ccd 7031 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7032
39e378da
PE
7033 * bidi.c: Integer size and overflow fixes.
7034 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7035 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7036 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7037 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7038 (bidi_find_other_level_edge):
7039 Use ptrdiff_t instead of EMACS_INT where either will do.
7040 This works better on 32-bit hosts configured --with-wide-int.
7041 (bidi_cache_ensure_space): Check for size-calculation overflow.
7042 Use % rather than repeated addition, for better worst-case speed.
7043 Don't set bidi_cache_size until after xrealloc returns, because it
7044 might not return.
7045 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7046 (bidi_cache_ensure_space): Also check that the bidi cache size
7047 does not exceed that of the largest Lisp string or buffer. See Eli
7048 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7049
5e927815
PE
7050 * alloc.c (__malloc_size_t): Remove.
7051 All uses replaced by size_t. See Andreas Schwab's note
7052 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7053
ca4aa935
PE
7054 * image.c: Improve checking for integer overflow.
7055 (check_image_size): Assume that f is nonnull, since
7056 it is always nonnull in practice. This is one less thing to
7057 worry about when checking for integer overflow later.
7058 (x_check_image_size): New function, which checks for integer
7059 overflow issues inside X.
7060 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7061 This removes the need for a memory_full check.
7062 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7063 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7064 (xbm_read_bitmap_data): Change locals back to 'int', since
7065 their values must fit in 'int'.
7066 (xpm_load_image, png_load, tiff_load):
7067 Invoke x_create_x_image_and_pixmap earlier,
7068 to avoid much needless work if the image is too large.
7069 (tiff_load): Treat overly large images as if
7070 x_create_x_image_and_pixmap failed, not as malloc failures.
7071 (gs_load): Use x_check_image_size.
7072
5f8f9cc2
PE
7073 * gtkutil.c: Omit integer casts.
7074 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7075 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7076
5adf60bc
PE
7077 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7078
c8907a93
PE
7079 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7080 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7081 would wrongly return t on a 64-bit host.
7082
e3c25c68
PE
7083 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7084 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7085 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7086 and therefore cause GCC to emit a bogus diagnostic in some cases.
7087
3f791afe
PE
7088 * image.c: Integer signedness and overflow and related fixes.
7089 This is not an exhaustive set of fixes, but it's time to
7090 record what I've got.
7091 (lookup_pixel_color, check_image_size): Remove redundant decls.
7092 (check_image_size): Don't assume that arbitrary EMACS_INT values
7093 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7094 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7095 (tiff_load, imagemagick_load_image):
7096 Check for overflow in size calculations.
7097 (x_create_x_image_and_pixmap): Remove unnecessary test for
7098 xmalloc returning NULL; that can't happen.
7099 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7100 (xpm_color_bucket): Use better integer hashing function.
7101 (xpm_cache_color): Don't possibly over-allocate memory.
7102 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7103 (gif_memory_source):
7104 Use ptrdiff_t, not int or size_t, to record sizes.
7105 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7106 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7107 either works, as we prefer signed integers.
7108 (tiff_read_from_memory, tiff_write_from_memory):
7109 Return tsize_t, not size_t, since that's what the TIFF API wants.
7110 (tiff_read_from_memory): Don't fail simply because the read would
7111 go past EOF; instead, return a short read.
7112 (tiff_load): Omit no-longer-needed casts.
7113 (Fimagemagick_types): Don't assume size fits into 'int'.
7114
3cc5a532
PE
7115 Improve hashing quality when configured --with-wide-int.
7116 * fns.c (hash_string): New function, taken from sxhash_string.
7117 Do not discard information about ASCII character case; this
7118 discarding is no longer needed.
7119 (sxhash-string): Use it. Change sig to match it. Caller changed.
7120 * lisp.h: Declare it.
7121 * lread.c (hash_string): Remove, since we now use fns.c's version.
7122 The fns.c version returns a wider integer if --with-wide-int is
7123 specified, so this should help the quality of the hashing a bit.
7124
b312a492
PE
7125 * emacs.c: Integer overflow minor fix.
7126 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7127 Define only if GNU_LINUX.
7128 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7129
dfd153ae
PE
7130 * dispnew.c: Integer signedness and overflow fixes.
7131 Remove unnecessary forward decls, that were a maintenance hassle.
7132 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7133 All uses changed.
7134 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7135 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7136 (prepare_desired_row, line_draw_cost):
7137 Use int, not unsigned, where either works.
7138 (save_current_matrix, restore_current_matrix):
7139 Use ptrdiff_t, not size_t, where either works.
7140 (init_display): Check for overflow more accurately, and without
7141 relying on undefined behavior.
7142
a81d11a3
PE
7143 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7144 Remove, replacing with the new symbols in lisp.h. All uses changed.
7145 * fileio.c (make_temp_name):
7146 * filelock.c (lock_file_1, lock_file):
7147 * xdisp.c (message_dolog):
7148 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7149 Use pMd etc. instead.
7150 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7151 replacing the pWIDE etc. symbols removed from editfns.c.
7152
3300e6fd
PE
7153 * keyboard.h (num_input_events): Now uintmax_t.
7154 This is (very slightly) less likely to mess up due to wraparound.
7155 All uses changed.
7156
fd05c7e9
PE
7157 * buffer.c: Integer signedness fixes.
7158 (alloc_buffer_text, enlarge_buffer_text):
7159 Use ptrdiff_t rather than size_t when either will do, as we prefer
7160 signed integers.
7161
903fe15d
PE
7162 * alloc.c: Integer signedness and overflow fixes.
7163 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7164 (__malloc_size_t): Default to size_t, not to int.
7165 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7166 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7167 Prefer ptrdiff_t to size_t when either would do, as we prefer
7168 signed integers.
7169 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7170 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7171 Now const. Initialize with values that are in range even if char
7172 is signed.
7173 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7174 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7175 These functions do the right thing with sizes > 2**32.
7176 (check_depth): Now ptrdiff_t, not int.
7177 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7178 Adjust to new way of storing sizes. Check for size overflow bugs
7179 in rest of code.
7180 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7181 slightly wrong anyway, as it missed one instance of
7182 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7183 (refill_memory_reserve): Omit needless cast to size_t.
7184 (mark_object_loop_halt): Mark as externally visible.
7185
ac82cc6a
PE
7186 * xselect.c: Integer signedness and overflow fixes.
7187 (Fx_register_dnd_atom, x_handle_dnd_message):
7188 Use ptrdiff_t, not size_t, since we prefer signed.
7189 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7190 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7191 x_dnd_atoms_size and x_dnd_atoms_length.
7192
c2d1e36d
PE
7193 * doprnt.c: Prefer signed to unsigned when either works.
7194 * eval.c (verror):
7195 * doprnt.c (doprnt):
7196 * lisp.h (doprnt):
7197 * xdisp.c (vmessage):
7198 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7199 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7200 prefer signed arithmetic to avoid comparison confusion.
7201 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7202 but is a bit tricky.
7203
0e926e56
PE
7204 Assume freestanding C89 headers, string.h, stdlib.h.
7205 * data.c, doprnt.c, floatfns.c, print.c:
7206 Include float.h unconditionally.
7207 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7208 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7209 * regex.c: Likewise for stddef.h, string.h.
7210 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7211 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7212 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7213 (STDC_HEADERS): Remove obsolete defines.
7214 * sysdep.c: Include limits.h unconditionally.
7215
9cfdb3ec
PE
7216 Assume support for memcmp, memcpy, memmove, memset.
7217 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7218 * regex.c (memcmp, memcpy):
7219 Remove; we assume C89 now.
7220
7221 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7222 (__malloc_safe_bcopy): Remove; no longer needed.
7223
cf950e6b 7224 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7225 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7226 well either way, and we prefer signed to unsigned.
7227
dbf38e02
LMI
72282011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7229
7230 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7231 closes the connection while we're reading (bug#9182).
7232
d6f0886c 72332011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7234
d6f0886c
JD
7235 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7236 are specified (Bug#9168).
24e0f6b1 7237
2eb1f9e6
PE
72382011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7239
7240 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7241 Found by GCC static checking and --with-wide-int on a 32-bit host.
7242
22381272 72432011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7244
7245 * xdisp.c (compute_display_string_pos): Fix logic of caching
7246 previous display string position. Initialize cached_prev_pos to
7247 -1. Fixes slow-down at the beginning of a buffer.
7248
f25e39b4
EZ
72492011-07-24 Eli Zaretskii <eliz@gnu.org>
7250
7251 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7252 for attrs[LFACE_FONTSET_INDEX].
7253
04c4b52e
PE
72542011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7255
7256 * xml.c (parse_region): Remove unused local
7257 that was recently introduced.
7258
c1734fbd
EZ
72592011-07-23 Eli Zaretskii <eliz@gnu.org>
7260
be18c5a5
EZ
7261 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7262 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7263
c1734fbd
EZ
7264 * xdisp.c (move_it_in_display_line_to): Record the best matching
7265 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7266 exit if none of the characters scanned was an exact match.
7267 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7268 when exact match is impossible due to invisible text, and the
7269 lines are truncated.
7270
a258d627
JD
72712011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7272
7273 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7274 for OSX >= 10.7.
7275
b6d5a689
EZ
72762011-07-22 Eli Zaretskii <eliz@gnu.org>
7277
0f74f785
EZ
7278 Fix a significant slow-down of cursor motion with C-n, C-p,
7279 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7280 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7281 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7282 (next_element_from_buffer): Call compute_stop_pos_backwards to
7283 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7284 base_level_stop.
7285 (reseat): Don't look for prev_stop, as that could mean a very long
7286 run.
7287 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7288 <cached_disp_overlay_modiff>: Cache for last found display string
7289 position.
551918c1 7290 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7291 about the same buffer in the same area of character positions, and
7292 the buffer wasn't changed since the time the display string
7293 position was cached.
551918c1 7294
b2d0c91a
EZ
72952011-07-22 Eli Zaretskii <eliz@gnu.org>
7296
7297 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7298 is an integer, which is important for empty lines. (Bug#9149)
7299
043604ee
CY
73002011-07-22 Chong Yidong <cyd@stupidchicken.com>
7301
7302 * frame.c (Fmodify_frame_parameters): In tty case, update the
7303 default face if necessary (Bug#4238).
7304
da4adb04
CY
73052011-07-21 Chong Yidong <cyd@stupidchicken.com>
7306
7307 * editfns.c (Fstring_to_char): No need to explain what a character
7308 is in the docstring (Bug#6576).
7309
9abd0532
LMI
73102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7311
7312 * xml.c (parse_region): Make sure we always return a tree.
7313
36881d16
HK
73142011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7315
7316 * xml.c (parse_region): If a document contains only comments,
7317 return that, too.
7318
1e98674d
LMI
73192011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7320
7321 * xml.c (make_dom): Return comments, too.
7322
590bd467
PE
73232011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7324
7325 Port to OpenBSD.
7326 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7327 and the surrounding thread.
7328 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7329 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7330 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7331 timer goes off.
7332 * s/openbsd.h (BROKEN_SIGIO): Define.
7333 * unexelf.c (unexec) [__OpenBSD__]:
7334 Don't update the .mdebug section of the Alpha COFF symbol table.
7335
f41628b2
LMI
73362011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7337
7338 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7339 (bug#8460).
7340
b59b67c5
PE
73412011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7342
15e3a074
PE
7343 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7344 This fixes some race conditions on the permissions of any newly
7345 created file.
7346
41bed37d
PE
7347 * alloc.c (valid_pointer_p): Use pipe, not open.
7348 This fixes some permissions issues when debugging.
7349
b59b67c5
PE
7350 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7351 If fchown fails to set both uid and gid, try to set just gid,
7352 as that is sometimes allowed. Adjust the file's mode to eliminate
7353 setuid or setgid bits that are inappropriate if fchown fails.
7354
925a6be7
SM
73552011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7356
7357 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7358 to compare Lisp_Objects.
7359 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7360 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7361 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7362
52968808
AS
73632011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7364
0a6a104b
AS
7365 * lread.c (read_integer): Unread even EOF character.
7366 (read1): Likewise. Properly record start position of symbol.
7367
52968808
AS
7368 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7369 symbol character follows.
7370
9e381cdd
PE
73712011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7372
7373 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7374 This works around a problem with the previous change to Fcopy_file.
7375 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7376 and without this change, GCC might complain about discarding
7377 fchown's return value.
7378
b5641435
JB
73792011-07-16 Juanma Barranquero <lekktu@gmail.com>
7380
7381 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7382
a8031457
PE
73832011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7384
7385 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7386
dd889327
LMI
73872011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7388
750c33f7
LMI
7389 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7390 it's used from the C level.
7391
dd889327
LMI
7392 * process.c: Use the same condition for POLL_FOR_INPUT in both
7393 keyboard.c and process.c (bug#1858).
7394
87e86684
LM
73952011-07-09 Lawrence Mitchell <wence@gmx.li>
7396
7397 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7398 (Fgnutls_boot): Use it.
7399
64348f40
AS
74002011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7401
7402 * doc.c (Fsubstitute_command_keys): Revert last change.
7403
1d698799
LMI
74042011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7405
f863868c
LMI
7406 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7407 quotes the next character, and doesn't affect other longer
7408 sequences (bug#8935).
7409
1d698799
LMI
7410 * lread.c (syms_of_lread): Clarify that is isn't only
7411 `eval-buffer' and `eval-defun' that's affected by
7412 `lexical-binding' (bug#8460).
7413
aa4b6df6
EZ
74142011-07-15 Eli Zaretskii <eliz@gnu.org>
7415
7416 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7417 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7418
5d856da6
PE
74192011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7420
ad6042bb
PE
7421 Fix minor problems found by static checking.
7422 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7423 (elsz): Now a signed constant, not a size_t var. We prefer signed
7424 types to unsigned, to avoid integer comparison confusion. Without
7425 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7426 "cannot optimize loop, the loop counter may overflow", a symptom
7427 of the confusion.
f00bbb22 7428 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7429 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7430
6468f31c
LMI
74312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7432
49080b10
LMI
7433 * search.c (Fre_search_backward): Mention `case-fold-search' in
7434 all the re_search_* functions (bug#8138).
7435
6468f31c
LMI
7436 * keyboard.c (Fopen_dribble_file): Document when the file is
7437 closed (bug#8056).
7438
c965adc5
EZ
74392011-07-14 Eli Zaretskii <eliz@gnu.org>
7440
df9733bf
EZ
7441 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7442 bidi_cache_idx.
7443
0bb23927
EZ
7444 Support bidi reordering of display and overlay strings.
7445 * xdisp.c (compute_display_string_pos)
7446 (compute_display_string_end): Accept additional argument STRING.
7447 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7448 (reseat_to_string): Initialize bidi_it->string.s and
7449 bidi_it->string.schars.
7450 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7451 NULL (avoids a crash in bidi_paragraph_init).
7452 Initialize itb.string.lstring.
0bb23927
EZ
7453 (init_iterator): Call bidi_init_it only of a valid
7454 buffer position was specified. Initialize paragraph_embedding to
7455 L2R.
7456 (reseat_to_string): Initialize the bidi iterator.
7457 (display_string): If we need to ignore text properties of
7458 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7459 original value of -1 will not work with bidi.)
7460 (compute_display_string_pos): First arg is now struct
7461 `text_pos *'; all callers changed. Support display properties on
7462 Lisp strings.
7463 (compute_display_string_end): Support display properties on Lisp
7464 strings.
7465 (init_iterator, reseat_1, reseat_to_string): Initialize the
7466 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7467 when iterating on a string not from display properties).
640c8776
SM
7468 (compute_display_string_pos, compute_display_string_end):
7469 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7470 arrow keys.
7471 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7472 base_level_stop; instead, set base_level_stop to BEGV.
7473 Fixes crashes in vertical-motion.
0bb23927
EZ
7474 (next_element_from_buffer): Improve commentary for when
7475 the iterator is before prev_stop.
7476 (init_iterator): Initialize bidi_p from the default value of
7477 bidi-display-reordering, not from buffer-local value. Use the
7478 buffer-local value only if initializing for buffer iteration.
7479 (handle_invisible_prop): Support invisible properties on strings
7480 that are being bidi-reordered.
7481 (set_iterator_to_next): Support bidi reordering of C strings and
7482 Lisp strings.
7483 (next_element_from_string): Support bidi reordering of Lisp
7484 strings.
7485 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7486 (display_string): Support display of R2L glyph rows.
7487 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7488 (init_iterator): Don't initialize it->bidi_p for strings
7489 here.
7490 (reseat_to_string): Initialize it->bidi_p for strings here.
7491 (next_element_from_string, next_element_from_c_string)
7492 (next_element_from_buffer): Add xassert's for correspondence
7493 between IT's object being iterated and it->bidi_it.string
7494 structure.
7495 (face_before_or_after_it_pos): Support bidi iteration.
7496 (next_element_from_c_string): Handle the case of the first string
7497 character that is not the first one in the visual order.
7498 (get_visually_first_element): New function, refactored from common
7499 parts of next_element_from_buffer, next_element_from_string, and
7500 next_element_from_c_string.
7501 (tool_bar_lines_needed, redisplay_tool_bar)
7502 (display_menu_bar): Force left-to-right direction. Add a FIXME
7503 comment for making that be controlled by a user option.
7504 (push_it, pop_it): Save and restore the state of the
7505 bidi iterator. Save and restore the bidi_p flag.
7506 (pop_it): Iterate out of display property for string iteration as
7507 well.
7508 (iterate_out_of_display_property): Support iteration over strings.
7509 (handle_single_display_spec): Set up it->bidi_it for iteration
7510 over a display string, and call bidi_init_it.
7511 (handle_single_display_spec, next_overlay_string)
7512 (get_overlay_strings_1, push_display_prop): Set up the bidi
7513 iterator for displaying display or overlay strings.
7514 (forward_to_next_line_start): Don't use the shortcut if
7515 bidi-iterating.
7516 (back_to_previous_visible_line_start): If handle_display_prop
7517 pushed the iterator stack, restore the internal state of the bidi
7518 iterator by calling bidi_pop_it same number of times.
7519 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7520 and we are bidi-iterating, don't decrement the iterator position;
7521 instead, set the first_elt flag in the bidi iterator, to produce
7522 the same effect.
7523 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7524 (push_display_prop): xassert that we are iterating a buffer.
7525 (push_it, pop_it): Save and restore paragraph_embedding member.
7526 (handle_single_display_spec, next_overlay_string)
7527 (get_overlay_strings_1, reseat_1, reseat_to_string)
7528 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7529 correctly. Don't assume unibyte strings are not bidi-reordered.
7530 (compute_display_string_pos)
7531 (compute_display_string_end): Fix handling the case of C string.
7532 (push_it, pop_it): Save and restore from_disp_prop_p.
7533 (handle_single_display_spec, push_display_prop): Set the
7534 from_disp_prop_p flag.
7535 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7536 (pop_it): Call iterate_out_of_display_property only if we are
7537 popping after iteration over a string that came from a display
7538 property. Fix a typo in popping stretch info. Add an assertion
7539 for verifying that the iterator position is in sync with the bidi
7540 iterator.
7541 (handle_single_display_spec, get_overlay_strings_1)
7542 (push_display_prop): Fix initialization of paragraph direction for
7543 string when that of the parent object is not yet determined.
7544 (reseat_1): Call bidi_init_it to resync the bidi
7545 iterator with IT's position. (Bug#7616)
7546 (find_row_edges): If ROW->start.pos gives position
7547 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7548 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7549 Reset the from_disp_prop_p flag.
7550 (SAVE_IT, RESTORE_IT): New macros.
7551 (pos_visible_p, face_before_or_after_it_pos)
7552 (back_to_previous_visible_line_start)
7553 (move_it_in_display_line_to, move_it_in_display_line)
7554 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7555 (try_scrolling, redisplay_window, display_line): Use them when
7556 saving a temporary copy of the iterator and restoring it back.
7557 (back_to_previous_visible_line_start, reseat_1)
7558 (init_iterator): Empty the bidi cache "stack".
7559 (move_it_in_display_line_to): If iterator ended up at
7560 EOL, but we never saw any buffer positions smaller than
7561 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7562 motion in bidi-reordered lines.
7563 (move_it_in_display_line_to): Record prev_method and prev_pos
7564 immediately before the call to set_iterator_to_next. Fixes cursor
7565 motion in bidi-reordered lines with stretch glyphs and strings
7566 displayed in margins. (Bug#8133) (Bug#8867)
7567 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7568 TO_CHARPOS.
640c8776
SM
7569 (pos_visible_p): Support positions in bidi-reordered lines.
7570 Save and restore bidi cache.
0bb23927
EZ
7571
7572 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7573 (bidi_paragraph_info): Delete unused struct.
7574 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7575 (bidi_cache_start): New variable.
7576 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7577 to zero.
7578 (bidi_cache_fetch_state, bidi_cache_search)
7579 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7580 (bidi_cache_find, bidi_peek_at_next_level)
7581 (bidi_level_of_next_char, bidi_find_other_level_edge)
7582 (bidi_move_to_visually_next): Compare cache index with
7583 bidi_cache_start rather than with zero.
7584 (bidi_fetch_char): Accept new argument STRING; all callers
7585 changed. Support iteration over a string. Support strings with
7586 display properties. Support unibyte strings. Fix the type of
7587 `len' according to what STRING_CHAR_AND_LENGTH expects.
7588 (bidi_paragraph_init, bidi_resolve_explicit_1)
7589 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7590 (bidi_level_of_next_char, bidi_move_to_visually_next):
7591 Support iteration over a string.
0bb23927
EZ
7592 (bidi_set_sor_type, bidi_resolve_explicit_1)
7593 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7594 can now be zero (for strings); special values 0 and -1 were
7595 changed to -1 and -2, respectively.
7596 (bidi_char_at_pos): New function.
7597 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7598 Call it instead of FETCH_MULTIBYTE_CHAR.
7599 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7600 initialized to valid values.
7601 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7602 values.
7603 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7604 the test for valid cached positions. Fix the logic for looking up
7605 the sentinel state in the cache. GCPRO the Lisp string we are
7606 iterating.
7607 (bidi_push_it, bidi_pop_it): New functions.
7608 (bidi_initialize): Initialize the bidi cache start stack pointer.
7609 (bidi_cache_ensure_space): New function, refactored from part of
7610 bidi_cache_iterator_state. Don't assume the required size is just
7611 one BIDI_CACHE_CHUNK away.
7612 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7613 (bidi_count_bytes, bidi_char_at_pos): New functions.
7614 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7615 always valid if bidi_cache_idx is valid.
7616 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7617 is valid if it's going to be used.
7618 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7619 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7620 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7621 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7622 (bidi_find_other_level_edge, bidi_cache_start_stack):
7623 All variables related to cache indices are now EMACS_INT.
c965adc5 7624
0bb23927
EZ
7625 * dispextern.h (struct bidi_string_data): New structure.
7626 (struct bidi_it): New member `string'. Make flag members be 1-bit
7627 fields, and put them last in the struct.
640c8776
SM
7628 (compute_display_string_pos, compute_display_string_end):
7629 Update prototypes.
0bb23927
EZ
7630 (bidi_push_it, bidi_pop_it): Add prototypes.
7631 (struct iterator_stack_entry): New members bidi_p,
7632 paragraph_embedding, and from_disp_prop_p.
7633 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7634 (bidi_shelve_cache, bidi_unshelve_cache):
7635 Declare prototypes.
0bb23927
EZ
7636
7637 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7638 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7639 and vector-like objects.
7640
7641 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7642 cache around display iteration.
7643
7644 * window.c (Fwindow_end, window_scroll_pixel_based)
7645 (displayed_window_lines, Frecenter): Save and restore the bidi
7646 cache around display iteration.
7647
3bbd2265
LMI
76482011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7649
7650 * editfns.c (Fdelete_region): Clarify the use of the named
7651 parameters (bug#6788).
7652
adc47434
MR
76532011-07-14 Martin Rudalics <rudalics@gmx.at>
7654
7655 * indent.c (Fvertical_motion): Set and restore w->pointm when
7656 saving and restoring the window's buffer (Bug#9006).
7657
837c31f8
LMI
76582011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7659
7660 * editfns.c (Fstring_to_char): Clarify just what is returned
7661 (bug#6576). Text by Eli Zaretskii.
7662
ac389d0c
JB
76632011-07-13 Juanma Barranquero <lekktu@gmail.com>
7664
7665 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7666
0be0ce47
EZ
76672011-07-13 Eli Zaretskii <eliz@gnu.org>
7668
7669 * buffer.c (mmap_find): Fix a typo.
7670
cd18e7e3
JB
76712011-07-13 Johan Bockgård <bojohan@gnu.org>
7672
7673 Fix execution of x selection hooks.
7674 * xselect.c (Qx_lost_selection_functions)
7675 (Qx_sent_selection_functions): New vars.
7676 (syms_of_xselect): DEFSYM them.
7677 (x_handle_selection_request): Pass Qx_sent_selection_functions
7678 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7679 (x_handle_selection_clear,x_clear_frame_selections):
7680 Pass Qx_lost_selection_functions rather than
7681 Vx_lost_selection_functions to Frun_hook_with_args.
7682
47ea7f44
PE
76832011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7684
ac389d0c 7685 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7686 The old code sometimes used this field without initializing it.
7687
47ea7f44
PE
7688 * alloc.c (gc_sweep): Don't read past end of array.
7689 In theory, the old code could also have corrupted Emacs internals,
7690 though it'd be very unlikely.
7691
bc985c87
AS
76922011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7693
7694 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7695 argument. (Bug#4026)
bc985c87 7696
0cf34688
LMI
76972011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7698
b3dadd76
LMI
7699 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7700 key" (bug#4257).
7701
0cf34688
LMI
7702 * window.c (Fset_window_start): Doc fix (bug#4199).
7703 (Fset_window_hscroll): Ditto.
7704
270768cd
PE
77052011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7706
077e3dda 7707 Fix minor new problems caught by GCC 4.6.1.
270768cd 7708 * term.c (init_tty): Remove unused local.
490011a6 7709 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7710 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7711 not used otherwise.
270768cd 7712
b1f58454
CY
77132011-07-12 Chong Yidong <cyd@stupidchicken.com>
7714
7715 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7716
22b9578d
LMI
77172011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7718
6e70ab07
LMI
7719 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7720 are the mini-buffer and the echo area (bug#3320).
7721
22b9578d
LMI
7722 * term.c (init_tty): Remove support for supdup, c10 and perq
7723 terminals, which are no longer supported (bug#1482).
7724
8974cc9f
JB
77252011-07-10 Johan Bockgård <bojohan@gnu.org>
7726
7727 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7728
a560d974
JD
77292011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7730
7731 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7732 for non-popups (Bug#3642).
7733
1dae0f0a
AS
77342011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7735
268c2c36 7736 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7737 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7738 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7739 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7740 * data.c (fmod): Likewise.
7741 * dispnew.c (swap_glyphs_in_rows): Likewise.
7742 * emacs.c (memory_warning_signal): Likewise.
7743 * floatfns.c (float_error): Likewise.
7744 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7745 (otf_open, font_otf_capability, generate_otf_features)
7746 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7747 Likewise.
7748 * image.c (pbm_read_file): Likewise.
7749 * indent.c (string_display_width): Likewise.
7750 * intervals.c (check_for_interval, search_for_interval)
7751 (inc_interval_count, count_intervals, root_interval)
7752 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7753 * lread.c (defalias): Likewise.
268c2c36 7754 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7755 * regex.c (set_image_of_range_1, set_image_of_range)
7756 (regex_grow_registers): Likewise.
7757 * sysdep.c (strerror): Likewise.
7758 * termcap.c (valid_filename_p, tprint, main): Likewise.
7759 * tparam.c (main): Likewise.
7760 * unexhp9k800.c (run_time_remap, save_data_space)
7761 (update_file_ptrs, read_header, write_header, calculate_checksum)
7762 (copy_file, copy_rest, display_header): Likewise.
7763 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7764 Likewise.
7765 * xdisp.c (check_it): Likewise.
7766 * xfaces.c (register_color, unregister_color, unregister_colors):
7767 Likewise.
7768 * xfns.c (print_fontset_result): Likewise.
7769 * xrdb.c (member, fatal, main): Likewise.
7770
99033785
PE
77712011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7772
7773 Fix minor problems found by static checking (Bug#9031).
7774 * chartab.c (char_table_set_range, map_sub_char_table):
7775 Remove unused locals.
7776 (uniprop_table): Now static.
7777 * composite.c (_work_char): Remove unused static var.
7778
9cb2ac56
JB
77792011-07-09 Juanma Barranquero <lekktu@gmail.com>
7780
7781 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7782
f25661f0
JD
77832011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7784
7785 * gtkutil.c (qttip_cb): Remove code without function.
7786
8278c4fe
EZ
77872011-07-09 Eli Zaretskii <eliz@gnu.org>
7788
7789 * w32.c (pthread_sigmask): New stub.
7790
1692ae2d 77912011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7792
8a6ebd58 7793 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7794 sigprocmask is portable only for single-threaded applications, and
7795 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7796 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7797 (LIBES): Use it.
7798 * callproc.c (Fcall_process):
7799 * process.c (create_process):
7800 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7801 Use pthread_sigmask, not sigprocmask.
123403e4 7802
1b854618
JD
78032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7804
7805 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7806 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7807 wrong (Bug#8591).
7808
3fe4b549
JD
78092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7810
0ce7e563
JD
7811 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7812 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7813 (xg_hide_tooltip): Fix comment.
7814
3fe4b549
JD
7815 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7816 in registerServicesMenuSendTypes.
7817 (validRequestorForSendType): Don't check ns_return_types.
7818
7819 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7820 ns_return_type.
7821
5df75e47
JR
78222011-07-08 Jason Rumney <jasonr@gnu.org>
7823
22610910
JR
7824 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7825 SH_SHOW for hidden windows (Bug#5482).
7826
5df75e47
JR
7827 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7828 frame struct members of non-existent frames (Bug#6284).
7829
699c10bd
JD
78302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7831
4393663b
JD
7832 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7833 variable firstTime not needed on OSX >= 10.6.
7834 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7835 >= 10.5. Use setKnobProportion, setDoubleValue.
7836
7837 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7838 (MAC_OS_X_VERSION_10_5): Define if not defined.
7839 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7840 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7841 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7842
7843 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7844 cString and lossyCString on OSX >= 10.4.
4393663b 7845
58179cce 7846 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7847 sizeToFit on OSX >= 10.2.
7848
7849 * nsimage.m (allocInitFromFile): Don't use deprecated method
7850 bestRepresentationForDevice on OSX >= 10.6.
7851
7852 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7853 to avoid warning.
7854
7855 * emacs.c: Declare unexec_init_emacs_zone.
7856
a63e0781
JD
7857 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7858
699c10bd
JD
7859 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7860
7861 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7862 on svcsMenu (Bug#8842).
7863
7864 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7865 ns_return_types.
7866 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7867
7868 * nsterm.m (QUTF8_STRING): Declare.
7869 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7870 (validRequestorForSendType): Return type is (id).
7871 Change indexOfObjectIdenticalTo to indexOfObject.
7872 Check if we have local selection before returning self (Bug#8842).
7873 (writeSelectionToPasteboard): Put local selection into paste board
7874 if we have a local selection (Bug#8842).
7875 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7876
7877 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7878 (ns_get_local_selection): Declare.
7879
54e10184
LMI
78802011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7881
9888ff71
LMI
7882 * keymap.c (describe_map_tree): Don't insert a double newline at
7883 the end of the buffer (bug#1169) and return whether we inserted
7884 something.
7885
54e10184
LMI
7886 * callint.c (Fcall_interactively): Change "reading args" to
7887 "providing args" to try to clarify what it does (bug#1010).
7888
15fa4783
KH
78892011-07-07 Kenichi Handa <handa@m17n.org>
7890
7891 * composite.c (composition_compute_stop_pos): Ignore a static
7892 composition starting before CHARPOS (Bug#8915).
7893
7894 * xdisp.c (handle_composition_prop): Likewise.
7895
a8815b00
EZ
78962011-07-07 Eli Zaretskii <eliz@gnu.org>
7897
7898 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7899 (Bug#9015)
7900
ef7b981d 79012011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7902
7903 * character.h (unicode_category_t): New enum type.
7904
7905 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7906 (Qchar_code_property_table): New variable.
7907 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7908 (UNIPROP_COMPRESSED_FORM_P): New macros.
7909 (char_table_ascii): Uncompress the compressed values.
7910 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7911 Uncompress the compressed values.
ac389d0c 7912 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7913 (char_table_ref_and_range): Uncompress the compressed values.
7914 (sub_char_table_set): New arg is_uniprop. Callers changed.
7915 Uncompress the compressed values.
7916 (sub_char_table_set_range): Args changed. Callers changed.
7917 (char_table_set_range): Adjuted for the above change.
7918 (map_sub_char_table): Delete args default_val and parent. Add arg
7919 top. Give decoded values to a Lisp function.
640c8776 7920 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7921 values to a Lisp function. Gcpro more variables.
7922 (uniprop_table_uncompress)
7923 (uniprop_decode_value_run_length): New functions.
7924 (uniprop_decoder, uniprop_decoder_count): New variables.
7925 (uniprop_get_decoder, uniprop_encode_value_character)
7926 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7927 New functions.
7928 (uniprop_encoder, uniprop_encoder_count): New variables.
7929 (uniprop_get_encoder, uniprop_table)
7930 (Funicode_property_table_internal, Fget_unicode_property_internal)
7931 (Fput_unicode_property_internal): New functions.
7932 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7933 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7934 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7935 char-code-property-alist.
7936
640c8776 7937 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7938 Vunicode_category_table.
7939
640c8776 7940 * font.c (font_range): Adjust for the change of
c805dec0
KH
7941 Vunicode_category_table.
7942
76b397fb
DN
79432011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7944
7945 * m/iris4d.h: Remove file, move contents ...
7946 * s/irix6-5.h: ... here.
7947
22b4128e
PE
79482011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7949
7950 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7951 * alloc.c (mark_buffer):
7952 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7953 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7954 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7955 This isn't true in general, and it's particularly not true
7956 if Emacs is configured with --with-wide-int.
7957 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7958 New macros, used in the buffer.c change.
7959
869795d6
JD
79602011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7961
7962 * xsettings.c: Use both GConf and GSettings if both are available.
7963 (store_config_changed_event): Add comment.
7964 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7965 (store_tool_bar_style_changed): New functions.
5e617bc2 7966 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7967 (struct xsettings): Move font inside HAVE_XFT.
7968 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7969 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7970 Move inside HAVE_XFT.
640c8776 7971 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7972 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7973 also.
7974 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7975 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7976 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7977 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7978 (parse_settings): Move check for font inside HAVE_XFT.
7979 (read_settings, apply_xft_settings): Add comment.
7980 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7981 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7982 call store_font_name_changed.
7983 (xft_settings_event): Add comment.
7984 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7985 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7986 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7987 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7988 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7989 (xsettings_get_system_font, xsettings_get_system_normal_font):
7990 Add comment.
869795d6 7991
d8ed26bd
PE
79922011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7993
7994 Random fixes. E.g., (random) never returned negative values.
7995 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7996 subseconds part to the entropy, as that's a bit more random.
7997 Prefer signed to unsigned, since the signedness doesn't matter and
7998 in general we prefer signed. When given a limit, use a
7999 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8000 latter isn't right if USE_2_TAGS_FOR_INTS.
8001 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8002 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8003
cabf1cac
SM
80042011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8005
8006 * textprop.c (text_property_stickiness):
8007 Obey Vtext_property_default_nonsticky.
8008 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8009 * w32fns.c (syms_of_w32fns):
8010 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8011
6e9b2be9
PE
80122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8013
8014 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8015 This is more efficient than Ffile_directory_p and avoids a minor race.
8016
90186c68
LMI
80172011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8018
7c301272
LMI
8019 * buffer.c (Foverlay_put): Say what the return value is
8020 (bug#7835).
8021
c4f2d8d4
LMI
8022 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8023 is a directory before asking whether to use the file name
8024 (bug#7564).
ad637907
LMI
8025 (barf_or_query_if_file_exists): Make the "File is a directory"
8026 error be more correct.
c4f2d8d4 8027
90186c68
LMI
8028 * fns.c (Frequire): Remove the mention of the .gz files, since
8029 that's installation-specific, but keep the mention of
8030 `get-load-suffixes'.
8031
da64016e
PE
80322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8033
8034 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8035 Report string overflow if the output is too long.
8036
7d47b580
JB
80372011-07-04 Juanma Barranquero <lekktu@gmail.com>
8038
a555cb87
JB
8039 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8040 (syms_of_gnutls): Remove duplicate DEFSYM for
8041 Qgnutls_bootprop_verify_hostname_error, an error for
8042 Qgnutls_bootprop_verify_error (which is no longer used).
8043
7d47b580
JB
8044 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8045 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8046 Also (re)move comments that are misplaced or no longer relevant.
8047
1e49bfab
LMI
80482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8049
8050 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8051
1485f4c0
CY
80522011-07-03 Chong Yidong <cyd@stupidchicken.com>
8053
8054 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8055 and background color parameters if they have been changed.
8056
a9ab721e
LMI
80572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8058
8059 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8060
cf7cff57
PE
80612011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8062
2e13213d
PE
8063 * xsettings.c (SYSTEM_FONT): Define only when used.
8064 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8065
cf7cff57
PE
8066 * keymap.c (access_keymap_1): Now static.
8067
7a8e04f7
CY
80682011-07-02 Chong Yidong <cyd@stupidchicken.com>
8069
8070 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8071 leave any prefix arg for the up event (Bug#1586).
8072
61352f62
LMI
80732011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8074
69bb1ef7
LMI
8075 * lread.c (syms_of_lread): Mention single symbols defined by
8076 `defvar' or `defconst' (bug#7154).
8077
61352f62 8078 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8079 (Frequire): Mention get-load-suffixes.
61352f62 8080
28545e04
MR
80812011-07-02 Martin Rudalics <rudalics@gmx.at>
8082
8083 * window.h (window): Remove clone_number slot.
8084 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8085 Remove.
8086 (make_parent_window, make_window, saved_window)
8087 (Fset_window_configuration, save_window_save): Don't deal with
8088 clone numbers.
8089 * buffer.c (Qclone_number): Remove declaration.
8090 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8091
3349e122
SM
80922011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8093
8094 Add multiple inheritance to keymaps.
8095 * keymap.c (Fmake_composed_keymap): New function.
8096 (Fset_keymap_parent): Simplify.
8097 (fix_submap_inheritance): Remove.
8098 (access_keymap_1): New function extracted from access_keymap to handle
8099 embedded parents and handle lists of maps.
8100 (access_keymap): Use it.
8101 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8102 (Fcopy_keymap): Handle embedded parents.
8103 (Fcommand_remapping, define_as_prefix): Simplify.
8104 (Fkey_binding): Simplify.
8105 (syms_of_keymap): Move minibuffer-local-completion-map,
8106 minibuffer-local-filename-completion-map,
8107 minibuffer-local-must-match-map, and
8108 minibuffer-local-filename-must-match-map to Elisp.
8109 (syms_of_keymap): Defsubr make-composed-keymap.
8110 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8111 (parse_menu_item): Trivial simplification.
8112
3279eb87
GM
81132011-07-01 Glenn Morris <rgm@gnu.org>
8114
8115 * Makefile.in (SETTINGS_LIBS): Fix typo.
8116
4550efdf
KI
81172011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8118
8119 * coding.c (Fencode_coding_string): Record the last coding system
8120 used, as the function doc string says (bug#8738).
8121
0949d2b6
JD
81222011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8123
8124 * xsettings.c (store_monospaced_changed): Take new font as arg and
8125 check for change against current_mono_font.
8126 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8127 (emacs_settings_constructor, emacs_settings_get_property)
8128 (emacs_settings_set_property, emacs_settings_class_init)
8129 (emacs_settings_init, gsettings_obj): Remove.
8130 (something_changedCB): New function for HAVE_GSETTINGS.
8131 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8132 with value as argument.
8133 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8134 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8135 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8136 "changed".
8137
8138 * xgselect.c: Add defined (HAVE_GSETTINGS).
8139 (xgselect_initialize): Ditto.
8140
8141 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8142 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8143 xg_select.
8144
bbc6b304
PE
81452011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8146
8147 * eval.c (struct backtrace): Simplify and port the data structure.
8148 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8149 signed bit field, as this assumption is not portable and it makes
8150 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8151 "char debug_on_exit : 1" as this is not portable either; instead,
8152 use the portable "unsigned int debug_on_exit : 1". Remove unused
8153 member evalargs. Remove obsolete comments about cc bombing out.
8154
9851bfc5
JD
81552011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8156
51bb811f 8157 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8158 Let HAVE_GSETTINGS override HAVE_GCONF.
8159 (store_monospaced_changed): New function.
8160 (EMACS_SETTINGS): A new type derived from GObject to handle
8161 GSettings notifications.
8162 (emacs_settings_constructor, emacs_settings_get_property)
8163 (emacs_settings_set_property, emacs_settings_class_init):
8164 New functions.
8165 (gsettings_client, gsettings_obj): New variables.
8166 (GSETTINGS_SCHEMA): New define.
8167 (something_changedCB): Call store_monospaced_changed.
8168 (init_gsettings): New function.
8169 (xsettings_initialize): Call init_gsettings.
8170 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8171 to NULL.
8172
640c8776 8173 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8174 GCONF_CFLAGS/LIBS.
8175
5386012d
MR
81762011-06-29 Martin Rudalics <rudalics@gmx.at>
8177
8178 * window.c (resize_root_window, grow_mini_window)
8179 (shrink_mini_window): Rename Qresize_root_window to
8180 Qwindow_resize_root_window and Qresize_root_window_vertically to
8181 Qwindow_resize_root_window_vertically.
8182
f13e0b08
PE
81832011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8184
8185 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8186
94515237
JB
81872011-06-27 Juanma Barranquero <lekktu@gmail.com>
8188
8189 * makefile.w32-in: Redesign dependencies so they reflect more
8190 clearly which files are directly included by each source file,
8191 and not through other includes.
8192
e43b6e43
MR
81932011-06-27 Martin Rudalics <rudalics@gmx.at>
8194
8195 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8196 (sort_overlays, overlay_strings): When an overlay's clone number
8197 matches the window's clone number process the overlay even if
8198 the overlay's window property doesn't match the current window.
8199
d68443dc
MR
8200 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8201 (Fwindow_hchild): Rename to Fwindow_left_child.
8202 (Fwindow_next): Rename to Fwindow_next_sibling.
8203 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8204 (resize_window_check): Rename to window_resize_check.
8205 (resize_window_apply): Rename to window_resize_apply.
8206 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8207 (Fdelete_other_windows_internal, resize_frame_windows)
8208 (Fsplit_window_internal, Fdelete_window_internal)
8209 (grow_mini_window, shrink_mini_window)
8210 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8211
c7e73be5
JD
82122011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8213
8214 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8215 (emacs_fixed_set_min_size): Remove.
8216 (emacs_fixed_new): Take frame as argument.
8217
8218 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8219 (_EmacsFixedPrivate): Remove minwidth/height.
8220 Add struct frame *f.
8221 (emacs_fixed_init): Initialize priv->f.
8222 (get_parent_class, emacs_fixed_set_min_size): Remove.
8223 (emacs_fixed_new): Set priv->f to argument.
8224 (emacs_fixed_get_preferred_width)
8225 (emacs_fixed_get_preferred_height): Use min_width/height from
8226 frames size_hint to set minimum and natural (Bug#8919).
8227 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8228 and use min_width/height from frames size_hint to set
8229 min_width/height (Bug#8919).
8230
8231 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8232 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8233 Fix indentation.
c7e73be5 8234
cf99dcf8
EZ
82352011-06-26 Eli Zaretskii <eliz@gnu.org>
8236
8237 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8238 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8239 called at ZV.
8240
029529ac
CY
82412011-06-26 Chong Yidong <cyd@stupidchicken.com>
8242
8243 * process.c (wait_reading_process_output): Bypass select if
8244 waiting for a cell while ignoring keyboard input, and input is
8245 pending. Suggested by Jan Djärv (Bug#8869).
8246
7a7ef429
PE
82472011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8248
8249 Use gnulib's dup2 module instead of rolling our own.
8250 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8251
11fdef7d 82522011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8253
8254 * dispnew.c (scrolling_window): Before scrolling, turn off a
8255 mouse-highlight in the window being scrolled.
8256
cd3520a4
JB
82572011-06-24 Juanma Barranquero <lekktu@gmail.com>
8258
8259 Move DEFSYM to lisp.h and use everywhere.
8260
8261 * character.h (DEFSYM): Move declaration...
8262 * lisp.h (DEFSYM): ...here.
8263
8264 * gnutls.c:
8265 * minibuf.c:
8266 * w32menu.c:
8267 * w32proc.c:
8268 * w32select.c: Don't include character.h.
8269
8270 * alloc.c (syms_of_alloc):
8271 * buffer.c (syms_of_buffer):
8272 * bytecode.c (syms_of_bytecode):
8273 * callint.c (syms_of_callint):
8274 * casefiddle.c (syms_of_casefiddle):
8275 * casetab.c (init_casetab_once):
8276 * category.c (init_category_once, syms_of_category):
8277 * ccl.c (syms_of_ccl):
8278 * cmds.c (syms_of_cmds):
8279 * composite.c (syms_of_composite):
8280 * dbusbind.c (syms_of_dbusbind):
8281 * dired.c (syms_of_dired):
8282 * dispnew.c (syms_of_display):
8283 * doc.c (syms_of_doc):
8284 * editfns.c (syms_of_editfns):
8285 * emacs.c (syms_of_emacs):
8286 * eval.c (syms_of_eval):
8287 * fileio.c (syms_of_fileio):
8288 * fns.c (syms_of_fns):
8289 * frame.c (syms_of_frame):
8290 * fringe.c (syms_of_fringe):
8291 * insdel.c (syms_of_insdel):
8292 * keymap.c (syms_of_keymap):
8293 * lread.c (init_obarray, syms_of_lread):
8294 * macros.c (syms_of_macros):
8295 * msdos.c (syms_of_msdos):
8296 * print.c (syms_of_print):
8297 * process.c (syms_of_process):
8298 * search.c (syms_of_search):
8299 * sound.c (syms_of_sound):
8300 * syntax.c (init_syntax_once, syms_of_syntax):
8301 * terminal.c (syms_of_terminal):
8302 * textprop.c (syms_of_textprop):
8303 * undo.c (syms_of_undo):
8304 * w32.c (globals_of_w32):
8305 * window.c (syms_of_window):
8306 * xdisp.c (syms_of_xdisp):
8307 * xfaces.c (syms_of_xfaces):
8308 * xfns.c (syms_of_xfns):
8309 * xmenu.c (syms_of_xmenu):
8310 * xsettings.c (syms_of_xsettings):
8311 * xterm.c (syms_of_xterm): Use DEFSYM.
8312
4228cf16
TZ
83132011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8314
cd3520a4 8315 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8316
7fcccf1e
PE
83172011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8318
7efb4e0e
PE
8319 Integer and buffer overflow fixes (Bug#8873).
8320
ff5844ad
PE
8321 * print.c (printchar, strout): Check for string overflow.
8322 (PRINTPREPARE, printchar, strout):
8323 Don't set size unless allocation succeeds.
8324
90532f02
PE
8325 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8326 for sizes. Check for string overflow more accurately.
8327 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8328
6d84508d
PE
8329 * macros.c: Integer and buffer overflow fixes.
8330 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8331 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8332 Use ptrdiff_t, not int, for sizes.
8333 Don't increment bufsize until after realloc succeeds.
8334 Check for size-calculation overflow.
8335 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8336
437b2cb4
PE
8337 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8338
8b9ac8b4
PE
8339 * lread.c: Integer overflow fixes.
8340 (read_integer): Radix is now EMACS_INT, not int,
8341 to improve quality of diagnostics for out-of-range radices.
8342 Calculate buffer size correctly for out-of-range radices.
8343 (read1): Check for integer overflow in radices, and in
8344 read-circle numbers.
82cb60d3
PE
8345 (read_escape): Avoid int overflow.
8346 (Fload, openp, read_buffer_size, read1)
8347 (substitute_object_recurse, read_vector, read_list, map_obarray):
8348 Use ptrdiff_t, not int, for sizes.
8349 (read1): Use EMACS_INT, not int, for sizes.
20270765 8350 Check for size overflow.
8b9ac8b4 8351
7fcccf1e
PE
8352 * image.c (cache_image): Check for size arithmetic overflow.
8353
bfbbd7e7
PE
8354 * lread.c: Integer overflow issues.
8355 (saved_doc_string_size, saved_doc_string_length)
8356 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8357 Now ptrdiff_t, not int.
8358 (read1): Don't assume doc string length fits in int. Check for
8359 out-of-range doc string lengths.
8360 (read_list): Don't assume file position fits in int.
39019e54 8361 (read_escape): Check for hex character overflow.
bfbbd7e7 8362
4e323265
LL
83632011-06-22 Leo Liu <sdl.web@gmail.com>
8364
8365 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8366 Move to minibuffer.el.
8367
85fece3e
PE
83682011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8369
20b84ce9 8370 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8371 The following patches are for when GLYPH_DEBUG && !XASSERT.
8372 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8373 * dispnew.c (flush_stdout):
8374 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8375 Mark as externally visible.
8376 * dispnew.c (check_window_matrix_pointers): Now static.
8377 * dispnew.c (window_to_frame_vpos):
8378 * xfns.c (unwind_create_frame):
8379 * xterm.c (x_check_font): Remove unused local.
8380 * scroll.c (CHECK_BOUNDS):
8381 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8382 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8383 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8384 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8385 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8386 Now static.
8387 (debug_method_add): Use va_list and vsprintf rather than relying
8388 on undefined behavior with wrong number of arguments.
8389 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8390 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8391 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8392 since we're not interested in debugging glyphs with old libraries.
8393 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8394 GCC 4.6.0's static checking.
8395
0766b489
PE
83962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8397
31fd4b32
PE
8398 Integer overflow and signedness fixes (Bug#8873).
8399 A few related buffer overrun fixes, too.
8400
b79e8648
PE
8401 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8402
0766b489
PE
8403 * dispextern.h (struct face.stipple):
8404 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8405 (x_bitmap_mask, x_allocate_bitmap_record)
8406 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8407 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8408 (x_create_bitmap_from_xpm_data):
8409 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8410 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8411 (.bitmaps_last):
8412 * xfaces.c (load_pixmap):
8413 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8414 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8415 (.bitmaps_last, struct x_output.icon_bitmap):
8416 Use ptrdiff_t, not int, for bitmap indexes.
8417 (x_allocate_bitmap_record): Check for size overflow.
8418 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8419
b081724f
PE
8420 Use ptrdiff_t, not int, for overlay counts.
8421 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8422 * editfns.c (overlays_around, get_pos_property):
8423 * textprop.c (get_char_property_and_overlay):
8424 * xdisp.c (next_overlay_change, note_mouse_highlight):
8425 * xfaces.c (face_at_buffer_position):
21514da7
PE
8426 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8427 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8428 (Fnext_overlay_change, Fprevious_overlay_change)
8429 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8430 Use ptrdiff_t, not int, for sizes.
21514da7 8431 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8432
3de73e5e
PE
8433 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8434
2606c57b
PE
8435 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8436 (x_session_initialize): Do not assume string length fits in int.
8437
aaafe47a
PE
8438 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8439 This is unlikely, but can occur if DPI is outlandish.
8440
2674ddc8 8441 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8442 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8443
28154962
PE
8444 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8445 * xrdb.c (magic_file_p, search_magic_path):
8446 Omit last arg SUFFIX; it was always 0. All callers changed.
8447 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8448
7de51af5
PE
8449 * xfont.c (xfont_match): Avoid need for strlen.
8450
25ed6cc3
PE
8451 * xfns.c: Don't assume strlen fits in int.
8452 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8453
4eab31dd
PE
8454 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8455 not unsigned long, as we prefer signed integers. All callers changed.
8456 Detect integer overflow in repeat count.
8457 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8458 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8459
171e2a58
PE
8460 * termcap.c: Don't assume sizes fit in int and never overflow.
8461 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8462 (gobble_line): Check for size-calculation overflow.
8463
ad39faca 8464 * minibuf.c (Fread_buffer):
6e5bb2dc 8465 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8466 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8467 Don't assume string length fits in int.
8468
52c61c22 8469 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8470 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8471
b5b8c9e5
PE
8472 * font.c: Don't assume string length fits in int.
8473 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8474 Use ptrdiff_t, not int.
ccd6111c
PE
8475 (font_intern_prop): Don't assume string length fits in int.
8476 Don't assume integer property fits in fixnum.
8477 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8478
882f0d81 8479 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8480 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8481 Reformulate so as not to need the command string.
8482 Invoke gzip -cd rather than gunzip, as it's more portable.
8483 (lock_info_type, lock_file_1, lock_file):
8484 Don't assume pid_t and time_t fit in unsigned long.
8485 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8486 (current_lock_owner): Prefer signed type for sizes.
8487 Use memcpy, not strncpy, where memcpy is what is really wanted.
8488 Don't assume (via atoi) that time_t and pid_t fit in int.
8489 Check for time_t and/or pid_t out of range, e.g., via a network share.
8490 Don't alloca where an auto var works fine.
8491
93f4cf88
PE
8492 * fileio.c: Fix some integer overflow issues.
8493 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8494 Don't assume string length fits in int.
8495 (directory_file_name): Don't assume string length fits in long.
8496 (make_temp_name): Don't assume pid fits in int, or that its print
8497 length is less than 20.
8498
f3e92b69
PE
8499 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8500
1bfdaf10
PE
8501 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8502
35016e9a
PE
8503 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8504
3d1e65a1
PE
8505 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8506 We prefer signed integers, even for size calculations.
8507
0b963a93
PE
8508 * emacs.c: Don't assume string length fits in 'int'.
8509 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8510 (main): Don't invoke strlen when not needed.
8511
573f4b54
PE
8512 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8513 (XD_DEBUG_MESSAGE): Don't waste a byte.
8514
989f33ba
PE
8515 * callproc.c (getenv_internal_1, getenv_internal)
8516 (Fgetenv_internal):
965d34eb
PE
8517 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8518
e4d29b33
PE
8519 * lread.c (invalid_syntax): Omit length argument.
8520 All uses changed. This doesn't fix a bug, but it simplifies the
8521 code away from its former Hollerith-constant appearance, and it's
8522 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8523 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8524
eb49b136
PE
8525 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8526 This didn't break anything, but it didn't help either.
8527 It's confusing to put a bogus integer in a place where the actual
8528 value does not matter.
9f62aeb1 8529 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8530 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8531
15375a22
PE
8532 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8533 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8534 implementation.
b61cc01c
PE
8535 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8536 We prefer signed types, and the value cannot exceed the EMACS_INT
8537 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8538 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8539 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8540 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8541
53b2623d
PE
8542 * indent.c (sane_tab_width): New function.
8543 (current_column, scan_for_column, Findent_to, position_indentation)
8544 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8545 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8546
51cab52b 8547 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8548
f2ed8a70
PE
8549 * lisp.h (lint_assume): New macro.
8550 * composite.c (composition_gstring_put_cache):
8551 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8552
abe80cc6
PE
8553 * editfns.c, insdel.c:
8554 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8555
b02c740e
PE
8556 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8557
ebc96716
PE
8558 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8559
b4e50fa0 8560 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8561 Use much-faster test for byte-length change.
311d5d7c 8562 Don't assume string byte-length fits in 'int'.
a4cf38e4 8563 Check that character arg fits in 'int'.
85461888 8564 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8565
c0c1ee9f
PE
8566 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8567
a498d7f4
PE
8568 * fns.c (concat): Catch string overflow earlier.
8569 Do not rely on integer wraparound.
8570
51cab52b
PE
8571 * dispextern.h (struct it.overlay_strings_charpos)
8572 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8573 * xdisp.c (forward_to_next_line_start)
8574 (back_to_previous_visible_line_start)
8575 (reseat_at_next_visible_line_start, next_element_from_buffer):
8576 Don't arbitrarily truncate the value of 'selective' to int.
8577
76031fad
PE
8578 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8579
5eb55db9
PE
8580 * composite.c: Don't truncate sizes to 'int'.
8581 (composition_gstring_p, composition_reseat_it)
8582 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8583 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8584 not EMACS_UINT, for indexes.
5eb55db9 8585
0703a717
PE
8586 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8587
d6202519
PE
8588 * buffer.c: Include <verify.h>.
8589 (struct sortvec.priority, struct sortstr.priority):
8961a454 8590 Now EMACS_INT, not int.
c20998a7 8591 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8592 (struct sortstr.size, record_overlay_string)
8593 (struct sortstrlist.size, struct sortlist.used):
8594 Don't truncate size to int.
8595 (record_overlay_string): Check for size-calculation overflow.
d6202519 8596 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8597
d5a19415
JM
85982011-06-22 Jim Meyering <meyering@redhat.com>
8599
029529ac 8600 Don't leak an XBM-image-sized buffer
d5a19415
JM
8601 * image.c (xbm_load): Free the image buffer after using it.
8602
a9041e6c
PE
86032011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8604
8605 Port to Sun C.
8606 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8607 that Sun C diagnosed.
8608 * fns.c (secure_hash): Fix pointer signedness issue.
8609 * intervals.c (static_offset_intervals): New function.
8610 (offset_intervals): Use it.
8611
7f3f739f
LL
86122011-06-21 Leo Liu <sdl.web@gmail.com>
8613
8614 * deps.mk (fns.o):
8615 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8616 sha512.h.
8617
8618 * fns.c (secure_hash): Rename from crypto_hash_function and change
8619 the first arg to accept symbols.
5b66d427 8620 (Fsecure_hash): New primitive.
7f3f739f
LL
8621 (syms_of_fns): New symbols.
8622
76147d94
DD
86232011-06-20 Deniz Dogan <deniz@dogan.se>
8624
8625 * process.c (Fset_process_buffer): Clarify return value in
8626 docstring.
8627
7d7d0045
CY
86282011-06-18 Chong Yidong <cyd@stupidchicken.com>
8629
8630 * dispnew.c (add_window_display_history): Use BVAR.
8631
8632 * xdisp.c (debug_method_add): Use BVAR.
8633 (check_window_end, dump_glyph_matrix, dump_glyph)
8634 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8635
8636 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8637 Likewise.
8638
8639 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8640 check till after the cache is created in init_frame_faces.
8641
ff2bc410
SM
86422011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8643
8644 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8645
28177add
PE
86462011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8647
dd3482fe
PE
8648 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8649 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8650 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8651
393d71f3 8652 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8653 * fileio.c (Finsert_file_contents):
8654 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8655 Remove the old (too-loose) buffer overflow checks.
8656 They weren't needed, since make_gap checks for buffer overflow.
8657 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8658 The old code merely checked for Emacs fixnum overflow, and relied
8659 on undefined (wraparound) behavior. The new code avoids undefined
8660 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8661
2e6813b0 8662 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8663 Tune. Don't use wider integers than needed. Don't use alloca.
8664 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8665
599a9e4f
PE
8666 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8667
99561444
PE
8668 * insdel.c, lisp.h (buffer_overflow): New function.
8669 (insert_from_buffer_1, replace_range, replace_range_2):
8670 * insdel.c (make_gap_larger):
8671 * editfns.c (Finsert_char):
8672 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8673
28177add
PE
8674 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8675
e69dafad
PE
86762011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8677
4baa020d 8678 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8679
b1c46f02
PE
8680 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8681 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8682
e69dafad
PE
8683 * fileio.c: Don't assume EMACS_INT fits in off_t.
8684 (emacs_lseek): New static function.
8685 (Finsert_file_contents, Fwrite_region): Use it.
8686 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8687
566684ea
PE
8688 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8689
e6966cd6
PE
8690 * fns.c: Don't overflow int when computing a list length.
8691 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8692 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8693 truncation on 64-bit hosts. Check for QUIT every
8694 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8695 faster and is responsive enough.
8696 (Flength): Report an error instead of overflowing an integer.
8697 (Fsafe_length): Return a float if the value is not representable
8698 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8699 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8700 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8701
dd0b0efb
PE
8702 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8703 (header_size, word_size): New constants.
8704 (allocate_vectorlike): Don't check size overflow here.
8705 (allocate_vector): Check it here instead, since this is the only
8706 caller of allocate_vectorlike that could cause overflow.
8707 Check that the new vector's length is representable as a fixnum.
8708
86fe5cfe
PE
8709 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8710 The previous code was bogus. For example, next_almost_prime (32)
8711 returned 39, which is undesirable as it is a multiple of 3; and
8712 next_almost_prime (24) returned 25, which is a multiple of 5 so
8713 why was the code bothering to check for multiples of 7?
8714
80e88859
PE
8715 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8716
4a2f0ad6
PE
8717 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8718
f66c7cf8
PE
8719 Variadic C functions now count arguments with ptrdiff_t.
8720 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8721 Back then I didn't know that the Emacs coding style prefers signed int.
8722 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8723 were being counted with int, which may truncate counts on 64-bit
8724 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8725 * lisp.h (struct Lisp_Subr.function.aMANY)
8726 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8727 Arg counts are now ptrdiff_t, not size_t.
8728 All variadic functions and their callers changed accordingly.
8729 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8730 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8731 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8732 * callint.c (Fcall_interactively): Check arg count for overflow,
8733 to avoid potential buffer overrun. Use signed char, not 'int',
8734 for 'varies' array, so that we needn't bother to check its size
8735 calculation for overflow.
8736 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8737 * eval.c (apply_lambda):
8738 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8739 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8740 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8741
a1759b76
PE
8742 * callint.c (Fcall_interactively): Don't use index var as event count.
8743
d96be9fc
PE
8744 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8745 * mem-limits.h (SIZE): Remove; no longer used.
8746
a690a978 8747 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8748
578c21e6
PE
8749 Remove unnecessary casts.
8750 * xterm.c (x_term_init):
8751 * xfns.c (x_set_border_pixel):
8752 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8753 These aren't needed now that we assume ANSI C.
8754
96f53c6c
PE
8755 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8756 It's more likely to cause problems (due to unsigned overflow)
8757 than to cure them.
8758
83c77d31
PE
8759 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8760
ee2079f1
PE
8761 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8762
6da65536
PE
8763 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8764
7147c4a4
PE
8765 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8766
193e32d9
PE
8767 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8768
e5533da6
PE
8769 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8770
9910e595
PE
8771 GLYPH_CODE_FACE returns EMACS_INT, not int.
8772 * dispextern.h (merge_faces):
8773 * xfaces.c (merge_faces):
01103c44
PE
8774 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8775 Don't assume EMACS_INT fits in int.
9910e595 8776
2638320e
PE
8777 * character.h (CHAR_VALID_P): Remove unused parameter.
8778 * fontset.c, lisp.h, xdisp.c: All uses changed.
8779
045eb8d9
PE
8780 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8781
c1f134b5
PE
8782 * fns.c (concat): Minor tuning based on overflow analysis.
8783 This doesn't fix any bugs. Use int to hold character, instead
8784 of constantly refetching from Emacs object. Use XFASTINT, not
8785 XINT, for value known to be a character. Don't bother comparing
8786 a single byte to 0400, as it's always less.
8787
395fcb93 8788 * floatfns.c (Fexpt):
327eeec8
PE
8789 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8790
abbd3d23
PE
8791 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8792 for characters.
8793
684a03ef
PE
8794 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8795
0fed43f3
PE
8796 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8797 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8798 incorrectly succeed when S was a string, because 4294967386 was
8799 truncated before it was used.
8800
8fd02eb7
PE
8801 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8802 Otherwise, an out-of-range integer could cause undefined behavior
8803 on a 64-bit host.
8804
f8c86b69
PE
8805 * composite.c: Use int, not EMACS_INT, for characters.
8806 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8807 EMACS_INT, for values that are known to be in character range.
8808 This doesn't fix any bugs but is the usual style inside Emacs and
8809 may generate better code on 32-bit machines.
8810
34206dd2
PE
8811 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8812 This is for reasons similar to the recent CHAR_STRING fix.
8813 * charset.c (Fencode_char): Check that character arg is actually
8814 a character. Pass an int to ENCODE_CHAR.
8815 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8816 wider than 'int', as a compile-time check to prevent future regressions
8817 in this area.
8818
c5958d4c 8819 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8820
8821 Make sure a 64-bit char is never passed to CHAR_STRING.
8822 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8823 by silently ignoring the top 32 bits, allowing some values
8824 that were far too large to be valid characters.
8825 * character.h: Include <verify.h>.
8826 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8827 arguments are no wider than unsigned, as a compile-time check
8828 to prevent future regressions in this area.
8829 * data.c (Faset):
01103c44 8830 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8831 (Fsubst_char_in_region):
8832 * fns.c (concat):
8833 * xdisp.c (decode_mode_spec_coding):
8834 Adjust to CHAR_STRING's new requirement.
8835 * editfns.c (Finsert_char, Fsubst_char_in_region):
8836 * fns.c (concat): Check that character args are actually
8837 characters. Without this test, these functions did the wrong
8838 thing with wildly out-of-range values on 64-bit hosts.
8839
d37ca623
PE
8840 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8841 These casts should not be needed on 32-bit hosts, either.
8842 * keyboard.c (read_char):
8843 * lread.c (Fload): Remove casts to unsigned.
8844
ea204efb
PE
8845 * lisp.h (UNSIGNED_CMP): New macro.
8846 This fixes comparison bugs on 64-bit hosts.
8847 (ASCII_CHAR_P): Use it.
8848 * casefiddle.c (casify_object):
01103c44 8849 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8850 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8851 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8852 * dispextern.h (FACE_FROM_ID):
8853 * keyboard.c (read_char): Use UNSIGNED_CMP.
8854
41cb286c
PE
8855 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8856 not to EMACS_INT, to avoid GCC warning.
8857
4a1b9832
PE
8858 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8859
55daad71
PE
8860 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8861 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8862 isn't needed on 32-bit machines.
8f95c75c 8863
01103c44
PE
8864 * buffer.c (Fgenerate_new_buffer_name):
8865 Use EMACS_INT for count, not int.
0ceccced 8866 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8867
8868 * data.c (Qcompiled_function): Now static.
8869
c6f072e7
PE
8870 * window.c (window_body_lines): Now static.
8871
20ce5912
PE
8872 * image.c (gif_load): Rename local to avoid shadowing.
8873
9c4c5f81
PE
8874 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8875 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8876 * alloc.c (make_save_value): Integer argument is now of type
8877 ptrdiff_t, not int.
8878 (mark_object): Use ptrdiff_t, not int.
8879 * lisp.h (pD): New macro.
8880 * print.c (print_object): Use it.
8881
c0c5c8ae
PE
8882 * alloc.c: Use EMACS_INT, not int, to count objects.
8883 (total_conses, total_markers, total_symbols, total_vector_size)
8884 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8885 (total_free_floats, total_floats, total_free_intervals)
8886 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8887 Now EMACS_INT, not int. All uses changed.
8888 (Fgarbage_collect): Compute overall total using a double, so that
8889 integer overflow is less likely to be a problem. Check for overflow
8890 when converting back to an integer.
5a25e253
PE
8891 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8892 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8893 These were 'int' variables that could overflow on 64-bit hosts;
8894 they were never used, so remove them instead of repairing them.
211a0b2a 8895 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8896 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8897 Previously, this ceilinged at INT_MAX, but that doesn't work on
8898 64-bit machines.
e46bb31a 8899 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8900
c78baabf 8901 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8902 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8903 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8904 when a (possibly-narrower) signed value would do just as well.
8905 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8906
c9d624c6
PE
8907 * alloc.c: Catch some string size overflows that we were missing.
8908 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8909 for convenience in STRING_BYTES_MAX.
8910 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8911 The definition here is exact; the one in lisp.h was approximate.
8912 (allocate_string_data): Check for string overflow. This catches
8913 some instances we weren't catching before. Also, it catches
8914 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8915 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8916 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8917
c9d624c6
PE
8918 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8919 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8920 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8921
353032ce
PE
8922 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8923
2bccce07
PE
8924 * alloc.c (Fmake_string): Check for out-of-range init.
8925
0ac30604
SM
89262011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8927
8928 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8929
c195f2de
JD
89302011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8931
8932 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8933 xg_get_default_scrollbar_width.
8934
8935 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8936 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8937 (style_changed_cb): Call update_theme_scrollbar_width and call
8938 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8939 all frames (Bug#8505).
8940 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8941 Call gtk_window_set_resizable if HAVE_GTK3.
8942 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8943 and height if HAVE_GTK3 (Bug#8505).
8944 (scroll_bar_width_for_theme): New variable.
8945 (update_theme_scrollbar_width): New function.
8946 (xg_get_default_scrollbar_width): Move code to
8947 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8948 (xg_initialize): Call update_theme_scrollbar_width.
8949
8950 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8951
8952 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8953
e10ac9f1
MR
89542011-06-12 Martin Rudalics <rudalics@gmx.at>
8955
8956 * frame.c (make_frame): Call other_buffer_safely instead of
8957 other_buffer.
8958
8959 * window.c (temp_output_buffer_show): Call display_buffer with
8960 second argument Vtemp_buffer_show_specifiers and reset latter
8961 immediately after the call.
8962 (Vtemp_buffer_show_specifiers): New variable.
8963 (auto_window_vscroll_p, next_screen_context_lines)
8964 (Vscroll_preserve_screen_position): Remove leading asterisks from
8965 doc-strings.
8966
2d3c217e 89672011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8968
7b7f97e8 8969 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8970 * buffer.c (Qclone_number): Remove for now, as it's unused.
8971 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8972 (record_buffer): Remove unused local.
8973 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8974 (set_frame_buffer_list): Remove; unused.
8975 * frame.h (other_visible_frames): Remove decl.
8976 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8977 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8978 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8979 if HAVE_GPM.
8980 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8981 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8982 Define only if HAVE_GPM.
8983 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8984 (update_hints_inhibit): Remove; never set. All uses removed.
8985 * widgetprv.h (emacsFrameClassRec): Remove decl.
8986 * window.c (delete_deletable_window): Now returns void, since it
8987 wasn't returning anything.
8988 (compare_window_configurations): Remove unused locals.
8989 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8990 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8991 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8992 the same widths as pointers. This follows up on the 2011-05-06 patch.
8993 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8994 * xterm.h: Likewise.
8995 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8996
1384b89e
JB
89972011-06-12 Juanma Barranquero <lekktu@gmail.com>
8998
8999 * makefile.w32-in: Update dependencies.
9000 (LISP_H): Add lib/intprops.h.
9001
1100a63c
CY
90022011-06-11 Chong Yidong <cyd@stupidchicken.com>
9003
9004 * image.c (gif_load): Add animation frame delay to the metadata.
9005 (syms_of_image): Use DEFSYM. New symbol `delay'.
9006
6198ccd0
MR
90072011-06-11 Martin Rudalics <rudalics@gmx.at>
9008
9009 * window.c (delete_deletable_window): Re-add.
9010 (Fset_window_configuration): Rewrite to handle dead buffers and
9011 consequently deletable windows.
9012 (window_tree, Fwindow_tree): Remove. Supply functionality in
9013 window.el.
9014 (compare_window_configurations): Simplify code.
9015
b6e3633c
AS
90162011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9017
1ab0dee5
AS
9018 * image.c (imagemagick_load_image): Fix type mismatch.
9019 (Fimagemagick_types): Likewise.
9020
b6e3633c
AS
9021 * window.h (replace_buffer_in_windows): Declare.
9022
9397e56f
MR
90232011-06-11 Martin Rudalics <rudalics@gmx.at>
9024
9025 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9026 Qclone_number. Remove external declaration of Qdelete_window.
9027 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9028 code.
640c8776
SM
9029 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9030 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9031 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9032 buffer list implementation.
9033 (other_buffer_safely): New function.
9034 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9035 calls to replace_buffer_in_windows and
9036 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9037 if allowed.
9038 (record_buffer): Inhibit quitting and rewrite using quittable
9039 functions. Run Qbuffer_list_update_hook if allowed.
9040 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9041 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9042 Move switch-to-buffer to window.el.
9397e56f
MR
9043 (bury-buffer): Move to window.el.
9044 (Vbuffer_list_update_hook): New variable.
9045
9046 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9047 section.
9048
9049 * window.h (resize_frame_windows): Move up in code.
9050 (Fwindow_frame): Remove EXFUN.
9051 (replace_buffer_in_all_windows): Remove prototype.
9052 (replace_buffer_in_windows_safely): Add prototype.
9053
9054 * window.c: Declare Qdelete_window static again. Move down
9055 declaration of select_count.
9056 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9057 (Fother_window): Move to window.el.
9058 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9059 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9060 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9061 window.el.
9062 (replace_buffer_in_windows): Implement by calling
9063 Qreplace_buffer_in_windows.
9064 (replace_buffer_in_all_windows): Remove with some functionality
9065 moved into replace_buffer_in_windows_safely.
9066 (replace_buffer_in_windows_safely): New function.
9067 (select_window_norecord, select_frame_norecord): Move in front
9068 of run_window_configuration_change_hook. Remove now obsolete
9069 declarations.
640c8776
SM
9070 (Fset_window_buffer): Rewrite doc-string.
9071 Call Qrecord_window_buffer.
9397e56f
MR
9072 (keys_of_window): Move binding for other-window to window.el.
9073
b50691aa
CY
90742011-06-11 Chong Yidong <cyd@stupidchicken.com>
9075
9076 * dispextern.h (struct image): Replace data member, whose int_val
9077 and ptr_val fields were not used by anything, with a single
9078 lisp_val object.
9079
9080 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9081 (gif_clear_image, gif_load, imagemagick_load_image)
9082 (gs_clear_image, gs_load): Callers changed.
9083
3f754b86
PE
90842011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9085
cca69397
PE
9086 * buffer.h: Include <time.h>, for time_t.
9087 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9088
109e28d0
PE
9089 Fix minor problems found by static checking.
9090
60737f02
PE
9091 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9092
4b66faf3
PE
9093 Make identifiers static if they are not used in other modules.
9094 * data.c (Qcompiled_function, Qframe, Qvector):
9095 * image.c (QimageMagick, Qsvg):
9096 * minibuf.c (Qmetadata):
9097 * window.c (resize_window_check, resize_root_window): Now static.
9098 * window.h (resize_window_check, resize_root_window): Remove decls.
9099
109e28d0
PE
9100 * window.c (window_deletion_count, delete_deletable_window):
9101 Remove; unused.
46a4ce9e
PE
9102 (window_body_lines): Now static.
9103 (Fdelete_other_windows_internal): Mark vars as initialized.
9104 Make sure 'resize_failed' is initialized.
9105 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9106 (resize_window_apply): Remove unused local.
9107 * window.h (delete_deletable_window): Remove decl.
9108
109e28d0 9109 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9110 (imagemagick_load_image): Fix pointer signedness problem by changing
9111 last arg from unsigned char * to char *. All uses changed.
9112 Also, fix a local for similar reasons.
9113 Remove unused locals. Remove locals to avoid shadowing.
9114 (fn_rsvg_handle_free): Remove; unused.
9115 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9116 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9117
3f754b86
PE
9118 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9119
2547adb1
CY
91202011-06-10 Chong Yidong <cyd@stupidchicken.com>
9121
9122 * image.c (gif_load): Fix omitted cast error introduced by
9123 2011-06-06 change.
9124
2c8e37d4
MR
91252011-06-10 Martin Rudalics <rudalics@gmx.at>
9126
9127 * window.h (resize_proportionally, orig_total_lines)
9128 (orig_top_line): Remove from window structure.
9129 (set_window_height, set_window_width, change_window_heights)
9130 (Fdelete_window): Remove prototypes.
9131 (resize_frame_windows): Remove duplicate declaration.
9132
440a42e3
EZ
91332011-06-10 Eli Zaretskii <eliz@gnu.org>
9134
9135 * window.h (resize_frame_windows, resize_window_check)
9136 (delete_deletable_window, resize_root_window)
9137 (resize_frame_windows): Declare prototypes.
9138
9139 * window.c (resize_window_apply): Make definition be "static" to
9140 match the prototype.
9141
562dd5e9
MR
91422011-06-10 Martin Rudalics <rudalics@gmx.at>
9143
9144 * window.c: Remove declarations of Qwindow_size_fixed,
9145 window_min_size_1, window_min_size_2, window_min_size,
9146 size_window, window_fixed_size_p, enlarge_window, delete_window.
9147 Remove static from declaration of Qdelete_window, it's
9148 temporarily needed by Fbury_buffer.
9149 (replace_window): Don't assign orig_top_line and
9150 orig_total_lines.
9151 (Fdelete_window, delete_window): Remove. Window deletion is
9152 handled by window.el.
640c8776
SM
9153 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9154 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9155 (Fdelete_other_windows): Remove. Deleting other windows is
9156 handled by window.el.
9157 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9158 handled in window.el.
9159 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9160 Window minimum sizes are handled in window.el.
9161 (shrink_windows, size_window, set_window_height)
9162 (set_window_width, change_window_heights, window_height)
9163 (window_width, CURBEG, CURSIZE, enlarge_window)
9164 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9165 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9166 handled in window.el.
9167 (make_dummy_parent): Rename to make_parent_window and give it a
9168 second argument horflag.
9169 (make_window): Don't set resize_proportionally any more.
9170 (Fsplit_window): Remove. Windows are split in window.el.
9171 (save_restore_action, save_restore_orig_size)
9172 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9173 Resize mini windows in window.el.
9174 (grow_mini_window, shrink_mini_window): Implement by calling
9175 Qresize_root_window_vertically, resize_window_check and
9176 resize_window_apply.
640c8776
SM
9177 (saved_window, Fset_window_configuration, save_window_save):
9178 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9179 resize_proportionally.
9180 (window_min_height, window_min_width): Move to window.el.
9181 (keys_of_window): Move bindings for delete-other-windows,
9182 split-window, delete-window and enlarge-window to window.el.
9183
9184 * buffer.c: Temporarily extern Qdelete_window.
9185 (Fbury_buffer): Temporarily call Qdelete_window instead of
9186 Fdelete_window (Fbury_buffer will move to window.el soon).
9187
9188 * frame.c (set_menu_bar_lines_1): Remove code handling
9189 orig_top_line and orig_total_lines.
9190
9191 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9192 set_window_height but set heights directly.
9193 (change_frame_size_1): Use resize_frame_windows.
9194
9195 * xdisp.c (init_xdisp): Don't use set_window_height but set
9196 heights directly.
9197
640c8776
SM
9198 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9199 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9200 run_window_configuration_change_hook.
9201
9202 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9203 instead of change_window_heights and run
9204 run_window_configuration_change_hook.
9205
1a13852e
MR
92062011-06-09 Martin Rudalics <rudalics@gmx.at>
9207
9208 * window.c (replace_window): Rename second argument REPLACEMENT to
9209 NEW. New third argument SETFLAG. Rewrite.
9210 (delete_window, make_dummy_parent): Call replace_window with
9211 third argument 1.
9212 (window_list_1): Move down in code.
9213 (run_window_configuration_change_hook): Move set_buffer part
9214 before select_frame_norecord part in order to unwind correctly.
9215 Rename count1 to count.
9216 (recombine_windows, delete_deletable_window, resize_root_window)
9217 (Fdelete_other_windows_internal)
9218 (Frun_window_configuration_change_hook, make_parent_window)
9219 (resize_window_check, resize_window_apply, Fresize_window_apply)
9220 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9221 (Fdelete_window_internal, Fresize_mini_window_internal):
9222 New functions.
1a13852e
MR
9223 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9224
f3d1777e
MR
92252011-06-08 Martin Rudalics <rudalics@gmx.at>
9226
496e208e
MR
9227 * window.h (window): Add some new members to window structure -
9228 normal_lines, normal_cols, new_total, new_normal, clone_number,
9229 splits, nest, prev_buffers, next_buffers.
9230 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9231 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9232
f3d1777e
MR
9233 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9234 Remove.
496e208e
MR
9235 (make_dummy_parent): Set new members of windows structure.
9236 (make_window): Move down in code. Handle new members of window
9237 structure.
9238 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9239 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9240 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9241 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9242 (Fset_window_next_buffers, Fset_window_clone_number):
9243 New functions.
496e208e
MR
9244 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9245 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9246 Doc-string fixes.
9247 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9248 Argument WINDOW can be now internal window too.
9249 (Fwindow_use_time): Move up in code.
9250 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9251 Rewrite doc-string.
9252 (Fset_window_configuration, saved_window)
9253 (Fcurrent_window_configuration, save_window_save): Handle new
9254 members of window structure.
b9e809c2
MR
9255 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9256 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9257 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9258 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9259 Qget_mru_window, Qresize_root_window,
9260 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9261 Qauto_buffer_name; staticpro them.
f3d1777e 9262
abde8f8c
MR
92632011-06-07 Martin Rudalics <rudalics@gmx.at>
9264
9265 * window.c (Fwindow_total_size, Fwindow_left_column)
9266 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9267 (Fwindow_list_1): New functions.
9268 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9269 (Fwindow_width, Fscroll_left, Fscroll_right):
9270 Use window_body_cols instead of window_box_text_cols.
9271 (delete_window, Fset_window_configuration):
9272 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9273 (delete_all_subwindows): Take a window as argument and not a
9274 structure. Rewrite.
190b47e6
MR
9275 (window_loop): Remove handling of GET_LRU_WINDOW and
9276 GET_LARGEST_WINDOW.
9277 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9278
9279 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9280 window_box_text_cols. delete_all_subwindows now takes a
9281 Lisp_Object as argument.
abde8f8c 9282
640c8776
SM
9283 * indent.c (compute_motion, Fcompute_motion):
9284 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9285
fa8a67e6
MR
9286 * frame.c (delete_frame): Call delete_all_subwindows with root
9287 window as argument.
9288
a54e3482
DC
92892011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9290
9291 * fns.c (Fputhash): Document return value.
9292
60002bf5
CY
92932011-06-06 Chong Yidong <cyd@stupidchicken.com>
9294
9295 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9296
0c671da6 92972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9298
b862a52a 9299 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9300
be44ca6c
PE
9301 Check for overflow when converting integer to cons and back.
9302 * charset.c (Fdefine_charset_internal, Fdecode_char):
9303 Use cons_to_unsigned to catch overflow.
9304 (Fencode_char): Use INTEGER_TO_CONS.
9305 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9306 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9307 * data.c (long_to_cons, cons_to_long): Remove.
9308 (cons_to_unsigned, cons_to_signed): New functions.
9309 These signal an error for invalid or out-of-range values.
9310 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9311 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9312 * font.c (Ffont_variation_glyphs):
9313 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9314 * lisp.h: Include <intprops.h>.
9315 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9316 (cons_to_signed, cons_to_unsigned): New decls.
9317 (long_to_cons, cons_to_long): Remove decls.
9318 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9319 (Fprimitive_undo): Use CONS_TO_INTEGER.
9320 * xfns.c (Fx_window_property): Likewise.
9321 * xselect.c: Include <limits.h>.
9322 (x_own_selection, selection_data_to_lisp_data):
9323 Use INTEGER_TO_CONS.
9324 (x_handle_selection_request, x_handle_selection_clear)
9325 (x_get_foreign_selection, Fx_disown_selection_internal)
9326 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9327 (lisp_data_to_selection_data): Use cons_to_unsigned.
9328 (x_fill_property_data): Use cons_to_signed.
9329 Report values out of range.
9330
d1f3d2af
PE
9331 Check for buffer and string overflow more precisely.
9332 * buffer.h (BUF_BYTES_MAX): New macro.
9333 * lisp.h (STRING_BYTES_MAX): New macro.
9334 * alloc.c (Fmake_string):
9335 * character.c (string_escape_byte8):
9336 * coding.c (coding_alloc_by_realloc):
9337 * doprnt.c (doprnt):
9338 * editfns.c (Fformat):
9339 * eval.c (verror):
9340 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9341 since they may not be the same number.
9342 * editfns.c (Finsert_char):
9343 * fileio.c (Finsert_file_contents):
9344 Likewise for BUF_BYTES_MAX.
9345
dd52fcea
PE
9346 * image.c: Use ptrdiff_t, not int, for sizes.
9347 (slurp_file): Switch from int to ptrdiff_t.
9348 All uses changed.
9349 (slurp_file): Check that file size fits in both size_t (for
9350 malloc) and ptrdiff_t (for sanity and safety).
9351
7f9bbdbb
PE
9352 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9353 if b->modtime has its maximal value.
9354
dfe18f82
PE
9355 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9356
84acfcf0
PE
9357 Don't assume time_t can fit into int.
9358 * buffer.h (struct buffer.modtime): Now time_t, not int.
9359 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9360 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9361
ccd9a01a
PE
9362 Minor fixes for signed vs unsigned integers.
9363 * character.h (MAYBE_UNIFY_CHAR):
9364 * charset.c (maybe_unify_char):
9365 * keyboard.c (read_char, reorder_modifiers):
9366 XINT -> XFASTINT, since the integer must be nonnegative.
9367 * ftfont.c (ftfont_spec_pattern):
9368 * keymap.c (access_keymap, silly_event_symbol_error):
9369 XUINT -> XFASTINT, since the integer must be nonnegative.
9370 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9371 since it makes no difference and we prefer signed.
9372 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9373 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9374 nonnegative.
9375
d6d100dd
SM
93762011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9377
9378 * window.h (Fwindow_frame): Declare.
9379
2b6148e4
PE
93802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9381
9382 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9383 (SPARE_MEMORY): Always define.
9384 (LARGE_REQUEST): Remove.
9385 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9386
f230ecc9
MR
93872011-06-06 Martin Rudalics <rudalics@gmx.at>
9388
727e958e
MR
9389 * lisp.h: Move EXFUNS for Fframe_root_window,
9390 Fframe_first_window and Fset_frame_selected_window to window.h.
9391
9392 * window.h: Move EXFUNS for Fframe_root_window,
9393 Fframe_first_window and Fset_frame_selected_window here from
9394 lisp.h.
9395
9396 * frame.c (Fwindow_frame, Fframe_first_window)
9397 (Fframe_root_window, Fframe_selected_window)
9398 (Fset_frame_selected_window): Move to window.c.
9399 (Factive_minibuffer_window): Move to minibuf.c.
9400 (Fother_visible_frames_p): New function.
9401
9402 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9403
f230ecc9
MR
9404 * window.c (decode_window, decode_any_window): Move up in code.
9405 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9406 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9407 (Fwindow_buffer): Move up and rewrite doc-string.
9408 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9409 (Fwindow_prev): New functions.
727e958e
MR
9410 (Fwindow_frame): Move here from frame.c. Accept any window as
9411 argument.
9412 (Fframe_root_window, Fframe_first_window)
9413 (Fframe_selected_window): Move here from frame.c. Accept frame
9414 or arbitrary window as argument. Update doc-strings.
9415 (Fminibuffer_window): Move up in code.
9416 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9417 (Fset_frame_selected_window): Move here from frame.c.
9418 Marginal rewrite.
727e958e
MR
9419 (Fselected_window, select_window, Fselect_window): Move up in
9420 code. Minor doc-string fixes.
f230ecc9 9421
4d09bcf6
PE
94222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9423
9424 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9425 Do not assume that spare memory exists; that assumption is valid
9426 only if SYSTEM_MALLOC.
9427 (LARGE_REQUEST): New macro, so that the issue of large requests
9428 is separated from the issue of spare memory.
9429
810928a2
AS
94302011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9431
172418ad
AS
9432 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9433 format. (Bug#8806)
9434
43f862f7
AS
9435 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9436
810928a2
AS
9437 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9438 before statements.
9439
a059fe24
JD
94402011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9441
9442 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9443
9444 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9445
9446 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9447 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9448
989bf368
JB
94492011-06-05 Juanma Barranquero <lekktu@gmail.com>
9450
9451 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9452
4b80f674
CY
94532011-06-04 Chong Yidong <cyd@stupidchicken.com>
9454
9455 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9456 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9457 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9458 New error handlers.
4b80f674
CY
9459 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9460 Obey Vx_select_enable_clipboard_manager. Catch errors in
9461 x_clipboard_manager_save (Bug#8779).
9462 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9463 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9464
99a33b77 94652011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9466
9467 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9468
99a33b77 94692011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9470
9471 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9472 in the current matrix if keep_current_p is non-zero.
9473
8264569d
EZ
94742011-06-04 Eli Zaretskii <eliz@gnu.org>
9475
9476 * bidi.c (bidi_level_of_next_char): Fix last change.
9477
57f97249
EZ
94782011-06-03 Eli Zaretskii <eliz@gnu.org>
9479
fec2107c 9480 Support bidi reordering of text covered by display properties.
57f97249 9481
fec2107c
EZ
9482 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9483 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9484 (bidi_cache_search, bidi_cache_iterator_state)
9485 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9486 (bidi_level_of_next_char, bidi_move_to_visually_next):
9487 Support character positions inside a run of characters covered by a
fec2107c
EZ
9488 display string.
9489 (bidi_paragraph_init, bidi_resolve_explicit_1)
9490 (bidi_level_of_next_char): Call bidi_fetch_char and
9491 bidi_fetch_char_advance instead of FETCH_CHAR and
9492 FETCH_CHAR_ADVANCE.
9493 (bidi_init_it): Initialize new members.
9494 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9495 definitions.
9496 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9497 instead of using explicit *_CHAR codes.
d6d100dd
SM
9498 (bidi_resolve_explicit, bidi_resolve_weak):
9499 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9500 bidirectional text is supported only in multibyte buffers.
9501 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9502 it to initialize the frame_window_p member of struct bidi_it.
9503 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9504 (bidi_resolve_explicit, bidi_resolve_weak)
9505 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9506 bidi_it->nchars is non-positive.
9507 (bidi_level_of_next_char): Don't try to lookup the cache for the
9508 next/previous character if nothing is cached there yet, or if we
9509 were just reseat()'ed to a new position.
c40e2fb2 9510
0e14fe90
EZ
9511 * xdisp.c (set_cursor_from_row): Set start and stop points
9512 according to the row's direction when priming the loop that looks
9513 for the glyph on which to display cursor.
9514 (single_display_spec_intangible_p): Function deleted.
9515 (display_prop_intangible_p): Reimplement to call
9516 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9517 Accept 3 additional arguments needed by handle_display_spec.
9518 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9519 values: lists, `(when COND...)' forms, etc.
9520 (single_display_spec_string_p): Support property values that are
9521 lists with the argument STRING its top-level element.
9522 (display_prop_string_p): Fix the condition for processing a
9523 property that is a list to be consistent with handle_display_spec.
fec2107c 9524 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9525 last portion of handle_display_prop.
9526 (compute_display_string_pos): Accept additional argument
9527 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9528 value of a `display' property is a "replacing spec".
9529 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9530 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9531 the display property, but just return a value indicating whether
9532 the display property will replace the characters it covers.
9533 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9534 frame_window_p members of struct bidi_it.
d6d100dd
SM
9535 (compute_display_string_pos, compute_display_string_end):
9536 New functions.
fec2107c
EZ
9537 (push_it): Accept second argument POSITION, where pop_it should
9538 jump to continue iteration.
9539 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9540
fec2107c
EZ
9541 * keyboard.c (adjust_point_for_property): Adjust the call to
9542 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9543
9544 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9545 (bidi_init_it): Update prototypes.
9546 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9547 (compute_display_string_pos, compute_display_string_end):
9548 Declare prototypes.
fec2107c
EZ
9549 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9550 EMACS_INT.
fc6f18ce 9551
40087514 95522011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9553
57f53182
PE
9554 Malloc failure behavior now depends on size of allocation.
9555 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9556 * lisp.h: Change signatures accordingly.
9557 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9558 All callers changed. (Bug#8762)
9559
9560 * gnutls.c: Use Emacs's memory allocators.
9561 Without this change, the gnutls library would invoke malloc etc.
9562 directly, which causes problems on non-SYNC_INPUT hosts, and which
9563 runs afoul of improving memory_full behavior. (Bug#8761)
9564 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9565 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9566 xfree instead of the default malloc, realloc, free.
9567 (Fgnutls_boot): No need to check for memory allocation failure,
9568 since xmalloc does that for us.
9569
ac32cd99 9570 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9571 * category.c (hash_get_category_set):
9572 * ccl.c (ccl_driver):
9573 * charset.c (Fdefine_charset_internal):
9574 * charset.h (struct charset.hash_index):
9575 * composite.c (get_composition_id, gstring_lookup_cache)
9576 (composition_gstring_put_cache):
9577 * composite.h (struct composition.hash_index):
9578 * dispextern.h (struct image.hash):
9579 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9580 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9581 (hashfn_equal, hashfn_user_defined, make_hash_table)
9582 (maybe_resize_hash_table, hash_lookup, hash_put)
9583 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9584 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9585 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9586 * image.c (make_image, search_image_cache, lookup_image)
9587 (xpm_put_color_table_h):
9588 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9589 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9590 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9591 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9592 * alloc.c (allocate_vectorlike):
9593 Check for overflow in vector size calculations.
9594 * ccl.c (ccl_driver):
9595 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9596 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9597 need to be updated by these changes.
40087514
PE
9598 * fns.c (make_hash_table, maybe_resize_hash_table):
9599 Check for integer overflow with large hash tables.
0de4bb68
PE
9600 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9601 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9602 (SXHASH_REDUCE): New macro.
9603 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9604 Use it instead of discarding useful hash info with large hash values.
9605 (sxhash_float): New function.
9606 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9607 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9608 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9609 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9610 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9611 Adjust signatures to match updated version of code.
9612 (consing_since_gc): Now EMACS_INT, since a single hash table can
9613 use more than INT_MAX bytes.
9614
698d32e2
DN
96152011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9616
9617 Make it possible to build with GCC-4.6+ -O2 -flto.
9618
9619 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9620
fd6fa53f
SM
96212011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9622
9623 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9624 Call minibuffer-inactive-mode.
9625
864db017
JB
96262011-05-31 Juanma Barranquero <lekktu@gmail.com>
9627
9628 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9629 Update dependencies.
9630
2ad0baf4
DN
96312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9632
9633 * data.c (init_data): Remove code for UTS, this system is not
9634 supported anymore.
9635
4fcc2638
DN
96362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9637
9638 Don't force ./temacs to start in terminal mode.
9639
9640 * frame.c (make_initial_frame): Initialize faces in all cases, not
9641 only when CANNOT_DUMP is defined.
9642 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9643
c56e0fd5
DN
96442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9645
9646 * dispnew.c (add_window_display_history): Use const for the string
9647 pointer. Remove declaration, not needed.
9648
333d54da 96492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9650
55d4c1b2 9651 Use 'inline', not 'INLINE'.
333d54da 9652 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9653 * alloc.c, fontset.c (INLINE): Remove.
9654 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9655 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9656 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9657 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9658 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9659
738db178
DN
96602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9661
9662 Make it possible to run ./temacs.
9663
9664 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9665 syms_of_callproc does the same thing. Remove test for
9666 "initialized", do it in the caller.
9667 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9668
620c53a6
SM
96692011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9670
9671 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9672 (read_minibuf): Use get_minibuffer.
9673 (syms_of_minibuf): Use DEFSYM.
9674 (Qmetadata): New var.
9675 * data.c (Qbuffer): Don't make it static.
9676 (syms_of_data): Use DEFSYM.
9677
e003a292
PE
96782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9679
9680 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9681 (CCL_CODE_MIN): New macro.
9682
ed008a6d
PE
96832011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9684
3687c2ef
PE
9685 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9686
ed008a6d
PE
9687 * eval.c (Qdebug): Now static.
9688 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9689 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9690 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9691
d66c4c7c
CY
96922011-05-29 Chong Yidong <cyd@stupidchicken.com>
9693
9694 * image.c: Various fixes to ImageMagick code comments.
9695 (Fimagemagick_types): Doc fix.
9696
5fbc2025
PE
96972011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9698
0196f88a
PE
9699 Minor fixes prompted by GCC 4.6.0 warnings.
9700
9701 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9702
5fbc2025
PE
9703 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9704 (x_clipboard_manager_save_all): Move extern decl to ...
9705 * xterm.h: ... here, so that it can be checked for consistency.
9706
1dd3c2d9
CY
97072011-05-29 Chong Yidong <cyd@stupidchicken.com>
9708
9709 * xselect.c (x_clipboard_manager_save_frame)
9710 (x_clipboard_manager_save_all): New functions.
9711 (Fx_clipboard_manager_save): Lisp function deleted.
9712
9713 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9714 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9715
9716 * xterm.h: Update prototype.
9717
5ba6571d
WX
97182011-05-28 William Xu <william.xwl@gmail.com>
9719
9720 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9721 exiting (Bug#8239).
9722
3eaff834
JM
97232011-05-28 Jim Meyering <meyering@redhat.com>
9724
e1900994 9725 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9726 * fns.c (to_uchar): Define.
9727 (crypto_hash_function): Use it to convert some newly-signed
9728 variables to unsigned, to avoid sign-extension bugs. For example,
9729 without this change, (md5 "truc") would evaluate to
9730 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9731 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9732 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9733
0f6990a7
PE
97342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9735
9736 Integer overflow fixes.
c8a9ca5a 9737
08686060
PE
9738 * dbusbind.c: Serial number integer overflow fixes.
9739 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9740 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9741 to hold a serial number that is too large for a fixnum.
9742 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9743 Check for serial numbers out of range. Decode any serial number
59568bf0 9744 that was so large that it became a float. (Bug#8722)
08686060 9745
2d1fc3c7
PE
9746 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9747 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9748 Use XFASTINT rather than XUINT when numbers are nonnegative.
9749 (xd_append_arg, Fdbus_method_return_internal):
9750 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9751 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9752 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9753 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9754 (Bug#8722)
2d1fc3c7 9755
c8a9ca5a
PE
9756 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9757
519e1d69
PE
9758 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9759
6df6ae42 9760 ccl: Add integer overflow checks.
30569699
PE
9761 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9762 (IN_INT_RANGE): New macros.
9763 (ccl_driver): Use them to check for integer overflow when
9764 decoding a CCL program. Many of the new checks are whether XINT (x)
9765 fits in int; it doesn't always, on 64-bit hosts. The new version
9766 doesn't catch all possible integer overflows, but it's an
847044ea 9767 improvement. (Bug#8719)
30569699 9768
c11285dc
PE
9769 * alloc.c (make_event_array): Use XINT, not XUINT.
9770 There's no need for unsigned here.
9771
fdccd48e
PE
9772 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9773 This follows up to the 2011-05-06 change that substituted uintptr_t
9774 for EMACS_INT. This case wasn't caught back then.
9775
37910ab2
PE
9776 Rework Fformat to avoid integer overflow issues.
9777 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9778 now (part of C89). Include <verify.h>.
9779 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9780 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9781 (Fformat): Avoid the prepass trying to compute sizes; it was only
9782 approximate and thus did not catch overflow reliably. Instead, walk
9783 through the format just once, formatting and computing sizes as we go,
9784 checking for integer overflow at every step, and allocating a larger
9785 buffer as needed. Keep track separately whether the format is
9786 multibyte. Keep only the most-recently calculated precision, rather
9787 than them all. Record whether each argument has been converted to
9788 string. Use EMACS_INT, not int, for byte and char and arg counts.
9789 Support field widths and precisions larger than INT_MAX. Avoid
9790 sprintf's undefined behavior with conversion specifications such as %#d
9791 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9792 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9793 formatting out-of-range floating point numbers with int
9173deec 9794 formats. (Bug#8668)
37910ab2 9795
2e6578fb
PE
9796 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9797
0ae6bdee
PE
9798 * data.c: Avoid integer truncation in expressions involving floats.
9799 * data.c: Include <intprops.h>.
9800 (arith_driver): When there's an integer overflow in an expression
9801 involving floating point, convert the integers to floating point
9802 so that the resulting value does not suffer from catastrophic
9803 integer truncation. For example, on a 64-bit host (* 4
9804 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9805 Do not rely on undefined behavior after integer overflow.
9806
de883a70
PE
9807 merge count_size_as_multibyte, parse_str_to_multibyte
9808 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9809 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9810 Check for integer overflow.
9811 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9812 since it's now a duplicate of the other. This is more of
9813 a character than a buffer op, so better that it's in character.c.
9814 * fns.c, print.c: Adjust to above changes.
9815
2ff916cb
PE
98162011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9817
9818 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9819
f1b54466
PE
98202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9821
fb1ac845
PE
9822 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9823 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9824 (x_clipboard_manager_save): Now static.
9825 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9826
f1b54466
PE
9827 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9828 (crypto_hash_function): Now static.
9829 Fix pointer signedness problems. Avoid unnecessary initializations.
9830
a9f737ee
CY
98312011-05-27 Chong Yidong <cyd@stupidchicken.com>
9832
9833 * termhooks.h (Vselection_alist): Make it terminal-local.
9834
9835 * terminal.c (create_terminal): Initialize it.
9836
9837 * xselect.c: Support for clipboard managers.
9838 (Vselection_alist): Move to termhooks.h as terminal-local var.
9839 (LOCAL_SELECTION): New macro.
9840 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9841 (symbol_to_x_atom): Remove gratuitous arg.
9842 (x_handle_selection_request, lisp_data_to_selection_data)
9843 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9844 (x_own_selection, x_get_local_selection, x_convert_selection):
9845 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9846 (some_frame_on_display): Delete unused function.
9847 (Fx_own_selection_internal, Fx_get_selection_internal)
9848 (Fx_disown_selection_internal, Fx_selection_owner_p)
9849 (Fx_selection_exists_p): New optional frame arg.
9850 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9851 (x_handle_selection_clear): Don't treat other terminals with the
9852 same keyboard specially. Use the terminal-local Vselection_alist.
9853 (x_clear_frame_selections): Use Frun_hook_with_args.
9854
9855 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9856
9857 * xterm.h: Add support for those atoms.
9858
e067f0c1
CY
98592011-05-26 Chong Yidong <cyd@stupidchicken.com>
9860
9861 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9862 (converted_selections, conversion_fail_tag): New global variables.
9863 (x_selection_request_lisp_error): Free the above.
9864 (x_get_local_selection): Remove unnecessary code.
9865 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9866 of converted selections stored in converted_selections.
9867 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9868 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9869 (x_convert_selection): New function.
9870 (x_handle_selection_event): Simplify.
9871 (x_get_foreign_selection): Don't ignore incoming requests while
9872 waiting for an answer; this will fail when we implement
9873 SAVE_TARGETS, and seems unnecessary anyway.
9874 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9875 (Vx_sent_selection_functions): Doc fix.
9876
0f4aebc0
LL
98772011-05-26 Leo Liu <sdl.web@gmail.com>
9878
9879 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9880
e61124cd
YM
98812011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9882
9883 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9884
9885 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9886 for fringe update if it has periodic bitmap.
ac389d0c 9887 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9888 and fringe_bitmap_periodic_p.
9889
9890 * fringe.c (get_fringe_bitmap_data): New function.
9891 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9892 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9893 row. Mark glyph row for fringe update if periodicity changed.
9894
9895 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9896 for fringe update unless it has periodic bitmap.
9897
f16d9837
KH
98982011-05-25 Kenichi Handa <handa@m17n.org>
9899
9900 * xdisp.c (get_next_display_element): Set correct it->face_id for
9901 a static composition.
9902
e1b90ef6
LL
99032011-05-24 Leo Liu <sdl.web@gmail.com>
9904
9905 * deps.mk (fns.o):
9906 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9907
9908 * fns.c (crypto_hash_function, Fsha1): New function.
9909 (Fmd5): Use crypto_hash_function.
9910 (syms_of_fns): Add Ssha1.
9911
7400048f
PE
99122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9913
9914 * gnutls.c: Remove unused macros.
9915 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9916 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9917 Remove macros that are defined and never used.
9918 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9919
abb71cf4
CY
99202011-05-22 Chong Yidong <cyd@stupidchicken.com>
9921
9922 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9923 (Fx_get_selection_internal): Minor cleanup.
9924 (Fx_own_selection_internal): Rename arguments for consistency with
9925 select.el.
9926
6307db39
PE
99272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9928
9929 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9930
f3d4e0a4
CY
99312011-05-22 Chong Yidong <cyd@stupidchicken.com>
9932
9933 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9934
4d8ade89
YM
99352011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9936
9937 * dispnew.c (scrolling_window): Don't exclude the case that the
9938 last enabled row in the desired matrix touches the bottom boundary.
9939
32078c8d
GM
99402011-05-21 Glenn Morris <rgm@gnu.org>
9941
9942 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9943 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9944 and add some more files.
32078c8d 9945
7285dc67
EZ
99462011-05-20 Eli Zaretskii <eliz@gnu.org>
9947
9948 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9949 report_file_error introduced by the change from 2011-05-07.
9950
89d1bd22
PE
99512011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9952
9953 * systime.h (Time): Define only if emacs is defined.
9954 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9955 where the include path doesn't have X11/X.h by default. See
9956 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9957
cd394be1 99582011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9959
9960 * composite.c (find_automatic_composition): Fix previous change.
9961
b9704ad9
GM
99622011-05-20 Glenn Morris <rgm@gnu.org>
9963
9964 * lisp.mk: New file, split from Makefile.in.
9965 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9966 (shortlisp): Remove.
9967 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9968
4a720484
GM
99692011-05-19 Glenn Morris <rgm@gnu.org>
9970
9971 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9972 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9973 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9974 (lisp): Set the order to that of loadup.el.
9975 (shortlisp): Make it a copy of $lisp.
9976 (SOME_MACHINE_LISP): Remove.
9977 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9978 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9979
a28d4396
KH
99802011-05-18 Kenichi Handa <handa@m17n.org>
9981
9982 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9983 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9984 (find_automatic_composition): Mostly rewrite for efficiency.
9985
a2b1fa8e
JB
99862011-05-18 Juanma Barranquero <lekktu@gmail.com>
9987
9988 * makefile.w32-in: Update dependencies.
9989
8e1f5610
CS
99902011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9991
9992 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9993 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9994
7025ee00 99952011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9996
cdfa6eab
PE
9997 Fix some integer overflow issues, such as string length overflow.
9998
06d6db33
PE
9999 * insdel.c (count_size_as_multibyte): Check for string overflow.
10000
2b4560a8
PE
10001 * character.c (lisp_string_width): Check for string overflow.
10002 Use EMACS_INT, not int, for string indexes and lengths; in
10003 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10004 the resulting string length overflows an EMACS_INT; instead,
10005 report a string overflow if no precision given. When checking for
10006 precision exhaustion, use a check that cannot possibly have
10007 integer overflow. (Bug#8675)
10008 * character.h (lisp_string_width): Adjust to new signature.
10009
cb93f9be
PE
10010 * alloc.c (string_overflow): New function.
10011 (Fmake_string): Use it. This doesn't change behavior, but saves
10012 a few bytes and will simplify future changes.
10013 * character.c (string_escape_byte8): Likewise.
10014 * lisp.h (string_overflow): New decl.
10015
1a1f3366
PE
10016 Fixups, following up to the user-interface timestamp change.
10017 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10018 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10019 * msdos.c (mouse_get_pos): Likewise.
10020 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10021 * w32gui.h (Time): Define by including "systime.h" rather than by
10022 declaring it ourselves. (Bug#8664)
10023
d4e3e4d3
PE
10024 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10025 * image.c (clear_image_cache): Likewise.
10026
f6a24d19
PE
10027 * term.c (term_mouse_position): Don't assume time_t wraparound.
10028
08dc5ae6
PE
10029 Be more systematic about user-interface timestamps.
10030 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10031 and sometimes 'EMACS_UINT', to represent these timestamps.
10032 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10033 This makes the code easier to follow, and makes it easier to catch
10034 integer overflow bugs such as Bug#8664.
10035 * frame.c (Fmouse_position, Fmouse_pixel_position):
10036 Use Time, not unsigned long, for user-interface timestamps.
10037 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10038 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10039 * keyboard.h (last_event_timestamp): Likewise.
10040 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10041 * menu.h (xmenu_show): Likewise.
10042 * term.c (term_mouse_position): Likewise.
10043 * termhooks.h (struct input_event.timestamp): Likewise.
10044 (struct terminal.mouse_position_hook): Likewise.
10045 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10046 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10047 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10048 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10049 what it was before.
10050 * menu.h, termhooks.h: Include "systime.h", for Time.
10051
8e55734a
PE
10052 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10053 Don't assume that the difference between two unsigned long values
10054 can fit into an integer. At this point, we know button_down_time
10055 <= event->timestamp, so the difference must be nonnegative, so
10056 there's no need to cast the result if double-click-time is
10057 nonnegative, as it should be; check that it's nonnegative, just in
10058 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10059 apart (about 25 days). (Bug#8664)
8e55734a 10060
841f1b75 10061 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10062 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10063
3e26f69c
PE
10064 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10065 that always fit in int. Use a sentinel instead of a counter, to
10066 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10067 * frame.h (struct frame): Use int for menu_bar_items_used
10068 instead of EMACS_INT, since it always fits in int.
3e26f69c 10069
5cc152c0
PE
10070 * menu.c (grow_menu_items): Check for int overflow.
10071
d89eb65e
PE
10072 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10073
5235bd3e
PE
10074 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10075 Before, the code was not consistent. These values cannot exceed
10076 2**31 - 1 so there's no need to make them unsigned.
10077 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10078 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10079 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10080 as modifiers.
10081 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10082
bc827e23
PE
10083 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10084 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10085 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10086 presumably because the widths might not match.
10087
78eb494e
PE
10088 * window.c (size_window): Avoid needless test at loop start.
10089
04f2d78b
CB
100902011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10091
10092 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10093
d2fc7e3d 100942011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10095
10096 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10097
d2fc7e3d 100982011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10099
10100 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10101 `width' to `bar_area_x' and `bar_area_width', respectively.
10102 (x_scroll_run): Take account of fringe background extension.
10103
04f2d78b
CB
10104 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10105 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10106 `bar_area_width', respectively.
10107 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10108 background extension.
10109
79b70037
GM
101102011-05-10 Jim Meyering <meyering@redhat.com>
10111
10112 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10113
2f142cc5
JB
101142011-05-10 Juanma Barranquero <lekktu@gmail.com>
10115
10116 * image.c (Finit_image_library): Return t for built-in image types,
10117 like pbm and xbm. (Bug#8640)
10118
57679c86
AS
101192011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10120
10121 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10122
888c9e86
EZ
101232011-05-07 Eli Zaretskii <eliz@gnu.org>
10124
b0512a1d
EZ
10125 * w32console.c (Fset_screen_color): Doc fix.
10126 (Fget_screen_color): New function.
10127 (syms_of_ntterm): Defsubr it.
10128
7285dc67
EZ
10129 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10130 unlink the temporary file if Fcall_process didn't create it in the
10131 first place.
10132 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10133 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10134 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10135 cue to call_process_cleanup not to close that handle.
10136
4d3fcc8e
BK
101372011-05-07 Ben Key <bkey76@gmail.com>
10138
10139 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10140 one of two shell specific rules, either bootstrap-temacs-CMD or
10141 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10142 to the previous implementation of the bootstrap-temacs rule.
10143 The bootstrap-temacs-CMD rule is similar to the previous
10144 implementation of the bootstrap-temacs rule except that it
10145 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10146 variable.
10147
10148 These changes, along with some changes to nt/configure.bat,
10149 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10150 earlier fix to add support for --cflags and --ldflags options
10151 that include quotes so that it works whether make uses cmd or
10152 sh as the shell.
10153
b4289b64
MA
101542011-05-06 Michael Albinus <michael.albinus@gmx.de>
10155
10156 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10157 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10158 is a constant.
10159 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10160 a string. Handle both cases.
10161 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10162 (Fdbus_register_method): Use Qinvalid_function.
10163
af4c0e28
JB
101642011-05-06 Juanma Barranquero <lekktu@gmail.com>
10165
10166 * makefile.w32-in: Update dependencies.
10167 (LISP_H): Add inttypes.h and stdin.h.
10168 (PROCESS_H): Add unistd.h.
10169
c51453d9
EZ
101702011-05-06 Eli Zaretskii <eliz@gnu.org>
10171
10172 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10173 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10174
8ff0ac3c 101752011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10176
4c4b566b
PE
10177 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10178
aab2b9b5
PE
10179 * term.c (vfatal): Remove stray call to va_end.
10180 It's not needed and the C Standard doesn't allow it here anyway.
10181
c378da0b
PE
10182 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10183 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10184
288b08c7
PE
10185 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10186 bytes.
10187
e3601888
PE
10188 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10189
db6c0e74
PE
10190 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10191
dd5963ea
PE
10192 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10193
88c9450f
PE
10194 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10195
2f9442b8
PE
10196 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10197
c032b5f8
PE
10198 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10199 * charset.c (Fdefine_charset_internal): Don't initialize
10200 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10201 32-bit int (Bug#8600).
a108c10b
PE
10202
10203 * lread.c (read_integer): Be more consistent with string-to-number.
10204 Use string_to_number to do the actual conversion; this avoids
10205 rounding errors and fixes some other screwups. Without this fix,
10206 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10207 (digit_to_number): Move earlier, for benefit of read_integer.
10208 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10209 not a digit in any supported base. (Bug#8602)
a108c10b 10210
ad5f9eea
PE
10211 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10212
aec1708a
PE
10213 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10214 to match comment at start of function. This also removes a
10215 GCC warning about overflow in a 32+64-bit port.
10216
47be4ab5
PE
10217 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10218
371cac43
PE
10219 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10220 Reported by Stefan Monnier in
10221 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10222 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10223 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10224
d01a7826
PE
10225 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10226 (EMACS_UINTPTR): Likewise, with uintptr_t.
10227
7fd47d5c
PE
10228 * lisp.h: Prefer 64-bit EMACS_INT if available.
10229 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10230 on 32-bit hosts that have 64-bit int, so that they can access
10231 large files.
122b0c86
PE
10232 However, temporarily disable this change unless the temporary
10233 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10234
8727937b
PE
10235 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10236
8ac068ac
PE
10237 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10238 This removes an assumption that EMACS_INT and long are the same
10239 width as pointers. The assumption is true for Emacs porting targets
10240 now, but we want to make other targets possible.
10241 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10242 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10243 In the rest of the code, change types of integers that hold casted
10244 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10245 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10246 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10247 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10248 No need to cast type when ORing.
10249 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10250 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10251 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10252 assume EMACS_INT is the same width as char *.
10253 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10254 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10255 Remove no-longer-needed casts.
10256 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10257 (xg_tool_bar_help_callback, xg_make_tool_item):
10258 Use EMACS_INTPTR to hold an integer
10259 that will be cast to void *; this can avoid a GCC warning
10260 if EMACS_INT is not the same width as void *.
10261 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10262 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10263 (current_message_1, set_message_1):
10264 Use a local to convert to proper width without a cast.
10265 * xmenu.c (dialog_selection_callback): Likewise.
10266
ede49d71
PE
10267 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10268 Also, don't assume VALBITS / RAND_BITS is less than 5,
10269 and don't rely on undefined behavior when shifting a 1 left into
10270 the sign bit.
10271 * lisp.h (get_random): Change signature to match.
10272
2f30ecd0
PE
10273 * lread.c (hash_string): Use size_t, not int, for hash computation.
10274 Normally we prefer signed values; but hashing is special, because
10275 it's better to use unsigned division on hash table sizes so that
10276 the remainder is nonnegative. Also, size_t is the natural width
10277 for hashing into memory. The previous code used 'int', which doesn't
10278 retain enough info to hash well into very large tables.
10279 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10280
2a866e7b
PE
10281 * dbusbind.c: Don't possibly lose pointer info when converting.
10282 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10283 Use XPNTR rather than XHASH, so that the high-order bits of
10284 the pointer aren't lost when converting through void *.
10285
51639eac
PE
10286 * eval.c (Fautoload): Don't double-shift a pointer.
10287
92394119
PE
10288 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10289
dbdb9a7c
JB
102902011-05-06 Juanma Barranquero <lekktu@gmail.com>
10291
10292 * gnutls.c (DEF_GNUTLS_FN):
10293 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10294
db7a0b4f
AS
102952011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10296
10297 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10298 marker. (Bug#8610)
10299
cd394be1 103002011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10301
10302 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10303 New version that can reserve upto 2GB of heap space.
10304
f7ff1b0f 103052011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10306
10307 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10308
639c109b
TZ
103092011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10310
10311 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10312 `gnutls_certificate_set_x509_key_file'.
10313
d2127135
JB
103142011-05-05 Juanma Barranquero <lekktu@gmail.com>
10315
10316 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10317 Update dependencies.
10318
e968f4f3
JB
103192011-05-04 Juanma Barranquero <lekktu@gmail.com>
10320
10321 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10322 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10323 Remove unused parameter `fildes'.
10324 * process.c (read_process_output, send_process): Don't pass it.
10325
84d358f0
JB
103262011-05-04 Juanma Barranquero <lekktu@gmail.com>
10327
10328 Fix previous change: the library cache is defined in w32.c.
10329 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10330 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10331
0898ca10
JB
103322011-05-04 Juanma Barranquero <lekktu@gmail.com>
10333
10334 Implement dynamic loading of GnuTLS on Windows.
10335
10336 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10337 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10338 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10339 Declare.
10340
10341 * gnutls.c (Qgnutls_dll): Define.
10342 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10343 (gnutls_*): Declare function pointers.
10344 (init_gnutls_functions): New function to initialize function pointers.
10345 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10346 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10347 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10348 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10349 (emacs_gnutls_write, emacs_gnutls_read)
10350 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10351 (Fgnutls_available_p): New function.
10352 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10353 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10354 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10355
10356 * image.c: Include w32.h.
10357 (Vimage_type_cache): Delete.
10358 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10359 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10360 (w32_delayed_load): Move to w32.c.
10361
10362 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10363
10364 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10365 (w32_delayed_load): Move from image.c. When loading a library, record
10366 its filename in the :loaded-from property of the library id.
10367 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10368 Initialize and staticpro them.
10369 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10370
10371 * process.c: Include lisp.h before w32.h, not after.
10372 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10373 instead of gnutls_record_check_pending.
10374
10375 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10376
ff4de4aa
TZ
103772011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10378
10379 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10380 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10381 as passed in.
10382
abe95abb
JD
103832011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10384
10385 * xterm.c (x_set_frame_alpha): Do not set property on anything
10386 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10387
e16e55d4
JB
103882011-05-02 Juanma Barranquero <lekktu@gmail.com>
10389
10390 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10391
bafcf6a5
JB
103922011-05-02 Juanma Barranquero <lekktu@gmail.com>
10393
10394 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10395 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10396 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10397 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10398 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10399 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10400 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10401 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10402 (Qgnutls_bootprop_callbacks_verify): Make static.
10403
e7a6747f
AS
104042011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10405
19ed11ba
AS
10406 * callproc.c: Indentation fixup.
10407
e7a6747f 10408 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10409 (wait_for_termination, interruptible_wait_for_termination):
10410 Move after wait_for_termination_1.
e7a6747f 10411
1ef14cb4
LMI
104122011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10413
10414 * sysdep.c (interruptible_wait_for_termination): New function
10415 which is like wait_for_termination, but allows keyboard
10416 interruptions.
10417
10418 * callproc.c (Fcall_process): Add (:file "file") as an option for
10419 the STDOUT buffer.
10420 (Fcall_process_region): Ditto.
10421
330d880c
EZ
104222011-04-30 Eli Zaretskii <eliz@gnu.org>
10423
8db90b73
EZ
10424 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10425 rather than `XVECTOR (FOO)->size'.
10426
330d880c
EZ
10427 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10428 inttypes.h, as a gnulib replacement is used if it not available in
10429 system headers.
10430
15cbd324
EZ
104312011-04-21 Eli Zaretskii <eliz@gnu.org>
10432
10433 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10434 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10435 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10436
10437 * coding.c (coding_alloc_by_realloc): Error out if destination
10438 will grow beyond MOST_POSITIVE_FIXNUM.
10439 (decode_coding_emacs_mule): Abort if there isn't enough place in
10440 charbuf for the composition carryover bytes. Reserve an extra
10441 space for up to 2 characters produced in a loop.
10442 (decode_coding_iso_2022): Abort if there isn't enough place in
10443 charbuf for the composition carryover bytes.
10444
104452011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10446
ae940cca
EZ
10447 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10448 aborting when %lld or %lll format is passed.
10449 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10450 %llo or %llx format is passed. (Bug#8545)
10451
03ab8921
EZ
10452 * window.c (window_scroll_line_based): Use a marker instead of
10453 simple variables to record original value of point. (Bug#7952)
10454
afda1437
EZ
10455 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10456 produced by %s or %c overflows available buffer space. (Bug#8545)
10457
f76dee0c
PE
104582011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10459
10460 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10461 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10462
fdc5744d
JB
104632011-04-28 Juanma Barranquero <lekktu@gmail.com>
10464
10465 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10466
638f053a
JB
104672011-04-28 Juanma Barranquero <lekktu@gmail.com>
10468
10469 * keyboard.c (Qdelayed_warnings_hook): Define.
10470 (command_loop_1): Run `delayed-warnings-hook'
10471 if Vdelayed_warnings_list is non-nil.
10472 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10473 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10474
d178f871
EZ
104752011-04-28 Eli Zaretskii <eliz@gnu.org>
10476
10477 * doprnt.c (doprnt): Don't return value smaller than the buffer
10478 size if the message was truncated. (Bug#8545).
10479
b124fd93
JB
104802011-04-28 Juanma Barranquero <lekktu@gmail.com>
10481
10482 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10483 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10484
e810457d
PE
104852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10486
10487 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10488
ea51cceb
JB
104892011-04-27 Juanma Barranquero <lekktu@gmail.com>
10490
10491 * makefile.w32-in: Update dependencies.
10492
94dcfacf
EZ
104932011-04-27 Eli Zaretskii <eliz@gnu.org>
10494
10495 Improve `doprnt' and its usage. (Bug#8545)
10496 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10497 `format_end'. Remove support for %l as a conversion specifier.
10498 Don't use xrealloc. Improve diagnostics when the %l size modifier
10499 is used. Update the commentary.
10500
10501 * eval.c (verror): Simplify calculation of size_t.
10502
10503 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10504 messages.
10505
f61f41d7
PE
105062011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10507
10508 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10509 change.
10510
96fb4434
PE
105112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10512
10513 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10514 This makes this file independent of the recent pseudovector change.
10515
671875da 105162011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10517
69e9b5a3
PE
10518 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10519
b5f869a7 10520 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10521 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10522 Remove unused local.
c8926152 10523 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10524
841a1577 10525 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10526 GCC 4.6.0 optimizes based on type-based alias analysis.
10527 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10528 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10529 != &v->size, and therefore "v->size = 1; b->size = 2; return
10530 v->size;" must therefore return 1. This assumption is incorrect
10531 for Emacs, since it type-puns struct Lisp_Vector * with many other
10532 types. To fix this problem, this patch adds a new type struct
f904488f 10533 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10534 and pseudovectors, and helps optimizing compilers not get fooled
10535 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10536 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10537 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10538 the size member.
eab3844f
PE
10539 (XSETPVECTYPE): Rewrite in terms of new macro.
10540 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10541 This is a bit clearer, and further avoids the possibility of
10542 undesirable aliasing.
10543 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10544 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10545 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10546 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10547 (ASIZE): Now uses header.size rather than size.
10548 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10549 to avoid the hassle of writing XVECTOR (foo)->header.size.
10550 (struct vectorlike_header): New type.
eab3844f
PE
10551 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10552 object, to help avoid aliasing.
10553 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10554 (SUBRP): Likewise, since Lisp_Subr is a special case.
10555 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10556 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10557 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10558 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10559 changed to be "header.size" and "header.next".
10560 * buffer.h (struct buffer): Likewise.
10561 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10562 * frame.h (struct frame): Likewise.
10563 * process.h (struct Lisp_Process): Likewise.
10564 * termhooks.h (struct terminal): Likewise.
10565 * window.c (struct save_window_data, struct saved_window): Likewise.
10566 * window.h (struct window): Likewise.
10567 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10568 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10569 * buffer.c (init_buffer_once): Likewise.
10570 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10571 special case.
10572 * process.c (Fformat_network_address): Use local var for size,
10573 for brevity.
10574
0df1eac5
PE
10575 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10576
847ab9d1 10577 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10578 * data.c (atof): Remove decl; no longer used or needed.
10579 (digit_to_number): Move to lread.c.
10580 (Fstring_to_number): Use new string_to_number function, to be
10581 consistent with how the Lisp reader treats infinities and NaNs.
10582 Do not assume that floating-point numbers represent EMACS_INT
10583 without losing information; this is not true on most 64-bit hosts.
10584 Avoid double-rounding errors, by insisting on integers when
10585 parsing non-base-10 numbers, as the documentation specifies.
10586 * lisp.h (string_to_number): New decl, replacing ...
10587 (isfloat_string): Remove.
bc0a5c13 10588 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10589 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10590 appears to have been a coding error. Similarly, do not accept
10591 strings like +-1e0 as floating point numbers. Do not report
10592 overflow for integer overflows unless the base is not 10 which
10593 means we have no simple and reliable way to continue.
10594 Break out the floating-point parsing into a new
10595 function string_to_number, so that Fstring_to_number parses
10596 floating point numbers consistently with the Lisp reader.
04f2d78b 10597 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10598 (E_CHAR, EXP_INT): Remove, replacing with ...
10599 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10600 (string_to_number): New function, replacing isfloat_string.
10601 This function checks for valid syntax and produces the resulting
10602 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10603 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10604 so that overflow for non-base-10 numbers is reported only when
10605 there's no portable and simple way to convert to floating point.
452f4150 10606
67769ffc
PE
10607 * textprop.c (set_text_properties_1): Rewrite for clarity,
10608 and to avoid GCC warning about integer overflow.
10609
c20db43f
PE
10610 * intervals.h (struct interval): Use EMACS_INT for members
10611 where EMACS_UINT might cause problems. See
10612 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10613 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10614 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10615 All uses changed.
37aa2f85
PE
10616 (offset_intervals): Tell GCC not to worry about length overflow
10617 when negating a negative length.
c20db43f 10618
2538aa2f
PE
10619 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10620 (overrun_check_free): Likewise.
10621
f2d3008d
PE
10622 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10623 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10624 word size.
10625
ec8df744
PE
10626 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10627 (gnutls_make_error): Rename local to avoid shadowing.
10628 (gnutls_emacs_global_deinit): ifdef out; not used.
10629 (Fgnutls_boot): Use const for pointer to readonly storage.
10630 Comment out unused local. Fix pointer signedness problems.
10631
640ee02d
PE
10632 * lread.c (openp): Don't stuff size_t into an 'int'.
10633 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10634 about possible signed overflow.
10635
6048fb2a
PE
10636 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10637 (GDK_KEY_g): Don't define if already defined.
10638 (xg_prepare_tooltip): Avoid pointer signedness problem.
10639 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10640
fa3c87e1
PE
10641 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10642 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10643
2172544b
PE
10644 * xfns.c (Fx_window_property): Simplify a bit,
10645 to make a bit faster and to avoid GCC 4.6.0 warning.
10646 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10647
9b821a21
PE
10648 * fns.c (internal_equal): Don't assume size_t fits in int.
10649
3c616cfa
PE
10650 * alloc.c (compact_small_strings): Tighten assertion a little.
10651
c2982e87
PE
10652 Replace pEd with more-general pI, and fix some printf arg casts.
10653 * lisp.h (pI): New macro, generalizing old pEd macro to other
10654 conversion specifiers. For example, use "...%"pI"d..." rather
10655 than "...%"pEd"...".
10656 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10657 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10658 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10659 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10660 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10661 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10662 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10663 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10664 64-bit hosts.
10665 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10666 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10667 * print.c (safe_debug_print, print_object): Likewise.
10668 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10669 to int.
6f04d126
PE
10670 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10671 avoiding the 0 flag, which is not portable.
c2982e87
PE
10672 * process.c (Fmake_network_process): Use pI to avoid cast.
10673 * region-cache.c (pp_cache): Likewise.
10674 * xdisp.c (decode_mode_spec): Likewise.
10675 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10676 behavior on 64-bit hosts with printf arg.
6f04d126 10677 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10678 (x_stop_queuing_selection_requests): Likewise.
10679 (x_get_window_property): Don't truncate byte count to an 'int'
10680 when tracing.
0b432f21 10681
5e073ec7
PE
10682 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10683 here, since it parses constructs like leading '-' and spaces,
10684 which are not wanted; and it overflows with large numbers.
10685 Instead, simply match F[0-9]+, which is what is wanted anyway.
10686
36372bf9
PE
10687 * alloc.c: Remove unportable assumptions about struct layout.
10688 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10689 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10690 (allocate_vectorlike, make_pure_vector): Use the new macros,
10691 plus offsetof, to remove unportable assumptions about struct layout.
10692 These assumptions hold on all porting targets that I know of, but
10693 they are not guaranteed, they're easy to remove, and removing them
10694 makes further changes easier.
10695
0b432f21
PE
10696 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10697 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10698 (string_overrun_cookie): Now const. Use initializers that
10699 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10700 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10701 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10702 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10703 multiple of sizeof (EMACS_INT); it need not be, if
10704 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10705 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10706
895009e1
JB
107072011-04-26 Juanma Barranquero <lekktu@gmail.com>
10708
10709 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10710
6a7a1b0b
TZ
107112011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10712
10713 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10714 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10715 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10716
841a1577 107172011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10718
10719 * lisp.h (Qdebug): List symbol.
895009e1 10720 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10721 * keyboard.c (debug-on-event): New variable.
10722 (handle_user_signal): Break into debugger when debug-on-event
10723 matches the current signal symbol.
10724
f2d3ba6f
DN
107252011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10726
10727 * alloc.c (check_sblock, check_string_bytes)
10728 (check_string_free_list): Convert to standard C.
10729
42ce4c63
TZ
107302011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10731
10732 * w32.c (emacs_gnutls_push): Fix typo.
10733
825cd63c
EZ
107342011-04-25 Eli Zaretskii <eliz@gnu.org>
10735
fb11d64d
EZ
10736 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10737 "cast to pointer from integer of different size".
10738
825cd63c
EZ
10739 Improve doprnt and its use in verror. (Bug#8545)
10740 * doprnt.c (doprnt): Document the set of format control sequences
10741 supported by the function. Use SAFE_ALLOCA instead of always
10742 using `alloca'.
10743
10744 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10745 is one byte too soon. Don't use xrealloc; instead xfree and
10746 xmalloc anew.
10747
e061a11b
TZ
107482011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10749
10750 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10751 callbacks stage.
10752
10753 * gnutls.c: Renamed global_initialized to
10754 gnutls_global_initialized. Added internals for the
10755 :verify-hostname-error, :verify-error, and :verify-flags
10756 parameters of `gnutls-boot' and documented those parameters in the
10757 docstring. Start callback support.
9173deec
JB
10758 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10759 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10760 on error. Return error code.
e061a11b
TZ
10761 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10762 (emacs_gnutls_read): Likewise.
10763 (Fgnutls_boot): Return handshake error code.
10764 (emacs_gnutls_handle_error): New function.
10765 (wsaerror_to_errno): Likewise.
10766
10767 * w32.h (emacs_gnutls_pull): Add prototype.
10768 (emacs_gnutls_push): Likewise.
10769
10770 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10771 (emacs_gnutls_push): Likewise.
10772
107732011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10774
10775 * process.c (wait_reading_process_output): Check if GnuTLS
10776 buffered some data internally if no FDs are set for TLS
10777 connections.
10778
10779 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10780 (LIBS): Link to USER_LIBS.
10781 ($(BLD)/gnutls.$(0)): New target.
10782
fa6996bc
EZ
107832011-04-24 Eli Zaretskii <eliz@gnu.org>
10784
eb35682e
EZ
10785 * xdisp.c (handle_single_display_spec): Rename the
10786 display_replaced_before_p argument into display_replaced_p, to
10787 make it consistent with the commentary. Fix typos in the
10788 commentary.
10789
e2ad650c
EZ
10790 * textprop.c (syms_of_textprop): Remove dead code.
10791 (copy_text_properties): Delete obsolete commentary about an
10792 interface that was deleted long ago. Fix typos in the description
10793 of arguments.
10794
1b2de274
EZ
10795 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10796 to changes in oldXMenu/XMenu.h from 2011-04-16.
10797 <menu_help_message, prev_menu_help_message>: Constify.
10798 (IT_menu_make_room): menu->help_text is now `const char **';
10799 adjust.
10800
10801 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10802 to changes in oldXMenu/XMenu.h from 2011-04-16.
10803 (struct XMenu): Declare `help_text' `const char **'.
10804
10805 * xfaces.c <Qunspecified>: Make extern again.
10806
10807 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10808 required by POSIX.
1b2de274 10809
762b15be
EZ
10810 * doc.c (get_doc_string): Improve the format passed to `error'.
10811
10812 * doprnt.c (doprnt): Improve commentary.
10813
10814 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10815
10816 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10817 them with etags.
10818
f1052e5d
EZ
10819 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10820 changes in globals.h immediately force recompilation.
762b15be
EZ
10821 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10822 $(CURDIR)/s/ms-w32.h.
10823 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10824
fa6996bc
EZ
10825 * character.c (Fchar_direction): Function deleted.
10826 (syms_of_character): Don't defsubr it.
10827 <char-direction-table>: Deleted.
10828
e6c3da20
EZ
108292011-04-23 Eli Zaretskii <eliz@gnu.org>
10830
10831 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10832 * doprnt.c: Include limits.h.
10833 (SIZE_MAX): New macro.
04f2d78b
CB
10834 (doprnt): Return a size_t value. 2nd arg is now size_t.
10835 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10836 Improve overflow protection. Support `l' modifier for integer
10837 conversions. Support %l conversion. Don't assume an EMACS_INT
10838 argument for integer conversions and for %c.
10839
10840 * lisp.h (doprnt): Restore prototype.
10841
10842 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10843 $(SRC)/character.h.
10844
10845 * Makefile.in (base_obj): Add back doprnt.o.
10846
10847 * deps.mk (doprnt.o): Add back prerequisites.
10848 (callint.o): Depend on character.h.
10849
10850 * eval.c (internal_lisp_condition_case): Include the handler
10851 representation in the error message.
10852 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10853 when breaking from the loop.
10854
10855 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10856
10857 * callint.c (Fcall_interactively): When displaying error message
10858 about invalid control letter, pass the character's codepoint, not
10859 a pointer to its multibyte form. Improve display of the character
10860 in octal and display also its hex code.
10861
10862 * character.c (char_string): Use %x to display the (unsigned)
10863 codepoint of an invalid character, to avoid displaying a bogus
10864 negative value.
10865
10866 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10867 `error', not SYMBOL_NAME itself.
10868
10869 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10870 character arguments to `error'.
10871
10872 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10873 to `error' in error message about FINAL_CHAR argument. Make sure
10874 FINAL_CHAR is a character, and use %c when it is passed as
10875 argument to `error'.
10876
4ffd0d6b 108772011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10878
10879 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10880
10881 * w32.c: Include <time.h>.
10882 (sys_localtime): New function.
10883
4ffd0d6b 108842011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10885
10886 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10887
4ffd0d6b 10888 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10889
4ffd0d6b 108902011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10891
4ffd0d6b
GM
10892 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10893 zombies (Bug#8467).
aac0c6e3 10894
04c56954
EZ
108952011-04-19 Eli Zaretskii <eliz@gnu.org>
10896
10897 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10898 gl_state.e_property when gl_state.object is Qt.
10899
10900 * insdel.c (make_gap_larger): Remove limitation of buffer size
10901 to <= INT_MAX.
10902
16a43933
CY
109032011-04-18 Chong Yidong <cyd@stupidchicken.com>
10904
10905 * xdisp.c (lookup_glyphless_char_display)
10906 (produce_glyphless_glyph): Handle cons cell entry in
10907 glyphless-char-display.
10908 (Vglyphless_char_display): Document it.
10909
10910 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10911 glyphless-char-display.
10912
4581706e
CY
109132011-04-17 Chong Yidong <cyd@stupidchicken.com>
10914
10915 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10916
10917 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10918
10919 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10920 definition for no-X builds.
10921
4887c6e2 109222011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10923
fd35b6f9
PE
10924 Static checks with GCC 4.6.0 and non-default toolkits.
10925
5c1ccb01
PE
10926 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10927
006c5daa
PE
10928 * process.c (keyboard_bit_set): Define only if SIGIO.
10929 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10930 (send_process): Repair possible setjmp clobbering.
10931
efc736d3
PE
10932 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10933
4e2fe2e6
PE
10934 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10935
f97334a2
PE
10936 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10937
4e75f29d
PE
10938 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10939 Define only if needed.
10940
90efadd1
PE
10941 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10942 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10943 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10944
3c647824
PE
10945 * dispextern.h (struct redisplay_interface): Rename param
10946 to avoid shadowing.
e264f262 10947 * termhooks.h (struct terminal): Likewise.
761383f4 10948 * xterm.c (xembed_send_message): Likewise.
3c647824 10949
b58c5c4a
PE
10950 * insdel.c (make_gap_smaller): Define only if
10951 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10952
cad59032
PE
10953 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10954 it.
10955
c339dc2e
PE
10956 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10957 so that we aren't warned about unused symbols.
10958
91a3e27b
PE
10959 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10960
399c71d3 10961 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10962
8ffc96f5
PE
10963 * xfns.c (x_real_positions): Mark locals as initialized.
10964
eef9bc79
PE
10965 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10966
098db9dd
PE
10967 * xterm.c: Fix problems found by static analysis with other toolkits.
10968 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10969 (x_dispatch_event): Declare static if USE_GTK, and
10970 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10971 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10972 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10973 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10974 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10975
eb18f6cc
PE
10976 * xmenu.c (menu_help_callback): Pointer type fixes.
10977 Use const pointers when pointing at readonly data. Avoid pointer
10978 signedness clashes.
10979 (FALSE): Remove unused macro.
10980 (update_frame_menubar): Remove unused decl.
10981
1fe72bf8
PE
10982 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10983
60d9e1db
PE
10984 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10985 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10986 (single_menu_item): Rename local to avoid shadowing.
10987
39261c26
PE
10988 * keyboard.c (make_lispy_event): Remove unused local var.
10989
018c5e19
PE
10990 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10991 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10992
63d2b86e
PE
10993 * bitmaps: Change bitmaps from unsigned char back to the X11
10994 compatible char. Avoid the old compiler warnings about
10995 out-of-range initializers by using, for example, '\xab' rather
10996 than 0xab.
10997
aefd87e1
PE
10998 * xgselect.c (xgselect_initialize): Check vs interface
10999 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11000
bf501fb9
PE
11001 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11002
e9829fdf
PE
11003 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11004 to read-only memory.
11005
1086c095
PE
11006 * fns.c (vector): Remove; this old hack is no longer needed.
11007
2baccd04 11008 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11009 Remove unused var.
dde42981 11010 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11011
72391843 11012 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11013
436c16df 11014 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11015 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11016 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11017
92bb796d 11018 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11019 (x_term_init): Remove local to avoid shadowing.
92bb796d 11020
764430a3 11021 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11022
11023 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11024 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11025
d1dfb56c
EZ
110262011-04-16 Eli Zaretskii <eliz@gnu.org>
11027
c4354cb4
EZ
11028 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11029
d1dfb56c
EZ
11030 Fix regex.c, syntax.c and friends for buffers > 2GB.
11031 * syntax.h (struct gl_state_s): Declare character position members
11032 EMACS_INT.
11033
11034 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11035
04f2d78b
CB
11036 * textprop.c (verify_interval_modification, interval_of):
11037 Declare arguments EMACS_INT.
d1dfb56c
EZ
11038
11039 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11040 EMACS_INT.
11041
11042 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11043
11044 * indent.c (Fvertical_motion): Local variable it_start is now
11045 EMACS_INT.
11046
11047 * regex.c (re_match, re_match_2, re_match_2_internal)
11048 (bcmp_translate, regcomp, regexec, print_double_string)
11049 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11050 (re_compile_pattern, re_exec): Declare arguments and local
11051 variables `size_t' and `ssize_t' and return values `regoff_t', as
11052 appropriate.
11053 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11054 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11055 <compile_stack_type>: `size' and `avail' are now `size_t'.
11056
11057 * regex.h <regoff_t>: Use ssize_t, not int.
11058 (re_search, re_search_2, re_match, re_match_2): Arguments that
11059 specify buffer/string position and length are now ssize_t and
11060 size_t. Return type is regoff_t.
11061
613052cd
BK
110622011-04-16 Ben Key <bkey76@gmail.com>
11063
11064 * nsfont.m: Fixed bugs in ns_get_family and
11065 ns_descriptor_to_entity that were caused by using free to
11066 deallocate memory blocks that were allocated by xmalloc (via
11067 xstrdup). This caused Emacs to crash when compiled with
11068 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11069 --enable-checking=xmallocoverrun). xfree is now used to
11070 deallocate these memory blocks.
11071
4170f62f 110722011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11073
71b41406
PE
11074 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11075
9587a89d
PE
11076 emacs_write: Accept and return EMACS_INT for sizes.
11077 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11078 et seq.
11079 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11080 Accept and return EMACS_INT.
11081 (emacs_gnutls_write): Return the number of bytes written on
11082 partial writes.
11083 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11084 (emacs_read, emacs_write): Remove check for negative size, as the
11085 Emacs source code has been audited now.
9587a89d
PE
11086 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11087 (emacs_read, emacs_write): Use it.
273a5f82
PE
11088 * process.c (send_process): Adjust to the new signatures of
11089 emacs_write and emacs_gnutls_write. Do not attempt to store
11090 a byte offset into an 'int'; it might overflow.
9587a89d 11091 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11092
3e047f51
PE
11093 * sound.c: Don't assume sizes fit in 'int'.
11094 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11095 Return EMACS_INT, not int.
3e047f51 11096 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11097 Accept EMACS_INT, not int.
11098 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11099 record read return values.
11100
cc39a9db
BK
111012011-04-15 Ben Key <bkey76@gmail.com>
11102
c9d0ec6d
JB
11103 * keyboard.c (Qundefined): Don't declare static since it is used
11104 in nsfns.m.
11105 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11106 static since they are used in nsfont.m.
cc39a9db 11107
6c60eb9f
SM
111082011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11109
11110 * process.c (Qprocessp): Don't declare static.
11111 * lisp.h (Qprocessp): Declare again.
11112
7990b61a
JB
111132011-04-15 Juanma Barranquero <lekktu@gmail.com>
11114
11115 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11116
5d4cb038
PE
111172011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11118
8bd7b830 11119 Improve C-level modularity by making more things 'static'.
cd64ea1d 11120
e3b27b31
PE
11121 Don't publish debugger-only interfaces to other modules.
11122 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11123 (verify_bytepos, count_markers): Move decls to the only modules
11124 that need them.
11125 * region-cache.h (pp_cache): Likewise.
11126 * window.h (check_all_windows): Likewise.
11127 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11128
5d4cb038
PE
11129 * sysdep.c (croak): Now static, if
11130 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11131 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11132
11133 * alloc.c (refill_memory_reserve): Now static if
11134 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11135 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11136
e87b6180
PE
11137 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11138 Define only if USE_LUCID.
11139
ac64929e
PE
11140 * xrdb.c (x_customization_string, x_rm_string): Now static.
11141
6f37259d
PE
11142 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11143 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11144
1683e3ab
PE
11145 * xdisp.c (draw_row_with_mouse_face): Now static.
11146 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11147
de9c2632
PE
11148 * window.h (check_all_windows): Mark externally visible.
11149
2b96acb7
PE
11150 * window.c (window_deletion_count): Now static.
11151
11152 * undo.c: Make symbols static if they're not exported.
11153 (last_undo_buffer, last_boundary_position, pending_boundary):
11154 Now static.
11155
50436f33
PE
11156 * textprop.c (interval_insert_behind_hooks): Now static.
11157 (interval_insert_in_front_hooks): Likewise.
11158
64520e5c
PE
11159 * term.c: Make symbols static if they're not exported.
11160 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11161 (max_frame_lines, tty_set_terminal_modes):
11162 (tty_reset_terminal_modes, tty_turn_off_highlight):
11163 (get_tty_terminal): Now static.
11164 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11165 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11166 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11167 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11168 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11169
1fa53021
PE
11170 * sysdep.c: Make symbols static if they're not exported.
11171 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11172 Now static.
11173 (sigprocmask_set, full_mask): Remove; unused.
11174 (wait_debugging): Mark as visible.
11175 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11176 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11177
d4b43b22
PE
11178 * syntax.c (syntax_temp): Define only if !__GNUC__.
11179
b7c513d0
PE
11180 * sound.c (current_sound_device, current_sound): Now static.
11181
989b29ad
PE
11182 * search.c (searchbufs, searchbuf_head): Now static.
11183
13a55a78
PE
11184 * scroll.c (scroll_cost): Remove; unused.
11185 * dispextern.h (scroll_cost): Remove decl.
11186
de68a1fc
PE
11187 * region-cache.h (pp_cache): Mark as externally visible.
11188
40ccffa6
PE
11189 * process.c: Make symbols static if they're not exported.
11190 (process_tick, update_tick, create_process, chan_process):
11191 (Vprocess_alist, proc_buffered_char, datagram_access):
11192 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11193 (deactivate_process): Mark defn as static, as well as decl.
11194 * lisp.h (create_process): Remove decl.
11195 * process.h (chan_process, Vprocess_alist): Remove decls.
11196
ad64fc97
PE
11197 * print.c: Make symbols static if they're not exported.
11198 (print_depth, new_backquote_output, being_printed, print_buffer):
11199 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11200 (print_interval, print_number_index, initial_stderr_stream):
11201 Now static.
11202 * lisp.h (Fprinc): Remove decl.
11203 (debug_output_compilation_hack): Mark as externally visible.
11204
adddb265
PE
11205 * sysdep.c (croak): Move decl from here to syssignal.h.
11206 * syssignal.h (croak): Put it here, so the API can be checked when
11207 'croak' is called from dissociate_if_controlling_tty.
11208
1717ede2
PE
11209 * minibuf.c: Make symbols static if they're not exported.
11210 (minibuf_save_list, choose_minibuf_frame): Now static.
11211 * lisp.h (choose_minibuf_frame): Remove decl.
11212
fa5fb2bc
PE
11213 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11214
1e3890d1
PE
11215 * lread.c: Make symbols static if they're not exported.
11216 (read_objects, initial_obarray, oblookup_last_bucket_number):
11217 Now static.
11218 (make_symbol): Remove; unused.
11219 * lisp.h (initial_obarray, make_symbol): Remove decls.
11220
8a1414fa
PE
11221 * keyboard.c: Make symbols static if they're not exported.
11222 (single_kboard, recent_keys_index, total_keys, recent_keys):
11223 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11224 (this_single_command_key_start, echoing, last_auto_save):
11225 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11226 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11227 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11228 (Vlispy_mouse_stem, double_click_count):
11229 Now static.
11230 (force_auto_save_soon): Define only if SIGDANGER.
11231 (ignore_mouse_drag_p): Now static if
11232 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11233 (print_help): Remove; unused.
11234 (stop_character, last_timer_event): Mark as externally visible.
11235 * keyboard.h (ignore_mouse_drag_p): Declare only if
11236 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11237 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11238 * lisp.h (echoing): Remove decl.
11239 (force_auto_save_soon): Declare only if SIGDANGER.
11240 * xdisp.c (redisplay_window): Simplify code, to make it more
11241 obvious that ignore_mouse_drag_p is not accessed if !defined
11242 USE_GTK && !defined HAVE_NS.
11243
93ea6e8f
PE
11244 * intervals.c: Make symbols static if they're not exported.
11245 (merge_properties_sticky, merge_interval_right, delete_interval):
11246 Now static.
11247 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11248
77382fcc
PE
11249 * insdel.c: Make symbols static if they're not exported.
11250 However, leave prepare_to_modify_buffer alone. It's never
11251 called from outside this function, but that appears to be a bug.
11252 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11253 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11254 (adjust_after_replace_noundo): Remove; unused.
11255 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11256 (signal_before_change): Remove decls.
77382fcc 11257
9306c32e
PE
11258 * indent.c (val_compute_motion, val_vmotion): Now static.
11259
cd44d2eb
PE
11260 * image.c: Make symbols static if they're not exported.
11261 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11262 if USE_GTK.
11263 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11264 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11265
ad9a7a06
PE
11266 * fringe.c (standard_bitmaps): Now static.
11267 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11268
81626931
PE
11269 * frame.c: Make symbols static if they're not exported.
11270 (x_report_frame_params, make_terminal_frame): Now static.
11271 (get_frame_param): Now static, unless HAVE_NS.
11272 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11273 (x_get_resource_string): Remove; not used.
11274 * frame.h (make_terminal_frame, x_report_frame_params):
11275 (x_get_resource_string); Remove decls.
11276 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11277 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11278
239f9db9
PE
11279 * font.c, fontset.c: Make symbols static if they're not exported.
11280 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11281 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11282 * font.c (font_close_object): Now static.
11283 * font.h (font_close_object): Remove.
11284 * fontset.c (FONTSET_OBJLIST): Remove.
11285 (free_realized_fontset) #if-0 the body, which does nothing.
11286 (face_suitable_for_char_p): #if-0, as it's never called.
11287 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11288 * xfaces.c (face_at_string_position):
11289 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11290 since 0 is always ASCII.
11291
dfcf3579
PE
11292 * fns.c (weak_hash_tables): Now static.
11293
5045092b
PE
11294 * fileio.c: Make symbols static if they're not exported.
11295 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11296 (Vwrite_region_annotation_buffers): Now static.
11297
57a96f5c
PE
11298 * eval.c: Make symbols static if they're not exported.
11299 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11300 * lisp.h (backtrace_list): Remove decl.
11301
35f08c38
PE
11302 * emacs.c: Make symbols static if they're not exported.
11303 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11304 (fatal_error_code, fatal_error_signal_hook, standard_args):
11305 Now static.
11306 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11307 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11308 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11309 * lisp.h (fatal_error_signal_hook): Remove decl.
11310 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11311
f44bd759
PE
11312 * editfns.c: Move a (normally-unused) function to its only use.
11313 * editfns.c, lisp.h (get_operating_system_release): Remove.
11314 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11315 worth the hassle of breaking this out.
11316
b532497d
PE
11317 * xterm.c: Make symbols static if they're not exported.
11318 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11319 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11320 (x_destroy_window, x_delete_display):
11321 Now static.
11322 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11323 (x_mouse_leave): Remove; unused.
11324 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11325 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11326 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11327 Remove decls.
11328 (x_mouse_leave): Declare only if WINDOWSNT.
11329 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11330 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11331 USE_X_TOOLKIT.
11332
1675728f
PE
11333 * ftxfont.c: Make symbols static if they're not exported.
11334 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11335 HAVE_FREETYPE.
11336 * font.h (ftxfont_driver): Likewise.
11337
e4cebfca
PE
11338 * xfns.c: Make symbols static if they're not exported.
11339 (x_last_font_name, x_display_info_for_name):
11340 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11341 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11342 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11343 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11344 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11345 (last_show_tip_args): Now static.
11346 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11347 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11348 (x_screen_planes): Remove; unused.
11349 * dispextern.h (x_screen_planes): Remove decl.
11350
5bf46f05
PE
11351 * dispnew.c: Make symbols static if they're not exported.
11352 * dispextern.h (redraw_garbaged_frames, scrolling):
11353 (increment_row_positions): Remove.
11354 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11355 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11356 Now static.
11357 (redraw_garbaged_frames): Remove; unused.
11358
435f4c28
PE
11359 * xfaces.c: Make symbols static if they're not exported.
11360 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11361 Remove decls.
11362 * xterm.h (defined_color): Remove decls.
11363 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11364 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11365 (menu_face_changed_default, defined_color, free_realized_face):
11366 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11367 (ascii_face_of_lisp_face): Remove; unused.
11368
8524aef3
PE
11369 * xdisp.c: Make symbols static if they're not exported.
11370 * dispextern.h (scratch_glyph_row, window_box_edges):
11371 (glyph_to_pixel_coords, set_cursor_from_row):
11372 (get_next_display_element, set_iterator_to_next):
11373 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11374 (show_mouse_face): Remove decls
11375 * frame.h (message_buf_print): Likewise.
11376 * lisp.h (pop_message, set_message, check_point_in_composition):
11377 Likewise.
11378 * xterm.h (set_vertical_scroll_bar): Likewise.
11379 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11380 (message_buf_print, scratch_glyph_row, displayed_buffer):
11381 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11382 (get_next_display_element, show_mouse_face, window_box_edges):
11383 (frame_to_window_pixel_xy, check_point_in_composition):
11384 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11385 (glyph_to_pixel_coords): Remove; unused.
11386
16390cd2
PE
11387 * dired.c (file_name_completion): Now static.
11388
11389 * dbusbind.c (xd_in_read_queued_messages): Now static.
11390
a25f4dfa
PE
11391 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11392 * data.c (circular_list_error): Remove.
11393
14a9c8df
PE
11394 * commands.h (last_point_position, last_point_position_buffer):
11395 (last_point_position_window): Remove decls.
11396 * keyboard.c: Make these variables static.
11397
04f2d78b
CB
11398 * coding.h (coding, code_convert_region, encode_coding_gap):
11399 Remove decls.
74ab6df5
PE
11400 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11401 (iso_code_class, detect_coding, code_convert_region): Now static.
11402 (encode_coding_gap): Remove; unused.
11403
38dfbee1
PE
11404 * chartab.c (chartab_chars, chartab_bits): Now static.
11405
a2cb4e63
PE
11406 * charset.h (charset_iso_8859_1): Remove decl.
11407 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11408 Now static.
11409
127198fd
PE
11410 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11411 * ccl.c (Vccl_program_table): Now static.
11412 (check_ccl_update): Remove; unused.
11413
d85b608f
PE
11414 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11415 * category.h: ... from here.
11416 * category.c (check_category_table, set_category_set): Now static.
11417
31cd66f3
PE
11418 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11419 * lisp.h: Remove these decls.
11420
c358e587
PE
11421 * buffer.c (buffer_count): Remove unused var.
11422
e78aecca
PE
11423 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11424 so that it's not optimized away.
11425 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11426 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11427 exported only to the debugger.
11428
e192d7d3 11429 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11430 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11431
92470028
PE
11432 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11433 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11434 was inaccessible from Lisp.
11435 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11436 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11437
244ed907
PE
11438 alloc.c: Import and export fewer symbols, and remove unused items.
11439 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11440 is defined.
11441 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11442 it's not optimized away by whole-program optimization.
11443 (message_enable_multibyte, free_misc): Remove.
11444 (catchlist, handlerlist, mark_backtrace):
11445 Declare only if BYTE_MARK_STACK.
11446 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11447 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11448 (message_enable_multibyte): Remove decl.
11449 (free_misc, interval_free_list, float_block, float_block_index):
11450 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11451 (cons_free_list, last_marked_index):
11452 Now static.
11453 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11454 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11455 (mark_backtrace): Define only if BYTE_MARK_STACK.
11456 * xdisp.c (message_enable_multibyte): Now static.
11457
61c2b50e 11458 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11459 This makes it easier for human readers (and static analyzers)
11460 to see whether these variables are used from other modules.
11461 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11462 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11463 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11464 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11465 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11466 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11467 * xmenu.c, xselect.c:
11468 Declare Q* vars static if they are not used in other modules.
11469 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11470 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11471 Remove decls of unexported vars.
11472 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11473
95c82688
PE
11474 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11475
16a97296
PE
11476 Make Emacs functions such as Fatom 'static' by default.
11477 This makes it easier for human readers (and static analyzers)
11478 to see whether these functions can be called from other modules.
11479 DEFUN now defines a static function. To make the function external
11480 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11481 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11482 (Finit_image_library):
16a97296
PE
11483 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11484 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11485 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11486 Remove decls, since these functions are now static.
11487 (Funintern, Fget_internal_run_time): New decls, since these functions
11488 were already external.
95c82688 11489
16a97296
PE
11490 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11491 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11492 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11493 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11494 * keyboard.c, keymap.c, lread.c:
11495 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11496 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11497 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11498 Mark functions with DEFUE instead of DEFUN,
11499 if they are used in other modules.
11500 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11501 decls for now-static functions.
11502 * buffer.h (Fdelete_overlay): Remove decl.
11503 * callproc.c (Fgetenv_internal): Mark as internal.
11504 * composite.c (Fremove_list_of_text_properties): Remove decl.
11505 (Fcomposition_get_gstring): New forward static decl.
11506 * composite.h (Fcomposite_get_gstring): Remove decl.
11507 * dired.c (Ffile_attributes): New forward static decl.
11508 * doc.c (Fdocumntation_property): New forward static decl.
11509 * eval.c (Ffetch_bytecode): New forward static decl.
11510 (Funintern): Remove extern decl; now in .h file where it belongs.
11511 * fileio.c (Fmake_symbolic_link): New forward static decl.
11512 * image.c (Finit_image_library): New forward static decl.
11513 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11514 * intervals.h (Fprevious_property_change):
11515 (Fremove_list_of_text_properties): Remove decls.
11516 * keyboard.c (Fthis_command_keys): Remove decl.
11517 (Fcommand_execute): New forward static decl.
11518 * keymap.c (Flookup_key): New forward static decl.
11519 (Fcopy_keymap): Now static.
11520 * keymap.h (Flookup_key): Remove decl.
11521 * process.c (Fget_process): New forward static decl.
11522 (Fprocess_datagram_address): Mark as internal.
11523 * syntax.c (Fsyntax_table_p): New forward static decl.
11524 (skip_chars): Remove duplicate decl.
11525 * textprop.c (Fprevious_property_change): New forward static decl.
11526 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11527 Now internal.
11528 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11529 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11530
785bbd42
PE
11531 * editfns.c (Fformat): Remove unreachable code.
11532
8b913b57
AS
115332011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11534
11535 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11536 change. (Bug#8496)
11537
a6744a35
EZ
115382011-04-13 Eli Zaretskii <eliz@gnu.org>
11539
11540 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11541 when at ZV. (Bug#8487)
11542
e7974947
AS
115432011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11544
baad03f0
AS
11545 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11546 (Bug#8437)
11547 * keyboard.c (parse_tool_bar_item): Likewise.
11548 * sound.c (sound_cleanup, alsa_close): Likewise.
11549 * termcap.c (tgetent): Likewise.
11550 * xfns.c (x_default_font_parameter): Likewise.
11551 * xsettings.c (read_and_apply_settings): Likewise.
11552
e7974947
AS
11553 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11554 (overrun_check_free): Protoize.
11555
28272684
PE
115562011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11557
11558 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11559 since callers should never pass a negative size.
11560 Change the signature to match that of plain 'read' and 'write'; see
11561 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11562 * lisp.h: Update prototypes of emacs_write and emacs_read.
11563
11997c76
EZ
115642011-04-11 Eli Zaretskii <eliz@gnu.org>
11565
11566 * xdisp.c (redisplay_window): Don't try to determine the character
11567 position of the scroll margin if the window start point w->startp
e896f03c 11568 is outside the buffer's accessible region. (Bug#8468)
11997c76 11569
8a2cbd72
EZ
115702011-04-10 Eli Zaretskii <eliz@gnu.org>
11571
11572 Fix write-region and its subroutines for buffers > 2GB.
11573 * fileio.c (a_write, e_write): Modify declaration of arguments and
11574 local variables to support buffers larger than 2GB.
11575 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11576
11577 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11578 argument, local variables, and return value.
11579
11580 * lisp.h: Update prototypes of emacs_write and emacs_read.
11581
11582 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11583
4073e537 115842011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11585
1ebfdcb6
PE
11586 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11587
b2ded58d
PE
11588 Fix more problems found by GCC 4.6.0's static checks.
11589
7d66342c
PE
11590 * xdisp.c (vmessage): Use a better test for character truncation.
11591
bbf47d44
PE
11592 * charset.c (load_charset_map): <, not <=, for optimization,
11593 and to avoid potential problems with integer overflow.
9248994d 11594 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11595 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11596 * editfns.c (Fformat): Likewise.
1e69125e 11597 * syntax.c (skip_chars): Likewise.
3befa583 11598
e3019616
PE
11599 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11600 This also lets GCC 4.6.0 generate slightly better loop code.
11601
becfa255
PE
11602 * callint.c (Fcall_interactively): <, not <=, for optimization.
11603 (Fcall_interactively): Count the number of arguments produced,
11604 not the number of arguments given. This is simpler and lets GCC
11605 4.6.0 generate slightly better code.
11606
dae0cd48
PE
11607 * ftfont.c: Distingish more carefully between FcChar8 and char.
11608 The previous code passed unsigned char * to a functions like
11609 strlen and xstrcasecmp that expect char *, which does not
11610 conform to the C standard.
11611 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11612 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11613 char * when the C standard requires it.
11614
76032d70
PE
11615 * keyboard.c (read_char): Remove unused var.
11616
eb3f1cc8
PE
11617 * eval.c: Port to Windows vsnprintf (Bug#8435).
11618 Include <limits.h>.
11619 (SIZE_MAX): Define if the headers do not.
11620 (verror): Do not give up if vsnprintf returns a negative count.
11621 Instead, grow the buffer. This ports to Windows vsnprintf, which
11622 does not conform to C99. Problem reported by Eli Zaretskii.
11623 Also, simplify the allocation scheme, by avoiding the need for
11624 calling realloc, and removing the ALLOCATED variable.
11625
70476b54
PE
11626 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11627
12020a9e
PE
11628 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11629 But keep the doprint source code for now, as we might revamp it
11630 and use it again (Bug#8435).
ea6c7ae6
PE
11631 * lisp.h (doprnt): Remove.
11632 * Makefile.in (base_obj): Remove doprnt.o.
11633 * deps.mk (doprnt.o): Remove.
11634
5fdb398c
PE
11635 error: Print 32- and 64-bit integers portably (Bug#8435).
11636 Without this change, on typical 64-bit hosts error ("...%d...", N)
11637 was used to print both 32- and 64-bit integers N, which relied on
11638 undefined behavior.
61bdb816 11639 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11640 * lisp.h (error, verror): Mark as printf-like functions.
11641 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11642 Report overflow in size calculations when allocating printf buffer.
11643 Do not truncate output string at its first null byte.
11644 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11645 Truncate the output at a character boundary, since vsnprintf does not
11646 do that.
11647 * charset.c (check_iso_charset_parameter): Convert internal
11648 character to string before calling 'error', since %c now has the
11649 printf meaning.
11650 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11651 overflow when computing char to be passed to 'error'. Do not
11652 pass Lisp_Object to 'error'; pass the integer instead.
11653 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11654 formatted with plain %d.
11655
b189fa66
PE
11656 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11657
bff87ef0
PE
11658 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11659
7e2cac20
PE
11660 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11661
ce4d90b5
PE
11662 * xterm.c (x_catch_errors): Remove duplicate declaration.
11663
266c9547
PE
11664 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11665
79c49ad2
PE
11666 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11667
368f4090
JM
116682011-04-10 Jim Meyering <meyering@redhat.com>
11669
11670 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11671 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11672 return ssize_t not "int", and use size_t as the buffer length.
11673 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11674 * gnutls.h: Update declarations.
11675 * process.c (read_process_output): Use ssize_t, to match.
11676 (send_process): Likewise.
11677
a32d4040
CY
116782011-04-09 Chong Yidong <cyd@stupidchicken.com>
11679
11680 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11681
8546720e 116822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11683
04f2d78b
CB
11684 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11685 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11686
8546720e
GM
11687 * xterm.c (handle_one_xevent):
11688 * xmenu.c (create_and_show_popup_menu):
11689 * xselect.c (x_decline_selection_request)
11690 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11691
0a2f5c1a 116922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11693
11694 Fix some uses of `int' instead of EMACS_INT.
11695 * search.c (string_match_1, fast_string_match)
11696 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11697 (scan_buffer, find_next_newline_no_quit)
11698 (find_before_next_newline, search_command, Freplace_match)
11699 (Fmatch_data): Make some `int' variables be EMACS_INT.
11700
11701 * xdisp.c (display_count_lines): 3rd argument and return value now
11702 EMACS_INT. All callers changed.
11703 (pint2hrstr): Last argument is now EMACS_INT.
11704
11705 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11706 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11707 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11708 (decode_coding_utf_16, decode_coding_emacs_mule)
11709 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11710 (decode_coding_ccl, decode_coding_charset)
11711 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11712 (decode_coding_iso_2022, decode_coding_emacs_mule)
11713 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11714 <char_offset, last_offset>: Declare EMACS_INT.
11715 (encode_coding_utf_8, encode_coding_utf_16)
11716 (encode_coding_emacs_mule, encode_invocation_designation)
11717 (encode_designation_at_bol, encode_coding_iso_2022)
11718 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11719 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11720 Declare EMACS_INT.
11721 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11722 (encode_invocation_designation): Last argument P_NCHARS is now
11723 EMACS_INT.
11724 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11725 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11726
11727 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11728 All users changed.
11729
11730 * ccl.c (Fccl_execute_on_string): Declare some variables
11731 EMACS_INT.
11732
8546720e 117332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11734
11735 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11736
4e19a977
CS
117372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11738
11739 * process.c (Fformat_network_address): Doc fix.
11740
87302331
R
117412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11742
ee7683eb 11743 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11744
cbb59342
CY
117452011-04-08 Chong Yidong <cyd@stupidchicken.com>
11746
11747 * keyboard.c (read_char): Call Lisp function help-form-show,
11748 instead of using internal_with_output_to_temp_buffer.
11749 (Qhelp_form_show): New var.
e0d38eeb 11750 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11751
11752 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11753
11754 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11755
e67a13ab
CY
117562011-04-06 Chong Yidong <cyd@stupidchicken.com>
11757
04f2d78b
CB
11758 * process.c (Flist_processes): Remove to Lisp.
11759 (list_processes_1): Delete.
e67a13ab 11760
973f782d
EZ
117612011-04-06 Eli Zaretskii <eliz@gnu.org>
11762
7c106b1e
EZ
11763 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11764
973f782d
EZ
11765 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11766
41cf7d1a 117672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11768
ca23cc88
PE
11769 Fix more problems found by GCC 4.6.0's static checks.
11770
f390e2d5
PE
11771 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11772
42eea0d0
PE
11773 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11774
b69769da 11775 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11776
f9541e84
PE
11777 * xdisp.c (vmessage): Mark as a printf-like function.
11778
13841b55
PE
11779 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11780
c136c10f
PE
11781 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11782
5e2d4a30
PE
11783 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11784 printf-like functions.
11785 (tiff_load): Add casts to remove these marks before passing them
11786 to system-supplied API.
11787
583f48b9
PE
11788 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11789
b25d760e
PE
11790 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11791 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11792 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11793 directly, rather than having caller test rule sign. This avoids
11794 some unnecessary tests.
11795 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11796 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11797 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11798
bc7b6697 11799 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11800 (xfont_open): Avoid unnecessary tests.
bc7b6697 11801
27ccc379
PE
11802 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11803
dcd5c89a
PE
11804 * composite.h, composite.c (composition_gstring_put_cache):
11805 Use EMACS_INT, not int, for length.
11806
b13a45c6
PE
11807 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11808 breaking out part of COMPOSITION_DECODE_RULE.
11809 (COMPOSITION_DECODE_RULE): Use it.
11810 * composite.c (get_composition_id): Remove unused local vars,
11811 by using the new macro.
11812
1e792e4d
PE
11813 * textprop.c (set_text_properties_1): Change while to do-while,
11814 since the condition is always true at first.
11815
dc6c6455 11816 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11817 (interval_deletion_adjustment): Return unsigned value.
11818 All uses changed.
dc6c6455 11819
aba7731a
PE
11820 * process.c (list_processes_1, create_pty, read_process_output):
11821 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11822 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11823 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11824 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11825 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11826
fdfc4bf3
PE
11827 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11828
fca8fe46 11829 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11830 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11831
06a0259a 11832 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11833 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11834 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11835
e7b9e80f
PE
11836 * print.c (print_error_message): Avoid int overflow.
11837
56201685
PE
11838 * font.c (font_list_entities): Redo for clarity,
11839 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11840
78834453 11841 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11842 (font_score): Avoid potential overflow in diff calculation.
78834453 11843
0bc0b309 11844 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11845 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11846
e610eaca
PE
11847 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11848
b895abce
PE
11849 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11850 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11851 can always succeed if overflow has undefined behavior.
11852
1f1d9321 11853 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11854 (wordify): Omit three unnecessary tests.
1f1d9321 11855
c59478bc
PE
11856 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11857 All callers changed. This avoids the need for an unused var.
11858
79b73827
PE
11859 * casefiddle.c (casify_region): Remove var that is set but not used.
11860
a4db5dfe
PE
11861 * dired.c (file_name_completion): Remove var that is set but not used.
11862
43aae36e
PE
11863 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11864
2a47c44d 11865 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11866 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11867
a37c69bf
PE
11868 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11869 Check for integer overflow on size calculations.
11870
328ab8e7
PE
11871 * buffer.c (Fprevious_overlay_change): Remove var that is set
11872 but not used.
11873
e5a2a5cb
PE
11874 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11875 Remove vars that are set but not used.
8d84a6eb 11876 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11877 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11878
a60e5f68
PE
11879 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11880
f661cb61 11881 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11882 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11883
f0397f5a
PE
11884 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11885 that are set but not used.
11886
8664db06 11887 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11888 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11889
6abdaa4a
PE
11890 * xselect.c (x_get_local_selection, x_handle_property_notify):
11891 Remove vars that are set but not used.
11892
0ce7538d 11893 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11894 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11895
9ae848fc
PE
11896 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11897 Remove var that is set but not used.
0b918413
PE
11898 (scroll_bar_windows_size): Now size_t, not int.
11899 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11900 Check for overflow.
9ae848fc 11901
a5a62657
PE
11902 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11903 (map_tty_color) [!defined MSDOS]: Likewise.
11904
5c5cdd39
PE
11905 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11906
66ebf983
PE
11907 * coding.c: Remove vars that are set but not used.
11908 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11909 All callers changed.
11910 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11911 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11912 (decode_coding_charset): Remove vars that are set but not used.
11913
1be4d761
PE
11914 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11915 that is set but not used.
11916
47553fa8
PE
11917 * print.c (print_object): Remove var that is set but not used.
11918
1f7196bf 11919 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11920 The gnulib version avoids calling malloc in the usual case,
11921 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11922 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11923 * filelock.c (current_lock_owner): Likewise.
11924 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11925 * sysdep.c: Include allocator.h, careadlinkat.h.
11926 (emacs_no_realloc_allocator): New static constant.
11927 (emacs_readlink): New function.
fdb61804
PE
11928 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11929 ../lib/careadlinkat.h.
d1fdcab7 11930
f84c17c7
SM
119312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11932
11933 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11934 first non-nil return value).
11935
ef3862ad
JD
119362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11937
11938 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11939 if not defined (Bug#8403).
11940
376a7006
JB
119412011-04-02 Juanma Barranquero <lekktu@gmail.com>
11942
11943 * xdisp.c (display_count_lines): Remove parameter `start',
11944 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11945 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11946 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11947 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11948 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11949 and thereabouts. All callers changed.
11950 (get_per_char_metric): Remove parameter `f', unused since
11951 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11952
6ca3801d
JM
119532011-04-02 Jim Meyering <meyering@redhat.com>
11954
11955 do not dereference NULL upon failed strdup
11956 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11957 (ns_get_family): Likewise.
11958
d8e2b5ba
JB
119592011-04-02 Juanma Barranquero <lekktu@gmail.com>
11960
11961 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11962
8c74fcbd
JD
119632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11964
11965 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11966 later (Bug#8403).
11967
7200d79c
SM
119682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11969
03408648 11970 Add lexical binding.
7200d79c 11971
03408648
SM
11972 * window.c (Ftemp_output_buffer_show): New fun.
11973 (Fsave_window_excursion):
11974 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11975
11976 * lread.c (lisp_file_lexically_bound_p): New function.
11977 (Fload): Bind Qlexical_binding.
11978 (readevalloop): Remove `evalfun' arg.
11979 Bind Qinternal_interpreter_environment.
11980 (Feval_buffer): Bind Qlexical_binding.
11981 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11982 Mark as dynamic.
11983 (syms_of_lread): Declare `lexical-binding'.
11984
11985 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11986
11987 * keyboard.c (eval_dyn): New fun.
11988 (menu_item_eval_property): Use it.
ca105506
SM
11989
11990 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11991
03408648
SM
11992 * fns.c (concat, mapcar1): Accept byte-code-functions.
11993
11994 * eval.c (Fsetq): Handle lexical vars.
11995 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11996 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11997 (FletX, Flet): Obey lexical binding.
11998 (Fcommandp): Handle closures.
11999 (Feval): New `lexical' arg.
12000 (eval_sub): New function extracted from Feval. Use it almost
12001 everywhere where Feval was used. Look up vars in lexical env.
12002 Handle closures.
12003 (Ffunctionp): Move from subr.el.
12004 (Ffuncall): Handle closures.
12005 (apply_lambda): Remove `eval_flags'.
12006 (funcall_lambda): Handle closures and new byte-code-functions.
12007 (Fspecial_variable_p): New function.
12008 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12009 but without exporting it to Lisp.
23aba0ea 12010
23aba0ea 12011 * doc.c (Fdocumentation, store_function_docstring):
03408648 12012 * data.c (Finteractive_form): Handle closures.
23aba0ea 12013
03408648
SM
12014 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12015 interactive spec.
ba83908c 12016
04f2d78b
CB
12017 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12018 New byte-codes.
03408648
SM
12019 (exec_byte_code): New function extracted from Fbyte_code to handle new
12020 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12021
03408648 12022 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12023
03408648 12024 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12025
e2abce01
JB
120262011-03-31 Juanma Barranquero <lekktu@gmail.com>
12027
12028 * xdisp.c (redisplay_internal): Fix prototype.
12029
63696a73 120302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12031
63696a73 12032 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12033 (try_scrolling): Use it when setting scroll_limit.
12034 Limit scrolling to 100 screen lines.
63696a73
EZ
12035 (redisplay_window): Even when falling back on "recentering",
12036 position point in the window according to scroll-conservatively,
12037 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12038
12039 (try_scrolling): When point is above the window, allow searching
12040 as far as scroll_max, or one screenful, to compute vertical
12041 distance from PT to the scroll margin position. This prevents
12042 try_scrolling from unnecessarily failing when
12043 scroll-conservatively is set to a value slightly larger than the
12044 window height. Clean up the case of PT below the margin at bottom
12045 of window: scroll_max can no longer be INT_MAX. When aggressive
12046 scrolling is in use, don't let point enter the opposite scroll
12047 margin as result of the scroll.
12048 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12049 threshold of 100 lines for never-recentering scrolling.
12050
e4cc2dfc
JB
120512011-03-31 Juanma Barranquero <lekktu@gmail.com>
12052
12053 * dispextern.h (move_it_by_lines):
12054 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12055 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12056 (message_log_check_duplicate): Remove parameters `prev_bol' and
12057 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12058 (redisplay_internal): Remove parameter `preserve_echo_area',
12059 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12060
12061 * indent.c (Fvertical_motion):
12062 * window.c (window_scroll_pixel_based, Frecenter):
12063 Don't pass `need_y_p' to `move_it_by_lines'.
12064
1c470562
SM
120652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12066
44f230aa
SM
12067 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12068 steal a few bits to be more compact.
12069 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12070 Remove unneeded casts.
12071
1c470562
SM
12072 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12073
888adce9
ZK
120742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12075
12076 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12077 binding" message (bug#7967).
12078
f838ed7b
PE
120792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12080
77861b95
PE
12081 Fix more problems found by GCC 4.6.0's static checks.
12082
de6dbc14
PE
12083 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12084 Remove unused local var.
12085
f838ed7b
PE
12086 * editfns.c (Fmessage_box): Remove unused local var.
12087
792c7b2b
PE
12088 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12089 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12090 Omit unused local vars.
c499e557 12091 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12092 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12093 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12094 Omit unused local var.
12095
ba0165e1
PE
12096 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12097 Don't assume string length fits in int.
32ad8845 12098 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12099 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12100
3c59b4c9
PE
12101 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12102 instead of alloca (Bug#8344).
12103
a3eed478 12104 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12105 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12106
eb4d412d
PE
12107 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12108
1658b401
PE
12109 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12110 concerns.
12111
12112 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12113
12114 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12115
9a2c6e05
PE
12116 * keyboard.c (syms_of_keyboard): Use the same style as later
12117 in this function when indexing through an array. This also
12118 works around GCC bug 48267.
12119
03d0a109
PE
12120 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12121
44f730c8
PE
12122 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12123
fe75f926
PE
12124 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12125 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12126
ffa8c828
PE
12127 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12128 This avoids undefined behavior on integer overflow, and is a bit
12129 more convenient anyway since it is compared to a size_t variable.
12130
c5101a77
PE
12131 Variadic C functions now count arguments with size_t, not int.
12132 This avoids an unnecessary limitation on 64-bit machines, which
12133 caused (substring ...) to crash on large vectors (Bug#8344).
12134 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12135 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12136 All variadic functions and their callers changed accordingly.
c5101a77
PE
12137 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12138 * data.c (arith_driver, float_arith_driver): Likewise.
12139 * editfns.c (general_insert_function): Likewise.
12140 * eval.c (struct backtrace.nargs, interactive_p)
12141 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12142 (funcall_lambda, mark_backtrace): Likewise.
12143 * fns.c (concat): Likewise.
12144 * frame.c (x_set_frame_parameters): Likewise.
12145 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12146 0 if not found, not -1. All callers changed.
12147
dd3f25f7
PE
12148 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12149 (stack_copy_size): Now size_t, not int.
12150 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12151
461c2ab9
JB
121522011-03-28 Juanma Barranquero <lekktu@gmail.com>
12153
12154 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12155 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12156 All callers changed.
12157
12158 * lisp.h (multibyte_char_to_unibyte):
12159 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12160 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12161 * character.h (CHAR_TO_BYTE8):
12162 * cmds.c (internal_self_insert):
12163 * editfns.c (general_insert_function):
12164 * keymap.c (push_key_description):
12165 * search.c (Freplace_match):
12166 * xdisp.c (message_dolog, set_message_1): All callers changed.
12167
f6d62986
SM
121682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12169
12170 * keyboard.c (safe_run_hook_funcall): New function.
12171 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12172 don't set the hook to nil, but remove the offending function instead.
12173 (Qcommand_hook_internal): Remove, unused.
12174 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12175 Vcommand_hook_internal.
12176
12177 * eval.c (enum run_hooks_condition): Remove.
12178 (funcall_nil, funcall_not): New functions.
12179 (run_hook_with_args): Call each function through a `funcall' argument.
12180 Remove `cond' argument, now redundant.
12181 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12182 (Frun_hook_with_args_until_failure): Adjust accordingly.
12183 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12184
1db5b1ad
JB
121852011-03-28 Juanma Barranquero <lekktu@gmail.com>
12186
12187 * dispextern.h (string_buffer_position): Remove declaration.
12188
12189 * print.c (strout): Remove parameter `multibyte', unused since
12190 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12191
12192 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12193 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12194 All callers changed.
12195
12196 * w32.c (_wsa_errlist): Use braces for struct initializers.
12197
12198 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12199 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12200 All callers changed.
12201 (string_buffer_position): Likewise. Also, make static (it's never
12202 used outside xdisp.c).
12203 (cursor_row_p): Remove parameter `w', unused since
12204 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12205 (decode_mode_spec): Remove parameter `precision', introduced during
12206 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12207 All callers changed.
12208
5ffb62aa
JD
122092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12210
12211 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12212
461c2ab9 122132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12214
12215 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12216 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12217 (ns_update_auto_hide_menu_bar): New functions.
12218 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12219 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12220 ns_constrain_all_frames.
12221 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12222 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12223
5c380ffb
JD
122242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12225
12226 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12227
9af30bdf
GM
122282011-03-27 Glenn Morris <rgm@gnu.org>
12229
12230 * syssignal.h: Replace RETSIGTYPE with void.
12231 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12232 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12233 Replace SIGTYPE with void everywhere.
12234 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12235 * s/template.h (SIGTYPE): Remove commented out definition.
12236
e2abce01
JB
122372011-03-26 Eli Zaretskii <eliz@gnu.org>
12238
12239 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12240 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12241
f868cd8a
JB
122422011-03-26 Juanma Barranquero <lekktu@gmail.com>
12243
59eb0929
JB
12244 * w32.c (read_unc_volume): Use parameter `henum', instead of
12245 global variable `wget_enum_handle'.
12246
12247 * keymap.c (describe_vector): Remove parameters `indices' and
12248 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12249 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12250
f868cd8a
JB
12251 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12252
12253 * keyboard.c (timer_check): Remove parameter `do_it_now',
12254 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12255 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12256 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12257
12258 * keyboard.c (read_char):
12259 * w32menu.c (w32_menu_display_help):
12260 * xmenu.c (show_help_event, menu_help_callback):
12261 Adjust calls to `show_help_echo'.
12262
12263 * gtkutil.c (xg_maybe_add_timer):
12264 * keyboard.c (readable_events):
12265 * process.c (wait_reading_process_output):
12266 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12267
12268 * insdel.c (adjust_markers_gap_motion):
12269 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12270 (gap_left, gap_right): Don't call it.
12271
2ecf6fdb
CY
122722011-03-25 Chong Yidong <cyd@stupidchicken.com>
12273
12274 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12275 incurred during fontification.
12276
6b1f9ba4
JB
122772011-03-25 Juanma Barranquero <lekktu@gmail.com>
12278
12279 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12280 (DEFVAR_PER_BUFFER): Don't pass it.
12281
12282 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12283 (scrolling_window): Don't pass it.
12284
0f4a96b5
JB
122852011-03-25 Juanma Barranquero <lekktu@gmail.com>
12286
12287 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12288
12289 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12290 and `suffix'.
12291 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12292 of variables specific to SELinux and computation of `encoded_absname'.
12293
12294 * image.c (XPutPixel): Remove unused variable `height'.
12295
12296 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12297
12298 * unexw32.c (get_section_info): Remove unused variable `section'.
12299
12300 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12301 (system_process_attributes): Remove unused variable `sess'.
12302 (sys_read): Remove unused variable `err'.
12303
12304 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12305 (w32_wnd_proc): Remove unused variable `isdead'.
12306 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12307 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12308 (x_create_tip_frame): Remove unused variable `tem'.
12309
12310 * w32inevt.c (w32_console_read_socket):
12311 Remove unused variable `no_events'.
12312
12313 * w32term.c (x_draw_composite_glyph_string_foreground):
12314 Remove unused variable `width'.
12315
1149507c
JB
123162011-03-24 Juanma Barranquero <lekktu@gmail.com>
12317
12318 * w32term.c (x_set_glyph_string_clipping):
12319 Don't pass uninitialized region to CombineRgn.
12320
9c88f339
JB
123212011-03-23 Juanma Barranquero <lekktu@gmail.com>
12322
12323 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12324 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12325 (Fx_close_connection): Remove unused variable `i'.
12326
12327 * w32font.c (w32font_draw): Return number of glyphs.
12328 (w32font_open_internal): Remove unused variable `i'.
12329 (w32font_driver): Add missing initializer.
12330
12331 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12332 (fill_in_menu): Remove unused variable `items_added'.
12333
12334 * w32term.c (last_mouse_press_frame): Remove static global variable.
12335 (w32_clip_to_row): Remove unused variable `f'.
12336 (x_delete_terminal): Remove unused variable `i'.
12337
12338 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12339 (NOTHING): Remove unused static global variable.
12340 (uniscribe_check_otf): Remove unused variable `table'.
12341 (uniscribe_font_driver): Add missing initializers.
12342
dee091a3
JD
123432011-03-23 Julien Danjou <julien@danjou.info>
12344
12345 * term.c (Fsuspend_tty, Fresume_tty):
12346 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12347 * window.c (temp_output_buffer_show):
12348 * insdel.c (signal_before_change):
12349 * frame.c (Fhandle_switch_frame):
12350 * fileio.c (Fdo_auto_save):
12351 * emacs.c (Fkill_emacs):
12352 * editfns.c (save_excursion_restore):
12353 * cmds.c (internal_self_insert):
12354 * callint.c (Fcall_interactively):
12355 * buffer.c (Fkill_all_local_variables):
12356 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12357 Use Frun_hooks.
0f4a96b5 12358 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12359 unconditionally since it does the check itself.
dee091a3 12360
2c520ab5 123612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12362
c9c49752
PE
12363 Fix more problems found by GCC 4.5.2's static checks.
12364
8abc3f12
PE
12365 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12366 the first time through the loop, since we know p0 < p1 then.
12367 This also avoids a gcc -Wstrict-overflow warning.
12368
a2d26660
PE
12369 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12370 leading to a memory leak, possible in functions like
12371 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12372 of objects (Bug#8318).
a2d26660 12373
916c72e9
PE
12374 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12375 that could (at least in theory) be that large.
12376
19ab8a18
PE
12377 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12378 This is less likely to overflow, and avoids undefined behavior if
12379 overflow does occur. All callers changed. Use strtoul to scan
12380 for the unsigned long integer.
b7cbbd6f
PE
12381 (pint2hrstr): Simplify and tune code slightly.
12382 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12383
f0641eff
PE
12384 * scroll.c (do_scrolling): Work around GCC bug 48228.
12385 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12386
7f650bb9
PE
12387 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12388 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12389 (validate_x_resource_name): Simplify count usage.
12390 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12391
37dd57d1
PE
12392 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12393 fail (Bug#8306).
81e56e61 12394
699979fc 12395 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12396
401bf9b4
PE
12397 * process.c (Fmake_network_process): Use socklen_t, not int,
12398 where POSIX says socklen_t is required in portable programs.
12399 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12400 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12401 (Fmake_network_process, server_accept_connection):
12402 (wait_reading_process_output, read_process_output):
12403 Likewise.
12404
b93aacde
PE
12405 * process.c: Rename or move locals to avoid shadowing.
12406 (list_processes_1, Fmake_network_process):
12407 (read_process_output_error_handler, exec_sentinel_error_handler):
12408 Rename or move locals.
4dc343ee 12409 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12410 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12411 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12412 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12413 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12414
af8a867c 12415 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12416 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12417 Include tparam.h instead, since it declares them.
af8a867c
PE
12418 * cm.h (PC): Remove extern decl; tparam.h now does this.
12419 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12420 * terminfo.c: Include tparam.h, to check interfaces.
12421 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12422 (tparam): Adjust signature to match interface in tparam.h;
12423 this removes some undefined behavior. Check that outstring and len
12424 are zero, which they always are with Emacs.
12425 * tparam.h (PC, BC, UP): New extern decls.
12426
0248044d 12427 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12428 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12429
8ff096c1 12430 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12431 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12432 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12433 (ftfont_list): Remove unused local.
49eaafba
PE
12434 (get_adstyle_property, ftfont_pattern_entity):
12435 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12436 Rename locals to avoid shadowing.
8ff096c1 12437
e2be39f6
PE
12438 * xfont.c (xfont_list_family): Mark var as initialized.
12439
c9735e30
PE
12440 * xml.c (make_dom): Now static.
12441
8f5201ae
PE
12442 * composite.c (composition_compute_stop_pos): Rename local to
12443 avoid shadowing.
b246f932
PE
12444 (composition_reseat_it): Remove unused locals.
12445 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12446 (composition_update_it): Mark var as initialized.
11b61122
PE
12447 (find_automatic_composition): Mark vars as initialized,
12448 with a FIXME (Bug#8290).
8f5201ae 12449
760fbc2c
PE
12450 character.h: Rename locals to avoid shadowing.
12451 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12452 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12453 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12454 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12455 to avoid shadowing.
12456
ff08eb85
PE
12457 * textprop.c (property_change_between_p): Remove; unused.
12458
fc7bf025
PE
12459 * intervals.c (interval_start_pos): Now static.
12460
235d7abc
PE
12461 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12462
44f230aa
SM
12463 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12464 Rename locals to avoid shadowing.
3e7d6594 12465
50060332
PE
12466 * sound.c (wav_play, au_play, Fplay_sound_internal):
12467 Fix pointer signedness.
d01f234b 12468 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12469 (wav_play): Initialize a variable to 0, to prevent undefined
12470 behavior (Bug#8278).
50060332 12471
c4fc4e30
PE
12472 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12473
918436ed
PE
12474 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12475
c939f91b
PE
12476 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12477 clobbering (Bug#8298).
b9c7f648
PE
12478 * sysdep.c (sys_subshell): Likewise.
12479 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12480
6bd8c144
PE
12481 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12482 This should get cleaned up, so that child_setup has the
12483 same signature on all platforms.
12484
7710357c 12485 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12486 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12487
c59da222
CY
124882011-03-22 Chong Yidong <cyd@stupidchicken.com>
12489
12490 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12491 not to be necessary, and produces flickering.
12492
66b87493
GM
124932011-03-20 Glenn Morris <rgm@gnu.org>
12494
12495 * config.in: Remove file.
12496
45b6f6d5
JB
124972011-03-20 Juanma Barranquero <lekktu@gmail.com>
12498
12499 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12500 are now in src/globals.h.
12501 (syms_of_minibuf): Remove spurious & from previous change.
12502
cd394be1 125032011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12504
12505 * minibuf.c (completing-read-function): New variable.
12506 (completing-read-default): Rename from completing-read.
12507 (completing-read): Call completing-read-function.
12508
b14e3e21
CY
125092011-03-19 Juanma Barranquero <lekktu@gmail.com>
12510
12511 * xfaces.c (Fx_load_color_file):
12512 Read color file from absolute filename (bug#8250).
12513
f2b726e6
JB
125142011-03-19 Juanma Barranquero <lekktu@gmail.com>
12515
12516 * makefile.w32-in: Update dependencies.
12517
09f6ff02
EZ
125182011-03-17 Eli Zaretskii <eliz@gnu.org>
12519
12520 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12521
29a6015a
PE
125222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12523
a3a6c54e
PE
12524 Fix more problems found by GCC 4.5.2's static checks.
12525
b766f867
PE
12526 * process.c (make_serial_process_unwind, send_process_trap):
12527 (sigchld_handler): Now static.
12528
be02381c
PE
12529 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12530 That way, the code declares only the vars that it needs.
12531 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12532 * s/cygwin.h (PTY_ITERATION): Likewise.
12533 * s/darwin.h (PTY_ITERATION): Likewise.
12534 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12535
57048744
PE
12536 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12537 * process.c (allocate_pty): Don't declare stb unless it's needed.
12538
7914961c 12539 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12540 (CONSTANTLIM): Remove; unused.
12541 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12542 Define only if needed.
7914961c 12543
b3967b18
PE
12544 * unexelf.c (unexec): Name an expression,
12545 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12546 Use a different way to cause a compilation error if anyone uses
12547 n rather than nn, a way that does not involve shadowing.
73366a00 12548 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12549
29a6015a
PE
12550 * deps.mk (unexalpha.o): Remove; unused.
12551
43cfc33e 12552 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12553 * unexec.h: New file.
ce701a33
PE
12554 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12555 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12556 Depend on unexec.h.
12557 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12558 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12559 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12560 Change as necessary to match prototype in unexec.h.
ce701a33 12561
01f44d5a
PE
12562 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12563 shadowing.
4f63c6bb 12564 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12565
a6670b0b
PE
12566 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12567 Rename locals to avoid shadowing.
12568
cef2010d 12569 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12570 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12571
d4d7173a
PE
12572 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12573
f08b802a
PE
12574 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12575 warning when compiling print.c.
12576
3ddb0639
PE
12577 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12578 instead of using an uninitialized var.
5ad03b97 12579 (font_sort_entities): Mark var as initialized.
3ddb0639 12580
170a2692
PE
12581 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12582
e663c700
PE
12583 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12584 pointers to constants.
89bc529a 12585 (font_parse_fcname): Remove unused vars.
7b81e2d0 12586 (font_delete_unmatched): Now static.
ea838e10 12587 (font_get_spec): Remove; unused.
13a547c6
PE
12588 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12589 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12590 Rename or move locals to avoid shadowing.
e663c700 12591
2a80c887 12592 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12593 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12594
1384fa33 12595 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12596 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12597
8b2c52e9
PE
12598 * alloc.c (mark_backtrace): Move decl from here ...
12599 * lisp.h: ... to here, so that it can be checked.
12600
475545b5 12601 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12602 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12603 (lisp_indirect_variable): Name an expression,
12604 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12605 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12606
b1349114 12607 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12608 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12609 Use const pointer when appropriate.
b1349114 12610
a2928364
PE
12611 * lisp.h (get_system_name, get_operating_system_release):
12612 Move decls here, to check interfaces.
12613 * process.c (get_operating_system_release): Move decl to lisp.h.
12614 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12615 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12616 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12617 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12618 (Fformat_time_string, Fencode_time, Finsert_char):
12619 (Ftranslate_region_internal, Fformat):
12620 Rename or remove local vars to avoid shadowing.
9710023e 12621 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12622
a415e694
PE
12623 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12624 avoid shadowing.
12625
8ef4622d
PE
12626 * lisp.h (eassert): Check that the argument compiles, even if
12627 ENABLE_CHECKING is not defined.
12628
946f9a5b
PE
12629 * data.c (Findirect_variable): Name an expression, to avoid
12630 gcc -Wbad-function-cast warning.
112396d6 12631 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12632 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12633 (Fmake_variable_buffer_local, Fmake_local_variable):
12634 Mark variables as initialized.
52746918 12635 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12636
e5aab7e7 12637 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12638 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12639 Rename locals to avoid shadowing.
dff45157
PE
12640 (mark_stack): Move local variables into the #ifdef region where
12641 they're used.
7bc26fdb
PE
12642 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12643 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12644 needed otherwise.
12645 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12646 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12647 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12648
e5aab7e7
PE
12649 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12650 avoids undefined behavior in theory.
12651
4da60324
PE
12652 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12653
88043301
PE
12654 Use functions, not macros, for up- and down-casing (Bug#8254).
12655 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12656 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12657 to use the following functions instead of these macros.
12658 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12659 EMACS_INT, since callers assume the returned value fits in int.
12660 (upcase1): Likewise, for UPCASE_TABLE.
12661 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12662 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12663 the race-condition problem in the old DOWNCASE.
88043301 12664
19ed5445
PE
12665 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12666 Rename locals to avoid shadowing.
12667 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12668 (regex_compile, re_search_2, re_match_2_internal):
12669 Remove unused local vars.
952db0d7
PE
12670 (FREE_VAR): Rewrite so as not to use empty "else",
12671 which gcc can warn about.
da053e48 12672 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12673 (RETALLOC_IF): Define only if needed.
12674 (WORDCHAR_P): Likewise. This one is never needed, but is used
12675 only in a comment talking about a compiler bug, so put inside
12676 the #if 0 of that comment.
12677 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12678 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12679 Remove; unused.
19ed5445 12680
1f3561e4 12681 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12682 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12683 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12684
ded6f8f7
PE
12685 * search.c (simple_search): Remove unused var.
12686
dbd37a95
PE
12687 * dired.c (compile_pattern): Move decl from here ...
12688 * lisp.h: ... to here, so that it can be checked.
12689 (struct re_registers): New forward decl.
12690
7e47afad
PE
12691 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12692
85f24f61
PE
12693 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12694 All uses changed.
12695 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12696 Rename locals to avoid shadowing.
5671df8f 12697 (Fvertical_motion): Mark locals as initialized.
85f24f61 12698
181aa2be 12699 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12700 (casify_region): Mark local as initialized.
181aa2be 12701
930d429c
PE
12702 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12703
7082eac6
PE
12704 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12705 New macros, so that the caller can use some names other than
12706 gcpro1, gcpro2, etc.
12707 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12708 of the new macros.
12709 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12710 argument, for consistency with GCPRO2_VAR, etc: it is now the
12711 prefix of the variable, not the variable itself. All uses
12712 changed.
38b2c076
PE
12713 * dired.c (directory_files_internal, file_name_completion):
12714 Rename locals to avoid shadowing.
12715
15206ed9
PE
12716 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12717 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12718 dired.c's scmp function, had undefined behavior.
12719 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12720 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12721 * buffer.h: ... to here, because these macros use current_buffer,
12722 and the new implementation with inline functions needs to have
12723 current_buffer in scope now, rather than later when the macros
12724 are used.
12725 (downcase, upcase1): New static inline functions.
12726 (DOWNCASE, UPCASE1): Reimplement using these functions.
12727 This avoids undefined behavior in expressions like
12728 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12729 from race conditions in accessing the global variables
12730 case_temp1 and case_temp2.
12731 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12732 * lisp.h (case_temp1, case_temp2): Remove their decls.
12733 * character.h (ASCII_CHAR_P): Move from here ...
12734 * lisp.h: ... to here, so that the inline functions mentioned
12735 above can use them.
12736
4a6bea26
PE
12737 * dired.c (directory_files_internal_unwind): Now static.
12738
f14b7e14
PE
12739 * fileio.c (file_name_as_directory, directory_file_name):
12740 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12741 Now static.
2893f146
PE
12742 (file_name_as_directory): Use const pointers when appropriate.
12743 (Fexpand_file_name): Likewise. In particular, newdir might
12744 point at constant storage, so make it a const pointer.
fd4ead52 12745 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12746 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12747 signedness issues.
f839df0c
PE
12748 (Fset_file_times, Finsert_file_contents, auto_save_error):
12749 Rename locals to avoid shadowing.
f14b7e14 12750
5716756e 12751 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12752 (Ftry_completion, Fall_completions): Rename or remove locals
12753 to avoid shadowing.
5716756e 12754
b4c3046a
PE
12755 * marker.c (bytepos_to_charpos): Remove; unused.
12756
b45db522
PE
12757 * lisp.h (verify_bytepos, count_markers): New decls,
12758 so that gcc does not warn that these functions aren't declared.
12759
85876d07
PE
12760 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12761 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12762 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12763 (copy_text): Remove unused local var.
85876d07 12764
03d78a21 12765 * filelock.c (within_one_second): Now static.
b3dd38ab 12766 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12767
5df8f01b
PE
12768 * buffer.c (fix_overlays_before): Mark locals as initialized.
12769 (fix_start_end_in_overlays): Likewise. This function should be
12770 simplified by using pointers-to-pointers, but that's a different
12771 matter.
b1d876f1 12772 (switch_to_buffer_1): Now static.
8f54f30a
PE
12773 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12774 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12775
a70072c9 12776 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12777 Fix pointer signedness issue.
edced198
PE
12778 (sys_subshell): Mark local as volatile if checking for lint,
12779 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12780 (MAXPATHLEN): Define only if needed.
a70072c9 12781
a0977c44
PE
12782 * process.c (serial_open, serial_configure): Move decls from here ...
12783 * systty.h: ... to here, so that they can be checked.
12784
a884fdcc
PE
12785 * fns.c (get_random, seed_random): Move extern decls from here ...
12786 * lisp.h: ... to here, so that they can be checked.
12787
604efe86 12788 * sysdep.c (reset_io): Now static.
b8950c94 12789 (wait_for_termination_signal): Remove; unused.
604efe86 12790
38fc62d9
PE
12791 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12792 (copy_keymap_item, append_key, push_text_char_description):
12793 Now static.
1004a21a 12794 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12795 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12796 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12797 (describe_map_tree):
12798 Rename locals to avoid shadowing.
38fc62d9 12799
2f2650da
PE
12800 * keyboard.c: Declare functions static if they are not used elsewhere.
12801 (echo_char, echo_dash, cmd_error, top_level_2):
12802 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12803 (read_char, kbd_buffer_get_event, make_lispy_position):
12804 (make_lispy_event, make_lispy_movement, apply_modifiers):
12805 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12806 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12807 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12808 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12809 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12810
a053e86c 12811 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12812 (mark_kboards): Move decl here ...
12813 * alloc.c (mark_kboards): ... from here.
a053e86c 12814
4752793e
PE
12815 * lisp.h (force_auto_save_soon): New decl.
12816
74f10ca7 12817 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12818 (DEFINE_DUMMY_FUNCTION): New macro.
12819 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12820 Use it.
c03cd23f
PE
12821 (main): Add casts to avoid warnings
12822 if GCC considers string literals to be constants.
74f10ca7 12823
022e70d4
PE
12824 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12825
59d6fe83
PE
12826 * dbusbind.c: Pointer signedness fixes.
12827 (xd_signature, xd_append_arg, xd_initialize):
12828 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12829 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12830 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12831 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12832
78320123
PE
12833 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12834 if GCC considers string literals to be constants.
49cebcca 12835 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12836
35ac2a97
SM
128372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12838
fb103ca9
SM
12839 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12840 (print_preprocess, print_object): New macro to fix last change.
12841
35ac2a97
SM
12842 * print.c (print_preprocess): Don't forget font objects.
12843
62973b41
JB
128442011-03-16 Juanma Barranquero <lekktu@gmail.com>
12845
12846 * emacs.c (USAGE3): Doc fixes.
12847
0e48bb22
AS
128482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12849
12850 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12851 structure.
12852
7684e57b
JB
128532011-03-14 Juanma Barranquero <lekktu@gmail.com>
12854
12855 * lisp.h (VWindow_system, Qfile_name_history):
12856 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12857 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12858 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12859
12860 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12861 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12862
12863 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12864 * w32console.c (detect_input_pending, read_input_pending)
12865 (encode_terminal_code):
12866 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12867 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12868 (w32_system_caret_y, Qfile_name_history):
12869 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12870 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12871 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12872 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12873 * w32proc.c (Qlocal, report_file_error):
12874 * w32term.c (Vwindow_system, updating_frame):
12875 * w32uniscribe.c (initialized, uniscribe_font_driver):
12876 Remove unneeded extern declarations.
12877
2aa46d6c
CY
128782011-03-14 Chong Yidong <cyd@stupidchicken.com>
12879
c96bbc66 12880 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12881
cffc6f3b
CY
128822011-03-13 Chong Yidong <cyd@stupidchicken.com>
12883
12884 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12885 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12886 These macros can no longer be used for assignment.
12887
44f230aa
SM
12888 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12889 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12890 (record_buffer_markers, fetch_buffer_markers): New functions for
12891 recording and fetching special buffer markers.
12892 (set_buffer_internal_1, set_buffer_temp): Use them.
12893
12894 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12895
12896 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12897
12898 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12899 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12900
12901 * xdisp.c (hscroll_window_tree):
12902 (reconsider_clip_changes): Use PT instead of BUF_PT.
12903
d251f04b
EZ
129042011-03-13 Eli Zaretskii <eliz@gnu.org>
12905
12906 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12907 $(EMACS_ROOT)/lib/intprops.h.
12908
f0c77cd1
PE
129092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12910
3eca4629
PE
12911 Fix more problems found by GCC 4.5.2's static checks.
12912
7c86ee98
PE
12913 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12914 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12915 (xg_free_frame_widgets): Make it clear that a local variable is
12916 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12917 (gdk_window_get_screen): Make it clear that this macro is needed
12918 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12919 (int_gtk_range_get_value): New function, which avoids a diagnostic
12920 from gcc -Wbad-function-cast.
12921 (xg_set_toolkit_scroll_bar_thumb): Use it.
12922 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12923 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12924 (get_utf8_string, xg_get_file_with_chooser):
12925 Rename locals to avoid shadowing.
12926 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12927
41729b81
PE
12928 * xgselect.c (xg_select): Remove unused var.
12929
f0c77cd1
PE
12930 * image.c (four_corners_best): Mark locals as initialized.
12931 (gif_load): Initialize transparent_p to zero (Bug#8238).
12932 Mark another local as initialized.
ec6cf4c6 12933 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12934
ce0ad53d 12935 * image.c (clear_image_cache): Now static.
d5d5a617 12936 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12937 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12938 (x_edge_detection): Remove unnecessary cast that
12939 gcc -Wbad-function-cast diagnoses.
2037898d 12940 (gif_load): Fix pointer signedness.
6ae141d6
PE
12941 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12942 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12943
33383987 129442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12945
d32df629
PE
12946 Improve quality of tests for time stamp overflow.
12947 For example, without this patch (encode-time 0 0 0 1 1
12948 1152921504606846976) returns the obviously-bogus value (-948597
12949 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12950 reports time overflow. See
12951 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12952 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12953 * editfns.c: Include limits.h and intprops.h.
12954 (TIME_T_MIN, TIME_T_MAX): New macros.
12955 (time_overflow): Move earlier, to before first use.
12956 (hi_time, lo_time): New functions, for an accurate test for
12957 out-of-range times.
12958 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12959 (Fget_internal_run_time): Don't assume time_t fits in int.
12960 (make_time): Use list2 instead of Fcons twice.
12961 (Fdecode_time): More accurate test for out-of-range times.
12962 (check_tm_member): New function.
12963 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12964 (lisp_time_argument): Don't rely on undefined left-shift and
12965 right-shift behavior when checking for time stamp overflow.
8be6f318 12966
fe31d94c
PE
12967 * editfns.c (time_overflow): New function, refactoring common code.
12968 (Fformat_time_string, Fdecode_time, Fencode_time):
12969 (Fcurrent_time_string): Use it.
12970
8be6f318
PE
12971 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12972 * dired.c (make_time): Move to ...
12973 * editfns.c (make_time): ... here.
12974 * systime.h: Note the move.
12975
09d9db2c 129762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12977
126bc0dc
YM
12978 * fringe.c (update_window_fringes): Remove unused variables.
12979
c47cbdfd
YM
12980 * unexmacosx.c (copy_data_segment): Also copy __got section.
12981 (Bug#8223)
12982
7ac80be9
EZ
129832011-03-12 Eli Zaretskii <eliz@gnu.org>
12984
c96bbc66 12985 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12986 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12987 Constify `char *' arguments and their references according to
12988 prototypes in tparam.h.
12989
ecb0f94d 12990 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12991
7ac80be9
EZ
12992 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12993 Adapt all references accordingly.
12994
12995 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12996
ef1fd07e
TT
129972011-03-11 Tom Tromey <tromey@redhat.com>
12998
12999 * buffer.c (syms_of_buffer): Remove obsolete comment.
13000
7ef4b50c
EZ
130012011-03-11 Eli Zaretskii <eliz@gnu.org>
13002
13003 * termhooks.h (encode_terminal_code): Declare prototype.
13004
13005 * msdos.c (encode_terminal_code): Don't declare prototype.
13006
13007 * term.c (encode_terminal_code): Now external again, used by
13008 w32console.c and msdos.c.
13009
44f230aa
SM
13010 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13011 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13012
4b1ec863 130132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13014
1714f52b 13015 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13016
4b1ec863
PE
13017 * fringe.c (update_window_fringes): Mark locals as initialized
13018 (Bug#8227).
13019 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13020
524c7aa6
PE
13021 * alloc.c (mark_fringe_data): Move decl from here ...
13022 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13023 to check its interface.
13024 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13025
a5c0af81 13026 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13027 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13028 (fontset_font): Mark local as initialized.
a9a06e0b 13029 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13030
b4716021
PE
13031 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13032
811e9bac 13033 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13034 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13035 (x_own_selection, Fx_disown_selection_internal): Rename locals
13036 to avoid shadowing.
13037 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13038
7e3ab302
PE
13039 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13040 so that the caller can use some name other than gcpro1.
13041 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13042 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13043 (Fx_backspace_delete_keys_p):
13044 Use them to avoid shadowing, and rename vars to avoid shadowing.
13045 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13046 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13047 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13048 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13049 Remove unused locals.
7e3ab302
PE
13050 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13051 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13052 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13053 macros.
f78faa98 13054
e2b13473
PE
13055 * xterm.h (x_mouse_leave): New decl.
13056
77f23912
PE
13057 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13058 Remove unused functions.
cdf4ba58
PE
13059 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13060 (x_calc_absolute_position): Now static.
7411c686 13061 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13062 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13063 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13064 unless they are used.
38d0b34a
PE
13065 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13066 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13067 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13068 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13069 (x_error_catcher, x_connection_closed, x_error_handler):
13070 (x_error_quitter, xembed_send_message, x_iconify_frame):
13071 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13072 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13073 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13074
44f230aa
SM
13075 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13076 Rename or move locals to avoid shadowing.
6b463e58 13077 (tty_defined_color, merge_face_heights): Now static.
5967d051 13078 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13079 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13080 does not deduce is never used uninitialized.
73719eba
PE
13081 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13082 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13083
426994c3 13084 * terminal.c (store_terminal_param): Now static.
5489860b 13085
032f1620 13086 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13087 (set_frame_menubar): Remove unused local.
d4323972 13088 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13089 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13090 since they might point to immutable storage.
281585b0
PE
13091 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13092 since it's unused otherwise.
032f1620 13093
367c19e5 13094 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13095 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13096 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13097 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13098 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13099 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13100 does not deduce are never used uninitialized.
70739cbe 13101
07b48fa9
PE
13102 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13103
8868a238 13104 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13105 * window.c (window_loop, size_window):
13106 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13107
7e5cf297 13108 * window.c (display_buffer): Now static.
d6550a9f
PE
13109 (size_window): Mark variables that gcc -Wuninitialized
13110 does not deduce are never used uninitialized.
a586633d
PE
13111 * window.h (check_all_windows): New decl, to forestall
13112 gcc -Wmissing-prototypes diagnostic.
5b555da1 13113 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13114
f6095868
PE
13115 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13116 shadowing.
13117 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13118 Include <limits.h>.
13119 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13120 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13121 (load_charset_map): Mark variables that gcc -Wuninitialized
13122 does not deduce are never used uninitialized.
53df7c11 13123 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13124
f38b440c
PE
13125 * coding.c (coding_set_source, coding_set_destination):
13126 Use "else { /* comment */ }" rather than "else /* comment */;"
13127 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13128 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13129 a block, when the outer 'i' will do.
13130 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13131 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13132 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13133 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13134 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13135 Rename locals to avoid shadowing.
13136 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13137 * coding.c (emacs_mule_char, encode_invocation_designation):
13138 Now static, since they're not used elsewhere.
413bb2db 13139 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13140 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13141 (decode_coding_emacs_mule): Mark variables that gcc
13142 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13143 (detect_coding_iso_2022): Initialize a local variable that might
13144 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13145 this initialization is needed. (Bug#8211)
5f58e762
PE
13146 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13147 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13148 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13149 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13150 Remove unused macros.
f38b440c 13151
232b38b9 13152 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13153 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13154 * character.c (string_count_byte8): Likewise.
232b38b9 13155
fb90da1b
PE
13156 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13157 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13158
fb93dbc2
PE
13159 * chartab.c (copy_sub_char_table): Now static, since it's not used
13160 elsewhere.
5c156ace
PE
13161 (sub_char_table_ref_and_range, char_table_ref_and_range):
13162 Rename locals to avoid shadowing.
bbcd0949 13163 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13164
7d3b3862 13165 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13166 (BIDI_BOB): Remove unused macro.
7d3b3862 13167
6be7d3da
PE
13168 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13169 deduce are never used uninitialized.
c2ed9c8b 13170 * term.c (encode_terminal_code): Likewise.
6be7d3da 13171
75f8807f 13172 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13173
50938595
PE
13174 * tparam.h: New file.
13175 * term.c, tparam.h: Include it.
13176 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13177 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13178 Move these decls to tparam.h, and make them agree with what
13179 is actually in tparam.c. The previous trick of using incompatible
13180 decls in different modules does not conform to the C standard.
13181 All callers of tparam changed to use tparam's actual API.
13182 * tparam.c (tparam1, tparam, tgoto):
13183 Use const pointers where appropriate.
13184
fbceeba2
PE
13185 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13186 * cm.h (struct cm): Likewise.
13187 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13188 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13189 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13190 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13191 (turn_on_face, init_tty): Likewise.
13192 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13193
7f3f1250
PE
13194 * term.c (term_mouse_position): Rename local to avoid shadowing.
13195
e6ca6543
PE
13196 * alloc.c (mark_ttys): Move decl from here ...
13197 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13198
c40f8d15
AS
131992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13200
13201 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13202
cfe0661d
JB
132032011-03-09 Juanma Barranquero <lekktu@gmail.com>
13204
13205 * search.c (compile_pattern_1): Remove argument regp, unused since
13206 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13207 (compile_pattern): Don't pass it.
13208
0afb4571
J
132092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13210
13211 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13212 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13213 for ! HAVE_GTK3.
13214 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13215
13216 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13217
13218 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13219 gdk_window_get_screen, gdk_window_get_geometry,
13220 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13221 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13222 (xg_get_pixbuf_from_pixmap): New function.
13223 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13224 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13225 Call xg_get_pixbuf_from_pixmap instead of
13226 gdk_pixbuf_get_from_drawable.
13227 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13228 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13229 (xg_check_special_colors): Use GtkStyleContext and its functions
13230 for HAVE_GTK3.
13231 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13232 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13233 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13234 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13235 Call gtk_widget_get_preferred_size.
0afb4571
J
13236 (xg_frame_resized): gdk_window_get_geometry only takes 5
13237 parameters.
44f230aa
SM
13238 (xg_win_to_widget, xg_event_is_for_menubar):
13239 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13240 (xg_set_widget_bg): New function.
13241 (delete_cb): New function.
895009e1 13242 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13243 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13244 (xg_set_background_color): Call xg_set_widget_bg.
13245 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13246 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13247 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13248 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13249 if ! HAVE_GTK3.
13250 (update_frame_tool_bar): Call gtk_widget_hide.
13251 (xg_initialize): Use GDK_KEY_g.
13252
13253 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13254 if ! HAVE_GTK3
13255 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13256
13257 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13258 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13259 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13260
1c2cc4ef
JB
132612011-03-08 Juanma Barranquero <lekktu@gmail.com>
13262
13263 * w32xfns.c (select_palette): Check success of RealizePalette against
13264 GDI_ERROR, not zero.
13265
33383987 13266See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13267
13268;; Local Variables:
13269;; coding: utf-8
aac0c6e3
MR
13270;; End:
13271
2f097256 13272 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13273
13274 This file is part of GNU Emacs.
13275
13276 GNU Emacs is free software: you can redistribute it and/or modify
13277 it under the terms of the GNU General Public License as published by
13278 the Free Software Foundation, either version 3 of the License, or
13279 (at your option) any later version.
13280
13281 GNU Emacs is distributed in the hope that it will be useful,
13282 but WITHOUT ANY WARRANTY; without even the implied warranty of
13283 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13284 GNU General Public License for more details.
13285
13286 You should have received a copy of the GNU General Public License
13287 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.