Revert last change in bidi.c.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4446092a
EZ
12012-05-26 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (bidi_mirror_char): Revert last change: an int is
4 definitely wide enough here.
5
42b2a986 62012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 7
42b2a986 8 Fix integer width and related bugs (Bug#9874).
eb106a49 9 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
10 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
11 (string_bytes, check_sblock, allocate_string_data):
12 (compact_small_strings, Fmake_bool_vector, make_string)
13 (make_unibyte_string, make_multibyte_string)
14 (make_string_from_bytes, make_specified_string)
15 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
16 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
17 (mark_vectorlike):
18 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
19 (allocate_pseudovector):
20 Use int, not EMACS_INT, where int is wide enough.
21 (inhibit_garbage_collection, Fgarbage_collect):
22 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
23 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
24 int might not be wide enough.
25 (bidi_cache_search, bidi_cache_find, bidi_init_it)
26 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
27 (bidi_at_paragraph_end, bidi_find_paragraph_start)
28 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
29 (bidi_level_of_next_char, bidi_move_to_visually_next):
30 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
31 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
32 (Fkill_buffer, Fset_buffer_major_mode)
33 (advance_to_char_boundary, Fbuffer_swap_text)
34 (Fset_buffer_multibyte, overlays_at, overlays_in)
35 (overlay_touches_p, struct sortvec, record_overlay_string)
36 (overlay_strings, recenter_overlay_lists)
37 (adjust_overlays_for_insert, adjust_overlays_for_delete)
38 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
39 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
40 (Foverlay_recenter, last_overlay_modification_hooks_used)
41 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
42 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
43 (validate_region): Omit unnecessary test for b <= e,
44 since that's guaranteed by the previous test.
d311d28c
PE
45 (adjust_overlays_for_delete): Avoid pos + length overflow.
46 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
47 (report_overlay_modification):
48 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
49 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
50 Omit pointer cast, which isn't needed anyway, and doesn't work
51 after the EMACS_INT -> ptrdiff_t change.
02481186 52 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 109 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 117 Don't assume fixnum fits in int.
d311d28c
PE
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
c96e5d6a 146 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 153 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
154 (ASSURE_DESTINATION, coding_alloc_by_realloc)
155 (coding_alloc_by_making_gap, alloc_destination)
156 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
157 (encode_coding_utf_16, detect_coding_emacs_mule)
158 (decode_coding_emacs_mule, encode_coding_emacs_mule)
159 (detect_coding_iso_2022, decode_coding_iso_2022)
160 (encode_invocation_designation, encode_designation_at_bol)
161 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
162 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
163 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
164 (encode_coding_ccl, encode_coding_raw_text)
165 (detect_coding_charset, decode_coding_charset)
166 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
167 (produce_composition, produce_charset, produce_annotation)
168 (decode_coding, handle_composition_annotation)
169 (handle_charset_annotation, consume_chars, decode_coding_gap)
170 (decode_coding_object, encode_coding_object, detect_coding_system)
171 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
172 (code_convert_region, code_convert_string)
8f50130c
PE
173 (Fdefine_coding_system_internal)
174 (coding_set_source, coding_set_destination):
d311d28c
PE
175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
176 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
177 (Fdefine_coding_system_internal):
178 Don't assume fixnums fit in int.
179 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 180 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
181 (Funencodable_char_position, Fcheck_coding_systems_region)
182 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 184 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 185 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 186 Don't access memory outside of the args array.
d311d28c 187 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
188 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
189 result of ENCODE_CHAR.
d311d28c
PE
190 * coding.h: Adjust decls to match defn changes elsewhere.
191 (struct coding_system):
192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
193 * composite.c (get_composition_id, find_composition)
194 (run_composition_function, update_compositions)
195 (compose_text, composition_gstring_put_cache)
196 (composition_gstring_p, composition_gstring_width)
197 (fill_gstring_header, fill_gstring_body, autocmp_chars)
198 (composition_compute_stop_pos, composition_reseat_it)
199 (composition_update_it, struct position_record)
200 (find_automatic_composition, composition_adjust_point)
201 (Fcomposition_get_gstring, Ffind_composition_internal):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 (update_compositions):
204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
205 * composite.h: Adjust decls to match defn changes elsewhere.
206 (struct composition):
207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
208 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
209 Do not attempt to compute the address of the object just before a
210 buffer; this is not portable.
211 (Faref, Faset):
212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
213 (Faset): Use int, not EMACS_INT, where int is wide enough.
214 (Fstring_to_number): Don't assume fixnums fit in int.
215 (Frem): Don't assume arg is nonnegative.
216 * dbusbind.c (xd_append_arg): Check for integers out of range.
217 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 218 (extract_signed, extract_unsigned): New functions.
243e0530
PE
219 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
220 (xd_get_connection_references): Return ptrdiff_t, not int.
221 All uses changed.
222 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
223 (xd_read_message_1):
224 Use int, not unsigned, where the dbus API uses int.
225 (Fdbus_message_internal): Don't overflow mtype.
226 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
227 * dired.c (directory_files_internal, file_name_completion, scmp)
228 (file_name_completion_stat):
229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
230 (file_name_completion): Don't overflow matchcount.
231 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
232 * dispextern.h: Adjust decls to match defn changes elsewhere.
233 (struct text_pos, struct glyph, struct bidi_saved_info)
234 (struct bidi_string_data, struct bidi_it, struct composition_it)
235 (struct it):
236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
237 (struct display_pos, struct composition_it, struct it):
238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
239 * dispnew.c (increment_matrix_positions)
240 (increment_row_positions, mode_line_string)
241 (marginal_area_string):
242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 243 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
245 (duration_to_sec_usec): New function, to check for overflow better.
246 (Fsleep_for, sit_for): Use it.
247 * doc.c (get_doc_string, store_function_docstring):
248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
249 (get_doc_string, Fsnarf_documentation):
250 Use int, not EMACS_INT, where int is wide enough.
251 (get_doc_string):
252 Use SAFE_ALLOCA, not alloca.
253 Check for overflow when converting EMACS_INT to off_t.
254 * doprnt.c (doprnt):
255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
256 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
257 Don't assume uid_t fits into fixnum.
258 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
259 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
260 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
261 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
262 (general_insert_function)
263 (Finsert_char, make_buffer_string, make_buffer_string_both)
264 (update_buffer_properties, Fbuffer_substring)
265 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
266 (Fsubst_char_in_region, check_translation)
267 (Ftranslate_region_internal, save_restriction_restore, Fformat)
268 (transpose_markers, Ftranspose_regions):
269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
270 (clip_to_bounds): Move to lisp.h as an inline function).
271 (Fconstrain_to_field): Don't assume integers are nonnegative.
272 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
273 (Fsubst_char_in_region, Fsave_restriction):
274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
275 (Femacs_pid): Don't assume pid_t fits into fixnum.
276 (lo_time): Use int, not EMACS_INT, when int suffices.
277 (lisp_time_argument): Check for usec out of range.
278 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
279 (Fuser_login_name, Fuser_full_name): Signal an error
280 if a uid argument is out of range, rather than relying on
281 undefined behavior.
c8d5c857
PE
282 (Fformat_time_string): Remove now-unnecessary check.
283 lisp_time_argument checks for out-of-range usec now.
243e0530 284 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
285 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
286 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
287 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
288 (init_cmdargs, Fdump_emacs):
289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
290 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
291 the bottom (typically) 32 bits of the fixnum.
292 * eval.c (specpdl_size, call_debugger):
293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
294 (when_entered_debugger, Fbacktrace_debug):
295 Don't assume fixnum can fit in int.
296 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
297 the object just before a buffer; this is not portable.
298 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
299 (grow_specpdl, unbind_to):
300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
301 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
302 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 303 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
304 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
305 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
307 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
308 (a_write, e_write):
309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
310 (Fcopy_file, non_regular_nbytes, read_non_regular)
311 (Finsert_file_contents):
312 Use int, not EMACS_INT, where int is wide enough.
313 (READ_BUF_SIZE): Verify that it fits in int.
314 (Finsert_file_contents): Check that counts are in proper range,
315 rather than assuming fixnums fit into ptrdiff_t etc.
316 Don't assume fixnums fit into int.
125b3835 317 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
318 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
319 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
320 (string_char_to_byte, string_byte_to_char)
321 (string_make_multibyte, string_to_multibyte)
322 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
323 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
324 (substring_both, Fdelete, internal_equal, Ffillarray)
325 (Fclear_string, mapcar1)
326 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
327 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
328 (larger_vector, make_hash_table, maybe_resize_hash_table)
329 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
330 (Fmaphash, secure_hash):
331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
332 (concat): Check for string index and length overflow.
333 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
334 (Frequire):
335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
336 (larger_vector): New API (vec, incr_min, size_max) replaces old
337 one (vec, new_size, init). This catches size overflow.
338 INIT was removed because it was always Qnil.
339 All callers changed.
340 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
341 the upper bound on a hash table index size.
342 (make_hash_table, maybe_resize_hash_table): Use it.
343 (secure_hash): Computer start_byte and end_byte only after
344 they're known to be in ptrdiff_t range.
345 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
346 (Ffont_get_glyphs, Ffont_at):
347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
348 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
349 (Flist_fonts, Fopen_font):
350 Don't assume fixnum can fit in int.
351 (check_gstring): Don't assume index can fit in int.
352 (font_match_p): Check that fixnum is a character, not a nonnegative
353 fixnum, since the later code needs to stuff it into an int.
354 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
355 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
356 conversion overflow issues.
357 (Fopen_font): Check for integer out of range.
358 (Ffont_get_glyphs): Don't assume index can fit in int.
359 * font.h: Adjust decls to match defn changes elsewhere.
360 * fontset.c (reorder_font_vector): Redo score calculation to avoid
361 integer overflow.
362 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
363 printmax_t, where ptrdiff_t is wide enough.
364 (Finternal_char_font):
365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
366 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
367 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
368 (Fset_frame_position, x_set_frame_parameters)
369 (x_set_line_spacing, x_set_border_width)
370 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
371 Check that fixnums are in proper range for system types.
372 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
375 Use SAFE_ALLOCA_LISP, not alloca.
376 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
377 intptr_t is wide enough.
378 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
379 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
380 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
381 Check for fixnum out of range.
382 * ftfont.c (ftfont_list): Don't assume index fits in int.
383 Check that fixnums are in proper range for system types.
384 (ftfont_shape_by_flt):
385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
386 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
389 Check that fixnums are in proper range for system types.
390 * gnutls.h: Adjust decls to match defn changes elsewhere.
391 * gtkutil.c (xg_dialog_run):
392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
393 (update_frame_tool_bar):
394 Check that fixnums are in proper range for system types.
395 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 396 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
397 * indent.c (last_known_column, last_known_column_point):
398 (current_column_bol_cache):
399 (skip_invisible, current_column, check_display_width):
400 (check_display_width, scan_for_column, current_column_1)
401 (Findent_to, Fcurrent_indentation, position_indentation)
402 (indented_beyond_p, Fmove_to_column, compute_motion):
403 (Fcompute_motion, Fvertical_motion):
404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
405 (last_known_column_modified): Use EMACS_INT, not int.
406 (check_display_width):
407 (Fcompute_motion):
408 Check that fixnums and floats are in proper range for system types.
409 (compute_motion): Don't assume index or fixnum fits in int.
410 (compute_motion, Fcompute_motion):
411 Use int, not EMACS_INT, when it is wide enough.
412 (vmotion): Omit local var start_hpos that is always 0; that way
413 we don't need to worry about overflow in expressions involving it.
414 * indent.h: Adjust decls to match defn changes elsewhere.
415 (struct position):
416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
417 Use int, not EMACS_INT, where int is wide enough.
418 Remove unused members ovstring_chars_done and tab_offset;
419 all uses removed.
420 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
421 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
422 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
423 (make_gap, copy_text, insert, insert_and_inherit)
424 (insert_before_markers, insert_before_markers_and_inherit)
425 (insert_1, count_combining_before, count_combining_after)
426 (insert_1_both, insert_from_string)
427 (insert_from_string_before_markers, insert_from_string_1)
428 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
429 (adjust_after_replace, adjust_after_insert, replace_range)
430 (replace_range_2, del_range, del_range_1, del_range_byte)
431 (del_range_both, del_range_2, modify_region)
432 (prepare_to_modify_buffer, signal_before_change)
433 (signal_after_change, Fcombine_after_change_execute):
434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
435 * intervals.c (traverse_intervals, rotate_right, rotate_left)
436 (balance_an_interval, split_interval_right, split_interval_left)
437 (find_interval, next_interval, update_interval)
438 (adjust_intervals_for_insertion, delete_node, delete_interval)
439 (interval_deletion_adjustment, adjust_intervals_for_deletion)
440 (static_offset_intervals, offset_intervals)
441 (merge_interval_right, merge_interval_left, make_new_interval)
442 (graft_intervals_into_buffer, temp_set_point_both)
443 (temp_set_point, set_point, adjust_for_invis_intang)
444 (set_point_both, move_if_not_intangible, get_property_and_range)
445 (get_local_map, copy_intervals, copy_intervals_to_string)
446 (compare_string_intervals, set_intervals_multibyte_1):
447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
448 * intervals.h: Adjust decls to match defn changes elsewhere.
449 (struct interval):
450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
451 * keyboard.c (this_command_key_count, this_single_command_key_start)
452 (before_command_key_count, before_command_echo_length, echo_now)
453 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
454 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
455 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
456 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
458 (last_non_minibuf_size, last_point_position, echo_truncate)
459 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
460 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
461 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
462 (stuff_buffered_input):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (last_auto_save, command_loop_1, read_char):
465 Use EMACS_INT, not int, to avoid integer overflow.
466 (record_char): Avoid overflow in total_keys computation.
467 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
468 * keyboard.h: Adjust decls to match defn changes elsewhere.
469 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
470 (Fkey_description, Fdescribe_vector, Flookup_key):
471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
472 (click_position): New function, to check that positions are in range.
473 (Fcurrent_active_maps):
474 (describe_command):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (Faccessible_keymaps, Fkey_description):
477 (preferred_sequence_p):
478 Don't assume fixnum can fit into int.
479 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
480 Check for integer overflow in size calculations.
481 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
482 avoid mishandling large integers.
483 * lisp.h: Adjust decls to match defn changes elsewhere.
484 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
485 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
486 (struct Lisp_Marker):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
489 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
490 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
491 All callers changed.
492 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
493 Assume the arg has valid form, since it always does.
494 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
495 unsigned integer system type.
496 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
497 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
499 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
500 (duration_to_sec_usec): New decl.
501 * lread.c (read_from_string_index, read_from_string_index_byte)
502 (read_from_string_limit, readchar, unreadchar, openp)
503 (read_internal_start, read1, oblookup):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (Fload, readevalloop, Feval_buffer, Feval_region):
506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
507 (openp): Check for out-of-range argument to 'access'.
508 (read1): Use int, not EMACS_INT, where int is wide enough.
509 Don't assume fixnum fits into int.
6efdadfd 510 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
511 (read_filtered_event): Use duration_to_sec_usec
512 to do proper overflow checking on durations.
d311d28c
PE
513 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
514 in size calculation.
515 (Fexecute_kbd_macro):
516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
517 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
518 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
519 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
520 (set_marker_both, set_marker_restricted_both, marker_position)
521 (marker_byte_position, Fbuffer_has_markers_at):
522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
523 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
524 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
525 It now merely ensures that the menu is large enough, without
526 necessarily growing it, as this avoids some integer overflow issues.
527 All callers changed.
528 (keymap_panes, parse_single_submenu, Fx_popup_menu):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
531 Use SAFE_ALLOCA_LISP, not alloca.
532 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
533 to EMACS_INT. Check that fixnums are in proper range for system types.
534 * minibuf.c (minibuf_prompt_width, string_to_object)
535 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
536 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
538 (get_minibuffer, read_minibuf_unwind):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
541 this simplifies overflow checking. All callers changed.
542 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
543 (Ftest_completion):
544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
545 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
546 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
547 Check that fixnums are in proper range for system types.
548 (Fx_create_frame, Fx_show_tip):
549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
550 * nsfont.m (ns_findfonts, nsfont_list_family):
551 Don't assume fixnum fits in long.
552 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
554 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
555 wide enough.
17fdb222 556 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
558 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
559 (PRINTDECLARE, PRINTPREPARE):
560 (strout, print_string):
561 (print, print_preprocess, print_check_string_charset_prop)
562 (print_object):
563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
564 (PRINTDECLARE):
565 (temp_output_buffer_setup, Fprin1_to_string, print_object):
566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
567 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 568 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 569 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
570 (print_error_message): Use SAFE_ALLOCA, not alloca.
571 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
572 (print_depth, new_backquote_output, print_number_index):
573 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
574 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
575 (Fset_process_window_size, Fformat_network_address)
576 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 577 (sigchld_handler):
d311d28c 578 Check that fixnums are in proper range for system types.
d44287d4 579 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
580 Check for process-ids out of pid_t range rather than relying on
581 undefined behavior.
e4d81efc 582 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
583 (Fformat_network_address, read_process_output, send_process)
584 (Fprocess_send_region, status_notify):
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
587 (wait_reading_process_output, read_process_output, exec_sentinel):
588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
589 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
590 (Faccept_process_output): Use duration_to_sec_usec to do proper
591 overflow checking on durations.
dde14581
PE
592 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
593 Don't assume pid_t fits in int.
02481186
PE
594 * process.h (struct Lisp_Process): Members tick and update_tick
595 are now of type EMACS_INT, not int.
b62b53e8
PE
596 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
597 configured --with-wide-int.
d311d28c
PE
598 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
599 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
600 * search.c (looking_at_1, string_match_1):
601 (fast_string_match, fast_c_string_match_ignore_case)
602 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
603 (scan_newline, find_before_next_newline, search_command)
604 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
605 (set_search_regs, wordify):
606 (Freplace_match):
607 (Fmatch_data):
608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
609 (string_match_1, search_buffer, set_search_regs):
610 (Fmatch_data):
611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
612 (wordify): Check for overflow in size calculation.
613 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
614 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
615 Check that fixnums are in proper range for system types.
616 * sound.c (struct sound_device)
617 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
619 (Fplay_sound_internal):
620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 621 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
622 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
623 (Fparse_partial_sexp):
624 Don't assume fixnums can fit in int.
625 (struct lisp_parse_state, find_start_pos, find_start_value)
626 (find_start_value_byte, find_start_begv)
627 (update_syntax_table, char_quoted, dec_bytepos)
628 (find_defun_start, prev_char_comend_first, back_comment):
629 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
630 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (Finternal_describe_syntax_value): Check that match_lisp is a
633 character, not an integer, since the code stuffs it into int.
634 (scan_words, scan_sexps_forward):
635 Check that fixnums are in proper range for system types.
636 (Fforward_word):
637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
638 (scan_sexps_forward):
639 Use CHARACTERP, not INTEGERP, since the value must fit into int.
640 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
641 * syntax.h: Adjust decls to match defn changes elsewhere.
642 (struct gl_state_s):
643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
644 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
645 MOST_POSITIVE_FIXNUM.
d311d28c
PE
646 * sysdep.c (wait_for_termination_1, wait_for_termination)
647 (interruptible_wait_for_termination, mkdir):
648 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
649 (emacs_read, emacs_write):
650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
651 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
652 and double all fit in int.
d311d28c
PE
653 * term.c (set_tty_color_mode):
654 Check that fixnums are in proper range for system types.
655 * termhooks.h (struct input_event):
656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
657 * textprop.c (validate_interval_range, interval_of)
658 (Fadd_text_properties, set_text_properties_1)
659 (Fremove_text_properties, Fremove_list_of_text_properties)
660 (Ftext_property_any, Ftext_property_not_all)
661 (copy_text_properties, text_property_list, extend_property_ranges)
662 (verify_interval_modification):
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 (Fnext_single_char_property_change)
665 (Fprevious_single_char_property_change):
666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
667 (copy_text_properties):
668 Check for integer overflow in index calculation.
d311d28c
PE
669 * undo.c (last_boundary_position, record_point, record_insert)
670 (record_delete, record_marker_adjustment, record_change)
671 (record_property_change):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
673 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
675 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
676 (Fx_hide_tip, Fx_file_dialog):
677 * w32menu.c (set_frame_menubar):
678 Use ptrdiff_t, not int, for consistency with rest of code.
679 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
680 (select_window, Fdelete_other_windows_internal)
681 (window_scroll_pixel_based, window_scroll_line_based)
682 (Frecenter, Fset_window_configuration):
683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
684 (Fset_window_hscroll, run_window_configuration_change_hook)
685 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 686 (Fscroll_other_window, Frecenter):
d311d28c
PE
687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
688 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
689 Don't assume fixnum fits in int.
690 (Fset_window_scroll_bars):
691 Check that fixnums are in proper range for system types.
692 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
693 (string_pos, c_string_pos, number_of_chars, init_iterator)
694 (in_ellipses_for_invisible_text_p, init_from_display_pos)
695 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
696 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
697 (face_before_or_after_it_pos, handle_invisible_prop)
698 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
699 (display_prop_intangible_p, string_buffer_position_lim)
700 (string_buffer_position, handle_composition_prop, load_overlay_strings)
701 (get_overlay_strings_1, get_overlay_strings)
702 (iterate_out_of_display_property, forward_to_next_line_start)
703 (back_to_previous_visible_line_start, reseat, reseat_to_string)
704 (get_next_display_element, set_iterator_to_next)
705 (get_visually_first_element, compute_stop_pos_backwards)
706 (handle_stop_backwards, next_element_from_buffer)
707 (move_it_in_display_line_to, move_it_in_display_line)
708 (move_it_to, move_it_vertically_backward, move_it_by_lines)
709 (add_to_log, message_dolog, message_log_check_duplicate)
710 (message2, message2_nolog, message3, message3_nolog
711 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
712 (current_message_1, truncate_echo_area, truncate_message_1)
713 (set_message, set_message_1, store_mode_line_noprop)
714 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
715 (text_outside_line_unchanged_p, check_point_in_composition)
716 (reconsider_clip_changes)
717 (redisplay_internal, set_cursor_from_row, try_scrolling)
718 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
719 (redisplay_window, find_last_unchanged_at_beg_row)
720 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
721 (trailing_whitespace_p, find_row_edges, display_line)
722 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
723 (display_mode_element, store_mode_line_string)
724 (pint2str, pint2hrstr, decode_mode_spec)
725 (display_count_lines, display_string, draw_glyphs)
726 (x_produce_glyphs, x_insert_glyphs)
727 (rows_from_pos_range, mouse_face_from_buffer_pos)
728 (fast_find_string_pos, mouse_face_from_string_pos)
729 (note_mode_line_or_margin_highlight, note_mouse_highlight):
730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
731 (safe_call, init_from_display_pos, handle_fontified_prop)
732 (handle_single_display_spec, load_overlay_strings)
733 (with_echo_area_buffer, setup_echo_area_for_printing)
734 (display_echo_area, echo_area_display)
735 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
736 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
737 (redisplay_window, dump_glyph_row, display_mode_line)
738 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 739 (handle_display_spec, display_prop_string_p):
d311d28c
PE
740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
741 (handle_single_display_spec, build_desired_tool_bar_string)
742 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
743 (get_specified_cursor_type):
744 Check that fixnums are in proper range for system types.
745 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
746 (Flookup_image_map):
747 Don't assume fixnums fit in int.
748 (compare_overlay_entries):
749 Avoid mishandling comparisons due to subtraction overflow.
750 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
751 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
752 (handle_tool_bar_click):
753 Use int, not unsigned, since we prefer signed and the signedness
754 doesn't matter here.
755 (get_next_display_element, next_element_from_display_vector):
756 Use int, not EMACS_INT, when int is wide enough.
757 (start_hourglass): Use duration_to_sec_usec to do proper
758 overflow checking on durations.
759 * xfaces.c (Fbitmap_spec_p):
760 Check that fixnums are in proper range for system types.
761 (compare_fonts_by_sort_order):
762 Avoid mishandling comparisons due to subtraction overflow.
763 (Fx_family_fonts, realize_basic_faces):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
765 (Fx_family_fonts):
766 Don't assume fixnum fits in int.
767 Use SAFE_ALLOCA_LISP, not alloca.
768 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
769 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
770 (face_at_buffer_position, face_for_overlay_string)
771 (face_at_string_position):
772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
773 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
774 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
775 (Fx_show_tip):
776 Check that fixnums are in proper range for system types.
777 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
778 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
780 (Fx_change_window_property): Don't assume fixnums fit in int.
781 * xfont.c (xfont_chars_supported):
782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
783 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
784 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
786 * xml.c (parse_region):
787 * xrdb.c (magic_file_p):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
790 (x_get_local_selection, x_reply_selection_request)
791 (x_handle_selection_request, wait_for_property_change):
792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
793 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
794 short is wide enough.
795 (x_send_client_event): Don't assume fixnum fits in int.
796 * xterm.c (x_x_to_emacs_modifiers):
797 Don't assume EMACS_INT overflows nicely into int.
798 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
799 may come from Lisp.
800 (handle_one_xevent): NATNUMP can eval its arg twice.
801 (x_connection_closed):
802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
803 * xterm.h: Adjust decls to match defn changes elsewhere.
804 (struct scroll_bar): Use struct vectorlike_header
805 rather than rolling our own approximation.
806 (SCROLL_BAR_VEC_SIZE): Remove; not used.
807
c6574eb5
GM
8082012-05-25 Glenn Morris <rgm@gnu.org>
809
810 * lisp.mk (lisp): Update for more files being compiled now.
811
e8d32c7e
SM
8122012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
813
48def666
SM
814 * lread.c: Remove `read_pure' which makes no difference.
815 (read_pure): Remove var.
816 (unreadpure): Remove function.
817 (readevalloop): Don't call read_list with -1 flag.
818 (read1, read_vector): Don't test read_pure any more.
819 (read_list): Simplify.
820
e8d32c7e
SM
821 * fileio.c, character.h: Minor style tweaks.
822
4b2addb7
DA
8232012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
824
825 * window.h (clip_changed): Remove useless declaration.
826
584461b2
JB
8272012-05-22 Juanma Barranquero <lekktu@gmail.com>
828
829 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
830 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
831
34374650
PE
8322012-05-22 Paul Eggert <eggert@cs.ucla.edu>
833
834 Remove src/m/*.
835 This directory predates autoconf and is no longer needed nowadays.
836 Move its few remaining bits of functionality to where they're needed.
837 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
838 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
839 * m/template.h: Remove.
840 * Makefile.in (M_FILE): Remove. All uses removed.
841 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
842 * lisp.h (USE_LSB_TAG):
843 * mem-limits.h (EXCEEDS_LISP_PTR):
844 Use VAL_MAX, not VALBITS, in #if.
845 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
846 (EMACS_UINT): Define unconditionally now.
847 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
848 (BITS_PER_EMACS_INT): New constants, replacing
849 what used to be in config.h, but not useful in #if.
850 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
851 define them any more.
852 (VAL_MAX): New macro.
853 (VALMASK): Use it.
854 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
855 BITS_PER_EMACS_INT, in #if.
856 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
857 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
858 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
859 * s/ms-w32.h (DATA_START):
860 Move here from removed file m/intel386.h.
861 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
862 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
863
261cb4bb
PE
8642012-05-21 Paul Eggert <eggert@cs.ucla.edu>
865
866 Assume C89 or later.
867 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
868 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
869 (xrealloc):
870 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
871 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
872 * textprop.c, tparam.c (NULL): Remove.
873 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
874 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
875 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
876 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
877 * xterm.c (input_signal_count): Assume volatile works.
878
ff23cd9f
KB
8792012-05-21 Ken Brown <kbrown@cornell.edu>
880
881 * xgselect.c (xg_select): Fix first argument in call to 'select'
882 (bug#11508).
883
1b170bc6
KB
8842012-05-20 Ken Brown <kbrown@cornell.edu>
885
886 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 887 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 888
b2f4d39f
KB
8892012-05-19 Ken Brown <kbrown@cornell.edu>
890
891 * xfns.c (x_in_use): Remove `static' qualifier.
892 * xterm.h (x_in_use): Declare.
893 * xgselect.c: Include xterm.h.
894 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
895 and `display_arg' (bug#9754).
896
003fdae2
PE
8972012-05-19 Paul Eggert <eggert@cs.ucla.edu>
898
9232a6d9
PE
899 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
900
003fdae2
PE
901 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
902 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
903
784b56e2
EZ
9042012-05-18 Eli Zaretskii <eliz@gnu.org>
905
906 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
907
908 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
909 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
910
911 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
912 reference to image_cache->refcount.
913 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
914
a0a79cde
JL
9152012-05-17 Juri Linkov <juri@jurta.org>
916
917 * search.c (Fword_search_regexp, Fword_search_backward)
918 (Fword_search_forward, Fword_search_backward_lax)
919 (Fword_search_forward_lax): Move functions to isearch.el
920 (bug#10145, bug#11381).
921
b0572523
PE
9222012-05-16 Paul Eggert <eggert@cs.ucla.edu>
923
924 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
925
9660f5fc
SM
9262012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
927
928 * lread.c (init_obarray): Declare Qt and Qnil as special.
929
4374de83
GM
9302012-05-14 Glenn Morris <rgm@gnu.org>
931
932 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 933 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 934
dc44c39a
PE
9352012-05-14 Paul Eggert <eggert@cs.ucla.edu>
936
078c97cb
PE
937 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
938
dc44c39a
PE
939 * unexaix.c: Port to more-recent AIX compilers.
940 (report_error, report_error_1, make_hdr, copy_sym)
941 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
942 Make arguments const char *, not char *, to avoid violations of C
943 standard and to fix some AIX warnings reported by Gilles Pion.
944
e18afed7 9452012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
946
947 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
948 already have overlays loaded.
949 (handle_single_display_spec): Before returning without displaying
950 fringe bitmap, synchronize the bidi iterator with the main display
951 iterator, by calling iterate_out_of_display_property.
952 (iterate_out_of_display_property): Detect buffer iteration by
953 testing that it->string is a Lisp string.
954 (get_next_display_element): When the current object is exhausted,
955 and there's something on it->stack, call set_iterator_to_next to
956 proceed with what's on the stack, instead of returning zero.
957 (set_iterator_to_next): If called at the end of a Lisp string,
958 proceed to consider_string_end without incrementing string
959 position. Don't increment display vector index past the end of
960 the display vector. (Bug#11417)
c8fb9dc6
EZ
961 (pos_visible_p): Don't report a position visible when move_it_to
962 stopped at the last line of window, which happens to be scanned
963 backwards by the bidi iteration. (Bug#11464)
ac268e67 964
e18afed7 9652012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
966
967 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
968 and right-margin display specs even if the spec is invalid or we
969 are on a TTY, and thus unable to display on the fringes. That's
970 because the text with the property will not be displayed anyway,
971 so we need to signal to the caller that this is a "replacing"
972 display spec. This fixes display when the spec is invalid or we
973 are on a TTY.
974
e18afed7 9752012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
976
977 * unexaix.c (make_hdr): Fix typo in prototype.
978 This bug broke the build on AIX. Problem reported by Gilles Pion.
979
9d0a235a
MA
9802012-05-14 Michael Albinus <michael.albinus@gmx.de>
981
982 * keyboard.c (kbd_buffer_get_event): Read special events also in
983 batch mode. (Bug#11415)
984
9e6b06ed
GM
9852012-05-12 Glenn Morris <rgm@gnu.org>
986
987 * ns.mk: Update for ns_appbindir no longer having trailing "/".
988
c1a1d7a3
EZ
9892012-05-12 Eli Zaretskii <eliz@gnu.org>
990
991 * lisp.mk (lisp): Add newcomment.elc.
992
3fe7cdc8
GM
9932012-05-12 Glenn Morris <rgm@gnu.org>
994
995 * Makefile.in (MKDIR_P): New, set by configure.
996 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
997
53f7d2c0
PE
9982012-05-11 Paul Eggert <eggert@cs.ucla.edu>
999
1000 Remove unused function hourglass_started.
1001 * dispextern.h (hourglass_started):
1002 * w32fns.c (hourglass_started):
1003 * xdisp.c (hourglass_started): Remove.
1004
75aafb17
JB
10052012-05-10 Juanma Barranquero <lekktu@gmail.com>
1006
1007 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1008 Update dependencies.
1009
12959e8e
PE
10102012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1011
97107e2e
PE
1012 * xgselect.c (xg_select): Put maxfds+1 into a var.
1013 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1014
12959e8e
PE
1015 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1016
836d29b3
DA
10172012-05-10 Dave Abrahams <dave@boostpro.com>
1018
1019 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1020 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1021
5cb67954
MA
10222012-05-09 Michael Albinus <michael.albinus@gmx.de>
1023
1024 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1025 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1026 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1027 Initialize xd_registered_buses.
1028
3478ec45
PE
10292012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1030
b263a6b0
PE
1031 Untag more efficiently if USE_LSB_TAG.
1032 This is based on a proposal by YAMAMOTO Mitsuharu in
1033 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1034 For an admittedly artificial (nth 8000 longlist) benchmark on
1035 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1036 Emacs's overall text size by 1%.
1037 * lisp.h (XUNTAG): New macro.
1038 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1039 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1040 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1041 * eval.c (Fautoload):
1042 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1043 * frame.h (XFRAME): Use XUNTAG.
1044
3478ec45
PE
1045 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1046 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1047 Remove unportable assumptions about print widths of types like
1048 dbus_uint32_t.
1049 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1050 intptr_t when converting between pointer and integer, to avoid GCC
1051 warnings about wrong width.
1052
666b903b 10532012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1054
1055 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1056 stack for each reader_thread, instead of defaulting to 8MB
1057 determined by the linker. This avoids failures in creating
1058 subprocesses on Windows 7, see the discussion in this thread:
1059 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1060
b120cc17
JC
10612012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1062
1063 Fix up display of the *Minibuf-0* buffer in the mini window.
1064 * keyboard.c (read_char): Don't clear the echo area if there's no
1065 message to clear.
1066 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1067 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1068
9a4b36f8
MA
10692012-05-07 Michael Albinus <michael.albinus@gmx.de>
1070
1071 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1072 batch mode.
1073
e5f9458f
CY
10742012-05-06 Chong Yidong <cyd@gnu.org>
1075
1076 * lisp.mk (lisp): Update.
1077
eceeb5fc 10782012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1079
1080 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1081
71873e2b
SM
10822012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1083
1084 * data.c (PUT_ERROR): New macro.
1085 (syms_of_data): Use it. Add new error type `user-error'.
1086 * undo.c (user_error): New function.
1087 (Fprimitive_undo): Use it.
1088 * print.c (print_error_message): Adjust print style for `user-error'.
1089 * keyboard.c (user_error): New function.
1090 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1091
ab0fa4e4
PE
10922012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 Do not limit current-time-string to years 1000..9999.
1095 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1096 (Fcurrent_time_string): Support any year that is supported by the
1097 underlying localtime representation. Don't use asctime, as it
1098 has undefined behavior for years outside the range -999..9999.
1099
7ed806a7
PE
11002012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 Fix race conditions involving setenv, gmtime, localtime, asctime.
1103 Without this fix, interrupts could mess up code that uses these
1104 nonreentrant functions, since setting TZ invalidates existing
1105 tm_zone or tzname values, and since most of these functions return
1106 pointers to static storage.
1107 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1108 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1109 Grow the critical sections to include not just invoking
1110 localtime/gmtime, but also accessing these functions' results
1111 including their tm_zone values if any, and any related TZ setting.
1112 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1113 so that the struct tm is saved in the critical section.
1114 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1115 motivated by the fact that memory allocation needs to be outside
1116 the critical section.
1117
0c16dfed
DA
11182012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1119
1120 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1121 with RESET_INTERVAL.
1122
1123 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1124 Remove duplicated buffer name initialization.
1125
3f83ace8
JM
11262012-05-02 Jim Meyering <jim@meyering.net>
1127
1128 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1129
c7b8541e
JM
1130 * xfns.c (x_window): Use xstrdup (Bug#11375).
1131
90207a15 11322012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1133
1134 * xdisp.c (pos_visible_p): If already at a newline from the
1135 display string before the 'while' loop, don't walk back the glyphs
1136 from it3.glyph_row. Solves assertion violation when the display
1137 string begins with a newline (egg.el). (Bug#11367)
1138
b593d6a9
AH
11392012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1140
1141 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1142 Move to simple.el.
1143
4737362e
GM
11442012-05-01 Glenn Morris <rgm@gnu.org>
1145
99cf43f9
GM
1146 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1147 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1148 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1149 All were removed before 23.1.
1150
9311dcff
GM
1151 * dispnew.c: Remove HAVE_LIBNCURSES test;
1152 it is always true on relevant platforms.
1153
4d5c6349
GM
1154 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1155 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1156
4737362e
GM
1157 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1158
74dd3a6b
AS
11592012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1160
1161 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1162 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1163 Remove.
1164
13c379ee
PE
11652012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 Do not avoid creating empty evaporating overlays (Bug#9642).
1168 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1169 That is, do not delete an evaporating overlay if it becomes
1170 empty after its bounds are adjusted to fit within its buffer.
1171 This fix caused other problems, and I'm reverting it until we get
1172 to the bottom of them.
1173
a8e7d6d7 11742012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1175
1176 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1177
a8e7d6d7 11782012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1179
1180 * xdisp.c (pos_visible_p): If the window start position is beyond
1181 ZV, start the display from buffer beginning. Prevents assertion
1182 violation in init_iterator when the minibuffer window is scrolled
1183 via the scroll bar.
1184
1185 * window.c (window_scroll_pixel_based): Likewise.
1186
a8e7d6d7 11872012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1188
1189 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1190
a8e7d6d7 11912012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1192
1193 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1194 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1195
a8e7d6d7 11962012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1197
b593d6a9
AH
1198 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1199 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1200
1c6900d9
EZ
12012012-04-26 Eli Zaretskii <eliz@gnu.org>
1202
4c3fa1d9
EZ
1203 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1204 display element, check also the underlying string or buffer
1205 character. (Bug#11341)
1206
1c6900d9
EZ
1207 * w32menu.c: Include w32heap.h.
1208 (add_menu_item): If the call to AppendMenuW (via
1209 unicode_append_menu) fails, disable Unicode menus only if we are
1210 running on Windows 9X/Me.
1211
42bf8205
AS
12122012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1213
1214 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1215 (xgetint): Add missing shift for LSB tags.
1216
b1bac16e
MR
12172012-04-24 Martin Rudalics <rudalics@gmx.at>
1218
1219 * keyboard.c (read_char): Don't wipe echo area for select window
1220 events: These might get delayed via `mouse-autoselect-window'
1221 (Bug#11304).
1222
d69621cc
JB
12232012-04-24 Juanma Barranquero <lekktu@gmail.com>
1224
1225 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1226 manipulation of :loaded-from data.
1227
02fd101b
JB
12282012-04-23 Juanma Barranquero <lekktu@gmail.com>
1229
1230 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1231 now a cons (bug#11311).
1232
888bec30
PE
12332012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1234
89a438bd
PE
1235 Do not create empty overlays with the evaporate property (Bug#9642).
1236 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1237 if it becomes empty after its bounds are adjusted to fit within
1238 its buffer. Without this fix, in a nonempty buffer (let ((o
1239 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1240 yields an empty overlay that has the evaporate property, which is
1241 not supposed to happen.
1242
1068fe4d
PE
1243 Fix minor GTK3 problems found by static checking.
1244 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1245 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1246 (struct _EmacsFixedClass, emacs_fixed_get_type):
1247 Move decls here from emacsgtkfixed.h, since they needn't be public.
1248 (emacs_fixed_get_type): Now static.
1249 (emacs_fixed_class_init): Omit unused local.
1250 (emacs_fixed_child_type): Remove; unused.
1251 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1252 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1253 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1254 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1255 (EMACS_FIXED_GET_CLASS): Remove; unused.
1256 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1257
888bec30
PE
1258 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1259 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1260
de85e130
PE
12612012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1262
d0baac98 1263 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1264 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1265 (__malloc_size_t, __malloc_ptrdiff_t):
1266 Remove. All uses removed, replaced by the definiens if needed,
1267 since we can assume C89 or better now.
1268 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1269 (protect_malloc_state, align, get_contiguous_space)
1270 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1271 (malloc_atfork_handler_child, malloc_enable_thread)
1272 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1273 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1274 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1275 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1276 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1277 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1278 Define using prototypes, not old style.
1279 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1280 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1281 (align): Don't assume that signed integer overflow wraps around.
1282 Omit unused local var.
1283 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1284 (_free_internal_nolock, memalign, mallochook, reallochook):
1285 Omit no-longer-needed casts.
1286 (valloc): Use getpagesize, not __getpagesize.
1287 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1288 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1289
de85e130
PE
1290 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1291
dcbf5805
MA
12922012-04-22 Michael Albinus <michael.albinus@gmx.de>
1293
1294 Move functions from C to Lisp. Make non-blocking method calls
1295 the default. Implement further D-Bus standard interfaces.
1296
1297 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1298 (QCdbus_request_name_allow_replacement)
1299 (QCdbus_request_name_replace_existing)
1300 (QCdbus_request_name_do_not_queue)
1301 (QCdbus_request_name_reply_primary_owner)
1302 (QCdbus_request_name_reply_in_queue)
1303 (QCdbus_request_name_reply_exists)
1304 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1305 (QCdbus_registered_serial, QCdbus_registered_method)
1306 (QCdbus_registered_signal): New Lisp objects.
1307 (XD_DEBUG_MESSAGE): Use sizeof.
1308 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1309 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1310 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1311 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1312 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1313 (xd_signature, xd_append_arg): Allow float for integer types.
1314 (xd_get_connection_references): New function.
b593d6a9
AH
1315 (xd_get_connection_address): Rename from xd_initialize.
1316 Return cached address.
dcbf5805
MA
1317 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1318 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1319 level.
1320 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1321 Return number of refcounts.
dcbf5805
MA
1322 (Fdbus_get_unique_name): Make stronger parameter check.
1323 (Fdbus_message_internal): New defun.
1324 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1325 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1326 (Fdbus_send_signal, Fdbus_register_service)
1327 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1328 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1329 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1330 (Vdbus_compiled_version, Vdbus_runtime_version)
1331 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1332 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1333 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1334 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1335 Adapt docstring.
dcbf5805 1336
52828e02
PE
13372012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1338
da05bc4c
PE
1339 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1340 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1341 Do not assume ptrdiff_t is the same width as 'int'.
1342
52828e02
PE
1343 * alloc.c: Handle unusual debugging option combinations.
1344 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1345 since the two debugging options are incompatible.
1346 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1347 is defined.
1348 (mem_init, mem_insert, mem_insert_fixup):
1349 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1350 (NEED_MEM_INSERT): Remove; no longer needed.
1351
f01769f9
LL
13522012-04-22 Leo Liu <sdl.web@gmail.com>
1353
1354 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1355
5790543d
PE
13562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 * sysdep.c [__FreeBSD__]: Minor cleanups.
1359 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1360 Use Emacs indenting style more consistently. Avoid some casts.
1361 Use 'double' consistently rather than mixing 'float' and 'double'.
1362
b91b7e4d
EW
13632012-04-21 Eduard Wiebe <usenet@pusto.de>
1364
b593d6a9
AH
1365 * sysdep.c (list_system_processes, system_process_attributes):
1366 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1367
6114eb15
AS
13682012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1369
1370 * lisp.mk (lisp): Update.
1371
2f38dff7
PE
13722012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1373
1374 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1375 It is never used otherwise.
1376
4ae29f89
SM
13772012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1378
1379 * print.c (print_preprocess): Only check print_depth if print-circle
1380 is nil.
1381 (print_object): Check for cycles even when print-circle is nil and
1382 print-gensym is t, but only check print_depth if print-circle is nil.
1383
f30d612a
CY
13842012-04-20 Chong Yidong <cyd@gnu.org>
1385
1386 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1387 set the status to "failed" and ensure that sentinel is run.
1388
c07a4c0b 13892012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1390
1391 * process.c (Fset_process_inherit_coding_system_flag)
1392 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1393 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1394
c07a4c0b 13952012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1396
1397 * xdisp.c (string_buffer_position_lim): Limit starting position to
1398 BEGV.
1399 (set_cursor_from_row): If called for a mode-line or header-line
1400 row, return zero immediately.
1401 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1402 farther than the first row after the header line, if any.
1403 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1404 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1405
c07a4c0b 14062012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1407
4ae29f89
SM
1408 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1409 (bug#11238).
ad3a2b41 1410
c07a4c0b 14112012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 14122012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1413
1414 configure: new option --enable-gcc-warnings (Bug#11207)
1415 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1416 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1417 (ALL_CFLAGS): Use new macros rather than old.
1418 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1419 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1420 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1421 -Wunused-result, -Wunused-variable. This should go away once
1422 the Emacs and Gnulib regex code is merged.
1423 (xmalloc, xrealloc): Now static.
1424
aba027e8
PE
14252012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1426
1427 * dired.c (Fsystem_groups): Remove unused local.
1428
e5a36063
GM
14292012-04-17 Glenn Morris <rgm@gnu.org>
1430
1431 * dired.c (Fsystem_users): Doc fix.
1432
316411f0
DA
14332012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1434
1435 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1436 (syms_of_dired): Add them.
1437
9426aba4
PE
14382012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1439
b62a57be
PE
1440 Fix minor alloc.c problems found by static checking.
1441 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1442 New extern decls, to avoid calling undeclared functions.
1443 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1444 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1445 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1446 (NEED_MEM_INSERT): New macro.
1447 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1448 Remove one incorrect comment and fix another.
b62a57be 1449
3539f31f
PE
1450 Fix minor ralloc.c problems found by static checking.
1451 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1452 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1453 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1454 (r_alloc_sbrk): Now static.
1455
a041960a
PE
1456 Improve ralloc.c interface checking.
1457 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1458 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1459 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1460 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1461 [REL_ALLOC]: ... to here, to check interface.
1462 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1463 Remove decls. This fixes an "It stinks!".
1464
9426aba4
PE
1465 * alloc.c (which_symbols): Fix alignment issue / type clash.
1466
d55c12ed
AS
14672012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1468
1469 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1470 (struct Lisp_Misc_Any): Likewise.
1471 (struct Lisp_Free): Likewise.
1472 * alloc.c (union aligned_Lisp_Symbol): Define.
1473 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1474 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1475 (union aligned_Lisp_Misc): Define.
1476 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1477 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1478 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1479
b948ce8b
PE
14802012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1483 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1484 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1485 * s/netbsd.h, s/sol2-6.h:
1486 Remove definition of GC_MARK_STACK, since the default now works.
1487 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1488 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1489 no longer the default.
1490 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1491
35dc09a1 14922012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1493
35dc09a1
GM
1494 * lread.c (lisp_file_lexically_bound_p):
1495 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1496
35dc09a1
GM
14972012-04-14 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1500 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1501
15022012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1503
1504 * nsterm.m (constrainFrameRect): Always constrain when there is only
1505 one screen (Bug#10962).
1506
bcd86815
KB
15072012-04-13 Ken Brown <kbrown@cornell.edu>
1508
1509 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1510
c25df26e
RT
15112012-04-13 Reuben Thomas <rrt@sc3d.org>
1512
1513 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1514
0fc59f1e
DC
15152012-04-11 Daniel Colascione <dancol@dancol.org>
1516
1517 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1518 against is gone. It's better to use vfork now so that when Cygwin
1519 gains a new, working vfork, we use it automatically (bug#10398).
1520
de8c03dc
SM
15212012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1522
1523 * window.c (save_window_save): Obey window-point-insertion-type.
1524
2f097256
GM
15252012-04-11 Glenn Morris <rgm@gnu.org>
1526
1527 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1528
453b951e
SM
15292012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1530
1531 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1532
75f1671a 15332012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1534
1535 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1536 (force_quit_count): New var.
1537 (handle_interrupt): Use it.
1538
2a8ce227
JB
15392012-04-10 Juanma Barranquero <lekktu@gmail.com>
1540
1541 * w32.c (w32_delayed_load): Record the full path of the library
1542 being loaded (bug#10424).
1543
935396c0
GM
15442012-04-09 Glenn Morris <rgm@gnu.org>
1545
05920a43
GM
1546 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1547 not just in the obarray, before snarfing them. (Bug#11036)
1548
935396c0
GM
1549 * Makefile.in ($(leimdir)/leim-list.el):
1550 Pass EMACS rather than BUILT_EMACS.
1551
a18ecafa
TZ
15522012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1553
1554 * process.c (make_process):
1555 * process.h: Add integer `gnutls_handshakes_tried' member to
1556 process struct.
1557
6bbef4e5
JC
1558 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1559 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1560
1561 * gnutls.c (gnutls_log_function2i): Convenience log function.
1562 (emacs_gnutls_read): Use new log functions,
1563 `gnutls_handshakes_tried' process member, and
1564 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1565 attempts per process (connection).
1566
b4d3bc10
CY
15672012-04-09 Chong Yidong <cyd@gnu.org>
1568
1569 * eval.c (Fuser_variable_p, user_variable_p_eh)
1570 (lisp_indirect_variable): Functions deleted.
1571 (Fdefvar): Caller changed.
1572
1573 * callint.c (Finteractive, Fcall_interactively):
1574 * minibuf.c (Fread_variable): Callers changed.
1575
70f4d973
EZ
15762012-04-09 Eli Zaretskii <eliz@gnu.org>
1577
1578 * xdisp.c (set_cursor_from_row): If the display string appears in
1579 the buffer at position that is closer to point than the position
1580 after the display string, display the cursor on the first glyph of
1581 the display string. Fixes cursor display when a 'display' text
1582 property immediately follows invisible text. (Bug#11094)
1583
cb3c2e3e
PE
15842012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 composite.c: use 'double' consistently
1587 * composite.c (get_composition_id): Use 'double' consistently
1588 instead of converting 'float' to 'double' and vice versa; this is
1589 easier to understand and avoids a GCC warning.
1590
fd06db5d
GM
15912012-04-09 Glenn Morris <rgm@gnu.org>
1592
50fe702a
GM
1593 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1594 preparation for dumping it with emacs. (Bug#4789)
1595 (leimdir): New variable.
1596 ($(leimdir)/leim-list.el): New rule.
1597 (emacs$(EXEEXT)): Depend on leim-list.el.
1598
fd06db5d
GM
1599 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1600 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1601 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1602
55c131ee
AS
16032012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1604
1605 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1606 proper alignment.
1607
9209588f
JB
16082012-04-07 Juanma Barranquero <lekktu@gmail.com>
1609
1610 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1611 Remove unused local variable.
1612
e3fb2efb
PE
16132012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1614
1615 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1616 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1617 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1618 objects, as mark_maybe_pointer will catch them otherwise.
1619 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1620 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1621
b5385551
PE
16222012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1623
1624 Fix typo that broke non-Windows builds.
1625 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1626
9078ead6
EZ
16272012-04-07 Eli Zaretskii <eliz@gnu.org>
1628
1629 Support building on MS-Windows with libxml2.
1630
1631 * makefile.w32-in (OBJ2): Add xml.$(O).
1632 (GLOBAL_SOURCES): Add xml.c.
1633 ($(BLD)/xml.$(O)): New dependency list.
1634
1635 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1636 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1637 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1638 [!WINDOWSNT]: New macros.
1639 (init_libxml2_functions, libxml2_loaded_p): New functions.
1640 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1641 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1642 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1643 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1644 linked in).
6bbef4e5
JC
1645 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1646 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1647 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1648
1649 * emacs.c: Don't include libxml/parser.h.
1650 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1651 xmlCleanupParser directly.
1652
1653 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1654
3811fdf3
EZ
16552012-04-07 Eli Zaretskii <eliz@gnu.org>
1656
1657 * indent.c (Fvertical_motion): If there is a display string at
1658 point, use it.vpos to compute how many lines to backtrack after
1659 move_it_to point. (Bug#11133)
1660
2f8e16b2
EZ
16612012-04-06 Eli Zaretskii <eliz@gnu.org>
1662
1663 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1664 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1665 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1666 macros related to unification of CJK characters. For the details,
1667 see the discussion following the message here:
1668 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1669
3d439cd1
CY
16702012-04-04 Chong Yidong <cyd@gnu.org>
1671
1672 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1673
8bc53d00
EZ
16742012-04-01 Eli Zaretskii <eliz@gnu.org>
1675
1676 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1677 instead of alloca. (Bug#11138)
1678
3b0512a3
AS
16792012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1680
1681 * w32menu.c (is_simple_dialog): Properly check lisp types.
1682 (Bug#11141)
1683
8427ddd2
EZ
16842012-03-31 Eli Zaretskii <eliz@gnu.org>
1685
979022ef
EZ
1686 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1687 position we get to after a call to move_it_to fails the
1688 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1689 only if we wind up in a string from display property. (Bug#11063)
1690
a6b1c7cc
EZ
1691 * window.c (Fdelete_other_windows_internal): Invalidate the row
1692 and column information about mouse highlight, so that redisplay
1693 restores it after reallocating the glyph matrices. (Bug#7464)
1694
8427ddd2
EZ
1695 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1696 string comes from a `display' text property, use the buffer
1697 position of that property as if we actually saw that position in
1698 the row's glyphs.
697ba24b
EZ
1699 (move_it_by_lines): Remove the assertion that
1700 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1701 violated when there's a before-string at the beginning of a line.
1702 (Bug#11063)
8427ddd2 1703
65a0a738
EZ
17042012-03-30 Eli Zaretskii <eliz@gnu.org>
1705
1706 * xdisp.c (append_space_for_newline): If the default face was
1707 remapped, use the remapped face for the appended newline.
1708 (extend_face_to_end_of_line): Use the remapped default face for
1709 extending the face to the end of the line.
1710 (display_line): Call extend_face_to_end_of_line when the default
1711 face was remapped. (Bug#11068)
1712
581355cc
EZ
17132012-03-29 Eli Zaretskii <eliz@gnu.org>
1714
1715 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1716
e8fc049f
SM
17172012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1718
1719 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1720
4fb9a543
GM
17212012-03-27 Glenn Morris <rgm@gnu.org>
1722
1723 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1724 Doc fixes.
1725
679910f1
KH
17262012-03-26 Kenichi Handa <handa@m17n.org>
1727
1728 * dispextern.h (struct glyph): Fix previous change. Change the
1729 bit length of glyphless.ch to 25 (Bug#11082).
1730
90d49b7f
CY
17312012-03-26 Chong Yidong <cyd@gnu.org>
1732
1733 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1734 (command_loop_1): Use it; inhibit selection update for
1735 handle-select-window too (Bug#8996).
1736
f514f6f0
FP
17372012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1738
e8fc049f 1739 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1740
bf43fa51
KH
17412012-03-25 Kenichi Handa <handa@m17n.org>
1742
1743 * dispextern.h (struct glyph): Change the bit length of
1744 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1745
8a0c01dd
EZ
17462012-03-24 Eli Zaretskii <eliz@gnu.org>
1747
1748 * s/ms-w32.h (tzname): Include time.h before redirecting to
1749 _tzname. Fixes the MSVC build. (Bug#9960)
1750
7d1c3a76
AS
17512012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1752
8ed79523
AS
1753 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1754 characters.
1755
7d1c3a76
AS
1756 * xterm.c (XTread_socket): Only modify handling_signal if
1757 !SYNC_INPUT. (Bug#11080)
1758
e99a9b8b
EZ
17592012-03-23 Eli Zaretskii <eliz@gnu.org>
1760
1761 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1762 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1763 when fetching a multibyte character consumes more bytes than
1764 CHAR_BYTES returns, due to unification of CJK characters in
1765 string_char. (Bug#11073)
1766
5063c0e1
TN
17672012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1768
1769 * process.c (wait_reading_process_output): Handle pty disconnect
1770 by refraining from sending oneself a SIGCHLD (bug#10933).
1771
9f851fbd
CY
17722012-03-22 Chong Yidong <cyd@gnu.org>
1773
1774 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1775
5063c0e1 1776 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
1777 Mark string as coming from a prefix property.
1778 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1779 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1780
fb5b8aca
CY
17812012-03-21 Chong Yidong <cyd@gnu.org>
1782
1783 * xfaces.c (Vface_remapping_alist): Doc fix.
1784
62356a1b
EZ
17852012-03-20 Eli Zaretskii <eliz@gnu.org>
1786
1787 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
1788 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1789 Doc fixes.
62356a1b 1790
025de85b
CY
17912012-03-20 Chong Yidong <cyd@gnu.org>
1792
1793 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1794 to reflect default non-nil value of redisplay-dont-pause.
1795
4827f94e
KH
17962012-03-19 Kenichi Handa <handa@m17n.org>
1797
1798 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1799 it fit in a valid range (Bug#11003).
1800
e50a24a2
EZ
18012012-03-18 Eli Zaretskii <eliz@gnu.org>
1802
1803 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1804 that is not from display property, accept the row as a "cursor
1805 row" if one of the string's character has a non-nil `cursor'
1806 property. Fixes cursor positioning when there are newlines in
1807 overlay strings, e.g. in icomplete.el. (Bug#11035)
1808
9af5ed87
PE
18092012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1812
d1f55f16
CY
18132012-03-12 Chong Yidong <cyd@gnu.org>
1814
1815 * eval.c (inhibit_lisp_code): Rename from
1816 inhibit_window_configuration_change_hook; move from window.c.
1817
1818 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1819 * window.c (run_window_configuration_change_hook)
1820 (syms_of_window): Callers changed.
1821
66c5eebd
CY
18222012-03-11 Chong Yidong <cyd@gnu.org>
1823
413df973
CY
1824 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1825
66c5eebd
CY
1826 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1827
1de11f56
CY
18282012-03-10 Chong Yidong <cyd@gnu.org>
1829
1830 * frame.c (other_visible_frames): Don't assume the selected frame
1831 is visible (Bug#10955).
1832
cae07000
SM
18332012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1834
1835 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1836
89c94350
JD
18372012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1838
1839 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1840 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1841 zero (Bug#10954).
1842
999dd333
GM
18432012-03-03 Glenn Morris <rgm@gnu.org>
1844
01a6dcc8 1845 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1846
de0100f2
EZ
18472012-03-02 Eli Zaretskii <eliz@gnu.org>
1848
1849 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1850 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1851 (redisplay_window, next_element_from_string): Fix typos in
1852 comments.
3e441275
EZ
1853 (redisplay_window): Pass to move_it_vertically the margin in
1854 pixels, not in screen lines.
de0100f2 1855
96a72ee9
GM
18562012-03-02 Glenn Morris <rgm@gnu.org>
1857
1858 * buffer.c (buffer-list-update-hook): Doc fix.
1859
312508d7
EZ
18602012-02-29 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1863 push_it before setting up the iterator for the first overlay
1864 string, even if we have an empty string loaded.
1865 (next_overlay_string): If there's an empty string on the iterator
1866 stack, pop the stack. (Bug#10903)
1867
27f3c637
PE
18682012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1871 Suggested by Stefan Monnier in
1872 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1873 * alloc.c (widen_to_Lisp_Object): New static function.
1874 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1875 and widening them to Lisp_Objects. This would work even if
1876 USE_LSB_TAG is defined and wide integers are used, which might
1877 happen in a future version of Emacs.
1878
3c9dfce6
CY
18792012-02-25 Chong Yidong <cyd@gnu.org>
1880
fa74b241
CY
1881 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1882 Doc fix.
1883
3c9dfce6
CY
1884 * xselect.c (Fx_selection_exists_p): Doc fix.
1885 (x_clipboard_manager_save_all): Print an informative message
1886 before saving to clipboard manager.
1887
9486df08
CY
18882012-02-24 Chong Yidong <cyd@gnu.org>
1889
1890 * keyboard.c (process_special_events): Handle all X selection
1891 requests in kbd_buffer, not just the next one (Bug#8869).
1892
f01d3321
CY
18932012-02-23 Chong Yidong <cyd@gnu.org>
1894
1895 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1896 call when setting menu-bar-lines and tool-bar-lines parameters.
1897 (unwind_create_frame_1): New helper function.
1898
1899 * window.c (inhibit_window_configuration_change_hook): New var.
1900 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1901 (syms_of_window): Initialize it.
f01d3321 1902
86b847b6
CY
19032012-02-22 Chong Yidong <cyd@gnu.org>
1904
1905 * xterm.c (x_draw_image_relief): Add missing type check for
1906 Vtool_bar_button_margin (Bug#10743).
1907
a59225b1
CY
19082012-02-21 Chong Yidong <cyd@gnu.org>
1909
1910 * fileio.c (Vfile_name_handler_alist): Doc fix.
1911
1912 * buffer.c (Fget_file_buffer): Protect against invalid file
1913 handler return value.
1914
310f5bd4
PE
19152012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1916
cb3a28cc
PE
1917 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1918 when computing $valmask.
1919
310f5bd4
PE
1920 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1921 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1922 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1923 It's useless in that case, and it can cause problems on hosts
1924 that allocate halves of EMACS_INT values separately.
1925 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1926 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1927 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1928 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1929 it avoids undefined behavior on hosts where shifting right by more
1930 than the word width has undefined behavior.
1931
2375c96a
CY
19322012-02-19 Chong Yidong <cyd@gnu.org>
1933
1934 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1935 (Funhandled_file_name_directory, Ffile_name_as_directory)
1936 (Fdirectory_file_name, Fexpand_file_name)
1937 (Fsubstitute_in_file_name): Protect against invalid file handler
1938 return values (Bug#10845).
1939
3eb49e71
EZ
19402012-02-18 Eli Zaretskii <eliz@gnu.org>
1941
1942 * .gdbinit (pitx): Fix incorrect references to fields of the
1943 iterator stack.
1944
7b926f3f
CY
19452012-02-17 Chong Yidong <cyd@gnu.org>
1946
1947 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1948
11273115
PE
19492012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1952 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1953
c3a70e2b
CY
19542012-02-15 Chong Yidong <cyd@gnu.org>
1955
1956 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1957 marked as special. Also, starting docstrings with * is obsolete.
1958
0ca43699
AS
19592012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1960
1961 * gnutls.c (emacs_gnutls_write): Fix last change.
1962
2e8f3c56
LI
19632012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1964
1965 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1966 send_process.
1967
af70074f
SM
19682012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1969
1970 * keymap.c (Fsingle_key_description): Handle char ranges.
1971
95986d52
CY
19722012-02-12 Chong Yidong <cyd@gnu.org>
1973
afd83bd1
CY
1974 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1975 as that creates a dangerous corner case.
1976
95986d52
CY
1977 * window.c (Fdelete_window_internal): Invalidate the mouse
1978 highlight (Bug#9904).
1979
bd7da63e
GM
19802012-02-12 Glenn Morris <rgm@gnu.org>
1981
1982 * xselect.c (Fx_own_selection_internal)
1983 (Fx_get_selection_internal, Fx_disown_selection_internal)
1984 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1985 * nsselect.m (Fx_own_selection_internal)
1986 (Fx_disown_selection_internal, Fx_selection_exists_p)
1987 (Fx_selection_owner_p, Fx_get_selection_internal):
1988 Sync docs and argument specs with the xselect.c versions.
1989
77abcbc2
LI
19902012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1991
1992 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1993
90b671e2
EZ
19942012-02-11 Eli Zaretskii <eliz@gnu.org>
1995
1c0ca0b7
EZ
1996 * w32select.c (Fx_selection_exists_p): Sync doc string and
1997 argument list with xselect.c. (Bug#10783)
1998
1999 * w16select.c (Fx_selection_exists_p): Sync doc string and
2000 argument list with xselect.c. (Bug#10783)
90b671e2 2001
49241268
GM
20022012-02-10 Glenn Morris <rgm@gnu.org>
2003
2004 * fns.c (Fsecure_hash): Doc fix.
2005
f998bbe7 20062012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2007
2008 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2009
0992bd9c
CY
20102012-02-07 Chong Yidong <cyd@gnu.org>
2011
2012 * buffer.c (Fbuffer_local_variables)
2013 (buffer_lisp_local_variables): Handle unbound vars correctly;
2014 don't let Qunbound leak into Lisp.
2015
af008560
GM
20162012-02-07 Glenn Morris <rgm@gnu.org>
2017
dd605cc4
GM
2018 * image.c (Fimagemagick_types): Doc fix.
2019
af008560
GM
2020 * image.c (imagemagick-render-type): Change it from a lisp object
2021 to an integer. Move the doc here from the lisp manual.
2022 Treat all values not equal to 0 the same.
2023
1449fa1d
CY
20242012-02-06 Chong Yidong <cyd@gnu.org>
2025
2026 * doc.c (store_function_docstring): Avoid applying docstring of
2027 alias to base function (Bug#2603).
2028
3723ec07
AS
20292012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2030
2031 * .gdbinit (pp1, pv1): Remove redundant defines.
2032 (pr): Use pp.
2033
79c1cc1e
CY
20342012-02-04 Chong Yidong <cyd@gnu.org>
2035
2036 * nsterm.m: Declare a global (Bug#10694).
2037
d7f29f8e
EZ
20382012-02-04 Eli Zaretskii <eliz@gnu.org>
2039
cae07000
SM
2040 * w32.c (get_emacs_configuration_options):
2041 Include --enable-checking, if specified, in the return value.
d7f29f8e 2042
3b95a6f9
MR
20432012-02-04 Martin Rudalics <rudalics@gmx.at>
2044
2045 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2046 after rounding frame sizes. (Bug#9723)
2047
d6fa96a6
EZ
20482012-02-04 Eli Zaretskii <eliz@gnu.org>
2049
2050 * keyboard.c (adjust_point_for_property): Don't position point
2051 before BEGV. (Bug#10696)
2052
df0b2940
PE
20532012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2054
2055 Handle overflow when computing char display width (Bug#9496).
2056 * character.c (char_width): Return EMACS_INT, not int.
2057 (char_width, c_string_width): Check for overflow when
2058 computing the width; this is possible now that individual
2059 characters can have unbounded width. Problem introduced
2060 by merge from Emacs 23 on 2012-01-19.
2061
6bee44d6
MA
20622012-02-02 Michael Albinus <michael.albinus@gmx.de>
2063
2064 * dbusbind.c (Fdbus_register_method): Mention the return value
2065 :ignore in the docstring.
2066
44f92739
GM
20672012-02-02 Glenn Morris <rgm@gnu.org>
2068
1b9f60cc
GM
2069 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2070
44f92739
GM
2071 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2072 Unconditionally set to t. (Bug#10673)
2073 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2074 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2075 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2076
c5d3843c
KH
20772012-02-02 Kenichi Handa <handa@m17n.org>
2078
2079 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2080 0, do not call append_composite_glyph.
2081
159462d4 20822012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2083
2084 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2085 NULL (Bug#6988).
2086 (x_produce_glyphs): If the component of a composition is a null
2087 string, set it->pixel_width to 1 to avoid zero-width glyph.
2088
78cef877
EZ
20892012-02-01 Eli Zaretskii <eliz@gnu.org>
2090
2091 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2092 first 2 arguments are identical. This makes inserting large
2093 output from a subprocess an order of magnitude faster on
2094 MS-Windows, where all sbrk'ed memory is always contiguous.
2095
97897668
GM
20962012-01-31 Glenn Morris <rgm@gnu.org>
2097
2098 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2099 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2100 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2101
31fd3586
GM
21022012-01-29 Glenn Morris <rgm@gnu.org>
2103
2104 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2105
0e24a8b2
CY
21062012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2107
2108 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2109
cc0adcb0
CY
21102012-01-28 Chong Yidong <cyd@gnu.org>
2111
2112 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2113
acc28cb9
CY
21142012-01-26 Chong Yidong <cyd@gnu.org>
2115
9c69cfb7
CY
2116 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2117
acc28cb9
CY
2118 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2119 repeat counts (Bug#10507).
2120
48da7392
GM
21212012-01-26 Glenn Morris <rgm@gnu.org>
2122
2123 * lread.c (syms_of_lread): Doc fix.
2124
14af5f7f
CY
21252012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2126
2127 * coding.c (encode_designation_at_bol): Change return value to
2128 EMACS_INT.
2129
0b21c100
CY
21302012-01-25 Chong Yidong <cyd@gnu.org>
2131
2132 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2133
3c2907f7
CY
21342012-01-21 Chong Yidong <cyd@gnu.org>
2135
2136 * floatfns.c (Fcopysign): Make the second argument non-optional,
2137 since nil is not allowed anyway.
2138
959ad23f
AS
21392012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2140
2141 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2142 (send_process): Likewise.
2143
34a02f46
MR
21442012-01-19 Martin Rudalics <rudalics@gmx.at>
2145
2146 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2147 (Vwindow_persistent_parameters): Do not use Qstate.
2148 Rewrite doc-strings.
34a02f46 2149
1259009a 21502012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2151
2152 * character.c (char_width): New function.
70d4fdf6
GM
2153 (Fchar_width, c_string_width, lisp_string_width):
2154 Use char_width (Bug#9496).
25ed9e61 2155
6a6ee00d
MR
21562012-01-16 Martin Rudalics <rudalics@gmx.at>
2157
2158 * window.c (Vwindow_persistent_parameters): New variable.
2159 (Fset_window_configuration, save_window_save): Handle persistent
2160 window parameters.
2161
c85efaf7
EZ
21622012-01-14 Eli Zaretskii <eliz@gnu.org>
2163
2164 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2165 thrashing the stack of the thread. (Bug#9087)
2166
5944709e
PE
21672012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2168
2169 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2170
e71f5d99
EZ
21712012-01-11 Eli Zaretskii <eliz@gnu.org>
2172
2173 * xdisp.c (rows_from_pos_range): Handle the case where the
2174 highlight ends on a newline. (Bug#10464)
2175 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2176 he end column for display of highlight that ends on a newline
2177 before a R2L line.
2178
ce316182
GM
21792012-01-11 Glenn Morris <rgm@gnu.org>
2180
2181 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2182 from load-path also when installation-directory is nil. (Bug#10208)
2183
5b43da69
GM
21842012-01-10 Glenn Morris <rgm@gnu.org>
2185
74cc8ff9
GM
2186 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2187
7d8d6e4e
GM
2188 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2189 Update template values to be closer to their typical values these days.
5b43da69 2190
a0db8d43
EZ
21912012-01-09 Eli Zaretskii <eliz@gnu.org>
2192
2193 * xdisp.c (rows_from_pos_range): Accept additional argument
2194 DISP_STRING, and accept any glyph in a row whose object is that
2195 string as eligible for mouse highlight. Fixes mouse highlight of
2196 display strings from overlays. (Bug#10464)
2197
9a0115ab 21982012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2199
b9110d6a 2200 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2201 * fileio.c (auto_saving_dir_umask): New static var.
2202 (Fmake_directory_internal): Use it.
2203 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2204 creating the directory. The old code temporarily assigns
2205 too-generous permissions to the directory.
2206 (do_auto_save_eh): Clear it.
b9110d6a 2207 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2208 that the var is always cleared.
2209
6c1bd3f3
EZ
22102012-01-07 Eli Zaretskii <eliz@gnu.org>
2211
2212 * search.c (scan_buffer): Pass character positions to
2213 know_region_cache, not byte positions. (Bug#6540)
2214
069d2b50
L
22152012-01-07 LynX <_LynX@bk.ru> (tiny change)
2216
2217 * w32.c (sys_rename): Report EXDEV when rename of a directory
2218 fails because the target is on another logical disk. (Bug#10284)
2219
75bf0d33
DB
22202012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2221
2222 * xterm.c (x_embed_request_focus): New function.
2223
2224 * xterm.h: Add prototype.
2225
2226 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2227
1c6e5a32
GM
22282012-01-05 Glenn Morris <rgm@gnu.org>
2229
2230 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2231
651e947e
EZ
22322012-01-01 Eli Zaretskii <eliz@gnu.org>
2233
2234 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2235 Load gnutls_transport_set_lowat only if GnuTLS version is below
2236 2.11.1.
2237 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2238 GnuTLS versions below 2.11.1.
2239
3778cdd8
AL
22402011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2241
2242 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2243 to the doc string advising against its use for altering the way
2244 windows are scrolled.
2245
0e5317f7
KH
22462011-12-28 Kenichi Handa <handa@m17n.org>
2247
2248 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2249 coding-system ASCII compatible only when it does not produce BOM
2250 on encoding (Bug#10383).
2251
93d5ca1f
JD
22522011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2253
2254 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2255 can scroll.
2256 (create_and_show_popup_menu): Always use menu_position_func for
2257 Gtk3 (Bug#10361).
2258
ca22b785
AS
22592011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2260
2261 * callint.c (Fcall_interactively): Don't truncate prompt string.
2262
d048e1e6
EZ
22632011-12-23 Eli Zaretskii <eliz@gnu.org>
2264
2265 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2266 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2267 resumed from there (after widening). (Bug#10360)
d048e1e6 2268
5ccaba1f
JD
22692011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2270
2271 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2272
204ee57f
JD
22732011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2274
b81d40f0
JB
2275 * nsterm.m (x_free_frame_resources):
2276 Release f->output_data.ns->miniimage.
204ee57f
JD
2277 (ns_index_color): Fix indentation. Do not retain
2278 color_table->colors[i].
2279
2280 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2281 before returning.
2282
2283 * nsfns.m (x_set_background_color): Assign return value from
2284 ns_index_color to face-background instead of NSColor*.
2285 (ns_implicitly_set_icon_type): Fix indentation.
2286 Change assignment in for loop to comparison.
2287
2288 * emacs.c (ns_pool): New variable.
2289 (main): Assign ns_pool.
2290 (Fkill_emacs): Call ns_release_autorelease_pool.
2291
2292 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2293 autorelease fdesc, release fdAttrs and tdict.
2294 (ns_get_covering_families): Release charset.
2295 (ns_findfonts): Release NSFontDescriptor created with new.
2296 (ns_uni_to_glyphs): Fix indentation.
2297 (setString): Release attrStr before assigning new value.
2298
c803b2b7
JD
22992011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2300
678f4426
JD
2301 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2302 and NS_IMPL_COCOA.
2303 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2304 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2305
cd394be1 23062011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2307
5fecd5fc
JD
2308 * nsterm.m (ns_term_init): Subscribe for notifications
2309 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2310 to method trackingNotification in EmacsMenu.
2311
2312 * nsmenu.m (trackingMenu): New variable.
3771cb17 2313 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2314 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2315 from Aquamacs (Bug#7030).
678f4426
JD
2316
23172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2318
c803b2b7
JD
2319 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2320 (symbol_to_nsstring): Fix indentation.
2321 (ns_symbol_to_pb): New function.
cae07000
SM
2322 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2323 (Fns_rotate_cut_buffers_internal): Remove.
2324 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2325 Fns_store_cut_buffer_internal.
2326 (ns_get_foreign_selection, Fx_own_selection_internal)
2327 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2328 (Fns_get_selection_internal, Fns_store_selection_internal):
2329 Use ns_symbol_to_pb and check if return value is nil.
2330 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2331 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2332 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2333 renamed to Sns_store_selection_internal.
2334 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2335 and remove this function.
2336 (ns_handle_selection_clear): Remove, never used.
2337 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2338 here.
2339
e1b01a3a
KB
23402011-12-17 Ken Brown <kbrown@cornell.edu>
2341
2342 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2343 GID is unknown (Bug#10257).
2344
2adb6e85
PE
23452011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2346
2347 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2348 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2349 which caused a build failure on GNU/Linux IA-64. This problem was
2350 introduced by my 2011-10-07 patch.
2351
d1d7b339
JL
23522011-12-15 Juri Linkov <juri@jurta.org>
2353
2354 * image.c (imagemagick_error): New function. (Bug#10112)
2355 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2356 Use `imagemagick_error' where ImageMagick functions return
2357 `MagickFalse'.
2358 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2359 proper order.
2360
100d5755
KH
23612011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2362
2363 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2364 fill background (Bug#8992).
2365
454592a6
MR
23662011-12-13 Martin Rudalics <rudalics@gmx.at>
2367
2368 * window.c (Vwindow_combination_resize)
2369 (Vwindow_combination_limit): Use t instead of non-nil in
2370 doc-strings.
61d4b438
MR
2371 (Vrecenter_redisplay): Add first sentence of doc-string on
2372 separate line.
53524d93 2373 (Frecenter): Fix doc-string typo.
454592a6 2374
3633e3aa
KH
23752011-12-11 Kenichi Handa <handa@m17n.org>
2376
2377 * coding.c (Funencodable_char_position): Pay attention to the
2378 buffer text relocation (Bug#9389).
2379
7b9d523a 23802011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2381
7b9d523a
JD
2382 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2383 gtk_init (Bug#10100).
2384
b73189c6
EZ
23852011-12-10 Eli Zaretskii <eliz@gnu.org>
2386
2387 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2388 IT->string is nil. (Bug#10263)
2389
f7dfe5d6
JD
23902011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2391
83faebb4
JD
2392 * nsterm.h (x_free_frame_resources): Declare.
2393
f7dfe5d6
JD
2394 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2395 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2396
2397 * nsterm.h (ns_get_defaults_value): Declare.
2398
2399 * nsterm.m (ns_default): Call ns_get_defaults_value.
2400
7cd4e72c
EZ
24012011-12-09 Eli Zaretskii <eliz@gnu.org>
2402
2403 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2404 (Bug#10170)
2405
b34d7317
YM
24062011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2407
2408 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2409 that where the value of an _OBJC_* symbol points to is in the .bss
2410 section (Bug#10240).
2411
76470ad1
KH
24122011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2413
2414 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2415 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2416
745fff94
KH
24172011-12-08 Kenichi Handa <handa@m17n.org>
2418
2419 * ftfont.c (get_adstyle_property): Fix previous change
2420 (Bug#10233).
2421
6e44397c
JB
24222011-12-07 Juanma Barranquero <lekktu@gmail.com>
2423
2424 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2425 dirs from the default value of EMACSLOADPATH (bug#10208).
2426
7efa6272
GM
24272011-12-07 Glenn Morris <rgm@gnu.org>
2428
2429 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2430 installation and source directories as well. (Bug#10208)
2431
f6fc4d87
CY
24322011-12-06 Chong Yidong <cyd@gnu.org>
2433
2434 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2435
2bf26180
GM
24362011-12-06 Glenn Morris <rgm@gnu.org>
2437
2438 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2439 as an error, not just -1. (Bug#10217)
2440
3a6ad4f0
CY
24412011-12-05 Chong Yidong <cyd@gnu.org>
2442
2443 * keyboard.c (process_special_events): New function.
2444 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2445
75a3b399
PE
24462011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2447
2448 * coding.c (encode_designation_at_bol): Don't use uninitialized
2449 local variable (Bug#9318).
2450
c3c9e25e
KH
24512011-12-05 Kenichi Handa <handa@m17n.org>
2452
2453 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2454 return Qnil (Bug#8046, Bug#10193).
2455
5eb05ea3
KH
24562011-12-05 Kenichi Handa <handa@m17n.org>
2457
2458 * coding.c (encode_designation_at_bol): New args charbuf_end and
2459 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2460 (coding_set_source): Return how many bytes coding->source was
2461 relocated.
2462 (coding_set_destination): Return how many bytes
2463 coding->destination was relocated.
2464 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2465 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2466
24672011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2468
2469 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2470 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2471 macro (Bug#9318).
2472
24732011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2474
2475 The following changes are to fix Bug#9318.
2476
a79703f5 2477 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2478 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2479 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2480 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2481
7dbda6df
JB
24822011-12-05 Juanma Barranquero <lekktu@gmail.com>
2483
2484 * lisp.h (process_quit_flag): Fix external declaration.
2485
6d5eb5b0
SM
24862011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2487
2488 Don't macro-inline non-performance-critical code.
2489 * eval.c (process_quit_flag): New function.
2490 * lisp.h (QUIT): Use it.
2491
a0c3fad0
JD
24922011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2493
2494 * nsfns.m (get_geometry_from_preferences): New function.
2495 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2496
6c07aac2
AS
24972011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2498
2499 * emacs.c (Qkill_emacs): Define.
2500 (syms_of_emacs): Initialize it.
2501 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2502 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2503 (quit_throw_to_read_char): Add parameter `from_signal'.
2504 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2505 * lisp.h (QUIT): Call Fkill_emacs if requested.
2506
c052ead4
JD
25072011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2508
2509 * widget.c (update_wm_hints): Return if wmshell is null.
2510 (widget_update_wm_size_hints): New function.
2511
2512 * widget.h (widget_update_wm_size_hints): Declare.
2513
2514 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2515 widget_update_wm_size_hints (Bug#10104).
2516
9e49252b
EZ
25172011-12-03 Eli Zaretskii <eliz@gnu.org>
2518
2519 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2520 before a newline, prepare the bidi iterator for consuming the
2521 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2522 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2523
02b16839
JL
25242011-12-02 Juri Linkov <juri@jurta.org>
2525
2526 * search.c (Fword_search_regexp): New Lisp function created from
2527 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2528 (Fword_search_backward, Fword_search_forward)
2529 (Fword_search_backward_lax, Fword_search_forward_lax):
2530 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2531 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2532
0068070e
SM
25332011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2534
2535 * fileio.c (Finsert_file_contents): Move after-change-function call
2536 to before the "handled:" label, since all "goto handled" appear in
2537 cases where the *-change-functions have already been properly called
2538 (bug#10117).
2539
3360a3fc
AS
25402011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2541
2542 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2543 waiting for input. (Bug#10169)
2544
73d6c093
EZ
25452011-11-30 Eli Zaretskii <eliz@gnu.org>
2546
2547 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2548 verifies glyph row's hash code--we have just reallocated the
2549 glyphs, so their contents can be complete garbage. (Bug#10164)
2550
febe6bea
JB
25512011-11-30 Juanma Barranquero <lekktu@gmail.com>
2552
2553 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2554
801a4313
EZ
25552011-11-30 Eli Zaretskii <eliz@gnu.org>
2556
2557 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2558 attributes are tested _before_ calling verify_row_hash, to protect
2559 against GCC re-ordering of the tests. (Bug#10164)
2560
2b56b87e
JD
25612011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2562
2563 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2564
2565 * xterm.c (handle_one_xevent): Only set async_visible and friends
2566 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2567 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2568 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2569
dbf31225
PE
25702011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2573 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2574 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2575 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2576 All uses changed to use GCPRO1 etc.
2577 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2578 Revert to old implementation (i.e., before 2011-03-11).
2579
1305621b
YM
25802011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2581
2582 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2583 of scroll runs so as to avoid assigning disabled bogus rows and
2584 unnecessary graphics copy operations.
2585
8c9afb46
EZ
25862011-11-27 Eli Zaretskii <eliz@gnu.org>
2587
2588 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2589 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2590 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2591 (malloc, free, realloc, calloc): Redirect to e_* only when
2592 compiling Emacs.
2593
2594 * lisp.h (GCTYPEBITS): Move before first use.
2595 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2596 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2597 this macro definition.
2598
2599 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2600 _MSC_VER.
2601
54e9e3bf
JD
26022011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2603
6d5eb5b0
SM
2604 * gtkutil.c (xg_create_frame_widgets):
2605 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2606 present with Gtk+ 2.0.
2607
83aca1cb
PE
26082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * fileio.c (Finsert_file_contents): Undo previous change; see
2611 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2612
5b76caa4
PE
26132011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2614
2615 Rename locals to avoid shadowing.
2616 * fileio.c (Finsert_file_contents):
2617 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2618 * process.c (wait_reading_process_output):
2619 Rename inner 'proc' to 'p' to avoid shadowing.
2620 Indent for consistency with usual Emacs style.
2621
8c535114
EZ
26222011-11-25 Eli Zaretskii <eliz@gnu.org>
2623
2624 * xdisp.c (redisplay_window): If cursor row is not fully visible
2625 after recentering, and scroll-conservatively is set to a large
2626 number, scroll window by a few more lines to make the cursor fully
2627 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2628 (start_display): Don't move to the next line if the display should
2629 start at a newline that is part of a display vector or an overlay
2630 string. (Bug#10119)
8c535114 2631
fa4fdb5c
JL
26322011-11-24 Juri Linkov <juri@jurta.org>
2633
2634 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2635 after the `MagickPingImage' call. (Bug#10112)
2636
90ec88df
CY
26372011-11-23 Chong Yidong <cyd@gnu.org>
2638
2639 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2640
56e2e794
MR
26412011-11-23 Martin Rudalics <rudalics@gmx.at>
2642
2643 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2644 making another buffer current. (Bug#10114)
2645
b6e64c41
GM
26462011-11-23 Glenn Morris <rgm@gnu.org>
2647
2648 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2649
6b21de18
CY
26502011-11-23 Chong Yidong <cyd@gnu.org>
2651
2652 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2653 using it (Bug#5984).
2654
b12cd789
EZ
26552011-11-22 Eli Zaretskii <eliz@gnu.org>
2656
2657 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2658 and header-lines, as they don't have one computed for them.
2659 (Bug#10098)
2660
2661 * .gdbinit (prow): Make displayed values more self-explaining.
2662 Add row's hash code.
2663
261b6fd4
LMI
26642011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2665
2666 * process.c (wait_reading_process_output): Fix asynchrounous
2667 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2668 (wait_reading_process_output): Add comment and URL.
261b6fd4 2669
e7cfd277
JD
26702011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2671
2672 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2673
a9b9b7f5
CY
26742011-11-21 Chong Yidong <cyd@gnu.org>
2675
2676 * window.c (Fnext_window, Fprevious_window): Doc fix.
2677
b0d15b4f
SM
26782011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2679
2680 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2681
fe7a3057
JB
26822011-11-20 Juanma Barranquero <lekktu@gmail.com>
2683
2684 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2685
d2999b1a
MR
26862011-11-20 Martin Rudalics <rudalics@gmx.at>
2687
2688 * window.c (Fset_window_combination_limit): Rename argument
2689 STATUS to LIMIT.
2690 (Vwindow_combination_limit): Remove "status" from doc-string.
2691
d5ff9cd0
AS
26922011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2693
2694 * m/ibms390.h: Remove.
2695 * m/ibms390x.h: Don't include "ibms390.h".
2696
a5bb9bd3
SM
26972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2698
2699 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2700 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2701
cd1181db
JB
27022011-11-20 Juanma Barranquero <lekktu@gmail.com>
2703
2704 * casetab.c (Fset_case_table):
2705 * charset.c (Fcharset_after): Fix typos.
2706
615a3b8d 27072011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2708
17e845af
PE
2709 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2710 Otherwise, valgrind does not work on some platforms.
2711 Problem reported by Andreas Schwab in
6a0bf43d
PE
2712 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2713 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2714 is set, removing the need for VIRT_ADDRESS_VARIES.
2715 (PURE_P): Use a more-efficient implementation that needs just one
2716 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2717 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2718 to 4 (xorl, subq, cmpq, setbe).
2719 * alloc.c (pure): Always extern now, since that's the
2720 VIRT_ADDR_VARIES behavior.
2721 (PURE_POINTER_P): Use a single comparison, not two, for
2722 consistency with the new puresize.h.
2723 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2724 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2725 Remove VIRT_ADDR_VARIES no longer needed.
2726
f8fe6f96
EZ
27272011-11-19 Eli Zaretskii <eliz@gnu.org>
2728
2729 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2730 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2731 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2732 behave as if the cursor position were at the window margin.
2733
2734 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2735 and the cursor position is out of bounds, behave as if the cursor
2736 position were at the window margin. (Bug#10075)
2737
df05a53c
CY
27382011-11-18 Chong Yidong <cyd@gnu.org>
2739
2740 * window.c (Fwindow_combination_limit): Make first argument
2741 non-optional, since it is meaningless for live windows like the
2742 selected window.
61ccba97 2743
2071918e
DA
27442011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2745
2746 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2747
b50a28de
SM
27482011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2749
2750 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2751 (graft_intervals_into_buffer): Simplify.
2752
015137db
EZ
27532011-11-18 Eli Zaretskii <eliz@gnu.org>
2754
2755 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2756 hash values of the two rows.
2757 (copy_row_except_pointers): Preserve the used[] arrays and the
2758 hash values of the two rows. (Bug#10035)
68c95424 2759 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
2760
2761 * xdisp.c (row_hash): New function, body extracted from
2762 compute_line_metrics.
2763 (compute_line_metrics): Call row_hash, instead of computing the
2764 hash code inline.
2765
2766 * dispnew.c (verify_row_hash): Call row_hash for computing the
2767 hash code of a row, instead of duplicating code from xdisp.c.
2768
2769 * dispextern.h (row_hash): Add prototype.
2770
a2addb04
TH
27712011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2772
2773 * frame.c (delete_frame): Don't delete the terminal when the last
2774 X frame is closed if emacs is built with GTK toolkit.
2775
df85d315
JB
27762011-11-17 Juanma Barranquero <lekktu@gmail.com>
2777
2778 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2779
a0c2d0ae
MR
27802011-11-17 Martin Rudalics <rudalics@gmx.at>
2781
2782 * window.c (Vwindow_splits): Rename to
2783 Vwindow_combination_resize. Suggested by Juri Linkov.
2784 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2785 of Vwindow_splits.
2786
58179cce
JB
27872011-11-16 Juanma Barranquero <lekktu@gmail.com>
2788
7877f373
JB
2789 * nsfns.m (Fns_font_name):
2790 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 2791
b6f67890
MR
27922011-11-16 Martin Rudalics <rudalics@gmx.at>
2793
2794 * window.h (window): Rename slot "nest" to "combination_limit".
2795 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2796 (Fset_window_nest): Rename to Fset_window_combination_limit.
2797 (Vwindow_nest): Rename to Vwindow_combination_limit.
2798 (recombine_windows, make_parent_window, make_window)
2799 (Fsplit_window_internal, saved_window)
2800 (Fset_window_configuration, save_window_save): Rename all
2801 occurrences of window_nest to window_combination_limit.
2802
c7015153
JB
28032011-11-15 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * image.c (imagemagick_load_image): Fix typo.
2806
322ad6ec
EZ
28072011-11-14 Eli Zaretskii <eliz@gnu.org>
2808
2809 * xdisp.c (display_line): Move the call to
2810 highlight_trailing_whitespace before the call to
2811 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
2812 faces of all the glyphs to compute ROW's hash value.
2813 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 2814
f067b8ec
JB
28152011-11-14 Juanma Barranquero <lekktu@gmail.com>
2816
2817 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2818 just return (bug#10044).
2819
1e5b2111
EZ
28202011-11-12 Eli Zaretskii <eliz@gnu.org>
2821
7ef3cbd5
EZ
2822 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2823 with user-defined heap size. Bump the default size of the temacs
2824 heap to 27MB, to avoid memory warning when running temacs.
2825 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2826
1e5b2111
EZ
2827 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2828 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2829 (verify_row_hash) [XASSERTS]: New function.
2830 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2831 that the hash value of glyph rows is correct.
1e5b2111 2832
89d61221
MR
28332011-11-12 Martin Rudalics <rudalics@gmx.at>
2834
2835 * window.h (window): Remove splits slot.
2836 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2837 (Fdelete_other_windows_internal, make_parent_window)
2838 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2839 (Fset_window_configuration, save_window_save): Don't deal with
2840 split status of windows.
2841 (saved_window): Remove splits slot.
2842 (Vwindow_splits): Rewrite doc-string.
2843
97f18cc8
JD
28442011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2845
2846 * xfns.c (unwind_create_frame):
2847 * nsfns.m (unwind_create_frame):
2848 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2849 Vframe_list (Bug#9999).
2850
22a648b4
DA
28512011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2852
0b381c7e 2853 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2854
659afede
KH
28552011-11-11 Kenichi Handa <handa@m17n.org>
2856
2857 * callproc.c (Fcall_process): Set the member dst_multibyte of
2858 process_coding.
2859
9ac0394b
KH
28602011-11-11 Johan Bockgård <bojohan@gnu.org>
2861
2862 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2863 avoid a crash (bug#9496).
2864
2fbdc249
CY
28652011-11-09 Chong Yidong <cyd@gnu.org>
2866
2867 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2868 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2869
ac6b1f81
PE
28702011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2871
2872 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2873
09db192c
PE
28742011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2875
2876 Avoid some portability problems by eschewing 'extern inline' functions.
2877 The trivial performance wins aren't worth the portability hassles; see
2878 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2879 et seq.
2880 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2881 (window_box_width, window_box_left, window_box_left_offset)
2882 (window_box_right, window_box_right_offset): Undo previous change,
2883 by removing the "extern"s.
2884 * intervals.c (adjust_intervals_for_insertion)
2885 (adjust_intervals_for_deletion): Undo previous change,
2886 making these static again.
2887 (offset_intervals, temp_set_point_both, temp_set_point)
2888 (copy_intervals_to_string): No longer inline.
2889 * xdisp.c (window_text_bottom_y, window_box_width)
2890 (window_box_height, window_box_left_offset)
2891 (window_box_right_offset, window_box_left, window_box_right)
2892 (window_box): No longer inline.
2893
105216ed
CY
28942011-11-08 Chong Yidong <cyd@gnu.org>
2895
2896 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2897 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2898 Signal an error if not a live window.
105216ed
CY
2899 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2900 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2901
ae9e237f
JB
29022011-11-07 Juanma Barranquero <lekktu@gmail.com>
2903
2904 * lisp.h (syms_of_abbrev): Remove declaration.
2905 Reported by CHENG Gao <chenggao@royau.me>.
2906
c7aa8333
EZ
29072011-11-07 Eli Zaretskii <eliz@gnu.org>
2908
2909 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2910 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2911 of temacs in GUI mode.
2912
be7f5545
MR
29132011-11-07 Martin Rudalics <rudalics@gmx.at>
2914
2915 * window.h: Declare delete_all_child_windows instead of
2916 delete_all_subwindows.
2917 * window.c (Fwindow_nest, Fset_window_nest)
2918 (Fset_window_new_total, Fset_window_new_normal)
2919 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2920 (delete_all_subwindows): Rename to delete_all_child_windows.
2921 (Fdelete_other_windows_internal, Fset_window_configuration):
2922 Call delete_all_child_windows instead of delete_all_subwindows.
2923 * frame.c (delete_frame): Call delete_all_child_windows instead
2924 of delete_all_subwindows.
2925
ca78dc43
PE
29262011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2927
2928 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2929 This is also needed for porting to any host where GC_MARK_STACK is
2930 not GC_MAKE_GCPROS_NOOPS.
2931 (which_symbols): Use it.
2932
a0241d01
KH
29332011-11-07 Kenichi Handa <handa@m17n.org>
2934
2935 * coding.c (coding_set_destination): Check coding->src_pos only
2936 when coding->src_object is a buffer (bug#9910).
2937
2938 * process.c (send_process): Set the member src_multibyte of coding
2939 to 0 (bug#9911) when sending a unibyte text.
2940
2941 * callproc.c (Fcall_process): Set the member src_multibyte of
2942 process_coding to 0 (bug#9912).
2943
a64bfdfa 29442011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2945
2946 * xmenu.c (cleanup_widget_value_tree): New function.
2947 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2948 calling free_menubar_widget_value_tree directly (Bug#9830).
2949
cb41b32a
PE
29502011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 Fix some portability problems with 'inline'.
2953 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2954 (window_box_width, window_box_left, window_box_left_offset)
2955 (window_box_right, window_box_right_offset): Declare extern.
2956 Otherwise, these inline functions do not conform to C99 and
2957 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2958 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2959 * intervals.c (adjust_intervals_for_insertion)
2960 (adjust_intervals_for_deletion): Now extern, because otherwise the
2961 extern inline functions 'offset_intervals' couldn't refer to it.
2962 (static_offset_intervals): Remove.
2963 (offset_intervals): Rewrite using the old contents of
2964 static_offset_intervals. The old version didn't conform to C99
2965 because an extern inline function contained a reference to an
2966 identifier with static linkage.
2967
b7041366
AS
29682011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2969
2970 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2971 GC.
2972
88a37c4d
EZ
29732011-11-06 Eli Zaretskii <eliz@gnu.org>
2974
2975 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2976 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2977 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2978 return Qleft_to_right.
2979
49745b39
CY
29802011-11-06 Chong Yidong <cyd@gnu.org>
2981
2982 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2983 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2984 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2985 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2986 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2987 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2988 (Fwindow_vscroll): Doc fix.
2989 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2990 argument, since it makes no sense to pass a live window and for
2991 consistency with window-child.
2992
1f05cd82
CS
29932011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2994
2995 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2996 support MSVC.
2997
22610910
JR
29982011-11-05 Jason Rumney <jasonr@gnu.org>
2999
3000 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3001 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3002 fonts (Bug#6029).
3003 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3004 bitwise arithmetic preventing use of unicode-sip and non-truetype
3005 opentype fonts.
3006
a06776b2
EZ
30072011-11-05 Eli Zaretskii <eliz@gnu.org>
3008
3ad924ba
EZ
3009 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3010 "emacs"-only part.
3011
a06776b2
EZ
3012 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3013 initialization code to keep similarity to xfns.c after changes
3014 from 2011-11-05.
3015
c9e7db78
JD
30162011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3017
a97f8f3f
JD
3018 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3019 (unwind_create_frame): New function (Bug#9943).
3020 (Fx_create_frame): Restructure code to be more similar to the one in
3021 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3022 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3023 Move terminal->reference_count++ just before making the frame official
3024 (Bug#9943).
3025
3026 * nsterm.m (x_free_frame_resources): New function.
3027 (x_destroy_window): Move code to x_free_frame_resources.
3028
c9e7db78 3029 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3030 (Fx_create_frame, x_create_tip_frame):
3031 Move terminal->reference_count++ just before making the frame
75f1671a 3032 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3033 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3034
a6fc3b5c
EZ
30352011-11-05 Eli Zaretskii <eliz@gnu.org>
3036
3037 Support MSVC build with newer versions of Visual Studio.
3038 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3039 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3040 nt/gmake.defs.
3041
3042 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3043 which are not supported by MSVC.
3044 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3045 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3046 bitfields.
3047 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3048 types in bitfields.
3049 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3050
3051 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3052
58179cce 30532011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3054
3055 Support MSVC build with newer versions of Visual Studio.
3056 * w32.c: Don't include w32api.h for MSVC.
3057 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3058
3059 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3060 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3061 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3062 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3063 e_* cousins.
3064 (alloca) [_MSC_VER]: Define to _alloca.
3065
3066 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3067
3068 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3069
a58c13ed
EZ
30702011-11-04 Eli Zaretskii <eliz@gnu.org>
3071
3072 * xdisp.c (note_mouse_highlight): If either of
3073 previous/next-single-property-change returns nil, treat that as
3074 the beginning or the end of the buffer. (Bug#9955)
3075
fe0b6370
JD
30762011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3077
a58c13ed 3078 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3079 label is not null (Bug#9951).
3080 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3081 may be NULL.
3082
89bd5ee1
EZ
30832011-11-04 Eli Zaretskii <eliz@gnu.org>
3084
3085 * window.c (Fwindow_body_size): Mention in the doc string that the
3086 return value is in frame's canonical units. (Bug#9949)
3087
84c3edb9
EZ
30882011-11-03 Eli Zaretskii <eliz@gnu.org>
3089
4e2fb5c7
EZ
3090 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3091
84c3edb9 3092 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3093 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3094 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3095
bc17a887
EZ
30962011-11-01 Eli Zaretskii <eliz@gnu.org>
3097
3098 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3099 Don't stop backward scan on the continuation glyph, even though
3100 its CHARPOS is positive.
6d5eb5b0
SM
3101 (mouse_face_from_buffer_pos, note_mouse_highlight):
3102 Rename cover_string to disp_string.
bc17a887 3103
4ee88440
MR
31042011-11-01 Martin Rudalics <rudalics@gmx.at>
3105
3106 * window.c (temp_output_buffer_show): Don't use
3107 Vtemp_buffer_show_specifiers.
3108 (Vtemp_buffer_show_specifiers): Remove unused variable.
3109
c2ff3c02
EZ
31102011-10-30 Eli Zaretskii <eliz@gnu.org>
3111
3112 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3113 past the beginning of the current glyph matrix.
3114
58179cce 31152011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3116
3117 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3118 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3119 HAVE_GTK3 (Bug#9869).
b77a6a7f 3120
3b574623
JD
3121 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3122 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3123
b77a6a7f
JD
3124 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3125
3126 * xterm.c: Declare x_handle_net_wm_state to return int.
3127 (handle_one_xevent): Check if we are iconified but don't have
3128 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3129 (get_current_wm_state): Return non-zero if not hidden,
3130 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3131 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3132 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3133 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3134
196e41e4
PE
31352011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3138 so that this new function doesn't get optimized away by a
3139 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3140
021f2e1a
AS
31412011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3142
3143 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3144
8b058d44
EZ
31452011-10-29 Eli Zaretskii <eliz@gnu.org>
3146
3147 Fix the `xbytecode' command.
3148 * .gdbinit (xprintbytestr): New command.
b50a28de 3149 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3150 (xbytecode): Print the byte-code string as well.
3151
4452fb80
EZ
31522011-10-29 Kim Storm <storm@cua.dk>
3153
8b058d44
EZ
3154 * alloc.c (which_symbols): New function.
3155
21b72067
AS
31562011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3157
3158 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3159 line. (Bug#9903)
3160
83ed7b5c
GM
31612011-10-29 Glenn Morris <rgm@gnu.org>
3162
3163 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3164 Not clear what it was for, and it causes various bugs. (Bug#9839)
3165
5a7a728b
EZ
31662011-10-28 Eli Zaretskii <eliz@gnu.org>
3167
3168 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3169 possible random value that matches one of those tested as
3170 condition to clear the mouse face.
3171
d3d0842f
CY
31722011-10-28 Chong Yidong <cyd@gnu.org>
3173
3174 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3175
31b39d13
DN
31762011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3177
3178 * window.c (make_window): Initialize phys_cursor_on_p.
3179
9aba6043
SM
31802011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3181
3182 * lisp.h (struct Lisp_Symbol): Update comments.
3183
c20992f4
JB
31842011-10-28 Juanma Barranquero <lekktu@gmail.com>
3185
3186 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3187
db4f02f2
EZ
31882011-10-28 Eli Zaretskii <eliz@gnu.org>
3189
3190 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3191 <oslsachem@gmail.com> for helping to debug this.
3192
3193 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3194 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3195 (g_b_init_get_glyph_outline_w): New static variables.
3196 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3197 (GetGlyphOutlineW_Proc): New typedefs.
3198 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3199 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3200 New functions.
3201 (w32font_open_internal, compute_metrics):
3202 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3203 instead of calling the "wide" APIs directly.
3204
3205 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3206
3207 * w32.h (syms_of_w32font): Add prototype.
3208
87e68db4
JB
32092011-10-27 Juanma Barranquero <lekktu@gmail.com>
3210
3211 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3212 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3213 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3214 (Fmove_to_window_line): Doc fix.
3215
435c1d67
CY
32162011-10-27 Chong Yidong <cyd@gnu.org>
3217
3218 * process.c (make_process): Set gnutls_state to NULL.
3219
3220 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3221 non-NULL, regardless of GNUTLS_INITSTAGE.
3222 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3223 an error. Set process slots as soon as we allocate them.
3224
3225 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3226
9c6c6f49
CY
32272011-10-27 Chong Yidong <cyd@gnu.org>
3228
9aba6043
SM
3229 * gnutls.c (emacs_gnutls_deinit): New function.
3230 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3231 (Fgnutls_deinit, Fgnutls_boot): Use it.
3232
3233 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3234 (deactivate_process): Call emacs_gnutls_deinit.
3235
657d08d3
JB
32362011-10-27 Juanma Barranquero <lekktu@gmail.com>
3237
3238 * image.c (x_create_x_image_and_pixmap):
3239 * w32.c (sys_rename, w32_delayed_load):
3240 * w32font.c (fill_in_logfont):
3241 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3242
5430d399
JB
32432011-10-26 Juanma Barranquero <lekktu@gmail.com>
3244
3245 * w32fns.c (w32_default_color_map): New function,
3246 extracted from Fw32_default_color_map.
a7ef684b 3247 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3248
fe0055fa
PE
32492011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3250
3251 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3252
e6346438
SM
32532011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3254
3255 * keyboard.c (test_undefined): New function (bug#9751).
3256 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3257
e112cc37
ET
32582011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3259
3260 * sysdep.c (init_sys_modes): Fix the check for the controlling
3261 terminal (Bug#6649).
3262
7b5d6677
EZ
32632011-10-20 Eli Zaretskii <eliz@gnu.org>
3264
3265 * dispextern.h (struct bidi_it): New member next_en_type.
3266
3267 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3268 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3269 current character, check also for next_en_type being WEAK_EN.
3270 (bidi_resolve_weak): Don't enter the expensive loop if the current
3271 position is before next_en_pos. Record the bidi type of the first
3272 non-ET, non-BN character we find, in addition to its position.
3273 (bidi_level_of_next_char): Invalidate next_en_type when
3274 next_en_pos is over-stepped.
3275
7da0b018
PE
32762011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3277
3278 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3279 * editfns.c: Rewrite current-time-zone so that it invokes
3280 the equivalent of (format-time-string "%Z") to get the time zone name.
3281 This fixes a bug when the time zone name contains characters that
3282 need converting from the system time locale to Emacs internal format.
3283 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3284 that patch fixed format-time-string to do the conversion, but
3285 I forgot to fix current-time-zone.
3286 (format_time_string): New function, containing most of
3287 what Fformat_time_string used to contain.
3288 (Fformat_time_string): Rewrite in terms of format_time_string.
3289 This doesn't change this function's behavior.
3290 (current-time-zone): Rewrite to use format_time_string.
3291 This fixes the bug reported by Michael Schierl in
3292 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3293 Jason Rumney's 2007-06-07 change worked around this bug, but
3294 didn't fix it.
3295 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3296
8547b010
EZ
32972011-10-19 Eli Zaretskii <eliz@gnu.org>
3298
3299 * xdisp.c (start_display): If the character at POS is displayed
3300 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3301 (try_window_reusing_current_matrix): If a line ends in a display
3302 vector or the next line starts in a display vector, continue
3303 redrawing the window even though the character position of
3304 start_row was reached.
8547b010
EZ
3305 (Bug#9771, part 2)
3306
4e948d15
CY
33072011-10-18 Chong Yidong <cyd@gnu.org>
3308
3309 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3310 with nobreak-char-display too.
3311
4787455f
EZ
33122011-10-18 Eli Zaretskii <eliz@gnu.org>
3313
3314 Fix part 3 of bug#9771.
3315 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3316 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3317 non-neutral characters if the current character is a paragraph
3318 separator (a.k.a. Newline). This avoids running the same
3319 expensive loop twice, once when we consume the preceding newline
3320 and the other time when the line actually needs to be displayed.
3321 Avoid the loop when we see neutrals on the base embedding level
3322 following a character whose directionality is the same as the
3323 paragraph's. This avoids running the expensive loop when a line
3324 ends in a long sequence of neutrals, like control characters.
3325 Add assertion against STRONG_AL type. Slightly rearrange code
3326 that determines the type of a neutral given the first non-neutral
3327 that follows it.
3328 (bidi_level_of_next_char): Set next_en_pos to zero when
3329 invalidating its info.
3330
2c91f553
EZ
33312011-10-17 Eli Zaretskii <eliz@gnu.org>
3332
3333 * xdisp.c (push_display_prop): Determine whether to record string
3334 or buffer position by IT->string, not by IT->method. Allow
3335 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3336 (move_it_vertically_backward): Don't look for character position
3337 immediately after the newline when in a continuation line.
3338 (Bug#9771, part 1)
2c91f553 3339
c7b08b0d
MR
33402011-10-15 Martin Rudalics <rudalics@gmx.at>
3341
3342 * window.c (coordinates_in_window): Rewrite and delabelize
3343 vertical border check. (Bug#5357) (Bug#9618)
3344
6b02f655
SM
33452011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3346
3347 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3348 errors in XSetWindowBorder (bug#9310).
3349
81d40c92
DA
33502011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3351
3352 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3353 avoid crash when xmalloc overrun checking is enabled.
3354
d4172c3b
EZ
33552011-10-13 Eli Zaretskii <eliz@gnu.org>
3356
3357 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3358 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3359 cursor motion with <left> and <right> arrow keys.
3360
3361 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3362 some callers set that themselves.
3363
b00eea75
EZ
33642011-10-12 Eli Zaretskii <eliz@gnu.org>
3365
3366 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3367 display string and the previous row comes from the same string and
3368 is empty. (Bug#9739) (Bug#9738)
3369
8fe012c4
SM
33702011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3371
3372 * doc.c (get_doc_string): Encode file name (bug#9735).
3373
0074aef2
EZ
33742011-10-12 Eli Zaretskii <eliz@gnu.org>
3375
79beb178
EZ
3376 * bidi.c (bidi_level_of_next_char):
3377 * xdisp.c (get_visually_first_element): Remove old incorrect
3378 comments regarding the Unicode Line Separator character.
3379
0074aef2
EZ
3380 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3381
6e4b3fbe
DA
33822011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3383
3384 * alloc.c (Fgc_status): Do not access beyond zombies array
3385 boundary if nzombies > MAX_ZOMBIES.
3386 * alloc.c (dump_zombies): Add missing format specifier.
3387
0324f3af
PE
33882011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3389
b5525cac
PE
3390 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3391 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3392
0324f3af
PE
3393 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3394 Some packages use them to denote characters with modifiers.
3395
e9b5f888
AS
33962011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3397
3398 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3399 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3400 matching a pp-number. Rename parameter var to var1.
3401
127827c0
SM
34022011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3403
3404 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3405
c8fd3bd0
GM
34062011-10-08 Glenn Morris <rgm@gnu.org>
3407
3408 * callint.c (Fcall_interactively): Give a more explicit error for the
3409 'c' case with a non-character input. (Bug#8479)
3410
352ec8ff
EZ
34112011-10-08 Eli Zaretskii <eliz@gnu.org>
3412
03669ccb
EZ
3413 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3414 lines.
7061c986
EZ
3415 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3416 lines that are hscrolled on the left.
03669ccb 3417
352ec8ff
EZ
3418 * dispnew.c (buffer_posn_from_coords): Account for a possible
3419 presence of header-line. (Bug#4426)
3420
a66cfb1c
SM
34212011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3422
6b02f655
SM
3423 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3424 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3425
7c5ee88e
PE
34262011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3427
3428 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3429 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3430 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3431 this makes Emacs dump core during garbage collection on rare
3432 occasions. sizeof is obviously inferior to offsetof here, so
3433 stick with offsetof.
3434 (GC_POINTER_ALIGNMENT): New macro.
3435 (mark_memory): Omit 3rd (offset) arg; caller changed.
3436 Don't assume EMACS_INT alignment is the same as pointer alignment.
3437
df1bbe5b
SM
34382011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3439
3440 * keyboard.c (read_key_sequence_remapped): New var.
3441 (read_key_sequence): Compute remapping in the right buffer.
3442 (command_loop_1): Use read_key_sequence's remapping directly.
3443
51553db6
SM
34442011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3445
32c1fffd
SM
3446 * dired.c (file_name_completion): Don't expand file name.
3447 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3448 before checking file name handler.
3449
51553db6
SM
3450 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3451 they've been requested explicitly (bug#9591).
3452
b6bd1599 34532011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3454
3455 * keymap.c (Fsingle_key_description): Use make_specified_string
3456 instead of build_string to build string from push_key_description.
3457 (Bug#5193)
3458
f701dc2a
PE
34592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3460
4222c55d
PE
3461 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3462 This fixes a Y2038 bug on 64-bit hosts.
3463 * buffer.c (reset_buffer):
3464 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3465 (Fclear_buffer_auto_save_failure):
3466 Use 0, not -1, to represent an unset failure time, since time_t
3467 might not be signed.
3468
f701dc2a
PE
3469 Remove dependency on glibc malloc internals.
3470 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3471 Move back here from lisp.h, but with their new implementations.
3472 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3473 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3474 * charset.c (charset_table_init): New static var.
3475 (syms_of_charset): Use it instead of xmalloc. This removes a
3476 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3477 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3478 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3479 Move back to alloc.c.
3480 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3481 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3482
9ceebf39
JD
34832011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3484
3485 * nsterm.m (windowDidResize): Call x_set_window_size only when
3486 ns_in_resize is true. Otherwise set pixelwidth/height and
3487 call change_frame_size (Bug#9628).
3488
cb993c58
PE
34892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3490
3930c88b
PE
3491 Port --enable-checking=all to Fedora 14 x86-64.
3492 * charset.c (syms_of_charset): Also account for glibc malloc's
3493 internal overhead when calculating the initial malloc maximum.
3494
cb993c58
PE
3495 Port --enable-checking=all to Fedora 14 x86.
3496 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3497 Move to lisp.h.
3498 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3499 (overrun_check_realloc, overrun_check_free):
3500 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3501 That way, xmalloc returns a properly-aligned pointer even if
3502 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3503 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3504 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3505 into account when calculating the initial malloc maximum.
3506 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3507 Move here from alloc.c, so that charset.c can use it too.
3508 Properly align; the old code wasn't right for common 32-bit hosts
3509 when configured with --enable-checking=all.
3510 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3511 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3512
31bed486
EZ
35132011-09-29 Eli Zaretskii <eliz@gnu.org>
3514
04c70788 3515 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3516 use EDOM.
3517
fbcaa2f3
EZ
35182011-09-28 Eli Zaretskii <eliz@gnu.org>
3519
3520 * xdisp.c (compute_display_string_end): If there's no display
3521 string at CHARPOS, return -1.
3522
3523 * bidi.c (bidi_fetch_char): When compute_display_string_end
3524 returns a negative value, treat the character as a normal
3525 character not covered by a display string. (Bug#9624)
3526
a239d4e9
JB
35272011-09-28 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * lread.c (Fread_from_string): Fix typo in docstring.
3530
88652fd5
EZ
35312011-09-27 Eli Zaretskii <eliz@gnu.org>
3532
3533 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3534 newline, reseat the iterator instead of bidi-iterating there one
3535 character at a time. (Bug#9610)
32c1fffd
SM
3536 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3537 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3538
ed497dd4
AS
35392011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3540
3541 * lread.c (readevalloop): Use correct code for NBSP.
3542 (read1): Likewise. (Bug#9608)
3543
b2bf61aa
MA
35442011-09-25 Michael Albinus <michael.albinus@gmx.de>
3545
3546 * dbusbind.c (Fdbus_register_signal): When service is not
3547 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3548
32bbb17c
GM
35492011-09-25 Glenn Morris <rgm@gnu.org>
3550
3551 * buffer.c (truncate-lines): Doc fix.
3552
94e0933e
CY
35532011-09-24 Chong Yidong <cyd@stupidchicken.com>
3554
3555 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3556 (Fset_window_next_buffers): Doc fix.
3557
cddde921
GM
35582011-09-24 Glenn Morris <rgm@gnu.org>
3559
3560 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3561
1260aef1
PE
35622011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3563
25b4bfa0
PE
3564 Fix minor problems found by static checking.
3565 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3566 * indent.c (Fvertical_motion): Fix == vs = typo.
3567
e3cbd34b
EZ
35682011-09-24 Eli Zaretskii <eliz@gnu.org>
3569
a66cfb1c
SM
3570 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3571 Default value is now t. Doc fix.
6bf7006f 3572
e3cbd34b 3573 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3574 logic when moving up, not only when moving down. Fix the
e3cbd34b 3575 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3576 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3577
3578 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3579 CHARPOS is covered by a display string which includes newlines.
3580 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3581 is covered by a display string with embedded newlines.
3582
a3de0cbd
MA
35832011-09-24 Michael Albinus <michael.albinus@gmx.de>
3584
3585 * dbusbind.c (Fdbus_register_signal): Add match rule to
3586 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3587 (Fdbus_register_method, Vdbus_registered_objects_table):
3588 Fix docstring.
a3de0cbd 3589
b260039d
JM
35902011-09-24 Jim Meyering <meyering@redhat.com>
3591
32c1fffd 3592 do not ignore write error for any output size
b260039d
JM
3593 The previous change was incomplete.
3594 While it makes emacs --batch detect the vast majority of stdout
3595 write failures, errors were still ignored whenever the output size is
3596 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3597 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3598 && echo FAIL: ignored write error
3599 FAIL: ignored write error
3600 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3601 && echo FAIL: ignored write error
3602 FAIL: ignored write error
3603 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3604
8eca8a7c
AS
36052011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3606
3607 * emacs.c (Fkill_emacs): In noninteractive mode exit
3608 non-successfully if a write error occurred on stdout. (Bug#9574)
3609
3341db62
EZ
36102011-09-21 Eli Zaretskii <eliz@gnu.org>
3611
3612 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3613 the xassert test.
3614
3615 * dispextern.h (struct it): Update the comment documenting what
3616 can it->OBJECT be.
3617
8c203dbf
EZ
36182011-09-20 Eli Zaretskii <eliz@gnu.org>
3619
3620 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3621 a display string, extend search for cursor position to end of row.
3622 (find_row_edges): If the row ends in a newline from a display
3623 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3624 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3625 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3626 non-empty line. Fixes confusing cursor motion with arrow keys at
3627 the beginning of a line that starts with whitespace.
8c203dbf 3628
a4824228
LMI
36292011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3630
3631 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3632 (bug#9493).
3633
33ed493b
CY
36342011-09-18 Chong Yidong <cyd@stupidchicken.com>
3635
3636 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3637 boolean (Bug#9154).
3638
56cd55c8
EZ
36392011-09-18 Eli Zaretskii <eliz@gnu.org>
3640
3641 * xdisp.c (display_line): Record maximum and minimum buffer
3642 positions even if no glyphs were produced (e.g., by a zero-width
3643 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3644 buffer positions that will be removed from the glyph row because
3645 they don't fit.
c02dcedf
EZ
3646 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3647 column is beyond frame width: don't subtract 1 "pixel" when
3648 computing width of the stretch.
3e62b7e0
EZ
3649 (reseat_at_next_visible_line_start): Undo the change made on
3650 2011-09-17 that saved paragraph information and restored it after
3651 the call to `reseat'. (Bug#9545)
56cd55c8 3652
5ed99d36 36532011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3654
3655 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3656 and turn window cursor on if cleared (Bug#9415).
3657
5ed99d36 36582011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3659
3660 * search.c (boyer_moore): Take unibyte characters from pattern
3661 literally. (Bug#9458)
3662
9bade7b2
EZ
36632011-09-18 Eli Zaretskii <eliz@gnu.org>
3664
3665 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3666
e5e9d610
PE
36672011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3668
87e4427a
PE
3669 Fix minor problem found by static checking.
3670 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3671 initialized, to pacify gcc -Wuninitialized.
3672
e5e9d610
PE
3673 * fileio.c: Report proper errno when syscall falls.
3674 (Finsert_file_contents): Save and restore errno,
3675 so that report_file_error outputs the correct diagnostic.
3676 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3677
a1674f0b
EZ
36782011-09-18 Eli Zaretskii <eliz@gnu.org>
3679
3680 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3681
fbfb6dd4
EZ
36822011-09-17 Eli Zaretskii <eliz@gnu.org>
3683
3684 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3685 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3686
bb187662
EZ
36872011-09-17 Eli Zaretskii <eliz@gnu.org>
3688
1137e8b8 3689 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3690 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3691
3692 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3693 (bidi_find_paragraph_start): Search back for paragraph beginning
3694 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3695 (bidi_move_to_visually_next): Only trigger paragraph-related
3696 computations when the last character is a newline or at EOB, not
3697 just any NEUTRAL_B. (Bug#9470)
3698
bb187662
EZ
3699 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3700 truncated lines if point is covered by a display string. (Bug#9524)
3701
2e621251
PE
37022011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3705 (cons_to_x_long): New function.
3706 (lisp_data_to_selection_data): Use it. Correct the test for
3707 short-versus-long data; it was negated. Break out of vector
3708 loop, for efficiency, when a long datum is discovered.
3709
91a15bc6
SM
37102011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3711
3712 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3713
b41c3a35
EZ
37142011-09-16 Eli Zaretskii <eliz@gnu.org>
3715
3716 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3717 GCC PR/17406) by declaring this function with external scope.
3718
7812ba2d
PE
37192011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3720
3721 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3722 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3723
cf7edc2a
AS
37242011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3725
3726 * editfns.c (Fformat): Correctly handle text properties on "%%".
3727
bd01620e
EZ
37282011-09-15 Eli Zaretskii <eliz@gnu.org>
3729
3730 * xterm.c (x_draw_composite_glyph_string_foreground):
3731 * w32term.c (x_draw_composite_glyph_string_foreground):
3732 * term.c (encode_terminal_code):
3733 * composite.c (composition_update_it, get_composition_id):
3734 * xdisp.c (get_next_display_element)
3735 (fill_composite_glyph_string): Add comments about special meaning
3736 of TAB characters in a composition.
3737
a02719a3
PE
37382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3741 This occurs when processing a multibyte format.
3742 Problem reported by Wolfgang Jenker.
a02719a3 3743
72589a3c
JB
37442011-09-15 Johan Bockgård <bojohan@gnu.org>
3745
3746 * xdisp.c (try_cursor_movement): Only check for exact match if
3747 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3748
1c14176c
PE
37492011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3750
3751 Remove unused external symbols.
3752 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3753 * xdisp.c (calc_pixel_width_or_height): Now static.
3754 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3755 * indent.c (check_display_width):
3756 * w32term.c: Fix comment to match code.
3757 * xterm.c, xterm.h (x_catching_errors): Remove.
3758
d2eea5b5
PE
37592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3760
3761 * xselect.c: Use signed conversions more consistently (Bug#9498).
3762 (selection_data_to_lisp_data): Assume incoming selection data are
3763 signed integers, not unsigned. This is to be consistent with
3764 outgoing selection data, which was modified to use signed integers
3765 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3766 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3767 expects long, not unsigned long.
3768
46888499
EZ
37692011-09-14 Eli Zaretskii <eliz@gnu.org>
3770
3771 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3772 computation of loop end. Reported by Johan Bockgård
3773 <bojohan@gnu.org>.
3774
ef8ef9fb
CY
37752011-09-13 Chong Yidong <cyd@stupidchicken.com>
3776
3777 * frame.c (Fother_visible_frames_p): Function deleted.
3778
fa819fed
EZ
37792011-09-12 Eli Zaretskii <eliz@gnu.org>
3780
3781 * indent.c (compute_motion): Process display vector front to back
3782 rather than the other way around. (Bug#2496)
3783
2ba8e008
SM
37842011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3785
3786 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3787
20f53c69
CY
37882011-09-11 Chong Yidong <cyd@stupidchicken.com>
3789
3790 * minibuf.c (Fread_from_minibuffer): Doc fix.
3791
d562d7a4
EZ
37922011-09-11 Eli Zaretskii <eliz@gnu.org>
3793
3794 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3795 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3796
1c4d7f3d
LMI
37972011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3798
3799 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3800 value for non-existent files.
3801
b885bf36
EZ
38022011-09-11 Eli Zaretskii <eliz@gnu.org>
3803
3804 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3805 set its "size" to -1. This will set the modtime_size field of
3806 the corresponding buffer to -1, which is what
3807 verify-visited-file-modtime expects for files that do not exist.
3808 (Bug#9139)
3809
6612f0bf
PE
38102011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3813 here ...
3814 * lisp.h: ... from here. push_key_description is no longer
3815 defined in keyboard.c, so its declaration should not be in
3816 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3817 logically belongs with push_key_description.
3818
dfb3f755
PE
38192011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3820
3821 * buffer.h: Include <sys/types.h> instead of <time.h>.
3822 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3823 Problem reported by Herbert J. Skuhra.
3824
3134906c
LMI
38252011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3826
3827 * xml.c (parse_region): Make the parsing work for
3828 non-comment-starting XML files again (bug#9144).
3829
8d903f4e
AS
38302011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3831
3832 * image.c (gif_load): Fix calculation of bottom and right corner.
3833 (Bug#9468)
3834
80ad64f4
EZ
38352011-09-10 Eli Zaretskii <eliz@gnu.org>
3836
3837 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3838 redisplay in small windows.
3839
208a048d
EZ
38402011-09-09 Eli Zaretskii <eliz@gnu.org>
3841
3842 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3843
9b1c252e
MR
38442011-09-08 Martin Rudalics <rudalics@gmx.at>
3845
3846 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3847 Operate on live windows only.
3848
2949f33b
JB
38492011-09-08 Juanma Barranquero <lekktu@gmail.com>
3850
3851 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3852
e08dcafd
EZ
38532011-09-07 Eli Zaretskii <eliz@gnu.org>
3854
3855 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3856 only under bidi iteration.
3857
115b96bd
JD
38582011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3859
3860 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3861
c8199d0f
PE
38622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3865 Without this fix, the command to link temacs failed due to an
3866 undefined symbol __builtin_isnan. This is because
3867 /usr/include/iso/math_c99.h #defines isnan(x) to
3868 __builtin_isnan(x), but the bundled gcc, which identifies itself
3869 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3870 a __builtin_isnan.
3871 * floatfns.c (isnan): #undef, and then #define to a clone of
3872 what's in data.c.
3873 (Fisnan): Always define, since it's always available now.
3874 (syms_of_floatfns): Always define isnan at the Lisp level.
3875
e39b275c 38762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3877
3878 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3879
b2db44d9 38802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3881
f4af5137 3882 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3883 The previous code assumed that file offsets (off_t values) fit in
3884 EMACS_INT variables, which is not true on typical 32-bit hosts.
3885 The code messed up by falsely reporting buffer overflow in cases
3886 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3887 when "big" contains more than 2**29 bytes, even though this
3888 inserts just one byte and does not overflow the buffer.
3889 (Finsert_file_contents): Store file offsets as off_t
3890 values, not as EMACS_INT values. Check for overflow when
3891 converting between EMACS_INT and off_t. When checking for
3892 buffer overflow or for overlap, take the offsets into account.
3893 Don't use EMACS_INT for small values where int suffices.
3894 When checking for overlap, fix a typo: ZV was used where
3895 ZV_BYTE was intended.
3896 (Fwrite_region): Don't assume off_t fits into 'long'.
3897 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3898
ecfc0a49
MA
38992011-09-05 Michael Albinus <michael.albinus@gmx.de>
3900
3901 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3902
6511acf2 39032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3904
0999621a 3905 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3906
3907 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3908 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3909 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3910 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3911 (modify_event_symbol): Do not assume that the length of
3912 name_alist_or_stem is safe to alloca and fits in int.
3913 (Fexecute_extended_command): Likewise for function name and binding.
3914 (Frecursion_depth): Wrap around reliably on integer overflow.
3915 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3916 since some callers pass EMACS_INT values.
3917 (Fsingle_key_description): Don't crash if symbol name contains more
3918 than MAX_ALLOCA bytes.
3919 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3920 (get_minibuffer): Arg is now EMACS_INT, not int.
3921 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3922 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3923 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3924
2be7d702
PE
3925 * dbusbind.c (signature_cat): New function.
3926 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3927 Do not overrun buffer; instead, report string overflow.
3928
9d1df220
PE
3929 * dispnew.c (add_window_display_history): Don't overrun buffer.
3930 Truncate instead; this is OK since it's just a log.
3931
33ef5c64
PE
3932 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3933 even if the time zone offset is outlandishly large.
3934 Don't mishandle offset == INT_MIN.
3935
66c6fdd5
PE
3936 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3937 when creating daemon; the previous buffer-overflow check was incorrect.
3938
d749b01b
PE
3939 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3940 which has the guts of the old verror function.
3941
b5cd1905
PE
3942 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3943 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3944
6e1a67fb
PE
3945 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3946 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3947 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3948 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3949 length of string rather than counting it via multiple sprintfs;
3950 that's simpler and more reliable.
c21721cc
PE
3951 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3952 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3953 sprintf, in case result does not fit in int.
3954
c57b67fc
PE
3955 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3956 (fontset_from_font): Print it.
3957
8a401434
PE
3958 * frame.c (tty_frame_count): Now printmax_t, not int.
3959 (make_terminal_frame, set_term_frame_name): Print it.
3960 (x_report_frame_params): In X, window IDs are unsigned long,
3961 not signed long, so print them as unsigned.
3962 (validate_x_resource_name): Check for implausibly long names,
3963 and don't assume name length fits in 'int'.
3964 (x_get_resource_string): Don't blindly alloca invocation name;
3965 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3966 not fit in int.
3967
6e1a67fb
PE
3968 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3969 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3970 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3971
0df02bf3
PE
3972 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3973 Use esprintf, not sprintf, in case result does not fit in int.
3974
48e30793
PE
3975 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3976 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3977 it as a large positive number.
3978 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3979 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3980
a66ff6d8
PE
3981 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3982 in case result does not fit in int.
3983
aca216ff
PE
3984 * print.c (float_to_string): Detect width overflow more reliably.
3985 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3986 buffer overrun. Don't assume list length fits in 'int'. Treat
3987 print length of 0 as 0, not as infinity; to be consistent with other
3988 uses of print length in this function. Don't overflow print length
3989 index. Don't assume hash table size fits in 'long', or that
3990 vectorlike size fits in 'unsigned long'.
3991
31c286f7
PE
3992 * process.c (make_process): Use printmax_t, not int, to format
3993 process-name gensyms.
3994
55e5faa1
PE
3995 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3996
80f2e268
PE
3997 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3998 to avoid potential buffer overrun.
3999
670741ab
PE
4000 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4001 if X resource line is longer than 512 bytes.
4002
b7163a50
PE
4003 * xfns.c (x_window): Make sprintf buffer a bit bigger
4004 to avoid potential buffer overrun.
4005
ae58ff1f
PE
4006 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4007
c43c8a6a
PE
4008 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4009
3f8236f4
PE
40102011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4011
53e9fe90 4012 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4013 Without these, Emacs silently mishandles large integers sometimes.
4014 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4015 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4016
6511acf2
PE
4017 * xdisp.c (try_window_id): Check Emacs fixnum range before
4018 converting to 'int'.
806add1d 4019
6511acf2 4020 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4021 Check that an Emacs fixnum is in range before assigning it to 'int'.
4022 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4023 values converted from Emacs fixnums.
4024 (Frecenter): Don't wrap around a line count if it is out of 'int'
4025 range; instead, treat it as an extreme value.
4026 (Fset_window_configuration, compare_window_configurations):
4027 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4028
6511acf2
PE
4029 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4030 that can exceed INT_MAX. Check that EMACS_INT value is in range
4031 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4032 (match_limit): Don't assume that a fixnum can fit in 'int'.
4033
6511acf2 4034 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4035 exceed INT_MAX.
4036
6511acf2 4037 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4038 (Fvertical_motion): Don't wrap around LINES values that don't fit
4039 in 'int'. Instead, treat them as extreme values. This is good
4040 enough for windows, which can't have more than INT_MAX lines anyway.
4041
fcb901a7
LMI
40422011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4043
0f2f6b6d
LMI
4044 * Require libxml/parser.h to avoid compilation warning.
4045
fcb901a7
LMI
4046 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4047
4048 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4049 since this reportedly can destroy thread storage.
4050
6e20a0d4
CY
40512011-08-30 Chong Yidong <cyd@stupidchicken.com>
4052
4053 * syntax.c (find_defun_start): Update all cache variables if
4054 exiting early (Bug#9401).
4055
148ae00e
EZ
40562011-08-30 Eli Zaretskii <eliz@gnu.org>
4057
f6cfbd8f
EZ
4058 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4059
148ae00e
EZ
4060 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4061 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4062 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4063
4064 * term.c (tty_append_glyph): New function.
4065 (produce_stretch_glyph): Static function and its prototype deleted.
4066
a66cfb1c
SM
4067 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4068 Add prototypes.
148ae00e 4069
c4a07a4c
PE
40702011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4071
4072 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4073 when checking :margin (Bug#9390).
4074 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4075 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4076 so that the name doesn't mislead. All uses changed.
4077
6bc8cd65
JB
40782011-08-28 Johan Bockgård <bojohan@gnu.org>
4079
4080 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4081 set_tty_hooks.
4082
dca4927e
EZ
40832011-08-27 Eli Zaretskii <eliz@gnu.org>
4084
4085 * xdisp.c (move_it_to): Don't bail out early when reaching
4086 position beyond to_charpos, if we are scanning backwards.
4087 (move_it_vertically_backward): When DY == 0, make sure we get to
4088 the first character in the line after the newline.
4089
f2cad773
PE
40902011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4091
4092 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4093 (ccl_driver): Do not generate an out-of-range pointer.
4094 (Fccl_execute_on_string): Remove unnecessary check for
4095 integer overflow, noted by Stefan Monnier in
4096 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4097 Remove a FIXME that didn't need fixing.
4098 Simplify the newly-introduced buffer reallocation code.
4099
0cae2cdb
JB
41002011-08-27 Juanma Barranquero <lekktu@gmail.com>
4101
4102 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4103
5fc295a4 41042011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4105
70c60eb2 4106 Integer and memory overflow issues (Bug#9196).
726e0ab1 4107
d31850da
PE
4108 * doc.c (get_doc_string): Rework so that
4109 get_doc_string_buffer_size is the actual buffer size, rather than
4110 being 1 less than the actual buffer size; this makes xpalloc more
4111 convenient.
4112
a69fbedb
PE
4113 * image.c (x_allocate_bitmap_record, cache_image):
4114 * xselect.c (Fx_register_dnd_atom):
4115 Simplify previous changes by using xpalloc.
4116
fe5c5d37
PE
4117 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4118 since either will do and ptrdiff_t is convenient with xpalloc.
4119
0065d054
PE
4120 * charset.c (charset_table_size)
4121 (struct charset_sort_data.priority): Now ptrdiff_t.
4122 (charset_compare): Don't overflow if priorities differ greatly.
4123 (Fsort_charsets): Don't assume list length fits in int.
4124 Check for size-calculation overflow when allocating sort data.
4125 (syms_of_charset): Allocate an initial charset table that is
4126 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4127
4128 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4129
4130 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4131 The actual value is always <= INT_MAX, and leaving it unsigned made
4132 overflow checking harder.
4133
4134 * dispextern.h (struct glyph_matrix.rows_allocated)
4135 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4136 with xpalloc. The values are still always <= INT_MAX.
4137
4138 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4139
4140 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4141 (SAFE_NALLOCA): New macro.
4142
4143 * region-cache.c (struct boundary.pos, find_cache_boundary)
4144 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4145 (set_cache_region, invalidate_region_cache)
4146 (revalidate_region_cache, know_region_cache, region_cache_forward)
4147 (region_cache_backward, pp_cache):
4148 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4149 so that ptrdiff_t * can be passed to xpalloc.
4150 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4151 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4152 (pp_cache): Don't assume cache_len fits in int.
4153 * region-cache.h: Adjust extern decls to match.
4154
4155 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4156 EMACS_INT, since either will do, for xpalloc.
4157
4158 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4159 (xnmalloc, xnrealloc, xpalloc): New functions.
4160
726e0ab1
PE
4161 * bidi.c (bidi_shelve_header_size): New constant.
4162 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4163 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4164
51f30bc5 4165 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4166 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4167 (overlay_strings):
4168 Don't update size of array until after memory allocation succeeds,
4169 because xmalloc/xrealloc may not return.
0065d054
PE
4170 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4171 now that we have proper integer overflow checking.
4172 (record_overlay_string, overlay_strings): Catch overflows when
4173 calculating size of overlay_str_buf.
726e0ab1 4174
0065d054
PE
4175 * callproc.c (Fcall_process): Check for size overflow when
4176 calculating size of args2.
4177 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4178 Normally we prefer signed values, but sticking with ptrdiff_t would
4179 require adding more-complicated checks.
726e0ab1
PE
4180
4181 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4182 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4183 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4184 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4185
4186 * character.c (Fstring): Check for size-calculation overflow.
4187
4188 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4189 unnecessary integer overflow. Check for size overflow.
4190 (encode_coding_object): Don't update size until xmalloc succeeds.
4191
4192 * composite.c (get_composition_id): Check for overflow in glyph
4193 length calculations.
4194
4195 Integer and memory overflow fixes for display code.
4196 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4197 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4198 (scrolling_window): Check for overflow in size calculations.
4199 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4200 Don't assume glyph table len fits in int.
4201 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4202 (row_table_size): Now ptrdiff_t, not int.
4203 (scrolling_window): Avoid overflow in size calculations.
4204 Don't update size until allocation succeeds.
4205 * fns.c (concat): Check for overflow in size calculations.
4206 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4207 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4208 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4209
4210 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4211 (get_doc_string): Check for size calculation overflow.
4212 Don't update size until allocation succeeds.
4213 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4214 EMACS_INT, where ptrdiff_t will do.
4215 (Fsubstitute_command_keys): Check for string overflow.
4216
4217 * editfns.c (set_time_zone_rule): Don't assume environment length
4218 fits in int.
4219 (message_length): Now ptrdiff_t, not int.
4220 (Fmessage_box): Don't update size until allocation succeeds.
4221 Don't assume message length fits in int.
4222 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4223
0065d054
PE
4224 * emacs.c (main): Do not reallocate argv, since there is a null at
4225 the end that can be overwritten, and this way there's no need to
4226 worry about size-calculation overflow.
4227 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4228
4229 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4230 alloc succeeds.
4231 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4232
4233 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4234 (x_set_scroll_bar_width, x_figure_window_size):
4235 Check for integer overflow.
4236 (x_set_alpha): Do not assume XINT fits in int.
4237
4238 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4239 This is for the members text_lines, text_cols, total_lines, total_cols,
4240 where the system imposes an 'int' limit.
4241
4242 * fringe.c (Fdefine_fringe_bitmap):
4243 Don't update size until alloc works.
4244
4245 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4246 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4247
4248 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4249 Check for size-calculation overflow.
4250 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4251 do, as we prefer signed integers.
4252 (id_to_widget.max_size, id_to_widget.used)
4253 (xg_store_widget_in_map, xg_remove_widget_from_map)
4254 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4255 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4256 Use and return ptrdiff_t, not int.
4257 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4258 * gtkutil.h: Change prototypes to match the above.
4259
4260 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4261 are duplicate now that they've been promoted to lisp.h.
4262 (x_allocate_bitmap_record, x_alloc_image_color)
4263 (make_image_cache, cache_image, xpm_load):
4264 Don't update size until alloc is done.
4265 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4266 (x_detect_edges):
3256efce 4267 Check for size calculation overflow.
726e0ab1
PE
4268 (ct_colors_allocated_max): New constant.
4269 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4270 overflow.
3256efce 4271
726e0ab1
PE
4272 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4273 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4274 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4275 Use ptrdiff_t, not int, to count maps.
4276 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4277 calculations. Don't update size until allocation succeeds.
4278 Redo calculations to avoid overflow.
726e0ab1
PE
4279 * keyboard.h: Change prototypes to match the above.
4280
4281 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4282 to count maps.
4283 (current_minor_maps): Check for size calculation overflow.
4284 * keymap.h: Change prototypes to match the above.
4285
4286 * lread.c (read1, init_obarray): Don't update size until alloc done.
4287
4288 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4289 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4290
726e0ab1
PE
4291 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4292 Now ptrdiff_t, not int.
4293 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4294 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4295
4296 * process.c (Fnetwork_interface_list): Check for overflow
4297 in size calculation.
4298
4299 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4300
4301 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4302 overflow. Don't bother calling xmalloc when xrealloc will do.
4303
4304 * search.c (Freplace_match): Check for size calculation overflow.
4305 (Fset_match_data): Don't assume list lengths fit in 'int'.
4306
4307 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4308 for command line length. Do not attempt to address one before the
4309 beginning of an array, as that's not portable.
4310
4311 * term.c (max_frame_lines): Remove; unused.
4312 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4313 not int.
4314 (encode_terminal_code, calculate_costs): Check for size
4315 calculation overflow.
4316 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4317 table lengths and related sizes. Don't update size until alloc
4318 done. Redo calculations to avoid overflow.
4319 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4320
4321 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4322 subtracting pointers.
4323 (gobble_line): Check for overflow more carefully. Don't update size
4324 until alloc done.
4325
4326 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4327 Don't update size until alloc done.
4328 Redo size calculations to avoid overflow.
4329 Check for size calculation overflow.
0065d054 4330 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4331
4332 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4333 Use ptrdiff_t, not int, for sizes.
4334 (store_mode_line_noprop_char): Don't update size until alloc done.
4335
0065d054
PE
4336 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4337 Use ptrdiff_t, not int, for sizes.
4338 (Finternal_make_lisp_face, cache_face):
4339 Check for size calculation overflow.
4340 (cache_face): Treat size calculation overflows as if they were
4341 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4342
4343 * xfns.c (x_encode_text, x_set_name_internal)
4344 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4345 sizes, since they can exceed INT_MAX in size. Check for size
4346 calculation overflow.
4347
0065d054
PE
4348 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4349 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4350 Don't update size until alloc done.
4351
0065d054 4352 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4353 as sprintf is limited to int lengths.
1d526e2f 4354
252c5ee1
PE
4355 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4356 (X_LONG_MIN): New macros.
864d7ce7
PE
4357 Use them to make the following changes clearer.
4358 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4359 This change doesn't affect the value now, but it may help remind
4360 future maintainers not to raise the value too much later.
4361 (SELECTION_QUANTUM): Remove, replacing with ...
4362 (selection_quantum): ... new function, which avoids overflow.
4363 All uses changed.
4364 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4365 assumption that selection length fits in 'int'.
4366 (x_reply_selection_request, x_handle_selection_request)
4367 (x_get_window_property, receive_incremental_selection)
4368 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4369 (lisp_data_to_selection_data, clean_local_selection_data):
4370 Use ptrdiff_t, not int, to record length of selection.
4371 (x_reply_selection_request, x_get_window_property)
4372 (receive_incremental_selection, x_property_data_to_lisp):
4373 Redo calculations to avoid overflow.
4374 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4375 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4376 something.
4377 (x_get_window_property, receive_incremental_selection)
4378 (lisp_data_to_selection_data, x_property_data_to_lisp):
4379 Check for size-calculation overflow.
4380 (x_get_window_property, receive_incremental_selection)
4381 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4382 Don't store size until memory allocation succeeds.
4383 (x_get_window_property): Plug memory leak on memory exhaustion.
4384 Don't double-block input; malloc is safe here. Don't assume 2**34
4385 - 4 fits in unsigned long. Add an xassert to check
4386 XGetWindowProperty overflow. Be more careful about overflow
4387 calculations, and distinguish size from memory overflow better.
4388 (receive_incremental_selection): When tracing, don't assume
4389 unsigned int is less than INT_MAX.
4390 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4391 harmful) conversions of unsigned short to int.
4392 (lisp_data_to_selection_data): Don't assume that integers
4393 in the range -65535 through -1 fit in an X unsigned short.
4394 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4395 result parameters unless successful. Rely on cons_to_unsigned
4396 to report problems with elements; the old code wasn't right anyway.
4397 (x_check_property_data): Check for int overflow; we cannot use
4398 a wider type due to X limits.
4399 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4400
726e0ab1 4401 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4402
0065d054
PE
4403 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4404 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4405 (x_color_cells): Don't store size until memory allocation succeeds.
4406 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4407 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4408 (x_term_init): Don't assume length fits in int (sprintf is limited
4409 to int size).
bc18e09d 4410
ebfa62c0
PE
4411 Use ptrdiff_t for composition IDs.
4412 * character.c (lisp_string_width):
4413 * composite.c (composition_table_size, n_compositions)
4414 (get_composition_id, composition_gstring_from_id):
4415 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4416 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4417 * window.c (Frecenter):
4418 Use ptrdiff_t, not int, for composition IDs.
4419 * composite.c (get_composition_id): Check for integer overflow.
4420 * composite.h: Adjust prototypes to match the above changes.
4421
d3411f89
PE
4422 Use ptrdiff_t for hash table indexes.
4423 * category.c (hash_get_category_set):
4424 * ccl.c (ccl_driver):
4425 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4426 * coding.c (coding_system_charset_list, detect_coding_system):
4427 * coding.h (struct coding_system.id):
4428 * composite.c (get_composition_id, gstring_lookup_cache):
4429 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4430 * image.c (xpm_get_color_table_h):
4431 * lisp.h (hash_lookup, hash_put):
4432 * minibuf.c (Ftest_completion):
4433 Use ptrdiff_t for hash table indexes, not int (which is too
4434 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4435 32-bit --with-wide-int hosts).
4436
e097a6fa
PE
4437 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4438 Add a FIXME comment about memory leaks.
4439 (syms_of_charset): Don't assume xmalloc returns.
4440
5637687f
PE
4441 Don't assume that stated character widths fit in int.
4442 * character.c (Fchar_width, c_string_width, lisp_string_width):
4443 * character.h (CHAR_WIDTH):
4444 * indent.c (MULTIBYTE_BYTES_WIDTH):
4445 Use sanitize_char_width to avoid undefined and/or bad behavior
4446 with outlandish widths.
a66cfb1c 4447 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4448 now that we have two such functions. All uses changed.
4449 (sanitize_char_width): New inline function.
4450
a2271ba2
PE
4451 Don't assume that tab-width fits in int.
4452 * character.h (sanitize_width): New inline function.
4453 (SANE_TAB_WIDTH): New macro.
4454 (ASCII_CHAR_WIDTH): Use it.
4455 * indent.c (sane_tab_width): Remove. All uses replaced by
4456 SANE_TAB_WIDTH (current_buffer).
4457 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4458
18c52557
PE
4459 * fileio.c: Integer overflow issues with file modes.
4460 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4461
caeeedc1
PE
4462 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4463 Remove unreachable code.
4464 (read_hex, load_charset_map_from_file): Check for integer overflow.
4465
6df6ae42 4466 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4467 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4468 (x_send_scroll_bar_event): Likewise. Check that the size does not
4469 exceed limits imposed by XClientMessageEvent, as well as the usual
4470 ptrdiff_t and size_t limits.
4471
b13995db
PE
4472 * keyboard.c: Overflow, signedness and related fixes.
4473 (make_lispy_movement): Use same integer type in forward decl
4474 that is used in the definition.
4475 (read_key_sequence, keyremap_step):
4476 Change bufsize argument back to int, undoing my 2011-03-30 change.
4477 We prefer signed types, and int is wide enough here.
4478 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4479 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4480 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4481 length, not size_t. Use ptrdiff_t for index, not int.
4482 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4483 possibility of integer overflow.
4484
13464394
PE
4485 Overflow, signedness and related fixes for images.
4486
4487 * dispextern.h (struct it.stack[0].u.image.image_id)
4488 (struct_it.image_id, struct image.id, struct image_cache.size)
4489 (struct image_cache.used, struct image_cache.ref_count):
4490 * gtkutil.c (update_frame_tool_bar):
4491 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4492 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4493 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4494 * nsmenu.m (update_frame_tool_bar):
4495 * xdisp.c (calc_pixel_width_or_height):
4496 * xfns.c (image_cache_refcount):
4497 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4498 on typical 64-bit hosts.
4499
4500 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4501 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4502 Omit unnecessary casts to int.
4503 (parse_image_spec): Check that integers fall into 'int' range
4504 when the callers expect that.
4505 (image_ascent): Redo ascent calculation to avoid int overflow.
4506 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4507 (lookup_image): Remove unnecessary tests.
4508 (xbm_image_p): Locals are now of int, not EMACS_INT,
4509 since parse_image_check makes sure they fit into int.
4510 (png_load, gif_load, svg_load_image):
4511 Prefer int to unsigned where either will do.
4512 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4513 old tiff_error_handler and tiff_warning_handler.
4514 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4515 stack buffer overflows. It uses only the features of vsnprintf
4516 that are common to both POSIX and native Microsoft.
4517 (tiff_error_handler, tiff_warning_handler): Use it.
4518 (tiff_load, gif_load, imagemagick_load_image):
4519 Don't assume :index value fits in 'int'.
4520 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4521 (imagemagick_load_image): Check that crop parameters fit into
4522 the integer types that MagickCropImage accepts. Don't assume
4523 Vimagemagick_render_type has a nonnegative value. Don't assume
4524 size_t fits in 'long'.
4525 (gs_load): Use printmax_t to print the widest integers possible.
4526 Check for integer overflow when computing image height and width.
4527
c11821d4
EZ
45282011-08-26 Eli Zaretskii <eliz@gnu.org>
4529
4530 * xdisp.c (redisplay_window): Don't force window start if point
4531 will be invisible in the resulting window. (Bug#9324)
4532
0c95fcf7
EZ
45332011-08-25 Eli Zaretskii <eliz@gnu.org>
4534
4535 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4536 the display spec is of the form `(space ...)'.
4537 (handle_display_spec): Return the value returned by
4538 handle_single_display_spec, not just 1 or zero.
4539 (handle_single_display_spec): If the display spec is of the form
4540 `(space ...)', and specifies display in the text area, return 2
4541 rather than 1.
fee65a97 4542 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4543 accurately, and prefer exact match for point under bidi.
4544 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4545
4546 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4547 into disp_prop; all users changed.
4548
4549 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4550 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4551 for the text covered by the display property.
4552
e4ed06f1
CY
45532011-08-25 Chong Yidong <cyd@stupidchicken.com>
4554
4555 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4556 Change return value to nil.
4557 (Frecord_buffer): Delete unused function.
4558
f67cdd7f
EZ
45592011-08-24 Eli Zaretskii <eliz@gnu.org>
4560
5980d4c6
EZ
4561 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4562 buffers, return left-to-right.
8610fe8b
EZ
4563 (set_cursor_from_row): Consider candidate row a win if its glyph
4564 represents a newline and point is on that newline. Fixes cursor
4565 positioning on the newline at EOL of R2L text within L2R
4566 paragraph, and vice versa.
4567 (try_cursor_movement): Check continued rows, in addition to
4568 continuation rows. Fixes unwarranted scroll when point enters a
4569 continued line of R2L text within an L2R paragraph, or vice versa.
4570 (cursor_row_p): Consider the case of point being equal to
4571 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4572 from the end of a short line to the beginning of a continued line
4573 of R2L text within L2R paragraph.
4574 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4575 composed characters.
5980d4c6 4576
f67cdd7f
EZ
4577 * bidi.c (bidi_check_type): Use xassert.
4578 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4579 members.
4580
bca633fb
EZ
45812011-08-23 Eli Zaretskii <eliz@gnu.org>
4582
4583 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4584 a character.
4585
4a5885a7
CY
45862011-08-23 Chong Yidong <cyd@stupidchicken.com>
4587
4588 * nsfont.m (ns_otf_to_script): Fix typo.
4589
0902a04e
KH
45902011-08-22 Kenichi Handa <handa@m17n.org>
4591
4592 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4593 extra slot even if the purpose is char-code-property-table.
4594
1a2e6670
EZ
45952011-08-23 Eli Zaretskii <eliz@gnu.org>
4596
8ddde651
EZ
4597 * xdisp.c (redisplay_window): When computing centering_position,
4598 account for the height of the header line. (Bug#8874)
4599
425cc014
EZ
4600 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4601 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4602 candidate is selected by the mouse, and that candidate has a
4603 composed character under the mouse.
4604
1a2e6670
EZ
4605 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4606 coordinates reported by pos-visible-in-window-p for a composed
4607 character in column zero.
4608
8b76d6f8
SM
46092011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4610
4611 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4612
dac347dd
EZ
46132011-08-22 Eli Zaretskii <eliz@gnu.org>
4614
4615 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4616 consider it a hit if to_charpos is anywhere in the range of the
4617 composed buffer positions.
4618
e013fb34
CY
46192011-08-22 Chong Yidong <cyd@stupidchicken.com>
4620
4621 * image.c (gif_load): Don't assume that each subimage has the same
4622 dimensions as the base image. Handle disposal method that is
4623 "undefined" by the gif spec (Bug#9335).
4624
bd1ba3e8
CY
46252011-08-20 Chong Yidong <cyd@stupidchicken.com>
4626
4627 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4628 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4629
54a1215b
EZ
46302011-08-19 Eli Zaretskii <eliz@gnu.org>
4631
823564e5
EZ
4632 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4633 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4634 from an Org mode buffer to a Speedbar frame.
4635
54a1215b
EZ
4636 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4637 a composition, take its buffer position from IT->cmp_it.charpos.
4638 Fixes cursor positioning at the beginning of a line that begins
4639 with a composed character.
4640
9778ebcc
EZ
46412011-08-18 Eli Zaretskii <eliz@gnu.org>
4642
0be6ee06
EZ
4643 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4644 character bidirectional type, use STRONG_L instead. Fixes crashes
4645 in a buffer produced by `describe-categories'.
4646
9778ebcc
EZ
4647 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4648 members before the level stack, so they would be saved and
4649 restored when copying iterator state. Fixes incorrect reordering
4650 around TABs covered by display properties.
4651
156bffbe
AS
46522011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4653
6b02f655 4654 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4655
72ad093b
CY
46562011-08-17 Chong Yidong <cyd@stupidchicken.com>
4657
4658 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4659 (internal_condition_case_2, internal_condition_case_n):
4660 Remove unnecessary aborts (Bug#9081).
72ad093b 4661
35774242
EZ
46622011-08-17 Eli Zaretskii <eliz@gnu.org>
4663
4664 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4665 has no `load' handler, try opening the file locally. (Bug#9311)
4666
db76dd85
KB
46672011-08-16 Ken Brown <kbrown@cornell.edu>
4668
4669 * gmalloc.c: Expand comment.
4670
b215eee5
EZ
46712011-08-16 Eli Zaretskii <eliz@gnu.org>
4672
4673 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4674 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4675
a4579d33
KB
46762011-08-16 Ken Brown <kbrown@cornell.edu>
4677
4678 Fix memory allocation problems in Cygwin build (Bug#9273).
4679
4680 * unexcw.c ( __malloc_initialized): Declare external variable.
4681 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4682
8b76d6f8
SM
4683 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4684 New variables.
a4579d33
KB
4685 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4686 dumped emacs.
4687 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4688 in the static heap.
4689 [CYGWIN] (special_realloc): New function.
4690 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4691 requests to realloc storage in the static heap.
4692
3ebec551
PE
46932011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4694
4695 * bidi.c (bidi_initialize): Remove unused local.
4696
9fd8be00
EZ
46972011-08-15 Eli Zaretskii <eliz@gnu.org>
4698
6b02f655
SM
4699 * bidimirror.h:
4700 * biditype.h: Remove file.
4701 * makefile.w32-in ($(BLD)/bidi.$(O)):
4702 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4703
4704 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4705
4706 * chartab.c: Improve commentary for the uniprop_table API.
4707
32413314
EZ
4708 * bidi.c (bidi_paragraph_init): Support zero value of
4709 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4710 (bidi_initialize): Use uniprop_table instead of including
4711 biditype.h and bidimirror.h.
32413314 4712
9fd8be00
EZ
4713 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4714 coordinates of the iterator when restoring from ppos_it.
4715 (Bug#9296)
4716
5cf2b69b
KH
47172011-08-14 Kenichi Handa <handa@m17n.org>
4718
4719 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4720 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4721
daf17d00
EZ
47222011-08-14 Eli Zaretskii <eliz@gnu.org>
4723
4724 * xdisp.c (move_it_in_display_line_to): Don't invoke
4725 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4726 ppos_it. Fixes vertical cursor motion when line beginning is
4727 covered by an image. (Bug#9296)
4728
08e3161a
JD
47292011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4730
4731 * nsterm.h (ns_run_ascript): Declare.
4732 (NSAPP_DATA2_RUNASSCRIPT): Define.
4733
4734 * nsfns.m (as_script, as_result, as_status): New static variables.
4735 (ns_run_ascript): New function.
5e617bc2 4736 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4737 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4738 the event loop. Get status from as_status (Bug#7276).
4739
4740 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4741 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4742 the event loop (Bug#7276).
4743
a3720aa2
AS
47442011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4745
4746 * gnutls.c (QCgnutls_bootprop_priority)
4747 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4748 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4749 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4750 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4751 (QCgnutls_bootprop_verify_hostname_error)
4752 (QCgnutls_bootprop_callbacks_verify): Rename from
4753 Qgnutls_bootprop_..., all uses changed.
4754
4755 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4756 uses changed.
4757
0a0d27fb
PE
47582011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4759
19d5c50c
PE
4760 * xfaces.c (Qframe_set_background_mode): Now static.
4761 * dispextern.h (Qframe_set_background_mode): Remove decl.
4762
0a0d27fb
PE
4763 * process.c (Fnetwork_interface_info): Declare local only if needed.
4764
377538cb
JD
47652011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4766
4767 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4768 (Fnetwork_interface_list): Allocate in increments of bytes instead
4769 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4770 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4771 sockaddr.
4772 (struct ifflag_def): notrailers is smart on OSX.
4773 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4774 Get hardware address with getifaddrs if available.
4775
08fff70c
EZ
47762011-08-12 Eli Zaretskii <eliz@gnu.org>
4777
4778 * xdisp.c (iterate_out_of_display_property): xassert that
4779 IT->position is set to within IT->object's boundaries. Break from
4780 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
4781 when IT->position is set up wrongly due to some bug.
4782 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
4783 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4784 entry. Force push_it to save on the stack the current
4785 buffer/string position, to be restored by pop_it. Fix flags in
4786 the iterator structure wrt the object coming from a display
4787 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4788 properties. (Bug#9284)
4789
7be1c708 47902011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 4791
7be1c708
CY
4792 * fontset.c (fontset_get_font_group): Add proper type checks.
4793 (Bug#9172)
aac0c6e3 4794
7be1c708 47952011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 4796
7be1c708
CY
4797 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4798 and LC_VERSION_MIN_MACOSX.
4799 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4800 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 4801
97bb72a6
EZ
48022011-08-08 Eli Zaretskii <eliz@gnu.org>
4803
4804 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
4805 no-display-properties-and-no-overlays under bidi display.
4806 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 4807 properties and overlays.
97bb72a6 4808
d5617611
CY
48092011-08-08 Chong Yidong <cyd@stupidchicken.com>
4810
37e11a63
CY
4811 * editfns.c (Fset_time_zone_rule): Document relationship with the
4812 setenv function.
4813
d5617611
CY
4814 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4815 the font entity extracted from the cache (Bug#8109).
4816
58872834
CY
48172011-08-07 Chong Yidong <cyd@stupidchicken.com>
4818
4819 * composite.c (autocmp_chars): Don't reset point. That is done by
4820 restore_point_unwind (Bug#5984).
4821
75bfc667
JL
48222011-08-07 Juri Linkov <juri@jurta.org>
4823
4824 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4825 to show the arg `TIME' instead of `TIMEVAL'.
4826
d1410150
EZ
48272011-08-06 Eli Zaretskii <eliz@gnu.org>
4828
4829 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4830 display property strides EOL and includes a newline, as in
4831 longlines-mode. (Bug#9254)
75b771e4
EZ
4832 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4833 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4834
4835 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4836 is non-zero, even if the data buffer is NULL. Fixes a crash in
4837 vertical-motion with longlines-mode. (Bug#9254)
4838
35928349
EZ
48392011-08-05 Eli Zaretskii <eliz@gnu.org>
4840
ec7cc85b
EZ
4841 * bidi.c <bidi_cache_total_alloc>: Now static.
4842 (bidi_initialize): Initialize bidi_cache_total_alloc.
4843
8b76d6f8 4844 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4845 cache. (Bug#9221)
4846
4847 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4848 amount allocated this far in `bidi_cache_total_alloc'.
4849 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4850 non-zero, only free the data buffer without restoring the cache
4851 contents. All callers changed.
4852
4853 * dispextern.h (bidi_unshelve_cache): Update prototype.
4854
4855 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4856 (move_it_in_display_line, move_it_to)
4857 (move_it_vertically_backward, move_it_by_lines): Replace the call
4858 to xfree to an equivalent call to bidi_unshelve_cache.
4859 (move_it_in_display_line_to): Fix logic of returning
412b6358 4860 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 4861
e2e2423b
EZ
48622011-08-05 Eli Zaretskii <eliz@gnu.org>
4863
4864 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4865 came from a string character with a `cursor' property. (Bug#9229)
4866
ae9e757a
JD
48672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4868
4869 * Makefile.in (LIB_PTHREAD): New variable.
4870 (LIBES): Add LIB_PTHREAD (Bug#9216).
4871
4872 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4873 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4874
213bd7f2
AS
48752011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4876
6b02f655 4877 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4878
99aaf75f
JD
48792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4880
4881 * xterm.c (x_find_topmost_parent): New function.
4882 (x_set_frame_alpha): Find topmost parent window with
4883 x_find_topmost_parent and set the property there also (bug#9181).
4884 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4885
c74e9d86
PE
48862011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 * callproc.c (Fcall_process): Avoid vfork clobbering
4889 the local vars buffer, coding_systems, current_dir.
4890
640c8776
SM
48912011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4892
4893 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4894
f26d0e4c
PE
48952011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4896
8a10d76c
PE
4897 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4898 so that it is not optimized away.
4899
f26d0e4c
PE
4900 * xdisp.c (compute_display_string_pos): Remove unused local.
4901
55439c61
EZ
49022011-08-02 Eli Zaretskii <eliz@gnu.org>
4903
4904 Fix slow cursor motion and scrolling in large buffers with
4905 selective display, like Org Mode buffers. (Bug#9218)
4906
4907 * dispextern.h (struct bidi_it): New member disp_prop_p.
4908
4909 * xdisp.c: Remove one-slot cache of display string positions.
4910 (compute_display_string_pos): Accept an additional argument
5e617bc2 4911 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4912 for a display string or property. If found, set DISP_PROP_P
4913 non-zero.
4914
4915 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4916 DISP_PROP_P, and pass it to compute_display_string_pos.
4917 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4918 non-zero. All callers of bidi_fetch_char changed.
4919
fb33fa43
SM
49202011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4921
4922 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4923
b099e063
DM
49242010-12-03 Don March <don@ohspite.net>
4925
4926 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4927 last character M-[char] is translated to ESC [char] (bug#7541).
4928
5cc7f7af
KH
49292011-08-02 Kenichi Handa <handa@m17n.org>
4930
d0fffa3f 4931 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4932
4933 * chartab.c (uniprop_table): Make it non-static.
4934
525d5e6e
EZ
49352011-08-01 Eli Zaretskii <eliz@gnu.org>
4936
4937 * xdisp.c (forward_to_next_line_start): Accept additional argument
4938 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4939 on the newline.
4940 (reseat_at_next_visible_line_start): Use the bidi iterator state
4941 returned by forward_to_next_line_start to restore the state of
4942 it->bidi_it after backing up to previous newline. (Bug#9212)
4943
31011111
AS
49442011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4945
4946 * regex.c (re_comp): Protoize.
4947 (re_exec): Fix return type.
4948 (regexec): Fix type of `ret'. (Bug#9203)
4949
476371c4
PE
49502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4951
e5d76069
PE
4952 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4953 This is needed if max-image-size is a floating-point number.
4954
9a79b20c
AS
49552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4956
4957 * print.c (print_object): Print empty symbol as ##.
4958
4959 * lread.c (read1): Read ## as empty symbol.
4960
d8c2fa78
AA
49612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4962
4963 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4964 setting frame foreground color (Bug#9175).
4965 (x_set_background_color): Likewise.
4966
ffe57a7a
AA
4967 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4968 contents (Bug#9176).
4969 (EmacsTooltip -init): Remove bezels and add shadows to
4970 tooltip windows.
4971
bf3492a5
AA
4972 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4973 or scroll bar (Bug#8470).
4974
d55e9c53
AA
4975 * nsfont.m (nsfont_open): Remove assignment to voffset and
4976 unnecessary vars hshink, expand, hd, full_height, min_height.
4977 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4978
4979 * nsterm.h (nsfont_info): Remove voffset field.
4980
d8c2fa78 49812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4982
4983 Implement strike-through and overline on NextStep (Bug#8863).
4984
4985 * nsfont.m (nsfont_open): Use underline position provided by font,
4986 instead of hard-coded value of 2.
4987 (nsfont_draw): Call ns_draw_text_decoration instead.
4988
4989 * nsterm.h: Add declaration for ns_draw_text_decoration.
4990
4991 * nsterm.m (ns_draw_text_decoration): New function for drawing
4992 underline, overline, and strike-through.
4993 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4994 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4995 accommodate underlining, etc.
4843aac3 4996
4cc60b9b
EZ
49972011-07-28 Eli Zaretskii <eliz@gnu.org>
4998
bc7ece87
EZ
4999 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5000 default.
4cc60b9b 5001
476371c4
PE
50022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5003
66606eea
PE
5004 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5005 Without this fix, if a signal arrives just after memory fills up,
5006 'malloc' might be invoked reentrantly.
5007
476371c4
PE
5008 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5009 In other words, assume that every image size is allowed, on non-X
5010 hosts. This assumption is probably wrong, but it lets Emacs compile.
5011
f3fcc40d
AS
50122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5013
5014 * regex.c (re_iswctype): Convert return values to boolean.
5015
350c992f
EZ
50162011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5017
5018 * xdisp.c (compute_display_string_pos): Don't use cached display
5019 string position if the buffer had its restriction changed.
5020 (Bug#9184)
5021
5266b4bb
PE
50222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5025
2573a837 50262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5027
41f55ccd 5028 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5029
39e378da
PE
5030 * bidi.c: Integer size and overflow fixes.
5031 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5032 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5033 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5034 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5035 (bidi_find_other_level_edge):
5036 Use ptrdiff_t instead of EMACS_INT where either will do.
5037 This works better on 32-bit hosts configured --with-wide-int.
5038 (bidi_cache_ensure_space): Check for size-calculation overflow.
5039 Use % rather than repeated addition, for better worst-case speed.
5040 Don't set bidi_cache_size until after xrealloc returns, because it
5041 might not return.
5042 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5043 (bidi_cache_ensure_space): Also check that the bidi cache size
5044 does not exceed that of the largest Lisp string or buffer. See Eli
5045 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5046
5e927815
PE
5047 * alloc.c (__malloc_size_t): Remove.
5048 All uses replaced by size_t. See Andreas Schwab's note
5049 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5050
ca4aa935
PE
5051 * image.c: Improve checking for integer overflow.
5052 (check_image_size): Assume that f is nonnull, since
5053 it is always nonnull in practice. This is one less thing to
5054 worry about when checking for integer overflow later.
5055 (x_check_image_size): New function, which checks for integer
5056 overflow issues inside X.
5057 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5058 This removes the need for a memory_full check.
5059 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5060 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5061 (xbm_read_bitmap_data): Change locals back to 'int', since
5062 their values must fit in 'int'.
5063 (xpm_load_image, png_load, tiff_load):
5064 Invoke x_create_x_image_and_pixmap earlier,
5065 to avoid much needless work if the image is too large.
5066 (tiff_load): Treat overly large images as if
5067 x_create_x_image_and_pixmap failed, not as malloc failures.
5068 (gs_load): Use x_check_image_size.
5069
5f8f9cc2
PE
5070 * gtkutil.c: Omit integer casts.
5071 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5072 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5073
5adf60bc
PE
5074 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5075
c8907a93
PE
5076 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5077 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5078 would wrongly return t on a 64-bit host.
5079
e3c25c68
PE
5080 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5081 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5082 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5083 and therefore cause GCC to emit a bogus diagnostic in some cases.
5084
3f791afe
PE
5085 * image.c: Integer signedness and overflow and related fixes.
5086 This is not an exhaustive set of fixes, but it's time to
5087 record what I've got.
5088 (lookup_pixel_color, check_image_size): Remove redundant decls.
5089 (check_image_size): Don't assume that arbitrary EMACS_INT values
5090 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5091 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5092 (tiff_load, imagemagick_load_image):
5093 Check for overflow in size calculations.
5094 (x_create_x_image_and_pixmap): Remove unnecessary test for
5095 xmalloc returning NULL; that can't happen.
5096 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5097 (xpm_color_bucket): Use better integer hashing function.
5098 (xpm_cache_color): Don't possibly over-allocate memory.
5099 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5100 (gif_memory_source):
5101 Use ptrdiff_t, not int or size_t, to record sizes.
5102 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5103 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5104 either works, as we prefer signed integers.
5105 (tiff_read_from_memory, tiff_write_from_memory):
5106 Return tsize_t, not size_t, since that's what the TIFF API wants.
5107 (tiff_read_from_memory): Don't fail simply because the read would
5108 go past EOF; instead, return a short read.
5109 (tiff_load): Omit no-longer-needed casts.
5110 (Fimagemagick_types): Don't assume size fits into 'int'.
5111
3cc5a532
PE
5112 Improve hashing quality when configured --with-wide-int.
5113 * fns.c (hash_string): New function, taken from sxhash_string.
5114 Do not discard information about ASCII character case; this
5115 discarding is no longer needed.
5116 (sxhash-string): Use it. Change sig to match it. Caller changed.
5117 * lisp.h: Declare it.
5118 * lread.c (hash_string): Remove, since we now use fns.c's version.
5119 The fns.c version returns a wider integer if --with-wide-int is
5120 specified, so this should help the quality of the hashing a bit.
5121
b312a492
PE
5122 * emacs.c: Integer overflow minor fix.
5123 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5124 Define only if GNU_LINUX.
5125 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5126
dfd153ae
PE
5127 * dispnew.c: Integer signedness and overflow fixes.
5128 Remove unnecessary forward decls, that were a maintenance hassle.
5129 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5130 All uses changed.
5131 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5132 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5133 (prepare_desired_row, line_draw_cost):
5134 Use int, not unsigned, where either works.
5135 (save_current_matrix, restore_current_matrix):
5136 Use ptrdiff_t, not size_t, where either works.
5137 (init_display): Check for overflow more accurately, and without
5138 relying on undefined behavior.
5139
a81d11a3
PE
5140 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5141 Remove, replacing with the new symbols in lisp.h. All uses changed.
5142 * fileio.c (make_temp_name):
5143 * filelock.c (lock_file_1, lock_file):
5144 * xdisp.c (message_dolog):
5145 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5146 Use pMd etc. instead.
5147 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5148 replacing the pWIDE etc. symbols removed from editfns.c.
5149
3300e6fd
PE
5150 * keyboard.h (num_input_events): Now uintmax_t.
5151 This is (very slightly) less likely to mess up due to wraparound.
5152 All uses changed.
5153
fd05c7e9
PE
5154 * buffer.c: Integer signedness fixes.
5155 (alloc_buffer_text, enlarge_buffer_text):
5156 Use ptrdiff_t rather than size_t when either will do, as we prefer
5157 signed integers.
5158
903fe15d
PE
5159 * alloc.c: Integer signedness and overflow fixes.
5160 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5161 (__malloc_size_t): Default to size_t, not to int.
5162 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5163 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5164 Prefer ptrdiff_t to size_t when either would do, as we prefer
5165 signed integers.
5166 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5167 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5168 Now const. Initialize with values that are in range even if char
5169 is signed.
5170 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5171 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5172 These functions do the right thing with sizes > 2**32.
5173 (check_depth): Now ptrdiff_t, not int.
5174 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5175 Adjust to new way of storing sizes. Check for size overflow bugs
5176 in rest of code.
5177 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5178 slightly wrong anyway, as it missed one instance of
5179 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5180 (refill_memory_reserve): Omit needless cast to size_t.
5181 (mark_object_loop_halt): Mark as externally visible.
5182
ac82cc6a
PE
5183 * xselect.c: Integer signedness and overflow fixes.
5184 (Fx_register_dnd_atom, x_handle_dnd_message):
5185 Use ptrdiff_t, not size_t, since we prefer signed.
5186 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5187 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5188 x_dnd_atoms_size and x_dnd_atoms_length.
5189
c2d1e36d
PE
5190 * doprnt.c: Prefer signed to unsigned when either works.
5191 * eval.c (verror):
5192 * doprnt.c (doprnt):
5193 * lisp.h (doprnt):
5194 * xdisp.c (vmessage):
5195 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5196 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5197 prefer signed arithmetic to avoid comparison confusion.
5198 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5199 but is a bit tricky.
5200
0e926e56
PE
5201 Assume freestanding C89 headers, string.h, stdlib.h.
5202 * data.c, doprnt.c, floatfns.c, print.c:
5203 Include float.h unconditionally.
5204 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5205 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5206 * regex.c: Likewise for stddef.h, string.h.
5207 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5208 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5209 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5210 (STDC_HEADERS): Remove obsolete defines.
5211 * sysdep.c: Include limits.h unconditionally.
5212
9cfdb3ec
PE
5213 Assume support for memcmp, memcpy, memmove, memset.
5214 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5215 * regex.c (memcmp, memcpy):
5216 Remove; we assume C89 now.
5217
5218 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5219 (__malloc_safe_bcopy): Remove; no longer needed.
5220
cf950e6b 5221 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5222 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5223 well either way, and we prefer signed to unsigned.
5224
dbf38e02
LMI
52252011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5226
5227 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5228 closes the connection while we're reading (bug#9182).
5229
d6f0886c 52302011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5231
d6f0886c
JD
5232 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5233 are specified (Bug#9168).
24e0f6b1 5234
2eb1f9e6
PE
52352011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5236
5237 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5238 Found by GCC static checking and --with-wide-int on a 32-bit host.
5239
22381272 52402011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5241
5242 * xdisp.c (compute_display_string_pos): Fix logic of caching
5243 previous display string position. Initialize cached_prev_pos to
5244 -1. Fixes slow-down at the beginning of a buffer.
5245
f25e39b4
EZ
52462011-07-24 Eli Zaretskii <eliz@gnu.org>
5247
5248 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5249 for attrs[LFACE_FONTSET_INDEX].
5250
04c4b52e
PE
52512011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5252
5253 * xml.c (parse_region): Remove unused local
5254 that was recently introduced.
5255
c1734fbd
EZ
52562011-07-23 Eli Zaretskii <eliz@gnu.org>
5257
be18c5a5
EZ
5258 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5259 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5260
c1734fbd
EZ
5261 * xdisp.c (move_it_in_display_line_to): Record the best matching
5262 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5263 exit if none of the characters scanned was an exact match.
5264 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5265 when exact match is impossible due to invisible text, and the
5266 lines are truncated.
5267
a258d627
JD
52682011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5269
5270 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5271 for OSX >= 10.7.
5272
b6d5a689
EZ
52732011-07-22 Eli Zaretskii <eliz@gnu.org>
5274
0f74f785
EZ
5275 Fix a significant slow-down of cursor motion with C-n, C-p,
5276 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5277 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5278 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5279 (next_element_from_buffer): Call compute_stop_pos_backwards to
5280 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5281 base_level_stop.
5282 (reseat): Don't look for prev_stop, as that could mean a very long
5283 run.
5284 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5285 <cached_disp_overlay_modiff>: Cache for last found display string
5286 position.
551918c1 5287 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5288 about the same buffer in the same area of character positions, and
5289 the buffer wasn't changed since the time the display string
5290 position was cached.
551918c1 5291
b2d0c91a
EZ
52922011-07-22 Eli Zaretskii <eliz@gnu.org>
5293
5294 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5295 is an integer, which is important for empty lines. (Bug#9149)
5296
043604ee
CY
52972011-07-22 Chong Yidong <cyd@stupidchicken.com>
5298
5299 * frame.c (Fmodify_frame_parameters): In tty case, update the
5300 default face if necessary (Bug#4238).
5301
da4adb04
CY
53022011-07-21 Chong Yidong <cyd@stupidchicken.com>
5303
5304 * editfns.c (Fstring_to_char): No need to explain what a character
5305 is in the docstring (Bug#6576).
5306
9abd0532
LMI
53072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5308
5309 * xml.c (parse_region): Make sure we always return a tree.
5310
36881d16
HK
53112011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5312
5313 * xml.c (parse_region): If a document contains only comments,
5314 return that, too.
5315
1e98674d
LMI
53162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5317
5318 * xml.c (make_dom): Return comments, too.
5319
590bd467
PE
53202011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5321
5322 Port to OpenBSD.
5323 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5324 and the surrounding thread.
5325 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5326 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5327 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5328 timer goes off.
5329 * s/openbsd.h (BROKEN_SIGIO): Define.
5330 * unexelf.c (unexec) [__OpenBSD__]:
5331 Don't update the .mdebug section of the Alpha COFF symbol table.
5332
f41628b2
LMI
53332011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5334
5335 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5336 (bug#8460).
5337
b59b67c5
PE
53382011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5339
15e3a074
PE
5340 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5341 This fixes some race conditions on the permissions of any newly
5342 created file.
5343
41bed37d
PE
5344 * alloc.c (valid_pointer_p): Use pipe, not open.
5345 This fixes some permissions issues when debugging.
5346
b59b67c5
PE
5347 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5348 If fchown fails to set both uid and gid, try to set just gid,
5349 as that is sometimes allowed. Adjust the file's mode to eliminate
5350 setuid or setgid bits that are inappropriate if fchown fails.
5351
925a6be7
SM
53522011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5353
5354 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5355 to compare Lisp_Objects.
5356 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5357 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5358 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5359
52968808
AS
53602011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5361
0a6a104b
AS
5362 * lread.c (read_integer): Unread even EOF character.
5363 (read1): Likewise. Properly record start position of symbol.
5364
52968808
AS
5365 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5366 symbol character follows.
5367
9e381cdd
PE
53682011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5369
5370 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5371 This works around a problem with the previous change to Fcopy_file.
5372 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5373 and without this change, GCC might complain about discarding
5374 fchown's return value.
5375
b5641435
JB
53762011-07-16 Juanma Barranquero <lekktu@gmail.com>
5377
5378 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5379
a8031457
PE
53802011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5381
5382 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5383
dd889327
LMI
53842011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5385
750c33f7
LMI
5386 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5387 it's used from the C level.
5388
dd889327
LMI
5389 * process.c: Use the same condition for POLL_FOR_INPUT in both
5390 keyboard.c and process.c (bug#1858).
5391
87e86684
LM
53922011-07-09 Lawrence Mitchell <wence@gmx.li>
5393
5394 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5395 (Fgnutls_boot): Use it.
5396
64348f40
AS
53972011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5398
5399 * doc.c (Fsubstitute_command_keys): Revert last change.
5400
1d698799
LMI
54012011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5402
f863868c
LMI
5403 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5404 quotes the next character, and doesn't affect other longer
5405 sequences (bug#8935).
5406
1d698799
LMI
5407 * lread.c (syms_of_lread): Clarify that is isn't only
5408 `eval-buffer' and `eval-defun' that's affected by
5409 `lexical-binding' (bug#8460).
5410
aa4b6df6
EZ
54112011-07-15 Eli Zaretskii <eliz@gnu.org>
5412
5413 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5414 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5415
5d856da6
PE
54162011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5417
ad6042bb
PE
5418 Fix minor problems found by static checking.
5419 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5420 (elsz): Now a signed constant, not a size_t var. We prefer signed
5421 types to unsigned, to avoid integer comparison confusion. Without
5422 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5423 "cannot optimize loop, the loop counter may overflow", a symptom
5424 of the confusion.
f00bbb22 5425 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5426 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5427
6468f31c
LMI
54282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5429
49080b10
LMI
5430 * search.c (Fre_search_backward): Mention `case-fold-search' in
5431 all the re_search_* functions (bug#8138).
5432
6468f31c
LMI
5433 * keyboard.c (Fopen_dribble_file): Document when the file is
5434 closed (bug#8056).
5435
c965adc5
EZ
54362011-07-14 Eli Zaretskii <eliz@gnu.org>
5437
df9733bf
EZ
5438 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5439 bidi_cache_idx.
5440
0bb23927
EZ
5441 Support bidi reordering of display and overlay strings.
5442 * xdisp.c (compute_display_string_pos)
5443 (compute_display_string_end): Accept additional argument STRING.
5444 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5445 (reseat_to_string): Initialize bidi_it->string.s and
5446 bidi_it->string.schars.
5447 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5448 NULL (avoids a crash in bidi_paragraph_init).
5449 Initialize itb.string.lstring.
0bb23927
EZ
5450 (init_iterator): Call bidi_init_it only of a valid
5451 buffer position was specified. Initialize paragraph_embedding to
5452 L2R.
5453 (reseat_to_string): Initialize the bidi iterator.
5454 (display_string): If we need to ignore text properties of
5455 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5456 original value of -1 will not work with bidi.)
5457 (compute_display_string_pos): First arg is now struct
5458 `text_pos *'; all callers changed. Support display properties on
5459 Lisp strings.
5460 (compute_display_string_end): Support display properties on Lisp
5461 strings.
5462 (init_iterator, reseat_1, reseat_to_string): Initialize the
5463 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5464 when iterating on a string not from display properties).
640c8776
SM
5465 (compute_display_string_pos, compute_display_string_end):
5466 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5467 arrow keys.
5468 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5469 base_level_stop; instead, set base_level_stop to BEGV.
5470 Fixes crashes in vertical-motion.
0bb23927
EZ
5471 (next_element_from_buffer): Improve commentary for when
5472 the iterator is before prev_stop.
5473 (init_iterator): Initialize bidi_p from the default value of
5474 bidi-display-reordering, not from buffer-local value. Use the
5475 buffer-local value only if initializing for buffer iteration.
5476 (handle_invisible_prop): Support invisible properties on strings
5477 that are being bidi-reordered.
5478 (set_iterator_to_next): Support bidi reordering of C strings and
5479 Lisp strings.
5480 (next_element_from_string): Support bidi reordering of Lisp
5481 strings.
5482 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5483 (display_string): Support display of R2L glyph rows.
5484 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5485 (init_iterator): Don't initialize it->bidi_p for strings
5486 here.
5487 (reseat_to_string): Initialize it->bidi_p for strings here.
5488 (next_element_from_string, next_element_from_c_string)
5489 (next_element_from_buffer): Add xassert's for correspondence
5490 between IT's object being iterated and it->bidi_it.string
5491 structure.
5492 (face_before_or_after_it_pos): Support bidi iteration.
5493 (next_element_from_c_string): Handle the case of the first string
5494 character that is not the first one in the visual order.
5495 (get_visually_first_element): New function, refactored from common
5496 parts of next_element_from_buffer, next_element_from_string, and
5497 next_element_from_c_string.
5498 (tool_bar_lines_needed, redisplay_tool_bar)
5499 (display_menu_bar): Force left-to-right direction. Add a FIXME
5500 comment for making that be controlled by a user option.
5501 (push_it, pop_it): Save and restore the state of the
5502 bidi iterator. Save and restore the bidi_p flag.
5503 (pop_it): Iterate out of display property for string iteration as
5504 well.
5505 (iterate_out_of_display_property): Support iteration over strings.
5506 (handle_single_display_spec): Set up it->bidi_it for iteration
5507 over a display string, and call bidi_init_it.
5508 (handle_single_display_spec, next_overlay_string)
5509 (get_overlay_strings_1, push_display_prop): Set up the bidi
5510 iterator for displaying display or overlay strings.
5511 (forward_to_next_line_start): Don't use the shortcut if
5512 bidi-iterating.
5513 (back_to_previous_visible_line_start): If handle_display_prop
5514 pushed the iterator stack, restore the internal state of the bidi
5515 iterator by calling bidi_pop_it same number of times.
5516 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5517 and we are bidi-iterating, don't decrement the iterator position;
5518 instead, set the first_elt flag in the bidi iterator, to produce
5519 the same effect.
5520 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5521 (push_display_prop): xassert that we are iterating a buffer.
5522 (push_it, pop_it): Save and restore paragraph_embedding member.
5523 (handle_single_display_spec, next_overlay_string)
5524 (get_overlay_strings_1, reseat_1, reseat_to_string)
5525 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5526 correctly. Don't assume unibyte strings are not bidi-reordered.
5527 (compute_display_string_pos)
5528 (compute_display_string_end): Fix handling the case of C string.
5529 (push_it, pop_it): Save and restore from_disp_prop_p.
5530 (handle_single_display_spec, push_display_prop): Set the
5531 from_disp_prop_p flag.
5532 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5533 (pop_it): Call iterate_out_of_display_property only if we are
5534 popping after iteration over a string that came from a display
5535 property. Fix a typo in popping stretch info. Add an assertion
5536 for verifying that the iterator position is in sync with the bidi
5537 iterator.
5538 (handle_single_display_spec, get_overlay_strings_1)
5539 (push_display_prop): Fix initialization of paragraph direction for
5540 string when that of the parent object is not yet determined.
5541 (reseat_1): Call bidi_init_it to resync the bidi
5542 iterator with IT's position. (Bug#7616)
5543 (find_row_edges): If ROW->start.pos gives position
5544 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5545 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5546 Reset the from_disp_prop_p flag.
5547 (SAVE_IT, RESTORE_IT): New macros.
5548 (pos_visible_p, face_before_or_after_it_pos)
5549 (back_to_previous_visible_line_start)
5550 (move_it_in_display_line_to, move_it_in_display_line)
5551 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5552 (try_scrolling, redisplay_window, display_line): Use them when
5553 saving a temporary copy of the iterator and restoring it back.
5554 (back_to_previous_visible_line_start, reseat_1)
5555 (init_iterator): Empty the bidi cache "stack".
5556 (move_it_in_display_line_to): If iterator ended up at
5557 EOL, but we never saw any buffer positions smaller than
5558 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5559 motion in bidi-reordered lines.
5560 (move_it_in_display_line_to): Record prev_method and prev_pos
5561 immediately before the call to set_iterator_to_next. Fixes cursor
5562 motion in bidi-reordered lines with stretch glyphs and strings
5563 displayed in margins. (Bug#8133) (Bug#8867)
5564 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5565 TO_CHARPOS.
640c8776
SM
5566 (pos_visible_p): Support positions in bidi-reordered lines.
5567 Save and restore bidi cache.
0bb23927
EZ
5568
5569 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5570 (bidi_paragraph_info): Delete unused struct.
5571 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5572 (bidi_cache_start): New variable.
5573 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5574 to zero.
5575 (bidi_cache_fetch_state, bidi_cache_search)
5576 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5577 (bidi_cache_find, bidi_peek_at_next_level)
5578 (bidi_level_of_next_char, bidi_find_other_level_edge)
5579 (bidi_move_to_visually_next): Compare cache index with
5580 bidi_cache_start rather than with zero.
5581 (bidi_fetch_char): Accept new argument STRING; all callers
5582 changed. Support iteration over a string. Support strings with
5583 display properties. Support unibyte strings. Fix the type of
5584 `len' according to what STRING_CHAR_AND_LENGTH expects.
5585 (bidi_paragraph_init, bidi_resolve_explicit_1)
5586 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5587 (bidi_level_of_next_char, bidi_move_to_visually_next):
5588 Support iteration over a string.
0bb23927
EZ
5589 (bidi_set_sor_type, bidi_resolve_explicit_1)
5590 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5591 can now be zero (for strings); special values 0 and -1 were
5592 changed to -1 and -2, respectively.
5593 (bidi_char_at_pos): New function.
5594 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5595 Call it instead of FETCH_MULTIBYTE_CHAR.
5596 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5597 initialized to valid values.
5598 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5599 values.
5600 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5601 the test for valid cached positions. Fix the logic for looking up
5602 the sentinel state in the cache. GCPRO the Lisp string we are
5603 iterating.
5604 (bidi_push_it, bidi_pop_it): New functions.
5605 (bidi_initialize): Initialize the bidi cache start stack pointer.
5606 (bidi_cache_ensure_space): New function, refactored from part of
5607 bidi_cache_iterator_state. Don't assume the required size is just
5608 one BIDI_CACHE_CHUNK away.
5609 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5610 (bidi_count_bytes, bidi_char_at_pos): New functions.
5611 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5612 always valid if bidi_cache_idx is valid.
5613 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5614 is valid if it's going to be used.
5615 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5616 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5617 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5618 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5619 (bidi_find_other_level_edge, bidi_cache_start_stack):
5620 All variables related to cache indices are now EMACS_INT.
c965adc5 5621
0bb23927
EZ
5622 * dispextern.h (struct bidi_string_data): New structure.
5623 (struct bidi_it): New member `string'. Make flag members be 1-bit
5624 fields, and put them last in the struct.
640c8776
SM
5625 (compute_display_string_pos, compute_display_string_end):
5626 Update prototypes.
0bb23927
EZ
5627 (bidi_push_it, bidi_pop_it): Add prototypes.
5628 (struct iterator_stack_entry): New members bidi_p,
5629 paragraph_embedding, and from_disp_prop_p.
5630 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5631 (bidi_shelve_cache, bidi_unshelve_cache):
5632 Declare prototypes.
0bb23927
EZ
5633
5634 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5635 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5636 and vector-like objects.
5637
5638 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5639 cache around display iteration.
5640
5641 * window.c (Fwindow_end, window_scroll_pixel_based)
5642 (displayed_window_lines, Frecenter): Save and restore the bidi
5643 cache around display iteration.
5644
3bbd2265
LMI
56452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5646
5647 * editfns.c (Fdelete_region): Clarify the use of the named
5648 parameters (bug#6788).
5649
adc47434
MR
56502011-07-14 Martin Rudalics <rudalics@gmx.at>
5651
5652 * indent.c (Fvertical_motion): Set and restore w->pointm when
5653 saving and restoring the window's buffer (Bug#9006).
5654
837c31f8
LMI
56552011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5656
5657 * editfns.c (Fstring_to_char): Clarify just what is returned
5658 (bug#6576). Text by Eli Zaretskii.
5659
ac389d0c
JB
56602011-07-13 Juanma Barranquero <lekktu@gmail.com>
5661
5662 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5663
0be0ce47
EZ
56642011-07-13 Eli Zaretskii <eliz@gnu.org>
5665
5666 * buffer.c (mmap_find): Fix a typo.
5667
cd18e7e3
JB
56682011-07-13 Johan Bockgård <bojohan@gnu.org>
5669
5670 Fix execution of x selection hooks.
5671 * xselect.c (Qx_lost_selection_functions)
5672 (Qx_sent_selection_functions): New vars.
5673 (syms_of_xselect): DEFSYM them.
5674 (x_handle_selection_request): Pass Qx_sent_selection_functions
5675 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5676 (x_handle_selection_clear,x_clear_frame_selections):
5677 Pass Qx_lost_selection_functions rather than
5678 Vx_lost_selection_functions to Frun_hook_with_args.
5679
47ea7f44
PE
56802011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5681
ac389d0c 5682 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5683 The old code sometimes used this field without initializing it.
5684
47ea7f44
PE
5685 * alloc.c (gc_sweep): Don't read past end of array.
5686 In theory, the old code could also have corrupted Emacs internals,
5687 though it'd be very unlikely.
5688
bc985c87
AS
56892011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5690
5691 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5692 argument. (Bug#4026)
bc985c87 5693
0cf34688
LMI
56942011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5695
b3dadd76
LMI
5696 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5697 key" (bug#4257).
5698
0cf34688
LMI
5699 * window.c (Fset_window_start): Doc fix (bug#4199).
5700 (Fset_window_hscroll): Ditto.
5701
270768cd
PE
57022011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5703
077e3dda 5704 Fix minor new problems caught by GCC 4.6.1.
270768cd 5705 * term.c (init_tty): Remove unused local.
490011a6 5706 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5707 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5708 not used otherwise.
270768cd 5709
b1f58454
CY
57102011-07-12 Chong Yidong <cyd@stupidchicken.com>
5711
5712 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5713
22b9578d
LMI
57142011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5715
6e70ab07
LMI
5716 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5717 are the mini-buffer and the echo area (bug#3320).
5718
22b9578d
LMI
5719 * term.c (init_tty): Remove support for supdup, c10 and perq
5720 terminals, which are no longer supported (bug#1482).
5721
8974cc9f
JB
57222011-07-10 Johan Bockgård <bojohan@gnu.org>
5723
5724 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5725
a560d974
JD
57262011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5727
5728 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5729 for non-popups (Bug#3642).
5730
1dae0f0a
AS
57312011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5732
268c2c36 5733 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5734 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5735 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5736 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5737 * data.c (fmod): Likewise.
5738 * dispnew.c (swap_glyphs_in_rows): Likewise.
5739 * emacs.c (memory_warning_signal): Likewise.
5740 * floatfns.c (float_error): Likewise.
5741 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5742 (otf_open, font_otf_capability, generate_otf_features)
5743 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5744 Likewise.
5745 * image.c (pbm_read_file): Likewise.
5746 * indent.c (string_display_width): Likewise.
5747 * intervals.c (check_for_interval, search_for_interval)
5748 (inc_interval_count, count_intervals, root_interval)
5749 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5750 * lread.c (defalias): Likewise.
268c2c36 5751 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
5752 * regex.c (set_image_of_range_1, set_image_of_range)
5753 (regex_grow_registers): Likewise.
5754 * sysdep.c (strerror): Likewise.
5755 * termcap.c (valid_filename_p, tprint, main): Likewise.
5756 * tparam.c (main): Likewise.
5757 * unexhp9k800.c (run_time_remap, save_data_space)
5758 (update_file_ptrs, read_header, write_header, calculate_checksum)
5759 (copy_file, copy_rest, display_header): Likewise.
5760 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5761 Likewise.
5762 * xdisp.c (check_it): Likewise.
5763 * xfaces.c (register_color, unregister_color, unregister_colors):
5764 Likewise.
5765 * xfns.c (print_fontset_result): Likewise.
5766 * xrdb.c (member, fatal, main): Likewise.
5767
99033785
PE
57682011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5769
5770 Fix minor problems found by static checking (Bug#9031).
5771 * chartab.c (char_table_set_range, map_sub_char_table):
5772 Remove unused locals.
5773 (uniprop_table): Now static.
5774 * composite.c (_work_char): Remove unused static var.
5775
9cb2ac56
JB
57762011-07-09 Juanma Barranquero <lekktu@gmail.com>
5777
5778 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5779
f25661f0
JD
57802011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5781
5782 * gtkutil.c (qttip_cb): Remove code without function.
5783
8278c4fe
EZ
57842011-07-09 Eli Zaretskii <eliz@gnu.org>
5785
5786 * w32.c (pthread_sigmask): New stub.
5787
1692ae2d 57882011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 5789
8a6ebd58 5790 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
5791 sigprocmask is portable only for single-threaded applications, and
5792 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
5793 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5794 (LIBES): Use it.
5795 * callproc.c (Fcall_process):
5796 * process.c (create_process):
5797 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5798 Use pthread_sigmask, not sigprocmask.
123403e4 5799
1b854618
JD
58002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5801
5802 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5803 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5804 wrong (Bug#8591).
5805
3fe4b549
JD
58062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5807
0ce7e563
JD
5808 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5809 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5810 (xg_hide_tooltip): Fix comment.
5811
3fe4b549
JD
5812 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5813 in registerServicesMenuSendTypes.
5814 (validRequestorForSendType): Don't check ns_return_types.
5815
5816 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5817 ns_return_type.
5818
5df75e47
JR
58192011-07-08 Jason Rumney <jasonr@gnu.org>
5820
22610910
JR
5821 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5822 SH_SHOW for hidden windows (Bug#5482).
5823
5df75e47
JR
5824 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5825 frame struct members of non-existent frames (Bug#6284).
5826
699c10bd
JD
58272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5828
4393663b
JD
5829 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5830 variable firstTime not needed on OSX >= 10.6.
5831 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5832 >= 10.5. Use setKnobProportion, setDoubleValue.
5833
5834 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5835 (MAC_OS_X_VERSION_10_5): Define if not defined.
5836 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5837 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5838 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5839
5840 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5841 cString and lossyCString on OSX >= 10.4
5842
58179cce 5843 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5844 sizeToFit on OSX >= 10.2.
5845
5846 * nsimage.m (allocInitFromFile): Don't use deprecated method
5847 bestRepresentationForDevice on OSX >= 10.6.
5848
5849 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5850 to avoid warning.
5851
5852 * emacs.c: Declare unexec_init_emacs_zone.
5853
a63e0781
JD
5854 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5855
699c10bd
JD
5856 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5857
5858 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5859 on svcsMenu (Bug#8842).
5860
5861 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5862 ns_return_types.
5863 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5864
5865 * nsterm.m (QUTF8_STRING): Declare.
5866 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5867 (validRequestorForSendType): Return type is (id).
5868 Change indexOfObjectIdenticalTo to indexOfObject.
5869 Check if we have local selection before returning self (Bug#8842).
5870 (writeSelectionToPasteboard): Put local selection into paste board
5871 if we have a local selection (Bug#8842).
5872 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5873
5874 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5875 (ns_get_local_selection): Declare.
5876
54e10184
LMI
58772011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5878
9888ff71
LMI
5879 * keymap.c (describe_map_tree): Don't insert a double newline at
5880 the end of the buffer (bug#1169) and return whether we inserted
5881 something.
5882
54e10184
LMI
5883 * callint.c (Fcall_interactively): Change "reading args" to
5884 "providing args" to try to clarify what it does (bug#1010).
5885
15fa4783
KH
58862011-07-07 Kenichi Handa <handa@m17n.org>
5887
5888 * composite.c (composition_compute_stop_pos): Ignore a static
5889 composition starting before CHARPOS (Bug#8915).
5890
5891 * xdisp.c (handle_composition_prop): Likewise.
5892
a8815b00
EZ
58932011-07-07 Eli Zaretskii <eliz@gnu.org>
5894
5895 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5896 (Bug#9015)
5897
ef7b981d 58982011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5899
5900 * character.h (unicode_category_t): New enum type.
5901
5902 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5903 (Qchar_code_property_table): New variable.
5904 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5905 (UNIPROP_COMPRESSED_FORM_P): New macros.
5906 (char_table_ascii): Uncompress the compressed values.
5907 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5908 Uncompress the compressed values.
ac389d0c 5909 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5910 (char_table_ref_and_range): Uncompress the compressed values.
5911 (sub_char_table_set): New arg is_uniprop. Callers changed.
5912 Uncompress the compressed values.
5913 (sub_char_table_set_range): Args changed. Callers changed.
5914 (char_table_set_range): Adjuted for the above change.
5915 (map_sub_char_table): Delete args default_val and parent. Add arg
5916 top. Give decoded values to a Lisp function.
640c8776 5917 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5918 values to a Lisp function. Gcpro more variables.
5919 (uniprop_table_uncompress)
5920 (uniprop_decode_value_run_length): New functions.
5921 (uniprop_decoder, uniprop_decoder_count): New variables.
5922 (uniprop_get_decoder, uniprop_encode_value_character)
5923 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5924 New functions.
5925 (uniprop_encoder, uniprop_encoder_count): New variables.
5926 (uniprop_get_encoder, uniprop_table)
5927 (Funicode_property_table_internal, Fget_unicode_property_internal)
5928 (Fput_unicode_property_internal): New functions.
5929 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5930 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 5931 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
5932 char-code-property-alist.
5933
640c8776 5934 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5935 Vunicode_category_table.
5936
640c8776 5937 * font.c (font_range): Adjust for the change of
c805dec0
KH
5938 Vunicode_category_table.
5939
76b397fb
DN
59402011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5941
5942 * m/iris4d.h: Remove file, move contents ...
5943 * s/irix6-5.h: ... here.
5944
22b4128e
PE
59452011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5946
5947 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5948 * alloc.c (mark_buffer):
5949 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5950 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5951 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5952 This isn't true in general, and it's particularly not true
5953 if Emacs is configured with --with-wide-int.
5954 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5955 New macros, used in the buffer.c change.
5956
869795d6
JD
59572011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5958
5959 * xsettings.c: Use both GConf and GSettings if both are available.
5960 (store_config_changed_event): Add comment.
5961 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5962 (store_tool_bar_style_changed): New functions.
5e617bc2 5963 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5964 (struct xsettings): Move font inside HAVE_XFT.
5965 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5966 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5967 Move inside HAVE_XFT.
640c8776 5968 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5969 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5970 also.
5971 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5972 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5973 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5974 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5975 (parse_settings): Move check for font inside HAVE_XFT.
5976 (read_settings, apply_xft_settings): Add comment.
5977 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5978 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5979 call store_font_name_changed.
5980 (xft_settings_event): Add comment.
5981 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5982 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5983 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5984 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5985 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5986 (xsettings_get_system_font, xsettings_get_system_normal_font):
5987 Add comment.
869795d6 5988
d8ed26bd
PE
59892011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5990
5991 Random fixes. E.g., (random) never returned negative values.
5992 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5993 subseconds part to the entropy, as that's a bit more random.
5994 Prefer signed to unsigned, since the signedness doesn't matter and
5995 in general we prefer signed. When given a limit, use a
5996 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5997 latter isn't right if USE_2_TAGS_FOR_INTS.
5998 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5999 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6000
cabf1cac
SM
60012011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6002
6003 * textprop.c (text_property_stickiness):
6004 Obey Vtext_property_default_nonsticky.
6005 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6006 * w32fns.c (syms_of_w32fns):
6007 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6008
6e9b2be9
PE
60092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6010
6011 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6012 This is more efficient than Ffile_directory_p and avoids a minor race.
6013
90186c68
LMI
60142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6015
7c301272
LMI
6016 * buffer.c (Foverlay_put): Say what the return value is
6017 (bug#7835).
6018
c4f2d8d4
LMI
6019 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6020 is a directory before asking whether to use the file name
6021 (bug#7564).
ad637907
LMI
6022 (barf_or_query_if_file_exists): Make the "File is a directory"
6023 error be more correct.
c4f2d8d4 6024
90186c68
LMI
6025 * fns.c (Frequire): Remove the mention of the .gz files, since
6026 that's installation-specific, but keep the mention of
6027 `get-load-suffixes'.
6028
da64016e
PE
60292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6030
6031 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6032 Report string overflow if the output is too long.
6033
7d47b580
JB
60342011-07-04 Juanma Barranquero <lekktu@gmail.com>
6035
a555cb87
JB
6036 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6037 (syms_of_gnutls): Remove duplicate DEFSYM for
6038 Qgnutls_bootprop_verify_hostname_error, an error for
6039 Qgnutls_bootprop_verify_error (which is no longer used).
6040
7d47b580
JB
6041 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6042 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6043 Also (re)move comments that are misplaced or no longer relevant.
6044
1e49bfab
LMI
60452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6046
6047 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6048
1485f4c0
CY
60492011-07-03 Chong Yidong <cyd@stupidchicken.com>
6050
6051 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6052 and background color parameters if they have been changed.
6053
a9ab721e
LMI
60542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6055
6056 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6057
cf7cff57
PE
60582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6059
2e13213d
PE
6060 * xsettings.c (SYSTEM_FONT): Define only when used.
6061 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6062
cf7cff57
PE
6063 * keymap.c (access_keymap_1): Now static.
6064
7a8e04f7
CY
60652011-07-02 Chong Yidong <cyd@stupidchicken.com>
6066
6067 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6068 leave any prefix arg for the up event (Bug#1586).
6069
61352f62
LMI
60702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6071
69bb1ef7
LMI
6072 * lread.c (syms_of_lread): Mention single symbols defined by
6073 `defvar' or `defconst' (bug#7154).
6074
61352f62 6075 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6076 (Frequire): Mention get-load-suffixes.
61352f62 6077
28545e04
MR
60782011-07-02 Martin Rudalics <rudalics@gmx.at>
6079
6080 * window.h (window): Remove clone_number slot.
6081 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6082 Remove.
6083 (make_parent_window, make_window, saved_window)
6084 (Fset_window_configuration, save_window_save): Don't deal with
6085 clone numbers.
6086 * buffer.c (Qclone_number): Remove declaration.
6087 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6088
3349e122
SM
60892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6090
6091 Add multiple inheritance to keymaps.
6092 * keymap.c (Fmake_composed_keymap): New function.
6093 (Fset_keymap_parent): Simplify.
6094 (fix_submap_inheritance): Remove.
6095 (access_keymap_1): New function extracted from access_keymap to handle
6096 embedded parents and handle lists of maps.
6097 (access_keymap): Use it.
6098 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6099 (Fcopy_keymap): Handle embedded parents.
6100 (Fcommand_remapping, define_as_prefix): Simplify.
6101 (Fkey_binding): Simplify.
6102 (syms_of_keymap): Move minibuffer-local-completion-map,
6103 minibuffer-local-filename-completion-map,
6104 minibuffer-local-must-match-map, and
6105 minibuffer-local-filename-must-match-map to Elisp.
6106 (syms_of_keymap): Defsubr make-composed-keymap.
6107 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6108 (parse_menu_item): Trivial simplification.
6109
3279eb87
GM
61102011-07-01 Glenn Morris <rgm@gnu.org>
6111
6112 * Makefile.in (SETTINGS_LIBS): Fix typo.
6113
4550efdf
KI
61142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6115
6116 * coding.c (Fencode_coding_string): Record the last coding system
6117 used, as the function doc string says (bug#8738).
6118
0949d2b6
JD
61192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6120
6121 * xsettings.c (store_monospaced_changed): Take new font as arg and
6122 check for change against current_mono_font.
6123 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6124 (emacs_settings_constructor, emacs_settings_get_property)
6125 (emacs_settings_set_property, emacs_settings_class_init)
6126 (emacs_settings_init, gsettings_obj): Remove.
6127 (something_changedCB): New function for HAVE_GSETTINGS.
6128 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6129 with value as argument.
6130 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6131 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6132 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6133 "changed".
6134
6135 * xgselect.c: Add defined (HAVE_GSETTINGS).
6136 (xgselect_initialize): Ditto.
6137
6138 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6139 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6140 xg_select.
6141
bbc6b304
PE
61422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6143
6144 * eval.c (struct backtrace): Simplify and port the data structure.
6145 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6146 signed bit field, as this assumption is not portable and it makes
6147 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6148 "char debug_on_exit : 1" as this is not portable either; instead,
6149 use the portable "unsigned int debug_on_exit : 1". Remove unused
6150 member evalargs. Remove obsolete comments about cc bombing out.
6151
9851bfc5
JD
61522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6153
51bb811f 6154 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6155 Let HAVE_GSETTINGS override HAVE_GCONF.
6156 (store_monospaced_changed): New function.
6157 (EMACS_SETTINGS): A new type derived from GObject to handle
6158 GSettings notifications.
6159 (emacs_settings_constructor, emacs_settings_get_property)
6160 (emacs_settings_set_property, emacs_settings_class_init):
6161 New functions.
6162 (gsettings_client, gsettings_obj): New variables.
6163 (GSETTINGS_SCHEMA): New define.
6164 (something_changedCB): Call store_monospaced_changed.
6165 (init_gsettings): New function.
6166 (xsettings_initialize): Call init_gsettings.
6167 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6168 to NULL.
6169
640c8776 6170 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6171 GCONF_CFLAGS/LIBS.
6172
5386012d
MR
61732011-06-29 Martin Rudalics <rudalics@gmx.at>
6174
6175 * window.c (resize_root_window, grow_mini_window)
6176 (shrink_mini_window): Rename Qresize_root_window to
6177 Qwindow_resize_root_window and Qresize_root_window_vertically to
6178 Qwindow_resize_root_window_vertically.
6179
f13e0b08
PE
61802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6181
6182 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6183
94515237
JB
61842011-06-27 Juanma Barranquero <lekktu@gmail.com>
6185
6186 * makefile.w32-in: Redesign dependencies so they reflect more
6187 clearly which files are directly included by each source file,
6188 and not through other includes.
6189
e43b6e43
MR
61902011-06-27 Martin Rudalics <rudalics@gmx.at>
6191
6192 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6193 (sort_overlays, overlay_strings): When an overlay's clone number
6194 matches the window's clone number process the overlay even if
6195 the overlay's window property doesn't match the current window.
6196
d68443dc
MR
6197 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6198 (Fwindow_hchild): Rename to Fwindow_left_child.
6199 (Fwindow_next): Rename to Fwindow_next_sibling.
6200 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6201 (resize_window_check): Rename to window_resize_check.
6202 (resize_window_apply): Rename to window_resize_apply.
6203 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6204 (Fdelete_other_windows_internal, resize_frame_windows)
6205 (Fsplit_window_internal, Fdelete_window_internal)
6206 (grow_mini_window, shrink_mini_window)
6207 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6208
c7e73be5
JD
62092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6210
6211 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6212 (emacs_fixed_set_min_size): Remove.
6213 (emacs_fixed_new): Take frame as argument.
6214
6215 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6216 (_EmacsFixedPrivate): Remove minwidth/height.
6217 Add struct frame *f.
6218 (emacs_fixed_init): Initialize priv->f.
6219 (get_parent_class, emacs_fixed_set_min_size): Remove.
6220 (emacs_fixed_new): Set priv->f to argument.
6221 (emacs_fixed_get_preferred_width)
6222 (emacs_fixed_get_preferred_height): Use min_width/height from
6223 frames size_hint to set minimum and natural (Bug#8919).
6224 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6225 and use min_width/height from frames size_hint to set
6226 min_width/height (Bug#8919).
6227
6228 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6229 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6230 Fix indentation.
c7e73be5 6231
cf99dcf8
EZ
62322011-06-26 Eli Zaretskii <eliz@gnu.org>
6233
6234 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6235 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6236 called at ZV.
6237
029529ac
CY
62382011-06-26 Chong Yidong <cyd@stupidchicken.com>
6239
6240 * process.c (wait_reading_process_output): Bypass select if
6241 waiting for a cell while ignoring keyboard input, and input is
6242 pending. Suggested by Jan Djärv (Bug#8869).
6243
7a7ef429
PE
62442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6245
6246 Use gnulib's dup2 module instead of rolling our own.
6247 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6248
11fdef7d 62492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6250
6251 * dispnew.c (scrolling_window): Before scrolling, turn off a
6252 mouse-highlight in the window being scrolled.
6253
cd3520a4
JB
62542011-06-24 Juanma Barranquero <lekktu@gmail.com>
6255
6256 Move DEFSYM to lisp.h and use everywhere.
6257
6258 * character.h (DEFSYM): Move declaration...
6259 * lisp.h (DEFSYM): ...here.
6260
6261 * gnutls.c:
6262 * minibuf.c:
6263 * w32menu.c:
6264 * w32proc.c:
6265 * w32select.c: Don't include character.h.
6266
6267 * alloc.c (syms_of_alloc):
6268 * buffer.c (syms_of_buffer):
6269 * bytecode.c (syms_of_bytecode):
6270 * callint.c (syms_of_callint):
6271 * casefiddle.c (syms_of_casefiddle):
6272 * casetab.c (init_casetab_once):
6273 * category.c (init_category_once, syms_of_category):
6274 * ccl.c (syms_of_ccl):
6275 * cmds.c (syms_of_cmds):
6276 * composite.c (syms_of_composite):
6277 * dbusbind.c (syms_of_dbusbind):
6278 * dired.c (syms_of_dired):
6279 * dispnew.c (syms_of_display):
6280 * doc.c (syms_of_doc):
6281 * editfns.c (syms_of_editfns):
6282 * emacs.c (syms_of_emacs):
6283 * eval.c (syms_of_eval):
6284 * fileio.c (syms_of_fileio):
6285 * fns.c (syms_of_fns):
6286 * frame.c (syms_of_frame):
6287 * fringe.c (syms_of_fringe):
6288 * insdel.c (syms_of_insdel):
6289 * keymap.c (syms_of_keymap):
6290 * lread.c (init_obarray, syms_of_lread):
6291 * macros.c (syms_of_macros):
6292 * msdos.c (syms_of_msdos):
6293 * print.c (syms_of_print):
6294 * process.c (syms_of_process):
6295 * search.c (syms_of_search):
6296 * sound.c (syms_of_sound):
6297 * syntax.c (init_syntax_once, syms_of_syntax):
6298 * terminal.c (syms_of_terminal):
6299 * textprop.c (syms_of_textprop):
6300 * undo.c (syms_of_undo):
6301 * w32.c (globals_of_w32):
6302 * window.c (syms_of_window):
6303 * xdisp.c (syms_of_xdisp):
6304 * xfaces.c (syms_of_xfaces):
6305 * xfns.c (syms_of_xfns):
6306 * xmenu.c (syms_of_xmenu):
6307 * xsettings.c (syms_of_xsettings):
6308 * xterm.c (syms_of_xterm): Use DEFSYM.
6309
4228cf16
TZ
63102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6311
cd3520a4 6312 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6313
7fcccf1e
PE
63142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6315
7efb4e0e
PE
6316 Integer and buffer overflow fixes (Bug#8873).
6317
ff5844ad
PE
6318 * print.c (printchar, strout): Check for string overflow.
6319 (PRINTPREPARE, printchar, strout):
6320 Don't set size unless allocation succeeds.
6321
90532f02
PE
6322 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6323 for sizes. Check for string overflow more accurately.
6324 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6325
6d84508d
PE
6326 * macros.c: Integer and buffer overflow fixes.
6327 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6328 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6329 Use ptrdiff_t, not int, for sizes.
6330 Don't increment bufsize until after realloc succeeds.
6331 Check for size-calculation overflow.
6332 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6333
437b2cb4
PE
6334 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6335
8b9ac8b4
PE
6336 * lread.c: Integer overflow fixes.
6337 (read_integer): Radix is now EMACS_INT, not int,
6338 to improve quality of diagnostics for out-of-range radices.
6339 Calculate buffer size correctly for out-of-range radices.
6340 (read1): Check for integer overflow in radices, and in
6341 read-circle numbers.
82cb60d3
PE
6342 (read_escape): Avoid int overflow.
6343 (Fload, openp, read_buffer_size, read1)
6344 (substitute_object_recurse, read_vector, read_list, map_obarray):
6345 Use ptrdiff_t, not int, for sizes.
6346 (read1): Use EMACS_INT, not int, for sizes.
20270765 6347 Check for size overflow.
8b9ac8b4 6348
7fcccf1e
PE
6349 * image.c (cache_image): Check for size arithmetic overflow.
6350
bfbbd7e7
PE
6351 * lread.c: Integer overflow issues.
6352 (saved_doc_string_size, saved_doc_string_length)
6353 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6354 Now ptrdiff_t, not int.
6355 (read1): Don't assume doc string length fits in int. Check for
6356 out-of-range doc string lengths.
6357 (read_list): Don't assume file position fits in int.
39019e54 6358 (read_escape): Check for hex character overflow.
bfbbd7e7 6359
4e323265
LL
63602011-06-22 Leo Liu <sdl.web@gmail.com>
6361
6362 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6363 Move to minibuffer.el.
6364
85fece3e
PE
63652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6366
20b84ce9 6367 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6368 The following patches are for when GLYPH_DEBUG && !XASSERT.
6369 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6370 * dispnew.c (flush_stdout):
6371 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6372 Mark as externally visible.
6373 * dispnew.c (check_window_matrix_pointers): Now static.
6374 * dispnew.c (window_to_frame_vpos):
6375 * xfns.c (unwind_create_frame):
6376 * xterm.c (x_check_font): Remove unused local.
6377 * scroll.c (CHECK_BOUNDS):
6378 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6379 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6380 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6381 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6382 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6383 Now static.
6384 (debug_method_add): Use va_list and vsprintf rather than relying
6385 on undefined behavior with wrong number of arguments.
6386 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6387 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6388 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6389 since we're not interested in debugging glyphs with old libraries.
6390 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6391 GCC 4.6.0's static checking.
6392
0766b489
PE
63932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6394
31fd4b32
PE
6395 Integer overflow and signedness fixes (Bug#8873).
6396 A few related buffer overrun fixes, too.
6397
b79e8648
PE
6398 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6399
0766b489
PE
6400 * dispextern.h (struct face.stipple):
6401 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6402 (x_bitmap_mask, x_allocate_bitmap_record)
6403 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6404 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6405 (x_create_bitmap_from_xpm_data):
6406 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6407 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6408 (.bitmaps_last):
6409 * xfaces.c (load_pixmap):
6410 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6411 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6412 (.bitmaps_last, struct x_output.icon_bitmap):
6413 Use ptrdiff_t, not int, for bitmap indexes.
6414 (x_allocate_bitmap_record): Check for size overflow.
6415 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6416
b081724f
PE
6417 Use ptrdiff_t, not int, for overlay counts.
6418 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6419 * editfns.c (overlays_around, get_pos_property):
6420 * textprop.c (get_char_property_and_overlay):
6421 * xdisp.c (next_overlay_change, note_mouse_highlight):
6422 * xfaces.c (face_at_buffer_position):
21514da7
PE
6423 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6424 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6425 (Fnext_overlay_change, Fprevious_overlay_change)
6426 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6427 Use ptrdiff_t, not int, for sizes.
21514da7 6428 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6429
3de73e5e
PE
6430 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6431
2606c57b
PE
6432 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6433 (x_session_initialize): Do not assume string length fits in int.
6434
aaafe47a
PE
6435 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6436 This is unlikely, but can occur if DPI is outlandish.
6437
2674ddc8 6438 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6439 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6440
28154962
PE
6441 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6442 * xrdb.c (magic_file_p, search_magic_path):
6443 Omit last arg SUFFIX; it was always 0. All callers changed.
6444 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6445
7de51af5
PE
6446 * xfont.c (xfont_match): Avoid need for strlen.
6447
25ed6cc3
PE
6448 * xfns.c: Don't assume strlen fits in int.
6449 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6450
4eab31dd
PE
6451 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6452 not unsigned long, as we prefer signed integers. All callers changed.
6453 Detect integer overflow in repeat count.
6454 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6455 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6456
171e2a58
PE
6457 * termcap.c: Don't assume sizes fit in int and never overflow.
6458 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6459 (gobble_line): Check for size-calculation overflow.
6460
ad39faca 6461 * minibuf.c (Fread_buffer):
6e5bb2dc 6462 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6463 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6464 Don't assume string length fits in int.
6465
52c61c22 6466 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6467 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6468
b5b8c9e5
PE
6469 * font.c: Don't assume string length fits in int.
6470 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6471 Use ptrdiff_t, not int.
ccd6111c
PE
6472 (font_intern_prop): Don't assume string length fits in int.
6473 Don't assume integer property fits in fixnum.
6474 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6475
882f0d81 6476 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6477 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6478 Reformulate so as not to need the command string.
6479 Invoke gzip -cd rather than gunzip, as it's more portable.
6480 (lock_info_type, lock_file_1, lock_file):
6481 Don't assume pid_t and time_t fit in unsigned long.
6482 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6483 (current_lock_owner): Prefer signed type for sizes.
6484 Use memcpy, not strncpy, where memcpy is what is really wanted.
6485 Don't assume (via atoi) that time_t and pid_t fit in int.
6486 Check for time_t and/or pid_t out of range, e.g., via a network share.
6487 Don't alloca where an auto var works fine.
6488
93f4cf88
PE
6489 * fileio.c: Fix some integer overflow issues.
6490 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6491 Don't assume string length fits in int.
6492 (directory_file_name): Don't assume string length fits in long.
6493 (make_temp_name): Don't assume pid fits in int, or that its print
6494 length is less than 20.
6495
f3e92b69
PE
6496 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6497
1bfdaf10
PE
6498 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6499
35016e9a
PE
6500 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6501
3d1e65a1
PE
6502 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6503 We prefer signed integers, even for size calculations.
6504
0b963a93
PE
6505 * emacs.c: Don't assume string length fits in 'int'.
6506 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6507 (main): Don't invoke strlen when not needed.
6508
573f4b54
PE
6509 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6510 (XD_DEBUG_MESSAGE): Don't waste a byte.
6511
989f33ba
PE
6512 * callproc.c (getenv_internal_1, getenv_internal)
6513 (Fgetenv_internal):
965d34eb
PE
6514 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6515
e4d29b33
PE
6516 * lread.c (invalid_syntax): Omit length argument.
6517 All uses changed. This doesn't fix a bug, but it simplifies the
6518 code away from its former Hollerith-constant appearance, and it's
6519 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6520 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6521
eb49b136
PE
6522 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6523 This didn't break anything, but it didn't help either.
6524 It's confusing to put a bogus integer in a place where the actual
6525 value does not matter.
9f62aeb1 6526 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6527 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6528
15375a22
PE
6529 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6530 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6531 implementation.
b61cc01c
PE
6532 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6533 We prefer signed types, and the value cannot exceed the EMACS_INT
6534 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6535 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6536 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6537 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6538
53b2623d
PE
6539 * indent.c (sane_tab_width): New function.
6540 (current_column, scan_for_column, Findent_to, position_indentation)
6541 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6542 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6543
51cab52b 6544 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6545
f2ed8a70
PE
6546 * lisp.h (lint_assume): New macro.
6547 * composite.c (composition_gstring_put_cache):
6548 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6549
abe80cc6
PE
6550 * editfns.c, insdel.c:
6551 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6552
b02c740e
PE
6553 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6554
ebc96716
PE
6555 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6556
b4e50fa0 6557 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6558 Use much-faster test for byte-length change.
311d5d7c 6559 Don't assume string byte-length fits in 'int'.
a4cf38e4 6560 Check that character arg fits in 'int'.
85461888 6561 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6562
c0c1ee9f
PE
6563 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6564
a498d7f4
PE
6565 * fns.c (concat): Catch string overflow earlier.
6566 Do not rely on integer wraparound.
6567
51cab52b
PE
6568 * dispextern.h (struct it.overlay_strings_charpos)
6569 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6570 * xdisp.c (forward_to_next_line_start)
6571 (back_to_previous_visible_line_start)
6572 (reseat_at_next_visible_line_start, next_element_from_buffer):
6573 Don't arbitrarily truncate the value of 'selective' to int.
6574
76031fad
PE
6575 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6576
5eb55db9
PE
6577 * composite.c: Don't truncate sizes to 'int'.
6578 (composition_gstring_p, composition_reseat_it)
6579 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6580 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6581 not EMACS_UINT, for indexes.
5eb55db9 6582
0703a717
PE
6583 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6584
d6202519
PE
6585 * buffer.c: Include <verify.h>.
6586 (struct sortvec.priority, struct sortstr.priority):
8961a454 6587 Now EMACS_INT, not int.
c20998a7 6588 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6589 (struct sortstr.size, record_overlay_string)
6590 (struct sortstrlist.size, struct sortlist.used):
6591 Don't truncate size to int.
6592 (record_overlay_string): Check for size-calculation overflow.
d6202519 6593 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6594
d5a19415
JM
65952011-06-22 Jim Meyering <meyering@redhat.com>
6596
029529ac 6597 Don't leak an XBM-image-sized buffer
d5a19415
JM
6598 * image.c (xbm_load): Free the image buffer after using it.
6599
a9041e6c
PE
66002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6601
6602 Port to Sun C.
6603 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6604 that Sun C diagnosed.
6605 * fns.c (secure_hash): Fix pointer signedness issue.
6606 * intervals.c (static_offset_intervals): New function.
6607 (offset_intervals): Use it.
6608
7f3f739f
LL
66092011-06-21 Leo Liu <sdl.web@gmail.com>
6610
6611 * deps.mk (fns.o):
6612 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6613 sha512.h.
6614
6615 * fns.c (secure_hash): Rename from crypto_hash_function and change
6616 the first arg to accept symbols.
5b66d427 6617 (Fsecure_hash): New primitive.
7f3f739f
LL
6618 (syms_of_fns): New symbols.
6619
76147d94
DD
66202011-06-20 Deniz Dogan <deniz@dogan.se>
6621
6622 * process.c (Fset_process_buffer): Clarify return value in
6623 docstring.
6624
7d7d0045
CY
66252011-06-18 Chong Yidong <cyd@stupidchicken.com>
6626
6627 * dispnew.c (add_window_display_history): Use BVAR.
6628
6629 * xdisp.c (debug_method_add): Use BVAR.
6630 (check_window_end, dump_glyph_matrix, dump_glyph)
6631 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6632
6633 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6634 Likewise.
6635
6636 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6637 check till after the cache is created in init_frame_faces.
6638
ff2bc410
SM
66392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6640
6641 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6642
28177add
PE
66432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6644
dd3482fe
PE
6645 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6646 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6647 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6648
393d71f3 6649 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6650 * fileio.c (Finsert_file_contents):
6651 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6652 Remove the old (too-loose) buffer overflow checks.
6653 They weren't needed, since make_gap checks for buffer overflow.
6654 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6655 The old code merely checked for Emacs fixnum overflow, and relied
6656 on undefined (wraparound) behavior. The new code avoids undefined
6657 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6658
2e6813b0 6659 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6660 Tune. Don't use wider integers than needed. Don't use alloca.
6661 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6662
599a9e4f
PE
6663 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6664
99561444
PE
6665 * insdel.c, lisp.h (buffer_overflow): New function.
6666 (insert_from_buffer_1, replace_range, replace_range_2):
6667 * insdel.c (make_gap_larger):
6668 * editfns.c (Finsert_char):
6669 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6670
28177add
PE
6671 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6672
e69dafad
PE
66732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6674
4baa020d 6675 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6676
b1c46f02
PE
6677 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6678 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6679
e69dafad
PE
6680 * fileio.c: Don't assume EMACS_INT fits in off_t.
6681 (emacs_lseek): New static function.
6682 (Finsert_file_contents, Fwrite_region): Use it.
6683 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6684
566684ea
PE
6685 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6686
e6966cd6
PE
6687 * fns.c: Don't overflow int when computing a list length.
6688 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6689 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6690 truncation on 64-bit hosts. Check for QUIT every
6691 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6692 faster and is responsive enough.
6693 (Flength): Report an error instead of overflowing an integer.
6694 (Fsafe_length): Return a float if the value is not representable
6695 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6696 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6697 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6698
dd0b0efb
PE
6699 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6700 (header_size, word_size): New constants.
6701 (allocate_vectorlike): Don't check size overflow here.
6702 (allocate_vector): Check it here instead, since this is the only
6703 caller of allocate_vectorlike that could cause overflow.
6704 Check that the new vector's length is representable as a fixnum.
6705
86fe5cfe
PE
6706 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6707 The previous code was bogus. For example, next_almost_prime (32)
6708 returned 39, which is undesirable as it is a multiple of 3; and
6709 next_almost_prime (24) returned 25, which is a multiple of 5 so
6710 why was the code bothering to check for multiples of 7?
6711
80e88859
PE
6712 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6713
4a2f0ad6
PE
6714 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6715
f66c7cf8
PE
6716 Variadic C functions now count arguments with ptrdiff_t.
6717 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6718 Back then I didn't know that the Emacs coding style prefers signed int.
6719 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6720 were being counted with int, which may truncate counts on 64-bit
6721 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6722 * lisp.h (struct Lisp_Subr.function.aMANY)
6723 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6724 Arg counts are now ptrdiff_t, not size_t.
6725 All variadic functions and their callers changed accordingly.
6726 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6727 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6728 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6729 * callint.c (Fcall_interactively): Check arg count for overflow,
6730 to avoid potential buffer overrun. Use signed char, not 'int',
6731 for 'varies' array, so that we needn't bother to check its size
6732 calculation for overflow.
6733 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6734 * eval.c (apply_lambda):
6735 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6736 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6737 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6738
a1759b76
PE
6739 * callint.c (Fcall_interactively): Don't use index var as event count.
6740
d96be9fc
PE
6741 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6742 * mem-limits.h (SIZE): Remove; no longer used.
6743
a690a978 6744 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6745
578c21e6
PE
6746 Remove unnecessary casts.
6747 * xterm.c (x_term_init):
6748 * xfns.c (x_set_border_pixel):
6749 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6750 These aren't needed now that we assume ANSI C.
6751
96f53c6c
PE
6752 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6753 It's more likely to cause problems (due to unsigned overflow)
6754 than to cure them.
6755
83c77d31
PE
6756 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6757
ee2079f1
PE
6758 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6759
6da65536
PE
6760 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6761
7147c4a4
PE
6762 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6763
193e32d9
PE
6764 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6765
e5533da6
PE
6766 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6767
9910e595
PE
6768 GLYPH_CODE_FACE returns EMACS_INT, not int.
6769 * dispextern.h (merge_faces):
6770 * xfaces.c (merge_faces):
01103c44
PE
6771 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6772 Don't assume EMACS_INT fits in int.
9910e595 6773
2638320e
PE
6774 * character.h (CHAR_VALID_P): Remove unused parameter.
6775 * fontset.c, lisp.h, xdisp.c: All uses changed.
6776
045eb8d9
PE
6777 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6778
c1f134b5
PE
6779 * fns.c (concat): Minor tuning based on overflow analysis.
6780 This doesn't fix any bugs. Use int to hold character, instead
6781 of constantly refetching from Emacs object. Use XFASTINT, not
6782 XINT, for value known to be a character. Don't bother comparing
6783 a single byte to 0400, as it's always less.
6784
395fcb93 6785 * floatfns.c (Fexpt):
327eeec8
PE
6786 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6787
abbd3d23
PE
6788 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6789 for characters.
6790
684a03ef
PE
6791 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6792
0fed43f3
PE
6793 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6794 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6795 incorrectly succeed when S was a string, because 4294967386 was
6796 truncated before it was used.
6797
8fd02eb7
PE
6798 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6799 Otherwise, an out-of-range integer could cause undefined behavior
6800 on a 64-bit host.
6801
f8c86b69
PE
6802 * composite.c: Use int, not EMACS_INT, for characters.
6803 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6804 EMACS_INT, for values that are known to be in character range.
6805 This doesn't fix any bugs but is the usual style inside Emacs and
6806 may generate better code on 32-bit machines.
6807
34206dd2
PE
6808 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6809 This is for reasons similar to the recent CHAR_STRING fix.
6810 * charset.c (Fencode_char): Check that character arg is actually
6811 a character. Pass an int to ENCODE_CHAR.
6812 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6813 wider than 'int', as a compile-time check to prevent future regressions
6814 in this area.
6815
c5958d4c 6816 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
6817
6818 Make sure a 64-bit char is never passed to CHAR_STRING.
6819 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6820 by silently ignoring the top 32 bits, allowing some values
6821 that were far too large to be valid characters.
6822 * character.h: Include <verify.h>.
6823 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6824 arguments are no wider than unsigned, as a compile-time check
6825 to prevent future regressions in this area.
6826 * data.c (Faset):
01103c44 6827 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6828 (Fsubst_char_in_region):
6829 * fns.c (concat):
6830 * xdisp.c (decode_mode_spec_coding):
6831 Adjust to CHAR_STRING's new requirement.
6832 * editfns.c (Finsert_char, Fsubst_char_in_region):
6833 * fns.c (concat): Check that character args are actually
6834 characters. Without this test, these functions did the wrong
6835 thing with wildly out-of-range values on 64-bit hosts.
6836
d37ca623
PE
6837 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6838 These casts should not be needed on 32-bit hosts, either.
6839 * keyboard.c (read_char):
6840 * lread.c (Fload): Remove casts to unsigned.
6841
ea204efb
PE
6842 * lisp.h (UNSIGNED_CMP): New macro.
6843 This fixes comparison bugs on 64-bit hosts.
6844 (ASCII_CHAR_P): Use it.
6845 * casefiddle.c (casify_object):
01103c44 6846 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6847 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6848 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6849 * dispextern.h (FACE_FROM_ID):
6850 * keyboard.c (read_char): Use UNSIGNED_CMP.
6851
41cb286c
PE
6852 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6853 not to EMACS_INT, to avoid GCC warning.
6854
4a1b9832
PE
6855 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6856
55daad71
PE
6857 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6858 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6859 isn't needed on 32-bit machines.
8f95c75c 6860
01103c44
PE
6861 * buffer.c (Fgenerate_new_buffer_name):
6862 Use EMACS_INT for count, not int.
0ceccced 6863 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6864
6865 * data.c (Qcompiled_function): Now static.
6866
c6f072e7
PE
6867 * window.c (window_body_lines): Now static.
6868
20ce5912
PE
6869 * image.c (gif_load): Rename local to avoid shadowing.
6870
9c4c5f81
PE
6871 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6872 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6873 * alloc.c (make_save_value): Integer argument is now of type
6874 ptrdiff_t, not int.
6875 (mark_object): Use ptrdiff_t, not int.
6876 * lisp.h (pD): New macro.
6877 * print.c (print_object): Use it.
6878
c0c5c8ae
PE
6879 * alloc.c: Use EMACS_INT, not int, to count objects.
6880 (total_conses, total_markers, total_symbols, total_vector_size)
6881 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6882 (total_free_floats, total_floats, total_free_intervals)
6883 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6884 Now EMACS_INT, not int. All uses changed.
6885 (Fgarbage_collect): Compute overall total using a double, so that
6886 integer overflow is less likely to be a problem. Check for overflow
6887 when converting back to an integer.
5a25e253
PE
6888 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6889 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6890 These were 'int' variables that could overflow on 64-bit hosts;
6891 they were never used, so remove them instead of repairing them.
211a0b2a 6892 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6893 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6894 Previously, this ceilinged at INT_MAX, but that doesn't work on
6895 64-bit machines.
e46bb31a 6896 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6897
c78baabf 6898 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6899 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6900 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6901 when a (possibly-narrower) signed value would do just as well.
6902 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6903
c9d624c6
PE
6904 * alloc.c: Catch some string size overflows that we were missing.
6905 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6906 for convenience in STRING_BYTES_MAX.
6907 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6908 The definition here is exact; the one in lisp.h was approximate.
6909 (allocate_string_data): Check for string overflow. This catches
6910 some instances we weren't catching before. Also, it catches
6911 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6912 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6913 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6914
c9d624c6
PE
6915 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6916 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6917 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6918
353032ce
PE
6919 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6920
2bccce07
PE
6921 * alloc.c (Fmake_string): Check for out-of-range init.
6922
0ac30604
SM
69232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6924
6925 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6926
c195f2de
JD
69272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6928
6929 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6930 xg_get_default_scrollbar_width.
6931
6932 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6933 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6934 (style_changed_cb): Call update_theme_scrollbar_width and call
6935 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6936 all frames (Bug#8505).
6937 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6938 Call gtk_window_set_resizable if HAVE_GTK3.
6939 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6940 and height if HAVE_GTK3 (Bug#8505).
6941 (scroll_bar_width_for_theme): New variable.
6942 (update_theme_scrollbar_width): New function.
6943 (xg_get_default_scrollbar_width): Move code to
6944 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6945 (xg_initialize): Call update_theme_scrollbar_width.
6946
6947 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6948
6949 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6950
e10ac9f1
MR
69512011-06-12 Martin Rudalics <rudalics@gmx.at>
6952
6953 * frame.c (make_frame): Call other_buffer_safely instead of
6954 other_buffer.
6955
6956 * window.c (temp_output_buffer_show): Call display_buffer with
6957 second argument Vtemp_buffer_show_specifiers and reset latter
6958 immediately after the call.
6959 (Vtemp_buffer_show_specifiers): New variable.
6960 (auto_window_vscroll_p, next_screen_context_lines)
6961 (Vscroll_preserve_screen_position): Remove leading asterisks from
6962 doc-strings.
6963
2d3c217e 69642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6965
7b7f97e8 6966 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6967 * buffer.c (Qclone_number): Remove for now, as it's unused.
6968 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6969 (record_buffer): Remove unused local.
6970 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6971 (set_frame_buffer_list): Remove; unused.
6972 * frame.h (other_visible_frames): Remove decl.
6973 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6974 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6975 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6976 if HAVE_GPM.
6977 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6978 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6979 Define only if HAVE_GPM.
6980 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6981 (update_hints_inhibit): Remove; never set. All uses removed.
6982 * widgetprv.h (emacsFrameClassRec): Remove decl.
6983 * window.c (delete_deletable_window): Now returns void, since it
6984 wasn't returning anything.
6985 (compare_window_configurations): Remove unused locals.
6986 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6987 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6988 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6989 the same widths as pointers. This follows up on the 2011-05-06 patch.
6990 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6991 * xterm.h: Likewise.
6992 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6993
1384b89e
JB
69942011-06-12 Juanma Barranquero <lekktu@gmail.com>
6995
6996 * makefile.w32-in: Update dependencies.
6997 (LISP_H): Add lib/intprops.h.
6998
1100a63c
CY
69992011-06-11 Chong Yidong <cyd@stupidchicken.com>
7000
7001 * image.c (gif_load): Add animation frame delay to the metadata.
7002 (syms_of_image): Use DEFSYM. New symbol `delay'.
7003
6198ccd0
MR
70042011-06-11 Martin Rudalics <rudalics@gmx.at>
7005
7006 * window.c (delete_deletable_window): Re-add.
7007 (Fset_window_configuration): Rewrite to handle dead buffers and
7008 consequently deletable windows.
7009 (window_tree, Fwindow_tree): Remove. Supply functionality in
7010 window.el.
7011 (compare_window_configurations): Simplify code.
7012
b6e3633c
AS
70132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7014
1ab0dee5
AS
7015 * image.c (imagemagick_load_image): Fix type mismatch.
7016 (Fimagemagick_types): Likewise.
7017
b6e3633c
AS
7018 * window.h (replace_buffer_in_windows): Declare.
7019
9397e56f
MR
70202011-06-11 Martin Rudalics <rudalics@gmx.at>
7021
7022 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7023 Qclone_number. Remove external declaration of Qdelete_window.
7024 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7025 code.
640c8776
SM
7026 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7027 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7028 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7029 buffer list implementation.
7030 (other_buffer_safely): New function.
7031 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7032 calls to replace_buffer_in_windows and
7033 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7034 if allowed.
7035 (record_buffer): Inhibit quitting and rewrite using quittable
7036 functions. Run Qbuffer_list_update_hook if allowed.
7037 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7038 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7039 Move switch-to-buffer to window.el.
9397e56f
MR
7040 (bury-buffer): Move to window.el.
7041 (Vbuffer_list_update_hook): New variable.
7042
7043 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7044 section.
7045
7046 * window.h (resize_frame_windows): Move up in code.
7047 (Fwindow_frame): Remove EXFUN.
7048 (replace_buffer_in_all_windows): Remove prototype.
7049 (replace_buffer_in_windows_safely): Add prototype.
7050
7051 * window.c: Declare Qdelete_window static again. Move down
7052 declaration of select_count.
7053 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7054 (Fother_window): Move to window.el.
7055 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7056 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7057 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7058 window.el.
7059 (replace_buffer_in_windows): Implement by calling
7060 Qreplace_buffer_in_windows.
7061 (replace_buffer_in_all_windows): Remove with some functionality
7062 moved into replace_buffer_in_windows_safely.
7063 (replace_buffer_in_windows_safely): New function.
7064 (select_window_norecord, select_frame_norecord): Move in front
7065 of run_window_configuration_change_hook. Remove now obsolete
7066 declarations.
640c8776
SM
7067 (Fset_window_buffer): Rewrite doc-string.
7068 Call Qrecord_window_buffer.
9397e56f
MR
7069 (keys_of_window): Move binding for other-window to window.el.
7070
b50691aa
CY
70712011-06-11 Chong Yidong <cyd@stupidchicken.com>
7072
7073 * dispextern.h (struct image): Replace data member, whose int_val
7074 and ptr_val fields were not used by anything, with a single
7075 lisp_val object.
7076
7077 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7078 (gif_clear_image, gif_load, imagemagick_load_image)
7079 (gs_clear_image, gs_load): Callers changed.
7080
3f754b86
PE
70812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7082
cca69397
PE
7083 * buffer.h: Include <time.h>, for time_t.
7084 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7085
109e28d0
PE
7086 Fix minor problems found by static checking.
7087
60737f02
PE
7088 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7089
4b66faf3
PE
7090 Make identifiers static if they are not used in other modules.
7091 * data.c (Qcompiled_function, Qframe, Qvector):
7092 * image.c (QimageMagick, Qsvg):
7093 * minibuf.c (Qmetadata):
7094 * window.c (resize_window_check, resize_root_window): Now static.
7095 * window.h (resize_window_check, resize_root_window): Remove decls.
7096
109e28d0
PE
7097 * window.c (window_deletion_count, delete_deletable_window):
7098 Remove; unused.
46a4ce9e
PE
7099 (window_body_lines): Now static.
7100 (Fdelete_other_windows_internal): Mark vars as initialized.
7101 Make sure 'resize_failed' is initialized.
7102 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7103 (resize_window_apply): Remove unused local.
7104 * window.h (delete_deletable_window): Remove decl.
7105
109e28d0 7106 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7107 (imagemagick_load_image): Fix pointer signedness problem by changing
7108 last arg from unsigned char * to char *. All uses changed.
7109 Also, fix a local for similar reasons.
7110 Remove unused locals. Remove locals to avoid shadowing.
7111 (fn_rsvg_handle_free): Remove; unused.
7112 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7113 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7114
3f754b86
PE
7115 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7116
2547adb1
CY
71172011-06-10 Chong Yidong <cyd@stupidchicken.com>
7118
7119 * image.c (gif_load): Fix omitted cast error introduced by
7120 2011-06-06 change.
7121
2c8e37d4
MR
71222011-06-10 Martin Rudalics <rudalics@gmx.at>
7123
7124 * window.h (resize_proportionally, orig_total_lines)
7125 (orig_top_line): Remove from window structure.
7126 (set_window_height, set_window_width, change_window_heights)
7127 (Fdelete_window): Remove prototypes.
7128 (resize_frame_windows): Remove duplicate declaration.
7129
440a42e3
EZ
71302011-06-10 Eli Zaretskii <eliz@gnu.org>
7131
7132 * window.h (resize_frame_windows, resize_window_check)
7133 (delete_deletable_window, resize_root_window)
7134 (resize_frame_windows): Declare prototypes.
7135
7136 * window.c (resize_window_apply): Make definition be "static" to
7137 match the prototype.
7138
562dd5e9
MR
71392011-06-10 Martin Rudalics <rudalics@gmx.at>
7140
7141 * window.c: Remove declarations of Qwindow_size_fixed,
7142 window_min_size_1, window_min_size_2, window_min_size,
7143 size_window, window_fixed_size_p, enlarge_window, delete_window.
7144 Remove static from declaration of Qdelete_window, it's
7145 temporarily needed by Fbury_buffer.
7146 (replace_window): Don't assign orig_top_line and
7147 orig_total_lines.
7148 (Fdelete_window, delete_window): Remove. Window deletion is
7149 handled by window.el.
640c8776
SM
7150 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7151 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7152 (Fdelete_other_windows): Remove. Deleting other windows is
7153 handled by window.el.
7154 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7155 handled in window.el.
7156 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7157 Window minimum sizes are handled in window.el.
7158 (shrink_windows, size_window, set_window_height)
7159 (set_window_width, change_window_heights, window_height)
7160 (window_width, CURBEG, CURSIZE, enlarge_window)
7161 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7162 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7163 handled in window.el.
7164 (make_dummy_parent): Rename to make_parent_window and give it a
7165 second argument horflag.
7166 (make_window): Don't set resize_proportionally any more.
7167 (Fsplit_window): Remove. Windows are split in window.el.
7168 (save_restore_action, save_restore_orig_size)
7169 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7170 Resize mini windows in window.el.
7171 (grow_mini_window, shrink_mini_window): Implement by calling
7172 Qresize_root_window_vertically, resize_window_check and
7173 resize_window_apply.
640c8776
SM
7174 (saved_window, Fset_window_configuration, save_window_save):
7175 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7176 resize_proportionally.
7177 (window_min_height, window_min_width): Move to window.el.
7178 (keys_of_window): Move bindings for delete-other-windows,
7179 split-window, delete-window and enlarge-window to window.el.
7180
7181 * buffer.c: Temporarily extern Qdelete_window.
7182 (Fbury_buffer): Temporarily call Qdelete_window instead of
7183 Fdelete_window (Fbury_buffer will move to window.el soon).
7184
7185 * frame.c (set_menu_bar_lines_1): Remove code handling
7186 orig_top_line and orig_total_lines.
7187
7188 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7189 set_window_height but set heights directly.
7190 (change_frame_size_1): Use resize_frame_windows.
7191
7192 * xdisp.c (init_xdisp): Don't use set_window_height but set
7193 heights directly.
7194
640c8776
SM
7195 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7196 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7197 run_window_configuration_change_hook.
7198
7199 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7200 instead of change_window_heights and run
7201 run_window_configuration_change_hook.
7202
1a13852e
MR
72032011-06-09 Martin Rudalics <rudalics@gmx.at>
7204
7205 * window.c (replace_window): Rename second argument REPLACEMENT to
7206 NEW. New third argument SETFLAG. Rewrite.
7207 (delete_window, make_dummy_parent): Call replace_window with
7208 third argument 1.
7209 (window_list_1): Move down in code.
7210 (run_window_configuration_change_hook): Move set_buffer part
7211 before select_frame_norecord part in order to unwind correctly.
7212 Rename count1 to count.
7213 (recombine_windows, delete_deletable_window, resize_root_window)
7214 (Fdelete_other_windows_internal)
7215 (Frun_window_configuration_change_hook, make_parent_window)
7216 (resize_window_check, resize_window_apply, Fresize_window_apply)
7217 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7218 (Fdelete_window_internal, Fresize_mini_window_internal):
7219 New functions.
1a13852e
MR
7220 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7221
f3d1777e
MR
72222011-06-08 Martin Rudalics <rudalics@gmx.at>
7223
496e208e
MR
7224 * window.h (window): Add some new members to window structure -
7225 normal_lines, normal_cols, new_total, new_normal, clone_number,
7226 splits, nest, prev_buffers, next_buffers.
7227 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7228 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7229
f3d1777e
MR
7230 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7231 Remove.
496e208e
MR
7232 (make_dummy_parent): Set new members of windows structure.
7233 (make_window): Move down in code. Handle new members of window
7234 structure.
7235 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7236 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7237 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7238 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7239 (Fset_window_next_buffers, Fset_window_clone_number):
7240 New functions.
496e208e
MR
7241 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7242 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7243 Doc-string fixes.
7244 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7245 Argument WINDOW can be now internal window too.
7246 (Fwindow_use_time): Move up in code.
7247 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7248 Rewrite doc-string.
7249 (Fset_window_configuration, saved_window)
7250 (Fcurrent_window_configuration, save_window_save): Handle new
7251 members of window structure.
b9e809c2
MR
7252 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7253 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7254 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7255 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7256 Qget_mru_window, Qresize_root_window,
7257 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7258 Qauto_buffer_name; staticpro them.
f3d1777e 7259
abde8f8c
MR
72602011-06-07 Martin Rudalics <rudalics@gmx.at>
7261
7262 * window.c (Fwindow_total_size, Fwindow_left_column)
7263 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7264 (Fwindow_list_1): New functions.
7265 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7266 (Fwindow_width, Fscroll_left, Fscroll_right):
7267 Use window_body_cols instead of window_box_text_cols.
7268 (delete_window, Fset_window_configuration):
7269 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7270 (delete_all_subwindows): Take a window as argument and not a
7271 structure. Rewrite.
190b47e6
MR
7272 (window_loop): Remove handling of GET_LRU_WINDOW and
7273 GET_LARGEST_WINDOW.
7274 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7275
7276 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7277 window_box_text_cols. delete_all_subwindows now takes a
7278 Lisp_Object as argument.
abde8f8c 7279
640c8776
SM
7280 * indent.c (compute_motion, Fcompute_motion):
7281 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7282
fa8a67e6
MR
7283 * frame.c (delete_frame): Call delete_all_subwindows with root
7284 window as argument.
7285
a54e3482
DC
72862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7287
7288 * fns.c (Fputhash): Document return value.
7289
60002bf5
CY
72902011-06-06 Chong Yidong <cyd@stupidchicken.com>
7291
7292 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7293
0c671da6 72942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7295
b862a52a 7296 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7297
be44ca6c
PE
7298 Check for overflow when converting integer to cons and back.
7299 * charset.c (Fdefine_charset_internal, Fdecode_char):
7300 Use cons_to_unsigned to catch overflow.
7301 (Fencode_char): Use INTEGER_TO_CONS.
7302 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7303 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7304 * data.c (long_to_cons, cons_to_long): Remove.
7305 (cons_to_unsigned, cons_to_signed): New functions.
7306 These signal an error for invalid or out-of-range values.
7307 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7308 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7309 * font.c (Ffont_variation_glyphs):
7310 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7311 * lisp.h: Include <intprops.h>.
7312 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7313 (cons_to_signed, cons_to_unsigned): New decls.
7314 (long_to_cons, cons_to_long): Remove decls.
7315 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7316 (Fprimitive_undo): Use CONS_TO_INTEGER.
7317 * xfns.c (Fx_window_property): Likewise.
7318 * xselect.c: Include <limits.h>.
7319 (x_own_selection, selection_data_to_lisp_data):
7320 Use INTEGER_TO_CONS.
7321 (x_handle_selection_request, x_handle_selection_clear)
7322 (x_get_foreign_selection, Fx_disown_selection_internal)
7323 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7324 (lisp_data_to_selection_data): Use cons_to_unsigned.
7325 (x_fill_property_data): Use cons_to_signed.
7326 Report values out of range.
7327
d1f3d2af
PE
7328 Check for buffer and string overflow more precisely.
7329 * buffer.h (BUF_BYTES_MAX): New macro.
7330 * lisp.h (STRING_BYTES_MAX): New macro.
7331 * alloc.c (Fmake_string):
7332 * character.c (string_escape_byte8):
7333 * coding.c (coding_alloc_by_realloc):
7334 * doprnt.c (doprnt):
7335 * editfns.c (Fformat):
7336 * eval.c (verror):
7337 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7338 since they may not be the same number.
7339 * editfns.c (Finsert_char):
7340 * fileio.c (Finsert_file_contents):
7341 Likewise for BUF_BYTES_MAX.
7342
dd52fcea
PE
7343 * image.c: Use ptrdiff_t, not int, for sizes.
7344 (slurp_file): Switch from int to ptrdiff_t.
7345 All uses changed.
7346 (slurp_file): Check that file size fits in both size_t (for
7347 malloc) and ptrdiff_t (for sanity and safety).
7348
7f9bbdbb
PE
7349 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7350 if b->modtime has its maximal value.
7351
dfe18f82
PE
7352 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7353
84acfcf0
PE
7354 Don't assume time_t can fit into int.
7355 * buffer.h (struct buffer.modtime): Now time_t, not int.
7356 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7357 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7358
ccd9a01a
PE
7359 Minor fixes for signed vs unsigned integers.
7360 * character.h (MAYBE_UNIFY_CHAR):
7361 * charset.c (maybe_unify_char):
7362 * keyboard.c (read_char, reorder_modifiers):
7363 XINT -> XFASTINT, since the integer must be nonnegative.
7364 * ftfont.c (ftfont_spec_pattern):
7365 * keymap.c (access_keymap, silly_event_symbol_error):
7366 XUINT -> XFASTINT, since the integer must be nonnegative.
7367 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7368 since it makes no difference and we prefer signed.
7369 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7370 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7371 nonnegative.
7372
d6d100dd
SM
73732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7374
7375 * window.h (Fwindow_frame): Declare.
7376
2b6148e4
PE
73772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7378
7379 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7380 (SPARE_MEMORY): Always define.
7381 (LARGE_REQUEST): Remove.
7382 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7383
f230ecc9
MR
73842011-06-06 Martin Rudalics <rudalics@gmx.at>
7385
727e958e
MR
7386 * lisp.h: Move EXFUNS for Fframe_root_window,
7387 Fframe_first_window and Fset_frame_selected_window to window.h.
7388
7389 * window.h: Move EXFUNS for Fframe_root_window,
7390 Fframe_first_window and Fset_frame_selected_window here from
7391 lisp.h.
7392
7393 * frame.c (Fwindow_frame, Fframe_first_window)
7394 (Fframe_root_window, Fframe_selected_window)
7395 (Fset_frame_selected_window): Move to window.c.
7396 (Factive_minibuffer_window): Move to minibuf.c.
7397 (Fother_visible_frames_p): New function.
7398
7399 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7400
f230ecc9
MR
7401 * window.c (decode_window, decode_any_window): Move up in code.
7402 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7403 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7404 (Fwindow_buffer): Move up and rewrite doc-string.
7405 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7406 (Fwindow_prev): New functions.
727e958e
MR
7407 (Fwindow_frame): Move here from frame.c. Accept any window as
7408 argument.
7409 (Fframe_root_window, Fframe_first_window)
7410 (Fframe_selected_window): Move here from frame.c. Accept frame
7411 or arbitrary window as argument. Update doc-strings.
7412 (Fminibuffer_window): Move up in code.
7413 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7414 (Fset_frame_selected_window): Move here from frame.c.
7415 Marginal rewrite.
727e958e
MR
7416 (Fselected_window, select_window, Fselect_window): Move up in
7417 code. Minor doc-string fixes.
f230ecc9 7418
4d09bcf6
PE
74192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7420
7421 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7422 Do not assume that spare memory exists; that assumption is valid
7423 only if SYSTEM_MALLOC.
7424 (LARGE_REQUEST): New macro, so that the issue of large requests
7425 is separated from the issue of spare memory.
7426
810928a2
AS
74272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7428
172418ad
AS
7429 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7430 format. (Bug#8806)
7431
43f862f7
AS
7432 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7433
810928a2
AS
7434 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7435 before statements.
7436
a059fe24
JD
74372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7438
7439 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7440
7441 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7442
7443 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7444 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7445
989bf368
JB
74462011-06-05 Juanma Barranquero <lekktu@gmail.com>
7447
7448 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7449
4b80f674
CY
74502011-06-04 Chong Yidong <cyd@stupidchicken.com>
7451
7452 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7453 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7454 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7455 New error handlers.
4b80f674
CY
7456 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7457 Obey Vx_select_enable_clipboard_manager. Catch errors in
7458 x_clipboard_manager_save (Bug#8779).
7459 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7460 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7461
99a33b77 74622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7463
7464 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7465
99a33b77 74662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7467
7468 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7469 in the current matrix if keep_current_p is non-zero.
7470
8264569d
EZ
74712011-06-04 Eli Zaretskii <eliz@gnu.org>
7472
7473 * bidi.c (bidi_level_of_next_char): Fix last change.
7474
57f97249
EZ
74752011-06-03 Eli Zaretskii <eliz@gnu.org>
7476
fec2107c 7477 Support bidi reordering of text covered by display properties.
57f97249 7478
fec2107c
EZ
7479 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7480 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7481 (bidi_cache_search, bidi_cache_iterator_state)
7482 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7483 (bidi_level_of_next_char, bidi_move_to_visually_next):
7484 Support character positions inside a run of characters covered by a
fec2107c
EZ
7485 display string.
7486 (bidi_paragraph_init, bidi_resolve_explicit_1)
7487 (bidi_level_of_next_char): Call bidi_fetch_char and
7488 bidi_fetch_char_advance instead of FETCH_CHAR and
7489 FETCH_CHAR_ADVANCE.
7490 (bidi_init_it): Initialize new members.
7491 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7492 definitions.
7493 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7494 instead of using explicit *_CHAR codes.
d6d100dd
SM
7495 (bidi_resolve_explicit, bidi_resolve_weak):
7496 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7497 bidirectional text is supported only in multibyte buffers.
7498 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7499 it to initialize the frame_window_p member of struct bidi_it.
7500 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7501 (bidi_resolve_explicit, bidi_resolve_weak)
7502 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7503 bidi_it->nchars is non-positive.
7504 (bidi_level_of_next_char): Don't try to lookup the cache for the
7505 next/previous character if nothing is cached there yet, or if we
7506 were just reseat()'ed to a new position.
c40e2fb2 7507
0e14fe90
EZ
7508 * xdisp.c (set_cursor_from_row): Set start and stop points
7509 according to the row's direction when priming the loop that looks
7510 for the glyph on which to display cursor.
7511 (single_display_spec_intangible_p): Function deleted.
7512 (display_prop_intangible_p): Reimplement to call
7513 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7514 Accept 3 additional arguments needed by handle_display_spec.
7515 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7516 values: lists, `(when COND...)' forms, etc.
7517 (single_display_spec_string_p): Support property values that are
7518 lists with the argument STRING its top-level element.
7519 (display_prop_string_p): Fix the condition for processing a
7520 property that is a list to be consistent with handle_display_spec.
fec2107c 7521 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7522 last portion of handle_display_prop.
7523 (compute_display_string_pos): Accept additional argument
7524 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7525 value of a `display' property is a "replacing spec".
7526 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7527 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7528 the display property, but just return a value indicating whether
7529 the display property will replace the characters it covers.
7530 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7531 frame_window_p members of struct bidi_it.
d6d100dd
SM
7532 (compute_display_string_pos, compute_display_string_end):
7533 New functions.
fec2107c
EZ
7534 (push_it): Accept second argument POSITION, where pop_it should
7535 jump to continue iteration.
7536 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7537
fec2107c
EZ
7538 * keyboard.c (adjust_point_for_property): Adjust the call to
7539 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7540
7541 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7542 (bidi_init_it): Update prototypes.
7543 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7544 (compute_display_string_pos, compute_display_string_end):
7545 Declare prototypes.
fec2107c
EZ
7546 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7547 EMACS_INT.
fc6f18ce 7548
40087514 75492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7550
57f53182
PE
7551 Malloc failure behavior now depends on size of allocation.
7552 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7553 * lisp.h: Change signatures accordingly.
7554 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7555 All callers changed. (Bug#8762)
7556
7557 * gnutls.c: Use Emacs's memory allocators.
7558 Without this change, the gnutls library would invoke malloc etc.
7559 directly, which causes problems on non-SYNC_INPUT hosts, and which
7560 runs afoul of improving memory_full behavior. (Bug#8761)
7561 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7562 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7563 xfree instead of the default malloc, realloc, free.
7564 (Fgnutls_boot): No need to check for memory allocation failure,
7565 since xmalloc does that for us.
7566
ac32cd99 7567 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7568 * category.c (hash_get_category_set):
7569 * ccl.c (ccl_driver):
7570 * charset.c (Fdefine_charset_internal):
7571 * charset.h (struct charset.hash_index):
7572 * composite.c (get_composition_id, gstring_lookup_cache)
7573 (composition_gstring_put_cache):
7574 * composite.h (struct composition.hash_index):
7575 * dispextern.h (struct image.hash):
7576 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7577 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7578 (hashfn_equal, hashfn_user_defined, make_hash_table)
7579 (maybe_resize_hash_table, hash_lookup, hash_put)
7580 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7581 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7582 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7583 * image.c (make_image, search_image_cache, lookup_image)
7584 (xpm_put_color_table_h):
7585 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7586 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7587 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7588 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7589 * alloc.c (allocate_vectorlike):
7590 Check for overflow in vector size calculations.
7591 * ccl.c (ccl_driver):
7592 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7593 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7594 need to be updated by these changes.
40087514
PE
7595 * fns.c (make_hash_table, maybe_resize_hash_table):
7596 Check for integer overflow with large hash tables.
0de4bb68
PE
7597 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7598 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7599 (SXHASH_REDUCE): New macro.
7600 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7601 Use it instead of discarding useful hash info with large hash values.
7602 (sxhash_float): New function.
7603 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7604 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7605 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7606 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7607 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7608 Adjust signatures to match updated version of code.
7609 (consing_since_gc): Now EMACS_INT, since a single hash table can
7610 use more than INT_MAX bytes.
7611
698d32e2
DN
76122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7613
7614 Make it possible to build with GCC-4.6+ -O2 -flto.
7615
7616 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7617
fd6fa53f
SM
76182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7619
7620 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7621 Call minibuffer-inactive-mode.
7622
864db017
JB
76232011-05-31 Juanma Barranquero <lekktu@gmail.com>
7624
7625 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7626 Update dependencies.
7627
2ad0baf4
DN
76282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7629
7630 * data.c (init_data): Remove code for UTS, this system is not
7631 supported anymore.
7632
4fcc2638
DN
76332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7634
7635 Don't force ./temacs to start in terminal mode.
7636
7637 * frame.c (make_initial_frame): Initialize faces in all cases, not
7638 only when CANNOT_DUMP is defined.
7639 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7640
c56e0fd5
DN
76412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7642
7643 * dispnew.c (add_window_display_history): Use const for the string
7644 pointer. Remove declaration, not needed.
7645
333d54da 76462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7647
55d4c1b2 7648 Use 'inline', not 'INLINE'.
333d54da 7649 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7650 * alloc.c, fontset.c (INLINE): Remove.
7651 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7652 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7653 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7654 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7655 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7656
738db178
DN
76572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7658
7659 Make it possible to run ./temacs.
7660
7661 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7662 syms_of_callproc does the same thing. Remove test for
7663 "initialized", do it in the caller.
7664 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7665
620c53a6
SM
76662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7667
7668 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7669 (read_minibuf): Use get_minibuffer.
7670 (syms_of_minibuf): Use DEFSYM.
7671 (Qmetadata): New var.
7672 * data.c (Qbuffer): Don't make it static.
7673 (syms_of_data): Use DEFSYM.
7674
e003a292
PE
76752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7676
7677 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7678 (CCL_CODE_MIN): New macro.
7679
ed008a6d
PE
76802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7681
3687c2ef
PE
7682 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7683
ed008a6d
PE
7684 * eval.c (Qdebug): Now static.
7685 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7686 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7687 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7688
d66c4c7c
CY
76892011-05-29 Chong Yidong <cyd@stupidchicken.com>
7690
7691 * image.c: Various fixes to ImageMagick code comments.
7692 (Fimagemagick_types): Doc fix.
7693
5fbc2025
PE
76942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7695
0196f88a
PE
7696 Minor fixes prompted by GCC 4.6.0 warnings.
7697
7698 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7699
5fbc2025
PE
7700 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7701 (x_clipboard_manager_save_all): Move extern decl to ...
7702 * xterm.h: ... here, so that it can be checked for consistency.
7703
1dd3c2d9
CY
77042011-05-29 Chong Yidong <cyd@stupidchicken.com>
7705
7706 * xselect.c (x_clipboard_manager_save_frame)
7707 (x_clipboard_manager_save_all): New functions.
7708 (Fx_clipboard_manager_save): Lisp function deleted.
7709
7710 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7711 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7712
7713 * xterm.h: Update prototype.
7714
5ba6571d
WX
77152011-05-28 William Xu <william.xwl@gmail.com>
7716
7717 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7718 exiting (Bug#8239).
7719
3eaff834
JM
77202011-05-28 Jim Meyering <meyering@redhat.com>
7721
e1900994 7722 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7723 * fns.c (to_uchar): Define.
7724 (crypto_hash_function): Use it to convert some newly-signed
7725 variables to unsigned, to avoid sign-extension bugs. For example,
7726 without this change, (md5 "truc") would evaluate to
7727 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7728 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7729 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7730
0f6990a7
PE
77312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7732
7733 Integer overflow fixes.
c8a9ca5a 7734
08686060
PE
7735 * dbusbind.c: Serial number integer overflow fixes.
7736 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7737 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7738 to hold a serial number that is too large for a fixnum.
7739 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7740 Check for serial numbers out of range. Decode any serial number
59568bf0 7741 that was so large that it became a float. (Bug#8722)
08686060 7742
2d1fc3c7
PE
7743 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7744 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7745 Use XFASTINT rather than XUINT when numbers are nonnegative.
7746 (xd_append_arg, Fdbus_method_return_internal):
7747 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7748 arguments, check that Lisp number is nonnegative, rather than
59568bf0 7749 silently wrapping negative numbers around. (Bug#8722)
30217ff0 7750 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 7751 (Bug#8722)
2d1fc3c7 7752
c8a9ca5a
PE
7753 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7754
519e1d69
PE
7755 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7756
6df6ae42 7757 ccl: Add integer overflow checks.
30569699
PE
7758 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7759 (IN_INT_RANGE): New macros.
7760 (ccl_driver): Use them to check for integer overflow when
7761 decoding a CCL program. Many of the new checks are whether XINT (x)
7762 fits in int; it doesn't always, on 64-bit hosts. The new version
7763 doesn't catch all possible integer overflows, but it's an
847044ea 7764 improvement. (Bug#8719)
30569699 7765
c11285dc
PE
7766 * alloc.c (make_event_array): Use XINT, not XUINT.
7767 There's no need for unsigned here.
7768
fdccd48e
PE
7769 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7770 This follows up to the 2011-05-06 change that substituted uintptr_t
7771 for EMACS_INT. This case wasn't caught back then.
7772
37910ab2
PE
7773 Rework Fformat to avoid integer overflow issues.
7774 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7775 now (part of C89). Include <verify.h>.
7776 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7777 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7778 (Fformat): Avoid the prepass trying to compute sizes; it was only
7779 approximate and thus did not catch overflow reliably. Instead, walk
7780 through the format just once, formatting and computing sizes as we go,
7781 checking for integer overflow at every step, and allocating a larger
7782 buffer as needed. Keep track separately whether the format is
7783 multibyte. Keep only the most-recently calculated precision, rather
7784 than them all. Record whether each argument has been converted to
7785 string. Use EMACS_INT, not int, for byte and char and arg counts.
7786 Support field widths and precisions larger than INT_MAX. Avoid
7787 sprintf's undefined behavior with conversion specifications such as %#d
7788 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7789 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7790 formatting out-of-range floating point numbers with int
9173deec 7791 formats. (Bug#8668)
37910ab2 7792
2e6578fb
PE
7793 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7794
0ae6bdee
PE
7795 * data.c: Avoid integer truncation in expressions involving floats.
7796 * data.c: Include <intprops.h>.
7797 (arith_driver): When there's an integer overflow in an expression
7798 involving floating point, convert the integers to floating point
7799 so that the resulting value does not suffer from catastrophic
7800 integer truncation. For example, on a 64-bit host (* 4
7801 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7802 Do not rely on undefined behavior after integer overflow.
7803
de883a70
PE
7804 merge count_size_as_multibyte, parse_str_to_multibyte
7805 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 7806 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
7807 Check for integer overflow.
7808 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7809 since it's now a duplicate of the other. This is more of
7810 a character than a buffer op, so better that it's in character.c.
7811 * fns.c, print.c: Adjust to above changes.
7812
2ff916cb
PE
78132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7814
7815 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7816
f1b54466
PE
78172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7818
fb1ac845
PE
7819 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7820 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7821 (x_clipboard_manager_save): Now static.
7822 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7823
f1b54466
PE
7824 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7825 (crypto_hash_function): Now static.
7826 Fix pointer signedness problems. Avoid unnecessary initializations.
7827
a9f737ee
CY
78282011-05-27 Chong Yidong <cyd@stupidchicken.com>
7829
7830 * termhooks.h (Vselection_alist): Make it terminal-local.
7831
7832 * terminal.c (create_terminal): Initialize it.
7833
7834 * xselect.c: Support for clipboard managers.
7835 (Vselection_alist): Move to termhooks.h as terminal-local var.
7836 (LOCAL_SELECTION): New macro.
7837 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7838 (symbol_to_x_atom): Remove gratuitous arg.
7839 (x_handle_selection_request, lisp_data_to_selection_data)
7840 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7841 (x_own_selection, x_get_local_selection, x_convert_selection):
7842 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7843 (some_frame_on_display): Delete unused function.
7844 (Fx_own_selection_internal, Fx_get_selection_internal)
7845 (Fx_disown_selection_internal, Fx_selection_owner_p)
7846 (Fx_selection_exists_p): New optional frame arg.
7847 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7848 (x_handle_selection_clear): Don't treat other terminals with the
7849 same keyboard specially. Use the terminal-local Vselection_alist.
7850 (x_clear_frame_selections): Use Frun_hook_with_args.
7851
7852 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7853
7854 * xterm.h: Add support for those atoms.
7855
e067f0c1
CY
78562011-05-26 Chong Yidong <cyd@stupidchicken.com>
7857
7858 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7859 (converted_selections, conversion_fail_tag): New global variables.
7860 (x_selection_request_lisp_error): Free the above.
7861 (x_get_local_selection): Remove unnecessary code.
7862 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7863 of converted selections stored in converted_selections.
7864 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7865 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7866 (x_convert_selection): New function.
7867 (x_handle_selection_event): Simplify.
7868 (x_get_foreign_selection): Don't ignore incoming requests while
7869 waiting for an answer; this will fail when we implement
7870 SAVE_TARGETS, and seems unnecessary anyway.
7871 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7872 (Vx_sent_selection_functions): Doc fix.
7873
0f4aebc0
LL
78742011-05-26 Leo Liu <sdl.web@gmail.com>
7875
7876 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7877
e61124cd
YM
78782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7879
7880 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7881
7882 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7883 for fringe update if it has periodic bitmap.
ac389d0c 7884 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7885 and fringe_bitmap_periodic_p.
7886
7887 * fringe.c (get_fringe_bitmap_data): New function.
7888 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7889 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7890 row. Mark glyph row for fringe update if periodicity changed.
7891
7892 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7893 for fringe update unless it has periodic bitmap.
7894
f16d9837
KH
78952011-05-25 Kenichi Handa <handa@m17n.org>
7896
7897 * xdisp.c (get_next_display_element): Set correct it->face_id for
7898 a static composition.
7899
e1b90ef6
LL
79002011-05-24 Leo Liu <sdl.web@gmail.com>
7901
7902 * deps.mk (fns.o):
7903 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7904
7905 * fns.c (crypto_hash_function, Fsha1): New function.
7906 (Fmd5): Use crypto_hash_function.
7907 (syms_of_fns): Add Ssha1.
7908
7400048f
PE
79092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7910
7911 * gnutls.c: Remove unused macros.
7912 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7913 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7914 Remove macros that are defined and never used.
7915 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7916
abb71cf4
CY
79172011-05-22 Chong Yidong <cyd@stupidchicken.com>
7918
7919 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7920 (Fx_get_selection_internal): Minor cleanup.
7921 (Fx_own_selection_internal): Rename arguments for consistency with
7922 select.el.
7923
6307db39
PE
79242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7925
7926 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7927
f3d4e0a4
CY
79282011-05-22 Chong Yidong <cyd@stupidchicken.com>
7929
7930 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7931
4d8ade89
YM
79322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7933
7934 * dispnew.c (scrolling_window): Don't exclude the case that the
7935 last enabled row in the desired matrix touches the bottom boundary.
7936
32078c8d
GM
79372011-05-21 Glenn Morris <rgm@gnu.org>
7938
7939 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7940 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7941 and add some more files.
32078c8d 7942
7285dc67
EZ
79432011-05-20 Eli Zaretskii <eliz@gnu.org>
7944
7945 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7946 report_file_error introduced by the change from 2011-05-07.
7947
89d1bd22
PE
79482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7949
7950 * systime.h (Time): Define only if emacs is defined.
7951 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7952 where the include path doesn't have X11/X.h by default. See
7953 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7954
cd394be1 79552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7956
7957 * composite.c (find_automatic_composition): Fix previous change.
7958
b9704ad9
GM
79592011-05-20 Glenn Morris <rgm@gnu.org>
7960
7961 * lisp.mk: New file, split from Makefile.in.
7962 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7963 (shortlisp): Remove.
7964 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7965
4a720484
GM
79662011-05-19 Glenn Morris <rgm@gnu.org>
7967
7968 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7969 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7970 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7971 (lisp): Set the order to that of loadup.el.
7972 (shortlisp): Make it a copy of $lisp.
7973 (SOME_MACHINE_LISP): Remove.
7974 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7975 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7976
a28d4396
KH
79772011-05-18 Kenichi Handa <handa@m17n.org>
7978
7979 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7980 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7981 (find_automatic_composition): Mostly rewrite for efficiency.
7982
a2b1fa8e
JB
79832011-05-18 Juanma Barranquero <lekktu@gmail.com>
7984
7985 * makefile.w32-in: Update dependencies.
7986
8e1f5610
CS
79872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7988
7989 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7990 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7991
7025ee00 79922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7993
cdfa6eab
PE
7994 Fix some integer overflow issues, such as string length overflow.
7995
06d6db33
PE
7996 * insdel.c (count_size_as_multibyte): Check for string overflow.
7997
2b4560a8
PE
7998 * character.c (lisp_string_width): Check for string overflow.
7999 Use EMACS_INT, not int, for string indexes and lengths; in
8000 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8001 the resulting string length overflows an EMACS_INT; instead,
8002 report a string overflow if no precision given. When checking for
8003 precision exhaustion, use a check that cannot possibly have
8004 integer overflow. (Bug#8675)
8005 * character.h (lisp_string_width): Adjust to new signature.
8006
cb93f9be
PE
8007 * alloc.c (string_overflow): New function.
8008 (Fmake_string): Use it. This doesn't change behavior, but saves
8009 a few bytes and will simplify future changes.
8010 * character.c (string_escape_byte8): Likewise.
8011 * lisp.h (string_overflow): New decl.
8012
1a1f3366
PE
8013 Fixups, following up to the user-interface timestamp change.
8014 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8015 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8016 * msdos.c (mouse_get_pos): Likewise.
8017 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8018 * w32gui.h (Time): Define by including "systime.h" rather than by
8019 declaring it ourselves. (Bug#8664)
8020
d4e3e4d3
PE
8021 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8022 * image.c (clear_image_cache): Likewise.
8023
f6a24d19
PE
8024 * term.c (term_mouse_position): Don't assume time_t wraparound.
8025
08dc5ae6
PE
8026 Be more systematic about user-interface timestamps.
8027 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8028 and sometimes 'EMACS_UINT', to represent these timestamps.
8029 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8030 This makes the code easier to follow, and makes it easier to catch
8031 integer overflow bugs such as Bug#8664.
8032 * frame.c (Fmouse_position, Fmouse_pixel_position):
8033 Use Time, not unsigned long, for user-interface timestamps.
8034 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8035 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8036 * keyboard.h (last_event_timestamp): Likewise.
8037 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8038 * menu.h (xmenu_show): Likewise.
8039 * term.c (term_mouse_position): Likewise.
8040 * termhooks.h (struct input_event.timestamp): Likewise.
8041 (struct terminal.mouse_position_hook): Likewise.
8042 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8043 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8044 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8045 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8046 what it was before.
8047 * menu.h, termhooks.h: Include "systime.h", for Time.
8048
8e55734a
PE
8049 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8050 Don't assume that the difference between two unsigned long values
8051 can fit into an integer. At this point, we know button_down_time
8052 <= event->timestamp, so the difference must be nonnegative, so
8053 there's no need to cast the result if double-click-time is
8054 nonnegative, as it should be; check that it's nonnegative, just in
8055 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8056 apart (about 25 days). (Bug#8664)
8e55734a 8057
841f1b75 8058 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8059 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8060
3e26f69c
PE
8061 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8062 that always fit in int. Use a sentinel instead of a counter, to
8063 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8064 * frame.h (struct frame): Use int for menu_bar_items_used
8065 instead of EMACS_INT, since it always fits in int.
3e26f69c 8066
5cc152c0
PE
8067 * menu.c (grow_menu_items): Check for int overflow.
8068
d89eb65e
PE
8069 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8070
5235bd3e
PE
8071 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8072 Before, the code was not consistent. These values cannot exceed
8073 2**31 - 1 so there's no need to make them unsigned.
8074 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8075 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8076 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8077 as modifiers.
8078 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8079
bc827e23
PE
8080 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8081 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8082 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8083 presumably because the widths might not match.
8084
78eb494e
PE
8085 * window.c (size_window): Avoid needless test at loop start.
8086
04f2d78b
CB
80872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8088
8089 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8090
d2fc7e3d 80912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8092
8093 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8094
d2fc7e3d 80952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8096
8097 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8098 `width' to `bar_area_x' and `bar_area_width', respectively.
8099 (x_scroll_run): Take account of fringe background extension.
8100
04f2d78b
CB
8101 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8102 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8103 `bar_area_width', respectively.
8104 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8105 background extension.
8106
79b70037
GM
81072011-05-10 Jim Meyering <meyering@redhat.com>
8108
8109 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8110
2f142cc5
JB
81112011-05-10 Juanma Barranquero <lekktu@gmail.com>
8112
8113 * image.c (Finit_image_library): Return t for built-in image types,
8114 like pbm and xbm. (Bug#8640)
8115
57679c86
AS
81162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8117
8118 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8119
888c9e86
EZ
81202011-05-07 Eli Zaretskii <eliz@gnu.org>
8121
b0512a1d
EZ
8122 * w32console.c (Fset_screen_color): Doc fix.
8123 (Fget_screen_color): New function.
8124 (syms_of_ntterm): Defsubr it.
8125
7285dc67
EZ
8126 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8127 unlink the temporary file if Fcall_process didn't create it in the
8128 first place.
8129 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8130 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8131 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8132 cue to call_process_cleanup not to close that handle.
8133
4d3fcc8e
BK
81342011-05-07 Ben Key <bkey76@gmail.com>
8135
8136 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8137 one of two shell specific rules, either bootstrap-temacs-CMD or
8138 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8139 to the previous implementation of the bootstrap-temacs rule.
8140 The bootstrap-temacs-CMD rule is similar to the previous
8141 implementation of the bootstrap-temacs rule except that it
8142 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8143 variable.
8144
8145 These changes, along with some changes to nt/configure.bat,
8146 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8147 earlier fix to add support for --cflags and --ldflags options
8148 that include quotes so that it works whether make uses cmd or
8149 sh as the shell.
8150
b4289b64
MA
81512011-05-06 Michael Albinus <michael.albinus@gmx.de>
8152
8153 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8154 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8155 is a constant.
8156 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8157 a string. Handle both cases.
8158 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8159 (Fdbus_register_method): Use Qinvalid_function.
8160
af4c0e28
JB
81612011-05-06 Juanma Barranquero <lekktu@gmail.com>
8162
8163 * makefile.w32-in: Update dependencies.
8164 (LISP_H): Add inttypes.h and stdin.h.
8165 (PROCESS_H): Add unistd.h.
8166
c51453d9
EZ
81672011-05-06 Eli Zaretskii <eliz@gnu.org>
8168
8169 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8170 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8171
8ff0ac3c 81722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8173
4c4b566b
PE
8174 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8175
aab2b9b5
PE
8176 * term.c (vfatal): Remove stray call to va_end.
8177 It's not needed and the C Standard doesn't allow it here anyway.
8178
c378da0b
PE
8179 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8180 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8181
288b08c7
PE
8182 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8183 bytes.
8184
e3601888
PE
8185 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8186
db6c0e74
PE
8187 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8188
dd5963ea
PE
8189 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8190
88c9450f
PE
8191 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8192
2f9442b8
PE
8193 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8194
c032b5f8
PE
8195 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8196 * charset.c (Fdefine_charset_internal): Don't initialize
8197 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8198 32-bit int (Bug#8600).
a108c10b
PE
8199
8200 * lread.c (read_integer): Be more consistent with string-to-number.
8201 Use string_to_number to do the actual conversion; this avoids
8202 rounding errors and fixes some other screwups. Without this fix,
8203 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8204 (digit_to_number): Move earlier, for benefit of read_integer.
8205 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8206 not a digit in any supported base. (Bug#8602)
a108c10b 8207
ad5f9eea
PE
8208 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8209
aec1708a
PE
8210 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8211 to match comment at start of function. This also removes a
8212 GCC warning about overflow in a 32+64-bit port.
8213
47be4ab5
PE
8214 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8215
371cac43
PE
8216 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8217 Reported by Stefan Monnier in
8218 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8219 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8220 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8221
d01a7826
PE
8222 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8223 (EMACS_UINTPTR): Likewise, with uintptr_t.
8224
7fd47d5c
PE
8225 * lisp.h: Prefer 64-bit EMACS_INT if available.
8226 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8227 on 32-bit hosts that have 64-bit int, so that they can access
8228 large files.
122b0c86
PE
8229 However, temporarily disable this change unless the temporary
8230 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8231
8727937b
PE
8232 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8233
8ac068ac
PE
8234 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8235 This removes an assumption that EMACS_INT and long are the same
8236 width as pointers. The assumption is true for Emacs porting targets
8237 now, but we want to make other targets possible.
8238 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8239 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8240 In the rest of the code, change types of integers that hold casted
8241 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8242 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8243 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8244 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8245 No need to cast type when ORing.
8246 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8247 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8248 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8249 assume EMACS_INT is the same width as char *.
8250 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8251 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8252 Remove no-longer-needed casts.
8253 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8254 (xg_tool_bar_help_callback, xg_make_tool_item):
8255 Use EMACS_INTPTR to hold an integer
8256 that will be cast to void *; this can avoid a GCC warning
8257 if EMACS_INT is not the same width as void *.
8258 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8259 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8260 (current_message_1, set_message_1):
8261 Use a local to convert to proper width without a cast.
8262 * xmenu.c (dialog_selection_callback): Likewise.
8263
ede49d71
PE
8264 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8265 Also, don't assume VALBITS / RAND_BITS is less than 5,
8266 and don't rely on undefined behavior when shifting a 1 left into
8267 the sign bit.
8268 * lisp.h (get_random): Change signature to match.
8269
2f30ecd0
PE
8270 * lread.c (hash_string): Use size_t, not int, for hash computation.
8271 Normally we prefer signed values; but hashing is special, because
8272 it's better to use unsigned division on hash table sizes so that
8273 the remainder is nonnegative. Also, size_t is the natural width
8274 for hashing into memory. The previous code used 'int', which doesn't
8275 retain enough info to hash well into very large tables.
8276 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8277
2a866e7b
PE
8278 * dbusbind.c: Don't possibly lose pointer info when converting.
8279 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8280 Use XPNTR rather than XHASH, so that the high-order bits of
8281 the pointer aren't lost when converting through void *.
8282
51639eac
PE
8283 * eval.c (Fautoload): Don't double-shift a pointer.
8284
92394119
PE
8285 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8286
dbdb9a7c
JB
82872011-05-06 Juanma Barranquero <lekktu@gmail.com>
8288
8289 * gnutls.c (DEF_GNUTLS_FN):
8290 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8291
db7a0b4f
AS
82922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8293
8294 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8295 marker. (Bug#8610)
8296
cd394be1 82972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8298
8299 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8300 New version that can reserve upto 2GB of heap space.
8301
f7ff1b0f 83022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8303
8304 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8305
639c109b
TZ
83062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8307
8308 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8309 `gnutls_certificate_set_x509_key_file'.
8310
d2127135
JB
83112011-05-05 Juanma Barranquero <lekktu@gmail.com>
8312
8313 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8314 Update dependencies.
8315
e968f4f3
JB
83162011-05-04 Juanma Barranquero <lekktu@gmail.com>
8317
8318 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8319 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8320 Remove unused parameter `fildes'.
8321 * process.c (read_process_output, send_process): Don't pass it.
8322
84d358f0
JB
83232011-05-04 Juanma Barranquero <lekktu@gmail.com>
8324
8325 Fix previous change: the library cache is defined in w32.c.
8326 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8327 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8328
0898ca10
JB
83292011-05-04 Juanma Barranquero <lekktu@gmail.com>
8330
8331 Implement dynamic loading of GnuTLS on Windows.
8332
8333 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8334 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8335 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8336 Declare.
8337
8338 * gnutls.c (Qgnutls_dll): Define.
8339 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8340 (gnutls_*): Declare function pointers.
8341 (init_gnutls_functions): New function to initialize function pointers.
8342 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8343 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8344 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8345 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8346 (emacs_gnutls_write, emacs_gnutls_read)
8347 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8348 (Fgnutls_available_p): New function.
8349 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8350 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8351 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8352
8353 * image.c: Include w32.h.
8354 (Vimage_type_cache): Delete.
8355 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8356 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8357 (w32_delayed_load): Move to w32.c.
8358
8359 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8360
8361 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8362 (w32_delayed_load): Move from image.c. When loading a library, record
8363 its filename in the :loaded-from property of the library id.
8364 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8365 Initialize and staticpro them.
8366 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8367
8368 * process.c: Include lisp.h before w32.h, not after.
8369 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8370 instead of gnutls_record_check_pending.
8371
8372 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8373
ff4de4aa
TZ
83742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8375
8376 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8377 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8378 as passed in.
8379
abe95abb
JD
83802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8381
8382 * xterm.c (x_set_frame_alpha): Do not set property on anything
8383 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8384
e16e55d4
JB
83852011-05-02 Juanma Barranquero <lekktu@gmail.com>
8386
8387 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8388
bafcf6a5
JB
83892011-05-02 Juanma Barranquero <lekktu@gmail.com>
8390
8391 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8392 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8393 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8394 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8395 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8396 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8397 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8398 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8399 (Qgnutls_bootprop_callbacks_verify): Make static.
8400
e7a6747f
AS
84012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8402
19ed11ba
AS
8403 * callproc.c: Indentation fixup.
8404
e7a6747f 8405 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8406 (wait_for_termination, interruptible_wait_for_termination):
8407 Move after wait_for_termination_1.
e7a6747f 8408
1ef14cb4
LMI
84092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8410
8411 * sysdep.c (interruptible_wait_for_termination): New function
8412 which is like wait_for_termination, but allows keyboard
8413 interruptions.
8414
8415 * callproc.c (Fcall_process): Add (:file "file") as an option for
8416 the STDOUT buffer.
8417 (Fcall_process_region): Ditto.
8418
330d880c
EZ
84192011-04-30 Eli Zaretskii <eliz@gnu.org>
8420
8db90b73
EZ
8421 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8422 rather than `XVECTOR (FOO)->size'.
8423
330d880c
EZ
8424 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8425 inttypes.h, as a gnulib replacement is used if it not available in
8426 system headers.
8427
15cbd324
EZ
84282011-04-21 Eli Zaretskii <eliz@gnu.org>
8429
8430 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8431 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8432 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8433
8434 * coding.c (coding_alloc_by_realloc): Error out if destination
8435 will grow beyond MOST_POSITIVE_FIXNUM.
8436 (decode_coding_emacs_mule): Abort if there isn't enough place in
8437 charbuf for the composition carryover bytes. Reserve an extra
8438 space for up to 2 characters produced in a loop.
8439 (decode_coding_iso_2022): Abort if there isn't enough place in
8440 charbuf for the composition carryover bytes.
8441
84422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8443
ae940cca
EZ
8444 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8445 aborting when %lld or %lll format is passed.
8446 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8447 %llo or %llx format is passed. (Bug#8545)
8448
03ab8921
EZ
8449 * window.c (window_scroll_line_based): Use a marker instead of
8450 simple variables to record original value of point. (Bug#7952)
8451
afda1437
EZ
8452 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8453 produced by %s or %c overflows available buffer space. (Bug#8545)
8454
f76dee0c
PE
84552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8456
8457 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8458 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8459
fdc5744d
JB
84602011-04-28 Juanma Barranquero <lekktu@gmail.com>
8461
8462 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8463
638f053a
JB
84642011-04-28 Juanma Barranquero <lekktu@gmail.com>
8465
8466 * keyboard.c (Qdelayed_warnings_hook): Define.
8467 (command_loop_1): Run `delayed-warnings-hook'
8468 if Vdelayed_warnings_list is non-nil.
8469 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8470 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8471
d178f871
EZ
84722011-04-28 Eli Zaretskii <eliz@gnu.org>
8473
8474 * doprnt.c (doprnt): Don't return value smaller than the buffer
8475 size if the message was truncated. (Bug#8545).
8476
b124fd93
JB
84772011-04-28 Juanma Barranquero <lekktu@gmail.com>
8478
8479 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8480 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8481
e810457d
PE
84822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8483
8484 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8485
ea51cceb
JB
84862011-04-27 Juanma Barranquero <lekktu@gmail.com>
8487
8488 * makefile.w32-in: Update dependencies.
8489
94dcfacf
EZ
84902011-04-27 Eli Zaretskii <eliz@gnu.org>
8491
8492 Improve `doprnt' and its usage. (Bug#8545)
8493 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8494 `format_end'. Remove support for %l as a conversion specifier.
8495 Don't use xrealloc. Improve diagnostics when the %l size modifier
8496 is used. Update the commentary.
8497
8498 * eval.c (verror): Simplify calculation of size_t.
8499
8500 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8501 messages.
8502
f61f41d7
PE
85032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8504
8505 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8506 change.
8507
96fb4434
PE
85082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8509
8510 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8511 This makes this file independent of the recent pseudovector change.
8512
671875da 85132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8514
69e9b5a3
PE
8515 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8516
b5f869a7 8517 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8518 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8519 Remove unused local.
c8926152 8520 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8521
841a1577 8522 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8523 GCC 4.6.0 optimizes based on type-based alias analysis.
8524 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8525 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8526 != &v->size, and therefore "v->size = 1; b->size = 2; return
8527 v->size;" must therefore return 1. This assumption is incorrect
8528 for Emacs, since it type-puns struct Lisp_Vector * with many other
8529 types. To fix this problem, this patch adds a new type struct
f904488f 8530 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8531 and pseudovectors, and helps optimizing compilers not get fooled
8532 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8533 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8534 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8535 the size member.
eab3844f
PE
8536 (XSETPVECTYPE): Rewrite in terms of new macro.
8537 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8538 This is a bit clearer, and further avoids the possibility of
8539 undesirable aliasing.
8540 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8541 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8542 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8543 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8544 (ASIZE): Now uses header.size rather than size.
8545 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8546 to avoid the hassle of writing XVECTOR (foo)->header.size.
8547 (struct vectorlike_header): New type.
eab3844f
PE
8548 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8549 object, to help avoid aliasing.
8550 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8551 (SUBRP): Likewise, since Lisp_Subr is a special case.
8552 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8553 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8554 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8555 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8556 changed to be "header.size" and "header.next".
8557 * buffer.h (struct buffer): Likewise.
8558 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8559 * frame.h (struct frame): Likewise.
8560 * process.h (struct Lisp_Process): Likewise.
8561 * termhooks.h (struct terminal): Likewise.
8562 * window.c (struct save_window_data, struct saved_window): Likewise.
8563 * window.h (struct window): Likewise.
8564 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8565 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8566 * buffer.c (init_buffer_once): Likewise.
8567 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8568 special case.
8569 * process.c (Fformat_network_address): Use local var for size,
8570 for brevity.
8571
0df1eac5
PE
8572 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8573
847ab9d1 8574 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8575 * data.c (atof): Remove decl; no longer used or needed.
8576 (digit_to_number): Move to lread.c.
8577 (Fstring_to_number): Use new string_to_number function, to be
8578 consistent with how the Lisp reader treats infinities and NaNs.
8579 Do not assume that floating-point numbers represent EMACS_INT
8580 without losing information; this is not true on most 64-bit hosts.
8581 Avoid double-rounding errors, by insisting on integers when
8582 parsing non-base-10 numbers, as the documentation specifies.
8583 * lisp.h (string_to_number): New decl, replacing ...
8584 (isfloat_string): Remove.
bc0a5c13 8585 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8586 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8587 appears to have been a coding error. Similarly, do not accept
8588 strings like +-1e0 as floating point numbers. Do not report
8589 overflow for integer overflows unless the base is not 10 which
8590 means we have no simple and reliable way to continue.
8591 Break out the floating-point parsing into a new
8592 function string_to_number, so that Fstring_to_number parses
8593 floating point numbers consistently with the Lisp reader.
04f2d78b 8594 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8595 (E_CHAR, EXP_INT): Remove, replacing with ...
8596 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8597 (string_to_number): New function, replacing isfloat_string.
8598 This function checks for valid syntax and produces the resulting
8599 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8600 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8601 so that overflow for non-base-10 numbers is reported only when
8602 there's no portable and simple way to convert to floating point.
452f4150 8603
67769ffc
PE
8604 * textprop.c (set_text_properties_1): Rewrite for clarity,
8605 and to avoid GCC warning about integer overflow.
8606
c20db43f
PE
8607 * intervals.h (struct interval): Use EMACS_INT for members
8608 where EMACS_UINT might cause problems. See
8609 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8610 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8611 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8612 All uses changed.
37aa2f85
PE
8613 (offset_intervals): Tell GCC not to worry about length overflow
8614 when negating a negative length.
c20db43f 8615
2538aa2f
PE
8616 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8617 (overrun_check_free): Likewise.
8618
f2d3008d
PE
8619 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8620 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8621 word size.
8622
ec8df744
PE
8623 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8624 (gnutls_make_error): Rename local to avoid shadowing.
8625 (gnutls_emacs_global_deinit): ifdef out; not used.
8626 (Fgnutls_boot): Use const for pointer to readonly storage.
8627 Comment out unused local. Fix pointer signedness problems.
8628
640ee02d
PE
8629 * lread.c (openp): Don't stuff size_t into an 'int'.
8630 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8631 about possible signed overflow.
8632
6048fb2a
PE
8633 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8634 (GDK_KEY_g): Don't define if already defined.
8635 (xg_prepare_tooltip): Avoid pointer signedness problem.
8636 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8637
fa3c87e1
PE
8638 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8639 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8640
2172544b
PE
8641 * xfns.c (Fx_window_property): Simplify a bit,
8642 to make a bit faster and to avoid GCC 4.6.0 warning.
8643 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8644
9b821a21
PE
8645 * fns.c (internal_equal): Don't assume size_t fits in int.
8646
3c616cfa
PE
8647 * alloc.c (compact_small_strings): Tighten assertion a little.
8648
c2982e87
PE
8649 Replace pEd with more-general pI, and fix some printf arg casts.
8650 * lisp.h (pI): New macro, generalizing old pEd macro to other
8651 conversion specifiers. For example, use "...%"pI"d..." rather
8652 than "...%"pEd"...".
8653 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8654 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8655 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8656 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8657 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8658 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8659 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8660 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8661 64-bit hosts.
8662 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8663 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8664 * print.c (safe_debug_print, print_object): Likewise.
8665 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8666 to int.
6f04d126
PE
8667 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8668 avoiding the 0 flag, which is not portable.
c2982e87
PE
8669 * process.c (Fmake_network_process): Use pI to avoid cast.
8670 * region-cache.c (pp_cache): Likewise.
8671 * xdisp.c (decode_mode_spec): Likewise.
8672 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8673 behavior on 64-bit hosts with printf arg.
6f04d126 8674 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8675 (x_stop_queuing_selection_requests): Likewise.
8676 (x_get_window_property): Don't truncate byte count to an 'int'
8677 when tracing.
0b432f21 8678
5e073ec7
PE
8679 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8680 here, since it parses constructs like leading '-' and spaces,
8681 which are not wanted; and it overflows with large numbers.
8682 Instead, simply match F[0-9]+, which is what is wanted anyway.
8683
36372bf9
PE
8684 * alloc.c: Remove unportable assumptions about struct layout.
8685 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8686 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8687 (allocate_vectorlike, make_pure_vector): Use the new macros,
8688 plus offsetof, to remove unportable assumptions about struct layout.
8689 These assumptions hold on all porting targets that I know of, but
8690 they are not guaranteed, they're easy to remove, and removing them
8691 makes further changes easier.
8692
0b432f21
PE
8693 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8694 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8695 (string_overrun_cookie): Now const. Use initializers that
8696 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8697 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8698 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8699 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8700 multiple of sizeof (EMACS_INT); it need not be, if
8701 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8702 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8703
895009e1
JB
87042011-04-26 Juanma Barranquero <lekktu@gmail.com>
8705
8706 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8707
6a7a1b0b
TZ
87082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8709
8710 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8711 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8712 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8713
841a1577 87142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8715
8716 * lisp.h (Qdebug): List symbol.
895009e1 8717 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8718 * keyboard.c (debug-on-event): New variable.
8719 (handle_user_signal): Break into debugger when debug-on-event
8720 matches the current signal symbol.
8721
f2d3ba6f
DN
87222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8723
8724 * alloc.c (check_sblock, check_string_bytes)
8725 (check_string_free_list): Convert to standard C.
8726
42ce4c63
TZ
87272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8728
8729 * w32.c (emacs_gnutls_push): Fix typo.
8730
825cd63c
EZ
87312011-04-25 Eli Zaretskii <eliz@gnu.org>
8732
fb11d64d
EZ
8733 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8734 "cast to pointer from integer of different size".
8735
825cd63c
EZ
8736 Improve doprnt and its use in verror. (Bug#8545)
8737 * doprnt.c (doprnt): Document the set of format control sequences
8738 supported by the function. Use SAFE_ALLOCA instead of always
8739 using `alloca'.
8740
8741 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8742 is one byte too soon. Don't use xrealloc; instead xfree and
8743 xmalloc anew.
8744
e061a11b
TZ
87452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8746
8747 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8748 callbacks stage.
8749
8750 * gnutls.c: Renamed global_initialized to
8751 gnutls_global_initialized. Added internals for the
8752 :verify-hostname-error, :verify-error, and :verify-flags
8753 parameters of `gnutls-boot' and documented those parameters in the
8754 docstring. Start callback support.
9173deec
JB
8755 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8756 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8757 on error. Return error code.
e061a11b
TZ
8758 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8759 (emacs_gnutls_read): Likewise.
8760 (Fgnutls_boot): Return handshake error code.
8761 (emacs_gnutls_handle_error): New function.
8762 (wsaerror_to_errno): Likewise.
8763
8764 * w32.h (emacs_gnutls_pull): Add prototype.
8765 (emacs_gnutls_push): Likewise.
8766
8767 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8768 (emacs_gnutls_push): Likewise.
8769
87702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8771
8772 * process.c (wait_reading_process_output): Check if GnuTLS
8773 buffered some data internally if no FDs are set for TLS
8774 connections.
8775
8776 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8777 (LIBS): Link to USER_LIBS.
8778 ($(BLD)/gnutls.$(0)): New target.
8779
fa6996bc
EZ
87802011-04-24 Eli Zaretskii <eliz@gnu.org>
8781
eb35682e
EZ
8782 * xdisp.c (handle_single_display_spec): Rename the
8783 display_replaced_before_p argument into display_replaced_p, to
8784 make it consistent with the commentary. Fix typos in the
8785 commentary.
8786
e2ad650c
EZ
8787 * textprop.c (syms_of_textprop): Remove dead code.
8788 (copy_text_properties): Delete obsolete commentary about an
8789 interface that was deleted long ago. Fix typos in the description
8790 of arguments.
8791
1b2de274
EZ
8792 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8793 to changes in oldXMenu/XMenu.h from 2011-04-16.
8794 <menu_help_message, prev_menu_help_message>: Constify.
8795 (IT_menu_make_room): menu->help_text is now `const char **';
8796 adjust.
8797
8798 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8799 to changes in oldXMenu/XMenu.h from 2011-04-16.
8800 (struct XMenu): Declare `help_text' `const char **'.
8801
8802 * xfaces.c <Qunspecified>: Make extern again.
8803
8804 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 8805 required by POSIX.
1b2de274 8806
762b15be
EZ
8807 * doc.c (get_doc_string): Improve the format passed to `error'.
8808
8809 * doprnt.c (doprnt): Improve commentary.
8810
8811 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8812
8813 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8814 them with etags.
8815
f1052e5d
EZ
8816 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8817 changes in globals.h immediately force recompilation.
762b15be
EZ
8818 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8819 $(CURDIR)/s/ms-w32.h.
8820 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 8821
fa6996bc
EZ
8822 * character.c (Fchar_direction): Function deleted.
8823 (syms_of_character): Don't defsubr it.
8824 <char-direction-table>: Deleted.
8825
e6c3da20
EZ
88262011-04-23 Eli Zaretskii <eliz@gnu.org>
8827
8828 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8829 * doprnt.c: Include limits.h.
8830 (SIZE_MAX): New macro.
04f2d78b
CB
8831 (doprnt): Return a size_t value. 2nd arg is now size_t.
8832 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8833 Improve overflow protection. Support `l' modifier for integer
8834 conversions. Support %l conversion. Don't assume an EMACS_INT
8835 argument for integer conversions and for %c.
8836
8837 * lisp.h (doprnt): Restore prototype.
8838
8839 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8840 $(SRC)/character.h.
8841
8842 * Makefile.in (base_obj): Add back doprnt.o.
8843
8844 * deps.mk (doprnt.o): Add back prerequisites.
8845 (callint.o): Depend on character.h.
8846
8847 * eval.c (internal_lisp_condition_case): Include the handler
8848 representation in the error message.
8849 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8850 when breaking from the loop.
8851
8852 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8853
8854 * callint.c (Fcall_interactively): When displaying error message
8855 about invalid control letter, pass the character's codepoint, not
8856 a pointer to its multibyte form. Improve display of the character
8857 in octal and display also its hex code.
8858
8859 * character.c (char_string): Use %x to display the (unsigned)
8860 codepoint of an invalid character, to avoid displaying a bogus
8861 negative value.
8862
8863 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8864 `error', not SYMBOL_NAME itself.
8865
8866 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8867 character arguments to `error'.
8868
8869 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8870 to `error' in error message about FINAL_CHAR argument. Make sure
8871 FINAL_CHAR is a character, and use %c when it is passed as
8872 argument to `error'.
8873
4ffd0d6b 88742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8875
8876 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8877
8878 * w32.c: Include <time.h>.
8879 (sys_localtime): New function.
8880
4ffd0d6b 88812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8882
8883 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8884
4ffd0d6b 8885 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8886
4ffd0d6b 88872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8888
4ffd0d6b
GM
8889 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8890 zombies (Bug#8467).
aac0c6e3 8891
04c56954
EZ
88922011-04-19 Eli Zaretskii <eliz@gnu.org>
8893
8894 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8895 gl_state.e_property when gl_state.object is Qt.
8896
8897 * insdel.c (make_gap_larger): Remove limitation of buffer size
8898 to <= INT_MAX.
8899
16a43933
CY
89002011-04-18 Chong Yidong <cyd@stupidchicken.com>
8901
8902 * xdisp.c (lookup_glyphless_char_display)
8903 (produce_glyphless_glyph): Handle cons cell entry in
8904 glyphless-char-display.
8905 (Vglyphless_char_display): Document it.
8906
8907 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8908 glyphless-char-display.
8909
4581706e
CY
89102011-04-17 Chong Yidong <cyd@stupidchicken.com>
8911
8912 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8913
8914 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8915
8916 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8917 definition for no-X builds.
8918
4887c6e2 89192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8920
fd35b6f9
PE
8921 Static checks with GCC 4.6.0 and non-default toolkits.
8922
5c1ccb01
PE
8923 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8924
006c5daa
PE
8925 * process.c (keyboard_bit_set): Define only if SIGIO.
8926 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8927 (send_process): Repair possible setjmp clobbering.
8928
efc736d3
PE
8929 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8930
4e2fe2e6
PE
8931 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8932
f97334a2
PE
8933 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8934
4e75f29d
PE
8935 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8936 Define only if needed.
8937
90efadd1
PE
8938 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8939 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8940 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8941
3c647824
PE
8942 * dispextern.h (struct redisplay_interface): Rename param
8943 to avoid shadowing.
e264f262 8944 * termhooks.h (struct terminal): Likewise.
761383f4 8945 * xterm.c (xembed_send_message): Likewise.
3c647824 8946
b58c5c4a
PE
8947 * insdel.c (make_gap_smaller): Define only if
8948 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8949
cad59032
PE
8950 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8951 it.
8952
c339dc2e
PE
8953 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8954 so that we aren't warned about unused symbols.
8955
91a3e27b
PE
8956 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8957
399c71d3 8958 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8959
8ffc96f5
PE
8960 * xfns.c (x_real_positions): Mark locals as initialized.
8961
eef9bc79
PE
8962 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8963
098db9dd
PE
8964 * xterm.c: Fix problems found by static analysis with other toolkits.
8965 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8966 (x_dispatch_event): Declare static if USE_GTK, and
8967 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8968 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8969 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8970 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8971 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8972
eb18f6cc
PE
8973 * xmenu.c (menu_help_callback): Pointer type fixes.
8974 Use const pointers when pointing at readonly data. Avoid pointer
8975 signedness clashes.
8976 (FALSE): Remove unused macro.
8977 (update_frame_menubar): Remove unused decl.
8978
1fe72bf8
PE
8979 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8980
60d9e1db
PE
8981 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8982 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8983 (single_menu_item): Rename local to avoid shadowing.
8984
39261c26
PE
8985 * keyboard.c (make_lispy_event): Remove unused local var.
8986
018c5e19
PE
8987 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8988 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8989
63d2b86e
PE
8990 * bitmaps: Change bitmaps from unsigned char back to the X11
8991 compatible char. Avoid the old compiler warnings about
8992 out-of-range initializers by using, for example, '\xab' rather
8993 than 0xab.
8994
aefd87e1
PE
8995 * xgselect.c (xgselect_initialize): Check vs interface
8996 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8997
bf501fb9
PE
8998 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8999
e9829fdf
PE
9000 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9001 to read-only memory.
9002
1086c095
PE
9003 * fns.c (vector): Remove; this old hack is no longer needed.
9004
2baccd04 9005 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9006 Remove unused var.
dde42981 9007 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9008
72391843 9009 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9010
436c16df 9011 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9012 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9013 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9014
92bb796d 9015 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9016 (x_term_init): Remove local to avoid shadowing.
92bb796d 9017
764430a3 9018 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9019
9020 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9021 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9022
d1dfb56c
EZ
90232011-04-16 Eli Zaretskii <eliz@gnu.org>
9024
c4354cb4
EZ
9025 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9026
d1dfb56c
EZ
9027 Fix regex.c, syntax.c and friends for buffers > 2GB.
9028 * syntax.h (struct gl_state_s): Declare character position members
9029 EMACS_INT.
9030
9031 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9032
04f2d78b
CB
9033 * textprop.c (verify_interval_modification, interval_of):
9034 Declare arguments EMACS_INT.
d1dfb56c
EZ
9035
9036 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9037 EMACS_INT.
9038
9039 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9040
9041 * indent.c (Fvertical_motion): Local variable it_start is now
9042 EMACS_INT.
9043
9044 * regex.c (re_match, re_match_2, re_match_2_internal)
9045 (bcmp_translate, regcomp, regexec, print_double_string)
9046 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9047 (re_compile_pattern, re_exec): Declare arguments and local
9048 variables `size_t' and `ssize_t' and return values `regoff_t', as
9049 appropriate.
9050 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9051 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9052 <compile_stack_type>: `size' and `avail' are now `size_t'.
9053
9054 * regex.h <regoff_t>: Use ssize_t, not int.
9055 (re_search, re_search_2, re_match, re_match_2): Arguments that
9056 specify buffer/string position and length are now ssize_t and
9057 size_t. Return type is regoff_t.
9058
613052cd
BK
90592011-04-16 Ben Key <bkey76@gmail.com>
9060
9061 * nsfont.m: Fixed bugs in ns_get_family and
9062 ns_descriptor_to_entity that were caused by using free to
9063 deallocate memory blocks that were allocated by xmalloc (via
9064 xstrdup). This caused Emacs to crash when compiled with
9065 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9066 --enable-checking=xmallocoverrun). xfree is now used to
9067 deallocate these memory blocks.
9068
4170f62f 90692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9070
71b41406
PE
9071 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9072
9587a89d
PE
9073 emacs_write: Accept and return EMACS_INT for sizes.
9074 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9075 et seq.
9076 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9077 Accept and return EMACS_INT.
9078 (emacs_gnutls_write): Return the number of bytes written on
9079 partial writes.
9080 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9081 (emacs_read, emacs_write): Remove check for negative size, as the
9082 Emacs source code has been audited now.
9587a89d
PE
9083 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9084 (emacs_read, emacs_write): Use it.
273a5f82
PE
9085 * process.c (send_process): Adjust to the new signatures of
9086 emacs_write and emacs_gnutls_write. Do not attempt to store
9087 a byte offset into an 'int'; it might overflow.
9587a89d 9088 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9089
3e047f51
PE
9090 * sound.c: Don't assume sizes fit in 'int'.
9091 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9092 Return EMACS_INT, not int.
3e047f51 9093 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9094 Accept EMACS_INT, not int.
9095 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9096 record read return values.
9097
cc39a9db
BK
90982011-04-15 Ben Key <bkey76@gmail.com>
9099
c9d0ec6d
JB
9100 * keyboard.c (Qundefined): Don't declare static since it is used
9101 in nsfns.m.
9102 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9103 static since they are used in nsfont.m.
cc39a9db 9104
6c60eb9f
SM
91052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9106
9107 * process.c (Qprocessp): Don't declare static.
9108 * lisp.h (Qprocessp): Declare again.
9109
7990b61a
JB
91102011-04-15 Juanma Barranquero <lekktu@gmail.com>
9111
9112 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9113
5d4cb038
PE
91142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9115
8bd7b830 9116 Improve C-level modularity by making more things 'static'.
cd64ea1d 9117
e3b27b31
PE
9118 Don't publish debugger-only interfaces to other modules.
9119 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9120 (verify_bytepos, count_markers): Move decls to the only modules
9121 that need them.
9122 * region-cache.h (pp_cache): Likewise.
9123 * window.h (check_all_windows): Likewise.
9124 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9125
5d4cb038
PE
9126 * sysdep.c (croak): Now static, if
9127 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9128 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9129
9130 * alloc.c (refill_memory_reserve): Now static if
9131 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9132 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9133
e87b6180
PE
9134 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9135 Define only if USE_LUCID.
9136
ac64929e
PE
9137 * xrdb.c (x_customization_string, x_rm_string): Now static.
9138
6f37259d
PE
9139 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9140 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9141
1683e3ab
PE
9142 * xdisp.c (draw_row_with_mouse_face): Now static.
9143 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9144
de9c2632
PE
9145 * window.h (check_all_windows): Mark externally visible.
9146
2b96acb7
PE
9147 * window.c (window_deletion_count): Now static.
9148
9149 * undo.c: Make symbols static if they're not exported.
9150 (last_undo_buffer, last_boundary_position, pending_boundary):
9151 Now static.
9152
50436f33
PE
9153 * textprop.c (interval_insert_behind_hooks): Now static.
9154 (interval_insert_in_front_hooks): Likewise.
9155
64520e5c
PE
9156 * term.c: Make symbols static if they're not exported.
9157 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9158 (max_frame_lines, tty_set_terminal_modes):
9159 (tty_reset_terminal_modes, tty_turn_off_highlight):
9160 (get_tty_terminal): Now static.
9161 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9162 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9163 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9164 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9165 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9166
1fa53021
PE
9167 * sysdep.c: Make symbols static if they're not exported.
9168 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9169 Now static.
9170 (sigprocmask_set, full_mask): Remove; unused.
9171 (wait_debugging): Mark as visible.
9172 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9173 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9174
d4b43b22
PE
9175 * syntax.c (syntax_temp): Define only if !__GNUC__.
9176
b7c513d0
PE
9177 * sound.c (current_sound_device, current_sound): Now static.
9178
989b29ad
PE
9179 * search.c (searchbufs, searchbuf_head): Now static.
9180
13a55a78
PE
9181 * scroll.c (scroll_cost): Remove; unused.
9182 * dispextern.h (scroll_cost): Remove decl.
9183
de68a1fc
PE
9184 * region-cache.h (pp_cache): Mark as externally visible.
9185
40ccffa6
PE
9186 * process.c: Make symbols static if they're not exported.
9187 (process_tick, update_tick, create_process, chan_process):
9188 (Vprocess_alist, proc_buffered_char, datagram_access):
9189 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9190 (deactivate_process): Mark defn as static, as well as decl.
9191 * lisp.h (create_process): Remove decl.
9192 * process.h (chan_process, Vprocess_alist): Remove decls.
9193
ad64fc97
PE
9194 * print.c: Make symbols static if they're not exported.
9195 (print_depth, new_backquote_output, being_printed, print_buffer):
9196 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9197 (print_interval, print_number_index, initial_stderr_stream):
9198 Now static.
9199 * lisp.h (Fprinc): Remove decl.
9200 (debug_output_compilation_hack): Mark as externally visible.
9201
adddb265
PE
9202 * sysdep.c (croak): Move decl from here to syssignal.h.
9203 * syssignal.h (croak): Put it here, so the API can be checked when
9204 'croak' is called from dissociate_if_controlling_tty.
9205
1717ede2
PE
9206 * minibuf.c: Make symbols static if they're not exported.
9207 (minibuf_save_list, choose_minibuf_frame): Now static.
9208 * lisp.h (choose_minibuf_frame): Remove decl.
9209
fa5fb2bc
PE
9210 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9211
1e3890d1
PE
9212 * lread.c: Make symbols static if they're not exported.
9213 (read_objects, initial_obarray, oblookup_last_bucket_number):
9214 Now static.
9215 (make_symbol): Remove; unused.
9216 * lisp.h (initial_obarray, make_symbol): Remove decls.
9217
8a1414fa
PE
9218 * keyboard.c: Make symbols static if they're not exported.
9219 (single_kboard, recent_keys_index, total_keys, recent_keys):
9220 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9221 (this_single_command_key_start, echoing, last_auto_save):
9222 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9223 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9224 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9225 (Vlispy_mouse_stem, double_click_count):
9226 Now static.
9227 (force_auto_save_soon): Define only if SIGDANGER.
9228 (ignore_mouse_drag_p): Now static if
9229 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9230 (print_help): Remove; unused.
9231 (stop_character, last_timer_event): Mark as externally visible.
9232 * keyboard.h (ignore_mouse_drag_p): Declare only if
9233 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9234 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9235 * lisp.h (echoing): Remove decl.
9236 (force_auto_save_soon): Declare only if SIGDANGER.
9237 * xdisp.c (redisplay_window): Simplify code, to make it more
9238 obvious that ignore_mouse_drag_p is not accessed if !defined
9239 USE_GTK && !defined HAVE_NS.
9240
93ea6e8f
PE
9241 * intervals.c: Make symbols static if they're not exported.
9242 (merge_properties_sticky, merge_interval_right, delete_interval):
9243 Now static.
9244 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9245
77382fcc
PE
9246 * insdel.c: Make symbols static if they're not exported.
9247 However, leave prepare_to_modify_buffer alone. It's never
9248 called from outside this function, but that appears to be a bug.
9249 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9250 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9251 (adjust_after_replace_noundo): Remove; unused.
9252 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9253 (signal_before_change): Remove decls.
77382fcc 9254
9306c32e
PE
9255 * indent.c (val_compute_motion, val_vmotion): Now static.
9256
cd44d2eb
PE
9257 * image.c: Make symbols static if they're not exported.
9258 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9259 if USE_GTK.
9260 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9261 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9262
ad9a7a06
PE
9263 * fringe.c (standard_bitmaps): Now static.
9264 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9265
81626931
PE
9266 * frame.c: Make symbols static if they're not exported.
9267 (x_report_frame_params, make_terminal_frame): Now static.
9268 (get_frame_param): Now static, unless HAVE_NS.
9269 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9270 (x_get_resource_string): Remove; not used.
9271 * frame.h (make_terminal_frame, x_report_frame_params):
9272 (x_get_resource_string); Remove decls.
9273 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9274 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9275
239f9db9
PE
9276 * font.c, fontset.c: Make symbols static if they're not exported.
9277 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9278 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9279 * font.c (font_close_object): Now static.
9280 * font.h (font_close_object): Remove.
9281 * fontset.c (FONTSET_OBJLIST): Remove.
9282 (free_realized_fontset) #if-0 the body, which does nothing.
9283 (face_suitable_for_char_p): #if-0, as it's never called.
9284 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9285 * xfaces.c (face_at_string_position):
9286 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9287 since 0 is always ASCII.
9288
dfcf3579
PE
9289 * fns.c (weak_hash_tables): Now static.
9290
5045092b
PE
9291 * fileio.c: Make symbols static if they're not exported.
9292 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9293 (Vwrite_region_annotation_buffers): Now static.
9294
57a96f5c
PE
9295 * eval.c: Make symbols static if they're not exported.
9296 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9297 * lisp.h (backtrace_list): Remove decl.
9298
35f08c38
PE
9299 * emacs.c: Make symbols static if they're not exported.
9300 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9301 (fatal_error_code, fatal_error_signal_hook, standard_args):
9302 Now static.
9303 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9304 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9305 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9306 * lisp.h (fatal_error_signal_hook): Remove decl.
9307 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9308
f44bd759
PE
9309 * editfns.c: Move a (normally-unused) function to its only use.
9310 * editfns.c, lisp.h (get_operating_system_release): Remove.
9311 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9312 worth the hassle of breaking this out.
9313
b532497d
PE
9314 * xterm.c: Make symbols static if they're not exported.
9315 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9316 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9317 (x_destroy_window, x_delete_display):
9318 Now static.
9319 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9320 (x_mouse_leave): Remove; unused.
9321 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9322 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9323 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9324 Remove decls.
9325 (x_mouse_leave): Declare only if WINDOWSNT.
9326 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9327 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9328 USE_X_TOOLKIT.
9329
1675728f
PE
9330 * ftxfont.c: Make symbols static if they're not exported.
9331 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9332 HAVE_FREETYPE.
9333 * font.h (ftxfont_driver): Likewise.
9334
e4cebfca
PE
9335 * xfns.c: Make symbols static if they're not exported.
9336 (x_last_font_name, x_display_info_for_name):
9337 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9338 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9339 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9340 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9341 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9342 (last_show_tip_args): Now static.
9343 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9344 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9345 (x_screen_planes): Remove; unused.
9346 * dispextern.h (x_screen_planes): Remove decl.
9347
5bf46f05
PE
9348 * dispnew.c: Make symbols static if they're not exported.
9349 * dispextern.h (redraw_garbaged_frames, scrolling):
9350 (increment_row_positions): Remove.
9351 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9352 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9353 Now static.
9354 (redraw_garbaged_frames): Remove; unused.
9355
435f4c28
PE
9356 * xfaces.c: Make symbols static if they're not exported.
9357 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9358 Remove decls.
9359 * xterm.h (defined_color): Remove decls.
9360 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9361 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9362 (menu_face_changed_default, defined_color, free_realized_face):
9363 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9364 (ascii_face_of_lisp_face): Remove; unused.
9365
8524aef3
PE
9366 * xdisp.c: Make symbols static if they're not exported.
9367 * dispextern.h (scratch_glyph_row, window_box_edges):
9368 (glyph_to_pixel_coords, set_cursor_from_row):
9369 (get_next_display_element, set_iterator_to_next):
9370 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9371 (show_mouse_face): Remove decls
9372 * frame.h (message_buf_print): Likewise.
9373 * lisp.h (pop_message, set_message, check_point_in_composition):
9374 Likewise.
9375 * xterm.h (set_vertical_scroll_bar): Likewise.
9376 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9377 (message_buf_print, scratch_glyph_row, displayed_buffer):
9378 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9379 (get_next_display_element, show_mouse_face, window_box_edges):
9380 (frame_to_window_pixel_xy, check_point_in_composition):
9381 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9382 (glyph_to_pixel_coords): Remove; unused.
9383
16390cd2
PE
9384 * dired.c (file_name_completion): Now static.
9385
9386 * dbusbind.c (xd_in_read_queued_messages): Now static.
9387
a25f4dfa
PE
9388 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9389 * data.c (circular_list_error): Remove.
9390
14a9c8df
PE
9391 * commands.h (last_point_position, last_point_position_buffer):
9392 (last_point_position_window): Remove decls.
9393 * keyboard.c: Make these variables static.
9394
04f2d78b
CB
9395 * coding.h (coding, code_convert_region, encode_coding_gap):
9396 Remove decls.
74ab6df5
PE
9397 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9398 (iso_code_class, detect_coding, code_convert_region): Now static.
9399 (encode_coding_gap): Remove; unused.
9400
38dfbee1
PE
9401 * chartab.c (chartab_chars, chartab_bits): Now static.
9402
a2cb4e63
PE
9403 * charset.h (charset_iso_8859_1): Remove decl.
9404 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9405 Now static.
9406
127198fd
PE
9407 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9408 * ccl.c (Vccl_program_table): Now static.
9409 (check_ccl_update): Remove; unused.
9410
d85b608f
PE
9411 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9412 * category.h: ... from here.
9413 * category.c (check_category_table, set_category_set): Now static.
9414
31cd66f3
PE
9415 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9416 * lisp.h: Remove these decls.
9417
c358e587
PE
9418 * buffer.c (buffer_count): Remove unused var.
9419
e78aecca
PE
9420 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9421 so that it's not optimized away.
9422 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9423 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9424 exported only to the debugger.
9425
e192d7d3 9426 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9427 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9428
92470028
PE
9429 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9430 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9431 was inaccessible from Lisp.
9432 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9433 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9434
244ed907
PE
9435 alloc.c: Import and export fewer symbols, and remove unused items.
9436 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9437 is defined.
9438 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9439 it's not optimized away by whole-program optimization.
9440 (message_enable_multibyte, free_misc): Remove.
9441 (catchlist, handlerlist, mark_backtrace):
9442 Declare only if BYTE_MARK_STACK.
9443 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9444 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9445 (message_enable_multibyte): Remove decl.
9446 (free_misc, interval_free_list, float_block, float_block_index):
9447 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9448 (cons_free_list, last_marked_index):
9449 Now static.
9450 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9451 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9452 (mark_backtrace): Define only if BYTE_MARK_STACK.
9453 * xdisp.c (message_enable_multibyte): Now static.
9454
61c2b50e 9455 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9456 This makes it easier for human readers (and static analyzers)
9457 to see whether these variables are used from other modules.
9458 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9459 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9460 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9461 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9462 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9463 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9464 * xmenu.c, xselect.c:
9465 Declare Q* vars static if they are not used in other modules.
9466 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9467 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9468 Remove decls of unexported vars.
9469 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9470
95c82688
PE
9471 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9472
16a97296
PE
9473 Make Emacs functions such as Fatom 'static' by default.
9474 This makes it easier for human readers (and static analyzers)
9475 to see whether these functions can be called from other modules.
9476 DEFUN now defines a static function. To make the function external
9477 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9478 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9479 (Finit_image_library):
16a97296
PE
9480 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9481 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9482 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9483 Remove decls, since these functions are now static.
9484 (Funintern, Fget_internal_run_time): New decls, since these functions
9485 were already external.
95c82688 9486
16a97296
PE
9487 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9488 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9489 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9490 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9491 * keyboard.c, keymap.c, lread.c:
9492 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9493 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9494 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9495 Mark functions with DEFUE instead of DEFUN,
9496 if they are used in other modules.
9497 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9498 decls for now-static functions.
9499 * buffer.h (Fdelete_overlay): Remove decl.
9500 * callproc.c (Fgetenv_internal): Mark as internal.
9501 * composite.c (Fremove_list_of_text_properties): Remove decl.
9502 (Fcomposition_get_gstring): New forward static decl.
9503 * composite.h (Fcomposite_get_gstring): Remove decl.
9504 * dired.c (Ffile_attributes): New forward static decl.
9505 * doc.c (Fdocumntation_property): New forward static decl.
9506 * eval.c (Ffetch_bytecode): New forward static decl.
9507 (Funintern): Remove extern decl; now in .h file where it belongs.
9508 * fileio.c (Fmake_symbolic_link): New forward static decl.
9509 * image.c (Finit_image_library): New forward static decl.
9510 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9511 * intervals.h (Fprevious_property_change):
9512 (Fremove_list_of_text_properties): Remove decls.
9513 * keyboard.c (Fthis_command_keys): Remove decl.
9514 (Fcommand_execute): New forward static decl.
9515 * keymap.c (Flookup_key): New forward static decl.
9516 (Fcopy_keymap): Now static.
9517 * keymap.h (Flookup_key): Remove decl.
9518 * process.c (Fget_process): New forward static decl.
9519 (Fprocess_datagram_address): Mark as internal.
9520 * syntax.c (Fsyntax_table_p): New forward static decl.
9521 (skip_chars): Remove duplicate decl.
9522 * textprop.c (Fprevious_property_change): New forward static decl.
9523 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9524 Now internal.
9525 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9526 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9527
785bbd42
PE
9528 * editfns.c (Fformat): Remove unreachable code.
9529
8b913b57
AS
95302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9531
9532 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9533 change. (Bug#8496)
9534
a6744a35
EZ
95352011-04-13 Eli Zaretskii <eliz@gnu.org>
9536
9537 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9538 when at ZV. (Bug#8487)
9539
e7974947
AS
95402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9541
baad03f0
AS
9542 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9543 (Bug#8437)
9544 * keyboard.c (parse_tool_bar_item): Likewise.
9545 * sound.c (sound_cleanup, alsa_close): Likewise.
9546 * termcap.c (tgetent): Likewise.
9547 * xfns.c (x_default_font_parameter): Likewise.
9548 * xsettings.c (read_and_apply_settings): Likewise.
9549
e7974947
AS
9550 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9551 (overrun_check_free): Protoize.
9552
28272684
PE
95532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9554
9555 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9556 since callers should never pass a negative size.
9557 Change the signature to match that of plain 'read' and 'write'; see
9558 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9559 * lisp.h: Update prototypes of emacs_write and emacs_read.
9560
11997c76
EZ
95612011-04-11 Eli Zaretskii <eliz@gnu.org>
9562
9563 * xdisp.c (redisplay_window): Don't try to determine the character
9564 position of the scroll margin if the window start point w->startp
e896f03c 9565 is outside the buffer's accessible region. (Bug#8468)
11997c76 9566
8a2cbd72
EZ
95672011-04-10 Eli Zaretskii <eliz@gnu.org>
9568
9569 Fix write-region and its subroutines for buffers > 2GB.
9570 * fileio.c (a_write, e_write): Modify declaration of arguments and
9571 local variables to support buffers larger than 2GB.
9572 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9573
9574 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9575 argument, local variables, and return value.
9576
9577 * lisp.h: Update prototypes of emacs_write and emacs_read.
9578
9579 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9580
4073e537 95812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9582
1ebfdcb6
PE
9583 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9584
b2ded58d
PE
9585 Fix more problems found by GCC 4.6.0's static checks.
9586
7d66342c
PE
9587 * xdisp.c (vmessage): Use a better test for character truncation.
9588
bbf47d44
PE
9589 * charset.c (load_charset_map): <, not <=, for optimization,
9590 and to avoid potential problems with integer overflow.
9248994d 9591 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9592 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9593 * editfns.c (Fformat): Likewise.
1e69125e 9594 * syntax.c (skip_chars): Likewise.
3befa583 9595
e3019616
PE
9596 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9597 This also lets GCC 4.6.0 generate slightly better loop code.
9598
becfa255
PE
9599 * callint.c (Fcall_interactively): <, not <=, for optimization.
9600 (Fcall_interactively): Count the number of arguments produced,
9601 not the number of arguments given. This is simpler and lets GCC
9602 4.6.0 generate slightly better code.
9603
dae0cd48
PE
9604 * ftfont.c: Distingish more carefully between FcChar8 and char.
9605 The previous code passed unsigned char * to a functions like
9606 strlen and xstrcasecmp that expect char *, which does not
9607 conform to the C standard.
9608 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9609 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9610 char * when the C standard requires it.
9611
76032d70
PE
9612 * keyboard.c (read_char): Remove unused var.
9613
eb3f1cc8
PE
9614 * eval.c: Port to Windows vsnprintf (Bug#8435).
9615 Include <limits.h>.
9616 (SIZE_MAX): Define if the headers do not.
9617 (verror): Do not give up if vsnprintf returns a negative count.
9618 Instead, grow the buffer. This ports to Windows vsnprintf, which
9619 does not conform to C99. Problem reported by Eli Zaretskii.
9620 Also, simplify the allocation scheme, by avoiding the need for
9621 calling realloc, and removing the ALLOCATED variable.
9622
70476b54
PE
9623 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9624
12020a9e
PE
9625 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9626 But keep the doprint source code for now, as we might revamp it
9627 and use it again (Bug#8435).
ea6c7ae6
PE
9628 * lisp.h (doprnt): Remove.
9629 * Makefile.in (base_obj): Remove doprnt.o.
9630 * deps.mk (doprnt.o): Remove.
9631
5fdb398c
PE
9632 error: Print 32- and 64-bit integers portably (Bug#8435).
9633 Without this change, on typical 64-bit hosts error ("...%d...", N)
9634 was used to print both 32- and 64-bit integers N, which relied on
9635 undefined behavior.
61bdb816 9636 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9637 * lisp.h (error, verror): Mark as printf-like functions.
9638 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9639 Report overflow in size calculations when allocating printf buffer.
9640 Do not truncate output string at its first null byte.
9641 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9642 Truncate the output at a character boundary, since vsnprintf does not
9643 do that.
9644 * charset.c (check_iso_charset_parameter): Convert internal
9645 character to string before calling 'error', since %c now has the
9646 printf meaning.
9647 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9648 overflow when computing char to be passed to 'error'. Do not
9649 pass Lisp_Object to 'error'; pass the integer instead.
9650 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9651 formatted with plain %d.
9652
b189fa66
PE
9653 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9654
bff87ef0
PE
9655 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9656
7e2cac20
PE
9657 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9658
ce4d90b5
PE
9659 * xterm.c (x_catch_errors): Remove duplicate declaration.
9660
266c9547
PE
9661 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9662
79c49ad2
PE
9663 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9664
368f4090
JM
96652011-04-10 Jim Meyering <meyering@redhat.com>
9666
9667 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9668 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9669 return ssize_t not "int", and use size_t as the buffer length.
9670 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9671 * gnutls.h: Update declarations.
9672 * process.c (read_process_output): Use ssize_t, to match.
9673 (send_process): Likewise.
9674
a32d4040
CY
96752011-04-09 Chong Yidong <cyd@stupidchicken.com>
9676
9677 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9678
8546720e 96792011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9680
04f2d78b
CB
9681 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9682 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9683
8546720e
GM
9684 * xterm.c (handle_one_xevent):
9685 * xmenu.c (create_and_show_popup_menu):
9686 * xselect.c (x_decline_selection_request)
9687 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9688
0a2f5c1a 96892011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9690
9691 Fix some uses of `int' instead of EMACS_INT.
9692 * search.c (string_match_1, fast_string_match)
9693 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9694 (scan_buffer, find_next_newline_no_quit)
9695 (find_before_next_newline, search_command, Freplace_match)
9696 (Fmatch_data): Make some `int' variables be EMACS_INT.
9697
9698 * xdisp.c (display_count_lines): 3rd argument and return value now
9699 EMACS_INT. All callers changed.
9700 (pint2hrstr): Last argument is now EMACS_INT.
9701
9702 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9703 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9704 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9705 (decode_coding_utf_16, decode_coding_emacs_mule)
9706 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9707 (decode_coding_ccl, decode_coding_charset)
9708 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9709 (decode_coding_iso_2022, decode_coding_emacs_mule)
9710 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9711 <char_offset, last_offset>: Declare EMACS_INT.
9712 (encode_coding_utf_8, encode_coding_utf_16)
9713 (encode_coding_emacs_mule, encode_invocation_designation)
9714 (encode_designation_at_bol, encode_coding_iso_2022)
9715 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9716 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9717 Declare EMACS_INT.
9718 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9719 (encode_invocation_designation): Last argument P_NCHARS is now
9720 EMACS_INT.
9721 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9722 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9723
9724 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9725 All users changed.
9726
9727 * ccl.c (Fccl_execute_on_string): Declare some variables
9728 EMACS_INT.
9729
8546720e 97302011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9731
9732 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9733
4e19a977
CS
97342011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9735
9736 * process.c (Fformat_network_address): Doc fix.
9737
87302331
R
97382011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9739
ee7683eb 9740 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9741
cbb59342
CY
97422011-04-08 Chong Yidong <cyd@stupidchicken.com>
9743
9744 * keyboard.c (read_char): Call Lisp function help-form-show,
9745 instead of using internal_with_output_to_temp_buffer.
9746 (Qhelp_form_show): New var.
e0d38eeb 9747 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9748
9749 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9750
9751 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9752
e67a13ab
CY
97532011-04-06 Chong Yidong <cyd@stupidchicken.com>
9754
04f2d78b
CB
9755 * process.c (Flist_processes): Remove to Lisp.
9756 (list_processes_1): Delete.
e67a13ab 9757
973f782d
EZ
97582011-04-06 Eli Zaretskii <eliz@gnu.org>
9759
7c106b1e
EZ
9760 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9761
973f782d
EZ
9762 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9763
41cf7d1a 97642011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 9765
ca23cc88
PE
9766 Fix more problems found by GCC 4.6.0's static checks.
9767
f390e2d5
PE
9768 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9769
42eea0d0
PE
9770 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9771
b69769da 9772 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 9773
f9541e84
PE
9774 * xdisp.c (vmessage): Mark as a printf-like function.
9775
13841b55
PE
9776 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9777
c136c10f
PE
9778 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9779
5e2d4a30
PE
9780 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9781 printf-like functions.
9782 (tiff_load): Add casts to remove these marks before passing them
9783 to system-supplied API.
9784
583f48b9
PE
9785 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9786
b25d760e
PE
9787 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9788 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
9789 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9790 directly, rather than having caller test rule sign. This avoids
9791 some unnecessary tests.
9792 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9793 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9794 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 9795
bc7b6697 9796 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 9797 (xfont_open): Avoid unnecessary tests.
bc7b6697 9798
27ccc379
PE
9799 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9800
dcd5c89a
PE
9801 * composite.h, composite.c (composition_gstring_put_cache):
9802 Use EMACS_INT, not int, for length.
9803
b13a45c6
PE
9804 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9805 breaking out part of COMPOSITION_DECODE_RULE.
9806 (COMPOSITION_DECODE_RULE): Use it.
9807 * composite.c (get_composition_id): Remove unused local vars,
9808 by using the new macro.
9809
1e792e4d
PE
9810 * textprop.c (set_text_properties_1): Change while to do-while,
9811 since the condition is always true at first.
9812
dc6c6455 9813 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
9814 (interval_deletion_adjustment): Return unsigned value.
9815 All uses changed.
dc6c6455 9816
aba7731a
PE
9817 * process.c (list_processes_1, create_pty, read_process_output):
9818 (exec_sentinel): Remove vars that were set but not used.
afd4052b 9819 (create_pty): Remove unnecessary "volatile"s.
bc57d757 9820 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 9821 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9822 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9823
fdfc4bf3
PE
9824 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9825
fca8fe46 9826 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9827 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9828
06a0259a 9829 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9830 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9831 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9832
e7b9e80f
PE
9833 * print.c (print_error_message): Avoid int overflow.
9834
56201685
PE
9835 * font.c (font_list_entities): Redo for clarity,
9836 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9837
78834453 9838 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9839 (font_score): Avoid potential overflow in diff calculation.
78834453 9840
0bc0b309 9841 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9842 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9843
e610eaca
PE
9844 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9845
b895abce
PE
9846 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9847 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9848 can always succeed if overflow has undefined behavior.
9849
1f1d9321 9850 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9851 (wordify): Omit three unnecessary tests.
1f1d9321 9852
c59478bc
PE
9853 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9854 All callers changed. This avoids the need for an unused var.
9855
79b73827
PE
9856 * casefiddle.c (casify_region): Remove var that is set but not used.
9857
a4db5dfe
PE
9858 * dired.c (file_name_completion): Remove var that is set but not used.
9859
43aae36e
PE
9860 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9861
2a47c44d 9862 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9863 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9864
a37c69bf
PE
9865 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9866 Check for integer overflow on size calculations.
9867
328ab8e7
PE
9868 * buffer.c (Fprevious_overlay_change): Remove var that is set
9869 but not used.
9870
e5a2a5cb
PE
9871 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9872 Remove vars that are set but not used.
8d84a6eb 9873 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9874 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9875
a60e5f68
PE
9876 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9877
f661cb61 9878 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9879 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9880
f0397f5a
PE
9881 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9882 that are set but not used.
9883
8664db06 9884 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9885 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9886
6abdaa4a
PE
9887 * xselect.c (x_get_local_selection, x_handle_property_notify):
9888 Remove vars that are set but not used.
9889
0ce7538d 9890 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9891 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9892
9ae848fc
PE
9893 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9894 Remove var that is set but not used.
0b918413
PE
9895 (scroll_bar_windows_size): Now size_t, not int.
9896 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9897 Check for overflow.
9ae848fc 9898
a5a62657
PE
9899 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9900 (map_tty_color) [!defined MSDOS]: Likewise.
9901
5c5cdd39
PE
9902 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9903
66ebf983
PE
9904 * coding.c: Remove vars that are set but not used.
9905 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9906 All callers changed.
9907 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9908 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9909 (decode_coding_charset): Remove vars that are set but not used.
9910
1be4d761
PE
9911 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9912 that is set but not used.
9913
47553fa8
PE
9914 * print.c (print_object): Remove var that is set but not used.
9915
1f7196bf 9916 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9917 The gnulib version avoids calling malloc in the usual case,
9918 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9919 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9920 * filelock.c (current_lock_owner): Likewise.
9921 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9922 * sysdep.c: Include allocator.h, careadlinkat.h.
9923 (emacs_no_realloc_allocator): New static constant.
9924 (emacs_readlink): New function.
fdb61804
PE
9925 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9926 ../lib/careadlinkat.h.
d1fdcab7 9927
f84c17c7
SM
99282011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9929
9930 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9931 first non-nil return value).
9932
ef3862ad
JD
99332011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9934
9935 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9936 if not defined (Bug#8403).
9937
376a7006
JB
99382011-04-02 Juanma Barranquero <lekktu@gmail.com>
9939
9940 * xdisp.c (display_count_lines): Remove parameter `start',
9941 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9942 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9943 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9944 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9945 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9946 and thereabouts. All callers changed.
9947 (get_per_char_metric): Remove parameter `f', unused since
9948 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9949
6ca3801d
JM
99502011-04-02 Jim Meyering <meyering@redhat.com>
9951
9952 do not dereference NULL upon failed strdup
9953 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9954 (ns_get_family): Likewise.
9955
d8e2b5ba
JB
99562011-04-02 Juanma Barranquero <lekktu@gmail.com>
9957
9958 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9959
8c74fcbd
JD
99602011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9961
9962 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9963 later (Bug#8403).
9964
7200d79c
SM
99652011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9966
03408648 9967 Add lexical binding.
7200d79c 9968
03408648
SM
9969 * window.c (Ftemp_output_buffer_show): New fun.
9970 (Fsave_window_excursion):
9971 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9972
9973 * lread.c (lisp_file_lexically_bound_p): New function.
9974 (Fload): Bind Qlexical_binding.
9975 (readevalloop): Remove `evalfun' arg.
9976 Bind Qinternal_interpreter_environment.
9977 (Feval_buffer): Bind Qlexical_binding.
9978 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9979 Mark as dynamic.
9980 (syms_of_lread): Declare `lexical-binding'.
9981
9982 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9983
9984 * keyboard.c (eval_dyn): New fun.
9985 (menu_item_eval_property): Use it.
ca105506
SM
9986
9987 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9988
03408648
SM
9989 * fns.c (concat, mapcar1): Accept byte-code-functions.
9990
9991 * eval.c (Fsetq): Handle lexical vars.
9992 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9993 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9994 (FletX, Flet): Obey lexical binding.
9995 (Fcommandp): Handle closures.
9996 (Feval): New `lexical' arg.
9997 (eval_sub): New function extracted from Feval. Use it almost
9998 everywhere where Feval was used. Look up vars in lexical env.
9999 Handle closures.
10000 (Ffunctionp): Move from subr.el.
10001 (Ffuncall): Handle closures.
10002 (apply_lambda): Remove `eval_flags'.
10003 (funcall_lambda): Handle closures and new byte-code-functions.
10004 (Fspecial_variable_p): New function.
10005 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10006 but without exporting it to Lisp.
23aba0ea 10007
23aba0ea 10008 * doc.c (Fdocumentation, store_function_docstring):
03408648 10009 * data.c (Finteractive_form): Handle closures.
23aba0ea 10010
03408648
SM
10011 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10012 interactive spec.
ba83908c 10013
04f2d78b
CB
10014 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10015 New byte-codes.
03408648
SM
10016 (exec_byte_code): New function extracted from Fbyte_code to handle new
10017 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10018
03408648 10019 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10020
03408648 10021 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10022
e2abce01
JB
100232011-03-31 Juanma Barranquero <lekktu@gmail.com>
10024
10025 * xdisp.c (redisplay_internal): Fix prototype.
10026
63696a73 100272011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10028
63696a73 10029 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10030 (try_scrolling): Use it when setting scroll_limit.
10031 Limit scrolling to 100 screen lines.
63696a73
EZ
10032 (redisplay_window): Even when falling back on "recentering",
10033 position point in the window according to scroll-conservatively,
10034 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10035
10036 (try_scrolling): When point is above the window, allow searching
10037 as far as scroll_max, or one screenful, to compute vertical
10038 distance from PT to the scroll margin position. This prevents
10039 try_scrolling from unnecessarily failing when
10040 scroll-conservatively is set to a value slightly larger than the
10041 window height. Clean up the case of PT below the margin at bottom
10042 of window: scroll_max can no longer be INT_MAX. When aggressive
10043 scrolling is in use, don't let point enter the opposite scroll
10044 margin as result of the scroll.
10045 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10046 threshold of 100 lines for never-recentering scrolling.
10047
e4cc2dfc
JB
100482011-03-31 Juanma Barranquero <lekktu@gmail.com>
10049
10050 * dispextern.h (move_it_by_lines):
10051 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10052 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10053 (message_log_check_duplicate): Remove parameters `prev_bol' and
10054 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10055 (redisplay_internal): Remove parameter `preserve_echo_area',
10056 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10057
10058 * indent.c (Fvertical_motion):
10059 * window.c (window_scroll_pixel_based, Frecenter):
10060 Don't pass `need_y_p' to `move_it_by_lines'.
10061
1c470562
SM
100622011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10063
44f230aa
SM
10064 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10065 steal a few bits to be more compact.
10066 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10067 Remove unneeded casts.
10068
1c470562
SM
10069 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10070
888adce9
ZK
100712011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10072
10073 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10074 binding" message (bug#7967).
10075
f838ed7b
PE
100762011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10077
77861b95
PE
10078 Fix more problems found by GCC 4.6.0's static checks.
10079
de6dbc14
PE
10080 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10081 Remove unused local var.
10082
f838ed7b
PE
10083 * editfns.c (Fmessage_box): Remove unused local var.
10084
792c7b2b
PE
10085 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10086 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10087 Omit unused local vars.
c499e557 10088 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10089 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10090 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10091 Omit unused local var.
10092
ba0165e1
PE
10093 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10094 Don't assume string length fits in int.
32ad8845 10095 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10096 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10097
3c59b4c9
PE
10098 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10099 instead of alloca (Bug#8344).
10100
a3eed478 10101 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10102 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10103
eb4d412d
PE
10104 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10105
1658b401
PE
10106 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10107 concerns.
10108
10109 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10110
10111 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10112
9a2c6e05
PE
10113 * keyboard.c (syms_of_keyboard): Use the same style as later
10114 in this function when indexing through an array. This also
10115 works around GCC bug 48267.
10116
03d0a109
PE
10117 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10118
44f730c8
PE
10119 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10120
fe75f926
PE
10121 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10122 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10123
ffa8c828
PE
10124 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10125 This avoids undefined behavior on integer overflow, and is a bit
10126 more convenient anyway since it is compared to a size_t variable.
10127
c5101a77
PE
10128 Variadic C functions now count arguments with size_t, not int.
10129 This avoids an unnecessary limitation on 64-bit machines, which
10130 caused (substring ...) to crash on large vectors (Bug#8344).
10131 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10132 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10133 All variadic functions and their callers changed accordingly.
c5101a77
PE
10134 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10135 * data.c (arith_driver, float_arith_driver): Likewise.
10136 * editfns.c (general_insert_function): Likewise.
10137 * eval.c (struct backtrace.nargs, interactive_p)
10138 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10139 (funcall_lambda, mark_backtrace): Likewise.
10140 * fns.c (concat): Likewise.
10141 * frame.c (x_set_frame_parameters): Likewise.
10142 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10143 0 if not found, not -1. All callers changed.
10144
dd3f25f7
PE
10145 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10146 (stack_copy_size): Now size_t, not int.
10147 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10148
461c2ab9
JB
101492011-03-28 Juanma Barranquero <lekktu@gmail.com>
10150
10151 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10152 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10153 All callers changed.
10154
10155 * lisp.h (multibyte_char_to_unibyte):
10156 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10157 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10158 * character.h (CHAR_TO_BYTE8):
10159 * cmds.c (internal_self_insert):
10160 * editfns.c (general_insert_function):
10161 * keymap.c (push_key_description):
10162 * search.c (Freplace_match):
10163 * xdisp.c (message_dolog, set_message_1): All callers changed.
10164
f6d62986
SM
101652011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10166
10167 * keyboard.c (safe_run_hook_funcall): New function.
10168 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10169 don't set the hook to nil, but remove the offending function instead.
10170 (Qcommand_hook_internal): Remove, unused.
10171 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10172 Vcommand_hook_internal.
10173
10174 * eval.c (enum run_hooks_condition): Remove.
10175 (funcall_nil, funcall_not): New functions.
10176 (run_hook_with_args): Call each function through a `funcall' argument.
10177 Remove `cond' argument, now redundant.
10178 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10179 (Frun_hook_with_args_until_failure): Adjust accordingly.
10180 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10181
1db5b1ad
JB
101822011-03-28 Juanma Barranquero <lekktu@gmail.com>
10183
10184 * dispextern.h (string_buffer_position): Remove declaration.
10185
10186 * print.c (strout): Remove parameter `multibyte', unused since
10187 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10188
10189 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10190 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10191 All callers changed.
10192
10193 * w32.c (_wsa_errlist): Use braces for struct initializers.
10194
10195 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10196 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10197 All callers changed.
10198 (string_buffer_position): Likewise. Also, make static (it's never
10199 used outside xdisp.c).
10200 (cursor_row_p): Remove parameter `w', unused since
10201 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10202 (decode_mode_spec): Remove parameter `precision', introduced during
10203 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10204 All callers changed.
10205
5ffb62aa
JD
102062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10207
10208 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10209
461c2ab9 102102011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10211
10212 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10213 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10214 (ns_update_auto_hide_menu_bar): New functions.
10215 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10216 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10217 ns_constrain_all_frames.
10218 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10219 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10220
5c380ffb
JD
102212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10222
10223 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10224
9af30bdf
GM
102252011-03-27 Glenn Morris <rgm@gnu.org>
10226
10227 * syssignal.h: Replace RETSIGTYPE with void.
10228 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10229 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10230 Replace SIGTYPE with void everywhere.
10231 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10232 * s/template.h (SIGTYPE): Remove commented out definition.
10233
e2abce01
JB
102342011-03-26 Eli Zaretskii <eliz@gnu.org>
10235
10236 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10237 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10238
f868cd8a
JB
102392011-03-26 Juanma Barranquero <lekktu@gmail.com>
10240
59eb0929
JB
10241 * w32.c (read_unc_volume): Use parameter `henum', instead of
10242 global variable `wget_enum_handle'.
10243
10244 * keymap.c (describe_vector): Remove parameters `indices' and
10245 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10246 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10247
f868cd8a
JB
10248 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10249
10250 * keyboard.c (timer_check): Remove parameter `do_it_now',
10251 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10252 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10253 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10254
10255 * keyboard.c (read_char):
10256 * w32menu.c (w32_menu_display_help):
10257 * xmenu.c (show_help_event, menu_help_callback):
10258 Adjust calls to `show_help_echo'.
10259
10260 * gtkutil.c (xg_maybe_add_timer):
10261 * keyboard.c (readable_events):
10262 * process.c (wait_reading_process_output):
10263 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10264
10265 * insdel.c (adjust_markers_gap_motion):
10266 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10267 (gap_left, gap_right): Don't call it.
10268
2ecf6fdb
CY
102692011-03-25 Chong Yidong <cyd@stupidchicken.com>
10270
10271 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10272 incurred during fontification.
10273
6b1f9ba4
JB
102742011-03-25 Juanma Barranquero <lekktu@gmail.com>
10275
10276 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10277 (DEFVAR_PER_BUFFER): Don't pass it.
10278
10279 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10280 (scrolling_window): Don't pass it.
10281
0f4a96b5
JB
102822011-03-25 Juanma Barranquero <lekktu@gmail.com>
10283
10284 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10285
10286 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10287 and `suffix'.
10288 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10289 of variables specific to SELinux and computation of `encoded_absname'.
10290
10291 * image.c (XPutPixel): Remove unused variable `height'.
10292
10293 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10294
10295 * unexw32.c (get_section_info): Remove unused variable `section'.
10296
10297 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10298 (system_process_attributes): Remove unused variable `sess'.
10299 (sys_read): Remove unused variable `err'.
10300
10301 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10302 (w32_wnd_proc): Remove unused variable `isdead'.
10303 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10304 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10305 (x_create_tip_frame): Remove unused variable `tem'.
10306
10307 * w32inevt.c (w32_console_read_socket):
10308 Remove unused variable `no_events'.
10309
10310 * w32term.c (x_draw_composite_glyph_string_foreground):
10311 Remove unused variable `width'.
10312
1149507c
JB
103132011-03-24 Juanma Barranquero <lekktu@gmail.com>
10314
10315 * w32term.c (x_set_glyph_string_clipping):
10316 Don't pass uninitialized region to CombineRgn.
10317
9c88f339
JB
103182011-03-23 Juanma Barranquero <lekktu@gmail.com>
10319
10320 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10321 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10322 (Fx_close_connection): Remove unused variable `i'.
10323
10324 * w32font.c (w32font_draw): Return number of glyphs.
10325 (w32font_open_internal): Remove unused variable `i'.
10326 (w32font_driver): Add missing initializer.
10327
10328 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10329 (fill_in_menu): Remove unused variable `items_added'.
10330
10331 * w32term.c (last_mouse_press_frame): Remove static global variable.
10332 (w32_clip_to_row): Remove unused variable `f'.
10333 (x_delete_terminal): Remove unused variable `i'.
10334
10335 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10336 (NOTHING): Remove unused static global variable.
10337 (uniscribe_check_otf): Remove unused variable `table'.
10338 (uniscribe_font_driver): Add missing initializers.
10339
dee091a3
JD
103402011-03-23 Julien Danjou <julien@danjou.info>
10341
10342 * term.c (Fsuspend_tty, Fresume_tty):
10343 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10344 * window.c (temp_output_buffer_show):
10345 * insdel.c (signal_before_change):
10346 * frame.c (Fhandle_switch_frame):
10347 * fileio.c (Fdo_auto_save):
10348 * emacs.c (Fkill_emacs):
10349 * editfns.c (save_excursion_restore):
10350 * cmds.c (internal_self_insert):
10351 * callint.c (Fcall_interactively):
10352 * buffer.c (Fkill_all_local_variables):
10353 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10354 Use Frun_hooks.
0f4a96b5 10355 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10356 unconditionally since it does the check itself.
dee091a3 10357
2c520ab5 103582011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10359
c9c49752
PE
10360 Fix more problems found by GCC 4.5.2's static checks.
10361
8abc3f12
PE
10362 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10363 the first time through the loop, since we know p0 < p1 then.
10364 This also avoids a gcc -Wstrict-overflow warning.
10365
a2d26660
PE
10366 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10367 leading to a memory leak, possible in functions like
10368 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10369 of objects (Bug#8318).
a2d26660 10370
916c72e9
PE
10371 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10372 that could (at least in theory) be that large.
10373
19ab8a18
PE
10374 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10375 This is less likely to overflow, and avoids undefined behavior if
10376 overflow does occur. All callers changed. Use strtoul to scan
10377 for the unsigned long integer.
b7cbbd6f
PE
10378 (pint2hrstr): Simplify and tune code slightly.
10379 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10380
f0641eff
PE
10381 * scroll.c (do_scrolling): Work around GCC bug 48228.
10382 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10383
7f650bb9
PE
10384 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10385 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10386 (validate_x_resource_name): Simplify count usage.
10387 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10388
37dd57d1
PE
10389 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10390 fail (Bug#8306).
81e56e61 10391
699979fc 10392 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10393
401bf9b4
PE
10394 * process.c (Fmake_network_process): Use socklen_t, not int,
10395 where POSIX says socklen_t is required in portable programs.
10396 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10397 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10398 (Fmake_network_process, server_accept_connection):
10399 (wait_reading_process_output, read_process_output):
10400 Likewise.
10401
b93aacde
PE
10402 * process.c: Rename or move locals to avoid shadowing.
10403 (list_processes_1, Fmake_network_process):
10404 (read_process_output_error_handler, exec_sentinel_error_handler):
10405 Rename or move locals.
4dc343ee 10406 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10407 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10408 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10409 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10410 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10411
af8a867c 10412 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10413 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10414 Include tparam.h instead, since it declares them.
af8a867c
PE
10415 * cm.h (PC): Remove extern decl; tparam.h now does this.
10416 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10417 * terminfo.c: Include tparam.h, to check interfaces.
10418 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10419 (tparam): Adjust signature to match interface in tparam.h;
10420 this removes some undefined behavior. Check that outstring and len
10421 are zero, which they always are with Emacs.
10422 * tparam.h (PC, BC, UP): New extern decls.
10423
0248044d 10424 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10425 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10426
8ff096c1 10427 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10428 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10429 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10430 (ftfont_list): Remove unused local.
49eaafba
PE
10431 (get_adstyle_property, ftfont_pattern_entity):
10432 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10433 Rename locals to avoid shadowing.
8ff096c1 10434
e2be39f6
PE
10435 * xfont.c (xfont_list_family): Mark var as initialized.
10436
c9735e30
PE
10437 * xml.c (make_dom): Now static.
10438
8f5201ae
PE
10439 * composite.c (composition_compute_stop_pos): Rename local to
10440 avoid shadowing.
b246f932
PE
10441 (composition_reseat_it): Remove unused locals.
10442 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10443 (composition_update_it): Mark var as initialized.
11b61122
PE
10444 (find_automatic_composition): Mark vars as initialized,
10445 with a FIXME (Bug#8290).
8f5201ae 10446
760fbc2c
PE
10447 character.h: Rename locals to avoid shadowing.
10448 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10449 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10450 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10451 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10452 to avoid shadowing.
10453
ff08eb85
PE
10454 * textprop.c (property_change_between_p): Remove; unused.
10455
fc7bf025
PE
10456 * intervals.c (interval_start_pos): Now static.
10457
235d7abc
PE
10458 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10459
44f230aa
SM
10460 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10461 Rename locals to avoid shadowing.
3e7d6594 10462
50060332
PE
10463 * sound.c (wav_play, au_play, Fplay_sound_internal):
10464 Fix pointer signedness.
d01f234b 10465 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10466 (wav_play): Initialize a variable to 0, to prevent undefined
10467 behavior (Bug#8278).
50060332 10468
c4fc4e30
PE
10469 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10470
918436ed
PE
10471 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10472
c939f91b
PE
10473 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10474 clobbering (Bug#8298).
b9c7f648
PE
10475 * sysdep.c (sys_subshell): Likewise.
10476 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10477
6bd8c144
PE
10478 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10479 This should get cleaned up, so that child_setup has the
10480 same signature on all platforms.
10481
7710357c 10482 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10483 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10484
c59da222
CY
104852011-03-22 Chong Yidong <cyd@stupidchicken.com>
10486
10487 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10488 not to be necessary, and produces flickering.
10489
66b87493
GM
104902011-03-20 Glenn Morris <rgm@gnu.org>
10491
10492 * config.in: Remove file.
10493
45b6f6d5
JB
104942011-03-20 Juanma Barranquero <lekktu@gmail.com>
10495
10496 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10497 are now in src/globals.h.
10498 (syms_of_minibuf): Remove spurious & from previous change.
10499
cd394be1 105002011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10501
10502 * minibuf.c (completing-read-function): New variable.
10503 (completing-read-default): Rename from completing-read.
10504 (completing-read): Call completing-read-function.
10505
b14e3e21
CY
105062011-03-19 Juanma Barranquero <lekktu@gmail.com>
10507
10508 * xfaces.c (Fx_load_color_file):
10509 Read color file from absolute filename (bug#8250).
10510
f2b726e6
JB
105112011-03-19 Juanma Barranquero <lekktu@gmail.com>
10512
10513 * makefile.w32-in: Update dependencies.
10514
09f6ff02
EZ
105152011-03-17 Eli Zaretskii <eliz@gnu.org>
10516
10517 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10518
29a6015a
PE
105192011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10520
a3a6c54e
PE
10521 Fix more problems found by GCC 4.5.2's static checks.
10522
b766f867
PE
10523 * process.c (make_serial_process_unwind, send_process_trap):
10524 (sigchld_handler): Now static.
10525
be02381c
PE
10526 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10527 That way, the code declares only the vars that it needs.
10528 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10529 * s/cygwin.h (PTY_ITERATION): Likewise.
10530 * s/darwin.h (PTY_ITERATION): Likewise.
10531 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10532
57048744
PE
10533 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10534 * process.c (allocate_pty): Don't declare stb unless it's needed.
10535
7914961c 10536 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10537 (CONSTANTLIM): Remove; unused.
10538 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10539 Define only if needed.
7914961c 10540
b3967b18
PE
10541 * unexelf.c (unexec): Name an expression,
10542 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10543 Use a different way to cause a compilation error if anyone uses
10544 n rather than nn, a way that does not involve shadowing.
73366a00 10545 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10546
29a6015a
PE
10547 * deps.mk (unexalpha.o): Remove; unused.
10548
43cfc33e 10549 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10550 * unexec.h: New file.
ce701a33
PE
10551 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10552 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10553 Depend on unexec.h.
10554 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10555 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10556 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10557 Change as necessary to match prototype in unexec.h.
ce701a33 10558
01f44d5a
PE
10559 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10560 shadowing.
4f63c6bb 10561 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10562
a6670b0b
PE
10563 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10564 Rename locals to avoid shadowing.
10565
cef2010d 10566 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10567 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10568
d4d7173a
PE
10569 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10570
f08b802a
PE
10571 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10572 warning when compiling print.c.
10573
3ddb0639
PE
10574 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10575 instead of using an uninitialized var.
5ad03b97 10576 (font_sort_entities): Mark var as initialized.
3ddb0639 10577
170a2692
PE
10578 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10579
e663c700
PE
10580 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10581 pointers to constants.
89bc529a 10582 (font_parse_fcname): Remove unused vars.
7b81e2d0 10583 (font_delete_unmatched): Now static.
ea838e10 10584 (font_get_spec): Remove; unused.
13a547c6
PE
10585 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10586 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10587 Rename or move locals to avoid shadowing.
e663c700 10588
2a80c887 10589 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10590 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10591
1384fa33 10592 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10593 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10594
8b2c52e9
PE
10595 * alloc.c (mark_backtrace): Move decl from here ...
10596 * lisp.h: ... to here, so that it can be checked.
10597
475545b5 10598 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10599 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10600 (lisp_indirect_variable): Name an expression,
10601 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10602 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10603
b1349114 10604 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10605 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10606 Use const pointer when appropriate.
b1349114 10607
a2928364
PE
10608 * lisp.h (get_system_name, get_operating_system_release):
10609 Move decls here, to check interfaces.
10610 * process.c (get_operating_system_release): Move decl to lisp.h.
10611 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10612 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10613 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10614 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10615 (Fformat_time_string, Fencode_time, Finsert_char):
10616 (Ftranslate_region_internal, Fformat):
10617 Rename or remove local vars to avoid shadowing.
9710023e 10618 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10619
a415e694
PE
10620 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10621 avoid shadowing.
10622
8ef4622d
PE
10623 * lisp.h (eassert): Check that the argument compiles, even if
10624 ENABLE_CHECKING is not defined.
10625
946f9a5b
PE
10626 * data.c (Findirect_variable): Name an expression, to avoid
10627 gcc -Wbad-function-cast warning.
112396d6 10628 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10629 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10630 (Fmake_variable_buffer_local, Fmake_local_variable):
10631 Mark variables as initialized.
52746918 10632 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10633
e5aab7e7 10634 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10635 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10636 Rename locals to avoid shadowing.
dff45157
PE
10637 (mark_stack): Move local variables into the #ifdef region where
10638 they're used.
7bc26fdb
PE
10639 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10640 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10641 needed otherwise.
10642 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10643 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10644 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10645
e5aab7e7
PE
10646 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10647 avoids undefined behavior in theory.
10648
4da60324
PE
10649 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10650
88043301
PE
10651 Use functions, not macros, for up- and down-casing (Bug#8254).
10652 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10653 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10654 to use the following functions instead of these macros.
10655 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10656 EMACS_INT, since callers assume the returned value fits in int.
10657 (upcase1): Likewise, for UPCASE_TABLE.
10658 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10659 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10660 the race-condition problem in the old DOWNCASE.
88043301 10661
19ed5445
PE
10662 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10663 Rename locals to avoid shadowing.
10664 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10665 (regex_compile, re_search_2, re_match_2_internal):
10666 Remove unused local vars.
952db0d7
PE
10667 (FREE_VAR): Rewrite so as not to use empty "else",
10668 which gcc can warn about.
da053e48 10669 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10670 (RETALLOC_IF): Define only if needed.
10671 (WORDCHAR_P): Likewise. This one is never needed, but is used
10672 only in a comment talking about a compiler bug, so put inside
10673 the #if 0 of that comment.
10674 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10675 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10676 Remove; unused.
19ed5445 10677
1f3561e4 10678 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10679 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10680 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10681
ded6f8f7
PE
10682 * search.c (simple_search): Remove unused var.
10683
dbd37a95
PE
10684 * dired.c (compile_pattern): Move decl from here ...
10685 * lisp.h: ... to here, so that it can be checked.
10686 (struct re_registers): New forward decl.
10687
7e47afad
PE
10688 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10689
85f24f61
PE
10690 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10691 All uses changed.
10692 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10693 Rename locals to avoid shadowing.
5671df8f 10694 (Fvertical_motion): Mark locals as initialized.
85f24f61 10695
181aa2be 10696 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10697 (casify_region): Mark local as initialized.
181aa2be 10698
930d429c
PE
10699 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10700
7082eac6
PE
10701 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10702 New macros, so that the caller can use some names other than
10703 gcpro1, gcpro2, etc.
10704 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10705 of the new macros.
10706 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10707 argument, for consistency with GCPRO2_VAR, etc: it is now the
10708 prefix of the variable, not the variable itself. All uses
10709 changed.
38b2c076
PE
10710 * dired.c (directory_files_internal, file_name_completion):
10711 Rename locals to avoid shadowing.
10712
15206ed9
PE
10713 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10714 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10715 dired.c's scmp function, had undefined behavior.
10716 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10717 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10718 * buffer.h: ... to here, because these macros use current_buffer,
10719 and the new implementation with inline functions needs to have
10720 current_buffer in scope now, rather than later when the macros
10721 are used.
10722 (downcase, upcase1): New static inline functions.
10723 (DOWNCASE, UPCASE1): Reimplement using these functions.
10724 This avoids undefined behavior in expressions like
10725 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10726 from race conditions in accessing the global variables
10727 case_temp1 and case_temp2.
10728 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10729 * lisp.h (case_temp1, case_temp2): Remove their decls.
10730 * character.h (ASCII_CHAR_P): Move from here ...
10731 * lisp.h: ... to here, so that the inline functions mentioned
10732 above can use them.
10733
4a6bea26
PE
10734 * dired.c (directory_files_internal_unwind): Now static.
10735
f14b7e14
PE
10736 * fileio.c (file_name_as_directory, directory_file_name):
10737 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10738 Now static.
2893f146
PE
10739 (file_name_as_directory): Use const pointers when appropriate.
10740 (Fexpand_file_name): Likewise. In particular, newdir might
10741 point at constant storage, so make it a const pointer.
fd4ead52 10742 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10743 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10744 signedness issues.
f839df0c
PE
10745 (Fset_file_times, Finsert_file_contents, auto_save_error):
10746 Rename locals to avoid shadowing.
f14b7e14 10747
5716756e 10748 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
10749 (Ftry_completion, Fall_completions): Rename or remove locals
10750 to avoid shadowing.
5716756e 10751
b4c3046a
PE
10752 * marker.c (bytepos_to_charpos): Remove; unused.
10753
b45db522
PE
10754 * lisp.h (verify_bytepos, count_markers): New decls,
10755 so that gcc does not warn that these functions aren't declared.
10756
85876d07
PE
10757 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10758 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 10759 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 10760 (copy_text): Remove unused local var.
85876d07 10761
03d78a21 10762 * filelock.c (within_one_second): Now static.
b3dd38ab 10763 (lock_file_1): Rename local to avoid shadowing.
03d78a21 10764
5df8f01b
PE
10765 * buffer.c (fix_overlays_before): Mark locals as initialized.
10766 (fix_start_end_in_overlays): Likewise. This function should be
10767 simplified by using pointers-to-pointers, but that's a different
10768 matter.
b1d876f1 10769 (switch_to_buffer_1): Now static.
8f54f30a
PE
10770 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10771 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 10772
a70072c9 10773 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 10774 Fix pointer signedness issue.
edced198
PE
10775 (sys_subshell): Mark local as volatile if checking for lint,
10776 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 10777 (MAXPATHLEN): Define only if needed.
a70072c9 10778
a0977c44
PE
10779 * process.c (serial_open, serial_configure): Move decls from here ...
10780 * systty.h: ... to here, so that they can be checked.
10781
a884fdcc
PE
10782 * fns.c (get_random, seed_random): Move extern decls from here ...
10783 * lisp.h: ... to here, so that they can be checked.
10784
604efe86 10785 * sysdep.c (reset_io): Now static.
b8950c94 10786 (wait_for_termination_signal): Remove; unused.
604efe86 10787
38fc62d9
PE
10788 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10789 (copy_keymap_item, append_key, push_text_char_description):
10790 Now static.
1004a21a 10791 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 10792 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
10793 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10794 (describe_map_tree):
10795 Rename locals to avoid shadowing.
38fc62d9 10796
2f2650da
PE
10797 * keyboard.c: Declare functions static if they are not used elsewhere.
10798 (echo_char, echo_dash, cmd_error, top_level_2):
10799 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
10800 (read_char, kbd_buffer_get_event, make_lispy_position):
10801 (make_lispy_event, make_lispy_movement, apply_modifiers):
10802 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10803 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10804 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 10805 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 10806 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 10807
a053e86c 10808 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
10809 (mark_kboards): Move decl here ...
10810 * alloc.c (mark_kboards): ... from here.
a053e86c 10811
4752793e
PE
10812 * lisp.h (force_auto_save_soon): New decl.
10813
74f10ca7 10814 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
10815 (DEFINE_DUMMY_FUNCTION): New macro.
10816 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10817 Use it.
c03cd23f
PE
10818 (main): Add casts to avoid warnings
10819 if GCC considers string literals to be constants.
74f10ca7 10820
022e70d4
PE
10821 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10822
59d6fe83
PE
10823 * dbusbind.c: Pointer signedness fixes.
10824 (xd_signature, xd_append_arg, xd_initialize):
10825 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10826 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10827 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10828 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10829
78320123
PE
10830 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10831 if GCC considers string literals to be constants.
49cebcca 10832 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10833
35ac2a97
SM
108342011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10835
fb103ca9
SM
10836 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10837 (print_preprocess, print_object): New macro to fix last change.
10838
35ac2a97
SM
10839 * print.c (print_preprocess): Don't forget font objects.
10840
62973b41
JB
108412011-03-16 Juanma Barranquero <lekktu@gmail.com>
10842
10843 * emacs.c (USAGE3): Doc fixes.
10844
0e48bb22
AS
108452011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10846
10847 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10848 structure.
10849
7684e57b
JB
108502011-03-14 Juanma Barranquero <lekktu@gmail.com>
10851
10852 * lisp.h (VWindow_system, Qfile_name_history):
10853 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10854 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10855 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10856
10857 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10858 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10859
10860 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10861 * w32console.c (detect_input_pending, read_input_pending)
10862 (encode_terminal_code):
10863 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10864 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10865 (w32_system_caret_y, Qfile_name_history):
10866 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10867 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10868 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10869 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10870 * w32proc.c (Qlocal, report_file_error):
10871 * w32term.c (Vwindow_system, updating_frame):
10872 * w32uniscribe.c (initialized, uniscribe_font_driver):
10873 Remove unneeded extern declarations.
10874
2aa46d6c
CY
108752011-03-14 Chong Yidong <cyd@stupidchicken.com>
10876
c96bbc66 10877 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10878
cffc6f3b
CY
108792011-03-13 Chong Yidong <cyd@stupidchicken.com>
10880
10881 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10882 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10883 These macros can no longer be used for assignment.
10884
44f230aa
SM
10885 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10886 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10887 (record_buffer_markers, fetch_buffer_markers): New functions for
10888 recording and fetching special buffer markers.
10889 (set_buffer_internal_1, set_buffer_temp): Use them.
10890
10891 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10892
10893 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10894
10895 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10896 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10897
10898 * xdisp.c (hscroll_window_tree):
10899 (reconsider_clip_changes): Use PT instead of BUF_PT.
10900
d251f04b
EZ
109012011-03-13 Eli Zaretskii <eliz@gnu.org>
10902
10903 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10904 $(EMACS_ROOT)/lib/intprops.h.
10905
f0c77cd1
PE
109062011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10907
3eca4629
PE
10908 Fix more problems found by GCC 4.5.2's static checks.
10909
7c86ee98
PE
10910 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10911 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10912 (xg_free_frame_widgets): Make it clear that a local variable is
10913 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10914 (gdk_window_get_screen): Make it clear that this macro is needed
10915 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10916 (int_gtk_range_get_value): New function, which avoids a diagnostic
10917 from gcc -Wbad-function-cast.
10918 (xg_set_toolkit_scroll_bar_thumb): Use it.
10919 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10920 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10921 (get_utf8_string, xg_get_file_with_chooser):
10922 Rename locals to avoid shadowing.
10923 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10924
41729b81
PE
10925 * xgselect.c (xg_select): Remove unused var.
10926
f0c77cd1
PE
10927 * image.c (four_corners_best): Mark locals as initialized.
10928 (gif_load): Initialize transparent_p to zero (Bug#8238).
10929 Mark another local as initialized.
ec6cf4c6 10930 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 10931
ce0ad53d 10932 * image.c (clear_image_cache): Now static.
d5d5a617 10933 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10934 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10935 (x_edge_detection): Remove unnecessary cast that
10936 gcc -Wbad-function-cast diagnoses.
2037898d 10937 (gif_load): Fix pointer signedness.
6ae141d6
PE
10938 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10939 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10940
33383987 109412011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10942
d32df629
PE
10943 Improve quality of tests for time stamp overflow.
10944 For example, without this patch (encode-time 0 0 0 1 1
10945 1152921504606846976) returns the obviously-bogus value (-948597
10946 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10947 reports time overflow. See
10948 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10949 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10950 * editfns.c: Include limits.h and intprops.h.
10951 (TIME_T_MIN, TIME_T_MAX): New macros.
10952 (time_overflow): Move earlier, to before first use.
10953 (hi_time, lo_time): New functions, for an accurate test for
10954 out-of-range times.
10955 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10956 (Fget_internal_run_time): Don't assume time_t fits in int.
10957 (make_time): Use list2 instead of Fcons twice.
10958 (Fdecode_time): More accurate test for out-of-range times.
10959 (check_tm_member): New function.
10960 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10961 (lisp_time_argument): Don't rely on undefined left-shift and
10962 right-shift behavior when checking for time stamp overflow.
8be6f318 10963
fe31d94c
PE
10964 * editfns.c (time_overflow): New function, refactoring common code.
10965 (Fformat_time_string, Fdecode_time, Fencode_time):
10966 (Fcurrent_time_string): Use it.
10967
8be6f318
PE
10968 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10969 * dired.c (make_time): Move to ...
10970 * editfns.c (make_time): ... here.
10971 * systime.h: Note the move.
10972
09d9db2c 109732011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10974
126bc0dc
YM
10975 * fringe.c (update_window_fringes): Remove unused variables.
10976
c47cbdfd
YM
10977 * unexmacosx.c (copy_data_segment): Also copy __got section.
10978 (Bug#8223)
10979
7ac80be9
EZ
109802011-03-12 Eli Zaretskii <eliz@gnu.org>
10981
c96bbc66 10982 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10983 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10984 Constify `char *' arguments and their references according to
10985 prototypes in tparam.h.
10986
ecb0f94d 10987 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10988
7ac80be9
EZ
10989 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10990 Adapt all references accordingly.
10991
10992 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10993
ef1fd07e
TT
109942011-03-11 Tom Tromey <tromey@redhat.com>
10995
10996 * buffer.c (syms_of_buffer): Remove obsolete comment.
10997
7ef4b50c
EZ
109982011-03-11 Eli Zaretskii <eliz@gnu.org>
10999
11000 * termhooks.h (encode_terminal_code): Declare prototype.
11001
11002 * msdos.c (encode_terminal_code): Don't declare prototype.
11003
11004 * term.c (encode_terminal_code): Now external again, used by
11005 w32console.c and msdos.c.
11006
44f230aa
SM
11007 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11008 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11009
4b1ec863 110102011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11011
1714f52b 11012 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11013
4b1ec863
PE
11014 * fringe.c (update_window_fringes): Mark locals as initialized
11015 (Bug#8227).
11016 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11017
524c7aa6
PE
11018 * alloc.c (mark_fringe_data): Move decl from here ...
11019 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11020 to check its interface.
11021 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11022
a5c0af81 11023 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11024 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11025 (fontset_font): Mark local as initialized.
a9a06e0b 11026 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11027
b4716021
PE
11028 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11029
811e9bac 11030 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11031 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11032 (x_own_selection, Fx_disown_selection_internal): Rename locals
11033 to avoid shadowing.
11034 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11035
7e3ab302
PE
11036 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11037 so that the caller can use some name other than gcpro1.
11038 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11039 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11040 (Fx_backspace_delete_keys_p):
11041 Use them to avoid shadowing, and rename vars to avoid shadowing.
11042 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11043 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11044 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11045 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11046 Remove unused locals.
7e3ab302
PE
11047 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11048 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11049 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11050 macros.
f78faa98 11051
e2b13473
PE
11052 * xterm.h (x_mouse_leave): New decl.
11053
77f23912
PE
11054 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11055 Remove unused functions.
cdf4ba58
PE
11056 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11057 (x_calc_absolute_position): Now static.
7411c686 11058 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11059 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11060 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11061 unless they are used.
38d0b34a
PE
11062 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11063 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11064 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11065 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11066 (x_error_catcher, x_connection_closed, x_error_handler):
11067 (x_error_quitter, xembed_send_message, x_iconify_frame):
11068 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11069 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11070 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11071
44f230aa
SM
11072 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11073 Rename or move locals to avoid shadowing.
6b463e58 11074 (tty_defined_color, merge_face_heights): Now static.
5967d051 11075 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11076 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11077 does not deduce is never used uninitialized.
73719eba
PE
11078 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11079 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11080
426994c3 11081 * terminal.c (store_terminal_param): Now static.
5489860b 11082
032f1620 11083 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11084 (set_frame_menubar): Remove unused local.
d4323972 11085 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11086 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11087 since they might point to immutable storage.
281585b0
PE
11088 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11089 since it's unused otherwise.
032f1620 11090
367c19e5 11091 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11092 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11093 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11094 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11095 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11096 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11097 does not deduce are never used uninitialized.
70739cbe 11098
07b48fa9
PE
11099 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11100
8868a238 11101 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11102 * window.c (window_loop, size_window):
11103 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11104
7e5cf297 11105 * window.c (display_buffer): Now static.
d6550a9f
PE
11106 (size_window): Mark variables that gcc -Wuninitialized
11107 does not deduce are never used uninitialized.
a586633d
PE
11108 * window.h (check_all_windows): New decl, to forestall
11109 gcc -Wmissing-prototypes diagnostic.
5b555da1 11110 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11111
f6095868
PE
11112 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11113 shadowing.
11114 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11115 Include <limits.h>.
11116 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11117 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11118 (load_charset_map): Mark variables that gcc -Wuninitialized
11119 does not deduce are never used uninitialized.
53df7c11 11120 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11121
f38b440c
PE
11122 * coding.c (coding_set_source, coding_set_destination):
11123 Use "else { /* comment */ }" rather than "else /* comment */;"
11124 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11125 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11126 a block, when the outer 'i' will do.
11127 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11128 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11129 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11130 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11131 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11132 Rename locals to avoid shadowing.
11133 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11134 * coding.c (emacs_mule_char, encode_invocation_designation):
11135 Now static, since they're not used elsewhere.
413bb2db 11136 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11137 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11138 (decode_coding_emacs_mule): Mark variables that gcc
11139 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11140 (detect_coding_iso_2022): Initialize a local variable that might
11141 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11142 this initialization is needed. (Bug#8211)
5f58e762
PE
11143 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11144 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11145 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11146 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11147 Remove unused macros.
f38b440c 11148
232b38b9 11149 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11150 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11151 * character.c (string_count_byte8): Likewise.
232b38b9 11152
fb90da1b
PE
11153 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11154 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11155
fb93dbc2
PE
11156 * chartab.c (copy_sub_char_table): Now static, since it's not used
11157 elsewhere.
5c156ace
PE
11158 (sub_char_table_ref_and_range, char_table_ref_and_range):
11159 Rename locals to avoid shadowing.
bbcd0949 11160 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11161
7d3b3862 11162 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11163 (BIDI_BOB): Remove unused macro.
7d3b3862 11164
6be7d3da
PE
11165 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11166 deduce are never used uninitialized.
c2ed9c8b 11167 * term.c (encode_terminal_code): Likewise.
6be7d3da 11168
75f8807f 11169 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11170
50938595
PE
11171 * tparam.h: New file.
11172 * term.c, tparam.h: Include it.
11173 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11174 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11175 Move these decls to tparam.h, and make them agree with what
11176 is actually in tparam.c. The previous trick of using incompatible
11177 decls in different modules does not conform to the C standard.
11178 All callers of tparam changed to use tparam's actual API.
11179 * tparam.c (tparam1, tparam, tgoto):
11180 Use const pointers where appropriate.
11181
fbceeba2
PE
11182 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11183 * cm.h (struct cm): Likewise.
11184 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11185 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11186 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11187 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11188 (turn_on_face, init_tty): Likewise.
11189 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11190
7f3f1250
PE
11191 * term.c (term_mouse_position): Rename local to avoid shadowing.
11192
e6ca6543
PE
11193 * alloc.c (mark_ttys): Move decl from here ...
11194 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11195
c40f8d15
AS
111962011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11197
11198 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11199
cfe0661d
JB
112002011-03-09 Juanma Barranquero <lekktu@gmail.com>
11201
11202 * search.c (compile_pattern_1): Remove argument regp, unused since
11203 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11204 (compile_pattern): Don't pass it.
11205
0afb4571
J
112062011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11207
11208 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11209 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11210 for ! HAVE_GTK3.
11211 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11212
11213 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11214
11215 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11216 gdk_window_get_screen, gdk_window_get_geometry,
11217 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11218 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11219 (xg_get_pixbuf_from_pixmap): New function.
11220 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11221 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11222 Call xg_get_pixbuf_from_pixmap instead of
11223 gdk_pixbuf_get_from_drawable.
11224 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11225 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11226 (xg_check_special_colors): Use GtkStyleContext and its functions
11227 for HAVE_GTK3.
11228 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11229 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11230 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11231 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11232 Call gtk_widget_get_preferred_size.
0afb4571
J
11233 (xg_frame_resized): gdk_window_get_geometry only takes 5
11234 parameters.
44f230aa
SM
11235 (xg_win_to_widget, xg_event_is_for_menubar):
11236 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11237 (xg_set_widget_bg): New function.
11238 (delete_cb): New function.
895009e1 11239 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11240 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11241 (xg_set_background_color): Call xg_set_widget_bg.
11242 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11243 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11244 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11245 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11246 if ! HAVE_GTK3.
11247 (update_frame_tool_bar): Call gtk_widget_hide.
11248 (xg_initialize): Use GDK_KEY_g.
11249
11250 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11251 if ! HAVE_GTK3
11252 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11253
11254 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11255 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11256 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11257
1c2cc4ef
JB
112582011-03-08 Juanma Barranquero <lekktu@gmail.com>
11259
11260 * w32xfns.c (select_palette): Check success of RealizePalette against
11261 GDI_ERROR, not zero.
11262
33383987 11263See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11264
11265;; Local Variables:
11266;; coding: utf-8
aac0c6e3
MR
11267;; End:
11268
2f097256 11269 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11270
11271 This file is part of GNU Emacs.
11272
11273 GNU Emacs is free software: you can redistribute it and/or modify
11274 it under the terms of the GNU General Public License as published by
11275 the Free Software Foundation, either version 3 of the License, or
11276 (at your option) any later version.
11277
11278 GNU Emacs is distributed in the hope that it will be useful,
11279 but WITHOUT ANY WARRANTY; without even the implied warranty of
11280 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11281 GNU General Public License for more details.
11282
11283 You should have received a copy of the GNU General Public License
11284 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.