* net/ange-ftp.el (ange-ftp-copy-file-internal): Check for
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5ccaba1f
JD
12011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4
204ee57f
JD
52011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6
7 * nsterm.m (x_free_frame_resources): Release
8 f->output_data.ns->miniimage
9 (ns_index_color): Fix indentation. Do not retain
10 color_table->colors[i].
11
12 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
13 before returning.
14
15 * nsfns.m (x_set_background_color): Assign return value from
16 ns_index_color to face-background instead of NSColor*.
17 (ns_implicitly_set_icon_type): Fix indentation.
18 Change assignment in for loop to comparison.
19
20 * emacs.c (ns_pool): New variable.
21 (main): Assign ns_pool.
22 (Fkill_emacs): Call ns_release_autorelease_pool.
23
24 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
25 autorelease fdesc, release fdAttrs and tdict.
26 (ns_get_covering_families): Release charset.
27 (ns_findfonts): Release NSFontDescriptor created with new.
28 (ns_uni_to_glyphs): Fix indentation.
29 (setString): Release attrStr before assigning new value.
30
c803b2b7
JD
312011-12-18 Jan Djärv <jan.h.d@swipnet.se>
32
678f4426
JD
33 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
34 and NS_IMPL_COCOA.
35 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
36 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
37
382011-12-18 David Reitter <reitter@cmu.edu>
39
5fecd5fc
JD
40 * nsterm.m (ns_term_init): Subscribe for notifications
41 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
42 to method trackingNotification in EmacsMenu.
43
44 * nsmenu.m (trackingMenu): New variable.
3771cb17 45 (trackingNotification): New method (from Aquamacs).
5fecd5fc 46 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 47 from Aquamacs (Bug#7030).
678f4426
JD
48
492011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 50
c803b2b7
JD
51 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
52 (symbol_to_nsstring): Fix indentation.
53 (ns_symbol_to_pb): New function.
54 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
55 (Fns_rotate_cut_buffers_internal): Removed.
56 (Fns_store_selection_internal): Renamed from
57 Fns_store_cut_buffer_internal.
58 (ns_get_foreign_selection, Fx_own_selection_internal)
59 (Fx_disown_selection_internal, Fx_selection_exists_p)
60 (Fns_get_selection_internal, Fns_store_selection_internal): Use
61 ns_symbol_to_pb and check if return value is nil.
62 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove
63 defsubr Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
64 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
65 renamed to Sns_store_selection_internal.
66 (ns_handle_selection_request): Move code to Fx_own_selection_internal
67 and remove this function.
68 (ns_handle_selection_clear): Remove, never used.
69 (Fx_own_selection_internal): Move code from ns_handle_selection_request
70 here.
71
e1b01a3a
KB
722011-12-17 Ken Brown <kbrown@cornell.edu>
73
74 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
75 GID is unknown (Bug#10257).
76
2adb6e85
PE
772011-12-17 Paul Eggert <eggert@cs.ucla.edu>
78
79 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
80 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
81 which caused a build failure on GNU/Linux IA-64. This problem was
82 introduced by my 2011-10-07 patch.
83
d1d7b339
JL
842011-12-15 Juri Linkov <juri@jurta.org>
85
86 * image.c (imagemagick_error): New function. (Bug#10112)
87 (imagemagick_load_image): Comment out `MagickSetResolution' call.
88 Use `imagemagick_error' where ImageMagick functions return
89 `MagickFalse'.
90 (Fimagemagick_types): Add `Fnreverse' to return the list in the
91 proper order.
92
100d5755
KH
932011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
94
95 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
96 fill background (Bug#8992).
97
454592a6
MR
982011-12-13 Martin Rudalics <rudalics@gmx.at>
99
100 * window.c (Vwindow_combination_resize)
101 (Vwindow_combination_limit): Use t instead of non-nil in
102 doc-strings.
61d4b438
MR
103 (Vrecenter_redisplay): Add first sentence of doc-string on
104 separate line.
53524d93 105 (Frecenter): Fix doc-string typo.
454592a6 106
3633e3aa
KH
1072011-12-11 Kenichi Handa <handa@m17n.org>
108
109 * coding.c (Funencodable_char_position): Pay attention to the
110 buffer text relocation (Bug#9389).
111
7b9d523a
JD
1122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
113
114 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
115 gtk_init (Bug#10100).
116
b73189c6
EZ
1172011-12-10 Eli Zaretskii <eliz@gnu.org>
118
119 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
120 IT->string is nil. (Bug#10263)
121
f7dfe5d6
JD
1222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
123
83faebb4
JD
124 * nsterm.h (x_free_frame_resources): Declare.
125
f7dfe5d6
JD
126 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
127 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
128
129 * nsterm.h (ns_get_defaults_value): Declare.
130
131 * nsterm.m (ns_default): Call ns_get_defaults_value.
132
7cd4e72c
EZ
1332011-12-09 Eli Zaretskii <eliz@gnu.org>
134
135 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
136 (Bug#10170)
137
b34d7317
YM
1382011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
139
140 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
141 that where the value of an _OBJC_* symbol points to is in the .bss
142 section (Bug#10240).
143
76470ad1
KH
1442011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
145
146 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 147 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 148
745fff94
KH
1492011-12-08 Kenichi Handa <handa@m17n.org>
150
151 * ftfont.c (get_adstyle_property): Fix previous change
152 (Bug#10233).
153
6e44397c
JB
1542011-12-07 Juanma Barranquero <lekktu@gmail.com>
155
156 * w32.c (init_environment): If no_site_lisp, remove site-lisp
157 dirs from the default value of EMACSLOADPATH (bug#10208).
158
7efa6272
GM
1592011-12-07 Glenn Morris <rgm@gnu.org>
160
161 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
162 installation and source directories as well. (Bug#10208)
163
f6fc4d87
CY
1642011-12-06 Chong Yidong <cyd@gnu.org>
165
166 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
167
2bf26180
GM
1682011-12-06 Glenn Morris <rgm@gnu.org>
169
170 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
171 as an error, not just -1. (Bug#10217)
172
3a6ad4f0
CY
1732011-12-05 Chong Yidong <cyd@gnu.org>
174
175 * keyboard.c (process_special_events): New function.
176 (swallow_events, Finput_pending_p): Use it (Bug#10195).
177
75a3b399
PE
1782011-12-05 Paul Eggert <eggert@cs.ucla.edu>
179
180 * coding.c (encode_designation_at_bol): Don't use uninitialized
181 local variable (Bug#9318).
182
c3c9e25e
KH
1832011-12-05 Kenichi Handa <handa@m17n.org>
184
185 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
186 return Qnil (Bug#8046, Bug#10193).
187
5eb05ea3
KH
1882011-12-05 Kenichi Handa <handa@m17n.org>
189
190 * coding.c (encode_designation_at_bol): New args charbuf_end and
191 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
192 (coding_set_source): Return how many bytes coding->source was
193 relocated.
194 (coding_set_destination): Return how many bytes
195 coding->destination was relocated.
196 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
197 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
198
1992011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
200
201 * coding.c (CODING_CHAR_CHARSET_P): New macro.
202 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
203 macro (Bug#9318).
204
2052011-12-05 Andreas Schwab <schwab@linux-m68k.org>
206
207 The following changes are to fix Bug#9318.
208
a79703f5 209 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
210 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
211 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 212 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 213
7dbda6df
JB
2142011-12-05 Juanma Barranquero <lekktu@gmail.com>
215
216 * lisp.h (process_quit_flag): Fix external declaration.
217
6d5eb5b0
SM
2182011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
219
220 Don't macro-inline non-performance-critical code.
221 * eval.c (process_quit_flag): New function.
222 * lisp.h (QUIT): Use it.
223
a0c3fad0
JD
2242011-12-04 Jan Djärv <jan.h.d@swipnet.se>
225
226 * nsfns.m (get_geometry_from_preferences): New function.
227 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
228
6c07aac2
AS
2292011-12-04 Andreas Schwab <schwab@linux-m68k.org>
230
231 * emacs.c (Qkill_emacs): Define.
232 (syms_of_emacs): Initialize it.
233 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
234 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
235 (quit_throw_to_read_char): Add parameter `from_signal'.
236 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
237 * lisp.h (QUIT): Call Fkill_emacs if requested.
238
c052ead4
JD
2392011-12-03 Jan Djärv <jan.h.d@swipnet.se>
240
241 * widget.c (update_wm_hints): Return if wmshell is null.
242 (widget_update_wm_size_hints): New function.
243
244 * widget.h (widget_update_wm_size_hints): Declare.
245
246 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
247 widget_update_wm_size_hints (Bug#10104).
248
9e49252b
EZ
2492011-12-03 Eli Zaretskii <eliz@gnu.org>
250
251 * xdisp.c (handle_invisible_prop): If the invisible text ends just
252 before a newline, prepare the bidi iterator for consuming the
253 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 254 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 255
02b16839
JL
2562011-12-02 Juri Linkov <juri@jurta.org>
257
258 * search.c (Fword_search_regexp): New Lisp function created from
259 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
260 (Fword_search_backward, Fword_search_forward)
261 (Fword_search_backward_lax, Fword_search_forward_lax):
262 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
263 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
264
0068070e
SM
2652011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
266
267 * fileio.c (Finsert_file_contents): Move after-change-function call
268 to before the "handled:" label, since all "goto handled" appear in
269 cases where the *-change-functions have already been properly called
270 (bug#10117).
271
3360a3fc
AS
2722011-12-01 Andreas Schwab <schwab@linux-m68k.org>
273
274 * keyboard.c (interrupt_signal): Don't call kill-emacs when
275 waiting for input. (Bug#10169)
276
73d6c093
EZ
2772011-11-30 Eli Zaretskii <eliz@gnu.org>
278
279 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
280 verifies glyph row's hash code--we have just reallocated the
281 glyphs, so their contents can be complete garbage. (Bug#10164)
282
febe6bea
JB
2832011-11-30 Juanma Barranquero <lekktu@gmail.com>
284
285 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
286
801a4313
EZ
2872011-11-30 Eli Zaretskii <eliz@gnu.org>
288
289 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
290 attributes are tested _before_ calling verify_row_hash, to protect
291 against GCC re-ordering of the tests. (Bug#10164)
292
2b56b87e
JD
2932011-11-29 Jan Djärv <jan.h.d@swipnet.se>
294
295 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
296
297 * xterm.c (handle_one_xevent): Only set async_visible and friends
298 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 299 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
300 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
301
dbf31225
PE
3022011-11-28 Paul Eggert <eggert@cs.ucla.edu>
303
304 Remove GCPRO-related macros that exist only to avoid shadowing locals.
305 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
306 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
307 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
308 All uses changed to use GCPRO1 etc.
309 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
310 Revert to old implementation (i.e., before 2011-03-11).
311
1305621b
YM
3122011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
313
314 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
315 of scroll runs so as to avoid assigning disabled bogus rows and
316 unnecessary graphics copy operations.
317
8c9afb46
EZ
3182011-11-27 Eli Zaretskii <eliz@gnu.org>
319
320 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
321 (snprintf) [_MSC_VER]: Redirect to _snprintf.
322 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
323 (malloc, free, realloc, calloc): Redirect to e_* only when
324 compiling Emacs.
325
326 * lisp.h (GCTYPEBITS): Move before first use.
327 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
328 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
329 this macro definition.
330
331 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
332 _MSC_VER.
333
54e9e3bf
JD
3342011-11-27 Jan Djärv <jan.h.d@swipnet.se>
335
6d5eb5b0
SM
336 * gtkutil.c (xg_create_frame_widgets):
337 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
338 present with Gtk+ 2.0.
339
83aca1cb
PE
3402011-11-26 Paul Eggert <eggert@cs.ucla.edu>
341
342 * fileio.c (Finsert_file_contents): Undo previous change; see
343 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
344
5b76caa4
PE
3452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
346
347 Rename locals to avoid shadowing.
348 * fileio.c (Finsert_file_contents):
349 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
350 * process.c (wait_reading_process_output):
351 Rename inner 'proc' to 'p' to avoid shadowing.
352 Indent for consistency with usual Emacs style.
353
8c535114
EZ
3542011-11-25 Eli Zaretskii <eliz@gnu.org>
355
356 * xdisp.c (redisplay_window): If cursor row is not fully visible
357 after recentering, and scroll-conservatively is set to a large
358 number, scroll window by a few more lines to make the cursor fully
359 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
360 (start_display): Don't move to the next line if the display should
361 start at a newline that is part of a display vector or an overlay
362 string. (Bug#10119)
8c535114 363
fa4fdb5c
JL
3642011-11-24 Juri Linkov <juri@jurta.org>
365
366 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
367 after the `MagickPingImage' call. (Bug#10112)
368
90ec88df
CY
3692011-11-23 Chong Yidong <cyd@gnu.org>
370
371 * window.c (Fcoordinates_in_window_p): Accept only live windows.
372
56e2e794
MR
3732011-11-23 Martin Rudalics <rudalics@gmx.at>
374
375 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
376 making another buffer current. (Bug#10114)
377
b6e64c41
GM
3782011-11-23 Glenn Morris <rgm@gnu.org>
379
380 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
381
6b21de18
CY
3822011-11-23 Chong Yidong <cyd@gnu.org>
383
384 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
385 using it (Bug#5984).
386
b12cd789
EZ
3872011-11-22 Eli Zaretskii <eliz@gnu.org>
388
389 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
390 and header-lines, as they don't have one computed for them.
391 (Bug#10098)
392
393 * .gdbinit (prow): Make displayed values more self-explaining.
394 Add row's hash code.
395
261b6fd4
LMI
3962011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
397
398 * process.c (wait_reading_process_output): Fix asynchrounous
399 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 400 (wait_reading_process_output): Add comment and URL.
261b6fd4 401
e7cfd277
JD
4022011-11-21 Jan Djärv <jan.h.d@swipnet.se>
403
404 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
405
a9b9b7f5
CY
4062011-11-21 Chong Yidong <cyd@gnu.org>
407
408 * window.c (Fnext_window, Fprevious_window): Doc fix.
409
b0d15b4f
SM
4102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
411
412 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
413
fe7a3057
JB
4142011-11-20 Juanma Barranquero <lekktu@gmail.com>
415
416 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
417
d2999b1a
MR
4182011-11-20 Martin Rudalics <rudalics@gmx.at>
419
420 * window.c (Fset_window_combination_limit): Rename argument
421 STATUS to LIMIT.
422 (Vwindow_combination_limit): Remove "status" from doc-string.
423
d5ff9cd0
AS
4242011-11-20 Andreas Schwab <schwab@linux-m68k.org>
425
426 * m/ibms390.h: Remove.
427 * m/ibms390x.h: Don't include "ibms390.h".
428
a5bb9bd3
SM
4292011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
430
431 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
432 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
433
cd1181db
JB
4342011-11-20 Juanma Barranquero <lekktu@gmail.com>
435
436 * casetab.c (Fset_case_table):
437 * charset.c (Fcharset_after): Fix typos.
438
615a3b8d 4392011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 440
17e845af
PE
441 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
442 Otherwise, valgrind does not work on some platforms.
443 Problem reported by Andreas Schwab in
6a0bf43d
PE
444 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
445 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
446 is set, removing the need for VIRT_ADDRESS_VARIES.
447 (PURE_P): Use a more-efficient implementation that needs just one
448 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
449 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
450 to 4 (xorl, subq, cmpq, setbe).
451 * alloc.c (pure): Always extern now, since that's the
452 VIRT_ADDR_VARIES behavior.
453 (PURE_POINTER_P): Use a single comparison, not two, for
454 consistency with the new puresize.h.
455 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
456 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
457 Remove VIRT_ADDR_VARIES no longer needed.
458
f8fe6f96
EZ
4592011-11-19 Eli Zaretskii <eliz@gnu.org>
460
461 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
462 (erase_phys_cursor, update_window_cursor, show_mouse_face)
463 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
464 behave as if the cursor position were at the window margin.
465
466 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
467 and the cursor position is out of bounds, behave as if the cursor
468 position were at the window margin. (Bug#10075)
469
df05a53c
CY
4702011-11-18 Chong Yidong <cyd@gnu.org>
471
472 * window.c (Fwindow_combination_limit): Make first argument
473 non-optional, since it is meaningless for live windows like the
474 selected window.
475
2071918e
DA
4762011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
477
478 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
479
b50a28de
SM
4802011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
481
482 * intervals.c: Fix grafting over the whole buffer (bug#10071).
483 (graft_intervals_into_buffer): Simplify.
484
015137db
EZ
4852011-11-18 Eli Zaretskii <eliz@gnu.org>
486
487 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
488 hash values of the two rows.
489 (copy_row_except_pointers): Preserve the used[] arrays and the
490 hash values of the two rows. (Bug#10035)
68c95424 491 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
492
493 * xdisp.c (row_hash): New function, body extracted from
494 compute_line_metrics.
495 (compute_line_metrics): Call row_hash, instead of computing the
496 hash code inline.
497
498 * dispnew.c (verify_row_hash): Call row_hash for computing the
499 hash code of a row, instead of duplicating code from xdisp.c.
500
501 * dispextern.h (row_hash): Add prototype.
502
a2addb04
TH
5032011-11-18 Tassilo Horn <tassilo@member.fsf.org>
504
505 * frame.c (delete_frame): Don't delete the terminal when the last
506 X frame is closed if emacs is built with GTK toolkit.
507
df85d315
JB
5082011-11-17 Juanma Barranquero <lekktu@gmail.com>
509
510 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
511
a0c2d0ae
MR
5122011-11-17 Martin Rudalics <rudalics@gmx.at>
513
514 * window.c (Vwindow_splits): Rename to
515 Vwindow_combination_resize. Suggested by Juri Linkov.
516 (Fsplit_window_internal): Use Vwindow_combination_resize instead
517 of Vwindow_splits.
518
58179cce
JB
5192011-11-16 Juanma Barranquero <lekktu@gmail.com>
520
7877f373
JB
521 * nsfns.m (Fns_font_name):
522 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 523
b6f67890
MR
5242011-11-16 Martin Rudalics <rudalics@gmx.at>
525
526 * window.h (window): Rename slot "nest" to "combination_limit".
527 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
528 (Fset_window_nest): Rename to Fset_window_combination_limit.
529 (Vwindow_nest): Rename to Vwindow_combination_limit.
530 (recombine_windows, make_parent_window, make_window)
531 (Fsplit_window_internal, saved_window)
532 (Fset_window_configuration, save_window_save): Rename all
533 occurrences of window_nest to window_combination_limit.
534
c7015153
JB
5352011-11-15 Juanma Barranquero <lekktu@gmail.com>
536
537 * image.c (imagemagick_load_image): Fix typo.
538
322ad6ec
EZ
5392011-11-14 Eli Zaretskii <eliz@gnu.org>
540
541 * xdisp.c (display_line): Move the call to
542 highlight_trailing_whitespace before the call to
543 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
544 faces of all the glyphs to compute ROW's hash value.
545 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 546
f067b8ec
JB
5472011-11-14 Juanma Barranquero <lekktu@gmail.com>
548
549 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
550 just return (bug#10044).
551
1e5b2111
EZ
5522011-11-12 Eli Zaretskii <eliz@gnu.org>
553
7ef3cbd5
EZ
554 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
555 with user-defined heap size. Bump the default size of the temacs
556 heap to 27MB, to avoid memory warning when running temacs.
557 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
558
1e5b2111
EZ
559 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
560 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
561 (verify_row_hash) [XASSERTS]: New function.
562 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
563 that the hash value of glyph rows is correct.
1e5b2111 564
89d61221
MR
5652011-11-12 Martin Rudalics <rudalics@gmx.at>
566
567 * window.h (window): Remove splits slot.
568 * window.c (Fwindow_splits, Fset_window_splits): Remove.
569 (Fdelete_other_windows_internal, make_parent_window)
570 (make_window, Fsplit_window_internal, Fdelete_window_internal)
571 (Fset_window_configuration, save_window_save): Don't deal with
572 split status of windows.
573 (saved_window): Remove splits slot.
574 (Vwindow_splits): Rewrite doc-string.
575
97f18cc8
JD
5762011-11-11 Jan Djärv <jan.h.d@swipnet.se>
577
578 * xfns.c (unwind_create_frame):
579 * nsfns.m (unwind_create_frame):
580 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
581 Vframe_list (Bug#9999).
582
22a648b4
DA
5832011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
584
0b381c7e 585 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 586
659afede
KH
5872011-11-11 Kenichi Handa <handa@m17n.org>
588
589 * callproc.c (Fcall_process): Set the member dst_multibyte of
590 process_coding.
591
9ac0394b
KH
5922011-11-11 Johan Bockgård <bojohan@gnu.org>
593
594 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
595 avoid a crash (bug#9496).
596
2fbdc249
CY
5972011-11-09 Chong Yidong <cyd@gnu.org>
598
599 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
600 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
601
ac6b1f81
PE
6022011-11-08 Paul Eggert <eggert@cs.ucla.edu>
603
604 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
605
09db192c
PE
6062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
607
608 Avoid some portability problems by eschewing 'extern inline' functions.
609 The trivial performance wins aren't worth the portability hassles; see
610 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
611 et seq.
612 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
613 (window_box_width, window_box_left, window_box_left_offset)
614 (window_box_right, window_box_right_offset): Undo previous change,
615 by removing the "extern"s.
616 * intervals.c (adjust_intervals_for_insertion)
617 (adjust_intervals_for_deletion): Undo previous change,
618 making these static again.
619 (offset_intervals, temp_set_point_both, temp_set_point)
620 (copy_intervals_to_string): No longer inline.
621 * xdisp.c (window_text_bottom_y, window_box_width)
622 (window_box_height, window_box_left_offset)
623 (window_box_right_offset, window_box_left, window_box_right)
624 (window_box): No longer inline.
625
105216ed
CY
6262011-11-08 Chong Yidong <cyd@gnu.org>
627
628 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
629 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
630 Signal an error if not a live window.
105216ed
CY
631 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
632 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
633
ae9e237f
JB
6342011-11-07 Juanma Barranquero <lekktu@gmail.com>
635
636 * lisp.h (syms_of_abbrev): Remove declaration.
637 Reported by CHENG Gao <chenggao@royau.me>.
638
c7aa8333
EZ
6392011-11-07 Eli Zaretskii <eliz@gnu.org>
640
641 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
642 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
643 of temacs in GUI mode.
644
be7f5545
MR
6452011-11-07 Martin Rudalics <rudalics@gmx.at>
646
647 * window.h: Declare delete_all_child_windows instead of
648 delete_all_subwindows.
649 * window.c (Fwindow_nest, Fset_window_nest)
650 (Fset_window_new_total, Fset_window_new_normal)
651 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
652 (delete_all_subwindows): Rename to delete_all_child_windows.
653 (Fdelete_other_windows_internal, Fset_window_configuration):
654 Call delete_all_child_windows instead of delete_all_subwindows.
655 * frame.c (delete_frame): Call delete_all_child_windows instead
656 of delete_all_subwindows.
657
ca78dc43
PE
6582011-11-07 Paul Eggert <eggert@cs.ucla.edu>
659
660 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
661 This is also needed for porting to any host where GC_MARK_STACK is
662 not GC_MAKE_GCPROS_NOOPS.
663 (which_symbols): Use it.
664
a0241d01
KH
6652011-11-07 Kenichi Handa <handa@m17n.org>
666
667 * coding.c (coding_set_destination): Check coding->src_pos only
668 when coding->src_object is a buffer (bug#9910).
669
670 * process.c (send_process): Set the member src_multibyte of coding
671 to 0 (bug#9911) when sending a unibyte text.
672
673 * callproc.c (Fcall_process): Set the member src_multibyte of
674 process_coding to 0 (bug#9912).
675
a64bfdfa 6762011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
677
678 * xmenu.c (cleanup_widget_value_tree): New function.
679 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
680 calling free_menubar_widget_value_tree directly (Bug#9830).
681
cb41b32a
PE
6822011-11-06 Paul Eggert <eggert@cs.ucla.edu>
683
684 Fix some portability problems with 'inline'.
685 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
686 (window_box_width, window_box_left, window_box_left_offset)
687 (window_box_right, window_box_right_offset): Declare extern.
688 Otherwise, these inline functions do not conform to C99 and
689 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
690 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
691 * intervals.c (adjust_intervals_for_insertion)
692 (adjust_intervals_for_deletion): Now extern, because otherwise the
693 extern inline functions 'offset_intervals' couldn't refer to it.
694 (static_offset_intervals): Remove.
695 (offset_intervals): Rewrite using the old contents of
696 static_offset_intervals. The old version didn't conform to C99
697 because an extern inline function contained a reference to an
698 identifier with static linkage.
699
b7041366
AS
7002011-11-06 Andreas Schwab <schwab@linux-m68k.org>
701
702 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
703 GC.
704
88a37c4d
EZ
7052011-11-06 Eli Zaretskii <eliz@gnu.org>
706
707 * xdisp.c (init_iterator, reseat_to_string): Don't set the
708 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
709 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
710 return Qleft_to_right.
711
49745b39
CY
7122011-11-06 Chong Yidong <cyd@gnu.org>
713
714 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
715 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
716 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
717 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
718 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
719 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
720 (Fwindow_vscroll): Doc fix.
721 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
722 argument, since it makes no sense to pass a live window and for
723 consistency with window-child.
724
1f05cd82
CS
7252011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
726
727 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
728 support MSVC.
729
22610910
JR
7302011-11-05 Jason Rumney <jasonr@gnu.org>
731
732 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
733 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
734 fonts (Bug#6029).
735 (add_font_entity_to_list): Fix logic errors in mixed boolean and
736 bitwise arithmetic preventing use of unicode-sip and non-truetype
737 opentype fonts.
738
a06776b2
EZ
7392011-11-05 Eli Zaretskii <eliz@gnu.org>
740
3ad924ba
EZ
741 * s/ms-w32.h (fstat, stat, utime): Move redirections to
742 "emacs"-only part.
743
a06776b2
EZ
744 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
745 initialization code to keep similarity to xfns.c after changes
746 from 2011-11-05.
747
c9e7db78
JD
7482011-11-05 Jan Djärv <jan.h.d@swipnet.se>
749
a97f8f3f
JD
750 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
751 (unwind_create_frame): New function (Bug#9943).
752 (Fx_create_frame): Restructure code to be more similar to the one in
753 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
754 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
755 Move terminal->reference_count++ just before making the frame official
756 (Bug#9943).
757
758 * nsterm.m (x_free_frame_resources): New function.
759 (x_destroy_window): Move code to x_free_frame_resources.
760
c9e7db78 761 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
762 (Fx_create_frame, x_create_tip_frame):
763 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
764 official. Move initialization of image_cache_refcount and
765 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
766
a6fc3b5c
EZ
7672011-11-05 Eli Zaretskii <eliz@gnu.org>
768
769 Support MSVC build with newer versions of Visual Studio.
770 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
771 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
772 nt/gmake.defs.
773
774 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
775 which are not supported by MSVC.
776 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
777 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
778 bitfields.
779 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
780 types in bitfields.
781 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
782
783 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
784
58179cce 7852011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
786
787 Support MSVC build with newer versions of Visual Studio.
788 * w32.c: Don't include w32api.h for MSVC.
789 (init_environment) [_MSC_VER]: Call sys_access, not _access.
790
791 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
792 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
793 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
794 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
795 e_* cousins.
796 (alloca) [_MSC_VER]: Define to _alloca.
797
798 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
799
800 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
801
a58c13ed
EZ
8022011-11-04 Eli Zaretskii <eliz@gnu.org>
803
804 * xdisp.c (note_mouse_highlight): If either of
805 previous/next-single-property-change returns nil, treat that as
806 the beginning or the end of the buffer. (Bug#9955)
807
fe0b6370
JD
8082011-11-04 Jan Djärv <jan.h.d@swipnet.se>
809
a58c13ed 810 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
811 label is not null (Bug#9951).
812 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
813 may be NULL.
814
89bd5ee1
EZ
8152011-11-04 Eli Zaretskii <eliz@gnu.org>
816
817 * window.c (Fwindow_body_size): Mention in the doc string that the
818 return value is in frame's canonical units. (Bug#9949)
819
84c3edb9
EZ
8202011-11-03 Eli Zaretskii <eliz@gnu.org>
821
4e2fb5c7
EZ
822 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
823
84c3edb9 824 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 825 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 826 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 827
bc17a887
EZ
8282011-11-01 Eli Zaretskii <eliz@gnu.org>
829
830 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
831 Don't stop backward scan on the continuation glyph, even though
832 its CHARPOS is positive.
6d5eb5b0
SM
833 (mouse_face_from_buffer_pos, note_mouse_highlight):
834 Rename cover_string to disp_string.
bc17a887 835
4ee88440
MR
8362011-11-01 Martin Rudalics <rudalics@gmx.at>
837
838 * window.c (temp_output_buffer_show): Don't use
839 Vtemp_buffer_show_specifiers.
840 (Vtemp_buffer_show_specifiers): Remove unused variable.
841
c2ff3c02
EZ
8422011-10-30 Eli Zaretskii <eliz@gnu.org>
843
844 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
845 past the beginning of the current glyph matrix.
846
58179cce 8472011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
848
849 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
850 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
851 HAVE_GTK3 (Bug#9869).
b77a6a7f 852
3b574623
JD
853 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
854 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
855
b77a6a7f
JD
856 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
857
858 * xterm.c: Declare x_handle_net_wm_state to return int.
859 (handle_one_xevent): Check if we are iconified but don't have
860 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
861 (get_current_wm_state): Return non-zero if not hidden,
862 check for _NET_WM_STATE_HIDDEN (Bug#9893).
863 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
864 (x_handle_net_wm_state): Return what get_current_wm_state returns.
865 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
866
196e41e4
PE
8672011-10-29 Paul Eggert <eggert@cs.ucla.edu>
868
869 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
870 so that this new function doesn't get optimized away by a
871 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
872
021f2e1a
AS
8732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
874
875 * frame.h (MOUSE_HL_INFO): Remove excess parens.
876
8b058d44
EZ
8772011-10-29 Eli Zaretskii <eliz@gnu.org>
878
879 Fix the `xbytecode' command.
880 * .gdbinit (xprintbytestr): New command.
b50a28de 881 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
882 (xbytecode): Print the byte-code string as well.
883
4452fb80
EZ
8842011-10-29 Kim Storm <storm@cua.dk>
885
8b058d44
EZ
886 * alloc.c (which_symbols): New function.
887
21b72067
AS
8882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
889
890 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
891 line. (Bug#9903)
892
83ed7b5c
GM
8932011-10-29 Glenn Morris <rgm@gnu.org>
894
895 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
896 Not clear what it was for, and it causes various bugs. (Bug#9839)
897
5a7a728b
EZ
8982011-10-28 Eli Zaretskii <eliz@gnu.org>
899
900 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
901 possible random value that matches one of those tested as
902 condition to clear the mouse face.
903
d3d0842f
CY
9042011-10-28 Chong Yidong <cyd@gnu.org>
905
906 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
907
31b39d13
DN
9082011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
909
910 * window.c (make_window): Initialize phys_cursor_on_p.
911
9aba6043
SM
9122011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
913
914 * lisp.h (struct Lisp_Symbol): Update comments.
915
c20992f4
JB
9162011-10-28 Juanma Barranquero <lekktu@gmail.com>
917
918 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
919
db4f02f2
EZ
9202011-10-28 Eli Zaretskii <eliz@gnu.org>
921
922 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
923 <oslsachem@gmail.com> for helping to debug this.
924
925 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
926 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
927 (g_b_init_get_glyph_outline_w): New static variables.
928 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
929 (GetGlyphOutlineW_Proc): New typedefs.
930 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
931 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
932 New functions.
933 (w32font_open_internal, compute_metrics):
934 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
935 instead of calling the "wide" APIs directly.
936
937 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
938
939 * w32.h (syms_of_w32font): Add prototype.
940
87e68db4
JB
9412011-10-27 Juanma Barranquero <lekktu@gmail.com>
942
943 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
944 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
945 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
946 (Fmove_to_window_line): Doc fix.
947
435c1d67
CY
9482011-10-27 Chong Yidong <cyd@gnu.org>
949
950 * process.c (make_process): Set gnutls_state to NULL.
951
952 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
953 non-NULL, regardless of GNUTLS_INITSTAGE.
954 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
955 an error. Set process slots as soon as we allocate them.
956
957 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
958
9c6c6f49
CY
9592011-10-27 Chong Yidong <cyd@gnu.org>
960
9aba6043
SM
961 * gnutls.c (emacs_gnutls_deinit): New function.
962 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
963 (Fgnutls_deinit, Fgnutls_boot): Use it.
964
965 * process.c (make_process): Initialize GnuTLS credentials to NULL.
966 (deactivate_process): Call emacs_gnutls_deinit.
967
657d08d3
JB
9682011-10-27 Juanma Barranquero <lekktu@gmail.com>
969
970 * image.c (x_create_x_image_and_pixmap):
971 * w32.c (sys_rename, w32_delayed_load):
972 * w32font.c (fill_in_logfont):
973 * w32reg.c (x_get_string_resource): Silence compiler warnings.
974
5430d399
JB
9752011-10-26 Juanma Barranquero <lekktu@gmail.com>
976
977 * w32fns.c (w32_default_color_map): New function,
978 extracted from Fw32_default_color_map.
a7ef684b 979 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 980
fe0055fa
PE
9812011-10-25 Paul Eggert <eggert@cs.ucla.edu>
982
983 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
984
e6346438
SM
9852011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
986
987 * keyboard.c (test_undefined): New function (bug#9751).
988 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
989
e112cc37
ET
9902011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
991
992 * sysdep.c (init_sys_modes): Fix the check for the controlling
993 terminal (Bug#6649).
994
7b5d6677
EZ
9952011-10-20 Eli Zaretskii <eliz@gnu.org>
996
997 * dispextern.h (struct bidi_it): New member next_en_type.
998
999 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1000 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1001 current character, check also for next_en_type being WEAK_EN.
1002 (bidi_resolve_weak): Don't enter the expensive loop if the current
1003 position is before next_en_pos. Record the bidi type of the first
1004 non-ET, non-BN character we find, in addition to its position.
1005 (bidi_level_of_next_char): Invalidate next_en_type when
1006 next_en_pos is over-stepped.
1007
7da0b018
PE
10082011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1011 * editfns.c: Rewrite current-time-zone so that it invokes
1012 the equivalent of (format-time-string "%Z") to get the time zone name.
1013 This fixes a bug when the time zone name contains characters that
1014 need converting from the system time locale to Emacs internal format.
1015 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1016 that patch fixed format-time-string to do the conversion, but
1017 I forgot to fix current-time-zone.
1018 (format_time_string): New function, containing most of
1019 what Fformat_time_string used to contain.
1020 (Fformat_time_string): Rewrite in terms of format_time_string.
1021 This doesn't change this function's behavior.
1022 (current-time-zone): Rewrite to use format_time_string.
1023 This fixes the bug reported by Michael Schierl in
1024 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1025 Jason Rumney's 2007-06-07 change worked around this bug, but
1026 didn't fix it.
1027 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1028
8547b010
EZ
10292011-10-19 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (start_display): If the character at POS is displayed
1032 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1033 (try_window_reusing_current_matrix): If a line ends in a display
1034 vector or the next line starts in a display vector, continue
1035 redrawing the window even though the character position of
1036 start_row was reached.
8547b010
EZ
1037 (Bug#9771, part 2)
1038
4e948d15
CY
10392011-10-18 Chong Yidong <cyd@gnu.org>
1040
1041 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1042 with nobreak-char-display too.
1043
4787455f
EZ
10442011-10-18 Eli Zaretskii <eliz@gnu.org>
1045
1046 Fix part 3 of bug#9771.
1047 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1048 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1049 non-neutral characters if the current character is a paragraph
1050 separator (a.k.a. Newline). This avoids running the same
1051 expensive loop twice, once when we consume the preceding newline
1052 and the other time when the line actually needs to be displayed.
1053 Avoid the loop when we see neutrals on the base embedding level
1054 following a character whose directionality is the same as the
1055 paragraph's. This avoids running the expensive loop when a line
1056 ends in a long sequence of neutrals, like control characters.
1057 Add assertion against STRONG_AL type. Slightly rearrange code
1058 that determines the type of a neutral given the first non-neutral
1059 that follows it.
1060 (bidi_level_of_next_char): Set next_en_pos to zero when
1061 invalidating its info.
1062
2c91f553
EZ
10632011-10-17 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (push_display_prop): Determine whether to record string
1066 or buffer position by IT->string, not by IT->method. Allow
1067 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1068 (move_it_vertically_backward): Don't look for character position
1069 immediately after the newline when in a continuation line.
1070 (Bug#9771, part 1)
2c91f553 1071
c7b08b0d
MR
10722011-10-15 Martin Rudalics <rudalics@gmx.at>
1073
1074 * window.c (coordinates_in_window): Rewrite and delabelize
1075 vertical border check. (Bug#5357) (Bug#9618)
1076
6b02f655
SM
10772011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1078
1079 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1080 errors in XSetWindowBorder (bug#9310).
1081
81d40c92
DA
10822011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1085 avoid crash when xmalloc overrun checking is enabled.
1086
d4172c3b
EZ
10872011-10-13 Eli Zaretskii <eliz@gnu.org>
1088
1089 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1090 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1091 cursor motion with <left> and <right> arrow keys.
1092
1093 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1094 some callers set that themselves.
1095
b00eea75
EZ
10962011-10-12 Eli Zaretskii <eliz@gnu.org>
1097
1098 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1099 display string and the previous row comes from the same string and
1100 is empty. (Bug#9739) (Bug#9738)
1101
8fe012c4
SM
11022011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1103
1104 * doc.c (get_doc_string): Encode file name (bug#9735).
1105
0074aef2
EZ
11062011-10-12 Eli Zaretskii <eliz@gnu.org>
1107
79beb178
EZ
1108 * bidi.c (bidi_level_of_next_char):
1109 * xdisp.c (get_visually_first_element): Remove old incorrect
1110 comments regarding the Unicode Line Separator character.
1111
0074aef2
EZ
1112 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1113
6e4b3fbe
DA
11142011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1115
1116 * alloc.c (Fgc_status): Do not access beyond zombies array
1117 boundary if nzombies > MAX_ZOMBIES.
1118 * alloc.c (dump_zombies): Add missing format specifier.
1119
0324f3af
PE
11202011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1121
b5525cac
PE
1122 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1123 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1124
0324f3af
PE
1125 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1126 Some packages use them to denote characters with modifiers.
1127
e9b5f888
AS
11282011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1129
1130 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1131 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1132 matching a pp-number. Rename parameter var to var1.
1133
127827c0
SM
11342011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1137
c8fd3bd0
GM
11382011-10-08 Glenn Morris <rgm@gnu.org>
1139
1140 * callint.c (Fcall_interactively): Give a more explicit error for the
1141 'c' case with a non-character input. (Bug#8479)
1142
352ec8ff
EZ
11432011-10-08 Eli Zaretskii <eliz@gnu.org>
1144
03669ccb
EZ
1145 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1146 lines.
7061c986
EZ
1147 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1148 lines that are hscrolled on the left.
03669ccb 1149
352ec8ff
EZ
1150 * dispnew.c (buffer_posn_from_coords): Account for a possible
1151 presence of header-line. (Bug#4426)
1152
a66cfb1c
SM
11532011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1154
6b02f655
SM
1155 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1156 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1157
7c5ee88e
PE
11582011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1159
1160 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1161 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1162 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1163 this makes Emacs dump core during garbage collection on rare
1164 occasions. sizeof is obviously inferior to offsetof here, so
1165 stick with offsetof.
1166 (GC_POINTER_ALIGNMENT): New macro.
1167 (mark_memory): Omit 3rd (offset) arg; caller changed.
1168 Don't assume EMACS_INT alignment is the same as pointer alignment.
1169
df1bbe5b
SM
11702011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1171
1172 * keyboard.c (read_key_sequence_remapped): New var.
1173 (read_key_sequence): Compute remapping in the right buffer.
1174 (command_loop_1): Use read_key_sequence's remapping directly.
1175
51553db6
SM
11762011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1177
32c1fffd
SM
1178 * dired.c (file_name_completion): Don't expand file name.
1179 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1180 before checking file name handler.
1181
51553db6
SM
1182 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1183 they've been requested explicitly (bug#9591).
1184
b6bd1599 11852011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1186
1187 * keymap.c (Fsingle_key_description): Use make_specified_string
1188 instead of build_string to build string from push_key_description.
1189 (Bug#5193)
1190
f701dc2a
PE
11912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1192
4222c55d
PE
1193 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1194 This fixes a Y2038 bug on 64-bit hosts.
1195 * buffer.c (reset_buffer):
1196 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1197 (Fclear_buffer_auto_save_failure):
1198 Use 0, not -1, to represent an unset failure time, since time_t
1199 might not be signed.
1200
f701dc2a
PE
1201 Remove dependency on glibc malloc internals.
1202 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1203 Move back here from lisp.h, but with their new implementations.
1204 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1205 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1206 * charset.c (charset_table_init): New static var.
1207 (syms_of_charset): Use it instead of xmalloc. This removes a
1208 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1209 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1210 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1211 Move back to alloc.c.
1212 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1213 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1214
9ceebf39
JD
12152011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1216
1217 * nsterm.m (windowDidResize): Call x_set_window_size only when
1218 ns_in_resize is true. Otherwise set pixelwidth/height and
1219 call change_frame_size (Bug#9628).
1220
cb993c58
PE
12212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1222
3930c88b
PE
1223 Port --enable-checking=all to Fedora 14 x86-64.
1224 * charset.c (syms_of_charset): Also account for glibc malloc's
1225 internal overhead when calculating the initial malloc maximum.
1226
cb993c58
PE
1227 Port --enable-checking=all to Fedora 14 x86.
1228 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1229 Move to lisp.h.
1230 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1231 (overrun_check_realloc, overrun_check_free):
1232 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1233 That way, xmalloc returns a properly-aligned pointer even if
1234 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1235 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1236 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1237 into account when calculating the initial malloc maximum.
1238 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1239 Move here from alloc.c, so that charset.c can use it too.
1240 Properly align; the old code wasn't right for common 32-bit hosts
1241 when configured with --enable-checking=all.
1242 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1243 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1244
31bed486
EZ
12452011-09-29 Eli Zaretskii <eliz@gnu.org>
1246
04c70788 1247 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1248 use EDOM.
1249
fbcaa2f3
EZ
12502011-09-28 Eli Zaretskii <eliz@gnu.org>
1251
1252 * xdisp.c (compute_display_string_end): If there's no display
1253 string at CHARPOS, return -1.
1254
1255 * bidi.c (bidi_fetch_char): When compute_display_string_end
1256 returns a negative value, treat the character as a normal
1257 character not covered by a display string. (Bug#9624)
1258
a239d4e9
JB
12592011-09-28 Juanma Barranquero <lekktu@gmail.com>
1260
1261 * lread.c (Fread_from_string): Fix typo in docstring.
1262
88652fd5
EZ
12632011-09-27 Eli Zaretskii <eliz@gnu.org>
1264
1265 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1266 newline, reseat the iterator instead of bidi-iterating there one
1267 character at a time. (Bug#9610)
32c1fffd
SM
1268 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1269 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1270
ed497dd4
AS
12712011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1272
1273 * lread.c (readevalloop): Use correct code for NBSP.
1274 (read1): Likewise. (Bug#9608)
1275
b2bf61aa
MA
12762011-09-25 Michael Albinus <michael.albinus@gmx.de>
1277
1278 * dbusbind.c (Fdbus_register_signal): When service is not
1279 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1280
32bbb17c
GM
12812011-09-25 Glenn Morris <rgm@gnu.org>
1282
1283 * buffer.c (truncate-lines): Doc fix.
1284
94e0933e
CY
12852011-09-24 Chong Yidong <cyd@stupidchicken.com>
1286
1287 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1288 (Fset_window_next_buffers): Doc fix.
1289
cddde921
GM
12902011-09-24 Glenn Morris <rgm@gnu.org>
1291
1292 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1293
1260aef1
PE
12942011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1295
25b4bfa0
PE
1296 Fix minor problems found by static checking.
1297 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1298 * indent.c (Fvertical_motion): Fix == vs = typo.
1299
e3cbd34b
EZ
13002011-09-24 Eli Zaretskii <eliz@gnu.org>
1301
a66cfb1c
SM
1302 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1303 Default value is now t. Doc fix.
6bf7006f 1304
e3cbd34b 1305 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1306 logic when moving up, not only when moving down. Fix the
e3cbd34b 1307 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1308 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1309
1310 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1311 CHARPOS is covered by a display string which includes newlines.
1312 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1313 is covered by a display string with embedded newlines.
1314
a3de0cbd
MA
13152011-09-24 Michael Albinus <michael.albinus@gmx.de>
1316
1317 * dbusbind.c (Fdbus_register_signal): Add match rule to
1318 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1319 (Fdbus_register_method, Vdbus_registered_objects_table):
1320 Fix docstring.
a3de0cbd 1321
b260039d
JM
13222011-09-24 Jim Meyering <meyering@redhat.com>
1323
32c1fffd 1324 do not ignore write error for any output size
b260039d
JM
1325 The previous change was incomplete.
1326 While it makes emacs --batch detect the vast majority of stdout
1327 write failures, errors were still ignored whenever the output size is
1328 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1329 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1330 && echo FAIL: ignored write error
1331 FAIL: ignored write error
1332 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1333 && echo FAIL: ignored write error
1334 FAIL: ignored write error
1335 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1336
8eca8a7c
AS
13372011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1338
1339 * emacs.c (Fkill_emacs): In noninteractive mode exit
1340 non-successfully if a write error occurred on stdout. (Bug#9574)
1341
3341db62
EZ
13422011-09-21 Eli Zaretskii <eliz@gnu.org>
1343
1344 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1345 the xassert test.
1346
1347 * dispextern.h (struct it): Update the comment documenting what
1348 can it->OBJECT be.
1349
8c203dbf
EZ
13502011-09-20 Eli Zaretskii <eliz@gnu.org>
1351
1352 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1353 a display string, extend search for cursor position to end of row.
1354 (find_row_edges): If the row ends in a newline from a display
1355 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1356 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1357 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1358 non-empty line. Fixes confusing cursor motion with arrow keys at
1359 the beginning of a line that starts with whitespace.
8c203dbf 1360
a4824228
LMI
13612011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1362
1363 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1364 (bug#9493).
1365
33ed493b
CY
13662011-09-18 Chong Yidong <cyd@stupidchicken.com>
1367
1368 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1369 boolean (Bug#9154).
1370
56cd55c8
EZ
13712011-09-18 Eli Zaretskii <eliz@gnu.org>
1372
1373 * xdisp.c (display_line): Record maximum and minimum buffer
1374 positions even if no glyphs were produced (e.g., by a zero-width
1375 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1376 buffer positions that will be removed from the glyph row because
1377 they don't fit.
c02dcedf
EZ
1378 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1379 column is beyond frame width: don't subtract 1 "pixel" when
1380 computing width of the stretch.
3e62b7e0
EZ
1381 (reseat_at_next_visible_line_start): Undo the change made on
1382 2011-09-17 that saved paragraph information and restored it after
1383 the call to `reseat'. (Bug#9545)
56cd55c8 1384
5ed99d36 13852011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1386
1387 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1388 and turn window cursor on if cleared (Bug#9415).
1389
5ed99d36 13902011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1391
1392 * search.c (boyer_moore): Take unibyte characters from pattern
1393 literally. (Bug#9458)
1394
9bade7b2
EZ
13952011-09-18 Eli Zaretskii <eliz@gnu.org>
1396
1397 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1398
e5e9d610
PE
13992011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1400
87e4427a
PE
1401 Fix minor problem found by static checking.
1402 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1403 initialized, to pacify gcc -Wuninitialized.
1404
e5e9d610
PE
1405 * fileio.c: Report proper errno when syscall falls.
1406 (Finsert_file_contents): Save and restore errno,
1407 so that report_file_error outputs the correct diagnostic.
1408 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1409
a1674f0b
EZ
14102011-09-18 Eli Zaretskii <eliz@gnu.org>
1411
1412 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1413
fbfb6dd4
EZ
14142011-09-17 Eli Zaretskii <eliz@gnu.org>
1415
1416 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1417 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1418
bb187662
EZ
14192011-09-17 Eli Zaretskii <eliz@gnu.org>
1420
1137e8b8 1421 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1422 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1423
1424 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1425 (bidi_find_paragraph_start): Search back for paragraph beginning
1426 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1427 (bidi_move_to_visually_next): Only trigger paragraph-related
1428 computations when the last character is a newline or at EOB, not
1429 just any NEUTRAL_B. (Bug#9470)
1430
bb187662
EZ
1431 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1432 truncated lines if point is covered by a display string. (Bug#9524)
1433
2e621251
PE
14342011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1437 (cons_to_x_long): New function.
1438 (lisp_data_to_selection_data): Use it. Correct the test for
1439 short-versus-long data; it was negated. Break out of vector
1440 loop, for efficiency, when a long datum is discovered.
1441
91a15bc6
SM
14422011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1443
1444 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1445
b41c3a35
EZ
14462011-09-16 Eli Zaretskii <eliz@gnu.org>
1447
1448 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1449 GCC PR/17406) by declaring this function with external scope.
1450
7812ba2d
PE
14512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1452
1453 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1454 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1455
cf7edc2a
AS
14562011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1457
1458 * editfns.c (Fformat): Correctly handle text properties on "%%".
1459
bd01620e
EZ
14602011-09-15 Eli Zaretskii <eliz@gnu.org>
1461
1462 * xterm.c (x_draw_composite_glyph_string_foreground):
1463 * w32term.c (x_draw_composite_glyph_string_foreground):
1464 * term.c (encode_terminal_code):
1465 * composite.c (composition_update_it, get_composition_id):
1466 * xdisp.c (get_next_display_element)
1467 (fill_composite_glyph_string): Add comments about special meaning
1468 of TAB characters in a composition.
1469
a02719a3
PE
14702011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1473 This occurs when processing a multibyte format.
1474 Problem reported by Wolfgang Jenker.
a02719a3 1475
72589a3c
JB
14762011-09-15 Johan Bockgård <bojohan@gnu.org>
1477
1478 * xdisp.c (try_cursor_movement): Only check for exact match if
1479 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1480
1c14176c
PE
14812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 Remove unused external symbols.
1484 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1485 * xdisp.c (calc_pixel_width_or_height): Now static.
1486 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1487 * indent.c (check_display_width):
1488 * w32term.c: Fix comment to match code.
1489 * xterm.c, xterm.h (x_catching_errors): Remove.
1490
d2eea5b5
PE
14912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 * xselect.c: Use signed conversions more consistently (Bug#9498).
1494 (selection_data_to_lisp_data): Assume incoming selection data are
1495 signed integers, not unsigned. This is to be consistent with
1496 outgoing selection data, which was modified to use signed integers
1497 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1498 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1499 expects long, not unsigned long.
1500
46888499
EZ
15012011-09-14 Eli Zaretskii <eliz@gnu.org>
1502
1503 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1504 computation of loop end. Reported by Johan Bockgård
1505 <bojohan@gnu.org>.
1506
ef8ef9fb
CY
15072011-09-13 Chong Yidong <cyd@stupidchicken.com>
1508
1509 * frame.c (Fother_visible_frames_p): Function deleted.
1510
fa819fed
EZ
15112011-09-12 Eli Zaretskii <eliz@gnu.org>
1512
1513 * indent.c (compute_motion): Process display vector front to back
1514 rather than the other way around. (Bug#2496)
1515
2ba8e008
SM
15162011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1517
1518 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1519
20f53c69
CY
15202011-09-11 Chong Yidong <cyd@stupidchicken.com>
1521
1522 * minibuf.c (Fread_from_minibuffer): Doc fix.
1523
d562d7a4
EZ
15242011-09-11 Eli Zaretskii <eliz@gnu.org>
1525
1526 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1527 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1528
1c4d7f3d
LMI
15292011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1530
1531 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1532 value for non-existent files.
1533
b885bf36
EZ
15342011-09-11 Eli Zaretskii <eliz@gnu.org>
1535
1536 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1537 set its "size" to -1. This will set the modtime_size field of
1538 the corresponding buffer to -1, which is what
1539 verify-visited-file-modtime expects for files that do not exist.
1540 (Bug#9139)
1541
6612f0bf
PE
15422011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1543
1544 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1545 here ...
1546 * lisp.h: ... from here. push_key_description is no longer
1547 defined in keyboard.c, so its declaration should not be in
1548 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1549 logically belongs with push_key_description.
1550
dfb3f755
PE
15512011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1552
1553 * buffer.h: Include <sys/types.h> instead of <time.h>.
1554 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1555 Problem reported by Herbert J. Skuhra.
1556
3134906c
LMI
15572011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1558
1559 * xml.c (parse_region): Make the parsing work for
1560 non-comment-starting XML files again (bug#9144).
1561
8d903f4e
AS
15622011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1563
1564 * image.c (gif_load): Fix calculation of bottom and right corner.
1565 (Bug#9468)
1566
80ad64f4
EZ
15672011-09-10 Eli Zaretskii <eliz@gnu.org>
1568
1569 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1570 redisplay in small windows.
1571
208a048d
EZ
15722011-09-09 Eli Zaretskii <eliz@gnu.org>
1573
1574 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1575
9b1c252e
MR
15762011-09-08 Martin Rudalics <rudalics@gmx.at>
1577
1578 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1579 Operate on live windows only.
1580
2949f33b
JB
15812011-09-08 Juanma Barranquero <lekktu@gmail.com>
1582
1583 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1584
e08dcafd
EZ
15852011-09-07 Eli Zaretskii <eliz@gnu.org>
1586
1587 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1588 only under bidi iteration.
1589
115b96bd
JD
15902011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1591
1592 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1593
c8199d0f
PE
15942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1597 Without this fix, the command to link temacs failed due to an
1598 undefined symbol __builtin_isnan. This is because
1599 /usr/include/iso/math_c99.h #defines isnan(x) to
1600 __builtin_isnan(x), but the bundled gcc, which identifies itself
1601 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1602 a __builtin_isnan.
1603 * floatfns.c (isnan): #undef, and then #define to a clone of
1604 what's in data.c.
1605 (Fisnan): Always define, since it's always available now.
1606 (syms_of_floatfns): Always define isnan at the Lisp level.
1607
e39b275c 16082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1609
1610 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1611
b2db44d9 16122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1613
f4af5137 1614 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1615 The previous code assumed that file offsets (off_t values) fit in
1616 EMACS_INT variables, which is not true on typical 32-bit hosts.
1617 The code messed up by falsely reporting buffer overflow in cases
1618 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1619 when "big" contains more than 2**29 bytes, even though this
1620 inserts just one byte and does not overflow the buffer.
1621 (Finsert_file_contents): Store file offsets as off_t
1622 values, not as EMACS_INT values. Check for overflow when
1623 converting between EMACS_INT and off_t. When checking for
1624 buffer overflow or for overlap, take the offsets into account.
1625 Don't use EMACS_INT for small values where int suffices.
1626 When checking for overlap, fix a typo: ZV was used where
1627 ZV_BYTE was intended.
1628 (Fwrite_region): Don't assume off_t fits into 'long'.
1629 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1630
ecfc0a49
MA
16312011-09-05 Michael Albinus <michael.albinus@gmx.de>
1632
1633 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1634
6511acf2 16352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1636
0999621a 1637 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1638
1639 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1640 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1641 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1642 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1643 (modify_event_symbol): Do not assume that the length of
1644 name_alist_or_stem is safe to alloca and fits in int.
1645 (Fexecute_extended_command): Likewise for function name and binding.
1646 (Frecursion_depth): Wrap around reliably on integer overflow.
1647 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1648 since some callers pass EMACS_INT values.
1649 (Fsingle_key_description): Don't crash if symbol name contains more
1650 than MAX_ALLOCA bytes.
1651 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1652 (get_minibuffer): Arg is now EMACS_INT, not int.
1653 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1654 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1655 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1656
2be7d702
PE
1657 * dbusbind.c (signature_cat): New function.
1658 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1659 Do not overrun buffer; instead, report string overflow.
1660
9d1df220
PE
1661 * dispnew.c (add_window_display_history): Don't overrun buffer.
1662 Truncate instead; this is OK since it's just a log.
1663
33ef5c64
PE
1664 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1665 even if the time zone offset is outlandishly large.
1666 Don't mishandle offset == INT_MIN.
1667
66c6fdd5
PE
1668 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1669 when creating daemon; the previous buffer-overflow check was incorrect.
1670
d749b01b
PE
1671 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1672 which has the guts of the old verror function.
1673
b5cd1905
PE
1674 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1675 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1676
6e1a67fb
PE
1677 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1678 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1679 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1680 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1681 length of string rather than counting it via multiple sprintfs;
1682 that's simpler and more reliable.
c21721cc
PE
1683 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1684 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1685 sprintf, in case result does not fit in int.
1686
c57b67fc
PE
1687 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1688 (fontset_from_font): Print it.
1689
8a401434
PE
1690 * frame.c (tty_frame_count): Now printmax_t, not int.
1691 (make_terminal_frame, set_term_frame_name): Print it.
1692 (x_report_frame_params): In X, window IDs are unsigned long,
1693 not signed long, so print them as unsigned.
1694 (validate_x_resource_name): Check for implausibly long names,
1695 and don't assume name length fits in 'int'.
1696 (x_get_resource_string): Don't blindly alloca invocation name;
1697 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1698 not fit in int.
1699
6e1a67fb
PE
1700 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1701 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1702 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1703
0df02bf3
PE
1704 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1705 Use esprintf, not sprintf, in case result does not fit in int.
1706
48e30793
PE
1707 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1708 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1709 it as a large positive number.
1710 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1711 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1712
a66ff6d8
PE
1713 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1714 in case result does not fit in int.
1715
aca216ff
PE
1716 * print.c (float_to_string): Detect width overflow more reliably.
1717 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1718 buffer overrun. Don't assume list length fits in 'int'. Treat
1719 print length of 0 as 0, not as infinity; to be consistent with other
1720 uses of print length in this function. Don't overflow print length
1721 index. Don't assume hash table size fits in 'long', or that
1722 vectorlike size fits in 'unsigned long'.
1723
31c286f7
PE
1724 * process.c (make_process): Use printmax_t, not int, to format
1725 process-name gensyms.
1726
55e5faa1
PE
1727 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1728
80f2e268
PE
1729 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1730 to avoid potential buffer overrun.
1731
670741ab
PE
1732 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1733 if X resource line is longer than 512 bytes.
1734
b7163a50
PE
1735 * xfns.c (x_window): Make sprintf buffer a bit bigger
1736 to avoid potential buffer overrun.
1737
ae58ff1f
PE
1738 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1739
c43c8a6a
PE
1740 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1741
3f8236f4
PE
17422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1743
53e9fe90 1744 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1745 Without these, Emacs silently mishandles large integers sometimes.
1746 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1747 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1748
6511acf2
PE
1749 * xdisp.c (try_window_id): Check Emacs fixnum range before
1750 converting to 'int'.
806add1d 1751
6511acf2 1752 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1753 Check that an Emacs fixnum is in range before assigning it to 'int'.
1754 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1755 values converted from Emacs fixnums.
1756 (Frecenter): Don't wrap around a line count if it is out of 'int'
1757 range; instead, treat it as an extreme value.
1758 (Fset_window_configuration, compare_window_configurations):
1759 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1760
6511acf2
PE
1761 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1762 that can exceed INT_MAX. Check that EMACS_INT value is in range
1763 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1764 (match_limit): Don't assume that a fixnum can fit in 'int'.
1765
6511acf2 1766 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1767 exceed INT_MAX.
1768
6511acf2 1769 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1770 (Fvertical_motion): Don't wrap around LINES values that don't fit
1771 in 'int'. Instead, treat them as extreme values. This is good
1772 enough for windows, which can't have more than INT_MAX lines anyway.
1773
fcb901a7
LMI
17742011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1775
0f2f6b6d
LMI
1776 * Require libxml/parser.h to avoid compilation warning.
1777
fcb901a7
LMI
1778 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1779
1780 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1781 since this reportedly can destroy thread storage.
1782
6e20a0d4
CY
17832011-08-30 Chong Yidong <cyd@stupidchicken.com>
1784
1785 * syntax.c (find_defun_start): Update all cache variables if
1786 exiting early (Bug#9401).
1787
148ae00e
EZ
17882011-08-30 Eli Zaretskii <eliz@gnu.org>
1789
f6cfbd8f
EZ
1790 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1791
148ae00e
EZ
1792 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1793 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1794 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1795
1796 * term.c (tty_append_glyph): New function.
1797 (produce_stretch_glyph): Static function and its prototype deleted.
1798
a66cfb1c
SM
1799 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1800 Add prototypes.
148ae00e 1801
c4a07a4c
PE
18022011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1805 when checking :margin (Bug#9390).
1806 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1807 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1808 so that the name doesn't mislead. All uses changed.
1809
6bc8cd65
JB
18102011-08-28 Johan Bockgård <bojohan@gnu.org>
1811
1812 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1813 set_tty_hooks.
1814
dca4927e
EZ
18152011-08-27 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (move_it_to): Don't bail out early when reaching
1818 position beyond to_charpos, if we are scanning backwards.
1819 (move_it_vertically_backward): When DY == 0, make sure we get to
1820 the first character in the line after the newline.
1821
f2cad773
PE
18222011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1823
1824 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1825 (ccl_driver): Do not generate an out-of-range pointer.
1826 (Fccl_execute_on_string): Remove unnecessary check for
1827 integer overflow, noted by Stefan Monnier in
1828 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1829 Remove a FIXME that didn't need fixing.
1830 Simplify the newly-introduced buffer reallocation code.
1831
0cae2cdb
JB
18322011-08-27 Juanma Barranquero <lekktu@gmail.com>
1833
1834 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1835
5fc295a4 18362011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1837
70c60eb2 1838 Integer and memory overflow issues (Bug#9196).
726e0ab1 1839
d31850da
PE
1840 * doc.c (get_doc_string): Rework so that
1841 get_doc_string_buffer_size is the actual buffer size, rather than
1842 being 1 less than the actual buffer size; this makes xpalloc more
1843 convenient.
1844
a69fbedb
PE
1845 * image.c (x_allocate_bitmap_record, cache_image):
1846 * xselect.c (Fx_register_dnd_atom):
1847 Simplify previous changes by using xpalloc.
1848
fe5c5d37
PE
1849 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1850 since either will do and ptrdiff_t is convenient with xpalloc.
1851
0065d054
PE
1852 * charset.c (charset_table_size)
1853 (struct charset_sort_data.priority): Now ptrdiff_t.
1854 (charset_compare): Don't overflow if priorities differ greatly.
1855 (Fsort_charsets): Don't assume list length fits in int.
1856 Check for size-calculation overflow when allocating sort data.
1857 (syms_of_charset): Allocate an initial charset table that is
1858 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1859
1860 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1861
1862 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1863 The actual value is always <= INT_MAX, and leaving it unsigned made
1864 overflow checking harder.
1865
1866 * dispextern.h (struct glyph_matrix.rows_allocated)
1867 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1868 with xpalloc. The values are still always <= INT_MAX.
1869
1870 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1871
1872 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1873 (SAFE_NALLOCA): New macro.
1874
1875 * region-cache.c (struct boundary.pos, find_cache_boundary)
1876 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1877 (set_cache_region, invalidate_region_cache)
1878 (revalidate_region_cache, know_region_cache, region_cache_forward)
1879 (region_cache_backward, pp_cache):
1880 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1881 so that ptrdiff_t * can be passed to xpalloc.
1882 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1883 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1884 (pp_cache): Don't assume cache_len fits in int.
1885 * region-cache.h: Adjust extern decls to match.
1886
1887 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1888 EMACS_INT, since either will do, for xpalloc.
1889
1890 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1891 (xnmalloc, xnrealloc, xpalloc): New functions.
1892
726e0ab1
PE
1893 * bidi.c (bidi_shelve_header_size): New constant.
1894 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1895 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1896
51f30bc5 1897 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1898 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1899 (overlay_strings):
1900 Don't update size of array until after memory allocation succeeds,
1901 because xmalloc/xrealloc may not return.
0065d054
PE
1902 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1903 now that we have proper integer overflow checking.
1904 (record_overlay_string, overlay_strings): Catch overflows when
1905 calculating size of overlay_str_buf.
726e0ab1 1906
0065d054
PE
1907 * callproc.c (Fcall_process): Check for size overflow when
1908 calculating size of args2.
1909 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1910 Normally we prefer signed values, but sticking with ptrdiff_t would
1911 require adding more-complicated checks.
726e0ab1
PE
1912
1913 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1914 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1915 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1916 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1917
1918 * character.c (Fstring): Check for size-calculation overflow.
1919
1920 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1921 unnecessary integer overflow. Check for size overflow.
1922 (encode_coding_object): Don't update size until xmalloc succeeds.
1923
1924 * composite.c (get_composition_id): Check for overflow in glyph
1925 length calculations.
1926
1927 Integer and memory overflow fixes for display code.
1928 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1929 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1930 (scrolling_window): Check for overflow in size calculations.
1931 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1932 Don't assume glyph table len fits in int.
1933 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1934 (row_table_size): Now ptrdiff_t, not int.
1935 (scrolling_window): Avoid overflow in size calculations.
1936 Don't update size until allocation succeeds.
1937 * fns.c (concat): Check for overflow in size calculations.
1938 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1939 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1940 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1941
1942 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1943 (get_doc_string): Check for size calculation overflow.
1944 Don't update size until allocation succeeds.
1945 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1946 EMACS_INT, where ptrdiff_t will do.
1947 (Fsubstitute_command_keys): Check for string overflow.
1948
1949 * editfns.c (set_time_zone_rule): Don't assume environment length
1950 fits in int.
1951 (message_length): Now ptrdiff_t, not int.
1952 (Fmessage_box): Don't update size until allocation succeeds.
1953 Don't assume message length fits in int.
1954 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1955
0065d054
PE
1956 * emacs.c (main): Do not reallocate argv, since there is a null at
1957 the end that can be overwritten, and this way there's no need to
1958 worry about size-calculation overflow.
1959 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1960
1961 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1962 alloc succeeds.
1963 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1964
1965 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1966 (x_set_scroll_bar_width, x_figure_window_size):
1967 Check for integer overflow.
1968 (x_set_alpha): Do not assume XINT fits in int.
1969
1970 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1971 This is for the members text_lines, text_cols, total_lines, total_cols,
1972 where the system imposes an 'int' limit.
1973
1974 * fringe.c (Fdefine_fringe_bitmap):
1975 Don't update size until alloc works.
1976
1977 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1978 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1979
1980 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1981 Check for size-calculation overflow.
1982 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1983 do, as we prefer signed integers.
1984 (id_to_widget.max_size, id_to_widget.used)
1985 (xg_store_widget_in_map, xg_remove_widget_from_map)
1986 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1987 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1988 Use and return ptrdiff_t, not int.
1989 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1990 * gtkutil.h: Change prototypes to match the above.
1991
1992 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1993 are duplicate now that they've been promoted to lisp.h.
1994 (x_allocate_bitmap_record, x_alloc_image_color)
1995 (make_image_cache, cache_image, xpm_load):
1996 Don't update size until alloc is done.
1997 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1998 (x_detect_edges):
3256efce 1999 Check for size calculation overflow.
726e0ab1
PE
2000 (ct_colors_allocated_max): New constant.
2001 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2002 overflow.
3256efce 2003
726e0ab1
PE
2004 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2005 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2006 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2007 Use ptrdiff_t, not int, to count maps.
2008 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2009 calculations. Don't update size until allocation succeeds.
2010 Redo calculations to avoid overflow.
726e0ab1
PE
2011 * keyboard.h: Change prototypes to match the above.
2012
2013 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2014 to count maps.
2015 (current_minor_maps): Check for size calculation overflow.
2016 * keymap.h: Change prototypes to match the above.
2017
2018 * lread.c (read1, init_obarray): Don't update size until alloc done.
2019
2020 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2021 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2022
726e0ab1
PE
2023 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2024 Now ptrdiff_t, not int.
2025 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2026 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2027
2028 * process.c (Fnetwork_interface_list): Check for overflow
2029 in size calculation.
2030
2031 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2032
2033 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2034 overflow. Don't bother calling xmalloc when xrealloc will do.
2035
2036 * search.c (Freplace_match): Check for size calculation overflow.
2037 (Fset_match_data): Don't assume list lengths fit in 'int'.
2038
2039 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2040 for command line length. Do not attempt to address one before the
2041 beginning of an array, as that's not portable.
2042
2043 * term.c (max_frame_lines): Remove; unused.
2044 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2045 not int.
2046 (encode_terminal_code, calculate_costs): Check for size
2047 calculation overflow.
2048 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2049 table lengths and related sizes. Don't update size until alloc
2050 done. Redo calculations to avoid overflow.
2051 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2052
2053 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2054 subtracting pointers.
2055 (gobble_line): Check for overflow more carefully. Don't update size
2056 until alloc done.
2057
2058 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2059 Don't update size until alloc done.
2060 Redo size calculations to avoid overflow.
2061 Check for size calculation overflow.
0065d054 2062 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2063
2064 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2065 Use ptrdiff_t, not int, for sizes.
2066 (store_mode_line_noprop_char): Don't update size until alloc done.
2067
0065d054
PE
2068 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2069 Use ptrdiff_t, not int, for sizes.
2070 (Finternal_make_lisp_face, cache_face):
2071 Check for size calculation overflow.
2072 (cache_face): Treat size calculation overflows as if they were
2073 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2074
2075 * xfns.c (x_encode_text, x_set_name_internal)
2076 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2077 sizes, since they can exceed INT_MAX in size. Check for size
2078 calculation overflow.
2079
0065d054
PE
2080 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2081 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2082 Don't update size until alloc done.
2083
0065d054 2084 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2085 as sprintf is limited to int lengths.
1d526e2f 2086
252c5ee1
PE
2087 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2088 (X_LONG_MIN): New macros.
864d7ce7
PE
2089 Use them to make the following changes clearer.
2090 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2091 This change doesn't affect the value now, but it may help remind
2092 future maintainers not to raise the value too much later.
2093 (SELECTION_QUANTUM): Remove, replacing with ...
2094 (selection_quantum): ... new function, which avoids overflow.
2095 All uses changed.
2096 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2097 assumption that selection length fits in 'int'.
2098 (x_reply_selection_request, x_handle_selection_request)
2099 (x_get_window_property, receive_incremental_selection)
2100 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2101 (lisp_data_to_selection_data, clean_local_selection_data):
2102 Use ptrdiff_t, not int, to record length of selection.
2103 (x_reply_selection_request, x_get_window_property)
2104 (receive_incremental_selection, x_property_data_to_lisp):
2105 Redo calculations to avoid overflow.
2106 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2107 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2108 something.
2109 (x_get_window_property, receive_incremental_selection)
2110 (lisp_data_to_selection_data, x_property_data_to_lisp):
2111 Check for size-calculation overflow.
2112 (x_get_window_property, receive_incremental_selection)
2113 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2114 Don't store size until memory allocation succeeds.
2115 (x_get_window_property): Plug memory leak on memory exhaustion.
2116 Don't double-block input; malloc is safe here. Don't assume 2**34
2117 - 4 fits in unsigned long. Add an xassert to check
2118 XGetWindowProperty overflow. Be more careful about overflow
2119 calculations, and distinguish size from memory overflow better.
2120 (receive_incremental_selection): When tracing, don't assume
2121 unsigned int is less than INT_MAX.
2122 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2123 harmful) conversions of unsigned short to int.
2124 (lisp_data_to_selection_data): Don't assume that integers
2125 in the range -65535 through -1 fit in an X unsigned short.
2126 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2127 result parameters unless successful. Rely on cons_to_unsigned
2128 to report problems with elements; the old code wasn't right anyway.
2129 (x_check_property_data): Check for int overflow; we cannot use
2130 a wider type due to X limits.
2131 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2132
726e0ab1 2133 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2134
0065d054
PE
2135 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2136 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2137 (x_color_cells): Don't store size until memory allocation succeeds.
2138 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2139 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2140 (x_term_init): Don't assume length fits in int (sprintf is limited
2141 to int size).
bc18e09d 2142
ebfa62c0
PE
2143 Use ptrdiff_t for composition IDs.
2144 * character.c (lisp_string_width):
2145 * composite.c (composition_table_size, n_compositions)
2146 (get_composition_id, composition_gstring_from_id):
2147 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2148 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2149 * window.c (Frecenter):
2150 Use ptrdiff_t, not int, for composition IDs.
2151 * composite.c (get_composition_id): Check for integer overflow.
2152 * composite.h: Adjust prototypes to match the above changes.
2153
d3411f89
PE
2154 Use ptrdiff_t for hash table indexes.
2155 * category.c (hash_get_category_set):
2156 * ccl.c (ccl_driver):
2157 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2158 * coding.c (coding_system_charset_list, detect_coding_system):
2159 * coding.h (struct coding_system.id):
2160 * composite.c (get_composition_id, gstring_lookup_cache):
2161 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2162 * image.c (xpm_get_color_table_h):
2163 * lisp.h (hash_lookup, hash_put):
2164 * minibuf.c (Ftest_completion):
2165 Use ptrdiff_t for hash table indexes, not int (which is too
2166 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2167 32-bit --with-wide-int hosts).
2168
e097a6fa
PE
2169 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2170 Add a FIXME comment about memory leaks.
2171 (syms_of_charset): Don't assume xmalloc returns.
2172
5637687f
PE
2173 Don't assume that stated character widths fit in int.
2174 * character.c (Fchar_width, c_string_width, lisp_string_width):
2175 * character.h (CHAR_WIDTH):
2176 * indent.c (MULTIBYTE_BYTES_WIDTH):
2177 Use sanitize_char_width to avoid undefined and/or bad behavior
2178 with outlandish widths.
a66cfb1c 2179 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2180 now that we have two such functions. All uses changed.
2181 (sanitize_char_width): New inline function.
2182
a2271ba2
PE
2183 Don't assume that tab-width fits in int.
2184 * character.h (sanitize_width): New inline function.
2185 (SANE_TAB_WIDTH): New macro.
2186 (ASCII_CHAR_WIDTH): Use it.
2187 * indent.c (sane_tab_width): Remove. All uses replaced by
2188 SANE_TAB_WIDTH (current_buffer).
2189 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2190
18c52557
PE
2191 * fileio.c: Integer overflow issues with file modes.
2192 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2193
caeeedc1
PE
2194 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2195 Remove unreachable code.
2196 (read_hex, load_charset_map_from_file): Check for integer overflow.
2197
50849c52
PE
2198 * xterm.c: don't go over XClientMessageEvent limit
2199 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2200 (x_send_scroll_bar_event): Likewise. Check that the size does not
2201 exceed limits imposed by XClientMessageEvent, as well as the usual
2202 ptrdiff_t and size_t limits.
2203
b13995db
PE
2204 * keyboard.c: Overflow, signedness and related fixes.
2205 (make_lispy_movement): Use same integer type in forward decl
2206 that is used in the definition.
2207 (read_key_sequence, keyremap_step):
2208 Change bufsize argument back to int, undoing my 2011-03-30 change.
2209 We prefer signed types, and int is wide enough here.
2210 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2211 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2212 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2213 length, not size_t. Use ptrdiff_t for index, not int.
2214 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2215 possibility of integer overflow.
2216
13464394
PE
2217 Overflow, signedness and related fixes for images.
2218
2219 * dispextern.h (struct it.stack[0].u.image.image_id)
2220 (struct_it.image_id, struct image.id, struct image_cache.size)
2221 (struct image_cache.used, struct image_cache.ref_count):
2222 * gtkutil.c (update_frame_tool_bar):
2223 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2224 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2225 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2226 * nsmenu.m (update_frame_tool_bar):
2227 * xdisp.c (calc_pixel_width_or_height):
2228 * xfns.c (image_cache_refcount):
2229 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2230 on typical 64-bit hosts.
2231
2232 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2233 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2234 Omit unnecessary casts to int.
2235 (parse_image_spec): Check that integers fall into 'int' range
2236 when the callers expect that.
2237 (image_ascent): Redo ascent calculation to avoid int overflow.
2238 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2239 (lookup_image): Remove unnecessary tests.
2240 (xbm_image_p): Locals are now of int, not EMACS_INT,
2241 since parse_image_check makes sure they fit into int.
2242 (png_load, gif_load, svg_load_image):
2243 Prefer int to unsigned where either will do.
2244 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2245 old tiff_error_handler and tiff_warning_handler.
2246 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2247 stack buffer overflows. It uses only the features of vsnprintf
2248 that are common to both POSIX and native Microsoft.
2249 (tiff_error_handler, tiff_warning_handler): Use it.
2250 (tiff_load, gif_load, imagemagick_load_image):
2251 Don't assume :index value fits in 'int'.
2252 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2253 (imagemagick_load_image): Check that crop parameters fit into
2254 the integer types that MagickCropImage accepts. Don't assume
2255 Vimagemagick_render_type has a nonnegative value. Don't assume
2256 size_t fits in 'long'.
2257 (gs_load): Use printmax_t to print the widest integers possible.
2258 Check for integer overflow when computing image height and width.
2259
c11821d4
EZ
22602011-08-26 Eli Zaretskii <eliz@gnu.org>
2261
2262 * xdisp.c (redisplay_window): Don't force window start if point
2263 will be invisible in the resulting window. (Bug#9324)
2264
0c95fcf7
EZ
22652011-08-25 Eli Zaretskii <eliz@gnu.org>
2266
2267 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2268 the display spec is of the form `(space ...)'.
2269 (handle_display_spec): Return the value returned by
2270 handle_single_display_spec, not just 1 or zero.
2271 (handle_single_display_spec): If the display spec is of the form
2272 `(space ...)', and specifies display in the text area, return 2
2273 rather than 1.
fee65a97 2274 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2275 accurately, and prefer exact match for point under bidi.
2276 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2277
2278 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2279 into disp_prop; all users changed.
2280
2281 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2282 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2283 for the text covered by the display property.
2284
e4ed06f1
CY
22852011-08-25 Chong Yidong <cyd@stupidchicken.com>
2286
2287 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2288 Change return value to nil.
2289 (Frecord_buffer): Delete unused function.
2290
f67cdd7f
EZ
22912011-08-24 Eli Zaretskii <eliz@gnu.org>
2292
5980d4c6
EZ
2293 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2294 buffers, return left-to-right.
8610fe8b
EZ
2295 (set_cursor_from_row): Consider candidate row a win if its glyph
2296 represents a newline and point is on that newline. Fixes cursor
2297 positioning on the newline at EOL of R2L text within L2R
2298 paragraph, and vice versa.
2299 (try_cursor_movement): Check continued rows, in addition to
2300 continuation rows. Fixes unwarranted scroll when point enters a
2301 continued line of R2L text within an L2R paragraph, or vice versa.
2302 (cursor_row_p): Consider the case of point being equal to
2303 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2304 from the end of a short line to the beginning of a continued line
2305 of R2L text within L2R paragraph.
2306 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2307 composed characters.
5980d4c6 2308
f67cdd7f
EZ
2309 * bidi.c (bidi_check_type): Use xassert.
2310 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2311 members.
2312
bca633fb
EZ
23132011-08-23 Eli Zaretskii <eliz@gnu.org>
2314
2315 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2316 a character.
2317
4a5885a7
CY
23182011-08-23 Chong Yidong <cyd@stupidchicken.com>
2319
2320 * nsfont.m (ns_otf_to_script): Fix typo.
2321
0902a04e
KH
23222011-08-22 Kenichi Handa <handa@m17n.org>
2323
2324 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2325 extra slot even if the purpose is char-code-property-table.
2326
1a2e6670
EZ
23272011-08-23 Eli Zaretskii <eliz@gnu.org>
2328
8ddde651
EZ
2329 * xdisp.c (redisplay_window): When computing centering_position,
2330 account for the height of the header line. (Bug#8874)
2331
425cc014
EZ
2332 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2333 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2334 candidate is selected by the mouse, and that candidate has a
2335 composed character under the mouse.
2336
1a2e6670
EZ
2337 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2338 coordinates reported by pos-visible-in-window-p for a composed
2339 character in column zero.
2340
8b76d6f8
SM
23412011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2342
2343 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2344
dac347dd
EZ
23452011-08-22 Eli Zaretskii <eliz@gnu.org>
2346
2347 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2348 consider it a hit if to_charpos is anywhere in the range of the
2349 composed buffer positions.
2350
e013fb34
CY
23512011-08-22 Chong Yidong <cyd@stupidchicken.com>
2352
2353 * image.c (gif_load): Don't assume that each subimage has the same
2354 dimensions as the base image. Handle disposal method that is
2355 "undefined" by the gif spec (Bug#9335).
2356
bd1ba3e8
CY
23572011-08-20 Chong Yidong <cyd@stupidchicken.com>
2358
2359 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2360 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2361
54a1215b
EZ
23622011-08-19 Eli Zaretskii <eliz@gnu.org>
2363
823564e5
EZ
2364 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2365 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2366 from an Org mode buffer to a Speedbar frame.
2367
54a1215b
EZ
2368 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2369 a composition, take its buffer position from IT->cmp_it.charpos.
2370 Fixes cursor positioning at the beginning of a line that begins
2371 with a composed character.
2372
9778ebcc
EZ
23732011-08-18 Eli Zaretskii <eliz@gnu.org>
2374
0be6ee06
EZ
2375 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2376 character bidirectional type, use STRONG_L instead. Fixes crashes
2377 in a buffer produced by `describe-categories'.
2378
9778ebcc
EZ
2379 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2380 members before the level stack, so they would be saved and
2381 restored when copying iterator state. Fixes incorrect reordering
2382 around TABs covered by display properties.
2383
156bffbe
AS
23842011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2385
6b02f655 2386 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2387
72ad093b
CY
23882011-08-17 Chong Yidong <cyd@stupidchicken.com>
2389
2390 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2391 (internal_condition_case_2, internal_condition_case_n):
2392 Remove unnecessary aborts (Bug#9081).
72ad093b 2393
35774242
EZ
23942011-08-17 Eli Zaretskii <eliz@gnu.org>
2395
2396 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2397 has no `load' handler, try opening the file locally. (Bug#9311)
2398
db76dd85
KB
23992011-08-16 Ken Brown <kbrown@cornell.edu>
2400
2401 * gmalloc.c: Expand comment.
2402
b215eee5
EZ
24032011-08-16 Eli Zaretskii <eliz@gnu.org>
2404
2405 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2406 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2407
a4579d33
KB
24082011-08-16 Ken Brown <kbrown@cornell.edu>
2409
2410 Fix memory allocation problems in Cygwin build (Bug#9273).
2411
2412 * unexcw.c ( __malloc_initialized): Declare external variable.
2413 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2414
8b76d6f8
SM
2415 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2416 New variables.
a4579d33
KB
2417 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2418 dumped emacs.
2419 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2420 in the static heap.
2421 [CYGWIN] (special_realloc): New function.
2422 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2423 requests to realloc storage in the static heap.
2424
3ebec551
PE
24252011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 * bidi.c (bidi_initialize): Remove unused local.
2428
9fd8be00
EZ
24292011-08-15 Eli Zaretskii <eliz@gnu.org>
2430
6b02f655
SM
2431 * bidimirror.h:
2432 * biditype.h: Remove file.
2433 * makefile.w32-in ($(BLD)/bidi.$(O)):
2434 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2435
2436 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2437
2438 * chartab.c: Improve commentary for the uniprop_table API.
2439
32413314
EZ
2440 * bidi.c (bidi_paragraph_init): Support zero value of
2441 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2442 (bidi_initialize): Use uniprop_table instead of including
2443 biditype.h and bidimirror.h.
32413314 2444
9fd8be00
EZ
2445 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2446 coordinates of the iterator when restoring from ppos_it.
2447 (Bug#9296)
2448
5cf2b69b
KH
24492011-08-14 Kenichi Handa <handa@m17n.org>
2450
2451 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2452 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2453
daf17d00
EZ
24542011-08-14 Eli Zaretskii <eliz@gnu.org>
2455
2456 * xdisp.c (move_it_in_display_line_to): Don't invoke
2457 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2458 ppos_it. Fixes vertical cursor motion when line beginning is
2459 covered by an image. (Bug#9296)
2460
08e3161a
JD
24612011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2462
2463 * nsterm.h (ns_run_ascript): Declare.
2464 (NSAPP_DATA2_RUNASSCRIPT): Define.
2465
2466 * nsfns.m (as_script, as_result, as_status): New static variables.
2467 (ns_run_ascript): New function.
5e617bc2 2468 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2469 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2470 the event loop. Get status from as_status (Bug#7276).
2471
2472 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2473 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2474 the event loop (Bug#7276).
2475
a3720aa2
AS
24762011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2477
2478 * gnutls.c (QCgnutls_bootprop_priority)
2479 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2480 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2481 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2482 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2483 (QCgnutls_bootprop_verify_hostname_error)
2484 (QCgnutls_bootprop_callbacks_verify): Rename from
2485 Qgnutls_bootprop_..., all uses changed.
2486
2487 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2488 uses changed.
2489
0a0d27fb
PE
24902011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2491
19d5c50c
PE
2492 * xfaces.c (Qframe_set_background_mode): Now static.
2493 * dispextern.h (Qframe_set_background_mode): Remove decl.
2494
0a0d27fb
PE
2495 * process.c (Fnetwork_interface_info): Declare local only if needed.
2496
377538cb
JD
24972011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2498
2499 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2500 (Fnetwork_interface_list): Allocate in increments of bytes instead
2501 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2502 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2503 sockaddr.
2504 (struct ifflag_def): notrailers is smart on OSX.
2505 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2506 Get hardware address with getifaddrs if available.
2507
08fff70c
EZ
25082011-08-12 Eli Zaretskii <eliz@gnu.org>
2509
2510 * xdisp.c (iterate_out_of_display_property): xassert that
2511 IT->position is set to within IT->object's boundaries. Break from
2512 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2513 when IT->position is set up wrongly due to some bug.
2514 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2515 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2516 entry. Force push_it to save on the stack the current
2517 buffer/string position, to be restored by pop_it. Fix flags in
2518 the iterator structure wrt the object coming from a display
2519 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2520 properties. (Bug#9284)
2521
7be1c708 25222011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2523
7be1c708
CY
2524 * fontset.c (fontset_get_font_group): Add proper type checks.
2525 (Bug#9172)
aac0c6e3 2526
7be1c708 25272011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2528
7be1c708
CY
2529 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2530 and LC_VERSION_MIN_MACOSX.
2531 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2532 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2533
97bb72a6
EZ
25342011-08-08 Eli Zaretskii <eliz@gnu.org>
2535
2536 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2537 no-display-properties-and-no-overlays under bidi display.
2538 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2539 properties and overlays.
97bb72a6 2540
d5617611
CY
25412011-08-08 Chong Yidong <cyd@stupidchicken.com>
2542
37e11a63
CY
2543 * editfns.c (Fset_time_zone_rule): Document relationship with the
2544 setenv function.
2545
d5617611
CY
2546 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2547 the font entity extracted from the cache (Bug#8109).
2548
58872834
CY
25492011-08-07 Chong Yidong <cyd@stupidchicken.com>
2550
2551 * composite.c (autocmp_chars): Don't reset point. That is done by
2552 restore_point_unwind (Bug#5984).
2553
75bfc667
JL
25542011-08-07 Juri Linkov <juri@jurta.org>
2555
2556 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2557 to show the arg `TIME' instead of `TIMEVAL'.
2558
d1410150
EZ
25592011-08-06 Eli Zaretskii <eliz@gnu.org>
2560
2561 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2562 display property strides EOL and includes a newline, as in
2563 longlines-mode. (Bug#9254)
75b771e4
EZ
2564 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2565 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2566
2567 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2568 is non-zero, even if the data buffer is NULL. Fixes a crash in
2569 vertical-motion with longlines-mode. (Bug#9254)
2570
35928349
EZ
25712011-08-05 Eli Zaretskii <eliz@gnu.org>
2572
ec7cc85b
EZ
2573 * bidi.c <bidi_cache_total_alloc>: Now static.
2574 (bidi_initialize): Initialize bidi_cache_total_alloc.
2575
8b76d6f8 2576 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2577 cache. (Bug#9221)
2578
2579 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2580 amount allocated this far in `bidi_cache_total_alloc'.
2581 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2582 non-zero, only free the data buffer without restoring the cache
2583 contents. All callers changed.
2584
2585 * dispextern.h (bidi_unshelve_cache): Update prototype.
2586
2587 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2588 (move_it_in_display_line, move_it_to)
2589 (move_it_vertically_backward, move_it_by_lines): Replace the call
2590 to xfree to an equivalent call to bidi_unshelve_cache.
2591 (move_it_in_display_line_to): Fix logic of returning
412b6358 2592 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2593
e2e2423b
EZ
25942011-08-05 Eli Zaretskii <eliz@gnu.org>
2595
2596 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2597 came from a string character with a `cursor' property. (Bug#9229)
2598
ae9e757a
JD
25992011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2600
2601 * Makefile.in (LIB_PTHREAD): New variable.
2602 (LIBES): Add LIB_PTHREAD (Bug#9216).
2603
2604 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2605 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2606
213bd7f2
AS
26072011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2608
6b02f655 2609 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2610
99aaf75f
JD
26112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2612
2613 * xterm.c (x_find_topmost_parent): New function.
2614 (x_set_frame_alpha): Find topmost parent window with
2615 x_find_topmost_parent and set the property there also (bug#9181).
2616 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2617
c74e9d86
PE
26182011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2619
2620 * callproc.c (Fcall_process): Avoid vfork clobbering
2621 the local vars buffer, coding_systems, current_dir.
2622
640c8776
SM
26232011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2624
2625 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2626
f26d0e4c
PE
26272011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2628
8a10d76c
PE
2629 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2630 so that it is not optimized away.
2631
f26d0e4c
PE
2632 * xdisp.c (compute_display_string_pos): Remove unused local.
2633
55439c61
EZ
26342011-08-02 Eli Zaretskii <eliz@gnu.org>
2635
2636 Fix slow cursor motion and scrolling in large buffers with
2637 selective display, like Org Mode buffers. (Bug#9218)
2638
2639 * dispextern.h (struct bidi_it): New member disp_prop_p.
2640
2641 * xdisp.c: Remove one-slot cache of display string positions.
2642 (compute_display_string_pos): Accept an additional argument
5e617bc2 2643 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2644 for a display string or property. If found, set DISP_PROP_P
2645 non-zero.
2646
2647 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2648 DISP_PROP_P, and pass it to compute_display_string_pos.
2649 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2650 non-zero. All callers of bidi_fetch_char changed.
2651
fb33fa43
SM
26522011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2653
2654 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2655
b099e063
DM
26562010-12-03 Don March <don@ohspite.net>
2657
2658 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2659 last character M-[char] is translated to ESC [char] (bug#7541).
2660
5cc7f7af
KH
26612011-08-02 Kenichi Handa <handa@m17n.org>
2662
d0fffa3f 2663 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2664
2665 * chartab.c (uniprop_table): Make it non-static.
2666
525d5e6e
EZ
26672011-08-01 Eli Zaretskii <eliz@gnu.org>
2668
2669 * xdisp.c (forward_to_next_line_start): Accept additional argument
2670 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2671 on the newline.
2672 (reseat_at_next_visible_line_start): Use the bidi iterator state
2673 returned by forward_to_next_line_start to restore the state of
2674 it->bidi_it after backing up to previous newline. (Bug#9212)
2675
31011111
AS
26762011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2677
2678 * regex.c (re_comp): Protoize.
2679 (re_exec): Fix return type.
2680 (regexec): Fix type of `ret'. (Bug#9203)
2681
476371c4
PE
26822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2683
e5d76069
PE
2684 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2685 This is needed if max-image-size is a floating-point number.
2686
9a79b20c
AS
26872011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2688
2689 * print.c (print_object): Print empty symbol as ##.
2690
2691 * lread.c (read1): Read ## as empty symbol.
2692
d8c2fa78
AA
26932011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2694
2695 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2696 setting frame foreground color (Bug#9175).
2697 (x_set_background_color): Likewise.
2698
ffe57a7a
AA
2699 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2700 contents (Bug#9176).
2701 (EmacsTooltip -init): Remove bezels and add shadows to
2702 tooltip windows.
2703
bf3492a5
AA
2704 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2705 or scroll bar (Bug#8470).
2706
d55e9c53
AA
2707 * nsfont.m (nsfont_open): Remove assignment to voffset and
2708 unnecessary vars hshink, expand, hd, full_height, min_height.
2709 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2710
2711 * nsterm.h (nsfont_info): Remove voffset field.
2712
d8c2fa78 27132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2714
2715 Implement strike-through and overline on NextStep (Bug#8863).
2716
2717 * nsfont.m (nsfont_open): Use underline position provided by font,
2718 instead of hard-coded value of 2.
2719 (nsfont_draw): Call ns_draw_text_decoration instead.
2720
2721 * nsterm.h: Add declaration for ns_draw_text_decoration.
2722
2723 * nsterm.m (ns_draw_text_decoration): New function for drawing
2724 underline, overline, and strike-through.
2725 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2726 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2727 accommodate underlining, etc.
4843aac3 2728
4cc60b9b
EZ
27292011-07-28 Eli Zaretskii <eliz@gnu.org>
2730
bc7ece87
EZ
2731 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2732 default.
4cc60b9b 2733
476371c4
PE
27342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2735
66606eea
PE
2736 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2737 Without this fix, if a signal arrives just after memory fills up,
2738 'malloc' might be invoked reentrantly.
2739
476371c4
PE
2740 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2741 In other words, assume that every image size is allowed, on non-X
2742 hosts. This assumption is probably wrong, but it lets Emacs compile.
2743
f3fcc40d
AS
27442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2745
2746 * regex.c (re_iswctype): Convert return values to boolean.
2747
350c992f
EZ
27482011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2749
2750 * xdisp.c (compute_display_string_pos): Don't use cached display
2751 string position if the buffer had its restriction changed.
2752 (Bug#9184)
2753
5266b4bb
PE
27542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2757
2573a837 27582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2759
41f55ccd 2760 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2761
39e378da
PE
2762 * bidi.c: Integer size and overflow fixes.
2763 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2764 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2765 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2766 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2767 (bidi_find_other_level_edge):
2768 Use ptrdiff_t instead of EMACS_INT where either will do.
2769 This works better on 32-bit hosts configured --with-wide-int.
2770 (bidi_cache_ensure_space): Check for size-calculation overflow.
2771 Use % rather than repeated addition, for better worst-case speed.
2772 Don't set bidi_cache_size until after xrealloc returns, because it
2773 might not return.
2774 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2775 (bidi_cache_ensure_space): Also check that the bidi cache size
2776 does not exceed that of the largest Lisp string or buffer. See Eli
2777 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2778
5e927815
PE
2779 * alloc.c (__malloc_size_t): Remove.
2780 All uses replaced by size_t. See Andreas Schwab's note
2781 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2782
ca4aa935
PE
2783 * image.c: Improve checking for integer overflow.
2784 (check_image_size): Assume that f is nonnull, since
2785 it is always nonnull in practice. This is one less thing to
2786 worry about when checking for integer overflow later.
2787 (x_check_image_size): New function, which checks for integer
2788 overflow issues inside X.
2789 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2790 This removes the need for a memory_full check.
2791 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2792 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2793 (xbm_read_bitmap_data): Change locals back to 'int', since
2794 their values must fit in 'int'.
2795 (xpm_load_image, png_load, tiff_load):
2796 Invoke x_create_x_image_and_pixmap earlier,
2797 to avoid much needless work if the image is too large.
2798 (tiff_load): Treat overly large images as if
2799 x_create_x_image_and_pixmap failed, not as malloc failures.
2800 (gs_load): Use x_check_image_size.
2801
5f8f9cc2
PE
2802 * gtkutil.c: Omit integer casts.
2803 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2804 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2805
5adf60bc
PE
2806 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2807
c8907a93
PE
2808 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2809 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2810 would wrongly return t on a 64-bit host.
2811
e3c25c68
PE
2812 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2813 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2814 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2815 and therefore cause GCC to emit a bogus diagnostic in some cases.
2816
3f791afe
PE
2817 * image.c: Integer signedness and overflow and related fixes.
2818 This is not an exhaustive set of fixes, but it's time to
2819 record what I've got.
2820 (lookup_pixel_color, check_image_size): Remove redundant decls.
2821 (check_image_size): Don't assume that arbitrary EMACS_INT values
2822 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2823 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2824 (tiff_load, imagemagick_load_image):
2825 Check for overflow in size calculations.
2826 (x_create_x_image_and_pixmap): Remove unnecessary test for
2827 xmalloc returning NULL; that can't happen.
2828 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2829 (xpm_color_bucket): Use better integer hashing function.
2830 (xpm_cache_color): Don't possibly over-allocate memory.
2831 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2832 (gif_memory_source):
2833 Use ptrdiff_t, not int or size_t, to record sizes.
2834 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2835 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2836 either works, as we prefer signed integers.
2837 (tiff_read_from_memory, tiff_write_from_memory):
2838 Return tsize_t, not size_t, since that's what the TIFF API wants.
2839 (tiff_read_from_memory): Don't fail simply because the read would
2840 go past EOF; instead, return a short read.
2841 (tiff_load): Omit no-longer-needed casts.
2842 (Fimagemagick_types): Don't assume size fits into 'int'.
2843
3cc5a532
PE
2844 Improve hashing quality when configured --with-wide-int.
2845 * fns.c (hash_string): New function, taken from sxhash_string.
2846 Do not discard information about ASCII character case; this
2847 discarding is no longer needed.
2848 (sxhash-string): Use it. Change sig to match it. Caller changed.
2849 * lisp.h: Declare it.
2850 * lread.c (hash_string): Remove, since we now use fns.c's version.
2851 The fns.c version returns a wider integer if --with-wide-int is
2852 specified, so this should help the quality of the hashing a bit.
2853
b312a492
PE
2854 * emacs.c: Integer overflow minor fix.
2855 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2856 Define only if GNU_LINUX.
2857 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2858
dfd153ae
PE
2859 * dispnew.c: Integer signedness and overflow fixes.
2860 Remove unnecessary forward decls, that were a maintenance hassle.
2861 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2862 All uses changed.
2863 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2864 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2865 (prepare_desired_row, line_draw_cost):
2866 Use int, not unsigned, where either works.
2867 (save_current_matrix, restore_current_matrix):
2868 Use ptrdiff_t, not size_t, where either works.
2869 (init_display): Check for overflow more accurately, and without
2870 relying on undefined behavior.
2871
a81d11a3
PE
2872 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2873 Remove, replacing with the new symbols in lisp.h. All uses changed.
2874 * fileio.c (make_temp_name):
2875 * filelock.c (lock_file_1, lock_file):
2876 * xdisp.c (message_dolog):
2877 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2878 Use pMd etc. instead.
2879 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2880 replacing the pWIDE etc. symbols removed from editfns.c.
2881
3300e6fd
PE
2882 * keyboard.h (num_input_events): Now uintmax_t.
2883 This is (very slightly) less likely to mess up due to wraparound.
2884 All uses changed.
2885
fd05c7e9
PE
2886 * buffer.c: Integer signedness fixes.
2887 (alloc_buffer_text, enlarge_buffer_text):
2888 Use ptrdiff_t rather than size_t when either will do, as we prefer
2889 signed integers.
2890
903fe15d
PE
2891 * alloc.c: Integer signedness and overflow fixes.
2892 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2893 (__malloc_size_t): Default to size_t, not to int.
2894 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2895 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2896 Prefer ptrdiff_t to size_t when either would do, as we prefer
2897 signed integers.
2898 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2899 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2900 Now const. Initialize with values that are in range even if char
2901 is signed.
2902 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2903 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2904 These functions do the right thing with sizes > 2**32.
2905 (check_depth): Now ptrdiff_t, not int.
2906 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2907 Adjust to new way of storing sizes. Check for size overflow bugs
2908 in rest of code.
2909 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2910 slightly wrong anyway, as it missed one instance of
2911 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2912 (refill_memory_reserve): Omit needless cast to size_t.
2913 (mark_object_loop_halt): Mark as externally visible.
2914
ac82cc6a
PE
2915 * xselect.c: Integer signedness and overflow fixes.
2916 (Fx_register_dnd_atom, x_handle_dnd_message):
2917 Use ptrdiff_t, not size_t, since we prefer signed.
2918 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2919 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2920 x_dnd_atoms_size and x_dnd_atoms_length.
2921
c2d1e36d
PE
2922 * doprnt.c: Prefer signed to unsigned when either works.
2923 * eval.c (verror):
2924 * doprnt.c (doprnt):
2925 * lisp.h (doprnt):
2926 * xdisp.c (vmessage):
2927 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2928 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2929 prefer signed arithmetic to avoid comparison confusion.
2930 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2931 but is a bit tricky.
2932
0e926e56
PE
2933 Assume freestanding C89 headers, string.h, stdlib.h.
2934 * data.c, doprnt.c, floatfns.c, print.c:
2935 Include float.h unconditionally.
2936 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2937 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2938 * regex.c: Likewise for stddef.h, string.h.
2939 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2940 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2941 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2942 (STDC_HEADERS): Remove obsolete defines.
2943 * sysdep.c: Include limits.h unconditionally.
2944
9cfdb3ec
PE
2945 Assume support for memcmp, memcpy, memmove, memset.
2946 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2947 * regex.c (memcmp, memcpy):
2948 Remove; we assume C89 now.
2949
2950 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2951 (__malloc_safe_bcopy): Remove; no longer needed.
2952
cf950e6b 2953 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2954 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2955 well either way, and we prefer signed to unsigned.
2956
dbf38e02
LMI
29572011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2958
2959 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2960 closes the connection while we're reading (bug#9182).
2961
d6f0886c 29622011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2963
d6f0886c
JD
2964 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2965 are specified (Bug#9168).
24e0f6b1 2966
2eb1f9e6
PE
29672011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2968
2969 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2970 Found by GCC static checking and --with-wide-int on a 32-bit host.
2971
22381272 29722011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2973
2974 * xdisp.c (compute_display_string_pos): Fix logic of caching
2975 previous display string position. Initialize cached_prev_pos to
2976 -1. Fixes slow-down at the beginning of a buffer.
2977
f25e39b4
EZ
29782011-07-24 Eli Zaretskii <eliz@gnu.org>
2979
2980 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2981 for attrs[LFACE_FONTSET_INDEX].
2982
04c4b52e
PE
29832011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2984
2985 * xml.c (parse_region): Remove unused local
2986 that was recently introduced.
2987
c1734fbd
EZ
29882011-07-23 Eli Zaretskii <eliz@gnu.org>
2989
be18c5a5
EZ
2990 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2991 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2992
c1734fbd
EZ
2993 * xdisp.c (move_it_in_display_line_to): Record the best matching
2994 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2995 exit if none of the characters scanned was an exact match.
2996 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2997 when exact match is impossible due to invisible text, and the
2998 lines are truncated.
2999
a258d627
JD
30002011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3001
3002 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3003 for OSX >= 10.7.
3004
b6d5a689
EZ
30052011-07-22 Eli Zaretskii <eliz@gnu.org>
3006
0f74f785
EZ
3007 Fix a significant slow-down of cursor motion with C-n, C-p,
3008 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3009 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3010 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3011 (next_element_from_buffer): Call compute_stop_pos_backwards to
3012 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3013 base_level_stop.
3014 (reseat): Don't look for prev_stop, as that could mean a very long
3015 run.
3016 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3017 <cached_disp_overlay_modiff>: Cache for last found display string
3018 position.
551918c1 3019 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3020 about the same buffer in the same area of character positions, and
3021 the buffer wasn't changed since the time the display string
3022 position was cached.
551918c1 3023
b2d0c91a
EZ
30242011-07-22 Eli Zaretskii <eliz@gnu.org>
3025
3026 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3027 is an integer, which is important for empty lines. (Bug#9149)
3028
043604ee
CY
30292011-07-22 Chong Yidong <cyd@stupidchicken.com>
3030
3031 * frame.c (Fmodify_frame_parameters): In tty case, update the
3032 default face if necessary (Bug#4238).
3033
da4adb04
CY
30342011-07-21 Chong Yidong <cyd@stupidchicken.com>
3035
3036 * editfns.c (Fstring_to_char): No need to explain what a character
3037 is in the docstring (Bug#6576).
3038
9abd0532
LMI
30392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3040
3041 * xml.c (parse_region): Make sure we always return a tree.
3042
36881d16
HK
30432011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3044
3045 * xml.c (parse_region): If a document contains only comments,
3046 return that, too.
3047
1e98674d
LMI
30482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3049
3050 * xml.c (make_dom): Return comments, too.
3051
590bd467
PE
30522011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 Port to OpenBSD.
3055 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3056 and the surrounding thread.
3057 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3058 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3059 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3060 timer goes off.
3061 * s/openbsd.h (BROKEN_SIGIO): Define.
3062 * unexelf.c (unexec) [__OpenBSD__]:
3063 Don't update the .mdebug section of the Alpha COFF symbol table.
3064
f41628b2
LMI
30652011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3066
3067 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3068 (bug#8460).
3069
b59b67c5
PE
30702011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3071
15e3a074
PE
3072 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3073 This fixes some race conditions on the permissions of any newly
3074 created file.
3075
41bed37d
PE
3076 * alloc.c (valid_pointer_p): Use pipe, not open.
3077 This fixes some permissions issues when debugging.
3078
b59b67c5
PE
3079 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3080 If fchown fails to set both uid and gid, try to set just gid,
3081 as that is sometimes allowed. Adjust the file's mode to eliminate
3082 setuid or setgid bits that are inappropriate if fchown fails.
3083
925a6be7
SM
30842011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3085
3086 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3087 to compare Lisp_Objects.
3088 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3089 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3090 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3091
52968808
AS
30922011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3093
0a6a104b
AS
3094 * lread.c (read_integer): Unread even EOF character.
3095 (read1): Likewise. Properly record start position of symbol.
3096
52968808
AS
3097 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3098 symbol character follows.
3099
9e381cdd
PE
31002011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3101
3102 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3103 This works around a problem with the previous change to Fcopy_file.
3104 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3105 and without this change, GCC might complain about discarding
3106 fchown's return value.
3107
b5641435
JB
31082011-07-16 Juanma Barranquero <lekktu@gmail.com>
3109
3110 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3111
a8031457
PE
31122011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3113
3114 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3115
dd889327
LMI
31162011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3117
750c33f7
LMI
3118 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3119 it's used from the C level.
3120
dd889327
LMI
3121 * process.c: Use the same condition for POLL_FOR_INPUT in both
3122 keyboard.c and process.c (bug#1858).
3123
87e86684
LM
31242011-07-09 Lawrence Mitchell <wence@gmx.li>
3125
3126 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3127 (Fgnutls_boot): Use it.
3128
64348f40
AS
31292011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3130
3131 * doc.c (Fsubstitute_command_keys): Revert last change.
3132
1d698799
LMI
31332011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3134
f863868c
LMI
3135 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3136 quotes the next character, and doesn't affect other longer
3137 sequences (bug#8935).
3138
1d698799
LMI
3139 * lread.c (syms_of_lread): Clarify that is isn't only
3140 `eval-buffer' and `eval-defun' that's affected by
3141 `lexical-binding' (bug#8460).
3142
aa4b6df6
EZ
31432011-07-15 Eli Zaretskii <eliz@gnu.org>
3144
3145 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3146 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3147
5d856da6
PE
31482011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3149
ad6042bb
PE
3150 Fix minor problems found by static checking.
3151 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3152 (elsz): Now a signed constant, not a size_t var. We prefer signed
3153 types to unsigned, to avoid integer comparison confusion. Without
3154 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3155 "cannot optimize loop, the loop counter may overflow", a symptom
3156 of the confusion.
f00bbb22 3157 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3158 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3159
6468f31c
LMI
31602011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3161
49080b10
LMI
3162 * search.c (Fre_search_backward): Mention `case-fold-search' in
3163 all the re_search_* functions (bug#8138).
3164
6468f31c
LMI
3165 * keyboard.c (Fopen_dribble_file): Document when the file is
3166 closed (bug#8056).
3167
c965adc5
EZ
31682011-07-14 Eli Zaretskii <eliz@gnu.org>
3169
df9733bf
EZ
3170 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3171 bidi_cache_idx.
3172
0bb23927
EZ
3173 Support bidi reordering of display and overlay strings.
3174 * xdisp.c (compute_display_string_pos)
3175 (compute_display_string_end): Accept additional argument STRING.
3176 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3177 (reseat_to_string): Initialize bidi_it->string.s and
3178 bidi_it->string.schars.
3179 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3180 NULL (avoids a crash in bidi_paragraph_init).
3181 Initialize itb.string.lstring.
0bb23927
EZ
3182 (init_iterator): Call bidi_init_it only of a valid
3183 buffer position was specified. Initialize paragraph_embedding to
3184 L2R.
3185 (reseat_to_string): Initialize the bidi iterator.
3186 (display_string): If we need to ignore text properties of
3187 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3188 original value of -1 will not work with bidi.)
3189 (compute_display_string_pos): First arg is now struct
3190 `text_pos *'; all callers changed. Support display properties on
3191 Lisp strings.
3192 (compute_display_string_end): Support display properties on Lisp
3193 strings.
3194 (init_iterator, reseat_1, reseat_to_string): Initialize the
3195 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3196 when iterating on a string not from display properties).
640c8776
SM
3197 (compute_display_string_pos, compute_display_string_end):
3198 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3199 arrow keys.
3200 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3201 base_level_stop; instead, set base_level_stop to BEGV.
3202 Fixes crashes in vertical-motion.
0bb23927
EZ
3203 (next_element_from_buffer): Improve commentary for when
3204 the iterator is before prev_stop.
3205 (init_iterator): Initialize bidi_p from the default value of
3206 bidi-display-reordering, not from buffer-local value. Use the
3207 buffer-local value only if initializing for buffer iteration.
3208 (handle_invisible_prop): Support invisible properties on strings
3209 that are being bidi-reordered.
3210 (set_iterator_to_next): Support bidi reordering of C strings and
3211 Lisp strings.
3212 (next_element_from_string): Support bidi reordering of Lisp
3213 strings.
3214 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3215 (display_string): Support display of R2L glyph rows.
3216 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3217 (init_iterator): Don't initialize it->bidi_p for strings
3218 here.
3219 (reseat_to_string): Initialize it->bidi_p for strings here.
3220 (next_element_from_string, next_element_from_c_string)
3221 (next_element_from_buffer): Add xassert's for correspondence
3222 between IT's object being iterated and it->bidi_it.string
3223 structure.
3224 (face_before_or_after_it_pos): Support bidi iteration.
3225 (next_element_from_c_string): Handle the case of the first string
3226 character that is not the first one in the visual order.
3227 (get_visually_first_element): New function, refactored from common
3228 parts of next_element_from_buffer, next_element_from_string, and
3229 next_element_from_c_string.
3230 (tool_bar_lines_needed, redisplay_tool_bar)
3231 (display_menu_bar): Force left-to-right direction. Add a FIXME
3232 comment for making that be controlled by a user option.
3233 (push_it, pop_it): Save and restore the state of the
3234 bidi iterator. Save and restore the bidi_p flag.
3235 (pop_it): Iterate out of display property for string iteration as
3236 well.
3237 (iterate_out_of_display_property): Support iteration over strings.
3238 (handle_single_display_spec): Set up it->bidi_it for iteration
3239 over a display string, and call bidi_init_it.
3240 (handle_single_display_spec, next_overlay_string)
3241 (get_overlay_strings_1, push_display_prop): Set up the bidi
3242 iterator for displaying display or overlay strings.
3243 (forward_to_next_line_start): Don't use the shortcut if
3244 bidi-iterating.
3245 (back_to_previous_visible_line_start): If handle_display_prop
3246 pushed the iterator stack, restore the internal state of the bidi
3247 iterator by calling bidi_pop_it same number of times.
3248 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3249 and we are bidi-iterating, don't decrement the iterator position;
3250 instead, set the first_elt flag in the bidi iterator, to produce
3251 the same effect.
3252 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3253 (push_display_prop): xassert that we are iterating a buffer.
3254 (push_it, pop_it): Save and restore paragraph_embedding member.
3255 (handle_single_display_spec, next_overlay_string)
3256 (get_overlay_strings_1, reseat_1, reseat_to_string)
3257 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3258 correctly. Don't assume unibyte strings are not bidi-reordered.
3259 (compute_display_string_pos)
3260 (compute_display_string_end): Fix handling the case of C string.
3261 (push_it, pop_it): Save and restore from_disp_prop_p.
3262 (handle_single_display_spec, push_display_prop): Set the
3263 from_disp_prop_p flag.
3264 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3265 (pop_it): Call iterate_out_of_display_property only if we are
3266 popping after iteration over a string that came from a display
3267 property. Fix a typo in popping stretch info. Add an assertion
3268 for verifying that the iterator position is in sync with the bidi
3269 iterator.
3270 (handle_single_display_spec, get_overlay_strings_1)
3271 (push_display_prop): Fix initialization of paragraph direction for
3272 string when that of the parent object is not yet determined.
3273 (reseat_1): Call bidi_init_it to resync the bidi
3274 iterator with IT's position. (Bug#7616)
3275 (find_row_edges): If ROW->start.pos gives position
3276 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3277 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3278 Reset the from_disp_prop_p flag.
3279 (SAVE_IT, RESTORE_IT): New macros.
3280 (pos_visible_p, face_before_or_after_it_pos)
3281 (back_to_previous_visible_line_start)
3282 (move_it_in_display_line_to, move_it_in_display_line)
3283 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3284 (try_scrolling, redisplay_window, display_line): Use them when
3285 saving a temporary copy of the iterator and restoring it back.
3286 (back_to_previous_visible_line_start, reseat_1)
3287 (init_iterator): Empty the bidi cache "stack".
3288 (move_it_in_display_line_to): If iterator ended up at
3289 EOL, but we never saw any buffer positions smaller than
3290 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3291 motion in bidi-reordered lines.
3292 (move_it_in_display_line_to): Record prev_method and prev_pos
3293 immediately before the call to set_iterator_to_next. Fixes cursor
3294 motion in bidi-reordered lines with stretch glyphs and strings
3295 displayed in margins. (Bug#8133) (Bug#8867)
3296 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3297 TO_CHARPOS.
640c8776
SM
3298 (pos_visible_p): Support positions in bidi-reordered lines.
3299 Save and restore bidi cache.
0bb23927
EZ
3300
3301 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3302 (bidi_paragraph_info): Delete unused struct.
3303 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3304 (bidi_cache_start): New variable.
3305 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3306 to zero.
3307 (bidi_cache_fetch_state, bidi_cache_search)
3308 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3309 (bidi_cache_find, bidi_peek_at_next_level)
3310 (bidi_level_of_next_char, bidi_find_other_level_edge)
3311 (bidi_move_to_visually_next): Compare cache index with
3312 bidi_cache_start rather than with zero.
3313 (bidi_fetch_char): Accept new argument STRING; all callers
3314 changed. Support iteration over a string. Support strings with
3315 display properties. Support unibyte strings. Fix the type of
3316 `len' according to what STRING_CHAR_AND_LENGTH expects.
3317 (bidi_paragraph_init, bidi_resolve_explicit_1)
3318 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3319 (bidi_level_of_next_char, bidi_move_to_visually_next):
3320 Support iteration over a string.
0bb23927
EZ
3321 (bidi_set_sor_type, bidi_resolve_explicit_1)
3322 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3323 can now be zero (for strings); special values 0 and -1 were
3324 changed to -1 and -2, respectively.
3325 (bidi_char_at_pos): New function.
3326 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3327 Call it instead of FETCH_MULTIBYTE_CHAR.
3328 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3329 initialized to valid values.
3330 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3331 values.
3332 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3333 the test for valid cached positions. Fix the logic for looking up
3334 the sentinel state in the cache. GCPRO the Lisp string we are
3335 iterating.
3336 (bidi_push_it, bidi_pop_it): New functions.
3337 (bidi_initialize): Initialize the bidi cache start stack pointer.
3338 (bidi_cache_ensure_space): New function, refactored from part of
3339 bidi_cache_iterator_state. Don't assume the required size is just
3340 one BIDI_CACHE_CHUNK away.
3341 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3342 (bidi_count_bytes, bidi_char_at_pos): New functions.
3343 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3344 always valid if bidi_cache_idx is valid.
3345 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3346 is valid if it's going to be used.
3347 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3348 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3349 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3350 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3351 (bidi_find_other_level_edge, bidi_cache_start_stack):
3352 All variables related to cache indices are now EMACS_INT.
c965adc5 3353
0bb23927
EZ
3354 * dispextern.h (struct bidi_string_data): New structure.
3355 (struct bidi_it): New member `string'. Make flag members be 1-bit
3356 fields, and put them last in the struct.
640c8776
SM
3357 (compute_display_string_pos, compute_display_string_end):
3358 Update prototypes.
0bb23927
EZ
3359 (bidi_push_it, bidi_pop_it): Add prototypes.
3360 (struct iterator_stack_entry): New members bidi_p,
3361 paragraph_embedding, and from_disp_prop_p.
3362 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3363 (bidi_shelve_cache, bidi_unshelve_cache):
3364 Declare prototypes.
0bb23927
EZ
3365
3366 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3367 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3368 and vector-like objects.
3369
3370 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3371 cache around display iteration.
3372
3373 * window.c (Fwindow_end, window_scroll_pixel_based)
3374 (displayed_window_lines, Frecenter): Save and restore the bidi
3375 cache around display iteration.
3376
3bbd2265
LMI
33772011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3378
3379 * editfns.c (Fdelete_region): Clarify the use of the named
3380 parameters (bug#6788).
3381
adc47434
MR
33822011-07-14 Martin Rudalics <rudalics@gmx.at>
3383
3384 * indent.c (Fvertical_motion): Set and restore w->pointm when
3385 saving and restoring the window's buffer (Bug#9006).
3386
837c31f8
LMI
33872011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3388
3389 * editfns.c (Fstring_to_char): Clarify just what is returned
3390 (bug#6576). Text by Eli Zaretskii.
3391
ac389d0c
JB
33922011-07-13 Juanma Barranquero <lekktu@gmail.com>
3393
3394 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3395
0be0ce47
EZ
33962011-07-13 Eli Zaretskii <eliz@gnu.org>
3397
3398 * buffer.c (mmap_find): Fix a typo.
3399
cd18e7e3
JB
34002011-07-13 Johan Bockgård <bojohan@gnu.org>
3401
3402 Fix execution of x selection hooks.
3403 * xselect.c (Qx_lost_selection_functions)
3404 (Qx_sent_selection_functions): New vars.
3405 (syms_of_xselect): DEFSYM them.
3406 (x_handle_selection_request): Pass Qx_sent_selection_functions
3407 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3408 (x_handle_selection_clear,x_clear_frame_selections):
3409 Pass Qx_lost_selection_functions rather than
3410 Vx_lost_selection_functions to Frun_hook_with_args.
3411
47ea7f44
PE
34122011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3413
ac389d0c 3414 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3415 The old code sometimes used this field without initializing it.
3416
47ea7f44
PE
3417 * alloc.c (gc_sweep): Don't read past end of array.
3418 In theory, the old code could also have corrupted Emacs internals,
3419 though it'd be very unlikely.
3420
bc985c87
AS
34212011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3422
3423 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3424 argument. (Bug#4026)
bc985c87 3425
0cf34688
LMI
34262011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3427
b3dadd76
LMI
3428 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3429 key" (bug#4257).
3430
0cf34688
LMI
3431 * window.c (Fset_window_start): Doc fix (bug#4199).
3432 (Fset_window_hscroll): Ditto.
3433
270768cd
PE
34342011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3435
077e3dda 3436 Fix minor new problems caught by GCC 4.6.1.
270768cd 3437 * term.c (init_tty): Remove unused local.
490011a6 3438 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3439 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3440 not used otherwise.
270768cd 3441
b1f58454
CY
34422011-07-12 Chong Yidong <cyd@stupidchicken.com>
3443
3444 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3445
22b9578d
LMI
34462011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3447
6e70ab07
LMI
3448 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3449 are the mini-buffer and the echo area (bug#3320).
3450
22b9578d
LMI
3451 * term.c (init_tty): Remove support for supdup, c10 and perq
3452 terminals, which are no longer supported (bug#1482).
3453
8974cc9f
JB
34542011-07-10 Johan Bockgård <bojohan@gnu.org>
3455
3456 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3457
a560d974
JD
34582011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3459
3460 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3461 for non-popups (Bug#3642).
3462
1dae0f0a
AS
34632011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3464
268c2c36 3465 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3466 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3467 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3468 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3469 * data.c (fmod): Likewise.
3470 * dispnew.c (swap_glyphs_in_rows): Likewise.
3471 * emacs.c (memory_warning_signal): Likewise.
3472 * floatfns.c (float_error): Likewise.
3473 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3474 (otf_open, font_otf_capability, generate_otf_features)
3475 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3476 Likewise.
3477 * image.c (pbm_read_file): Likewise.
3478 * indent.c (string_display_width): Likewise.
3479 * intervals.c (check_for_interval, search_for_interval)
3480 (inc_interval_count, count_intervals, root_interval)
3481 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3482 * lread.c (defalias): Likewise.
268c2c36 3483 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3484 * regex.c (set_image_of_range_1, set_image_of_range)
3485 (regex_grow_registers): Likewise.
3486 * sysdep.c (strerror): Likewise.
3487 * termcap.c (valid_filename_p, tprint, main): Likewise.
3488 * tparam.c (main): Likewise.
3489 * unexhp9k800.c (run_time_remap, save_data_space)
3490 (update_file_ptrs, read_header, write_header, calculate_checksum)
3491 (copy_file, copy_rest, display_header): Likewise.
3492 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3493 Likewise.
3494 * xdisp.c (check_it): Likewise.
3495 * xfaces.c (register_color, unregister_color, unregister_colors):
3496 Likewise.
3497 * xfns.c (print_fontset_result): Likewise.
3498 * xrdb.c (member, fatal, main): Likewise.
3499
99033785
PE
35002011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 Fix minor problems found by static checking (Bug#9031).
3503 * chartab.c (char_table_set_range, map_sub_char_table):
3504 Remove unused locals.
3505 (uniprop_table): Now static.
3506 * composite.c (_work_char): Remove unused static var.
3507
9cb2ac56
JB
35082011-07-09 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3511
f25661f0
JD
35122011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3513
3514 * gtkutil.c (qttip_cb): Remove code without function.
3515
8278c4fe
EZ
35162011-07-09 Eli Zaretskii <eliz@gnu.org>
3517
3518 * w32.c (pthread_sigmask): New stub.
3519
1692ae2d 35202011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3521
8a6ebd58 3522 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3523 sigprocmask is portable only for single-threaded applications, and
3524 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3525 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3526 (LIBES): Use it.
3527 * callproc.c (Fcall_process):
3528 * process.c (create_process):
3529 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3530 Use pthread_sigmask, not sigprocmask.
123403e4 3531
1b854618
JD
35322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3533
3534 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3535 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3536 wrong (Bug#8591).
3537
3fe4b549
JD
35382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3539
0ce7e563
JD
3540 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3541 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3542 (xg_hide_tooltip): Fix comment.
3543
3fe4b549
JD
3544 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3545 in registerServicesMenuSendTypes.
3546 (validRequestorForSendType): Don't check ns_return_types.
3547
3548 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3549 ns_return_type.
3550
5df75e47
JR
35512011-07-08 Jason Rumney <jasonr@gnu.org>
3552
22610910
JR
3553 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3554 SH_SHOW for hidden windows (Bug#5482).
3555
5df75e47
JR
3556 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3557 frame struct members of non-existent frames (Bug#6284).
3558
699c10bd
JD
35592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3560
4393663b
JD
3561 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3562 variable firstTime not needed on OSX >= 10.6.
3563 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3564 >= 10.5. Use setKnobProportion, setDoubleValue.
3565
3566 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3567 (MAC_OS_X_VERSION_10_5): Define if not defined.
3568 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3569 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3570 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3571
3572 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3573 cString and lossyCString on OSX >= 10.4
3574
58179cce 3575 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3576 sizeToFit on OSX >= 10.2.
3577
3578 * nsimage.m (allocInitFromFile): Don't use deprecated method
3579 bestRepresentationForDevice on OSX >= 10.6.
3580
3581 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3582 to avoid warning.
3583
3584 * emacs.c: Declare unexec_init_emacs_zone.
3585
a63e0781
JD
3586 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3587
699c10bd
JD
3588 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3589
3590 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3591 on svcsMenu (Bug#8842).
3592
3593 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3594 ns_return_types.
3595 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3596
3597 * nsterm.m (QUTF8_STRING): Declare.
3598 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3599 (validRequestorForSendType): Return type is (id).
3600 Change indexOfObjectIdenticalTo to indexOfObject.
3601 Check if we have local selection before returning self (Bug#8842).
3602 (writeSelectionToPasteboard): Put local selection into paste board
3603 if we have a local selection (Bug#8842).
3604 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3605
3606 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3607 (ns_get_local_selection): Declare.
3608
54e10184
LMI
36092011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3610
9888ff71
LMI
3611 * keymap.c (describe_map_tree): Don't insert a double newline at
3612 the end of the buffer (bug#1169) and return whether we inserted
3613 something.
3614
54e10184
LMI
3615 * callint.c (Fcall_interactively): Change "reading args" to
3616 "providing args" to try to clarify what it does (bug#1010).
3617
15fa4783
KH
36182011-07-07 Kenichi Handa <handa@m17n.org>
3619
3620 * composite.c (composition_compute_stop_pos): Ignore a static
3621 composition starting before CHARPOS (Bug#8915).
3622
3623 * xdisp.c (handle_composition_prop): Likewise.
3624
a8815b00
EZ
36252011-07-07 Eli Zaretskii <eliz@gnu.org>
3626
3627 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3628 (Bug#9015)
3629
ef7b981d 36302011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3631
3632 * character.h (unicode_category_t): New enum type.
3633
3634 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3635 (Qchar_code_property_table): New variable.
3636 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3637 (UNIPROP_COMPRESSED_FORM_P): New macros.
3638 (char_table_ascii): Uncompress the compressed values.
3639 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3640 Uncompress the compressed values.
ac389d0c 3641 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3642 (char_table_ref_and_range): Uncompress the compressed values.
3643 (sub_char_table_set): New arg is_uniprop. Callers changed.
3644 Uncompress the compressed values.
3645 (sub_char_table_set_range): Args changed. Callers changed.
3646 (char_table_set_range): Adjuted for the above change.
3647 (map_sub_char_table): Delete args default_val and parent. Add arg
3648 top. Give decoded values to a Lisp function.
640c8776 3649 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3650 values to a Lisp function. Gcpro more variables.
3651 (uniprop_table_uncompress)
3652 (uniprop_decode_value_run_length): New functions.
3653 (uniprop_decoder, uniprop_decoder_count): New variables.
3654 (uniprop_get_decoder, uniprop_encode_value_character)
3655 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3656 New functions.
3657 (uniprop_encoder, uniprop_encoder_count): New variables.
3658 (uniprop_get_encoder, uniprop_table)
3659 (Funicode_property_table_internal, Fget_unicode_property_internal)
3660 (Fput_unicode_property_internal): New functions.
3661 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3662 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3663 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3664 char-code-property-alist.
3665
640c8776 3666 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3667 Vunicode_category_table.
3668
640c8776 3669 * font.c (font_range): Adjust for the change of
c805dec0
KH
3670 Vunicode_category_table.
3671
76b397fb
DN
36722011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3673
3674 * m/iris4d.h: Remove file, move contents ...
3675 * s/irix6-5.h: ... here.
3676
22b4128e
PE
36772011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3678
3679 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3680 * alloc.c (mark_buffer):
3681 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3682 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3683 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3684 This isn't true in general, and it's particularly not true
3685 if Emacs is configured with --with-wide-int.
3686 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3687 New macros, used in the buffer.c change.
3688
869795d6
JD
36892011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3690
3691 * xsettings.c: Use both GConf and GSettings if both are available.
3692 (store_config_changed_event): Add comment.
3693 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3694 (store_tool_bar_style_changed): New functions.
5e617bc2 3695 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3696 (struct xsettings): Move font inside HAVE_XFT.
3697 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3698 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3699 Move inside HAVE_XFT.
640c8776 3700 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3701 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3702 also.
3703 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3704 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3705 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3706 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3707 (parse_settings): Move check for font inside HAVE_XFT.
3708 (read_settings, apply_xft_settings): Add comment.
3709 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3710 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3711 call store_font_name_changed.
3712 (xft_settings_event): Add comment.
3713 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3714 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3715 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3716 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3717 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3718 (xsettings_get_system_font, xsettings_get_system_normal_font):
3719 Add comment.
869795d6 3720
d8ed26bd
PE
37212011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3722
3723 Random fixes. E.g., (random) never returned negative values.
3724 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3725 subseconds part to the entropy, as that's a bit more random.
3726 Prefer signed to unsigned, since the signedness doesn't matter and
3727 in general we prefer signed. When given a limit, use a
3728 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3729 latter isn't right if USE_2_TAGS_FOR_INTS.
3730 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3731 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3732
cabf1cac
SM
37332011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3734
3735 * textprop.c (text_property_stickiness):
3736 Obey Vtext_property_default_nonsticky.
3737 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3738 * w32fns.c (syms_of_w32fns):
3739 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3740
6e9b2be9
PE
37412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3744 This is more efficient than Ffile_directory_p and avoids a minor race.
3745
90186c68
LMI
37462011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3747
7c301272
LMI
3748 * buffer.c (Foverlay_put): Say what the return value is
3749 (bug#7835).
3750
c4f2d8d4
LMI
3751 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3752 is a directory before asking whether to use the file name
3753 (bug#7564).
ad637907
LMI
3754 (barf_or_query_if_file_exists): Make the "File is a directory"
3755 error be more correct.
c4f2d8d4 3756
90186c68
LMI
3757 * fns.c (Frequire): Remove the mention of the .gz files, since
3758 that's installation-specific, but keep the mention of
3759 `get-load-suffixes'.
3760
da64016e
PE
37612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3762
3763 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3764 Report string overflow if the output is too long.
3765
7d47b580
JB
37662011-07-04 Juanma Barranquero <lekktu@gmail.com>
3767
a555cb87
JB
3768 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3769 (syms_of_gnutls): Remove duplicate DEFSYM for
3770 Qgnutls_bootprop_verify_hostname_error, an error for
3771 Qgnutls_bootprop_verify_error (which is no longer used).
3772
7d47b580
JB
3773 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3774 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3775 Also (re)move comments that are misplaced or no longer relevant.
3776
1e49bfab
LMI
37772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3778
3779 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3780
1485f4c0
CY
37812011-07-03 Chong Yidong <cyd@stupidchicken.com>
3782
3783 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3784 and background color parameters if they have been changed.
3785
a9ab721e
LMI
37862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3787
3788 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3789
cf7cff57
PE
37902011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3791
2e13213d
PE
3792 * xsettings.c (SYSTEM_FONT): Define only when used.
3793 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3794
cf7cff57
PE
3795 * keymap.c (access_keymap_1): Now static.
3796
7a8e04f7
CY
37972011-07-02 Chong Yidong <cyd@stupidchicken.com>
3798
3799 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3800 leave any prefix arg for the up event (Bug#1586).
3801
61352f62
LMI
38022011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3803
69bb1ef7
LMI
3804 * lread.c (syms_of_lread): Mention single symbols defined by
3805 `defvar' or `defconst' (bug#7154).
3806
61352f62 3807 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3808 (Frequire): Mention get-load-suffixes.
61352f62 3809
28545e04
MR
38102011-07-02 Martin Rudalics <rudalics@gmx.at>
3811
3812 * window.h (window): Remove clone_number slot.
3813 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3814 Remove.
3815 (make_parent_window, make_window, saved_window)
3816 (Fset_window_configuration, save_window_save): Don't deal with
3817 clone numbers.
3818 * buffer.c (Qclone_number): Remove declaration.
3819 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3820
3349e122
SM
38212011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3822
3823 Add multiple inheritance to keymaps.
3824 * keymap.c (Fmake_composed_keymap): New function.
3825 (Fset_keymap_parent): Simplify.
3826 (fix_submap_inheritance): Remove.
3827 (access_keymap_1): New function extracted from access_keymap to handle
3828 embedded parents and handle lists of maps.
3829 (access_keymap): Use it.
3830 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3831 (Fcopy_keymap): Handle embedded parents.
3832 (Fcommand_remapping, define_as_prefix): Simplify.
3833 (Fkey_binding): Simplify.
3834 (syms_of_keymap): Move minibuffer-local-completion-map,
3835 minibuffer-local-filename-completion-map,
3836 minibuffer-local-must-match-map, and
3837 minibuffer-local-filename-must-match-map to Elisp.
3838 (syms_of_keymap): Defsubr make-composed-keymap.
3839 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3840 (parse_menu_item): Trivial simplification.
3841
3279eb87
GM
38422011-07-01 Glenn Morris <rgm@gnu.org>
3843
3844 * Makefile.in (SETTINGS_LIBS): Fix typo.
3845
4550efdf
KI
38462011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3847
3848 * coding.c (Fencode_coding_string): Record the last coding system
3849 used, as the function doc string says (bug#8738).
3850
0949d2b6
JD
38512011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3852
3853 * xsettings.c (store_monospaced_changed): Take new font as arg and
3854 check for change against current_mono_font.
3855 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3856 (emacs_settings_constructor, emacs_settings_get_property)
3857 (emacs_settings_set_property, emacs_settings_class_init)
3858 (emacs_settings_init, gsettings_obj): Remove.
3859 (something_changedCB): New function for HAVE_GSETTINGS.
3860 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3861 with value as argument.
3862 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3863 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3864 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3865 "changed".
3866
3867 * xgselect.c: Add defined (HAVE_GSETTINGS).
3868 (xgselect_initialize): Ditto.
3869
3870 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3871 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3872 xg_select.
3873
bbc6b304
PE
38742011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 * eval.c (struct backtrace): Simplify and port the data structure.
3877 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3878 signed bit field, as this assumption is not portable and it makes
3879 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3880 "char debug_on_exit : 1" as this is not portable either; instead,
3881 use the portable "unsigned int debug_on_exit : 1". Remove unused
3882 member evalargs. Remove obsolete comments about cc bombing out.
3883
9851bfc5
JD
38842011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3885
51bb811f 3886 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3887 Let HAVE_GSETTINGS override HAVE_GCONF.
3888 (store_monospaced_changed): New function.
3889 (EMACS_SETTINGS): A new type derived from GObject to handle
3890 GSettings notifications.
3891 (emacs_settings_constructor, emacs_settings_get_property)
3892 (emacs_settings_set_property, emacs_settings_class_init):
3893 New functions.
3894 (gsettings_client, gsettings_obj): New variables.
3895 (GSETTINGS_SCHEMA): New define.
3896 (something_changedCB): Call store_monospaced_changed.
3897 (init_gsettings): New function.
3898 (xsettings_initialize): Call init_gsettings.
3899 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3900 to NULL.
3901
640c8776 3902 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3903 GCONF_CFLAGS/LIBS.
3904
5386012d
MR
39052011-06-29 Martin Rudalics <rudalics@gmx.at>
3906
3907 * window.c (resize_root_window, grow_mini_window)
3908 (shrink_mini_window): Rename Qresize_root_window to
3909 Qwindow_resize_root_window and Qresize_root_window_vertically to
3910 Qwindow_resize_root_window_vertically.
3911
f13e0b08
PE
39122011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3913
3914 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3915
94515237
JB
39162011-06-27 Juanma Barranquero <lekktu@gmail.com>
3917
3918 * makefile.w32-in: Redesign dependencies so they reflect more
3919 clearly which files are directly included by each source file,
3920 and not through other includes.
3921
e43b6e43
MR
39222011-06-27 Martin Rudalics <rudalics@gmx.at>
3923
3924 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3925 (sort_overlays, overlay_strings): When an overlay's clone number
3926 matches the window's clone number process the overlay even if
3927 the overlay's window property doesn't match the current window.
3928
d68443dc
MR
3929 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3930 (Fwindow_hchild): Rename to Fwindow_left_child.
3931 (Fwindow_next): Rename to Fwindow_next_sibling.
3932 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3933 (resize_window_check): Rename to window_resize_check.
3934 (resize_window_apply): Rename to window_resize_apply.
3935 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3936 (Fdelete_other_windows_internal, resize_frame_windows)
3937 (Fsplit_window_internal, Fdelete_window_internal)
3938 (grow_mini_window, shrink_mini_window)
3939 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3940
c7e73be5
JD
39412011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3942
3943 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3944 (emacs_fixed_set_min_size): Remove.
3945 (emacs_fixed_new): Take frame as argument.
3946
3947 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3948 (_EmacsFixedPrivate): Remove minwidth/height.
3949 Add struct frame *f.
3950 (emacs_fixed_init): Initialize priv->f.
3951 (get_parent_class, emacs_fixed_set_min_size): Remove.
3952 (emacs_fixed_new): Set priv->f to argument.
3953 (emacs_fixed_get_preferred_width)
3954 (emacs_fixed_get_preferred_height): Use min_width/height from
3955 frames size_hint to set minimum and natural (Bug#8919).
3956 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3957 and use min_width/height from frames size_hint to set
3958 min_width/height (Bug#8919).
3959
3960 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3961 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3962 Fix indentation.
c7e73be5 3963
cf99dcf8
EZ
39642011-06-26 Eli Zaretskii <eliz@gnu.org>
3965
3966 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3967 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3968 called at ZV.
3969
029529ac
CY
39702011-06-26 Chong Yidong <cyd@stupidchicken.com>
3971
3972 * process.c (wait_reading_process_output): Bypass select if
3973 waiting for a cell while ignoring keyboard input, and input is
3974 pending. Suggested by Jan Djärv (Bug#8869).
3975
7a7ef429
PE
39762011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3977
3978 Use gnulib's dup2 module instead of rolling our own.
3979 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3980
11fdef7d 39812011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3982
3983 * dispnew.c (scrolling_window): Before scrolling, turn off a
3984 mouse-highlight in the window being scrolled.
3985
cd3520a4
JB
39862011-06-24 Juanma Barranquero <lekktu@gmail.com>
3987
3988 Move DEFSYM to lisp.h and use everywhere.
3989
3990 * character.h (DEFSYM): Move declaration...
3991 * lisp.h (DEFSYM): ...here.
3992
3993 * gnutls.c:
3994 * minibuf.c:
3995 * w32menu.c:
3996 * w32proc.c:
3997 * w32select.c: Don't include character.h.
3998
3999 * alloc.c (syms_of_alloc):
4000 * buffer.c (syms_of_buffer):
4001 * bytecode.c (syms_of_bytecode):
4002 * callint.c (syms_of_callint):
4003 * casefiddle.c (syms_of_casefiddle):
4004 * casetab.c (init_casetab_once):
4005 * category.c (init_category_once, syms_of_category):
4006 * ccl.c (syms_of_ccl):
4007 * cmds.c (syms_of_cmds):
4008 * composite.c (syms_of_composite):
4009 * dbusbind.c (syms_of_dbusbind):
4010 * dired.c (syms_of_dired):
4011 * dispnew.c (syms_of_display):
4012 * doc.c (syms_of_doc):
4013 * editfns.c (syms_of_editfns):
4014 * emacs.c (syms_of_emacs):
4015 * eval.c (syms_of_eval):
4016 * fileio.c (syms_of_fileio):
4017 * fns.c (syms_of_fns):
4018 * frame.c (syms_of_frame):
4019 * fringe.c (syms_of_fringe):
4020 * insdel.c (syms_of_insdel):
4021 * keymap.c (syms_of_keymap):
4022 * lread.c (init_obarray, syms_of_lread):
4023 * macros.c (syms_of_macros):
4024 * msdos.c (syms_of_msdos):
4025 * print.c (syms_of_print):
4026 * process.c (syms_of_process):
4027 * search.c (syms_of_search):
4028 * sound.c (syms_of_sound):
4029 * syntax.c (init_syntax_once, syms_of_syntax):
4030 * terminal.c (syms_of_terminal):
4031 * textprop.c (syms_of_textprop):
4032 * undo.c (syms_of_undo):
4033 * w32.c (globals_of_w32):
4034 * window.c (syms_of_window):
4035 * xdisp.c (syms_of_xdisp):
4036 * xfaces.c (syms_of_xfaces):
4037 * xfns.c (syms_of_xfns):
4038 * xmenu.c (syms_of_xmenu):
4039 * xsettings.c (syms_of_xsettings):
4040 * xterm.c (syms_of_xterm): Use DEFSYM.
4041
4228cf16
TZ
40422011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4043
cd3520a4 4044 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4045
7fcccf1e
PE
40462011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4047
7efb4e0e
PE
4048 Integer and buffer overflow fixes (Bug#8873).
4049
ff5844ad
PE
4050 * print.c (printchar, strout): Check for string overflow.
4051 (PRINTPREPARE, printchar, strout):
4052 Don't set size unless allocation succeeds.
4053
90532f02
PE
4054 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4055 for sizes. Check for string overflow more accurately.
4056 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4057
6d84508d
PE
4058 * macros.c: Integer and buffer overflow fixes.
4059 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4060 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4061 Use ptrdiff_t, not int, for sizes.
4062 Don't increment bufsize until after realloc succeeds.
4063 Check for size-calculation overflow.
4064 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4065
437b2cb4
PE
4066 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4067
8b9ac8b4
PE
4068 * lread.c: Integer overflow fixes.
4069 (read_integer): Radix is now EMACS_INT, not int,
4070 to improve quality of diagnostics for out-of-range radices.
4071 Calculate buffer size correctly for out-of-range radices.
4072 (read1): Check for integer overflow in radices, and in
4073 read-circle numbers.
82cb60d3
PE
4074 (read_escape): Avoid int overflow.
4075 (Fload, openp, read_buffer_size, read1)
4076 (substitute_object_recurse, read_vector, read_list, map_obarray):
4077 Use ptrdiff_t, not int, for sizes.
4078 (read1): Use EMACS_INT, not int, for sizes.
20270765 4079 Check for size overflow.
8b9ac8b4 4080
7fcccf1e
PE
4081 * image.c (cache_image): Check for size arithmetic overflow.
4082
bfbbd7e7
PE
4083 * lread.c: Integer overflow issues.
4084 (saved_doc_string_size, saved_doc_string_length)
4085 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4086 Now ptrdiff_t, not int.
4087 (read1): Don't assume doc string length fits in int. Check for
4088 out-of-range doc string lengths.
4089 (read_list): Don't assume file position fits in int.
39019e54 4090 (read_escape): Check for hex character overflow.
bfbbd7e7 4091
4e323265
LL
40922011-06-22 Leo Liu <sdl.web@gmail.com>
4093
4094 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4095 Move to minibuffer.el.
4096
85fece3e
PE
40972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4098
20b84ce9 4099 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4100 The following patches are for when GLYPH_DEBUG && !XASSERT.
4101 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4102 * dispnew.c (flush_stdout):
4103 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4104 Mark as externally visible.
4105 * dispnew.c (check_window_matrix_pointers): Now static.
4106 * dispnew.c (window_to_frame_vpos):
4107 * xfns.c (unwind_create_frame):
4108 * xterm.c (x_check_font): Remove unused local.
4109 * scroll.c (CHECK_BOUNDS):
4110 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4111 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4112 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4113 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4114 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4115 Now static.
4116 (debug_method_add): Use va_list and vsprintf rather than relying
4117 on undefined behavior with wrong number of arguments.
4118 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4119 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4120 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4121 since we're not interested in debugging glyphs with old libraries.
4122 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4123 GCC 4.6.0's static checking.
4124
0766b489
PE
41252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4126
31fd4b32
PE
4127 Integer overflow and signedness fixes (Bug#8873).
4128 A few related buffer overrun fixes, too.
4129
b79e8648
PE
4130 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4131
0766b489
PE
4132 * dispextern.h (struct face.stipple):
4133 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4134 (x_bitmap_mask, x_allocate_bitmap_record)
4135 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4136 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4137 (x_create_bitmap_from_xpm_data):
4138 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4139 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4140 (.bitmaps_last):
4141 * xfaces.c (load_pixmap):
4142 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4143 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4144 (.bitmaps_last, struct x_output.icon_bitmap):
4145 Use ptrdiff_t, not int, for bitmap indexes.
4146 (x_allocate_bitmap_record): Check for size overflow.
4147 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4148
b081724f
PE
4149 Use ptrdiff_t, not int, for overlay counts.
4150 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4151 * editfns.c (overlays_around, get_pos_property):
4152 * textprop.c (get_char_property_and_overlay):
4153 * xdisp.c (next_overlay_change, note_mouse_highlight):
4154 * xfaces.c (face_at_buffer_position):
21514da7
PE
4155 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4156 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4157 (Fnext_overlay_change, Fprevious_overlay_change)
4158 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4159 Use ptrdiff_t, not int, for sizes.
21514da7 4160 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4161
3de73e5e
PE
4162 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4163
2606c57b
PE
4164 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4165 (x_session_initialize): Do not assume string length fits in int.
4166
aaafe47a
PE
4167 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4168 This is unlikely, but can occur if DPI is outlandish.
4169
2674ddc8 4170 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4171 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4172
28154962
PE
4173 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4174 * xrdb.c (magic_file_p, search_magic_path):
4175 Omit last arg SUFFIX; it was always 0. All callers changed.
4176 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4177
7de51af5
PE
4178 * xfont.c (xfont_match): Avoid need for strlen.
4179
25ed6cc3
PE
4180 * xfns.c: Don't assume strlen fits in int.
4181 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4182
4eab31dd
PE
4183 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4184 not unsigned long, as we prefer signed integers. All callers changed.
4185 Detect integer overflow in repeat count.
4186 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4187 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4188
171e2a58
PE
4189 * termcap.c: Don't assume sizes fit in int and never overflow.
4190 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4191 (gobble_line): Check for size-calculation overflow.
4192
ad39faca 4193 * minibuf.c (Fread_buffer):
6e5bb2dc 4194 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4195 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4196 Don't assume string length fits in int.
4197
52c61c22 4198 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4199 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4200
b5b8c9e5
PE
4201 * font.c: Don't assume string length fits in int.
4202 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4203 Use ptrdiff_t, not int.
ccd6111c
PE
4204 (font_intern_prop): Don't assume string length fits in int.
4205 Don't assume integer property fits in fixnum.
4206 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4207
882f0d81 4208 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4209 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4210 Reformulate so as not to need the command string.
4211 Invoke gzip -cd rather than gunzip, as it's more portable.
4212 (lock_info_type, lock_file_1, lock_file):
4213 Don't assume pid_t and time_t fit in unsigned long.
4214 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4215 (current_lock_owner): Prefer signed type for sizes.
4216 Use memcpy, not strncpy, where memcpy is what is really wanted.
4217 Don't assume (via atoi) that time_t and pid_t fit in int.
4218 Check for time_t and/or pid_t out of range, e.g., via a network share.
4219 Don't alloca where an auto var works fine.
4220
93f4cf88
PE
4221 * fileio.c: Fix some integer overflow issues.
4222 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4223 Don't assume string length fits in int.
4224 (directory_file_name): Don't assume string length fits in long.
4225 (make_temp_name): Don't assume pid fits in int, or that its print
4226 length is less than 20.
4227
f3e92b69
PE
4228 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4229
1bfdaf10
PE
4230 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4231
35016e9a
PE
4232 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4233
3d1e65a1
PE
4234 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4235 We prefer signed integers, even for size calculations.
4236
0b963a93
PE
4237 * emacs.c: Don't assume string length fits in 'int'.
4238 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4239 (main): Don't invoke strlen when not needed.
4240
573f4b54
PE
4241 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4242 (XD_DEBUG_MESSAGE): Don't waste a byte.
4243
989f33ba
PE
4244 * callproc.c (getenv_internal_1, getenv_internal)
4245 (Fgetenv_internal):
965d34eb
PE
4246 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4247
e4d29b33
PE
4248 * lread.c (invalid_syntax): Omit length argument.
4249 All uses changed. This doesn't fix a bug, but it simplifies the
4250 code away from its former Hollerith-constant appearance, and it's
4251 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4252 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4253
eb49b136
PE
4254 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4255 This didn't break anything, but it didn't help either.
4256 It's confusing to put a bogus integer in a place where the actual
4257 value does not matter.
9f62aeb1 4258 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4259 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4260
15375a22
PE
4261 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4262 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4263 implementation.
b61cc01c
PE
4264 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4265 We prefer signed types, and the value cannot exceed the EMACS_INT
4266 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4267 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4268 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4269 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4270
53b2623d
PE
4271 * indent.c (sane_tab_width): New function.
4272 (current_column, scan_for_column, Findent_to, position_indentation)
4273 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4274 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4275
51cab52b 4276 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4277
f2ed8a70
PE
4278 * lisp.h (lint_assume): New macro.
4279 * composite.c (composition_gstring_put_cache):
4280 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4281
abe80cc6
PE
4282 * editfns.c, insdel.c:
4283 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4284
b02c740e
PE
4285 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4286
ebc96716
PE
4287 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4288
b4e50fa0 4289 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4290 Use much-faster test for byte-length change.
311d5d7c 4291 Don't assume string byte-length fits in 'int'.
a4cf38e4 4292 Check that character arg fits in 'int'.
85461888 4293 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4294
c0c1ee9f
PE
4295 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4296
a498d7f4
PE
4297 * fns.c (concat): Catch string overflow earlier.
4298 Do not rely on integer wraparound.
4299
51cab52b
PE
4300 * dispextern.h (struct it.overlay_strings_charpos)
4301 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4302 * xdisp.c (forward_to_next_line_start)
4303 (back_to_previous_visible_line_start)
4304 (reseat_at_next_visible_line_start, next_element_from_buffer):
4305 Don't arbitrarily truncate the value of 'selective' to int.
4306
76031fad
PE
4307 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4308
5eb55db9
PE
4309 * composite.c: Don't truncate sizes to 'int'.
4310 (composition_gstring_p, composition_reseat_it)
4311 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4312 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4313 not EMACS_UINT, for indexes.
5eb55db9 4314
0703a717
PE
4315 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4316
d6202519
PE
4317 * buffer.c: Include <verify.h>.
4318 (struct sortvec.priority, struct sortstr.priority):
8961a454 4319 Now EMACS_INT, not int.
c20998a7 4320 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4321 (struct sortstr.size, record_overlay_string)
4322 (struct sortstrlist.size, struct sortlist.used):
4323 Don't truncate size to int.
4324 (record_overlay_string): Check for size-calculation overflow.
d6202519 4325 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4326
d5a19415
JM
43272011-06-22 Jim Meyering <meyering@redhat.com>
4328
029529ac 4329 Don't leak an XBM-image-sized buffer
d5a19415
JM
4330 * image.c (xbm_load): Free the image buffer after using it.
4331
a9041e6c
PE
43322011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 Port to Sun C.
4335 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4336 that Sun C diagnosed.
4337 * fns.c (secure_hash): Fix pointer signedness issue.
4338 * intervals.c (static_offset_intervals): New function.
4339 (offset_intervals): Use it.
4340
7f3f739f
LL
43412011-06-21 Leo Liu <sdl.web@gmail.com>
4342
4343 * deps.mk (fns.o):
4344 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4345 sha512.h.
4346
4347 * fns.c (secure_hash): Rename from crypto_hash_function and change
4348 the first arg to accept symbols.
5b66d427 4349 (Fsecure_hash): New primitive.
7f3f739f
LL
4350 (syms_of_fns): New symbols.
4351
76147d94
DD
43522011-06-20 Deniz Dogan <deniz@dogan.se>
4353
4354 * process.c (Fset_process_buffer): Clarify return value in
4355 docstring.
4356
7d7d0045
CY
43572011-06-18 Chong Yidong <cyd@stupidchicken.com>
4358
4359 * dispnew.c (add_window_display_history): Use BVAR.
4360
4361 * xdisp.c (debug_method_add): Use BVAR.
4362 (check_window_end, dump_glyph_matrix, dump_glyph)
4363 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4364
4365 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4366 Likewise.
4367
4368 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4369 check till after the cache is created in init_frame_faces.
4370
ff2bc410
SM
43712011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4372
4373 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4374
28177add
PE
43752011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4376
dd3482fe
PE
4377 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4378 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4379 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4380
393d71f3 4381 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4382 * fileio.c (Finsert_file_contents):
4383 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4384 Remove the old (too-loose) buffer overflow checks.
4385 They weren't needed, since make_gap checks for buffer overflow.
4386 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4387 The old code merely checked for Emacs fixnum overflow, and relied
4388 on undefined (wraparound) behavior. The new code avoids undefined
4389 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4390
2e6813b0 4391 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4392 Tune. Don't use wider integers than needed. Don't use alloca.
4393 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4394
599a9e4f
PE
4395 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4396
99561444
PE
4397 * insdel.c, lisp.h (buffer_overflow): New function.
4398 (insert_from_buffer_1, replace_range, replace_range_2):
4399 * insdel.c (make_gap_larger):
4400 * editfns.c (Finsert_char):
4401 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4402
28177add
PE
4403 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4404
e69dafad
PE
44052011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4406
a7af7fde 4407 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4408
b1c46f02
PE
4409 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4410 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4411
e69dafad
PE
4412 * fileio.c: Don't assume EMACS_INT fits in off_t.
4413 (emacs_lseek): New static function.
4414 (Finsert_file_contents, Fwrite_region): Use it.
4415 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4416
566684ea
PE
4417 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4418
e6966cd6
PE
4419 * fns.c: Don't overflow int when computing a list length.
4420 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4421 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4422 truncation on 64-bit hosts. Check for QUIT every
4423 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4424 faster and is responsive enough.
4425 (Flength): Report an error instead of overflowing an integer.
4426 (Fsafe_length): Return a float if the value is not representable
4427 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4428 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4429 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4430
dd0b0efb
PE
4431 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4432 (header_size, word_size): New constants.
4433 (allocate_vectorlike): Don't check size overflow here.
4434 (allocate_vector): Check it here instead, since this is the only
4435 caller of allocate_vectorlike that could cause overflow.
4436 Check that the new vector's length is representable as a fixnum.
4437
86fe5cfe
PE
4438 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4439 The previous code was bogus. For example, next_almost_prime (32)
4440 returned 39, which is undesirable as it is a multiple of 3; and
4441 next_almost_prime (24) returned 25, which is a multiple of 5 so
4442 why was the code bothering to check for multiples of 7?
4443
80e88859
PE
4444 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4445
4a2f0ad6
PE
4446 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4447
f66c7cf8
PE
4448 Variadic C functions now count arguments with ptrdiff_t.
4449 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4450 Back then I didn't know that the Emacs coding style prefers signed int.
4451 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4452 were being counted with int, which may truncate counts on 64-bit
4453 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4454 * lisp.h (struct Lisp_Subr.function.aMANY)
4455 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4456 Arg counts are now ptrdiff_t, not size_t.
4457 All variadic functions and their callers changed accordingly.
4458 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4459 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4460 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4461 * callint.c (Fcall_interactively): Check arg count for overflow,
4462 to avoid potential buffer overrun. Use signed char, not 'int',
4463 for 'varies' array, so that we needn't bother to check its size
4464 calculation for overflow.
4465 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4466 * eval.c (apply_lambda):
4467 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4468 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4469 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4470
a1759b76
PE
4471 * callint.c (Fcall_interactively): Don't use index var as event count.
4472
d96be9fc
PE
4473 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4474 * mem-limits.h (SIZE): Remove; no longer used.
4475
a690a978 4476 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4477
578c21e6
PE
4478 Remove unnecessary casts.
4479 * xterm.c (x_term_init):
4480 * xfns.c (x_set_border_pixel):
4481 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4482 These aren't needed now that we assume ANSI C.
4483
96f53c6c
PE
4484 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4485 It's more likely to cause problems (due to unsigned overflow)
4486 than to cure them.
4487
83c77d31
PE
4488 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4489
ee2079f1
PE
4490 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4491
6da65536
PE
4492 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4493
7147c4a4
PE
4494 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4495
193e32d9
PE
4496 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4497
e5533da6
PE
4498 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4499
9910e595
PE
4500 GLYPH_CODE_FACE returns EMACS_INT, not int.
4501 * dispextern.h (merge_faces):
4502 * xfaces.c (merge_faces):
01103c44
PE
4503 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4504 Don't assume EMACS_INT fits in int.
9910e595 4505
2638320e
PE
4506 * character.h (CHAR_VALID_P): Remove unused parameter.
4507 * fontset.c, lisp.h, xdisp.c: All uses changed.
4508
045eb8d9
PE
4509 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4510
c1f134b5
PE
4511 * fns.c (concat): Minor tuning based on overflow analysis.
4512 This doesn't fix any bugs. Use int to hold character, instead
4513 of constantly refetching from Emacs object. Use XFASTINT, not
4514 XINT, for value known to be a character. Don't bother comparing
4515 a single byte to 0400, as it's always less.
4516
395fcb93 4517 * floatfns.c (Fexpt):
327eeec8
PE
4518 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4519
abbd3d23
PE
4520 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4521 for characters.
4522
684a03ef
PE
4523 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4524
0fed43f3
PE
4525 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4526 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4527 incorrectly succeed when S was a string, because 4294967386 was
4528 truncated before it was used.
4529
8fd02eb7
PE
4530 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4531 Otherwise, an out-of-range integer could cause undefined behavior
4532 on a 64-bit host.
4533
f8c86b69
PE
4534 * composite.c: Use int, not EMACS_INT, for characters.
4535 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4536 EMACS_INT, for values that are known to be in character range.
4537 This doesn't fix any bugs but is the usual style inside Emacs and
4538 may generate better code on 32-bit machines.
4539
34206dd2
PE
4540 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4541 This is for reasons similar to the recent CHAR_STRING fix.
4542 * charset.c (Fencode_char): Check that character arg is actually
4543 a character. Pass an int to ENCODE_CHAR.
4544 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4545 wider than 'int', as a compile-time check to prevent future regressions
4546 in this area.
4547
c5958d4c 4548 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4549
4550 Make sure a 64-bit char is never passed to CHAR_STRING.
4551 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4552 by silently ignoring the top 32 bits, allowing some values
4553 that were far too large to be valid characters.
4554 * character.h: Include <verify.h>.
4555 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4556 arguments are no wider than unsigned, as a compile-time check
4557 to prevent future regressions in this area.
4558 * data.c (Faset):
01103c44 4559 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4560 (Fsubst_char_in_region):
4561 * fns.c (concat):
4562 * xdisp.c (decode_mode_spec_coding):
4563 Adjust to CHAR_STRING's new requirement.
4564 * editfns.c (Finsert_char, Fsubst_char_in_region):
4565 * fns.c (concat): Check that character args are actually
4566 characters. Without this test, these functions did the wrong
4567 thing with wildly out-of-range values on 64-bit hosts.
4568
d37ca623
PE
4569 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4570 These casts should not be needed on 32-bit hosts, either.
4571 * keyboard.c (read_char):
4572 * lread.c (Fload): Remove casts to unsigned.
4573
ea204efb
PE
4574 * lisp.h (UNSIGNED_CMP): New macro.
4575 This fixes comparison bugs on 64-bit hosts.
4576 (ASCII_CHAR_P): Use it.
4577 * casefiddle.c (casify_object):
01103c44 4578 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4579 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4580 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4581 * dispextern.h (FACE_FROM_ID):
4582 * keyboard.c (read_char): Use UNSIGNED_CMP.
4583
41cb286c
PE
4584 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4585 not to EMACS_INT, to avoid GCC warning.
4586
4a1b9832
PE
4587 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4588
55daad71
PE
4589 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4590 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4591 isn't needed on 32-bit machines.
8f95c75c 4592
01103c44
PE
4593 * buffer.c (Fgenerate_new_buffer_name):
4594 Use EMACS_INT for count, not int.
0ceccced 4595 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4596
4597 * data.c (Qcompiled_function): Now static.
4598
c6f072e7
PE
4599 * window.c (window_body_lines): Now static.
4600
20ce5912
PE
4601 * image.c (gif_load): Rename local to avoid shadowing.
4602
9c4c5f81
PE
4603 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4604 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4605 * alloc.c (make_save_value): Integer argument is now of type
4606 ptrdiff_t, not int.
4607 (mark_object): Use ptrdiff_t, not int.
4608 * lisp.h (pD): New macro.
4609 * print.c (print_object): Use it.
4610
c0c5c8ae
PE
4611 * alloc.c: Use EMACS_INT, not int, to count objects.
4612 (total_conses, total_markers, total_symbols, total_vector_size)
4613 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4614 (total_free_floats, total_floats, total_free_intervals)
4615 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4616 Now EMACS_INT, not int. All uses changed.
4617 (Fgarbage_collect): Compute overall total using a double, so that
4618 integer overflow is less likely to be a problem. Check for overflow
4619 when converting back to an integer.
5a25e253
PE
4620 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4621 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4622 These were 'int' variables that could overflow on 64-bit hosts;
4623 they were never used, so remove them instead of repairing them.
211a0b2a 4624 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4625 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4626 Previously, this ceilinged at INT_MAX, but that doesn't work on
4627 64-bit machines.
e46bb31a 4628 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4629
c78baabf 4630 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4631 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4632 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4633 when a (possibly-narrower) signed value would do just as well.
4634 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4635
c9d624c6
PE
4636 * alloc.c: Catch some string size overflows that we were missing.
4637 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4638 for convenience in STRING_BYTES_MAX.
4639 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4640 The definition here is exact; the one in lisp.h was approximate.
4641 (allocate_string_data): Check for string overflow. This catches
4642 some instances we weren't catching before. Also, it catches
4643 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4644 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4645 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4646
c9d624c6
PE
4647 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4648 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4649 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4650
353032ce
PE
4651 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4652
2bccce07
PE
4653 * alloc.c (Fmake_string): Check for out-of-range init.
4654
0ac30604
SM
46552011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4656
4657 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4658
c195f2de
JD
46592011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4660
4661 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4662 xg_get_default_scrollbar_width.
4663
4664 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4665 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4666 (style_changed_cb): Call update_theme_scrollbar_width and call
4667 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4668 all frames (Bug#8505).
4669 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4670 Call gtk_window_set_resizable if HAVE_GTK3.
4671 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4672 and height if HAVE_GTK3 (Bug#8505).
4673 (scroll_bar_width_for_theme): New variable.
4674 (update_theme_scrollbar_width): New function.
4675 (xg_get_default_scrollbar_width): Move code to
4676 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4677 (xg_initialize): Call update_theme_scrollbar_width.
4678
4679 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4680
4681 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4682
e10ac9f1
MR
46832011-06-12 Martin Rudalics <rudalics@gmx.at>
4684
4685 * frame.c (make_frame): Call other_buffer_safely instead of
4686 other_buffer.
4687
4688 * window.c (temp_output_buffer_show): Call display_buffer with
4689 second argument Vtemp_buffer_show_specifiers and reset latter
4690 immediately after the call.
4691 (Vtemp_buffer_show_specifiers): New variable.
4692 (auto_window_vscroll_p, next_screen_context_lines)
4693 (Vscroll_preserve_screen_position): Remove leading asterisks from
4694 doc-strings.
4695
2d3c217e 46962011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4697
7b7f97e8 4698 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4699 * buffer.c (Qclone_number): Remove for now, as it's unused.
4700 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4701 (record_buffer): Remove unused local.
4702 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4703 (set_frame_buffer_list): Remove; unused.
4704 * frame.h (other_visible_frames): Remove decl.
4705 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4706 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4707 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4708 if HAVE_GPM.
4709 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4710 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4711 Define only if HAVE_GPM.
4712 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4713 (update_hints_inhibit): Remove; never set. All uses removed.
4714 * widgetprv.h (emacsFrameClassRec): Remove decl.
4715 * window.c (delete_deletable_window): Now returns void, since it
4716 wasn't returning anything.
4717 (compare_window_configurations): Remove unused locals.
4718 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4719 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4720 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4721 the same widths as pointers. This follows up on the 2011-05-06 patch.
4722 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4723 * xterm.h: Likewise.
4724 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4725
1384b89e
JB
47262011-06-12 Juanma Barranquero <lekktu@gmail.com>
4727
4728 * makefile.w32-in: Update dependencies.
4729 (LISP_H): Add lib/intprops.h.
4730
1100a63c
CY
47312011-06-11 Chong Yidong <cyd@stupidchicken.com>
4732
4733 * image.c (gif_load): Add animation frame delay to the metadata.
4734 (syms_of_image): Use DEFSYM. New symbol `delay'.
4735
6198ccd0
MR
47362011-06-11 Martin Rudalics <rudalics@gmx.at>
4737
4738 * window.c (delete_deletable_window): Re-add.
4739 (Fset_window_configuration): Rewrite to handle dead buffers and
4740 consequently deletable windows.
4741 (window_tree, Fwindow_tree): Remove. Supply functionality in
4742 window.el.
4743 (compare_window_configurations): Simplify code.
4744
b6e3633c
AS
47452011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4746
1ab0dee5
AS
4747 * image.c (imagemagick_load_image): Fix type mismatch.
4748 (Fimagemagick_types): Likewise.
4749
b6e3633c
AS
4750 * window.h (replace_buffer_in_windows): Declare.
4751
9397e56f
MR
47522011-06-11 Martin Rudalics <rudalics@gmx.at>
4753
4754 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4755 Qclone_number. Remove external declaration of Qdelete_window.
4756 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4757 code.
640c8776
SM
4758 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4759 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4760 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4761 buffer list implementation.
4762 (other_buffer_safely): New function.
4763 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4764 calls to replace_buffer_in_windows and
4765 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4766 if allowed.
4767 (record_buffer): Inhibit quitting and rewrite using quittable
4768 functions. Run Qbuffer_list_update_hook if allowed.
4769 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4770 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4771 Move switch-to-buffer to window.el.
9397e56f
MR
4772 (bury-buffer): Move to window.el.
4773 (Vbuffer_list_update_hook): New variable.
4774
4775 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4776 section.
4777
4778 * window.h (resize_frame_windows): Move up in code.
4779 (Fwindow_frame): Remove EXFUN.
4780 (replace_buffer_in_all_windows): Remove prototype.
4781 (replace_buffer_in_windows_safely): Add prototype.
4782
4783 * window.c: Declare Qdelete_window static again. Move down
4784 declaration of select_count.
4785 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4786 (Fother_window): Move to window.el.
4787 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4788 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4789 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4790 window.el.
4791 (replace_buffer_in_windows): Implement by calling
4792 Qreplace_buffer_in_windows.
4793 (replace_buffer_in_all_windows): Remove with some functionality
4794 moved into replace_buffer_in_windows_safely.
4795 (replace_buffer_in_windows_safely): New function.
4796 (select_window_norecord, select_frame_norecord): Move in front
4797 of run_window_configuration_change_hook. Remove now obsolete
4798 declarations.
640c8776
SM
4799 (Fset_window_buffer): Rewrite doc-string.
4800 Call Qrecord_window_buffer.
9397e56f
MR
4801 (keys_of_window): Move binding for other-window to window.el.
4802
b50691aa
CY
48032011-06-11 Chong Yidong <cyd@stupidchicken.com>
4804
4805 * dispextern.h (struct image): Replace data member, whose int_val
4806 and ptr_val fields were not used by anything, with a single
4807 lisp_val object.
4808
4809 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4810 (gif_clear_image, gif_load, imagemagick_load_image)
4811 (gs_clear_image, gs_load): Callers changed.
4812
3f754b86
PE
48132011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4814
cca69397
PE
4815 * buffer.h: Include <time.h>, for time_t.
4816 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4817
109e28d0
PE
4818 Fix minor problems found by static checking.
4819
60737f02
PE
4820 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4821
4b66faf3
PE
4822 Make identifiers static if they are not used in other modules.
4823 * data.c (Qcompiled_function, Qframe, Qvector):
4824 * image.c (QimageMagick, Qsvg):
4825 * minibuf.c (Qmetadata):
4826 * window.c (resize_window_check, resize_root_window): Now static.
4827 * window.h (resize_window_check, resize_root_window): Remove decls.
4828
109e28d0
PE
4829 * window.c (window_deletion_count, delete_deletable_window):
4830 Remove; unused.
46a4ce9e
PE
4831 (window_body_lines): Now static.
4832 (Fdelete_other_windows_internal): Mark vars as initialized.
4833 Make sure 'resize_failed' is initialized.
4834 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4835 (resize_window_apply): Remove unused local.
4836 * window.h (delete_deletable_window): Remove decl.
4837
109e28d0 4838 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4839 (imagemagick_load_image): Fix pointer signedness problem by changing
4840 last arg from unsigned char * to char *. All uses changed.
4841 Also, fix a local for similar reasons.
4842 Remove unused locals. Remove locals to avoid shadowing.
4843 (fn_rsvg_handle_free): Remove; unused.
4844 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4845 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4846
3f754b86
PE
4847 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4848
2547adb1
CY
48492011-06-10 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * image.c (gif_load): Fix omitted cast error introduced by
4852 2011-06-06 change.
4853
2c8e37d4
MR
48542011-06-10 Martin Rudalics <rudalics@gmx.at>
4855
4856 * window.h (resize_proportionally, orig_total_lines)
4857 (orig_top_line): Remove from window structure.
4858 (set_window_height, set_window_width, change_window_heights)
4859 (Fdelete_window): Remove prototypes.
4860 (resize_frame_windows): Remove duplicate declaration.
4861
440a42e3
EZ
48622011-06-10 Eli Zaretskii <eliz@gnu.org>
4863
4864 * window.h (resize_frame_windows, resize_window_check)
4865 (delete_deletable_window, resize_root_window)
4866 (resize_frame_windows): Declare prototypes.
4867
4868 * window.c (resize_window_apply): Make definition be "static" to
4869 match the prototype.
4870
562dd5e9
MR
48712011-06-10 Martin Rudalics <rudalics@gmx.at>
4872
4873 * window.c: Remove declarations of Qwindow_size_fixed,
4874 window_min_size_1, window_min_size_2, window_min_size,
4875 size_window, window_fixed_size_p, enlarge_window, delete_window.
4876 Remove static from declaration of Qdelete_window, it's
4877 temporarily needed by Fbury_buffer.
4878 (replace_window): Don't assign orig_top_line and
4879 orig_total_lines.
4880 (Fdelete_window, delete_window): Remove. Window deletion is
4881 handled by window.el.
640c8776
SM
4882 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4883 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4884 (Fdelete_other_windows): Remove. Deleting other windows is
4885 handled by window.el.
4886 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4887 handled in window.el.
4888 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4889 Window minimum sizes are handled in window.el.
4890 (shrink_windows, size_window, set_window_height)
4891 (set_window_width, change_window_heights, window_height)
4892 (window_width, CURBEG, CURSIZE, enlarge_window)
4893 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4894 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4895 handled in window.el.
4896 (make_dummy_parent): Rename to make_parent_window and give it a
4897 second argument horflag.
4898 (make_window): Don't set resize_proportionally any more.
4899 (Fsplit_window): Remove. Windows are split in window.el.
4900 (save_restore_action, save_restore_orig_size)
4901 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4902 Resize mini windows in window.el.
4903 (grow_mini_window, shrink_mini_window): Implement by calling
4904 Qresize_root_window_vertically, resize_window_check and
4905 resize_window_apply.
640c8776
SM
4906 (saved_window, Fset_window_configuration, save_window_save):
4907 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4908 resize_proportionally.
4909 (window_min_height, window_min_width): Move to window.el.
4910 (keys_of_window): Move bindings for delete-other-windows,
4911 split-window, delete-window and enlarge-window to window.el.
4912
4913 * buffer.c: Temporarily extern Qdelete_window.
4914 (Fbury_buffer): Temporarily call Qdelete_window instead of
4915 Fdelete_window (Fbury_buffer will move to window.el soon).
4916
4917 * frame.c (set_menu_bar_lines_1): Remove code handling
4918 orig_top_line and orig_total_lines.
4919
4920 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4921 set_window_height but set heights directly.
4922 (change_frame_size_1): Use resize_frame_windows.
4923
4924 * xdisp.c (init_xdisp): Don't use set_window_height but set
4925 heights directly.
4926
640c8776
SM
4927 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4928 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4929 run_window_configuration_change_hook.
4930
4931 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4932 instead of change_window_heights and run
4933 run_window_configuration_change_hook.
4934
1a13852e
MR
49352011-06-09 Martin Rudalics <rudalics@gmx.at>
4936
4937 * window.c (replace_window): Rename second argument REPLACEMENT to
4938 NEW. New third argument SETFLAG. Rewrite.
4939 (delete_window, make_dummy_parent): Call replace_window with
4940 third argument 1.
4941 (window_list_1): Move down in code.
4942 (run_window_configuration_change_hook): Move set_buffer part
4943 before select_frame_norecord part in order to unwind correctly.
4944 Rename count1 to count.
4945 (recombine_windows, delete_deletable_window, resize_root_window)
4946 (Fdelete_other_windows_internal)
4947 (Frun_window_configuration_change_hook, make_parent_window)
4948 (resize_window_check, resize_window_apply, Fresize_window_apply)
4949 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4950 (Fdelete_window_internal, Fresize_mini_window_internal):
4951 New functions.
1a13852e
MR
4952 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4953
f3d1777e
MR
49542011-06-08 Martin Rudalics <rudalics@gmx.at>
4955
496e208e
MR
4956 * window.h (window): Add some new members to window structure -
4957 normal_lines, normal_cols, new_total, new_normal, clone_number,
4958 splits, nest, prev_buffers, next_buffers.
4959 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4960 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4961
f3d1777e
MR
4962 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4963 Remove.
496e208e
MR
4964 (make_dummy_parent): Set new members of windows structure.
4965 (make_window): Move down in code. Handle new members of window
4966 structure.
4967 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4968 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4969 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4970 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4971 (Fset_window_next_buffers, Fset_window_clone_number):
4972 New functions.
496e208e
MR
4973 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4974 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4975 Doc-string fixes.
4976 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4977 Argument WINDOW can be now internal window too.
4978 (Fwindow_use_time): Move up in code.
4979 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4980 Rewrite doc-string.
4981 (Fset_window_configuration, saved_window)
4982 (Fcurrent_window_configuration, save_window_save): Handle new
4983 members of window structure.
b9e809c2
MR
4984 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4985 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4986 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4987 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4988 Qget_mru_window, Qresize_root_window,
4989 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4990 Qauto_buffer_name; staticpro them.
f3d1777e 4991
abde8f8c
MR
49922011-06-07 Martin Rudalics <rudalics@gmx.at>
4993
4994 * window.c (Fwindow_total_size, Fwindow_left_column)
4995 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4996 (Fwindow_list_1): New functions.
4997 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4998 (Fwindow_width, Fscroll_left, Fscroll_right):
4999 Use window_body_cols instead of window_box_text_cols.
5000 (delete_window, Fset_window_configuration):
5001 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5002 (delete_all_subwindows): Take a window as argument and not a
5003 structure. Rewrite.
190b47e6
MR
5004 (window_loop): Remove handling of GET_LRU_WINDOW and
5005 GET_LARGEST_WINDOW.
5006 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5007
5008 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5009 window_box_text_cols. delete_all_subwindows now takes a
5010 Lisp_Object as argument.
abde8f8c 5011
640c8776
SM
5012 * indent.c (compute_motion, Fcompute_motion):
5013 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5014
fa8a67e6
MR
5015 * frame.c (delete_frame): Call delete_all_subwindows with root
5016 window as argument.
5017
a54e3482
DC
50182011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5019
5020 * fns.c (Fputhash): Document return value.
5021
60002bf5
CY
50222011-06-06 Chong Yidong <cyd@stupidchicken.com>
5023
5024 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5025
0c671da6 50262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5027
b862a52a 5028 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5029
be44ca6c
PE
5030 Check for overflow when converting integer to cons and back.
5031 * charset.c (Fdefine_charset_internal, Fdecode_char):
5032 Use cons_to_unsigned to catch overflow.
5033 (Fencode_char): Use INTEGER_TO_CONS.
5034 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5035 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5036 * data.c (long_to_cons, cons_to_long): Remove.
5037 (cons_to_unsigned, cons_to_signed): New functions.
5038 These signal an error for invalid or out-of-range values.
5039 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5040 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5041 * font.c (Ffont_variation_glyphs):
5042 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5043 * lisp.h: Include <intprops.h>.
5044 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5045 (cons_to_signed, cons_to_unsigned): New decls.
5046 (long_to_cons, cons_to_long): Remove decls.
5047 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5048 (Fprimitive_undo): Use CONS_TO_INTEGER.
5049 * xfns.c (Fx_window_property): Likewise.
5050 * xselect.c: Include <limits.h>.
5051 (x_own_selection, selection_data_to_lisp_data):
5052 Use INTEGER_TO_CONS.
5053 (x_handle_selection_request, x_handle_selection_clear)
5054 (x_get_foreign_selection, Fx_disown_selection_internal)
5055 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5056 (lisp_data_to_selection_data): Use cons_to_unsigned.
5057 (x_fill_property_data): Use cons_to_signed.
5058 Report values out of range.
5059
d1f3d2af
PE
5060 Check for buffer and string overflow more precisely.
5061 * buffer.h (BUF_BYTES_MAX): New macro.
5062 * lisp.h (STRING_BYTES_MAX): New macro.
5063 * alloc.c (Fmake_string):
5064 * character.c (string_escape_byte8):
5065 * coding.c (coding_alloc_by_realloc):
5066 * doprnt.c (doprnt):
5067 * editfns.c (Fformat):
5068 * eval.c (verror):
5069 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5070 since they may not be the same number.
5071 * editfns.c (Finsert_char):
5072 * fileio.c (Finsert_file_contents):
5073 Likewise for BUF_BYTES_MAX.
5074
dd52fcea
PE
5075 * image.c: Use ptrdiff_t, not int, for sizes.
5076 (slurp_file): Switch from int to ptrdiff_t.
5077 All uses changed.
5078 (slurp_file): Check that file size fits in both size_t (for
5079 malloc) and ptrdiff_t (for sanity and safety).
5080
7f9bbdbb
PE
5081 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5082 if b->modtime has its maximal value.
5083
dfe18f82
PE
5084 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5085
84acfcf0
PE
5086 Don't assume time_t can fit into int.
5087 * buffer.h (struct buffer.modtime): Now time_t, not int.
5088 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5089 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5090
ccd9a01a
PE
5091 Minor fixes for signed vs unsigned integers.
5092 * character.h (MAYBE_UNIFY_CHAR):
5093 * charset.c (maybe_unify_char):
5094 * keyboard.c (read_char, reorder_modifiers):
5095 XINT -> XFASTINT, since the integer must be nonnegative.
5096 * ftfont.c (ftfont_spec_pattern):
5097 * keymap.c (access_keymap, silly_event_symbol_error):
5098 XUINT -> XFASTINT, since the integer must be nonnegative.
5099 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5100 since it makes no difference and we prefer signed.
5101 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5102 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5103 nonnegative.
5104
d6d100dd
SM
51052011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5106
5107 * window.h (Fwindow_frame): Declare.
5108
2b6148e4
PE
51092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5110
5111 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5112 (SPARE_MEMORY): Always define.
5113 (LARGE_REQUEST): Remove.
5114 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5115
f230ecc9
MR
51162011-06-06 Martin Rudalics <rudalics@gmx.at>
5117
727e958e
MR
5118 * lisp.h: Move EXFUNS for Fframe_root_window,
5119 Fframe_first_window and Fset_frame_selected_window to window.h.
5120
5121 * window.h: Move EXFUNS for Fframe_root_window,
5122 Fframe_first_window and Fset_frame_selected_window here from
5123 lisp.h.
5124
5125 * frame.c (Fwindow_frame, Fframe_first_window)
5126 (Fframe_root_window, Fframe_selected_window)
5127 (Fset_frame_selected_window): Move to window.c.
5128 (Factive_minibuffer_window): Move to minibuf.c.
5129 (Fother_visible_frames_p): New function.
5130
5131 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5132
f230ecc9
MR
5133 * window.c (decode_window, decode_any_window): Move up in code.
5134 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5135 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5136 (Fwindow_buffer): Move up and rewrite doc-string.
5137 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5138 (Fwindow_prev): New functions.
727e958e
MR
5139 (Fwindow_frame): Move here from frame.c. Accept any window as
5140 argument.
5141 (Fframe_root_window, Fframe_first_window)
5142 (Fframe_selected_window): Move here from frame.c. Accept frame
5143 or arbitrary window as argument. Update doc-strings.
5144 (Fminibuffer_window): Move up in code.
5145 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5146 (Fset_frame_selected_window): Move here from frame.c.
5147 Marginal rewrite.
727e958e
MR
5148 (Fselected_window, select_window, Fselect_window): Move up in
5149 code. Minor doc-string fixes.
f230ecc9 5150
4d09bcf6
PE
51512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5152
5153 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5154 Do not assume that spare memory exists; that assumption is valid
5155 only if SYSTEM_MALLOC.
5156 (LARGE_REQUEST): New macro, so that the issue of large requests
5157 is separated from the issue of spare memory.
5158
810928a2
AS
51592011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5160
172418ad
AS
5161 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5162 format. (Bug#8806)
5163
43f862f7
AS
5164 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5165
810928a2
AS
5166 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5167 before statements.
5168
a059fe24
JD
51692011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5170
5171 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5172
5173 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5174
5175 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5176 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5177
989bf368
JB
51782011-06-05 Juanma Barranquero <lekktu@gmail.com>
5179
5180 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5181
4b80f674
CY
51822011-06-04 Chong Yidong <cyd@stupidchicken.com>
5183
5184 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5185 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5186 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5187 New error handlers.
4b80f674
CY
5188 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5189 Obey Vx_select_enable_clipboard_manager. Catch errors in
5190 x_clipboard_manager_save (Bug#8779).
5191 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5192 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5193
99a33b77 51942011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5195
5196 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5197
99a33b77 51982011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5199
5200 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5201 in the current matrix if keep_current_p is non-zero.
5202
8264569d
EZ
52032011-06-04 Eli Zaretskii <eliz@gnu.org>
5204
5205 * bidi.c (bidi_level_of_next_char): Fix last change.
5206
57f97249
EZ
52072011-06-03 Eli Zaretskii <eliz@gnu.org>
5208
fec2107c 5209 Support bidi reordering of text covered by display properties.
57f97249 5210
fec2107c
EZ
5211 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5212 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5213 (bidi_cache_search, bidi_cache_iterator_state)
5214 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5215 (bidi_level_of_next_char, bidi_move_to_visually_next):
5216 Support character positions inside a run of characters covered by a
fec2107c
EZ
5217 display string.
5218 (bidi_paragraph_init, bidi_resolve_explicit_1)
5219 (bidi_level_of_next_char): Call bidi_fetch_char and
5220 bidi_fetch_char_advance instead of FETCH_CHAR and
5221 FETCH_CHAR_ADVANCE.
5222 (bidi_init_it): Initialize new members.
5223 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5224 definitions.
5225 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5226 instead of using explicit *_CHAR codes.
d6d100dd
SM
5227 (bidi_resolve_explicit, bidi_resolve_weak):
5228 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5229 bidirectional text is supported only in multibyte buffers.
5230 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5231 it to initialize the frame_window_p member of struct bidi_it.
5232 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5233 (bidi_resolve_explicit, bidi_resolve_weak)
5234 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5235 bidi_it->nchars is non-positive.
5236 (bidi_level_of_next_char): Don't try to lookup the cache for the
5237 next/previous character if nothing is cached there yet, or if we
5238 were just reseat()'ed to a new position.
c40e2fb2 5239
0e14fe90
EZ
5240 * xdisp.c (set_cursor_from_row): Set start and stop points
5241 according to the row's direction when priming the loop that looks
5242 for the glyph on which to display cursor.
5243 (single_display_spec_intangible_p): Function deleted.
5244 (display_prop_intangible_p): Reimplement to call
5245 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5246 Accept 3 additional arguments needed by handle_display_spec.
5247 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5248 values: lists, `(when COND...)' forms, etc.
5249 (single_display_spec_string_p): Support property values that are
5250 lists with the argument STRING its top-level element.
5251 (display_prop_string_p): Fix the condition for processing a
5252 property that is a list to be consistent with handle_display_spec.
fec2107c 5253 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5254 last portion of handle_display_prop.
5255 (compute_display_string_pos): Accept additional argument
5256 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5257 value of a `display' property is a "replacing spec".
5258 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5259 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5260 the display property, but just return a value indicating whether
5261 the display property will replace the characters it covers.
5262 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5263 frame_window_p members of struct bidi_it.
d6d100dd
SM
5264 (compute_display_string_pos, compute_display_string_end):
5265 New functions.
fec2107c
EZ
5266 (push_it): Accept second argument POSITION, where pop_it should
5267 jump to continue iteration.
5268 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5269
fec2107c
EZ
5270 * keyboard.c (adjust_point_for_property): Adjust the call to
5271 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5272
5273 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5274 (bidi_init_it): Update prototypes.
5275 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5276 (compute_display_string_pos, compute_display_string_end):
5277 Declare prototypes.
fec2107c
EZ
5278 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5279 EMACS_INT.
fc6f18ce 5280
40087514 52812011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5282
57f53182
PE
5283 Malloc failure behavior now depends on size of allocation.
5284 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5285 * lisp.h: Change signatures accordingly.
5286 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5287 All callers changed. (Bug#8762)
5288
5289 * gnutls.c: Use Emacs's memory allocators.
5290 Without this change, the gnutls library would invoke malloc etc.
5291 directly, which causes problems on non-SYNC_INPUT hosts, and which
5292 runs afoul of improving memory_full behavior. (Bug#8761)
5293 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5294 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5295 xfree instead of the default malloc, realloc, free.
5296 (Fgnutls_boot): No need to check for memory allocation failure,
5297 since xmalloc does that for us.
5298
ac32cd99 5299 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5300 * category.c (hash_get_category_set):
5301 * ccl.c (ccl_driver):
5302 * charset.c (Fdefine_charset_internal):
5303 * charset.h (struct charset.hash_index):
5304 * composite.c (get_composition_id, gstring_lookup_cache)
5305 (composition_gstring_put_cache):
5306 * composite.h (struct composition.hash_index):
5307 * dispextern.h (struct image.hash):
5308 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5309 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5310 (hashfn_equal, hashfn_user_defined, make_hash_table)
5311 (maybe_resize_hash_table, hash_lookup, hash_put)
5312 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5313 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5314 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5315 * image.c (make_image, search_image_cache, lookup_image)
5316 (xpm_put_color_table_h):
5317 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5318 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5319 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5320 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5321 * alloc.c (allocate_vectorlike):
5322 Check for overflow in vector size calculations.
5323 * ccl.c (ccl_driver):
5324 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5325 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5326 need to be updated by these changes.
40087514
PE
5327 * fns.c (make_hash_table, maybe_resize_hash_table):
5328 Check for integer overflow with large hash tables.
0de4bb68
PE
5329 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5330 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5331 (SXHASH_REDUCE): New macro.
5332 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5333 Use it instead of discarding useful hash info with large hash values.
5334 (sxhash_float): New function.
5335 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5336 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5337 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5338 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5339 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5340 Adjust signatures to match updated version of code.
5341 (consing_since_gc): Now EMACS_INT, since a single hash table can
5342 use more than INT_MAX bytes.
5343
698d32e2
DN
53442011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5345
5346 Make it possible to build with GCC-4.6+ -O2 -flto.
5347
5348 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5349
fd6fa53f
SM
53502011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5351
5352 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5353 Call minibuffer-inactive-mode.
5354
864db017
JB
53552011-05-31 Juanma Barranquero <lekktu@gmail.com>
5356
5357 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5358 Update dependencies.
5359
2ad0baf4
DN
53602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5361
5362 * data.c (init_data): Remove code for UTS, this system is not
5363 supported anymore.
5364
4fcc2638
DN
53652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5366
5367 Don't force ./temacs to start in terminal mode.
5368
5369 * frame.c (make_initial_frame): Initialize faces in all cases, not
5370 only when CANNOT_DUMP is defined.
5371 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5372
c56e0fd5
DN
53732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5374
5375 * dispnew.c (add_window_display_history): Use const for the string
5376 pointer. Remove declaration, not needed.
5377
333d54da 53782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5379
55d4c1b2 5380 Use 'inline', not 'INLINE'.
333d54da 5381 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5382 * alloc.c, fontset.c (INLINE): Remove.
5383 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5384 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5385 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5386 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5387 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5388
738db178
DN
53892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5390
5391 Make it possible to run ./temacs.
5392
5393 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5394 syms_of_callproc does the same thing. Remove test for
5395 "initialized", do it in the caller.
5396 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5397
620c53a6
SM
53982011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5399
5400 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5401 (read_minibuf): Use get_minibuffer.
5402 (syms_of_minibuf): Use DEFSYM.
5403 (Qmetadata): New var.
5404 * data.c (Qbuffer): Don't make it static.
5405 (syms_of_data): Use DEFSYM.
5406
e003a292
PE
54072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5408
5409 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5410 (CCL_CODE_MIN): New macro.
5411
ed008a6d
PE
54122011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5413
3687c2ef
PE
5414 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5415
ed008a6d
PE
5416 * eval.c (Qdebug): Now static.
5417 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5418 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5419 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5420
d66c4c7c
CY
54212011-05-29 Chong Yidong <cyd@stupidchicken.com>
5422
5423 * image.c: Various fixes to ImageMagick code comments.
5424 (Fimagemagick_types): Doc fix.
5425
5fbc2025
PE
54262011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5427
0196f88a
PE
5428 Minor fixes prompted by GCC 4.6.0 warnings.
5429
5430 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5431
5fbc2025
PE
5432 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5433 (x_clipboard_manager_save_all): Move extern decl to ...
5434 * xterm.h: ... here, so that it can be checked for consistency.
5435
1dd3c2d9
CY
54362011-05-29 Chong Yidong <cyd@stupidchicken.com>
5437
5438 * xselect.c (x_clipboard_manager_save_frame)
5439 (x_clipboard_manager_save_all): New functions.
5440 (Fx_clipboard_manager_save): Lisp function deleted.
5441
5442 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5443 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5444
5445 * xterm.h: Update prototype.
5446
5ba6571d
WX
54472011-05-28 William Xu <william.xwl@gmail.com>
5448
5449 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5450 exiting (Bug#8239).
5451
3eaff834
JM
54522011-05-28 Jim Meyering <meyering@redhat.com>
5453
e1900994 5454 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5455 * fns.c (to_uchar): Define.
5456 (crypto_hash_function): Use it to convert some newly-signed
5457 variables to unsigned, to avoid sign-extension bugs. For example,
5458 without this change, (md5 "truc") would evaluate to
5459 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5460 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5461 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5462
0f6990a7
PE
54632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5464
5465 Integer overflow fixes.
c8a9ca5a 5466
08686060
PE
5467 * dbusbind.c: Serial number integer overflow fixes.
5468 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5469 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5470 to hold a serial number that is too large for a fixnum.
5471 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5472 Check for serial numbers out of range. Decode any serial number
59568bf0 5473 that was so large that it became a float. (Bug#8722)
08686060 5474
2d1fc3c7
PE
5475 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5476 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5477 Use XFASTINT rather than XUINT when numbers are nonnegative.
5478 (xd_append_arg, Fdbus_method_return_internal):
5479 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5480 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5481 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5482 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5483 (Bug#8722)
2d1fc3c7 5484
c8a9ca5a
PE
5485 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5486
519e1d69
PE
5487 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5488
30569699
PE
5489 ccl: add integer overflow checks
5490 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5491 (IN_INT_RANGE): New macros.
5492 (ccl_driver): Use them to check for integer overflow when
5493 decoding a CCL program. Many of the new checks are whether XINT (x)
5494 fits in int; it doesn't always, on 64-bit hosts. The new version
5495 doesn't catch all possible integer overflows, but it's an
847044ea 5496 improvement. (Bug#8719)
30569699 5497
c11285dc
PE
5498 * alloc.c (make_event_array): Use XINT, not XUINT.
5499 There's no need for unsigned here.
5500
fdccd48e
PE
5501 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5502 This follows up to the 2011-05-06 change that substituted uintptr_t
5503 for EMACS_INT. This case wasn't caught back then.
5504
37910ab2
PE
5505 Rework Fformat to avoid integer overflow issues.
5506 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5507 now (part of C89). Include <verify.h>.
5508 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5509 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5510 (Fformat): Avoid the prepass trying to compute sizes; it was only
5511 approximate and thus did not catch overflow reliably. Instead, walk
5512 through the format just once, formatting and computing sizes as we go,
5513 checking for integer overflow at every step, and allocating a larger
5514 buffer as needed. Keep track separately whether the format is
5515 multibyte. Keep only the most-recently calculated precision, rather
5516 than them all. Record whether each argument has been converted to
5517 string. Use EMACS_INT, not int, for byte and char and arg counts.
5518 Support field widths and precisions larger than INT_MAX. Avoid
5519 sprintf's undefined behavior with conversion specifications such as %#d
5520 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5521 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5522 formatting out-of-range floating point numbers with int
9173deec 5523 formats. (Bug#8668)
37910ab2 5524
2e6578fb
PE
5525 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5526
0ae6bdee
PE
5527 * data.c: Avoid integer truncation in expressions involving floats.
5528 * data.c: Include <intprops.h>.
5529 (arith_driver): When there's an integer overflow in an expression
5530 involving floating point, convert the integers to floating point
5531 so that the resulting value does not suffer from catastrophic
5532 integer truncation. For example, on a 64-bit host (* 4
5533 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5534 Do not rely on undefined behavior after integer overflow.
5535
de883a70
PE
5536 merge count_size_as_multibyte, parse_str_to_multibyte
5537 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5538 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5539 Check for integer overflow.
5540 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5541 since it's now a duplicate of the other. This is more of
5542 a character than a buffer op, so better that it's in character.c.
5543 * fns.c, print.c: Adjust to above changes.
5544
2ff916cb
PE
55452011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5546
5547 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5548
f1b54466
PE
55492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5550
fb1ac845
PE
5551 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5552 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5553 (x_clipboard_manager_save): Now static.
5554 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5555
f1b54466
PE
5556 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5557 (crypto_hash_function): Now static.
5558 Fix pointer signedness problems. Avoid unnecessary initializations.
5559
a9f737ee
CY
55602011-05-27 Chong Yidong <cyd@stupidchicken.com>
5561
5562 * termhooks.h (Vselection_alist): Make it terminal-local.
5563
5564 * terminal.c (create_terminal): Initialize it.
5565
5566 * xselect.c: Support for clipboard managers.
5567 (Vselection_alist): Move to termhooks.h as terminal-local var.
5568 (LOCAL_SELECTION): New macro.
5569 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5570 (symbol_to_x_atom): Remove gratuitous arg.
5571 (x_handle_selection_request, lisp_data_to_selection_data)
5572 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5573 (x_own_selection, x_get_local_selection, x_convert_selection):
5574 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5575 (some_frame_on_display): Delete unused function.
5576 (Fx_own_selection_internal, Fx_get_selection_internal)
5577 (Fx_disown_selection_internal, Fx_selection_owner_p)
5578 (Fx_selection_exists_p): New optional frame arg.
5579 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5580 (x_handle_selection_clear): Don't treat other terminals with the
5581 same keyboard specially. Use the terminal-local Vselection_alist.
5582 (x_clear_frame_selections): Use Frun_hook_with_args.
5583
5584 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5585
5586 * xterm.h: Add support for those atoms.
5587
e067f0c1
CY
55882011-05-26 Chong Yidong <cyd@stupidchicken.com>
5589
5590 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5591 (converted_selections, conversion_fail_tag): New global variables.
5592 (x_selection_request_lisp_error): Free the above.
5593 (x_get_local_selection): Remove unnecessary code.
5594 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5595 of converted selections stored in converted_selections.
5596 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5597 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5598 (x_convert_selection): New function.
5599 (x_handle_selection_event): Simplify.
5600 (x_get_foreign_selection): Don't ignore incoming requests while
5601 waiting for an answer; this will fail when we implement
5602 SAVE_TARGETS, and seems unnecessary anyway.
5603 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5604 (Vx_sent_selection_functions): Doc fix.
5605
0f4aebc0
LL
56062011-05-26 Leo Liu <sdl.web@gmail.com>
5607
5608 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5609
e61124cd
YM
56102011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5611
5612 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5613
5614 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5615 for fringe update if it has periodic bitmap.
ac389d0c 5616 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5617 and fringe_bitmap_periodic_p.
5618
5619 * fringe.c (get_fringe_bitmap_data): New function.
5620 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5621 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5622 row. Mark glyph row for fringe update if periodicity changed.
5623
5624 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5625 for fringe update unless it has periodic bitmap.
5626
f16d9837
KH
56272011-05-25 Kenichi Handa <handa@m17n.org>
5628
5629 * xdisp.c (get_next_display_element): Set correct it->face_id for
5630 a static composition.
5631
e1b90ef6
LL
56322011-05-24 Leo Liu <sdl.web@gmail.com>
5633
5634 * deps.mk (fns.o):
5635 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5636
5637 * fns.c (crypto_hash_function, Fsha1): New function.
5638 (Fmd5): Use crypto_hash_function.
5639 (syms_of_fns): Add Ssha1.
5640
7400048f
PE
56412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5642
5643 * gnutls.c: Remove unused macros.
5644 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5645 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5646 Remove macros that are defined and never used.
5647 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5648
abb71cf4
CY
56492011-05-22 Chong Yidong <cyd@stupidchicken.com>
5650
5651 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5652 (Fx_get_selection_internal): Minor cleanup.
5653 (Fx_own_selection_internal): Rename arguments for consistency with
5654 select.el.
5655
6307db39
PE
56562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5657
5658 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5659
f3d4e0a4
CY
56602011-05-22 Chong Yidong <cyd@stupidchicken.com>
5661
5662 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5663
4d8ade89
YM
56642011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5665
5666 * dispnew.c (scrolling_window): Don't exclude the case that the
5667 last enabled row in the desired matrix touches the bottom boundary.
5668
32078c8d
GM
56692011-05-21 Glenn Morris <rgm@gnu.org>
5670
5671 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5672 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5673 and add some more files.
32078c8d 5674
7285dc67
EZ
56752011-05-20 Eli Zaretskii <eliz@gnu.org>
5676
5677 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5678 report_file_error introduced by the change from 2011-05-07.
5679
89d1bd22
PE
56802011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5681
5682 * systime.h (Time): Define only if emacs is defined.
5683 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5684 where the include path doesn't have X11/X.h by default. See
5685 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5686
e23640bb 56872011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5688
5689 * composite.c (find_automatic_composition): Fix previous change.
5690
b9704ad9
GM
56912011-05-20 Glenn Morris <rgm@gnu.org>
5692
5693 * lisp.mk: New file, split from Makefile.in.
5694 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5695 (shortlisp): Remove.
5696 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5697
4a720484
GM
56982011-05-19 Glenn Morris <rgm@gnu.org>
5699
5700 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5701 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5702 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5703 (lisp): Set the order to that of loadup.el.
5704 (shortlisp): Make it a copy of $lisp.
5705 (SOME_MACHINE_LISP): Remove.
5706 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5707 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5708
a28d4396
KH
57092011-05-18 Kenichi Handa <handa@m17n.org>
5710
5711 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5712 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5713 (find_automatic_composition): Mostly rewrite for efficiency.
5714
a2b1fa8e
JB
57152011-05-18 Juanma Barranquero <lekktu@gmail.com>
5716
5717 * makefile.w32-in: Update dependencies.
5718
8e1f5610
CS
57192011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5720
5721 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5722 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5723
7025ee00 57242011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5725
cdfa6eab
PE
5726 Fix some integer overflow issues, such as string length overflow.
5727
06d6db33
PE
5728 * insdel.c (count_size_as_multibyte): Check for string overflow.
5729
2b4560a8
PE
5730 * character.c (lisp_string_width): Check for string overflow.
5731 Use EMACS_INT, not int, for string indexes and lengths; in
5732 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5733 the resulting string length overflows an EMACS_INT; instead,
5734 report a string overflow if no precision given. When checking for
5735 precision exhaustion, use a check that cannot possibly have
5736 integer overflow. (Bug#8675)
5737 * character.h (lisp_string_width): Adjust to new signature.
5738
cb93f9be
PE
5739 * alloc.c (string_overflow): New function.
5740 (Fmake_string): Use it. This doesn't change behavior, but saves
5741 a few bytes and will simplify future changes.
5742 * character.c (string_escape_byte8): Likewise.
5743 * lisp.h (string_overflow): New decl.
5744
1a1f3366
PE
5745 Fixups, following up to the user-interface timestamp change.
5746 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5747 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5748 * msdos.c (mouse_get_pos): Likewise.
5749 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5750 * w32gui.h (Time): Define by including "systime.h" rather than by
5751 declaring it ourselves. (Bug#8664)
5752
d4e3e4d3
PE
5753 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5754 * image.c (clear_image_cache): Likewise.
5755
f6a24d19
PE
5756 * term.c (term_mouse_position): Don't assume time_t wraparound.
5757
08dc5ae6
PE
5758 Be more systematic about user-interface timestamps.
5759 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5760 and sometimes 'EMACS_UINT', to represent these timestamps.
5761 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5762 This makes the code easier to follow, and makes it easier to catch
5763 integer overflow bugs such as Bug#8664.
5764 * frame.c (Fmouse_position, Fmouse_pixel_position):
5765 Use Time, not unsigned long, for user-interface timestamps.
5766 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5767 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5768 * keyboard.h (last_event_timestamp): Likewise.
5769 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5770 * menu.h (xmenu_show): Likewise.
5771 * term.c (term_mouse_position): Likewise.
5772 * termhooks.h (struct input_event.timestamp): Likewise.
5773 (struct terminal.mouse_position_hook): Likewise.
5774 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5775 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5776 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5777 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5778 what it was before.
5779 * menu.h, termhooks.h: Include "systime.h", for Time.
5780
8e55734a
PE
5781 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5782 Don't assume that the difference between two unsigned long values
5783 can fit into an integer. At this point, we know button_down_time
5784 <= event->timestamp, so the difference must be nonnegative, so
5785 there's no need to cast the result if double-click-time is
5786 nonnegative, as it should be; check that it's nonnegative, just in
5787 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5788 apart (about 25 days). (Bug#8664)
8e55734a 5789
841f1b75 5790 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5791 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5792
3e26f69c
PE
5793 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5794 that always fit in int. Use a sentinel instead of a counter, to
5795 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5796 * frame.h (struct frame): Use int for menu_bar_items_used
5797 instead of EMACS_INT, since it always fits in int.
3e26f69c 5798
5cc152c0
PE
5799 * menu.c (grow_menu_items): Check for int overflow.
5800
d89eb65e
PE
5801 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5802
5235bd3e
PE
5803 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5804 Before, the code was not consistent. These values cannot exceed
5805 2**31 - 1 so there's no need to make them unsigned.
5806 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5807 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5808 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5809 as modifiers.
5810 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5811
bc827e23
PE
5812 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5813 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5814 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5815 presumably because the widths might not match.
5816
78eb494e
PE
5817 * window.c (size_window): Avoid needless test at loop start.
5818
04f2d78b
CB
58192011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5820
5821 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5822
d2fc7e3d 58232011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5824
5825 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5826
d2fc7e3d 58272011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5828
5829 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5830 `width' to `bar_area_x' and `bar_area_width', respectively.
5831 (x_scroll_run): Take account of fringe background extension.
5832
04f2d78b
CB
5833 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5834 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5835 `bar_area_width', respectively.
5836 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5837 background extension.
5838
79b70037
GM
58392011-05-10 Jim Meyering <meyering@redhat.com>
5840
5841 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5842
2f142cc5
JB
58432011-05-10 Juanma Barranquero <lekktu@gmail.com>
5844
5845 * image.c (Finit_image_library): Return t for built-in image types,
5846 like pbm and xbm. (Bug#8640)
5847
57679c86
AS
58482011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5849
5850 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5851
888c9e86
EZ
58522011-05-07 Eli Zaretskii <eliz@gnu.org>
5853
b0512a1d
EZ
5854 * w32console.c (Fset_screen_color): Doc fix.
5855 (Fget_screen_color): New function.
5856 (syms_of_ntterm): Defsubr it.
5857
7285dc67
EZ
5858 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5859 unlink the temporary file if Fcall_process didn't create it in the
5860 first place.
5861 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5862 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5863 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5864 cue to call_process_cleanup not to close that handle.
5865
4d3fcc8e
BK
58662011-05-07 Ben Key <bkey76@gmail.com>
5867
5868 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5869 one of two shell specific rules, either bootstrap-temacs-CMD or
5870 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5871 to the previous implementation of the bootstrap-temacs rule.
5872 The bootstrap-temacs-CMD rule is similar to the previous
5873 implementation of the bootstrap-temacs rule except that it
5874 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5875 variable.
5876
5877 These changes, along with some changes to nt/configure.bat,
5878 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5879 earlier fix to add support for --cflags and --ldflags options
5880 that include quotes so that it works whether make uses cmd or
5881 sh as the shell.
5882
b4289b64
MA
58832011-05-06 Michael Albinus <michael.albinus@gmx.de>
5884
5885 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5886 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5887 is a constant.
5888 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5889 a string. Handle both cases.
5890 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5891 (Fdbus_register_method): Use Qinvalid_function.
5892
af4c0e28
JB
58932011-05-06 Juanma Barranquero <lekktu@gmail.com>
5894
5895 * makefile.w32-in: Update dependencies.
5896 (LISP_H): Add inttypes.h and stdin.h.
5897 (PROCESS_H): Add unistd.h.
5898
c51453d9
EZ
58992011-05-06 Eli Zaretskii <eliz@gnu.org>
5900
5901 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5902 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5903
8ff0ac3c 59042011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5905
4c4b566b
PE
5906 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5907
aab2b9b5
PE
5908 * term.c (vfatal): Remove stray call to va_end.
5909 It's not needed and the C Standard doesn't allow it here anyway.
5910
c378da0b
PE
5911 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5912 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5913
288b08c7
PE
5914 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5915 bytes.
5916
e3601888
PE
5917 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5918
db6c0e74
PE
5919 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5920
dd5963ea
PE
5921 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5922
88c9450f
PE
5923 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5924
2f9442b8
PE
5925 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5926
c032b5f8
PE
5927 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5928 * charset.c (Fdefine_charset_internal): Don't initialize
5929 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5930 32-bit int (Bug#8600).
a108c10b
PE
5931
5932 * lread.c (read_integer): Be more consistent with string-to-number.
5933 Use string_to_number to do the actual conversion; this avoids
5934 rounding errors and fixes some other screwups. Without this fix,
5935 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5936 (digit_to_number): Move earlier, for benefit of read_integer.
5937 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5938 not a digit in any supported base. (Bug#8602)
a108c10b 5939
ad5f9eea
PE
5940 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5941
aec1708a
PE
5942 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5943 to match comment at start of function. This also removes a
5944 GCC warning about overflow in a 32+64-bit port.
5945
47be4ab5
PE
5946 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5947
371cac43
PE
5948 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5949 Reported by Stefan Monnier in
5950 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5951 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5952 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5953
d01a7826
PE
5954 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5955 (EMACS_UINTPTR): Likewise, with uintptr_t.
5956
7fd47d5c
PE
5957 * lisp.h: Prefer 64-bit EMACS_INT if available.
5958 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5959 on 32-bit hosts that have 64-bit int, so that they can access
5960 large files.
122b0c86
PE
5961 However, temporarily disable this change unless the temporary
5962 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5963
8727937b
PE
5964 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5965
8ac068ac
PE
5966 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5967 This removes an assumption that EMACS_INT and long are the same
5968 width as pointers. The assumption is true for Emacs porting targets
5969 now, but we want to make other targets possible.
5970 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5971 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5972 In the rest of the code, change types of integers that hold casted
5973 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5974 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5975 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5976 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5977 No need to cast type when ORing.
5978 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5979 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5980 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5981 assume EMACS_INT is the same width as char *.
5982 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5983 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5984 Remove no-longer-needed casts.
5985 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5986 (xg_tool_bar_help_callback, xg_make_tool_item):
5987 Use EMACS_INTPTR to hold an integer
5988 that will be cast to void *; this can avoid a GCC warning
5989 if EMACS_INT is not the same width as void *.
5990 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5991 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5992 (current_message_1, set_message_1):
5993 Use a local to convert to proper width without a cast.
5994 * xmenu.c (dialog_selection_callback): Likewise.
5995
ede49d71
PE
5996 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5997 Also, don't assume VALBITS / RAND_BITS is less than 5,
5998 and don't rely on undefined behavior when shifting a 1 left into
5999 the sign bit.
6000 * lisp.h (get_random): Change signature to match.
6001
2f30ecd0
PE
6002 * lread.c (hash_string): Use size_t, not int, for hash computation.
6003 Normally we prefer signed values; but hashing is special, because
6004 it's better to use unsigned division on hash table sizes so that
6005 the remainder is nonnegative. Also, size_t is the natural width
6006 for hashing into memory. The previous code used 'int', which doesn't
6007 retain enough info to hash well into very large tables.
6008 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6009
2a866e7b
PE
6010 * dbusbind.c: Don't possibly lose pointer info when converting.
6011 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6012 Use XPNTR rather than XHASH, so that the high-order bits of
6013 the pointer aren't lost when converting through void *.
6014
51639eac
PE
6015 * eval.c (Fautoload): Don't double-shift a pointer.
6016
92394119
PE
6017 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6018
dbdb9a7c
JB
60192011-05-06 Juanma Barranquero <lekktu@gmail.com>
6020
6021 * gnutls.c (DEF_GNUTLS_FN):
6022 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6023
db7a0b4f
AS
60242011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6025
6026 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6027 marker. (Bug#8610)
6028
f7ff1b0f 60292011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6030
6031 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6032 New version that can reserve upto 2GB of heap space.
6033
f7ff1b0f 60342011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6035
6036 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6037
639c109b
TZ
60382011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6039
6040 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6041 `gnutls_certificate_set_x509_key_file'.
6042
d2127135
JB
60432011-05-05 Juanma Barranquero <lekktu@gmail.com>
6044
6045 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6046 Update dependencies.
6047
e968f4f3
JB
60482011-05-04 Juanma Barranquero <lekktu@gmail.com>
6049
6050 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6051 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6052 Remove unused parameter `fildes'.
6053 * process.c (read_process_output, send_process): Don't pass it.
6054
84d358f0
JB
60552011-05-04 Juanma Barranquero <lekktu@gmail.com>
6056
6057 Fix previous change: the library cache is defined in w32.c.
6058 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6059 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6060
0898ca10
JB
60612011-05-04 Juanma Barranquero <lekktu@gmail.com>
6062
6063 Implement dynamic loading of GnuTLS on Windows.
6064
6065 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6066 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6067 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6068 Declare.
6069
6070 * gnutls.c (Qgnutls_dll): Define.
6071 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6072 (gnutls_*): Declare function pointers.
6073 (init_gnutls_functions): New function to initialize function pointers.
6074 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6075 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6076 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6077 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6078 (emacs_gnutls_write, emacs_gnutls_read)
6079 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6080 (Fgnutls_available_p): New function.
6081 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6082 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6083 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6084
6085 * image.c: Include w32.h.
6086 (Vimage_type_cache): Delete.
6087 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6088 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6089 (w32_delayed_load): Move to w32.c.
6090
6091 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6092
6093 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6094 (w32_delayed_load): Move from image.c. When loading a library, record
6095 its filename in the :loaded-from property of the library id.
6096 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6097 Initialize and staticpro them.
6098 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6099
6100 * process.c: Include lisp.h before w32.h, not after.
6101 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6102 instead of gnutls_record_check_pending.
6103
6104 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6105
ff4de4aa
TZ
61062011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6107
6108 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6109 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6110 as passed in.
6111
abe95abb
JD
61122011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6113
6114 * xterm.c (x_set_frame_alpha): Do not set property on anything
6115 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6116
e16e55d4
JB
61172011-05-02 Juanma Barranquero <lekktu@gmail.com>
6118
6119 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6120
bafcf6a5
JB
61212011-05-02 Juanma Barranquero <lekktu@gmail.com>
6122
6123 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6124 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6125 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6126 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6127 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6128 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6129 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6130 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6131 (Qgnutls_bootprop_callbacks_verify): Make static.
6132
e7a6747f
AS
61332011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6134
19ed11ba
AS
6135 * callproc.c: Indentation fixup.
6136
e7a6747f 6137 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6138 (wait_for_termination, interruptible_wait_for_termination):
6139 Move after wait_for_termination_1.
e7a6747f 6140
1ef14cb4
LMI
61412011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6142
6143 * sysdep.c (interruptible_wait_for_termination): New function
6144 which is like wait_for_termination, but allows keyboard
6145 interruptions.
6146
6147 * callproc.c (Fcall_process): Add (:file "file") as an option for
6148 the STDOUT buffer.
6149 (Fcall_process_region): Ditto.
6150
330d880c
EZ
61512011-04-30 Eli Zaretskii <eliz@gnu.org>
6152
8db90b73
EZ
6153 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6154 rather than `XVECTOR (FOO)->size'.
6155
330d880c
EZ
6156 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6157 inttypes.h, as a gnulib replacement is used if it not available in
6158 system headers.
6159
15cbd324
EZ
61602011-04-21 Eli Zaretskii <eliz@gnu.org>
6161
6162 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6163 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6164 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6165
6166 * coding.c (coding_alloc_by_realloc): Error out if destination
6167 will grow beyond MOST_POSITIVE_FIXNUM.
6168 (decode_coding_emacs_mule): Abort if there isn't enough place in
6169 charbuf for the composition carryover bytes. Reserve an extra
6170 space for up to 2 characters produced in a loop.
6171 (decode_coding_iso_2022): Abort if there isn't enough place in
6172 charbuf for the composition carryover bytes.
6173
61742011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6175
ae940cca
EZ
6176 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6177 aborting when %lld or %lll format is passed.
6178 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6179 %llo or %llx format is passed. (Bug#8545)
6180
03ab8921
EZ
6181 * window.c (window_scroll_line_based): Use a marker instead of
6182 simple variables to record original value of point. (Bug#7952)
6183
afda1437
EZ
6184 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6185 produced by %s or %c overflows available buffer space. (Bug#8545)
6186
f76dee0c
PE
61872011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6188
6189 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6190 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6191
fdc5744d
JB
61922011-04-28 Juanma Barranquero <lekktu@gmail.com>
6193
6194 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6195
638f053a
JB
61962011-04-28 Juanma Barranquero <lekktu@gmail.com>
6197
6198 * keyboard.c (Qdelayed_warnings_hook): Define.
6199 (command_loop_1): Run `delayed-warnings-hook'
6200 if Vdelayed_warnings_list is non-nil.
6201 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6202 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6203
d178f871
EZ
62042011-04-28 Eli Zaretskii <eliz@gnu.org>
6205
6206 * doprnt.c (doprnt): Don't return value smaller than the buffer
6207 size if the message was truncated. (Bug#8545).
6208
b124fd93
JB
62092011-04-28 Juanma Barranquero <lekktu@gmail.com>
6210
6211 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6212 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6213
e810457d
PE
62142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6215
6216 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6217
ea51cceb
JB
62182011-04-27 Juanma Barranquero <lekktu@gmail.com>
6219
6220 * makefile.w32-in: Update dependencies.
6221
94dcfacf
EZ
62222011-04-27 Eli Zaretskii <eliz@gnu.org>
6223
6224 Improve `doprnt' and its usage. (Bug#8545)
6225 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6226 `format_end'. Remove support for %l as a conversion specifier.
6227 Don't use xrealloc. Improve diagnostics when the %l size modifier
6228 is used. Update the commentary.
6229
6230 * eval.c (verror): Simplify calculation of size_t.
6231
6232 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6233 messages.
6234
f61f41d7
PE
62352011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6236
6237 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6238 change.
6239
96fb4434
PE
62402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6241
6242 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6243 This makes this file independent of the recent pseudovector change.
6244
671875da 62452011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6246
69e9b5a3
PE
6247 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6248
b5f869a7 6249 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6250 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6251 Remove unused local.
c8926152 6252 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6253
841a1577 6254 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6255 GCC 4.6.0 optimizes based on type-based alias analysis.
6256 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6257 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6258 != &v->size, and therefore "v->size = 1; b->size = 2; return
6259 v->size;" must therefore return 1. This assumption is incorrect
6260 for Emacs, since it type-puns struct Lisp_Vector * with many other
6261 types. To fix this problem, this patch adds a new type struct
f904488f 6262 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6263 and pseudovectors, and helps optimizing compilers not get fooled
6264 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6265 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6266 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6267 the size member.
eab3844f
PE
6268 (XSETPVECTYPE): Rewrite in terms of new macro.
6269 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6270 This is a bit clearer, and further avoids the possibility of
6271 undesirable aliasing.
6272 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6273 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6274 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6275 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6276 (ASIZE): Now uses header.size rather than size.
6277 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6278 to avoid the hassle of writing XVECTOR (foo)->header.size.
6279 (struct vectorlike_header): New type.
eab3844f
PE
6280 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6281 object, to help avoid aliasing.
6282 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6283 (SUBRP): Likewise, since Lisp_Subr is a special case.
6284 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6285 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6286 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6287 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6288 changed to be "header.size" and "header.next".
6289 * buffer.h (struct buffer): Likewise.
6290 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6291 * frame.h (struct frame): Likewise.
6292 * process.h (struct Lisp_Process): Likewise.
6293 * termhooks.h (struct terminal): Likewise.
6294 * window.c (struct save_window_data, struct saved_window): Likewise.
6295 * window.h (struct window): Likewise.
6296 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6297 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6298 * buffer.c (init_buffer_once): Likewise.
6299 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6300 special case.
6301 * process.c (Fformat_network_address): Use local var for size,
6302 for brevity.
6303
0df1eac5
PE
6304 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6305
847ab9d1 6306 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6307 * data.c (atof): Remove decl; no longer used or needed.
6308 (digit_to_number): Move to lread.c.
6309 (Fstring_to_number): Use new string_to_number function, to be
6310 consistent with how the Lisp reader treats infinities and NaNs.
6311 Do not assume that floating-point numbers represent EMACS_INT
6312 without losing information; this is not true on most 64-bit hosts.
6313 Avoid double-rounding errors, by insisting on integers when
6314 parsing non-base-10 numbers, as the documentation specifies.
6315 * lisp.h (string_to_number): New decl, replacing ...
6316 (isfloat_string): Remove.
bc0a5c13 6317 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6318 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6319 appears to have been a coding error. Similarly, do not accept
6320 strings like +-1e0 as floating point numbers. Do not report
6321 overflow for integer overflows unless the base is not 10 which
6322 means we have no simple and reliable way to continue.
6323 Break out the floating-point parsing into a new
6324 function string_to_number, so that Fstring_to_number parses
6325 floating point numbers consistently with the Lisp reader.
04f2d78b 6326 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6327 (E_CHAR, EXP_INT): Remove, replacing with ...
6328 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6329 (string_to_number): New function, replacing isfloat_string.
6330 This function checks for valid syntax and produces the resulting
6331 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6332 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6333 so that overflow for non-base-10 numbers is reported only when
6334 there's no portable and simple way to convert to floating point.
452f4150 6335
67769ffc
PE
6336 * textprop.c (set_text_properties_1): Rewrite for clarity,
6337 and to avoid GCC warning about integer overflow.
6338
c20db43f
PE
6339 * intervals.h (struct interval): Use EMACS_INT for members
6340 where EMACS_UINT might cause problems. See
6341 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6342 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6343 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6344 All uses changed.
37aa2f85
PE
6345 (offset_intervals): Tell GCC not to worry about length overflow
6346 when negating a negative length.
c20db43f 6347
2538aa2f
PE
6348 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6349 (overrun_check_free): Likewise.
6350
f2d3008d
PE
6351 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6352 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6353 word size.
6354
ec8df744
PE
6355 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6356 (gnutls_make_error): Rename local to avoid shadowing.
6357 (gnutls_emacs_global_deinit): ifdef out; not used.
6358 (Fgnutls_boot): Use const for pointer to readonly storage.
6359 Comment out unused local. Fix pointer signedness problems.
6360
640ee02d
PE
6361 * lread.c (openp): Don't stuff size_t into an 'int'.
6362 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6363 about possible signed overflow.
6364
6048fb2a
PE
6365 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6366 (GDK_KEY_g): Don't define if already defined.
6367 (xg_prepare_tooltip): Avoid pointer signedness problem.
6368 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6369
fa3c87e1
PE
6370 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6371 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6372
2172544b
PE
6373 * xfns.c (Fx_window_property): Simplify a bit,
6374 to make a bit faster and to avoid GCC 4.6.0 warning.
6375 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6376
9b821a21
PE
6377 * fns.c (internal_equal): Don't assume size_t fits in int.
6378
3c616cfa
PE
6379 * alloc.c (compact_small_strings): Tighten assertion a little.
6380
c2982e87
PE
6381 Replace pEd with more-general pI, and fix some printf arg casts.
6382 * lisp.h (pI): New macro, generalizing old pEd macro to other
6383 conversion specifiers. For example, use "...%"pI"d..." rather
6384 than "...%"pEd"...".
6385 (pEd): Remove. All uses replaced with similar uses of pI.
6386 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6387 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6388 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6389 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6390 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6391 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6392 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6393 64-bit hosts.
6394 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6395 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6396 * print.c (safe_debug_print, print_object): Likewise.
6397 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6398 to int.
6f04d126
PE
6399 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6400 avoiding the 0 flag, which is not portable.
c2982e87
PE
6401 * process.c (Fmake_network_process): Use pI to avoid cast.
6402 * region-cache.c (pp_cache): Likewise.
6403 * xdisp.c (decode_mode_spec): Likewise.
6404 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6405 behavior on 64-bit hosts with printf arg.
6f04d126 6406 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6407 (x_stop_queuing_selection_requests): Likewise.
6408 (x_get_window_property): Don't truncate byte count to an 'int'
6409 when tracing.
0b432f21 6410
5e073ec7
PE
6411 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6412 here, since it parses constructs like leading '-' and spaces,
6413 which are not wanted; and it overflows with large numbers.
6414 Instead, simply match F[0-9]+, which is what is wanted anyway.
6415
36372bf9
PE
6416 * alloc.c: Remove unportable assumptions about struct layout.
6417 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6418 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6419 (allocate_vectorlike, make_pure_vector): Use the new macros,
6420 plus offsetof, to remove unportable assumptions about struct layout.
6421 These assumptions hold on all porting targets that I know of, but
6422 they are not guaranteed, they're easy to remove, and removing them
6423 makes further changes easier.
6424
0b432f21
PE
6425 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6426 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6427 (string_overrun_cookie): Now const. Use initializers that
6428 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6429 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6430 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6431 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6432 multiple of sizeof (EMACS_INT); it need not be, if
6433 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6434 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6435
895009e1
JB
64362011-04-26 Juanma Barranquero <lekktu@gmail.com>
6437
6438 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6439
6a7a1b0b
TZ
64402011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6441
6442 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6443 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6444 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6445
841a1577 64462011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6447
6448 * lisp.h (Qdebug): List symbol.
895009e1 6449 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6450 * keyboard.c (debug-on-event): New variable.
6451 (handle_user_signal): Break into debugger when debug-on-event
6452 matches the current signal symbol.
6453
f2d3ba6f
DN
64542011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6455
6456 * alloc.c (check_sblock, check_string_bytes)
6457 (check_string_free_list): Convert to standard C.
6458
42ce4c63
TZ
64592011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6460
6461 * w32.c (emacs_gnutls_push): Fix typo.
6462
825cd63c
EZ
64632011-04-25 Eli Zaretskii <eliz@gnu.org>
6464
fb11d64d
EZ
6465 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6466 "cast to pointer from integer of different size".
6467
825cd63c
EZ
6468 Improve doprnt and its use in verror. (Bug#8545)
6469 * doprnt.c (doprnt): Document the set of format control sequences
6470 supported by the function. Use SAFE_ALLOCA instead of always
6471 using `alloca'.
6472
6473 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6474 is one byte too soon. Don't use xrealloc; instead xfree and
6475 xmalloc anew.
6476
e061a11b
TZ
64772011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6478
6479 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6480 callbacks stage.
6481
6482 * gnutls.c: Renamed global_initialized to
6483 gnutls_global_initialized. Added internals for the
6484 :verify-hostname-error, :verify-error, and :verify-flags
6485 parameters of `gnutls-boot' and documented those parameters in the
6486 docstring. Start callback support.
9173deec
JB
6487 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6488 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6489 on error. Return error code.
e061a11b
TZ
6490 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6491 (emacs_gnutls_read): Likewise.
6492 (Fgnutls_boot): Return handshake error code.
6493 (emacs_gnutls_handle_error): New function.
6494 (wsaerror_to_errno): Likewise.
6495
6496 * w32.h (emacs_gnutls_pull): Add prototype.
6497 (emacs_gnutls_push): Likewise.
6498
6499 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6500 (emacs_gnutls_push): Likewise.
6501
65022011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6503
6504 * process.c (wait_reading_process_output): Check if GnuTLS
6505 buffered some data internally if no FDs are set for TLS
6506 connections.
6507
6508 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6509 (LIBS): Link to USER_LIBS.
6510 ($(BLD)/gnutls.$(0)): New target.
6511
fa6996bc
EZ
65122011-04-24 Eli Zaretskii <eliz@gnu.org>
6513
eb35682e
EZ
6514 * xdisp.c (handle_single_display_spec): Rename the
6515 display_replaced_before_p argument into display_replaced_p, to
6516 make it consistent with the commentary. Fix typos in the
6517 commentary.
6518
e2ad650c
EZ
6519 * textprop.c (syms_of_textprop): Remove dead code.
6520 (copy_text_properties): Delete obsolete commentary about an
6521 interface that was deleted long ago. Fix typos in the description
6522 of arguments.
6523
1b2de274
EZ
6524 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6525 to changes in oldXMenu/XMenu.h from 2011-04-16.
6526 <menu_help_message, prev_menu_help_message>: Constify.
6527 (IT_menu_make_room): menu->help_text is now `const char **';
6528 adjust.
6529
6530 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6531 to changes in oldXMenu/XMenu.h from 2011-04-16.
6532 (struct XMenu): Declare `help_text' `const char **'.
6533
6534 * xfaces.c <Qunspecified>: Make extern again.
6535
6536 * syntax.c: Include sys/types.h before including regex.h, as
6537 required by Posix.
6538
762b15be
EZ
6539 * doc.c (get_doc_string): Improve the format passed to `error'.
6540
6541 * doprnt.c (doprnt): Improve commentary.
6542
6543 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6544
6545 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6546 them with etags.
6547
f1052e5d
EZ
6548 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6549 changes in globals.h immediately force recompilation.
762b15be
EZ
6550 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6551 $(CURDIR)/s/ms-w32.h.
6552 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6553
fa6996bc
EZ
6554 * character.c (Fchar_direction): Function deleted.
6555 (syms_of_character): Don't defsubr it.
6556 <char-direction-table>: Deleted.
6557
e6c3da20
EZ
65582011-04-23 Eli Zaretskii <eliz@gnu.org>
6559
6560 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6561 * doprnt.c: Include limits.h.
6562 (SIZE_MAX): New macro.
04f2d78b
CB
6563 (doprnt): Return a size_t value. 2nd arg is now size_t.
6564 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6565 Improve overflow protection. Support `l' modifier for integer
6566 conversions. Support %l conversion. Don't assume an EMACS_INT
6567 argument for integer conversions and for %c.
6568
6569 * lisp.h (doprnt): Restore prototype.
6570
6571 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6572 $(SRC)/character.h.
6573
6574 * Makefile.in (base_obj): Add back doprnt.o.
6575
6576 * deps.mk (doprnt.o): Add back prerequisites.
6577 (callint.o): Depend on character.h.
6578
6579 * eval.c (internal_lisp_condition_case): Include the handler
6580 representation in the error message.
6581 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6582 when breaking from the loop.
6583
6584 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6585
6586 * callint.c (Fcall_interactively): When displaying error message
6587 about invalid control letter, pass the character's codepoint, not
6588 a pointer to its multibyte form. Improve display of the character
6589 in octal and display also its hex code.
6590
6591 * character.c (char_string): Use %x to display the (unsigned)
6592 codepoint of an invalid character, to avoid displaying a bogus
6593 negative value.
6594
6595 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6596 `error', not SYMBOL_NAME itself.
6597
6598 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6599 character arguments to `error'.
6600
6601 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6602 to `error' in error message about FINAL_CHAR argument. Make sure
6603 FINAL_CHAR is a character, and use %c when it is passed as
6604 argument to `error'.
6605
4ffd0d6b 66062011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6607
6608 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6609
6610 * w32.c: Include <time.h>.
6611 (sys_localtime): New function.
6612
4ffd0d6b 66132011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6614
6615 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6616
4ffd0d6b 6617 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6618
4ffd0d6b 66192011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6620
4ffd0d6b
GM
6621 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6622 zombies (Bug#8467).
aac0c6e3 6623
04c56954
EZ
66242011-04-19 Eli Zaretskii <eliz@gnu.org>
6625
6626 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6627 gl_state.e_property when gl_state.object is Qt.
6628
6629 * insdel.c (make_gap_larger): Remove limitation of buffer size
6630 to <= INT_MAX.
6631
16a43933
CY
66322011-04-18 Chong Yidong <cyd@stupidchicken.com>
6633
6634 * xdisp.c (lookup_glyphless_char_display)
6635 (produce_glyphless_glyph): Handle cons cell entry in
6636 glyphless-char-display.
6637 (Vglyphless_char_display): Document it.
6638
6639 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6640 glyphless-char-display.
6641
4581706e
CY
66422011-04-17 Chong Yidong <cyd@stupidchicken.com>
6643
6644 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6645
6646 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6647
6648 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6649 definition for no-X builds.
6650
4887c6e2 66512011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6652
fd35b6f9
PE
6653 Static checks with GCC 4.6.0 and non-default toolkits.
6654
5c1ccb01
PE
6655 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6656
006c5daa
PE
6657 * process.c (keyboard_bit_set): Define only if SIGIO.
6658 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6659 (send_process): Repair possible setjmp clobbering.
6660
efc736d3
PE
6661 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6662
4e2fe2e6
PE
6663 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6664
f97334a2
PE
6665 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6666
4e75f29d
PE
6667 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6668 Define only if needed.
6669
90efadd1
PE
6670 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6671 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6672 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6673
3c647824
PE
6674 * dispextern.h (struct redisplay_interface): Rename param
6675 to avoid shadowing.
e264f262 6676 * termhooks.h (struct terminal): Likewise.
761383f4 6677 * xterm.c (xembed_send_message): Likewise.
3c647824 6678
b58c5c4a
PE
6679 * insdel.c (make_gap_smaller): Define only if
6680 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6681
cad59032
PE
6682 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6683 it.
6684
c339dc2e
PE
6685 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6686 so that we aren't warned about unused symbols.
6687
91a3e27b
PE
6688 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6689
399c71d3 6690 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6691
8ffc96f5
PE
6692 * xfns.c (x_real_positions): Mark locals as initialized.
6693
eef9bc79
PE
6694 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6695
098db9dd
PE
6696 * xterm.c: Fix problems found by static analysis with other toolkits.
6697 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6698 (x_dispatch_event): Declare static if USE_GTK, and
6699 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6700 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6701 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6702 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6703 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6704
eb18f6cc
PE
6705 * xmenu.c (menu_help_callback): Pointer type fixes.
6706 Use const pointers when pointing at readonly data. Avoid pointer
6707 signedness clashes.
6708 (FALSE): Remove unused macro.
6709 (update_frame_menubar): Remove unused decl.
6710
1fe72bf8
PE
6711 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6712
60d9e1db
PE
6713 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6714 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6715 (single_menu_item): Rename local to avoid shadowing.
6716
39261c26
PE
6717 * keyboard.c (make_lispy_event): Remove unused local var.
6718
018c5e19
PE
6719 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6720 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6721
63d2b86e
PE
6722 * bitmaps: Change bitmaps from unsigned char back to the X11
6723 compatible char. Avoid the old compiler warnings about
6724 out-of-range initializers by using, for example, '\xab' rather
6725 than 0xab.
6726
aefd87e1
PE
6727 * xgselect.c (xgselect_initialize): Check vs interface
6728 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6729
bf501fb9
PE
6730 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6731
e9829fdf
PE
6732 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6733 to read-only memory.
6734
1086c095
PE
6735 * fns.c (vector): Remove; this old hack is no longer needed.
6736
2baccd04 6737 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6738 Remove unused var.
dde42981 6739 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6740
72391843 6741 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6742
436c16df 6743 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6744 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6745 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6746
92bb796d 6747 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6748 (x_term_init): Remove local to avoid shadowing.
92bb796d 6749
764430a3 6750 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6751
6752 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6753 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6754
d1dfb56c
EZ
67552011-04-16 Eli Zaretskii <eliz@gnu.org>
6756
c4354cb4
EZ
6757 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6758
d1dfb56c
EZ
6759 Fix regex.c, syntax.c and friends for buffers > 2GB.
6760 * syntax.h (struct gl_state_s): Declare character position members
6761 EMACS_INT.
6762
6763 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6764
04f2d78b
CB
6765 * textprop.c (verify_interval_modification, interval_of):
6766 Declare arguments EMACS_INT.
d1dfb56c
EZ
6767
6768 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6769 EMACS_INT.
6770
6771 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6772
6773 * indent.c (Fvertical_motion): Local variable it_start is now
6774 EMACS_INT.
6775
6776 * regex.c (re_match, re_match_2, re_match_2_internal)
6777 (bcmp_translate, regcomp, regexec, print_double_string)
6778 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6779 (re_compile_pattern, re_exec): Declare arguments and local
6780 variables `size_t' and `ssize_t' and return values `regoff_t', as
6781 appropriate.
6782 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6783 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6784 <compile_stack_type>: `size' and `avail' are now `size_t'.
6785
6786 * regex.h <regoff_t>: Use ssize_t, not int.
6787 (re_search, re_search_2, re_match, re_match_2): Arguments that
6788 specify buffer/string position and length are now ssize_t and
6789 size_t. Return type is regoff_t.
6790
613052cd
BK
67912011-04-16 Ben Key <bkey76@gmail.com>
6792
6793 * nsfont.m: Fixed bugs in ns_get_family and
6794 ns_descriptor_to_entity that were caused by using free to
6795 deallocate memory blocks that were allocated by xmalloc (via
6796 xstrdup). This caused Emacs to crash when compiled with
6797 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6798 --enable-checking=xmallocoverrun). xfree is now used to
6799 deallocate these memory blocks.
6800
4170f62f 68012011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6802
71b41406
PE
6803 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6804
9587a89d
PE
6805 emacs_write: Accept and return EMACS_INT for sizes.
6806 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6807 et seq.
6808 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6809 Accept and return EMACS_INT.
6810 (emacs_gnutls_write): Return the number of bytes written on
6811 partial writes.
6812 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6813 (emacs_read, emacs_write): Remove check for negative size, as the
6814 Emacs source code has been audited now.
9587a89d
PE
6815 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6816 (emacs_read, emacs_write): Use it.
273a5f82
PE
6817 * process.c (send_process): Adjust to the new signatures of
6818 emacs_write and emacs_gnutls_write. Do not attempt to store
6819 a byte offset into an 'int'; it might overflow.
9587a89d 6820 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6821
3e047f51
PE
6822 * sound.c: Don't assume sizes fit in 'int'.
6823 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6824 Return EMACS_INT, not int.
3e047f51 6825 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6826 Accept EMACS_INT, not int.
6827 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6828 record read return values.
6829
cc39a9db
BK
68302011-04-15 Ben Key <bkey76@gmail.com>
6831
c9d0ec6d
JB
6832 * keyboard.c (Qundefined): Don't declare static since it is used
6833 in nsfns.m.
6834 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6835 static since they are used in nsfont.m.
cc39a9db 6836
6c60eb9f
SM
68372011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6838
6839 * process.c (Qprocessp): Don't declare static.
6840 * lisp.h (Qprocessp): Declare again.
6841
7990b61a
JB
68422011-04-15 Juanma Barranquero <lekktu@gmail.com>
6843
6844 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6845
5d4cb038
PE
68462011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6847
8bd7b830 6848 Improve C-level modularity by making more things 'static'.
cd64ea1d 6849
e3b27b31
PE
6850 Don't publish debugger-only interfaces to other modules.
6851 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6852 (verify_bytepos, count_markers): Move decls to the only modules
6853 that need them.
6854 * region-cache.h (pp_cache): Likewise.
6855 * window.h (check_all_windows): Likewise.
6856 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6857
5d4cb038
PE
6858 * sysdep.c (croak): Now static, if
6859 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6860 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6861
6862 * alloc.c (refill_memory_reserve): Now static if
6863 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6864 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6865
e87b6180
PE
6866 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6867 Define only if USE_LUCID.
6868
ac64929e
PE
6869 * xrdb.c (x_customization_string, x_rm_string): Now static.
6870
6f37259d
PE
6871 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6872 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6873
1683e3ab
PE
6874 * xdisp.c (draw_row_with_mouse_face): Now static.
6875 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6876
de9c2632
PE
6877 * window.h (check_all_windows): Mark externally visible.
6878
2b96acb7
PE
6879 * window.c (window_deletion_count): Now static.
6880
6881 * undo.c: Make symbols static if they're not exported.
6882 (last_undo_buffer, last_boundary_position, pending_boundary):
6883 Now static.
6884
50436f33
PE
6885 * textprop.c (interval_insert_behind_hooks): Now static.
6886 (interval_insert_in_front_hooks): Likewise.
6887
64520e5c
PE
6888 * term.c: Make symbols static if they're not exported.
6889 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6890 (max_frame_lines, tty_set_terminal_modes):
6891 (tty_reset_terminal_modes, tty_turn_off_highlight):
6892 (get_tty_terminal): Now static.
6893 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6894 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6895 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6896 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6897 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6898
1fa53021
PE
6899 * sysdep.c: Make symbols static if they're not exported.
6900 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6901 Now static.
6902 (sigprocmask_set, full_mask): Remove; unused.
6903 (wait_debugging): Mark as visible.
6904 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6905 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6906
d4b43b22
PE
6907 * syntax.c (syntax_temp): Define only if !__GNUC__.
6908
b7c513d0
PE
6909 * sound.c (current_sound_device, current_sound): Now static.
6910
989b29ad
PE
6911 * search.c (searchbufs, searchbuf_head): Now static.
6912
13a55a78
PE
6913 * scroll.c (scroll_cost): Remove; unused.
6914 * dispextern.h (scroll_cost): Remove decl.
6915
de68a1fc
PE
6916 * region-cache.h (pp_cache): Mark as externally visible.
6917
40ccffa6
PE
6918 * process.c: Make symbols static if they're not exported.
6919 (process_tick, update_tick, create_process, chan_process):
6920 (Vprocess_alist, proc_buffered_char, datagram_access):
6921 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6922 (deactivate_process): Mark defn as static, as well as decl.
6923 * lisp.h (create_process): Remove decl.
6924 * process.h (chan_process, Vprocess_alist): Remove decls.
6925
ad64fc97
PE
6926 * print.c: Make symbols static if they're not exported.
6927 (print_depth, new_backquote_output, being_printed, print_buffer):
6928 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6929 (print_interval, print_number_index, initial_stderr_stream):
6930 Now static.
6931 * lisp.h (Fprinc): Remove decl.
6932 (debug_output_compilation_hack): Mark as externally visible.
6933
adddb265
PE
6934 * sysdep.c (croak): Move decl from here to syssignal.h.
6935 * syssignal.h (croak): Put it here, so the API can be checked when
6936 'croak' is called from dissociate_if_controlling_tty.
6937
1717ede2
PE
6938 * minibuf.c: Make symbols static if they're not exported.
6939 (minibuf_save_list, choose_minibuf_frame): Now static.
6940 * lisp.h (choose_minibuf_frame): Remove decl.
6941
fa5fb2bc
PE
6942 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6943
1e3890d1
PE
6944 * lread.c: Make symbols static if they're not exported.
6945 (read_objects, initial_obarray, oblookup_last_bucket_number):
6946 Now static.
6947 (make_symbol): Remove; unused.
6948 * lisp.h (initial_obarray, make_symbol): Remove decls.
6949
8a1414fa
PE
6950 * keyboard.c: Make symbols static if they're not exported.
6951 (single_kboard, recent_keys_index, total_keys, recent_keys):
6952 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6953 (this_single_command_key_start, echoing, last_auto_save):
6954 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6955 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6956 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6957 (Vlispy_mouse_stem, double_click_count):
6958 Now static.
6959 (force_auto_save_soon): Define only if SIGDANGER.
6960 (ignore_mouse_drag_p): Now static if
6961 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6962 (print_help): Remove; unused.
6963 (stop_character, last_timer_event): Mark as externally visible.
6964 * keyboard.h (ignore_mouse_drag_p): Declare only if
6965 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6966 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6967 * lisp.h (echoing): Remove decl.
6968 (force_auto_save_soon): Declare only if SIGDANGER.
6969 * xdisp.c (redisplay_window): Simplify code, to make it more
6970 obvious that ignore_mouse_drag_p is not accessed if !defined
6971 USE_GTK && !defined HAVE_NS.
6972
93ea6e8f
PE
6973 * intervals.c: Make symbols static if they're not exported.
6974 (merge_properties_sticky, merge_interval_right, delete_interval):
6975 Now static.
6976 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6977
77382fcc
PE
6978 * insdel.c: Make symbols static if they're not exported.
6979 However, leave prepare_to_modify_buffer alone. It's never
6980 called from outside this function, but that appears to be a bug.
6981 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6982 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6983 (adjust_after_replace_noundo): Remove; unused.
6984 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6985 (signal_before_change): Remove decls.
77382fcc 6986
9306c32e
PE
6987 * indent.c (val_compute_motion, val_vmotion): Now static.
6988
cd44d2eb
PE
6989 * image.c: Make symbols static if they're not exported.
6990 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6991 if USE_GTK.
6992 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6993 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6994
ad9a7a06
PE
6995 * fringe.c (standard_bitmaps): Now static.
6996 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6997
81626931
PE
6998 * frame.c: Make symbols static if they're not exported.
6999 (x_report_frame_params, make_terminal_frame): Now static.
7000 (get_frame_param): Now static, unless HAVE_NS.
7001 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7002 (x_get_resource_string): Remove; not used.
7003 * frame.h (make_terminal_frame, x_report_frame_params):
7004 (x_get_resource_string); Remove decls.
7005 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7006 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7007
239f9db9
PE
7008 * font.c, fontset.c: Make symbols static if they're not exported.
7009 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7010 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7011 * font.c (font_close_object): Now static.
7012 * font.h (font_close_object): Remove.
7013 * fontset.c (FONTSET_OBJLIST): Remove.
7014 (free_realized_fontset) #if-0 the body, which does nothing.
7015 (face_suitable_for_char_p): #if-0, as it's never called.
7016 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7017 * xfaces.c (face_at_string_position):
7018 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7019 since 0 is always ASCII.
7020
dfcf3579
PE
7021 * fns.c (weak_hash_tables): Now static.
7022
5045092b
PE
7023 * fileio.c: Make symbols static if they're not exported.
7024 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7025 (Vwrite_region_annotation_buffers): Now static.
7026
57a96f5c
PE
7027 * eval.c: Make symbols static if they're not exported.
7028 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7029 * lisp.h (backtrace_list): Remove decl.
7030
35f08c38
PE
7031 * emacs.c: Make symbols static if they're not exported.
7032 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7033 (fatal_error_code, fatal_error_signal_hook, standard_args):
7034 Now static.
7035 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7036 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7037 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7038 * lisp.h (fatal_error_signal_hook): Remove decl.
7039 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7040
f44bd759
PE
7041 * editfns.c: Move a (normally-unused) function to its only use.
7042 * editfns.c, lisp.h (get_operating_system_release): Remove.
7043 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7044 worth the hassle of breaking this out.
7045
b532497d
PE
7046 * xterm.c: Make symbols static if they're not exported.
7047 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7048 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7049 (x_destroy_window, x_delete_display):
7050 Now static.
7051 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7052 (x_mouse_leave): Remove; unused.
7053 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7054 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7055 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7056 Remove decls.
7057 (x_mouse_leave): Declare only if WINDOWSNT.
7058 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7059 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7060 USE_X_TOOLKIT.
7061
1675728f
PE
7062 * ftxfont.c: Make symbols static if they're not exported.
7063 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7064 HAVE_FREETYPE.
7065 * font.h (ftxfont_driver): Likewise.
7066
e4cebfca
PE
7067 * xfns.c: Make symbols static if they're not exported.
7068 (x_last_font_name, x_display_info_for_name):
7069 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7070 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7071 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7072 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7073 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7074 (last_show_tip_args): Now static.
7075 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7076 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7077 (x_screen_planes): Remove; unused.
7078 * dispextern.h (x_screen_planes): Remove decl.
7079
5bf46f05
PE
7080 * dispnew.c: Make symbols static if they're not exported.
7081 * dispextern.h (redraw_garbaged_frames, scrolling):
7082 (increment_row_positions): Remove.
7083 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7084 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7085 Now static.
7086 (redraw_garbaged_frames): Remove; unused.
7087
435f4c28
PE
7088 * xfaces.c: Make symbols static if they're not exported.
7089 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7090 Remove decls.
7091 * xterm.h (defined_color): Remove decls.
7092 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7093 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7094 (menu_face_changed_default, defined_color, free_realized_face):
7095 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7096 (ascii_face_of_lisp_face): Remove; unused.
7097
8524aef3
PE
7098 * xdisp.c: Make symbols static if they're not exported.
7099 * dispextern.h (scratch_glyph_row, window_box_edges):
7100 (glyph_to_pixel_coords, set_cursor_from_row):
7101 (get_next_display_element, set_iterator_to_next):
7102 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7103 (show_mouse_face): Remove decls
7104 * frame.h (message_buf_print): Likewise.
7105 * lisp.h (pop_message, set_message, check_point_in_composition):
7106 Likewise.
7107 * xterm.h (set_vertical_scroll_bar): Likewise.
7108 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7109 (message_buf_print, scratch_glyph_row, displayed_buffer):
7110 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7111 (get_next_display_element, show_mouse_face, window_box_edges):
7112 (frame_to_window_pixel_xy, check_point_in_composition):
7113 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7114 (glyph_to_pixel_coords): Remove; unused.
7115
16390cd2
PE
7116 * dired.c (file_name_completion): Now static.
7117
7118 * dbusbind.c (xd_in_read_queued_messages): Now static.
7119
a25f4dfa
PE
7120 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7121 * data.c (circular_list_error): Remove.
7122
14a9c8df
PE
7123 * commands.h (last_point_position, last_point_position_buffer):
7124 (last_point_position_window): Remove decls.
7125 * keyboard.c: Make these variables static.
7126
04f2d78b
CB
7127 * coding.h (coding, code_convert_region, encode_coding_gap):
7128 Remove decls.
74ab6df5
PE
7129 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7130 (iso_code_class, detect_coding, code_convert_region): Now static.
7131 (encode_coding_gap): Remove; unused.
7132
38dfbee1
PE
7133 * chartab.c (chartab_chars, chartab_bits): Now static.
7134
a2cb4e63
PE
7135 * charset.h (charset_iso_8859_1): Remove decl.
7136 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7137 Now static.
7138
127198fd
PE
7139 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7140 * ccl.c (Vccl_program_table): Now static.
7141 (check_ccl_update): Remove; unused.
7142
d85b608f
PE
7143 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7144 * category.h: ... from here.
7145 * category.c (check_category_table, set_category_set): Now static.
7146
31cd66f3
PE
7147 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7148 * lisp.h: Remove these decls.
7149
c358e587
PE
7150 * buffer.c (buffer_count): Remove unused var.
7151
e78aecca
PE
7152 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7153 so that it's not optimized away.
7154 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7155 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7156 exported only to the debugger.
7157
e192d7d3 7158 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7159 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7160
92470028
PE
7161 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7162 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7163 was inaccessible from Lisp.
7164 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7165 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7166
244ed907
PE
7167 alloc.c: Import and export fewer symbols, and remove unused items.
7168 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7169 is defined.
7170 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7171 it's not optimized away by whole-program optimization.
7172 (message_enable_multibyte, free_misc): Remove.
7173 (catchlist, handlerlist, mark_backtrace):
7174 Declare only if BYTE_MARK_STACK.
7175 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7176 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7177 (message_enable_multibyte): Remove decl.
7178 (free_misc, interval_free_list, float_block, float_block_index):
7179 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7180 (cons_free_list, last_marked_index):
7181 Now static.
7182 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7183 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7184 (mark_backtrace): Define only if BYTE_MARK_STACK.
7185 * xdisp.c (message_enable_multibyte): Now static.
7186
61c2b50e 7187 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7188 This makes it easier for human readers (and static analyzers)
7189 to see whether these variables are used from other modules.
7190 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7191 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7192 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7193 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7194 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7195 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7196 * xmenu.c, xselect.c:
7197 Declare Q* vars static if they are not used in other modules.
7198 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7199 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7200 Remove decls of unexported vars.
7201 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7202
95c82688
PE
7203 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7204
16a97296
PE
7205 Make Emacs functions such as Fatom 'static' by default.
7206 This makes it easier for human readers (and static analyzers)
7207 to see whether these functions can be called from other modules.
7208 DEFUN now defines a static function. To make the function external
7209 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7210 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7211 (Finit_image_library):
16a97296
PE
7212 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7213 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7214 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7215 Remove decls, since these functions are now static.
7216 (Funintern, Fget_internal_run_time): New decls, since these functions
7217 were already external.
95c82688 7218
16a97296
PE
7219 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7220 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7221 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7222 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7223 * keyboard.c, keymap.c, lread.c:
7224 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7225 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7226 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7227 Mark functions with DEFUE instead of DEFUN,
7228 if they are used in other modules.
7229 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7230 decls for now-static functions.
7231 * buffer.h (Fdelete_overlay): Remove decl.
7232 * callproc.c (Fgetenv_internal): Mark as internal.
7233 * composite.c (Fremove_list_of_text_properties): Remove decl.
7234 (Fcomposition_get_gstring): New forward static decl.
7235 * composite.h (Fcomposite_get_gstring): Remove decl.
7236 * dired.c (Ffile_attributes): New forward static decl.
7237 * doc.c (Fdocumntation_property): New forward static decl.
7238 * eval.c (Ffetch_bytecode): New forward static decl.
7239 (Funintern): Remove extern decl; now in .h file where it belongs.
7240 * fileio.c (Fmake_symbolic_link): New forward static decl.
7241 * image.c (Finit_image_library): New forward static decl.
7242 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7243 * intervals.h (Fprevious_property_change):
7244 (Fremove_list_of_text_properties): Remove decls.
7245 * keyboard.c (Fthis_command_keys): Remove decl.
7246 (Fcommand_execute): New forward static decl.
7247 * keymap.c (Flookup_key): New forward static decl.
7248 (Fcopy_keymap): Now static.
7249 * keymap.h (Flookup_key): Remove decl.
7250 * process.c (Fget_process): New forward static decl.
7251 (Fprocess_datagram_address): Mark as internal.
7252 * syntax.c (Fsyntax_table_p): New forward static decl.
7253 (skip_chars): Remove duplicate decl.
7254 * textprop.c (Fprevious_property_change): New forward static decl.
7255 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7256 Now internal.
7257 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7258 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7259
785bbd42
PE
7260 * editfns.c (Fformat): Remove unreachable code.
7261
8b913b57
AS
72622011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7263
7264 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7265 change. (Bug#8496)
7266
a6744a35
EZ
72672011-04-13 Eli Zaretskii <eliz@gnu.org>
7268
7269 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7270 when at ZV. (Bug#8487)
7271
e7974947
AS
72722011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7273
baad03f0
AS
7274 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7275 (Bug#8437)
7276 * keyboard.c (parse_tool_bar_item): Likewise.
7277 * sound.c (sound_cleanup, alsa_close): Likewise.
7278 * termcap.c (tgetent): Likewise.
7279 * xfns.c (x_default_font_parameter): Likewise.
7280 * xsettings.c (read_and_apply_settings): Likewise.
7281
e7974947
AS
7282 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7283 (overrun_check_free): Protoize.
7284
28272684
PE
72852011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7286
7287 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7288 since callers should never pass a negative size.
7289 Change the signature to match that of plain 'read' and 'write'; see
7290 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7291 * lisp.h: Update prototypes of emacs_write and emacs_read.
7292
11997c76
EZ
72932011-04-11 Eli Zaretskii <eliz@gnu.org>
7294
7295 * xdisp.c (redisplay_window): Don't try to determine the character
7296 position of the scroll margin if the window start point w->startp
e896f03c 7297 is outside the buffer's accessible region. (Bug#8468)
11997c76 7298
8a2cbd72
EZ
72992011-04-10 Eli Zaretskii <eliz@gnu.org>
7300
7301 Fix write-region and its subroutines for buffers > 2GB.
7302 * fileio.c (a_write, e_write): Modify declaration of arguments and
7303 local variables to support buffers larger than 2GB.
7304 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7305
7306 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7307 argument, local variables, and return value.
7308
7309 * lisp.h: Update prototypes of emacs_write and emacs_read.
7310
7311 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7312
4073e537 73132011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7314
1ebfdcb6
PE
7315 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7316
b2ded58d
PE
7317 Fix more problems found by GCC 4.6.0's static checks.
7318
7d66342c
PE
7319 * xdisp.c (vmessage): Use a better test for character truncation.
7320
bbf47d44
PE
7321 * charset.c (load_charset_map): <, not <=, for optimization,
7322 and to avoid potential problems with integer overflow.
9248994d 7323 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7324 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7325 * editfns.c (Fformat): Likewise.
1e69125e 7326 * syntax.c (skip_chars): Likewise.
3befa583 7327
e3019616
PE
7328 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7329 This also lets GCC 4.6.0 generate slightly better loop code.
7330
becfa255
PE
7331 * callint.c (Fcall_interactively): <, not <=, for optimization.
7332 (Fcall_interactively): Count the number of arguments produced,
7333 not the number of arguments given. This is simpler and lets GCC
7334 4.6.0 generate slightly better code.
7335
dae0cd48
PE
7336 * ftfont.c: Distingish more carefully between FcChar8 and char.
7337 The previous code passed unsigned char * to a functions like
7338 strlen and xstrcasecmp that expect char *, which does not
7339 conform to the C standard.
7340 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7341 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7342 char * when the C standard requires it.
7343
76032d70
PE
7344 * keyboard.c (read_char): Remove unused var.
7345
eb3f1cc8
PE
7346 * eval.c: Port to Windows vsnprintf (Bug#8435).
7347 Include <limits.h>.
7348 (SIZE_MAX): Define if the headers do not.
7349 (verror): Do not give up if vsnprintf returns a negative count.
7350 Instead, grow the buffer. This ports to Windows vsnprintf, which
7351 does not conform to C99. Problem reported by Eli Zaretskii.
7352 Also, simplify the allocation scheme, by avoiding the need for
7353 calling realloc, and removing the ALLOCATED variable.
7354
70476b54
PE
7355 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7356
12020a9e
PE
7357 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7358 But keep the doprint source code for now, as we might revamp it
7359 and use it again (Bug#8435).
ea6c7ae6
PE
7360 * lisp.h (doprnt): Remove.
7361 * Makefile.in (base_obj): Remove doprnt.o.
7362 * deps.mk (doprnt.o): Remove.
7363
5fdb398c
PE
7364 error: Print 32- and 64-bit integers portably (Bug#8435).
7365 Without this change, on typical 64-bit hosts error ("...%d...", N)
7366 was used to print both 32- and 64-bit integers N, which relied on
7367 undefined behavior.
7368 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7369 New macro.
7370 * lisp.h (error, verror): Mark as printf-like functions.
7371 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7372 Report overflow in size calculations when allocating printf buffer.
7373 Do not truncate output string at its first null byte.
7374 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7375 Truncate the output at a character boundary, since vsnprintf does not
7376 do that.
7377 * charset.c (check_iso_charset_parameter): Convert internal
7378 character to string before calling 'error', since %c now has the
7379 printf meaning.
7380 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7381 overflow when computing char to be passed to 'error'. Do not
7382 pass Lisp_Object to 'error'; pass the integer instead.
7383 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7384 formatted with plain %d.
7385
b189fa66
PE
7386 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7387
bff87ef0
PE
7388 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7389
7e2cac20
PE
7390 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7391
ce4d90b5
PE
7392 * xterm.c (x_catch_errors): Remove duplicate declaration.
7393
266c9547
PE
7394 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7395
79c49ad2
PE
7396 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7397
368f4090
JM
73982011-04-10 Jim Meyering <meyering@redhat.com>
7399
7400 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7401 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7402 return ssize_t not "int", and use size_t as the buffer length.
7403 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7404 * gnutls.h: Update declarations.
7405 * process.c (read_process_output): Use ssize_t, to match.
7406 (send_process): Likewise.
7407
a32d4040
CY
74082011-04-09 Chong Yidong <cyd@stupidchicken.com>
7409
7410 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7411
8546720e 74122011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7413
04f2d78b
CB
7414 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7415 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7416
8546720e
GM
7417 * xterm.c (handle_one_xevent):
7418 * xmenu.c (create_and_show_popup_menu):
7419 * xselect.c (x_decline_selection_request)
7420 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7421
0a2f5c1a 74222011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7423
7424 Fix some uses of `int' instead of EMACS_INT.
7425 * search.c (string_match_1, fast_string_match)
7426 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7427 (scan_buffer, find_next_newline_no_quit)
7428 (find_before_next_newline, search_command, Freplace_match)
7429 (Fmatch_data): Make some `int' variables be EMACS_INT.
7430
7431 * xdisp.c (display_count_lines): 3rd argument and return value now
7432 EMACS_INT. All callers changed.
7433 (pint2hrstr): Last argument is now EMACS_INT.
7434
7435 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7436 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7437 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7438 (decode_coding_utf_16, decode_coding_emacs_mule)
7439 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7440 (decode_coding_ccl, decode_coding_charset)
7441 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7442 (decode_coding_iso_2022, decode_coding_emacs_mule)
7443 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7444 <char_offset, last_offset>: Declare EMACS_INT.
7445 (encode_coding_utf_8, encode_coding_utf_16)
7446 (encode_coding_emacs_mule, encode_invocation_designation)
7447 (encode_designation_at_bol, encode_coding_iso_2022)
7448 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7449 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7450 Declare EMACS_INT.
7451 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7452 (encode_invocation_designation): Last argument P_NCHARS is now
7453 EMACS_INT.
7454 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7455 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7456
7457 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7458 All users changed.
7459
7460 * ccl.c (Fccl_execute_on_string): Declare some variables
7461 EMACS_INT.
7462
8546720e 74632011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7464
7465 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7466
4e19a977
CS
74672011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7468
7469 * process.c (Fformat_network_address): Doc fix.
7470
87302331
R
74712011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7472
ee7683eb 7473 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7474
cbb59342
CY
74752011-04-08 Chong Yidong <cyd@stupidchicken.com>
7476
7477 * keyboard.c (read_char): Call Lisp function help-form-show,
7478 instead of using internal_with_output_to_temp_buffer.
7479 (Qhelp_form_show): New var.
e0d38eeb 7480 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7481
7482 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7483
7484 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7485
e67a13ab
CY
74862011-04-06 Chong Yidong <cyd@stupidchicken.com>
7487
04f2d78b
CB
7488 * process.c (Flist_processes): Remove to Lisp.
7489 (list_processes_1): Delete.
e67a13ab 7490
973f782d
EZ
74912011-04-06 Eli Zaretskii <eliz@gnu.org>
7492
7c106b1e
EZ
7493 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7494
973f782d
EZ
7495 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7496
41cf7d1a 74972011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7498
ca23cc88
PE
7499 Fix more problems found by GCC 4.6.0's static checks.
7500
f390e2d5
PE
7501 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7502
42eea0d0
PE
7503 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7504
b69769da 7505 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7506
f9541e84
PE
7507 * xdisp.c (vmessage): Mark as a printf-like function.
7508
13841b55
PE
7509 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7510
c136c10f
PE
7511 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7512
5e2d4a30
PE
7513 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7514 printf-like functions.
7515 (tiff_load): Add casts to remove these marks before passing them
7516 to system-supplied API.
7517
583f48b9
PE
7518 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7519
b25d760e
PE
7520 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7521 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7522 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7523 directly, rather than having caller test rule sign. This avoids
7524 some unnecessary tests.
7525 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7526 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7527 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7528
bc7b6697 7529 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7530 (xfont_open): Avoid unnecessary tests.
bc7b6697 7531
27ccc379
PE
7532 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7533
dcd5c89a
PE
7534 * composite.h, composite.c (composition_gstring_put_cache):
7535 Use EMACS_INT, not int, for length.
7536
b13a45c6
PE
7537 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7538 breaking out part of COMPOSITION_DECODE_RULE.
7539 (COMPOSITION_DECODE_RULE): Use it.
7540 * composite.c (get_composition_id): Remove unused local vars,
7541 by using the new macro.
7542
1e792e4d
PE
7543 * textprop.c (set_text_properties_1): Change while to do-while,
7544 since the condition is always true at first.
7545
dc6c6455 7546 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7547 (interval_deletion_adjustment): Return unsigned value.
7548 All uses changed.
dc6c6455 7549
aba7731a
PE
7550 * process.c (list_processes_1, create_pty, read_process_output):
7551 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7552 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7553 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7554 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7555 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7556
fdfc4bf3
PE
7557 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7558
fca8fe46 7559 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7560 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7561
06a0259a 7562 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7563 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7564 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7565
e7b9e80f
PE
7566 * print.c (print_error_message): Avoid int overflow.
7567
56201685
PE
7568 * font.c (font_list_entities): Redo for clarity,
7569 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7570
78834453 7571 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7572 (font_score): Avoid potential overflow in diff calculation.
78834453 7573
0bc0b309 7574 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7575 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7576
e610eaca
PE
7577 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7578
b895abce
PE
7579 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7580 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7581 can always succeed if overflow has undefined behavior.
7582
1f1d9321 7583 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7584 (wordify): Omit three unnecessary tests.
1f1d9321 7585
c59478bc
PE
7586 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7587 All callers changed. This avoids the need for an unused var.
7588
79b73827
PE
7589 * casefiddle.c (casify_region): Remove var that is set but not used.
7590
a4db5dfe
PE
7591 * dired.c (file_name_completion): Remove var that is set but not used.
7592
43aae36e
PE
7593 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7594
2a47c44d 7595 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7596 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7597
a37c69bf
PE
7598 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7599 Check for integer overflow on size calculations.
7600
328ab8e7
PE
7601 * buffer.c (Fprevious_overlay_change): Remove var that is set
7602 but not used.
7603
e5a2a5cb
PE
7604 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7605 Remove vars that are set but not used.
8d84a6eb 7606 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7607 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7608
a60e5f68
PE
7609 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7610
f661cb61 7611 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7612 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7613
f0397f5a
PE
7614 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7615 that are set but not used.
7616
8664db06 7617 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7618 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7619
6abdaa4a
PE
7620 * xselect.c (x_get_local_selection, x_handle_property_notify):
7621 Remove vars that are set but not used.
7622
0ce7538d 7623 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7624 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7625
9ae848fc
PE
7626 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7627 Remove var that is set but not used.
0b918413
PE
7628 (scroll_bar_windows_size): Now size_t, not int.
7629 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7630 Check for overflow.
9ae848fc 7631
a5a62657
PE
7632 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7633 (map_tty_color) [!defined MSDOS]: Likewise.
7634
5c5cdd39
PE
7635 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7636
66ebf983
PE
7637 * coding.c: Remove vars that are set but not used.
7638 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7639 All callers changed.
7640 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7641 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7642 (decode_coding_charset): Remove vars that are set but not used.
7643
1be4d761
PE
7644 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7645 that is set but not used.
7646
47553fa8
PE
7647 * print.c (print_object): Remove var that is set but not used.
7648
1f7196bf 7649 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7650 The gnulib version avoids calling malloc in the usual case,
7651 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7652 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7653 * filelock.c (current_lock_owner): Likewise.
7654 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7655 * sysdep.c: Include allocator.h, careadlinkat.h.
7656 (emacs_no_realloc_allocator): New static constant.
7657 (emacs_readlink): New function.
fdb61804
PE
7658 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7659 ../lib/careadlinkat.h.
d1fdcab7 7660
f84c17c7
SM
76612011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7662
7663 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7664 first non-nil return value).
7665
ef3862ad
JD
76662011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7667
7668 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7669 if not defined (Bug#8403).
7670
376a7006
JB
76712011-04-02 Juanma Barranquero <lekktu@gmail.com>
7672
7673 * xdisp.c (display_count_lines): Remove parameter `start',
7674 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7675 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7676 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7677 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7678 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7679 and thereabouts. All callers changed.
7680 (get_per_char_metric): Remove parameter `f', unused since
7681 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7682
6ca3801d
JM
76832011-04-02 Jim Meyering <meyering@redhat.com>
7684
7685 do not dereference NULL upon failed strdup
7686 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7687 (ns_get_family): Likewise.
7688
d8e2b5ba
JB
76892011-04-02 Juanma Barranquero <lekktu@gmail.com>
7690
7691 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7692
8c74fcbd
JD
76932011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7694
7695 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7696 later (Bug#8403).
7697
7200d79c
SM
76982011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7699
03408648 7700 Add lexical binding.
7200d79c 7701
03408648
SM
7702 * window.c (Ftemp_output_buffer_show): New fun.
7703 (Fsave_window_excursion):
7704 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7705
7706 * lread.c (lisp_file_lexically_bound_p): New function.
7707 (Fload): Bind Qlexical_binding.
7708 (readevalloop): Remove `evalfun' arg.
7709 Bind Qinternal_interpreter_environment.
7710 (Feval_buffer): Bind Qlexical_binding.
7711 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7712 Mark as dynamic.
7713 (syms_of_lread): Declare `lexical-binding'.
7714
7715 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7716
7717 * keyboard.c (eval_dyn): New fun.
7718 (menu_item_eval_property): Use it.
ca105506
SM
7719
7720 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7721
03408648
SM
7722 * fns.c (concat, mapcar1): Accept byte-code-functions.
7723
7724 * eval.c (Fsetq): Handle lexical vars.
7725 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7726 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7727 (FletX, Flet): Obey lexical binding.
7728 (Fcommandp): Handle closures.
7729 (Feval): New `lexical' arg.
7730 (eval_sub): New function extracted from Feval. Use it almost
7731 everywhere where Feval was used. Look up vars in lexical env.
7732 Handle closures.
7733 (Ffunctionp): Move from subr.el.
7734 (Ffuncall): Handle closures.
7735 (apply_lambda): Remove `eval_flags'.
7736 (funcall_lambda): Handle closures and new byte-code-functions.
7737 (Fspecial_variable_p): New function.
7738 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7739 but without exporting it to Lisp.
23aba0ea 7740
23aba0ea 7741 * doc.c (Fdocumentation, store_function_docstring):
03408648 7742 * data.c (Finteractive_form): Handle closures.
23aba0ea 7743
03408648
SM
7744 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7745 interactive spec.
ba83908c 7746
04f2d78b
CB
7747 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7748 New byte-codes.
03408648
SM
7749 (exec_byte_code): New function extracted from Fbyte_code to handle new
7750 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7751
03408648 7752 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7753
03408648 7754 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7755
e2abce01
JB
77562011-03-31 Juanma Barranquero <lekktu@gmail.com>
7757
7758 * xdisp.c (redisplay_internal): Fix prototype.
7759
63696a73 77602011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7761
63696a73 7762 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7763 (try_scrolling): Use it when setting scroll_limit.
7764 Limit scrolling to 100 screen lines.
63696a73
EZ
7765 (redisplay_window): Even when falling back on "recentering",
7766 position point in the window according to scroll-conservatively,
7767 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7768
7769 (try_scrolling): When point is above the window, allow searching
7770 as far as scroll_max, or one screenful, to compute vertical
7771 distance from PT to the scroll margin position. This prevents
7772 try_scrolling from unnecessarily failing when
7773 scroll-conservatively is set to a value slightly larger than the
7774 window height. Clean up the case of PT below the margin at bottom
7775 of window: scroll_max can no longer be INT_MAX. When aggressive
7776 scrolling is in use, don't let point enter the opposite scroll
7777 margin as result of the scroll.
7778 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7779 threshold of 100 lines for never-recentering scrolling.
7780
e4cc2dfc
JB
77812011-03-31 Juanma Barranquero <lekktu@gmail.com>
7782
7783 * dispextern.h (move_it_by_lines):
7784 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7785 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7786 (message_log_check_duplicate): Remove parameters `prev_bol' and
7787 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7788 (redisplay_internal): Remove parameter `preserve_echo_area',
7789 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7790
7791 * indent.c (Fvertical_motion):
7792 * window.c (window_scroll_pixel_based, Frecenter):
7793 Don't pass `need_y_p' to `move_it_by_lines'.
7794
1c470562
SM
77952011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7796
44f230aa
SM
7797 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7798 steal a few bits to be more compact.
7799 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7800 Remove unneeded casts.
7801
1c470562
SM
7802 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7803
888adce9
ZK
78042011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7805
7806 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7807 binding" message (bug#7967).
7808
f838ed7b
PE
78092011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7810
77861b95
PE
7811 Fix more problems found by GCC 4.6.0's static checks.
7812
de6dbc14
PE
7813 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7814 Remove unused local var.
7815
f838ed7b
PE
7816 * editfns.c (Fmessage_box): Remove unused local var.
7817
792c7b2b
PE
7818 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7819 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7820 Omit unused local vars.
c499e557 7821 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7822 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7823 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7824 Omit unused local var.
7825
ba0165e1
PE
7826 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7827 Don't assume string length fits in int.
32ad8845 7828 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7829 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7830
3c59b4c9
PE
7831 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7832 instead of alloca (Bug#8344).
7833
a3eed478 7834 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7835 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7836
eb4d412d
PE
7837 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7838
1658b401
PE
7839 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7840 concerns.
7841
7842 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7843
7844 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7845
9a2c6e05
PE
7846 * keyboard.c (syms_of_keyboard): Use the same style as later
7847 in this function when indexing through an array. This also
7848 works around GCC bug 48267.
7849
03d0a109
PE
7850 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7851
44f730c8
PE
7852 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7853
fe75f926
PE
7854 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7855 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7856
ffa8c828
PE
7857 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7858 This avoids undefined behavior on integer overflow, and is a bit
7859 more convenient anyway since it is compared to a size_t variable.
7860
c5101a77
PE
7861 Variadic C functions now count arguments with size_t, not int.
7862 This avoids an unnecessary limitation on 64-bit machines, which
7863 caused (substring ...) to crash on large vectors (Bug#8344).
7864 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7865 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7866 All variadic functions and their callers changed accordingly.
c5101a77
PE
7867 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7868 * data.c (arith_driver, float_arith_driver): Likewise.
7869 * editfns.c (general_insert_function): Likewise.
7870 * eval.c (struct backtrace.nargs, interactive_p)
7871 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7872 (funcall_lambda, mark_backtrace): Likewise.
7873 * fns.c (concat): Likewise.
7874 * frame.c (x_set_frame_parameters): Likewise.
7875 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7876 0 if not found, not -1. All callers changed.
7877
dd3f25f7
PE
7878 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7879 (stack_copy_size): Now size_t, not int.
7880 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7881
461c2ab9
JB
78822011-03-28 Juanma Barranquero <lekktu@gmail.com>
7883
7884 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7885 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7886 All callers changed.
7887
7888 * lisp.h (multibyte_char_to_unibyte):
7889 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7890 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7891 * character.h (CHAR_TO_BYTE8):
7892 * cmds.c (internal_self_insert):
7893 * editfns.c (general_insert_function):
7894 * keymap.c (push_key_description):
7895 * search.c (Freplace_match):
7896 * xdisp.c (message_dolog, set_message_1): All callers changed.
7897
f6d62986
SM
78982011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7899
7900 * keyboard.c (safe_run_hook_funcall): New function.
7901 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7902 don't set the hook to nil, but remove the offending function instead.
7903 (Qcommand_hook_internal): Remove, unused.
7904 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7905 Vcommand_hook_internal.
7906
7907 * eval.c (enum run_hooks_condition): Remove.
7908 (funcall_nil, funcall_not): New functions.
7909 (run_hook_with_args): Call each function through a `funcall' argument.
7910 Remove `cond' argument, now redundant.
7911 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7912 (Frun_hook_with_args_until_failure): Adjust accordingly.
7913 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7914
1db5b1ad
JB
79152011-03-28 Juanma Barranquero <lekktu@gmail.com>
7916
7917 * dispextern.h (string_buffer_position): Remove declaration.
7918
7919 * print.c (strout): Remove parameter `multibyte', unused since
7920 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7921
7922 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7923 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7924 All callers changed.
7925
7926 * w32.c (_wsa_errlist): Use braces for struct initializers.
7927
7928 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7929 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7930 All callers changed.
7931 (string_buffer_position): Likewise. Also, make static (it's never
7932 used outside xdisp.c).
7933 (cursor_row_p): Remove parameter `w', unused since
7934 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7935 (decode_mode_spec): Remove parameter `precision', introduced during
7936 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7937 All callers changed.
7938
5ffb62aa
JD
79392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7940
7941 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7942
461c2ab9 79432011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7944
7945 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7946 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7947 (ns_update_auto_hide_menu_bar): New functions.
7948 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7949 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7950 ns_constrain_all_frames.
7951 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7952 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7953
5c380ffb
JD
79542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7955
7956 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7957
9af30bdf
GM
79582011-03-27 Glenn Morris <rgm@gnu.org>
7959
7960 * syssignal.h: Replace RETSIGTYPE with void.
7961 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7962 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7963 Replace SIGTYPE with void everywhere.
7964 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7965 * s/template.h (SIGTYPE): Remove commented out definition.
7966
e2abce01
JB
79672011-03-26 Eli Zaretskii <eliz@gnu.org>
7968
7969 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7970 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7971
f868cd8a
JB
79722011-03-26 Juanma Barranquero <lekktu@gmail.com>
7973
59eb0929
JB
7974 * w32.c (read_unc_volume): Use parameter `henum', instead of
7975 global variable `wget_enum_handle'.
7976
7977 * keymap.c (describe_vector): Remove parameters `indices' and
7978 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7979 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7980
f868cd8a
JB
7981 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7982
7983 * keyboard.c (timer_check): Remove parameter `do_it_now',
7984 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7985 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7986 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7987
7988 * keyboard.c (read_char):
7989 * w32menu.c (w32_menu_display_help):
7990 * xmenu.c (show_help_event, menu_help_callback):
7991 Adjust calls to `show_help_echo'.
7992
7993 * gtkutil.c (xg_maybe_add_timer):
7994 * keyboard.c (readable_events):
7995 * process.c (wait_reading_process_output):
7996 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7997
7998 * insdel.c (adjust_markers_gap_motion):
7999 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8000 (gap_left, gap_right): Don't call it.
8001
2ecf6fdb
CY
80022011-03-25 Chong Yidong <cyd@stupidchicken.com>
8003
8004 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8005 incurred during fontification.
8006
6b1f9ba4
JB
80072011-03-25 Juanma Barranquero <lekktu@gmail.com>
8008
8009 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8010 (DEFVAR_PER_BUFFER): Don't pass it.
8011
8012 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8013 (scrolling_window): Don't pass it.
8014
0f4a96b5
JB
80152011-03-25 Juanma Barranquero <lekktu@gmail.com>
8016
8017 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8018
8019 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8020 and `suffix'.
8021 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8022 of variables specific to SELinux and computation of `encoded_absname'.
8023
8024 * image.c (XPutPixel): Remove unused variable `height'.
8025
8026 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8027
8028 * unexw32.c (get_section_info): Remove unused variable `section'.
8029
8030 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8031 (system_process_attributes): Remove unused variable `sess'.
8032 (sys_read): Remove unused variable `err'.
8033
8034 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8035 (w32_wnd_proc): Remove unused variable `isdead'.
8036 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8037 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8038 (x_create_tip_frame): Remove unused variable `tem'.
8039
8040 * w32inevt.c (w32_console_read_socket):
8041 Remove unused variable `no_events'.
8042
8043 * w32term.c (x_draw_composite_glyph_string_foreground):
8044 Remove unused variable `width'.
8045
1149507c
JB
80462011-03-24 Juanma Barranquero <lekktu@gmail.com>
8047
8048 * w32term.c (x_set_glyph_string_clipping):
8049 Don't pass uninitialized region to CombineRgn.
8050
9c88f339
JB
80512011-03-23 Juanma Barranquero <lekktu@gmail.com>
8052
8053 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8054 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8055 (Fx_close_connection): Remove unused variable `i'.
8056
8057 * w32font.c (w32font_draw): Return number of glyphs.
8058 (w32font_open_internal): Remove unused variable `i'.
8059 (w32font_driver): Add missing initializer.
8060
8061 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8062 (fill_in_menu): Remove unused variable `items_added'.
8063
8064 * w32term.c (last_mouse_press_frame): Remove static global variable.
8065 (w32_clip_to_row): Remove unused variable `f'.
8066 (x_delete_terminal): Remove unused variable `i'.
8067
8068 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8069 (NOTHING): Remove unused static global variable.
8070 (uniscribe_check_otf): Remove unused variable `table'.
8071 (uniscribe_font_driver): Add missing initializers.
8072
dee091a3
JD
80732011-03-23 Julien Danjou <julien@danjou.info>
8074
8075 * term.c (Fsuspend_tty, Fresume_tty):
8076 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8077 * window.c (temp_output_buffer_show):
8078 * insdel.c (signal_before_change):
8079 * frame.c (Fhandle_switch_frame):
8080 * fileio.c (Fdo_auto_save):
8081 * emacs.c (Fkill_emacs):
8082 * editfns.c (save_excursion_restore):
8083 * cmds.c (internal_self_insert):
8084 * callint.c (Fcall_interactively):
8085 * buffer.c (Fkill_all_local_variables):
8086 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8087 Use Frun_hooks.
0f4a96b5 8088 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8089 unconditionally since it does the check itself.
dee091a3 8090
2c520ab5 80912011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8092
c9c49752
PE
8093 Fix more problems found by GCC 4.5.2's static checks.
8094
8abc3f12
PE
8095 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8096 the first time through the loop, since we know p0 < p1 then.
8097 This also avoids a gcc -Wstrict-overflow warning.
8098
a2d26660
PE
8099 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8100 leading to a memory leak, possible in functions like
8101 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8102 of objects (Bug#8318).
a2d26660 8103
916c72e9
PE
8104 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8105 that could (at least in theory) be that large.
8106
19ab8a18
PE
8107 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8108 This is less likely to overflow, and avoids undefined behavior if
8109 overflow does occur. All callers changed. Use strtoul to scan
8110 for the unsigned long integer.
b7cbbd6f
PE
8111 (pint2hrstr): Simplify and tune code slightly.
8112 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8113
f0641eff
PE
8114 * scroll.c (do_scrolling): Work around GCC bug 48228.
8115 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8116
7f650bb9
PE
8117 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8118 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8119 (validate_x_resource_name): Simplify count usage.
8120 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8121
37dd57d1
PE
8122 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8123 fail (Bug#8306).
81e56e61 8124
699979fc 8125 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8126
401bf9b4
PE
8127 * process.c (Fmake_network_process): Use socklen_t, not int,
8128 where POSIX says socklen_t is required in portable programs.
8129 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8130 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8131 (Fmake_network_process, server_accept_connection):
8132 (wait_reading_process_output, read_process_output):
8133 Likewise.
8134
b93aacde
PE
8135 * process.c: Rename or move locals to avoid shadowing.
8136 (list_processes_1, Fmake_network_process):
8137 (read_process_output_error_handler, exec_sentinel_error_handler):
8138 Rename or move locals.
4dc343ee 8139 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8140 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8141 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8142 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8143 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8144
af8a867c 8145 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8146 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8147 Include tparam.h instead, since it declares them.
af8a867c
PE
8148 * cm.h (PC): Remove extern decl; tparam.h now does this.
8149 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8150 * terminfo.c: Include tparam.h, to check interfaces.
8151 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8152 (tparam): Adjust signature to match interface in tparam.h;
8153 this removes some undefined behavior. Check that outstring and len
8154 are zero, which they always are with Emacs.
8155 * tparam.h (PC, BC, UP): New extern decls.
8156
0248044d 8157 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8158 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8159
8ff096c1 8160 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8161 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8162 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8163 (ftfont_list): Remove unused local.
49eaafba
PE
8164 (get_adstyle_property, ftfont_pattern_entity):
8165 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8166 Rename locals to avoid shadowing.
8ff096c1 8167
e2be39f6
PE
8168 * xfont.c (xfont_list_family): Mark var as initialized.
8169
c9735e30
PE
8170 * xml.c (make_dom): Now static.
8171
8f5201ae
PE
8172 * composite.c (composition_compute_stop_pos): Rename local to
8173 avoid shadowing.
b246f932
PE
8174 (composition_reseat_it): Remove unused locals.
8175 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8176 (composition_update_it): Mark var as initialized.
11b61122
PE
8177 (find_automatic_composition): Mark vars as initialized,
8178 with a FIXME (Bug#8290).
8f5201ae 8179
760fbc2c
PE
8180 character.h: Rename locals to avoid shadowing.
8181 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8182 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8183 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8184 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8185 to avoid shadowing.
8186
ff08eb85
PE
8187 * textprop.c (property_change_between_p): Remove; unused.
8188
fc7bf025
PE
8189 * intervals.c (interval_start_pos): Now static.
8190
235d7abc
PE
8191 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8192
44f230aa
SM
8193 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8194 Rename locals to avoid shadowing.
3e7d6594 8195
50060332
PE
8196 * sound.c (wav_play, au_play, Fplay_sound_internal):
8197 Fix pointer signedness.
d01f234b 8198 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8199 (wav_play): Initialize a variable to 0, to prevent undefined
8200 behavior (Bug#8278).
50060332 8201
c4fc4e30
PE
8202 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8203
918436ed
PE
8204 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8205
c939f91b
PE
8206 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8207 clobbering (Bug#8298).
b9c7f648
PE
8208 * sysdep.c (sys_subshell): Likewise.
8209 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8210
6bd8c144
PE
8211 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8212 This should get cleaned up, so that child_setup has the
8213 same signature on all platforms.
8214
7710357c 8215 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8216 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8217
c59da222
CY
82182011-03-22 Chong Yidong <cyd@stupidchicken.com>
8219
8220 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8221 not to be necessary, and produces flickering.
8222
66b87493
GM
82232011-03-20 Glenn Morris <rgm@gnu.org>
8224
8225 * config.in: Remove file.
8226
45b6f6d5
JB
82272011-03-20 Juanma Barranquero <lekktu@gmail.com>
8228
8229 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8230 are now in src/globals.h.
8231 (syms_of_minibuf): Remove spurious & from previous change.
8232
3ec03f7e
LL
82332011-03-20 Leo <sdl.web@gmail.com>
8234
8235 * minibuf.c (completing-read-function): New variable.
8236 (completing-read-default): Rename from completing-read.
8237 (completing-read): Call completing-read-function.
8238
b14e3e21
CY
82392011-03-19 Juanma Barranquero <lekktu@gmail.com>
8240
8241 * xfaces.c (Fx_load_color_file):
8242 Read color file from absolute filename (bug#8250).
8243
f2b726e6
JB
82442011-03-19 Juanma Barranquero <lekktu@gmail.com>
8245
8246 * makefile.w32-in: Update dependencies.
8247
09f6ff02
EZ
82482011-03-17 Eli Zaretskii <eliz@gnu.org>
8249
8250 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8251
29a6015a
PE
82522011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8253
a3a6c54e
PE
8254 Fix more problems found by GCC 4.5.2's static checks.
8255
b766f867
PE
8256 * process.c (make_serial_process_unwind, send_process_trap):
8257 (sigchld_handler): Now static.
8258
be02381c
PE
8259 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8260 That way, the code declares only the vars that it needs.
8261 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8262 * s/cygwin.h (PTY_ITERATION): Likewise.
8263 * s/darwin.h (PTY_ITERATION): Likewise.
8264 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8265
57048744
PE
8266 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8267 * process.c (allocate_pty): Don't declare stb unless it's needed.
8268
7914961c 8269 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8270 (CONSTANTLIM): Remove; unused.
8271 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8272 Define only if needed.
7914961c 8273
b3967b18
PE
8274 * unexelf.c (unexec): Name an expression,
8275 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8276 Use a different way to cause a compilation error if anyone uses
8277 n rather than nn, a way that does not involve shadowing.
73366a00 8278 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8279
29a6015a
PE
8280 * deps.mk (unexalpha.o): Remove; unused.
8281
43cfc33e 8282 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8283 * unexec.h: New file.
ce701a33
PE
8284 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8285 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8286 Depend on unexec.h.
8287 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8288 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8289 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8290 Change as necessary to match prototype in unexec.h.
ce701a33 8291
01f44d5a
PE
8292 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8293 shadowing.
4f63c6bb 8294 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8295
a6670b0b
PE
8296 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8297 Rename locals to avoid shadowing.
8298
cef2010d 8299 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8300 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8301
d4d7173a
PE
8302 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8303
f08b802a
PE
8304 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8305 warning when compiling print.c.
8306
3ddb0639
PE
8307 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8308 instead of using an uninitialized var.
5ad03b97 8309 (font_sort_entities): Mark var as initialized.
3ddb0639 8310
170a2692
PE
8311 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8312
e663c700
PE
8313 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8314 pointers to constants.
89bc529a 8315 (font_parse_fcname): Remove unused vars.
7b81e2d0 8316 (font_delete_unmatched): Now static.
ea838e10 8317 (font_get_spec): Remove; unused.
13a547c6
PE
8318 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8319 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8320 Rename or move locals to avoid shadowing.
e663c700 8321
2a80c887 8322 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8323 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8324
1384fa33 8325 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8326 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8327
8b2c52e9
PE
8328 * alloc.c (mark_backtrace): Move decl from here ...
8329 * lisp.h: ... to here, so that it can be checked.
8330
475545b5 8331 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8332 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8333 (lisp_indirect_variable): Name an expression,
8334 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8335 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8336
b1349114 8337 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8338 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8339 Use const pointer when appropriate.
b1349114 8340
a2928364
PE
8341 * lisp.h (get_system_name, get_operating_system_release):
8342 Move decls here, to check interfaces.
8343 * process.c (get_operating_system_release): Move decl to lisp.h.
8344 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8345 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8346 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8347 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8348 (Fformat_time_string, Fencode_time, Finsert_char):
8349 (Ftranslate_region_internal, Fformat):
8350 Rename or remove local vars to avoid shadowing.
9710023e 8351 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8352
a415e694
PE
8353 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8354 avoid shadowing.
8355
8ef4622d
PE
8356 * lisp.h (eassert): Check that the argument compiles, even if
8357 ENABLE_CHECKING is not defined.
8358
946f9a5b
PE
8359 * data.c (Findirect_variable): Name an expression, to avoid
8360 gcc -Wbad-function-cast warning.
112396d6 8361 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8362 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8363 (Fmake_variable_buffer_local, Fmake_local_variable):
8364 Mark variables as initialized.
52746918 8365 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8366
e5aab7e7 8367 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8368 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8369 Rename locals to avoid shadowing.
dff45157
PE
8370 (mark_stack): Move local variables into the #ifdef region where
8371 they're used.
7bc26fdb
PE
8372 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8373 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8374 needed otherwise.
8375 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8376 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8377 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8378
e5aab7e7
PE
8379 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8380 avoids undefined behavior in theory.
8381
4da60324
PE
8382 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8383
88043301
PE
8384 Use functions, not macros, for up- and down-casing (Bug#8254).
8385 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8386 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8387 to use the following functions instead of these macros.
8388 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8389 EMACS_INT, since callers assume the returned value fits in int.
8390 (upcase1): Likewise, for UPCASE_TABLE.
8391 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8392 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8393 the race-condition problem in the old DOWNCASE.
88043301 8394
19ed5445
PE
8395 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8396 Rename locals to avoid shadowing.
8397 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8398 (regex_compile, re_search_2, re_match_2_internal):
8399 Remove unused local vars.
952db0d7
PE
8400 (FREE_VAR): Rewrite so as not to use empty "else",
8401 which gcc can warn about.
da053e48 8402 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8403 (RETALLOC_IF): Define only if needed.
8404 (WORDCHAR_P): Likewise. This one is never needed, but is used
8405 only in a comment talking about a compiler bug, so put inside
8406 the #if 0 of that comment.
8407 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8408 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8409 Remove; unused.
19ed5445 8410
1f3561e4 8411 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8412 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8413 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8414
ded6f8f7
PE
8415 * search.c (simple_search): Remove unused var.
8416
dbd37a95
PE
8417 * dired.c (compile_pattern): Move decl from here ...
8418 * lisp.h: ... to here, so that it can be checked.
8419 (struct re_registers): New forward decl.
8420
7e47afad
PE
8421 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8422
85f24f61
PE
8423 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8424 All uses changed.
8425 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8426 Rename locals to avoid shadowing.
5671df8f 8427 (Fvertical_motion): Mark locals as initialized.
85f24f61 8428
181aa2be 8429 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8430 (casify_region): Mark local as initialized.
181aa2be 8431
930d429c
PE
8432 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8433
7082eac6
PE
8434 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8435 New macros, so that the caller can use some names other than
8436 gcpro1, gcpro2, etc.
8437 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8438 of the new macros.
8439 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8440 argument, for consistency with GCPRO2_VAR, etc: it is now the
8441 prefix of the variable, not the variable itself. All uses
8442 changed.
38b2c076
PE
8443 * dired.c (directory_files_internal, file_name_completion):
8444 Rename locals to avoid shadowing.
8445
15206ed9
PE
8446 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8447 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8448 dired.c's scmp function, had undefined behavior.
8449 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8450 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8451 * buffer.h: ... to here, because these macros use current_buffer,
8452 and the new implementation with inline functions needs to have
8453 current_buffer in scope now, rather than later when the macros
8454 are used.
8455 (downcase, upcase1): New static inline functions.
8456 (DOWNCASE, UPCASE1): Reimplement using these functions.
8457 This avoids undefined behavior in expressions like
8458 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8459 from race conditions in accessing the global variables
8460 case_temp1 and case_temp2.
8461 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8462 * lisp.h (case_temp1, case_temp2): Remove their decls.
8463 * character.h (ASCII_CHAR_P): Move from here ...
8464 * lisp.h: ... to here, so that the inline functions mentioned
8465 above can use them.
8466
4a6bea26
PE
8467 * dired.c (directory_files_internal_unwind): Now static.
8468
f14b7e14
PE
8469 * fileio.c (file_name_as_directory, directory_file_name):
8470 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8471 Now static.
2893f146
PE
8472 (file_name_as_directory): Use const pointers when appropriate.
8473 (Fexpand_file_name): Likewise. In particular, newdir might
8474 point at constant storage, so make it a const pointer.
fd4ead52 8475 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8476 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8477 signedness issues.
f839df0c
PE
8478 (Fset_file_times, Finsert_file_contents, auto_save_error):
8479 Rename locals to avoid shadowing.
f14b7e14 8480
5716756e 8481 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8482 (Ftry_completion, Fall_completions): Rename or remove locals
8483 to avoid shadowing.
5716756e 8484
b4c3046a
PE
8485 * marker.c (bytepos_to_charpos): Remove; unused.
8486
b45db522
PE
8487 * lisp.h (verify_bytepos, count_markers): New decls,
8488 so that gcc does not warn that these functions aren't declared.
8489
85876d07
PE
8490 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8491 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8492 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8493 (copy_text): Remove unused local var.
85876d07 8494
03d78a21 8495 * filelock.c (within_one_second): Now static.
b3dd38ab 8496 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8497
5df8f01b
PE
8498 * buffer.c (fix_overlays_before): Mark locals as initialized.
8499 (fix_start_end_in_overlays): Likewise. This function should be
8500 simplified by using pointers-to-pointers, but that's a different
8501 matter.
b1d876f1 8502 (switch_to_buffer_1): Now static.
8f54f30a
PE
8503 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8504 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8505
a70072c9 8506 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8507 Fix pointer signedness issue.
edced198
PE
8508 (sys_subshell): Mark local as volatile if checking for lint,
8509 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8510 (MAXPATHLEN): Define only if needed.
a70072c9 8511
a0977c44
PE
8512 * process.c (serial_open, serial_configure): Move decls from here ...
8513 * systty.h: ... to here, so that they can be checked.
8514
a884fdcc
PE
8515 * fns.c (get_random, seed_random): Move extern decls from here ...
8516 * lisp.h: ... to here, so that they can be checked.
8517
604efe86 8518 * sysdep.c (reset_io): Now static.
b8950c94 8519 (wait_for_termination_signal): Remove; unused.
604efe86 8520
38fc62d9
PE
8521 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8522 (copy_keymap_item, append_key, push_text_char_description):
8523 Now static.
1004a21a 8524 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8525 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8526 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8527 (describe_map_tree):
8528 Rename locals to avoid shadowing.
38fc62d9 8529
2f2650da
PE
8530 * keyboard.c: Declare functions static if they are not used elsewhere.
8531 (echo_char, echo_dash, cmd_error, top_level_2):
8532 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8533 (read_char, kbd_buffer_get_event, make_lispy_position):
8534 (make_lispy_event, make_lispy_movement, apply_modifiers):
8535 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8536 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8537 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8538 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8539 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8540
a053e86c 8541 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8542 (mark_kboards): Move decl here ...
8543 * alloc.c (mark_kboards): ... from here.
a053e86c 8544
4752793e
PE
8545 * lisp.h (force_auto_save_soon): New decl.
8546
74f10ca7 8547 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8548 (DEFINE_DUMMY_FUNCTION): New macro.
8549 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8550 Use it.
c03cd23f
PE
8551 (main): Add casts to avoid warnings
8552 if GCC considers string literals to be constants.
74f10ca7 8553
022e70d4
PE
8554 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8555
59d6fe83
PE
8556 * dbusbind.c: Pointer signedness fixes.
8557 (xd_signature, xd_append_arg, xd_initialize):
8558 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8559 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8560 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8561 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8562
78320123
PE
8563 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8564 if GCC considers string literals to be constants.
49cebcca 8565 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8566
35ac2a97
SM
85672011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8568
fb103ca9
SM
8569 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8570 (print_preprocess, print_object): New macro to fix last change.
8571
35ac2a97
SM
8572 * print.c (print_preprocess): Don't forget font objects.
8573
62973b41
JB
85742011-03-16 Juanma Barranquero <lekktu@gmail.com>
8575
8576 * emacs.c (USAGE3): Doc fixes.
8577
0e48bb22
AS
85782011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8579
8580 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8581 structure.
8582
7684e57b
JB
85832011-03-14 Juanma Barranquero <lekktu@gmail.com>
8584
8585 * lisp.h (VWindow_system, Qfile_name_history):
8586 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8587 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8588 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8589
8590 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8591 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8592
8593 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8594 * w32console.c (detect_input_pending, read_input_pending)
8595 (encode_terminal_code):
8596 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8597 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8598 (w32_system_caret_y, Qfile_name_history):
8599 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8600 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8601 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8602 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8603 * w32proc.c (Qlocal, report_file_error):
8604 * w32term.c (Vwindow_system, updating_frame):
8605 * w32uniscribe.c (initialized, uniscribe_font_driver):
8606 Remove unneeded extern declarations.
8607
2aa46d6c
CY
86082011-03-14 Chong Yidong <cyd@stupidchicken.com>
8609
c96bbc66 8610 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8611
cffc6f3b
CY
86122011-03-13 Chong Yidong <cyd@stupidchicken.com>
8613
8614 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8615 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8616 These macros can no longer be used for assignment.
8617
44f230aa
SM
8618 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8619 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8620 (record_buffer_markers, fetch_buffer_markers): New functions for
8621 recording and fetching special buffer markers.
8622 (set_buffer_internal_1, set_buffer_temp): Use them.
8623
8624 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8625
8626 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8627
8628 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8629 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8630
8631 * xdisp.c (hscroll_window_tree):
8632 (reconsider_clip_changes): Use PT instead of BUF_PT.
8633
d251f04b
EZ
86342011-03-13 Eli Zaretskii <eliz@gnu.org>
8635
8636 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8637 $(EMACS_ROOT)/lib/intprops.h.
8638
f0c77cd1
PE
86392011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8640
3eca4629
PE
8641 Fix more problems found by GCC 4.5.2's static checks.
8642
7c86ee98
PE
8643 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8644 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8645 (xg_free_frame_widgets): Make it clear that a local variable is
8646 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8647 (gdk_window_get_screen): Make it clear that this macro is needed
8648 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8649 (int_gtk_range_get_value): New function, which avoids a diagnostic
8650 from gcc -Wbad-function-cast.
8651 (xg_set_toolkit_scroll_bar_thumb): Use it.
8652 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8653 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8654 (get_utf8_string, xg_get_file_with_chooser):
8655 Rename locals to avoid shadowing.
8656 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8657
41729b81
PE
8658 * xgselect.c (xg_select): Remove unused var.
8659
f0c77cd1
PE
8660 * image.c (four_corners_best): Mark locals as initialized.
8661 (gif_load): Initialize transparent_p to zero (Bug#8238).
8662 Mark another local as initialized.
ec6cf4c6 8663 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8664
ce0ad53d 8665 * image.c (clear_image_cache): Now static.
d5d5a617 8666 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8667 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8668 (x_edge_detection): Remove unnecessary cast that
8669 gcc -Wbad-function-cast diagnoses.
2037898d 8670 (gif_load): Fix pointer signedness.
6ae141d6
PE
8671 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8672 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8673
33383987 86742011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8675
d32df629
PE
8676 Improve quality of tests for time stamp overflow.
8677 For example, without this patch (encode-time 0 0 0 1 1
8678 1152921504606846976) returns the obviously-bogus value (-948597
8679 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8680 reports time overflow. See
8681 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8682 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8683 * editfns.c: Include limits.h and intprops.h.
8684 (TIME_T_MIN, TIME_T_MAX): New macros.
8685 (time_overflow): Move earlier, to before first use.
8686 (hi_time, lo_time): New functions, for an accurate test for
8687 out-of-range times.
8688 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8689 (Fget_internal_run_time): Don't assume time_t fits in int.
8690 (make_time): Use list2 instead of Fcons twice.
8691 (Fdecode_time): More accurate test for out-of-range times.
8692 (check_tm_member): New function.
8693 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8694 (lisp_time_argument): Don't rely on undefined left-shift and
8695 right-shift behavior when checking for time stamp overflow.
8be6f318 8696
fe31d94c
PE
8697 * editfns.c (time_overflow): New function, refactoring common code.
8698 (Fformat_time_string, Fdecode_time, Fencode_time):
8699 (Fcurrent_time_string): Use it.
8700
8be6f318
PE
8701 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8702 * dired.c (make_time): Move to ...
8703 * editfns.c (make_time): ... here.
8704 * systime.h: Note the move.
8705
09d9db2c 87062011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8707
126bc0dc
YM
8708 * fringe.c (update_window_fringes): Remove unused variables.
8709
c47cbdfd
YM
8710 * unexmacosx.c (copy_data_segment): Also copy __got section.
8711 (Bug#8223)
8712
7ac80be9
EZ
87132011-03-12 Eli Zaretskii <eliz@gnu.org>
8714
c96bbc66 8715 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8716 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8717 Constify `char *' arguments and their references according to
8718 prototypes in tparam.h.
8719
ecb0f94d 8720 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8721
7ac80be9
EZ
8722 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8723 Adapt all references accordingly.
8724
8725 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8726
ef1fd07e
TT
87272011-03-11 Tom Tromey <tromey@redhat.com>
8728
8729 * buffer.c (syms_of_buffer): Remove obsolete comment.
8730
7ef4b50c
EZ
87312011-03-11 Eli Zaretskii <eliz@gnu.org>
8732
8733 * termhooks.h (encode_terminal_code): Declare prototype.
8734
8735 * msdos.c (encode_terminal_code): Don't declare prototype.
8736
8737 * term.c (encode_terminal_code): Now external again, used by
8738 w32console.c and msdos.c.
8739
44f230aa
SM
8740 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8741 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8742
4b1ec863 87432011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8744
1714f52b 8745 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8746
4b1ec863
PE
8747 * fringe.c (update_window_fringes): Mark locals as initialized
8748 (Bug#8227).
8749 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8750
524c7aa6
PE
8751 * alloc.c (mark_fringe_data): Move decl from here ...
8752 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8753 to check its interface.
8754 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8755
a5c0af81 8756 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8757 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8758 (fontset_font): Mark local as initialized.
a9a06e0b 8759 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8760
b4716021
PE
8761 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8762
811e9bac 8763 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8764 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8765 (x_own_selection, Fx_disown_selection_internal): Rename locals
8766 to avoid shadowing.
8767 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8768
7e3ab302
PE
8769 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8770 so that the caller can use some name other than gcpro1.
8771 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8772 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8773 (Fx_backspace_delete_keys_p):
8774 Use them to avoid shadowing, and rename vars to avoid shadowing.
8775 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8776 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8777 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8778 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8779 Remove unused locals.
7e3ab302
PE
8780 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8781 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8782 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8783 macros.
f78faa98 8784
e2b13473
PE
8785 * xterm.h (x_mouse_leave): New decl.
8786
77f23912
PE
8787 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8788 Remove unused functions.
cdf4ba58
PE
8789 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8790 (x_calc_absolute_position): Now static.
7411c686 8791 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8792 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8793 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8794 unless they are used.
38d0b34a
PE
8795 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8796 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8797 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8798 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8799 (x_error_catcher, x_connection_closed, x_error_handler):
8800 (x_error_quitter, xembed_send_message, x_iconify_frame):
8801 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8802 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8803 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8804
44f230aa
SM
8805 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8806 Rename or move locals to avoid shadowing.
6b463e58 8807 (tty_defined_color, merge_face_heights): Now static.
5967d051 8808 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8809 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8810 does not deduce is never used uninitialized.
73719eba
PE
8811 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8812 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8813
426994c3 8814 * terminal.c (store_terminal_param): Now static.
5489860b 8815
032f1620 8816 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8817 (set_frame_menubar): Remove unused local.
d4323972 8818 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8819 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8820 since they might point to immutable storage.
281585b0
PE
8821 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8822 since it's unused otherwise.
032f1620 8823
367c19e5 8824 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8825 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8826 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8827 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8828 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8829 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8830 does not deduce are never used uninitialized.
70739cbe 8831
07b48fa9
PE
8832 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8833
8868a238 8834 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8835 * window.c (window_loop, size_window):
8836 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8837
7e5cf297 8838 * window.c (display_buffer): Now static.
d6550a9f
PE
8839 (size_window): Mark variables that gcc -Wuninitialized
8840 does not deduce are never used uninitialized.
a586633d
PE
8841 * window.h (check_all_windows): New decl, to forestall
8842 gcc -Wmissing-prototypes diagnostic.
5b555da1 8843 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8844
f6095868
PE
8845 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8846 shadowing.
8847 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8848 Include <limits.h>.
8849 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8850 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8851 (load_charset_map): Mark variables that gcc -Wuninitialized
8852 does not deduce are never used uninitialized.
53df7c11 8853 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8854
f38b440c
PE
8855 * coding.c (coding_set_source, coding_set_destination):
8856 Use "else { /* comment */ }" rather than "else /* comment */;"
8857 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8858 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8859 a block, when the outer 'i' will do.
8860 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8861 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8862 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8863 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8864 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8865 Rename locals to avoid shadowing.
8866 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8867 * coding.c (emacs_mule_char, encode_invocation_designation):
8868 Now static, since they're not used elsewhere.
413bb2db 8869 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8870 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8871 (decode_coding_emacs_mule): Mark variables that gcc
8872 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8873 (detect_coding_iso_2022): Initialize a local variable that might
8874 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8875 this initialization is needed. (Bug#8211)
5f58e762
PE
8876 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8877 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8878 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8879 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8880 Remove unused macros.
f38b440c 8881
232b38b9 8882 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8883 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8884 * character.c (string_count_byte8): Likewise.
232b38b9 8885
fb90da1b
PE
8886 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8887 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8888
fb93dbc2
PE
8889 * chartab.c (copy_sub_char_table): Now static, since it's not used
8890 elsewhere.
5c156ace
PE
8891 (sub_char_table_ref_and_range, char_table_ref_and_range):
8892 Rename locals to avoid shadowing.
bbcd0949 8893 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8894
7d3b3862 8895 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8896 (BIDI_BOB): Remove unused macro.
7d3b3862 8897
6be7d3da
PE
8898 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8899 deduce are never used uninitialized.
c2ed9c8b 8900 * term.c (encode_terminal_code): Likewise.
6be7d3da 8901
75f8807f 8902 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8903
50938595
PE
8904 * tparam.h: New file.
8905 * term.c, tparam.h: Include it.
8906 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8907 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8908 Move these decls to tparam.h, and make them agree with what
8909 is actually in tparam.c. The previous trick of using incompatible
8910 decls in different modules does not conform to the C standard.
8911 All callers of tparam changed to use tparam's actual API.
8912 * tparam.c (tparam1, tparam, tgoto):
8913 Use const pointers where appropriate.
8914
fbceeba2
PE
8915 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8916 * cm.h (struct cm): Likewise.
8917 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8918 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8919 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8920 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8921 (turn_on_face, init_tty): Likewise.
8922 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8923
7f3f1250
PE
8924 * term.c (term_mouse_position): Rename local to avoid shadowing.
8925
e6ca6543
PE
8926 * alloc.c (mark_ttys): Move decl from here ...
8927 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8928
c40f8d15
AS
89292011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8930
8931 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8932
cfe0661d
JB
89332011-03-09 Juanma Barranquero <lekktu@gmail.com>
8934
8935 * search.c (compile_pattern_1): Remove argument regp, unused since
8936 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8937 (compile_pattern): Don't pass it.
8938
0afb4571
J
89392011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8940
8941 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8942 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8943 for ! HAVE_GTK3.
8944 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8945
8946 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8947
8948 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8949 gdk_window_get_screen, gdk_window_get_geometry,
8950 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8951 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8952 (xg_get_pixbuf_from_pixmap): New function.
8953 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8954 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8955 Call xg_get_pixbuf_from_pixmap instead of
8956 gdk_pixbuf_get_from_drawable.
8957 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8958 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8959 (xg_check_special_colors): Use GtkStyleContext and its functions
8960 for HAVE_GTK3.
8961 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8962 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8963 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8964 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8965 Call gtk_widget_get_preferred_size.
0afb4571
J
8966 (xg_frame_resized): gdk_window_get_geometry only takes 5
8967 parameters.
44f230aa
SM
8968 (xg_win_to_widget, xg_event_is_for_menubar):
8969 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8970 (xg_set_widget_bg): New function.
8971 (delete_cb): New function.
895009e1 8972 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8973 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8974 (xg_set_background_color): Call xg_set_widget_bg.
8975 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8976 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8977 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8978 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8979 if ! HAVE_GTK3.
8980 (update_frame_tool_bar): Call gtk_widget_hide.
8981 (xg_initialize): Use GDK_KEY_g.
8982
8983 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8984 if ! HAVE_GTK3
8985 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8986
8987 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8988 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8989 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8990
1c2cc4ef
JB
89912011-03-08 Juanma Barranquero <lekktu@gmail.com>
8992
8993 * w32xfns.c (select_palette): Check success of RealizePalette against
8994 GDI_ERROR, not zero.
8995
33383987 8996See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8997
8998;; Local Variables:
8999;; coding: utf-8
aac0c6e3
MR
9000;; End:
9001
33383987 9002 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
9003
9004 This file is part of GNU Emacs.
9005
9006 GNU Emacs is free software: you can redistribute it and/or modify
9007 it under the terms of the GNU General Public License as published by
9008 the Free Software Foundation, either version 3 of the License, or
9009 (at your option) any later version.
9010
9011 GNU Emacs is distributed in the hope that it will be useful,
9012 but WITHOUT ANY WARRANTY; without even the implied warranty of
9013 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9014 GNU General Public License for more details.
9015
9016 You should have received a copy of the GNU General Public License
9017 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.