* src/alloc.c (mark_object): Revert part of last patch to use `switch'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7555c33f
SM
12012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
4
5 * alloc.c (mark_object): Revert part of last patch to use `switch'.
6
d12e8f5a
DA
72012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
8
9 * alloc.c (allocate_vector_block): Remove redundant
10 calls to mallopt if DOUG_LEA_MALLOC is defined.
11 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
12 avoid calls to mallopt if zero_vector is returned.
13
296094c3
DA
142012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
15
16 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
17 is enabled, avoid dereferencing NULL current_sblock if
18 running undumped.
19
36429c89
DA
202012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
21
22 Cleanup basic buffer management.
23 * buffer.h (struct buffer): Change layout to use generic vector
24 marking code. Fix some comments. Change type of 'clip_changed'
25 to bitfield. Remove unused #ifndef old.
26 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
27 (GET_OVERLAYS_AT): Fix indentation.
28 (for_each_per_buffer_object_at): New macro.
29 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
30 (Fbuffer_local_variables): Use it.
31 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
32 * alloc.c (allocate_buffer): Adjust to match new layout of
33 struct buffer. Fix comment.
34 (mark_overlay): New function.
35 (mark_buffer): Use it. Use mark_vectorlike to mark normal
36 Lisp area of struct buffer.
37 (mark_object): Use it. Adjust marking of misc objects
38 and related comments.
39
3b3e4cac
PE
402012-07-02 Paul Eggert <eggert@cs.ucla.edu>
41
42 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
43 wrapper that is not needed because the wrapped code is a no-op (zero
44 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
45 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
46
cf5c0175
DA
472012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
48
49 * alloc.c (mark_buffer): Simplify. Remove prototype.
50 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 51 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
52 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
53 redundant calls to mark_vectorlike for bool vectors.
54
ca26824c
GM
552012-06-30 Glenn Morris <rgm@gnu.org>
56
2e4c5312
GM
57 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
58
ca26824c
GM
59 * epaths.in (PATH_SITELOADSEARCH): New.
60 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
61 This is rather than relying on --enable-locallisppath elements
62 having "site-lisp" in their names. (Bug#10208#25, 11658)
63
0d23c240
EZ
642012-06-30 Eli Zaretskii <eliz@gnu.org>
65
c9240d7a
EZ
66 * w32proc.c (sys_select): Accept and ignore one more argument.
67
68 * w32.c (emacs_gnutls_pull): Call select with one more argument.
69
0d23c240 70 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 71 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
72
73 * sysdep.c: Don't include dos.h and dosfns.h.
74
75 * process.c (sys_select):
76 * msdos.c (sys_select): Accept one more argument and ignore it.
77
78 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
79 adapt data types and code to that.
80
81 * dosfns.c:
82 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
83 which clashes with the gnulib function of the same name.
84
af5a5a98
AS
852012-06-30 Andreas Schwab <schwab@linux-m68k.org>
86
c5e4379c
AS
87 * font.c (font_style_to_value, font_style_symbolic)
88 (font_prop_validate_style): Add type checks for values in
89 font_style_table.
90
af5a5a98
AS
91 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
92 argument.
93 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
94 uses.
95
8d38f461
EZ
962012-06-29 Eli Zaretskii <eliz@gnu.org>
97
2e5a6631
EZ
98 * xdisp.c (try_window_id): Undo last change.
99
8d38f461
EZ
100 * w32.c (getwd): Adjust commentary about startup_dir.
101 (init_environment): Always call sys_access, even in non-MSVC
102 builds. Don't chdir to the directory of the Emacs executable.
103 This undoes code from 1997 which was justified by the need to
104 "avoid conflicts when removing and renaming directories". But its
105 downside was that every relative file name was being interpreted
106 relative to the directory of the Emacs executable, which can never
107 be TRT. In particular, it broke sys_access when called with
108 relative file names.
109 (sys_access): Map GetLastError to errno.
110
2af3565e
DA
1112012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
112
113 * window.h (struct window): Change type of 'fringes_outside_margins'
114 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 115 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
116 Adjust comment.
117 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
118 to ptrdiff_t.
119
c8d3a25c 1202012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 121
c8d3a25c
GM
122 * gnutls.c (emacs_gnutls_handshake):
123 Add QUIT to make the loop interruptible.
57570cd3 124
c8d3a25c 1252012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 126
c8d3a25c
GM
127 * charset.c (init_charset): Make lack of etc/charsets fatal.
128
3e984ee8
DA
1292012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
130
131 * editfns.c (region_limit): Fix type mismatch.
132
ef884f23
DA
1332012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
134
135 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
136 undefined. Convert from xassert to eassert.
137 * nsmenu.m: Convert from xassert to eassert.
138 * nsterm.m: Likewise.
139
7d7e0027
SM
1402012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
141
142 * editfns.c (region_limit): Clip to narrowing (bug#11770).
143
aa754e6a
PE
1442012-06-28 Paul Eggert <eggert@cs.ucla.edu>
145
146 Avoid integer overflow on scroll-left and scroll-right.
147 * window.c (HSCROLL_MAX): New macro.
148 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
149 overflow when requested scroll falls outside ptrdiff_t range.
150
80b00b08
DA
1512012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
152
153 * window.h (struct window): Change type of 'hscroll',
154 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
155 'last_modified' and 'last_overlay_modified' to EMACS_INT.
156 Adjust users accordingly.
157 * xdisp.c (try_cursor_movement): Replace type check with eassert.
158 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
159 from EMACS_INT to ptrdiff_t.
160 (make_window): Omit redundant initialization.
161
62b2bcf6
JB
1622012-06-28 Juanma Barranquero <lekktu@gmail.com>
163
164 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
165
45942c7d
DA
1662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
167
168 * window.h (struct window): Change type of 'use_time' and
169 'sequence_number' from Lisp_Object to int.
170 * frame.c (make_frame): Adjust users accordingly.
171 * print.c (print_object): Likewise.
172 * window.c (select_window, Fwindow_use_time, make_parent_window)
173 (make_window): Likewise.
174
e509cfa6
DA
1752012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
176
177 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
178 enabled with --enable-checking=[all,glyphs] configure option.
179 Fix GLYPH_DEBUG usage assuming that it may be undefined,
180 adjust comments accordingly.
181 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
182 undefined, adjust comments accordingly.
183 * image.c: Likewise.
184 * scroll.c: Likewise.
185 * w32fns.c: Likewise.
186 * w32term.c: Likewise.
187 * xdisp.c: Likewise.
188 * xfaces.c: Likewise.
189 * xfns.c: Likewise.
190 * xterm.c: Likewise.
191
a54e2c05
DA
1922012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
193
194 Generalize run-time debugging checks.
195 * dispextern.h (XASSERTS): Remove.
196 * fontset.c (xassert): Remove.
197 Convert from xassert to eassert.
198 * alloc.c: Convert from xassert to eassert.
199 * bidi.c: Likewise.
200 * dispnew.c: Likewise.
201 * fns.c: Likewise.
202 * fringe.c: Likewise.
203 * ftfont.c: Likewise.
204 * gtkutil.c: Likewise.
205 * image.c: Likewise.
206 * keyboard.c: Likewise.
207 * menu.c: Likewise.
208 * process.c: Likewise.
209 * scroll.c: Likewise.
210 * sound.c: Likewise.
211 * term.c: Likewise.
212 * w32console.c: Likewise.
213 * w32fns.c: Likewise.
214 * w32term.c: Likewise.
215 * window.c: Likewise.
216 * xdisp.c: Likewise.
217 * xfaces.c: Likewise.
218 * xfns.c: Likewise.
219 * xselect.c: Likewise.
220 * xterm.c: Likewise.
221
1ec4b7b2
SM
2222012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
223
224 * fns.c (maybe_resize_hash_table): Output message when growing the
225 purify-hashtable.
226
2014308a
DA
2272012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * alloc.c (allocate_string_data): Remove dead code.
230 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
231 avoid GCC warning about unused macro.
232
246155eb
DA
2332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
234
235 * alloc.c (allocate_string): Omit intervals initialization.
236 * alloc.c (make_uninit_multibyte_string): Initialize intervals
237 as in make_pure_string and make_pure_c_string.
238
43184b7b
DA
2392012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
240
241 * alloc.c (allocate_string): Fix last change.
242
3fe6dd74
DA
2432012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
244
245 * alloc.c (allocate_string): Remove two redundant calls
246 to memset, add explicit initialization where appropriate.
247
1ba6038a
GM
2482012-06-27 Glenn Morris <rgm@gnu.org>
249
250 * lisp.mk (lisp): Remove paths.elc.
251
c89926a5
CY
2522012-06-27 Chong Yidong <cyd@gnu.org>
253
254 * doc.c (Fsubstitute_command_keys): Fix punctuation.
255
ed6b3510
JW
2562012-06-26 John Wiegley <johnw@newartisans.com>
257
1ec4b7b2 258 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
259 on Mac OS X Lion: __mod_init_func and __mod_term_func.
260
ed6b3510
JW
261 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
262 when building with Clang.
263
8edd4a2b
SM
2642012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
265
266 * eval.c (Fapply): Allow calling it with a single argument.
267
f6f62d1b
EZ
2682012-06-26 Eli Zaretskii <eliz@gnu.org>
269
270 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
271 _stricmp and _strnicmp.
272 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
273
62efea5e
DA
2742012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
275
276 * alloc.c (allocate_window): Zero out non-Lisp part of newly
277 allocated window.
278 (allocate_process): Likewise for new process.
8edd4a2b 279 (allocate_terminal): Change to use offsetof.
62efea5e
DA
280 (allocate_frame): Likewise.
281 * frame.c (make_frame): Omit redundant initialization.
282 * window.c (make_parent_window): Use memset.
283 (make_window): Omit redundant initialization.
284 * process.c (make_process): Omit redundant initialization.
285 * terminal.c (create_terminal): Likewise.
286
42997f4d
DA
2872012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
288
289 * term.c (delete_tty): Remove redundant call to memset.
290
1130ecfc
DA
2912012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
292
293 * alloc.c: Remove build_string.
294 * lisp.h: Define build_string as static inline. This provides
295 a better opportunity to optimize away calls to strlen when the
296 function is called with compile-time constant argument.
297 * image.c (imagemagick_error): Convert to build_string.
298 * w32proc.c (sys_spawnve): Likewise.
299 * xterm.c (x_term_init): Likewise.
300
cf38a720
PE
3012012-06-26 Paul Eggert <eggert@cs.ucla.edu>
302
99027bdd
PE
303 Use sprintf return value instead of invoking strlen on result.
304 In the old days this wasn't portable, since some sprintf
305 implementations returned char *. But they died out years ago and
306 Emacs already assumes sprintf returns int.
307 Similarly for float_to_string.
308 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
309 * ccl.c (ccl_driver):
310 * character.c (string_escape_byte8):
311 * data.c (Fnumber_to_string):
312 * doprnt.c (doprnt):
313 * print.c (print_object):
314 * xdisp.c (message_dolog):
315 * xfns.c (syms_of_xfns):
316 Use sprintf or float_to_string result to avoid need to call strlen.
317 * data.c (Fnumber_to_string):
318 Use make_unibyte_string, since the string must be ASCII.
319 * lisp.h, print.c (float_to_string): Now returns int length.
320 * term.c (produce_glyphless_glyph):
321 Use sprintf result rather than recomputing it.
322
cf38a720
PE
323 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
324 * Makefile.in (ALL_CFLAGS):
325 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
326 * gmalloc.c, regex.c: Include <config.h> unconditionally.
327
3511c784
DA
3282012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
329
0a08eb21 330 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
331 strcasecmp if available.
332 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
333
fb7da12e
AS
3342012-06-25 Andreas Schwab <schwab@linux-m68k.org>
335
336 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
337 Avoid comma operator.
338 * menu.c (push_submenu_start, push_submenu_end)
339 (push_left_right_boundary, push_menu_pane): Likewise.
340 * msdos.c (dos_rawgetc): Likewise.
341
afa2ffd8
DA
3422012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
343
344 * xfns.c (xic_create_fontsetname): Remove redundant calls
345 to memset.
346
b3b4476b
PE
3472012-06-25 Paul Eggert <eggert@cs.ucla.edu>
348
4495ff38
PE
349 * gtkutil.c (get_utf8_string): Remove redundant assignment.
350 sprintf already null-terminates its output.
351
b3b4476b
PE
352 * xfns.c (x_window): Remove redundant cast.
353
b00876c9
DA
3542012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
355
356 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
357 `const char *' to `char *' to avoid compiler warning.
358
d188e26b
PE
3592012-06-24 Paul Eggert <eggert@cs.ucla.edu>
360
885d1d74
PE
361 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
362 instead of truncating it to 63 (admittedly a generous limit).
363
d188e26b
PE
364 * process.c: Fix spelling and caps in comments.
365
e2f560b1
DN
3662012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
367
e86db54b 368 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
369 * sysdep.c (setpgrp): Remove definition, not used in this file.
370
7583a3a1
JB
3712012-06-24 Juanma Barranquero <lekktu@gmail.com>
372
373 * makefile.w32-in: Update dependencies.
374
696056c2
EZ
3752012-06-24 Eli Zaretskii <eliz@gnu.org>
376
377 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
378 (SYSTIME_H): Add nt/inc/sys/time.h.
379
380 * systime.h [WINDOWSNT]: Include sys/time.h.
381
382 * s/ms-w32.h (struct timespec): Definition moved from
383 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
384
845ca893
PE
3852012-06-24 Paul Eggert <eggert@cs.ucla.edu>
386
387 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
388 * buffer.h (buffer_slot_type_mismatch):
389 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
390 * eval.c (unwind_to_catch):
391 * image.c (my_png_error, my_error_exit):
392 * keyboard.c (quit_throw_to_read_char, user_error)
393 (Fexit_recursive_edit, Fabort_recursive_edit):
394 * lisp.h (die, args_out_of_range, args_out_of_range_3)
395 (wrong_type_argument, buffer_overflow, __executable_start)
396 (memory_full, buffer_memory_full, string_overflow, Fthrow)
397 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
398 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
399 (fatal):
400 (child_setup) [!DOS_NT]:
401 * lread.c (end_of_file_error, invalid_syntax):
402 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
403 * puresize.h (pure_write_error):
404 * search.c (matcher_overflow):
405 * sound.c (sound_perror, alsa_sound_perror):
406 * sysdep.c, syssignal.h (croak):
407 * term.c (maybe_fatal, vfatal):
408 * textprop.c (text_read_only):
409 * undo.c (user_error):
410 * unexmacosx.c (unexec_error):
411 * xterm.c (x_ins_del_lines, x_delete_glyphs):
412 Use _Noreturn rather than NO_RETURN.
413 No need for separate decl merely because of _Noreturn.
414 * sound.c (sound_warning, parse_sound):
415 Remove unnecessary forward decls.
416
f1dd8073
PE
4172012-06-24 Paul Eggert <eggert@cs.ucla.edu>
418
419 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
420 * lisp.h (WAIT_READING_MAX): New macro.
421 * dispnew.c (Fsleep_for, sit_for):
422 * keyboard.c (kbd_buffer_get_event):
423 * process.c (Faccept_process_output):
424 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
425 This improves on the previous patch, which introduced a bug
426 when time_t is unsigned and as wide as intmax_t.
427 See <http://bugs.gnu.org/9000#51>.
428
b82c1755
EZ
4292012-06-23 Eli Zaretskii <eliz@gnu.org>
430
431 * dispnew.c (sit_for, Fsleep_for):
432 * keyboard.c (kbd_buffer_get_event):
433 * process.c (Faccept_process_output): Avoid compiler warnings when
434 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
435
ca300656
JB
4362012-06-23 Juanma Barranquero <lekktu@gmail.com>
437
049ec95b
JB
438 * makefile.w32-in: Update dependencies.
439
ca300656
JB
440 * w32.c (ltime): Add return type and declare static.
441 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
442
db7b8d06
PE
4432012-06-23 Paul Eggert <eggert@cs.ucla.edu>
444
445 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
446 Privately reported by Herbert J. Skuhra.
447 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
448 All uses changed.
449 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
450 not make_lisp_timeval, when the argument is of type EMACS_TIME.
451
0bd8297f
EZ
4522012-06-23 Eli Zaretskii <eliz@gnu.org>
453
96512555
EZ
454 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
455 last argument of make_unibyte_string.
456
0bd8297f
EZ
457 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
458 language ID in the event parameters.
459
460 * w32term.c (w32_read_socket): Put the new keyboard codepage into
461 event.code, not the obscure "character set ID".
462
63def6b6
CY
4632012-06-23 Chong Yidong <cyd@gnu.org>
464
465 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
466
e8a02204
EZ
4672012-06-23 Eli Zaretskii <eliz@gnu.org>
468
388cdec0
EZ
469 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
470 * w32.c (fdutimens): New function.
471
472 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
473
474 * s/ms-w32.h (pselect): Redirect to sys_select.
475
476 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
477
e8a02204
EZ
478 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
479 in the logic of incrementing and decrementing the value of
480 use_relocatable_buffers.
481
d054f3fb
PE
4822012-06-23 Paul Eggert <eggert@cs.ucla.edu>
483
484 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
485 Privately reported by Herbert J. Skuhra.
486 [__FreeBSD__]: Remove "*/" typo after "#include".
487 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
488 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
489 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
490 Don't assume EMACS_TIME and struct timeval are the same type.
491
d35af63c
PE
4922012-06-22 Paul Eggert <eggert@cs.ucla.edu>
493
494 Support higher-resolution time stamps (Bug#9000).
495 The time stamps are only nanosecond-resolution at the C level,
496 since that's the best that any real-world system supports now.
497 But they are picosecond-resolution at the Lisp level, as that's
498 easy, and leaves room for future OS improvements.
499
500 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
501 (LIBES): Use it.
502
503 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
504 Don't get current time unless it's needed.
505
506 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
507 now provides it if it's absent.
508 (start_atimer): Port to higher-res time stamps.
509 Check for time stamp overflow. Don't get current time more
510 often than is needed.
511
512 * buffer.h (struct buffer): Buffer modtime now has high resolution.
513 Include systime.h, not time.h.
514 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
515
516 * dired.c: Include stat-time.h.
517 (Ffile-attributes): File times now have higher resolution.
518
519 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
520 (struct image): Timestamp now has higher resolution.
521
522 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
523 has at least microseconds now. All uses removed.
524 (update_frame, update_single_window, update_window, update_frame_1)
525 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
526
527 * editfns.c (time_overflow): Now extern.
528 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
529 (float-time, Fformat_time_string, Fcurrent_time_string)
530 (Fcurrent_time_zone): Accept and generate higher-resolution
531 time stamps.
532 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
533 (decode_time_components, lisp_seconds_argument): New functions.
534 (make_time): Now static.
535 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
536 Report an error if the time is invalid, rather than having the caller
537 do that.
538
539 * fileio.c: Include <stat-time.h>
540 (Fcopy_file): Copy higher-resolution time stamps.
541 Prefer to set the time stamp via a file descriptor if that works.
542 (Fset_file_times, Finsert_file_contents, Fwrite_region)
543 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
544 (Fvisited_file_modtime, Fset_visited_file_modtime):
545 Support higher-resolution time stamps.
546
547 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
548
549 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
550
551 * image.c (prepare_image_for_display, clear_image_cache)
552 (lookup_image): Port to higer-resolution time stamps.
553
554 * keyboard.c (start_polling, bind_polling_period):
555 Check for time stamp overflow.
556 (read_char, kbd_buffer_get_event, timer_start_idle)
557 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
558 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
559 Port to higher-resolution time stamps. Do not assume time_t is signed.
560 (decode_timer): New function. Timers are now vectors of length 9,
561 not 8, to accommodate the picosecond component.
562 (timer_check_2): Use it.
563
564 * nsterm.m (select_timeout, timeval_subtract): Remove.
565 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
566 as they're a bit more accurate and handle overflow better.
567 (ns_select): Change prototype to be compatible with pselect.
568 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
569 * nsterm.h (ns_select): Adjust prototype.
570
571 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
572 us-resolution time stamps.
573 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
574
575 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
576
577 * lisp.h (time_overflow): New decl.
578 (wait_reading_process_output): First arg is now intmax_t, not int,
579 to accommodate larger waits.
580
581 * process.h (struct Lisp_Process.read_output_delay):
582 Now counts nanoseconds, not microseconds.
583 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
584 EMACS_HAS_USECS.
585 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
586 (wait_reading_process_output):
587 Port to ns-resolution time stamps.
588 (Faccept_process_output, wait_reading_process_output):
589 Check for time stamp overflow. Do not assume time_t is signed.
590 (select_wrapper): Remove; we now use pselect.
591 (Fprocess_attributes): Now generates ns-resolution time stamps.
592
593 * sysdep.c: Include utimens.h. Don't include utime.h
594 or worry about struct utimbuf; gnulib does that for us now.
595 (gettimeofday): Remove; gnulib provides a substitute.
596 (make_timeval): New function.
597 (set_file_times): Now sets ns-resolution time stamps.
598 New arg FD; all uses changed.
599 (time_from_jiffies, ltime_from_jiffies, get_up_time)
600 (system_process_attributes):
601 Now returns ns-resolution time stamp. All uses changed.
602 Check for time stamp overflow.
603
604 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
605 provides a substitute now.
606
607 * systime.h: Include timespec.h rather than sys/time.h and time.h,
608 since it guarantees struct timespec.
609 (EMACS_TIME): Now struct timespec, so that we can support
610 ns-resolution time stamps.
611 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
612 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
613 (EMACS_USECS): Remove.
614 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
615 so multiply the arg by 1000 before storing it.
616 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
617 New macros.
618 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
619 Port to ns-resolution time stamps.
620 (EMACS_TIME_NEG_P): Remove; replaced by....
621 (EMACS_TIME_SIGN): New macro.
622 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
623 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
624 (set_file_times, make_time, lisp_time_argument): Adjust signature.
625 (make_timeval, make_lisp_time, decode_time_components): New decls.
626 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
627 that it mishandled time_t overflow. You can't compare by subtracting!
628 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
629 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
630
631 * term.c: Include <sys/time.h>.
632 (timeval_to_Time): New function, for proper overflow wraparound.
633 (term_mouse_position, term_mouse_click): Use it.
634
635 * undo.c (record_first_change): Support higher-resolution time stamps
636 in the undo buffer.
637 (Fprimitive_undo): Use them when restoring time stamps.
638
639 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
640 (w32_get_internal_run_time):
641 Port to higher-resolution Emacs time stamps.
642 (ltime): Now accepts single 64-bit integer, as that's more convenient
643 for callers.
644
645 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
646
647 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
648 for compatibility with pselect. Support ns-resolution time stamps.
649
650 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
651
652 * xselect.c (wait_for_property_change, x_get_foreign_selection):
653 Check for time stamp overflow, and support ns-resolution time stamps.
654
655 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
656 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
657 (timeval_subtract): Remove; no longer needed.
658 (XTflash, XTring_bell, x_wait_for_event):
659 Port to ns-resolution time stamps. Don't assume time_t is signed.
660
b6a92dfe
CY
6612012-06-22 Chong Yidong <cyd@gnu.org>
662
663 * xdisp.c (x_consider_frame_title): Revert last change.
664
d251c37c
EZ
6652012-06-22 Eli Zaretskii <eliz@gnu.org>
666
667 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
668 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
669 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
670 staticidx goes up to 1597 out of 1600 = 0x640.)
671
f10deafb
PE
6722012-06-20 Paul Eggert <eggert@cs.ucla.edu>
673
674 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
675 Otherwise, the umask might be mistakenly 0 while handling input signals.
676
ec6de1e2
SM
6772012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
678
679 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
680
28be1ada
DA
6812012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
682
683 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
684 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
685 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
686 access to `contents' member of Lisp_Vector objects with AREF and ASET
687 where appropriate.
688
c6bf3022
CY
6892012-06-19 Chong Yidong <cyd@gnu.org>
690
691 * frame.c (delete_frame): When selecting a frame on a different
692 text terminal, do not alter the terminal's top-frame.
693
694 * xdisp.c (format_mode_line_unwind_data): Record the target
695 frame's selected window and its terminal's top-frame.
696 (unwind_format_mode_line): Restore them.
697 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
698 Callers changed.
699 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
700 since tty frames can be explicitly named.
701 (prepare_menu_bars): Likewise.
702
703 * term.c (Ftty_top_frame): New function.
704
defd4196
PE
7052012-06-18 Paul Eggert <eggert@cs.ucla.edu>
706
707 Port byte-code-meter to modern targets.
708 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
709 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 710 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
711 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
712 (METER_1, METER_2): Simplify.
713
1053a871
SM
7142012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
715
716 * data.c (Fdefalias): Return `symbol' (bug#11686).
717
b7e8d081
MR
7182012-06-18 Martin Rudalics <rudalics@gmx.at>
719
720 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
721 gets killed during executing of this function (Bug#11665).
722 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
723 (Vkill_buffer_query_functions): In doc-string say that functions
724 run by this hook should not change the current buffer.
725
7ea2b339
PE
7262012-06-18 Paul Eggert <eggert@cs.ucla.edu>
727
728 Fix recently-introduced process.c problems found by static checking.
729 * process.c (write_queue_push, write_queue_pop, send_process):
730 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
731 (write_queue_pop): Fix pointer signedness problem.
732 (send_process): Remove unused local.
733
96a313a1
CY
7342012-06-17 Chong Yidong <cyd@gnu.org>
735
736 * xdisp.c (redisplay_internal): No need to redisplay terminal
737 frames that are not on top.
738
20ca2e94
TN
7392012-06-17 Troels Nielsen <bn.troels@gmail.com>
740
741 * process.c (make_process): Initialize write_queue.
742 (write_queue_push, write_queue_pop): New functions.
743 (send_process): Use them to maintain correct ordering of process
744 writes (Bug#10815).
745
9a900ca9
PE
7462012-06-17 Paul Eggert <eggert@cs.ucla.edu>
747
310fbfa8
PE
748 * lisp.h (eassert): Assume C89 or later.
749 This removes the need for CHECK.
750 (CHECK): Remove. Its comments about always evaluating its
751 argument were confusing, as 'eassert' typically does not evaluate
752 its argument.
753
27bb1ca4
PE
754 * coding.c (produce_chars): Use ptrdiff_t, not int.
755
9a900ca9
PE
756 * xterm.c (x_draw_underwave): Check for integer overflow.
757 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
758
41b7f8bc 7592012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
760
761 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
762 referenced (Bug#11583).
763
9b0e3eba
AA
7642012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
765
766 Implement wave-style variant of underlining.
767 * dispextern.h (face_underline_type): New enum.
768 (face): Add field for underline type.
769 * nsterm.m (ns_draw_underwave): New function.
770 (ns_draw_text_decoration): Use it.
771 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
772 New functions.
773 (x_draw_glyph_string): Use them.
774 * xfaces.c (Qline, Qwave): New Lisp objects.
775 (check_lface_attrs, merge_face_ref)
1053a871
SM
776 (Finternal_set_lisp_face_attribute, realize_x_face):
777 Handle wave-style underline face attributes.
9b0e3eba
AA
778 * xterm.c (x_draw_underwave): New function.
779 (x_draw_glyph_string): Use it.
780
0fb52f11
JB
7812012-06-16 Juanma Barranquero <lekktu@gmail.com>
782
783 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
784 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
785 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
786 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
787 ($(BLD)/w32select.$(O)): Update dependencies.
788
e5560ff7
AS
7892012-06-16 Andreas Schwab <schwab@linux-m68k.org>
790
791 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
792 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
793 * character.c (_fetch_multibyte_char_p): Remove.
794 * alloc.c: Include "character.h" before "buffer.h".
795 * bidi.c: Likewise.
796 * buffer.c: Likewise.
797 * bytecode.c: Likewise.
798 * callint.c: Likewise.
799 * callproc.c: Likewise.
800 * casefiddle.c: Likewise.
801 * casetab.c: Likewise.
802 * category.c: Likewise.
803 * cmds.c: Likewise.
804 * coding.c: Likewise.
805 * composite.c: Likewise.
806 * dired.c: Likewise.
807 * dispnew.c: Likewise.
808 * doc.c: Likewise.
809 * dosfns.c: Likewise.
810 * editfns.c: Likewise.
811 * emacs.c: Likewise.
812 * fileio.c: Likewise.
813 * filelock.c: Likewise.
814 * font.c: Likewise.
815 * fontset.c: Likewise.
816 * fringe.c: Likewise.
817 * indent.c: Likewise.
818 * insdel.c: Likewise.
819 * intervals.c: Likewise.
820 * keyboard.c: Likewise.
821 * keymap.c: Likewise.
822 * lread.c: Likewise.
823 * macros.c: Likewise.
824 * marker.c: Likewise.
825 * minibuf.c: Likewise.
826 * nsfns.m: Likewise.
827 * nsmenu.m: Likewise.
828 * print.c: Likewise.
829 * process.c: Likewise.
830 * regex.c: Likewise.
831 * region-cache.c: Likewise.
832 * search.c: Likewise.
833 * syntax.c: Likewise.
834 * term.c: Likewise.
835 * textprop.c: Likewise.
836 * undo.c: Likewise.
837 * unexsol.c: Likewise.
838 * w16select.c: Likewise.
839 * w32fns.c: Likewise.
840 * w32menu.c: Likewise.
841 * window.c: Likewise.
842 * xdisp.c: Likewise.
843 * xfns.c: Likewise.
844 * xmenu.c: Likewise.
845 * xml.c: Likewise.
846 * xselect.c: Likewise.
847
2f07e6af
EZ
8482012-06-16 Eli Zaretskii <eliz@gnu.org>
849
1053a871
SM
850 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
851 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 852 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
853 row.
854 (handle_face_prop): Use chunk-relative overlay string index when
855 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
856 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
857 the rightmost. (Bug#11720)
2f07e6af 858
29b83cec
AS
8592012-06-16 Andreas Schwab <schwab@linux-m68k.org>
860
861 * category.h (CHAR_HAS_CATEGORY): Define as inline.
862 (CATEGORY_MEMBER): Enforce 1/0 value.
863 * category.c (_temp_category_set): Remove.
864
4c5501e9
EZ
8652012-06-16 Eli Zaretskii <eliz@gnu.org>
866
867 * window.c (Fdelete_other_windows_internal)
868 (Fdelete_window_internal): Don't access frame's mouse highlight
869 info of the initial frame. (Bug#11677)
870
2b570124
PE
8712012-06-14 Paul Eggert <eggert@cs.ucla.edu>
872
e93864f9
PE
873 * .gdbinit (xgetint): Fix recently-introduced paren typo.
874 Assume USE_2_TAGS_FOR_INTS.
875 (xreload): Adjust $tagmask width to match recent lisp.h change.
876
2b570124
PE
877 Simplify lisp.h in minor ways that should not affect code.
878 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
879 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
880 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
881 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
882 (INTTYPEBITS): New macro, for clarity.
883 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
884 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
885 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
886 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
887 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
888
81755f69
JB
8892012-06-13 Juanma Barranquero <lekktu@gmail.com>
890
891 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
892
16192a57
GM
8932012-06-13 Glenn Morris <rgm@gnu.org>
894
895 * s/bsd-common.h (BSD4_3):
896 * s/usg5-4-common.h (USG5_4): No longer define; unused.
897
646b5f55
AS
8982012-06-13 Andreas Schwab <schwab@linux-m68k.org>
899
900 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
901 instead of union.
902 (XLI, XIL): Define.
1053a871
SM
903 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
904 Use them.
905 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 906 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 907 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
908 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
909 * frame.c (delete_frame): Remove outdated comment.
910 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
911 USE_LISP_UNION_TYPE.
912 (Fw32_unregister_hot_key): Likewise.
913 (Fw32_toggle_lock_key): Likewise.
914 * w32menu.c (add_menu_item): Likewise.
915 (w32_menu_display_help): Use XIL instead of checking
916 USE_LISP_UNION_TYPE.
917 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
918 (init_heap): Likewise.
919 * w32term.c (w32_read_socket): Update comment.
920
1d3823c9
GM
9212012-06-13 Glenn Morris <rgm@gnu.org>
922
c62ff706
GM
923 * s/usg5-4-common.h, src/s/unixware.h:
924 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
925
1d3823c9
GM
926 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
927
bfe3e0a2
PE
9282012-06-13 Paul Eggert <eggert@cs.ucla.edu>
929
930 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
931 * alloc.c (make_number) [!defined make_number]:
932 Remove, as lisp.h always defines this now.
933 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
934 (roundup_size): Verify that it is a power of 2.
935 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
936 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
937 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
938 -DUSE_LSB_TAG=0, to override the automatically-selected default.
939 USE_LSB_TAG now is always defined to be either 0 or 1.
940 All uses changed.
941 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
942 code works fine either way, and efficiency is not a concern here,
943 as the union type is for debugging, not for production.
944 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
945 Use an inline function on all platforms when using the union type,
946 since this is simpler and 'static inline' can be used portably
947 within Emacs now.
948 (LISP_INITIALLY_ZERO): New macro.
949 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
950 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
951
45fa9c0f
GM
9522012-06-12 Glenn Morris <rgm@gnu.org>
953
b4492cba
GM
954 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
955
956 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 957
45fa9c0f
GM
958 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
959 Move BROKEN_SIGIO to configure.
960
961 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
962 Move NO_TERMIO to configure.
963
0e25d334
CY
9642012-06-12 Chong Yidong <cyd@gnu.org>
965
966 * image.c (imagemagick_load_image): Use MagickFlattenImage if
967 MagickMergeImageLayers is undefined. Use pixel pusher loop if
968 MagickExportImagePixels is undefined.
969
43682bb6
PE
9702012-06-12 Paul Eggert <eggert@cs.ucla.edu>
971
972 * image.c (imagemagick_load_image): Remove unused label.
973
a9be7d2b
GM
9742012-06-11 Glenn Morris <rgm@gnu.org>
975
976 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
977 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
978 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
979 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
980
3017f87f
SM
9812012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
982
983 * alloc.c (make_byte_code): New function.
984 (Fmake_byte_code): Use it. Don't purify here.
985 * lread.c (read1): Use it as well to avoid extra allocation.
986
1b9b4cf4
CY
9872012-06-11 Chong Yidong <cyd@gnu.org>
988
989 * image.c (imagemagick_load_image): Implement transparency.
990
95988fcf
AS
9912012-06-10 Andreas Schwab <schwab@linux-m68k.org>
992
993 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
994 account for preceding backslashes. (Bug#11663)
995
cd4eb164
CY
9962012-06-09 Chong Yidong <cyd@gnu.org>
997
998 * term.c: Support italics in capable terminals (Bug#9652).
999 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1000 (turn_on_face): Output using TS_enter_italic_mode if available.
1001 Don't handle unused blinking and alt-charset cases.
1002 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1003 and tty_alt_charset_p cases.
1004 (tty_capable_p, init_tty): Support italics.
1005
1006 * termchar.h (struct tty_display_info): Add field for italics.
1007 Remove unused blink field.
1008
1009 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1010 Handle slant.
1011
1012 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1013 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1014 tty_alt_charset_p. Add tty_italic_p.
1015
ff88beb8
MA
10162012-06-09 Michael Albinus <michael.albinus@gmx.de>
1017
1018 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1019 dbus_type_is_basic if available.
1020 (xd_extract_signed, xd_extract_unsigned): Rename from
1021 extract_signed and extract_unsigned, respectively. Adapt callers.
1022
44286096
CY
10232012-06-09 Chong Yidong <cyd@gnu.org>
1024
1682701f
CY
1025 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1026
44286096
CY
1027 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1028 case (Bug#9752).
1029
d86feb17
PE
10302012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 * xdisp.c (vmessage): Treat frame message as multibyte.
1033 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1034 would generate the diagnostic "Making \302\247 buffer-local while
1035 let-bound!".
1036
d5c20fe8
EZ
10372012-06-08 Eli Zaretskii <eliz@gnu.org>
1038
1039 * dispnew.c (showing_window_margins_p): Undo last change, which
1040 was done due to an inadvertent commit.
1041 (adjust_frame_glyphs_for_frame_redisplay): Do call
1042 showing_window_margins_p.
1043
513749ee
SM
10442012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1045
1046 * eval.c (Fmake_var_non_special): New primitive.
1047 (syms_of_eval): Defsubr it.
1048 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1049
d4a8f5c1
JB
10502012-06-08 Juanma Barranquero <lekktu@gmail.com>
1051
1052 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1053 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1054
8bbbc977
EZ
10552012-06-08 Eli Zaretskii <eliz@gnu.org>
1056
1057 * alloc.c (allocate_vectorlike): Fix last change.
1058
f3372c87
DA
10592012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1060
1061 Block-based vector allocation of small vectors.
1062 * lisp.h (struct vectorlike_header): New field `nbytes',
1063 adjust comment accordingly.
1064 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1065 to denote vector blocks. Adjust users (live_vector_p,
1066 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1067 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1068 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1069 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1070 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1071 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1072 (roundup_size): New constant.
1073 (struct vector_block): New data type.
1074 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1075 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1076 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1077 (sweep_vectors): New functions.
1078 (allocate_vectorlike): Return `zero_vector' as the only vector of
1079 0 items. Allocate new vector from block if vector size is less than
1080 or equal to VBLOCK_BYTES_MAX.
1081 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1082 (init_alloc_once): Add call to init_vectors.
1083
4f18a4ed
SM
10842012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1085
1086 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1087
86f158bc
PE
10882012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 * doprnt.c (doprnt): Truncate multibyte char correctly.
1091 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1092 would mishandle a string argument "Xc" if X was a multibyte
1093 character of length 2: it would truncate after X's first byte
1094 rather than including all of X.
1095
c5cfcbe0
CY
10962012-06-06 Chong Yidong <cyd@gnu.org>
1097
1098 * buffer.c (word_wrap): Doc fix.
1099
c05cf390
PE
11002012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1103
0c3461de
GM
11042012-06-03 Glenn Morris <rgm@gnu.org>
1105
1106 * xdisp.c (tool-bar-style): Doc fix.
1107
c71232db
UM
11082012-06-03 Ulrich Müller <ulm@gentoo.org>
1109
1110 * Makefile.in (PAXCTL): Define.
1111 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1112 binary via PaX flags if the paxctl utility is available.
1113 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1114 Restore PaX flags to their default. (Bug#11398)
1115
383f7350
CY
11162012-06-03 Chong Yidong <cyd@gnu.org>
1117
1118 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1119 buffer (Bug#11226).
1120
5f2c76c6
CY
11212012-06-03 Chong Yidong <cyd@gnu.org>
1122
1123 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1124 (note_mode_line_or_margin_highlight): If there is no help echo,
1125 use mode-line-default-help-echo. Handle the case where the mouse
1126 position is past the end of the mode line string.
1127
1128 * buffer.c (buffer_local_value_1): New function, split from
1129 Fbuffer_local_value; can return Qunbound.
1130 (Fbuffer_local_value): Use it.
1131 (Vmode_line_format): Docstring tweaks.
1132
773d47f6
PE
11332012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1134
1135 * sysdep.c (system_process_attributes): Improve comment.
1136
f2d6a3df
SM
11372012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1138
1139 * keyboard.c: Export real-this-command to Elisp.
1140 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1141 and DEFVAR it. Update all users.
1142
63810350
PE
11432012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1144
7bd5c1f4
PE
1145 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1146
63810350
PE
1147 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1148 Convert pctcpu and pctmem to Lisp float properly.
1149 Let the compiler fold better, as 100.0/0x8000 is exact.
1150
a2821611
AS
11512012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1152
1153 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1154 cons_block.
1155
5fceba1d
PE
11562012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1159
c98ff5dd
DA
11602012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1161
1162 For a 'struct window', replace some Lisp_Object fields to
1163 bitfields where appropriate, remove unused fields.
1164 * window.h (struct window): Remove unused 'last_mark_x' and
1165 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1166 change it's type from Lisp_Object to bitfield.
1167 Change type of 'force_start', 'optional_new_start',
1168 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1169 fields from Lisp_Object to bitfield. Adjust users accordingly.
1170
ca34e0be
PE
11712012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 Pacify gcc -Wdouble-precision when using Xaw.
1174 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1175 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1176 Use 'float' consistently, rather than 'float' in most places
1177 and 'double' in a couple of places.
1178
efc00ab1 11792012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1180
1181 * xdisp.c (handle_stop): Detect whether we have overlay strings
1182 loaded by testing it->current.overlay_string_index to be
1183 non-negative, instead of checking whether n_overlay_strings is
1184 positive. (Bug#11587)
1185
efc00ab1 11862012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1187
1188 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1189
1190 * doc.c (Fsubstitute_command_keys): Doc fix.
1191
efc00ab1 11922012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1193
1194 * search.c (search_buffer): Remove calls to
1195 r_alloc_inhibit_buffer_relocation, as it is now called by
1196 maybe_unify_char, which was the cause of relocation of buffer text
1197 in bug#11519.
1198
efc00ab1 11992012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1200
1201 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1202 for the duration of call to load_charset, to avoid problems with
1203 callers of maybe_unify_char that access buffer text through C
1204 pointers.
1205
1206 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1207 decrement the inhibition flag, instead of just setting or
1208 resetting it.
1209
ba93a187
PE
12102012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 Remove obsolete '#define static' cruft.
1213 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1214 This #undef was "temporary" in 2000; it is no longer needed
1215 now that '#define static' has gone away.
1216 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1217 (gray_bitmap_bits): Remove; no longer needed.
1218 All uses replaced with definiens.
1219 * xterm.c: Include "bitmaps/gray.xbm".
1220
9e4bf381
PE
12212012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 Clean up __executable_start, monstartup when --enable-profiling.
1224 The following changes affect the code only when profiling.
1225 * dispnew.c (__executable_start): Rename from safe_bcopy.
1226 Define only on platforms that need it.
1227 * emacs.c: Include <sys/gmon.h> when profiling.
1228 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1229 (__executable_start): Remove decl, since lisp.h does it now.
1230 (safe_bcopy): Remove decl; no longer has that name.
1231 (main): Coalesce #if into single bit of code, for simplicity.
1232 Cast pointers to uintptr_t, since standard libraries want integers
1233 and not pointers.
1234 * lisp.h (__executable_start): New decl.
1235
32d72c2f
GM
12362012-05-31 Glenn Morris <rgm@gnu.org>
1237
1238 * image.c (Fimagemagick_types): Doc fix.
1239
baac5bc7
JM
12402012-05-30 Jim Meyering <meyering@redhat.com>
1241
1242 * callproc.c (Fcall_process_region): Include directory component
1243 in mkstemp error message (Bug#11586).
1244
72cb32cf
PE
12452012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1246
1247 * alloc.c, lisp.h (make_pure_vector): Now static.
1248
61b108cc
SM
12492012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1250
1251 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1252 Move to byte-run.el.
1253 (Fautoload): Do the hash-doc more carefully.
1254 * data.c (Fdefalias): Purify definition, except for keymaps.
1255 (Qdefun): Move from eval.c.
1256 * lisp.h (Qdefun): Remove.
1257 * lread.c (read1): Tiny simplification.
1258
471fe23d
TN
12592012-05-29 Troels Nielsen <bn.troels@gmail.com>
1260
934f3f58 1261 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1262 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1263 Bug#9642, but explicitly check that the buffer the overlay would
1264 be moved to is live and rearrange lines to make sure that errors
1265 will not put the overlay in an inconsistent state.
1266 (Fdelete_overlay): Cosmetics.
1267
85d0efd1
EZ
12682012-05-28 Eli Zaretskii <eliz@gnu.org>
1269
1270 * w32term.c (my_bring_window_to_top): New function.
1271 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1272 could be different from the original one.
1273 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1274 (Bug#11513)
1275
1276 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1277 by calling BringWindowToTop.
1278
1279 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1280 (WM_EMACS_END): Increase by one.
1281
da92a98c
PE
12822012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1285 This avoids undefined behavior that might cause the eassert
1286 to not catch an out-of-range value.
1287
74d1f848
JB
12882012-05-28 Juanma Barranquero <lekktu@gmail.com>
1289
1290 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1291 Update dependencies.
1292
9e1a06fc
EZ
12932012-05-27 Eli Zaretskii <eliz@gnu.org>
1294
1295 * bidi.c (bidi_mirror_char): Fix last change.
1296
f3dd7312
AS
12972012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1298
1299 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1300 when referring to sectname field in printf format.
1301
81899c91
PE
13022012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1303
57b81a9f
PE
1304 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1305 Only r_alloc_inhibit_buffer_relocation needed to be added;
1306 the others were already declared.
1307
81899c91
PE
1308 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1309 before checking whether it's out of range. Put the check inside
1310 eassert. See
1311 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1312
33017faf 13132012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1314
1315 * callproc.c (Fcall_process): Restore a line that was accidentally
1316 commented out in the 2011-02-13 change (bug#11547).
1317
33017faf 13182012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1319
1320 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1321 defined on ralloc.c.
1322
1323 * buffer.c [REL_ALLOC]: Remove prototypes of
1324 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1325 they are now on lisp.h.
1326
1327 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1328
1329 * search.c (search_buffer): Use it to inhibit relocation of buffer
1330 text while re_search_2 is doing its job, because re_search_2 is
1331 passed C pointers to buffer text. (Bug#11519)
1332
23415acf
EZ
1333 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1334 Update value to 24.
1335
44e27368
EZ
1336 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1337 state after an additional call to move_it_in_display_line_to, keep
1338 the values of it->max_ascent and it->max_descent found for the
1339 entire line.
1340 (pos_visible_p): Revert the comparison against bottom_y to what it
1341 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1342 (Bug#11464)
1343
c1892f11
PE
13442012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 Fix coding-related core dumps with gcc -ftrapv.
1347 The code was computing A - B, where A and B are pointers, and B is
1348 random garbage. This can lead to core dumps on platforms that
1349 have special pointer registers, and it also leads to core dumps on
1350 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1351 A - B only when B is initialized properly.
1352 * coding.c (coding_set_source, coding_set_destination): Return void.
1353 (coding_change_source, coding_change_destinations): New functions,
1354 with the old behaviors of coding_set_source and coding_set_destination.
1355 All callers that need an offset changed to use these new functions.
1356
eb7afdad
GM
13572012-05-26 Glenn Morris <rgm@gnu.org>
1358
1359 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1360
f12fdf02
EZ
13612012-05-26 Eli Zaretskii <eliz@gnu.org>
1362
53a63be6 1363 Extend mouse support on W32 text-mode console.
61b108cc
SM
1364 * xdisp.c (draw_row_with_mouse_face):
1365 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1366
eb3f6f01 1367 * w32console.c: Include window.h.
61b108cc
SM
1368 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1369 New functions.
eb3f6f01
EZ
1370 (initialize_w32_display): Initialize mouse-highlight data.
1371
53a63be6
EZ
1372 * w32inevt.c: Include termchar.h and window.h.
1373 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1374 moves, call note_mouse_highlight. If help_echo changed, call
1375 gen_help_event to produce help-echo message in the echo area.
1376 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1377 highlight info.
1378
4cfd81f6
PE
13792012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * lread.c (read1): Simplify slightly to avoid an overflow warning
1382 with GCC 4.7.0 on x86-64.
1383
4446092a
EZ
13842012-05-26 Eli Zaretskii <eliz@gnu.org>
1385
1386 * bidi.c (bidi_mirror_char): Revert last change: an int is
1387 definitely wide enough here.
1388
42b2a986 13892012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1390
42b2a986 1391 Fix integer width and related bugs (Bug#9874).
eb106a49 1392 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1393 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1394 (string_bytes, check_sblock, allocate_string_data):
1395 (compact_small_strings, Fmake_bool_vector, make_string)
1396 (make_unibyte_string, make_multibyte_string)
1397 (make_string_from_bytes, make_specified_string)
1398 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1399 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1400 (mark_vectorlike):
1401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1402 (allocate_pseudovector):
1403 Use int, not EMACS_INT, where int is wide enough.
1404 (inhibit_garbage_collection, Fgarbage_collect):
1405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1406 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1407 int might not be wide enough.
1408 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1409 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1410 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1411 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1412 (bidi_level_of_next_char, bidi_move_to_visually_next):
1413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1414 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1415 (Fkill_buffer, Fset_buffer_major_mode)
1416 (advance_to_char_boundary, Fbuffer_swap_text)
1417 (Fset_buffer_multibyte, overlays_at, overlays_in)
1418 (overlay_touches_p, struct sortvec, record_overlay_string)
1419 (overlay_strings, recenter_overlay_lists)
1420 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1421 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1422 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1423 (Foverlay_recenter, last_overlay_modification_hooks_used)
1424 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1426 (validate_region): Omit unnecessary test for b <= e,
1427 since that's guaranteed by the previous test.
d311d28c
PE
1428 (adjust_overlays_for_delete): Avoid pos + length overflow.
1429 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1430 (report_overlay_modification):
1431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1432 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1433 Omit pointer cast, which isn't needed anyway, and doesn't work
1434 after the EMACS_INT -> ptrdiff_t change.
02481186 1435 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1436 * buffer.h: Adjust decls to match defn changes elsewhere.
1437 (struct buffer_text, struct buffer):
1438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1439 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1440 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1441 not int, to avoid needless 32-bit limit on 64-bit hosts.
1442 (exec_byte_code): Use tighter memory-full test, one that checks
1443 for alloca overflow. Don't compute the address of the object just
1444 before an array, as that's not portable. Use EMACS_INT, not
1445 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1446 * callint.c (Fcall_interactively):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 * callproc.c (call_process_kill, Fcall_process):
1449 Don't assume pid_t fits into an Emacs fixnum.
1450 (call_process_cleanup, Fcall_process, child_setup):
1451 Don't assume pid_t fits into int.
1452 (call_process_cleanup, Fcall_process, delete_temp_file)
1453 (Fcall_process_region):
1454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1455 (Fcall_process): Simplify handling of volatile integers.
1456 Use int, not EMACS_INT, where int will do.
1457 * casefiddle.c (casify_object, casify_region, operate_on_word)
1458 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1460 (casify_object): Avoid integer overflow when overallocating buffer.
1461 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1462 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1463 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1464 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1465 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1466 integers are now checked earlier. All uses replaced with XINT.
1467 (ccl_driver):
1468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1469 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1470 (ccl_driver, Fregister_code_conversion_map):
1471 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1472 (resolve_symbol_ccl_program): Check that vector header is in range.
1473 Always copy the vector, so that we can check its contents reliably
1474 now rather than having to recheck each instruction as it's being
1475 executed. Check that vector words fit in 'int'.
1476 (ccl_get_compiled_code, Fregister_ccl_program)
1477 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1478 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1479 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1480 contents are in range.
1481 (Fccl_execute_on_string): Check that status is in range.
1482 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1483 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1484 Accept and return EMACS_INT, not int, because callers can pass values
1485 out of 'int' range.
1486 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1487 (multibyte_chars_in_text, parse_str_as_multibyte)
1488 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1489 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1490 (string_escape_byte8, Fget_byte):
1491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1492 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1493 avoid mishandling large integers.
1494 * character.h: Adjust decls to match defn changes elsewhere.
1495 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1496 (Ffind_charset_region):
1497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1498 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1499 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1500 Don't assume fixnum fits in int.
d311d28c
PE
1501 (load_charset_map_from_vector, Fmap_charset_chars):
1502 Remove now-unnecessary CHECK_NATNUMs.
1503 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1504 Don't rely on undefined behavior with signed left shift overflow.
1505 Don't assume unsigned int fits into fixnum, or that fixnum fits
1506 into unsigned int. Don't require max_code to be a valid fixnum;
1507 that's not true for gb10830 4-byte on a 32-bit host. Allow
1508 invalid_code to be a cons, for the same reason. Require code_offset
1509 to be a character. Avoid int overflow if max_char is close
1510 to INT_MAX.
1511 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1512 this is intended anyway and avoids some undefined behavior.
1513 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1514 INDEX_TO_CODE_POINT, as that's what it expects.
1515 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1516 * charset.h (DECODE_CHAR): Return int, not unsigned;
1517 this is what was intended anyway, and it avoids undefined behavior.
1518 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1519 integer-overflow issues.
1520 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1521 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1522 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1523 * chartab.c (Fmake_char_table, Fset_char_table_range)
1524 (uniprop_get_decoder, uniprop_get_encoder):
1525 Don't assume fixnum fits in int.
1526 * cmds.c (move_point): New function, that does the gist of
1527 Fforward_char and Fbackward_char, but does so while checking
1528 for integer overflow more accurately.
c96e5d6a 1529 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1530 (Fforward_line, Fend_of_line, internal_self_insert)
1531 (internal_self_insert):
1532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1533 Fix a FIXME, by checking for integer overflow when calculating
1534 target_clm and actual_clm.
1535 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1536 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1537 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1538 (coding_alloc_by_making_gap, alloc_destination)
1539 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1540 (encode_coding_utf_16, detect_coding_emacs_mule)
1541 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1542 (detect_coding_iso_2022, decode_coding_iso_2022)
1543 (encode_invocation_designation, encode_designation_at_bol)
1544 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1545 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1546 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1547 (encode_coding_ccl, encode_coding_raw_text)
1548 (detect_coding_charset, decode_coding_charset)
1549 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1550 (produce_composition, produce_charset, produce_annotation)
1551 (decode_coding, handle_composition_annotation)
1552 (handle_charset_annotation, consume_chars, decode_coding_gap)
1553 (decode_coding_object, encode_coding_object, detect_coding_system)
1554 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1555 (code_convert_region, code_convert_string)
8f50130c
PE
1556 (Fdefine_coding_system_internal)
1557 (coding_set_source, coding_set_destination):
d311d28c
PE
1558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1559 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1560 (Fdefine_coding_system_internal):
1561 Don't assume fixnums fit in int.
1562 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1563 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1564 (Funencodable_char_position, Fcheck_coding_systems_region)
1565 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1567 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1568 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1569 Don't access memory outside of the args array.
d311d28c 1570 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1571 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1572 result of ENCODE_CHAR.
d311d28c
PE
1573 * coding.h: Adjust decls to match defn changes elsewhere.
1574 (struct coding_system):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1576 * composite.c (get_composition_id, find_composition)
1577 (run_composition_function, update_compositions)
1578 (compose_text, composition_gstring_put_cache)
1579 (composition_gstring_p, composition_gstring_width)
1580 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1581 (composition_compute_stop_pos, composition_reseat_it)
1582 (composition_update_it, struct position_record)
1583 (find_automatic_composition, composition_adjust_point)
1584 (Fcomposition_get_gstring, Ffind_composition_internal):
1585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1586 (update_compositions):
1587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1588 * composite.h: Adjust decls to match defn changes elsewhere.
1589 (struct composition):
1590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1591 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1592 Do not attempt to compute the address of the object just before a
1593 buffer; this is not portable.
1594 (Faref, Faset):
1595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1596 (Faset): Use int, not EMACS_INT, where int is wide enough.
1597 (Fstring_to_number): Don't assume fixnums fit in int.
1598 (Frem): Don't assume arg is nonnegative.
1599 * dbusbind.c (xd_append_arg): Check for integers out of range.
1600 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1601 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1602 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1603 (xd_get_connection_references): Return ptrdiff_t, not int.
1604 All uses changed.
1605 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1606 (xd_read_message_1):
1607 Use int, not unsigned, where the dbus API uses int.
1608 (Fdbus_message_internal): Don't overflow mtype.
1609 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1610 * dired.c (directory_files_internal, file_name_completion, scmp)
1611 (file_name_completion_stat):
1612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1613 (file_name_completion): Don't overflow matchcount.
1614 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1615 * dispextern.h: Adjust decls to match defn changes elsewhere.
1616 (struct text_pos, struct glyph, struct bidi_saved_info)
1617 (struct bidi_string_data, struct bidi_it, struct composition_it)
1618 (struct it):
1619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1620 (struct display_pos, struct composition_it, struct it):
1621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1622 * dispnew.c (increment_matrix_positions)
1623 (increment_row_positions, mode_line_string)
1624 (marginal_area_string):
1625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1626 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1628 (duration_to_sec_usec): New function, to check for overflow better.
1629 (Fsleep_for, sit_for): Use it.
1630 * doc.c (get_doc_string, store_function_docstring):
1631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1632 (get_doc_string, Fsnarf_documentation):
1633 Use int, not EMACS_INT, where int is wide enough.
1634 (get_doc_string):
1635 Use SAFE_ALLOCA, not alloca.
1636 Check for overflow when converting EMACS_INT to off_t.
1637 * doprnt.c (doprnt):
1638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1639 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1640 Don't assume uid_t fits into fixnum.
1641 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1642 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1643 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1644 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1645 (general_insert_function)
1646 (Finsert_char, make_buffer_string, make_buffer_string_both)
1647 (update_buffer_properties, Fbuffer_substring)
1648 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1649 (Fsubst_char_in_region, check_translation)
1650 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1651 (transpose_markers, Ftranspose_regions):
1652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1653 (clip_to_bounds): Move to lisp.h as an inline function).
1654 (Fconstrain_to_field): Don't assume integers are nonnegative.
1655 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1656 (Fsubst_char_in_region, Fsave_restriction):
1657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1658 (Femacs_pid): Don't assume pid_t fits into fixnum.
1659 (lo_time): Use int, not EMACS_INT, when int suffices.
1660 (lisp_time_argument): Check for usec out of range.
1661 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1662 (Fuser_login_name, Fuser_full_name): Signal an error
1663 if a uid argument is out of range, rather than relying on
1664 undefined behavior.
c8d5c857
PE
1665 (Fformat_time_string): Remove now-unnecessary check.
1666 lisp_time_argument checks for out-of-range usec now.
243e0530 1667 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1668 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1669 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1670 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1671 (init_cmdargs, Fdump_emacs):
1672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1673 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1674 the bottom (typically) 32 bits of the fixnum.
1675 * eval.c (specpdl_size, call_debugger):
1676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1677 (when_entered_debugger, Fbacktrace_debug):
1678 Don't assume fixnum can fit in int.
1679 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1680 the object just before a buffer; this is not portable.
1681 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1682 (grow_specpdl, unbind_to):
1683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1684 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1685 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1686 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1687 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1688 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1690 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1691 (a_write, e_write):
1692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1693 (Fcopy_file, non_regular_nbytes, read_non_regular)
1694 (Finsert_file_contents):
1695 Use int, not EMACS_INT, where int is wide enough.
1696 (READ_BUF_SIZE): Verify that it fits in int.
1697 (Finsert_file_contents): Check that counts are in proper range,
1698 rather than assuming fixnums fit into ptrdiff_t etc.
1699 Don't assume fixnums fit into int.
125b3835 1700 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1701 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1702 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1703 (string_char_to_byte, string_byte_to_char)
1704 (string_make_multibyte, string_to_multibyte)
1705 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1706 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1707 (substring_both, Fdelete, internal_equal, Ffillarray)
1708 (Fclear_string, mapcar1)
1709 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1710 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1711 (larger_vector, make_hash_table, maybe_resize_hash_table)
1712 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1713 (Fmaphash, secure_hash):
1714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1715 (concat): Check for string index and length overflow.
1716 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1717 (Frequire):
1718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1719 (larger_vector): New API (vec, incr_min, size_max) replaces old
1720 one (vec, new_size, init). This catches size overflow.
1721 INIT was removed because it was always Qnil.
1722 All callers changed.
1723 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1724 the upper bound on a hash table index size.
1725 (make_hash_table, maybe_resize_hash_table): Use it.
1726 (secure_hash): Computer start_byte and end_byte only after
1727 they're known to be in ptrdiff_t range.
1728 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1729 (Ffont_get_glyphs, Ffont_at):
1730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1731 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1732 (Flist_fonts, Fopen_font):
1733 Don't assume fixnum can fit in int.
1734 (check_gstring): Don't assume index can fit in int.
1735 (font_match_p): Check that fixnum is a character, not a nonnegative
1736 fixnum, since the later code needs to stuff it into an int.
1737 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1738 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1739 conversion overflow issues.
1740 (Fopen_font): Check for integer out of range.
1741 (Ffont_get_glyphs): Don't assume index can fit in int.
1742 * font.h: Adjust decls to match defn changes elsewhere.
1743 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1744 integer overflow.
1745 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1746 printmax_t, where ptrdiff_t is wide enough.
1747 (Finternal_char_font):
1748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1749 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1750 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1751 (Fset_frame_position, x_set_frame_parameters)
1752 (x_set_line_spacing, x_set_border_width)
1753 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1754 Check that fixnums are in proper range for system types.
1755 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1757 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1758 Use SAFE_ALLOCA_LISP, not alloca.
1759 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1760 intptr_t is wide enough.
1761 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1762 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1763 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1764 Check for fixnum out of range.
1765 * ftfont.c (ftfont_list): Don't assume index fits in int.
1766 Check that fixnums are in proper range for system types.
1767 (ftfont_shape_by_flt):
1768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1769 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1771 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1772 Check that fixnums are in proper range for system types.
1773 * gnutls.h: Adjust decls to match defn changes elsewhere.
1774 * gtkutil.c (xg_dialog_run):
1775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1776 (update_frame_tool_bar):
1777 Check that fixnums are in proper range for system types.
1778 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1779 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1780 * indent.c (last_known_column, last_known_column_point):
1781 (current_column_bol_cache):
1782 (skip_invisible, current_column, check_display_width):
1783 (check_display_width, scan_for_column, current_column_1)
1784 (Findent_to, Fcurrent_indentation, position_indentation)
1785 (indented_beyond_p, Fmove_to_column, compute_motion):
1786 (Fcompute_motion, Fvertical_motion):
1787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1788 (last_known_column_modified): Use EMACS_INT, not int.
1789 (check_display_width):
1790 (Fcompute_motion):
1791 Check that fixnums and floats are in proper range for system types.
1792 (compute_motion): Don't assume index or fixnum fits in int.
1793 (compute_motion, Fcompute_motion):
1794 Use int, not EMACS_INT, when it is wide enough.
1795 (vmotion): Omit local var start_hpos that is always 0; that way
1796 we don't need to worry about overflow in expressions involving it.
1797 * indent.h: Adjust decls to match defn changes elsewhere.
1798 (struct position):
1799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1800 Use int, not EMACS_INT, where int is wide enough.
1801 Remove unused members ovstring_chars_done and tab_offset;
1802 all uses removed.
1803 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1804 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1805 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1806 (make_gap, copy_text, insert, insert_and_inherit)
1807 (insert_before_markers, insert_before_markers_and_inherit)
1808 (insert_1, count_combining_before, count_combining_after)
1809 (insert_1_both, insert_from_string)
1810 (insert_from_string_before_markers, insert_from_string_1)
1811 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1812 (adjust_after_replace, adjust_after_insert, replace_range)
1813 (replace_range_2, del_range, del_range_1, del_range_byte)
1814 (del_range_both, del_range_2, modify_region)
1815 (prepare_to_modify_buffer, signal_before_change)
1816 (signal_after_change, Fcombine_after_change_execute):
1817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1818 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1819 (balance_an_interval, split_interval_right, split_interval_left)
1820 (find_interval, next_interval, update_interval)
1821 (adjust_intervals_for_insertion, delete_node, delete_interval)
1822 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1823 (static_offset_intervals, offset_intervals)
1824 (merge_interval_right, merge_interval_left, make_new_interval)
1825 (graft_intervals_into_buffer, temp_set_point_both)
1826 (temp_set_point, set_point, adjust_for_invis_intang)
1827 (set_point_both, move_if_not_intangible, get_property_and_range)
1828 (get_local_map, copy_intervals, copy_intervals_to_string)
1829 (compare_string_intervals, set_intervals_multibyte_1):
1830 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1831 * intervals.h: Adjust decls to match defn changes elsewhere.
1832 (struct interval):
1833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1834 * keyboard.c (this_command_key_count, this_single_command_key_start)
1835 (before_command_key_count, before_command_echo_length, echo_now)
1836 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1837 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1838 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1839 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1841 (last_non_minibuf_size, last_point_position, echo_truncate)
1842 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1843 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1844 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1845 (stuff_buffered_input):
1846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1847 (last_auto_save, command_loop_1, read_char):
1848 Use EMACS_INT, not int, to avoid integer overflow.
1849 (record_char): Avoid overflow in total_keys computation.
1850 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1851 * keyboard.h: Adjust decls to match defn changes elsewhere.
1852 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1853 (Fkey_description, Fdescribe_vector, Flookup_key):
1854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1855 (click_position): New function, to check that positions are in range.
1856 (Fcurrent_active_maps):
1857 (describe_command):
1858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1859 (Faccessible_keymaps, Fkey_description):
1860 (preferred_sequence_p):
1861 Don't assume fixnum can fit into int.
1862 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1863 Check for integer overflow in size calculations.
1864 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1865 avoid mishandling large integers.
1866 * lisp.h: Adjust decls to match defn changes elsewhere.
1867 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1868 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1869 (struct Lisp_Marker):
1870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1871 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1872 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1873 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1874 All callers changed.
1875 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1876 Assume the arg has valid form, since it always does.
1877 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1878 unsigned integer system type.
1879 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1880 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1882 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1883 (duration_to_sec_usec): New decl.
1884 * lread.c (read_from_string_index, read_from_string_index_byte)
1885 (read_from_string_limit, readchar, unreadchar, openp)
1886 (read_internal_start, read1, oblookup):
1887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1888 (Fload, readevalloop, Feval_buffer, Feval_region):
1889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1890 (openp): Check for out-of-range argument to 'access'.
1891 (read1): Use int, not EMACS_INT, where int is wide enough.
1892 Don't assume fixnum fits into int.
6efdadfd 1893 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1894 (read_filtered_event): Use duration_to_sec_usec
1895 to do proper overflow checking on durations.
d311d28c
PE
1896 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1897 in size calculation.
1898 (Fexecute_kbd_macro):
1899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1900 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1901 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1902 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1903 (set_marker_both, set_marker_restricted_both, marker_position)
1904 (marker_byte_position, Fbuffer_has_markers_at):
1905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1906 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1907 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1908 It now merely ensures that the menu is large enough, without
1909 necessarily growing it, as this avoids some integer overflow issues.
1910 All callers changed.
1911 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1913 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1914 Use SAFE_ALLOCA_LISP, not alloca.
1915 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1916 to EMACS_INT. Check that fixnums are in proper range for system types.
1917 * minibuf.c (minibuf_prompt_width, string_to_object)
1918 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1919 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1921 (get_minibuffer, read_minibuf_unwind):
1922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1923 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1924 this simplifies overflow checking. All callers changed.
1925 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1926 (Ftest_completion):
1927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1928 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1929 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1930 Check that fixnums are in proper range for system types.
1931 (Fx_create_frame, Fx_show_tip):
1932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1933 * nsfont.m (ns_findfonts, nsfont_list_family):
1934 Don't assume fixnum fits in long.
1935 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1937 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1938 wide enough.
17fdb222 1939 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1941 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1942 (PRINTDECLARE, PRINTPREPARE):
1943 (strout, print_string):
1944 (print, print_preprocess, print_check_string_charset_prop)
1945 (print_object):
1946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1947 (PRINTDECLARE):
1948 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1950 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1951 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1952 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1953 (print_error_message): Use SAFE_ALLOCA, not alloca.
1954 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1955 (print_depth, new_backquote_output, print_number_index):
1956 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1957 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1958 (Fset_process_window_size, Fformat_network_address)
1959 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1960 (sigchld_handler):
d311d28c 1961 Check that fixnums are in proper range for system types.
d44287d4 1962 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1963 Check for process-ids out of pid_t range rather than relying on
1964 undefined behavior.
e4d81efc 1965 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1966 (Fformat_network_address, read_process_output, send_process)
1967 (Fprocess_send_region, status_notify):
1968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1969 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1970 (wait_reading_process_output, read_process_output, exec_sentinel):
1971 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1972 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1973 (Faccept_process_output): Use duration_to_sec_usec to do proper
1974 overflow checking on durations.
dde14581
PE
1975 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1976 Don't assume pid_t fits in int.
02481186
PE
1977 * process.h (struct Lisp_Process): Members tick and update_tick
1978 are now of type EMACS_INT, not int.
b62b53e8
PE
1979 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1980 configured --with-wide-int.
d311d28c
PE
1981 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1982 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1983 * search.c (looking_at_1, string_match_1):
1984 (fast_string_match, fast_c_string_match_ignore_case)
1985 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1986 (scan_newline, find_before_next_newline, search_command)
1987 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1988 (set_search_regs, wordify):
1989 (Freplace_match):
1990 (Fmatch_data):
1991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1992 (string_match_1, search_buffer, set_search_regs):
1993 (Fmatch_data):
1994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1995 (wordify): Check for overflow in size calculation.
1996 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1997 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1998 Check that fixnums are in proper range for system types.
1999 * sound.c (struct sound_device)
2000 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2002 (Fplay_sound_internal):
2003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2004 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2005 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2006 (Fparse_partial_sexp):
2007 Don't assume fixnums can fit in int.
2008 (struct lisp_parse_state, find_start_pos, find_start_value)
2009 (find_start_value_byte, find_start_begv)
2010 (update_syntax_table, char_quoted, dec_bytepos)
2011 (find_defun_start, prev_char_comend_first, back_comment):
2012 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2013 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2015 (Finternal_describe_syntax_value): Check that match_lisp is a
2016 character, not an integer, since the code stuffs it into int.
2017 (scan_words, scan_sexps_forward):
2018 Check that fixnums are in proper range for system types.
2019 (Fforward_word):
2020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2021 (scan_sexps_forward):
2022 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2023 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2024 * syntax.h: Adjust decls to match defn changes elsewhere.
2025 (struct gl_state_s):
2026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2027 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2028 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2029 * sysdep.c (wait_for_termination_1, wait_for_termination)
2030 (interruptible_wait_for_termination, mkdir):
2031 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2032 (emacs_read, emacs_write):
2033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2034 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2035 and double all fit in int.
d311d28c
PE
2036 * term.c (set_tty_color_mode):
2037 Check that fixnums are in proper range for system types.
2038 * termhooks.h (struct input_event):
2039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2040 * textprop.c (validate_interval_range, interval_of)
2041 (Fadd_text_properties, set_text_properties_1)
2042 (Fremove_text_properties, Fremove_list_of_text_properties)
2043 (Ftext_property_any, Ftext_property_not_all)
2044 (copy_text_properties, text_property_list, extend_property_ranges)
2045 (verify_interval_modification):
2046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2047 (Fnext_single_char_property_change)
2048 (Fprevious_single_char_property_change):
2049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2050 (copy_text_properties):
2051 Check for integer overflow in index calculation.
d311d28c
PE
2052 * undo.c (last_boundary_position, record_point, record_insert)
2053 (record_delete, record_marker_adjustment, record_change)
2054 (record_property_change):
2055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2056 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2058 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2059 (Fx_hide_tip, Fx_file_dialog):
2060 * w32menu.c (set_frame_menubar):
2061 Use ptrdiff_t, not int, for consistency with rest of code.
2062 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2063 (select_window, Fdelete_other_windows_internal)
2064 (window_scroll_pixel_based, window_scroll_line_based)
2065 (Frecenter, Fset_window_configuration):
2066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2067 (Fset_window_hscroll, run_window_configuration_change_hook)
2068 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2069 (Fscroll_other_window, Frecenter):
d311d28c
PE
2070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2071 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2072 Don't assume fixnum fits in int.
2073 (Fset_window_scroll_bars):
2074 Check that fixnums are in proper range for system types.
2075 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2076 (string_pos, c_string_pos, number_of_chars, init_iterator)
2077 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2078 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2079 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2080 (face_before_or_after_it_pos, handle_invisible_prop)
2081 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2082 (display_prop_intangible_p, string_buffer_position_lim)
2083 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2084 (get_overlay_strings_1, get_overlay_strings)
2085 (iterate_out_of_display_property, forward_to_next_line_start)
2086 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2087 (get_next_display_element, set_iterator_to_next)
2088 (get_visually_first_element, compute_stop_pos_backwards)
2089 (handle_stop_backwards, next_element_from_buffer)
2090 (move_it_in_display_line_to, move_it_in_display_line)
2091 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2092 (add_to_log, message_dolog, message_log_check_duplicate)
2093 (message2, message2_nolog, message3, message3_nolog
2094 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2095 (current_message_1, truncate_echo_area, truncate_message_1)
2096 (set_message, set_message_1, store_mode_line_noprop)
2097 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2098 (text_outside_line_unchanged_p, check_point_in_composition)
2099 (reconsider_clip_changes)
2100 (redisplay_internal, set_cursor_from_row, try_scrolling)
2101 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2102 (redisplay_window, find_last_unchanged_at_beg_row)
2103 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2104 (trailing_whitespace_p, find_row_edges, display_line)
2105 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2106 (display_mode_element, store_mode_line_string)
2107 (pint2str, pint2hrstr, decode_mode_spec)
2108 (display_count_lines, display_string, draw_glyphs)
2109 (x_produce_glyphs, x_insert_glyphs)
2110 (rows_from_pos_range, mouse_face_from_buffer_pos)
2111 (fast_find_string_pos, mouse_face_from_string_pos)
2112 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2114 (safe_call, init_from_display_pos, handle_fontified_prop)
2115 (handle_single_display_spec, load_overlay_strings)
2116 (with_echo_area_buffer, setup_echo_area_for_printing)
2117 (display_echo_area, echo_area_display)
2118 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2119 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2120 (redisplay_window, dump_glyph_row, display_mode_line)
2121 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2122 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2124 (handle_single_display_spec, build_desired_tool_bar_string)
2125 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2126 (get_specified_cursor_type):
2127 Check that fixnums are in proper range for system types.
2128 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2129 (Flookup_image_map):
2130 Don't assume fixnums fit in int.
2131 (compare_overlay_entries):
2132 Avoid mishandling comparisons due to subtraction overflow.
2133 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2134 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2135 (handle_tool_bar_click):
2136 Use int, not unsigned, since we prefer signed and the signedness
2137 doesn't matter here.
2138 (get_next_display_element, next_element_from_display_vector):
2139 Use int, not EMACS_INT, when int is wide enough.
2140 (start_hourglass): Use duration_to_sec_usec to do proper
2141 overflow checking on durations.
2142 * xfaces.c (Fbitmap_spec_p):
2143 Check that fixnums are in proper range for system types.
2144 (compare_fonts_by_sort_order):
2145 Avoid mishandling comparisons due to subtraction overflow.
2146 (Fx_family_fonts, realize_basic_faces):
2147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2148 (Fx_family_fonts):
2149 Don't assume fixnum fits in int.
2150 Use SAFE_ALLOCA_LISP, not alloca.
2151 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2152 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2153 (face_at_buffer_position, face_for_overlay_string)
2154 (face_at_string_position):
2155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2156 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2157 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2158 (Fx_show_tip):
2159 Check that fixnums are in proper range for system types.
2160 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2161 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2162 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2163 (Fx_change_window_property): Don't assume fixnums fit in int.
2164 * xfont.c (xfont_chars_supported):
2165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2166 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2167 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2169 * xml.c (parse_region):
2170 * xrdb.c (magic_file_p):
2171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2172 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2173 (x_get_local_selection, x_reply_selection_request)
2174 (x_handle_selection_request, wait_for_property_change):
2175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2176 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2177 short is wide enough.
2178 (x_send_client_event): Don't assume fixnum fits in int.
2179 * xterm.c (x_x_to_emacs_modifiers):
2180 Don't assume EMACS_INT overflows nicely into int.
2181 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2182 may come from Lisp.
2183 (handle_one_xevent): NATNUMP can eval its arg twice.
2184 (x_connection_closed):
2185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2186 * xterm.h: Adjust decls to match defn changes elsewhere.
2187 (struct scroll_bar): Use struct vectorlike_header
2188 rather than rolling our own approximation.
2189 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2190
c6574eb5
GM
21912012-05-25 Glenn Morris <rgm@gnu.org>
2192
2193 * lisp.mk (lisp): Update for more files being compiled now.
2194
e8d32c7e
SM
21952012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2196
48def666
SM
2197 * lread.c: Remove `read_pure' which makes no difference.
2198 (read_pure): Remove var.
2199 (unreadpure): Remove function.
2200 (readevalloop): Don't call read_list with -1 flag.
2201 (read1, read_vector): Don't test read_pure any more.
2202 (read_list): Simplify.
2203
e8d32c7e
SM
2204 * fileio.c, character.h: Minor style tweaks.
2205
4b2addb7
DA
22062012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2207
2208 * window.h (clip_changed): Remove useless declaration.
2209
584461b2
JB
22102012-05-22 Juanma Barranquero <lekktu@gmail.com>
2211
2212 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2213 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2214
34374650
PE
22152012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 Remove src/m/*.
2218 This directory predates autoconf and is no longer needed nowadays.
2219 Move its few remaining bits of functionality to where they're needed.
2220 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2221 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2222 * m/template.h: Remove.
2223 * Makefile.in (M_FILE): Remove. All uses removed.
2224 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2225 * lisp.h (USE_LSB_TAG):
2226 * mem-limits.h (EXCEEDS_LISP_PTR):
2227 Use VAL_MAX, not VALBITS, in #if.
2228 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2229 (EMACS_UINT): Define unconditionally now.
2230 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2231 (BITS_PER_EMACS_INT): New constants, replacing
2232 what used to be in config.h, but not useful in #if.
2233 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2234 define them any more.
2235 (VAL_MAX): New macro.
2236 (VALMASK): Use it.
2237 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2238 BITS_PER_EMACS_INT, in #if.
2239 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2240 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2241 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2242 * s/ms-w32.h (DATA_START):
2243 Move here from removed file m/intel386.h.
2244 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2245 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2246
261cb4bb
PE
22472012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 Assume C89 or later.
2250 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2251 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2252 (xrealloc):
2253 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2254 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2255 * textprop.c, tparam.c (NULL): Remove.
2256 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2257 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2258 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2259 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2260 * xterm.c (input_signal_count): Assume volatile works.
2261
ff23cd9f
KB
22622012-05-21 Ken Brown <kbrown@cornell.edu>
2263
2264 * xgselect.c (xg_select): Fix first argument in call to 'select'
2265 (bug#11508).
2266
1b170bc6
KB
22672012-05-20 Ken Brown <kbrown@cornell.edu>
2268
2269 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2270 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2271
b2f4d39f
KB
22722012-05-19 Ken Brown <kbrown@cornell.edu>
2273
2274 * xfns.c (x_in_use): Remove `static' qualifier.
2275 * xterm.h (x_in_use): Declare.
2276 * xgselect.c: Include xterm.h.
2277 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2278 and `display_arg' (bug#9754).
2279
003fdae2
PE
22802012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2281
9232a6d9
PE
2282 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2283
003fdae2
PE
2284 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2285 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2286
784b56e2
EZ
22872012-05-18 Eli Zaretskii <eliz@gnu.org>
2288
2289 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2290
2291 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2292 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2293
2294 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2295 reference to image_cache->refcount.
2296 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2297
a0a79cde
JL
22982012-05-17 Juri Linkov <juri@jurta.org>
2299
2300 * search.c (Fword_search_regexp, Fword_search_backward)
2301 (Fword_search_forward, Fword_search_backward_lax)
2302 (Fword_search_forward_lax): Move functions to isearch.el
2303 (bug#10145, bug#11381).
2304
b0572523
PE
23052012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2308
9660f5fc
SM
23092012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2310
2311 * lread.c (init_obarray): Declare Qt and Qnil as special.
2312
4374de83
GM
23132012-05-14 Glenn Morris <rgm@gnu.org>
2314
2315 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2316 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2317
dc44c39a
PE
23182012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2319
078c97cb
PE
2320 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2321
dc44c39a
PE
2322 * unexaix.c: Port to more-recent AIX compilers.
2323 (report_error, report_error_1, make_hdr, copy_sym)
2324 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2325 Make arguments const char *, not char *, to avoid violations of C
2326 standard and to fix some AIX warnings reported by Gilles Pion.
2327
e18afed7 23282012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2329
2330 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2331 already have overlays loaded.
2332 (handle_single_display_spec): Before returning without displaying
2333 fringe bitmap, synchronize the bidi iterator with the main display
2334 iterator, by calling iterate_out_of_display_property.
2335 (iterate_out_of_display_property): Detect buffer iteration by
2336 testing that it->string is a Lisp string.
2337 (get_next_display_element): When the current object is exhausted,
2338 and there's something on it->stack, call set_iterator_to_next to
2339 proceed with what's on the stack, instead of returning zero.
2340 (set_iterator_to_next): If called at the end of a Lisp string,
2341 proceed to consider_string_end without incrementing string
2342 position. Don't increment display vector index past the end of
2343 the display vector. (Bug#11417)
c8fb9dc6
EZ
2344 (pos_visible_p): Don't report a position visible when move_it_to
2345 stopped at the last line of window, which happens to be scanned
2346 backwards by the bidi iteration. (Bug#11464)
ac268e67 2347
e18afed7 23482012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2349
2350 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2351 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2352 are on a TTY, and thus unable to display on the fringes.
2353 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2354 so we need to signal to the caller that this is a "replacing"
2355 display spec. This fixes display when the spec is invalid or we
2356 are on a TTY.
2357
e18afed7 23582012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2359
2360 * unexaix.c (make_hdr): Fix typo in prototype.
2361 This bug broke the build on AIX. Problem reported by Gilles Pion.
2362
9d0a235a
MA
23632012-05-14 Michael Albinus <michael.albinus@gmx.de>
2364
2365 * keyboard.c (kbd_buffer_get_event): Read special events also in
2366 batch mode. (Bug#11415)
2367
9e6b06ed
GM
23682012-05-12 Glenn Morris <rgm@gnu.org>
2369
2370 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2371
c1a1d7a3
EZ
23722012-05-12 Eli Zaretskii <eliz@gnu.org>
2373
2374 * lisp.mk (lisp): Add newcomment.elc.
2375
3fe7cdc8
GM
23762012-05-12 Glenn Morris <rgm@gnu.org>
2377
2378 * Makefile.in (MKDIR_P): New, set by configure.
2379 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2380
53f7d2c0
PE
23812012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 Remove unused function hourglass_started.
2384 * dispextern.h (hourglass_started):
2385 * w32fns.c (hourglass_started):
2386 * xdisp.c (hourglass_started): Remove.
2387
75aafb17
JB
23882012-05-10 Juanma Barranquero <lekktu@gmail.com>
2389
2390 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2391 Update dependencies.
2392
12959e8e
PE
23932012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2394
97107e2e
PE
2395 * xgselect.c (xg_select): Put maxfds+1 into a var.
2396 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2397
12959e8e
PE
2398 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2399
836d29b3
DA
24002012-05-10 Dave Abrahams <dave@boostpro.com>
2401
2402 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2403 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2404
5cb67954
MA
24052012-05-09 Michael Albinus <michael.albinus@gmx.de>
2406
2407 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2408 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2409 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2410 Initialize xd_registered_buses.
2411
3478ec45
PE
24122012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2413
b263a6b0
PE
2414 Untag more efficiently if USE_LSB_TAG.
2415 This is based on a proposal by YAMAMOTO Mitsuharu in
2416 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2417 For an admittedly artificial (nth 8000 longlist) benchmark on
2418 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2419 Emacs's overall text size by 1%.
2420 * lisp.h (XUNTAG): New macro.
2421 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2422 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2423 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2424 * eval.c (Fautoload):
2425 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2426 * frame.h (XFRAME): Use XUNTAG.
2427
3478ec45
PE
2428 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2429 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2430 Remove unportable assumptions about print widths of types like
2431 dbus_uint32_t.
2432 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2433 intptr_t when converting between pointer and integer, to avoid GCC
2434 warnings about wrong width.
2435
666b903b 24362012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2437
2438 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2439 stack for each reader_thread, instead of defaulting to 8MB
2440 determined by the linker. This avoids failures in creating
2441 subprocesses on Windows 7, see the discussion in this thread:
2442 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2443
b120cc17
JC
24442012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2445
2446 Fix up display of the *Minibuf-0* buffer in the mini window.
2447 * keyboard.c (read_char): Don't clear the echo area if there's no
2448 message to clear.
2449 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2450 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2451
9a4b36f8
MA
24522012-05-07 Michael Albinus <michael.albinus@gmx.de>
2453
2454 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2455 batch mode.
2456
e5f9458f
CY
24572012-05-06 Chong Yidong <cyd@gnu.org>
2458
2459 * lisp.mk (lisp): Update.
2460
eceeb5fc 24612012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2462
2463 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2464
71873e2b
SM
24652012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2466
2467 * data.c (PUT_ERROR): New macro.
2468 (syms_of_data): Use it. Add new error type `user-error'.
2469 * undo.c (user_error): New function.
2470 (Fprimitive_undo): Use it.
2471 * print.c (print_error_message): Adjust print style for `user-error'.
2472 * keyboard.c (user_error): New function.
2473 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2474
ab0fa4e4
PE
24752012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 Do not limit current-time-string to years 1000..9999.
2478 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2479 (Fcurrent_time_string): Support any year that is supported by the
2480 underlying localtime representation. Don't use asctime, as it
2481 has undefined behavior for years outside the range -999..9999.
2482
7ed806a7
PE
24832012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 Fix race conditions involving setenv, gmtime, localtime, asctime.
2486 Without this fix, interrupts could mess up code that uses these
2487 nonreentrant functions, since setting TZ invalidates existing
2488 tm_zone or tzname values, and since most of these functions return
2489 pointers to static storage.
2490 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2491 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2492 Grow the critical sections to include not just invoking
2493 localtime/gmtime, but also accessing these functions' results
2494 including their tm_zone values if any, and any related TZ setting.
2495 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2496 so that the struct tm is saved in the critical section.
2497 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2498 motivated by the fact that memory allocation needs to be outside
2499 the critical section.
2500
0c16dfed
DA
25012012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2502
2503 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2504 with RESET_INTERVAL.
2505
2506 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2507 Remove duplicated buffer name initialization.
2508
3f83ace8
JM
25092012-05-02 Jim Meyering <jim@meyering.net>
2510
2511 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2512
c7b8541e
JM
2513 * xfns.c (x_window): Use xstrdup (Bug#11375).
2514
90207a15 25152012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2516
2517 * xdisp.c (pos_visible_p): If already at a newline from the
2518 display string before the 'while' loop, don't walk back the glyphs
2519 from it3.glyph_row. Solves assertion violation when the display
2520 string begins with a newline (egg.el). (Bug#11367)
2521
b593d6a9
AH
25222012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2523
2524 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2525 Move to simple.el.
2526
4737362e
GM
25272012-05-01 Glenn Morris <rgm@gnu.org>
2528
99cf43f9
GM
2529 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2530 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2531 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2532 All were removed before 23.1.
2533
9311dcff
GM
2534 * dispnew.c: Remove HAVE_LIBNCURSES test;
2535 it is always true on relevant platforms.
2536
4d5c6349
GM
2537 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2538 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2539
4737362e
GM
2540 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2541
74dd3a6b
AS
25422012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2543
2544 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2545 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2546 Remove.
2547
13c379ee
PE
25482012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 Do not avoid creating empty evaporating overlays (Bug#9642).
2551 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2552 That is, do not delete an evaporating overlay if it becomes
2553 empty after its bounds are adjusted to fit within its buffer.
2554 This fix caused other problems, and I'm reverting it until we get
2555 to the bottom of them.
2556
a8e7d6d7 25572012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2558
2559 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2560
a8e7d6d7 25612012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2562
2563 * xdisp.c (pos_visible_p): If the window start position is beyond
2564 ZV, start the display from buffer beginning. Prevents assertion
2565 violation in init_iterator when the minibuffer window is scrolled
2566 via the scroll bar.
2567
2568 * window.c (window_scroll_pixel_based): Likewise.
2569
a8e7d6d7 25702012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2571
2572 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2573
a8e7d6d7 25742012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2575
2576 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2577 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2578
a8e7d6d7 25792012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2580
b593d6a9
AH
2581 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2582 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2583
1c6900d9
EZ
25842012-04-26 Eli Zaretskii <eliz@gnu.org>
2585
4c3fa1d9
EZ
2586 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2587 display element, check also the underlying string or buffer
2588 character. (Bug#11341)
2589
1c6900d9
EZ
2590 * w32menu.c: Include w32heap.h.
2591 (add_menu_item): If the call to AppendMenuW (via
2592 unicode_append_menu) fails, disable Unicode menus only if we are
2593 running on Windows 9X/Me.
2594
42bf8205
AS
25952012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2596
2597 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2598 (xgetint): Add missing shift for LSB tags.
2599
b1bac16e
MR
26002012-04-24 Martin Rudalics <rudalics@gmx.at>
2601
2602 * keyboard.c (read_char): Don't wipe echo area for select window
2603 events: These might get delayed via `mouse-autoselect-window'
2604 (Bug#11304).
2605
d69621cc
JB
26062012-04-24 Juanma Barranquero <lekktu@gmail.com>
2607
2608 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2609 manipulation of :loaded-from data.
2610
02fd101b
JB
26112012-04-23 Juanma Barranquero <lekktu@gmail.com>
2612
2613 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2614 now a cons (bug#11311).
2615
888bec30
PE
26162012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2617
89a438bd
PE
2618 Do not create empty overlays with the evaporate property (Bug#9642).
2619 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2620 if it becomes empty after its bounds are adjusted to fit within
2621 its buffer. Without this fix, in a nonempty buffer (let ((o
2622 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2623 yields an empty overlay that has the evaporate property, which is
2624 not supposed to happen.
2625
1068fe4d
PE
2626 Fix minor GTK3 problems found by static checking.
2627 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2628 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2629 (struct _EmacsFixedClass, emacs_fixed_get_type):
2630 Move decls here from emacsgtkfixed.h, since they needn't be public.
2631 (emacs_fixed_get_type): Now static.
2632 (emacs_fixed_class_init): Omit unused local.
2633 (emacs_fixed_child_type): Remove; unused.
2634 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2635 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2636 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2637 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2638 (EMACS_FIXED_GET_CLASS): Remove; unused.
2639 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2640
888bec30
PE
2641 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2642 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2643
de85e130
PE
26442012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2645
d0baac98 2646 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2647 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2648 (__malloc_size_t, __malloc_ptrdiff_t):
2649 Remove. All uses removed, replaced by the definiens if needed,
2650 since we can assume C89 or better now.
2651 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2652 (protect_malloc_state, align, get_contiguous_space)
2653 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2654 (malloc_atfork_handler_child, malloc_enable_thread)
2655 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2656 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2657 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2658 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2659 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2660 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2661 Define using prototypes, not old style.
2662 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2663 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2664 (align): Don't assume that signed integer overflow wraps around.
2665 Omit unused local var.
2666 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2667 (_free_internal_nolock, memalign, mallochook, reallochook):
2668 Omit no-longer-needed casts.
2669 (valloc): Use getpagesize, not __getpagesize.
2670 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2671 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2672
de85e130
PE
2673 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2674
dcbf5805
MA
26752012-04-22 Michael Albinus <michael.albinus@gmx.de>
2676
2677 Move functions from C to Lisp. Make non-blocking method calls
2678 the default. Implement further D-Bus standard interfaces.
2679
2680 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2681 (QCdbus_request_name_allow_replacement)
2682 (QCdbus_request_name_replace_existing)
2683 (QCdbus_request_name_do_not_queue)
2684 (QCdbus_request_name_reply_primary_owner)
2685 (QCdbus_request_name_reply_in_queue)
2686 (QCdbus_request_name_reply_exists)
2687 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2688 (QCdbus_registered_serial, QCdbus_registered_method)
2689 (QCdbus_registered_signal): New Lisp objects.
2690 (XD_DEBUG_MESSAGE): Use sizeof.
2691 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2692 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2693 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2694 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2695 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2696 (xd_signature, xd_append_arg): Allow float for integer types.
2697 (xd_get_connection_references): New function.
b593d6a9
AH
2698 (xd_get_connection_address): Rename from xd_initialize.
2699 Return cached address.
dcbf5805
MA
2700 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2701 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2702 level.
2703 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2704 Return number of refcounts.
dcbf5805
MA
2705 (Fdbus_get_unique_name): Make stronger parameter check.
2706 (Fdbus_message_internal): New defun.
2707 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2708 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2709 (Fdbus_send_signal, Fdbus_register_service)
2710 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2711 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2712 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2713 (Vdbus_compiled_version, Vdbus_runtime_version)
2714 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2715 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2716 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2717 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2718 Adapt docstring.
dcbf5805 2719
52828e02
PE
27202012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2721
da05bc4c
PE
2722 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2723 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2724 Do not assume ptrdiff_t is the same width as 'int'.
2725
52828e02
PE
2726 * alloc.c: Handle unusual debugging option combinations.
2727 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2728 since the two debugging options are incompatible.
2729 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2730 is defined.
2731 (mem_init, mem_insert, mem_insert_fixup):
2732 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2733 (NEED_MEM_INSERT): Remove; no longer needed.
2734
f01769f9
LL
27352012-04-22 Leo Liu <sdl.web@gmail.com>
2736
2737 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2738
5790543d
PE
27392012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * sysdep.c [__FreeBSD__]: Minor cleanups.
2742 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2743 Use Emacs indenting style more consistently. Avoid some casts.
2744 Use 'double' consistently rather than mixing 'float' and 'double'.
2745
b91b7e4d
EW
27462012-04-21 Eduard Wiebe <usenet@pusto.de>
2747
b593d6a9
AH
2748 * sysdep.c (list_system_processes, system_process_attributes):
2749 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2750
6114eb15
AS
27512012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2752
2753 * lisp.mk (lisp): Update.
2754
2f38dff7
PE
27552012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2758 It is never used otherwise.
2759
4ae29f89
SM
27602012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2761
2762 * print.c (print_preprocess): Only check print_depth if print-circle
2763 is nil.
2764 (print_object): Check for cycles even when print-circle is nil and
2765 print-gensym is t, but only check print_depth if print-circle is nil.
2766
f30d612a
CY
27672012-04-20 Chong Yidong <cyd@gnu.org>
2768
2769 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2770 set the status to "failed" and ensure that sentinel is run.
2771
c07a4c0b 27722012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2773
2774 * process.c (Fset_process_inherit_coding_system_flag)
2775 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2776 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2777
c07a4c0b 27782012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2779
2780 * xdisp.c (string_buffer_position_lim): Limit starting position to
2781 BEGV.
2782 (set_cursor_from_row): If called for a mode-line or header-line
2783 row, return zero immediately.
2784 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2785 farther than the first row after the header line, if any.
2786 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2787 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2788
c07a4c0b 27892012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2790
4ae29f89
SM
2791 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2792 (bug#11238).
ad3a2b41 2793
c07a4c0b 27942012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 27952012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2796
2797 configure: new option --enable-gcc-warnings (Bug#11207)
2798 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2799 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2800 (ALL_CFLAGS): Use new macros rather than old.
2801 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2802 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2803 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2804 -Wunused-result, -Wunused-variable. This should go away once
2805 the Emacs and Gnulib regex code is merged.
2806 (xmalloc, xrealloc): Now static.
2807
aba027e8
PE
28082012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 * dired.c (Fsystem_groups): Remove unused local.
2811
e5a36063
GM
28122012-04-17 Glenn Morris <rgm@gnu.org>
2813
2814 * dired.c (Fsystem_users): Doc fix.
2815
316411f0
DA
28162012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2817
2818 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2819 (syms_of_dired): Add them.
2820
9426aba4
PE
28212012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2822
b62a57be
PE
2823 Fix minor alloc.c problems found by static checking.
2824 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2825 New extern decls, to avoid calling undeclared functions.
2826 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2827 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2828 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2829 (NEED_MEM_INSERT): New macro.
2830 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2831 Remove one incorrect comment and fix another.
b62a57be 2832
3539f31f
PE
2833 Fix minor ralloc.c problems found by static checking.
2834 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2835 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2836 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2837 (r_alloc_sbrk): Now static.
2838
a041960a
PE
2839 Improve ralloc.c interface checking.
2840 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2841 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2842 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2843 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2844 [REL_ALLOC]: ... to here, to check interface.
2845 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2846 Remove decls. This fixes an "It stinks!".
2847
9426aba4
PE
2848 * alloc.c (which_symbols): Fix alignment issue / type clash.
2849
d55c12ed
AS
28502012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2851
2852 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2853 (struct Lisp_Misc_Any): Likewise.
2854 (struct Lisp_Free): Likewise.
2855 * alloc.c (union aligned_Lisp_Symbol): Define.
2856 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2857 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2858 (union aligned_Lisp_Misc): Define.
2859 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2860 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2861 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2862
b948ce8b
PE
28632012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2864
2865 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2866 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2867 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2868 * s/netbsd.h, s/sol2-6.h:
2869 Remove definition of GC_MARK_STACK, since the default now works.
2870 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2871 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2872 no longer the default.
2873 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2874
35dc09a1 28752012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2876
35dc09a1
GM
2877 * lread.c (lisp_file_lexically_bound_p):
2878 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2879
35dc09a1
GM
28802012-04-14 Eli Zaretskii <eliz@gnu.org>
2881
2882 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2883 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2884
28852012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2886
2887 * nsterm.m (constrainFrameRect): Always constrain when there is only
2888 one screen (Bug#10962).
2889
bcd86815
KB
28902012-04-13 Ken Brown <kbrown@cornell.edu>
2891
2892 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2893
c25df26e
RT
28942012-04-13 Reuben Thomas <rrt@sc3d.org>
2895
2896 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2897
0fc59f1e
DC
28982012-04-11 Daniel Colascione <dancol@dancol.org>
2899
2900 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2901 against is gone. It's better to use vfork now so that when Cygwin
2902 gains a new, working vfork, we use it automatically (bug#10398).
2903
de8c03dc
SM
29042012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2905
2906 * window.c (save_window_save): Obey window-point-insertion-type.
2907
2f097256
GM
29082012-04-11 Glenn Morris <rgm@gnu.org>
2909
2910 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2911
453b951e
SM
29122012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2913
2914 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2915
75f1671a 29162012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2917
2918 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2919 (force_quit_count): New var.
2920 (handle_interrupt): Use it.
2921
2a8ce227
JB
29222012-04-10 Juanma Barranquero <lekktu@gmail.com>
2923
2924 * w32.c (w32_delayed_load): Record the full path of the library
2925 being loaded (bug#10424).
2926
935396c0
GM
29272012-04-09 Glenn Morris <rgm@gnu.org>
2928
05920a43
GM
2929 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2930 not just in the obarray, before snarfing them. (Bug#11036)
2931
935396c0
GM
2932 * Makefile.in ($(leimdir)/leim-list.el):
2933 Pass EMACS rather than BUILT_EMACS.
2934
a18ecafa
TZ
29352012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2936
2937 * process.c (make_process):
2938 * process.h: Add integer `gnutls_handshakes_tried' member to
2939 process struct.
2940
6bbef4e5
JC
2941 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2942 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2943
2944 * gnutls.c (gnutls_log_function2i): Convenience log function.
2945 (emacs_gnutls_read): Use new log functions,
2946 `gnutls_handshakes_tried' process member, and
2947 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2948 attempts per process (connection).
2949
b4d3bc10
CY
29502012-04-09 Chong Yidong <cyd@gnu.org>
2951
2952 * eval.c (Fuser_variable_p, user_variable_p_eh)
2953 (lisp_indirect_variable): Functions deleted.
2954 (Fdefvar): Caller changed.
2955
2956 * callint.c (Finteractive, Fcall_interactively):
2957 * minibuf.c (Fread_variable): Callers changed.
2958
70f4d973
EZ
29592012-04-09 Eli Zaretskii <eliz@gnu.org>
2960
2961 * xdisp.c (set_cursor_from_row): If the display string appears in
2962 the buffer at position that is closer to point than the position
2963 after the display string, display the cursor on the first glyph of
2964 the display string. Fixes cursor display when a 'display' text
2965 property immediately follows invisible text. (Bug#11094)
2966
cb3c2e3e
PE
29672012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2968
2969 composite.c: use 'double' consistently
2970 * composite.c (get_composition_id): Use 'double' consistently
2971 instead of converting 'float' to 'double' and vice versa; this is
2972 easier to understand and avoids a GCC warning.
2973
fd06db5d
GM
29742012-04-09 Glenn Morris <rgm@gnu.org>
2975
50fe702a
GM
2976 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2977 preparation for dumping it with emacs. (Bug#4789)
2978 (leimdir): New variable.
2979 ($(leimdir)/leim-list.el): New rule.
2980 (emacs$(EXEEXT)): Depend on leim-list.el.
2981
fd06db5d
GM
2982 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2983 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2984 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2985
55c131ee
AS
29862012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2987
2988 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2989 proper alignment.
2990
9209588f
JB
29912012-04-07 Juanma Barranquero <lekktu@gmail.com>
2992
2993 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2994 Remove unused local variable.
2995
e3fb2efb
PE
29962012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2997
2998 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2999 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3000 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3001 objects, as mark_maybe_pointer will catch them otherwise.
3002 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3003 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3004
b5385551
PE
30052012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 Fix typo that broke non-Windows builds.
3008 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3009
9078ead6
EZ
30102012-04-07 Eli Zaretskii <eliz@gnu.org>
3011
3012 Support building on MS-Windows with libxml2.
3013
3014 * makefile.w32-in (OBJ2): Add xml.$(O).
3015 (GLOBAL_SOURCES): Add xml.c.
3016 ($(BLD)/xml.$(O)): New dependency list.
3017
3018 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3019 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3020 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3021 [!WINDOWSNT]: New macros.
3022 (init_libxml2_functions, libxml2_loaded_p): New functions.
3023 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3024 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3025 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3026 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3027 linked in).
6bbef4e5
JC
3028 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3029 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3030 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3031
3032 * emacs.c: Don't include libxml/parser.h.
3033 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3034 xmlCleanupParser directly.
3035
3036 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3037
3811fdf3
EZ
30382012-04-07 Eli Zaretskii <eliz@gnu.org>
3039
3040 * indent.c (Fvertical_motion): If there is a display string at
3041 point, use it.vpos to compute how many lines to backtrack after
3042 move_it_to point. (Bug#11133)
3043
2f8e16b2
EZ
30442012-04-06 Eli Zaretskii <eliz@gnu.org>
3045
3046 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3047 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3048 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3049 macros related to unification of CJK characters. For the details,
3050 see the discussion following the message here:
3051 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3052
3d439cd1
CY
30532012-04-04 Chong Yidong <cyd@gnu.org>
3054
3055 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3056
8bc53d00
EZ
30572012-04-01 Eli Zaretskii <eliz@gnu.org>
3058
3059 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3060 instead of alloca. (Bug#11138)
3061
3b0512a3
AS
30622012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3063
3064 * w32menu.c (is_simple_dialog): Properly check lisp types.
3065 (Bug#11141)
3066
8427ddd2
EZ
30672012-03-31 Eli Zaretskii <eliz@gnu.org>
3068
979022ef
EZ
3069 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3070 position we get to after a call to move_it_to fails the
3071 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3072 only if we wind up in a string from display property. (Bug#11063)
3073
a6b1c7cc
EZ
3074 * window.c (Fdelete_other_windows_internal): Invalidate the row
3075 and column information about mouse highlight, so that redisplay
3076 restores it after reallocating the glyph matrices. (Bug#7464)
3077
8427ddd2
EZ
3078 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3079 string comes from a `display' text property, use the buffer
3080 position of that property as if we actually saw that position in
3081 the row's glyphs.
697ba24b
EZ
3082 (move_it_by_lines): Remove the assertion that
3083 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3084 violated when there's a before-string at the beginning of a line.
3085 (Bug#11063)
8427ddd2 3086
65a0a738
EZ
30872012-03-30 Eli Zaretskii <eliz@gnu.org>
3088
3089 * xdisp.c (append_space_for_newline): If the default face was
3090 remapped, use the remapped face for the appended newline.
3091 (extend_face_to_end_of_line): Use the remapped default face for
3092 extending the face to the end of the line.
3093 (display_line): Call extend_face_to_end_of_line when the default
3094 face was remapped. (Bug#11068)
3095
581355cc
EZ
30962012-03-29 Eli Zaretskii <eliz@gnu.org>
3097
3098 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3099
e8fc049f
SM
31002012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3101
3102 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3103
4fb9a543
GM
31042012-03-27 Glenn Morris <rgm@gnu.org>
3105
3106 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3107 Doc fixes.
3108
679910f1
KH
31092012-03-26 Kenichi Handa <handa@m17n.org>
3110
3111 * dispextern.h (struct glyph): Fix previous change. Change the
3112 bit length of glyphless.ch to 25 (Bug#11082).
3113
90d49b7f
CY
31142012-03-26 Chong Yidong <cyd@gnu.org>
3115
3116 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3117 (command_loop_1): Use it; inhibit selection update for
3118 handle-select-window too (Bug#8996).
3119
f514f6f0
FP
31202012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3121
e8fc049f 3122 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3123
bf43fa51
KH
31242012-03-25 Kenichi Handa <handa@m17n.org>
3125
3126 * dispextern.h (struct glyph): Change the bit length of
3127 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3128
8a0c01dd
EZ
31292012-03-24 Eli Zaretskii <eliz@gnu.org>
3130
3131 * s/ms-w32.h (tzname): Include time.h before redirecting to
3132 _tzname. Fixes the MSVC build. (Bug#9960)
3133
7d1c3a76
AS
31342012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3135
8ed79523
AS
3136 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3137 characters.
3138
7d1c3a76
AS
3139 * xterm.c (XTread_socket): Only modify handling_signal if
3140 !SYNC_INPUT. (Bug#11080)
3141
e99a9b8b
EZ
31422012-03-23 Eli Zaretskii <eliz@gnu.org>
3143
3144 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3145 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3146 when fetching a multibyte character consumes more bytes than
3147 CHAR_BYTES returns, due to unification of CJK characters in
3148 string_char. (Bug#11073)
3149
5063c0e1
TN
31502012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3151
3152 * process.c (wait_reading_process_output): Handle pty disconnect
3153 by refraining from sending oneself a SIGCHLD (bug#10933).
3154
9f851fbd
CY
31552012-03-22 Chong Yidong <cyd@gnu.org>
3156
3157 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3158
5063c0e1 3159 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3160 Mark string as coming from a prefix property.
3161 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3162 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3163
fb5b8aca
CY
31642012-03-21 Chong Yidong <cyd@gnu.org>
3165
3166 * xfaces.c (Vface_remapping_alist): Doc fix.
3167
62356a1b
EZ
31682012-03-20 Eli Zaretskii <eliz@gnu.org>
3169
3170 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3171 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3172 Doc fixes.
62356a1b 3173
025de85b
CY
31742012-03-20 Chong Yidong <cyd@gnu.org>
3175
3176 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3177 to reflect default non-nil value of redisplay-dont-pause.
3178
4827f94e
KH
31792012-03-19 Kenichi Handa <handa@m17n.org>
3180
3181 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3182 it fit in a valid range (Bug#11003).
3183
e50a24a2
EZ
31842012-03-18 Eli Zaretskii <eliz@gnu.org>
3185
3186 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3187 that is not from display property, accept the row as a "cursor
3188 row" if one of the string's character has a non-nil `cursor'
3189 property. Fixes cursor positioning when there are newlines in
3190 overlay strings, e.g. in icomplete.el. (Bug#11035)
3191
9af5ed87
PE
31922012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3195
d1f55f16
CY
31962012-03-12 Chong Yidong <cyd@gnu.org>
3197
3198 * eval.c (inhibit_lisp_code): Rename from
3199 inhibit_window_configuration_change_hook; move from window.c.
3200
3201 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3202 * window.c (run_window_configuration_change_hook)
3203 (syms_of_window): Callers changed.
3204
66c5eebd
CY
32052012-03-11 Chong Yidong <cyd@gnu.org>
3206
413df973
CY
3207 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3208
66c5eebd
CY
3209 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3210
1de11f56
CY
32112012-03-10 Chong Yidong <cyd@gnu.org>
3212
3213 * frame.c (other_visible_frames): Don't assume the selected frame
3214 is visible (Bug#10955).
3215
cae07000
SM
32162012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3217
3218 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3219
89c94350
JD
32202012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3221
3222 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3223 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3224 zero (Bug#10954).
3225
999dd333
GM
32262012-03-03 Glenn Morris <rgm@gnu.org>
3227
01a6dcc8 3228 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3229
de0100f2
EZ
32302012-03-02 Eli Zaretskii <eliz@gnu.org>
3231
3232 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3233 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3234 (redisplay_window, next_element_from_string): Fix typos in
3235 comments.
3e441275
EZ
3236 (redisplay_window): Pass to move_it_vertically the margin in
3237 pixels, not in screen lines.
de0100f2 3238
96a72ee9
GM
32392012-03-02 Glenn Morris <rgm@gnu.org>
3240
3241 * buffer.c (buffer-list-update-hook): Doc fix.
3242
312508d7
EZ
32432012-02-29 Eli Zaretskii <eliz@gnu.org>
3244
3245 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3246 push_it before setting up the iterator for the first overlay
3247 string, even if we have an empty string loaded.
3248 (next_overlay_string): If there's an empty string on the iterator
3249 stack, pop the stack. (Bug#10903)
3250
27f3c637
PE
32512012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3254 Suggested by Stefan Monnier in
3255 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3256 * alloc.c (widen_to_Lisp_Object): New static function.
3257 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3258 and widening them to Lisp_Objects. This would work even if
3259 USE_LSB_TAG is defined and wide integers are used, which might
3260 happen in a future version of Emacs.
3261
3c9dfce6
CY
32622012-02-25 Chong Yidong <cyd@gnu.org>
3263
fa74b241
CY
3264 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3265 Doc fix.
3266
3c9dfce6
CY
3267 * xselect.c (Fx_selection_exists_p): Doc fix.
3268 (x_clipboard_manager_save_all): Print an informative message
3269 before saving to clipboard manager.
3270
9486df08
CY
32712012-02-24 Chong Yidong <cyd@gnu.org>
3272
3273 * keyboard.c (process_special_events): Handle all X selection
3274 requests in kbd_buffer, not just the next one (Bug#8869).
3275
f01d3321
CY
32762012-02-23 Chong Yidong <cyd@gnu.org>
3277
3278 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3279 call when setting menu-bar-lines and tool-bar-lines parameters.
3280 (unwind_create_frame_1): New helper function.
3281
3282 * window.c (inhibit_window_configuration_change_hook): New var.
3283 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3284 (syms_of_window): Initialize it.
f01d3321 3285
86b847b6
CY
32862012-02-22 Chong Yidong <cyd@gnu.org>
3287
3288 * xterm.c (x_draw_image_relief): Add missing type check for
3289 Vtool_bar_button_margin (Bug#10743).
3290
a59225b1
CY
32912012-02-21 Chong Yidong <cyd@gnu.org>
3292
3293 * fileio.c (Vfile_name_handler_alist): Doc fix.
3294
3295 * buffer.c (Fget_file_buffer): Protect against invalid file
3296 handler return value.
3297
310f5bd4
PE
32982012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3299
cb3a28cc
PE
3300 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3301 when computing $valmask.
3302
310f5bd4
PE
3303 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3304 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3305 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3306 It's useless in that case, and it can cause problems on hosts
3307 that allocate halves of EMACS_INT values separately.
3308 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3309 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3310 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3311 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3312 it avoids undefined behavior on hosts where shifting right by more
3313 than the word width has undefined behavior.
3314
2375c96a
CY
33152012-02-19 Chong Yidong <cyd@gnu.org>
3316
3317 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3318 (Funhandled_file_name_directory, Ffile_name_as_directory)
3319 (Fdirectory_file_name, Fexpand_file_name)
3320 (Fsubstitute_in_file_name): Protect against invalid file handler
3321 return values (Bug#10845).
3322
3eb49e71
EZ
33232012-02-18 Eli Zaretskii <eliz@gnu.org>
3324
3325 * .gdbinit (pitx): Fix incorrect references to fields of the
3326 iterator stack.
3327
7b926f3f
CY
33282012-02-17 Chong Yidong <cyd@gnu.org>
3329
3330 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3331
11273115
PE
33322012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3333
3334 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3335 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3336
c3a70e2b
CY
33372012-02-15 Chong Yidong <cyd@gnu.org>
3338
3339 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3340 marked as special. Also, starting docstrings with * is obsolete.
3341
0ca43699
AS
33422012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3343
3344 * gnutls.c (emacs_gnutls_write): Fix last change.
3345
2e8f3c56
LI
33462012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3347
3348 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3349 send_process.
3350
af70074f
SM
33512012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3352
3353 * keymap.c (Fsingle_key_description): Handle char ranges.
3354
95986d52
CY
33552012-02-12 Chong Yidong <cyd@gnu.org>
3356
afd83bd1
CY
3357 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3358 as that creates a dangerous corner case.
3359
95986d52
CY
3360 * window.c (Fdelete_window_internal): Invalidate the mouse
3361 highlight (Bug#9904).
3362
bd7da63e
GM
33632012-02-12 Glenn Morris <rgm@gnu.org>
3364
3365 * xselect.c (Fx_own_selection_internal)
3366 (Fx_get_selection_internal, Fx_disown_selection_internal)
3367 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3368 * nsselect.m (Fx_own_selection_internal)
3369 (Fx_disown_selection_internal, Fx_selection_exists_p)
3370 (Fx_selection_owner_p, Fx_get_selection_internal):
3371 Sync docs and argument specs with the xselect.c versions.
3372
77abcbc2
LI
33732012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3374
3375 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3376
90b671e2
EZ
33772012-02-11 Eli Zaretskii <eliz@gnu.org>
3378
1c0ca0b7
EZ
3379 * w32select.c (Fx_selection_exists_p): Sync doc string and
3380 argument list with xselect.c. (Bug#10783)
3381
3382 * w16select.c (Fx_selection_exists_p): Sync doc string and
3383 argument list with xselect.c. (Bug#10783)
90b671e2 3384
49241268
GM
33852012-02-10 Glenn Morris <rgm@gnu.org>
3386
3387 * fns.c (Fsecure_hash): Doc fix.
3388
f998bbe7 33892012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3390
3391 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3392
0992bd9c
CY
33932012-02-07 Chong Yidong <cyd@gnu.org>
3394
3395 * buffer.c (Fbuffer_local_variables)
3396 (buffer_lisp_local_variables): Handle unbound vars correctly;
3397 don't let Qunbound leak into Lisp.
3398
af008560
GM
33992012-02-07 Glenn Morris <rgm@gnu.org>
3400
dd605cc4
GM
3401 * image.c (Fimagemagick_types): Doc fix.
3402
af008560
GM
3403 * image.c (imagemagick-render-type): Change it from a lisp object
3404 to an integer. Move the doc here from the lisp manual.
3405 Treat all values not equal to 0 the same.
3406
1449fa1d
CY
34072012-02-06 Chong Yidong <cyd@gnu.org>
3408
3409 * doc.c (store_function_docstring): Avoid applying docstring of
3410 alias to base function (Bug#2603).
3411
3723ec07
AS
34122012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3413
3414 * .gdbinit (pp1, pv1): Remove redundant defines.
3415 (pr): Use pp.
3416
79c1cc1e
CY
34172012-02-04 Chong Yidong <cyd@gnu.org>
3418
3419 * nsterm.m: Declare a global (Bug#10694).
3420
d7f29f8e
EZ
34212012-02-04 Eli Zaretskii <eliz@gnu.org>
3422
cae07000
SM
3423 * w32.c (get_emacs_configuration_options):
3424 Include --enable-checking, if specified, in the return value.
d7f29f8e 3425
3b95a6f9
MR
34262012-02-04 Martin Rudalics <rudalics@gmx.at>
3427
3428 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3429 after rounding frame sizes. (Bug#9723)
3430
d6fa96a6
EZ
34312012-02-04 Eli Zaretskii <eliz@gnu.org>
3432
3433 * keyboard.c (adjust_point_for_property): Don't position point
3434 before BEGV. (Bug#10696)
3435
df0b2940
PE
34362012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3437
3438 Handle overflow when computing char display width (Bug#9496).
3439 * character.c (char_width): Return EMACS_INT, not int.
3440 (char_width, c_string_width): Check for overflow when
3441 computing the width; this is possible now that individual
3442 characters can have unbounded width. Problem introduced
3443 by merge from Emacs 23 on 2012-01-19.
3444
6bee44d6
MA
34452012-02-02 Michael Albinus <michael.albinus@gmx.de>
3446
3447 * dbusbind.c (Fdbus_register_method): Mention the return value
3448 :ignore in the docstring.
3449
44f92739
GM
34502012-02-02 Glenn Morris <rgm@gnu.org>
3451
1b9f60cc
GM
3452 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3453
44f92739
GM
3454 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3455 Unconditionally set to t. (Bug#10673)
3456 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3457 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3458 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3459
c5d3843c
KH
34602012-02-02 Kenichi Handa <handa@m17n.org>
3461
3462 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3463 0, do not call append_composite_glyph.
3464
159462d4 34652012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3466
3467 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3468 NULL (Bug#6988).
3469 (x_produce_glyphs): If the component of a composition is a null
3470 string, set it->pixel_width to 1 to avoid zero-width glyph.
3471
78cef877
EZ
34722012-02-01 Eli Zaretskii <eliz@gnu.org>
3473
3474 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3475 first 2 arguments are identical. This makes inserting large
3476 output from a subprocess an order of magnitude faster on
3477 MS-Windows, where all sbrk'ed memory is always contiguous.
3478
97897668
GM
34792012-01-31 Glenn Morris <rgm@gnu.org>
3480
3481 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3482 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3483 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3484
31fd3586
GM
34852012-01-29 Glenn Morris <rgm@gnu.org>
3486
3487 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3488
0e24a8b2
CY
34892012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3490
3491 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3492
cc0adcb0
CY
34932012-01-28 Chong Yidong <cyd@gnu.org>
3494
3495 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3496
acc28cb9
CY
34972012-01-26 Chong Yidong <cyd@gnu.org>
3498
9c69cfb7
CY
3499 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3500
acc28cb9
CY
3501 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3502 repeat counts (Bug#10507).
3503
48da7392
GM
35042012-01-26 Glenn Morris <rgm@gnu.org>
3505
3506 * lread.c (syms_of_lread): Doc fix.
3507
14af5f7f
CY
35082012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3509
3510 * coding.c (encode_designation_at_bol): Change return value to
3511 EMACS_INT.
3512
0b21c100
CY
35132012-01-25 Chong Yidong <cyd@gnu.org>
3514
3515 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3516
3c2907f7
CY
35172012-01-21 Chong Yidong <cyd@gnu.org>
3518
3519 * floatfns.c (Fcopysign): Make the second argument non-optional,
3520 since nil is not allowed anyway.
3521
959ad23f
AS
35222012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3523
3524 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3525 (send_process): Likewise.
3526
34a02f46
MR
35272012-01-19 Martin Rudalics <rudalics@gmx.at>
3528
3529 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3530 (Vwindow_persistent_parameters): Do not use Qstate.
3531 Rewrite doc-strings.
34a02f46 3532
1259009a 35332012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3534
3535 * character.c (char_width): New function.
70d4fdf6
GM
3536 (Fchar_width, c_string_width, lisp_string_width):
3537 Use char_width (Bug#9496).
25ed9e61 3538
6a6ee00d
MR
35392012-01-16 Martin Rudalics <rudalics@gmx.at>
3540
3541 * window.c (Vwindow_persistent_parameters): New variable.
3542 (Fset_window_configuration, save_window_save): Handle persistent
3543 window parameters.
3544
c85efaf7
EZ
35452012-01-14 Eli Zaretskii <eliz@gnu.org>
3546
3547 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3548 thrashing the stack of the thread. (Bug#9087)
3549
5944709e
PE
35502012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3551
3552 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3553
e71f5d99
EZ
35542012-01-11 Eli Zaretskii <eliz@gnu.org>
3555
3556 * xdisp.c (rows_from_pos_range): Handle the case where the
3557 highlight ends on a newline. (Bug#10464)
3558 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3559 he end column for display of highlight that ends on a newline
3560 before a R2L line.
3561
ce316182
GM
35622012-01-11 Glenn Morris <rgm@gnu.org>
3563
3564 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3565 from load-path also when installation-directory is nil. (Bug#10208)
3566
5b43da69
GM
35672012-01-10 Glenn Morris <rgm@gnu.org>
3568
74cc8ff9
GM
3569 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3570
7d8d6e4e
GM
3571 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3572 Update template values to be closer to their typical values these days.
5b43da69 3573
a0db8d43
EZ
35742012-01-09 Eli Zaretskii <eliz@gnu.org>
3575
3576 * xdisp.c (rows_from_pos_range): Accept additional argument
3577 DISP_STRING, and accept any glyph in a row whose object is that
3578 string as eligible for mouse highlight. Fixes mouse highlight of
3579 display strings from overlays. (Bug#10464)
3580
9a0115ab 35812012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3582
b9110d6a 3583 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3584 * fileio.c (auto_saving_dir_umask): New static var.
3585 (Fmake_directory_internal): Use it.
3586 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3587 creating the directory. The old code temporarily assigns
3588 too-generous permissions to the directory.
3589 (do_auto_save_eh): Clear it.
b9110d6a 3590 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3591 that the var is always cleared.
3592
6c1bd3f3
EZ
35932012-01-07 Eli Zaretskii <eliz@gnu.org>
3594
3595 * search.c (scan_buffer): Pass character positions to
3596 know_region_cache, not byte positions. (Bug#6540)
3597
069d2b50
L
35982012-01-07 LynX <_LynX@bk.ru> (tiny change)
3599
3600 * w32.c (sys_rename): Report EXDEV when rename of a directory
3601 fails because the target is on another logical disk. (Bug#10284)
3602
75bf0d33
DB
36032012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3604
3605 * xterm.c (x_embed_request_focus): New function.
3606
3607 * xterm.h: Add prototype.
3608
3609 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3610
1c6e5a32
GM
36112012-01-05 Glenn Morris <rgm@gnu.org>
3612
3613 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3614
651e947e
EZ
36152012-01-01 Eli Zaretskii <eliz@gnu.org>
3616
3617 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3618 Load gnutls_transport_set_lowat only if GnuTLS version is below
3619 2.11.1.
3620 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3621 GnuTLS versions below 2.11.1.
3622
3778cdd8
AL
36232011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3624
3625 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3626 to the doc string advising against its use for altering the way
3627 windows are scrolled.
3628
0e5317f7
KH
36292011-12-28 Kenichi Handa <handa@m17n.org>
3630
3631 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3632 coding-system ASCII compatible only when it does not produce BOM
3633 on encoding (Bug#10383).
3634
93d5ca1f
JD
36352011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3636
3637 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3638 can scroll.
3639 (create_and_show_popup_menu): Always use menu_position_func for
3640 Gtk3 (Bug#10361).
3641
ca22b785
AS
36422011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3643
3644 * callint.c (Fcall_interactively): Don't truncate prompt string.
3645
d048e1e6
EZ
36462011-12-23 Eli Zaretskii <eliz@gnu.org>
3647
3648 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3649 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3650 resumed from there (after widening). (Bug#10360)
d048e1e6 3651
5ccaba1f
JD
36522011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3653
3654 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3655
204ee57f
JD
36562011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3657
b81d40f0
JB
3658 * nsterm.m (x_free_frame_resources):
3659 Release f->output_data.ns->miniimage.
204ee57f
JD
3660 (ns_index_color): Fix indentation. Do not retain
3661 color_table->colors[i].
3662
3663 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3664 before returning.
3665
3666 * nsfns.m (x_set_background_color): Assign return value from
3667 ns_index_color to face-background instead of NSColor*.
3668 (ns_implicitly_set_icon_type): Fix indentation.
3669 Change assignment in for loop to comparison.
3670
3671 * emacs.c (ns_pool): New variable.
3672 (main): Assign ns_pool.
3673 (Fkill_emacs): Call ns_release_autorelease_pool.
3674
3675 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3676 autorelease fdesc, release fdAttrs and tdict.
3677 (ns_get_covering_families): Release charset.
3678 (ns_findfonts): Release NSFontDescriptor created with new.
3679 (ns_uni_to_glyphs): Fix indentation.
3680 (setString): Release attrStr before assigning new value.
3681
c803b2b7
JD
36822011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3683
678f4426
JD
3684 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3685 and NS_IMPL_COCOA.
3686 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3687 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3688
cd394be1 36892011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3690
5fecd5fc
JD
3691 * nsterm.m (ns_term_init): Subscribe for notifications
3692 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3693 to method trackingNotification in EmacsMenu.
3694
3695 * nsmenu.m (trackingMenu): New variable.
3771cb17 3696 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3697 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3698 from Aquamacs (Bug#7030).
678f4426
JD
3699
37002011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3701
c803b2b7
JD
3702 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3703 (symbol_to_nsstring): Fix indentation.
3704 (ns_symbol_to_pb): New function.
cae07000
SM
3705 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3706 (Fns_rotate_cut_buffers_internal): Remove.
3707 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3708 Fns_store_cut_buffer_internal.
3709 (ns_get_foreign_selection, Fx_own_selection_internal)
3710 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3711 (Fns_get_selection_internal, Fns_store_selection_internal):
3712 Use ns_symbol_to_pb and check if return value is nil.
3713 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3714 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3715 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3716 renamed to Sns_store_selection_internal.
3717 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3718 and remove this function.
3719 (ns_handle_selection_clear): Remove, never used.
3720 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3721 here.
3722
e1b01a3a
KB
37232011-12-17 Ken Brown <kbrown@cornell.edu>
3724
3725 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3726 GID is unknown (Bug#10257).
3727
2adb6e85
PE
37282011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3731 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3732 which caused a build failure on GNU/Linux IA-64. This problem was
3733 introduced by my 2011-10-07 patch.
3734
d1d7b339
JL
37352011-12-15 Juri Linkov <juri@jurta.org>
3736
3737 * image.c (imagemagick_error): New function. (Bug#10112)
3738 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3739 Use `imagemagick_error' where ImageMagick functions return
3740 `MagickFalse'.
3741 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3742 proper order.
3743
100d5755
KH
37442011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3745
3746 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3747 fill background (Bug#8992).
3748
454592a6
MR
37492011-12-13 Martin Rudalics <rudalics@gmx.at>
3750
3751 * window.c (Vwindow_combination_resize)
3752 (Vwindow_combination_limit): Use t instead of non-nil in
3753 doc-strings.
61d4b438
MR
3754 (Vrecenter_redisplay): Add first sentence of doc-string on
3755 separate line.
53524d93 3756 (Frecenter): Fix doc-string typo.
454592a6 3757
3633e3aa
KH
37582011-12-11 Kenichi Handa <handa@m17n.org>
3759
3760 * coding.c (Funencodable_char_position): Pay attention to the
3761 buffer text relocation (Bug#9389).
3762
7b9d523a 37632011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3764
7b9d523a
JD
3765 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3766 gtk_init (Bug#10100).
3767
b73189c6
EZ
37682011-12-10 Eli Zaretskii <eliz@gnu.org>
3769
3770 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3771 IT->string is nil. (Bug#10263)
3772
f7dfe5d6
JD
37732011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3774
83faebb4
JD
3775 * nsterm.h (x_free_frame_resources): Declare.
3776
f7dfe5d6
JD
3777 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3778 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3779
3780 * nsterm.h (ns_get_defaults_value): Declare.
3781
3782 * nsterm.m (ns_default): Call ns_get_defaults_value.
3783
7cd4e72c
EZ
37842011-12-09 Eli Zaretskii <eliz@gnu.org>
3785
3786 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3787 (Bug#10170)
3788
b34d7317
YM
37892011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3790
3791 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3792 that where the value of an _OBJC_* symbol points to is in the .bss
3793 section (Bug#10240).
3794
76470ad1
KH
37952011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3796
3797 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3798 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3799
745fff94
KH
38002011-12-08 Kenichi Handa <handa@m17n.org>
3801
3802 * ftfont.c (get_adstyle_property): Fix previous change
3803 (Bug#10233).
3804
6e44397c
JB
38052011-12-07 Juanma Barranquero <lekktu@gmail.com>
3806
3807 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3808 dirs from the default value of EMACSLOADPATH (bug#10208).
3809
7efa6272
GM
38102011-12-07 Glenn Morris <rgm@gnu.org>
3811
3812 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3813 installation and source directories as well. (Bug#10208)
3814
f6fc4d87
CY
38152011-12-06 Chong Yidong <cyd@gnu.org>
3816
3817 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3818
2bf26180
GM
38192011-12-06 Glenn Morris <rgm@gnu.org>
3820
3821 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3822 as an error, not just -1. (Bug#10217)
3823
3a6ad4f0
CY
38242011-12-05 Chong Yidong <cyd@gnu.org>
3825
3826 * keyboard.c (process_special_events): New function.
3827 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3828
75a3b399
PE
38292011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3830
3831 * coding.c (encode_designation_at_bol): Don't use uninitialized
3832 local variable (Bug#9318).
3833
c3c9e25e
KH
38342011-12-05 Kenichi Handa <handa@m17n.org>
3835
3836 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3837 return Qnil (Bug#8046, Bug#10193).
3838
5eb05ea3
KH
38392011-12-05 Kenichi Handa <handa@m17n.org>
3840
3841 * coding.c (encode_designation_at_bol): New args charbuf_end and
3842 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3843 (coding_set_source): Return how many bytes coding->source was
3844 relocated.
3845 (coding_set_destination): Return how many bytes
3846 coding->destination was relocated.
3847 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3848 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3849
38502011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3851
3852 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3853 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3854 macro (Bug#9318).
3855
38562011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3857
3858 The following changes are to fix Bug#9318.
3859
a79703f5 3860 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3861 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3862 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3863 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3864
7dbda6df
JB
38652011-12-05 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * lisp.h (process_quit_flag): Fix external declaration.
3868
6d5eb5b0
SM
38692011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3870
3871 Don't macro-inline non-performance-critical code.
3872 * eval.c (process_quit_flag): New function.
3873 * lisp.h (QUIT): Use it.
3874
a0c3fad0
JD
38752011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3876
3877 * nsfns.m (get_geometry_from_preferences): New function.
3878 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3879
6c07aac2
AS
38802011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3881
3882 * emacs.c (Qkill_emacs): Define.
3883 (syms_of_emacs): Initialize it.
3884 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3885 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3886 (quit_throw_to_read_char): Add parameter `from_signal'.
3887 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3888 * lisp.h (QUIT): Call Fkill_emacs if requested.
3889
c052ead4
JD
38902011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3891
3892 * widget.c (update_wm_hints): Return if wmshell is null.
3893 (widget_update_wm_size_hints): New function.
3894
3895 * widget.h (widget_update_wm_size_hints): Declare.
3896
3897 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3898 widget_update_wm_size_hints (Bug#10104).
3899
9e49252b
EZ
39002011-12-03 Eli Zaretskii <eliz@gnu.org>
3901
3902 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3903 before a newline, prepare the bidi iterator for consuming the
3904 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3905 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3906
02b16839
JL
39072011-12-02 Juri Linkov <juri@jurta.org>
3908
3909 * search.c (Fword_search_regexp): New Lisp function created from
3910 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3911 (Fword_search_backward, Fword_search_forward)
3912 (Fword_search_backward_lax, Fword_search_forward_lax):
3913 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3914 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3915
0068070e
SM
39162011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3917
3918 * fileio.c (Finsert_file_contents): Move after-change-function call
3919 to before the "handled:" label, since all "goto handled" appear in
3920 cases where the *-change-functions have already been properly called
3921 (bug#10117).
3922
3360a3fc
AS
39232011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3924
3925 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3926 waiting for input. (Bug#10169)
3927
73d6c093
EZ
39282011-11-30 Eli Zaretskii <eliz@gnu.org>
3929
3930 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3931 verifies glyph row's hash code--we have just reallocated the
3932 glyphs, so their contents can be complete garbage. (Bug#10164)
3933
febe6bea
JB
39342011-11-30 Juanma Barranquero <lekktu@gmail.com>
3935
3936 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3937
801a4313
EZ
39382011-11-30 Eli Zaretskii <eliz@gnu.org>
3939
3940 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3941 attributes are tested _before_ calling verify_row_hash, to protect
3942 against GCC re-ordering of the tests. (Bug#10164)
3943
2b56b87e
JD
39442011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3945
3946 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3947
3948 * xterm.c (handle_one_xevent): Only set async_visible and friends
3949 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3950 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3951 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3952
dbf31225
PE
39532011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3956 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3957 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3958 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3959 All uses changed to use GCPRO1 etc.
3960 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3961 Revert to old implementation (i.e., before 2011-03-11).
3962
1305621b
YM
39632011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3964
3965 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3966 of scroll runs so as to avoid assigning disabled bogus rows and
3967 unnecessary graphics copy operations.
3968
8c9afb46
EZ
39692011-11-27 Eli Zaretskii <eliz@gnu.org>
3970
3971 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3972 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3973 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3974 (malloc, free, realloc, calloc): Redirect to e_* only when
3975 compiling Emacs.
3976
3977 * lisp.h (GCTYPEBITS): Move before first use.
3978 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3979 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3980 this macro definition.
3981
3982 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3983 _MSC_VER.
3984
54e9e3bf
JD
39852011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3986
6d5eb5b0
SM
3987 * gtkutil.c (xg_create_frame_widgets):
3988 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3989 present with Gtk+ 2.0.
3990
83aca1cb
PE
39912011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3992
3993 * fileio.c (Finsert_file_contents): Undo previous change; see
3994 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3995
5b76caa4
PE
39962011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 Rename locals to avoid shadowing.
3999 * fileio.c (Finsert_file_contents):
4000 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4001 * process.c (wait_reading_process_output):
4002 Rename inner 'proc' to 'p' to avoid shadowing.
4003 Indent for consistency with usual Emacs style.
4004
8c535114
EZ
40052011-11-25 Eli Zaretskii <eliz@gnu.org>
4006
4007 * xdisp.c (redisplay_window): If cursor row is not fully visible
4008 after recentering, and scroll-conservatively is set to a large
4009 number, scroll window by a few more lines to make the cursor fully
4010 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4011 (start_display): Don't move to the next line if the display should
4012 start at a newline that is part of a display vector or an overlay
4013 string. (Bug#10119)
8c535114 4014
fa4fdb5c
JL
40152011-11-24 Juri Linkov <juri@jurta.org>
4016
4017 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4018 after the `MagickPingImage' call. (Bug#10112)
4019
90ec88df
CY
40202011-11-23 Chong Yidong <cyd@gnu.org>
4021
4022 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4023
56e2e794
MR
40242011-11-23 Martin Rudalics <rudalics@gmx.at>
4025
4026 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4027 making another buffer current. (Bug#10114)
4028
b6e64c41
GM
40292011-11-23 Glenn Morris <rgm@gnu.org>
4030
4031 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4032
6b21de18
CY
40332011-11-23 Chong Yidong <cyd@gnu.org>
4034
4035 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4036 using it (Bug#5984).
4037
b12cd789
EZ
40382011-11-22 Eli Zaretskii <eliz@gnu.org>
4039
4040 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4041 and header-lines, as they don't have one computed for them.
4042 (Bug#10098)
4043
4044 * .gdbinit (prow): Make displayed values more self-explaining.
4045 Add row's hash code.
4046
261b6fd4
LMI
40472011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4048
4049 * process.c (wait_reading_process_output): Fix asynchrounous
4050 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4051 (wait_reading_process_output): Add comment and URL.
261b6fd4 4052
e7cfd277
JD
40532011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4054
4055 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4056
a9b9b7f5
CY
40572011-11-21 Chong Yidong <cyd@gnu.org>
4058
4059 * window.c (Fnext_window, Fprevious_window): Doc fix.
4060
b0d15b4f
SM
40612011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4062
4063 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4064
fe7a3057
JB
40652011-11-20 Juanma Barranquero <lekktu@gmail.com>
4066
4067 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4068
d2999b1a
MR
40692011-11-20 Martin Rudalics <rudalics@gmx.at>
4070
4071 * window.c (Fset_window_combination_limit): Rename argument
4072 STATUS to LIMIT.
4073 (Vwindow_combination_limit): Remove "status" from doc-string.
4074
d5ff9cd0
AS
40752011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4076
4077 * m/ibms390.h: Remove.
4078 * m/ibms390x.h: Don't include "ibms390.h".
4079
a5bb9bd3
SM
40802011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4081
4082 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4083 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4084
cd1181db
JB
40852011-11-20 Juanma Barranquero <lekktu@gmail.com>
4086
4087 * casetab.c (Fset_case_table):
4088 * charset.c (Fcharset_after): Fix typos.
4089
615a3b8d 40902011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4091
17e845af
PE
4092 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4093 Otherwise, valgrind does not work on some platforms.
4094 Problem reported by Andreas Schwab in
6a0bf43d
PE
4095 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4096 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4097 is set, removing the need for VIRT_ADDRESS_VARIES.
4098 (PURE_P): Use a more-efficient implementation that needs just one
4099 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4100 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4101 to 4 (xorl, subq, cmpq, setbe).
4102 * alloc.c (pure): Always extern now, since that's the
4103 VIRT_ADDR_VARIES behavior.
4104 (PURE_POINTER_P): Use a single comparison, not two, for
4105 consistency with the new puresize.h.
4106 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4107 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4108 Remove VIRT_ADDR_VARIES no longer needed.
4109
f8fe6f96
EZ
41102011-11-19 Eli Zaretskii <eliz@gnu.org>
4111
4112 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4113 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4114 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4115 behave as if the cursor position were at the window margin.
4116
4117 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4118 and the cursor position is out of bounds, behave as if the cursor
4119 position were at the window margin. (Bug#10075)
4120
df05a53c
CY
41212011-11-18 Chong Yidong <cyd@gnu.org>
4122
4123 * window.c (Fwindow_combination_limit): Make first argument
4124 non-optional, since it is meaningless for live windows like the
4125 selected window.
61ccba97 4126
2071918e
DA
41272011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4128
4129 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4130
b50a28de
SM
41312011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4132
4133 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4134 (graft_intervals_into_buffer): Simplify.
4135
015137db
EZ
41362011-11-18 Eli Zaretskii <eliz@gnu.org>
4137
4138 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4139 hash values of the two rows.
4140 (copy_row_except_pointers): Preserve the used[] arrays and the
4141 hash values of the two rows. (Bug#10035)
68c95424 4142 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4143
4144 * xdisp.c (row_hash): New function, body extracted from
4145 compute_line_metrics.
4146 (compute_line_metrics): Call row_hash, instead of computing the
4147 hash code inline.
4148
4149 * dispnew.c (verify_row_hash): Call row_hash for computing the
4150 hash code of a row, instead of duplicating code from xdisp.c.
4151
4152 * dispextern.h (row_hash): Add prototype.
4153
a2addb04
TH
41542011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4155
4156 * frame.c (delete_frame): Don't delete the terminal when the last
4157 X frame is closed if emacs is built with GTK toolkit.
4158
df85d315
JB
41592011-11-17 Juanma Barranquero <lekktu@gmail.com>
4160
4161 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4162
a0c2d0ae
MR
41632011-11-17 Martin Rudalics <rudalics@gmx.at>
4164
4165 * window.c (Vwindow_splits): Rename to
4166 Vwindow_combination_resize. Suggested by Juri Linkov.
4167 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4168 of Vwindow_splits.
4169
58179cce
JB
41702011-11-16 Juanma Barranquero <lekktu@gmail.com>
4171
7877f373
JB
4172 * nsfns.m (Fns_font_name):
4173 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4174
b6f67890
MR
41752011-11-16 Martin Rudalics <rudalics@gmx.at>
4176
4177 * window.h (window): Rename slot "nest" to "combination_limit".
4178 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4179 (Fset_window_nest): Rename to Fset_window_combination_limit.
4180 (Vwindow_nest): Rename to Vwindow_combination_limit.
4181 (recombine_windows, make_parent_window, make_window)
4182 (Fsplit_window_internal, saved_window)
4183 (Fset_window_configuration, save_window_save): Rename all
4184 occurrences of window_nest to window_combination_limit.
4185
c7015153
JB
41862011-11-15 Juanma Barranquero <lekktu@gmail.com>
4187
4188 * image.c (imagemagick_load_image): Fix typo.
4189
322ad6ec
EZ
41902011-11-14 Eli Zaretskii <eliz@gnu.org>
4191
4192 * xdisp.c (display_line): Move the call to
4193 highlight_trailing_whitespace before the call to
4194 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4195 faces of all the glyphs to compute ROW's hash value.
4196 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4197
f067b8ec
JB
41982011-11-14 Juanma Barranquero <lekktu@gmail.com>
4199
4200 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4201 just return (bug#10044).
4202
1e5b2111
EZ
42032011-11-12 Eli Zaretskii <eliz@gnu.org>
4204
7ef3cbd5
EZ
4205 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4206 with user-defined heap size. Bump the default size of the temacs
4207 heap to 27MB, to avoid memory warning when running temacs.
4208 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4209
1e5b2111
EZ
4210 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4211 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4212 (verify_row_hash) [XASSERTS]: New function.
4213 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4214 that the hash value of glyph rows is correct.
1e5b2111 4215
89d61221
MR
42162011-11-12 Martin Rudalics <rudalics@gmx.at>
4217
4218 * window.h (window): Remove splits slot.
4219 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4220 (Fdelete_other_windows_internal, make_parent_window)
4221 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4222 (Fset_window_configuration, save_window_save): Don't deal with
4223 split status of windows.
4224 (saved_window): Remove splits slot.
4225 (Vwindow_splits): Rewrite doc-string.
4226
97f18cc8
JD
42272011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4228
4229 * xfns.c (unwind_create_frame):
4230 * nsfns.m (unwind_create_frame):
4231 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4232 Vframe_list (Bug#9999).
4233
22a648b4
DA
42342011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4235
0b381c7e 4236 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4237
659afede
KH
42382011-11-11 Kenichi Handa <handa@m17n.org>
4239
4240 * callproc.c (Fcall_process): Set the member dst_multibyte of
4241 process_coding.
4242
9ac0394b
KH
42432011-11-11 Johan Bockgård <bojohan@gnu.org>
4244
4245 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4246 avoid a crash (bug#9496).
4247
2fbdc249
CY
42482011-11-09 Chong Yidong <cyd@gnu.org>
4249
4250 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4251 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4252
ac6b1f81
PE
42532011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4256
09db192c
PE
42572011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4258
4259 Avoid some portability problems by eschewing 'extern inline' functions.
4260 The trivial performance wins aren't worth the portability hassles; see
4261 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4262 et seq.
4263 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4264 (window_box_width, window_box_left, window_box_left_offset)
4265 (window_box_right, window_box_right_offset): Undo previous change,
4266 by removing the "extern"s.
4267 * intervals.c (adjust_intervals_for_insertion)
4268 (adjust_intervals_for_deletion): Undo previous change,
4269 making these static again.
4270 (offset_intervals, temp_set_point_both, temp_set_point)
4271 (copy_intervals_to_string): No longer inline.
4272 * xdisp.c (window_text_bottom_y, window_box_width)
4273 (window_box_height, window_box_left_offset)
4274 (window_box_right_offset, window_box_left, window_box_right)
4275 (window_box): No longer inline.
4276
105216ed
CY
42772011-11-08 Chong Yidong <cyd@gnu.org>
4278
4279 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4280 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4281 Signal an error if not a live window.
105216ed
CY
4282 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4283 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4284
ae9e237f
JB
42852011-11-07 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * lisp.h (syms_of_abbrev): Remove declaration.
4288 Reported by CHENG Gao <chenggao@royau.me>.
4289
c7aa8333
EZ
42902011-11-07 Eli Zaretskii <eliz@gnu.org>
4291
4292 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4293 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4294 of temacs in GUI mode.
4295
be7f5545
MR
42962011-11-07 Martin Rudalics <rudalics@gmx.at>
4297
4298 * window.h: Declare delete_all_child_windows instead of
4299 delete_all_subwindows.
4300 * window.c (Fwindow_nest, Fset_window_nest)
4301 (Fset_window_new_total, Fset_window_new_normal)
4302 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4303 (delete_all_subwindows): Rename to delete_all_child_windows.
4304 (Fdelete_other_windows_internal, Fset_window_configuration):
4305 Call delete_all_child_windows instead of delete_all_subwindows.
4306 * frame.c (delete_frame): Call delete_all_child_windows instead
4307 of delete_all_subwindows.
4308
ca78dc43
PE
43092011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4310
4311 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4312 This is also needed for porting to any host where GC_MARK_STACK is
4313 not GC_MAKE_GCPROS_NOOPS.
4314 (which_symbols): Use it.
4315
a0241d01
KH
43162011-11-07 Kenichi Handa <handa@m17n.org>
4317
4318 * coding.c (coding_set_destination): Check coding->src_pos only
4319 when coding->src_object is a buffer (bug#9910).
4320
4321 * process.c (send_process): Set the member src_multibyte of coding
4322 to 0 (bug#9911) when sending a unibyte text.
4323
4324 * callproc.c (Fcall_process): Set the member src_multibyte of
4325 process_coding to 0 (bug#9912).
4326
a64bfdfa 43272011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4328
4329 * xmenu.c (cleanup_widget_value_tree): New function.
4330 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4331 calling free_menubar_widget_value_tree directly (Bug#9830).
4332
cb41b32a
PE
43332011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4334
4335 Fix some portability problems with 'inline'.
4336 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4337 (window_box_width, window_box_left, window_box_left_offset)
4338 (window_box_right, window_box_right_offset): Declare extern.
4339 Otherwise, these inline functions do not conform to C99 and
4340 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4341 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4342 * intervals.c (adjust_intervals_for_insertion)
4343 (adjust_intervals_for_deletion): Now extern, because otherwise the
4344 extern inline functions 'offset_intervals' couldn't refer to it.
4345 (static_offset_intervals): Remove.
4346 (offset_intervals): Rewrite using the old contents of
4347 static_offset_intervals. The old version didn't conform to C99
4348 because an extern inline function contained a reference to an
4349 identifier with static linkage.
4350
b7041366
AS
43512011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4352
4353 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4354 GC.
4355
88a37c4d
EZ
43562011-11-06 Eli Zaretskii <eliz@gnu.org>
4357
4358 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4359 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4360 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4361 return Qleft_to_right.
4362
49745b39
CY
43632011-11-06 Chong Yidong <cyd@gnu.org>
4364
4365 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4366 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4367 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4368 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4369 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4370 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4371 (Fwindow_vscroll): Doc fix.
4372 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4373 argument, since it makes no sense to pass a live window and for
4374 consistency with window-child.
4375
1f05cd82
CS
43762011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4377
4378 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4379 support MSVC.
4380
22610910
JR
43812011-11-05 Jason Rumney <jasonr@gnu.org>
4382
4383 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4384 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4385 fonts (Bug#6029).
4386 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4387 bitwise arithmetic preventing use of unicode-sip and non-truetype
4388 opentype fonts.
4389
a06776b2
EZ
43902011-11-05 Eli Zaretskii <eliz@gnu.org>
4391
3ad924ba
EZ
4392 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4393 "emacs"-only part.
4394
a06776b2
EZ
4395 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4396 initialization code to keep similarity to xfns.c after changes
4397 from 2011-11-05.
4398
c9e7db78
JD
43992011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4400
a97f8f3f
JD
4401 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4402 (unwind_create_frame): New function (Bug#9943).
4403 (Fx_create_frame): Restructure code to be more similar to the one in
4404 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4405 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4406 Move terminal->reference_count++ just before making the frame official
4407 (Bug#9943).
4408
4409 * nsterm.m (x_free_frame_resources): New function.
4410 (x_destroy_window): Move code to x_free_frame_resources.
4411
c9e7db78 4412 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4413 (Fx_create_frame, x_create_tip_frame):
4414 Move terminal->reference_count++ just before making the frame
75f1671a 4415 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4416 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4417
a6fc3b5c
EZ
44182011-11-05 Eli Zaretskii <eliz@gnu.org>
4419
4420 Support MSVC build with newer versions of Visual Studio.
4421 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4422 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4423 nt/gmake.defs.
4424
4425 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4426 which are not supported by MSVC.
4427 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4428 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4429 bitfields.
4430 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4431 types in bitfields.
4432 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4433
4434 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4435
58179cce 44362011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4437
4438 Support MSVC build with newer versions of Visual Studio.
4439 * w32.c: Don't include w32api.h for MSVC.
4440 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4441
4442 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4443 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4444 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4445 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4446 e_* cousins.
4447 (alloca) [_MSC_VER]: Define to _alloca.
4448
4449 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4450
4451 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4452
a58c13ed
EZ
44532011-11-04 Eli Zaretskii <eliz@gnu.org>
4454
4455 * xdisp.c (note_mouse_highlight): If either of
4456 previous/next-single-property-change returns nil, treat that as
4457 the beginning or the end of the buffer. (Bug#9955)
4458
fe0b6370
JD
44592011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4460
a58c13ed 4461 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4462 label is not null (Bug#9951).
4463 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4464 may be NULL.
4465
89bd5ee1
EZ
44662011-11-04 Eli Zaretskii <eliz@gnu.org>
4467
4468 * window.c (Fwindow_body_size): Mention in the doc string that the
4469 return value is in frame's canonical units. (Bug#9949)
4470
84c3edb9
EZ
44712011-11-03 Eli Zaretskii <eliz@gnu.org>
4472
4e2fb5c7
EZ
4473 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4474
84c3edb9 4475 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4476 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4477 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4478
bc17a887
EZ
44792011-11-01 Eli Zaretskii <eliz@gnu.org>
4480
4481 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4482 Don't stop backward scan on the continuation glyph, even though
4483 its CHARPOS is positive.
6d5eb5b0
SM
4484 (mouse_face_from_buffer_pos, note_mouse_highlight):
4485 Rename cover_string to disp_string.
bc17a887 4486
4ee88440
MR
44872011-11-01 Martin Rudalics <rudalics@gmx.at>
4488
4489 * window.c (temp_output_buffer_show): Don't use
4490 Vtemp_buffer_show_specifiers.
4491 (Vtemp_buffer_show_specifiers): Remove unused variable.
4492
c2ff3c02
EZ
44932011-10-30 Eli Zaretskii <eliz@gnu.org>
4494
4495 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4496 past the beginning of the current glyph matrix.
4497
58179cce 44982011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4499
4500 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4501 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4502 HAVE_GTK3 (Bug#9869).
b77a6a7f 4503
3b574623
JD
4504 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4505 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4506
b77a6a7f
JD
4507 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4508
4509 * xterm.c: Declare x_handle_net_wm_state to return int.
4510 (handle_one_xevent): Check if we are iconified but don't have
4511 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4512 (get_current_wm_state): Return non-zero if not hidden,
4513 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4514 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4515 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4516 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4517
196e41e4
PE
45182011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4519
4520 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4521 so that this new function doesn't get optimized away by a
4522 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4523
021f2e1a
AS
45242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4525
4526 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4527
8b058d44
EZ
45282011-10-29 Eli Zaretskii <eliz@gnu.org>
4529
4530 Fix the `xbytecode' command.
4531 * .gdbinit (xprintbytestr): New command.
b50a28de 4532 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4533 (xbytecode): Print the byte-code string as well.
4534
4452fb80
EZ
45352011-10-29 Kim Storm <storm@cua.dk>
4536
8b058d44
EZ
4537 * alloc.c (which_symbols): New function.
4538
21b72067
AS
45392011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4540
4541 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4542 line. (Bug#9903)
4543
83ed7b5c
GM
45442011-10-29 Glenn Morris <rgm@gnu.org>
4545
4546 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4547 Not clear what it was for, and it causes various bugs. (Bug#9839)
4548
5a7a728b
EZ
45492011-10-28 Eli Zaretskii <eliz@gnu.org>
4550
4551 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4552 possible random value that matches one of those tested as
4553 condition to clear the mouse face.
4554
d3d0842f
CY
45552011-10-28 Chong Yidong <cyd@gnu.org>
4556
4557 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4558
31b39d13
DN
45592011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4560
4561 * window.c (make_window): Initialize phys_cursor_on_p.
4562
9aba6043
SM
45632011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4564
4565 * lisp.h (struct Lisp_Symbol): Update comments.
4566
c20992f4
JB
45672011-10-28 Juanma Barranquero <lekktu@gmail.com>
4568
4569 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4570
db4f02f2
EZ
45712011-10-28 Eli Zaretskii <eliz@gnu.org>
4572
4573 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4574 <oslsachem@gmail.com> for helping to debug this.
4575
4576 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4577 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4578 (g_b_init_get_glyph_outline_w): New static variables.
4579 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4580 (GetGlyphOutlineW_Proc): New typedefs.
4581 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4582 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4583 New functions.
4584 (w32font_open_internal, compute_metrics):
4585 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4586 instead of calling the "wide" APIs directly.
4587
4588 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4589
4590 * w32.h (syms_of_w32font): Add prototype.
4591
87e68db4
JB
45922011-10-27 Juanma Barranquero <lekktu@gmail.com>
4593
4594 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4595 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4596 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4597 (Fmove_to_window_line): Doc fix.
4598
435c1d67
CY
45992011-10-27 Chong Yidong <cyd@gnu.org>
4600
4601 * process.c (make_process): Set gnutls_state to NULL.
4602
4603 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4604 non-NULL, regardless of GNUTLS_INITSTAGE.
4605 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4606 an error. Set process slots as soon as we allocate them.
4607
4608 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4609
9c6c6f49
CY
46102011-10-27 Chong Yidong <cyd@gnu.org>
4611
9aba6043
SM
4612 * gnutls.c (emacs_gnutls_deinit): New function.
4613 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4614 (Fgnutls_deinit, Fgnutls_boot): Use it.
4615
4616 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4617 (deactivate_process): Call emacs_gnutls_deinit.
4618
657d08d3
JB
46192011-10-27 Juanma Barranquero <lekktu@gmail.com>
4620
4621 * image.c (x_create_x_image_and_pixmap):
4622 * w32.c (sys_rename, w32_delayed_load):
4623 * w32font.c (fill_in_logfont):
4624 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4625
5430d399
JB
46262011-10-26 Juanma Barranquero <lekktu@gmail.com>
4627
4628 * w32fns.c (w32_default_color_map): New function,
4629 extracted from Fw32_default_color_map.
a7ef684b 4630 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4631
fe0055fa
PE
46322011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4633
4634 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4635
e6346438
SM
46362011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4637
4638 * keyboard.c (test_undefined): New function (bug#9751).
4639 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4640
e112cc37
ET
46412011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4642
4643 * sysdep.c (init_sys_modes): Fix the check for the controlling
4644 terminal (Bug#6649).
4645
7b5d6677
EZ
46462011-10-20 Eli Zaretskii <eliz@gnu.org>
4647
4648 * dispextern.h (struct bidi_it): New member next_en_type.
4649
4650 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4651 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4652 current character, check also for next_en_type being WEAK_EN.
4653 (bidi_resolve_weak): Don't enter the expensive loop if the current
4654 position is before next_en_pos. Record the bidi type of the first
4655 non-ET, non-BN character we find, in addition to its position.
4656 (bidi_level_of_next_char): Invalidate next_en_type when
4657 next_en_pos is over-stepped.
4658
7da0b018
PE
46592011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4660
4661 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4662 * editfns.c: Rewrite current-time-zone so that it invokes
4663 the equivalent of (format-time-string "%Z") to get the time zone name.
4664 This fixes a bug when the time zone name contains characters that
4665 need converting from the system time locale to Emacs internal format.
4666 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4667 that patch fixed format-time-string to do the conversion, but
4668 I forgot to fix current-time-zone.
4669 (format_time_string): New function, containing most of
4670 what Fformat_time_string used to contain.
4671 (Fformat_time_string): Rewrite in terms of format_time_string.
4672 This doesn't change this function's behavior.
4673 (current-time-zone): Rewrite to use format_time_string.
4674 This fixes the bug reported by Michael Schierl in
4675 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4676 Jason Rumney's 2007-06-07 change worked around this bug, but
4677 didn't fix it.
4678 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4679
8547b010
EZ
46802011-10-19 Eli Zaretskii <eliz@gnu.org>
4681
4682 * xdisp.c (start_display): If the character at POS is displayed
4683 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4684 (try_window_reusing_current_matrix): If a line ends in a display
4685 vector or the next line starts in a display vector, continue
4686 redrawing the window even though the character position of
4687 start_row was reached.
8547b010
EZ
4688 (Bug#9771, part 2)
4689
4e948d15
CY
46902011-10-18 Chong Yidong <cyd@gnu.org>
4691
4692 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4693 with nobreak-char-display too.
4694
4787455f
EZ
46952011-10-18 Eli Zaretskii <eliz@gnu.org>
4696
4697 Fix part 3 of bug#9771.
4698 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4699 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4700 non-neutral characters if the current character is a paragraph
4701 separator (a.k.a. Newline). This avoids running the same
4702 expensive loop twice, once when we consume the preceding newline
4703 and the other time when the line actually needs to be displayed.
4704 Avoid the loop when we see neutrals on the base embedding level
4705 following a character whose directionality is the same as the
4706 paragraph's. This avoids running the expensive loop when a line
4707 ends in a long sequence of neutrals, like control characters.
4708 Add assertion against STRONG_AL type. Slightly rearrange code
4709 that determines the type of a neutral given the first non-neutral
4710 that follows it.
4711 (bidi_level_of_next_char): Set next_en_pos to zero when
4712 invalidating its info.
4713
2c91f553
EZ
47142011-10-17 Eli Zaretskii <eliz@gnu.org>
4715
4716 * xdisp.c (push_display_prop): Determine whether to record string
4717 or buffer position by IT->string, not by IT->method. Allow
4718 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4719 (move_it_vertically_backward): Don't look for character position
4720 immediately after the newline when in a continuation line.
4721 (Bug#9771, part 1)
2c91f553 4722
c7b08b0d
MR
47232011-10-15 Martin Rudalics <rudalics@gmx.at>
4724
4725 * window.c (coordinates_in_window): Rewrite and delabelize
4726 vertical border check. (Bug#5357) (Bug#9618)
4727
6b02f655
SM
47282011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4729
4730 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4731 errors in XSetWindowBorder (bug#9310).
4732
81d40c92
DA
47332011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4734
4735 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4736 avoid crash when xmalloc overrun checking is enabled.
4737
d4172c3b
EZ
47382011-10-13 Eli Zaretskii <eliz@gnu.org>
4739
4740 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4741 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4742 cursor motion with <left> and <right> arrow keys.
4743
4744 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4745 some callers set that themselves.
4746
b00eea75
EZ
47472011-10-12 Eli Zaretskii <eliz@gnu.org>
4748
4749 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4750 display string and the previous row comes from the same string and
4751 is empty. (Bug#9739) (Bug#9738)
4752
8fe012c4
SM
47532011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4754
4755 * doc.c (get_doc_string): Encode file name (bug#9735).
4756
0074aef2
EZ
47572011-10-12 Eli Zaretskii <eliz@gnu.org>
4758
79beb178
EZ
4759 * bidi.c (bidi_level_of_next_char):
4760 * xdisp.c (get_visually_first_element): Remove old incorrect
4761 comments regarding the Unicode Line Separator character.
4762
0074aef2
EZ
4763 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4764
6e4b3fbe
DA
47652011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4766
4767 * alloc.c (Fgc_status): Do not access beyond zombies array
4768 boundary if nzombies > MAX_ZOMBIES.
4769 * alloc.c (dump_zombies): Add missing format specifier.
4770
0324f3af
PE
47712011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4772
b5525cac
PE
4773 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4774 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4775
0324f3af
PE
4776 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4777 Some packages use them to denote characters with modifiers.
4778
e9b5f888
AS
47792011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4780
4781 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4782 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4783 matching a pp-number. Rename parameter var to var1.
4784
127827c0
SM
47852011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4786
4787 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4788
c8fd3bd0
GM
47892011-10-08 Glenn Morris <rgm@gnu.org>
4790
4791 * callint.c (Fcall_interactively): Give a more explicit error for the
4792 'c' case with a non-character input. (Bug#8479)
4793
352ec8ff
EZ
47942011-10-08 Eli Zaretskii <eliz@gnu.org>
4795
03669ccb
EZ
4796 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4797 lines.
7061c986
EZ
4798 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4799 lines that are hscrolled on the left.
03669ccb 4800
352ec8ff
EZ
4801 * dispnew.c (buffer_posn_from_coords): Account for a possible
4802 presence of header-line. (Bug#4426)
4803
a66cfb1c
SM
48042011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4805
6b02f655
SM
4806 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4807 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4808
7c5ee88e
PE
48092011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4812 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4813 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4814 this makes Emacs dump core during garbage collection on rare
4815 occasions. sizeof is obviously inferior to offsetof here, so
4816 stick with offsetof.
4817 (GC_POINTER_ALIGNMENT): New macro.
4818 (mark_memory): Omit 3rd (offset) arg; caller changed.
4819 Don't assume EMACS_INT alignment is the same as pointer alignment.
4820
df1bbe5b
SM
48212011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4822
4823 * keyboard.c (read_key_sequence_remapped): New var.
4824 (read_key_sequence): Compute remapping in the right buffer.
4825 (command_loop_1): Use read_key_sequence's remapping directly.
4826
51553db6
SM
48272011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4828
32c1fffd
SM
4829 * dired.c (file_name_completion): Don't expand file name.
4830 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4831 before checking file name handler.
4832
51553db6
SM
4833 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4834 they've been requested explicitly (bug#9591).
4835
b6bd1599 48362011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4837
4838 * keymap.c (Fsingle_key_description): Use make_specified_string
4839 instead of build_string to build string from push_key_description.
4840 (Bug#5193)
4841
f701dc2a
PE
48422011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4843
4222c55d
PE
4844 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4845 This fixes a Y2038 bug on 64-bit hosts.
4846 * buffer.c (reset_buffer):
4847 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4848 (Fclear_buffer_auto_save_failure):
4849 Use 0, not -1, to represent an unset failure time, since time_t
4850 might not be signed.
4851
f701dc2a
PE
4852 Remove dependency on glibc malloc internals.
4853 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4854 Move back here from lisp.h, but with their new implementations.
4855 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4856 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4857 * charset.c (charset_table_init): New static var.
4858 (syms_of_charset): Use it instead of xmalloc. This removes a
4859 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4860 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4861 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4862 Move back to alloc.c.
4863 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4864 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4865
9ceebf39
JD
48662011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4867
4868 * nsterm.m (windowDidResize): Call x_set_window_size only when
4869 ns_in_resize is true. Otherwise set pixelwidth/height and
4870 call change_frame_size (Bug#9628).
4871
cb993c58
PE
48722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4873
3930c88b
PE
4874 Port --enable-checking=all to Fedora 14 x86-64.
4875 * charset.c (syms_of_charset): Also account for glibc malloc's
4876 internal overhead when calculating the initial malloc maximum.
4877
cb993c58
PE
4878 Port --enable-checking=all to Fedora 14 x86.
4879 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4880 Move to lisp.h.
4881 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4882 (overrun_check_realloc, overrun_check_free):
4883 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4884 That way, xmalloc returns a properly-aligned pointer even if
4885 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4886 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4887 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4888 into account when calculating the initial malloc maximum.
4889 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4890 Move here from alloc.c, so that charset.c can use it too.
4891 Properly align; the old code wasn't right for common 32-bit hosts
4892 when configured with --enable-checking=all.
4893 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4894 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4895
31bed486
EZ
48962011-09-29 Eli Zaretskii <eliz@gnu.org>
4897
04c70788 4898 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4899 use EDOM.
4900
fbcaa2f3
EZ
49012011-09-28 Eli Zaretskii <eliz@gnu.org>
4902
4903 * xdisp.c (compute_display_string_end): If there's no display
4904 string at CHARPOS, return -1.
4905
4906 * bidi.c (bidi_fetch_char): When compute_display_string_end
4907 returns a negative value, treat the character as a normal
4908 character not covered by a display string. (Bug#9624)
4909
a239d4e9
JB
49102011-09-28 Juanma Barranquero <lekktu@gmail.com>
4911
4912 * lread.c (Fread_from_string): Fix typo in docstring.
4913
88652fd5
EZ
49142011-09-27 Eli Zaretskii <eliz@gnu.org>
4915
4916 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4917 newline, reseat the iterator instead of bidi-iterating there one
4918 character at a time. (Bug#9610)
32c1fffd
SM
4919 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4920 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4921
ed497dd4
AS
49222011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4923
4924 * lread.c (readevalloop): Use correct code for NBSP.
4925 (read1): Likewise. (Bug#9608)
4926
b2bf61aa
MA
49272011-09-25 Michael Albinus <michael.albinus@gmx.de>
4928
4929 * dbusbind.c (Fdbus_register_signal): When service is not
4930 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4931
32bbb17c
GM
49322011-09-25 Glenn Morris <rgm@gnu.org>
4933
4934 * buffer.c (truncate-lines): Doc fix.
4935
94e0933e
CY
49362011-09-24 Chong Yidong <cyd@stupidchicken.com>
4937
4938 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4939 (Fset_window_next_buffers): Doc fix.
4940
cddde921
GM
49412011-09-24 Glenn Morris <rgm@gnu.org>
4942
4943 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4944
1260aef1
PE
49452011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4946
25b4bfa0
PE
4947 Fix minor problems found by static checking.
4948 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4949 * indent.c (Fvertical_motion): Fix == vs = typo.
4950
e3cbd34b
EZ
49512011-09-24 Eli Zaretskii <eliz@gnu.org>
4952
a66cfb1c
SM
4953 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4954 Default value is now t. Doc fix.
6bf7006f 4955
e3cbd34b 4956 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4957 logic when moving up, not only when moving down. Fix the
e3cbd34b 4958 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4959 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4960
4961 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4962 CHARPOS is covered by a display string which includes newlines.
4963 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4964 is covered by a display string with embedded newlines.
4965
a3de0cbd
MA
49662011-09-24 Michael Albinus <michael.albinus@gmx.de>
4967
4968 * dbusbind.c (Fdbus_register_signal): Add match rule to
4969 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4970 (Fdbus_register_method, Vdbus_registered_objects_table):
4971 Fix docstring.
a3de0cbd 4972
b260039d
JM
49732011-09-24 Jim Meyering <meyering@redhat.com>
4974
32c1fffd 4975 do not ignore write error for any output size
b260039d
JM
4976 The previous change was incomplete.
4977 While it makes emacs --batch detect the vast majority of stdout
4978 write failures, errors were still ignored whenever the output size is
4979 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4980 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4981 && echo FAIL: ignored write error
4982 FAIL: ignored write error
4983 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4984 && echo FAIL: ignored write error
4985 FAIL: ignored write error
4986 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4987
8eca8a7c
AS
49882011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4989
4990 * emacs.c (Fkill_emacs): In noninteractive mode exit
4991 non-successfully if a write error occurred on stdout. (Bug#9574)
4992
3341db62
EZ
49932011-09-21 Eli Zaretskii <eliz@gnu.org>
4994
4995 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4996 the xassert test.
4997
4998 * dispextern.h (struct it): Update the comment documenting what
4999 can it->OBJECT be.
5000
8c203dbf
EZ
50012011-09-20 Eli Zaretskii <eliz@gnu.org>
5002
5003 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5004 a display string, extend search for cursor position to end of row.
5005 (find_row_edges): If the row ends in a newline from a display
5006 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5007 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5008 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5009 non-empty line. Fixes confusing cursor motion with arrow keys at
5010 the beginning of a line that starts with whitespace.
8c203dbf 5011
a4824228
LMI
50122011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5013
5014 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5015 (bug#9493).
5016
33ed493b
CY
50172011-09-18 Chong Yidong <cyd@stupidchicken.com>
5018
5019 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5020 boolean (Bug#9154).
5021
56cd55c8
EZ
50222011-09-18 Eli Zaretskii <eliz@gnu.org>
5023
5024 * xdisp.c (display_line): Record maximum and minimum buffer
5025 positions even if no glyphs were produced (e.g., by a zero-width
5026 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5027 buffer positions that will be removed from the glyph row because
5028 they don't fit.
c02dcedf
EZ
5029 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5030 column is beyond frame width: don't subtract 1 "pixel" when
5031 computing width of the stretch.
3e62b7e0
EZ
5032 (reseat_at_next_visible_line_start): Undo the change made on
5033 2011-09-17 that saved paragraph information and restored it after
5034 the call to `reseat'. (Bug#9545)
56cd55c8 5035
5ed99d36 50362011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5037
5038 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5039 and turn window cursor on if cleared (Bug#9415).
5040
5ed99d36 50412011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5042
5043 * search.c (boyer_moore): Take unibyte characters from pattern
5044 literally. (Bug#9458)
5045
9bade7b2
EZ
50462011-09-18 Eli Zaretskii <eliz@gnu.org>
5047
5048 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5049
e5e9d610
PE
50502011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5051
87e4427a
PE
5052 Fix minor problem found by static checking.
5053 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5054 initialized, to pacify gcc -Wuninitialized.
5055
e5e9d610
PE
5056 * fileio.c: Report proper errno when syscall falls.
5057 (Finsert_file_contents): Save and restore errno,
5058 so that report_file_error outputs the correct diagnostic.
5059 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5060
a1674f0b
EZ
50612011-09-18 Eli Zaretskii <eliz@gnu.org>
5062
5063 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5064
fbfb6dd4
EZ
50652011-09-17 Eli Zaretskii <eliz@gnu.org>
5066
5067 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5068 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5069
bb187662
EZ
50702011-09-17 Eli Zaretskii <eliz@gnu.org>
5071
1137e8b8 5072 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5073 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5074
5075 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5076 (bidi_find_paragraph_start): Search back for paragraph beginning
5077 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5078 (bidi_move_to_visually_next): Only trigger paragraph-related
5079 computations when the last character is a newline or at EOB, not
5080 just any NEUTRAL_B. (Bug#9470)
5081
bb187662
EZ
5082 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5083 truncated lines if point is covered by a display string. (Bug#9524)
5084
2e621251
PE
50852011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5086
5087 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5088 (cons_to_x_long): New function.
5089 (lisp_data_to_selection_data): Use it. Correct the test for
5090 short-versus-long data; it was negated. Break out of vector
5091 loop, for efficiency, when a long datum is discovered.
5092
91a15bc6
SM
50932011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5094
5095 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5096
b41c3a35
EZ
50972011-09-16 Eli Zaretskii <eliz@gnu.org>
5098
5099 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5100 GCC PR/17406) by declaring this function with external scope.
5101
7812ba2d
PE
51022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5103
5104 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5105 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5106
cf7edc2a
AS
51072011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5108
5109 * editfns.c (Fformat): Correctly handle text properties on "%%".
5110
bd01620e
EZ
51112011-09-15 Eli Zaretskii <eliz@gnu.org>
5112
5113 * xterm.c (x_draw_composite_glyph_string_foreground):
5114 * w32term.c (x_draw_composite_glyph_string_foreground):
5115 * term.c (encode_terminal_code):
5116 * composite.c (composition_update_it, get_composition_id):
5117 * xdisp.c (get_next_display_element)
5118 (fill_composite_glyph_string): Add comments about special meaning
5119 of TAB characters in a composition.
5120
a02719a3
PE
51212011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5122
5123 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5124 This occurs when processing a multibyte format.
5125 Problem reported by Wolfgang Jenker.
a02719a3 5126
72589a3c
JB
51272011-09-15 Johan Bockgård <bojohan@gnu.org>
5128
5129 * xdisp.c (try_cursor_movement): Only check for exact match if
5130 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5131
1c14176c
PE
51322011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5133
5134 Remove unused external symbols.
5135 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5136 * xdisp.c (calc_pixel_width_or_height): Now static.
5137 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5138 * indent.c (check_display_width):
5139 * w32term.c: Fix comment to match code.
5140 * xterm.c, xterm.h (x_catching_errors): Remove.
5141
d2eea5b5
PE
51422011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5143
5144 * xselect.c: Use signed conversions more consistently (Bug#9498).
5145 (selection_data_to_lisp_data): Assume incoming selection data are
5146 signed integers, not unsigned. This is to be consistent with
5147 outgoing selection data, which was modified to use signed integers
5148 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5149 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5150 expects long, not unsigned long.
5151
46888499
EZ
51522011-09-14 Eli Zaretskii <eliz@gnu.org>
5153
5154 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5155 computation of loop end. Reported by Johan Bockgård
5156 <bojohan@gnu.org>.
5157
ef8ef9fb
CY
51582011-09-13 Chong Yidong <cyd@stupidchicken.com>
5159
5160 * frame.c (Fother_visible_frames_p): Function deleted.
5161
fa819fed
EZ
51622011-09-12 Eli Zaretskii <eliz@gnu.org>
5163
5164 * indent.c (compute_motion): Process display vector front to back
5165 rather than the other way around. (Bug#2496)
5166
2ba8e008
SM
51672011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5168
5169 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5170
20f53c69
CY
51712011-09-11 Chong Yidong <cyd@stupidchicken.com>
5172
5173 * minibuf.c (Fread_from_minibuffer): Doc fix.
5174
d562d7a4
EZ
51752011-09-11 Eli Zaretskii <eliz@gnu.org>
5176
5177 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5178 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5179
1c4d7f3d
LMI
51802011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5181
5182 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5183 value for non-existent files.
5184
b885bf36
EZ
51852011-09-11 Eli Zaretskii <eliz@gnu.org>
5186
5187 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5188 set its "size" to -1. This will set the modtime_size field of
5189 the corresponding buffer to -1, which is what
5190 verify-visited-file-modtime expects for files that do not exist.
5191 (Bug#9139)
5192
6612f0bf
PE
51932011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5196 here ...
5197 * lisp.h: ... from here. push_key_description is no longer
5198 defined in keyboard.c, so its declaration should not be in
5199 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5200 logically belongs with push_key_description.
5201
dfb3f755
PE
52022011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5203
5204 * buffer.h: Include <sys/types.h> instead of <time.h>.
5205 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5206 Problem reported by Herbert J. Skuhra.
5207
3134906c
LMI
52082011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5209
5210 * xml.c (parse_region): Make the parsing work for
5211 non-comment-starting XML files again (bug#9144).
5212
8d903f4e
AS
52132011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5214
5215 * image.c (gif_load): Fix calculation of bottom and right corner.
5216 (Bug#9468)
5217
80ad64f4
EZ
52182011-09-10 Eli Zaretskii <eliz@gnu.org>
5219
5220 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5221 redisplay in small windows.
5222
208a048d
EZ
52232011-09-09 Eli Zaretskii <eliz@gnu.org>
5224
5225 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5226
9b1c252e
MR
52272011-09-08 Martin Rudalics <rudalics@gmx.at>
5228
5229 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5230 Operate on live windows only.
5231
2949f33b
JB
52322011-09-08 Juanma Barranquero <lekktu@gmail.com>
5233
5234 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5235
e08dcafd
EZ
52362011-09-07 Eli Zaretskii <eliz@gnu.org>
5237
5238 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5239 only under bidi iteration.
5240
115b96bd
JD
52412011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5242
5243 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5244
c8199d0f
PE
52452011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5248 Without this fix, the command to link temacs failed due to an
5249 undefined symbol __builtin_isnan. This is because
5250 /usr/include/iso/math_c99.h #defines isnan(x) to
5251 __builtin_isnan(x), but the bundled gcc, which identifies itself
5252 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5253 a __builtin_isnan.
5254 * floatfns.c (isnan): #undef, and then #define to a clone of
5255 what's in data.c.
5256 (Fisnan): Always define, since it's always available now.
5257 (syms_of_floatfns): Always define isnan at the Lisp level.
5258
e39b275c 52592011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5260
5261 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5262
b2db44d9 52632011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5264
f4af5137 5265 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5266 The previous code assumed that file offsets (off_t values) fit in
5267 EMACS_INT variables, which is not true on typical 32-bit hosts.
5268 The code messed up by falsely reporting buffer overflow in cases
5269 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5270 when "big" contains more than 2**29 bytes, even though this
5271 inserts just one byte and does not overflow the buffer.
5272 (Finsert_file_contents): Store file offsets as off_t
5273 values, not as EMACS_INT values. Check for overflow when
5274 converting between EMACS_INT and off_t. When checking for
5275 buffer overflow or for overlap, take the offsets into account.
5276 Don't use EMACS_INT for small values where int suffices.
5277 When checking for overlap, fix a typo: ZV was used where
5278 ZV_BYTE was intended.
5279 (Fwrite_region): Don't assume off_t fits into 'long'.
5280 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5281
ecfc0a49
MA
52822011-09-05 Michael Albinus <michael.albinus@gmx.de>
5283
5284 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5285
6511acf2 52862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5287
0999621a 5288 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5289
5290 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5291 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5292 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5293 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5294 (modify_event_symbol): Do not assume that the length of
5295 name_alist_or_stem is safe to alloca and fits in int.
5296 (Fexecute_extended_command): Likewise for function name and binding.
5297 (Frecursion_depth): Wrap around reliably on integer overflow.
5298 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5299 since some callers pass EMACS_INT values.
5300 (Fsingle_key_description): Don't crash if symbol name contains more
5301 than MAX_ALLOCA bytes.
5302 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5303 (get_minibuffer): Arg is now EMACS_INT, not int.
5304 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5305 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5306 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5307
2be7d702
PE
5308 * dbusbind.c (signature_cat): New function.
5309 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5310 Do not overrun buffer; instead, report string overflow.
5311
9d1df220
PE
5312 * dispnew.c (add_window_display_history): Don't overrun buffer.
5313 Truncate instead; this is OK since it's just a log.
5314
33ef5c64
PE
5315 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5316 even if the time zone offset is outlandishly large.
5317 Don't mishandle offset == INT_MIN.
5318
66c6fdd5
PE
5319 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5320 when creating daemon; the previous buffer-overflow check was incorrect.
5321
d749b01b
PE
5322 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5323 which has the guts of the old verror function.
5324
b5cd1905
PE
5325 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5326 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5327
6e1a67fb
PE
5328 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5329 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5330 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5331 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5332 length of string rather than counting it via multiple sprintfs;
5333 that's simpler and more reliable.
c21721cc
PE
5334 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5335 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5336 sprintf, in case result does not fit in int.
5337
c57b67fc
PE
5338 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5339 (fontset_from_font): Print it.
5340
8a401434
PE
5341 * frame.c (tty_frame_count): Now printmax_t, not int.
5342 (make_terminal_frame, set_term_frame_name): Print it.
5343 (x_report_frame_params): In X, window IDs are unsigned long,
5344 not signed long, so print them as unsigned.
5345 (validate_x_resource_name): Check for implausibly long names,
5346 and don't assume name length fits in 'int'.
5347 (x_get_resource_string): Don't blindly alloca invocation name;
5348 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5349 not fit in int.
5350
6e1a67fb
PE
5351 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5352 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5353 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5354
0df02bf3
PE
5355 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5356 Use esprintf, not sprintf, in case result does not fit in int.
5357
48e30793
PE
5358 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5359 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5360 it as a large positive number.
5361 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5362 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5363
a66ff6d8
PE
5364 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5365 in case result does not fit in int.
5366
aca216ff
PE
5367 * print.c (float_to_string): Detect width overflow more reliably.
5368 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5369 buffer overrun. Don't assume list length fits in 'int'. Treat
5370 print length of 0 as 0, not as infinity; to be consistent with other
5371 uses of print length in this function. Don't overflow print length
5372 index. Don't assume hash table size fits in 'long', or that
5373 vectorlike size fits in 'unsigned long'.
5374
31c286f7
PE
5375 * process.c (make_process): Use printmax_t, not int, to format
5376 process-name gensyms.
5377
55e5faa1
PE
5378 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5379
80f2e268
PE
5380 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5381 to avoid potential buffer overrun.
5382
670741ab
PE
5383 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5384 if X resource line is longer than 512 bytes.
5385
b7163a50
PE
5386 * xfns.c (x_window): Make sprintf buffer a bit bigger
5387 to avoid potential buffer overrun.
5388
ae58ff1f
PE
5389 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5390
c43c8a6a
PE
5391 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5392
3f8236f4
PE
53932011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5394
53e9fe90 5395 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5396 Without these, Emacs silently mishandles large integers sometimes.
5397 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5398 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5399
6511acf2
PE
5400 * xdisp.c (try_window_id): Check Emacs fixnum range before
5401 converting to 'int'.
806add1d 5402
6511acf2 5403 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5404 Check that an Emacs fixnum is in range before assigning it to 'int'.
5405 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5406 values converted from Emacs fixnums.
5407 (Frecenter): Don't wrap around a line count if it is out of 'int'
5408 range; instead, treat it as an extreme value.
5409 (Fset_window_configuration, compare_window_configurations):
5410 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5411
6511acf2
PE
5412 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5413 that can exceed INT_MAX. Check that EMACS_INT value is in range
5414 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5415 (match_limit): Don't assume that a fixnum can fit in 'int'.
5416
6511acf2 5417 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5418 exceed INT_MAX.
5419
6511acf2 5420 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5421 (Fvertical_motion): Don't wrap around LINES values that don't fit
5422 in 'int'. Instead, treat them as extreme values. This is good
5423 enough for windows, which can't have more than INT_MAX lines anyway.
5424
fcb901a7
LMI
54252011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5426
0f2f6b6d
LMI
5427 * Require libxml/parser.h to avoid compilation warning.
5428
fcb901a7
LMI
5429 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5430
5431 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5432 since this reportedly can destroy thread storage.
5433
6e20a0d4
CY
54342011-08-30 Chong Yidong <cyd@stupidchicken.com>
5435
5436 * syntax.c (find_defun_start): Update all cache variables if
5437 exiting early (Bug#9401).
5438
148ae00e
EZ
54392011-08-30 Eli Zaretskii <eliz@gnu.org>
5440
f6cfbd8f
EZ
5441 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5442
148ae00e
EZ
5443 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5444 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5445 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5446
5447 * term.c (tty_append_glyph): New function.
5448 (produce_stretch_glyph): Static function and its prototype deleted.
5449
a66cfb1c
SM
5450 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5451 Add prototypes.
148ae00e 5452
c4a07a4c
PE
54532011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5454
5455 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5456 when checking :margin (Bug#9390).
5457 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5458 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5459 so that the name doesn't mislead. All uses changed.
5460
6bc8cd65
JB
54612011-08-28 Johan Bockgård <bojohan@gnu.org>
5462
5463 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5464 set_tty_hooks.
5465
dca4927e
EZ
54662011-08-27 Eli Zaretskii <eliz@gnu.org>
5467
5468 * xdisp.c (move_it_to): Don't bail out early when reaching
5469 position beyond to_charpos, if we are scanning backwards.
5470 (move_it_vertically_backward): When DY == 0, make sure we get to
5471 the first character in the line after the newline.
5472
f2cad773
PE
54732011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5476 (ccl_driver): Do not generate an out-of-range pointer.
5477 (Fccl_execute_on_string): Remove unnecessary check for
5478 integer overflow, noted by Stefan Monnier in
5479 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5480 Remove a FIXME that didn't need fixing.
5481 Simplify the newly-introduced buffer reallocation code.
5482
0cae2cdb
JB
54832011-08-27 Juanma Barranquero <lekktu@gmail.com>
5484
5485 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5486
5fc295a4 54872011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5488
70c60eb2 5489 Integer and memory overflow issues (Bug#9196).
726e0ab1 5490
d31850da
PE
5491 * doc.c (get_doc_string): Rework so that
5492 get_doc_string_buffer_size is the actual buffer size, rather than
5493 being 1 less than the actual buffer size; this makes xpalloc more
5494 convenient.
5495
a69fbedb
PE
5496 * image.c (x_allocate_bitmap_record, cache_image):
5497 * xselect.c (Fx_register_dnd_atom):
5498 Simplify previous changes by using xpalloc.
5499
fe5c5d37
PE
5500 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5501 since either will do and ptrdiff_t is convenient with xpalloc.
5502
0065d054
PE
5503 * charset.c (charset_table_size)
5504 (struct charset_sort_data.priority): Now ptrdiff_t.
5505 (charset_compare): Don't overflow if priorities differ greatly.
5506 (Fsort_charsets): Don't assume list length fits in int.
5507 Check for size-calculation overflow when allocating sort data.
5508 (syms_of_charset): Allocate an initial charset table that is
5509 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5510
5511 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5512
5513 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5514 The actual value is always <= INT_MAX, and leaving it unsigned made
5515 overflow checking harder.
5516
5517 * dispextern.h (struct glyph_matrix.rows_allocated)
5518 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5519 with xpalloc. The values are still always <= INT_MAX.
5520
5521 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5522
5523 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5524 (SAFE_NALLOCA): New macro.
5525
5526 * region-cache.c (struct boundary.pos, find_cache_boundary)
5527 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5528 (set_cache_region, invalidate_region_cache)
5529 (revalidate_region_cache, know_region_cache, region_cache_forward)
5530 (region_cache_backward, pp_cache):
5531 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5532 so that ptrdiff_t * can be passed to xpalloc.
5533 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5534 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5535 (pp_cache): Don't assume cache_len fits in int.
5536 * region-cache.h: Adjust extern decls to match.
5537
5538 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5539 EMACS_INT, since either will do, for xpalloc.
5540
5541 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5542 (xnmalloc, xnrealloc, xpalloc): New functions.
5543
726e0ab1
PE
5544 * bidi.c (bidi_shelve_header_size): New constant.
5545 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5546 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5547
51f30bc5 5548 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5549 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5550 (overlay_strings):
5551 Don't update size of array until after memory allocation succeeds,
5552 because xmalloc/xrealloc may not return.
0065d054
PE
5553 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5554 now that we have proper integer overflow checking.
5555 (record_overlay_string, overlay_strings): Catch overflows when
5556 calculating size of overlay_str_buf.
726e0ab1 5557
0065d054
PE
5558 * callproc.c (Fcall_process): Check for size overflow when
5559 calculating size of args2.
5560 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5561 Normally we prefer signed values, but sticking with ptrdiff_t would
5562 require adding more-complicated checks.
726e0ab1
PE
5563
5564 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5565 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5566 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5567 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5568
5569 * character.c (Fstring): Check for size-calculation overflow.
5570
5571 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5572 unnecessary integer overflow. Check for size overflow.
5573 (encode_coding_object): Don't update size until xmalloc succeeds.
5574
5575 * composite.c (get_composition_id): Check for overflow in glyph
5576 length calculations.
5577
5578 Integer and memory overflow fixes for display code.
5579 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5580 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5581 (scrolling_window): Check for overflow in size calculations.
5582 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5583 Don't assume glyph table len fits in int.
5584 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5585 (row_table_size): Now ptrdiff_t, not int.
5586 (scrolling_window): Avoid overflow in size calculations.
5587 Don't update size until allocation succeeds.
5588 * fns.c (concat): Check for overflow in size calculations.
5589 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5590 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5591 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5592
5593 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5594 (get_doc_string): Check for size calculation overflow.
5595 Don't update size until allocation succeeds.
5596 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5597 EMACS_INT, where ptrdiff_t will do.
5598 (Fsubstitute_command_keys): Check for string overflow.
5599
5600 * editfns.c (set_time_zone_rule): Don't assume environment length
5601 fits in int.
5602 (message_length): Now ptrdiff_t, not int.
5603 (Fmessage_box): Don't update size until allocation succeeds.
5604 Don't assume message length fits in int.
5605 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5606
0065d054
PE
5607 * emacs.c (main): Do not reallocate argv, since there is a null at
5608 the end that can be overwritten, and this way there's no need to
5609 worry about size-calculation overflow.
5610 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5611
5612 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5613 alloc succeeds.
5614 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5615
5616 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5617 (x_set_scroll_bar_width, x_figure_window_size):
5618 Check for integer overflow.
5619 (x_set_alpha): Do not assume XINT fits in int.
5620
5621 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5622 This is for the members text_lines, text_cols, total_lines, total_cols,
5623 where the system imposes an 'int' limit.
5624
5625 * fringe.c (Fdefine_fringe_bitmap):
5626 Don't update size until alloc works.
5627
5628 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5629 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5630
5631 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5632 Check for size-calculation overflow.
5633 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5634 do, as we prefer signed integers.
5635 (id_to_widget.max_size, id_to_widget.used)
5636 (xg_store_widget_in_map, xg_remove_widget_from_map)
5637 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5638 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5639 Use and return ptrdiff_t, not int.
5640 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5641 * gtkutil.h: Change prototypes to match the above.
5642
5643 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5644 are duplicate now that they've been promoted to lisp.h.
5645 (x_allocate_bitmap_record, x_alloc_image_color)
5646 (make_image_cache, cache_image, xpm_load):
5647 Don't update size until alloc is done.
5648 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5649 (x_detect_edges):
3256efce 5650 Check for size calculation overflow.
726e0ab1
PE
5651 (ct_colors_allocated_max): New constant.
5652 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5653 overflow.
3256efce 5654
726e0ab1
PE
5655 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5656 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5657 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5658 Use ptrdiff_t, not int, to count maps.
5659 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5660 calculations. Don't update size until allocation succeeds.
5661 Redo calculations to avoid overflow.
726e0ab1
PE
5662 * keyboard.h: Change prototypes to match the above.
5663
5664 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5665 to count maps.
5666 (current_minor_maps): Check for size calculation overflow.
5667 * keymap.h: Change prototypes to match the above.
5668
5669 * lread.c (read1, init_obarray): Don't update size until alloc done.
5670
5671 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5672 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5673
726e0ab1
PE
5674 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5675 Now ptrdiff_t, not int.
5676 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5677 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5678
5679 * process.c (Fnetwork_interface_list): Check for overflow
5680 in size calculation.
5681
5682 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5683
5684 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5685 overflow. Don't bother calling xmalloc when xrealloc will do.
5686
5687 * search.c (Freplace_match): Check for size calculation overflow.
5688 (Fset_match_data): Don't assume list lengths fit in 'int'.
5689
5690 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5691 for command line length. Do not attempt to address one before the
5692 beginning of an array, as that's not portable.
5693
5694 * term.c (max_frame_lines): Remove; unused.
5695 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5696 not int.
5697 (encode_terminal_code, calculate_costs): Check for size
5698 calculation overflow.
5699 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5700 table lengths and related sizes. Don't update size until alloc
5701 done. Redo calculations to avoid overflow.
5702 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5703
5704 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5705 subtracting pointers.
5706 (gobble_line): Check for overflow more carefully. Don't update size
5707 until alloc done.
5708
5709 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5710 Don't update size until alloc done.
5711 Redo size calculations to avoid overflow.
5712 Check for size calculation overflow.
0065d054 5713 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5714
5715 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5716 Use ptrdiff_t, not int, for sizes.
5717 (store_mode_line_noprop_char): Don't update size until alloc done.
5718
0065d054
PE
5719 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5720 Use ptrdiff_t, not int, for sizes.
5721 (Finternal_make_lisp_face, cache_face):
5722 Check for size calculation overflow.
5723 (cache_face): Treat size calculation overflows as if they were
5724 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5725
5726 * xfns.c (x_encode_text, x_set_name_internal)
5727 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5728 sizes, since they can exceed INT_MAX in size. Check for size
5729 calculation overflow.
5730
0065d054
PE
5731 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5732 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5733 Don't update size until alloc done.
5734
0065d054 5735 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5736 as sprintf is limited to int lengths.
1d526e2f 5737
252c5ee1
PE
5738 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5739 (X_LONG_MIN): New macros.
864d7ce7
PE
5740 Use them to make the following changes clearer.
5741 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5742 This change doesn't affect the value now, but it may help remind
5743 future maintainers not to raise the value too much later.
5744 (SELECTION_QUANTUM): Remove, replacing with ...
5745 (selection_quantum): ... new function, which avoids overflow.
5746 All uses changed.
5747 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5748 assumption that selection length fits in 'int'.
5749 (x_reply_selection_request, x_handle_selection_request)
5750 (x_get_window_property, receive_incremental_selection)
5751 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5752 (lisp_data_to_selection_data, clean_local_selection_data):
5753 Use ptrdiff_t, not int, to record length of selection.
5754 (x_reply_selection_request, x_get_window_property)
5755 (receive_incremental_selection, x_property_data_to_lisp):
5756 Redo calculations to avoid overflow.
5757 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5758 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5759 something.
5760 (x_get_window_property, receive_incremental_selection)
5761 (lisp_data_to_selection_data, x_property_data_to_lisp):
5762 Check for size-calculation overflow.
5763 (x_get_window_property, receive_incremental_selection)
5764 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5765 Don't store size until memory allocation succeeds.
5766 (x_get_window_property): Plug memory leak on memory exhaustion.
5767 Don't double-block input; malloc is safe here. Don't assume 2**34
5768 - 4 fits in unsigned long. Add an xassert to check
5769 XGetWindowProperty overflow. Be more careful about overflow
5770 calculations, and distinguish size from memory overflow better.
5771 (receive_incremental_selection): When tracing, don't assume
5772 unsigned int is less than INT_MAX.
5773 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5774 harmful) conversions of unsigned short to int.
5775 (lisp_data_to_selection_data): Don't assume that integers
5776 in the range -65535 through -1 fit in an X unsigned short.
5777 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5778 result parameters unless successful. Rely on cons_to_unsigned
5779 to report problems with elements; the old code wasn't right anyway.
5780 (x_check_property_data): Check for int overflow; we cannot use
5781 a wider type due to X limits.
5782 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5783
726e0ab1 5784 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5785
0065d054
PE
5786 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5787 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5788 (x_color_cells): Don't store size until memory allocation succeeds.
5789 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5790 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5791 (x_term_init): Don't assume length fits in int (sprintf is limited
5792 to int size).
bc18e09d 5793
ebfa62c0
PE
5794 Use ptrdiff_t for composition IDs.
5795 * character.c (lisp_string_width):
5796 * composite.c (composition_table_size, n_compositions)
5797 (get_composition_id, composition_gstring_from_id):
5798 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5799 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5800 * window.c (Frecenter):
5801 Use ptrdiff_t, not int, for composition IDs.
5802 * composite.c (get_composition_id): Check for integer overflow.
5803 * composite.h: Adjust prototypes to match the above changes.
5804
d3411f89
PE
5805 Use ptrdiff_t for hash table indexes.
5806 * category.c (hash_get_category_set):
5807 * ccl.c (ccl_driver):
5808 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5809 * coding.c (coding_system_charset_list, detect_coding_system):
5810 * coding.h (struct coding_system.id):
5811 * composite.c (get_composition_id, gstring_lookup_cache):
5812 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5813 * image.c (xpm_get_color_table_h):
5814 * lisp.h (hash_lookup, hash_put):
5815 * minibuf.c (Ftest_completion):
5816 Use ptrdiff_t for hash table indexes, not int (which is too
5817 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5818 32-bit --with-wide-int hosts).
5819
e097a6fa
PE
5820 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5821 Add a FIXME comment about memory leaks.
5822 (syms_of_charset): Don't assume xmalloc returns.
5823
5637687f
PE
5824 Don't assume that stated character widths fit in int.
5825 * character.c (Fchar_width, c_string_width, lisp_string_width):
5826 * character.h (CHAR_WIDTH):
5827 * indent.c (MULTIBYTE_BYTES_WIDTH):
5828 Use sanitize_char_width to avoid undefined and/or bad behavior
5829 with outlandish widths.
a66cfb1c 5830 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5831 now that we have two such functions. All uses changed.
5832 (sanitize_char_width): New inline function.
5833
a2271ba2
PE
5834 Don't assume that tab-width fits in int.
5835 * character.h (sanitize_width): New inline function.
5836 (SANE_TAB_WIDTH): New macro.
5837 (ASCII_CHAR_WIDTH): Use it.
5838 * indent.c (sane_tab_width): Remove. All uses replaced by
5839 SANE_TAB_WIDTH (current_buffer).
5840 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5841
18c52557
PE
5842 * fileio.c: Integer overflow issues with file modes.
5843 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5844
caeeedc1
PE
5845 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5846 Remove unreachable code.
5847 (read_hex, load_charset_map_from_file): Check for integer overflow.
5848
6df6ae42 5849 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5850 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5851 (x_send_scroll_bar_event): Likewise. Check that the size does not
5852 exceed limits imposed by XClientMessageEvent, as well as the usual
5853 ptrdiff_t and size_t limits.
5854
b13995db
PE
5855 * keyboard.c: Overflow, signedness and related fixes.
5856 (make_lispy_movement): Use same integer type in forward decl
5857 that is used in the definition.
5858 (read_key_sequence, keyremap_step):
5859 Change bufsize argument back to int, undoing my 2011-03-30 change.
5860 We prefer signed types, and int is wide enough here.
5861 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5862 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5863 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5864 length, not size_t. Use ptrdiff_t for index, not int.
5865 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5866 possibility of integer overflow.
5867
13464394
PE
5868 Overflow, signedness and related fixes for images.
5869
5870 * dispextern.h (struct it.stack[0].u.image.image_id)
5871 (struct_it.image_id, struct image.id, struct image_cache.size)
5872 (struct image_cache.used, struct image_cache.ref_count):
5873 * gtkutil.c (update_frame_tool_bar):
5874 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5875 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5876 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5877 * nsmenu.m (update_frame_tool_bar):
5878 * xdisp.c (calc_pixel_width_or_height):
5879 * xfns.c (image_cache_refcount):
5880 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5881 on typical 64-bit hosts.
5882
5883 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5884 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5885 Omit unnecessary casts to int.
5886 (parse_image_spec): Check that integers fall into 'int' range
5887 when the callers expect that.
5888 (image_ascent): Redo ascent calculation to avoid int overflow.
5889 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5890 (lookup_image): Remove unnecessary tests.
5891 (xbm_image_p): Locals are now of int, not EMACS_INT,
5892 since parse_image_check makes sure they fit into int.
5893 (png_load, gif_load, svg_load_image):
5894 Prefer int to unsigned where either will do.
5895 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5896 old tiff_error_handler and tiff_warning_handler.
5897 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5898 stack buffer overflows. It uses only the features of vsnprintf
5899 that are common to both POSIX and native Microsoft.
5900 (tiff_error_handler, tiff_warning_handler): Use it.
5901 (tiff_load, gif_load, imagemagick_load_image):
5902 Don't assume :index value fits in 'int'.
5903 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5904 (imagemagick_load_image): Check that crop parameters fit into
5905 the integer types that MagickCropImage accepts. Don't assume
5906 Vimagemagick_render_type has a nonnegative value. Don't assume
5907 size_t fits in 'long'.
5908 (gs_load): Use printmax_t to print the widest integers possible.
5909 Check for integer overflow when computing image height and width.
5910
c11821d4
EZ
59112011-08-26 Eli Zaretskii <eliz@gnu.org>
5912
5913 * xdisp.c (redisplay_window): Don't force window start if point
5914 will be invisible in the resulting window. (Bug#9324)
5915
0c95fcf7
EZ
59162011-08-25 Eli Zaretskii <eliz@gnu.org>
5917
5918 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5919 the display spec is of the form `(space ...)'.
5920 (handle_display_spec): Return the value returned by
5921 handle_single_display_spec, not just 1 or zero.
5922 (handle_single_display_spec): If the display spec is of the form
5923 `(space ...)', and specifies display in the text area, return 2
5924 rather than 1.
fee65a97 5925 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5926 accurately, and prefer exact match for point under bidi.
5927 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5928
5929 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5930 into disp_prop; all users changed.
5931
5932 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5933 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5934 for the text covered by the display property.
5935
e4ed06f1
CY
59362011-08-25 Chong Yidong <cyd@stupidchicken.com>
5937
5938 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5939 Change return value to nil.
5940 (Frecord_buffer): Delete unused function.
5941
f67cdd7f
EZ
59422011-08-24 Eli Zaretskii <eliz@gnu.org>
5943
5980d4c6
EZ
5944 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5945 buffers, return left-to-right.
8610fe8b
EZ
5946 (set_cursor_from_row): Consider candidate row a win if its glyph
5947 represents a newline and point is on that newline. Fixes cursor
5948 positioning on the newline at EOL of R2L text within L2R
5949 paragraph, and vice versa.
5950 (try_cursor_movement): Check continued rows, in addition to
5951 continuation rows. Fixes unwarranted scroll when point enters a
5952 continued line of R2L text within an L2R paragraph, or vice versa.
5953 (cursor_row_p): Consider the case of point being equal to
5954 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5955 from the end of a short line to the beginning of a continued line
5956 of R2L text within L2R paragraph.
5957 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5958 composed characters.
5980d4c6 5959
f67cdd7f
EZ
5960 * bidi.c (bidi_check_type): Use xassert.
5961 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5962 members.
5963
bca633fb
EZ
59642011-08-23 Eli Zaretskii <eliz@gnu.org>
5965
5966 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5967 a character.
5968
4a5885a7
CY
59692011-08-23 Chong Yidong <cyd@stupidchicken.com>
5970
5971 * nsfont.m (ns_otf_to_script): Fix typo.
5972
0902a04e
KH
59732011-08-22 Kenichi Handa <handa@m17n.org>
5974
5975 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5976 extra slot even if the purpose is char-code-property-table.
5977
1a2e6670
EZ
59782011-08-23 Eli Zaretskii <eliz@gnu.org>
5979
8ddde651
EZ
5980 * xdisp.c (redisplay_window): When computing centering_position,
5981 account for the height of the header line. (Bug#8874)
5982
425cc014
EZ
5983 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5984 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5985 candidate is selected by the mouse, and that candidate has a
5986 composed character under the mouse.
5987
1a2e6670
EZ
5988 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5989 coordinates reported by pos-visible-in-window-p for a composed
5990 character in column zero.
5991
8b76d6f8
SM
59922011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5993
5994 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5995
dac347dd
EZ
59962011-08-22 Eli Zaretskii <eliz@gnu.org>
5997
5998 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5999 consider it a hit if to_charpos is anywhere in the range of the
6000 composed buffer positions.
6001
e013fb34
CY
60022011-08-22 Chong Yidong <cyd@stupidchicken.com>
6003
6004 * image.c (gif_load): Don't assume that each subimage has the same
6005 dimensions as the base image. Handle disposal method that is
6006 "undefined" by the gif spec (Bug#9335).
6007
bd1ba3e8
CY
60082011-08-20 Chong Yidong <cyd@stupidchicken.com>
6009
6010 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6011 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6012
54a1215b
EZ
60132011-08-19 Eli Zaretskii <eliz@gnu.org>
6014
823564e5
EZ
6015 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6016 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6017 from an Org mode buffer to a Speedbar frame.
6018
54a1215b
EZ
6019 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6020 a composition, take its buffer position from IT->cmp_it.charpos.
6021 Fixes cursor positioning at the beginning of a line that begins
6022 with a composed character.
6023
9778ebcc
EZ
60242011-08-18 Eli Zaretskii <eliz@gnu.org>
6025
0be6ee06
EZ
6026 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6027 character bidirectional type, use STRONG_L instead. Fixes crashes
6028 in a buffer produced by `describe-categories'.
6029
9778ebcc
EZ
6030 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6031 members before the level stack, so they would be saved and
6032 restored when copying iterator state. Fixes incorrect reordering
6033 around TABs covered by display properties.
6034
156bffbe
AS
60352011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6036
6b02f655 6037 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6038
72ad093b
CY
60392011-08-17 Chong Yidong <cyd@stupidchicken.com>
6040
6041 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6042 (internal_condition_case_2, internal_condition_case_n):
6043 Remove unnecessary aborts (Bug#9081).
72ad093b 6044
35774242
EZ
60452011-08-17 Eli Zaretskii <eliz@gnu.org>
6046
6047 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6048 has no `load' handler, try opening the file locally. (Bug#9311)
6049
db76dd85
KB
60502011-08-16 Ken Brown <kbrown@cornell.edu>
6051
6052 * gmalloc.c: Expand comment.
6053
b215eee5
EZ
60542011-08-16 Eli Zaretskii <eliz@gnu.org>
6055
6056 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6057 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6058
a4579d33
KB
60592011-08-16 Ken Brown <kbrown@cornell.edu>
6060
6061 Fix memory allocation problems in Cygwin build (Bug#9273).
6062
6063 * unexcw.c ( __malloc_initialized): Declare external variable.
6064 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6065
8b76d6f8
SM
6066 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6067 New variables.
a4579d33
KB
6068 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6069 dumped emacs.
6070 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6071 in the static heap.
6072 [CYGWIN] (special_realloc): New function.
6073 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6074 requests to realloc storage in the static heap.
6075
3ebec551
PE
60762011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6077
6078 * bidi.c (bidi_initialize): Remove unused local.
6079
9fd8be00
EZ
60802011-08-15 Eli Zaretskii <eliz@gnu.org>
6081
6b02f655
SM
6082 * bidimirror.h:
6083 * biditype.h: Remove file.
6084 * makefile.w32-in ($(BLD)/bidi.$(O)):
6085 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6086
6087 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6088
6089 * chartab.c: Improve commentary for the uniprop_table API.
6090
32413314
EZ
6091 * bidi.c (bidi_paragraph_init): Support zero value of
6092 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6093 (bidi_initialize): Use uniprop_table instead of including
6094 biditype.h and bidimirror.h.
32413314 6095
9fd8be00
EZ
6096 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6097 coordinates of the iterator when restoring from ppos_it.
6098 (Bug#9296)
6099
5cf2b69b
KH
61002011-08-14 Kenichi Handa <handa@m17n.org>
6101
6102 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6103 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6104
daf17d00
EZ
61052011-08-14 Eli Zaretskii <eliz@gnu.org>
6106
6107 * xdisp.c (move_it_in_display_line_to): Don't invoke
6108 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6109 ppos_it. Fixes vertical cursor motion when line beginning is
6110 covered by an image. (Bug#9296)
6111
08e3161a
JD
61122011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6113
6114 * nsterm.h (ns_run_ascript): Declare.
6115 (NSAPP_DATA2_RUNASSCRIPT): Define.
6116
6117 * nsfns.m (as_script, as_result, as_status): New static variables.
6118 (ns_run_ascript): New function.
5e617bc2 6119 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6120 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6121 the event loop. Get status from as_status (Bug#7276).
6122
6123 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6124 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6125 the event loop (Bug#7276).
6126
a3720aa2
AS
61272011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6128
6129 * gnutls.c (QCgnutls_bootprop_priority)
6130 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6131 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6132 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6133 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6134 (QCgnutls_bootprop_verify_hostname_error)
6135 (QCgnutls_bootprop_callbacks_verify): Rename from
6136 Qgnutls_bootprop_..., all uses changed.
6137
6138 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6139 uses changed.
6140
0a0d27fb
PE
61412011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6142
19d5c50c
PE
6143 * xfaces.c (Qframe_set_background_mode): Now static.
6144 * dispextern.h (Qframe_set_background_mode): Remove decl.
6145
0a0d27fb
PE
6146 * process.c (Fnetwork_interface_info): Declare local only if needed.
6147
377538cb
JD
61482011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6149
6150 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6151 (Fnetwork_interface_list): Allocate in increments of bytes instead
6152 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6153 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6154 sockaddr.
6155 (struct ifflag_def): notrailers is smart on OSX.
6156 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6157 Get hardware address with getifaddrs if available.
6158
08fff70c
EZ
61592011-08-12 Eli Zaretskii <eliz@gnu.org>
6160
6161 * xdisp.c (iterate_out_of_display_property): xassert that
6162 IT->position is set to within IT->object's boundaries. Break from
6163 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6164 when IT->position is set up wrongly due to some bug.
6165 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6166 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6167 entry. Force push_it to save on the stack the current
6168 buffer/string position, to be restored by pop_it. Fix flags in
6169 the iterator structure wrt the object coming from a display
6170 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6171 properties. (Bug#9284)
6172
7be1c708 61732011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6174
7be1c708
CY
6175 * fontset.c (fontset_get_font_group): Add proper type checks.
6176 (Bug#9172)
aac0c6e3 6177
7be1c708 61782011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6179
7be1c708
CY
6180 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6181 and LC_VERSION_MIN_MACOSX.
6182 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6183 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6184
97bb72a6
EZ
61852011-08-08 Eli Zaretskii <eliz@gnu.org>
6186
6187 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6188 no-display-properties-and-no-overlays under bidi display.
6189 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6190 properties and overlays.
97bb72a6 6191
d5617611
CY
61922011-08-08 Chong Yidong <cyd@stupidchicken.com>
6193
37e11a63
CY
6194 * editfns.c (Fset_time_zone_rule): Document relationship with the
6195 setenv function.
6196
d5617611
CY
6197 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6198 the font entity extracted from the cache (Bug#8109).
6199
58872834
CY
62002011-08-07 Chong Yidong <cyd@stupidchicken.com>
6201
6202 * composite.c (autocmp_chars): Don't reset point. That is done by
6203 restore_point_unwind (Bug#5984).
6204
75bfc667
JL
62052011-08-07 Juri Linkov <juri@jurta.org>
6206
6207 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6208 to show the arg `TIME' instead of `TIMEVAL'.
6209
d1410150
EZ
62102011-08-06 Eli Zaretskii <eliz@gnu.org>
6211
6212 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6213 display property strides EOL and includes a newline, as in
6214 longlines-mode. (Bug#9254)
75b771e4
EZ
6215 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6216 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6217
6218 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6219 is non-zero, even if the data buffer is NULL. Fixes a crash in
6220 vertical-motion with longlines-mode. (Bug#9254)
6221
35928349
EZ
62222011-08-05 Eli Zaretskii <eliz@gnu.org>
6223
ec7cc85b
EZ
6224 * bidi.c <bidi_cache_total_alloc>: Now static.
6225 (bidi_initialize): Initialize bidi_cache_total_alloc.
6226
8b76d6f8 6227 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6228 cache. (Bug#9221)
6229
6230 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6231 amount allocated this far in `bidi_cache_total_alloc'.
6232 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6233 non-zero, only free the data buffer without restoring the cache
6234 contents. All callers changed.
6235
6236 * dispextern.h (bidi_unshelve_cache): Update prototype.
6237
6238 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6239 (move_it_in_display_line, move_it_to)
6240 (move_it_vertically_backward, move_it_by_lines): Replace the call
6241 to xfree to an equivalent call to bidi_unshelve_cache.
6242 (move_it_in_display_line_to): Fix logic of returning
412b6358 6243 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6244
e2e2423b
EZ
62452011-08-05 Eli Zaretskii <eliz@gnu.org>
6246
6247 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6248 came from a string character with a `cursor' property. (Bug#9229)
6249
ae9e757a
JD
62502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6251
6252 * Makefile.in (LIB_PTHREAD): New variable.
6253 (LIBES): Add LIB_PTHREAD (Bug#9216).
6254
6255 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6256 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6257
213bd7f2
AS
62582011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6259
6b02f655 6260 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6261
99aaf75f
JD
62622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6263
6264 * xterm.c (x_find_topmost_parent): New function.
6265 (x_set_frame_alpha): Find topmost parent window with
6266 x_find_topmost_parent and set the property there also (bug#9181).
6267 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6268
c74e9d86
PE
62692011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6270
6271 * callproc.c (Fcall_process): Avoid vfork clobbering
6272 the local vars buffer, coding_systems, current_dir.
6273
640c8776
SM
62742011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6275
6276 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6277
f26d0e4c
PE
62782011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6279
8a10d76c
PE
6280 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6281 so that it is not optimized away.
6282
f26d0e4c
PE
6283 * xdisp.c (compute_display_string_pos): Remove unused local.
6284
55439c61
EZ
62852011-08-02 Eli Zaretskii <eliz@gnu.org>
6286
6287 Fix slow cursor motion and scrolling in large buffers with
6288 selective display, like Org Mode buffers. (Bug#9218)
6289
6290 * dispextern.h (struct bidi_it): New member disp_prop_p.
6291
6292 * xdisp.c: Remove one-slot cache of display string positions.
6293 (compute_display_string_pos): Accept an additional argument
5e617bc2 6294 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6295 for a display string or property. If found, set DISP_PROP_P
6296 non-zero.
6297
6298 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6299 DISP_PROP_P, and pass it to compute_display_string_pos.
6300 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6301 non-zero. All callers of bidi_fetch_char changed.
6302
fb33fa43
SM
63032011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6304
6305 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6306
b099e063
DM
63072010-12-03 Don March <don@ohspite.net>
6308
6309 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6310 last character M-[char] is translated to ESC [char] (bug#7541).
6311
5cc7f7af
KH
63122011-08-02 Kenichi Handa <handa@m17n.org>
6313
d0fffa3f 6314 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6315
6316 * chartab.c (uniprop_table): Make it non-static.
6317
525d5e6e
EZ
63182011-08-01 Eli Zaretskii <eliz@gnu.org>
6319
6320 * xdisp.c (forward_to_next_line_start): Accept additional argument
6321 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6322 on the newline.
6323 (reseat_at_next_visible_line_start): Use the bidi iterator state
6324 returned by forward_to_next_line_start to restore the state of
6325 it->bidi_it after backing up to previous newline. (Bug#9212)
6326
31011111
AS
63272011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6328
6329 * regex.c (re_comp): Protoize.
6330 (re_exec): Fix return type.
6331 (regexec): Fix type of `ret'. (Bug#9203)
6332
476371c4
PE
63332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6334
e5d76069
PE
6335 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6336 This is needed if max-image-size is a floating-point number.
6337
9a79b20c
AS
63382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6339
6340 * print.c (print_object): Print empty symbol as ##.
6341
6342 * lread.c (read1): Read ## as empty symbol.
6343
d8c2fa78
AA
63442011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6345
6346 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6347 setting frame foreground color (Bug#9175).
6348 (x_set_background_color): Likewise.
6349
ffe57a7a
AA
6350 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6351 contents (Bug#9176).
6352 (EmacsTooltip -init): Remove bezels and add shadows to
6353 tooltip windows.
6354
bf3492a5
AA
6355 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6356 or scroll bar (Bug#8470).
6357
d55e9c53
AA
6358 * nsfont.m (nsfont_open): Remove assignment to voffset and
6359 unnecessary vars hshink, expand, hd, full_height, min_height.
6360 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6361
6362 * nsterm.h (nsfont_info): Remove voffset field.
6363
d8c2fa78 63642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6365
6366 Implement strike-through and overline on NextStep (Bug#8863).
6367
6368 * nsfont.m (nsfont_open): Use underline position provided by font,
6369 instead of hard-coded value of 2.
6370 (nsfont_draw): Call ns_draw_text_decoration instead.
6371
6372 * nsterm.h: Add declaration for ns_draw_text_decoration.
6373
6374 * nsterm.m (ns_draw_text_decoration): New function for drawing
6375 underline, overline, and strike-through.
6376 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6377 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6378 accommodate underlining, etc.
4843aac3 6379
4cc60b9b
EZ
63802011-07-28 Eli Zaretskii <eliz@gnu.org>
6381
bc7ece87
EZ
6382 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6383 default.
4cc60b9b 6384
476371c4
PE
63852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6386
66606eea
PE
6387 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6388 Without this fix, if a signal arrives just after memory fills up,
6389 'malloc' might be invoked reentrantly.
6390
476371c4
PE
6391 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6392 In other words, assume that every image size is allowed, on non-X
6393 hosts. This assumption is probably wrong, but it lets Emacs compile.
6394
f3fcc40d
AS
63952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6396
6397 * regex.c (re_iswctype): Convert return values to boolean.
6398
350c992f
EZ
63992011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6400
6401 * xdisp.c (compute_display_string_pos): Don't use cached display
6402 string position if the buffer had its restriction changed.
6403 (Bug#9184)
6404
5266b4bb
PE
64052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6406
6407 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6408
2573a837 64092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6410
41f55ccd 6411 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6412
39e378da
PE
6413 * bidi.c: Integer size and overflow fixes.
6414 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6415 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6416 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6417 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6418 (bidi_find_other_level_edge):
6419 Use ptrdiff_t instead of EMACS_INT where either will do.
6420 This works better on 32-bit hosts configured --with-wide-int.
6421 (bidi_cache_ensure_space): Check for size-calculation overflow.
6422 Use % rather than repeated addition, for better worst-case speed.
6423 Don't set bidi_cache_size until after xrealloc returns, because it
6424 might not return.
6425 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6426 (bidi_cache_ensure_space): Also check that the bidi cache size
6427 does not exceed that of the largest Lisp string or buffer. See Eli
6428 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6429
5e927815
PE
6430 * alloc.c (__malloc_size_t): Remove.
6431 All uses replaced by size_t. See Andreas Schwab's note
6432 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6433
ca4aa935
PE
6434 * image.c: Improve checking for integer overflow.
6435 (check_image_size): Assume that f is nonnull, since
6436 it is always nonnull in practice. This is one less thing to
6437 worry about when checking for integer overflow later.
6438 (x_check_image_size): New function, which checks for integer
6439 overflow issues inside X.
6440 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6441 This removes the need for a memory_full check.
6442 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6443 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6444 (xbm_read_bitmap_data): Change locals back to 'int', since
6445 their values must fit in 'int'.
6446 (xpm_load_image, png_load, tiff_load):
6447 Invoke x_create_x_image_and_pixmap earlier,
6448 to avoid much needless work if the image is too large.
6449 (tiff_load): Treat overly large images as if
6450 x_create_x_image_and_pixmap failed, not as malloc failures.
6451 (gs_load): Use x_check_image_size.
6452
5f8f9cc2
PE
6453 * gtkutil.c: Omit integer casts.
6454 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6455 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6456
5adf60bc
PE
6457 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6458
c8907a93
PE
6459 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6460 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6461 would wrongly return t on a 64-bit host.
6462
e3c25c68
PE
6463 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6464 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6465 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6466 and therefore cause GCC to emit a bogus diagnostic in some cases.
6467
3f791afe
PE
6468 * image.c: Integer signedness and overflow and related fixes.
6469 This is not an exhaustive set of fixes, but it's time to
6470 record what I've got.
6471 (lookup_pixel_color, check_image_size): Remove redundant decls.
6472 (check_image_size): Don't assume that arbitrary EMACS_INT values
6473 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6474 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6475 (tiff_load, imagemagick_load_image):
6476 Check for overflow in size calculations.
6477 (x_create_x_image_and_pixmap): Remove unnecessary test for
6478 xmalloc returning NULL; that can't happen.
6479 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6480 (xpm_color_bucket): Use better integer hashing function.
6481 (xpm_cache_color): Don't possibly over-allocate memory.
6482 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6483 (gif_memory_source):
6484 Use ptrdiff_t, not int or size_t, to record sizes.
6485 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6486 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6487 either works, as we prefer signed integers.
6488 (tiff_read_from_memory, tiff_write_from_memory):
6489 Return tsize_t, not size_t, since that's what the TIFF API wants.
6490 (tiff_read_from_memory): Don't fail simply because the read would
6491 go past EOF; instead, return a short read.
6492 (tiff_load): Omit no-longer-needed casts.
6493 (Fimagemagick_types): Don't assume size fits into 'int'.
6494
3cc5a532
PE
6495 Improve hashing quality when configured --with-wide-int.
6496 * fns.c (hash_string): New function, taken from sxhash_string.
6497 Do not discard information about ASCII character case; this
6498 discarding is no longer needed.
6499 (sxhash-string): Use it. Change sig to match it. Caller changed.
6500 * lisp.h: Declare it.
6501 * lread.c (hash_string): Remove, since we now use fns.c's version.
6502 The fns.c version returns a wider integer if --with-wide-int is
6503 specified, so this should help the quality of the hashing a bit.
6504
b312a492
PE
6505 * emacs.c: Integer overflow minor fix.
6506 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6507 Define only if GNU_LINUX.
6508 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6509
dfd153ae
PE
6510 * dispnew.c: Integer signedness and overflow fixes.
6511 Remove unnecessary forward decls, that were a maintenance hassle.
6512 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6513 All uses changed.
6514 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6515 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6516 (prepare_desired_row, line_draw_cost):
6517 Use int, not unsigned, where either works.
6518 (save_current_matrix, restore_current_matrix):
6519 Use ptrdiff_t, not size_t, where either works.
6520 (init_display): Check for overflow more accurately, and without
6521 relying on undefined behavior.
6522
a81d11a3
PE
6523 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6524 Remove, replacing with the new symbols in lisp.h. All uses changed.
6525 * fileio.c (make_temp_name):
6526 * filelock.c (lock_file_1, lock_file):
6527 * xdisp.c (message_dolog):
6528 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6529 Use pMd etc. instead.
6530 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6531 replacing the pWIDE etc. symbols removed from editfns.c.
6532
3300e6fd
PE
6533 * keyboard.h (num_input_events): Now uintmax_t.
6534 This is (very slightly) less likely to mess up due to wraparound.
6535 All uses changed.
6536
fd05c7e9
PE
6537 * buffer.c: Integer signedness fixes.
6538 (alloc_buffer_text, enlarge_buffer_text):
6539 Use ptrdiff_t rather than size_t when either will do, as we prefer
6540 signed integers.
6541
903fe15d
PE
6542 * alloc.c: Integer signedness and overflow fixes.
6543 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6544 (__malloc_size_t): Default to size_t, not to int.
6545 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6546 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6547 Prefer ptrdiff_t to size_t when either would do, as we prefer
6548 signed integers.
6549 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6550 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6551 Now const. Initialize with values that are in range even if char
6552 is signed.
6553 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6554 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6555 These functions do the right thing with sizes > 2**32.
6556 (check_depth): Now ptrdiff_t, not int.
6557 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6558 Adjust to new way of storing sizes. Check for size overflow bugs
6559 in rest of code.
6560 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6561 slightly wrong anyway, as it missed one instance of
6562 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6563 (refill_memory_reserve): Omit needless cast to size_t.
6564 (mark_object_loop_halt): Mark as externally visible.
6565
ac82cc6a
PE
6566 * xselect.c: Integer signedness and overflow fixes.
6567 (Fx_register_dnd_atom, x_handle_dnd_message):
6568 Use ptrdiff_t, not size_t, since we prefer signed.
6569 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6570 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6571 x_dnd_atoms_size and x_dnd_atoms_length.
6572
c2d1e36d
PE
6573 * doprnt.c: Prefer signed to unsigned when either works.
6574 * eval.c (verror):
6575 * doprnt.c (doprnt):
6576 * lisp.h (doprnt):
6577 * xdisp.c (vmessage):
6578 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6579 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6580 prefer signed arithmetic to avoid comparison confusion.
6581 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6582 but is a bit tricky.
6583
0e926e56
PE
6584 Assume freestanding C89 headers, string.h, stdlib.h.
6585 * data.c, doprnt.c, floatfns.c, print.c:
6586 Include float.h unconditionally.
6587 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6588 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6589 * regex.c: Likewise for stddef.h, string.h.
6590 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6591 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6592 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6593 (STDC_HEADERS): Remove obsolete defines.
6594 * sysdep.c: Include limits.h unconditionally.
6595
9cfdb3ec
PE
6596 Assume support for memcmp, memcpy, memmove, memset.
6597 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6598 * regex.c (memcmp, memcpy):
6599 Remove; we assume C89 now.
6600
6601 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6602 (__malloc_safe_bcopy): Remove; no longer needed.
6603
cf950e6b 6604 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6605 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6606 well either way, and we prefer signed to unsigned.
6607
dbf38e02
LMI
66082011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6609
6610 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6611 closes the connection while we're reading (bug#9182).
6612
d6f0886c 66132011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6614
d6f0886c
JD
6615 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6616 are specified (Bug#9168).
24e0f6b1 6617
2eb1f9e6
PE
66182011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6619
6620 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6621 Found by GCC static checking and --with-wide-int on a 32-bit host.
6622
22381272 66232011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6624
6625 * xdisp.c (compute_display_string_pos): Fix logic of caching
6626 previous display string position. Initialize cached_prev_pos to
6627 -1. Fixes slow-down at the beginning of a buffer.
6628
f25e39b4
EZ
66292011-07-24 Eli Zaretskii <eliz@gnu.org>
6630
6631 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6632 for attrs[LFACE_FONTSET_INDEX].
6633
04c4b52e
PE
66342011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6635
6636 * xml.c (parse_region): Remove unused local
6637 that was recently introduced.
6638
c1734fbd
EZ
66392011-07-23 Eli Zaretskii <eliz@gnu.org>
6640
be18c5a5
EZ
6641 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6642 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6643
c1734fbd
EZ
6644 * xdisp.c (move_it_in_display_line_to): Record the best matching
6645 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6646 exit if none of the characters scanned was an exact match.
6647 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6648 when exact match is impossible due to invisible text, and the
6649 lines are truncated.
6650
a258d627
JD
66512011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6652
6653 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6654 for OSX >= 10.7.
6655
b6d5a689
EZ
66562011-07-22 Eli Zaretskii <eliz@gnu.org>
6657
0f74f785
EZ
6658 Fix a significant slow-down of cursor motion with C-n, C-p,
6659 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6660 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6661 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6662 (next_element_from_buffer): Call compute_stop_pos_backwards to
6663 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6664 base_level_stop.
6665 (reseat): Don't look for prev_stop, as that could mean a very long
6666 run.
6667 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6668 <cached_disp_overlay_modiff>: Cache for last found display string
6669 position.
551918c1 6670 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6671 about the same buffer in the same area of character positions, and
6672 the buffer wasn't changed since the time the display string
6673 position was cached.
551918c1 6674
b2d0c91a
EZ
66752011-07-22 Eli Zaretskii <eliz@gnu.org>
6676
6677 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6678 is an integer, which is important for empty lines. (Bug#9149)
6679
043604ee
CY
66802011-07-22 Chong Yidong <cyd@stupidchicken.com>
6681
6682 * frame.c (Fmodify_frame_parameters): In tty case, update the
6683 default face if necessary (Bug#4238).
6684
da4adb04
CY
66852011-07-21 Chong Yidong <cyd@stupidchicken.com>
6686
6687 * editfns.c (Fstring_to_char): No need to explain what a character
6688 is in the docstring (Bug#6576).
6689
9abd0532
LMI
66902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6691
6692 * xml.c (parse_region): Make sure we always return a tree.
6693
36881d16
HK
66942011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6695
6696 * xml.c (parse_region): If a document contains only comments,
6697 return that, too.
6698
1e98674d
LMI
66992011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6700
6701 * xml.c (make_dom): Return comments, too.
6702
590bd467
PE
67032011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6704
6705 Port to OpenBSD.
6706 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6707 and the surrounding thread.
6708 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6709 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6710 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6711 timer goes off.
6712 * s/openbsd.h (BROKEN_SIGIO): Define.
6713 * unexelf.c (unexec) [__OpenBSD__]:
6714 Don't update the .mdebug section of the Alpha COFF symbol table.
6715
f41628b2
LMI
67162011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6717
6718 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6719 (bug#8460).
6720
b59b67c5
PE
67212011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6722
15e3a074
PE
6723 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6724 This fixes some race conditions on the permissions of any newly
6725 created file.
6726
41bed37d
PE
6727 * alloc.c (valid_pointer_p): Use pipe, not open.
6728 This fixes some permissions issues when debugging.
6729
b59b67c5
PE
6730 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6731 If fchown fails to set both uid and gid, try to set just gid,
6732 as that is sometimes allowed. Adjust the file's mode to eliminate
6733 setuid or setgid bits that are inappropriate if fchown fails.
6734
925a6be7
SM
67352011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6736
6737 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6738 to compare Lisp_Objects.
6739 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6740 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6741 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6742
52968808
AS
67432011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6744
0a6a104b
AS
6745 * lread.c (read_integer): Unread even EOF character.
6746 (read1): Likewise. Properly record start position of symbol.
6747
52968808
AS
6748 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6749 symbol character follows.
6750
9e381cdd
PE
67512011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6752
6753 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6754 This works around a problem with the previous change to Fcopy_file.
6755 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6756 and without this change, GCC might complain about discarding
6757 fchown's return value.
6758
b5641435
JB
67592011-07-16 Juanma Barranquero <lekktu@gmail.com>
6760
6761 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6762
a8031457
PE
67632011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6764
6765 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6766
dd889327
LMI
67672011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6768
750c33f7
LMI
6769 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6770 it's used from the C level.
6771
dd889327
LMI
6772 * process.c: Use the same condition for POLL_FOR_INPUT in both
6773 keyboard.c and process.c (bug#1858).
6774
87e86684
LM
67752011-07-09 Lawrence Mitchell <wence@gmx.li>
6776
6777 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6778 (Fgnutls_boot): Use it.
6779
64348f40
AS
67802011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6781
6782 * doc.c (Fsubstitute_command_keys): Revert last change.
6783
1d698799
LMI
67842011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6785
f863868c
LMI
6786 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6787 quotes the next character, and doesn't affect other longer
6788 sequences (bug#8935).
6789
1d698799
LMI
6790 * lread.c (syms_of_lread): Clarify that is isn't only
6791 `eval-buffer' and `eval-defun' that's affected by
6792 `lexical-binding' (bug#8460).
6793
aa4b6df6
EZ
67942011-07-15 Eli Zaretskii <eliz@gnu.org>
6795
6796 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6797 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6798
5d856da6
PE
67992011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6800
ad6042bb
PE
6801 Fix minor problems found by static checking.
6802 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6803 (elsz): Now a signed constant, not a size_t var. We prefer signed
6804 types to unsigned, to avoid integer comparison confusion. Without
6805 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6806 "cannot optimize loop, the loop counter may overflow", a symptom
6807 of the confusion.
f00bbb22 6808 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6809 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6810
6468f31c
LMI
68112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6812
49080b10
LMI
6813 * search.c (Fre_search_backward): Mention `case-fold-search' in
6814 all the re_search_* functions (bug#8138).
6815
6468f31c
LMI
6816 * keyboard.c (Fopen_dribble_file): Document when the file is
6817 closed (bug#8056).
6818
c965adc5
EZ
68192011-07-14 Eli Zaretskii <eliz@gnu.org>
6820
df9733bf
EZ
6821 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6822 bidi_cache_idx.
6823
0bb23927
EZ
6824 Support bidi reordering of display and overlay strings.
6825 * xdisp.c (compute_display_string_pos)
6826 (compute_display_string_end): Accept additional argument STRING.
6827 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6828 (reseat_to_string): Initialize bidi_it->string.s and
6829 bidi_it->string.schars.
6830 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6831 NULL (avoids a crash in bidi_paragraph_init).
6832 Initialize itb.string.lstring.
0bb23927
EZ
6833 (init_iterator): Call bidi_init_it only of a valid
6834 buffer position was specified. Initialize paragraph_embedding to
6835 L2R.
6836 (reseat_to_string): Initialize the bidi iterator.
6837 (display_string): If we need to ignore text properties of
6838 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6839 original value of -1 will not work with bidi.)
6840 (compute_display_string_pos): First arg is now struct
6841 `text_pos *'; all callers changed. Support display properties on
6842 Lisp strings.
6843 (compute_display_string_end): Support display properties on Lisp
6844 strings.
6845 (init_iterator, reseat_1, reseat_to_string): Initialize the
6846 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6847 when iterating on a string not from display properties).
640c8776
SM
6848 (compute_display_string_pos, compute_display_string_end):
6849 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6850 arrow keys.
6851 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6852 base_level_stop; instead, set base_level_stop to BEGV.
6853 Fixes crashes in vertical-motion.
0bb23927
EZ
6854 (next_element_from_buffer): Improve commentary for when
6855 the iterator is before prev_stop.
6856 (init_iterator): Initialize bidi_p from the default value of
6857 bidi-display-reordering, not from buffer-local value. Use the
6858 buffer-local value only if initializing for buffer iteration.
6859 (handle_invisible_prop): Support invisible properties on strings
6860 that are being bidi-reordered.
6861 (set_iterator_to_next): Support bidi reordering of C strings and
6862 Lisp strings.
6863 (next_element_from_string): Support bidi reordering of Lisp
6864 strings.
6865 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6866 (display_string): Support display of R2L glyph rows.
6867 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6868 (init_iterator): Don't initialize it->bidi_p for strings
6869 here.
6870 (reseat_to_string): Initialize it->bidi_p for strings here.
6871 (next_element_from_string, next_element_from_c_string)
6872 (next_element_from_buffer): Add xassert's for correspondence
6873 between IT's object being iterated and it->bidi_it.string
6874 structure.
6875 (face_before_or_after_it_pos): Support bidi iteration.
6876 (next_element_from_c_string): Handle the case of the first string
6877 character that is not the first one in the visual order.
6878 (get_visually_first_element): New function, refactored from common
6879 parts of next_element_from_buffer, next_element_from_string, and
6880 next_element_from_c_string.
6881 (tool_bar_lines_needed, redisplay_tool_bar)
6882 (display_menu_bar): Force left-to-right direction. Add a FIXME
6883 comment for making that be controlled by a user option.
6884 (push_it, pop_it): Save and restore the state of the
6885 bidi iterator. Save and restore the bidi_p flag.
6886 (pop_it): Iterate out of display property for string iteration as
6887 well.
6888 (iterate_out_of_display_property): Support iteration over strings.
6889 (handle_single_display_spec): Set up it->bidi_it for iteration
6890 over a display string, and call bidi_init_it.
6891 (handle_single_display_spec, next_overlay_string)
6892 (get_overlay_strings_1, push_display_prop): Set up the bidi
6893 iterator for displaying display or overlay strings.
6894 (forward_to_next_line_start): Don't use the shortcut if
6895 bidi-iterating.
6896 (back_to_previous_visible_line_start): If handle_display_prop
6897 pushed the iterator stack, restore the internal state of the bidi
6898 iterator by calling bidi_pop_it same number of times.
6899 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6900 and we are bidi-iterating, don't decrement the iterator position;
6901 instead, set the first_elt flag in the bidi iterator, to produce
6902 the same effect.
6903 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6904 (push_display_prop): xassert that we are iterating a buffer.
6905 (push_it, pop_it): Save and restore paragraph_embedding member.
6906 (handle_single_display_spec, next_overlay_string)
6907 (get_overlay_strings_1, reseat_1, reseat_to_string)
6908 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6909 correctly. Don't assume unibyte strings are not bidi-reordered.
6910 (compute_display_string_pos)
6911 (compute_display_string_end): Fix handling the case of C string.
6912 (push_it, pop_it): Save and restore from_disp_prop_p.
6913 (handle_single_display_spec, push_display_prop): Set the
6914 from_disp_prop_p flag.
6915 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6916 (pop_it): Call iterate_out_of_display_property only if we are
6917 popping after iteration over a string that came from a display
6918 property. Fix a typo in popping stretch info. Add an assertion
6919 for verifying that the iterator position is in sync with the bidi
6920 iterator.
6921 (handle_single_display_spec, get_overlay_strings_1)
6922 (push_display_prop): Fix initialization of paragraph direction for
6923 string when that of the parent object is not yet determined.
6924 (reseat_1): Call bidi_init_it to resync the bidi
6925 iterator with IT's position. (Bug#7616)
6926 (find_row_edges): If ROW->start.pos gives position
6927 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6928 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6929 Reset the from_disp_prop_p flag.
6930 (SAVE_IT, RESTORE_IT): New macros.
6931 (pos_visible_p, face_before_or_after_it_pos)
6932 (back_to_previous_visible_line_start)
6933 (move_it_in_display_line_to, move_it_in_display_line)
6934 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6935 (try_scrolling, redisplay_window, display_line): Use them when
6936 saving a temporary copy of the iterator and restoring it back.
6937 (back_to_previous_visible_line_start, reseat_1)
6938 (init_iterator): Empty the bidi cache "stack".
6939 (move_it_in_display_line_to): If iterator ended up at
6940 EOL, but we never saw any buffer positions smaller than
6941 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6942 motion in bidi-reordered lines.
6943 (move_it_in_display_line_to): Record prev_method and prev_pos
6944 immediately before the call to set_iterator_to_next. Fixes cursor
6945 motion in bidi-reordered lines with stretch glyphs and strings
6946 displayed in margins. (Bug#8133) (Bug#8867)
6947 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6948 TO_CHARPOS.
640c8776
SM
6949 (pos_visible_p): Support positions in bidi-reordered lines.
6950 Save and restore bidi cache.
0bb23927
EZ
6951
6952 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6953 (bidi_paragraph_info): Delete unused struct.
6954 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6955 (bidi_cache_start): New variable.
6956 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6957 to zero.
6958 (bidi_cache_fetch_state, bidi_cache_search)
6959 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6960 (bidi_cache_find, bidi_peek_at_next_level)
6961 (bidi_level_of_next_char, bidi_find_other_level_edge)
6962 (bidi_move_to_visually_next): Compare cache index with
6963 bidi_cache_start rather than with zero.
6964 (bidi_fetch_char): Accept new argument STRING; all callers
6965 changed. Support iteration over a string. Support strings with
6966 display properties. Support unibyte strings. Fix the type of
6967 `len' according to what STRING_CHAR_AND_LENGTH expects.
6968 (bidi_paragraph_init, bidi_resolve_explicit_1)
6969 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6970 (bidi_level_of_next_char, bidi_move_to_visually_next):
6971 Support iteration over a string.
0bb23927
EZ
6972 (bidi_set_sor_type, bidi_resolve_explicit_1)
6973 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6974 can now be zero (for strings); special values 0 and -1 were
6975 changed to -1 and -2, respectively.
6976 (bidi_char_at_pos): New function.
6977 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6978 Call it instead of FETCH_MULTIBYTE_CHAR.
6979 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6980 initialized to valid values.
6981 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6982 values.
6983 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6984 the test for valid cached positions. Fix the logic for looking up
6985 the sentinel state in the cache. GCPRO the Lisp string we are
6986 iterating.
6987 (bidi_push_it, bidi_pop_it): New functions.
6988 (bidi_initialize): Initialize the bidi cache start stack pointer.
6989 (bidi_cache_ensure_space): New function, refactored from part of
6990 bidi_cache_iterator_state. Don't assume the required size is just
6991 one BIDI_CACHE_CHUNK away.
6992 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6993 (bidi_count_bytes, bidi_char_at_pos): New functions.
6994 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6995 always valid if bidi_cache_idx is valid.
6996 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6997 is valid if it's going to be used.
6998 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6999 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7000 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7001 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7002 (bidi_find_other_level_edge, bidi_cache_start_stack):
7003 All variables related to cache indices are now EMACS_INT.
c965adc5 7004
0bb23927
EZ
7005 * dispextern.h (struct bidi_string_data): New structure.
7006 (struct bidi_it): New member `string'. Make flag members be 1-bit
7007 fields, and put them last in the struct.
640c8776
SM
7008 (compute_display_string_pos, compute_display_string_end):
7009 Update prototypes.
0bb23927
EZ
7010 (bidi_push_it, bidi_pop_it): Add prototypes.
7011 (struct iterator_stack_entry): New members bidi_p,
7012 paragraph_embedding, and from_disp_prop_p.
7013 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7014 (bidi_shelve_cache, bidi_unshelve_cache):
7015 Declare prototypes.
0bb23927
EZ
7016
7017 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7018 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7019 and vector-like objects.
7020
7021 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7022 cache around display iteration.
7023
7024 * window.c (Fwindow_end, window_scroll_pixel_based)
7025 (displayed_window_lines, Frecenter): Save and restore the bidi
7026 cache around display iteration.
7027
3bbd2265
LMI
70282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7029
7030 * editfns.c (Fdelete_region): Clarify the use of the named
7031 parameters (bug#6788).
7032
adc47434
MR
70332011-07-14 Martin Rudalics <rudalics@gmx.at>
7034
7035 * indent.c (Fvertical_motion): Set and restore w->pointm when
7036 saving and restoring the window's buffer (Bug#9006).
7037
837c31f8
LMI
70382011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7039
7040 * editfns.c (Fstring_to_char): Clarify just what is returned
7041 (bug#6576). Text by Eli Zaretskii.
7042
ac389d0c
JB
70432011-07-13 Juanma Barranquero <lekktu@gmail.com>
7044
7045 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7046
0be0ce47
EZ
70472011-07-13 Eli Zaretskii <eliz@gnu.org>
7048
7049 * buffer.c (mmap_find): Fix a typo.
7050
cd18e7e3
JB
70512011-07-13 Johan Bockgård <bojohan@gnu.org>
7052
7053 Fix execution of x selection hooks.
7054 * xselect.c (Qx_lost_selection_functions)
7055 (Qx_sent_selection_functions): New vars.
7056 (syms_of_xselect): DEFSYM them.
7057 (x_handle_selection_request): Pass Qx_sent_selection_functions
7058 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7059 (x_handle_selection_clear,x_clear_frame_selections):
7060 Pass Qx_lost_selection_functions rather than
7061 Vx_lost_selection_functions to Frun_hook_with_args.
7062
47ea7f44
PE
70632011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7064
ac389d0c 7065 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7066 The old code sometimes used this field without initializing it.
7067
47ea7f44
PE
7068 * alloc.c (gc_sweep): Don't read past end of array.
7069 In theory, the old code could also have corrupted Emacs internals,
7070 though it'd be very unlikely.
7071
bc985c87
AS
70722011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7073
7074 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7075 argument. (Bug#4026)
bc985c87 7076
0cf34688
LMI
70772011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7078
b3dadd76
LMI
7079 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7080 key" (bug#4257).
7081
0cf34688
LMI
7082 * window.c (Fset_window_start): Doc fix (bug#4199).
7083 (Fset_window_hscroll): Ditto.
7084
270768cd
PE
70852011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7086
077e3dda 7087 Fix minor new problems caught by GCC 4.6.1.
270768cd 7088 * term.c (init_tty): Remove unused local.
490011a6 7089 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7090 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7091 not used otherwise.
270768cd 7092
b1f58454
CY
70932011-07-12 Chong Yidong <cyd@stupidchicken.com>
7094
7095 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7096
22b9578d
LMI
70972011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7098
6e70ab07
LMI
7099 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7100 are the mini-buffer and the echo area (bug#3320).
7101
22b9578d
LMI
7102 * term.c (init_tty): Remove support for supdup, c10 and perq
7103 terminals, which are no longer supported (bug#1482).
7104
8974cc9f
JB
71052011-07-10 Johan Bockgård <bojohan@gnu.org>
7106
7107 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7108
a560d974
JD
71092011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7110
7111 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7112 for non-popups (Bug#3642).
7113
1dae0f0a
AS
71142011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7115
268c2c36 7116 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7117 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7118 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7119 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7120 * data.c (fmod): Likewise.
7121 * dispnew.c (swap_glyphs_in_rows): Likewise.
7122 * emacs.c (memory_warning_signal): Likewise.
7123 * floatfns.c (float_error): Likewise.
7124 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7125 (otf_open, font_otf_capability, generate_otf_features)
7126 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7127 Likewise.
7128 * image.c (pbm_read_file): Likewise.
7129 * indent.c (string_display_width): Likewise.
7130 * intervals.c (check_for_interval, search_for_interval)
7131 (inc_interval_count, count_intervals, root_interval)
7132 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7133 * lread.c (defalias): Likewise.
268c2c36 7134 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7135 * regex.c (set_image_of_range_1, set_image_of_range)
7136 (regex_grow_registers): Likewise.
7137 * sysdep.c (strerror): Likewise.
7138 * termcap.c (valid_filename_p, tprint, main): Likewise.
7139 * tparam.c (main): Likewise.
7140 * unexhp9k800.c (run_time_remap, save_data_space)
7141 (update_file_ptrs, read_header, write_header, calculate_checksum)
7142 (copy_file, copy_rest, display_header): Likewise.
7143 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7144 Likewise.
7145 * xdisp.c (check_it): Likewise.
7146 * xfaces.c (register_color, unregister_color, unregister_colors):
7147 Likewise.
7148 * xfns.c (print_fontset_result): Likewise.
7149 * xrdb.c (member, fatal, main): Likewise.
7150
99033785
PE
71512011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7152
7153 Fix minor problems found by static checking (Bug#9031).
7154 * chartab.c (char_table_set_range, map_sub_char_table):
7155 Remove unused locals.
7156 (uniprop_table): Now static.
7157 * composite.c (_work_char): Remove unused static var.
7158
9cb2ac56
JB
71592011-07-09 Juanma Barranquero <lekktu@gmail.com>
7160
7161 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7162
f25661f0
JD
71632011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7164
7165 * gtkutil.c (qttip_cb): Remove code without function.
7166
8278c4fe
EZ
71672011-07-09 Eli Zaretskii <eliz@gnu.org>
7168
7169 * w32.c (pthread_sigmask): New stub.
7170
1692ae2d 71712011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7172
8a6ebd58 7173 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7174 sigprocmask is portable only for single-threaded applications, and
7175 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7176 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7177 (LIBES): Use it.
7178 * callproc.c (Fcall_process):
7179 * process.c (create_process):
7180 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7181 Use pthread_sigmask, not sigprocmask.
123403e4 7182
1b854618
JD
71832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7184
7185 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7186 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7187 wrong (Bug#8591).
7188
3fe4b549
JD
71892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7190
0ce7e563
JD
7191 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7192 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7193 (xg_hide_tooltip): Fix comment.
7194
3fe4b549
JD
7195 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7196 in registerServicesMenuSendTypes.
7197 (validRequestorForSendType): Don't check ns_return_types.
7198
7199 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7200 ns_return_type.
7201
5df75e47
JR
72022011-07-08 Jason Rumney <jasonr@gnu.org>
7203
22610910
JR
7204 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7205 SH_SHOW for hidden windows (Bug#5482).
7206
5df75e47
JR
7207 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7208 frame struct members of non-existent frames (Bug#6284).
7209
699c10bd
JD
72102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7211
4393663b
JD
7212 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7213 variable firstTime not needed on OSX >= 10.6.
7214 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7215 >= 10.5. Use setKnobProportion, setDoubleValue.
7216
7217 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7218 (MAC_OS_X_VERSION_10_5): Define if not defined.
7219 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7220 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7221 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7222
7223 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7224 cString and lossyCString on OSX >= 10.4
7225
58179cce 7226 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7227 sizeToFit on OSX >= 10.2.
7228
7229 * nsimage.m (allocInitFromFile): Don't use deprecated method
7230 bestRepresentationForDevice on OSX >= 10.6.
7231
7232 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7233 to avoid warning.
7234
7235 * emacs.c: Declare unexec_init_emacs_zone.
7236
a63e0781
JD
7237 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7238
699c10bd
JD
7239 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7240
7241 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7242 on svcsMenu (Bug#8842).
7243
7244 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7245 ns_return_types.
7246 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7247
7248 * nsterm.m (QUTF8_STRING): Declare.
7249 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7250 (validRequestorForSendType): Return type is (id).
7251 Change indexOfObjectIdenticalTo to indexOfObject.
7252 Check if we have local selection before returning self (Bug#8842).
7253 (writeSelectionToPasteboard): Put local selection into paste board
7254 if we have a local selection (Bug#8842).
7255 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7256
7257 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7258 (ns_get_local_selection): Declare.
7259
54e10184
LMI
72602011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7261
9888ff71
LMI
7262 * keymap.c (describe_map_tree): Don't insert a double newline at
7263 the end of the buffer (bug#1169) and return whether we inserted
7264 something.
7265
54e10184
LMI
7266 * callint.c (Fcall_interactively): Change "reading args" to
7267 "providing args" to try to clarify what it does (bug#1010).
7268
15fa4783
KH
72692011-07-07 Kenichi Handa <handa@m17n.org>
7270
7271 * composite.c (composition_compute_stop_pos): Ignore a static
7272 composition starting before CHARPOS (Bug#8915).
7273
7274 * xdisp.c (handle_composition_prop): Likewise.
7275
a8815b00
EZ
72762011-07-07 Eli Zaretskii <eliz@gnu.org>
7277
7278 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7279 (Bug#9015)
7280
ef7b981d 72812011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7282
7283 * character.h (unicode_category_t): New enum type.
7284
7285 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7286 (Qchar_code_property_table): New variable.
7287 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7288 (UNIPROP_COMPRESSED_FORM_P): New macros.
7289 (char_table_ascii): Uncompress the compressed values.
7290 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7291 Uncompress the compressed values.
ac389d0c 7292 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7293 (char_table_ref_and_range): Uncompress the compressed values.
7294 (sub_char_table_set): New arg is_uniprop. Callers changed.
7295 Uncompress the compressed values.
7296 (sub_char_table_set_range): Args changed. Callers changed.
7297 (char_table_set_range): Adjuted for the above change.
7298 (map_sub_char_table): Delete args default_val and parent. Add arg
7299 top. Give decoded values to a Lisp function.
640c8776 7300 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7301 values to a Lisp function. Gcpro more variables.
7302 (uniprop_table_uncompress)
7303 (uniprop_decode_value_run_length): New functions.
7304 (uniprop_decoder, uniprop_decoder_count): New variables.
7305 (uniprop_get_decoder, uniprop_encode_value_character)
7306 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7307 New functions.
7308 (uniprop_encoder, uniprop_encoder_count): New variables.
7309 (uniprop_get_encoder, uniprop_table)
7310 (Funicode_property_table_internal, Fget_unicode_property_internal)
7311 (Fput_unicode_property_internal): New functions.
7312 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7313 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7314 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7315 char-code-property-alist.
7316
640c8776 7317 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7318 Vunicode_category_table.
7319
640c8776 7320 * font.c (font_range): Adjust for the change of
c805dec0
KH
7321 Vunicode_category_table.
7322
76b397fb
DN
73232011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7324
7325 * m/iris4d.h: Remove file, move contents ...
7326 * s/irix6-5.h: ... here.
7327
22b4128e
PE
73282011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7329
7330 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7331 * alloc.c (mark_buffer):
7332 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7333 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7334 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7335 This isn't true in general, and it's particularly not true
7336 if Emacs is configured with --with-wide-int.
7337 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7338 New macros, used in the buffer.c change.
7339
869795d6
JD
73402011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7341
7342 * xsettings.c: Use both GConf and GSettings if both are available.
7343 (store_config_changed_event): Add comment.
7344 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7345 (store_tool_bar_style_changed): New functions.
5e617bc2 7346 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7347 (struct xsettings): Move font inside HAVE_XFT.
7348 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7349 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7350 Move inside HAVE_XFT.
640c8776 7351 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7352 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7353 also.
7354 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7355 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7356 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7357 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7358 (parse_settings): Move check for font inside HAVE_XFT.
7359 (read_settings, apply_xft_settings): Add comment.
7360 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7361 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7362 call store_font_name_changed.
7363 (xft_settings_event): Add comment.
7364 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7365 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7366 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7367 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7368 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7369 (xsettings_get_system_font, xsettings_get_system_normal_font):
7370 Add comment.
869795d6 7371
d8ed26bd
PE
73722011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7373
7374 Random fixes. E.g., (random) never returned negative values.
7375 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7376 subseconds part to the entropy, as that's a bit more random.
7377 Prefer signed to unsigned, since the signedness doesn't matter and
7378 in general we prefer signed. When given a limit, use a
7379 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7380 latter isn't right if USE_2_TAGS_FOR_INTS.
7381 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7382 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7383
cabf1cac
SM
73842011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7385
7386 * textprop.c (text_property_stickiness):
7387 Obey Vtext_property_default_nonsticky.
7388 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7389 * w32fns.c (syms_of_w32fns):
7390 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7391
6e9b2be9
PE
73922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7393
7394 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7395 This is more efficient than Ffile_directory_p and avoids a minor race.
7396
90186c68
LMI
73972011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7398
7c301272
LMI
7399 * buffer.c (Foverlay_put): Say what the return value is
7400 (bug#7835).
7401
c4f2d8d4
LMI
7402 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7403 is a directory before asking whether to use the file name
7404 (bug#7564).
ad637907
LMI
7405 (barf_or_query_if_file_exists): Make the "File is a directory"
7406 error be more correct.
c4f2d8d4 7407
90186c68
LMI
7408 * fns.c (Frequire): Remove the mention of the .gz files, since
7409 that's installation-specific, but keep the mention of
7410 `get-load-suffixes'.
7411
da64016e
PE
74122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7413
7414 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7415 Report string overflow if the output is too long.
7416
7d47b580
JB
74172011-07-04 Juanma Barranquero <lekktu@gmail.com>
7418
a555cb87
JB
7419 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7420 (syms_of_gnutls): Remove duplicate DEFSYM for
7421 Qgnutls_bootprop_verify_hostname_error, an error for
7422 Qgnutls_bootprop_verify_error (which is no longer used).
7423
7d47b580
JB
7424 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7425 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7426 Also (re)move comments that are misplaced or no longer relevant.
7427
1e49bfab
LMI
74282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7429
7430 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7431
1485f4c0
CY
74322011-07-03 Chong Yidong <cyd@stupidchicken.com>
7433
7434 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7435 and background color parameters if they have been changed.
7436
a9ab721e
LMI
74372011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7438
7439 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7440
cf7cff57
PE
74412011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7442
2e13213d
PE
7443 * xsettings.c (SYSTEM_FONT): Define only when used.
7444 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7445
cf7cff57
PE
7446 * keymap.c (access_keymap_1): Now static.
7447
7a8e04f7
CY
74482011-07-02 Chong Yidong <cyd@stupidchicken.com>
7449
7450 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7451 leave any prefix arg for the up event (Bug#1586).
7452
61352f62
LMI
74532011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7454
69bb1ef7
LMI
7455 * lread.c (syms_of_lread): Mention single symbols defined by
7456 `defvar' or `defconst' (bug#7154).
7457
61352f62 7458 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7459 (Frequire): Mention get-load-suffixes.
61352f62 7460
28545e04
MR
74612011-07-02 Martin Rudalics <rudalics@gmx.at>
7462
7463 * window.h (window): Remove clone_number slot.
7464 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7465 Remove.
7466 (make_parent_window, make_window, saved_window)
7467 (Fset_window_configuration, save_window_save): Don't deal with
7468 clone numbers.
7469 * buffer.c (Qclone_number): Remove declaration.
7470 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7471
3349e122
SM
74722011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7473
7474 Add multiple inheritance to keymaps.
7475 * keymap.c (Fmake_composed_keymap): New function.
7476 (Fset_keymap_parent): Simplify.
7477 (fix_submap_inheritance): Remove.
7478 (access_keymap_1): New function extracted from access_keymap to handle
7479 embedded parents and handle lists of maps.
7480 (access_keymap): Use it.
7481 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7482 (Fcopy_keymap): Handle embedded parents.
7483 (Fcommand_remapping, define_as_prefix): Simplify.
7484 (Fkey_binding): Simplify.
7485 (syms_of_keymap): Move minibuffer-local-completion-map,
7486 minibuffer-local-filename-completion-map,
7487 minibuffer-local-must-match-map, and
7488 minibuffer-local-filename-must-match-map to Elisp.
7489 (syms_of_keymap): Defsubr make-composed-keymap.
7490 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7491 (parse_menu_item): Trivial simplification.
7492
3279eb87
GM
74932011-07-01 Glenn Morris <rgm@gnu.org>
7494
7495 * Makefile.in (SETTINGS_LIBS): Fix typo.
7496
4550efdf
KI
74972011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7498
7499 * coding.c (Fencode_coding_string): Record the last coding system
7500 used, as the function doc string says (bug#8738).
7501
0949d2b6
JD
75022011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7503
7504 * xsettings.c (store_monospaced_changed): Take new font as arg and
7505 check for change against current_mono_font.
7506 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7507 (emacs_settings_constructor, emacs_settings_get_property)
7508 (emacs_settings_set_property, emacs_settings_class_init)
7509 (emacs_settings_init, gsettings_obj): Remove.
7510 (something_changedCB): New function for HAVE_GSETTINGS.
7511 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7512 with value as argument.
7513 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7514 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7515 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7516 "changed".
7517
7518 * xgselect.c: Add defined (HAVE_GSETTINGS).
7519 (xgselect_initialize): Ditto.
7520
7521 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7522 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7523 xg_select.
7524
bbc6b304
PE
75252011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7526
7527 * eval.c (struct backtrace): Simplify and port the data structure.
7528 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7529 signed bit field, as this assumption is not portable and it makes
7530 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7531 "char debug_on_exit : 1" as this is not portable either; instead,
7532 use the portable "unsigned int debug_on_exit : 1". Remove unused
7533 member evalargs. Remove obsolete comments about cc bombing out.
7534
9851bfc5
JD
75352011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7536
51bb811f 7537 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7538 Let HAVE_GSETTINGS override HAVE_GCONF.
7539 (store_monospaced_changed): New function.
7540 (EMACS_SETTINGS): A new type derived from GObject to handle
7541 GSettings notifications.
7542 (emacs_settings_constructor, emacs_settings_get_property)
7543 (emacs_settings_set_property, emacs_settings_class_init):
7544 New functions.
7545 (gsettings_client, gsettings_obj): New variables.
7546 (GSETTINGS_SCHEMA): New define.
7547 (something_changedCB): Call store_monospaced_changed.
7548 (init_gsettings): New function.
7549 (xsettings_initialize): Call init_gsettings.
7550 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7551 to NULL.
7552
640c8776 7553 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7554 GCONF_CFLAGS/LIBS.
7555
5386012d
MR
75562011-06-29 Martin Rudalics <rudalics@gmx.at>
7557
7558 * window.c (resize_root_window, grow_mini_window)
7559 (shrink_mini_window): Rename Qresize_root_window to
7560 Qwindow_resize_root_window and Qresize_root_window_vertically to
7561 Qwindow_resize_root_window_vertically.
7562
f13e0b08
PE
75632011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7564
7565 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7566
94515237
JB
75672011-06-27 Juanma Barranquero <lekktu@gmail.com>
7568
7569 * makefile.w32-in: Redesign dependencies so they reflect more
7570 clearly which files are directly included by each source file,
7571 and not through other includes.
7572
e43b6e43
MR
75732011-06-27 Martin Rudalics <rudalics@gmx.at>
7574
7575 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7576 (sort_overlays, overlay_strings): When an overlay's clone number
7577 matches the window's clone number process the overlay even if
7578 the overlay's window property doesn't match the current window.
7579
d68443dc
MR
7580 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7581 (Fwindow_hchild): Rename to Fwindow_left_child.
7582 (Fwindow_next): Rename to Fwindow_next_sibling.
7583 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7584 (resize_window_check): Rename to window_resize_check.
7585 (resize_window_apply): Rename to window_resize_apply.
7586 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7587 (Fdelete_other_windows_internal, resize_frame_windows)
7588 (Fsplit_window_internal, Fdelete_window_internal)
7589 (grow_mini_window, shrink_mini_window)
7590 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7591
c7e73be5
JD
75922011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7593
7594 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7595 (emacs_fixed_set_min_size): Remove.
7596 (emacs_fixed_new): Take frame as argument.
7597
7598 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7599 (_EmacsFixedPrivate): Remove minwidth/height.
7600 Add struct frame *f.
7601 (emacs_fixed_init): Initialize priv->f.
7602 (get_parent_class, emacs_fixed_set_min_size): Remove.
7603 (emacs_fixed_new): Set priv->f to argument.
7604 (emacs_fixed_get_preferred_width)
7605 (emacs_fixed_get_preferred_height): Use min_width/height from
7606 frames size_hint to set minimum and natural (Bug#8919).
7607 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7608 and use min_width/height from frames size_hint to set
7609 min_width/height (Bug#8919).
7610
7611 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7612 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7613 Fix indentation.
c7e73be5 7614
cf99dcf8
EZ
76152011-06-26 Eli Zaretskii <eliz@gnu.org>
7616
7617 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7618 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7619 called at ZV.
7620
029529ac
CY
76212011-06-26 Chong Yidong <cyd@stupidchicken.com>
7622
7623 * process.c (wait_reading_process_output): Bypass select if
7624 waiting for a cell while ignoring keyboard input, and input is
7625 pending. Suggested by Jan Djärv (Bug#8869).
7626
7a7ef429
PE
76272011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7628
7629 Use gnulib's dup2 module instead of rolling our own.
7630 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7631
11fdef7d 76322011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7633
7634 * dispnew.c (scrolling_window): Before scrolling, turn off a
7635 mouse-highlight in the window being scrolled.
7636
cd3520a4
JB
76372011-06-24 Juanma Barranquero <lekktu@gmail.com>
7638
7639 Move DEFSYM to lisp.h and use everywhere.
7640
7641 * character.h (DEFSYM): Move declaration...
7642 * lisp.h (DEFSYM): ...here.
7643
7644 * gnutls.c:
7645 * minibuf.c:
7646 * w32menu.c:
7647 * w32proc.c:
7648 * w32select.c: Don't include character.h.
7649
7650 * alloc.c (syms_of_alloc):
7651 * buffer.c (syms_of_buffer):
7652 * bytecode.c (syms_of_bytecode):
7653 * callint.c (syms_of_callint):
7654 * casefiddle.c (syms_of_casefiddle):
7655 * casetab.c (init_casetab_once):
7656 * category.c (init_category_once, syms_of_category):
7657 * ccl.c (syms_of_ccl):
7658 * cmds.c (syms_of_cmds):
7659 * composite.c (syms_of_composite):
7660 * dbusbind.c (syms_of_dbusbind):
7661 * dired.c (syms_of_dired):
7662 * dispnew.c (syms_of_display):
7663 * doc.c (syms_of_doc):
7664 * editfns.c (syms_of_editfns):
7665 * emacs.c (syms_of_emacs):
7666 * eval.c (syms_of_eval):
7667 * fileio.c (syms_of_fileio):
7668 * fns.c (syms_of_fns):
7669 * frame.c (syms_of_frame):
7670 * fringe.c (syms_of_fringe):
7671 * insdel.c (syms_of_insdel):
7672 * keymap.c (syms_of_keymap):
7673 * lread.c (init_obarray, syms_of_lread):
7674 * macros.c (syms_of_macros):
7675 * msdos.c (syms_of_msdos):
7676 * print.c (syms_of_print):
7677 * process.c (syms_of_process):
7678 * search.c (syms_of_search):
7679 * sound.c (syms_of_sound):
7680 * syntax.c (init_syntax_once, syms_of_syntax):
7681 * terminal.c (syms_of_terminal):
7682 * textprop.c (syms_of_textprop):
7683 * undo.c (syms_of_undo):
7684 * w32.c (globals_of_w32):
7685 * window.c (syms_of_window):
7686 * xdisp.c (syms_of_xdisp):
7687 * xfaces.c (syms_of_xfaces):
7688 * xfns.c (syms_of_xfns):
7689 * xmenu.c (syms_of_xmenu):
7690 * xsettings.c (syms_of_xsettings):
7691 * xterm.c (syms_of_xterm): Use DEFSYM.
7692
4228cf16
TZ
76932011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7694
cd3520a4 7695 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7696
7fcccf1e
PE
76972011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7698
7efb4e0e
PE
7699 Integer and buffer overflow fixes (Bug#8873).
7700
ff5844ad
PE
7701 * print.c (printchar, strout): Check for string overflow.
7702 (PRINTPREPARE, printchar, strout):
7703 Don't set size unless allocation succeeds.
7704
90532f02
PE
7705 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7706 for sizes. Check for string overflow more accurately.
7707 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7708
6d84508d
PE
7709 * macros.c: Integer and buffer overflow fixes.
7710 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7711 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7712 Use ptrdiff_t, not int, for sizes.
7713 Don't increment bufsize until after realloc succeeds.
7714 Check for size-calculation overflow.
7715 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7716
437b2cb4
PE
7717 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7718
8b9ac8b4
PE
7719 * lread.c: Integer overflow fixes.
7720 (read_integer): Radix is now EMACS_INT, not int,
7721 to improve quality of diagnostics for out-of-range radices.
7722 Calculate buffer size correctly for out-of-range radices.
7723 (read1): Check for integer overflow in radices, and in
7724 read-circle numbers.
82cb60d3
PE
7725 (read_escape): Avoid int overflow.
7726 (Fload, openp, read_buffer_size, read1)
7727 (substitute_object_recurse, read_vector, read_list, map_obarray):
7728 Use ptrdiff_t, not int, for sizes.
7729 (read1): Use EMACS_INT, not int, for sizes.
20270765 7730 Check for size overflow.
8b9ac8b4 7731
7fcccf1e
PE
7732 * image.c (cache_image): Check for size arithmetic overflow.
7733
bfbbd7e7
PE
7734 * lread.c: Integer overflow issues.
7735 (saved_doc_string_size, saved_doc_string_length)
7736 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7737 Now ptrdiff_t, not int.
7738 (read1): Don't assume doc string length fits in int. Check for
7739 out-of-range doc string lengths.
7740 (read_list): Don't assume file position fits in int.
39019e54 7741 (read_escape): Check for hex character overflow.
bfbbd7e7 7742
4e323265
LL
77432011-06-22 Leo Liu <sdl.web@gmail.com>
7744
7745 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7746 Move to minibuffer.el.
7747
85fece3e
PE
77482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7749
20b84ce9 7750 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7751 The following patches are for when GLYPH_DEBUG && !XASSERT.
7752 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7753 * dispnew.c (flush_stdout):
7754 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7755 Mark as externally visible.
7756 * dispnew.c (check_window_matrix_pointers): Now static.
7757 * dispnew.c (window_to_frame_vpos):
7758 * xfns.c (unwind_create_frame):
7759 * xterm.c (x_check_font): Remove unused local.
7760 * scroll.c (CHECK_BOUNDS):
7761 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7762 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7763 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7764 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7765 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7766 Now static.
7767 (debug_method_add): Use va_list and vsprintf rather than relying
7768 on undefined behavior with wrong number of arguments.
7769 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7770 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7771 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7772 since we're not interested in debugging glyphs with old libraries.
7773 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7774 GCC 4.6.0's static checking.
7775
0766b489
PE
77762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7777
31fd4b32
PE
7778 Integer overflow and signedness fixes (Bug#8873).
7779 A few related buffer overrun fixes, too.
7780
b79e8648
PE
7781 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7782
0766b489
PE
7783 * dispextern.h (struct face.stipple):
7784 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7785 (x_bitmap_mask, x_allocate_bitmap_record)
7786 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7787 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7788 (x_create_bitmap_from_xpm_data):
7789 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7790 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7791 (.bitmaps_last):
7792 * xfaces.c (load_pixmap):
7793 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7794 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7795 (.bitmaps_last, struct x_output.icon_bitmap):
7796 Use ptrdiff_t, not int, for bitmap indexes.
7797 (x_allocate_bitmap_record): Check for size overflow.
7798 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7799
b081724f
PE
7800 Use ptrdiff_t, not int, for overlay counts.
7801 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7802 * editfns.c (overlays_around, get_pos_property):
7803 * textprop.c (get_char_property_and_overlay):
7804 * xdisp.c (next_overlay_change, note_mouse_highlight):
7805 * xfaces.c (face_at_buffer_position):
21514da7
PE
7806 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7807 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7808 (Fnext_overlay_change, Fprevious_overlay_change)
7809 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7810 Use ptrdiff_t, not int, for sizes.
21514da7 7811 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7812
3de73e5e
PE
7813 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7814
2606c57b
PE
7815 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7816 (x_session_initialize): Do not assume string length fits in int.
7817
aaafe47a
PE
7818 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7819 This is unlikely, but can occur if DPI is outlandish.
7820
2674ddc8 7821 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7822 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7823
28154962
PE
7824 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7825 * xrdb.c (magic_file_p, search_magic_path):
7826 Omit last arg SUFFIX; it was always 0. All callers changed.
7827 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7828
7de51af5
PE
7829 * xfont.c (xfont_match): Avoid need for strlen.
7830
25ed6cc3
PE
7831 * xfns.c: Don't assume strlen fits in int.
7832 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7833
4eab31dd
PE
7834 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7835 not unsigned long, as we prefer signed integers. All callers changed.
7836 Detect integer overflow in repeat count.
7837 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7838 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7839
171e2a58
PE
7840 * termcap.c: Don't assume sizes fit in int and never overflow.
7841 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7842 (gobble_line): Check for size-calculation overflow.
7843
ad39faca 7844 * minibuf.c (Fread_buffer):
6e5bb2dc 7845 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7846 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7847 Don't assume string length fits in int.
7848
52c61c22 7849 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7850 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7851
b5b8c9e5
PE
7852 * font.c: Don't assume string length fits in int.
7853 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7854 Use ptrdiff_t, not int.
ccd6111c
PE
7855 (font_intern_prop): Don't assume string length fits in int.
7856 Don't assume integer property fits in fixnum.
7857 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7858
882f0d81 7859 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7860 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7861 Reformulate so as not to need the command string.
7862 Invoke gzip -cd rather than gunzip, as it's more portable.
7863 (lock_info_type, lock_file_1, lock_file):
7864 Don't assume pid_t and time_t fit in unsigned long.
7865 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7866 (current_lock_owner): Prefer signed type for sizes.
7867 Use memcpy, not strncpy, where memcpy is what is really wanted.
7868 Don't assume (via atoi) that time_t and pid_t fit in int.
7869 Check for time_t and/or pid_t out of range, e.g., via a network share.
7870 Don't alloca where an auto var works fine.
7871
93f4cf88
PE
7872 * fileio.c: Fix some integer overflow issues.
7873 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7874 Don't assume string length fits in int.
7875 (directory_file_name): Don't assume string length fits in long.
7876 (make_temp_name): Don't assume pid fits in int, or that its print
7877 length is less than 20.
7878
f3e92b69
PE
7879 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7880
1bfdaf10
PE
7881 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7882
35016e9a
PE
7883 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7884
3d1e65a1
PE
7885 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7886 We prefer signed integers, even for size calculations.
7887
0b963a93
PE
7888 * emacs.c: Don't assume string length fits in 'int'.
7889 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7890 (main): Don't invoke strlen when not needed.
7891
573f4b54
PE
7892 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7893 (XD_DEBUG_MESSAGE): Don't waste a byte.
7894
989f33ba
PE
7895 * callproc.c (getenv_internal_1, getenv_internal)
7896 (Fgetenv_internal):
965d34eb
PE
7897 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7898
e4d29b33
PE
7899 * lread.c (invalid_syntax): Omit length argument.
7900 All uses changed. This doesn't fix a bug, but it simplifies the
7901 code away from its former Hollerith-constant appearance, and it's
7902 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7903 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7904
eb49b136
PE
7905 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7906 This didn't break anything, but it didn't help either.
7907 It's confusing to put a bogus integer in a place where the actual
7908 value does not matter.
9f62aeb1 7909 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7910 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7911
15375a22
PE
7912 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7913 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7914 implementation.
b61cc01c
PE
7915 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7916 We prefer signed types, and the value cannot exceed the EMACS_INT
7917 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7918 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7919 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7920 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7921
53b2623d
PE
7922 * indent.c (sane_tab_width): New function.
7923 (current_column, scan_for_column, Findent_to, position_indentation)
7924 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7925 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7926
51cab52b 7927 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7928
f2ed8a70
PE
7929 * lisp.h (lint_assume): New macro.
7930 * composite.c (composition_gstring_put_cache):
7931 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7932
abe80cc6
PE
7933 * editfns.c, insdel.c:
7934 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7935
b02c740e
PE
7936 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7937
ebc96716
PE
7938 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7939
b4e50fa0 7940 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7941 Use much-faster test for byte-length change.
311d5d7c 7942 Don't assume string byte-length fits in 'int'.
a4cf38e4 7943 Check that character arg fits in 'int'.
85461888 7944 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7945
c0c1ee9f
PE
7946 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7947
a498d7f4
PE
7948 * fns.c (concat): Catch string overflow earlier.
7949 Do not rely on integer wraparound.
7950
51cab52b
PE
7951 * dispextern.h (struct it.overlay_strings_charpos)
7952 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7953 * xdisp.c (forward_to_next_line_start)
7954 (back_to_previous_visible_line_start)
7955 (reseat_at_next_visible_line_start, next_element_from_buffer):
7956 Don't arbitrarily truncate the value of 'selective' to int.
7957
76031fad
PE
7958 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7959
5eb55db9
PE
7960 * composite.c: Don't truncate sizes to 'int'.
7961 (composition_gstring_p, composition_reseat_it)
7962 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7963 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7964 not EMACS_UINT, for indexes.
5eb55db9 7965
0703a717
PE
7966 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7967
d6202519
PE
7968 * buffer.c: Include <verify.h>.
7969 (struct sortvec.priority, struct sortstr.priority):
8961a454 7970 Now EMACS_INT, not int.
c20998a7 7971 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7972 (struct sortstr.size, record_overlay_string)
7973 (struct sortstrlist.size, struct sortlist.used):
7974 Don't truncate size to int.
7975 (record_overlay_string): Check for size-calculation overflow.
d6202519 7976 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7977
d5a19415
JM
79782011-06-22 Jim Meyering <meyering@redhat.com>
7979
029529ac 7980 Don't leak an XBM-image-sized buffer
d5a19415
JM
7981 * image.c (xbm_load): Free the image buffer after using it.
7982
a9041e6c
PE
79832011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7984
7985 Port to Sun C.
7986 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7987 that Sun C diagnosed.
7988 * fns.c (secure_hash): Fix pointer signedness issue.
7989 * intervals.c (static_offset_intervals): New function.
7990 (offset_intervals): Use it.
7991
7f3f739f
LL
79922011-06-21 Leo Liu <sdl.web@gmail.com>
7993
7994 * deps.mk (fns.o):
7995 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7996 sha512.h.
7997
7998 * fns.c (secure_hash): Rename from crypto_hash_function and change
7999 the first arg to accept symbols.
5b66d427 8000 (Fsecure_hash): New primitive.
7f3f739f
LL
8001 (syms_of_fns): New symbols.
8002
76147d94
DD
80032011-06-20 Deniz Dogan <deniz@dogan.se>
8004
8005 * process.c (Fset_process_buffer): Clarify return value in
8006 docstring.
8007
7d7d0045
CY
80082011-06-18 Chong Yidong <cyd@stupidchicken.com>
8009
8010 * dispnew.c (add_window_display_history): Use BVAR.
8011
8012 * xdisp.c (debug_method_add): Use BVAR.
8013 (check_window_end, dump_glyph_matrix, dump_glyph)
8014 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8015
8016 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8017 Likewise.
8018
8019 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8020 check till after the cache is created in init_frame_faces.
8021
ff2bc410
SM
80222011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8023
8024 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8025
28177add
PE
80262011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8027
dd3482fe
PE
8028 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8029 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8030 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8031
393d71f3 8032 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8033 * fileio.c (Finsert_file_contents):
8034 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8035 Remove the old (too-loose) buffer overflow checks.
8036 They weren't needed, since make_gap checks for buffer overflow.
8037 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8038 The old code merely checked for Emacs fixnum overflow, and relied
8039 on undefined (wraparound) behavior. The new code avoids undefined
8040 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8041
2e6813b0 8042 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8043 Tune. Don't use wider integers than needed. Don't use alloca.
8044 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8045
599a9e4f
PE
8046 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8047
99561444
PE
8048 * insdel.c, lisp.h (buffer_overflow): New function.
8049 (insert_from_buffer_1, replace_range, replace_range_2):
8050 * insdel.c (make_gap_larger):
8051 * editfns.c (Finsert_char):
8052 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8053
28177add
PE
8054 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8055
e69dafad
PE
80562011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8057
4baa020d 8058 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8059
b1c46f02
PE
8060 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8061 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8062
e69dafad
PE
8063 * fileio.c: Don't assume EMACS_INT fits in off_t.
8064 (emacs_lseek): New static function.
8065 (Finsert_file_contents, Fwrite_region): Use it.
8066 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8067
566684ea
PE
8068 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8069
e6966cd6
PE
8070 * fns.c: Don't overflow int when computing a list length.
8071 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8072 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8073 truncation on 64-bit hosts. Check for QUIT every
8074 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8075 faster and is responsive enough.
8076 (Flength): Report an error instead of overflowing an integer.
8077 (Fsafe_length): Return a float if the value is not representable
8078 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8079 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8080 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8081
dd0b0efb
PE
8082 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8083 (header_size, word_size): New constants.
8084 (allocate_vectorlike): Don't check size overflow here.
8085 (allocate_vector): Check it here instead, since this is the only
8086 caller of allocate_vectorlike that could cause overflow.
8087 Check that the new vector's length is representable as a fixnum.
8088
86fe5cfe
PE
8089 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8090 The previous code was bogus. For example, next_almost_prime (32)
8091 returned 39, which is undesirable as it is a multiple of 3; and
8092 next_almost_prime (24) returned 25, which is a multiple of 5 so
8093 why was the code bothering to check for multiples of 7?
8094
80e88859
PE
8095 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8096
4a2f0ad6
PE
8097 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8098
f66c7cf8
PE
8099 Variadic C functions now count arguments with ptrdiff_t.
8100 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8101 Back then I didn't know that the Emacs coding style prefers signed int.
8102 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8103 were being counted with int, which may truncate counts on 64-bit
8104 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8105 * lisp.h (struct Lisp_Subr.function.aMANY)
8106 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8107 Arg counts are now ptrdiff_t, not size_t.
8108 All variadic functions and their callers changed accordingly.
8109 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8110 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8111 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8112 * callint.c (Fcall_interactively): Check arg count for overflow,
8113 to avoid potential buffer overrun. Use signed char, not 'int',
8114 for 'varies' array, so that we needn't bother to check its size
8115 calculation for overflow.
8116 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8117 * eval.c (apply_lambda):
8118 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8119 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8120 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8121
a1759b76
PE
8122 * callint.c (Fcall_interactively): Don't use index var as event count.
8123
d96be9fc
PE
8124 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8125 * mem-limits.h (SIZE): Remove; no longer used.
8126
a690a978 8127 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8128
578c21e6
PE
8129 Remove unnecessary casts.
8130 * xterm.c (x_term_init):
8131 * xfns.c (x_set_border_pixel):
8132 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8133 These aren't needed now that we assume ANSI C.
8134
96f53c6c
PE
8135 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8136 It's more likely to cause problems (due to unsigned overflow)
8137 than to cure them.
8138
83c77d31
PE
8139 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8140
ee2079f1
PE
8141 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8142
6da65536
PE
8143 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8144
7147c4a4
PE
8145 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8146
193e32d9
PE
8147 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8148
e5533da6
PE
8149 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8150
9910e595
PE
8151 GLYPH_CODE_FACE returns EMACS_INT, not int.
8152 * dispextern.h (merge_faces):
8153 * xfaces.c (merge_faces):
01103c44
PE
8154 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8155 Don't assume EMACS_INT fits in int.
9910e595 8156
2638320e
PE
8157 * character.h (CHAR_VALID_P): Remove unused parameter.
8158 * fontset.c, lisp.h, xdisp.c: All uses changed.
8159
045eb8d9
PE
8160 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8161
c1f134b5
PE
8162 * fns.c (concat): Minor tuning based on overflow analysis.
8163 This doesn't fix any bugs. Use int to hold character, instead
8164 of constantly refetching from Emacs object. Use XFASTINT, not
8165 XINT, for value known to be a character. Don't bother comparing
8166 a single byte to 0400, as it's always less.
8167
395fcb93 8168 * floatfns.c (Fexpt):
327eeec8
PE
8169 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8170
abbd3d23
PE
8171 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8172 for characters.
8173
684a03ef
PE
8174 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8175
0fed43f3
PE
8176 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8177 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8178 incorrectly succeed when S was a string, because 4294967386 was
8179 truncated before it was used.
8180
8fd02eb7
PE
8181 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8182 Otherwise, an out-of-range integer could cause undefined behavior
8183 on a 64-bit host.
8184
f8c86b69
PE
8185 * composite.c: Use int, not EMACS_INT, for characters.
8186 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8187 EMACS_INT, for values that are known to be in character range.
8188 This doesn't fix any bugs but is the usual style inside Emacs and
8189 may generate better code on 32-bit machines.
8190
34206dd2
PE
8191 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8192 This is for reasons similar to the recent CHAR_STRING fix.
8193 * charset.c (Fencode_char): Check that character arg is actually
8194 a character. Pass an int to ENCODE_CHAR.
8195 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8196 wider than 'int', as a compile-time check to prevent future regressions
8197 in this area.
8198
c5958d4c 8199 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8200
8201 Make sure a 64-bit char is never passed to CHAR_STRING.
8202 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8203 by silently ignoring the top 32 bits, allowing some values
8204 that were far too large to be valid characters.
8205 * character.h: Include <verify.h>.
8206 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8207 arguments are no wider than unsigned, as a compile-time check
8208 to prevent future regressions in this area.
8209 * data.c (Faset):
01103c44 8210 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8211 (Fsubst_char_in_region):
8212 * fns.c (concat):
8213 * xdisp.c (decode_mode_spec_coding):
8214 Adjust to CHAR_STRING's new requirement.
8215 * editfns.c (Finsert_char, Fsubst_char_in_region):
8216 * fns.c (concat): Check that character args are actually
8217 characters. Without this test, these functions did the wrong
8218 thing with wildly out-of-range values on 64-bit hosts.
8219
d37ca623
PE
8220 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8221 These casts should not be needed on 32-bit hosts, either.
8222 * keyboard.c (read_char):
8223 * lread.c (Fload): Remove casts to unsigned.
8224
ea204efb
PE
8225 * lisp.h (UNSIGNED_CMP): New macro.
8226 This fixes comparison bugs on 64-bit hosts.
8227 (ASCII_CHAR_P): Use it.
8228 * casefiddle.c (casify_object):
01103c44 8229 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8230 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8231 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8232 * dispextern.h (FACE_FROM_ID):
8233 * keyboard.c (read_char): Use UNSIGNED_CMP.
8234
41cb286c
PE
8235 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8236 not to EMACS_INT, to avoid GCC warning.
8237
4a1b9832
PE
8238 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8239
55daad71
PE
8240 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8241 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8242 isn't needed on 32-bit machines.
8f95c75c 8243
01103c44
PE
8244 * buffer.c (Fgenerate_new_buffer_name):
8245 Use EMACS_INT for count, not int.
0ceccced 8246 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8247
8248 * data.c (Qcompiled_function): Now static.
8249
c6f072e7
PE
8250 * window.c (window_body_lines): Now static.
8251
20ce5912
PE
8252 * image.c (gif_load): Rename local to avoid shadowing.
8253
9c4c5f81
PE
8254 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8255 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8256 * alloc.c (make_save_value): Integer argument is now of type
8257 ptrdiff_t, not int.
8258 (mark_object): Use ptrdiff_t, not int.
8259 * lisp.h (pD): New macro.
8260 * print.c (print_object): Use it.
8261
c0c5c8ae
PE
8262 * alloc.c: Use EMACS_INT, not int, to count objects.
8263 (total_conses, total_markers, total_symbols, total_vector_size)
8264 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8265 (total_free_floats, total_floats, total_free_intervals)
8266 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8267 Now EMACS_INT, not int. All uses changed.
8268 (Fgarbage_collect): Compute overall total using a double, so that
8269 integer overflow is less likely to be a problem. Check for overflow
8270 when converting back to an integer.
5a25e253
PE
8271 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8272 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8273 These were 'int' variables that could overflow on 64-bit hosts;
8274 they were never used, so remove them instead of repairing them.
211a0b2a 8275 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8276 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8277 Previously, this ceilinged at INT_MAX, but that doesn't work on
8278 64-bit machines.
e46bb31a 8279 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8280
c78baabf 8281 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8282 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8283 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8284 when a (possibly-narrower) signed value would do just as well.
8285 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8286
c9d624c6
PE
8287 * alloc.c: Catch some string size overflows that we were missing.
8288 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8289 for convenience in STRING_BYTES_MAX.
8290 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8291 The definition here is exact; the one in lisp.h was approximate.
8292 (allocate_string_data): Check for string overflow. This catches
8293 some instances we weren't catching before. Also, it catches
8294 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8295 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8296 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8297
c9d624c6
PE
8298 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8299 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8300 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8301
353032ce
PE
8302 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8303
2bccce07
PE
8304 * alloc.c (Fmake_string): Check for out-of-range init.
8305
0ac30604
SM
83062011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8307
8308 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8309
c195f2de
JD
83102011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8311
8312 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8313 xg_get_default_scrollbar_width.
8314
8315 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8316 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8317 (style_changed_cb): Call update_theme_scrollbar_width and call
8318 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8319 all frames (Bug#8505).
8320 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8321 Call gtk_window_set_resizable if HAVE_GTK3.
8322 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8323 and height if HAVE_GTK3 (Bug#8505).
8324 (scroll_bar_width_for_theme): New variable.
8325 (update_theme_scrollbar_width): New function.
8326 (xg_get_default_scrollbar_width): Move code to
8327 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8328 (xg_initialize): Call update_theme_scrollbar_width.
8329
8330 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8331
8332 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8333
e10ac9f1
MR
83342011-06-12 Martin Rudalics <rudalics@gmx.at>
8335
8336 * frame.c (make_frame): Call other_buffer_safely instead of
8337 other_buffer.
8338
8339 * window.c (temp_output_buffer_show): Call display_buffer with
8340 second argument Vtemp_buffer_show_specifiers and reset latter
8341 immediately after the call.
8342 (Vtemp_buffer_show_specifiers): New variable.
8343 (auto_window_vscroll_p, next_screen_context_lines)
8344 (Vscroll_preserve_screen_position): Remove leading asterisks from
8345 doc-strings.
8346
2d3c217e 83472011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8348
7b7f97e8 8349 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8350 * buffer.c (Qclone_number): Remove for now, as it's unused.
8351 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8352 (record_buffer): Remove unused local.
8353 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8354 (set_frame_buffer_list): Remove; unused.
8355 * frame.h (other_visible_frames): Remove decl.
8356 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8357 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8358 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8359 if HAVE_GPM.
8360 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8361 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8362 Define only if HAVE_GPM.
8363 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8364 (update_hints_inhibit): Remove; never set. All uses removed.
8365 * widgetprv.h (emacsFrameClassRec): Remove decl.
8366 * window.c (delete_deletable_window): Now returns void, since it
8367 wasn't returning anything.
8368 (compare_window_configurations): Remove unused locals.
8369 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8370 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8371 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8372 the same widths as pointers. This follows up on the 2011-05-06 patch.
8373 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8374 * xterm.h: Likewise.
8375 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8376
1384b89e
JB
83772011-06-12 Juanma Barranquero <lekktu@gmail.com>
8378
8379 * makefile.w32-in: Update dependencies.
8380 (LISP_H): Add lib/intprops.h.
8381
1100a63c
CY
83822011-06-11 Chong Yidong <cyd@stupidchicken.com>
8383
8384 * image.c (gif_load): Add animation frame delay to the metadata.
8385 (syms_of_image): Use DEFSYM. New symbol `delay'.
8386
6198ccd0
MR
83872011-06-11 Martin Rudalics <rudalics@gmx.at>
8388
8389 * window.c (delete_deletable_window): Re-add.
8390 (Fset_window_configuration): Rewrite to handle dead buffers and
8391 consequently deletable windows.
8392 (window_tree, Fwindow_tree): Remove. Supply functionality in
8393 window.el.
8394 (compare_window_configurations): Simplify code.
8395
b6e3633c
AS
83962011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8397
1ab0dee5
AS
8398 * image.c (imagemagick_load_image): Fix type mismatch.
8399 (Fimagemagick_types): Likewise.
8400
b6e3633c
AS
8401 * window.h (replace_buffer_in_windows): Declare.
8402
9397e56f
MR
84032011-06-11 Martin Rudalics <rudalics@gmx.at>
8404
8405 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8406 Qclone_number. Remove external declaration of Qdelete_window.
8407 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8408 code.
640c8776
SM
8409 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8410 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8411 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8412 buffer list implementation.
8413 (other_buffer_safely): New function.
8414 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8415 calls to replace_buffer_in_windows and
8416 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8417 if allowed.
8418 (record_buffer): Inhibit quitting and rewrite using quittable
8419 functions. Run Qbuffer_list_update_hook if allowed.
8420 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8421 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8422 Move switch-to-buffer to window.el.
9397e56f
MR
8423 (bury-buffer): Move to window.el.
8424 (Vbuffer_list_update_hook): New variable.
8425
8426 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8427 section.
8428
8429 * window.h (resize_frame_windows): Move up in code.
8430 (Fwindow_frame): Remove EXFUN.
8431 (replace_buffer_in_all_windows): Remove prototype.
8432 (replace_buffer_in_windows_safely): Add prototype.
8433
8434 * window.c: Declare Qdelete_window static again. Move down
8435 declaration of select_count.
8436 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8437 (Fother_window): Move to window.el.
8438 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8439 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8440 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8441 window.el.
8442 (replace_buffer_in_windows): Implement by calling
8443 Qreplace_buffer_in_windows.
8444 (replace_buffer_in_all_windows): Remove with some functionality
8445 moved into replace_buffer_in_windows_safely.
8446 (replace_buffer_in_windows_safely): New function.
8447 (select_window_norecord, select_frame_norecord): Move in front
8448 of run_window_configuration_change_hook. Remove now obsolete
8449 declarations.
640c8776
SM
8450 (Fset_window_buffer): Rewrite doc-string.
8451 Call Qrecord_window_buffer.
9397e56f
MR
8452 (keys_of_window): Move binding for other-window to window.el.
8453
b50691aa
CY
84542011-06-11 Chong Yidong <cyd@stupidchicken.com>
8455
8456 * dispextern.h (struct image): Replace data member, whose int_val
8457 and ptr_val fields were not used by anything, with a single
8458 lisp_val object.
8459
8460 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8461 (gif_clear_image, gif_load, imagemagick_load_image)
8462 (gs_clear_image, gs_load): Callers changed.
8463
3f754b86
PE
84642011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8465
cca69397
PE
8466 * buffer.h: Include <time.h>, for time_t.
8467 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8468
109e28d0
PE
8469 Fix minor problems found by static checking.
8470
60737f02
PE
8471 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8472
4b66faf3
PE
8473 Make identifiers static if they are not used in other modules.
8474 * data.c (Qcompiled_function, Qframe, Qvector):
8475 * image.c (QimageMagick, Qsvg):
8476 * minibuf.c (Qmetadata):
8477 * window.c (resize_window_check, resize_root_window): Now static.
8478 * window.h (resize_window_check, resize_root_window): Remove decls.
8479
109e28d0
PE
8480 * window.c (window_deletion_count, delete_deletable_window):
8481 Remove; unused.
46a4ce9e
PE
8482 (window_body_lines): Now static.
8483 (Fdelete_other_windows_internal): Mark vars as initialized.
8484 Make sure 'resize_failed' is initialized.
8485 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8486 (resize_window_apply): Remove unused local.
8487 * window.h (delete_deletable_window): Remove decl.
8488
109e28d0 8489 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8490 (imagemagick_load_image): Fix pointer signedness problem by changing
8491 last arg from unsigned char * to char *. All uses changed.
8492 Also, fix a local for similar reasons.
8493 Remove unused locals. Remove locals to avoid shadowing.
8494 (fn_rsvg_handle_free): Remove; unused.
8495 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8496 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8497
3f754b86
PE
8498 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8499
2547adb1
CY
85002011-06-10 Chong Yidong <cyd@stupidchicken.com>
8501
8502 * image.c (gif_load): Fix omitted cast error introduced by
8503 2011-06-06 change.
8504
2c8e37d4
MR
85052011-06-10 Martin Rudalics <rudalics@gmx.at>
8506
8507 * window.h (resize_proportionally, orig_total_lines)
8508 (orig_top_line): Remove from window structure.
8509 (set_window_height, set_window_width, change_window_heights)
8510 (Fdelete_window): Remove prototypes.
8511 (resize_frame_windows): Remove duplicate declaration.
8512
440a42e3
EZ
85132011-06-10 Eli Zaretskii <eliz@gnu.org>
8514
8515 * window.h (resize_frame_windows, resize_window_check)
8516 (delete_deletable_window, resize_root_window)
8517 (resize_frame_windows): Declare prototypes.
8518
8519 * window.c (resize_window_apply): Make definition be "static" to
8520 match the prototype.
8521
562dd5e9
MR
85222011-06-10 Martin Rudalics <rudalics@gmx.at>
8523
8524 * window.c: Remove declarations of Qwindow_size_fixed,
8525 window_min_size_1, window_min_size_2, window_min_size,
8526 size_window, window_fixed_size_p, enlarge_window, delete_window.
8527 Remove static from declaration of Qdelete_window, it's
8528 temporarily needed by Fbury_buffer.
8529 (replace_window): Don't assign orig_top_line and
8530 orig_total_lines.
8531 (Fdelete_window, delete_window): Remove. Window deletion is
8532 handled by window.el.
640c8776
SM
8533 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8534 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8535 (Fdelete_other_windows): Remove. Deleting other windows is
8536 handled by window.el.
8537 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8538 handled in window.el.
8539 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8540 Window minimum sizes are handled in window.el.
8541 (shrink_windows, size_window, set_window_height)
8542 (set_window_width, change_window_heights, window_height)
8543 (window_width, CURBEG, CURSIZE, enlarge_window)
8544 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8545 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8546 handled in window.el.
8547 (make_dummy_parent): Rename to make_parent_window and give it a
8548 second argument horflag.
8549 (make_window): Don't set resize_proportionally any more.
8550 (Fsplit_window): Remove. Windows are split in window.el.
8551 (save_restore_action, save_restore_orig_size)
8552 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8553 Resize mini windows in window.el.
8554 (grow_mini_window, shrink_mini_window): Implement by calling
8555 Qresize_root_window_vertically, resize_window_check and
8556 resize_window_apply.
640c8776
SM
8557 (saved_window, Fset_window_configuration, save_window_save):
8558 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8559 resize_proportionally.
8560 (window_min_height, window_min_width): Move to window.el.
8561 (keys_of_window): Move bindings for delete-other-windows,
8562 split-window, delete-window and enlarge-window to window.el.
8563
8564 * buffer.c: Temporarily extern Qdelete_window.
8565 (Fbury_buffer): Temporarily call Qdelete_window instead of
8566 Fdelete_window (Fbury_buffer will move to window.el soon).
8567
8568 * frame.c (set_menu_bar_lines_1): Remove code handling
8569 orig_top_line and orig_total_lines.
8570
8571 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8572 set_window_height but set heights directly.
8573 (change_frame_size_1): Use resize_frame_windows.
8574
8575 * xdisp.c (init_xdisp): Don't use set_window_height but set
8576 heights directly.
8577
640c8776
SM
8578 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8579 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8580 run_window_configuration_change_hook.
8581
8582 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8583 instead of change_window_heights and run
8584 run_window_configuration_change_hook.
8585
1a13852e
MR
85862011-06-09 Martin Rudalics <rudalics@gmx.at>
8587
8588 * window.c (replace_window): Rename second argument REPLACEMENT to
8589 NEW. New third argument SETFLAG. Rewrite.
8590 (delete_window, make_dummy_parent): Call replace_window with
8591 third argument 1.
8592 (window_list_1): Move down in code.
8593 (run_window_configuration_change_hook): Move set_buffer part
8594 before select_frame_norecord part in order to unwind correctly.
8595 Rename count1 to count.
8596 (recombine_windows, delete_deletable_window, resize_root_window)
8597 (Fdelete_other_windows_internal)
8598 (Frun_window_configuration_change_hook, make_parent_window)
8599 (resize_window_check, resize_window_apply, Fresize_window_apply)
8600 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8601 (Fdelete_window_internal, Fresize_mini_window_internal):
8602 New functions.
1a13852e
MR
8603 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8604
f3d1777e
MR
86052011-06-08 Martin Rudalics <rudalics@gmx.at>
8606
496e208e
MR
8607 * window.h (window): Add some new members to window structure -
8608 normal_lines, normal_cols, new_total, new_normal, clone_number,
8609 splits, nest, prev_buffers, next_buffers.
8610 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8611 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8612
f3d1777e
MR
8613 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8614 Remove.
496e208e
MR
8615 (make_dummy_parent): Set new members of windows structure.
8616 (make_window): Move down in code. Handle new members of window
8617 structure.
8618 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8619 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8620 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8621 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8622 (Fset_window_next_buffers, Fset_window_clone_number):
8623 New functions.
496e208e
MR
8624 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8625 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8626 Doc-string fixes.
8627 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8628 Argument WINDOW can be now internal window too.
8629 (Fwindow_use_time): Move up in code.
8630 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8631 Rewrite doc-string.
8632 (Fset_window_configuration, saved_window)
8633 (Fcurrent_window_configuration, save_window_save): Handle new
8634 members of window structure.
b9e809c2
MR
8635 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8636 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8637 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8638 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8639 Qget_mru_window, Qresize_root_window,
8640 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8641 Qauto_buffer_name; staticpro them.
f3d1777e 8642
abde8f8c
MR
86432011-06-07 Martin Rudalics <rudalics@gmx.at>
8644
8645 * window.c (Fwindow_total_size, Fwindow_left_column)
8646 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8647 (Fwindow_list_1): New functions.
8648 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8649 (Fwindow_width, Fscroll_left, Fscroll_right):
8650 Use window_body_cols instead of window_box_text_cols.
8651 (delete_window, Fset_window_configuration):
8652 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8653 (delete_all_subwindows): Take a window as argument and not a
8654 structure. Rewrite.
190b47e6
MR
8655 (window_loop): Remove handling of GET_LRU_WINDOW and
8656 GET_LARGEST_WINDOW.
8657 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8658
8659 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8660 window_box_text_cols. delete_all_subwindows now takes a
8661 Lisp_Object as argument.
abde8f8c 8662
640c8776
SM
8663 * indent.c (compute_motion, Fcompute_motion):
8664 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8665
fa8a67e6
MR
8666 * frame.c (delete_frame): Call delete_all_subwindows with root
8667 window as argument.
8668
a54e3482
DC
86692011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8670
8671 * fns.c (Fputhash): Document return value.
8672
60002bf5
CY
86732011-06-06 Chong Yidong <cyd@stupidchicken.com>
8674
8675 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8676
0c671da6 86772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8678
b862a52a 8679 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8680
be44ca6c
PE
8681 Check for overflow when converting integer to cons and back.
8682 * charset.c (Fdefine_charset_internal, Fdecode_char):
8683 Use cons_to_unsigned to catch overflow.
8684 (Fencode_char): Use INTEGER_TO_CONS.
8685 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8686 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8687 * data.c (long_to_cons, cons_to_long): Remove.
8688 (cons_to_unsigned, cons_to_signed): New functions.
8689 These signal an error for invalid or out-of-range values.
8690 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8691 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8692 * font.c (Ffont_variation_glyphs):
8693 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8694 * lisp.h: Include <intprops.h>.
8695 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8696 (cons_to_signed, cons_to_unsigned): New decls.
8697 (long_to_cons, cons_to_long): Remove decls.
8698 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8699 (Fprimitive_undo): Use CONS_TO_INTEGER.
8700 * xfns.c (Fx_window_property): Likewise.
8701 * xselect.c: Include <limits.h>.
8702 (x_own_selection, selection_data_to_lisp_data):
8703 Use INTEGER_TO_CONS.
8704 (x_handle_selection_request, x_handle_selection_clear)
8705 (x_get_foreign_selection, Fx_disown_selection_internal)
8706 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8707 (lisp_data_to_selection_data): Use cons_to_unsigned.
8708 (x_fill_property_data): Use cons_to_signed.
8709 Report values out of range.
8710
d1f3d2af
PE
8711 Check for buffer and string overflow more precisely.
8712 * buffer.h (BUF_BYTES_MAX): New macro.
8713 * lisp.h (STRING_BYTES_MAX): New macro.
8714 * alloc.c (Fmake_string):
8715 * character.c (string_escape_byte8):
8716 * coding.c (coding_alloc_by_realloc):
8717 * doprnt.c (doprnt):
8718 * editfns.c (Fformat):
8719 * eval.c (verror):
8720 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8721 since they may not be the same number.
8722 * editfns.c (Finsert_char):
8723 * fileio.c (Finsert_file_contents):
8724 Likewise for BUF_BYTES_MAX.
8725
dd52fcea
PE
8726 * image.c: Use ptrdiff_t, not int, for sizes.
8727 (slurp_file): Switch from int to ptrdiff_t.
8728 All uses changed.
8729 (slurp_file): Check that file size fits in both size_t (for
8730 malloc) and ptrdiff_t (for sanity and safety).
8731
7f9bbdbb
PE
8732 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8733 if b->modtime has its maximal value.
8734
dfe18f82
PE
8735 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8736
84acfcf0
PE
8737 Don't assume time_t can fit into int.
8738 * buffer.h (struct buffer.modtime): Now time_t, not int.
8739 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8740 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8741
ccd9a01a
PE
8742 Minor fixes for signed vs unsigned integers.
8743 * character.h (MAYBE_UNIFY_CHAR):
8744 * charset.c (maybe_unify_char):
8745 * keyboard.c (read_char, reorder_modifiers):
8746 XINT -> XFASTINT, since the integer must be nonnegative.
8747 * ftfont.c (ftfont_spec_pattern):
8748 * keymap.c (access_keymap, silly_event_symbol_error):
8749 XUINT -> XFASTINT, since the integer must be nonnegative.
8750 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8751 since it makes no difference and we prefer signed.
8752 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8753 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8754 nonnegative.
8755
d6d100dd
SM
87562011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8757
8758 * window.h (Fwindow_frame): Declare.
8759
2b6148e4
PE
87602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8761
8762 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8763 (SPARE_MEMORY): Always define.
8764 (LARGE_REQUEST): Remove.
8765 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8766
f230ecc9
MR
87672011-06-06 Martin Rudalics <rudalics@gmx.at>
8768
727e958e
MR
8769 * lisp.h: Move EXFUNS for Fframe_root_window,
8770 Fframe_first_window and Fset_frame_selected_window to window.h.
8771
8772 * window.h: Move EXFUNS for Fframe_root_window,
8773 Fframe_first_window and Fset_frame_selected_window here from
8774 lisp.h.
8775
8776 * frame.c (Fwindow_frame, Fframe_first_window)
8777 (Fframe_root_window, Fframe_selected_window)
8778 (Fset_frame_selected_window): Move to window.c.
8779 (Factive_minibuffer_window): Move to minibuf.c.
8780 (Fother_visible_frames_p): New function.
8781
8782 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8783
f230ecc9
MR
8784 * window.c (decode_window, decode_any_window): Move up in code.
8785 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8786 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8787 (Fwindow_buffer): Move up and rewrite doc-string.
8788 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8789 (Fwindow_prev): New functions.
727e958e
MR
8790 (Fwindow_frame): Move here from frame.c. Accept any window as
8791 argument.
8792 (Fframe_root_window, Fframe_first_window)
8793 (Fframe_selected_window): Move here from frame.c. Accept frame
8794 or arbitrary window as argument. Update doc-strings.
8795 (Fminibuffer_window): Move up in code.
8796 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8797 (Fset_frame_selected_window): Move here from frame.c.
8798 Marginal rewrite.
727e958e
MR
8799 (Fselected_window, select_window, Fselect_window): Move up in
8800 code. Minor doc-string fixes.
f230ecc9 8801
4d09bcf6
PE
88022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8803
8804 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8805 Do not assume that spare memory exists; that assumption is valid
8806 only if SYSTEM_MALLOC.
8807 (LARGE_REQUEST): New macro, so that the issue of large requests
8808 is separated from the issue of spare memory.
8809
810928a2
AS
88102011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8811
172418ad
AS
8812 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8813 format. (Bug#8806)
8814
43f862f7
AS
8815 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8816
810928a2
AS
8817 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8818 before statements.
8819
a059fe24
JD
88202011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8821
8822 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8823
8824 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8825
8826 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8827 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8828
989bf368
JB
88292011-06-05 Juanma Barranquero <lekktu@gmail.com>
8830
8831 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8832
4b80f674
CY
88332011-06-04 Chong Yidong <cyd@stupidchicken.com>
8834
8835 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8836 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8837 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8838 New error handlers.
4b80f674
CY
8839 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8840 Obey Vx_select_enable_clipboard_manager. Catch errors in
8841 x_clipboard_manager_save (Bug#8779).
8842 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8843 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8844
99a33b77 88452011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8846
8847 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8848
99a33b77 88492011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8850
8851 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8852 in the current matrix if keep_current_p is non-zero.
8853
8264569d
EZ
88542011-06-04 Eli Zaretskii <eliz@gnu.org>
8855
8856 * bidi.c (bidi_level_of_next_char): Fix last change.
8857
57f97249
EZ
88582011-06-03 Eli Zaretskii <eliz@gnu.org>
8859
fec2107c 8860 Support bidi reordering of text covered by display properties.
57f97249 8861
fec2107c
EZ
8862 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8863 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8864 (bidi_cache_search, bidi_cache_iterator_state)
8865 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8866 (bidi_level_of_next_char, bidi_move_to_visually_next):
8867 Support character positions inside a run of characters covered by a
fec2107c
EZ
8868 display string.
8869 (bidi_paragraph_init, bidi_resolve_explicit_1)
8870 (bidi_level_of_next_char): Call bidi_fetch_char and
8871 bidi_fetch_char_advance instead of FETCH_CHAR and
8872 FETCH_CHAR_ADVANCE.
8873 (bidi_init_it): Initialize new members.
8874 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8875 definitions.
8876 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8877 instead of using explicit *_CHAR codes.
d6d100dd
SM
8878 (bidi_resolve_explicit, bidi_resolve_weak):
8879 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8880 bidirectional text is supported only in multibyte buffers.
8881 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8882 it to initialize the frame_window_p member of struct bidi_it.
8883 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8884 (bidi_resolve_explicit, bidi_resolve_weak)
8885 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8886 bidi_it->nchars is non-positive.
8887 (bidi_level_of_next_char): Don't try to lookup the cache for the
8888 next/previous character if nothing is cached there yet, or if we
8889 were just reseat()'ed to a new position.
c40e2fb2 8890
0e14fe90
EZ
8891 * xdisp.c (set_cursor_from_row): Set start and stop points
8892 according to the row's direction when priming the loop that looks
8893 for the glyph on which to display cursor.
8894 (single_display_spec_intangible_p): Function deleted.
8895 (display_prop_intangible_p): Reimplement to call
8896 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8897 Accept 3 additional arguments needed by handle_display_spec.
8898 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8899 values: lists, `(when COND...)' forms, etc.
8900 (single_display_spec_string_p): Support property values that are
8901 lists with the argument STRING its top-level element.
8902 (display_prop_string_p): Fix the condition for processing a
8903 property that is a list to be consistent with handle_display_spec.
fec2107c 8904 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8905 last portion of handle_display_prop.
8906 (compute_display_string_pos): Accept additional argument
8907 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8908 value of a `display' property is a "replacing spec".
8909 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8910 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8911 the display property, but just return a value indicating whether
8912 the display property will replace the characters it covers.
8913 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8914 frame_window_p members of struct bidi_it.
d6d100dd
SM
8915 (compute_display_string_pos, compute_display_string_end):
8916 New functions.
fec2107c
EZ
8917 (push_it): Accept second argument POSITION, where pop_it should
8918 jump to continue iteration.
8919 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8920
fec2107c
EZ
8921 * keyboard.c (adjust_point_for_property): Adjust the call to
8922 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8923
8924 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8925 (bidi_init_it): Update prototypes.
8926 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8927 (compute_display_string_pos, compute_display_string_end):
8928 Declare prototypes.
fec2107c
EZ
8929 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8930 EMACS_INT.
fc6f18ce 8931
40087514 89322011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8933
57f53182
PE
8934 Malloc failure behavior now depends on size of allocation.
8935 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8936 * lisp.h: Change signatures accordingly.
8937 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8938 All callers changed. (Bug#8762)
8939
8940 * gnutls.c: Use Emacs's memory allocators.
8941 Without this change, the gnutls library would invoke malloc etc.
8942 directly, which causes problems on non-SYNC_INPUT hosts, and which
8943 runs afoul of improving memory_full behavior. (Bug#8761)
8944 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8945 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8946 xfree instead of the default malloc, realloc, free.
8947 (Fgnutls_boot): No need to check for memory allocation failure,
8948 since xmalloc does that for us.
8949
ac32cd99 8950 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8951 * category.c (hash_get_category_set):
8952 * ccl.c (ccl_driver):
8953 * charset.c (Fdefine_charset_internal):
8954 * charset.h (struct charset.hash_index):
8955 * composite.c (get_composition_id, gstring_lookup_cache)
8956 (composition_gstring_put_cache):
8957 * composite.h (struct composition.hash_index):
8958 * dispextern.h (struct image.hash):
8959 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8960 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8961 (hashfn_equal, hashfn_user_defined, make_hash_table)
8962 (maybe_resize_hash_table, hash_lookup, hash_put)
8963 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8964 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8965 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8966 * image.c (make_image, search_image_cache, lookup_image)
8967 (xpm_put_color_table_h):
8968 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8969 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8970 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8971 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8972 * alloc.c (allocate_vectorlike):
8973 Check for overflow in vector size calculations.
8974 * ccl.c (ccl_driver):
8975 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8976 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8977 need to be updated by these changes.
40087514
PE
8978 * fns.c (make_hash_table, maybe_resize_hash_table):
8979 Check for integer overflow with large hash tables.
0de4bb68
PE
8980 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8981 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8982 (SXHASH_REDUCE): New macro.
8983 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8984 Use it instead of discarding useful hash info with large hash values.
8985 (sxhash_float): New function.
8986 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8987 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8988 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8989 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8990 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8991 Adjust signatures to match updated version of code.
8992 (consing_since_gc): Now EMACS_INT, since a single hash table can
8993 use more than INT_MAX bytes.
8994
698d32e2
DN
89952011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8996
8997 Make it possible to build with GCC-4.6+ -O2 -flto.
8998
8999 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9000
fd6fa53f
SM
90012011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9002
9003 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9004 Call minibuffer-inactive-mode.
9005
864db017
JB
90062011-05-31 Juanma Barranquero <lekktu@gmail.com>
9007
9008 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9009 Update dependencies.
9010
2ad0baf4
DN
90112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9012
9013 * data.c (init_data): Remove code for UTS, this system is not
9014 supported anymore.
9015
4fcc2638
DN
90162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9017
9018 Don't force ./temacs to start in terminal mode.
9019
9020 * frame.c (make_initial_frame): Initialize faces in all cases, not
9021 only when CANNOT_DUMP is defined.
9022 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9023
c56e0fd5
DN
90242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9025
9026 * dispnew.c (add_window_display_history): Use const for the string
9027 pointer. Remove declaration, not needed.
9028
333d54da 90292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9030
55d4c1b2 9031 Use 'inline', not 'INLINE'.
333d54da 9032 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9033 * alloc.c, fontset.c (INLINE): Remove.
9034 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9035 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9036 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9037 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9038 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9039
738db178
DN
90402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9041
9042 Make it possible to run ./temacs.
9043
9044 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9045 syms_of_callproc does the same thing. Remove test for
9046 "initialized", do it in the caller.
9047 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9048
620c53a6
SM
90492011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9050
9051 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9052 (read_minibuf): Use get_minibuffer.
9053 (syms_of_minibuf): Use DEFSYM.
9054 (Qmetadata): New var.
9055 * data.c (Qbuffer): Don't make it static.
9056 (syms_of_data): Use DEFSYM.
9057
e003a292
PE
90582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9059
9060 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9061 (CCL_CODE_MIN): New macro.
9062
ed008a6d
PE
90632011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9064
3687c2ef
PE
9065 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9066
ed008a6d
PE
9067 * eval.c (Qdebug): Now static.
9068 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9069 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9070 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9071
d66c4c7c
CY
90722011-05-29 Chong Yidong <cyd@stupidchicken.com>
9073
9074 * image.c: Various fixes to ImageMagick code comments.
9075 (Fimagemagick_types): Doc fix.
9076
5fbc2025
PE
90772011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9078
0196f88a
PE
9079 Minor fixes prompted by GCC 4.6.0 warnings.
9080
9081 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9082
5fbc2025
PE
9083 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9084 (x_clipboard_manager_save_all): Move extern decl to ...
9085 * xterm.h: ... here, so that it can be checked for consistency.
9086
1dd3c2d9
CY
90872011-05-29 Chong Yidong <cyd@stupidchicken.com>
9088
9089 * xselect.c (x_clipboard_manager_save_frame)
9090 (x_clipboard_manager_save_all): New functions.
9091 (Fx_clipboard_manager_save): Lisp function deleted.
9092
9093 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9094 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9095
9096 * xterm.h: Update prototype.
9097
5ba6571d
WX
90982011-05-28 William Xu <william.xwl@gmail.com>
9099
9100 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9101 exiting (Bug#8239).
9102
3eaff834
JM
91032011-05-28 Jim Meyering <meyering@redhat.com>
9104
e1900994 9105 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9106 * fns.c (to_uchar): Define.
9107 (crypto_hash_function): Use it to convert some newly-signed
9108 variables to unsigned, to avoid sign-extension bugs. For example,
9109 without this change, (md5 "truc") would evaluate to
9110 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9111 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9112 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9113
0f6990a7
PE
91142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9115
9116 Integer overflow fixes.
c8a9ca5a 9117
08686060
PE
9118 * dbusbind.c: Serial number integer overflow fixes.
9119 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9120 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9121 to hold a serial number that is too large for a fixnum.
9122 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9123 Check for serial numbers out of range. Decode any serial number
59568bf0 9124 that was so large that it became a float. (Bug#8722)
08686060 9125
2d1fc3c7
PE
9126 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9127 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9128 Use XFASTINT rather than XUINT when numbers are nonnegative.
9129 (xd_append_arg, Fdbus_method_return_internal):
9130 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9131 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9132 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9133 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9134 (Bug#8722)
2d1fc3c7 9135
c8a9ca5a
PE
9136 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9137
519e1d69
PE
9138 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9139
6df6ae42 9140 ccl: Add integer overflow checks.
30569699
PE
9141 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9142 (IN_INT_RANGE): New macros.
9143 (ccl_driver): Use them to check for integer overflow when
9144 decoding a CCL program. Many of the new checks are whether XINT (x)
9145 fits in int; it doesn't always, on 64-bit hosts. The new version
9146 doesn't catch all possible integer overflows, but it's an
847044ea 9147 improvement. (Bug#8719)
30569699 9148
c11285dc
PE
9149 * alloc.c (make_event_array): Use XINT, not XUINT.
9150 There's no need for unsigned here.
9151
fdccd48e
PE
9152 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9153 This follows up to the 2011-05-06 change that substituted uintptr_t
9154 for EMACS_INT. This case wasn't caught back then.
9155
37910ab2
PE
9156 Rework Fformat to avoid integer overflow issues.
9157 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9158 now (part of C89). Include <verify.h>.
9159 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9160 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9161 (Fformat): Avoid the prepass trying to compute sizes; it was only
9162 approximate and thus did not catch overflow reliably. Instead, walk
9163 through the format just once, formatting and computing sizes as we go,
9164 checking for integer overflow at every step, and allocating a larger
9165 buffer as needed. Keep track separately whether the format is
9166 multibyte. Keep only the most-recently calculated precision, rather
9167 than them all. Record whether each argument has been converted to
9168 string. Use EMACS_INT, not int, for byte and char and arg counts.
9169 Support field widths and precisions larger than INT_MAX. Avoid
9170 sprintf's undefined behavior with conversion specifications such as %#d
9171 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9172 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9173 formatting out-of-range floating point numbers with int
9173deec 9174 formats. (Bug#8668)
37910ab2 9175
2e6578fb
PE
9176 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9177
0ae6bdee
PE
9178 * data.c: Avoid integer truncation in expressions involving floats.
9179 * data.c: Include <intprops.h>.
9180 (arith_driver): When there's an integer overflow in an expression
9181 involving floating point, convert the integers to floating point
9182 so that the resulting value does not suffer from catastrophic
9183 integer truncation. For example, on a 64-bit host (* 4
9184 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9185 Do not rely on undefined behavior after integer overflow.
9186
de883a70
PE
9187 merge count_size_as_multibyte, parse_str_to_multibyte
9188 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9189 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9190 Check for integer overflow.
9191 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9192 since it's now a duplicate of the other. This is more of
9193 a character than a buffer op, so better that it's in character.c.
9194 * fns.c, print.c: Adjust to above changes.
9195
2ff916cb
PE
91962011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9197
9198 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9199
f1b54466
PE
92002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9201
fb1ac845
PE
9202 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9203 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9204 (x_clipboard_manager_save): Now static.
9205 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9206
f1b54466
PE
9207 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9208 (crypto_hash_function): Now static.
9209 Fix pointer signedness problems. Avoid unnecessary initializations.
9210
a9f737ee
CY
92112011-05-27 Chong Yidong <cyd@stupidchicken.com>
9212
9213 * termhooks.h (Vselection_alist): Make it terminal-local.
9214
9215 * terminal.c (create_terminal): Initialize it.
9216
9217 * xselect.c: Support for clipboard managers.
9218 (Vselection_alist): Move to termhooks.h as terminal-local var.
9219 (LOCAL_SELECTION): New macro.
9220 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9221 (symbol_to_x_atom): Remove gratuitous arg.
9222 (x_handle_selection_request, lisp_data_to_selection_data)
9223 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9224 (x_own_selection, x_get_local_selection, x_convert_selection):
9225 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9226 (some_frame_on_display): Delete unused function.
9227 (Fx_own_selection_internal, Fx_get_selection_internal)
9228 (Fx_disown_selection_internal, Fx_selection_owner_p)
9229 (Fx_selection_exists_p): New optional frame arg.
9230 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9231 (x_handle_selection_clear): Don't treat other terminals with the
9232 same keyboard specially. Use the terminal-local Vselection_alist.
9233 (x_clear_frame_selections): Use Frun_hook_with_args.
9234
9235 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9236
9237 * xterm.h: Add support for those atoms.
9238
e067f0c1
CY
92392011-05-26 Chong Yidong <cyd@stupidchicken.com>
9240
9241 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9242 (converted_selections, conversion_fail_tag): New global variables.
9243 (x_selection_request_lisp_error): Free the above.
9244 (x_get_local_selection): Remove unnecessary code.
9245 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9246 of converted selections stored in converted_selections.
9247 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9248 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9249 (x_convert_selection): New function.
9250 (x_handle_selection_event): Simplify.
9251 (x_get_foreign_selection): Don't ignore incoming requests while
9252 waiting for an answer; this will fail when we implement
9253 SAVE_TARGETS, and seems unnecessary anyway.
9254 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9255 (Vx_sent_selection_functions): Doc fix.
9256
0f4aebc0
LL
92572011-05-26 Leo Liu <sdl.web@gmail.com>
9258
9259 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9260
e61124cd
YM
92612011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9262
9263 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9264
9265 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9266 for fringe update if it has periodic bitmap.
ac389d0c 9267 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9268 and fringe_bitmap_periodic_p.
9269
9270 * fringe.c (get_fringe_bitmap_data): New function.
9271 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9272 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9273 row. Mark glyph row for fringe update if periodicity changed.
9274
9275 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9276 for fringe update unless it has periodic bitmap.
9277
f16d9837
KH
92782011-05-25 Kenichi Handa <handa@m17n.org>
9279
9280 * xdisp.c (get_next_display_element): Set correct it->face_id for
9281 a static composition.
9282
e1b90ef6
LL
92832011-05-24 Leo Liu <sdl.web@gmail.com>
9284
9285 * deps.mk (fns.o):
9286 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9287
9288 * fns.c (crypto_hash_function, Fsha1): New function.
9289 (Fmd5): Use crypto_hash_function.
9290 (syms_of_fns): Add Ssha1.
9291
7400048f
PE
92922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9293
9294 * gnutls.c: Remove unused macros.
9295 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9296 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9297 Remove macros that are defined and never used.
9298 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9299
abb71cf4
CY
93002011-05-22 Chong Yidong <cyd@stupidchicken.com>
9301
9302 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9303 (Fx_get_selection_internal): Minor cleanup.
9304 (Fx_own_selection_internal): Rename arguments for consistency with
9305 select.el.
9306
6307db39
PE
93072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9308
9309 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9310
f3d4e0a4
CY
93112011-05-22 Chong Yidong <cyd@stupidchicken.com>
9312
9313 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9314
4d8ade89
YM
93152011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9316
9317 * dispnew.c (scrolling_window): Don't exclude the case that the
9318 last enabled row in the desired matrix touches the bottom boundary.
9319
32078c8d
GM
93202011-05-21 Glenn Morris <rgm@gnu.org>
9321
9322 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9323 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9324 and add some more files.
32078c8d 9325
7285dc67
EZ
93262011-05-20 Eli Zaretskii <eliz@gnu.org>
9327
9328 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9329 report_file_error introduced by the change from 2011-05-07.
9330
89d1bd22
PE
93312011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9332
9333 * systime.h (Time): Define only if emacs is defined.
9334 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9335 where the include path doesn't have X11/X.h by default. See
9336 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9337
cd394be1 93382011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9339
9340 * composite.c (find_automatic_composition): Fix previous change.
9341
b9704ad9
GM
93422011-05-20 Glenn Morris <rgm@gnu.org>
9343
9344 * lisp.mk: New file, split from Makefile.in.
9345 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9346 (shortlisp): Remove.
9347 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9348
4a720484
GM
93492011-05-19 Glenn Morris <rgm@gnu.org>
9350
9351 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9352 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9353 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9354 (lisp): Set the order to that of loadup.el.
9355 (shortlisp): Make it a copy of $lisp.
9356 (SOME_MACHINE_LISP): Remove.
9357 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9358 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9359
a28d4396
KH
93602011-05-18 Kenichi Handa <handa@m17n.org>
9361
9362 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9363 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9364 (find_automatic_composition): Mostly rewrite for efficiency.
9365
a2b1fa8e
JB
93662011-05-18 Juanma Barranquero <lekktu@gmail.com>
9367
9368 * makefile.w32-in: Update dependencies.
9369
8e1f5610
CS
93702011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9371
9372 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9373 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9374
7025ee00 93752011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9376
cdfa6eab
PE
9377 Fix some integer overflow issues, such as string length overflow.
9378
06d6db33
PE
9379 * insdel.c (count_size_as_multibyte): Check for string overflow.
9380
2b4560a8
PE
9381 * character.c (lisp_string_width): Check for string overflow.
9382 Use EMACS_INT, not int, for string indexes and lengths; in
9383 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9384 the resulting string length overflows an EMACS_INT; instead,
9385 report a string overflow if no precision given. When checking for
9386 precision exhaustion, use a check that cannot possibly have
9387 integer overflow. (Bug#8675)
9388 * character.h (lisp_string_width): Adjust to new signature.
9389
cb93f9be
PE
9390 * alloc.c (string_overflow): New function.
9391 (Fmake_string): Use it. This doesn't change behavior, but saves
9392 a few bytes and will simplify future changes.
9393 * character.c (string_escape_byte8): Likewise.
9394 * lisp.h (string_overflow): New decl.
9395
1a1f3366
PE
9396 Fixups, following up to the user-interface timestamp change.
9397 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9398 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9399 * msdos.c (mouse_get_pos): Likewise.
9400 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9401 * w32gui.h (Time): Define by including "systime.h" rather than by
9402 declaring it ourselves. (Bug#8664)
9403
d4e3e4d3
PE
9404 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9405 * image.c (clear_image_cache): Likewise.
9406
f6a24d19
PE
9407 * term.c (term_mouse_position): Don't assume time_t wraparound.
9408
08dc5ae6
PE
9409 Be more systematic about user-interface timestamps.
9410 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9411 and sometimes 'EMACS_UINT', to represent these timestamps.
9412 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9413 This makes the code easier to follow, and makes it easier to catch
9414 integer overflow bugs such as Bug#8664.
9415 * frame.c (Fmouse_position, Fmouse_pixel_position):
9416 Use Time, not unsigned long, for user-interface timestamps.
9417 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9418 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9419 * keyboard.h (last_event_timestamp): Likewise.
9420 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9421 * menu.h (xmenu_show): Likewise.
9422 * term.c (term_mouse_position): Likewise.
9423 * termhooks.h (struct input_event.timestamp): Likewise.
9424 (struct terminal.mouse_position_hook): Likewise.
9425 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9426 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9427 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9428 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9429 what it was before.
9430 * menu.h, termhooks.h: Include "systime.h", for Time.
9431
8e55734a
PE
9432 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9433 Don't assume that the difference between two unsigned long values
9434 can fit into an integer. At this point, we know button_down_time
9435 <= event->timestamp, so the difference must be nonnegative, so
9436 there's no need to cast the result if double-click-time is
9437 nonnegative, as it should be; check that it's nonnegative, just in
9438 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9439 apart (about 25 days). (Bug#8664)
8e55734a 9440
841f1b75 9441 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9442 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9443
3e26f69c
PE
9444 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9445 that always fit in int. Use a sentinel instead of a counter, to
9446 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9447 * frame.h (struct frame): Use int for menu_bar_items_used
9448 instead of EMACS_INT, since it always fits in int.
3e26f69c 9449
5cc152c0
PE
9450 * menu.c (grow_menu_items): Check for int overflow.
9451
d89eb65e
PE
9452 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9453
5235bd3e
PE
9454 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9455 Before, the code was not consistent. These values cannot exceed
9456 2**31 - 1 so there's no need to make them unsigned.
9457 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9458 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9459 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9460 as modifiers.
9461 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9462
bc827e23
PE
9463 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9464 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9465 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9466 presumably because the widths might not match.
9467
78eb494e
PE
9468 * window.c (size_window): Avoid needless test at loop start.
9469
04f2d78b
CB
94702011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9471
9472 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9473
d2fc7e3d 94742011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9475
9476 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9477
d2fc7e3d 94782011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9479
9480 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9481 `width' to `bar_area_x' and `bar_area_width', respectively.
9482 (x_scroll_run): Take account of fringe background extension.
9483
04f2d78b
CB
9484 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9485 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9486 `bar_area_width', respectively.
9487 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9488 background extension.
9489
79b70037
GM
94902011-05-10 Jim Meyering <meyering@redhat.com>
9491
9492 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9493
2f142cc5
JB
94942011-05-10 Juanma Barranquero <lekktu@gmail.com>
9495
9496 * image.c (Finit_image_library): Return t for built-in image types,
9497 like pbm and xbm. (Bug#8640)
9498
57679c86
AS
94992011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9500
9501 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9502
888c9e86
EZ
95032011-05-07 Eli Zaretskii <eliz@gnu.org>
9504
b0512a1d
EZ
9505 * w32console.c (Fset_screen_color): Doc fix.
9506 (Fget_screen_color): New function.
9507 (syms_of_ntterm): Defsubr it.
9508
7285dc67
EZ
9509 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9510 unlink the temporary file if Fcall_process didn't create it in the
9511 first place.
9512 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9513 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9514 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9515 cue to call_process_cleanup not to close that handle.
9516
4d3fcc8e
BK
95172011-05-07 Ben Key <bkey76@gmail.com>
9518
9519 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9520 one of two shell specific rules, either bootstrap-temacs-CMD or
9521 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9522 to the previous implementation of the bootstrap-temacs rule.
9523 The bootstrap-temacs-CMD rule is similar to the previous
9524 implementation of the bootstrap-temacs rule except that it
9525 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9526 variable.
9527
9528 These changes, along with some changes to nt/configure.bat,
9529 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9530 earlier fix to add support for --cflags and --ldflags options
9531 that include quotes so that it works whether make uses cmd or
9532 sh as the shell.
9533
b4289b64
MA
95342011-05-06 Michael Albinus <michael.albinus@gmx.de>
9535
9536 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9537 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9538 is a constant.
9539 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9540 a string. Handle both cases.
9541 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9542 (Fdbus_register_method): Use Qinvalid_function.
9543
af4c0e28
JB
95442011-05-06 Juanma Barranquero <lekktu@gmail.com>
9545
9546 * makefile.w32-in: Update dependencies.
9547 (LISP_H): Add inttypes.h and stdin.h.
9548 (PROCESS_H): Add unistd.h.
9549
c51453d9
EZ
95502011-05-06 Eli Zaretskii <eliz@gnu.org>
9551
9552 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9553 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9554
8ff0ac3c 95552011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9556
4c4b566b
PE
9557 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9558
aab2b9b5
PE
9559 * term.c (vfatal): Remove stray call to va_end.
9560 It's not needed and the C Standard doesn't allow it here anyway.
9561
c378da0b
PE
9562 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9563 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9564
288b08c7
PE
9565 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9566 bytes.
9567
e3601888
PE
9568 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9569
db6c0e74
PE
9570 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9571
dd5963ea
PE
9572 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9573
88c9450f
PE
9574 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9575
2f9442b8
PE
9576 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9577
c032b5f8
PE
9578 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9579 * charset.c (Fdefine_charset_internal): Don't initialize
9580 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9581 32-bit int (Bug#8600).
a108c10b
PE
9582
9583 * lread.c (read_integer): Be more consistent with string-to-number.
9584 Use string_to_number to do the actual conversion; this avoids
9585 rounding errors and fixes some other screwups. Without this fix,
9586 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9587 (digit_to_number): Move earlier, for benefit of read_integer.
9588 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9589 not a digit in any supported base. (Bug#8602)
a108c10b 9590
ad5f9eea
PE
9591 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9592
aec1708a
PE
9593 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9594 to match comment at start of function. This also removes a
9595 GCC warning about overflow in a 32+64-bit port.
9596
47be4ab5
PE
9597 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9598
371cac43
PE
9599 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9600 Reported by Stefan Monnier in
9601 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9602 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9603 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9604
d01a7826
PE
9605 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9606 (EMACS_UINTPTR): Likewise, with uintptr_t.
9607
7fd47d5c
PE
9608 * lisp.h: Prefer 64-bit EMACS_INT if available.
9609 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9610 on 32-bit hosts that have 64-bit int, so that they can access
9611 large files.
122b0c86
PE
9612 However, temporarily disable this change unless the temporary
9613 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9614
8727937b
PE
9615 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9616
8ac068ac
PE
9617 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9618 This removes an assumption that EMACS_INT and long are the same
9619 width as pointers. The assumption is true for Emacs porting targets
9620 now, but we want to make other targets possible.
9621 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9622 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9623 In the rest of the code, change types of integers that hold casted
9624 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9625 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9626 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9627 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9628 No need to cast type when ORing.
9629 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9630 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9631 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9632 assume EMACS_INT is the same width as char *.
9633 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9634 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9635 Remove no-longer-needed casts.
9636 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9637 (xg_tool_bar_help_callback, xg_make_tool_item):
9638 Use EMACS_INTPTR to hold an integer
9639 that will be cast to void *; this can avoid a GCC warning
9640 if EMACS_INT is not the same width as void *.
9641 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9642 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9643 (current_message_1, set_message_1):
9644 Use a local to convert to proper width without a cast.
9645 * xmenu.c (dialog_selection_callback): Likewise.
9646
ede49d71
PE
9647 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9648 Also, don't assume VALBITS / RAND_BITS is less than 5,
9649 and don't rely on undefined behavior when shifting a 1 left into
9650 the sign bit.
9651 * lisp.h (get_random): Change signature to match.
9652
2f30ecd0
PE
9653 * lread.c (hash_string): Use size_t, not int, for hash computation.
9654 Normally we prefer signed values; but hashing is special, because
9655 it's better to use unsigned division on hash table sizes so that
9656 the remainder is nonnegative. Also, size_t is the natural width
9657 for hashing into memory. The previous code used 'int', which doesn't
9658 retain enough info to hash well into very large tables.
9659 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9660
2a866e7b
PE
9661 * dbusbind.c: Don't possibly lose pointer info when converting.
9662 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9663 Use XPNTR rather than XHASH, so that the high-order bits of
9664 the pointer aren't lost when converting through void *.
9665
51639eac
PE
9666 * eval.c (Fautoload): Don't double-shift a pointer.
9667
92394119
PE
9668 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9669
dbdb9a7c
JB
96702011-05-06 Juanma Barranquero <lekktu@gmail.com>
9671
9672 * gnutls.c (DEF_GNUTLS_FN):
9673 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9674
db7a0b4f
AS
96752011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9676
9677 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9678 marker. (Bug#8610)
9679
cd394be1 96802011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9681
9682 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9683 New version that can reserve upto 2GB of heap space.
9684
f7ff1b0f 96852011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9686
9687 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9688
639c109b
TZ
96892011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9690
9691 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9692 `gnutls_certificate_set_x509_key_file'.
9693
d2127135
JB
96942011-05-05 Juanma Barranquero <lekktu@gmail.com>
9695
9696 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9697 Update dependencies.
9698
e968f4f3
JB
96992011-05-04 Juanma Barranquero <lekktu@gmail.com>
9700
9701 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9702 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9703 Remove unused parameter `fildes'.
9704 * process.c (read_process_output, send_process): Don't pass it.
9705
84d358f0
JB
97062011-05-04 Juanma Barranquero <lekktu@gmail.com>
9707
9708 Fix previous change: the library cache is defined in w32.c.
9709 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9710 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9711
0898ca10
JB
97122011-05-04 Juanma Barranquero <lekktu@gmail.com>
9713
9714 Implement dynamic loading of GnuTLS on Windows.
9715
9716 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9717 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9718 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9719 Declare.
9720
9721 * gnutls.c (Qgnutls_dll): Define.
9722 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9723 (gnutls_*): Declare function pointers.
9724 (init_gnutls_functions): New function to initialize function pointers.
9725 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9726 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9727 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9728 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9729 (emacs_gnutls_write, emacs_gnutls_read)
9730 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9731 (Fgnutls_available_p): New function.
9732 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9733 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9734 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9735
9736 * image.c: Include w32.h.
9737 (Vimage_type_cache): Delete.
9738 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9739 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9740 (w32_delayed_load): Move to w32.c.
9741
9742 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9743
9744 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9745 (w32_delayed_load): Move from image.c. When loading a library, record
9746 its filename in the :loaded-from property of the library id.
9747 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9748 Initialize and staticpro them.
9749 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9750
9751 * process.c: Include lisp.h before w32.h, not after.
9752 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9753 instead of gnutls_record_check_pending.
9754
9755 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9756
ff4de4aa
TZ
97572011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9758
9759 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9760 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9761 as passed in.
9762
abe95abb
JD
97632011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9764
9765 * xterm.c (x_set_frame_alpha): Do not set property on anything
9766 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9767
e16e55d4
JB
97682011-05-02 Juanma Barranquero <lekktu@gmail.com>
9769
9770 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9771
bafcf6a5
JB
97722011-05-02 Juanma Barranquero <lekktu@gmail.com>
9773
9774 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9775 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9776 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9777 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9778 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9779 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9780 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9781 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9782 (Qgnutls_bootprop_callbacks_verify): Make static.
9783
e7a6747f
AS
97842011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9785
19ed11ba
AS
9786 * callproc.c: Indentation fixup.
9787
e7a6747f 9788 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9789 (wait_for_termination, interruptible_wait_for_termination):
9790 Move after wait_for_termination_1.
e7a6747f 9791
1ef14cb4
LMI
97922011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9793
9794 * sysdep.c (interruptible_wait_for_termination): New function
9795 which is like wait_for_termination, but allows keyboard
9796 interruptions.
9797
9798 * callproc.c (Fcall_process): Add (:file "file") as an option for
9799 the STDOUT buffer.
9800 (Fcall_process_region): Ditto.
9801
330d880c
EZ
98022011-04-30 Eli Zaretskii <eliz@gnu.org>
9803
8db90b73
EZ
9804 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9805 rather than `XVECTOR (FOO)->size'.
9806
330d880c
EZ
9807 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9808 inttypes.h, as a gnulib replacement is used if it not available in
9809 system headers.
9810
15cbd324
EZ
98112011-04-21 Eli Zaretskii <eliz@gnu.org>
9812
9813 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9814 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9815 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9816
9817 * coding.c (coding_alloc_by_realloc): Error out if destination
9818 will grow beyond MOST_POSITIVE_FIXNUM.
9819 (decode_coding_emacs_mule): Abort if there isn't enough place in
9820 charbuf for the composition carryover bytes. Reserve an extra
9821 space for up to 2 characters produced in a loop.
9822 (decode_coding_iso_2022): Abort if there isn't enough place in
9823 charbuf for the composition carryover bytes.
9824
98252011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9826
ae940cca
EZ
9827 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9828 aborting when %lld or %lll format is passed.
9829 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9830 %llo or %llx format is passed. (Bug#8545)
9831
03ab8921
EZ
9832 * window.c (window_scroll_line_based): Use a marker instead of
9833 simple variables to record original value of point. (Bug#7952)
9834
afda1437
EZ
9835 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9836 produced by %s or %c overflows available buffer space. (Bug#8545)
9837
f76dee0c
PE
98382011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9839
9840 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9841 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9842
fdc5744d
JB
98432011-04-28 Juanma Barranquero <lekktu@gmail.com>
9844
9845 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9846
638f053a
JB
98472011-04-28 Juanma Barranquero <lekktu@gmail.com>
9848
9849 * keyboard.c (Qdelayed_warnings_hook): Define.
9850 (command_loop_1): Run `delayed-warnings-hook'
9851 if Vdelayed_warnings_list is non-nil.
9852 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9853 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9854
d178f871
EZ
98552011-04-28 Eli Zaretskii <eliz@gnu.org>
9856
9857 * doprnt.c (doprnt): Don't return value smaller than the buffer
9858 size if the message was truncated. (Bug#8545).
9859
b124fd93
JB
98602011-04-28 Juanma Barranquero <lekktu@gmail.com>
9861
9862 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9863 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9864
e810457d
PE
98652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9866
9867 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9868
ea51cceb
JB
98692011-04-27 Juanma Barranquero <lekktu@gmail.com>
9870
9871 * makefile.w32-in: Update dependencies.
9872
94dcfacf
EZ
98732011-04-27 Eli Zaretskii <eliz@gnu.org>
9874
9875 Improve `doprnt' and its usage. (Bug#8545)
9876 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9877 `format_end'. Remove support for %l as a conversion specifier.
9878 Don't use xrealloc. Improve diagnostics when the %l size modifier
9879 is used. Update the commentary.
9880
9881 * eval.c (verror): Simplify calculation of size_t.
9882
9883 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9884 messages.
9885
f61f41d7
PE
98862011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9887
9888 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9889 change.
9890
96fb4434
PE
98912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9892
9893 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9894 This makes this file independent of the recent pseudovector change.
9895
671875da 98962011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9897
69e9b5a3
PE
9898 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9899
b5f869a7 9900 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9901 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9902 Remove unused local.
c8926152 9903 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9904
841a1577 9905 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9906 GCC 4.6.0 optimizes based on type-based alias analysis.
9907 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9908 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9909 != &v->size, and therefore "v->size = 1; b->size = 2; return
9910 v->size;" must therefore return 1. This assumption is incorrect
9911 for Emacs, since it type-puns struct Lisp_Vector * with many other
9912 types. To fix this problem, this patch adds a new type struct
f904488f 9913 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9914 and pseudovectors, and helps optimizing compilers not get fooled
9915 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9916 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9917 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9918 the size member.
eab3844f
PE
9919 (XSETPVECTYPE): Rewrite in terms of new macro.
9920 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9921 This is a bit clearer, and further avoids the possibility of
9922 undesirable aliasing.
9923 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9924 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9925 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9926 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9927 (ASIZE): Now uses header.size rather than size.
9928 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9929 to avoid the hassle of writing XVECTOR (foo)->header.size.
9930 (struct vectorlike_header): New type.
eab3844f
PE
9931 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9932 object, to help avoid aliasing.
9933 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9934 (SUBRP): Likewise, since Lisp_Subr is a special case.
9935 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9936 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9937 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9938 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9939 changed to be "header.size" and "header.next".
9940 * buffer.h (struct buffer): Likewise.
9941 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9942 * frame.h (struct frame): Likewise.
9943 * process.h (struct Lisp_Process): Likewise.
9944 * termhooks.h (struct terminal): Likewise.
9945 * window.c (struct save_window_data, struct saved_window): Likewise.
9946 * window.h (struct window): Likewise.
9947 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9948 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9949 * buffer.c (init_buffer_once): Likewise.
9950 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9951 special case.
9952 * process.c (Fformat_network_address): Use local var for size,
9953 for brevity.
9954
0df1eac5
PE
9955 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9956
847ab9d1 9957 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9958 * data.c (atof): Remove decl; no longer used or needed.
9959 (digit_to_number): Move to lread.c.
9960 (Fstring_to_number): Use new string_to_number function, to be
9961 consistent with how the Lisp reader treats infinities and NaNs.
9962 Do not assume that floating-point numbers represent EMACS_INT
9963 without losing information; this is not true on most 64-bit hosts.
9964 Avoid double-rounding errors, by insisting on integers when
9965 parsing non-base-10 numbers, as the documentation specifies.
9966 * lisp.h (string_to_number): New decl, replacing ...
9967 (isfloat_string): Remove.
bc0a5c13 9968 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9969 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9970 appears to have been a coding error. Similarly, do not accept
9971 strings like +-1e0 as floating point numbers. Do not report
9972 overflow for integer overflows unless the base is not 10 which
9973 means we have no simple and reliable way to continue.
9974 Break out the floating-point parsing into a new
9975 function string_to_number, so that Fstring_to_number parses
9976 floating point numbers consistently with the Lisp reader.
04f2d78b 9977 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9978 (E_CHAR, EXP_INT): Remove, replacing with ...
9979 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9980 (string_to_number): New function, replacing isfloat_string.
9981 This function checks for valid syntax and produces the resulting
9982 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9983 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9984 so that overflow for non-base-10 numbers is reported only when
9985 there's no portable and simple way to convert to floating point.
452f4150 9986
67769ffc
PE
9987 * textprop.c (set_text_properties_1): Rewrite for clarity,
9988 and to avoid GCC warning about integer overflow.
9989
c20db43f
PE
9990 * intervals.h (struct interval): Use EMACS_INT for members
9991 where EMACS_UINT might cause problems. See
9992 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9993 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9994 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9995 All uses changed.
37aa2f85
PE
9996 (offset_intervals): Tell GCC not to worry about length overflow
9997 when negating a negative length.
c20db43f 9998
2538aa2f
PE
9999 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10000 (overrun_check_free): Likewise.
10001
f2d3008d
PE
10002 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10003 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10004 word size.
10005
ec8df744
PE
10006 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10007 (gnutls_make_error): Rename local to avoid shadowing.
10008 (gnutls_emacs_global_deinit): ifdef out; not used.
10009 (Fgnutls_boot): Use const for pointer to readonly storage.
10010 Comment out unused local. Fix pointer signedness problems.
10011
640ee02d
PE
10012 * lread.c (openp): Don't stuff size_t into an 'int'.
10013 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10014 about possible signed overflow.
10015
6048fb2a
PE
10016 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10017 (GDK_KEY_g): Don't define if already defined.
10018 (xg_prepare_tooltip): Avoid pointer signedness problem.
10019 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10020
fa3c87e1
PE
10021 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10022 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10023
2172544b
PE
10024 * xfns.c (Fx_window_property): Simplify a bit,
10025 to make a bit faster and to avoid GCC 4.6.0 warning.
10026 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10027
9b821a21
PE
10028 * fns.c (internal_equal): Don't assume size_t fits in int.
10029
3c616cfa
PE
10030 * alloc.c (compact_small_strings): Tighten assertion a little.
10031
c2982e87
PE
10032 Replace pEd with more-general pI, and fix some printf arg casts.
10033 * lisp.h (pI): New macro, generalizing old pEd macro to other
10034 conversion specifiers. For example, use "...%"pI"d..." rather
10035 than "...%"pEd"...".
10036 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10037 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10038 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10039 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10040 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10041 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10042 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10043 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10044 64-bit hosts.
10045 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10046 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10047 * print.c (safe_debug_print, print_object): Likewise.
10048 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10049 to int.
6f04d126
PE
10050 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10051 avoiding the 0 flag, which is not portable.
c2982e87
PE
10052 * process.c (Fmake_network_process): Use pI to avoid cast.
10053 * region-cache.c (pp_cache): Likewise.
10054 * xdisp.c (decode_mode_spec): Likewise.
10055 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10056 behavior on 64-bit hosts with printf arg.
6f04d126 10057 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10058 (x_stop_queuing_selection_requests): Likewise.
10059 (x_get_window_property): Don't truncate byte count to an 'int'
10060 when tracing.
0b432f21 10061
5e073ec7
PE
10062 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10063 here, since it parses constructs like leading '-' and spaces,
10064 which are not wanted; and it overflows with large numbers.
10065 Instead, simply match F[0-9]+, which is what is wanted anyway.
10066
36372bf9
PE
10067 * alloc.c: Remove unportable assumptions about struct layout.
10068 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10069 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10070 (allocate_vectorlike, make_pure_vector): Use the new macros,
10071 plus offsetof, to remove unportable assumptions about struct layout.
10072 These assumptions hold on all porting targets that I know of, but
10073 they are not guaranteed, they're easy to remove, and removing them
10074 makes further changes easier.
10075
0b432f21
PE
10076 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10077 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10078 (string_overrun_cookie): Now const. Use initializers that
10079 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10080 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10081 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10082 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10083 multiple of sizeof (EMACS_INT); it need not be, if
10084 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10085 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10086
895009e1
JB
100872011-04-26 Juanma Barranquero <lekktu@gmail.com>
10088
10089 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10090
6a7a1b0b
TZ
100912011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10092
10093 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10094 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10095 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10096
841a1577 100972011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10098
10099 * lisp.h (Qdebug): List symbol.
895009e1 10100 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10101 * keyboard.c (debug-on-event): New variable.
10102 (handle_user_signal): Break into debugger when debug-on-event
10103 matches the current signal symbol.
10104
f2d3ba6f
DN
101052011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10106
10107 * alloc.c (check_sblock, check_string_bytes)
10108 (check_string_free_list): Convert to standard C.
10109
42ce4c63
TZ
101102011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10111
10112 * w32.c (emacs_gnutls_push): Fix typo.
10113
825cd63c
EZ
101142011-04-25 Eli Zaretskii <eliz@gnu.org>
10115
fb11d64d
EZ
10116 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10117 "cast to pointer from integer of different size".
10118
825cd63c
EZ
10119 Improve doprnt and its use in verror. (Bug#8545)
10120 * doprnt.c (doprnt): Document the set of format control sequences
10121 supported by the function. Use SAFE_ALLOCA instead of always
10122 using `alloca'.
10123
10124 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10125 is one byte too soon. Don't use xrealloc; instead xfree and
10126 xmalloc anew.
10127
e061a11b
TZ
101282011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10129
10130 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10131 callbacks stage.
10132
10133 * gnutls.c: Renamed global_initialized to
10134 gnutls_global_initialized. Added internals for the
10135 :verify-hostname-error, :verify-error, and :verify-flags
10136 parameters of `gnutls-boot' and documented those parameters in the
10137 docstring. Start callback support.
9173deec
JB
10138 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10139 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10140 on error. Return error code.
e061a11b
TZ
10141 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10142 (emacs_gnutls_read): Likewise.
10143 (Fgnutls_boot): Return handshake error code.
10144 (emacs_gnutls_handle_error): New function.
10145 (wsaerror_to_errno): Likewise.
10146
10147 * w32.h (emacs_gnutls_pull): Add prototype.
10148 (emacs_gnutls_push): Likewise.
10149
10150 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10151 (emacs_gnutls_push): Likewise.
10152
101532011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10154
10155 * process.c (wait_reading_process_output): Check if GnuTLS
10156 buffered some data internally if no FDs are set for TLS
10157 connections.
10158
10159 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10160 (LIBS): Link to USER_LIBS.
10161 ($(BLD)/gnutls.$(0)): New target.
10162
fa6996bc
EZ
101632011-04-24 Eli Zaretskii <eliz@gnu.org>
10164
eb35682e
EZ
10165 * xdisp.c (handle_single_display_spec): Rename the
10166 display_replaced_before_p argument into display_replaced_p, to
10167 make it consistent with the commentary. Fix typos in the
10168 commentary.
10169
e2ad650c
EZ
10170 * textprop.c (syms_of_textprop): Remove dead code.
10171 (copy_text_properties): Delete obsolete commentary about an
10172 interface that was deleted long ago. Fix typos in the description
10173 of arguments.
10174
1b2de274
EZ
10175 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10176 to changes in oldXMenu/XMenu.h from 2011-04-16.
10177 <menu_help_message, prev_menu_help_message>: Constify.
10178 (IT_menu_make_room): menu->help_text is now `const char **';
10179 adjust.
10180
10181 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10182 to changes in oldXMenu/XMenu.h from 2011-04-16.
10183 (struct XMenu): Declare `help_text' `const char **'.
10184
10185 * xfaces.c <Qunspecified>: Make extern again.
10186
10187 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10188 required by POSIX.
1b2de274 10189
762b15be
EZ
10190 * doc.c (get_doc_string): Improve the format passed to `error'.
10191
10192 * doprnt.c (doprnt): Improve commentary.
10193
10194 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10195
10196 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10197 them with etags.
10198
f1052e5d
EZ
10199 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10200 changes in globals.h immediately force recompilation.
762b15be
EZ
10201 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10202 $(CURDIR)/s/ms-w32.h.
10203 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10204
fa6996bc
EZ
10205 * character.c (Fchar_direction): Function deleted.
10206 (syms_of_character): Don't defsubr it.
10207 <char-direction-table>: Deleted.
10208
e6c3da20
EZ
102092011-04-23 Eli Zaretskii <eliz@gnu.org>
10210
10211 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10212 * doprnt.c: Include limits.h.
10213 (SIZE_MAX): New macro.
04f2d78b
CB
10214 (doprnt): Return a size_t value. 2nd arg is now size_t.
10215 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10216 Improve overflow protection. Support `l' modifier for integer
10217 conversions. Support %l conversion. Don't assume an EMACS_INT
10218 argument for integer conversions and for %c.
10219
10220 * lisp.h (doprnt): Restore prototype.
10221
10222 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10223 $(SRC)/character.h.
10224
10225 * Makefile.in (base_obj): Add back doprnt.o.
10226
10227 * deps.mk (doprnt.o): Add back prerequisites.
10228 (callint.o): Depend on character.h.
10229
10230 * eval.c (internal_lisp_condition_case): Include the handler
10231 representation in the error message.
10232 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10233 when breaking from the loop.
10234
10235 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10236
10237 * callint.c (Fcall_interactively): When displaying error message
10238 about invalid control letter, pass the character's codepoint, not
10239 a pointer to its multibyte form. Improve display of the character
10240 in octal and display also its hex code.
10241
10242 * character.c (char_string): Use %x to display the (unsigned)
10243 codepoint of an invalid character, to avoid displaying a bogus
10244 negative value.
10245
10246 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10247 `error', not SYMBOL_NAME itself.
10248
10249 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10250 character arguments to `error'.
10251
10252 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10253 to `error' in error message about FINAL_CHAR argument. Make sure
10254 FINAL_CHAR is a character, and use %c when it is passed as
10255 argument to `error'.
10256
4ffd0d6b 102572011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10258
10259 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10260
10261 * w32.c: Include <time.h>.
10262 (sys_localtime): New function.
10263
4ffd0d6b 102642011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10265
10266 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10267
4ffd0d6b 10268 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10269
4ffd0d6b 102702011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10271
4ffd0d6b
GM
10272 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10273 zombies (Bug#8467).
aac0c6e3 10274
04c56954
EZ
102752011-04-19 Eli Zaretskii <eliz@gnu.org>
10276
10277 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10278 gl_state.e_property when gl_state.object is Qt.
10279
10280 * insdel.c (make_gap_larger): Remove limitation of buffer size
10281 to <= INT_MAX.
10282
16a43933
CY
102832011-04-18 Chong Yidong <cyd@stupidchicken.com>
10284
10285 * xdisp.c (lookup_glyphless_char_display)
10286 (produce_glyphless_glyph): Handle cons cell entry in
10287 glyphless-char-display.
10288 (Vglyphless_char_display): Document it.
10289
10290 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10291 glyphless-char-display.
10292
4581706e
CY
102932011-04-17 Chong Yidong <cyd@stupidchicken.com>
10294
10295 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10296
10297 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10298
10299 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10300 definition for no-X builds.
10301
4887c6e2 103022011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10303
fd35b6f9
PE
10304 Static checks with GCC 4.6.0 and non-default toolkits.
10305
5c1ccb01
PE
10306 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10307
006c5daa
PE
10308 * process.c (keyboard_bit_set): Define only if SIGIO.
10309 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10310 (send_process): Repair possible setjmp clobbering.
10311
efc736d3
PE
10312 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10313
4e2fe2e6
PE
10314 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10315
f97334a2
PE
10316 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10317
4e75f29d
PE
10318 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10319 Define only if needed.
10320
90efadd1
PE
10321 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10322 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10323 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10324
3c647824
PE
10325 * dispextern.h (struct redisplay_interface): Rename param
10326 to avoid shadowing.
e264f262 10327 * termhooks.h (struct terminal): Likewise.
761383f4 10328 * xterm.c (xembed_send_message): Likewise.
3c647824 10329
b58c5c4a
PE
10330 * insdel.c (make_gap_smaller): Define only if
10331 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10332
cad59032
PE
10333 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10334 it.
10335
c339dc2e
PE
10336 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10337 so that we aren't warned about unused symbols.
10338
91a3e27b
PE
10339 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10340
399c71d3 10341 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10342
8ffc96f5
PE
10343 * xfns.c (x_real_positions): Mark locals as initialized.
10344
eef9bc79
PE
10345 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10346
098db9dd
PE
10347 * xterm.c: Fix problems found by static analysis with other toolkits.
10348 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10349 (x_dispatch_event): Declare static if USE_GTK, and
10350 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10351 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10352 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10353 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10354 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10355
eb18f6cc
PE
10356 * xmenu.c (menu_help_callback): Pointer type fixes.
10357 Use const pointers when pointing at readonly data. Avoid pointer
10358 signedness clashes.
10359 (FALSE): Remove unused macro.
10360 (update_frame_menubar): Remove unused decl.
10361
1fe72bf8
PE
10362 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10363
60d9e1db
PE
10364 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10365 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10366 (single_menu_item): Rename local to avoid shadowing.
10367
39261c26
PE
10368 * keyboard.c (make_lispy_event): Remove unused local var.
10369
018c5e19
PE
10370 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10371 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10372
63d2b86e
PE
10373 * bitmaps: Change bitmaps from unsigned char back to the X11
10374 compatible char. Avoid the old compiler warnings about
10375 out-of-range initializers by using, for example, '\xab' rather
10376 than 0xab.
10377
aefd87e1
PE
10378 * xgselect.c (xgselect_initialize): Check vs interface
10379 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10380
bf501fb9
PE
10381 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10382
e9829fdf
PE
10383 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10384 to read-only memory.
10385
1086c095
PE
10386 * fns.c (vector): Remove; this old hack is no longer needed.
10387
2baccd04 10388 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10389 Remove unused var.
dde42981 10390 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10391
72391843 10392 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10393
436c16df 10394 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10395 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10396 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10397
92bb796d 10398 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10399 (x_term_init): Remove local to avoid shadowing.
92bb796d 10400
764430a3 10401 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10402
10403 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10404 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10405
d1dfb56c
EZ
104062011-04-16 Eli Zaretskii <eliz@gnu.org>
10407
c4354cb4
EZ
10408 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10409
d1dfb56c
EZ
10410 Fix regex.c, syntax.c and friends for buffers > 2GB.
10411 * syntax.h (struct gl_state_s): Declare character position members
10412 EMACS_INT.
10413
10414 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10415
04f2d78b
CB
10416 * textprop.c (verify_interval_modification, interval_of):
10417 Declare arguments EMACS_INT.
d1dfb56c
EZ
10418
10419 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10420 EMACS_INT.
10421
10422 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10423
10424 * indent.c (Fvertical_motion): Local variable it_start is now
10425 EMACS_INT.
10426
10427 * regex.c (re_match, re_match_2, re_match_2_internal)
10428 (bcmp_translate, regcomp, regexec, print_double_string)
10429 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10430 (re_compile_pattern, re_exec): Declare arguments and local
10431 variables `size_t' and `ssize_t' and return values `regoff_t', as
10432 appropriate.
10433 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10434 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10435 <compile_stack_type>: `size' and `avail' are now `size_t'.
10436
10437 * regex.h <regoff_t>: Use ssize_t, not int.
10438 (re_search, re_search_2, re_match, re_match_2): Arguments that
10439 specify buffer/string position and length are now ssize_t and
10440 size_t. Return type is regoff_t.
10441
613052cd
BK
104422011-04-16 Ben Key <bkey76@gmail.com>
10443
10444 * nsfont.m: Fixed bugs in ns_get_family and
10445 ns_descriptor_to_entity that were caused by using free to
10446 deallocate memory blocks that were allocated by xmalloc (via
10447 xstrdup). This caused Emacs to crash when compiled with
10448 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10449 --enable-checking=xmallocoverrun). xfree is now used to
10450 deallocate these memory blocks.
10451
4170f62f 104522011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10453
71b41406
PE
10454 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10455
9587a89d
PE
10456 emacs_write: Accept and return EMACS_INT for sizes.
10457 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10458 et seq.
10459 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10460 Accept and return EMACS_INT.
10461 (emacs_gnutls_write): Return the number of bytes written on
10462 partial writes.
10463 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10464 (emacs_read, emacs_write): Remove check for negative size, as the
10465 Emacs source code has been audited now.
9587a89d
PE
10466 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10467 (emacs_read, emacs_write): Use it.
273a5f82
PE
10468 * process.c (send_process): Adjust to the new signatures of
10469 emacs_write and emacs_gnutls_write. Do not attempt to store
10470 a byte offset into an 'int'; it might overflow.
9587a89d 10471 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10472
3e047f51
PE
10473 * sound.c: Don't assume sizes fit in 'int'.
10474 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10475 Return EMACS_INT, not int.
3e047f51 10476 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10477 Accept EMACS_INT, not int.
10478 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10479 record read return values.
10480
cc39a9db
BK
104812011-04-15 Ben Key <bkey76@gmail.com>
10482
c9d0ec6d
JB
10483 * keyboard.c (Qundefined): Don't declare static since it is used
10484 in nsfns.m.
10485 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10486 static since they are used in nsfont.m.
cc39a9db 10487
6c60eb9f
SM
104882011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10489
10490 * process.c (Qprocessp): Don't declare static.
10491 * lisp.h (Qprocessp): Declare again.
10492
7990b61a
JB
104932011-04-15 Juanma Barranquero <lekktu@gmail.com>
10494
10495 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10496
5d4cb038
PE
104972011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10498
8bd7b830 10499 Improve C-level modularity by making more things 'static'.
cd64ea1d 10500
e3b27b31
PE
10501 Don't publish debugger-only interfaces to other modules.
10502 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10503 (verify_bytepos, count_markers): Move decls to the only modules
10504 that need them.
10505 * region-cache.h (pp_cache): Likewise.
10506 * window.h (check_all_windows): Likewise.
10507 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10508
5d4cb038
PE
10509 * sysdep.c (croak): Now static, if
10510 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10511 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10512
10513 * alloc.c (refill_memory_reserve): Now static if
10514 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10515 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10516
e87b6180
PE
10517 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10518 Define only if USE_LUCID.
10519
ac64929e
PE
10520 * xrdb.c (x_customization_string, x_rm_string): Now static.
10521
6f37259d
PE
10522 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10523 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10524
1683e3ab
PE
10525 * xdisp.c (draw_row_with_mouse_face): Now static.
10526 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10527
de9c2632
PE
10528 * window.h (check_all_windows): Mark externally visible.
10529
2b96acb7
PE
10530 * window.c (window_deletion_count): Now static.
10531
10532 * undo.c: Make symbols static if they're not exported.
10533 (last_undo_buffer, last_boundary_position, pending_boundary):
10534 Now static.
10535
50436f33
PE
10536 * textprop.c (interval_insert_behind_hooks): Now static.
10537 (interval_insert_in_front_hooks): Likewise.
10538
64520e5c
PE
10539 * term.c: Make symbols static if they're not exported.
10540 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10541 (max_frame_lines, tty_set_terminal_modes):
10542 (tty_reset_terminal_modes, tty_turn_off_highlight):
10543 (get_tty_terminal): Now static.
10544 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10545 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10546 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10547 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10548 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10549
1fa53021
PE
10550 * sysdep.c: Make symbols static if they're not exported.
10551 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10552 Now static.
10553 (sigprocmask_set, full_mask): Remove; unused.
10554 (wait_debugging): Mark as visible.
10555 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10556 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10557
d4b43b22
PE
10558 * syntax.c (syntax_temp): Define only if !__GNUC__.
10559
b7c513d0
PE
10560 * sound.c (current_sound_device, current_sound): Now static.
10561
989b29ad
PE
10562 * search.c (searchbufs, searchbuf_head): Now static.
10563
13a55a78
PE
10564 * scroll.c (scroll_cost): Remove; unused.
10565 * dispextern.h (scroll_cost): Remove decl.
10566
de68a1fc
PE
10567 * region-cache.h (pp_cache): Mark as externally visible.
10568
40ccffa6
PE
10569 * process.c: Make symbols static if they're not exported.
10570 (process_tick, update_tick, create_process, chan_process):
10571 (Vprocess_alist, proc_buffered_char, datagram_access):
10572 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10573 (deactivate_process): Mark defn as static, as well as decl.
10574 * lisp.h (create_process): Remove decl.
10575 * process.h (chan_process, Vprocess_alist): Remove decls.
10576
ad64fc97
PE
10577 * print.c: Make symbols static if they're not exported.
10578 (print_depth, new_backquote_output, being_printed, print_buffer):
10579 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10580 (print_interval, print_number_index, initial_stderr_stream):
10581 Now static.
10582 * lisp.h (Fprinc): Remove decl.
10583 (debug_output_compilation_hack): Mark as externally visible.
10584
adddb265
PE
10585 * sysdep.c (croak): Move decl from here to syssignal.h.
10586 * syssignal.h (croak): Put it here, so the API can be checked when
10587 'croak' is called from dissociate_if_controlling_tty.
10588
1717ede2
PE
10589 * minibuf.c: Make symbols static if they're not exported.
10590 (minibuf_save_list, choose_minibuf_frame): Now static.
10591 * lisp.h (choose_minibuf_frame): Remove decl.
10592
fa5fb2bc
PE
10593 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10594
1e3890d1
PE
10595 * lread.c: Make symbols static if they're not exported.
10596 (read_objects, initial_obarray, oblookup_last_bucket_number):
10597 Now static.
10598 (make_symbol): Remove; unused.
10599 * lisp.h (initial_obarray, make_symbol): Remove decls.
10600
8a1414fa
PE
10601 * keyboard.c: Make symbols static if they're not exported.
10602 (single_kboard, recent_keys_index, total_keys, recent_keys):
10603 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10604 (this_single_command_key_start, echoing, last_auto_save):
10605 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10606 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10607 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10608 (Vlispy_mouse_stem, double_click_count):
10609 Now static.
10610 (force_auto_save_soon): Define only if SIGDANGER.
10611 (ignore_mouse_drag_p): Now static if
10612 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10613 (print_help): Remove; unused.
10614 (stop_character, last_timer_event): Mark as externally visible.
10615 * keyboard.h (ignore_mouse_drag_p): Declare only if
10616 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10617 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10618 * lisp.h (echoing): Remove decl.
10619 (force_auto_save_soon): Declare only if SIGDANGER.
10620 * xdisp.c (redisplay_window): Simplify code, to make it more
10621 obvious that ignore_mouse_drag_p is not accessed if !defined
10622 USE_GTK && !defined HAVE_NS.
10623
93ea6e8f
PE
10624 * intervals.c: Make symbols static if they're not exported.
10625 (merge_properties_sticky, merge_interval_right, delete_interval):
10626 Now static.
10627 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10628
77382fcc
PE
10629 * insdel.c: Make symbols static if they're not exported.
10630 However, leave prepare_to_modify_buffer alone. It's never
10631 called from outside this function, but that appears to be a bug.
10632 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10633 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10634 (adjust_after_replace_noundo): Remove; unused.
10635 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10636 (signal_before_change): Remove decls.
77382fcc 10637
9306c32e
PE
10638 * indent.c (val_compute_motion, val_vmotion): Now static.
10639
cd44d2eb
PE
10640 * image.c: Make symbols static if they're not exported.
10641 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10642 if USE_GTK.
10643 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10644 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10645
ad9a7a06
PE
10646 * fringe.c (standard_bitmaps): Now static.
10647 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10648
81626931
PE
10649 * frame.c: Make symbols static if they're not exported.
10650 (x_report_frame_params, make_terminal_frame): Now static.
10651 (get_frame_param): Now static, unless HAVE_NS.
10652 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10653 (x_get_resource_string): Remove; not used.
10654 * frame.h (make_terminal_frame, x_report_frame_params):
10655 (x_get_resource_string); Remove decls.
10656 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10657 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10658
239f9db9
PE
10659 * font.c, fontset.c: Make symbols static if they're not exported.
10660 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10661 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10662 * font.c (font_close_object): Now static.
10663 * font.h (font_close_object): Remove.
10664 * fontset.c (FONTSET_OBJLIST): Remove.
10665 (free_realized_fontset) #if-0 the body, which does nothing.
10666 (face_suitable_for_char_p): #if-0, as it's never called.
10667 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10668 * xfaces.c (face_at_string_position):
10669 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10670 since 0 is always ASCII.
10671
dfcf3579
PE
10672 * fns.c (weak_hash_tables): Now static.
10673
5045092b
PE
10674 * fileio.c: Make symbols static if they're not exported.
10675 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10676 (Vwrite_region_annotation_buffers): Now static.
10677
57a96f5c
PE
10678 * eval.c: Make symbols static if they're not exported.
10679 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10680 * lisp.h (backtrace_list): Remove decl.
10681
35f08c38
PE
10682 * emacs.c: Make symbols static if they're not exported.
10683 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10684 (fatal_error_code, fatal_error_signal_hook, standard_args):
10685 Now static.
10686 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10687 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10688 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10689 * lisp.h (fatal_error_signal_hook): Remove decl.
10690 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10691
f44bd759
PE
10692 * editfns.c: Move a (normally-unused) function to its only use.
10693 * editfns.c, lisp.h (get_operating_system_release): Remove.
10694 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10695 worth the hassle of breaking this out.
10696
b532497d
PE
10697 * xterm.c: Make symbols static if they're not exported.
10698 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10699 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10700 (x_destroy_window, x_delete_display):
10701 Now static.
10702 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10703 (x_mouse_leave): Remove; unused.
10704 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10705 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10706 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10707 Remove decls.
10708 (x_mouse_leave): Declare only if WINDOWSNT.
10709 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10710 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10711 USE_X_TOOLKIT.
10712
1675728f
PE
10713 * ftxfont.c: Make symbols static if they're not exported.
10714 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10715 HAVE_FREETYPE.
10716 * font.h (ftxfont_driver): Likewise.
10717
e4cebfca
PE
10718 * xfns.c: Make symbols static if they're not exported.
10719 (x_last_font_name, x_display_info_for_name):
10720 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10721 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10722 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10723 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10724 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10725 (last_show_tip_args): Now static.
10726 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10727 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10728 (x_screen_planes): Remove; unused.
10729 * dispextern.h (x_screen_planes): Remove decl.
10730
5bf46f05
PE
10731 * dispnew.c: Make symbols static if they're not exported.
10732 * dispextern.h (redraw_garbaged_frames, scrolling):
10733 (increment_row_positions): Remove.
10734 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10735 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10736 Now static.
10737 (redraw_garbaged_frames): Remove; unused.
10738
435f4c28
PE
10739 * xfaces.c: Make symbols static if they're not exported.
10740 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10741 Remove decls.
10742 * xterm.h (defined_color): Remove decls.
10743 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10744 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10745 (menu_face_changed_default, defined_color, free_realized_face):
10746 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10747 (ascii_face_of_lisp_face): Remove; unused.
10748
8524aef3
PE
10749 * xdisp.c: Make symbols static if they're not exported.
10750 * dispextern.h (scratch_glyph_row, window_box_edges):
10751 (glyph_to_pixel_coords, set_cursor_from_row):
10752 (get_next_display_element, set_iterator_to_next):
10753 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10754 (show_mouse_face): Remove decls
10755 * frame.h (message_buf_print): Likewise.
10756 * lisp.h (pop_message, set_message, check_point_in_composition):
10757 Likewise.
10758 * xterm.h (set_vertical_scroll_bar): Likewise.
10759 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10760 (message_buf_print, scratch_glyph_row, displayed_buffer):
10761 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10762 (get_next_display_element, show_mouse_face, window_box_edges):
10763 (frame_to_window_pixel_xy, check_point_in_composition):
10764 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10765 (glyph_to_pixel_coords): Remove; unused.
10766
16390cd2
PE
10767 * dired.c (file_name_completion): Now static.
10768
10769 * dbusbind.c (xd_in_read_queued_messages): Now static.
10770
a25f4dfa
PE
10771 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10772 * data.c (circular_list_error): Remove.
10773
14a9c8df
PE
10774 * commands.h (last_point_position, last_point_position_buffer):
10775 (last_point_position_window): Remove decls.
10776 * keyboard.c: Make these variables static.
10777
04f2d78b
CB
10778 * coding.h (coding, code_convert_region, encode_coding_gap):
10779 Remove decls.
74ab6df5
PE
10780 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10781 (iso_code_class, detect_coding, code_convert_region): Now static.
10782 (encode_coding_gap): Remove; unused.
10783
38dfbee1
PE
10784 * chartab.c (chartab_chars, chartab_bits): Now static.
10785
a2cb4e63
PE
10786 * charset.h (charset_iso_8859_1): Remove decl.
10787 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10788 Now static.
10789
127198fd
PE
10790 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10791 * ccl.c (Vccl_program_table): Now static.
10792 (check_ccl_update): Remove; unused.
10793
d85b608f
PE
10794 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10795 * category.h: ... from here.
10796 * category.c (check_category_table, set_category_set): Now static.
10797
31cd66f3
PE
10798 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10799 * lisp.h: Remove these decls.
10800
c358e587
PE
10801 * buffer.c (buffer_count): Remove unused var.
10802
e78aecca
PE
10803 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10804 so that it's not optimized away.
10805 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10806 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10807 exported only to the debugger.
10808
e192d7d3 10809 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10810 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10811
92470028
PE
10812 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10813 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10814 was inaccessible from Lisp.
10815 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10816 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10817
244ed907
PE
10818 alloc.c: Import and export fewer symbols, and remove unused items.
10819 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10820 is defined.
10821 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10822 it's not optimized away by whole-program optimization.
10823 (message_enable_multibyte, free_misc): Remove.
10824 (catchlist, handlerlist, mark_backtrace):
10825 Declare only if BYTE_MARK_STACK.
10826 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10827 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10828 (message_enable_multibyte): Remove decl.
10829 (free_misc, interval_free_list, float_block, float_block_index):
10830 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10831 (cons_free_list, last_marked_index):
10832 Now static.
10833 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10834 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10835 (mark_backtrace): Define only if BYTE_MARK_STACK.
10836 * xdisp.c (message_enable_multibyte): Now static.
10837
61c2b50e 10838 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10839 This makes it easier for human readers (and static analyzers)
10840 to see whether these variables are used from other modules.
10841 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10842 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10843 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10844 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10845 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10846 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10847 * xmenu.c, xselect.c:
10848 Declare Q* vars static if they are not used in other modules.
10849 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10850 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10851 Remove decls of unexported vars.
10852 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10853
95c82688
PE
10854 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10855
16a97296
PE
10856 Make Emacs functions such as Fatom 'static' by default.
10857 This makes it easier for human readers (and static analyzers)
10858 to see whether these functions can be called from other modules.
10859 DEFUN now defines a static function. To make the function external
10860 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10861 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10862 (Finit_image_library):
16a97296
PE
10863 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10864 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10865 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10866 Remove decls, since these functions are now static.
10867 (Funintern, Fget_internal_run_time): New decls, since these functions
10868 were already external.
95c82688 10869
16a97296
PE
10870 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10871 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10872 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10873 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10874 * keyboard.c, keymap.c, lread.c:
10875 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10876 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10877 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10878 Mark functions with DEFUE instead of DEFUN,
10879 if they are used in other modules.
10880 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10881 decls for now-static functions.
10882 * buffer.h (Fdelete_overlay): Remove decl.
10883 * callproc.c (Fgetenv_internal): Mark as internal.
10884 * composite.c (Fremove_list_of_text_properties): Remove decl.
10885 (Fcomposition_get_gstring): New forward static decl.
10886 * composite.h (Fcomposite_get_gstring): Remove decl.
10887 * dired.c (Ffile_attributes): New forward static decl.
10888 * doc.c (Fdocumntation_property): New forward static decl.
10889 * eval.c (Ffetch_bytecode): New forward static decl.
10890 (Funintern): Remove extern decl; now in .h file where it belongs.
10891 * fileio.c (Fmake_symbolic_link): New forward static decl.
10892 * image.c (Finit_image_library): New forward static decl.
10893 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10894 * intervals.h (Fprevious_property_change):
10895 (Fremove_list_of_text_properties): Remove decls.
10896 * keyboard.c (Fthis_command_keys): Remove decl.
10897 (Fcommand_execute): New forward static decl.
10898 * keymap.c (Flookup_key): New forward static decl.
10899 (Fcopy_keymap): Now static.
10900 * keymap.h (Flookup_key): Remove decl.
10901 * process.c (Fget_process): New forward static decl.
10902 (Fprocess_datagram_address): Mark as internal.
10903 * syntax.c (Fsyntax_table_p): New forward static decl.
10904 (skip_chars): Remove duplicate decl.
10905 * textprop.c (Fprevious_property_change): New forward static decl.
10906 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10907 Now internal.
10908 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10909 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10910
785bbd42
PE
10911 * editfns.c (Fformat): Remove unreachable code.
10912
8b913b57
AS
109132011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10914
10915 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10916 change. (Bug#8496)
10917
a6744a35
EZ
109182011-04-13 Eli Zaretskii <eliz@gnu.org>
10919
10920 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10921 when at ZV. (Bug#8487)
10922
e7974947
AS
109232011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10924
baad03f0
AS
10925 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10926 (Bug#8437)
10927 * keyboard.c (parse_tool_bar_item): Likewise.
10928 * sound.c (sound_cleanup, alsa_close): Likewise.
10929 * termcap.c (tgetent): Likewise.
10930 * xfns.c (x_default_font_parameter): Likewise.
10931 * xsettings.c (read_and_apply_settings): Likewise.
10932
e7974947
AS
10933 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10934 (overrun_check_free): Protoize.
10935
28272684
PE
109362011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10937
10938 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10939 since callers should never pass a negative size.
10940 Change the signature to match that of plain 'read' and 'write'; see
10941 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10942 * lisp.h: Update prototypes of emacs_write and emacs_read.
10943
11997c76
EZ
109442011-04-11 Eli Zaretskii <eliz@gnu.org>
10945
10946 * xdisp.c (redisplay_window): Don't try to determine the character
10947 position of the scroll margin if the window start point w->startp
e896f03c 10948 is outside the buffer's accessible region. (Bug#8468)
11997c76 10949
8a2cbd72
EZ
109502011-04-10 Eli Zaretskii <eliz@gnu.org>
10951
10952 Fix write-region and its subroutines for buffers > 2GB.
10953 * fileio.c (a_write, e_write): Modify declaration of arguments and
10954 local variables to support buffers larger than 2GB.
10955 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10956
10957 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10958 argument, local variables, and return value.
10959
10960 * lisp.h: Update prototypes of emacs_write and emacs_read.
10961
10962 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10963
4073e537 109642011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10965
1ebfdcb6
PE
10966 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10967
b2ded58d
PE
10968 Fix more problems found by GCC 4.6.0's static checks.
10969
7d66342c
PE
10970 * xdisp.c (vmessage): Use a better test for character truncation.
10971
bbf47d44
PE
10972 * charset.c (load_charset_map): <, not <=, for optimization,
10973 and to avoid potential problems with integer overflow.
9248994d 10974 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10975 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10976 * editfns.c (Fformat): Likewise.
1e69125e 10977 * syntax.c (skip_chars): Likewise.
3befa583 10978
e3019616
PE
10979 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10980 This also lets GCC 4.6.0 generate slightly better loop code.
10981
becfa255
PE
10982 * callint.c (Fcall_interactively): <, not <=, for optimization.
10983 (Fcall_interactively): Count the number of arguments produced,
10984 not the number of arguments given. This is simpler and lets GCC
10985 4.6.0 generate slightly better code.
10986
dae0cd48
PE
10987 * ftfont.c: Distingish more carefully between FcChar8 and char.
10988 The previous code passed unsigned char * to a functions like
10989 strlen and xstrcasecmp that expect char *, which does not
10990 conform to the C standard.
10991 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10992 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10993 char * when the C standard requires it.
10994
76032d70
PE
10995 * keyboard.c (read_char): Remove unused var.
10996
eb3f1cc8
PE
10997 * eval.c: Port to Windows vsnprintf (Bug#8435).
10998 Include <limits.h>.
10999 (SIZE_MAX): Define if the headers do not.
11000 (verror): Do not give up if vsnprintf returns a negative count.
11001 Instead, grow the buffer. This ports to Windows vsnprintf, which
11002 does not conform to C99. Problem reported by Eli Zaretskii.
11003 Also, simplify the allocation scheme, by avoiding the need for
11004 calling realloc, and removing the ALLOCATED variable.
11005
70476b54
PE
11006 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11007
12020a9e
PE
11008 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11009 But keep the doprint source code for now, as we might revamp it
11010 and use it again (Bug#8435).
ea6c7ae6
PE
11011 * lisp.h (doprnt): Remove.
11012 * Makefile.in (base_obj): Remove doprnt.o.
11013 * deps.mk (doprnt.o): Remove.
11014
5fdb398c
PE
11015 error: Print 32- and 64-bit integers portably (Bug#8435).
11016 Without this change, on typical 64-bit hosts error ("...%d...", N)
11017 was used to print both 32- and 64-bit integers N, which relied on
11018 undefined behavior.
61bdb816 11019 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11020 * lisp.h (error, verror): Mark as printf-like functions.
11021 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11022 Report overflow in size calculations when allocating printf buffer.
11023 Do not truncate output string at its first null byte.
11024 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11025 Truncate the output at a character boundary, since vsnprintf does not
11026 do that.
11027 * charset.c (check_iso_charset_parameter): Convert internal
11028 character to string before calling 'error', since %c now has the
11029 printf meaning.
11030 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11031 overflow when computing char to be passed to 'error'. Do not
11032 pass Lisp_Object to 'error'; pass the integer instead.
11033 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11034 formatted with plain %d.
11035
b189fa66
PE
11036 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11037
bff87ef0
PE
11038 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11039
7e2cac20
PE
11040 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11041
ce4d90b5
PE
11042 * xterm.c (x_catch_errors): Remove duplicate declaration.
11043
266c9547
PE
11044 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11045
79c49ad2
PE
11046 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11047
368f4090
JM
110482011-04-10 Jim Meyering <meyering@redhat.com>
11049
11050 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11051 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11052 return ssize_t not "int", and use size_t as the buffer length.
11053 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11054 * gnutls.h: Update declarations.
11055 * process.c (read_process_output): Use ssize_t, to match.
11056 (send_process): Likewise.
11057
a32d4040
CY
110582011-04-09 Chong Yidong <cyd@stupidchicken.com>
11059
11060 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11061
8546720e 110622011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11063
04f2d78b
CB
11064 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11065 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11066
8546720e
GM
11067 * xterm.c (handle_one_xevent):
11068 * xmenu.c (create_and_show_popup_menu):
11069 * xselect.c (x_decline_selection_request)
11070 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11071
0a2f5c1a 110722011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11073
11074 Fix some uses of `int' instead of EMACS_INT.
11075 * search.c (string_match_1, fast_string_match)
11076 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11077 (scan_buffer, find_next_newline_no_quit)
11078 (find_before_next_newline, search_command, Freplace_match)
11079 (Fmatch_data): Make some `int' variables be EMACS_INT.
11080
11081 * xdisp.c (display_count_lines): 3rd argument and return value now
11082 EMACS_INT. All callers changed.
11083 (pint2hrstr): Last argument is now EMACS_INT.
11084
11085 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11086 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11087 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11088 (decode_coding_utf_16, decode_coding_emacs_mule)
11089 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11090 (decode_coding_ccl, decode_coding_charset)
11091 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11092 (decode_coding_iso_2022, decode_coding_emacs_mule)
11093 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11094 <char_offset, last_offset>: Declare EMACS_INT.
11095 (encode_coding_utf_8, encode_coding_utf_16)
11096 (encode_coding_emacs_mule, encode_invocation_designation)
11097 (encode_designation_at_bol, encode_coding_iso_2022)
11098 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11099 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11100 Declare EMACS_INT.
11101 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11102 (encode_invocation_designation): Last argument P_NCHARS is now
11103 EMACS_INT.
11104 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11105 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11106
11107 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11108 All users changed.
11109
11110 * ccl.c (Fccl_execute_on_string): Declare some variables
11111 EMACS_INT.
11112
8546720e 111132011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11114
11115 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11116
4e19a977
CS
111172011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11118
11119 * process.c (Fformat_network_address): Doc fix.
11120
87302331
R
111212011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11122
ee7683eb 11123 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11124
cbb59342
CY
111252011-04-08 Chong Yidong <cyd@stupidchicken.com>
11126
11127 * keyboard.c (read_char): Call Lisp function help-form-show,
11128 instead of using internal_with_output_to_temp_buffer.
11129 (Qhelp_form_show): New var.
e0d38eeb 11130 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11131
11132 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11133
11134 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11135
e67a13ab
CY
111362011-04-06 Chong Yidong <cyd@stupidchicken.com>
11137
04f2d78b
CB
11138 * process.c (Flist_processes): Remove to Lisp.
11139 (list_processes_1): Delete.
e67a13ab 11140
973f782d
EZ
111412011-04-06 Eli Zaretskii <eliz@gnu.org>
11142
7c106b1e
EZ
11143 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11144
973f782d
EZ
11145 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11146
41cf7d1a 111472011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11148
ca23cc88
PE
11149 Fix more problems found by GCC 4.6.0's static checks.
11150
f390e2d5
PE
11151 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11152
42eea0d0
PE
11153 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11154
b69769da 11155 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11156
f9541e84
PE
11157 * xdisp.c (vmessage): Mark as a printf-like function.
11158
13841b55
PE
11159 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11160
c136c10f
PE
11161 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11162
5e2d4a30
PE
11163 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11164 printf-like functions.
11165 (tiff_load): Add casts to remove these marks before passing them
11166 to system-supplied API.
11167
583f48b9
PE
11168 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11169
b25d760e
PE
11170 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11171 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11172 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11173 directly, rather than having caller test rule sign. This avoids
11174 some unnecessary tests.
11175 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11176 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11177 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11178
bc7b6697 11179 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11180 (xfont_open): Avoid unnecessary tests.
bc7b6697 11181
27ccc379
PE
11182 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11183
dcd5c89a
PE
11184 * composite.h, composite.c (composition_gstring_put_cache):
11185 Use EMACS_INT, not int, for length.
11186
b13a45c6
PE
11187 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11188 breaking out part of COMPOSITION_DECODE_RULE.
11189 (COMPOSITION_DECODE_RULE): Use it.
11190 * composite.c (get_composition_id): Remove unused local vars,
11191 by using the new macro.
11192
1e792e4d
PE
11193 * textprop.c (set_text_properties_1): Change while to do-while,
11194 since the condition is always true at first.
11195
dc6c6455 11196 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11197 (interval_deletion_adjustment): Return unsigned value.
11198 All uses changed.
dc6c6455 11199
aba7731a
PE
11200 * process.c (list_processes_1, create_pty, read_process_output):
11201 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11202 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11203 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11204 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11205 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11206
fdfc4bf3
PE
11207 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11208
fca8fe46 11209 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11210 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11211
06a0259a 11212 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11213 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11214 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11215
e7b9e80f
PE
11216 * print.c (print_error_message): Avoid int overflow.
11217
56201685
PE
11218 * font.c (font_list_entities): Redo for clarity,
11219 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11220
78834453 11221 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11222 (font_score): Avoid potential overflow in diff calculation.
78834453 11223
0bc0b309 11224 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11225 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11226
e610eaca
PE
11227 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11228
b895abce
PE
11229 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11230 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11231 can always succeed if overflow has undefined behavior.
11232
1f1d9321 11233 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11234 (wordify): Omit three unnecessary tests.
1f1d9321 11235
c59478bc
PE
11236 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11237 All callers changed. This avoids the need for an unused var.
11238
79b73827
PE
11239 * casefiddle.c (casify_region): Remove var that is set but not used.
11240
a4db5dfe
PE
11241 * dired.c (file_name_completion): Remove var that is set but not used.
11242
43aae36e
PE
11243 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11244
2a47c44d 11245 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11246 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11247
a37c69bf
PE
11248 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11249 Check for integer overflow on size calculations.
11250
328ab8e7
PE
11251 * buffer.c (Fprevious_overlay_change): Remove var that is set
11252 but not used.
11253
e5a2a5cb
PE
11254 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11255 Remove vars that are set but not used.
8d84a6eb 11256 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11257 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11258
a60e5f68
PE
11259 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11260
f661cb61 11261 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11262 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11263
f0397f5a
PE
11264 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11265 that are set but not used.
11266
8664db06 11267 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11268 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11269
6abdaa4a
PE
11270 * xselect.c (x_get_local_selection, x_handle_property_notify):
11271 Remove vars that are set but not used.
11272
0ce7538d 11273 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11274 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11275
9ae848fc
PE
11276 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11277 Remove var that is set but not used.
0b918413
PE
11278 (scroll_bar_windows_size): Now size_t, not int.
11279 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11280 Check for overflow.
9ae848fc 11281
a5a62657
PE
11282 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11283 (map_tty_color) [!defined MSDOS]: Likewise.
11284
5c5cdd39
PE
11285 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11286
66ebf983
PE
11287 * coding.c: Remove vars that are set but not used.
11288 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11289 All callers changed.
11290 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11291 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11292 (decode_coding_charset): Remove vars that are set but not used.
11293
1be4d761
PE
11294 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11295 that is set but not used.
11296
47553fa8
PE
11297 * print.c (print_object): Remove var that is set but not used.
11298
1f7196bf 11299 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11300 The gnulib version avoids calling malloc in the usual case,
11301 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11302 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11303 * filelock.c (current_lock_owner): Likewise.
11304 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11305 * sysdep.c: Include allocator.h, careadlinkat.h.
11306 (emacs_no_realloc_allocator): New static constant.
11307 (emacs_readlink): New function.
fdb61804
PE
11308 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11309 ../lib/careadlinkat.h.
d1fdcab7 11310
f84c17c7
SM
113112011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11312
11313 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11314 first non-nil return value).
11315
ef3862ad
JD
113162011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11317
11318 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11319 if not defined (Bug#8403).
11320
376a7006
JB
113212011-04-02 Juanma Barranquero <lekktu@gmail.com>
11322
11323 * xdisp.c (display_count_lines): Remove parameter `start',
11324 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11325 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11326 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11327 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11328 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11329 and thereabouts. All callers changed.
11330 (get_per_char_metric): Remove parameter `f', unused since
11331 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11332
6ca3801d
JM
113332011-04-02 Jim Meyering <meyering@redhat.com>
11334
11335 do not dereference NULL upon failed strdup
11336 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11337 (ns_get_family): Likewise.
11338
d8e2b5ba
JB
113392011-04-02 Juanma Barranquero <lekktu@gmail.com>
11340
11341 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11342
8c74fcbd
JD
113432011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11344
11345 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11346 later (Bug#8403).
11347
7200d79c
SM
113482011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11349
03408648 11350 Add lexical binding.
7200d79c 11351
03408648
SM
11352 * window.c (Ftemp_output_buffer_show): New fun.
11353 (Fsave_window_excursion):
11354 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11355
11356 * lread.c (lisp_file_lexically_bound_p): New function.
11357 (Fload): Bind Qlexical_binding.
11358 (readevalloop): Remove `evalfun' arg.
11359 Bind Qinternal_interpreter_environment.
11360 (Feval_buffer): Bind Qlexical_binding.
11361 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11362 Mark as dynamic.
11363 (syms_of_lread): Declare `lexical-binding'.
11364
11365 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11366
11367 * keyboard.c (eval_dyn): New fun.
11368 (menu_item_eval_property): Use it.
ca105506
SM
11369
11370 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11371
03408648
SM
11372 * fns.c (concat, mapcar1): Accept byte-code-functions.
11373
11374 * eval.c (Fsetq): Handle lexical vars.
11375 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11376 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11377 (FletX, Flet): Obey lexical binding.
11378 (Fcommandp): Handle closures.
11379 (Feval): New `lexical' arg.
11380 (eval_sub): New function extracted from Feval. Use it almost
11381 everywhere where Feval was used. Look up vars in lexical env.
11382 Handle closures.
11383 (Ffunctionp): Move from subr.el.
11384 (Ffuncall): Handle closures.
11385 (apply_lambda): Remove `eval_flags'.
11386 (funcall_lambda): Handle closures and new byte-code-functions.
11387 (Fspecial_variable_p): New function.
11388 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11389 but without exporting it to Lisp.
23aba0ea 11390
23aba0ea 11391 * doc.c (Fdocumentation, store_function_docstring):
03408648 11392 * data.c (Finteractive_form): Handle closures.
23aba0ea 11393
03408648
SM
11394 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11395 interactive spec.
ba83908c 11396
04f2d78b
CB
11397 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11398 New byte-codes.
03408648
SM
11399 (exec_byte_code): New function extracted from Fbyte_code to handle new
11400 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11401
03408648 11402 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11403
03408648 11404 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11405
e2abce01
JB
114062011-03-31 Juanma Barranquero <lekktu@gmail.com>
11407
11408 * xdisp.c (redisplay_internal): Fix prototype.
11409
63696a73 114102011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11411
63696a73 11412 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11413 (try_scrolling): Use it when setting scroll_limit.
11414 Limit scrolling to 100 screen lines.
63696a73
EZ
11415 (redisplay_window): Even when falling back on "recentering",
11416 position point in the window according to scroll-conservatively,
11417 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11418
11419 (try_scrolling): When point is above the window, allow searching
11420 as far as scroll_max, or one screenful, to compute vertical
11421 distance from PT to the scroll margin position. This prevents
11422 try_scrolling from unnecessarily failing when
11423 scroll-conservatively is set to a value slightly larger than the
11424 window height. Clean up the case of PT below the margin at bottom
11425 of window: scroll_max can no longer be INT_MAX. When aggressive
11426 scrolling is in use, don't let point enter the opposite scroll
11427 margin as result of the scroll.
11428 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11429 threshold of 100 lines for never-recentering scrolling.
11430
e4cc2dfc
JB
114312011-03-31 Juanma Barranquero <lekktu@gmail.com>
11432
11433 * dispextern.h (move_it_by_lines):
11434 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11435 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11436 (message_log_check_duplicate): Remove parameters `prev_bol' and
11437 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11438 (redisplay_internal): Remove parameter `preserve_echo_area',
11439 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11440
11441 * indent.c (Fvertical_motion):
11442 * window.c (window_scroll_pixel_based, Frecenter):
11443 Don't pass `need_y_p' to `move_it_by_lines'.
11444
1c470562
SM
114452011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11446
44f230aa
SM
11447 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11448 steal a few bits to be more compact.
11449 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11450 Remove unneeded casts.
11451
1c470562
SM
11452 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11453
888adce9
ZK
114542011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11455
11456 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11457 binding" message (bug#7967).
11458
f838ed7b
PE
114592011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11460
77861b95
PE
11461 Fix more problems found by GCC 4.6.0's static checks.
11462
de6dbc14
PE
11463 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11464 Remove unused local var.
11465
f838ed7b
PE
11466 * editfns.c (Fmessage_box): Remove unused local var.
11467
792c7b2b
PE
11468 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11469 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11470 Omit unused local vars.
c499e557 11471 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11472 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11473 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11474 Omit unused local var.
11475
ba0165e1
PE
11476 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11477 Don't assume string length fits in int.
32ad8845 11478 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11479 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11480
3c59b4c9
PE
11481 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11482 instead of alloca (Bug#8344).
11483
a3eed478 11484 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11485 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11486
eb4d412d
PE
11487 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11488
1658b401
PE
11489 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11490 concerns.
11491
11492 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11493
11494 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11495
9a2c6e05
PE
11496 * keyboard.c (syms_of_keyboard): Use the same style as later
11497 in this function when indexing through an array. This also
11498 works around GCC bug 48267.
11499
03d0a109
PE
11500 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11501
44f730c8
PE
11502 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11503
fe75f926
PE
11504 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11505 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11506
ffa8c828
PE
11507 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11508 This avoids undefined behavior on integer overflow, and is a bit
11509 more convenient anyway since it is compared to a size_t variable.
11510
c5101a77
PE
11511 Variadic C functions now count arguments with size_t, not int.
11512 This avoids an unnecessary limitation on 64-bit machines, which
11513 caused (substring ...) to crash on large vectors (Bug#8344).
11514 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11515 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11516 All variadic functions and their callers changed accordingly.
c5101a77
PE
11517 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11518 * data.c (arith_driver, float_arith_driver): Likewise.
11519 * editfns.c (general_insert_function): Likewise.
11520 * eval.c (struct backtrace.nargs, interactive_p)
11521 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11522 (funcall_lambda, mark_backtrace): Likewise.
11523 * fns.c (concat): Likewise.
11524 * frame.c (x_set_frame_parameters): Likewise.
11525 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11526 0 if not found, not -1. All callers changed.
11527
dd3f25f7
PE
11528 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11529 (stack_copy_size): Now size_t, not int.
11530 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11531
461c2ab9
JB
115322011-03-28 Juanma Barranquero <lekktu@gmail.com>
11533
11534 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11535 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11536 All callers changed.
11537
11538 * lisp.h (multibyte_char_to_unibyte):
11539 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11540 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11541 * character.h (CHAR_TO_BYTE8):
11542 * cmds.c (internal_self_insert):
11543 * editfns.c (general_insert_function):
11544 * keymap.c (push_key_description):
11545 * search.c (Freplace_match):
11546 * xdisp.c (message_dolog, set_message_1): All callers changed.
11547
f6d62986
SM
115482011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11549
11550 * keyboard.c (safe_run_hook_funcall): New function.
11551 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11552 don't set the hook to nil, but remove the offending function instead.
11553 (Qcommand_hook_internal): Remove, unused.
11554 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11555 Vcommand_hook_internal.
11556
11557 * eval.c (enum run_hooks_condition): Remove.
11558 (funcall_nil, funcall_not): New functions.
11559 (run_hook_with_args): Call each function through a `funcall' argument.
11560 Remove `cond' argument, now redundant.
11561 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11562 (Frun_hook_with_args_until_failure): Adjust accordingly.
11563 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11564
1db5b1ad
JB
115652011-03-28 Juanma Barranquero <lekktu@gmail.com>
11566
11567 * dispextern.h (string_buffer_position): Remove declaration.
11568
11569 * print.c (strout): Remove parameter `multibyte', unused since
11570 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11571
11572 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11573 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11574 All callers changed.
11575
11576 * w32.c (_wsa_errlist): Use braces for struct initializers.
11577
11578 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11579 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11580 All callers changed.
11581 (string_buffer_position): Likewise. Also, make static (it's never
11582 used outside xdisp.c).
11583 (cursor_row_p): Remove parameter `w', unused since
11584 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11585 (decode_mode_spec): Remove parameter `precision', introduced during
11586 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11587 All callers changed.
11588
5ffb62aa
JD
115892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11590
11591 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11592
461c2ab9 115932011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11594
11595 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11596 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11597 (ns_update_auto_hide_menu_bar): New functions.
11598 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11599 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11600 ns_constrain_all_frames.
11601 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11602 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11603
5c380ffb
JD
116042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11605
11606 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11607
9af30bdf
GM
116082011-03-27 Glenn Morris <rgm@gnu.org>
11609
11610 * syssignal.h: Replace RETSIGTYPE with void.
11611 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11612 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11613 Replace SIGTYPE with void everywhere.
11614 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11615 * s/template.h (SIGTYPE): Remove commented out definition.
11616
e2abce01
JB
116172011-03-26 Eli Zaretskii <eliz@gnu.org>
11618
11619 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11620 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11621
f868cd8a
JB
116222011-03-26 Juanma Barranquero <lekktu@gmail.com>
11623
59eb0929
JB
11624 * w32.c (read_unc_volume): Use parameter `henum', instead of
11625 global variable `wget_enum_handle'.
11626
11627 * keymap.c (describe_vector): Remove parameters `indices' and
11628 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11629 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11630
f868cd8a
JB
11631 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11632
11633 * keyboard.c (timer_check): Remove parameter `do_it_now',
11634 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11635 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11636 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11637
11638 * keyboard.c (read_char):
11639 * w32menu.c (w32_menu_display_help):
11640 * xmenu.c (show_help_event, menu_help_callback):
11641 Adjust calls to `show_help_echo'.
11642
11643 * gtkutil.c (xg_maybe_add_timer):
11644 * keyboard.c (readable_events):
11645 * process.c (wait_reading_process_output):
11646 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11647
11648 * insdel.c (adjust_markers_gap_motion):
11649 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11650 (gap_left, gap_right): Don't call it.
11651
2ecf6fdb
CY
116522011-03-25 Chong Yidong <cyd@stupidchicken.com>
11653
11654 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11655 incurred during fontification.
11656
6b1f9ba4
JB
116572011-03-25 Juanma Barranquero <lekktu@gmail.com>
11658
11659 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11660 (DEFVAR_PER_BUFFER): Don't pass it.
11661
11662 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11663 (scrolling_window): Don't pass it.
11664
0f4a96b5
JB
116652011-03-25 Juanma Barranquero <lekktu@gmail.com>
11666
11667 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11668
11669 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11670 and `suffix'.
11671 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11672 of variables specific to SELinux and computation of `encoded_absname'.
11673
11674 * image.c (XPutPixel): Remove unused variable `height'.
11675
11676 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11677
11678 * unexw32.c (get_section_info): Remove unused variable `section'.
11679
11680 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11681 (system_process_attributes): Remove unused variable `sess'.
11682 (sys_read): Remove unused variable `err'.
11683
11684 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11685 (w32_wnd_proc): Remove unused variable `isdead'.
11686 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11687 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11688 (x_create_tip_frame): Remove unused variable `tem'.
11689
11690 * w32inevt.c (w32_console_read_socket):
11691 Remove unused variable `no_events'.
11692
11693 * w32term.c (x_draw_composite_glyph_string_foreground):
11694 Remove unused variable `width'.
11695
1149507c
JB
116962011-03-24 Juanma Barranquero <lekktu@gmail.com>
11697
11698 * w32term.c (x_set_glyph_string_clipping):
11699 Don't pass uninitialized region to CombineRgn.
11700
9c88f339
JB
117012011-03-23 Juanma Barranquero <lekktu@gmail.com>
11702
11703 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11704 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11705 (Fx_close_connection): Remove unused variable `i'.
11706
11707 * w32font.c (w32font_draw): Return number of glyphs.
11708 (w32font_open_internal): Remove unused variable `i'.
11709 (w32font_driver): Add missing initializer.
11710
11711 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11712 (fill_in_menu): Remove unused variable `items_added'.
11713
11714 * w32term.c (last_mouse_press_frame): Remove static global variable.
11715 (w32_clip_to_row): Remove unused variable `f'.
11716 (x_delete_terminal): Remove unused variable `i'.
11717
11718 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11719 (NOTHING): Remove unused static global variable.
11720 (uniscribe_check_otf): Remove unused variable `table'.
11721 (uniscribe_font_driver): Add missing initializers.
11722
dee091a3
JD
117232011-03-23 Julien Danjou <julien@danjou.info>
11724
11725 * term.c (Fsuspend_tty, Fresume_tty):
11726 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11727 * window.c (temp_output_buffer_show):
11728 * insdel.c (signal_before_change):
11729 * frame.c (Fhandle_switch_frame):
11730 * fileio.c (Fdo_auto_save):
11731 * emacs.c (Fkill_emacs):
11732 * editfns.c (save_excursion_restore):
11733 * cmds.c (internal_self_insert):
11734 * callint.c (Fcall_interactively):
11735 * buffer.c (Fkill_all_local_variables):
11736 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11737 Use Frun_hooks.
0f4a96b5 11738 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11739 unconditionally since it does the check itself.
dee091a3 11740
2c520ab5 117412011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11742
c9c49752
PE
11743 Fix more problems found by GCC 4.5.2's static checks.
11744
8abc3f12
PE
11745 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11746 the first time through the loop, since we know p0 < p1 then.
11747 This also avoids a gcc -Wstrict-overflow warning.
11748
a2d26660
PE
11749 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11750 leading to a memory leak, possible in functions like
11751 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11752 of objects (Bug#8318).
a2d26660 11753
916c72e9
PE
11754 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11755 that could (at least in theory) be that large.
11756
19ab8a18
PE
11757 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11758 This is less likely to overflow, and avoids undefined behavior if
11759 overflow does occur. All callers changed. Use strtoul to scan
11760 for the unsigned long integer.
b7cbbd6f
PE
11761 (pint2hrstr): Simplify and tune code slightly.
11762 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11763
f0641eff
PE
11764 * scroll.c (do_scrolling): Work around GCC bug 48228.
11765 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11766
7f650bb9
PE
11767 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11768 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11769 (validate_x_resource_name): Simplify count usage.
11770 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11771
37dd57d1
PE
11772 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11773 fail (Bug#8306).
81e56e61 11774
699979fc 11775 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11776
401bf9b4
PE
11777 * process.c (Fmake_network_process): Use socklen_t, not int,
11778 where POSIX says socklen_t is required in portable programs.
11779 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11780 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11781 (Fmake_network_process, server_accept_connection):
11782 (wait_reading_process_output, read_process_output):
11783 Likewise.
11784
b93aacde
PE
11785 * process.c: Rename or move locals to avoid shadowing.
11786 (list_processes_1, Fmake_network_process):
11787 (read_process_output_error_handler, exec_sentinel_error_handler):
11788 Rename or move locals.
4dc343ee 11789 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11790 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11791 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11792 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11793 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11794
af8a867c 11795 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11796 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11797 Include tparam.h instead, since it declares them.
af8a867c
PE
11798 * cm.h (PC): Remove extern decl; tparam.h now does this.
11799 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11800 * terminfo.c: Include tparam.h, to check interfaces.
11801 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11802 (tparam): Adjust signature to match interface in tparam.h;
11803 this removes some undefined behavior. Check that outstring and len
11804 are zero, which they always are with Emacs.
11805 * tparam.h (PC, BC, UP): New extern decls.
11806
0248044d 11807 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11808 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11809
8ff096c1 11810 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11811 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11812 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11813 (ftfont_list): Remove unused local.
49eaafba
PE
11814 (get_adstyle_property, ftfont_pattern_entity):
11815 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11816 Rename locals to avoid shadowing.
8ff096c1 11817
e2be39f6
PE
11818 * xfont.c (xfont_list_family): Mark var as initialized.
11819
c9735e30
PE
11820 * xml.c (make_dom): Now static.
11821
8f5201ae
PE
11822 * composite.c (composition_compute_stop_pos): Rename local to
11823 avoid shadowing.
b246f932
PE
11824 (composition_reseat_it): Remove unused locals.
11825 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11826 (composition_update_it): Mark var as initialized.
11b61122
PE
11827 (find_automatic_composition): Mark vars as initialized,
11828 with a FIXME (Bug#8290).
8f5201ae 11829
760fbc2c
PE
11830 character.h: Rename locals to avoid shadowing.
11831 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11832 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11833 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11834 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11835 to avoid shadowing.
11836
ff08eb85
PE
11837 * textprop.c (property_change_between_p): Remove; unused.
11838
fc7bf025
PE
11839 * intervals.c (interval_start_pos): Now static.
11840
235d7abc
PE
11841 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11842
44f230aa
SM
11843 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11844 Rename locals to avoid shadowing.
3e7d6594 11845
50060332
PE
11846 * sound.c (wav_play, au_play, Fplay_sound_internal):
11847 Fix pointer signedness.
d01f234b 11848 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11849 (wav_play): Initialize a variable to 0, to prevent undefined
11850 behavior (Bug#8278).
50060332 11851
c4fc4e30
PE
11852 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11853
918436ed
PE
11854 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11855
c939f91b
PE
11856 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11857 clobbering (Bug#8298).
b9c7f648
PE
11858 * sysdep.c (sys_subshell): Likewise.
11859 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11860
6bd8c144
PE
11861 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11862 This should get cleaned up, so that child_setup has the
11863 same signature on all platforms.
11864
7710357c 11865 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11866 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11867
c59da222
CY
118682011-03-22 Chong Yidong <cyd@stupidchicken.com>
11869
11870 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11871 not to be necessary, and produces flickering.
11872
66b87493
GM
118732011-03-20 Glenn Morris <rgm@gnu.org>
11874
11875 * config.in: Remove file.
11876
45b6f6d5
JB
118772011-03-20 Juanma Barranquero <lekktu@gmail.com>
11878
11879 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11880 are now in src/globals.h.
11881 (syms_of_minibuf): Remove spurious & from previous change.
11882
cd394be1 118832011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11884
11885 * minibuf.c (completing-read-function): New variable.
11886 (completing-read-default): Rename from completing-read.
11887 (completing-read): Call completing-read-function.
11888
b14e3e21
CY
118892011-03-19 Juanma Barranquero <lekktu@gmail.com>
11890
11891 * xfaces.c (Fx_load_color_file):
11892 Read color file from absolute filename (bug#8250).
11893
f2b726e6
JB
118942011-03-19 Juanma Barranquero <lekktu@gmail.com>
11895
11896 * makefile.w32-in: Update dependencies.
11897
09f6ff02
EZ
118982011-03-17 Eli Zaretskii <eliz@gnu.org>
11899
11900 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11901
29a6015a
PE
119022011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11903
a3a6c54e
PE
11904 Fix more problems found by GCC 4.5.2's static checks.
11905
b766f867
PE
11906 * process.c (make_serial_process_unwind, send_process_trap):
11907 (sigchld_handler): Now static.
11908
be02381c
PE
11909 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11910 That way, the code declares only the vars that it needs.
11911 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11912 * s/cygwin.h (PTY_ITERATION): Likewise.
11913 * s/darwin.h (PTY_ITERATION): Likewise.
11914 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11915
57048744
PE
11916 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11917 * process.c (allocate_pty): Don't declare stb unless it's needed.
11918
7914961c 11919 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11920 (CONSTANTLIM): Remove; unused.
11921 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11922 Define only if needed.
7914961c 11923
b3967b18
PE
11924 * unexelf.c (unexec): Name an expression,
11925 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11926 Use a different way to cause a compilation error if anyone uses
11927 n rather than nn, a way that does not involve shadowing.
73366a00 11928 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11929
29a6015a
PE
11930 * deps.mk (unexalpha.o): Remove; unused.
11931
43cfc33e 11932 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11933 * unexec.h: New file.
ce701a33
PE
11934 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11935 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11936 Depend on unexec.h.
11937 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11938 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11939 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11940 Change as necessary to match prototype in unexec.h.
ce701a33 11941
01f44d5a
PE
11942 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11943 shadowing.
4f63c6bb 11944 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11945
a6670b0b
PE
11946 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11947 Rename locals to avoid shadowing.
11948
cef2010d 11949 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11950 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11951
d4d7173a
PE
11952 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11953
f08b802a
PE
11954 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11955 warning when compiling print.c.
11956
3ddb0639
PE
11957 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11958 instead of using an uninitialized var.
5ad03b97 11959 (font_sort_entities): Mark var as initialized.
3ddb0639 11960
170a2692
PE
11961 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11962
e663c700
PE
11963 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11964 pointers to constants.
89bc529a 11965 (font_parse_fcname): Remove unused vars.
7b81e2d0 11966 (font_delete_unmatched): Now static.
ea838e10 11967 (font_get_spec): Remove; unused.
13a547c6
PE
11968 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11969 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11970 Rename or move locals to avoid shadowing.
e663c700 11971
2a80c887 11972 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11973 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11974
1384fa33 11975 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11976 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11977
8b2c52e9
PE
11978 * alloc.c (mark_backtrace): Move decl from here ...
11979 * lisp.h: ... to here, so that it can be checked.
11980
475545b5 11981 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11982 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11983 (lisp_indirect_variable): Name an expression,
11984 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11985 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11986
b1349114 11987 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11988 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11989 Use const pointer when appropriate.
b1349114 11990
a2928364
PE
11991 * lisp.h (get_system_name, get_operating_system_release):
11992 Move decls here, to check interfaces.
11993 * process.c (get_operating_system_release): Move decl to lisp.h.
11994 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11995 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11996 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11997 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11998 (Fformat_time_string, Fencode_time, Finsert_char):
11999 (Ftranslate_region_internal, Fformat):
12000 Rename or remove local vars to avoid shadowing.
9710023e 12001 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12002
a415e694
PE
12003 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12004 avoid shadowing.
12005
8ef4622d
PE
12006 * lisp.h (eassert): Check that the argument compiles, even if
12007 ENABLE_CHECKING is not defined.
12008
946f9a5b
PE
12009 * data.c (Findirect_variable): Name an expression, to avoid
12010 gcc -Wbad-function-cast warning.
112396d6 12011 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12012 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12013 (Fmake_variable_buffer_local, Fmake_local_variable):
12014 Mark variables as initialized.
52746918 12015 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12016
e5aab7e7 12017 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12018 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12019 Rename locals to avoid shadowing.
dff45157
PE
12020 (mark_stack): Move local variables into the #ifdef region where
12021 they're used.
7bc26fdb
PE
12022 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12023 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12024 needed otherwise.
12025 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12026 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12027 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12028
e5aab7e7
PE
12029 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12030 avoids undefined behavior in theory.
12031
4da60324
PE
12032 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12033
88043301
PE
12034 Use functions, not macros, for up- and down-casing (Bug#8254).
12035 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12036 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12037 to use the following functions instead of these macros.
12038 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12039 EMACS_INT, since callers assume the returned value fits in int.
12040 (upcase1): Likewise, for UPCASE_TABLE.
12041 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12042 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12043 the race-condition problem in the old DOWNCASE.
88043301 12044
19ed5445
PE
12045 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12046 Rename locals to avoid shadowing.
12047 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12048 (regex_compile, re_search_2, re_match_2_internal):
12049 Remove unused local vars.
952db0d7
PE
12050 (FREE_VAR): Rewrite so as not to use empty "else",
12051 which gcc can warn about.
da053e48 12052 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12053 (RETALLOC_IF): Define only if needed.
12054 (WORDCHAR_P): Likewise. This one is never needed, but is used
12055 only in a comment talking about a compiler bug, so put inside
12056 the #if 0 of that comment.
12057 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12058 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12059 Remove; unused.
19ed5445 12060
1f3561e4 12061 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12062 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12063 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12064
ded6f8f7
PE
12065 * search.c (simple_search): Remove unused var.
12066
dbd37a95
PE
12067 * dired.c (compile_pattern): Move decl from here ...
12068 * lisp.h: ... to here, so that it can be checked.
12069 (struct re_registers): New forward decl.
12070
7e47afad
PE
12071 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12072
85f24f61
PE
12073 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12074 All uses changed.
12075 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12076 Rename locals to avoid shadowing.
5671df8f 12077 (Fvertical_motion): Mark locals as initialized.
85f24f61 12078
181aa2be 12079 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12080 (casify_region): Mark local as initialized.
181aa2be 12081
930d429c
PE
12082 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12083
7082eac6
PE
12084 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12085 New macros, so that the caller can use some names other than
12086 gcpro1, gcpro2, etc.
12087 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12088 of the new macros.
12089 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12090 argument, for consistency with GCPRO2_VAR, etc: it is now the
12091 prefix of the variable, not the variable itself. All uses
12092 changed.
38b2c076
PE
12093 * dired.c (directory_files_internal, file_name_completion):
12094 Rename locals to avoid shadowing.
12095
15206ed9
PE
12096 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12097 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12098 dired.c's scmp function, had undefined behavior.
12099 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12100 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12101 * buffer.h: ... to here, because these macros use current_buffer,
12102 and the new implementation with inline functions needs to have
12103 current_buffer in scope now, rather than later when the macros
12104 are used.
12105 (downcase, upcase1): New static inline functions.
12106 (DOWNCASE, UPCASE1): Reimplement using these functions.
12107 This avoids undefined behavior in expressions like
12108 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12109 from race conditions in accessing the global variables
12110 case_temp1 and case_temp2.
12111 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12112 * lisp.h (case_temp1, case_temp2): Remove their decls.
12113 * character.h (ASCII_CHAR_P): Move from here ...
12114 * lisp.h: ... to here, so that the inline functions mentioned
12115 above can use them.
12116
4a6bea26
PE
12117 * dired.c (directory_files_internal_unwind): Now static.
12118
f14b7e14
PE
12119 * fileio.c (file_name_as_directory, directory_file_name):
12120 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12121 Now static.
2893f146
PE
12122 (file_name_as_directory): Use const pointers when appropriate.
12123 (Fexpand_file_name): Likewise. In particular, newdir might
12124 point at constant storage, so make it a const pointer.
fd4ead52 12125 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12126 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12127 signedness issues.
f839df0c
PE
12128 (Fset_file_times, Finsert_file_contents, auto_save_error):
12129 Rename locals to avoid shadowing.
f14b7e14 12130
5716756e 12131 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12132 (Ftry_completion, Fall_completions): Rename or remove locals
12133 to avoid shadowing.
5716756e 12134
b4c3046a
PE
12135 * marker.c (bytepos_to_charpos): Remove; unused.
12136
b45db522
PE
12137 * lisp.h (verify_bytepos, count_markers): New decls,
12138 so that gcc does not warn that these functions aren't declared.
12139
85876d07
PE
12140 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12141 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12142 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12143 (copy_text): Remove unused local var.
85876d07 12144
03d78a21 12145 * filelock.c (within_one_second): Now static.
b3dd38ab 12146 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12147
5df8f01b
PE
12148 * buffer.c (fix_overlays_before): Mark locals as initialized.
12149 (fix_start_end_in_overlays): Likewise. This function should be
12150 simplified by using pointers-to-pointers, but that's a different
12151 matter.
b1d876f1 12152 (switch_to_buffer_1): Now static.
8f54f30a
PE
12153 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12154 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12155
a70072c9 12156 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12157 Fix pointer signedness issue.
edced198
PE
12158 (sys_subshell): Mark local as volatile if checking for lint,
12159 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12160 (MAXPATHLEN): Define only if needed.
a70072c9 12161
a0977c44
PE
12162 * process.c (serial_open, serial_configure): Move decls from here ...
12163 * systty.h: ... to here, so that they can be checked.
12164
a884fdcc
PE
12165 * fns.c (get_random, seed_random): Move extern decls from here ...
12166 * lisp.h: ... to here, so that they can be checked.
12167
604efe86 12168 * sysdep.c (reset_io): Now static.
b8950c94 12169 (wait_for_termination_signal): Remove; unused.
604efe86 12170
38fc62d9
PE
12171 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12172 (copy_keymap_item, append_key, push_text_char_description):
12173 Now static.
1004a21a 12174 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12175 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12176 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12177 (describe_map_tree):
12178 Rename locals to avoid shadowing.
38fc62d9 12179
2f2650da
PE
12180 * keyboard.c: Declare functions static if they are not used elsewhere.
12181 (echo_char, echo_dash, cmd_error, top_level_2):
12182 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12183 (read_char, kbd_buffer_get_event, make_lispy_position):
12184 (make_lispy_event, make_lispy_movement, apply_modifiers):
12185 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12186 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12187 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12188 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12189 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12190
a053e86c 12191 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12192 (mark_kboards): Move decl here ...
12193 * alloc.c (mark_kboards): ... from here.
a053e86c 12194
4752793e
PE
12195 * lisp.h (force_auto_save_soon): New decl.
12196
74f10ca7 12197 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12198 (DEFINE_DUMMY_FUNCTION): New macro.
12199 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12200 Use it.
c03cd23f
PE
12201 (main): Add casts to avoid warnings
12202 if GCC considers string literals to be constants.
74f10ca7 12203
022e70d4
PE
12204 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12205
59d6fe83
PE
12206 * dbusbind.c: Pointer signedness fixes.
12207 (xd_signature, xd_append_arg, xd_initialize):
12208 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12209 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12210 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12211 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12212
78320123
PE
12213 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12214 if GCC considers string literals to be constants.
49cebcca 12215 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12216
35ac2a97
SM
122172011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12218
fb103ca9
SM
12219 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12220 (print_preprocess, print_object): New macro to fix last change.
12221
35ac2a97
SM
12222 * print.c (print_preprocess): Don't forget font objects.
12223
62973b41
JB
122242011-03-16 Juanma Barranquero <lekktu@gmail.com>
12225
12226 * emacs.c (USAGE3): Doc fixes.
12227
0e48bb22
AS
122282011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12229
12230 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12231 structure.
12232
7684e57b
JB
122332011-03-14 Juanma Barranquero <lekktu@gmail.com>
12234
12235 * lisp.h (VWindow_system, Qfile_name_history):
12236 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12237 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12238 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12239
12240 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12241 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12242
12243 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12244 * w32console.c (detect_input_pending, read_input_pending)
12245 (encode_terminal_code):
12246 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12247 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12248 (w32_system_caret_y, Qfile_name_history):
12249 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12250 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12251 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12252 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12253 * w32proc.c (Qlocal, report_file_error):
12254 * w32term.c (Vwindow_system, updating_frame):
12255 * w32uniscribe.c (initialized, uniscribe_font_driver):
12256 Remove unneeded extern declarations.
12257
2aa46d6c
CY
122582011-03-14 Chong Yidong <cyd@stupidchicken.com>
12259
c96bbc66 12260 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12261
cffc6f3b
CY
122622011-03-13 Chong Yidong <cyd@stupidchicken.com>
12263
12264 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12265 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12266 These macros can no longer be used for assignment.
12267
44f230aa
SM
12268 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12269 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12270 (record_buffer_markers, fetch_buffer_markers): New functions for
12271 recording and fetching special buffer markers.
12272 (set_buffer_internal_1, set_buffer_temp): Use them.
12273
12274 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12275
12276 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12277
12278 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12279 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12280
12281 * xdisp.c (hscroll_window_tree):
12282 (reconsider_clip_changes): Use PT instead of BUF_PT.
12283
d251f04b
EZ
122842011-03-13 Eli Zaretskii <eliz@gnu.org>
12285
12286 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12287 $(EMACS_ROOT)/lib/intprops.h.
12288
f0c77cd1
PE
122892011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12290
3eca4629
PE
12291 Fix more problems found by GCC 4.5.2's static checks.
12292
7c86ee98
PE
12293 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12294 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12295 (xg_free_frame_widgets): Make it clear that a local variable is
12296 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12297 (gdk_window_get_screen): Make it clear that this macro is needed
12298 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12299 (int_gtk_range_get_value): New function, which avoids a diagnostic
12300 from gcc -Wbad-function-cast.
12301 (xg_set_toolkit_scroll_bar_thumb): Use it.
12302 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12303 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12304 (get_utf8_string, xg_get_file_with_chooser):
12305 Rename locals to avoid shadowing.
12306 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12307
41729b81
PE
12308 * xgselect.c (xg_select): Remove unused var.
12309
f0c77cd1
PE
12310 * image.c (four_corners_best): Mark locals as initialized.
12311 (gif_load): Initialize transparent_p to zero (Bug#8238).
12312 Mark another local as initialized.
ec6cf4c6 12313 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12314
ce0ad53d 12315 * image.c (clear_image_cache): Now static.
d5d5a617 12316 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12317 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12318 (x_edge_detection): Remove unnecessary cast that
12319 gcc -Wbad-function-cast diagnoses.
2037898d 12320 (gif_load): Fix pointer signedness.
6ae141d6
PE
12321 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12322 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12323
33383987 123242011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12325
d32df629
PE
12326 Improve quality of tests for time stamp overflow.
12327 For example, without this patch (encode-time 0 0 0 1 1
12328 1152921504606846976) returns the obviously-bogus value (-948597
12329 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12330 reports time overflow. See
12331 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12332 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12333 * editfns.c: Include limits.h and intprops.h.
12334 (TIME_T_MIN, TIME_T_MAX): New macros.
12335 (time_overflow): Move earlier, to before first use.
12336 (hi_time, lo_time): New functions, for an accurate test for
12337 out-of-range times.
12338 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12339 (Fget_internal_run_time): Don't assume time_t fits in int.
12340 (make_time): Use list2 instead of Fcons twice.
12341 (Fdecode_time): More accurate test for out-of-range times.
12342 (check_tm_member): New function.
12343 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12344 (lisp_time_argument): Don't rely on undefined left-shift and
12345 right-shift behavior when checking for time stamp overflow.
8be6f318 12346
fe31d94c
PE
12347 * editfns.c (time_overflow): New function, refactoring common code.
12348 (Fformat_time_string, Fdecode_time, Fencode_time):
12349 (Fcurrent_time_string): Use it.
12350
8be6f318
PE
12351 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12352 * dired.c (make_time): Move to ...
12353 * editfns.c (make_time): ... here.
12354 * systime.h: Note the move.
12355
09d9db2c 123562011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12357
126bc0dc
YM
12358 * fringe.c (update_window_fringes): Remove unused variables.
12359
c47cbdfd
YM
12360 * unexmacosx.c (copy_data_segment): Also copy __got section.
12361 (Bug#8223)
12362
7ac80be9
EZ
123632011-03-12 Eli Zaretskii <eliz@gnu.org>
12364
c96bbc66 12365 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12366 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12367 Constify `char *' arguments and their references according to
12368 prototypes in tparam.h.
12369
ecb0f94d 12370 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12371
7ac80be9
EZ
12372 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12373 Adapt all references accordingly.
12374
12375 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12376
ef1fd07e
TT
123772011-03-11 Tom Tromey <tromey@redhat.com>
12378
12379 * buffer.c (syms_of_buffer): Remove obsolete comment.
12380
7ef4b50c
EZ
123812011-03-11 Eli Zaretskii <eliz@gnu.org>
12382
12383 * termhooks.h (encode_terminal_code): Declare prototype.
12384
12385 * msdos.c (encode_terminal_code): Don't declare prototype.
12386
12387 * term.c (encode_terminal_code): Now external again, used by
12388 w32console.c and msdos.c.
12389
44f230aa
SM
12390 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12391 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12392
4b1ec863 123932011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12394
1714f52b 12395 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12396
4b1ec863
PE
12397 * fringe.c (update_window_fringes): Mark locals as initialized
12398 (Bug#8227).
12399 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12400
524c7aa6
PE
12401 * alloc.c (mark_fringe_data): Move decl from here ...
12402 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12403 to check its interface.
12404 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12405
a5c0af81 12406 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12407 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12408 (fontset_font): Mark local as initialized.
a9a06e0b 12409 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12410
b4716021
PE
12411 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12412
811e9bac 12413 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12414 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12415 (x_own_selection, Fx_disown_selection_internal): Rename locals
12416 to avoid shadowing.
12417 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12418
7e3ab302
PE
12419 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12420 so that the caller can use some name other than gcpro1.
12421 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12422 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12423 (Fx_backspace_delete_keys_p):
12424 Use them to avoid shadowing, and rename vars to avoid shadowing.
12425 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12426 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12427 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12428 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12429 Remove unused locals.
7e3ab302
PE
12430 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12431 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12432 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12433 macros.
f78faa98 12434
e2b13473
PE
12435 * xterm.h (x_mouse_leave): New decl.
12436
77f23912
PE
12437 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12438 Remove unused functions.
cdf4ba58
PE
12439 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12440 (x_calc_absolute_position): Now static.
7411c686 12441 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12442 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12443 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12444 unless they are used.
38d0b34a
PE
12445 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12446 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12447 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12448 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12449 (x_error_catcher, x_connection_closed, x_error_handler):
12450 (x_error_quitter, xembed_send_message, x_iconify_frame):
12451 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12452 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12453 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12454
44f230aa
SM
12455 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12456 Rename or move locals to avoid shadowing.
6b463e58 12457 (tty_defined_color, merge_face_heights): Now static.
5967d051 12458 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12459 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12460 does not deduce is never used uninitialized.
73719eba
PE
12461 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12462 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12463
426994c3 12464 * terminal.c (store_terminal_param): Now static.
5489860b 12465
032f1620 12466 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12467 (set_frame_menubar): Remove unused local.
d4323972 12468 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12469 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12470 since they might point to immutable storage.
281585b0
PE
12471 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12472 since it's unused otherwise.
032f1620 12473
367c19e5 12474 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12475 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12476 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12477 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12478 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12479 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12480 does not deduce are never used uninitialized.
70739cbe 12481
07b48fa9
PE
12482 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12483
8868a238 12484 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12485 * window.c (window_loop, size_window):
12486 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12487
7e5cf297 12488 * window.c (display_buffer): Now static.
d6550a9f
PE
12489 (size_window): Mark variables that gcc -Wuninitialized
12490 does not deduce are never used uninitialized.
a586633d
PE
12491 * window.h (check_all_windows): New decl, to forestall
12492 gcc -Wmissing-prototypes diagnostic.
5b555da1 12493 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12494
f6095868
PE
12495 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12496 shadowing.
12497 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12498 Include <limits.h>.
12499 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12500 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12501 (load_charset_map): Mark variables that gcc -Wuninitialized
12502 does not deduce are never used uninitialized.
53df7c11 12503 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12504
f38b440c
PE
12505 * coding.c (coding_set_source, coding_set_destination):
12506 Use "else { /* comment */ }" rather than "else /* comment */;"
12507 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12508 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12509 a block, when the outer 'i' will do.
12510 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12511 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12512 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12513 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12514 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12515 Rename locals to avoid shadowing.
12516 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12517 * coding.c (emacs_mule_char, encode_invocation_designation):
12518 Now static, since they're not used elsewhere.
413bb2db 12519 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12520 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12521 (decode_coding_emacs_mule): Mark variables that gcc
12522 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12523 (detect_coding_iso_2022): Initialize a local variable that might
12524 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12525 this initialization is needed. (Bug#8211)
5f58e762
PE
12526 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12527 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12528 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12529 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12530 Remove unused macros.
f38b440c 12531
232b38b9 12532 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12533 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12534 * character.c (string_count_byte8): Likewise.
232b38b9 12535
fb90da1b
PE
12536 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12537 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12538
fb93dbc2
PE
12539 * chartab.c (copy_sub_char_table): Now static, since it's not used
12540 elsewhere.
5c156ace
PE
12541 (sub_char_table_ref_and_range, char_table_ref_and_range):
12542 Rename locals to avoid shadowing.
bbcd0949 12543 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12544
7d3b3862 12545 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12546 (BIDI_BOB): Remove unused macro.
7d3b3862 12547
6be7d3da
PE
12548 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12549 deduce are never used uninitialized.
c2ed9c8b 12550 * term.c (encode_terminal_code): Likewise.
6be7d3da 12551
75f8807f 12552 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12553
50938595
PE
12554 * tparam.h: New file.
12555 * term.c, tparam.h: Include it.
12556 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12557 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12558 Move these decls to tparam.h, and make them agree with what
12559 is actually in tparam.c. The previous trick of using incompatible
12560 decls in different modules does not conform to the C standard.
12561 All callers of tparam changed to use tparam's actual API.
12562 * tparam.c (tparam1, tparam, tgoto):
12563 Use const pointers where appropriate.
12564
fbceeba2
PE
12565 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12566 * cm.h (struct cm): Likewise.
12567 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12568 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12569 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12570 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12571 (turn_on_face, init_tty): Likewise.
12572 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12573
7f3f1250
PE
12574 * term.c (term_mouse_position): Rename local to avoid shadowing.
12575
e6ca6543
PE
12576 * alloc.c (mark_ttys): Move decl from here ...
12577 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12578
c40f8d15
AS
125792011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12580
12581 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12582
cfe0661d
JB
125832011-03-09 Juanma Barranquero <lekktu@gmail.com>
12584
12585 * search.c (compile_pattern_1): Remove argument regp, unused since
12586 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12587 (compile_pattern): Don't pass it.
12588
0afb4571
J
125892011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12590
12591 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12592 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12593 for ! HAVE_GTK3.
12594 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12595
12596 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12597
12598 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12599 gdk_window_get_screen, gdk_window_get_geometry,
12600 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12601 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12602 (xg_get_pixbuf_from_pixmap): New function.
12603 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12604 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12605 Call xg_get_pixbuf_from_pixmap instead of
12606 gdk_pixbuf_get_from_drawable.
12607 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12608 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12609 (xg_check_special_colors): Use GtkStyleContext and its functions
12610 for HAVE_GTK3.
12611 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12612 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12613 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12614 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12615 Call gtk_widget_get_preferred_size.
0afb4571
J
12616 (xg_frame_resized): gdk_window_get_geometry only takes 5
12617 parameters.
44f230aa
SM
12618 (xg_win_to_widget, xg_event_is_for_menubar):
12619 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12620 (xg_set_widget_bg): New function.
12621 (delete_cb): New function.
895009e1 12622 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12623 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12624 (xg_set_background_color): Call xg_set_widget_bg.
12625 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12626 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12627 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12628 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12629 if ! HAVE_GTK3.
12630 (update_frame_tool_bar): Call gtk_widget_hide.
12631 (xg_initialize): Use GDK_KEY_g.
12632
12633 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12634 if ! HAVE_GTK3
12635 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12636
12637 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12638 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12639 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12640
1c2cc4ef
JB
126412011-03-08 Juanma Barranquero <lekktu@gmail.com>
12642
12643 * w32xfns.c (select_palette): Check success of RealizePalette against
12644 GDI_ERROR, not zero.
12645
33383987 12646See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12647
12648;; Local Variables:
12649;; coding: utf-8
aac0c6e3
MR
12650;; End:
12651
2f097256 12652 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12653
12654 This file is part of GNU Emacs.
12655
12656 GNU Emacs is free software: you can redistribute it and/or modify
12657 it under the terms of the GNU General Public License as published by
12658 the Free Software Foundation, either version 3 of the License, or
12659 (at your option) any later version.
12660
12661 GNU Emacs is distributed in the hope that it will be useful,
12662 but WITHOUT ANY WARRANTY; without even the implied warranty of
12663 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12664 GNU General Public License for more details.
12665
12666 You should have received a copy of the GNU General Public License
12667 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.