Move DONT_REOPEN_PTY from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
20e94fdd
GM
12012-07-11 Glenn Morris <rgm@gnu.org>
2
9d596af3
GM
3 * s/darwin.h, s/freebsd.h, s/netbsd.h:
4 Move DONT_REOPEN_PTY to configure.
5
20e94fdd
GM
6 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
7 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
8
e99a530f
PE
92012-07-10 Paul Eggert <eggert@cs.ucla.edu>
10
22ffb973
PE
11 Remove "#define unix" that is no longer needed (Bug#11905).
12 * s/aix4-2.h (unix): Remove; no longer needed.
13
e9a9ae03
PE
14 EMACS_TIME simplification (Bug#11875).
15 This replaces macros (which typically do not work in GDB)
16 with functions, typedefs and enums, making the code easier to debug.
17 The functional style also makes code easier to read and maintain.
18 * systime.h: Include <sys/time.h> on all hosts, not just if
19 WINDOWSNT, since 'struct timeval' is needed in general.
20 (EMACS_TIME): Now a typedef, not a macro.
21 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
22 not macros.
23 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
24 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
25 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
26 (EMACS_TIME_LE): Now functions, not macros.
27 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
28 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
29 which are not functions. All uses rewritten to use:
30 (make_emacs_time): New function.
31 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
32 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
33 not functions. All uses rewritten to use the following, respectively:
34 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
35 (add_emacs_time, sub_emacs_time): New functions.
36 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
37 * fileio.c (Fcopy_file):
38 * xterm.c (XTflash): Get the current time closer to when it's used.
39 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
40
ffacb126
PE
41 * bytecode.c (targets): Suppress -Woverride-init warnings.
42
e99a530f
PE
43 Simplify by avoiding confusing use of strncpy etc.
44 * doc.c (Fsnarf_documentation):
45 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
46 * frame.c (Fmake_terminal_frame):
47 * gtkutil.c (get_utf8_string):
48 * lread.c (openp):
49 * nsmenu.m (ns_update_menubar):
50 * regex.c (regerror):
51 Prefer memcpy to strncpy and strncat when either will do.
52 * fileio.c (Fsubstitute_in_file_name):
53 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
54 (menu_separator_name_p):
55 * nsmenu.m (ns_update_menubar):
56 Prefer memcmp to strncmp when either will do.
57 * nsterm.m: Include <ftoastr.h>.
58 (ns_get_color):
59 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
60 Prefer snprintf to strncpy.
61 * nsterm.m (ns_term_init):
62 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
63 * nsterm.m (ns_term_init):
64 Avoid the need for strncpy, by using build_string or
65 make_unibyte_string directly. Use dtoastr, not snprintf.
66 * process.c (Fmake_network_process): Diagnose service names that
67 are too long, rather than silently truncating them or creating
68 non-null-terminated names.
69 (Fnetwork_interface_info): Likewise, for interface names.
70 * sysdep.c (system_process_attributes) [GNU_LINUX]:
71 Prefer sprintf to strncat.
72 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
73 Prefer vsnprintf to vsprintf + strncpy.
74
c59592b3
GM
752012-07-10 Glenn Morris <rgm@gnu.org>
76
77 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
78 Clarify fallback case.
79
7d7bbefd
DA
802012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
81
82 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
83 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
84 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
85 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
86 where argument type is known to be a Lisp_Cons.
87
3a4c8000
TT
882012-07-10 Tom Tromey <tromey@redhat.com>
89
90 * bytecode.c (BYTE_CODE_THREADED): New macro.
91 (BYTE_CODES): New macro. Replaces all old byte-code defines.
92 (enum byte_code_op): New type.
93 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
94 (exec_byte_code): Use them. Use token threading when applicable.
95
2a0213a6
DA
962012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
97
98 Optimize pure C strings initialization.
99 * lisp.h (make_pure_string): Fix prototype.
100 (build_pure_c_string): New function, defined as static inline. This
101 provides a better opportunity to optimize away calls to strlen when
102 the function is called with compile-time constant argument.
103 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
104 argument, adjust users accordingly. Use build_pure_c_string where
105 appropriate.
106 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
107 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
108 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
109
cb1caeaf
DA
1102012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
111
112 Avoid calls to strlen in miscellaneous functions.
113 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
114 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
115 * lread.c (openp): Likewise.
116
c293e30c
DA
1172012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
118
119 Avoid calls to strlen in path processing functions.
120 * fileio.c (file_name_as_directory): Add comment. Change to add
121 srclen argument and return the length of result. Adjust users
122 accordingly.
123 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 124 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
125 users accordingly.
126 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
127
9e059e3f
GM
1282012-07-10 Glenn Morris <rgm@gnu.org>
129
d02eb359
GM
130 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
131 Move PENDING_OUTPUT_COUNT definition to configure.
132
882cf227
GM
133 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
134 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
135 * s/gnu.h (DATA_START): Move definitions to configure.
136
af6e839f
GM
137 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
138 We include usg5-4-common.h, which defines them both.
139
40289a12
GM
140 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
141 O_RDONLY already includes it).
142
9e059e3f
GM
143 Stop ns builds setting the EMACSLOADPATH environment variable.
144 * nsterm.m (ns_load_path): Rename from ns_init_paths.
145 Now it does not set EMACSLOADPATH, just returns the load-path string.
146 * nsterm.h: Update accordingly.
147 * lread.c [HAVE_NS]: Include nsterm.h.
148 (init_lread) [HAVE_NS]: Use ns_load_path.
149 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
150
7c4e8ec0
GM
1512012-07-09 Glenn Morris <rgm@gnu.org>
152
d4f600ff
GM
153 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
154 since the included bsd-common.h does so.
155
cbb31951
GM
156 Stop ns builds setting the EMACSPATH environment variable.
157 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
158 (ns_init_paths): Do not set EMACSPATH.
159 * nsterm.h (ns_exec_path): Add it.
160 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
161 Use ns_exec_path.
162
7c4e8ec0
GM
163 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
164
26bccfae
PE
1652012-07-09 Paul Eggert <eggert@cs.ucla.edu>
166
a0bee46f
PE
167 * process.c (wait_reading_process_output): 'waitchannels' was unset
168 when read_kbd || !NILP (wait_for_cell); fix this.
169
5994c183
PE
170 Add GCC-style 'const' attribute to functions that can use it.
171 * character.h (char_resolve_modifier_mask):
172 * keyboard.h (make_ctrl_char):
173 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
174 (init_character_once, next_almost_prime, init_fns, init_image)
175 (flush_pending_output, init_sound):
176 * mem-limits.h (start_of_data):
177 * menu.h (finish_menu_items):
178 Add ATTRIBUTE_CONST.
179 * emacs.c (DEFINE_DUMMY_FUNCTION):
180 Declare the dummy function with ATTRIBUTE_CONST.
181 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
182 Add decls with ATTRIBUTE_CONST.
183
26bccfae
PE
184 Minor improvements to make_formatted_string.
185 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
186 where int is good enough, as vsprintf returns an int.
187 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
188
a8290ec3
DA
1892012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Use make_formatted_string to avoid double length calculation.
192 * lisp.h (make_formatted_string): New prototype.
193 * alloc.c (make_formatted_string): New function.
194 * buffer.c (Fgenerate_new_buffer_name): Use it.
195 * dbus.c (syms_of_dbusbind): Likewise.
196 * editfns.c (Fcurrent_time_zone): Likewise.
197 * filelock.c (get_boot_time): Likewise.
198 * frame.c (make_terminal_frame, set_term_frame_name)
199 (x_report_frame_params): Likewise.
200 * image.c (gs_load): Likewise.
201 * minibuf.c (get_minibuffer): Likewise.
202 * msdos.c (dos_set_window_size): Likewise.
203 * process.c (make_process): Likewise.
204 * xdisp.c (ensure_echo_area_buffers): Likewise.
205 * xsettings.c (apply_xft_settings): Likewise.
206
d01ba2f1
GM
2072012-07-09 Glenn Morris <rgm@gnu.org>
208
209 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
210 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
211 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
212 * nsterm.h (ns_etc_directory): Add it.
213 * callproc.c [HAVE_NS]: Include nsterm.h.
214 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
215
f1f924b6
DA
2162012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
217
218 Move marker debugging code under MARKER_DEBUG.
219 * marker.c (MARKER_DEBUG): Move marker debugging code under
220 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
221 for bootstrap with --enable-checking (~3x slowdown reported
222 by Juanma Barranquero <lekktu@gmail.com>).
223 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
224
ab531b66
PE
2252012-07-08 Paul Eggert <eggert@cs.ucla.edu>
226
227 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
228 See <http://bugs.gnu.org/11825#29>.
229
c4b3bc8a
EZ
2302012-07-08 Eli Zaretskii <eliz@gnu.org>
231
232 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
233 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
234 (display_line): Add commentary about displaying truncation glyphs
235 on GUI frames.
236 (produce_special_glyphs): Move here from term.c.
237
238 * term.c (produce_special_glyphs): Move to xdisp.c.
239
240 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
241 section.
c4b3bc8a 242
b676b881
AS
2432012-07-07 Andreas Schwab <schwab@linux-m68k.org>
244
f17c5273
AS
245 * xdisp.c (display_line): Avoid warning about implicit declaration
246 of FRAME_FONT.
247
298819b9
AS
248 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
249
b676b881
AS
250 * lisp.h: Remove empty conditional.
251
6045c4fd
PE
2522012-07-07 Paul Eggert <eggert@cs.ucla.edu>
253
b3350bf9
PE
254 * lread.c (load_path_check): Now static.
255
6045c4fd
PE
256 Fix some minor --with-ns problems found by static checking.
257 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
258 (x_set_font) [!HAVE_X_WINDOWS]:
259 * image.c (xpm_load_image) [HAVE_NS]:
260 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
261 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
262 Remove unused local.
263 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
264 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
265 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
266 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
267 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
268 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
269 Fix pointer signedness problem.
270 * xfaces.c (FRAME_X_FONT_TABLE):
271 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
272
929e7845
GM
2732012-07-07 Glenn Morris <rgm@gnu.org>
274
275 * lread.c (load_path_check): New function, split from init_lread.
276 (init_lread): Reorganize. Motivation:
277 If EMACSLOADPATH is set, check/warn about that rather than the
278 defaults, which we are not going to use. Hence we can remove
279 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
280 Don't warn if site-lisp directories are missing.
281 If not installed, start from a blank load-path, since
282 PATH_LOADSEARCH refers to the eventual installation directories.
283
58dd0aa4
EZ
2842012-07-07 Eli Zaretskii <eliz@gnu.org>
285
286 Support truncation and continuation glyphs on GUI frames, when
287 fringes are disabled. (Bug#11832)
288 * xdisp.c (init_iterator): Get dimensions of truncation and
289 continuation glyphs even if on GUI frames. Adjust
290 it->last_visible_x on GUI frames when the left or right fringes,
291 or both, are absent.
292 (start_display, move_it_in_display_line_to): Handle the case of a
293 GUI frame without a fringe to display continuation or truncation
294 glyphs.
295 (insert_left_trunc_glyphs): Support GUI frames: make sure
296 truncation glyphs overwrite enough glyphs from the current line to
297 have sufficient space in pixels.
298 (display_line): Support truncation and continuation glyphs on GUI
299 frames. If some spare pixels are left on the line after inserting
300 the truncation glyphs, fill that space with a stretch glyph of a
301 suitably computed width.
302
303 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
304 produce_glyphs, to support GUI sessions.
305
31571fd7
PE
3062012-07-07 Paul Eggert <eggert@cs.ucla.edu>
307
5a16b9bc
PE
308 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
309
f3047c75
PE
310 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
311
31571fd7
PE
312 Do not require float-time's arg to fit in time_t (Bug#11825).
313 This works better on hosts where time_t is unsigned, and where
314 float-time is applied to the (negative) difference between two times.
315 * editfns.c (decode_time_components): Last arg is now double *,
316 not int *, and means to store all the result as a double, without
317 worrying about whether the seconds part fits in time_t.
318 All callers changed.
319 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
320 All callers changed.
321 (Ffloat_time): Do not fail merely because the specified time falls
322 outside of time_t range.
323
4516fbef
GM
3242012-07-07 Glenn Morris <rgm@gnu.org>
325
326 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
327 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
328 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
329
07adc2c6
JB
3302012-07-07 Juanma Barranquero <lekktu@gmail.com>
331
332 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
333 Update dependencies.
334
335 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
336
fd573f31
PE
3372012-07-06 Paul Eggert <eggert@cs.ucla.edu>
338
fee5959d
PE
339 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
340 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
341 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
342 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
343 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
344 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
345
fd573f31
PE
346 * xfont.c (compare_font_names): Redo to omit the need for casts.
347
ddadbc0e
AS
3482012-07-06 Andreas Schwab <schwab@linux-m68k.org>
349
fca8d6b6
AS
350 * xfns.c (Fx_change_window_property): Doc fix.
351 * w32fns.c (Fx_change_window_property): Doc fix.
352
ddadbc0e
AS
353 * w32fns.c (Fx_window_property): Accept the same arguments as the
354 X Windows version. Doc fix.
355 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
356
f247498e
JB
3572012-07-06 Juanma Barranquero <lekktu@gmail.com>
358 Eli Zaretskii <eliz@gnu.org>
359
360 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
361 Windows-specific code from nt/config.nt moved here.
362 Obsolete settings removed.
363
216ee680
PE
3642012-07-06 Paul Eggert <eggert@cs.ucla.edu>
365
366 * process.c: Avoid unnecessary calls to gettime.
367 (wait_reading_process_output): Don't get the time of day
368 when gobbling data immediately and not waiting, as there's no need
369 for it in that case. This removes a FIXME.
370
bdd091e4
JD
3712012-07-06 Jan Djärv <jan.h.d@swipnet.se>
372
373 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
374 is defined (Bug#11768).
375
9d44f8ce
DA
3762012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
377
378 Fix marker debugging code.
379 * marker.c (byte_char_debug_check): Do not perform the check
380 if buffer is not multibyte.
090bd7cb
JB
381 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
382 Call byte_char_debug_check with correct arguments.
9d44f8ce 383
90fc4786
DA
3842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
385
386 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
387 * marker.c (byte_char_debug_check, count_markers):
388 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
389 (byte_debug_flag): Remove.
390 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
391 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
392
7b7ae965
DA
3932012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
394
4e57b342
DA
395 Avoid code repetition in marker-related functions.
396 * marker.c (attach_marker): New function.
397 (Fset_marker, set_marker_restricted, set_marker_both)
398 (set_marker_restricted_both): Use it.
399 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
400 Consistently rename charno to charpos.
401 (marker_position): Add eassert.
402 (marker_byte_position): Convert to eassert.
403
4042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
405
406 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 407 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 408 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 409
657924ff
DA
4102012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
411
412 Introduce fast path for the widely used marker operation.
413 * alloc.c (build_marker): New function.
414 * lisp.h (build_marker): New prototype.
415 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
416 * composite.c (autocmp_chars): Likewise.
417 * editfns.c (buildmark): Remove.
418 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
419 (save_restriction_save): Use build_marker.
420 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
421 * window.c (save_window_save): Likewise.
422
041a49a6
DA
4232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
424
425 Do not use Fdelete_overlay in delete_all_overlays
426 to avoid redundant calls to unchain_overlay.
427 * buffer.c (drop_overlay): New function.
428 (delete_all_overlays, Fdelete_overlay): Use it.
429 * minibuf.c (get_minibuffer): Fix comment.
430
7dca65a4
PE
4312012-07-06 Paul Eggert <eggert@cs.ucla.edu>
432
433 Port to OpenBSD 5.1 amd64.
434 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
435 This is needed for OpenBSD, and should be harmless on all BSD systems.
436 Also, include <sys/sysctl.h>, as it should be available on all
437 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
438 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
439 use p_pid member, not kp_proc.pid.
440
8eb876e2
GM
4412012-07-06 Glenn Morris <rgm@gnu.org>
442
443 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
444
38182d90
PE
4452012-07-05 Paul Eggert <eggert@cs.ucla.edu>
446
447 More xmalloc and related cleanup.
448 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
449 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
450 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
451 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
452 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
453 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
454 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
455 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
456 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
457 * xterm.c:
458 Omit needless casts involving void * pointers and allocation.
459 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
460 as the former is more robust if P's type is changed.
461 Prefer xzalloc to xmalloc + memset 0.
462 Simplify malloc-or-realloc to realloc.
463 Don't worry about xmalloc returning a null pointer.
464 Prefer xstrdup to xmalloc + strcpy.
465 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
466 growing it.
467 * keyboard.c (apply_modifiers_uncached): Prefer local array to
468 alloca of a constant.
469
6dd5a677
EZ
4702012-07-05 Eli Zaretskii <eliz@gnu.org>
471
472 * xdisp.c (display_line): Fix horizontal pixel coordinates when
473 hscroll is larger than the line width. Fixes long and futile
474 looping inside extend_face_to_end_of_line (on a TTY) producing
475 glyphs that are not needed and thrown away.
476
6b312f0f
DA
4772012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
478
479 * marker.c (set_marker_restricted_both): Simplify by using
480 clip_to_bounds.
481
f520ef9b
PE
4822012-07-05 Paul Eggert <eggert@cs.ucla.edu>
483
484 * editfns.c (region_limit): Simplify by using clip_to_bounds.
485
383b7c95
JD
4862012-07-05 Jan Djärv <jan.h.d@swipnet.se>
487
488 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
489 not defined (Bug#11768).
490 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
491 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
492 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
493 followed by gtk_box_set_homogeneous (Bug#11768).
494 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
495 (update_theme_scrollbar_width, xg_create_scroll_bar):
496 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
497 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
498 (is_box_type): New function (Bug#11768).
499 (xg_tool_item_stale_p): Call is_box_type.
5293d758 500 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
501 with default display (Bug#11768).
502
d6e7bf45
EZ
5032012-07-05 Eli Zaretskii <eliz@gnu.org>
504
505 * xdisp.c (window_hscroll_limited): New function.
506 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
507 coordinates when window's hscroll is set to insanely large
508 values. (Bug#11857)
509
431391ec
JB
5102012-07-05 Juanma Barranquero <lekktu@gmail.com>
511
512 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
513 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
514
23f86fce
DA
5152012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
516
517 Cleanup xmalloc.
518 * lisp.h (xzalloc): New prototype. Omit needless casts.
519 * alloc.c (xzalloc): New function. Omit needless casts.
520 * charset.c: Omit needless casts. Convert all calls to
521 xmalloc with following memset to xzalloc.
522 * dispnew.c: Likewise.
523 * fringe.c: Likewise.
524 * image.c: Likewise.
525 * sound.c: Likewise.
526 * term.c: Likewise.
527 * w32fns.c: Likewise.
528 * w32font.c: Likewise.
529 * w32term.c: Likewise.
530 * xfaces.c: Likewise.
531 * xfns.c: Likewise.
532 * xterm.c: Likewise.
533 * atimer.c: Omit needless casts.
534 * buffer.c: Likewise.
535 * callproc.c: Likewise.
536 * ccl.c: Likewise.
537 * coding.c: Likewise.
538 * composite.c: Likewise.
539 * doc.c: Likewise.
540 * doprnt.c: Likewise.
541 * editfns.c: Likewise.
542 * emacs.c: Likewise.
543 * eval.c: Likewise.
544 * filelock.c: Likewise.
545 * fns.c: Likewise.
546 * gtkutil.c: Likewise.
547 * keyboard.c: Likewise.
548 * lisp.h: Likewise.
549 * lread.c: Likewise.
550 * minibuf.c: Likewise.
551 * msdos.c: Likewise.
552 * print.c: Likewise.
553 * process.c: Likewise.
554 * region-cache.c: Likewise.
555 * search.c: Likewise.
556 * sysdep.c: Likewise.
557 * termcap.c: Likewise.
558 * terminal.c: Likewise.
559 * tparam.c: Likewise.
560 * w16select.c: Likewise.
561 * w32.c: Likewise.
562 * w32reg.c: Likewise.
563 * w32select.c: Likewise.
564 * w32uniscribe.c: Likewise.
565 * widget.c: Likewise.
566 * xdisp.c: Likewise.
567 * xmenu.c: Likewise.
568 * xrdb.c: Likewise.
569 * xselect.c: Likewise.
570
0497dc44
PE
5712012-07-05 Paul Eggert <eggert@cs.ucla.edu>
572
573 * fileio.c (time_error_value): Check the right error number.
574 Problem reported by Troels Nielsen in
575 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
576
356e7178
PE
5772012-07-04 Paul Eggert <eggert@cs.ucla.edu>
578
4e71fd89
PE
579 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
580 This should be fixed in a better way; see Eli Zaretskii in
581 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
582 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
583
f0941253
PE
584 * fileio.c (time_error_value): Rename from special_mtime.
585 The old name's problems were noted by Eli Zaretskii in
586 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
587
065c9eb4
PE
588 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
589 This variable's comment says Emacs needs at least one GDB-visible
590 symbol of type enum pvec_type, to work around GDB problems.
591 The symbol's value doesn't matter.
592
356e7178
PE
593 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
594 that causes compilation to fail on pre-C99 compilers.
595
95f61aa2
JB
5962012-07-04 Juanma Barranquero <lekktu@gmail.com>
597
598 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
599 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
600
3884d954
DA
6012012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
602
d209e2fb 603 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
604 headers for buffer_defaults and buffer_local_symbols.
605 Reported by Juanma Barranquero <lekktu@gmail.com>.
606
ee28be33
SM
6072012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
608
609 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
610 * lisp.h (enum pvec_type): Use fewer bits.
611 (PSEUDOVECTOR_SIZE_BITS): New constant.
612 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
613 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
614 change in pvec_type.
615 (PSEUDOVECTOR_TYPEP): New macro.
616 (TYPED_PSEUDOVECTORP): Use it.
617 * fns.c (internal_equal): Adapt code to extract pvectype.
618 * emacs.c (gdb_pvec_type): Update type.
619 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
620 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
621 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
622 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
623 (sweep_vectors): Use it. Use local var `total_bytes' instead of
624 abusing vector->header.next.nbytes.
625 (live_vector_p): Use PVEC_TYPE.
626 (mark_object): Adapt code to extract pvectype. Use switch.
627
c7f2cd7f
PE
6282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
629
630 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
631 Tighten new eassert a bit.
632
8ce70ed2
DA
6332012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Fix compilation with --enable-gcc-warnings and -O1
636 optimization level.
637 * doprnt.c (doprnt): Change type of tem to int, initialize
638 to avoid compiler warning. Add eassert.
639 * search.c (simple_search): Initialize match_byte to avoid
640 compiler warning. Add eassert.
641
dea7f1e5
PE
6422012-07-04 Paul Eggert <eggert@cs.ucla.edu>
643
24a212eb
PE
644 Avoid weird behavior with large horizontal scrolls.
645 Without this change, for example, large hscroll values would
646 mess up Emacs's display on Fedora 15 x86, presumably due to
647 overflows in int calculations in the display code.
648 Also, if buffers had long lines, Emacs would freeze.
649 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
650 (set_window_hscroll): New function, containing the old guts of
651 Fset_window_hscroll. Return the clipped value.
652 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
653 This avoids the need to check against PTRDIFF_MAX.
654
dea7f1e5
PE
655 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
656
76046526
DA
6572012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
658
659 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
660
39adff0d
PE
6612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
662
63807d47
PE
663 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
664 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
665 since GCC 4.4.6 issues a bogus warning for them.
666
39adff0d
PE
667 Fix bugs in file timestamp newness comparisons.
668 * fileio.c (Ffile_newer_than_file_p):
669 * lread.c (Fload): Use full timestamp resolution of files,
670 not just the 1-second resolution, so that files that are only
671 slightly newer still count as newer.
672 * fileio.c (Ffile_newer_than_file_p): Don't assume file
673 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
674
dbeed9a6
PE
6752012-07-03 Paul Eggert <eggert@cs.ucla.edu>
676
677 * fileio.c: Improve handling of file time marker. (Bug#11852)
678 (special_mtime): New function.
679 (Finsert_file_contents, Fverify_visited_file_modtime):
680 Use it to set special mtime values consistently.
681
636334d6
AS
6822012-07-03 Andreas Schwab <schwab@linux-m68k.org>
683
684 * fileio.c (Finsert_file_contents): Properly handle st_mtime
685 marker for non-existing file. (Bug#11852)
686
e2017fe2
GM
6872012-07-03 Glenn Morris <rgm@gnu.org>
688
689 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
690 and did not make it into globals.h).
691
404dbd37
TT
6922012-07-03 Tom Tromey <tromey@redhat.com>
693
694 * window.c (Fset_window_margins, Fset_window_fringes)
695 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
696 * textprop.c (Fprevious_property_change): No longer static.
697 * syntax.c (Fsyntax_table_p): No longer static.
698 * process.c (Fget_process, Fprocess_datagram_address): No longer
699 static.
700 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
701 * keyboard.c (Fcommand_execute): No longer static.
702 Remove EXFUN.
703 * insdel.c (Fcombine_after_change_execute): No longer static.
704 * image.c (Finit_image_library): No longer static.
705 * fileio.c (Fmake_symbolic_link): No longer static.
706 * eval.c (Ffetch_bytecode): No longer static.
707 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
708 * doc.c (Fdocumentation_property, Fsnarf_documentation):
709 No longer static.
404dbd37
TT
710 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
711 static.
712 * dired.c (Ffile_attributes): No longer static.
713 * composite.c (Fcomposition_get_gstring): No longer static.
714 * callproc.c (Fgetenv_internal): No longer static.
715
716 * ccl.h: Remove EXFUNs.
717 * buffer.h: Remove EXFUNs.
718 * dispextern.h: Remove EXFUNs.
719 * intervals.h: Remove EXFUNs.
720 * fontset.h: Remove EXFUN.
721 * font.h: Remove EXFUNs.
722 * dosfns.c (system_process_attributes): Remove EXFUN.
723 * keymap.h: Remove EXFUNs.
724 * lisp.h: Remove EXFUNs.
725 * w32term.h: Remove EXFUNs.
726 * window.h: Remove EXFUNs.
727 * xsettings.h: Remove EXFUN.
728 * xterm.h: Remove EXFUN.
729
8e4fd1e1
GM
7302012-07-03 Glenn Morris <rgm@gnu.org>
731
732 * lisp.h (Frandom): Make it visible to C.
733 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
734 buffer for invisible buffers. (Bug#1229)
735
ca95b3eb
DA
7362012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
737
738 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
739 values which aren't power of 2.
740 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
741 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
742 accordingly.
743
7555c33f
SM
7442012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
745
746 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
747
748 * alloc.c (mark_object): Revert part of last patch to use `switch'.
749
d12e8f5a
DA
7502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
751
752 * alloc.c (allocate_vector_block): Remove redundant
753 calls to mallopt if DOUG_LEA_MALLOC is defined.
754 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
755 avoid calls to mallopt if zero_vector is returned.
756
296094c3
DA
7572012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
758
759 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
760 is enabled, avoid dereferencing NULL current_sblock if
761 running undumped.
762
36429c89
DA
7632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
764
765 Cleanup basic buffer management.
766 * buffer.h (struct buffer): Change layout to use generic vector
767 marking code. Fix some comments. Change type of 'clip_changed'
768 to bitfield. Remove unused #ifndef old.
769 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
770 (GET_OVERLAYS_AT): Fix indentation.
771 (for_each_per_buffer_object_at): New macro.
772 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
773 (Fbuffer_local_variables): Use it.
774 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
775 * alloc.c (allocate_buffer): Adjust to match new layout of
776 struct buffer. Fix comment.
777 (mark_overlay): New function.
778 (mark_buffer): Use it. Use mark_vectorlike to mark normal
779 Lisp area of struct buffer.
780 (mark_object): Use it. Adjust marking of misc objects
781 and related comments.
782
3b3e4cac
PE
7832012-07-02 Paul Eggert <eggert@cs.ucla.edu>
784
785 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
786 wrapper that is not needed because the wrapped code is a no-op (zero
787 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
788 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
789
cf5c0175
DA
7902012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
791
792 * alloc.c (mark_buffer): Simplify. Remove prototype.
793 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 794 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
795 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
796 redundant calls to mark_vectorlike for bool vectors.
797
ca26824c
GM
7982012-06-30 Glenn Morris <rgm@gnu.org>
799
2e4c5312
GM
800 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
801
ca26824c
GM
802 * epaths.in (PATH_SITELOADSEARCH): New.
803 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
804 This is rather than relying on --enable-locallisppath elements
805 having "site-lisp" in their names. (Bug#10208#25, 11658)
806
0d23c240
EZ
8072012-06-30 Eli Zaretskii <eliz@gnu.org>
808
c9240d7a
EZ
809 * w32proc.c (sys_select): Accept and ignore one more argument.
810
811 * w32.c (emacs_gnutls_pull): Call select with one more argument.
812
0d23c240 813 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 814 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
815
816 * sysdep.c: Don't include dos.h and dosfns.h.
817
818 * process.c (sys_select):
819 * msdos.c (sys_select): Accept one more argument and ignore it.
820
821 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
822 adapt data types and code to that.
823
824 * dosfns.c:
825 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
826 which clashes with the gnulib function of the same name.
827
af5a5a98
AS
8282012-06-30 Andreas Schwab <schwab@linux-m68k.org>
829
c5e4379c
AS
830 * font.c (font_style_to_value, font_style_symbolic)
831 (font_prop_validate_style): Add type checks for values in
832 font_style_table.
833
af5a5a98
AS
834 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
835 argument.
836 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
837 uses.
838
8d38f461
EZ
8392012-06-29 Eli Zaretskii <eliz@gnu.org>
840
2e5a6631
EZ
841 * xdisp.c (try_window_id): Undo last change.
842
8d38f461
EZ
843 * w32.c (getwd): Adjust commentary about startup_dir.
844 (init_environment): Always call sys_access, even in non-MSVC
845 builds. Don't chdir to the directory of the Emacs executable.
846 This undoes code from 1997 which was justified by the need to
847 "avoid conflicts when removing and renaming directories". But its
848 downside was that every relative file name was being interpreted
849 relative to the directory of the Emacs executable, which can never
850 be TRT. In particular, it broke sys_access when called with
851 relative file names.
852 (sys_access): Map GetLastError to errno.
853
2af3565e
DA
8542012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
855
856 * window.h (struct window): Change type of 'fringes_outside_margins'
857 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 858 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
859 Adjust comment.
860 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
861 to ptrdiff_t.
862
c8d3a25c 8632012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 864
c8d3a25c
GM
865 * gnutls.c (emacs_gnutls_handshake):
866 Add QUIT to make the loop interruptible.
57570cd3 867
c8d3a25c 8682012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 869
c8d3a25c
GM
870 * charset.c (init_charset): Make lack of etc/charsets fatal.
871
3e984ee8
DA
8722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
873
874 * editfns.c (region_limit): Fix type mismatch.
875
ef884f23
DA
8762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
877
878 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
879 undefined. Convert from xassert to eassert.
880 * nsmenu.m: Convert from xassert to eassert.
881 * nsterm.m: Likewise.
882
7d7e0027
SM
8832012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
884
885 * editfns.c (region_limit): Clip to narrowing (bug#11770).
886
aa754e6a
PE
8872012-06-28 Paul Eggert <eggert@cs.ucla.edu>
888
889 Avoid integer overflow on scroll-left and scroll-right.
890 * window.c (HSCROLL_MAX): New macro.
891 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
892 overflow when requested scroll falls outside ptrdiff_t range.
893
80b00b08
DA
8942012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
895
896 * window.h (struct window): Change type of 'hscroll',
897 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
898 'last_modified' and 'last_overlay_modified' to EMACS_INT.
899 Adjust users accordingly.
900 * xdisp.c (try_cursor_movement): Replace type check with eassert.
901 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
902 from EMACS_INT to ptrdiff_t.
903 (make_window): Omit redundant initialization.
904
62b2bcf6
JB
9052012-06-28 Juanma Barranquero <lekktu@gmail.com>
906
907 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
908
45942c7d
DA
9092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
910
911 * window.h (struct window): Change type of 'use_time' and
912 'sequence_number' from Lisp_Object to int.
913 * frame.c (make_frame): Adjust users accordingly.
914 * print.c (print_object): Likewise.
915 * window.c (select_window, Fwindow_use_time, make_parent_window)
916 (make_window): Likewise.
917
e509cfa6
DA
9182012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
919
920 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
921 enabled with --enable-checking=[all,glyphs] configure option.
922 Fix GLYPH_DEBUG usage assuming that it may be undefined,
923 adjust comments accordingly.
924 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
925 undefined, adjust comments accordingly.
926 * image.c: Likewise.
927 * scroll.c: Likewise.
928 * w32fns.c: Likewise.
929 * w32term.c: Likewise.
930 * xdisp.c: Likewise.
931 * xfaces.c: Likewise.
932 * xfns.c: Likewise.
933 * xterm.c: Likewise.
934
a54e2c05
DA
9352012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Generalize run-time debugging checks.
938 * dispextern.h (XASSERTS): Remove.
939 * fontset.c (xassert): Remove.
940 Convert from xassert to eassert.
941 * alloc.c: Convert from xassert to eassert.
942 * bidi.c: Likewise.
943 * dispnew.c: Likewise.
944 * fns.c: Likewise.
945 * fringe.c: Likewise.
946 * ftfont.c: Likewise.
947 * gtkutil.c: Likewise.
948 * image.c: Likewise.
949 * keyboard.c: Likewise.
950 * menu.c: Likewise.
951 * process.c: Likewise.
952 * scroll.c: Likewise.
953 * sound.c: Likewise.
954 * term.c: Likewise.
955 * w32console.c: Likewise.
956 * w32fns.c: Likewise.
957 * w32term.c: Likewise.
958 * window.c: Likewise.
959 * xdisp.c: Likewise.
960 * xfaces.c: Likewise.
961 * xfns.c: Likewise.
962 * xselect.c: Likewise.
963 * xterm.c: Likewise.
964
1ec4b7b2
SM
9652012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
966
967 * fns.c (maybe_resize_hash_table): Output message when growing the
968 purify-hashtable.
969
2014308a
DA
9702012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
971
972 * alloc.c (allocate_string_data): Remove dead code.
973 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
974 avoid GCC warning about unused macro.
975
246155eb
DA
9762012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
977
978 * alloc.c (allocate_string): Omit intervals initialization.
979 * alloc.c (make_uninit_multibyte_string): Initialize intervals
980 as in make_pure_string and make_pure_c_string.
981
43184b7b
DA
9822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
983
d209e2fb 984 * alloc.c (allocate_string): Fix last change.
43184b7b 985
3fe6dd74
DA
9862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
987
d209e2fb 988 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
989 to memset, add explicit initialization where appropriate.
990
1ba6038a
GM
9912012-06-27 Glenn Morris <rgm@gnu.org>
992
993 * lisp.mk (lisp): Remove paths.elc.
994
c89926a5
CY
9952012-06-27 Chong Yidong <cyd@gnu.org>
996
997 * doc.c (Fsubstitute_command_keys): Fix punctuation.
998
ed6b3510
JW
9992012-06-26 John Wiegley <johnw@newartisans.com>
1000
1ec4b7b2 1001 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1002 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1003
ed6b3510
JW
1004 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1005 when building with Clang.
1006
8edd4a2b
SM
10072012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1008
1009 * eval.c (Fapply): Allow calling it with a single argument.
1010
f6f62d1b
EZ
10112012-06-26 Eli Zaretskii <eliz@gnu.org>
1012
1013 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1014 _stricmp and _strnicmp.
1015 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1016
62efea5e
DA
10172012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1018
1019 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1020 allocated window.
1021 (allocate_process): Likewise for new process.
8edd4a2b 1022 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1023 (allocate_frame): Likewise.
1024 * frame.c (make_frame): Omit redundant initialization.
1025 * window.c (make_parent_window): Use memset.
1026 (make_window): Omit redundant initialization.
1027 * process.c (make_process): Omit redundant initialization.
1028 * terminal.c (create_terminal): Likewise.
1029
42997f4d
DA
10302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1031
1032 * term.c (delete_tty): Remove redundant call to memset.
1033
1130ecfc
DA
10342012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 * alloc.c: Remove build_string.
1037 * lisp.h: Define build_string as static inline. This provides
1038 a better opportunity to optimize away calls to strlen when the
1039 function is called with compile-time constant argument.
1040 * image.c (imagemagick_error): Convert to build_string.
1041 * w32proc.c (sys_spawnve): Likewise.
1042 * xterm.c (x_term_init): Likewise.
1043
cf38a720
PE
10442012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1045
99027bdd
PE
1046 Use sprintf return value instead of invoking strlen on result.
1047 In the old days this wasn't portable, since some sprintf
1048 implementations returned char *. But they died out years ago and
1049 Emacs already assumes sprintf returns int.
1050 Similarly for float_to_string.
1051 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1052 * ccl.c (ccl_driver):
1053 * character.c (string_escape_byte8):
1054 * data.c (Fnumber_to_string):
1055 * doprnt.c (doprnt):
1056 * print.c (print_object):
1057 * xdisp.c (message_dolog):
1058 * xfns.c (syms_of_xfns):
1059 Use sprintf or float_to_string result to avoid need to call strlen.
1060 * data.c (Fnumber_to_string):
1061 Use make_unibyte_string, since the string must be ASCII.
1062 * lisp.h, print.c (float_to_string): Now returns int length.
1063 * term.c (produce_glyphless_glyph):
1064 Use sprintf result rather than recomputing it.
1065
cf38a720
PE
1066 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1067 * Makefile.in (ALL_CFLAGS):
1068 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1069 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1070
3511c784
DA
10712012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1072
0a08eb21 1073 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1074 strcasecmp if available.
1075 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1076
fb7da12e
AS
10772012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1078
1079 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1080 Avoid comma operator.
1081 * menu.c (push_submenu_start, push_submenu_end)
1082 (push_left_right_boundary, push_menu_pane): Likewise.
1083 * msdos.c (dos_rawgetc): Likewise.
1084
afa2ffd8
DA
10852012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1086
1087 * xfns.c (xic_create_fontsetname): Remove redundant calls
1088 to memset.
1089
b3b4476b
PE
10902012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1091
4495ff38
PE
1092 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1093 sprintf already null-terminates its output.
1094
b3b4476b
PE
1095 * xfns.c (x_window): Remove redundant cast.
1096
b00876c9
DA
10972012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1100 `const char *' to `char *' to avoid compiler warning.
1101
d188e26b
PE
11022012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1103
885d1d74
PE
1104 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1105 instead of truncating it to 63 (admittedly a generous limit).
1106
d188e26b
PE
1107 * process.c: Fix spelling and caps in comments.
1108
e2f560b1
DN
11092012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1110
e86db54b 1111 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1112 * sysdep.c (setpgrp): Remove definition, not used in this file.
1113
7583a3a1
JB
11142012-06-24 Juanma Barranquero <lekktu@gmail.com>
1115
1116 * makefile.w32-in: Update dependencies.
1117
696056c2
EZ
11182012-06-24 Eli Zaretskii <eliz@gnu.org>
1119
1120 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1121 (SYSTIME_H): Add nt/inc/sys/time.h.
1122
1123 * systime.h [WINDOWSNT]: Include sys/time.h.
1124
1125 * s/ms-w32.h (struct timespec): Definition moved from
1126 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1127
845ca893
PE
11282012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1131 * buffer.h (buffer_slot_type_mismatch):
1132 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1133 * eval.c (unwind_to_catch):
1134 * image.c (my_png_error, my_error_exit):
1135 * keyboard.c (quit_throw_to_read_char, user_error)
1136 (Fexit_recursive_edit, Fabort_recursive_edit):
1137 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1138 (wrong_type_argument, buffer_overflow, __executable_start)
1139 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1140 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1141 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1142 (fatal):
1143 (child_setup) [!DOS_NT]:
1144 * lread.c (end_of_file_error, invalid_syntax):
1145 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1146 * puresize.h (pure_write_error):
1147 * search.c (matcher_overflow):
1148 * sound.c (sound_perror, alsa_sound_perror):
1149 * sysdep.c, syssignal.h (croak):
1150 * term.c (maybe_fatal, vfatal):
1151 * textprop.c (text_read_only):
1152 * undo.c (user_error):
1153 * unexmacosx.c (unexec_error):
1154 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1155 Use _Noreturn rather than NO_RETURN.
1156 No need for separate decl merely because of _Noreturn.
1157 * sound.c (sound_warning, parse_sound):
1158 Remove unnecessary forward decls.
1159
f1dd8073
PE
11602012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1161
1162 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1163 * lisp.h (WAIT_READING_MAX): New macro.
1164 * dispnew.c (Fsleep_for, sit_for):
1165 * keyboard.c (kbd_buffer_get_event):
1166 * process.c (Faccept_process_output):
1167 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1168 This improves on the previous patch, which introduced a bug
1169 when time_t is unsigned and as wide as intmax_t.
1170 See <http://bugs.gnu.org/9000#51>.
1171
b82c1755
EZ
11722012-06-23 Eli Zaretskii <eliz@gnu.org>
1173
1174 * dispnew.c (sit_for, Fsleep_for):
1175 * keyboard.c (kbd_buffer_get_event):
1176 * process.c (Faccept_process_output): Avoid compiler warnings when
1177 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1178
ca300656
JB
11792012-06-23 Juanma Barranquero <lekktu@gmail.com>
1180
049ec95b
JB
1181 * makefile.w32-in: Update dependencies.
1182
ca300656
JB
1183 * w32.c (ltime): Add return type and declare static.
1184 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1185
db7b8d06
PE
11862012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1189 Privately reported by Herbert J. Skuhra.
1190 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1191 All uses changed.
1192 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1193 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1194
0bd8297f
EZ
11952012-06-23 Eli Zaretskii <eliz@gnu.org>
1196
96512555
EZ
1197 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1198 last argument of make_unibyte_string.
1199
0bd8297f
EZ
1200 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1201 language ID in the event parameters.
1202
1203 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1204 event.code, not the obscure "character set ID".
1205
63def6b6
CY
12062012-06-23 Chong Yidong <cyd@gnu.org>
1207
1208 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1209
e8a02204
EZ
12102012-06-23 Eli Zaretskii <eliz@gnu.org>
1211
388cdec0
EZ
1212 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1213 * w32.c (fdutimens): New function.
1214
1215 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1216
1217 * s/ms-w32.h (pselect): Redirect to sys_select.
1218
1219 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1220
e8a02204
EZ
1221 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1222 in the logic of incrementing and decrementing the value of
1223 use_relocatable_buffers.
1224
d054f3fb
PE
12252012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1228 Privately reported by Herbert J. Skuhra.
1229 [__FreeBSD__]: Remove "*/" typo after "#include".
1230 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1231 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1232 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1233 Don't assume EMACS_TIME and struct timeval are the same type.
1234
d35af63c
PE
12352012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1236
1237 Support higher-resolution time stamps (Bug#9000).
1238 The time stamps are only nanosecond-resolution at the C level,
1239 since that's the best that any real-world system supports now.
1240 But they are picosecond-resolution at the Lisp level, as that's
1241 easy, and leaves room for future OS improvements.
1242
1243 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1244 (LIBES): Use it.
1245
1246 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1247 Don't get current time unless it's needed.
1248
1249 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1250 now provides it if it's absent.
1251 (start_atimer): Port to higher-res time stamps.
1252 Check for time stamp overflow. Don't get current time more
1253 often than is needed.
1254
1255 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1256 Include systime.h, not time.h.
1257 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1258
1259 * dired.c: Include stat-time.h.
1260 (Ffile-attributes): File times now have higher resolution.
1261
1262 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1263 (struct image): Timestamp now has higher resolution.
1264
1265 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1266 has at least microseconds now. All uses removed.
1267 (update_frame, update_single_window, update_window, update_frame_1)
1268 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1269
1270 * editfns.c (time_overflow): Now extern.
1271 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1272 (float-time, Fformat_time_string, Fcurrent_time_string)
1273 (Fcurrent_time_zone): Accept and generate higher-resolution
1274 time stamps.
1275 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1276 (decode_time_components, lisp_seconds_argument): New functions.
1277 (make_time): Now static.
1278 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1279 Report an error if the time is invalid, rather than having the caller
1280 do that.
1281
1282 * fileio.c: Include <stat-time.h>
1283 (Fcopy_file): Copy higher-resolution time stamps.
1284 Prefer to set the time stamp via a file descriptor if that works.
1285 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1286 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1287 (Fvisited_file_modtime, Fset_visited_file_modtime):
1288 Support higher-resolution time stamps.
1289
1290 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1291
1292 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1293
1294 * image.c (prepare_image_for_display, clear_image_cache)
1295 (lookup_image): Port to higer-resolution time stamps.
1296
1297 * keyboard.c (start_polling, bind_polling_period):
1298 Check for time stamp overflow.
1299 (read_char, kbd_buffer_get_event, timer_start_idle)
1300 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1301 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1302 Port to higher-resolution time stamps. Do not assume time_t is signed.
1303 (decode_timer): New function. Timers are now vectors of length 9,
1304 not 8, to accommodate the picosecond component.
1305 (timer_check_2): Use it.
1306
1307 * nsterm.m (select_timeout, timeval_subtract): Remove.
1308 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1309 as they're a bit more accurate and handle overflow better.
1310 (ns_select): Change prototype to be compatible with pselect.
1311 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1312 * nsterm.h (ns_select): Adjust prototype.
1313
1314 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1315 us-resolution time stamps.
1316 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1317
1318 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1319
1320 * lisp.h (time_overflow): New decl.
1321 (wait_reading_process_output): First arg is now intmax_t, not int,
1322 to accommodate larger waits.
1323
1324 * process.h (struct Lisp_Process.read_output_delay):
1325 Now counts nanoseconds, not microseconds.
1326 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1327 EMACS_HAS_USECS.
1328 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1329 (wait_reading_process_output):
1330 Port to ns-resolution time stamps.
1331 (Faccept_process_output, wait_reading_process_output):
1332 Check for time stamp overflow. Do not assume time_t is signed.
1333 (select_wrapper): Remove; we now use pselect.
1334 (Fprocess_attributes): Now generates ns-resolution time stamps.
1335
1336 * sysdep.c: Include utimens.h. Don't include utime.h
1337 or worry about struct utimbuf; gnulib does that for us now.
1338 (gettimeofday): Remove; gnulib provides a substitute.
1339 (make_timeval): New function.
1340 (set_file_times): Now sets ns-resolution time stamps.
1341 New arg FD; all uses changed.
1342 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1343 (system_process_attributes):
1344 Now returns ns-resolution time stamp. All uses changed.
1345 Check for time stamp overflow.
1346
1347 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1348 provides a substitute now.
1349
1350 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1351 since it guarantees struct timespec.
1352 (EMACS_TIME): Now struct timespec, so that we can support
1353 ns-resolution time stamps.
1354 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1355 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1356 (EMACS_USECS): Remove.
1357 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1358 so multiply the arg by 1000 before storing it.
1359 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1360 New macros.
1361 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1362 Port to ns-resolution time stamps.
1363 (EMACS_TIME_NEG_P): Remove; replaced by....
1364 (EMACS_TIME_SIGN): New macro.
1365 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1366 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1367 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1368 (make_timeval, make_lisp_time, decode_time_components): New decls.
1369 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1370 that it mishandled time_t overflow. You can't compare by subtracting!
1371 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1372 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1373
1374 * term.c: Include <sys/time.h>.
1375 (timeval_to_Time): New function, for proper overflow wraparound.
1376 (term_mouse_position, term_mouse_click): Use it.
1377
1378 * undo.c (record_first_change): Support higher-resolution time stamps
1379 in the undo buffer.
1380 (Fprimitive_undo): Use them when restoring time stamps.
1381
1382 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1383 (w32_get_internal_run_time):
1384 Port to higher-resolution Emacs time stamps.
1385 (ltime): Now accepts single 64-bit integer, as that's more convenient
1386 for callers.
1387
1388 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1389
1390 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1391 for compatibility with pselect. Support ns-resolution time stamps.
1392
1393 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1394
1395 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1396 Check for time stamp overflow, and support ns-resolution time stamps.
1397
1398 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1399 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1400 (timeval_subtract): Remove; no longer needed.
1401 (XTflash, XTring_bell, x_wait_for_event):
1402 Port to ns-resolution time stamps. Don't assume time_t is signed.
1403
b6a92dfe
CY
14042012-06-22 Chong Yidong <cyd@gnu.org>
1405
1406 * xdisp.c (x_consider_frame_title): Revert last change.
1407
d251c37c
EZ
14082012-06-22 Eli Zaretskii <eliz@gnu.org>
1409
1410 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1411 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1412 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1413 staticidx goes up to 1597 out of 1600 = 0x640.)
1414
f10deafb
PE
14152012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1416
1417 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1418 Otherwise, the umask might be mistakenly 0 while handling input signals.
1419
ec6de1e2
SM
14202012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1421
1422 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1423
28be1ada
DA
14242012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1425
1426 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1427 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1428 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1429 access to `contents' member of Lisp_Vector objects with AREF and ASET
1430 where appropriate.
1431
c6bf3022
CY
14322012-06-19 Chong Yidong <cyd@gnu.org>
1433
1434 * frame.c (delete_frame): When selecting a frame on a different
1435 text terminal, do not alter the terminal's top-frame.
1436
1437 * xdisp.c (format_mode_line_unwind_data): Record the target
1438 frame's selected window and its terminal's top-frame.
1439 (unwind_format_mode_line): Restore them.
1440 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1441 Callers changed.
1442 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1443 since tty frames can be explicitly named.
1444 (prepare_menu_bars): Likewise.
1445
1446 * term.c (Ftty_top_frame): New function.
1447
defd4196
PE
14482012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1449
1450 Port byte-code-meter to modern targets.
1451 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1452 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1453 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1454 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1455 (METER_1, METER_2): Simplify.
1456
1053a871
SM
14572012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1458
1459 * data.c (Fdefalias): Return `symbol' (bug#11686).
1460
b7e8d081
MR
14612012-06-18 Martin Rudalics <rudalics@gmx.at>
1462
1463 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1464 gets killed during executing of this function (Bug#11665).
1465 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1466 (Vkill_buffer_query_functions): In doc-string say that functions
1467 run by this hook should not change the current buffer.
1468
7ea2b339
PE
14692012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1470
1471 Fix recently-introduced process.c problems found by static checking.
1472 * process.c (write_queue_push, write_queue_pop, send_process):
1473 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1474 (write_queue_pop): Fix pointer signedness problem.
1475 (send_process): Remove unused local.
1476
96a313a1
CY
14772012-06-17 Chong Yidong <cyd@gnu.org>
1478
1479 * xdisp.c (redisplay_internal): No need to redisplay terminal
1480 frames that are not on top.
1481
20ca2e94
TN
14822012-06-17 Troels Nielsen <bn.troels@gmail.com>
1483
1484 * process.c (make_process): Initialize write_queue.
1485 (write_queue_push, write_queue_pop): New functions.
1486 (send_process): Use them to maintain correct ordering of process
1487 writes (Bug#10815).
1488
9a900ca9
PE
14892012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1490
310fbfa8
PE
1491 * lisp.h (eassert): Assume C89 or later.
1492 This removes the need for CHECK.
1493 (CHECK): Remove. Its comments about always evaluating its
1494 argument were confusing, as 'eassert' typically does not evaluate
1495 its argument.
1496
27bb1ca4
PE
1497 * coding.c (produce_chars): Use ptrdiff_t, not int.
1498
9a900ca9
PE
1499 * xterm.c (x_draw_underwave): Check for integer overflow.
1500 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1501
41b7f8bc 15022012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1503
1504 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1505 referenced (Bug#11583).
1506
9b0e3eba
AA
15072012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1508
1509 Implement wave-style variant of underlining.
1510 * dispextern.h (face_underline_type): New enum.
1511 (face): Add field for underline type.
1512 * nsterm.m (ns_draw_underwave): New function.
1513 (ns_draw_text_decoration): Use it.
1514 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1515 New functions.
1516 (x_draw_glyph_string): Use them.
1517 * xfaces.c (Qline, Qwave): New Lisp objects.
1518 (check_lface_attrs, merge_face_ref)
1053a871
SM
1519 (Finternal_set_lisp_face_attribute, realize_x_face):
1520 Handle wave-style underline face attributes.
9b0e3eba
AA
1521 * xterm.c (x_draw_underwave): New function.
1522 (x_draw_glyph_string): Use it.
1523
0fb52f11
JB
15242012-06-16 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1527 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1528 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1529 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1530 ($(BLD)/w32select.$(O)): Update dependencies.
1531
e5560ff7
AS
15322012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1533
1534 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1535 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1536 * character.c (_fetch_multibyte_char_p): Remove.
1537 * alloc.c: Include "character.h" before "buffer.h".
1538 * bidi.c: Likewise.
1539 * buffer.c: Likewise.
1540 * bytecode.c: Likewise.
1541 * callint.c: Likewise.
1542 * callproc.c: Likewise.
1543 * casefiddle.c: Likewise.
1544 * casetab.c: Likewise.
1545 * category.c: Likewise.
1546 * cmds.c: Likewise.
1547 * coding.c: Likewise.
1548 * composite.c: Likewise.
1549 * dired.c: Likewise.
1550 * dispnew.c: Likewise.
1551 * doc.c: Likewise.
1552 * dosfns.c: Likewise.
1553 * editfns.c: Likewise.
1554 * emacs.c: Likewise.
1555 * fileio.c: Likewise.
1556 * filelock.c: Likewise.
1557 * font.c: Likewise.
1558 * fontset.c: Likewise.
1559 * fringe.c: Likewise.
1560 * indent.c: Likewise.
1561 * insdel.c: Likewise.
1562 * intervals.c: Likewise.
1563 * keyboard.c: Likewise.
1564 * keymap.c: Likewise.
1565 * lread.c: Likewise.
1566 * macros.c: Likewise.
1567 * marker.c: Likewise.
1568 * minibuf.c: Likewise.
1569 * nsfns.m: Likewise.
1570 * nsmenu.m: Likewise.
1571 * print.c: Likewise.
1572 * process.c: Likewise.
1573 * regex.c: Likewise.
1574 * region-cache.c: Likewise.
1575 * search.c: Likewise.
1576 * syntax.c: Likewise.
1577 * term.c: Likewise.
1578 * textprop.c: Likewise.
1579 * undo.c: Likewise.
1580 * unexsol.c: Likewise.
1581 * w16select.c: Likewise.
1582 * w32fns.c: Likewise.
1583 * w32menu.c: Likewise.
1584 * window.c: Likewise.
1585 * xdisp.c: Likewise.
1586 * xfns.c: Likewise.
1587 * xmenu.c: Likewise.
1588 * xml.c: Likewise.
1589 * xselect.c: Likewise.
1590
2f07e6af
EZ
15912012-06-16 Eli Zaretskii <eliz@gnu.org>
1592
1053a871
SM
1593 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1594 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1595 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1596 row.
1597 (handle_face_prop): Use chunk-relative overlay string index when
1598 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1599 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1600 the rightmost. (Bug#11720)
2f07e6af 1601
29b83cec
AS
16022012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1603
1604 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1605 (CATEGORY_MEMBER): Enforce 1/0 value.
1606 * category.c (_temp_category_set): Remove.
1607
4c5501e9
EZ
16082012-06-16 Eli Zaretskii <eliz@gnu.org>
1609
1610 * window.c (Fdelete_other_windows_internal)
1611 (Fdelete_window_internal): Don't access frame's mouse highlight
1612 info of the initial frame. (Bug#11677)
1613
2b570124
PE
16142012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1615
e93864f9
PE
1616 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1617 Assume USE_2_TAGS_FOR_INTS.
1618 (xreload): Adjust $tagmask width to match recent lisp.h change.
1619
2b570124
PE
1620 Simplify lisp.h in minor ways that should not affect code.
1621 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1622 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1623 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1624 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1625 (INTTYPEBITS): New macro, for clarity.
1626 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1627 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1628 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1629 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1630 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1631
81755f69
JB
16322012-06-13 Juanma Barranquero <lekktu@gmail.com>
1633
1634 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1635
16192a57
GM
16362012-06-13 Glenn Morris <rgm@gnu.org>
1637
1638 * s/bsd-common.h (BSD4_3):
1639 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1640
646b5f55
AS
16412012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1642
1643 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1644 instead of union.
1645 (XLI, XIL): Define.
1053a871
SM
1646 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1647 Use them.
1648 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1649 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1650 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1651 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1652 * frame.c (delete_frame): Remove outdated comment.
1653 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1654 USE_LISP_UNION_TYPE.
1655 (Fw32_unregister_hot_key): Likewise.
1656 (Fw32_toggle_lock_key): Likewise.
1657 * w32menu.c (add_menu_item): Likewise.
1658 (w32_menu_display_help): Use XIL instead of checking
1659 USE_LISP_UNION_TYPE.
1660 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1661 (init_heap): Likewise.
1662 * w32term.c (w32_read_socket): Update comment.
1663
1d3823c9
GM
16642012-06-13 Glenn Morris <rgm@gnu.org>
1665
c62ff706
GM
1666 * s/usg5-4-common.h, src/s/unixware.h:
1667 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1668
1d3823c9
GM
1669 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1670
bfe3e0a2
PE
16712012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1674 * alloc.c (make_number) [!defined make_number]:
1675 Remove, as lisp.h always defines this now.
1676 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1677 (roundup_size): Verify that it is a power of 2.
1678 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1679 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1680 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1681 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1682 USE_LSB_TAG now is always defined to be either 0 or 1.
1683 All uses changed.
1684 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1685 code works fine either way, and efficiency is not a concern here,
1686 as the union type is for debugging, not for production.
1687 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1688 Use an inline function on all platforms when using the union type,
1689 since this is simpler and 'static inline' can be used portably
1690 within Emacs now.
1691 (LISP_INITIALLY_ZERO): New macro.
1692 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1693 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1694
45fa9c0f
GM
16952012-06-12 Glenn Morris <rgm@gnu.org>
1696
b4492cba
GM
1697 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1698
1699 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1700
45fa9c0f
GM
1701 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1702 Move BROKEN_SIGIO to configure.
1703
1704 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1705 Move NO_TERMIO to configure.
1706
0e25d334
CY
17072012-06-12 Chong Yidong <cyd@gnu.org>
1708
1709 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1710 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1711 MagickExportImagePixels is undefined.
1712
43682bb6
PE
17132012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 * image.c (imagemagick_load_image): Remove unused label.
1716
a9be7d2b
GM
17172012-06-11 Glenn Morris <rgm@gnu.org>
1718
1719 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1720 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1721 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1722 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1723
3017f87f
SM
17242012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1725
1726 * alloc.c (make_byte_code): New function.
1727 (Fmake_byte_code): Use it. Don't purify here.
1728 * lread.c (read1): Use it as well to avoid extra allocation.
1729
1b9b4cf4
CY
17302012-06-11 Chong Yidong <cyd@gnu.org>
1731
1732 * image.c (imagemagick_load_image): Implement transparency.
1733
95988fcf
AS
17342012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1735
1736 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1737 account for preceding backslashes. (Bug#11663)
1738
cd4eb164
CY
17392012-06-09 Chong Yidong <cyd@gnu.org>
1740
1741 * term.c: Support italics in capable terminals (Bug#9652).
1742 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1743 (turn_on_face): Output using TS_enter_italic_mode if available.
1744 Don't handle unused blinking and alt-charset cases.
1745 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1746 and tty_alt_charset_p cases.
1747 (tty_capable_p, init_tty): Support italics.
1748
1749 * termchar.h (struct tty_display_info): Add field for italics.
1750 Remove unused blink field.
1751
1752 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1753 Handle slant.
1754
1755 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1756 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1757 tty_alt_charset_p. Add tty_italic_p.
1758
ff88beb8
MA
17592012-06-09 Michael Albinus <michael.albinus@gmx.de>
1760
1761 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1762 dbus_type_is_basic if available.
1763 (xd_extract_signed, xd_extract_unsigned): Rename from
1764 extract_signed and extract_unsigned, respectively. Adapt callers.
1765
44286096
CY
17662012-06-09 Chong Yidong <cyd@gnu.org>
1767
1682701f
CY
1768 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1769
44286096
CY
1770 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1771 case (Bug#9752).
1772
d86feb17
PE
17732012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 * xdisp.c (vmessage): Treat frame message as multibyte.
1776 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1777 would generate the diagnostic "Making \302\247 buffer-local while
1778 let-bound!".
1779
d5c20fe8
EZ
17802012-06-08 Eli Zaretskii <eliz@gnu.org>
1781
1782 * dispnew.c (showing_window_margins_p): Undo last change, which
1783 was done due to an inadvertent commit.
1784 (adjust_frame_glyphs_for_frame_redisplay): Do call
1785 showing_window_margins_p.
1786
513749ee
SM
17872012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1788
1789 * eval.c (Fmake_var_non_special): New primitive.
1790 (syms_of_eval): Defsubr it.
1791 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1792
d4a8f5c1
JB
17932012-06-08 Juanma Barranquero <lekktu@gmail.com>
1794
1795 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1796 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1797
8bbbc977
EZ
17982012-06-08 Eli Zaretskii <eliz@gnu.org>
1799
1800 * alloc.c (allocate_vectorlike): Fix last change.
1801
f3372c87
DA
18022012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1803
1804 Block-based vector allocation of small vectors.
1805 * lisp.h (struct vectorlike_header): New field `nbytes',
1806 adjust comment accordingly.
1807 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1808 to denote vector blocks. Adjust users (live_vector_p,
1809 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1810 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1811 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1812 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1813 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1814 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1815 (roundup_size): New constant.
1816 (struct vector_block): New data type.
1817 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1818 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1819 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1820 (sweep_vectors): New functions.
1821 (allocate_vectorlike): Return `zero_vector' as the only vector of
1822 0 items. Allocate new vector from block if vector size is less than
1823 or equal to VBLOCK_BYTES_MAX.
1824 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1825 (init_alloc_once): Add call to init_vectors.
1826
4f18a4ed
SM
18272012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1828
1829 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1830
86f158bc
PE
18312012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1832
1833 * doprnt.c (doprnt): Truncate multibyte char correctly.
1834 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1835 would mishandle a string argument "Xc" if X was a multibyte
1836 character of length 2: it would truncate after X's first byte
1837 rather than including all of X.
1838
c5cfcbe0
CY
18392012-06-06 Chong Yidong <cyd@gnu.org>
1840
1841 * buffer.c (word_wrap): Doc fix.
1842
c05cf390
PE
18432012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1846
0c3461de
GM
18472012-06-03 Glenn Morris <rgm@gnu.org>
1848
1849 * xdisp.c (tool-bar-style): Doc fix.
1850
c71232db
UM
18512012-06-03 Ulrich Müller <ulm@gentoo.org>
1852
1853 * Makefile.in (PAXCTL): Define.
1854 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1855 binary via PaX flags if the paxctl utility is available.
1856 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1857 Restore PaX flags to their default. (Bug#11398)
1858
383f7350
CY
18592012-06-03 Chong Yidong <cyd@gnu.org>
1860
1861 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1862 buffer (Bug#11226).
1863
5f2c76c6
CY
18642012-06-03 Chong Yidong <cyd@gnu.org>
1865
1866 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1867 (note_mode_line_or_margin_highlight): If there is no help echo,
1868 use mode-line-default-help-echo. Handle the case where the mouse
1869 position is past the end of the mode line string.
1870
1871 * buffer.c (buffer_local_value_1): New function, split from
1872 Fbuffer_local_value; can return Qunbound.
1873 (Fbuffer_local_value): Use it.
1874 (Vmode_line_format): Docstring tweaks.
1875
773d47f6
PE
18762012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1877
1878 * sysdep.c (system_process_attributes): Improve comment.
1879
f2d6a3df
SM
18802012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1881
1882 * keyboard.c: Export real-this-command to Elisp.
1883 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1884 and DEFVAR it. Update all users.
1885
63810350
PE
18862012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1887
7bd5c1f4
PE
1888 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1889
63810350
PE
1890 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1891 Convert pctcpu and pctmem to Lisp float properly.
1892 Let the compiler fold better, as 100.0/0x8000 is exact.
1893
a2821611
AS
18942012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1895
1896 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1897 cons_block.
1898
5fceba1d
PE
18992012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1902
c98ff5dd
DA
19032012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1904
1905 For a 'struct window', replace some Lisp_Object fields to
1906 bitfields where appropriate, remove unused fields.
1907 * window.h (struct window): Remove unused 'last_mark_x' and
1908 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1909 change it's type from Lisp_Object to bitfield.
1910 Change type of 'force_start', 'optional_new_start',
1911 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1912 fields from Lisp_Object to bitfield. Adjust users accordingly.
1913
ca34e0be
PE
19142012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1915
1916 Pacify gcc -Wdouble-precision when using Xaw.
1917 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1918 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1919 Use 'float' consistently, rather than 'float' in most places
1920 and 'double' in a couple of places.
1921
efc00ab1 19222012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1923
1924 * xdisp.c (handle_stop): Detect whether we have overlay strings
1925 loaded by testing it->current.overlay_string_index to be
1926 non-negative, instead of checking whether n_overlay_strings is
1927 positive. (Bug#11587)
1928
efc00ab1 19292012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1930
1931 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1932
1933 * doc.c (Fsubstitute_command_keys): Doc fix.
1934
efc00ab1 19352012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1936
1937 * search.c (search_buffer): Remove calls to
1938 r_alloc_inhibit_buffer_relocation, as it is now called by
1939 maybe_unify_char, which was the cause of relocation of buffer text
1940 in bug#11519.
1941
efc00ab1 19422012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1943
1944 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1945 for the duration of call to load_charset, to avoid problems with
1946 callers of maybe_unify_char that access buffer text through C
1947 pointers.
1948
1949 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1950 decrement the inhibition flag, instead of just setting or
1951 resetting it.
1952
ba93a187
PE
19532012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1954
1955 Remove obsolete '#define static' cruft.
1956 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1957 This #undef was "temporary" in 2000; it is no longer needed
1958 now that '#define static' has gone away.
1959 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1960 (gray_bitmap_bits): Remove; no longer needed.
1961 All uses replaced with definiens.
1962 * xterm.c: Include "bitmaps/gray.xbm".
1963
9e4bf381
PE
19642012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 Clean up __executable_start, monstartup when --enable-profiling.
1967 The following changes affect the code only when profiling.
1968 * dispnew.c (__executable_start): Rename from safe_bcopy.
1969 Define only on platforms that need it.
1970 * emacs.c: Include <sys/gmon.h> when profiling.
1971 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1972 (__executable_start): Remove decl, since lisp.h does it now.
1973 (safe_bcopy): Remove decl; no longer has that name.
1974 (main): Coalesce #if into single bit of code, for simplicity.
1975 Cast pointers to uintptr_t, since standard libraries want integers
1976 and not pointers.
1977 * lisp.h (__executable_start): New decl.
1978
32d72c2f
GM
19792012-05-31 Glenn Morris <rgm@gnu.org>
1980
1981 * image.c (Fimagemagick_types): Doc fix.
1982
baac5bc7
JM
19832012-05-30 Jim Meyering <meyering@redhat.com>
1984
1985 * callproc.c (Fcall_process_region): Include directory component
1986 in mkstemp error message (Bug#11586).
1987
72cb32cf
PE
19882012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1989
1990 * alloc.c, lisp.h (make_pure_vector): Now static.
1991
61b108cc
SM
19922012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1993
1994 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1995 Move to byte-run.el.
1996 (Fautoload): Do the hash-doc more carefully.
1997 * data.c (Fdefalias): Purify definition, except for keymaps.
1998 (Qdefun): Move from eval.c.
1999 * lisp.h (Qdefun): Remove.
2000 * lread.c (read1): Tiny simplification.
2001
471fe23d
TN
20022012-05-29 Troels Nielsen <bn.troels@gmail.com>
2003
934f3f58 2004 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2005 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2006 Bug#9642, but explicitly check that the buffer the overlay would
2007 be moved to is live and rearrange lines to make sure that errors
2008 will not put the overlay in an inconsistent state.
2009 (Fdelete_overlay): Cosmetics.
2010
85d0efd1
EZ
20112012-05-28 Eli Zaretskii <eliz@gnu.org>
2012
2013 * w32term.c (my_bring_window_to_top): New function.
2014 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2015 could be different from the original one.
2016 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2017 (Bug#11513)
2018
2019 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2020 by calling BringWindowToTop.
2021
2022 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2023 (WM_EMACS_END): Increase by one.
2024
da92a98c
PE
20252012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2028 This avoids undefined behavior that might cause the eassert
2029 to not catch an out-of-range value.
2030
74d1f848
JB
20312012-05-28 Juanma Barranquero <lekktu@gmail.com>
2032
2033 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2034 Update dependencies.
2035
9e1a06fc
EZ
20362012-05-27 Eli Zaretskii <eliz@gnu.org>
2037
2038 * bidi.c (bidi_mirror_char): Fix last change.
2039
f3dd7312
AS
20402012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2041
2042 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2043 when referring to sectname field in printf format.
2044
81899c91
PE
20452012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2046
57b81a9f
PE
2047 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2048 Only r_alloc_inhibit_buffer_relocation needed to be added;
2049 the others were already declared.
2050
81899c91
PE
2051 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2052 before checking whether it's out of range. Put the check inside
2053 eassert. See
2054 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2055
33017faf 20562012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2057
2058 * callproc.c (Fcall_process): Restore a line that was accidentally
2059 commented out in the 2011-02-13 change (bug#11547).
2060
33017faf 20612012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2062
2063 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2064 defined on ralloc.c.
2065
2066 * buffer.c [REL_ALLOC]: Remove prototypes of
2067 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2068 they are now on lisp.h.
2069
2070 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2071
2072 * search.c (search_buffer): Use it to inhibit relocation of buffer
2073 text while re_search_2 is doing its job, because re_search_2 is
2074 passed C pointers to buffer text. (Bug#11519)
2075
23415acf
EZ
2076 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2077 Update value to 24.
2078
44e27368
EZ
2079 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2080 state after an additional call to move_it_in_display_line_to, keep
2081 the values of it->max_ascent and it->max_descent found for the
2082 entire line.
2083 (pos_visible_p): Revert the comparison against bottom_y to what it
2084 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2085 (Bug#11464)
2086
c1892f11
PE
20872012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2088
2089 Fix coding-related core dumps with gcc -ftrapv.
2090 The code was computing A - B, where A and B are pointers, and B is
2091 random garbage. This can lead to core dumps on platforms that
2092 have special pointer registers, and it also leads to core dumps on
2093 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2094 A - B only when B is initialized properly.
2095 * coding.c (coding_set_source, coding_set_destination): Return void.
2096 (coding_change_source, coding_change_destinations): New functions,
2097 with the old behaviors of coding_set_source and coding_set_destination.
2098 All callers that need an offset changed to use these new functions.
2099
eb7afdad
GM
21002012-05-26 Glenn Morris <rgm@gnu.org>
2101
2102 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2103
f12fdf02
EZ
21042012-05-26 Eli Zaretskii <eliz@gnu.org>
2105
53a63be6 2106 Extend mouse support on W32 text-mode console.
61b108cc
SM
2107 * xdisp.c (draw_row_with_mouse_face):
2108 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2109
eb3f6f01 2110 * w32console.c: Include window.h.
61b108cc
SM
2111 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2112 New functions.
eb3f6f01
EZ
2113 (initialize_w32_display): Initialize mouse-highlight data.
2114
53a63be6
EZ
2115 * w32inevt.c: Include termchar.h and window.h.
2116 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2117 moves, call note_mouse_highlight. If help_echo changed, call
2118 gen_help_event to produce help-echo message in the echo area.
2119 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2120 highlight info.
2121
4cfd81f6
PE
21222012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 * lread.c (read1): Simplify slightly to avoid an overflow warning
2125 with GCC 4.7.0 on x86-64.
2126
4446092a
EZ
21272012-05-26 Eli Zaretskii <eliz@gnu.org>
2128
2129 * bidi.c (bidi_mirror_char): Revert last change: an int is
2130 definitely wide enough here.
2131
42b2a986 21322012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2133
42b2a986 2134 Fix integer width and related bugs (Bug#9874).
eb106a49 2135 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2136 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2137 (string_bytes, check_sblock, allocate_string_data):
2138 (compact_small_strings, Fmake_bool_vector, make_string)
2139 (make_unibyte_string, make_multibyte_string)
2140 (make_string_from_bytes, make_specified_string)
2141 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2142 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2143 (mark_vectorlike):
2144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2145 (allocate_pseudovector):
2146 Use int, not EMACS_INT, where int is wide enough.
2147 (inhibit_garbage_collection, Fgarbage_collect):
2148 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2149 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2150 int might not be wide enough.
2151 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2152 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2153 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2154 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2155 (bidi_level_of_next_char, bidi_move_to_visually_next):
2156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2157 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2158 (Fkill_buffer, Fset_buffer_major_mode)
2159 (advance_to_char_boundary, Fbuffer_swap_text)
2160 (Fset_buffer_multibyte, overlays_at, overlays_in)
2161 (overlay_touches_p, struct sortvec, record_overlay_string)
2162 (overlay_strings, recenter_overlay_lists)
2163 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2164 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2165 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2166 (Foverlay_recenter, last_overlay_modification_hooks_used)
2167 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2169 (validate_region): Omit unnecessary test for b <= e,
2170 since that's guaranteed by the previous test.
d311d28c
PE
2171 (adjust_overlays_for_delete): Avoid pos + length overflow.
2172 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2173 (report_overlay_modification):
2174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2175 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2176 Omit pointer cast, which isn't needed anyway, and doesn't work
2177 after the EMACS_INT -> ptrdiff_t change.
02481186 2178 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2179 * buffer.h: Adjust decls to match defn changes elsewhere.
2180 (struct buffer_text, struct buffer):
2181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2182 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2183 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2184 not int, to avoid needless 32-bit limit on 64-bit hosts.
2185 (exec_byte_code): Use tighter memory-full test, one that checks
2186 for alloca overflow. Don't compute the address of the object just
2187 before an array, as that's not portable. Use EMACS_INT, not
2188 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2189 * callint.c (Fcall_interactively):
2190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2191 * callproc.c (call_process_kill, Fcall_process):
2192 Don't assume pid_t fits into an Emacs fixnum.
2193 (call_process_cleanup, Fcall_process, child_setup):
2194 Don't assume pid_t fits into int.
2195 (call_process_cleanup, Fcall_process, delete_temp_file)
2196 (Fcall_process_region):
2197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2198 (Fcall_process): Simplify handling of volatile integers.
2199 Use int, not EMACS_INT, where int will do.
2200 * casefiddle.c (casify_object, casify_region, operate_on_word)
2201 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2203 (casify_object): Avoid integer overflow when overallocating buffer.
2204 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2205 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2206 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2207 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2208 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2209 integers are now checked earlier. All uses replaced with XINT.
2210 (ccl_driver):
2211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2212 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2213 (ccl_driver, Fregister_code_conversion_map):
2214 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2215 (resolve_symbol_ccl_program): Check that vector header is in range.
2216 Always copy the vector, so that we can check its contents reliably
2217 now rather than having to recheck each instruction as it's being
2218 executed. Check that vector words fit in 'int'.
2219 (ccl_get_compiled_code, Fregister_ccl_program)
2220 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2221 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2222 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2223 contents are in range.
2224 (Fccl_execute_on_string): Check that status is in range.
2225 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2226 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2227 Accept and return EMACS_INT, not int, because callers can pass values
2228 out of 'int' range.
2229 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2230 (multibyte_chars_in_text, parse_str_as_multibyte)
2231 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2232 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2233 (string_escape_byte8, Fget_byte):
2234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2235 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2236 avoid mishandling large integers.
2237 * character.h: Adjust decls to match defn changes elsewhere.
2238 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2239 (Ffind_charset_region):
2240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2241 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2242 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2243 Don't assume fixnum fits in int.
d311d28c
PE
2244 (load_charset_map_from_vector, Fmap_charset_chars):
2245 Remove now-unnecessary CHECK_NATNUMs.
2246 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2247 Don't rely on undefined behavior with signed left shift overflow.
2248 Don't assume unsigned int fits into fixnum, or that fixnum fits
2249 into unsigned int. Don't require max_code to be a valid fixnum;
2250 that's not true for gb10830 4-byte on a 32-bit host. Allow
2251 invalid_code to be a cons, for the same reason. Require code_offset
2252 to be a character. Avoid int overflow if max_char is close
2253 to INT_MAX.
2254 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2255 this is intended anyway and avoids some undefined behavior.
2256 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2257 INDEX_TO_CODE_POINT, as that's what it expects.
2258 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2259 * charset.h (DECODE_CHAR): Return int, not unsigned;
2260 this is what was intended anyway, and it avoids undefined behavior.
2261 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2262 integer-overflow issues.
2263 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2264 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2265 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2266 * chartab.c (Fmake_char_table, Fset_char_table_range)
2267 (uniprop_get_decoder, uniprop_get_encoder):
2268 Don't assume fixnum fits in int.
2269 * cmds.c (move_point): New function, that does the gist of
2270 Fforward_char and Fbackward_char, but does so while checking
2271 for integer overflow more accurately.
c96e5d6a 2272 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2273 (Fforward_line, Fend_of_line, internal_self_insert)
2274 (internal_self_insert):
2275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2276 Fix a FIXME, by checking for integer overflow when calculating
2277 target_clm and actual_clm.
2278 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2279 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2280 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2281 (coding_alloc_by_making_gap, alloc_destination)
2282 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2283 (encode_coding_utf_16, detect_coding_emacs_mule)
2284 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2285 (detect_coding_iso_2022, decode_coding_iso_2022)
2286 (encode_invocation_designation, encode_designation_at_bol)
2287 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2288 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2289 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2290 (encode_coding_ccl, encode_coding_raw_text)
2291 (detect_coding_charset, decode_coding_charset)
2292 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2293 (produce_composition, produce_charset, produce_annotation)
2294 (decode_coding, handle_composition_annotation)
2295 (handle_charset_annotation, consume_chars, decode_coding_gap)
2296 (decode_coding_object, encode_coding_object, detect_coding_system)
2297 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2298 (code_convert_region, code_convert_string)
8f50130c
PE
2299 (Fdefine_coding_system_internal)
2300 (coding_set_source, coding_set_destination):
d311d28c
PE
2301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2302 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2303 (Fdefine_coding_system_internal):
2304 Don't assume fixnums fit in int.
2305 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2306 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2307 (Funencodable_char_position, Fcheck_coding_systems_region)
2308 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2310 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2311 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2312 Don't access memory outside of the args array.
d311d28c 2313 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2314 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2315 result of ENCODE_CHAR.
d311d28c
PE
2316 * coding.h: Adjust decls to match defn changes elsewhere.
2317 (struct coding_system):
2318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2319 * composite.c (get_composition_id, find_composition)
2320 (run_composition_function, update_compositions)
2321 (compose_text, composition_gstring_put_cache)
2322 (composition_gstring_p, composition_gstring_width)
2323 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2324 (composition_compute_stop_pos, composition_reseat_it)
2325 (composition_update_it, struct position_record)
2326 (find_automatic_composition, composition_adjust_point)
2327 (Fcomposition_get_gstring, Ffind_composition_internal):
2328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2329 (update_compositions):
2330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2331 * composite.h: Adjust decls to match defn changes elsewhere.
2332 (struct composition):
2333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2334 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2335 Do not attempt to compute the address of the object just before a
2336 buffer; this is not portable.
2337 (Faref, Faset):
2338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2339 (Faset): Use int, not EMACS_INT, where int is wide enough.
2340 (Fstring_to_number): Don't assume fixnums fit in int.
2341 (Frem): Don't assume arg is nonnegative.
2342 * dbusbind.c (xd_append_arg): Check for integers out of range.
2343 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2344 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2345 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2346 (xd_get_connection_references): Return ptrdiff_t, not int.
2347 All uses changed.
2348 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2349 (xd_read_message_1):
2350 Use int, not unsigned, where the dbus API uses int.
2351 (Fdbus_message_internal): Don't overflow mtype.
2352 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2353 * dired.c (directory_files_internal, file_name_completion, scmp)
2354 (file_name_completion_stat):
2355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2356 (file_name_completion): Don't overflow matchcount.
2357 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2358 * dispextern.h: Adjust decls to match defn changes elsewhere.
2359 (struct text_pos, struct glyph, struct bidi_saved_info)
2360 (struct bidi_string_data, struct bidi_it, struct composition_it)
2361 (struct it):
2362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2363 (struct display_pos, struct composition_it, struct it):
2364 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2365 * dispnew.c (increment_matrix_positions)
2366 (increment_row_positions, mode_line_string)
2367 (marginal_area_string):
2368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2369 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2371 (duration_to_sec_usec): New function, to check for overflow better.
2372 (Fsleep_for, sit_for): Use it.
2373 * doc.c (get_doc_string, store_function_docstring):
2374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2375 (get_doc_string, Fsnarf_documentation):
2376 Use int, not EMACS_INT, where int is wide enough.
2377 (get_doc_string):
2378 Use SAFE_ALLOCA, not alloca.
2379 Check for overflow when converting EMACS_INT to off_t.
2380 * doprnt.c (doprnt):
2381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2382 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2383 Don't assume uid_t fits into fixnum.
2384 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2385 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2386 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2387 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2388 (general_insert_function)
2389 (Finsert_char, make_buffer_string, make_buffer_string_both)
2390 (update_buffer_properties, Fbuffer_substring)
2391 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2392 (Fsubst_char_in_region, check_translation)
2393 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2394 (transpose_markers, Ftranspose_regions):
2395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2396 (clip_to_bounds): Move to lisp.h as an inline function).
2397 (Fconstrain_to_field): Don't assume integers are nonnegative.
2398 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2399 (Fsubst_char_in_region, Fsave_restriction):
2400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2401 (Femacs_pid): Don't assume pid_t fits into fixnum.
2402 (lo_time): Use int, not EMACS_INT, when int suffices.
2403 (lisp_time_argument): Check for usec out of range.
2404 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2405 (Fuser_login_name, Fuser_full_name): Signal an error
2406 if a uid argument is out of range, rather than relying on
2407 undefined behavior.
c8d5c857
PE
2408 (Fformat_time_string): Remove now-unnecessary check.
2409 lisp_time_argument checks for out-of-range usec now.
243e0530 2410 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2411 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2412 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2413 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2414 (init_cmdargs, Fdump_emacs):
2415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2416 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2417 the bottom (typically) 32 bits of the fixnum.
2418 * eval.c (specpdl_size, call_debugger):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2420 (when_entered_debugger, Fbacktrace_debug):
2421 Don't assume fixnum can fit in int.
2422 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2423 the object just before a buffer; this is not portable.
2424 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2425 (grow_specpdl, unbind_to):
2426 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2427 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2428 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2429 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2430 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2431 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2433 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2434 (a_write, e_write):
2435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2436 (Fcopy_file, non_regular_nbytes, read_non_regular)
2437 (Finsert_file_contents):
2438 Use int, not EMACS_INT, where int is wide enough.
2439 (READ_BUF_SIZE): Verify that it fits in int.
2440 (Finsert_file_contents): Check that counts are in proper range,
2441 rather than assuming fixnums fit into ptrdiff_t etc.
2442 Don't assume fixnums fit into int.
125b3835 2443 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2444 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2445 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2446 (string_char_to_byte, string_byte_to_char)
2447 (string_make_multibyte, string_to_multibyte)
2448 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2449 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2450 (substring_both, Fdelete, internal_equal, Ffillarray)
2451 (Fclear_string, mapcar1)
2452 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2453 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2454 (larger_vector, make_hash_table, maybe_resize_hash_table)
2455 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2456 (Fmaphash, secure_hash):
2457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2458 (concat): Check for string index and length overflow.
2459 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2460 (Frequire):
2461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2462 (larger_vector): New API (vec, incr_min, size_max) replaces old
2463 one (vec, new_size, init). This catches size overflow.
2464 INIT was removed because it was always Qnil.
2465 All callers changed.
2466 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2467 the upper bound on a hash table index size.
2468 (make_hash_table, maybe_resize_hash_table): Use it.
2469 (secure_hash): Computer start_byte and end_byte only after
2470 they're known to be in ptrdiff_t range.
2471 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2472 (Ffont_get_glyphs, Ffont_at):
2473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2474 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2475 (Flist_fonts, Fopen_font):
2476 Don't assume fixnum can fit in int.
2477 (check_gstring): Don't assume index can fit in int.
2478 (font_match_p): Check that fixnum is a character, not a nonnegative
2479 fixnum, since the later code needs to stuff it into an int.
2480 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2481 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2482 conversion overflow issues.
2483 (Fopen_font): Check for integer out of range.
2484 (Ffont_get_glyphs): Don't assume index can fit in int.
2485 * font.h: Adjust decls to match defn changes elsewhere.
2486 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2487 integer overflow.
2488 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2489 printmax_t, where ptrdiff_t is wide enough.
2490 (Finternal_char_font):
2491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2492 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2493 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2494 (Fset_frame_position, x_set_frame_parameters)
2495 (x_set_line_spacing, x_set_border_width)
2496 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2497 Check that fixnums are in proper range for system types.
2498 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2500 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2501 Use SAFE_ALLOCA_LISP, not alloca.
2502 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2503 intptr_t is wide enough.
2504 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2505 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2506 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2507 Check for fixnum out of range.
2508 * ftfont.c (ftfont_list): Don't assume index fits in int.
2509 Check that fixnums are in proper range for system types.
2510 (ftfont_shape_by_flt):
2511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2512 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2514 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2515 Check that fixnums are in proper range for system types.
2516 * gnutls.h: Adjust decls to match defn changes elsewhere.
2517 * gtkutil.c (xg_dialog_run):
2518 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2519 (update_frame_tool_bar):
2520 Check that fixnums are in proper range for system types.
2521 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2522 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2523 * indent.c (last_known_column, last_known_column_point):
2524 (current_column_bol_cache):
2525 (skip_invisible, current_column, check_display_width):
2526 (check_display_width, scan_for_column, current_column_1)
2527 (Findent_to, Fcurrent_indentation, position_indentation)
2528 (indented_beyond_p, Fmove_to_column, compute_motion):
2529 (Fcompute_motion, Fvertical_motion):
2530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2531 (last_known_column_modified): Use EMACS_INT, not int.
2532 (check_display_width):
2533 (Fcompute_motion):
2534 Check that fixnums and floats are in proper range for system types.
2535 (compute_motion): Don't assume index or fixnum fits in int.
2536 (compute_motion, Fcompute_motion):
2537 Use int, not EMACS_INT, when it is wide enough.
2538 (vmotion): Omit local var start_hpos that is always 0; that way
2539 we don't need to worry about overflow in expressions involving it.
2540 * indent.h: Adjust decls to match defn changes elsewhere.
2541 (struct position):
2542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2543 Use int, not EMACS_INT, where int is wide enough.
2544 Remove unused members ovstring_chars_done and tab_offset;
2545 all uses removed.
2546 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2547 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2548 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2549 (make_gap, copy_text, insert, insert_and_inherit)
2550 (insert_before_markers, insert_before_markers_and_inherit)
2551 (insert_1, count_combining_before, count_combining_after)
2552 (insert_1_both, insert_from_string)
2553 (insert_from_string_before_markers, insert_from_string_1)
2554 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2555 (adjust_after_replace, adjust_after_insert, replace_range)
2556 (replace_range_2, del_range, del_range_1, del_range_byte)
2557 (del_range_both, del_range_2, modify_region)
2558 (prepare_to_modify_buffer, signal_before_change)
2559 (signal_after_change, Fcombine_after_change_execute):
2560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2561 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2562 (balance_an_interval, split_interval_right, split_interval_left)
2563 (find_interval, next_interval, update_interval)
2564 (adjust_intervals_for_insertion, delete_node, delete_interval)
2565 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2566 (static_offset_intervals, offset_intervals)
2567 (merge_interval_right, merge_interval_left, make_new_interval)
2568 (graft_intervals_into_buffer, temp_set_point_both)
2569 (temp_set_point, set_point, adjust_for_invis_intang)
2570 (set_point_both, move_if_not_intangible, get_property_and_range)
2571 (get_local_map, copy_intervals, copy_intervals_to_string)
2572 (compare_string_intervals, set_intervals_multibyte_1):
2573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2574 * intervals.h: Adjust decls to match defn changes elsewhere.
2575 (struct interval):
2576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2577 * keyboard.c (this_command_key_count, this_single_command_key_start)
2578 (before_command_key_count, before_command_echo_length, echo_now)
2579 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2580 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2581 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2582 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2584 (last_non_minibuf_size, last_point_position, echo_truncate)
2585 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2586 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2587 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2588 (stuff_buffered_input):
2589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2590 (last_auto_save, command_loop_1, read_char):
2591 Use EMACS_INT, not int, to avoid integer overflow.
2592 (record_char): Avoid overflow in total_keys computation.
2593 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2594 * keyboard.h: Adjust decls to match defn changes elsewhere.
2595 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2596 (Fkey_description, Fdescribe_vector, Flookup_key):
2597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2598 (click_position): New function, to check that positions are in range.
2599 (Fcurrent_active_maps):
2600 (describe_command):
2601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2602 (Faccessible_keymaps, Fkey_description):
2603 (preferred_sequence_p):
2604 Don't assume fixnum can fit into int.
2605 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2606 Check for integer overflow in size calculations.
2607 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2608 avoid mishandling large integers.
2609 * lisp.h: Adjust decls to match defn changes elsewhere.
2610 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2611 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2612 (struct Lisp_Marker):
2613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2614 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2615 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2616 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2617 All callers changed.
2618 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2619 Assume the arg has valid form, since it always does.
2620 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2621 unsigned integer system type.
2622 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2623 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2625 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2626 (duration_to_sec_usec): New decl.
2627 * lread.c (read_from_string_index, read_from_string_index_byte)
2628 (read_from_string_limit, readchar, unreadchar, openp)
2629 (read_internal_start, read1, oblookup):
2630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2631 (Fload, readevalloop, Feval_buffer, Feval_region):
2632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2633 (openp): Check for out-of-range argument to 'access'.
2634 (read1): Use int, not EMACS_INT, where int is wide enough.
2635 Don't assume fixnum fits into int.
6efdadfd 2636 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2637 (read_filtered_event): Use duration_to_sec_usec
2638 to do proper overflow checking on durations.
d311d28c
PE
2639 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2640 in size calculation.
2641 (Fexecute_kbd_macro):
2642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2643 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2644 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2645 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2646 (set_marker_both, set_marker_restricted_both, marker_position)
2647 (marker_byte_position, Fbuffer_has_markers_at):
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2650 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2651 It now merely ensures that the menu is large enough, without
2652 necessarily growing it, as this avoids some integer overflow issues.
2653 All callers changed.
2654 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2656 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2657 Use SAFE_ALLOCA_LISP, not alloca.
2658 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2659 to EMACS_INT. Check that fixnums are in proper range for system types.
2660 * minibuf.c (minibuf_prompt_width, string_to_object)
2661 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2662 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2664 (get_minibuffer, read_minibuf_unwind):
2665 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2666 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2667 this simplifies overflow checking. All callers changed.
2668 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2669 (Ftest_completion):
2670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2671 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2672 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2673 Check that fixnums are in proper range for system types.
2674 (Fx_create_frame, Fx_show_tip):
2675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2676 * nsfont.m (ns_findfonts, nsfont_list_family):
2677 Don't assume fixnum fits in long.
2678 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2680 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2681 wide enough.
17fdb222 2682 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2684 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2685 (PRINTDECLARE, PRINTPREPARE):
2686 (strout, print_string):
2687 (print, print_preprocess, print_check_string_charset_prop)
2688 (print_object):
2689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2690 (PRINTDECLARE):
2691 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2693 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2694 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2695 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2696 (print_error_message): Use SAFE_ALLOCA, not alloca.
2697 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2698 (print_depth, new_backquote_output, print_number_index):
2699 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2700 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2701 (Fset_process_window_size, Fformat_network_address)
2702 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2703 (sigchld_handler):
d311d28c 2704 Check that fixnums are in proper range for system types.
d44287d4 2705 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2706 Check for process-ids out of pid_t range rather than relying on
2707 undefined behavior.
e4d81efc 2708 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2709 (Fformat_network_address, read_process_output, send_process)
2710 (Fprocess_send_region, status_notify):
2711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2712 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2713 (wait_reading_process_output, read_process_output, exec_sentinel):
2714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2715 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2716 (Faccept_process_output): Use duration_to_sec_usec to do proper
2717 overflow checking on durations.
dde14581
PE
2718 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2719 Don't assume pid_t fits in int.
02481186
PE
2720 * process.h (struct Lisp_Process): Members tick and update_tick
2721 are now of type EMACS_INT, not int.
b62b53e8
PE
2722 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2723 configured --with-wide-int.
d311d28c
PE
2724 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2725 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2726 * search.c (looking_at_1, string_match_1):
2727 (fast_string_match, fast_c_string_match_ignore_case)
2728 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2729 (scan_newline, find_before_next_newline, search_command)
2730 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2731 (set_search_regs, wordify):
2732 (Freplace_match):
2733 (Fmatch_data):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (string_match_1, search_buffer, set_search_regs):
2736 (Fmatch_data):
2737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2738 (wordify): Check for overflow in size calculation.
2739 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2740 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2741 Check that fixnums are in proper range for system types.
2742 * sound.c (struct sound_device)
2743 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2745 (Fplay_sound_internal):
2746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2747 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2748 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2749 (Fparse_partial_sexp):
2750 Don't assume fixnums can fit in int.
2751 (struct lisp_parse_state, find_start_pos, find_start_value)
2752 (find_start_value_byte, find_start_begv)
2753 (update_syntax_table, char_quoted, dec_bytepos)
2754 (find_defun_start, prev_char_comend_first, back_comment):
2755 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2756 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2758 (Finternal_describe_syntax_value): Check that match_lisp is a
2759 character, not an integer, since the code stuffs it into int.
2760 (scan_words, scan_sexps_forward):
2761 Check that fixnums are in proper range for system types.
2762 (Fforward_word):
2763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2764 (scan_sexps_forward):
2765 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2766 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2767 * syntax.h: Adjust decls to match defn changes elsewhere.
2768 (struct gl_state_s):
2769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2770 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2771 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2772 * sysdep.c (wait_for_termination_1, wait_for_termination)
2773 (interruptible_wait_for_termination, mkdir):
2774 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2775 (emacs_read, emacs_write):
2776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2777 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2778 and double all fit in int.
d311d28c
PE
2779 * term.c (set_tty_color_mode):
2780 Check that fixnums are in proper range for system types.
2781 * termhooks.h (struct input_event):
2782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2783 * textprop.c (validate_interval_range, interval_of)
2784 (Fadd_text_properties, set_text_properties_1)
2785 (Fremove_text_properties, Fremove_list_of_text_properties)
2786 (Ftext_property_any, Ftext_property_not_all)
2787 (copy_text_properties, text_property_list, extend_property_ranges)
2788 (verify_interval_modification):
2789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2790 (Fnext_single_char_property_change)
2791 (Fprevious_single_char_property_change):
2792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2793 (copy_text_properties):
2794 Check for integer overflow in index calculation.
d311d28c
PE
2795 * undo.c (last_boundary_position, record_point, record_insert)
2796 (record_delete, record_marker_adjustment, record_change)
2797 (record_property_change):
2798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2799 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2801 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2802 (Fx_hide_tip, Fx_file_dialog):
2803 * w32menu.c (set_frame_menubar):
2804 Use ptrdiff_t, not int, for consistency with rest of code.
2805 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2806 (select_window, Fdelete_other_windows_internal)
2807 (window_scroll_pixel_based, window_scroll_line_based)
2808 (Frecenter, Fset_window_configuration):
2809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2810 (Fset_window_hscroll, run_window_configuration_change_hook)
2811 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2812 (Fscroll_other_window, Frecenter):
d311d28c
PE
2813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2814 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2815 Don't assume fixnum fits in int.
2816 (Fset_window_scroll_bars):
2817 Check that fixnums are in proper range for system types.
2818 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2819 (string_pos, c_string_pos, number_of_chars, init_iterator)
2820 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2821 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2822 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2823 (face_before_or_after_it_pos, handle_invisible_prop)
2824 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2825 (display_prop_intangible_p, string_buffer_position_lim)
2826 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2827 (get_overlay_strings_1, get_overlay_strings)
2828 (iterate_out_of_display_property, forward_to_next_line_start)
2829 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2830 (get_next_display_element, set_iterator_to_next)
2831 (get_visually_first_element, compute_stop_pos_backwards)
2832 (handle_stop_backwards, next_element_from_buffer)
2833 (move_it_in_display_line_to, move_it_in_display_line)
2834 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2835 (add_to_log, message_dolog, message_log_check_duplicate)
2836 (message2, message2_nolog, message3, message3_nolog
2837 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2838 (current_message_1, truncate_echo_area, truncate_message_1)
2839 (set_message, set_message_1, store_mode_line_noprop)
2840 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2841 (text_outside_line_unchanged_p, check_point_in_composition)
2842 (reconsider_clip_changes)
2843 (redisplay_internal, set_cursor_from_row, try_scrolling)
2844 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2845 (redisplay_window, find_last_unchanged_at_beg_row)
2846 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2847 (trailing_whitespace_p, find_row_edges, display_line)
2848 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2849 (display_mode_element, store_mode_line_string)
2850 (pint2str, pint2hrstr, decode_mode_spec)
2851 (display_count_lines, display_string, draw_glyphs)
2852 (x_produce_glyphs, x_insert_glyphs)
2853 (rows_from_pos_range, mouse_face_from_buffer_pos)
2854 (fast_find_string_pos, mouse_face_from_string_pos)
2855 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2857 (safe_call, init_from_display_pos, handle_fontified_prop)
2858 (handle_single_display_spec, load_overlay_strings)
2859 (with_echo_area_buffer, setup_echo_area_for_printing)
2860 (display_echo_area, echo_area_display)
2861 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2862 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2863 (redisplay_window, dump_glyph_row, display_mode_line)
2864 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2865 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2867 (handle_single_display_spec, build_desired_tool_bar_string)
2868 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2869 (get_specified_cursor_type):
2870 Check that fixnums are in proper range for system types.
2871 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2872 (Flookup_image_map):
2873 Don't assume fixnums fit in int.
2874 (compare_overlay_entries):
2875 Avoid mishandling comparisons due to subtraction overflow.
2876 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2877 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2878 (handle_tool_bar_click):
2879 Use int, not unsigned, since we prefer signed and the signedness
2880 doesn't matter here.
2881 (get_next_display_element, next_element_from_display_vector):
2882 Use int, not EMACS_INT, when int is wide enough.
2883 (start_hourglass): Use duration_to_sec_usec to do proper
2884 overflow checking on durations.
2885 * xfaces.c (Fbitmap_spec_p):
2886 Check that fixnums are in proper range for system types.
2887 (compare_fonts_by_sort_order):
2888 Avoid mishandling comparisons due to subtraction overflow.
2889 (Fx_family_fonts, realize_basic_faces):
2890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2891 (Fx_family_fonts):
2892 Don't assume fixnum fits in int.
2893 Use SAFE_ALLOCA_LISP, not alloca.
2894 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2895 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2896 (face_at_buffer_position, face_for_overlay_string)
2897 (face_at_string_position):
2898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2899 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2900 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2901 (Fx_show_tip):
2902 Check that fixnums are in proper range for system types.
2903 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2904 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2906 (Fx_change_window_property): Don't assume fixnums fit in int.
2907 * xfont.c (xfont_chars_supported):
2908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2909 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2910 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2912 * xml.c (parse_region):
2913 * xrdb.c (magic_file_p):
2914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2915 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2916 (x_get_local_selection, x_reply_selection_request)
2917 (x_handle_selection_request, wait_for_property_change):
2918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2919 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2920 short is wide enough.
2921 (x_send_client_event): Don't assume fixnum fits in int.
2922 * xterm.c (x_x_to_emacs_modifiers):
2923 Don't assume EMACS_INT overflows nicely into int.
2924 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2925 may come from Lisp.
2926 (handle_one_xevent): NATNUMP can eval its arg twice.
2927 (x_connection_closed):
2928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2929 * xterm.h: Adjust decls to match defn changes elsewhere.
2930 (struct scroll_bar): Use struct vectorlike_header
2931 rather than rolling our own approximation.
2932 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2933
c6574eb5
GM
29342012-05-25 Glenn Morris <rgm@gnu.org>
2935
2936 * lisp.mk (lisp): Update for more files being compiled now.
2937
e8d32c7e
SM
29382012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2939
48def666
SM
2940 * lread.c: Remove `read_pure' which makes no difference.
2941 (read_pure): Remove var.
2942 (unreadpure): Remove function.
2943 (readevalloop): Don't call read_list with -1 flag.
2944 (read1, read_vector): Don't test read_pure any more.
2945 (read_list): Simplify.
2946
e8d32c7e
SM
2947 * fileio.c, character.h: Minor style tweaks.
2948
4b2addb7
DA
29492012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2950
2951 * window.h (clip_changed): Remove useless declaration.
2952
584461b2
JB
29532012-05-22 Juanma Barranquero <lekktu@gmail.com>
2954
2955 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2956 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2957
34374650
PE
29582012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2959
2960 Remove src/m/*.
2961 This directory predates autoconf and is no longer needed nowadays.
2962 Move its few remaining bits of functionality to where they're needed.
2963 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2964 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2965 * m/template.h: Remove.
2966 * Makefile.in (M_FILE): Remove. All uses removed.
2967 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2968 * lisp.h (USE_LSB_TAG):
2969 * mem-limits.h (EXCEEDS_LISP_PTR):
2970 Use VAL_MAX, not VALBITS, in #if.
2971 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2972 (EMACS_UINT): Define unconditionally now.
2973 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2974 (BITS_PER_EMACS_INT): New constants, replacing
2975 what used to be in config.h, but not useful in #if.
2976 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2977 define them any more.
2978 (VAL_MAX): New macro.
2979 (VALMASK): Use it.
2980 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2981 BITS_PER_EMACS_INT, in #if.
2982 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2983 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2984 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2985 * s/ms-w32.h (DATA_START):
2986 Move here from removed file m/intel386.h.
2987 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2988 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2989
261cb4bb
PE
29902012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 Assume C89 or later.
2993 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2994 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2995 (xrealloc):
2996 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2997 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2998 * textprop.c, tparam.c (NULL): Remove.
2999 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3000 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3001 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3002 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3003 * xterm.c (input_signal_count): Assume volatile works.
3004
ff23cd9f
KB
30052012-05-21 Ken Brown <kbrown@cornell.edu>
3006
3007 * xgselect.c (xg_select): Fix first argument in call to 'select'
3008 (bug#11508).
3009
1b170bc6
KB
30102012-05-20 Ken Brown <kbrown@cornell.edu>
3011
3012 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3013 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3014
b2f4d39f
KB
30152012-05-19 Ken Brown <kbrown@cornell.edu>
3016
3017 * xfns.c (x_in_use): Remove `static' qualifier.
3018 * xterm.h (x_in_use): Declare.
3019 * xgselect.c: Include xterm.h.
3020 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3021 and `display_arg' (bug#9754).
3022
003fdae2
PE
30232012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3024
9232a6d9
PE
3025 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3026
003fdae2
PE
3027 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3028 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3029
784b56e2
EZ
30302012-05-18 Eli Zaretskii <eliz@gnu.org>
3031
3032 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3033
3034 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3035 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3036
3037 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3038 reference to image_cache->refcount.
3039 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3040
a0a79cde
JL
30412012-05-17 Juri Linkov <juri@jurta.org>
3042
3043 * search.c (Fword_search_regexp, Fword_search_backward)
3044 (Fword_search_forward, Fword_search_backward_lax)
3045 (Fword_search_forward_lax): Move functions to isearch.el
3046 (bug#10145, bug#11381).
3047
b0572523
PE
30482012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3049
3050 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3051
9660f5fc
SM
30522012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3053
3054 * lread.c (init_obarray): Declare Qt and Qnil as special.
3055
4374de83
GM
30562012-05-14 Glenn Morris <rgm@gnu.org>
3057
3058 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3059 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3060
dc44c39a
PE
30612012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3062
078c97cb
PE
3063 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3064
dc44c39a
PE
3065 * unexaix.c: Port to more-recent AIX compilers.
3066 (report_error, report_error_1, make_hdr, copy_sym)
3067 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3068 Make arguments const char *, not char *, to avoid violations of C
3069 standard and to fix some AIX warnings reported by Gilles Pion.
3070
e18afed7 30712012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3072
3073 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3074 already have overlays loaded.
3075 (handle_single_display_spec): Before returning without displaying
3076 fringe bitmap, synchronize the bidi iterator with the main display
3077 iterator, by calling iterate_out_of_display_property.
3078 (iterate_out_of_display_property): Detect buffer iteration by
3079 testing that it->string is a Lisp string.
3080 (get_next_display_element): When the current object is exhausted,
3081 and there's something on it->stack, call set_iterator_to_next to
3082 proceed with what's on the stack, instead of returning zero.
3083 (set_iterator_to_next): If called at the end of a Lisp string,
3084 proceed to consider_string_end without incrementing string
3085 position. Don't increment display vector index past the end of
3086 the display vector. (Bug#11417)
c8fb9dc6
EZ
3087 (pos_visible_p): Don't report a position visible when move_it_to
3088 stopped at the last line of window, which happens to be scanned
3089 backwards by the bidi iteration. (Bug#11464)
ac268e67 3090
e18afed7 30912012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3092
3093 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3094 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3095 are on a TTY, and thus unable to display on the fringes.
3096 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3097 so we need to signal to the caller that this is a "replacing"
3098 display spec. This fixes display when the spec is invalid or we
3099 are on a TTY.
3100
e18afed7 31012012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3102
3103 * unexaix.c (make_hdr): Fix typo in prototype.
3104 This bug broke the build on AIX. Problem reported by Gilles Pion.
3105
9d0a235a
MA
31062012-05-14 Michael Albinus <michael.albinus@gmx.de>
3107
3108 * keyboard.c (kbd_buffer_get_event): Read special events also in
3109 batch mode. (Bug#11415)
3110
9e6b06ed
GM
31112012-05-12 Glenn Morris <rgm@gnu.org>
3112
3113 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3114
c1a1d7a3
EZ
31152012-05-12 Eli Zaretskii <eliz@gnu.org>
3116
3117 * lisp.mk (lisp): Add newcomment.elc.
3118
3fe7cdc8
GM
31192012-05-12 Glenn Morris <rgm@gnu.org>
3120
3121 * Makefile.in (MKDIR_P): New, set by configure.
3122 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3123
53f7d2c0
PE
31242012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3125
3126 Remove unused function hourglass_started.
3127 * dispextern.h (hourglass_started):
3128 * w32fns.c (hourglass_started):
3129 * xdisp.c (hourglass_started): Remove.
3130
75aafb17
JB
31312012-05-10 Juanma Barranquero <lekktu@gmail.com>
3132
3133 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3134 Update dependencies.
3135
12959e8e
PE
31362012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3137
97107e2e
PE
3138 * xgselect.c (xg_select): Put maxfds+1 into a var.
3139 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3140
12959e8e
PE
3141 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3142
836d29b3
DA
31432012-05-10 Dave Abrahams <dave@boostpro.com>
3144
3145 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3146 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3147
5cb67954
MA
31482012-05-09 Michael Albinus <michael.albinus@gmx.de>
3149
3150 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3151 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3152 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3153 Initialize xd_registered_buses.
3154
3478ec45
PE
31552012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3156
b263a6b0
PE
3157 Untag more efficiently if USE_LSB_TAG.
3158 This is based on a proposal by YAMAMOTO Mitsuharu in
3159 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3160 For an admittedly artificial (nth 8000 longlist) benchmark on
3161 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3162 Emacs's overall text size by 1%.
3163 * lisp.h (XUNTAG): New macro.
3164 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3165 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3166 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3167 * eval.c (Fautoload):
3168 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3169 * frame.h (XFRAME): Use XUNTAG.
3170
3478ec45
PE
3171 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3172 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3173 Remove unportable assumptions about print widths of types like
3174 dbus_uint32_t.
3175 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3176 intptr_t when converting between pointer and integer, to avoid GCC
3177 warnings about wrong width.
3178
666b903b 31792012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3180
3181 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3182 stack for each reader_thread, instead of defaulting to 8MB
3183 determined by the linker. This avoids failures in creating
3184 subprocesses on Windows 7, see the discussion in this thread:
3185 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3186
b120cc17
JC
31872012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3188
3189 Fix up display of the *Minibuf-0* buffer in the mini window.
3190 * keyboard.c (read_char): Don't clear the echo area if there's no
3191 message to clear.
3192 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3193 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3194
9a4b36f8
MA
31952012-05-07 Michael Albinus <michael.albinus@gmx.de>
3196
3197 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3198 batch mode.
3199
e5f9458f
CY
32002012-05-06 Chong Yidong <cyd@gnu.org>
3201
3202 * lisp.mk (lisp): Update.
3203
eceeb5fc 32042012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3205
3206 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3207
71873e2b
SM
32082012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3209
3210 * data.c (PUT_ERROR): New macro.
3211 (syms_of_data): Use it. Add new error type `user-error'.
3212 * undo.c (user_error): New function.
3213 (Fprimitive_undo): Use it.
3214 * print.c (print_error_message): Adjust print style for `user-error'.
3215 * keyboard.c (user_error): New function.
3216 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3217
ab0fa4e4
PE
32182012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 Do not limit current-time-string to years 1000..9999.
3221 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3222 (Fcurrent_time_string): Support any year that is supported by the
3223 underlying localtime representation. Don't use asctime, as it
3224 has undefined behavior for years outside the range -999..9999.
3225
7ed806a7
PE
32262012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 Fix race conditions involving setenv, gmtime, localtime, asctime.
3229 Without this fix, interrupts could mess up code that uses these
3230 nonreentrant functions, since setting TZ invalidates existing
3231 tm_zone or tzname values, and since most of these functions return
3232 pointers to static storage.
3233 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3234 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3235 Grow the critical sections to include not just invoking
3236 localtime/gmtime, but also accessing these functions' results
3237 including their tm_zone values if any, and any related TZ setting.
3238 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3239 so that the struct tm is saved in the critical section.
3240 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3241 motivated by the fact that memory allocation needs to be outside
3242 the critical section.
3243
0c16dfed
DA
32442012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3245
3246 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3247 with RESET_INTERVAL.
3248
3249 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3250 Remove duplicated buffer name initialization.
3251
3f83ace8
JM
32522012-05-02 Jim Meyering <jim@meyering.net>
3253
3254 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3255
c7b8541e
JM
3256 * xfns.c (x_window): Use xstrdup (Bug#11375).
3257
90207a15 32582012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3259
3260 * xdisp.c (pos_visible_p): If already at a newline from the
3261 display string before the 'while' loop, don't walk back the glyphs
3262 from it3.glyph_row. Solves assertion violation when the display
3263 string begins with a newline (egg.el). (Bug#11367)
3264
b593d6a9
AH
32652012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3266
3267 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3268 Move to simple.el.
3269
4737362e
GM
32702012-05-01 Glenn Morris <rgm@gnu.org>
3271
99cf43f9
GM
3272 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3273 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3274 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3275 All were removed before 23.1.
3276
9311dcff
GM
3277 * dispnew.c: Remove HAVE_LIBNCURSES test;
3278 it is always true on relevant platforms.
3279
4d5c6349
GM
3280 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3281 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3282
4737362e
GM
3283 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3284
74dd3a6b
AS
32852012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3286
3287 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3288 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3289 Remove.
3290
13c379ee
PE
32912012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3292
3293 Do not avoid creating empty evaporating overlays (Bug#9642).
3294 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3295 That is, do not delete an evaporating overlay if it becomes
3296 empty after its bounds are adjusted to fit within its buffer.
3297 This fix caused other problems, and I'm reverting it until we get
3298 to the bottom of them.
3299
a8e7d6d7 33002012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3301
3302 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3303
a8e7d6d7 33042012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3305
3306 * xdisp.c (pos_visible_p): If the window start position is beyond
3307 ZV, start the display from buffer beginning. Prevents assertion
3308 violation in init_iterator when the minibuffer window is scrolled
3309 via the scroll bar.
3310
3311 * window.c (window_scroll_pixel_based): Likewise.
3312
a8e7d6d7 33132012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3314
3315 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3316
a8e7d6d7 33172012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3318
3319 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3320 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3321
a8e7d6d7 33222012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3323
b593d6a9
AH
3324 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3325 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3326
1c6900d9
EZ
33272012-04-26 Eli Zaretskii <eliz@gnu.org>
3328
4c3fa1d9
EZ
3329 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3330 display element, check also the underlying string or buffer
3331 character. (Bug#11341)
3332
1c6900d9
EZ
3333 * w32menu.c: Include w32heap.h.
3334 (add_menu_item): If the call to AppendMenuW (via
3335 unicode_append_menu) fails, disable Unicode menus only if we are
3336 running on Windows 9X/Me.
3337
42bf8205
AS
33382012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3339
3340 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3341 (xgetint): Add missing shift for LSB tags.
3342
b1bac16e
MR
33432012-04-24 Martin Rudalics <rudalics@gmx.at>
3344
3345 * keyboard.c (read_char): Don't wipe echo area for select window
3346 events: These might get delayed via `mouse-autoselect-window'
3347 (Bug#11304).
3348
d69621cc
JB
33492012-04-24 Juanma Barranquero <lekktu@gmail.com>
3350
3351 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3352 manipulation of :loaded-from data.
3353
02fd101b
JB
33542012-04-23 Juanma Barranquero <lekktu@gmail.com>
3355
3356 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3357 now a cons (bug#11311).
3358
888bec30
PE
33592012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3360
89a438bd
PE
3361 Do not create empty overlays with the evaporate property (Bug#9642).
3362 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3363 if it becomes empty after its bounds are adjusted to fit within
3364 its buffer. Without this fix, in a nonempty buffer (let ((o
3365 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3366 yields an empty overlay that has the evaporate property, which is
3367 not supposed to happen.
3368
1068fe4d
PE
3369 Fix minor GTK3 problems found by static checking.
3370 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3371 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3372 (struct _EmacsFixedClass, emacs_fixed_get_type):
3373 Move decls here from emacsgtkfixed.h, since they needn't be public.
3374 (emacs_fixed_get_type): Now static.
3375 (emacs_fixed_class_init): Omit unused local.
3376 (emacs_fixed_child_type): Remove; unused.
3377 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3378 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3379 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3380 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3381 (EMACS_FIXED_GET_CLASS): Remove; unused.
3382 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3383
888bec30
PE
3384 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3385 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3386
de85e130
PE
33872012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3388
d0baac98 3389 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3390 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3391 (__malloc_size_t, __malloc_ptrdiff_t):
3392 Remove. All uses removed, replaced by the definiens if needed,
3393 since we can assume C89 or better now.
3394 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3395 (protect_malloc_state, align, get_contiguous_space)
3396 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3397 (malloc_atfork_handler_child, malloc_enable_thread)
3398 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3399 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3400 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3401 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3402 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3403 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3404 Define using prototypes, not old style.
3405 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3406 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3407 (align): Don't assume that signed integer overflow wraps around.
3408 Omit unused local var.
3409 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3410 (_free_internal_nolock, memalign, mallochook, reallochook):
3411 Omit no-longer-needed casts.
3412 (valloc): Use getpagesize, not __getpagesize.
3413 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3414 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3415
de85e130
PE
3416 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3417
dcbf5805
MA
34182012-04-22 Michael Albinus <michael.albinus@gmx.de>
3419
3420 Move functions from C to Lisp. Make non-blocking method calls
3421 the default. Implement further D-Bus standard interfaces.
3422
3423 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3424 (QCdbus_request_name_allow_replacement)
3425 (QCdbus_request_name_replace_existing)
3426 (QCdbus_request_name_do_not_queue)
3427 (QCdbus_request_name_reply_primary_owner)
3428 (QCdbus_request_name_reply_in_queue)
3429 (QCdbus_request_name_reply_exists)
3430 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3431 (QCdbus_registered_serial, QCdbus_registered_method)
3432 (QCdbus_registered_signal): New Lisp objects.
3433 (XD_DEBUG_MESSAGE): Use sizeof.
3434 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3435 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3436 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3437 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3438 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3439 (xd_signature, xd_append_arg): Allow float for integer types.
3440 (xd_get_connection_references): New function.
b593d6a9
AH
3441 (xd_get_connection_address): Rename from xd_initialize.
3442 Return cached address.
dcbf5805
MA
3443 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3444 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3445 level.
3446 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3447 Return number of refcounts.
dcbf5805
MA
3448 (Fdbus_get_unique_name): Make stronger parameter check.
3449 (Fdbus_message_internal): New defun.
3450 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3451 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3452 (Fdbus_send_signal, Fdbus_register_service)
3453 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3454 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3455 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3456 (Vdbus_compiled_version, Vdbus_runtime_version)
3457 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3458 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3459 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3460 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3461 Adapt docstring.
dcbf5805 3462
52828e02
PE
34632012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3464
da05bc4c
PE
3465 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3466 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3467 Do not assume ptrdiff_t is the same width as 'int'.
3468
52828e02
PE
3469 * alloc.c: Handle unusual debugging option combinations.
3470 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3471 since the two debugging options are incompatible.
3472 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3473 is defined.
3474 (mem_init, mem_insert, mem_insert_fixup):
3475 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3476 (NEED_MEM_INSERT): Remove; no longer needed.
3477
f01769f9
LL
34782012-04-22 Leo Liu <sdl.web@gmail.com>
3479
3480 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3481
5790543d
PE
34822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3483
3484 * sysdep.c [__FreeBSD__]: Minor cleanups.
3485 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3486 Use Emacs indenting style more consistently. Avoid some casts.
3487 Use 'double' consistently rather than mixing 'float' and 'double'.
3488
b91b7e4d
EW
34892012-04-21 Eduard Wiebe <usenet@pusto.de>
3490
b593d6a9
AH
3491 * sysdep.c (list_system_processes, system_process_attributes):
3492 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3493
6114eb15
AS
34942012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3495
3496 * lisp.mk (lisp): Update.
3497
2f38dff7
PE
34982012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3499
3500 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3501 It is never used otherwise.
3502
4ae29f89
SM
35032012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3504
3505 * print.c (print_preprocess): Only check print_depth if print-circle
3506 is nil.
3507 (print_object): Check for cycles even when print-circle is nil and
3508 print-gensym is t, but only check print_depth if print-circle is nil.
3509
f30d612a
CY
35102012-04-20 Chong Yidong <cyd@gnu.org>
3511
3512 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3513 set the status to "failed" and ensure that sentinel is run.
3514
c07a4c0b 35152012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3516
3517 * process.c (Fset_process_inherit_coding_system_flag)
3518 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3519 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3520
c07a4c0b 35212012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3522
3523 * xdisp.c (string_buffer_position_lim): Limit starting position to
3524 BEGV.
3525 (set_cursor_from_row): If called for a mode-line or header-line
3526 row, return zero immediately.
3527 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3528 farther than the first row after the header line, if any.
3529 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3530 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3531
c07a4c0b 35322012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3533
4ae29f89
SM
3534 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3535 (bug#11238).
ad3a2b41 3536
c07a4c0b 35372012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 35382012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3539
3540 configure: new option --enable-gcc-warnings (Bug#11207)
3541 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3542 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3543 (ALL_CFLAGS): Use new macros rather than old.
3544 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3545 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3546 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3547 -Wunused-result, -Wunused-variable. This should go away once
3548 the Emacs and Gnulib regex code is merged.
3549 (xmalloc, xrealloc): Now static.
3550
aba027e8
PE
35512012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3552
3553 * dired.c (Fsystem_groups): Remove unused local.
3554
e5a36063
GM
35552012-04-17 Glenn Morris <rgm@gnu.org>
3556
3557 * dired.c (Fsystem_users): Doc fix.
3558
316411f0
DA
35592012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3560
3561 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3562 (syms_of_dired): Add them.
3563
9426aba4
PE
35642012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3565
b62a57be
PE
3566 Fix minor alloc.c problems found by static checking.
3567 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3568 New extern decls, to avoid calling undeclared functions.
3569 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3570 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3571 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3572 (NEED_MEM_INSERT): New macro.
3573 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3574 Remove one incorrect comment and fix another.
b62a57be 3575
3539f31f
PE
3576 Fix minor ralloc.c problems found by static checking.
3577 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3578 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3579 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3580 (r_alloc_sbrk): Now static.
3581
a041960a
PE
3582 Improve ralloc.c interface checking.
3583 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3584 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3585 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3586 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3587 [REL_ALLOC]: ... to here, to check interface.
3588 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3589 Remove decls. This fixes an "It stinks!".
3590
9426aba4
PE
3591 * alloc.c (which_symbols): Fix alignment issue / type clash.
3592
d55c12ed
AS
35932012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3594
3595 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3596 (struct Lisp_Misc_Any): Likewise.
3597 (struct Lisp_Free): Likewise.
3598 * alloc.c (union aligned_Lisp_Symbol): Define.
3599 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3600 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3601 (union aligned_Lisp_Misc): Define.
3602 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3603 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3604 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3605
b948ce8b
PE
36062012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3609 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3610 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3611 * s/netbsd.h, s/sol2-6.h:
3612 Remove definition of GC_MARK_STACK, since the default now works.
3613 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3614 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3615 no longer the default.
3616 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3617
35dc09a1 36182012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3619
35dc09a1
GM
3620 * lread.c (lisp_file_lexically_bound_p):
3621 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3622
35dc09a1
GM
36232012-04-14 Eli Zaretskii <eliz@gnu.org>
3624
3625 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3626 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3627
36282012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3629
3630 * nsterm.m (constrainFrameRect): Always constrain when there is only
3631 one screen (Bug#10962).
3632
bcd86815
KB
36332012-04-13 Ken Brown <kbrown@cornell.edu>
3634
3635 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3636
c25df26e
RT
36372012-04-13 Reuben Thomas <rrt@sc3d.org>
3638
3639 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3640
0fc59f1e
DC
36412012-04-11 Daniel Colascione <dancol@dancol.org>
3642
3643 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3644 against is gone. It's better to use vfork now so that when Cygwin
3645 gains a new, working vfork, we use it automatically (bug#10398).
3646
de8c03dc
SM
36472012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3648
3649 * window.c (save_window_save): Obey window-point-insertion-type.
3650
2f097256
GM
36512012-04-11 Glenn Morris <rgm@gnu.org>
3652
3653 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3654
453b951e
SM
36552012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3656
3657 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3658
75f1671a 36592012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3660
3661 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3662 (force_quit_count): New var.
3663 (handle_interrupt): Use it.
3664
2a8ce227
JB
36652012-04-10 Juanma Barranquero <lekktu@gmail.com>
3666
3667 * w32.c (w32_delayed_load): Record the full path of the library
3668 being loaded (bug#10424).
3669
935396c0
GM
36702012-04-09 Glenn Morris <rgm@gnu.org>
3671
05920a43
GM
3672 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3673 not just in the obarray, before snarfing them. (Bug#11036)
3674
935396c0
GM
3675 * Makefile.in ($(leimdir)/leim-list.el):
3676 Pass EMACS rather than BUILT_EMACS.
3677
a18ecafa
TZ
36782012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3679
3680 * process.c (make_process):
3681 * process.h: Add integer `gnutls_handshakes_tried' member to
3682 process struct.
3683
6bbef4e5
JC
3684 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3685 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3686
3687 * gnutls.c (gnutls_log_function2i): Convenience log function.
3688 (emacs_gnutls_read): Use new log functions,
3689 `gnutls_handshakes_tried' process member, and
3690 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3691 attempts per process (connection).
3692
b4d3bc10
CY
36932012-04-09 Chong Yidong <cyd@gnu.org>
3694
3695 * eval.c (Fuser_variable_p, user_variable_p_eh)
3696 (lisp_indirect_variable): Functions deleted.
3697 (Fdefvar): Caller changed.
3698
3699 * callint.c (Finteractive, Fcall_interactively):
3700 * minibuf.c (Fread_variable): Callers changed.
3701
70f4d973
EZ
37022012-04-09 Eli Zaretskii <eliz@gnu.org>
3703
3704 * xdisp.c (set_cursor_from_row): If the display string appears in
3705 the buffer at position that is closer to point than the position
3706 after the display string, display the cursor on the first glyph of
3707 the display string. Fixes cursor display when a 'display' text
3708 property immediately follows invisible text. (Bug#11094)
3709
cb3c2e3e
PE
37102012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 composite.c: use 'double' consistently
3713 * composite.c (get_composition_id): Use 'double' consistently
3714 instead of converting 'float' to 'double' and vice versa; this is
3715 easier to understand and avoids a GCC warning.
3716
fd06db5d
GM
37172012-04-09 Glenn Morris <rgm@gnu.org>
3718
50fe702a
GM
3719 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3720 preparation for dumping it with emacs. (Bug#4789)
3721 (leimdir): New variable.
3722 ($(leimdir)/leim-list.el): New rule.
3723 (emacs$(EXEEXT)): Depend on leim-list.el.
3724
fd06db5d
GM
3725 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3726 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3727 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3728
55c131ee
AS
37292012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3730
3731 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3732 proper alignment.
3733
9209588f
JB
37342012-04-07 Juanma Barranquero <lekktu@gmail.com>
3735
3736 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3737 Remove unused local variable.
3738
e3fb2efb
PE
37392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3740
3741 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3742 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3743 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3744 objects, as mark_maybe_pointer will catch them otherwise.
3745 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3746 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3747
b5385551
PE
37482012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3749
3750 Fix typo that broke non-Windows builds.
3751 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3752
9078ead6
EZ
37532012-04-07 Eli Zaretskii <eliz@gnu.org>
3754
3755 Support building on MS-Windows with libxml2.
3756
3757 * makefile.w32-in (OBJ2): Add xml.$(O).
3758 (GLOBAL_SOURCES): Add xml.c.
3759 ($(BLD)/xml.$(O)): New dependency list.
3760
3761 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3762 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3763 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3764 [!WINDOWSNT]: New macros.
3765 (init_libxml2_functions, libxml2_loaded_p): New functions.
3766 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3767 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3768 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3769 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3770 linked in).
6bbef4e5
JC
3771 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3772 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3773 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3774
3775 * emacs.c: Don't include libxml/parser.h.
3776 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3777 xmlCleanupParser directly.
3778
3779 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3780
3811fdf3
EZ
37812012-04-07 Eli Zaretskii <eliz@gnu.org>
3782
3783 * indent.c (Fvertical_motion): If there is a display string at
3784 point, use it.vpos to compute how many lines to backtrack after
3785 move_it_to point. (Bug#11133)
3786
2f8e16b2
EZ
37872012-04-06 Eli Zaretskii <eliz@gnu.org>
3788
3789 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3790 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3791 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3792 macros related to unification of CJK characters. For the details,
3793 see the discussion following the message here:
3794 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3795
3d439cd1
CY
37962012-04-04 Chong Yidong <cyd@gnu.org>
3797
3798 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3799
8bc53d00
EZ
38002012-04-01 Eli Zaretskii <eliz@gnu.org>
3801
3802 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3803 instead of alloca. (Bug#11138)
3804
3b0512a3
AS
38052012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3806
3807 * w32menu.c (is_simple_dialog): Properly check lisp types.
3808 (Bug#11141)
3809
8427ddd2
EZ
38102012-03-31 Eli Zaretskii <eliz@gnu.org>
3811
979022ef
EZ
3812 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3813 position we get to after a call to move_it_to fails the
3814 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3815 only if we wind up in a string from display property. (Bug#11063)
3816
a6b1c7cc
EZ
3817 * window.c (Fdelete_other_windows_internal): Invalidate the row
3818 and column information about mouse highlight, so that redisplay
3819 restores it after reallocating the glyph matrices. (Bug#7464)
3820
8427ddd2
EZ
3821 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3822 string comes from a `display' text property, use the buffer
3823 position of that property as if we actually saw that position in
3824 the row's glyphs.
697ba24b
EZ
3825 (move_it_by_lines): Remove the assertion that
3826 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3827 violated when there's a before-string at the beginning of a line.
3828 (Bug#11063)
8427ddd2 3829
65a0a738
EZ
38302012-03-30 Eli Zaretskii <eliz@gnu.org>
3831
3832 * xdisp.c (append_space_for_newline): If the default face was
3833 remapped, use the remapped face for the appended newline.
3834 (extend_face_to_end_of_line): Use the remapped default face for
3835 extending the face to the end of the line.
3836 (display_line): Call extend_face_to_end_of_line when the default
3837 face was remapped. (Bug#11068)
3838
581355cc
EZ
38392012-03-29 Eli Zaretskii <eliz@gnu.org>
3840
3841 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3842
e8fc049f
SM
38432012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3844
3845 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3846
4fb9a543
GM
38472012-03-27 Glenn Morris <rgm@gnu.org>
3848
3849 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3850 Doc fixes.
3851
679910f1
KH
38522012-03-26 Kenichi Handa <handa@m17n.org>
3853
3854 * dispextern.h (struct glyph): Fix previous change. Change the
3855 bit length of glyphless.ch to 25 (Bug#11082).
3856
90d49b7f
CY
38572012-03-26 Chong Yidong <cyd@gnu.org>
3858
3859 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3860 (command_loop_1): Use it; inhibit selection update for
3861 handle-select-window too (Bug#8996).
3862
f514f6f0
FP
38632012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3864
e8fc049f 3865 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3866
bf43fa51
KH
38672012-03-25 Kenichi Handa <handa@m17n.org>
3868
3869 * dispextern.h (struct glyph): Change the bit length of
3870 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3871
8a0c01dd
EZ
38722012-03-24 Eli Zaretskii <eliz@gnu.org>
3873
3874 * s/ms-w32.h (tzname): Include time.h before redirecting to
3875 _tzname. Fixes the MSVC build. (Bug#9960)
3876
7d1c3a76
AS
38772012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3878
8ed79523
AS
3879 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3880 characters.
3881
7d1c3a76
AS
3882 * xterm.c (XTread_socket): Only modify handling_signal if
3883 !SYNC_INPUT. (Bug#11080)
3884
e99a9b8b
EZ
38852012-03-23 Eli Zaretskii <eliz@gnu.org>
3886
3887 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3888 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3889 when fetching a multibyte character consumes more bytes than
3890 CHAR_BYTES returns, due to unification of CJK characters in
3891 string_char. (Bug#11073)
3892
5063c0e1
TN
38932012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3894
3895 * process.c (wait_reading_process_output): Handle pty disconnect
3896 by refraining from sending oneself a SIGCHLD (bug#10933).
3897
9f851fbd
CY
38982012-03-22 Chong Yidong <cyd@gnu.org>
3899
3900 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3901
5063c0e1 3902 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3903 Mark string as coming from a prefix property.
3904 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3905 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3906
fb5b8aca
CY
39072012-03-21 Chong Yidong <cyd@gnu.org>
3908
3909 * xfaces.c (Vface_remapping_alist): Doc fix.
3910
62356a1b
EZ
39112012-03-20 Eli Zaretskii <eliz@gnu.org>
3912
3913 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3914 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3915 Doc fixes.
62356a1b 3916
025de85b
CY
39172012-03-20 Chong Yidong <cyd@gnu.org>
3918
3919 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3920 to reflect default non-nil value of redisplay-dont-pause.
3921
4827f94e
KH
39222012-03-19 Kenichi Handa <handa@m17n.org>
3923
3924 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3925 it fit in a valid range (Bug#11003).
3926
e50a24a2
EZ
39272012-03-18 Eli Zaretskii <eliz@gnu.org>
3928
3929 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3930 that is not from display property, accept the row as a "cursor
3931 row" if one of the string's character has a non-nil `cursor'
3932 property. Fixes cursor positioning when there are newlines in
3933 overlay strings, e.g. in icomplete.el. (Bug#11035)
3934
9af5ed87
PE
39352012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3938
d1f55f16
CY
39392012-03-12 Chong Yidong <cyd@gnu.org>
3940
3941 * eval.c (inhibit_lisp_code): Rename from
3942 inhibit_window_configuration_change_hook; move from window.c.
3943
3944 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3945 * window.c (run_window_configuration_change_hook)
3946 (syms_of_window): Callers changed.
3947
66c5eebd
CY
39482012-03-11 Chong Yidong <cyd@gnu.org>
3949
413df973
CY
3950 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3951
66c5eebd
CY
3952 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3953
1de11f56
CY
39542012-03-10 Chong Yidong <cyd@gnu.org>
3955
3956 * frame.c (other_visible_frames): Don't assume the selected frame
3957 is visible (Bug#10955).
3958
cae07000
SM
39592012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3960
3961 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3962
89c94350
JD
39632012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3964
3965 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3966 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3967 zero (Bug#10954).
3968
999dd333
GM
39692012-03-03 Glenn Morris <rgm@gnu.org>
3970
01a6dcc8 3971 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3972
de0100f2
EZ
39732012-03-02 Eli Zaretskii <eliz@gnu.org>
3974
3975 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3976 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3977 (redisplay_window, next_element_from_string): Fix typos in
3978 comments.
3e441275
EZ
3979 (redisplay_window): Pass to move_it_vertically the margin in
3980 pixels, not in screen lines.
de0100f2 3981
96a72ee9
GM
39822012-03-02 Glenn Morris <rgm@gnu.org>
3983
3984 * buffer.c (buffer-list-update-hook): Doc fix.
3985
312508d7
EZ
39862012-02-29 Eli Zaretskii <eliz@gnu.org>
3987
3988 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3989 push_it before setting up the iterator for the first overlay
3990 string, even if we have an empty string loaded.
3991 (next_overlay_string): If there's an empty string on the iterator
3992 stack, pop the stack. (Bug#10903)
3993
27f3c637
PE
39942012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3995
3996 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3997 Suggested by Stefan Monnier in
3998 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3999 * alloc.c (widen_to_Lisp_Object): New static function.
4000 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4001 and widening them to Lisp_Objects. This would work even if
4002 USE_LSB_TAG is defined and wide integers are used, which might
4003 happen in a future version of Emacs.
4004
3c9dfce6
CY
40052012-02-25 Chong Yidong <cyd@gnu.org>
4006
fa74b241
CY
4007 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4008 Doc fix.
4009
3c9dfce6
CY
4010 * xselect.c (Fx_selection_exists_p): Doc fix.
4011 (x_clipboard_manager_save_all): Print an informative message
4012 before saving to clipboard manager.
4013
9486df08
CY
40142012-02-24 Chong Yidong <cyd@gnu.org>
4015
4016 * keyboard.c (process_special_events): Handle all X selection
4017 requests in kbd_buffer, not just the next one (Bug#8869).
4018
f01d3321
CY
40192012-02-23 Chong Yidong <cyd@gnu.org>
4020
4021 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4022 call when setting menu-bar-lines and tool-bar-lines parameters.
4023 (unwind_create_frame_1): New helper function.
4024
4025 * window.c (inhibit_window_configuration_change_hook): New var.
4026 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4027 (syms_of_window): Initialize it.
f01d3321 4028
86b847b6
CY
40292012-02-22 Chong Yidong <cyd@gnu.org>
4030
4031 * xterm.c (x_draw_image_relief): Add missing type check for
4032 Vtool_bar_button_margin (Bug#10743).
4033
a59225b1
CY
40342012-02-21 Chong Yidong <cyd@gnu.org>
4035
4036 * fileio.c (Vfile_name_handler_alist): Doc fix.
4037
4038 * buffer.c (Fget_file_buffer): Protect against invalid file
4039 handler return value.
4040
310f5bd4
PE
40412012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4042
cb3a28cc
PE
4043 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4044 when computing $valmask.
4045
310f5bd4
PE
4046 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4047 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4048 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4049 It's useless in that case, and it can cause problems on hosts
4050 that allocate halves of EMACS_INT values separately.
4051 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4052 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4053 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4054 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4055 it avoids undefined behavior on hosts where shifting right by more
4056 than the word width has undefined behavior.
4057
2375c96a
CY
40582012-02-19 Chong Yidong <cyd@gnu.org>
4059
4060 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4061 (Funhandled_file_name_directory, Ffile_name_as_directory)
4062 (Fdirectory_file_name, Fexpand_file_name)
4063 (Fsubstitute_in_file_name): Protect against invalid file handler
4064 return values (Bug#10845).
4065
3eb49e71
EZ
40662012-02-18 Eli Zaretskii <eliz@gnu.org>
4067
4068 * .gdbinit (pitx): Fix incorrect references to fields of the
4069 iterator stack.
4070
7b926f3f
CY
40712012-02-17 Chong Yidong <cyd@gnu.org>
4072
4073 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4074
11273115
PE
40752012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4076
4077 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4078 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4079
c3a70e2b
CY
40802012-02-15 Chong Yidong <cyd@gnu.org>
4081
4082 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4083 marked as special. Also, starting docstrings with * is obsolete.
4084
0ca43699
AS
40852012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4086
4087 * gnutls.c (emacs_gnutls_write): Fix last change.
4088
2e8f3c56
LI
40892012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4090
4091 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4092 send_process.
4093
af70074f
SM
40942012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4095
4096 * keymap.c (Fsingle_key_description): Handle char ranges.
4097
95986d52
CY
40982012-02-12 Chong Yidong <cyd@gnu.org>
4099
afd83bd1
CY
4100 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4101 as that creates a dangerous corner case.
4102
95986d52
CY
4103 * window.c (Fdelete_window_internal): Invalidate the mouse
4104 highlight (Bug#9904).
4105
bd7da63e
GM
41062012-02-12 Glenn Morris <rgm@gnu.org>
4107
4108 * xselect.c (Fx_own_selection_internal)
4109 (Fx_get_selection_internal, Fx_disown_selection_internal)
4110 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4111 * nsselect.m (Fx_own_selection_internal)
4112 (Fx_disown_selection_internal, Fx_selection_exists_p)
4113 (Fx_selection_owner_p, Fx_get_selection_internal):
4114 Sync docs and argument specs with the xselect.c versions.
4115
77abcbc2
LI
41162012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4117
4118 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4119
90b671e2
EZ
41202012-02-11 Eli Zaretskii <eliz@gnu.org>
4121
1c0ca0b7
EZ
4122 * w32select.c (Fx_selection_exists_p): Sync doc string and
4123 argument list with xselect.c. (Bug#10783)
4124
4125 * w16select.c (Fx_selection_exists_p): Sync doc string and
4126 argument list with xselect.c. (Bug#10783)
90b671e2 4127
49241268
GM
41282012-02-10 Glenn Morris <rgm@gnu.org>
4129
4130 * fns.c (Fsecure_hash): Doc fix.
4131
f998bbe7 41322012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4133
4134 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4135
0992bd9c
CY
41362012-02-07 Chong Yidong <cyd@gnu.org>
4137
4138 * buffer.c (Fbuffer_local_variables)
4139 (buffer_lisp_local_variables): Handle unbound vars correctly;
4140 don't let Qunbound leak into Lisp.
4141
af008560
GM
41422012-02-07 Glenn Morris <rgm@gnu.org>
4143
dd605cc4
GM
4144 * image.c (Fimagemagick_types): Doc fix.
4145
af008560
GM
4146 * image.c (imagemagick-render-type): Change it from a lisp object
4147 to an integer. Move the doc here from the lisp manual.
4148 Treat all values not equal to 0 the same.
4149
1449fa1d
CY
41502012-02-06 Chong Yidong <cyd@gnu.org>
4151
4152 * doc.c (store_function_docstring): Avoid applying docstring of
4153 alias to base function (Bug#2603).
4154
3723ec07
AS
41552012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4156
4157 * .gdbinit (pp1, pv1): Remove redundant defines.
4158 (pr): Use pp.
4159
79c1cc1e
CY
41602012-02-04 Chong Yidong <cyd@gnu.org>
4161
4162 * nsterm.m: Declare a global (Bug#10694).
4163
d7f29f8e
EZ
41642012-02-04 Eli Zaretskii <eliz@gnu.org>
4165
cae07000
SM
4166 * w32.c (get_emacs_configuration_options):
4167 Include --enable-checking, if specified, in the return value.
d7f29f8e 4168
3b95a6f9
MR
41692012-02-04 Martin Rudalics <rudalics@gmx.at>
4170
4171 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4172 after rounding frame sizes. (Bug#9723)
4173
d6fa96a6
EZ
41742012-02-04 Eli Zaretskii <eliz@gnu.org>
4175
4176 * keyboard.c (adjust_point_for_property): Don't position point
4177 before BEGV. (Bug#10696)
4178
df0b2940
PE
41792012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4180
4181 Handle overflow when computing char display width (Bug#9496).
4182 * character.c (char_width): Return EMACS_INT, not int.
4183 (char_width, c_string_width): Check for overflow when
4184 computing the width; this is possible now that individual
4185 characters can have unbounded width. Problem introduced
4186 by merge from Emacs 23 on 2012-01-19.
4187
6bee44d6
MA
41882012-02-02 Michael Albinus <michael.albinus@gmx.de>
4189
4190 * dbusbind.c (Fdbus_register_method): Mention the return value
4191 :ignore in the docstring.
4192
44f92739
GM
41932012-02-02 Glenn Morris <rgm@gnu.org>
4194
1b9f60cc
GM
4195 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4196
44f92739
GM
4197 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4198 Unconditionally set to t. (Bug#10673)
4199 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4200 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4201 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4202
c5d3843c
KH
42032012-02-02 Kenichi Handa <handa@m17n.org>
4204
4205 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4206 0, do not call append_composite_glyph.
4207
159462d4 42082012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4209
4210 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4211 NULL (Bug#6988).
4212 (x_produce_glyphs): If the component of a composition is a null
4213 string, set it->pixel_width to 1 to avoid zero-width glyph.
4214
78cef877
EZ
42152012-02-01 Eli Zaretskii <eliz@gnu.org>
4216
4217 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4218 first 2 arguments are identical. This makes inserting large
4219 output from a subprocess an order of magnitude faster on
4220 MS-Windows, where all sbrk'ed memory is always contiguous.
4221
97897668
GM
42222012-01-31 Glenn Morris <rgm@gnu.org>
4223
4224 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4225 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4226 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4227
31fd3586
GM
42282012-01-29 Glenn Morris <rgm@gnu.org>
4229
4230 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4231
0e24a8b2
CY
42322012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4233
4234 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4235
cc0adcb0
CY
42362012-01-28 Chong Yidong <cyd@gnu.org>
4237
4238 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4239
acc28cb9
CY
42402012-01-26 Chong Yidong <cyd@gnu.org>
4241
9c69cfb7
CY
4242 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4243
acc28cb9
CY
4244 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4245 repeat counts (Bug#10507).
4246
48da7392
GM
42472012-01-26 Glenn Morris <rgm@gnu.org>
4248
4249 * lread.c (syms_of_lread): Doc fix.
4250
14af5f7f
CY
42512012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4252
4253 * coding.c (encode_designation_at_bol): Change return value to
4254 EMACS_INT.
4255
0b21c100
CY
42562012-01-25 Chong Yidong <cyd@gnu.org>
4257
4258 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4259
3c2907f7
CY
42602012-01-21 Chong Yidong <cyd@gnu.org>
4261
4262 * floatfns.c (Fcopysign): Make the second argument non-optional,
4263 since nil is not allowed anyway.
4264
959ad23f
AS
42652012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4266
4267 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4268 (send_process): Likewise.
4269
34a02f46
MR
42702012-01-19 Martin Rudalics <rudalics@gmx.at>
4271
4272 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4273 (Vwindow_persistent_parameters): Do not use Qstate.
4274 Rewrite doc-strings.
34a02f46 4275
1259009a 42762012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4277
4278 * character.c (char_width): New function.
70d4fdf6
GM
4279 (Fchar_width, c_string_width, lisp_string_width):
4280 Use char_width (Bug#9496).
25ed9e61 4281
6a6ee00d
MR
42822012-01-16 Martin Rudalics <rudalics@gmx.at>
4283
4284 * window.c (Vwindow_persistent_parameters): New variable.
4285 (Fset_window_configuration, save_window_save): Handle persistent
4286 window parameters.
4287
c85efaf7
EZ
42882012-01-14 Eli Zaretskii <eliz@gnu.org>
4289
4290 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4291 thrashing the stack of the thread. (Bug#9087)
4292
5944709e
PE
42932012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4296
e71f5d99
EZ
42972012-01-11 Eli Zaretskii <eliz@gnu.org>
4298
4299 * xdisp.c (rows_from_pos_range): Handle the case where the
4300 highlight ends on a newline. (Bug#10464)
4301 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4302 he end column for display of highlight that ends on a newline
4303 before a R2L line.
4304
ce316182
GM
43052012-01-11 Glenn Morris <rgm@gnu.org>
4306
4307 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4308 from load-path also when installation-directory is nil. (Bug#10208)
4309
5b43da69
GM
43102012-01-10 Glenn Morris <rgm@gnu.org>
4311
74cc8ff9
GM
4312 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4313
7d8d6e4e
GM
4314 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4315 Update template values to be closer to their typical values these days.
5b43da69 4316
a0db8d43
EZ
43172012-01-09 Eli Zaretskii <eliz@gnu.org>
4318
4319 * xdisp.c (rows_from_pos_range): Accept additional argument
4320 DISP_STRING, and accept any glyph in a row whose object is that
4321 string as eligible for mouse highlight. Fixes mouse highlight of
4322 display strings from overlays. (Bug#10464)
4323
9a0115ab 43242012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4325
b9110d6a 4326 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4327 * fileio.c (auto_saving_dir_umask): New static var.
4328 (Fmake_directory_internal): Use it.
4329 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4330 creating the directory. The old code temporarily assigns
4331 too-generous permissions to the directory.
4332 (do_auto_save_eh): Clear it.
b9110d6a 4333 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4334 that the var is always cleared.
4335
6c1bd3f3
EZ
43362012-01-07 Eli Zaretskii <eliz@gnu.org>
4337
4338 * search.c (scan_buffer): Pass character positions to
4339 know_region_cache, not byte positions. (Bug#6540)
4340
069d2b50
L
43412012-01-07 LynX <_LynX@bk.ru> (tiny change)
4342
4343 * w32.c (sys_rename): Report EXDEV when rename of a directory
4344 fails because the target is on another logical disk. (Bug#10284)
4345
75bf0d33
DB
43462012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4347
4348 * xterm.c (x_embed_request_focus): New function.
4349
4350 * xterm.h: Add prototype.
4351
4352 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4353
1c6e5a32
GM
43542012-01-05 Glenn Morris <rgm@gnu.org>
4355
4356 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4357
651e947e
EZ
43582012-01-01 Eli Zaretskii <eliz@gnu.org>
4359
4360 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4361 Load gnutls_transport_set_lowat only if GnuTLS version is below
4362 2.11.1.
4363 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4364 GnuTLS versions below 2.11.1.
4365
3778cdd8
AL
43662011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4367
4368 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4369 to the doc string advising against its use for altering the way
4370 windows are scrolled.
4371
0e5317f7
KH
43722011-12-28 Kenichi Handa <handa@m17n.org>
4373
4374 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4375 coding-system ASCII compatible only when it does not produce BOM
4376 on encoding (Bug#10383).
4377
93d5ca1f
JD
43782011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4379
4380 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4381 can scroll.
4382 (create_and_show_popup_menu): Always use menu_position_func for
4383 Gtk3 (Bug#10361).
4384
ca22b785
AS
43852011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4386
4387 * callint.c (Fcall_interactively): Don't truncate prompt string.
4388
d048e1e6
EZ
43892011-12-23 Eli Zaretskii <eliz@gnu.org>
4390
4391 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4392 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4393 resumed from there (after widening). (Bug#10360)
d048e1e6 4394
5ccaba1f
JD
43952011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4396
4397 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4398
204ee57f
JD
43992011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4400
b81d40f0
JB
4401 * nsterm.m (x_free_frame_resources):
4402 Release f->output_data.ns->miniimage.
204ee57f
JD
4403 (ns_index_color): Fix indentation. Do not retain
4404 color_table->colors[i].
4405
4406 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4407 before returning.
4408
4409 * nsfns.m (x_set_background_color): Assign return value from
4410 ns_index_color to face-background instead of NSColor*.
4411 (ns_implicitly_set_icon_type): Fix indentation.
4412 Change assignment in for loop to comparison.
4413
4414 * emacs.c (ns_pool): New variable.
4415 (main): Assign ns_pool.
4416 (Fkill_emacs): Call ns_release_autorelease_pool.
4417
4418 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4419 autorelease fdesc, release fdAttrs and tdict.
4420 (ns_get_covering_families): Release charset.
4421 (ns_findfonts): Release NSFontDescriptor created with new.
4422 (ns_uni_to_glyphs): Fix indentation.
4423 (setString): Release attrStr before assigning new value.
4424
c803b2b7
JD
44252011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4426
678f4426
JD
4427 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4428 and NS_IMPL_COCOA.
4429 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4430 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4431
cd394be1 44322011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4433
5fecd5fc
JD
4434 * nsterm.m (ns_term_init): Subscribe for notifications
4435 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4436 to method trackingNotification in EmacsMenu.
4437
4438 * nsmenu.m (trackingMenu): New variable.
3771cb17 4439 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4440 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4441 from Aquamacs (Bug#7030).
678f4426
JD
4442
44432011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4444
c803b2b7
JD
4445 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4446 (symbol_to_nsstring): Fix indentation.
4447 (ns_symbol_to_pb): New function.
cae07000
SM
4448 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4449 (Fns_rotate_cut_buffers_internal): Remove.
4450 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4451 Fns_store_cut_buffer_internal.
4452 (ns_get_foreign_selection, Fx_own_selection_internal)
4453 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4454 (Fns_get_selection_internal, Fns_store_selection_internal):
4455 Use ns_symbol_to_pb and check if return value is nil.
4456 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4457 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4458 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4459 renamed to Sns_store_selection_internal.
4460 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4461 and remove this function.
4462 (ns_handle_selection_clear): Remove, never used.
4463 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4464 here.
4465
e1b01a3a
KB
44662011-12-17 Ken Brown <kbrown@cornell.edu>
4467
4468 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4469 GID is unknown (Bug#10257).
4470
2adb6e85
PE
44712011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4472
4473 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4474 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4475 which caused a build failure on GNU/Linux IA-64. This problem was
4476 introduced by my 2011-10-07 patch.
4477
d1d7b339
JL
44782011-12-15 Juri Linkov <juri@jurta.org>
4479
4480 * image.c (imagemagick_error): New function. (Bug#10112)
4481 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4482 Use `imagemagick_error' where ImageMagick functions return
4483 `MagickFalse'.
4484 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4485 proper order.
4486
100d5755
KH
44872011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4488
4489 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4490 fill background (Bug#8992).
4491
454592a6
MR
44922011-12-13 Martin Rudalics <rudalics@gmx.at>
4493
4494 * window.c (Vwindow_combination_resize)
4495 (Vwindow_combination_limit): Use t instead of non-nil in
4496 doc-strings.
61d4b438
MR
4497 (Vrecenter_redisplay): Add first sentence of doc-string on
4498 separate line.
53524d93 4499 (Frecenter): Fix doc-string typo.
454592a6 4500
3633e3aa
KH
45012011-12-11 Kenichi Handa <handa@m17n.org>
4502
4503 * coding.c (Funencodable_char_position): Pay attention to the
4504 buffer text relocation (Bug#9389).
4505
7b9d523a 45062011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4507
7b9d523a
JD
4508 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4509 gtk_init (Bug#10100).
4510
b73189c6
EZ
45112011-12-10 Eli Zaretskii <eliz@gnu.org>
4512
4513 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4514 IT->string is nil. (Bug#10263)
4515
f7dfe5d6
JD
45162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4517
83faebb4
JD
4518 * nsterm.h (x_free_frame_resources): Declare.
4519
f7dfe5d6
JD
4520 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4521 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4522
4523 * nsterm.h (ns_get_defaults_value): Declare.
4524
4525 * nsterm.m (ns_default): Call ns_get_defaults_value.
4526
7cd4e72c
EZ
45272011-12-09 Eli Zaretskii <eliz@gnu.org>
4528
4529 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4530 (Bug#10170)
4531
b34d7317
YM
45322011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4533
4534 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4535 that where the value of an _OBJC_* symbol points to is in the .bss
4536 section (Bug#10240).
4537
76470ad1
KH
45382011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4539
4540 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4541 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4542
745fff94
KH
45432011-12-08 Kenichi Handa <handa@m17n.org>
4544
4545 * ftfont.c (get_adstyle_property): Fix previous change
4546 (Bug#10233).
4547
6e44397c
JB
45482011-12-07 Juanma Barranquero <lekktu@gmail.com>
4549
4550 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4551 dirs from the default value of EMACSLOADPATH (bug#10208).
4552
7efa6272
GM
45532011-12-07 Glenn Morris <rgm@gnu.org>
4554
4555 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4556 installation and source directories as well. (Bug#10208)
4557
f6fc4d87
CY
45582011-12-06 Chong Yidong <cyd@gnu.org>
4559
4560 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4561
2bf26180
GM
45622011-12-06 Glenn Morris <rgm@gnu.org>
4563
4564 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4565 as an error, not just -1. (Bug#10217)
4566
3a6ad4f0
CY
45672011-12-05 Chong Yidong <cyd@gnu.org>
4568
4569 * keyboard.c (process_special_events): New function.
4570 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4571
75a3b399
PE
45722011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4573
4574 * coding.c (encode_designation_at_bol): Don't use uninitialized
4575 local variable (Bug#9318).
4576
c3c9e25e
KH
45772011-12-05 Kenichi Handa <handa@m17n.org>
4578
4579 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4580 return Qnil (Bug#8046, Bug#10193).
4581
5eb05ea3
KH
45822011-12-05 Kenichi Handa <handa@m17n.org>
4583
4584 * coding.c (encode_designation_at_bol): New args charbuf_end and
4585 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4586 (coding_set_source): Return how many bytes coding->source was
4587 relocated.
4588 (coding_set_destination): Return how many bytes
4589 coding->destination was relocated.
4590 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4591 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4592
45932011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4594
4595 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4596 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4597 macro (Bug#9318).
4598
45992011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4600
4601 The following changes are to fix Bug#9318.
4602
a79703f5 4603 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4604 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4605 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4606 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4607
7dbda6df
JB
46082011-12-05 Juanma Barranquero <lekktu@gmail.com>
4609
4610 * lisp.h (process_quit_flag): Fix external declaration.
4611
6d5eb5b0
SM
46122011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4613
4614 Don't macro-inline non-performance-critical code.
4615 * eval.c (process_quit_flag): New function.
4616 * lisp.h (QUIT): Use it.
4617
a0c3fad0
JD
46182011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4619
4620 * nsfns.m (get_geometry_from_preferences): New function.
4621 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4622
6c07aac2
AS
46232011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4624
4625 * emacs.c (Qkill_emacs): Define.
4626 (syms_of_emacs): Initialize it.
4627 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4628 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4629 (quit_throw_to_read_char): Add parameter `from_signal'.
4630 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4631 * lisp.h (QUIT): Call Fkill_emacs if requested.
4632
c052ead4
JD
46332011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4634
4635 * widget.c (update_wm_hints): Return if wmshell is null.
4636 (widget_update_wm_size_hints): New function.
4637
4638 * widget.h (widget_update_wm_size_hints): Declare.
4639
4640 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4641 widget_update_wm_size_hints (Bug#10104).
4642
9e49252b
EZ
46432011-12-03 Eli Zaretskii <eliz@gnu.org>
4644
4645 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4646 before a newline, prepare the bidi iterator for consuming the
4647 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4648 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4649
02b16839
JL
46502011-12-02 Juri Linkov <juri@jurta.org>
4651
4652 * search.c (Fword_search_regexp): New Lisp function created from
4653 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4654 (Fword_search_backward, Fword_search_forward)
4655 (Fword_search_backward_lax, Fword_search_forward_lax):
4656 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4657 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4658
0068070e
SM
46592011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4660
4661 * fileio.c (Finsert_file_contents): Move after-change-function call
4662 to before the "handled:" label, since all "goto handled" appear in
4663 cases where the *-change-functions have already been properly called
4664 (bug#10117).
4665
3360a3fc
AS
46662011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4667
4668 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4669 waiting for input. (Bug#10169)
4670
73d6c093
EZ
46712011-11-30 Eli Zaretskii <eliz@gnu.org>
4672
4673 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4674 verifies glyph row's hash code--we have just reallocated the
4675 glyphs, so their contents can be complete garbage. (Bug#10164)
4676
febe6bea
JB
46772011-11-30 Juanma Barranquero <lekktu@gmail.com>
4678
4679 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4680
801a4313
EZ
46812011-11-30 Eli Zaretskii <eliz@gnu.org>
4682
4683 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4684 attributes are tested _before_ calling verify_row_hash, to protect
4685 against GCC re-ordering of the tests. (Bug#10164)
4686
2b56b87e
JD
46872011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4688
4689 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4690
4691 * xterm.c (handle_one_xevent): Only set async_visible and friends
4692 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4693 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4694 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4695
dbf31225
PE
46962011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4697
4698 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4699 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4700 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4701 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4702 All uses changed to use GCPRO1 etc.
4703 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4704 Revert to old implementation (i.e., before 2011-03-11).
4705
1305621b
YM
47062011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4707
4708 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4709 of scroll runs so as to avoid assigning disabled bogus rows and
4710 unnecessary graphics copy operations.
4711
8c9afb46
EZ
47122011-11-27 Eli Zaretskii <eliz@gnu.org>
4713
4714 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4715 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4716 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4717 (malloc, free, realloc, calloc): Redirect to e_* only when
4718 compiling Emacs.
4719
4720 * lisp.h (GCTYPEBITS): Move before first use.
4721 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4722 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4723 this macro definition.
4724
4725 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4726 _MSC_VER.
4727
54e9e3bf
JD
47282011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4729
6d5eb5b0
SM
4730 * gtkutil.c (xg_create_frame_widgets):
4731 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4732 present with Gtk+ 2.0.
4733
83aca1cb
PE
47342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 * fileio.c (Finsert_file_contents): Undo previous change; see
4737 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4738
5b76caa4
PE
47392011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4740
4741 Rename locals to avoid shadowing.
4742 * fileio.c (Finsert_file_contents):
4743 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4744 * process.c (wait_reading_process_output):
4745 Rename inner 'proc' to 'p' to avoid shadowing.
4746 Indent for consistency with usual Emacs style.
4747
8c535114
EZ
47482011-11-25 Eli Zaretskii <eliz@gnu.org>
4749
4750 * xdisp.c (redisplay_window): If cursor row is not fully visible
4751 after recentering, and scroll-conservatively is set to a large
4752 number, scroll window by a few more lines to make the cursor fully
4753 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4754 (start_display): Don't move to the next line if the display should
4755 start at a newline that is part of a display vector or an overlay
4756 string. (Bug#10119)
8c535114 4757
fa4fdb5c
JL
47582011-11-24 Juri Linkov <juri@jurta.org>
4759
4760 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4761 after the `MagickPingImage' call. (Bug#10112)
4762
90ec88df
CY
47632011-11-23 Chong Yidong <cyd@gnu.org>
4764
4765 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4766
56e2e794
MR
47672011-11-23 Martin Rudalics <rudalics@gmx.at>
4768
4769 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4770 making another buffer current. (Bug#10114)
4771
b6e64c41
GM
47722011-11-23 Glenn Morris <rgm@gnu.org>
4773
4774 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4775
6b21de18
CY
47762011-11-23 Chong Yidong <cyd@gnu.org>
4777
4778 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4779 using it (Bug#5984).
4780
b12cd789
EZ
47812011-11-22 Eli Zaretskii <eliz@gnu.org>
4782
4783 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4784 and header-lines, as they don't have one computed for them.
4785 (Bug#10098)
4786
4787 * .gdbinit (prow): Make displayed values more self-explaining.
4788 Add row's hash code.
4789
261b6fd4
LMI
47902011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4791
4792 * process.c (wait_reading_process_output): Fix asynchrounous
4793 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4794 (wait_reading_process_output): Add comment and URL.
261b6fd4 4795
e7cfd277
JD
47962011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4797
4798 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4799
a9b9b7f5
CY
48002011-11-21 Chong Yidong <cyd@gnu.org>
4801
4802 * window.c (Fnext_window, Fprevious_window): Doc fix.
4803
b0d15b4f
SM
48042011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4805
4806 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4807
fe7a3057
JB
48082011-11-20 Juanma Barranquero <lekktu@gmail.com>
4809
4810 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4811
d2999b1a
MR
48122011-11-20 Martin Rudalics <rudalics@gmx.at>
4813
4814 * window.c (Fset_window_combination_limit): Rename argument
4815 STATUS to LIMIT.
4816 (Vwindow_combination_limit): Remove "status" from doc-string.
4817
d5ff9cd0
AS
48182011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4819
4820 * m/ibms390.h: Remove.
4821 * m/ibms390x.h: Don't include "ibms390.h".
4822
a5bb9bd3
SM
48232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4824
4825 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4826 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4827
cd1181db
JB
48282011-11-20 Juanma Barranquero <lekktu@gmail.com>
4829
4830 * casetab.c (Fset_case_table):
4831 * charset.c (Fcharset_after): Fix typos.
4832
615a3b8d 48332011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4834
17e845af
PE
4835 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4836 Otherwise, valgrind does not work on some platforms.
4837 Problem reported by Andreas Schwab in
6a0bf43d
PE
4838 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4839 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4840 is set, removing the need for VIRT_ADDRESS_VARIES.
4841 (PURE_P): Use a more-efficient implementation that needs just one
4842 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4843 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4844 to 4 (xorl, subq, cmpq, setbe).
4845 * alloc.c (pure): Always extern now, since that's the
4846 VIRT_ADDR_VARIES behavior.
4847 (PURE_POINTER_P): Use a single comparison, not two, for
4848 consistency with the new puresize.h.
4849 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4850 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4851 Remove VIRT_ADDR_VARIES no longer needed.
4852
f8fe6f96
EZ
48532011-11-19 Eli Zaretskii <eliz@gnu.org>
4854
4855 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4856 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4857 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4858 behave as if the cursor position were at the window margin.
4859
4860 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4861 and the cursor position is out of bounds, behave as if the cursor
4862 position were at the window margin. (Bug#10075)
4863
df05a53c
CY
48642011-11-18 Chong Yidong <cyd@gnu.org>
4865
4866 * window.c (Fwindow_combination_limit): Make first argument
4867 non-optional, since it is meaningless for live windows like the
4868 selected window.
61ccba97 4869
2071918e
DA
48702011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4871
4872 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4873
b50a28de
SM
48742011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4875
4876 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4877 (graft_intervals_into_buffer): Simplify.
4878
015137db
EZ
48792011-11-18 Eli Zaretskii <eliz@gnu.org>
4880
4881 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4882 hash values of the two rows.
4883 (copy_row_except_pointers): Preserve the used[] arrays and the
4884 hash values of the two rows. (Bug#10035)
68c95424 4885 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4886
4887 * xdisp.c (row_hash): New function, body extracted from
4888 compute_line_metrics.
4889 (compute_line_metrics): Call row_hash, instead of computing the
4890 hash code inline.
4891
4892 * dispnew.c (verify_row_hash): Call row_hash for computing the
4893 hash code of a row, instead of duplicating code from xdisp.c.
4894
4895 * dispextern.h (row_hash): Add prototype.
4896
a2addb04
TH
48972011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4898
4899 * frame.c (delete_frame): Don't delete the terminal when the last
4900 X frame is closed if emacs is built with GTK toolkit.
4901
df85d315
JB
49022011-11-17 Juanma Barranquero <lekktu@gmail.com>
4903
4904 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4905
a0c2d0ae
MR
49062011-11-17 Martin Rudalics <rudalics@gmx.at>
4907
4908 * window.c (Vwindow_splits): Rename to
4909 Vwindow_combination_resize. Suggested by Juri Linkov.
4910 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4911 of Vwindow_splits.
4912
58179cce
JB
49132011-11-16 Juanma Barranquero <lekktu@gmail.com>
4914
7877f373
JB
4915 * nsfns.m (Fns_font_name):
4916 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4917
b6f67890
MR
49182011-11-16 Martin Rudalics <rudalics@gmx.at>
4919
4920 * window.h (window): Rename slot "nest" to "combination_limit".
4921 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4922 (Fset_window_nest): Rename to Fset_window_combination_limit.
4923 (Vwindow_nest): Rename to Vwindow_combination_limit.
4924 (recombine_windows, make_parent_window, make_window)
4925 (Fsplit_window_internal, saved_window)
4926 (Fset_window_configuration, save_window_save): Rename all
4927 occurrences of window_nest to window_combination_limit.
4928
c7015153
JB
49292011-11-15 Juanma Barranquero <lekktu@gmail.com>
4930
4931 * image.c (imagemagick_load_image): Fix typo.
4932
322ad6ec
EZ
49332011-11-14 Eli Zaretskii <eliz@gnu.org>
4934
4935 * xdisp.c (display_line): Move the call to
4936 highlight_trailing_whitespace before the call to
4937 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4938 faces of all the glyphs to compute ROW's hash value.
4939 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4940
f067b8ec
JB
49412011-11-14 Juanma Barranquero <lekktu@gmail.com>
4942
4943 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4944 just return (bug#10044).
4945
1e5b2111
EZ
49462011-11-12 Eli Zaretskii <eliz@gnu.org>
4947
7ef3cbd5
EZ
4948 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4949 with user-defined heap size. Bump the default size of the temacs
4950 heap to 27MB, to avoid memory warning when running temacs.
4951 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4952
1e5b2111
EZ
4953 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4954 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4955 (verify_row_hash) [XASSERTS]: New function.
4956 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4957 that the hash value of glyph rows is correct.
1e5b2111 4958
89d61221
MR
49592011-11-12 Martin Rudalics <rudalics@gmx.at>
4960
4961 * window.h (window): Remove splits slot.
4962 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4963 (Fdelete_other_windows_internal, make_parent_window)
4964 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4965 (Fset_window_configuration, save_window_save): Don't deal with
4966 split status of windows.
4967 (saved_window): Remove splits slot.
4968 (Vwindow_splits): Rewrite doc-string.
4969
97f18cc8
JD
49702011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4971
4972 * xfns.c (unwind_create_frame):
4973 * nsfns.m (unwind_create_frame):
4974 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4975 Vframe_list (Bug#9999).
4976
22a648b4
DA
49772011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4978
0b381c7e 4979 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4980
659afede
KH
49812011-11-11 Kenichi Handa <handa@m17n.org>
4982
4983 * callproc.c (Fcall_process): Set the member dst_multibyte of
4984 process_coding.
4985
9ac0394b
KH
49862011-11-11 Johan Bockgård <bojohan@gnu.org>
4987
4988 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4989 avoid a crash (bug#9496).
4990
2fbdc249
CY
49912011-11-09 Chong Yidong <cyd@gnu.org>
4992
4993 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4994 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4995
ac6b1f81
PE
49962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4997
4998 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4999
09db192c
PE
50002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5001
5002 Avoid some portability problems by eschewing 'extern inline' functions.
5003 The trivial performance wins aren't worth the portability hassles; see
5004 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5005 et seq.
5006 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5007 (window_box_width, window_box_left, window_box_left_offset)
5008 (window_box_right, window_box_right_offset): Undo previous change,
5009 by removing the "extern"s.
5010 * intervals.c (adjust_intervals_for_insertion)
5011 (adjust_intervals_for_deletion): Undo previous change,
5012 making these static again.
5013 (offset_intervals, temp_set_point_both, temp_set_point)
5014 (copy_intervals_to_string): No longer inline.
5015 * xdisp.c (window_text_bottom_y, window_box_width)
5016 (window_box_height, window_box_left_offset)
5017 (window_box_right_offset, window_box_left, window_box_right)
5018 (window_box): No longer inline.
5019
105216ed
CY
50202011-11-08 Chong Yidong <cyd@gnu.org>
5021
5022 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5023 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5024 Signal an error if not a live window.
105216ed
CY
5025 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5026 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5027
ae9e237f
JB
50282011-11-07 Juanma Barranquero <lekktu@gmail.com>
5029
5030 * lisp.h (syms_of_abbrev): Remove declaration.
5031 Reported by CHENG Gao <chenggao@royau.me>.
5032
c7aa8333
EZ
50332011-11-07 Eli Zaretskii <eliz@gnu.org>
5034
5035 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5036 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5037 of temacs in GUI mode.
5038
be7f5545
MR
50392011-11-07 Martin Rudalics <rudalics@gmx.at>
5040
5041 * window.h: Declare delete_all_child_windows instead of
5042 delete_all_subwindows.
5043 * window.c (Fwindow_nest, Fset_window_nest)
5044 (Fset_window_new_total, Fset_window_new_normal)
5045 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5046 (delete_all_subwindows): Rename to delete_all_child_windows.
5047 (Fdelete_other_windows_internal, Fset_window_configuration):
5048 Call delete_all_child_windows instead of delete_all_subwindows.
5049 * frame.c (delete_frame): Call delete_all_child_windows instead
5050 of delete_all_subwindows.
5051
ca78dc43
PE
50522011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5053
5054 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5055 This is also needed for porting to any host where GC_MARK_STACK is
5056 not GC_MAKE_GCPROS_NOOPS.
5057 (which_symbols): Use it.
5058
a0241d01
KH
50592011-11-07 Kenichi Handa <handa@m17n.org>
5060
5061 * coding.c (coding_set_destination): Check coding->src_pos only
5062 when coding->src_object is a buffer (bug#9910).
5063
5064 * process.c (send_process): Set the member src_multibyte of coding
5065 to 0 (bug#9911) when sending a unibyte text.
5066
5067 * callproc.c (Fcall_process): Set the member src_multibyte of
5068 process_coding to 0 (bug#9912).
5069
a64bfdfa 50702011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5071
5072 * xmenu.c (cleanup_widget_value_tree): New function.
5073 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5074 calling free_menubar_widget_value_tree directly (Bug#9830).
5075
cb41b32a
PE
50762011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5077
5078 Fix some portability problems with 'inline'.
5079 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5080 (window_box_width, window_box_left, window_box_left_offset)
5081 (window_box_right, window_box_right_offset): Declare extern.
5082 Otherwise, these inline functions do not conform to C99 and
5083 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5084 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5085 * intervals.c (adjust_intervals_for_insertion)
5086 (adjust_intervals_for_deletion): Now extern, because otherwise the
5087 extern inline functions 'offset_intervals' couldn't refer to it.
5088 (static_offset_intervals): Remove.
5089 (offset_intervals): Rewrite using the old contents of
5090 static_offset_intervals. The old version didn't conform to C99
5091 because an extern inline function contained a reference to an
5092 identifier with static linkage.
5093
b7041366
AS
50942011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5095
5096 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5097 GC.
5098
88a37c4d
EZ
50992011-11-06 Eli Zaretskii <eliz@gnu.org>
5100
5101 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5102 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5103 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5104 return Qleft_to_right.
5105
49745b39
CY
51062011-11-06 Chong Yidong <cyd@gnu.org>
5107
5108 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5109 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5110 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5111 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5112 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5113 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5114 (Fwindow_vscroll): Doc fix.
5115 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5116 argument, since it makes no sense to pass a live window and for
5117 consistency with window-child.
5118
1f05cd82
CS
51192011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5120
5121 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5122 support MSVC.
5123
22610910
JR
51242011-11-05 Jason Rumney <jasonr@gnu.org>
5125
5126 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5127 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5128 fonts (Bug#6029).
5129 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5130 bitwise arithmetic preventing use of unicode-sip and non-truetype
5131 opentype fonts.
5132
a06776b2
EZ
51332011-11-05 Eli Zaretskii <eliz@gnu.org>
5134
3ad924ba
EZ
5135 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5136 "emacs"-only part.
5137
a06776b2
EZ
5138 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5139 initialization code to keep similarity to xfns.c after changes
5140 from 2011-11-05.
5141
c9e7db78
JD
51422011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5143
a97f8f3f
JD
5144 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5145 (unwind_create_frame): New function (Bug#9943).
5146 (Fx_create_frame): Restructure code to be more similar to the one in
5147 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5148 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5149 Move terminal->reference_count++ just before making the frame official
5150 (Bug#9943).
5151
5152 * nsterm.m (x_free_frame_resources): New function.
5153 (x_destroy_window): Move code to x_free_frame_resources.
5154
c9e7db78 5155 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5156 (Fx_create_frame, x_create_tip_frame):
5157 Move terminal->reference_count++ just before making the frame
75f1671a 5158 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5159 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5160
a6fc3b5c
EZ
51612011-11-05 Eli Zaretskii <eliz@gnu.org>
5162
5163 Support MSVC build with newer versions of Visual Studio.
5164 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5165 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5166 nt/gmake.defs.
5167
5168 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5169 which are not supported by MSVC.
5170 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5171 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5172 bitfields.
5173 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5174 types in bitfields.
5175 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5176
5177 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5178
58179cce 51792011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5180
5181 Support MSVC build with newer versions of Visual Studio.
5182 * w32.c: Don't include w32api.h for MSVC.
5183 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5184
5185 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5186 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5187 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5188 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5189 e_* cousins.
5190 (alloca) [_MSC_VER]: Define to _alloca.
5191
5192 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5193
5194 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5195
a58c13ed
EZ
51962011-11-04 Eli Zaretskii <eliz@gnu.org>
5197
5198 * xdisp.c (note_mouse_highlight): If either of
5199 previous/next-single-property-change returns nil, treat that as
5200 the beginning or the end of the buffer. (Bug#9955)
5201
fe0b6370
JD
52022011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5203
a58c13ed 5204 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5205 label is not null (Bug#9951).
5206 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5207 may be NULL.
5208
89bd5ee1
EZ
52092011-11-04 Eli Zaretskii <eliz@gnu.org>
5210
5211 * window.c (Fwindow_body_size): Mention in the doc string that the
5212 return value is in frame's canonical units. (Bug#9949)
5213
84c3edb9
EZ
52142011-11-03 Eli Zaretskii <eliz@gnu.org>
5215
4e2fb5c7
EZ
5216 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5217
84c3edb9 5218 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5219 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5220 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5221
bc17a887
EZ
52222011-11-01 Eli Zaretskii <eliz@gnu.org>
5223
5224 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5225 Don't stop backward scan on the continuation glyph, even though
5226 its CHARPOS is positive.
6d5eb5b0
SM
5227 (mouse_face_from_buffer_pos, note_mouse_highlight):
5228 Rename cover_string to disp_string.
bc17a887 5229
4ee88440
MR
52302011-11-01 Martin Rudalics <rudalics@gmx.at>
5231
5232 * window.c (temp_output_buffer_show): Don't use
5233 Vtemp_buffer_show_specifiers.
5234 (Vtemp_buffer_show_specifiers): Remove unused variable.
5235
c2ff3c02
EZ
52362011-10-30 Eli Zaretskii <eliz@gnu.org>
5237
5238 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5239 past the beginning of the current glyph matrix.
5240
58179cce 52412011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5242
5243 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5244 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5245 HAVE_GTK3 (Bug#9869).
b77a6a7f 5246
3b574623
JD
5247 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5248 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5249
b77a6a7f
JD
5250 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5251
5252 * xterm.c: Declare x_handle_net_wm_state to return int.
5253 (handle_one_xevent): Check if we are iconified but don't have
5254 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5255 (get_current_wm_state): Return non-zero if not hidden,
5256 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5257 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5258 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5259 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5260
196e41e4
PE
52612011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5262
5263 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5264 so that this new function doesn't get optimized away by a
5265 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5266
021f2e1a
AS
52672011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5268
5269 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5270
8b058d44
EZ
52712011-10-29 Eli Zaretskii <eliz@gnu.org>
5272
5273 Fix the `xbytecode' command.
5274 * .gdbinit (xprintbytestr): New command.
b50a28de 5275 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5276 (xbytecode): Print the byte-code string as well.
5277
4452fb80
EZ
52782011-10-29 Kim Storm <storm@cua.dk>
5279
8b058d44
EZ
5280 * alloc.c (which_symbols): New function.
5281
21b72067
AS
52822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5283
5284 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5285 line. (Bug#9903)
5286
83ed7b5c
GM
52872011-10-29 Glenn Morris <rgm@gnu.org>
5288
5289 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5290 Not clear what it was for, and it causes various bugs. (Bug#9839)
5291
5a7a728b
EZ
52922011-10-28 Eli Zaretskii <eliz@gnu.org>
5293
5294 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5295 possible random value that matches one of those tested as
5296 condition to clear the mouse face.
5297
d3d0842f
CY
52982011-10-28 Chong Yidong <cyd@gnu.org>
5299
5300 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5301
31b39d13
DN
53022011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5303
5304 * window.c (make_window): Initialize phys_cursor_on_p.
5305
9aba6043
SM
53062011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5307
5308 * lisp.h (struct Lisp_Symbol): Update comments.
5309
c20992f4
JB
53102011-10-28 Juanma Barranquero <lekktu@gmail.com>
5311
5312 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5313
db4f02f2
EZ
53142011-10-28 Eli Zaretskii <eliz@gnu.org>
5315
5316 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5317 <oslsachem@gmail.com> for helping to debug this.
5318
5319 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5320 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5321 (g_b_init_get_glyph_outline_w): New static variables.
5322 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5323 (GetGlyphOutlineW_Proc): New typedefs.
5324 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5325 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5326 New functions.
5327 (w32font_open_internal, compute_metrics):
5328 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5329 instead of calling the "wide" APIs directly.
5330
5331 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5332
5333 * w32.h (syms_of_w32font): Add prototype.
5334
87e68db4
JB
53352011-10-27 Juanma Barranquero <lekktu@gmail.com>
5336
5337 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5338 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5339 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5340 (Fmove_to_window_line): Doc fix.
5341
435c1d67
CY
53422011-10-27 Chong Yidong <cyd@gnu.org>
5343
5344 * process.c (make_process): Set gnutls_state to NULL.
5345
5346 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5347 non-NULL, regardless of GNUTLS_INITSTAGE.
5348 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5349 an error. Set process slots as soon as we allocate them.
5350
5351 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5352
9c6c6f49
CY
53532011-10-27 Chong Yidong <cyd@gnu.org>
5354
9aba6043
SM
5355 * gnutls.c (emacs_gnutls_deinit): New function.
5356 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5357 (Fgnutls_deinit, Fgnutls_boot): Use it.
5358
5359 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5360 (deactivate_process): Call emacs_gnutls_deinit.
5361
657d08d3
JB
53622011-10-27 Juanma Barranquero <lekktu@gmail.com>
5363
5364 * image.c (x_create_x_image_and_pixmap):
5365 * w32.c (sys_rename, w32_delayed_load):
5366 * w32font.c (fill_in_logfont):
5367 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5368
5430d399
JB
53692011-10-26 Juanma Barranquero <lekktu@gmail.com>
5370
5371 * w32fns.c (w32_default_color_map): New function,
5372 extracted from Fw32_default_color_map.
a7ef684b 5373 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5374
fe0055fa
PE
53752011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5376
5377 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5378
e6346438
SM
53792011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5380
5381 * keyboard.c (test_undefined): New function (bug#9751).
5382 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5383
e112cc37
ET
53842011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5385
5386 * sysdep.c (init_sys_modes): Fix the check for the controlling
5387 terminal (Bug#6649).
5388
7b5d6677
EZ
53892011-10-20 Eli Zaretskii <eliz@gnu.org>
5390
5391 * dispextern.h (struct bidi_it): New member next_en_type.
5392
5393 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5394 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5395 current character, check also for next_en_type being WEAK_EN.
5396 (bidi_resolve_weak): Don't enter the expensive loop if the current
5397 position is before next_en_pos. Record the bidi type of the first
5398 non-ET, non-BN character we find, in addition to its position.
5399 (bidi_level_of_next_char): Invalidate next_en_type when
5400 next_en_pos is over-stepped.
5401
7da0b018
PE
54022011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5403
5404 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5405 * editfns.c: Rewrite current-time-zone so that it invokes
5406 the equivalent of (format-time-string "%Z") to get the time zone name.
5407 This fixes a bug when the time zone name contains characters that
5408 need converting from the system time locale to Emacs internal format.
5409 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5410 that patch fixed format-time-string to do the conversion, but
5411 I forgot to fix current-time-zone.
5412 (format_time_string): New function, containing most of
5413 what Fformat_time_string used to contain.
5414 (Fformat_time_string): Rewrite in terms of format_time_string.
5415 This doesn't change this function's behavior.
5416 (current-time-zone): Rewrite to use format_time_string.
5417 This fixes the bug reported by Michael Schierl in
5418 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5419 Jason Rumney's 2007-06-07 change worked around this bug, but
5420 didn't fix it.
5421 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5422
8547b010
EZ
54232011-10-19 Eli Zaretskii <eliz@gnu.org>
5424
5425 * xdisp.c (start_display): If the character at POS is displayed
5426 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5427 (try_window_reusing_current_matrix): If a line ends in a display
5428 vector or the next line starts in a display vector, continue
5429 redrawing the window even though the character position of
5430 start_row was reached.
8547b010
EZ
5431 (Bug#9771, part 2)
5432
4e948d15
CY
54332011-10-18 Chong Yidong <cyd@gnu.org>
5434
5435 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5436 with nobreak-char-display too.
5437
4787455f
EZ
54382011-10-18 Eli Zaretskii <eliz@gnu.org>
5439
5440 Fix part 3 of bug#9771.
5441 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5442 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5443 non-neutral characters if the current character is a paragraph
5444 separator (a.k.a. Newline). This avoids running the same
5445 expensive loop twice, once when we consume the preceding newline
5446 and the other time when the line actually needs to be displayed.
5447 Avoid the loop when we see neutrals on the base embedding level
5448 following a character whose directionality is the same as the
5449 paragraph's. This avoids running the expensive loop when a line
5450 ends in a long sequence of neutrals, like control characters.
5451 Add assertion against STRONG_AL type. Slightly rearrange code
5452 that determines the type of a neutral given the first non-neutral
5453 that follows it.
5454 (bidi_level_of_next_char): Set next_en_pos to zero when
5455 invalidating its info.
5456
2c91f553
EZ
54572011-10-17 Eli Zaretskii <eliz@gnu.org>
5458
5459 * xdisp.c (push_display_prop): Determine whether to record string
5460 or buffer position by IT->string, not by IT->method. Allow
5461 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5462 (move_it_vertically_backward): Don't look for character position
5463 immediately after the newline when in a continuation line.
5464 (Bug#9771, part 1)
2c91f553 5465
c7b08b0d
MR
54662011-10-15 Martin Rudalics <rudalics@gmx.at>
5467
5468 * window.c (coordinates_in_window): Rewrite and delabelize
5469 vertical border check. (Bug#5357) (Bug#9618)
5470
6b02f655
SM
54712011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5472
5473 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5474 errors in XSetWindowBorder (bug#9310).
5475
81d40c92
DA
54762011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5477
5478 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5479 avoid crash when xmalloc overrun checking is enabled.
5480
d4172c3b
EZ
54812011-10-13 Eli Zaretskii <eliz@gnu.org>
5482
5483 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5484 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5485 cursor motion with <left> and <right> arrow keys.
5486
5487 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5488 some callers set that themselves.
5489
b00eea75
EZ
54902011-10-12 Eli Zaretskii <eliz@gnu.org>
5491
5492 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5493 display string and the previous row comes from the same string and
5494 is empty. (Bug#9739) (Bug#9738)
5495
8fe012c4
SM
54962011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5497
5498 * doc.c (get_doc_string): Encode file name (bug#9735).
5499
0074aef2
EZ
55002011-10-12 Eli Zaretskii <eliz@gnu.org>
5501
79beb178
EZ
5502 * bidi.c (bidi_level_of_next_char):
5503 * xdisp.c (get_visually_first_element): Remove old incorrect
5504 comments regarding the Unicode Line Separator character.
5505
0074aef2
EZ
5506 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5507
6e4b3fbe
DA
55082011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5509
5510 * alloc.c (Fgc_status): Do not access beyond zombies array
5511 boundary if nzombies > MAX_ZOMBIES.
5512 * alloc.c (dump_zombies): Add missing format specifier.
5513
0324f3af
PE
55142011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5515
b5525cac
PE
5516 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5517 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5518
0324f3af
PE
5519 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5520 Some packages use them to denote characters with modifiers.
5521
e9b5f888
AS
55222011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5523
5524 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5525 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5526 matching a pp-number. Rename parameter var to var1.
5527
127827c0
SM
55282011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5529
5530 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5531
c8fd3bd0
GM
55322011-10-08 Glenn Morris <rgm@gnu.org>
5533
5534 * callint.c (Fcall_interactively): Give a more explicit error for the
5535 'c' case with a non-character input. (Bug#8479)
5536
352ec8ff
EZ
55372011-10-08 Eli Zaretskii <eliz@gnu.org>
5538
03669ccb
EZ
5539 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5540 lines.
7061c986
EZ
5541 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5542 lines that are hscrolled on the left.
03669ccb 5543
352ec8ff
EZ
5544 * dispnew.c (buffer_posn_from_coords): Account for a possible
5545 presence of header-line. (Bug#4426)
5546
a66cfb1c
SM
55472011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5548
6b02f655
SM
5549 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5550 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5551
7c5ee88e
PE
55522011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5553
5554 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5555 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5556 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5557 this makes Emacs dump core during garbage collection on rare
5558 occasions. sizeof is obviously inferior to offsetof here, so
5559 stick with offsetof.
5560 (GC_POINTER_ALIGNMENT): New macro.
5561 (mark_memory): Omit 3rd (offset) arg; caller changed.
5562 Don't assume EMACS_INT alignment is the same as pointer alignment.
5563
df1bbe5b
SM
55642011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5565
5566 * keyboard.c (read_key_sequence_remapped): New var.
5567 (read_key_sequence): Compute remapping in the right buffer.
5568 (command_loop_1): Use read_key_sequence's remapping directly.
5569
51553db6
SM
55702011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5571
32c1fffd
SM
5572 * dired.c (file_name_completion): Don't expand file name.
5573 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5574 before checking file name handler.
5575
51553db6
SM
5576 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5577 they've been requested explicitly (bug#9591).
5578
b6bd1599 55792011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5580
5581 * keymap.c (Fsingle_key_description): Use make_specified_string
5582 instead of build_string to build string from push_key_description.
5583 (Bug#5193)
5584
f701dc2a
PE
55852011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5586
4222c55d
PE
5587 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5588 This fixes a Y2038 bug on 64-bit hosts.
5589 * buffer.c (reset_buffer):
5590 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5591 (Fclear_buffer_auto_save_failure):
5592 Use 0, not -1, to represent an unset failure time, since time_t
5593 might not be signed.
5594
f701dc2a
PE
5595 Remove dependency on glibc malloc internals.
5596 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5597 Move back here from lisp.h, but with their new implementations.
5598 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5599 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5600 * charset.c (charset_table_init): New static var.
5601 (syms_of_charset): Use it instead of xmalloc. This removes a
5602 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5603 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5604 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5605 Move back to alloc.c.
5606 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5607 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5608
9ceebf39
JD
56092011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5610
5611 * nsterm.m (windowDidResize): Call x_set_window_size only when
5612 ns_in_resize is true. Otherwise set pixelwidth/height and
5613 call change_frame_size (Bug#9628).
5614
cb993c58
PE
56152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5616
3930c88b
PE
5617 Port --enable-checking=all to Fedora 14 x86-64.
5618 * charset.c (syms_of_charset): Also account for glibc malloc's
5619 internal overhead when calculating the initial malloc maximum.
5620
cb993c58
PE
5621 Port --enable-checking=all to Fedora 14 x86.
5622 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5623 Move to lisp.h.
5624 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5625 (overrun_check_realloc, overrun_check_free):
5626 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5627 That way, xmalloc returns a properly-aligned pointer even if
5628 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5629 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5630 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5631 into account when calculating the initial malloc maximum.
5632 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5633 Move here from alloc.c, so that charset.c can use it too.
5634 Properly align; the old code wasn't right for common 32-bit hosts
5635 when configured with --enable-checking=all.
5636 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5637 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5638
31bed486
EZ
56392011-09-29 Eli Zaretskii <eliz@gnu.org>
5640
04c70788 5641 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5642 use EDOM.
5643
fbcaa2f3
EZ
56442011-09-28 Eli Zaretskii <eliz@gnu.org>
5645
5646 * xdisp.c (compute_display_string_end): If there's no display
5647 string at CHARPOS, return -1.
5648
5649 * bidi.c (bidi_fetch_char): When compute_display_string_end
5650 returns a negative value, treat the character as a normal
5651 character not covered by a display string. (Bug#9624)
5652
a239d4e9
JB
56532011-09-28 Juanma Barranquero <lekktu@gmail.com>
5654
5655 * lread.c (Fread_from_string): Fix typo in docstring.
5656
88652fd5
EZ
56572011-09-27 Eli Zaretskii <eliz@gnu.org>
5658
5659 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5660 newline, reseat the iterator instead of bidi-iterating there one
5661 character at a time. (Bug#9610)
32c1fffd
SM
5662 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5663 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5664
ed497dd4
AS
56652011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5666
5667 * lread.c (readevalloop): Use correct code for NBSP.
5668 (read1): Likewise. (Bug#9608)
5669
b2bf61aa
MA
56702011-09-25 Michael Albinus <michael.albinus@gmx.de>
5671
5672 * dbusbind.c (Fdbus_register_signal): When service is not
5673 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5674
32bbb17c
GM
56752011-09-25 Glenn Morris <rgm@gnu.org>
5676
5677 * buffer.c (truncate-lines): Doc fix.
5678
94e0933e
CY
56792011-09-24 Chong Yidong <cyd@stupidchicken.com>
5680
5681 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5682 (Fset_window_next_buffers): Doc fix.
5683
cddde921
GM
56842011-09-24 Glenn Morris <rgm@gnu.org>
5685
5686 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5687
1260aef1
PE
56882011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5689
25b4bfa0
PE
5690 Fix minor problems found by static checking.
5691 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5692 * indent.c (Fvertical_motion): Fix == vs = typo.
5693
e3cbd34b
EZ
56942011-09-24 Eli Zaretskii <eliz@gnu.org>
5695
a66cfb1c
SM
5696 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5697 Default value is now t. Doc fix.
6bf7006f 5698
e3cbd34b 5699 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5700 logic when moving up, not only when moving down. Fix the
e3cbd34b 5701 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5702 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5703
5704 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5705 CHARPOS is covered by a display string which includes newlines.
5706 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5707 is covered by a display string with embedded newlines.
5708
a3de0cbd
MA
57092011-09-24 Michael Albinus <michael.albinus@gmx.de>
5710
5711 * dbusbind.c (Fdbus_register_signal): Add match rule to
5712 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5713 (Fdbus_register_method, Vdbus_registered_objects_table):
5714 Fix docstring.
a3de0cbd 5715
b260039d
JM
57162011-09-24 Jim Meyering <meyering@redhat.com>
5717
32c1fffd 5718 do not ignore write error for any output size
b260039d
JM
5719 The previous change was incomplete.
5720 While it makes emacs --batch detect the vast majority of stdout
5721 write failures, errors were still ignored whenever the output size is
5722 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5723 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5724 && echo FAIL: ignored write error
5725 FAIL: ignored write error
5726 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5727 && echo FAIL: ignored write error
5728 FAIL: ignored write error
5729 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5730
8eca8a7c
AS
57312011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5732
5733 * emacs.c (Fkill_emacs): In noninteractive mode exit
5734 non-successfully if a write error occurred on stdout. (Bug#9574)
5735
3341db62
EZ
57362011-09-21 Eli Zaretskii <eliz@gnu.org>
5737
5738 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5739 the xassert test.
5740
5741 * dispextern.h (struct it): Update the comment documenting what
5742 can it->OBJECT be.
5743
8c203dbf
EZ
57442011-09-20 Eli Zaretskii <eliz@gnu.org>
5745
5746 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5747 a display string, extend search for cursor position to end of row.
5748 (find_row_edges): If the row ends in a newline from a display
5749 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5750 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5751 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5752 non-empty line. Fixes confusing cursor motion with arrow keys at
5753 the beginning of a line that starts with whitespace.
8c203dbf 5754
a4824228
LMI
57552011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5756
5757 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5758 (bug#9493).
5759
33ed493b
CY
57602011-09-18 Chong Yidong <cyd@stupidchicken.com>
5761
5762 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5763 boolean (Bug#9154).
5764
56cd55c8
EZ
57652011-09-18 Eli Zaretskii <eliz@gnu.org>
5766
5767 * xdisp.c (display_line): Record maximum and minimum buffer
5768 positions even if no glyphs were produced (e.g., by a zero-width
5769 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5770 buffer positions that will be removed from the glyph row because
5771 they don't fit.
c02dcedf
EZ
5772 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5773 column is beyond frame width: don't subtract 1 "pixel" when
5774 computing width of the stretch.
3e62b7e0
EZ
5775 (reseat_at_next_visible_line_start): Undo the change made on
5776 2011-09-17 that saved paragraph information and restored it after
5777 the call to `reseat'. (Bug#9545)
56cd55c8 5778
5ed99d36 57792011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5780
5781 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5782 and turn window cursor on if cleared (Bug#9415).
5783
5ed99d36 57842011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5785
5786 * search.c (boyer_moore): Take unibyte characters from pattern
5787 literally. (Bug#9458)
5788
9bade7b2
EZ
57892011-09-18 Eli Zaretskii <eliz@gnu.org>
5790
5791 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5792
e5e9d610
PE
57932011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5794
87e4427a
PE
5795 Fix minor problem found by static checking.
5796 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5797 initialized, to pacify gcc -Wuninitialized.
5798
e5e9d610
PE
5799 * fileio.c: Report proper errno when syscall falls.
5800 (Finsert_file_contents): Save and restore errno,
5801 so that report_file_error outputs the correct diagnostic.
5802 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5803
a1674f0b
EZ
58042011-09-18 Eli Zaretskii <eliz@gnu.org>
5805
5806 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5807
fbfb6dd4
EZ
58082011-09-17 Eli Zaretskii <eliz@gnu.org>
5809
5810 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5811 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5812
bb187662
EZ
58132011-09-17 Eli Zaretskii <eliz@gnu.org>
5814
1137e8b8 5815 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5816 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5817
5818 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5819 (bidi_find_paragraph_start): Search back for paragraph beginning
5820 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5821 (bidi_move_to_visually_next): Only trigger paragraph-related
5822 computations when the last character is a newline or at EOB, not
5823 just any NEUTRAL_B. (Bug#9470)
5824
bb187662
EZ
5825 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5826 truncated lines if point is covered by a display string. (Bug#9524)
5827
2e621251
PE
58282011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5829
5830 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5831 (cons_to_x_long): New function.
5832 (lisp_data_to_selection_data): Use it. Correct the test for
5833 short-versus-long data; it was negated. Break out of vector
5834 loop, for efficiency, when a long datum is discovered.
5835
91a15bc6
SM
58362011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5837
5838 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5839
b41c3a35
EZ
58402011-09-16 Eli Zaretskii <eliz@gnu.org>
5841
5842 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5843 GCC PR/17406) by declaring this function with external scope.
5844
7812ba2d
PE
58452011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5846
5847 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5848 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5849
cf7edc2a
AS
58502011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5851
5852 * editfns.c (Fformat): Correctly handle text properties on "%%".
5853
bd01620e
EZ
58542011-09-15 Eli Zaretskii <eliz@gnu.org>
5855
5856 * xterm.c (x_draw_composite_glyph_string_foreground):
5857 * w32term.c (x_draw_composite_glyph_string_foreground):
5858 * term.c (encode_terminal_code):
5859 * composite.c (composition_update_it, get_composition_id):
5860 * xdisp.c (get_next_display_element)
5861 (fill_composite_glyph_string): Add comments about special meaning
5862 of TAB characters in a composition.
5863
a02719a3
PE
58642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5865
5866 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5867 This occurs when processing a multibyte format.
5868 Problem reported by Wolfgang Jenker.
a02719a3 5869
72589a3c
JB
58702011-09-15 Johan Bockgård <bojohan@gnu.org>
5871
5872 * xdisp.c (try_cursor_movement): Only check for exact match if
5873 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5874
1c14176c
PE
58752011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5876
5877 Remove unused external symbols.
5878 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5879 * xdisp.c (calc_pixel_width_or_height): Now static.
5880 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5881 * indent.c (check_display_width):
5882 * w32term.c: Fix comment to match code.
5883 * xterm.c, xterm.h (x_catching_errors): Remove.
5884
d2eea5b5
PE
58852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5886
5887 * xselect.c: Use signed conversions more consistently (Bug#9498).
5888 (selection_data_to_lisp_data): Assume incoming selection data are
5889 signed integers, not unsigned. This is to be consistent with
5890 outgoing selection data, which was modified to use signed integers
5891 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5892 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5893 expects long, not unsigned long.
5894
46888499
EZ
58952011-09-14 Eli Zaretskii <eliz@gnu.org>
5896
5897 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5898 computation of loop end. Reported by Johan Bockgård
5899 <bojohan@gnu.org>.
5900
ef8ef9fb
CY
59012011-09-13 Chong Yidong <cyd@stupidchicken.com>
5902
5903 * frame.c (Fother_visible_frames_p): Function deleted.
5904
fa819fed
EZ
59052011-09-12 Eli Zaretskii <eliz@gnu.org>
5906
5907 * indent.c (compute_motion): Process display vector front to back
5908 rather than the other way around. (Bug#2496)
5909
2ba8e008
SM
59102011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5911
5912 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5913
20f53c69
CY
59142011-09-11 Chong Yidong <cyd@stupidchicken.com>
5915
5916 * minibuf.c (Fread_from_minibuffer): Doc fix.
5917
d562d7a4
EZ
59182011-09-11 Eli Zaretskii <eliz@gnu.org>
5919
5920 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5921 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5922
1c4d7f3d
LMI
59232011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5924
5925 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5926 value for non-existent files.
5927
b885bf36
EZ
59282011-09-11 Eli Zaretskii <eliz@gnu.org>
5929
5930 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5931 set its "size" to -1. This will set the modtime_size field of
5932 the corresponding buffer to -1, which is what
5933 verify-visited-file-modtime expects for files that do not exist.
5934 (Bug#9139)
5935
6612f0bf
PE
59362011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5939 here ...
5940 * lisp.h: ... from here. push_key_description is no longer
5941 defined in keyboard.c, so its declaration should not be in
5942 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5943 logically belongs with push_key_description.
5944
dfb3f755
PE
59452011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5946
5947 * buffer.h: Include <sys/types.h> instead of <time.h>.
5948 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5949 Problem reported by Herbert J. Skuhra.
5950
3134906c
LMI
59512011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5952
5953 * xml.c (parse_region): Make the parsing work for
5954 non-comment-starting XML files again (bug#9144).
5955
8d903f4e
AS
59562011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5957
5958 * image.c (gif_load): Fix calculation of bottom and right corner.
5959 (Bug#9468)
5960
80ad64f4
EZ
59612011-09-10 Eli Zaretskii <eliz@gnu.org>
5962
5963 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5964 redisplay in small windows.
5965
208a048d
EZ
59662011-09-09 Eli Zaretskii <eliz@gnu.org>
5967
5968 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5969
9b1c252e
MR
59702011-09-08 Martin Rudalics <rudalics@gmx.at>
5971
5972 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5973 Operate on live windows only.
5974
2949f33b
JB
59752011-09-08 Juanma Barranquero <lekktu@gmail.com>
5976
5977 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5978
e08dcafd
EZ
59792011-09-07 Eli Zaretskii <eliz@gnu.org>
5980
5981 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5982 only under bidi iteration.
5983
115b96bd
JD
59842011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5985
5986 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5987
c8199d0f
PE
59882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5989
5990 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5991 Without this fix, the command to link temacs failed due to an
5992 undefined symbol __builtin_isnan. This is because
5993 /usr/include/iso/math_c99.h #defines isnan(x) to
5994 __builtin_isnan(x), but the bundled gcc, which identifies itself
5995 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5996 a __builtin_isnan.
5997 * floatfns.c (isnan): #undef, and then #define to a clone of
5998 what's in data.c.
5999 (Fisnan): Always define, since it's always available now.
6000 (syms_of_floatfns): Always define isnan at the Lisp level.
6001
e39b275c 60022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6003
6004 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6005
b2db44d9 60062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6007
f4af5137 6008 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6009 The previous code assumed that file offsets (off_t values) fit in
6010 EMACS_INT variables, which is not true on typical 32-bit hosts.
6011 The code messed up by falsely reporting buffer overflow in cases
6012 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6013 when "big" contains more than 2**29 bytes, even though this
6014 inserts just one byte and does not overflow the buffer.
6015 (Finsert_file_contents): Store file offsets as off_t
6016 values, not as EMACS_INT values. Check for overflow when
6017 converting between EMACS_INT and off_t. When checking for
6018 buffer overflow or for overlap, take the offsets into account.
6019 Don't use EMACS_INT for small values where int suffices.
6020 When checking for overlap, fix a typo: ZV was used where
6021 ZV_BYTE was intended.
6022 (Fwrite_region): Don't assume off_t fits into 'long'.
6023 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6024
ecfc0a49
MA
60252011-09-05 Michael Albinus <michael.albinus@gmx.de>
6026
6027 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6028
6511acf2 60292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6030
0999621a 6031 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6032
6033 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6034 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6035 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6036 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6037 (modify_event_symbol): Do not assume that the length of
6038 name_alist_or_stem is safe to alloca and fits in int.
6039 (Fexecute_extended_command): Likewise for function name and binding.
6040 (Frecursion_depth): Wrap around reliably on integer overflow.
6041 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6042 since some callers pass EMACS_INT values.
6043 (Fsingle_key_description): Don't crash if symbol name contains more
6044 than MAX_ALLOCA bytes.
6045 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6046 (get_minibuffer): Arg is now EMACS_INT, not int.
6047 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6048 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6049 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6050
2be7d702
PE
6051 * dbusbind.c (signature_cat): New function.
6052 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6053 Do not overrun buffer; instead, report string overflow.
6054
9d1df220
PE
6055 * dispnew.c (add_window_display_history): Don't overrun buffer.
6056 Truncate instead; this is OK since it's just a log.
6057
33ef5c64
PE
6058 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6059 even if the time zone offset is outlandishly large.
6060 Don't mishandle offset == INT_MIN.
6061
66c6fdd5
PE
6062 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6063 when creating daemon; the previous buffer-overflow check was incorrect.
6064
d749b01b
PE
6065 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6066 which has the guts of the old verror function.
6067
b5cd1905
PE
6068 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6069 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6070
6e1a67fb
PE
6071 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6072 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6073 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6074 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6075 length of string rather than counting it via multiple sprintfs;
6076 that's simpler and more reliable.
c21721cc
PE
6077 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6078 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6079 sprintf, in case result does not fit in int.
6080
c57b67fc
PE
6081 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6082 (fontset_from_font): Print it.
6083
8a401434
PE
6084 * frame.c (tty_frame_count): Now printmax_t, not int.
6085 (make_terminal_frame, set_term_frame_name): Print it.
6086 (x_report_frame_params): In X, window IDs are unsigned long,
6087 not signed long, so print them as unsigned.
6088 (validate_x_resource_name): Check for implausibly long names,
6089 and don't assume name length fits in 'int'.
6090 (x_get_resource_string): Don't blindly alloca invocation name;
6091 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6092 not fit in int.
6093
6e1a67fb
PE
6094 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6095 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6096 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6097
0df02bf3
PE
6098 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6099 Use esprintf, not sprintf, in case result does not fit in int.
6100
48e30793
PE
6101 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6102 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6103 it as a large positive number.
6104 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6105 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6106
a66ff6d8
PE
6107 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6108 in case result does not fit in int.
6109
aca216ff
PE
6110 * print.c (float_to_string): Detect width overflow more reliably.
6111 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6112 buffer overrun. Don't assume list length fits in 'int'. Treat
6113 print length of 0 as 0, not as infinity; to be consistent with other
6114 uses of print length in this function. Don't overflow print length
6115 index. Don't assume hash table size fits in 'long', or that
6116 vectorlike size fits in 'unsigned long'.
6117
31c286f7
PE
6118 * process.c (make_process): Use printmax_t, not int, to format
6119 process-name gensyms.
6120
55e5faa1
PE
6121 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6122
80f2e268
PE
6123 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6124 to avoid potential buffer overrun.
6125
670741ab
PE
6126 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6127 if X resource line is longer than 512 bytes.
6128
b7163a50
PE
6129 * xfns.c (x_window): Make sprintf buffer a bit bigger
6130 to avoid potential buffer overrun.
6131
ae58ff1f
PE
6132 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6133
c43c8a6a
PE
6134 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6135
3f8236f4
PE
61362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6137
53e9fe90 6138 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6139 Without these, Emacs silently mishandles large integers sometimes.
6140 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6141 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6142
6511acf2
PE
6143 * xdisp.c (try_window_id): Check Emacs fixnum range before
6144 converting to 'int'.
806add1d 6145
6511acf2 6146 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6147 Check that an Emacs fixnum is in range before assigning it to 'int'.
6148 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6149 values converted from Emacs fixnums.
6150 (Frecenter): Don't wrap around a line count if it is out of 'int'
6151 range; instead, treat it as an extreme value.
6152 (Fset_window_configuration, compare_window_configurations):
6153 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6154
6511acf2
PE
6155 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6156 that can exceed INT_MAX. Check that EMACS_INT value is in range
6157 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6158 (match_limit): Don't assume that a fixnum can fit in 'int'.
6159
6511acf2 6160 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6161 exceed INT_MAX.
6162
6511acf2 6163 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6164 (Fvertical_motion): Don't wrap around LINES values that don't fit
6165 in 'int'. Instead, treat them as extreme values. This is good
6166 enough for windows, which can't have more than INT_MAX lines anyway.
6167
fcb901a7
LMI
61682011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6169
0f2f6b6d
LMI
6170 * Require libxml/parser.h to avoid compilation warning.
6171
fcb901a7
LMI
6172 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6173
6174 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6175 since this reportedly can destroy thread storage.
6176
6e20a0d4
CY
61772011-08-30 Chong Yidong <cyd@stupidchicken.com>
6178
6179 * syntax.c (find_defun_start): Update all cache variables if
6180 exiting early (Bug#9401).
6181
148ae00e
EZ
61822011-08-30 Eli Zaretskii <eliz@gnu.org>
6183
f6cfbd8f
EZ
6184 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6185
148ae00e
EZ
6186 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6187 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6188 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6189
6190 * term.c (tty_append_glyph): New function.
6191 (produce_stretch_glyph): Static function and its prototype deleted.
6192
a66cfb1c
SM
6193 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6194 Add prototypes.
148ae00e 6195
c4a07a4c
PE
61962011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6197
6198 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6199 when checking :margin (Bug#9390).
6200 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6201 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6202 so that the name doesn't mislead. All uses changed.
6203
6bc8cd65
JB
62042011-08-28 Johan Bockgård <bojohan@gnu.org>
6205
6206 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6207 set_tty_hooks.
6208
dca4927e
EZ
62092011-08-27 Eli Zaretskii <eliz@gnu.org>
6210
6211 * xdisp.c (move_it_to): Don't bail out early when reaching
6212 position beyond to_charpos, if we are scanning backwards.
6213 (move_it_vertically_backward): When DY == 0, make sure we get to
6214 the first character in the line after the newline.
6215
f2cad773
PE
62162011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6217
6218 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6219 (ccl_driver): Do not generate an out-of-range pointer.
6220 (Fccl_execute_on_string): Remove unnecessary check for
6221 integer overflow, noted by Stefan Monnier in
6222 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6223 Remove a FIXME that didn't need fixing.
6224 Simplify the newly-introduced buffer reallocation code.
6225
0cae2cdb
JB
62262011-08-27 Juanma Barranquero <lekktu@gmail.com>
6227
6228 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6229
5fc295a4 62302011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6231
70c60eb2 6232 Integer and memory overflow issues (Bug#9196).
726e0ab1 6233
d31850da
PE
6234 * doc.c (get_doc_string): Rework so that
6235 get_doc_string_buffer_size is the actual buffer size, rather than
6236 being 1 less than the actual buffer size; this makes xpalloc more
6237 convenient.
6238
a69fbedb
PE
6239 * image.c (x_allocate_bitmap_record, cache_image):
6240 * xselect.c (Fx_register_dnd_atom):
6241 Simplify previous changes by using xpalloc.
6242
fe5c5d37
PE
6243 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6244 since either will do and ptrdiff_t is convenient with xpalloc.
6245
0065d054
PE
6246 * charset.c (charset_table_size)
6247 (struct charset_sort_data.priority): Now ptrdiff_t.
6248 (charset_compare): Don't overflow if priorities differ greatly.
6249 (Fsort_charsets): Don't assume list length fits in int.
6250 Check for size-calculation overflow when allocating sort data.
6251 (syms_of_charset): Allocate an initial charset table that is
6252 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6253
6254 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6255
6256 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6257 The actual value is always <= INT_MAX, and leaving it unsigned made
6258 overflow checking harder.
6259
6260 * dispextern.h (struct glyph_matrix.rows_allocated)
6261 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6262 with xpalloc. The values are still always <= INT_MAX.
6263
6264 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6265
6266 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6267 (SAFE_NALLOCA): New macro.
6268
6269 * region-cache.c (struct boundary.pos, find_cache_boundary)
6270 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6271 (set_cache_region, invalidate_region_cache)
6272 (revalidate_region_cache, know_region_cache, region_cache_forward)
6273 (region_cache_backward, pp_cache):
6274 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6275 so that ptrdiff_t * can be passed to xpalloc.
6276 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6277 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6278 (pp_cache): Don't assume cache_len fits in int.
6279 * region-cache.h: Adjust extern decls to match.
6280
6281 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6282 EMACS_INT, since either will do, for xpalloc.
6283
6284 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6285 (xnmalloc, xnrealloc, xpalloc): New functions.
6286
726e0ab1
PE
6287 * bidi.c (bidi_shelve_header_size): New constant.
6288 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6289 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6290
51f30bc5 6291 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6292 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6293 (overlay_strings):
6294 Don't update size of array until after memory allocation succeeds,
6295 because xmalloc/xrealloc may not return.
0065d054
PE
6296 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6297 now that we have proper integer overflow checking.
6298 (record_overlay_string, overlay_strings): Catch overflows when
6299 calculating size of overlay_str_buf.
726e0ab1 6300
0065d054
PE
6301 * callproc.c (Fcall_process): Check for size overflow when
6302 calculating size of args2.
6303 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6304 Normally we prefer signed values, but sticking with ptrdiff_t would
6305 require adding more-complicated checks.
726e0ab1
PE
6306
6307 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6308 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6309 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6310 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6311
6312 * character.c (Fstring): Check for size-calculation overflow.
6313
6314 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6315 unnecessary integer overflow. Check for size overflow.
6316 (encode_coding_object): Don't update size until xmalloc succeeds.
6317
6318 * composite.c (get_composition_id): Check for overflow in glyph
6319 length calculations.
6320
6321 Integer and memory overflow fixes for display code.
6322 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6323 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6324 (scrolling_window): Check for overflow in size calculations.
6325 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6326 Don't assume glyph table len fits in int.
6327 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6328 (row_table_size): Now ptrdiff_t, not int.
6329 (scrolling_window): Avoid overflow in size calculations.
6330 Don't update size until allocation succeeds.
6331 * fns.c (concat): Check for overflow in size calculations.
6332 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6333 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6334 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6335
6336 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6337 (get_doc_string): Check for size calculation overflow.
6338 Don't update size until allocation succeeds.
6339 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6340 EMACS_INT, where ptrdiff_t will do.
6341 (Fsubstitute_command_keys): Check for string overflow.
6342
6343 * editfns.c (set_time_zone_rule): Don't assume environment length
6344 fits in int.
6345 (message_length): Now ptrdiff_t, not int.
6346 (Fmessage_box): Don't update size until allocation succeeds.
6347 Don't assume message length fits in int.
6348 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6349
0065d054
PE
6350 * emacs.c (main): Do not reallocate argv, since there is a null at
6351 the end that can be overwritten, and this way there's no need to
6352 worry about size-calculation overflow.
6353 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6354
6355 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6356 alloc succeeds.
6357 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6358
6359 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6360 (x_set_scroll_bar_width, x_figure_window_size):
6361 Check for integer overflow.
6362 (x_set_alpha): Do not assume XINT fits in int.
6363
6364 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6365 This is for the members text_lines, text_cols, total_lines, total_cols,
6366 where the system imposes an 'int' limit.
6367
6368 * fringe.c (Fdefine_fringe_bitmap):
6369 Don't update size until alloc works.
6370
6371 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6372 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6373
6374 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6375 Check for size-calculation overflow.
6376 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6377 do, as we prefer signed integers.
6378 (id_to_widget.max_size, id_to_widget.used)
6379 (xg_store_widget_in_map, xg_remove_widget_from_map)
6380 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6381 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6382 Use and return ptrdiff_t, not int.
6383 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6384 * gtkutil.h: Change prototypes to match the above.
6385
6386 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6387 are duplicate now that they've been promoted to lisp.h.
6388 (x_allocate_bitmap_record, x_alloc_image_color)
6389 (make_image_cache, cache_image, xpm_load):
6390 Don't update size until alloc is done.
6391 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6392 (x_detect_edges):
3256efce 6393 Check for size calculation overflow.
726e0ab1
PE
6394 (ct_colors_allocated_max): New constant.
6395 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6396 overflow.
3256efce 6397
726e0ab1
PE
6398 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6399 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6400 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6401 Use ptrdiff_t, not int, to count maps.
6402 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6403 calculations. Don't update size until allocation succeeds.
6404 Redo calculations to avoid overflow.
726e0ab1
PE
6405 * keyboard.h: Change prototypes to match the above.
6406
6407 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6408 to count maps.
6409 (current_minor_maps): Check for size calculation overflow.
6410 * keymap.h: Change prototypes to match the above.
6411
6412 * lread.c (read1, init_obarray): Don't update size until alloc done.
6413
6414 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6415 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6416
726e0ab1
PE
6417 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6418 Now ptrdiff_t, not int.
6419 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6420 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6421
6422 * process.c (Fnetwork_interface_list): Check for overflow
6423 in size calculation.
6424
6425 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6426
6427 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6428 overflow. Don't bother calling xmalloc when xrealloc will do.
6429
6430 * search.c (Freplace_match): Check for size calculation overflow.
6431 (Fset_match_data): Don't assume list lengths fit in 'int'.
6432
6433 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6434 for command line length. Do not attempt to address one before the
6435 beginning of an array, as that's not portable.
6436
6437 * term.c (max_frame_lines): Remove; unused.
6438 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6439 not int.
6440 (encode_terminal_code, calculate_costs): Check for size
6441 calculation overflow.
6442 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6443 table lengths and related sizes. Don't update size until alloc
6444 done. Redo calculations to avoid overflow.
6445 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6446
6447 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6448 subtracting pointers.
6449 (gobble_line): Check for overflow more carefully. Don't update size
6450 until alloc done.
6451
6452 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6453 Don't update size until alloc done.
6454 Redo size calculations to avoid overflow.
6455 Check for size calculation overflow.
0065d054 6456 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6457
6458 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6459 Use ptrdiff_t, not int, for sizes.
6460 (store_mode_line_noprop_char): Don't update size until alloc done.
6461
0065d054
PE
6462 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6463 Use ptrdiff_t, not int, for sizes.
6464 (Finternal_make_lisp_face, cache_face):
6465 Check for size calculation overflow.
6466 (cache_face): Treat size calculation overflows as if they were
6467 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6468
6469 * xfns.c (x_encode_text, x_set_name_internal)
6470 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6471 sizes, since they can exceed INT_MAX in size. Check for size
6472 calculation overflow.
6473
0065d054
PE
6474 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6475 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6476 Don't update size until alloc done.
6477
0065d054 6478 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6479 as sprintf is limited to int lengths.
1d526e2f 6480
252c5ee1
PE
6481 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6482 (X_LONG_MIN): New macros.
864d7ce7
PE
6483 Use them to make the following changes clearer.
6484 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6485 This change doesn't affect the value now, but it may help remind
6486 future maintainers not to raise the value too much later.
6487 (SELECTION_QUANTUM): Remove, replacing with ...
6488 (selection_quantum): ... new function, which avoids overflow.
6489 All uses changed.
6490 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6491 assumption that selection length fits in 'int'.
6492 (x_reply_selection_request, x_handle_selection_request)
6493 (x_get_window_property, receive_incremental_selection)
6494 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6495 (lisp_data_to_selection_data, clean_local_selection_data):
6496 Use ptrdiff_t, not int, to record length of selection.
6497 (x_reply_selection_request, x_get_window_property)
6498 (receive_incremental_selection, x_property_data_to_lisp):
6499 Redo calculations to avoid overflow.
6500 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6501 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6502 something.
6503 (x_get_window_property, receive_incremental_selection)
6504 (lisp_data_to_selection_data, x_property_data_to_lisp):
6505 Check for size-calculation overflow.
6506 (x_get_window_property, receive_incremental_selection)
6507 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6508 Don't store size until memory allocation succeeds.
6509 (x_get_window_property): Plug memory leak on memory exhaustion.
6510 Don't double-block input; malloc is safe here. Don't assume 2**34
6511 - 4 fits in unsigned long. Add an xassert to check
6512 XGetWindowProperty overflow. Be more careful about overflow
6513 calculations, and distinguish size from memory overflow better.
6514 (receive_incremental_selection): When tracing, don't assume
6515 unsigned int is less than INT_MAX.
6516 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6517 harmful) conversions of unsigned short to int.
6518 (lisp_data_to_selection_data): Don't assume that integers
6519 in the range -65535 through -1 fit in an X unsigned short.
6520 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6521 result parameters unless successful. Rely on cons_to_unsigned
6522 to report problems with elements; the old code wasn't right anyway.
6523 (x_check_property_data): Check for int overflow; we cannot use
6524 a wider type due to X limits.
6525 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6526
726e0ab1 6527 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6528
0065d054
PE
6529 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6530 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6531 (x_color_cells): Don't store size until memory allocation succeeds.
6532 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6533 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6534 (x_term_init): Don't assume length fits in int (sprintf is limited
6535 to int size).
bc18e09d 6536
ebfa62c0
PE
6537 Use ptrdiff_t for composition IDs.
6538 * character.c (lisp_string_width):
6539 * composite.c (composition_table_size, n_compositions)
6540 (get_composition_id, composition_gstring_from_id):
6541 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6542 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6543 * window.c (Frecenter):
6544 Use ptrdiff_t, not int, for composition IDs.
6545 * composite.c (get_composition_id): Check for integer overflow.
6546 * composite.h: Adjust prototypes to match the above changes.
6547
d3411f89
PE
6548 Use ptrdiff_t for hash table indexes.
6549 * category.c (hash_get_category_set):
6550 * ccl.c (ccl_driver):
6551 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6552 * coding.c (coding_system_charset_list, detect_coding_system):
6553 * coding.h (struct coding_system.id):
6554 * composite.c (get_composition_id, gstring_lookup_cache):
6555 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6556 * image.c (xpm_get_color_table_h):
6557 * lisp.h (hash_lookup, hash_put):
6558 * minibuf.c (Ftest_completion):
6559 Use ptrdiff_t for hash table indexes, not int (which is too
6560 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6561 32-bit --with-wide-int hosts).
6562
e097a6fa
PE
6563 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6564 Add a FIXME comment about memory leaks.
6565 (syms_of_charset): Don't assume xmalloc returns.
6566
5637687f
PE
6567 Don't assume that stated character widths fit in int.
6568 * character.c (Fchar_width, c_string_width, lisp_string_width):
6569 * character.h (CHAR_WIDTH):
6570 * indent.c (MULTIBYTE_BYTES_WIDTH):
6571 Use sanitize_char_width to avoid undefined and/or bad behavior
6572 with outlandish widths.
a66cfb1c 6573 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6574 now that we have two such functions. All uses changed.
6575 (sanitize_char_width): New inline function.
6576
a2271ba2
PE
6577 Don't assume that tab-width fits in int.
6578 * character.h (sanitize_width): New inline function.
6579 (SANE_TAB_WIDTH): New macro.
6580 (ASCII_CHAR_WIDTH): Use it.
6581 * indent.c (sane_tab_width): Remove. All uses replaced by
6582 SANE_TAB_WIDTH (current_buffer).
6583 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6584
18c52557
PE
6585 * fileio.c: Integer overflow issues with file modes.
6586 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6587
caeeedc1
PE
6588 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6589 Remove unreachable code.
6590 (read_hex, load_charset_map_from_file): Check for integer overflow.
6591
6df6ae42 6592 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6593 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6594 (x_send_scroll_bar_event): Likewise. Check that the size does not
6595 exceed limits imposed by XClientMessageEvent, as well as the usual
6596 ptrdiff_t and size_t limits.
6597
b13995db
PE
6598 * keyboard.c: Overflow, signedness and related fixes.
6599 (make_lispy_movement): Use same integer type in forward decl
6600 that is used in the definition.
6601 (read_key_sequence, keyremap_step):
6602 Change bufsize argument back to int, undoing my 2011-03-30 change.
6603 We prefer signed types, and int is wide enough here.
6604 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6605 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6606 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6607 length, not size_t. Use ptrdiff_t for index, not int.
6608 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6609 possibility of integer overflow.
6610
13464394
PE
6611 Overflow, signedness and related fixes for images.
6612
6613 * dispextern.h (struct it.stack[0].u.image.image_id)
6614 (struct_it.image_id, struct image.id, struct image_cache.size)
6615 (struct image_cache.used, struct image_cache.ref_count):
6616 * gtkutil.c (update_frame_tool_bar):
6617 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6618 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6619 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6620 * nsmenu.m (update_frame_tool_bar):
6621 * xdisp.c (calc_pixel_width_or_height):
6622 * xfns.c (image_cache_refcount):
6623 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6624 on typical 64-bit hosts.
6625
6626 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6627 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6628 Omit unnecessary casts to int.
6629 (parse_image_spec): Check that integers fall into 'int' range
6630 when the callers expect that.
6631 (image_ascent): Redo ascent calculation to avoid int overflow.
6632 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6633 (lookup_image): Remove unnecessary tests.
6634 (xbm_image_p): Locals are now of int, not EMACS_INT,
6635 since parse_image_check makes sure they fit into int.
6636 (png_load, gif_load, svg_load_image):
6637 Prefer int to unsigned where either will do.
6638 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6639 old tiff_error_handler and tiff_warning_handler.
6640 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6641 stack buffer overflows. It uses only the features of vsnprintf
6642 that are common to both POSIX and native Microsoft.
6643 (tiff_error_handler, tiff_warning_handler): Use it.
6644 (tiff_load, gif_load, imagemagick_load_image):
6645 Don't assume :index value fits in 'int'.
6646 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6647 (imagemagick_load_image): Check that crop parameters fit into
6648 the integer types that MagickCropImage accepts. Don't assume
6649 Vimagemagick_render_type has a nonnegative value. Don't assume
6650 size_t fits in 'long'.
6651 (gs_load): Use printmax_t to print the widest integers possible.
6652 Check for integer overflow when computing image height and width.
6653
c11821d4
EZ
66542011-08-26 Eli Zaretskii <eliz@gnu.org>
6655
6656 * xdisp.c (redisplay_window): Don't force window start if point
6657 will be invisible in the resulting window. (Bug#9324)
6658
0c95fcf7
EZ
66592011-08-25 Eli Zaretskii <eliz@gnu.org>
6660
6661 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6662 the display spec is of the form `(space ...)'.
6663 (handle_display_spec): Return the value returned by
6664 handle_single_display_spec, not just 1 or zero.
6665 (handle_single_display_spec): If the display spec is of the form
6666 `(space ...)', and specifies display in the text area, return 2
6667 rather than 1.
fee65a97 6668 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6669 accurately, and prefer exact match for point under bidi.
6670 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6671
6672 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6673 into disp_prop; all users changed.
6674
6675 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6676 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6677 for the text covered by the display property.
6678
e4ed06f1
CY
66792011-08-25 Chong Yidong <cyd@stupidchicken.com>
6680
6681 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6682 Change return value to nil.
6683 (Frecord_buffer): Delete unused function.
6684
f67cdd7f
EZ
66852011-08-24 Eli Zaretskii <eliz@gnu.org>
6686
5980d4c6
EZ
6687 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6688 buffers, return left-to-right.
8610fe8b
EZ
6689 (set_cursor_from_row): Consider candidate row a win if its glyph
6690 represents a newline and point is on that newline. Fixes cursor
6691 positioning on the newline at EOL of R2L text within L2R
6692 paragraph, and vice versa.
6693 (try_cursor_movement): Check continued rows, in addition to
6694 continuation rows. Fixes unwarranted scroll when point enters a
6695 continued line of R2L text within an L2R paragraph, or vice versa.
6696 (cursor_row_p): Consider the case of point being equal to
6697 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6698 from the end of a short line to the beginning of a continued line
6699 of R2L text within L2R paragraph.
6700 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6701 composed characters.
5980d4c6 6702
f67cdd7f
EZ
6703 * bidi.c (bidi_check_type): Use xassert.
6704 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6705 members.
6706
bca633fb
EZ
67072011-08-23 Eli Zaretskii <eliz@gnu.org>
6708
6709 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6710 a character.
6711
4a5885a7
CY
67122011-08-23 Chong Yidong <cyd@stupidchicken.com>
6713
6714 * nsfont.m (ns_otf_to_script): Fix typo.
6715
0902a04e
KH
67162011-08-22 Kenichi Handa <handa@m17n.org>
6717
6718 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6719 extra slot even if the purpose is char-code-property-table.
6720
1a2e6670
EZ
67212011-08-23 Eli Zaretskii <eliz@gnu.org>
6722
8ddde651
EZ
6723 * xdisp.c (redisplay_window): When computing centering_position,
6724 account for the height of the header line. (Bug#8874)
6725
425cc014
EZ
6726 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6727 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6728 candidate is selected by the mouse, and that candidate has a
6729 composed character under the mouse.
6730
1a2e6670
EZ
6731 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6732 coordinates reported by pos-visible-in-window-p for a composed
6733 character in column zero.
6734
8b76d6f8
SM
67352011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6736
6737 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6738
dac347dd
EZ
67392011-08-22 Eli Zaretskii <eliz@gnu.org>
6740
6741 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6742 consider it a hit if to_charpos is anywhere in the range of the
6743 composed buffer positions.
6744
e013fb34
CY
67452011-08-22 Chong Yidong <cyd@stupidchicken.com>
6746
6747 * image.c (gif_load): Don't assume that each subimage has the same
6748 dimensions as the base image. Handle disposal method that is
6749 "undefined" by the gif spec (Bug#9335).
6750
bd1ba3e8
CY
67512011-08-20 Chong Yidong <cyd@stupidchicken.com>
6752
6753 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6754 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6755
54a1215b
EZ
67562011-08-19 Eli Zaretskii <eliz@gnu.org>
6757
823564e5
EZ
6758 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6759 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6760 from an Org mode buffer to a Speedbar frame.
6761
54a1215b
EZ
6762 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6763 a composition, take its buffer position from IT->cmp_it.charpos.
6764 Fixes cursor positioning at the beginning of a line that begins
6765 with a composed character.
6766
9778ebcc
EZ
67672011-08-18 Eli Zaretskii <eliz@gnu.org>
6768
0be6ee06
EZ
6769 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6770 character bidirectional type, use STRONG_L instead. Fixes crashes
6771 in a buffer produced by `describe-categories'.
6772
9778ebcc
EZ
6773 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6774 members before the level stack, so they would be saved and
6775 restored when copying iterator state. Fixes incorrect reordering
6776 around TABs covered by display properties.
6777
156bffbe
AS
67782011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6779
6b02f655 6780 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6781
72ad093b
CY
67822011-08-17 Chong Yidong <cyd@stupidchicken.com>
6783
6784 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6785 (internal_condition_case_2, internal_condition_case_n):
6786 Remove unnecessary aborts (Bug#9081).
72ad093b 6787
35774242
EZ
67882011-08-17 Eli Zaretskii <eliz@gnu.org>
6789
6790 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6791 has no `load' handler, try opening the file locally. (Bug#9311)
6792
db76dd85
KB
67932011-08-16 Ken Brown <kbrown@cornell.edu>
6794
6795 * gmalloc.c: Expand comment.
6796
b215eee5
EZ
67972011-08-16 Eli Zaretskii <eliz@gnu.org>
6798
6799 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6800 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6801
a4579d33
KB
68022011-08-16 Ken Brown <kbrown@cornell.edu>
6803
6804 Fix memory allocation problems in Cygwin build (Bug#9273).
6805
6806 * unexcw.c ( __malloc_initialized): Declare external variable.
6807 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6808
8b76d6f8
SM
6809 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6810 New variables.
a4579d33
KB
6811 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6812 dumped emacs.
6813 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6814 in the static heap.
6815 [CYGWIN] (special_realloc): New function.
6816 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6817 requests to realloc storage in the static heap.
6818
3ebec551
PE
68192011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6820
6821 * bidi.c (bidi_initialize): Remove unused local.
6822
9fd8be00
EZ
68232011-08-15 Eli Zaretskii <eliz@gnu.org>
6824
6b02f655
SM
6825 * bidimirror.h:
6826 * biditype.h: Remove file.
6827 * makefile.w32-in ($(BLD)/bidi.$(O)):
6828 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6829
6830 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6831
6832 * chartab.c: Improve commentary for the uniprop_table API.
6833
32413314
EZ
6834 * bidi.c (bidi_paragraph_init): Support zero value of
6835 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6836 (bidi_initialize): Use uniprop_table instead of including
6837 biditype.h and bidimirror.h.
32413314 6838
9fd8be00
EZ
6839 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6840 coordinates of the iterator when restoring from ppos_it.
6841 (Bug#9296)
6842
5cf2b69b
KH
68432011-08-14 Kenichi Handa <handa@m17n.org>
6844
6845 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6846 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6847
daf17d00
EZ
68482011-08-14 Eli Zaretskii <eliz@gnu.org>
6849
6850 * xdisp.c (move_it_in_display_line_to): Don't invoke
6851 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6852 ppos_it. Fixes vertical cursor motion when line beginning is
6853 covered by an image. (Bug#9296)
6854
08e3161a
JD
68552011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6856
6857 * nsterm.h (ns_run_ascript): Declare.
6858 (NSAPP_DATA2_RUNASSCRIPT): Define.
6859
6860 * nsfns.m (as_script, as_result, as_status): New static variables.
6861 (ns_run_ascript): New function.
5e617bc2 6862 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6863 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6864 the event loop. Get status from as_status (Bug#7276).
6865
6866 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6867 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6868 the event loop (Bug#7276).
6869
a3720aa2
AS
68702011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6871
6872 * gnutls.c (QCgnutls_bootprop_priority)
6873 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6874 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6875 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6876 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6877 (QCgnutls_bootprop_verify_hostname_error)
6878 (QCgnutls_bootprop_callbacks_verify): Rename from
6879 Qgnutls_bootprop_..., all uses changed.
6880
6881 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6882 uses changed.
6883
0a0d27fb
PE
68842011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6885
19d5c50c
PE
6886 * xfaces.c (Qframe_set_background_mode): Now static.
6887 * dispextern.h (Qframe_set_background_mode): Remove decl.
6888
0a0d27fb
PE
6889 * process.c (Fnetwork_interface_info): Declare local only if needed.
6890
377538cb
JD
68912011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6892
6893 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6894 (Fnetwork_interface_list): Allocate in increments of bytes instead
6895 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6896 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6897 sockaddr.
6898 (struct ifflag_def): notrailers is smart on OSX.
6899 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6900 Get hardware address with getifaddrs if available.
6901
08fff70c
EZ
69022011-08-12 Eli Zaretskii <eliz@gnu.org>
6903
6904 * xdisp.c (iterate_out_of_display_property): xassert that
6905 IT->position is set to within IT->object's boundaries. Break from
6906 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6907 when IT->position is set up wrongly due to some bug.
6908 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6909 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6910 entry. Force push_it to save on the stack the current
6911 buffer/string position, to be restored by pop_it. Fix flags in
6912 the iterator structure wrt the object coming from a display
6913 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6914 properties. (Bug#9284)
6915
7be1c708 69162011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6917
7be1c708
CY
6918 * fontset.c (fontset_get_font_group): Add proper type checks.
6919 (Bug#9172)
aac0c6e3 6920
7be1c708 69212011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6922
7be1c708
CY
6923 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6924 and LC_VERSION_MIN_MACOSX.
6925 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6926 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6927
97bb72a6
EZ
69282011-08-08 Eli Zaretskii <eliz@gnu.org>
6929
6930 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6931 no-display-properties-and-no-overlays under bidi display.
6932 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6933 properties and overlays.
97bb72a6 6934
d5617611
CY
69352011-08-08 Chong Yidong <cyd@stupidchicken.com>
6936
37e11a63
CY
6937 * editfns.c (Fset_time_zone_rule): Document relationship with the
6938 setenv function.
6939
d5617611
CY
6940 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6941 the font entity extracted from the cache (Bug#8109).
6942
58872834
CY
69432011-08-07 Chong Yidong <cyd@stupidchicken.com>
6944
6945 * composite.c (autocmp_chars): Don't reset point. That is done by
6946 restore_point_unwind (Bug#5984).
6947
75bfc667
JL
69482011-08-07 Juri Linkov <juri@jurta.org>
6949
6950 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6951 to show the arg `TIME' instead of `TIMEVAL'.
6952
d1410150
EZ
69532011-08-06 Eli Zaretskii <eliz@gnu.org>
6954
6955 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6956 display property strides EOL and includes a newline, as in
6957 longlines-mode. (Bug#9254)
75b771e4
EZ
6958 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6959 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6960
6961 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6962 is non-zero, even if the data buffer is NULL. Fixes a crash in
6963 vertical-motion with longlines-mode. (Bug#9254)
6964
35928349
EZ
69652011-08-05 Eli Zaretskii <eliz@gnu.org>
6966
ec7cc85b
EZ
6967 * bidi.c <bidi_cache_total_alloc>: Now static.
6968 (bidi_initialize): Initialize bidi_cache_total_alloc.
6969
8b76d6f8 6970 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6971 cache. (Bug#9221)
6972
6973 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6974 amount allocated this far in `bidi_cache_total_alloc'.
6975 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6976 non-zero, only free the data buffer without restoring the cache
6977 contents. All callers changed.
6978
6979 * dispextern.h (bidi_unshelve_cache): Update prototype.
6980
6981 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6982 (move_it_in_display_line, move_it_to)
6983 (move_it_vertically_backward, move_it_by_lines): Replace the call
6984 to xfree to an equivalent call to bidi_unshelve_cache.
6985 (move_it_in_display_line_to): Fix logic of returning
412b6358 6986 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6987
e2e2423b
EZ
69882011-08-05 Eli Zaretskii <eliz@gnu.org>
6989
6990 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6991 came from a string character with a `cursor' property. (Bug#9229)
6992
ae9e757a
JD
69932011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6994
6995 * Makefile.in (LIB_PTHREAD): New variable.
6996 (LIBES): Add LIB_PTHREAD (Bug#9216).
6997
6998 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6999 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7000
213bd7f2
AS
70012011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7002
6b02f655 7003 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7004
99aaf75f
JD
70052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7006
7007 * xterm.c (x_find_topmost_parent): New function.
7008 (x_set_frame_alpha): Find topmost parent window with
7009 x_find_topmost_parent and set the property there also (bug#9181).
7010 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7011
c74e9d86
PE
70122011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7013
7014 * callproc.c (Fcall_process): Avoid vfork clobbering
7015 the local vars buffer, coding_systems, current_dir.
7016
640c8776
SM
70172011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7018
7019 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7020
f26d0e4c
PE
70212011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7022
8a10d76c
PE
7023 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7024 so that it is not optimized away.
7025
f26d0e4c
PE
7026 * xdisp.c (compute_display_string_pos): Remove unused local.
7027
55439c61
EZ
70282011-08-02 Eli Zaretskii <eliz@gnu.org>
7029
7030 Fix slow cursor motion and scrolling in large buffers with
7031 selective display, like Org Mode buffers. (Bug#9218)
7032
7033 * dispextern.h (struct bidi_it): New member disp_prop_p.
7034
7035 * xdisp.c: Remove one-slot cache of display string positions.
7036 (compute_display_string_pos): Accept an additional argument
5e617bc2 7037 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7038 for a display string or property. If found, set DISP_PROP_P
7039 non-zero.
7040
7041 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7042 DISP_PROP_P, and pass it to compute_display_string_pos.
7043 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7044 non-zero. All callers of bidi_fetch_char changed.
7045
fb33fa43
SM
70462011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7047
7048 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7049
b099e063
DM
70502010-12-03 Don March <don@ohspite.net>
7051
7052 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7053 last character M-[char] is translated to ESC [char] (bug#7541).
7054
5cc7f7af
KH
70552011-08-02 Kenichi Handa <handa@m17n.org>
7056
d0fffa3f 7057 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7058
7059 * chartab.c (uniprop_table): Make it non-static.
7060
525d5e6e
EZ
70612011-08-01 Eli Zaretskii <eliz@gnu.org>
7062
7063 * xdisp.c (forward_to_next_line_start): Accept additional argument
7064 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7065 on the newline.
7066 (reseat_at_next_visible_line_start): Use the bidi iterator state
7067 returned by forward_to_next_line_start to restore the state of
7068 it->bidi_it after backing up to previous newline. (Bug#9212)
7069
31011111
AS
70702011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7071
7072 * regex.c (re_comp): Protoize.
7073 (re_exec): Fix return type.
7074 (regexec): Fix type of `ret'. (Bug#9203)
7075
476371c4
PE
70762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7077
e5d76069
PE
7078 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7079 This is needed if max-image-size is a floating-point number.
7080
9a79b20c
AS
70812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7082
7083 * print.c (print_object): Print empty symbol as ##.
7084
7085 * lread.c (read1): Read ## as empty symbol.
7086
d8c2fa78
AA
70872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7088
7089 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7090 setting frame foreground color (Bug#9175).
7091 (x_set_background_color): Likewise.
7092
ffe57a7a
AA
7093 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7094 contents (Bug#9176).
7095 (EmacsTooltip -init): Remove bezels and add shadows to
7096 tooltip windows.
7097
bf3492a5
AA
7098 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7099 or scroll bar (Bug#8470).
7100
d55e9c53
AA
7101 * nsfont.m (nsfont_open): Remove assignment to voffset and
7102 unnecessary vars hshink, expand, hd, full_height, min_height.
7103 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7104
7105 * nsterm.h (nsfont_info): Remove voffset field.
7106
d8c2fa78 71072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7108
7109 Implement strike-through and overline on NextStep (Bug#8863).
7110
7111 * nsfont.m (nsfont_open): Use underline position provided by font,
7112 instead of hard-coded value of 2.
7113 (nsfont_draw): Call ns_draw_text_decoration instead.
7114
7115 * nsterm.h: Add declaration for ns_draw_text_decoration.
7116
7117 * nsterm.m (ns_draw_text_decoration): New function for drawing
7118 underline, overline, and strike-through.
7119 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7120 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7121 accommodate underlining, etc.
4843aac3 7122
4cc60b9b
EZ
71232011-07-28 Eli Zaretskii <eliz@gnu.org>
7124
bc7ece87
EZ
7125 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7126 default.
4cc60b9b 7127
476371c4
PE
71282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7129
66606eea
PE
7130 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7131 Without this fix, if a signal arrives just after memory fills up,
7132 'malloc' might be invoked reentrantly.
7133
476371c4
PE
7134 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7135 In other words, assume that every image size is allowed, on non-X
7136 hosts. This assumption is probably wrong, but it lets Emacs compile.
7137
f3fcc40d
AS
71382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7139
7140 * regex.c (re_iswctype): Convert return values to boolean.
7141
350c992f
EZ
71422011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7143
7144 * xdisp.c (compute_display_string_pos): Don't use cached display
7145 string position if the buffer had its restriction changed.
7146 (Bug#9184)
7147
5266b4bb
PE
71482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7149
7150 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7151
2573a837 71522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7153
41f55ccd 7154 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7155
39e378da
PE
7156 * bidi.c: Integer size and overflow fixes.
7157 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7158 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7159 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7160 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7161 (bidi_find_other_level_edge):
7162 Use ptrdiff_t instead of EMACS_INT where either will do.
7163 This works better on 32-bit hosts configured --with-wide-int.
7164 (bidi_cache_ensure_space): Check for size-calculation overflow.
7165 Use % rather than repeated addition, for better worst-case speed.
7166 Don't set bidi_cache_size until after xrealloc returns, because it
7167 might not return.
7168 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7169 (bidi_cache_ensure_space): Also check that the bidi cache size
7170 does not exceed that of the largest Lisp string or buffer. See Eli
7171 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7172
5e927815
PE
7173 * alloc.c (__malloc_size_t): Remove.
7174 All uses replaced by size_t. See Andreas Schwab's note
7175 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7176
ca4aa935
PE
7177 * image.c: Improve checking for integer overflow.
7178 (check_image_size): Assume that f is nonnull, since
7179 it is always nonnull in practice. This is one less thing to
7180 worry about when checking for integer overflow later.
7181 (x_check_image_size): New function, which checks for integer
7182 overflow issues inside X.
7183 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7184 This removes the need for a memory_full check.
7185 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7186 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7187 (xbm_read_bitmap_data): Change locals back to 'int', since
7188 their values must fit in 'int'.
7189 (xpm_load_image, png_load, tiff_load):
7190 Invoke x_create_x_image_and_pixmap earlier,
7191 to avoid much needless work if the image is too large.
7192 (tiff_load): Treat overly large images as if
7193 x_create_x_image_and_pixmap failed, not as malloc failures.
7194 (gs_load): Use x_check_image_size.
7195
5f8f9cc2
PE
7196 * gtkutil.c: Omit integer casts.
7197 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7198 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7199
5adf60bc
PE
7200 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7201
c8907a93
PE
7202 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7203 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7204 would wrongly return t on a 64-bit host.
7205
e3c25c68
PE
7206 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7207 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7208 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7209 and therefore cause GCC to emit a bogus diagnostic in some cases.
7210
3f791afe
PE
7211 * image.c: Integer signedness and overflow and related fixes.
7212 This is not an exhaustive set of fixes, but it's time to
7213 record what I've got.
7214 (lookup_pixel_color, check_image_size): Remove redundant decls.
7215 (check_image_size): Don't assume that arbitrary EMACS_INT values
7216 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7217 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7218 (tiff_load, imagemagick_load_image):
7219 Check for overflow in size calculations.
7220 (x_create_x_image_and_pixmap): Remove unnecessary test for
7221 xmalloc returning NULL; that can't happen.
7222 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7223 (xpm_color_bucket): Use better integer hashing function.
7224 (xpm_cache_color): Don't possibly over-allocate memory.
7225 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7226 (gif_memory_source):
7227 Use ptrdiff_t, not int or size_t, to record sizes.
7228 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7229 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7230 either works, as we prefer signed integers.
7231 (tiff_read_from_memory, tiff_write_from_memory):
7232 Return tsize_t, not size_t, since that's what the TIFF API wants.
7233 (tiff_read_from_memory): Don't fail simply because the read would
7234 go past EOF; instead, return a short read.
7235 (tiff_load): Omit no-longer-needed casts.
7236 (Fimagemagick_types): Don't assume size fits into 'int'.
7237
3cc5a532
PE
7238 Improve hashing quality when configured --with-wide-int.
7239 * fns.c (hash_string): New function, taken from sxhash_string.
7240 Do not discard information about ASCII character case; this
7241 discarding is no longer needed.
7242 (sxhash-string): Use it. Change sig to match it. Caller changed.
7243 * lisp.h: Declare it.
7244 * lread.c (hash_string): Remove, since we now use fns.c's version.
7245 The fns.c version returns a wider integer if --with-wide-int is
7246 specified, so this should help the quality of the hashing a bit.
7247
b312a492
PE
7248 * emacs.c: Integer overflow minor fix.
7249 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7250 Define only if GNU_LINUX.
7251 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7252
dfd153ae
PE
7253 * dispnew.c: Integer signedness and overflow fixes.
7254 Remove unnecessary forward decls, that were a maintenance hassle.
7255 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7256 All uses changed.
7257 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7258 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7259 (prepare_desired_row, line_draw_cost):
7260 Use int, not unsigned, where either works.
7261 (save_current_matrix, restore_current_matrix):
7262 Use ptrdiff_t, not size_t, where either works.
7263 (init_display): Check for overflow more accurately, and without
7264 relying on undefined behavior.
7265
a81d11a3
PE
7266 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7267 Remove, replacing with the new symbols in lisp.h. All uses changed.
7268 * fileio.c (make_temp_name):
7269 * filelock.c (lock_file_1, lock_file):
7270 * xdisp.c (message_dolog):
7271 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7272 Use pMd etc. instead.
7273 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7274 replacing the pWIDE etc. symbols removed from editfns.c.
7275
3300e6fd
PE
7276 * keyboard.h (num_input_events): Now uintmax_t.
7277 This is (very slightly) less likely to mess up due to wraparound.
7278 All uses changed.
7279
fd05c7e9
PE
7280 * buffer.c: Integer signedness fixes.
7281 (alloc_buffer_text, enlarge_buffer_text):
7282 Use ptrdiff_t rather than size_t when either will do, as we prefer
7283 signed integers.
7284
903fe15d
PE
7285 * alloc.c: Integer signedness and overflow fixes.
7286 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7287 (__malloc_size_t): Default to size_t, not to int.
7288 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7289 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7290 Prefer ptrdiff_t to size_t when either would do, as we prefer
7291 signed integers.
7292 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7293 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7294 Now const. Initialize with values that are in range even if char
7295 is signed.
7296 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7297 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7298 These functions do the right thing with sizes > 2**32.
7299 (check_depth): Now ptrdiff_t, not int.
7300 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7301 Adjust to new way of storing sizes. Check for size overflow bugs
7302 in rest of code.
7303 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7304 slightly wrong anyway, as it missed one instance of
7305 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7306 (refill_memory_reserve): Omit needless cast to size_t.
7307 (mark_object_loop_halt): Mark as externally visible.
7308
ac82cc6a
PE
7309 * xselect.c: Integer signedness and overflow fixes.
7310 (Fx_register_dnd_atom, x_handle_dnd_message):
7311 Use ptrdiff_t, not size_t, since we prefer signed.
7312 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7313 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7314 x_dnd_atoms_size and x_dnd_atoms_length.
7315
c2d1e36d
PE
7316 * doprnt.c: Prefer signed to unsigned when either works.
7317 * eval.c (verror):
7318 * doprnt.c (doprnt):
7319 * lisp.h (doprnt):
7320 * xdisp.c (vmessage):
7321 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7322 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7323 prefer signed arithmetic to avoid comparison confusion.
7324 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7325 but is a bit tricky.
7326
0e926e56
PE
7327 Assume freestanding C89 headers, string.h, stdlib.h.
7328 * data.c, doprnt.c, floatfns.c, print.c:
7329 Include float.h unconditionally.
7330 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7331 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7332 * regex.c: Likewise for stddef.h, string.h.
7333 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7334 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7335 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7336 (STDC_HEADERS): Remove obsolete defines.
7337 * sysdep.c: Include limits.h unconditionally.
7338
9cfdb3ec
PE
7339 Assume support for memcmp, memcpy, memmove, memset.
7340 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7341 * regex.c (memcmp, memcpy):
7342 Remove; we assume C89 now.
7343
7344 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7345 (__malloc_safe_bcopy): Remove; no longer needed.
7346
cf950e6b 7347 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7348 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7349 well either way, and we prefer signed to unsigned.
7350
dbf38e02
LMI
73512011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7352
7353 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7354 closes the connection while we're reading (bug#9182).
7355
d6f0886c 73562011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7357
d6f0886c
JD
7358 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7359 are specified (Bug#9168).
24e0f6b1 7360
2eb1f9e6
PE
73612011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7362
7363 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7364 Found by GCC static checking and --with-wide-int on a 32-bit host.
7365
22381272 73662011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7367
7368 * xdisp.c (compute_display_string_pos): Fix logic of caching
7369 previous display string position. Initialize cached_prev_pos to
7370 -1. Fixes slow-down at the beginning of a buffer.
7371
f25e39b4
EZ
73722011-07-24 Eli Zaretskii <eliz@gnu.org>
7373
7374 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7375 for attrs[LFACE_FONTSET_INDEX].
7376
04c4b52e
PE
73772011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7378
7379 * xml.c (parse_region): Remove unused local
7380 that was recently introduced.
7381
c1734fbd
EZ
73822011-07-23 Eli Zaretskii <eliz@gnu.org>
7383
be18c5a5
EZ
7384 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7385 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7386
c1734fbd
EZ
7387 * xdisp.c (move_it_in_display_line_to): Record the best matching
7388 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7389 exit if none of the characters scanned was an exact match.
7390 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7391 when exact match is impossible due to invisible text, and the
7392 lines are truncated.
7393
a258d627
JD
73942011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7395
7396 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7397 for OSX >= 10.7.
7398
b6d5a689
EZ
73992011-07-22 Eli Zaretskii <eliz@gnu.org>
7400
0f74f785
EZ
7401 Fix a significant slow-down of cursor motion with C-n, C-p,
7402 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7403 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7404 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7405 (next_element_from_buffer): Call compute_stop_pos_backwards to
7406 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7407 base_level_stop.
7408 (reseat): Don't look for prev_stop, as that could mean a very long
7409 run.
7410 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7411 <cached_disp_overlay_modiff>: Cache for last found display string
7412 position.
551918c1 7413 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7414 about the same buffer in the same area of character positions, and
7415 the buffer wasn't changed since the time the display string
7416 position was cached.
551918c1 7417
b2d0c91a
EZ
74182011-07-22 Eli Zaretskii <eliz@gnu.org>
7419
7420 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7421 is an integer, which is important for empty lines. (Bug#9149)
7422
043604ee
CY
74232011-07-22 Chong Yidong <cyd@stupidchicken.com>
7424
7425 * frame.c (Fmodify_frame_parameters): In tty case, update the
7426 default face if necessary (Bug#4238).
7427
da4adb04
CY
74282011-07-21 Chong Yidong <cyd@stupidchicken.com>
7429
7430 * editfns.c (Fstring_to_char): No need to explain what a character
7431 is in the docstring (Bug#6576).
7432
9abd0532
LMI
74332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7434
7435 * xml.c (parse_region): Make sure we always return a tree.
7436
36881d16
HK
74372011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7438
7439 * xml.c (parse_region): If a document contains only comments,
7440 return that, too.
7441
1e98674d
LMI
74422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7443
7444 * xml.c (make_dom): Return comments, too.
7445
590bd467
PE
74462011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7447
7448 Port to OpenBSD.
7449 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7450 and the surrounding thread.
7451 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7452 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7453 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7454 timer goes off.
7455 * s/openbsd.h (BROKEN_SIGIO): Define.
7456 * unexelf.c (unexec) [__OpenBSD__]:
7457 Don't update the .mdebug section of the Alpha COFF symbol table.
7458
f41628b2
LMI
74592011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7460
7461 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7462 (bug#8460).
7463
b59b67c5
PE
74642011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7465
15e3a074
PE
7466 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7467 This fixes some race conditions on the permissions of any newly
7468 created file.
7469
41bed37d
PE
7470 * alloc.c (valid_pointer_p): Use pipe, not open.
7471 This fixes some permissions issues when debugging.
7472
b59b67c5
PE
7473 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7474 If fchown fails to set both uid and gid, try to set just gid,
7475 as that is sometimes allowed. Adjust the file's mode to eliminate
7476 setuid or setgid bits that are inappropriate if fchown fails.
7477
925a6be7
SM
74782011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7479
7480 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7481 to compare Lisp_Objects.
7482 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7483 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7484 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7485
52968808
AS
74862011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7487
0a6a104b
AS
7488 * lread.c (read_integer): Unread even EOF character.
7489 (read1): Likewise. Properly record start position of symbol.
7490
52968808
AS
7491 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7492 symbol character follows.
7493
9e381cdd
PE
74942011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7495
7496 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7497 This works around a problem with the previous change to Fcopy_file.
7498 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7499 and without this change, GCC might complain about discarding
7500 fchown's return value.
7501
b5641435
JB
75022011-07-16 Juanma Barranquero <lekktu@gmail.com>
7503
7504 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7505
a8031457
PE
75062011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7507
7508 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7509
dd889327
LMI
75102011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7511
750c33f7
LMI
7512 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7513 it's used from the C level.
7514
dd889327
LMI
7515 * process.c: Use the same condition for POLL_FOR_INPUT in both
7516 keyboard.c and process.c (bug#1858).
7517
87e86684
LM
75182011-07-09 Lawrence Mitchell <wence@gmx.li>
7519
7520 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7521 (Fgnutls_boot): Use it.
7522
64348f40
AS
75232011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7524
7525 * doc.c (Fsubstitute_command_keys): Revert last change.
7526
1d698799
LMI
75272011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7528
f863868c
LMI
7529 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7530 quotes the next character, and doesn't affect other longer
7531 sequences (bug#8935).
7532
1d698799
LMI
7533 * lread.c (syms_of_lread): Clarify that is isn't only
7534 `eval-buffer' and `eval-defun' that's affected by
7535 `lexical-binding' (bug#8460).
7536
aa4b6df6
EZ
75372011-07-15 Eli Zaretskii <eliz@gnu.org>
7538
7539 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7540 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7541
5d856da6
PE
75422011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7543
ad6042bb
PE
7544 Fix minor problems found by static checking.
7545 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7546 (elsz): Now a signed constant, not a size_t var. We prefer signed
7547 types to unsigned, to avoid integer comparison confusion. Without
7548 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7549 "cannot optimize loop, the loop counter may overflow", a symptom
7550 of the confusion.
f00bbb22 7551 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7552 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7553
6468f31c
LMI
75542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7555
49080b10
LMI
7556 * search.c (Fre_search_backward): Mention `case-fold-search' in
7557 all the re_search_* functions (bug#8138).
7558
6468f31c
LMI
7559 * keyboard.c (Fopen_dribble_file): Document when the file is
7560 closed (bug#8056).
7561
c965adc5
EZ
75622011-07-14 Eli Zaretskii <eliz@gnu.org>
7563
df9733bf
EZ
7564 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7565 bidi_cache_idx.
7566
0bb23927
EZ
7567 Support bidi reordering of display and overlay strings.
7568 * xdisp.c (compute_display_string_pos)
7569 (compute_display_string_end): Accept additional argument STRING.
7570 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7571 (reseat_to_string): Initialize bidi_it->string.s and
7572 bidi_it->string.schars.
7573 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7574 NULL (avoids a crash in bidi_paragraph_init).
7575 Initialize itb.string.lstring.
0bb23927
EZ
7576 (init_iterator): Call bidi_init_it only of a valid
7577 buffer position was specified. Initialize paragraph_embedding to
7578 L2R.
7579 (reseat_to_string): Initialize the bidi iterator.
7580 (display_string): If we need to ignore text properties of
7581 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7582 original value of -1 will not work with bidi.)
7583 (compute_display_string_pos): First arg is now struct
7584 `text_pos *'; all callers changed. Support display properties on
7585 Lisp strings.
7586 (compute_display_string_end): Support display properties on Lisp
7587 strings.
7588 (init_iterator, reseat_1, reseat_to_string): Initialize the
7589 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7590 when iterating on a string not from display properties).
640c8776
SM
7591 (compute_display_string_pos, compute_display_string_end):
7592 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7593 arrow keys.
7594 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7595 base_level_stop; instead, set base_level_stop to BEGV.
7596 Fixes crashes in vertical-motion.
0bb23927
EZ
7597 (next_element_from_buffer): Improve commentary for when
7598 the iterator is before prev_stop.
7599 (init_iterator): Initialize bidi_p from the default value of
7600 bidi-display-reordering, not from buffer-local value. Use the
7601 buffer-local value only if initializing for buffer iteration.
7602 (handle_invisible_prop): Support invisible properties on strings
7603 that are being bidi-reordered.
7604 (set_iterator_to_next): Support bidi reordering of C strings and
7605 Lisp strings.
7606 (next_element_from_string): Support bidi reordering of Lisp
7607 strings.
7608 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7609 (display_string): Support display of R2L glyph rows.
7610 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7611 (init_iterator): Don't initialize it->bidi_p for strings
7612 here.
7613 (reseat_to_string): Initialize it->bidi_p for strings here.
7614 (next_element_from_string, next_element_from_c_string)
7615 (next_element_from_buffer): Add xassert's for correspondence
7616 between IT's object being iterated and it->bidi_it.string
7617 structure.
7618 (face_before_or_after_it_pos): Support bidi iteration.
7619 (next_element_from_c_string): Handle the case of the first string
7620 character that is not the first one in the visual order.
7621 (get_visually_first_element): New function, refactored from common
7622 parts of next_element_from_buffer, next_element_from_string, and
7623 next_element_from_c_string.
7624 (tool_bar_lines_needed, redisplay_tool_bar)
7625 (display_menu_bar): Force left-to-right direction. Add a FIXME
7626 comment for making that be controlled by a user option.
7627 (push_it, pop_it): Save and restore the state of the
7628 bidi iterator. Save and restore the bidi_p flag.
7629 (pop_it): Iterate out of display property for string iteration as
7630 well.
7631 (iterate_out_of_display_property): Support iteration over strings.
7632 (handle_single_display_spec): Set up it->bidi_it for iteration
7633 over a display string, and call bidi_init_it.
7634 (handle_single_display_spec, next_overlay_string)
7635 (get_overlay_strings_1, push_display_prop): Set up the bidi
7636 iterator for displaying display or overlay strings.
7637 (forward_to_next_line_start): Don't use the shortcut if
7638 bidi-iterating.
7639 (back_to_previous_visible_line_start): If handle_display_prop
7640 pushed the iterator stack, restore the internal state of the bidi
7641 iterator by calling bidi_pop_it same number of times.
7642 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7643 and we are bidi-iterating, don't decrement the iterator position;
7644 instead, set the first_elt flag in the bidi iterator, to produce
7645 the same effect.
7646 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7647 (push_display_prop): xassert that we are iterating a buffer.
7648 (push_it, pop_it): Save and restore paragraph_embedding member.
7649 (handle_single_display_spec, next_overlay_string)
7650 (get_overlay_strings_1, reseat_1, reseat_to_string)
7651 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7652 correctly. Don't assume unibyte strings are not bidi-reordered.
7653 (compute_display_string_pos)
7654 (compute_display_string_end): Fix handling the case of C string.
7655 (push_it, pop_it): Save and restore from_disp_prop_p.
7656 (handle_single_display_spec, push_display_prop): Set the
7657 from_disp_prop_p flag.
7658 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7659 (pop_it): Call iterate_out_of_display_property only if we are
7660 popping after iteration over a string that came from a display
7661 property. Fix a typo in popping stretch info. Add an assertion
7662 for verifying that the iterator position is in sync with the bidi
7663 iterator.
7664 (handle_single_display_spec, get_overlay_strings_1)
7665 (push_display_prop): Fix initialization of paragraph direction for
7666 string when that of the parent object is not yet determined.
7667 (reseat_1): Call bidi_init_it to resync the bidi
7668 iterator with IT's position. (Bug#7616)
7669 (find_row_edges): If ROW->start.pos gives position
7670 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7671 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7672 Reset the from_disp_prop_p flag.
7673 (SAVE_IT, RESTORE_IT): New macros.
7674 (pos_visible_p, face_before_or_after_it_pos)
7675 (back_to_previous_visible_line_start)
7676 (move_it_in_display_line_to, move_it_in_display_line)
7677 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7678 (try_scrolling, redisplay_window, display_line): Use them when
7679 saving a temporary copy of the iterator and restoring it back.
7680 (back_to_previous_visible_line_start, reseat_1)
7681 (init_iterator): Empty the bidi cache "stack".
7682 (move_it_in_display_line_to): If iterator ended up at
7683 EOL, but we never saw any buffer positions smaller than
7684 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7685 motion in bidi-reordered lines.
7686 (move_it_in_display_line_to): Record prev_method and prev_pos
7687 immediately before the call to set_iterator_to_next. Fixes cursor
7688 motion in bidi-reordered lines with stretch glyphs and strings
7689 displayed in margins. (Bug#8133) (Bug#8867)
7690 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7691 TO_CHARPOS.
640c8776
SM
7692 (pos_visible_p): Support positions in bidi-reordered lines.
7693 Save and restore bidi cache.
0bb23927
EZ
7694
7695 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7696 (bidi_paragraph_info): Delete unused struct.
7697 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7698 (bidi_cache_start): New variable.
7699 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7700 to zero.
7701 (bidi_cache_fetch_state, bidi_cache_search)
7702 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7703 (bidi_cache_find, bidi_peek_at_next_level)
7704 (bidi_level_of_next_char, bidi_find_other_level_edge)
7705 (bidi_move_to_visually_next): Compare cache index with
7706 bidi_cache_start rather than with zero.
7707 (bidi_fetch_char): Accept new argument STRING; all callers
7708 changed. Support iteration over a string. Support strings with
7709 display properties. Support unibyte strings. Fix the type of
7710 `len' according to what STRING_CHAR_AND_LENGTH expects.
7711 (bidi_paragraph_init, bidi_resolve_explicit_1)
7712 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7713 (bidi_level_of_next_char, bidi_move_to_visually_next):
7714 Support iteration over a string.
0bb23927
EZ
7715 (bidi_set_sor_type, bidi_resolve_explicit_1)
7716 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7717 can now be zero (for strings); special values 0 and -1 were
7718 changed to -1 and -2, respectively.
7719 (bidi_char_at_pos): New function.
7720 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7721 Call it instead of FETCH_MULTIBYTE_CHAR.
7722 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7723 initialized to valid values.
7724 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7725 values.
7726 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7727 the test for valid cached positions. Fix the logic for looking up
7728 the sentinel state in the cache. GCPRO the Lisp string we are
7729 iterating.
7730 (bidi_push_it, bidi_pop_it): New functions.
7731 (bidi_initialize): Initialize the bidi cache start stack pointer.
7732 (bidi_cache_ensure_space): New function, refactored from part of
7733 bidi_cache_iterator_state. Don't assume the required size is just
7734 one BIDI_CACHE_CHUNK away.
7735 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7736 (bidi_count_bytes, bidi_char_at_pos): New functions.
7737 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7738 always valid if bidi_cache_idx is valid.
7739 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7740 is valid if it's going to be used.
7741 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7742 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7743 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7744 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7745 (bidi_find_other_level_edge, bidi_cache_start_stack):
7746 All variables related to cache indices are now EMACS_INT.
c965adc5 7747
0bb23927
EZ
7748 * dispextern.h (struct bidi_string_data): New structure.
7749 (struct bidi_it): New member `string'. Make flag members be 1-bit
7750 fields, and put them last in the struct.
640c8776
SM
7751 (compute_display_string_pos, compute_display_string_end):
7752 Update prototypes.
0bb23927
EZ
7753 (bidi_push_it, bidi_pop_it): Add prototypes.
7754 (struct iterator_stack_entry): New members bidi_p,
7755 paragraph_embedding, and from_disp_prop_p.
7756 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7757 (bidi_shelve_cache, bidi_unshelve_cache):
7758 Declare prototypes.
0bb23927
EZ
7759
7760 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7761 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7762 and vector-like objects.
7763
7764 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7765 cache around display iteration.
7766
7767 * window.c (Fwindow_end, window_scroll_pixel_based)
7768 (displayed_window_lines, Frecenter): Save and restore the bidi
7769 cache around display iteration.
7770
3bbd2265
LMI
77712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7772
7773 * editfns.c (Fdelete_region): Clarify the use of the named
7774 parameters (bug#6788).
7775
adc47434
MR
77762011-07-14 Martin Rudalics <rudalics@gmx.at>
7777
7778 * indent.c (Fvertical_motion): Set and restore w->pointm when
7779 saving and restoring the window's buffer (Bug#9006).
7780
837c31f8
LMI
77812011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7782
7783 * editfns.c (Fstring_to_char): Clarify just what is returned
7784 (bug#6576). Text by Eli Zaretskii.
7785
ac389d0c
JB
77862011-07-13 Juanma Barranquero <lekktu@gmail.com>
7787
7788 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7789
0be0ce47
EZ
77902011-07-13 Eli Zaretskii <eliz@gnu.org>
7791
7792 * buffer.c (mmap_find): Fix a typo.
7793
cd18e7e3
JB
77942011-07-13 Johan Bockgård <bojohan@gnu.org>
7795
7796 Fix execution of x selection hooks.
7797 * xselect.c (Qx_lost_selection_functions)
7798 (Qx_sent_selection_functions): New vars.
7799 (syms_of_xselect): DEFSYM them.
7800 (x_handle_selection_request): Pass Qx_sent_selection_functions
7801 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7802 (x_handle_selection_clear,x_clear_frame_selections):
7803 Pass Qx_lost_selection_functions rather than
7804 Vx_lost_selection_functions to Frun_hook_with_args.
7805
47ea7f44
PE
78062011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7807
ac389d0c 7808 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7809 The old code sometimes used this field without initializing it.
7810
47ea7f44
PE
7811 * alloc.c (gc_sweep): Don't read past end of array.
7812 In theory, the old code could also have corrupted Emacs internals,
7813 though it'd be very unlikely.
7814
bc985c87
AS
78152011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7816
7817 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7818 argument. (Bug#4026)
bc985c87 7819
0cf34688
LMI
78202011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7821
b3dadd76
LMI
7822 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7823 key" (bug#4257).
7824
0cf34688
LMI
7825 * window.c (Fset_window_start): Doc fix (bug#4199).
7826 (Fset_window_hscroll): Ditto.
7827
270768cd
PE
78282011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7829
077e3dda 7830 Fix minor new problems caught by GCC 4.6.1.
270768cd 7831 * term.c (init_tty): Remove unused local.
490011a6 7832 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7833 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7834 not used otherwise.
270768cd 7835
b1f58454
CY
78362011-07-12 Chong Yidong <cyd@stupidchicken.com>
7837
7838 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7839
22b9578d
LMI
78402011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7841
6e70ab07
LMI
7842 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7843 are the mini-buffer and the echo area (bug#3320).
7844
22b9578d
LMI
7845 * term.c (init_tty): Remove support for supdup, c10 and perq
7846 terminals, which are no longer supported (bug#1482).
7847
8974cc9f
JB
78482011-07-10 Johan Bockgård <bojohan@gnu.org>
7849
7850 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7851
a560d974
JD
78522011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7853
7854 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7855 for non-popups (Bug#3642).
7856
1dae0f0a
AS
78572011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7858
268c2c36 7859 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7860 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7861 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7862 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7863 * data.c (fmod): Likewise.
7864 * dispnew.c (swap_glyphs_in_rows): Likewise.
7865 * emacs.c (memory_warning_signal): Likewise.
7866 * floatfns.c (float_error): Likewise.
7867 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7868 (otf_open, font_otf_capability, generate_otf_features)
7869 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7870 Likewise.
7871 * image.c (pbm_read_file): Likewise.
7872 * indent.c (string_display_width): Likewise.
7873 * intervals.c (check_for_interval, search_for_interval)
7874 (inc_interval_count, count_intervals, root_interval)
7875 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7876 * lread.c (defalias): Likewise.
268c2c36 7877 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7878 * regex.c (set_image_of_range_1, set_image_of_range)
7879 (regex_grow_registers): Likewise.
7880 * sysdep.c (strerror): Likewise.
7881 * termcap.c (valid_filename_p, tprint, main): Likewise.
7882 * tparam.c (main): Likewise.
7883 * unexhp9k800.c (run_time_remap, save_data_space)
7884 (update_file_ptrs, read_header, write_header, calculate_checksum)
7885 (copy_file, copy_rest, display_header): Likewise.
7886 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7887 Likewise.
7888 * xdisp.c (check_it): Likewise.
7889 * xfaces.c (register_color, unregister_color, unregister_colors):
7890 Likewise.
7891 * xfns.c (print_fontset_result): Likewise.
7892 * xrdb.c (member, fatal, main): Likewise.
7893
99033785
PE
78942011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7895
7896 Fix minor problems found by static checking (Bug#9031).
7897 * chartab.c (char_table_set_range, map_sub_char_table):
7898 Remove unused locals.
7899 (uniprop_table): Now static.
7900 * composite.c (_work_char): Remove unused static var.
7901
9cb2ac56
JB
79022011-07-09 Juanma Barranquero <lekktu@gmail.com>
7903
7904 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7905
f25661f0
JD
79062011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7907
7908 * gtkutil.c (qttip_cb): Remove code without function.
7909
8278c4fe
EZ
79102011-07-09 Eli Zaretskii <eliz@gnu.org>
7911
7912 * w32.c (pthread_sigmask): New stub.
7913
1692ae2d 79142011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7915
8a6ebd58 7916 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7917 sigprocmask is portable only for single-threaded applications, and
7918 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7919 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7920 (LIBES): Use it.
7921 * callproc.c (Fcall_process):
7922 * process.c (create_process):
7923 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7924 Use pthread_sigmask, not sigprocmask.
123403e4 7925
1b854618
JD
79262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7927
7928 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7929 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7930 wrong (Bug#8591).
7931
3fe4b549
JD
79322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7933
0ce7e563
JD
7934 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7935 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7936 (xg_hide_tooltip): Fix comment.
7937
3fe4b549
JD
7938 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7939 in registerServicesMenuSendTypes.
7940 (validRequestorForSendType): Don't check ns_return_types.
7941
7942 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7943 ns_return_type.
7944
5df75e47
JR
79452011-07-08 Jason Rumney <jasonr@gnu.org>
7946
22610910
JR
7947 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7948 SH_SHOW for hidden windows (Bug#5482).
7949
5df75e47
JR
7950 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7951 frame struct members of non-existent frames (Bug#6284).
7952
699c10bd
JD
79532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7954
4393663b
JD
7955 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7956 variable firstTime not needed on OSX >= 10.6.
7957 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7958 >= 10.5. Use setKnobProportion, setDoubleValue.
7959
7960 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7961 (MAC_OS_X_VERSION_10_5): Define if not defined.
7962 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7963 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7964 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7965
7966 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7967 cString and lossyCString on OSX >= 10.4.
4393663b 7968
58179cce 7969 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7970 sizeToFit on OSX >= 10.2.
7971
7972 * nsimage.m (allocInitFromFile): Don't use deprecated method
7973 bestRepresentationForDevice on OSX >= 10.6.
7974
7975 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7976 to avoid warning.
7977
7978 * emacs.c: Declare unexec_init_emacs_zone.
7979
a63e0781
JD
7980 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7981
699c10bd
JD
7982 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7983
7984 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7985 on svcsMenu (Bug#8842).
7986
7987 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7988 ns_return_types.
7989 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7990
7991 * nsterm.m (QUTF8_STRING): Declare.
7992 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7993 (validRequestorForSendType): Return type is (id).
7994 Change indexOfObjectIdenticalTo to indexOfObject.
7995 Check if we have local selection before returning self (Bug#8842).
7996 (writeSelectionToPasteboard): Put local selection into paste board
7997 if we have a local selection (Bug#8842).
7998 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7999
8000 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8001 (ns_get_local_selection): Declare.
8002
54e10184
LMI
80032011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8004
9888ff71
LMI
8005 * keymap.c (describe_map_tree): Don't insert a double newline at
8006 the end of the buffer (bug#1169) and return whether we inserted
8007 something.
8008
54e10184
LMI
8009 * callint.c (Fcall_interactively): Change "reading args" to
8010 "providing args" to try to clarify what it does (bug#1010).
8011
15fa4783
KH
80122011-07-07 Kenichi Handa <handa@m17n.org>
8013
8014 * composite.c (composition_compute_stop_pos): Ignore a static
8015 composition starting before CHARPOS (Bug#8915).
8016
8017 * xdisp.c (handle_composition_prop): Likewise.
8018
a8815b00
EZ
80192011-07-07 Eli Zaretskii <eliz@gnu.org>
8020
8021 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8022 (Bug#9015)
8023
ef7b981d 80242011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8025
8026 * character.h (unicode_category_t): New enum type.
8027
8028 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8029 (Qchar_code_property_table): New variable.
8030 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8031 (UNIPROP_COMPRESSED_FORM_P): New macros.
8032 (char_table_ascii): Uncompress the compressed values.
8033 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8034 Uncompress the compressed values.
ac389d0c 8035 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8036 (char_table_ref_and_range): Uncompress the compressed values.
8037 (sub_char_table_set): New arg is_uniprop. Callers changed.
8038 Uncompress the compressed values.
8039 (sub_char_table_set_range): Args changed. Callers changed.
8040 (char_table_set_range): Adjuted for the above change.
8041 (map_sub_char_table): Delete args default_val and parent. Add arg
8042 top. Give decoded values to a Lisp function.
640c8776 8043 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8044 values to a Lisp function. Gcpro more variables.
8045 (uniprop_table_uncompress)
8046 (uniprop_decode_value_run_length): New functions.
8047 (uniprop_decoder, uniprop_decoder_count): New variables.
8048 (uniprop_get_decoder, uniprop_encode_value_character)
8049 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8050 New functions.
8051 (uniprop_encoder, uniprop_encoder_count): New variables.
8052 (uniprop_get_encoder, uniprop_table)
8053 (Funicode_property_table_internal, Fget_unicode_property_internal)
8054 (Fput_unicode_property_internal): New functions.
8055 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8056 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8057 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8058 char-code-property-alist.
8059
640c8776 8060 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8061 Vunicode_category_table.
8062
640c8776 8063 * font.c (font_range): Adjust for the change of
c805dec0
KH
8064 Vunicode_category_table.
8065
76b397fb
DN
80662011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8067
8068 * m/iris4d.h: Remove file, move contents ...
8069 * s/irix6-5.h: ... here.
8070
22b4128e
PE
80712011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8072
8073 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8074 * alloc.c (mark_buffer):
8075 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8076 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8077 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8078 This isn't true in general, and it's particularly not true
8079 if Emacs is configured with --with-wide-int.
8080 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8081 New macros, used in the buffer.c change.
8082
869795d6
JD
80832011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8084
8085 * xsettings.c: Use both GConf and GSettings if both are available.
8086 (store_config_changed_event): Add comment.
8087 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8088 (store_tool_bar_style_changed): New functions.
5e617bc2 8089 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8090 (struct xsettings): Move font inside HAVE_XFT.
8091 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8092 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8093 Move inside HAVE_XFT.
640c8776 8094 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8095 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8096 also.
8097 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8098 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8099 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8100 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8101 (parse_settings): Move check for font inside HAVE_XFT.
8102 (read_settings, apply_xft_settings): Add comment.
8103 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8104 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8105 call store_font_name_changed.
8106 (xft_settings_event): Add comment.
8107 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8108 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8109 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8110 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8111 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8112 (xsettings_get_system_font, xsettings_get_system_normal_font):
8113 Add comment.
869795d6 8114
d8ed26bd
PE
81152011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8116
8117 Random fixes. E.g., (random) never returned negative values.
8118 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8119 subseconds part to the entropy, as that's a bit more random.
8120 Prefer signed to unsigned, since the signedness doesn't matter and
8121 in general we prefer signed. When given a limit, use a
8122 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8123 latter isn't right if USE_2_TAGS_FOR_INTS.
8124 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8125 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8126
cabf1cac
SM
81272011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8128
8129 * textprop.c (text_property_stickiness):
8130 Obey Vtext_property_default_nonsticky.
8131 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8132 * w32fns.c (syms_of_w32fns):
8133 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8134
6e9b2be9
PE
81352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8136
8137 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8138 This is more efficient than Ffile_directory_p and avoids a minor race.
8139
90186c68
LMI
81402011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8141
7c301272
LMI
8142 * buffer.c (Foverlay_put): Say what the return value is
8143 (bug#7835).
8144
c4f2d8d4
LMI
8145 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8146 is a directory before asking whether to use the file name
8147 (bug#7564).
ad637907
LMI
8148 (barf_or_query_if_file_exists): Make the "File is a directory"
8149 error be more correct.
c4f2d8d4 8150
90186c68
LMI
8151 * fns.c (Frequire): Remove the mention of the .gz files, since
8152 that's installation-specific, but keep the mention of
8153 `get-load-suffixes'.
8154
da64016e
PE
81552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8156
8157 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8158 Report string overflow if the output is too long.
8159
7d47b580
JB
81602011-07-04 Juanma Barranquero <lekktu@gmail.com>
8161
a555cb87
JB
8162 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8163 (syms_of_gnutls): Remove duplicate DEFSYM for
8164 Qgnutls_bootprop_verify_hostname_error, an error for
8165 Qgnutls_bootprop_verify_error (which is no longer used).
8166
7d47b580
JB
8167 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8168 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8169 Also (re)move comments that are misplaced or no longer relevant.
8170
1e49bfab
LMI
81712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8172
8173 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8174
1485f4c0
CY
81752011-07-03 Chong Yidong <cyd@stupidchicken.com>
8176
8177 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8178 and background color parameters if they have been changed.
8179
a9ab721e
LMI
81802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8181
8182 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8183
cf7cff57
PE
81842011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8185
2e13213d
PE
8186 * xsettings.c (SYSTEM_FONT): Define only when used.
8187 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8188
cf7cff57
PE
8189 * keymap.c (access_keymap_1): Now static.
8190
7a8e04f7
CY
81912011-07-02 Chong Yidong <cyd@stupidchicken.com>
8192
8193 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8194 leave any prefix arg for the up event (Bug#1586).
8195
61352f62
LMI
81962011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8197
69bb1ef7
LMI
8198 * lread.c (syms_of_lread): Mention single symbols defined by
8199 `defvar' or `defconst' (bug#7154).
8200
61352f62 8201 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8202 (Frequire): Mention get-load-suffixes.
61352f62 8203
28545e04
MR
82042011-07-02 Martin Rudalics <rudalics@gmx.at>
8205
8206 * window.h (window): Remove clone_number slot.
8207 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8208 Remove.
8209 (make_parent_window, make_window, saved_window)
8210 (Fset_window_configuration, save_window_save): Don't deal with
8211 clone numbers.
8212 * buffer.c (Qclone_number): Remove declaration.
8213 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8214
3349e122
SM
82152011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8216
8217 Add multiple inheritance to keymaps.
8218 * keymap.c (Fmake_composed_keymap): New function.
8219 (Fset_keymap_parent): Simplify.
8220 (fix_submap_inheritance): Remove.
8221 (access_keymap_1): New function extracted from access_keymap to handle
8222 embedded parents and handle lists of maps.
8223 (access_keymap): Use it.
8224 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8225 (Fcopy_keymap): Handle embedded parents.
8226 (Fcommand_remapping, define_as_prefix): Simplify.
8227 (Fkey_binding): Simplify.
8228 (syms_of_keymap): Move minibuffer-local-completion-map,
8229 minibuffer-local-filename-completion-map,
8230 minibuffer-local-must-match-map, and
8231 minibuffer-local-filename-must-match-map to Elisp.
8232 (syms_of_keymap): Defsubr make-composed-keymap.
8233 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8234 (parse_menu_item): Trivial simplification.
8235
3279eb87
GM
82362011-07-01 Glenn Morris <rgm@gnu.org>
8237
8238 * Makefile.in (SETTINGS_LIBS): Fix typo.
8239
4550efdf
KI
82402011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8241
8242 * coding.c (Fencode_coding_string): Record the last coding system
8243 used, as the function doc string says (bug#8738).
8244
0949d2b6
JD
82452011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8246
8247 * xsettings.c (store_monospaced_changed): Take new font as arg and
8248 check for change against current_mono_font.
8249 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8250 (emacs_settings_constructor, emacs_settings_get_property)
8251 (emacs_settings_set_property, emacs_settings_class_init)
8252 (emacs_settings_init, gsettings_obj): Remove.
8253 (something_changedCB): New function for HAVE_GSETTINGS.
8254 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8255 with value as argument.
8256 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8257 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8258 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8259 "changed".
8260
8261 * xgselect.c: Add defined (HAVE_GSETTINGS).
8262 (xgselect_initialize): Ditto.
8263
8264 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8265 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8266 xg_select.
8267
bbc6b304
PE
82682011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8269
8270 * eval.c (struct backtrace): Simplify and port the data structure.
8271 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8272 signed bit field, as this assumption is not portable and it makes
8273 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8274 "char debug_on_exit : 1" as this is not portable either; instead,
8275 use the portable "unsigned int debug_on_exit : 1". Remove unused
8276 member evalargs. Remove obsolete comments about cc bombing out.
8277
9851bfc5
JD
82782011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8279
51bb811f 8280 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8281 Let HAVE_GSETTINGS override HAVE_GCONF.
8282 (store_monospaced_changed): New function.
8283 (EMACS_SETTINGS): A new type derived from GObject to handle
8284 GSettings notifications.
8285 (emacs_settings_constructor, emacs_settings_get_property)
8286 (emacs_settings_set_property, emacs_settings_class_init):
8287 New functions.
8288 (gsettings_client, gsettings_obj): New variables.
8289 (GSETTINGS_SCHEMA): New define.
8290 (something_changedCB): Call store_monospaced_changed.
8291 (init_gsettings): New function.
8292 (xsettings_initialize): Call init_gsettings.
8293 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8294 to NULL.
8295
640c8776 8296 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8297 GCONF_CFLAGS/LIBS.
8298
5386012d
MR
82992011-06-29 Martin Rudalics <rudalics@gmx.at>
8300
8301 * window.c (resize_root_window, grow_mini_window)
8302 (shrink_mini_window): Rename Qresize_root_window to
8303 Qwindow_resize_root_window and Qresize_root_window_vertically to
8304 Qwindow_resize_root_window_vertically.
8305
f13e0b08
PE
83062011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8307
8308 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8309
94515237
JB
83102011-06-27 Juanma Barranquero <lekktu@gmail.com>
8311
8312 * makefile.w32-in: Redesign dependencies so they reflect more
8313 clearly which files are directly included by each source file,
8314 and not through other includes.
8315
e43b6e43
MR
83162011-06-27 Martin Rudalics <rudalics@gmx.at>
8317
8318 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8319 (sort_overlays, overlay_strings): When an overlay's clone number
8320 matches the window's clone number process the overlay even if
8321 the overlay's window property doesn't match the current window.
8322
d68443dc
MR
8323 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8324 (Fwindow_hchild): Rename to Fwindow_left_child.
8325 (Fwindow_next): Rename to Fwindow_next_sibling.
8326 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8327 (resize_window_check): Rename to window_resize_check.
8328 (resize_window_apply): Rename to window_resize_apply.
8329 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8330 (Fdelete_other_windows_internal, resize_frame_windows)
8331 (Fsplit_window_internal, Fdelete_window_internal)
8332 (grow_mini_window, shrink_mini_window)
8333 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8334
c7e73be5
JD
83352011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8336
8337 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8338 (emacs_fixed_set_min_size): Remove.
8339 (emacs_fixed_new): Take frame as argument.
8340
8341 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8342 (_EmacsFixedPrivate): Remove minwidth/height.
8343 Add struct frame *f.
8344 (emacs_fixed_init): Initialize priv->f.
8345 (get_parent_class, emacs_fixed_set_min_size): Remove.
8346 (emacs_fixed_new): Set priv->f to argument.
8347 (emacs_fixed_get_preferred_width)
8348 (emacs_fixed_get_preferred_height): Use min_width/height from
8349 frames size_hint to set minimum and natural (Bug#8919).
8350 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8351 and use min_width/height from frames size_hint to set
8352 min_width/height (Bug#8919).
8353
8354 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8355 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8356 Fix indentation.
c7e73be5 8357
cf99dcf8
EZ
83582011-06-26 Eli Zaretskii <eliz@gnu.org>
8359
8360 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8361 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8362 called at ZV.
8363
029529ac
CY
83642011-06-26 Chong Yidong <cyd@stupidchicken.com>
8365
8366 * process.c (wait_reading_process_output): Bypass select if
8367 waiting for a cell while ignoring keyboard input, and input is
8368 pending. Suggested by Jan Djärv (Bug#8869).
8369
7a7ef429
PE
83702011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8371
8372 Use gnulib's dup2 module instead of rolling our own.
8373 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8374
11fdef7d 83752011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8376
8377 * dispnew.c (scrolling_window): Before scrolling, turn off a
8378 mouse-highlight in the window being scrolled.
8379
cd3520a4
JB
83802011-06-24 Juanma Barranquero <lekktu@gmail.com>
8381
8382 Move DEFSYM to lisp.h and use everywhere.
8383
8384 * character.h (DEFSYM): Move declaration...
8385 * lisp.h (DEFSYM): ...here.
8386
8387 * gnutls.c:
8388 * minibuf.c:
8389 * w32menu.c:
8390 * w32proc.c:
8391 * w32select.c: Don't include character.h.
8392
8393 * alloc.c (syms_of_alloc):
8394 * buffer.c (syms_of_buffer):
8395 * bytecode.c (syms_of_bytecode):
8396 * callint.c (syms_of_callint):
8397 * casefiddle.c (syms_of_casefiddle):
8398 * casetab.c (init_casetab_once):
8399 * category.c (init_category_once, syms_of_category):
8400 * ccl.c (syms_of_ccl):
8401 * cmds.c (syms_of_cmds):
8402 * composite.c (syms_of_composite):
8403 * dbusbind.c (syms_of_dbusbind):
8404 * dired.c (syms_of_dired):
8405 * dispnew.c (syms_of_display):
8406 * doc.c (syms_of_doc):
8407 * editfns.c (syms_of_editfns):
8408 * emacs.c (syms_of_emacs):
8409 * eval.c (syms_of_eval):
8410 * fileio.c (syms_of_fileio):
8411 * fns.c (syms_of_fns):
8412 * frame.c (syms_of_frame):
8413 * fringe.c (syms_of_fringe):
8414 * insdel.c (syms_of_insdel):
8415 * keymap.c (syms_of_keymap):
8416 * lread.c (init_obarray, syms_of_lread):
8417 * macros.c (syms_of_macros):
8418 * msdos.c (syms_of_msdos):
8419 * print.c (syms_of_print):
8420 * process.c (syms_of_process):
8421 * search.c (syms_of_search):
8422 * sound.c (syms_of_sound):
8423 * syntax.c (init_syntax_once, syms_of_syntax):
8424 * terminal.c (syms_of_terminal):
8425 * textprop.c (syms_of_textprop):
8426 * undo.c (syms_of_undo):
8427 * w32.c (globals_of_w32):
8428 * window.c (syms_of_window):
8429 * xdisp.c (syms_of_xdisp):
8430 * xfaces.c (syms_of_xfaces):
8431 * xfns.c (syms_of_xfns):
8432 * xmenu.c (syms_of_xmenu):
8433 * xsettings.c (syms_of_xsettings):
8434 * xterm.c (syms_of_xterm): Use DEFSYM.
8435
4228cf16
TZ
84362011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8437
cd3520a4 8438 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8439
7fcccf1e
PE
84402011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8441
7efb4e0e
PE
8442 Integer and buffer overflow fixes (Bug#8873).
8443
ff5844ad
PE
8444 * print.c (printchar, strout): Check for string overflow.
8445 (PRINTPREPARE, printchar, strout):
8446 Don't set size unless allocation succeeds.
8447
90532f02
PE
8448 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8449 for sizes. Check for string overflow more accurately.
8450 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8451
6d84508d
PE
8452 * macros.c: Integer and buffer overflow fixes.
8453 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8454 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8455 Use ptrdiff_t, not int, for sizes.
8456 Don't increment bufsize until after realloc succeeds.
8457 Check for size-calculation overflow.
8458 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8459
437b2cb4
PE
8460 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8461
8b9ac8b4
PE
8462 * lread.c: Integer overflow fixes.
8463 (read_integer): Radix is now EMACS_INT, not int,
8464 to improve quality of diagnostics for out-of-range radices.
8465 Calculate buffer size correctly for out-of-range radices.
8466 (read1): Check for integer overflow in radices, and in
8467 read-circle numbers.
82cb60d3
PE
8468 (read_escape): Avoid int overflow.
8469 (Fload, openp, read_buffer_size, read1)
8470 (substitute_object_recurse, read_vector, read_list, map_obarray):
8471 Use ptrdiff_t, not int, for sizes.
8472 (read1): Use EMACS_INT, not int, for sizes.
20270765 8473 Check for size overflow.
8b9ac8b4 8474
7fcccf1e
PE
8475 * image.c (cache_image): Check for size arithmetic overflow.
8476
bfbbd7e7
PE
8477 * lread.c: Integer overflow issues.
8478 (saved_doc_string_size, saved_doc_string_length)
8479 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8480 Now ptrdiff_t, not int.
8481 (read1): Don't assume doc string length fits in int. Check for
8482 out-of-range doc string lengths.
8483 (read_list): Don't assume file position fits in int.
39019e54 8484 (read_escape): Check for hex character overflow.
bfbbd7e7 8485
4e323265
LL
84862011-06-22 Leo Liu <sdl.web@gmail.com>
8487
8488 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8489 Move to minibuffer.el.
8490
85fece3e
PE
84912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8492
20b84ce9 8493 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8494 The following patches are for when GLYPH_DEBUG && !XASSERT.
8495 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8496 * dispnew.c (flush_stdout):
8497 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8498 Mark as externally visible.
8499 * dispnew.c (check_window_matrix_pointers): Now static.
8500 * dispnew.c (window_to_frame_vpos):
8501 * xfns.c (unwind_create_frame):
8502 * xterm.c (x_check_font): Remove unused local.
8503 * scroll.c (CHECK_BOUNDS):
8504 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8505 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8506 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8507 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8508 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8509 Now static.
8510 (debug_method_add): Use va_list and vsprintf rather than relying
8511 on undefined behavior with wrong number of arguments.
8512 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8513 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8514 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8515 since we're not interested in debugging glyphs with old libraries.
8516 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8517 GCC 4.6.0's static checking.
8518
0766b489
PE
85192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8520
31fd4b32
PE
8521 Integer overflow and signedness fixes (Bug#8873).
8522 A few related buffer overrun fixes, too.
8523
b79e8648
PE
8524 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8525
0766b489
PE
8526 * dispextern.h (struct face.stipple):
8527 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8528 (x_bitmap_mask, x_allocate_bitmap_record)
8529 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8530 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8531 (x_create_bitmap_from_xpm_data):
8532 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8533 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8534 (.bitmaps_last):
8535 * xfaces.c (load_pixmap):
8536 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8537 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8538 (.bitmaps_last, struct x_output.icon_bitmap):
8539 Use ptrdiff_t, not int, for bitmap indexes.
8540 (x_allocate_bitmap_record): Check for size overflow.
8541 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8542
b081724f
PE
8543 Use ptrdiff_t, not int, for overlay counts.
8544 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8545 * editfns.c (overlays_around, get_pos_property):
8546 * textprop.c (get_char_property_and_overlay):
8547 * xdisp.c (next_overlay_change, note_mouse_highlight):
8548 * xfaces.c (face_at_buffer_position):
21514da7
PE
8549 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8550 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8551 (Fnext_overlay_change, Fprevious_overlay_change)
8552 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8553 Use ptrdiff_t, not int, for sizes.
21514da7 8554 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8555
3de73e5e
PE
8556 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8557
2606c57b
PE
8558 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8559 (x_session_initialize): Do not assume string length fits in int.
8560
aaafe47a
PE
8561 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8562 This is unlikely, but can occur if DPI is outlandish.
8563
2674ddc8 8564 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8565 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8566
28154962
PE
8567 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8568 * xrdb.c (magic_file_p, search_magic_path):
8569 Omit last arg SUFFIX; it was always 0. All callers changed.
8570 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8571
7de51af5
PE
8572 * xfont.c (xfont_match): Avoid need for strlen.
8573
25ed6cc3
PE
8574 * xfns.c: Don't assume strlen fits in int.
8575 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8576
4eab31dd
PE
8577 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8578 not unsigned long, as we prefer signed integers. All callers changed.
8579 Detect integer overflow in repeat count.
8580 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8581 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8582
171e2a58
PE
8583 * termcap.c: Don't assume sizes fit in int and never overflow.
8584 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8585 (gobble_line): Check for size-calculation overflow.
8586
ad39faca 8587 * minibuf.c (Fread_buffer):
6e5bb2dc 8588 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8589 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8590 Don't assume string length fits in int.
8591
52c61c22 8592 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8593 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8594
b5b8c9e5
PE
8595 * font.c: Don't assume string length fits in int.
8596 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8597 Use ptrdiff_t, not int.
ccd6111c
PE
8598 (font_intern_prop): Don't assume string length fits in int.
8599 Don't assume integer property fits in fixnum.
8600 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8601
882f0d81 8602 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8603 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8604 Reformulate so as not to need the command string.
8605 Invoke gzip -cd rather than gunzip, as it's more portable.
8606 (lock_info_type, lock_file_1, lock_file):
8607 Don't assume pid_t and time_t fit in unsigned long.
8608 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8609 (current_lock_owner): Prefer signed type for sizes.
8610 Use memcpy, not strncpy, where memcpy is what is really wanted.
8611 Don't assume (via atoi) that time_t and pid_t fit in int.
8612 Check for time_t and/or pid_t out of range, e.g., via a network share.
8613 Don't alloca where an auto var works fine.
8614
93f4cf88
PE
8615 * fileio.c: Fix some integer overflow issues.
8616 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8617 Don't assume string length fits in int.
8618 (directory_file_name): Don't assume string length fits in long.
8619 (make_temp_name): Don't assume pid fits in int, or that its print
8620 length is less than 20.
8621
f3e92b69
PE
8622 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8623
1bfdaf10
PE
8624 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8625
35016e9a
PE
8626 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8627
3d1e65a1
PE
8628 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8629 We prefer signed integers, even for size calculations.
8630
0b963a93
PE
8631 * emacs.c: Don't assume string length fits in 'int'.
8632 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8633 (main): Don't invoke strlen when not needed.
8634
573f4b54
PE
8635 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8636 (XD_DEBUG_MESSAGE): Don't waste a byte.
8637
989f33ba
PE
8638 * callproc.c (getenv_internal_1, getenv_internal)
8639 (Fgetenv_internal):
965d34eb
PE
8640 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8641
e4d29b33
PE
8642 * lread.c (invalid_syntax): Omit length argument.
8643 All uses changed. This doesn't fix a bug, but it simplifies the
8644 code away from its former Hollerith-constant appearance, and it's
8645 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8646 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8647
eb49b136
PE
8648 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8649 This didn't break anything, but it didn't help either.
8650 It's confusing to put a bogus integer in a place where the actual
8651 value does not matter.
9f62aeb1 8652 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8653 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8654
15375a22
PE
8655 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8656 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8657 implementation.
b61cc01c
PE
8658 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8659 We prefer signed types, and the value cannot exceed the EMACS_INT
8660 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8661 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8662 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8663 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8664
53b2623d
PE
8665 * indent.c (sane_tab_width): New function.
8666 (current_column, scan_for_column, Findent_to, position_indentation)
8667 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8668 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8669
51cab52b 8670 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8671
f2ed8a70
PE
8672 * lisp.h (lint_assume): New macro.
8673 * composite.c (composition_gstring_put_cache):
8674 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8675
abe80cc6
PE
8676 * editfns.c, insdel.c:
8677 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8678
b02c740e
PE
8679 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8680
ebc96716
PE
8681 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8682
b4e50fa0 8683 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8684 Use much-faster test for byte-length change.
311d5d7c 8685 Don't assume string byte-length fits in 'int'.
a4cf38e4 8686 Check that character arg fits in 'int'.
85461888 8687 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8688
c0c1ee9f
PE
8689 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8690
a498d7f4
PE
8691 * fns.c (concat): Catch string overflow earlier.
8692 Do not rely on integer wraparound.
8693
51cab52b
PE
8694 * dispextern.h (struct it.overlay_strings_charpos)
8695 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8696 * xdisp.c (forward_to_next_line_start)
8697 (back_to_previous_visible_line_start)
8698 (reseat_at_next_visible_line_start, next_element_from_buffer):
8699 Don't arbitrarily truncate the value of 'selective' to int.
8700
76031fad
PE
8701 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8702
5eb55db9
PE
8703 * composite.c: Don't truncate sizes to 'int'.
8704 (composition_gstring_p, composition_reseat_it)
8705 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8706 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8707 not EMACS_UINT, for indexes.
5eb55db9 8708
0703a717
PE
8709 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8710
d6202519
PE
8711 * buffer.c: Include <verify.h>.
8712 (struct sortvec.priority, struct sortstr.priority):
8961a454 8713 Now EMACS_INT, not int.
c20998a7 8714 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8715 (struct sortstr.size, record_overlay_string)
8716 (struct sortstrlist.size, struct sortlist.used):
8717 Don't truncate size to int.
8718 (record_overlay_string): Check for size-calculation overflow.
d6202519 8719 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8720
d5a19415
JM
87212011-06-22 Jim Meyering <meyering@redhat.com>
8722
029529ac 8723 Don't leak an XBM-image-sized buffer
d5a19415
JM
8724 * image.c (xbm_load): Free the image buffer after using it.
8725
a9041e6c
PE
87262011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8727
8728 Port to Sun C.
8729 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8730 that Sun C diagnosed.
8731 * fns.c (secure_hash): Fix pointer signedness issue.
8732 * intervals.c (static_offset_intervals): New function.
8733 (offset_intervals): Use it.
8734
7f3f739f
LL
87352011-06-21 Leo Liu <sdl.web@gmail.com>
8736
8737 * deps.mk (fns.o):
8738 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8739 sha512.h.
8740
8741 * fns.c (secure_hash): Rename from crypto_hash_function and change
8742 the first arg to accept symbols.
5b66d427 8743 (Fsecure_hash): New primitive.
7f3f739f
LL
8744 (syms_of_fns): New symbols.
8745
76147d94
DD
87462011-06-20 Deniz Dogan <deniz@dogan.se>
8747
8748 * process.c (Fset_process_buffer): Clarify return value in
8749 docstring.
8750
7d7d0045
CY
87512011-06-18 Chong Yidong <cyd@stupidchicken.com>
8752
8753 * dispnew.c (add_window_display_history): Use BVAR.
8754
8755 * xdisp.c (debug_method_add): Use BVAR.
8756 (check_window_end, dump_glyph_matrix, dump_glyph)
8757 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8758
8759 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8760 Likewise.
8761
8762 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8763 check till after the cache is created in init_frame_faces.
8764
ff2bc410
SM
87652011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8766
8767 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8768
28177add
PE
87692011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8770
dd3482fe
PE
8771 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8772 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8773 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8774
393d71f3 8775 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8776 * fileio.c (Finsert_file_contents):
8777 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8778 Remove the old (too-loose) buffer overflow checks.
8779 They weren't needed, since make_gap checks for buffer overflow.
8780 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8781 The old code merely checked for Emacs fixnum overflow, and relied
8782 on undefined (wraparound) behavior. The new code avoids undefined
8783 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8784
2e6813b0 8785 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8786 Tune. Don't use wider integers than needed. Don't use alloca.
8787 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8788
599a9e4f
PE
8789 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8790
99561444
PE
8791 * insdel.c, lisp.h (buffer_overflow): New function.
8792 (insert_from_buffer_1, replace_range, replace_range_2):
8793 * insdel.c (make_gap_larger):
8794 * editfns.c (Finsert_char):
8795 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8796
28177add
PE
8797 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8798
e69dafad
PE
87992011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8800
4baa020d 8801 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8802
b1c46f02
PE
8803 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8804 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8805
e69dafad
PE
8806 * fileio.c: Don't assume EMACS_INT fits in off_t.
8807 (emacs_lseek): New static function.
8808 (Finsert_file_contents, Fwrite_region): Use it.
8809 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8810
566684ea
PE
8811 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8812
e6966cd6
PE
8813 * fns.c: Don't overflow int when computing a list length.
8814 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8815 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8816 truncation on 64-bit hosts. Check for QUIT every
8817 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8818 faster and is responsive enough.
8819 (Flength): Report an error instead of overflowing an integer.
8820 (Fsafe_length): Return a float if the value is not representable
8821 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8822 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8823 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8824
dd0b0efb
PE
8825 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8826 (header_size, word_size): New constants.
8827 (allocate_vectorlike): Don't check size overflow here.
8828 (allocate_vector): Check it here instead, since this is the only
8829 caller of allocate_vectorlike that could cause overflow.
8830 Check that the new vector's length is representable as a fixnum.
8831
86fe5cfe
PE
8832 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8833 The previous code was bogus. For example, next_almost_prime (32)
8834 returned 39, which is undesirable as it is a multiple of 3; and
8835 next_almost_prime (24) returned 25, which is a multiple of 5 so
8836 why was the code bothering to check for multiples of 7?
8837
80e88859
PE
8838 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8839
4a2f0ad6
PE
8840 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8841
f66c7cf8
PE
8842 Variadic C functions now count arguments with ptrdiff_t.
8843 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8844 Back then I didn't know that the Emacs coding style prefers signed int.
8845 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8846 were being counted with int, which may truncate counts on 64-bit
8847 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8848 * lisp.h (struct Lisp_Subr.function.aMANY)
8849 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8850 Arg counts are now ptrdiff_t, not size_t.
8851 All variadic functions and their callers changed accordingly.
8852 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8853 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8854 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8855 * callint.c (Fcall_interactively): Check arg count for overflow,
8856 to avoid potential buffer overrun. Use signed char, not 'int',
8857 for 'varies' array, so that we needn't bother to check its size
8858 calculation for overflow.
8859 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8860 * eval.c (apply_lambda):
8861 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8862 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8863 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8864
a1759b76
PE
8865 * callint.c (Fcall_interactively): Don't use index var as event count.
8866
d96be9fc
PE
8867 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8868 * mem-limits.h (SIZE): Remove; no longer used.
8869
a690a978 8870 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8871
578c21e6
PE
8872 Remove unnecessary casts.
8873 * xterm.c (x_term_init):
8874 * xfns.c (x_set_border_pixel):
8875 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8876 These aren't needed now that we assume ANSI C.
8877
96f53c6c
PE
8878 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8879 It's more likely to cause problems (due to unsigned overflow)
8880 than to cure them.
8881
83c77d31
PE
8882 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8883
ee2079f1
PE
8884 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8885
6da65536
PE
8886 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8887
7147c4a4
PE
8888 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8889
193e32d9
PE
8890 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8891
e5533da6
PE
8892 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8893
9910e595
PE
8894 GLYPH_CODE_FACE returns EMACS_INT, not int.
8895 * dispextern.h (merge_faces):
8896 * xfaces.c (merge_faces):
01103c44
PE
8897 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8898 Don't assume EMACS_INT fits in int.
9910e595 8899
2638320e
PE
8900 * character.h (CHAR_VALID_P): Remove unused parameter.
8901 * fontset.c, lisp.h, xdisp.c: All uses changed.
8902
045eb8d9
PE
8903 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8904
c1f134b5
PE
8905 * fns.c (concat): Minor tuning based on overflow analysis.
8906 This doesn't fix any bugs. Use int to hold character, instead
8907 of constantly refetching from Emacs object. Use XFASTINT, not
8908 XINT, for value known to be a character. Don't bother comparing
8909 a single byte to 0400, as it's always less.
8910
395fcb93 8911 * floatfns.c (Fexpt):
327eeec8
PE
8912 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8913
abbd3d23
PE
8914 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8915 for characters.
8916
684a03ef
PE
8917 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8918
0fed43f3
PE
8919 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8920 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8921 incorrectly succeed when S was a string, because 4294967386 was
8922 truncated before it was used.
8923
8fd02eb7
PE
8924 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8925 Otherwise, an out-of-range integer could cause undefined behavior
8926 on a 64-bit host.
8927
f8c86b69
PE
8928 * composite.c: Use int, not EMACS_INT, for characters.
8929 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8930 EMACS_INT, for values that are known to be in character range.
8931 This doesn't fix any bugs but is the usual style inside Emacs and
8932 may generate better code on 32-bit machines.
8933
34206dd2
PE
8934 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8935 This is for reasons similar to the recent CHAR_STRING fix.
8936 * charset.c (Fencode_char): Check that character arg is actually
8937 a character. Pass an int to ENCODE_CHAR.
8938 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8939 wider than 'int', as a compile-time check to prevent future regressions
8940 in this area.
8941
c5958d4c 8942 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8943
8944 Make sure a 64-bit char is never passed to CHAR_STRING.
8945 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8946 by silently ignoring the top 32 bits, allowing some values
8947 that were far too large to be valid characters.
8948 * character.h: Include <verify.h>.
8949 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8950 arguments are no wider than unsigned, as a compile-time check
8951 to prevent future regressions in this area.
8952 * data.c (Faset):
01103c44 8953 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8954 (Fsubst_char_in_region):
8955 * fns.c (concat):
8956 * xdisp.c (decode_mode_spec_coding):
8957 Adjust to CHAR_STRING's new requirement.
8958 * editfns.c (Finsert_char, Fsubst_char_in_region):
8959 * fns.c (concat): Check that character args are actually
8960 characters. Without this test, these functions did the wrong
8961 thing with wildly out-of-range values on 64-bit hosts.
8962
d37ca623
PE
8963 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8964 These casts should not be needed on 32-bit hosts, either.
8965 * keyboard.c (read_char):
8966 * lread.c (Fload): Remove casts to unsigned.
8967
ea204efb
PE
8968 * lisp.h (UNSIGNED_CMP): New macro.
8969 This fixes comparison bugs on 64-bit hosts.
8970 (ASCII_CHAR_P): Use it.
8971 * casefiddle.c (casify_object):
01103c44 8972 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8973 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8974 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8975 * dispextern.h (FACE_FROM_ID):
8976 * keyboard.c (read_char): Use UNSIGNED_CMP.
8977
41cb286c
PE
8978 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8979 not to EMACS_INT, to avoid GCC warning.
8980
4a1b9832
PE
8981 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8982
55daad71
PE
8983 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8984 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8985 isn't needed on 32-bit machines.
8f95c75c 8986
01103c44
PE
8987 * buffer.c (Fgenerate_new_buffer_name):
8988 Use EMACS_INT for count, not int.
0ceccced 8989 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8990
8991 * data.c (Qcompiled_function): Now static.
8992
c6f072e7
PE
8993 * window.c (window_body_lines): Now static.
8994
20ce5912
PE
8995 * image.c (gif_load): Rename local to avoid shadowing.
8996
9c4c5f81
PE
8997 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8998 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8999 * alloc.c (make_save_value): Integer argument is now of type
9000 ptrdiff_t, not int.
9001 (mark_object): Use ptrdiff_t, not int.
9002 * lisp.h (pD): New macro.
9003 * print.c (print_object): Use it.
9004
c0c5c8ae
PE
9005 * alloc.c: Use EMACS_INT, not int, to count objects.
9006 (total_conses, total_markers, total_symbols, total_vector_size)
9007 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9008 (total_free_floats, total_floats, total_free_intervals)
9009 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9010 Now EMACS_INT, not int. All uses changed.
9011 (Fgarbage_collect): Compute overall total using a double, so that
9012 integer overflow is less likely to be a problem. Check for overflow
9013 when converting back to an integer.
5a25e253
PE
9014 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9015 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9016 These were 'int' variables that could overflow on 64-bit hosts;
9017 they were never used, so remove them instead of repairing them.
211a0b2a 9018 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9019 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9020 Previously, this ceilinged at INT_MAX, but that doesn't work on
9021 64-bit machines.
e46bb31a 9022 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9023
c78baabf 9024 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9025 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9026 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9027 when a (possibly-narrower) signed value would do just as well.
9028 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9029
c9d624c6
PE
9030 * alloc.c: Catch some string size overflows that we were missing.
9031 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9032 for convenience in STRING_BYTES_MAX.
9033 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9034 The definition here is exact; the one in lisp.h was approximate.
9035 (allocate_string_data): Check for string overflow. This catches
9036 some instances we weren't catching before. Also, it catches
9037 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9038 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9039 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9040
c9d624c6
PE
9041 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9042 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9043 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9044
353032ce
PE
9045 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9046
2bccce07
PE
9047 * alloc.c (Fmake_string): Check for out-of-range init.
9048
0ac30604
SM
90492011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9050
9051 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9052
c195f2de
JD
90532011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9054
9055 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9056 xg_get_default_scrollbar_width.
9057
9058 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9059 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9060 (style_changed_cb): Call update_theme_scrollbar_width and call
9061 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9062 all frames (Bug#8505).
9063 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9064 Call gtk_window_set_resizable if HAVE_GTK3.
9065 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9066 and height if HAVE_GTK3 (Bug#8505).
9067 (scroll_bar_width_for_theme): New variable.
9068 (update_theme_scrollbar_width): New function.
9069 (xg_get_default_scrollbar_width): Move code to
9070 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9071 (xg_initialize): Call update_theme_scrollbar_width.
9072
9073 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9074
9075 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9076
e10ac9f1
MR
90772011-06-12 Martin Rudalics <rudalics@gmx.at>
9078
9079 * frame.c (make_frame): Call other_buffer_safely instead of
9080 other_buffer.
9081
9082 * window.c (temp_output_buffer_show): Call display_buffer with
9083 second argument Vtemp_buffer_show_specifiers and reset latter
9084 immediately after the call.
9085 (Vtemp_buffer_show_specifiers): New variable.
9086 (auto_window_vscroll_p, next_screen_context_lines)
9087 (Vscroll_preserve_screen_position): Remove leading asterisks from
9088 doc-strings.
9089
2d3c217e 90902011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9091
7b7f97e8 9092 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9093 * buffer.c (Qclone_number): Remove for now, as it's unused.
9094 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9095 (record_buffer): Remove unused local.
9096 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9097 (set_frame_buffer_list): Remove; unused.
9098 * frame.h (other_visible_frames): Remove decl.
9099 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9100 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9101 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9102 if HAVE_GPM.
9103 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9104 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9105 Define only if HAVE_GPM.
9106 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9107 (update_hints_inhibit): Remove; never set. All uses removed.
9108 * widgetprv.h (emacsFrameClassRec): Remove decl.
9109 * window.c (delete_deletable_window): Now returns void, since it
9110 wasn't returning anything.
9111 (compare_window_configurations): Remove unused locals.
9112 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9113 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9114 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9115 the same widths as pointers. This follows up on the 2011-05-06 patch.
9116 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9117 * xterm.h: Likewise.
9118 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9119
1384b89e
JB
91202011-06-12 Juanma Barranquero <lekktu@gmail.com>
9121
9122 * makefile.w32-in: Update dependencies.
9123 (LISP_H): Add lib/intprops.h.
9124
1100a63c
CY
91252011-06-11 Chong Yidong <cyd@stupidchicken.com>
9126
9127 * image.c (gif_load): Add animation frame delay to the metadata.
9128 (syms_of_image): Use DEFSYM. New symbol `delay'.
9129
6198ccd0
MR
91302011-06-11 Martin Rudalics <rudalics@gmx.at>
9131
9132 * window.c (delete_deletable_window): Re-add.
9133 (Fset_window_configuration): Rewrite to handle dead buffers and
9134 consequently deletable windows.
9135 (window_tree, Fwindow_tree): Remove. Supply functionality in
9136 window.el.
9137 (compare_window_configurations): Simplify code.
9138
b6e3633c
AS
91392011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9140
1ab0dee5
AS
9141 * image.c (imagemagick_load_image): Fix type mismatch.
9142 (Fimagemagick_types): Likewise.
9143
b6e3633c
AS
9144 * window.h (replace_buffer_in_windows): Declare.
9145
9397e56f
MR
91462011-06-11 Martin Rudalics <rudalics@gmx.at>
9147
9148 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9149 Qclone_number. Remove external declaration of Qdelete_window.
9150 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9151 code.
640c8776
SM
9152 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9153 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9154 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9155 buffer list implementation.
9156 (other_buffer_safely): New function.
9157 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9158 calls to replace_buffer_in_windows and
9159 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9160 if allowed.
9161 (record_buffer): Inhibit quitting and rewrite using quittable
9162 functions. Run Qbuffer_list_update_hook if allowed.
9163 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9164 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9165 Move switch-to-buffer to window.el.
9397e56f
MR
9166 (bury-buffer): Move to window.el.
9167 (Vbuffer_list_update_hook): New variable.
9168
9169 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9170 section.
9171
9172 * window.h (resize_frame_windows): Move up in code.
9173 (Fwindow_frame): Remove EXFUN.
9174 (replace_buffer_in_all_windows): Remove prototype.
9175 (replace_buffer_in_windows_safely): Add prototype.
9176
9177 * window.c: Declare Qdelete_window static again. Move down
9178 declaration of select_count.
9179 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9180 (Fother_window): Move to window.el.
9181 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9182 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9183 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9184 window.el.
9185 (replace_buffer_in_windows): Implement by calling
9186 Qreplace_buffer_in_windows.
9187 (replace_buffer_in_all_windows): Remove with some functionality
9188 moved into replace_buffer_in_windows_safely.
9189 (replace_buffer_in_windows_safely): New function.
9190 (select_window_norecord, select_frame_norecord): Move in front
9191 of run_window_configuration_change_hook. Remove now obsolete
9192 declarations.
640c8776
SM
9193 (Fset_window_buffer): Rewrite doc-string.
9194 Call Qrecord_window_buffer.
9397e56f
MR
9195 (keys_of_window): Move binding for other-window to window.el.
9196
b50691aa
CY
91972011-06-11 Chong Yidong <cyd@stupidchicken.com>
9198
9199 * dispextern.h (struct image): Replace data member, whose int_val
9200 and ptr_val fields were not used by anything, with a single
9201 lisp_val object.
9202
9203 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9204 (gif_clear_image, gif_load, imagemagick_load_image)
9205 (gs_clear_image, gs_load): Callers changed.
9206
3f754b86
PE
92072011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9208
cca69397
PE
9209 * buffer.h: Include <time.h>, for time_t.
9210 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9211
109e28d0
PE
9212 Fix minor problems found by static checking.
9213
60737f02
PE
9214 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9215
4b66faf3
PE
9216 Make identifiers static if they are not used in other modules.
9217 * data.c (Qcompiled_function, Qframe, Qvector):
9218 * image.c (QimageMagick, Qsvg):
9219 * minibuf.c (Qmetadata):
9220 * window.c (resize_window_check, resize_root_window): Now static.
9221 * window.h (resize_window_check, resize_root_window): Remove decls.
9222
109e28d0
PE
9223 * window.c (window_deletion_count, delete_deletable_window):
9224 Remove; unused.
46a4ce9e
PE
9225 (window_body_lines): Now static.
9226 (Fdelete_other_windows_internal): Mark vars as initialized.
9227 Make sure 'resize_failed' is initialized.
9228 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9229 (resize_window_apply): Remove unused local.
9230 * window.h (delete_deletable_window): Remove decl.
9231
109e28d0 9232 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9233 (imagemagick_load_image): Fix pointer signedness problem by changing
9234 last arg from unsigned char * to char *. All uses changed.
9235 Also, fix a local for similar reasons.
9236 Remove unused locals. Remove locals to avoid shadowing.
9237 (fn_rsvg_handle_free): Remove; unused.
9238 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9239 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9240
3f754b86
PE
9241 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9242
2547adb1
CY
92432011-06-10 Chong Yidong <cyd@stupidchicken.com>
9244
9245 * image.c (gif_load): Fix omitted cast error introduced by
9246 2011-06-06 change.
9247
2c8e37d4
MR
92482011-06-10 Martin Rudalics <rudalics@gmx.at>
9249
9250 * window.h (resize_proportionally, orig_total_lines)
9251 (orig_top_line): Remove from window structure.
9252 (set_window_height, set_window_width, change_window_heights)
9253 (Fdelete_window): Remove prototypes.
9254 (resize_frame_windows): Remove duplicate declaration.
9255
440a42e3
EZ
92562011-06-10 Eli Zaretskii <eliz@gnu.org>
9257
9258 * window.h (resize_frame_windows, resize_window_check)
9259 (delete_deletable_window, resize_root_window)
9260 (resize_frame_windows): Declare prototypes.
9261
9262 * window.c (resize_window_apply): Make definition be "static" to
9263 match the prototype.
9264
562dd5e9
MR
92652011-06-10 Martin Rudalics <rudalics@gmx.at>
9266
9267 * window.c: Remove declarations of Qwindow_size_fixed,
9268 window_min_size_1, window_min_size_2, window_min_size,
9269 size_window, window_fixed_size_p, enlarge_window, delete_window.
9270 Remove static from declaration of Qdelete_window, it's
9271 temporarily needed by Fbury_buffer.
9272 (replace_window): Don't assign orig_top_line and
9273 orig_total_lines.
9274 (Fdelete_window, delete_window): Remove. Window deletion is
9275 handled by window.el.
640c8776
SM
9276 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9277 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9278 (Fdelete_other_windows): Remove. Deleting other windows is
9279 handled by window.el.
9280 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9281 handled in window.el.
9282 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9283 Window minimum sizes are handled in window.el.
9284 (shrink_windows, size_window, set_window_height)
9285 (set_window_width, change_window_heights, window_height)
9286 (window_width, CURBEG, CURSIZE, enlarge_window)
9287 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9288 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9289 handled in window.el.
9290 (make_dummy_parent): Rename to make_parent_window and give it a
9291 second argument horflag.
9292 (make_window): Don't set resize_proportionally any more.
9293 (Fsplit_window): Remove. Windows are split in window.el.
9294 (save_restore_action, save_restore_orig_size)
9295 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9296 Resize mini windows in window.el.
9297 (grow_mini_window, shrink_mini_window): Implement by calling
9298 Qresize_root_window_vertically, resize_window_check and
9299 resize_window_apply.
640c8776
SM
9300 (saved_window, Fset_window_configuration, save_window_save):
9301 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9302 resize_proportionally.
9303 (window_min_height, window_min_width): Move to window.el.
9304 (keys_of_window): Move bindings for delete-other-windows,
9305 split-window, delete-window and enlarge-window to window.el.
9306
9307 * buffer.c: Temporarily extern Qdelete_window.
9308 (Fbury_buffer): Temporarily call Qdelete_window instead of
9309 Fdelete_window (Fbury_buffer will move to window.el soon).
9310
9311 * frame.c (set_menu_bar_lines_1): Remove code handling
9312 orig_top_line and orig_total_lines.
9313
9314 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9315 set_window_height but set heights directly.
9316 (change_frame_size_1): Use resize_frame_windows.
9317
9318 * xdisp.c (init_xdisp): Don't use set_window_height but set
9319 heights directly.
9320
640c8776
SM
9321 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9322 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9323 run_window_configuration_change_hook.
9324
9325 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9326 instead of change_window_heights and run
9327 run_window_configuration_change_hook.
9328
1a13852e
MR
93292011-06-09 Martin Rudalics <rudalics@gmx.at>
9330
9331 * window.c (replace_window): Rename second argument REPLACEMENT to
9332 NEW. New third argument SETFLAG. Rewrite.
9333 (delete_window, make_dummy_parent): Call replace_window with
9334 third argument 1.
9335 (window_list_1): Move down in code.
9336 (run_window_configuration_change_hook): Move set_buffer part
9337 before select_frame_norecord part in order to unwind correctly.
9338 Rename count1 to count.
9339 (recombine_windows, delete_deletable_window, resize_root_window)
9340 (Fdelete_other_windows_internal)
9341 (Frun_window_configuration_change_hook, make_parent_window)
9342 (resize_window_check, resize_window_apply, Fresize_window_apply)
9343 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9344 (Fdelete_window_internal, Fresize_mini_window_internal):
9345 New functions.
1a13852e
MR
9346 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9347
f3d1777e
MR
93482011-06-08 Martin Rudalics <rudalics@gmx.at>
9349
496e208e
MR
9350 * window.h (window): Add some new members to window structure -
9351 normal_lines, normal_cols, new_total, new_normal, clone_number,
9352 splits, nest, prev_buffers, next_buffers.
9353 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9354 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9355
f3d1777e
MR
9356 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9357 Remove.
496e208e
MR
9358 (make_dummy_parent): Set new members of windows structure.
9359 (make_window): Move down in code. Handle new members of window
9360 structure.
9361 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9362 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9363 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9364 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9365 (Fset_window_next_buffers, Fset_window_clone_number):
9366 New functions.
496e208e
MR
9367 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9368 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9369 Doc-string fixes.
9370 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9371 Argument WINDOW can be now internal window too.
9372 (Fwindow_use_time): Move up in code.
9373 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9374 Rewrite doc-string.
9375 (Fset_window_configuration, saved_window)
9376 (Fcurrent_window_configuration, save_window_save): Handle new
9377 members of window structure.
b9e809c2
MR
9378 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9379 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9380 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9381 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9382 Qget_mru_window, Qresize_root_window,
9383 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9384 Qauto_buffer_name; staticpro them.
f3d1777e 9385
abde8f8c
MR
93862011-06-07 Martin Rudalics <rudalics@gmx.at>
9387
9388 * window.c (Fwindow_total_size, Fwindow_left_column)
9389 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9390 (Fwindow_list_1): New functions.
9391 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9392 (Fwindow_width, Fscroll_left, Fscroll_right):
9393 Use window_body_cols instead of window_box_text_cols.
9394 (delete_window, Fset_window_configuration):
9395 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9396 (delete_all_subwindows): Take a window as argument and not a
9397 structure. Rewrite.
190b47e6
MR
9398 (window_loop): Remove handling of GET_LRU_WINDOW and
9399 GET_LARGEST_WINDOW.
9400 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9401
9402 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9403 window_box_text_cols. delete_all_subwindows now takes a
9404 Lisp_Object as argument.
abde8f8c 9405
640c8776
SM
9406 * indent.c (compute_motion, Fcompute_motion):
9407 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9408
fa8a67e6
MR
9409 * frame.c (delete_frame): Call delete_all_subwindows with root
9410 window as argument.
9411
a54e3482
DC
94122011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9413
9414 * fns.c (Fputhash): Document return value.
9415
60002bf5
CY
94162011-06-06 Chong Yidong <cyd@stupidchicken.com>
9417
9418 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9419
0c671da6 94202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9421
b862a52a 9422 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9423
be44ca6c
PE
9424 Check for overflow when converting integer to cons and back.
9425 * charset.c (Fdefine_charset_internal, Fdecode_char):
9426 Use cons_to_unsigned to catch overflow.
9427 (Fencode_char): Use INTEGER_TO_CONS.
9428 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9429 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9430 * data.c (long_to_cons, cons_to_long): Remove.
9431 (cons_to_unsigned, cons_to_signed): New functions.
9432 These signal an error for invalid or out-of-range values.
9433 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9434 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9435 * font.c (Ffont_variation_glyphs):
9436 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9437 * lisp.h: Include <intprops.h>.
9438 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9439 (cons_to_signed, cons_to_unsigned): New decls.
9440 (long_to_cons, cons_to_long): Remove decls.
9441 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9442 (Fprimitive_undo): Use CONS_TO_INTEGER.
9443 * xfns.c (Fx_window_property): Likewise.
9444 * xselect.c: Include <limits.h>.
9445 (x_own_selection, selection_data_to_lisp_data):
9446 Use INTEGER_TO_CONS.
9447 (x_handle_selection_request, x_handle_selection_clear)
9448 (x_get_foreign_selection, Fx_disown_selection_internal)
9449 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9450 (lisp_data_to_selection_data): Use cons_to_unsigned.
9451 (x_fill_property_data): Use cons_to_signed.
9452 Report values out of range.
9453
d1f3d2af
PE
9454 Check for buffer and string overflow more precisely.
9455 * buffer.h (BUF_BYTES_MAX): New macro.
9456 * lisp.h (STRING_BYTES_MAX): New macro.
9457 * alloc.c (Fmake_string):
9458 * character.c (string_escape_byte8):
9459 * coding.c (coding_alloc_by_realloc):
9460 * doprnt.c (doprnt):
9461 * editfns.c (Fformat):
9462 * eval.c (verror):
9463 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9464 since they may not be the same number.
9465 * editfns.c (Finsert_char):
9466 * fileio.c (Finsert_file_contents):
9467 Likewise for BUF_BYTES_MAX.
9468
dd52fcea
PE
9469 * image.c: Use ptrdiff_t, not int, for sizes.
9470 (slurp_file): Switch from int to ptrdiff_t.
9471 All uses changed.
9472 (slurp_file): Check that file size fits in both size_t (for
9473 malloc) and ptrdiff_t (for sanity and safety).
9474
7f9bbdbb
PE
9475 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9476 if b->modtime has its maximal value.
9477
dfe18f82
PE
9478 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9479
84acfcf0
PE
9480 Don't assume time_t can fit into int.
9481 * buffer.h (struct buffer.modtime): Now time_t, not int.
9482 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9483 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9484
ccd9a01a
PE
9485 Minor fixes for signed vs unsigned integers.
9486 * character.h (MAYBE_UNIFY_CHAR):
9487 * charset.c (maybe_unify_char):
9488 * keyboard.c (read_char, reorder_modifiers):
9489 XINT -> XFASTINT, since the integer must be nonnegative.
9490 * ftfont.c (ftfont_spec_pattern):
9491 * keymap.c (access_keymap, silly_event_symbol_error):
9492 XUINT -> XFASTINT, since the integer must be nonnegative.
9493 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9494 since it makes no difference and we prefer signed.
9495 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9496 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9497 nonnegative.
9498
d6d100dd
SM
94992011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9500
9501 * window.h (Fwindow_frame): Declare.
9502
2b6148e4
PE
95032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9504
9505 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9506 (SPARE_MEMORY): Always define.
9507 (LARGE_REQUEST): Remove.
9508 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9509
f230ecc9
MR
95102011-06-06 Martin Rudalics <rudalics@gmx.at>
9511
727e958e
MR
9512 * lisp.h: Move EXFUNS for Fframe_root_window,
9513 Fframe_first_window and Fset_frame_selected_window to window.h.
9514
9515 * window.h: Move EXFUNS for Fframe_root_window,
9516 Fframe_first_window and Fset_frame_selected_window here from
9517 lisp.h.
9518
9519 * frame.c (Fwindow_frame, Fframe_first_window)
9520 (Fframe_root_window, Fframe_selected_window)
9521 (Fset_frame_selected_window): Move to window.c.
9522 (Factive_minibuffer_window): Move to minibuf.c.
9523 (Fother_visible_frames_p): New function.
9524
9525 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9526
f230ecc9
MR
9527 * window.c (decode_window, decode_any_window): Move up in code.
9528 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9529 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9530 (Fwindow_buffer): Move up and rewrite doc-string.
9531 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9532 (Fwindow_prev): New functions.
727e958e
MR
9533 (Fwindow_frame): Move here from frame.c. Accept any window as
9534 argument.
9535 (Fframe_root_window, Fframe_first_window)
9536 (Fframe_selected_window): Move here from frame.c. Accept frame
9537 or arbitrary window as argument. Update doc-strings.
9538 (Fminibuffer_window): Move up in code.
9539 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9540 (Fset_frame_selected_window): Move here from frame.c.
9541 Marginal rewrite.
727e958e
MR
9542 (Fselected_window, select_window, Fselect_window): Move up in
9543 code. Minor doc-string fixes.
f230ecc9 9544
4d09bcf6
PE
95452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9546
9547 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9548 Do not assume that spare memory exists; that assumption is valid
9549 only if SYSTEM_MALLOC.
9550 (LARGE_REQUEST): New macro, so that the issue of large requests
9551 is separated from the issue of spare memory.
9552
810928a2
AS
95532011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9554
172418ad
AS
9555 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9556 format. (Bug#8806)
9557
43f862f7
AS
9558 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9559
810928a2
AS
9560 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9561 before statements.
9562
a059fe24
JD
95632011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9564
9565 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9566
9567 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9568
9569 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9570 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9571
989bf368
JB
95722011-06-05 Juanma Barranquero <lekktu@gmail.com>
9573
9574 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9575
4b80f674
CY
95762011-06-04 Chong Yidong <cyd@stupidchicken.com>
9577
9578 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9579 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9580 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9581 New error handlers.
4b80f674
CY
9582 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9583 Obey Vx_select_enable_clipboard_manager. Catch errors in
9584 x_clipboard_manager_save (Bug#8779).
9585 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9586 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9587
99a33b77 95882011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9589
9590 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9591
99a33b77 95922011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9593
9594 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9595 in the current matrix if keep_current_p is non-zero.
9596
8264569d
EZ
95972011-06-04 Eli Zaretskii <eliz@gnu.org>
9598
9599 * bidi.c (bidi_level_of_next_char): Fix last change.
9600
57f97249
EZ
96012011-06-03 Eli Zaretskii <eliz@gnu.org>
9602
fec2107c 9603 Support bidi reordering of text covered by display properties.
57f97249 9604
fec2107c
EZ
9605 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9606 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9607 (bidi_cache_search, bidi_cache_iterator_state)
9608 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9609 (bidi_level_of_next_char, bidi_move_to_visually_next):
9610 Support character positions inside a run of characters covered by a
fec2107c
EZ
9611 display string.
9612 (bidi_paragraph_init, bidi_resolve_explicit_1)
9613 (bidi_level_of_next_char): Call bidi_fetch_char and
9614 bidi_fetch_char_advance instead of FETCH_CHAR and
9615 FETCH_CHAR_ADVANCE.
9616 (bidi_init_it): Initialize new members.
9617 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9618 definitions.
9619 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9620 instead of using explicit *_CHAR codes.
d6d100dd
SM
9621 (bidi_resolve_explicit, bidi_resolve_weak):
9622 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9623 bidirectional text is supported only in multibyte buffers.
9624 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9625 it to initialize the frame_window_p member of struct bidi_it.
9626 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9627 (bidi_resolve_explicit, bidi_resolve_weak)
9628 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9629 bidi_it->nchars is non-positive.
9630 (bidi_level_of_next_char): Don't try to lookup the cache for the
9631 next/previous character if nothing is cached there yet, or if we
9632 were just reseat()'ed to a new position.
c40e2fb2 9633
0e14fe90
EZ
9634 * xdisp.c (set_cursor_from_row): Set start and stop points
9635 according to the row's direction when priming the loop that looks
9636 for the glyph on which to display cursor.
9637 (single_display_spec_intangible_p): Function deleted.
9638 (display_prop_intangible_p): Reimplement to call
9639 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9640 Accept 3 additional arguments needed by handle_display_spec.
9641 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9642 values: lists, `(when COND...)' forms, etc.
9643 (single_display_spec_string_p): Support property values that are
9644 lists with the argument STRING its top-level element.
9645 (display_prop_string_p): Fix the condition for processing a
9646 property that is a list to be consistent with handle_display_spec.
fec2107c 9647 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9648 last portion of handle_display_prop.
9649 (compute_display_string_pos): Accept additional argument
9650 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9651 value of a `display' property is a "replacing spec".
9652 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9653 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9654 the display property, but just return a value indicating whether
9655 the display property will replace the characters it covers.
9656 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9657 frame_window_p members of struct bidi_it.
d6d100dd
SM
9658 (compute_display_string_pos, compute_display_string_end):
9659 New functions.
fec2107c
EZ
9660 (push_it): Accept second argument POSITION, where pop_it should
9661 jump to continue iteration.
9662 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9663
fec2107c
EZ
9664 * keyboard.c (adjust_point_for_property): Adjust the call to
9665 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9666
9667 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9668 (bidi_init_it): Update prototypes.
9669 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9670 (compute_display_string_pos, compute_display_string_end):
9671 Declare prototypes.
fec2107c
EZ
9672 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9673 EMACS_INT.
fc6f18ce 9674
40087514 96752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9676
57f53182
PE
9677 Malloc failure behavior now depends on size of allocation.
9678 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9679 * lisp.h: Change signatures accordingly.
9680 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9681 All callers changed. (Bug#8762)
9682
9683 * gnutls.c: Use Emacs's memory allocators.
9684 Without this change, the gnutls library would invoke malloc etc.
9685 directly, which causes problems on non-SYNC_INPUT hosts, and which
9686 runs afoul of improving memory_full behavior. (Bug#8761)
9687 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9688 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9689 xfree instead of the default malloc, realloc, free.
9690 (Fgnutls_boot): No need to check for memory allocation failure,
9691 since xmalloc does that for us.
9692
ac32cd99 9693 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9694 * category.c (hash_get_category_set):
9695 * ccl.c (ccl_driver):
9696 * charset.c (Fdefine_charset_internal):
9697 * charset.h (struct charset.hash_index):
9698 * composite.c (get_composition_id, gstring_lookup_cache)
9699 (composition_gstring_put_cache):
9700 * composite.h (struct composition.hash_index):
9701 * dispextern.h (struct image.hash):
9702 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9703 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9704 (hashfn_equal, hashfn_user_defined, make_hash_table)
9705 (maybe_resize_hash_table, hash_lookup, hash_put)
9706 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9707 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9708 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9709 * image.c (make_image, search_image_cache, lookup_image)
9710 (xpm_put_color_table_h):
9711 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9712 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9713 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9714 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9715 * alloc.c (allocate_vectorlike):
9716 Check for overflow in vector size calculations.
9717 * ccl.c (ccl_driver):
9718 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9719 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9720 need to be updated by these changes.
40087514
PE
9721 * fns.c (make_hash_table, maybe_resize_hash_table):
9722 Check for integer overflow with large hash tables.
0de4bb68
PE
9723 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9724 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9725 (SXHASH_REDUCE): New macro.
9726 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9727 Use it instead of discarding useful hash info with large hash values.
9728 (sxhash_float): New function.
9729 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9730 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9731 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9732 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9733 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9734 Adjust signatures to match updated version of code.
9735 (consing_since_gc): Now EMACS_INT, since a single hash table can
9736 use more than INT_MAX bytes.
9737
698d32e2
DN
97382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9739
9740 Make it possible to build with GCC-4.6+ -O2 -flto.
9741
9742 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9743
fd6fa53f
SM
97442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9745
9746 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9747 Call minibuffer-inactive-mode.
9748
864db017
JB
97492011-05-31 Juanma Barranquero <lekktu@gmail.com>
9750
9751 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9752 Update dependencies.
9753
2ad0baf4
DN
97542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9755
9756 * data.c (init_data): Remove code for UTS, this system is not
9757 supported anymore.
9758
4fcc2638
DN
97592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9760
9761 Don't force ./temacs to start in terminal mode.
9762
9763 * frame.c (make_initial_frame): Initialize faces in all cases, not
9764 only when CANNOT_DUMP is defined.
9765 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9766
c56e0fd5
DN
97672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9768
9769 * dispnew.c (add_window_display_history): Use const for the string
9770 pointer. Remove declaration, not needed.
9771
333d54da 97722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9773
55d4c1b2 9774 Use 'inline', not 'INLINE'.
333d54da 9775 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9776 * alloc.c, fontset.c (INLINE): Remove.
9777 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9778 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9779 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9780 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9781 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9782
738db178
DN
97832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9784
9785 Make it possible to run ./temacs.
9786
9787 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9788 syms_of_callproc does the same thing. Remove test for
9789 "initialized", do it in the caller.
9790 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9791
620c53a6
SM
97922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9793
9794 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9795 (read_minibuf): Use get_minibuffer.
9796 (syms_of_minibuf): Use DEFSYM.
9797 (Qmetadata): New var.
9798 * data.c (Qbuffer): Don't make it static.
9799 (syms_of_data): Use DEFSYM.
9800
e003a292
PE
98012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9802
9803 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9804 (CCL_CODE_MIN): New macro.
9805
ed008a6d
PE
98062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9807
3687c2ef
PE
9808 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9809
ed008a6d
PE
9810 * eval.c (Qdebug): Now static.
9811 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9812 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9813 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9814
d66c4c7c
CY
98152011-05-29 Chong Yidong <cyd@stupidchicken.com>
9816
9817 * image.c: Various fixes to ImageMagick code comments.
9818 (Fimagemagick_types): Doc fix.
9819
5fbc2025
PE
98202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9821
0196f88a
PE
9822 Minor fixes prompted by GCC 4.6.0 warnings.
9823
9824 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9825
5fbc2025
PE
9826 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9827 (x_clipboard_manager_save_all): Move extern decl to ...
9828 * xterm.h: ... here, so that it can be checked for consistency.
9829
1dd3c2d9
CY
98302011-05-29 Chong Yidong <cyd@stupidchicken.com>
9831
9832 * xselect.c (x_clipboard_manager_save_frame)
9833 (x_clipboard_manager_save_all): New functions.
9834 (Fx_clipboard_manager_save): Lisp function deleted.
9835
9836 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9837 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9838
9839 * xterm.h: Update prototype.
9840
5ba6571d
WX
98412011-05-28 William Xu <william.xwl@gmail.com>
9842
9843 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9844 exiting (Bug#8239).
9845
3eaff834
JM
98462011-05-28 Jim Meyering <meyering@redhat.com>
9847
e1900994 9848 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9849 * fns.c (to_uchar): Define.
9850 (crypto_hash_function): Use it to convert some newly-signed
9851 variables to unsigned, to avoid sign-extension bugs. For example,
9852 without this change, (md5 "truc") would evaluate to
9853 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9854 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9855 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9856
0f6990a7
PE
98572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9858
9859 Integer overflow fixes.
c8a9ca5a 9860
08686060
PE
9861 * dbusbind.c: Serial number integer overflow fixes.
9862 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9863 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9864 to hold a serial number that is too large for a fixnum.
9865 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9866 Check for serial numbers out of range. Decode any serial number
59568bf0 9867 that was so large that it became a float. (Bug#8722)
08686060 9868
2d1fc3c7
PE
9869 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9870 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9871 Use XFASTINT rather than XUINT when numbers are nonnegative.
9872 (xd_append_arg, Fdbus_method_return_internal):
9873 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9874 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9875 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9876 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9877 (Bug#8722)
2d1fc3c7 9878
c8a9ca5a
PE
9879 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9880
519e1d69
PE
9881 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9882
6df6ae42 9883 ccl: Add integer overflow checks.
30569699
PE
9884 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9885 (IN_INT_RANGE): New macros.
9886 (ccl_driver): Use them to check for integer overflow when
9887 decoding a CCL program. Many of the new checks are whether XINT (x)
9888 fits in int; it doesn't always, on 64-bit hosts. The new version
9889 doesn't catch all possible integer overflows, but it's an
847044ea 9890 improvement. (Bug#8719)
30569699 9891
c11285dc
PE
9892 * alloc.c (make_event_array): Use XINT, not XUINT.
9893 There's no need for unsigned here.
9894
fdccd48e
PE
9895 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9896 This follows up to the 2011-05-06 change that substituted uintptr_t
9897 for EMACS_INT. This case wasn't caught back then.
9898
37910ab2
PE
9899 Rework Fformat to avoid integer overflow issues.
9900 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9901 now (part of C89). Include <verify.h>.
9902 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9903 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9904 (Fformat): Avoid the prepass trying to compute sizes; it was only
9905 approximate and thus did not catch overflow reliably. Instead, walk
9906 through the format just once, formatting and computing sizes as we go,
9907 checking for integer overflow at every step, and allocating a larger
9908 buffer as needed. Keep track separately whether the format is
9909 multibyte. Keep only the most-recently calculated precision, rather
9910 than them all. Record whether each argument has been converted to
9911 string. Use EMACS_INT, not int, for byte and char and arg counts.
9912 Support field widths and precisions larger than INT_MAX. Avoid
9913 sprintf's undefined behavior with conversion specifications such as %#d
9914 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9915 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9916 formatting out-of-range floating point numbers with int
9173deec 9917 formats. (Bug#8668)
37910ab2 9918
2e6578fb
PE
9919 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9920
0ae6bdee
PE
9921 * data.c: Avoid integer truncation in expressions involving floats.
9922 * data.c: Include <intprops.h>.
9923 (arith_driver): When there's an integer overflow in an expression
9924 involving floating point, convert the integers to floating point
9925 so that the resulting value does not suffer from catastrophic
9926 integer truncation. For example, on a 64-bit host (* 4
9927 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9928 Do not rely on undefined behavior after integer overflow.
9929
de883a70
PE
9930 merge count_size_as_multibyte, parse_str_to_multibyte
9931 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9932 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9933 Check for integer overflow.
9934 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9935 since it's now a duplicate of the other. This is more of
9936 a character than a buffer op, so better that it's in character.c.
9937 * fns.c, print.c: Adjust to above changes.
9938
2ff916cb
PE
99392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9940
9941 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9942
f1b54466
PE
99432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9944
fb1ac845
PE
9945 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9946 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9947 (x_clipboard_manager_save): Now static.
9948 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9949
f1b54466
PE
9950 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9951 (crypto_hash_function): Now static.
9952 Fix pointer signedness problems. Avoid unnecessary initializations.
9953
a9f737ee
CY
99542011-05-27 Chong Yidong <cyd@stupidchicken.com>
9955
9956 * termhooks.h (Vselection_alist): Make it terminal-local.
9957
9958 * terminal.c (create_terminal): Initialize it.
9959
9960 * xselect.c: Support for clipboard managers.
9961 (Vselection_alist): Move to termhooks.h as terminal-local var.
9962 (LOCAL_SELECTION): New macro.
9963 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9964 (symbol_to_x_atom): Remove gratuitous arg.
9965 (x_handle_selection_request, lisp_data_to_selection_data)
9966 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9967 (x_own_selection, x_get_local_selection, x_convert_selection):
9968 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9969 (some_frame_on_display): Delete unused function.
9970 (Fx_own_selection_internal, Fx_get_selection_internal)
9971 (Fx_disown_selection_internal, Fx_selection_owner_p)
9972 (Fx_selection_exists_p): New optional frame arg.
9973 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9974 (x_handle_selection_clear): Don't treat other terminals with the
9975 same keyboard specially. Use the terminal-local Vselection_alist.
9976 (x_clear_frame_selections): Use Frun_hook_with_args.
9977
9978 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9979
9980 * xterm.h: Add support for those atoms.
9981
e067f0c1
CY
99822011-05-26 Chong Yidong <cyd@stupidchicken.com>
9983
9984 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9985 (converted_selections, conversion_fail_tag): New global variables.
9986 (x_selection_request_lisp_error): Free the above.
9987 (x_get_local_selection): Remove unnecessary code.
9988 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9989 of converted selections stored in converted_selections.
9990 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9991 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9992 (x_convert_selection): New function.
9993 (x_handle_selection_event): Simplify.
9994 (x_get_foreign_selection): Don't ignore incoming requests while
9995 waiting for an answer; this will fail when we implement
9996 SAVE_TARGETS, and seems unnecessary anyway.
9997 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9998 (Vx_sent_selection_functions): Doc fix.
9999
0f4aebc0
LL
100002011-05-26 Leo Liu <sdl.web@gmail.com>
10001
10002 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10003
e61124cd
YM
100042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10005
10006 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10007
10008 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10009 for fringe update if it has periodic bitmap.
ac389d0c 10010 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10011 and fringe_bitmap_periodic_p.
10012
10013 * fringe.c (get_fringe_bitmap_data): New function.
10014 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10015 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10016 row. Mark glyph row for fringe update if periodicity changed.
10017
10018 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10019 for fringe update unless it has periodic bitmap.
10020
f16d9837
KH
100212011-05-25 Kenichi Handa <handa@m17n.org>
10022
10023 * xdisp.c (get_next_display_element): Set correct it->face_id for
10024 a static composition.
10025
e1b90ef6
LL
100262011-05-24 Leo Liu <sdl.web@gmail.com>
10027
10028 * deps.mk (fns.o):
10029 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10030
10031 * fns.c (crypto_hash_function, Fsha1): New function.
10032 (Fmd5): Use crypto_hash_function.
10033 (syms_of_fns): Add Ssha1.
10034
7400048f
PE
100352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10036
10037 * gnutls.c: Remove unused macros.
10038 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10039 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10040 Remove macros that are defined and never used.
10041 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10042
abb71cf4
CY
100432011-05-22 Chong Yidong <cyd@stupidchicken.com>
10044
10045 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10046 (Fx_get_selection_internal): Minor cleanup.
10047 (Fx_own_selection_internal): Rename arguments for consistency with
10048 select.el.
10049
6307db39
PE
100502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10051
10052 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10053
f3d4e0a4
CY
100542011-05-22 Chong Yidong <cyd@stupidchicken.com>
10055
10056 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10057
4d8ade89
YM
100582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10059
10060 * dispnew.c (scrolling_window): Don't exclude the case that the
10061 last enabled row in the desired matrix touches the bottom boundary.
10062
32078c8d
GM
100632011-05-21 Glenn Morris <rgm@gnu.org>
10064
10065 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10066 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10067 and add some more files.
32078c8d 10068
7285dc67
EZ
100692011-05-20 Eli Zaretskii <eliz@gnu.org>
10070
10071 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10072 report_file_error introduced by the change from 2011-05-07.
10073
89d1bd22
PE
100742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10075
10076 * systime.h (Time): Define only if emacs is defined.
10077 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10078 where the include path doesn't have X11/X.h by default. See
10079 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10080
cd394be1 100812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10082
10083 * composite.c (find_automatic_composition): Fix previous change.
10084
b9704ad9
GM
100852011-05-20 Glenn Morris <rgm@gnu.org>
10086
10087 * lisp.mk: New file, split from Makefile.in.
10088 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10089 (shortlisp): Remove.
10090 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10091
4a720484
GM
100922011-05-19 Glenn Morris <rgm@gnu.org>
10093
10094 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10095 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10096 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10097 (lisp): Set the order to that of loadup.el.
10098 (shortlisp): Make it a copy of $lisp.
10099 (SOME_MACHINE_LISP): Remove.
10100 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10101 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10102
a28d4396
KH
101032011-05-18 Kenichi Handa <handa@m17n.org>
10104
10105 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10106 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10107 (find_automatic_composition): Mostly rewrite for efficiency.
10108
a2b1fa8e
JB
101092011-05-18 Juanma Barranquero <lekktu@gmail.com>
10110
10111 * makefile.w32-in: Update dependencies.
10112
8e1f5610
CS
101132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10114
10115 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10116 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10117
7025ee00 101182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10119
cdfa6eab
PE
10120 Fix some integer overflow issues, such as string length overflow.
10121
06d6db33
PE
10122 * insdel.c (count_size_as_multibyte): Check for string overflow.
10123
2b4560a8
PE
10124 * character.c (lisp_string_width): Check for string overflow.
10125 Use EMACS_INT, not int, for string indexes and lengths; in
10126 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10127 the resulting string length overflows an EMACS_INT; instead,
10128 report a string overflow if no precision given. When checking for
10129 precision exhaustion, use a check that cannot possibly have
10130 integer overflow. (Bug#8675)
10131 * character.h (lisp_string_width): Adjust to new signature.
10132
cb93f9be
PE
10133 * alloc.c (string_overflow): New function.
10134 (Fmake_string): Use it. This doesn't change behavior, but saves
10135 a few bytes and will simplify future changes.
10136 * character.c (string_escape_byte8): Likewise.
10137 * lisp.h (string_overflow): New decl.
10138
1a1f3366
PE
10139 Fixups, following up to the user-interface timestamp change.
10140 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10141 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10142 * msdos.c (mouse_get_pos): Likewise.
10143 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10144 * w32gui.h (Time): Define by including "systime.h" rather than by
10145 declaring it ourselves. (Bug#8664)
10146
d4e3e4d3
PE
10147 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10148 * image.c (clear_image_cache): Likewise.
10149
f6a24d19
PE
10150 * term.c (term_mouse_position): Don't assume time_t wraparound.
10151
08dc5ae6
PE
10152 Be more systematic about user-interface timestamps.
10153 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10154 and sometimes 'EMACS_UINT', to represent these timestamps.
10155 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10156 This makes the code easier to follow, and makes it easier to catch
10157 integer overflow bugs such as Bug#8664.
10158 * frame.c (Fmouse_position, Fmouse_pixel_position):
10159 Use Time, not unsigned long, for user-interface timestamps.
10160 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10161 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10162 * keyboard.h (last_event_timestamp): Likewise.
10163 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10164 * menu.h (xmenu_show): Likewise.
10165 * term.c (term_mouse_position): Likewise.
10166 * termhooks.h (struct input_event.timestamp): Likewise.
10167 (struct terminal.mouse_position_hook): Likewise.
10168 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10169 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10170 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10171 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10172 what it was before.
10173 * menu.h, termhooks.h: Include "systime.h", for Time.
10174
8e55734a
PE
10175 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10176 Don't assume that the difference between two unsigned long values
10177 can fit into an integer. At this point, we know button_down_time
10178 <= event->timestamp, so the difference must be nonnegative, so
10179 there's no need to cast the result if double-click-time is
10180 nonnegative, as it should be; check that it's nonnegative, just in
10181 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10182 apart (about 25 days). (Bug#8664)
8e55734a 10183
841f1b75 10184 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10185 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10186
3e26f69c
PE
10187 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10188 that always fit in int. Use a sentinel instead of a counter, to
10189 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10190 * frame.h (struct frame): Use int for menu_bar_items_used
10191 instead of EMACS_INT, since it always fits in int.
3e26f69c 10192
5cc152c0
PE
10193 * menu.c (grow_menu_items): Check for int overflow.
10194
d89eb65e
PE
10195 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10196
5235bd3e
PE
10197 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10198 Before, the code was not consistent. These values cannot exceed
10199 2**31 - 1 so there's no need to make them unsigned.
10200 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10201 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10202 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10203 as modifiers.
10204 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10205
bc827e23
PE
10206 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10207 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10208 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10209 presumably because the widths might not match.
10210
78eb494e
PE
10211 * window.c (size_window): Avoid needless test at loop start.
10212
04f2d78b
CB
102132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10214
10215 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10216
d2fc7e3d 102172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10218
10219 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10220
d2fc7e3d 102212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10222
10223 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10224 `width' to `bar_area_x' and `bar_area_width', respectively.
10225 (x_scroll_run): Take account of fringe background extension.
10226
04f2d78b
CB
10227 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10228 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10229 `bar_area_width', respectively.
10230 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10231 background extension.
10232
79b70037
GM
102332011-05-10 Jim Meyering <meyering@redhat.com>
10234
10235 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10236
2f142cc5
JB
102372011-05-10 Juanma Barranquero <lekktu@gmail.com>
10238
10239 * image.c (Finit_image_library): Return t for built-in image types,
10240 like pbm and xbm. (Bug#8640)
10241
57679c86
AS
102422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10243
10244 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10245
888c9e86
EZ
102462011-05-07 Eli Zaretskii <eliz@gnu.org>
10247
b0512a1d
EZ
10248 * w32console.c (Fset_screen_color): Doc fix.
10249 (Fget_screen_color): New function.
10250 (syms_of_ntterm): Defsubr it.
10251
7285dc67
EZ
10252 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10253 unlink the temporary file if Fcall_process didn't create it in the
10254 first place.
10255 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10256 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10257 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10258 cue to call_process_cleanup not to close that handle.
10259
4d3fcc8e
BK
102602011-05-07 Ben Key <bkey76@gmail.com>
10261
10262 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10263 one of two shell specific rules, either bootstrap-temacs-CMD or
10264 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10265 to the previous implementation of the bootstrap-temacs rule.
10266 The bootstrap-temacs-CMD rule is similar to the previous
10267 implementation of the bootstrap-temacs rule except that it
10268 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10269 variable.
10270
10271 These changes, along with some changes to nt/configure.bat,
10272 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10273 earlier fix to add support for --cflags and --ldflags options
10274 that include quotes so that it works whether make uses cmd or
10275 sh as the shell.
10276
b4289b64
MA
102772011-05-06 Michael Albinus <michael.albinus@gmx.de>
10278
10279 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10280 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10281 is a constant.
10282 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10283 a string. Handle both cases.
10284 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10285 (Fdbus_register_method): Use Qinvalid_function.
10286
af4c0e28
JB
102872011-05-06 Juanma Barranquero <lekktu@gmail.com>
10288
10289 * makefile.w32-in: Update dependencies.
10290 (LISP_H): Add inttypes.h and stdin.h.
10291 (PROCESS_H): Add unistd.h.
10292
c51453d9
EZ
102932011-05-06 Eli Zaretskii <eliz@gnu.org>
10294
10295 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10296 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10297
8ff0ac3c 102982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10299
4c4b566b
PE
10300 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10301
aab2b9b5
PE
10302 * term.c (vfatal): Remove stray call to va_end.
10303 It's not needed and the C Standard doesn't allow it here anyway.
10304
c378da0b
PE
10305 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10306 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10307
288b08c7
PE
10308 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10309 bytes.
10310
e3601888
PE
10311 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10312
db6c0e74
PE
10313 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10314
dd5963ea
PE
10315 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10316
88c9450f
PE
10317 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10318
2f9442b8
PE
10319 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10320
c032b5f8
PE
10321 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10322 * charset.c (Fdefine_charset_internal): Don't initialize
10323 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10324 32-bit int (Bug#8600).
a108c10b
PE
10325
10326 * lread.c (read_integer): Be more consistent with string-to-number.
10327 Use string_to_number to do the actual conversion; this avoids
10328 rounding errors and fixes some other screwups. Without this fix,
10329 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10330 (digit_to_number): Move earlier, for benefit of read_integer.
10331 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10332 not a digit in any supported base. (Bug#8602)
a108c10b 10333
ad5f9eea
PE
10334 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10335
aec1708a
PE
10336 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10337 to match comment at start of function. This also removes a
10338 GCC warning about overflow in a 32+64-bit port.
10339
47be4ab5
PE
10340 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10341
371cac43
PE
10342 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10343 Reported by Stefan Monnier in
10344 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10345 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10346 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10347
d01a7826
PE
10348 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10349 (EMACS_UINTPTR): Likewise, with uintptr_t.
10350
7fd47d5c
PE
10351 * lisp.h: Prefer 64-bit EMACS_INT if available.
10352 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10353 on 32-bit hosts that have 64-bit int, so that they can access
10354 large files.
122b0c86
PE
10355 However, temporarily disable this change unless the temporary
10356 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10357
8727937b
PE
10358 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10359
8ac068ac
PE
10360 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10361 This removes an assumption that EMACS_INT and long are the same
10362 width as pointers. The assumption is true for Emacs porting targets
10363 now, but we want to make other targets possible.
10364 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10365 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10366 In the rest of the code, change types of integers that hold casted
10367 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10368 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10369 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10370 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10371 No need to cast type when ORing.
10372 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10373 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10374 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10375 assume EMACS_INT is the same width as char *.
10376 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10377 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10378 Remove no-longer-needed casts.
10379 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10380 (xg_tool_bar_help_callback, xg_make_tool_item):
10381 Use EMACS_INTPTR to hold an integer
10382 that will be cast to void *; this can avoid a GCC warning
10383 if EMACS_INT is not the same width as void *.
10384 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10385 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10386 (current_message_1, set_message_1):
10387 Use a local to convert to proper width without a cast.
10388 * xmenu.c (dialog_selection_callback): Likewise.
10389
ede49d71
PE
10390 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10391 Also, don't assume VALBITS / RAND_BITS is less than 5,
10392 and don't rely on undefined behavior when shifting a 1 left into
10393 the sign bit.
10394 * lisp.h (get_random): Change signature to match.
10395
2f30ecd0
PE
10396 * lread.c (hash_string): Use size_t, not int, for hash computation.
10397 Normally we prefer signed values; but hashing is special, because
10398 it's better to use unsigned division on hash table sizes so that
10399 the remainder is nonnegative. Also, size_t is the natural width
10400 for hashing into memory. The previous code used 'int', which doesn't
10401 retain enough info to hash well into very large tables.
10402 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10403
2a866e7b
PE
10404 * dbusbind.c: Don't possibly lose pointer info when converting.
10405 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10406 Use XPNTR rather than XHASH, so that the high-order bits of
10407 the pointer aren't lost when converting through void *.
10408
51639eac
PE
10409 * eval.c (Fautoload): Don't double-shift a pointer.
10410
92394119
PE
10411 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10412
dbdb9a7c
JB
104132011-05-06 Juanma Barranquero <lekktu@gmail.com>
10414
10415 * gnutls.c (DEF_GNUTLS_FN):
10416 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10417
db7a0b4f
AS
104182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10419
10420 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10421 marker. (Bug#8610)
10422
cd394be1 104232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10424
10425 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10426 New version that can reserve upto 2GB of heap space.
10427
f7ff1b0f 104282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10429
10430 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10431
639c109b
TZ
104322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10433
10434 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10435 `gnutls_certificate_set_x509_key_file'.
10436
d2127135
JB
104372011-05-05 Juanma Barranquero <lekktu@gmail.com>
10438
10439 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10440 Update dependencies.
10441
e968f4f3
JB
104422011-05-04 Juanma Barranquero <lekktu@gmail.com>
10443
10444 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10445 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10446 Remove unused parameter `fildes'.
10447 * process.c (read_process_output, send_process): Don't pass it.
10448
84d358f0
JB
104492011-05-04 Juanma Barranquero <lekktu@gmail.com>
10450
10451 Fix previous change: the library cache is defined in w32.c.
10452 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10453 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10454
0898ca10
JB
104552011-05-04 Juanma Barranquero <lekktu@gmail.com>
10456
10457 Implement dynamic loading of GnuTLS on Windows.
10458
10459 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10460 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10461 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10462 Declare.
10463
10464 * gnutls.c (Qgnutls_dll): Define.
10465 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10466 (gnutls_*): Declare function pointers.
10467 (init_gnutls_functions): New function to initialize function pointers.
10468 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10469 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10470 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10471 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10472 (emacs_gnutls_write, emacs_gnutls_read)
10473 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10474 (Fgnutls_available_p): New function.
10475 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10476 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10477 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10478
10479 * image.c: Include w32.h.
10480 (Vimage_type_cache): Delete.
10481 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10482 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10483 (w32_delayed_load): Move to w32.c.
10484
10485 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10486
10487 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10488 (w32_delayed_load): Move from image.c. When loading a library, record
10489 its filename in the :loaded-from property of the library id.
10490 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10491 Initialize and staticpro them.
10492 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10493
10494 * process.c: Include lisp.h before w32.h, not after.
10495 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10496 instead of gnutls_record_check_pending.
10497
10498 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10499
ff4de4aa
TZ
105002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10501
10502 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10503 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10504 as passed in.
10505
abe95abb
JD
105062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10507
10508 * xterm.c (x_set_frame_alpha): Do not set property on anything
10509 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10510
e16e55d4
JB
105112011-05-02 Juanma Barranquero <lekktu@gmail.com>
10512
10513 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10514
bafcf6a5
JB
105152011-05-02 Juanma Barranquero <lekktu@gmail.com>
10516
10517 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10518 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10519 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10520 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10521 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10522 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10523 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10524 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10525 (Qgnutls_bootprop_callbacks_verify): Make static.
10526
e7a6747f
AS
105272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10528
19ed11ba
AS
10529 * callproc.c: Indentation fixup.
10530
e7a6747f 10531 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10532 (wait_for_termination, interruptible_wait_for_termination):
10533 Move after wait_for_termination_1.
e7a6747f 10534
1ef14cb4
LMI
105352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10536
10537 * sysdep.c (interruptible_wait_for_termination): New function
10538 which is like wait_for_termination, but allows keyboard
10539 interruptions.
10540
10541 * callproc.c (Fcall_process): Add (:file "file") as an option for
10542 the STDOUT buffer.
10543 (Fcall_process_region): Ditto.
10544
330d880c
EZ
105452011-04-30 Eli Zaretskii <eliz@gnu.org>
10546
8db90b73
EZ
10547 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10548 rather than `XVECTOR (FOO)->size'.
10549
330d880c
EZ
10550 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10551 inttypes.h, as a gnulib replacement is used if it not available in
10552 system headers.
10553
15cbd324
EZ
105542011-04-21 Eli Zaretskii <eliz@gnu.org>
10555
10556 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10557 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10558 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10559
10560 * coding.c (coding_alloc_by_realloc): Error out if destination
10561 will grow beyond MOST_POSITIVE_FIXNUM.
10562 (decode_coding_emacs_mule): Abort if there isn't enough place in
10563 charbuf for the composition carryover bytes. Reserve an extra
10564 space for up to 2 characters produced in a loop.
10565 (decode_coding_iso_2022): Abort if there isn't enough place in
10566 charbuf for the composition carryover bytes.
10567
105682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10569
ae940cca
EZ
10570 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10571 aborting when %lld or %lll format is passed.
10572 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10573 %llo or %llx format is passed. (Bug#8545)
10574
03ab8921
EZ
10575 * window.c (window_scroll_line_based): Use a marker instead of
10576 simple variables to record original value of point. (Bug#7952)
10577
afda1437
EZ
10578 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10579 produced by %s or %c overflows available buffer space. (Bug#8545)
10580
f76dee0c
PE
105812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10582
10583 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10584 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10585
fdc5744d
JB
105862011-04-28 Juanma Barranquero <lekktu@gmail.com>
10587
10588 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10589
638f053a
JB
105902011-04-28 Juanma Barranquero <lekktu@gmail.com>
10591
10592 * keyboard.c (Qdelayed_warnings_hook): Define.
10593 (command_loop_1): Run `delayed-warnings-hook'
10594 if Vdelayed_warnings_list is non-nil.
10595 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10596 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10597
d178f871
EZ
105982011-04-28 Eli Zaretskii <eliz@gnu.org>
10599
10600 * doprnt.c (doprnt): Don't return value smaller than the buffer
10601 size if the message was truncated. (Bug#8545).
10602
b124fd93
JB
106032011-04-28 Juanma Barranquero <lekktu@gmail.com>
10604
10605 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10606 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10607
e810457d
PE
106082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10609
10610 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10611
ea51cceb
JB
106122011-04-27 Juanma Barranquero <lekktu@gmail.com>
10613
10614 * makefile.w32-in: Update dependencies.
10615
94dcfacf
EZ
106162011-04-27 Eli Zaretskii <eliz@gnu.org>
10617
10618 Improve `doprnt' and its usage. (Bug#8545)
10619 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10620 `format_end'. Remove support for %l as a conversion specifier.
10621 Don't use xrealloc. Improve diagnostics when the %l size modifier
10622 is used. Update the commentary.
10623
10624 * eval.c (verror): Simplify calculation of size_t.
10625
10626 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10627 messages.
10628
f61f41d7
PE
106292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10630
10631 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10632 change.
10633
96fb4434
PE
106342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10635
10636 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10637 This makes this file independent of the recent pseudovector change.
10638
671875da 106392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10640
69e9b5a3
PE
10641 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10642
b5f869a7 10643 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10644 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10645 Remove unused local.
c8926152 10646 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10647
841a1577 10648 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10649 GCC 4.6.0 optimizes based on type-based alias analysis.
10650 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10651 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10652 != &v->size, and therefore "v->size = 1; b->size = 2; return
10653 v->size;" must therefore return 1. This assumption is incorrect
10654 for Emacs, since it type-puns struct Lisp_Vector * with many other
10655 types. To fix this problem, this patch adds a new type struct
f904488f 10656 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10657 and pseudovectors, and helps optimizing compilers not get fooled
10658 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10659 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10660 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10661 the size member.
eab3844f
PE
10662 (XSETPVECTYPE): Rewrite in terms of new macro.
10663 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10664 This is a bit clearer, and further avoids the possibility of
10665 undesirable aliasing.
10666 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10667 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10668 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10669 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10670 (ASIZE): Now uses header.size rather than size.
10671 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10672 to avoid the hassle of writing XVECTOR (foo)->header.size.
10673 (struct vectorlike_header): New type.
eab3844f
PE
10674 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10675 object, to help avoid aliasing.
10676 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10677 (SUBRP): Likewise, since Lisp_Subr is a special case.
10678 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10679 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10680 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10681 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10682 changed to be "header.size" and "header.next".
10683 * buffer.h (struct buffer): Likewise.
10684 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10685 * frame.h (struct frame): Likewise.
10686 * process.h (struct Lisp_Process): Likewise.
10687 * termhooks.h (struct terminal): Likewise.
10688 * window.c (struct save_window_data, struct saved_window): Likewise.
10689 * window.h (struct window): Likewise.
10690 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10691 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10692 * buffer.c (init_buffer_once): Likewise.
10693 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10694 special case.
10695 * process.c (Fformat_network_address): Use local var for size,
10696 for brevity.
10697
0df1eac5
PE
10698 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10699
847ab9d1 10700 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10701 * data.c (atof): Remove decl; no longer used or needed.
10702 (digit_to_number): Move to lread.c.
10703 (Fstring_to_number): Use new string_to_number function, to be
10704 consistent with how the Lisp reader treats infinities and NaNs.
10705 Do not assume that floating-point numbers represent EMACS_INT
10706 without losing information; this is not true on most 64-bit hosts.
10707 Avoid double-rounding errors, by insisting on integers when
10708 parsing non-base-10 numbers, as the documentation specifies.
10709 * lisp.h (string_to_number): New decl, replacing ...
10710 (isfloat_string): Remove.
bc0a5c13 10711 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10712 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10713 appears to have been a coding error. Similarly, do not accept
10714 strings like +-1e0 as floating point numbers. Do not report
10715 overflow for integer overflows unless the base is not 10 which
10716 means we have no simple and reliable way to continue.
10717 Break out the floating-point parsing into a new
10718 function string_to_number, so that Fstring_to_number parses
10719 floating point numbers consistently with the Lisp reader.
04f2d78b 10720 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10721 (E_CHAR, EXP_INT): Remove, replacing with ...
10722 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10723 (string_to_number): New function, replacing isfloat_string.
10724 This function checks for valid syntax and produces the resulting
10725 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10726 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10727 so that overflow for non-base-10 numbers is reported only when
10728 there's no portable and simple way to convert to floating point.
452f4150 10729
67769ffc
PE
10730 * textprop.c (set_text_properties_1): Rewrite for clarity,
10731 and to avoid GCC warning about integer overflow.
10732
c20db43f
PE
10733 * intervals.h (struct interval): Use EMACS_INT for members
10734 where EMACS_UINT might cause problems. See
10735 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10736 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10737 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10738 All uses changed.
37aa2f85
PE
10739 (offset_intervals): Tell GCC not to worry about length overflow
10740 when negating a negative length.
c20db43f 10741
2538aa2f
PE
10742 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10743 (overrun_check_free): Likewise.
10744
f2d3008d
PE
10745 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10746 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10747 word size.
10748
ec8df744
PE
10749 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10750 (gnutls_make_error): Rename local to avoid shadowing.
10751 (gnutls_emacs_global_deinit): ifdef out; not used.
10752 (Fgnutls_boot): Use const for pointer to readonly storage.
10753 Comment out unused local. Fix pointer signedness problems.
10754
640ee02d
PE
10755 * lread.c (openp): Don't stuff size_t into an 'int'.
10756 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10757 about possible signed overflow.
10758
6048fb2a
PE
10759 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10760 (GDK_KEY_g): Don't define if already defined.
10761 (xg_prepare_tooltip): Avoid pointer signedness problem.
10762 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10763
fa3c87e1
PE
10764 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10765 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10766
2172544b
PE
10767 * xfns.c (Fx_window_property): Simplify a bit,
10768 to make a bit faster and to avoid GCC 4.6.0 warning.
10769 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10770
9b821a21
PE
10771 * fns.c (internal_equal): Don't assume size_t fits in int.
10772
3c616cfa
PE
10773 * alloc.c (compact_small_strings): Tighten assertion a little.
10774
c2982e87
PE
10775 Replace pEd with more-general pI, and fix some printf arg casts.
10776 * lisp.h (pI): New macro, generalizing old pEd macro to other
10777 conversion specifiers. For example, use "...%"pI"d..." rather
10778 than "...%"pEd"...".
10779 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10780 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10781 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10782 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10783 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10784 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10785 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10786 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10787 64-bit hosts.
10788 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10789 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10790 * print.c (safe_debug_print, print_object): Likewise.
10791 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10792 to int.
6f04d126
PE
10793 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10794 avoiding the 0 flag, which is not portable.
c2982e87
PE
10795 * process.c (Fmake_network_process): Use pI to avoid cast.
10796 * region-cache.c (pp_cache): Likewise.
10797 * xdisp.c (decode_mode_spec): Likewise.
10798 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10799 behavior on 64-bit hosts with printf arg.
6f04d126 10800 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10801 (x_stop_queuing_selection_requests): Likewise.
10802 (x_get_window_property): Don't truncate byte count to an 'int'
10803 when tracing.
0b432f21 10804
5e073ec7
PE
10805 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10806 here, since it parses constructs like leading '-' and spaces,
10807 which are not wanted; and it overflows with large numbers.
10808 Instead, simply match F[0-9]+, which is what is wanted anyway.
10809
36372bf9
PE
10810 * alloc.c: Remove unportable assumptions about struct layout.
10811 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10812 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10813 (allocate_vectorlike, make_pure_vector): Use the new macros,
10814 plus offsetof, to remove unportable assumptions about struct layout.
10815 These assumptions hold on all porting targets that I know of, but
10816 they are not guaranteed, they're easy to remove, and removing them
10817 makes further changes easier.
10818
0b432f21
PE
10819 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10820 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10821 (string_overrun_cookie): Now const. Use initializers that
10822 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10823 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10824 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10825 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10826 multiple of sizeof (EMACS_INT); it need not be, if
10827 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10828 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10829
895009e1
JB
108302011-04-26 Juanma Barranquero <lekktu@gmail.com>
10831
10832 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10833
6a7a1b0b
TZ
108342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10835
10836 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10837 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10838 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10839
841a1577 108402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10841
10842 * lisp.h (Qdebug): List symbol.
895009e1 10843 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10844 * keyboard.c (debug-on-event): New variable.
10845 (handle_user_signal): Break into debugger when debug-on-event
10846 matches the current signal symbol.
10847
f2d3ba6f
DN
108482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10849
10850 * alloc.c (check_sblock, check_string_bytes)
10851 (check_string_free_list): Convert to standard C.
10852
42ce4c63
TZ
108532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10854
10855 * w32.c (emacs_gnutls_push): Fix typo.
10856
825cd63c
EZ
108572011-04-25 Eli Zaretskii <eliz@gnu.org>
10858
fb11d64d
EZ
10859 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10860 "cast to pointer from integer of different size".
10861
825cd63c
EZ
10862 Improve doprnt and its use in verror. (Bug#8545)
10863 * doprnt.c (doprnt): Document the set of format control sequences
10864 supported by the function. Use SAFE_ALLOCA instead of always
10865 using `alloca'.
10866
10867 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10868 is one byte too soon. Don't use xrealloc; instead xfree and
10869 xmalloc anew.
10870
e061a11b
TZ
108712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10872
10873 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10874 callbacks stage.
10875
10876 * gnutls.c: Renamed global_initialized to
10877 gnutls_global_initialized. Added internals for the
10878 :verify-hostname-error, :verify-error, and :verify-flags
10879 parameters of `gnutls-boot' and documented those parameters in the
10880 docstring. Start callback support.
9173deec
JB
10881 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10882 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10883 on error. Return error code.
e061a11b
TZ
10884 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10885 (emacs_gnutls_read): Likewise.
10886 (Fgnutls_boot): Return handshake error code.
10887 (emacs_gnutls_handle_error): New function.
10888 (wsaerror_to_errno): Likewise.
10889
10890 * w32.h (emacs_gnutls_pull): Add prototype.
10891 (emacs_gnutls_push): Likewise.
10892
10893 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10894 (emacs_gnutls_push): Likewise.
10895
108962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10897
10898 * process.c (wait_reading_process_output): Check if GnuTLS
10899 buffered some data internally if no FDs are set for TLS
10900 connections.
10901
10902 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10903 (LIBS): Link to USER_LIBS.
10904 ($(BLD)/gnutls.$(0)): New target.
10905
fa6996bc
EZ
109062011-04-24 Eli Zaretskii <eliz@gnu.org>
10907
eb35682e
EZ
10908 * xdisp.c (handle_single_display_spec): Rename the
10909 display_replaced_before_p argument into display_replaced_p, to
10910 make it consistent with the commentary. Fix typos in the
10911 commentary.
10912
e2ad650c
EZ
10913 * textprop.c (syms_of_textprop): Remove dead code.
10914 (copy_text_properties): Delete obsolete commentary about an
10915 interface that was deleted long ago. Fix typos in the description
10916 of arguments.
10917
1b2de274
EZ
10918 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10919 to changes in oldXMenu/XMenu.h from 2011-04-16.
10920 <menu_help_message, prev_menu_help_message>: Constify.
10921 (IT_menu_make_room): menu->help_text is now `const char **';
10922 adjust.
10923
10924 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10925 to changes in oldXMenu/XMenu.h from 2011-04-16.
10926 (struct XMenu): Declare `help_text' `const char **'.
10927
10928 * xfaces.c <Qunspecified>: Make extern again.
10929
10930 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10931 required by POSIX.
1b2de274 10932
762b15be
EZ
10933 * doc.c (get_doc_string): Improve the format passed to `error'.
10934
10935 * doprnt.c (doprnt): Improve commentary.
10936
10937 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10938
10939 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10940 them with etags.
10941
f1052e5d
EZ
10942 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10943 changes in globals.h immediately force recompilation.
762b15be
EZ
10944 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10945 $(CURDIR)/s/ms-w32.h.
10946 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10947
fa6996bc
EZ
10948 * character.c (Fchar_direction): Function deleted.
10949 (syms_of_character): Don't defsubr it.
10950 <char-direction-table>: Deleted.
10951
e6c3da20
EZ
109522011-04-23 Eli Zaretskii <eliz@gnu.org>
10953
10954 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10955 * doprnt.c: Include limits.h.
10956 (SIZE_MAX): New macro.
04f2d78b
CB
10957 (doprnt): Return a size_t value. 2nd arg is now size_t.
10958 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10959 Improve overflow protection. Support `l' modifier for integer
10960 conversions. Support %l conversion. Don't assume an EMACS_INT
10961 argument for integer conversions and for %c.
10962
10963 * lisp.h (doprnt): Restore prototype.
10964
10965 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10966 $(SRC)/character.h.
10967
10968 * Makefile.in (base_obj): Add back doprnt.o.
10969
10970 * deps.mk (doprnt.o): Add back prerequisites.
10971 (callint.o): Depend on character.h.
10972
10973 * eval.c (internal_lisp_condition_case): Include the handler
10974 representation in the error message.
10975 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10976 when breaking from the loop.
10977
10978 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10979
10980 * callint.c (Fcall_interactively): When displaying error message
10981 about invalid control letter, pass the character's codepoint, not
10982 a pointer to its multibyte form. Improve display of the character
10983 in octal and display also its hex code.
10984
10985 * character.c (char_string): Use %x to display the (unsigned)
10986 codepoint of an invalid character, to avoid displaying a bogus
10987 negative value.
10988
10989 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10990 `error', not SYMBOL_NAME itself.
10991
10992 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10993 character arguments to `error'.
10994
10995 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10996 to `error' in error message about FINAL_CHAR argument. Make sure
10997 FINAL_CHAR is a character, and use %c when it is passed as
10998 argument to `error'.
10999
4ffd0d6b 110002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11001
11002 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11003
11004 * w32.c: Include <time.h>.
11005 (sys_localtime): New function.
11006
4ffd0d6b 110072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11008
11009 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11010
4ffd0d6b 11011 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11012
4ffd0d6b 110132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11014
4ffd0d6b
GM
11015 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11016 zombies (Bug#8467).
aac0c6e3 11017
04c56954
EZ
110182011-04-19 Eli Zaretskii <eliz@gnu.org>
11019
11020 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11021 gl_state.e_property when gl_state.object is Qt.
11022
11023 * insdel.c (make_gap_larger): Remove limitation of buffer size
11024 to <= INT_MAX.
11025
16a43933
CY
110262011-04-18 Chong Yidong <cyd@stupidchicken.com>
11027
11028 * xdisp.c (lookup_glyphless_char_display)
11029 (produce_glyphless_glyph): Handle cons cell entry in
11030 glyphless-char-display.
11031 (Vglyphless_char_display): Document it.
11032
11033 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11034 glyphless-char-display.
11035
4581706e
CY
110362011-04-17 Chong Yidong <cyd@stupidchicken.com>
11037
11038 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11039
11040 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11041
11042 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11043 definition for no-X builds.
11044
4887c6e2 110452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11046
fd35b6f9
PE
11047 Static checks with GCC 4.6.0 and non-default toolkits.
11048
5c1ccb01
PE
11049 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11050
006c5daa
PE
11051 * process.c (keyboard_bit_set): Define only if SIGIO.
11052 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11053 (send_process): Repair possible setjmp clobbering.
11054
efc736d3
PE
11055 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11056
4e2fe2e6
PE
11057 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11058
f97334a2
PE
11059 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11060
4e75f29d
PE
11061 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11062 Define only if needed.
11063
90efadd1
PE
11064 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11065 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11066 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11067
3c647824
PE
11068 * dispextern.h (struct redisplay_interface): Rename param
11069 to avoid shadowing.
e264f262 11070 * termhooks.h (struct terminal): Likewise.
761383f4 11071 * xterm.c (xembed_send_message): Likewise.
3c647824 11072
b58c5c4a
PE
11073 * insdel.c (make_gap_smaller): Define only if
11074 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11075
cad59032
PE
11076 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11077 it.
11078
c339dc2e
PE
11079 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11080 so that we aren't warned about unused symbols.
11081
91a3e27b
PE
11082 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11083
399c71d3 11084 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11085
8ffc96f5
PE
11086 * xfns.c (x_real_positions): Mark locals as initialized.
11087
eef9bc79
PE
11088 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11089
098db9dd
PE
11090 * xterm.c: Fix problems found by static analysis with other toolkits.
11091 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11092 (x_dispatch_event): Declare static if USE_GTK, and
11093 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11094 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11095 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11096 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11097 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11098
eb18f6cc
PE
11099 * xmenu.c (menu_help_callback): Pointer type fixes.
11100 Use const pointers when pointing at readonly data. Avoid pointer
11101 signedness clashes.
11102 (FALSE): Remove unused macro.
11103 (update_frame_menubar): Remove unused decl.
11104
1fe72bf8
PE
11105 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11106
60d9e1db
PE
11107 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11108 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11109 (single_menu_item): Rename local to avoid shadowing.
11110
39261c26
PE
11111 * keyboard.c (make_lispy_event): Remove unused local var.
11112
018c5e19
PE
11113 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11114 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11115
63d2b86e
PE
11116 * bitmaps: Change bitmaps from unsigned char back to the X11
11117 compatible char. Avoid the old compiler warnings about
11118 out-of-range initializers by using, for example, '\xab' rather
11119 than 0xab.
11120
aefd87e1
PE
11121 * xgselect.c (xgselect_initialize): Check vs interface
11122 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11123
bf501fb9
PE
11124 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11125
e9829fdf
PE
11126 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11127 to read-only memory.
11128
1086c095
PE
11129 * fns.c (vector): Remove; this old hack is no longer needed.
11130
2baccd04 11131 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11132 Remove unused var.
dde42981 11133 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11134
72391843 11135 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11136
436c16df 11137 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11138 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11139 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11140
92bb796d 11141 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11142 (x_term_init): Remove local to avoid shadowing.
92bb796d 11143
764430a3 11144 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11145
11146 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11147 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11148
d1dfb56c
EZ
111492011-04-16 Eli Zaretskii <eliz@gnu.org>
11150
c4354cb4
EZ
11151 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11152
d1dfb56c
EZ
11153 Fix regex.c, syntax.c and friends for buffers > 2GB.
11154 * syntax.h (struct gl_state_s): Declare character position members
11155 EMACS_INT.
11156
11157 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11158
04f2d78b
CB
11159 * textprop.c (verify_interval_modification, interval_of):
11160 Declare arguments EMACS_INT.
d1dfb56c
EZ
11161
11162 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11163 EMACS_INT.
11164
11165 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11166
11167 * indent.c (Fvertical_motion): Local variable it_start is now
11168 EMACS_INT.
11169
11170 * regex.c (re_match, re_match_2, re_match_2_internal)
11171 (bcmp_translate, regcomp, regexec, print_double_string)
11172 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11173 (re_compile_pattern, re_exec): Declare arguments and local
11174 variables `size_t' and `ssize_t' and return values `regoff_t', as
11175 appropriate.
11176 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11177 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11178 <compile_stack_type>: `size' and `avail' are now `size_t'.
11179
11180 * regex.h <regoff_t>: Use ssize_t, not int.
11181 (re_search, re_search_2, re_match, re_match_2): Arguments that
11182 specify buffer/string position and length are now ssize_t and
11183 size_t. Return type is regoff_t.
11184
613052cd
BK
111852011-04-16 Ben Key <bkey76@gmail.com>
11186
11187 * nsfont.m: Fixed bugs in ns_get_family and
11188 ns_descriptor_to_entity that were caused by using free to
11189 deallocate memory blocks that were allocated by xmalloc (via
11190 xstrdup). This caused Emacs to crash when compiled with
11191 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11192 --enable-checking=xmallocoverrun). xfree is now used to
11193 deallocate these memory blocks.
11194
4170f62f 111952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11196
71b41406
PE
11197 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11198
9587a89d
PE
11199 emacs_write: Accept and return EMACS_INT for sizes.
11200 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11201 et seq.
11202 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11203 Accept and return EMACS_INT.
11204 (emacs_gnutls_write): Return the number of bytes written on
11205 partial writes.
11206 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11207 (emacs_read, emacs_write): Remove check for negative size, as the
11208 Emacs source code has been audited now.
9587a89d
PE
11209 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11210 (emacs_read, emacs_write): Use it.
273a5f82
PE
11211 * process.c (send_process): Adjust to the new signatures of
11212 emacs_write and emacs_gnutls_write. Do not attempt to store
11213 a byte offset into an 'int'; it might overflow.
9587a89d 11214 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11215
3e047f51
PE
11216 * sound.c: Don't assume sizes fit in 'int'.
11217 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11218 Return EMACS_INT, not int.
3e047f51 11219 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11220 Accept EMACS_INT, not int.
11221 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11222 record read return values.
11223
cc39a9db
BK
112242011-04-15 Ben Key <bkey76@gmail.com>
11225
c9d0ec6d
JB
11226 * keyboard.c (Qundefined): Don't declare static since it is used
11227 in nsfns.m.
11228 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11229 static since they are used in nsfont.m.
cc39a9db 11230
6c60eb9f
SM
112312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11232
11233 * process.c (Qprocessp): Don't declare static.
11234 * lisp.h (Qprocessp): Declare again.
11235
7990b61a
JB
112362011-04-15 Juanma Barranquero <lekktu@gmail.com>
11237
11238 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11239
5d4cb038
PE
112402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11241
8bd7b830 11242 Improve C-level modularity by making more things 'static'.
cd64ea1d 11243
e3b27b31
PE
11244 Don't publish debugger-only interfaces to other modules.
11245 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11246 (verify_bytepos, count_markers): Move decls to the only modules
11247 that need them.
11248 * region-cache.h (pp_cache): Likewise.
11249 * window.h (check_all_windows): Likewise.
11250 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11251
5d4cb038
PE
11252 * sysdep.c (croak): Now static, if
11253 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11254 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11255
11256 * alloc.c (refill_memory_reserve): Now static if
11257 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11258 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11259
e87b6180
PE
11260 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11261 Define only if USE_LUCID.
11262
ac64929e
PE
11263 * xrdb.c (x_customization_string, x_rm_string): Now static.
11264
6f37259d
PE
11265 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11266 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11267
1683e3ab
PE
11268 * xdisp.c (draw_row_with_mouse_face): Now static.
11269 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11270
de9c2632
PE
11271 * window.h (check_all_windows): Mark externally visible.
11272
2b96acb7
PE
11273 * window.c (window_deletion_count): Now static.
11274
11275 * undo.c: Make symbols static if they're not exported.
11276 (last_undo_buffer, last_boundary_position, pending_boundary):
11277 Now static.
11278
50436f33
PE
11279 * textprop.c (interval_insert_behind_hooks): Now static.
11280 (interval_insert_in_front_hooks): Likewise.
11281
64520e5c
PE
11282 * term.c: Make symbols static if they're not exported.
11283 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11284 (max_frame_lines, tty_set_terminal_modes):
11285 (tty_reset_terminal_modes, tty_turn_off_highlight):
11286 (get_tty_terminal): Now static.
11287 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11288 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11289 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11290 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11291 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11292
1fa53021
PE
11293 * sysdep.c: Make symbols static if they're not exported.
11294 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11295 Now static.
11296 (sigprocmask_set, full_mask): Remove; unused.
11297 (wait_debugging): Mark as visible.
11298 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11299 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11300
d4b43b22
PE
11301 * syntax.c (syntax_temp): Define only if !__GNUC__.
11302
b7c513d0
PE
11303 * sound.c (current_sound_device, current_sound): Now static.
11304
989b29ad
PE
11305 * search.c (searchbufs, searchbuf_head): Now static.
11306
13a55a78
PE
11307 * scroll.c (scroll_cost): Remove; unused.
11308 * dispextern.h (scroll_cost): Remove decl.
11309
de68a1fc
PE
11310 * region-cache.h (pp_cache): Mark as externally visible.
11311
40ccffa6
PE
11312 * process.c: Make symbols static if they're not exported.
11313 (process_tick, update_tick, create_process, chan_process):
11314 (Vprocess_alist, proc_buffered_char, datagram_access):
11315 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11316 (deactivate_process): Mark defn as static, as well as decl.
11317 * lisp.h (create_process): Remove decl.
11318 * process.h (chan_process, Vprocess_alist): Remove decls.
11319
ad64fc97
PE
11320 * print.c: Make symbols static if they're not exported.
11321 (print_depth, new_backquote_output, being_printed, print_buffer):
11322 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11323 (print_interval, print_number_index, initial_stderr_stream):
11324 Now static.
11325 * lisp.h (Fprinc): Remove decl.
11326 (debug_output_compilation_hack): Mark as externally visible.
11327
adddb265
PE
11328 * sysdep.c (croak): Move decl from here to syssignal.h.
11329 * syssignal.h (croak): Put it here, so the API can be checked when
11330 'croak' is called from dissociate_if_controlling_tty.
11331
1717ede2
PE
11332 * minibuf.c: Make symbols static if they're not exported.
11333 (minibuf_save_list, choose_minibuf_frame): Now static.
11334 * lisp.h (choose_minibuf_frame): Remove decl.
11335
fa5fb2bc
PE
11336 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11337
1e3890d1
PE
11338 * lread.c: Make symbols static if they're not exported.
11339 (read_objects, initial_obarray, oblookup_last_bucket_number):
11340 Now static.
11341 (make_symbol): Remove; unused.
11342 * lisp.h (initial_obarray, make_symbol): Remove decls.
11343
8a1414fa
PE
11344 * keyboard.c: Make symbols static if they're not exported.
11345 (single_kboard, recent_keys_index, total_keys, recent_keys):
11346 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11347 (this_single_command_key_start, echoing, last_auto_save):
11348 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11349 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11350 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11351 (Vlispy_mouse_stem, double_click_count):
11352 Now static.
11353 (force_auto_save_soon): Define only if SIGDANGER.
11354 (ignore_mouse_drag_p): Now static if
11355 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11356 (print_help): Remove; unused.
11357 (stop_character, last_timer_event): Mark as externally visible.
11358 * keyboard.h (ignore_mouse_drag_p): Declare only if
11359 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11360 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11361 * lisp.h (echoing): Remove decl.
11362 (force_auto_save_soon): Declare only if SIGDANGER.
11363 * xdisp.c (redisplay_window): Simplify code, to make it more
11364 obvious that ignore_mouse_drag_p is not accessed if !defined
11365 USE_GTK && !defined HAVE_NS.
11366
93ea6e8f
PE
11367 * intervals.c: Make symbols static if they're not exported.
11368 (merge_properties_sticky, merge_interval_right, delete_interval):
11369 Now static.
11370 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11371
77382fcc
PE
11372 * insdel.c: Make symbols static if they're not exported.
11373 However, leave prepare_to_modify_buffer alone. It's never
11374 called from outside this function, but that appears to be a bug.
11375 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11376 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11377 (adjust_after_replace_noundo): Remove; unused.
11378 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11379 (signal_before_change): Remove decls.
77382fcc 11380
9306c32e
PE
11381 * indent.c (val_compute_motion, val_vmotion): Now static.
11382
cd44d2eb
PE
11383 * image.c: Make symbols static if they're not exported.
11384 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11385 if USE_GTK.
11386 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11387 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11388
ad9a7a06
PE
11389 * fringe.c (standard_bitmaps): Now static.
11390 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11391
81626931
PE
11392 * frame.c: Make symbols static if they're not exported.
11393 (x_report_frame_params, make_terminal_frame): Now static.
11394 (get_frame_param): Now static, unless HAVE_NS.
11395 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11396 (x_get_resource_string): Remove; not used.
11397 * frame.h (make_terminal_frame, x_report_frame_params):
11398 (x_get_resource_string); Remove decls.
11399 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11400 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11401
239f9db9
PE
11402 * font.c, fontset.c: Make symbols static if they're not exported.
11403 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11404 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11405 * font.c (font_close_object): Now static.
11406 * font.h (font_close_object): Remove.
11407 * fontset.c (FONTSET_OBJLIST): Remove.
11408 (free_realized_fontset) #if-0 the body, which does nothing.
11409 (face_suitable_for_char_p): #if-0, as it's never called.
11410 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11411 * xfaces.c (face_at_string_position):
11412 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11413 since 0 is always ASCII.
11414
dfcf3579
PE
11415 * fns.c (weak_hash_tables): Now static.
11416
5045092b
PE
11417 * fileio.c: Make symbols static if they're not exported.
11418 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11419 (Vwrite_region_annotation_buffers): Now static.
11420
57a96f5c
PE
11421 * eval.c: Make symbols static if they're not exported.
11422 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11423 * lisp.h (backtrace_list): Remove decl.
11424
35f08c38
PE
11425 * emacs.c: Make symbols static if they're not exported.
11426 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11427 (fatal_error_code, fatal_error_signal_hook, standard_args):
11428 Now static.
11429 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11430 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11431 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11432 * lisp.h (fatal_error_signal_hook): Remove decl.
11433 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11434
f44bd759
PE
11435 * editfns.c: Move a (normally-unused) function to its only use.
11436 * editfns.c, lisp.h (get_operating_system_release): Remove.
11437 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11438 worth the hassle of breaking this out.
11439
b532497d
PE
11440 * xterm.c: Make symbols static if they're not exported.
11441 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11442 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11443 (x_destroy_window, x_delete_display):
11444 Now static.
11445 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11446 (x_mouse_leave): Remove; unused.
11447 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11448 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11449 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11450 Remove decls.
11451 (x_mouse_leave): Declare only if WINDOWSNT.
11452 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11453 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11454 USE_X_TOOLKIT.
11455
1675728f
PE
11456 * ftxfont.c: Make symbols static if they're not exported.
11457 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11458 HAVE_FREETYPE.
11459 * font.h (ftxfont_driver): Likewise.
11460
e4cebfca
PE
11461 * xfns.c: Make symbols static if they're not exported.
11462 (x_last_font_name, x_display_info_for_name):
11463 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11464 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11465 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11466 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11467 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11468 (last_show_tip_args): Now static.
11469 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11470 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11471 (x_screen_planes): Remove; unused.
11472 * dispextern.h (x_screen_planes): Remove decl.
11473
5bf46f05
PE
11474 * dispnew.c: Make symbols static if they're not exported.
11475 * dispextern.h (redraw_garbaged_frames, scrolling):
11476 (increment_row_positions): Remove.
11477 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11478 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11479 Now static.
11480 (redraw_garbaged_frames): Remove; unused.
11481
435f4c28
PE
11482 * xfaces.c: Make symbols static if they're not exported.
11483 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11484 Remove decls.
11485 * xterm.h (defined_color): Remove decls.
11486 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11487 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11488 (menu_face_changed_default, defined_color, free_realized_face):
11489 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11490 (ascii_face_of_lisp_face): Remove; unused.
11491
8524aef3
PE
11492 * xdisp.c: Make symbols static if they're not exported.
11493 * dispextern.h (scratch_glyph_row, window_box_edges):
11494 (glyph_to_pixel_coords, set_cursor_from_row):
11495 (get_next_display_element, set_iterator_to_next):
11496 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11497 (show_mouse_face): Remove decls
11498 * frame.h (message_buf_print): Likewise.
11499 * lisp.h (pop_message, set_message, check_point_in_composition):
11500 Likewise.
11501 * xterm.h (set_vertical_scroll_bar): Likewise.
11502 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11503 (message_buf_print, scratch_glyph_row, displayed_buffer):
11504 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11505 (get_next_display_element, show_mouse_face, window_box_edges):
11506 (frame_to_window_pixel_xy, check_point_in_composition):
11507 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11508 (glyph_to_pixel_coords): Remove; unused.
11509
16390cd2
PE
11510 * dired.c (file_name_completion): Now static.
11511
11512 * dbusbind.c (xd_in_read_queued_messages): Now static.
11513
a25f4dfa
PE
11514 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11515 * data.c (circular_list_error): Remove.
11516
14a9c8df
PE
11517 * commands.h (last_point_position, last_point_position_buffer):
11518 (last_point_position_window): Remove decls.
11519 * keyboard.c: Make these variables static.
11520
04f2d78b
CB
11521 * coding.h (coding, code_convert_region, encode_coding_gap):
11522 Remove decls.
74ab6df5
PE
11523 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11524 (iso_code_class, detect_coding, code_convert_region): Now static.
11525 (encode_coding_gap): Remove; unused.
11526
38dfbee1
PE
11527 * chartab.c (chartab_chars, chartab_bits): Now static.
11528
a2cb4e63
PE
11529 * charset.h (charset_iso_8859_1): Remove decl.
11530 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11531 Now static.
11532
127198fd
PE
11533 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11534 * ccl.c (Vccl_program_table): Now static.
11535 (check_ccl_update): Remove; unused.
11536
d85b608f
PE
11537 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11538 * category.h: ... from here.
11539 * category.c (check_category_table, set_category_set): Now static.
11540
31cd66f3
PE
11541 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11542 * lisp.h: Remove these decls.
11543
c358e587
PE
11544 * buffer.c (buffer_count): Remove unused var.
11545
e78aecca
PE
11546 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11547 so that it's not optimized away.
11548 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11549 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11550 exported only to the debugger.
11551
e192d7d3 11552 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11553 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11554
92470028
PE
11555 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11556 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11557 was inaccessible from Lisp.
11558 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11559 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11560
244ed907
PE
11561 alloc.c: Import and export fewer symbols, and remove unused items.
11562 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11563 is defined.
11564 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11565 it's not optimized away by whole-program optimization.
11566 (message_enable_multibyte, free_misc): Remove.
11567 (catchlist, handlerlist, mark_backtrace):
11568 Declare only if BYTE_MARK_STACK.
11569 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11570 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11571 (message_enable_multibyte): Remove decl.
11572 (free_misc, interval_free_list, float_block, float_block_index):
11573 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11574 (cons_free_list, last_marked_index):
11575 Now static.
11576 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11577 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11578 (mark_backtrace): Define only if BYTE_MARK_STACK.
11579 * xdisp.c (message_enable_multibyte): Now static.
11580
61c2b50e 11581 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11582 This makes it easier for human readers (and static analyzers)
11583 to see whether these variables are used from other modules.
11584 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11585 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11586 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11587 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11588 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11589 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11590 * xmenu.c, xselect.c:
11591 Declare Q* vars static if they are not used in other modules.
11592 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11593 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11594 Remove decls of unexported vars.
11595 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11596
95c82688
PE
11597 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11598
16a97296
PE
11599 Make Emacs functions such as Fatom 'static' by default.
11600 This makes it easier for human readers (and static analyzers)
11601 to see whether these functions can be called from other modules.
11602 DEFUN now defines a static function. To make the function external
11603 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11604 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11605 (Finit_image_library):
16a97296
PE
11606 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11607 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11608 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11609 Remove decls, since these functions are now static.
11610 (Funintern, Fget_internal_run_time): New decls, since these functions
11611 were already external.
95c82688 11612
16a97296
PE
11613 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11614 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11615 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11616 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11617 * keyboard.c, keymap.c, lread.c:
11618 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11619 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11620 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11621 Mark functions with DEFUE instead of DEFUN,
11622 if they are used in other modules.
11623 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11624 decls for now-static functions.
11625 * buffer.h (Fdelete_overlay): Remove decl.
11626 * callproc.c (Fgetenv_internal): Mark as internal.
11627 * composite.c (Fremove_list_of_text_properties): Remove decl.
11628 (Fcomposition_get_gstring): New forward static decl.
11629 * composite.h (Fcomposite_get_gstring): Remove decl.
11630 * dired.c (Ffile_attributes): New forward static decl.
11631 * doc.c (Fdocumntation_property): New forward static decl.
11632 * eval.c (Ffetch_bytecode): New forward static decl.
11633 (Funintern): Remove extern decl; now in .h file where it belongs.
11634 * fileio.c (Fmake_symbolic_link): New forward static decl.
11635 * image.c (Finit_image_library): New forward static decl.
11636 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11637 * intervals.h (Fprevious_property_change):
11638 (Fremove_list_of_text_properties): Remove decls.
11639 * keyboard.c (Fthis_command_keys): Remove decl.
11640 (Fcommand_execute): New forward static decl.
11641 * keymap.c (Flookup_key): New forward static decl.
11642 (Fcopy_keymap): Now static.
11643 * keymap.h (Flookup_key): Remove decl.
11644 * process.c (Fget_process): New forward static decl.
11645 (Fprocess_datagram_address): Mark as internal.
11646 * syntax.c (Fsyntax_table_p): New forward static decl.
11647 (skip_chars): Remove duplicate decl.
11648 * textprop.c (Fprevious_property_change): New forward static decl.
11649 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11650 Now internal.
11651 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11652 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11653
785bbd42
PE
11654 * editfns.c (Fformat): Remove unreachable code.
11655
8b913b57
AS
116562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11657
11658 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11659 change. (Bug#8496)
11660
a6744a35
EZ
116612011-04-13 Eli Zaretskii <eliz@gnu.org>
11662
11663 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11664 when at ZV. (Bug#8487)
11665
e7974947
AS
116662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11667
baad03f0
AS
11668 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11669 (Bug#8437)
11670 * keyboard.c (parse_tool_bar_item): Likewise.
11671 * sound.c (sound_cleanup, alsa_close): Likewise.
11672 * termcap.c (tgetent): Likewise.
11673 * xfns.c (x_default_font_parameter): Likewise.
11674 * xsettings.c (read_and_apply_settings): Likewise.
11675
e7974947
AS
11676 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11677 (overrun_check_free): Protoize.
11678
28272684
PE
116792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11680
11681 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11682 since callers should never pass a negative size.
11683 Change the signature to match that of plain 'read' and 'write'; see
11684 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11685 * lisp.h: Update prototypes of emacs_write and emacs_read.
11686
11997c76
EZ
116872011-04-11 Eli Zaretskii <eliz@gnu.org>
11688
11689 * xdisp.c (redisplay_window): Don't try to determine the character
11690 position of the scroll margin if the window start point w->startp
e896f03c 11691 is outside the buffer's accessible region. (Bug#8468)
11997c76 11692
8a2cbd72
EZ
116932011-04-10 Eli Zaretskii <eliz@gnu.org>
11694
11695 Fix write-region and its subroutines for buffers > 2GB.
11696 * fileio.c (a_write, e_write): Modify declaration of arguments and
11697 local variables to support buffers larger than 2GB.
11698 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11699
11700 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11701 argument, local variables, and return value.
11702
11703 * lisp.h: Update prototypes of emacs_write and emacs_read.
11704
11705 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11706
4073e537 117072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11708
1ebfdcb6
PE
11709 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11710
b2ded58d
PE
11711 Fix more problems found by GCC 4.6.0's static checks.
11712
7d66342c
PE
11713 * xdisp.c (vmessage): Use a better test for character truncation.
11714
bbf47d44
PE
11715 * charset.c (load_charset_map): <, not <=, for optimization,
11716 and to avoid potential problems with integer overflow.
9248994d 11717 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11718 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11719 * editfns.c (Fformat): Likewise.
1e69125e 11720 * syntax.c (skip_chars): Likewise.
3befa583 11721
e3019616
PE
11722 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11723 This also lets GCC 4.6.0 generate slightly better loop code.
11724
becfa255
PE
11725 * callint.c (Fcall_interactively): <, not <=, for optimization.
11726 (Fcall_interactively): Count the number of arguments produced,
11727 not the number of arguments given. This is simpler and lets GCC
11728 4.6.0 generate slightly better code.
11729
dae0cd48
PE
11730 * ftfont.c: Distingish more carefully between FcChar8 and char.
11731 The previous code passed unsigned char * to a functions like
11732 strlen and xstrcasecmp that expect char *, which does not
11733 conform to the C standard.
11734 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11735 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11736 char * when the C standard requires it.
11737
76032d70
PE
11738 * keyboard.c (read_char): Remove unused var.
11739
eb3f1cc8
PE
11740 * eval.c: Port to Windows vsnprintf (Bug#8435).
11741 Include <limits.h>.
11742 (SIZE_MAX): Define if the headers do not.
11743 (verror): Do not give up if vsnprintf returns a negative count.
11744 Instead, grow the buffer. This ports to Windows vsnprintf, which
11745 does not conform to C99. Problem reported by Eli Zaretskii.
11746 Also, simplify the allocation scheme, by avoiding the need for
11747 calling realloc, and removing the ALLOCATED variable.
11748
70476b54
PE
11749 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11750
12020a9e
PE
11751 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11752 But keep the doprint source code for now, as we might revamp it
11753 and use it again (Bug#8435).
ea6c7ae6
PE
11754 * lisp.h (doprnt): Remove.
11755 * Makefile.in (base_obj): Remove doprnt.o.
11756 * deps.mk (doprnt.o): Remove.
11757
5fdb398c
PE
11758 error: Print 32- and 64-bit integers portably (Bug#8435).
11759 Without this change, on typical 64-bit hosts error ("...%d...", N)
11760 was used to print both 32- and 64-bit integers N, which relied on
11761 undefined behavior.
61bdb816 11762 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11763 * lisp.h (error, verror): Mark as printf-like functions.
11764 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11765 Report overflow in size calculations when allocating printf buffer.
11766 Do not truncate output string at its first null byte.
11767 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11768 Truncate the output at a character boundary, since vsnprintf does not
11769 do that.
11770 * charset.c (check_iso_charset_parameter): Convert internal
11771 character to string before calling 'error', since %c now has the
11772 printf meaning.
11773 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11774 overflow when computing char to be passed to 'error'. Do not
11775 pass Lisp_Object to 'error'; pass the integer instead.
11776 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11777 formatted with plain %d.
11778
b189fa66
PE
11779 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11780
bff87ef0
PE
11781 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11782
7e2cac20
PE
11783 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11784
ce4d90b5
PE
11785 * xterm.c (x_catch_errors): Remove duplicate declaration.
11786
266c9547
PE
11787 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11788
79c49ad2
PE
11789 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11790
368f4090
JM
117912011-04-10 Jim Meyering <meyering@redhat.com>
11792
11793 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11794 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11795 return ssize_t not "int", and use size_t as the buffer length.
11796 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11797 * gnutls.h: Update declarations.
11798 * process.c (read_process_output): Use ssize_t, to match.
11799 (send_process): Likewise.
11800
a32d4040
CY
118012011-04-09 Chong Yidong <cyd@stupidchicken.com>
11802
11803 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11804
8546720e 118052011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11806
04f2d78b
CB
11807 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11808 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11809
8546720e
GM
11810 * xterm.c (handle_one_xevent):
11811 * xmenu.c (create_and_show_popup_menu):
11812 * xselect.c (x_decline_selection_request)
11813 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11814
0a2f5c1a 118152011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11816
11817 Fix some uses of `int' instead of EMACS_INT.
11818 * search.c (string_match_1, fast_string_match)
11819 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11820 (scan_buffer, find_next_newline_no_quit)
11821 (find_before_next_newline, search_command, Freplace_match)
11822 (Fmatch_data): Make some `int' variables be EMACS_INT.
11823
11824 * xdisp.c (display_count_lines): 3rd argument and return value now
11825 EMACS_INT. All callers changed.
11826 (pint2hrstr): Last argument is now EMACS_INT.
11827
11828 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11829 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11830 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11831 (decode_coding_utf_16, decode_coding_emacs_mule)
11832 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11833 (decode_coding_ccl, decode_coding_charset)
11834 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11835 (decode_coding_iso_2022, decode_coding_emacs_mule)
11836 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11837 <char_offset, last_offset>: Declare EMACS_INT.
11838 (encode_coding_utf_8, encode_coding_utf_16)
11839 (encode_coding_emacs_mule, encode_invocation_designation)
11840 (encode_designation_at_bol, encode_coding_iso_2022)
11841 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11842 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11843 Declare EMACS_INT.
11844 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11845 (encode_invocation_designation): Last argument P_NCHARS is now
11846 EMACS_INT.
11847 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11848 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11849
11850 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11851 All users changed.
11852
11853 * ccl.c (Fccl_execute_on_string): Declare some variables
11854 EMACS_INT.
11855
8546720e 118562011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11857
11858 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11859
4e19a977
CS
118602011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11861
11862 * process.c (Fformat_network_address): Doc fix.
11863
87302331
R
118642011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11865
ee7683eb 11866 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11867
cbb59342
CY
118682011-04-08 Chong Yidong <cyd@stupidchicken.com>
11869
11870 * keyboard.c (read_char): Call Lisp function help-form-show,
11871 instead of using internal_with_output_to_temp_buffer.
11872 (Qhelp_form_show): New var.
e0d38eeb 11873 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11874
11875 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11876
11877 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11878
e67a13ab
CY
118792011-04-06 Chong Yidong <cyd@stupidchicken.com>
11880
04f2d78b
CB
11881 * process.c (Flist_processes): Remove to Lisp.
11882 (list_processes_1): Delete.
e67a13ab 11883
973f782d
EZ
118842011-04-06 Eli Zaretskii <eliz@gnu.org>
11885
7c106b1e
EZ
11886 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11887
973f782d
EZ
11888 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11889
41cf7d1a 118902011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11891
ca23cc88
PE
11892 Fix more problems found by GCC 4.6.0's static checks.
11893
f390e2d5
PE
11894 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11895
42eea0d0
PE
11896 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11897
b69769da 11898 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11899
f9541e84
PE
11900 * xdisp.c (vmessage): Mark as a printf-like function.
11901
13841b55
PE
11902 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11903
c136c10f
PE
11904 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11905
5e2d4a30
PE
11906 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11907 printf-like functions.
11908 (tiff_load): Add casts to remove these marks before passing them
11909 to system-supplied API.
11910
583f48b9
PE
11911 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11912
b25d760e
PE
11913 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11914 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11915 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11916 directly, rather than having caller test rule sign. This avoids
11917 some unnecessary tests.
11918 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11919 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11920 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11921
bc7b6697 11922 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11923 (xfont_open): Avoid unnecessary tests.
bc7b6697 11924
27ccc379
PE
11925 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11926
dcd5c89a
PE
11927 * composite.h, composite.c (composition_gstring_put_cache):
11928 Use EMACS_INT, not int, for length.
11929
b13a45c6
PE
11930 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11931 breaking out part of COMPOSITION_DECODE_RULE.
11932 (COMPOSITION_DECODE_RULE): Use it.
11933 * composite.c (get_composition_id): Remove unused local vars,
11934 by using the new macro.
11935
1e792e4d
PE
11936 * textprop.c (set_text_properties_1): Change while to do-while,
11937 since the condition is always true at first.
11938
dc6c6455 11939 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11940 (interval_deletion_adjustment): Return unsigned value.
11941 All uses changed.
dc6c6455 11942
aba7731a
PE
11943 * process.c (list_processes_1, create_pty, read_process_output):
11944 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11945 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11946 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11947 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11948 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11949
fdfc4bf3
PE
11950 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11951
fca8fe46 11952 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11953 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11954
06a0259a 11955 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11956 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11957 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11958
e7b9e80f
PE
11959 * print.c (print_error_message): Avoid int overflow.
11960
56201685
PE
11961 * font.c (font_list_entities): Redo for clarity,
11962 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11963
78834453 11964 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11965 (font_score): Avoid potential overflow in diff calculation.
78834453 11966
0bc0b309 11967 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11968 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11969
e610eaca
PE
11970 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11971
b895abce
PE
11972 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11973 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11974 can always succeed if overflow has undefined behavior.
11975
1f1d9321 11976 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11977 (wordify): Omit three unnecessary tests.
1f1d9321 11978
c59478bc
PE
11979 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11980 All callers changed. This avoids the need for an unused var.
11981
79b73827
PE
11982 * casefiddle.c (casify_region): Remove var that is set but not used.
11983
a4db5dfe
PE
11984 * dired.c (file_name_completion): Remove var that is set but not used.
11985
43aae36e
PE
11986 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11987
2a47c44d 11988 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11989 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11990
a37c69bf
PE
11991 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11992 Check for integer overflow on size calculations.
11993
328ab8e7
PE
11994 * buffer.c (Fprevious_overlay_change): Remove var that is set
11995 but not used.
11996
e5a2a5cb
PE
11997 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11998 Remove vars that are set but not used.
8d84a6eb 11999 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12000 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12001
a60e5f68
PE
12002 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12003
f661cb61 12004 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12005 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12006
f0397f5a
PE
12007 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12008 that are set but not used.
12009
8664db06 12010 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12011 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12012
6abdaa4a
PE
12013 * xselect.c (x_get_local_selection, x_handle_property_notify):
12014 Remove vars that are set but not used.
12015
0ce7538d 12016 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12017 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12018
9ae848fc
PE
12019 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12020 Remove var that is set but not used.
0b918413
PE
12021 (scroll_bar_windows_size): Now size_t, not int.
12022 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12023 Check for overflow.
9ae848fc 12024
a5a62657
PE
12025 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12026 (map_tty_color) [!defined MSDOS]: Likewise.
12027
5c5cdd39
PE
12028 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12029
66ebf983
PE
12030 * coding.c: Remove vars that are set but not used.
12031 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12032 All callers changed.
12033 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12034 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12035 (decode_coding_charset): Remove vars that are set but not used.
12036
1be4d761
PE
12037 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12038 that is set but not used.
12039
47553fa8
PE
12040 * print.c (print_object): Remove var that is set but not used.
12041
1f7196bf 12042 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12043 The gnulib version avoids calling malloc in the usual case,
12044 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12045 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12046 * filelock.c (current_lock_owner): Likewise.
12047 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12048 * sysdep.c: Include allocator.h, careadlinkat.h.
12049 (emacs_no_realloc_allocator): New static constant.
12050 (emacs_readlink): New function.
fdb61804
PE
12051 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12052 ../lib/careadlinkat.h.
d1fdcab7 12053
f84c17c7
SM
120542011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12055
12056 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12057 first non-nil return value).
12058
ef3862ad
JD
120592011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12060
12061 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12062 if not defined (Bug#8403).
12063
376a7006
JB
120642011-04-02 Juanma Barranquero <lekktu@gmail.com>
12065
12066 * xdisp.c (display_count_lines): Remove parameter `start',
12067 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12068 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12069 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12070 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12071 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12072 and thereabouts. All callers changed.
12073 (get_per_char_metric): Remove parameter `f', unused since
12074 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12075
6ca3801d
JM
120762011-04-02 Jim Meyering <meyering@redhat.com>
12077
12078 do not dereference NULL upon failed strdup
12079 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12080 (ns_get_family): Likewise.
12081
d8e2b5ba
JB
120822011-04-02 Juanma Barranquero <lekktu@gmail.com>
12083
12084 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12085
8c74fcbd
JD
120862011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12087
12088 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12089 later (Bug#8403).
12090
7200d79c
SM
120912011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12092
03408648 12093 Add lexical binding.
7200d79c 12094
03408648
SM
12095 * window.c (Ftemp_output_buffer_show): New fun.
12096 (Fsave_window_excursion):
12097 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12098
12099 * lread.c (lisp_file_lexically_bound_p): New function.
12100 (Fload): Bind Qlexical_binding.
12101 (readevalloop): Remove `evalfun' arg.
12102 Bind Qinternal_interpreter_environment.
12103 (Feval_buffer): Bind Qlexical_binding.
12104 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12105 Mark as dynamic.
12106 (syms_of_lread): Declare `lexical-binding'.
12107
12108 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12109
12110 * keyboard.c (eval_dyn): New fun.
12111 (menu_item_eval_property): Use it.
ca105506
SM
12112
12113 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12114
03408648
SM
12115 * fns.c (concat, mapcar1): Accept byte-code-functions.
12116
12117 * eval.c (Fsetq): Handle lexical vars.
12118 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12119 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12120 (FletX, Flet): Obey lexical binding.
12121 (Fcommandp): Handle closures.
12122 (Feval): New `lexical' arg.
12123 (eval_sub): New function extracted from Feval. Use it almost
12124 everywhere where Feval was used. Look up vars in lexical env.
12125 Handle closures.
12126 (Ffunctionp): Move from subr.el.
12127 (Ffuncall): Handle closures.
12128 (apply_lambda): Remove `eval_flags'.
12129 (funcall_lambda): Handle closures and new byte-code-functions.
12130 (Fspecial_variable_p): New function.
12131 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12132 but without exporting it to Lisp.
23aba0ea 12133
23aba0ea 12134 * doc.c (Fdocumentation, store_function_docstring):
03408648 12135 * data.c (Finteractive_form): Handle closures.
23aba0ea 12136
03408648
SM
12137 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12138 interactive spec.
ba83908c 12139
04f2d78b
CB
12140 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12141 New byte-codes.
03408648
SM
12142 (exec_byte_code): New function extracted from Fbyte_code to handle new
12143 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12144
03408648 12145 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12146
03408648 12147 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12148
e2abce01
JB
121492011-03-31 Juanma Barranquero <lekktu@gmail.com>
12150
12151 * xdisp.c (redisplay_internal): Fix prototype.
12152
63696a73 121532011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12154
63696a73 12155 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12156 (try_scrolling): Use it when setting scroll_limit.
12157 Limit scrolling to 100 screen lines.
63696a73
EZ
12158 (redisplay_window): Even when falling back on "recentering",
12159 position point in the window according to scroll-conservatively,
12160 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12161
12162 (try_scrolling): When point is above the window, allow searching
12163 as far as scroll_max, or one screenful, to compute vertical
12164 distance from PT to the scroll margin position. This prevents
12165 try_scrolling from unnecessarily failing when
12166 scroll-conservatively is set to a value slightly larger than the
12167 window height. Clean up the case of PT below the margin at bottom
12168 of window: scroll_max can no longer be INT_MAX. When aggressive
12169 scrolling is in use, don't let point enter the opposite scroll
12170 margin as result of the scroll.
12171 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12172 threshold of 100 lines for never-recentering scrolling.
12173
e4cc2dfc
JB
121742011-03-31 Juanma Barranquero <lekktu@gmail.com>
12175
12176 * dispextern.h (move_it_by_lines):
12177 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12178 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12179 (message_log_check_duplicate): Remove parameters `prev_bol' and
12180 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12181 (redisplay_internal): Remove parameter `preserve_echo_area',
12182 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12183
12184 * indent.c (Fvertical_motion):
12185 * window.c (window_scroll_pixel_based, Frecenter):
12186 Don't pass `need_y_p' to `move_it_by_lines'.
12187
1c470562
SM
121882011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12189
44f230aa
SM
12190 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12191 steal a few bits to be more compact.
12192 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12193 Remove unneeded casts.
12194
1c470562
SM
12195 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12196
888adce9
ZK
121972011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12198
12199 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12200 binding" message (bug#7967).
12201
f838ed7b
PE
122022011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12203
77861b95
PE
12204 Fix more problems found by GCC 4.6.0's static checks.
12205
de6dbc14
PE
12206 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12207 Remove unused local var.
12208
f838ed7b
PE
12209 * editfns.c (Fmessage_box): Remove unused local var.
12210
792c7b2b
PE
12211 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12212 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12213 Omit unused local vars.
c499e557 12214 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12215 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12216 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12217 Omit unused local var.
12218
ba0165e1
PE
12219 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12220 Don't assume string length fits in int.
32ad8845 12221 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12222 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12223
3c59b4c9
PE
12224 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12225 instead of alloca (Bug#8344).
12226
a3eed478 12227 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12228 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12229
eb4d412d
PE
12230 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12231
1658b401
PE
12232 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12233 concerns.
12234
12235 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12236
12237 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12238
9a2c6e05
PE
12239 * keyboard.c (syms_of_keyboard): Use the same style as later
12240 in this function when indexing through an array. This also
12241 works around GCC bug 48267.
12242
03d0a109
PE
12243 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12244
44f730c8
PE
12245 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12246
fe75f926
PE
12247 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12248 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12249
ffa8c828
PE
12250 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12251 This avoids undefined behavior on integer overflow, and is a bit
12252 more convenient anyway since it is compared to a size_t variable.
12253
c5101a77
PE
12254 Variadic C functions now count arguments with size_t, not int.
12255 This avoids an unnecessary limitation on 64-bit machines, which
12256 caused (substring ...) to crash on large vectors (Bug#8344).
12257 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12258 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12259 All variadic functions and their callers changed accordingly.
c5101a77
PE
12260 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12261 * data.c (arith_driver, float_arith_driver): Likewise.
12262 * editfns.c (general_insert_function): Likewise.
12263 * eval.c (struct backtrace.nargs, interactive_p)
12264 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12265 (funcall_lambda, mark_backtrace): Likewise.
12266 * fns.c (concat): Likewise.
12267 * frame.c (x_set_frame_parameters): Likewise.
12268 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12269 0 if not found, not -1. All callers changed.
12270
dd3f25f7
PE
12271 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12272 (stack_copy_size): Now size_t, not int.
12273 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12274
461c2ab9
JB
122752011-03-28 Juanma Barranquero <lekktu@gmail.com>
12276
12277 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12278 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12279 All callers changed.
12280
12281 * lisp.h (multibyte_char_to_unibyte):
12282 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12283 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12284 * character.h (CHAR_TO_BYTE8):
12285 * cmds.c (internal_self_insert):
12286 * editfns.c (general_insert_function):
12287 * keymap.c (push_key_description):
12288 * search.c (Freplace_match):
12289 * xdisp.c (message_dolog, set_message_1): All callers changed.
12290
f6d62986
SM
122912011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12292
12293 * keyboard.c (safe_run_hook_funcall): New function.
12294 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12295 don't set the hook to nil, but remove the offending function instead.
12296 (Qcommand_hook_internal): Remove, unused.
12297 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12298 Vcommand_hook_internal.
12299
12300 * eval.c (enum run_hooks_condition): Remove.
12301 (funcall_nil, funcall_not): New functions.
12302 (run_hook_with_args): Call each function through a `funcall' argument.
12303 Remove `cond' argument, now redundant.
12304 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12305 (Frun_hook_with_args_until_failure): Adjust accordingly.
12306 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12307
1db5b1ad
JB
123082011-03-28 Juanma Barranquero <lekktu@gmail.com>
12309
12310 * dispextern.h (string_buffer_position): Remove declaration.
12311
12312 * print.c (strout): Remove parameter `multibyte', unused since
12313 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12314
12315 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12316 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12317 All callers changed.
12318
12319 * w32.c (_wsa_errlist): Use braces for struct initializers.
12320
12321 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12322 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12323 All callers changed.
12324 (string_buffer_position): Likewise. Also, make static (it's never
12325 used outside xdisp.c).
12326 (cursor_row_p): Remove parameter `w', unused since
12327 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12328 (decode_mode_spec): Remove parameter `precision', introduced during
12329 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12330 All callers changed.
12331
5ffb62aa
JD
123322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12333
12334 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12335
461c2ab9 123362011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12337
12338 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12339 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12340 (ns_update_auto_hide_menu_bar): New functions.
12341 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12342 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12343 ns_constrain_all_frames.
12344 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12345 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12346
5c380ffb
JD
123472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12348
12349 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12350
9af30bdf
GM
123512011-03-27 Glenn Morris <rgm@gnu.org>
12352
12353 * syssignal.h: Replace RETSIGTYPE with void.
12354 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12355 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12356 Replace SIGTYPE with void everywhere.
12357 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12358 * s/template.h (SIGTYPE): Remove commented out definition.
12359
e2abce01
JB
123602011-03-26 Eli Zaretskii <eliz@gnu.org>
12361
12362 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12363 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12364
f868cd8a
JB
123652011-03-26 Juanma Barranquero <lekktu@gmail.com>
12366
59eb0929
JB
12367 * w32.c (read_unc_volume): Use parameter `henum', instead of
12368 global variable `wget_enum_handle'.
12369
12370 * keymap.c (describe_vector): Remove parameters `indices' and
12371 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12372 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12373
f868cd8a
JB
12374 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12375
12376 * keyboard.c (timer_check): Remove parameter `do_it_now',
12377 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12378 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12379 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12380
12381 * keyboard.c (read_char):
12382 * w32menu.c (w32_menu_display_help):
12383 * xmenu.c (show_help_event, menu_help_callback):
12384 Adjust calls to `show_help_echo'.
12385
12386 * gtkutil.c (xg_maybe_add_timer):
12387 * keyboard.c (readable_events):
12388 * process.c (wait_reading_process_output):
12389 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12390
12391 * insdel.c (adjust_markers_gap_motion):
12392 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12393 (gap_left, gap_right): Don't call it.
12394
2ecf6fdb
CY
123952011-03-25 Chong Yidong <cyd@stupidchicken.com>
12396
12397 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12398 incurred during fontification.
12399
6b1f9ba4
JB
124002011-03-25 Juanma Barranquero <lekktu@gmail.com>
12401
12402 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12403 (DEFVAR_PER_BUFFER): Don't pass it.
12404
12405 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12406 (scrolling_window): Don't pass it.
12407
0f4a96b5
JB
124082011-03-25 Juanma Barranquero <lekktu@gmail.com>
12409
12410 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12411
12412 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12413 and `suffix'.
12414 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12415 of variables specific to SELinux and computation of `encoded_absname'.
12416
12417 * image.c (XPutPixel): Remove unused variable `height'.
12418
12419 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12420
12421 * unexw32.c (get_section_info): Remove unused variable `section'.
12422
12423 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12424 (system_process_attributes): Remove unused variable `sess'.
12425 (sys_read): Remove unused variable `err'.
12426
12427 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12428 (w32_wnd_proc): Remove unused variable `isdead'.
12429 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12430 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12431 (x_create_tip_frame): Remove unused variable `tem'.
12432
12433 * w32inevt.c (w32_console_read_socket):
12434 Remove unused variable `no_events'.
12435
12436 * w32term.c (x_draw_composite_glyph_string_foreground):
12437 Remove unused variable `width'.
12438
1149507c
JB
124392011-03-24 Juanma Barranquero <lekktu@gmail.com>
12440
12441 * w32term.c (x_set_glyph_string_clipping):
12442 Don't pass uninitialized region to CombineRgn.
12443
9c88f339
JB
124442011-03-23 Juanma Barranquero <lekktu@gmail.com>
12445
12446 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12447 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12448 (Fx_close_connection): Remove unused variable `i'.
12449
12450 * w32font.c (w32font_draw): Return number of glyphs.
12451 (w32font_open_internal): Remove unused variable `i'.
12452 (w32font_driver): Add missing initializer.
12453
12454 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12455 (fill_in_menu): Remove unused variable `items_added'.
12456
12457 * w32term.c (last_mouse_press_frame): Remove static global variable.
12458 (w32_clip_to_row): Remove unused variable `f'.
12459 (x_delete_terminal): Remove unused variable `i'.
12460
12461 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12462 (NOTHING): Remove unused static global variable.
12463 (uniscribe_check_otf): Remove unused variable `table'.
12464 (uniscribe_font_driver): Add missing initializers.
12465
dee091a3
JD
124662011-03-23 Julien Danjou <julien@danjou.info>
12467
12468 * term.c (Fsuspend_tty, Fresume_tty):
12469 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12470 * window.c (temp_output_buffer_show):
12471 * insdel.c (signal_before_change):
12472 * frame.c (Fhandle_switch_frame):
12473 * fileio.c (Fdo_auto_save):
12474 * emacs.c (Fkill_emacs):
12475 * editfns.c (save_excursion_restore):
12476 * cmds.c (internal_self_insert):
12477 * callint.c (Fcall_interactively):
12478 * buffer.c (Fkill_all_local_variables):
12479 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12480 Use Frun_hooks.
0f4a96b5 12481 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12482 unconditionally since it does the check itself.
dee091a3 12483
2c520ab5 124842011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12485
c9c49752
PE
12486 Fix more problems found by GCC 4.5.2's static checks.
12487
8abc3f12
PE
12488 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12489 the first time through the loop, since we know p0 < p1 then.
12490 This also avoids a gcc -Wstrict-overflow warning.
12491
a2d26660
PE
12492 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12493 leading to a memory leak, possible in functions like
12494 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12495 of objects (Bug#8318).
a2d26660 12496
916c72e9
PE
12497 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12498 that could (at least in theory) be that large.
12499
19ab8a18
PE
12500 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12501 This is less likely to overflow, and avoids undefined behavior if
12502 overflow does occur. All callers changed. Use strtoul to scan
12503 for the unsigned long integer.
b7cbbd6f
PE
12504 (pint2hrstr): Simplify and tune code slightly.
12505 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12506
f0641eff
PE
12507 * scroll.c (do_scrolling): Work around GCC bug 48228.
12508 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12509
7f650bb9
PE
12510 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12511 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12512 (validate_x_resource_name): Simplify count usage.
12513 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12514
37dd57d1
PE
12515 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12516 fail (Bug#8306).
81e56e61 12517
699979fc 12518 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12519
401bf9b4
PE
12520 * process.c (Fmake_network_process): Use socklen_t, not int,
12521 where POSIX says socklen_t is required in portable programs.
12522 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12523 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12524 (Fmake_network_process, server_accept_connection):
12525 (wait_reading_process_output, read_process_output):
12526 Likewise.
12527
b93aacde
PE
12528 * process.c: Rename or move locals to avoid shadowing.
12529 (list_processes_1, Fmake_network_process):
12530 (read_process_output_error_handler, exec_sentinel_error_handler):
12531 Rename or move locals.
4dc343ee 12532 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12533 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12534 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12535 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12536 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12537
af8a867c 12538 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12539 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12540 Include tparam.h instead, since it declares them.
af8a867c
PE
12541 * cm.h (PC): Remove extern decl; tparam.h now does this.
12542 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12543 * terminfo.c: Include tparam.h, to check interfaces.
12544 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12545 (tparam): Adjust signature to match interface in tparam.h;
12546 this removes some undefined behavior. Check that outstring and len
12547 are zero, which they always are with Emacs.
12548 * tparam.h (PC, BC, UP): New extern decls.
12549
0248044d 12550 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12551 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12552
8ff096c1 12553 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12554 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12555 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12556 (ftfont_list): Remove unused local.
49eaafba
PE
12557 (get_adstyle_property, ftfont_pattern_entity):
12558 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12559 Rename locals to avoid shadowing.
8ff096c1 12560
e2be39f6
PE
12561 * xfont.c (xfont_list_family): Mark var as initialized.
12562
c9735e30
PE
12563 * xml.c (make_dom): Now static.
12564
8f5201ae
PE
12565 * composite.c (composition_compute_stop_pos): Rename local to
12566 avoid shadowing.
b246f932
PE
12567 (composition_reseat_it): Remove unused locals.
12568 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12569 (composition_update_it): Mark var as initialized.
11b61122
PE
12570 (find_automatic_composition): Mark vars as initialized,
12571 with a FIXME (Bug#8290).
8f5201ae 12572
760fbc2c
PE
12573 character.h: Rename locals to avoid shadowing.
12574 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12575 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12576 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12577 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12578 to avoid shadowing.
12579
ff08eb85
PE
12580 * textprop.c (property_change_between_p): Remove; unused.
12581
fc7bf025
PE
12582 * intervals.c (interval_start_pos): Now static.
12583
235d7abc
PE
12584 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12585
44f230aa
SM
12586 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12587 Rename locals to avoid shadowing.
3e7d6594 12588
50060332
PE
12589 * sound.c (wav_play, au_play, Fplay_sound_internal):
12590 Fix pointer signedness.
d01f234b 12591 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12592 (wav_play): Initialize a variable to 0, to prevent undefined
12593 behavior (Bug#8278).
50060332 12594
c4fc4e30
PE
12595 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12596
918436ed
PE
12597 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12598
c939f91b
PE
12599 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12600 clobbering (Bug#8298).
b9c7f648
PE
12601 * sysdep.c (sys_subshell): Likewise.
12602 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12603
6bd8c144
PE
12604 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12605 This should get cleaned up, so that child_setup has the
12606 same signature on all platforms.
12607
7710357c 12608 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12609 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12610
c59da222
CY
126112011-03-22 Chong Yidong <cyd@stupidchicken.com>
12612
12613 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12614 not to be necessary, and produces flickering.
12615
66b87493
GM
126162011-03-20 Glenn Morris <rgm@gnu.org>
12617
12618 * config.in: Remove file.
12619
45b6f6d5
JB
126202011-03-20 Juanma Barranquero <lekktu@gmail.com>
12621
12622 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12623 are now in src/globals.h.
12624 (syms_of_minibuf): Remove spurious & from previous change.
12625
cd394be1 126262011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12627
12628 * minibuf.c (completing-read-function): New variable.
12629 (completing-read-default): Rename from completing-read.
12630 (completing-read): Call completing-read-function.
12631
b14e3e21
CY
126322011-03-19 Juanma Barranquero <lekktu@gmail.com>
12633
12634 * xfaces.c (Fx_load_color_file):
12635 Read color file from absolute filename (bug#8250).
12636
f2b726e6
JB
126372011-03-19 Juanma Barranquero <lekktu@gmail.com>
12638
12639 * makefile.w32-in: Update dependencies.
12640
09f6ff02
EZ
126412011-03-17 Eli Zaretskii <eliz@gnu.org>
12642
12643 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12644
29a6015a
PE
126452011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12646
a3a6c54e
PE
12647 Fix more problems found by GCC 4.5.2's static checks.
12648
b766f867
PE
12649 * process.c (make_serial_process_unwind, send_process_trap):
12650 (sigchld_handler): Now static.
12651
be02381c
PE
12652 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12653 That way, the code declares only the vars that it needs.
12654 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12655 * s/cygwin.h (PTY_ITERATION): Likewise.
12656 * s/darwin.h (PTY_ITERATION): Likewise.
12657 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12658
57048744
PE
12659 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12660 * process.c (allocate_pty): Don't declare stb unless it's needed.
12661
7914961c 12662 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12663 (CONSTANTLIM): Remove; unused.
12664 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12665 Define only if needed.
7914961c 12666
b3967b18
PE
12667 * unexelf.c (unexec): Name an expression,
12668 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12669 Use a different way to cause a compilation error if anyone uses
12670 n rather than nn, a way that does not involve shadowing.
73366a00 12671 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12672
29a6015a
PE
12673 * deps.mk (unexalpha.o): Remove; unused.
12674
43cfc33e 12675 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12676 * unexec.h: New file.
ce701a33
PE
12677 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12678 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12679 Depend on unexec.h.
12680 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12681 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12682 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12683 Change as necessary to match prototype in unexec.h.
ce701a33 12684
01f44d5a
PE
12685 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12686 shadowing.
4f63c6bb 12687 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12688
a6670b0b
PE
12689 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12690 Rename locals to avoid shadowing.
12691
cef2010d 12692 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12693 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12694
d4d7173a
PE
12695 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12696
f08b802a
PE
12697 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12698 warning when compiling print.c.
12699
3ddb0639
PE
12700 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12701 instead of using an uninitialized var.
5ad03b97 12702 (font_sort_entities): Mark var as initialized.
3ddb0639 12703
170a2692
PE
12704 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12705
e663c700
PE
12706 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12707 pointers to constants.
89bc529a 12708 (font_parse_fcname): Remove unused vars.
7b81e2d0 12709 (font_delete_unmatched): Now static.
ea838e10 12710 (font_get_spec): Remove; unused.
13a547c6
PE
12711 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12712 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12713 Rename or move locals to avoid shadowing.
e663c700 12714
2a80c887 12715 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12716 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12717
1384fa33 12718 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12719 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12720
8b2c52e9
PE
12721 * alloc.c (mark_backtrace): Move decl from here ...
12722 * lisp.h: ... to here, so that it can be checked.
12723
475545b5 12724 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12725 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12726 (lisp_indirect_variable): Name an expression,
12727 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12728 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12729
b1349114 12730 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12731 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12732 Use const pointer when appropriate.
b1349114 12733
a2928364
PE
12734 * lisp.h (get_system_name, get_operating_system_release):
12735 Move decls here, to check interfaces.
12736 * process.c (get_operating_system_release): Move decl to lisp.h.
12737 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12738 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12739 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12740 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12741 (Fformat_time_string, Fencode_time, Finsert_char):
12742 (Ftranslate_region_internal, Fformat):
12743 Rename or remove local vars to avoid shadowing.
9710023e 12744 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12745
a415e694
PE
12746 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12747 avoid shadowing.
12748
8ef4622d
PE
12749 * lisp.h (eassert): Check that the argument compiles, even if
12750 ENABLE_CHECKING is not defined.
12751
946f9a5b
PE
12752 * data.c (Findirect_variable): Name an expression, to avoid
12753 gcc -Wbad-function-cast warning.
112396d6 12754 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12755 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12756 (Fmake_variable_buffer_local, Fmake_local_variable):
12757 Mark variables as initialized.
52746918 12758 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12759
e5aab7e7 12760 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12761 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12762 Rename locals to avoid shadowing.
dff45157
PE
12763 (mark_stack): Move local variables into the #ifdef region where
12764 they're used.
7bc26fdb
PE
12765 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12766 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12767 needed otherwise.
12768 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12769 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12770 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12771
e5aab7e7
PE
12772 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12773 avoids undefined behavior in theory.
12774
4da60324
PE
12775 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12776
88043301
PE
12777 Use functions, not macros, for up- and down-casing (Bug#8254).
12778 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12779 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12780 to use the following functions instead of these macros.
12781 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12782 EMACS_INT, since callers assume the returned value fits in int.
12783 (upcase1): Likewise, for UPCASE_TABLE.
12784 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12785 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12786 the race-condition problem in the old DOWNCASE.
88043301 12787
19ed5445
PE
12788 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12789 Rename locals to avoid shadowing.
12790 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12791 (regex_compile, re_search_2, re_match_2_internal):
12792 Remove unused local vars.
952db0d7
PE
12793 (FREE_VAR): Rewrite so as not to use empty "else",
12794 which gcc can warn about.
da053e48 12795 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12796 (RETALLOC_IF): Define only if needed.
12797 (WORDCHAR_P): Likewise. This one is never needed, but is used
12798 only in a comment talking about a compiler bug, so put inside
12799 the #if 0 of that comment.
12800 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12801 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12802 Remove; unused.
19ed5445 12803
1f3561e4 12804 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12805 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12806 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12807
ded6f8f7
PE
12808 * search.c (simple_search): Remove unused var.
12809
dbd37a95
PE
12810 * dired.c (compile_pattern): Move decl from here ...
12811 * lisp.h: ... to here, so that it can be checked.
12812 (struct re_registers): New forward decl.
12813
7e47afad
PE
12814 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12815
85f24f61
PE
12816 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12817 All uses changed.
12818 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12819 Rename locals to avoid shadowing.
5671df8f 12820 (Fvertical_motion): Mark locals as initialized.
85f24f61 12821
181aa2be 12822 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12823 (casify_region): Mark local as initialized.
181aa2be 12824
930d429c
PE
12825 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12826
7082eac6
PE
12827 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12828 New macros, so that the caller can use some names other than
12829 gcpro1, gcpro2, etc.
12830 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12831 of the new macros.
12832 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12833 argument, for consistency with GCPRO2_VAR, etc: it is now the
12834 prefix of the variable, not the variable itself. All uses
12835 changed.
38b2c076
PE
12836 * dired.c (directory_files_internal, file_name_completion):
12837 Rename locals to avoid shadowing.
12838
15206ed9
PE
12839 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12840 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12841 dired.c's scmp function, had undefined behavior.
12842 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12843 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12844 * buffer.h: ... to here, because these macros use current_buffer,
12845 and the new implementation with inline functions needs to have
12846 current_buffer in scope now, rather than later when the macros
12847 are used.
12848 (downcase, upcase1): New static inline functions.
12849 (DOWNCASE, UPCASE1): Reimplement using these functions.
12850 This avoids undefined behavior in expressions like
12851 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12852 from race conditions in accessing the global variables
12853 case_temp1 and case_temp2.
12854 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12855 * lisp.h (case_temp1, case_temp2): Remove their decls.
12856 * character.h (ASCII_CHAR_P): Move from here ...
12857 * lisp.h: ... to here, so that the inline functions mentioned
12858 above can use them.
12859
4a6bea26
PE
12860 * dired.c (directory_files_internal_unwind): Now static.
12861
f14b7e14
PE
12862 * fileio.c (file_name_as_directory, directory_file_name):
12863 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12864 Now static.
2893f146
PE
12865 (file_name_as_directory): Use const pointers when appropriate.
12866 (Fexpand_file_name): Likewise. In particular, newdir might
12867 point at constant storage, so make it a const pointer.
fd4ead52 12868 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12869 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12870 signedness issues.
f839df0c
PE
12871 (Fset_file_times, Finsert_file_contents, auto_save_error):
12872 Rename locals to avoid shadowing.
f14b7e14 12873
5716756e 12874 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12875 (Ftry_completion, Fall_completions): Rename or remove locals
12876 to avoid shadowing.
5716756e 12877
b4c3046a
PE
12878 * marker.c (bytepos_to_charpos): Remove; unused.
12879
b45db522
PE
12880 * lisp.h (verify_bytepos, count_markers): New decls,
12881 so that gcc does not warn that these functions aren't declared.
12882
85876d07
PE
12883 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12884 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12885 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12886 (copy_text): Remove unused local var.
85876d07 12887
03d78a21 12888 * filelock.c (within_one_second): Now static.
b3dd38ab 12889 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12890
5df8f01b
PE
12891 * buffer.c (fix_overlays_before): Mark locals as initialized.
12892 (fix_start_end_in_overlays): Likewise. This function should be
12893 simplified by using pointers-to-pointers, but that's a different
12894 matter.
b1d876f1 12895 (switch_to_buffer_1): Now static.
8f54f30a
PE
12896 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12897 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12898
a70072c9 12899 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12900 Fix pointer signedness issue.
edced198
PE
12901 (sys_subshell): Mark local as volatile if checking for lint,
12902 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12903 (MAXPATHLEN): Define only if needed.
a70072c9 12904
a0977c44
PE
12905 * process.c (serial_open, serial_configure): Move decls from here ...
12906 * systty.h: ... to here, so that they can be checked.
12907
a884fdcc
PE
12908 * fns.c (get_random, seed_random): Move extern decls from here ...
12909 * lisp.h: ... to here, so that they can be checked.
12910
604efe86 12911 * sysdep.c (reset_io): Now static.
b8950c94 12912 (wait_for_termination_signal): Remove; unused.
604efe86 12913
38fc62d9
PE
12914 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12915 (copy_keymap_item, append_key, push_text_char_description):
12916 Now static.
1004a21a 12917 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12918 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12919 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12920 (describe_map_tree):
12921 Rename locals to avoid shadowing.
38fc62d9 12922
2f2650da
PE
12923 * keyboard.c: Declare functions static if they are not used elsewhere.
12924 (echo_char, echo_dash, cmd_error, top_level_2):
12925 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12926 (read_char, kbd_buffer_get_event, make_lispy_position):
12927 (make_lispy_event, make_lispy_movement, apply_modifiers):
12928 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12929 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12930 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12931 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12932 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12933
a053e86c 12934 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12935 (mark_kboards): Move decl here ...
12936 * alloc.c (mark_kboards): ... from here.
a053e86c 12937
4752793e
PE
12938 * lisp.h (force_auto_save_soon): New decl.
12939
74f10ca7 12940 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12941 (DEFINE_DUMMY_FUNCTION): New macro.
12942 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12943 Use it.
c03cd23f
PE
12944 (main): Add casts to avoid warnings
12945 if GCC considers string literals to be constants.
74f10ca7 12946
022e70d4
PE
12947 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12948
59d6fe83
PE
12949 * dbusbind.c: Pointer signedness fixes.
12950 (xd_signature, xd_append_arg, xd_initialize):
12951 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12952 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12953 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12954 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12955
78320123
PE
12956 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12957 if GCC considers string literals to be constants.
49cebcca 12958 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12959
35ac2a97
SM
129602011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12961
fb103ca9
SM
12962 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12963 (print_preprocess, print_object): New macro to fix last change.
12964
35ac2a97
SM
12965 * print.c (print_preprocess): Don't forget font objects.
12966
62973b41
JB
129672011-03-16 Juanma Barranquero <lekktu@gmail.com>
12968
12969 * emacs.c (USAGE3): Doc fixes.
12970
0e48bb22
AS
129712011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12972
12973 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12974 structure.
12975
7684e57b
JB
129762011-03-14 Juanma Barranquero <lekktu@gmail.com>
12977
12978 * lisp.h (VWindow_system, Qfile_name_history):
12979 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12980 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12981 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12982
12983 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12984 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12985
12986 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12987 * w32console.c (detect_input_pending, read_input_pending)
12988 (encode_terminal_code):
12989 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12990 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12991 (w32_system_caret_y, Qfile_name_history):
12992 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12993 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12994 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12995 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12996 * w32proc.c (Qlocal, report_file_error):
12997 * w32term.c (Vwindow_system, updating_frame):
12998 * w32uniscribe.c (initialized, uniscribe_font_driver):
12999 Remove unneeded extern declarations.
13000
2aa46d6c
CY
130012011-03-14 Chong Yidong <cyd@stupidchicken.com>
13002
c96bbc66 13003 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13004
cffc6f3b
CY
130052011-03-13 Chong Yidong <cyd@stupidchicken.com>
13006
13007 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13008 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13009 These macros can no longer be used for assignment.
13010
44f230aa
SM
13011 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13012 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13013 (record_buffer_markers, fetch_buffer_markers): New functions for
13014 recording and fetching special buffer markers.
13015 (set_buffer_internal_1, set_buffer_temp): Use them.
13016
13017 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13018
13019 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13020
13021 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13022 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13023
13024 * xdisp.c (hscroll_window_tree):
13025 (reconsider_clip_changes): Use PT instead of BUF_PT.
13026
d251f04b
EZ
130272011-03-13 Eli Zaretskii <eliz@gnu.org>
13028
13029 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13030 $(EMACS_ROOT)/lib/intprops.h.
13031
f0c77cd1
PE
130322011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13033
3eca4629
PE
13034 Fix more problems found by GCC 4.5.2's static checks.
13035
7c86ee98
PE
13036 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13037 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13038 (xg_free_frame_widgets): Make it clear that a local variable is
13039 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13040 (gdk_window_get_screen): Make it clear that this macro is needed
13041 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13042 (int_gtk_range_get_value): New function, which avoids a diagnostic
13043 from gcc -Wbad-function-cast.
13044 (xg_set_toolkit_scroll_bar_thumb): Use it.
13045 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13046 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13047 (get_utf8_string, xg_get_file_with_chooser):
13048 Rename locals to avoid shadowing.
13049 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13050
41729b81
PE
13051 * xgselect.c (xg_select): Remove unused var.
13052
f0c77cd1
PE
13053 * image.c (four_corners_best): Mark locals as initialized.
13054 (gif_load): Initialize transparent_p to zero (Bug#8238).
13055 Mark another local as initialized.
ec6cf4c6 13056 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13057
ce0ad53d 13058 * image.c (clear_image_cache): Now static.
d5d5a617 13059 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13060 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13061 (x_edge_detection): Remove unnecessary cast that
13062 gcc -Wbad-function-cast diagnoses.
2037898d 13063 (gif_load): Fix pointer signedness.
6ae141d6
PE
13064 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13065 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13066
33383987 130672011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13068
d32df629
PE
13069 Improve quality of tests for time stamp overflow.
13070 For example, without this patch (encode-time 0 0 0 1 1
13071 1152921504606846976) returns the obviously-bogus value (-948597
13072 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13073 reports time overflow. See
13074 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13075 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13076 * editfns.c: Include limits.h and intprops.h.
13077 (TIME_T_MIN, TIME_T_MAX): New macros.
13078 (time_overflow): Move earlier, to before first use.
13079 (hi_time, lo_time): New functions, for an accurate test for
13080 out-of-range times.
13081 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13082 (Fget_internal_run_time): Don't assume time_t fits in int.
13083 (make_time): Use list2 instead of Fcons twice.
13084 (Fdecode_time): More accurate test for out-of-range times.
13085 (check_tm_member): New function.
13086 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13087 (lisp_time_argument): Don't rely on undefined left-shift and
13088 right-shift behavior when checking for time stamp overflow.
8be6f318 13089
fe31d94c
PE
13090 * editfns.c (time_overflow): New function, refactoring common code.
13091 (Fformat_time_string, Fdecode_time, Fencode_time):
13092 (Fcurrent_time_string): Use it.
13093
8be6f318
PE
13094 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13095 * dired.c (make_time): Move to ...
13096 * editfns.c (make_time): ... here.
13097 * systime.h: Note the move.
13098
09d9db2c 130992011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13100
126bc0dc
YM
13101 * fringe.c (update_window_fringes): Remove unused variables.
13102
c47cbdfd
YM
13103 * unexmacosx.c (copy_data_segment): Also copy __got section.
13104 (Bug#8223)
13105
7ac80be9
EZ
131062011-03-12 Eli Zaretskii <eliz@gnu.org>
13107
c96bbc66 13108 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13109 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13110 Constify `char *' arguments and their references according to
13111 prototypes in tparam.h.
13112
ecb0f94d 13113 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13114
7ac80be9
EZ
13115 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13116 Adapt all references accordingly.
13117
13118 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13119
ef1fd07e
TT
131202011-03-11 Tom Tromey <tromey@redhat.com>
13121
13122 * buffer.c (syms_of_buffer): Remove obsolete comment.
13123
7ef4b50c
EZ
131242011-03-11 Eli Zaretskii <eliz@gnu.org>
13125
13126 * termhooks.h (encode_terminal_code): Declare prototype.
13127
13128 * msdos.c (encode_terminal_code): Don't declare prototype.
13129
13130 * term.c (encode_terminal_code): Now external again, used by
13131 w32console.c and msdos.c.
13132
44f230aa
SM
13133 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13134 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13135
4b1ec863 131362011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13137
1714f52b 13138 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13139
4b1ec863
PE
13140 * fringe.c (update_window_fringes): Mark locals as initialized
13141 (Bug#8227).
13142 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13143
524c7aa6
PE
13144 * alloc.c (mark_fringe_data): Move decl from here ...
13145 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13146 to check its interface.
13147 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13148
a5c0af81 13149 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13150 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13151 (fontset_font): Mark local as initialized.
a9a06e0b 13152 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13153
b4716021
PE
13154 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13155
811e9bac 13156 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13157 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13158 (x_own_selection, Fx_disown_selection_internal): Rename locals
13159 to avoid shadowing.
13160 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13161
7e3ab302
PE
13162 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13163 so that the caller can use some name other than gcpro1.
13164 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13165 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13166 (Fx_backspace_delete_keys_p):
13167 Use them to avoid shadowing, and rename vars to avoid shadowing.
13168 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13169 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13170 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13171 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13172 Remove unused locals.
7e3ab302
PE
13173 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13174 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13175 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13176 macros.
f78faa98 13177
e2b13473
PE
13178 * xterm.h (x_mouse_leave): New decl.
13179
77f23912
PE
13180 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13181 Remove unused functions.
cdf4ba58
PE
13182 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13183 (x_calc_absolute_position): Now static.
7411c686 13184 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13185 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13186 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13187 unless they are used.
38d0b34a
PE
13188 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13189 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13190 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13191 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13192 (x_error_catcher, x_connection_closed, x_error_handler):
13193 (x_error_quitter, xembed_send_message, x_iconify_frame):
13194 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13195 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13196 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13197
44f230aa
SM
13198 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13199 Rename or move locals to avoid shadowing.
6b463e58 13200 (tty_defined_color, merge_face_heights): Now static.
5967d051 13201 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13202 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13203 does not deduce is never used uninitialized.
73719eba
PE
13204 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13205 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13206
426994c3 13207 * terminal.c (store_terminal_param): Now static.
5489860b 13208
032f1620 13209 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13210 (set_frame_menubar): Remove unused local.
d4323972 13211 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13212 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13213 since they might point to immutable storage.
281585b0
PE
13214 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13215 since it's unused otherwise.
032f1620 13216
367c19e5 13217 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13218 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13219 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13220 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13221 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13222 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13223 does not deduce are never used uninitialized.
70739cbe 13224
07b48fa9
PE
13225 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13226
8868a238 13227 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13228 * window.c (window_loop, size_window):
13229 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13230
7e5cf297 13231 * window.c (display_buffer): Now static.
d6550a9f
PE
13232 (size_window): Mark variables that gcc -Wuninitialized
13233 does not deduce are never used uninitialized.
a586633d
PE
13234 * window.h (check_all_windows): New decl, to forestall
13235 gcc -Wmissing-prototypes diagnostic.
5b555da1 13236 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13237
f6095868
PE
13238 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13239 shadowing.
13240 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13241 Include <limits.h>.
13242 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13243 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13244 (load_charset_map): Mark variables that gcc -Wuninitialized
13245 does not deduce are never used uninitialized.
53df7c11 13246 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13247
f38b440c
PE
13248 * coding.c (coding_set_source, coding_set_destination):
13249 Use "else { /* comment */ }" rather than "else /* comment */;"
13250 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13251 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13252 a block, when the outer 'i' will do.
13253 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13254 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13255 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13256 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13257 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13258 Rename locals to avoid shadowing.
13259 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13260 * coding.c (emacs_mule_char, encode_invocation_designation):
13261 Now static, since they're not used elsewhere.
413bb2db 13262 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13263 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13264 (decode_coding_emacs_mule): Mark variables that gcc
13265 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13266 (detect_coding_iso_2022): Initialize a local variable that might
13267 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13268 this initialization is needed. (Bug#8211)
5f58e762
PE
13269 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13270 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13271 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13272 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13273 Remove unused macros.
f38b440c 13274
232b38b9 13275 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13276 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13277 * character.c (string_count_byte8): Likewise.
232b38b9 13278
fb90da1b
PE
13279 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13280 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13281
fb93dbc2
PE
13282 * chartab.c (copy_sub_char_table): Now static, since it's not used
13283 elsewhere.
5c156ace
PE
13284 (sub_char_table_ref_and_range, char_table_ref_and_range):
13285 Rename locals to avoid shadowing.
bbcd0949 13286 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13287
7d3b3862 13288 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13289 (BIDI_BOB): Remove unused macro.
7d3b3862 13290
6be7d3da
PE
13291 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13292 deduce are never used uninitialized.
c2ed9c8b 13293 * term.c (encode_terminal_code): Likewise.
6be7d3da 13294
75f8807f 13295 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13296
50938595
PE
13297 * tparam.h: New file.
13298 * term.c, tparam.h: Include it.
13299 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13300 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13301 Move these decls to tparam.h, and make them agree with what
13302 is actually in tparam.c. The previous trick of using incompatible
13303 decls in different modules does not conform to the C standard.
13304 All callers of tparam changed to use tparam's actual API.
13305 * tparam.c (tparam1, tparam, tgoto):
13306 Use const pointers where appropriate.
13307
fbceeba2
PE
13308 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13309 * cm.h (struct cm): Likewise.
13310 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13311 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13312 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13313 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13314 (turn_on_face, init_tty): Likewise.
13315 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13316
7f3f1250
PE
13317 * term.c (term_mouse_position): Rename local to avoid shadowing.
13318
e6ca6543
PE
13319 * alloc.c (mark_ttys): Move decl from here ...
13320 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13321
c40f8d15
AS
133222011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13323
13324 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13325
cfe0661d
JB
133262011-03-09 Juanma Barranquero <lekktu@gmail.com>
13327
13328 * search.c (compile_pattern_1): Remove argument regp, unused since
13329 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13330 (compile_pattern): Don't pass it.
13331
0afb4571
J
133322011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13333
13334 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13335 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13336 for ! HAVE_GTK3.
13337 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13338
13339 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13340
13341 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13342 gdk_window_get_screen, gdk_window_get_geometry,
13343 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13344 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13345 (xg_get_pixbuf_from_pixmap): New function.
13346 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13347 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13348 Call xg_get_pixbuf_from_pixmap instead of
13349 gdk_pixbuf_get_from_drawable.
13350 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13351 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13352 (xg_check_special_colors): Use GtkStyleContext and its functions
13353 for HAVE_GTK3.
13354 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13355 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13356 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13357 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13358 Call gtk_widget_get_preferred_size.
0afb4571
J
13359 (xg_frame_resized): gdk_window_get_geometry only takes 5
13360 parameters.
44f230aa
SM
13361 (xg_win_to_widget, xg_event_is_for_menubar):
13362 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13363 (xg_set_widget_bg): New function.
13364 (delete_cb): New function.
895009e1 13365 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13366 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13367 (xg_set_background_color): Call xg_set_widget_bg.
13368 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13369 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13370 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13371 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13372 if ! HAVE_GTK3.
13373 (update_frame_tool_bar): Call gtk_widget_hide.
13374 (xg_initialize): Use GDK_KEY_g.
13375
13376 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13377 if ! HAVE_GTK3
13378 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13379
13380 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13381 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13382 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13383
1c2cc4ef
JB
133842011-03-08 Juanma Barranquero <lekktu@gmail.com>
13385
13386 * w32xfns.c (select_palette): Check success of RealizePalette against
13387 GDI_ERROR, not zero.
13388
33383987 13389See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13390
13391;; Local Variables:
13392;; coding: utf-8
aac0c6e3
MR
13393;; End:
13394
2f097256 13395 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13396
13397 This file is part of GNU Emacs.
13398
13399 GNU Emacs is free software: you can redistribute it and/or modify
13400 it under the terms of the GNU General Public License as published by
13401 the Free Software Foundation, either version 3 of the License, or
13402 (at your option) any later version.
13403
13404 GNU Emacs is distributed in the hope that it will be useful,
13405 but WITHOUT ANY WARRANTY; without even the implied warranty of
13406 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13407 GNU General Public License for more details.
13408
13409 You should have received a copy of the GNU General Public License
13410 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.