* indent.c (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e39e811e
PE
12011-06-18 Paul Eggert <eggert@cs.ucla.edu>
2
53b2623d
PE
3 * indent.c (sane_tab_width): New function.
4 (current_column, scan_for_column, Findent_to, position_indentation)
5 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7
45aebb64
PE
8 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
9
f2ed8a70
PE
10 * lisp.h (lint_assume): New macro.
11 * composite.c (composition_gstring_put_cache):
12 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13
abe80cc6
PE
14 * editfns.c, insdel.c:
15 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 16
b02c740e
PE
17 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
18
ebc96716
PE
19 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
20
b4e50fa0 21 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 22 Use much-faster test for byte-length change.
311d5d7c 23 Don't assume string byte-length fits in 'int'.
a4cf38e4 24 Check that character arg fits in 'int'.
85461888 25 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 26
c0c1ee9f
PE
27 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
28
a498d7f4
PE
29 * fns.c (concat): Catch string overflow earlier.
30 Do not rely on integer wraparound.
31
e39e811e
PE
32 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
33
fadf4e30
PE
342011-06-17 Paul Eggert <eggert@cs.ucla.edu>
35
87830974
PE
36 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
37 * xdisp.c (forward_to_next_line_start)
38 (back_to_previous_visible_line_start)
39 (reseat_at_next_visible_line_start, next_element_from_buffer):
40 Don't arbitrarily truncate the value of 'selective' to int.
41
76031fad
PE
42 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
43
5eb55db9
PE
44 * composite.c: Don't truncate sizes to 'int'.
45 (composition_gstring_p, composition_reseat_it)
46 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
47 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
48 not EMACS_UINT, for indexes.
5eb55db9 49
0703a717
PE
50 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
51
d6202519
PE
52 * buffer.c: Include <verify.h>.
53 (struct sortvec.priority, struct sortstr.priority):
8961a454 54 Now EMACS_INT, not int.
c20998a7 55 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
56 (struct sortstr.size, record_overlay_string)
57 (struct sortstrlist.size, struct sortlist.used):
58 Don't truncate size to int.
59 (record_overlay_string): Check for size-calculation overflow.
d6202519 60 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 61
28177add
PE
622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
63
dd3482fe
PE
64 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
65 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
66 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
67
393d71f3 68 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
69 * fileio.c (Finsert_file_contents):
70 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
71 Remove the old (too-loose) buffer overflow checks.
72 They weren't needed, since make_gap checks for buffer overflow.
73 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
74 The old code merely checked for Emacs fixnum overflow, and relied
75 on undefined (wraparound) behavior. The new code avoids undefined
76 behavior, and also checks for ptrdiff_t and/or size_t overflow.
77
2e6813b0 78 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
79 Tune. Don't use wider integers than needed. Don't use alloca.
80 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 81
599a9e4f
PE
82 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
83
99561444
PE
84 * insdel.c, lisp.h (buffer_overflow): New function.
85 (insert_from_buffer_1, replace_range, replace_range_2):
86 * insdel.c (make_gap_larger):
87 * editfns.c (Finsert_char):
88 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
89
28177add
PE
90 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
91
e69dafad
PE
922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
93
a7af7fde 94 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 95
b1c46f02
PE
96 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
97 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
98
e69dafad
PE
99 * fileio.c: Don't assume EMACS_INT fits in off_t.
100 (emacs_lseek): New static function.
101 (Finsert_file_contents, Fwrite_region): Use it.
102 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
103
566684ea
PE
104 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
105
e6966cd6
PE
106 * fns.c: Don't overflow int when computing a list length.
107 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
108 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
109 truncation on 64-bit hosts. Check for QUIT every
110 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
111 faster and is responsive enough.
112 (Flength): Report an error instead of overflowing an integer.
113 (Fsafe_length): Return a float if the value is not representable
114 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 115 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 116 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 117
dd0b0efb
PE
118 * alloc.c: Check that resized vectors' lengths fit in fixnums.
119 (header_size, word_size): New constants.
120 (allocate_vectorlike): Don't check size overflow here.
121 (allocate_vector): Check it here instead, since this is the only
122 caller of allocate_vectorlike that could cause overflow.
123 Check that the new vector's length is representable as a fixnum.
124
86fe5cfe
PE
125 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
126 The previous code was bogus. For example, next_almost_prime (32)
127 returned 39, which is undesirable as it is a multiple of 3; and
128 next_almost_prime (24) returned 25, which is a multiple of 5 so
129 why was the code bothering to check for multiples of 7?
130
80e88859
PE
131 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
132
4a2f0ad6
PE
133 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
134
f66c7cf8
PE
135 Variadic C functions now count arguments with ptrdiff_t.
136 This partly undoes my 2011-03-30 change, which replaced int with size_t.
137 Back then I didn't know that the Emacs coding style prefers signed int.
138 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
139 were being counted with int, which may truncate counts on 64-bit
140 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
141 * lisp.h (struct Lisp_Subr.function.aMANY)
142 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
143 Arg counts are now ptrdiff_t, not size_t.
144 All variadic functions and their callers changed accordingly.
145 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
146 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
147 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
148 * callint.c (Fcall_interactively): Check arg count for overflow,
149 to avoid potential buffer overrun. Use signed char, not 'int',
150 for 'varies' array, so that we needn't bother to check its size
151 calculation for overflow.
152 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
153 * eval.c (apply_lambda):
154 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
155 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
156 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
157
a1759b76
PE
158 * callint.c (Fcall_interactively): Don't use index var as event count.
159
d96be9fc
PE
160 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
161 * mem-limits.h (SIZE): Remove; no longer used.
162
a690a978 163 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 164
578c21e6
PE
165 Remove unnecessary casts.
166 * xterm.c (x_term_init):
167 * xfns.c (x_set_border_pixel):
168 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
169 These aren't needed now that we assume ANSI C.
170
96f53c6c
PE
171 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
172 It's more likely to cause problems (due to unsigned overflow)
173 than to cure them.
174
83c77d31
PE
175 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
176
ee2079f1
PE
177 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
178
6da65536
PE
179 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
180
7147c4a4
PE
181 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
182
193e32d9
PE
183 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
184
e5533da6
PE
185 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
186
9910e595
PE
187 GLYPH_CODE_FACE returns EMACS_INT, not int.
188 * dispextern.h (merge_faces):
189 * xfaces.c (merge_faces):
01103c44
PE
190 * xdisp.c (get_next_display_element, next_element_from_display_vector):
191 Don't assume EMACS_INT fits in int.
9910e595 192
2638320e
PE
193 * character.h (CHAR_VALID_P): Remove unused parameter.
194 * fontset.c, lisp.h, xdisp.c: All uses changed.
195
045eb8d9
PE
196 * editfns.c (Ftranslate_region_internal): Omit redundant test.
197
c1f134b5
PE
198 * fns.c (concat): Minor tuning based on overflow analysis.
199 This doesn't fix any bugs. Use int to hold character, instead
200 of constantly refetching from Emacs object. Use XFASTINT, not
201 XINT, for value known to be a character. Don't bother comparing
202 a single byte to 0400, as it's always less.
203
395fcb93 204 * floatfns.c (Fexpt):
327eeec8
PE
205 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
206
abbd3d23
PE
207 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
208 for characters.
209
684a03ef
PE
210 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
211
0fed43f3
PE
212 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
213 Without this fix, on a 64-bit host (aset S 0 4294967386) would
214 incorrectly succeed when S was a string, because 4294967386 was
215 truncated before it was used.
216
8fd02eb7
PE
217 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
218 Otherwise, an out-of-range integer could cause undefined behavior
219 on a 64-bit host.
220
f8c86b69
PE
221 * composite.c: Use int, not EMACS_INT, for characters.
222 (fill_gstring_body, composition_compute_stop_pos): Use int, not
223 EMACS_INT, for values that are known to be in character range.
224 This doesn't fix any bugs but is the usual style inside Emacs and
225 may generate better code on 32-bit machines.
226
34206dd2
PE
227 Make sure a 64-bit char is never passed to ENCODE_CHAR.
228 This is for reasons similar to the recent CHAR_STRING fix.
229 * charset.c (Fencode_char): Check that character arg is actually
230 a character. Pass an int to ENCODE_CHAR.
231 * charset.h (ENCODE_CHAR): Verify that the character argument is no
232 wider than 'int', as a compile-time check to prevent future regressions
233 in this area.
234
c5958d4c 235 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
236
237 Make sure a 64-bit char is never passed to CHAR_STRING.
238 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
239 by silently ignoring the top 32 bits, allowing some values
240 that were far too large to be valid characters.
241 * character.h: Include <verify.h>.
242 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
243 arguments are no wider than unsigned, as a compile-time check
244 to prevent future regressions in this area.
245 * data.c (Faset):
01103c44 246 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
247 (Fsubst_char_in_region):
248 * fns.c (concat):
249 * xdisp.c (decode_mode_spec_coding):
250 Adjust to CHAR_STRING's new requirement.
251 * editfns.c (Finsert_char, Fsubst_char_in_region):
252 * fns.c (concat): Check that character args are actually
253 characters. Without this test, these functions did the wrong
254 thing with wildly out-of-range values on 64-bit hosts.
255
d37ca623
PE
256 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
257 These casts should not be needed on 32-bit hosts, either.
258 * keyboard.c (read_char):
259 * lread.c (Fload): Remove casts to unsigned.
260
ea204efb
PE
261 * lisp.h (UNSIGNED_CMP): New macro.
262 This fixes comparison bugs on 64-bit hosts.
263 (ASCII_CHAR_P): Use it.
264 * casefiddle.c (casify_object):
01103c44 265 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
266 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
267 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
268 * dispextern.h (FACE_FROM_ID):
269 * keyboard.c (read_char): Use UNSIGNED_CMP.
270
41cb286c
PE
271 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
272 not to EMACS_INT, to avoid GCC warning.
273
4a1b9832
PE
274 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
275
55daad71
PE
276 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
277 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
278 isn't needed on 32-bit machines.
8f95c75c 279
01103c44
PE
280 * buffer.c (Fgenerate_new_buffer_name):
281 Use EMACS_INT for count, not int.
0ceccced 282 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
283
284 * data.c (Qcompiled_function): Now static.
285
c6f072e7
PE
286 * window.c (window_body_lines): Now static.
287
20ce5912
PE
288 * image.c (gif_load): Rename local to avoid shadowing.
289
9c4c5f81
PE
290 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
291 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
292 * alloc.c (make_save_value): Integer argument is now of type
293 ptrdiff_t, not int.
294 (mark_object): Use ptrdiff_t, not int.
295 * lisp.h (pD): New macro.
296 * print.c (print_object): Use it.
297
c0c5c8ae
PE
298 * alloc.c: Use EMACS_INT, not int, to count objects.
299 (total_conses, total_markers, total_symbols, total_vector_size)
300 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
301 (total_free_floats, total_floats, total_free_intervals)
302 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
303 Now EMACS_INT, not int. All uses changed.
304 (Fgarbage_collect): Compute overall total using a double, so that
305 integer overflow is less likely to be a problem. Check for overflow
306 when converting back to an integer.
5a25e253
PE
307 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
308 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
309 These were 'int' variables that could overflow on 64-bit hosts;
310 they were never used, so remove them instead of repairing them.
211a0b2a 311 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
312 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
313 Previously, this ceilinged at INT_MAX, but that doesn't work on
314 64-bit machines.
e46bb31a 315 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 316
c78baabf 317 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 318 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
319 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
320 when a (possibly-narrower) signed value would do just as well.
321 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 322
c9d624c6
PE
323 * alloc.c: Catch some string size overflows that we were missing.
324 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
325 for convenience in STRING_BYTES_MAX.
326 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
327 The definition here is exact; the one in lisp.h was approximate.
328 (allocate_string_data): Check for string overflow. This catches
329 some instances we weren't catching before. Also, it catches
330 size_t overflow on (unusual) hosts where SIZE_MAX <= min
331 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
332 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 333
c9d624c6
PE
334 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
335 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
336 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
337
353032ce
PE
338 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
339
2bccce07
PE
340 * alloc.c (Fmake_string): Check for out-of-range init.
341
0ac30604
SM
3422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
343
344 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
345
c195f2de
JD
3462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
347
348 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
349 xg_get_default_scrollbar_width.
350
351 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
352 (int_gtk_range_get_value): Move to the scroll bar part of the file.
353 (style_changed_cb): Call update_theme_scrollbar_width and call
354 x_set_scroll_bar_default_width and xg_frame_set_char_size for
355 all frames (Bug#8505).
356 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
357 Call gtk_window_set_resizable if HAVE_GTK3.
358 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
359 and height if HAVE_GTK3 (Bug#8505).
360 (scroll_bar_width_for_theme): New variable.
361 (update_theme_scrollbar_width): New function.
362 (xg_get_default_scrollbar_width): Move code to
363 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
364 (xg_initialize): Call update_theme_scrollbar_width.
365
366 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
367
368 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
369
e10ac9f1
MR
3702011-06-12 Martin Rudalics <rudalics@gmx.at>
371
372 * frame.c (make_frame): Call other_buffer_safely instead of
373 other_buffer.
374
375 * window.c (temp_output_buffer_show): Call display_buffer with
376 second argument Vtemp_buffer_show_specifiers and reset latter
377 immediately after the call.
378 (Vtemp_buffer_show_specifiers): New variable.
379 (auto_window_vscroll_p, next_screen_context_lines)
380 (Vscroll_preserve_screen_position): Remove leading asterisks from
381 doc-strings.
382
2d3c217e 3832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 384
7b7f97e8 385 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
386 * buffer.c (Qclone_number): Remove for now, as it's unused.
387 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
388 (record_buffer): Remove unused local.
389 * frame.c (other_visible_frames, frame_buffer_list): Now static.
390 (set_frame_buffer_list): Remove; unused.
391 * frame.h (other_visible_frames): Remove decl.
392 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
393 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
394 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
395 if HAVE_GPM.
396 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
397 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
398 Define only if HAVE_GPM.
399 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
400 (update_hints_inhibit): Remove; never set. All uses removed.
401 * widgetprv.h (emacsFrameClassRec): Remove decl.
402 * window.c (delete_deletable_window): Now returns void, since it
403 wasn't returning anything.
404 (compare_window_configurations): Remove unused locals.
405 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
406 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
407 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
408 the same widths as pointers. This follows up on the 2011-05-06 patch.
409 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
410 * xterm.h: Likewise.
411 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
412
1384b89e
JB
4132011-06-12 Juanma Barranquero <lekktu@gmail.com>
414
415 * makefile.w32-in: Update dependencies.
416 (LISP_H): Add lib/intprops.h.
417
1100a63c
CY
4182011-06-11 Chong Yidong <cyd@stupidchicken.com>
419
420 * image.c (gif_load): Add animation frame delay to the metadata.
421 (syms_of_image): Use DEFSYM. New symbol `delay'.
422
6198ccd0
MR
4232011-06-11 Martin Rudalics <rudalics@gmx.at>
424
425 * window.c (delete_deletable_window): Re-add.
426 (Fset_window_configuration): Rewrite to handle dead buffers and
427 consequently deletable windows.
428 (window_tree, Fwindow_tree): Remove. Supply functionality in
429 window.el.
430 (compare_window_configurations): Simplify code.
431
b6e3633c
AS
4322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
433
1ab0dee5
AS
434 * image.c (imagemagick_load_image): Fix type mismatch.
435 (Fimagemagick_types): Likewise.
436
b6e3633c
AS
437 * window.h (replace_buffer_in_windows): Declare.
438
9397e56f
MR
4392011-06-11 Martin Rudalics <rudalics@gmx.at>
440
441 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
442 Qclone_number. Remove external declaration of Qdelete_window.
443 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
444 code.
445 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
446 Qbuffer_list_update_hook if allowed.
447 (Fother_buffer): Rewrite doc-string. Major rewrite for new
448 buffer list implementation.
449 (other_buffer_safely): New function.
450 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
451 calls to replace_buffer_in_windows and
452 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
453 if allowed.
454 (record_buffer): Inhibit quitting and rewrite using quittable
455 functions. Run Qbuffer_list_update_hook if allowed.
456 (Frecord_buffer, Funrecord_buffer): New functions.
457 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
458 switch-to-buffer to window.el.
459 (bury-buffer): Move to window.el.
460 (Vbuffer_list_update_hook): New variable.
461
462 * lisp.h (other_buffer_safely): Add prototype in buffer.c
463 section.
464
465 * window.h (resize_frame_windows): Move up in code.
466 (Fwindow_frame): Remove EXFUN.
467 (replace_buffer_in_all_windows): Remove prototype.
468 (replace_buffer_in_windows_safely): Add prototype.
469
470 * window.c: Declare Qdelete_window static again. Move down
471 declaration of select_count.
472 (Fnext_window, Fprevious_window): Rewrite doc-strings.
473 (Fother_window): Move to window.el.
474 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
475 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
476 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
477 window.el.
478 (replace_buffer_in_windows): Implement by calling
479 Qreplace_buffer_in_windows.
480 (replace_buffer_in_all_windows): Remove with some functionality
481 moved into replace_buffer_in_windows_safely.
482 (replace_buffer_in_windows_safely): New function.
483 (select_window_norecord, select_frame_norecord): Move in front
484 of run_window_configuration_change_hook. Remove now obsolete
485 declarations.
486 (Fset_window_buffer): Rewrite doc-string. Call
487 Qrecord_window_buffer.
488 (keys_of_window): Move binding for other-window to window.el.
489
b50691aa
CY
4902011-06-11 Chong Yidong <cyd@stupidchicken.com>
491
492 * dispextern.h (struct image): Replace data member, whose int_val
493 and ptr_val fields were not used by anything, with a single
494 lisp_val object.
495
496 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
497 (gif_clear_image, gif_load, imagemagick_load_image)
498 (gs_clear_image, gs_load): Callers changed.
499
3f754b86
PE
5002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
501
cca69397
PE
502 * buffer.h: Include <time.h>, for time_t.
503 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
504
109e28d0
PE
505 Fix minor problems found by static checking.
506
60737f02
PE
507 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
508
4b66faf3
PE
509 Make identifiers static if they are not used in other modules.
510 * data.c (Qcompiled_function, Qframe, Qvector):
511 * image.c (QimageMagick, Qsvg):
512 * minibuf.c (Qmetadata):
513 * window.c (resize_window_check, resize_root_window): Now static.
514 * window.h (resize_window_check, resize_root_window): Remove decls.
515
109e28d0
PE
516 * window.c (window_deletion_count, delete_deletable_window):
517 Remove; unused.
46a4ce9e
PE
518 (window_body_lines): Now static.
519 (Fdelete_other_windows_internal): Mark vars as initialized.
520 Make sure 'resize_failed' is initialized.
521 (run_window_configuration_change_hook): Rename local to avoid shadowing.
522 (resize_window_apply): Remove unused local.
523 * window.h (delete_deletable_window): Remove decl.
524
109e28d0 525 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
526 (imagemagick_load_image): Fix pointer signedness problem by changing
527 last arg from unsigned char * to char *. All uses changed.
528 Also, fix a local for similar reasons.
529 Remove unused locals. Remove locals to avoid shadowing.
530 (fn_rsvg_handle_free): Remove; unused.
531 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 532 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 533
3f754b86
PE
534 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
535
2547adb1
CY
5362011-06-10 Chong Yidong <cyd@stupidchicken.com>
537
538 * image.c (gif_load): Fix omitted cast error introduced by
539 2011-06-06 change.
540
2c8e37d4
MR
5412011-06-10 Martin Rudalics <rudalics@gmx.at>
542
543 * window.h (resize_proportionally, orig_total_lines)
544 (orig_top_line): Remove from window structure.
545 (set_window_height, set_window_width, change_window_heights)
546 (Fdelete_window): Remove prototypes.
547 (resize_frame_windows): Remove duplicate declaration.
548
440a42e3
EZ
5492011-06-10 Eli Zaretskii <eliz@gnu.org>
550
551 * window.h (resize_frame_windows, resize_window_check)
552 (delete_deletable_window, resize_root_window)
553 (resize_frame_windows): Declare prototypes.
554
555 * window.c (resize_window_apply): Make definition be "static" to
556 match the prototype.
557
562dd5e9
MR
5582011-06-10 Martin Rudalics <rudalics@gmx.at>
559
560 * window.c: Remove declarations of Qwindow_size_fixed,
561 window_min_size_1, window_min_size_2, window_min_size,
562 size_window, window_fixed_size_p, enlarge_window, delete_window.
563 Remove static from declaration of Qdelete_window, it's
564 temporarily needed by Fbury_buffer.
565 (replace_window): Don't assign orig_top_line and
566 orig_total_lines.
567 (Fdelete_window, delete_window): Remove. Window deletion is
568 handled by window.el.
569 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
570 Fdelete_window calls with calls to Qdelete_window.
571 (Fdelete_other_windows): Remove. Deleting other windows is
572 handled by window.el.
573 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
574 handled in window.el.
575 (window_min_size_2, window_min_size_1, window_min_size): Remove.
576 Window minimum sizes are handled in window.el.
577 (shrink_windows, size_window, set_window_height)
578 (set_window_width, change_window_heights, window_height)
579 (window_width, CURBEG, CURSIZE, enlarge_window)
580 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
581 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
582 handled in window.el.
583 (make_dummy_parent): Rename to make_parent_window and give it a
584 second argument horflag.
585 (make_window): Don't set resize_proportionally any more.
586 (Fsplit_window): Remove. Windows are split in window.el.
587 (save_restore_action, save_restore_orig_size)
588 (shrink_window_lowest_first, save_restore_orig_size): Remove.
589 Resize mini windows in window.el.
590 (grow_mini_window, shrink_mini_window): Implement by calling
591 Qresize_root_window_vertically, resize_window_check and
592 resize_window_apply.
593 (saved_window, Fset_window_configuration, save_window_save): Do
594 not handle orig_top_line, orig_total_lines, and
595 resize_proportionally.
596 (window_min_height, window_min_width): Move to window.el.
597 (keys_of_window): Move bindings for delete-other-windows,
598 split-window, delete-window and enlarge-window to window.el.
599
600 * buffer.c: Temporarily extern Qdelete_window.
601 (Fbury_buffer): Temporarily call Qdelete_window instead of
602 Fdelete_window (Fbury_buffer will move to window.el soon).
603
604 * frame.c (set_menu_bar_lines_1): Remove code handling
605 orig_top_line and orig_total_lines.
606
607 * dispnew.c (adjust_frame_glyphs_initially): Don't use
608 set_window_height but set heights directly.
609 (change_frame_size_1): Use resize_frame_windows.
610
611 * xdisp.c (init_xdisp): Don't use set_window_height but set
612 heights directly.
613
614 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
615 resize_frame_windows instead of change_window_heights and run
616 run_window_configuration_change_hook.
617
618 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
619 instead of change_window_heights and run
620 run_window_configuration_change_hook.
621
1a13852e
MR
6222011-06-09 Martin Rudalics <rudalics@gmx.at>
623
624 * window.c (replace_window): Rename second argument REPLACEMENT to
625 NEW. New third argument SETFLAG. Rewrite.
626 (delete_window, make_dummy_parent): Call replace_window with
627 third argument 1.
628 (window_list_1): Move down in code.
629 (run_window_configuration_change_hook): Move set_buffer part
630 before select_frame_norecord part in order to unwind correctly.
631 Rename count1 to count.
632 (recombine_windows, delete_deletable_window, resize_root_window)
633 (Fdelete_other_windows_internal)
634 (Frun_window_configuration_change_hook, make_parent_window)
635 (resize_window_check, resize_window_apply, Fresize_window_apply)
636 (resize_frame_windows, Fsplit_window_internal)
637 (Fdelete_window_internal, Fresize_mini_window_internal): New
638 functions.
639 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
640
f3d1777e
MR
6412011-06-08 Martin Rudalics <rudalics@gmx.at>
642
496e208e
MR
643 * window.h (window): Add some new members to window structure -
644 normal_lines, normal_cols, new_total, new_normal, clone_number,
645 splits, nest, prev_buffers, next_buffers.
646 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 647 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 648
f3d1777e
MR
649 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
650 Remove.
496e208e
MR
651 (make_dummy_parent): Set new members of windows structure.
652 (make_window): Move down in code. Handle new members of window
653 structure.
654 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
655 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
656 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
657 (Fset_window_prev_buffers, Fwindow_next_buffers)
658 (Fset_window_next_buffers, Fset_window_clone_number): New
659 functions.
660 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
661 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
662 Doc-string fixes.
663 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
664 Argument WINDOW can be now internal window too.
665 (Fwindow_use_time): Move up in code.
666 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
667 Rewrite doc-string.
668 (Fset_window_configuration, saved_window)
669 (Fcurrent_window_configuration, save_window_save): Handle new
670 members of window structure.
b9e809c2
MR
671 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
672 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
673 (syms_of_window): New Lisp objects Qrecord_window_buffer,
674 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
675 Qget_mru_window, Qresize_root_window,
676 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
677 Qauto_buffer_name; staticpro them.
f3d1777e 678
abde8f8c
MR
6792011-06-07 Martin Rudalics <rudalics@gmx.at>
680
681 * window.c (Fwindow_total_size, Fwindow_left_column)
682 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
683 (Fwindow_list_1): New functions.
684 (window_box_text_cols): Replace with window_body_cols.
685 (Fwindow_width, Fscroll_left, Fscroll_right): Use
686 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
687 (delete_window, Fset_window_configuration): Call
688 delete_all_subwindows with window as argument.
689 (delete_all_subwindows): Take a window as argument and not a
690 structure. Rewrite.
190b47e6
MR
691 (window_loop): Remove handling of GET_LRU_WINDOW and
692 GET_LARGEST_WINDOW.
693 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
694
695 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
696 window_box_text_cols. delete_all_subwindows now takes a
697 Lisp_Object as argument.
abde8f8c
MR
698
699 * indent.c (compute_motion, Fcompute_motion): Use
700 window_body_cols instead of window_box_text_cols.
701
fa8a67e6
MR
702 * frame.c (delete_frame): Call delete_all_subwindows with root
703 window as argument.
704
a54e3482
DC
7052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
706
707 * fns.c (Fputhash): Document return value.
708
60002bf5
CY
7092011-06-06 Chong Yidong <cyd@stupidchicken.com>
710
711 * image.c (gif_load): Implement gif89a spec "no disposal" method.
712
0c671da6 7132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 714
b862a52a 715 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 716
be44ca6c
PE
717 Check for overflow when converting integer to cons and back.
718 * charset.c (Fdefine_charset_internal, Fdecode_char):
719 Use cons_to_unsigned to catch overflow.
720 (Fencode_char): Use INTEGER_TO_CONS.
721 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
722 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
723 * data.c (long_to_cons, cons_to_long): Remove.
724 (cons_to_unsigned, cons_to_signed): New functions.
725 These signal an error for invalid or out-of-range values.
726 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
727 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
728 * font.c (Ffont_variation_glyphs):
729 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
730 * lisp.h: Include <intprops.h>.
731 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
732 (cons_to_signed, cons_to_unsigned): New decls.
733 (long_to_cons, cons_to_long): Remove decls.
734 * undo.c (record_first_change): Use INTEGER_TO_CONS.
735 (Fprimitive_undo): Use CONS_TO_INTEGER.
736 * xfns.c (Fx_window_property): Likewise.
737 * xselect.c: Include <limits.h>.
738 (x_own_selection, selection_data_to_lisp_data):
739 Use INTEGER_TO_CONS.
740 (x_handle_selection_request, x_handle_selection_clear)
741 (x_get_foreign_selection, Fx_disown_selection_internal)
742 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
743 (lisp_data_to_selection_data): Use cons_to_unsigned.
744 (x_fill_property_data): Use cons_to_signed.
745 Report values out of range.
746
d1f3d2af
PE
747 Check for buffer and string overflow more precisely.
748 * buffer.h (BUF_BYTES_MAX): New macro.
749 * lisp.h (STRING_BYTES_MAX): New macro.
750 * alloc.c (Fmake_string):
751 * character.c (string_escape_byte8):
752 * coding.c (coding_alloc_by_realloc):
753 * doprnt.c (doprnt):
754 * editfns.c (Fformat):
755 * eval.c (verror):
756 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
757 since they may not be the same number.
758 * editfns.c (Finsert_char):
759 * fileio.c (Finsert_file_contents):
760 Likewise for BUF_BYTES_MAX.
761
dd52fcea
PE
762 * image.c: Use ptrdiff_t, not int, for sizes.
763 (slurp_file): Switch from int to ptrdiff_t.
764 All uses changed.
765 (slurp_file): Check that file size fits in both size_t (for
766 malloc) and ptrdiff_t (for sanity and safety).
767
7f9bbdbb
PE
768 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
769 if b->modtime has its maximal value.
770
dfe18f82
PE
771 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
772
84acfcf0
PE
773 Don't assume time_t can fit into int.
774 * buffer.h (struct buffer.modtime): Now time_t, not int.
775 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
776 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
777
ccd9a01a
PE
778 Minor fixes for signed vs unsigned integers.
779 * character.h (MAYBE_UNIFY_CHAR):
780 * charset.c (maybe_unify_char):
781 * keyboard.c (read_char, reorder_modifiers):
782 XINT -> XFASTINT, since the integer must be nonnegative.
783 * ftfont.c (ftfont_spec_pattern):
784 * keymap.c (access_keymap, silly_event_symbol_error):
785 XUINT -> XFASTINT, since the integer must be nonnegative.
786 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
787 since it makes no difference and we prefer signed.
788 * keyboard.c (record_char): Use XUINT when all the neighbors do.
789 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
790 nonnegative.
791
d6d100dd
SM
7922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
793
794 * window.h (Fwindow_frame): Declare.
795
2b6148e4
PE
7962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
797
798 * alloc.c: Simplify handling of large-request failures (Bug#8800).
799 (SPARE_MEMORY): Always define.
800 (LARGE_REQUEST): Remove.
801 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
802
f230ecc9
MR
8032011-06-06 Martin Rudalics <rudalics@gmx.at>
804
727e958e
MR
805 * lisp.h: Move EXFUNS for Fframe_root_window,
806 Fframe_first_window and Fset_frame_selected_window to window.h.
807
808 * window.h: Move EXFUNS for Fframe_root_window,
809 Fframe_first_window and Fset_frame_selected_window here from
810 lisp.h.
811
812 * frame.c (Fwindow_frame, Fframe_first_window)
813 (Fframe_root_window, Fframe_selected_window)
814 (Fset_frame_selected_window): Move to window.c.
815 (Factive_minibuffer_window): Move to minibuf.c.
816 (Fother_visible_frames_p): New function.
817
818 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
819
f230ecc9
MR
820 * window.c (decode_window, decode_any_window): Move up in code.
821 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
822 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
823 (Fwindow_buffer): Move up and rewrite doc-string.
824 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
825 (Fwindow_prev): New functions.
727e958e
MR
826 (Fwindow_frame): Move here from frame.c. Accept any window as
827 argument.
828 (Fframe_root_window, Fframe_first_window)
829 (Fframe_selected_window): Move here from frame.c. Accept frame
830 or arbitrary window as argument. Update doc-strings.
831 (Fminibuffer_window): Move up in code.
832 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
833 (Fset_frame_selected_window): Move here from frame.c.
834 Marginal rewrite.
727e958e
MR
835 (Fselected_window, select_window, Fselect_window): Move up in
836 code. Minor doc-string fixes.
f230ecc9 837
4d09bcf6
PE
8382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
839
840 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
841 Do not assume that spare memory exists; that assumption is valid
842 only if SYSTEM_MALLOC.
843 (LARGE_REQUEST): New macro, so that the issue of large requests
844 is separated from the issue of spare memory.
845
810928a2
AS
8462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
847
172418ad
AS
848 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
849 format. (Bug#8806)
850
43f862f7
AS
851 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
852
810928a2
AS
853 * xfns.c (x_set_scroll_bar_default_width): Move declarations
854 before statements.
855
a059fe24
JD
8562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
857
858 * gtkutil.c (xg_get_default_scrollbar_width): New function.
859
860 * gtkutil.h: Declare xg_get_default_scrollbar_width.
861
862 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
863 min width by calling x_set_scroll_bar_default_width (Bug#8505).
864
989bf368
JB
8652011-06-05 Juanma Barranquero <lekktu@gmail.com>
866
867 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
868
4b80f674
CY
8692011-06-04 Chong Yidong <cyd@stupidchicken.com>
870
871 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
872 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
873 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
874 New error handlers.
4b80f674
CY
875 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
876 Obey Vx_select_enable_clipboard_manager. Catch errors in
877 x_clipboard_manager_save (Bug#8779).
878 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 879 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 880
99a33b77 8812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
882
883 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
884
99a33b77 8852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
886
887 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
888 in the current matrix if keep_current_p is non-zero.
889
8264569d
EZ
8902011-06-04 Eli Zaretskii <eliz@gnu.org>
891
892 * bidi.c (bidi_level_of_next_char): Fix last change.
893
57f97249
EZ
8942011-06-03 Eli Zaretskii <eliz@gnu.org>
895
fec2107c 896 Support bidi reordering of text covered by display properties.
57f97249 897
fec2107c
EZ
898 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
899 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
900 (bidi_cache_search, bidi_cache_iterator_state)
901 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
902 (bidi_level_of_next_char, bidi_move_to_visually_next):
903 Support character positions inside a run of characters covered by a
fec2107c
EZ
904 display string.
905 (bidi_paragraph_init, bidi_resolve_explicit_1)
906 (bidi_level_of_next_char): Call bidi_fetch_char and
907 bidi_fetch_char_advance instead of FETCH_CHAR and
908 FETCH_CHAR_ADVANCE.
909 (bidi_init_it): Initialize new members.
910 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
911 definitions.
912 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
913 instead of using explicit *_CHAR codes.
d6d100dd
SM
914 (bidi_resolve_explicit, bidi_resolve_weak):
915 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
916 bidirectional text is supported only in multibyte buffers.
917 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
918 it to initialize the frame_window_p member of struct bidi_it.
919 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
920 (bidi_resolve_explicit, bidi_resolve_weak)
921 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
922 bidi_it->nchars is non-positive.
923 (bidi_level_of_next_char): Don't try to lookup the cache for the
924 next/previous character if nothing is cached there yet, or if we
925 were just reseat()'ed to a new position.
c40e2fb2 926
0e14fe90
EZ
927 * xdisp.c (set_cursor_from_row): Set start and stop points
928 according to the row's direction when priming the loop that looks
929 for the glyph on which to display cursor.
930 (single_display_spec_intangible_p): Function deleted.
931 (display_prop_intangible_p): Reimplement to call
932 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
933 Accept 3 additional arguments needed by handle_display_spec.
934 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
935 values: lists, `(when COND...)' forms, etc.
936 (single_display_spec_string_p): Support property values that are
937 lists with the argument STRING its top-level element.
938 (display_prop_string_p): Fix the condition for processing a
939 property that is a list to be consistent with handle_display_spec.
fec2107c 940 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
941 last portion of handle_display_prop.
942 (compute_display_string_pos): Accept additional argument
943 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
944 value of a `display' property is a "replacing spec".
945 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
946 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
947 the display property, but just return a value indicating whether
948 the display property will replace the characters it covers.
949 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
950 frame_window_p members of struct bidi_it.
d6d100dd
SM
951 (compute_display_string_pos, compute_display_string_end):
952 New functions.
fec2107c
EZ
953 (push_it): Accept second argument POSITION, where pop_it should
954 jump to continue iteration.
955 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 956
fec2107c
EZ
957 * keyboard.c (adjust_point_for_property): Adjust the call to
958 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
959
960 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
961 (bidi_init_it): Update prototypes.
962 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
963 (compute_display_string_pos, compute_display_string_end):
964 Declare prototypes.
fec2107c
EZ
965 (struct bidi_it): New members nchars and disp_pos. ch_len is now
966 EMACS_INT.
fc6f18ce 967
40087514 9682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 969
57f53182
PE
970 Malloc failure behavior now depends on size of allocation.
971 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
972 * lisp.h: Change signatures accordingly.
973 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
974 All callers changed. (Bug#8762)
975
976 * gnutls.c: Use Emacs's memory allocators.
977 Without this change, the gnutls library would invoke malloc etc.
978 directly, which causes problems on non-SYNC_INPUT hosts, and which
979 runs afoul of improving memory_full behavior. (Bug#8761)
980 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
981 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
982 xfree instead of the default malloc, realloc, free.
983 (Fgnutls_boot): No need to check for memory allocation failure,
984 since xmalloc does that for us.
985
ac32cd99 986 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
987 * category.c (hash_get_category_set):
988 * ccl.c (ccl_driver):
989 * charset.c (Fdefine_charset_internal):
990 * charset.h (struct charset.hash_index):
991 * composite.c (get_composition_id, gstring_lookup_cache)
992 (composition_gstring_put_cache):
993 * composite.h (struct composition.hash_index):
994 * dispextern.h (struct image.hash):
995 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
996 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
997 (hashfn_equal, hashfn_user_defined, make_hash_table)
998 (maybe_resize_hash_table, hash_lookup, hash_put)
999 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1000 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1001 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1002 * image.c (make_image, search_image_cache, lookup_image)
1003 (xpm_put_color_table_h):
1004 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1005 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1006 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1007 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1008 * alloc.c (allocate_vectorlike):
1009 Check for overflow in vector size calculations.
1010 * ccl.c (ccl_driver):
1011 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1012 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1013 need to be updated by these changes.
40087514
PE
1014 * fns.c (make_hash_table, maybe_resize_hash_table):
1015 Check for integer overflow with large hash tables.
0de4bb68
PE
1016 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1017 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1018 (SXHASH_REDUCE): New macro.
1019 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1020 Use it instead of discarding useful hash info with large hash values.
1021 (sxhash_float): New function.
1022 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1023 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1024 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1025 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1026 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1027 Adjust signatures to match updated version of code.
1028 (consing_since_gc): Now EMACS_INT, since a single hash table can
1029 use more than INT_MAX bytes.
1030
698d32e2
DN
10312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1032
1033 Make it possible to build with GCC-4.6+ -O2 -flto.
1034
1035 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1036
fd6fa53f
SM
10372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1038
1039 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1040 Call minibuffer-inactive-mode.
1041
864db017
JB
10422011-05-31 Juanma Barranquero <lekktu@gmail.com>
1043
1044 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1045 Update dependencies.
1046
2ad0baf4
DN
10472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1048
1049 * data.c (init_data): Remove code for UTS, this system is not
1050 supported anymore.
1051
4fcc2638
DN
10522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1053
1054 Don't force ./temacs to start in terminal mode.
1055
1056 * frame.c (make_initial_frame): Initialize faces in all cases, not
1057 only when CANNOT_DUMP is defined.
1058 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1059
c56e0fd5
DN
10602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1061
1062 * dispnew.c (add_window_display_history): Use const for the string
1063 pointer. Remove declaration, not needed.
1064
333d54da 10652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1066
55d4c1b2 1067 Use 'inline', not 'INLINE'.
333d54da 1068 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1069 * alloc.c, fontset.c (INLINE): Remove.
1070 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1071 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1072 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1073 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1074 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1075
738db178
DN
10762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1077
1078 Make it possible to run ./temacs.
1079
1080 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1081 syms_of_callproc does the same thing. Remove test for
1082 "initialized", do it in the caller.
1083 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1084
620c53a6
SM
10852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1086
1087 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1088 (read_minibuf): Use get_minibuffer.
1089 (syms_of_minibuf): Use DEFSYM.
1090 (Qmetadata): New var.
1091 * data.c (Qbuffer): Don't make it static.
1092 (syms_of_data): Use DEFSYM.
1093
e003a292
PE
10942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1097 (CCL_CODE_MIN): New macro.
1098
ed008a6d
PE
10992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1100
3687c2ef
PE
1101 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1102
ed008a6d
PE
1103 * eval.c (Qdebug): Now static.
1104 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1105 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1106 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1107
d66c4c7c
CY
11082011-05-29 Chong Yidong <cyd@stupidchicken.com>
1109
1110 * image.c: Various fixes to ImageMagick code comments.
1111 (Fimagemagick_types): Doc fix.
1112
5fbc2025
PE
11132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1114
0196f88a
PE
1115 Minor fixes prompted by GCC 4.6.0 warnings.
1116
1117 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1118
5fbc2025
PE
1119 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1120 (x_clipboard_manager_save_all): Move extern decl to ...
1121 * xterm.h: ... here, so that it can be checked for consistency.
1122
1dd3c2d9
CY
11232011-05-29 Chong Yidong <cyd@stupidchicken.com>
1124
1125 * xselect.c (x_clipboard_manager_save_frame)
1126 (x_clipboard_manager_save_all): New functions.
1127 (Fx_clipboard_manager_save): Lisp function deleted.
1128
1129 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1130 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1131
1132 * xterm.h: Update prototype.
1133
5ba6571d
WX
11342011-05-28 William Xu <william.xwl@gmail.com>
1135
1136 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1137 exiting (Bug#8239).
1138
3eaff834
JM
11392011-05-28 Jim Meyering <meyering@redhat.com>
1140
e1900994 1141 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1142 * fns.c (to_uchar): Define.
1143 (crypto_hash_function): Use it to convert some newly-signed
1144 variables to unsigned, to avoid sign-extension bugs. For example,
1145 without this change, (md5 "truc") would evaluate to
1146 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1147 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1148 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1149
0f6990a7
PE
11502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 Integer overflow fixes.
c8a9ca5a 1153
08686060
PE
1154 * dbusbind.c: Serial number integer overflow fixes.
1155 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1156 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1157 to hold a serial number that is too large for a fixnum.
1158 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1159 Check for serial numbers out of range. Decode any serial number
59568bf0 1160 that was so large that it became a float. (Bug#8722)
08686060 1161
2d1fc3c7
PE
1162 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1163 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1164 Use XFASTINT rather than XUINT when numbers are nonnegative.
1165 (xd_append_arg, Fdbus_method_return_internal):
1166 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1167 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1168 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1169 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1170 (Bug#8722)
2d1fc3c7 1171
c8a9ca5a
PE
1172 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1173
519e1d69
PE
1174 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1175
30569699
PE
1176 ccl: add integer overflow checks
1177 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1178 (IN_INT_RANGE): New macros.
1179 (ccl_driver): Use them to check for integer overflow when
1180 decoding a CCL program. Many of the new checks are whether XINT (x)
1181 fits in int; it doesn't always, on 64-bit hosts. The new version
1182 doesn't catch all possible integer overflows, but it's an
847044ea 1183 improvement. (Bug#8719)
30569699 1184
c11285dc
PE
1185 * alloc.c (make_event_array): Use XINT, not XUINT.
1186 There's no need for unsigned here.
1187
fdccd48e
PE
1188 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1189 This follows up to the 2011-05-06 change that substituted uintptr_t
1190 for EMACS_INT. This case wasn't caught back then.
1191
37910ab2
PE
1192 Rework Fformat to avoid integer overflow issues.
1193 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1194 now (part of C89). Include <verify.h>.
1195 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1196 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1197 (Fformat): Avoid the prepass trying to compute sizes; it was only
1198 approximate and thus did not catch overflow reliably. Instead, walk
1199 through the format just once, formatting and computing sizes as we go,
1200 checking for integer overflow at every step, and allocating a larger
1201 buffer as needed. Keep track separately whether the format is
1202 multibyte. Keep only the most-recently calculated precision, rather
1203 than them all. Record whether each argument has been converted to
1204 string. Use EMACS_INT, not int, for byte and char and arg counts.
1205 Support field widths and precisions larger than INT_MAX. Avoid
1206 sprintf's undefined behavior with conversion specifications such as %#d
1207 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1208 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1209 formatting out-of-range floating point numbers with int
1210 formats. (Bug#8668)
1211
2e6578fb
PE
1212 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1213
0ae6bdee
PE
1214 * data.c: Avoid integer truncation in expressions involving floats.
1215 * data.c: Include <intprops.h>.
1216 (arith_driver): When there's an integer overflow in an expression
1217 involving floating point, convert the integers to floating point
1218 so that the resulting value does not suffer from catastrophic
1219 integer truncation. For example, on a 64-bit host (* 4
1220 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1221 Do not rely on undefined behavior after integer overflow.
1222
de883a70
PE
1223 merge count_size_as_multibyte, parse_str_to_multibyte
1224 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1225 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1226 Check for integer overflow.
1227 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1228 since it's now a duplicate of the other. This is more of
1229 a character than a buffer op, so better that it's in character.c.
1230 * fns.c, print.c: Adjust to above changes.
1231
2ff916cb
PE
12322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1233
1234 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1235
f1b54466
PE
12362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1237
fb1ac845
PE
1238 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1239 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1240 (x_clipboard_manager_save): Now static.
1241 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1242
f1b54466
PE
1243 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1244 (crypto_hash_function): Now static.
1245 Fix pointer signedness problems. Avoid unnecessary initializations.
1246
a9f737ee
CY
12472011-05-27 Chong Yidong <cyd@stupidchicken.com>
1248
1249 * termhooks.h (Vselection_alist): Make it terminal-local.
1250
1251 * terminal.c (create_terminal): Initialize it.
1252
1253 * xselect.c: Support for clipboard managers.
1254 (Vselection_alist): Move to termhooks.h as terminal-local var.
1255 (LOCAL_SELECTION): New macro.
1256 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1257 (symbol_to_x_atom): Remove gratuitous arg.
1258 (x_handle_selection_request, lisp_data_to_selection_data)
1259 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1260 (x_own_selection, x_get_local_selection, x_convert_selection):
1261 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1262 (some_frame_on_display): Delete unused function.
1263 (Fx_own_selection_internal, Fx_get_selection_internal)
1264 (Fx_disown_selection_internal, Fx_selection_owner_p)
1265 (Fx_selection_exists_p): New optional frame arg.
1266 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1267 (x_handle_selection_clear): Don't treat other terminals with the
1268 same keyboard specially. Use the terminal-local Vselection_alist.
1269 (x_clear_frame_selections): Use Frun_hook_with_args.
1270
1271 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1272
1273 * xterm.h: Add support for those atoms.
1274
e067f0c1
CY
12752011-05-26 Chong Yidong <cyd@stupidchicken.com>
1276
1277 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1278 (converted_selections, conversion_fail_tag): New global variables.
1279 (x_selection_request_lisp_error): Free the above.
1280 (x_get_local_selection): Remove unnecessary code.
1281 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1282 of converted selections stored in converted_selections.
1283 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1284 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1285 (x_convert_selection): New function.
1286 (x_handle_selection_event): Simplify.
1287 (x_get_foreign_selection): Don't ignore incoming requests while
1288 waiting for an answer; this will fail when we implement
1289 SAVE_TARGETS, and seems unnecessary anyway.
1290 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1291 (Vx_sent_selection_functions): Doc fix.
1292
0f4aebc0
LL
12932011-05-26 Leo Liu <sdl.web@gmail.com>
1294
1295 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1296
e61124cd
YM
12972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1298
1299 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1300
1301 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1302 for fringe update if it has periodic bitmap.
1303 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1304 and fringe_bitmap_periodic_p.
1305
1306 * fringe.c (get_fringe_bitmap_data): New function.
1307 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1308 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1309 row. Mark glyph row for fringe update if periodicity changed.
1310
1311 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1312 for fringe update unless it has periodic bitmap.
1313
f16d9837
KH
13142011-05-25 Kenichi Handa <handa@m17n.org>
1315
1316 * xdisp.c (get_next_display_element): Set correct it->face_id for
1317 a static composition.
1318
e1b90ef6
LL
13192011-05-24 Leo Liu <sdl.web@gmail.com>
1320
1321 * deps.mk (fns.o):
1322 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1323
1324 * fns.c (crypto_hash_function, Fsha1): New function.
1325 (Fmd5): Use crypto_hash_function.
1326 (syms_of_fns): Add Ssha1.
1327
7400048f
PE
13282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 * gnutls.c: Remove unused macros.
1331 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1332 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1333 Remove macros that are defined and never used.
1334 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1335
abb71cf4
CY
13362011-05-22 Chong Yidong <cyd@stupidchicken.com>
1337
1338 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1339 (Fx_get_selection_internal): Minor cleanup.
1340 (Fx_own_selection_internal): Rename arguments for consistency with
1341 select.el.
1342
6307db39
PE
13432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1346
f3d4e0a4
CY
13472011-05-22 Chong Yidong <cyd@stupidchicken.com>
1348
1349 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1350
4d8ade89
YM
13512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1352
1353 * dispnew.c (scrolling_window): Don't exclude the case that the
1354 last enabled row in the desired matrix touches the bottom boundary.
1355
32078c8d
GM
13562011-05-21 Glenn Morris <rgm@gnu.org>
1357
1358 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1359 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1360 and add some more files.
32078c8d 1361
7285dc67
EZ
13622011-05-20 Eli Zaretskii <eliz@gnu.org>
1363
1364 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1365 report_file_error introduced by the change from 2011-05-07.
1366
89d1bd22
PE
13672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1368
1369 * systime.h (Time): Define only if emacs is defined.
1370 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1371 where the include path doesn't have X11/X.h by default. See
1372 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1373
e23640bb 13742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1375
1376 * composite.c (find_automatic_composition): Fix previous change.
1377
b9704ad9
GM
13782011-05-20 Glenn Morris <rgm@gnu.org>
1379
1380 * lisp.mk: New file, split from Makefile.in.
1381 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1382 (shortlisp): Remove.
1383 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1384
4a720484
GM
13852011-05-19 Glenn Morris <rgm@gnu.org>
1386
1387 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1388 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1389 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1390 (lisp): Set the order to that of loadup.el.
1391 (shortlisp): Make it a copy of $lisp.
1392 (SOME_MACHINE_LISP): Remove.
1393 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1394 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1395
a28d4396
KH
13962011-05-18 Kenichi Handa <handa@m17n.org>
1397
1398 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1399 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1400 (find_automatic_composition): Mostly rewrite for efficiency.
1401
a2b1fa8e
JB
14022011-05-18 Juanma Barranquero <lekktu@gmail.com>
1403
1404 * makefile.w32-in: Update dependencies.
1405
8e1f5610
CS
14062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1407
1408 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1409 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1410
7025ee00 14112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1412
cdfa6eab
PE
1413 Fix some integer overflow issues, such as string length overflow.
1414
06d6db33
PE
1415 * insdel.c (count_size_as_multibyte): Check for string overflow.
1416
2b4560a8
PE
1417 * character.c (lisp_string_width): Check for string overflow.
1418 Use EMACS_INT, not int, for string indexes and lengths; in
1419 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1420 the resulting string length overflows an EMACS_INT; instead,
1421 report a string overflow if no precision given. When checking for
1422 precision exhaustion, use a check that cannot possibly have
1423 integer overflow. (Bug#8675)
1424 * character.h (lisp_string_width): Adjust to new signature.
1425
cb93f9be
PE
1426 * alloc.c (string_overflow): New function.
1427 (Fmake_string): Use it. This doesn't change behavior, but saves
1428 a few bytes and will simplify future changes.
1429 * character.c (string_escape_byte8): Likewise.
1430 * lisp.h (string_overflow): New decl.
1431
1a1f3366
PE
1432 Fixups, following up to the user-interface timestamp change.
1433 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1434 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1435 * msdos.c (mouse_get_pos): Likewise.
1436 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1437 * w32gui.h (Time): Define by including "systime.h" rather than by
1438 declaring it ourselves. (Bug#8664)
1439
d4e3e4d3
PE
1440 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1441 * image.c (clear_image_cache): Likewise.
1442
f6a24d19
PE
1443 * term.c (term_mouse_position): Don't assume time_t wraparound.
1444
08dc5ae6
PE
1445 Be more systematic about user-interface timestamps.
1446 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1447 and sometimes 'EMACS_UINT', to represent these timestamps.
1448 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1449 This makes the code easier to follow, and makes it easier to catch
1450 integer overflow bugs such as Bug#8664.
1451 * frame.c (Fmouse_position, Fmouse_pixel_position):
1452 Use Time, not unsigned long, for user-interface timestamps.
1453 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1454 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1455 * keyboard.h (last_event_timestamp): Likewise.
1456 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1457 * menu.h (xmenu_show): Likewise.
1458 * term.c (term_mouse_position): Likewise.
1459 * termhooks.h (struct input_event.timestamp): Likewise.
1460 (struct terminal.mouse_position_hook): Likewise.
1461 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1462 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1463 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1464 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1465 what it was before.
1466 * menu.h, termhooks.h: Include "systime.h", for Time.
1467
8e55734a
PE
1468 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1469 Don't assume that the difference between two unsigned long values
1470 can fit into an integer. At this point, we know button_down_time
1471 <= event->timestamp, so the difference must be nonnegative, so
1472 there's no need to cast the result if double-click-time is
1473 nonnegative, as it should be; check that it's nonnegative, just in
1474 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1475 apart (about 25 days). (Bug#8664)
8e55734a 1476
841f1b75 1477 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1478 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1479
3e26f69c
PE
1480 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1481 that always fit in int. Use a sentinel instead of a counter, to
1482 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1483 * frame.h (struct frame): Use int for menu_bar_items_used
1484 instead of EMACS_INT, since it always fits in int.
3e26f69c 1485
5cc152c0
PE
1486 * menu.c (grow_menu_items): Check for int overflow.
1487
d89eb65e
PE
1488 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1489
5235bd3e
PE
1490 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1491 Before, the code was not consistent. These values cannot exceed
1492 2**31 - 1 so there's no need to make them unsigned.
1493 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1494 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1495 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1496 as modifiers.
1497 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1498
bc827e23
PE
1499 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1500 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1501 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1502 presumably because the widths might not match.
1503
78eb494e
PE
1504 * window.c (size_window): Avoid needless test at loop start.
1505
04f2d78b
CB
15062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1507
1508 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1509
d2fc7e3d 15102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1511
1512 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1513
d2fc7e3d 15142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1515
1516 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1517 `width' to `bar_area_x' and `bar_area_width', respectively.
1518 (x_scroll_run): Take account of fringe background extension.
1519
04f2d78b
CB
1520 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1521 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1522 `bar_area_width', respectively.
1523 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1524 background extension.
1525
79b70037
GM
15262011-05-10 Jim Meyering <meyering@redhat.com>
1527
1528 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1529
2f142cc5
JB
15302011-05-10 Juanma Barranquero <lekktu@gmail.com>
1531
1532 * image.c (Finit_image_library): Return t for built-in image types,
1533 like pbm and xbm. (Bug#8640)
1534
57679c86
AS
15352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1536
1537 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1538
888c9e86
EZ
15392011-05-07 Eli Zaretskii <eliz@gnu.org>
1540
b0512a1d
EZ
1541 * w32console.c (Fset_screen_color): Doc fix.
1542 (Fget_screen_color): New function.
1543 (syms_of_ntterm): Defsubr it.
1544
7285dc67
EZ
1545 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1546 unlink the temporary file if Fcall_process didn't create it in the
1547 first place.
1548 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1549 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1550 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1551 cue to call_process_cleanup not to close that handle.
1552
4d3fcc8e
BK
15532011-05-07 Ben Key <bkey76@gmail.com>
1554
1555 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1556 one of two shell specific rules, either bootstrap-temacs-CMD or
1557 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1558 to the previous implementation of the bootstrap-temacs rule.
1559 The bootstrap-temacs-CMD rule is similar to the previous
1560 implementation of the bootstrap-temacs rule except that it
1561 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1562 variable.
1563
1564 These changes, along with some changes to nt/configure.bat,
1565 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1566 earlier fix to add support for --cflags and --ldflags options
1567 that include quotes so that it works whether make uses cmd or
1568 sh as the shell.
1569
b4289b64
MA
15702011-05-06 Michael Albinus <michael.albinus@gmx.de>
1571
1572 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1573 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1574 is a constant.
1575 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1576 a string. Handle both cases.
1577 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1578 (Fdbus_register_method): Use Qinvalid_function.
1579
af4c0e28
JB
15802011-05-06 Juanma Barranquero <lekktu@gmail.com>
1581
1582 * makefile.w32-in: Update dependencies.
1583 (LISP_H): Add inttypes.h and stdin.h.
1584 (PROCESS_H): Add unistd.h.
1585
c51453d9
EZ
15862011-05-06 Eli Zaretskii <eliz@gnu.org>
1587
1588 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1589 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1590
8ff0ac3c 15912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1592
4c4b566b
PE
1593 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1594
aab2b9b5
PE
1595 * term.c (vfatal): Remove stray call to va_end.
1596 It's not needed and the C Standard doesn't allow it here anyway.
1597
c378da0b
PE
1598 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1599 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1600
288b08c7
PE
1601 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1602 bytes.
1603
e3601888
PE
1604 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1605
db6c0e74
PE
1606 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1607
dd5963ea
PE
1608 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1609
88c9450f
PE
1610 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1611
2f9442b8
PE
1612 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1613
c032b5f8
PE
1614 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1615 * charset.c (Fdefine_charset_internal): Don't initialize
1616 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1617 32-bit int (Bug#8600).
a108c10b
PE
1618
1619 * lread.c (read_integer): Be more consistent with string-to-number.
1620 Use string_to_number to do the actual conversion; this avoids
1621 rounding errors and fixes some other screwups. Without this fix,
1622 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1623 (digit_to_number): Move earlier, for benefit of read_integer.
1624 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1625 not a digit in any supported base. (Bug#8602)
a108c10b 1626
ad5f9eea
PE
1627 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1628
aec1708a
PE
1629 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1630 to match comment at start of function. This also removes a
1631 GCC warning about overflow in a 32+64-bit port.
1632
47be4ab5
PE
1633 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1634
371cac43
PE
1635 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1636 Reported by Stefan Monnier in
1637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1638 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1639 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1640
d01a7826
PE
1641 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1642 (EMACS_UINTPTR): Likewise, with uintptr_t.
1643
7fd47d5c
PE
1644 * lisp.h: Prefer 64-bit EMACS_INT if available.
1645 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1646 on 32-bit hosts that have 64-bit int, so that they can access
1647 large files.
122b0c86
PE
1648 However, temporarily disable this change unless the temporary
1649 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1650
8727937b
PE
1651 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1652
8ac068ac
PE
1653 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1654 This removes an assumption that EMACS_INT and long are the same
1655 width as pointers. The assumption is true for Emacs porting targets
1656 now, but we want to make other targets possible.
1657 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1658 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1659 In the rest of the code, change types of integers that hold casted
1660 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1661 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1662 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1663 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1664 No need to cast type when ORing.
1665 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1666 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1667 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1668 assume EMACS_INT is the same width as char *.
1669 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1670 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1671 Remove no-longer-needed casts.
1672 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1673 (xg_tool_bar_help_callback, xg_make_tool_item):
1674 Use EMACS_INTPTR to hold an integer
1675 that will be cast to void *; this can avoid a GCC warning
1676 if EMACS_INT is not the same width as void *.
1677 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1678 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1679 (current_message_1, set_message_1):
1680 Use a local to convert to proper width without a cast.
1681 * xmenu.c (dialog_selection_callback): Likewise.
1682
ede49d71
PE
1683 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1684 Also, don't assume VALBITS / RAND_BITS is less than 5,
1685 and don't rely on undefined behavior when shifting a 1 left into
1686 the sign bit.
1687 * lisp.h (get_random): Change signature to match.
1688
2f30ecd0
PE
1689 * lread.c (hash_string): Use size_t, not int, for hash computation.
1690 Normally we prefer signed values; but hashing is special, because
1691 it's better to use unsigned division on hash table sizes so that
1692 the remainder is nonnegative. Also, size_t is the natural width
1693 for hashing into memory. The previous code used 'int', which doesn't
1694 retain enough info to hash well into very large tables.
1695 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1696
2a866e7b
PE
1697 * dbusbind.c: Don't possibly lose pointer info when converting.
1698 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1699 Use XPNTR rather than XHASH, so that the high-order bits of
1700 the pointer aren't lost when converting through void *.
1701
51639eac
PE
1702 * eval.c (Fautoload): Don't double-shift a pointer.
1703
92394119
PE
1704 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1705
dbdb9a7c
JB
17062011-05-06 Juanma Barranquero <lekktu@gmail.com>
1707
1708 * gnutls.c (DEF_GNUTLS_FN):
1709 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1710
db7a0b4f
AS
17112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1712
1713 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1714 marker. (Bug#8610)
1715
f7ff1b0f 17162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1717
1718 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1719 New version that can reserve upto 2GB of heap space.
1720
f7ff1b0f 17212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1722
1723 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1724
639c109b
TZ
17252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1726
1727 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1728 `gnutls_certificate_set_x509_key_file'.
1729
d2127135
JB
17302011-05-05 Juanma Barranquero <lekktu@gmail.com>
1731
1732 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1733 Update dependencies.
1734
e968f4f3
JB
17352011-05-04 Juanma Barranquero <lekktu@gmail.com>
1736
1737 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1738 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1739 Remove unused parameter `fildes'.
1740 * process.c (read_process_output, send_process): Don't pass it.
1741
84d358f0
JB
17422011-05-04 Juanma Barranquero <lekktu@gmail.com>
1743
1744 Fix previous change: the library cache is defined in w32.c.
1745 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1746 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1747
0898ca10
JB
17482011-05-04 Juanma Barranquero <lekktu@gmail.com>
1749
1750 Implement dynamic loading of GnuTLS on Windows.
1751
1752 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1753 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1754 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1755 Declare.
1756
1757 * gnutls.c (Qgnutls_dll): Define.
1758 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1759 (gnutls_*): Declare function pointers.
1760 (init_gnutls_functions): New function to initialize function pointers.
1761 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1762 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1763 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1764 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1765 (emacs_gnutls_write, emacs_gnutls_read)
1766 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1767 (Fgnutls_available_p): New function.
1768 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1769 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1770 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1771
1772 * image.c: Include w32.h.
1773 (Vimage_type_cache): Delete.
1774 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1775 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1776 (w32_delayed_load): Move to w32.c.
1777
1778 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1779
1780 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1781 (w32_delayed_load): Move from image.c. When loading a library, record
1782 its filename in the :loaded-from property of the library id.
1783 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1784 Initialize and staticpro them.
1785 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1786
1787 * process.c: Include lisp.h before w32.h, not after.
1788 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1789 instead of gnutls_record_check_pending.
1790
1791 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1792
ff4de4aa
TZ
17932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1794
1795 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1796 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1797 as passed in.
1798
abe95abb
JD
17992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1800
1801 * xterm.c (x_set_frame_alpha): Do not set property on anything
1802 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1803
e16e55d4
JB
18042011-05-02 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1807
bafcf6a5
JB
18082011-05-02 Juanma Barranquero <lekktu@gmail.com>
1809
1810 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1811 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1812 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1813 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1814 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1815 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1816 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1817 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1818 (Qgnutls_bootprop_callbacks_verify): Make static.
1819
e7a6747f
AS
18202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1821
19ed11ba
AS
1822 * callproc.c: Indentation fixup.
1823
e7a6747f 1824 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1825 (wait_for_termination, interruptible_wait_for_termination):
1826 Move after wait_for_termination_1.
e7a6747f 1827
1ef14cb4
LMI
18282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1829
1830 * sysdep.c (interruptible_wait_for_termination): New function
1831 which is like wait_for_termination, but allows keyboard
1832 interruptions.
1833
1834 * callproc.c (Fcall_process): Add (:file "file") as an option for
1835 the STDOUT buffer.
1836 (Fcall_process_region): Ditto.
1837
330d880c
EZ
18382011-04-30 Eli Zaretskii <eliz@gnu.org>
1839
8db90b73
EZ
1840 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1841 rather than `XVECTOR (FOO)->size'.
1842
330d880c
EZ
1843 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1844 inttypes.h, as a gnulib replacement is used if it not available in
1845 system headers.
1846
15cbd324
EZ
18472011-04-21 Eli Zaretskii <eliz@gnu.org>
1848
1849 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1850 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1851 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1852
1853 * coding.c (coding_alloc_by_realloc): Error out if destination
1854 will grow beyond MOST_POSITIVE_FIXNUM.
1855 (decode_coding_emacs_mule): Abort if there isn't enough place in
1856 charbuf for the composition carryover bytes. Reserve an extra
1857 space for up to 2 characters produced in a loop.
1858 (decode_coding_iso_2022): Abort if there isn't enough place in
1859 charbuf for the composition carryover bytes.
1860
18612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1862
ae940cca
EZ
1863 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1864 aborting when %lld or %lll format is passed.
1865 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1866 %llo or %llx format is passed. (Bug#8545)
1867
03ab8921
EZ
1868 * window.c (window_scroll_line_based): Use a marker instead of
1869 simple variables to record original value of point. (Bug#7952)
1870
afda1437
EZ
1871 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1872 produced by %s or %c overflows available buffer space. (Bug#8545)
1873
f76dee0c
PE
18742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1875
1876 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1877 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1878
fdc5744d
JB
18792011-04-28 Juanma Barranquero <lekktu@gmail.com>
1880
1881 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1882
638f053a
JB
18832011-04-28 Juanma Barranquero <lekktu@gmail.com>
1884
1885 * keyboard.c (Qdelayed_warnings_hook): Define.
1886 (command_loop_1): Run `delayed-warnings-hook'
1887 if Vdelayed_warnings_list is non-nil.
1888 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1889 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1890
d178f871
EZ
18912011-04-28 Eli Zaretskii <eliz@gnu.org>
1892
1893 * doprnt.c (doprnt): Don't return value smaller than the buffer
1894 size if the message was truncated. (Bug#8545).
1895
b124fd93
JB
18962011-04-28 Juanma Barranquero <lekktu@gmail.com>
1897
1898 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1899 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1900
e810457d
PE
19012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1904
ea51cceb
JB
19052011-04-27 Juanma Barranquero <lekktu@gmail.com>
1906
1907 * makefile.w32-in: Update dependencies.
1908
94dcfacf
EZ
19092011-04-27 Eli Zaretskii <eliz@gnu.org>
1910
1911 Improve `doprnt' and its usage. (Bug#8545)
1912 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1913 `format_end'. Remove support for %l as a conversion specifier.
1914 Don't use xrealloc. Improve diagnostics when the %l size modifier
1915 is used. Update the commentary.
1916
1917 * eval.c (verror): Simplify calculation of size_t.
1918
1919 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1920 messages.
1921
f61f41d7
PE
19222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1923
1924 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1925 change.
1926
96fb4434
PE
19272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1930 This makes this file independent of the recent pseudovector change.
1931
671875da 19322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1933
69e9b5a3
PE
1934 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1935
b5f869a7 1936 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1937 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1938 Remove unused local.
c8926152 1939 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1940
841a1577 1941 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1942 GCC 4.6.0 optimizes based on type-based alias analysis.
1943 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1944 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1945 != &v->size, and therefore "v->size = 1; b->size = 2; return
1946 v->size;" must therefore return 1. This assumption is incorrect
1947 for Emacs, since it type-puns struct Lisp_Vector * with many other
1948 types. To fix this problem, this patch adds a new type struct
f904488f 1949 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1950 and pseudovectors, and helps optimizing compilers not get fooled
1951 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1952 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1953 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1954 the size member.
eab3844f
PE
1955 (XSETPVECTYPE): Rewrite in terms of new macro.
1956 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1957 This is a bit clearer, and further avoids the possibility of
1958 undesirable aliasing.
1959 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1960 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1961 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1962 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1963 (ASIZE): Now uses header.size rather than size.
1964 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1965 to avoid the hassle of writing XVECTOR (foo)->header.size.
1966 (struct vectorlike_header): New type.
eab3844f
PE
1967 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1968 object, to help avoid aliasing.
1969 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1970 (SUBRP): Likewise, since Lisp_Subr is a special case.
1971 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1972 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1973 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1974 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1975 changed to be "header.size" and "header.next".
1976 * buffer.h (struct buffer): Likewise.
1977 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1978 * frame.h (struct frame): Likewise.
1979 * process.h (struct Lisp_Process): Likewise.
1980 * termhooks.h (struct terminal): Likewise.
1981 * window.c (struct save_window_data, struct saved_window): Likewise.
1982 * window.h (struct window): Likewise.
1983 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1984 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1985 * buffer.c (init_buffer_once): Likewise.
1986 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1987 special case.
1988 * process.c (Fformat_network_address): Use local var for size,
1989 for brevity.
1990
0df1eac5
PE
1991 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1992
847ab9d1 1993 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1994 * data.c (atof): Remove decl; no longer used or needed.
1995 (digit_to_number): Move to lread.c.
1996 (Fstring_to_number): Use new string_to_number function, to be
1997 consistent with how the Lisp reader treats infinities and NaNs.
1998 Do not assume that floating-point numbers represent EMACS_INT
1999 without losing information; this is not true on most 64-bit hosts.
2000 Avoid double-rounding errors, by insisting on integers when
2001 parsing non-base-10 numbers, as the documentation specifies.
2002 * lisp.h (string_to_number): New decl, replacing ...
2003 (isfloat_string): Remove.
bc0a5c13 2004 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2005 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2006 appears to have been a coding error. Similarly, do not accept
2007 strings like +-1e0 as floating point numbers. Do not report
2008 overflow for integer overflows unless the base is not 10 which
2009 means we have no simple and reliable way to continue.
2010 Break out the floating-point parsing into a new
2011 function string_to_number, so that Fstring_to_number parses
2012 floating point numbers consistently with the Lisp reader.
04f2d78b 2013 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2014 (E_CHAR, EXP_INT): Remove, replacing with ...
2015 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2016 (string_to_number): New function, replacing isfloat_string.
2017 This function checks for valid syntax and produces the resulting
2018 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2019 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2020 so that overflow for non-base-10 numbers is reported only when
2021 there's no portable and simple way to convert to floating point.
452f4150 2022
67769ffc
PE
2023 * textprop.c (set_text_properties_1): Rewrite for clarity,
2024 and to avoid GCC warning about integer overflow.
2025
c20db43f
PE
2026 * intervals.h (struct interval): Use EMACS_INT for members
2027 where EMACS_UINT might cause problems. See
2028 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2029 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2030 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2031 All uses changed.
37aa2f85
PE
2032 (offset_intervals): Tell GCC not to worry about length overflow
2033 when negating a negative length.
c20db43f 2034
2538aa2f
PE
2035 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2036 (overrun_check_free): Likewise.
2037
f2d3008d
PE
2038 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2039 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2040 word size.
2041
ec8df744
PE
2042 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2043 (gnutls_make_error): Rename local to avoid shadowing.
2044 (gnutls_emacs_global_deinit): ifdef out; not used.
2045 (Fgnutls_boot): Use const for pointer to readonly storage.
2046 Comment out unused local. Fix pointer signedness problems.
2047
640ee02d
PE
2048 * lread.c (openp): Don't stuff size_t into an 'int'.
2049 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2050 about possible signed overflow.
2051
6048fb2a
PE
2052 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2053 (GDK_KEY_g): Don't define if already defined.
2054 (xg_prepare_tooltip): Avoid pointer signedness problem.
2055 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2056
fa3c87e1
PE
2057 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2058 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2059
2172544b
PE
2060 * xfns.c (Fx_window_property): Simplify a bit,
2061 to make a bit faster and to avoid GCC 4.6.0 warning.
2062 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2063
9b821a21
PE
2064 * fns.c (internal_equal): Don't assume size_t fits in int.
2065
3c616cfa
PE
2066 * alloc.c (compact_small_strings): Tighten assertion a little.
2067
c2982e87
PE
2068 Replace pEd with more-general pI, and fix some printf arg casts.
2069 * lisp.h (pI): New macro, generalizing old pEd macro to other
2070 conversion specifiers. For example, use "...%"pI"d..." rather
2071 than "...%"pEd"...".
2072 (pEd): Remove. All uses replaced with similar uses of pI.
2073 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2074 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2075 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2076 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2077 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2078 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2079 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2080 64-bit hosts.
2081 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2082 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2083 * print.c (safe_debug_print, print_object): Likewise.
2084 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2085 to int.
6f04d126
PE
2086 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2087 avoiding the 0 flag, which is not portable.
c2982e87
PE
2088 * process.c (Fmake_network_process): Use pI to avoid cast.
2089 * region-cache.c (pp_cache): Likewise.
2090 * xdisp.c (decode_mode_spec): Likewise.
2091 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2092 behavior on 64-bit hosts with printf arg.
6f04d126 2093 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2094 (x_stop_queuing_selection_requests): Likewise.
2095 (x_get_window_property): Don't truncate byte count to an 'int'
2096 when tracing.
0b432f21 2097
5e073ec7
PE
2098 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2099 here, since it parses constructs like leading '-' and spaces,
2100 which are not wanted; and it overflows with large numbers.
2101 Instead, simply match F[0-9]+, which is what is wanted anyway.
2102
36372bf9
PE
2103 * alloc.c: Remove unportable assumptions about struct layout.
2104 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2105 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2106 (allocate_vectorlike, make_pure_vector): Use the new macros,
2107 plus offsetof, to remove unportable assumptions about struct layout.
2108 These assumptions hold on all porting targets that I know of, but
2109 they are not guaranteed, they're easy to remove, and removing them
2110 makes further changes easier.
2111
0b432f21
PE
2112 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2113 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2114 (string_overrun_cookie): Now const. Use initializers that
2115 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2116 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2117 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2118 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2119 multiple of sizeof (EMACS_INT); it need not be, if
2120 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2121 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2122
895009e1
JB
21232011-04-26 Juanma Barranquero <lekktu@gmail.com>
2124
2125 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2126
6a7a1b0b
TZ
21272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2128
2129 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2130 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2131 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2132
841a1577 21332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2134
2135 * lisp.h (Qdebug): List symbol.
895009e1 2136 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2137 * keyboard.c (debug-on-event): New variable.
2138 (handle_user_signal): Break into debugger when debug-on-event
2139 matches the current signal symbol.
2140
f2d3ba6f
DN
21412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2142
2143 * alloc.c (check_sblock, check_string_bytes)
2144 (check_string_free_list): Convert to standard C.
2145
42ce4c63
TZ
21462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2147
2148 * w32.c (emacs_gnutls_push): Fix typo.
2149
825cd63c
EZ
21502011-04-25 Eli Zaretskii <eliz@gnu.org>
2151
fb11d64d
EZ
2152 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2153 "cast to pointer from integer of different size".
2154
825cd63c
EZ
2155 Improve doprnt and its use in verror. (Bug#8545)
2156 * doprnt.c (doprnt): Document the set of format control sequences
2157 supported by the function. Use SAFE_ALLOCA instead of always
2158 using `alloca'.
2159
2160 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2161 is one byte too soon. Don't use xrealloc; instead xfree and
2162 xmalloc anew.
2163
e061a11b
TZ
21642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2165
2166 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2167 callbacks stage.
2168
2169 * gnutls.c: Renamed global_initialized to
2170 gnutls_global_initialized. Added internals for the
2171 :verify-hostname-error, :verify-error, and :verify-flags
2172 parameters of `gnutls-boot' and documented those parameters in the
2173 docstring. Start callback support.
2174 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2175 unless a fatal error occured. Call gnutls_alert_send_appropriate
2176 on error. Return error code.
2177 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2178 (emacs_gnutls_read): Likewise.
2179 (Fgnutls_boot): Return handshake error code.
2180 (emacs_gnutls_handle_error): New function.
2181 (wsaerror_to_errno): Likewise.
2182
2183 * w32.h (emacs_gnutls_pull): Add prototype.
2184 (emacs_gnutls_push): Likewise.
2185
2186 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2187 (emacs_gnutls_push): Likewise.
2188
21892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2190
2191 * process.c (wait_reading_process_output): Check if GnuTLS
2192 buffered some data internally if no FDs are set for TLS
2193 connections.
2194
2195 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2196 (LIBS): Link to USER_LIBS.
2197 ($(BLD)/gnutls.$(0)): New target.
2198
fa6996bc
EZ
21992011-04-24 Eli Zaretskii <eliz@gnu.org>
2200
eb35682e
EZ
2201 * xdisp.c (handle_single_display_spec): Rename the
2202 display_replaced_before_p argument into display_replaced_p, to
2203 make it consistent with the commentary. Fix typos in the
2204 commentary.
2205
e2ad650c
EZ
2206 * textprop.c (syms_of_textprop): Remove dead code.
2207 (copy_text_properties): Delete obsolete commentary about an
2208 interface that was deleted long ago. Fix typos in the description
2209 of arguments.
2210
1b2de274
EZ
2211 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2212 to changes in oldXMenu/XMenu.h from 2011-04-16.
2213 <menu_help_message, prev_menu_help_message>: Constify.
2214 (IT_menu_make_room): menu->help_text is now `const char **';
2215 adjust.
2216
2217 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2218 to changes in oldXMenu/XMenu.h from 2011-04-16.
2219 (struct XMenu): Declare `help_text' `const char **'.
2220
2221 * xfaces.c <Qunspecified>: Make extern again.
2222
2223 * syntax.c: Include sys/types.h before including regex.h, as
2224 required by Posix.
2225
762b15be
EZ
2226 * doc.c (get_doc_string): Improve the format passed to `error'.
2227
2228 * doprnt.c (doprnt): Improve commentary.
2229
2230 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2231
2232 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2233 them with etags.
2234
f1052e5d
EZ
2235 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2236 changes in globals.h immediately force recompilation.
762b15be
EZ
2237 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2238 $(CURDIR)/s/ms-w32.h.
2239 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2240
fa6996bc
EZ
2241 * character.c (Fchar_direction): Function deleted.
2242 (syms_of_character): Don't defsubr it.
2243 <char-direction-table>: Deleted.
2244
e6c3da20
EZ
22452011-04-23 Eli Zaretskii <eliz@gnu.org>
2246
2247 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2248 * doprnt.c: Include limits.h.
2249 (SIZE_MAX): New macro.
04f2d78b
CB
2250 (doprnt): Return a size_t value. 2nd arg is now size_t.
2251 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2252 Improve overflow protection. Support `l' modifier for integer
2253 conversions. Support %l conversion. Don't assume an EMACS_INT
2254 argument for integer conversions and for %c.
2255
2256 * lisp.h (doprnt): Restore prototype.
2257
2258 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2259 $(SRC)/character.h.
2260
2261 * Makefile.in (base_obj): Add back doprnt.o.
2262
2263 * deps.mk (doprnt.o): Add back prerequisites.
2264 (callint.o): Depend on character.h.
2265
2266 * eval.c (internal_lisp_condition_case): Include the handler
2267 representation in the error message.
2268 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2269 when breaking from the loop.
2270
2271 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2272
2273 * callint.c (Fcall_interactively): When displaying error message
2274 about invalid control letter, pass the character's codepoint, not
2275 a pointer to its multibyte form. Improve display of the character
2276 in octal and display also its hex code.
2277
2278 * character.c (char_string): Use %x to display the (unsigned)
2279 codepoint of an invalid character, to avoid displaying a bogus
2280 negative value.
2281
2282 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2283 `error', not SYMBOL_NAME itself.
2284
2285 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2286 character arguments to `error'.
2287
2288 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2289 to `error' in error message about FINAL_CHAR argument. Make sure
2290 FINAL_CHAR is a character, and use %c when it is passed as
2291 argument to `error'.
2292
4ffd0d6b 22932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2294
2295 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2296
2297 * w32.c: Include <time.h>.
2298 (sys_localtime): New function.
2299
4ffd0d6b 23002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2301
2302 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2303
4ffd0d6b 2304 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2305
4ffd0d6b 23062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2307
4ffd0d6b
GM
2308 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2309 zombies (Bug#8467).
aac0c6e3 2310
04c56954
EZ
23112011-04-19 Eli Zaretskii <eliz@gnu.org>
2312
2313 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2314 gl_state.e_property when gl_state.object is Qt.
2315
2316 * insdel.c (make_gap_larger): Remove limitation of buffer size
2317 to <= INT_MAX.
2318
16a43933
CY
23192011-04-18 Chong Yidong <cyd@stupidchicken.com>
2320
2321 * xdisp.c (lookup_glyphless_char_display)
2322 (produce_glyphless_glyph): Handle cons cell entry in
2323 glyphless-char-display.
2324 (Vglyphless_char_display): Document it.
2325
2326 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2327 glyphless-char-display.
2328
4581706e
CY
23292011-04-17 Chong Yidong <cyd@stupidchicken.com>
2330
2331 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2332
2333 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2334
2335 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2336 definition for no-X builds.
2337
4887c6e2 23382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2339
fd35b6f9
PE
2340 Static checks with GCC 4.6.0 and non-default toolkits.
2341
5c1ccb01
PE
2342 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2343
006c5daa
PE
2344 * process.c (keyboard_bit_set): Define only if SIGIO.
2345 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2346 (send_process): Repair possible setjmp clobbering.
2347
efc736d3
PE
2348 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2349
4e2fe2e6
PE
2350 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2351
f97334a2
PE
2352 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2353
4e75f29d
PE
2354 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2355 Define only if needed.
2356
90efadd1
PE
2357 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2358 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2359 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2360
3c647824
PE
2361 * dispextern.h (struct redisplay_interface): Rename param
2362 to avoid shadowing.
e264f262 2363 * termhooks.h (struct terminal): Likewise.
761383f4 2364 * xterm.c (xembed_send_message): Likewise.
3c647824 2365
b58c5c4a
PE
2366 * insdel.c (make_gap_smaller): Define only if
2367 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2368
cad59032
PE
2369 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2370 it.
2371
c339dc2e
PE
2372 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2373 so that we aren't warned about unused symbols.
2374
91a3e27b
PE
2375 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2376
399c71d3 2377 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2378
8ffc96f5
PE
2379 * xfns.c (x_real_positions): Mark locals as initialized.
2380
eef9bc79
PE
2381 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2382
098db9dd
PE
2383 * xterm.c: Fix problems found by static analysis with other toolkits.
2384 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2385 (x_dispatch_event): Declare static if USE_GTK, and
2386 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2387 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2388 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2389 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2390 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2391
eb18f6cc
PE
2392 * xmenu.c (menu_help_callback): Pointer type fixes.
2393 Use const pointers when pointing at readonly data. Avoid pointer
2394 signedness clashes.
2395 (FALSE): Remove unused macro.
2396 (update_frame_menubar): Remove unused decl.
2397
1fe72bf8
PE
2398 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2399
60d9e1db
PE
2400 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2401 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2402 (single_menu_item): Rename local to avoid shadowing.
2403
39261c26
PE
2404 * keyboard.c (make_lispy_event): Remove unused local var.
2405
018c5e19
PE
2406 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2407 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2408
63d2b86e
PE
2409 * bitmaps: Change bitmaps from unsigned char back to the X11
2410 compatible char. Avoid the old compiler warnings about
2411 out-of-range initializers by using, for example, '\xab' rather
2412 than 0xab.
2413
aefd87e1
PE
2414 * xgselect.c (xgselect_initialize): Check vs interface
2415 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2416
bf501fb9
PE
2417 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2418
e9829fdf
PE
2419 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2420 to read-only memory.
2421
1086c095
PE
2422 * fns.c (vector): Remove; this old hack is no longer needed.
2423
2baccd04 2424 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2425 Remove unused var.
dde42981 2426 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2427
72391843 2428 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2429
436c16df 2430 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2431 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2432 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2433
92bb796d 2434 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2435 (x_term_init): Remove local to avoid shadowing.
92bb796d 2436
764430a3 2437 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2438
2439 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2440 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2441
d1dfb56c
EZ
24422011-04-16 Eli Zaretskii <eliz@gnu.org>
2443
c4354cb4
EZ
2444 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2445
d1dfb56c
EZ
2446 Fix regex.c, syntax.c and friends for buffers > 2GB.
2447 * syntax.h (struct gl_state_s): Declare character position members
2448 EMACS_INT.
2449
2450 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2451
04f2d78b
CB
2452 * textprop.c (verify_interval_modification, interval_of):
2453 Declare arguments EMACS_INT.
d1dfb56c
EZ
2454
2455 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2456 EMACS_INT.
2457
2458 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2459
2460 * indent.c (Fvertical_motion): Local variable it_start is now
2461 EMACS_INT.
2462
2463 * regex.c (re_match, re_match_2, re_match_2_internal)
2464 (bcmp_translate, regcomp, regexec, print_double_string)
2465 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2466 (re_compile_pattern, re_exec): Declare arguments and local
2467 variables `size_t' and `ssize_t' and return values `regoff_t', as
2468 appropriate.
2469 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2470 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2471 <compile_stack_type>: `size' and `avail' are now `size_t'.
2472
2473 * regex.h <regoff_t>: Use ssize_t, not int.
2474 (re_search, re_search_2, re_match, re_match_2): Arguments that
2475 specify buffer/string position and length are now ssize_t and
2476 size_t. Return type is regoff_t.
2477
613052cd
BK
24782011-04-16 Ben Key <bkey76@gmail.com>
2479
2480 * nsfont.m: Fixed bugs in ns_get_family and
2481 ns_descriptor_to_entity that were caused by using free to
2482 deallocate memory blocks that were allocated by xmalloc (via
2483 xstrdup). This caused Emacs to crash when compiled with
2484 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2485 --enable-checking=xmallocoverrun). xfree is now used to
2486 deallocate these memory blocks.
2487
4170f62f 24882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2489
71b41406
PE
2490 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2491
9587a89d
PE
2492 emacs_write: Accept and return EMACS_INT for sizes.
2493 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2494 et seq.
2495 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2496 Accept and return EMACS_INT.
2497 (emacs_gnutls_write): Return the number of bytes written on
2498 partial writes.
2499 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2500 (emacs_read, emacs_write): Remove check for negative size, as the
2501 Emacs source code has been audited now.
9587a89d
PE
2502 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2503 (emacs_read, emacs_write): Use it.
273a5f82
PE
2504 * process.c (send_process): Adjust to the new signatures of
2505 emacs_write and emacs_gnutls_write. Do not attempt to store
2506 a byte offset into an 'int'; it might overflow.
9587a89d 2507 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2508
3e047f51
PE
2509 * sound.c: Don't assume sizes fit in 'int'.
2510 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2511 Return EMACS_INT, not int.
3e047f51 2512 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2513 Accept EMACS_INT, not int.
2514 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2515 record read return values.
2516
cc39a9db
BK
25172011-04-15 Ben Key <bkey76@gmail.com>
2518
c9d0ec6d
JB
2519 * keyboard.c (Qundefined): Don't declare static since it is used
2520 in nsfns.m.
2521 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2522 static since they are used in nsfont.m.
cc39a9db 2523
6c60eb9f
SM
25242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2525
2526 * process.c (Qprocessp): Don't declare static.
2527 * lisp.h (Qprocessp): Declare again.
2528
7990b61a
JB
25292011-04-15 Juanma Barranquero <lekktu@gmail.com>
2530
2531 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2532
5d4cb038
PE
25332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2534
8bd7b830 2535 Improve C-level modularity by making more things 'static'.
cd64ea1d 2536
e3b27b31
PE
2537 Don't publish debugger-only interfaces to other modules.
2538 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2539 (verify_bytepos, count_markers): Move decls to the only modules
2540 that need them.
2541 * region-cache.h (pp_cache): Likewise.
2542 * window.h (check_all_windows): Likewise.
2543 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2544
5d4cb038
PE
2545 * sysdep.c (croak): Now static, if
2546 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2547 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2548
2549 * alloc.c (refill_memory_reserve): Now static if
2550 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2551 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2552
e87b6180
PE
2553 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2554 Define only if USE_LUCID.
2555
ac64929e
PE
2556 * xrdb.c (x_customization_string, x_rm_string): Now static.
2557
6f37259d
PE
2558 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2559 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2560
1683e3ab
PE
2561 * xdisp.c (draw_row_with_mouse_face): Now static.
2562 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2563
de9c2632
PE
2564 * window.h (check_all_windows): Mark externally visible.
2565
2b96acb7
PE
2566 * window.c (window_deletion_count): Now static.
2567
2568 * undo.c: Make symbols static if they're not exported.
2569 (last_undo_buffer, last_boundary_position, pending_boundary):
2570 Now static.
2571
50436f33
PE
2572 * textprop.c (interval_insert_behind_hooks): Now static.
2573 (interval_insert_in_front_hooks): Likewise.
2574
64520e5c
PE
2575 * term.c: Make symbols static if they're not exported.
2576 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2577 (max_frame_lines, tty_set_terminal_modes):
2578 (tty_reset_terminal_modes, tty_turn_off_highlight):
2579 (get_tty_terminal): Now static.
2580 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2581 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2582 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2583 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2584 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2585
1fa53021
PE
2586 * sysdep.c: Make symbols static if they're not exported.
2587 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2588 Now static.
2589 (sigprocmask_set, full_mask): Remove; unused.
2590 (wait_debugging): Mark as visible.
2591 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2592 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2593
d4b43b22
PE
2594 * syntax.c (syntax_temp): Define only if !__GNUC__.
2595
b7c513d0
PE
2596 * sound.c (current_sound_device, current_sound): Now static.
2597
989b29ad
PE
2598 * search.c (searchbufs, searchbuf_head): Now static.
2599
13a55a78
PE
2600 * scroll.c (scroll_cost): Remove; unused.
2601 * dispextern.h (scroll_cost): Remove decl.
2602
de68a1fc
PE
2603 * region-cache.h (pp_cache): Mark as externally visible.
2604
40ccffa6
PE
2605 * process.c: Make symbols static if they're not exported.
2606 (process_tick, update_tick, create_process, chan_process):
2607 (Vprocess_alist, proc_buffered_char, datagram_access):
2608 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2609 (deactivate_process): Mark defn as static, as well as decl.
2610 * lisp.h (create_process): Remove decl.
2611 * process.h (chan_process, Vprocess_alist): Remove decls.
2612
ad64fc97
PE
2613 * print.c: Make symbols static if they're not exported.
2614 (print_depth, new_backquote_output, being_printed, print_buffer):
2615 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2616 (print_interval, print_number_index, initial_stderr_stream):
2617 Now static.
2618 * lisp.h (Fprinc): Remove decl.
2619 (debug_output_compilation_hack): Mark as externally visible.
2620
adddb265
PE
2621 * sysdep.c (croak): Move decl from here to syssignal.h.
2622 * syssignal.h (croak): Put it here, so the API can be checked when
2623 'croak' is called from dissociate_if_controlling_tty.
2624
1717ede2
PE
2625 * minibuf.c: Make symbols static if they're not exported.
2626 (minibuf_save_list, choose_minibuf_frame): Now static.
2627 * lisp.h (choose_minibuf_frame): Remove decl.
2628
fa5fb2bc
PE
2629 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2630
1e3890d1
PE
2631 * lread.c: Make symbols static if they're not exported.
2632 (read_objects, initial_obarray, oblookup_last_bucket_number):
2633 Now static.
2634 (make_symbol): Remove; unused.
2635 * lisp.h (initial_obarray, make_symbol): Remove decls.
2636
8a1414fa
PE
2637 * keyboard.c: Make symbols static if they're not exported.
2638 (single_kboard, recent_keys_index, total_keys, recent_keys):
2639 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2640 (this_single_command_key_start, echoing, last_auto_save):
2641 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2642 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2643 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2644 (Vlispy_mouse_stem, double_click_count):
2645 Now static.
2646 (force_auto_save_soon): Define only if SIGDANGER.
2647 (ignore_mouse_drag_p): Now static if
2648 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2649 (print_help): Remove; unused.
2650 (stop_character, last_timer_event): Mark as externally visible.
2651 * keyboard.h (ignore_mouse_drag_p): Declare only if
2652 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2653 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2654 * lisp.h (echoing): Remove decl.
2655 (force_auto_save_soon): Declare only if SIGDANGER.
2656 * xdisp.c (redisplay_window): Simplify code, to make it more
2657 obvious that ignore_mouse_drag_p is not accessed if !defined
2658 USE_GTK && !defined HAVE_NS.
2659
93ea6e8f
PE
2660 * intervals.c: Make symbols static if they're not exported.
2661 (merge_properties_sticky, merge_interval_right, delete_interval):
2662 Now static.
2663 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2664
77382fcc
PE
2665 * insdel.c: Make symbols static if they're not exported.
2666 However, leave prepare_to_modify_buffer alone. It's never
2667 called from outside this function, but that appears to be a bug.
2668 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2669 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2670 (adjust_after_replace_noundo): Remove; unused.
2671 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2672 (signal_before_change): Remove decls.
77382fcc 2673
9306c32e
PE
2674 * indent.c (val_compute_motion, val_vmotion): Now static.
2675
cd44d2eb
PE
2676 * image.c: Make symbols static if they're not exported.
2677 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2678 if USE_GTK.
2679 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2680 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2681
ad9a7a06
PE
2682 * fringe.c (standard_bitmaps): Now static.
2683 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2684
81626931
PE
2685 * frame.c: Make symbols static if they're not exported.
2686 (x_report_frame_params, make_terminal_frame): Now static.
2687 (get_frame_param): Now static, unless HAVE_NS.
2688 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2689 (x_get_resource_string): Remove; not used.
2690 * frame.h (make_terminal_frame, x_report_frame_params):
2691 (x_get_resource_string); Remove decls.
2692 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2693 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2694
239f9db9
PE
2695 * font.c, fontset.c: Make symbols static if they're not exported.
2696 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2697 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2698 * font.c (font_close_object): Now static.
2699 * font.h (font_close_object): Remove.
2700 * fontset.c (FONTSET_OBJLIST): Remove.
2701 (free_realized_fontset) #if-0 the body, which does nothing.
2702 (face_suitable_for_char_p): #if-0, as it's never called.
2703 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2704 * xfaces.c (face_at_string_position):
2705 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2706 since 0 is always ASCII.
2707
dfcf3579
PE
2708 * fns.c (weak_hash_tables): Now static.
2709
5045092b
PE
2710 * fileio.c: Make symbols static if they're not exported.
2711 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2712 (Vwrite_region_annotation_buffers): Now static.
2713
57a96f5c
PE
2714 * eval.c: Make symbols static if they're not exported.
2715 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2716 * lisp.h (backtrace_list): Remove decl.
2717
35f08c38
PE
2718 * emacs.c: Make symbols static if they're not exported.
2719 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2720 (fatal_error_code, fatal_error_signal_hook, standard_args):
2721 Now static.
2722 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2723 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2724 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2725 * lisp.h (fatal_error_signal_hook): Remove decl.
2726 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2727
f44bd759
PE
2728 * editfns.c: Move a (normally-unused) function to its only use.
2729 * editfns.c, lisp.h (get_operating_system_release): Remove.
2730 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2731 worth the hassle of breaking this out.
2732
b532497d
PE
2733 * xterm.c: Make symbols static if they're not exported.
2734 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2735 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2736 (x_destroy_window, x_delete_display):
2737 Now static.
2738 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2739 (x_mouse_leave): Remove; unused.
2740 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2741 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2742 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2743 Remove decls.
2744 (x_mouse_leave): Declare only if WINDOWSNT.
2745 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2746 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2747 USE_X_TOOLKIT.
2748
1675728f
PE
2749 * ftxfont.c: Make symbols static if they're not exported.
2750 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2751 HAVE_FREETYPE.
2752 * font.h (ftxfont_driver): Likewise.
2753
e4cebfca
PE
2754 * xfns.c: Make symbols static if they're not exported.
2755 (x_last_font_name, x_display_info_for_name):
2756 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2757 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2758 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2759 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2760 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2761 (last_show_tip_args): Now static.
2762 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2763 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2764 (x_screen_planes): Remove; unused.
2765 * dispextern.h (x_screen_planes): Remove decl.
2766
5bf46f05
PE
2767 * dispnew.c: Make symbols static if they're not exported.
2768 * dispextern.h (redraw_garbaged_frames, scrolling):
2769 (increment_row_positions): Remove.
2770 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2771 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2772 Now static.
2773 (redraw_garbaged_frames): Remove; unused.
2774
435f4c28
PE
2775 * xfaces.c: Make symbols static if they're not exported.
2776 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2777 Remove decls.
2778 * xterm.h (defined_color): Remove decls.
2779 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2780 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2781 (menu_face_changed_default, defined_color, free_realized_face):
2782 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2783 (ascii_face_of_lisp_face): Remove; unused.
2784
8524aef3
PE
2785 * xdisp.c: Make symbols static if they're not exported.
2786 * dispextern.h (scratch_glyph_row, window_box_edges):
2787 (glyph_to_pixel_coords, set_cursor_from_row):
2788 (get_next_display_element, set_iterator_to_next):
2789 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2790 (show_mouse_face): Remove decls
2791 * frame.h (message_buf_print): Likewise.
2792 * lisp.h (pop_message, set_message, check_point_in_composition):
2793 Likewise.
2794 * xterm.h (set_vertical_scroll_bar): Likewise.
2795 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2796 (message_buf_print, scratch_glyph_row, displayed_buffer):
2797 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2798 (get_next_display_element, show_mouse_face, window_box_edges):
2799 (frame_to_window_pixel_xy, check_point_in_composition):
2800 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2801 (glyph_to_pixel_coords): Remove; unused.
2802
16390cd2
PE
2803 * dired.c (file_name_completion): Now static.
2804
2805 * dbusbind.c (xd_in_read_queued_messages): Now static.
2806
a25f4dfa
PE
2807 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2808 * data.c (circular_list_error): Remove.
2809
14a9c8df
PE
2810 * commands.h (last_point_position, last_point_position_buffer):
2811 (last_point_position_window): Remove decls.
2812 * keyboard.c: Make these variables static.
2813
04f2d78b
CB
2814 * coding.h (coding, code_convert_region, encode_coding_gap):
2815 Remove decls.
74ab6df5
PE
2816 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2817 (iso_code_class, detect_coding, code_convert_region): Now static.
2818 (encode_coding_gap): Remove; unused.
2819
38dfbee1
PE
2820 * chartab.c (chartab_chars, chartab_bits): Now static.
2821
a2cb4e63
PE
2822 * charset.h (charset_iso_8859_1): Remove decl.
2823 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2824 Now static.
2825
127198fd
PE
2826 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2827 * ccl.c (Vccl_program_table): Now static.
2828 (check_ccl_update): Remove; unused.
2829
d85b608f
PE
2830 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2831 * category.h: ... from here.
2832 * category.c (check_category_table, set_category_set): Now static.
2833
31cd66f3
PE
2834 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2835 * lisp.h: Remove these decls.
2836
c358e587
PE
2837 * buffer.c (buffer_count): Remove unused var.
2838
e78aecca
PE
2839 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2840 so that it's not optimized away.
2841 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2842 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2843 exported only to the debugger.
2844
e192d7d3 2845 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2846 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2847
92470028
PE
2848 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2849 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2850 was inaccessible from Lisp.
2851 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2852 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2853
244ed907
PE
2854 alloc.c: Import and export fewer symbols, and remove unused items.
2855 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2856 is defined.
2857 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2858 it's not optimized away by whole-program optimization.
2859 (message_enable_multibyte, free_misc): Remove.
2860 (catchlist, handlerlist, mark_backtrace):
2861 Declare only if BYTE_MARK_STACK.
2862 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2863 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2864 (message_enable_multibyte): Remove decl.
2865 (free_misc, interval_free_list, float_block, float_block_index):
2866 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2867 (cons_free_list, last_marked_index):
2868 Now static.
2869 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2870 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2871 (mark_backtrace): Define only if BYTE_MARK_STACK.
2872 * xdisp.c (message_enable_multibyte): Now static.
2873
61c2b50e 2874 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2875 This makes it easier for human readers (and static analyzers)
2876 to see whether these variables are used from other modules.
2877 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2878 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2879 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2880 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2881 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2882 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2883 * xmenu.c, xselect.c:
2884 Declare Q* vars static if they are not used in other modules.
2885 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2886 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2887 Remove decls of unexported vars.
2888 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2889
95c82688
PE
2890 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2891
16a97296
PE
2892 Make Emacs functions such as Fatom 'static' by default.
2893 This makes it easier for human readers (and static analyzers)
2894 to see whether these functions can be called from other modules.
2895 DEFUN now defines a static function. To make the function external
2896 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2897 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2898 (Finit_image_library):
16a97296
PE
2899 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2900 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2901 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2902 Remove decls, since these functions are now static.
2903 (Funintern, Fget_internal_run_time): New decls, since these functions
2904 were already external.
95c82688 2905
16a97296
PE
2906 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2907 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2908 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2909 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2910 * keyboard.c, keymap.c, lread.c:
2911 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2912 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2913 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2914 Mark functions with DEFUE instead of DEFUN,
2915 if they are used in other modules.
2916 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2917 decls for now-static functions.
2918 * buffer.h (Fdelete_overlay): Remove decl.
2919 * callproc.c (Fgetenv_internal): Mark as internal.
2920 * composite.c (Fremove_list_of_text_properties): Remove decl.
2921 (Fcomposition_get_gstring): New forward static decl.
2922 * composite.h (Fcomposite_get_gstring): Remove decl.
2923 * dired.c (Ffile_attributes): New forward static decl.
2924 * doc.c (Fdocumntation_property): New forward static decl.
2925 * eval.c (Ffetch_bytecode): New forward static decl.
2926 (Funintern): Remove extern decl; now in .h file where it belongs.
2927 * fileio.c (Fmake_symbolic_link): New forward static decl.
2928 * image.c (Finit_image_library): New forward static decl.
2929 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2930 * intervals.h (Fprevious_property_change):
2931 (Fremove_list_of_text_properties): Remove decls.
2932 * keyboard.c (Fthis_command_keys): Remove decl.
2933 (Fcommand_execute): New forward static decl.
2934 * keymap.c (Flookup_key): New forward static decl.
2935 (Fcopy_keymap): Now static.
2936 * keymap.h (Flookup_key): Remove decl.
2937 * process.c (Fget_process): New forward static decl.
2938 (Fprocess_datagram_address): Mark as internal.
2939 * syntax.c (Fsyntax_table_p): New forward static decl.
2940 (skip_chars): Remove duplicate decl.
2941 * textprop.c (Fprevious_property_change): New forward static decl.
2942 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2943 Now internal.
2944 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2945 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2946
785bbd42
PE
2947 * editfns.c (Fformat): Remove unreachable code.
2948
8b913b57
AS
29492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2950
2951 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2952 change. (Bug#8496)
2953
a6744a35
EZ
29542011-04-13 Eli Zaretskii <eliz@gnu.org>
2955
2956 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2957 when at ZV. (Bug#8487)
2958
e7974947
AS
29592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2960
baad03f0
AS
2961 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2962 (Bug#8437)
2963 * keyboard.c (parse_tool_bar_item): Likewise.
2964 * sound.c (sound_cleanup, alsa_close): Likewise.
2965 * termcap.c (tgetent): Likewise.
2966 * xfns.c (x_default_font_parameter): Likewise.
2967 * xsettings.c (read_and_apply_settings): Likewise.
2968
e7974947
AS
2969 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2970 (overrun_check_free): Protoize.
2971
28272684
PE
29722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2973
2974 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2975 since callers should never pass a negative size.
2976 Change the signature to match that of plain 'read' and 'write'; see
2977 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2978 * lisp.h: Update prototypes of emacs_write and emacs_read.
2979
11997c76
EZ
29802011-04-11 Eli Zaretskii <eliz@gnu.org>
2981
2982 * xdisp.c (redisplay_window): Don't try to determine the character
2983 position of the scroll margin if the window start point w->startp
e896f03c 2984 is outside the buffer's accessible region. (Bug#8468)
11997c76 2985
8a2cbd72
EZ
29862011-04-10 Eli Zaretskii <eliz@gnu.org>
2987
2988 Fix write-region and its subroutines for buffers > 2GB.
2989 * fileio.c (a_write, e_write): Modify declaration of arguments and
2990 local variables to support buffers larger than 2GB.
2991 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2992
2993 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2994 argument, local variables, and return value.
2995
2996 * lisp.h: Update prototypes of emacs_write and emacs_read.
2997
2998 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2999
4073e537 30002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3001
1ebfdcb6
PE
3002 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3003
b2ded58d
PE
3004 Fix more problems found by GCC 4.6.0's static checks.
3005
7d66342c
PE
3006 * xdisp.c (vmessage): Use a better test for character truncation.
3007
bbf47d44
PE
3008 * charset.c (load_charset_map): <, not <=, for optimization,
3009 and to avoid potential problems with integer overflow.
9248994d 3010 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3011 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3012 * editfns.c (Fformat): Likewise.
1e69125e 3013 * syntax.c (skip_chars): Likewise.
3befa583 3014
e3019616
PE
3015 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3016 This also lets GCC 4.6.0 generate slightly better loop code.
3017
becfa255
PE
3018 * callint.c (Fcall_interactively): <, not <=, for optimization.
3019 (Fcall_interactively): Count the number of arguments produced,
3020 not the number of arguments given. This is simpler and lets GCC
3021 4.6.0 generate slightly better code.
3022
dae0cd48
PE
3023 * ftfont.c: Distingish more carefully between FcChar8 and char.
3024 The previous code passed unsigned char * to a functions like
3025 strlen and xstrcasecmp that expect char *, which does not
3026 conform to the C standard.
3027 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3028 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3029 char * when the C standard requires it.
3030
76032d70
PE
3031 * keyboard.c (read_char): Remove unused var.
3032
eb3f1cc8
PE
3033 * eval.c: Port to Windows vsnprintf (Bug#8435).
3034 Include <limits.h>.
3035 (SIZE_MAX): Define if the headers do not.
3036 (verror): Do not give up if vsnprintf returns a negative count.
3037 Instead, grow the buffer. This ports to Windows vsnprintf, which
3038 does not conform to C99. Problem reported by Eli Zaretskii.
3039 Also, simplify the allocation scheme, by avoiding the need for
3040 calling realloc, and removing the ALLOCATED variable.
3041
70476b54
PE
3042 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3043
12020a9e
PE
3044 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3045 But keep the doprint source code for now, as we might revamp it
3046 and use it again (Bug#8435).
ea6c7ae6
PE
3047 * lisp.h (doprnt): Remove.
3048 * Makefile.in (base_obj): Remove doprnt.o.
3049 * deps.mk (doprnt.o): Remove.
3050
5fdb398c
PE
3051 error: Print 32- and 64-bit integers portably (Bug#8435).
3052 Without this change, on typical 64-bit hosts error ("...%d...", N)
3053 was used to print both 32- and 64-bit integers N, which relied on
3054 undefined behavior.
3055 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3056 New macro.
3057 * lisp.h (error, verror): Mark as printf-like functions.
3058 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3059 Report overflow in size calculations when allocating printf buffer.
3060 Do not truncate output string at its first null byte.
3061 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3062 Truncate the output at a character boundary, since vsnprintf does not
3063 do that.
3064 * charset.c (check_iso_charset_parameter): Convert internal
3065 character to string before calling 'error', since %c now has the
3066 printf meaning.
3067 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3068 overflow when computing char to be passed to 'error'. Do not
3069 pass Lisp_Object to 'error'; pass the integer instead.
3070 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3071 formatted with plain %d.
3072
b189fa66
PE
3073 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3074
bff87ef0
PE
3075 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3076
7e2cac20
PE
3077 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3078
ce4d90b5
PE
3079 * xterm.c (x_catch_errors): Remove duplicate declaration.
3080
266c9547
PE
3081 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3082
79c49ad2
PE
3083 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3084
368f4090
JM
30852011-04-10 Jim Meyering <meyering@redhat.com>
3086
3087 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3088 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3089 return ssize_t not "int", and use size_t as the buffer length.
3090 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3091 * gnutls.h: Update declarations.
3092 * process.c (read_process_output): Use ssize_t, to match.
3093 (send_process): Likewise.
3094
a32d4040
CY
30952011-04-09 Chong Yidong <cyd@stupidchicken.com>
3096
3097 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3098
8546720e 30992011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3100
04f2d78b
CB
3101 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3102 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3103
8546720e
GM
3104 * xterm.c (handle_one_xevent):
3105 * xmenu.c (create_and_show_popup_menu):
3106 * xselect.c (x_decline_selection_request)
3107 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3108
0a2f5c1a 31092011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3110
3111 Fix some uses of `int' instead of EMACS_INT.
3112 * search.c (string_match_1, fast_string_match)
3113 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3114 (scan_buffer, find_next_newline_no_quit)
3115 (find_before_next_newline, search_command, Freplace_match)
3116 (Fmatch_data): Make some `int' variables be EMACS_INT.
3117
3118 * xdisp.c (display_count_lines): 3rd argument and return value now
3119 EMACS_INT. All callers changed.
3120 (pint2hrstr): Last argument is now EMACS_INT.
3121
3122 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3123 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3124 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3125 (decode_coding_utf_16, decode_coding_emacs_mule)
3126 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3127 (decode_coding_ccl, decode_coding_charset)
3128 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3129 (decode_coding_iso_2022, decode_coding_emacs_mule)
3130 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3131 <char_offset, last_offset>: Declare EMACS_INT.
3132 (encode_coding_utf_8, encode_coding_utf_16)
3133 (encode_coding_emacs_mule, encode_invocation_designation)
3134 (encode_designation_at_bol, encode_coding_iso_2022)
3135 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3136 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3137 Declare EMACS_INT.
3138 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3139 (encode_invocation_designation): Last argument P_NCHARS is now
3140 EMACS_INT.
3141 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3142 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3143
3144 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3145 All users changed.
3146
3147 * ccl.c (Fccl_execute_on_string): Declare some variables
3148 EMACS_INT.
3149
8546720e 31502011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3151
3152 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3153
4e19a977
CS
31542011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3155
3156 * process.c (Fformat_network_address): Doc fix.
3157
87302331
R
31582011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3159
3160 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3161
cbb59342
CY
31622011-04-08 Chong Yidong <cyd@stupidchicken.com>
3163
3164 * keyboard.c (read_char): Call Lisp function help-form-show,
3165 instead of using internal_with_output_to_temp_buffer.
3166 (Qhelp_form_show): New var.
e0d38eeb 3167 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3168
3169 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3170
3171 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3172
e67a13ab
CY
31732011-04-06 Chong Yidong <cyd@stupidchicken.com>
3174
04f2d78b
CB
3175 * process.c (Flist_processes): Remove to Lisp.
3176 (list_processes_1): Delete.
e67a13ab 3177
973f782d
EZ
31782011-04-06 Eli Zaretskii <eliz@gnu.org>
3179
7c106b1e
EZ
3180 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3181
973f782d
EZ
3182 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3183
41cf7d1a 31842011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3185
ca23cc88
PE
3186 Fix more problems found by GCC 4.6.0's static checks.
3187
f390e2d5
PE
3188 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3189
42eea0d0
PE
3190 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3191
b69769da 3192 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3193
f9541e84
PE
3194 * xdisp.c (vmessage): Mark as a printf-like function.
3195
13841b55
PE
3196 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3197
c136c10f
PE
3198 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3199
5e2d4a30
PE
3200 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3201 printf-like functions.
3202 (tiff_load): Add casts to remove these marks before passing them
3203 to system-supplied API.
3204
583f48b9
PE
3205 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3206
b25d760e
PE
3207 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3208 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3209 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3210 directly, rather than having caller test rule sign. This avoids
3211 some unnecessary tests.
3212 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3213 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3214 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3215
bc7b6697 3216 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3217 (xfont_open): Avoid unnecessary tests.
bc7b6697 3218
27ccc379
PE
3219 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3220
dcd5c89a
PE
3221 * composite.h, composite.c (composition_gstring_put_cache):
3222 Use EMACS_INT, not int, for length.
3223
b13a45c6
PE
3224 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3225 breaking out part of COMPOSITION_DECODE_RULE.
3226 (COMPOSITION_DECODE_RULE): Use it.
3227 * composite.c (get_composition_id): Remove unused local vars,
3228 by using the new macro.
3229
1e792e4d
PE
3230 * textprop.c (set_text_properties_1): Change while to do-while,
3231 since the condition is always true at first.
3232
dc6c6455 3233 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3234 (interval_deletion_adjustment): Return unsigned value.
3235 All uses changed.
dc6c6455 3236
aba7731a
PE
3237 * process.c (list_processes_1, create_pty, read_process_output):
3238 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3239 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3240 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3241 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3242 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3243
fdfc4bf3
PE
3244 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3245
fca8fe46 3246 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3247 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3248
06a0259a 3249 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3250 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3251 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3252
e7b9e80f
PE
3253 * print.c (print_error_message): Avoid int overflow.
3254
56201685
PE
3255 * font.c (font_list_entities): Redo for clarity,
3256 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3257
78834453 3258 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3259 (font_score): Avoid potential overflow in diff calculation.
78834453 3260
0bc0b309 3261 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3262 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3263
e610eaca
PE
3264 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3265
b895abce
PE
3266 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3267 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3268 can always succeed if overflow has undefined behavior.
3269
1f1d9321 3270 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3271 (wordify): Omit three unnecessary tests.
1f1d9321 3272
c59478bc
PE
3273 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3274 All callers changed. This avoids the need for an unused var.
3275
79b73827
PE
3276 * casefiddle.c (casify_region): Remove var that is set but not used.
3277
a4db5dfe
PE
3278 * dired.c (file_name_completion): Remove var that is set but not used.
3279
43aae36e
PE
3280 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3281
2a47c44d 3282 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3283 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3284
a37c69bf
PE
3285 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3286 Check for integer overflow on size calculations.
3287
328ab8e7
PE
3288 * buffer.c (Fprevious_overlay_change): Remove var that is set
3289 but not used.
3290
e5a2a5cb
PE
3291 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3292 Remove vars that are set but not used.
8d84a6eb 3293 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3294 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3295
a60e5f68
PE
3296 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3297
f661cb61 3298 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3299 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3300
f0397f5a
PE
3301 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3302 that are set but not used.
3303
8664db06 3304 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3305 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3306
6abdaa4a
PE
3307 * xselect.c (x_get_local_selection, x_handle_property_notify):
3308 Remove vars that are set but not used.
3309
0ce7538d 3310 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3311 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3312
9ae848fc
PE
3313 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3314 Remove var that is set but not used.
0b918413
PE
3315 (scroll_bar_windows_size): Now size_t, not int.
3316 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3317 Check for overflow.
9ae848fc 3318
a5a62657
PE
3319 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3320 (map_tty_color) [!defined MSDOS]: Likewise.
3321
5c5cdd39
PE
3322 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3323
66ebf983
PE
3324 * coding.c: Remove vars that are set but not used.
3325 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3326 All callers changed.
3327 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3328 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3329 (decode_coding_charset): Remove vars that are set but not used.
3330
1be4d761
PE
3331 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3332 that is set but not used.
3333
47553fa8
PE
3334 * print.c (print_object): Remove var that is set but not used.
3335
1f7196bf 3336 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3337 The gnulib version avoids calling malloc in the usual case,
3338 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3339 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3340 * filelock.c (current_lock_owner): Likewise.
3341 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3342 * sysdep.c: Include allocator.h, careadlinkat.h.
3343 (emacs_no_realloc_allocator): New static constant.
3344 (emacs_readlink): New function.
fdb61804
PE
3345 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3346 ../lib/careadlinkat.h.
d1fdcab7 3347
f84c17c7
SM
33482011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3349
3350 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3351 first non-nil return value).
3352
ef3862ad
JD
33532011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3354
3355 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3356 if not defined (Bug#8403).
3357
376a7006
JB
33582011-04-02 Juanma Barranquero <lekktu@gmail.com>
3359
3360 * xdisp.c (display_count_lines): Remove parameter `start',
3361 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3362 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3363 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3364 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3365 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3366 and thereabouts. All callers changed.
3367 (get_per_char_metric): Remove parameter `f', unused since
3368 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3369
6ca3801d
JM
33702011-04-02 Jim Meyering <meyering@redhat.com>
3371
3372 do not dereference NULL upon failed strdup
3373 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3374 (ns_get_family): Likewise.
3375
d8e2b5ba
JB
33762011-04-02 Juanma Barranquero <lekktu@gmail.com>
3377
3378 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3379
8c74fcbd
JD
33802011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3381
3382 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3383 later (Bug#8403).
3384
7200d79c
SM
33852011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3386
03408648 3387 Add lexical binding.
7200d79c 3388
03408648
SM
3389 * window.c (Ftemp_output_buffer_show): New fun.
3390 (Fsave_window_excursion):
3391 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3392
3393 * lread.c (lisp_file_lexically_bound_p): New function.
3394 (Fload): Bind Qlexical_binding.
3395 (readevalloop): Remove `evalfun' arg.
3396 Bind Qinternal_interpreter_environment.
3397 (Feval_buffer): Bind Qlexical_binding.
3398 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3399 Mark as dynamic.
3400 (syms_of_lread): Declare `lexical-binding'.
3401
3402 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3403
3404 * keyboard.c (eval_dyn): New fun.
3405 (menu_item_eval_property): Use it.
ca105506
SM
3406
3407 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3408
03408648
SM
3409 * fns.c (concat, mapcar1): Accept byte-code-functions.
3410
3411 * eval.c (Fsetq): Handle lexical vars.
3412 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3413 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3414 (FletX, Flet): Obey lexical binding.
3415 (Fcommandp): Handle closures.
3416 (Feval): New `lexical' arg.
3417 (eval_sub): New function extracted from Feval. Use it almost
3418 everywhere where Feval was used. Look up vars in lexical env.
3419 Handle closures.
3420 (Ffunctionp): Move from subr.el.
3421 (Ffuncall): Handle closures.
3422 (apply_lambda): Remove `eval_flags'.
3423 (funcall_lambda): Handle closures and new byte-code-functions.
3424 (Fspecial_variable_p): New function.
3425 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3426 but without exporting it to Lisp.
23aba0ea 3427
23aba0ea 3428 * doc.c (Fdocumentation, store_function_docstring):
03408648 3429 * data.c (Finteractive_form): Handle closures.
23aba0ea 3430
03408648
SM
3431 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3432 interactive spec.
ba83908c 3433
04f2d78b
CB
3434 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3435 New byte-codes.
03408648
SM
3436 (exec_byte_code): New function extracted from Fbyte_code to handle new
3437 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3438
03408648 3439 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3440
03408648 3441 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3442
e2abce01
JB
34432011-03-31 Juanma Barranquero <lekktu@gmail.com>
3444
3445 * xdisp.c (redisplay_internal): Fix prototype.
3446
63696a73 34472011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3448
63696a73 3449 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3450 (try_scrolling): Use it when setting scroll_limit.
3451 Limit scrolling to 100 screen lines.
63696a73
EZ
3452 (redisplay_window): Even when falling back on "recentering",
3453 position point in the window according to scroll-conservatively,
3454 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3455
3456 (try_scrolling): When point is above the window, allow searching
3457 as far as scroll_max, or one screenful, to compute vertical
3458 distance from PT to the scroll margin position. This prevents
3459 try_scrolling from unnecessarily failing when
3460 scroll-conservatively is set to a value slightly larger than the
3461 window height. Clean up the case of PT below the margin at bottom
3462 of window: scroll_max can no longer be INT_MAX. When aggressive
3463 scrolling is in use, don't let point enter the opposite scroll
3464 margin as result of the scroll.
3465 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3466 threshold of 100 lines for never-recentering scrolling.
3467
e4cc2dfc
JB
34682011-03-31 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * dispextern.h (move_it_by_lines):
3471 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3472 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3473 (message_log_check_duplicate): Remove parameters `prev_bol' and
3474 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3475 (redisplay_internal): Remove parameter `preserve_echo_area',
3476 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3477
3478 * indent.c (Fvertical_motion):
3479 * window.c (window_scroll_pixel_based, Frecenter):
3480 Don't pass `need_y_p' to `move_it_by_lines'.
3481
1c470562
SM
34822011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3483
44f230aa
SM
3484 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3485 steal a few bits to be more compact.
3486 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3487 Remove unneeded casts.
3488
1c470562
SM
3489 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3490
888adce9
ZK
34912011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3492
3493 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3494 binding" message (bug#7967).
3495
f838ed7b
PE
34962011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3497
77861b95
PE
3498 Fix more problems found by GCC 4.6.0's static checks.
3499
de6dbc14
PE
3500 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3501 Remove unused local var.
3502
f838ed7b
PE
3503 * editfns.c (Fmessage_box): Remove unused local var.
3504
792c7b2b
PE
3505 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3506 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3507 Omit unused local vars.
c499e557 3508 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3509 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3510 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3511 Omit unused local var.
3512
ba0165e1
PE
3513 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3514 Don't assume string length fits in int.
32ad8845 3515 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3516 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3517
3c59b4c9
PE
3518 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3519 instead of alloca (Bug#8344).
3520
a3eed478 3521 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3522 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3523
eb4d412d
PE
3524 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3525
1658b401
PE
3526 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3527 concerns.
3528
3529 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3530
3531 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3532
9a2c6e05
PE
3533 * keyboard.c (syms_of_keyboard): Use the same style as later
3534 in this function when indexing through an array. This also
3535 works around GCC bug 48267.
3536
03d0a109
PE
3537 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3538
44f730c8
PE
3539 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3540
fe75f926
PE
3541 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3542 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3543
ffa8c828
PE
3544 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3545 This avoids undefined behavior on integer overflow, and is a bit
3546 more convenient anyway since it is compared to a size_t variable.
3547
c5101a77
PE
3548 Variadic C functions now count arguments with size_t, not int.
3549 This avoids an unnecessary limitation on 64-bit machines, which
3550 caused (substring ...) to crash on large vectors (Bug#8344).
3551 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3552 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3553 All variadic functions and their callers changed accordingly.
c5101a77
PE
3554 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3555 * data.c (arith_driver, float_arith_driver): Likewise.
3556 * editfns.c (general_insert_function): Likewise.
3557 * eval.c (struct backtrace.nargs, interactive_p)
3558 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3559 (funcall_lambda, mark_backtrace): Likewise.
3560 * fns.c (concat): Likewise.
3561 * frame.c (x_set_frame_parameters): Likewise.
3562 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3563 0 if not found, not -1. All callers changed.
3564
dd3f25f7
PE
3565 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3566 (stack_copy_size): Now size_t, not int.
3567 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3568
461c2ab9
JB
35692011-03-28 Juanma Barranquero <lekktu@gmail.com>
3570
3571 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3572 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3573 All callers changed.
3574
3575 * lisp.h (multibyte_char_to_unibyte):
3576 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3577 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3578 * character.h (CHAR_TO_BYTE8):
3579 * cmds.c (internal_self_insert):
3580 * editfns.c (general_insert_function):
3581 * keymap.c (push_key_description):
3582 * search.c (Freplace_match):
3583 * xdisp.c (message_dolog, set_message_1): All callers changed.
3584
f6d62986
SM
35852011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3586
3587 * keyboard.c (safe_run_hook_funcall): New function.
3588 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3589 don't set the hook to nil, but remove the offending function instead.
3590 (Qcommand_hook_internal): Remove, unused.
3591 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3592 Vcommand_hook_internal.
3593
3594 * eval.c (enum run_hooks_condition): Remove.
3595 (funcall_nil, funcall_not): New functions.
3596 (run_hook_with_args): Call each function through a `funcall' argument.
3597 Remove `cond' argument, now redundant.
3598 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3599 (Frun_hook_with_args_until_failure): Adjust accordingly.
3600 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3601
1db5b1ad
JB
36022011-03-28 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * dispextern.h (string_buffer_position): Remove declaration.
3605
3606 * print.c (strout): Remove parameter `multibyte', unused since
3607 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3608
3609 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3610 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3611 All callers changed.
3612
3613 * w32.c (_wsa_errlist): Use braces for struct initializers.
3614
3615 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3616 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3617 All callers changed.
3618 (string_buffer_position): Likewise. Also, make static (it's never
3619 used outside xdisp.c).
3620 (cursor_row_p): Remove parameter `w', unused since
3621 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3622 (decode_mode_spec): Remove parameter `precision', introduced during
3623 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3624 All callers changed.
3625
5ffb62aa
JD
36262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3627
3628 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3629
461c2ab9 36302011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3631
3632 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3633 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3634 (ns_update_auto_hide_menu_bar): New functions.
3635 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3636 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3637 ns_constrain_all_frames.
3638 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3639 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3640
5c380ffb
JD
36412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3642
3643 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3644
9af30bdf
GM
36452011-03-27 Glenn Morris <rgm@gnu.org>
3646
3647 * syssignal.h: Replace RETSIGTYPE with void.
3648 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3649 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3650 Replace SIGTYPE with void everywhere.
3651 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3652 * s/template.h (SIGTYPE): Remove commented out definition.
3653
e2abce01
JB
36542011-03-26 Eli Zaretskii <eliz@gnu.org>
3655
3656 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3657 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3658
f868cd8a
JB
36592011-03-26 Juanma Barranquero <lekktu@gmail.com>
3660
59eb0929
JB
3661 * w32.c (read_unc_volume): Use parameter `henum', instead of
3662 global variable `wget_enum_handle'.
3663
3664 * keymap.c (describe_vector): Remove parameters `indices' and
3665 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3666 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3667
f868cd8a
JB
3668 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3669
3670 * keyboard.c (timer_check): Remove parameter `do_it_now',
3671 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3672 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3673 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3674
3675 * keyboard.c (read_char):
3676 * w32menu.c (w32_menu_display_help):
3677 * xmenu.c (show_help_event, menu_help_callback):
3678 Adjust calls to `show_help_echo'.
3679
3680 * gtkutil.c (xg_maybe_add_timer):
3681 * keyboard.c (readable_events):
3682 * process.c (wait_reading_process_output):
3683 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3684
3685 * insdel.c (adjust_markers_gap_motion):
3686 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3687 (gap_left, gap_right): Don't call it.
3688
2ecf6fdb
CY
36892011-03-25 Chong Yidong <cyd@stupidchicken.com>
3690
3691 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3692 incurred during fontification.
3693
6b1f9ba4
JB
36942011-03-25 Juanma Barranquero <lekktu@gmail.com>
3695
3696 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3697 (DEFVAR_PER_BUFFER): Don't pass it.
3698
3699 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3700 (scrolling_window): Don't pass it.
3701
0f4a96b5
JB
37022011-03-25 Juanma Barranquero <lekktu@gmail.com>
3703
3704 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3705
3706 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3707 and `suffix'.
3708 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3709 of variables specific to SELinux and computation of `encoded_absname'.
3710
3711 * image.c (XPutPixel): Remove unused variable `height'.
3712
3713 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3714
3715 * unexw32.c (get_section_info): Remove unused variable `section'.
3716
3717 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3718 (system_process_attributes): Remove unused variable `sess'.
3719 (sys_read): Remove unused variable `err'.
3720
3721 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3722 (w32_wnd_proc): Remove unused variable `isdead'.
3723 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3724 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3725 (x_create_tip_frame): Remove unused variable `tem'.
3726
3727 * w32inevt.c (w32_console_read_socket):
3728 Remove unused variable `no_events'.
3729
3730 * w32term.c (x_draw_composite_glyph_string_foreground):
3731 Remove unused variable `width'.
3732
1149507c
JB
37332011-03-24 Juanma Barranquero <lekktu@gmail.com>
3734
3735 * w32term.c (x_set_glyph_string_clipping):
3736 Don't pass uninitialized region to CombineRgn.
3737
9c88f339
JB
37382011-03-23 Juanma Barranquero <lekktu@gmail.com>
3739
3740 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3741 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3742 (Fx_close_connection): Remove unused variable `i'.
3743
3744 * w32font.c (w32font_draw): Return number of glyphs.
3745 (w32font_open_internal): Remove unused variable `i'.
3746 (w32font_driver): Add missing initializer.
3747
3748 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3749 (fill_in_menu): Remove unused variable `items_added'.
3750
3751 * w32term.c (last_mouse_press_frame): Remove static global variable.
3752 (w32_clip_to_row): Remove unused variable `f'.
3753 (x_delete_terminal): Remove unused variable `i'.
3754
3755 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3756 (NOTHING): Remove unused static global variable.
3757 (uniscribe_check_otf): Remove unused variable `table'.
3758 (uniscribe_font_driver): Add missing initializers.
3759
dee091a3
JD
37602011-03-23 Julien Danjou <julien@danjou.info>
3761
3762 * term.c (Fsuspend_tty, Fresume_tty):
3763 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3764 * window.c (temp_output_buffer_show):
3765 * insdel.c (signal_before_change):
3766 * frame.c (Fhandle_switch_frame):
3767 * fileio.c (Fdo_auto_save):
3768 * emacs.c (Fkill_emacs):
3769 * editfns.c (save_excursion_restore):
3770 * cmds.c (internal_self_insert):
3771 * callint.c (Fcall_interactively):
3772 * buffer.c (Fkill_all_local_variables):
3773 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3774 Use Frun_hooks.
0f4a96b5 3775 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3776 unconditionnaly since it does the check itself.
3777
2c520ab5 37782011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3779
c9c49752
PE
3780 Fix more problems found by GCC 4.5.2's static checks.
3781
8abc3f12
PE
3782 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3783 the first time through the loop, since we know p0 < p1 then.
3784 This also avoids a gcc -Wstrict-overflow warning.
3785
a2d26660
PE
3786 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3787 leading to a memory leak, possible in functions like
3788 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3789 of objects (Bug#8318).
a2d26660 3790
916c72e9
PE
3791 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3792 that could (at least in theory) be that large.
3793
19ab8a18
PE
3794 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3795 This is less likely to overflow, and avoids undefined behavior if
3796 overflow does occur. All callers changed. Use strtoul to scan
3797 for the unsigned long integer.
b7cbbd6f
PE
3798 (pint2hrstr): Simplify and tune code slightly.
3799 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3800
f0641eff
PE
3801 * scroll.c (do_scrolling): Work around GCC bug 48228.
3802 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3803
7f650bb9
PE
3804 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3805 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3806 (validate_x_resource_name): Simplify count usage.
3807 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3808
37dd57d1
PE
3809 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3810 fail (Bug#8306).
81e56e61 3811
699979fc 3812 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3813
401bf9b4
PE
3814 * process.c (Fmake_network_process): Use socklen_t, not int,
3815 where POSIX says socklen_t is required in portable programs.
3816 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3817 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3818 (Fmake_network_process, server_accept_connection):
3819 (wait_reading_process_output, read_process_output):
3820 Likewise.
3821
b93aacde
PE
3822 * process.c: Rename or move locals to avoid shadowing.
3823 (list_processes_1, Fmake_network_process):
3824 (read_process_output_error_handler, exec_sentinel_error_handler):
3825 Rename or move locals.
4dc343ee 3826 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3827 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3828 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3829 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3830 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3831
af8a867c 3832 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3833 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3834 Include tparam.h instead, since it declares them.
af8a867c
PE
3835 * cm.h (PC): Remove extern decl; tparam.h now does this.
3836 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3837 * terminfo.c: Include tparam.h, to check interfaces.
3838 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3839 (tparam): Adjust signature to match interface in tparam.h;
3840 this removes some undefined behavior. Check that outstring and len
3841 are zero, which they always are with Emacs.
3842 * tparam.h (PC, BC, UP): New extern decls.
3843
0248044d 3844 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3845 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3846
8ff096c1 3847 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3848 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3849 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3850 (ftfont_list): Remove unused local.
49eaafba
PE
3851 (get_adstyle_property, ftfont_pattern_entity):
3852 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3853 Rename locals to avoid shadowing.
8ff096c1 3854
e2be39f6
PE
3855 * xfont.c (xfont_list_family): Mark var as initialized.
3856
c9735e30
PE
3857 * xml.c (make_dom): Now static.
3858
8f5201ae
PE
3859 * composite.c (composition_compute_stop_pos): Rename local to
3860 avoid shadowing.
b246f932
PE
3861 (composition_reseat_it): Remove unused locals.
3862 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3863 (composition_update_it): Mark var as initialized.
11b61122
PE
3864 (find_automatic_composition): Mark vars as initialized,
3865 with a FIXME (Bug#8290).
8f5201ae 3866
760fbc2c
PE
3867 character.h: Rename locals to avoid shadowing.
3868 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3869 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3870 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3871 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3872 to avoid shadowing.
3873
ff08eb85
PE
3874 * textprop.c (property_change_between_p): Remove; unused.
3875
fc7bf025
PE
3876 * intervals.c (interval_start_pos): Now static.
3877
235d7abc
PE
3878 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3879
44f230aa
SM
3880 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3881 Rename locals to avoid shadowing.
3e7d6594 3882
50060332
PE
3883 * sound.c (wav_play, au_play, Fplay_sound_internal):
3884 Fix pointer signedness.
d01f234b 3885 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3886 (wav_play): Initialize a variable to 0, to prevent undefined
3887 behavior (Bug#8278).
50060332 3888
c4fc4e30
PE
3889 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3890
918436ed
PE
3891 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3892
c939f91b
PE
3893 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3894 clobbering (Bug#8298).
b9c7f648
PE
3895 * sysdep.c (sys_subshell): Likewise.
3896 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3897
6bd8c144
PE
3898 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3899 This should get cleaned up, so that child_setup has the
3900 same signature on all platforms.
3901
7710357c 3902 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3903 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3904
c59da222
CY
39052011-03-22 Chong Yidong <cyd@stupidchicken.com>
3906
3907 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3908 not to be necessary, and produces flickering.
3909
66b87493
GM
39102011-03-20 Glenn Morris <rgm@gnu.org>
3911
3912 * config.in: Remove file.
3913
45b6f6d5
JB
39142011-03-20 Juanma Barranquero <lekktu@gmail.com>
3915
3916 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3917 are now in src/globals.h.
3918 (syms_of_minibuf): Remove spurious & from previous change.
3919
3ec03f7e
LL
39202011-03-20 Leo <sdl.web@gmail.com>
3921
3922 * minibuf.c (completing-read-function): New variable.
3923 (completing-read-default): Rename from completing-read.
3924 (completing-read): Call completing-read-function.
3925
b14e3e21
CY
39262011-03-19 Juanma Barranquero <lekktu@gmail.com>
3927
3928 * xfaces.c (Fx_load_color_file):
3929 Read color file from absolute filename (bug#8250).
3930
f2b726e6
JB
39312011-03-19 Juanma Barranquero <lekktu@gmail.com>
3932
3933 * makefile.w32-in: Update dependencies.
3934
09f6ff02
EZ
39352011-03-17 Eli Zaretskii <eliz@gnu.org>
3936
3937 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3938
29a6015a
PE
39392011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3940
a3a6c54e
PE
3941 Fix more problems found by GCC 4.5.2's static checks.
3942
b766f867
PE
3943 * process.c (make_serial_process_unwind, send_process_trap):
3944 (sigchld_handler): Now static.
3945
be02381c
PE
3946 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3947 That way, the code declares only the vars that it needs.
3948 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3949 * s/cygwin.h (PTY_ITERATION): Likewise.
3950 * s/darwin.h (PTY_ITERATION): Likewise.
3951 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3952
57048744
PE
3953 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3954 * process.c (allocate_pty): Don't declare stb unless it's needed.
3955
7914961c 3956 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3957 (CONSTANTLIM): Remove; unused.
3958 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3959 Define only if needed.
7914961c 3960
b3967b18
PE
3961 * unexelf.c (unexec): Name an expression,
3962 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3963 Use a different way to cause a compilation error if anyone uses
3964 n rather than nn, a way that does not involve shadowing.
73366a00 3965 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3966
29a6015a
PE
3967 * deps.mk (unexalpha.o): Remove; unused.
3968
43cfc33e 3969 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3970 * unexec.h: New file.
ce701a33
PE
3971 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3972 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3973 Depend on unexec.h.
3974 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3975 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3976 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3977 Change as necessary to match prototype in unexec.h.
ce701a33 3978
01f44d5a
PE
3979 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3980 shadowing.
4f63c6bb 3981 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3982
a6670b0b
PE
3983 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3984 Rename locals to avoid shadowing.
3985
cef2010d 3986 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3987 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3988
d4d7173a
PE
3989 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3990
f08b802a
PE
3991 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3992 warning when compiling print.c.
3993
3ddb0639
PE
3994 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3995 instead of using an uninitialized var.
5ad03b97 3996 (font_sort_entities): Mark var as initialized.
3ddb0639 3997
170a2692
PE
3998 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3999
e663c700
PE
4000 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4001 pointers to constants.
89bc529a 4002 (font_parse_fcname): Remove unused vars.
7b81e2d0 4003 (font_delete_unmatched): Now static.
ea838e10 4004 (font_get_spec): Remove; unused.
13a547c6
PE
4005 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4006 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4007 Rename or move locals to avoid shadowing.
e663c700 4008
2a80c887 4009 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4010 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4011
1384fa33 4012 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4013 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4014
8b2c52e9
PE
4015 * alloc.c (mark_backtrace): Move decl from here ...
4016 * lisp.h: ... to here, so that it can be checked.
4017
475545b5 4018 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4019 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4020 (lisp_indirect_variable): Name an expression,
4021 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4022 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4023
b1349114 4024 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4025 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4026 Use const pointer when appropriate.
b1349114 4027
a2928364
PE
4028 * lisp.h (get_system_name, get_operating_system_release):
4029 Move decls here, to check interfaces.
4030 * process.c (get_operating_system_release): Move decl to lisp.h.
4031 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4032 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4033 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4034 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4035 (Fformat_time_string, Fencode_time, Finsert_char):
4036 (Ftranslate_region_internal, Fformat):
4037 Rename or remove local vars to avoid shadowing.
9710023e 4038 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4039
a415e694
PE
4040 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4041 avoid shadowing.
4042
8ef4622d
PE
4043 * lisp.h (eassert): Check that the argument compiles, even if
4044 ENABLE_CHECKING is not defined.
4045
946f9a5b
PE
4046 * data.c (Findirect_variable): Name an expression, to avoid
4047 gcc -Wbad-function-cast warning.
112396d6 4048 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4049 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4050 (Fmake_variable_buffer_local, Fmake_local_variable):
4051 Mark variables as initialized.
52746918 4052 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4053
e5aab7e7 4054 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4055 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4056 Rename locals to avoid shadowing.
dff45157
PE
4057 (mark_stack): Move local variables into the #ifdef region where
4058 they're used.
7bc26fdb
PE
4059 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4060 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4061 needed otherwise.
4062 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4063 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4064 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4065
e5aab7e7
PE
4066 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4067 avoids undefined behavior in theory.
4068
4da60324
PE
4069 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4070
88043301
PE
4071 Use functions, not macros, for up- and down-casing (Bug#8254).
4072 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4073 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4074 to use the following functions instead of these macros.
4075 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4076 EMACS_INT, since callers assume the returned value fits in int.
4077 (upcase1): Likewise, for UPCASE_TABLE.
4078 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4079 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4080 the race-condition problem in the old DOWNCASE.
88043301 4081
19ed5445
PE
4082 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4083 Rename locals to avoid shadowing.
4084 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4085 (regex_compile, re_search_2, re_match_2_internal):
4086 Remove unused local vars.
952db0d7
PE
4087 (FREE_VAR): Rewrite so as not to use empty "else",
4088 which gcc can warn about.
da053e48 4089 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4090 (RETALLOC_IF): Define only if needed.
4091 (WORDCHAR_P): Likewise. This one is never needed, but is used
4092 only in a comment talking about a compiler bug, so put inside
4093 the #if 0 of that comment.
4094 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4095 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4096 Remove; unused.
19ed5445 4097
1f3561e4 4098 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4099 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4100 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4101
ded6f8f7
PE
4102 * search.c (simple_search): Remove unused var.
4103
dbd37a95
PE
4104 * dired.c (compile_pattern): Move decl from here ...
4105 * lisp.h: ... to here, so that it can be checked.
4106 (struct re_registers): New forward decl.
4107
7e47afad
PE
4108 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4109
85f24f61
PE
4110 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4111 All uses changed.
4112 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4113 Rename locals to avoid shadowing.
5671df8f 4114 (Fvertical_motion): Mark locals as initialized.
85f24f61 4115
181aa2be 4116 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4117 (casify_region): Mark local as initialized.
181aa2be 4118
930d429c
PE
4119 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4120
7082eac6
PE
4121 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4122 New macros, so that the caller can use some names other than
4123 gcpro1, gcpro2, etc.
4124 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4125 of the new macros.
4126 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4127 argument, for consistency with GCPRO2_VAR, etc: it is now the
4128 prefix of the variable, not the variable itself. All uses
4129 changed.
38b2c076
PE
4130 * dired.c (directory_files_internal, file_name_completion):
4131 Rename locals to avoid shadowing.
4132
15206ed9
PE
4133 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4134 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4135 dired.c's scmp function, had undefined behavior.
4136 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4137 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4138 * buffer.h: ... to here, because these macros use current_buffer,
4139 and the new implementation with inline functions needs to have
4140 current_buffer in scope now, rather than later when the macros
4141 are used.
4142 (downcase, upcase1): New static inline functions.
4143 (DOWNCASE, UPCASE1): Reimplement using these functions.
4144 This avoids undefined behavior in expressions like
4145 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4146 from race conditions in accessing the global variables
4147 case_temp1 and case_temp2.
4148 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4149 * lisp.h (case_temp1, case_temp2): Remove their decls.
4150 * character.h (ASCII_CHAR_P): Move from here ...
4151 * lisp.h: ... to here, so that the inline functions mentioned
4152 above can use them.
4153
4a6bea26
PE
4154 * dired.c (directory_files_internal_unwind): Now static.
4155
f14b7e14
PE
4156 * fileio.c (file_name_as_directory, directory_file_name):
4157 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4158 Now static.
2893f146
PE
4159 (file_name_as_directory): Use const pointers when appropriate.
4160 (Fexpand_file_name): Likewise. In particular, newdir might
4161 point at constant storage, so make it a const pointer.
fd4ead52 4162 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4163 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4164 signedness issues.
f839df0c
PE
4165 (Fset_file_times, Finsert_file_contents, auto_save_error):
4166 Rename locals to avoid shadowing.
f14b7e14 4167
5716756e 4168 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4169 (Ftry_completion, Fall_completions): Rename or remove locals
4170 to avoid shadowing.
5716756e 4171
b4c3046a
PE
4172 * marker.c (bytepos_to_charpos): Remove; unused.
4173
b45db522
PE
4174 * lisp.h (verify_bytepos, count_markers): New decls,
4175 so that gcc does not warn that these functions aren't declared.
4176
85876d07
PE
4177 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4178 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4179 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4180 (copy_text): Remove unused local var.
85876d07 4181
03d78a21 4182 * filelock.c (within_one_second): Now static.
b3dd38ab 4183 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4184
5df8f01b
PE
4185 * buffer.c (fix_overlays_before): Mark locals as initialized.
4186 (fix_start_end_in_overlays): Likewise. This function should be
4187 simplified by using pointers-to-pointers, but that's a different
4188 matter.
b1d876f1 4189 (switch_to_buffer_1): Now static.
8f54f30a
PE
4190 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4191 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4192
a70072c9 4193 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4194 Fix pointer signedness issue.
edced198
PE
4195 (sys_subshell): Mark local as volatile if checking for lint,
4196 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4197 (MAXPATHLEN): Define only if needed.
a70072c9 4198
a0977c44
PE
4199 * process.c (serial_open, serial_configure): Move decls from here ...
4200 * systty.h: ... to here, so that they can be checked.
4201
a884fdcc
PE
4202 * fns.c (get_random, seed_random): Move extern decls from here ...
4203 * lisp.h: ... to here, so that they can be checked.
4204
604efe86 4205 * sysdep.c (reset_io): Now static.
b8950c94 4206 (wait_for_termination_signal): Remove; unused.
604efe86 4207
38fc62d9
PE
4208 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4209 (copy_keymap_item, append_key, push_text_char_description):
4210 Now static.
1004a21a 4211 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4212 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4213 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4214 (describe_map_tree):
4215 Rename locals to avoid shadowing.
38fc62d9 4216
2f2650da
PE
4217 * keyboard.c: Declare functions static if they are not used elsewhere.
4218 (echo_char, echo_dash, cmd_error, top_level_2):
4219 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4220 (read_char, kbd_buffer_get_event, make_lispy_position):
4221 (make_lispy_event, make_lispy_movement, apply_modifiers):
4222 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4223 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4224 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4225 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4226 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4227
a053e86c 4228 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4229 (mark_kboards): Move decl here ...
4230 * alloc.c (mark_kboards): ... from here.
a053e86c 4231
4752793e
PE
4232 * lisp.h (force_auto_save_soon): New decl.
4233
74f10ca7 4234 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4235 (DEFINE_DUMMY_FUNCTION): New macro.
4236 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4237 Use it.
c03cd23f
PE
4238 (main): Add casts to avoid warnings
4239 if GCC considers string literals to be constants.
74f10ca7 4240
022e70d4
PE
4241 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4242
59d6fe83
PE
4243 * dbusbind.c: Pointer signedness fixes.
4244 (xd_signature, xd_append_arg, xd_initialize):
4245 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4246 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4247 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4248 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4249
78320123
PE
4250 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4251 if GCC considers string literals to be constants.
49cebcca 4252 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4253
35ac2a97
SM
42542011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4255
fb103ca9
SM
4256 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4257 (print_preprocess, print_object): New macro to fix last change.
4258
35ac2a97
SM
4259 * print.c (print_preprocess): Don't forget font objects.
4260
62973b41
JB
42612011-03-16 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * emacs.c (USAGE3): Doc fixes.
4264
0e48bb22
AS
42652011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4266
4267 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4268 structure.
4269
7684e57b
JB
42702011-03-14 Juanma Barranquero <lekktu@gmail.com>
4271
4272 * lisp.h (VWindow_system, Qfile_name_history):
4273 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4274 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4275 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4276
4277 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4278 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4279
4280 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4281 * w32console.c (detect_input_pending, read_input_pending)
4282 (encode_terminal_code):
4283 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4284 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4285 (w32_system_caret_y, Qfile_name_history):
4286 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4287 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4288 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4289 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4290 * w32proc.c (Qlocal, report_file_error):
4291 * w32term.c (Vwindow_system, updating_frame):
4292 * w32uniscribe.c (initialized, uniscribe_font_driver):
4293 Remove unneeded extern declarations.
4294
2aa46d6c
CY
42952011-03-14 Chong Yidong <cyd@stupidchicken.com>
4296
c96bbc66 4297 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4298
cffc6f3b
CY
42992011-03-13 Chong Yidong <cyd@stupidchicken.com>
4300
4301 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4302 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4303 These macros can no longer be used for assignment.
4304
44f230aa
SM
4305 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4306 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4307 (record_buffer_markers, fetch_buffer_markers): New functions for
4308 recording and fetching special buffer markers.
4309 (set_buffer_internal_1, set_buffer_temp): Use them.
4310
4311 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4312
4313 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4314
4315 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4316 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4317
4318 * xdisp.c (hscroll_window_tree):
4319 (reconsider_clip_changes): Use PT instead of BUF_PT.
4320
d251f04b
EZ
43212011-03-13 Eli Zaretskii <eliz@gnu.org>
4322
4323 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4324 $(EMACS_ROOT)/lib/intprops.h.
4325
f0c77cd1
PE
43262011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4327
3eca4629
PE
4328 Fix more problems found by GCC 4.5.2's static checks.
4329
7c86ee98
PE
4330 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4331 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4332 (xg_free_frame_widgets): Make it clear that a local variable is
4333 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4334 (gdk_window_get_screen): Make it clear that this macro is needed
4335 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4336 (int_gtk_range_get_value): New function, which avoids a diagnostic
4337 from gcc -Wbad-function-cast.
4338 (xg_set_toolkit_scroll_bar_thumb): Use it.
4339 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4340 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4341 (get_utf8_string, xg_get_file_with_chooser):
4342 Rename locals to avoid shadowing.
4343 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4344
41729b81
PE
4345 * xgselect.c (xg_select): Remove unused var.
4346
f0c77cd1
PE
4347 * image.c (four_corners_best): Mark locals as initialized.
4348 (gif_load): Initialize transparent_p to zero (Bug#8238).
4349 Mark another local as initialized.
ec6cf4c6 4350 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4351
ce0ad53d 4352 * image.c (clear_image_cache): Now static.
d5d5a617 4353 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4354 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4355 (x_edge_detection): Remove unnecessary cast that
4356 gcc -Wbad-function-cast diagnoses.
2037898d 4357 (gif_load): Fix pointer signedness.
6ae141d6
PE
4358 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4359 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4360
33383987 43612011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4362
d32df629
PE
4363 Improve quality of tests for time stamp overflow.
4364 For example, without this patch (encode-time 0 0 0 1 1
4365 1152921504606846976) returns the obviously-bogus value (-948597
4366 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4367 reports time overflow. See
4368 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4369 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4370 * editfns.c: Include limits.h and intprops.h.
4371 (TIME_T_MIN, TIME_T_MAX): New macros.
4372 (time_overflow): Move earlier, to before first use.
4373 (hi_time, lo_time): New functions, for an accurate test for
4374 out-of-range times.
4375 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4376 (Fget_internal_run_time): Don't assume time_t fits in int.
4377 (make_time): Use list2 instead of Fcons twice.
4378 (Fdecode_time): More accurate test for out-of-range times.
4379 (check_tm_member): New function.
4380 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4381 (lisp_time_argument): Don't rely on undefined left-shift and
4382 right-shift behavior when checking for time stamp overflow.
8be6f318 4383
fe31d94c
PE
4384 * editfns.c (time_overflow): New function, refactoring common code.
4385 (Fformat_time_string, Fdecode_time, Fencode_time):
4386 (Fcurrent_time_string): Use it.
4387
8be6f318
PE
4388 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4389 * dired.c (make_time): Move to ...
4390 * editfns.c (make_time): ... here.
4391 * systime.h: Note the move.
4392
09d9db2c 43932011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4394
126bc0dc
YM
4395 * fringe.c (update_window_fringes): Remove unused variables.
4396
c47cbdfd
YM
4397 * unexmacosx.c (copy_data_segment): Also copy __got section.
4398 (Bug#8223)
4399
7ac80be9
EZ
44002011-03-12 Eli Zaretskii <eliz@gnu.org>
4401
c96bbc66 4402 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4403 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4404 Constify `char *' arguments and their references according to
4405 prototypes in tparam.h.
4406
ecb0f94d 4407 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4408
7ac80be9
EZ
4409 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4410 Adapt all references accordingly.
4411
4412 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4413
ef1fd07e
TT
44142011-03-11 Tom Tromey <tromey@redhat.com>
4415
4416 * buffer.c (syms_of_buffer): Remove obsolete comment.
4417
7ef4b50c
EZ
44182011-03-11 Eli Zaretskii <eliz@gnu.org>
4419
4420 * termhooks.h (encode_terminal_code): Declare prototype.
4421
4422 * msdos.c (encode_terminal_code): Don't declare prototype.
4423
4424 * term.c (encode_terminal_code): Now external again, used by
4425 w32console.c and msdos.c.
4426
44f230aa
SM
4427 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4428 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4429
4b1ec863 44302011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4431
1714f52b 4432 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4433
4b1ec863
PE
4434 * fringe.c (update_window_fringes): Mark locals as initialized
4435 (Bug#8227).
4436 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4437
524c7aa6
PE
4438 * alloc.c (mark_fringe_data): Move decl from here ...
4439 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4440 to check its interface.
4441 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4442
a5c0af81 4443 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4444 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4445 (fontset_font): Mark local as initialized.
a9a06e0b 4446 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4447
b4716021
PE
4448 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4449
811e9bac 4450 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4451 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4452 (x_own_selection, Fx_disown_selection_internal): Rename locals
4453 to avoid shadowing.
4454 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4455
7e3ab302
PE
4456 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4457 so that the caller can use some name other than gcpro1.
4458 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4459 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4460 (Fx_backspace_delete_keys_p):
4461 Use them to avoid shadowing, and rename vars to avoid shadowing.
4462 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4463 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4464 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4465 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4466 Remove unused locals.
7e3ab302
PE
4467 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4468 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4469 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4470 macros.
f78faa98 4471
e2b13473
PE
4472 * xterm.h (x_mouse_leave): New decl.
4473
77f23912
PE
4474 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4475 Remove unused functions.
cdf4ba58
PE
4476 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4477 (x_calc_absolute_position): Now static.
7411c686 4478 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4479 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4480 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4481 unless they are used.
38d0b34a
PE
4482 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4483 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4484 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4485 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4486 (x_error_catcher, x_connection_closed, x_error_handler):
4487 (x_error_quitter, xembed_send_message, x_iconify_frame):
4488 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4489 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4490 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4491
44f230aa
SM
4492 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4493 Rename or move locals to avoid shadowing.
6b463e58 4494 (tty_defined_color, merge_face_heights): Now static.
5967d051 4495 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4496 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4497 does not deduce is never used uninitialized.
73719eba
PE
4498 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4499 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4500
426994c3 4501 * terminal.c (store_terminal_param): Now static.
5489860b 4502
032f1620 4503 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4504 (set_frame_menubar): Remove unused local.
d4323972 4505 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4506 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4507 since they might point to immutable storage.
281585b0
PE
4508 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4509 since it's unused otherwise.
032f1620 4510
367c19e5 4511 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4512 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4513 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4514 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4515 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4516 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4517 does not deduce are never used uninitialized.
70739cbe 4518
07b48fa9
PE
4519 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4520
8868a238 4521 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4522 * window.c (window_loop, size_window):
4523 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4524
7e5cf297 4525 * window.c (display_buffer): Now static.
d6550a9f
PE
4526 (size_window): Mark variables that gcc -Wuninitialized
4527 does not deduce are never used uninitialized.
a586633d
PE
4528 * window.h (check_all_windows): New decl, to forestall
4529 gcc -Wmissing-prototypes diagnostic.
5b555da1 4530 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4531
f6095868
PE
4532 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4533 shadowing.
4534 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4535 Include <limits.h>.
4536 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4537 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4538 (load_charset_map): Mark variables that gcc -Wuninitialized
4539 does not deduce are never used uninitialized.
53df7c11 4540 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4541
f38b440c
PE
4542 * coding.c (coding_set_source, coding_set_destination):
4543 Use "else { /* comment */ }" rather than "else /* comment */;"
4544 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4545 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4546 a block, when the outer 'i' will do.
4547 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4548 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4549 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4550 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4551 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4552 Rename locals to avoid shadowing.
4553 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4554 * coding.c (emacs_mule_char, encode_invocation_designation):
4555 Now static, since they're not used elsewhere.
413bb2db 4556 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4557 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4558 (decode_coding_emacs_mule): Mark variables that gcc
4559 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4560 (detect_coding_iso_2022): Initialize a local variable that might
4561 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4562 this initialization is needed. (Bug#8211)
5f58e762
PE
4563 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4564 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4565 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4566 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4567 Remove unused macros.
f38b440c 4568
232b38b9 4569 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4570 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4571 * character.c (string_count_byte8): Likewise.
232b38b9 4572
fb90da1b
PE
4573 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4574 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4575
fb93dbc2
PE
4576 * chartab.c (copy_sub_char_table): Now static, since it's not used
4577 elsewhere.
5c156ace
PE
4578 (sub_char_table_ref_and_range, char_table_ref_and_range):
4579 Rename locals to avoid shadowing.
bbcd0949 4580 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4581
7d3b3862 4582 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4583 (BIDI_BOB): Remove unused macro.
7d3b3862 4584
6be7d3da
PE
4585 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4586 deduce are never used uninitialized.
c2ed9c8b 4587 * term.c (encode_terminal_code): Likewise.
6be7d3da 4588
75f8807f 4589 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4590
50938595
PE
4591 * tparam.h: New file.
4592 * term.c, tparam.h: Include it.
4593 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4594 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4595 Move these decls to tparam.h, and make them agree with what
4596 is actually in tparam.c. The previous trick of using incompatible
4597 decls in different modules does not conform to the C standard.
4598 All callers of tparam changed to use tparam's actual API.
4599 * tparam.c (tparam1, tparam, tgoto):
4600 Use const pointers where appropriate.
4601
fbceeba2
PE
4602 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4603 * cm.h (struct cm): Likewise.
4604 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4605 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4606 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4607 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4608 (turn_on_face, init_tty): Likewise.
4609 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4610
7f3f1250
PE
4611 * term.c (term_mouse_position): Rename local to avoid shadowing.
4612
e6ca6543
PE
4613 * alloc.c (mark_ttys): Move decl from here ...
4614 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4615
c40f8d15
AS
46162011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4617
4618 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4619
cfe0661d
JB
46202011-03-09 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * search.c (compile_pattern_1): Remove argument regp, unused since
4623 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4624 (compile_pattern): Don't pass it.
4625
0afb4571
J
46262011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4627
4628 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4629 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4630 for ! HAVE_GTK3.
4631 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4632
4633 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4634
4635 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4636 gdk_window_get_screen, gdk_window_get_geometry,
4637 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4638 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4639 (xg_get_pixbuf_from_pixmap): New function.
4640 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4641 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4642 Call xg_get_pixbuf_from_pixmap instead of
4643 gdk_pixbuf_get_from_drawable.
4644 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4645 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4646 (xg_check_special_colors): Use GtkStyleContext and its functions
4647 for HAVE_GTK3.
4648 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4649 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4650 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4651 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4652 Call gtk_widget_get_preferred_size.
0afb4571
J
4653 (xg_frame_resized): gdk_window_get_geometry only takes 5
4654 parameters.
44f230aa
SM
4655 (xg_win_to_widget, xg_event_is_for_menubar):
4656 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4657 (xg_set_widget_bg): New function.
4658 (delete_cb): New function.
895009e1 4659 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4660 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4661 (xg_set_background_color): Call xg_set_widget_bg.
4662 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4663 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4664 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4665 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4666 if ! HAVE_GTK3.
4667 (update_frame_tool_bar): Call gtk_widget_hide.
4668 (xg_initialize): Use GDK_KEY_g.
4669
4670 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4671 if ! HAVE_GTK3
4672 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4673
4674 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4675 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4676 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4677
1c2cc4ef
JB
46782011-03-08 Juanma Barranquero <lekktu@gmail.com>
4679
4680 * w32xfns.c (select_palette): Check success of RealizePalette against
4681 GDI_ERROR, not zero.
4682
33383987 4683See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4684
4685;; Local Variables:
4686;; coding: utf-8
aac0c6e3
MR
4687;; End:
4688
33383987 4689 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4690
4691 This file is part of GNU Emacs.
4692
4693 GNU Emacs is free software: you can redistribute it and/or modify
4694 it under the terms of the GNU General Public License as published by
4695 the Free Software Foundation, either version 3 of the License, or
4696 (at your option) any later version.
4697
4698 GNU Emacs is distributed in the hope that it will be useful,
4699 but WITHOUT ANY WARRANTY; without even the implied warranty of
4700 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4701 GNU General Public License for more details.
4702
4703 You should have received a copy of the GNU General Public License
4704 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.