* doc/lispref/intro.texi (A Sample Function Description): Fix cross-refs.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
356e7178
PE
12012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
4e71fd89
PE
3 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
4 This should be fixed in a better way; see Eli Zaretskii in
5 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
6 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
7
f0941253
PE
8 * fileio.c (time_error_value): Rename from special_mtime.
9 The old name's problems were noted by Eli Zaretskii in
10 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
11
065c9eb4
PE
12 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
13 This variable's comment says Emacs needs at least one GDB-visible
14 symbol of type enum pvec_type, to work around GDB problems.
15 The symbol's value doesn't matter.
16
356e7178
PE
17 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
18 that causes compilation to fail on pre-C99 compilers.
19
95f61aa2
JB
202012-07-04 Juanma Barranquero <lekktu@gmail.com>
21
22 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
23 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
24
3884d954
DA
252012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
26
d209e2fb 27 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
28 headers for buffer_defaults and buffer_local_symbols.
29 Reported by Juanma Barranquero <lekktu@gmail.com>.
30
ee28be33
SM
312012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
32
33 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
34 * lisp.h (enum pvec_type): Use fewer bits.
35 (PSEUDOVECTOR_SIZE_BITS): New constant.
36 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
37 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
38 change in pvec_type.
39 (PSEUDOVECTOR_TYPEP): New macro.
40 (TYPED_PSEUDOVECTORP): Use it.
41 * fns.c (internal_equal): Adapt code to extract pvectype.
42 * emacs.c (gdb_pvec_type): Update type.
43 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
44 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
45 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
46 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
47 (sweep_vectors): Use it. Use local var `total_bytes' instead of
48 abusing vector->header.next.nbytes.
49 (live_vector_p): Use PVEC_TYPE.
50 (mark_object): Adapt code to extract pvectype. Use switch.
51
c7f2cd7f
PE
522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
53
54 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
55 Tighten new eassert a bit.
56
8ce70ed2
DA
572012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
58
59 Fix compilation with --enable-gcc-warnings and -O1
60 optimization level.
61 * doprnt.c (doprnt): Change type of tem to int, initialize
62 to avoid compiler warning. Add eassert.
63 * search.c (simple_search): Initialize match_byte to avoid
64 compiler warning. Add eassert.
65
dea7f1e5
PE
662012-07-04 Paul Eggert <eggert@cs.ucla.edu>
67
24a212eb
PE
68 Avoid weird behavior with large horizontal scrolls.
69 Without this change, for example, large hscroll values would
70 mess up Emacs's display on Fedora 15 x86, presumably due to
71 overflows in int calculations in the display code.
72 Also, if buffers had long lines, Emacs would freeze.
73 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
74 (set_window_hscroll): New function, containing the old guts of
75 Fset_window_hscroll. Return the clipped value.
76 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
77 This avoids the need to check against PTRDIFF_MAX.
78
dea7f1e5
PE
79 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
80
76046526
DA
812012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
82
83 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
84
39adff0d
PE
852012-07-04 Paul Eggert <eggert@cs.ucla.edu>
86
63807d47
PE
87 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
88 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
89 since GCC 4.4.6 issues a bogus warning for them.
90
39adff0d
PE
91 Fix bugs in file timestamp newness comparisons.
92 * fileio.c (Ffile_newer_than_file_p):
93 * lread.c (Fload): Use full timestamp resolution of files,
94 not just the 1-second resolution, so that files that are only
95 slightly newer still count as newer.
96 * fileio.c (Ffile_newer_than_file_p): Don't assume file
97 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
98
dbeed9a6
PE
992012-07-03 Paul Eggert <eggert@cs.ucla.edu>
100
101 * fileio.c: Improve handling of file time marker. (Bug#11852)
102 (special_mtime): New function.
103 (Finsert_file_contents, Fverify_visited_file_modtime):
104 Use it to set special mtime values consistently.
105
636334d6
AS
1062012-07-03 Andreas Schwab <schwab@linux-m68k.org>
107
108 * fileio.c (Finsert_file_contents): Properly handle st_mtime
109 marker for non-existing file. (Bug#11852)
110
e2017fe2
GM
1112012-07-03 Glenn Morris <rgm@gnu.org>
112
113 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
114 and did not make it into globals.h).
115
404dbd37
TT
1162012-07-03 Tom Tromey <tromey@redhat.com>
117
118 * window.c (Fset_window_margins, Fset_window_fringes)
119 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
120 * textprop.c (Fprevious_property_change): No longer static.
121 * syntax.c (Fsyntax_table_p): No longer static.
122 * process.c (Fget_process, Fprocess_datagram_address): No longer
123 static.
124 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
125 * keyboard.c (Fcommand_execute): No longer static.
126 Remove EXFUN.
127 * insdel.c (Fcombine_after_change_execute): No longer static.
128 * image.c (Finit_image_library): No longer static.
129 * fileio.c (Fmake_symbolic_link): No longer static.
130 * eval.c (Ffetch_bytecode): No longer static.
131 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
132 * doc.c (Fdocumentation_property, Fsnarf_documentation):
133 No longer static.
404dbd37
TT
134 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
135 static.
136 * dired.c (Ffile_attributes): No longer static.
137 * composite.c (Fcomposition_get_gstring): No longer static.
138 * callproc.c (Fgetenv_internal): No longer static.
139
140 * ccl.h: Remove EXFUNs.
141 * buffer.h: Remove EXFUNs.
142 * dispextern.h: Remove EXFUNs.
143 * intervals.h: Remove EXFUNs.
144 * fontset.h: Remove EXFUN.
145 * font.h: Remove EXFUNs.
146 * dosfns.c (system_process_attributes): Remove EXFUN.
147 * keymap.h: Remove EXFUNs.
148 * lisp.h: Remove EXFUNs.
149 * w32term.h: Remove EXFUNs.
150 * window.h: Remove EXFUNs.
151 * xsettings.h: Remove EXFUN.
152 * xterm.h: Remove EXFUN.
153
8e4fd1e1
GM
1542012-07-03 Glenn Morris <rgm@gnu.org>
155
156 * lisp.h (Frandom): Make it visible to C.
157 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
158 buffer for invisible buffers. (Bug#1229)
159
ca95b3eb
DA
1602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
161
162 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
163 values which aren't power of 2.
164 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
165 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
166 accordingly.
167
7555c33f
SM
1682012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
169
170 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
171
172 * alloc.c (mark_object): Revert part of last patch to use `switch'.
173
d12e8f5a
DA
1742012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
175
176 * alloc.c (allocate_vector_block): Remove redundant
177 calls to mallopt if DOUG_LEA_MALLOC is defined.
178 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
179 avoid calls to mallopt if zero_vector is returned.
180
296094c3
DA
1812012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
182
183 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
184 is enabled, avoid dereferencing NULL current_sblock if
185 running undumped.
186
36429c89
DA
1872012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
188
189 Cleanup basic buffer management.
190 * buffer.h (struct buffer): Change layout to use generic vector
191 marking code. Fix some comments. Change type of 'clip_changed'
192 to bitfield. Remove unused #ifndef old.
193 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
194 (GET_OVERLAYS_AT): Fix indentation.
195 (for_each_per_buffer_object_at): New macro.
196 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
197 (Fbuffer_local_variables): Use it.
198 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
199 * alloc.c (allocate_buffer): Adjust to match new layout of
200 struct buffer. Fix comment.
201 (mark_overlay): New function.
202 (mark_buffer): Use it. Use mark_vectorlike to mark normal
203 Lisp area of struct buffer.
204 (mark_object): Use it. Adjust marking of misc objects
205 and related comments.
206
3b3e4cac
PE
2072012-07-02 Paul Eggert <eggert@cs.ucla.edu>
208
209 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
210 wrapper that is not needed because the wrapped code is a no-op (zero
211 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
212 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
213
cf5c0175
DA
2142012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
215
216 * alloc.c (mark_buffer): Simplify. Remove prototype.
217 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 218 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
219 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
220 redundant calls to mark_vectorlike for bool vectors.
221
ca26824c
GM
2222012-06-30 Glenn Morris <rgm@gnu.org>
223
2e4c5312
GM
224 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
225
ca26824c
GM
226 * epaths.in (PATH_SITELOADSEARCH): New.
227 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
228 This is rather than relying on --enable-locallisppath elements
229 having "site-lisp" in their names. (Bug#10208#25, 11658)
230
0d23c240
EZ
2312012-06-30 Eli Zaretskii <eliz@gnu.org>
232
c9240d7a
EZ
233 * w32proc.c (sys_select): Accept and ignore one more argument.
234
235 * w32.c (emacs_gnutls_pull): Call select with one more argument.
236
0d23c240 237 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 238 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
239
240 * sysdep.c: Don't include dos.h and dosfns.h.
241
242 * process.c (sys_select):
243 * msdos.c (sys_select): Accept one more argument and ignore it.
244
245 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
246 adapt data types and code to that.
247
248 * dosfns.c:
249 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
250 which clashes with the gnulib function of the same name.
251
af5a5a98
AS
2522012-06-30 Andreas Schwab <schwab@linux-m68k.org>
253
c5e4379c
AS
254 * font.c (font_style_to_value, font_style_symbolic)
255 (font_prop_validate_style): Add type checks for values in
256 font_style_table.
257
af5a5a98
AS
258 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
259 argument.
260 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
261 uses.
262
8d38f461
EZ
2632012-06-29 Eli Zaretskii <eliz@gnu.org>
264
2e5a6631
EZ
265 * xdisp.c (try_window_id): Undo last change.
266
8d38f461
EZ
267 * w32.c (getwd): Adjust commentary about startup_dir.
268 (init_environment): Always call sys_access, even in non-MSVC
269 builds. Don't chdir to the directory of the Emacs executable.
270 This undoes code from 1997 which was justified by the need to
271 "avoid conflicts when removing and renaming directories". But its
272 downside was that every relative file name was being interpreted
273 relative to the directory of the Emacs executable, which can never
274 be TRT. In particular, it broke sys_access when called with
275 relative file names.
276 (sys_access): Map GetLastError to errno.
277
2af3565e
DA
2782012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
279
280 * window.h (struct window): Change type of 'fringes_outside_margins'
281 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 282 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
283 Adjust comment.
284 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
285 to ptrdiff_t.
286
c8d3a25c 2872012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 288
c8d3a25c
GM
289 * gnutls.c (emacs_gnutls_handshake):
290 Add QUIT to make the loop interruptible.
57570cd3 291
c8d3a25c 2922012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 293
c8d3a25c
GM
294 * charset.c (init_charset): Make lack of etc/charsets fatal.
295
3e984ee8
DA
2962012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
297
298 * editfns.c (region_limit): Fix type mismatch.
299
ef884f23
DA
3002012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
301
302 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
303 undefined. Convert from xassert to eassert.
304 * nsmenu.m: Convert from xassert to eassert.
305 * nsterm.m: Likewise.
306
7d7e0027
SM
3072012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
308
309 * editfns.c (region_limit): Clip to narrowing (bug#11770).
310
aa754e6a
PE
3112012-06-28 Paul Eggert <eggert@cs.ucla.edu>
312
313 Avoid integer overflow on scroll-left and scroll-right.
314 * window.c (HSCROLL_MAX): New macro.
315 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
316 overflow when requested scroll falls outside ptrdiff_t range.
317
80b00b08
DA
3182012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
319
320 * window.h (struct window): Change type of 'hscroll',
321 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
322 'last_modified' and 'last_overlay_modified' to EMACS_INT.
323 Adjust users accordingly.
324 * xdisp.c (try_cursor_movement): Replace type check with eassert.
325 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
326 from EMACS_INT to ptrdiff_t.
327 (make_window): Omit redundant initialization.
328
62b2bcf6
JB
3292012-06-28 Juanma Barranquero <lekktu@gmail.com>
330
331 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
332
45942c7d
DA
3332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
334
335 * window.h (struct window): Change type of 'use_time' and
336 'sequence_number' from Lisp_Object to int.
337 * frame.c (make_frame): Adjust users accordingly.
338 * print.c (print_object): Likewise.
339 * window.c (select_window, Fwindow_use_time, make_parent_window)
340 (make_window): Likewise.
341
e509cfa6
DA
3422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
343
344 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
345 enabled with --enable-checking=[all,glyphs] configure option.
346 Fix GLYPH_DEBUG usage assuming that it may be undefined,
347 adjust comments accordingly.
348 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
349 undefined, adjust comments accordingly.
350 * image.c: Likewise.
351 * scroll.c: Likewise.
352 * w32fns.c: Likewise.
353 * w32term.c: Likewise.
354 * xdisp.c: Likewise.
355 * xfaces.c: Likewise.
356 * xfns.c: Likewise.
357 * xterm.c: Likewise.
358
a54e2c05
DA
3592012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
360
361 Generalize run-time debugging checks.
362 * dispextern.h (XASSERTS): Remove.
363 * fontset.c (xassert): Remove.
364 Convert from xassert to eassert.
365 * alloc.c: Convert from xassert to eassert.
366 * bidi.c: Likewise.
367 * dispnew.c: Likewise.
368 * fns.c: Likewise.
369 * fringe.c: Likewise.
370 * ftfont.c: Likewise.
371 * gtkutil.c: Likewise.
372 * image.c: Likewise.
373 * keyboard.c: Likewise.
374 * menu.c: Likewise.
375 * process.c: Likewise.
376 * scroll.c: Likewise.
377 * sound.c: Likewise.
378 * term.c: Likewise.
379 * w32console.c: Likewise.
380 * w32fns.c: Likewise.
381 * w32term.c: Likewise.
382 * window.c: Likewise.
383 * xdisp.c: Likewise.
384 * xfaces.c: Likewise.
385 * xfns.c: Likewise.
386 * xselect.c: Likewise.
387 * xterm.c: Likewise.
388
1ec4b7b2
SM
3892012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
390
391 * fns.c (maybe_resize_hash_table): Output message when growing the
392 purify-hashtable.
393
2014308a
DA
3942012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
395
396 * alloc.c (allocate_string_data): Remove dead code.
397 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
398 avoid GCC warning about unused macro.
399
246155eb
DA
4002012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
401
402 * alloc.c (allocate_string): Omit intervals initialization.
403 * alloc.c (make_uninit_multibyte_string): Initialize intervals
404 as in make_pure_string and make_pure_c_string.
405
43184b7b
DA
4062012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
407
d209e2fb 408 * alloc.c (allocate_string): Fix last change.
43184b7b 409
3fe6dd74
DA
4102012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
411
d209e2fb 412 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
413 to memset, add explicit initialization where appropriate.
414
1ba6038a
GM
4152012-06-27 Glenn Morris <rgm@gnu.org>
416
417 * lisp.mk (lisp): Remove paths.elc.
418
c89926a5
CY
4192012-06-27 Chong Yidong <cyd@gnu.org>
420
421 * doc.c (Fsubstitute_command_keys): Fix punctuation.
422
ed6b3510
JW
4232012-06-26 John Wiegley <johnw@newartisans.com>
424
1ec4b7b2 425 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
426 on Mac OS X Lion: __mod_init_func and __mod_term_func.
427
ed6b3510
JW
428 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
429 when building with Clang.
430
8edd4a2b
SM
4312012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
432
433 * eval.c (Fapply): Allow calling it with a single argument.
434
f6f62d1b
EZ
4352012-06-26 Eli Zaretskii <eliz@gnu.org>
436
437 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
438 _stricmp and _strnicmp.
439 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
440
62efea5e
DA
4412012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
442
443 * alloc.c (allocate_window): Zero out non-Lisp part of newly
444 allocated window.
445 (allocate_process): Likewise for new process.
8edd4a2b 446 (allocate_terminal): Change to use offsetof.
62efea5e
DA
447 (allocate_frame): Likewise.
448 * frame.c (make_frame): Omit redundant initialization.
449 * window.c (make_parent_window): Use memset.
450 (make_window): Omit redundant initialization.
451 * process.c (make_process): Omit redundant initialization.
452 * terminal.c (create_terminal): Likewise.
453
42997f4d
DA
4542012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
455
456 * term.c (delete_tty): Remove redundant call to memset.
457
1130ecfc
DA
4582012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
459
460 * alloc.c: Remove build_string.
461 * lisp.h: Define build_string as static inline. This provides
462 a better opportunity to optimize away calls to strlen when the
463 function is called with compile-time constant argument.
464 * image.c (imagemagick_error): Convert to build_string.
465 * w32proc.c (sys_spawnve): Likewise.
466 * xterm.c (x_term_init): Likewise.
467
cf38a720
PE
4682012-06-26 Paul Eggert <eggert@cs.ucla.edu>
469
99027bdd
PE
470 Use sprintf return value instead of invoking strlen on result.
471 In the old days this wasn't portable, since some sprintf
472 implementations returned char *. But they died out years ago and
473 Emacs already assumes sprintf returns int.
474 Similarly for float_to_string.
475 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
476 * ccl.c (ccl_driver):
477 * character.c (string_escape_byte8):
478 * data.c (Fnumber_to_string):
479 * doprnt.c (doprnt):
480 * print.c (print_object):
481 * xdisp.c (message_dolog):
482 * xfns.c (syms_of_xfns):
483 Use sprintf or float_to_string result to avoid need to call strlen.
484 * data.c (Fnumber_to_string):
485 Use make_unibyte_string, since the string must be ASCII.
486 * lisp.h, print.c (float_to_string): Now returns int length.
487 * term.c (produce_glyphless_glyph):
488 Use sprintf result rather than recomputing it.
489
cf38a720
PE
490 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
491 * Makefile.in (ALL_CFLAGS):
492 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
493 * gmalloc.c, regex.c: Include <config.h> unconditionally.
494
3511c784
DA
4952012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
496
0a08eb21 497 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
498 strcasecmp if available.
499 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
500
fb7da12e
AS
5012012-06-25 Andreas Schwab <schwab@linux-m68k.org>
502
503 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
504 Avoid comma operator.
505 * menu.c (push_submenu_start, push_submenu_end)
506 (push_left_right_boundary, push_menu_pane): Likewise.
507 * msdos.c (dos_rawgetc): Likewise.
508
afa2ffd8
DA
5092012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
510
511 * xfns.c (xic_create_fontsetname): Remove redundant calls
512 to memset.
513
b3b4476b
PE
5142012-06-25 Paul Eggert <eggert@cs.ucla.edu>
515
4495ff38
PE
516 * gtkutil.c (get_utf8_string): Remove redundant assignment.
517 sprintf already null-terminates its output.
518
b3b4476b
PE
519 * xfns.c (x_window): Remove redundant cast.
520
b00876c9
DA
5212012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
522
523 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
524 `const char *' to `char *' to avoid compiler warning.
525
d188e26b
PE
5262012-06-24 Paul Eggert <eggert@cs.ucla.edu>
527
885d1d74
PE
528 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
529 instead of truncating it to 63 (admittedly a generous limit).
530
d188e26b
PE
531 * process.c: Fix spelling and caps in comments.
532
e2f560b1
DN
5332012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
534
e86db54b 535 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
536 * sysdep.c (setpgrp): Remove definition, not used in this file.
537
7583a3a1
JB
5382012-06-24 Juanma Barranquero <lekktu@gmail.com>
539
540 * makefile.w32-in: Update dependencies.
541
696056c2
EZ
5422012-06-24 Eli Zaretskii <eliz@gnu.org>
543
544 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
545 (SYSTIME_H): Add nt/inc/sys/time.h.
546
547 * systime.h [WINDOWSNT]: Include sys/time.h.
548
549 * s/ms-w32.h (struct timespec): Definition moved from
550 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
551
845ca893
PE
5522012-06-24 Paul Eggert <eggert@cs.ucla.edu>
553
554 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
555 * buffer.h (buffer_slot_type_mismatch):
556 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
557 * eval.c (unwind_to_catch):
558 * image.c (my_png_error, my_error_exit):
559 * keyboard.c (quit_throw_to_read_char, user_error)
560 (Fexit_recursive_edit, Fabort_recursive_edit):
561 * lisp.h (die, args_out_of_range, args_out_of_range_3)
562 (wrong_type_argument, buffer_overflow, __executable_start)
563 (memory_full, buffer_memory_full, string_overflow, Fthrow)
564 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
565 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
566 (fatal):
567 (child_setup) [!DOS_NT]:
568 * lread.c (end_of_file_error, invalid_syntax):
569 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
570 * puresize.h (pure_write_error):
571 * search.c (matcher_overflow):
572 * sound.c (sound_perror, alsa_sound_perror):
573 * sysdep.c, syssignal.h (croak):
574 * term.c (maybe_fatal, vfatal):
575 * textprop.c (text_read_only):
576 * undo.c (user_error):
577 * unexmacosx.c (unexec_error):
578 * xterm.c (x_ins_del_lines, x_delete_glyphs):
579 Use _Noreturn rather than NO_RETURN.
580 No need for separate decl merely because of _Noreturn.
581 * sound.c (sound_warning, parse_sound):
582 Remove unnecessary forward decls.
583
f1dd8073
PE
5842012-06-24 Paul Eggert <eggert@cs.ucla.edu>
585
586 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
587 * lisp.h (WAIT_READING_MAX): New macro.
588 * dispnew.c (Fsleep_for, sit_for):
589 * keyboard.c (kbd_buffer_get_event):
590 * process.c (Faccept_process_output):
591 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
592 This improves on the previous patch, which introduced a bug
593 when time_t is unsigned and as wide as intmax_t.
594 See <http://bugs.gnu.org/9000#51>.
595
b82c1755
EZ
5962012-06-23 Eli Zaretskii <eliz@gnu.org>
597
598 * dispnew.c (sit_for, Fsleep_for):
599 * keyboard.c (kbd_buffer_get_event):
600 * process.c (Faccept_process_output): Avoid compiler warnings when
601 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
602
ca300656
JB
6032012-06-23 Juanma Barranquero <lekktu@gmail.com>
604
049ec95b
JB
605 * makefile.w32-in: Update dependencies.
606
ca300656
JB
607 * w32.c (ltime): Add return type and declare static.
608 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
609
db7b8d06
PE
6102012-06-23 Paul Eggert <eggert@cs.ucla.edu>
611
612 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
613 Privately reported by Herbert J. Skuhra.
614 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
615 All uses changed.
616 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
617 not make_lisp_timeval, when the argument is of type EMACS_TIME.
618
0bd8297f
EZ
6192012-06-23 Eli Zaretskii <eliz@gnu.org>
620
96512555
EZ
621 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
622 last argument of make_unibyte_string.
623
0bd8297f
EZ
624 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
625 language ID in the event parameters.
626
627 * w32term.c (w32_read_socket): Put the new keyboard codepage into
628 event.code, not the obscure "character set ID".
629
63def6b6
CY
6302012-06-23 Chong Yidong <cyd@gnu.org>
631
632 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
633
e8a02204
EZ
6342012-06-23 Eli Zaretskii <eliz@gnu.org>
635
388cdec0
EZ
636 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
637 * w32.c (fdutimens): New function.
638
639 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
640
641 * s/ms-w32.h (pselect): Redirect to sys_select.
642
643 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
644
e8a02204
EZ
645 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
646 in the logic of incrementing and decrementing the value of
647 use_relocatable_buffers.
648
d054f3fb
PE
6492012-06-23 Paul Eggert <eggert@cs.ucla.edu>
650
651 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
652 Privately reported by Herbert J. Skuhra.
653 [__FreeBSD__]: Remove "*/" typo after "#include".
654 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
655 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
656 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
657 Don't assume EMACS_TIME and struct timeval are the same type.
658
d35af63c
PE
6592012-06-22 Paul Eggert <eggert@cs.ucla.edu>
660
661 Support higher-resolution time stamps (Bug#9000).
662 The time stamps are only nanosecond-resolution at the C level,
663 since that's the best that any real-world system supports now.
664 But they are picosecond-resolution at the Lisp level, as that's
665 easy, and leaves room for future OS improvements.
666
667 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
668 (LIBES): Use it.
669
670 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
671 Don't get current time unless it's needed.
672
673 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
674 now provides it if it's absent.
675 (start_atimer): Port to higher-res time stamps.
676 Check for time stamp overflow. Don't get current time more
677 often than is needed.
678
679 * buffer.h (struct buffer): Buffer modtime now has high resolution.
680 Include systime.h, not time.h.
681 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
682
683 * dired.c: Include stat-time.h.
684 (Ffile-attributes): File times now have higher resolution.
685
686 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
687 (struct image): Timestamp now has higher resolution.
688
689 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
690 has at least microseconds now. All uses removed.
691 (update_frame, update_single_window, update_window, update_frame_1)
692 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
693
694 * editfns.c (time_overflow): Now extern.
695 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
696 (float-time, Fformat_time_string, Fcurrent_time_string)
697 (Fcurrent_time_zone): Accept and generate higher-resolution
698 time stamps.
699 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
700 (decode_time_components, lisp_seconds_argument): New functions.
701 (make_time): Now static.
702 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
703 Report an error if the time is invalid, rather than having the caller
704 do that.
705
706 * fileio.c: Include <stat-time.h>
707 (Fcopy_file): Copy higher-resolution time stamps.
708 Prefer to set the time stamp via a file descriptor if that works.
709 (Fset_file_times, Finsert_file_contents, Fwrite_region)
710 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
711 (Fvisited_file_modtime, Fset_visited_file_modtime):
712 Support higher-resolution time stamps.
713
714 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
715
716 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
717
718 * image.c (prepare_image_for_display, clear_image_cache)
719 (lookup_image): Port to higer-resolution time stamps.
720
721 * keyboard.c (start_polling, bind_polling_period):
722 Check for time stamp overflow.
723 (read_char, kbd_buffer_get_event, timer_start_idle)
724 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
725 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
726 Port to higher-resolution time stamps. Do not assume time_t is signed.
727 (decode_timer): New function. Timers are now vectors of length 9,
728 not 8, to accommodate the picosecond component.
729 (timer_check_2): Use it.
730
731 * nsterm.m (select_timeout, timeval_subtract): Remove.
732 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
733 as they're a bit more accurate and handle overflow better.
734 (ns_select): Change prototype to be compatible with pselect.
735 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
736 * nsterm.h (ns_select): Adjust prototype.
737
738 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
739 us-resolution time stamps.
740 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
741
742 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
743
744 * lisp.h (time_overflow): New decl.
745 (wait_reading_process_output): First arg is now intmax_t, not int,
746 to accommodate larger waits.
747
748 * process.h (struct Lisp_Process.read_output_delay):
749 Now counts nanoseconds, not microseconds.
750 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
751 EMACS_HAS_USECS.
752 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
753 (wait_reading_process_output):
754 Port to ns-resolution time stamps.
755 (Faccept_process_output, wait_reading_process_output):
756 Check for time stamp overflow. Do not assume time_t is signed.
757 (select_wrapper): Remove; we now use pselect.
758 (Fprocess_attributes): Now generates ns-resolution time stamps.
759
760 * sysdep.c: Include utimens.h. Don't include utime.h
761 or worry about struct utimbuf; gnulib does that for us now.
762 (gettimeofday): Remove; gnulib provides a substitute.
763 (make_timeval): New function.
764 (set_file_times): Now sets ns-resolution time stamps.
765 New arg FD; all uses changed.
766 (time_from_jiffies, ltime_from_jiffies, get_up_time)
767 (system_process_attributes):
768 Now returns ns-resolution time stamp. All uses changed.
769 Check for time stamp overflow.
770
771 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
772 provides a substitute now.
773
774 * systime.h: Include timespec.h rather than sys/time.h and time.h,
775 since it guarantees struct timespec.
776 (EMACS_TIME): Now struct timespec, so that we can support
777 ns-resolution time stamps.
778 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
779 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
780 (EMACS_USECS): Remove.
781 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
782 so multiply the arg by 1000 before storing it.
783 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
784 New macros.
785 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
786 Port to ns-resolution time stamps.
787 (EMACS_TIME_NEG_P): Remove; replaced by....
788 (EMACS_TIME_SIGN): New macro.
789 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
790 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
791 (set_file_times, make_time, lisp_time_argument): Adjust signature.
792 (make_timeval, make_lisp_time, decode_time_components): New decls.
793 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
794 that it mishandled time_t overflow. You can't compare by subtracting!
795 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
796 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
797
798 * term.c: Include <sys/time.h>.
799 (timeval_to_Time): New function, for proper overflow wraparound.
800 (term_mouse_position, term_mouse_click): Use it.
801
802 * undo.c (record_first_change): Support higher-resolution time stamps
803 in the undo buffer.
804 (Fprimitive_undo): Use them when restoring time stamps.
805
806 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
807 (w32_get_internal_run_time):
808 Port to higher-resolution Emacs time stamps.
809 (ltime): Now accepts single 64-bit integer, as that's more convenient
810 for callers.
811
812 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
813
814 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
815 for compatibility with pselect. Support ns-resolution time stamps.
816
817 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
818
819 * xselect.c (wait_for_property_change, x_get_foreign_selection):
820 Check for time stamp overflow, and support ns-resolution time stamps.
821
822 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
823 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
824 (timeval_subtract): Remove; no longer needed.
825 (XTflash, XTring_bell, x_wait_for_event):
826 Port to ns-resolution time stamps. Don't assume time_t is signed.
827
b6a92dfe
CY
8282012-06-22 Chong Yidong <cyd@gnu.org>
829
830 * xdisp.c (x_consider_frame_title): Revert last change.
831
d251c37c
EZ
8322012-06-22 Eli Zaretskii <eliz@gnu.org>
833
834 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
835 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
836 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
837 staticidx goes up to 1597 out of 1600 = 0x640.)
838
f10deafb
PE
8392012-06-20 Paul Eggert <eggert@cs.ucla.edu>
840
841 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
842 Otherwise, the umask might be mistakenly 0 while handling input signals.
843
ec6de1e2
SM
8442012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
845
846 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
847
28be1ada
DA
8482012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
849
850 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
851 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
852 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
853 access to `contents' member of Lisp_Vector objects with AREF and ASET
854 where appropriate.
855
c6bf3022
CY
8562012-06-19 Chong Yidong <cyd@gnu.org>
857
858 * frame.c (delete_frame): When selecting a frame on a different
859 text terminal, do not alter the terminal's top-frame.
860
861 * xdisp.c (format_mode_line_unwind_data): Record the target
862 frame's selected window and its terminal's top-frame.
863 (unwind_format_mode_line): Restore them.
864 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
865 Callers changed.
866 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
867 since tty frames can be explicitly named.
868 (prepare_menu_bars): Likewise.
869
870 * term.c (Ftty_top_frame): New function.
871
defd4196
PE
8722012-06-18 Paul Eggert <eggert@cs.ucla.edu>
873
874 Port byte-code-meter to modern targets.
875 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
876 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 877 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
878 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
879 (METER_1, METER_2): Simplify.
880
1053a871
SM
8812012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
882
883 * data.c (Fdefalias): Return `symbol' (bug#11686).
884
b7e8d081
MR
8852012-06-18 Martin Rudalics <rudalics@gmx.at>
886
887 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
888 gets killed during executing of this function (Bug#11665).
889 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
890 (Vkill_buffer_query_functions): In doc-string say that functions
891 run by this hook should not change the current buffer.
892
7ea2b339
PE
8932012-06-18 Paul Eggert <eggert@cs.ucla.edu>
894
895 Fix recently-introduced process.c problems found by static checking.
896 * process.c (write_queue_push, write_queue_pop, send_process):
897 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
898 (write_queue_pop): Fix pointer signedness problem.
899 (send_process): Remove unused local.
900
96a313a1
CY
9012012-06-17 Chong Yidong <cyd@gnu.org>
902
903 * xdisp.c (redisplay_internal): No need to redisplay terminal
904 frames that are not on top.
905
20ca2e94
TN
9062012-06-17 Troels Nielsen <bn.troels@gmail.com>
907
908 * process.c (make_process): Initialize write_queue.
909 (write_queue_push, write_queue_pop): New functions.
910 (send_process): Use them to maintain correct ordering of process
911 writes (Bug#10815).
912
9a900ca9
PE
9132012-06-17 Paul Eggert <eggert@cs.ucla.edu>
914
310fbfa8
PE
915 * lisp.h (eassert): Assume C89 or later.
916 This removes the need for CHECK.
917 (CHECK): Remove. Its comments about always evaluating its
918 argument were confusing, as 'eassert' typically does not evaluate
919 its argument.
920
27bb1ca4
PE
921 * coding.c (produce_chars): Use ptrdiff_t, not int.
922
9a900ca9
PE
923 * xterm.c (x_draw_underwave): Check for integer overflow.
924 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
925
41b7f8bc 9262012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
927
928 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
929 referenced (Bug#11583).
930
9b0e3eba
AA
9312012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
932
933 Implement wave-style variant of underlining.
934 * dispextern.h (face_underline_type): New enum.
935 (face): Add field for underline type.
936 * nsterm.m (ns_draw_underwave): New function.
937 (ns_draw_text_decoration): Use it.
938 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
939 New functions.
940 (x_draw_glyph_string): Use them.
941 * xfaces.c (Qline, Qwave): New Lisp objects.
942 (check_lface_attrs, merge_face_ref)
1053a871
SM
943 (Finternal_set_lisp_face_attribute, realize_x_face):
944 Handle wave-style underline face attributes.
9b0e3eba
AA
945 * xterm.c (x_draw_underwave): New function.
946 (x_draw_glyph_string): Use it.
947
0fb52f11
JB
9482012-06-16 Juanma Barranquero <lekktu@gmail.com>
949
950 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
951 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
952 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
953 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
954 ($(BLD)/w32select.$(O)): Update dependencies.
955
e5560ff7
AS
9562012-06-16 Andreas Schwab <schwab@linux-m68k.org>
957
958 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
959 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
960 * character.c (_fetch_multibyte_char_p): Remove.
961 * alloc.c: Include "character.h" before "buffer.h".
962 * bidi.c: Likewise.
963 * buffer.c: Likewise.
964 * bytecode.c: Likewise.
965 * callint.c: Likewise.
966 * callproc.c: Likewise.
967 * casefiddle.c: Likewise.
968 * casetab.c: Likewise.
969 * category.c: Likewise.
970 * cmds.c: Likewise.
971 * coding.c: Likewise.
972 * composite.c: Likewise.
973 * dired.c: Likewise.
974 * dispnew.c: Likewise.
975 * doc.c: Likewise.
976 * dosfns.c: Likewise.
977 * editfns.c: Likewise.
978 * emacs.c: Likewise.
979 * fileio.c: Likewise.
980 * filelock.c: Likewise.
981 * font.c: Likewise.
982 * fontset.c: Likewise.
983 * fringe.c: Likewise.
984 * indent.c: Likewise.
985 * insdel.c: Likewise.
986 * intervals.c: Likewise.
987 * keyboard.c: Likewise.
988 * keymap.c: Likewise.
989 * lread.c: Likewise.
990 * macros.c: Likewise.
991 * marker.c: Likewise.
992 * minibuf.c: Likewise.
993 * nsfns.m: Likewise.
994 * nsmenu.m: Likewise.
995 * print.c: Likewise.
996 * process.c: Likewise.
997 * regex.c: Likewise.
998 * region-cache.c: Likewise.
999 * search.c: Likewise.
1000 * syntax.c: Likewise.
1001 * term.c: Likewise.
1002 * textprop.c: Likewise.
1003 * undo.c: Likewise.
1004 * unexsol.c: Likewise.
1005 * w16select.c: Likewise.
1006 * w32fns.c: Likewise.
1007 * w32menu.c: Likewise.
1008 * window.c: Likewise.
1009 * xdisp.c: Likewise.
1010 * xfns.c: Likewise.
1011 * xmenu.c: Likewise.
1012 * xml.c: Likewise.
1013 * xselect.c: Likewise.
1014
2f07e6af
EZ
10152012-06-16 Eli Zaretskii <eliz@gnu.org>
1016
1053a871
SM
1017 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1018 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1019 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1020 row.
1021 (handle_face_prop): Use chunk-relative overlay string index when
1022 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1023 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1024 the rightmost. (Bug#11720)
2f07e6af 1025
29b83cec
AS
10262012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1027
1028 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1029 (CATEGORY_MEMBER): Enforce 1/0 value.
1030 * category.c (_temp_category_set): Remove.
1031
4c5501e9
EZ
10322012-06-16 Eli Zaretskii <eliz@gnu.org>
1033
1034 * window.c (Fdelete_other_windows_internal)
1035 (Fdelete_window_internal): Don't access frame's mouse highlight
1036 info of the initial frame. (Bug#11677)
1037
2b570124
PE
10382012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1039
e93864f9
PE
1040 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1041 Assume USE_2_TAGS_FOR_INTS.
1042 (xreload): Adjust $tagmask width to match recent lisp.h change.
1043
2b570124
PE
1044 Simplify lisp.h in minor ways that should not affect code.
1045 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1046 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1047 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1048 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1049 (INTTYPEBITS): New macro, for clarity.
1050 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1051 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1052 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1053 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1054 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1055
81755f69
JB
10562012-06-13 Juanma Barranquero <lekktu@gmail.com>
1057
1058 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1059
16192a57
GM
10602012-06-13 Glenn Morris <rgm@gnu.org>
1061
1062 * s/bsd-common.h (BSD4_3):
1063 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1064
646b5f55
AS
10652012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1066
1067 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1068 instead of union.
1069 (XLI, XIL): Define.
1053a871
SM
1070 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1071 Use them.
1072 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1073 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1074 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1075 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1076 * frame.c (delete_frame): Remove outdated comment.
1077 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1078 USE_LISP_UNION_TYPE.
1079 (Fw32_unregister_hot_key): Likewise.
1080 (Fw32_toggle_lock_key): Likewise.
1081 * w32menu.c (add_menu_item): Likewise.
1082 (w32_menu_display_help): Use XIL instead of checking
1083 USE_LISP_UNION_TYPE.
1084 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1085 (init_heap): Likewise.
1086 * w32term.c (w32_read_socket): Update comment.
1087
1d3823c9
GM
10882012-06-13 Glenn Morris <rgm@gnu.org>
1089
c62ff706
GM
1090 * s/usg5-4-common.h, src/s/unixware.h:
1091 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1092
1d3823c9
GM
1093 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1094
bfe3e0a2
PE
10952012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1098 * alloc.c (make_number) [!defined make_number]:
1099 Remove, as lisp.h always defines this now.
1100 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1101 (roundup_size): Verify that it is a power of 2.
1102 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1103 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1104 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1105 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1106 USE_LSB_TAG now is always defined to be either 0 or 1.
1107 All uses changed.
1108 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1109 code works fine either way, and efficiency is not a concern here,
1110 as the union type is for debugging, not for production.
1111 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1112 Use an inline function on all platforms when using the union type,
1113 since this is simpler and 'static inline' can be used portably
1114 within Emacs now.
1115 (LISP_INITIALLY_ZERO): New macro.
1116 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1117 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1118
45fa9c0f
GM
11192012-06-12 Glenn Morris <rgm@gnu.org>
1120
b4492cba
GM
1121 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1122
1123 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1124
45fa9c0f
GM
1125 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1126 Move BROKEN_SIGIO to configure.
1127
1128 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1129 Move NO_TERMIO to configure.
1130
0e25d334
CY
11312012-06-12 Chong Yidong <cyd@gnu.org>
1132
1133 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1134 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1135 MagickExportImagePixels is undefined.
1136
43682bb6
PE
11372012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * image.c (imagemagick_load_image): Remove unused label.
1140
a9be7d2b
GM
11412012-06-11 Glenn Morris <rgm@gnu.org>
1142
1143 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1144 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1145 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1146 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1147
3017f87f
SM
11482012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1149
1150 * alloc.c (make_byte_code): New function.
1151 (Fmake_byte_code): Use it. Don't purify here.
1152 * lread.c (read1): Use it as well to avoid extra allocation.
1153
1b9b4cf4
CY
11542012-06-11 Chong Yidong <cyd@gnu.org>
1155
1156 * image.c (imagemagick_load_image): Implement transparency.
1157
95988fcf
AS
11582012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1159
1160 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1161 account for preceding backslashes. (Bug#11663)
1162
cd4eb164
CY
11632012-06-09 Chong Yidong <cyd@gnu.org>
1164
1165 * term.c: Support italics in capable terminals (Bug#9652).
1166 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1167 (turn_on_face): Output using TS_enter_italic_mode if available.
1168 Don't handle unused blinking and alt-charset cases.
1169 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1170 and tty_alt_charset_p cases.
1171 (tty_capable_p, init_tty): Support italics.
1172
1173 * termchar.h (struct tty_display_info): Add field for italics.
1174 Remove unused blink field.
1175
1176 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1177 Handle slant.
1178
1179 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1180 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1181 tty_alt_charset_p. Add tty_italic_p.
1182
ff88beb8
MA
11832012-06-09 Michael Albinus <michael.albinus@gmx.de>
1184
1185 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1186 dbus_type_is_basic if available.
1187 (xd_extract_signed, xd_extract_unsigned): Rename from
1188 extract_signed and extract_unsigned, respectively. Adapt callers.
1189
44286096
CY
11902012-06-09 Chong Yidong <cyd@gnu.org>
1191
1682701f
CY
1192 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1193
44286096
CY
1194 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1195 case (Bug#9752).
1196
d86feb17
PE
11972012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * xdisp.c (vmessage): Treat frame message as multibyte.
1200 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1201 would generate the diagnostic "Making \302\247 buffer-local while
1202 let-bound!".
1203
d5c20fe8
EZ
12042012-06-08 Eli Zaretskii <eliz@gnu.org>
1205
1206 * dispnew.c (showing_window_margins_p): Undo last change, which
1207 was done due to an inadvertent commit.
1208 (adjust_frame_glyphs_for_frame_redisplay): Do call
1209 showing_window_margins_p.
1210
513749ee
SM
12112012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1212
1213 * eval.c (Fmake_var_non_special): New primitive.
1214 (syms_of_eval): Defsubr it.
1215 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1216
d4a8f5c1
JB
12172012-06-08 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1220 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1221
8bbbc977
EZ
12222012-06-08 Eli Zaretskii <eliz@gnu.org>
1223
1224 * alloc.c (allocate_vectorlike): Fix last change.
1225
f3372c87
DA
12262012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1227
1228 Block-based vector allocation of small vectors.
1229 * lisp.h (struct vectorlike_header): New field `nbytes',
1230 adjust comment accordingly.
1231 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1232 to denote vector blocks. Adjust users (live_vector_p,
1233 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1234 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1235 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1236 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1237 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1238 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1239 (roundup_size): New constant.
1240 (struct vector_block): New data type.
1241 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1242 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1243 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1244 (sweep_vectors): New functions.
1245 (allocate_vectorlike): Return `zero_vector' as the only vector of
1246 0 items. Allocate new vector from block if vector size is less than
1247 or equal to VBLOCK_BYTES_MAX.
1248 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1249 (init_alloc_once): Add call to init_vectors.
1250
4f18a4ed
SM
12512012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1252
1253 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1254
86f158bc
PE
12552012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1256
1257 * doprnt.c (doprnt): Truncate multibyte char correctly.
1258 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1259 would mishandle a string argument "Xc" if X was a multibyte
1260 character of length 2: it would truncate after X's first byte
1261 rather than including all of X.
1262
c5cfcbe0
CY
12632012-06-06 Chong Yidong <cyd@gnu.org>
1264
1265 * buffer.c (word_wrap): Doc fix.
1266
c05cf390
PE
12672012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1270
0c3461de
GM
12712012-06-03 Glenn Morris <rgm@gnu.org>
1272
1273 * xdisp.c (tool-bar-style): Doc fix.
1274
c71232db
UM
12752012-06-03 Ulrich Müller <ulm@gentoo.org>
1276
1277 * Makefile.in (PAXCTL): Define.
1278 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1279 binary via PaX flags if the paxctl utility is available.
1280 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1281 Restore PaX flags to their default. (Bug#11398)
1282
383f7350
CY
12832012-06-03 Chong Yidong <cyd@gnu.org>
1284
1285 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1286 buffer (Bug#11226).
1287
5f2c76c6
CY
12882012-06-03 Chong Yidong <cyd@gnu.org>
1289
1290 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1291 (note_mode_line_or_margin_highlight): If there is no help echo,
1292 use mode-line-default-help-echo. Handle the case where the mouse
1293 position is past the end of the mode line string.
1294
1295 * buffer.c (buffer_local_value_1): New function, split from
1296 Fbuffer_local_value; can return Qunbound.
1297 (Fbuffer_local_value): Use it.
1298 (Vmode_line_format): Docstring tweaks.
1299
773d47f6
PE
13002012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * sysdep.c (system_process_attributes): Improve comment.
1303
f2d6a3df
SM
13042012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1305
1306 * keyboard.c: Export real-this-command to Elisp.
1307 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1308 and DEFVAR it. Update all users.
1309
63810350
PE
13102012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1311
7bd5c1f4
PE
1312 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1313
63810350
PE
1314 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1315 Convert pctcpu and pctmem to Lisp float properly.
1316 Let the compiler fold better, as 100.0/0x8000 is exact.
1317
a2821611
AS
13182012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1319
1320 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1321 cons_block.
1322
5fceba1d
PE
13232012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1326
c98ff5dd
DA
13272012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1328
1329 For a 'struct window', replace some Lisp_Object fields to
1330 bitfields where appropriate, remove unused fields.
1331 * window.h (struct window): Remove unused 'last_mark_x' and
1332 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1333 change it's type from Lisp_Object to bitfield.
1334 Change type of 'force_start', 'optional_new_start',
1335 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1336 fields from Lisp_Object to bitfield. Adjust users accordingly.
1337
ca34e0be
PE
13382012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Pacify gcc -Wdouble-precision when using Xaw.
1341 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1342 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1343 Use 'float' consistently, rather than 'float' in most places
1344 and 'double' in a couple of places.
1345
efc00ab1 13462012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1347
1348 * xdisp.c (handle_stop): Detect whether we have overlay strings
1349 loaded by testing it->current.overlay_string_index to be
1350 non-negative, instead of checking whether n_overlay_strings is
1351 positive. (Bug#11587)
1352
efc00ab1 13532012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1354
1355 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1356
1357 * doc.c (Fsubstitute_command_keys): Doc fix.
1358
efc00ab1 13592012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1360
1361 * search.c (search_buffer): Remove calls to
1362 r_alloc_inhibit_buffer_relocation, as it is now called by
1363 maybe_unify_char, which was the cause of relocation of buffer text
1364 in bug#11519.
1365
efc00ab1 13662012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1367
1368 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1369 for the duration of call to load_charset, to avoid problems with
1370 callers of maybe_unify_char that access buffer text through C
1371 pointers.
1372
1373 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1374 decrement the inhibition flag, instead of just setting or
1375 resetting it.
1376
ba93a187
PE
13772012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 Remove obsolete '#define static' cruft.
1380 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1381 This #undef was "temporary" in 2000; it is no longer needed
1382 now that '#define static' has gone away.
1383 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1384 (gray_bitmap_bits): Remove; no longer needed.
1385 All uses replaced with definiens.
1386 * xterm.c: Include "bitmaps/gray.xbm".
1387
9e4bf381
PE
13882012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 Clean up __executable_start, monstartup when --enable-profiling.
1391 The following changes affect the code only when profiling.
1392 * dispnew.c (__executable_start): Rename from safe_bcopy.
1393 Define only on platforms that need it.
1394 * emacs.c: Include <sys/gmon.h> when profiling.
1395 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1396 (__executable_start): Remove decl, since lisp.h does it now.
1397 (safe_bcopy): Remove decl; no longer has that name.
1398 (main): Coalesce #if into single bit of code, for simplicity.
1399 Cast pointers to uintptr_t, since standard libraries want integers
1400 and not pointers.
1401 * lisp.h (__executable_start): New decl.
1402
32d72c2f
GM
14032012-05-31 Glenn Morris <rgm@gnu.org>
1404
1405 * image.c (Fimagemagick_types): Doc fix.
1406
baac5bc7
JM
14072012-05-30 Jim Meyering <meyering@redhat.com>
1408
1409 * callproc.c (Fcall_process_region): Include directory component
1410 in mkstemp error message (Bug#11586).
1411
72cb32cf
PE
14122012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 * alloc.c, lisp.h (make_pure_vector): Now static.
1415
61b108cc
SM
14162012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1417
1418 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1419 Move to byte-run.el.
1420 (Fautoload): Do the hash-doc more carefully.
1421 * data.c (Fdefalias): Purify definition, except for keymaps.
1422 (Qdefun): Move from eval.c.
1423 * lisp.h (Qdefun): Remove.
1424 * lread.c (read1): Tiny simplification.
1425
471fe23d
TN
14262012-05-29 Troels Nielsen <bn.troels@gmail.com>
1427
934f3f58 1428 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1429 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1430 Bug#9642, but explicitly check that the buffer the overlay would
1431 be moved to is live and rearrange lines to make sure that errors
1432 will not put the overlay in an inconsistent state.
1433 (Fdelete_overlay): Cosmetics.
1434
85d0efd1
EZ
14352012-05-28 Eli Zaretskii <eliz@gnu.org>
1436
1437 * w32term.c (my_bring_window_to_top): New function.
1438 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1439 could be different from the original one.
1440 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1441 (Bug#11513)
1442
1443 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1444 by calling BringWindowToTop.
1445
1446 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1447 (WM_EMACS_END): Increase by one.
1448
da92a98c
PE
14492012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1452 This avoids undefined behavior that might cause the eassert
1453 to not catch an out-of-range value.
1454
74d1f848
JB
14552012-05-28 Juanma Barranquero <lekktu@gmail.com>
1456
1457 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1458 Update dependencies.
1459
9e1a06fc
EZ
14602012-05-27 Eli Zaretskii <eliz@gnu.org>
1461
1462 * bidi.c (bidi_mirror_char): Fix last change.
1463
f3dd7312
AS
14642012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1465
1466 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1467 when referring to sectname field in printf format.
1468
81899c91
PE
14692012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1470
57b81a9f
PE
1471 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1472 Only r_alloc_inhibit_buffer_relocation needed to be added;
1473 the others were already declared.
1474
81899c91
PE
1475 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1476 before checking whether it's out of range. Put the check inside
1477 eassert. See
1478 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1479
33017faf 14802012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1481
1482 * callproc.c (Fcall_process): Restore a line that was accidentally
1483 commented out in the 2011-02-13 change (bug#11547).
1484
33017faf 14852012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1486
1487 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1488 defined on ralloc.c.
1489
1490 * buffer.c [REL_ALLOC]: Remove prototypes of
1491 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1492 they are now on lisp.h.
1493
1494 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1495
1496 * search.c (search_buffer): Use it to inhibit relocation of buffer
1497 text while re_search_2 is doing its job, because re_search_2 is
1498 passed C pointers to buffer text. (Bug#11519)
1499
23415acf
EZ
1500 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1501 Update value to 24.
1502
44e27368
EZ
1503 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1504 state after an additional call to move_it_in_display_line_to, keep
1505 the values of it->max_ascent and it->max_descent found for the
1506 entire line.
1507 (pos_visible_p): Revert the comparison against bottom_y to what it
1508 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1509 (Bug#11464)
1510
c1892f11
PE
15112012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 Fix coding-related core dumps with gcc -ftrapv.
1514 The code was computing A - B, where A and B are pointers, and B is
1515 random garbage. This can lead to core dumps on platforms that
1516 have special pointer registers, and it also leads to core dumps on
1517 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1518 A - B only when B is initialized properly.
1519 * coding.c (coding_set_source, coding_set_destination): Return void.
1520 (coding_change_source, coding_change_destinations): New functions,
1521 with the old behaviors of coding_set_source and coding_set_destination.
1522 All callers that need an offset changed to use these new functions.
1523
eb7afdad
GM
15242012-05-26 Glenn Morris <rgm@gnu.org>
1525
1526 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1527
f12fdf02
EZ
15282012-05-26 Eli Zaretskii <eliz@gnu.org>
1529
53a63be6 1530 Extend mouse support on W32 text-mode console.
61b108cc
SM
1531 * xdisp.c (draw_row_with_mouse_face):
1532 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1533
eb3f6f01 1534 * w32console.c: Include window.h.
61b108cc
SM
1535 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1536 New functions.
eb3f6f01
EZ
1537 (initialize_w32_display): Initialize mouse-highlight data.
1538
53a63be6
EZ
1539 * w32inevt.c: Include termchar.h and window.h.
1540 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1541 moves, call note_mouse_highlight. If help_echo changed, call
1542 gen_help_event to produce help-echo message in the echo area.
1543 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1544 highlight info.
1545
4cfd81f6
PE
15462012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 * lread.c (read1): Simplify slightly to avoid an overflow warning
1549 with GCC 4.7.0 on x86-64.
1550
4446092a
EZ
15512012-05-26 Eli Zaretskii <eliz@gnu.org>
1552
1553 * bidi.c (bidi_mirror_char): Revert last change: an int is
1554 definitely wide enough here.
1555
42b2a986 15562012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1557
42b2a986 1558 Fix integer width and related bugs (Bug#9874).
eb106a49 1559 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1560 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1561 (string_bytes, check_sblock, allocate_string_data):
1562 (compact_small_strings, Fmake_bool_vector, make_string)
1563 (make_unibyte_string, make_multibyte_string)
1564 (make_string_from_bytes, make_specified_string)
1565 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1566 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1567 (mark_vectorlike):
1568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1569 (allocate_pseudovector):
1570 Use int, not EMACS_INT, where int is wide enough.
1571 (inhibit_garbage_collection, Fgarbage_collect):
1572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1573 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1574 int might not be wide enough.
1575 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1576 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1577 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1578 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1579 (bidi_level_of_next_char, bidi_move_to_visually_next):
1580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1581 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1582 (Fkill_buffer, Fset_buffer_major_mode)
1583 (advance_to_char_boundary, Fbuffer_swap_text)
1584 (Fset_buffer_multibyte, overlays_at, overlays_in)
1585 (overlay_touches_p, struct sortvec, record_overlay_string)
1586 (overlay_strings, recenter_overlay_lists)
1587 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1588 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1589 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1590 (Foverlay_recenter, last_overlay_modification_hooks_used)
1591 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1593 (validate_region): Omit unnecessary test for b <= e,
1594 since that's guaranteed by the previous test.
d311d28c
PE
1595 (adjust_overlays_for_delete): Avoid pos + length overflow.
1596 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1597 (report_overlay_modification):
1598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1599 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1600 Omit pointer cast, which isn't needed anyway, and doesn't work
1601 after the EMACS_INT -> ptrdiff_t change.
02481186 1602 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1603 * buffer.h: Adjust decls to match defn changes elsewhere.
1604 (struct buffer_text, struct buffer):
1605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1606 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1607 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1608 not int, to avoid needless 32-bit limit on 64-bit hosts.
1609 (exec_byte_code): Use tighter memory-full test, one that checks
1610 for alloca overflow. Don't compute the address of the object just
1611 before an array, as that's not portable. Use EMACS_INT, not
1612 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1613 * callint.c (Fcall_interactively):
1614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1615 * callproc.c (call_process_kill, Fcall_process):
1616 Don't assume pid_t fits into an Emacs fixnum.
1617 (call_process_cleanup, Fcall_process, child_setup):
1618 Don't assume pid_t fits into int.
1619 (call_process_cleanup, Fcall_process, delete_temp_file)
1620 (Fcall_process_region):
1621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1622 (Fcall_process): Simplify handling of volatile integers.
1623 Use int, not EMACS_INT, where int will do.
1624 * casefiddle.c (casify_object, casify_region, operate_on_word)
1625 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1627 (casify_object): Avoid integer overflow when overallocating buffer.
1628 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1629 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1630 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1631 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1632 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1633 integers are now checked earlier. All uses replaced with XINT.
1634 (ccl_driver):
1635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1636 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1637 (ccl_driver, Fregister_code_conversion_map):
1638 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1639 (resolve_symbol_ccl_program): Check that vector header is in range.
1640 Always copy the vector, so that we can check its contents reliably
1641 now rather than having to recheck each instruction as it's being
1642 executed. Check that vector words fit in 'int'.
1643 (ccl_get_compiled_code, Fregister_ccl_program)
1644 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1645 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1646 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1647 contents are in range.
1648 (Fccl_execute_on_string): Check that status is in range.
1649 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1650 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1651 Accept and return EMACS_INT, not int, because callers can pass values
1652 out of 'int' range.
1653 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1654 (multibyte_chars_in_text, parse_str_as_multibyte)
1655 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1656 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1657 (string_escape_byte8, Fget_byte):
1658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1659 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1660 avoid mishandling large integers.
1661 * character.h: Adjust decls to match defn changes elsewhere.
1662 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1663 (Ffind_charset_region):
1664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1665 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1666 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1667 Don't assume fixnum fits in int.
d311d28c
PE
1668 (load_charset_map_from_vector, Fmap_charset_chars):
1669 Remove now-unnecessary CHECK_NATNUMs.
1670 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1671 Don't rely on undefined behavior with signed left shift overflow.
1672 Don't assume unsigned int fits into fixnum, or that fixnum fits
1673 into unsigned int. Don't require max_code to be a valid fixnum;
1674 that's not true for gb10830 4-byte on a 32-bit host. Allow
1675 invalid_code to be a cons, for the same reason. Require code_offset
1676 to be a character. Avoid int overflow if max_char is close
1677 to INT_MAX.
1678 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1679 this is intended anyway and avoids some undefined behavior.
1680 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1681 INDEX_TO_CODE_POINT, as that's what it expects.
1682 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1683 * charset.h (DECODE_CHAR): Return int, not unsigned;
1684 this is what was intended anyway, and it avoids undefined behavior.
1685 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1686 integer-overflow issues.
1687 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1688 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1689 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1690 * chartab.c (Fmake_char_table, Fset_char_table_range)
1691 (uniprop_get_decoder, uniprop_get_encoder):
1692 Don't assume fixnum fits in int.
1693 * cmds.c (move_point): New function, that does the gist of
1694 Fforward_char and Fbackward_char, but does so while checking
1695 for integer overflow more accurately.
c96e5d6a 1696 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1697 (Fforward_line, Fend_of_line, internal_self_insert)
1698 (internal_self_insert):
1699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1700 Fix a FIXME, by checking for integer overflow when calculating
1701 target_clm and actual_clm.
1702 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1703 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1704 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1705 (coding_alloc_by_making_gap, alloc_destination)
1706 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1707 (encode_coding_utf_16, detect_coding_emacs_mule)
1708 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1709 (detect_coding_iso_2022, decode_coding_iso_2022)
1710 (encode_invocation_designation, encode_designation_at_bol)
1711 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1712 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1713 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1714 (encode_coding_ccl, encode_coding_raw_text)
1715 (detect_coding_charset, decode_coding_charset)
1716 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1717 (produce_composition, produce_charset, produce_annotation)
1718 (decode_coding, handle_composition_annotation)
1719 (handle_charset_annotation, consume_chars, decode_coding_gap)
1720 (decode_coding_object, encode_coding_object, detect_coding_system)
1721 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1722 (code_convert_region, code_convert_string)
8f50130c
PE
1723 (Fdefine_coding_system_internal)
1724 (coding_set_source, coding_set_destination):
d311d28c
PE
1725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1726 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1727 (Fdefine_coding_system_internal):
1728 Don't assume fixnums fit in int.
1729 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1730 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1731 (Funencodable_char_position, Fcheck_coding_systems_region)
1732 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1734 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1735 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1736 Don't access memory outside of the args array.
d311d28c 1737 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1738 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1739 result of ENCODE_CHAR.
d311d28c
PE
1740 * coding.h: Adjust decls to match defn changes elsewhere.
1741 (struct coding_system):
1742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1743 * composite.c (get_composition_id, find_composition)
1744 (run_composition_function, update_compositions)
1745 (compose_text, composition_gstring_put_cache)
1746 (composition_gstring_p, composition_gstring_width)
1747 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1748 (composition_compute_stop_pos, composition_reseat_it)
1749 (composition_update_it, struct position_record)
1750 (find_automatic_composition, composition_adjust_point)
1751 (Fcomposition_get_gstring, Ffind_composition_internal):
1752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1753 (update_compositions):
1754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1755 * composite.h: Adjust decls to match defn changes elsewhere.
1756 (struct composition):
1757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1758 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1759 Do not attempt to compute the address of the object just before a
1760 buffer; this is not portable.
1761 (Faref, Faset):
1762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1763 (Faset): Use int, not EMACS_INT, where int is wide enough.
1764 (Fstring_to_number): Don't assume fixnums fit in int.
1765 (Frem): Don't assume arg is nonnegative.
1766 * dbusbind.c (xd_append_arg): Check for integers out of range.
1767 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1768 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1769 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1770 (xd_get_connection_references): Return ptrdiff_t, not int.
1771 All uses changed.
1772 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1773 (xd_read_message_1):
1774 Use int, not unsigned, where the dbus API uses int.
1775 (Fdbus_message_internal): Don't overflow mtype.
1776 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1777 * dired.c (directory_files_internal, file_name_completion, scmp)
1778 (file_name_completion_stat):
1779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1780 (file_name_completion): Don't overflow matchcount.
1781 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1782 * dispextern.h: Adjust decls to match defn changes elsewhere.
1783 (struct text_pos, struct glyph, struct bidi_saved_info)
1784 (struct bidi_string_data, struct bidi_it, struct composition_it)
1785 (struct it):
1786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1787 (struct display_pos, struct composition_it, struct it):
1788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1789 * dispnew.c (increment_matrix_positions)
1790 (increment_row_positions, mode_line_string)
1791 (marginal_area_string):
1792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1793 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1795 (duration_to_sec_usec): New function, to check for overflow better.
1796 (Fsleep_for, sit_for): Use it.
1797 * doc.c (get_doc_string, store_function_docstring):
1798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1799 (get_doc_string, Fsnarf_documentation):
1800 Use int, not EMACS_INT, where int is wide enough.
1801 (get_doc_string):
1802 Use SAFE_ALLOCA, not alloca.
1803 Check for overflow when converting EMACS_INT to off_t.
1804 * doprnt.c (doprnt):
1805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1806 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1807 Don't assume uid_t fits into fixnum.
1808 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1809 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1810 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1811 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1812 (general_insert_function)
1813 (Finsert_char, make_buffer_string, make_buffer_string_both)
1814 (update_buffer_properties, Fbuffer_substring)
1815 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1816 (Fsubst_char_in_region, check_translation)
1817 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1818 (transpose_markers, Ftranspose_regions):
1819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1820 (clip_to_bounds): Move to lisp.h as an inline function).
1821 (Fconstrain_to_field): Don't assume integers are nonnegative.
1822 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1823 (Fsubst_char_in_region, Fsave_restriction):
1824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1825 (Femacs_pid): Don't assume pid_t fits into fixnum.
1826 (lo_time): Use int, not EMACS_INT, when int suffices.
1827 (lisp_time_argument): Check for usec out of range.
1828 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1829 (Fuser_login_name, Fuser_full_name): Signal an error
1830 if a uid argument is out of range, rather than relying on
1831 undefined behavior.
c8d5c857
PE
1832 (Fformat_time_string): Remove now-unnecessary check.
1833 lisp_time_argument checks for out-of-range usec now.
243e0530 1834 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1835 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1836 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1837 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1838 (init_cmdargs, Fdump_emacs):
1839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1840 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1841 the bottom (typically) 32 bits of the fixnum.
1842 * eval.c (specpdl_size, call_debugger):
1843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1844 (when_entered_debugger, Fbacktrace_debug):
1845 Don't assume fixnum can fit in int.
1846 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1847 the object just before a buffer; this is not portable.
1848 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1849 (grow_specpdl, unbind_to):
1850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1851 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1852 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1853 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1854 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1855 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1857 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1858 (a_write, e_write):
1859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1860 (Fcopy_file, non_regular_nbytes, read_non_regular)
1861 (Finsert_file_contents):
1862 Use int, not EMACS_INT, where int is wide enough.
1863 (READ_BUF_SIZE): Verify that it fits in int.
1864 (Finsert_file_contents): Check that counts are in proper range,
1865 rather than assuming fixnums fit into ptrdiff_t etc.
1866 Don't assume fixnums fit into int.
125b3835 1867 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1868 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1869 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1870 (string_char_to_byte, string_byte_to_char)
1871 (string_make_multibyte, string_to_multibyte)
1872 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1873 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1874 (substring_both, Fdelete, internal_equal, Ffillarray)
1875 (Fclear_string, mapcar1)
1876 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1877 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1878 (larger_vector, make_hash_table, maybe_resize_hash_table)
1879 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1880 (Fmaphash, secure_hash):
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 (concat): Check for string index and length overflow.
1883 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1884 (Frequire):
1885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1886 (larger_vector): New API (vec, incr_min, size_max) replaces old
1887 one (vec, new_size, init). This catches size overflow.
1888 INIT was removed because it was always Qnil.
1889 All callers changed.
1890 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1891 the upper bound on a hash table index size.
1892 (make_hash_table, maybe_resize_hash_table): Use it.
1893 (secure_hash): Computer start_byte and end_byte only after
1894 they're known to be in ptrdiff_t range.
1895 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1896 (Ffont_get_glyphs, Ffont_at):
1897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1898 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1899 (Flist_fonts, Fopen_font):
1900 Don't assume fixnum can fit in int.
1901 (check_gstring): Don't assume index can fit in int.
1902 (font_match_p): Check that fixnum is a character, not a nonnegative
1903 fixnum, since the later code needs to stuff it into an int.
1904 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1905 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1906 conversion overflow issues.
1907 (Fopen_font): Check for integer out of range.
1908 (Ffont_get_glyphs): Don't assume index can fit in int.
1909 * font.h: Adjust decls to match defn changes elsewhere.
1910 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1911 integer overflow.
1912 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1913 printmax_t, where ptrdiff_t is wide enough.
1914 (Finternal_char_font):
1915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1916 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1917 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1918 (Fset_frame_position, x_set_frame_parameters)
1919 (x_set_line_spacing, x_set_border_width)
1920 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1921 Check that fixnums are in proper range for system types.
1922 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1924 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1925 Use SAFE_ALLOCA_LISP, not alloca.
1926 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1927 intptr_t is wide enough.
1928 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1929 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1930 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1931 Check for fixnum out of range.
1932 * ftfont.c (ftfont_list): Don't assume index fits in int.
1933 Check that fixnums are in proper range for system types.
1934 (ftfont_shape_by_flt):
1935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1936 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1938 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1939 Check that fixnums are in proper range for system types.
1940 * gnutls.h: Adjust decls to match defn changes elsewhere.
1941 * gtkutil.c (xg_dialog_run):
1942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1943 (update_frame_tool_bar):
1944 Check that fixnums are in proper range for system types.
1945 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1946 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1947 * indent.c (last_known_column, last_known_column_point):
1948 (current_column_bol_cache):
1949 (skip_invisible, current_column, check_display_width):
1950 (check_display_width, scan_for_column, current_column_1)
1951 (Findent_to, Fcurrent_indentation, position_indentation)
1952 (indented_beyond_p, Fmove_to_column, compute_motion):
1953 (Fcompute_motion, Fvertical_motion):
1954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1955 (last_known_column_modified): Use EMACS_INT, not int.
1956 (check_display_width):
1957 (Fcompute_motion):
1958 Check that fixnums and floats are in proper range for system types.
1959 (compute_motion): Don't assume index or fixnum fits in int.
1960 (compute_motion, Fcompute_motion):
1961 Use int, not EMACS_INT, when it is wide enough.
1962 (vmotion): Omit local var start_hpos that is always 0; that way
1963 we don't need to worry about overflow in expressions involving it.
1964 * indent.h: Adjust decls to match defn changes elsewhere.
1965 (struct position):
1966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1967 Use int, not EMACS_INT, where int is wide enough.
1968 Remove unused members ovstring_chars_done and tab_offset;
1969 all uses removed.
1970 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1971 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1972 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1973 (make_gap, copy_text, insert, insert_and_inherit)
1974 (insert_before_markers, insert_before_markers_and_inherit)
1975 (insert_1, count_combining_before, count_combining_after)
1976 (insert_1_both, insert_from_string)
1977 (insert_from_string_before_markers, insert_from_string_1)
1978 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1979 (adjust_after_replace, adjust_after_insert, replace_range)
1980 (replace_range_2, del_range, del_range_1, del_range_byte)
1981 (del_range_both, del_range_2, modify_region)
1982 (prepare_to_modify_buffer, signal_before_change)
1983 (signal_after_change, Fcombine_after_change_execute):
1984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1985 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1986 (balance_an_interval, split_interval_right, split_interval_left)
1987 (find_interval, next_interval, update_interval)
1988 (adjust_intervals_for_insertion, delete_node, delete_interval)
1989 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1990 (static_offset_intervals, offset_intervals)
1991 (merge_interval_right, merge_interval_left, make_new_interval)
1992 (graft_intervals_into_buffer, temp_set_point_both)
1993 (temp_set_point, set_point, adjust_for_invis_intang)
1994 (set_point_both, move_if_not_intangible, get_property_and_range)
1995 (get_local_map, copy_intervals, copy_intervals_to_string)
1996 (compare_string_intervals, set_intervals_multibyte_1):
1997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1998 * intervals.h: Adjust decls to match defn changes elsewhere.
1999 (struct interval):
2000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2001 * keyboard.c (this_command_key_count, this_single_command_key_start)
2002 (before_command_key_count, before_command_echo_length, echo_now)
2003 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2004 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2005 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2006 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2008 (last_non_minibuf_size, last_point_position, echo_truncate)
2009 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2010 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2011 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2012 (stuff_buffered_input):
2013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2014 (last_auto_save, command_loop_1, read_char):
2015 Use EMACS_INT, not int, to avoid integer overflow.
2016 (record_char): Avoid overflow in total_keys computation.
2017 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2018 * keyboard.h: Adjust decls to match defn changes elsewhere.
2019 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2020 (Fkey_description, Fdescribe_vector, Flookup_key):
2021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2022 (click_position): New function, to check that positions are in range.
2023 (Fcurrent_active_maps):
2024 (describe_command):
2025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2026 (Faccessible_keymaps, Fkey_description):
2027 (preferred_sequence_p):
2028 Don't assume fixnum can fit into int.
2029 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2030 Check for integer overflow in size calculations.
2031 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2032 avoid mishandling large integers.
2033 * lisp.h: Adjust decls to match defn changes elsewhere.
2034 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2035 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2036 (struct Lisp_Marker):
2037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2038 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2039 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2040 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2041 All callers changed.
2042 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2043 Assume the arg has valid form, since it always does.
2044 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2045 unsigned integer system type.
2046 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2047 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2049 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2050 (duration_to_sec_usec): New decl.
2051 * lread.c (read_from_string_index, read_from_string_index_byte)
2052 (read_from_string_limit, readchar, unreadchar, openp)
2053 (read_internal_start, read1, oblookup):
2054 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2055 (Fload, readevalloop, Feval_buffer, Feval_region):
2056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2057 (openp): Check for out-of-range argument to 'access'.
2058 (read1): Use int, not EMACS_INT, where int is wide enough.
2059 Don't assume fixnum fits into int.
6efdadfd 2060 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2061 (read_filtered_event): Use duration_to_sec_usec
2062 to do proper overflow checking on durations.
d311d28c
PE
2063 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2064 in size calculation.
2065 (Fexecute_kbd_macro):
2066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2067 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2068 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2069 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2070 (set_marker_both, set_marker_restricted_both, marker_position)
2071 (marker_byte_position, Fbuffer_has_markers_at):
2072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2073 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2074 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2075 It now merely ensures that the menu is large enough, without
2076 necessarily growing it, as this avoids some integer overflow issues.
2077 All callers changed.
2078 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2080 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2081 Use SAFE_ALLOCA_LISP, not alloca.
2082 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2083 to EMACS_INT. Check that fixnums are in proper range for system types.
2084 * minibuf.c (minibuf_prompt_width, string_to_object)
2085 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2086 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2088 (get_minibuffer, read_minibuf_unwind):
2089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2090 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2091 this simplifies overflow checking. All callers changed.
2092 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2093 (Ftest_completion):
2094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2095 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2096 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2097 Check that fixnums are in proper range for system types.
2098 (Fx_create_frame, Fx_show_tip):
2099 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2100 * nsfont.m (ns_findfonts, nsfont_list_family):
2101 Don't assume fixnum fits in long.
2102 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2104 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2105 wide enough.
17fdb222 2106 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2108 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2109 (PRINTDECLARE, PRINTPREPARE):
2110 (strout, print_string):
2111 (print, print_preprocess, print_check_string_charset_prop)
2112 (print_object):
2113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2114 (PRINTDECLARE):
2115 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2117 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2118 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2119 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2120 (print_error_message): Use SAFE_ALLOCA, not alloca.
2121 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2122 (print_depth, new_backquote_output, print_number_index):
2123 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2124 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2125 (Fset_process_window_size, Fformat_network_address)
2126 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2127 (sigchld_handler):
d311d28c 2128 Check that fixnums are in proper range for system types.
d44287d4 2129 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2130 Check for process-ids out of pid_t range rather than relying on
2131 undefined behavior.
e4d81efc 2132 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2133 (Fformat_network_address, read_process_output, send_process)
2134 (Fprocess_send_region, status_notify):
2135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2136 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2137 (wait_reading_process_output, read_process_output, exec_sentinel):
2138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2139 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2140 (Faccept_process_output): Use duration_to_sec_usec to do proper
2141 overflow checking on durations.
dde14581
PE
2142 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2143 Don't assume pid_t fits in int.
02481186
PE
2144 * process.h (struct Lisp_Process): Members tick and update_tick
2145 are now of type EMACS_INT, not int.
b62b53e8
PE
2146 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2147 configured --with-wide-int.
d311d28c
PE
2148 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2149 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2150 * search.c (looking_at_1, string_match_1):
2151 (fast_string_match, fast_c_string_match_ignore_case)
2152 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2153 (scan_newline, find_before_next_newline, search_command)
2154 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2155 (set_search_regs, wordify):
2156 (Freplace_match):
2157 (Fmatch_data):
2158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2159 (string_match_1, search_buffer, set_search_regs):
2160 (Fmatch_data):
2161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2162 (wordify): Check for overflow in size calculation.
2163 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2164 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2165 Check that fixnums are in proper range for system types.
2166 * sound.c (struct sound_device)
2167 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2169 (Fplay_sound_internal):
2170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2171 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2172 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2173 (Fparse_partial_sexp):
2174 Don't assume fixnums can fit in int.
2175 (struct lisp_parse_state, find_start_pos, find_start_value)
2176 (find_start_value_byte, find_start_begv)
2177 (update_syntax_table, char_quoted, dec_bytepos)
2178 (find_defun_start, prev_char_comend_first, back_comment):
2179 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2180 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2182 (Finternal_describe_syntax_value): Check that match_lisp is a
2183 character, not an integer, since the code stuffs it into int.
2184 (scan_words, scan_sexps_forward):
2185 Check that fixnums are in proper range for system types.
2186 (Fforward_word):
2187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2188 (scan_sexps_forward):
2189 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2190 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2191 * syntax.h: Adjust decls to match defn changes elsewhere.
2192 (struct gl_state_s):
2193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2194 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2195 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2196 * sysdep.c (wait_for_termination_1, wait_for_termination)
2197 (interruptible_wait_for_termination, mkdir):
2198 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2199 (emacs_read, emacs_write):
2200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2201 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2202 and double all fit in int.
d311d28c
PE
2203 * term.c (set_tty_color_mode):
2204 Check that fixnums are in proper range for system types.
2205 * termhooks.h (struct input_event):
2206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2207 * textprop.c (validate_interval_range, interval_of)
2208 (Fadd_text_properties, set_text_properties_1)
2209 (Fremove_text_properties, Fremove_list_of_text_properties)
2210 (Ftext_property_any, Ftext_property_not_all)
2211 (copy_text_properties, text_property_list, extend_property_ranges)
2212 (verify_interval_modification):
2213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2214 (Fnext_single_char_property_change)
2215 (Fprevious_single_char_property_change):
2216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2217 (copy_text_properties):
2218 Check for integer overflow in index calculation.
d311d28c
PE
2219 * undo.c (last_boundary_position, record_point, record_insert)
2220 (record_delete, record_marker_adjustment, record_change)
2221 (record_property_change):
2222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2223 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2225 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2226 (Fx_hide_tip, Fx_file_dialog):
2227 * w32menu.c (set_frame_menubar):
2228 Use ptrdiff_t, not int, for consistency with rest of code.
2229 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2230 (select_window, Fdelete_other_windows_internal)
2231 (window_scroll_pixel_based, window_scroll_line_based)
2232 (Frecenter, Fset_window_configuration):
2233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2234 (Fset_window_hscroll, run_window_configuration_change_hook)
2235 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2236 (Fscroll_other_window, Frecenter):
d311d28c
PE
2237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2238 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2239 Don't assume fixnum fits in int.
2240 (Fset_window_scroll_bars):
2241 Check that fixnums are in proper range for system types.
2242 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2243 (string_pos, c_string_pos, number_of_chars, init_iterator)
2244 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2245 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2246 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2247 (face_before_or_after_it_pos, handle_invisible_prop)
2248 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2249 (display_prop_intangible_p, string_buffer_position_lim)
2250 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2251 (get_overlay_strings_1, get_overlay_strings)
2252 (iterate_out_of_display_property, forward_to_next_line_start)
2253 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2254 (get_next_display_element, set_iterator_to_next)
2255 (get_visually_first_element, compute_stop_pos_backwards)
2256 (handle_stop_backwards, next_element_from_buffer)
2257 (move_it_in_display_line_to, move_it_in_display_line)
2258 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2259 (add_to_log, message_dolog, message_log_check_duplicate)
2260 (message2, message2_nolog, message3, message3_nolog
2261 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2262 (current_message_1, truncate_echo_area, truncate_message_1)
2263 (set_message, set_message_1, store_mode_line_noprop)
2264 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2265 (text_outside_line_unchanged_p, check_point_in_composition)
2266 (reconsider_clip_changes)
2267 (redisplay_internal, set_cursor_from_row, try_scrolling)
2268 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2269 (redisplay_window, find_last_unchanged_at_beg_row)
2270 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2271 (trailing_whitespace_p, find_row_edges, display_line)
2272 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2273 (display_mode_element, store_mode_line_string)
2274 (pint2str, pint2hrstr, decode_mode_spec)
2275 (display_count_lines, display_string, draw_glyphs)
2276 (x_produce_glyphs, x_insert_glyphs)
2277 (rows_from_pos_range, mouse_face_from_buffer_pos)
2278 (fast_find_string_pos, mouse_face_from_string_pos)
2279 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2281 (safe_call, init_from_display_pos, handle_fontified_prop)
2282 (handle_single_display_spec, load_overlay_strings)
2283 (with_echo_area_buffer, setup_echo_area_for_printing)
2284 (display_echo_area, echo_area_display)
2285 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2286 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2287 (redisplay_window, dump_glyph_row, display_mode_line)
2288 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2289 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2291 (handle_single_display_spec, build_desired_tool_bar_string)
2292 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2293 (get_specified_cursor_type):
2294 Check that fixnums are in proper range for system types.
2295 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2296 (Flookup_image_map):
2297 Don't assume fixnums fit in int.
2298 (compare_overlay_entries):
2299 Avoid mishandling comparisons due to subtraction overflow.
2300 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2301 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2302 (handle_tool_bar_click):
2303 Use int, not unsigned, since we prefer signed and the signedness
2304 doesn't matter here.
2305 (get_next_display_element, next_element_from_display_vector):
2306 Use int, not EMACS_INT, when int is wide enough.
2307 (start_hourglass): Use duration_to_sec_usec to do proper
2308 overflow checking on durations.
2309 * xfaces.c (Fbitmap_spec_p):
2310 Check that fixnums are in proper range for system types.
2311 (compare_fonts_by_sort_order):
2312 Avoid mishandling comparisons due to subtraction overflow.
2313 (Fx_family_fonts, realize_basic_faces):
2314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2315 (Fx_family_fonts):
2316 Don't assume fixnum fits in int.
2317 Use SAFE_ALLOCA_LISP, not alloca.
2318 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2319 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2320 (face_at_buffer_position, face_for_overlay_string)
2321 (face_at_string_position):
2322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2323 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2324 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2325 (Fx_show_tip):
2326 Check that fixnums are in proper range for system types.
2327 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2328 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2330 (Fx_change_window_property): Don't assume fixnums fit in int.
2331 * xfont.c (xfont_chars_supported):
2332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2333 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2334 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2336 * xml.c (parse_region):
2337 * xrdb.c (magic_file_p):
2338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2339 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2340 (x_get_local_selection, x_reply_selection_request)
2341 (x_handle_selection_request, wait_for_property_change):
2342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2343 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2344 short is wide enough.
2345 (x_send_client_event): Don't assume fixnum fits in int.
2346 * xterm.c (x_x_to_emacs_modifiers):
2347 Don't assume EMACS_INT overflows nicely into int.
2348 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2349 may come from Lisp.
2350 (handle_one_xevent): NATNUMP can eval its arg twice.
2351 (x_connection_closed):
2352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2353 * xterm.h: Adjust decls to match defn changes elsewhere.
2354 (struct scroll_bar): Use struct vectorlike_header
2355 rather than rolling our own approximation.
2356 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2357
c6574eb5
GM
23582012-05-25 Glenn Morris <rgm@gnu.org>
2359
2360 * lisp.mk (lisp): Update for more files being compiled now.
2361
e8d32c7e
SM
23622012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2363
48def666
SM
2364 * lread.c: Remove `read_pure' which makes no difference.
2365 (read_pure): Remove var.
2366 (unreadpure): Remove function.
2367 (readevalloop): Don't call read_list with -1 flag.
2368 (read1, read_vector): Don't test read_pure any more.
2369 (read_list): Simplify.
2370
e8d32c7e
SM
2371 * fileio.c, character.h: Minor style tweaks.
2372
4b2addb7
DA
23732012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2374
2375 * window.h (clip_changed): Remove useless declaration.
2376
584461b2
JB
23772012-05-22 Juanma Barranquero <lekktu@gmail.com>
2378
2379 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2380 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2381
34374650
PE
23822012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 Remove src/m/*.
2385 This directory predates autoconf and is no longer needed nowadays.
2386 Move its few remaining bits of functionality to where they're needed.
2387 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2388 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2389 * m/template.h: Remove.
2390 * Makefile.in (M_FILE): Remove. All uses removed.
2391 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2392 * lisp.h (USE_LSB_TAG):
2393 * mem-limits.h (EXCEEDS_LISP_PTR):
2394 Use VAL_MAX, not VALBITS, in #if.
2395 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2396 (EMACS_UINT): Define unconditionally now.
2397 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2398 (BITS_PER_EMACS_INT): New constants, replacing
2399 what used to be in config.h, but not useful in #if.
2400 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2401 define them any more.
2402 (VAL_MAX): New macro.
2403 (VALMASK): Use it.
2404 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2405 BITS_PER_EMACS_INT, in #if.
2406 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2407 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2408 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2409 * s/ms-w32.h (DATA_START):
2410 Move here from removed file m/intel386.h.
2411 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2412 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2413
261cb4bb
PE
24142012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2415
2416 Assume C89 or later.
2417 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2418 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2419 (xrealloc):
2420 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2421 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2422 * textprop.c, tparam.c (NULL): Remove.
2423 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2424 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2425 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2426 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2427 * xterm.c (input_signal_count): Assume volatile works.
2428
ff23cd9f
KB
24292012-05-21 Ken Brown <kbrown@cornell.edu>
2430
2431 * xgselect.c (xg_select): Fix first argument in call to 'select'
2432 (bug#11508).
2433
1b170bc6
KB
24342012-05-20 Ken Brown <kbrown@cornell.edu>
2435
2436 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2437 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2438
b2f4d39f
KB
24392012-05-19 Ken Brown <kbrown@cornell.edu>
2440
2441 * xfns.c (x_in_use): Remove `static' qualifier.
2442 * xterm.h (x_in_use): Declare.
2443 * xgselect.c: Include xterm.h.
2444 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2445 and `display_arg' (bug#9754).
2446
003fdae2
PE
24472012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2448
9232a6d9
PE
2449 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2450
003fdae2
PE
2451 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2452 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2453
784b56e2
EZ
24542012-05-18 Eli Zaretskii <eliz@gnu.org>
2455
2456 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2457
2458 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2459 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2460
2461 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2462 reference to image_cache->refcount.
2463 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2464
a0a79cde
JL
24652012-05-17 Juri Linkov <juri@jurta.org>
2466
2467 * search.c (Fword_search_regexp, Fword_search_backward)
2468 (Fword_search_forward, Fword_search_backward_lax)
2469 (Fword_search_forward_lax): Move functions to isearch.el
2470 (bug#10145, bug#11381).
2471
b0572523
PE
24722012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2475
9660f5fc
SM
24762012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2477
2478 * lread.c (init_obarray): Declare Qt and Qnil as special.
2479
4374de83
GM
24802012-05-14 Glenn Morris <rgm@gnu.org>
2481
2482 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2483 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2484
dc44c39a
PE
24852012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2486
078c97cb
PE
2487 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2488
dc44c39a
PE
2489 * unexaix.c: Port to more-recent AIX compilers.
2490 (report_error, report_error_1, make_hdr, copy_sym)
2491 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2492 Make arguments const char *, not char *, to avoid violations of C
2493 standard and to fix some AIX warnings reported by Gilles Pion.
2494
e18afed7 24952012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2496
2497 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2498 already have overlays loaded.
2499 (handle_single_display_spec): Before returning without displaying
2500 fringe bitmap, synchronize the bidi iterator with the main display
2501 iterator, by calling iterate_out_of_display_property.
2502 (iterate_out_of_display_property): Detect buffer iteration by
2503 testing that it->string is a Lisp string.
2504 (get_next_display_element): When the current object is exhausted,
2505 and there's something on it->stack, call set_iterator_to_next to
2506 proceed with what's on the stack, instead of returning zero.
2507 (set_iterator_to_next): If called at the end of a Lisp string,
2508 proceed to consider_string_end without incrementing string
2509 position. Don't increment display vector index past the end of
2510 the display vector. (Bug#11417)
c8fb9dc6
EZ
2511 (pos_visible_p): Don't report a position visible when move_it_to
2512 stopped at the last line of window, which happens to be scanned
2513 backwards by the bidi iteration. (Bug#11464)
ac268e67 2514
e18afed7 25152012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2516
2517 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2518 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2519 are on a TTY, and thus unable to display on the fringes.
2520 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2521 so we need to signal to the caller that this is a "replacing"
2522 display spec. This fixes display when the spec is invalid or we
2523 are on a TTY.
2524
e18afed7 25252012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2526
2527 * unexaix.c (make_hdr): Fix typo in prototype.
2528 This bug broke the build on AIX. Problem reported by Gilles Pion.
2529
9d0a235a
MA
25302012-05-14 Michael Albinus <michael.albinus@gmx.de>
2531
2532 * keyboard.c (kbd_buffer_get_event): Read special events also in
2533 batch mode. (Bug#11415)
2534
9e6b06ed
GM
25352012-05-12 Glenn Morris <rgm@gnu.org>
2536
2537 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2538
c1a1d7a3
EZ
25392012-05-12 Eli Zaretskii <eliz@gnu.org>
2540
2541 * lisp.mk (lisp): Add newcomment.elc.
2542
3fe7cdc8
GM
25432012-05-12 Glenn Morris <rgm@gnu.org>
2544
2545 * Makefile.in (MKDIR_P): New, set by configure.
2546 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2547
53f7d2c0
PE
25482012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 Remove unused function hourglass_started.
2551 * dispextern.h (hourglass_started):
2552 * w32fns.c (hourglass_started):
2553 * xdisp.c (hourglass_started): Remove.
2554
75aafb17
JB
25552012-05-10 Juanma Barranquero <lekktu@gmail.com>
2556
2557 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2558 Update dependencies.
2559
12959e8e
PE
25602012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2561
97107e2e
PE
2562 * xgselect.c (xg_select): Put maxfds+1 into a var.
2563 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2564
12959e8e
PE
2565 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2566
836d29b3
DA
25672012-05-10 Dave Abrahams <dave@boostpro.com>
2568
2569 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2570 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2571
5cb67954
MA
25722012-05-09 Michael Albinus <michael.albinus@gmx.de>
2573
2574 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2575 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2576 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2577 Initialize xd_registered_buses.
2578
3478ec45
PE
25792012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2580
b263a6b0
PE
2581 Untag more efficiently if USE_LSB_TAG.
2582 This is based on a proposal by YAMAMOTO Mitsuharu in
2583 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2584 For an admittedly artificial (nth 8000 longlist) benchmark on
2585 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2586 Emacs's overall text size by 1%.
2587 * lisp.h (XUNTAG): New macro.
2588 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2589 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2590 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2591 * eval.c (Fautoload):
2592 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2593 * frame.h (XFRAME): Use XUNTAG.
2594
3478ec45
PE
2595 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2596 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2597 Remove unportable assumptions about print widths of types like
2598 dbus_uint32_t.
2599 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2600 intptr_t when converting between pointer and integer, to avoid GCC
2601 warnings about wrong width.
2602
666b903b 26032012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2604
2605 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2606 stack for each reader_thread, instead of defaulting to 8MB
2607 determined by the linker. This avoids failures in creating
2608 subprocesses on Windows 7, see the discussion in this thread:
2609 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2610
b120cc17
JC
26112012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2612
2613 Fix up display of the *Minibuf-0* buffer in the mini window.
2614 * keyboard.c (read_char): Don't clear the echo area if there's no
2615 message to clear.
2616 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2617 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2618
9a4b36f8
MA
26192012-05-07 Michael Albinus <michael.albinus@gmx.de>
2620
2621 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2622 batch mode.
2623
e5f9458f
CY
26242012-05-06 Chong Yidong <cyd@gnu.org>
2625
2626 * lisp.mk (lisp): Update.
2627
eceeb5fc 26282012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2629
2630 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2631
71873e2b
SM
26322012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2633
2634 * data.c (PUT_ERROR): New macro.
2635 (syms_of_data): Use it. Add new error type `user-error'.
2636 * undo.c (user_error): New function.
2637 (Fprimitive_undo): Use it.
2638 * print.c (print_error_message): Adjust print style for `user-error'.
2639 * keyboard.c (user_error): New function.
2640 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2641
ab0fa4e4
PE
26422012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 Do not limit current-time-string to years 1000..9999.
2645 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2646 (Fcurrent_time_string): Support any year that is supported by the
2647 underlying localtime representation. Don't use asctime, as it
2648 has undefined behavior for years outside the range -999..9999.
2649
7ed806a7
PE
26502012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2651
2652 Fix race conditions involving setenv, gmtime, localtime, asctime.
2653 Without this fix, interrupts could mess up code that uses these
2654 nonreentrant functions, since setting TZ invalidates existing
2655 tm_zone or tzname values, and since most of these functions return
2656 pointers to static storage.
2657 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2658 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2659 Grow the critical sections to include not just invoking
2660 localtime/gmtime, but also accessing these functions' results
2661 including their tm_zone values if any, and any related TZ setting.
2662 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2663 so that the struct tm is saved in the critical section.
2664 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2665 motivated by the fact that memory allocation needs to be outside
2666 the critical section.
2667
0c16dfed
DA
26682012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2669
2670 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2671 with RESET_INTERVAL.
2672
2673 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2674 Remove duplicated buffer name initialization.
2675
3f83ace8
JM
26762012-05-02 Jim Meyering <jim@meyering.net>
2677
2678 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2679
c7b8541e
JM
2680 * xfns.c (x_window): Use xstrdup (Bug#11375).
2681
90207a15 26822012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2683
2684 * xdisp.c (pos_visible_p): If already at a newline from the
2685 display string before the 'while' loop, don't walk back the glyphs
2686 from it3.glyph_row. Solves assertion violation when the display
2687 string begins with a newline (egg.el). (Bug#11367)
2688
b593d6a9
AH
26892012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2690
2691 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2692 Move to simple.el.
2693
4737362e
GM
26942012-05-01 Glenn Morris <rgm@gnu.org>
2695
99cf43f9
GM
2696 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2697 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2698 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2699 All were removed before 23.1.
2700
9311dcff
GM
2701 * dispnew.c: Remove HAVE_LIBNCURSES test;
2702 it is always true on relevant platforms.
2703
4d5c6349
GM
2704 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2705 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2706
4737362e
GM
2707 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2708
74dd3a6b
AS
27092012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2710
2711 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2712 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2713 Remove.
2714
13c379ee
PE
27152012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2716
2717 Do not avoid creating empty evaporating overlays (Bug#9642).
2718 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2719 That is, do not delete an evaporating overlay if it becomes
2720 empty after its bounds are adjusted to fit within its buffer.
2721 This fix caused other problems, and I'm reverting it until we get
2722 to the bottom of them.
2723
a8e7d6d7 27242012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2725
2726 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2727
a8e7d6d7 27282012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2729
2730 * xdisp.c (pos_visible_p): If the window start position is beyond
2731 ZV, start the display from buffer beginning. Prevents assertion
2732 violation in init_iterator when the minibuffer window is scrolled
2733 via the scroll bar.
2734
2735 * window.c (window_scroll_pixel_based): Likewise.
2736
a8e7d6d7 27372012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2738
2739 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2740
a8e7d6d7 27412012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2742
2743 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2744 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2745
a8e7d6d7 27462012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2747
b593d6a9
AH
2748 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2749 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2750
1c6900d9
EZ
27512012-04-26 Eli Zaretskii <eliz@gnu.org>
2752
4c3fa1d9
EZ
2753 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2754 display element, check also the underlying string or buffer
2755 character. (Bug#11341)
2756
1c6900d9
EZ
2757 * w32menu.c: Include w32heap.h.
2758 (add_menu_item): If the call to AppendMenuW (via
2759 unicode_append_menu) fails, disable Unicode menus only if we are
2760 running on Windows 9X/Me.
2761
42bf8205
AS
27622012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2763
2764 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2765 (xgetint): Add missing shift for LSB tags.
2766
b1bac16e
MR
27672012-04-24 Martin Rudalics <rudalics@gmx.at>
2768
2769 * keyboard.c (read_char): Don't wipe echo area for select window
2770 events: These might get delayed via `mouse-autoselect-window'
2771 (Bug#11304).
2772
d69621cc
JB
27732012-04-24 Juanma Barranquero <lekktu@gmail.com>
2774
2775 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2776 manipulation of :loaded-from data.
2777
02fd101b
JB
27782012-04-23 Juanma Barranquero <lekktu@gmail.com>
2779
2780 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2781 now a cons (bug#11311).
2782
888bec30
PE
27832012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2784
89a438bd
PE
2785 Do not create empty overlays with the evaporate property (Bug#9642).
2786 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2787 if it becomes empty after its bounds are adjusted to fit within
2788 its buffer. Without this fix, in a nonempty buffer (let ((o
2789 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2790 yields an empty overlay that has the evaporate property, which is
2791 not supposed to happen.
2792
1068fe4d
PE
2793 Fix minor GTK3 problems found by static checking.
2794 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2795 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2796 (struct _EmacsFixedClass, emacs_fixed_get_type):
2797 Move decls here from emacsgtkfixed.h, since they needn't be public.
2798 (emacs_fixed_get_type): Now static.
2799 (emacs_fixed_class_init): Omit unused local.
2800 (emacs_fixed_child_type): Remove; unused.
2801 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2802 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2803 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2804 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2805 (EMACS_FIXED_GET_CLASS): Remove; unused.
2806 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2807
888bec30
PE
2808 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2809 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2810
de85e130
PE
28112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2812
d0baac98 2813 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2814 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2815 (__malloc_size_t, __malloc_ptrdiff_t):
2816 Remove. All uses removed, replaced by the definiens if needed,
2817 since we can assume C89 or better now.
2818 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2819 (protect_malloc_state, align, get_contiguous_space)
2820 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2821 (malloc_atfork_handler_child, malloc_enable_thread)
2822 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2823 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2824 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2825 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2826 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2827 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2828 Define using prototypes, not old style.
2829 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2830 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2831 (align): Don't assume that signed integer overflow wraps around.
2832 Omit unused local var.
2833 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2834 (_free_internal_nolock, memalign, mallochook, reallochook):
2835 Omit no-longer-needed casts.
2836 (valloc): Use getpagesize, not __getpagesize.
2837 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2838 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2839
de85e130
PE
2840 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2841
dcbf5805
MA
28422012-04-22 Michael Albinus <michael.albinus@gmx.de>
2843
2844 Move functions from C to Lisp. Make non-blocking method calls
2845 the default. Implement further D-Bus standard interfaces.
2846
2847 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2848 (QCdbus_request_name_allow_replacement)
2849 (QCdbus_request_name_replace_existing)
2850 (QCdbus_request_name_do_not_queue)
2851 (QCdbus_request_name_reply_primary_owner)
2852 (QCdbus_request_name_reply_in_queue)
2853 (QCdbus_request_name_reply_exists)
2854 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2855 (QCdbus_registered_serial, QCdbus_registered_method)
2856 (QCdbus_registered_signal): New Lisp objects.
2857 (XD_DEBUG_MESSAGE): Use sizeof.
2858 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2859 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2860 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2861 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2862 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2863 (xd_signature, xd_append_arg): Allow float for integer types.
2864 (xd_get_connection_references): New function.
b593d6a9
AH
2865 (xd_get_connection_address): Rename from xd_initialize.
2866 Return cached address.
dcbf5805
MA
2867 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2868 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2869 level.
2870 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2871 Return number of refcounts.
dcbf5805
MA
2872 (Fdbus_get_unique_name): Make stronger parameter check.
2873 (Fdbus_message_internal): New defun.
2874 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2875 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2876 (Fdbus_send_signal, Fdbus_register_service)
2877 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2878 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2879 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2880 (Vdbus_compiled_version, Vdbus_runtime_version)
2881 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2882 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2883 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2884 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2885 Adapt docstring.
dcbf5805 2886
52828e02
PE
28872012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2888
da05bc4c
PE
2889 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2890 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2891 Do not assume ptrdiff_t is the same width as 'int'.
2892
52828e02
PE
2893 * alloc.c: Handle unusual debugging option combinations.
2894 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2895 since the two debugging options are incompatible.
2896 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2897 is defined.
2898 (mem_init, mem_insert, mem_insert_fixup):
2899 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2900 (NEED_MEM_INSERT): Remove; no longer needed.
2901
f01769f9
LL
29022012-04-22 Leo Liu <sdl.web@gmail.com>
2903
2904 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2905
5790543d
PE
29062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2907
2908 * sysdep.c [__FreeBSD__]: Minor cleanups.
2909 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2910 Use Emacs indenting style more consistently. Avoid some casts.
2911 Use 'double' consistently rather than mixing 'float' and 'double'.
2912
b91b7e4d
EW
29132012-04-21 Eduard Wiebe <usenet@pusto.de>
2914
b593d6a9
AH
2915 * sysdep.c (list_system_processes, system_process_attributes):
2916 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2917
6114eb15
AS
29182012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2919
2920 * lisp.mk (lisp): Update.
2921
2f38dff7
PE
29222012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2923
2924 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2925 It is never used otherwise.
2926
4ae29f89
SM
29272012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2928
2929 * print.c (print_preprocess): Only check print_depth if print-circle
2930 is nil.
2931 (print_object): Check for cycles even when print-circle is nil and
2932 print-gensym is t, but only check print_depth if print-circle is nil.
2933
f30d612a
CY
29342012-04-20 Chong Yidong <cyd@gnu.org>
2935
2936 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2937 set the status to "failed" and ensure that sentinel is run.
2938
c07a4c0b 29392012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2940
2941 * process.c (Fset_process_inherit_coding_system_flag)
2942 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2943 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2944
c07a4c0b 29452012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2946
2947 * xdisp.c (string_buffer_position_lim): Limit starting position to
2948 BEGV.
2949 (set_cursor_from_row): If called for a mode-line or header-line
2950 row, return zero immediately.
2951 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2952 farther than the first row after the header line, if any.
2953 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2954 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2955
c07a4c0b 29562012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2957
4ae29f89
SM
2958 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2959 (bug#11238).
ad3a2b41 2960
c07a4c0b 29612012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 29622012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2963
2964 configure: new option --enable-gcc-warnings (Bug#11207)
2965 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2966 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2967 (ALL_CFLAGS): Use new macros rather than old.
2968 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2969 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2970 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2971 -Wunused-result, -Wunused-variable. This should go away once
2972 the Emacs and Gnulib regex code is merged.
2973 (xmalloc, xrealloc): Now static.
2974
aba027e8
PE
29752012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 * dired.c (Fsystem_groups): Remove unused local.
2978
e5a36063
GM
29792012-04-17 Glenn Morris <rgm@gnu.org>
2980
2981 * dired.c (Fsystem_users): Doc fix.
2982
316411f0
DA
29832012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2984
2985 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2986 (syms_of_dired): Add them.
2987
9426aba4
PE
29882012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2989
b62a57be
PE
2990 Fix minor alloc.c problems found by static checking.
2991 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2992 New extern decls, to avoid calling undeclared functions.
2993 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2994 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2995 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2996 (NEED_MEM_INSERT): New macro.
2997 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2998 Remove one incorrect comment and fix another.
b62a57be 2999
3539f31f
PE
3000 Fix minor ralloc.c problems found by static checking.
3001 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3002 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3003 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3004 (r_alloc_sbrk): Now static.
3005
a041960a
PE
3006 Improve ralloc.c interface checking.
3007 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3008 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3009 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3010 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3011 [REL_ALLOC]: ... to here, to check interface.
3012 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3013 Remove decls. This fixes an "It stinks!".
3014
9426aba4
PE
3015 * alloc.c (which_symbols): Fix alignment issue / type clash.
3016
d55c12ed
AS
30172012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3018
3019 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3020 (struct Lisp_Misc_Any): Likewise.
3021 (struct Lisp_Free): Likewise.
3022 * alloc.c (union aligned_Lisp_Symbol): Define.
3023 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3024 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3025 (union aligned_Lisp_Misc): Define.
3026 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3027 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3028 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3029
b948ce8b
PE
30302012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3033 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3034 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3035 * s/netbsd.h, s/sol2-6.h:
3036 Remove definition of GC_MARK_STACK, since the default now works.
3037 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3038 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3039 no longer the default.
3040 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3041
35dc09a1 30422012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3043
35dc09a1
GM
3044 * lread.c (lisp_file_lexically_bound_p):
3045 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3046
35dc09a1
GM
30472012-04-14 Eli Zaretskii <eliz@gnu.org>
3048
3049 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3050 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3051
30522012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3053
3054 * nsterm.m (constrainFrameRect): Always constrain when there is only
3055 one screen (Bug#10962).
3056
bcd86815
KB
30572012-04-13 Ken Brown <kbrown@cornell.edu>
3058
3059 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3060
c25df26e
RT
30612012-04-13 Reuben Thomas <rrt@sc3d.org>
3062
3063 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3064
0fc59f1e
DC
30652012-04-11 Daniel Colascione <dancol@dancol.org>
3066
3067 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3068 against is gone. It's better to use vfork now so that when Cygwin
3069 gains a new, working vfork, we use it automatically (bug#10398).
3070
de8c03dc
SM
30712012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3072
3073 * window.c (save_window_save): Obey window-point-insertion-type.
3074
2f097256
GM
30752012-04-11 Glenn Morris <rgm@gnu.org>
3076
3077 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3078
453b951e
SM
30792012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3080
3081 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3082
75f1671a 30832012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3084
3085 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3086 (force_quit_count): New var.
3087 (handle_interrupt): Use it.
3088
2a8ce227
JB
30892012-04-10 Juanma Barranquero <lekktu@gmail.com>
3090
3091 * w32.c (w32_delayed_load): Record the full path of the library
3092 being loaded (bug#10424).
3093
935396c0
GM
30942012-04-09 Glenn Morris <rgm@gnu.org>
3095
05920a43
GM
3096 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3097 not just in the obarray, before snarfing them. (Bug#11036)
3098
935396c0
GM
3099 * Makefile.in ($(leimdir)/leim-list.el):
3100 Pass EMACS rather than BUILT_EMACS.
3101
a18ecafa
TZ
31022012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3103
3104 * process.c (make_process):
3105 * process.h: Add integer `gnutls_handshakes_tried' member to
3106 process struct.
3107
6bbef4e5
JC
3108 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3109 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3110
3111 * gnutls.c (gnutls_log_function2i): Convenience log function.
3112 (emacs_gnutls_read): Use new log functions,
3113 `gnutls_handshakes_tried' process member, and
3114 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3115 attempts per process (connection).
3116
b4d3bc10
CY
31172012-04-09 Chong Yidong <cyd@gnu.org>
3118
3119 * eval.c (Fuser_variable_p, user_variable_p_eh)
3120 (lisp_indirect_variable): Functions deleted.
3121 (Fdefvar): Caller changed.
3122
3123 * callint.c (Finteractive, Fcall_interactively):
3124 * minibuf.c (Fread_variable): Callers changed.
3125
70f4d973
EZ
31262012-04-09 Eli Zaretskii <eliz@gnu.org>
3127
3128 * xdisp.c (set_cursor_from_row): If the display string appears in
3129 the buffer at position that is closer to point than the position
3130 after the display string, display the cursor on the first glyph of
3131 the display string. Fixes cursor display when a 'display' text
3132 property immediately follows invisible text. (Bug#11094)
3133
cb3c2e3e
PE
31342012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3135
3136 composite.c: use 'double' consistently
3137 * composite.c (get_composition_id): Use 'double' consistently
3138 instead of converting 'float' to 'double' and vice versa; this is
3139 easier to understand and avoids a GCC warning.
3140
fd06db5d
GM
31412012-04-09 Glenn Morris <rgm@gnu.org>
3142
50fe702a
GM
3143 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3144 preparation for dumping it with emacs. (Bug#4789)
3145 (leimdir): New variable.
3146 ($(leimdir)/leim-list.el): New rule.
3147 (emacs$(EXEEXT)): Depend on leim-list.el.
3148
fd06db5d
GM
3149 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3150 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3151 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3152
55c131ee
AS
31532012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3154
3155 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3156 proper alignment.
3157
9209588f
JB
31582012-04-07 Juanma Barranquero <lekktu@gmail.com>
3159
3160 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3161 Remove unused local variable.
3162
e3fb2efb
PE
31632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3166 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3167 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3168 objects, as mark_maybe_pointer will catch them otherwise.
3169 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3170 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3171
b5385551
PE
31722012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3173
3174 Fix typo that broke non-Windows builds.
3175 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3176
9078ead6
EZ
31772012-04-07 Eli Zaretskii <eliz@gnu.org>
3178
3179 Support building on MS-Windows with libxml2.
3180
3181 * makefile.w32-in (OBJ2): Add xml.$(O).
3182 (GLOBAL_SOURCES): Add xml.c.
3183 ($(BLD)/xml.$(O)): New dependency list.
3184
3185 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3186 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3187 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3188 [!WINDOWSNT]: New macros.
3189 (init_libxml2_functions, libxml2_loaded_p): New functions.
3190 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3191 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3192 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3193 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3194 linked in).
6bbef4e5
JC
3195 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3196 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3197 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3198
3199 * emacs.c: Don't include libxml/parser.h.
3200 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3201 xmlCleanupParser directly.
3202
3203 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3204
3811fdf3
EZ
32052012-04-07 Eli Zaretskii <eliz@gnu.org>
3206
3207 * indent.c (Fvertical_motion): If there is a display string at
3208 point, use it.vpos to compute how many lines to backtrack after
3209 move_it_to point. (Bug#11133)
3210
2f8e16b2
EZ
32112012-04-06 Eli Zaretskii <eliz@gnu.org>
3212
3213 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3214 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3215 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3216 macros related to unification of CJK characters. For the details,
3217 see the discussion following the message here:
3218 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3219
3d439cd1
CY
32202012-04-04 Chong Yidong <cyd@gnu.org>
3221
3222 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3223
8bc53d00
EZ
32242012-04-01 Eli Zaretskii <eliz@gnu.org>
3225
3226 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3227 instead of alloca. (Bug#11138)
3228
3b0512a3
AS
32292012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3230
3231 * w32menu.c (is_simple_dialog): Properly check lisp types.
3232 (Bug#11141)
3233
8427ddd2
EZ
32342012-03-31 Eli Zaretskii <eliz@gnu.org>
3235
979022ef
EZ
3236 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3237 position we get to after a call to move_it_to fails the
3238 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3239 only if we wind up in a string from display property. (Bug#11063)
3240
a6b1c7cc
EZ
3241 * window.c (Fdelete_other_windows_internal): Invalidate the row
3242 and column information about mouse highlight, so that redisplay
3243 restores it after reallocating the glyph matrices. (Bug#7464)
3244
8427ddd2
EZ
3245 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3246 string comes from a `display' text property, use the buffer
3247 position of that property as if we actually saw that position in
3248 the row's glyphs.
697ba24b
EZ
3249 (move_it_by_lines): Remove the assertion that
3250 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3251 violated when there's a before-string at the beginning of a line.
3252 (Bug#11063)
8427ddd2 3253
65a0a738
EZ
32542012-03-30 Eli Zaretskii <eliz@gnu.org>
3255
3256 * xdisp.c (append_space_for_newline): If the default face was
3257 remapped, use the remapped face for the appended newline.
3258 (extend_face_to_end_of_line): Use the remapped default face for
3259 extending the face to the end of the line.
3260 (display_line): Call extend_face_to_end_of_line when the default
3261 face was remapped. (Bug#11068)
3262
581355cc
EZ
32632012-03-29 Eli Zaretskii <eliz@gnu.org>
3264
3265 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3266
e8fc049f
SM
32672012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3268
3269 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3270
4fb9a543
GM
32712012-03-27 Glenn Morris <rgm@gnu.org>
3272
3273 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3274 Doc fixes.
3275
679910f1
KH
32762012-03-26 Kenichi Handa <handa@m17n.org>
3277
3278 * dispextern.h (struct glyph): Fix previous change. Change the
3279 bit length of glyphless.ch to 25 (Bug#11082).
3280
90d49b7f
CY
32812012-03-26 Chong Yidong <cyd@gnu.org>
3282
3283 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3284 (command_loop_1): Use it; inhibit selection update for
3285 handle-select-window too (Bug#8996).
3286
f514f6f0
FP
32872012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3288
e8fc049f 3289 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3290
bf43fa51
KH
32912012-03-25 Kenichi Handa <handa@m17n.org>
3292
3293 * dispextern.h (struct glyph): Change the bit length of
3294 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3295
8a0c01dd
EZ
32962012-03-24 Eli Zaretskii <eliz@gnu.org>
3297
3298 * s/ms-w32.h (tzname): Include time.h before redirecting to
3299 _tzname. Fixes the MSVC build. (Bug#9960)
3300
7d1c3a76
AS
33012012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3302
8ed79523
AS
3303 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3304 characters.
3305
7d1c3a76
AS
3306 * xterm.c (XTread_socket): Only modify handling_signal if
3307 !SYNC_INPUT. (Bug#11080)
3308
e99a9b8b
EZ
33092012-03-23 Eli Zaretskii <eliz@gnu.org>
3310
3311 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3312 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3313 when fetching a multibyte character consumes more bytes than
3314 CHAR_BYTES returns, due to unification of CJK characters in
3315 string_char. (Bug#11073)
3316
5063c0e1
TN
33172012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3318
3319 * process.c (wait_reading_process_output): Handle pty disconnect
3320 by refraining from sending oneself a SIGCHLD (bug#10933).
3321
9f851fbd
CY
33222012-03-22 Chong Yidong <cyd@gnu.org>
3323
3324 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3325
5063c0e1 3326 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3327 Mark string as coming from a prefix property.
3328 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3329 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3330
fb5b8aca
CY
33312012-03-21 Chong Yidong <cyd@gnu.org>
3332
3333 * xfaces.c (Vface_remapping_alist): Doc fix.
3334
62356a1b
EZ
33352012-03-20 Eli Zaretskii <eliz@gnu.org>
3336
3337 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3338 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3339 Doc fixes.
62356a1b 3340
025de85b
CY
33412012-03-20 Chong Yidong <cyd@gnu.org>
3342
3343 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3344 to reflect default non-nil value of redisplay-dont-pause.
3345
4827f94e
KH
33462012-03-19 Kenichi Handa <handa@m17n.org>
3347
3348 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3349 it fit in a valid range (Bug#11003).
3350
e50a24a2
EZ
33512012-03-18 Eli Zaretskii <eliz@gnu.org>
3352
3353 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3354 that is not from display property, accept the row as a "cursor
3355 row" if one of the string's character has a non-nil `cursor'
3356 property. Fixes cursor positioning when there are newlines in
3357 overlay strings, e.g. in icomplete.el. (Bug#11035)
3358
9af5ed87
PE
33592012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3362
d1f55f16
CY
33632012-03-12 Chong Yidong <cyd@gnu.org>
3364
3365 * eval.c (inhibit_lisp_code): Rename from
3366 inhibit_window_configuration_change_hook; move from window.c.
3367
3368 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3369 * window.c (run_window_configuration_change_hook)
3370 (syms_of_window): Callers changed.
3371
66c5eebd
CY
33722012-03-11 Chong Yidong <cyd@gnu.org>
3373
413df973
CY
3374 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3375
66c5eebd
CY
3376 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3377
1de11f56
CY
33782012-03-10 Chong Yidong <cyd@gnu.org>
3379
3380 * frame.c (other_visible_frames): Don't assume the selected frame
3381 is visible (Bug#10955).
3382
cae07000
SM
33832012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3384
3385 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3386
89c94350
JD
33872012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3388
3389 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3390 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3391 zero (Bug#10954).
3392
999dd333
GM
33932012-03-03 Glenn Morris <rgm@gnu.org>
3394
01a6dcc8 3395 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3396
de0100f2
EZ
33972012-03-02 Eli Zaretskii <eliz@gnu.org>
3398
3399 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3400 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3401 (redisplay_window, next_element_from_string): Fix typos in
3402 comments.
3e441275
EZ
3403 (redisplay_window): Pass to move_it_vertically the margin in
3404 pixels, not in screen lines.
de0100f2 3405
96a72ee9
GM
34062012-03-02 Glenn Morris <rgm@gnu.org>
3407
3408 * buffer.c (buffer-list-update-hook): Doc fix.
3409
312508d7
EZ
34102012-02-29 Eli Zaretskii <eliz@gnu.org>
3411
3412 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3413 push_it before setting up the iterator for the first overlay
3414 string, even if we have an empty string loaded.
3415 (next_overlay_string): If there's an empty string on the iterator
3416 stack, pop the stack. (Bug#10903)
3417
27f3c637
PE
34182012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3419
3420 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3421 Suggested by Stefan Monnier in
3422 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3423 * alloc.c (widen_to_Lisp_Object): New static function.
3424 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3425 and widening them to Lisp_Objects. This would work even if
3426 USE_LSB_TAG is defined and wide integers are used, which might
3427 happen in a future version of Emacs.
3428
3c9dfce6
CY
34292012-02-25 Chong Yidong <cyd@gnu.org>
3430
fa74b241
CY
3431 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3432 Doc fix.
3433
3c9dfce6
CY
3434 * xselect.c (Fx_selection_exists_p): Doc fix.
3435 (x_clipboard_manager_save_all): Print an informative message
3436 before saving to clipboard manager.
3437
9486df08
CY
34382012-02-24 Chong Yidong <cyd@gnu.org>
3439
3440 * keyboard.c (process_special_events): Handle all X selection
3441 requests in kbd_buffer, not just the next one (Bug#8869).
3442
f01d3321
CY
34432012-02-23 Chong Yidong <cyd@gnu.org>
3444
3445 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3446 call when setting menu-bar-lines and tool-bar-lines parameters.
3447 (unwind_create_frame_1): New helper function.
3448
3449 * window.c (inhibit_window_configuration_change_hook): New var.
3450 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3451 (syms_of_window): Initialize it.
f01d3321 3452
86b847b6
CY
34532012-02-22 Chong Yidong <cyd@gnu.org>
3454
3455 * xterm.c (x_draw_image_relief): Add missing type check for
3456 Vtool_bar_button_margin (Bug#10743).
3457
a59225b1
CY
34582012-02-21 Chong Yidong <cyd@gnu.org>
3459
3460 * fileio.c (Vfile_name_handler_alist): Doc fix.
3461
3462 * buffer.c (Fget_file_buffer): Protect against invalid file
3463 handler return value.
3464
310f5bd4
PE
34652012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3466
cb3a28cc
PE
3467 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3468 when computing $valmask.
3469
310f5bd4
PE
3470 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3471 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3472 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3473 It's useless in that case, and it can cause problems on hosts
3474 that allocate halves of EMACS_INT values separately.
3475 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3476 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3477 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3478 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3479 it avoids undefined behavior on hosts where shifting right by more
3480 than the word width has undefined behavior.
3481
2375c96a
CY
34822012-02-19 Chong Yidong <cyd@gnu.org>
3483
3484 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3485 (Funhandled_file_name_directory, Ffile_name_as_directory)
3486 (Fdirectory_file_name, Fexpand_file_name)
3487 (Fsubstitute_in_file_name): Protect against invalid file handler
3488 return values (Bug#10845).
3489
3eb49e71
EZ
34902012-02-18 Eli Zaretskii <eliz@gnu.org>
3491
3492 * .gdbinit (pitx): Fix incorrect references to fields of the
3493 iterator stack.
3494
7b926f3f
CY
34952012-02-17 Chong Yidong <cyd@gnu.org>
3496
3497 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3498
11273115
PE
34992012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3500
3501 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3502 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3503
c3a70e2b
CY
35042012-02-15 Chong Yidong <cyd@gnu.org>
3505
3506 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3507 marked as special. Also, starting docstrings with * is obsolete.
3508
0ca43699
AS
35092012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3510
3511 * gnutls.c (emacs_gnutls_write): Fix last change.
3512
2e8f3c56
LI
35132012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3514
3515 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3516 send_process.
3517
af70074f
SM
35182012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3519
3520 * keymap.c (Fsingle_key_description): Handle char ranges.
3521
95986d52
CY
35222012-02-12 Chong Yidong <cyd@gnu.org>
3523
afd83bd1
CY
3524 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3525 as that creates a dangerous corner case.
3526
95986d52
CY
3527 * window.c (Fdelete_window_internal): Invalidate the mouse
3528 highlight (Bug#9904).
3529
bd7da63e
GM
35302012-02-12 Glenn Morris <rgm@gnu.org>
3531
3532 * xselect.c (Fx_own_selection_internal)
3533 (Fx_get_selection_internal, Fx_disown_selection_internal)
3534 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3535 * nsselect.m (Fx_own_selection_internal)
3536 (Fx_disown_selection_internal, Fx_selection_exists_p)
3537 (Fx_selection_owner_p, Fx_get_selection_internal):
3538 Sync docs and argument specs with the xselect.c versions.
3539
77abcbc2
LI
35402012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3541
3542 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3543
90b671e2
EZ
35442012-02-11 Eli Zaretskii <eliz@gnu.org>
3545
1c0ca0b7
EZ
3546 * w32select.c (Fx_selection_exists_p): Sync doc string and
3547 argument list with xselect.c. (Bug#10783)
3548
3549 * w16select.c (Fx_selection_exists_p): Sync doc string and
3550 argument list with xselect.c. (Bug#10783)
90b671e2 3551
49241268
GM
35522012-02-10 Glenn Morris <rgm@gnu.org>
3553
3554 * fns.c (Fsecure_hash): Doc fix.
3555
f998bbe7 35562012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3557
3558 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3559
0992bd9c
CY
35602012-02-07 Chong Yidong <cyd@gnu.org>
3561
3562 * buffer.c (Fbuffer_local_variables)
3563 (buffer_lisp_local_variables): Handle unbound vars correctly;
3564 don't let Qunbound leak into Lisp.
3565
af008560
GM
35662012-02-07 Glenn Morris <rgm@gnu.org>
3567
dd605cc4
GM
3568 * image.c (Fimagemagick_types): Doc fix.
3569
af008560
GM
3570 * image.c (imagemagick-render-type): Change it from a lisp object
3571 to an integer. Move the doc here from the lisp manual.
3572 Treat all values not equal to 0 the same.
3573
1449fa1d
CY
35742012-02-06 Chong Yidong <cyd@gnu.org>
3575
3576 * doc.c (store_function_docstring): Avoid applying docstring of
3577 alias to base function (Bug#2603).
3578
3723ec07
AS
35792012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3580
3581 * .gdbinit (pp1, pv1): Remove redundant defines.
3582 (pr): Use pp.
3583
79c1cc1e
CY
35842012-02-04 Chong Yidong <cyd@gnu.org>
3585
3586 * nsterm.m: Declare a global (Bug#10694).
3587
d7f29f8e
EZ
35882012-02-04 Eli Zaretskii <eliz@gnu.org>
3589
cae07000
SM
3590 * w32.c (get_emacs_configuration_options):
3591 Include --enable-checking, if specified, in the return value.
d7f29f8e 3592
3b95a6f9
MR
35932012-02-04 Martin Rudalics <rudalics@gmx.at>
3594
3595 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3596 after rounding frame sizes. (Bug#9723)
3597
d6fa96a6
EZ
35982012-02-04 Eli Zaretskii <eliz@gnu.org>
3599
3600 * keyboard.c (adjust_point_for_property): Don't position point
3601 before BEGV. (Bug#10696)
3602
df0b2940
PE
36032012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3604
3605 Handle overflow when computing char display width (Bug#9496).
3606 * character.c (char_width): Return EMACS_INT, not int.
3607 (char_width, c_string_width): Check for overflow when
3608 computing the width; this is possible now that individual
3609 characters can have unbounded width. Problem introduced
3610 by merge from Emacs 23 on 2012-01-19.
3611
6bee44d6
MA
36122012-02-02 Michael Albinus <michael.albinus@gmx.de>
3613
3614 * dbusbind.c (Fdbus_register_method): Mention the return value
3615 :ignore in the docstring.
3616
44f92739
GM
36172012-02-02 Glenn Morris <rgm@gnu.org>
3618
1b9f60cc
GM
3619 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3620
44f92739
GM
3621 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3622 Unconditionally set to t. (Bug#10673)
3623 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3624 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3625 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3626
c5d3843c
KH
36272012-02-02 Kenichi Handa <handa@m17n.org>
3628
3629 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3630 0, do not call append_composite_glyph.
3631
159462d4 36322012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3633
3634 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3635 NULL (Bug#6988).
3636 (x_produce_glyphs): If the component of a composition is a null
3637 string, set it->pixel_width to 1 to avoid zero-width glyph.
3638
78cef877
EZ
36392012-02-01 Eli Zaretskii <eliz@gnu.org>
3640
3641 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3642 first 2 arguments are identical. This makes inserting large
3643 output from a subprocess an order of magnitude faster on
3644 MS-Windows, where all sbrk'ed memory is always contiguous.
3645
97897668
GM
36462012-01-31 Glenn Morris <rgm@gnu.org>
3647
3648 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3649 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3650 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3651
31fd3586
GM
36522012-01-29 Glenn Morris <rgm@gnu.org>
3653
3654 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3655
0e24a8b2
CY
36562012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3657
3658 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3659
cc0adcb0
CY
36602012-01-28 Chong Yidong <cyd@gnu.org>
3661
3662 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3663
acc28cb9
CY
36642012-01-26 Chong Yidong <cyd@gnu.org>
3665
9c69cfb7
CY
3666 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3667
acc28cb9
CY
3668 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3669 repeat counts (Bug#10507).
3670
48da7392
GM
36712012-01-26 Glenn Morris <rgm@gnu.org>
3672
3673 * lread.c (syms_of_lread): Doc fix.
3674
14af5f7f
CY
36752012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3676
3677 * coding.c (encode_designation_at_bol): Change return value to
3678 EMACS_INT.
3679
0b21c100
CY
36802012-01-25 Chong Yidong <cyd@gnu.org>
3681
3682 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3683
3c2907f7
CY
36842012-01-21 Chong Yidong <cyd@gnu.org>
3685
3686 * floatfns.c (Fcopysign): Make the second argument non-optional,
3687 since nil is not allowed anyway.
3688
959ad23f
AS
36892012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3690
3691 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3692 (send_process): Likewise.
3693
34a02f46
MR
36942012-01-19 Martin Rudalics <rudalics@gmx.at>
3695
3696 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3697 (Vwindow_persistent_parameters): Do not use Qstate.
3698 Rewrite doc-strings.
34a02f46 3699
1259009a 37002012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3701
3702 * character.c (char_width): New function.
70d4fdf6
GM
3703 (Fchar_width, c_string_width, lisp_string_width):
3704 Use char_width (Bug#9496).
25ed9e61 3705
6a6ee00d
MR
37062012-01-16 Martin Rudalics <rudalics@gmx.at>
3707
3708 * window.c (Vwindow_persistent_parameters): New variable.
3709 (Fset_window_configuration, save_window_save): Handle persistent
3710 window parameters.
3711
c85efaf7
EZ
37122012-01-14 Eli Zaretskii <eliz@gnu.org>
3713
3714 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3715 thrashing the stack of the thread. (Bug#9087)
3716
5944709e
PE
37172012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3718
3719 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3720
e71f5d99
EZ
37212012-01-11 Eli Zaretskii <eliz@gnu.org>
3722
3723 * xdisp.c (rows_from_pos_range): Handle the case where the
3724 highlight ends on a newline. (Bug#10464)
3725 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3726 he end column for display of highlight that ends on a newline
3727 before a R2L line.
3728
ce316182
GM
37292012-01-11 Glenn Morris <rgm@gnu.org>
3730
3731 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3732 from load-path also when installation-directory is nil. (Bug#10208)
3733
5b43da69
GM
37342012-01-10 Glenn Morris <rgm@gnu.org>
3735
74cc8ff9
GM
3736 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3737
7d8d6e4e
GM
3738 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3739 Update template values to be closer to their typical values these days.
5b43da69 3740
a0db8d43
EZ
37412012-01-09 Eli Zaretskii <eliz@gnu.org>
3742
3743 * xdisp.c (rows_from_pos_range): Accept additional argument
3744 DISP_STRING, and accept any glyph in a row whose object is that
3745 string as eligible for mouse highlight. Fixes mouse highlight of
3746 display strings from overlays. (Bug#10464)
3747
9a0115ab 37482012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3749
b9110d6a 3750 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3751 * fileio.c (auto_saving_dir_umask): New static var.
3752 (Fmake_directory_internal): Use it.
3753 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3754 creating the directory. The old code temporarily assigns
3755 too-generous permissions to the directory.
3756 (do_auto_save_eh): Clear it.
b9110d6a 3757 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3758 that the var is always cleared.
3759
6c1bd3f3
EZ
37602012-01-07 Eli Zaretskii <eliz@gnu.org>
3761
3762 * search.c (scan_buffer): Pass character positions to
3763 know_region_cache, not byte positions. (Bug#6540)
3764
069d2b50
L
37652012-01-07 LynX <_LynX@bk.ru> (tiny change)
3766
3767 * w32.c (sys_rename): Report EXDEV when rename of a directory
3768 fails because the target is on another logical disk. (Bug#10284)
3769
75bf0d33
DB
37702012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3771
3772 * xterm.c (x_embed_request_focus): New function.
3773
3774 * xterm.h: Add prototype.
3775
3776 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3777
1c6e5a32
GM
37782012-01-05 Glenn Morris <rgm@gnu.org>
3779
3780 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3781
651e947e
EZ
37822012-01-01 Eli Zaretskii <eliz@gnu.org>
3783
3784 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3785 Load gnutls_transport_set_lowat only if GnuTLS version is below
3786 2.11.1.
3787 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3788 GnuTLS versions below 2.11.1.
3789
3778cdd8
AL
37902011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3791
3792 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3793 to the doc string advising against its use for altering the way
3794 windows are scrolled.
3795
0e5317f7
KH
37962011-12-28 Kenichi Handa <handa@m17n.org>
3797
3798 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3799 coding-system ASCII compatible only when it does not produce BOM
3800 on encoding (Bug#10383).
3801
93d5ca1f
JD
38022011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3803
3804 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3805 can scroll.
3806 (create_and_show_popup_menu): Always use menu_position_func for
3807 Gtk3 (Bug#10361).
3808
ca22b785
AS
38092011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3810
3811 * callint.c (Fcall_interactively): Don't truncate prompt string.
3812
d048e1e6
EZ
38132011-12-23 Eli Zaretskii <eliz@gnu.org>
3814
3815 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3816 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3817 resumed from there (after widening). (Bug#10360)
d048e1e6 3818
5ccaba1f
JD
38192011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3820
3821 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3822
204ee57f
JD
38232011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3824
b81d40f0
JB
3825 * nsterm.m (x_free_frame_resources):
3826 Release f->output_data.ns->miniimage.
204ee57f
JD
3827 (ns_index_color): Fix indentation. Do not retain
3828 color_table->colors[i].
3829
3830 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3831 before returning.
3832
3833 * nsfns.m (x_set_background_color): Assign return value from
3834 ns_index_color to face-background instead of NSColor*.
3835 (ns_implicitly_set_icon_type): Fix indentation.
3836 Change assignment in for loop to comparison.
3837
3838 * emacs.c (ns_pool): New variable.
3839 (main): Assign ns_pool.
3840 (Fkill_emacs): Call ns_release_autorelease_pool.
3841
3842 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3843 autorelease fdesc, release fdAttrs and tdict.
3844 (ns_get_covering_families): Release charset.
3845 (ns_findfonts): Release NSFontDescriptor created with new.
3846 (ns_uni_to_glyphs): Fix indentation.
3847 (setString): Release attrStr before assigning new value.
3848
c803b2b7
JD
38492011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3850
678f4426
JD
3851 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3852 and NS_IMPL_COCOA.
3853 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3854 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3855
cd394be1 38562011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3857
5fecd5fc
JD
3858 * nsterm.m (ns_term_init): Subscribe for notifications
3859 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3860 to method trackingNotification in EmacsMenu.
3861
3862 * nsmenu.m (trackingMenu): New variable.
3771cb17 3863 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3864 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3865 from Aquamacs (Bug#7030).
678f4426
JD
3866
38672011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3868
c803b2b7
JD
3869 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3870 (symbol_to_nsstring): Fix indentation.
3871 (ns_symbol_to_pb): New function.
cae07000
SM
3872 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3873 (Fns_rotate_cut_buffers_internal): Remove.
3874 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3875 Fns_store_cut_buffer_internal.
3876 (ns_get_foreign_selection, Fx_own_selection_internal)
3877 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3878 (Fns_get_selection_internal, Fns_store_selection_internal):
3879 Use ns_symbol_to_pb and check if return value is nil.
3880 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3881 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3882 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3883 renamed to Sns_store_selection_internal.
3884 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3885 and remove this function.
3886 (ns_handle_selection_clear): Remove, never used.
3887 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3888 here.
3889
e1b01a3a
KB
38902011-12-17 Ken Brown <kbrown@cornell.edu>
3891
3892 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3893 GID is unknown (Bug#10257).
3894
2adb6e85
PE
38952011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3898 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3899 which caused a build failure on GNU/Linux IA-64. This problem was
3900 introduced by my 2011-10-07 patch.
3901
d1d7b339
JL
39022011-12-15 Juri Linkov <juri@jurta.org>
3903
3904 * image.c (imagemagick_error): New function. (Bug#10112)
3905 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3906 Use `imagemagick_error' where ImageMagick functions return
3907 `MagickFalse'.
3908 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3909 proper order.
3910
100d5755
KH
39112011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3912
3913 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3914 fill background (Bug#8992).
3915
454592a6
MR
39162011-12-13 Martin Rudalics <rudalics@gmx.at>
3917
3918 * window.c (Vwindow_combination_resize)
3919 (Vwindow_combination_limit): Use t instead of non-nil in
3920 doc-strings.
61d4b438
MR
3921 (Vrecenter_redisplay): Add first sentence of doc-string on
3922 separate line.
53524d93 3923 (Frecenter): Fix doc-string typo.
454592a6 3924
3633e3aa
KH
39252011-12-11 Kenichi Handa <handa@m17n.org>
3926
3927 * coding.c (Funencodable_char_position): Pay attention to the
3928 buffer text relocation (Bug#9389).
3929
7b9d523a 39302011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3931
7b9d523a
JD
3932 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3933 gtk_init (Bug#10100).
3934
b73189c6
EZ
39352011-12-10 Eli Zaretskii <eliz@gnu.org>
3936
3937 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3938 IT->string is nil. (Bug#10263)
3939
f7dfe5d6
JD
39402011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3941
83faebb4
JD
3942 * nsterm.h (x_free_frame_resources): Declare.
3943
f7dfe5d6
JD
3944 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3945 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3946
3947 * nsterm.h (ns_get_defaults_value): Declare.
3948
3949 * nsterm.m (ns_default): Call ns_get_defaults_value.
3950
7cd4e72c
EZ
39512011-12-09 Eli Zaretskii <eliz@gnu.org>
3952
3953 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3954 (Bug#10170)
3955
b34d7317
YM
39562011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3957
3958 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3959 that where the value of an _OBJC_* symbol points to is in the .bss
3960 section (Bug#10240).
3961
76470ad1
KH
39622011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3963
3964 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3965 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3966
745fff94
KH
39672011-12-08 Kenichi Handa <handa@m17n.org>
3968
3969 * ftfont.c (get_adstyle_property): Fix previous change
3970 (Bug#10233).
3971
6e44397c
JB
39722011-12-07 Juanma Barranquero <lekktu@gmail.com>
3973
3974 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3975 dirs from the default value of EMACSLOADPATH (bug#10208).
3976
7efa6272
GM
39772011-12-07 Glenn Morris <rgm@gnu.org>
3978
3979 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3980 installation and source directories as well. (Bug#10208)
3981
f6fc4d87
CY
39822011-12-06 Chong Yidong <cyd@gnu.org>
3983
3984 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3985
2bf26180
GM
39862011-12-06 Glenn Morris <rgm@gnu.org>
3987
3988 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3989 as an error, not just -1. (Bug#10217)
3990
3a6ad4f0
CY
39912011-12-05 Chong Yidong <cyd@gnu.org>
3992
3993 * keyboard.c (process_special_events): New function.
3994 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3995
75a3b399
PE
39962011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 * coding.c (encode_designation_at_bol): Don't use uninitialized
3999 local variable (Bug#9318).
4000
c3c9e25e
KH
40012011-12-05 Kenichi Handa <handa@m17n.org>
4002
4003 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4004 return Qnil (Bug#8046, Bug#10193).
4005
5eb05ea3
KH
40062011-12-05 Kenichi Handa <handa@m17n.org>
4007
4008 * coding.c (encode_designation_at_bol): New args charbuf_end and
4009 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4010 (coding_set_source): Return how many bytes coding->source was
4011 relocated.
4012 (coding_set_destination): Return how many bytes
4013 coding->destination was relocated.
4014 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4015 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4016
40172011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4018
4019 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4020 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4021 macro (Bug#9318).
4022
40232011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4024
4025 The following changes are to fix Bug#9318.
4026
a79703f5 4027 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4028 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4029 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4030 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4031
7dbda6df
JB
40322011-12-05 Juanma Barranquero <lekktu@gmail.com>
4033
4034 * lisp.h (process_quit_flag): Fix external declaration.
4035
6d5eb5b0
SM
40362011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4037
4038 Don't macro-inline non-performance-critical code.
4039 * eval.c (process_quit_flag): New function.
4040 * lisp.h (QUIT): Use it.
4041
a0c3fad0
JD
40422011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4043
4044 * nsfns.m (get_geometry_from_preferences): New function.
4045 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4046
6c07aac2
AS
40472011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4048
4049 * emacs.c (Qkill_emacs): Define.
4050 (syms_of_emacs): Initialize it.
4051 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4052 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4053 (quit_throw_to_read_char): Add parameter `from_signal'.
4054 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4055 * lisp.h (QUIT): Call Fkill_emacs if requested.
4056
c052ead4
JD
40572011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4058
4059 * widget.c (update_wm_hints): Return if wmshell is null.
4060 (widget_update_wm_size_hints): New function.
4061
4062 * widget.h (widget_update_wm_size_hints): Declare.
4063
4064 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4065 widget_update_wm_size_hints (Bug#10104).
4066
9e49252b
EZ
40672011-12-03 Eli Zaretskii <eliz@gnu.org>
4068
4069 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4070 before a newline, prepare the bidi iterator for consuming the
4071 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4072 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4073
02b16839
JL
40742011-12-02 Juri Linkov <juri@jurta.org>
4075
4076 * search.c (Fword_search_regexp): New Lisp function created from
4077 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4078 (Fword_search_backward, Fword_search_forward)
4079 (Fword_search_backward_lax, Fword_search_forward_lax):
4080 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4081 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4082
0068070e
SM
40832011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4084
4085 * fileio.c (Finsert_file_contents): Move after-change-function call
4086 to before the "handled:" label, since all "goto handled" appear in
4087 cases where the *-change-functions have already been properly called
4088 (bug#10117).
4089
3360a3fc
AS
40902011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4091
4092 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4093 waiting for input. (Bug#10169)
4094
73d6c093
EZ
40952011-11-30 Eli Zaretskii <eliz@gnu.org>
4096
4097 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4098 verifies glyph row's hash code--we have just reallocated the
4099 glyphs, so their contents can be complete garbage. (Bug#10164)
4100
febe6bea
JB
41012011-11-30 Juanma Barranquero <lekktu@gmail.com>
4102
4103 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4104
801a4313
EZ
41052011-11-30 Eli Zaretskii <eliz@gnu.org>
4106
4107 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4108 attributes are tested _before_ calling verify_row_hash, to protect
4109 against GCC re-ordering of the tests. (Bug#10164)
4110
2b56b87e
JD
41112011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4112
4113 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4114
4115 * xterm.c (handle_one_xevent): Only set async_visible and friends
4116 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4117 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4118 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4119
dbf31225
PE
41202011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4121
4122 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4123 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4124 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4125 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4126 All uses changed to use GCPRO1 etc.
4127 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4128 Revert to old implementation (i.e., before 2011-03-11).
4129
1305621b
YM
41302011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4131
4132 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4133 of scroll runs so as to avoid assigning disabled bogus rows and
4134 unnecessary graphics copy operations.
4135
8c9afb46
EZ
41362011-11-27 Eli Zaretskii <eliz@gnu.org>
4137
4138 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4139 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4140 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4141 (malloc, free, realloc, calloc): Redirect to e_* only when
4142 compiling Emacs.
4143
4144 * lisp.h (GCTYPEBITS): Move before first use.
4145 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4146 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4147 this macro definition.
4148
4149 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4150 _MSC_VER.
4151
54e9e3bf
JD
41522011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4153
6d5eb5b0
SM
4154 * gtkutil.c (xg_create_frame_widgets):
4155 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4156 present with Gtk+ 2.0.
4157
83aca1cb
PE
41582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4159
4160 * fileio.c (Finsert_file_contents): Undo previous change; see
4161 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4162
5b76caa4
PE
41632011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4164
4165 Rename locals to avoid shadowing.
4166 * fileio.c (Finsert_file_contents):
4167 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4168 * process.c (wait_reading_process_output):
4169 Rename inner 'proc' to 'p' to avoid shadowing.
4170 Indent for consistency with usual Emacs style.
4171
8c535114
EZ
41722011-11-25 Eli Zaretskii <eliz@gnu.org>
4173
4174 * xdisp.c (redisplay_window): If cursor row is not fully visible
4175 after recentering, and scroll-conservatively is set to a large
4176 number, scroll window by a few more lines to make the cursor fully
4177 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4178 (start_display): Don't move to the next line if the display should
4179 start at a newline that is part of a display vector or an overlay
4180 string. (Bug#10119)
8c535114 4181
fa4fdb5c
JL
41822011-11-24 Juri Linkov <juri@jurta.org>
4183
4184 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4185 after the `MagickPingImage' call. (Bug#10112)
4186
90ec88df
CY
41872011-11-23 Chong Yidong <cyd@gnu.org>
4188
4189 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4190
56e2e794
MR
41912011-11-23 Martin Rudalics <rudalics@gmx.at>
4192
4193 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4194 making another buffer current. (Bug#10114)
4195
b6e64c41
GM
41962011-11-23 Glenn Morris <rgm@gnu.org>
4197
4198 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4199
6b21de18
CY
42002011-11-23 Chong Yidong <cyd@gnu.org>
4201
4202 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4203 using it (Bug#5984).
4204
b12cd789
EZ
42052011-11-22 Eli Zaretskii <eliz@gnu.org>
4206
4207 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4208 and header-lines, as they don't have one computed for them.
4209 (Bug#10098)
4210
4211 * .gdbinit (prow): Make displayed values more self-explaining.
4212 Add row's hash code.
4213
261b6fd4
LMI
42142011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4215
4216 * process.c (wait_reading_process_output): Fix asynchrounous
4217 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4218 (wait_reading_process_output): Add comment and URL.
261b6fd4 4219
e7cfd277
JD
42202011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4221
4222 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4223
a9b9b7f5
CY
42242011-11-21 Chong Yidong <cyd@gnu.org>
4225
4226 * window.c (Fnext_window, Fprevious_window): Doc fix.
4227
b0d15b4f
SM
42282011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4229
4230 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4231
fe7a3057
JB
42322011-11-20 Juanma Barranquero <lekktu@gmail.com>
4233
4234 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4235
d2999b1a
MR
42362011-11-20 Martin Rudalics <rudalics@gmx.at>
4237
4238 * window.c (Fset_window_combination_limit): Rename argument
4239 STATUS to LIMIT.
4240 (Vwindow_combination_limit): Remove "status" from doc-string.
4241
d5ff9cd0
AS
42422011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4243
4244 * m/ibms390.h: Remove.
4245 * m/ibms390x.h: Don't include "ibms390.h".
4246
a5bb9bd3
SM
42472011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4248
4249 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4250 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4251
cd1181db
JB
42522011-11-20 Juanma Barranquero <lekktu@gmail.com>
4253
4254 * casetab.c (Fset_case_table):
4255 * charset.c (Fcharset_after): Fix typos.
4256
615a3b8d 42572011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4258
17e845af
PE
4259 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4260 Otherwise, valgrind does not work on some platforms.
4261 Problem reported by Andreas Schwab in
6a0bf43d
PE
4262 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4263 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4264 is set, removing the need for VIRT_ADDRESS_VARIES.
4265 (PURE_P): Use a more-efficient implementation that needs just one
4266 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4267 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4268 to 4 (xorl, subq, cmpq, setbe).
4269 * alloc.c (pure): Always extern now, since that's the
4270 VIRT_ADDR_VARIES behavior.
4271 (PURE_POINTER_P): Use a single comparison, not two, for
4272 consistency with the new puresize.h.
4273 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4274 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4275 Remove VIRT_ADDR_VARIES no longer needed.
4276
f8fe6f96
EZ
42772011-11-19 Eli Zaretskii <eliz@gnu.org>
4278
4279 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4280 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4281 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4282 behave as if the cursor position were at the window margin.
4283
4284 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4285 and the cursor position is out of bounds, behave as if the cursor
4286 position were at the window margin. (Bug#10075)
4287
df05a53c
CY
42882011-11-18 Chong Yidong <cyd@gnu.org>
4289
4290 * window.c (Fwindow_combination_limit): Make first argument
4291 non-optional, since it is meaningless for live windows like the
4292 selected window.
61ccba97 4293
2071918e
DA
42942011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4295
4296 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4297
b50a28de
SM
42982011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4299
4300 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4301 (graft_intervals_into_buffer): Simplify.
4302
015137db
EZ
43032011-11-18 Eli Zaretskii <eliz@gnu.org>
4304
4305 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4306 hash values of the two rows.
4307 (copy_row_except_pointers): Preserve the used[] arrays and the
4308 hash values of the two rows. (Bug#10035)
68c95424 4309 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4310
4311 * xdisp.c (row_hash): New function, body extracted from
4312 compute_line_metrics.
4313 (compute_line_metrics): Call row_hash, instead of computing the
4314 hash code inline.
4315
4316 * dispnew.c (verify_row_hash): Call row_hash for computing the
4317 hash code of a row, instead of duplicating code from xdisp.c.
4318
4319 * dispextern.h (row_hash): Add prototype.
4320
a2addb04
TH
43212011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4322
4323 * frame.c (delete_frame): Don't delete the terminal when the last
4324 X frame is closed if emacs is built with GTK toolkit.
4325
df85d315
JB
43262011-11-17 Juanma Barranquero <lekktu@gmail.com>
4327
4328 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4329
a0c2d0ae
MR
43302011-11-17 Martin Rudalics <rudalics@gmx.at>
4331
4332 * window.c (Vwindow_splits): Rename to
4333 Vwindow_combination_resize. Suggested by Juri Linkov.
4334 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4335 of Vwindow_splits.
4336
58179cce
JB
43372011-11-16 Juanma Barranquero <lekktu@gmail.com>
4338
7877f373
JB
4339 * nsfns.m (Fns_font_name):
4340 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4341
b6f67890
MR
43422011-11-16 Martin Rudalics <rudalics@gmx.at>
4343
4344 * window.h (window): Rename slot "nest" to "combination_limit".
4345 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4346 (Fset_window_nest): Rename to Fset_window_combination_limit.
4347 (Vwindow_nest): Rename to Vwindow_combination_limit.
4348 (recombine_windows, make_parent_window, make_window)
4349 (Fsplit_window_internal, saved_window)
4350 (Fset_window_configuration, save_window_save): Rename all
4351 occurrences of window_nest to window_combination_limit.
4352
c7015153
JB
43532011-11-15 Juanma Barranquero <lekktu@gmail.com>
4354
4355 * image.c (imagemagick_load_image): Fix typo.
4356
322ad6ec
EZ
43572011-11-14 Eli Zaretskii <eliz@gnu.org>
4358
4359 * xdisp.c (display_line): Move the call to
4360 highlight_trailing_whitespace before the call to
4361 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4362 faces of all the glyphs to compute ROW's hash value.
4363 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4364
f067b8ec
JB
43652011-11-14 Juanma Barranquero <lekktu@gmail.com>
4366
4367 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4368 just return (bug#10044).
4369
1e5b2111
EZ
43702011-11-12 Eli Zaretskii <eliz@gnu.org>
4371
7ef3cbd5
EZ
4372 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4373 with user-defined heap size. Bump the default size of the temacs
4374 heap to 27MB, to avoid memory warning when running temacs.
4375 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4376
1e5b2111
EZ
4377 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4378 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4379 (verify_row_hash) [XASSERTS]: New function.
4380 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4381 that the hash value of glyph rows is correct.
1e5b2111 4382
89d61221
MR
43832011-11-12 Martin Rudalics <rudalics@gmx.at>
4384
4385 * window.h (window): Remove splits slot.
4386 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4387 (Fdelete_other_windows_internal, make_parent_window)
4388 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4389 (Fset_window_configuration, save_window_save): Don't deal with
4390 split status of windows.
4391 (saved_window): Remove splits slot.
4392 (Vwindow_splits): Rewrite doc-string.
4393
97f18cc8
JD
43942011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4395
4396 * xfns.c (unwind_create_frame):
4397 * nsfns.m (unwind_create_frame):
4398 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4399 Vframe_list (Bug#9999).
4400
22a648b4
DA
44012011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4402
0b381c7e 4403 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4404
659afede
KH
44052011-11-11 Kenichi Handa <handa@m17n.org>
4406
4407 * callproc.c (Fcall_process): Set the member dst_multibyte of
4408 process_coding.
4409
9ac0394b
KH
44102011-11-11 Johan Bockgård <bojohan@gnu.org>
4411
4412 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4413 avoid a crash (bug#9496).
4414
2fbdc249
CY
44152011-11-09 Chong Yidong <cyd@gnu.org>
4416
4417 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4418 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4419
ac6b1f81
PE
44202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4421
4422 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4423
09db192c
PE
44242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4425
4426 Avoid some portability problems by eschewing 'extern inline' functions.
4427 The trivial performance wins aren't worth the portability hassles; see
4428 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4429 et seq.
4430 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4431 (window_box_width, window_box_left, window_box_left_offset)
4432 (window_box_right, window_box_right_offset): Undo previous change,
4433 by removing the "extern"s.
4434 * intervals.c (adjust_intervals_for_insertion)
4435 (adjust_intervals_for_deletion): Undo previous change,
4436 making these static again.
4437 (offset_intervals, temp_set_point_both, temp_set_point)
4438 (copy_intervals_to_string): No longer inline.
4439 * xdisp.c (window_text_bottom_y, window_box_width)
4440 (window_box_height, window_box_left_offset)
4441 (window_box_right_offset, window_box_left, window_box_right)
4442 (window_box): No longer inline.
4443
105216ed
CY
44442011-11-08 Chong Yidong <cyd@gnu.org>
4445
4446 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4447 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4448 Signal an error if not a live window.
105216ed
CY
4449 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4450 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4451
ae9e237f
JB
44522011-11-07 Juanma Barranquero <lekktu@gmail.com>
4453
4454 * lisp.h (syms_of_abbrev): Remove declaration.
4455 Reported by CHENG Gao <chenggao@royau.me>.
4456
c7aa8333
EZ
44572011-11-07 Eli Zaretskii <eliz@gnu.org>
4458
4459 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4460 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4461 of temacs in GUI mode.
4462
be7f5545
MR
44632011-11-07 Martin Rudalics <rudalics@gmx.at>
4464
4465 * window.h: Declare delete_all_child_windows instead of
4466 delete_all_subwindows.
4467 * window.c (Fwindow_nest, Fset_window_nest)
4468 (Fset_window_new_total, Fset_window_new_normal)
4469 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4470 (delete_all_subwindows): Rename to delete_all_child_windows.
4471 (Fdelete_other_windows_internal, Fset_window_configuration):
4472 Call delete_all_child_windows instead of delete_all_subwindows.
4473 * frame.c (delete_frame): Call delete_all_child_windows instead
4474 of delete_all_subwindows.
4475
ca78dc43
PE
44762011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4479 This is also needed for porting to any host where GC_MARK_STACK is
4480 not GC_MAKE_GCPROS_NOOPS.
4481 (which_symbols): Use it.
4482
a0241d01
KH
44832011-11-07 Kenichi Handa <handa@m17n.org>
4484
4485 * coding.c (coding_set_destination): Check coding->src_pos only
4486 when coding->src_object is a buffer (bug#9910).
4487
4488 * process.c (send_process): Set the member src_multibyte of coding
4489 to 0 (bug#9911) when sending a unibyte text.
4490
4491 * callproc.c (Fcall_process): Set the member src_multibyte of
4492 process_coding to 0 (bug#9912).
4493
a64bfdfa 44942011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4495
4496 * xmenu.c (cleanup_widget_value_tree): New function.
4497 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4498 calling free_menubar_widget_value_tree directly (Bug#9830).
4499
cb41b32a
PE
45002011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4501
4502 Fix some portability problems with 'inline'.
4503 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4504 (window_box_width, window_box_left, window_box_left_offset)
4505 (window_box_right, window_box_right_offset): Declare extern.
4506 Otherwise, these inline functions do not conform to C99 and
4507 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4508 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4509 * intervals.c (adjust_intervals_for_insertion)
4510 (adjust_intervals_for_deletion): Now extern, because otherwise the
4511 extern inline functions 'offset_intervals' couldn't refer to it.
4512 (static_offset_intervals): Remove.
4513 (offset_intervals): Rewrite using the old contents of
4514 static_offset_intervals. The old version didn't conform to C99
4515 because an extern inline function contained a reference to an
4516 identifier with static linkage.
4517
b7041366
AS
45182011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4519
4520 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4521 GC.
4522
88a37c4d
EZ
45232011-11-06 Eli Zaretskii <eliz@gnu.org>
4524
4525 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4526 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4527 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4528 return Qleft_to_right.
4529
49745b39
CY
45302011-11-06 Chong Yidong <cyd@gnu.org>
4531
4532 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4533 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4534 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4535 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4536 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4537 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4538 (Fwindow_vscroll): Doc fix.
4539 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4540 argument, since it makes no sense to pass a live window and for
4541 consistency with window-child.
4542
1f05cd82
CS
45432011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4544
4545 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4546 support MSVC.
4547
22610910
JR
45482011-11-05 Jason Rumney <jasonr@gnu.org>
4549
4550 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4551 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4552 fonts (Bug#6029).
4553 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4554 bitwise arithmetic preventing use of unicode-sip and non-truetype
4555 opentype fonts.
4556
a06776b2
EZ
45572011-11-05 Eli Zaretskii <eliz@gnu.org>
4558
3ad924ba
EZ
4559 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4560 "emacs"-only part.
4561
a06776b2
EZ
4562 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4563 initialization code to keep similarity to xfns.c after changes
4564 from 2011-11-05.
4565
c9e7db78
JD
45662011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4567
a97f8f3f
JD
4568 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4569 (unwind_create_frame): New function (Bug#9943).
4570 (Fx_create_frame): Restructure code to be more similar to the one in
4571 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4572 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4573 Move terminal->reference_count++ just before making the frame official
4574 (Bug#9943).
4575
4576 * nsterm.m (x_free_frame_resources): New function.
4577 (x_destroy_window): Move code to x_free_frame_resources.
4578
c9e7db78 4579 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4580 (Fx_create_frame, x_create_tip_frame):
4581 Move terminal->reference_count++ just before making the frame
75f1671a 4582 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4583 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4584
a6fc3b5c
EZ
45852011-11-05 Eli Zaretskii <eliz@gnu.org>
4586
4587 Support MSVC build with newer versions of Visual Studio.
4588 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4589 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4590 nt/gmake.defs.
4591
4592 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4593 which are not supported by MSVC.
4594 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4595 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4596 bitfields.
4597 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4598 types in bitfields.
4599 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4600
4601 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4602
58179cce 46032011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4604
4605 Support MSVC build with newer versions of Visual Studio.
4606 * w32.c: Don't include w32api.h for MSVC.
4607 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4608
4609 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4610 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4611 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4612 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4613 e_* cousins.
4614 (alloca) [_MSC_VER]: Define to _alloca.
4615
4616 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4617
4618 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4619
a58c13ed
EZ
46202011-11-04 Eli Zaretskii <eliz@gnu.org>
4621
4622 * xdisp.c (note_mouse_highlight): If either of
4623 previous/next-single-property-change returns nil, treat that as
4624 the beginning or the end of the buffer. (Bug#9955)
4625
fe0b6370
JD
46262011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4627
a58c13ed 4628 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4629 label is not null (Bug#9951).
4630 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4631 may be NULL.
4632
89bd5ee1
EZ
46332011-11-04 Eli Zaretskii <eliz@gnu.org>
4634
4635 * window.c (Fwindow_body_size): Mention in the doc string that the
4636 return value is in frame's canonical units. (Bug#9949)
4637
84c3edb9
EZ
46382011-11-03 Eli Zaretskii <eliz@gnu.org>
4639
4e2fb5c7
EZ
4640 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4641
84c3edb9 4642 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4643 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4644 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4645
bc17a887
EZ
46462011-11-01 Eli Zaretskii <eliz@gnu.org>
4647
4648 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4649 Don't stop backward scan on the continuation glyph, even though
4650 its CHARPOS is positive.
6d5eb5b0
SM
4651 (mouse_face_from_buffer_pos, note_mouse_highlight):
4652 Rename cover_string to disp_string.
bc17a887 4653
4ee88440
MR
46542011-11-01 Martin Rudalics <rudalics@gmx.at>
4655
4656 * window.c (temp_output_buffer_show): Don't use
4657 Vtemp_buffer_show_specifiers.
4658 (Vtemp_buffer_show_specifiers): Remove unused variable.
4659
c2ff3c02
EZ
46602011-10-30 Eli Zaretskii <eliz@gnu.org>
4661
4662 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4663 past the beginning of the current glyph matrix.
4664
58179cce 46652011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4666
4667 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4668 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4669 HAVE_GTK3 (Bug#9869).
b77a6a7f 4670
3b574623
JD
4671 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4672 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4673
b77a6a7f
JD
4674 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4675
4676 * xterm.c: Declare x_handle_net_wm_state to return int.
4677 (handle_one_xevent): Check if we are iconified but don't have
4678 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4679 (get_current_wm_state): Return non-zero if not hidden,
4680 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4681 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4682 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4683 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4684
196e41e4
PE
46852011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4686
4687 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4688 so that this new function doesn't get optimized away by a
4689 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4690
021f2e1a
AS
46912011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4692
4693 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4694
8b058d44
EZ
46952011-10-29 Eli Zaretskii <eliz@gnu.org>
4696
4697 Fix the `xbytecode' command.
4698 * .gdbinit (xprintbytestr): New command.
b50a28de 4699 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4700 (xbytecode): Print the byte-code string as well.
4701
4452fb80
EZ
47022011-10-29 Kim Storm <storm@cua.dk>
4703
8b058d44
EZ
4704 * alloc.c (which_symbols): New function.
4705
21b72067
AS
47062011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4707
4708 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4709 line. (Bug#9903)
4710
83ed7b5c
GM
47112011-10-29 Glenn Morris <rgm@gnu.org>
4712
4713 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4714 Not clear what it was for, and it causes various bugs. (Bug#9839)
4715
5a7a728b
EZ
47162011-10-28 Eli Zaretskii <eliz@gnu.org>
4717
4718 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4719 possible random value that matches one of those tested as
4720 condition to clear the mouse face.
4721
d3d0842f
CY
47222011-10-28 Chong Yidong <cyd@gnu.org>
4723
4724 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4725
31b39d13
DN
47262011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4727
4728 * window.c (make_window): Initialize phys_cursor_on_p.
4729
9aba6043
SM
47302011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4731
4732 * lisp.h (struct Lisp_Symbol): Update comments.
4733
c20992f4
JB
47342011-10-28 Juanma Barranquero <lekktu@gmail.com>
4735
4736 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4737
db4f02f2
EZ
47382011-10-28 Eli Zaretskii <eliz@gnu.org>
4739
4740 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4741 <oslsachem@gmail.com> for helping to debug this.
4742
4743 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4744 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4745 (g_b_init_get_glyph_outline_w): New static variables.
4746 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4747 (GetGlyphOutlineW_Proc): New typedefs.
4748 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4749 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4750 New functions.
4751 (w32font_open_internal, compute_metrics):
4752 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4753 instead of calling the "wide" APIs directly.
4754
4755 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4756
4757 * w32.h (syms_of_w32font): Add prototype.
4758
87e68db4
JB
47592011-10-27 Juanma Barranquero <lekktu@gmail.com>
4760
4761 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4762 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4763 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4764 (Fmove_to_window_line): Doc fix.
4765
435c1d67
CY
47662011-10-27 Chong Yidong <cyd@gnu.org>
4767
4768 * process.c (make_process): Set gnutls_state to NULL.
4769
4770 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4771 non-NULL, regardless of GNUTLS_INITSTAGE.
4772 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4773 an error. Set process slots as soon as we allocate them.
4774
4775 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4776
9c6c6f49
CY
47772011-10-27 Chong Yidong <cyd@gnu.org>
4778
9aba6043
SM
4779 * gnutls.c (emacs_gnutls_deinit): New function.
4780 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4781 (Fgnutls_deinit, Fgnutls_boot): Use it.
4782
4783 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4784 (deactivate_process): Call emacs_gnutls_deinit.
4785
657d08d3
JB
47862011-10-27 Juanma Barranquero <lekktu@gmail.com>
4787
4788 * image.c (x_create_x_image_and_pixmap):
4789 * w32.c (sys_rename, w32_delayed_load):
4790 * w32font.c (fill_in_logfont):
4791 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4792
5430d399
JB
47932011-10-26 Juanma Barranquero <lekktu@gmail.com>
4794
4795 * w32fns.c (w32_default_color_map): New function,
4796 extracted from Fw32_default_color_map.
a7ef684b 4797 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4798
fe0055fa
PE
47992011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4800
4801 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4802
e6346438
SM
48032011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4804
4805 * keyboard.c (test_undefined): New function (bug#9751).
4806 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4807
e112cc37
ET
48082011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4809
4810 * sysdep.c (init_sys_modes): Fix the check for the controlling
4811 terminal (Bug#6649).
4812
7b5d6677
EZ
48132011-10-20 Eli Zaretskii <eliz@gnu.org>
4814
4815 * dispextern.h (struct bidi_it): New member next_en_type.
4816
4817 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4818 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4819 current character, check also for next_en_type being WEAK_EN.
4820 (bidi_resolve_weak): Don't enter the expensive loop if the current
4821 position is before next_en_pos. Record the bidi type of the first
4822 non-ET, non-BN character we find, in addition to its position.
4823 (bidi_level_of_next_char): Invalidate next_en_type when
4824 next_en_pos is over-stepped.
4825
7da0b018
PE
48262011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4827
4828 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4829 * editfns.c: Rewrite current-time-zone so that it invokes
4830 the equivalent of (format-time-string "%Z") to get the time zone name.
4831 This fixes a bug when the time zone name contains characters that
4832 need converting from the system time locale to Emacs internal format.
4833 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4834 that patch fixed format-time-string to do the conversion, but
4835 I forgot to fix current-time-zone.
4836 (format_time_string): New function, containing most of
4837 what Fformat_time_string used to contain.
4838 (Fformat_time_string): Rewrite in terms of format_time_string.
4839 This doesn't change this function's behavior.
4840 (current-time-zone): Rewrite to use format_time_string.
4841 This fixes the bug reported by Michael Schierl in
4842 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4843 Jason Rumney's 2007-06-07 change worked around this bug, but
4844 didn't fix it.
4845 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4846
8547b010
EZ
48472011-10-19 Eli Zaretskii <eliz@gnu.org>
4848
4849 * xdisp.c (start_display): If the character at POS is displayed
4850 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4851 (try_window_reusing_current_matrix): If a line ends in a display
4852 vector or the next line starts in a display vector, continue
4853 redrawing the window even though the character position of
4854 start_row was reached.
8547b010
EZ
4855 (Bug#9771, part 2)
4856
4e948d15
CY
48572011-10-18 Chong Yidong <cyd@gnu.org>
4858
4859 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4860 with nobreak-char-display too.
4861
4787455f
EZ
48622011-10-18 Eli Zaretskii <eliz@gnu.org>
4863
4864 Fix part 3 of bug#9771.
4865 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4866 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4867 non-neutral characters if the current character is a paragraph
4868 separator (a.k.a. Newline). This avoids running the same
4869 expensive loop twice, once when we consume the preceding newline
4870 and the other time when the line actually needs to be displayed.
4871 Avoid the loop when we see neutrals on the base embedding level
4872 following a character whose directionality is the same as the
4873 paragraph's. This avoids running the expensive loop when a line
4874 ends in a long sequence of neutrals, like control characters.
4875 Add assertion against STRONG_AL type. Slightly rearrange code
4876 that determines the type of a neutral given the first non-neutral
4877 that follows it.
4878 (bidi_level_of_next_char): Set next_en_pos to zero when
4879 invalidating its info.
4880
2c91f553
EZ
48812011-10-17 Eli Zaretskii <eliz@gnu.org>
4882
4883 * xdisp.c (push_display_prop): Determine whether to record string
4884 or buffer position by IT->string, not by IT->method. Allow
4885 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4886 (move_it_vertically_backward): Don't look for character position
4887 immediately after the newline when in a continuation line.
4888 (Bug#9771, part 1)
2c91f553 4889
c7b08b0d
MR
48902011-10-15 Martin Rudalics <rudalics@gmx.at>
4891
4892 * window.c (coordinates_in_window): Rewrite and delabelize
4893 vertical border check. (Bug#5357) (Bug#9618)
4894
6b02f655
SM
48952011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4896
4897 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4898 errors in XSetWindowBorder (bug#9310).
4899
81d40c92
DA
49002011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4901
4902 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4903 avoid crash when xmalloc overrun checking is enabled.
4904
d4172c3b
EZ
49052011-10-13 Eli Zaretskii <eliz@gnu.org>
4906
4907 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4908 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4909 cursor motion with <left> and <right> arrow keys.
4910
4911 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4912 some callers set that themselves.
4913
b00eea75
EZ
49142011-10-12 Eli Zaretskii <eliz@gnu.org>
4915
4916 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4917 display string and the previous row comes from the same string and
4918 is empty. (Bug#9739) (Bug#9738)
4919
8fe012c4
SM
49202011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4921
4922 * doc.c (get_doc_string): Encode file name (bug#9735).
4923
0074aef2
EZ
49242011-10-12 Eli Zaretskii <eliz@gnu.org>
4925
79beb178
EZ
4926 * bidi.c (bidi_level_of_next_char):
4927 * xdisp.c (get_visually_first_element): Remove old incorrect
4928 comments regarding the Unicode Line Separator character.
4929
0074aef2
EZ
4930 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4931
6e4b3fbe
DA
49322011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4933
4934 * alloc.c (Fgc_status): Do not access beyond zombies array
4935 boundary if nzombies > MAX_ZOMBIES.
4936 * alloc.c (dump_zombies): Add missing format specifier.
4937
0324f3af
PE
49382011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4939
b5525cac
PE
4940 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4941 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4942
0324f3af
PE
4943 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4944 Some packages use them to denote characters with modifiers.
4945
e9b5f888
AS
49462011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4947
4948 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4949 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4950 matching a pp-number. Rename parameter var to var1.
4951
127827c0
SM
49522011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4953
4954 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4955
c8fd3bd0
GM
49562011-10-08 Glenn Morris <rgm@gnu.org>
4957
4958 * callint.c (Fcall_interactively): Give a more explicit error for the
4959 'c' case with a non-character input. (Bug#8479)
4960
352ec8ff
EZ
49612011-10-08 Eli Zaretskii <eliz@gnu.org>
4962
03669ccb
EZ
4963 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4964 lines.
7061c986
EZ
4965 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4966 lines that are hscrolled on the left.
03669ccb 4967
352ec8ff
EZ
4968 * dispnew.c (buffer_posn_from_coords): Account for a possible
4969 presence of header-line. (Bug#4426)
4970
a66cfb1c
SM
49712011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4972
6b02f655
SM
4973 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4974 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4975
7c5ee88e
PE
49762011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4977
4978 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4979 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4980 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4981 this makes Emacs dump core during garbage collection on rare
4982 occasions. sizeof is obviously inferior to offsetof here, so
4983 stick with offsetof.
4984 (GC_POINTER_ALIGNMENT): New macro.
4985 (mark_memory): Omit 3rd (offset) arg; caller changed.
4986 Don't assume EMACS_INT alignment is the same as pointer alignment.
4987
df1bbe5b
SM
49882011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4989
4990 * keyboard.c (read_key_sequence_remapped): New var.
4991 (read_key_sequence): Compute remapping in the right buffer.
4992 (command_loop_1): Use read_key_sequence's remapping directly.
4993
51553db6
SM
49942011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4995
32c1fffd
SM
4996 * dired.c (file_name_completion): Don't expand file name.
4997 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4998 before checking file name handler.
4999
51553db6
SM
5000 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5001 they've been requested explicitly (bug#9591).
5002
b6bd1599 50032011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5004
5005 * keymap.c (Fsingle_key_description): Use make_specified_string
5006 instead of build_string to build string from push_key_description.
5007 (Bug#5193)
5008
f701dc2a
PE
50092011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5010
4222c55d
PE
5011 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5012 This fixes a Y2038 bug on 64-bit hosts.
5013 * buffer.c (reset_buffer):
5014 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5015 (Fclear_buffer_auto_save_failure):
5016 Use 0, not -1, to represent an unset failure time, since time_t
5017 might not be signed.
5018
f701dc2a
PE
5019 Remove dependency on glibc malloc internals.
5020 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5021 Move back here from lisp.h, but with their new implementations.
5022 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5023 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5024 * charset.c (charset_table_init): New static var.
5025 (syms_of_charset): Use it instead of xmalloc. This removes a
5026 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5027 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5028 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5029 Move back to alloc.c.
5030 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5031 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5032
9ceebf39
JD
50332011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5034
5035 * nsterm.m (windowDidResize): Call x_set_window_size only when
5036 ns_in_resize is true. Otherwise set pixelwidth/height and
5037 call change_frame_size (Bug#9628).
5038
cb993c58
PE
50392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5040
3930c88b
PE
5041 Port --enable-checking=all to Fedora 14 x86-64.
5042 * charset.c (syms_of_charset): Also account for glibc malloc's
5043 internal overhead when calculating the initial malloc maximum.
5044
cb993c58
PE
5045 Port --enable-checking=all to Fedora 14 x86.
5046 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5047 Move to lisp.h.
5048 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5049 (overrun_check_realloc, overrun_check_free):
5050 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5051 That way, xmalloc returns a properly-aligned pointer even if
5052 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5053 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5054 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5055 into account when calculating the initial malloc maximum.
5056 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5057 Move here from alloc.c, so that charset.c can use it too.
5058 Properly align; the old code wasn't right for common 32-bit hosts
5059 when configured with --enable-checking=all.
5060 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5061 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5062
31bed486
EZ
50632011-09-29 Eli Zaretskii <eliz@gnu.org>
5064
04c70788 5065 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5066 use EDOM.
5067
fbcaa2f3
EZ
50682011-09-28 Eli Zaretskii <eliz@gnu.org>
5069
5070 * xdisp.c (compute_display_string_end): If there's no display
5071 string at CHARPOS, return -1.
5072
5073 * bidi.c (bidi_fetch_char): When compute_display_string_end
5074 returns a negative value, treat the character as a normal
5075 character not covered by a display string. (Bug#9624)
5076
a239d4e9
JB
50772011-09-28 Juanma Barranquero <lekktu@gmail.com>
5078
5079 * lread.c (Fread_from_string): Fix typo in docstring.
5080
88652fd5
EZ
50812011-09-27 Eli Zaretskii <eliz@gnu.org>
5082
5083 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5084 newline, reseat the iterator instead of bidi-iterating there one
5085 character at a time. (Bug#9610)
32c1fffd
SM
5086 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5087 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5088
ed497dd4
AS
50892011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5090
5091 * lread.c (readevalloop): Use correct code for NBSP.
5092 (read1): Likewise. (Bug#9608)
5093
b2bf61aa
MA
50942011-09-25 Michael Albinus <michael.albinus@gmx.de>
5095
5096 * dbusbind.c (Fdbus_register_signal): When service is not
5097 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5098
32bbb17c
GM
50992011-09-25 Glenn Morris <rgm@gnu.org>
5100
5101 * buffer.c (truncate-lines): Doc fix.
5102
94e0933e
CY
51032011-09-24 Chong Yidong <cyd@stupidchicken.com>
5104
5105 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5106 (Fset_window_next_buffers): Doc fix.
5107
cddde921
GM
51082011-09-24 Glenn Morris <rgm@gnu.org>
5109
5110 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5111
1260aef1
PE
51122011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5113
25b4bfa0
PE
5114 Fix minor problems found by static checking.
5115 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5116 * indent.c (Fvertical_motion): Fix == vs = typo.
5117
e3cbd34b
EZ
51182011-09-24 Eli Zaretskii <eliz@gnu.org>
5119
a66cfb1c
SM
5120 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5121 Default value is now t. Doc fix.
6bf7006f 5122
e3cbd34b 5123 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5124 logic when moving up, not only when moving down. Fix the
e3cbd34b 5125 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5126 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5127
5128 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5129 CHARPOS is covered by a display string which includes newlines.
5130 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5131 is covered by a display string with embedded newlines.
5132
a3de0cbd
MA
51332011-09-24 Michael Albinus <michael.albinus@gmx.de>
5134
5135 * dbusbind.c (Fdbus_register_signal): Add match rule to
5136 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5137 (Fdbus_register_method, Vdbus_registered_objects_table):
5138 Fix docstring.
a3de0cbd 5139
b260039d
JM
51402011-09-24 Jim Meyering <meyering@redhat.com>
5141
32c1fffd 5142 do not ignore write error for any output size
b260039d
JM
5143 The previous change was incomplete.
5144 While it makes emacs --batch detect the vast majority of stdout
5145 write failures, errors were still ignored whenever the output size is
5146 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5147 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5148 && echo FAIL: ignored write error
5149 FAIL: ignored write error
5150 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5151 && echo FAIL: ignored write error
5152 FAIL: ignored write error
5153 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5154
8eca8a7c
AS
51552011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5156
5157 * emacs.c (Fkill_emacs): In noninteractive mode exit
5158 non-successfully if a write error occurred on stdout. (Bug#9574)
5159
3341db62
EZ
51602011-09-21 Eli Zaretskii <eliz@gnu.org>
5161
5162 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5163 the xassert test.
5164
5165 * dispextern.h (struct it): Update the comment documenting what
5166 can it->OBJECT be.
5167
8c203dbf
EZ
51682011-09-20 Eli Zaretskii <eliz@gnu.org>
5169
5170 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5171 a display string, extend search for cursor position to end of row.
5172 (find_row_edges): If the row ends in a newline from a display
5173 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5174 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5175 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5176 non-empty line. Fixes confusing cursor motion with arrow keys at
5177 the beginning of a line that starts with whitespace.
8c203dbf 5178
a4824228
LMI
51792011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5180
5181 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5182 (bug#9493).
5183
33ed493b
CY
51842011-09-18 Chong Yidong <cyd@stupidchicken.com>
5185
5186 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5187 boolean (Bug#9154).
5188
56cd55c8
EZ
51892011-09-18 Eli Zaretskii <eliz@gnu.org>
5190
5191 * xdisp.c (display_line): Record maximum and minimum buffer
5192 positions even if no glyphs were produced (e.g., by a zero-width
5193 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5194 buffer positions that will be removed from the glyph row because
5195 they don't fit.
c02dcedf
EZ
5196 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5197 column is beyond frame width: don't subtract 1 "pixel" when
5198 computing width of the stretch.
3e62b7e0
EZ
5199 (reseat_at_next_visible_line_start): Undo the change made on
5200 2011-09-17 that saved paragraph information and restored it after
5201 the call to `reseat'. (Bug#9545)
56cd55c8 5202
5ed99d36 52032011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5204
5205 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5206 and turn window cursor on if cleared (Bug#9415).
5207
5ed99d36 52082011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5209
5210 * search.c (boyer_moore): Take unibyte characters from pattern
5211 literally. (Bug#9458)
5212
9bade7b2
EZ
52132011-09-18 Eli Zaretskii <eliz@gnu.org>
5214
5215 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5216
e5e9d610
PE
52172011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5218
87e4427a
PE
5219 Fix minor problem found by static checking.
5220 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5221 initialized, to pacify gcc -Wuninitialized.
5222
e5e9d610
PE
5223 * fileio.c: Report proper errno when syscall falls.
5224 (Finsert_file_contents): Save and restore errno,
5225 so that report_file_error outputs the correct diagnostic.
5226 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5227
a1674f0b
EZ
52282011-09-18 Eli Zaretskii <eliz@gnu.org>
5229
5230 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5231
fbfb6dd4
EZ
52322011-09-17 Eli Zaretskii <eliz@gnu.org>
5233
5234 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5235 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5236
bb187662
EZ
52372011-09-17 Eli Zaretskii <eliz@gnu.org>
5238
1137e8b8 5239 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5240 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5241
5242 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5243 (bidi_find_paragraph_start): Search back for paragraph beginning
5244 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5245 (bidi_move_to_visually_next): Only trigger paragraph-related
5246 computations when the last character is a newline or at EOB, not
5247 just any NEUTRAL_B. (Bug#9470)
5248
bb187662
EZ
5249 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5250 truncated lines if point is covered by a display string. (Bug#9524)
5251
2e621251
PE
52522011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5255 (cons_to_x_long): New function.
5256 (lisp_data_to_selection_data): Use it. Correct the test for
5257 short-versus-long data; it was negated. Break out of vector
5258 loop, for efficiency, when a long datum is discovered.
5259
91a15bc6
SM
52602011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5261
5262 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5263
b41c3a35
EZ
52642011-09-16 Eli Zaretskii <eliz@gnu.org>
5265
5266 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5267 GCC PR/17406) by declaring this function with external scope.
5268
7812ba2d
PE
52692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5270
5271 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5272 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5273
cf7edc2a
AS
52742011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5275
5276 * editfns.c (Fformat): Correctly handle text properties on "%%".
5277
bd01620e
EZ
52782011-09-15 Eli Zaretskii <eliz@gnu.org>
5279
5280 * xterm.c (x_draw_composite_glyph_string_foreground):
5281 * w32term.c (x_draw_composite_glyph_string_foreground):
5282 * term.c (encode_terminal_code):
5283 * composite.c (composition_update_it, get_composition_id):
5284 * xdisp.c (get_next_display_element)
5285 (fill_composite_glyph_string): Add comments about special meaning
5286 of TAB characters in a composition.
5287
a02719a3
PE
52882011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5289
5290 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5291 This occurs when processing a multibyte format.
5292 Problem reported by Wolfgang Jenker.
a02719a3 5293
72589a3c
JB
52942011-09-15 Johan Bockgård <bojohan@gnu.org>
5295
5296 * xdisp.c (try_cursor_movement): Only check for exact match if
5297 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5298
1c14176c
PE
52992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5300
5301 Remove unused external symbols.
5302 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5303 * xdisp.c (calc_pixel_width_or_height): Now static.
5304 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5305 * indent.c (check_display_width):
5306 * w32term.c: Fix comment to match code.
5307 * xterm.c, xterm.h (x_catching_errors): Remove.
5308
d2eea5b5
PE
53092011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5310
5311 * xselect.c: Use signed conversions more consistently (Bug#9498).
5312 (selection_data_to_lisp_data): Assume incoming selection data are
5313 signed integers, not unsigned. This is to be consistent with
5314 outgoing selection data, which was modified to use signed integers
5315 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5316 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5317 expects long, not unsigned long.
5318
46888499
EZ
53192011-09-14 Eli Zaretskii <eliz@gnu.org>
5320
5321 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5322 computation of loop end. Reported by Johan Bockgård
5323 <bojohan@gnu.org>.
5324
ef8ef9fb
CY
53252011-09-13 Chong Yidong <cyd@stupidchicken.com>
5326
5327 * frame.c (Fother_visible_frames_p): Function deleted.
5328
fa819fed
EZ
53292011-09-12 Eli Zaretskii <eliz@gnu.org>
5330
5331 * indent.c (compute_motion): Process display vector front to back
5332 rather than the other way around. (Bug#2496)
5333
2ba8e008
SM
53342011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5335
5336 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5337
20f53c69
CY
53382011-09-11 Chong Yidong <cyd@stupidchicken.com>
5339
5340 * minibuf.c (Fread_from_minibuffer): Doc fix.
5341
d562d7a4
EZ
53422011-09-11 Eli Zaretskii <eliz@gnu.org>
5343
5344 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5345 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5346
1c4d7f3d
LMI
53472011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5348
5349 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5350 value for non-existent files.
5351
b885bf36
EZ
53522011-09-11 Eli Zaretskii <eliz@gnu.org>
5353
5354 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5355 set its "size" to -1. This will set the modtime_size field of
5356 the corresponding buffer to -1, which is what
5357 verify-visited-file-modtime expects for files that do not exist.
5358 (Bug#9139)
5359
6612f0bf
PE
53602011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5361
5362 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5363 here ...
5364 * lisp.h: ... from here. push_key_description is no longer
5365 defined in keyboard.c, so its declaration should not be in
5366 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5367 logically belongs with push_key_description.
5368
dfb3f755
PE
53692011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5370
5371 * buffer.h: Include <sys/types.h> instead of <time.h>.
5372 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5373 Problem reported by Herbert J. Skuhra.
5374
3134906c
LMI
53752011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5376
5377 * xml.c (parse_region): Make the parsing work for
5378 non-comment-starting XML files again (bug#9144).
5379
8d903f4e
AS
53802011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5381
5382 * image.c (gif_load): Fix calculation of bottom and right corner.
5383 (Bug#9468)
5384
80ad64f4
EZ
53852011-09-10 Eli Zaretskii <eliz@gnu.org>
5386
5387 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5388 redisplay in small windows.
5389
208a048d
EZ
53902011-09-09 Eli Zaretskii <eliz@gnu.org>
5391
5392 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5393
9b1c252e
MR
53942011-09-08 Martin Rudalics <rudalics@gmx.at>
5395
5396 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5397 Operate on live windows only.
5398
2949f33b
JB
53992011-09-08 Juanma Barranquero <lekktu@gmail.com>
5400
5401 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5402
e08dcafd
EZ
54032011-09-07 Eli Zaretskii <eliz@gnu.org>
5404
5405 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5406 only under bidi iteration.
5407
115b96bd
JD
54082011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5409
5410 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5411
c8199d0f
PE
54122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5413
5414 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5415 Without this fix, the command to link temacs failed due to an
5416 undefined symbol __builtin_isnan. This is because
5417 /usr/include/iso/math_c99.h #defines isnan(x) to
5418 __builtin_isnan(x), but the bundled gcc, which identifies itself
5419 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5420 a __builtin_isnan.
5421 * floatfns.c (isnan): #undef, and then #define to a clone of
5422 what's in data.c.
5423 (Fisnan): Always define, since it's always available now.
5424 (syms_of_floatfns): Always define isnan at the Lisp level.
5425
e39b275c 54262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5427
5428 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5429
b2db44d9 54302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5431
f4af5137 5432 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5433 The previous code assumed that file offsets (off_t values) fit in
5434 EMACS_INT variables, which is not true on typical 32-bit hosts.
5435 The code messed up by falsely reporting buffer overflow in cases
5436 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5437 when "big" contains more than 2**29 bytes, even though this
5438 inserts just one byte and does not overflow the buffer.
5439 (Finsert_file_contents): Store file offsets as off_t
5440 values, not as EMACS_INT values. Check for overflow when
5441 converting between EMACS_INT and off_t. When checking for
5442 buffer overflow or for overlap, take the offsets into account.
5443 Don't use EMACS_INT for small values where int suffices.
5444 When checking for overlap, fix a typo: ZV was used where
5445 ZV_BYTE was intended.
5446 (Fwrite_region): Don't assume off_t fits into 'long'.
5447 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5448
ecfc0a49
MA
54492011-09-05 Michael Albinus <michael.albinus@gmx.de>
5450
5451 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5452
6511acf2 54532011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5454
0999621a 5455 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5456
5457 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5458 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5459 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5460 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5461 (modify_event_symbol): Do not assume that the length of
5462 name_alist_or_stem is safe to alloca and fits in int.
5463 (Fexecute_extended_command): Likewise for function name and binding.
5464 (Frecursion_depth): Wrap around reliably on integer overflow.
5465 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5466 since some callers pass EMACS_INT values.
5467 (Fsingle_key_description): Don't crash if symbol name contains more
5468 than MAX_ALLOCA bytes.
5469 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5470 (get_minibuffer): Arg is now EMACS_INT, not int.
5471 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5472 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5473 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5474
2be7d702
PE
5475 * dbusbind.c (signature_cat): New function.
5476 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5477 Do not overrun buffer; instead, report string overflow.
5478
9d1df220
PE
5479 * dispnew.c (add_window_display_history): Don't overrun buffer.
5480 Truncate instead; this is OK since it's just a log.
5481
33ef5c64
PE
5482 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5483 even if the time zone offset is outlandishly large.
5484 Don't mishandle offset == INT_MIN.
5485
66c6fdd5
PE
5486 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5487 when creating daemon; the previous buffer-overflow check was incorrect.
5488
d749b01b
PE
5489 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5490 which has the guts of the old verror function.
5491
b5cd1905
PE
5492 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5493 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5494
6e1a67fb
PE
5495 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5496 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5497 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5498 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5499 length of string rather than counting it via multiple sprintfs;
5500 that's simpler and more reliable.
c21721cc
PE
5501 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5502 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5503 sprintf, in case result does not fit in int.
5504
c57b67fc
PE
5505 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5506 (fontset_from_font): Print it.
5507
8a401434
PE
5508 * frame.c (tty_frame_count): Now printmax_t, not int.
5509 (make_terminal_frame, set_term_frame_name): Print it.
5510 (x_report_frame_params): In X, window IDs are unsigned long,
5511 not signed long, so print them as unsigned.
5512 (validate_x_resource_name): Check for implausibly long names,
5513 and don't assume name length fits in 'int'.
5514 (x_get_resource_string): Don't blindly alloca invocation name;
5515 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5516 not fit in int.
5517
6e1a67fb
PE
5518 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5519 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5520 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5521
0df02bf3
PE
5522 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5523 Use esprintf, not sprintf, in case result does not fit in int.
5524
48e30793
PE
5525 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5526 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5527 it as a large positive number.
5528 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5529 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5530
a66ff6d8
PE
5531 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5532 in case result does not fit in int.
5533
aca216ff
PE
5534 * print.c (float_to_string): Detect width overflow more reliably.
5535 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5536 buffer overrun. Don't assume list length fits in 'int'. Treat
5537 print length of 0 as 0, not as infinity; to be consistent with other
5538 uses of print length in this function. Don't overflow print length
5539 index. Don't assume hash table size fits in 'long', or that
5540 vectorlike size fits in 'unsigned long'.
5541
31c286f7
PE
5542 * process.c (make_process): Use printmax_t, not int, to format
5543 process-name gensyms.
5544
55e5faa1
PE
5545 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5546
80f2e268
PE
5547 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5548 to avoid potential buffer overrun.
5549
670741ab
PE
5550 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5551 if X resource line is longer than 512 bytes.
5552
b7163a50
PE
5553 * xfns.c (x_window): Make sprintf buffer a bit bigger
5554 to avoid potential buffer overrun.
5555
ae58ff1f
PE
5556 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5557
c43c8a6a
PE
5558 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5559
3f8236f4
PE
55602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5561
53e9fe90 5562 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5563 Without these, Emacs silently mishandles large integers sometimes.
5564 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5565 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5566
6511acf2
PE
5567 * xdisp.c (try_window_id): Check Emacs fixnum range before
5568 converting to 'int'.
806add1d 5569
6511acf2 5570 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5571 Check that an Emacs fixnum is in range before assigning it to 'int'.
5572 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5573 values converted from Emacs fixnums.
5574 (Frecenter): Don't wrap around a line count if it is out of 'int'
5575 range; instead, treat it as an extreme value.
5576 (Fset_window_configuration, compare_window_configurations):
5577 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5578
6511acf2
PE
5579 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5580 that can exceed INT_MAX. Check that EMACS_INT value is in range
5581 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5582 (match_limit): Don't assume that a fixnum can fit in 'int'.
5583
6511acf2 5584 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5585 exceed INT_MAX.
5586
6511acf2 5587 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5588 (Fvertical_motion): Don't wrap around LINES values that don't fit
5589 in 'int'. Instead, treat them as extreme values. This is good
5590 enough for windows, which can't have more than INT_MAX lines anyway.
5591
fcb901a7
LMI
55922011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5593
0f2f6b6d
LMI
5594 * Require libxml/parser.h to avoid compilation warning.
5595
fcb901a7
LMI
5596 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5597
5598 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5599 since this reportedly can destroy thread storage.
5600
6e20a0d4
CY
56012011-08-30 Chong Yidong <cyd@stupidchicken.com>
5602
5603 * syntax.c (find_defun_start): Update all cache variables if
5604 exiting early (Bug#9401).
5605
148ae00e
EZ
56062011-08-30 Eli Zaretskii <eliz@gnu.org>
5607
f6cfbd8f
EZ
5608 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5609
148ae00e
EZ
5610 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5611 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5612 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5613
5614 * term.c (tty_append_glyph): New function.
5615 (produce_stretch_glyph): Static function and its prototype deleted.
5616
a66cfb1c
SM
5617 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5618 Add prototypes.
148ae00e 5619
c4a07a4c
PE
56202011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5621
5622 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5623 when checking :margin (Bug#9390).
5624 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5625 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5626 so that the name doesn't mislead. All uses changed.
5627
6bc8cd65
JB
56282011-08-28 Johan Bockgård <bojohan@gnu.org>
5629
5630 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5631 set_tty_hooks.
5632
dca4927e
EZ
56332011-08-27 Eli Zaretskii <eliz@gnu.org>
5634
5635 * xdisp.c (move_it_to): Don't bail out early when reaching
5636 position beyond to_charpos, if we are scanning backwards.
5637 (move_it_vertically_backward): When DY == 0, make sure we get to
5638 the first character in the line after the newline.
5639
f2cad773
PE
56402011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5641
5642 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5643 (ccl_driver): Do not generate an out-of-range pointer.
5644 (Fccl_execute_on_string): Remove unnecessary check for
5645 integer overflow, noted by Stefan Monnier in
5646 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5647 Remove a FIXME that didn't need fixing.
5648 Simplify the newly-introduced buffer reallocation code.
5649
0cae2cdb
JB
56502011-08-27 Juanma Barranquero <lekktu@gmail.com>
5651
5652 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5653
5fc295a4 56542011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5655
70c60eb2 5656 Integer and memory overflow issues (Bug#9196).
726e0ab1 5657
d31850da
PE
5658 * doc.c (get_doc_string): Rework so that
5659 get_doc_string_buffer_size is the actual buffer size, rather than
5660 being 1 less than the actual buffer size; this makes xpalloc more
5661 convenient.
5662
a69fbedb
PE
5663 * image.c (x_allocate_bitmap_record, cache_image):
5664 * xselect.c (Fx_register_dnd_atom):
5665 Simplify previous changes by using xpalloc.
5666
fe5c5d37
PE
5667 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5668 since either will do and ptrdiff_t is convenient with xpalloc.
5669
0065d054
PE
5670 * charset.c (charset_table_size)
5671 (struct charset_sort_data.priority): Now ptrdiff_t.
5672 (charset_compare): Don't overflow if priorities differ greatly.
5673 (Fsort_charsets): Don't assume list length fits in int.
5674 Check for size-calculation overflow when allocating sort data.
5675 (syms_of_charset): Allocate an initial charset table that is
5676 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5677
5678 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5679
5680 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5681 The actual value is always <= INT_MAX, and leaving it unsigned made
5682 overflow checking harder.
5683
5684 * dispextern.h (struct glyph_matrix.rows_allocated)
5685 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5686 with xpalloc. The values are still always <= INT_MAX.
5687
5688 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5689
5690 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5691 (SAFE_NALLOCA): New macro.
5692
5693 * region-cache.c (struct boundary.pos, find_cache_boundary)
5694 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5695 (set_cache_region, invalidate_region_cache)
5696 (revalidate_region_cache, know_region_cache, region_cache_forward)
5697 (region_cache_backward, pp_cache):
5698 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5699 so that ptrdiff_t * can be passed to xpalloc.
5700 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5701 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5702 (pp_cache): Don't assume cache_len fits in int.
5703 * region-cache.h: Adjust extern decls to match.
5704
5705 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5706 EMACS_INT, since either will do, for xpalloc.
5707
5708 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5709 (xnmalloc, xnrealloc, xpalloc): New functions.
5710
726e0ab1
PE
5711 * bidi.c (bidi_shelve_header_size): New constant.
5712 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5713 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5714
51f30bc5 5715 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5716 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5717 (overlay_strings):
5718 Don't update size of array until after memory allocation succeeds,
5719 because xmalloc/xrealloc may not return.
0065d054
PE
5720 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5721 now that we have proper integer overflow checking.
5722 (record_overlay_string, overlay_strings): Catch overflows when
5723 calculating size of overlay_str_buf.
726e0ab1 5724
0065d054
PE
5725 * callproc.c (Fcall_process): Check for size overflow when
5726 calculating size of args2.
5727 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5728 Normally we prefer signed values, but sticking with ptrdiff_t would
5729 require adding more-complicated checks.
726e0ab1
PE
5730
5731 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5732 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5733 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5734 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5735
5736 * character.c (Fstring): Check for size-calculation overflow.
5737
5738 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5739 unnecessary integer overflow. Check for size overflow.
5740 (encode_coding_object): Don't update size until xmalloc succeeds.
5741
5742 * composite.c (get_composition_id): Check for overflow in glyph
5743 length calculations.
5744
5745 Integer and memory overflow fixes for display code.
5746 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5747 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5748 (scrolling_window): Check for overflow in size calculations.
5749 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5750 Don't assume glyph table len fits in int.
5751 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5752 (row_table_size): Now ptrdiff_t, not int.
5753 (scrolling_window): Avoid overflow in size calculations.
5754 Don't update size until allocation succeeds.
5755 * fns.c (concat): Check for overflow in size calculations.
5756 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5757 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5758 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5759
5760 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5761 (get_doc_string): Check for size calculation overflow.
5762 Don't update size until allocation succeeds.
5763 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5764 EMACS_INT, where ptrdiff_t will do.
5765 (Fsubstitute_command_keys): Check for string overflow.
5766
5767 * editfns.c (set_time_zone_rule): Don't assume environment length
5768 fits in int.
5769 (message_length): Now ptrdiff_t, not int.
5770 (Fmessage_box): Don't update size until allocation succeeds.
5771 Don't assume message length fits in int.
5772 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5773
0065d054
PE
5774 * emacs.c (main): Do not reallocate argv, since there is a null at
5775 the end that can be overwritten, and this way there's no need to
5776 worry about size-calculation overflow.
5777 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5778
5779 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5780 alloc succeeds.
5781 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5782
5783 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5784 (x_set_scroll_bar_width, x_figure_window_size):
5785 Check for integer overflow.
5786 (x_set_alpha): Do not assume XINT fits in int.
5787
5788 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5789 This is for the members text_lines, text_cols, total_lines, total_cols,
5790 where the system imposes an 'int' limit.
5791
5792 * fringe.c (Fdefine_fringe_bitmap):
5793 Don't update size until alloc works.
5794
5795 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5796 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5797
5798 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5799 Check for size-calculation overflow.
5800 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5801 do, as we prefer signed integers.
5802 (id_to_widget.max_size, id_to_widget.used)
5803 (xg_store_widget_in_map, xg_remove_widget_from_map)
5804 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5805 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5806 Use and return ptrdiff_t, not int.
5807 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5808 * gtkutil.h: Change prototypes to match the above.
5809
5810 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5811 are duplicate now that they've been promoted to lisp.h.
5812 (x_allocate_bitmap_record, x_alloc_image_color)
5813 (make_image_cache, cache_image, xpm_load):
5814 Don't update size until alloc is done.
5815 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5816 (x_detect_edges):
3256efce 5817 Check for size calculation overflow.
726e0ab1
PE
5818 (ct_colors_allocated_max): New constant.
5819 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5820 overflow.
3256efce 5821
726e0ab1
PE
5822 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5823 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5824 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5825 Use ptrdiff_t, not int, to count maps.
5826 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5827 calculations. Don't update size until allocation succeeds.
5828 Redo calculations to avoid overflow.
726e0ab1
PE
5829 * keyboard.h: Change prototypes to match the above.
5830
5831 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5832 to count maps.
5833 (current_minor_maps): Check for size calculation overflow.
5834 * keymap.h: Change prototypes to match the above.
5835
5836 * lread.c (read1, init_obarray): Don't update size until alloc done.
5837
5838 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5839 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5840
726e0ab1
PE
5841 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5842 Now ptrdiff_t, not int.
5843 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5844 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5845
5846 * process.c (Fnetwork_interface_list): Check for overflow
5847 in size calculation.
5848
5849 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5850
5851 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5852 overflow. Don't bother calling xmalloc when xrealloc will do.
5853
5854 * search.c (Freplace_match): Check for size calculation overflow.
5855 (Fset_match_data): Don't assume list lengths fit in 'int'.
5856
5857 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5858 for command line length. Do not attempt to address one before the
5859 beginning of an array, as that's not portable.
5860
5861 * term.c (max_frame_lines): Remove; unused.
5862 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5863 not int.
5864 (encode_terminal_code, calculate_costs): Check for size
5865 calculation overflow.
5866 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5867 table lengths and related sizes. Don't update size until alloc
5868 done. Redo calculations to avoid overflow.
5869 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5870
5871 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5872 subtracting pointers.
5873 (gobble_line): Check for overflow more carefully. Don't update size
5874 until alloc done.
5875
5876 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5877 Don't update size until alloc done.
5878 Redo size calculations to avoid overflow.
5879 Check for size calculation overflow.
0065d054 5880 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5881
5882 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5883 Use ptrdiff_t, not int, for sizes.
5884 (store_mode_line_noprop_char): Don't update size until alloc done.
5885
0065d054
PE
5886 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5887 Use ptrdiff_t, not int, for sizes.
5888 (Finternal_make_lisp_face, cache_face):
5889 Check for size calculation overflow.
5890 (cache_face): Treat size calculation overflows as if they were
5891 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5892
5893 * xfns.c (x_encode_text, x_set_name_internal)
5894 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5895 sizes, since they can exceed INT_MAX in size. Check for size
5896 calculation overflow.
5897
0065d054
PE
5898 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5899 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5900 Don't update size until alloc done.
5901
0065d054 5902 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5903 as sprintf is limited to int lengths.
1d526e2f 5904
252c5ee1
PE
5905 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5906 (X_LONG_MIN): New macros.
864d7ce7
PE
5907 Use them to make the following changes clearer.
5908 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5909 This change doesn't affect the value now, but it may help remind
5910 future maintainers not to raise the value too much later.
5911 (SELECTION_QUANTUM): Remove, replacing with ...
5912 (selection_quantum): ... new function, which avoids overflow.
5913 All uses changed.
5914 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5915 assumption that selection length fits in 'int'.
5916 (x_reply_selection_request, x_handle_selection_request)
5917 (x_get_window_property, receive_incremental_selection)
5918 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5919 (lisp_data_to_selection_data, clean_local_selection_data):
5920 Use ptrdiff_t, not int, to record length of selection.
5921 (x_reply_selection_request, x_get_window_property)
5922 (receive_incremental_selection, x_property_data_to_lisp):
5923 Redo calculations to avoid overflow.
5924 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5925 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5926 something.
5927 (x_get_window_property, receive_incremental_selection)
5928 (lisp_data_to_selection_data, x_property_data_to_lisp):
5929 Check for size-calculation overflow.
5930 (x_get_window_property, receive_incremental_selection)
5931 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5932 Don't store size until memory allocation succeeds.
5933 (x_get_window_property): Plug memory leak on memory exhaustion.
5934 Don't double-block input; malloc is safe here. Don't assume 2**34
5935 - 4 fits in unsigned long. Add an xassert to check
5936 XGetWindowProperty overflow. Be more careful about overflow
5937 calculations, and distinguish size from memory overflow better.
5938 (receive_incremental_selection): When tracing, don't assume
5939 unsigned int is less than INT_MAX.
5940 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5941 harmful) conversions of unsigned short to int.
5942 (lisp_data_to_selection_data): Don't assume that integers
5943 in the range -65535 through -1 fit in an X unsigned short.
5944 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5945 result parameters unless successful. Rely on cons_to_unsigned
5946 to report problems with elements; the old code wasn't right anyway.
5947 (x_check_property_data): Check for int overflow; we cannot use
5948 a wider type due to X limits.
5949 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5950
726e0ab1 5951 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5952
0065d054
PE
5953 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5954 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5955 (x_color_cells): Don't store size until memory allocation succeeds.
5956 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5957 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5958 (x_term_init): Don't assume length fits in int (sprintf is limited
5959 to int size).
bc18e09d 5960
ebfa62c0
PE
5961 Use ptrdiff_t for composition IDs.
5962 * character.c (lisp_string_width):
5963 * composite.c (composition_table_size, n_compositions)
5964 (get_composition_id, composition_gstring_from_id):
5965 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5966 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5967 * window.c (Frecenter):
5968 Use ptrdiff_t, not int, for composition IDs.
5969 * composite.c (get_composition_id): Check for integer overflow.
5970 * composite.h: Adjust prototypes to match the above changes.
5971
d3411f89
PE
5972 Use ptrdiff_t for hash table indexes.
5973 * category.c (hash_get_category_set):
5974 * ccl.c (ccl_driver):
5975 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5976 * coding.c (coding_system_charset_list, detect_coding_system):
5977 * coding.h (struct coding_system.id):
5978 * composite.c (get_composition_id, gstring_lookup_cache):
5979 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5980 * image.c (xpm_get_color_table_h):
5981 * lisp.h (hash_lookup, hash_put):
5982 * minibuf.c (Ftest_completion):
5983 Use ptrdiff_t for hash table indexes, not int (which is too
5984 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5985 32-bit --with-wide-int hosts).
5986
e097a6fa
PE
5987 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5988 Add a FIXME comment about memory leaks.
5989 (syms_of_charset): Don't assume xmalloc returns.
5990
5637687f
PE
5991 Don't assume that stated character widths fit in int.
5992 * character.c (Fchar_width, c_string_width, lisp_string_width):
5993 * character.h (CHAR_WIDTH):
5994 * indent.c (MULTIBYTE_BYTES_WIDTH):
5995 Use sanitize_char_width to avoid undefined and/or bad behavior
5996 with outlandish widths.
a66cfb1c 5997 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5998 now that we have two such functions. All uses changed.
5999 (sanitize_char_width): New inline function.
6000
a2271ba2
PE
6001 Don't assume that tab-width fits in int.
6002 * character.h (sanitize_width): New inline function.
6003 (SANE_TAB_WIDTH): New macro.
6004 (ASCII_CHAR_WIDTH): Use it.
6005 * indent.c (sane_tab_width): Remove. All uses replaced by
6006 SANE_TAB_WIDTH (current_buffer).
6007 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6008
18c52557
PE
6009 * fileio.c: Integer overflow issues with file modes.
6010 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6011
caeeedc1
PE
6012 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6013 Remove unreachable code.
6014 (read_hex, load_charset_map_from_file): Check for integer overflow.
6015
6df6ae42 6016 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6017 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6018 (x_send_scroll_bar_event): Likewise. Check that the size does not
6019 exceed limits imposed by XClientMessageEvent, as well as the usual
6020 ptrdiff_t and size_t limits.
6021
b13995db
PE
6022 * keyboard.c: Overflow, signedness and related fixes.
6023 (make_lispy_movement): Use same integer type in forward decl
6024 that is used in the definition.
6025 (read_key_sequence, keyremap_step):
6026 Change bufsize argument back to int, undoing my 2011-03-30 change.
6027 We prefer signed types, and int is wide enough here.
6028 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6029 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6030 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6031 length, not size_t. Use ptrdiff_t for index, not int.
6032 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6033 possibility of integer overflow.
6034
13464394
PE
6035 Overflow, signedness and related fixes for images.
6036
6037 * dispextern.h (struct it.stack[0].u.image.image_id)
6038 (struct_it.image_id, struct image.id, struct image_cache.size)
6039 (struct image_cache.used, struct image_cache.ref_count):
6040 * gtkutil.c (update_frame_tool_bar):
6041 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6042 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6043 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6044 * nsmenu.m (update_frame_tool_bar):
6045 * xdisp.c (calc_pixel_width_or_height):
6046 * xfns.c (image_cache_refcount):
6047 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6048 on typical 64-bit hosts.
6049
6050 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6051 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6052 Omit unnecessary casts to int.
6053 (parse_image_spec): Check that integers fall into 'int' range
6054 when the callers expect that.
6055 (image_ascent): Redo ascent calculation to avoid int overflow.
6056 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6057 (lookup_image): Remove unnecessary tests.
6058 (xbm_image_p): Locals are now of int, not EMACS_INT,
6059 since parse_image_check makes sure they fit into int.
6060 (png_load, gif_load, svg_load_image):
6061 Prefer int to unsigned where either will do.
6062 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6063 old tiff_error_handler and tiff_warning_handler.
6064 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6065 stack buffer overflows. It uses only the features of vsnprintf
6066 that are common to both POSIX and native Microsoft.
6067 (tiff_error_handler, tiff_warning_handler): Use it.
6068 (tiff_load, gif_load, imagemagick_load_image):
6069 Don't assume :index value fits in 'int'.
6070 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6071 (imagemagick_load_image): Check that crop parameters fit into
6072 the integer types that MagickCropImage accepts. Don't assume
6073 Vimagemagick_render_type has a nonnegative value. Don't assume
6074 size_t fits in 'long'.
6075 (gs_load): Use printmax_t to print the widest integers possible.
6076 Check for integer overflow when computing image height and width.
6077
c11821d4
EZ
60782011-08-26 Eli Zaretskii <eliz@gnu.org>
6079
6080 * xdisp.c (redisplay_window): Don't force window start if point
6081 will be invisible in the resulting window. (Bug#9324)
6082
0c95fcf7
EZ
60832011-08-25 Eli Zaretskii <eliz@gnu.org>
6084
6085 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6086 the display spec is of the form `(space ...)'.
6087 (handle_display_spec): Return the value returned by
6088 handle_single_display_spec, not just 1 or zero.
6089 (handle_single_display_spec): If the display spec is of the form
6090 `(space ...)', and specifies display in the text area, return 2
6091 rather than 1.
fee65a97 6092 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6093 accurately, and prefer exact match for point under bidi.
6094 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6095
6096 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6097 into disp_prop; all users changed.
6098
6099 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6100 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6101 for the text covered by the display property.
6102
e4ed06f1
CY
61032011-08-25 Chong Yidong <cyd@stupidchicken.com>
6104
6105 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6106 Change return value to nil.
6107 (Frecord_buffer): Delete unused function.
6108
f67cdd7f
EZ
61092011-08-24 Eli Zaretskii <eliz@gnu.org>
6110
5980d4c6
EZ
6111 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6112 buffers, return left-to-right.
8610fe8b
EZ
6113 (set_cursor_from_row): Consider candidate row a win if its glyph
6114 represents a newline and point is on that newline. Fixes cursor
6115 positioning on the newline at EOL of R2L text within L2R
6116 paragraph, and vice versa.
6117 (try_cursor_movement): Check continued rows, in addition to
6118 continuation rows. Fixes unwarranted scroll when point enters a
6119 continued line of R2L text within an L2R paragraph, or vice versa.
6120 (cursor_row_p): Consider the case of point being equal to
6121 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6122 from the end of a short line to the beginning of a continued line
6123 of R2L text within L2R paragraph.
6124 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6125 composed characters.
5980d4c6 6126
f67cdd7f
EZ
6127 * bidi.c (bidi_check_type): Use xassert.
6128 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6129 members.
6130
bca633fb
EZ
61312011-08-23 Eli Zaretskii <eliz@gnu.org>
6132
6133 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6134 a character.
6135
4a5885a7
CY
61362011-08-23 Chong Yidong <cyd@stupidchicken.com>
6137
6138 * nsfont.m (ns_otf_to_script): Fix typo.
6139
0902a04e
KH
61402011-08-22 Kenichi Handa <handa@m17n.org>
6141
6142 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6143 extra slot even if the purpose is char-code-property-table.
6144
1a2e6670
EZ
61452011-08-23 Eli Zaretskii <eliz@gnu.org>
6146
8ddde651
EZ
6147 * xdisp.c (redisplay_window): When computing centering_position,
6148 account for the height of the header line. (Bug#8874)
6149
425cc014
EZ
6150 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6151 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6152 candidate is selected by the mouse, and that candidate has a
6153 composed character under the mouse.
6154
1a2e6670
EZ
6155 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6156 coordinates reported by pos-visible-in-window-p for a composed
6157 character in column zero.
6158
8b76d6f8
SM
61592011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6160
6161 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6162
dac347dd
EZ
61632011-08-22 Eli Zaretskii <eliz@gnu.org>
6164
6165 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6166 consider it a hit if to_charpos is anywhere in the range of the
6167 composed buffer positions.
6168
e013fb34
CY
61692011-08-22 Chong Yidong <cyd@stupidchicken.com>
6170
6171 * image.c (gif_load): Don't assume that each subimage has the same
6172 dimensions as the base image. Handle disposal method that is
6173 "undefined" by the gif spec (Bug#9335).
6174
bd1ba3e8
CY
61752011-08-20 Chong Yidong <cyd@stupidchicken.com>
6176
6177 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6178 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6179
54a1215b
EZ
61802011-08-19 Eli Zaretskii <eliz@gnu.org>
6181
823564e5
EZ
6182 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6183 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6184 from an Org mode buffer to a Speedbar frame.
6185
54a1215b
EZ
6186 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6187 a composition, take its buffer position from IT->cmp_it.charpos.
6188 Fixes cursor positioning at the beginning of a line that begins
6189 with a composed character.
6190
9778ebcc
EZ
61912011-08-18 Eli Zaretskii <eliz@gnu.org>
6192
0be6ee06
EZ
6193 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6194 character bidirectional type, use STRONG_L instead. Fixes crashes
6195 in a buffer produced by `describe-categories'.
6196
9778ebcc
EZ
6197 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6198 members before the level stack, so they would be saved and
6199 restored when copying iterator state. Fixes incorrect reordering
6200 around TABs covered by display properties.
6201
156bffbe
AS
62022011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6203
6b02f655 6204 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6205
72ad093b
CY
62062011-08-17 Chong Yidong <cyd@stupidchicken.com>
6207
6208 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6209 (internal_condition_case_2, internal_condition_case_n):
6210 Remove unnecessary aborts (Bug#9081).
72ad093b 6211
35774242
EZ
62122011-08-17 Eli Zaretskii <eliz@gnu.org>
6213
6214 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6215 has no `load' handler, try opening the file locally. (Bug#9311)
6216
db76dd85
KB
62172011-08-16 Ken Brown <kbrown@cornell.edu>
6218
6219 * gmalloc.c: Expand comment.
6220
b215eee5
EZ
62212011-08-16 Eli Zaretskii <eliz@gnu.org>
6222
6223 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6224 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6225
a4579d33
KB
62262011-08-16 Ken Brown <kbrown@cornell.edu>
6227
6228 Fix memory allocation problems in Cygwin build (Bug#9273).
6229
6230 * unexcw.c ( __malloc_initialized): Declare external variable.
6231 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6232
8b76d6f8
SM
6233 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6234 New variables.
a4579d33
KB
6235 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6236 dumped emacs.
6237 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6238 in the static heap.
6239 [CYGWIN] (special_realloc): New function.
6240 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6241 requests to realloc storage in the static heap.
6242
3ebec551
PE
62432011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6244
6245 * bidi.c (bidi_initialize): Remove unused local.
6246
9fd8be00
EZ
62472011-08-15 Eli Zaretskii <eliz@gnu.org>
6248
6b02f655
SM
6249 * bidimirror.h:
6250 * biditype.h: Remove file.
6251 * makefile.w32-in ($(BLD)/bidi.$(O)):
6252 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6253
6254 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6255
6256 * chartab.c: Improve commentary for the uniprop_table API.
6257
32413314
EZ
6258 * bidi.c (bidi_paragraph_init): Support zero value of
6259 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6260 (bidi_initialize): Use uniprop_table instead of including
6261 biditype.h and bidimirror.h.
32413314 6262
9fd8be00
EZ
6263 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6264 coordinates of the iterator when restoring from ppos_it.
6265 (Bug#9296)
6266
5cf2b69b
KH
62672011-08-14 Kenichi Handa <handa@m17n.org>
6268
6269 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6270 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6271
daf17d00
EZ
62722011-08-14 Eli Zaretskii <eliz@gnu.org>
6273
6274 * xdisp.c (move_it_in_display_line_to): Don't invoke
6275 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6276 ppos_it. Fixes vertical cursor motion when line beginning is
6277 covered by an image. (Bug#9296)
6278
08e3161a
JD
62792011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6280
6281 * nsterm.h (ns_run_ascript): Declare.
6282 (NSAPP_DATA2_RUNASSCRIPT): Define.
6283
6284 * nsfns.m (as_script, as_result, as_status): New static variables.
6285 (ns_run_ascript): New function.
5e617bc2 6286 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6287 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6288 the event loop. Get status from as_status (Bug#7276).
6289
6290 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6291 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6292 the event loop (Bug#7276).
6293
a3720aa2
AS
62942011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6295
6296 * gnutls.c (QCgnutls_bootprop_priority)
6297 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6298 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6299 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6300 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6301 (QCgnutls_bootprop_verify_hostname_error)
6302 (QCgnutls_bootprop_callbacks_verify): Rename from
6303 Qgnutls_bootprop_..., all uses changed.
6304
6305 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6306 uses changed.
6307
0a0d27fb
PE
63082011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6309
19d5c50c
PE
6310 * xfaces.c (Qframe_set_background_mode): Now static.
6311 * dispextern.h (Qframe_set_background_mode): Remove decl.
6312
0a0d27fb
PE
6313 * process.c (Fnetwork_interface_info): Declare local only if needed.
6314
377538cb
JD
63152011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6316
6317 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6318 (Fnetwork_interface_list): Allocate in increments of bytes instead
6319 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6320 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6321 sockaddr.
6322 (struct ifflag_def): notrailers is smart on OSX.
6323 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6324 Get hardware address with getifaddrs if available.
6325
08fff70c
EZ
63262011-08-12 Eli Zaretskii <eliz@gnu.org>
6327
6328 * xdisp.c (iterate_out_of_display_property): xassert that
6329 IT->position is set to within IT->object's boundaries. Break from
6330 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6331 when IT->position is set up wrongly due to some bug.
6332 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6333 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6334 entry. Force push_it to save on the stack the current
6335 buffer/string position, to be restored by pop_it. Fix flags in
6336 the iterator structure wrt the object coming from a display
6337 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6338 properties. (Bug#9284)
6339
7be1c708 63402011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6341
7be1c708
CY
6342 * fontset.c (fontset_get_font_group): Add proper type checks.
6343 (Bug#9172)
aac0c6e3 6344
7be1c708 63452011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6346
7be1c708
CY
6347 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6348 and LC_VERSION_MIN_MACOSX.
6349 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6350 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6351
97bb72a6
EZ
63522011-08-08 Eli Zaretskii <eliz@gnu.org>
6353
6354 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6355 no-display-properties-and-no-overlays under bidi display.
6356 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6357 properties and overlays.
97bb72a6 6358
d5617611
CY
63592011-08-08 Chong Yidong <cyd@stupidchicken.com>
6360
37e11a63
CY
6361 * editfns.c (Fset_time_zone_rule): Document relationship with the
6362 setenv function.
6363
d5617611
CY
6364 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6365 the font entity extracted from the cache (Bug#8109).
6366
58872834
CY
63672011-08-07 Chong Yidong <cyd@stupidchicken.com>
6368
6369 * composite.c (autocmp_chars): Don't reset point. That is done by
6370 restore_point_unwind (Bug#5984).
6371
75bfc667
JL
63722011-08-07 Juri Linkov <juri@jurta.org>
6373
6374 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6375 to show the arg `TIME' instead of `TIMEVAL'.
6376
d1410150
EZ
63772011-08-06 Eli Zaretskii <eliz@gnu.org>
6378
6379 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6380 display property strides EOL and includes a newline, as in
6381 longlines-mode. (Bug#9254)
75b771e4
EZ
6382 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6383 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6384
6385 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6386 is non-zero, even if the data buffer is NULL. Fixes a crash in
6387 vertical-motion with longlines-mode. (Bug#9254)
6388
35928349
EZ
63892011-08-05 Eli Zaretskii <eliz@gnu.org>
6390
ec7cc85b
EZ
6391 * bidi.c <bidi_cache_total_alloc>: Now static.
6392 (bidi_initialize): Initialize bidi_cache_total_alloc.
6393
8b76d6f8 6394 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6395 cache. (Bug#9221)
6396
6397 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6398 amount allocated this far in `bidi_cache_total_alloc'.
6399 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6400 non-zero, only free the data buffer without restoring the cache
6401 contents. All callers changed.
6402
6403 * dispextern.h (bidi_unshelve_cache): Update prototype.
6404
6405 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6406 (move_it_in_display_line, move_it_to)
6407 (move_it_vertically_backward, move_it_by_lines): Replace the call
6408 to xfree to an equivalent call to bidi_unshelve_cache.
6409 (move_it_in_display_line_to): Fix logic of returning
412b6358 6410 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6411
e2e2423b
EZ
64122011-08-05 Eli Zaretskii <eliz@gnu.org>
6413
6414 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6415 came from a string character with a `cursor' property. (Bug#9229)
6416
ae9e757a
JD
64172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6418
6419 * Makefile.in (LIB_PTHREAD): New variable.
6420 (LIBES): Add LIB_PTHREAD (Bug#9216).
6421
6422 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6423 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6424
213bd7f2
AS
64252011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6426
6b02f655 6427 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6428
99aaf75f
JD
64292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6430
6431 * xterm.c (x_find_topmost_parent): New function.
6432 (x_set_frame_alpha): Find topmost parent window with
6433 x_find_topmost_parent and set the property there also (bug#9181).
6434 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6435
c74e9d86
PE
64362011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6437
6438 * callproc.c (Fcall_process): Avoid vfork clobbering
6439 the local vars buffer, coding_systems, current_dir.
6440
640c8776
SM
64412011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6442
6443 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6444
f26d0e4c
PE
64452011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6446
8a10d76c
PE
6447 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6448 so that it is not optimized away.
6449
f26d0e4c
PE
6450 * xdisp.c (compute_display_string_pos): Remove unused local.
6451
55439c61
EZ
64522011-08-02 Eli Zaretskii <eliz@gnu.org>
6453
6454 Fix slow cursor motion and scrolling in large buffers with
6455 selective display, like Org Mode buffers. (Bug#9218)
6456
6457 * dispextern.h (struct bidi_it): New member disp_prop_p.
6458
6459 * xdisp.c: Remove one-slot cache of display string positions.
6460 (compute_display_string_pos): Accept an additional argument
5e617bc2 6461 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6462 for a display string or property. If found, set DISP_PROP_P
6463 non-zero.
6464
6465 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6466 DISP_PROP_P, and pass it to compute_display_string_pos.
6467 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6468 non-zero. All callers of bidi_fetch_char changed.
6469
fb33fa43
SM
64702011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6471
6472 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6473
b099e063
DM
64742010-12-03 Don March <don@ohspite.net>
6475
6476 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6477 last character M-[char] is translated to ESC [char] (bug#7541).
6478
5cc7f7af
KH
64792011-08-02 Kenichi Handa <handa@m17n.org>
6480
d0fffa3f 6481 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6482
6483 * chartab.c (uniprop_table): Make it non-static.
6484
525d5e6e
EZ
64852011-08-01 Eli Zaretskii <eliz@gnu.org>
6486
6487 * xdisp.c (forward_to_next_line_start): Accept additional argument
6488 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6489 on the newline.
6490 (reseat_at_next_visible_line_start): Use the bidi iterator state
6491 returned by forward_to_next_line_start to restore the state of
6492 it->bidi_it after backing up to previous newline. (Bug#9212)
6493
31011111
AS
64942011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6495
6496 * regex.c (re_comp): Protoize.
6497 (re_exec): Fix return type.
6498 (regexec): Fix type of `ret'. (Bug#9203)
6499
476371c4
PE
65002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6501
e5d76069
PE
6502 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6503 This is needed if max-image-size is a floating-point number.
6504
9a79b20c
AS
65052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6506
6507 * print.c (print_object): Print empty symbol as ##.
6508
6509 * lread.c (read1): Read ## as empty symbol.
6510
d8c2fa78
AA
65112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6512
6513 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6514 setting frame foreground color (Bug#9175).
6515 (x_set_background_color): Likewise.
6516
ffe57a7a
AA
6517 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6518 contents (Bug#9176).
6519 (EmacsTooltip -init): Remove bezels and add shadows to
6520 tooltip windows.
6521
bf3492a5
AA
6522 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6523 or scroll bar (Bug#8470).
6524
d55e9c53
AA
6525 * nsfont.m (nsfont_open): Remove assignment to voffset and
6526 unnecessary vars hshink, expand, hd, full_height, min_height.
6527 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6528
6529 * nsterm.h (nsfont_info): Remove voffset field.
6530
d8c2fa78 65312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6532
6533 Implement strike-through and overline on NextStep (Bug#8863).
6534
6535 * nsfont.m (nsfont_open): Use underline position provided by font,
6536 instead of hard-coded value of 2.
6537 (nsfont_draw): Call ns_draw_text_decoration instead.
6538
6539 * nsterm.h: Add declaration for ns_draw_text_decoration.
6540
6541 * nsterm.m (ns_draw_text_decoration): New function for drawing
6542 underline, overline, and strike-through.
6543 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6544 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6545 accommodate underlining, etc.
4843aac3 6546
4cc60b9b
EZ
65472011-07-28 Eli Zaretskii <eliz@gnu.org>
6548
bc7ece87
EZ
6549 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6550 default.
4cc60b9b 6551
476371c4
PE
65522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6553
66606eea
PE
6554 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6555 Without this fix, if a signal arrives just after memory fills up,
6556 'malloc' might be invoked reentrantly.
6557
476371c4
PE
6558 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6559 In other words, assume that every image size is allowed, on non-X
6560 hosts. This assumption is probably wrong, but it lets Emacs compile.
6561
f3fcc40d
AS
65622011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6563
6564 * regex.c (re_iswctype): Convert return values to boolean.
6565
350c992f
EZ
65662011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6567
6568 * xdisp.c (compute_display_string_pos): Don't use cached display
6569 string position if the buffer had its restriction changed.
6570 (Bug#9184)
6571
5266b4bb
PE
65722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6573
6574 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6575
2573a837 65762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6577
41f55ccd 6578 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6579
39e378da
PE
6580 * bidi.c: Integer size and overflow fixes.
6581 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6582 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6583 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6584 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6585 (bidi_find_other_level_edge):
6586 Use ptrdiff_t instead of EMACS_INT where either will do.
6587 This works better on 32-bit hosts configured --with-wide-int.
6588 (bidi_cache_ensure_space): Check for size-calculation overflow.
6589 Use % rather than repeated addition, for better worst-case speed.
6590 Don't set bidi_cache_size until after xrealloc returns, because it
6591 might not return.
6592 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6593 (bidi_cache_ensure_space): Also check that the bidi cache size
6594 does not exceed that of the largest Lisp string or buffer. See Eli
6595 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6596
5e927815
PE
6597 * alloc.c (__malloc_size_t): Remove.
6598 All uses replaced by size_t. See Andreas Schwab's note
6599 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6600
ca4aa935
PE
6601 * image.c: Improve checking for integer overflow.
6602 (check_image_size): Assume that f is nonnull, since
6603 it is always nonnull in practice. This is one less thing to
6604 worry about when checking for integer overflow later.
6605 (x_check_image_size): New function, which checks for integer
6606 overflow issues inside X.
6607 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6608 This removes the need for a memory_full check.
6609 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6610 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6611 (xbm_read_bitmap_data): Change locals back to 'int', since
6612 their values must fit in 'int'.
6613 (xpm_load_image, png_load, tiff_load):
6614 Invoke x_create_x_image_and_pixmap earlier,
6615 to avoid much needless work if the image is too large.
6616 (tiff_load): Treat overly large images as if
6617 x_create_x_image_and_pixmap failed, not as malloc failures.
6618 (gs_load): Use x_check_image_size.
6619
5f8f9cc2
PE
6620 * gtkutil.c: Omit integer casts.
6621 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6622 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6623
5adf60bc
PE
6624 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6625
c8907a93
PE
6626 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6627 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6628 would wrongly return t on a 64-bit host.
6629
e3c25c68
PE
6630 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6631 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6632 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6633 and therefore cause GCC to emit a bogus diagnostic in some cases.
6634
3f791afe
PE
6635 * image.c: Integer signedness and overflow and related fixes.
6636 This is not an exhaustive set of fixes, but it's time to
6637 record what I've got.
6638 (lookup_pixel_color, check_image_size): Remove redundant decls.
6639 (check_image_size): Don't assume that arbitrary EMACS_INT values
6640 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6641 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6642 (tiff_load, imagemagick_load_image):
6643 Check for overflow in size calculations.
6644 (x_create_x_image_and_pixmap): Remove unnecessary test for
6645 xmalloc returning NULL; that can't happen.
6646 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6647 (xpm_color_bucket): Use better integer hashing function.
6648 (xpm_cache_color): Don't possibly over-allocate memory.
6649 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6650 (gif_memory_source):
6651 Use ptrdiff_t, not int or size_t, to record sizes.
6652 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6653 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6654 either works, as we prefer signed integers.
6655 (tiff_read_from_memory, tiff_write_from_memory):
6656 Return tsize_t, not size_t, since that's what the TIFF API wants.
6657 (tiff_read_from_memory): Don't fail simply because the read would
6658 go past EOF; instead, return a short read.
6659 (tiff_load): Omit no-longer-needed casts.
6660 (Fimagemagick_types): Don't assume size fits into 'int'.
6661
3cc5a532
PE
6662 Improve hashing quality when configured --with-wide-int.
6663 * fns.c (hash_string): New function, taken from sxhash_string.
6664 Do not discard information about ASCII character case; this
6665 discarding is no longer needed.
6666 (sxhash-string): Use it. Change sig to match it. Caller changed.
6667 * lisp.h: Declare it.
6668 * lread.c (hash_string): Remove, since we now use fns.c's version.
6669 The fns.c version returns a wider integer if --with-wide-int is
6670 specified, so this should help the quality of the hashing a bit.
6671
b312a492
PE
6672 * emacs.c: Integer overflow minor fix.
6673 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6674 Define only if GNU_LINUX.
6675 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6676
dfd153ae
PE
6677 * dispnew.c: Integer signedness and overflow fixes.
6678 Remove unnecessary forward decls, that were a maintenance hassle.
6679 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6680 All uses changed.
6681 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6682 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6683 (prepare_desired_row, line_draw_cost):
6684 Use int, not unsigned, where either works.
6685 (save_current_matrix, restore_current_matrix):
6686 Use ptrdiff_t, not size_t, where either works.
6687 (init_display): Check for overflow more accurately, and without
6688 relying on undefined behavior.
6689
a81d11a3
PE
6690 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6691 Remove, replacing with the new symbols in lisp.h. All uses changed.
6692 * fileio.c (make_temp_name):
6693 * filelock.c (lock_file_1, lock_file):
6694 * xdisp.c (message_dolog):
6695 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6696 Use pMd etc. instead.
6697 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6698 replacing the pWIDE etc. symbols removed from editfns.c.
6699
3300e6fd
PE
6700 * keyboard.h (num_input_events): Now uintmax_t.
6701 This is (very slightly) less likely to mess up due to wraparound.
6702 All uses changed.
6703
fd05c7e9
PE
6704 * buffer.c: Integer signedness fixes.
6705 (alloc_buffer_text, enlarge_buffer_text):
6706 Use ptrdiff_t rather than size_t when either will do, as we prefer
6707 signed integers.
6708
903fe15d
PE
6709 * alloc.c: Integer signedness and overflow fixes.
6710 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6711 (__malloc_size_t): Default to size_t, not to int.
6712 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6713 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6714 Prefer ptrdiff_t to size_t when either would do, as we prefer
6715 signed integers.
6716 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6717 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6718 Now const. Initialize with values that are in range even if char
6719 is signed.
6720 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6721 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6722 These functions do the right thing with sizes > 2**32.
6723 (check_depth): Now ptrdiff_t, not int.
6724 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6725 Adjust to new way of storing sizes. Check for size overflow bugs
6726 in rest of code.
6727 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6728 slightly wrong anyway, as it missed one instance of
6729 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6730 (refill_memory_reserve): Omit needless cast to size_t.
6731 (mark_object_loop_halt): Mark as externally visible.
6732
ac82cc6a
PE
6733 * xselect.c: Integer signedness and overflow fixes.
6734 (Fx_register_dnd_atom, x_handle_dnd_message):
6735 Use ptrdiff_t, not size_t, since we prefer signed.
6736 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6737 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6738 x_dnd_atoms_size and x_dnd_atoms_length.
6739
c2d1e36d
PE
6740 * doprnt.c: Prefer signed to unsigned when either works.
6741 * eval.c (verror):
6742 * doprnt.c (doprnt):
6743 * lisp.h (doprnt):
6744 * xdisp.c (vmessage):
6745 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6746 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6747 prefer signed arithmetic to avoid comparison confusion.
6748 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6749 but is a bit tricky.
6750
0e926e56
PE
6751 Assume freestanding C89 headers, string.h, stdlib.h.
6752 * data.c, doprnt.c, floatfns.c, print.c:
6753 Include float.h unconditionally.
6754 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6755 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6756 * regex.c: Likewise for stddef.h, string.h.
6757 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6758 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6759 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6760 (STDC_HEADERS): Remove obsolete defines.
6761 * sysdep.c: Include limits.h unconditionally.
6762
9cfdb3ec
PE
6763 Assume support for memcmp, memcpy, memmove, memset.
6764 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6765 * regex.c (memcmp, memcpy):
6766 Remove; we assume C89 now.
6767
6768 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6769 (__malloc_safe_bcopy): Remove; no longer needed.
6770
cf950e6b 6771 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6772 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6773 well either way, and we prefer signed to unsigned.
6774
dbf38e02
LMI
67752011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6776
6777 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6778 closes the connection while we're reading (bug#9182).
6779
d6f0886c 67802011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6781
d6f0886c
JD
6782 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6783 are specified (Bug#9168).
24e0f6b1 6784
2eb1f9e6
PE
67852011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6786
6787 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6788 Found by GCC static checking and --with-wide-int on a 32-bit host.
6789
22381272 67902011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6791
6792 * xdisp.c (compute_display_string_pos): Fix logic of caching
6793 previous display string position. Initialize cached_prev_pos to
6794 -1. Fixes slow-down at the beginning of a buffer.
6795
f25e39b4
EZ
67962011-07-24 Eli Zaretskii <eliz@gnu.org>
6797
6798 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6799 for attrs[LFACE_FONTSET_INDEX].
6800
04c4b52e
PE
68012011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6802
6803 * xml.c (parse_region): Remove unused local
6804 that was recently introduced.
6805
c1734fbd
EZ
68062011-07-23 Eli Zaretskii <eliz@gnu.org>
6807
be18c5a5
EZ
6808 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6809 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6810
c1734fbd
EZ
6811 * xdisp.c (move_it_in_display_line_to): Record the best matching
6812 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6813 exit if none of the characters scanned was an exact match.
6814 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6815 when exact match is impossible due to invisible text, and the
6816 lines are truncated.
6817
a258d627
JD
68182011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6819
6820 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6821 for OSX >= 10.7.
6822
b6d5a689
EZ
68232011-07-22 Eli Zaretskii <eliz@gnu.org>
6824
0f74f785
EZ
6825 Fix a significant slow-down of cursor motion with C-n, C-p,
6826 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6827 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6828 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6829 (next_element_from_buffer): Call compute_stop_pos_backwards to
6830 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6831 base_level_stop.
6832 (reseat): Don't look for prev_stop, as that could mean a very long
6833 run.
6834 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6835 <cached_disp_overlay_modiff>: Cache for last found display string
6836 position.
551918c1 6837 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6838 about the same buffer in the same area of character positions, and
6839 the buffer wasn't changed since the time the display string
6840 position was cached.
551918c1 6841
b2d0c91a
EZ
68422011-07-22 Eli Zaretskii <eliz@gnu.org>
6843
6844 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6845 is an integer, which is important for empty lines. (Bug#9149)
6846
043604ee
CY
68472011-07-22 Chong Yidong <cyd@stupidchicken.com>
6848
6849 * frame.c (Fmodify_frame_parameters): In tty case, update the
6850 default face if necessary (Bug#4238).
6851
da4adb04
CY
68522011-07-21 Chong Yidong <cyd@stupidchicken.com>
6853
6854 * editfns.c (Fstring_to_char): No need to explain what a character
6855 is in the docstring (Bug#6576).
6856
9abd0532
LMI
68572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6858
6859 * xml.c (parse_region): Make sure we always return a tree.
6860
36881d16
HK
68612011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6862
6863 * xml.c (parse_region): If a document contains only comments,
6864 return that, too.
6865
1e98674d
LMI
68662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6867
6868 * xml.c (make_dom): Return comments, too.
6869
590bd467
PE
68702011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6871
6872 Port to OpenBSD.
6873 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6874 and the surrounding thread.
6875 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6876 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6877 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6878 timer goes off.
6879 * s/openbsd.h (BROKEN_SIGIO): Define.
6880 * unexelf.c (unexec) [__OpenBSD__]:
6881 Don't update the .mdebug section of the Alpha COFF symbol table.
6882
f41628b2
LMI
68832011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6884
6885 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6886 (bug#8460).
6887
b59b67c5
PE
68882011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6889
15e3a074
PE
6890 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6891 This fixes some race conditions on the permissions of any newly
6892 created file.
6893
41bed37d
PE
6894 * alloc.c (valid_pointer_p): Use pipe, not open.
6895 This fixes some permissions issues when debugging.
6896
b59b67c5
PE
6897 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6898 If fchown fails to set both uid and gid, try to set just gid,
6899 as that is sometimes allowed. Adjust the file's mode to eliminate
6900 setuid or setgid bits that are inappropriate if fchown fails.
6901
925a6be7
SM
69022011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6903
6904 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6905 to compare Lisp_Objects.
6906 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6907 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6908 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6909
52968808
AS
69102011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6911
0a6a104b
AS
6912 * lread.c (read_integer): Unread even EOF character.
6913 (read1): Likewise. Properly record start position of symbol.
6914
52968808
AS
6915 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6916 symbol character follows.
6917
9e381cdd
PE
69182011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6919
6920 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6921 This works around a problem with the previous change to Fcopy_file.
6922 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6923 and without this change, GCC might complain about discarding
6924 fchown's return value.
6925
b5641435
JB
69262011-07-16 Juanma Barranquero <lekktu@gmail.com>
6927
6928 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6929
a8031457
PE
69302011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6931
6932 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6933
dd889327
LMI
69342011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6935
750c33f7
LMI
6936 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6937 it's used from the C level.
6938
dd889327
LMI
6939 * process.c: Use the same condition for POLL_FOR_INPUT in both
6940 keyboard.c and process.c (bug#1858).
6941
87e86684
LM
69422011-07-09 Lawrence Mitchell <wence@gmx.li>
6943
6944 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6945 (Fgnutls_boot): Use it.
6946
64348f40
AS
69472011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6948
6949 * doc.c (Fsubstitute_command_keys): Revert last change.
6950
1d698799
LMI
69512011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6952
f863868c
LMI
6953 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6954 quotes the next character, and doesn't affect other longer
6955 sequences (bug#8935).
6956
1d698799
LMI
6957 * lread.c (syms_of_lread): Clarify that is isn't only
6958 `eval-buffer' and `eval-defun' that's affected by
6959 `lexical-binding' (bug#8460).
6960
aa4b6df6
EZ
69612011-07-15 Eli Zaretskii <eliz@gnu.org>
6962
6963 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6964 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6965
5d856da6
PE
69662011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6967
ad6042bb
PE
6968 Fix minor problems found by static checking.
6969 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6970 (elsz): Now a signed constant, not a size_t var. We prefer signed
6971 types to unsigned, to avoid integer comparison confusion. Without
6972 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6973 "cannot optimize loop, the loop counter may overflow", a symptom
6974 of the confusion.
f00bbb22 6975 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6976 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6977
6468f31c
LMI
69782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6979
49080b10
LMI
6980 * search.c (Fre_search_backward): Mention `case-fold-search' in
6981 all the re_search_* functions (bug#8138).
6982
6468f31c
LMI
6983 * keyboard.c (Fopen_dribble_file): Document when the file is
6984 closed (bug#8056).
6985
c965adc5
EZ
69862011-07-14 Eli Zaretskii <eliz@gnu.org>
6987
df9733bf
EZ
6988 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6989 bidi_cache_idx.
6990
0bb23927
EZ
6991 Support bidi reordering of display and overlay strings.
6992 * xdisp.c (compute_display_string_pos)
6993 (compute_display_string_end): Accept additional argument STRING.
6994 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6995 (reseat_to_string): Initialize bidi_it->string.s and
6996 bidi_it->string.schars.
6997 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6998 NULL (avoids a crash in bidi_paragraph_init).
6999 Initialize itb.string.lstring.
0bb23927
EZ
7000 (init_iterator): Call bidi_init_it only of a valid
7001 buffer position was specified. Initialize paragraph_embedding to
7002 L2R.
7003 (reseat_to_string): Initialize the bidi iterator.
7004 (display_string): If we need to ignore text properties of
7005 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7006 original value of -1 will not work with bidi.)
7007 (compute_display_string_pos): First arg is now struct
7008 `text_pos *'; all callers changed. Support display properties on
7009 Lisp strings.
7010 (compute_display_string_end): Support display properties on Lisp
7011 strings.
7012 (init_iterator, reseat_1, reseat_to_string): Initialize the
7013 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7014 when iterating on a string not from display properties).
640c8776
SM
7015 (compute_display_string_pos, compute_display_string_end):
7016 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7017 arrow keys.
7018 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7019 base_level_stop; instead, set base_level_stop to BEGV.
7020 Fixes crashes in vertical-motion.
0bb23927
EZ
7021 (next_element_from_buffer): Improve commentary for when
7022 the iterator is before prev_stop.
7023 (init_iterator): Initialize bidi_p from the default value of
7024 bidi-display-reordering, not from buffer-local value. Use the
7025 buffer-local value only if initializing for buffer iteration.
7026 (handle_invisible_prop): Support invisible properties on strings
7027 that are being bidi-reordered.
7028 (set_iterator_to_next): Support bidi reordering of C strings and
7029 Lisp strings.
7030 (next_element_from_string): Support bidi reordering of Lisp
7031 strings.
7032 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7033 (display_string): Support display of R2L glyph rows.
7034 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7035 (init_iterator): Don't initialize it->bidi_p for strings
7036 here.
7037 (reseat_to_string): Initialize it->bidi_p for strings here.
7038 (next_element_from_string, next_element_from_c_string)
7039 (next_element_from_buffer): Add xassert's for correspondence
7040 between IT's object being iterated and it->bidi_it.string
7041 structure.
7042 (face_before_or_after_it_pos): Support bidi iteration.
7043 (next_element_from_c_string): Handle the case of the first string
7044 character that is not the first one in the visual order.
7045 (get_visually_first_element): New function, refactored from common
7046 parts of next_element_from_buffer, next_element_from_string, and
7047 next_element_from_c_string.
7048 (tool_bar_lines_needed, redisplay_tool_bar)
7049 (display_menu_bar): Force left-to-right direction. Add a FIXME
7050 comment for making that be controlled by a user option.
7051 (push_it, pop_it): Save and restore the state of the
7052 bidi iterator. Save and restore the bidi_p flag.
7053 (pop_it): Iterate out of display property for string iteration as
7054 well.
7055 (iterate_out_of_display_property): Support iteration over strings.
7056 (handle_single_display_spec): Set up it->bidi_it for iteration
7057 over a display string, and call bidi_init_it.
7058 (handle_single_display_spec, next_overlay_string)
7059 (get_overlay_strings_1, push_display_prop): Set up the bidi
7060 iterator for displaying display or overlay strings.
7061 (forward_to_next_line_start): Don't use the shortcut if
7062 bidi-iterating.
7063 (back_to_previous_visible_line_start): If handle_display_prop
7064 pushed the iterator stack, restore the internal state of the bidi
7065 iterator by calling bidi_pop_it same number of times.
7066 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7067 and we are bidi-iterating, don't decrement the iterator position;
7068 instead, set the first_elt flag in the bidi iterator, to produce
7069 the same effect.
7070 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7071 (push_display_prop): xassert that we are iterating a buffer.
7072 (push_it, pop_it): Save and restore paragraph_embedding member.
7073 (handle_single_display_spec, next_overlay_string)
7074 (get_overlay_strings_1, reseat_1, reseat_to_string)
7075 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7076 correctly. Don't assume unibyte strings are not bidi-reordered.
7077 (compute_display_string_pos)
7078 (compute_display_string_end): Fix handling the case of C string.
7079 (push_it, pop_it): Save and restore from_disp_prop_p.
7080 (handle_single_display_spec, push_display_prop): Set the
7081 from_disp_prop_p flag.
7082 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7083 (pop_it): Call iterate_out_of_display_property only if we are
7084 popping after iteration over a string that came from a display
7085 property. Fix a typo in popping stretch info. Add an assertion
7086 for verifying that the iterator position is in sync with the bidi
7087 iterator.
7088 (handle_single_display_spec, get_overlay_strings_1)
7089 (push_display_prop): Fix initialization of paragraph direction for
7090 string when that of the parent object is not yet determined.
7091 (reseat_1): Call bidi_init_it to resync the bidi
7092 iterator with IT's position. (Bug#7616)
7093 (find_row_edges): If ROW->start.pos gives position
7094 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7095 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7096 Reset the from_disp_prop_p flag.
7097 (SAVE_IT, RESTORE_IT): New macros.
7098 (pos_visible_p, face_before_or_after_it_pos)
7099 (back_to_previous_visible_line_start)
7100 (move_it_in_display_line_to, move_it_in_display_line)
7101 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7102 (try_scrolling, redisplay_window, display_line): Use them when
7103 saving a temporary copy of the iterator and restoring it back.
7104 (back_to_previous_visible_line_start, reseat_1)
7105 (init_iterator): Empty the bidi cache "stack".
7106 (move_it_in_display_line_to): If iterator ended up at
7107 EOL, but we never saw any buffer positions smaller than
7108 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7109 motion in bidi-reordered lines.
7110 (move_it_in_display_line_to): Record prev_method and prev_pos
7111 immediately before the call to set_iterator_to_next. Fixes cursor
7112 motion in bidi-reordered lines with stretch glyphs and strings
7113 displayed in margins. (Bug#8133) (Bug#8867)
7114 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7115 TO_CHARPOS.
640c8776
SM
7116 (pos_visible_p): Support positions in bidi-reordered lines.
7117 Save and restore bidi cache.
0bb23927
EZ
7118
7119 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7120 (bidi_paragraph_info): Delete unused struct.
7121 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7122 (bidi_cache_start): New variable.
7123 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7124 to zero.
7125 (bidi_cache_fetch_state, bidi_cache_search)
7126 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7127 (bidi_cache_find, bidi_peek_at_next_level)
7128 (bidi_level_of_next_char, bidi_find_other_level_edge)
7129 (bidi_move_to_visually_next): Compare cache index with
7130 bidi_cache_start rather than with zero.
7131 (bidi_fetch_char): Accept new argument STRING; all callers
7132 changed. Support iteration over a string. Support strings with
7133 display properties. Support unibyte strings. Fix the type of
7134 `len' according to what STRING_CHAR_AND_LENGTH expects.
7135 (bidi_paragraph_init, bidi_resolve_explicit_1)
7136 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7137 (bidi_level_of_next_char, bidi_move_to_visually_next):
7138 Support iteration over a string.
0bb23927
EZ
7139 (bidi_set_sor_type, bidi_resolve_explicit_1)
7140 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7141 can now be zero (for strings); special values 0 and -1 were
7142 changed to -1 and -2, respectively.
7143 (bidi_char_at_pos): New function.
7144 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7145 Call it instead of FETCH_MULTIBYTE_CHAR.
7146 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7147 initialized to valid values.
7148 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7149 values.
7150 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7151 the test for valid cached positions. Fix the logic for looking up
7152 the sentinel state in the cache. GCPRO the Lisp string we are
7153 iterating.
7154 (bidi_push_it, bidi_pop_it): New functions.
7155 (bidi_initialize): Initialize the bidi cache start stack pointer.
7156 (bidi_cache_ensure_space): New function, refactored from part of
7157 bidi_cache_iterator_state. Don't assume the required size is just
7158 one BIDI_CACHE_CHUNK away.
7159 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7160 (bidi_count_bytes, bidi_char_at_pos): New functions.
7161 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7162 always valid if bidi_cache_idx is valid.
7163 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7164 is valid if it's going to be used.
7165 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7166 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7167 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7168 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7169 (bidi_find_other_level_edge, bidi_cache_start_stack):
7170 All variables related to cache indices are now EMACS_INT.
c965adc5 7171
0bb23927
EZ
7172 * dispextern.h (struct bidi_string_data): New structure.
7173 (struct bidi_it): New member `string'. Make flag members be 1-bit
7174 fields, and put them last in the struct.
640c8776
SM
7175 (compute_display_string_pos, compute_display_string_end):
7176 Update prototypes.
0bb23927
EZ
7177 (bidi_push_it, bidi_pop_it): Add prototypes.
7178 (struct iterator_stack_entry): New members bidi_p,
7179 paragraph_embedding, and from_disp_prop_p.
7180 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7181 (bidi_shelve_cache, bidi_unshelve_cache):
7182 Declare prototypes.
0bb23927
EZ
7183
7184 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7185 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7186 and vector-like objects.
7187
7188 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7189 cache around display iteration.
7190
7191 * window.c (Fwindow_end, window_scroll_pixel_based)
7192 (displayed_window_lines, Frecenter): Save and restore the bidi
7193 cache around display iteration.
7194
3bbd2265
LMI
71952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7196
7197 * editfns.c (Fdelete_region): Clarify the use of the named
7198 parameters (bug#6788).
7199
adc47434
MR
72002011-07-14 Martin Rudalics <rudalics@gmx.at>
7201
7202 * indent.c (Fvertical_motion): Set and restore w->pointm when
7203 saving and restoring the window's buffer (Bug#9006).
7204
837c31f8
LMI
72052011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7206
7207 * editfns.c (Fstring_to_char): Clarify just what is returned
7208 (bug#6576). Text by Eli Zaretskii.
7209
ac389d0c
JB
72102011-07-13 Juanma Barranquero <lekktu@gmail.com>
7211
7212 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7213
0be0ce47
EZ
72142011-07-13 Eli Zaretskii <eliz@gnu.org>
7215
7216 * buffer.c (mmap_find): Fix a typo.
7217
cd18e7e3
JB
72182011-07-13 Johan Bockgård <bojohan@gnu.org>
7219
7220 Fix execution of x selection hooks.
7221 * xselect.c (Qx_lost_selection_functions)
7222 (Qx_sent_selection_functions): New vars.
7223 (syms_of_xselect): DEFSYM them.
7224 (x_handle_selection_request): Pass Qx_sent_selection_functions
7225 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7226 (x_handle_selection_clear,x_clear_frame_selections):
7227 Pass Qx_lost_selection_functions rather than
7228 Vx_lost_selection_functions to Frun_hook_with_args.
7229
47ea7f44
PE
72302011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7231
ac389d0c 7232 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7233 The old code sometimes used this field without initializing it.
7234
47ea7f44
PE
7235 * alloc.c (gc_sweep): Don't read past end of array.
7236 In theory, the old code could also have corrupted Emacs internals,
7237 though it'd be very unlikely.
7238
bc985c87
AS
72392011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7240
7241 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7242 argument. (Bug#4026)
bc985c87 7243
0cf34688
LMI
72442011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7245
b3dadd76
LMI
7246 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7247 key" (bug#4257).
7248
0cf34688
LMI
7249 * window.c (Fset_window_start): Doc fix (bug#4199).
7250 (Fset_window_hscroll): Ditto.
7251
270768cd
PE
72522011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7253
077e3dda 7254 Fix minor new problems caught by GCC 4.6.1.
270768cd 7255 * term.c (init_tty): Remove unused local.
490011a6 7256 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7257 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7258 not used otherwise.
270768cd 7259
b1f58454
CY
72602011-07-12 Chong Yidong <cyd@stupidchicken.com>
7261
7262 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7263
22b9578d
LMI
72642011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7265
6e70ab07
LMI
7266 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7267 are the mini-buffer and the echo area (bug#3320).
7268
22b9578d
LMI
7269 * term.c (init_tty): Remove support for supdup, c10 and perq
7270 terminals, which are no longer supported (bug#1482).
7271
8974cc9f
JB
72722011-07-10 Johan Bockgård <bojohan@gnu.org>
7273
7274 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7275
a560d974
JD
72762011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7277
7278 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7279 for non-popups (Bug#3642).
7280
1dae0f0a
AS
72812011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7282
268c2c36 7283 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7284 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7285 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7286 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7287 * data.c (fmod): Likewise.
7288 * dispnew.c (swap_glyphs_in_rows): Likewise.
7289 * emacs.c (memory_warning_signal): Likewise.
7290 * floatfns.c (float_error): Likewise.
7291 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7292 (otf_open, font_otf_capability, generate_otf_features)
7293 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7294 Likewise.
7295 * image.c (pbm_read_file): Likewise.
7296 * indent.c (string_display_width): Likewise.
7297 * intervals.c (check_for_interval, search_for_interval)
7298 (inc_interval_count, count_intervals, root_interval)
7299 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7300 * lread.c (defalias): Likewise.
268c2c36 7301 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7302 * regex.c (set_image_of_range_1, set_image_of_range)
7303 (regex_grow_registers): Likewise.
7304 * sysdep.c (strerror): Likewise.
7305 * termcap.c (valid_filename_p, tprint, main): Likewise.
7306 * tparam.c (main): Likewise.
7307 * unexhp9k800.c (run_time_remap, save_data_space)
7308 (update_file_ptrs, read_header, write_header, calculate_checksum)
7309 (copy_file, copy_rest, display_header): Likewise.
7310 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7311 Likewise.
7312 * xdisp.c (check_it): Likewise.
7313 * xfaces.c (register_color, unregister_color, unregister_colors):
7314 Likewise.
7315 * xfns.c (print_fontset_result): Likewise.
7316 * xrdb.c (member, fatal, main): Likewise.
7317
99033785
PE
73182011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7319
7320 Fix minor problems found by static checking (Bug#9031).
7321 * chartab.c (char_table_set_range, map_sub_char_table):
7322 Remove unused locals.
7323 (uniprop_table): Now static.
7324 * composite.c (_work_char): Remove unused static var.
7325
9cb2ac56
JB
73262011-07-09 Juanma Barranquero <lekktu@gmail.com>
7327
7328 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7329
f25661f0
JD
73302011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7331
7332 * gtkutil.c (qttip_cb): Remove code without function.
7333
8278c4fe
EZ
73342011-07-09 Eli Zaretskii <eliz@gnu.org>
7335
7336 * w32.c (pthread_sigmask): New stub.
7337
1692ae2d 73382011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7339
8a6ebd58 7340 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7341 sigprocmask is portable only for single-threaded applications, and
7342 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7343 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7344 (LIBES): Use it.
7345 * callproc.c (Fcall_process):
7346 * process.c (create_process):
7347 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7348 Use pthread_sigmask, not sigprocmask.
123403e4 7349
1b854618
JD
73502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7351
7352 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7353 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7354 wrong (Bug#8591).
7355
3fe4b549
JD
73562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7357
0ce7e563
JD
7358 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7359 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7360 (xg_hide_tooltip): Fix comment.
7361
3fe4b549
JD
7362 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7363 in registerServicesMenuSendTypes.
7364 (validRequestorForSendType): Don't check ns_return_types.
7365
7366 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7367 ns_return_type.
7368
5df75e47
JR
73692011-07-08 Jason Rumney <jasonr@gnu.org>
7370
22610910
JR
7371 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7372 SH_SHOW for hidden windows (Bug#5482).
7373
5df75e47
JR
7374 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7375 frame struct members of non-existent frames (Bug#6284).
7376
699c10bd
JD
73772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7378
4393663b
JD
7379 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7380 variable firstTime not needed on OSX >= 10.6.
7381 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7382 >= 10.5. Use setKnobProportion, setDoubleValue.
7383
7384 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7385 (MAC_OS_X_VERSION_10_5): Define if not defined.
7386 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7387 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7388 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7389
7390 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7391 cString and lossyCString on OSX >= 10.4
7392
58179cce 7393 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7394 sizeToFit on OSX >= 10.2.
7395
7396 * nsimage.m (allocInitFromFile): Don't use deprecated method
7397 bestRepresentationForDevice on OSX >= 10.6.
7398
7399 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7400 to avoid warning.
7401
7402 * emacs.c: Declare unexec_init_emacs_zone.
7403
a63e0781
JD
7404 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7405
699c10bd
JD
7406 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7407
7408 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7409 on svcsMenu (Bug#8842).
7410
7411 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7412 ns_return_types.
7413 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7414
7415 * nsterm.m (QUTF8_STRING): Declare.
7416 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7417 (validRequestorForSendType): Return type is (id).
7418 Change indexOfObjectIdenticalTo to indexOfObject.
7419 Check if we have local selection before returning self (Bug#8842).
7420 (writeSelectionToPasteboard): Put local selection into paste board
7421 if we have a local selection (Bug#8842).
7422 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7423
7424 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7425 (ns_get_local_selection): Declare.
7426
54e10184
LMI
74272011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7428
9888ff71
LMI
7429 * keymap.c (describe_map_tree): Don't insert a double newline at
7430 the end of the buffer (bug#1169) and return whether we inserted
7431 something.
7432
54e10184
LMI
7433 * callint.c (Fcall_interactively): Change "reading args" to
7434 "providing args" to try to clarify what it does (bug#1010).
7435
15fa4783
KH
74362011-07-07 Kenichi Handa <handa@m17n.org>
7437
7438 * composite.c (composition_compute_stop_pos): Ignore a static
7439 composition starting before CHARPOS (Bug#8915).
7440
7441 * xdisp.c (handle_composition_prop): Likewise.
7442
a8815b00
EZ
74432011-07-07 Eli Zaretskii <eliz@gnu.org>
7444
7445 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7446 (Bug#9015)
7447
ef7b981d 74482011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7449
7450 * character.h (unicode_category_t): New enum type.
7451
7452 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7453 (Qchar_code_property_table): New variable.
7454 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7455 (UNIPROP_COMPRESSED_FORM_P): New macros.
7456 (char_table_ascii): Uncompress the compressed values.
7457 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7458 Uncompress the compressed values.
ac389d0c 7459 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7460 (char_table_ref_and_range): Uncompress the compressed values.
7461 (sub_char_table_set): New arg is_uniprop. Callers changed.
7462 Uncompress the compressed values.
7463 (sub_char_table_set_range): Args changed. Callers changed.
7464 (char_table_set_range): Adjuted for the above change.
7465 (map_sub_char_table): Delete args default_val and parent. Add arg
7466 top. Give decoded values to a Lisp function.
640c8776 7467 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7468 values to a Lisp function. Gcpro more variables.
7469 (uniprop_table_uncompress)
7470 (uniprop_decode_value_run_length): New functions.
7471 (uniprop_decoder, uniprop_decoder_count): New variables.
7472 (uniprop_get_decoder, uniprop_encode_value_character)
7473 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7474 New functions.
7475 (uniprop_encoder, uniprop_encoder_count): New variables.
7476 (uniprop_get_encoder, uniprop_table)
7477 (Funicode_property_table_internal, Fget_unicode_property_internal)
7478 (Fput_unicode_property_internal): New functions.
7479 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7480 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7481 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7482 char-code-property-alist.
7483
640c8776 7484 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7485 Vunicode_category_table.
7486
640c8776 7487 * font.c (font_range): Adjust for the change of
c805dec0
KH
7488 Vunicode_category_table.
7489
76b397fb
DN
74902011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7491
7492 * m/iris4d.h: Remove file, move contents ...
7493 * s/irix6-5.h: ... here.
7494
22b4128e
PE
74952011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7496
7497 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7498 * alloc.c (mark_buffer):
7499 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7500 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7501 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7502 This isn't true in general, and it's particularly not true
7503 if Emacs is configured with --with-wide-int.
7504 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7505 New macros, used in the buffer.c change.
7506
869795d6
JD
75072011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7508
7509 * xsettings.c: Use both GConf and GSettings if both are available.
7510 (store_config_changed_event): Add comment.
7511 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7512 (store_tool_bar_style_changed): New functions.
5e617bc2 7513 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7514 (struct xsettings): Move font inside HAVE_XFT.
7515 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7516 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7517 Move inside HAVE_XFT.
640c8776 7518 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7519 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7520 also.
7521 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7522 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7523 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7524 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7525 (parse_settings): Move check for font inside HAVE_XFT.
7526 (read_settings, apply_xft_settings): Add comment.
7527 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7528 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7529 call store_font_name_changed.
7530 (xft_settings_event): Add comment.
7531 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7532 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7533 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7534 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7535 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7536 (xsettings_get_system_font, xsettings_get_system_normal_font):
7537 Add comment.
869795d6 7538
d8ed26bd
PE
75392011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7540
7541 Random fixes. E.g., (random) never returned negative values.
7542 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7543 subseconds part to the entropy, as that's a bit more random.
7544 Prefer signed to unsigned, since the signedness doesn't matter and
7545 in general we prefer signed. When given a limit, use a
7546 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7547 latter isn't right if USE_2_TAGS_FOR_INTS.
7548 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7549 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7550
cabf1cac
SM
75512011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7552
7553 * textprop.c (text_property_stickiness):
7554 Obey Vtext_property_default_nonsticky.
7555 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7556 * w32fns.c (syms_of_w32fns):
7557 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7558
6e9b2be9
PE
75592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7560
7561 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7562 This is more efficient than Ffile_directory_p and avoids a minor race.
7563
90186c68
LMI
75642011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7565
7c301272
LMI
7566 * buffer.c (Foverlay_put): Say what the return value is
7567 (bug#7835).
7568
c4f2d8d4
LMI
7569 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7570 is a directory before asking whether to use the file name
7571 (bug#7564).
ad637907
LMI
7572 (barf_or_query_if_file_exists): Make the "File is a directory"
7573 error be more correct.
c4f2d8d4 7574
90186c68
LMI
7575 * fns.c (Frequire): Remove the mention of the .gz files, since
7576 that's installation-specific, but keep the mention of
7577 `get-load-suffixes'.
7578
da64016e
PE
75792011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7580
7581 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7582 Report string overflow if the output is too long.
7583
7d47b580
JB
75842011-07-04 Juanma Barranquero <lekktu@gmail.com>
7585
a555cb87
JB
7586 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7587 (syms_of_gnutls): Remove duplicate DEFSYM for
7588 Qgnutls_bootprop_verify_hostname_error, an error for
7589 Qgnutls_bootprop_verify_error (which is no longer used).
7590
7d47b580
JB
7591 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7592 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7593 Also (re)move comments that are misplaced or no longer relevant.
7594
1e49bfab
LMI
75952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7596
7597 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7598
1485f4c0
CY
75992011-07-03 Chong Yidong <cyd@stupidchicken.com>
7600
7601 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7602 and background color parameters if they have been changed.
7603
a9ab721e
LMI
76042011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7605
7606 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7607
cf7cff57
PE
76082011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7609
2e13213d
PE
7610 * xsettings.c (SYSTEM_FONT): Define only when used.
7611 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7612
cf7cff57
PE
7613 * keymap.c (access_keymap_1): Now static.
7614
7a8e04f7
CY
76152011-07-02 Chong Yidong <cyd@stupidchicken.com>
7616
7617 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7618 leave any prefix arg for the up event (Bug#1586).
7619
61352f62
LMI
76202011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7621
69bb1ef7
LMI
7622 * lread.c (syms_of_lread): Mention single symbols defined by
7623 `defvar' or `defconst' (bug#7154).
7624
61352f62 7625 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7626 (Frequire): Mention get-load-suffixes.
61352f62 7627
28545e04
MR
76282011-07-02 Martin Rudalics <rudalics@gmx.at>
7629
7630 * window.h (window): Remove clone_number slot.
7631 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7632 Remove.
7633 (make_parent_window, make_window, saved_window)
7634 (Fset_window_configuration, save_window_save): Don't deal with
7635 clone numbers.
7636 * buffer.c (Qclone_number): Remove declaration.
7637 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7638
3349e122
SM
76392011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7640
7641 Add multiple inheritance to keymaps.
7642 * keymap.c (Fmake_composed_keymap): New function.
7643 (Fset_keymap_parent): Simplify.
7644 (fix_submap_inheritance): Remove.
7645 (access_keymap_1): New function extracted from access_keymap to handle
7646 embedded parents and handle lists of maps.
7647 (access_keymap): Use it.
7648 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7649 (Fcopy_keymap): Handle embedded parents.
7650 (Fcommand_remapping, define_as_prefix): Simplify.
7651 (Fkey_binding): Simplify.
7652 (syms_of_keymap): Move minibuffer-local-completion-map,
7653 minibuffer-local-filename-completion-map,
7654 minibuffer-local-must-match-map, and
7655 minibuffer-local-filename-must-match-map to Elisp.
7656 (syms_of_keymap): Defsubr make-composed-keymap.
7657 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7658 (parse_menu_item): Trivial simplification.
7659
3279eb87
GM
76602011-07-01 Glenn Morris <rgm@gnu.org>
7661
7662 * Makefile.in (SETTINGS_LIBS): Fix typo.
7663
4550efdf
KI
76642011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7665
7666 * coding.c (Fencode_coding_string): Record the last coding system
7667 used, as the function doc string says (bug#8738).
7668
0949d2b6
JD
76692011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7670
7671 * xsettings.c (store_monospaced_changed): Take new font as arg and
7672 check for change against current_mono_font.
7673 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7674 (emacs_settings_constructor, emacs_settings_get_property)
7675 (emacs_settings_set_property, emacs_settings_class_init)
7676 (emacs_settings_init, gsettings_obj): Remove.
7677 (something_changedCB): New function for HAVE_GSETTINGS.
7678 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7679 with value as argument.
7680 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7681 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7682 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7683 "changed".
7684
7685 * xgselect.c: Add defined (HAVE_GSETTINGS).
7686 (xgselect_initialize): Ditto.
7687
7688 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7689 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7690 xg_select.
7691
bbc6b304
PE
76922011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7693
7694 * eval.c (struct backtrace): Simplify and port the data structure.
7695 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7696 signed bit field, as this assumption is not portable and it makes
7697 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7698 "char debug_on_exit : 1" as this is not portable either; instead,
7699 use the portable "unsigned int debug_on_exit : 1". Remove unused
7700 member evalargs. Remove obsolete comments about cc bombing out.
7701
9851bfc5
JD
77022011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7703
51bb811f 7704 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7705 Let HAVE_GSETTINGS override HAVE_GCONF.
7706 (store_monospaced_changed): New function.
7707 (EMACS_SETTINGS): A new type derived from GObject to handle
7708 GSettings notifications.
7709 (emacs_settings_constructor, emacs_settings_get_property)
7710 (emacs_settings_set_property, emacs_settings_class_init):
7711 New functions.
7712 (gsettings_client, gsettings_obj): New variables.
7713 (GSETTINGS_SCHEMA): New define.
7714 (something_changedCB): Call store_monospaced_changed.
7715 (init_gsettings): New function.
7716 (xsettings_initialize): Call init_gsettings.
7717 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7718 to NULL.
7719
640c8776 7720 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7721 GCONF_CFLAGS/LIBS.
7722
5386012d
MR
77232011-06-29 Martin Rudalics <rudalics@gmx.at>
7724
7725 * window.c (resize_root_window, grow_mini_window)
7726 (shrink_mini_window): Rename Qresize_root_window to
7727 Qwindow_resize_root_window and Qresize_root_window_vertically to
7728 Qwindow_resize_root_window_vertically.
7729
f13e0b08
PE
77302011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7731
7732 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7733
94515237
JB
77342011-06-27 Juanma Barranquero <lekktu@gmail.com>
7735
7736 * makefile.w32-in: Redesign dependencies so they reflect more
7737 clearly which files are directly included by each source file,
7738 and not through other includes.
7739
e43b6e43
MR
77402011-06-27 Martin Rudalics <rudalics@gmx.at>
7741
7742 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7743 (sort_overlays, overlay_strings): When an overlay's clone number
7744 matches the window's clone number process the overlay even if
7745 the overlay's window property doesn't match the current window.
7746
d68443dc
MR
7747 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7748 (Fwindow_hchild): Rename to Fwindow_left_child.
7749 (Fwindow_next): Rename to Fwindow_next_sibling.
7750 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7751 (resize_window_check): Rename to window_resize_check.
7752 (resize_window_apply): Rename to window_resize_apply.
7753 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7754 (Fdelete_other_windows_internal, resize_frame_windows)
7755 (Fsplit_window_internal, Fdelete_window_internal)
7756 (grow_mini_window, shrink_mini_window)
7757 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7758
c7e73be5
JD
77592011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7760
7761 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7762 (emacs_fixed_set_min_size): Remove.
7763 (emacs_fixed_new): Take frame as argument.
7764
7765 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7766 (_EmacsFixedPrivate): Remove minwidth/height.
7767 Add struct frame *f.
7768 (emacs_fixed_init): Initialize priv->f.
7769 (get_parent_class, emacs_fixed_set_min_size): Remove.
7770 (emacs_fixed_new): Set priv->f to argument.
7771 (emacs_fixed_get_preferred_width)
7772 (emacs_fixed_get_preferred_height): Use min_width/height from
7773 frames size_hint to set minimum and natural (Bug#8919).
7774 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7775 and use min_width/height from frames size_hint to set
7776 min_width/height (Bug#8919).
7777
7778 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7779 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7780 Fix indentation.
c7e73be5 7781
cf99dcf8
EZ
77822011-06-26 Eli Zaretskii <eliz@gnu.org>
7783
7784 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7785 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7786 called at ZV.
7787
029529ac
CY
77882011-06-26 Chong Yidong <cyd@stupidchicken.com>
7789
7790 * process.c (wait_reading_process_output): Bypass select if
7791 waiting for a cell while ignoring keyboard input, and input is
7792 pending. Suggested by Jan Djärv (Bug#8869).
7793
7a7ef429
PE
77942011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7795
7796 Use gnulib's dup2 module instead of rolling our own.
7797 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7798
11fdef7d 77992011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7800
7801 * dispnew.c (scrolling_window): Before scrolling, turn off a
7802 mouse-highlight in the window being scrolled.
7803
cd3520a4
JB
78042011-06-24 Juanma Barranquero <lekktu@gmail.com>
7805
7806 Move DEFSYM to lisp.h and use everywhere.
7807
7808 * character.h (DEFSYM): Move declaration...
7809 * lisp.h (DEFSYM): ...here.
7810
7811 * gnutls.c:
7812 * minibuf.c:
7813 * w32menu.c:
7814 * w32proc.c:
7815 * w32select.c: Don't include character.h.
7816
7817 * alloc.c (syms_of_alloc):
7818 * buffer.c (syms_of_buffer):
7819 * bytecode.c (syms_of_bytecode):
7820 * callint.c (syms_of_callint):
7821 * casefiddle.c (syms_of_casefiddle):
7822 * casetab.c (init_casetab_once):
7823 * category.c (init_category_once, syms_of_category):
7824 * ccl.c (syms_of_ccl):
7825 * cmds.c (syms_of_cmds):
7826 * composite.c (syms_of_composite):
7827 * dbusbind.c (syms_of_dbusbind):
7828 * dired.c (syms_of_dired):
7829 * dispnew.c (syms_of_display):
7830 * doc.c (syms_of_doc):
7831 * editfns.c (syms_of_editfns):
7832 * emacs.c (syms_of_emacs):
7833 * eval.c (syms_of_eval):
7834 * fileio.c (syms_of_fileio):
7835 * fns.c (syms_of_fns):
7836 * frame.c (syms_of_frame):
7837 * fringe.c (syms_of_fringe):
7838 * insdel.c (syms_of_insdel):
7839 * keymap.c (syms_of_keymap):
7840 * lread.c (init_obarray, syms_of_lread):
7841 * macros.c (syms_of_macros):
7842 * msdos.c (syms_of_msdos):
7843 * print.c (syms_of_print):
7844 * process.c (syms_of_process):
7845 * search.c (syms_of_search):
7846 * sound.c (syms_of_sound):
7847 * syntax.c (init_syntax_once, syms_of_syntax):
7848 * terminal.c (syms_of_terminal):
7849 * textprop.c (syms_of_textprop):
7850 * undo.c (syms_of_undo):
7851 * w32.c (globals_of_w32):
7852 * window.c (syms_of_window):
7853 * xdisp.c (syms_of_xdisp):
7854 * xfaces.c (syms_of_xfaces):
7855 * xfns.c (syms_of_xfns):
7856 * xmenu.c (syms_of_xmenu):
7857 * xsettings.c (syms_of_xsettings):
7858 * xterm.c (syms_of_xterm): Use DEFSYM.
7859
4228cf16
TZ
78602011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7861
cd3520a4 7862 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7863
7fcccf1e
PE
78642011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7865
7efb4e0e
PE
7866 Integer and buffer overflow fixes (Bug#8873).
7867
ff5844ad
PE
7868 * print.c (printchar, strout): Check for string overflow.
7869 (PRINTPREPARE, printchar, strout):
7870 Don't set size unless allocation succeeds.
7871
90532f02
PE
7872 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7873 for sizes. Check for string overflow more accurately.
7874 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7875
6d84508d
PE
7876 * macros.c: Integer and buffer overflow fixes.
7877 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7878 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7879 Use ptrdiff_t, not int, for sizes.
7880 Don't increment bufsize until after realloc succeeds.
7881 Check for size-calculation overflow.
7882 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7883
437b2cb4
PE
7884 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7885
8b9ac8b4
PE
7886 * lread.c: Integer overflow fixes.
7887 (read_integer): Radix is now EMACS_INT, not int,
7888 to improve quality of diagnostics for out-of-range radices.
7889 Calculate buffer size correctly for out-of-range radices.
7890 (read1): Check for integer overflow in radices, and in
7891 read-circle numbers.
82cb60d3
PE
7892 (read_escape): Avoid int overflow.
7893 (Fload, openp, read_buffer_size, read1)
7894 (substitute_object_recurse, read_vector, read_list, map_obarray):
7895 Use ptrdiff_t, not int, for sizes.
7896 (read1): Use EMACS_INT, not int, for sizes.
20270765 7897 Check for size overflow.
8b9ac8b4 7898
7fcccf1e
PE
7899 * image.c (cache_image): Check for size arithmetic overflow.
7900
bfbbd7e7
PE
7901 * lread.c: Integer overflow issues.
7902 (saved_doc_string_size, saved_doc_string_length)
7903 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7904 Now ptrdiff_t, not int.
7905 (read1): Don't assume doc string length fits in int. Check for
7906 out-of-range doc string lengths.
7907 (read_list): Don't assume file position fits in int.
39019e54 7908 (read_escape): Check for hex character overflow.
bfbbd7e7 7909
4e323265
LL
79102011-06-22 Leo Liu <sdl.web@gmail.com>
7911
7912 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7913 Move to minibuffer.el.
7914
85fece3e
PE
79152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7916
20b84ce9 7917 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7918 The following patches are for when GLYPH_DEBUG && !XASSERT.
7919 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7920 * dispnew.c (flush_stdout):
7921 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7922 Mark as externally visible.
7923 * dispnew.c (check_window_matrix_pointers): Now static.
7924 * dispnew.c (window_to_frame_vpos):
7925 * xfns.c (unwind_create_frame):
7926 * xterm.c (x_check_font): Remove unused local.
7927 * scroll.c (CHECK_BOUNDS):
7928 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7929 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7930 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7931 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7932 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7933 Now static.
7934 (debug_method_add): Use va_list and vsprintf rather than relying
7935 on undefined behavior with wrong number of arguments.
7936 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7937 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7938 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7939 since we're not interested in debugging glyphs with old libraries.
7940 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7941 GCC 4.6.0's static checking.
7942
0766b489
PE
79432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7944
31fd4b32
PE
7945 Integer overflow and signedness fixes (Bug#8873).
7946 A few related buffer overrun fixes, too.
7947
b79e8648
PE
7948 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7949
0766b489
PE
7950 * dispextern.h (struct face.stipple):
7951 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7952 (x_bitmap_mask, x_allocate_bitmap_record)
7953 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7954 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7955 (x_create_bitmap_from_xpm_data):
7956 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7957 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7958 (.bitmaps_last):
7959 * xfaces.c (load_pixmap):
7960 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7961 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7962 (.bitmaps_last, struct x_output.icon_bitmap):
7963 Use ptrdiff_t, not int, for bitmap indexes.
7964 (x_allocate_bitmap_record): Check for size overflow.
7965 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7966
b081724f
PE
7967 Use ptrdiff_t, not int, for overlay counts.
7968 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7969 * editfns.c (overlays_around, get_pos_property):
7970 * textprop.c (get_char_property_and_overlay):
7971 * xdisp.c (next_overlay_change, note_mouse_highlight):
7972 * xfaces.c (face_at_buffer_position):
21514da7
PE
7973 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7974 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7975 (Fnext_overlay_change, Fprevious_overlay_change)
7976 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7977 Use ptrdiff_t, not int, for sizes.
21514da7 7978 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7979
3de73e5e
PE
7980 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7981
2606c57b
PE
7982 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7983 (x_session_initialize): Do not assume string length fits in int.
7984
aaafe47a
PE
7985 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7986 This is unlikely, but can occur if DPI is outlandish.
7987
2674ddc8 7988 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7989 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7990
28154962
PE
7991 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7992 * xrdb.c (magic_file_p, search_magic_path):
7993 Omit last arg SUFFIX; it was always 0. All callers changed.
7994 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7995
7de51af5
PE
7996 * xfont.c (xfont_match): Avoid need for strlen.
7997
25ed6cc3
PE
7998 * xfns.c: Don't assume strlen fits in int.
7999 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8000
4eab31dd
PE
8001 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8002 not unsigned long, as we prefer signed integers. All callers changed.
8003 Detect integer overflow in repeat count.
8004 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8005 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8006
171e2a58
PE
8007 * termcap.c: Don't assume sizes fit in int and never overflow.
8008 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8009 (gobble_line): Check for size-calculation overflow.
8010
ad39faca 8011 * minibuf.c (Fread_buffer):
6e5bb2dc 8012 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8013 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8014 Don't assume string length fits in int.
8015
52c61c22 8016 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8017 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8018
b5b8c9e5
PE
8019 * font.c: Don't assume string length fits in int.
8020 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8021 Use ptrdiff_t, not int.
ccd6111c
PE
8022 (font_intern_prop): Don't assume string length fits in int.
8023 Don't assume integer property fits in fixnum.
8024 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8025
882f0d81 8026 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8027 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8028 Reformulate so as not to need the command string.
8029 Invoke gzip -cd rather than gunzip, as it's more portable.
8030 (lock_info_type, lock_file_1, lock_file):
8031 Don't assume pid_t and time_t fit in unsigned long.
8032 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8033 (current_lock_owner): Prefer signed type for sizes.
8034 Use memcpy, not strncpy, where memcpy is what is really wanted.
8035 Don't assume (via atoi) that time_t and pid_t fit in int.
8036 Check for time_t and/or pid_t out of range, e.g., via a network share.
8037 Don't alloca where an auto var works fine.
8038
93f4cf88
PE
8039 * fileio.c: Fix some integer overflow issues.
8040 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8041 Don't assume string length fits in int.
8042 (directory_file_name): Don't assume string length fits in long.
8043 (make_temp_name): Don't assume pid fits in int, or that its print
8044 length is less than 20.
8045
f3e92b69
PE
8046 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8047
1bfdaf10
PE
8048 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8049
35016e9a
PE
8050 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8051
3d1e65a1
PE
8052 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8053 We prefer signed integers, even for size calculations.
8054
0b963a93
PE
8055 * emacs.c: Don't assume string length fits in 'int'.
8056 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8057 (main): Don't invoke strlen when not needed.
8058
573f4b54
PE
8059 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8060 (XD_DEBUG_MESSAGE): Don't waste a byte.
8061
989f33ba
PE
8062 * callproc.c (getenv_internal_1, getenv_internal)
8063 (Fgetenv_internal):
965d34eb
PE
8064 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8065
e4d29b33
PE
8066 * lread.c (invalid_syntax): Omit length argument.
8067 All uses changed. This doesn't fix a bug, but it simplifies the
8068 code away from its former Hollerith-constant appearance, and it's
8069 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8070 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8071
eb49b136
PE
8072 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8073 This didn't break anything, but it didn't help either.
8074 It's confusing to put a bogus integer in a place where the actual
8075 value does not matter.
9f62aeb1 8076 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8077 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8078
15375a22
PE
8079 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8080 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8081 implementation.
b61cc01c
PE
8082 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8083 We prefer signed types, and the value cannot exceed the EMACS_INT
8084 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8085 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8086 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8087 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8088
53b2623d
PE
8089 * indent.c (sane_tab_width): New function.
8090 (current_column, scan_for_column, Findent_to, position_indentation)
8091 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8092 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8093
51cab52b 8094 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8095
f2ed8a70
PE
8096 * lisp.h (lint_assume): New macro.
8097 * composite.c (composition_gstring_put_cache):
8098 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8099
abe80cc6
PE
8100 * editfns.c, insdel.c:
8101 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8102
b02c740e
PE
8103 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8104
ebc96716
PE
8105 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8106
b4e50fa0 8107 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8108 Use much-faster test for byte-length change.
311d5d7c 8109 Don't assume string byte-length fits in 'int'.
a4cf38e4 8110 Check that character arg fits in 'int'.
85461888 8111 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8112
c0c1ee9f
PE
8113 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8114
a498d7f4
PE
8115 * fns.c (concat): Catch string overflow earlier.
8116 Do not rely on integer wraparound.
8117
51cab52b
PE
8118 * dispextern.h (struct it.overlay_strings_charpos)
8119 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8120 * xdisp.c (forward_to_next_line_start)
8121 (back_to_previous_visible_line_start)
8122 (reseat_at_next_visible_line_start, next_element_from_buffer):
8123 Don't arbitrarily truncate the value of 'selective' to int.
8124
76031fad
PE
8125 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8126
5eb55db9
PE
8127 * composite.c: Don't truncate sizes to 'int'.
8128 (composition_gstring_p, composition_reseat_it)
8129 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8130 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8131 not EMACS_UINT, for indexes.
5eb55db9 8132
0703a717
PE
8133 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8134
d6202519
PE
8135 * buffer.c: Include <verify.h>.
8136 (struct sortvec.priority, struct sortstr.priority):
8961a454 8137 Now EMACS_INT, not int.
c20998a7 8138 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8139 (struct sortstr.size, record_overlay_string)
8140 (struct sortstrlist.size, struct sortlist.used):
8141 Don't truncate size to int.
8142 (record_overlay_string): Check for size-calculation overflow.
d6202519 8143 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8144
d5a19415
JM
81452011-06-22 Jim Meyering <meyering@redhat.com>
8146
029529ac 8147 Don't leak an XBM-image-sized buffer
d5a19415
JM
8148 * image.c (xbm_load): Free the image buffer after using it.
8149
a9041e6c
PE
81502011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8151
8152 Port to Sun C.
8153 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8154 that Sun C diagnosed.
8155 * fns.c (secure_hash): Fix pointer signedness issue.
8156 * intervals.c (static_offset_intervals): New function.
8157 (offset_intervals): Use it.
8158
7f3f739f
LL
81592011-06-21 Leo Liu <sdl.web@gmail.com>
8160
8161 * deps.mk (fns.o):
8162 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8163 sha512.h.
8164
8165 * fns.c (secure_hash): Rename from crypto_hash_function and change
8166 the first arg to accept symbols.
5b66d427 8167 (Fsecure_hash): New primitive.
7f3f739f
LL
8168 (syms_of_fns): New symbols.
8169
76147d94
DD
81702011-06-20 Deniz Dogan <deniz@dogan.se>
8171
8172 * process.c (Fset_process_buffer): Clarify return value in
8173 docstring.
8174
7d7d0045
CY
81752011-06-18 Chong Yidong <cyd@stupidchicken.com>
8176
8177 * dispnew.c (add_window_display_history): Use BVAR.
8178
8179 * xdisp.c (debug_method_add): Use BVAR.
8180 (check_window_end, dump_glyph_matrix, dump_glyph)
8181 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8182
8183 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8184 Likewise.
8185
8186 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8187 check till after the cache is created in init_frame_faces.
8188
ff2bc410
SM
81892011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8190
8191 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8192
28177add
PE
81932011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8194
dd3482fe
PE
8195 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8196 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8197 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8198
393d71f3 8199 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8200 * fileio.c (Finsert_file_contents):
8201 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8202 Remove the old (too-loose) buffer overflow checks.
8203 They weren't needed, since make_gap checks for buffer overflow.
8204 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8205 The old code merely checked for Emacs fixnum overflow, and relied
8206 on undefined (wraparound) behavior. The new code avoids undefined
8207 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8208
2e6813b0 8209 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8210 Tune. Don't use wider integers than needed. Don't use alloca.
8211 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8212
599a9e4f
PE
8213 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8214
99561444
PE
8215 * insdel.c, lisp.h (buffer_overflow): New function.
8216 (insert_from_buffer_1, replace_range, replace_range_2):
8217 * insdel.c (make_gap_larger):
8218 * editfns.c (Finsert_char):
8219 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8220
28177add
PE
8221 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8222
e69dafad
PE
82232011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8224
4baa020d 8225 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8226
b1c46f02
PE
8227 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8228 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8229
e69dafad
PE
8230 * fileio.c: Don't assume EMACS_INT fits in off_t.
8231 (emacs_lseek): New static function.
8232 (Finsert_file_contents, Fwrite_region): Use it.
8233 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8234
566684ea
PE
8235 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8236
e6966cd6
PE
8237 * fns.c: Don't overflow int when computing a list length.
8238 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8239 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8240 truncation on 64-bit hosts. Check for QUIT every
8241 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8242 faster and is responsive enough.
8243 (Flength): Report an error instead of overflowing an integer.
8244 (Fsafe_length): Return a float if the value is not representable
8245 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8246 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8247 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8248
dd0b0efb
PE
8249 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8250 (header_size, word_size): New constants.
8251 (allocate_vectorlike): Don't check size overflow here.
8252 (allocate_vector): Check it here instead, since this is the only
8253 caller of allocate_vectorlike that could cause overflow.
8254 Check that the new vector's length is representable as a fixnum.
8255
86fe5cfe
PE
8256 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8257 The previous code was bogus. For example, next_almost_prime (32)
8258 returned 39, which is undesirable as it is a multiple of 3; and
8259 next_almost_prime (24) returned 25, which is a multiple of 5 so
8260 why was the code bothering to check for multiples of 7?
8261
80e88859
PE
8262 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8263
4a2f0ad6
PE
8264 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8265
f66c7cf8
PE
8266 Variadic C functions now count arguments with ptrdiff_t.
8267 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8268 Back then I didn't know that the Emacs coding style prefers signed int.
8269 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8270 were being counted with int, which may truncate counts on 64-bit
8271 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8272 * lisp.h (struct Lisp_Subr.function.aMANY)
8273 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8274 Arg counts are now ptrdiff_t, not size_t.
8275 All variadic functions and their callers changed accordingly.
8276 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8277 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8278 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8279 * callint.c (Fcall_interactively): Check arg count for overflow,
8280 to avoid potential buffer overrun. Use signed char, not 'int',
8281 for 'varies' array, so that we needn't bother to check its size
8282 calculation for overflow.
8283 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8284 * eval.c (apply_lambda):
8285 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8286 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8287 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8288
a1759b76
PE
8289 * callint.c (Fcall_interactively): Don't use index var as event count.
8290
d96be9fc
PE
8291 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8292 * mem-limits.h (SIZE): Remove; no longer used.
8293
a690a978 8294 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8295
578c21e6
PE
8296 Remove unnecessary casts.
8297 * xterm.c (x_term_init):
8298 * xfns.c (x_set_border_pixel):
8299 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8300 These aren't needed now that we assume ANSI C.
8301
96f53c6c
PE
8302 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8303 It's more likely to cause problems (due to unsigned overflow)
8304 than to cure them.
8305
83c77d31
PE
8306 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8307
ee2079f1
PE
8308 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8309
6da65536
PE
8310 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8311
7147c4a4
PE
8312 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8313
193e32d9
PE
8314 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8315
e5533da6
PE
8316 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8317
9910e595
PE
8318 GLYPH_CODE_FACE returns EMACS_INT, not int.
8319 * dispextern.h (merge_faces):
8320 * xfaces.c (merge_faces):
01103c44
PE
8321 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8322 Don't assume EMACS_INT fits in int.
9910e595 8323
2638320e
PE
8324 * character.h (CHAR_VALID_P): Remove unused parameter.
8325 * fontset.c, lisp.h, xdisp.c: All uses changed.
8326
045eb8d9
PE
8327 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8328
c1f134b5
PE
8329 * fns.c (concat): Minor tuning based on overflow analysis.
8330 This doesn't fix any bugs. Use int to hold character, instead
8331 of constantly refetching from Emacs object. Use XFASTINT, not
8332 XINT, for value known to be a character. Don't bother comparing
8333 a single byte to 0400, as it's always less.
8334
395fcb93 8335 * floatfns.c (Fexpt):
327eeec8
PE
8336 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8337
abbd3d23
PE
8338 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8339 for characters.
8340
684a03ef
PE
8341 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8342
0fed43f3
PE
8343 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8344 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8345 incorrectly succeed when S was a string, because 4294967386 was
8346 truncated before it was used.
8347
8fd02eb7
PE
8348 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8349 Otherwise, an out-of-range integer could cause undefined behavior
8350 on a 64-bit host.
8351
f8c86b69
PE
8352 * composite.c: Use int, not EMACS_INT, for characters.
8353 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8354 EMACS_INT, for values that are known to be in character range.
8355 This doesn't fix any bugs but is the usual style inside Emacs and
8356 may generate better code on 32-bit machines.
8357
34206dd2
PE
8358 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8359 This is for reasons similar to the recent CHAR_STRING fix.
8360 * charset.c (Fencode_char): Check that character arg is actually
8361 a character. Pass an int to ENCODE_CHAR.
8362 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8363 wider than 'int', as a compile-time check to prevent future regressions
8364 in this area.
8365
c5958d4c 8366 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8367
8368 Make sure a 64-bit char is never passed to CHAR_STRING.
8369 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8370 by silently ignoring the top 32 bits, allowing some values
8371 that were far too large to be valid characters.
8372 * character.h: Include <verify.h>.
8373 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8374 arguments are no wider than unsigned, as a compile-time check
8375 to prevent future regressions in this area.
8376 * data.c (Faset):
01103c44 8377 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8378 (Fsubst_char_in_region):
8379 * fns.c (concat):
8380 * xdisp.c (decode_mode_spec_coding):
8381 Adjust to CHAR_STRING's new requirement.
8382 * editfns.c (Finsert_char, Fsubst_char_in_region):
8383 * fns.c (concat): Check that character args are actually
8384 characters. Without this test, these functions did the wrong
8385 thing with wildly out-of-range values on 64-bit hosts.
8386
d37ca623
PE
8387 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8388 These casts should not be needed on 32-bit hosts, either.
8389 * keyboard.c (read_char):
8390 * lread.c (Fload): Remove casts to unsigned.
8391
ea204efb
PE
8392 * lisp.h (UNSIGNED_CMP): New macro.
8393 This fixes comparison bugs on 64-bit hosts.
8394 (ASCII_CHAR_P): Use it.
8395 * casefiddle.c (casify_object):
01103c44 8396 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8397 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8398 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8399 * dispextern.h (FACE_FROM_ID):
8400 * keyboard.c (read_char): Use UNSIGNED_CMP.
8401
41cb286c
PE
8402 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8403 not to EMACS_INT, to avoid GCC warning.
8404
4a1b9832
PE
8405 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8406
55daad71
PE
8407 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8408 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8409 isn't needed on 32-bit machines.
8f95c75c 8410
01103c44
PE
8411 * buffer.c (Fgenerate_new_buffer_name):
8412 Use EMACS_INT for count, not int.
0ceccced 8413 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8414
8415 * data.c (Qcompiled_function): Now static.
8416
c6f072e7
PE
8417 * window.c (window_body_lines): Now static.
8418
20ce5912
PE
8419 * image.c (gif_load): Rename local to avoid shadowing.
8420
9c4c5f81
PE
8421 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8422 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8423 * alloc.c (make_save_value): Integer argument is now of type
8424 ptrdiff_t, not int.
8425 (mark_object): Use ptrdiff_t, not int.
8426 * lisp.h (pD): New macro.
8427 * print.c (print_object): Use it.
8428
c0c5c8ae
PE
8429 * alloc.c: Use EMACS_INT, not int, to count objects.
8430 (total_conses, total_markers, total_symbols, total_vector_size)
8431 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8432 (total_free_floats, total_floats, total_free_intervals)
8433 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8434 Now EMACS_INT, not int. All uses changed.
8435 (Fgarbage_collect): Compute overall total using a double, so that
8436 integer overflow is less likely to be a problem. Check for overflow
8437 when converting back to an integer.
5a25e253
PE
8438 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8439 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8440 These were 'int' variables that could overflow on 64-bit hosts;
8441 they were never used, so remove them instead of repairing them.
211a0b2a 8442 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8443 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8444 Previously, this ceilinged at INT_MAX, but that doesn't work on
8445 64-bit machines.
e46bb31a 8446 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8447
c78baabf 8448 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8449 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8450 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8451 when a (possibly-narrower) signed value would do just as well.
8452 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8453
c9d624c6
PE
8454 * alloc.c: Catch some string size overflows that we were missing.
8455 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8456 for convenience in STRING_BYTES_MAX.
8457 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8458 The definition here is exact; the one in lisp.h was approximate.
8459 (allocate_string_data): Check for string overflow. This catches
8460 some instances we weren't catching before. Also, it catches
8461 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8462 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8463 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8464
c9d624c6
PE
8465 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8466 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8467 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8468
353032ce
PE
8469 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8470
2bccce07
PE
8471 * alloc.c (Fmake_string): Check for out-of-range init.
8472
0ac30604
SM
84732011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8474
8475 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8476
c195f2de
JD
84772011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8478
8479 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8480 xg_get_default_scrollbar_width.
8481
8482 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8483 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8484 (style_changed_cb): Call update_theme_scrollbar_width and call
8485 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8486 all frames (Bug#8505).
8487 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8488 Call gtk_window_set_resizable if HAVE_GTK3.
8489 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8490 and height if HAVE_GTK3 (Bug#8505).
8491 (scroll_bar_width_for_theme): New variable.
8492 (update_theme_scrollbar_width): New function.
8493 (xg_get_default_scrollbar_width): Move code to
8494 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8495 (xg_initialize): Call update_theme_scrollbar_width.
8496
8497 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8498
8499 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8500
e10ac9f1
MR
85012011-06-12 Martin Rudalics <rudalics@gmx.at>
8502
8503 * frame.c (make_frame): Call other_buffer_safely instead of
8504 other_buffer.
8505
8506 * window.c (temp_output_buffer_show): Call display_buffer with
8507 second argument Vtemp_buffer_show_specifiers and reset latter
8508 immediately after the call.
8509 (Vtemp_buffer_show_specifiers): New variable.
8510 (auto_window_vscroll_p, next_screen_context_lines)
8511 (Vscroll_preserve_screen_position): Remove leading asterisks from
8512 doc-strings.
8513
2d3c217e 85142011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8515
7b7f97e8 8516 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8517 * buffer.c (Qclone_number): Remove for now, as it's unused.
8518 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8519 (record_buffer): Remove unused local.
8520 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8521 (set_frame_buffer_list): Remove; unused.
8522 * frame.h (other_visible_frames): Remove decl.
8523 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8524 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8525 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8526 if HAVE_GPM.
8527 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8528 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8529 Define only if HAVE_GPM.
8530 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8531 (update_hints_inhibit): Remove; never set. All uses removed.
8532 * widgetprv.h (emacsFrameClassRec): Remove decl.
8533 * window.c (delete_deletable_window): Now returns void, since it
8534 wasn't returning anything.
8535 (compare_window_configurations): Remove unused locals.
8536 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8537 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8538 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8539 the same widths as pointers. This follows up on the 2011-05-06 patch.
8540 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8541 * xterm.h: Likewise.
8542 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8543
1384b89e
JB
85442011-06-12 Juanma Barranquero <lekktu@gmail.com>
8545
8546 * makefile.w32-in: Update dependencies.
8547 (LISP_H): Add lib/intprops.h.
8548
1100a63c
CY
85492011-06-11 Chong Yidong <cyd@stupidchicken.com>
8550
8551 * image.c (gif_load): Add animation frame delay to the metadata.
8552 (syms_of_image): Use DEFSYM. New symbol `delay'.
8553
6198ccd0
MR
85542011-06-11 Martin Rudalics <rudalics@gmx.at>
8555
8556 * window.c (delete_deletable_window): Re-add.
8557 (Fset_window_configuration): Rewrite to handle dead buffers and
8558 consequently deletable windows.
8559 (window_tree, Fwindow_tree): Remove. Supply functionality in
8560 window.el.
8561 (compare_window_configurations): Simplify code.
8562
b6e3633c
AS
85632011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8564
1ab0dee5
AS
8565 * image.c (imagemagick_load_image): Fix type mismatch.
8566 (Fimagemagick_types): Likewise.
8567
b6e3633c
AS
8568 * window.h (replace_buffer_in_windows): Declare.
8569
9397e56f
MR
85702011-06-11 Martin Rudalics <rudalics@gmx.at>
8571
8572 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8573 Qclone_number. Remove external declaration of Qdelete_window.
8574 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8575 code.
640c8776
SM
8576 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8577 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8578 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8579 buffer list implementation.
8580 (other_buffer_safely): New function.
8581 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8582 calls to replace_buffer_in_windows and
8583 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8584 if allowed.
8585 (record_buffer): Inhibit quitting and rewrite using quittable
8586 functions. Run Qbuffer_list_update_hook if allowed.
8587 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8588 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8589 Move switch-to-buffer to window.el.
9397e56f
MR
8590 (bury-buffer): Move to window.el.
8591 (Vbuffer_list_update_hook): New variable.
8592
8593 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8594 section.
8595
8596 * window.h (resize_frame_windows): Move up in code.
8597 (Fwindow_frame): Remove EXFUN.
8598 (replace_buffer_in_all_windows): Remove prototype.
8599 (replace_buffer_in_windows_safely): Add prototype.
8600
8601 * window.c: Declare Qdelete_window static again. Move down
8602 declaration of select_count.
8603 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8604 (Fother_window): Move to window.el.
8605 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8606 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8607 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8608 window.el.
8609 (replace_buffer_in_windows): Implement by calling
8610 Qreplace_buffer_in_windows.
8611 (replace_buffer_in_all_windows): Remove with some functionality
8612 moved into replace_buffer_in_windows_safely.
8613 (replace_buffer_in_windows_safely): New function.
8614 (select_window_norecord, select_frame_norecord): Move in front
8615 of run_window_configuration_change_hook. Remove now obsolete
8616 declarations.
640c8776
SM
8617 (Fset_window_buffer): Rewrite doc-string.
8618 Call Qrecord_window_buffer.
9397e56f
MR
8619 (keys_of_window): Move binding for other-window to window.el.
8620
b50691aa
CY
86212011-06-11 Chong Yidong <cyd@stupidchicken.com>
8622
8623 * dispextern.h (struct image): Replace data member, whose int_val
8624 and ptr_val fields were not used by anything, with a single
8625 lisp_val object.
8626
8627 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8628 (gif_clear_image, gif_load, imagemagick_load_image)
8629 (gs_clear_image, gs_load): Callers changed.
8630
3f754b86
PE
86312011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8632
cca69397
PE
8633 * buffer.h: Include <time.h>, for time_t.
8634 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8635
109e28d0
PE
8636 Fix minor problems found by static checking.
8637
60737f02
PE
8638 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8639
4b66faf3
PE
8640 Make identifiers static if they are not used in other modules.
8641 * data.c (Qcompiled_function, Qframe, Qvector):
8642 * image.c (QimageMagick, Qsvg):
8643 * minibuf.c (Qmetadata):
8644 * window.c (resize_window_check, resize_root_window): Now static.
8645 * window.h (resize_window_check, resize_root_window): Remove decls.
8646
109e28d0
PE
8647 * window.c (window_deletion_count, delete_deletable_window):
8648 Remove; unused.
46a4ce9e
PE
8649 (window_body_lines): Now static.
8650 (Fdelete_other_windows_internal): Mark vars as initialized.
8651 Make sure 'resize_failed' is initialized.
8652 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8653 (resize_window_apply): Remove unused local.
8654 * window.h (delete_deletable_window): Remove decl.
8655
109e28d0 8656 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8657 (imagemagick_load_image): Fix pointer signedness problem by changing
8658 last arg from unsigned char * to char *. All uses changed.
8659 Also, fix a local for similar reasons.
8660 Remove unused locals. Remove locals to avoid shadowing.
8661 (fn_rsvg_handle_free): Remove; unused.
8662 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8663 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8664
3f754b86
PE
8665 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8666
2547adb1
CY
86672011-06-10 Chong Yidong <cyd@stupidchicken.com>
8668
8669 * image.c (gif_load): Fix omitted cast error introduced by
8670 2011-06-06 change.
8671
2c8e37d4
MR
86722011-06-10 Martin Rudalics <rudalics@gmx.at>
8673
8674 * window.h (resize_proportionally, orig_total_lines)
8675 (orig_top_line): Remove from window structure.
8676 (set_window_height, set_window_width, change_window_heights)
8677 (Fdelete_window): Remove prototypes.
8678 (resize_frame_windows): Remove duplicate declaration.
8679
440a42e3
EZ
86802011-06-10 Eli Zaretskii <eliz@gnu.org>
8681
8682 * window.h (resize_frame_windows, resize_window_check)
8683 (delete_deletable_window, resize_root_window)
8684 (resize_frame_windows): Declare prototypes.
8685
8686 * window.c (resize_window_apply): Make definition be "static" to
8687 match the prototype.
8688
562dd5e9
MR
86892011-06-10 Martin Rudalics <rudalics@gmx.at>
8690
8691 * window.c: Remove declarations of Qwindow_size_fixed,
8692 window_min_size_1, window_min_size_2, window_min_size,
8693 size_window, window_fixed_size_p, enlarge_window, delete_window.
8694 Remove static from declaration of Qdelete_window, it's
8695 temporarily needed by Fbury_buffer.
8696 (replace_window): Don't assign orig_top_line and
8697 orig_total_lines.
8698 (Fdelete_window, delete_window): Remove. Window deletion is
8699 handled by window.el.
640c8776
SM
8700 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8701 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8702 (Fdelete_other_windows): Remove. Deleting other windows is
8703 handled by window.el.
8704 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8705 handled in window.el.
8706 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8707 Window minimum sizes are handled in window.el.
8708 (shrink_windows, size_window, set_window_height)
8709 (set_window_width, change_window_heights, window_height)
8710 (window_width, CURBEG, CURSIZE, enlarge_window)
8711 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8712 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8713 handled in window.el.
8714 (make_dummy_parent): Rename to make_parent_window and give it a
8715 second argument horflag.
8716 (make_window): Don't set resize_proportionally any more.
8717 (Fsplit_window): Remove. Windows are split in window.el.
8718 (save_restore_action, save_restore_orig_size)
8719 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8720 Resize mini windows in window.el.
8721 (grow_mini_window, shrink_mini_window): Implement by calling
8722 Qresize_root_window_vertically, resize_window_check and
8723 resize_window_apply.
640c8776
SM
8724 (saved_window, Fset_window_configuration, save_window_save):
8725 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8726 resize_proportionally.
8727 (window_min_height, window_min_width): Move to window.el.
8728 (keys_of_window): Move bindings for delete-other-windows,
8729 split-window, delete-window and enlarge-window to window.el.
8730
8731 * buffer.c: Temporarily extern Qdelete_window.
8732 (Fbury_buffer): Temporarily call Qdelete_window instead of
8733 Fdelete_window (Fbury_buffer will move to window.el soon).
8734
8735 * frame.c (set_menu_bar_lines_1): Remove code handling
8736 orig_top_line and orig_total_lines.
8737
8738 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8739 set_window_height but set heights directly.
8740 (change_frame_size_1): Use resize_frame_windows.
8741
8742 * xdisp.c (init_xdisp): Don't use set_window_height but set
8743 heights directly.
8744
640c8776
SM
8745 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8746 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8747 run_window_configuration_change_hook.
8748
8749 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8750 instead of change_window_heights and run
8751 run_window_configuration_change_hook.
8752
1a13852e
MR
87532011-06-09 Martin Rudalics <rudalics@gmx.at>
8754
8755 * window.c (replace_window): Rename second argument REPLACEMENT to
8756 NEW. New third argument SETFLAG. Rewrite.
8757 (delete_window, make_dummy_parent): Call replace_window with
8758 third argument 1.
8759 (window_list_1): Move down in code.
8760 (run_window_configuration_change_hook): Move set_buffer part
8761 before select_frame_norecord part in order to unwind correctly.
8762 Rename count1 to count.
8763 (recombine_windows, delete_deletable_window, resize_root_window)
8764 (Fdelete_other_windows_internal)
8765 (Frun_window_configuration_change_hook, make_parent_window)
8766 (resize_window_check, resize_window_apply, Fresize_window_apply)
8767 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8768 (Fdelete_window_internal, Fresize_mini_window_internal):
8769 New functions.
1a13852e
MR
8770 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8771
f3d1777e
MR
87722011-06-08 Martin Rudalics <rudalics@gmx.at>
8773
496e208e
MR
8774 * window.h (window): Add some new members to window structure -
8775 normal_lines, normal_cols, new_total, new_normal, clone_number,
8776 splits, nest, prev_buffers, next_buffers.
8777 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8778 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8779
f3d1777e
MR
8780 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8781 Remove.
496e208e
MR
8782 (make_dummy_parent): Set new members of windows structure.
8783 (make_window): Move down in code. Handle new members of window
8784 structure.
8785 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8786 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8787 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8788 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8789 (Fset_window_next_buffers, Fset_window_clone_number):
8790 New functions.
496e208e
MR
8791 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8792 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8793 Doc-string fixes.
8794 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8795 Argument WINDOW can be now internal window too.
8796 (Fwindow_use_time): Move up in code.
8797 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8798 Rewrite doc-string.
8799 (Fset_window_configuration, saved_window)
8800 (Fcurrent_window_configuration, save_window_save): Handle new
8801 members of window structure.
b9e809c2
MR
8802 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8803 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8804 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8805 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8806 Qget_mru_window, Qresize_root_window,
8807 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8808 Qauto_buffer_name; staticpro them.
f3d1777e 8809
abde8f8c
MR
88102011-06-07 Martin Rudalics <rudalics@gmx.at>
8811
8812 * window.c (Fwindow_total_size, Fwindow_left_column)
8813 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8814 (Fwindow_list_1): New functions.
8815 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8816 (Fwindow_width, Fscroll_left, Fscroll_right):
8817 Use window_body_cols instead of window_box_text_cols.
8818 (delete_window, Fset_window_configuration):
8819 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8820 (delete_all_subwindows): Take a window as argument and not a
8821 structure. Rewrite.
190b47e6
MR
8822 (window_loop): Remove handling of GET_LRU_WINDOW and
8823 GET_LARGEST_WINDOW.
8824 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8825
8826 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8827 window_box_text_cols. delete_all_subwindows now takes a
8828 Lisp_Object as argument.
abde8f8c 8829
640c8776
SM
8830 * indent.c (compute_motion, Fcompute_motion):
8831 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8832
fa8a67e6
MR
8833 * frame.c (delete_frame): Call delete_all_subwindows with root
8834 window as argument.
8835
a54e3482
DC
88362011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8837
8838 * fns.c (Fputhash): Document return value.
8839
60002bf5
CY
88402011-06-06 Chong Yidong <cyd@stupidchicken.com>
8841
8842 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8843
0c671da6 88442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8845
b862a52a 8846 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8847
be44ca6c
PE
8848 Check for overflow when converting integer to cons and back.
8849 * charset.c (Fdefine_charset_internal, Fdecode_char):
8850 Use cons_to_unsigned to catch overflow.
8851 (Fencode_char): Use INTEGER_TO_CONS.
8852 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8853 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8854 * data.c (long_to_cons, cons_to_long): Remove.
8855 (cons_to_unsigned, cons_to_signed): New functions.
8856 These signal an error for invalid or out-of-range values.
8857 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8858 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8859 * font.c (Ffont_variation_glyphs):
8860 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8861 * lisp.h: Include <intprops.h>.
8862 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8863 (cons_to_signed, cons_to_unsigned): New decls.
8864 (long_to_cons, cons_to_long): Remove decls.
8865 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8866 (Fprimitive_undo): Use CONS_TO_INTEGER.
8867 * xfns.c (Fx_window_property): Likewise.
8868 * xselect.c: Include <limits.h>.
8869 (x_own_selection, selection_data_to_lisp_data):
8870 Use INTEGER_TO_CONS.
8871 (x_handle_selection_request, x_handle_selection_clear)
8872 (x_get_foreign_selection, Fx_disown_selection_internal)
8873 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8874 (lisp_data_to_selection_data): Use cons_to_unsigned.
8875 (x_fill_property_data): Use cons_to_signed.
8876 Report values out of range.
8877
d1f3d2af
PE
8878 Check for buffer and string overflow more precisely.
8879 * buffer.h (BUF_BYTES_MAX): New macro.
8880 * lisp.h (STRING_BYTES_MAX): New macro.
8881 * alloc.c (Fmake_string):
8882 * character.c (string_escape_byte8):
8883 * coding.c (coding_alloc_by_realloc):
8884 * doprnt.c (doprnt):
8885 * editfns.c (Fformat):
8886 * eval.c (verror):
8887 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8888 since they may not be the same number.
8889 * editfns.c (Finsert_char):
8890 * fileio.c (Finsert_file_contents):
8891 Likewise for BUF_BYTES_MAX.
8892
dd52fcea
PE
8893 * image.c: Use ptrdiff_t, not int, for sizes.
8894 (slurp_file): Switch from int to ptrdiff_t.
8895 All uses changed.
8896 (slurp_file): Check that file size fits in both size_t (for
8897 malloc) and ptrdiff_t (for sanity and safety).
8898
7f9bbdbb
PE
8899 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8900 if b->modtime has its maximal value.
8901
dfe18f82
PE
8902 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8903
84acfcf0
PE
8904 Don't assume time_t can fit into int.
8905 * buffer.h (struct buffer.modtime): Now time_t, not int.
8906 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8907 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8908
ccd9a01a
PE
8909 Minor fixes for signed vs unsigned integers.
8910 * character.h (MAYBE_UNIFY_CHAR):
8911 * charset.c (maybe_unify_char):
8912 * keyboard.c (read_char, reorder_modifiers):
8913 XINT -> XFASTINT, since the integer must be nonnegative.
8914 * ftfont.c (ftfont_spec_pattern):
8915 * keymap.c (access_keymap, silly_event_symbol_error):
8916 XUINT -> XFASTINT, since the integer must be nonnegative.
8917 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8918 since it makes no difference and we prefer signed.
8919 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8920 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8921 nonnegative.
8922
d6d100dd
SM
89232011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8924
8925 * window.h (Fwindow_frame): Declare.
8926
2b6148e4
PE
89272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8928
8929 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8930 (SPARE_MEMORY): Always define.
8931 (LARGE_REQUEST): Remove.
8932 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8933
f230ecc9
MR
89342011-06-06 Martin Rudalics <rudalics@gmx.at>
8935
727e958e
MR
8936 * lisp.h: Move EXFUNS for Fframe_root_window,
8937 Fframe_first_window and Fset_frame_selected_window to window.h.
8938
8939 * window.h: Move EXFUNS for Fframe_root_window,
8940 Fframe_first_window and Fset_frame_selected_window here from
8941 lisp.h.
8942
8943 * frame.c (Fwindow_frame, Fframe_first_window)
8944 (Fframe_root_window, Fframe_selected_window)
8945 (Fset_frame_selected_window): Move to window.c.
8946 (Factive_minibuffer_window): Move to minibuf.c.
8947 (Fother_visible_frames_p): New function.
8948
8949 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8950
f230ecc9
MR
8951 * window.c (decode_window, decode_any_window): Move up in code.
8952 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8953 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8954 (Fwindow_buffer): Move up and rewrite doc-string.
8955 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8956 (Fwindow_prev): New functions.
727e958e
MR
8957 (Fwindow_frame): Move here from frame.c. Accept any window as
8958 argument.
8959 (Fframe_root_window, Fframe_first_window)
8960 (Fframe_selected_window): Move here from frame.c. Accept frame
8961 or arbitrary window as argument. Update doc-strings.
8962 (Fminibuffer_window): Move up in code.
8963 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8964 (Fset_frame_selected_window): Move here from frame.c.
8965 Marginal rewrite.
727e958e
MR
8966 (Fselected_window, select_window, Fselect_window): Move up in
8967 code. Minor doc-string fixes.
f230ecc9 8968
4d09bcf6
PE
89692011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8970
8971 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8972 Do not assume that spare memory exists; that assumption is valid
8973 only if SYSTEM_MALLOC.
8974 (LARGE_REQUEST): New macro, so that the issue of large requests
8975 is separated from the issue of spare memory.
8976
810928a2
AS
89772011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8978
172418ad
AS
8979 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8980 format. (Bug#8806)
8981
43f862f7
AS
8982 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8983
810928a2
AS
8984 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8985 before statements.
8986
a059fe24
JD
89872011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8988
8989 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8990
8991 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8992
8993 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8994 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8995
989bf368
JB
89962011-06-05 Juanma Barranquero <lekktu@gmail.com>
8997
8998 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8999
4b80f674
CY
90002011-06-04 Chong Yidong <cyd@stupidchicken.com>
9001
9002 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9003 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9004 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9005 New error handlers.
4b80f674
CY
9006 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9007 Obey Vx_select_enable_clipboard_manager. Catch errors in
9008 x_clipboard_manager_save (Bug#8779).
9009 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9010 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9011
99a33b77 90122011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9013
9014 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9015
99a33b77 90162011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9017
9018 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9019 in the current matrix if keep_current_p is non-zero.
9020
8264569d
EZ
90212011-06-04 Eli Zaretskii <eliz@gnu.org>
9022
9023 * bidi.c (bidi_level_of_next_char): Fix last change.
9024
57f97249
EZ
90252011-06-03 Eli Zaretskii <eliz@gnu.org>
9026
fec2107c 9027 Support bidi reordering of text covered by display properties.
57f97249 9028
fec2107c
EZ
9029 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9030 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9031 (bidi_cache_search, bidi_cache_iterator_state)
9032 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9033 (bidi_level_of_next_char, bidi_move_to_visually_next):
9034 Support character positions inside a run of characters covered by a
fec2107c
EZ
9035 display string.
9036 (bidi_paragraph_init, bidi_resolve_explicit_1)
9037 (bidi_level_of_next_char): Call bidi_fetch_char and
9038 bidi_fetch_char_advance instead of FETCH_CHAR and
9039 FETCH_CHAR_ADVANCE.
9040 (bidi_init_it): Initialize new members.
9041 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9042 definitions.
9043 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9044 instead of using explicit *_CHAR codes.
d6d100dd
SM
9045 (bidi_resolve_explicit, bidi_resolve_weak):
9046 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9047 bidirectional text is supported only in multibyte buffers.
9048 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9049 it to initialize the frame_window_p member of struct bidi_it.
9050 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9051 (bidi_resolve_explicit, bidi_resolve_weak)
9052 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9053 bidi_it->nchars is non-positive.
9054 (bidi_level_of_next_char): Don't try to lookup the cache for the
9055 next/previous character if nothing is cached there yet, or if we
9056 were just reseat()'ed to a new position.
c40e2fb2 9057
0e14fe90
EZ
9058 * xdisp.c (set_cursor_from_row): Set start and stop points
9059 according to the row's direction when priming the loop that looks
9060 for the glyph on which to display cursor.
9061 (single_display_spec_intangible_p): Function deleted.
9062 (display_prop_intangible_p): Reimplement to call
9063 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9064 Accept 3 additional arguments needed by handle_display_spec.
9065 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9066 values: lists, `(when COND...)' forms, etc.
9067 (single_display_spec_string_p): Support property values that are
9068 lists with the argument STRING its top-level element.
9069 (display_prop_string_p): Fix the condition for processing a
9070 property that is a list to be consistent with handle_display_spec.
fec2107c 9071 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9072 last portion of handle_display_prop.
9073 (compute_display_string_pos): Accept additional argument
9074 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9075 value of a `display' property is a "replacing spec".
9076 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9077 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9078 the display property, but just return a value indicating whether
9079 the display property will replace the characters it covers.
9080 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9081 frame_window_p members of struct bidi_it.
d6d100dd
SM
9082 (compute_display_string_pos, compute_display_string_end):
9083 New functions.
fec2107c
EZ
9084 (push_it): Accept second argument POSITION, where pop_it should
9085 jump to continue iteration.
9086 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9087
fec2107c
EZ
9088 * keyboard.c (adjust_point_for_property): Adjust the call to
9089 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9090
9091 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9092 (bidi_init_it): Update prototypes.
9093 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9094 (compute_display_string_pos, compute_display_string_end):
9095 Declare prototypes.
fec2107c
EZ
9096 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9097 EMACS_INT.
fc6f18ce 9098
40087514 90992011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9100
57f53182
PE
9101 Malloc failure behavior now depends on size of allocation.
9102 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9103 * lisp.h: Change signatures accordingly.
9104 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9105 All callers changed. (Bug#8762)
9106
9107 * gnutls.c: Use Emacs's memory allocators.
9108 Without this change, the gnutls library would invoke malloc etc.
9109 directly, which causes problems on non-SYNC_INPUT hosts, and which
9110 runs afoul of improving memory_full behavior. (Bug#8761)
9111 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9112 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9113 xfree instead of the default malloc, realloc, free.
9114 (Fgnutls_boot): No need to check for memory allocation failure,
9115 since xmalloc does that for us.
9116
ac32cd99 9117 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9118 * category.c (hash_get_category_set):
9119 * ccl.c (ccl_driver):
9120 * charset.c (Fdefine_charset_internal):
9121 * charset.h (struct charset.hash_index):
9122 * composite.c (get_composition_id, gstring_lookup_cache)
9123 (composition_gstring_put_cache):
9124 * composite.h (struct composition.hash_index):
9125 * dispextern.h (struct image.hash):
9126 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9127 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9128 (hashfn_equal, hashfn_user_defined, make_hash_table)
9129 (maybe_resize_hash_table, hash_lookup, hash_put)
9130 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9131 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9132 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9133 * image.c (make_image, search_image_cache, lookup_image)
9134 (xpm_put_color_table_h):
9135 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9136 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9137 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9138 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9139 * alloc.c (allocate_vectorlike):
9140 Check for overflow in vector size calculations.
9141 * ccl.c (ccl_driver):
9142 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9143 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9144 need to be updated by these changes.
40087514
PE
9145 * fns.c (make_hash_table, maybe_resize_hash_table):
9146 Check for integer overflow with large hash tables.
0de4bb68
PE
9147 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9148 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9149 (SXHASH_REDUCE): New macro.
9150 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9151 Use it instead of discarding useful hash info with large hash values.
9152 (sxhash_float): New function.
9153 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9154 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9155 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9156 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9157 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9158 Adjust signatures to match updated version of code.
9159 (consing_since_gc): Now EMACS_INT, since a single hash table can
9160 use more than INT_MAX bytes.
9161
698d32e2
DN
91622011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9163
9164 Make it possible to build with GCC-4.6+ -O2 -flto.
9165
9166 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9167
fd6fa53f
SM
91682011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9169
9170 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9171 Call minibuffer-inactive-mode.
9172
864db017
JB
91732011-05-31 Juanma Barranquero <lekktu@gmail.com>
9174
9175 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9176 Update dependencies.
9177
2ad0baf4
DN
91782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9179
9180 * data.c (init_data): Remove code for UTS, this system is not
9181 supported anymore.
9182
4fcc2638
DN
91832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9184
9185 Don't force ./temacs to start in terminal mode.
9186
9187 * frame.c (make_initial_frame): Initialize faces in all cases, not
9188 only when CANNOT_DUMP is defined.
9189 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9190
c56e0fd5
DN
91912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9192
9193 * dispnew.c (add_window_display_history): Use const for the string
9194 pointer. Remove declaration, not needed.
9195
333d54da 91962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9197
55d4c1b2 9198 Use 'inline', not 'INLINE'.
333d54da 9199 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9200 * alloc.c, fontset.c (INLINE): Remove.
9201 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9202 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9203 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9204 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9205 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9206
738db178
DN
92072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9208
9209 Make it possible to run ./temacs.
9210
9211 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9212 syms_of_callproc does the same thing. Remove test for
9213 "initialized", do it in the caller.
9214 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9215
620c53a6
SM
92162011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9217
9218 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9219 (read_minibuf): Use get_minibuffer.
9220 (syms_of_minibuf): Use DEFSYM.
9221 (Qmetadata): New var.
9222 * data.c (Qbuffer): Don't make it static.
9223 (syms_of_data): Use DEFSYM.
9224
e003a292
PE
92252011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9226
9227 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9228 (CCL_CODE_MIN): New macro.
9229
ed008a6d
PE
92302011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9231
3687c2ef
PE
9232 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9233
ed008a6d
PE
9234 * eval.c (Qdebug): Now static.
9235 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9236 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9237 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9238
d66c4c7c
CY
92392011-05-29 Chong Yidong <cyd@stupidchicken.com>
9240
9241 * image.c: Various fixes to ImageMagick code comments.
9242 (Fimagemagick_types): Doc fix.
9243
5fbc2025
PE
92442011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9245
0196f88a
PE
9246 Minor fixes prompted by GCC 4.6.0 warnings.
9247
9248 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9249
5fbc2025
PE
9250 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9251 (x_clipboard_manager_save_all): Move extern decl to ...
9252 * xterm.h: ... here, so that it can be checked for consistency.
9253
1dd3c2d9
CY
92542011-05-29 Chong Yidong <cyd@stupidchicken.com>
9255
9256 * xselect.c (x_clipboard_manager_save_frame)
9257 (x_clipboard_manager_save_all): New functions.
9258 (Fx_clipboard_manager_save): Lisp function deleted.
9259
9260 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9261 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9262
9263 * xterm.h: Update prototype.
9264
5ba6571d
WX
92652011-05-28 William Xu <william.xwl@gmail.com>
9266
9267 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9268 exiting (Bug#8239).
9269
3eaff834
JM
92702011-05-28 Jim Meyering <meyering@redhat.com>
9271
e1900994 9272 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9273 * fns.c (to_uchar): Define.
9274 (crypto_hash_function): Use it to convert some newly-signed
9275 variables to unsigned, to avoid sign-extension bugs. For example,
9276 without this change, (md5 "truc") would evaluate to
9277 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9278 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9279 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9280
0f6990a7
PE
92812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9282
9283 Integer overflow fixes.
c8a9ca5a 9284
08686060
PE
9285 * dbusbind.c: Serial number integer overflow fixes.
9286 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9287 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9288 to hold a serial number that is too large for a fixnum.
9289 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9290 Check for serial numbers out of range. Decode any serial number
59568bf0 9291 that was so large that it became a float. (Bug#8722)
08686060 9292
2d1fc3c7
PE
9293 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9294 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9295 Use XFASTINT rather than XUINT when numbers are nonnegative.
9296 (xd_append_arg, Fdbus_method_return_internal):
9297 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9298 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9299 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9300 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9301 (Bug#8722)
2d1fc3c7 9302
c8a9ca5a
PE
9303 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9304
519e1d69
PE
9305 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9306
6df6ae42 9307 ccl: Add integer overflow checks.
30569699
PE
9308 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9309 (IN_INT_RANGE): New macros.
9310 (ccl_driver): Use them to check for integer overflow when
9311 decoding a CCL program. Many of the new checks are whether XINT (x)
9312 fits in int; it doesn't always, on 64-bit hosts. The new version
9313 doesn't catch all possible integer overflows, but it's an
847044ea 9314 improvement. (Bug#8719)
30569699 9315
c11285dc
PE
9316 * alloc.c (make_event_array): Use XINT, not XUINT.
9317 There's no need for unsigned here.
9318
fdccd48e
PE
9319 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9320 This follows up to the 2011-05-06 change that substituted uintptr_t
9321 for EMACS_INT. This case wasn't caught back then.
9322
37910ab2
PE
9323 Rework Fformat to avoid integer overflow issues.
9324 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9325 now (part of C89). Include <verify.h>.
9326 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9327 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9328 (Fformat): Avoid the prepass trying to compute sizes; it was only
9329 approximate and thus did not catch overflow reliably. Instead, walk
9330 through the format just once, formatting and computing sizes as we go,
9331 checking for integer overflow at every step, and allocating a larger
9332 buffer as needed. Keep track separately whether the format is
9333 multibyte. Keep only the most-recently calculated precision, rather
9334 than them all. Record whether each argument has been converted to
9335 string. Use EMACS_INT, not int, for byte and char and arg counts.
9336 Support field widths and precisions larger than INT_MAX. Avoid
9337 sprintf's undefined behavior with conversion specifications such as %#d
9338 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9339 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9340 formatting out-of-range floating point numbers with int
9173deec 9341 formats. (Bug#8668)
37910ab2 9342
2e6578fb
PE
9343 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9344
0ae6bdee
PE
9345 * data.c: Avoid integer truncation in expressions involving floats.
9346 * data.c: Include <intprops.h>.
9347 (arith_driver): When there's an integer overflow in an expression
9348 involving floating point, convert the integers to floating point
9349 so that the resulting value does not suffer from catastrophic
9350 integer truncation. For example, on a 64-bit host (* 4
9351 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9352 Do not rely on undefined behavior after integer overflow.
9353
de883a70
PE
9354 merge count_size_as_multibyte, parse_str_to_multibyte
9355 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9356 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9357 Check for integer overflow.
9358 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9359 since it's now a duplicate of the other. This is more of
9360 a character than a buffer op, so better that it's in character.c.
9361 * fns.c, print.c: Adjust to above changes.
9362
2ff916cb
PE
93632011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9364
9365 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9366
f1b54466
PE
93672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9368
fb1ac845
PE
9369 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9370 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9371 (x_clipboard_manager_save): Now static.
9372 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9373
f1b54466
PE
9374 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9375 (crypto_hash_function): Now static.
9376 Fix pointer signedness problems. Avoid unnecessary initializations.
9377
a9f737ee
CY
93782011-05-27 Chong Yidong <cyd@stupidchicken.com>
9379
9380 * termhooks.h (Vselection_alist): Make it terminal-local.
9381
9382 * terminal.c (create_terminal): Initialize it.
9383
9384 * xselect.c: Support for clipboard managers.
9385 (Vselection_alist): Move to termhooks.h as terminal-local var.
9386 (LOCAL_SELECTION): New macro.
9387 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9388 (symbol_to_x_atom): Remove gratuitous arg.
9389 (x_handle_selection_request, lisp_data_to_selection_data)
9390 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9391 (x_own_selection, x_get_local_selection, x_convert_selection):
9392 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9393 (some_frame_on_display): Delete unused function.
9394 (Fx_own_selection_internal, Fx_get_selection_internal)
9395 (Fx_disown_selection_internal, Fx_selection_owner_p)
9396 (Fx_selection_exists_p): New optional frame arg.
9397 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9398 (x_handle_selection_clear): Don't treat other terminals with the
9399 same keyboard specially. Use the terminal-local Vselection_alist.
9400 (x_clear_frame_selections): Use Frun_hook_with_args.
9401
9402 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9403
9404 * xterm.h: Add support for those atoms.
9405
e067f0c1
CY
94062011-05-26 Chong Yidong <cyd@stupidchicken.com>
9407
9408 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9409 (converted_selections, conversion_fail_tag): New global variables.
9410 (x_selection_request_lisp_error): Free the above.
9411 (x_get_local_selection): Remove unnecessary code.
9412 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9413 of converted selections stored in converted_selections.
9414 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9415 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9416 (x_convert_selection): New function.
9417 (x_handle_selection_event): Simplify.
9418 (x_get_foreign_selection): Don't ignore incoming requests while
9419 waiting for an answer; this will fail when we implement
9420 SAVE_TARGETS, and seems unnecessary anyway.
9421 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9422 (Vx_sent_selection_functions): Doc fix.
9423
0f4aebc0
LL
94242011-05-26 Leo Liu <sdl.web@gmail.com>
9425
9426 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9427
e61124cd
YM
94282011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9429
9430 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9431
9432 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9433 for fringe update if it has periodic bitmap.
ac389d0c 9434 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9435 and fringe_bitmap_periodic_p.
9436
9437 * fringe.c (get_fringe_bitmap_data): New function.
9438 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9439 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9440 row. Mark glyph row for fringe update if periodicity changed.
9441
9442 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9443 for fringe update unless it has periodic bitmap.
9444
f16d9837
KH
94452011-05-25 Kenichi Handa <handa@m17n.org>
9446
9447 * xdisp.c (get_next_display_element): Set correct it->face_id for
9448 a static composition.
9449
e1b90ef6
LL
94502011-05-24 Leo Liu <sdl.web@gmail.com>
9451
9452 * deps.mk (fns.o):
9453 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9454
9455 * fns.c (crypto_hash_function, Fsha1): New function.
9456 (Fmd5): Use crypto_hash_function.
9457 (syms_of_fns): Add Ssha1.
9458
7400048f
PE
94592011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9460
9461 * gnutls.c: Remove unused macros.
9462 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9463 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9464 Remove macros that are defined and never used.
9465 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9466
abb71cf4
CY
94672011-05-22 Chong Yidong <cyd@stupidchicken.com>
9468
9469 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9470 (Fx_get_selection_internal): Minor cleanup.
9471 (Fx_own_selection_internal): Rename arguments for consistency with
9472 select.el.
9473
6307db39
PE
94742011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9475
9476 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9477
f3d4e0a4
CY
94782011-05-22 Chong Yidong <cyd@stupidchicken.com>
9479
9480 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9481
4d8ade89
YM
94822011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9483
9484 * dispnew.c (scrolling_window): Don't exclude the case that the
9485 last enabled row in the desired matrix touches the bottom boundary.
9486
32078c8d
GM
94872011-05-21 Glenn Morris <rgm@gnu.org>
9488
9489 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9490 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9491 and add some more files.
32078c8d 9492
7285dc67
EZ
94932011-05-20 Eli Zaretskii <eliz@gnu.org>
9494
9495 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9496 report_file_error introduced by the change from 2011-05-07.
9497
89d1bd22
PE
94982011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9499
9500 * systime.h (Time): Define only if emacs is defined.
9501 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9502 where the include path doesn't have X11/X.h by default. See
9503 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9504
cd394be1 95052011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9506
9507 * composite.c (find_automatic_composition): Fix previous change.
9508
b9704ad9
GM
95092011-05-20 Glenn Morris <rgm@gnu.org>
9510
9511 * lisp.mk: New file, split from Makefile.in.
9512 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9513 (shortlisp): Remove.
9514 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9515
4a720484
GM
95162011-05-19 Glenn Morris <rgm@gnu.org>
9517
9518 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9519 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9520 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9521 (lisp): Set the order to that of loadup.el.
9522 (shortlisp): Make it a copy of $lisp.
9523 (SOME_MACHINE_LISP): Remove.
9524 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9525 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9526
a28d4396
KH
95272011-05-18 Kenichi Handa <handa@m17n.org>
9528
9529 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9530 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9531 (find_automatic_composition): Mostly rewrite for efficiency.
9532
a2b1fa8e
JB
95332011-05-18 Juanma Barranquero <lekktu@gmail.com>
9534
9535 * makefile.w32-in: Update dependencies.
9536
8e1f5610
CS
95372011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9538
9539 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9540 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9541
7025ee00 95422011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9543
cdfa6eab
PE
9544 Fix some integer overflow issues, such as string length overflow.
9545
06d6db33
PE
9546 * insdel.c (count_size_as_multibyte): Check for string overflow.
9547
2b4560a8
PE
9548 * character.c (lisp_string_width): Check for string overflow.
9549 Use EMACS_INT, not int, for string indexes and lengths; in
9550 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9551 the resulting string length overflows an EMACS_INT; instead,
9552 report a string overflow if no precision given. When checking for
9553 precision exhaustion, use a check that cannot possibly have
9554 integer overflow. (Bug#8675)
9555 * character.h (lisp_string_width): Adjust to new signature.
9556
cb93f9be
PE
9557 * alloc.c (string_overflow): New function.
9558 (Fmake_string): Use it. This doesn't change behavior, but saves
9559 a few bytes and will simplify future changes.
9560 * character.c (string_escape_byte8): Likewise.
9561 * lisp.h (string_overflow): New decl.
9562
1a1f3366
PE
9563 Fixups, following up to the user-interface timestamp change.
9564 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9565 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9566 * msdos.c (mouse_get_pos): Likewise.
9567 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9568 * w32gui.h (Time): Define by including "systime.h" rather than by
9569 declaring it ourselves. (Bug#8664)
9570
d4e3e4d3
PE
9571 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9572 * image.c (clear_image_cache): Likewise.
9573
f6a24d19
PE
9574 * term.c (term_mouse_position): Don't assume time_t wraparound.
9575
08dc5ae6
PE
9576 Be more systematic about user-interface timestamps.
9577 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9578 and sometimes 'EMACS_UINT', to represent these timestamps.
9579 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9580 This makes the code easier to follow, and makes it easier to catch
9581 integer overflow bugs such as Bug#8664.
9582 * frame.c (Fmouse_position, Fmouse_pixel_position):
9583 Use Time, not unsigned long, for user-interface timestamps.
9584 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9585 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9586 * keyboard.h (last_event_timestamp): Likewise.
9587 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9588 * menu.h (xmenu_show): Likewise.
9589 * term.c (term_mouse_position): Likewise.
9590 * termhooks.h (struct input_event.timestamp): Likewise.
9591 (struct terminal.mouse_position_hook): Likewise.
9592 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9593 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9594 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9595 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9596 what it was before.
9597 * menu.h, termhooks.h: Include "systime.h", for Time.
9598
8e55734a
PE
9599 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9600 Don't assume that the difference between two unsigned long values
9601 can fit into an integer. At this point, we know button_down_time
9602 <= event->timestamp, so the difference must be nonnegative, so
9603 there's no need to cast the result if double-click-time is
9604 nonnegative, as it should be; check that it's nonnegative, just in
9605 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9606 apart (about 25 days). (Bug#8664)
8e55734a 9607
841f1b75 9608 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9609 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9610
3e26f69c
PE
9611 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9612 that always fit in int. Use a sentinel instead of a counter, to
9613 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9614 * frame.h (struct frame): Use int for menu_bar_items_used
9615 instead of EMACS_INT, since it always fits in int.
3e26f69c 9616
5cc152c0
PE
9617 * menu.c (grow_menu_items): Check for int overflow.
9618
d89eb65e
PE
9619 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9620
5235bd3e
PE
9621 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9622 Before, the code was not consistent. These values cannot exceed
9623 2**31 - 1 so there's no need to make them unsigned.
9624 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9625 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9626 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9627 as modifiers.
9628 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9629
bc827e23
PE
9630 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9631 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9632 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9633 presumably because the widths might not match.
9634
78eb494e
PE
9635 * window.c (size_window): Avoid needless test at loop start.
9636
04f2d78b
CB
96372011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9638
9639 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9640
d2fc7e3d 96412011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9642
9643 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9644
d2fc7e3d 96452011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9646
9647 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9648 `width' to `bar_area_x' and `bar_area_width', respectively.
9649 (x_scroll_run): Take account of fringe background extension.
9650
04f2d78b
CB
9651 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9652 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9653 `bar_area_width', respectively.
9654 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9655 background extension.
9656
79b70037
GM
96572011-05-10 Jim Meyering <meyering@redhat.com>
9658
9659 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9660
2f142cc5
JB
96612011-05-10 Juanma Barranquero <lekktu@gmail.com>
9662
9663 * image.c (Finit_image_library): Return t for built-in image types,
9664 like pbm and xbm. (Bug#8640)
9665
57679c86
AS
96662011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9667
9668 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9669
888c9e86
EZ
96702011-05-07 Eli Zaretskii <eliz@gnu.org>
9671
b0512a1d
EZ
9672 * w32console.c (Fset_screen_color): Doc fix.
9673 (Fget_screen_color): New function.
9674 (syms_of_ntterm): Defsubr it.
9675
7285dc67
EZ
9676 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9677 unlink the temporary file if Fcall_process didn't create it in the
9678 first place.
9679 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9680 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9681 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9682 cue to call_process_cleanup not to close that handle.
9683
4d3fcc8e
BK
96842011-05-07 Ben Key <bkey76@gmail.com>
9685
9686 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9687 one of two shell specific rules, either bootstrap-temacs-CMD or
9688 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9689 to the previous implementation of the bootstrap-temacs rule.
9690 The bootstrap-temacs-CMD rule is similar to the previous
9691 implementation of the bootstrap-temacs rule except that it
9692 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9693 variable.
9694
9695 These changes, along with some changes to nt/configure.bat,
9696 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9697 earlier fix to add support for --cflags and --ldflags options
9698 that include quotes so that it works whether make uses cmd or
9699 sh as the shell.
9700
b4289b64
MA
97012011-05-06 Michael Albinus <michael.albinus@gmx.de>
9702
9703 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9704 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9705 is a constant.
9706 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9707 a string. Handle both cases.
9708 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9709 (Fdbus_register_method): Use Qinvalid_function.
9710
af4c0e28
JB
97112011-05-06 Juanma Barranquero <lekktu@gmail.com>
9712
9713 * makefile.w32-in: Update dependencies.
9714 (LISP_H): Add inttypes.h and stdin.h.
9715 (PROCESS_H): Add unistd.h.
9716
c51453d9
EZ
97172011-05-06 Eli Zaretskii <eliz@gnu.org>
9718
9719 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9720 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9721
8ff0ac3c 97222011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9723
4c4b566b
PE
9724 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9725
aab2b9b5
PE
9726 * term.c (vfatal): Remove stray call to va_end.
9727 It's not needed and the C Standard doesn't allow it here anyway.
9728
c378da0b
PE
9729 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9730 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9731
288b08c7
PE
9732 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9733 bytes.
9734
e3601888
PE
9735 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9736
db6c0e74
PE
9737 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9738
dd5963ea
PE
9739 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9740
88c9450f
PE
9741 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9742
2f9442b8
PE
9743 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9744
c032b5f8
PE
9745 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9746 * charset.c (Fdefine_charset_internal): Don't initialize
9747 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9748 32-bit int (Bug#8600).
a108c10b
PE
9749
9750 * lread.c (read_integer): Be more consistent with string-to-number.
9751 Use string_to_number to do the actual conversion; this avoids
9752 rounding errors and fixes some other screwups. Without this fix,
9753 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9754 (digit_to_number): Move earlier, for benefit of read_integer.
9755 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9756 not a digit in any supported base. (Bug#8602)
a108c10b 9757
ad5f9eea
PE
9758 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9759
aec1708a
PE
9760 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9761 to match comment at start of function. This also removes a
9762 GCC warning about overflow in a 32+64-bit port.
9763
47be4ab5
PE
9764 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9765
371cac43
PE
9766 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9767 Reported by Stefan Monnier in
9768 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9769 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9770 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9771
d01a7826
PE
9772 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9773 (EMACS_UINTPTR): Likewise, with uintptr_t.
9774
7fd47d5c
PE
9775 * lisp.h: Prefer 64-bit EMACS_INT if available.
9776 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9777 on 32-bit hosts that have 64-bit int, so that they can access
9778 large files.
122b0c86
PE
9779 However, temporarily disable this change unless the temporary
9780 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9781
8727937b
PE
9782 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9783
8ac068ac
PE
9784 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9785 This removes an assumption that EMACS_INT and long are the same
9786 width as pointers. The assumption is true for Emacs porting targets
9787 now, but we want to make other targets possible.
9788 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9789 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9790 In the rest of the code, change types of integers that hold casted
9791 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9792 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9793 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9794 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9795 No need to cast type when ORing.
9796 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9797 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9798 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9799 assume EMACS_INT is the same width as char *.
9800 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9801 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9802 Remove no-longer-needed casts.
9803 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9804 (xg_tool_bar_help_callback, xg_make_tool_item):
9805 Use EMACS_INTPTR to hold an integer
9806 that will be cast to void *; this can avoid a GCC warning
9807 if EMACS_INT is not the same width as void *.
9808 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9809 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9810 (current_message_1, set_message_1):
9811 Use a local to convert to proper width without a cast.
9812 * xmenu.c (dialog_selection_callback): Likewise.
9813
ede49d71
PE
9814 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9815 Also, don't assume VALBITS / RAND_BITS is less than 5,
9816 and don't rely on undefined behavior when shifting a 1 left into
9817 the sign bit.
9818 * lisp.h (get_random): Change signature to match.
9819
2f30ecd0
PE
9820 * lread.c (hash_string): Use size_t, not int, for hash computation.
9821 Normally we prefer signed values; but hashing is special, because
9822 it's better to use unsigned division on hash table sizes so that
9823 the remainder is nonnegative. Also, size_t is the natural width
9824 for hashing into memory. The previous code used 'int', which doesn't
9825 retain enough info to hash well into very large tables.
9826 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9827
2a866e7b
PE
9828 * dbusbind.c: Don't possibly lose pointer info when converting.
9829 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9830 Use XPNTR rather than XHASH, so that the high-order bits of
9831 the pointer aren't lost when converting through void *.
9832
51639eac
PE
9833 * eval.c (Fautoload): Don't double-shift a pointer.
9834
92394119
PE
9835 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9836
dbdb9a7c
JB
98372011-05-06 Juanma Barranquero <lekktu@gmail.com>
9838
9839 * gnutls.c (DEF_GNUTLS_FN):
9840 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9841
db7a0b4f
AS
98422011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9843
9844 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9845 marker. (Bug#8610)
9846
cd394be1 98472011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9848
9849 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9850 New version that can reserve upto 2GB of heap space.
9851
f7ff1b0f 98522011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9853
9854 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9855
639c109b
TZ
98562011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9857
9858 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9859 `gnutls_certificate_set_x509_key_file'.
9860
d2127135
JB
98612011-05-05 Juanma Barranquero <lekktu@gmail.com>
9862
9863 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9864 Update dependencies.
9865
e968f4f3
JB
98662011-05-04 Juanma Barranquero <lekktu@gmail.com>
9867
9868 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9869 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9870 Remove unused parameter `fildes'.
9871 * process.c (read_process_output, send_process): Don't pass it.
9872
84d358f0
JB
98732011-05-04 Juanma Barranquero <lekktu@gmail.com>
9874
9875 Fix previous change: the library cache is defined in w32.c.
9876 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9877 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9878
0898ca10
JB
98792011-05-04 Juanma Barranquero <lekktu@gmail.com>
9880
9881 Implement dynamic loading of GnuTLS on Windows.
9882
9883 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9884 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9885 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9886 Declare.
9887
9888 * gnutls.c (Qgnutls_dll): Define.
9889 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9890 (gnutls_*): Declare function pointers.
9891 (init_gnutls_functions): New function to initialize function pointers.
9892 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9893 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9894 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9895 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9896 (emacs_gnutls_write, emacs_gnutls_read)
9897 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9898 (Fgnutls_available_p): New function.
9899 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9900 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9901 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9902
9903 * image.c: Include w32.h.
9904 (Vimage_type_cache): Delete.
9905 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9906 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9907 (w32_delayed_load): Move to w32.c.
9908
9909 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9910
9911 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9912 (w32_delayed_load): Move from image.c. When loading a library, record
9913 its filename in the :loaded-from property of the library id.
9914 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9915 Initialize and staticpro them.
9916 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9917
9918 * process.c: Include lisp.h before w32.h, not after.
9919 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9920 instead of gnutls_record_check_pending.
9921
9922 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9923
ff4de4aa
TZ
99242011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9925
9926 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9927 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9928 as passed in.
9929
abe95abb
JD
99302011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9931
9932 * xterm.c (x_set_frame_alpha): Do not set property on anything
9933 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9934
e16e55d4
JB
99352011-05-02 Juanma Barranquero <lekktu@gmail.com>
9936
9937 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9938
bafcf6a5
JB
99392011-05-02 Juanma Barranquero <lekktu@gmail.com>
9940
9941 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9942 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9943 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9944 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9945 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9946 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9947 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9948 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9949 (Qgnutls_bootprop_callbacks_verify): Make static.
9950
e7a6747f
AS
99512011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9952
19ed11ba
AS
9953 * callproc.c: Indentation fixup.
9954
e7a6747f 9955 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9956 (wait_for_termination, interruptible_wait_for_termination):
9957 Move after wait_for_termination_1.
e7a6747f 9958
1ef14cb4
LMI
99592011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9960
9961 * sysdep.c (interruptible_wait_for_termination): New function
9962 which is like wait_for_termination, but allows keyboard
9963 interruptions.
9964
9965 * callproc.c (Fcall_process): Add (:file "file") as an option for
9966 the STDOUT buffer.
9967 (Fcall_process_region): Ditto.
9968
330d880c
EZ
99692011-04-30 Eli Zaretskii <eliz@gnu.org>
9970
8db90b73
EZ
9971 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9972 rather than `XVECTOR (FOO)->size'.
9973
330d880c
EZ
9974 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9975 inttypes.h, as a gnulib replacement is used if it not available in
9976 system headers.
9977
15cbd324
EZ
99782011-04-21 Eli Zaretskii <eliz@gnu.org>
9979
9980 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9981 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9982 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9983
9984 * coding.c (coding_alloc_by_realloc): Error out if destination
9985 will grow beyond MOST_POSITIVE_FIXNUM.
9986 (decode_coding_emacs_mule): Abort if there isn't enough place in
9987 charbuf for the composition carryover bytes. Reserve an extra
9988 space for up to 2 characters produced in a loop.
9989 (decode_coding_iso_2022): Abort if there isn't enough place in
9990 charbuf for the composition carryover bytes.
9991
99922011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9993
ae940cca
EZ
9994 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9995 aborting when %lld or %lll format is passed.
9996 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9997 %llo or %llx format is passed. (Bug#8545)
9998
03ab8921
EZ
9999 * window.c (window_scroll_line_based): Use a marker instead of
10000 simple variables to record original value of point. (Bug#7952)
10001
afda1437
EZ
10002 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10003 produced by %s or %c overflows available buffer space. (Bug#8545)
10004
f76dee0c
PE
100052011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10006
10007 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10008 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10009
fdc5744d
JB
100102011-04-28 Juanma Barranquero <lekktu@gmail.com>
10011
10012 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10013
638f053a
JB
100142011-04-28 Juanma Barranquero <lekktu@gmail.com>
10015
10016 * keyboard.c (Qdelayed_warnings_hook): Define.
10017 (command_loop_1): Run `delayed-warnings-hook'
10018 if Vdelayed_warnings_list is non-nil.
10019 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10020 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10021
d178f871
EZ
100222011-04-28 Eli Zaretskii <eliz@gnu.org>
10023
10024 * doprnt.c (doprnt): Don't return value smaller than the buffer
10025 size if the message was truncated. (Bug#8545).
10026
b124fd93
JB
100272011-04-28 Juanma Barranquero <lekktu@gmail.com>
10028
10029 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10030 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10031
e810457d
PE
100322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10033
10034 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10035
ea51cceb
JB
100362011-04-27 Juanma Barranquero <lekktu@gmail.com>
10037
10038 * makefile.w32-in: Update dependencies.
10039
94dcfacf
EZ
100402011-04-27 Eli Zaretskii <eliz@gnu.org>
10041
10042 Improve `doprnt' and its usage. (Bug#8545)
10043 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10044 `format_end'. Remove support for %l as a conversion specifier.
10045 Don't use xrealloc. Improve diagnostics when the %l size modifier
10046 is used. Update the commentary.
10047
10048 * eval.c (verror): Simplify calculation of size_t.
10049
10050 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10051 messages.
10052
f61f41d7
PE
100532011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10054
10055 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10056 change.
10057
96fb4434
PE
100582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10059
10060 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10061 This makes this file independent of the recent pseudovector change.
10062
671875da 100632011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10064
69e9b5a3
PE
10065 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10066
b5f869a7 10067 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10068 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10069 Remove unused local.
c8926152 10070 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10071
841a1577 10072 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10073 GCC 4.6.0 optimizes based on type-based alias analysis.
10074 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10075 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10076 != &v->size, and therefore "v->size = 1; b->size = 2; return
10077 v->size;" must therefore return 1. This assumption is incorrect
10078 for Emacs, since it type-puns struct Lisp_Vector * with many other
10079 types. To fix this problem, this patch adds a new type struct
f904488f 10080 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10081 and pseudovectors, and helps optimizing compilers not get fooled
10082 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10083 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10084 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10085 the size member.
eab3844f
PE
10086 (XSETPVECTYPE): Rewrite in terms of new macro.
10087 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10088 This is a bit clearer, and further avoids the possibility of
10089 undesirable aliasing.
10090 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10091 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10092 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10093 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10094 (ASIZE): Now uses header.size rather than size.
10095 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10096 to avoid the hassle of writing XVECTOR (foo)->header.size.
10097 (struct vectorlike_header): New type.
eab3844f
PE
10098 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10099 object, to help avoid aliasing.
10100 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10101 (SUBRP): Likewise, since Lisp_Subr is a special case.
10102 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10103 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10104 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10105 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10106 changed to be "header.size" and "header.next".
10107 * buffer.h (struct buffer): Likewise.
10108 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10109 * frame.h (struct frame): Likewise.
10110 * process.h (struct Lisp_Process): Likewise.
10111 * termhooks.h (struct terminal): Likewise.
10112 * window.c (struct save_window_data, struct saved_window): Likewise.
10113 * window.h (struct window): Likewise.
10114 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10115 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10116 * buffer.c (init_buffer_once): Likewise.
10117 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10118 special case.
10119 * process.c (Fformat_network_address): Use local var for size,
10120 for brevity.
10121
0df1eac5
PE
10122 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10123
847ab9d1 10124 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10125 * data.c (atof): Remove decl; no longer used or needed.
10126 (digit_to_number): Move to lread.c.
10127 (Fstring_to_number): Use new string_to_number function, to be
10128 consistent with how the Lisp reader treats infinities and NaNs.
10129 Do not assume that floating-point numbers represent EMACS_INT
10130 without losing information; this is not true on most 64-bit hosts.
10131 Avoid double-rounding errors, by insisting on integers when
10132 parsing non-base-10 numbers, as the documentation specifies.
10133 * lisp.h (string_to_number): New decl, replacing ...
10134 (isfloat_string): Remove.
bc0a5c13 10135 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10136 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10137 appears to have been a coding error. Similarly, do not accept
10138 strings like +-1e0 as floating point numbers. Do not report
10139 overflow for integer overflows unless the base is not 10 which
10140 means we have no simple and reliable way to continue.
10141 Break out the floating-point parsing into a new
10142 function string_to_number, so that Fstring_to_number parses
10143 floating point numbers consistently with the Lisp reader.
04f2d78b 10144 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10145 (E_CHAR, EXP_INT): Remove, replacing with ...
10146 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10147 (string_to_number): New function, replacing isfloat_string.
10148 This function checks for valid syntax and produces the resulting
10149 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10150 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10151 so that overflow for non-base-10 numbers is reported only when
10152 there's no portable and simple way to convert to floating point.
452f4150 10153
67769ffc
PE
10154 * textprop.c (set_text_properties_1): Rewrite for clarity,
10155 and to avoid GCC warning about integer overflow.
10156
c20db43f
PE
10157 * intervals.h (struct interval): Use EMACS_INT for members
10158 where EMACS_UINT might cause problems. See
10159 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10160 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10161 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10162 All uses changed.
37aa2f85
PE
10163 (offset_intervals): Tell GCC not to worry about length overflow
10164 when negating a negative length.
c20db43f 10165
2538aa2f
PE
10166 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10167 (overrun_check_free): Likewise.
10168
f2d3008d
PE
10169 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10170 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10171 word size.
10172
ec8df744
PE
10173 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10174 (gnutls_make_error): Rename local to avoid shadowing.
10175 (gnutls_emacs_global_deinit): ifdef out; not used.
10176 (Fgnutls_boot): Use const for pointer to readonly storage.
10177 Comment out unused local. Fix pointer signedness problems.
10178
640ee02d
PE
10179 * lread.c (openp): Don't stuff size_t into an 'int'.
10180 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10181 about possible signed overflow.
10182
6048fb2a
PE
10183 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10184 (GDK_KEY_g): Don't define if already defined.
10185 (xg_prepare_tooltip): Avoid pointer signedness problem.
10186 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10187
fa3c87e1
PE
10188 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10189 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10190
2172544b
PE
10191 * xfns.c (Fx_window_property): Simplify a bit,
10192 to make a bit faster and to avoid GCC 4.6.0 warning.
10193 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10194
9b821a21
PE
10195 * fns.c (internal_equal): Don't assume size_t fits in int.
10196
3c616cfa
PE
10197 * alloc.c (compact_small_strings): Tighten assertion a little.
10198
c2982e87
PE
10199 Replace pEd with more-general pI, and fix some printf arg casts.
10200 * lisp.h (pI): New macro, generalizing old pEd macro to other
10201 conversion specifiers. For example, use "...%"pI"d..." rather
10202 than "...%"pEd"...".
10203 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10204 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10205 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10206 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10207 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10208 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10209 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10210 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10211 64-bit hosts.
10212 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10213 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10214 * print.c (safe_debug_print, print_object): Likewise.
10215 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10216 to int.
6f04d126
PE
10217 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10218 avoiding the 0 flag, which is not portable.
c2982e87
PE
10219 * process.c (Fmake_network_process): Use pI to avoid cast.
10220 * region-cache.c (pp_cache): Likewise.
10221 * xdisp.c (decode_mode_spec): Likewise.
10222 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10223 behavior on 64-bit hosts with printf arg.
6f04d126 10224 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10225 (x_stop_queuing_selection_requests): Likewise.
10226 (x_get_window_property): Don't truncate byte count to an 'int'
10227 when tracing.
0b432f21 10228
5e073ec7
PE
10229 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10230 here, since it parses constructs like leading '-' and spaces,
10231 which are not wanted; and it overflows with large numbers.
10232 Instead, simply match F[0-9]+, which is what is wanted anyway.
10233
36372bf9
PE
10234 * alloc.c: Remove unportable assumptions about struct layout.
10235 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10236 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10237 (allocate_vectorlike, make_pure_vector): Use the new macros,
10238 plus offsetof, to remove unportable assumptions about struct layout.
10239 These assumptions hold on all porting targets that I know of, but
10240 they are not guaranteed, they're easy to remove, and removing them
10241 makes further changes easier.
10242
0b432f21
PE
10243 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10244 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10245 (string_overrun_cookie): Now const. Use initializers that
10246 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10247 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10248 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10249 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10250 multiple of sizeof (EMACS_INT); it need not be, if
10251 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10252 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10253
895009e1
JB
102542011-04-26 Juanma Barranquero <lekktu@gmail.com>
10255
10256 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10257
6a7a1b0b
TZ
102582011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10259
10260 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10261 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10262 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10263
841a1577 102642011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10265
10266 * lisp.h (Qdebug): List symbol.
895009e1 10267 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10268 * keyboard.c (debug-on-event): New variable.
10269 (handle_user_signal): Break into debugger when debug-on-event
10270 matches the current signal symbol.
10271
f2d3ba6f
DN
102722011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10273
10274 * alloc.c (check_sblock, check_string_bytes)
10275 (check_string_free_list): Convert to standard C.
10276
42ce4c63
TZ
102772011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10278
10279 * w32.c (emacs_gnutls_push): Fix typo.
10280
825cd63c
EZ
102812011-04-25 Eli Zaretskii <eliz@gnu.org>
10282
fb11d64d
EZ
10283 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10284 "cast to pointer from integer of different size".
10285
825cd63c
EZ
10286 Improve doprnt and its use in verror. (Bug#8545)
10287 * doprnt.c (doprnt): Document the set of format control sequences
10288 supported by the function. Use SAFE_ALLOCA instead of always
10289 using `alloca'.
10290
10291 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10292 is one byte too soon. Don't use xrealloc; instead xfree and
10293 xmalloc anew.
10294
e061a11b
TZ
102952011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10296
10297 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10298 callbacks stage.
10299
10300 * gnutls.c: Renamed global_initialized to
10301 gnutls_global_initialized. Added internals for the
10302 :verify-hostname-error, :verify-error, and :verify-flags
10303 parameters of `gnutls-boot' and documented those parameters in the
10304 docstring. Start callback support.
9173deec
JB
10305 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10306 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10307 on error. Return error code.
e061a11b
TZ
10308 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10309 (emacs_gnutls_read): Likewise.
10310 (Fgnutls_boot): Return handshake error code.
10311 (emacs_gnutls_handle_error): New function.
10312 (wsaerror_to_errno): Likewise.
10313
10314 * w32.h (emacs_gnutls_pull): Add prototype.
10315 (emacs_gnutls_push): Likewise.
10316
10317 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10318 (emacs_gnutls_push): Likewise.
10319
103202011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10321
10322 * process.c (wait_reading_process_output): Check if GnuTLS
10323 buffered some data internally if no FDs are set for TLS
10324 connections.
10325
10326 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10327 (LIBS): Link to USER_LIBS.
10328 ($(BLD)/gnutls.$(0)): New target.
10329
fa6996bc
EZ
103302011-04-24 Eli Zaretskii <eliz@gnu.org>
10331
eb35682e
EZ
10332 * xdisp.c (handle_single_display_spec): Rename the
10333 display_replaced_before_p argument into display_replaced_p, to
10334 make it consistent with the commentary. Fix typos in the
10335 commentary.
10336
e2ad650c
EZ
10337 * textprop.c (syms_of_textprop): Remove dead code.
10338 (copy_text_properties): Delete obsolete commentary about an
10339 interface that was deleted long ago. Fix typos in the description
10340 of arguments.
10341
1b2de274
EZ
10342 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10343 to changes in oldXMenu/XMenu.h from 2011-04-16.
10344 <menu_help_message, prev_menu_help_message>: Constify.
10345 (IT_menu_make_room): menu->help_text is now `const char **';
10346 adjust.
10347
10348 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10349 to changes in oldXMenu/XMenu.h from 2011-04-16.
10350 (struct XMenu): Declare `help_text' `const char **'.
10351
10352 * xfaces.c <Qunspecified>: Make extern again.
10353
10354 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10355 required by POSIX.
1b2de274 10356
762b15be
EZ
10357 * doc.c (get_doc_string): Improve the format passed to `error'.
10358
10359 * doprnt.c (doprnt): Improve commentary.
10360
10361 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10362
10363 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10364 them with etags.
10365
f1052e5d
EZ
10366 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10367 changes in globals.h immediately force recompilation.
762b15be
EZ
10368 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10369 $(CURDIR)/s/ms-w32.h.
10370 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10371
fa6996bc
EZ
10372 * character.c (Fchar_direction): Function deleted.
10373 (syms_of_character): Don't defsubr it.
10374 <char-direction-table>: Deleted.
10375
e6c3da20
EZ
103762011-04-23 Eli Zaretskii <eliz@gnu.org>
10377
10378 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10379 * doprnt.c: Include limits.h.
10380 (SIZE_MAX): New macro.
04f2d78b
CB
10381 (doprnt): Return a size_t value. 2nd arg is now size_t.
10382 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10383 Improve overflow protection. Support `l' modifier for integer
10384 conversions. Support %l conversion. Don't assume an EMACS_INT
10385 argument for integer conversions and for %c.
10386
10387 * lisp.h (doprnt): Restore prototype.
10388
10389 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10390 $(SRC)/character.h.
10391
10392 * Makefile.in (base_obj): Add back doprnt.o.
10393
10394 * deps.mk (doprnt.o): Add back prerequisites.
10395 (callint.o): Depend on character.h.
10396
10397 * eval.c (internal_lisp_condition_case): Include the handler
10398 representation in the error message.
10399 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10400 when breaking from the loop.
10401
10402 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10403
10404 * callint.c (Fcall_interactively): When displaying error message
10405 about invalid control letter, pass the character's codepoint, not
10406 a pointer to its multibyte form. Improve display of the character
10407 in octal and display also its hex code.
10408
10409 * character.c (char_string): Use %x to display the (unsigned)
10410 codepoint of an invalid character, to avoid displaying a bogus
10411 negative value.
10412
10413 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10414 `error', not SYMBOL_NAME itself.
10415
10416 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10417 character arguments to `error'.
10418
10419 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10420 to `error' in error message about FINAL_CHAR argument. Make sure
10421 FINAL_CHAR is a character, and use %c when it is passed as
10422 argument to `error'.
10423
4ffd0d6b 104242011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10425
10426 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10427
10428 * w32.c: Include <time.h>.
10429 (sys_localtime): New function.
10430
4ffd0d6b 104312011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10432
10433 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10434
4ffd0d6b 10435 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10436
4ffd0d6b 104372011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10438
4ffd0d6b
GM
10439 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10440 zombies (Bug#8467).
aac0c6e3 10441
04c56954
EZ
104422011-04-19 Eli Zaretskii <eliz@gnu.org>
10443
10444 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10445 gl_state.e_property when gl_state.object is Qt.
10446
10447 * insdel.c (make_gap_larger): Remove limitation of buffer size
10448 to <= INT_MAX.
10449
16a43933
CY
104502011-04-18 Chong Yidong <cyd@stupidchicken.com>
10451
10452 * xdisp.c (lookup_glyphless_char_display)
10453 (produce_glyphless_glyph): Handle cons cell entry in
10454 glyphless-char-display.
10455 (Vglyphless_char_display): Document it.
10456
10457 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10458 glyphless-char-display.
10459
4581706e
CY
104602011-04-17 Chong Yidong <cyd@stupidchicken.com>
10461
10462 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10463
10464 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10465
10466 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10467 definition for no-X builds.
10468
4887c6e2 104692011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10470
fd35b6f9
PE
10471 Static checks with GCC 4.6.0 and non-default toolkits.
10472
5c1ccb01
PE
10473 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10474
006c5daa
PE
10475 * process.c (keyboard_bit_set): Define only if SIGIO.
10476 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10477 (send_process): Repair possible setjmp clobbering.
10478
efc736d3
PE
10479 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10480
4e2fe2e6
PE
10481 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10482
f97334a2
PE
10483 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10484
4e75f29d
PE
10485 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10486 Define only if needed.
10487
90efadd1
PE
10488 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10489 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10490 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10491
3c647824
PE
10492 * dispextern.h (struct redisplay_interface): Rename param
10493 to avoid shadowing.
e264f262 10494 * termhooks.h (struct terminal): Likewise.
761383f4 10495 * xterm.c (xembed_send_message): Likewise.
3c647824 10496
b58c5c4a
PE
10497 * insdel.c (make_gap_smaller): Define only if
10498 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10499
cad59032
PE
10500 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10501 it.
10502
c339dc2e
PE
10503 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10504 so that we aren't warned about unused symbols.
10505
91a3e27b
PE
10506 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10507
399c71d3 10508 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10509
8ffc96f5
PE
10510 * xfns.c (x_real_positions): Mark locals as initialized.
10511
eef9bc79
PE
10512 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10513
098db9dd
PE
10514 * xterm.c: Fix problems found by static analysis with other toolkits.
10515 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10516 (x_dispatch_event): Declare static if USE_GTK, and
10517 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10518 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10519 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10520 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10521 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10522
eb18f6cc
PE
10523 * xmenu.c (menu_help_callback): Pointer type fixes.
10524 Use const pointers when pointing at readonly data. Avoid pointer
10525 signedness clashes.
10526 (FALSE): Remove unused macro.
10527 (update_frame_menubar): Remove unused decl.
10528
1fe72bf8
PE
10529 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10530
60d9e1db
PE
10531 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10532 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10533 (single_menu_item): Rename local to avoid shadowing.
10534
39261c26
PE
10535 * keyboard.c (make_lispy_event): Remove unused local var.
10536
018c5e19
PE
10537 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10538 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10539
63d2b86e
PE
10540 * bitmaps: Change bitmaps from unsigned char back to the X11
10541 compatible char. Avoid the old compiler warnings about
10542 out-of-range initializers by using, for example, '\xab' rather
10543 than 0xab.
10544
aefd87e1
PE
10545 * xgselect.c (xgselect_initialize): Check vs interface
10546 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10547
bf501fb9
PE
10548 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10549
e9829fdf
PE
10550 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10551 to read-only memory.
10552
1086c095
PE
10553 * fns.c (vector): Remove; this old hack is no longer needed.
10554
2baccd04 10555 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10556 Remove unused var.
dde42981 10557 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10558
72391843 10559 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10560
436c16df 10561 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10562 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10563 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10564
92bb796d 10565 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10566 (x_term_init): Remove local to avoid shadowing.
92bb796d 10567
764430a3 10568 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10569
10570 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10571 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10572
d1dfb56c
EZ
105732011-04-16 Eli Zaretskii <eliz@gnu.org>
10574
c4354cb4
EZ
10575 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10576
d1dfb56c
EZ
10577 Fix regex.c, syntax.c and friends for buffers > 2GB.
10578 * syntax.h (struct gl_state_s): Declare character position members
10579 EMACS_INT.
10580
10581 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10582
04f2d78b
CB
10583 * textprop.c (verify_interval_modification, interval_of):
10584 Declare arguments EMACS_INT.
d1dfb56c
EZ
10585
10586 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10587 EMACS_INT.
10588
10589 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10590
10591 * indent.c (Fvertical_motion): Local variable it_start is now
10592 EMACS_INT.
10593
10594 * regex.c (re_match, re_match_2, re_match_2_internal)
10595 (bcmp_translate, regcomp, regexec, print_double_string)
10596 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10597 (re_compile_pattern, re_exec): Declare arguments and local
10598 variables `size_t' and `ssize_t' and return values `regoff_t', as
10599 appropriate.
10600 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10601 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10602 <compile_stack_type>: `size' and `avail' are now `size_t'.
10603
10604 * regex.h <regoff_t>: Use ssize_t, not int.
10605 (re_search, re_search_2, re_match, re_match_2): Arguments that
10606 specify buffer/string position and length are now ssize_t and
10607 size_t. Return type is regoff_t.
10608
613052cd
BK
106092011-04-16 Ben Key <bkey76@gmail.com>
10610
10611 * nsfont.m: Fixed bugs in ns_get_family and
10612 ns_descriptor_to_entity that were caused by using free to
10613 deallocate memory blocks that were allocated by xmalloc (via
10614 xstrdup). This caused Emacs to crash when compiled with
10615 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10616 --enable-checking=xmallocoverrun). xfree is now used to
10617 deallocate these memory blocks.
10618
4170f62f 106192011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10620
71b41406
PE
10621 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10622
9587a89d
PE
10623 emacs_write: Accept and return EMACS_INT for sizes.
10624 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10625 et seq.
10626 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10627 Accept and return EMACS_INT.
10628 (emacs_gnutls_write): Return the number of bytes written on
10629 partial writes.
10630 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10631 (emacs_read, emacs_write): Remove check for negative size, as the
10632 Emacs source code has been audited now.
9587a89d
PE
10633 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10634 (emacs_read, emacs_write): Use it.
273a5f82
PE
10635 * process.c (send_process): Adjust to the new signatures of
10636 emacs_write and emacs_gnutls_write. Do not attempt to store
10637 a byte offset into an 'int'; it might overflow.
9587a89d 10638 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10639
3e047f51
PE
10640 * sound.c: Don't assume sizes fit in 'int'.
10641 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10642 Return EMACS_INT, not int.
3e047f51 10643 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10644 Accept EMACS_INT, not int.
10645 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10646 record read return values.
10647
cc39a9db
BK
106482011-04-15 Ben Key <bkey76@gmail.com>
10649
c9d0ec6d
JB
10650 * keyboard.c (Qundefined): Don't declare static since it is used
10651 in nsfns.m.
10652 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10653 static since they are used in nsfont.m.
cc39a9db 10654
6c60eb9f
SM
106552011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10656
10657 * process.c (Qprocessp): Don't declare static.
10658 * lisp.h (Qprocessp): Declare again.
10659
7990b61a
JB
106602011-04-15 Juanma Barranquero <lekktu@gmail.com>
10661
10662 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10663
5d4cb038
PE
106642011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10665
8bd7b830 10666 Improve C-level modularity by making more things 'static'.
cd64ea1d 10667
e3b27b31
PE
10668 Don't publish debugger-only interfaces to other modules.
10669 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10670 (verify_bytepos, count_markers): Move decls to the only modules
10671 that need them.
10672 * region-cache.h (pp_cache): Likewise.
10673 * window.h (check_all_windows): Likewise.
10674 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10675
5d4cb038
PE
10676 * sysdep.c (croak): Now static, if
10677 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10678 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10679
10680 * alloc.c (refill_memory_reserve): Now static if
10681 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10682 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10683
e87b6180
PE
10684 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10685 Define only if USE_LUCID.
10686
ac64929e
PE
10687 * xrdb.c (x_customization_string, x_rm_string): Now static.
10688
6f37259d
PE
10689 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10690 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10691
1683e3ab
PE
10692 * xdisp.c (draw_row_with_mouse_face): Now static.
10693 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10694
de9c2632
PE
10695 * window.h (check_all_windows): Mark externally visible.
10696
2b96acb7
PE
10697 * window.c (window_deletion_count): Now static.
10698
10699 * undo.c: Make symbols static if they're not exported.
10700 (last_undo_buffer, last_boundary_position, pending_boundary):
10701 Now static.
10702
50436f33
PE
10703 * textprop.c (interval_insert_behind_hooks): Now static.
10704 (interval_insert_in_front_hooks): Likewise.
10705
64520e5c
PE
10706 * term.c: Make symbols static if they're not exported.
10707 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10708 (max_frame_lines, tty_set_terminal_modes):
10709 (tty_reset_terminal_modes, tty_turn_off_highlight):
10710 (get_tty_terminal): Now static.
10711 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10712 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10713 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10714 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10715 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10716
1fa53021
PE
10717 * sysdep.c: Make symbols static if they're not exported.
10718 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10719 Now static.
10720 (sigprocmask_set, full_mask): Remove; unused.
10721 (wait_debugging): Mark as visible.
10722 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10723 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10724
d4b43b22
PE
10725 * syntax.c (syntax_temp): Define only if !__GNUC__.
10726
b7c513d0
PE
10727 * sound.c (current_sound_device, current_sound): Now static.
10728
989b29ad
PE
10729 * search.c (searchbufs, searchbuf_head): Now static.
10730
13a55a78
PE
10731 * scroll.c (scroll_cost): Remove; unused.
10732 * dispextern.h (scroll_cost): Remove decl.
10733
de68a1fc
PE
10734 * region-cache.h (pp_cache): Mark as externally visible.
10735
40ccffa6
PE
10736 * process.c: Make symbols static if they're not exported.
10737 (process_tick, update_tick, create_process, chan_process):
10738 (Vprocess_alist, proc_buffered_char, datagram_access):
10739 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10740 (deactivate_process): Mark defn as static, as well as decl.
10741 * lisp.h (create_process): Remove decl.
10742 * process.h (chan_process, Vprocess_alist): Remove decls.
10743
ad64fc97
PE
10744 * print.c: Make symbols static if they're not exported.
10745 (print_depth, new_backquote_output, being_printed, print_buffer):
10746 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10747 (print_interval, print_number_index, initial_stderr_stream):
10748 Now static.
10749 * lisp.h (Fprinc): Remove decl.
10750 (debug_output_compilation_hack): Mark as externally visible.
10751
adddb265
PE
10752 * sysdep.c (croak): Move decl from here to syssignal.h.
10753 * syssignal.h (croak): Put it here, so the API can be checked when
10754 'croak' is called from dissociate_if_controlling_tty.
10755
1717ede2
PE
10756 * minibuf.c: Make symbols static if they're not exported.
10757 (minibuf_save_list, choose_minibuf_frame): Now static.
10758 * lisp.h (choose_minibuf_frame): Remove decl.
10759
fa5fb2bc
PE
10760 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10761
1e3890d1
PE
10762 * lread.c: Make symbols static if they're not exported.
10763 (read_objects, initial_obarray, oblookup_last_bucket_number):
10764 Now static.
10765 (make_symbol): Remove; unused.
10766 * lisp.h (initial_obarray, make_symbol): Remove decls.
10767
8a1414fa
PE
10768 * keyboard.c: Make symbols static if they're not exported.
10769 (single_kboard, recent_keys_index, total_keys, recent_keys):
10770 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10771 (this_single_command_key_start, echoing, last_auto_save):
10772 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10773 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10774 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10775 (Vlispy_mouse_stem, double_click_count):
10776 Now static.
10777 (force_auto_save_soon): Define only if SIGDANGER.
10778 (ignore_mouse_drag_p): Now static if
10779 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10780 (print_help): Remove; unused.
10781 (stop_character, last_timer_event): Mark as externally visible.
10782 * keyboard.h (ignore_mouse_drag_p): Declare only if
10783 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10784 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10785 * lisp.h (echoing): Remove decl.
10786 (force_auto_save_soon): Declare only if SIGDANGER.
10787 * xdisp.c (redisplay_window): Simplify code, to make it more
10788 obvious that ignore_mouse_drag_p is not accessed if !defined
10789 USE_GTK && !defined HAVE_NS.
10790
93ea6e8f
PE
10791 * intervals.c: Make symbols static if they're not exported.
10792 (merge_properties_sticky, merge_interval_right, delete_interval):
10793 Now static.
10794 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10795
77382fcc
PE
10796 * insdel.c: Make symbols static if they're not exported.
10797 However, leave prepare_to_modify_buffer alone. It's never
10798 called from outside this function, but that appears to be a bug.
10799 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10800 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10801 (adjust_after_replace_noundo): Remove; unused.
10802 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10803 (signal_before_change): Remove decls.
77382fcc 10804
9306c32e
PE
10805 * indent.c (val_compute_motion, val_vmotion): Now static.
10806
cd44d2eb
PE
10807 * image.c: Make symbols static if they're not exported.
10808 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10809 if USE_GTK.
10810 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10811 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10812
ad9a7a06
PE
10813 * fringe.c (standard_bitmaps): Now static.
10814 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10815
81626931
PE
10816 * frame.c: Make symbols static if they're not exported.
10817 (x_report_frame_params, make_terminal_frame): Now static.
10818 (get_frame_param): Now static, unless HAVE_NS.
10819 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10820 (x_get_resource_string): Remove; not used.
10821 * frame.h (make_terminal_frame, x_report_frame_params):
10822 (x_get_resource_string); Remove decls.
10823 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10824 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10825
239f9db9
PE
10826 * font.c, fontset.c: Make symbols static if they're not exported.
10827 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10828 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10829 * font.c (font_close_object): Now static.
10830 * font.h (font_close_object): Remove.
10831 * fontset.c (FONTSET_OBJLIST): Remove.
10832 (free_realized_fontset) #if-0 the body, which does nothing.
10833 (face_suitable_for_char_p): #if-0, as it's never called.
10834 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10835 * xfaces.c (face_at_string_position):
10836 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10837 since 0 is always ASCII.
10838
dfcf3579
PE
10839 * fns.c (weak_hash_tables): Now static.
10840
5045092b
PE
10841 * fileio.c: Make symbols static if they're not exported.
10842 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10843 (Vwrite_region_annotation_buffers): Now static.
10844
57a96f5c
PE
10845 * eval.c: Make symbols static if they're not exported.
10846 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10847 * lisp.h (backtrace_list): Remove decl.
10848
35f08c38
PE
10849 * emacs.c: Make symbols static if they're not exported.
10850 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10851 (fatal_error_code, fatal_error_signal_hook, standard_args):
10852 Now static.
10853 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10854 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10855 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10856 * lisp.h (fatal_error_signal_hook): Remove decl.
10857 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10858
f44bd759
PE
10859 * editfns.c: Move a (normally-unused) function to its only use.
10860 * editfns.c, lisp.h (get_operating_system_release): Remove.
10861 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10862 worth the hassle of breaking this out.
10863
b532497d
PE
10864 * xterm.c: Make symbols static if they're not exported.
10865 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10866 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10867 (x_destroy_window, x_delete_display):
10868 Now static.
10869 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10870 (x_mouse_leave): Remove; unused.
10871 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10872 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10873 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10874 Remove decls.
10875 (x_mouse_leave): Declare only if WINDOWSNT.
10876 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10877 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10878 USE_X_TOOLKIT.
10879
1675728f
PE
10880 * ftxfont.c: Make symbols static if they're not exported.
10881 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10882 HAVE_FREETYPE.
10883 * font.h (ftxfont_driver): Likewise.
10884
e4cebfca
PE
10885 * xfns.c: Make symbols static if they're not exported.
10886 (x_last_font_name, x_display_info_for_name):
10887 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10888 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10889 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10890 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10891 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10892 (last_show_tip_args): Now static.
10893 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10894 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10895 (x_screen_planes): Remove; unused.
10896 * dispextern.h (x_screen_planes): Remove decl.
10897
5bf46f05
PE
10898 * dispnew.c: Make symbols static if they're not exported.
10899 * dispextern.h (redraw_garbaged_frames, scrolling):
10900 (increment_row_positions): Remove.
10901 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10902 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10903 Now static.
10904 (redraw_garbaged_frames): Remove; unused.
10905
435f4c28
PE
10906 * xfaces.c: Make symbols static if they're not exported.
10907 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10908 Remove decls.
10909 * xterm.h (defined_color): Remove decls.
10910 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10911 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10912 (menu_face_changed_default, defined_color, free_realized_face):
10913 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10914 (ascii_face_of_lisp_face): Remove; unused.
10915
8524aef3
PE
10916 * xdisp.c: Make symbols static if they're not exported.
10917 * dispextern.h (scratch_glyph_row, window_box_edges):
10918 (glyph_to_pixel_coords, set_cursor_from_row):
10919 (get_next_display_element, set_iterator_to_next):
10920 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10921 (show_mouse_face): Remove decls
10922 * frame.h (message_buf_print): Likewise.
10923 * lisp.h (pop_message, set_message, check_point_in_composition):
10924 Likewise.
10925 * xterm.h (set_vertical_scroll_bar): Likewise.
10926 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10927 (message_buf_print, scratch_glyph_row, displayed_buffer):
10928 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10929 (get_next_display_element, show_mouse_face, window_box_edges):
10930 (frame_to_window_pixel_xy, check_point_in_composition):
10931 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10932 (glyph_to_pixel_coords): Remove; unused.
10933
16390cd2
PE
10934 * dired.c (file_name_completion): Now static.
10935
10936 * dbusbind.c (xd_in_read_queued_messages): Now static.
10937
a25f4dfa
PE
10938 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10939 * data.c (circular_list_error): Remove.
10940
14a9c8df
PE
10941 * commands.h (last_point_position, last_point_position_buffer):
10942 (last_point_position_window): Remove decls.
10943 * keyboard.c: Make these variables static.
10944
04f2d78b
CB
10945 * coding.h (coding, code_convert_region, encode_coding_gap):
10946 Remove decls.
74ab6df5
PE
10947 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10948 (iso_code_class, detect_coding, code_convert_region): Now static.
10949 (encode_coding_gap): Remove; unused.
10950
38dfbee1
PE
10951 * chartab.c (chartab_chars, chartab_bits): Now static.
10952
a2cb4e63
PE
10953 * charset.h (charset_iso_8859_1): Remove decl.
10954 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10955 Now static.
10956
127198fd
PE
10957 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10958 * ccl.c (Vccl_program_table): Now static.
10959 (check_ccl_update): Remove; unused.
10960
d85b608f
PE
10961 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10962 * category.h: ... from here.
10963 * category.c (check_category_table, set_category_set): Now static.
10964
31cd66f3
PE
10965 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10966 * lisp.h: Remove these decls.
10967
c358e587
PE
10968 * buffer.c (buffer_count): Remove unused var.
10969
e78aecca
PE
10970 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10971 so that it's not optimized away.
10972 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10973 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10974 exported only to the debugger.
10975
e192d7d3 10976 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10977 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10978
92470028
PE
10979 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10980 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10981 was inaccessible from Lisp.
10982 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10983 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10984
244ed907
PE
10985 alloc.c: Import and export fewer symbols, and remove unused items.
10986 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10987 is defined.
10988 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10989 it's not optimized away by whole-program optimization.
10990 (message_enable_multibyte, free_misc): Remove.
10991 (catchlist, handlerlist, mark_backtrace):
10992 Declare only if BYTE_MARK_STACK.
10993 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10994 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10995 (message_enable_multibyte): Remove decl.
10996 (free_misc, interval_free_list, float_block, float_block_index):
10997 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10998 (cons_free_list, last_marked_index):
10999 Now static.
11000 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11001 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11002 (mark_backtrace): Define only if BYTE_MARK_STACK.
11003 * xdisp.c (message_enable_multibyte): Now static.
11004
61c2b50e 11005 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11006 This makes it easier for human readers (and static analyzers)
11007 to see whether these variables are used from other modules.
11008 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11009 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11010 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11011 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11012 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11013 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11014 * xmenu.c, xselect.c:
11015 Declare Q* vars static if they are not used in other modules.
11016 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11017 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11018 Remove decls of unexported vars.
11019 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11020
95c82688
PE
11021 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11022
16a97296
PE
11023 Make Emacs functions such as Fatom 'static' by default.
11024 This makes it easier for human readers (and static analyzers)
11025 to see whether these functions can be called from other modules.
11026 DEFUN now defines a static function. To make the function external
11027 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11028 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11029 (Finit_image_library):
16a97296
PE
11030 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11031 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11032 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11033 Remove decls, since these functions are now static.
11034 (Funintern, Fget_internal_run_time): New decls, since these functions
11035 were already external.
95c82688 11036
16a97296
PE
11037 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11038 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11039 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11040 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11041 * keyboard.c, keymap.c, lread.c:
11042 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11043 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11044 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11045 Mark functions with DEFUE instead of DEFUN,
11046 if they are used in other modules.
11047 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11048 decls for now-static functions.
11049 * buffer.h (Fdelete_overlay): Remove decl.
11050 * callproc.c (Fgetenv_internal): Mark as internal.
11051 * composite.c (Fremove_list_of_text_properties): Remove decl.
11052 (Fcomposition_get_gstring): New forward static decl.
11053 * composite.h (Fcomposite_get_gstring): Remove decl.
11054 * dired.c (Ffile_attributes): New forward static decl.
11055 * doc.c (Fdocumntation_property): New forward static decl.
11056 * eval.c (Ffetch_bytecode): New forward static decl.
11057 (Funintern): Remove extern decl; now in .h file where it belongs.
11058 * fileio.c (Fmake_symbolic_link): New forward static decl.
11059 * image.c (Finit_image_library): New forward static decl.
11060 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11061 * intervals.h (Fprevious_property_change):
11062 (Fremove_list_of_text_properties): Remove decls.
11063 * keyboard.c (Fthis_command_keys): Remove decl.
11064 (Fcommand_execute): New forward static decl.
11065 * keymap.c (Flookup_key): New forward static decl.
11066 (Fcopy_keymap): Now static.
11067 * keymap.h (Flookup_key): Remove decl.
11068 * process.c (Fget_process): New forward static decl.
11069 (Fprocess_datagram_address): Mark as internal.
11070 * syntax.c (Fsyntax_table_p): New forward static decl.
11071 (skip_chars): Remove duplicate decl.
11072 * textprop.c (Fprevious_property_change): New forward static decl.
11073 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11074 Now internal.
11075 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11076 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11077
785bbd42
PE
11078 * editfns.c (Fformat): Remove unreachable code.
11079
8b913b57
AS
110802011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11081
11082 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11083 change. (Bug#8496)
11084
a6744a35
EZ
110852011-04-13 Eli Zaretskii <eliz@gnu.org>
11086
11087 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11088 when at ZV. (Bug#8487)
11089
e7974947
AS
110902011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11091
baad03f0
AS
11092 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11093 (Bug#8437)
11094 * keyboard.c (parse_tool_bar_item): Likewise.
11095 * sound.c (sound_cleanup, alsa_close): Likewise.
11096 * termcap.c (tgetent): Likewise.
11097 * xfns.c (x_default_font_parameter): Likewise.
11098 * xsettings.c (read_and_apply_settings): Likewise.
11099
e7974947
AS
11100 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11101 (overrun_check_free): Protoize.
11102
28272684
PE
111032011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11104
11105 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11106 since callers should never pass a negative size.
11107 Change the signature to match that of plain 'read' and 'write'; see
11108 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11109 * lisp.h: Update prototypes of emacs_write and emacs_read.
11110
11997c76
EZ
111112011-04-11 Eli Zaretskii <eliz@gnu.org>
11112
11113 * xdisp.c (redisplay_window): Don't try to determine the character
11114 position of the scroll margin if the window start point w->startp
e896f03c 11115 is outside the buffer's accessible region. (Bug#8468)
11997c76 11116
8a2cbd72
EZ
111172011-04-10 Eli Zaretskii <eliz@gnu.org>
11118
11119 Fix write-region and its subroutines for buffers > 2GB.
11120 * fileio.c (a_write, e_write): Modify declaration of arguments and
11121 local variables to support buffers larger than 2GB.
11122 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11123
11124 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11125 argument, local variables, and return value.
11126
11127 * lisp.h: Update prototypes of emacs_write and emacs_read.
11128
11129 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11130
4073e537 111312011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11132
1ebfdcb6
PE
11133 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11134
b2ded58d
PE
11135 Fix more problems found by GCC 4.6.0's static checks.
11136
7d66342c
PE
11137 * xdisp.c (vmessage): Use a better test for character truncation.
11138
bbf47d44
PE
11139 * charset.c (load_charset_map): <, not <=, for optimization,
11140 and to avoid potential problems with integer overflow.
9248994d 11141 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11142 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11143 * editfns.c (Fformat): Likewise.
1e69125e 11144 * syntax.c (skip_chars): Likewise.
3befa583 11145
e3019616
PE
11146 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11147 This also lets GCC 4.6.0 generate slightly better loop code.
11148
becfa255
PE
11149 * callint.c (Fcall_interactively): <, not <=, for optimization.
11150 (Fcall_interactively): Count the number of arguments produced,
11151 not the number of arguments given. This is simpler and lets GCC
11152 4.6.0 generate slightly better code.
11153
dae0cd48
PE
11154 * ftfont.c: Distingish more carefully between FcChar8 and char.
11155 The previous code passed unsigned char * to a functions like
11156 strlen and xstrcasecmp that expect char *, which does not
11157 conform to the C standard.
11158 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11159 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11160 char * when the C standard requires it.
11161
76032d70
PE
11162 * keyboard.c (read_char): Remove unused var.
11163
eb3f1cc8
PE
11164 * eval.c: Port to Windows vsnprintf (Bug#8435).
11165 Include <limits.h>.
11166 (SIZE_MAX): Define if the headers do not.
11167 (verror): Do not give up if vsnprintf returns a negative count.
11168 Instead, grow the buffer. This ports to Windows vsnprintf, which
11169 does not conform to C99. Problem reported by Eli Zaretskii.
11170 Also, simplify the allocation scheme, by avoiding the need for
11171 calling realloc, and removing the ALLOCATED variable.
11172
70476b54
PE
11173 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11174
12020a9e
PE
11175 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11176 But keep the doprint source code for now, as we might revamp it
11177 and use it again (Bug#8435).
ea6c7ae6
PE
11178 * lisp.h (doprnt): Remove.
11179 * Makefile.in (base_obj): Remove doprnt.o.
11180 * deps.mk (doprnt.o): Remove.
11181
5fdb398c
PE
11182 error: Print 32- and 64-bit integers portably (Bug#8435).
11183 Without this change, on typical 64-bit hosts error ("...%d...", N)
11184 was used to print both 32- and 64-bit integers N, which relied on
11185 undefined behavior.
61bdb816 11186 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11187 * lisp.h (error, verror): Mark as printf-like functions.
11188 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11189 Report overflow in size calculations when allocating printf buffer.
11190 Do not truncate output string at its first null byte.
11191 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11192 Truncate the output at a character boundary, since vsnprintf does not
11193 do that.
11194 * charset.c (check_iso_charset_parameter): Convert internal
11195 character to string before calling 'error', since %c now has the
11196 printf meaning.
11197 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11198 overflow when computing char to be passed to 'error'. Do not
11199 pass Lisp_Object to 'error'; pass the integer instead.
11200 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11201 formatted with plain %d.
11202
b189fa66
PE
11203 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11204
bff87ef0
PE
11205 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11206
7e2cac20
PE
11207 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11208
ce4d90b5
PE
11209 * xterm.c (x_catch_errors): Remove duplicate declaration.
11210
266c9547
PE
11211 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11212
79c49ad2
PE
11213 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11214
368f4090
JM
112152011-04-10 Jim Meyering <meyering@redhat.com>
11216
11217 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11218 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11219 return ssize_t not "int", and use size_t as the buffer length.
11220 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11221 * gnutls.h: Update declarations.
11222 * process.c (read_process_output): Use ssize_t, to match.
11223 (send_process): Likewise.
11224
a32d4040
CY
112252011-04-09 Chong Yidong <cyd@stupidchicken.com>
11226
11227 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11228
8546720e 112292011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11230
04f2d78b
CB
11231 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11232 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11233
8546720e
GM
11234 * xterm.c (handle_one_xevent):
11235 * xmenu.c (create_and_show_popup_menu):
11236 * xselect.c (x_decline_selection_request)
11237 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11238
0a2f5c1a 112392011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11240
11241 Fix some uses of `int' instead of EMACS_INT.
11242 * search.c (string_match_1, fast_string_match)
11243 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11244 (scan_buffer, find_next_newline_no_quit)
11245 (find_before_next_newline, search_command, Freplace_match)
11246 (Fmatch_data): Make some `int' variables be EMACS_INT.
11247
11248 * xdisp.c (display_count_lines): 3rd argument and return value now
11249 EMACS_INT. All callers changed.
11250 (pint2hrstr): Last argument is now EMACS_INT.
11251
11252 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11253 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11254 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11255 (decode_coding_utf_16, decode_coding_emacs_mule)
11256 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11257 (decode_coding_ccl, decode_coding_charset)
11258 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11259 (decode_coding_iso_2022, decode_coding_emacs_mule)
11260 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11261 <char_offset, last_offset>: Declare EMACS_INT.
11262 (encode_coding_utf_8, encode_coding_utf_16)
11263 (encode_coding_emacs_mule, encode_invocation_designation)
11264 (encode_designation_at_bol, encode_coding_iso_2022)
11265 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11266 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11267 Declare EMACS_INT.
11268 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11269 (encode_invocation_designation): Last argument P_NCHARS is now
11270 EMACS_INT.
11271 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11272 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11273
11274 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11275 All users changed.
11276
11277 * ccl.c (Fccl_execute_on_string): Declare some variables
11278 EMACS_INT.
11279
8546720e 112802011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11281
11282 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11283
4e19a977
CS
112842011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11285
11286 * process.c (Fformat_network_address): Doc fix.
11287
87302331
R
112882011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11289
ee7683eb 11290 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11291
cbb59342
CY
112922011-04-08 Chong Yidong <cyd@stupidchicken.com>
11293
11294 * keyboard.c (read_char): Call Lisp function help-form-show,
11295 instead of using internal_with_output_to_temp_buffer.
11296 (Qhelp_form_show): New var.
e0d38eeb 11297 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11298
11299 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11300
11301 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11302
e67a13ab
CY
113032011-04-06 Chong Yidong <cyd@stupidchicken.com>
11304
04f2d78b
CB
11305 * process.c (Flist_processes): Remove to Lisp.
11306 (list_processes_1): Delete.
e67a13ab 11307
973f782d
EZ
113082011-04-06 Eli Zaretskii <eliz@gnu.org>
11309
7c106b1e
EZ
11310 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11311
973f782d
EZ
11312 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11313
41cf7d1a 113142011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11315
ca23cc88
PE
11316 Fix more problems found by GCC 4.6.0's static checks.
11317
f390e2d5
PE
11318 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11319
42eea0d0
PE
11320 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11321
b69769da 11322 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11323
f9541e84
PE
11324 * xdisp.c (vmessage): Mark as a printf-like function.
11325
13841b55
PE
11326 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11327
c136c10f
PE
11328 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11329
5e2d4a30
PE
11330 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11331 printf-like functions.
11332 (tiff_load): Add casts to remove these marks before passing them
11333 to system-supplied API.
11334
583f48b9
PE
11335 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11336
b25d760e
PE
11337 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11338 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11339 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11340 directly, rather than having caller test rule sign. This avoids
11341 some unnecessary tests.
11342 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11343 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11344 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11345
bc7b6697 11346 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11347 (xfont_open): Avoid unnecessary tests.
bc7b6697 11348
27ccc379
PE
11349 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11350
dcd5c89a
PE
11351 * composite.h, composite.c (composition_gstring_put_cache):
11352 Use EMACS_INT, not int, for length.
11353
b13a45c6
PE
11354 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11355 breaking out part of COMPOSITION_DECODE_RULE.
11356 (COMPOSITION_DECODE_RULE): Use it.
11357 * composite.c (get_composition_id): Remove unused local vars,
11358 by using the new macro.
11359
1e792e4d
PE
11360 * textprop.c (set_text_properties_1): Change while to do-while,
11361 since the condition is always true at first.
11362
dc6c6455 11363 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11364 (interval_deletion_adjustment): Return unsigned value.
11365 All uses changed.
dc6c6455 11366
aba7731a
PE
11367 * process.c (list_processes_1, create_pty, read_process_output):
11368 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11369 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11370 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11371 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11372 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11373
fdfc4bf3
PE
11374 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11375
fca8fe46 11376 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11377 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11378
06a0259a 11379 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11380 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11381 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11382
e7b9e80f
PE
11383 * print.c (print_error_message): Avoid int overflow.
11384
56201685
PE
11385 * font.c (font_list_entities): Redo for clarity,
11386 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11387
78834453 11388 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11389 (font_score): Avoid potential overflow in diff calculation.
78834453 11390
0bc0b309 11391 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11392 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11393
e610eaca
PE
11394 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11395
b895abce
PE
11396 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11397 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11398 can always succeed if overflow has undefined behavior.
11399
1f1d9321 11400 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11401 (wordify): Omit three unnecessary tests.
1f1d9321 11402
c59478bc
PE
11403 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11404 All callers changed. This avoids the need for an unused var.
11405
79b73827
PE
11406 * casefiddle.c (casify_region): Remove var that is set but not used.
11407
a4db5dfe
PE
11408 * dired.c (file_name_completion): Remove var that is set but not used.
11409
43aae36e
PE
11410 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11411
2a47c44d 11412 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11413 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11414
a37c69bf
PE
11415 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11416 Check for integer overflow on size calculations.
11417
328ab8e7
PE
11418 * buffer.c (Fprevious_overlay_change): Remove var that is set
11419 but not used.
11420
e5a2a5cb
PE
11421 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11422 Remove vars that are set but not used.
8d84a6eb 11423 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11424 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11425
a60e5f68
PE
11426 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11427
f661cb61 11428 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11429 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11430
f0397f5a
PE
11431 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11432 that are set but not used.
11433
8664db06 11434 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11435 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11436
6abdaa4a
PE
11437 * xselect.c (x_get_local_selection, x_handle_property_notify):
11438 Remove vars that are set but not used.
11439
0ce7538d 11440 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11441 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11442
9ae848fc
PE
11443 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11444 Remove var that is set but not used.
0b918413
PE
11445 (scroll_bar_windows_size): Now size_t, not int.
11446 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11447 Check for overflow.
9ae848fc 11448
a5a62657
PE
11449 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11450 (map_tty_color) [!defined MSDOS]: Likewise.
11451
5c5cdd39
PE
11452 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11453
66ebf983
PE
11454 * coding.c: Remove vars that are set but not used.
11455 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11456 All callers changed.
11457 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11458 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11459 (decode_coding_charset): Remove vars that are set but not used.
11460
1be4d761
PE
11461 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11462 that is set but not used.
11463
47553fa8
PE
11464 * print.c (print_object): Remove var that is set but not used.
11465
1f7196bf 11466 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11467 The gnulib version avoids calling malloc in the usual case,
11468 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11469 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11470 * filelock.c (current_lock_owner): Likewise.
11471 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11472 * sysdep.c: Include allocator.h, careadlinkat.h.
11473 (emacs_no_realloc_allocator): New static constant.
11474 (emacs_readlink): New function.
fdb61804
PE
11475 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11476 ../lib/careadlinkat.h.
d1fdcab7 11477
f84c17c7
SM
114782011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11479
11480 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11481 first non-nil return value).
11482
ef3862ad
JD
114832011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11484
11485 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11486 if not defined (Bug#8403).
11487
376a7006
JB
114882011-04-02 Juanma Barranquero <lekktu@gmail.com>
11489
11490 * xdisp.c (display_count_lines): Remove parameter `start',
11491 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11492 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11493 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11494 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11495 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11496 and thereabouts. All callers changed.
11497 (get_per_char_metric): Remove parameter `f', unused since
11498 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11499
6ca3801d
JM
115002011-04-02 Jim Meyering <meyering@redhat.com>
11501
11502 do not dereference NULL upon failed strdup
11503 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11504 (ns_get_family): Likewise.
11505
d8e2b5ba
JB
115062011-04-02 Juanma Barranquero <lekktu@gmail.com>
11507
11508 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11509
8c74fcbd
JD
115102011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11511
11512 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11513 later (Bug#8403).
11514
7200d79c
SM
115152011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11516
03408648 11517 Add lexical binding.
7200d79c 11518
03408648
SM
11519 * window.c (Ftemp_output_buffer_show): New fun.
11520 (Fsave_window_excursion):
11521 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11522
11523 * lread.c (lisp_file_lexically_bound_p): New function.
11524 (Fload): Bind Qlexical_binding.
11525 (readevalloop): Remove `evalfun' arg.
11526 Bind Qinternal_interpreter_environment.
11527 (Feval_buffer): Bind Qlexical_binding.
11528 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11529 Mark as dynamic.
11530 (syms_of_lread): Declare `lexical-binding'.
11531
11532 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11533
11534 * keyboard.c (eval_dyn): New fun.
11535 (menu_item_eval_property): Use it.
ca105506
SM
11536
11537 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11538
03408648
SM
11539 * fns.c (concat, mapcar1): Accept byte-code-functions.
11540
11541 * eval.c (Fsetq): Handle lexical vars.
11542 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11543 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11544 (FletX, Flet): Obey lexical binding.
11545 (Fcommandp): Handle closures.
11546 (Feval): New `lexical' arg.
11547 (eval_sub): New function extracted from Feval. Use it almost
11548 everywhere where Feval was used. Look up vars in lexical env.
11549 Handle closures.
11550 (Ffunctionp): Move from subr.el.
11551 (Ffuncall): Handle closures.
11552 (apply_lambda): Remove `eval_flags'.
11553 (funcall_lambda): Handle closures and new byte-code-functions.
11554 (Fspecial_variable_p): New function.
11555 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11556 but without exporting it to Lisp.
23aba0ea 11557
23aba0ea 11558 * doc.c (Fdocumentation, store_function_docstring):
03408648 11559 * data.c (Finteractive_form): Handle closures.
23aba0ea 11560
03408648
SM
11561 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11562 interactive spec.
ba83908c 11563
04f2d78b
CB
11564 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11565 New byte-codes.
03408648
SM
11566 (exec_byte_code): New function extracted from Fbyte_code to handle new
11567 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11568
03408648 11569 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11570
03408648 11571 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11572
e2abce01
JB
115732011-03-31 Juanma Barranquero <lekktu@gmail.com>
11574
11575 * xdisp.c (redisplay_internal): Fix prototype.
11576
63696a73 115772011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11578
63696a73 11579 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11580 (try_scrolling): Use it when setting scroll_limit.
11581 Limit scrolling to 100 screen lines.
63696a73
EZ
11582 (redisplay_window): Even when falling back on "recentering",
11583 position point in the window according to scroll-conservatively,
11584 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11585
11586 (try_scrolling): When point is above the window, allow searching
11587 as far as scroll_max, or one screenful, to compute vertical
11588 distance from PT to the scroll margin position. This prevents
11589 try_scrolling from unnecessarily failing when
11590 scroll-conservatively is set to a value slightly larger than the
11591 window height. Clean up the case of PT below the margin at bottom
11592 of window: scroll_max can no longer be INT_MAX. When aggressive
11593 scrolling is in use, don't let point enter the opposite scroll
11594 margin as result of the scroll.
11595 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11596 threshold of 100 lines for never-recentering scrolling.
11597
e4cc2dfc
JB
115982011-03-31 Juanma Barranquero <lekktu@gmail.com>
11599
11600 * dispextern.h (move_it_by_lines):
11601 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11602 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11603 (message_log_check_duplicate): Remove parameters `prev_bol' and
11604 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11605 (redisplay_internal): Remove parameter `preserve_echo_area',
11606 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11607
11608 * indent.c (Fvertical_motion):
11609 * window.c (window_scroll_pixel_based, Frecenter):
11610 Don't pass `need_y_p' to `move_it_by_lines'.
11611
1c470562
SM
116122011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11613
44f230aa
SM
11614 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11615 steal a few bits to be more compact.
11616 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11617 Remove unneeded casts.
11618
1c470562
SM
11619 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11620
888adce9
ZK
116212011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11622
11623 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11624 binding" message (bug#7967).
11625
f838ed7b
PE
116262011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11627
77861b95
PE
11628 Fix more problems found by GCC 4.6.0's static checks.
11629
de6dbc14
PE
11630 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11631 Remove unused local var.
11632
f838ed7b
PE
11633 * editfns.c (Fmessage_box): Remove unused local var.
11634
792c7b2b
PE
11635 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11636 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11637 Omit unused local vars.
c499e557 11638 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11639 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11640 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11641 Omit unused local var.
11642
ba0165e1
PE
11643 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11644 Don't assume string length fits in int.
32ad8845 11645 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11646 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11647
3c59b4c9
PE
11648 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11649 instead of alloca (Bug#8344).
11650
a3eed478 11651 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11652 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11653
eb4d412d
PE
11654 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11655
1658b401
PE
11656 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11657 concerns.
11658
11659 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11660
11661 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11662
9a2c6e05
PE
11663 * keyboard.c (syms_of_keyboard): Use the same style as later
11664 in this function when indexing through an array. This also
11665 works around GCC bug 48267.
11666
03d0a109
PE
11667 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11668
44f730c8
PE
11669 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11670
fe75f926
PE
11671 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11672 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11673
ffa8c828
PE
11674 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11675 This avoids undefined behavior on integer overflow, and is a bit
11676 more convenient anyway since it is compared to a size_t variable.
11677
c5101a77
PE
11678 Variadic C functions now count arguments with size_t, not int.
11679 This avoids an unnecessary limitation on 64-bit machines, which
11680 caused (substring ...) to crash on large vectors (Bug#8344).
11681 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11682 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11683 All variadic functions and their callers changed accordingly.
c5101a77
PE
11684 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11685 * data.c (arith_driver, float_arith_driver): Likewise.
11686 * editfns.c (general_insert_function): Likewise.
11687 * eval.c (struct backtrace.nargs, interactive_p)
11688 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11689 (funcall_lambda, mark_backtrace): Likewise.
11690 * fns.c (concat): Likewise.
11691 * frame.c (x_set_frame_parameters): Likewise.
11692 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11693 0 if not found, not -1. All callers changed.
11694
dd3f25f7
PE
11695 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11696 (stack_copy_size): Now size_t, not int.
11697 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11698
461c2ab9
JB
116992011-03-28 Juanma Barranquero <lekktu@gmail.com>
11700
11701 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11702 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11703 All callers changed.
11704
11705 * lisp.h (multibyte_char_to_unibyte):
11706 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11707 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11708 * character.h (CHAR_TO_BYTE8):
11709 * cmds.c (internal_self_insert):
11710 * editfns.c (general_insert_function):
11711 * keymap.c (push_key_description):
11712 * search.c (Freplace_match):
11713 * xdisp.c (message_dolog, set_message_1): All callers changed.
11714
f6d62986
SM
117152011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11716
11717 * keyboard.c (safe_run_hook_funcall): New function.
11718 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11719 don't set the hook to nil, but remove the offending function instead.
11720 (Qcommand_hook_internal): Remove, unused.
11721 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11722 Vcommand_hook_internal.
11723
11724 * eval.c (enum run_hooks_condition): Remove.
11725 (funcall_nil, funcall_not): New functions.
11726 (run_hook_with_args): Call each function through a `funcall' argument.
11727 Remove `cond' argument, now redundant.
11728 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11729 (Frun_hook_with_args_until_failure): Adjust accordingly.
11730 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11731
1db5b1ad
JB
117322011-03-28 Juanma Barranquero <lekktu@gmail.com>
11733
11734 * dispextern.h (string_buffer_position): Remove declaration.
11735
11736 * print.c (strout): Remove parameter `multibyte', unused since
11737 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11738
11739 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11740 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11741 All callers changed.
11742
11743 * w32.c (_wsa_errlist): Use braces for struct initializers.
11744
11745 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11746 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11747 All callers changed.
11748 (string_buffer_position): Likewise. Also, make static (it's never
11749 used outside xdisp.c).
11750 (cursor_row_p): Remove parameter `w', unused since
11751 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11752 (decode_mode_spec): Remove parameter `precision', introduced during
11753 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11754 All callers changed.
11755
5ffb62aa
JD
117562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11757
11758 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11759
461c2ab9 117602011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11761
11762 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11763 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11764 (ns_update_auto_hide_menu_bar): New functions.
11765 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11766 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11767 ns_constrain_all_frames.
11768 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11769 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11770
5c380ffb
JD
117712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11772
11773 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11774
9af30bdf
GM
117752011-03-27 Glenn Morris <rgm@gnu.org>
11776
11777 * syssignal.h: Replace RETSIGTYPE with void.
11778 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11779 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11780 Replace SIGTYPE with void everywhere.
11781 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11782 * s/template.h (SIGTYPE): Remove commented out definition.
11783
e2abce01
JB
117842011-03-26 Eli Zaretskii <eliz@gnu.org>
11785
11786 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11787 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11788
f868cd8a
JB
117892011-03-26 Juanma Barranquero <lekktu@gmail.com>
11790
59eb0929
JB
11791 * w32.c (read_unc_volume): Use parameter `henum', instead of
11792 global variable `wget_enum_handle'.
11793
11794 * keymap.c (describe_vector): Remove parameters `indices' and
11795 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11796 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11797
f868cd8a
JB
11798 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11799
11800 * keyboard.c (timer_check): Remove parameter `do_it_now',
11801 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11802 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11803 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11804
11805 * keyboard.c (read_char):
11806 * w32menu.c (w32_menu_display_help):
11807 * xmenu.c (show_help_event, menu_help_callback):
11808 Adjust calls to `show_help_echo'.
11809
11810 * gtkutil.c (xg_maybe_add_timer):
11811 * keyboard.c (readable_events):
11812 * process.c (wait_reading_process_output):
11813 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11814
11815 * insdel.c (adjust_markers_gap_motion):
11816 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11817 (gap_left, gap_right): Don't call it.
11818
2ecf6fdb
CY
118192011-03-25 Chong Yidong <cyd@stupidchicken.com>
11820
11821 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11822 incurred during fontification.
11823
6b1f9ba4
JB
118242011-03-25 Juanma Barranquero <lekktu@gmail.com>
11825
11826 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11827 (DEFVAR_PER_BUFFER): Don't pass it.
11828
11829 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11830 (scrolling_window): Don't pass it.
11831
0f4a96b5
JB
118322011-03-25 Juanma Barranquero <lekktu@gmail.com>
11833
11834 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11835
11836 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11837 and `suffix'.
11838 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11839 of variables specific to SELinux and computation of `encoded_absname'.
11840
11841 * image.c (XPutPixel): Remove unused variable `height'.
11842
11843 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11844
11845 * unexw32.c (get_section_info): Remove unused variable `section'.
11846
11847 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11848 (system_process_attributes): Remove unused variable `sess'.
11849 (sys_read): Remove unused variable `err'.
11850
11851 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11852 (w32_wnd_proc): Remove unused variable `isdead'.
11853 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11854 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11855 (x_create_tip_frame): Remove unused variable `tem'.
11856
11857 * w32inevt.c (w32_console_read_socket):
11858 Remove unused variable `no_events'.
11859
11860 * w32term.c (x_draw_composite_glyph_string_foreground):
11861 Remove unused variable `width'.
11862
1149507c
JB
118632011-03-24 Juanma Barranquero <lekktu@gmail.com>
11864
11865 * w32term.c (x_set_glyph_string_clipping):
11866 Don't pass uninitialized region to CombineRgn.
11867
9c88f339
JB
118682011-03-23 Juanma Barranquero <lekktu@gmail.com>
11869
11870 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11871 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11872 (Fx_close_connection): Remove unused variable `i'.
11873
11874 * w32font.c (w32font_draw): Return number of glyphs.
11875 (w32font_open_internal): Remove unused variable `i'.
11876 (w32font_driver): Add missing initializer.
11877
11878 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11879 (fill_in_menu): Remove unused variable `items_added'.
11880
11881 * w32term.c (last_mouse_press_frame): Remove static global variable.
11882 (w32_clip_to_row): Remove unused variable `f'.
11883 (x_delete_terminal): Remove unused variable `i'.
11884
11885 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11886 (NOTHING): Remove unused static global variable.
11887 (uniscribe_check_otf): Remove unused variable `table'.
11888 (uniscribe_font_driver): Add missing initializers.
11889
dee091a3
JD
118902011-03-23 Julien Danjou <julien@danjou.info>
11891
11892 * term.c (Fsuspend_tty, Fresume_tty):
11893 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11894 * window.c (temp_output_buffer_show):
11895 * insdel.c (signal_before_change):
11896 * frame.c (Fhandle_switch_frame):
11897 * fileio.c (Fdo_auto_save):
11898 * emacs.c (Fkill_emacs):
11899 * editfns.c (save_excursion_restore):
11900 * cmds.c (internal_self_insert):
11901 * callint.c (Fcall_interactively):
11902 * buffer.c (Fkill_all_local_variables):
11903 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11904 Use Frun_hooks.
0f4a96b5 11905 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11906 unconditionally since it does the check itself.
dee091a3 11907
2c520ab5 119082011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11909
c9c49752
PE
11910 Fix more problems found by GCC 4.5.2's static checks.
11911
8abc3f12
PE
11912 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11913 the first time through the loop, since we know p0 < p1 then.
11914 This also avoids a gcc -Wstrict-overflow warning.
11915
a2d26660
PE
11916 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11917 leading to a memory leak, possible in functions like
11918 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11919 of objects (Bug#8318).
a2d26660 11920
916c72e9
PE
11921 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11922 that could (at least in theory) be that large.
11923
19ab8a18
PE
11924 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11925 This is less likely to overflow, and avoids undefined behavior if
11926 overflow does occur. All callers changed. Use strtoul to scan
11927 for the unsigned long integer.
b7cbbd6f
PE
11928 (pint2hrstr): Simplify and tune code slightly.
11929 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11930
f0641eff
PE
11931 * scroll.c (do_scrolling): Work around GCC bug 48228.
11932 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11933
7f650bb9
PE
11934 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11935 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11936 (validate_x_resource_name): Simplify count usage.
11937 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11938
37dd57d1
PE
11939 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11940 fail (Bug#8306).
81e56e61 11941
699979fc 11942 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11943
401bf9b4
PE
11944 * process.c (Fmake_network_process): Use socklen_t, not int,
11945 where POSIX says socklen_t is required in portable programs.
11946 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11947 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11948 (Fmake_network_process, server_accept_connection):
11949 (wait_reading_process_output, read_process_output):
11950 Likewise.
11951
b93aacde
PE
11952 * process.c: Rename or move locals to avoid shadowing.
11953 (list_processes_1, Fmake_network_process):
11954 (read_process_output_error_handler, exec_sentinel_error_handler):
11955 Rename or move locals.
4dc343ee 11956 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11957 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11958 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11959 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11960 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11961
af8a867c 11962 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11963 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11964 Include tparam.h instead, since it declares them.
af8a867c
PE
11965 * cm.h (PC): Remove extern decl; tparam.h now does this.
11966 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11967 * terminfo.c: Include tparam.h, to check interfaces.
11968 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11969 (tparam): Adjust signature to match interface in tparam.h;
11970 this removes some undefined behavior. Check that outstring and len
11971 are zero, which they always are with Emacs.
11972 * tparam.h (PC, BC, UP): New extern decls.
11973
0248044d 11974 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11975 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11976
8ff096c1 11977 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11978 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11979 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11980 (ftfont_list): Remove unused local.
49eaafba
PE
11981 (get_adstyle_property, ftfont_pattern_entity):
11982 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11983 Rename locals to avoid shadowing.
8ff096c1 11984
e2be39f6
PE
11985 * xfont.c (xfont_list_family): Mark var as initialized.
11986
c9735e30
PE
11987 * xml.c (make_dom): Now static.
11988
8f5201ae
PE
11989 * composite.c (composition_compute_stop_pos): Rename local to
11990 avoid shadowing.
b246f932
PE
11991 (composition_reseat_it): Remove unused locals.
11992 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11993 (composition_update_it): Mark var as initialized.
11b61122
PE
11994 (find_automatic_composition): Mark vars as initialized,
11995 with a FIXME (Bug#8290).
8f5201ae 11996
760fbc2c
PE
11997 character.h: Rename locals to avoid shadowing.
11998 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11999 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12000 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12001 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12002 to avoid shadowing.
12003
ff08eb85
PE
12004 * textprop.c (property_change_between_p): Remove; unused.
12005
fc7bf025
PE
12006 * intervals.c (interval_start_pos): Now static.
12007
235d7abc
PE
12008 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12009
44f230aa
SM
12010 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12011 Rename locals to avoid shadowing.
3e7d6594 12012
50060332
PE
12013 * sound.c (wav_play, au_play, Fplay_sound_internal):
12014 Fix pointer signedness.
d01f234b 12015 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12016 (wav_play): Initialize a variable to 0, to prevent undefined
12017 behavior (Bug#8278).
50060332 12018
c4fc4e30
PE
12019 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12020
918436ed
PE
12021 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12022
c939f91b
PE
12023 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12024 clobbering (Bug#8298).
b9c7f648
PE
12025 * sysdep.c (sys_subshell): Likewise.
12026 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12027
6bd8c144
PE
12028 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12029 This should get cleaned up, so that child_setup has the
12030 same signature on all platforms.
12031
7710357c 12032 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12033 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12034
c59da222
CY
120352011-03-22 Chong Yidong <cyd@stupidchicken.com>
12036
12037 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12038 not to be necessary, and produces flickering.
12039
66b87493
GM
120402011-03-20 Glenn Morris <rgm@gnu.org>
12041
12042 * config.in: Remove file.
12043
45b6f6d5
JB
120442011-03-20 Juanma Barranquero <lekktu@gmail.com>
12045
12046 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12047 are now in src/globals.h.
12048 (syms_of_minibuf): Remove spurious & from previous change.
12049
cd394be1 120502011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12051
12052 * minibuf.c (completing-read-function): New variable.
12053 (completing-read-default): Rename from completing-read.
12054 (completing-read): Call completing-read-function.
12055
b14e3e21
CY
120562011-03-19 Juanma Barranquero <lekktu@gmail.com>
12057
12058 * xfaces.c (Fx_load_color_file):
12059 Read color file from absolute filename (bug#8250).
12060
f2b726e6
JB
120612011-03-19 Juanma Barranquero <lekktu@gmail.com>
12062
12063 * makefile.w32-in: Update dependencies.
12064
09f6ff02
EZ
120652011-03-17 Eli Zaretskii <eliz@gnu.org>
12066
12067 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12068
29a6015a
PE
120692011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12070
a3a6c54e
PE
12071 Fix more problems found by GCC 4.5.2's static checks.
12072
b766f867
PE
12073 * process.c (make_serial_process_unwind, send_process_trap):
12074 (sigchld_handler): Now static.
12075
be02381c
PE
12076 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12077 That way, the code declares only the vars that it needs.
12078 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12079 * s/cygwin.h (PTY_ITERATION): Likewise.
12080 * s/darwin.h (PTY_ITERATION): Likewise.
12081 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12082
57048744
PE
12083 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12084 * process.c (allocate_pty): Don't declare stb unless it's needed.
12085
7914961c 12086 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12087 (CONSTANTLIM): Remove; unused.
12088 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12089 Define only if needed.
7914961c 12090
b3967b18
PE
12091 * unexelf.c (unexec): Name an expression,
12092 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12093 Use a different way to cause a compilation error if anyone uses
12094 n rather than nn, a way that does not involve shadowing.
73366a00 12095 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12096
29a6015a
PE
12097 * deps.mk (unexalpha.o): Remove; unused.
12098
43cfc33e 12099 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12100 * unexec.h: New file.
ce701a33
PE
12101 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12102 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12103 Depend on unexec.h.
12104 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12105 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12106 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12107 Change as necessary to match prototype in unexec.h.
ce701a33 12108
01f44d5a
PE
12109 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12110 shadowing.
4f63c6bb 12111 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12112
a6670b0b
PE
12113 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12114 Rename locals to avoid shadowing.
12115
cef2010d 12116 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12117 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12118
d4d7173a
PE
12119 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12120
f08b802a
PE
12121 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12122 warning when compiling print.c.
12123
3ddb0639
PE
12124 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12125 instead of using an uninitialized var.
5ad03b97 12126 (font_sort_entities): Mark var as initialized.
3ddb0639 12127
170a2692
PE
12128 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12129
e663c700
PE
12130 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12131 pointers to constants.
89bc529a 12132 (font_parse_fcname): Remove unused vars.
7b81e2d0 12133 (font_delete_unmatched): Now static.
ea838e10 12134 (font_get_spec): Remove; unused.
13a547c6
PE
12135 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12136 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12137 Rename or move locals to avoid shadowing.
e663c700 12138
2a80c887 12139 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12140 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12141
1384fa33 12142 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12143 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12144
8b2c52e9
PE
12145 * alloc.c (mark_backtrace): Move decl from here ...
12146 * lisp.h: ... to here, so that it can be checked.
12147
475545b5 12148 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12149 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12150 (lisp_indirect_variable): Name an expression,
12151 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12152 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12153
b1349114 12154 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12155 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12156 Use const pointer when appropriate.
b1349114 12157
a2928364
PE
12158 * lisp.h (get_system_name, get_operating_system_release):
12159 Move decls here, to check interfaces.
12160 * process.c (get_operating_system_release): Move decl to lisp.h.
12161 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12162 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12163 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12164 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12165 (Fformat_time_string, Fencode_time, Finsert_char):
12166 (Ftranslate_region_internal, Fformat):
12167 Rename or remove local vars to avoid shadowing.
9710023e 12168 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12169
a415e694
PE
12170 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12171 avoid shadowing.
12172
8ef4622d
PE
12173 * lisp.h (eassert): Check that the argument compiles, even if
12174 ENABLE_CHECKING is not defined.
12175
946f9a5b
PE
12176 * data.c (Findirect_variable): Name an expression, to avoid
12177 gcc -Wbad-function-cast warning.
112396d6 12178 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12179 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12180 (Fmake_variable_buffer_local, Fmake_local_variable):
12181 Mark variables as initialized.
52746918 12182 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12183
e5aab7e7 12184 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12185 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12186 Rename locals to avoid shadowing.
dff45157
PE
12187 (mark_stack): Move local variables into the #ifdef region where
12188 they're used.
7bc26fdb
PE
12189 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12190 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12191 needed otherwise.
12192 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12193 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12194 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12195
e5aab7e7
PE
12196 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12197 avoids undefined behavior in theory.
12198
4da60324
PE
12199 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12200
88043301
PE
12201 Use functions, not macros, for up- and down-casing (Bug#8254).
12202 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12203 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12204 to use the following functions instead of these macros.
12205 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12206 EMACS_INT, since callers assume the returned value fits in int.
12207 (upcase1): Likewise, for UPCASE_TABLE.
12208 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12209 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12210 the race-condition problem in the old DOWNCASE.
88043301 12211
19ed5445
PE
12212 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12213 Rename locals to avoid shadowing.
12214 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12215 (regex_compile, re_search_2, re_match_2_internal):
12216 Remove unused local vars.
952db0d7
PE
12217 (FREE_VAR): Rewrite so as not to use empty "else",
12218 which gcc can warn about.
da053e48 12219 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12220 (RETALLOC_IF): Define only if needed.
12221 (WORDCHAR_P): Likewise. This one is never needed, but is used
12222 only in a comment talking about a compiler bug, so put inside
12223 the #if 0 of that comment.
12224 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12225 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12226 Remove; unused.
19ed5445 12227
1f3561e4 12228 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12229 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12230 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12231
ded6f8f7
PE
12232 * search.c (simple_search): Remove unused var.
12233
dbd37a95
PE
12234 * dired.c (compile_pattern): Move decl from here ...
12235 * lisp.h: ... to here, so that it can be checked.
12236 (struct re_registers): New forward decl.
12237
7e47afad
PE
12238 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12239
85f24f61
PE
12240 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12241 All uses changed.
12242 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12243 Rename locals to avoid shadowing.
5671df8f 12244 (Fvertical_motion): Mark locals as initialized.
85f24f61 12245
181aa2be 12246 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12247 (casify_region): Mark local as initialized.
181aa2be 12248
930d429c
PE
12249 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12250
7082eac6
PE
12251 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12252 New macros, so that the caller can use some names other than
12253 gcpro1, gcpro2, etc.
12254 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12255 of the new macros.
12256 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12257 argument, for consistency with GCPRO2_VAR, etc: it is now the
12258 prefix of the variable, not the variable itself. All uses
12259 changed.
38b2c076
PE
12260 * dired.c (directory_files_internal, file_name_completion):
12261 Rename locals to avoid shadowing.
12262
15206ed9
PE
12263 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12264 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12265 dired.c's scmp function, had undefined behavior.
12266 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12267 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12268 * buffer.h: ... to here, because these macros use current_buffer,
12269 and the new implementation with inline functions needs to have
12270 current_buffer in scope now, rather than later when the macros
12271 are used.
12272 (downcase, upcase1): New static inline functions.
12273 (DOWNCASE, UPCASE1): Reimplement using these functions.
12274 This avoids undefined behavior in expressions like
12275 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12276 from race conditions in accessing the global variables
12277 case_temp1 and case_temp2.
12278 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12279 * lisp.h (case_temp1, case_temp2): Remove their decls.
12280 * character.h (ASCII_CHAR_P): Move from here ...
12281 * lisp.h: ... to here, so that the inline functions mentioned
12282 above can use them.
12283
4a6bea26
PE
12284 * dired.c (directory_files_internal_unwind): Now static.
12285
f14b7e14
PE
12286 * fileio.c (file_name_as_directory, directory_file_name):
12287 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12288 Now static.
2893f146
PE
12289 (file_name_as_directory): Use const pointers when appropriate.
12290 (Fexpand_file_name): Likewise. In particular, newdir might
12291 point at constant storage, so make it a const pointer.
fd4ead52 12292 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12293 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12294 signedness issues.
f839df0c
PE
12295 (Fset_file_times, Finsert_file_contents, auto_save_error):
12296 Rename locals to avoid shadowing.
f14b7e14 12297
5716756e 12298 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12299 (Ftry_completion, Fall_completions): Rename or remove locals
12300 to avoid shadowing.
5716756e 12301
b4c3046a
PE
12302 * marker.c (bytepos_to_charpos): Remove; unused.
12303
b45db522
PE
12304 * lisp.h (verify_bytepos, count_markers): New decls,
12305 so that gcc does not warn that these functions aren't declared.
12306
85876d07
PE
12307 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12308 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12309 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12310 (copy_text): Remove unused local var.
85876d07 12311
03d78a21 12312 * filelock.c (within_one_second): Now static.
b3dd38ab 12313 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12314
5df8f01b
PE
12315 * buffer.c (fix_overlays_before): Mark locals as initialized.
12316 (fix_start_end_in_overlays): Likewise. This function should be
12317 simplified by using pointers-to-pointers, but that's a different
12318 matter.
b1d876f1 12319 (switch_to_buffer_1): Now static.
8f54f30a
PE
12320 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12321 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12322
a70072c9 12323 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12324 Fix pointer signedness issue.
edced198
PE
12325 (sys_subshell): Mark local as volatile if checking for lint,
12326 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12327 (MAXPATHLEN): Define only if needed.
a70072c9 12328
a0977c44
PE
12329 * process.c (serial_open, serial_configure): Move decls from here ...
12330 * systty.h: ... to here, so that they can be checked.
12331
a884fdcc
PE
12332 * fns.c (get_random, seed_random): Move extern decls from here ...
12333 * lisp.h: ... to here, so that they can be checked.
12334
604efe86 12335 * sysdep.c (reset_io): Now static.
b8950c94 12336 (wait_for_termination_signal): Remove; unused.
604efe86 12337
38fc62d9
PE
12338 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12339 (copy_keymap_item, append_key, push_text_char_description):
12340 Now static.
1004a21a 12341 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12342 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12343 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12344 (describe_map_tree):
12345 Rename locals to avoid shadowing.
38fc62d9 12346
2f2650da
PE
12347 * keyboard.c: Declare functions static if they are not used elsewhere.
12348 (echo_char, echo_dash, cmd_error, top_level_2):
12349 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12350 (read_char, kbd_buffer_get_event, make_lispy_position):
12351 (make_lispy_event, make_lispy_movement, apply_modifiers):
12352 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12353 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12354 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12355 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12356 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12357
a053e86c 12358 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12359 (mark_kboards): Move decl here ...
12360 * alloc.c (mark_kboards): ... from here.
a053e86c 12361
4752793e
PE
12362 * lisp.h (force_auto_save_soon): New decl.
12363
74f10ca7 12364 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12365 (DEFINE_DUMMY_FUNCTION): New macro.
12366 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12367 Use it.
c03cd23f
PE
12368 (main): Add casts to avoid warnings
12369 if GCC considers string literals to be constants.
74f10ca7 12370
022e70d4
PE
12371 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12372
59d6fe83
PE
12373 * dbusbind.c: Pointer signedness fixes.
12374 (xd_signature, xd_append_arg, xd_initialize):
12375 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12376 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12377 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12378 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12379
78320123
PE
12380 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12381 if GCC considers string literals to be constants.
49cebcca 12382 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12383
35ac2a97
SM
123842011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12385
fb103ca9
SM
12386 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12387 (print_preprocess, print_object): New macro to fix last change.
12388
35ac2a97
SM
12389 * print.c (print_preprocess): Don't forget font objects.
12390
62973b41
JB
123912011-03-16 Juanma Barranquero <lekktu@gmail.com>
12392
12393 * emacs.c (USAGE3): Doc fixes.
12394
0e48bb22
AS
123952011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12396
12397 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12398 structure.
12399
7684e57b
JB
124002011-03-14 Juanma Barranquero <lekktu@gmail.com>
12401
12402 * lisp.h (VWindow_system, Qfile_name_history):
12403 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12404 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12405 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12406
12407 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12408 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12409
12410 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12411 * w32console.c (detect_input_pending, read_input_pending)
12412 (encode_terminal_code):
12413 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12414 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12415 (w32_system_caret_y, Qfile_name_history):
12416 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12417 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12418 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12419 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12420 * w32proc.c (Qlocal, report_file_error):
12421 * w32term.c (Vwindow_system, updating_frame):
12422 * w32uniscribe.c (initialized, uniscribe_font_driver):
12423 Remove unneeded extern declarations.
12424
2aa46d6c
CY
124252011-03-14 Chong Yidong <cyd@stupidchicken.com>
12426
c96bbc66 12427 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12428
cffc6f3b
CY
124292011-03-13 Chong Yidong <cyd@stupidchicken.com>
12430
12431 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12432 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12433 These macros can no longer be used for assignment.
12434
44f230aa
SM
12435 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12436 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12437 (record_buffer_markers, fetch_buffer_markers): New functions for
12438 recording and fetching special buffer markers.
12439 (set_buffer_internal_1, set_buffer_temp): Use them.
12440
12441 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12442
12443 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12444
12445 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12446 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12447
12448 * xdisp.c (hscroll_window_tree):
12449 (reconsider_clip_changes): Use PT instead of BUF_PT.
12450
d251f04b
EZ
124512011-03-13 Eli Zaretskii <eliz@gnu.org>
12452
12453 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12454 $(EMACS_ROOT)/lib/intprops.h.
12455
f0c77cd1
PE
124562011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12457
3eca4629
PE
12458 Fix more problems found by GCC 4.5.2's static checks.
12459
7c86ee98
PE
12460 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12461 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12462 (xg_free_frame_widgets): Make it clear that a local variable is
12463 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12464 (gdk_window_get_screen): Make it clear that this macro is needed
12465 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12466 (int_gtk_range_get_value): New function, which avoids a diagnostic
12467 from gcc -Wbad-function-cast.
12468 (xg_set_toolkit_scroll_bar_thumb): Use it.
12469 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12470 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12471 (get_utf8_string, xg_get_file_with_chooser):
12472 Rename locals to avoid shadowing.
12473 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12474
41729b81
PE
12475 * xgselect.c (xg_select): Remove unused var.
12476
f0c77cd1
PE
12477 * image.c (four_corners_best): Mark locals as initialized.
12478 (gif_load): Initialize transparent_p to zero (Bug#8238).
12479 Mark another local as initialized.
ec6cf4c6 12480 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12481
ce0ad53d 12482 * image.c (clear_image_cache): Now static.
d5d5a617 12483 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12484 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12485 (x_edge_detection): Remove unnecessary cast that
12486 gcc -Wbad-function-cast diagnoses.
2037898d 12487 (gif_load): Fix pointer signedness.
6ae141d6
PE
12488 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12489 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12490
33383987 124912011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12492
d32df629
PE
12493 Improve quality of tests for time stamp overflow.
12494 For example, without this patch (encode-time 0 0 0 1 1
12495 1152921504606846976) returns the obviously-bogus value (-948597
12496 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12497 reports time overflow. See
12498 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12499 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12500 * editfns.c: Include limits.h and intprops.h.
12501 (TIME_T_MIN, TIME_T_MAX): New macros.
12502 (time_overflow): Move earlier, to before first use.
12503 (hi_time, lo_time): New functions, for an accurate test for
12504 out-of-range times.
12505 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12506 (Fget_internal_run_time): Don't assume time_t fits in int.
12507 (make_time): Use list2 instead of Fcons twice.
12508 (Fdecode_time): More accurate test for out-of-range times.
12509 (check_tm_member): New function.
12510 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12511 (lisp_time_argument): Don't rely on undefined left-shift and
12512 right-shift behavior when checking for time stamp overflow.
8be6f318 12513
fe31d94c
PE
12514 * editfns.c (time_overflow): New function, refactoring common code.
12515 (Fformat_time_string, Fdecode_time, Fencode_time):
12516 (Fcurrent_time_string): Use it.
12517
8be6f318
PE
12518 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12519 * dired.c (make_time): Move to ...
12520 * editfns.c (make_time): ... here.
12521 * systime.h: Note the move.
12522
09d9db2c 125232011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12524
126bc0dc
YM
12525 * fringe.c (update_window_fringes): Remove unused variables.
12526
c47cbdfd
YM
12527 * unexmacosx.c (copy_data_segment): Also copy __got section.
12528 (Bug#8223)
12529
7ac80be9
EZ
125302011-03-12 Eli Zaretskii <eliz@gnu.org>
12531
c96bbc66 12532 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12533 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12534 Constify `char *' arguments and their references according to
12535 prototypes in tparam.h.
12536
ecb0f94d 12537 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12538
7ac80be9
EZ
12539 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12540 Adapt all references accordingly.
12541
12542 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12543
ef1fd07e
TT
125442011-03-11 Tom Tromey <tromey@redhat.com>
12545
12546 * buffer.c (syms_of_buffer): Remove obsolete comment.
12547
7ef4b50c
EZ
125482011-03-11 Eli Zaretskii <eliz@gnu.org>
12549
12550 * termhooks.h (encode_terminal_code): Declare prototype.
12551
12552 * msdos.c (encode_terminal_code): Don't declare prototype.
12553
12554 * term.c (encode_terminal_code): Now external again, used by
12555 w32console.c and msdos.c.
12556
44f230aa
SM
12557 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12558 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12559
4b1ec863 125602011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12561
1714f52b 12562 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12563
4b1ec863
PE
12564 * fringe.c (update_window_fringes): Mark locals as initialized
12565 (Bug#8227).
12566 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12567
524c7aa6
PE
12568 * alloc.c (mark_fringe_data): Move decl from here ...
12569 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12570 to check its interface.
12571 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12572
a5c0af81 12573 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12574 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12575 (fontset_font): Mark local as initialized.
a9a06e0b 12576 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12577
b4716021
PE
12578 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12579
811e9bac 12580 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12581 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12582 (x_own_selection, Fx_disown_selection_internal): Rename locals
12583 to avoid shadowing.
12584 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12585
7e3ab302
PE
12586 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12587 so that the caller can use some name other than gcpro1.
12588 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12589 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12590 (Fx_backspace_delete_keys_p):
12591 Use them to avoid shadowing, and rename vars to avoid shadowing.
12592 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12593 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12594 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12595 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12596 Remove unused locals.
7e3ab302
PE
12597 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12598 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12599 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12600 macros.
f78faa98 12601
e2b13473
PE
12602 * xterm.h (x_mouse_leave): New decl.
12603
77f23912
PE
12604 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12605 Remove unused functions.
cdf4ba58
PE
12606 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12607 (x_calc_absolute_position): Now static.
7411c686 12608 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12609 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12610 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12611 unless they are used.
38d0b34a
PE
12612 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12613 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12614 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12615 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12616 (x_error_catcher, x_connection_closed, x_error_handler):
12617 (x_error_quitter, xembed_send_message, x_iconify_frame):
12618 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12619 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12620 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12621
44f230aa
SM
12622 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12623 Rename or move locals to avoid shadowing.
6b463e58 12624 (tty_defined_color, merge_face_heights): Now static.
5967d051 12625 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12626 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12627 does not deduce is never used uninitialized.
73719eba
PE
12628 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12629 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12630
426994c3 12631 * terminal.c (store_terminal_param): Now static.
5489860b 12632
032f1620 12633 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12634 (set_frame_menubar): Remove unused local.
d4323972 12635 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12636 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12637 since they might point to immutable storage.
281585b0
PE
12638 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12639 since it's unused otherwise.
032f1620 12640
367c19e5 12641 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12642 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12643 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12644 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12645 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12646 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12647 does not deduce are never used uninitialized.
70739cbe 12648
07b48fa9
PE
12649 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12650
8868a238 12651 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12652 * window.c (window_loop, size_window):
12653 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12654
7e5cf297 12655 * window.c (display_buffer): Now static.
d6550a9f
PE
12656 (size_window): Mark variables that gcc -Wuninitialized
12657 does not deduce are never used uninitialized.
a586633d
PE
12658 * window.h (check_all_windows): New decl, to forestall
12659 gcc -Wmissing-prototypes diagnostic.
5b555da1 12660 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12661
f6095868
PE
12662 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12663 shadowing.
12664 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12665 Include <limits.h>.
12666 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12667 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12668 (load_charset_map): Mark variables that gcc -Wuninitialized
12669 does not deduce are never used uninitialized.
53df7c11 12670 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12671
f38b440c
PE
12672 * coding.c (coding_set_source, coding_set_destination):
12673 Use "else { /* comment */ }" rather than "else /* comment */;"
12674 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12675 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12676 a block, when the outer 'i' will do.
12677 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12678 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12679 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12680 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12681 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12682 Rename locals to avoid shadowing.
12683 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12684 * coding.c (emacs_mule_char, encode_invocation_designation):
12685 Now static, since they're not used elsewhere.
413bb2db 12686 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12687 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12688 (decode_coding_emacs_mule): Mark variables that gcc
12689 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12690 (detect_coding_iso_2022): Initialize a local variable that might
12691 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12692 this initialization is needed. (Bug#8211)
5f58e762
PE
12693 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12694 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12695 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12696 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12697 Remove unused macros.
f38b440c 12698
232b38b9 12699 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12700 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12701 * character.c (string_count_byte8): Likewise.
232b38b9 12702
fb90da1b
PE
12703 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12704 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12705
fb93dbc2
PE
12706 * chartab.c (copy_sub_char_table): Now static, since it's not used
12707 elsewhere.
5c156ace
PE
12708 (sub_char_table_ref_and_range, char_table_ref_and_range):
12709 Rename locals to avoid shadowing.
bbcd0949 12710 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12711
7d3b3862 12712 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12713 (BIDI_BOB): Remove unused macro.
7d3b3862 12714
6be7d3da
PE
12715 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12716 deduce are never used uninitialized.
c2ed9c8b 12717 * term.c (encode_terminal_code): Likewise.
6be7d3da 12718
75f8807f 12719 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12720
50938595
PE
12721 * tparam.h: New file.
12722 * term.c, tparam.h: Include it.
12723 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12724 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12725 Move these decls to tparam.h, and make them agree with what
12726 is actually in tparam.c. The previous trick of using incompatible
12727 decls in different modules does not conform to the C standard.
12728 All callers of tparam changed to use tparam's actual API.
12729 * tparam.c (tparam1, tparam, tgoto):
12730 Use const pointers where appropriate.
12731
fbceeba2
PE
12732 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12733 * cm.h (struct cm): Likewise.
12734 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12735 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12736 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12737 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12738 (turn_on_face, init_tty): Likewise.
12739 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12740
7f3f1250
PE
12741 * term.c (term_mouse_position): Rename local to avoid shadowing.
12742
e6ca6543
PE
12743 * alloc.c (mark_ttys): Move decl from here ...
12744 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12745
c40f8d15
AS
127462011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12747
12748 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12749
cfe0661d
JB
127502011-03-09 Juanma Barranquero <lekktu@gmail.com>
12751
12752 * search.c (compile_pattern_1): Remove argument regp, unused since
12753 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12754 (compile_pattern): Don't pass it.
12755
0afb4571
J
127562011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12757
12758 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12759 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12760 for ! HAVE_GTK3.
12761 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12762
12763 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12764
12765 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12766 gdk_window_get_screen, gdk_window_get_geometry,
12767 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12768 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12769 (xg_get_pixbuf_from_pixmap): New function.
12770 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12771 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12772 Call xg_get_pixbuf_from_pixmap instead of
12773 gdk_pixbuf_get_from_drawable.
12774 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12775 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12776 (xg_check_special_colors): Use GtkStyleContext and its functions
12777 for HAVE_GTK3.
12778 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12779 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12780 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12781 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12782 Call gtk_widget_get_preferred_size.
0afb4571
J
12783 (xg_frame_resized): gdk_window_get_geometry only takes 5
12784 parameters.
44f230aa
SM
12785 (xg_win_to_widget, xg_event_is_for_menubar):
12786 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12787 (xg_set_widget_bg): New function.
12788 (delete_cb): New function.
895009e1 12789 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12790 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12791 (xg_set_background_color): Call xg_set_widget_bg.
12792 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12793 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12794 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12795 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12796 if ! HAVE_GTK3.
12797 (update_frame_tool_bar): Call gtk_widget_hide.
12798 (xg_initialize): Use GDK_KEY_g.
12799
12800 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12801 if ! HAVE_GTK3
12802 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12803
12804 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12805 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12806 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12807
1c2cc4ef
JB
128082011-03-08 Juanma Barranquero <lekktu@gmail.com>
12809
12810 * w32xfns.c (select_palette): Check success of RealizePalette against
12811 GDI_ERROR, not zero.
12812
33383987 12813See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12814
12815;; Local Variables:
12816;; coding: utf-8
aac0c6e3
MR
12817;; End:
12818
2f097256 12819 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12820
12821 This file is part of GNU Emacs.
12822
12823 GNU Emacs is free software: you can redistribute it and/or modify
12824 it under the terms of the GNU General Public License as published by
12825 the Free Software Foundation, either version 3 of the License, or
12826 (at your option) any later version.
12827
12828 GNU Emacs is distributed in the hope that it will be useful,
12829 but WITHOUT ANY WARRANTY; without even the implied warranty of
12830 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12831 GNU General Public License for more details.
12832
12833 You should have received a copy of the GNU General Public License
12834 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.