* lisp/help-mode.el (help-mode): Restore autoload.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c8199d0f
PE
12011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2
3 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4 Without this fix, the command to link temacs failed due to an
5 undefined symbol __builtin_isnan. This is because
6 /usr/include/iso/math_c99.h #defines isnan(x) to
7 __builtin_isnan(x), but the bundled gcc, which identifies itself
8 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
9 a __builtin_isnan.
10 * floatfns.c (isnan): #undef, and then #define to a clone of
11 what's in data.c.
12 (Fisnan): Always define, since it's always available now.
13 (syms_of_floatfns): Always define isnan at the Lisp level.
14
e39b275c 152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
16
17 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
18
b2db44d9 192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 20
f4af5137 21 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
22 The previous code assumed that file offsets (off_t values) fit in
23 EMACS_INT variables, which is not true on typical 32-bit hosts.
24 The code messed up by falsely reporting buffer overflow in cases
25 such as (insert-file-contents "big" nil 1 2) into an empty buffer
26 when "big" contains more than 2**29 bytes, even though this
27 inserts just one byte and does not overflow the buffer.
28 (Finsert_file_contents): Store file offsets as off_t
29 values, not as EMACS_INT values. Check for overflow when
30 converting between EMACS_INT and off_t. When checking for
31 buffer overflow or for overlap, take the offsets into account.
32 Don't use EMACS_INT for small values where int suffices.
33 When checking for overlap, fix a typo: ZV was used where
34 ZV_BYTE was intended.
35 (Fwrite_region): Don't assume off_t fits into 'long'.
36 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
37
ecfc0a49
MA
382011-09-05 Michael Albinus <michael.albinus@gmx.de>
39
40 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
41
6511acf2 422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 43
0999621a 44 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
45
46 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 47 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
48 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
49 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
50 (modify_event_symbol): Do not assume that the length of
51 name_alist_or_stem is safe to alloca and fits in int.
52 (Fexecute_extended_command): Likewise for function name and binding.
53 (Frecursion_depth): Wrap around reliably on integer overflow.
54 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
55 since some callers pass EMACS_INT values.
56 (Fsingle_key_description): Don't crash if symbol name contains more
57 than MAX_ALLOCA bytes.
58 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
59 (get_minibuffer): Arg is now EMACS_INT, not int.
60 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 61 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
62 * window.h (command_loop_level, minibuf_level): Reflect API changes.
63
2be7d702
PE
64 * dbusbind.c (signature_cat): New function.
65 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
66 Do not overrun buffer; instead, report string overflow.
67
9d1df220
PE
68 * dispnew.c (add_window_display_history): Don't overrun buffer.
69 Truncate instead; this is OK since it's just a log.
70
33ef5c64
PE
71 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
72 even if the time zone offset is outlandishly large.
73 Don't mishandle offset == INT_MIN.
74
66c6fdd5
PE
75 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
76 when creating daemon; the previous buffer-overflow check was incorrect.
77
d749b01b
PE
78 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
79 which has the guts of the old verror function.
80
b5cd1905
PE
81 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
82 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
83
6e1a67fb
PE
84 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
85 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 86 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 87 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
88 length of string rather than counting it via multiple sprintfs;
89 that's simpler and more reliable.
c21721cc
PE
90 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
91 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
92 sprintf, in case result does not fit in int.
93
c57b67fc
PE
94 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
95 (fontset_from_font): Print it.
96
8a401434
PE
97 * frame.c (tty_frame_count): Now printmax_t, not int.
98 (make_terminal_frame, set_term_frame_name): Print it.
99 (x_report_frame_params): In X, window IDs are unsigned long,
100 not signed long, so print them as unsigned.
101 (validate_x_resource_name): Check for implausibly long names,
102 and don't assume name length fits in 'int'.
103 (x_get_resource_string): Don't blindly alloca invocation name;
104 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
105 not fit in int.
106
6e1a67fb
PE
107 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
108 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
109 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
110
0df02bf3
PE
111 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
112 Use esprintf, not sprintf, in case result does not fit in int.
113
48e30793
PE
114 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
115 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
116 it as a large positive number.
117 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
118 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
119
a66ff6d8
PE
120 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
121 in case result does not fit in int.
122
aca216ff
PE
123 * print.c (float_to_string): Detect width overflow more reliably.
124 (print_object): Make sprintf buffer a bit bigger, to avoid potential
125 buffer overrun. Don't assume list length fits in 'int'. Treat
126 print length of 0 as 0, not as infinity; to be consistent with other
127 uses of print length in this function. Don't overflow print length
128 index. Don't assume hash table size fits in 'long', or that
129 vectorlike size fits in 'unsigned long'.
130
31c286f7
PE
131 * process.c (make_process): Use printmax_t, not int, to format
132 process-name gensyms.
133
55e5faa1
PE
134 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
135
80f2e268
PE
136 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
137 to avoid potential buffer overrun.
138
670741ab
PE
139 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
140 if X resource line is longer than 512 bytes.
141
b7163a50
PE
142 * xfns.c (x_window): Make sprintf buffer a bit bigger
143 to avoid potential buffer overrun.
144
ae58ff1f
PE
145 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
146
c43c8a6a
PE
147 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
148
3f8236f4
PE
1492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
150
53e9fe90 151 Integer overflow fixes for scrolling, etc.
6511acf2
PE
152 Without these, Emacs silently mishandles large integers sometimes.
153 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
154 it were "C-u 1 M-x recenter" on a typical 64-bit host.
155
6511acf2
PE
156 * xdisp.c (try_window_id): Check Emacs fixnum range before
157 converting to 'int'.
806add1d 158
6511acf2 159 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
160 Check that an Emacs fixnum is in range before assigning it to 'int'.
161 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
162 values converted from Emacs fixnums.
163 (Frecenter): Don't wrap around a line count if it is out of 'int'
164 range; instead, treat it as an extreme value.
165 (Fset_window_configuration, compare_window_configurations):
166 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
167
6511acf2
PE
168 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
169 that can exceed INT_MAX. Check that EMACS_INT value is in range
170 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
171 (match_limit): Don't assume that a fixnum can fit in 'int'.
172
6511acf2 173 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
174 exceed INT_MAX.
175
6511acf2 176 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
177 (Fvertical_motion): Don't wrap around LINES values that don't fit
178 in 'int'. Instead, treat them as extreme values. This is good
179 enough for windows, which can't have more than INT_MAX lines anyway.
180
fcb901a7
LMI
1812011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
182
0f2f6b6d
LMI
183 * Require libxml/parser.h to avoid compilation warning.
184
fcb901a7
LMI
185 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
186
187 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
188 since this reportedly can destroy thread storage.
189
6e20a0d4
CY
1902011-08-30 Chong Yidong <cyd@stupidchicken.com>
191
192 * syntax.c (find_defun_start): Update all cache variables if
193 exiting early (Bug#9401).
194
148ae00e
EZ
1952011-08-30 Eli Zaretskii <eliz@gnu.org>
196
f6cfbd8f
EZ
197 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
198
148ae00e
EZ
199 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
200 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
201 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
202
203 * term.c (tty_append_glyph): New function.
204 (produce_stretch_glyph): Static function and its prototype deleted.
205
206 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
207 prototypes.
208
c4a07a4c
PE
2092011-08-29 Paul Eggert <eggert@cs.ucla.edu>
210
211 * image.c (parse_image_spec): Check for nonnegative, not for positive,
212 when checking :margin (Bug#9390).
213 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
214 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
215 so that the name doesn't mislead. All uses changed.
216
6bc8cd65
JB
2172011-08-28 Johan Bockgård <bojohan@gnu.org>
218
219 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
220 set_tty_hooks.
221
dca4927e
EZ
2222011-08-27 Eli Zaretskii <eliz@gnu.org>
223
224 * xdisp.c (move_it_to): Don't bail out early when reaching
225 position beyond to_charpos, if we are scanning backwards.
226 (move_it_vertically_backward): When DY == 0, make sure we get to
227 the first character in the line after the newline.
228
f2cad773
PE
2292011-08-27 Paul Eggert <eggert@cs.ucla.edu>
230
231 * ccl.c: Improve and simplify overflow checking (Bug#9196).
232 (ccl_driver): Do not generate an out-of-range pointer.
233 (Fccl_execute_on_string): Remove unnecessary check for
234 integer overflow, noted by Stefan Monnier in
235 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
236 Remove a FIXME that didn't need fixing.
237 Simplify the newly-introduced buffer reallocation code.
238
0cae2cdb
JB
2392011-08-27 Juanma Barranquero <lekktu@gmail.com>
240
241 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
242
5fc295a4 2432011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 244
70c60eb2 245 Integer and memory overflow issues (Bug#9196).
726e0ab1 246
d31850da
PE
247 * doc.c (get_doc_string): Rework so that
248 get_doc_string_buffer_size is the actual buffer size, rather than
249 being 1 less than the actual buffer size; this makes xpalloc more
250 convenient.
251
a69fbedb
PE
252 * image.c (x_allocate_bitmap_record, cache_image):
253 * xselect.c (Fx_register_dnd_atom):
254 Simplify previous changes by using xpalloc.
255
fe5c5d37
PE
256 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
257 since either will do and ptrdiff_t is convenient with xpalloc.
258
0065d054
PE
259 * charset.c (charset_table_size)
260 (struct charset_sort_data.priority): Now ptrdiff_t.
261 (charset_compare): Don't overflow if priorities differ greatly.
262 (Fsort_charsets): Don't assume list length fits in int.
263 Check for size-calculation overflow when allocating sort data.
264 (syms_of_charset): Allocate an initial charset table that is
265 just under 64 KiB, to avoid problems with glibc malloc and mmap.
266
267 * cmds.c (internal_self_insert): Check for size-calculation overflow.
268
269 * composite.h (struct composition.glyph_len): Now int, not unsigned.
270 The actual value is always <= INT_MAX, and leaving it unsigned made
271 overflow checking harder.
272
273 * dispextern.h (struct glyph_matrix.rows_allocated)
274 (struct face_cache.size): Now ptrdiff_t, for convenience in use
275 with xpalloc. The values are still always <= INT_MAX.
276
277 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
278
279 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
280 (SAFE_NALLOCA): New macro.
281
282 * region-cache.c (struct boundary.pos, find_cache_boundary)
283 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
284 (set_cache_region, invalidate_region_cache)
285 (revalidate_region_cache, know_region_cache, region_cache_forward)
286 (region_cache_backward, pp_cache):
287 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
288 so that ptrdiff_t * can be passed to xpalloc.
289 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
290 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
291 (pp_cache): Don't assume cache_len fits in int.
292 * region-cache.h: Adjust extern decls to match.
293
294 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
295 EMACS_INT, since either will do, for xpalloc.
296
297 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
298 (xnmalloc, xnrealloc, xpalloc): New functions.
299
726e0ab1
PE
300 * bidi.c (bidi_shelve_header_size): New constant.
301 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
302 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
303
51f30bc5 304 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
305 * buffer.c (overlays_at, overlays_in, record_overlay_string)
306 (overlay_strings):
307 Don't update size of array until after memory allocation succeeds,
308 because xmalloc/xrealloc may not return.
0065d054
PE
309 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
310 now that we have proper integer overflow checking.
311 (record_overlay_string, overlay_strings): Catch overflows when
312 calculating size of overlay_str_buf.
726e0ab1 313
0065d054
PE
314 * callproc.c (Fcall_process): Check for size overflow when
315 calculating size of args2.
316 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
317 Normally we prefer signed values, but sticking with ptrdiff_t would
318 require adding more-complicated checks.
726e0ab1
PE
319
320 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
321 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
322 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 323 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
324
325 * character.c (Fstring): Check for size-calculation overflow.
326
327 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
328 unnecessary integer overflow. Check for size overflow.
329 (encode_coding_object): Don't update size until xmalloc succeeds.
330
331 * composite.c (get_composition_id): Check for overflow in glyph
332 length calculations.
333
334 Integer and memory overflow fixes for display code.
335 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
336 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
337 (scrolling_window): Check for overflow in size calculations.
338 (line_draw_cost, realloc_glyph_pool, add_row_entry):
339 Don't assume glyph table len fits in int.
340 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
341 (row_table_size): Now ptrdiff_t, not int.
342 (scrolling_window): Avoid overflow in size calculations.
343 Don't update size until allocation succeeds.
344 * fns.c (concat): Check for overflow in size calculations.
345 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
346 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
347 (NEXT_ALMOST_PRIME_LIMIT): New constant.
348
349 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
350 (get_doc_string): Check for size calculation overflow.
351 Don't update size until allocation succeeds.
352 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
353 EMACS_INT, where ptrdiff_t will do.
354 (Fsubstitute_command_keys): Check for string overflow.
355
356 * editfns.c (set_time_zone_rule): Don't assume environment length
357 fits in int.
358 (message_length): Now ptrdiff_t, not int.
359 (Fmessage_box): Don't update size until allocation succeeds.
360 Don't assume message length fits in int.
361 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
362
0065d054
PE
363 * emacs.c (main): Do not reallocate argv, since there is a null at
364 the end that can be overwritten, and this way there's no need to
365 worry about size-calculation overflow.
366 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
367
368 * eval.c (init_eval_once, grow_specpdl): Don't update size until
369 alloc succeeds.
370 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
371
372 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
373 (x_set_scroll_bar_width, x_figure_window_size):
374 Check for integer overflow.
375 (x_set_alpha): Do not assume XINT fits in int.
376
377 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
378 This is for the members text_lines, text_cols, total_lines, total_cols,
379 where the system imposes an 'int' limit.
380
381 * fringe.c (Fdefine_fringe_bitmap):
382 Don't update size until alloc works.
383
384 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
385 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
386
387 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
388 Check for size-calculation overflow.
389 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
390 do, as we prefer signed integers.
391 (id_to_widget.max_size, id_to_widget.used)
392 (xg_store_widget_in_map, xg_remove_widget_from_map)
393 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
394 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
395 Use and return ptrdiff_t, not int.
396 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
397 * gtkutil.h: Change prototypes to match the above.
398
399 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
400 are duplicate now that they've been promoted to lisp.h.
401 (x_allocate_bitmap_record, x_alloc_image_color)
402 (make_image_cache, cache_image, xpm_load):
403 Don't update size until alloc is done.
404 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
405 (x_detect_edges):
3256efce 406 Check for size calculation overflow.
726e0ab1
PE
407 (ct_colors_allocated_max): New constant.
408 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
409 overflow.
3256efce 410
726e0ab1
PE
411 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
412 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
413 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
414 Use ptrdiff_t, not int, to count maps.
415 (read_char_minibuf_menu_prompt): Check for overflow in size
416 calculations. Don't update size until allocation succeeds. Redo
417 calculations to avoid overflow.
418 * keyboard.h: Change prototypes to match the above.
419
420 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
421 to count maps.
422 (current_minor_maps): Check for size calculation overflow.
423 * keymap.h: Change prototypes to match the above.
424
425 * lread.c (read1, init_obarray): Don't update size until alloc done.
426
427 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
428 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
429
726e0ab1
PE
430 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
431 Now ptrdiff_t, not int.
432 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
433 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
434
435 * process.c (Fnetwork_interface_list): Check for overflow
436 in size calculation.
437
438 * region-cache.c (move_cache_gap): Check for size calculation overflow.
439
440 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
441 overflow. Don't bother calling xmalloc when xrealloc will do.
442
443 * search.c (Freplace_match): Check for size calculation overflow.
444 (Fset_match_data): Don't assume list lengths fit in 'int'.
445
446 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
447 for command line length. Do not attempt to address one before the
448 beginning of an array, as that's not portable.
449
450 * term.c (max_frame_lines): Remove; unused.
451 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
452 not int.
453 (encode_terminal_code, calculate_costs): Check for size
454 calculation overflow.
455 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
456 table lengths and related sizes. Don't update size until alloc
457 done. Redo calculations to avoid overflow.
458 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
459
460 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
461 subtracting pointers.
462 (gobble_line): Check for overflow more carefully. Don't update size
463 until alloc done.
464
465 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
466 Don't update size until alloc done.
467 Redo size calculations to avoid overflow.
468 Check for size calculation overflow.
0065d054 469 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
470
471 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
472 Use ptrdiff_t, not int, for sizes.
473 (store_mode_line_noprop_char): Don't update size until alloc done.
474
0065d054
PE
475 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
476 Use ptrdiff_t, not int, for sizes.
477 (Finternal_make_lisp_face, cache_face):
478 Check for size calculation overflow.
479 (cache_face): Treat size calculation overflows as if they were
480 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
481
482 * xfns.c (x_encode_text, x_set_name_internal)
483 (Fx_change_window_property): Use ptrdiff_t, not int, to count
484 sizes, since they can exceed INT_MAX in size. Check for size
485 calculation overflow.
486
0065d054
PE
487 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
488 (xg_select): Check for size calculation overflow.
726e0ab1
PE
489 Don't update size until alloc done.
490
0065d054 491 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 492 as sprintf is limited to int lengths.
1d526e2f 493
252c5ee1
PE
494 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
495 (X_LONG_MIN): New macros.
864d7ce7
PE
496 Use them to make the following changes clearer.
497 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
498 This change doesn't affect the value now, but it may help remind
499 future maintainers not to raise the value too much later.
500 (SELECTION_QUANTUM): Remove, replacing with ...
501 (selection_quantum): ... new function, which avoids overflow.
502 All uses changed.
503 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
504 assumption that selection length fits in 'int'.
505 (x_reply_selection_request, x_handle_selection_request)
506 (x_get_window_property, receive_incremental_selection)
507 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
508 (lisp_data_to_selection_data, clean_local_selection_data):
509 Use ptrdiff_t, not int, to record length of selection.
510 (x_reply_selection_request, x_get_window_property)
511 (receive_incremental_selection, x_property_data_to_lisp):
512 Redo calculations to avoid overflow.
513 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 514 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
515 something.
516 (x_get_window_property, receive_incremental_selection)
517 (lisp_data_to_selection_data, x_property_data_to_lisp):
518 Check for size-calculation overflow.
519 (x_get_window_property, receive_incremental_selection)
520 (lisp_data_to_selection_data, Fx_register_dnd_atom):
521 Don't store size until memory allocation succeeds.
522 (x_get_window_property): Plug memory leak on memory exhaustion.
523 Don't double-block input; malloc is safe here. Don't assume 2**34
524 - 4 fits in unsigned long. Add an xassert to check
525 XGetWindowProperty overflow. Be more careful about overflow
526 calculations, and distinguish size from memory overflow better.
527 (receive_incremental_selection): When tracing, don't assume
528 unsigned int is less than INT_MAX.
529 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
530 harmful) conversions of unsigned short to int.
531 (lisp_data_to_selection_data): Don't assume that integers
532 in the range -65535 through -1 fit in an X unsigned short.
533 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
534 result parameters unless successful. Rely on cons_to_unsigned
535 to report problems with elements; the old code wasn't right anyway.
536 (x_check_property_data): Check for int overflow; we cannot use
537 a wider type due to X limits.
538 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
539
726e0ab1 540 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 541
0065d054
PE
542 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
543 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
544 (x_color_cells): Don't store size until memory allocation succeeds.
545 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 546 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
547 (x_term_init): Don't assume length fits in int (sprintf is limited
548 to int size).
bc18e09d 549
ebfa62c0
PE
550 Use ptrdiff_t for composition IDs.
551 * character.c (lisp_string_width):
552 * composite.c (composition_table_size, n_compositions)
553 (get_composition_id, composition_gstring_from_id):
554 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
555 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
556 * window.c (Frecenter):
557 Use ptrdiff_t, not int, for composition IDs.
558 * composite.c (get_composition_id): Check for integer overflow.
559 * composite.h: Adjust prototypes to match the above changes.
560
d3411f89
PE
561 Use ptrdiff_t for hash table indexes.
562 * category.c (hash_get_category_set):
563 * ccl.c (ccl_driver):
564 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
565 * coding.c (coding_system_charset_list, detect_coding_system):
566 * coding.h (struct coding_system.id):
567 * composite.c (get_composition_id, gstring_lookup_cache):
568 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
569 * image.c (xpm_get_color_table_h):
570 * lisp.h (hash_lookup, hash_put):
571 * minibuf.c (Ftest_completion):
572 Use ptrdiff_t for hash table indexes, not int (which is too
573 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
574 32-bit --with-wide-int hosts).
575
e097a6fa
PE
576 * charset.c (Fdefine_charset_internal): Check for integer overflow.
577 Add a FIXME comment about memory leaks.
578 (syms_of_charset): Don't assume xmalloc returns.
579
5637687f
PE
580 Don't assume that stated character widths fit in int.
581 * character.c (Fchar_width, c_string_width, lisp_string_width):
582 * character.h (CHAR_WIDTH):
583 * indent.c (MULTIBYTE_BYTES_WIDTH):
584 Use sanitize_char_width to avoid undefined and/or bad behavior
585 with outlandish widths.
586 * character.h (sanitize_tab_width): Renamed from sanitize_width,
587 now that we have two such functions. All uses changed.
588 (sanitize_char_width): New inline function.
589
a2271ba2
PE
590 Don't assume that tab-width fits in int.
591 * character.h (sanitize_width): New inline function.
592 (SANE_TAB_WIDTH): New macro.
593 (ASCII_CHAR_WIDTH): Use it.
594 * indent.c (sane_tab_width): Remove. All uses replaced by
595 SANE_TAB_WIDTH (current_buffer).
596 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
597
18c52557
PE
598 * fileio.c: Integer overflow issues with file modes.
599 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
600
caeeedc1
PE
601 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
602 Remove unreachable code.
603 (read_hex, load_charset_map_from_file): Check for integer overflow.
604
50849c52
PE
605 * xterm.c: don't go over XClientMessageEvent limit
606 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
607 (x_send_scroll_bar_event): Likewise. Check that the size does not
608 exceed limits imposed by XClientMessageEvent, as well as the usual
609 ptrdiff_t and size_t limits.
610
b13995db
PE
611 * keyboard.c: Overflow, signedness and related fixes.
612 (make_lispy_movement): Use same integer type in forward decl
613 that is used in the definition.
614 (read_key_sequence, keyremap_step):
615 Change bufsize argument back to int, undoing my 2011-03-30 change.
616 We prefer signed types, and int is wide enough here.
617 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
618 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
619 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
620 length, not size_t. Use ptrdiff_t for index, not int.
621 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
622 possibility of integer overflow.
623
13464394
PE
624 Overflow, signedness and related fixes for images.
625
626 * dispextern.h (struct it.stack[0].u.image.image_id)
627 (struct_it.image_id, struct image.id, struct image_cache.size)
628 (struct image_cache.used, struct image_cache.ref_count):
629 * gtkutil.c (update_frame_tool_bar):
630 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
631 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
632 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
633 * nsmenu.m (update_frame_tool_bar):
634 * xdisp.c (calc_pixel_width_or_height):
635 * xfns.c (image_cache_refcount):
636 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
637 on typical 64-bit hosts.
638
639 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
640 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
641 Omit unnecessary casts to int.
642 (parse_image_spec): Check that integers fall into 'int' range
643 when the callers expect that.
644 (image_ascent): Redo ascent calculation to avoid int overflow.
645 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
646 (lookup_image): Remove unnecessary tests.
647 (xbm_image_p): Locals are now of int, not EMACS_INT,
648 since parse_image_check makes sure they fit into int.
649 (png_load, gif_load, svg_load_image):
650 Prefer int to unsigned where either will do.
651 (tiff_handler): New function, combining the cores of the
652 old tiff_error_handler and tiff_warning_handler. This
653 function is rewritten to use vsnprintf and thereby avoid
654 stack buffer overflows. It uses only the features of vsnprintf
655 that are common to both POSIX and native Microsoft.
656 (tiff_error_handler, tiff_warning_handler): Use it.
657 (tiff_load, gif_load, imagemagick_load_image):
658 Don't assume :index value fits in 'int'.
659 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
660 (imagemagick_load_image): Check that crop parameters fit into
661 the integer types that MagickCropImage accepts. Don't assume
662 Vimagemagick_render_type has a nonnegative value. Don't assume
663 size_t fits in 'long'.
664 (gs_load): Use printmax_t to print the widest integers possible.
665 Check for integer overflow when computing image height and width.
666
c11821d4
EZ
6672011-08-26 Eli Zaretskii <eliz@gnu.org>
668
669 * xdisp.c (redisplay_window): Don't force window start if point
670 will be invisible in the resulting window. (Bug#9324)
671
0c95fcf7
EZ
6722011-08-25 Eli Zaretskii <eliz@gnu.org>
673
674 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
675 the display spec is of the form `(space ...)'.
676 (handle_display_spec): Return the value returned by
677 handle_single_display_spec, not just 1 or zero.
678 (handle_single_display_spec): If the display spec is of the form
679 `(space ...)', and specifies display in the text area, return 2
680 rather than 1.
fee65a97 681 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
682 accurately, and prefer exact match for point under bidi. Don't
683 advance `row' beyond the last row of the window.
0c95fcf7
EZ
684
685 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
686 into disp_prop; all users changed.
687
688 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
689 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
690 for the text covered by the display property.
691
e4ed06f1
CY
6922011-08-25 Chong Yidong <cyd@stupidchicken.com>
693
694 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
695 Change return value to nil.
696 (Frecord_buffer): Delete unused function.
697
f67cdd7f
EZ
6982011-08-24 Eli Zaretskii <eliz@gnu.org>
699
5980d4c6
EZ
700 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
701 buffers, return left-to-right.
8610fe8b
EZ
702 (set_cursor_from_row): Consider candidate row a win if its glyph
703 represents a newline and point is on that newline. Fixes cursor
704 positioning on the newline at EOL of R2L text within L2R
705 paragraph, and vice versa.
706 (try_cursor_movement): Check continued rows, in addition to
707 continuation rows. Fixes unwarranted scroll when point enters a
708 continued line of R2L text within an L2R paragraph, or vice versa.
709 (cursor_row_p): Consider the case of point being equal to
710 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
711 from the end of a short line to the beginning of a continued line
712 of R2L text within L2R paragraph.
713 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
714 composed characters.
5980d4c6 715
f67cdd7f
EZ
716 * bidi.c (bidi_check_type): Use xassert.
717 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
718 members.
719
bca633fb
EZ
7202011-08-23 Eli Zaretskii <eliz@gnu.org>
721
722 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
723 a character.
724
4a5885a7
CY
7252011-08-23 Chong Yidong <cyd@stupidchicken.com>
726
727 * nsfont.m (ns_otf_to_script): Fix typo.
728
0902a04e
KH
7292011-08-22 Kenichi Handa <handa@m17n.org>
730
731 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
732 extra slot even if the purpose is char-code-property-table.
733
1a2e6670
EZ
7342011-08-23 Eli Zaretskii <eliz@gnu.org>
735
8ddde651
EZ
736 * xdisp.c (redisplay_window): When computing centering_position,
737 account for the height of the header line. (Bug#8874)
738
425cc014
EZ
739 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
740 instead of CHAR_TO_BYTE. Fixes a crash when a completion
741 candidate is selected by the mouse, and that candidate has a
742 composed character under the mouse.
743
1a2e6670
EZ
744 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
745 coordinates reported by pos-visible-in-window-p for a composed
746 character in column zero.
747
8b76d6f8
SM
7482011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
749
750 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
751
dac347dd
EZ
7522011-08-22 Eli Zaretskii <eliz@gnu.org>
753
754 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
755 consider it a hit if to_charpos is anywhere in the range of the
756 composed buffer positions.
757
e013fb34
CY
7582011-08-22 Chong Yidong <cyd@stupidchicken.com>
759
760 * image.c (gif_load): Don't assume that each subimage has the same
761 dimensions as the base image. Handle disposal method that is
762 "undefined" by the gif spec (Bug#9335).
763
bd1ba3e8
CY
7642011-08-20 Chong Yidong <cyd@stupidchicken.com>
765
766 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 767 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 768
54a1215b
EZ
7692011-08-19 Eli Zaretskii <eliz@gnu.org>
770
823564e5
EZ
771 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
772 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
773 from an Org mode buffer to a Speedbar frame.
774
54a1215b
EZ
775 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
776 a composition, take its buffer position from IT->cmp_it.charpos.
777 Fixes cursor positioning at the beginning of a line that begins
778 with a composed character.
779
9778ebcc
EZ
7802011-08-18 Eli Zaretskii <eliz@gnu.org>
781
0be6ee06
EZ
782 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
783 character bidirectional type, use STRONG_L instead. Fixes crashes
784 in a buffer produced by `describe-categories'.
785
9778ebcc
EZ
786 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
787 members before the level stack, so they would be saved and
788 restored when copying iterator state. Fixes incorrect reordering
789 around TABs covered by display properties.
790
156bffbe
AS
7912011-08-18 Andreas Schwab <schwab@linux-m68k.org>
792
793 * process.c (Fnetwork_interface_list): Correctly determine buffer
794 size.
795
72ad093b
CY
7962011-08-17 Chong Yidong <cyd@stupidchicken.com>
797
798 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
799 (internal_condition_case_2, internal_condition_case_n):
800 Remove unnecessary aborts (Bug#9081).
72ad093b 801
35774242
EZ
8022011-08-17 Eli Zaretskii <eliz@gnu.org>
803
804 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
805 has no `load' handler, try opening the file locally. (Bug#9311)
806
db76dd85
KB
8072011-08-16 Ken Brown <kbrown@cornell.edu>
808
809 * gmalloc.c: Expand comment.
810
b215eee5
EZ
8112011-08-16 Eli Zaretskii <eliz@gnu.org>
812
813 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
814 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
815
a4579d33
KB
8162011-08-16 Ken Brown <kbrown@cornell.edu>
817
818 Fix memory allocation problems in Cygwin build (Bug#9273).
819
820 * unexcw.c ( __malloc_initialized): Declare external variable.
821 (fixup_executable): Force the dumped emacs to reinitialize malloc.
822
8b76d6f8
SM
823 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
824 New variables.
a4579d33
KB
825 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
826 dumped emacs.
827 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
828 in the static heap.
829 [CYGWIN] (special_realloc): New function.
830 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
831 requests to realloc storage in the static heap.
832
3ebec551
PE
8332011-08-15 Paul Eggert <eggert@cs.ucla.edu>
834
835 * bidi.c (bidi_initialize): Remove unused local.
836
9fd8be00
EZ
8372011-08-15 Eli Zaretskii <eliz@gnu.org>
838
474a8465
EZ
839 * biditype.h: File removed.
840
841 * bidimirror.h: File removed.
842
843 * deps.mk (bidi.o): Remove biditype.h and
844 bidimirror.h.
845
846 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
847 bidimirror.h.
848
849 * dispextern.h: Fix a typo in the comment to bidi_type_t.
850
851 * chartab.c: Improve commentary for the uniprop_table API.
852
32413314
EZ
853 * bidi.c (bidi_paragraph_init): Support zero value of
854 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
855 (bidi_initialize): Use uniprop_table instead of including
856 biditype.h and bidimirror.h.
32413314 857
9fd8be00
EZ
858 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
859 coordinates of the iterator when restoring from ppos_it.
860 (Bug#9296)
861
5cf2b69b
KH
8622011-08-14 Kenichi Handa <handa@m17n.org>
863
864 * process.c (create_process): Call setup_process_coding_systems
72ad093b 865 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 866
daf17d00
EZ
8672011-08-14 Eli Zaretskii <eliz@gnu.org>
868
869 * xdisp.c (move_it_in_display_line_to): Don't invoke
870 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
871 ppos_it. Fixes vertical cursor motion when line beginning is
872 covered by an image. (Bug#9296)
873
08e3161a
JD
8742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
875
876 * nsterm.h (ns_run_ascript): Declare.
877 (NSAPP_DATA2_RUNASSCRIPT): Define.
878
879 * nsfns.m (as_script, as_result, as_status): New static variables.
880 (ns_run_ascript): New function.
881 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
882 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
883 the event loop. Get status from as_status (Bug#7276).
884
885 * nsterm.m (sendEvent): If event is NSApplicationDefined and
886 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
887 the event loop (Bug#7276).
888
a3720aa2
AS
8892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
890
891 * gnutls.c (QCgnutls_bootprop_priority)
892 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
893 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
894 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
895 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
896 (QCgnutls_bootprop_verify_hostname_error)
897 (QCgnutls_bootprop_callbacks_verify): Rename from
898 Qgnutls_bootprop_..., all uses changed.
899
900 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
901 uses changed.
902
0a0d27fb
PE
9032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
904
19d5c50c
PE
905 * xfaces.c (Qframe_set_background_mode): Now static.
906 * dispextern.h (Qframe_set_background_mode): Remove decl.
907
0a0d27fb
PE
908 * process.c (Fnetwork_interface_info): Declare local only if needed.
909
377538cb
JD
9102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
911
912 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
913 (Fnetwork_interface_list): Allocate in increments of bytes instead
914 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
915 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
916 sockaddr.
917 (struct ifflag_def): notrailers is smart on OSX.
918 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
919 Get hardware address with getifaddrs if available.
920
08fff70c
EZ
9212011-08-12 Eli Zaretskii <eliz@gnu.org>
922
923 * xdisp.c (iterate_out_of_display_property): xassert that
924 IT->position is set to within IT->object's boundaries. Break from
925 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
926 when IT->position is set up wrongly due to some bug.
927 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
928 (push_display_prop): Allow GET_FROM_STRING as IT->method on
929 entry. Force push_it to save on the stack the current
930 buffer/string position, to be restored by pop_it. Fix flags in
931 the iterator structure wrt the object coming from a display
932 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
933 properties. (Bug#9284)
934
7be1c708 9352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 936
7be1c708
CY
937 * fontset.c (fontset_get_font_group): Add proper type checks.
938 (Bug#9172)
aac0c6e3 939
7be1c708 9402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 941
7be1c708
CY
942 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
943 and LC_VERSION_MIN_MACOSX.
944 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
945 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 946
97bb72a6
EZ
9472011-08-08 Eli Zaretskii <eliz@gnu.org>
948
949 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
950 no-display-properties-and-no-overlays under bidi display.
951 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 952 properties and overlays.
97bb72a6 953
d5617611
CY
9542011-08-08 Chong Yidong <cyd@stupidchicken.com>
955
37e11a63
CY
956 * editfns.c (Fset_time_zone_rule): Document relationship with the
957 setenv function.
958
d5617611
CY
959 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
960 the font entity extracted from the cache (Bug#8109).
961
58872834
CY
9622011-08-07 Chong Yidong <cyd@stupidchicken.com>
963
964 * composite.c (autocmp_chars): Don't reset point. That is done by
965 restore_point_unwind (Bug#5984).
966
75bfc667
JL
9672011-08-07 Juri Linkov <juri@jurta.org>
968
969 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
970 to show the arg `TIME' instead of `TIMEVAL'.
971
d1410150
EZ
9722011-08-06 Eli Zaretskii <eliz@gnu.org>
973
974 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
975 display property strides EOL and includes a newline, as in
976 longlines-mode. (Bug#9254)
75b771e4
EZ
977 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
978 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
979
980 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
981 is non-zero, even if the data buffer is NULL. Fixes a crash in
982 vertical-motion with longlines-mode. (Bug#9254)
983
35928349
EZ
9842011-08-05 Eli Zaretskii <eliz@gnu.org>
985
ec7cc85b
EZ
986 * bidi.c <bidi_cache_total_alloc>: Now static.
987 (bidi_initialize): Initialize bidi_cache_total_alloc.
988
8b76d6f8 989 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
990 cache. (Bug#9221)
991
992 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
993 amount allocated this far in `bidi_cache_total_alloc'.
994 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
995 non-zero, only free the data buffer without restoring the cache
996 contents. All callers changed.
997
998 * dispextern.h (bidi_unshelve_cache): Update prototype.
999
1000 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1001 (move_it_in_display_line, move_it_to)
1002 (move_it_vertically_backward, move_it_by_lines): Replace the call
1003 to xfree to an equivalent call to bidi_unshelve_cache.
1004 (move_it_in_display_line_to): Fix logic of returning
412b6358 1005 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1006
e2e2423b
EZ
10072011-08-05 Eli Zaretskii <eliz@gnu.org>
1008
1009 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1010 came from a string character with a `cursor' property. (Bug#9229)
1011
ae9e757a
JD
10122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1013
1014 * Makefile.in (LIB_PTHREAD): New variable.
1015 (LIBES): Add LIB_PTHREAD (Bug#9216).
1016
1017 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1018 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1019
213bd7f2
AS
10202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1021
1022 * regex.c (re_iswctype): Remove some redundant boolean
1023 conversions.
1024
99aaf75f
JD
10252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1026
1027 * xterm.c (x_find_topmost_parent): New function.
1028 (x_set_frame_alpha): Find topmost parent window with
1029 x_find_topmost_parent and set the property there also (bug#9181).
1030 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1031
c74e9d86
PE
10322011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 * callproc.c (Fcall_process): Avoid vfork clobbering
1035 the local vars buffer, coding_systems, current_dir.
1036
640c8776
SM
10372011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1038
1039 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1040
f26d0e4c
PE
10412011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1042
8a10d76c
PE
1043 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1044 so that it is not optimized away.
1045
f26d0e4c
PE
1046 * xdisp.c (compute_display_string_pos): Remove unused local.
1047
55439c61
EZ
10482011-08-02 Eli Zaretskii <eliz@gnu.org>
1049
1050 Fix slow cursor motion and scrolling in large buffers with
1051 selective display, like Org Mode buffers. (Bug#9218)
1052
1053 * dispextern.h (struct bidi_it): New member disp_prop_p.
1054
1055 * xdisp.c: Remove one-slot cache of display string positions.
1056 (compute_display_string_pos): Accept an additional argument
1057 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1058 for a display string or property. If found, set DISP_PROP_P
1059 non-zero.
1060
1061 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1062 DISP_PROP_P, and pass it to compute_display_string_pos.
1063 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1064 non-zero. All callers of bidi_fetch_char changed.
1065
fb33fa43
SM
10662011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1067
1068 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1069
b099e063
DM
10702010-12-03 Don March <don@ohspite.net>
1071
1072 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1073 last character M-[char] is translated to ESC [char] (bug#7541).
1074
5cc7f7af
KH
10752011-08-02 Kenichi Handa <handa@m17n.org>
1076
d0fffa3f 1077 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1078
1079 * chartab.c (uniprop_table): Make it non-static.
1080
525d5e6e
EZ
10812011-08-01 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (forward_to_next_line_start): Accept additional argument
1084 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1085 on the newline.
1086 (reseat_at_next_visible_line_start): Use the bidi iterator state
1087 returned by forward_to_next_line_start to restore the state of
1088 it->bidi_it after backing up to previous newline. (Bug#9212)
1089
31011111
AS
10902011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1091
1092 * regex.c (re_comp): Protoize.
1093 (re_exec): Fix return type.
1094 (regexec): Fix type of `ret'. (Bug#9203)
1095
476371c4
PE
10962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1097
e5d76069
PE
1098 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1099 This is needed if max-image-size is a floating-point number.
1100
9a79b20c
AS
11012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1102
1103 * print.c (print_object): Print empty symbol as ##.
1104
1105 * lread.c (read1): Read ## as empty symbol.
1106
d8c2fa78
AA
11072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1108
1109 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1110 setting frame foreground color (Bug#9175).
1111 (x_set_background_color): Likewise.
1112
ffe57a7a
AA
1113 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1114 contents (Bug#9176).
1115 (EmacsTooltip -init): Remove bezels and add shadows to
1116 tooltip windows.
1117
bf3492a5
AA
1118 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1119 or scroll bar (Bug#8470).
1120
d55e9c53
AA
1121 * nsfont.m (nsfont_open): Remove assignment to voffset and
1122 unnecessary vars hshink, expand, hd, full_height, min_height.
1123 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1124
1125 * nsterm.h (nsfont_info): Remove voffset field.
1126
d8c2fa78 11272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1128
1129 Implement strike-through and overline on NextStep (Bug#8863).
1130
1131 * nsfont.m (nsfont_open): Use underline position provided by font,
1132 instead of hard-coded value of 2.
1133 (nsfont_draw): Call ns_draw_text_decoration instead.
1134
1135 * nsterm.h: Add declaration for ns_draw_text_decoration.
1136
1137 * nsterm.m (ns_draw_text_decoration): New function for drawing
1138 underline, overline, and strike-through.
1139 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1140 ns_draw_text_decoration. Change treatment of cursor drawing to
1141 accomodate underlining, etc.
1142
4cc60b9b
EZ
11432011-07-28 Eli Zaretskii <eliz@gnu.org>
1144
bc7ece87
EZ
1145 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1146 default.
4cc60b9b 1147
476371c4
PE
11482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1149
66606eea
PE
1150 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1151 Without this fix, if a signal arrives just after memory fills up,
1152 'malloc' might be invoked reentrantly.
1153
476371c4
PE
1154 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1155 In other words, assume that every image size is allowed, on non-X
1156 hosts. This assumption is probably wrong, but it lets Emacs compile.
1157
f3fcc40d
AS
11582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1159
1160 * regex.c (re_iswctype): Convert return values to boolean.
1161
350c992f
EZ
11622011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1163
1164 * xdisp.c (compute_display_string_pos): Don't use cached display
1165 string position if the buffer had its restriction changed.
1166 (Bug#9184)
1167
5266b4bb
PE
11682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1171
2573a837 11722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1173
41f55ccd 1174 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1175
39e378da
PE
1176 * bidi.c: Integer size and overflow fixes.
1177 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1178 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1179 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1180 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1181 (bidi_find_other_level_edge):
1182 Use ptrdiff_t instead of EMACS_INT where either will do.
1183 This works better on 32-bit hosts configured --with-wide-int.
1184 (bidi_cache_ensure_space): Check for size-calculation overflow.
1185 Use % rather than repeated addition, for better worst-case speed.
1186 Don't set bidi_cache_size until after xrealloc returns, because it
1187 might not return.
1188 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1189 (bidi_cache_ensure_space): Also check that the bidi cache size
1190 does not exceed that of the largest Lisp string or buffer. See Eli
1191 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1192
5e927815
PE
1193 * alloc.c (__malloc_size_t): Remove.
1194 All uses replaced by size_t. See Andreas Schwab's note
1195 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1196
ca4aa935
PE
1197 * image.c: Improve checking for integer overflow.
1198 (check_image_size): Assume that f is nonnull, since
1199 it is always nonnull in practice. This is one less thing to
1200 worry about when checking for integer overflow later.
1201 (x_check_image_size): New function, which checks for integer
1202 overflow issues inside X.
1203 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1204 This removes the need for a memory_full check.
1205 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1206 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1207 (xbm_read_bitmap_data): Change locals back to 'int', since
1208 their values must fit in 'int'.
1209 (xpm_load_image, png_load, tiff_load):
1210 Invoke x_create_x_image_and_pixmap earlier,
1211 to avoid much needless work if the image is too large.
1212 (tiff_load): Treat overly large images as if
1213 x_create_x_image_and_pixmap failed, not as malloc failures.
1214 (gs_load): Use x_check_image_size.
1215
5f8f9cc2
PE
1216 * gtkutil.c: Omit integer casts.
1217 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1218 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1219
5adf60bc
PE
1220 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1221
c8907a93
PE
1222 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1223 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1224 would wrongly return t on a 64-bit host.
1225
e3c25c68
PE
1226 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1227 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1228 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1229 and therefore cause GCC to emit a bogus diagnostic in some cases.
1230
3f791afe
PE
1231 * image.c: Integer signedness and overflow and related fixes.
1232 This is not an exhaustive set of fixes, but it's time to
1233 record what I've got.
1234 (lookup_pixel_color, check_image_size): Remove redundant decls.
1235 (check_image_size): Don't assume that arbitrary EMACS_INT values
1236 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1237 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1238 (tiff_load, imagemagick_load_image):
1239 Check for overflow in size calculations.
1240 (x_create_x_image_and_pixmap): Remove unnecessary test for
1241 xmalloc returning NULL; that can't happen.
1242 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1243 (xpm_color_bucket): Use better integer hashing function.
1244 (xpm_cache_color): Don't possibly over-allocate memory.
1245 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1246 (gif_memory_source):
1247 Use ptrdiff_t, not int or size_t, to record sizes.
1248 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1249 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1250 either works, as we prefer signed integers.
1251 (tiff_read_from_memory, tiff_write_from_memory):
1252 Return tsize_t, not size_t, since that's what the TIFF API wants.
1253 (tiff_read_from_memory): Don't fail simply because the read would
1254 go past EOF; instead, return a short read.
1255 (tiff_load): Omit no-longer-needed casts.
1256 (Fimagemagick_types): Don't assume size fits into 'int'.
1257
3cc5a532
PE
1258 Improve hashing quality when configured --with-wide-int.
1259 * fns.c (hash_string): New function, taken from sxhash_string.
1260 Do not discard information about ASCII character case; this
1261 discarding is no longer needed.
1262 (sxhash-string): Use it. Change sig to match it. Caller changed.
1263 * lisp.h: Declare it.
1264 * lread.c (hash_string): Remove, since we now use fns.c's version.
1265 The fns.c version returns a wider integer if --with-wide-int is
1266 specified, so this should help the quality of the hashing a bit.
1267
b312a492
PE
1268 * emacs.c: Integer overflow minor fix.
1269 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1270 Define only if GNU_LINUX.
1271 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1272
dfd153ae
PE
1273 * dispnew.c: Integer signedness and overflow fixes.
1274 Remove unnecessary forward decls, that were a maintenance hassle.
1275 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1276 All uses changed.
1277 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1278 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1279 (prepare_desired_row, line_draw_cost):
1280 Use int, not unsigned, where either works.
1281 (save_current_matrix, restore_current_matrix):
1282 Use ptrdiff_t, not size_t, where either works.
1283 (init_display): Check for overflow more accurately, and without
1284 relying on undefined behavior.
1285
a81d11a3
PE
1286 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1287 Remove, replacing with the new symbols in lisp.h. All uses changed.
1288 * fileio.c (make_temp_name):
1289 * filelock.c (lock_file_1, lock_file):
1290 * xdisp.c (message_dolog):
1291 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1292 Use pMd etc. instead.
1293 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1294 replacing the pWIDE etc. symbols removed from editfns.c.
1295
3300e6fd
PE
1296 * keyboard.h (num_input_events): Now uintmax_t.
1297 This is (very slightly) less likely to mess up due to wraparound.
1298 All uses changed.
1299
fd05c7e9
PE
1300 * buffer.c: Integer signedness fixes.
1301 (alloc_buffer_text, enlarge_buffer_text):
1302 Use ptrdiff_t rather than size_t when either will do, as we prefer
1303 signed integers.
1304
903fe15d
PE
1305 * alloc.c: Integer signedness and overflow fixes.
1306 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1307 (__malloc_size_t): Default to size_t, not to int.
1308 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1309 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1310 Prefer ptrdiff_t to size_t when either would do, as we prefer
1311 signed integers.
1312 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1313 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1314 Now const. Initialize with values that are in range even if char
1315 is signed.
1316 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1317 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1318 These functions do the right thing with sizes > 2**32.
1319 (check_depth): Now ptrdiff_t, not int.
1320 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1321 Adjust to new way of storing sizes. Check for size overflow bugs
1322 in rest of code.
1323 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1324 slightly wrong anyway, as it missed one instance of
1325 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1326 (refill_memory_reserve): Omit needless cast to size_t.
1327 (mark_object_loop_halt): Mark as externally visible.
1328
ac82cc6a
PE
1329 * xselect.c: Integer signedness and overflow fixes.
1330 (Fx_register_dnd_atom, x_handle_dnd_message):
1331 Use ptrdiff_t, not size_t, since we prefer signed.
1332 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1333 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1334 x_dnd_atoms_size and x_dnd_atoms_length.
1335
c2d1e36d
PE
1336 * doprnt.c: Prefer signed to unsigned when either works.
1337 * eval.c (verror):
1338 * doprnt.c (doprnt):
1339 * lisp.h (doprnt):
1340 * xdisp.c (vmessage):
1341 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1342 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1343 prefer signed arithmetic to avoid comparison confusion.
1344 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1345 but is a bit tricky.
1346
0e926e56
PE
1347 Assume freestanding C89 headers, string.h, stdlib.h.
1348 * data.c, doprnt.c, floatfns.c, print.c:
1349 Include float.h unconditionally.
1350 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1351 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1352 * regex.c: Likewise for stddef.h, string.h.
1353 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1354 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1355 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1356 (STDC_HEADERS): Remove obsolete defines.
1357 * sysdep.c: Include limits.h unconditionally.
1358
9cfdb3ec
PE
1359 Assume support for memcmp, memcpy, memmove, memset.
1360 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1361 * regex.c (memcmp, memcpy):
1362 Remove; we assume C89 now.
1363
1364 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1365 (__malloc_safe_bcopy): Remove; no longer needed.
1366
cf950e6b 1367 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1368 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1369 well either way, and we prefer signed to unsigned.
1370
dbf38e02
LMI
13712011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1372
1373 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1374 closes the connection while we're reading (bug#9182).
1375
d6f0886c 13762011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1377
d6f0886c
JD
1378 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1379 are specified (Bug#9168).
24e0f6b1 1380
2eb1f9e6
PE
13812011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1384 Found by GCC static checking and --with-wide-int on a 32-bit host.
1385
22381272 13862011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1387
1388 * xdisp.c (compute_display_string_pos): Fix logic of caching
1389 previous display string position. Initialize cached_prev_pos to
1390 -1. Fixes slow-down at the beginning of a buffer.
1391
f25e39b4
EZ
13922011-07-24 Eli Zaretskii <eliz@gnu.org>
1393
1394 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1395 for attrs[LFACE_FONTSET_INDEX].
1396
04c4b52e
PE
13972011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1398
1399 * xml.c (parse_region): Remove unused local
1400 that was recently introduced.
1401
c1734fbd
EZ
14022011-07-23 Eli Zaretskii <eliz@gnu.org>
1403
be18c5a5
EZ
1404 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1405 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1406
c1734fbd
EZ
1407 * xdisp.c (move_it_in_display_line_to): Record the best matching
1408 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1409 exit if none of the characters scanned was an exact match.
1410 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1411 when exact match is impossible due to invisible text, and the
1412 lines are truncated.
1413
a258d627
JD
14142011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1415
1416 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1417 for OSX >= 10.7.
1418
b6d5a689
EZ
14192011-07-22 Eli Zaretskii <eliz@gnu.org>
1420
0f74f785
EZ
1421 Fix a significant slow-down of cursor motion with C-n, C-p,
1422 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1423 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1424 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1425 (next_element_from_buffer): Call compute_stop_pos_backwards to
1426 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1427 base_level_stop.
1428 (reseat): Don't look for prev_stop, as that could mean a very long
1429 run.
1430 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1431 <cached_disp_overlay_modiff>: Cache for last found display string
1432 position.
551918c1 1433 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1434 about the same buffer in the same area of character positions, and
1435 the buffer wasn't changed since the time the display string
1436 position was cached.
551918c1 1437
b2d0c91a
EZ
14382011-07-22 Eli Zaretskii <eliz@gnu.org>
1439
1440 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1441 is an integer, which is important for empty lines. (Bug#9149)
1442
043604ee
CY
14432011-07-22 Chong Yidong <cyd@stupidchicken.com>
1444
1445 * frame.c (Fmodify_frame_parameters): In tty case, update the
1446 default face if necessary (Bug#4238).
1447
da4adb04
CY
14482011-07-21 Chong Yidong <cyd@stupidchicken.com>
1449
1450 * editfns.c (Fstring_to_char): No need to explain what a character
1451 is in the docstring (Bug#6576).
1452
9abd0532
LMI
14532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1454
1455 * xml.c (parse_region): Make sure we always return a tree.
1456
36881d16
HK
14572011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1458
1459 * xml.c (parse_region): If a document contains only comments,
1460 return that, too.
1461
1e98674d
LMI
14622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1463
1464 * xml.c (make_dom): Return comments, too.
1465
590bd467
PE
14662011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 Port to OpenBSD.
1469 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1470 and the surrounding thread.
1471 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1472 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1473 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1474 timer goes off.
1475 * s/openbsd.h (BROKEN_SIGIO): Define.
1476 * unexelf.c (unexec) [__OpenBSD__]:
1477 Don't update the .mdebug section of the Alpha COFF symbol table.
1478
f41628b2
LMI
14792011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1480
1481 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1482 (bug#8460).
1483
b59b67c5
PE
14842011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1485
15e3a074
PE
1486 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1487 This fixes some race conditions on the permissions of any newly
1488 created file.
1489
41bed37d
PE
1490 * alloc.c (valid_pointer_p): Use pipe, not open.
1491 This fixes some permissions issues when debugging.
1492
b59b67c5
PE
1493 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1494 If fchown fails to set both uid and gid, try to set just gid,
1495 as that is sometimes allowed. Adjust the file's mode to eliminate
1496 setuid or setgid bits that are inappropriate if fchown fails.
1497
925a6be7
SM
14982011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1499
1500 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1501 to compare Lisp_Objects.
1502 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1503 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1504 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1505
52968808
AS
15062011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1507
0a6a104b
AS
1508 * lread.c (read_integer): Unread even EOF character.
1509 (read1): Likewise. Properly record start position of symbol.
1510
52968808
AS
1511 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1512 symbol character follows.
1513
9e381cdd
PE
15142011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1517 This works around a problem with the previous change to Fcopy_file.
1518 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1519 and without this change, GCC might complain about discarding
1520 fchown's return value.
1521
b5641435
JB
15222011-07-16 Juanma Barranquero <lekktu@gmail.com>
1523
1524 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1525
a8031457
PE
15262011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1529
dd889327
LMI
15302011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1531
750c33f7
LMI
1532 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1533 it's used from the C level.
1534
dd889327
LMI
1535 * process.c: Use the same condition for POLL_FOR_INPUT in both
1536 keyboard.c and process.c (bug#1858).
1537
87e86684
LM
15382011-07-09 Lawrence Mitchell <wence@gmx.li>
1539
1540 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1541 (Fgnutls_boot): Use it.
1542
64348f40
AS
15432011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1544
1545 * doc.c (Fsubstitute_command_keys): Revert last change.
1546
1d698799
LMI
15472011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1548
f863868c
LMI
1549 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1550 quotes the next character, and doesn't affect other longer
1551 sequences (bug#8935).
1552
1d698799
LMI
1553 * lread.c (syms_of_lread): Clarify that is isn't only
1554 `eval-buffer' and `eval-defun' that's affected by
1555 `lexical-binding' (bug#8460).
1556
aa4b6df6
EZ
15572011-07-15 Eli Zaretskii <eliz@gnu.org>
1558
1559 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1560 bidi redisplay when a line includes both an image and is
1561 truncated.
1562
5d856da6
PE
15632011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1564
ad6042bb
PE
1565 Fix minor problems found by static checking.
1566 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1567 (elsz): Now a signed constant, not a size_t var. We prefer signed
1568 types to unsigned, to avoid integer comparison confusion. Without
1569 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1570 "cannot optimize loop, the loop counter may overflow", a symptom
1571 of the confusion.
f00bbb22 1572 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1573 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1574
6468f31c
LMI
15752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1576
49080b10
LMI
1577 * search.c (Fre_search_backward): Mention `case-fold-search' in
1578 all the re_search_* functions (bug#8138).
1579
6468f31c
LMI
1580 * keyboard.c (Fopen_dribble_file): Document when the file is
1581 closed (bug#8056).
1582
c965adc5
EZ
15832011-07-14 Eli Zaretskii <eliz@gnu.org>
1584
df9733bf
EZ
1585 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1586 bidi_cache_idx.
1587
0bb23927
EZ
1588 Support bidi reordering of display and overlay strings.
1589 * xdisp.c (compute_display_string_pos)
1590 (compute_display_string_end): Accept additional argument STRING.
1591 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1592 (reseat_to_string): Initialize bidi_it->string.s and
1593 bidi_it->string.schars.
1594 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1595 NULL (avoids a crash in bidi_paragraph_init).
1596 Initialize itb.string.lstring.
0bb23927
EZ
1597 (init_iterator): Call bidi_init_it only of a valid
1598 buffer position was specified. Initialize paragraph_embedding to
1599 L2R.
1600 (reseat_to_string): Initialize the bidi iterator.
1601 (display_string): If we need to ignore text properties of
1602 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1603 original value of -1 will not work with bidi.)
1604 (compute_display_string_pos): First arg is now struct
1605 `text_pos *'; all callers changed. Support display properties on
1606 Lisp strings.
1607 (compute_display_string_end): Support display properties on Lisp
1608 strings.
1609 (init_iterator, reseat_1, reseat_to_string): Initialize the
1610 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1611 when iterating on a string not from display properties).
640c8776
SM
1612 (compute_display_string_pos, compute_display_string_end):
1613 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1614 arrow keys.
1615 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1616 base_level_stop; instead, set base_level_stop to BEGV.
1617 Fixes crashes in vertical-motion.
0bb23927
EZ
1618 (next_element_from_buffer): Improve commentary for when
1619 the iterator is before prev_stop.
1620 (init_iterator): Initialize bidi_p from the default value of
1621 bidi-display-reordering, not from buffer-local value. Use the
1622 buffer-local value only if initializing for buffer iteration.
1623 (handle_invisible_prop): Support invisible properties on strings
1624 that are being bidi-reordered.
1625 (set_iterator_to_next): Support bidi reordering of C strings and
1626 Lisp strings.
1627 (next_element_from_string): Support bidi reordering of Lisp
1628 strings.
1629 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1630 (display_string): Support display of R2L glyph rows.
1631 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1632 (init_iterator): Don't initialize it->bidi_p for strings
1633 here.
1634 (reseat_to_string): Initialize it->bidi_p for strings here.
1635 (next_element_from_string, next_element_from_c_string)
1636 (next_element_from_buffer): Add xassert's for correspondence
1637 between IT's object being iterated and it->bidi_it.string
1638 structure.
1639 (face_before_or_after_it_pos): Support bidi iteration.
1640 (next_element_from_c_string): Handle the case of the first string
1641 character that is not the first one in the visual order.
1642 (get_visually_first_element): New function, refactored from common
1643 parts of next_element_from_buffer, next_element_from_string, and
1644 next_element_from_c_string.
1645 (tool_bar_lines_needed, redisplay_tool_bar)
1646 (display_menu_bar): Force left-to-right direction. Add a FIXME
1647 comment for making that be controlled by a user option.
1648 (push_it, pop_it): Save and restore the state of the
1649 bidi iterator. Save and restore the bidi_p flag.
1650 (pop_it): Iterate out of display property for string iteration as
1651 well.
1652 (iterate_out_of_display_property): Support iteration over strings.
1653 (handle_single_display_spec): Set up it->bidi_it for iteration
1654 over a display string, and call bidi_init_it.
1655 (handle_single_display_spec, next_overlay_string)
1656 (get_overlay_strings_1, push_display_prop): Set up the bidi
1657 iterator for displaying display or overlay strings.
1658 (forward_to_next_line_start): Don't use the shortcut if
1659 bidi-iterating.
1660 (back_to_previous_visible_line_start): If handle_display_prop
1661 pushed the iterator stack, restore the internal state of the bidi
1662 iterator by calling bidi_pop_it same number of times.
1663 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1664 and we are bidi-iterating, don't decrement the iterator position;
1665 instead, set the first_elt flag in the bidi iterator, to produce
1666 the same effect.
1667 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1668 (push_display_prop): xassert that we are iterating a buffer.
1669 (push_it, pop_it): Save and restore paragraph_embedding member.
1670 (handle_single_display_spec, next_overlay_string)
1671 (get_overlay_strings_1, reseat_1, reseat_to_string)
1672 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1673 correctly. Don't assume unibyte strings are not bidi-reordered.
1674 (compute_display_string_pos)
1675 (compute_display_string_end): Fix handling the case of C string.
1676 (push_it, pop_it): Save and restore from_disp_prop_p.
1677 (handle_single_display_spec, push_display_prop): Set the
1678 from_disp_prop_p flag.
1679 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1680 (pop_it): Call iterate_out_of_display_property only if we are
1681 popping after iteration over a string that came from a display
1682 property. Fix a typo in popping stretch info. Add an assertion
1683 for verifying that the iterator position is in sync with the bidi
1684 iterator.
1685 (handle_single_display_spec, get_overlay_strings_1)
1686 (push_display_prop): Fix initialization of paragraph direction for
1687 string when that of the parent object is not yet determined.
1688 (reseat_1): Call bidi_init_it to resync the bidi
1689 iterator with IT's position. (Bug#7616)
1690 (find_row_edges): If ROW->start.pos gives position
1691 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1692 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1693 Reset the from_disp_prop_p flag.
1694 (SAVE_IT, RESTORE_IT): New macros.
1695 (pos_visible_p, face_before_or_after_it_pos)
1696 (back_to_previous_visible_line_start)
1697 (move_it_in_display_line_to, move_it_in_display_line)
1698 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1699 (try_scrolling, redisplay_window, display_line): Use them when
1700 saving a temporary copy of the iterator and restoring it back.
1701 (back_to_previous_visible_line_start, reseat_1)
1702 (init_iterator): Empty the bidi cache "stack".
1703 (move_it_in_display_line_to): If iterator ended up at
1704 EOL, but we never saw any buffer positions smaller than
1705 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1706 motion in bidi-reordered lines.
1707 (move_it_in_display_line_to): Record prev_method and prev_pos
1708 immediately before the call to set_iterator_to_next. Fixes cursor
1709 motion in bidi-reordered lines with stretch glyphs and strings
1710 displayed in margins. (Bug#8133) (Bug#8867)
1711 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1712 TO_CHARPOS.
640c8776
SM
1713 (pos_visible_p): Support positions in bidi-reordered lines.
1714 Save and restore bidi cache.
0bb23927
EZ
1715
1716 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1717 (bidi_paragraph_info): Delete unused struct.
1718 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1719 (bidi_cache_start): New variable.
1720 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1721 to zero.
1722 (bidi_cache_fetch_state, bidi_cache_search)
1723 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1724 (bidi_cache_find, bidi_peek_at_next_level)
1725 (bidi_level_of_next_char, bidi_find_other_level_edge)
1726 (bidi_move_to_visually_next): Compare cache index with
1727 bidi_cache_start rather than with zero.
1728 (bidi_fetch_char): Accept new argument STRING; all callers
1729 changed. Support iteration over a string. Support strings with
1730 display properties. Support unibyte strings. Fix the type of
1731 `len' according to what STRING_CHAR_AND_LENGTH expects.
1732 (bidi_paragraph_init, bidi_resolve_explicit_1)
1733 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1734 (bidi_level_of_next_char, bidi_move_to_visually_next):
1735 Support iteration over a string.
0bb23927
EZ
1736 (bidi_set_sor_type, bidi_resolve_explicit_1)
1737 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1738 can now be zero (for strings); special values 0 and -1 were
1739 changed to -1 and -2, respectively.
1740 (bidi_char_at_pos): New function.
1741 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1742 Call it instead of FETCH_MULTIBYTE_CHAR.
1743 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1744 initialized to valid values.
1745 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1746 values.
1747 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1748 the test for valid cached positions. Fix the logic for looking up
1749 the sentinel state in the cache. GCPRO the Lisp string we are
1750 iterating.
1751 (bidi_push_it, bidi_pop_it): New functions.
1752 (bidi_initialize): Initialize the bidi cache start stack pointer.
1753 (bidi_cache_ensure_space): New function, refactored from part of
1754 bidi_cache_iterator_state. Don't assume the required size is just
1755 one BIDI_CACHE_CHUNK away.
1756 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1757 (bidi_count_bytes, bidi_char_at_pos): New functions.
1758 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1759 always valid if bidi_cache_idx is valid.
1760 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1761 is valid if it's going to be used.
1762 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1763 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1764 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1765 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1766 (bidi_find_other_level_edge, bidi_cache_start_stack):
1767 All variables related to cache indices are now EMACS_INT.
c965adc5 1768
0bb23927
EZ
1769 * dispextern.h (struct bidi_string_data): New structure.
1770 (struct bidi_it): New member `string'. Make flag members be 1-bit
1771 fields, and put them last in the struct.
640c8776
SM
1772 (compute_display_string_pos, compute_display_string_end):
1773 Update prototypes.
0bb23927
EZ
1774 (bidi_push_it, bidi_pop_it): Add prototypes.
1775 (struct iterator_stack_entry): New members bidi_p,
1776 paragraph_embedding, and from_disp_prop_p.
1777 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1778 (bidi_shelve_cache, bidi_unshelve_cache):
1779 Declare prototypes.
0bb23927
EZ
1780
1781 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1782 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1783 and vector-like objects.
1784
1785 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1786 cache around display iteration.
1787
1788 * window.c (Fwindow_end, window_scroll_pixel_based)
1789 (displayed_window_lines, Frecenter): Save and restore the bidi
1790 cache around display iteration.
1791
3bbd2265
LMI
17922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1793
1794 * editfns.c (Fdelete_region): Clarify the use of the named
1795 parameters (bug#6788).
1796
adc47434
MR
17972011-07-14 Martin Rudalics <rudalics@gmx.at>
1798
1799 * indent.c (Fvertical_motion): Set and restore w->pointm when
1800 saving and restoring the window's buffer (Bug#9006).
1801
837c31f8
LMI
18022011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1803
1804 * editfns.c (Fstring_to_char): Clarify just what is returned
1805 (bug#6576). Text by Eli Zaretskii.
1806
ac389d0c
JB
18072011-07-13 Juanma Barranquero <lekktu@gmail.com>
1808
1809 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1810
0be0ce47
EZ
18112011-07-13 Eli Zaretskii <eliz@gnu.org>
1812
1813 * buffer.c (mmap_find): Fix a typo.
1814
cd18e7e3
JB
18152011-07-13 Johan Bockgård <bojohan@gnu.org>
1816
1817 Fix execution of x selection hooks.
1818 * xselect.c (Qx_lost_selection_functions)
1819 (Qx_sent_selection_functions): New vars.
1820 (syms_of_xselect): DEFSYM them.
1821 (x_handle_selection_request): Pass Qx_sent_selection_functions
1822 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1823 (x_handle_selection_clear,x_clear_frame_selections):
1824 Pass Qx_lost_selection_functions rather than
1825 Vx_lost_selection_functions to Frun_hook_with_args.
1826
47ea7f44
PE
18272011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1828
ac389d0c 1829 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1830 The old code sometimes used this field without initializing it.
1831
47ea7f44
PE
1832 * alloc.c (gc_sweep): Don't read past end of array.
1833 In theory, the old code could also have corrupted Emacs internals,
1834 though it'd be very unlikely.
1835
bc985c87
AS
18362011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1837
1838 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1839 argument. (Bug#4026)
bc985c87 1840
0cf34688
LMI
18412011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1842
b3dadd76
LMI
1843 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1844 key" (bug#4257).
1845
0cf34688
LMI
1846 * window.c (Fset_window_start): Doc fix (bug#4199).
1847 (Fset_window_hscroll): Ditto.
1848
270768cd
PE
18492011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1850
077e3dda 1851 Fix minor new problems caught by GCC 4.6.1.
270768cd 1852 * term.c (init_tty): Remove unused local.
490011a6 1853 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1854 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1855 not used otherwise.
270768cd 1856
b1f58454
CY
18572011-07-12 Chong Yidong <cyd@stupidchicken.com>
1858
1859 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1860
22b9578d
LMI
18612011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1862
6e70ab07
LMI
1863 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1864 are the mini-buffer and the echo area (bug#3320).
1865
22b9578d
LMI
1866 * term.c (init_tty): Remove support for supdup, c10 and perq
1867 terminals, which are no longer supported (bug#1482).
1868
8974cc9f
JB
18692011-07-10 Johan Bockgård <bojohan@gnu.org>
1870
1871 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1872
a560d974
JD
18732011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1874
1875 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1876 for non-popups (Bug#3642).
1877
1dae0f0a
AS
18782011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1879
268c2c36 1880 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1881 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1882 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1883 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1884 * data.c (fmod): Likewise.
1885 * dispnew.c (swap_glyphs_in_rows): Likewise.
1886 * emacs.c (memory_warning_signal): Likewise.
1887 * floatfns.c (float_error): Likewise.
1888 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1889 (otf_open, font_otf_capability, generate_otf_features)
1890 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1891 Likewise.
1892 * image.c (pbm_read_file): Likewise.
1893 * indent.c (string_display_width): Likewise.
1894 * intervals.c (check_for_interval, search_for_interval)
1895 (inc_interval_count, count_intervals, root_interval)
1896 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1897 * lread.c (defalias): Likewise.
268c2c36 1898 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1899 * regex.c (set_image_of_range_1, set_image_of_range)
1900 (regex_grow_registers): Likewise.
1901 * sysdep.c (strerror): Likewise.
1902 * termcap.c (valid_filename_p, tprint, main): Likewise.
1903 * tparam.c (main): Likewise.
1904 * unexhp9k800.c (run_time_remap, save_data_space)
1905 (update_file_ptrs, read_header, write_header, calculate_checksum)
1906 (copy_file, copy_rest, display_header): Likewise.
1907 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1908 Likewise.
1909 * xdisp.c (check_it): Likewise.
1910 * xfaces.c (register_color, unregister_color, unregister_colors):
1911 Likewise.
1912 * xfns.c (print_fontset_result): Likewise.
1913 * xrdb.c (member, fatal, main): Likewise.
1914
99033785
PE
19152011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1916
1917 Fix minor problems found by static checking (Bug#9031).
1918 * chartab.c (char_table_set_range, map_sub_char_table):
1919 Remove unused locals.
1920 (uniprop_table): Now static.
1921 * composite.c (_work_char): Remove unused static var.
1922
9cb2ac56
JB
19232011-07-09 Juanma Barranquero <lekktu@gmail.com>
1924
1925 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1926
f25661f0
JD
19272011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1928
1929 * gtkutil.c (qttip_cb): Remove code without function.
1930
8278c4fe
EZ
19312011-07-09 Eli Zaretskii <eliz@gnu.org>
1932
1933 * w32.c (pthread_sigmask): New stub.
1934
1692ae2d 19352011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1936
8a6ebd58 1937 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1938 sigprocmask is portable only for single-threaded applications, and
1939 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1940 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1941 (LIBES): Use it.
1942 * callproc.c (Fcall_process):
1943 * process.c (create_process):
1944 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1945 Use pthread_sigmask, not sigprocmask.
123403e4 1946
1b854618
JD
19472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1948
1949 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1950 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1951 wrong (Bug#8591).
1952
3fe4b549
JD
19532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1954
0ce7e563
JD
1955 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1956 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1957 (xg_hide_tooltip): Fix comment.
1958
3fe4b549
JD
1959 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1960 in registerServicesMenuSendTypes.
1961 (validRequestorForSendType): Don't check ns_return_types.
1962
1963 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1964 ns_return_type.
1965
5df75e47
JR
19662011-07-08 Jason Rumney <jasonr@gnu.org>
1967
1968 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1969 frame struct members of non-existent frames (Bug#6284).
1970
699c10bd
JD
19712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1972
4393663b
JD
1973 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1974 variable firstTime not needed on OSX >= 10.6.
1975 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1976 >= 10.5. Use setKnobProportion, setDoubleValue.
1977
1978 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1979 (MAC_OS_X_VERSION_10_5): Define if not defined.
1980 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1981 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1982 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1983
1984 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1985 cString and lossyCString on OSX >= 10.4
1986
1987 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1988 sizeToFit on OSX >= 10.2.
1989
1990 * nsimage.m (allocInitFromFile): Don't use deprecated method
1991 bestRepresentationForDevice on OSX >= 10.6.
1992
1993 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1994 to avoid warning.
1995
1996 * emacs.c: Declare unexec_init_emacs_zone.
1997
a63e0781
JD
1998 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1999
699c10bd
JD
2000 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2001
2002 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2003 on svcsMenu (Bug#8842).
2004
2005 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2006 ns_return_types.
2007 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2008
2009 * nsterm.m (QUTF8_STRING): Declare.
2010 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2011 (validRequestorForSendType): Return type is (id).
2012 Change indexOfObjectIdenticalTo to indexOfObject.
2013 Check if we have local selection before returning self (Bug#8842).
2014 (writeSelectionToPasteboard): Put local selection into paste board
2015 if we have a local selection (Bug#8842).
2016 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2017
2018 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2019 (ns_get_local_selection): Declare.
2020
54e10184
LMI
20212011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2022
9888ff71
LMI
2023 * keymap.c (describe_map_tree): Don't insert a double newline at
2024 the end of the buffer (bug#1169) and return whether we inserted
2025 something.
2026
54e10184
LMI
2027 * callint.c (Fcall_interactively): Change "reading args" to
2028 "providing args" to try to clarify what it does (bug#1010).
2029
15fa4783
KH
20302011-07-07 Kenichi Handa <handa@m17n.org>
2031
2032 * composite.c (composition_compute_stop_pos): Ignore a static
2033 composition starting before CHARPOS (Bug#8915).
2034
2035 * xdisp.c (handle_composition_prop): Likewise.
2036
a8815b00
EZ
20372011-07-07 Eli Zaretskii <eliz@gnu.org>
2038
2039 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2040 (Bug#9015)
2041
ef7b981d 20422011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2043
2044 * character.h (unicode_category_t): New enum type.
2045
2046 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2047 (Qchar_code_property_table): New variable.
2048 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2049 (UNIPROP_COMPRESSED_FORM_P): New macros.
2050 (char_table_ascii): Uncompress the compressed values.
2051 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2052 Uncompress the compressed values.
ac389d0c 2053 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2054 (char_table_ref_and_range): Uncompress the compressed values.
2055 (sub_char_table_set): New arg is_uniprop. Callers changed.
2056 Uncompress the compressed values.
2057 (sub_char_table_set_range): Args changed. Callers changed.
2058 (char_table_set_range): Adjuted for the above change.
2059 (map_sub_char_table): Delete args default_val and parent. Add arg
2060 top. Give decoded values to a Lisp function.
640c8776 2061 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2062 values to a Lisp function. Gcpro more variables.
2063 (uniprop_table_uncompress)
2064 (uniprop_decode_value_run_length): New functions.
2065 (uniprop_decoder, uniprop_decoder_count): New variables.
2066 (uniprop_get_decoder, uniprop_encode_value_character)
2067 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2068 New functions.
2069 (uniprop_encoder, uniprop_encoder_count): New variables.
2070 (uniprop_get_encoder, uniprop_table)
2071 (Funicode_property_table_internal, Fget_unicode_property_internal)
2072 (Fput_unicode_property_internal): New functions.
2073 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2074 Sunicode_property_table_internal, Sget_unicode_property_internal,
2075 and Sput_unicode_property_internal. Defvar_lisp
2076 char-code-property-alist.
2077
640c8776 2078 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2079 Vunicode_category_table.
2080
640c8776 2081 * font.c (font_range): Adjust for the change of
c805dec0
KH
2082 Vunicode_category_table.
2083
76b397fb
DN
20842011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2085
2086 * m/iris4d.h: Remove file, move contents ...
2087 * s/irix6-5.h: ... here.
2088
22b4128e
PE
20892011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2090
2091 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2092 * alloc.c (mark_buffer):
2093 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2094 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2095 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2096 This isn't true in general, and it's particularly not true
2097 if Emacs is configured with --with-wide-int.
2098 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2099 New macros, used in the buffer.c change.
2100
869795d6
JD
21012011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2102
2103 * xsettings.c: Use both GConf and GSettings if both are available.
2104 (store_config_changed_event): Add comment.
2105 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2106 (store_tool_bar_style_changed): New functions.
2107 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2108 (struct xsettings): Move font inside HAVE_XFT.
2109 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2110 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2111 Move inside HAVE_XFT.
640c8776 2112 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2113 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2114 also.
2115 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
2116 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2117 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2118 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2119 (parse_settings): Move check for font inside HAVE_XFT.
2120 (read_settings, apply_xft_settings): Add comment.
2121 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2122 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2123 call store_font_name_changed.
2124 (xft_settings_event): Add comment.
2125 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2126 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2127 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2128 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2129 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2130 (xsettings_get_system_font, xsettings_get_system_normal_font):
2131 Add comment.
869795d6 2132
d8ed26bd
PE
21332011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2134
2135 Random fixes. E.g., (random) never returned negative values.
2136 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2137 subseconds part to the entropy, as that's a bit more random.
2138 Prefer signed to unsigned, since the signedness doesn't matter and
2139 in general we prefer signed. When given a limit, use a
2140 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2141 latter isn't right if USE_2_TAGS_FOR_INTS.
2142 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2143 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2144
cabf1cac
SM
21452011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2146
2147 * textprop.c (text_property_stickiness):
2148 Obey Vtext_property_default_nonsticky.
2149 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2150 * w32fns.c (syms_of_w32fns):
2151 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2152
6e9b2be9
PE
21532011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2156 This is more efficient than Ffile_directory_p and avoids a minor race.
2157
90186c68
LMI
21582011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2159
7c301272
LMI
2160 * buffer.c (Foverlay_put): Say what the return value is
2161 (bug#7835).
2162
c4f2d8d4
LMI
2163 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2164 is a directory before asking whether to use the file name
2165 (bug#7564).
ad637907
LMI
2166 (barf_or_query_if_file_exists): Make the "File is a directory"
2167 error be more correct.
c4f2d8d4 2168
90186c68
LMI
2169 * fns.c (Frequire): Remove the mention of the .gz files, since
2170 that's installation-specific, but keep the mention of
2171 `get-load-suffixes'.
2172
da64016e
PE
21732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2174
2175 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2176 Report string overflow if the output is too long.
2177
7d47b580
JB
21782011-07-04 Juanma Barranquero <lekktu@gmail.com>
2179
a555cb87
JB
2180 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2181 (syms_of_gnutls): Remove duplicate DEFSYM for
2182 Qgnutls_bootprop_verify_hostname_error, an error for
2183 Qgnutls_bootprop_verify_error (which is no longer used).
2184
7d47b580
JB
2185 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2186 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2187 Also (re)move comments that are misplaced or no longer relevant.
2188
1e49bfab
LMI
21892011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2190
2191 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2192
1485f4c0
CY
21932011-07-03 Chong Yidong <cyd@stupidchicken.com>
2194
2195 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2196 and background color parameters if they have been changed.
2197
a9ab721e
LMI
21982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2199
2200 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2201
cf7cff57
PE
22022011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2203
2e13213d
PE
2204 * xsettings.c (SYSTEM_FONT): Define only when used.
2205 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2206
cf7cff57
PE
2207 * keymap.c (access_keymap_1): Now static.
2208
7a8e04f7
CY
22092011-07-02 Chong Yidong <cyd@stupidchicken.com>
2210
2211 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2212 leave any prefix arg for the up event (Bug#1586).
2213
61352f62
LMI
22142011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2215
69bb1ef7
LMI
2216 * lread.c (syms_of_lread): Mention single symbols defined by
2217 `defvar' or `defconst' (bug#7154).
2218
61352f62 2219 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2220 (Frequire): Mention get-load-suffixes.
61352f62 2221
28545e04
MR
22222011-07-02 Martin Rudalics <rudalics@gmx.at>
2223
2224 * window.h (window): Remove clone_number slot.
2225 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2226 Remove.
2227 (make_parent_window, make_window, saved_window)
2228 (Fset_window_configuration, save_window_save): Don't deal with
2229 clone numbers.
2230 * buffer.c (Qclone_number): Remove declaration.
2231 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2232
3349e122
SM
22332011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2234
2235 Add multiple inheritance to keymaps.
2236 * keymap.c (Fmake_composed_keymap): New function.
2237 (Fset_keymap_parent): Simplify.
2238 (fix_submap_inheritance): Remove.
2239 (access_keymap_1): New function extracted from access_keymap to handle
2240 embedded parents and handle lists of maps.
2241 (access_keymap): Use it.
2242 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2243 (Fcopy_keymap): Handle embedded parents.
2244 (Fcommand_remapping, define_as_prefix): Simplify.
2245 (Fkey_binding): Simplify.
2246 (syms_of_keymap): Move minibuffer-local-completion-map,
2247 minibuffer-local-filename-completion-map,
2248 minibuffer-local-must-match-map, and
2249 minibuffer-local-filename-must-match-map to Elisp.
2250 (syms_of_keymap): Defsubr make-composed-keymap.
2251 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2252 (parse_menu_item): Trivial simplification.
2253
3279eb87
GM
22542011-07-01 Glenn Morris <rgm@gnu.org>
2255
2256 * Makefile.in (SETTINGS_LIBS): Fix typo.
2257
4550efdf
KI
22582011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2259
2260 * coding.c (Fencode_coding_string): Record the last coding system
2261 used, as the function doc string says (bug#8738).
2262
0949d2b6
JD
22632011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2264
2265 * xsettings.c (store_monospaced_changed): Take new font as arg and
2266 check for change against current_mono_font.
2267 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2268 (emacs_settings_constructor, emacs_settings_get_property)
2269 (emacs_settings_set_property, emacs_settings_class_init)
2270 (emacs_settings_init, gsettings_obj): Remove.
2271 (something_changedCB): New function for HAVE_GSETTINGS.
2272 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2273 with value as argument.
2274 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2275 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2276 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2277 "changed".
2278
2279 * xgselect.c: Add defined (HAVE_GSETTINGS).
2280 (xgselect_initialize): Ditto.
2281
2282 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2283 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2284 xg_select.
2285
bbc6b304
PE
22862011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 * eval.c (struct backtrace): Simplify and port the data structure.
2289 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2290 signed bit field, as this assumption is not portable and it makes
2291 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2292 "char debug_on_exit : 1" as this is not portable either; instead,
2293 use the portable "unsigned int debug_on_exit : 1". Remove unused
2294 member evalargs. Remove obsolete comments about cc bombing out.
2295
9851bfc5
JD
22962011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2297
51bb811f 2298 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2299 Let HAVE_GSETTINGS override HAVE_GCONF.
2300 (store_monospaced_changed): New function.
2301 (EMACS_SETTINGS): A new type derived from GObject to handle
2302 GSettings notifications.
2303 (emacs_settings_constructor, emacs_settings_get_property)
2304 (emacs_settings_set_property, emacs_settings_class_init):
2305 New functions.
2306 (gsettings_client, gsettings_obj): New variables.
2307 (GSETTINGS_SCHEMA): New define.
2308 (something_changedCB): Call store_monospaced_changed.
2309 (init_gsettings): New function.
2310 (xsettings_initialize): Call init_gsettings.
2311 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2312 to NULL.
2313
640c8776 2314 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2315 GCONF_CFLAGS/LIBS.
2316
5386012d
MR
23172011-06-29 Martin Rudalics <rudalics@gmx.at>
2318
2319 * window.c (resize_root_window, grow_mini_window)
2320 (shrink_mini_window): Rename Qresize_root_window to
2321 Qwindow_resize_root_window and Qresize_root_window_vertically to
2322 Qwindow_resize_root_window_vertically.
2323
f13e0b08
PE
23242011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2325
2326 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2327
94515237
JB
23282011-06-27 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * makefile.w32-in: Redesign dependencies so they reflect more
2331 clearly which files are directly included by each source file,
2332 and not through other includes.
2333
e43b6e43
MR
23342011-06-27 Martin Rudalics <rudalics@gmx.at>
2335
2336 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2337 (sort_overlays, overlay_strings): When an overlay's clone number
2338 matches the window's clone number process the overlay even if
2339 the overlay's window property doesn't match the current window.
2340
d68443dc
MR
2341 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2342 (Fwindow_hchild): Rename to Fwindow_left_child.
2343 (Fwindow_next): Rename to Fwindow_next_sibling.
2344 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2345 (resize_window_check): Rename to window_resize_check.
2346 (resize_window_apply): Rename to window_resize_apply.
2347 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2348 (Fdelete_other_windows_internal, resize_frame_windows)
2349 (Fsplit_window_internal, Fdelete_window_internal)
2350 (grow_mini_window, shrink_mini_window)
2351 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2352
c7e73be5
JD
23532011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2354
2355 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2356 (emacs_fixed_set_min_size): Remove.
2357 (emacs_fixed_new): Take frame as argument.
2358
2359 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2360 (_EmacsFixedPrivate): Remove minwidth/height.
2361 Add struct frame *f.
2362 (emacs_fixed_init): Initialize priv->f.
2363 (get_parent_class, emacs_fixed_set_min_size): Remove.
2364 (emacs_fixed_new): Set priv->f to argument.
2365 (emacs_fixed_get_preferred_width)
2366 (emacs_fixed_get_preferred_height): Use min_width/height from
2367 frames size_hint to set minimum and natural (Bug#8919).
2368 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2369 and use min_width/height from frames size_hint to set
2370 min_width/height (Bug#8919).
2371
2372 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2373 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2374 Fix indentation.
c7e73be5 2375
cf99dcf8
EZ
23762011-06-26 Eli Zaretskii <eliz@gnu.org>
2377
2378 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2379 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2380 called at ZV.
2381
029529ac
CY
23822011-06-26 Chong Yidong <cyd@stupidchicken.com>
2383
2384 * process.c (wait_reading_process_output): Bypass select if
2385 waiting for a cell while ignoring keyboard input, and input is
2386 pending. Suggested by Jan Djärv (Bug#8869).
2387
7a7ef429
PE
23882011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 Use gnulib's dup2 module instead of rolling our own.
2391 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2392
11fdef7d 23932011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2394
2395 * dispnew.c (scrolling_window): Before scrolling, turn off a
2396 mouse-highlight in the window being scrolled.
2397
cd3520a4
JB
23982011-06-24 Juanma Barranquero <lekktu@gmail.com>
2399
2400 Move DEFSYM to lisp.h and use everywhere.
2401
2402 * character.h (DEFSYM): Move declaration...
2403 * lisp.h (DEFSYM): ...here.
2404
2405 * gnutls.c:
2406 * minibuf.c:
2407 * w32menu.c:
2408 * w32proc.c:
2409 * w32select.c: Don't include character.h.
2410
2411 * alloc.c (syms_of_alloc):
2412 * buffer.c (syms_of_buffer):
2413 * bytecode.c (syms_of_bytecode):
2414 * callint.c (syms_of_callint):
2415 * casefiddle.c (syms_of_casefiddle):
2416 * casetab.c (init_casetab_once):
2417 * category.c (init_category_once, syms_of_category):
2418 * ccl.c (syms_of_ccl):
2419 * cmds.c (syms_of_cmds):
2420 * composite.c (syms_of_composite):
2421 * dbusbind.c (syms_of_dbusbind):
2422 * dired.c (syms_of_dired):
2423 * dispnew.c (syms_of_display):
2424 * doc.c (syms_of_doc):
2425 * editfns.c (syms_of_editfns):
2426 * emacs.c (syms_of_emacs):
2427 * eval.c (syms_of_eval):
2428 * fileio.c (syms_of_fileio):
2429 * fns.c (syms_of_fns):
2430 * frame.c (syms_of_frame):
2431 * fringe.c (syms_of_fringe):
2432 * insdel.c (syms_of_insdel):
2433 * keymap.c (syms_of_keymap):
2434 * lread.c (init_obarray, syms_of_lread):
2435 * macros.c (syms_of_macros):
2436 * msdos.c (syms_of_msdos):
2437 * print.c (syms_of_print):
2438 * process.c (syms_of_process):
2439 * search.c (syms_of_search):
2440 * sound.c (syms_of_sound):
2441 * syntax.c (init_syntax_once, syms_of_syntax):
2442 * terminal.c (syms_of_terminal):
2443 * textprop.c (syms_of_textprop):
2444 * undo.c (syms_of_undo):
2445 * w32.c (globals_of_w32):
2446 * window.c (syms_of_window):
2447 * xdisp.c (syms_of_xdisp):
2448 * xfaces.c (syms_of_xfaces):
2449 * xfns.c (syms_of_xfns):
2450 * xmenu.c (syms_of_xmenu):
2451 * xsettings.c (syms_of_xsettings):
2452 * xterm.c (syms_of_xterm): Use DEFSYM.
2453
4228cf16
TZ
24542011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2455
cd3520a4 2456 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2457
7fcccf1e
PE
24582011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2459
7efb4e0e
PE
2460 Integer and buffer overflow fixes (Bug#8873).
2461
ff5844ad
PE
2462 * print.c (printchar, strout): Check for string overflow.
2463 (PRINTPREPARE, printchar, strout):
2464 Don't set size unless allocation succeeds.
2465
90532f02
PE
2466 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2467 for sizes. Check for string overflow more accurately.
2468 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2469
6d84508d
PE
2470 * macros.c: Integer and buffer overflow fixes.
2471 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2472 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2473 Use ptrdiff_t, not int, for sizes.
2474 Don't increment bufsize until after realloc succeeds.
2475 Check for size-calculation overflow.
2476 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2477
437b2cb4
PE
2478 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2479
8b9ac8b4
PE
2480 * lread.c: Integer overflow fixes.
2481 (read_integer): Radix is now EMACS_INT, not int,
2482 to improve quality of diagnostics for out-of-range radices.
2483 Calculate buffer size correctly for out-of-range radices.
2484 (read1): Check for integer overflow in radices, and in
2485 read-circle numbers.
82cb60d3
PE
2486 (read_escape): Avoid int overflow.
2487 (Fload, openp, read_buffer_size, read1)
2488 (substitute_object_recurse, read_vector, read_list, map_obarray):
2489 Use ptrdiff_t, not int, for sizes.
2490 (read1): Use EMACS_INT, not int, for sizes.
20270765 2491 Check for size overflow.
8b9ac8b4 2492
7fcccf1e
PE
2493 * image.c (cache_image): Check for size arithmetic overflow.
2494
bfbbd7e7
PE
2495 * lread.c: Integer overflow issues.
2496 (saved_doc_string_size, saved_doc_string_length)
2497 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2498 Now ptrdiff_t, not int.
2499 (read1): Don't assume doc string length fits in int. Check for
2500 out-of-range doc string lengths.
2501 (read_list): Don't assume file position fits in int.
39019e54 2502 (read_escape): Check for hex character overflow.
bfbbd7e7 2503
4e323265
LL
25042011-06-22 Leo Liu <sdl.web@gmail.com>
2505
2506 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2507 Move to minibuffer.el.
2508
85fece3e
PE
25092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2510
20b84ce9 2511 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2512 The following patches are for when GLYPH_DEBUG && !XASSERT.
2513 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2514 * dispnew.c (flush_stdout):
2515 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2516 Mark as externally visible.
2517 * dispnew.c (check_window_matrix_pointers): Now static.
2518 * dispnew.c (window_to_frame_vpos):
2519 * xfns.c (unwind_create_frame):
2520 * xterm.c (x_check_font): Remove unused local.
2521 * scroll.c (CHECK_BOUNDS):
2522 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2523 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2524 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2525 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2526 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2527 Now static.
2528 (debug_method_add): Use va_list and vsprintf rather than relying
2529 on undefined behavior with wrong number of arguments.
2530 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2531 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2532 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2533 since we're not interested in debugging glyphs with old libraries.
2534 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2535 GCC 4.6.0's static checking.
2536
0766b489
PE
25372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2538
31fd4b32
PE
2539 Integer overflow and signedness fixes (Bug#8873).
2540 A few related buffer overrun fixes, too.
2541
b79e8648
PE
2542 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2543
0766b489
PE
2544 * dispextern.h (struct face.stipple):
2545 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2546 (x_bitmap_mask, x_allocate_bitmap_record)
2547 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2548 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2549 (x_create_bitmap_from_xpm_data):
2550 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2551 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2552 (.bitmaps_last):
2553 * xfaces.c (load_pixmap):
2554 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2555 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2556 (.bitmaps_last, struct x_output.icon_bitmap):
2557 Use ptrdiff_t, not int, for bitmap indexes.
2558 (x_allocate_bitmap_record): Check for size overflow.
2559 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2560
b081724f
PE
2561 Use ptrdiff_t, not int, for overlay counts.
2562 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2563 * editfns.c (overlays_around, get_pos_property):
2564 * textprop.c (get_char_property_and_overlay):
2565 * xdisp.c (next_overlay_change, note_mouse_highlight):
2566 * xfaces.c (face_at_buffer_position):
21514da7
PE
2567 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2568 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2569 (Fnext_overlay_change, Fprevious_overlay_change)
2570 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2571 Use ptrdiff_t, not int, for sizes.
21514da7 2572 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2573
3de73e5e
PE
2574 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2575
2606c57b
PE
2576 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2577 (x_session_initialize): Do not assume string length fits in int.
2578
aaafe47a
PE
2579 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2580 This is unlikely, but can occur if DPI is outlandish.
2581
2674ddc8 2582 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2583 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2584
28154962
PE
2585 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2586 * xrdb.c (magic_file_p, search_magic_path):
2587 Omit last arg SUFFIX; it was always 0. All callers changed.
2588 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2589
7de51af5
PE
2590 * xfont.c (xfont_match): Avoid need for strlen.
2591
25ed6cc3
PE
2592 * xfns.c: Don't assume strlen fits in int.
2593 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2594
4eab31dd
PE
2595 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2596 not unsigned long, as we prefer signed integers. All callers changed.
2597 Detect integer overflow in repeat count.
2598 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2599 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2600
171e2a58
PE
2601 * termcap.c: Don't assume sizes fit in int and never overflow.
2602 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2603 (gobble_line): Check for size-calculation overflow.
2604
ad39faca 2605 * minibuf.c (Fread_buffer):
6e5bb2dc 2606 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2607 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2608 Don't assume string length fits in int.
2609
52c61c22 2610 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2611 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2612
b5b8c9e5
PE
2613 * font.c: Don't assume string length fits in int.
2614 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2615 Use ptrdiff_t, not int.
ccd6111c
PE
2616 (font_intern_prop): Don't assume string length fits in int.
2617 Don't assume integer property fits in fixnum.
2618 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2619
882f0d81 2620 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2621 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2622 Reformulate so as not to need the command string.
2623 Invoke gzip -cd rather than gunzip, as it's more portable.
2624 (lock_info_type, lock_file_1, lock_file):
2625 Don't assume pid_t and time_t fit in unsigned long.
2626 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2627 (current_lock_owner): Prefer signed type for sizes.
2628 Use memcpy, not strncpy, where memcpy is what is really wanted.
2629 Don't assume (via atoi) that time_t and pid_t fit in int.
2630 Check for time_t and/or pid_t out of range, e.g., via a network share.
2631 Don't alloca where an auto var works fine.
2632
93f4cf88
PE
2633 * fileio.c: Fix some integer overflow issues.
2634 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2635 Don't assume string length fits in int.
2636 (directory_file_name): Don't assume string length fits in long.
2637 (make_temp_name): Don't assume pid fits in int, or that its print
2638 length is less than 20.
2639
f3e92b69
PE
2640 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2641
1bfdaf10
PE
2642 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2643
35016e9a
PE
2644 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2645
3d1e65a1
PE
2646 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2647 We prefer signed integers, even for size calculations.
2648
0b963a93
PE
2649 * emacs.c: Don't assume string length fits in 'int'.
2650 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2651 (main): Don't invoke strlen when not needed.
2652
573f4b54
PE
2653 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2654 (XD_DEBUG_MESSAGE): Don't waste a byte.
2655
989f33ba
PE
2656 * callproc.c (getenv_internal_1, getenv_internal)
2657 (Fgetenv_internal):
965d34eb
PE
2658 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2659
e4d29b33
PE
2660 * lread.c (invalid_syntax): Omit length argument.
2661 All uses changed. This doesn't fix a bug, but it simplifies the
2662 code away from its former Hollerith-constant appearance, and it's
2663 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2664 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2665
eb49b136
PE
2666 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2667 This didn't break anything, but it didn't help either.
2668 It's confusing to put a bogus integer in a place where the actual
2669 value does not matter.
9f62aeb1 2670 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2671 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2672
15375a22
PE
2673 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2674 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2675 implementation.
b61cc01c
PE
2676 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2677 We prefer signed types, and the value cannot exceed the EMACS_INT
2678 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2679 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2680 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2681 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2682
53b2623d
PE
2683 * indent.c (sane_tab_width): New function.
2684 (current_column, scan_for_column, Findent_to, position_indentation)
2685 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2686 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2687
51cab52b 2688 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2689
f2ed8a70
PE
2690 * lisp.h (lint_assume): New macro.
2691 * composite.c (composition_gstring_put_cache):
2692 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2693
abe80cc6
PE
2694 * editfns.c, insdel.c:
2695 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2696
b02c740e
PE
2697 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2698
ebc96716
PE
2699 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2700
b4e50fa0 2701 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2702 Use much-faster test for byte-length change.
311d5d7c 2703 Don't assume string byte-length fits in 'int'.
a4cf38e4 2704 Check that character arg fits in 'int'.
85461888 2705 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2706
c0c1ee9f
PE
2707 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2708
a498d7f4
PE
2709 * fns.c (concat): Catch string overflow earlier.
2710 Do not rely on integer wraparound.
2711
51cab52b
PE
2712 * dispextern.h (struct it.overlay_strings_charpos)
2713 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2714 * xdisp.c (forward_to_next_line_start)
2715 (back_to_previous_visible_line_start)
2716 (reseat_at_next_visible_line_start, next_element_from_buffer):
2717 Don't arbitrarily truncate the value of 'selective' to int.
2718
76031fad
PE
2719 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2720
5eb55db9
PE
2721 * composite.c: Don't truncate sizes to 'int'.
2722 (composition_gstring_p, composition_reseat_it)
2723 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2724 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2725 not EMACS_UINT, for indexes.
5eb55db9 2726
0703a717
PE
2727 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2728
d6202519
PE
2729 * buffer.c: Include <verify.h>.
2730 (struct sortvec.priority, struct sortstr.priority):
8961a454 2731 Now EMACS_INT, not int.
c20998a7 2732 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2733 (struct sortstr.size, record_overlay_string)
2734 (struct sortstrlist.size, struct sortlist.used):
2735 Don't truncate size to int.
2736 (record_overlay_string): Check for size-calculation overflow.
d6202519 2737 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2738
d5a19415
JM
27392011-06-22 Jim Meyering <meyering@redhat.com>
2740
029529ac 2741 Don't leak an XBM-image-sized buffer
d5a19415
JM
2742 * image.c (xbm_load): Free the image buffer after using it.
2743
a9041e6c
PE
27442011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 Port to Sun C.
2747 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2748 that Sun C diagnosed.
2749 * fns.c (secure_hash): Fix pointer signedness issue.
2750 * intervals.c (static_offset_intervals): New function.
2751 (offset_intervals): Use it.
2752
7f3f739f
LL
27532011-06-21 Leo Liu <sdl.web@gmail.com>
2754
2755 * deps.mk (fns.o):
2756 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2757 sha512.h.
2758
2759 * fns.c (secure_hash): Rename from crypto_hash_function and change
2760 the first arg to accept symbols.
5b66d427 2761 (Fsecure_hash): New primitive.
7f3f739f
LL
2762 (syms_of_fns): New symbols.
2763
76147d94
DD
27642011-06-20 Deniz Dogan <deniz@dogan.se>
2765
2766 * process.c (Fset_process_buffer): Clarify return value in
2767 docstring.
2768
7d7d0045
CY
27692011-06-18 Chong Yidong <cyd@stupidchicken.com>
2770
2771 * dispnew.c (add_window_display_history): Use BVAR.
2772
2773 * xdisp.c (debug_method_add): Use BVAR.
2774 (check_window_end, dump_glyph_matrix, dump_glyph)
2775 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2776
2777 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2778 Likewise.
2779
2780 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2781 check till after the cache is created in init_frame_faces.
2782
ff2bc410
SM
27832011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2784
2785 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2786
28177add
PE
27872011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2788
dd3482fe
PE
2789 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2790 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2791 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2792
393d71f3 2793 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2794 * fileio.c (Finsert_file_contents):
2795 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2796 Remove the old (too-loose) buffer overflow checks.
2797 They weren't needed, since make_gap checks for buffer overflow.
2798 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2799 The old code merely checked for Emacs fixnum overflow, and relied
2800 on undefined (wraparound) behavior. The new code avoids undefined
2801 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2802
2e6813b0 2803 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2804 Tune. Don't use wider integers than needed. Don't use alloca.
2805 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2806
599a9e4f
PE
2807 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2808
99561444
PE
2809 * insdel.c, lisp.h (buffer_overflow): New function.
2810 (insert_from_buffer_1, replace_range, replace_range_2):
2811 * insdel.c (make_gap_larger):
2812 * editfns.c (Finsert_char):
2813 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2814
28177add
PE
2815 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2816
e69dafad
PE
28172011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2818
a7af7fde 2819 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2820
b1c46f02
PE
2821 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2822 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2823
e69dafad
PE
2824 * fileio.c: Don't assume EMACS_INT fits in off_t.
2825 (emacs_lseek): New static function.
2826 (Finsert_file_contents, Fwrite_region): Use it.
2827 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2828
566684ea
PE
2829 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2830
e6966cd6
PE
2831 * fns.c: Don't overflow int when computing a list length.
2832 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2833 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2834 truncation on 64-bit hosts. Check for QUIT every
2835 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2836 faster and is responsive enough.
2837 (Flength): Report an error instead of overflowing an integer.
2838 (Fsafe_length): Return a float if the value is not representable
2839 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2840 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2841 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2842
dd0b0efb
PE
2843 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2844 (header_size, word_size): New constants.
2845 (allocate_vectorlike): Don't check size overflow here.
2846 (allocate_vector): Check it here instead, since this is the only
2847 caller of allocate_vectorlike that could cause overflow.
2848 Check that the new vector's length is representable as a fixnum.
2849
86fe5cfe
PE
2850 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2851 The previous code was bogus. For example, next_almost_prime (32)
2852 returned 39, which is undesirable as it is a multiple of 3; and
2853 next_almost_prime (24) returned 25, which is a multiple of 5 so
2854 why was the code bothering to check for multiples of 7?
2855
80e88859
PE
2856 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2857
4a2f0ad6
PE
2858 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2859
f66c7cf8
PE
2860 Variadic C functions now count arguments with ptrdiff_t.
2861 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2862 Back then I didn't know that the Emacs coding style prefers signed int.
2863 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2864 were being counted with int, which may truncate counts on 64-bit
2865 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2866 * lisp.h (struct Lisp_Subr.function.aMANY)
2867 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2868 Arg counts are now ptrdiff_t, not size_t.
2869 All variadic functions and their callers changed accordingly.
2870 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2871 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2872 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2873 * callint.c (Fcall_interactively): Check arg count for overflow,
2874 to avoid potential buffer overrun. Use signed char, not 'int',
2875 for 'varies' array, so that we needn't bother to check its size
2876 calculation for overflow.
2877 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2878 * eval.c (apply_lambda):
2879 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2880 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2881 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2882
a1759b76
PE
2883 * callint.c (Fcall_interactively): Don't use index var as event count.
2884
d96be9fc
PE
2885 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2886 * mem-limits.h (SIZE): Remove; no longer used.
2887
a690a978 2888 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2889
578c21e6
PE
2890 Remove unnecessary casts.
2891 * xterm.c (x_term_init):
2892 * xfns.c (x_set_border_pixel):
2893 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2894 These aren't needed now that we assume ANSI C.
2895
96f53c6c
PE
2896 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2897 It's more likely to cause problems (due to unsigned overflow)
2898 than to cure them.
2899
83c77d31
PE
2900 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2901
ee2079f1
PE
2902 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2903
6da65536
PE
2904 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2905
7147c4a4
PE
2906 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2907
193e32d9
PE
2908 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2909
e5533da6
PE
2910 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2911
9910e595
PE
2912 GLYPH_CODE_FACE returns EMACS_INT, not int.
2913 * dispextern.h (merge_faces):
2914 * xfaces.c (merge_faces):
01103c44
PE
2915 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2916 Don't assume EMACS_INT fits in int.
9910e595 2917
2638320e
PE
2918 * character.h (CHAR_VALID_P): Remove unused parameter.
2919 * fontset.c, lisp.h, xdisp.c: All uses changed.
2920
045eb8d9
PE
2921 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2922
c1f134b5
PE
2923 * fns.c (concat): Minor tuning based on overflow analysis.
2924 This doesn't fix any bugs. Use int to hold character, instead
2925 of constantly refetching from Emacs object. Use XFASTINT, not
2926 XINT, for value known to be a character. Don't bother comparing
2927 a single byte to 0400, as it's always less.
2928
395fcb93 2929 * floatfns.c (Fexpt):
327eeec8
PE
2930 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2931
abbd3d23
PE
2932 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2933 for characters.
2934
684a03ef
PE
2935 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2936
0fed43f3
PE
2937 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2938 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2939 incorrectly succeed when S was a string, because 4294967386 was
2940 truncated before it was used.
2941
8fd02eb7
PE
2942 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2943 Otherwise, an out-of-range integer could cause undefined behavior
2944 on a 64-bit host.
2945
f8c86b69
PE
2946 * composite.c: Use int, not EMACS_INT, for characters.
2947 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2948 EMACS_INT, for values that are known to be in character range.
2949 This doesn't fix any bugs but is the usual style inside Emacs and
2950 may generate better code on 32-bit machines.
2951
34206dd2
PE
2952 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2953 This is for reasons similar to the recent CHAR_STRING fix.
2954 * charset.c (Fencode_char): Check that character arg is actually
2955 a character. Pass an int to ENCODE_CHAR.
2956 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2957 wider than 'int', as a compile-time check to prevent future regressions
2958 in this area.
2959
c5958d4c 2960 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2961
2962 Make sure a 64-bit char is never passed to CHAR_STRING.
2963 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2964 by silently ignoring the top 32 bits, allowing some values
2965 that were far too large to be valid characters.
2966 * character.h: Include <verify.h>.
2967 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2968 arguments are no wider than unsigned, as a compile-time check
2969 to prevent future regressions in this area.
2970 * data.c (Faset):
01103c44 2971 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2972 (Fsubst_char_in_region):
2973 * fns.c (concat):
2974 * xdisp.c (decode_mode_spec_coding):
2975 Adjust to CHAR_STRING's new requirement.
2976 * editfns.c (Finsert_char, Fsubst_char_in_region):
2977 * fns.c (concat): Check that character args are actually
2978 characters. Without this test, these functions did the wrong
2979 thing with wildly out-of-range values on 64-bit hosts.
2980
d37ca623
PE
2981 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2982 These casts should not be needed on 32-bit hosts, either.
2983 * keyboard.c (read_char):
2984 * lread.c (Fload): Remove casts to unsigned.
2985
ea204efb
PE
2986 * lisp.h (UNSIGNED_CMP): New macro.
2987 This fixes comparison bugs on 64-bit hosts.
2988 (ASCII_CHAR_P): Use it.
2989 * casefiddle.c (casify_object):
01103c44 2990 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2991 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2992 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2993 * dispextern.h (FACE_FROM_ID):
2994 * keyboard.c (read_char): Use UNSIGNED_CMP.
2995
41cb286c
PE
2996 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2997 not to EMACS_INT, to avoid GCC warning.
2998
4a1b9832
PE
2999 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3000
55daad71
PE
3001 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3002 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3003 isn't needed on 32-bit machines.
8f95c75c 3004
01103c44
PE
3005 * buffer.c (Fgenerate_new_buffer_name):
3006 Use EMACS_INT for count, not int.
0ceccced 3007 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3008
3009 * data.c (Qcompiled_function): Now static.
3010
c6f072e7
PE
3011 * window.c (window_body_lines): Now static.
3012
20ce5912
PE
3013 * image.c (gif_load): Rename local to avoid shadowing.
3014
9c4c5f81
PE
3015 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3016 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3017 * alloc.c (make_save_value): Integer argument is now of type
3018 ptrdiff_t, not int.
3019 (mark_object): Use ptrdiff_t, not int.
3020 * lisp.h (pD): New macro.
3021 * print.c (print_object): Use it.
3022
c0c5c8ae
PE
3023 * alloc.c: Use EMACS_INT, not int, to count objects.
3024 (total_conses, total_markers, total_symbols, total_vector_size)
3025 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3026 (total_free_floats, total_floats, total_free_intervals)
3027 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3028 Now EMACS_INT, not int. All uses changed.
3029 (Fgarbage_collect): Compute overall total using a double, so that
3030 integer overflow is less likely to be a problem. Check for overflow
3031 when converting back to an integer.
5a25e253
PE
3032 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3033 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3034 These were 'int' variables that could overflow on 64-bit hosts;
3035 they were never used, so remove them instead of repairing them.
211a0b2a 3036 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3037 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3038 Previously, this ceilinged at INT_MAX, but that doesn't work on
3039 64-bit machines.
e46bb31a 3040 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3041
c78baabf 3042 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3043 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3044 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3045 when a (possibly-narrower) signed value would do just as well.
3046 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3047
c9d624c6
PE
3048 * alloc.c: Catch some string size overflows that we were missing.
3049 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3050 for convenience in STRING_BYTES_MAX.
3051 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3052 The definition here is exact; the one in lisp.h was approximate.
3053 (allocate_string_data): Check for string overflow. This catches
3054 some instances we weren't catching before. Also, it catches
3055 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3056 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3057 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3058
c9d624c6
PE
3059 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3060 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3061 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3062
353032ce
PE
3063 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3064
2bccce07
PE
3065 * alloc.c (Fmake_string): Check for out-of-range init.
3066
0ac30604
SM
30672011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3068
3069 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3070
c195f2de
JD
30712011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3072
3073 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3074 xg_get_default_scrollbar_width.
3075
3076 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3077 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3078 (style_changed_cb): Call update_theme_scrollbar_width and call
3079 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3080 all frames (Bug#8505).
3081 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3082 Call gtk_window_set_resizable if HAVE_GTK3.
3083 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3084 and height if HAVE_GTK3 (Bug#8505).
3085 (scroll_bar_width_for_theme): New variable.
3086 (update_theme_scrollbar_width): New function.
3087 (xg_get_default_scrollbar_width): Move code to
3088 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3089 (xg_initialize): Call update_theme_scrollbar_width.
3090
3091 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3092
3093 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3094
e10ac9f1
MR
30952011-06-12 Martin Rudalics <rudalics@gmx.at>
3096
3097 * frame.c (make_frame): Call other_buffer_safely instead of
3098 other_buffer.
3099
3100 * window.c (temp_output_buffer_show): Call display_buffer with
3101 second argument Vtemp_buffer_show_specifiers and reset latter
3102 immediately after the call.
3103 (Vtemp_buffer_show_specifiers): New variable.
3104 (auto_window_vscroll_p, next_screen_context_lines)
3105 (Vscroll_preserve_screen_position): Remove leading asterisks from
3106 doc-strings.
3107
2d3c217e 31082011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3109
7b7f97e8 3110 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3111 * buffer.c (Qclone_number): Remove for now, as it's unused.
3112 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3113 (record_buffer): Remove unused local.
3114 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3115 (set_frame_buffer_list): Remove; unused.
3116 * frame.h (other_visible_frames): Remove decl.
3117 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3118 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3119 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3120 if HAVE_GPM.
3121 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3122 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3123 Define only if HAVE_GPM.
3124 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3125 (update_hints_inhibit): Remove; never set. All uses removed.
3126 * widgetprv.h (emacsFrameClassRec): Remove decl.
3127 * window.c (delete_deletable_window): Now returns void, since it
3128 wasn't returning anything.
3129 (compare_window_configurations): Remove unused locals.
3130 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3131 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3132 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3133 the same widths as pointers. This follows up on the 2011-05-06 patch.
3134 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3135 * xterm.h: Likewise.
3136 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3137
1384b89e
JB
31382011-06-12 Juanma Barranquero <lekktu@gmail.com>
3139
3140 * makefile.w32-in: Update dependencies.
3141 (LISP_H): Add lib/intprops.h.
3142
1100a63c
CY
31432011-06-11 Chong Yidong <cyd@stupidchicken.com>
3144
3145 * image.c (gif_load): Add animation frame delay to the metadata.
3146 (syms_of_image): Use DEFSYM. New symbol `delay'.
3147
6198ccd0
MR
31482011-06-11 Martin Rudalics <rudalics@gmx.at>
3149
3150 * window.c (delete_deletable_window): Re-add.
3151 (Fset_window_configuration): Rewrite to handle dead buffers and
3152 consequently deletable windows.
3153 (window_tree, Fwindow_tree): Remove. Supply functionality in
3154 window.el.
3155 (compare_window_configurations): Simplify code.
3156
b6e3633c
AS
31572011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3158
1ab0dee5
AS
3159 * image.c (imagemagick_load_image): Fix type mismatch.
3160 (Fimagemagick_types): Likewise.
3161
b6e3633c
AS
3162 * window.h (replace_buffer_in_windows): Declare.
3163
9397e56f
MR
31642011-06-11 Martin Rudalics <rudalics@gmx.at>
3165
3166 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3167 Qclone_number. Remove external declaration of Qdelete_window.
3168 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3169 code.
640c8776
SM
3170 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3171 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3172 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3173 buffer list implementation.
3174 (other_buffer_safely): New function.
3175 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3176 calls to replace_buffer_in_windows and
3177 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3178 if allowed.
3179 (record_buffer): Inhibit quitting and rewrite using quittable
3180 functions. Run Qbuffer_list_update_hook if allowed.
3181 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3182 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3183 Move switch-to-buffer to window.el.
9397e56f
MR
3184 (bury-buffer): Move to window.el.
3185 (Vbuffer_list_update_hook): New variable.
3186
3187 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3188 section.
3189
3190 * window.h (resize_frame_windows): Move up in code.
3191 (Fwindow_frame): Remove EXFUN.
3192 (replace_buffer_in_all_windows): Remove prototype.
3193 (replace_buffer_in_windows_safely): Add prototype.
3194
3195 * window.c: Declare Qdelete_window static again. Move down
3196 declaration of select_count.
3197 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3198 (Fother_window): Move to window.el.
3199 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3200 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3201 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3202 window.el.
3203 (replace_buffer_in_windows): Implement by calling
3204 Qreplace_buffer_in_windows.
3205 (replace_buffer_in_all_windows): Remove with some functionality
3206 moved into replace_buffer_in_windows_safely.
3207 (replace_buffer_in_windows_safely): New function.
3208 (select_window_norecord, select_frame_norecord): Move in front
3209 of run_window_configuration_change_hook. Remove now obsolete
3210 declarations.
640c8776
SM
3211 (Fset_window_buffer): Rewrite doc-string.
3212 Call Qrecord_window_buffer.
9397e56f
MR
3213 (keys_of_window): Move binding for other-window to window.el.
3214
b50691aa
CY
32152011-06-11 Chong Yidong <cyd@stupidchicken.com>
3216
3217 * dispextern.h (struct image): Replace data member, whose int_val
3218 and ptr_val fields were not used by anything, with a single
3219 lisp_val object.
3220
3221 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3222 (gif_clear_image, gif_load, imagemagick_load_image)
3223 (gs_clear_image, gs_load): Callers changed.
3224
3f754b86
PE
32252011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3226
cca69397
PE
3227 * buffer.h: Include <time.h>, for time_t.
3228 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3229
109e28d0
PE
3230 Fix minor problems found by static checking.
3231
60737f02
PE
3232 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3233
4b66faf3
PE
3234 Make identifiers static if they are not used in other modules.
3235 * data.c (Qcompiled_function, Qframe, Qvector):
3236 * image.c (QimageMagick, Qsvg):
3237 * minibuf.c (Qmetadata):
3238 * window.c (resize_window_check, resize_root_window): Now static.
3239 * window.h (resize_window_check, resize_root_window): Remove decls.
3240
109e28d0
PE
3241 * window.c (window_deletion_count, delete_deletable_window):
3242 Remove; unused.
46a4ce9e
PE
3243 (window_body_lines): Now static.
3244 (Fdelete_other_windows_internal): Mark vars as initialized.
3245 Make sure 'resize_failed' is initialized.
3246 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3247 (resize_window_apply): Remove unused local.
3248 * window.h (delete_deletable_window): Remove decl.
3249
109e28d0 3250 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3251 (imagemagick_load_image): Fix pointer signedness problem by changing
3252 last arg from unsigned char * to char *. All uses changed.
3253 Also, fix a local for similar reasons.
3254 Remove unused locals. Remove locals to avoid shadowing.
3255 (fn_rsvg_handle_free): Remove; unused.
3256 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3257 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3258
3f754b86
PE
3259 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3260
2547adb1
CY
32612011-06-10 Chong Yidong <cyd@stupidchicken.com>
3262
3263 * image.c (gif_load): Fix omitted cast error introduced by
3264 2011-06-06 change.
3265
2c8e37d4
MR
32662011-06-10 Martin Rudalics <rudalics@gmx.at>
3267
3268 * window.h (resize_proportionally, orig_total_lines)
3269 (orig_top_line): Remove from window structure.
3270 (set_window_height, set_window_width, change_window_heights)
3271 (Fdelete_window): Remove prototypes.
3272 (resize_frame_windows): Remove duplicate declaration.
3273
440a42e3
EZ
32742011-06-10 Eli Zaretskii <eliz@gnu.org>
3275
3276 * window.h (resize_frame_windows, resize_window_check)
3277 (delete_deletable_window, resize_root_window)
3278 (resize_frame_windows): Declare prototypes.
3279
3280 * window.c (resize_window_apply): Make definition be "static" to
3281 match the prototype.
3282
562dd5e9
MR
32832011-06-10 Martin Rudalics <rudalics@gmx.at>
3284
3285 * window.c: Remove declarations of Qwindow_size_fixed,
3286 window_min_size_1, window_min_size_2, window_min_size,
3287 size_window, window_fixed_size_p, enlarge_window, delete_window.
3288 Remove static from declaration of Qdelete_window, it's
3289 temporarily needed by Fbury_buffer.
3290 (replace_window): Don't assign orig_top_line and
3291 orig_total_lines.
3292 (Fdelete_window, delete_window): Remove. Window deletion is
3293 handled by window.el.
640c8776
SM
3294 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3295 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3296 (Fdelete_other_windows): Remove. Deleting other windows is
3297 handled by window.el.
3298 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3299 handled in window.el.
3300 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3301 Window minimum sizes are handled in window.el.
3302 (shrink_windows, size_window, set_window_height)
3303 (set_window_width, change_window_heights, window_height)
3304 (window_width, CURBEG, CURSIZE, enlarge_window)
3305 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3306 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3307 handled in window.el.
3308 (make_dummy_parent): Rename to make_parent_window and give it a
3309 second argument horflag.
3310 (make_window): Don't set resize_proportionally any more.
3311 (Fsplit_window): Remove. Windows are split in window.el.
3312 (save_restore_action, save_restore_orig_size)
3313 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3314 Resize mini windows in window.el.
3315 (grow_mini_window, shrink_mini_window): Implement by calling
3316 Qresize_root_window_vertically, resize_window_check and
3317 resize_window_apply.
640c8776
SM
3318 (saved_window, Fset_window_configuration, save_window_save):
3319 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3320 resize_proportionally.
3321 (window_min_height, window_min_width): Move to window.el.
3322 (keys_of_window): Move bindings for delete-other-windows,
3323 split-window, delete-window and enlarge-window to window.el.
3324
3325 * buffer.c: Temporarily extern Qdelete_window.
3326 (Fbury_buffer): Temporarily call Qdelete_window instead of
3327 Fdelete_window (Fbury_buffer will move to window.el soon).
3328
3329 * frame.c (set_menu_bar_lines_1): Remove code handling
3330 orig_top_line and orig_total_lines.
3331
3332 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3333 set_window_height but set heights directly.
3334 (change_frame_size_1): Use resize_frame_windows.
3335
3336 * xdisp.c (init_xdisp): Don't use set_window_height but set
3337 heights directly.
3338
640c8776
SM
3339 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3340 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3341 run_window_configuration_change_hook.
3342
3343 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3344 instead of change_window_heights and run
3345 run_window_configuration_change_hook.
3346
1a13852e
MR
33472011-06-09 Martin Rudalics <rudalics@gmx.at>
3348
3349 * window.c (replace_window): Rename second argument REPLACEMENT to
3350 NEW. New third argument SETFLAG. Rewrite.
3351 (delete_window, make_dummy_parent): Call replace_window with
3352 third argument 1.
3353 (window_list_1): Move down in code.
3354 (run_window_configuration_change_hook): Move set_buffer part
3355 before select_frame_norecord part in order to unwind correctly.
3356 Rename count1 to count.
3357 (recombine_windows, delete_deletable_window, resize_root_window)
3358 (Fdelete_other_windows_internal)
3359 (Frun_window_configuration_change_hook, make_parent_window)
3360 (resize_window_check, resize_window_apply, Fresize_window_apply)
3361 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3362 (Fdelete_window_internal, Fresize_mini_window_internal):
3363 New functions.
1a13852e
MR
3364 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3365
f3d1777e
MR
33662011-06-08 Martin Rudalics <rudalics@gmx.at>
3367
496e208e
MR
3368 * window.h (window): Add some new members to window structure -
3369 normal_lines, normal_cols, new_total, new_normal, clone_number,
3370 splits, nest, prev_buffers, next_buffers.
3371 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3372 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3373
f3d1777e
MR
3374 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3375 Remove.
496e208e
MR
3376 (make_dummy_parent): Set new members of windows structure.
3377 (make_window): Move down in code. Handle new members of window
3378 structure.
3379 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3380 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3381 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3382 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3383 (Fset_window_next_buffers, Fset_window_clone_number):
3384 New functions.
496e208e
MR
3385 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3386 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3387 Doc-string fixes.
3388 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3389 Argument WINDOW can be now internal window too.
3390 (Fwindow_use_time): Move up in code.
3391 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3392 Rewrite doc-string.
3393 (Fset_window_configuration, saved_window)
3394 (Fcurrent_window_configuration, save_window_save): Handle new
3395 members of window structure.
b9e809c2
MR
3396 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3397 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3398 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3399 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3400 Qget_mru_window, Qresize_root_window,
3401 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3402 Qauto_buffer_name; staticpro them.
f3d1777e 3403
abde8f8c
MR
34042011-06-07 Martin Rudalics <rudalics@gmx.at>
3405
3406 * window.c (Fwindow_total_size, Fwindow_left_column)
3407 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3408 (Fwindow_list_1): New functions.
3409 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3410 (Fwindow_width, Fscroll_left, Fscroll_right):
3411 Use window_body_cols instead of window_box_text_cols.
3412 (delete_window, Fset_window_configuration):
3413 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3414 (delete_all_subwindows): Take a window as argument and not a
3415 structure. Rewrite.
190b47e6
MR
3416 (window_loop): Remove handling of GET_LRU_WINDOW and
3417 GET_LARGEST_WINDOW.
3418 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3419
3420 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3421 window_box_text_cols. delete_all_subwindows now takes a
3422 Lisp_Object as argument.
abde8f8c 3423
640c8776
SM
3424 * indent.c (compute_motion, Fcompute_motion):
3425 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3426
fa8a67e6
MR
3427 * frame.c (delete_frame): Call delete_all_subwindows with root
3428 window as argument.
3429
a54e3482
DC
34302011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3431
3432 * fns.c (Fputhash): Document return value.
3433
60002bf5
CY
34342011-06-06 Chong Yidong <cyd@stupidchicken.com>
3435
3436 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3437
0c671da6 34382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3439
b862a52a 3440 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3441
be44ca6c
PE
3442 Check for overflow when converting integer to cons and back.
3443 * charset.c (Fdefine_charset_internal, Fdecode_char):
3444 Use cons_to_unsigned to catch overflow.
3445 (Fencode_char): Use INTEGER_TO_CONS.
3446 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3447 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3448 * data.c (long_to_cons, cons_to_long): Remove.
3449 (cons_to_unsigned, cons_to_signed): New functions.
3450 These signal an error for invalid or out-of-range values.
3451 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3452 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3453 * font.c (Ffont_variation_glyphs):
3454 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3455 * lisp.h: Include <intprops.h>.
3456 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3457 (cons_to_signed, cons_to_unsigned): New decls.
3458 (long_to_cons, cons_to_long): Remove decls.
3459 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3460 (Fprimitive_undo): Use CONS_TO_INTEGER.
3461 * xfns.c (Fx_window_property): Likewise.
3462 * xselect.c: Include <limits.h>.
3463 (x_own_selection, selection_data_to_lisp_data):
3464 Use INTEGER_TO_CONS.
3465 (x_handle_selection_request, x_handle_selection_clear)
3466 (x_get_foreign_selection, Fx_disown_selection_internal)
3467 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3468 (lisp_data_to_selection_data): Use cons_to_unsigned.
3469 (x_fill_property_data): Use cons_to_signed.
3470 Report values out of range.
3471
d1f3d2af
PE
3472 Check for buffer and string overflow more precisely.
3473 * buffer.h (BUF_BYTES_MAX): New macro.
3474 * lisp.h (STRING_BYTES_MAX): New macro.
3475 * alloc.c (Fmake_string):
3476 * character.c (string_escape_byte8):
3477 * coding.c (coding_alloc_by_realloc):
3478 * doprnt.c (doprnt):
3479 * editfns.c (Fformat):
3480 * eval.c (verror):
3481 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3482 since they may not be the same number.
3483 * editfns.c (Finsert_char):
3484 * fileio.c (Finsert_file_contents):
3485 Likewise for BUF_BYTES_MAX.
3486
dd52fcea
PE
3487 * image.c: Use ptrdiff_t, not int, for sizes.
3488 (slurp_file): Switch from int to ptrdiff_t.
3489 All uses changed.
3490 (slurp_file): Check that file size fits in both size_t (for
3491 malloc) and ptrdiff_t (for sanity and safety).
3492
7f9bbdbb
PE
3493 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3494 if b->modtime has its maximal value.
3495
dfe18f82
PE
3496 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3497
84acfcf0
PE
3498 Don't assume time_t can fit into int.
3499 * buffer.h (struct buffer.modtime): Now time_t, not int.
3500 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3501 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3502
ccd9a01a
PE
3503 Minor fixes for signed vs unsigned integers.
3504 * character.h (MAYBE_UNIFY_CHAR):
3505 * charset.c (maybe_unify_char):
3506 * keyboard.c (read_char, reorder_modifiers):
3507 XINT -> XFASTINT, since the integer must be nonnegative.
3508 * ftfont.c (ftfont_spec_pattern):
3509 * keymap.c (access_keymap, silly_event_symbol_error):
3510 XUINT -> XFASTINT, since the integer must be nonnegative.
3511 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3512 since it makes no difference and we prefer signed.
3513 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3514 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3515 nonnegative.
3516
d6d100dd
SM
35172011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3518
3519 * window.h (Fwindow_frame): Declare.
3520
2b6148e4
PE
35212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3524 (SPARE_MEMORY): Always define.
3525 (LARGE_REQUEST): Remove.
3526 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3527
f230ecc9
MR
35282011-06-06 Martin Rudalics <rudalics@gmx.at>
3529
727e958e
MR
3530 * lisp.h: Move EXFUNS for Fframe_root_window,
3531 Fframe_first_window and Fset_frame_selected_window to window.h.
3532
3533 * window.h: Move EXFUNS for Fframe_root_window,
3534 Fframe_first_window and Fset_frame_selected_window here from
3535 lisp.h.
3536
3537 * frame.c (Fwindow_frame, Fframe_first_window)
3538 (Fframe_root_window, Fframe_selected_window)
3539 (Fset_frame_selected_window): Move to window.c.
3540 (Factive_minibuffer_window): Move to minibuf.c.
3541 (Fother_visible_frames_p): New function.
3542
3543 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3544
f230ecc9
MR
3545 * window.c (decode_window, decode_any_window): Move up in code.
3546 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3547 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3548 (Fwindow_buffer): Move up and rewrite doc-string.
3549 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3550 (Fwindow_prev): New functions.
727e958e
MR
3551 (Fwindow_frame): Move here from frame.c. Accept any window as
3552 argument.
3553 (Fframe_root_window, Fframe_first_window)
3554 (Fframe_selected_window): Move here from frame.c. Accept frame
3555 or arbitrary window as argument. Update doc-strings.
3556 (Fminibuffer_window): Move up in code.
3557 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3558 (Fset_frame_selected_window): Move here from frame.c.
3559 Marginal rewrite.
727e958e
MR
3560 (Fselected_window, select_window, Fselect_window): Move up in
3561 code. Minor doc-string fixes.
f230ecc9 3562
4d09bcf6
PE
35632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3566 Do not assume that spare memory exists; that assumption is valid
3567 only if SYSTEM_MALLOC.
3568 (LARGE_REQUEST): New macro, so that the issue of large requests
3569 is separated from the issue of spare memory.
3570
810928a2
AS
35712011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3572
172418ad
AS
3573 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3574 format. (Bug#8806)
3575
43f862f7
AS
3576 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3577
810928a2
AS
3578 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3579 before statements.
3580
a059fe24
JD
35812011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3582
3583 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3584
3585 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3586
3587 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3588 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3589
989bf368
JB
35902011-06-05 Juanma Barranquero <lekktu@gmail.com>
3591
3592 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3593
4b80f674
CY
35942011-06-04 Chong Yidong <cyd@stupidchicken.com>
3595
3596 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3597 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3598 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3599 New error handlers.
4b80f674
CY
3600 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3601 Obey Vx_select_enable_clipboard_manager. Catch errors in
3602 x_clipboard_manager_save (Bug#8779).
3603 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3604 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3605
99a33b77 36062011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3607
3608 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3609
99a33b77 36102011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3611
3612 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3613 in the current matrix if keep_current_p is non-zero.
3614
8264569d
EZ
36152011-06-04 Eli Zaretskii <eliz@gnu.org>
3616
3617 * bidi.c (bidi_level_of_next_char): Fix last change.
3618
57f97249
EZ
36192011-06-03 Eli Zaretskii <eliz@gnu.org>
3620
fec2107c 3621 Support bidi reordering of text covered by display properties.
57f97249 3622
fec2107c
EZ
3623 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3624 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3625 (bidi_cache_search, bidi_cache_iterator_state)
3626 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3627 (bidi_level_of_next_char, bidi_move_to_visually_next):
3628 Support character positions inside a run of characters covered by a
fec2107c
EZ
3629 display string.
3630 (bidi_paragraph_init, bidi_resolve_explicit_1)
3631 (bidi_level_of_next_char): Call bidi_fetch_char and
3632 bidi_fetch_char_advance instead of FETCH_CHAR and
3633 FETCH_CHAR_ADVANCE.
3634 (bidi_init_it): Initialize new members.
3635 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3636 definitions.
3637 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3638 instead of using explicit *_CHAR codes.
d6d100dd
SM
3639 (bidi_resolve_explicit, bidi_resolve_weak):
3640 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3641 bidirectional text is supported only in multibyte buffers.
3642 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3643 it to initialize the frame_window_p member of struct bidi_it.
3644 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3645 (bidi_resolve_explicit, bidi_resolve_weak)
3646 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3647 bidi_it->nchars is non-positive.
3648 (bidi_level_of_next_char): Don't try to lookup the cache for the
3649 next/previous character if nothing is cached there yet, or if we
3650 were just reseat()'ed to a new position.
c40e2fb2 3651
0e14fe90
EZ
3652 * xdisp.c (set_cursor_from_row): Set start and stop points
3653 according to the row's direction when priming the loop that looks
3654 for the glyph on which to display cursor.
3655 (single_display_spec_intangible_p): Function deleted.
3656 (display_prop_intangible_p): Reimplement to call
3657 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3658 Accept 3 additional arguments needed by handle_display_spec.
3659 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3660 values: lists, `(when COND...)' forms, etc.
3661 (single_display_spec_string_p): Support property values that are
3662 lists with the argument STRING its top-level element.
3663 (display_prop_string_p): Fix the condition for processing a
3664 property that is a list to be consistent with handle_display_spec.
fec2107c 3665 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3666 last portion of handle_display_prop.
3667 (compute_display_string_pos): Accept additional argument
3668 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3669 value of a `display' property is a "replacing spec".
3670 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3671 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3672 the display property, but just return a value indicating whether
3673 the display property will replace the characters it covers.
3674 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3675 frame_window_p members of struct bidi_it.
d6d100dd
SM
3676 (compute_display_string_pos, compute_display_string_end):
3677 New functions.
fec2107c
EZ
3678 (push_it): Accept second argument POSITION, where pop_it should
3679 jump to continue iteration.
3680 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3681
fec2107c
EZ
3682 * keyboard.c (adjust_point_for_property): Adjust the call to
3683 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3684
3685 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3686 (bidi_init_it): Update prototypes.
3687 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3688 (compute_display_string_pos, compute_display_string_end):
3689 Declare prototypes.
fec2107c
EZ
3690 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3691 EMACS_INT.
fc6f18ce 3692
40087514 36932011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3694
57f53182
PE
3695 Malloc failure behavior now depends on size of allocation.
3696 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3697 * lisp.h: Change signatures accordingly.
3698 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3699 All callers changed. (Bug#8762)
3700
3701 * gnutls.c: Use Emacs's memory allocators.
3702 Without this change, the gnutls library would invoke malloc etc.
3703 directly, which causes problems on non-SYNC_INPUT hosts, and which
3704 runs afoul of improving memory_full behavior. (Bug#8761)
3705 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3706 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3707 xfree instead of the default malloc, realloc, free.
3708 (Fgnutls_boot): No need to check for memory allocation failure,
3709 since xmalloc does that for us.
3710
ac32cd99 3711 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3712 * category.c (hash_get_category_set):
3713 * ccl.c (ccl_driver):
3714 * charset.c (Fdefine_charset_internal):
3715 * charset.h (struct charset.hash_index):
3716 * composite.c (get_composition_id, gstring_lookup_cache)
3717 (composition_gstring_put_cache):
3718 * composite.h (struct composition.hash_index):
3719 * dispextern.h (struct image.hash):
3720 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3721 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3722 (hashfn_equal, hashfn_user_defined, make_hash_table)
3723 (maybe_resize_hash_table, hash_lookup, hash_put)
3724 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3725 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3726 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3727 * image.c (make_image, search_image_cache, lookup_image)
3728 (xpm_put_color_table_h):
3729 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3730 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3731 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3732 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3733 * alloc.c (allocate_vectorlike):
3734 Check for overflow in vector size calculations.
3735 * ccl.c (ccl_driver):
3736 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3737 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3738 need to be updated by these changes.
40087514
PE
3739 * fns.c (make_hash_table, maybe_resize_hash_table):
3740 Check for integer overflow with large hash tables.
0de4bb68
PE
3741 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3742 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3743 (SXHASH_REDUCE): New macro.
3744 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3745 Use it instead of discarding useful hash info with large hash values.
3746 (sxhash_float): New function.
3747 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3748 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3749 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3750 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3751 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3752 Adjust signatures to match updated version of code.
3753 (consing_since_gc): Now EMACS_INT, since a single hash table can
3754 use more than INT_MAX bytes.
3755
698d32e2
DN
37562011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3757
3758 Make it possible to build with GCC-4.6+ -O2 -flto.
3759
3760 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3761
fd6fa53f
SM
37622011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3763
3764 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3765 Call minibuffer-inactive-mode.
3766
864db017
JB
37672011-05-31 Juanma Barranquero <lekktu@gmail.com>
3768
3769 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3770 Update dependencies.
3771
2ad0baf4
DN
37722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3773
3774 * data.c (init_data): Remove code for UTS, this system is not
3775 supported anymore.
3776
4fcc2638
DN
37772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3778
3779 Don't force ./temacs to start in terminal mode.
3780
3781 * frame.c (make_initial_frame): Initialize faces in all cases, not
3782 only when CANNOT_DUMP is defined.
3783 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3784
c56e0fd5
DN
37852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3786
3787 * dispnew.c (add_window_display_history): Use const for the string
3788 pointer. Remove declaration, not needed.
3789
333d54da 37902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3791
55d4c1b2 3792 Use 'inline', not 'INLINE'.
333d54da 3793 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3794 * alloc.c, fontset.c (INLINE): Remove.
3795 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3796 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3797 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3798 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3799 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3800
738db178
DN
38012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3802
3803 Make it possible to run ./temacs.
3804
3805 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3806 syms_of_callproc does the same thing. Remove test for
3807 "initialized", do it in the caller.
3808 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3809
620c53a6
SM
38102011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3811
3812 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3813 (read_minibuf): Use get_minibuffer.
3814 (syms_of_minibuf): Use DEFSYM.
3815 (Qmetadata): New var.
3816 * data.c (Qbuffer): Don't make it static.
3817 (syms_of_data): Use DEFSYM.
3818
e003a292
PE
38192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3820
3821 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3822 (CCL_CODE_MIN): New macro.
3823
ed008a6d
PE
38242011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3825
3687c2ef
PE
3826 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3827
ed008a6d
PE
3828 * eval.c (Qdebug): Now static.
3829 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3830 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3831 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3832
d66c4c7c
CY
38332011-05-29 Chong Yidong <cyd@stupidchicken.com>
3834
3835 * image.c: Various fixes to ImageMagick code comments.
3836 (Fimagemagick_types): Doc fix.
3837
5fbc2025
PE
38382011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3839
0196f88a
PE
3840 Minor fixes prompted by GCC 4.6.0 warnings.
3841
3842 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3843
5fbc2025
PE
3844 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3845 (x_clipboard_manager_save_all): Move extern decl to ...
3846 * xterm.h: ... here, so that it can be checked for consistency.
3847
1dd3c2d9
CY
38482011-05-29 Chong Yidong <cyd@stupidchicken.com>
3849
3850 * xselect.c (x_clipboard_manager_save_frame)
3851 (x_clipboard_manager_save_all): New functions.
3852 (Fx_clipboard_manager_save): Lisp function deleted.
3853
3854 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3855 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3856
3857 * xterm.h: Update prototype.
3858
5ba6571d
WX
38592011-05-28 William Xu <william.xwl@gmail.com>
3860
3861 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3862 exiting (Bug#8239).
3863
3eaff834
JM
38642011-05-28 Jim Meyering <meyering@redhat.com>
3865
e1900994 3866 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3867 * fns.c (to_uchar): Define.
3868 (crypto_hash_function): Use it to convert some newly-signed
3869 variables to unsigned, to avoid sign-extension bugs. For example,
3870 without this change, (md5 "truc") would evaluate to
3871 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3872 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3873 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3874
0f6990a7
PE
38752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 Integer overflow fixes.
c8a9ca5a 3878
08686060
PE
3879 * dbusbind.c: Serial number integer overflow fixes.
3880 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3881 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3882 to hold a serial number that is too large for a fixnum.
3883 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3884 Check for serial numbers out of range. Decode any serial number
59568bf0 3885 that was so large that it became a float. (Bug#8722)
08686060 3886
2d1fc3c7
PE
3887 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3888 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3889 Use XFASTINT rather than XUINT when numbers are nonnegative.
3890 (xd_append_arg, Fdbus_method_return_internal):
3891 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3892 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3893 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3894 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3895 (Bug#8722)
2d1fc3c7 3896
c8a9ca5a
PE
3897 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3898
519e1d69
PE
3899 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3900
30569699
PE
3901 ccl: add integer overflow checks
3902 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3903 (IN_INT_RANGE): New macros.
3904 (ccl_driver): Use them to check for integer overflow when
3905 decoding a CCL program. Many of the new checks are whether XINT (x)
3906 fits in int; it doesn't always, on 64-bit hosts. The new version
3907 doesn't catch all possible integer overflows, but it's an
847044ea 3908 improvement. (Bug#8719)
30569699 3909
c11285dc
PE
3910 * alloc.c (make_event_array): Use XINT, not XUINT.
3911 There's no need for unsigned here.
3912
fdccd48e
PE
3913 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3914 This follows up to the 2011-05-06 change that substituted uintptr_t
3915 for EMACS_INT. This case wasn't caught back then.
3916
37910ab2
PE
3917 Rework Fformat to avoid integer overflow issues.
3918 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3919 now (part of C89). Include <verify.h>.
3920 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3921 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3922 (Fformat): Avoid the prepass trying to compute sizes; it was only
3923 approximate and thus did not catch overflow reliably. Instead, walk
3924 through the format just once, formatting and computing sizes as we go,
3925 checking for integer overflow at every step, and allocating a larger
3926 buffer as needed. Keep track separately whether the format is
3927 multibyte. Keep only the most-recently calculated precision, rather
3928 than them all. Record whether each argument has been converted to
3929 string. Use EMACS_INT, not int, for byte and char and arg counts.
3930 Support field widths and precisions larger than INT_MAX. Avoid
3931 sprintf's undefined behavior with conversion specifications such as %#d
3932 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3933 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3934 formatting out-of-range floating point numbers with int
9173deec 3935 formats. (Bug#8668)
37910ab2 3936
2e6578fb
PE
3937 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3938
0ae6bdee
PE
3939 * data.c: Avoid integer truncation in expressions involving floats.
3940 * data.c: Include <intprops.h>.
3941 (arith_driver): When there's an integer overflow in an expression
3942 involving floating point, convert the integers to floating point
3943 so that the resulting value does not suffer from catastrophic
3944 integer truncation. For example, on a 64-bit host (* 4
3945 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3946 Do not rely on undefined behavior after integer overflow.
3947
de883a70
PE
3948 merge count_size_as_multibyte, parse_str_to_multibyte
3949 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3950 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3951 Check for integer overflow.
3952 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3953 since it's now a duplicate of the other. This is more of
3954 a character than a buffer op, so better that it's in character.c.
3955 * fns.c, print.c: Adjust to above changes.
3956
2ff916cb
PE
39572011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3958
3959 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3960
f1b54466
PE
39612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3962
fb1ac845
PE
3963 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3964 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3965 (x_clipboard_manager_save): Now static.
3966 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3967
f1b54466
PE
3968 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3969 (crypto_hash_function): Now static.
3970 Fix pointer signedness problems. Avoid unnecessary initializations.
3971
a9f737ee
CY
39722011-05-27 Chong Yidong <cyd@stupidchicken.com>
3973
3974 * termhooks.h (Vselection_alist): Make it terminal-local.
3975
3976 * terminal.c (create_terminal): Initialize it.
3977
3978 * xselect.c: Support for clipboard managers.
3979 (Vselection_alist): Move to termhooks.h as terminal-local var.
3980 (LOCAL_SELECTION): New macro.
3981 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3982 (symbol_to_x_atom): Remove gratuitous arg.
3983 (x_handle_selection_request, lisp_data_to_selection_data)
3984 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3985 (x_own_selection, x_get_local_selection, x_convert_selection):
3986 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3987 (some_frame_on_display): Delete unused function.
3988 (Fx_own_selection_internal, Fx_get_selection_internal)
3989 (Fx_disown_selection_internal, Fx_selection_owner_p)
3990 (Fx_selection_exists_p): New optional frame arg.
3991 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3992 (x_handle_selection_clear): Don't treat other terminals with the
3993 same keyboard specially. Use the terminal-local Vselection_alist.
3994 (x_clear_frame_selections): Use Frun_hook_with_args.
3995
3996 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3997
3998 * xterm.h: Add support for those atoms.
3999
e067f0c1
CY
40002011-05-26 Chong Yidong <cyd@stupidchicken.com>
4001
4002 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4003 (converted_selections, conversion_fail_tag): New global variables.
4004 (x_selection_request_lisp_error): Free the above.
4005 (x_get_local_selection): Remove unnecessary code.
4006 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4007 of converted selections stored in converted_selections.
4008 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4009 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4010 (x_convert_selection): New function.
4011 (x_handle_selection_event): Simplify.
4012 (x_get_foreign_selection): Don't ignore incoming requests while
4013 waiting for an answer; this will fail when we implement
4014 SAVE_TARGETS, and seems unnecessary anyway.
4015 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4016 (Vx_sent_selection_functions): Doc fix.
4017
0f4aebc0
LL
40182011-05-26 Leo Liu <sdl.web@gmail.com>
4019
4020 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4021
e61124cd
YM
40222011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4023
4024 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4025
4026 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4027 for fringe update if it has periodic bitmap.
ac389d0c 4028 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4029 and fringe_bitmap_periodic_p.
4030
4031 * fringe.c (get_fringe_bitmap_data): New function.
4032 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4033 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4034 row. Mark glyph row for fringe update if periodicity changed.
4035
4036 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4037 for fringe update unless it has periodic bitmap.
4038
f16d9837
KH
40392011-05-25 Kenichi Handa <handa@m17n.org>
4040
4041 * xdisp.c (get_next_display_element): Set correct it->face_id for
4042 a static composition.
4043
e1b90ef6
LL
40442011-05-24 Leo Liu <sdl.web@gmail.com>
4045
4046 * deps.mk (fns.o):
4047 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4048
4049 * fns.c (crypto_hash_function, Fsha1): New function.
4050 (Fmd5): Use crypto_hash_function.
4051 (syms_of_fns): Add Ssha1.
4052
7400048f
PE
40532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4054
4055 * gnutls.c: Remove unused macros.
4056 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4057 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4058 Remove macros that are defined and never used.
4059 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4060
abb71cf4
CY
40612011-05-22 Chong Yidong <cyd@stupidchicken.com>
4062
4063 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4064 (Fx_get_selection_internal): Minor cleanup.
4065 (Fx_own_selection_internal): Rename arguments for consistency with
4066 select.el.
4067
6307db39
PE
40682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4069
4070 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4071
f3d4e0a4
CY
40722011-05-22 Chong Yidong <cyd@stupidchicken.com>
4073
4074 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4075
4d8ade89
YM
40762011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4077
4078 * dispnew.c (scrolling_window): Don't exclude the case that the
4079 last enabled row in the desired matrix touches the bottom boundary.
4080
32078c8d
GM
40812011-05-21 Glenn Morris <rgm@gnu.org>
4082
4083 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4084 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4085 and add some more files.
32078c8d 4086
7285dc67
EZ
40872011-05-20 Eli Zaretskii <eliz@gnu.org>
4088
4089 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4090 report_file_error introduced by the change from 2011-05-07.
4091
89d1bd22
PE
40922011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4093
4094 * systime.h (Time): Define only if emacs is defined.
4095 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4096 where the include path doesn't have X11/X.h by default. See
4097 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4098
e23640bb 40992011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4100
4101 * composite.c (find_automatic_composition): Fix previous change.
4102
b9704ad9
GM
41032011-05-20 Glenn Morris <rgm@gnu.org>
4104
4105 * lisp.mk: New file, split from Makefile.in.
4106 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4107 (shortlisp): Remove.
4108 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4109
4a720484
GM
41102011-05-19 Glenn Morris <rgm@gnu.org>
4111
4112 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4113 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4114 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4115 (lisp): Set the order to that of loadup.el.
4116 (shortlisp): Make it a copy of $lisp.
4117 (SOME_MACHINE_LISP): Remove.
4118 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4119 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4120
a28d4396
KH
41212011-05-18 Kenichi Handa <handa@m17n.org>
4122
4123 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4124 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4125 (find_automatic_composition): Mostly rewrite for efficiency.
4126
a2b1fa8e
JB
41272011-05-18 Juanma Barranquero <lekktu@gmail.com>
4128
4129 * makefile.w32-in: Update dependencies.
4130
8e1f5610
CS
41312011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4132
4133 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4134 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4135
7025ee00 41362011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4137
cdfa6eab
PE
4138 Fix some integer overflow issues, such as string length overflow.
4139
06d6db33
PE
4140 * insdel.c (count_size_as_multibyte): Check for string overflow.
4141
2b4560a8
PE
4142 * character.c (lisp_string_width): Check for string overflow.
4143 Use EMACS_INT, not int, for string indexes and lengths; in
4144 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4145 the resulting string length overflows an EMACS_INT; instead,
4146 report a string overflow if no precision given. When checking for
4147 precision exhaustion, use a check that cannot possibly have
4148 integer overflow. (Bug#8675)
4149 * character.h (lisp_string_width): Adjust to new signature.
4150
cb93f9be
PE
4151 * alloc.c (string_overflow): New function.
4152 (Fmake_string): Use it. This doesn't change behavior, but saves
4153 a few bytes and will simplify future changes.
4154 * character.c (string_escape_byte8): Likewise.
4155 * lisp.h (string_overflow): New decl.
4156
1a1f3366
PE
4157 Fixups, following up to the user-interface timestamp change.
4158 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4159 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4160 * msdos.c (mouse_get_pos): Likewise.
4161 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4162 * w32gui.h (Time): Define by including "systime.h" rather than by
4163 declaring it ourselves. (Bug#8664)
4164
d4e3e4d3
PE
4165 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4166 * image.c (clear_image_cache): Likewise.
4167
f6a24d19
PE
4168 * term.c (term_mouse_position): Don't assume time_t wraparound.
4169
08dc5ae6
PE
4170 Be more systematic about user-interface timestamps.
4171 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4172 and sometimes 'EMACS_UINT', to represent these timestamps.
4173 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4174 This makes the code easier to follow, and makes it easier to catch
4175 integer overflow bugs such as Bug#8664.
4176 * frame.c (Fmouse_position, Fmouse_pixel_position):
4177 Use Time, not unsigned long, for user-interface timestamps.
4178 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4179 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4180 * keyboard.h (last_event_timestamp): Likewise.
4181 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4182 * menu.h (xmenu_show): Likewise.
4183 * term.c (term_mouse_position): Likewise.
4184 * termhooks.h (struct input_event.timestamp): Likewise.
4185 (struct terminal.mouse_position_hook): Likewise.
4186 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4187 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4188 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4189 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4190 what it was before.
4191 * menu.h, termhooks.h: Include "systime.h", for Time.
4192
8e55734a
PE
4193 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4194 Don't assume that the difference between two unsigned long values
4195 can fit into an integer. At this point, we know button_down_time
4196 <= event->timestamp, so the difference must be nonnegative, so
4197 there's no need to cast the result if double-click-time is
4198 nonnegative, as it should be; check that it's nonnegative, just in
4199 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4200 apart (about 25 days). (Bug#8664)
8e55734a 4201
841f1b75 4202 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4203 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4204
3e26f69c
PE
4205 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4206 that always fit in int. Use a sentinel instead of a counter, to
4207 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4208 * frame.h (struct frame): Use int for menu_bar_items_used
4209 instead of EMACS_INT, since it always fits in int.
3e26f69c 4210
5cc152c0
PE
4211 * menu.c (grow_menu_items): Check for int overflow.
4212
d89eb65e
PE
4213 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4214
5235bd3e
PE
4215 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4216 Before, the code was not consistent. These values cannot exceed
4217 2**31 - 1 so there's no need to make them unsigned.
4218 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4219 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4220 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4221 as modifiers.
4222 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4223
bc827e23
PE
4224 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4225 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4226 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4227 presumably because the widths might not match.
4228
78eb494e
PE
4229 * window.c (size_window): Avoid needless test at loop start.
4230
04f2d78b
CB
42312011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4232
4233 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4234
d2fc7e3d 42352011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4236
4237 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4238
d2fc7e3d 42392011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4240
4241 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4242 `width' to `bar_area_x' and `bar_area_width', respectively.
4243 (x_scroll_run): Take account of fringe background extension.
4244
04f2d78b
CB
4245 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4246 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4247 `bar_area_width', respectively.
4248 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4249 background extension.
4250
79b70037
GM
42512011-05-10 Jim Meyering <meyering@redhat.com>
4252
4253 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4254
2f142cc5
JB
42552011-05-10 Juanma Barranquero <lekktu@gmail.com>
4256
4257 * image.c (Finit_image_library): Return t for built-in image types,
4258 like pbm and xbm. (Bug#8640)
4259
57679c86
AS
42602011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4261
4262 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4263
888c9e86
EZ
42642011-05-07 Eli Zaretskii <eliz@gnu.org>
4265
b0512a1d
EZ
4266 * w32console.c (Fset_screen_color): Doc fix.
4267 (Fget_screen_color): New function.
4268 (syms_of_ntterm): Defsubr it.
4269
7285dc67
EZ
4270 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4271 unlink the temporary file if Fcall_process didn't create it in the
4272 first place.
4273 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4274 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4275 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4276 cue to call_process_cleanup not to close that handle.
4277
4d3fcc8e
BK
42782011-05-07 Ben Key <bkey76@gmail.com>
4279
4280 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4281 one of two shell specific rules, either bootstrap-temacs-CMD or
4282 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4283 to the previous implementation of the bootstrap-temacs rule.
4284 The bootstrap-temacs-CMD rule is similar to the previous
4285 implementation of the bootstrap-temacs rule except that it
4286 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4287 variable.
4288
4289 These changes, along with some changes to nt/configure.bat,
4290 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4291 earlier fix to add support for --cflags and --ldflags options
4292 that include quotes so that it works whether make uses cmd or
4293 sh as the shell.
4294
b4289b64
MA
42952011-05-06 Michael Albinus <michael.albinus@gmx.de>
4296
4297 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4298 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4299 is a constant.
4300 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4301 a string. Handle both cases.
4302 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4303 (Fdbus_register_method): Use Qinvalid_function.
4304
af4c0e28
JB
43052011-05-06 Juanma Barranquero <lekktu@gmail.com>
4306
4307 * makefile.w32-in: Update dependencies.
4308 (LISP_H): Add inttypes.h and stdin.h.
4309 (PROCESS_H): Add unistd.h.
4310
c51453d9
EZ
43112011-05-06 Eli Zaretskii <eliz@gnu.org>
4312
4313 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4314 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4315
8ff0ac3c 43162011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4317
4c4b566b
PE
4318 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4319
aab2b9b5
PE
4320 * term.c (vfatal): Remove stray call to va_end.
4321 It's not needed and the C Standard doesn't allow it here anyway.
4322
c378da0b
PE
4323 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4324 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4325
288b08c7
PE
4326 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4327 bytes.
4328
e3601888
PE
4329 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4330
db6c0e74
PE
4331 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4332
dd5963ea
PE
4333 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4334
88c9450f
PE
4335 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4336
2f9442b8
PE
4337 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4338
c032b5f8
PE
4339 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4340 * charset.c (Fdefine_charset_internal): Don't initialize
4341 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4342 32-bit int (Bug#8600).
a108c10b
PE
4343
4344 * lread.c (read_integer): Be more consistent with string-to-number.
4345 Use string_to_number to do the actual conversion; this avoids
4346 rounding errors and fixes some other screwups. Without this fix,
4347 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4348 (digit_to_number): Move earlier, for benefit of read_integer.
4349 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4350 not a digit in any supported base. (Bug#8602)
a108c10b 4351
ad5f9eea
PE
4352 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4353
aec1708a
PE
4354 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4355 to match comment at start of function. This also removes a
4356 GCC warning about overflow in a 32+64-bit port.
4357
47be4ab5
PE
4358 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4359
371cac43
PE
4360 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4361 Reported by Stefan Monnier in
4362 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4363 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4364 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4365
d01a7826
PE
4366 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4367 (EMACS_UINTPTR): Likewise, with uintptr_t.
4368
7fd47d5c
PE
4369 * lisp.h: Prefer 64-bit EMACS_INT if available.
4370 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4371 on 32-bit hosts that have 64-bit int, so that they can access
4372 large files.
122b0c86
PE
4373 However, temporarily disable this change unless the temporary
4374 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4375
8727937b
PE
4376 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4377
8ac068ac
PE
4378 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4379 This removes an assumption that EMACS_INT and long are the same
4380 width as pointers. The assumption is true for Emacs porting targets
4381 now, but we want to make other targets possible.
4382 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4383 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4384 In the rest of the code, change types of integers that hold casted
4385 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4386 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4387 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4388 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4389 No need to cast type when ORing.
4390 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4391 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4392 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4393 assume EMACS_INT is the same width as char *.
4394 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4395 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4396 Remove no-longer-needed casts.
4397 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4398 (xg_tool_bar_help_callback, xg_make_tool_item):
4399 Use EMACS_INTPTR to hold an integer
4400 that will be cast to void *; this can avoid a GCC warning
4401 if EMACS_INT is not the same width as void *.
4402 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4403 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4404 (current_message_1, set_message_1):
4405 Use a local to convert to proper width without a cast.
4406 * xmenu.c (dialog_selection_callback): Likewise.
4407
ede49d71
PE
4408 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4409 Also, don't assume VALBITS / RAND_BITS is less than 5,
4410 and don't rely on undefined behavior when shifting a 1 left into
4411 the sign bit.
4412 * lisp.h (get_random): Change signature to match.
4413
2f30ecd0
PE
4414 * lread.c (hash_string): Use size_t, not int, for hash computation.
4415 Normally we prefer signed values; but hashing is special, because
4416 it's better to use unsigned division on hash table sizes so that
4417 the remainder is nonnegative. Also, size_t is the natural width
4418 for hashing into memory. The previous code used 'int', which doesn't
4419 retain enough info to hash well into very large tables.
4420 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4421
2a866e7b
PE
4422 * dbusbind.c: Don't possibly lose pointer info when converting.
4423 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4424 Use XPNTR rather than XHASH, so that the high-order bits of
4425 the pointer aren't lost when converting through void *.
4426
51639eac
PE
4427 * eval.c (Fautoload): Don't double-shift a pointer.
4428
92394119
PE
4429 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4430
dbdb9a7c
JB
44312011-05-06 Juanma Barranquero <lekktu@gmail.com>
4432
4433 * gnutls.c (DEF_GNUTLS_FN):
4434 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4435
db7a0b4f
AS
44362011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4437
4438 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4439 marker. (Bug#8610)
4440
f7ff1b0f 44412011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4442
4443 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4444 New version that can reserve upto 2GB of heap space.
4445
f7ff1b0f 44462011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4447
4448 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4449
639c109b
TZ
44502011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4451
4452 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4453 `gnutls_certificate_set_x509_key_file'.
4454
d2127135
JB
44552011-05-05 Juanma Barranquero <lekktu@gmail.com>
4456
4457 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4458 Update dependencies.
4459
e968f4f3
JB
44602011-05-04 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4463 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4464 Remove unused parameter `fildes'.
4465 * process.c (read_process_output, send_process): Don't pass it.
4466
84d358f0
JB
44672011-05-04 Juanma Barranquero <lekktu@gmail.com>
4468
4469 Fix previous change: the library cache is defined in w32.c.
4470 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4471 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4472
0898ca10
JB
44732011-05-04 Juanma Barranquero <lekktu@gmail.com>
4474
4475 Implement dynamic loading of GnuTLS on Windows.
4476
4477 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4478 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4479 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4480 Declare.
4481
4482 * gnutls.c (Qgnutls_dll): Define.
4483 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4484 (gnutls_*): Declare function pointers.
4485 (init_gnutls_functions): New function to initialize function pointers.
4486 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4487 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4488 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4489 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4490 (emacs_gnutls_write, emacs_gnutls_read)
4491 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4492 (Fgnutls_available_p): New function.
4493 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4494 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4495 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4496
4497 * image.c: Include w32.h.
4498 (Vimage_type_cache): Delete.
4499 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4500 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4501 (w32_delayed_load): Move to w32.c.
4502
4503 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4504
4505 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4506 (w32_delayed_load): Move from image.c. When loading a library, record
4507 its filename in the :loaded-from property of the library id.
4508 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4509 Initialize and staticpro them.
4510 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4511
4512 * process.c: Include lisp.h before w32.h, not after.
4513 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4514 instead of gnutls_record_check_pending.
4515
4516 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4517
ff4de4aa
TZ
45182011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4519
4520 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4521 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4522 as passed in.
4523
abe95abb
JD
45242011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4525
4526 * xterm.c (x_set_frame_alpha): Do not set property on anything
4527 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4528
e16e55d4
JB
45292011-05-02 Juanma Barranquero <lekktu@gmail.com>
4530
4531 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4532
bafcf6a5
JB
45332011-05-02 Juanma Barranquero <lekktu@gmail.com>
4534
4535 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4536 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4537 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4538 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4539 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4540 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4541 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4542 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4543 (Qgnutls_bootprop_callbacks_verify): Make static.
4544
e7a6747f
AS
45452011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4546
19ed11ba
AS
4547 * callproc.c: Indentation fixup.
4548
e7a6747f 4549 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4550 (wait_for_termination, interruptible_wait_for_termination):
4551 Move after wait_for_termination_1.
e7a6747f 4552
1ef14cb4
LMI
45532011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4554
4555 * sysdep.c (interruptible_wait_for_termination): New function
4556 which is like wait_for_termination, but allows keyboard
4557 interruptions.
4558
4559 * callproc.c (Fcall_process): Add (:file "file") as an option for
4560 the STDOUT buffer.
4561 (Fcall_process_region): Ditto.
4562
330d880c
EZ
45632011-04-30 Eli Zaretskii <eliz@gnu.org>
4564
8db90b73
EZ
4565 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4566 rather than `XVECTOR (FOO)->size'.
4567
330d880c
EZ
4568 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4569 inttypes.h, as a gnulib replacement is used if it not available in
4570 system headers.
4571
15cbd324
EZ
45722011-04-21 Eli Zaretskii <eliz@gnu.org>
4573
4574 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4575 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4576 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4577
4578 * coding.c (coding_alloc_by_realloc): Error out if destination
4579 will grow beyond MOST_POSITIVE_FIXNUM.
4580 (decode_coding_emacs_mule): Abort if there isn't enough place in
4581 charbuf for the composition carryover bytes. Reserve an extra
4582 space for up to 2 characters produced in a loop.
4583 (decode_coding_iso_2022): Abort if there isn't enough place in
4584 charbuf for the composition carryover bytes.
4585
45862011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4587
ae940cca
EZ
4588 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4589 aborting when %lld or %lll format is passed.
4590 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4591 %llo or %llx format is passed. (Bug#8545)
4592
03ab8921
EZ
4593 * window.c (window_scroll_line_based): Use a marker instead of
4594 simple variables to record original value of point. (Bug#7952)
4595
afda1437
EZ
4596 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4597 produced by %s or %c overflows available buffer space. (Bug#8545)
4598
f76dee0c
PE
45992011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4600
4601 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4602 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4603
fdc5744d
JB
46042011-04-28 Juanma Barranquero <lekktu@gmail.com>
4605
4606 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4607
638f053a
JB
46082011-04-28 Juanma Barranquero <lekktu@gmail.com>
4609
4610 * keyboard.c (Qdelayed_warnings_hook): Define.
4611 (command_loop_1): Run `delayed-warnings-hook'
4612 if Vdelayed_warnings_list is non-nil.
4613 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4614 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4615
d178f871
EZ
46162011-04-28 Eli Zaretskii <eliz@gnu.org>
4617
4618 * doprnt.c (doprnt): Don't return value smaller than the buffer
4619 size if the message was truncated. (Bug#8545).
4620
b124fd93
JB
46212011-04-28 Juanma Barranquero <lekktu@gmail.com>
4622
4623 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4624 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4625
e810457d
PE
46262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4627
4628 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4629
ea51cceb
JB
46302011-04-27 Juanma Barranquero <lekktu@gmail.com>
4631
4632 * makefile.w32-in: Update dependencies.
4633
94dcfacf
EZ
46342011-04-27 Eli Zaretskii <eliz@gnu.org>
4635
4636 Improve `doprnt' and its usage. (Bug#8545)
4637 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4638 `format_end'. Remove support for %l as a conversion specifier.
4639 Don't use xrealloc. Improve diagnostics when the %l size modifier
4640 is used. Update the commentary.
4641
4642 * eval.c (verror): Simplify calculation of size_t.
4643
4644 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4645 messages.
4646
f61f41d7
PE
46472011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4648
4649 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4650 change.
4651
96fb4434
PE
46522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4653
4654 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4655 This makes this file independent of the recent pseudovector change.
4656
671875da 46572011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4658
69e9b5a3
PE
4659 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4660
b5f869a7 4661 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4662 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4663 Remove unused local.
c8926152 4664 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4665
841a1577 4666 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4667 GCC 4.6.0 optimizes based on type-based alias analysis.
4668 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4669 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4670 != &v->size, and therefore "v->size = 1; b->size = 2; return
4671 v->size;" must therefore return 1. This assumption is incorrect
4672 for Emacs, since it type-puns struct Lisp_Vector * with many other
4673 types. To fix this problem, this patch adds a new type struct
f904488f 4674 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4675 and pseudovectors, and helps optimizing compilers not get fooled
4676 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4677 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4678 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4679 the size member.
eab3844f
PE
4680 (XSETPVECTYPE): Rewrite in terms of new macro.
4681 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4682 This is a bit clearer, and further avoids the possibility of
4683 undesirable aliasing.
4684 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4685 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4686 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4687 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4688 (ASIZE): Now uses header.size rather than size.
4689 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4690 to avoid the hassle of writing XVECTOR (foo)->header.size.
4691 (struct vectorlike_header): New type.
eab3844f
PE
4692 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4693 object, to help avoid aliasing.
4694 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4695 (SUBRP): Likewise, since Lisp_Subr is a special case.
4696 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4697 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4698 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4699 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4700 changed to be "header.size" and "header.next".
4701 * buffer.h (struct buffer): Likewise.
4702 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4703 * frame.h (struct frame): Likewise.
4704 * process.h (struct Lisp_Process): Likewise.
4705 * termhooks.h (struct terminal): Likewise.
4706 * window.c (struct save_window_data, struct saved_window): Likewise.
4707 * window.h (struct window): Likewise.
4708 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4709 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4710 * buffer.c (init_buffer_once): Likewise.
4711 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4712 special case.
4713 * process.c (Fformat_network_address): Use local var for size,
4714 for brevity.
4715
0df1eac5
PE
4716 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4717
847ab9d1 4718 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4719 * data.c (atof): Remove decl; no longer used or needed.
4720 (digit_to_number): Move to lread.c.
4721 (Fstring_to_number): Use new string_to_number function, to be
4722 consistent with how the Lisp reader treats infinities and NaNs.
4723 Do not assume that floating-point numbers represent EMACS_INT
4724 without losing information; this is not true on most 64-bit hosts.
4725 Avoid double-rounding errors, by insisting on integers when
4726 parsing non-base-10 numbers, as the documentation specifies.
4727 * lisp.h (string_to_number): New decl, replacing ...
4728 (isfloat_string): Remove.
bc0a5c13 4729 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4730 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4731 appears to have been a coding error. Similarly, do not accept
4732 strings like +-1e0 as floating point numbers. Do not report
4733 overflow for integer overflows unless the base is not 10 which
4734 means we have no simple and reliable way to continue.
4735 Break out the floating-point parsing into a new
4736 function string_to_number, so that Fstring_to_number parses
4737 floating point numbers consistently with the Lisp reader.
04f2d78b 4738 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4739 (E_CHAR, EXP_INT): Remove, replacing with ...
4740 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4741 (string_to_number): New function, replacing isfloat_string.
4742 This function checks for valid syntax and produces the resulting
4743 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4744 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4745 so that overflow for non-base-10 numbers is reported only when
4746 there's no portable and simple way to convert to floating point.
452f4150 4747
67769ffc
PE
4748 * textprop.c (set_text_properties_1): Rewrite for clarity,
4749 and to avoid GCC warning about integer overflow.
4750
c20db43f
PE
4751 * intervals.h (struct interval): Use EMACS_INT for members
4752 where EMACS_UINT might cause problems. See
4753 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4754 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4755 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4756 All uses changed.
37aa2f85
PE
4757 (offset_intervals): Tell GCC not to worry about length overflow
4758 when negating a negative length.
c20db43f 4759
2538aa2f
PE
4760 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4761 (overrun_check_free): Likewise.
4762
f2d3008d
PE
4763 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4764 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4765 word size.
4766
ec8df744
PE
4767 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4768 (gnutls_make_error): Rename local to avoid shadowing.
4769 (gnutls_emacs_global_deinit): ifdef out; not used.
4770 (Fgnutls_boot): Use const for pointer to readonly storage.
4771 Comment out unused local. Fix pointer signedness problems.
4772
640ee02d
PE
4773 * lread.c (openp): Don't stuff size_t into an 'int'.
4774 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4775 about possible signed overflow.
4776
6048fb2a
PE
4777 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4778 (GDK_KEY_g): Don't define if already defined.
4779 (xg_prepare_tooltip): Avoid pointer signedness problem.
4780 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4781
fa3c87e1
PE
4782 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4783 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4784
2172544b
PE
4785 * xfns.c (Fx_window_property): Simplify a bit,
4786 to make a bit faster and to avoid GCC 4.6.0 warning.
4787 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4788
9b821a21
PE
4789 * fns.c (internal_equal): Don't assume size_t fits in int.
4790
3c616cfa
PE
4791 * alloc.c (compact_small_strings): Tighten assertion a little.
4792
c2982e87
PE
4793 Replace pEd with more-general pI, and fix some printf arg casts.
4794 * lisp.h (pI): New macro, generalizing old pEd macro to other
4795 conversion specifiers. For example, use "...%"pI"d..." rather
4796 than "...%"pEd"...".
4797 (pEd): Remove. All uses replaced with similar uses of pI.
4798 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4799 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4800 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4801 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4802 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4803 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4804 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4805 64-bit hosts.
4806 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4807 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4808 * print.c (safe_debug_print, print_object): Likewise.
4809 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4810 to int.
6f04d126
PE
4811 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4812 avoiding the 0 flag, which is not portable.
c2982e87
PE
4813 * process.c (Fmake_network_process): Use pI to avoid cast.
4814 * region-cache.c (pp_cache): Likewise.
4815 * xdisp.c (decode_mode_spec): Likewise.
4816 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4817 behavior on 64-bit hosts with printf arg.
6f04d126 4818 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4819 (x_stop_queuing_selection_requests): Likewise.
4820 (x_get_window_property): Don't truncate byte count to an 'int'
4821 when tracing.
0b432f21 4822
5e073ec7
PE
4823 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4824 here, since it parses constructs like leading '-' and spaces,
4825 which are not wanted; and it overflows with large numbers.
4826 Instead, simply match F[0-9]+, which is what is wanted anyway.
4827
36372bf9
PE
4828 * alloc.c: Remove unportable assumptions about struct layout.
4829 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4830 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4831 (allocate_vectorlike, make_pure_vector): Use the new macros,
4832 plus offsetof, to remove unportable assumptions about struct layout.
4833 These assumptions hold on all porting targets that I know of, but
4834 they are not guaranteed, they're easy to remove, and removing them
4835 makes further changes easier.
4836
0b432f21
PE
4837 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4838 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4839 (string_overrun_cookie): Now const. Use initializers that
4840 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4841 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4842 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4843 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4844 multiple of sizeof (EMACS_INT); it need not be, if
4845 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4846 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4847
895009e1
JB
48482011-04-26 Juanma Barranquero <lekktu@gmail.com>
4849
4850 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4851
6a7a1b0b
TZ
48522011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4853
4854 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4855 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4856 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4857
841a1577 48582011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4859
4860 * lisp.h (Qdebug): List symbol.
895009e1 4861 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4862 * keyboard.c (debug-on-event): New variable.
4863 (handle_user_signal): Break into debugger when debug-on-event
4864 matches the current signal symbol.
4865
f2d3ba6f
DN
48662011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4867
4868 * alloc.c (check_sblock, check_string_bytes)
4869 (check_string_free_list): Convert to standard C.
4870
42ce4c63
TZ
48712011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4872
4873 * w32.c (emacs_gnutls_push): Fix typo.
4874
825cd63c
EZ
48752011-04-25 Eli Zaretskii <eliz@gnu.org>
4876
fb11d64d
EZ
4877 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4878 "cast to pointer from integer of different size".
4879
825cd63c
EZ
4880 Improve doprnt and its use in verror. (Bug#8545)
4881 * doprnt.c (doprnt): Document the set of format control sequences
4882 supported by the function. Use SAFE_ALLOCA instead of always
4883 using `alloca'.
4884
4885 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4886 is one byte too soon. Don't use xrealloc; instead xfree and
4887 xmalloc anew.
4888
e061a11b
TZ
48892011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4890
4891 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4892 callbacks stage.
4893
4894 * gnutls.c: Renamed global_initialized to
4895 gnutls_global_initialized. Added internals for the
4896 :verify-hostname-error, :verify-error, and :verify-flags
4897 parameters of `gnutls-boot' and documented those parameters in the
4898 docstring. Start callback support.
9173deec
JB
4899 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4900 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4901 on error. Return error code.
e061a11b
TZ
4902 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4903 (emacs_gnutls_read): Likewise.
4904 (Fgnutls_boot): Return handshake error code.
4905 (emacs_gnutls_handle_error): New function.
4906 (wsaerror_to_errno): Likewise.
4907
4908 * w32.h (emacs_gnutls_pull): Add prototype.
4909 (emacs_gnutls_push): Likewise.
4910
4911 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4912 (emacs_gnutls_push): Likewise.
4913
49142011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4915
4916 * process.c (wait_reading_process_output): Check if GnuTLS
4917 buffered some data internally if no FDs are set for TLS
4918 connections.
4919
4920 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4921 (LIBS): Link to USER_LIBS.
4922 ($(BLD)/gnutls.$(0)): New target.
4923
fa6996bc
EZ
49242011-04-24 Eli Zaretskii <eliz@gnu.org>
4925
eb35682e
EZ
4926 * xdisp.c (handle_single_display_spec): Rename the
4927 display_replaced_before_p argument into display_replaced_p, to
4928 make it consistent with the commentary. Fix typos in the
4929 commentary.
4930
e2ad650c
EZ
4931 * textprop.c (syms_of_textprop): Remove dead code.
4932 (copy_text_properties): Delete obsolete commentary about an
4933 interface that was deleted long ago. Fix typos in the description
4934 of arguments.
4935
1b2de274
EZ
4936 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4937 to changes in oldXMenu/XMenu.h from 2011-04-16.
4938 <menu_help_message, prev_menu_help_message>: Constify.
4939 (IT_menu_make_room): menu->help_text is now `const char **';
4940 adjust.
4941
4942 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4943 to changes in oldXMenu/XMenu.h from 2011-04-16.
4944 (struct XMenu): Declare `help_text' `const char **'.
4945
4946 * xfaces.c <Qunspecified>: Make extern again.
4947
4948 * syntax.c: Include sys/types.h before including regex.h, as
4949 required by Posix.
4950
762b15be
EZ
4951 * doc.c (get_doc_string): Improve the format passed to `error'.
4952
4953 * doprnt.c (doprnt): Improve commentary.
4954
4955 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4956
4957 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4958 them with etags.
4959
f1052e5d
EZ
4960 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4961 changes in globals.h immediately force recompilation.
762b15be
EZ
4962 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4963 $(CURDIR)/s/ms-w32.h.
4964 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4965
fa6996bc
EZ
4966 * character.c (Fchar_direction): Function deleted.
4967 (syms_of_character): Don't defsubr it.
4968 <char-direction-table>: Deleted.
4969
e6c3da20
EZ
49702011-04-23 Eli Zaretskii <eliz@gnu.org>
4971
4972 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4973 * doprnt.c: Include limits.h.
4974 (SIZE_MAX): New macro.
04f2d78b
CB
4975 (doprnt): Return a size_t value. 2nd arg is now size_t.
4976 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4977 Improve overflow protection. Support `l' modifier for integer
4978 conversions. Support %l conversion. Don't assume an EMACS_INT
4979 argument for integer conversions and for %c.
4980
4981 * lisp.h (doprnt): Restore prototype.
4982
4983 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4984 $(SRC)/character.h.
4985
4986 * Makefile.in (base_obj): Add back doprnt.o.
4987
4988 * deps.mk (doprnt.o): Add back prerequisites.
4989 (callint.o): Depend on character.h.
4990
4991 * eval.c (internal_lisp_condition_case): Include the handler
4992 representation in the error message.
4993 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4994 when breaking from the loop.
4995
4996 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4997
4998 * callint.c (Fcall_interactively): When displaying error message
4999 about invalid control letter, pass the character's codepoint, not
5000 a pointer to its multibyte form. Improve display of the character
5001 in octal and display also its hex code.
5002
5003 * character.c (char_string): Use %x to display the (unsigned)
5004 codepoint of an invalid character, to avoid displaying a bogus
5005 negative value.
5006
5007 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5008 `error', not SYMBOL_NAME itself.
5009
5010 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5011 character arguments to `error'.
5012
5013 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5014 to `error' in error message about FINAL_CHAR argument. Make sure
5015 FINAL_CHAR is a character, and use %c when it is passed as
5016 argument to `error'.
5017
4ffd0d6b 50182011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5019
5020 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5021
5022 * w32.c: Include <time.h>.
5023 (sys_localtime): New function.
5024
4ffd0d6b 50252011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5026
5027 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5028
4ffd0d6b 5029 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5030
4ffd0d6b 50312011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5032
4ffd0d6b
GM
5033 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5034 zombies (Bug#8467).
aac0c6e3 5035
04c56954
EZ
50362011-04-19 Eli Zaretskii <eliz@gnu.org>
5037
5038 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5039 gl_state.e_property when gl_state.object is Qt.
5040
5041 * insdel.c (make_gap_larger): Remove limitation of buffer size
5042 to <= INT_MAX.
5043
16a43933
CY
50442011-04-18 Chong Yidong <cyd@stupidchicken.com>
5045
5046 * xdisp.c (lookup_glyphless_char_display)
5047 (produce_glyphless_glyph): Handle cons cell entry in
5048 glyphless-char-display.
5049 (Vglyphless_char_display): Document it.
5050
5051 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5052 glyphless-char-display.
5053
4581706e
CY
50542011-04-17 Chong Yidong <cyd@stupidchicken.com>
5055
5056 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5057
5058 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5059
5060 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5061 definition for no-X builds.
5062
4887c6e2 50632011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5064
fd35b6f9
PE
5065 Static checks with GCC 4.6.0 and non-default toolkits.
5066
5c1ccb01
PE
5067 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5068
006c5daa
PE
5069 * process.c (keyboard_bit_set): Define only if SIGIO.
5070 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5071 (send_process): Repair possible setjmp clobbering.
5072
efc736d3
PE
5073 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5074
4e2fe2e6
PE
5075 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5076
f97334a2
PE
5077 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5078
4e75f29d
PE
5079 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5080 Define only if needed.
5081
90efadd1
PE
5082 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5083 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5084 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5085
3c647824
PE
5086 * dispextern.h (struct redisplay_interface): Rename param
5087 to avoid shadowing.
e264f262 5088 * termhooks.h (struct terminal): Likewise.
761383f4 5089 * xterm.c (xembed_send_message): Likewise.
3c647824 5090
b58c5c4a
PE
5091 * insdel.c (make_gap_smaller): Define only if
5092 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5093
cad59032
PE
5094 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5095 it.
5096
c339dc2e
PE
5097 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5098 so that we aren't warned about unused symbols.
5099
91a3e27b
PE
5100 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5101
399c71d3 5102 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5103
8ffc96f5
PE
5104 * xfns.c (x_real_positions): Mark locals as initialized.
5105
eef9bc79
PE
5106 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5107
098db9dd
PE
5108 * xterm.c: Fix problems found by static analysis with other toolkits.
5109 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5110 (x_dispatch_event): Declare static if USE_GTK, and
5111 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5112 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5113 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5114 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5115 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5116
eb18f6cc
PE
5117 * xmenu.c (menu_help_callback): Pointer type fixes.
5118 Use const pointers when pointing at readonly data. Avoid pointer
5119 signedness clashes.
5120 (FALSE): Remove unused macro.
5121 (update_frame_menubar): Remove unused decl.
5122
1fe72bf8
PE
5123 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5124
60d9e1db
PE
5125 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5126 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5127 (single_menu_item): Rename local to avoid shadowing.
5128
39261c26
PE
5129 * keyboard.c (make_lispy_event): Remove unused local var.
5130
018c5e19
PE
5131 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5132 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5133
63d2b86e
PE
5134 * bitmaps: Change bitmaps from unsigned char back to the X11
5135 compatible char. Avoid the old compiler warnings about
5136 out-of-range initializers by using, for example, '\xab' rather
5137 than 0xab.
5138
aefd87e1
PE
5139 * xgselect.c (xgselect_initialize): Check vs interface
5140 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5141
bf501fb9
PE
5142 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5143
e9829fdf
PE
5144 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5145 to read-only memory.
5146
1086c095
PE
5147 * fns.c (vector): Remove; this old hack is no longer needed.
5148
2baccd04 5149 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5150 Remove unused var.
dde42981 5151 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5152
72391843 5153 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5154
436c16df 5155 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5156 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5157 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5158
92bb796d 5159 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5160 (x_term_init): Remove local to avoid shadowing.
92bb796d 5161
764430a3 5162 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5163
5164 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5165 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5166
d1dfb56c
EZ
51672011-04-16 Eli Zaretskii <eliz@gnu.org>
5168
c4354cb4
EZ
5169 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5170
d1dfb56c
EZ
5171 Fix regex.c, syntax.c and friends for buffers > 2GB.
5172 * syntax.h (struct gl_state_s): Declare character position members
5173 EMACS_INT.
5174
5175 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5176
04f2d78b
CB
5177 * textprop.c (verify_interval_modification, interval_of):
5178 Declare arguments EMACS_INT.
d1dfb56c
EZ
5179
5180 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5181 EMACS_INT.
5182
5183 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5184
5185 * indent.c (Fvertical_motion): Local variable it_start is now
5186 EMACS_INT.
5187
5188 * regex.c (re_match, re_match_2, re_match_2_internal)
5189 (bcmp_translate, regcomp, regexec, print_double_string)
5190 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5191 (re_compile_pattern, re_exec): Declare arguments and local
5192 variables `size_t' and `ssize_t' and return values `regoff_t', as
5193 appropriate.
5194 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5195 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5196 <compile_stack_type>: `size' and `avail' are now `size_t'.
5197
5198 * regex.h <regoff_t>: Use ssize_t, not int.
5199 (re_search, re_search_2, re_match, re_match_2): Arguments that
5200 specify buffer/string position and length are now ssize_t and
5201 size_t. Return type is regoff_t.
5202
613052cd
BK
52032011-04-16 Ben Key <bkey76@gmail.com>
5204
5205 * nsfont.m: Fixed bugs in ns_get_family and
5206 ns_descriptor_to_entity that were caused by using free to
5207 deallocate memory blocks that were allocated by xmalloc (via
5208 xstrdup). This caused Emacs to crash when compiled with
5209 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5210 --enable-checking=xmallocoverrun). xfree is now used to
5211 deallocate these memory blocks.
5212
4170f62f 52132011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5214
71b41406
PE
5215 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5216
9587a89d
PE
5217 emacs_write: Accept and return EMACS_INT for sizes.
5218 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5219 et seq.
5220 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5221 Accept and return EMACS_INT.
5222 (emacs_gnutls_write): Return the number of bytes written on
5223 partial writes.
5224 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5225 (emacs_read, emacs_write): Remove check for negative size, as the
5226 Emacs source code has been audited now.
9587a89d
PE
5227 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5228 (emacs_read, emacs_write): Use it.
273a5f82
PE
5229 * process.c (send_process): Adjust to the new signatures of
5230 emacs_write and emacs_gnutls_write. Do not attempt to store
5231 a byte offset into an 'int'; it might overflow.
9587a89d 5232 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5233
3e047f51
PE
5234 * sound.c: Don't assume sizes fit in 'int'.
5235 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5236 Return EMACS_INT, not int.
3e047f51 5237 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5238 Accept EMACS_INT, not int.
5239 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5240 record read return values.
5241
cc39a9db
BK
52422011-04-15 Ben Key <bkey76@gmail.com>
5243
c9d0ec6d
JB
5244 * keyboard.c (Qundefined): Don't declare static since it is used
5245 in nsfns.m.
5246 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5247 static since they are used in nsfont.m.
cc39a9db 5248
6c60eb9f
SM
52492011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5250
5251 * process.c (Qprocessp): Don't declare static.
5252 * lisp.h (Qprocessp): Declare again.
5253
7990b61a
JB
52542011-04-15 Juanma Barranquero <lekktu@gmail.com>
5255
5256 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5257
5d4cb038
PE
52582011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5259
8bd7b830 5260 Improve C-level modularity by making more things 'static'.
cd64ea1d 5261
e3b27b31
PE
5262 Don't publish debugger-only interfaces to other modules.
5263 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5264 (verify_bytepos, count_markers): Move decls to the only modules
5265 that need them.
5266 * region-cache.h (pp_cache): Likewise.
5267 * window.h (check_all_windows): Likewise.
5268 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5269
5d4cb038
PE
5270 * sysdep.c (croak): Now static, if
5271 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5272 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5273
5274 * alloc.c (refill_memory_reserve): Now static if
5275 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5276 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5277
e87b6180
PE
5278 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5279 Define only if USE_LUCID.
5280
ac64929e
PE
5281 * xrdb.c (x_customization_string, x_rm_string): Now static.
5282
6f37259d
PE
5283 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5284 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5285
1683e3ab
PE
5286 * xdisp.c (draw_row_with_mouse_face): Now static.
5287 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5288
de9c2632
PE
5289 * window.h (check_all_windows): Mark externally visible.
5290
2b96acb7
PE
5291 * window.c (window_deletion_count): Now static.
5292
5293 * undo.c: Make symbols static if they're not exported.
5294 (last_undo_buffer, last_boundary_position, pending_boundary):
5295 Now static.
5296
50436f33
PE
5297 * textprop.c (interval_insert_behind_hooks): Now static.
5298 (interval_insert_in_front_hooks): Likewise.
5299
64520e5c
PE
5300 * term.c: Make symbols static if they're not exported.
5301 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5302 (max_frame_lines, tty_set_terminal_modes):
5303 (tty_reset_terminal_modes, tty_turn_off_highlight):
5304 (get_tty_terminal): Now static.
5305 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5306 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5307 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5308 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5309 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5310
1fa53021
PE
5311 * sysdep.c: Make symbols static if they're not exported.
5312 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5313 Now static.
5314 (sigprocmask_set, full_mask): Remove; unused.
5315 (wait_debugging): Mark as visible.
5316 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5317 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5318
d4b43b22
PE
5319 * syntax.c (syntax_temp): Define only if !__GNUC__.
5320
b7c513d0
PE
5321 * sound.c (current_sound_device, current_sound): Now static.
5322
989b29ad
PE
5323 * search.c (searchbufs, searchbuf_head): Now static.
5324
13a55a78
PE
5325 * scroll.c (scroll_cost): Remove; unused.
5326 * dispextern.h (scroll_cost): Remove decl.
5327
de68a1fc
PE
5328 * region-cache.h (pp_cache): Mark as externally visible.
5329
40ccffa6
PE
5330 * process.c: Make symbols static if they're not exported.
5331 (process_tick, update_tick, create_process, chan_process):
5332 (Vprocess_alist, proc_buffered_char, datagram_access):
5333 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5334 (deactivate_process): Mark defn as static, as well as decl.
5335 * lisp.h (create_process): Remove decl.
5336 * process.h (chan_process, Vprocess_alist): Remove decls.
5337
ad64fc97
PE
5338 * print.c: Make symbols static if they're not exported.
5339 (print_depth, new_backquote_output, being_printed, print_buffer):
5340 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5341 (print_interval, print_number_index, initial_stderr_stream):
5342 Now static.
5343 * lisp.h (Fprinc): Remove decl.
5344 (debug_output_compilation_hack): Mark as externally visible.
5345
adddb265
PE
5346 * sysdep.c (croak): Move decl from here to syssignal.h.
5347 * syssignal.h (croak): Put it here, so the API can be checked when
5348 'croak' is called from dissociate_if_controlling_tty.
5349
1717ede2
PE
5350 * minibuf.c: Make symbols static if they're not exported.
5351 (minibuf_save_list, choose_minibuf_frame): Now static.
5352 * lisp.h (choose_minibuf_frame): Remove decl.
5353
fa5fb2bc
PE
5354 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5355
1e3890d1
PE
5356 * lread.c: Make symbols static if they're not exported.
5357 (read_objects, initial_obarray, oblookup_last_bucket_number):
5358 Now static.
5359 (make_symbol): Remove; unused.
5360 * lisp.h (initial_obarray, make_symbol): Remove decls.
5361
8a1414fa
PE
5362 * keyboard.c: Make symbols static if they're not exported.
5363 (single_kboard, recent_keys_index, total_keys, recent_keys):
5364 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5365 (this_single_command_key_start, echoing, last_auto_save):
5366 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5367 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5368 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5369 (Vlispy_mouse_stem, double_click_count):
5370 Now static.
5371 (force_auto_save_soon): Define only if SIGDANGER.
5372 (ignore_mouse_drag_p): Now static if
5373 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5374 (print_help): Remove; unused.
5375 (stop_character, last_timer_event): Mark as externally visible.
5376 * keyboard.h (ignore_mouse_drag_p): Declare only if
5377 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5378 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5379 * lisp.h (echoing): Remove decl.
5380 (force_auto_save_soon): Declare only if SIGDANGER.
5381 * xdisp.c (redisplay_window): Simplify code, to make it more
5382 obvious that ignore_mouse_drag_p is not accessed if !defined
5383 USE_GTK && !defined HAVE_NS.
5384
93ea6e8f
PE
5385 * intervals.c: Make symbols static if they're not exported.
5386 (merge_properties_sticky, merge_interval_right, delete_interval):
5387 Now static.
5388 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5389
77382fcc
PE
5390 * insdel.c: Make symbols static if they're not exported.
5391 However, leave prepare_to_modify_buffer alone. It's never
5392 called from outside this function, but that appears to be a bug.
5393 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5394 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5395 (adjust_after_replace_noundo): Remove; unused.
5396 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5397 (signal_before_change): Remove decls.
77382fcc 5398
9306c32e
PE
5399 * indent.c (val_compute_motion, val_vmotion): Now static.
5400
cd44d2eb
PE
5401 * image.c: Make symbols static if they're not exported.
5402 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5403 if USE_GTK.
5404 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5405 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5406
ad9a7a06
PE
5407 * fringe.c (standard_bitmaps): Now static.
5408 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5409
81626931
PE
5410 * frame.c: Make symbols static if they're not exported.
5411 (x_report_frame_params, make_terminal_frame): Now static.
5412 (get_frame_param): Now static, unless HAVE_NS.
5413 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5414 (x_get_resource_string): Remove; not used.
5415 * frame.h (make_terminal_frame, x_report_frame_params):
5416 (x_get_resource_string); Remove decls.
5417 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5418 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5419
239f9db9
PE
5420 * font.c, fontset.c: Make symbols static if they're not exported.
5421 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5422 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5423 * font.c (font_close_object): Now static.
5424 * font.h (font_close_object): Remove.
5425 * fontset.c (FONTSET_OBJLIST): Remove.
5426 (free_realized_fontset) #if-0 the body, which does nothing.
5427 (face_suitable_for_char_p): #if-0, as it's never called.
5428 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5429 * xfaces.c (face_at_string_position):
5430 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5431 since 0 is always ASCII.
5432
dfcf3579
PE
5433 * fns.c (weak_hash_tables): Now static.
5434
5045092b
PE
5435 * fileio.c: Make symbols static if they're not exported.
5436 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5437 (Vwrite_region_annotation_buffers): Now static.
5438
57a96f5c
PE
5439 * eval.c: Make symbols static if they're not exported.
5440 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5441 * lisp.h (backtrace_list): Remove decl.
5442
35f08c38
PE
5443 * emacs.c: Make symbols static if they're not exported.
5444 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5445 (fatal_error_code, fatal_error_signal_hook, standard_args):
5446 Now static.
5447 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5448 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5449 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5450 * lisp.h (fatal_error_signal_hook): Remove decl.
5451 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5452
f44bd759
PE
5453 * editfns.c: Move a (normally-unused) function to its only use.
5454 * editfns.c, lisp.h (get_operating_system_release): Remove.
5455 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5456 worth the hassle of breaking this out.
5457
b532497d
PE
5458 * xterm.c: Make symbols static if they're not exported.
5459 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5460 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5461 (x_destroy_window, x_delete_display):
5462 Now static.
5463 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5464 (x_mouse_leave): Remove; unused.
5465 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5466 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5467 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5468 Remove decls.
5469 (x_mouse_leave): Declare only if WINDOWSNT.
5470 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5471 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5472 USE_X_TOOLKIT.
5473
1675728f
PE
5474 * ftxfont.c: Make symbols static if they're not exported.
5475 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5476 HAVE_FREETYPE.
5477 * font.h (ftxfont_driver): Likewise.
5478
e4cebfca
PE
5479 * xfns.c: Make symbols static if they're not exported.
5480 (x_last_font_name, x_display_info_for_name):
5481 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5482 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5483 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5484 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5485 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5486 (last_show_tip_args): Now static.
5487 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5488 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5489 (x_screen_planes): Remove; unused.
5490 * dispextern.h (x_screen_planes): Remove decl.
5491
5bf46f05
PE
5492 * dispnew.c: Make symbols static if they're not exported.
5493 * dispextern.h (redraw_garbaged_frames, scrolling):
5494 (increment_row_positions): Remove.
5495 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5496 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5497 Now static.
5498 (redraw_garbaged_frames): Remove; unused.
5499
435f4c28
PE
5500 * xfaces.c: Make symbols static if they're not exported.
5501 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5502 Remove decls.
5503 * xterm.h (defined_color): Remove decls.
5504 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5505 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5506 (menu_face_changed_default, defined_color, free_realized_face):
5507 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5508 (ascii_face_of_lisp_face): Remove; unused.
5509
8524aef3
PE
5510 * xdisp.c: Make symbols static if they're not exported.
5511 * dispextern.h (scratch_glyph_row, window_box_edges):
5512 (glyph_to_pixel_coords, set_cursor_from_row):
5513 (get_next_display_element, set_iterator_to_next):
5514 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5515 (show_mouse_face): Remove decls
5516 * frame.h (message_buf_print): Likewise.
5517 * lisp.h (pop_message, set_message, check_point_in_composition):
5518 Likewise.
5519 * xterm.h (set_vertical_scroll_bar): Likewise.
5520 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5521 (message_buf_print, scratch_glyph_row, displayed_buffer):
5522 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5523 (get_next_display_element, show_mouse_face, window_box_edges):
5524 (frame_to_window_pixel_xy, check_point_in_composition):
5525 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5526 (glyph_to_pixel_coords): Remove; unused.
5527
16390cd2
PE
5528 * dired.c (file_name_completion): Now static.
5529
5530 * dbusbind.c (xd_in_read_queued_messages): Now static.
5531
a25f4dfa
PE
5532 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5533 * data.c (circular_list_error): Remove.
5534
14a9c8df
PE
5535 * commands.h (last_point_position, last_point_position_buffer):
5536 (last_point_position_window): Remove decls.
5537 * keyboard.c: Make these variables static.
5538
04f2d78b
CB
5539 * coding.h (coding, code_convert_region, encode_coding_gap):
5540 Remove decls.
74ab6df5
PE
5541 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5542 (iso_code_class, detect_coding, code_convert_region): Now static.
5543 (encode_coding_gap): Remove; unused.
5544
38dfbee1
PE
5545 * chartab.c (chartab_chars, chartab_bits): Now static.
5546
a2cb4e63
PE
5547 * charset.h (charset_iso_8859_1): Remove decl.
5548 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5549 Now static.
5550
127198fd
PE
5551 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5552 * ccl.c (Vccl_program_table): Now static.
5553 (check_ccl_update): Remove; unused.
5554
d85b608f
PE
5555 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5556 * category.h: ... from here.
5557 * category.c (check_category_table, set_category_set): Now static.
5558
31cd66f3
PE
5559 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5560 * lisp.h: Remove these decls.
5561
c358e587
PE
5562 * buffer.c (buffer_count): Remove unused var.
5563
e78aecca
PE
5564 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5565 so that it's not optimized away.
5566 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5567 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5568 exported only to the debugger.
5569
e192d7d3 5570 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5571 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5572
92470028
PE
5573 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5574 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5575 was inaccessible from Lisp.
5576 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5577 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5578
244ed907
PE
5579 alloc.c: Import and export fewer symbols, and remove unused items.
5580 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5581 is defined.
5582 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5583 it's not optimized away by whole-program optimization.
5584 (message_enable_multibyte, free_misc): Remove.
5585 (catchlist, handlerlist, mark_backtrace):
5586 Declare only if BYTE_MARK_STACK.
5587 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5588 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5589 (message_enable_multibyte): Remove decl.
5590 (free_misc, interval_free_list, float_block, float_block_index):
5591 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5592 (cons_free_list, last_marked_index):
5593 Now static.
5594 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5595 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5596 (mark_backtrace): Define only if BYTE_MARK_STACK.
5597 * xdisp.c (message_enable_multibyte): Now static.
5598
61c2b50e 5599 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5600 This makes it easier for human readers (and static analyzers)
5601 to see whether these variables are used from other modules.
5602 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5603 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5604 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5605 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5606 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5607 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5608 * xmenu.c, xselect.c:
5609 Declare Q* vars static if they are not used in other modules.
5610 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5611 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5612 Remove decls of unexported vars.
5613 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5614
95c82688
PE
5615 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5616
16a97296
PE
5617 Make Emacs functions such as Fatom 'static' by default.
5618 This makes it easier for human readers (and static analyzers)
5619 to see whether these functions can be called from other modules.
5620 DEFUN now defines a static function. To make the function external
5621 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5622 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5623 (Finit_image_library):
16a97296
PE
5624 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5625 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5626 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5627 Remove decls, since these functions are now static.
5628 (Funintern, Fget_internal_run_time): New decls, since these functions
5629 were already external.
95c82688 5630
16a97296
PE
5631 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5632 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5633 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5634 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5635 * keyboard.c, keymap.c, lread.c:
5636 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5637 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5638 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5639 Mark functions with DEFUE instead of DEFUN,
5640 if they are used in other modules.
5641 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5642 decls for now-static functions.
5643 * buffer.h (Fdelete_overlay): Remove decl.
5644 * callproc.c (Fgetenv_internal): Mark as internal.
5645 * composite.c (Fremove_list_of_text_properties): Remove decl.
5646 (Fcomposition_get_gstring): New forward static decl.
5647 * composite.h (Fcomposite_get_gstring): Remove decl.
5648 * dired.c (Ffile_attributes): New forward static decl.
5649 * doc.c (Fdocumntation_property): New forward static decl.
5650 * eval.c (Ffetch_bytecode): New forward static decl.
5651 (Funintern): Remove extern decl; now in .h file where it belongs.
5652 * fileio.c (Fmake_symbolic_link): New forward static decl.
5653 * image.c (Finit_image_library): New forward static decl.
5654 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5655 * intervals.h (Fprevious_property_change):
5656 (Fremove_list_of_text_properties): Remove decls.
5657 * keyboard.c (Fthis_command_keys): Remove decl.
5658 (Fcommand_execute): New forward static decl.
5659 * keymap.c (Flookup_key): New forward static decl.
5660 (Fcopy_keymap): Now static.
5661 * keymap.h (Flookup_key): Remove decl.
5662 * process.c (Fget_process): New forward static decl.
5663 (Fprocess_datagram_address): Mark as internal.
5664 * syntax.c (Fsyntax_table_p): New forward static decl.
5665 (skip_chars): Remove duplicate decl.
5666 * textprop.c (Fprevious_property_change): New forward static decl.
5667 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5668 Now internal.
5669 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5670 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5671
785bbd42
PE
5672 * editfns.c (Fformat): Remove unreachable code.
5673
8b913b57
AS
56742011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5675
5676 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5677 change. (Bug#8496)
5678
a6744a35
EZ
56792011-04-13 Eli Zaretskii <eliz@gnu.org>
5680
5681 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5682 when at ZV. (Bug#8487)
5683
e7974947
AS
56842011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5685
baad03f0
AS
5686 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5687 (Bug#8437)
5688 * keyboard.c (parse_tool_bar_item): Likewise.
5689 * sound.c (sound_cleanup, alsa_close): Likewise.
5690 * termcap.c (tgetent): Likewise.
5691 * xfns.c (x_default_font_parameter): Likewise.
5692 * xsettings.c (read_and_apply_settings): Likewise.
5693
e7974947
AS
5694 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5695 (overrun_check_free): Protoize.
5696
28272684
PE
56972011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5698
5699 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5700 since callers should never pass a negative size.
5701 Change the signature to match that of plain 'read' and 'write'; see
5702 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5703 * lisp.h: Update prototypes of emacs_write and emacs_read.
5704
11997c76
EZ
57052011-04-11 Eli Zaretskii <eliz@gnu.org>
5706
5707 * xdisp.c (redisplay_window): Don't try to determine the character
5708 position of the scroll margin if the window start point w->startp
e896f03c 5709 is outside the buffer's accessible region. (Bug#8468)
11997c76 5710
8a2cbd72
EZ
57112011-04-10 Eli Zaretskii <eliz@gnu.org>
5712
5713 Fix write-region and its subroutines for buffers > 2GB.
5714 * fileio.c (a_write, e_write): Modify declaration of arguments and
5715 local variables to support buffers larger than 2GB.
5716 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5717
5718 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5719 argument, local variables, and return value.
5720
5721 * lisp.h: Update prototypes of emacs_write and emacs_read.
5722
5723 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5724
4073e537 57252011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5726
1ebfdcb6
PE
5727 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5728
b2ded58d
PE
5729 Fix more problems found by GCC 4.6.0's static checks.
5730
7d66342c
PE
5731 * xdisp.c (vmessage): Use a better test for character truncation.
5732
bbf47d44
PE
5733 * charset.c (load_charset_map): <, not <=, for optimization,
5734 and to avoid potential problems with integer overflow.
9248994d 5735 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5736 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5737 * editfns.c (Fformat): Likewise.
1e69125e 5738 * syntax.c (skip_chars): Likewise.
3befa583 5739
e3019616
PE
5740 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5741 This also lets GCC 4.6.0 generate slightly better loop code.
5742
becfa255
PE
5743 * callint.c (Fcall_interactively): <, not <=, for optimization.
5744 (Fcall_interactively): Count the number of arguments produced,
5745 not the number of arguments given. This is simpler and lets GCC
5746 4.6.0 generate slightly better code.
5747
dae0cd48
PE
5748 * ftfont.c: Distingish more carefully between FcChar8 and char.
5749 The previous code passed unsigned char * to a functions like
5750 strlen and xstrcasecmp that expect char *, which does not
5751 conform to the C standard.
5752 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5753 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5754 char * when the C standard requires it.
5755
76032d70
PE
5756 * keyboard.c (read_char): Remove unused var.
5757
eb3f1cc8
PE
5758 * eval.c: Port to Windows vsnprintf (Bug#8435).
5759 Include <limits.h>.
5760 (SIZE_MAX): Define if the headers do not.
5761 (verror): Do not give up if vsnprintf returns a negative count.
5762 Instead, grow the buffer. This ports to Windows vsnprintf, which
5763 does not conform to C99. Problem reported by Eli Zaretskii.
5764 Also, simplify the allocation scheme, by avoiding the need for
5765 calling realloc, and removing the ALLOCATED variable.
5766
70476b54
PE
5767 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5768
12020a9e
PE
5769 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5770 But keep the doprint source code for now, as we might revamp it
5771 and use it again (Bug#8435).
ea6c7ae6
PE
5772 * lisp.h (doprnt): Remove.
5773 * Makefile.in (base_obj): Remove doprnt.o.
5774 * deps.mk (doprnt.o): Remove.
5775
5fdb398c
PE
5776 error: Print 32- and 64-bit integers portably (Bug#8435).
5777 Without this change, on typical 64-bit hosts error ("...%d...", N)
5778 was used to print both 32- and 64-bit integers N, which relied on
5779 undefined behavior.
5780 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5781 New macro.
5782 * lisp.h (error, verror): Mark as printf-like functions.
5783 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5784 Report overflow in size calculations when allocating printf buffer.
5785 Do not truncate output string at its first null byte.
5786 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5787 Truncate the output at a character boundary, since vsnprintf does not
5788 do that.
5789 * charset.c (check_iso_charset_parameter): Convert internal
5790 character to string before calling 'error', since %c now has the
5791 printf meaning.
5792 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5793 overflow when computing char to be passed to 'error'. Do not
5794 pass Lisp_Object to 'error'; pass the integer instead.
5795 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5796 formatted with plain %d.
5797
b189fa66
PE
5798 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5799
bff87ef0
PE
5800 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5801
7e2cac20
PE
5802 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5803
ce4d90b5
PE
5804 * xterm.c (x_catch_errors): Remove duplicate declaration.
5805
266c9547
PE
5806 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5807
79c49ad2
PE
5808 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5809
368f4090
JM
58102011-04-10 Jim Meyering <meyering@redhat.com>
5811
5812 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5813 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5814 return ssize_t not "int", and use size_t as the buffer length.
5815 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5816 * gnutls.h: Update declarations.
5817 * process.c (read_process_output): Use ssize_t, to match.
5818 (send_process): Likewise.
5819
a32d4040
CY
58202011-04-09 Chong Yidong <cyd@stupidchicken.com>
5821
5822 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5823
8546720e 58242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5825
04f2d78b
CB
5826 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5827 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5828
8546720e
GM
5829 * xterm.c (handle_one_xevent):
5830 * xmenu.c (create_and_show_popup_menu):
5831 * xselect.c (x_decline_selection_request)
5832 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5833
0a2f5c1a 58342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5835
5836 Fix some uses of `int' instead of EMACS_INT.
5837 * search.c (string_match_1, fast_string_match)
5838 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5839 (scan_buffer, find_next_newline_no_quit)
5840 (find_before_next_newline, search_command, Freplace_match)
5841 (Fmatch_data): Make some `int' variables be EMACS_INT.
5842
5843 * xdisp.c (display_count_lines): 3rd argument and return value now
5844 EMACS_INT. All callers changed.
5845 (pint2hrstr): Last argument is now EMACS_INT.
5846
5847 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5848 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5849 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5850 (decode_coding_utf_16, decode_coding_emacs_mule)
5851 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5852 (decode_coding_ccl, decode_coding_charset)
5853 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5854 (decode_coding_iso_2022, decode_coding_emacs_mule)
5855 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5856 <char_offset, last_offset>: Declare EMACS_INT.
5857 (encode_coding_utf_8, encode_coding_utf_16)
5858 (encode_coding_emacs_mule, encode_invocation_designation)
5859 (encode_designation_at_bol, encode_coding_iso_2022)
5860 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5861 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5862 Declare EMACS_INT.
5863 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5864 (encode_invocation_designation): Last argument P_NCHARS is now
5865 EMACS_INT.
5866 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5867 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5868
5869 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5870 All users changed.
5871
5872 * ccl.c (Fccl_execute_on_string): Declare some variables
5873 EMACS_INT.
5874
8546720e 58752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5876
5877 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5878
4e19a977
CS
58792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5880
5881 * process.c (Fformat_network_address): Doc fix.
5882
87302331
R
58832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5884
5885 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5886
cbb59342
CY
58872011-04-08 Chong Yidong <cyd@stupidchicken.com>
5888
5889 * keyboard.c (read_char): Call Lisp function help-form-show,
5890 instead of using internal_with_output_to_temp_buffer.
5891 (Qhelp_form_show): New var.
e0d38eeb 5892 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5893
5894 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5895
5896 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5897
e67a13ab
CY
58982011-04-06 Chong Yidong <cyd@stupidchicken.com>
5899
04f2d78b
CB
5900 * process.c (Flist_processes): Remove to Lisp.
5901 (list_processes_1): Delete.
e67a13ab 5902
973f782d
EZ
59032011-04-06 Eli Zaretskii <eliz@gnu.org>
5904
7c106b1e
EZ
5905 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5906
973f782d
EZ
5907 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5908
41cf7d1a 59092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5910
ca23cc88
PE
5911 Fix more problems found by GCC 4.6.0's static checks.
5912
f390e2d5
PE
5913 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5914
42eea0d0
PE
5915 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5916
b69769da 5917 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5918
f9541e84
PE
5919 * xdisp.c (vmessage): Mark as a printf-like function.
5920
13841b55
PE
5921 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5922
c136c10f
PE
5923 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5924
5e2d4a30
PE
5925 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5926 printf-like functions.
5927 (tiff_load): Add casts to remove these marks before passing them
5928 to system-supplied API.
5929
583f48b9
PE
5930 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5931
b25d760e
PE
5932 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5933 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5934 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5935 directly, rather than having caller test rule sign. This avoids
5936 some unnecessary tests.
5937 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5938 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5939 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5940
bc7b6697 5941 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5942 (xfont_open): Avoid unnecessary tests.
bc7b6697 5943
27ccc379
PE
5944 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5945
dcd5c89a
PE
5946 * composite.h, composite.c (composition_gstring_put_cache):
5947 Use EMACS_INT, not int, for length.
5948
b13a45c6
PE
5949 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5950 breaking out part of COMPOSITION_DECODE_RULE.
5951 (COMPOSITION_DECODE_RULE): Use it.
5952 * composite.c (get_composition_id): Remove unused local vars,
5953 by using the new macro.
5954
1e792e4d
PE
5955 * textprop.c (set_text_properties_1): Change while to do-while,
5956 since the condition is always true at first.
5957
dc6c6455 5958 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5959 (interval_deletion_adjustment): Return unsigned value.
5960 All uses changed.
dc6c6455 5961
aba7731a
PE
5962 * process.c (list_processes_1, create_pty, read_process_output):
5963 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5964 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5965 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5966 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5967 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5968
fdfc4bf3
PE
5969 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5970
fca8fe46 5971 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5972 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5973
06a0259a 5974 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5975 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5976 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5977
e7b9e80f
PE
5978 * print.c (print_error_message): Avoid int overflow.
5979
56201685
PE
5980 * font.c (font_list_entities): Redo for clarity,
5981 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5982
78834453 5983 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5984 (font_score): Avoid potential overflow in diff calculation.
78834453 5985
0bc0b309 5986 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5987 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5988
e610eaca
PE
5989 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5990
b895abce
PE
5991 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5992 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5993 can always succeed if overflow has undefined behavior.
5994
1f1d9321 5995 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5996 (wordify): Omit three unnecessary tests.
1f1d9321 5997
c59478bc
PE
5998 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5999 All callers changed. This avoids the need for an unused var.
6000
79b73827
PE
6001 * casefiddle.c (casify_region): Remove var that is set but not used.
6002
a4db5dfe
PE
6003 * dired.c (file_name_completion): Remove var that is set but not used.
6004
43aae36e
PE
6005 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6006
2a47c44d 6007 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6008 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6009
a37c69bf
PE
6010 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6011 Check for integer overflow on size calculations.
6012
328ab8e7
PE
6013 * buffer.c (Fprevious_overlay_change): Remove var that is set
6014 but not used.
6015
e5a2a5cb
PE
6016 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6017 Remove vars that are set but not used.
8d84a6eb 6018 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6019 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6020
a60e5f68
PE
6021 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6022
f661cb61 6023 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6024 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6025
f0397f5a
PE
6026 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6027 that are set but not used.
6028
8664db06 6029 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6030 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6031
6abdaa4a
PE
6032 * xselect.c (x_get_local_selection, x_handle_property_notify):
6033 Remove vars that are set but not used.
6034
0ce7538d 6035 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6036 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6037
9ae848fc
PE
6038 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6039 Remove var that is set but not used.
0b918413
PE
6040 (scroll_bar_windows_size): Now size_t, not int.
6041 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6042 Check for overflow.
9ae848fc 6043
a5a62657
PE
6044 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6045 (map_tty_color) [!defined MSDOS]: Likewise.
6046
5c5cdd39
PE
6047 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6048
66ebf983
PE
6049 * coding.c: Remove vars that are set but not used.
6050 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6051 All callers changed.
6052 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6053 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6054 (decode_coding_charset): Remove vars that are set but not used.
6055
1be4d761
PE
6056 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6057 that is set but not used.
6058
47553fa8
PE
6059 * print.c (print_object): Remove var that is set but not used.
6060
1f7196bf 6061 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6062 The gnulib version avoids calling malloc in the usual case,
6063 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6064 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6065 * filelock.c (current_lock_owner): Likewise.
6066 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6067 * sysdep.c: Include allocator.h, careadlinkat.h.
6068 (emacs_no_realloc_allocator): New static constant.
6069 (emacs_readlink): New function.
fdb61804
PE
6070 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6071 ../lib/careadlinkat.h.
d1fdcab7 6072
f84c17c7
SM
60732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6074
6075 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6076 first non-nil return value).
6077
ef3862ad
JD
60782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6079
6080 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6081 if not defined (Bug#8403).
6082
376a7006
JB
60832011-04-02 Juanma Barranquero <lekktu@gmail.com>
6084
6085 * xdisp.c (display_count_lines): Remove parameter `start',
6086 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6087 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6088 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6089 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6090 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6091 and thereabouts. All callers changed.
6092 (get_per_char_metric): Remove parameter `f', unused since
6093 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6094
6ca3801d
JM
60952011-04-02 Jim Meyering <meyering@redhat.com>
6096
6097 do not dereference NULL upon failed strdup
6098 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6099 (ns_get_family): Likewise.
6100
d8e2b5ba
JB
61012011-04-02 Juanma Barranquero <lekktu@gmail.com>
6102
6103 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6104
8c74fcbd
JD
61052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6106
6107 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6108 later (Bug#8403).
6109
7200d79c
SM
61102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6111
03408648 6112 Add lexical binding.
7200d79c 6113
03408648
SM
6114 * window.c (Ftemp_output_buffer_show): New fun.
6115 (Fsave_window_excursion):
6116 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6117
6118 * lread.c (lisp_file_lexically_bound_p): New function.
6119 (Fload): Bind Qlexical_binding.
6120 (readevalloop): Remove `evalfun' arg.
6121 Bind Qinternal_interpreter_environment.
6122 (Feval_buffer): Bind Qlexical_binding.
6123 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6124 Mark as dynamic.
6125 (syms_of_lread): Declare `lexical-binding'.
6126
6127 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6128
6129 * keyboard.c (eval_dyn): New fun.
6130 (menu_item_eval_property): Use it.
ca105506
SM
6131
6132 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6133
03408648
SM
6134 * fns.c (concat, mapcar1): Accept byte-code-functions.
6135
6136 * eval.c (Fsetq): Handle lexical vars.
6137 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6138 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6139 (FletX, Flet): Obey lexical binding.
6140 (Fcommandp): Handle closures.
6141 (Feval): New `lexical' arg.
6142 (eval_sub): New function extracted from Feval. Use it almost
6143 everywhere where Feval was used. Look up vars in lexical env.
6144 Handle closures.
6145 (Ffunctionp): Move from subr.el.
6146 (Ffuncall): Handle closures.
6147 (apply_lambda): Remove `eval_flags'.
6148 (funcall_lambda): Handle closures and new byte-code-functions.
6149 (Fspecial_variable_p): New function.
6150 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6151 but without exporting it to Lisp.
23aba0ea 6152
23aba0ea 6153 * doc.c (Fdocumentation, store_function_docstring):
03408648 6154 * data.c (Finteractive_form): Handle closures.
23aba0ea 6155
03408648
SM
6156 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6157 interactive spec.
ba83908c 6158
04f2d78b
CB
6159 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6160 New byte-codes.
03408648
SM
6161 (exec_byte_code): New function extracted from Fbyte_code to handle new
6162 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6163
03408648 6164 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6165
03408648 6166 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6167
e2abce01
JB
61682011-03-31 Juanma Barranquero <lekktu@gmail.com>
6169
6170 * xdisp.c (redisplay_internal): Fix prototype.
6171
63696a73 61722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6173
63696a73 6174 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6175 (try_scrolling): Use it when setting scroll_limit.
6176 Limit scrolling to 100 screen lines.
63696a73
EZ
6177 (redisplay_window): Even when falling back on "recentering",
6178 position point in the window according to scroll-conservatively,
6179 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6180
6181 (try_scrolling): When point is above the window, allow searching
6182 as far as scroll_max, or one screenful, to compute vertical
6183 distance from PT to the scroll margin position. This prevents
6184 try_scrolling from unnecessarily failing when
6185 scroll-conservatively is set to a value slightly larger than the
6186 window height. Clean up the case of PT below the margin at bottom
6187 of window: scroll_max can no longer be INT_MAX. When aggressive
6188 scrolling is in use, don't let point enter the opposite scroll
6189 margin as result of the scroll.
6190 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6191 threshold of 100 lines for never-recentering scrolling.
6192
e4cc2dfc
JB
61932011-03-31 Juanma Barranquero <lekktu@gmail.com>
6194
6195 * dispextern.h (move_it_by_lines):
6196 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6197 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6198 (message_log_check_duplicate): Remove parameters `prev_bol' and
6199 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6200 (redisplay_internal): Remove parameter `preserve_echo_area',
6201 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6202
6203 * indent.c (Fvertical_motion):
6204 * window.c (window_scroll_pixel_based, Frecenter):
6205 Don't pass `need_y_p' to `move_it_by_lines'.
6206
1c470562
SM
62072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6208
44f230aa
SM
6209 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6210 steal a few bits to be more compact.
6211 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6212 Remove unneeded casts.
6213
1c470562
SM
6214 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6215
888adce9
ZK
62162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6217
6218 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6219 binding" message (bug#7967).
6220
f838ed7b
PE
62212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6222
77861b95
PE
6223 Fix more problems found by GCC 4.6.0's static checks.
6224
de6dbc14
PE
6225 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6226 Remove unused local var.
6227
f838ed7b
PE
6228 * editfns.c (Fmessage_box): Remove unused local var.
6229
792c7b2b
PE
6230 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6231 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6232 Omit unused local vars.
c499e557 6233 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6234 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6235 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6236 Omit unused local var.
6237
ba0165e1
PE
6238 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6239 Don't assume string length fits in int.
32ad8845 6240 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6241 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6242
3c59b4c9
PE
6243 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6244 instead of alloca (Bug#8344).
6245
a3eed478 6246 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6247 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6248
eb4d412d
PE
6249 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6250
1658b401
PE
6251 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6252 concerns.
6253
6254 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6255
6256 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6257
9a2c6e05
PE
6258 * keyboard.c (syms_of_keyboard): Use the same style as later
6259 in this function when indexing through an array. This also
6260 works around GCC bug 48267.
6261
03d0a109
PE
6262 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6263
44f730c8
PE
6264 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6265
fe75f926
PE
6266 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6267 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6268
ffa8c828
PE
6269 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6270 This avoids undefined behavior on integer overflow, and is a bit
6271 more convenient anyway since it is compared to a size_t variable.
6272
c5101a77
PE
6273 Variadic C functions now count arguments with size_t, not int.
6274 This avoids an unnecessary limitation on 64-bit machines, which
6275 caused (substring ...) to crash on large vectors (Bug#8344).
6276 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6277 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6278 All variadic functions and their callers changed accordingly.
c5101a77
PE
6279 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6280 * data.c (arith_driver, float_arith_driver): Likewise.
6281 * editfns.c (general_insert_function): Likewise.
6282 * eval.c (struct backtrace.nargs, interactive_p)
6283 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6284 (funcall_lambda, mark_backtrace): Likewise.
6285 * fns.c (concat): Likewise.
6286 * frame.c (x_set_frame_parameters): Likewise.
6287 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6288 0 if not found, not -1. All callers changed.
6289
dd3f25f7
PE
6290 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6291 (stack_copy_size): Now size_t, not int.
6292 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6293
461c2ab9
JB
62942011-03-28 Juanma Barranquero <lekktu@gmail.com>
6295
6296 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6297 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6298 All callers changed.
6299
6300 * lisp.h (multibyte_char_to_unibyte):
6301 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6302 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6303 * character.h (CHAR_TO_BYTE8):
6304 * cmds.c (internal_self_insert):
6305 * editfns.c (general_insert_function):
6306 * keymap.c (push_key_description):
6307 * search.c (Freplace_match):
6308 * xdisp.c (message_dolog, set_message_1): All callers changed.
6309
f6d62986
SM
63102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6311
6312 * keyboard.c (safe_run_hook_funcall): New function.
6313 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6314 don't set the hook to nil, but remove the offending function instead.
6315 (Qcommand_hook_internal): Remove, unused.
6316 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6317 Vcommand_hook_internal.
6318
6319 * eval.c (enum run_hooks_condition): Remove.
6320 (funcall_nil, funcall_not): New functions.
6321 (run_hook_with_args): Call each function through a `funcall' argument.
6322 Remove `cond' argument, now redundant.
6323 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6324 (Frun_hook_with_args_until_failure): Adjust accordingly.
6325 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6326
1db5b1ad
JB
63272011-03-28 Juanma Barranquero <lekktu@gmail.com>
6328
6329 * dispextern.h (string_buffer_position): Remove declaration.
6330
6331 * print.c (strout): Remove parameter `multibyte', unused since
6332 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6333
6334 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6335 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6336 All callers changed.
6337
6338 * w32.c (_wsa_errlist): Use braces for struct initializers.
6339
6340 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6341 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6342 All callers changed.
6343 (string_buffer_position): Likewise. Also, make static (it's never
6344 used outside xdisp.c).
6345 (cursor_row_p): Remove parameter `w', unused since
6346 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6347 (decode_mode_spec): Remove parameter `precision', introduced during
6348 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6349 All callers changed.
6350
5ffb62aa
JD
63512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6352
6353 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6354
461c2ab9 63552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6356
6357 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6358 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6359 (ns_update_auto_hide_menu_bar): New functions.
6360 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6361 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6362 ns_constrain_all_frames.
6363 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6364 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6365
5c380ffb
JD
63662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6367
6368 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6369
9af30bdf
GM
63702011-03-27 Glenn Morris <rgm@gnu.org>
6371
6372 * syssignal.h: Replace RETSIGTYPE with void.
6373 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6374 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6375 Replace SIGTYPE with void everywhere.
6376 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6377 * s/template.h (SIGTYPE): Remove commented out definition.
6378
e2abce01
JB
63792011-03-26 Eli Zaretskii <eliz@gnu.org>
6380
6381 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6382 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6383
f868cd8a
JB
63842011-03-26 Juanma Barranquero <lekktu@gmail.com>
6385
59eb0929
JB
6386 * w32.c (read_unc_volume): Use parameter `henum', instead of
6387 global variable `wget_enum_handle'.
6388
6389 * keymap.c (describe_vector): Remove parameters `indices' and
6390 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6391 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6392
f868cd8a
JB
6393 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6394
6395 * keyboard.c (timer_check): Remove parameter `do_it_now',
6396 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6397 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6398 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6399
6400 * keyboard.c (read_char):
6401 * w32menu.c (w32_menu_display_help):
6402 * xmenu.c (show_help_event, menu_help_callback):
6403 Adjust calls to `show_help_echo'.
6404
6405 * gtkutil.c (xg_maybe_add_timer):
6406 * keyboard.c (readable_events):
6407 * process.c (wait_reading_process_output):
6408 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6409
6410 * insdel.c (adjust_markers_gap_motion):
6411 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6412 (gap_left, gap_right): Don't call it.
6413
2ecf6fdb
CY
64142011-03-25 Chong Yidong <cyd@stupidchicken.com>
6415
6416 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6417 incurred during fontification.
6418
6b1f9ba4
JB
64192011-03-25 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6422 (DEFVAR_PER_BUFFER): Don't pass it.
6423
6424 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6425 (scrolling_window): Don't pass it.
6426
0f4a96b5
JB
64272011-03-25 Juanma Barranquero <lekktu@gmail.com>
6428
6429 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6430
6431 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6432 and `suffix'.
6433 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6434 of variables specific to SELinux and computation of `encoded_absname'.
6435
6436 * image.c (XPutPixel): Remove unused variable `height'.
6437
6438 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6439
6440 * unexw32.c (get_section_info): Remove unused variable `section'.
6441
6442 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6443 (system_process_attributes): Remove unused variable `sess'.
6444 (sys_read): Remove unused variable `err'.
6445
6446 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6447 (w32_wnd_proc): Remove unused variable `isdead'.
6448 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6449 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6450 (x_create_tip_frame): Remove unused variable `tem'.
6451
6452 * w32inevt.c (w32_console_read_socket):
6453 Remove unused variable `no_events'.
6454
6455 * w32term.c (x_draw_composite_glyph_string_foreground):
6456 Remove unused variable `width'.
6457
1149507c
JB
64582011-03-24 Juanma Barranquero <lekktu@gmail.com>
6459
6460 * w32term.c (x_set_glyph_string_clipping):
6461 Don't pass uninitialized region to CombineRgn.
6462
9c88f339
JB
64632011-03-23 Juanma Barranquero <lekktu@gmail.com>
6464
6465 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6466 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6467 (Fx_close_connection): Remove unused variable `i'.
6468
6469 * w32font.c (w32font_draw): Return number of glyphs.
6470 (w32font_open_internal): Remove unused variable `i'.
6471 (w32font_driver): Add missing initializer.
6472
6473 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6474 (fill_in_menu): Remove unused variable `items_added'.
6475
6476 * w32term.c (last_mouse_press_frame): Remove static global variable.
6477 (w32_clip_to_row): Remove unused variable `f'.
6478 (x_delete_terminal): Remove unused variable `i'.
6479
6480 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6481 (NOTHING): Remove unused static global variable.
6482 (uniscribe_check_otf): Remove unused variable `table'.
6483 (uniscribe_font_driver): Add missing initializers.
6484
dee091a3
JD
64852011-03-23 Julien Danjou <julien@danjou.info>
6486
6487 * term.c (Fsuspend_tty, Fresume_tty):
6488 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6489 * window.c (temp_output_buffer_show):
6490 * insdel.c (signal_before_change):
6491 * frame.c (Fhandle_switch_frame):
6492 * fileio.c (Fdo_auto_save):
6493 * emacs.c (Fkill_emacs):
6494 * editfns.c (save_excursion_restore):
6495 * cmds.c (internal_self_insert):
6496 * callint.c (Fcall_interactively):
6497 * buffer.c (Fkill_all_local_variables):
6498 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6499 Use Frun_hooks.
0f4a96b5 6500 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6501 unconditionnaly since it does the check itself.
6502
2c520ab5 65032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6504
c9c49752
PE
6505 Fix more problems found by GCC 4.5.2's static checks.
6506
8abc3f12
PE
6507 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6508 the first time through the loop, since we know p0 < p1 then.
6509 This also avoids a gcc -Wstrict-overflow warning.
6510
a2d26660
PE
6511 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6512 leading to a memory leak, possible in functions like
6513 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6514 of objects (Bug#8318).
a2d26660 6515
916c72e9
PE
6516 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6517 that could (at least in theory) be that large.
6518
19ab8a18
PE
6519 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6520 This is less likely to overflow, and avoids undefined behavior if
6521 overflow does occur. All callers changed. Use strtoul to scan
6522 for the unsigned long integer.
b7cbbd6f
PE
6523 (pint2hrstr): Simplify and tune code slightly.
6524 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6525
f0641eff
PE
6526 * scroll.c (do_scrolling): Work around GCC bug 48228.
6527 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6528
7f650bb9
PE
6529 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6530 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6531 (validate_x_resource_name): Simplify count usage.
6532 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6533
37dd57d1
PE
6534 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6535 fail (Bug#8306).
81e56e61 6536
699979fc 6537 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6538
401bf9b4
PE
6539 * process.c (Fmake_network_process): Use socklen_t, not int,
6540 where POSIX says socklen_t is required in portable programs.
6541 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6542 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6543 (Fmake_network_process, server_accept_connection):
6544 (wait_reading_process_output, read_process_output):
6545 Likewise.
6546
b93aacde
PE
6547 * process.c: Rename or move locals to avoid shadowing.
6548 (list_processes_1, Fmake_network_process):
6549 (read_process_output_error_handler, exec_sentinel_error_handler):
6550 Rename or move locals.
4dc343ee 6551 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6552 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6553 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6554 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6555 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6556
af8a867c 6557 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6558 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6559 Include tparam.h instead, since it declares them.
af8a867c
PE
6560 * cm.h (PC): Remove extern decl; tparam.h now does this.
6561 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6562 * terminfo.c: Include tparam.h, to check interfaces.
6563 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6564 (tparam): Adjust signature to match interface in tparam.h;
6565 this removes some undefined behavior. Check that outstring and len
6566 are zero, which they always are with Emacs.
6567 * tparam.h (PC, BC, UP): New extern decls.
6568
0248044d 6569 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6570 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6571
8ff096c1 6572 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6573 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6574 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6575 (ftfont_list): Remove unused local.
49eaafba
PE
6576 (get_adstyle_property, ftfont_pattern_entity):
6577 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6578 Rename locals to avoid shadowing.
8ff096c1 6579
e2be39f6
PE
6580 * xfont.c (xfont_list_family): Mark var as initialized.
6581
c9735e30
PE
6582 * xml.c (make_dom): Now static.
6583
8f5201ae
PE
6584 * composite.c (composition_compute_stop_pos): Rename local to
6585 avoid shadowing.
b246f932
PE
6586 (composition_reseat_it): Remove unused locals.
6587 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6588 (composition_update_it): Mark var as initialized.
11b61122
PE
6589 (find_automatic_composition): Mark vars as initialized,
6590 with a FIXME (Bug#8290).
8f5201ae 6591
760fbc2c
PE
6592 character.h: Rename locals to avoid shadowing.
6593 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6594 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6595 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6596 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6597 to avoid shadowing.
6598
ff08eb85
PE
6599 * textprop.c (property_change_between_p): Remove; unused.
6600
fc7bf025
PE
6601 * intervals.c (interval_start_pos): Now static.
6602
235d7abc
PE
6603 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6604
44f230aa
SM
6605 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6606 Rename locals to avoid shadowing.
3e7d6594 6607
50060332
PE
6608 * sound.c (wav_play, au_play, Fplay_sound_internal):
6609 Fix pointer signedness.
d01f234b 6610 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6611 (wav_play): Initialize a variable to 0, to prevent undefined
6612 behavior (Bug#8278).
50060332 6613
c4fc4e30
PE
6614 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6615
918436ed
PE
6616 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6617
c939f91b
PE
6618 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6619 clobbering (Bug#8298).
b9c7f648
PE
6620 * sysdep.c (sys_subshell): Likewise.
6621 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6622
6bd8c144
PE
6623 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6624 This should get cleaned up, so that child_setup has the
6625 same signature on all platforms.
6626
7710357c 6627 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6628 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6629
c59da222
CY
66302011-03-22 Chong Yidong <cyd@stupidchicken.com>
6631
6632 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6633 not to be necessary, and produces flickering.
6634
66b87493
GM
66352011-03-20 Glenn Morris <rgm@gnu.org>
6636
6637 * config.in: Remove file.
6638
45b6f6d5
JB
66392011-03-20 Juanma Barranquero <lekktu@gmail.com>
6640
6641 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6642 are now in src/globals.h.
6643 (syms_of_minibuf): Remove spurious & from previous change.
6644
3ec03f7e
LL
66452011-03-20 Leo <sdl.web@gmail.com>
6646
6647 * minibuf.c (completing-read-function): New variable.
6648 (completing-read-default): Rename from completing-read.
6649 (completing-read): Call completing-read-function.
6650
b14e3e21
CY
66512011-03-19 Juanma Barranquero <lekktu@gmail.com>
6652
6653 * xfaces.c (Fx_load_color_file):
6654 Read color file from absolute filename (bug#8250).
6655
f2b726e6
JB
66562011-03-19 Juanma Barranquero <lekktu@gmail.com>
6657
6658 * makefile.w32-in: Update dependencies.
6659
09f6ff02
EZ
66602011-03-17 Eli Zaretskii <eliz@gnu.org>
6661
6662 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6663
29a6015a
PE
66642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6665
a3a6c54e
PE
6666 Fix more problems found by GCC 4.5.2's static checks.
6667
b766f867
PE
6668 * process.c (make_serial_process_unwind, send_process_trap):
6669 (sigchld_handler): Now static.
6670
be02381c
PE
6671 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6672 That way, the code declares only the vars that it needs.
6673 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6674 * s/cygwin.h (PTY_ITERATION): Likewise.
6675 * s/darwin.h (PTY_ITERATION): Likewise.
6676 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6677
57048744
PE
6678 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6679 * process.c (allocate_pty): Don't declare stb unless it's needed.
6680
7914961c 6681 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6682 (CONSTANTLIM): Remove; unused.
6683 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6684 Define only if needed.
7914961c 6685
b3967b18
PE
6686 * unexelf.c (unexec): Name an expression,
6687 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6688 Use a different way to cause a compilation error if anyone uses
6689 n rather than nn, a way that does not involve shadowing.
73366a00 6690 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6691
29a6015a
PE
6692 * deps.mk (unexalpha.o): Remove; unused.
6693
43cfc33e 6694 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6695 * unexec.h: New file.
ce701a33
PE
6696 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6697 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6698 Depend on unexec.h.
6699 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6700 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6701 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6702 Change as necessary to match prototype in unexec.h.
ce701a33 6703
01f44d5a
PE
6704 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6705 shadowing.
4f63c6bb 6706 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6707
a6670b0b
PE
6708 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6709 Rename locals to avoid shadowing.
6710
cef2010d 6711 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6712 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6713
d4d7173a
PE
6714 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6715
f08b802a
PE
6716 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6717 warning when compiling print.c.
6718
3ddb0639
PE
6719 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6720 instead of using an uninitialized var.
5ad03b97 6721 (font_sort_entities): Mark var as initialized.
3ddb0639 6722
170a2692
PE
6723 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6724
e663c700
PE
6725 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6726 pointers to constants.
89bc529a 6727 (font_parse_fcname): Remove unused vars.
7b81e2d0 6728 (font_delete_unmatched): Now static.
ea838e10 6729 (font_get_spec): Remove; unused.
13a547c6
PE
6730 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6731 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6732 Rename or move locals to avoid shadowing.
e663c700 6733
2a80c887 6734 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6735 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6736
1384fa33 6737 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6738 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6739
8b2c52e9
PE
6740 * alloc.c (mark_backtrace): Move decl from here ...
6741 * lisp.h: ... to here, so that it can be checked.
6742
475545b5 6743 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6744 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6745 (lisp_indirect_variable): Name an expression,
6746 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6747 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6748
b1349114 6749 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6750 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6751 Use const pointer when appropriate.
b1349114 6752
a2928364
PE
6753 * lisp.h (get_system_name, get_operating_system_release):
6754 Move decls here, to check interfaces.
6755 * process.c (get_operating_system_release): Move decl to lisp.h.
6756 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6757 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6758 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6759 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6760 (Fformat_time_string, Fencode_time, Finsert_char):
6761 (Ftranslate_region_internal, Fformat):
6762 Rename or remove local vars to avoid shadowing.
9710023e 6763 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6764
a415e694
PE
6765 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6766 avoid shadowing.
6767
8ef4622d
PE
6768 * lisp.h (eassert): Check that the argument compiles, even if
6769 ENABLE_CHECKING is not defined.
6770
946f9a5b
PE
6771 * data.c (Findirect_variable): Name an expression, to avoid
6772 gcc -Wbad-function-cast warning.
112396d6 6773 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6774 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6775 (Fmake_variable_buffer_local, Fmake_local_variable):
6776 Mark variables as initialized.
52746918 6777 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6778
e5aab7e7 6779 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6780 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6781 Rename locals to avoid shadowing.
dff45157
PE
6782 (mark_stack): Move local variables into the #ifdef region where
6783 they're used.
7bc26fdb
PE
6784 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6785 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6786 needed otherwise.
6787 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6788 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6789 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6790
e5aab7e7
PE
6791 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6792 avoids undefined behavior in theory.
6793
4da60324
PE
6794 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6795
88043301
PE
6796 Use functions, not macros, for up- and down-casing (Bug#8254).
6797 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6798 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6799 to use the following functions instead of these macros.
6800 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6801 EMACS_INT, since callers assume the returned value fits in int.
6802 (upcase1): Likewise, for UPCASE_TABLE.
6803 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6804 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6805 the race-condition problem in the old DOWNCASE.
88043301 6806
19ed5445
PE
6807 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6808 Rename locals to avoid shadowing.
6809 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6810 (regex_compile, re_search_2, re_match_2_internal):
6811 Remove unused local vars.
952db0d7
PE
6812 (FREE_VAR): Rewrite so as not to use empty "else",
6813 which gcc can warn about.
da053e48 6814 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6815 (RETALLOC_IF): Define only if needed.
6816 (WORDCHAR_P): Likewise. This one is never needed, but is used
6817 only in a comment talking about a compiler bug, so put inside
6818 the #if 0 of that comment.
6819 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6820 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6821 Remove; unused.
19ed5445 6822
1f3561e4 6823 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6824 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6825 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6826
ded6f8f7
PE
6827 * search.c (simple_search): Remove unused var.
6828
dbd37a95
PE
6829 * dired.c (compile_pattern): Move decl from here ...
6830 * lisp.h: ... to here, so that it can be checked.
6831 (struct re_registers): New forward decl.
6832
7e47afad
PE
6833 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6834
85f24f61
PE
6835 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6836 All uses changed.
6837 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6838 Rename locals to avoid shadowing.
5671df8f 6839 (Fvertical_motion): Mark locals as initialized.
85f24f61 6840
181aa2be 6841 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6842 (casify_region): Mark local as initialized.
181aa2be 6843
930d429c
PE
6844 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6845
7082eac6
PE
6846 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6847 New macros, so that the caller can use some names other than
6848 gcpro1, gcpro2, etc.
6849 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6850 of the new macros.
6851 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6852 argument, for consistency with GCPRO2_VAR, etc: it is now the
6853 prefix of the variable, not the variable itself. All uses
6854 changed.
38b2c076
PE
6855 * dired.c (directory_files_internal, file_name_completion):
6856 Rename locals to avoid shadowing.
6857
15206ed9
PE
6858 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6859 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6860 dired.c's scmp function, had undefined behavior.
6861 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6862 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6863 * buffer.h: ... to here, because these macros use current_buffer,
6864 and the new implementation with inline functions needs to have
6865 current_buffer in scope now, rather than later when the macros
6866 are used.
6867 (downcase, upcase1): New static inline functions.
6868 (DOWNCASE, UPCASE1): Reimplement using these functions.
6869 This avoids undefined behavior in expressions like
6870 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6871 from race conditions in accessing the global variables
6872 case_temp1 and case_temp2.
6873 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6874 * lisp.h (case_temp1, case_temp2): Remove their decls.
6875 * character.h (ASCII_CHAR_P): Move from here ...
6876 * lisp.h: ... to here, so that the inline functions mentioned
6877 above can use them.
6878
4a6bea26
PE
6879 * dired.c (directory_files_internal_unwind): Now static.
6880
f14b7e14
PE
6881 * fileio.c (file_name_as_directory, directory_file_name):
6882 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6883 Now static.
2893f146
PE
6884 (file_name_as_directory): Use const pointers when appropriate.
6885 (Fexpand_file_name): Likewise. In particular, newdir might
6886 point at constant storage, so make it a const pointer.
fd4ead52 6887 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6888 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6889 signedness issues.
f839df0c
PE
6890 (Fset_file_times, Finsert_file_contents, auto_save_error):
6891 Rename locals to avoid shadowing.
f14b7e14 6892
5716756e 6893 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6894 (Ftry_completion, Fall_completions): Rename or remove locals
6895 to avoid shadowing.
5716756e 6896
b4c3046a
PE
6897 * marker.c (bytepos_to_charpos): Remove; unused.
6898
b45db522
PE
6899 * lisp.h (verify_bytepos, count_markers): New decls,
6900 so that gcc does not warn that these functions aren't declared.
6901
85876d07
PE
6902 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6903 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6904 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6905 (copy_text): Remove unused local var.
85876d07 6906
03d78a21 6907 * filelock.c (within_one_second): Now static.
b3dd38ab 6908 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6909
5df8f01b
PE
6910 * buffer.c (fix_overlays_before): Mark locals as initialized.
6911 (fix_start_end_in_overlays): Likewise. This function should be
6912 simplified by using pointers-to-pointers, but that's a different
6913 matter.
b1d876f1 6914 (switch_to_buffer_1): Now static.
8f54f30a
PE
6915 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6916 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6917
a70072c9 6918 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6919 Fix pointer signedness issue.
edced198
PE
6920 (sys_subshell): Mark local as volatile if checking for lint,
6921 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6922 (MAXPATHLEN): Define only if needed.
a70072c9 6923
a0977c44
PE
6924 * process.c (serial_open, serial_configure): Move decls from here ...
6925 * systty.h: ... to here, so that they can be checked.
6926
a884fdcc
PE
6927 * fns.c (get_random, seed_random): Move extern decls from here ...
6928 * lisp.h: ... to here, so that they can be checked.
6929
604efe86 6930 * sysdep.c (reset_io): Now static.
b8950c94 6931 (wait_for_termination_signal): Remove; unused.
604efe86 6932
38fc62d9
PE
6933 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6934 (copy_keymap_item, append_key, push_text_char_description):
6935 Now static.
1004a21a 6936 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6937 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6938 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6939 (describe_map_tree):
6940 Rename locals to avoid shadowing.
38fc62d9 6941
2f2650da
PE
6942 * keyboard.c: Declare functions static if they are not used elsewhere.
6943 (echo_char, echo_dash, cmd_error, top_level_2):
6944 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6945 (read_char, kbd_buffer_get_event, make_lispy_position):
6946 (make_lispy_event, make_lispy_movement, apply_modifiers):
6947 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6948 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6949 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6950 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6951 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6952
a053e86c 6953 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6954 (mark_kboards): Move decl here ...
6955 * alloc.c (mark_kboards): ... from here.
a053e86c 6956
4752793e
PE
6957 * lisp.h (force_auto_save_soon): New decl.
6958
74f10ca7 6959 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6960 (DEFINE_DUMMY_FUNCTION): New macro.
6961 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6962 Use it.
c03cd23f
PE
6963 (main): Add casts to avoid warnings
6964 if GCC considers string literals to be constants.
74f10ca7 6965
022e70d4
PE
6966 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6967
59d6fe83
PE
6968 * dbusbind.c: Pointer signedness fixes.
6969 (xd_signature, xd_append_arg, xd_initialize):
6970 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6971 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6972 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6973 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6974
78320123
PE
6975 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6976 if GCC considers string literals to be constants.
49cebcca 6977 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6978
35ac2a97
SM
69792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6980
fb103ca9
SM
6981 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6982 (print_preprocess, print_object): New macro to fix last change.
6983
35ac2a97
SM
6984 * print.c (print_preprocess): Don't forget font objects.
6985
62973b41
JB
69862011-03-16 Juanma Barranquero <lekktu@gmail.com>
6987
6988 * emacs.c (USAGE3): Doc fixes.
6989
0e48bb22
AS
69902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6991
6992 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6993 structure.
6994
7684e57b
JB
69952011-03-14 Juanma Barranquero <lekktu@gmail.com>
6996
6997 * lisp.h (VWindow_system, Qfile_name_history):
6998 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6999 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7000 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7001
7002 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7003 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7004
7005 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7006 * w32console.c (detect_input_pending, read_input_pending)
7007 (encode_terminal_code):
7008 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7009 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7010 (w32_system_caret_y, Qfile_name_history):
7011 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7012 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7013 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7014 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7015 * w32proc.c (Qlocal, report_file_error):
7016 * w32term.c (Vwindow_system, updating_frame):
7017 * w32uniscribe.c (initialized, uniscribe_font_driver):
7018 Remove unneeded extern declarations.
7019
2aa46d6c
CY
70202011-03-14 Chong Yidong <cyd@stupidchicken.com>
7021
c96bbc66 7022 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7023
cffc6f3b
CY
70242011-03-13 Chong Yidong <cyd@stupidchicken.com>
7025
7026 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7027 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7028 These macros can no longer be used for assignment.
7029
44f230aa
SM
7030 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7031 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7032 (record_buffer_markers, fetch_buffer_markers): New functions for
7033 recording and fetching special buffer markers.
7034 (set_buffer_internal_1, set_buffer_temp): Use them.
7035
7036 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7037
7038 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7039
7040 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7041 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7042
7043 * xdisp.c (hscroll_window_tree):
7044 (reconsider_clip_changes): Use PT instead of BUF_PT.
7045
d251f04b
EZ
70462011-03-13 Eli Zaretskii <eliz@gnu.org>
7047
7048 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7049 $(EMACS_ROOT)/lib/intprops.h.
7050
f0c77cd1
PE
70512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7052
3eca4629
PE
7053 Fix more problems found by GCC 4.5.2's static checks.
7054
7c86ee98
PE
7055 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7056 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7057 (xg_free_frame_widgets): Make it clear that a local variable is
7058 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7059 (gdk_window_get_screen): Make it clear that this macro is needed
7060 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7061 (int_gtk_range_get_value): New function, which avoids a diagnostic
7062 from gcc -Wbad-function-cast.
7063 (xg_set_toolkit_scroll_bar_thumb): Use it.
7064 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7065 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7066 (get_utf8_string, xg_get_file_with_chooser):
7067 Rename locals to avoid shadowing.
7068 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7069
41729b81
PE
7070 * xgselect.c (xg_select): Remove unused var.
7071
f0c77cd1
PE
7072 * image.c (four_corners_best): Mark locals as initialized.
7073 (gif_load): Initialize transparent_p to zero (Bug#8238).
7074 Mark another local as initialized.
ec6cf4c6 7075 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7076
ce0ad53d 7077 * image.c (clear_image_cache): Now static.
d5d5a617 7078 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7079 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7080 (x_edge_detection): Remove unnecessary cast that
7081 gcc -Wbad-function-cast diagnoses.
2037898d 7082 (gif_load): Fix pointer signedness.
6ae141d6
PE
7083 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7084 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7085
33383987 70862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7087
d32df629
PE
7088 Improve quality of tests for time stamp overflow.
7089 For example, without this patch (encode-time 0 0 0 1 1
7090 1152921504606846976) returns the obviously-bogus value (-948597
7091 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7092 reports time overflow. See
7093 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7094 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7095 * editfns.c: Include limits.h and intprops.h.
7096 (TIME_T_MIN, TIME_T_MAX): New macros.
7097 (time_overflow): Move earlier, to before first use.
7098 (hi_time, lo_time): New functions, for an accurate test for
7099 out-of-range times.
7100 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7101 (Fget_internal_run_time): Don't assume time_t fits in int.
7102 (make_time): Use list2 instead of Fcons twice.
7103 (Fdecode_time): More accurate test for out-of-range times.
7104 (check_tm_member): New function.
7105 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7106 (lisp_time_argument): Don't rely on undefined left-shift and
7107 right-shift behavior when checking for time stamp overflow.
8be6f318 7108
fe31d94c
PE
7109 * editfns.c (time_overflow): New function, refactoring common code.
7110 (Fformat_time_string, Fdecode_time, Fencode_time):
7111 (Fcurrent_time_string): Use it.
7112
8be6f318
PE
7113 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7114 * dired.c (make_time): Move to ...
7115 * editfns.c (make_time): ... here.
7116 * systime.h: Note the move.
7117
09d9db2c 71182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7119
126bc0dc
YM
7120 * fringe.c (update_window_fringes): Remove unused variables.
7121
c47cbdfd
YM
7122 * unexmacosx.c (copy_data_segment): Also copy __got section.
7123 (Bug#8223)
7124
7ac80be9
EZ
71252011-03-12 Eli Zaretskii <eliz@gnu.org>
7126
c96bbc66 7127 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7128 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7129 Constify `char *' arguments and their references according to
7130 prototypes in tparam.h.
7131
ecb0f94d 7132 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7133
7ac80be9
EZ
7134 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7135 Adapt all references accordingly.
7136
7137 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7138
ef1fd07e
TT
71392011-03-11 Tom Tromey <tromey@redhat.com>
7140
7141 * buffer.c (syms_of_buffer): Remove obsolete comment.
7142
7ef4b50c
EZ
71432011-03-11 Eli Zaretskii <eliz@gnu.org>
7144
7145 * termhooks.h (encode_terminal_code): Declare prototype.
7146
7147 * msdos.c (encode_terminal_code): Don't declare prototype.
7148
7149 * term.c (encode_terminal_code): Now external again, used by
7150 w32console.c and msdos.c.
7151
44f230aa
SM
7152 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7153 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7154
4b1ec863 71552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7156
1714f52b 7157 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7158
4b1ec863
PE
7159 * fringe.c (update_window_fringes): Mark locals as initialized
7160 (Bug#8227).
7161 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7162
524c7aa6
PE
7163 * alloc.c (mark_fringe_data): Move decl from here ...
7164 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7165 to check its interface.
7166 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7167
a5c0af81 7168 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7169 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7170 (fontset_font): Mark local as initialized.
a9a06e0b 7171 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7172
b4716021
PE
7173 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7174
811e9bac 7175 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7176 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7177 (x_own_selection, Fx_disown_selection_internal): Rename locals
7178 to avoid shadowing.
7179 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7180
7e3ab302
PE
7181 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7182 so that the caller can use some name other than gcpro1.
7183 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7184 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7185 (Fx_backspace_delete_keys_p):
7186 Use them to avoid shadowing, and rename vars to avoid shadowing.
7187 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7188 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7189 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7190 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7191 Remove unused locals.
7e3ab302
PE
7192 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7193 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7194 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7195 macros.
f78faa98 7196
e2b13473
PE
7197 * xterm.h (x_mouse_leave): New decl.
7198
77f23912
PE
7199 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7200 Remove unused functions.
cdf4ba58
PE
7201 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7202 (x_calc_absolute_position): Now static.
7411c686 7203 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7204 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7205 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7206 unless they are used.
38d0b34a
PE
7207 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7208 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7209 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7210 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7211 (x_error_catcher, x_connection_closed, x_error_handler):
7212 (x_error_quitter, xembed_send_message, x_iconify_frame):
7213 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7214 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7215 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7216
44f230aa
SM
7217 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7218 Rename or move locals to avoid shadowing.
6b463e58 7219 (tty_defined_color, merge_face_heights): Now static.
5967d051 7220 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7221 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7222 does not deduce is never used uninitialized.
73719eba
PE
7223 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7224 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7225
426994c3 7226 * terminal.c (store_terminal_param): Now static.
5489860b 7227
032f1620 7228 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7229 (set_frame_menubar): Remove unused local.
d4323972 7230 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7231 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7232 since they might point to immutable storage.
281585b0
PE
7233 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7234 since it's unused otherwise.
032f1620 7235
367c19e5 7236 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7237 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7238 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7239 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7240 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7241 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7242 does not deduce are never used uninitialized.
70739cbe 7243
07b48fa9
PE
7244 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7245
8868a238 7246 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7247 * window.c (window_loop, size_window):
7248 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7249
7e5cf297 7250 * window.c (display_buffer): Now static.
d6550a9f
PE
7251 (size_window): Mark variables that gcc -Wuninitialized
7252 does not deduce are never used uninitialized.
a586633d
PE
7253 * window.h (check_all_windows): New decl, to forestall
7254 gcc -Wmissing-prototypes diagnostic.
5b555da1 7255 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7256
f6095868
PE
7257 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7258 shadowing.
7259 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7260 Include <limits.h>.
7261 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7262 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7263 (load_charset_map): Mark variables that gcc -Wuninitialized
7264 does not deduce are never used uninitialized.
53df7c11 7265 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7266
f38b440c
PE
7267 * coding.c (coding_set_source, coding_set_destination):
7268 Use "else { /* comment */ }" rather than "else /* comment */;"
7269 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7270 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7271 a block, when the outer 'i' will do.
7272 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7273 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7274 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7275 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7276 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7277 Rename locals to avoid shadowing.
7278 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7279 * coding.c (emacs_mule_char, encode_invocation_designation):
7280 Now static, since they're not used elsewhere.
413bb2db 7281 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7282 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7283 (decode_coding_emacs_mule): Mark variables that gcc
7284 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7285 (detect_coding_iso_2022): Initialize a local variable that might
7286 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7287 this initialization is needed. (Bug#8211)
5f58e762
PE
7288 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7289 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7290 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7291 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7292 Remove unused macros.
f38b440c 7293
232b38b9 7294 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7295 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7296 * character.c (string_count_byte8): Likewise.
232b38b9 7297
fb90da1b
PE
7298 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7299 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7300
fb93dbc2
PE
7301 * chartab.c (copy_sub_char_table): Now static, since it's not used
7302 elsewhere.
5c156ace
PE
7303 (sub_char_table_ref_and_range, char_table_ref_and_range):
7304 Rename locals to avoid shadowing.
bbcd0949 7305 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7306
7d3b3862 7307 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7308 (BIDI_BOB): Remove unused macro.
7d3b3862 7309
6be7d3da
PE
7310 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7311 deduce are never used uninitialized.
c2ed9c8b 7312 * term.c (encode_terminal_code): Likewise.
6be7d3da 7313
75f8807f 7314 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7315
50938595
PE
7316 * tparam.h: New file.
7317 * term.c, tparam.h: Include it.
7318 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7319 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7320 Move these decls to tparam.h, and make them agree with what
7321 is actually in tparam.c. The previous trick of using incompatible
7322 decls in different modules does not conform to the C standard.
7323 All callers of tparam changed to use tparam's actual API.
7324 * tparam.c (tparam1, tparam, tgoto):
7325 Use const pointers where appropriate.
7326
fbceeba2
PE
7327 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7328 * cm.h (struct cm): Likewise.
7329 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7330 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7331 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7332 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7333 (turn_on_face, init_tty): Likewise.
7334 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7335
7f3f1250
PE
7336 * term.c (term_mouse_position): Rename local to avoid shadowing.
7337
e6ca6543
PE
7338 * alloc.c (mark_ttys): Move decl from here ...
7339 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7340
c40f8d15
AS
73412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7342
7343 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7344
cfe0661d
JB
73452011-03-09 Juanma Barranquero <lekktu@gmail.com>
7346
7347 * search.c (compile_pattern_1): Remove argument regp, unused since
7348 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7349 (compile_pattern): Don't pass it.
7350
0afb4571
J
73512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7352
7353 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7354 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7355 for ! HAVE_GTK3.
7356 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7357
7358 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7359
7360 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7361 gdk_window_get_screen, gdk_window_get_geometry,
7362 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7363 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7364 (xg_get_pixbuf_from_pixmap): New function.
7365 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7366 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7367 Call xg_get_pixbuf_from_pixmap instead of
7368 gdk_pixbuf_get_from_drawable.
7369 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7370 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7371 (xg_check_special_colors): Use GtkStyleContext and its functions
7372 for HAVE_GTK3.
7373 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7374 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7375 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7376 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7377 Call gtk_widget_get_preferred_size.
0afb4571
J
7378 (xg_frame_resized): gdk_window_get_geometry only takes 5
7379 parameters.
44f230aa
SM
7380 (xg_win_to_widget, xg_event_is_for_menubar):
7381 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7382 (xg_set_widget_bg): New function.
7383 (delete_cb): New function.
895009e1 7384 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7385 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7386 (xg_set_background_color): Call xg_set_widget_bg.
7387 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7388 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7389 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7390 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7391 if ! HAVE_GTK3.
7392 (update_frame_tool_bar): Call gtk_widget_hide.
7393 (xg_initialize): Use GDK_KEY_g.
7394
7395 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7396 if ! HAVE_GTK3
7397 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7398
7399 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7400 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7401 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7402
1c2cc4ef
JB
74032011-03-08 Juanma Barranquero <lekktu@gmail.com>
7404
7405 * w32xfns.c (select_palette): Check success of RealizePalette against
7406 GDI_ERROR, not zero.
7407
33383987 7408See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7409
7410;; Local Variables:
7411;; coding: utf-8
aac0c6e3
MR
7412;; End:
7413
33383987 7414 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7415
7416 This file is part of GNU Emacs.
7417
7418 GNU Emacs is free software: you can redistribute it and/or modify
7419 it under the terms of the GNU General Public License as published by
7420 the Free Software Foundation, either version 3 of the License, or
7421 (at your option) any later version.
7422
7423 GNU Emacs is distributed in the hope that it will be useful,
7424 but WITHOUT ANY WARRANTY; without even the implied warranty of
7425 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7426 GNU General Public License for more details.
7427
7428 You should have received a copy of the GNU General Public License
7429 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.