Rename string-mark-left-to-right to bidi-string-mark-left-to-right in the manual.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9778ebcc
EZ
12011-08-18 Eli Zaretskii <eliz@gnu.org>
2
3 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4 members before the level stack, so they would be saved and
5 restored when copying iterator state. Fixes incorrect reordering
6 around TABs covered by display properties.
7
156bffbe
AS
82011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9
10 * process.c (Fnetwork_interface_list): Correctly determine buffer
11 size.
12
72ad093b
CY
132011-08-17 Chong Yidong <cyd@stupidchicken.com>
14
15 * eval.c (internal_condition_case, internal_condition_case_1)
16 (internal_condition_case_2, internal_condition_case_n): Remove
17 unnecessary aborts (Bug#9081).
18
35774242
EZ
192011-08-17 Eli Zaretskii <eliz@gnu.org>
20
21 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
22 has no `load' handler, try opening the file locally. (Bug#9311)
23
db76dd85
KB
242011-08-16 Ken Brown <kbrown@cornell.edu>
25
26 * gmalloc.c: Expand comment.
27
b215eee5
EZ
282011-08-16 Eli Zaretskii <eliz@gnu.org>
29
30 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
31 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
32
a4579d33
KB
332011-08-16 Ken Brown <kbrown@cornell.edu>
34
35 Fix memory allocation problems in Cygwin build (Bug#9273).
36
37 * unexcw.c ( __malloc_initialized): Declare external variable.
38 (fixup_executable): Force the dumped emacs to reinitialize malloc.
39
40 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
41 variables.
42 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
43 dumped emacs.
44 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
45 in the static heap.
46 [CYGWIN] (special_realloc): New function.
47 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
48 requests to realloc storage in the static heap.
49
3ebec551
PE
502011-08-15 Paul Eggert <eggert@cs.ucla.edu>
51
52 * bidi.c (bidi_initialize): Remove unused local.
53
9fd8be00
EZ
542011-08-15 Eli Zaretskii <eliz@gnu.org>
55
474a8465
EZ
56 * biditype.h: File removed.
57
58 * bidimirror.h: File removed.
59
60 * deps.mk (bidi.o): Remove biditype.h and
61 bidimirror.h.
62
63 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
64 bidimirror.h.
65
66 * dispextern.h: Fix a typo in the comment to bidi_type_t.
67
68 * chartab.c: Improve commentary for the uniprop_table API.
69
32413314
EZ
70 * bidi.c (bidi_paragraph_init): Support zero value of
71 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
72 (bidi_initialize): Use uniprop_table instead of including
73 biditype.h and bidimirror.h.
32413314 74
9fd8be00
EZ
75 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
76 coordinates of the iterator when restoring from ppos_it.
77 (Bug#9296)
78
5cf2b69b
KH
792011-08-14 Kenichi Handa <handa@m17n.org>
80
81 * process.c (create_process): Call setup_process_coding_systems
72ad093b 82 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 83
daf17d00
EZ
842011-08-14 Eli Zaretskii <eliz@gnu.org>
85
86 * xdisp.c (move_it_in_display_line_to): Don't invoke
87 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
88 ppos_it. Fixes vertical cursor motion when line beginning is
89 covered by an image. (Bug#9296)
90
08e3161a
JD
912011-08-14 Jan Djärv <jan.h.d@swipnet.se>
92
93 * nsterm.h (ns_run_ascript): Declare.
94 (NSAPP_DATA2_RUNASSCRIPT): Define.
95
96 * nsfns.m (as_script, as_result, as_status): New static variables.
97 (ns_run_ascript): New function.
98 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
99 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
100 the event loop. Get status from as_status (Bug#7276).
101
102 * nsterm.m (sendEvent): If event is NSApplicationDefined and
103 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
104 the event loop (Bug#7276).
105
a3720aa2
AS
1062011-08-14 Andreas Schwab <schwab@linux-m68k.org>
107
108 * gnutls.c (QCgnutls_bootprop_priority)
109 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
110 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
111 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
112 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
113 (QCgnutls_bootprop_verify_hostname_error)
114 (QCgnutls_bootprop_callbacks_verify): Rename from
115 Qgnutls_bootprop_..., all uses changed.
116
117 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
118 uses changed.
119
0a0d27fb
PE
1202011-08-14 Paul Eggert <eggert@cs.ucla.edu>
121
19d5c50c
PE
122 * xfaces.c (Qframe_set_background_mode): Now static.
123 * dispextern.h (Qframe_set_background_mode): Remove decl.
124
0a0d27fb
PE
125 * process.c (Fnetwork_interface_info): Declare local only if needed.
126
377538cb
JD
1272011-08-13 Jan Djärv <jan.h.d@swipnet.se>
128
129 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
130 (Fnetwork_interface_list): Allocate in increments of bytes instead
131 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
132 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
133 sockaddr.
134 (struct ifflag_def): notrailers is smart on OSX.
135 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
136 Get hardware address with getifaddrs if available.
137
08fff70c
EZ
1382011-08-12 Eli Zaretskii <eliz@gnu.org>
139
140 * xdisp.c (iterate_out_of_display_property): xassert that
141 IT->position is set to within IT->object's boundaries. Break from
142 the loop as soon as EOB is reached; avoids infloops in redisplay
143 when IT->position is set up wrongly due to some bug. Set
144 IT->current to match the bidi iterator unconditionally.
145 (push_display_prop): Allow GET_FROM_STRING as IT->method on
146 entry. Force push_it to save on the stack the current
147 buffer/string position, to be restored by pop_it. Fix flags in
148 the iterator structure wrt the object coming from a display
149 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
150 properties. (Bug#9284)
151
7be1c708 1522011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 153
7be1c708
CY
154 * fontset.c (fontset_get_font_group): Add proper type checks.
155 (Bug#9172)
aac0c6e3 156
7be1c708 1572011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 158
7be1c708
CY
159 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
160 and LC_VERSION_MIN_MACOSX.
161 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
162 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 163
97bb72a6
EZ
1642011-08-08 Eli Zaretskii <eliz@gnu.org>
165
166 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
167 no-display-properties-and-no-overlays under bidi display. Set
168 disp_pos in the bidi iterator to avoid searches for display
169 properties and overlays.
97bb72a6 170
d5617611
CY
1712011-08-08 Chong Yidong <cyd@stupidchicken.com>
172
37e11a63
CY
173 * editfns.c (Fset_time_zone_rule): Document relationship with the
174 setenv function.
175
d5617611
CY
176 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
177 the font entity extracted from the cache (Bug#8109).
178
58872834
CY
1792011-08-07 Chong Yidong <cyd@stupidchicken.com>
180
181 * composite.c (autocmp_chars): Don't reset point. That is done by
182 restore_point_unwind (Bug#5984).
183
75bfc667
JL
1842011-08-07 Juri Linkov <juri@jurta.org>
185
186 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
187 to show the arg `TIME' instead of `TIMEVAL'.
188
d1410150
EZ
1892011-08-06 Eli Zaretskii <eliz@gnu.org>
190
191 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
192 display property strides EOL and includes a newline, as in
193 longlines-mode. (Bug#9254)
75b771e4
EZ
194 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
195 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
196
197 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
198 is non-zero, even if the data buffer is NULL. Fixes a crash in
199 vertical-motion with longlines-mode. (Bug#9254)
200
35928349
EZ
2012011-08-05 Eli Zaretskii <eliz@gnu.org>
202
ec7cc85b
EZ
203 * bidi.c <bidi_cache_total_alloc>: Now static.
204 (bidi_initialize): Initialize bidi_cache_total_alloc.
205
35928349
EZ
206 *xdisp.c (display_line): Release buffer allocated for shelved bidi
207 cache. (Bug#9221)
208
209 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
210 amount allocated this far in `bidi_cache_total_alloc'.
211 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
212 non-zero, only free the data buffer without restoring the cache
213 contents. All callers changed.
214
215 * dispextern.h (bidi_unshelve_cache): Update prototype.
216
217 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
218 (move_it_in_display_line, move_it_to)
219 (move_it_vertically_backward, move_it_by_lines): Replace the call
220 to xfree to an equivalent call to bidi_unshelve_cache.
221 (move_it_in_display_line_to): Fix logic of returning
412b6358 222 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 223
e2e2423b
EZ
2242011-08-05 Eli Zaretskii <eliz@gnu.org>
225
226 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
227 came from a string character with a `cursor' property. (Bug#9229)
228
ae9e757a
JD
2292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
230
231 * Makefile.in (LIB_PTHREAD): New variable.
232 (LIBES): Add LIB_PTHREAD (Bug#9216).
233
234 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
235 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
236
213bd7f2
AS
2372011-08-04 Andreas Schwab <schwab@linux-m68k.org>
238
239 * regex.c (re_iswctype): Remove some redundant boolean
240 conversions.
241
99aaf75f
JD
2422011-08-04 Jan Djärv <jan.h.d@swipnet.se>
243
244 * xterm.c (x_find_topmost_parent): New function.
245 (x_set_frame_alpha): Find topmost parent window with
246 x_find_topmost_parent and set the property there also (bug#9181).
247 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
248
c74e9d86
PE
2492011-08-04 Paul Eggert <eggert@cs.ucla.edu>
250
251 * callproc.c (Fcall_process): Avoid vfork clobbering
252 the local vars buffer, coding_systems, current_dir.
253
640c8776
SM
2542011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
255
256 * keymap.c (Fmake_composed_keymap): Move to subr.el.
257
f26d0e4c
PE
2582011-08-03 Paul Eggert <eggert@cs.ucla.edu>
259
8a10d76c
PE
260 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
261 so that it is not optimized away.
262
f26d0e4c
PE
263 * xdisp.c (compute_display_string_pos): Remove unused local.
264
55439c61
EZ
2652011-08-02 Eli Zaretskii <eliz@gnu.org>
266
267 Fix slow cursor motion and scrolling in large buffers with
268 selective display, like Org Mode buffers. (Bug#9218)
269
270 * dispextern.h (struct bidi_it): New member disp_prop_p.
271
272 * xdisp.c: Remove one-slot cache of display string positions.
273 (compute_display_string_pos): Accept an additional argument
274 DISP_PROP_P; callers changed. Scan at most 5K characters forward
275 for a display string or property. If found, set DISP_PROP_P
276 non-zero.
277
278 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
279 DISP_PROP_P, and pass it to compute_display_string_pos.
280 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
281 non-zero. All callers of bidi_fetch_char changed.
282
fb33fa43
SM
2832011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
284
285 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
286
b099e063
DM
2872010-12-03 Don March <don@ohspite.net>
288
289 * keymap.c (Fdefine_key): Fix non-prefix key error message when
290 last character M-[char] is translated to ESC [char] (bug#7541).
291
5cc7f7af
KH
2922011-08-02 Kenichi Handa <handa@m17n.org>
293
d0fffa3f 294 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
295
296 * chartab.c (uniprop_table): Make it non-static.
297
525d5e6e
EZ
2982011-08-01 Eli Zaretskii <eliz@gnu.org>
299
300 * xdisp.c (forward_to_next_line_start): Accept additional argument
301 BIDI_IT_PREV, and store into it the state of the bidi iterator had
302 on the newline.
303 (reseat_at_next_visible_line_start): Use the bidi iterator state
304 returned by forward_to_next_line_start to restore the state of
305 it->bidi_it after backing up to previous newline. (Bug#9212)
306
31011111
AS
3072011-07-30 Andreas Schwab <schwab@linux-m68k.org>
308
309 * regex.c (re_comp): Protoize.
310 (re_exec): Fix return type.
311 (regexec): Fix type of `ret'. (Bug#9203)
312
e5d76069
PE
3132011-07-29 Paul Eggert <eggert@cs.ucla.edu>
314
315 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
316 This is needed if max-image-size is a floating-point number.
317
9a79b20c
AS
3182011-07-28 Andreas Schwab <schwab@linux-m68k.org>
319
320 * print.c (print_object): Print empty symbol as ##.
321
322 * lread.c (read1): Read ## as empty symbol.
323
d8c2fa78
AA
3242011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
325
326 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
327 setting frame foreground color (Bug#9175).
328 (x_set_background_color): Likewise.
329
ffe57a7a
AA
330 * nsmenu.m (-setText): Size tooltip dimensions precisely to
331 contents (Bug#9176).
332 (EmacsTooltip -init): Remove bezels and add shadows to
333 tooltip windows.
334
bf3492a5
AA
335 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
336 or scroll bar (Bug#8470).
337
d55e9c53
AA
338 * nsfont.m (nsfont_open): Remove assignment to voffset and
339 unnecessary vars hshink, expand, hd, full_height, min_height.
340 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
341
342 * nsterm.h (nsfont_info): Remove voffset field.
343
d8c2fa78 3442011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
345
346 Implement strike-through and overline on NextStep (Bug#8863).
347
348 * nsfont.m (nsfont_open): Use underline position provided by font,
349 instead of hard-coded value of 2.
350 (nsfont_draw): Call ns_draw_text_decoration instead.
351
352 * nsterm.h: Add declaration for ns_draw_text_decoration.
353
354 * nsterm.m (ns_draw_text_decoration): New function for drawing
355 underline, overline, and strike-through.
356 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
357 ns_draw_text_decoration. Change treatment of cursor drawing to
358 accomodate underlining, etc.
359
4cc60b9b
EZ
3602011-07-28 Eli Zaretskii <eliz@gnu.org>
361
bc7ece87
EZ
362 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
363 default.
4cc60b9b 364
476371c4
PE
3652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
366
66606eea
PE
367 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
368 Without this fix, if a signal arrives just after memory fills up,
369 'malloc' might be invoked reentrantly.
370
476371c4
PE
371 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
372 In other words, assume that every image size is allowed, on non-X
373 hosts. This assumption is probably wrong, but it lets Emacs compile.
374
f3fcc40d
AS
3752011-07-28 Andreas Schwab <schwab@linux-m68k.org>
376
377 * regex.c (re_iswctype): Convert return values to boolean.
378
350c992f
EZ
3792011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
380
381 * xdisp.c (compute_display_string_pos): Don't use cached display
382 string position if the buffer had its restriction changed.
383 (Bug#9184)
384
5266b4bb
PE
3852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
386
387 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
388
2573a837 3892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 390
41f55ccd 391 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 392
39e378da
PE
393 * bidi.c: Integer size and overflow fixes.
394 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
395 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
396 (bidi_cache_find_level_change, bidi_cache_ensure_space)
397 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
398 (bidi_find_other_level_edge):
399 Use ptrdiff_t instead of EMACS_INT where either will do.
400 This works better on 32-bit hosts configured --with-wide-int.
401 (bidi_cache_ensure_space): Check for size-calculation overflow.
402 Use % rather than repeated addition, for better worst-case speed.
403 Don't set bidi_cache_size until after xrealloc returns, because it
404 might not return.
405 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
406 (bidi_cache_ensure_space): Also check that the bidi cache size
407 does not exceed that of the largest Lisp string or buffer. See Eli
408 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 409
5e927815
PE
410 * alloc.c (__malloc_size_t): Remove.
411 All uses replaced by size_t. See Andreas Schwab's note
412 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
413
ca4aa935
PE
414 * image.c: Improve checking for integer overflow.
415 (check_image_size): Assume that f is nonnull, since
416 it is always nonnull in practice. This is one less thing to
417 worry about when checking for integer overflow later.
418 (x_check_image_size): New function, which checks for integer
419 overflow issues inside X.
420 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
421 This removes the need for a memory_full check.
422 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
423 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
424 (xbm_read_bitmap_data): Change locals back to 'int', since
425 their values must fit in 'int'.
426 (xpm_load_image, png_load, tiff_load):
427 Invoke x_create_x_image_and_pixmap earlier,
428 to avoid much needless work if the image is too large.
429 (tiff_load): Treat overly large images as if
430 x_create_x_image_and_pixmap failed, not as malloc failures.
431 (gs_load): Use x_check_image_size.
432
5f8f9cc2
PE
433 * gtkutil.c: Omit integer casts.
434 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
435 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
436
5adf60bc
PE
437 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
438
c8907a93
PE
439 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
440 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
441 would wrongly return t on a 64-bit host.
442
e3c25c68
PE
443 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
444 The plain *_OVERFLOW macros run afoul of GCC bug 49705
445 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
446 and therefore cause GCC to emit a bogus diagnostic in some cases.
447
3f791afe
PE
448 * image.c: Integer signedness and overflow and related fixes.
449 This is not an exhaustive set of fixes, but it's time to
450 record what I've got.
451 (lookup_pixel_color, check_image_size): Remove redundant decls.
452 (check_image_size): Don't assume that arbitrary EMACS_INT values
453 fit in 'int', or that arbitrary 'double' values fit in 'int'.
454 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
455 (tiff_load, imagemagick_load_image):
456 Check for overflow in size calculations.
457 (x_create_x_image_and_pixmap): Remove unnecessary test for
458 xmalloc returning NULL; that can't happen.
459 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
460 (xpm_color_bucket): Use better integer hashing function.
461 (xpm_cache_color): Don't possibly over-allocate memory.
462 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
463 (gif_memory_source):
464 Use ptrdiff_t, not int or size_t, to record sizes.
465 (png_load): Don't assume values greater than 2**31 fit in 'int'.
466 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
467 either works, as we prefer signed integers.
468 (tiff_read_from_memory, tiff_write_from_memory):
469 Return tsize_t, not size_t, since that's what the TIFF API wants.
470 (tiff_read_from_memory): Don't fail simply because the read would
471 go past EOF; instead, return a short read.
472 (tiff_load): Omit no-longer-needed casts.
473 (Fimagemagick_types): Don't assume size fits into 'int'.
474
3cc5a532
PE
475 Improve hashing quality when configured --with-wide-int.
476 * fns.c (hash_string): New function, taken from sxhash_string.
477 Do not discard information about ASCII character case; this
478 discarding is no longer needed.
479 (sxhash-string): Use it. Change sig to match it. Caller changed.
480 * lisp.h: Declare it.
481 * lread.c (hash_string): Remove, since we now use fns.c's version.
482 The fns.c version returns a wider integer if --with-wide-int is
483 specified, so this should help the quality of the hashing a bit.
484
b312a492
PE
485 * emacs.c: Integer overflow minor fix.
486 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
487 Define only if GNU_LINUX.
488 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
489
dfd153ae
PE
490 * dispnew.c: Integer signedness and overflow fixes.
491 Remove unnecessary forward decls, that were a maintenance hassle.
492 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
493 All uses changed.
494 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
495 (scrolling_window): Use ptrdiff_t, not int, for byte count.
496 (prepare_desired_row, line_draw_cost):
497 Use int, not unsigned, where either works.
498 (save_current_matrix, restore_current_matrix):
499 Use ptrdiff_t, not size_t, where either works.
500 (init_display): Check for overflow more accurately, and without
501 relying on undefined behavior.
502
a81d11a3
PE
503 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
504 Remove, replacing with the new symbols in lisp.h. All uses changed.
505 * fileio.c (make_temp_name):
506 * filelock.c (lock_file_1, lock_file):
507 * xdisp.c (message_dolog):
508 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
509 Use pMd etc. instead.
510 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
511 replacing the pWIDE etc. symbols removed from editfns.c.
512
3300e6fd
PE
513 * keyboard.h (num_input_events): Now uintmax_t.
514 This is (very slightly) less likely to mess up due to wraparound.
515 All uses changed.
516
fd05c7e9
PE
517 * buffer.c: Integer signedness fixes.
518 (alloc_buffer_text, enlarge_buffer_text):
519 Use ptrdiff_t rather than size_t when either will do, as we prefer
520 signed integers.
521
903fe15d
PE
522 * alloc.c: Integer signedness and overflow fixes.
523 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
524 (__malloc_size_t): Default to size_t, not to int.
525 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
526 (Fgarbage_collect, mark_object_loop_halt, mark_object):
527 Prefer ptrdiff_t to size_t when either would do, as we prefer
528 signed integers.
529 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
530 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
531 Now const. Initialize with values that are in range even if char
532 is signed.
533 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
534 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
535 These functions do the right thing with sizes > 2**32.
536 (check_depth): Now ptrdiff_t, not int.
537 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
538 Adjust to new way of storing sizes. Check for size overflow bugs
539 in rest of code.
540 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
541 slightly wrong anyway, as it missed one instance of
542 XMALLOC_OVERRUN_CHECK_OVERHEAD.
543 (refill_memory_reserve): Omit needless cast to size_t.
544 (mark_object_loop_halt): Mark as externally visible.
545
ac82cc6a
PE
546 * xselect.c: Integer signedness and overflow fixes.
547 (Fx_register_dnd_atom, x_handle_dnd_message):
548 Use ptrdiff_t, not size_t, since we prefer signed.
549 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
550 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
551 x_dnd_atoms_size and x_dnd_atoms_length.
552
c2d1e36d
PE
553 * doprnt.c: Prefer signed to unsigned when either works.
554 * eval.c (verror):
555 * doprnt.c (doprnt):
556 * lisp.h (doprnt):
557 * xdisp.c (vmessage):
558 Use ptrdiff_t, not size_t, when using or implementing doprnt,
559 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
560 prefer signed arithmetic to avoid comparison confusion.
561 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
562 but is a bit tricky.
563
0e926e56
PE
564 Assume freestanding C89 headers, string.h, stdlib.h.
565 * data.c, doprnt.c, floatfns.c, print.c:
566 Include float.h unconditionally.
567 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
568 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
569 * regex.c: Likewise for stddef.h, string.h.
570 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
571 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
572 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
573 (STDC_HEADERS): Remove obsolete defines.
574 * sysdep.c: Include limits.h unconditionally.
575
9cfdb3ec
PE
576 Assume support for memcmp, memcpy, memmove, memset.
577 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
578 * regex.c (memcmp, memcpy):
579 Remove; we assume C89 now.
580
581 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
582 (__malloc_safe_bcopy): Remove; no longer needed.
583
cf950e6b 584 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
585 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
586 well either way, and we prefer signed to unsigned.
587
dbf38e02
LMI
5882011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
589
590 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
591 closes the connection while we're reading (bug#9182).
592
d6f0886c
JD
5932011-07-25 Jan Djärv <jan.h.d@swipnet.se>
594
595 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
596 are specified (Bug#9168).
597
2eb1f9e6
PE
5982011-07-25 Paul Eggert <eggert@cs.ucla.edu>
599
600 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
601 Found by GCC static checking and --with-wide-int on a 32-bit host.
602
22381272 6032011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
604
605 * xdisp.c (compute_display_string_pos): Fix logic of caching
606 previous display string position. Initialize cached_prev_pos to
607 -1. Fixes slow-down at the beginning of a buffer.
608
f25e39b4
EZ
6092011-07-24 Eli Zaretskii <eliz@gnu.org>
610
611 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
612 for attrs[LFACE_FONTSET_INDEX].
613
04c4b52e
PE
6142011-07-23 Paul Eggert <eggert@cs.ucla.edu>
615
616 * xml.c (parse_region): Remove unused local
617 that was recently introduced.
618
c1734fbd
EZ
6192011-07-23 Eli Zaretskii <eliz@gnu.org>
620
be18c5a5
EZ
621 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
622 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
623
c1734fbd
EZ
624 * xdisp.c (move_it_in_display_line_to): Record the best matching
625 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
626 exit if none of the characters scanned was an exact match.
627 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
628 when exact match is impossible due to invisible text, and the
629 lines are truncated.
630
a258d627
JD
6312011-07-23 Jan Djärv <jan.h.d@swipnet.se>
632
633 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
634 for OSX >= 10.7.
635
b6d5a689
EZ
6362011-07-22 Eli Zaretskii <eliz@gnu.org>
637
0f74f785
EZ
638 Fix a significant slow-down of cursor motion with C-n, C-p,
639 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
640 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 641 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
642 (next_element_from_buffer): Call compute_stop_pos_backwards to
643 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
644 base_level_stop.
645 (reseat): Don't look for prev_stop, as that could mean a very long
646 run.
647 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
648 <cached_disp_overlay_modiff>: Cache for last found display string
649 position.
551918c1 650 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
651 about the same buffer in the same area of character positions, and
652 the buffer wasn't changed since the time the display string
653 position was cached.
551918c1 654
b2d0c91a
EZ
6552011-07-22 Eli Zaretskii <eliz@gnu.org>
656
657 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
658 is an integer, which is important for empty lines. (Bug#9149)
659
043604ee
CY
6602011-07-22 Chong Yidong <cyd@stupidchicken.com>
661
662 * frame.c (Fmodify_frame_parameters): In tty case, update the
663 default face if necessary (Bug#4238).
664
da4adb04
CY
6652011-07-21 Chong Yidong <cyd@stupidchicken.com>
666
667 * editfns.c (Fstring_to_char): No need to explain what a character
668 is in the docstring (Bug#6576).
669
9abd0532
LMI
6702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
671
672 * xml.c (parse_region): Make sure we always return a tree.
673
36881d16
HK
6742011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
675
676 * xml.c (parse_region): If a document contains only comments,
677 return that, too.
678
1e98674d
LMI
6792011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
680
681 * xml.c (make_dom): Return comments, too.
682
590bd467
PE
6832011-07-19 Paul Eggert <eggert@cs.ucla.edu>
684
685 Port to OpenBSD.
686 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
687 and the surrounding thread.
688 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
689 rather than fgets, and retry after EINTR. Otherwise, 'emacs
690 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
691 timer goes off.
692 * s/openbsd.h (BROKEN_SIGIO): Define.
693 * unexelf.c (unexec) [__OpenBSD__]:
694 Don't update the .mdebug section of the Alpha COFF symbol table.
695
f41628b2
LMI
6962011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
697
698 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
699 (bug#8460).
700
b59b67c5
PE
7012011-07-18 Paul Eggert <eggert@cs.ucla.edu>
702
15e3a074
PE
703 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
704 This fixes some race conditions on the permissions of any newly
705 created file.
706
41bed37d
PE
707 * alloc.c (valid_pointer_p): Use pipe, not open.
708 This fixes some permissions issues when debugging.
709
b59b67c5
PE
710 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
711 If fchown fails to set both uid and gid, try to set just gid,
712 as that is sometimes allowed. Adjust the file's mode to eliminate
713 setuid or setgid bits that are inappropriate if fchown fails.
714
925a6be7
SM
7152011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
716
717 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
718 to compare Lisp_Objects.
719 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
720 global_gnutls_log_level, don't mistake it for a Lisp_Object.
721 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
722
52968808
AS
7232011-07-17 Andreas Schwab <schwab@linux-m68k.org>
724
0a6a104b
AS
725 * lread.c (read_integer): Unread even EOF character.
726 (read1): Likewise. Properly record start position of symbol.
727
52968808
AS
728 * lread.c (read1): Read `#:' as empty uninterned symbol if no
729 symbol character follows.
730
9e381cdd
PE
7312011-07-17 Paul Eggert <eggert@cs.ucla.edu>
732
733 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
734 This works around a problem with the previous change to Fcopy_file.
735 Recent glibc declares fchown with __attribute__((warn_unused_result)),
736 and without this change, GCC might complain about discarding
737 fchown's return value.
738
b5641435
JB
7392011-07-16 Juanma Barranquero <lekktu@gmail.com>
740
741 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
742
a8031457
PE
7432011-07-16 Paul Eggert <eggert@cs.ucla.edu>
744
745 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
746
dd889327
LMI
7472011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
748
750c33f7
LMI
749 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
750 it's used from the C level.
751
dd889327
LMI
752 * process.c: Use the same condition for POLL_FOR_INPUT in both
753 keyboard.c and process.c (bug#1858).
754
87e86684
LM
7552011-07-09 Lawrence Mitchell <wence@gmx.li>
756
757 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
758 (Fgnutls_boot): Use it.
759
64348f40
AS
7602011-07-15 Andreas Schwab <schwab@linux-m68k.org>
761
762 * doc.c (Fsubstitute_command_keys): Revert last change.
763
1d698799
LMI
7642011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
765
f863868c
LMI
766 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
767 quotes the next character, and doesn't affect other longer
768 sequences (bug#8935).
769
1d698799
LMI
770 * lread.c (syms_of_lread): Clarify that is isn't only
771 `eval-buffer' and `eval-defun' that's affected by
772 `lexical-binding' (bug#8460).
773
aa4b6df6
EZ
7742011-07-15 Eli Zaretskii <eliz@gnu.org>
775
776 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
777 bidi redisplay when a line includes both an image and is
778 truncated.
779
5d856da6
PE
7802011-07-14 Paul Eggert <eggert@cs.ucla.edu>
781
ad6042bb
PE
782 Fix minor problems found by static checking.
783 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
784 (elsz): Now a signed constant, not a size_t var. We prefer signed
785 types to unsigned, to avoid integer comparison confusion. Without
786 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
787 "cannot optimize loop, the loop counter may overflow", a symptom
788 of the confusion.
f00bbb22 789 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
790 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
791
6468f31c
LMI
7922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
793
49080b10
LMI
794 * search.c (Fre_search_backward): Mention `case-fold-search' in
795 all the re_search_* functions (bug#8138).
796
6468f31c
LMI
797 * keyboard.c (Fopen_dribble_file): Document when the file is
798 closed (bug#8056).
799
c965adc5
EZ
8002011-07-14 Eli Zaretskii <eliz@gnu.org>
801
df9733bf
EZ
802 * bidi.c (bidi_dump_cached_states): Fix format of displaying
803 bidi_cache_idx.
804
0bb23927
EZ
805 Support bidi reordering of display and overlay strings.
806 * xdisp.c (compute_display_string_pos)
807 (compute_display_string_end): Accept additional argument STRING.
808 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
809 (reseat_to_string): Initialize bidi_it->string.s and
810 bidi_it->string.schars.
811 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
812 NULL (avoids a crash in bidi_paragraph_init).
813 Initialize itb.string.lstring.
0bb23927
EZ
814 (init_iterator): Call bidi_init_it only of a valid
815 buffer position was specified. Initialize paragraph_embedding to
816 L2R.
817 (reseat_to_string): Initialize the bidi iterator.
818 (display_string): If we need to ignore text properties of
819 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
820 original value of -1 will not work with bidi.)
821 (compute_display_string_pos): First arg is now struct
822 `text_pos *'; all callers changed. Support display properties on
823 Lisp strings.
824 (compute_display_string_end): Support display properties on Lisp
825 strings.
826 (init_iterator, reseat_1, reseat_to_string): Initialize the
827 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
828 when iterating on a string not from display properties).
640c8776
SM
829 (compute_display_string_pos, compute_display_string_end):
830 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
831 arrow keys.
832 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
833 base_level_stop; instead, set base_level_stop to BEGV.
834 Fixes crashes in vertical-motion.
0bb23927
EZ
835 (next_element_from_buffer): Improve commentary for when
836 the iterator is before prev_stop.
837 (init_iterator): Initialize bidi_p from the default value of
838 bidi-display-reordering, not from buffer-local value. Use the
839 buffer-local value only if initializing for buffer iteration.
840 (handle_invisible_prop): Support invisible properties on strings
841 that are being bidi-reordered.
842 (set_iterator_to_next): Support bidi reordering of C strings and
843 Lisp strings.
844 (next_element_from_string): Support bidi reordering of Lisp
845 strings.
846 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
847 (display_string): Support display of R2L glyph rows.
848 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
849 (init_iterator): Don't initialize it->bidi_p for strings
850 here.
851 (reseat_to_string): Initialize it->bidi_p for strings here.
852 (next_element_from_string, next_element_from_c_string)
853 (next_element_from_buffer): Add xassert's for correspondence
854 between IT's object being iterated and it->bidi_it.string
855 structure.
856 (face_before_or_after_it_pos): Support bidi iteration.
857 (next_element_from_c_string): Handle the case of the first string
858 character that is not the first one in the visual order.
859 (get_visually_first_element): New function, refactored from common
860 parts of next_element_from_buffer, next_element_from_string, and
861 next_element_from_c_string.
862 (tool_bar_lines_needed, redisplay_tool_bar)
863 (display_menu_bar): Force left-to-right direction. Add a FIXME
864 comment for making that be controlled by a user option.
865 (push_it, pop_it): Save and restore the state of the
866 bidi iterator. Save and restore the bidi_p flag.
867 (pop_it): Iterate out of display property for string iteration as
868 well.
869 (iterate_out_of_display_property): Support iteration over strings.
870 (handle_single_display_spec): Set up it->bidi_it for iteration
871 over a display string, and call bidi_init_it.
872 (handle_single_display_spec, next_overlay_string)
873 (get_overlay_strings_1, push_display_prop): Set up the bidi
874 iterator for displaying display or overlay strings.
875 (forward_to_next_line_start): Don't use the shortcut if
876 bidi-iterating.
877 (back_to_previous_visible_line_start): If handle_display_prop
878 pushed the iterator stack, restore the internal state of the bidi
879 iterator by calling bidi_pop_it same number of times.
880 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
881 and we are bidi-iterating, don't decrement the iterator position;
882 instead, set the first_elt flag in the bidi iterator, to produce
883 the same effect.
884 (reseat_1): Remove redundant setting of string_from_display_prop_p.
885 (push_display_prop): xassert that we are iterating a buffer.
886 (push_it, pop_it): Save and restore paragraph_embedding member.
887 (handle_single_display_spec, next_overlay_string)
888 (get_overlay_strings_1, reseat_1, reseat_to_string)
889 (push_display_prop): Set up the `unibyte' member of bidi_it.string
890 correctly. Don't assume unibyte strings are not bidi-reordered.
891 (compute_display_string_pos)
892 (compute_display_string_end): Fix handling the case of C string.
893 (push_it, pop_it): Save and restore from_disp_prop_p.
894 (handle_single_display_spec, push_display_prop): Set the
895 from_disp_prop_p flag.
896 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
897 (pop_it): Call iterate_out_of_display_property only if we are
898 popping after iteration over a string that came from a display
899 property. Fix a typo in popping stretch info. Add an assertion
900 for verifying that the iterator position is in sync with the bidi
901 iterator.
902 (handle_single_display_spec, get_overlay_strings_1)
903 (push_display_prop): Fix initialization of paragraph direction for
904 string when that of the parent object is not yet determined.
905 (reseat_1): Call bidi_init_it to resync the bidi
906 iterator with IT's position. (Bug#7616)
907 (find_row_edges): If ROW->start.pos gives position
908 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
909 (handle_stop, back_to_previous_visible_line_start, reseat_1):
910 Reset the from_disp_prop_p flag.
911 (SAVE_IT, RESTORE_IT): New macros.
912 (pos_visible_p, face_before_or_after_it_pos)
913 (back_to_previous_visible_line_start)
914 (move_it_in_display_line_to, move_it_in_display_line)
915 (move_it_to, move_it_vertically_backward, move_it_by_lines)
916 (try_scrolling, redisplay_window, display_line): Use them when
917 saving a temporary copy of the iterator and restoring it back.
918 (back_to_previous_visible_line_start, reseat_1)
919 (init_iterator): Empty the bidi cache "stack".
920 (move_it_in_display_line_to): If iterator ended up at
921 EOL, but we never saw any buffer positions smaller than
922 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
923 motion in bidi-reordered lines.
924 (move_it_in_display_line_to): Record prev_method and prev_pos
925 immediately before the call to set_iterator_to_next. Fixes cursor
926 motion in bidi-reordered lines with stretch glyphs and strings
927 displayed in margins. (Bug#8133) (Bug#8867)
928 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
929 TO_CHARPOS.
640c8776
SM
930 (pos_visible_p): Support positions in bidi-reordered lines.
931 Save and restore bidi cache.
0bb23927
EZ
932
933 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
934 (bidi_paragraph_info): Delete unused struct.
935 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
936 (bidi_cache_start): New variable.
937 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
938 to zero.
939 (bidi_cache_fetch_state, bidi_cache_search)
940 (bidi_cache_find_level_change, bidi_cache_iterator_state)
941 (bidi_cache_find, bidi_peek_at_next_level)
942 (bidi_level_of_next_char, bidi_find_other_level_edge)
943 (bidi_move_to_visually_next): Compare cache index with
944 bidi_cache_start rather than with zero.
945 (bidi_fetch_char): Accept new argument STRING; all callers
946 changed. Support iteration over a string. Support strings with
947 display properties. Support unibyte strings. Fix the type of
948 `len' according to what STRING_CHAR_AND_LENGTH expects.
949 (bidi_paragraph_init, bidi_resolve_explicit_1)
950 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
951 (bidi_level_of_next_char, bidi_move_to_visually_next):
952 Support iteration over a string.
0bb23927
EZ
953 (bidi_set_sor_type, bidi_resolve_explicit_1)
954 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
955 can now be zero (for strings); special values 0 and -1 were
956 changed to -1 and -2, respectively.
957 (bidi_char_at_pos): New function.
958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
959 Call it instead of FETCH_MULTIBYTE_CHAR.
960 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
961 initialized to valid values.
962 (bidi_init_it): Don't initialize charpos and bytepos with invalid
963 values.
964 (bidi_level_of_next_char): Allow the sentinel "position" to pass
965 the test for valid cached positions. Fix the logic for looking up
966 the sentinel state in the cache. GCPRO the Lisp string we are
967 iterating.
968 (bidi_push_it, bidi_pop_it): New functions.
969 (bidi_initialize): Initialize the bidi cache start stack pointer.
970 (bidi_cache_ensure_space): New function, refactored from part of
971 bidi_cache_iterator_state. Don't assume the required size is just
972 one BIDI_CACHE_CHUNK away.
973 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
974 (bidi_count_bytes, bidi_char_at_pos): New functions.
975 (bidi_cache_search): Don't assume bidi_cache_last_idx is
976 always valid if bidi_cache_idx is valid.
977 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
978 is valid if it's going to be used.
979 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
980 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
981 (bidi_cache_find_level_change, bidi_cache_ensure_space)
982 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
983 (bidi_find_other_level_edge, bidi_cache_start_stack):
984 All variables related to cache indices are now EMACS_INT.
c965adc5 985
0bb23927
EZ
986 * dispextern.h (struct bidi_string_data): New structure.
987 (struct bidi_it): New member `string'. Make flag members be 1-bit
988 fields, and put them last in the struct.
640c8776
SM
989 (compute_display_string_pos, compute_display_string_end):
990 Update prototypes.
0bb23927
EZ
991 (bidi_push_it, bidi_pop_it): Add prototypes.
992 (struct iterator_stack_entry): New members bidi_p,
993 paragraph_embedding, and from_disp_prop_p.
994 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
995 (bidi_shelve_cache, bidi_unshelve_cache):
996 Declare prototypes.
0bb23927
EZ
997
998 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
999 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1000 and vector-like objects.
1001
1002 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1003 cache around display iteration.
1004
1005 * window.c (Fwindow_end, window_scroll_pixel_based)
1006 (displayed_window_lines, Frecenter): Save and restore the bidi
1007 cache around display iteration.
1008
3bbd2265
LMI
10092011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1010
1011 * editfns.c (Fdelete_region): Clarify the use of the named
1012 parameters (bug#6788).
1013
adc47434
MR
10142011-07-14 Martin Rudalics <rudalics@gmx.at>
1015
1016 * indent.c (Fvertical_motion): Set and restore w->pointm when
1017 saving and restoring the window's buffer (Bug#9006).
1018
837c31f8
LMI
10192011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1020
1021 * editfns.c (Fstring_to_char): Clarify just what is returned
1022 (bug#6576). Text by Eli Zaretskii.
1023
ac389d0c
JB
10242011-07-13 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1027
0be0ce47
EZ
10282011-07-13 Eli Zaretskii <eliz@gnu.org>
1029
1030 * buffer.c (mmap_find): Fix a typo.
1031
cd18e7e3
JB
10322011-07-13 Johan Bockgård <bojohan@gnu.org>
1033
1034 Fix execution of x selection hooks.
1035 * xselect.c (Qx_lost_selection_functions)
1036 (Qx_sent_selection_functions): New vars.
1037 (syms_of_xselect): DEFSYM them.
1038 (x_handle_selection_request): Pass Qx_sent_selection_functions
1039 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1040 (x_handle_selection_clear,x_clear_frame_selections):
1041 Pass Qx_lost_selection_functions rather than
1042 Vx_lost_selection_functions to Frun_hook_with_args.
1043
47ea7f44
PE
10442011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1045
ac389d0c 1046 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1047 The old code sometimes used this field without initializing it.
1048
47ea7f44
PE
1049 * alloc.c (gc_sweep): Don't read past end of array.
1050 In theory, the old code could also have corrupted Emacs internals,
1051 though it'd be very unlikely.
1052
bc985c87
AS
10532011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1054
1055 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1056 argument. (Bug#4026)
bc985c87 1057
0cf34688
LMI
10582011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1059
b3dadd76
LMI
1060 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1061 key" (bug#4257).
1062
0cf34688
LMI
1063 * window.c (Fset_window_start): Doc fix (bug#4199).
1064 (Fset_window_hscroll): Ditto.
1065
270768cd
PE
10662011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1067
077e3dda 1068 Fix minor new problems caught by GCC 4.6.1.
270768cd 1069 * term.c (init_tty): Remove unused local.
490011a6 1070 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1071 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1072 not used otherwise.
270768cd 1073
b1f58454
CY
10742011-07-12 Chong Yidong <cyd@stupidchicken.com>
1075
1076 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1077
22b9578d
LMI
10782011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1079
6e70ab07
LMI
1080 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1081 are the mini-buffer and the echo area (bug#3320).
1082
22b9578d
LMI
1083 * term.c (init_tty): Remove support for supdup, c10 and perq
1084 terminals, which are no longer supported (bug#1482).
1085
8974cc9f
JB
10862011-07-10 Johan Bockgård <bojohan@gnu.org>
1087
1088 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1089
a560d974
JD
10902011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1091
1092 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1093 for non-popups (Bug#3642).
1094
1dae0f0a
AS
10952011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1096
268c2c36 1097 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1098 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1099 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1100 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1101 * data.c (fmod): Likewise.
1102 * dispnew.c (swap_glyphs_in_rows): Likewise.
1103 * emacs.c (memory_warning_signal): Likewise.
1104 * floatfns.c (float_error): Likewise.
1105 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1106 (otf_open, font_otf_capability, generate_otf_features)
1107 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1108 Likewise.
1109 * image.c (pbm_read_file): Likewise.
1110 * indent.c (string_display_width): Likewise.
1111 * intervals.c (check_for_interval, search_for_interval)
1112 (inc_interval_count, count_intervals, root_interval)
1113 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1114 * lread.c (defalias): Likewise.
268c2c36 1115 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1116 * regex.c (set_image_of_range_1, set_image_of_range)
1117 (regex_grow_registers): Likewise.
1118 * sysdep.c (strerror): Likewise.
1119 * termcap.c (valid_filename_p, tprint, main): Likewise.
1120 * tparam.c (main): Likewise.
1121 * unexhp9k800.c (run_time_remap, save_data_space)
1122 (update_file_ptrs, read_header, write_header, calculate_checksum)
1123 (copy_file, copy_rest, display_header): Likewise.
1124 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1125 Likewise.
1126 * xdisp.c (check_it): Likewise.
1127 * xfaces.c (register_color, unregister_color, unregister_colors):
1128 Likewise.
1129 * xfns.c (print_fontset_result): Likewise.
1130 * xrdb.c (member, fatal, main): Likewise.
1131
99033785
PE
11322011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 Fix minor problems found by static checking (Bug#9031).
1135 * chartab.c (char_table_set_range, map_sub_char_table):
1136 Remove unused locals.
1137 (uniprop_table): Now static.
1138 * composite.c (_work_char): Remove unused static var.
1139
9cb2ac56
JB
11402011-07-09 Juanma Barranquero <lekktu@gmail.com>
1141
1142 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1143
f25661f0
JD
11442011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1145
1146 * gtkutil.c (qttip_cb): Remove code without function.
1147
8278c4fe
EZ
11482011-07-09 Eli Zaretskii <eliz@gnu.org>
1149
1150 * w32.c (pthread_sigmask): New stub.
1151
1692ae2d 11522011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1153
8a6ebd58 1154 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1155 sigprocmask is portable only for single-threaded applications, and
1156 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1157 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1158 (LIBES): Use it.
1159 * callproc.c (Fcall_process):
1160 * process.c (create_process):
1161 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1162 Use pthread_sigmask, not sigprocmask.
123403e4 1163
1b854618
JD
11642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1165
1166 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1167 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1168 wrong (Bug#8591).
1169
3fe4b549
JD
11702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1171
0ce7e563
JD
1172 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1173 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1174 (xg_hide_tooltip): Fix comment.
1175
3fe4b549
JD
1176 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1177 in registerServicesMenuSendTypes.
1178 (validRequestorForSendType): Don't check ns_return_types.
1179
1180 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1181 ns_return_type.
1182
5df75e47
JR
11832011-07-08 Jason Rumney <jasonr@gnu.org>
1184
1185 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1186 frame struct members of non-existent frames (Bug#6284).
1187
699c10bd
JD
11882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1189
4393663b
JD
1190 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1191 variable firstTime not needed on OSX >= 10.6.
1192 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1193 >= 10.5. Use setKnobProportion, setDoubleValue.
1194
1195 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1196 (MAC_OS_X_VERSION_10_5): Define if not defined.
1197 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1198 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1199 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1200
1201 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1202 cString and lossyCString on OSX >= 10.4
1203
1204 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1205 sizeToFit on OSX >= 10.2.
1206
1207 * nsimage.m (allocInitFromFile): Don't use deprecated method
1208 bestRepresentationForDevice on OSX >= 10.6.
1209
1210 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1211 to avoid warning.
1212
1213 * emacs.c: Declare unexec_init_emacs_zone.
1214
a63e0781
JD
1215 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1216
699c10bd
JD
1217 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1218
1219 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1220 on svcsMenu (Bug#8842).
1221
1222 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1223 ns_return_types.
1224 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1225
1226 * nsterm.m (QUTF8_STRING): Declare.
1227 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1228 (validRequestorForSendType): Return type is (id).
1229 Change indexOfObjectIdenticalTo to indexOfObject.
1230 Check if we have local selection before returning self (Bug#8842).
1231 (writeSelectionToPasteboard): Put local selection into paste board
1232 if we have a local selection (Bug#8842).
1233 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1234
1235 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1236 (ns_get_local_selection): Declare.
1237
54e10184
LMI
12382011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1239
9888ff71
LMI
1240 * keymap.c (describe_map_tree): Don't insert a double newline at
1241 the end of the buffer (bug#1169) and return whether we inserted
1242 something.
1243
54e10184
LMI
1244 * callint.c (Fcall_interactively): Change "reading args" to
1245 "providing args" to try to clarify what it does (bug#1010).
1246
15fa4783
KH
12472011-07-07 Kenichi Handa <handa@m17n.org>
1248
1249 * composite.c (composition_compute_stop_pos): Ignore a static
1250 composition starting before CHARPOS (Bug#8915).
1251
1252 * xdisp.c (handle_composition_prop): Likewise.
1253
a8815b00
EZ
12542011-07-07 Eli Zaretskii <eliz@gnu.org>
1255
1256 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1257 (Bug#9015)
1258
ef7b981d 12592011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1260
1261 * character.h (unicode_category_t): New enum type.
1262
1263 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1264 (Qchar_code_property_table): New variable.
1265 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1266 (UNIPROP_COMPRESSED_FORM_P): New macros.
1267 (char_table_ascii): Uncompress the compressed values.
1268 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1269 Uncompress the compressed values.
ac389d0c 1270 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1271 (char_table_ref_and_range): Uncompress the compressed values.
1272 (sub_char_table_set): New arg is_uniprop. Callers changed.
1273 Uncompress the compressed values.
1274 (sub_char_table_set_range): Args changed. Callers changed.
1275 (char_table_set_range): Adjuted for the above change.
1276 (map_sub_char_table): Delete args default_val and parent. Add arg
1277 top. Give decoded values to a Lisp function.
640c8776 1278 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1279 values to a Lisp function. Gcpro more variables.
1280 (uniprop_table_uncompress)
1281 (uniprop_decode_value_run_length): New functions.
1282 (uniprop_decoder, uniprop_decoder_count): New variables.
1283 (uniprop_get_decoder, uniprop_encode_value_character)
1284 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1285 New functions.
1286 (uniprop_encoder, uniprop_encoder_count): New variables.
1287 (uniprop_get_encoder, uniprop_table)
1288 (Funicode_property_table_internal, Fget_unicode_property_internal)
1289 (Fput_unicode_property_internal): New functions.
1290 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1291 Sunicode_property_table_internal, Sget_unicode_property_internal,
1292 and Sput_unicode_property_internal. Defvar_lisp
1293 char-code-property-alist.
1294
640c8776 1295 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1296 Vunicode_category_table.
1297
640c8776 1298 * font.c (font_range): Adjust for the change of
c805dec0
KH
1299 Vunicode_category_table.
1300
76b397fb
DN
13012011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1302
1303 * m/iris4d.h: Remove file, move contents ...
1304 * s/irix6-5.h: ... here.
1305
22b4128e
PE
13062011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1309 * alloc.c (mark_buffer):
1310 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1311 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1312 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1313 This isn't true in general, and it's particularly not true
1314 if Emacs is configured with --with-wide-int.
1315 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1316 New macros, used in the buffer.c change.
1317
869795d6
JD
13182011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1319
1320 * xsettings.c: Use both GConf and GSettings if both are available.
1321 (store_config_changed_event): Add comment.
1322 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1323 (store_tool_bar_style_changed): New functions.
1324 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1325 (struct xsettings): Move font inside HAVE_XFT.
1326 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1327 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1328 Move inside HAVE_XFT.
640c8776 1329 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1330 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1331 also.
1332 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1333 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1334 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1335 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1336 (parse_settings): Move check for font inside HAVE_XFT.
1337 (read_settings, apply_xft_settings): Add comment.
1338 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1339 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1340 call store_font_name_changed.
1341 (xft_settings_event): Add comment.
1342 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1343 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1344 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1345 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1346 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1347 (xsettings_get_system_font, xsettings_get_system_normal_font):
1348 Add comment.
869795d6 1349
d8ed26bd
PE
13502011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 Random fixes. E.g., (random) never returned negative values.
1353 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1354 subseconds part to the entropy, as that's a bit more random.
1355 Prefer signed to unsigned, since the signedness doesn't matter and
1356 in general we prefer signed. When given a limit, use a
1357 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1358 latter isn't right if USE_2_TAGS_FOR_INTS.
1359 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1360 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1361
cabf1cac
SM
13622011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1363
1364 * textprop.c (text_property_stickiness):
1365 Obey Vtext_property_default_nonsticky.
1366 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1367 * w32fns.c (syms_of_w32fns):
1368 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1369
6e9b2be9
PE
13702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1373 This is more efficient than Ffile_directory_p and avoids a minor race.
1374
90186c68
LMI
13752011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1376
7c301272
LMI
1377 * buffer.c (Foverlay_put): Say what the return value is
1378 (bug#7835).
1379
c4f2d8d4
LMI
1380 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1381 is a directory before asking whether to use the file name
1382 (bug#7564).
ad637907
LMI
1383 (barf_or_query_if_file_exists): Make the "File is a directory"
1384 error be more correct.
c4f2d8d4 1385
90186c68
LMI
1386 * fns.c (Frequire): Remove the mention of the .gz files, since
1387 that's installation-specific, but keep the mention of
1388 `get-load-suffixes'.
1389
da64016e
PE
13902011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1393 Report string overflow if the output is too long.
1394
7d47b580
JB
13952011-07-04 Juanma Barranquero <lekktu@gmail.com>
1396
a555cb87
JB
1397 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1398 (syms_of_gnutls): Remove duplicate DEFSYM for
1399 Qgnutls_bootprop_verify_hostname_error, an error for
1400 Qgnutls_bootprop_verify_error (which is no longer used).
1401
7d47b580
JB
1402 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1403 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1404 Also (re)move comments that are misplaced or no longer relevant.
1405
1e49bfab
LMI
14062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1407
1408 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1409
1485f4c0
CY
14102011-07-03 Chong Yidong <cyd@stupidchicken.com>
1411
1412 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1413 and background color parameters if they have been changed.
1414
a9ab721e
LMI
14152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1416
1417 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1418
cf7cff57
PE
14192011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1420
2e13213d
PE
1421 * xsettings.c (SYSTEM_FONT): Define only when used.
1422 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1423
cf7cff57
PE
1424 * keymap.c (access_keymap_1): Now static.
1425
7a8e04f7
CY
14262011-07-02 Chong Yidong <cyd@stupidchicken.com>
1427
1428 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1429 leave any prefix arg for the up event (Bug#1586).
1430
61352f62
LMI
14312011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1432
69bb1ef7
LMI
1433 * lread.c (syms_of_lread): Mention single symbols defined by
1434 `defvar' or `defconst' (bug#7154).
1435
61352f62 1436 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1437 (Frequire): Mention get-load-suffixes.
61352f62 1438
28545e04
MR
14392011-07-02 Martin Rudalics <rudalics@gmx.at>
1440
1441 * window.h (window): Remove clone_number slot.
1442 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1443 Remove.
1444 (make_parent_window, make_window, saved_window)
1445 (Fset_window_configuration, save_window_save): Don't deal with
1446 clone numbers.
1447 * buffer.c (Qclone_number): Remove declaration.
1448 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1449
3349e122
SM
14502011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1451
1452 Add multiple inheritance to keymaps.
1453 * keymap.c (Fmake_composed_keymap): New function.
1454 (Fset_keymap_parent): Simplify.
1455 (fix_submap_inheritance): Remove.
1456 (access_keymap_1): New function extracted from access_keymap to handle
1457 embedded parents and handle lists of maps.
1458 (access_keymap): Use it.
1459 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1460 (Fcopy_keymap): Handle embedded parents.
1461 (Fcommand_remapping, define_as_prefix): Simplify.
1462 (Fkey_binding): Simplify.
1463 (syms_of_keymap): Move minibuffer-local-completion-map,
1464 minibuffer-local-filename-completion-map,
1465 minibuffer-local-must-match-map, and
1466 minibuffer-local-filename-must-match-map to Elisp.
1467 (syms_of_keymap): Defsubr make-composed-keymap.
1468 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1469 (parse_menu_item): Trivial simplification.
1470
3279eb87
GM
14712011-07-01 Glenn Morris <rgm@gnu.org>
1472
1473 * Makefile.in (SETTINGS_LIBS): Fix typo.
1474
4550efdf
KI
14752011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1476
1477 * coding.c (Fencode_coding_string): Record the last coding system
1478 used, as the function doc string says (bug#8738).
1479
0949d2b6
JD
14802011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1481
1482 * xsettings.c (store_monospaced_changed): Take new font as arg and
1483 check for change against current_mono_font.
1484 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1485 (emacs_settings_constructor, emacs_settings_get_property)
1486 (emacs_settings_set_property, emacs_settings_class_init)
1487 (emacs_settings_init, gsettings_obj): Remove.
1488 (something_changedCB): New function for HAVE_GSETTINGS.
1489 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1490 with value as argument.
1491 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1492 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1493 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1494 "changed".
1495
1496 * xgselect.c: Add defined (HAVE_GSETTINGS).
1497 (xgselect_initialize): Ditto.
1498
1499 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1500 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1501 xg_select.
1502
bbc6b304
PE
15032011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 * eval.c (struct backtrace): Simplify and port the data structure.
1506 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1507 signed bit field, as this assumption is not portable and it makes
1508 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1509 "char debug_on_exit : 1" as this is not portable either; instead,
1510 use the portable "unsigned int debug_on_exit : 1". Remove unused
1511 member evalargs. Remove obsolete comments about cc bombing out.
1512
9851bfc5
JD
15132011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1514
51bb811f 1515 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1516 Let HAVE_GSETTINGS override HAVE_GCONF.
1517 (store_monospaced_changed): New function.
1518 (EMACS_SETTINGS): A new type derived from GObject to handle
1519 GSettings notifications.
1520 (emacs_settings_constructor, emacs_settings_get_property)
1521 (emacs_settings_set_property, emacs_settings_class_init):
1522 New functions.
1523 (gsettings_client, gsettings_obj): New variables.
1524 (GSETTINGS_SCHEMA): New define.
1525 (something_changedCB): Call store_monospaced_changed.
1526 (init_gsettings): New function.
1527 (xsettings_initialize): Call init_gsettings.
1528 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1529 to NULL.
1530
640c8776 1531 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1532 GCONF_CFLAGS/LIBS.
1533
5386012d
MR
15342011-06-29 Martin Rudalics <rudalics@gmx.at>
1535
1536 * window.c (resize_root_window, grow_mini_window)
1537 (shrink_mini_window): Rename Qresize_root_window to
1538 Qwindow_resize_root_window and Qresize_root_window_vertically to
1539 Qwindow_resize_root_window_vertically.
1540
f13e0b08
PE
15412011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1544
94515237
JB
15452011-06-27 Juanma Barranquero <lekktu@gmail.com>
1546
1547 * makefile.w32-in: Redesign dependencies so they reflect more
1548 clearly which files are directly included by each source file,
1549 and not through other includes.
1550
e43b6e43
MR
15512011-06-27 Martin Rudalics <rudalics@gmx.at>
1552
1553 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1554 (sort_overlays, overlay_strings): When an overlay's clone number
1555 matches the window's clone number process the overlay even if
1556 the overlay's window property doesn't match the current window.
1557
d68443dc
MR
1558 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1559 (Fwindow_hchild): Rename to Fwindow_left_child.
1560 (Fwindow_next): Rename to Fwindow_next_sibling.
1561 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1562 (resize_window_check): Rename to window_resize_check.
1563 (resize_window_apply): Rename to window_resize_apply.
1564 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1565 (Fdelete_other_windows_internal, resize_frame_windows)
1566 (Fsplit_window_internal, Fdelete_window_internal)
1567 (grow_mini_window, shrink_mini_window)
1568 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1569
c7e73be5
JD
15702011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1571
1572 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1573 (emacs_fixed_set_min_size): Remove.
1574 (emacs_fixed_new): Take frame as argument.
1575
1576 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1577 (_EmacsFixedPrivate): Remove minwidth/height.
1578 Add struct frame *f.
1579 (emacs_fixed_init): Initialize priv->f.
1580 (get_parent_class, emacs_fixed_set_min_size): Remove.
1581 (emacs_fixed_new): Set priv->f to argument.
1582 (emacs_fixed_get_preferred_width)
1583 (emacs_fixed_get_preferred_height): Use min_width/height from
1584 frames size_hint to set minimum and natural (Bug#8919).
1585 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1586 and use min_width/height from frames size_hint to set
1587 min_width/height (Bug#8919).
1588
1589 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1590 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1591 Fix indentation.
c7e73be5 1592
cf99dcf8
EZ
15932011-06-26 Eli Zaretskii <eliz@gnu.org>
1594
1595 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1596 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1597 called at ZV.
1598
029529ac
CY
15992011-06-26 Chong Yidong <cyd@stupidchicken.com>
1600
1601 * process.c (wait_reading_process_output): Bypass select if
1602 waiting for a cell while ignoring keyboard input, and input is
1603 pending. Suggested by Jan Djärv (Bug#8869).
1604
7a7ef429
PE
16052011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 Use gnulib's dup2 module instead of rolling our own.
1608 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1609
11fdef7d 16102011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1611
1612 * dispnew.c (scrolling_window): Before scrolling, turn off a
1613 mouse-highlight in the window being scrolled.
1614
cd3520a4
JB
16152011-06-24 Juanma Barranquero <lekktu@gmail.com>
1616
1617 Move DEFSYM to lisp.h and use everywhere.
1618
1619 * character.h (DEFSYM): Move declaration...
1620 * lisp.h (DEFSYM): ...here.
1621
1622 * gnutls.c:
1623 * minibuf.c:
1624 * w32menu.c:
1625 * w32proc.c:
1626 * w32select.c: Don't include character.h.
1627
1628 * alloc.c (syms_of_alloc):
1629 * buffer.c (syms_of_buffer):
1630 * bytecode.c (syms_of_bytecode):
1631 * callint.c (syms_of_callint):
1632 * casefiddle.c (syms_of_casefiddle):
1633 * casetab.c (init_casetab_once):
1634 * category.c (init_category_once, syms_of_category):
1635 * ccl.c (syms_of_ccl):
1636 * cmds.c (syms_of_cmds):
1637 * composite.c (syms_of_composite):
1638 * dbusbind.c (syms_of_dbusbind):
1639 * dired.c (syms_of_dired):
1640 * dispnew.c (syms_of_display):
1641 * doc.c (syms_of_doc):
1642 * editfns.c (syms_of_editfns):
1643 * emacs.c (syms_of_emacs):
1644 * eval.c (syms_of_eval):
1645 * fileio.c (syms_of_fileio):
1646 * fns.c (syms_of_fns):
1647 * frame.c (syms_of_frame):
1648 * fringe.c (syms_of_fringe):
1649 * insdel.c (syms_of_insdel):
1650 * keymap.c (syms_of_keymap):
1651 * lread.c (init_obarray, syms_of_lread):
1652 * macros.c (syms_of_macros):
1653 * msdos.c (syms_of_msdos):
1654 * print.c (syms_of_print):
1655 * process.c (syms_of_process):
1656 * search.c (syms_of_search):
1657 * sound.c (syms_of_sound):
1658 * syntax.c (init_syntax_once, syms_of_syntax):
1659 * terminal.c (syms_of_terminal):
1660 * textprop.c (syms_of_textprop):
1661 * undo.c (syms_of_undo):
1662 * w32.c (globals_of_w32):
1663 * window.c (syms_of_window):
1664 * xdisp.c (syms_of_xdisp):
1665 * xfaces.c (syms_of_xfaces):
1666 * xfns.c (syms_of_xfns):
1667 * xmenu.c (syms_of_xmenu):
1668 * xsettings.c (syms_of_xsettings):
1669 * xterm.c (syms_of_xterm): Use DEFSYM.
1670
4228cf16
TZ
16712011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1672
cd3520a4 1673 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1674
7fcccf1e
PE
16752011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1676
7efb4e0e
PE
1677 Integer and buffer overflow fixes (Bug#8873).
1678
ff5844ad
PE
1679 * print.c (printchar, strout): Check for string overflow.
1680 (PRINTPREPARE, printchar, strout):
1681 Don't set size unless allocation succeeds.
1682
90532f02
PE
1683 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1684 for sizes. Check for string overflow more accurately.
1685 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1686
6d84508d
PE
1687 * macros.c: Integer and buffer overflow fixes.
1688 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1689 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1690 Use ptrdiff_t, not int, for sizes.
1691 Don't increment bufsize until after realloc succeeds.
1692 Check for size-calculation overflow.
1693 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1694
437b2cb4
PE
1695 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1696
8b9ac8b4
PE
1697 * lread.c: Integer overflow fixes.
1698 (read_integer): Radix is now EMACS_INT, not int,
1699 to improve quality of diagnostics for out-of-range radices.
1700 Calculate buffer size correctly for out-of-range radices.
1701 (read1): Check for integer overflow in radices, and in
1702 read-circle numbers.
82cb60d3
PE
1703 (read_escape): Avoid int overflow.
1704 (Fload, openp, read_buffer_size, read1)
1705 (substitute_object_recurse, read_vector, read_list, map_obarray):
1706 Use ptrdiff_t, not int, for sizes.
1707 (read1): Use EMACS_INT, not int, for sizes.
20270765 1708 Check for size overflow.
8b9ac8b4 1709
7fcccf1e
PE
1710 * image.c (cache_image): Check for size arithmetic overflow.
1711
bfbbd7e7
PE
1712 * lread.c: Integer overflow issues.
1713 (saved_doc_string_size, saved_doc_string_length)
1714 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1715 Now ptrdiff_t, not int.
1716 (read1): Don't assume doc string length fits in int. Check for
1717 out-of-range doc string lengths.
1718 (read_list): Don't assume file position fits in int.
39019e54 1719 (read_escape): Check for hex character overflow.
bfbbd7e7 1720
4e323265
LL
17212011-06-22 Leo Liu <sdl.web@gmail.com>
1722
1723 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1724 Move to minibuffer.el.
1725
85fece3e
PE
17262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1727
20b84ce9 1728 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1729 The following patches are for when GLYPH_DEBUG && !XASSERT.
1730 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1731 * dispnew.c (flush_stdout):
1732 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1733 Mark as externally visible.
1734 * dispnew.c (check_window_matrix_pointers): Now static.
1735 * dispnew.c (window_to_frame_vpos):
1736 * xfns.c (unwind_create_frame):
1737 * xterm.c (x_check_font): Remove unused local.
1738 * scroll.c (CHECK_BOUNDS):
1739 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1740 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1741 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1742 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1743 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1744 Now static.
1745 (debug_method_add): Use va_list and vsprintf rather than relying
1746 on undefined behavior with wrong number of arguments.
1747 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1748 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1749 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1750 since we're not interested in debugging glyphs with old libraries.
1751 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1752 GCC 4.6.0's static checking.
1753
0766b489
PE
17542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1755
31fd4b32
PE
1756 Integer overflow and signedness fixes (Bug#8873).
1757 A few related buffer overrun fixes, too.
1758
b79e8648
PE
1759 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1760
0766b489
PE
1761 * dispextern.h (struct face.stipple):
1762 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1763 (x_bitmap_mask, x_allocate_bitmap_record)
1764 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1765 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1766 (x_create_bitmap_from_xpm_data):
1767 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1768 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1769 (.bitmaps_last):
1770 * xfaces.c (load_pixmap):
1771 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1772 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1773 (.bitmaps_last, struct x_output.icon_bitmap):
1774 Use ptrdiff_t, not int, for bitmap indexes.
1775 (x_allocate_bitmap_record): Check for size overflow.
1776 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1777
b081724f
PE
1778 Use ptrdiff_t, not int, for overlay counts.
1779 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1780 * editfns.c (overlays_around, get_pos_property):
1781 * textprop.c (get_char_property_and_overlay):
1782 * xdisp.c (next_overlay_change, note_mouse_highlight):
1783 * xfaces.c (face_at_buffer_position):
21514da7
PE
1784 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1785 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1786 (Fnext_overlay_change, Fprevious_overlay_change)
1787 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1788 Use ptrdiff_t, not int, for sizes.
21514da7 1789 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1790
3de73e5e
PE
1791 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1792
2606c57b
PE
1793 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1794 (x_session_initialize): Do not assume string length fits in int.
1795
aaafe47a
PE
1796 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1797 This is unlikely, but can occur if DPI is outlandish.
1798
2674ddc8 1799 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1800 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1801
28154962
PE
1802 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1803 * xrdb.c (magic_file_p, search_magic_path):
1804 Omit last arg SUFFIX; it was always 0. All callers changed.
1805 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1806
7de51af5
PE
1807 * xfont.c (xfont_match): Avoid need for strlen.
1808
25ed6cc3
PE
1809 * xfns.c: Don't assume strlen fits in int.
1810 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1811
4eab31dd
PE
1812 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1813 not unsigned long, as we prefer signed integers. All callers changed.
1814 Detect integer overflow in repeat count.
1815 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1816 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1817
171e2a58
PE
1818 * termcap.c: Don't assume sizes fit in int and never overflow.
1819 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1820 (gobble_line): Check for size-calculation overflow.
1821
ad39faca 1822 * minibuf.c (Fread_buffer):
6e5bb2dc 1823 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1824 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1825 Don't assume string length fits in int.
1826
52c61c22 1827 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1828 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1829
b5b8c9e5
PE
1830 * font.c: Don't assume string length fits in int.
1831 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1832 Use ptrdiff_t, not int.
ccd6111c
PE
1833 (font_intern_prop): Don't assume string length fits in int.
1834 Don't assume integer property fits in fixnum.
1835 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1836
882f0d81 1837 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1838 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1839 Reformulate so as not to need the command string.
1840 Invoke gzip -cd rather than gunzip, as it's more portable.
1841 (lock_info_type, lock_file_1, lock_file):
1842 Don't assume pid_t and time_t fit in unsigned long.
1843 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1844 (current_lock_owner): Prefer signed type for sizes.
1845 Use memcpy, not strncpy, where memcpy is what is really wanted.
1846 Don't assume (via atoi) that time_t and pid_t fit in int.
1847 Check for time_t and/or pid_t out of range, e.g., via a network share.
1848 Don't alloca where an auto var works fine.
1849
93f4cf88
PE
1850 * fileio.c: Fix some integer overflow issues.
1851 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1852 Don't assume string length fits in int.
1853 (directory_file_name): Don't assume string length fits in long.
1854 (make_temp_name): Don't assume pid fits in int, or that its print
1855 length is less than 20.
1856
f3e92b69
PE
1857 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1858
1bfdaf10
PE
1859 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1860
35016e9a
PE
1861 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1862
3d1e65a1
PE
1863 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1864 We prefer signed integers, even for size calculations.
1865
0b963a93
PE
1866 * emacs.c: Don't assume string length fits in 'int'.
1867 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1868 (main): Don't invoke strlen when not needed.
1869
573f4b54
PE
1870 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1871 (XD_DEBUG_MESSAGE): Don't waste a byte.
1872
989f33ba
PE
1873 * callproc.c (getenv_internal_1, getenv_internal)
1874 (Fgetenv_internal):
965d34eb
PE
1875 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1876
e4d29b33
PE
1877 * lread.c (invalid_syntax): Omit length argument.
1878 All uses changed. This doesn't fix a bug, but it simplifies the
1879 code away from its former Hollerith-constant appearance, and it's
1880 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1881 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1882
eb49b136
PE
1883 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1884 This didn't break anything, but it didn't help either.
1885 It's confusing to put a bogus integer in a place where the actual
1886 value does not matter.
9f62aeb1 1887 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1888 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1889
15375a22
PE
1890 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1891 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1892 implementation.
b61cc01c
PE
1893 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1894 We prefer signed types, and the value cannot exceed the EMACS_INT
1895 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1896 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1897 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1898 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1899
53b2623d
PE
1900 * indent.c (sane_tab_width): New function.
1901 (current_column, scan_for_column, Findent_to, position_indentation)
1902 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1903 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1904
51cab52b 1905 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1906
f2ed8a70
PE
1907 * lisp.h (lint_assume): New macro.
1908 * composite.c (composition_gstring_put_cache):
1909 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1910
abe80cc6
PE
1911 * editfns.c, insdel.c:
1912 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1913
b02c740e
PE
1914 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1915
ebc96716
PE
1916 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1917
b4e50fa0 1918 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1919 Use much-faster test for byte-length change.
311d5d7c 1920 Don't assume string byte-length fits in 'int'.
a4cf38e4 1921 Check that character arg fits in 'int'.
85461888 1922 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1923
c0c1ee9f
PE
1924 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1925
a498d7f4
PE
1926 * fns.c (concat): Catch string overflow earlier.
1927 Do not rely on integer wraparound.
1928
51cab52b
PE
1929 * dispextern.h (struct it.overlay_strings_charpos)
1930 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1931 * xdisp.c (forward_to_next_line_start)
1932 (back_to_previous_visible_line_start)
1933 (reseat_at_next_visible_line_start, next_element_from_buffer):
1934 Don't arbitrarily truncate the value of 'selective' to int.
1935
76031fad
PE
1936 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1937
5eb55db9
PE
1938 * composite.c: Don't truncate sizes to 'int'.
1939 (composition_gstring_p, composition_reseat_it)
1940 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1941 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1942 not EMACS_UINT, for indexes.
5eb55db9 1943
0703a717
PE
1944 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1945
d6202519
PE
1946 * buffer.c: Include <verify.h>.
1947 (struct sortvec.priority, struct sortstr.priority):
8961a454 1948 Now EMACS_INT, not int.
c20998a7 1949 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1950 (struct sortstr.size, record_overlay_string)
1951 (struct sortstrlist.size, struct sortlist.used):
1952 Don't truncate size to int.
1953 (record_overlay_string): Check for size-calculation overflow.
d6202519 1954 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1955
d5a19415
JM
19562011-06-22 Jim Meyering <meyering@redhat.com>
1957
029529ac 1958 Don't leak an XBM-image-sized buffer
d5a19415
JM
1959 * image.c (xbm_load): Free the image buffer after using it.
1960
a9041e6c
PE
19612011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 Port to Sun C.
1964 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1965 that Sun C diagnosed.
1966 * fns.c (secure_hash): Fix pointer signedness issue.
1967 * intervals.c (static_offset_intervals): New function.
1968 (offset_intervals): Use it.
1969
7f3f739f
LL
19702011-06-21 Leo Liu <sdl.web@gmail.com>
1971
1972 * deps.mk (fns.o):
1973 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1974 sha512.h.
1975
1976 * fns.c (secure_hash): Rename from crypto_hash_function and change
1977 the first arg to accept symbols.
5b66d427 1978 (Fsecure_hash): New primitive.
7f3f739f
LL
1979 (syms_of_fns): New symbols.
1980
76147d94
DD
19812011-06-20 Deniz Dogan <deniz@dogan.se>
1982
1983 * process.c (Fset_process_buffer): Clarify return value in
1984 docstring.
1985
7d7d0045
CY
19862011-06-18 Chong Yidong <cyd@stupidchicken.com>
1987
1988 * dispnew.c (add_window_display_history): Use BVAR.
1989
1990 * xdisp.c (debug_method_add): Use BVAR.
1991 (check_window_end, dump_glyph_matrix, dump_glyph)
1992 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1993
1994 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1995 Likewise.
1996
1997 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1998 check till after the cache is created in init_frame_faces.
1999
ff2bc410
SM
20002011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2001
2002 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2003
28177add
PE
20042011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2005
dd3482fe
PE
2006 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2007 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2008 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2009
393d71f3 2010 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2011 * fileio.c (Finsert_file_contents):
2012 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2013 Remove the old (too-loose) buffer overflow checks.
2014 They weren't needed, since make_gap checks for buffer overflow.
2015 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2016 The old code merely checked for Emacs fixnum overflow, and relied
2017 on undefined (wraparound) behavior. The new code avoids undefined
2018 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2019
2e6813b0 2020 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2021 Tune. Don't use wider integers than needed. Don't use alloca.
2022 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2023
599a9e4f
PE
2024 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2025
99561444
PE
2026 * insdel.c, lisp.h (buffer_overflow): New function.
2027 (insert_from_buffer_1, replace_range, replace_range_2):
2028 * insdel.c (make_gap_larger):
2029 * editfns.c (Finsert_char):
2030 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2031
28177add
PE
2032 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2033
e69dafad
PE
20342011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2035
a7af7fde 2036 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2037
b1c46f02
PE
2038 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2039 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2040
e69dafad
PE
2041 * fileio.c: Don't assume EMACS_INT fits in off_t.
2042 (emacs_lseek): New static function.
2043 (Finsert_file_contents, Fwrite_region): Use it.
2044 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2045
566684ea
PE
2046 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2047
e6966cd6
PE
2048 * fns.c: Don't overflow int when computing a list length.
2049 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2050 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2051 truncation on 64-bit hosts. Check for QUIT every
2052 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2053 faster and is responsive enough.
2054 (Flength): Report an error instead of overflowing an integer.
2055 (Fsafe_length): Return a float if the value is not representable
2056 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2057 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2058 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2059
dd0b0efb
PE
2060 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2061 (header_size, word_size): New constants.
2062 (allocate_vectorlike): Don't check size overflow here.
2063 (allocate_vector): Check it here instead, since this is the only
2064 caller of allocate_vectorlike that could cause overflow.
2065 Check that the new vector's length is representable as a fixnum.
2066
86fe5cfe
PE
2067 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2068 The previous code was bogus. For example, next_almost_prime (32)
2069 returned 39, which is undesirable as it is a multiple of 3; and
2070 next_almost_prime (24) returned 25, which is a multiple of 5 so
2071 why was the code bothering to check for multiples of 7?
2072
80e88859
PE
2073 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2074
4a2f0ad6
PE
2075 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2076
f66c7cf8
PE
2077 Variadic C functions now count arguments with ptrdiff_t.
2078 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2079 Back then I didn't know that the Emacs coding style prefers signed int.
2080 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2081 were being counted with int, which may truncate counts on 64-bit
2082 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2083 * lisp.h (struct Lisp_Subr.function.aMANY)
2084 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2085 Arg counts are now ptrdiff_t, not size_t.
2086 All variadic functions and their callers changed accordingly.
2087 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2088 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2089 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2090 * callint.c (Fcall_interactively): Check arg count for overflow,
2091 to avoid potential buffer overrun. Use signed char, not 'int',
2092 for 'varies' array, so that we needn't bother to check its size
2093 calculation for overflow.
2094 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2095 * eval.c (apply_lambda):
2096 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2097 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2098 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2099
a1759b76
PE
2100 * callint.c (Fcall_interactively): Don't use index var as event count.
2101
d96be9fc
PE
2102 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2103 * mem-limits.h (SIZE): Remove; no longer used.
2104
a690a978 2105 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2106
578c21e6
PE
2107 Remove unnecessary casts.
2108 * xterm.c (x_term_init):
2109 * xfns.c (x_set_border_pixel):
2110 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2111 These aren't needed now that we assume ANSI C.
2112
96f53c6c
PE
2113 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2114 It's more likely to cause problems (due to unsigned overflow)
2115 than to cure them.
2116
83c77d31
PE
2117 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2118
ee2079f1
PE
2119 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2120
6da65536
PE
2121 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2122
7147c4a4
PE
2123 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2124
193e32d9
PE
2125 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2126
e5533da6
PE
2127 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2128
9910e595
PE
2129 GLYPH_CODE_FACE returns EMACS_INT, not int.
2130 * dispextern.h (merge_faces):
2131 * xfaces.c (merge_faces):
01103c44
PE
2132 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2133 Don't assume EMACS_INT fits in int.
9910e595 2134
2638320e
PE
2135 * character.h (CHAR_VALID_P): Remove unused parameter.
2136 * fontset.c, lisp.h, xdisp.c: All uses changed.
2137
045eb8d9
PE
2138 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2139
c1f134b5
PE
2140 * fns.c (concat): Minor tuning based on overflow analysis.
2141 This doesn't fix any bugs. Use int to hold character, instead
2142 of constantly refetching from Emacs object. Use XFASTINT, not
2143 XINT, for value known to be a character. Don't bother comparing
2144 a single byte to 0400, as it's always less.
2145
395fcb93 2146 * floatfns.c (Fexpt):
327eeec8
PE
2147 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2148
abbd3d23
PE
2149 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2150 for characters.
2151
684a03ef
PE
2152 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2153
0fed43f3
PE
2154 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2155 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2156 incorrectly succeed when S was a string, because 4294967386 was
2157 truncated before it was used.
2158
8fd02eb7
PE
2159 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2160 Otherwise, an out-of-range integer could cause undefined behavior
2161 on a 64-bit host.
2162
f8c86b69
PE
2163 * composite.c: Use int, not EMACS_INT, for characters.
2164 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2165 EMACS_INT, for values that are known to be in character range.
2166 This doesn't fix any bugs but is the usual style inside Emacs and
2167 may generate better code on 32-bit machines.
2168
34206dd2
PE
2169 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2170 This is for reasons similar to the recent CHAR_STRING fix.
2171 * charset.c (Fencode_char): Check that character arg is actually
2172 a character. Pass an int to ENCODE_CHAR.
2173 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2174 wider than 'int', as a compile-time check to prevent future regressions
2175 in this area.
2176
c5958d4c 2177 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2178
2179 Make sure a 64-bit char is never passed to CHAR_STRING.
2180 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2181 by silently ignoring the top 32 bits, allowing some values
2182 that were far too large to be valid characters.
2183 * character.h: Include <verify.h>.
2184 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2185 arguments are no wider than unsigned, as a compile-time check
2186 to prevent future regressions in this area.
2187 * data.c (Faset):
01103c44 2188 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2189 (Fsubst_char_in_region):
2190 * fns.c (concat):
2191 * xdisp.c (decode_mode_spec_coding):
2192 Adjust to CHAR_STRING's new requirement.
2193 * editfns.c (Finsert_char, Fsubst_char_in_region):
2194 * fns.c (concat): Check that character args are actually
2195 characters. Without this test, these functions did the wrong
2196 thing with wildly out-of-range values on 64-bit hosts.
2197
d37ca623
PE
2198 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2199 These casts should not be needed on 32-bit hosts, either.
2200 * keyboard.c (read_char):
2201 * lread.c (Fload): Remove casts to unsigned.
2202
ea204efb
PE
2203 * lisp.h (UNSIGNED_CMP): New macro.
2204 This fixes comparison bugs on 64-bit hosts.
2205 (ASCII_CHAR_P): Use it.
2206 * casefiddle.c (casify_object):
01103c44 2207 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2208 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2209 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2210 * dispextern.h (FACE_FROM_ID):
2211 * keyboard.c (read_char): Use UNSIGNED_CMP.
2212
41cb286c
PE
2213 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2214 not to EMACS_INT, to avoid GCC warning.
2215
4a1b9832
PE
2216 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2217
55daad71
PE
2218 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2219 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2220 isn't needed on 32-bit machines.
8f95c75c 2221
01103c44
PE
2222 * buffer.c (Fgenerate_new_buffer_name):
2223 Use EMACS_INT for count, not int.
0ceccced 2224 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2225
2226 * data.c (Qcompiled_function): Now static.
2227
c6f072e7
PE
2228 * window.c (window_body_lines): Now static.
2229
20ce5912
PE
2230 * image.c (gif_load): Rename local to avoid shadowing.
2231
9c4c5f81
PE
2232 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2233 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2234 * alloc.c (make_save_value): Integer argument is now of type
2235 ptrdiff_t, not int.
2236 (mark_object): Use ptrdiff_t, not int.
2237 * lisp.h (pD): New macro.
2238 * print.c (print_object): Use it.
2239
c0c5c8ae
PE
2240 * alloc.c: Use EMACS_INT, not int, to count objects.
2241 (total_conses, total_markers, total_symbols, total_vector_size)
2242 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2243 (total_free_floats, total_floats, total_free_intervals)
2244 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2245 Now EMACS_INT, not int. All uses changed.
2246 (Fgarbage_collect): Compute overall total using a double, so that
2247 integer overflow is less likely to be a problem. Check for overflow
2248 when converting back to an integer.
5a25e253
PE
2249 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2250 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2251 These were 'int' variables that could overflow on 64-bit hosts;
2252 they were never used, so remove them instead of repairing them.
211a0b2a 2253 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2254 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2255 Previously, this ceilinged at INT_MAX, but that doesn't work on
2256 64-bit machines.
e46bb31a 2257 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2258
c78baabf 2259 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2260 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2261 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2262 when a (possibly-narrower) signed value would do just as well.
2263 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2264
c9d624c6
PE
2265 * alloc.c: Catch some string size overflows that we were missing.
2266 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2267 for convenience in STRING_BYTES_MAX.
2268 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2269 The definition here is exact; the one in lisp.h was approximate.
2270 (allocate_string_data): Check for string overflow. This catches
2271 some instances we weren't catching before. Also, it catches
2272 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2273 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2274 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2275
c9d624c6
PE
2276 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2277 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2278 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2279
353032ce
PE
2280 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2281
2bccce07
PE
2282 * alloc.c (Fmake_string): Check for out-of-range init.
2283
0ac30604
SM
22842011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2285
2286 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2287
c195f2de
JD
22882011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2289
2290 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2291 xg_get_default_scrollbar_width.
2292
2293 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2294 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2295 (style_changed_cb): Call update_theme_scrollbar_width and call
2296 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2297 all frames (Bug#8505).
2298 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2299 Call gtk_window_set_resizable if HAVE_GTK3.
2300 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2301 and height if HAVE_GTK3 (Bug#8505).
2302 (scroll_bar_width_for_theme): New variable.
2303 (update_theme_scrollbar_width): New function.
2304 (xg_get_default_scrollbar_width): Move code to
2305 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2306 (xg_initialize): Call update_theme_scrollbar_width.
2307
2308 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2309
2310 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2311
e10ac9f1
MR
23122011-06-12 Martin Rudalics <rudalics@gmx.at>
2313
2314 * frame.c (make_frame): Call other_buffer_safely instead of
2315 other_buffer.
2316
2317 * window.c (temp_output_buffer_show): Call display_buffer with
2318 second argument Vtemp_buffer_show_specifiers and reset latter
2319 immediately after the call.
2320 (Vtemp_buffer_show_specifiers): New variable.
2321 (auto_window_vscroll_p, next_screen_context_lines)
2322 (Vscroll_preserve_screen_position): Remove leading asterisks from
2323 doc-strings.
2324
2d3c217e 23252011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2326
7b7f97e8 2327 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2328 * buffer.c (Qclone_number): Remove for now, as it's unused.
2329 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2330 (record_buffer): Remove unused local.
2331 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2332 (set_frame_buffer_list): Remove; unused.
2333 * frame.h (other_visible_frames): Remove decl.
2334 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2335 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2336 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2337 if HAVE_GPM.
2338 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2339 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2340 Define only if HAVE_GPM.
2341 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2342 (update_hints_inhibit): Remove; never set. All uses removed.
2343 * widgetprv.h (emacsFrameClassRec): Remove decl.
2344 * window.c (delete_deletable_window): Now returns void, since it
2345 wasn't returning anything.
2346 (compare_window_configurations): Remove unused locals.
2347 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2348 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2349 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2350 the same widths as pointers. This follows up on the 2011-05-06 patch.
2351 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2352 * xterm.h: Likewise.
2353 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2354
1384b89e
JB
23552011-06-12 Juanma Barranquero <lekktu@gmail.com>
2356
2357 * makefile.w32-in: Update dependencies.
2358 (LISP_H): Add lib/intprops.h.
2359
1100a63c
CY
23602011-06-11 Chong Yidong <cyd@stupidchicken.com>
2361
2362 * image.c (gif_load): Add animation frame delay to the metadata.
2363 (syms_of_image): Use DEFSYM. New symbol `delay'.
2364
6198ccd0
MR
23652011-06-11 Martin Rudalics <rudalics@gmx.at>
2366
2367 * window.c (delete_deletable_window): Re-add.
2368 (Fset_window_configuration): Rewrite to handle dead buffers and
2369 consequently deletable windows.
2370 (window_tree, Fwindow_tree): Remove. Supply functionality in
2371 window.el.
2372 (compare_window_configurations): Simplify code.
2373
b6e3633c
AS
23742011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2375
1ab0dee5
AS
2376 * image.c (imagemagick_load_image): Fix type mismatch.
2377 (Fimagemagick_types): Likewise.
2378
b6e3633c
AS
2379 * window.h (replace_buffer_in_windows): Declare.
2380
9397e56f
MR
23812011-06-11 Martin Rudalics <rudalics@gmx.at>
2382
2383 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2384 Qclone_number. Remove external declaration of Qdelete_window.
2385 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2386 code.
640c8776
SM
2387 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2388 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2389 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2390 buffer list implementation.
2391 (other_buffer_safely): New function.
2392 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2393 calls to replace_buffer_in_windows and
2394 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2395 if allowed.
2396 (record_buffer): Inhibit quitting and rewrite using quittable
2397 functions. Run Qbuffer_list_update_hook if allowed.
2398 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2399 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2400 Move switch-to-buffer to window.el.
9397e56f
MR
2401 (bury-buffer): Move to window.el.
2402 (Vbuffer_list_update_hook): New variable.
2403
2404 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2405 section.
2406
2407 * window.h (resize_frame_windows): Move up in code.
2408 (Fwindow_frame): Remove EXFUN.
2409 (replace_buffer_in_all_windows): Remove prototype.
2410 (replace_buffer_in_windows_safely): Add prototype.
2411
2412 * window.c: Declare Qdelete_window static again. Move down
2413 declaration of select_count.
2414 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2415 (Fother_window): Move to window.el.
2416 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2417 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2418 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2419 window.el.
2420 (replace_buffer_in_windows): Implement by calling
2421 Qreplace_buffer_in_windows.
2422 (replace_buffer_in_all_windows): Remove with some functionality
2423 moved into replace_buffer_in_windows_safely.
2424 (replace_buffer_in_windows_safely): New function.
2425 (select_window_norecord, select_frame_norecord): Move in front
2426 of run_window_configuration_change_hook. Remove now obsolete
2427 declarations.
640c8776
SM
2428 (Fset_window_buffer): Rewrite doc-string.
2429 Call Qrecord_window_buffer.
9397e56f
MR
2430 (keys_of_window): Move binding for other-window to window.el.
2431
b50691aa
CY
24322011-06-11 Chong Yidong <cyd@stupidchicken.com>
2433
2434 * dispextern.h (struct image): Replace data member, whose int_val
2435 and ptr_val fields were not used by anything, with a single
2436 lisp_val object.
2437
2438 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2439 (gif_clear_image, gif_load, imagemagick_load_image)
2440 (gs_clear_image, gs_load): Callers changed.
2441
3f754b86
PE
24422011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2443
cca69397
PE
2444 * buffer.h: Include <time.h>, for time_t.
2445 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2446
109e28d0
PE
2447 Fix minor problems found by static checking.
2448
60737f02
PE
2449 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2450
4b66faf3
PE
2451 Make identifiers static if they are not used in other modules.
2452 * data.c (Qcompiled_function, Qframe, Qvector):
2453 * image.c (QimageMagick, Qsvg):
2454 * minibuf.c (Qmetadata):
2455 * window.c (resize_window_check, resize_root_window): Now static.
2456 * window.h (resize_window_check, resize_root_window): Remove decls.
2457
109e28d0
PE
2458 * window.c (window_deletion_count, delete_deletable_window):
2459 Remove; unused.
46a4ce9e
PE
2460 (window_body_lines): Now static.
2461 (Fdelete_other_windows_internal): Mark vars as initialized.
2462 Make sure 'resize_failed' is initialized.
2463 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2464 (resize_window_apply): Remove unused local.
2465 * window.h (delete_deletable_window): Remove decl.
2466
109e28d0 2467 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2468 (imagemagick_load_image): Fix pointer signedness problem by changing
2469 last arg from unsigned char * to char *. All uses changed.
2470 Also, fix a local for similar reasons.
2471 Remove unused locals. Remove locals to avoid shadowing.
2472 (fn_rsvg_handle_free): Remove; unused.
2473 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2474 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2475
3f754b86
PE
2476 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2477
2547adb1
CY
24782011-06-10 Chong Yidong <cyd@stupidchicken.com>
2479
2480 * image.c (gif_load): Fix omitted cast error introduced by
2481 2011-06-06 change.
2482
2c8e37d4
MR
24832011-06-10 Martin Rudalics <rudalics@gmx.at>
2484
2485 * window.h (resize_proportionally, orig_total_lines)
2486 (orig_top_line): Remove from window structure.
2487 (set_window_height, set_window_width, change_window_heights)
2488 (Fdelete_window): Remove prototypes.
2489 (resize_frame_windows): Remove duplicate declaration.
2490
440a42e3
EZ
24912011-06-10 Eli Zaretskii <eliz@gnu.org>
2492
2493 * window.h (resize_frame_windows, resize_window_check)
2494 (delete_deletable_window, resize_root_window)
2495 (resize_frame_windows): Declare prototypes.
2496
2497 * window.c (resize_window_apply): Make definition be "static" to
2498 match the prototype.
2499
562dd5e9
MR
25002011-06-10 Martin Rudalics <rudalics@gmx.at>
2501
2502 * window.c: Remove declarations of Qwindow_size_fixed,
2503 window_min_size_1, window_min_size_2, window_min_size,
2504 size_window, window_fixed_size_p, enlarge_window, delete_window.
2505 Remove static from declaration of Qdelete_window, it's
2506 temporarily needed by Fbury_buffer.
2507 (replace_window): Don't assign orig_top_line and
2508 orig_total_lines.
2509 (Fdelete_window, delete_window): Remove. Window deletion is
2510 handled by window.el.
640c8776
SM
2511 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2512 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2513 (Fdelete_other_windows): Remove. Deleting other windows is
2514 handled by window.el.
2515 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2516 handled in window.el.
2517 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2518 Window minimum sizes are handled in window.el.
2519 (shrink_windows, size_window, set_window_height)
2520 (set_window_width, change_window_heights, window_height)
2521 (window_width, CURBEG, CURSIZE, enlarge_window)
2522 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2523 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2524 handled in window.el.
2525 (make_dummy_parent): Rename to make_parent_window and give it a
2526 second argument horflag.
2527 (make_window): Don't set resize_proportionally any more.
2528 (Fsplit_window): Remove. Windows are split in window.el.
2529 (save_restore_action, save_restore_orig_size)
2530 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2531 Resize mini windows in window.el.
2532 (grow_mini_window, shrink_mini_window): Implement by calling
2533 Qresize_root_window_vertically, resize_window_check and
2534 resize_window_apply.
640c8776
SM
2535 (saved_window, Fset_window_configuration, save_window_save):
2536 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2537 resize_proportionally.
2538 (window_min_height, window_min_width): Move to window.el.
2539 (keys_of_window): Move bindings for delete-other-windows,
2540 split-window, delete-window and enlarge-window to window.el.
2541
2542 * buffer.c: Temporarily extern Qdelete_window.
2543 (Fbury_buffer): Temporarily call Qdelete_window instead of
2544 Fdelete_window (Fbury_buffer will move to window.el soon).
2545
2546 * frame.c (set_menu_bar_lines_1): Remove code handling
2547 orig_top_line and orig_total_lines.
2548
2549 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2550 set_window_height but set heights directly.
2551 (change_frame_size_1): Use resize_frame_windows.
2552
2553 * xdisp.c (init_xdisp): Don't use set_window_height but set
2554 heights directly.
2555
640c8776
SM
2556 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2557 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2558 run_window_configuration_change_hook.
2559
2560 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2561 instead of change_window_heights and run
2562 run_window_configuration_change_hook.
2563
1a13852e
MR
25642011-06-09 Martin Rudalics <rudalics@gmx.at>
2565
2566 * window.c (replace_window): Rename second argument REPLACEMENT to
2567 NEW. New third argument SETFLAG. Rewrite.
2568 (delete_window, make_dummy_parent): Call replace_window with
2569 third argument 1.
2570 (window_list_1): Move down in code.
2571 (run_window_configuration_change_hook): Move set_buffer part
2572 before select_frame_norecord part in order to unwind correctly.
2573 Rename count1 to count.
2574 (recombine_windows, delete_deletable_window, resize_root_window)
2575 (Fdelete_other_windows_internal)
2576 (Frun_window_configuration_change_hook, make_parent_window)
2577 (resize_window_check, resize_window_apply, Fresize_window_apply)
2578 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2579 (Fdelete_window_internal, Fresize_mini_window_internal):
2580 New functions.
1a13852e
MR
2581 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2582
f3d1777e
MR
25832011-06-08 Martin Rudalics <rudalics@gmx.at>
2584
496e208e
MR
2585 * window.h (window): Add some new members to window structure -
2586 normal_lines, normal_cols, new_total, new_normal, clone_number,
2587 splits, nest, prev_buffers, next_buffers.
2588 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2589 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2590
f3d1777e
MR
2591 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2592 Remove.
496e208e
MR
2593 (make_dummy_parent): Set new members of windows structure.
2594 (make_window): Move down in code. Handle new members of window
2595 structure.
2596 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2597 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2598 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2599 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2600 (Fset_window_next_buffers, Fset_window_clone_number):
2601 New functions.
496e208e
MR
2602 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2603 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2604 Doc-string fixes.
2605 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2606 Argument WINDOW can be now internal window too.
2607 (Fwindow_use_time): Move up in code.
2608 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2609 Rewrite doc-string.
2610 (Fset_window_configuration, saved_window)
2611 (Fcurrent_window_configuration, save_window_save): Handle new
2612 members of window structure.
b9e809c2
MR
2613 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2614 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2615 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2616 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2617 Qget_mru_window, Qresize_root_window,
2618 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2619 Qauto_buffer_name; staticpro them.
f3d1777e 2620
abde8f8c
MR
26212011-06-07 Martin Rudalics <rudalics@gmx.at>
2622
2623 * window.c (Fwindow_total_size, Fwindow_left_column)
2624 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2625 (Fwindow_list_1): New functions.
2626 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2627 (Fwindow_width, Fscroll_left, Fscroll_right):
2628 Use window_body_cols instead of window_box_text_cols.
2629 (delete_window, Fset_window_configuration):
2630 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2631 (delete_all_subwindows): Take a window as argument and not a
2632 structure. Rewrite.
190b47e6
MR
2633 (window_loop): Remove handling of GET_LRU_WINDOW and
2634 GET_LARGEST_WINDOW.
2635 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2636
2637 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2638 window_box_text_cols. delete_all_subwindows now takes a
2639 Lisp_Object as argument.
abde8f8c 2640
640c8776
SM
2641 * indent.c (compute_motion, Fcompute_motion):
2642 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2643
fa8a67e6
MR
2644 * frame.c (delete_frame): Call delete_all_subwindows with root
2645 window as argument.
2646
a54e3482
DC
26472011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2648
2649 * fns.c (Fputhash): Document return value.
2650
60002bf5
CY
26512011-06-06 Chong Yidong <cyd@stupidchicken.com>
2652
2653 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2654
0c671da6 26552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2656
b862a52a 2657 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2658
be44ca6c
PE
2659 Check for overflow when converting integer to cons and back.
2660 * charset.c (Fdefine_charset_internal, Fdecode_char):
2661 Use cons_to_unsigned to catch overflow.
2662 (Fencode_char): Use INTEGER_TO_CONS.
2663 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2664 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2665 * data.c (long_to_cons, cons_to_long): Remove.
2666 (cons_to_unsigned, cons_to_signed): New functions.
2667 These signal an error for invalid or out-of-range values.
2668 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2669 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2670 * font.c (Ffont_variation_glyphs):
2671 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2672 * lisp.h: Include <intprops.h>.
2673 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2674 (cons_to_signed, cons_to_unsigned): New decls.
2675 (long_to_cons, cons_to_long): Remove decls.
2676 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2677 (Fprimitive_undo): Use CONS_TO_INTEGER.
2678 * xfns.c (Fx_window_property): Likewise.
2679 * xselect.c: Include <limits.h>.
2680 (x_own_selection, selection_data_to_lisp_data):
2681 Use INTEGER_TO_CONS.
2682 (x_handle_selection_request, x_handle_selection_clear)
2683 (x_get_foreign_selection, Fx_disown_selection_internal)
2684 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2685 (lisp_data_to_selection_data): Use cons_to_unsigned.
2686 (x_fill_property_data): Use cons_to_signed.
2687 Report values out of range.
2688
d1f3d2af
PE
2689 Check for buffer and string overflow more precisely.
2690 * buffer.h (BUF_BYTES_MAX): New macro.
2691 * lisp.h (STRING_BYTES_MAX): New macro.
2692 * alloc.c (Fmake_string):
2693 * character.c (string_escape_byte8):
2694 * coding.c (coding_alloc_by_realloc):
2695 * doprnt.c (doprnt):
2696 * editfns.c (Fformat):
2697 * eval.c (verror):
2698 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2699 since they may not be the same number.
2700 * editfns.c (Finsert_char):
2701 * fileio.c (Finsert_file_contents):
2702 Likewise for BUF_BYTES_MAX.
2703
dd52fcea
PE
2704 * image.c: Use ptrdiff_t, not int, for sizes.
2705 (slurp_file): Switch from int to ptrdiff_t.
2706 All uses changed.
2707 (slurp_file): Check that file size fits in both size_t (for
2708 malloc) and ptrdiff_t (for sanity and safety).
2709
7f9bbdbb
PE
2710 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2711 if b->modtime has its maximal value.
2712
dfe18f82
PE
2713 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2714
84acfcf0
PE
2715 Don't assume time_t can fit into int.
2716 * buffer.h (struct buffer.modtime): Now time_t, not int.
2717 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2718 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2719
ccd9a01a
PE
2720 Minor fixes for signed vs unsigned integers.
2721 * character.h (MAYBE_UNIFY_CHAR):
2722 * charset.c (maybe_unify_char):
2723 * keyboard.c (read_char, reorder_modifiers):
2724 XINT -> XFASTINT, since the integer must be nonnegative.
2725 * ftfont.c (ftfont_spec_pattern):
2726 * keymap.c (access_keymap, silly_event_symbol_error):
2727 XUINT -> XFASTINT, since the integer must be nonnegative.
2728 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2729 since it makes no difference and we prefer signed.
2730 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2731 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2732 nonnegative.
2733
d6d100dd
SM
27342011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2735
2736 * window.h (Fwindow_frame): Declare.
2737
2b6148e4
PE
27382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2741 (SPARE_MEMORY): Always define.
2742 (LARGE_REQUEST): Remove.
2743 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2744
f230ecc9
MR
27452011-06-06 Martin Rudalics <rudalics@gmx.at>
2746
727e958e
MR
2747 * lisp.h: Move EXFUNS for Fframe_root_window,
2748 Fframe_first_window and Fset_frame_selected_window to window.h.
2749
2750 * window.h: Move EXFUNS for Fframe_root_window,
2751 Fframe_first_window and Fset_frame_selected_window here from
2752 lisp.h.
2753
2754 * frame.c (Fwindow_frame, Fframe_first_window)
2755 (Fframe_root_window, Fframe_selected_window)
2756 (Fset_frame_selected_window): Move to window.c.
2757 (Factive_minibuffer_window): Move to minibuf.c.
2758 (Fother_visible_frames_p): New function.
2759
2760 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2761
f230ecc9
MR
2762 * window.c (decode_window, decode_any_window): Move up in code.
2763 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2764 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2765 (Fwindow_buffer): Move up and rewrite doc-string.
2766 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2767 (Fwindow_prev): New functions.
727e958e
MR
2768 (Fwindow_frame): Move here from frame.c. Accept any window as
2769 argument.
2770 (Fframe_root_window, Fframe_first_window)
2771 (Fframe_selected_window): Move here from frame.c. Accept frame
2772 or arbitrary window as argument. Update doc-strings.
2773 (Fminibuffer_window): Move up in code.
2774 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2775 (Fset_frame_selected_window): Move here from frame.c.
2776 Marginal rewrite.
727e958e
MR
2777 (Fselected_window, select_window, Fselect_window): Move up in
2778 code. Minor doc-string fixes.
f230ecc9 2779
4d09bcf6
PE
27802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2783 Do not assume that spare memory exists; that assumption is valid
2784 only if SYSTEM_MALLOC.
2785 (LARGE_REQUEST): New macro, so that the issue of large requests
2786 is separated from the issue of spare memory.
2787
810928a2
AS
27882011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2789
172418ad
AS
2790 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2791 format. (Bug#8806)
2792
43f862f7
AS
2793 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2794
810928a2
AS
2795 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2796 before statements.
2797
a059fe24
JD
27982011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2799
2800 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2801
2802 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2803
2804 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2805 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2806
989bf368
JB
28072011-06-05 Juanma Barranquero <lekktu@gmail.com>
2808
2809 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2810
4b80f674
CY
28112011-06-04 Chong Yidong <cyd@stupidchicken.com>
2812
2813 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2814 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2815 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2816 New error handlers.
4b80f674
CY
2817 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2818 Obey Vx_select_enable_clipboard_manager. Catch errors in
2819 x_clipboard_manager_save (Bug#8779).
2820 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2821 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2822
99a33b77 28232011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2824
2825 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2826
99a33b77 28272011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2828
2829 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2830 in the current matrix if keep_current_p is non-zero.
2831
8264569d
EZ
28322011-06-04 Eli Zaretskii <eliz@gnu.org>
2833
2834 * bidi.c (bidi_level_of_next_char): Fix last change.
2835
57f97249
EZ
28362011-06-03 Eli Zaretskii <eliz@gnu.org>
2837
fec2107c 2838 Support bidi reordering of text covered by display properties.
57f97249 2839
fec2107c
EZ
2840 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2841 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2842 (bidi_cache_search, bidi_cache_iterator_state)
2843 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2844 (bidi_level_of_next_char, bidi_move_to_visually_next):
2845 Support character positions inside a run of characters covered by a
fec2107c
EZ
2846 display string.
2847 (bidi_paragraph_init, bidi_resolve_explicit_1)
2848 (bidi_level_of_next_char): Call bidi_fetch_char and
2849 bidi_fetch_char_advance instead of FETCH_CHAR and
2850 FETCH_CHAR_ADVANCE.
2851 (bidi_init_it): Initialize new members.
2852 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2853 definitions.
2854 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2855 instead of using explicit *_CHAR codes.
d6d100dd
SM
2856 (bidi_resolve_explicit, bidi_resolve_weak):
2857 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2858 bidirectional text is supported only in multibyte buffers.
2859 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2860 it to initialize the frame_window_p member of struct bidi_it.
2861 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2862 (bidi_resolve_explicit, bidi_resolve_weak)
2863 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2864 bidi_it->nchars is non-positive.
2865 (bidi_level_of_next_char): Don't try to lookup the cache for the
2866 next/previous character if nothing is cached there yet, or if we
2867 were just reseat()'ed to a new position.
c40e2fb2 2868
0e14fe90
EZ
2869 * xdisp.c (set_cursor_from_row): Set start and stop points
2870 according to the row's direction when priming the loop that looks
2871 for the glyph on which to display cursor.
2872 (single_display_spec_intangible_p): Function deleted.
2873 (display_prop_intangible_p): Reimplement to call
2874 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2875 Accept 3 additional arguments needed by handle_display_spec.
2876 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2877 values: lists, `(when COND...)' forms, etc.
2878 (single_display_spec_string_p): Support property values that are
2879 lists with the argument STRING its top-level element.
2880 (display_prop_string_p): Fix the condition for processing a
2881 property that is a list to be consistent with handle_display_spec.
fec2107c 2882 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2883 last portion of handle_display_prop.
2884 (compute_display_string_pos): Accept additional argument
2885 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2886 value of a `display' property is a "replacing spec".
2887 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2888 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2889 the display property, but just return a value indicating whether
2890 the display property will replace the characters it covers.
2891 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2892 frame_window_p members of struct bidi_it.
d6d100dd
SM
2893 (compute_display_string_pos, compute_display_string_end):
2894 New functions.
fec2107c
EZ
2895 (push_it): Accept second argument POSITION, where pop_it should
2896 jump to continue iteration.
2897 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2898
fec2107c
EZ
2899 * keyboard.c (adjust_point_for_property): Adjust the call to
2900 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2901
2902 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2903 (bidi_init_it): Update prototypes.
2904 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2905 (compute_display_string_pos, compute_display_string_end):
2906 Declare prototypes.
fec2107c
EZ
2907 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2908 EMACS_INT.
fc6f18ce 2909
40087514 29102011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2911
57f53182
PE
2912 Malloc failure behavior now depends on size of allocation.
2913 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2914 * lisp.h: Change signatures accordingly.
2915 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2916 All callers changed. (Bug#8762)
2917
2918 * gnutls.c: Use Emacs's memory allocators.
2919 Without this change, the gnutls library would invoke malloc etc.
2920 directly, which causes problems on non-SYNC_INPUT hosts, and which
2921 runs afoul of improving memory_full behavior. (Bug#8761)
2922 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2923 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2924 xfree instead of the default malloc, realloc, free.
2925 (Fgnutls_boot): No need to check for memory allocation failure,
2926 since xmalloc does that for us.
2927
ac32cd99 2928 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2929 * category.c (hash_get_category_set):
2930 * ccl.c (ccl_driver):
2931 * charset.c (Fdefine_charset_internal):
2932 * charset.h (struct charset.hash_index):
2933 * composite.c (get_composition_id, gstring_lookup_cache)
2934 (composition_gstring_put_cache):
2935 * composite.h (struct composition.hash_index):
2936 * dispextern.h (struct image.hash):
2937 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2938 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2939 (hashfn_equal, hashfn_user_defined, make_hash_table)
2940 (maybe_resize_hash_table, hash_lookup, hash_put)
2941 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2942 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2943 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2944 * image.c (make_image, search_image_cache, lookup_image)
2945 (xpm_put_color_table_h):
2946 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2947 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2948 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2949 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2950 * alloc.c (allocate_vectorlike):
2951 Check for overflow in vector size calculations.
2952 * ccl.c (ccl_driver):
2953 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2954 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2955 need to be updated by these changes.
40087514
PE
2956 * fns.c (make_hash_table, maybe_resize_hash_table):
2957 Check for integer overflow with large hash tables.
0de4bb68
PE
2958 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2959 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2960 (SXHASH_REDUCE): New macro.
2961 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2962 Use it instead of discarding useful hash info with large hash values.
2963 (sxhash_float): New function.
2964 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2965 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2966 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2967 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2968 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2969 Adjust signatures to match updated version of code.
2970 (consing_since_gc): Now EMACS_INT, since a single hash table can
2971 use more than INT_MAX bytes.
2972
698d32e2
DN
29732011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2974
2975 Make it possible to build with GCC-4.6+ -O2 -flto.
2976
2977 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2978
fd6fa53f
SM
29792011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2980
2981 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2982 Call minibuffer-inactive-mode.
2983
864db017
JB
29842011-05-31 Juanma Barranquero <lekktu@gmail.com>
2985
2986 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2987 Update dependencies.
2988
2ad0baf4
DN
29892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2990
2991 * data.c (init_data): Remove code for UTS, this system is not
2992 supported anymore.
2993
4fcc2638
DN
29942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2995
2996 Don't force ./temacs to start in terminal mode.
2997
2998 * frame.c (make_initial_frame): Initialize faces in all cases, not
2999 only when CANNOT_DUMP is defined.
3000 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3001
c56e0fd5
DN
30022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3003
3004 * dispnew.c (add_window_display_history): Use const for the string
3005 pointer. Remove declaration, not needed.
3006
333d54da 30072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3008
55d4c1b2 3009 Use 'inline', not 'INLINE'.
333d54da 3010 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3011 * alloc.c, fontset.c (INLINE): Remove.
3012 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3013 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3014 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3015 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3016 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3017
738db178
DN
30182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3019
3020 Make it possible to run ./temacs.
3021
3022 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3023 syms_of_callproc does the same thing. Remove test for
3024 "initialized", do it in the caller.
3025 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3026
620c53a6
SM
30272011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3028
3029 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3030 (read_minibuf): Use get_minibuffer.
3031 (syms_of_minibuf): Use DEFSYM.
3032 (Qmetadata): New var.
3033 * data.c (Qbuffer): Don't make it static.
3034 (syms_of_data): Use DEFSYM.
3035
e003a292
PE
30362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3037
3038 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3039 (CCL_CODE_MIN): New macro.
3040
ed008a6d
PE
30412011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3042
3687c2ef
PE
3043 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3044
ed008a6d
PE
3045 * eval.c (Qdebug): Now static.
3046 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3047 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3048 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3049
d66c4c7c
CY
30502011-05-29 Chong Yidong <cyd@stupidchicken.com>
3051
3052 * image.c: Various fixes to ImageMagick code comments.
3053 (Fimagemagick_types): Doc fix.
3054
5fbc2025
PE
30552011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3056
0196f88a
PE
3057 Minor fixes prompted by GCC 4.6.0 warnings.
3058
3059 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3060
5fbc2025
PE
3061 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3062 (x_clipboard_manager_save_all): Move extern decl to ...
3063 * xterm.h: ... here, so that it can be checked for consistency.
3064
1dd3c2d9
CY
30652011-05-29 Chong Yidong <cyd@stupidchicken.com>
3066
3067 * xselect.c (x_clipboard_manager_save_frame)
3068 (x_clipboard_manager_save_all): New functions.
3069 (Fx_clipboard_manager_save): Lisp function deleted.
3070
3071 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3072 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3073
3074 * xterm.h: Update prototype.
3075
5ba6571d
WX
30762011-05-28 William Xu <william.xwl@gmail.com>
3077
3078 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3079 exiting (Bug#8239).
3080
3eaff834
JM
30812011-05-28 Jim Meyering <meyering@redhat.com>
3082
e1900994 3083 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3084 * fns.c (to_uchar): Define.
3085 (crypto_hash_function): Use it to convert some newly-signed
3086 variables to unsigned, to avoid sign-extension bugs. For example,
3087 without this change, (md5 "truc") would evaluate to
3088 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3089 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3090 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3091
0f6990a7
PE
30922011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 Integer overflow fixes.
c8a9ca5a 3095
08686060
PE
3096 * dbusbind.c: Serial number integer overflow fixes.
3097 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3098 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3099 to hold a serial number that is too large for a fixnum.
3100 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3101 Check for serial numbers out of range. Decode any serial number
59568bf0 3102 that was so large that it became a float. (Bug#8722)
08686060 3103
2d1fc3c7
PE
3104 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3105 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3106 Use XFASTINT rather than XUINT when numbers are nonnegative.
3107 (xd_append_arg, Fdbus_method_return_internal):
3108 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3109 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3110 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3111 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3112 (Bug#8722)
2d1fc3c7 3113
c8a9ca5a
PE
3114 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3115
519e1d69
PE
3116 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3117
30569699
PE
3118 ccl: add integer overflow checks
3119 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3120 (IN_INT_RANGE): New macros.
3121 (ccl_driver): Use them to check for integer overflow when
3122 decoding a CCL program. Many of the new checks are whether XINT (x)
3123 fits in int; it doesn't always, on 64-bit hosts. The new version
3124 doesn't catch all possible integer overflows, but it's an
847044ea 3125 improvement. (Bug#8719)
30569699 3126
c11285dc
PE
3127 * alloc.c (make_event_array): Use XINT, not XUINT.
3128 There's no need for unsigned here.
3129
fdccd48e
PE
3130 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3131 This follows up to the 2011-05-06 change that substituted uintptr_t
3132 for EMACS_INT. This case wasn't caught back then.
3133
37910ab2
PE
3134 Rework Fformat to avoid integer overflow issues.
3135 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3136 now (part of C89). Include <verify.h>.
3137 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3138 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3139 (Fformat): Avoid the prepass trying to compute sizes; it was only
3140 approximate and thus did not catch overflow reliably. Instead, walk
3141 through the format just once, formatting and computing sizes as we go,
3142 checking for integer overflow at every step, and allocating a larger
3143 buffer as needed. Keep track separately whether the format is
3144 multibyte. Keep only the most-recently calculated precision, rather
3145 than them all. Record whether each argument has been converted to
3146 string. Use EMACS_INT, not int, for byte and char and arg counts.
3147 Support field widths and precisions larger than INT_MAX. Avoid
3148 sprintf's undefined behavior with conversion specifications such as %#d
3149 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3150 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3151 formatting out-of-range floating point numbers with int
9173deec 3152 formats. (Bug#8668)
37910ab2 3153
2e6578fb
PE
3154 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3155
0ae6bdee
PE
3156 * data.c: Avoid integer truncation in expressions involving floats.
3157 * data.c: Include <intprops.h>.
3158 (arith_driver): When there's an integer overflow in an expression
3159 involving floating point, convert the integers to floating point
3160 so that the resulting value does not suffer from catastrophic
3161 integer truncation. For example, on a 64-bit host (* 4
3162 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3163 Do not rely on undefined behavior after integer overflow.
3164
de883a70
PE
3165 merge count_size_as_multibyte, parse_str_to_multibyte
3166 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3167 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3168 Check for integer overflow.
3169 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3170 since it's now a duplicate of the other. This is more of
3171 a character than a buffer op, so better that it's in character.c.
3172 * fns.c, print.c: Adjust to above changes.
3173
2ff916cb
PE
31742011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3175
3176 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3177
f1b54466
PE
31782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3179
fb1ac845
PE
3180 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3181 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3182 (x_clipboard_manager_save): Now static.
3183 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3184
f1b54466
PE
3185 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3186 (crypto_hash_function): Now static.
3187 Fix pointer signedness problems. Avoid unnecessary initializations.
3188
a9f737ee
CY
31892011-05-27 Chong Yidong <cyd@stupidchicken.com>
3190
3191 * termhooks.h (Vselection_alist): Make it terminal-local.
3192
3193 * terminal.c (create_terminal): Initialize it.
3194
3195 * xselect.c: Support for clipboard managers.
3196 (Vselection_alist): Move to termhooks.h as terminal-local var.
3197 (LOCAL_SELECTION): New macro.
3198 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3199 (symbol_to_x_atom): Remove gratuitous arg.
3200 (x_handle_selection_request, lisp_data_to_selection_data)
3201 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3202 (x_own_selection, x_get_local_selection, x_convert_selection):
3203 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3204 (some_frame_on_display): Delete unused function.
3205 (Fx_own_selection_internal, Fx_get_selection_internal)
3206 (Fx_disown_selection_internal, Fx_selection_owner_p)
3207 (Fx_selection_exists_p): New optional frame arg.
3208 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3209 (x_handle_selection_clear): Don't treat other terminals with the
3210 same keyboard specially. Use the terminal-local Vselection_alist.
3211 (x_clear_frame_selections): Use Frun_hook_with_args.
3212
3213 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3214
3215 * xterm.h: Add support for those atoms.
3216
e067f0c1
CY
32172011-05-26 Chong Yidong <cyd@stupidchicken.com>
3218
3219 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3220 (converted_selections, conversion_fail_tag): New global variables.
3221 (x_selection_request_lisp_error): Free the above.
3222 (x_get_local_selection): Remove unnecessary code.
3223 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3224 of converted selections stored in converted_selections.
3225 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3226 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3227 (x_convert_selection): New function.
3228 (x_handle_selection_event): Simplify.
3229 (x_get_foreign_selection): Don't ignore incoming requests while
3230 waiting for an answer; this will fail when we implement
3231 SAVE_TARGETS, and seems unnecessary anyway.
3232 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3233 (Vx_sent_selection_functions): Doc fix.
3234
0f4aebc0
LL
32352011-05-26 Leo Liu <sdl.web@gmail.com>
3236
3237 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3238
e61124cd
YM
32392011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3240
3241 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3242
3243 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3244 for fringe update if it has periodic bitmap.
ac389d0c 3245 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3246 and fringe_bitmap_periodic_p.
3247
3248 * fringe.c (get_fringe_bitmap_data): New function.
3249 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3250 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3251 row. Mark glyph row for fringe update if periodicity changed.
3252
3253 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3254 for fringe update unless it has periodic bitmap.
3255
f16d9837
KH
32562011-05-25 Kenichi Handa <handa@m17n.org>
3257
3258 * xdisp.c (get_next_display_element): Set correct it->face_id for
3259 a static composition.
3260
e1b90ef6
LL
32612011-05-24 Leo Liu <sdl.web@gmail.com>
3262
3263 * deps.mk (fns.o):
3264 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3265
3266 * fns.c (crypto_hash_function, Fsha1): New function.
3267 (Fmd5): Use crypto_hash_function.
3268 (syms_of_fns): Add Ssha1.
3269
7400048f
PE
32702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3271
3272 * gnutls.c: Remove unused macros.
3273 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3274 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3275 Remove macros that are defined and never used.
3276 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3277
abb71cf4
CY
32782011-05-22 Chong Yidong <cyd@stupidchicken.com>
3279
3280 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3281 (Fx_get_selection_internal): Minor cleanup.
3282 (Fx_own_selection_internal): Rename arguments for consistency with
3283 select.el.
3284
6307db39
PE
32852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3286
3287 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3288
f3d4e0a4
CY
32892011-05-22 Chong Yidong <cyd@stupidchicken.com>
3290
3291 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3292
4d8ade89
YM
32932011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3294
3295 * dispnew.c (scrolling_window): Don't exclude the case that the
3296 last enabled row in the desired matrix touches the bottom boundary.
3297
32078c8d
GM
32982011-05-21 Glenn Morris <rgm@gnu.org>
3299
3300 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3301 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3302 and add some more files.
32078c8d 3303
7285dc67
EZ
33042011-05-20 Eli Zaretskii <eliz@gnu.org>
3305
3306 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3307 report_file_error introduced by the change from 2011-05-07.
3308
89d1bd22
PE
33092011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3310
3311 * systime.h (Time): Define only if emacs is defined.
3312 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3313 where the include path doesn't have X11/X.h by default. See
3314 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3315
e23640bb 33162011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3317
3318 * composite.c (find_automatic_composition): Fix previous change.
3319
b9704ad9
GM
33202011-05-20 Glenn Morris <rgm@gnu.org>
3321
3322 * lisp.mk: New file, split from Makefile.in.
3323 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3324 (shortlisp): Remove.
3325 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3326
4a720484
GM
33272011-05-19 Glenn Morris <rgm@gnu.org>
3328
3329 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3330 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3331 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3332 (lisp): Set the order to that of loadup.el.
3333 (shortlisp): Make it a copy of $lisp.
3334 (SOME_MACHINE_LISP): Remove.
3335 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3336 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3337
a28d4396
KH
33382011-05-18 Kenichi Handa <handa@m17n.org>
3339
3340 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3341 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3342 (find_automatic_composition): Mostly rewrite for efficiency.
3343
a2b1fa8e
JB
33442011-05-18 Juanma Barranquero <lekktu@gmail.com>
3345
3346 * makefile.w32-in: Update dependencies.
3347
8e1f5610
CS
33482011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3349
3350 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3351 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3352
7025ee00 33532011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3354
cdfa6eab
PE
3355 Fix some integer overflow issues, such as string length overflow.
3356
06d6db33
PE
3357 * insdel.c (count_size_as_multibyte): Check for string overflow.
3358
2b4560a8
PE
3359 * character.c (lisp_string_width): Check for string overflow.
3360 Use EMACS_INT, not int, for string indexes and lengths; in
3361 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3362 the resulting string length overflows an EMACS_INT; instead,
3363 report a string overflow if no precision given. When checking for
3364 precision exhaustion, use a check that cannot possibly have
3365 integer overflow. (Bug#8675)
3366 * character.h (lisp_string_width): Adjust to new signature.
3367
cb93f9be
PE
3368 * alloc.c (string_overflow): New function.
3369 (Fmake_string): Use it. This doesn't change behavior, but saves
3370 a few bytes and will simplify future changes.
3371 * character.c (string_escape_byte8): Likewise.
3372 * lisp.h (string_overflow): New decl.
3373
1a1f3366
PE
3374 Fixups, following up to the user-interface timestamp change.
3375 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3376 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3377 * msdos.c (mouse_get_pos): Likewise.
3378 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3379 * w32gui.h (Time): Define by including "systime.h" rather than by
3380 declaring it ourselves. (Bug#8664)
3381
d4e3e4d3
PE
3382 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3383 * image.c (clear_image_cache): Likewise.
3384
f6a24d19
PE
3385 * term.c (term_mouse_position): Don't assume time_t wraparound.
3386
08dc5ae6
PE
3387 Be more systematic about user-interface timestamps.
3388 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3389 and sometimes 'EMACS_UINT', to represent these timestamps.
3390 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3391 This makes the code easier to follow, and makes it easier to catch
3392 integer overflow bugs such as Bug#8664.
3393 * frame.c (Fmouse_position, Fmouse_pixel_position):
3394 Use Time, not unsigned long, for user-interface timestamps.
3395 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3396 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3397 * keyboard.h (last_event_timestamp): Likewise.
3398 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3399 * menu.h (xmenu_show): Likewise.
3400 * term.c (term_mouse_position): Likewise.
3401 * termhooks.h (struct input_event.timestamp): Likewise.
3402 (struct terminal.mouse_position_hook): Likewise.
3403 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3404 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3405 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3406 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3407 what it was before.
3408 * menu.h, termhooks.h: Include "systime.h", for Time.
3409
8e55734a
PE
3410 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3411 Don't assume that the difference between two unsigned long values
3412 can fit into an integer. At this point, we know button_down_time
3413 <= event->timestamp, so the difference must be nonnegative, so
3414 there's no need to cast the result if double-click-time is
3415 nonnegative, as it should be; check that it's nonnegative, just in
3416 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3417 apart (about 25 days). (Bug#8664)
8e55734a 3418
841f1b75 3419 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3420 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3421
3e26f69c
PE
3422 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3423 that always fit in int. Use a sentinel instead of a counter, to
3424 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3425 * frame.h (struct frame): Use int for menu_bar_items_used
3426 instead of EMACS_INT, since it always fits in int.
3e26f69c 3427
5cc152c0
PE
3428 * menu.c (grow_menu_items): Check for int overflow.
3429
d89eb65e
PE
3430 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3431
5235bd3e
PE
3432 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3433 Before, the code was not consistent. These values cannot exceed
3434 2**31 - 1 so there's no need to make them unsigned.
3435 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3436 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3437 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3438 as modifiers.
3439 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3440
bc827e23
PE
3441 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3442 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3443 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3444 presumably because the widths might not match.
3445
78eb494e
PE
3446 * window.c (size_window): Avoid needless test at loop start.
3447
04f2d78b
CB
34482011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3449
3450 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3451
d2fc7e3d 34522011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3453
3454 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3455
d2fc7e3d 34562011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3457
3458 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3459 `width' to `bar_area_x' and `bar_area_width', respectively.
3460 (x_scroll_run): Take account of fringe background extension.
3461
04f2d78b
CB
3462 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3463 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3464 `bar_area_width', respectively.
3465 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3466 background extension.
3467
79b70037
GM
34682011-05-10 Jim Meyering <meyering@redhat.com>
3469
3470 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3471
2f142cc5
JB
34722011-05-10 Juanma Barranquero <lekktu@gmail.com>
3473
3474 * image.c (Finit_image_library): Return t for built-in image types,
3475 like pbm and xbm. (Bug#8640)
3476
57679c86
AS
34772011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3478
3479 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3480
888c9e86
EZ
34812011-05-07 Eli Zaretskii <eliz@gnu.org>
3482
b0512a1d
EZ
3483 * w32console.c (Fset_screen_color): Doc fix.
3484 (Fget_screen_color): New function.
3485 (syms_of_ntterm): Defsubr it.
3486
7285dc67
EZ
3487 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3488 unlink the temporary file if Fcall_process didn't create it in the
3489 first place.
3490 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3491 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3492 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3493 cue to call_process_cleanup not to close that handle.
3494
4d3fcc8e
BK
34952011-05-07 Ben Key <bkey76@gmail.com>
3496
3497 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3498 one of two shell specific rules, either bootstrap-temacs-CMD or
3499 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3500 to the previous implementation of the bootstrap-temacs rule.
3501 The bootstrap-temacs-CMD rule is similar to the previous
3502 implementation of the bootstrap-temacs rule except that it
3503 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3504 variable.
3505
3506 These changes, along with some changes to nt/configure.bat,
3507 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3508 earlier fix to add support for --cflags and --ldflags options
3509 that include quotes so that it works whether make uses cmd or
3510 sh as the shell.
3511
b4289b64
MA
35122011-05-06 Michael Albinus <michael.albinus@gmx.de>
3513
3514 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3515 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3516 is a constant.
3517 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3518 a string. Handle both cases.
3519 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3520 (Fdbus_register_method): Use Qinvalid_function.
3521
af4c0e28
JB
35222011-05-06 Juanma Barranquero <lekktu@gmail.com>
3523
3524 * makefile.w32-in: Update dependencies.
3525 (LISP_H): Add inttypes.h and stdin.h.
3526 (PROCESS_H): Add unistd.h.
3527
c51453d9
EZ
35282011-05-06 Eli Zaretskii <eliz@gnu.org>
3529
3530 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3531 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3532
8ff0ac3c 35332011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3534
4c4b566b
PE
3535 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3536
aab2b9b5
PE
3537 * term.c (vfatal): Remove stray call to va_end.
3538 It's not needed and the C Standard doesn't allow it here anyway.
3539
c378da0b
PE
3540 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3541 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3542
288b08c7
PE
3543 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3544 bytes.
3545
e3601888
PE
3546 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3547
db6c0e74
PE
3548 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3549
dd5963ea
PE
3550 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3551
88c9450f
PE
3552 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3553
2f9442b8
PE
3554 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3555
c032b5f8
PE
3556 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3557 * charset.c (Fdefine_charset_internal): Don't initialize
3558 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3559 32-bit int (Bug#8600).
a108c10b
PE
3560
3561 * lread.c (read_integer): Be more consistent with string-to-number.
3562 Use string_to_number to do the actual conversion; this avoids
3563 rounding errors and fixes some other screwups. Without this fix,
3564 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3565 (digit_to_number): Move earlier, for benefit of read_integer.
3566 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3567 not a digit in any supported base. (Bug#8602)
a108c10b 3568
ad5f9eea
PE
3569 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3570
aec1708a
PE
3571 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3572 to match comment at start of function. This also removes a
3573 GCC warning about overflow in a 32+64-bit port.
3574
47be4ab5
PE
3575 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3576
371cac43
PE
3577 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3578 Reported by Stefan Monnier in
3579 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3580 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3581 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3582
d01a7826
PE
3583 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3584 (EMACS_UINTPTR): Likewise, with uintptr_t.
3585
7fd47d5c
PE
3586 * lisp.h: Prefer 64-bit EMACS_INT if available.
3587 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3588 on 32-bit hosts that have 64-bit int, so that they can access
3589 large files.
122b0c86
PE
3590 However, temporarily disable this change unless the temporary
3591 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3592
8727937b
PE
3593 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3594
8ac068ac
PE
3595 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3596 This removes an assumption that EMACS_INT and long are the same
3597 width as pointers. The assumption is true for Emacs porting targets
3598 now, but we want to make other targets possible.
3599 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3600 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3601 In the rest of the code, change types of integers that hold casted
3602 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3603 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3604 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3605 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3606 No need to cast type when ORing.
3607 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3608 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3609 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3610 assume EMACS_INT is the same width as char *.
3611 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3612 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3613 Remove no-longer-needed casts.
3614 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3615 (xg_tool_bar_help_callback, xg_make_tool_item):
3616 Use EMACS_INTPTR to hold an integer
3617 that will be cast to void *; this can avoid a GCC warning
3618 if EMACS_INT is not the same width as void *.
3619 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3620 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3621 (current_message_1, set_message_1):
3622 Use a local to convert to proper width without a cast.
3623 * xmenu.c (dialog_selection_callback): Likewise.
3624
ede49d71
PE
3625 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3626 Also, don't assume VALBITS / RAND_BITS is less than 5,
3627 and don't rely on undefined behavior when shifting a 1 left into
3628 the sign bit.
3629 * lisp.h (get_random): Change signature to match.
3630
2f30ecd0
PE
3631 * lread.c (hash_string): Use size_t, not int, for hash computation.
3632 Normally we prefer signed values; but hashing is special, because
3633 it's better to use unsigned division on hash table sizes so that
3634 the remainder is nonnegative. Also, size_t is the natural width
3635 for hashing into memory. The previous code used 'int', which doesn't
3636 retain enough info to hash well into very large tables.
3637 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3638
2a866e7b
PE
3639 * dbusbind.c: Don't possibly lose pointer info when converting.
3640 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3641 Use XPNTR rather than XHASH, so that the high-order bits of
3642 the pointer aren't lost when converting through void *.
3643
51639eac
PE
3644 * eval.c (Fautoload): Don't double-shift a pointer.
3645
92394119
PE
3646 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3647
dbdb9a7c
JB
36482011-05-06 Juanma Barranquero <lekktu@gmail.com>
3649
3650 * gnutls.c (DEF_GNUTLS_FN):
3651 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3652
db7a0b4f
AS
36532011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3654
3655 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3656 marker. (Bug#8610)
3657
f7ff1b0f 36582011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3659
3660 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3661 New version that can reserve upto 2GB of heap space.
3662
f7ff1b0f 36632011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3664
3665 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3666
639c109b
TZ
36672011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3668
3669 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3670 `gnutls_certificate_set_x509_key_file'.
3671
d2127135
JB
36722011-05-05 Juanma Barranquero <lekktu@gmail.com>
3673
3674 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3675 Update dependencies.
3676
e968f4f3
JB
36772011-05-04 Juanma Barranquero <lekktu@gmail.com>
3678
3679 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3680 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3681 Remove unused parameter `fildes'.
3682 * process.c (read_process_output, send_process): Don't pass it.
3683
84d358f0
JB
36842011-05-04 Juanma Barranquero <lekktu@gmail.com>
3685
3686 Fix previous change: the library cache is defined in w32.c.
3687 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3688 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3689
0898ca10
JB
36902011-05-04 Juanma Barranquero <lekktu@gmail.com>
3691
3692 Implement dynamic loading of GnuTLS on Windows.
3693
3694 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3695 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3696 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3697 Declare.
3698
3699 * gnutls.c (Qgnutls_dll): Define.
3700 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3701 (gnutls_*): Declare function pointers.
3702 (init_gnutls_functions): New function to initialize function pointers.
3703 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3704 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3705 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3706 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3707 (emacs_gnutls_write, emacs_gnutls_read)
3708 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3709 (Fgnutls_available_p): New function.
3710 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3711 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3712 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3713
3714 * image.c: Include w32.h.
3715 (Vimage_type_cache): Delete.
3716 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3717 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3718 (w32_delayed_load): Move to w32.c.
3719
3720 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3721
3722 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3723 (w32_delayed_load): Move from image.c. When loading a library, record
3724 its filename in the :loaded-from property of the library id.
3725 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3726 Initialize and staticpro them.
3727 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3728
3729 * process.c: Include lisp.h before w32.h, not after.
3730 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3731 instead of gnutls_record_check_pending.
3732
3733 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3734
ff4de4aa
TZ
37352011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3736
3737 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3738 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3739 as passed in.
3740
abe95abb
JD
37412011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3742
3743 * xterm.c (x_set_frame_alpha): Do not set property on anything
3744 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3745
e16e55d4
JB
37462011-05-02 Juanma Barranquero <lekktu@gmail.com>
3747
3748 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3749
bafcf6a5
JB
37502011-05-02 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3753 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3754 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3755 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3756 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3757 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3758 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3759 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3760 (Qgnutls_bootprop_callbacks_verify): Make static.
3761
e7a6747f
AS
37622011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3763
19ed11ba
AS
3764 * callproc.c: Indentation fixup.
3765
e7a6747f 3766 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3767 (wait_for_termination, interruptible_wait_for_termination):
3768 Move after wait_for_termination_1.
e7a6747f 3769
1ef14cb4
LMI
37702011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3771
3772 * sysdep.c (interruptible_wait_for_termination): New function
3773 which is like wait_for_termination, but allows keyboard
3774 interruptions.
3775
3776 * callproc.c (Fcall_process): Add (:file "file") as an option for
3777 the STDOUT buffer.
3778 (Fcall_process_region): Ditto.
3779
330d880c
EZ
37802011-04-30 Eli Zaretskii <eliz@gnu.org>
3781
8db90b73
EZ
3782 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3783 rather than `XVECTOR (FOO)->size'.
3784
330d880c
EZ
3785 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3786 inttypes.h, as a gnulib replacement is used if it not available in
3787 system headers.
3788
15cbd324
EZ
37892011-04-21 Eli Zaretskii <eliz@gnu.org>
3790
3791 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3792 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3793 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3794
3795 * coding.c (coding_alloc_by_realloc): Error out if destination
3796 will grow beyond MOST_POSITIVE_FIXNUM.
3797 (decode_coding_emacs_mule): Abort if there isn't enough place in
3798 charbuf for the composition carryover bytes. Reserve an extra
3799 space for up to 2 characters produced in a loop.
3800 (decode_coding_iso_2022): Abort if there isn't enough place in
3801 charbuf for the composition carryover bytes.
3802
38032011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3804
ae940cca
EZ
3805 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3806 aborting when %lld or %lll format is passed.
3807 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3808 %llo or %llx format is passed. (Bug#8545)
3809
03ab8921
EZ
3810 * window.c (window_scroll_line_based): Use a marker instead of
3811 simple variables to record original value of point. (Bug#7952)
3812
afda1437
EZ
3813 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3814 produced by %s or %c overflows available buffer space. (Bug#8545)
3815
f76dee0c
PE
38162011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3817
3818 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3819 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3820
fdc5744d
JB
38212011-04-28 Juanma Barranquero <lekktu@gmail.com>
3822
3823 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3824
638f053a
JB
38252011-04-28 Juanma Barranquero <lekktu@gmail.com>
3826
3827 * keyboard.c (Qdelayed_warnings_hook): Define.
3828 (command_loop_1): Run `delayed-warnings-hook'
3829 if Vdelayed_warnings_list is non-nil.
3830 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3831 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3832
d178f871
EZ
38332011-04-28 Eli Zaretskii <eliz@gnu.org>
3834
3835 * doprnt.c (doprnt): Don't return value smaller than the buffer
3836 size if the message was truncated. (Bug#8545).
3837
b124fd93
JB
38382011-04-28 Juanma Barranquero <lekktu@gmail.com>
3839
3840 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3841 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3842
e810457d
PE
38432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3844
3845 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3846
ea51cceb
JB
38472011-04-27 Juanma Barranquero <lekktu@gmail.com>
3848
3849 * makefile.w32-in: Update dependencies.
3850
94dcfacf
EZ
38512011-04-27 Eli Zaretskii <eliz@gnu.org>
3852
3853 Improve `doprnt' and its usage. (Bug#8545)
3854 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3855 `format_end'. Remove support for %l as a conversion specifier.
3856 Don't use xrealloc. Improve diagnostics when the %l size modifier
3857 is used. Update the commentary.
3858
3859 * eval.c (verror): Simplify calculation of size_t.
3860
3861 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3862 messages.
3863
f61f41d7
PE
38642011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3865
3866 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3867 change.
3868
96fb4434
PE
38692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3870
3871 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3872 This makes this file independent of the recent pseudovector change.
3873
671875da 38742011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3875
69e9b5a3
PE
3876 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3877
b5f869a7 3878 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3879 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3880 Remove unused local.
c8926152 3881 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3882
841a1577 3883 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3884 GCC 4.6.0 optimizes based on type-based alias analysis.
3885 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3886 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3887 != &v->size, and therefore "v->size = 1; b->size = 2; return
3888 v->size;" must therefore return 1. This assumption is incorrect
3889 for Emacs, since it type-puns struct Lisp_Vector * with many other
3890 types. To fix this problem, this patch adds a new type struct
f904488f 3891 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3892 and pseudovectors, and helps optimizing compilers not get fooled
3893 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3894 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3895 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3896 the size member.
eab3844f
PE
3897 (XSETPVECTYPE): Rewrite in terms of new macro.
3898 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3899 This is a bit clearer, and further avoids the possibility of
3900 undesirable aliasing.
3901 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3902 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3903 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3904 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3905 (ASIZE): Now uses header.size rather than size.
3906 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3907 to avoid the hassle of writing XVECTOR (foo)->header.size.
3908 (struct vectorlike_header): New type.
eab3844f
PE
3909 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3910 object, to help avoid aliasing.
3911 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3912 (SUBRP): Likewise, since Lisp_Subr is a special case.
3913 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3914 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3915 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3916 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3917 changed to be "header.size" and "header.next".
3918 * buffer.h (struct buffer): Likewise.
3919 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3920 * frame.h (struct frame): Likewise.
3921 * process.h (struct Lisp_Process): Likewise.
3922 * termhooks.h (struct terminal): Likewise.
3923 * window.c (struct save_window_data, struct saved_window): Likewise.
3924 * window.h (struct window): Likewise.
3925 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3926 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3927 * buffer.c (init_buffer_once): Likewise.
3928 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3929 special case.
3930 * process.c (Fformat_network_address): Use local var for size,
3931 for brevity.
3932
0df1eac5
PE
3933 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3934
847ab9d1 3935 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3936 * data.c (atof): Remove decl; no longer used or needed.
3937 (digit_to_number): Move to lread.c.
3938 (Fstring_to_number): Use new string_to_number function, to be
3939 consistent with how the Lisp reader treats infinities and NaNs.
3940 Do not assume that floating-point numbers represent EMACS_INT
3941 without losing information; this is not true on most 64-bit hosts.
3942 Avoid double-rounding errors, by insisting on integers when
3943 parsing non-base-10 numbers, as the documentation specifies.
3944 * lisp.h (string_to_number): New decl, replacing ...
3945 (isfloat_string): Remove.
bc0a5c13 3946 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3947 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3948 appears to have been a coding error. Similarly, do not accept
3949 strings like +-1e0 as floating point numbers. Do not report
3950 overflow for integer overflows unless the base is not 10 which
3951 means we have no simple and reliable way to continue.
3952 Break out the floating-point parsing into a new
3953 function string_to_number, so that Fstring_to_number parses
3954 floating point numbers consistently with the Lisp reader.
04f2d78b 3955 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3956 (E_CHAR, EXP_INT): Remove, replacing with ...
3957 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3958 (string_to_number): New function, replacing isfloat_string.
3959 This function checks for valid syntax and produces the resulting
3960 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3961 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3962 so that overflow for non-base-10 numbers is reported only when
3963 there's no portable and simple way to convert to floating point.
452f4150 3964
67769ffc
PE
3965 * textprop.c (set_text_properties_1): Rewrite for clarity,
3966 and to avoid GCC warning about integer overflow.
3967
c20db43f
PE
3968 * intervals.h (struct interval): Use EMACS_INT for members
3969 where EMACS_UINT might cause problems. See
3970 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3971 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3972 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3973 All uses changed.
37aa2f85
PE
3974 (offset_intervals): Tell GCC not to worry about length overflow
3975 when negating a negative length.
c20db43f 3976
2538aa2f
PE
3977 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3978 (overrun_check_free): Likewise.
3979
f2d3008d
PE
3980 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3981 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3982 word size.
3983
ec8df744
PE
3984 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3985 (gnutls_make_error): Rename local to avoid shadowing.
3986 (gnutls_emacs_global_deinit): ifdef out; not used.
3987 (Fgnutls_boot): Use const for pointer to readonly storage.
3988 Comment out unused local. Fix pointer signedness problems.
3989
640ee02d
PE
3990 * lread.c (openp): Don't stuff size_t into an 'int'.
3991 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3992 about possible signed overflow.
3993
6048fb2a
PE
3994 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3995 (GDK_KEY_g): Don't define if already defined.
3996 (xg_prepare_tooltip): Avoid pointer signedness problem.
3997 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3998
fa3c87e1
PE
3999 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4000 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4001
2172544b
PE
4002 * xfns.c (Fx_window_property): Simplify a bit,
4003 to make a bit faster and to avoid GCC 4.6.0 warning.
4004 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4005
9b821a21
PE
4006 * fns.c (internal_equal): Don't assume size_t fits in int.
4007
3c616cfa
PE
4008 * alloc.c (compact_small_strings): Tighten assertion a little.
4009
c2982e87
PE
4010 Replace pEd with more-general pI, and fix some printf arg casts.
4011 * lisp.h (pI): New macro, generalizing old pEd macro to other
4012 conversion specifiers. For example, use "...%"pI"d..." rather
4013 than "...%"pEd"...".
4014 (pEd): Remove. All uses replaced with similar uses of pI.
4015 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4016 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4017 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4018 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4019 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4020 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4021 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4022 64-bit hosts.
4023 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4024 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4025 * print.c (safe_debug_print, print_object): Likewise.
4026 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4027 to int.
6f04d126
PE
4028 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4029 avoiding the 0 flag, which is not portable.
c2982e87
PE
4030 * process.c (Fmake_network_process): Use pI to avoid cast.
4031 * region-cache.c (pp_cache): Likewise.
4032 * xdisp.c (decode_mode_spec): Likewise.
4033 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4034 behavior on 64-bit hosts with printf arg.
6f04d126 4035 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4036 (x_stop_queuing_selection_requests): Likewise.
4037 (x_get_window_property): Don't truncate byte count to an 'int'
4038 when tracing.
0b432f21 4039
5e073ec7
PE
4040 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4041 here, since it parses constructs like leading '-' and spaces,
4042 which are not wanted; and it overflows with large numbers.
4043 Instead, simply match F[0-9]+, which is what is wanted anyway.
4044
36372bf9
PE
4045 * alloc.c: Remove unportable assumptions about struct layout.
4046 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4047 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4048 (allocate_vectorlike, make_pure_vector): Use the new macros,
4049 plus offsetof, to remove unportable assumptions about struct layout.
4050 These assumptions hold on all porting targets that I know of, but
4051 they are not guaranteed, they're easy to remove, and removing them
4052 makes further changes easier.
4053
0b432f21
PE
4054 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4055 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4056 (string_overrun_cookie): Now const. Use initializers that
4057 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4058 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4059 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4060 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4061 multiple of sizeof (EMACS_INT); it need not be, if
4062 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4063 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4064
895009e1
JB
40652011-04-26 Juanma Barranquero <lekktu@gmail.com>
4066
4067 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4068
6a7a1b0b
TZ
40692011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4070
4071 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4072 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4073 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4074
841a1577 40752011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4076
4077 * lisp.h (Qdebug): List symbol.
895009e1 4078 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4079 * keyboard.c (debug-on-event): New variable.
4080 (handle_user_signal): Break into debugger when debug-on-event
4081 matches the current signal symbol.
4082
f2d3ba6f
DN
40832011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4084
4085 * alloc.c (check_sblock, check_string_bytes)
4086 (check_string_free_list): Convert to standard C.
4087
42ce4c63
TZ
40882011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4089
4090 * w32.c (emacs_gnutls_push): Fix typo.
4091
825cd63c
EZ
40922011-04-25 Eli Zaretskii <eliz@gnu.org>
4093
fb11d64d
EZ
4094 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4095 "cast to pointer from integer of different size".
4096
825cd63c
EZ
4097 Improve doprnt and its use in verror. (Bug#8545)
4098 * doprnt.c (doprnt): Document the set of format control sequences
4099 supported by the function. Use SAFE_ALLOCA instead of always
4100 using `alloca'.
4101
4102 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4103 is one byte too soon. Don't use xrealloc; instead xfree and
4104 xmalloc anew.
4105
e061a11b
TZ
41062011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4107
4108 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4109 callbacks stage.
4110
4111 * gnutls.c: Renamed global_initialized to
4112 gnutls_global_initialized. Added internals for the
4113 :verify-hostname-error, :verify-error, and :verify-flags
4114 parameters of `gnutls-boot' and documented those parameters in the
4115 docstring. Start callback support.
9173deec
JB
4116 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4117 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4118 on error. Return error code.
e061a11b
TZ
4119 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4120 (emacs_gnutls_read): Likewise.
4121 (Fgnutls_boot): Return handshake error code.
4122 (emacs_gnutls_handle_error): New function.
4123 (wsaerror_to_errno): Likewise.
4124
4125 * w32.h (emacs_gnutls_pull): Add prototype.
4126 (emacs_gnutls_push): Likewise.
4127
4128 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4129 (emacs_gnutls_push): Likewise.
4130
41312011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4132
4133 * process.c (wait_reading_process_output): Check if GnuTLS
4134 buffered some data internally if no FDs are set for TLS
4135 connections.
4136
4137 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4138 (LIBS): Link to USER_LIBS.
4139 ($(BLD)/gnutls.$(0)): New target.
4140
fa6996bc
EZ
41412011-04-24 Eli Zaretskii <eliz@gnu.org>
4142
eb35682e
EZ
4143 * xdisp.c (handle_single_display_spec): Rename the
4144 display_replaced_before_p argument into display_replaced_p, to
4145 make it consistent with the commentary. Fix typos in the
4146 commentary.
4147
e2ad650c
EZ
4148 * textprop.c (syms_of_textprop): Remove dead code.
4149 (copy_text_properties): Delete obsolete commentary about an
4150 interface that was deleted long ago. Fix typos in the description
4151 of arguments.
4152
1b2de274
EZ
4153 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4154 to changes in oldXMenu/XMenu.h from 2011-04-16.
4155 <menu_help_message, prev_menu_help_message>: Constify.
4156 (IT_menu_make_room): menu->help_text is now `const char **';
4157 adjust.
4158
4159 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4160 to changes in oldXMenu/XMenu.h from 2011-04-16.
4161 (struct XMenu): Declare `help_text' `const char **'.
4162
4163 * xfaces.c <Qunspecified>: Make extern again.
4164
4165 * syntax.c: Include sys/types.h before including regex.h, as
4166 required by Posix.
4167
762b15be
EZ
4168 * doc.c (get_doc_string): Improve the format passed to `error'.
4169
4170 * doprnt.c (doprnt): Improve commentary.
4171
4172 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4173
4174 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4175 them with etags.
4176
f1052e5d
EZ
4177 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4178 changes in globals.h immediately force recompilation.
762b15be
EZ
4179 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4180 $(CURDIR)/s/ms-w32.h.
4181 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4182
fa6996bc
EZ
4183 * character.c (Fchar_direction): Function deleted.
4184 (syms_of_character): Don't defsubr it.
4185 <char-direction-table>: Deleted.
4186
e6c3da20
EZ
41872011-04-23 Eli Zaretskii <eliz@gnu.org>
4188
4189 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4190 * doprnt.c: Include limits.h.
4191 (SIZE_MAX): New macro.
04f2d78b
CB
4192 (doprnt): Return a size_t value. 2nd arg is now size_t.
4193 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4194 Improve overflow protection. Support `l' modifier for integer
4195 conversions. Support %l conversion. Don't assume an EMACS_INT
4196 argument for integer conversions and for %c.
4197
4198 * lisp.h (doprnt): Restore prototype.
4199
4200 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4201 $(SRC)/character.h.
4202
4203 * Makefile.in (base_obj): Add back doprnt.o.
4204
4205 * deps.mk (doprnt.o): Add back prerequisites.
4206 (callint.o): Depend on character.h.
4207
4208 * eval.c (internal_lisp_condition_case): Include the handler
4209 representation in the error message.
4210 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4211 when breaking from the loop.
4212
4213 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4214
4215 * callint.c (Fcall_interactively): When displaying error message
4216 about invalid control letter, pass the character's codepoint, not
4217 a pointer to its multibyte form. Improve display of the character
4218 in octal and display also its hex code.
4219
4220 * character.c (char_string): Use %x to display the (unsigned)
4221 codepoint of an invalid character, to avoid displaying a bogus
4222 negative value.
4223
4224 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4225 `error', not SYMBOL_NAME itself.
4226
4227 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4228 character arguments to `error'.
4229
4230 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4231 to `error' in error message about FINAL_CHAR argument. Make sure
4232 FINAL_CHAR is a character, and use %c when it is passed as
4233 argument to `error'.
4234
4ffd0d6b 42352011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4236
4237 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4238
4239 * w32.c: Include <time.h>.
4240 (sys_localtime): New function.
4241
4ffd0d6b 42422011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4243
4244 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4245
4ffd0d6b 4246 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4247
4ffd0d6b 42482011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4249
4ffd0d6b
GM
4250 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4251 zombies (Bug#8467).
aac0c6e3 4252
04c56954
EZ
42532011-04-19 Eli Zaretskii <eliz@gnu.org>
4254
4255 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4256 gl_state.e_property when gl_state.object is Qt.
4257
4258 * insdel.c (make_gap_larger): Remove limitation of buffer size
4259 to <= INT_MAX.
4260
16a43933
CY
42612011-04-18 Chong Yidong <cyd@stupidchicken.com>
4262
4263 * xdisp.c (lookup_glyphless_char_display)
4264 (produce_glyphless_glyph): Handle cons cell entry in
4265 glyphless-char-display.
4266 (Vglyphless_char_display): Document it.
4267
4268 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4269 glyphless-char-display.
4270
4581706e
CY
42712011-04-17 Chong Yidong <cyd@stupidchicken.com>
4272
4273 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4274
4275 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4276
4277 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4278 definition for no-X builds.
4279
4887c6e2 42802011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4281
fd35b6f9
PE
4282 Static checks with GCC 4.6.0 and non-default toolkits.
4283
5c1ccb01
PE
4284 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4285
006c5daa
PE
4286 * process.c (keyboard_bit_set): Define only if SIGIO.
4287 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4288 (send_process): Repair possible setjmp clobbering.
4289
efc736d3
PE
4290 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4291
4e2fe2e6
PE
4292 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4293
f97334a2
PE
4294 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4295
4e75f29d
PE
4296 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4297 Define only if needed.
4298
90efadd1
PE
4299 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4300 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4301 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4302
3c647824
PE
4303 * dispextern.h (struct redisplay_interface): Rename param
4304 to avoid shadowing.
e264f262 4305 * termhooks.h (struct terminal): Likewise.
761383f4 4306 * xterm.c (xembed_send_message): Likewise.
3c647824 4307
b58c5c4a
PE
4308 * insdel.c (make_gap_smaller): Define only if
4309 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4310
cad59032
PE
4311 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4312 it.
4313
c339dc2e
PE
4314 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4315 so that we aren't warned about unused symbols.
4316
91a3e27b
PE
4317 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4318
399c71d3 4319 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4320
8ffc96f5
PE
4321 * xfns.c (x_real_positions): Mark locals as initialized.
4322
eef9bc79
PE
4323 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4324
098db9dd
PE
4325 * xterm.c: Fix problems found by static analysis with other toolkits.
4326 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4327 (x_dispatch_event): Declare static if USE_GTK, and
4328 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4329 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4330 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4331 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4332 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4333
eb18f6cc
PE
4334 * xmenu.c (menu_help_callback): Pointer type fixes.
4335 Use const pointers when pointing at readonly data. Avoid pointer
4336 signedness clashes.
4337 (FALSE): Remove unused macro.
4338 (update_frame_menubar): Remove unused decl.
4339
1fe72bf8
PE
4340 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4341
60d9e1db
PE
4342 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4343 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4344 (single_menu_item): Rename local to avoid shadowing.
4345
39261c26
PE
4346 * keyboard.c (make_lispy_event): Remove unused local var.
4347
018c5e19
PE
4348 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4349 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4350
63d2b86e
PE
4351 * bitmaps: Change bitmaps from unsigned char back to the X11
4352 compatible char. Avoid the old compiler warnings about
4353 out-of-range initializers by using, for example, '\xab' rather
4354 than 0xab.
4355
aefd87e1
PE
4356 * xgselect.c (xgselect_initialize): Check vs interface
4357 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4358
bf501fb9
PE
4359 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4360
e9829fdf
PE
4361 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4362 to read-only memory.
4363
1086c095
PE
4364 * fns.c (vector): Remove; this old hack is no longer needed.
4365
2baccd04 4366 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4367 Remove unused var.
dde42981 4368 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4369
72391843 4370 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4371
436c16df 4372 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4373 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4374 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4375
92bb796d 4376 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4377 (x_term_init): Remove local to avoid shadowing.
92bb796d 4378
764430a3 4379 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4380
4381 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4382 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4383
d1dfb56c
EZ
43842011-04-16 Eli Zaretskii <eliz@gnu.org>
4385
c4354cb4
EZ
4386 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4387
d1dfb56c
EZ
4388 Fix regex.c, syntax.c and friends for buffers > 2GB.
4389 * syntax.h (struct gl_state_s): Declare character position members
4390 EMACS_INT.
4391
4392 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4393
04f2d78b
CB
4394 * textprop.c (verify_interval_modification, interval_of):
4395 Declare arguments EMACS_INT.
d1dfb56c
EZ
4396
4397 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4398 EMACS_INT.
4399
4400 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4401
4402 * indent.c (Fvertical_motion): Local variable it_start is now
4403 EMACS_INT.
4404
4405 * regex.c (re_match, re_match_2, re_match_2_internal)
4406 (bcmp_translate, regcomp, regexec, print_double_string)
4407 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4408 (re_compile_pattern, re_exec): Declare arguments and local
4409 variables `size_t' and `ssize_t' and return values `regoff_t', as
4410 appropriate.
4411 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4412 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4413 <compile_stack_type>: `size' and `avail' are now `size_t'.
4414
4415 * regex.h <regoff_t>: Use ssize_t, not int.
4416 (re_search, re_search_2, re_match, re_match_2): Arguments that
4417 specify buffer/string position and length are now ssize_t and
4418 size_t. Return type is regoff_t.
4419
613052cd
BK
44202011-04-16 Ben Key <bkey76@gmail.com>
4421
4422 * nsfont.m: Fixed bugs in ns_get_family and
4423 ns_descriptor_to_entity that were caused by using free to
4424 deallocate memory blocks that were allocated by xmalloc (via
4425 xstrdup). This caused Emacs to crash when compiled with
4426 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4427 --enable-checking=xmallocoverrun). xfree is now used to
4428 deallocate these memory blocks.
4429
4170f62f 44302011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4431
71b41406
PE
4432 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4433
9587a89d
PE
4434 emacs_write: Accept and return EMACS_INT for sizes.
4435 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4436 et seq.
4437 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4438 Accept and return EMACS_INT.
4439 (emacs_gnutls_write): Return the number of bytes written on
4440 partial writes.
4441 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4442 (emacs_read, emacs_write): Remove check for negative size, as the
4443 Emacs source code has been audited now.
9587a89d
PE
4444 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4445 (emacs_read, emacs_write): Use it.
273a5f82
PE
4446 * process.c (send_process): Adjust to the new signatures of
4447 emacs_write and emacs_gnutls_write. Do not attempt to store
4448 a byte offset into an 'int'; it might overflow.
9587a89d 4449 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4450
3e047f51
PE
4451 * sound.c: Don't assume sizes fit in 'int'.
4452 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4453 Return EMACS_INT, not int.
3e047f51 4454 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4455 Accept EMACS_INT, not int.
4456 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4457 record read return values.
4458
cc39a9db
BK
44592011-04-15 Ben Key <bkey76@gmail.com>
4460
c9d0ec6d
JB
4461 * keyboard.c (Qundefined): Don't declare static since it is used
4462 in nsfns.m.
4463 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4464 static since they are used in nsfont.m.
cc39a9db 4465
6c60eb9f
SM
44662011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4467
4468 * process.c (Qprocessp): Don't declare static.
4469 * lisp.h (Qprocessp): Declare again.
4470
7990b61a
JB
44712011-04-15 Juanma Barranquero <lekktu@gmail.com>
4472
4473 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4474
5d4cb038
PE
44752011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4476
8bd7b830 4477 Improve C-level modularity by making more things 'static'.
cd64ea1d 4478
e3b27b31
PE
4479 Don't publish debugger-only interfaces to other modules.
4480 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4481 (verify_bytepos, count_markers): Move decls to the only modules
4482 that need them.
4483 * region-cache.h (pp_cache): Likewise.
4484 * window.h (check_all_windows): Likewise.
4485 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4486
5d4cb038
PE
4487 * sysdep.c (croak): Now static, if
4488 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4489 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4490
4491 * alloc.c (refill_memory_reserve): Now static if
4492 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4493 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4494
e87b6180
PE
4495 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4496 Define only if USE_LUCID.
4497
ac64929e
PE
4498 * xrdb.c (x_customization_string, x_rm_string): Now static.
4499
6f37259d
PE
4500 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4501 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4502
1683e3ab
PE
4503 * xdisp.c (draw_row_with_mouse_face): Now static.
4504 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4505
de9c2632
PE
4506 * window.h (check_all_windows): Mark externally visible.
4507
2b96acb7
PE
4508 * window.c (window_deletion_count): Now static.
4509
4510 * undo.c: Make symbols static if they're not exported.
4511 (last_undo_buffer, last_boundary_position, pending_boundary):
4512 Now static.
4513
50436f33
PE
4514 * textprop.c (interval_insert_behind_hooks): Now static.
4515 (interval_insert_in_front_hooks): Likewise.
4516
64520e5c
PE
4517 * term.c: Make symbols static if they're not exported.
4518 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4519 (max_frame_lines, tty_set_terminal_modes):
4520 (tty_reset_terminal_modes, tty_turn_off_highlight):
4521 (get_tty_terminal): Now static.
4522 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4523 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4524 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4525 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4526 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4527
1fa53021
PE
4528 * sysdep.c: Make symbols static if they're not exported.
4529 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4530 Now static.
4531 (sigprocmask_set, full_mask): Remove; unused.
4532 (wait_debugging): Mark as visible.
4533 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4534 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4535
d4b43b22
PE
4536 * syntax.c (syntax_temp): Define only if !__GNUC__.
4537
b7c513d0
PE
4538 * sound.c (current_sound_device, current_sound): Now static.
4539
989b29ad
PE
4540 * search.c (searchbufs, searchbuf_head): Now static.
4541
13a55a78
PE
4542 * scroll.c (scroll_cost): Remove; unused.
4543 * dispextern.h (scroll_cost): Remove decl.
4544
de68a1fc
PE
4545 * region-cache.h (pp_cache): Mark as externally visible.
4546
40ccffa6
PE
4547 * process.c: Make symbols static if they're not exported.
4548 (process_tick, update_tick, create_process, chan_process):
4549 (Vprocess_alist, proc_buffered_char, datagram_access):
4550 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4551 (deactivate_process): Mark defn as static, as well as decl.
4552 * lisp.h (create_process): Remove decl.
4553 * process.h (chan_process, Vprocess_alist): Remove decls.
4554
ad64fc97
PE
4555 * print.c: Make symbols static if they're not exported.
4556 (print_depth, new_backquote_output, being_printed, print_buffer):
4557 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4558 (print_interval, print_number_index, initial_stderr_stream):
4559 Now static.
4560 * lisp.h (Fprinc): Remove decl.
4561 (debug_output_compilation_hack): Mark as externally visible.
4562
adddb265
PE
4563 * sysdep.c (croak): Move decl from here to syssignal.h.
4564 * syssignal.h (croak): Put it here, so the API can be checked when
4565 'croak' is called from dissociate_if_controlling_tty.
4566
1717ede2
PE
4567 * minibuf.c: Make symbols static if they're not exported.
4568 (minibuf_save_list, choose_minibuf_frame): Now static.
4569 * lisp.h (choose_minibuf_frame): Remove decl.
4570
fa5fb2bc
PE
4571 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4572
1e3890d1
PE
4573 * lread.c: Make symbols static if they're not exported.
4574 (read_objects, initial_obarray, oblookup_last_bucket_number):
4575 Now static.
4576 (make_symbol): Remove; unused.
4577 * lisp.h (initial_obarray, make_symbol): Remove decls.
4578
8a1414fa
PE
4579 * keyboard.c: Make symbols static if they're not exported.
4580 (single_kboard, recent_keys_index, total_keys, recent_keys):
4581 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4582 (this_single_command_key_start, echoing, last_auto_save):
4583 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4584 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4585 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4586 (Vlispy_mouse_stem, double_click_count):
4587 Now static.
4588 (force_auto_save_soon): Define only if SIGDANGER.
4589 (ignore_mouse_drag_p): Now static if
4590 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4591 (print_help): Remove; unused.
4592 (stop_character, last_timer_event): Mark as externally visible.
4593 * keyboard.h (ignore_mouse_drag_p): Declare only if
4594 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4595 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4596 * lisp.h (echoing): Remove decl.
4597 (force_auto_save_soon): Declare only if SIGDANGER.
4598 * xdisp.c (redisplay_window): Simplify code, to make it more
4599 obvious that ignore_mouse_drag_p is not accessed if !defined
4600 USE_GTK && !defined HAVE_NS.
4601
93ea6e8f
PE
4602 * intervals.c: Make symbols static if they're not exported.
4603 (merge_properties_sticky, merge_interval_right, delete_interval):
4604 Now static.
4605 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4606
77382fcc
PE
4607 * insdel.c: Make symbols static if they're not exported.
4608 However, leave prepare_to_modify_buffer alone. It's never
4609 called from outside this function, but that appears to be a bug.
4610 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4611 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4612 (adjust_after_replace_noundo): Remove; unused.
4613 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4614 (signal_before_change): Remove decls.
77382fcc 4615
9306c32e
PE
4616 * indent.c (val_compute_motion, val_vmotion): Now static.
4617
cd44d2eb
PE
4618 * image.c: Make symbols static if they're not exported.
4619 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4620 if USE_GTK.
4621 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4622 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4623
ad9a7a06
PE
4624 * fringe.c (standard_bitmaps): Now static.
4625 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4626
81626931
PE
4627 * frame.c: Make symbols static if they're not exported.
4628 (x_report_frame_params, make_terminal_frame): Now static.
4629 (get_frame_param): Now static, unless HAVE_NS.
4630 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4631 (x_get_resource_string): Remove; not used.
4632 * frame.h (make_terminal_frame, x_report_frame_params):
4633 (x_get_resource_string); Remove decls.
4634 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4635 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4636
239f9db9
PE
4637 * font.c, fontset.c: Make symbols static if they're not exported.
4638 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4639 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4640 * font.c (font_close_object): Now static.
4641 * font.h (font_close_object): Remove.
4642 * fontset.c (FONTSET_OBJLIST): Remove.
4643 (free_realized_fontset) #if-0 the body, which does nothing.
4644 (face_suitable_for_char_p): #if-0, as it's never called.
4645 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4646 * xfaces.c (face_at_string_position):
4647 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4648 since 0 is always ASCII.
4649
dfcf3579
PE
4650 * fns.c (weak_hash_tables): Now static.
4651
5045092b
PE
4652 * fileio.c: Make symbols static if they're not exported.
4653 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4654 (Vwrite_region_annotation_buffers): Now static.
4655
57a96f5c
PE
4656 * eval.c: Make symbols static if they're not exported.
4657 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4658 * lisp.h (backtrace_list): Remove decl.
4659
35f08c38
PE
4660 * emacs.c: Make symbols static if they're not exported.
4661 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4662 (fatal_error_code, fatal_error_signal_hook, standard_args):
4663 Now static.
4664 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4665 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4666 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4667 * lisp.h (fatal_error_signal_hook): Remove decl.
4668 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4669
f44bd759
PE
4670 * editfns.c: Move a (normally-unused) function to its only use.
4671 * editfns.c, lisp.h (get_operating_system_release): Remove.
4672 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4673 worth the hassle of breaking this out.
4674
b532497d
PE
4675 * xterm.c: Make symbols static if they're not exported.
4676 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4677 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4678 (x_destroy_window, x_delete_display):
4679 Now static.
4680 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4681 (x_mouse_leave): Remove; unused.
4682 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4683 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4684 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4685 Remove decls.
4686 (x_mouse_leave): Declare only if WINDOWSNT.
4687 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4688 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4689 USE_X_TOOLKIT.
4690
1675728f
PE
4691 * ftxfont.c: Make symbols static if they're not exported.
4692 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4693 HAVE_FREETYPE.
4694 * font.h (ftxfont_driver): Likewise.
4695
e4cebfca
PE
4696 * xfns.c: Make symbols static if they're not exported.
4697 (x_last_font_name, x_display_info_for_name):
4698 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4699 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4700 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4701 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4702 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4703 (last_show_tip_args): Now static.
4704 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4705 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4706 (x_screen_planes): Remove; unused.
4707 * dispextern.h (x_screen_planes): Remove decl.
4708
5bf46f05
PE
4709 * dispnew.c: Make symbols static if they're not exported.
4710 * dispextern.h (redraw_garbaged_frames, scrolling):
4711 (increment_row_positions): Remove.
4712 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4713 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4714 Now static.
4715 (redraw_garbaged_frames): Remove; unused.
4716
435f4c28
PE
4717 * xfaces.c: Make symbols static if they're not exported.
4718 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4719 Remove decls.
4720 * xterm.h (defined_color): Remove decls.
4721 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4722 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4723 (menu_face_changed_default, defined_color, free_realized_face):
4724 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4725 (ascii_face_of_lisp_face): Remove; unused.
4726
8524aef3
PE
4727 * xdisp.c: Make symbols static if they're not exported.
4728 * dispextern.h (scratch_glyph_row, window_box_edges):
4729 (glyph_to_pixel_coords, set_cursor_from_row):
4730 (get_next_display_element, set_iterator_to_next):
4731 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4732 (show_mouse_face): Remove decls
4733 * frame.h (message_buf_print): Likewise.
4734 * lisp.h (pop_message, set_message, check_point_in_composition):
4735 Likewise.
4736 * xterm.h (set_vertical_scroll_bar): Likewise.
4737 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4738 (message_buf_print, scratch_glyph_row, displayed_buffer):
4739 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4740 (get_next_display_element, show_mouse_face, window_box_edges):
4741 (frame_to_window_pixel_xy, check_point_in_composition):
4742 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4743 (glyph_to_pixel_coords): Remove; unused.
4744
16390cd2
PE
4745 * dired.c (file_name_completion): Now static.
4746
4747 * dbusbind.c (xd_in_read_queued_messages): Now static.
4748
a25f4dfa
PE
4749 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4750 * data.c (circular_list_error): Remove.
4751
14a9c8df
PE
4752 * commands.h (last_point_position, last_point_position_buffer):
4753 (last_point_position_window): Remove decls.
4754 * keyboard.c: Make these variables static.
4755
04f2d78b
CB
4756 * coding.h (coding, code_convert_region, encode_coding_gap):
4757 Remove decls.
74ab6df5
PE
4758 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4759 (iso_code_class, detect_coding, code_convert_region): Now static.
4760 (encode_coding_gap): Remove; unused.
4761
38dfbee1
PE
4762 * chartab.c (chartab_chars, chartab_bits): Now static.
4763
a2cb4e63
PE
4764 * charset.h (charset_iso_8859_1): Remove decl.
4765 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4766 Now static.
4767
127198fd
PE
4768 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4769 * ccl.c (Vccl_program_table): Now static.
4770 (check_ccl_update): Remove; unused.
4771
d85b608f
PE
4772 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4773 * category.h: ... from here.
4774 * category.c (check_category_table, set_category_set): Now static.
4775
31cd66f3
PE
4776 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4777 * lisp.h: Remove these decls.
4778
c358e587
PE
4779 * buffer.c (buffer_count): Remove unused var.
4780
e78aecca
PE
4781 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4782 so that it's not optimized away.
4783 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4784 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4785 exported only to the debugger.
4786
e192d7d3 4787 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4788 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4789
92470028
PE
4790 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4791 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4792 was inaccessible from Lisp.
4793 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4794 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4795
244ed907
PE
4796 alloc.c: Import and export fewer symbols, and remove unused items.
4797 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4798 is defined.
4799 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4800 it's not optimized away by whole-program optimization.
4801 (message_enable_multibyte, free_misc): Remove.
4802 (catchlist, handlerlist, mark_backtrace):
4803 Declare only if BYTE_MARK_STACK.
4804 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4805 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4806 (message_enable_multibyte): Remove decl.
4807 (free_misc, interval_free_list, float_block, float_block_index):
4808 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4809 (cons_free_list, last_marked_index):
4810 Now static.
4811 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4812 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4813 (mark_backtrace): Define only if BYTE_MARK_STACK.
4814 * xdisp.c (message_enable_multibyte): Now static.
4815
61c2b50e 4816 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4817 This makes it easier for human readers (and static analyzers)
4818 to see whether these variables are used from other modules.
4819 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4820 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4821 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4822 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4823 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4824 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4825 * xmenu.c, xselect.c:
4826 Declare Q* vars static if they are not used in other modules.
4827 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4828 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4829 Remove decls of unexported vars.
4830 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4831
95c82688
PE
4832 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4833
16a97296
PE
4834 Make Emacs functions such as Fatom 'static' by default.
4835 This makes it easier for human readers (and static analyzers)
4836 to see whether these functions can be called from other modules.
4837 DEFUN now defines a static function. To make the function external
4838 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4839 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4840 (Finit_image_library):
16a97296
PE
4841 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4842 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4843 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4844 Remove decls, since these functions are now static.
4845 (Funintern, Fget_internal_run_time): New decls, since these functions
4846 were already external.
95c82688 4847
16a97296
PE
4848 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4849 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4850 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4851 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4852 * keyboard.c, keymap.c, lread.c:
4853 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4854 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4855 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4856 Mark functions with DEFUE instead of DEFUN,
4857 if they are used in other modules.
4858 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4859 decls for now-static functions.
4860 * buffer.h (Fdelete_overlay): Remove decl.
4861 * callproc.c (Fgetenv_internal): Mark as internal.
4862 * composite.c (Fremove_list_of_text_properties): Remove decl.
4863 (Fcomposition_get_gstring): New forward static decl.
4864 * composite.h (Fcomposite_get_gstring): Remove decl.
4865 * dired.c (Ffile_attributes): New forward static decl.
4866 * doc.c (Fdocumntation_property): New forward static decl.
4867 * eval.c (Ffetch_bytecode): New forward static decl.
4868 (Funintern): Remove extern decl; now in .h file where it belongs.
4869 * fileio.c (Fmake_symbolic_link): New forward static decl.
4870 * image.c (Finit_image_library): New forward static decl.
4871 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4872 * intervals.h (Fprevious_property_change):
4873 (Fremove_list_of_text_properties): Remove decls.
4874 * keyboard.c (Fthis_command_keys): Remove decl.
4875 (Fcommand_execute): New forward static decl.
4876 * keymap.c (Flookup_key): New forward static decl.
4877 (Fcopy_keymap): Now static.
4878 * keymap.h (Flookup_key): Remove decl.
4879 * process.c (Fget_process): New forward static decl.
4880 (Fprocess_datagram_address): Mark as internal.
4881 * syntax.c (Fsyntax_table_p): New forward static decl.
4882 (skip_chars): Remove duplicate decl.
4883 * textprop.c (Fprevious_property_change): New forward static decl.
4884 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4885 Now internal.
4886 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4887 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4888
785bbd42
PE
4889 * editfns.c (Fformat): Remove unreachable code.
4890
8b913b57
AS
48912011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4892
4893 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4894 change. (Bug#8496)
4895
a6744a35
EZ
48962011-04-13 Eli Zaretskii <eliz@gnu.org>
4897
4898 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4899 when at ZV. (Bug#8487)
4900
e7974947
AS
49012011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4902
baad03f0
AS
4903 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4904 (Bug#8437)
4905 * keyboard.c (parse_tool_bar_item): Likewise.
4906 * sound.c (sound_cleanup, alsa_close): Likewise.
4907 * termcap.c (tgetent): Likewise.
4908 * xfns.c (x_default_font_parameter): Likewise.
4909 * xsettings.c (read_and_apply_settings): Likewise.
4910
e7974947
AS
4911 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4912 (overrun_check_free): Protoize.
4913
28272684
PE
49142011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4915
4916 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4917 since callers should never pass a negative size.
4918 Change the signature to match that of plain 'read' and 'write'; see
4919 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4920 * lisp.h: Update prototypes of emacs_write and emacs_read.
4921
11997c76
EZ
49222011-04-11 Eli Zaretskii <eliz@gnu.org>
4923
4924 * xdisp.c (redisplay_window): Don't try to determine the character
4925 position of the scroll margin if the window start point w->startp
e896f03c 4926 is outside the buffer's accessible region. (Bug#8468)
11997c76 4927
8a2cbd72
EZ
49282011-04-10 Eli Zaretskii <eliz@gnu.org>
4929
4930 Fix write-region and its subroutines for buffers > 2GB.
4931 * fileio.c (a_write, e_write): Modify declaration of arguments and
4932 local variables to support buffers larger than 2GB.
4933 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4934
4935 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4936 argument, local variables, and return value.
4937
4938 * lisp.h: Update prototypes of emacs_write and emacs_read.
4939
4940 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4941
4073e537 49422011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4943
1ebfdcb6
PE
4944 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4945
b2ded58d
PE
4946 Fix more problems found by GCC 4.6.0's static checks.
4947
7d66342c
PE
4948 * xdisp.c (vmessage): Use a better test for character truncation.
4949
bbf47d44
PE
4950 * charset.c (load_charset_map): <, not <=, for optimization,
4951 and to avoid potential problems with integer overflow.
9248994d 4952 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4953 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4954 * editfns.c (Fformat): Likewise.
1e69125e 4955 * syntax.c (skip_chars): Likewise.
3befa583 4956
e3019616
PE
4957 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4958 This also lets GCC 4.6.0 generate slightly better loop code.
4959
becfa255
PE
4960 * callint.c (Fcall_interactively): <, not <=, for optimization.
4961 (Fcall_interactively): Count the number of arguments produced,
4962 not the number of arguments given. This is simpler and lets GCC
4963 4.6.0 generate slightly better code.
4964
dae0cd48
PE
4965 * ftfont.c: Distingish more carefully between FcChar8 and char.
4966 The previous code passed unsigned char * to a functions like
4967 strlen and xstrcasecmp that expect char *, which does not
4968 conform to the C standard.
4969 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4970 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4971 char * when the C standard requires it.
4972
76032d70
PE
4973 * keyboard.c (read_char): Remove unused var.
4974
eb3f1cc8
PE
4975 * eval.c: Port to Windows vsnprintf (Bug#8435).
4976 Include <limits.h>.
4977 (SIZE_MAX): Define if the headers do not.
4978 (verror): Do not give up if vsnprintf returns a negative count.
4979 Instead, grow the buffer. This ports to Windows vsnprintf, which
4980 does not conform to C99. Problem reported by Eli Zaretskii.
4981 Also, simplify the allocation scheme, by avoiding the need for
4982 calling realloc, and removing the ALLOCATED variable.
4983
70476b54
PE
4984 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4985
12020a9e
PE
4986 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4987 But keep the doprint source code for now, as we might revamp it
4988 and use it again (Bug#8435).
ea6c7ae6
PE
4989 * lisp.h (doprnt): Remove.
4990 * Makefile.in (base_obj): Remove doprnt.o.
4991 * deps.mk (doprnt.o): Remove.
4992
5fdb398c
PE
4993 error: Print 32- and 64-bit integers portably (Bug#8435).
4994 Without this change, on typical 64-bit hosts error ("...%d...", N)
4995 was used to print both 32- and 64-bit integers N, which relied on
4996 undefined behavior.
4997 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4998 New macro.
4999 * lisp.h (error, verror): Mark as printf-like functions.
5000 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5001 Report overflow in size calculations when allocating printf buffer.
5002 Do not truncate output string at its first null byte.
5003 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5004 Truncate the output at a character boundary, since vsnprintf does not
5005 do that.
5006 * charset.c (check_iso_charset_parameter): Convert internal
5007 character to string before calling 'error', since %c now has the
5008 printf meaning.
5009 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5010 overflow when computing char to be passed to 'error'. Do not
5011 pass Lisp_Object to 'error'; pass the integer instead.
5012 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5013 formatted with plain %d.
5014
b189fa66
PE
5015 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5016
bff87ef0
PE
5017 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5018
7e2cac20
PE
5019 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5020
ce4d90b5
PE
5021 * xterm.c (x_catch_errors): Remove duplicate declaration.
5022
266c9547
PE
5023 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5024
79c49ad2
PE
5025 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5026
368f4090
JM
50272011-04-10 Jim Meyering <meyering@redhat.com>
5028
5029 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5030 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5031 return ssize_t not "int", and use size_t as the buffer length.
5032 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5033 * gnutls.h: Update declarations.
5034 * process.c (read_process_output): Use ssize_t, to match.
5035 (send_process): Likewise.
5036
a32d4040
CY
50372011-04-09 Chong Yidong <cyd@stupidchicken.com>
5038
5039 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5040
8546720e 50412011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5042
04f2d78b
CB
5043 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5044 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5045
8546720e
GM
5046 * xterm.c (handle_one_xevent):
5047 * xmenu.c (create_and_show_popup_menu):
5048 * xselect.c (x_decline_selection_request)
5049 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5050
0a2f5c1a 50512011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5052
5053 Fix some uses of `int' instead of EMACS_INT.
5054 * search.c (string_match_1, fast_string_match)
5055 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5056 (scan_buffer, find_next_newline_no_quit)
5057 (find_before_next_newline, search_command, Freplace_match)
5058 (Fmatch_data): Make some `int' variables be EMACS_INT.
5059
5060 * xdisp.c (display_count_lines): 3rd argument and return value now
5061 EMACS_INT. All callers changed.
5062 (pint2hrstr): Last argument is now EMACS_INT.
5063
5064 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5065 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5066 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5067 (decode_coding_utf_16, decode_coding_emacs_mule)
5068 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5069 (decode_coding_ccl, decode_coding_charset)
5070 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5071 (decode_coding_iso_2022, decode_coding_emacs_mule)
5072 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5073 <char_offset, last_offset>: Declare EMACS_INT.
5074 (encode_coding_utf_8, encode_coding_utf_16)
5075 (encode_coding_emacs_mule, encode_invocation_designation)
5076 (encode_designation_at_bol, encode_coding_iso_2022)
5077 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5078 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5079 Declare EMACS_INT.
5080 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5081 (encode_invocation_designation): Last argument P_NCHARS is now
5082 EMACS_INT.
5083 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5084 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5085
5086 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5087 All users changed.
5088
5089 * ccl.c (Fccl_execute_on_string): Declare some variables
5090 EMACS_INT.
5091
8546720e 50922011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5093
5094 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5095
4e19a977
CS
50962011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5097
5098 * process.c (Fformat_network_address): Doc fix.
5099
87302331
R
51002011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5101
5102 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5103
cbb59342
CY
51042011-04-08 Chong Yidong <cyd@stupidchicken.com>
5105
5106 * keyboard.c (read_char): Call Lisp function help-form-show,
5107 instead of using internal_with_output_to_temp_buffer.
5108 (Qhelp_form_show): New var.
e0d38eeb 5109 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5110
5111 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5112
5113 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5114
e67a13ab
CY
51152011-04-06 Chong Yidong <cyd@stupidchicken.com>
5116
04f2d78b
CB
5117 * process.c (Flist_processes): Remove to Lisp.
5118 (list_processes_1): Delete.
e67a13ab 5119
973f782d
EZ
51202011-04-06 Eli Zaretskii <eliz@gnu.org>
5121
7c106b1e
EZ
5122 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5123
973f782d
EZ
5124 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5125
41cf7d1a 51262011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5127
ca23cc88
PE
5128 Fix more problems found by GCC 4.6.0's static checks.
5129
f390e2d5
PE
5130 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5131
42eea0d0
PE
5132 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5133
b69769da 5134 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5135
f9541e84
PE
5136 * xdisp.c (vmessage): Mark as a printf-like function.
5137
13841b55
PE
5138 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5139
c136c10f
PE
5140 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5141
5e2d4a30
PE
5142 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5143 printf-like functions.
5144 (tiff_load): Add casts to remove these marks before passing them
5145 to system-supplied API.
5146
583f48b9
PE
5147 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5148
b25d760e
PE
5149 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5150 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5151 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5152 directly, rather than having caller test rule sign. This avoids
5153 some unnecessary tests.
5154 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5155 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5156 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5157
bc7b6697 5158 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5159 (xfont_open): Avoid unnecessary tests.
bc7b6697 5160
27ccc379
PE
5161 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5162
dcd5c89a
PE
5163 * composite.h, composite.c (composition_gstring_put_cache):
5164 Use EMACS_INT, not int, for length.
5165
b13a45c6
PE
5166 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5167 breaking out part of COMPOSITION_DECODE_RULE.
5168 (COMPOSITION_DECODE_RULE): Use it.
5169 * composite.c (get_composition_id): Remove unused local vars,
5170 by using the new macro.
5171
1e792e4d
PE
5172 * textprop.c (set_text_properties_1): Change while to do-while,
5173 since the condition is always true at first.
5174
dc6c6455 5175 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5176 (interval_deletion_adjustment): Return unsigned value.
5177 All uses changed.
dc6c6455 5178
aba7731a
PE
5179 * process.c (list_processes_1, create_pty, read_process_output):
5180 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5181 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5182 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5183 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5184 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5185
fdfc4bf3
PE
5186 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5187
fca8fe46 5188 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5189 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5190
06a0259a 5191 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5192 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5193 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5194
e7b9e80f
PE
5195 * print.c (print_error_message): Avoid int overflow.
5196
56201685
PE
5197 * font.c (font_list_entities): Redo for clarity,
5198 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5199
78834453 5200 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5201 (font_score): Avoid potential overflow in diff calculation.
78834453 5202
0bc0b309 5203 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5204 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5205
e610eaca
PE
5206 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5207
b895abce
PE
5208 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5209 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5210 can always succeed if overflow has undefined behavior.
5211
1f1d9321 5212 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5213 (wordify): Omit three unnecessary tests.
1f1d9321 5214
c59478bc
PE
5215 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5216 All callers changed. This avoids the need for an unused var.
5217
79b73827
PE
5218 * casefiddle.c (casify_region): Remove var that is set but not used.
5219
a4db5dfe
PE
5220 * dired.c (file_name_completion): Remove var that is set but not used.
5221
43aae36e
PE
5222 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5223
2a47c44d 5224 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5225 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5226
a37c69bf
PE
5227 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5228 Check for integer overflow on size calculations.
5229
328ab8e7
PE
5230 * buffer.c (Fprevious_overlay_change): Remove var that is set
5231 but not used.
5232
e5a2a5cb
PE
5233 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5234 Remove vars that are set but not used.
8d84a6eb 5235 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5236 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5237
a60e5f68
PE
5238 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5239
f661cb61 5240 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5241 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5242
f0397f5a
PE
5243 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5244 that are set but not used.
5245
8664db06 5246 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5247 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5248
6abdaa4a
PE
5249 * xselect.c (x_get_local_selection, x_handle_property_notify):
5250 Remove vars that are set but not used.
5251
0ce7538d 5252 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5253 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5254
9ae848fc
PE
5255 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5256 Remove var that is set but not used.
0b918413
PE
5257 (scroll_bar_windows_size): Now size_t, not int.
5258 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5259 Check for overflow.
9ae848fc 5260
a5a62657
PE
5261 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5262 (map_tty_color) [!defined MSDOS]: Likewise.
5263
5c5cdd39
PE
5264 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5265
66ebf983
PE
5266 * coding.c: Remove vars that are set but not used.
5267 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5268 All callers changed.
5269 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5270 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5271 (decode_coding_charset): Remove vars that are set but not used.
5272
1be4d761
PE
5273 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5274 that is set but not used.
5275
47553fa8
PE
5276 * print.c (print_object): Remove var that is set but not used.
5277
1f7196bf 5278 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5279 The gnulib version avoids calling malloc in the usual case,
5280 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5281 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5282 * filelock.c (current_lock_owner): Likewise.
5283 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5284 * sysdep.c: Include allocator.h, careadlinkat.h.
5285 (emacs_no_realloc_allocator): New static constant.
5286 (emacs_readlink): New function.
fdb61804
PE
5287 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5288 ../lib/careadlinkat.h.
d1fdcab7 5289
f84c17c7
SM
52902011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5291
5292 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5293 first non-nil return value).
5294
ef3862ad
JD
52952011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5296
5297 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5298 if not defined (Bug#8403).
5299
376a7006
JB
53002011-04-02 Juanma Barranquero <lekktu@gmail.com>
5301
5302 * xdisp.c (display_count_lines): Remove parameter `start',
5303 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5304 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5305 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5306 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5307 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5308 and thereabouts. All callers changed.
5309 (get_per_char_metric): Remove parameter `f', unused since
5310 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5311
6ca3801d
JM
53122011-04-02 Jim Meyering <meyering@redhat.com>
5313
5314 do not dereference NULL upon failed strdup
5315 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5316 (ns_get_family): Likewise.
5317
d8e2b5ba
JB
53182011-04-02 Juanma Barranquero <lekktu@gmail.com>
5319
5320 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5321
8c74fcbd
JD
53222011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5323
5324 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5325 later (Bug#8403).
5326
7200d79c
SM
53272011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5328
03408648 5329 Add lexical binding.
7200d79c 5330
03408648
SM
5331 * window.c (Ftemp_output_buffer_show): New fun.
5332 (Fsave_window_excursion):
5333 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5334
5335 * lread.c (lisp_file_lexically_bound_p): New function.
5336 (Fload): Bind Qlexical_binding.
5337 (readevalloop): Remove `evalfun' arg.
5338 Bind Qinternal_interpreter_environment.
5339 (Feval_buffer): Bind Qlexical_binding.
5340 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5341 Mark as dynamic.
5342 (syms_of_lread): Declare `lexical-binding'.
5343
5344 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5345
5346 * keyboard.c (eval_dyn): New fun.
5347 (menu_item_eval_property): Use it.
ca105506
SM
5348
5349 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5350
03408648
SM
5351 * fns.c (concat, mapcar1): Accept byte-code-functions.
5352
5353 * eval.c (Fsetq): Handle lexical vars.
5354 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5355 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5356 (FletX, Flet): Obey lexical binding.
5357 (Fcommandp): Handle closures.
5358 (Feval): New `lexical' arg.
5359 (eval_sub): New function extracted from Feval. Use it almost
5360 everywhere where Feval was used. Look up vars in lexical env.
5361 Handle closures.
5362 (Ffunctionp): Move from subr.el.
5363 (Ffuncall): Handle closures.
5364 (apply_lambda): Remove `eval_flags'.
5365 (funcall_lambda): Handle closures and new byte-code-functions.
5366 (Fspecial_variable_p): New function.
5367 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5368 but without exporting it to Lisp.
23aba0ea 5369
23aba0ea 5370 * doc.c (Fdocumentation, store_function_docstring):
03408648 5371 * data.c (Finteractive_form): Handle closures.
23aba0ea 5372
03408648
SM
5373 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5374 interactive spec.
ba83908c 5375
04f2d78b
CB
5376 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5377 New byte-codes.
03408648
SM
5378 (exec_byte_code): New function extracted from Fbyte_code to handle new
5379 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5380
03408648 5381 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5382
03408648 5383 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5384
e2abce01
JB
53852011-03-31 Juanma Barranquero <lekktu@gmail.com>
5386
5387 * xdisp.c (redisplay_internal): Fix prototype.
5388
63696a73 53892011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5390
63696a73 5391 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5392 (try_scrolling): Use it when setting scroll_limit.
5393 Limit scrolling to 100 screen lines.
63696a73
EZ
5394 (redisplay_window): Even when falling back on "recentering",
5395 position point in the window according to scroll-conservatively,
5396 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5397
5398 (try_scrolling): When point is above the window, allow searching
5399 as far as scroll_max, or one screenful, to compute vertical
5400 distance from PT to the scroll margin position. This prevents
5401 try_scrolling from unnecessarily failing when
5402 scroll-conservatively is set to a value slightly larger than the
5403 window height. Clean up the case of PT below the margin at bottom
5404 of window: scroll_max can no longer be INT_MAX. When aggressive
5405 scrolling is in use, don't let point enter the opposite scroll
5406 margin as result of the scroll.
5407 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5408 threshold of 100 lines for never-recentering scrolling.
5409
e4cc2dfc
JB
54102011-03-31 Juanma Barranquero <lekktu@gmail.com>
5411
5412 * dispextern.h (move_it_by_lines):
5413 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5414 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5415 (message_log_check_duplicate): Remove parameters `prev_bol' and
5416 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5417 (redisplay_internal): Remove parameter `preserve_echo_area',
5418 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5419
5420 * indent.c (Fvertical_motion):
5421 * window.c (window_scroll_pixel_based, Frecenter):
5422 Don't pass `need_y_p' to `move_it_by_lines'.
5423
1c470562
SM
54242011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5425
44f230aa
SM
5426 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5427 steal a few bits to be more compact.
5428 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5429 Remove unneeded casts.
5430
1c470562
SM
5431 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5432
888adce9
ZK
54332011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5434
5435 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5436 binding" message (bug#7967).
5437
f838ed7b
PE
54382011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5439
77861b95
PE
5440 Fix more problems found by GCC 4.6.0's static checks.
5441
de6dbc14
PE
5442 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5443 Remove unused local var.
5444
f838ed7b
PE
5445 * editfns.c (Fmessage_box): Remove unused local var.
5446
792c7b2b
PE
5447 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5448 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5449 Omit unused local vars.
c499e557 5450 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5451 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5452 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5453 Omit unused local var.
5454
ba0165e1
PE
5455 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5456 Don't assume string length fits in int.
32ad8845 5457 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5458 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5459
3c59b4c9
PE
5460 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5461 instead of alloca (Bug#8344).
5462
a3eed478 5463 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5464 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5465
eb4d412d
PE
5466 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5467
1658b401
PE
5468 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5469 concerns.
5470
5471 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5472
5473 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5474
9a2c6e05
PE
5475 * keyboard.c (syms_of_keyboard): Use the same style as later
5476 in this function when indexing through an array. This also
5477 works around GCC bug 48267.
5478
03d0a109
PE
5479 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5480
44f730c8
PE
5481 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5482
fe75f926
PE
5483 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5484 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5485
ffa8c828
PE
5486 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5487 This avoids undefined behavior on integer overflow, and is a bit
5488 more convenient anyway since it is compared to a size_t variable.
5489
c5101a77
PE
5490 Variadic C functions now count arguments with size_t, not int.
5491 This avoids an unnecessary limitation on 64-bit machines, which
5492 caused (substring ...) to crash on large vectors (Bug#8344).
5493 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5494 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5495 All variadic functions and their callers changed accordingly.
c5101a77
PE
5496 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5497 * data.c (arith_driver, float_arith_driver): Likewise.
5498 * editfns.c (general_insert_function): Likewise.
5499 * eval.c (struct backtrace.nargs, interactive_p)
5500 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5501 (funcall_lambda, mark_backtrace): Likewise.
5502 * fns.c (concat): Likewise.
5503 * frame.c (x_set_frame_parameters): Likewise.
5504 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5505 0 if not found, not -1. All callers changed.
5506
dd3f25f7
PE
5507 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5508 (stack_copy_size): Now size_t, not int.
5509 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5510
461c2ab9
JB
55112011-03-28 Juanma Barranquero <lekktu@gmail.com>
5512
5513 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5514 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5515 All callers changed.
5516
5517 * lisp.h (multibyte_char_to_unibyte):
5518 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5519 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5520 * character.h (CHAR_TO_BYTE8):
5521 * cmds.c (internal_self_insert):
5522 * editfns.c (general_insert_function):
5523 * keymap.c (push_key_description):
5524 * search.c (Freplace_match):
5525 * xdisp.c (message_dolog, set_message_1): All callers changed.
5526
f6d62986
SM
55272011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5528
5529 * keyboard.c (safe_run_hook_funcall): New function.
5530 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5531 don't set the hook to nil, but remove the offending function instead.
5532 (Qcommand_hook_internal): Remove, unused.
5533 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5534 Vcommand_hook_internal.
5535
5536 * eval.c (enum run_hooks_condition): Remove.
5537 (funcall_nil, funcall_not): New functions.
5538 (run_hook_with_args): Call each function through a `funcall' argument.
5539 Remove `cond' argument, now redundant.
5540 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5541 (Frun_hook_with_args_until_failure): Adjust accordingly.
5542 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5543
1db5b1ad
JB
55442011-03-28 Juanma Barranquero <lekktu@gmail.com>
5545
5546 * dispextern.h (string_buffer_position): Remove declaration.
5547
5548 * print.c (strout): Remove parameter `multibyte', unused since
5549 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5550
5551 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5552 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5553 All callers changed.
5554
5555 * w32.c (_wsa_errlist): Use braces for struct initializers.
5556
5557 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5558 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5559 All callers changed.
5560 (string_buffer_position): Likewise. Also, make static (it's never
5561 used outside xdisp.c).
5562 (cursor_row_p): Remove parameter `w', unused since
5563 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5564 (decode_mode_spec): Remove parameter `precision', introduced during
5565 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5566 All callers changed.
5567
5ffb62aa
JD
55682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5569
5570 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5571
461c2ab9 55722011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5573
5574 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5575 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5576 (ns_update_auto_hide_menu_bar): New functions.
5577 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5578 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5579 ns_constrain_all_frames.
5580 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5581 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5582
5c380ffb
JD
55832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5584
5585 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5586
9af30bdf
GM
55872011-03-27 Glenn Morris <rgm@gnu.org>
5588
5589 * syssignal.h: Replace RETSIGTYPE with void.
5590 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5591 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5592 Replace SIGTYPE with void everywhere.
5593 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5594 * s/template.h (SIGTYPE): Remove commented out definition.
5595
e2abce01
JB
55962011-03-26 Eli Zaretskii <eliz@gnu.org>
5597
5598 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5599 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5600
f868cd8a
JB
56012011-03-26 Juanma Barranquero <lekktu@gmail.com>
5602
59eb0929
JB
5603 * w32.c (read_unc_volume): Use parameter `henum', instead of
5604 global variable `wget_enum_handle'.
5605
5606 * keymap.c (describe_vector): Remove parameters `indices' and
5607 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5608 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5609
f868cd8a
JB
5610 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5611
5612 * keyboard.c (timer_check): Remove parameter `do_it_now',
5613 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5614 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5615 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5616
5617 * keyboard.c (read_char):
5618 * w32menu.c (w32_menu_display_help):
5619 * xmenu.c (show_help_event, menu_help_callback):
5620 Adjust calls to `show_help_echo'.
5621
5622 * gtkutil.c (xg_maybe_add_timer):
5623 * keyboard.c (readable_events):
5624 * process.c (wait_reading_process_output):
5625 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5626
5627 * insdel.c (adjust_markers_gap_motion):
5628 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5629 (gap_left, gap_right): Don't call it.
5630
2ecf6fdb
CY
56312011-03-25 Chong Yidong <cyd@stupidchicken.com>
5632
5633 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5634 incurred during fontification.
5635
6b1f9ba4
JB
56362011-03-25 Juanma Barranquero <lekktu@gmail.com>
5637
5638 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5639 (DEFVAR_PER_BUFFER): Don't pass it.
5640
5641 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5642 (scrolling_window): Don't pass it.
5643
0f4a96b5
JB
56442011-03-25 Juanma Barranquero <lekktu@gmail.com>
5645
5646 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5647
5648 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5649 and `suffix'.
5650 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5651 of variables specific to SELinux and computation of `encoded_absname'.
5652
5653 * image.c (XPutPixel): Remove unused variable `height'.
5654
5655 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5656
5657 * unexw32.c (get_section_info): Remove unused variable `section'.
5658
5659 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5660 (system_process_attributes): Remove unused variable `sess'.
5661 (sys_read): Remove unused variable `err'.
5662
5663 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5664 (w32_wnd_proc): Remove unused variable `isdead'.
5665 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5666 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5667 (x_create_tip_frame): Remove unused variable `tem'.
5668
5669 * w32inevt.c (w32_console_read_socket):
5670 Remove unused variable `no_events'.
5671
5672 * w32term.c (x_draw_composite_glyph_string_foreground):
5673 Remove unused variable `width'.
5674
1149507c
JB
56752011-03-24 Juanma Barranquero <lekktu@gmail.com>
5676
5677 * w32term.c (x_set_glyph_string_clipping):
5678 Don't pass uninitialized region to CombineRgn.
5679
9c88f339
JB
56802011-03-23 Juanma Barranquero <lekktu@gmail.com>
5681
5682 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5683 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5684 (Fx_close_connection): Remove unused variable `i'.
5685
5686 * w32font.c (w32font_draw): Return number of glyphs.
5687 (w32font_open_internal): Remove unused variable `i'.
5688 (w32font_driver): Add missing initializer.
5689
5690 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5691 (fill_in_menu): Remove unused variable `items_added'.
5692
5693 * w32term.c (last_mouse_press_frame): Remove static global variable.
5694 (w32_clip_to_row): Remove unused variable `f'.
5695 (x_delete_terminal): Remove unused variable `i'.
5696
5697 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5698 (NOTHING): Remove unused static global variable.
5699 (uniscribe_check_otf): Remove unused variable `table'.
5700 (uniscribe_font_driver): Add missing initializers.
5701
dee091a3
JD
57022011-03-23 Julien Danjou <julien@danjou.info>
5703
5704 * term.c (Fsuspend_tty, Fresume_tty):
5705 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5706 * window.c (temp_output_buffer_show):
5707 * insdel.c (signal_before_change):
5708 * frame.c (Fhandle_switch_frame):
5709 * fileio.c (Fdo_auto_save):
5710 * emacs.c (Fkill_emacs):
5711 * editfns.c (save_excursion_restore):
5712 * cmds.c (internal_self_insert):
5713 * callint.c (Fcall_interactively):
5714 * buffer.c (Fkill_all_local_variables):
5715 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5716 Use Frun_hooks.
0f4a96b5 5717 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5718 unconditionnaly since it does the check itself.
5719
2c520ab5 57202011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5721
c9c49752
PE
5722 Fix more problems found by GCC 4.5.2's static checks.
5723
8abc3f12
PE
5724 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5725 the first time through the loop, since we know p0 < p1 then.
5726 This also avoids a gcc -Wstrict-overflow warning.
5727
a2d26660
PE
5728 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5729 leading to a memory leak, possible in functions like
5730 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5731 of objects (Bug#8318).
a2d26660 5732
916c72e9
PE
5733 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5734 that could (at least in theory) be that large.
5735
19ab8a18
PE
5736 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5737 This is less likely to overflow, and avoids undefined behavior if
5738 overflow does occur. All callers changed. Use strtoul to scan
5739 for the unsigned long integer.
b7cbbd6f
PE
5740 (pint2hrstr): Simplify and tune code slightly.
5741 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5742
f0641eff
PE
5743 * scroll.c (do_scrolling): Work around GCC bug 48228.
5744 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5745
7f650bb9
PE
5746 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5747 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5748 (validate_x_resource_name): Simplify count usage.
5749 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5750
37dd57d1
PE
5751 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5752 fail (Bug#8306).
81e56e61 5753
699979fc 5754 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5755
401bf9b4
PE
5756 * process.c (Fmake_network_process): Use socklen_t, not int,
5757 where POSIX says socklen_t is required in portable programs.
5758 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5759 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5760 (Fmake_network_process, server_accept_connection):
5761 (wait_reading_process_output, read_process_output):
5762 Likewise.
5763
b93aacde
PE
5764 * process.c: Rename or move locals to avoid shadowing.
5765 (list_processes_1, Fmake_network_process):
5766 (read_process_output_error_handler, exec_sentinel_error_handler):
5767 Rename or move locals.
4dc343ee 5768 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5769 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5770 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5771 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5772 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5773
af8a867c 5774 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5775 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5776 Include tparam.h instead, since it declares them.
af8a867c
PE
5777 * cm.h (PC): Remove extern decl; tparam.h now does this.
5778 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5779 * terminfo.c: Include tparam.h, to check interfaces.
5780 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5781 (tparam): Adjust signature to match interface in tparam.h;
5782 this removes some undefined behavior. Check that outstring and len
5783 are zero, which they always are with Emacs.
5784 * tparam.h (PC, BC, UP): New extern decls.
5785
0248044d 5786 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5787 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5788
8ff096c1 5789 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5790 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5791 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5792 (ftfont_list): Remove unused local.
49eaafba
PE
5793 (get_adstyle_property, ftfont_pattern_entity):
5794 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5795 Rename locals to avoid shadowing.
8ff096c1 5796
e2be39f6
PE
5797 * xfont.c (xfont_list_family): Mark var as initialized.
5798
c9735e30
PE
5799 * xml.c (make_dom): Now static.
5800
8f5201ae
PE
5801 * composite.c (composition_compute_stop_pos): Rename local to
5802 avoid shadowing.
b246f932
PE
5803 (composition_reseat_it): Remove unused locals.
5804 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5805 (composition_update_it): Mark var as initialized.
11b61122
PE
5806 (find_automatic_composition): Mark vars as initialized,
5807 with a FIXME (Bug#8290).
8f5201ae 5808
760fbc2c
PE
5809 character.h: Rename locals to avoid shadowing.
5810 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5811 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5812 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5813 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5814 to avoid shadowing.
5815
ff08eb85
PE
5816 * textprop.c (property_change_between_p): Remove; unused.
5817
fc7bf025
PE
5818 * intervals.c (interval_start_pos): Now static.
5819
235d7abc
PE
5820 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5821
44f230aa
SM
5822 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5823 Rename locals to avoid shadowing.
3e7d6594 5824
50060332
PE
5825 * sound.c (wav_play, au_play, Fplay_sound_internal):
5826 Fix pointer signedness.
d01f234b 5827 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5828 (wav_play): Initialize a variable to 0, to prevent undefined
5829 behavior (Bug#8278).
50060332 5830
c4fc4e30
PE
5831 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5832
918436ed
PE
5833 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5834
c939f91b
PE
5835 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5836 clobbering (Bug#8298).
b9c7f648
PE
5837 * sysdep.c (sys_subshell): Likewise.
5838 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5839
6bd8c144
PE
5840 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5841 This should get cleaned up, so that child_setup has the
5842 same signature on all platforms.
5843
7710357c 5844 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5845 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5846
c59da222
CY
58472011-03-22 Chong Yidong <cyd@stupidchicken.com>
5848
5849 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5850 not to be necessary, and produces flickering.
5851
66b87493
GM
58522011-03-20 Glenn Morris <rgm@gnu.org>
5853
5854 * config.in: Remove file.
5855
45b6f6d5
JB
58562011-03-20 Juanma Barranquero <lekktu@gmail.com>
5857
5858 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5859 are now in src/globals.h.
5860 (syms_of_minibuf): Remove spurious & from previous change.
5861
3ec03f7e
LL
58622011-03-20 Leo <sdl.web@gmail.com>
5863
5864 * minibuf.c (completing-read-function): New variable.
5865 (completing-read-default): Rename from completing-read.
5866 (completing-read): Call completing-read-function.
5867
b14e3e21
CY
58682011-03-19 Juanma Barranquero <lekktu@gmail.com>
5869
5870 * xfaces.c (Fx_load_color_file):
5871 Read color file from absolute filename (bug#8250).
5872
f2b726e6
JB
58732011-03-19 Juanma Barranquero <lekktu@gmail.com>
5874
5875 * makefile.w32-in: Update dependencies.
5876
09f6ff02
EZ
58772011-03-17 Eli Zaretskii <eliz@gnu.org>
5878
5879 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5880
29a6015a
PE
58812011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5882
a3a6c54e
PE
5883 Fix more problems found by GCC 4.5.2's static checks.
5884
b766f867
PE
5885 * process.c (make_serial_process_unwind, send_process_trap):
5886 (sigchld_handler): Now static.
5887
be02381c
PE
5888 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5889 That way, the code declares only the vars that it needs.
5890 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5891 * s/cygwin.h (PTY_ITERATION): Likewise.
5892 * s/darwin.h (PTY_ITERATION): Likewise.
5893 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5894
57048744
PE
5895 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5896 * process.c (allocate_pty): Don't declare stb unless it's needed.
5897
7914961c 5898 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5899 (CONSTANTLIM): Remove; unused.
5900 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5901 Define only if needed.
7914961c 5902
b3967b18
PE
5903 * unexelf.c (unexec): Name an expression,
5904 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5905 Use a different way to cause a compilation error if anyone uses
5906 n rather than nn, a way that does not involve shadowing.
73366a00 5907 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5908
29a6015a
PE
5909 * deps.mk (unexalpha.o): Remove; unused.
5910
43cfc33e 5911 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5912 * unexec.h: New file.
ce701a33
PE
5913 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5914 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5915 Depend on unexec.h.
5916 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5917 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5918 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5919 Change as necessary to match prototype in unexec.h.
ce701a33 5920
01f44d5a
PE
5921 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5922 shadowing.
4f63c6bb 5923 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5924
a6670b0b
PE
5925 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5926 Rename locals to avoid shadowing.
5927
cef2010d 5928 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5929 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5930
d4d7173a
PE
5931 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5932
f08b802a
PE
5933 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5934 warning when compiling print.c.
5935
3ddb0639
PE
5936 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5937 instead of using an uninitialized var.
5ad03b97 5938 (font_sort_entities): Mark var as initialized.
3ddb0639 5939
170a2692
PE
5940 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5941
e663c700
PE
5942 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5943 pointers to constants.
89bc529a 5944 (font_parse_fcname): Remove unused vars.
7b81e2d0 5945 (font_delete_unmatched): Now static.
ea838e10 5946 (font_get_spec): Remove; unused.
13a547c6
PE
5947 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5948 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5949 Rename or move locals to avoid shadowing.
e663c700 5950
2a80c887 5951 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5952 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5953
1384fa33 5954 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5955 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5956
8b2c52e9
PE
5957 * alloc.c (mark_backtrace): Move decl from here ...
5958 * lisp.h: ... to here, so that it can be checked.
5959
475545b5 5960 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5961 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5962 (lisp_indirect_variable): Name an expression,
5963 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5964 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5965
b1349114 5966 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5967 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5968 Use const pointer when appropriate.
b1349114 5969
a2928364
PE
5970 * lisp.h (get_system_name, get_operating_system_release):
5971 Move decls here, to check interfaces.
5972 * process.c (get_operating_system_release): Move decl to lisp.h.
5973 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5974 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5975 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5976 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5977 (Fformat_time_string, Fencode_time, Finsert_char):
5978 (Ftranslate_region_internal, Fformat):
5979 Rename or remove local vars to avoid shadowing.
9710023e 5980 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5981
a415e694
PE
5982 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5983 avoid shadowing.
5984
8ef4622d
PE
5985 * lisp.h (eassert): Check that the argument compiles, even if
5986 ENABLE_CHECKING is not defined.
5987
946f9a5b
PE
5988 * data.c (Findirect_variable): Name an expression, to avoid
5989 gcc -Wbad-function-cast warning.
112396d6 5990 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5991 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5992 (Fmake_variable_buffer_local, Fmake_local_variable):
5993 Mark variables as initialized.
52746918 5994 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5995
e5aab7e7 5996 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5997 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5998 Rename locals to avoid shadowing.
dff45157
PE
5999 (mark_stack): Move local variables into the #ifdef region where
6000 they're used.
7bc26fdb
PE
6001 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6002 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6003 needed otherwise.
6004 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6005 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6006 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6007
e5aab7e7
PE
6008 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6009 avoids undefined behavior in theory.
6010
4da60324
PE
6011 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6012
88043301
PE
6013 Use functions, not macros, for up- and down-casing (Bug#8254).
6014 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6015 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6016 to use the following functions instead of these macros.
6017 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6018 EMACS_INT, since callers assume the returned value fits in int.
6019 (upcase1): Likewise, for UPCASE_TABLE.
6020 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6021 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6022 the race-condition problem in the old DOWNCASE.
88043301 6023
19ed5445
PE
6024 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6025 Rename locals to avoid shadowing.
6026 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6027 (regex_compile, re_search_2, re_match_2_internal):
6028 Remove unused local vars.
952db0d7
PE
6029 (FREE_VAR): Rewrite so as not to use empty "else",
6030 which gcc can warn about.
da053e48 6031 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6032 (RETALLOC_IF): Define only if needed.
6033 (WORDCHAR_P): Likewise. This one is never needed, but is used
6034 only in a comment talking about a compiler bug, so put inside
6035 the #if 0 of that comment.
6036 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6037 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6038 Remove; unused.
19ed5445 6039
1f3561e4 6040 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6041 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6042 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6043
ded6f8f7
PE
6044 * search.c (simple_search): Remove unused var.
6045
dbd37a95
PE
6046 * dired.c (compile_pattern): Move decl from here ...
6047 * lisp.h: ... to here, so that it can be checked.
6048 (struct re_registers): New forward decl.
6049
7e47afad
PE
6050 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6051
85f24f61
PE
6052 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6053 All uses changed.
6054 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6055 Rename locals to avoid shadowing.
5671df8f 6056 (Fvertical_motion): Mark locals as initialized.
85f24f61 6057
181aa2be 6058 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6059 (casify_region): Mark local as initialized.
181aa2be 6060
930d429c
PE
6061 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6062
7082eac6
PE
6063 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6064 New macros, so that the caller can use some names other than
6065 gcpro1, gcpro2, etc.
6066 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6067 of the new macros.
6068 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6069 argument, for consistency with GCPRO2_VAR, etc: it is now the
6070 prefix of the variable, not the variable itself. All uses
6071 changed.
38b2c076
PE
6072 * dired.c (directory_files_internal, file_name_completion):
6073 Rename locals to avoid shadowing.
6074
15206ed9
PE
6075 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6076 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6077 dired.c's scmp function, had undefined behavior.
6078 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6079 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6080 * buffer.h: ... to here, because these macros use current_buffer,
6081 and the new implementation with inline functions needs to have
6082 current_buffer in scope now, rather than later when the macros
6083 are used.
6084 (downcase, upcase1): New static inline functions.
6085 (DOWNCASE, UPCASE1): Reimplement using these functions.
6086 This avoids undefined behavior in expressions like
6087 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6088 from race conditions in accessing the global variables
6089 case_temp1 and case_temp2.
6090 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6091 * lisp.h (case_temp1, case_temp2): Remove their decls.
6092 * character.h (ASCII_CHAR_P): Move from here ...
6093 * lisp.h: ... to here, so that the inline functions mentioned
6094 above can use them.
6095
4a6bea26
PE
6096 * dired.c (directory_files_internal_unwind): Now static.
6097
f14b7e14
PE
6098 * fileio.c (file_name_as_directory, directory_file_name):
6099 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6100 Now static.
2893f146
PE
6101 (file_name_as_directory): Use const pointers when appropriate.
6102 (Fexpand_file_name): Likewise. In particular, newdir might
6103 point at constant storage, so make it a const pointer.
fd4ead52 6104 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6105 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6106 signedness issues.
f839df0c
PE
6107 (Fset_file_times, Finsert_file_contents, auto_save_error):
6108 Rename locals to avoid shadowing.
f14b7e14 6109
5716756e 6110 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6111 (Ftry_completion, Fall_completions): Rename or remove locals
6112 to avoid shadowing.
5716756e 6113
b4c3046a
PE
6114 * marker.c (bytepos_to_charpos): Remove; unused.
6115
b45db522
PE
6116 * lisp.h (verify_bytepos, count_markers): New decls,
6117 so that gcc does not warn that these functions aren't declared.
6118
85876d07
PE
6119 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6120 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6121 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6122 (copy_text): Remove unused local var.
85876d07 6123
03d78a21 6124 * filelock.c (within_one_second): Now static.
b3dd38ab 6125 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6126
5df8f01b
PE
6127 * buffer.c (fix_overlays_before): Mark locals as initialized.
6128 (fix_start_end_in_overlays): Likewise. This function should be
6129 simplified by using pointers-to-pointers, but that's a different
6130 matter.
b1d876f1 6131 (switch_to_buffer_1): Now static.
8f54f30a
PE
6132 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6133 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6134
a70072c9 6135 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6136 Fix pointer signedness issue.
edced198
PE
6137 (sys_subshell): Mark local as volatile if checking for lint,
6138 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6139 (MAXPATHLEN): Define only if needed.
a70072c9 6140
a0977c44
PE
6141 * process.c (serial_open, serial_configure): Move decls from here ...
6142 * systty.h: ... to here, so that they can be checked.
6143
a884fdcc
PE
6144 * fns.c (get_random, seed_random): Move extern decls from here ...
6145 * lisp.h: ... to here, so that they can be checked.
6146
604efe86 6147 * sysdep.c (reset_io): Now static.
b8950c94 6148 (wait_for_termination_signal): Remove; unused.
604efe86 6149
38fc62d9
PE
6150 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6151 (copy_keymap_item, append_key, push_text_char_description):
6152 Now static.
1004a21a 6153 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6154 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6155 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6156 (describe_map_tree):
6157 Rename locals to avoid shadowing.
38fc62d9 6158
2f2650da
PE
6159 * keyboard.c: Declare functions static if they are not used elsewhere.
6160 (echo_char, echo_dash, cmd_error, top_level_2):
6161 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6162 (read_char, kbd_buffer_get_event, make_lispy_position):
6163 (make_lispy_event, make_lispy_movement, apply_modifiers):
6164 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6165 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6166 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6167 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6168 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6169
a053e86c 6170 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6171 (mark_kboards): Move decl here ...
6172 * alloc.c (mark_kboards): ... from here.
a053e86c 6173
4752793e
PE
6174 * lisp.h (force_auto_save_soon): New decl.
6175
74f10ca7 6176 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6177 (DEFINE_DUMMY_FUNCTION): New macro.
6178 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6179 Use it.
c03cd23f
PE
6180 (main): Add casts to avoid warnings
6181 if GCC considers string literals to be constants.
74f10ca7 6182
022e70d4
PE
6183 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6184
59d6fe83
PE
6185 * dbusbind.c: Pointer signedness fixes.
6186 (xd_signature, xd_append_arg, xd_initialize):
6187 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6188 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6189 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6190 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6191
78320123
PE
6192 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6193 if GCC considers string literals to be constants.
49cebcca 6194 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6195
35ac2a97
SM
61962011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6197
fb103ca9
SM
6198 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6199 (print_preprocess, print_object): New macro to fix last change.
6200
35ac2a97
SM
6201 * print.c (print_preprocess): Don't forget font objects.
6202
62973b41
JB
62032011-03-16 Juanma Barranquero <lekktu@gmail.com>
6204
6205 * emacs.c (USAGE3): Doc fixes.
6206
0e48bb22
AS
62072011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6208
6209 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6210 structure.
6211
7684e57b
JB
62122011-03-14 Juanma Barranquero <lekktu@gmail.com>
6213
6214 * lisp.h (VWindow_system, Qfile_name_history):
6215 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6216 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6217 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6218
6219 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6220 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6221
6222 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6223 * w32console.c (detect_input_pending, read_input_pending)
6224 (encode_terminal_code):
6225 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6226 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6227 (w32_system_caret_y, Qfile_name_history):
6228 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6229 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6230 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6231 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6232 * w32proc.c (Qlocal, report_file_error):
6233 * w32term.c (Vwindow_system, updating_frame):
6234 * w32uniscribe.c (initialized, uniscribe_font_driver):
6235 Remove unneeded extern declarations.
6236
2aa46d6c
CY
62372011-03-14 Chong Yidong <cyd@stupidchicken.com>
6238
c96bbc66 6239 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6240
cffc6f3b
CY
62412011-03-13 Chong Yidong <cyd@stupidchicken.com>
6242
6243 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6244 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6245 These macros can no longer be used for assignment.
6246
44f230aa
SM
6247 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6248 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6249 (record_buffer_markers, fetch_buffer_markers): New functions for
6250 recording and fetching special buffer markers.
6251 (set_buffer_internal_1, set_buffer_temp): Use them.
6252
6253 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6254
6255 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6256
6257 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6258 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6259
6260 * xdisp.c (hscroll_window_tree):
6261 (reconsider_clip_changes): Use PT instead of BUF_PT.
6262
d251f04b
EZ
62632011-03-13 Eli Zaretskii <eliz@gnu.org>
6264
6265 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6266 $(EMACS_ROOT)/lib/intprops.h.
6267
f0c77cd1
PE
62682011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6269
3eca4629
PE
6270 Fix more problems found by GCC 4.5.2's static checks.
6271
7c86ee98
PE
6272 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6273 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6274 (xg_free_frame_widgets): Make it clear that a local variable is
6275 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6276 (gdk_window_get_screen): Make it clear that this macro is needed
6277 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6278 (int_gtk_range_get_value): New function, which avoids a diagnostic
6279 from gcc -Wbad-function-cast.
6280 (xg_set_toolkit_scroll_bar_thumb): Use it.
6281 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6282 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6283 (get_utf8_string, xg_get_file_with_chooser):
6284 Rename locals to avoid shadowing.
6285 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6286
41729b81
PE
6287 * xgselect.c (xg_select): Remove unused var.
6288
f0c77cd1
PE
6289 * image.c (four_corners_best): Mark locals as initialized.
6290 (gif_load): Initialize transparent_p to zero (Bug#8238).
6291 Mark another local as initialized.
ec6cf4c6 6292 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6293
ce0ad53d 6294 * image.c (clear_image_cache): Now static.
d5d5a617 6295 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6296 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6297 (x_edge_detection): Remove unnecessary cast that
6298 gcc -Wbad-function-cast diagnoses.
2037898d 6299 (gif_load): Fix pointer signedness.
6ae141d6
PE
6300 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6301 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6302
33383987 63032011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6304
d32df629
PE
6305 Improve quality of tests for time stamp overflow.
6306 For example, without this patch (encode-time 0 0 0 1 1
6307 1152921504606846976) returns the obviously-bogus value (-948597
6308 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6309 reports time overflow. See
6310 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6311 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6312 * editfns.c: Include limits.h and intprops.h.
6313 (TIME_T_MIN, TIME_T_MAX): New macros.
6314 (time_overflow): Move earlier, to before first use.
6315 (hi_time, lo_time): New functions, for an accurate test for
6316 out-of-range times.
6317 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6318 (Fget_internal_run_time): Don't assume time_t fits in int.
6319 (make_time): Use list2 instead of Fcons twice.
6320 (Fdecode_time): More accurate test for out-of-range times.
6321 (check_tm_member): New function.
6322 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6323 (lisp_time_argument): Don't rely on undefined left-shift and
6324 right-shift behavior when checking for time stamp overflow.
8be6f318 6325
fe31d94c
PE
6326 * editfns.c (time_overflow): New function, refactoring common code.
6327 (Fformat_time_string, Fdecode_time, Fencode_time):
6328 (Fcurrent_time_string): Use it.
6329
8be6f318
PE
6330 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6331 * dired.c (make_time): Move to ...
6332 * editfns.c (make_time): ... here.
6333 * systime.h: Note the move.
6334
09d9db2c 63352011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6336
126bc0dc
YM
6337 * fringe.c (update_window_fringes): Remove unused variables.
6338
c47cbdfd
YM
6339 * unexmacosx.c (copy_data_segment): Also copy __got section.
6340 (Bug#8223)
6341
7ac80be9
EZ
63422011-03-12 Eli Zaretskii <eliz@gnu.org>
6343
c96bbc66 6344 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6345 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6346 Constify `char *' arguments and their references according to
6347 prototypes in tparam.h.
6348
ecb0f94d 6349 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6350
7ac80be9
EZ
6351 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6352 Adapt all references accordingly.
6353
6354 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6355
ef1fd07e
TT
63562011-03-11 Tom Tromey <tromey@redhat.com>
6357
6358 * buffer.c (syms_of_buffer): Remove obsolete comment.
6359
7ef4b50c
EZ
63602011-03-11 Eli Zaretskii <eliz@gnu.org>
6361
6362 * termhooks.h (encode_terminal_code): Declare prototype.
6363
6364 * msdos.c (encode_terminal_code): Don't declare prototype.
6365
6366 * term.c (encode_terminal_code): Now external again, used by
6367 w32console.c and msdos.c.
6368
44f230aa
SM
6369 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6370 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6371
4b1ec863 63722011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6373
1714f52b 6374 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6375
4b1ec863
PE
6376 * fringe.c (update_window_fringes): Mark locals as initialized
6377 (Bug#8227).
6378 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6379
524c7aa6
PE
6380 * alloc.c (mark_fringe_data): Move decl from here ...
6381 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6382 to check its interface.
6383 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6384
a5c0af81 6385 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6386 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6387 (fontset_font): Mark local as initialized.
a9a06e0b 6388 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6389
b4716021
PE
6390 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6391
811e9bac 6392 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6393 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6394 (x_own_selection, Fx_disown_selection_internal): Rename locals
6395 to avoid shadowing.
6396 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6397
7e3ab302
PE
6398 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6399 so that the caller can use some name other than gcpro1.
6400 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6401 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6402 (Fx_backspace_delete_keys_p):
6403 Use them to avoid shadowing, and rename vars to avoid shadowing.
6404 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6405 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6406 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6407 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6408 Remove unused locals.
7e3ab302
PE
6409 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6410 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6411 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6412 macros.
f78faa98 6413
e2b13473
PE
6414 * xterm.h (x_mouse_leave): New decl.
6415
77f23912
PE
6416 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6417 Remove unused functions.
cdf4ba58
PE
6418 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6419 (x_calc_absolute_position): Now static.
7411c686 6420 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6421 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6422 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6423 unless they are used.
38d0b34a
PE
6424 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6425 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6426 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6427 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6428 (x_error_catcher, x_connection_closed, x_error_handler):
6429 (x_error_quitter, xembed_send_message, x_iconify_frame):
6430 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6431 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6432 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6433
44f230aa
SM
6434 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6435 Rename or move locals to avoid shadowing.
6b463e58 6436 (tty_defined_color, merge_face_heights): Now static.
5967d051 6437 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6438 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6439 does not deduce is never used uninitialized.
73719eba
PE
6440 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6441 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6442
426994c3 6443 * terminal.c (store_terminal_param): Now static.
5489860b 6444
032f1620 6445 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6446 (set_frame_menubar): Remove unused local.
d4323972 6447 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6448 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6449 since they might point to immutable storage.
281585b0
PE
6450 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6451 since it's unused otherwise.
032f1620 6452
367c19e5 6453 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6454 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6455 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6456 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6457 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6458 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6459 does not deduce are never used uninitialized.
70739cbe 6460
07b48fa9
PE
6461 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6462
8868a238 6463 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6464 * window.c (window_loop, size_window):
6465 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6466
7e5cf297 6467 * window.c (display_buffer): Now static.
d6550a9f
PE
6468 (size_window): Mark variables that gcc -Wuninitialized
6469 does not deduce are never used uninitialized.
a586633d
PE
6470 * window.h (check_all_windows): New decl, to forestall
6471 gcc -Wmissing-prototypes diagnostic.
5b555da1 6472 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6473
f6095868
PE
6474 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6475 shadowing.
6476 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6477 Include <limits.h>.
6478 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6479 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6480 (load_charset_map): Mark variables that gcc -Wuninitialized
6481 does not deduce are never used uninitialized.
53df7c11 6482 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6483
f38b440c
PE
6484 * coding.c (coding_set_source, coding_set_destination):
6485 Use "else { /* comment */ }" rather than "else /* comment */;"
6486 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6487 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6488 a block, when the outer 'i' will do.
6489 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6490 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6491 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6492 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6493 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6494 Rename locals to avoid shadowing.
6495 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6496 * coding.c (emacs_mule_char, encode_invocation_designation):
6497 Now static, since they're not used elsewhere.
413bb2db 6498 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6499 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6500 (decode_coding_emacs_mule): Mark variables that gcc
6501 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6502 (detect_coding_iso_2022): Initialize a local variable that might
6503 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6504 this initialization is needed. (Bug#8211)
5f58e762
PE
6505 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6506 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6507 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6508 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6509 Remove unused macros.
f38b440c 6510
232b38b9 6511 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6512 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6513 * character.c (string_count_byte8): Likewise.
232b38b9 6514
fb90da1b
PE
6515 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6516 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6517
fb93dbc2
PE
6518 * chartab.c (copy_sub_char_table): Now static, since it's not used
6519 elsewhere.
5c156ace
PE
6520 (sub_char_table_ref_and_range, char_table_ref_and_range):
6521 Rename locals to avoid shadowing.
bbcd0949 6522 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6523
7d3b3862 6524 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6525 (BIDI_BOB): Remove unused macro.
7d3b3862 6526
6be7d3da
PE
6527 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6528 deduce are never used uninitialized.
c2ed9c8b 6529 * term.c (encode_terminal_code): Likewise.
6be7d3da 6530
75f8807f 6531 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6532
50938595
PE
6533 * tparam.h: New file.
6534 * term.c, tparam.h: Include it.
6535 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6536 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6537 Move these decls to tparam.h, and make them agree with what
6538 is actually in tparam.c. The previous trick of using incompatible
6539 decls in different modules does not conform to the C standard.
6540 All callers of tparam changed to use tparam's actual API.
6541 * tparam.c (tparam1, tparam, tgoto):
6542 Use const pointers where appropriate.
6543
fbceeba2
PE
6544 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6545 * cm.h (struct cm): Likewise.
6546 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6547 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6548 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6549 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6550 (turn_on_face, init_tty): Likewise.
6551 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6552
7f3f1250
PE
6553 * term.c (term_mouse_position): Rename local to avoid shadowing.
6554
e6ca6543
PE
6555 * alloc.c (mark_ttys): Move decl from here ...
6556 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6557
c40f8d15
AS
65582011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6559
6560 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6561
cfe0661d
JB
65622011-03-09 Juanma Barranquero <lekktu@gmail.com>
6563
6564 * search.c (compile_pattern_1): Remove argument regp, unused since
6565 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6566 (compile_pattern): Don't pass it.
6567
0afb4571
J
65682011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6569
6570 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6571 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6572 for ! HAVE_GTK3.
6573 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6574
6575 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6576
6577 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6578 gdk_window_get_screen, gdk_window_get_geometry,
6579 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6580 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6581 (xg_get_pixbuf_from_pixmap): New function.
6582 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6583 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6584 Call xg_get_pixbuf_from_pixmap instead of
6585 gdk_pixbuf_get_from_drawable.
6586 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6587 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6588 (xg_check_special_colors): Use GtkStyleContext and its functions
6589 for HAVE_GTK3.
6590 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6591 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6592 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6593 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6594 Call gtk_widget_get_preferred_size.
0afb4571
J
6595 (xg_frame_resized): gdk_window_get_geometry only takes 5
6596 parameters.
44f230aa
SM
6597 (xg_win_to_widget, xg_event_is_for_menubar):
6598 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6599 (xg_set_widget_bg): New function.
6600 (delete_cb): New function.
895009e1 6601 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6602 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6603 (xg_set_background_color): Call xg_set_widget_bg.
6604 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6605 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6606 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6607 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6608 if ! HAVE_GTK3.
6609 (update_frame_tool_bar): Call gtk_widget_hide.
6610 (xg_initialize): Use GDK_KEY_g.
6611
6612 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6613 if ! HAVE_GTK3
6614 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6615
6616 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6617 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6618 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6619
1c2cc4ef
JB
66202011-03-08 Juanma Barranquero <lekktu@gmail.com>
6621
6622 * w32xfns.c (select_palette): Check success of RealizePalette against
6623 GDI_ERROR, not zero.
6624
33383987 6625See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6626
6627;; Local Variables:
6628;; coding: utf-8
aac0c6e3
MR
6629;; End:
6630
33383987 6631 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6632
6633 This file is part of GNU Emacs.
6634
6635 GNU Emacs is free software: you can redistribute it and/or modify
6636 it under the terms of the GNU General Public License as published by
6637 the Free Software Foundation, either version 3 of the License, or
6638 (at your option) any later version.
6639
6640 GNU Emacs is distributed in the hope that it will be useful,
6641 but WITHOUT ANY WARRANTY; without even the implied warranty of
6642 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6643 GNU General Public License for more details.
6644
6645 You should have received a copy of the GNU General Public License
6646 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.