* alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
[bpt/emacs.git] / src / ChangeLog
CommitLineData
28be1ada
DA
12012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
4 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6 access to `contents' member of Lisp_Vector objects with AREF and ASET
7 where appropriate.
8
c6bf3022
CY
92012-06-19 Chong Yidong <cyd@gnu.org>
10
11 * frame.c (delete_frame): When selecting a frame on a different
12 text terminal, do not alter the terminal's top-frame.
13
14 * xdisp.c (format_mode_line_unwind_data): Record the target
15 frame's selected window and its terminal's top-frame.
16 (unwind_format_mode_line): Restore them.
17 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
18 Callers changed.
19 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
20 since tty frames can be explicitly named.
21 (prepare_menu_bars): Likewise.
22
23 * term.c (Ftty_top_frame): New function.
24
defd4196
PE
252012-06-18 Paul Eggert <eggert@cs.ucla.edu>
26
27 Port byte-code-meter to modern targets.
28 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
29 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
30 CHECK_LISP_OBJECT_TYPE reported by Dmitry Andropov in
31 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
32 (METER_1, METER_2): Simplify.
33
1053a871
SM
342012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
35
36 * data.c (Fdefalias): Return `symbol' (bug#11686).
37
b7e8d081
MR
382012-06-18 Martin Rudalics <rudalics@gmx.at>
39
40 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
41 gets killed during executing of this function (Bug#11665).
42 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
43 (Vkill_buffer_query_functions): In doc-string say that functions
44 run by this hook should not change the current buffer.
45
7ea2b339
PE
462012-06-18 Paul Eggert <eggert@cs.ucla.edu>
47
48 Fix recently-introduced process.c problems found by static checking.
49 * process.c (write_queue_push, write_queue_pop, send_process):
50 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
51 (write_queue_pop): Fix pointer signedness problem.
52 (send_process): Remove unused local.
53
96a313a1
CY
542012-06-17 Chong Yidong <cyd@gnu.org>
55
56 * xdisp.c (redisplay_internal): No need to redisplay terminal
57 frames that are not on top.
58
20ca2e94
TN
592012-06-17 Troels Nielsen <bn.troels@gmail.com>
60
61 * process.c (make_process): Initialize write_queue.
62 (write_queue_push, write_queue_pop): New functions.
63 (send_process): Use them to maintain correct ordering of process
64 writes (Bug#10815).
65
9a900ca9
PE
662012-06-17 Paul Eggert <eggert@cs.ucla.edu>
67
310fbfa8
PE
68 * lisp.h (eassert): Assume C89 or later.
69 This removes the need for CHECK.
70 (CHECK): Remove. Its comments about always evaluating its
71 argument were confusing, as 'eassert' typically does not evaluate
72 its argument.
73
27bb1ca4
PE
74 * coding.c (produce_chars): Use ptrdiff_t, not int.
75
9a900ca9
PE
76 * xterm.c (x_draw_underwave): Check for integer overflow.
77 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
78
41b7f8bc 792012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
80
81 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
82 referenced (Bug#11583).
83
9b0e3eba
AA
842012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
85
86 Implement wave-style variant of underlining.
87 * dispextern.h (face_underline_type): New enum.
88 (face): Add field for underline type.
89 * nsterm.m (ns_draw_underwave): New function.
90 (ns_draw_text_decoration): Use it.
91 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
92 New functions.
93 (x_draw_glyph_string): Use them.
94 * xfaces.c (Qline, Qwave): New Lisp objects.
95 (check_lface_attrs, merge_face_ref)
1053a871
SM
96 (Finternal_set_lisp_face_attribute, realize_x_face):
97 Handle wave-style underline face attributes.
9b0e3eba
AA
98 * xterm.c (x_draw_underwave): New function.
99 (x_draw_glyph_string): Use it.
100
0fb52f11
JB
1012012-06-16 Juanma Barranquero <lekktu@gmail.com>
102
103 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
104 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
105 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
106 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
107 ($(BLD)/w32select.$(O)): Update dependencies.
108
e5560ff7
AS
1092012-06-16 Andreas Schwab <schwab@linux-m68k.org>
110
111 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
112 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
113 * character.c (_fetch_multibyte_char_p): Remove.
114 * alloc.c: Include "character.h" before "buffer.h".
115 * bidi.c: Likewise.
116 * buffer.c: Likewise.
117 * bytecode.c: Likewise.
118 * callint.c: Likewise.
119 * callproc.c: Likewise.
120 * casefiddle.c: Likewise.
121 * casetab.c: Likewise.
122 * category.c: Likewise.
123 * cmds.c: Likewise.
124 * coding.c: Likewise.
125 * composite.c: Likewise.
126 * dired.c: Likewise.
127 * dispnew.c: Likewise.
128 * doc.c: Likewise.
129 * dosfns.c: Likewise.
130 * editfns.c: Likewise.
131 * emacs.c: Likewise.
132 * fileio.c: Likewise.
133 * filelock.c: Likewise.
134 * font.c: Likewise.
135 * fontset.c: Likewise.
136 * fringe.c: Likewise.
137 * indent.c: Likewise.
138 * insdel.c: Likewise.
139 * intervals.c: Likewise.
140 * keyboard.c: Likewise.
141 * keymap.c: Likewise.
142 * lread.c: Likewise.
143 * macros.c: Likewise.
144 * marker.c: Likewise.
145 * minibuf.c: Likewise.
146 * nsfns.m: Likewise.
147 * nsmenu.m: Likewise.
148 * print.c: Likewise.
149 * process.c: Likewise.
150 * regex.c: Likewise.
151 * region-cache.c: Likewise.
152 * search.c: Likewise.
153 * syntax.c: Likewise.
154 * term.c: Likewise.
155 * textprop.c: Likewise.
156 * undo.c: Likewise.
157 * unexsol.c: Likewise.
158 * w16select.c: Likewise.
159 * w32fns.c: Likewise.
160 * w32menu.c: Likewise.
161 * window.c: Likewise.
162 * xdisp.c: Likewise.
163 * xfns.c: Likewise.
164 * xmenu.c: Likewise.
165 * xml.c: Likewise.
166 * xselect.c: Likewise.
167
2f07e6af
EZ
1682012-06-16 Eli Zaretskii <eliz@gnu.org>
169
1053a871
SM
170 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
171 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 172 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
173 row.
174 (handle_face_prop): Use chunk-relative overlay string index when
175 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
176 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
177 the rightmost. (Bug#11720)
2f07e6af 178
29b83cec
AS
1792012-06-16 Andreas Schwab <schwab@linux-m68k.org>
180
181 * category.h (CHAR_HAS_CATEGORY): Define as inline.
182 (CATEGORY_MEMBER): Enforce 1/0 value.
183 * category.c (_temp_category_set): Remove.
184
4c5501e9
EZ
1852012-06-16 Eli Zaretskii <eliz@gnu.org>
186
187 * window.c (Fdelete_other_windows_internal)
188 (Fdelete_window_internal): Don't access frame's mouse highlight
189 info of the initial frame. (Bug#11677)
190
2b570124
PE
1912012-06-14 Paul Eggert <eggert@cs.ucla.edu>
192
e93864f9
PE
193 * .gdbinit (xgetint): Fix recently-introduced paren typo.
194 Assume USE_2_TAGS_FOR_INTS.
195 (xreload): Adjust $tagmask width to match recent lisp.h change.
196
2b570124
PE
197 Simplify lisp.h in minor ways that should not affect code.
198 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
199 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
200 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
201 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
202 (INTTYPEBITS): New macro, for clarity.
203 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
204 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
205 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
206 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
207 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
208
81755f69
JB
2092012-06-13 Juanma Barranquero <lekktu@gmail.com>
210
211 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
212
16192a57
GM
2132012-06-13 Glenn Morris <rgm@gnu.org>
214
215 * s/bsd-common.h (BSD4_3):
216 * s/usg5-4-common.h (USG5_4): No longer define; unused.
217
646b5f55
AS
2182012-06-13 Andreas Schwab <schwab@linux-m68k.org>
219
220 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
221 instead of union.
222 (XLI, XIL): Define.
1053a871
SM
223 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
224 Use them.
225 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 226 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 227 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
228 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
229 * frame.c (delete_frame): Remove outdated comment.
230 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
231 USE_LISP_UNION_TYPE.
232 (Fw32_unregister_hot_key): Likewise.
233 (Fw32_toggle_lock_key): Likewise.
234 * w32menu.c (add_menu_item): Likewise.
235 (w32_menu_display_help): Use XIL instead of checking
236 USE_LISP_UNION_TYPE.
237 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
238 (init_heap): Likewise.
239 * w32term.c (w32_read_socket): Update comment.
240
1d3823c9
GM
2412012-06-13 Glenn Morris <rgm@gnu.org>
242
c62ff706
GM
243 * s/usg5-4-common.h, src/s/unixware.h:
244 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
245
1d3823c9
GM
246 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
247
bfe3e0a2
PE
2482012-06-13 Paul Eggert <eggert@cs.ucla.edu>
249
250 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
251 * alloc.c (make_number) [!defined make_number]:
252 Remove, as lisp.h always defines this now.
253 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
254 (roundup_size): Verify that it is a power of 2.
255 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
256 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
257 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
258 -DUSE_LSB_TAG=0, to override the automatically-selected default.
259 USE_LSB_TAG now is always defined to be either 0 or 1.
260 All uses changed.
261 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
262 code works fine either way, and efficiency is not a concern here,
263 as the union type is for debugging, not for production.
264 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
265 Use an inline function on all platforms when using the union type,
266 since this is simpler and 'static inline' can be used portably
267 within Emacs now.
268 (LISP_INITIALLY_ZERO): New macro.
269 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
270 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
271
45fa9c0f
GM
2722012-06-12 Glenn Morris <rgm@gnu.org>
273
b4492cba
GM
274 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
275
276 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 277
45fa9c0f
GM
278 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
279 Move BROKEN_SIGIO to configure.
280
281 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
282 Move NO_TERMIO to configure.
283
0e25d334
CY
2842012-06-12 Chong Yidong <cyd@gnu.org>
285
286 * image.c (imagemagick_load_image): Use MagickFlattenImage if
287 MagickMergeImageLayers is undefined. Use pixel pusher loop if
288 MagickExportImagePixels is undefined.
289
43682bb6
PE
2902012-06-12 Paul Eggert <eggert@cs.ucla.edu>
291
292 * image.c (imagemagick_load_image): Remove unused label.
293
a9be7d2b
GM
2942012-06-11 Glenn Morris <rgm@gnu.org>
295
296 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
297 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
298 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
299 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
300
3017f87f
SM
3012012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
302
303 * alloc.c (make_byte_code): New function.
304 (Fmake_byte_code): Use it. Don't purify here.
305 * lread.c (read1): Use it as well to avoid extra allocation.
306
1b9b4cf4
CY
3072012-06-11 Chong Yidong <cyd@gnu.org>
308
309 * image.c (imagemagick_load_image): Implement transparency.
310
95988fcf
AS
3112012-06-10 Andreas Schwab <schwab@linux-m68k.org>
312
313 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
314 account for preceding backslashes. (Bug#11663)
315
cd4eb164
CY
3162012-06-09 Chong Yidong <cyd@gnu.org>
317
318 * term.c: Support italics in capable terminals (Bug#9652).
319 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
320 (turn_on_face): Output using TS_enter_italic_mode if available.
321 Don't handle unused blinking and alt-charset cases.
322 (turn_off_face): Handle italic case; discard unused tty_blinking_p
323 and tty_alt_charset_p cases.
324 (tty_capable_p, init_tty): Support italics.
325
326 * termchar.h (struct tty_display_info): Add field for italics.
327 Remove unused blink field.
328
329 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
330 Handle slant.
331
332 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
333 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
334 tty_alt_charset_p. Add tty_italic_p.
335
ff88beb8
MA
3362012-06-09 Michael Albinus <michael.albinus@gmx.de>
337
338 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
339 dbus_type_is_basic if available.
340 (xd_extract_signed, xd_extract_unsigned): Rename from
341 extract_signed and extract_unsigned, respectively. Adapt callers.
342
44286096
CY
3432012-06-09 Chong Yidong <cyd@gnu.org>
344
1682701f
CY
345 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
346
44286096
CY
347 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
348 case (Bug#9752).
349
d86feb17
PE
3502012-06-08 Paul Eggert <eggert@cs.ucla.edu>
351
352 * xdisp.c (vmessage): Treat frame message as multibyte.
353 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
354 would generate the diagnostic "Making \302\247 buffer-local while
355 let-bound!".
356
d5c20fe8
EZ
3572012-06-08 Eli Zaretskii <eliz@gnu.org>
358
359 * dispnew.c (showing_window_margins_p): Undo last change, which
360 was done due to an inadvertent commit.
361 (adjust_frame_glyphs_for_frame_redisplay): Do call
362 showing_window_margins_p.
363
513749ee
SM
3642012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
365
366 * eval.c (Fmake_var_non_special): New primitive.
367 (syms_of_eval): Defsubr it.
368 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
369
d4a8f5c1
JB
3702012-06-08 Juanma Barranquero <lekktu@gmail.com>
371
372 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
373 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
374
8bbbc977
EZ
3752012-06-08 Eli Zaretskii <eliz@gnu.org>
376
377 * alloc.c (allocate_vectorlike): Fix last change.
378
f3372c87
DA
3792012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
380
381 Block-based vector allocation of small vectors.
382 * lisp.h (struct vectorlike_header): New field `nbytes',
383 adjust comment accordingly.
384 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
385 to denote vector blocks. Adjust users (live_vector_p,
386 mark_maybe_pointer, valid_lisp_object_p) accordingly.
387 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
388 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
389 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
390 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
391 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
392 (roundup_size): New constant.
393 (struct vector_block): New data type.
394 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 395 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
396 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
397 (sweep_vectors): New functions.
398 (allocate_vectorlike): Return `zero_vector' as the only vector of
399 0 items. Allocate new vector from block if vector size is less than
400 or equal to VBLOCK_BYTES_MAX.
401 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
402 (init_alloc_once): Add call to init_vectors.
403
4f18a4ed
SM
4042012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
405
406 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
407
86f158bc
PE
4082012-06-07 Paul Eggert <eggert@cs.ucla.edu>
409
410 * doprnt.c (doprnt): Truncate multibyte char correctly.
411 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
412 would mishandle a string argument "Xc" if X was a multibyte
413 character of length 2: it would truncate after X's first byte
414 rather than including all of X.
415
c5cfcbe0
CY
4162012-06-06 Chong Yidong <cyd@gnu.org>
417
418 * buffer.c (word_wrap): Doc fix.
419
c05cf390
PE
4202012-06-04 Paul Eggert <eggert@cs.ucla.edu>
421
422 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
423
0c3461de
GM
4242012-06-03 Glenn Morris <rgm@gnu.org>
425
426 * xdisp.c (tool-bar-style): Doc fix.
427
c71232db
UM
4282012-06-03 Ulrich Müller <ulm@gentoo.org>
429
430 * Makefile.in (PAXCTL): Define.
431 (temacs$(EXEEXT)): Disable memory randomization for the temacs
432 binary via PaX flags if the paxctl utility is available.
433 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
434 Restore PaX flags to their default. (Bug#11398)
435
383f7350
CY
4362012-06-03 Chong Yidong <cyd@gnu.org>
437
438 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
439 buffer (Bug#11226).
440
5f2c76c6
CY
4412012-06-03 Chong Yidong <cyd@gnu.org>
442
443 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
444 (note_mode_line_or_margin_highlight): If there is no help echo,
445 use mode-line-default-help-echo. Handle the case where the mouse
446 position is past the end of the mode line string.
447
448 * buffer.c (buffer_local_value_1): New function, split from
449 Fbuffer_local_value; can return Qunbound.
450 (Fbuffer_local_value): Use it.
451 (Vmode_line_format): Docstring tweaks.
452
773d47f6
PE
4532012-06-02 Paul Eggert <eggert@cs.ucla.edu>
454
455 * sysdep.c (system_process_attributes): Improve comment.
456
f2d6a3df
SM
4572012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
458
459 * keyboard.c: Export real-this-command to Elisp.
460 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
461 and DEFVAR it. Update all users.
462
63810350
PE
4632012-06-02 Paul Eggert <eggert@cs.ucla.edu>
464
7bd5c1f4
PE
465 * minibuf.c (Fassoc_string): Remove duplicate declaration.
466
63810350
PE
467 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
468 Convert pctcpu and pctmem to Lisp float properly.
469 Let the compiler fold better, as 100.0/0x8000 is exact.
470
a2821611
AS
4712012-06-02 Andreas Schwab <schwab@linux-m68k.org>
472
473 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
474 cons_block.
475
5fceba1d
PE
4762012-06-01 Paul Eggert <eggert@cs.ucla.edu>
477
478 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
479
c98ff5dd
DA
4802012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
481
482 For a 'struct window', replace some Lisp_Object fields to
483 bitfields where appropriate, remove unused fields.
484 * window.h (struct window): Remove unused 'last_mark_x' and
485 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
486 change it's type from Lisp_Object to bitfield.
487 Change type of 'force_start', 'optional_new_start',
488 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
489 fields from Lisp_Object to bitfield. Adjust users accordingly.
490
ca34e0be
PE
4912012-05-31 Paul Eggert <eggert@cs.ucla.edu>
492
493 Pacify gcc -Wdouble-precision when using Xaw.
494 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
495 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
496 Use 'float' consistently, rather than 'float' in most places
497 and 'double' in a couple of places.
498
efc00ab1 4992012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
500
501 * xdisp.c (handle_stop): Detect whether we have overlay strings
502 loaded by testing it->current.overlay_string_index to be
503 non-negative, instead of checking whether n_overlay_strings is
504 positive. (Bug#11587)
505
efc00ab1 5062012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
507
508 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
509
510 * doc.c (Fsubstitute_command_keys): Doc fix.
511
efc00ab1 5122012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
513
514 * search.c (search_buffer): Remove calls to
515 r_alloc_inhibit_buffer_relocation, as it is now called by
516 maybe_unify_char, which was the cause of relocation of buffer text
517 in bug#11519.
518
efc00ab1 5192012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
520
521 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
522 for the duration of call to load_charset, to avoid problems with
523 callers of maybe_unify_char that access buffer text through C
524 pointers.
525
526 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
527 decrement the inhibition flag, instead of just setting or
528 resetting it.
529
ba93a187
PE
5302012-05-31 Paul Eggert <eggert@cs.ucla.edu>
531
532 Remove obsolete '#define static' cruft.
533 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
534 This #undef was "temporary" in 2000; it is no longer needed
535 now that '#define static' has gone away.
536 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
537 (gray_bitmap_bits): Remove; no longer needed.
538 All uses replaced with definiens.
539 * xterm.c: Include "bitmaps/gray.xbm".
540
9e4bf381
PE
5412012-05-30 Paul Eggert <eggert@cs.ucla.edu>
542
543 Clean up __executable_start, monstartup when --enable-profiling.
544 The following changes affect the code only when profiling.
545 * dispnew.c (__executable_start): Rename from safe_bcopy.
546 Define only on platforms that need it.
547 * emacs.c: Include <sys/gmon.h> when profiling.
548 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
549 (__executable_start): Remove decl, since lisp.h does it now.
550 (safe_bcopy): Remove decl; no longer has that name.
551 (main): Coalesce #if into single bit of code, for simplicity.
552 Cast pointers to uintptr_t, since standard libraries want integers
553 and not pointers.
554 * lisp.h (__executable_start): New decl.
555
32d72c2f
GM
5562012-05-31 Glenn Morris <rgm@gnu.org>
557
558 * image.c (Fimagemagick_types): Doc fix.
559
baac5bc7
JM
5602012-05-30 Jim Meyering <meyering@redhat.com>
561
562 * callproc.c (Fcall_process_region): Include directory component
563 in mkstemp error message (Bug#11586).
564
72cb32cf
PE
5652012-05-30 Paul Eggert <eggert@cs.ucla.edu>
566
567 * alloc.c, lisp.h (make_pure_vector): Now static.
568
61b108cc
SM
5692012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
570
571 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
572 Move to byte-run.el.
573 (Fautoload): Do the hash-doc more carefully.
574 * data.c (Fdefalias): Purify definition, except for keymaps.
575 (Qdefun): Move from eval.c.
576 * lisp.h (Qdefun): Remove.
577 * lread.c (read1): Tiny simplification.
578
471fe23d
TN
5792012-05-29 Troels Nielsen <bn.troels@gmail.com>
580
934f3f58 581 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
582 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
583 Bug#9642, but explicitly check that the buffer the overlay would
584 be moved to is live and rearrange lines to make sure that errors
585 will not put the overlay in an inconsistent state.
586 (Fdelete_overlay): Cosmetics.
587
85d0efd1
EZ
5882012-05-28 Eli Zaretskii <eliz@gnu.org>
589
590 * w32term.c (my_bring_window_to_top): New function.
591 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
592 could be different from the original one.
593 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
594 (Bug#11513)
595
596 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
597 by calling BringWindowToTop.
598
599 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
600 (WM_EMACS_END): Increase by one.
601
da92a98c
PE
6022012-05-28 Paul Eggert <eggert@cs.ucla.edu>
603
604 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
605 This avoids undefined behavior that might cause the eassert
606 to not catch an out-of-range value.
607
74d1f848
JB
6082012-05-28 Juanma Barranquero <lekktu@gmail.com>
609
610 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
611 Update dependencies.
612
9e1a06fc
EZ
6132012-05-27 Eli Zaretskii <eliz@gnu.org>
614
615 * bidi.c (bidi_mirror_char): Fix last change.
616
f3dd7312
AS
6172012-05-27 Andreas Schwab <schwab@linux-m68k.org>
618
619 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
620 when referring to sectname field in printf format.
621
81899c91
PE
6222012-05-27 Paul Eggert <eggert@cs.ucla.edu>
623
57b81a9f
PE
624 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
625 Only r_alloc_inhibit_buffer_relocation needed to be added;
626 the others were already declared.
627
81899c91
PE
628 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
629 before checking whether it's out of range. Put the check inside
630 eassert. See
631 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
632
33017faf 6332012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
634
635 * callproc.c (Fcall_process): Restore a line that was accidentally
636 commented out in the 2011-02-13 change (bug#11547).
637
33017faf 6382012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
639
640 * lisp.h [REL_ALLOC]: Add prototypes for external functions
641 defined on ralloc.c.
642
643 * buffer.c [REL_ALLOC]: Remove prototypes of
644 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
645 they are now on lisp.h.
646
647 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
648
649 * search.c (search_buffer): Use it to inhibit relocation of buffer
650 text while re_search_2 is doing its job, because re_search_2 is
651 passed C pointers to buffer text. (Bug#11519)
652
23415acf
EZ
653 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
654 Update value to 24.
655
44e27368
EZ
656 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
657 state after an additional call to move_it_in_display_line_to, keep
658 the values of it->max_ascent and it->max_descent found for the
659 entire line.
660 (pos_visible_p): Revert the comparison against bottom_y to what it
661 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
662 (Bug#11464)
663
c1892f11
PE
6642012-05-26 Paul Eggert <eggert@cs.ucla.edu>
665
666 Fix coding-related core dumps with gcc -ftrapv.
667 The code was computing A - B, where A and B are pointers, and B is
668 random garbage. This can lead to core dumps on platforms that
669 have special pointer registers, and it also leads to core dumps on
670 x86-64 when compiled with gcc -ftrapv. The fix is to compute
671 A - B only when B is initialized properly.
672 * coding.c (coding_set_source, coding_set_destination): Return void.
673 (coding_change_source, coding_change_destinations): New functions,
674 with the old behaviors of coding_set_source and coding_set_destination.
675 All callers that need an offset changed to use these new functions.
676
eb7afdad
GM
6772012-05-26 Glenn Morris <rgm@gnu.org>
678
679 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
680
f12fdf02
EZ
6812012-05-26 Eli Zaretskii <eliz@gnu.org>
682
53a63be6 683 Extend mouse support on W32 text-mode console.
61b108cc
SM
684 * xdisp.c (draw_row_with_mouse_face):
685 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 686
eb3f6f01 687 * w32console.c: Include window.h.
61b108cc
SM
688 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
689 New functions.
eb3f6f01
EZ
690 (initialize_w32_display): Initialize mouse-highlight data.
691
53a63be6
EZ
692 * w32inevt.c: Include termchar.h and window.h.
693 (do_mouse_event): Support mouse-autoselect-window. When the mouse
694 moves, call note_mouse_highlight. If help_echo changed, call
695 gen_help_event to produce help-echo message in the echo area.
696 Call clear_mouse_face if mouse_face_hidden is set in the mouse
697 highlight info.
698
4cfd81f6
PE
6992012-05-26 Paul Eggert <eggert@cs.ucla.edu>
700
701 * lread.c (read1): Simplify slightly to avoid an overflow warning
702 with GCC 4.7.0 on x86-64.
703
4446092a
EZ
7042012-05-26 Eli Zaretskii <eliz@gnu.org>
705
706 * bidi.c (bidi_mirror_char): Revert last change: an int is
707 definitely wide enough here.
708
42b2a986 7092012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 710
42b2a986 711 Fix integer width and related bugs (Bug#9874).
eb106a49 712 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
713 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
714 (string_bytes, check_sblock, allocate_string_data):
715 (compact_small_strings, Fmake_bool_vector, make_string)
716 (make_unibyte_string, make_multibyte_string)
717 (make_string_from_bytes, make_specified_string)
718 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
719 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
720 (mark_vectorlike):
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
722 (allocate_pseudovector):
723 Use int, not EMACS_INT, where int is wide enough.
724 (inhibit_garbage_collection, Fgarbage_collect):
725 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
726 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
727 int might not be wide enough.
728 (bidi_cache_search, bidi_cache_find, bidi_init_it)
729 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
730 (bidi_at_paragraph_end, bidi_find_paragraph_start)
731 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
732 (bidi_level_of_next_char, bidi_move_to_visually_next):
733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
734 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
735 (Fkill_buffer, Fset_buffer_major_mode)
736 (advance_to_char_boundary, Fbuffer_swap_text)
737 (Fset_buffer_multibyte, overlays_at, overlays_in)
738 (overlay_touches_p, struct sortvec, record_overlay_string)
739 (overlay_strings, recenter_overlay_lists)
740 (adjust_overlays_for_insert, adjust_overlays_for_delete)
741 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
742 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
743 (Foverlay_recenter, last_overlay_modification_hooks_used)
744 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
746 (validate_region): Omit unnecessary test for b <= e,
747 since that's guaranteed by the previous test.
d311d28c
PE
748 (adjust_overlays_for_delete): Avoid pos + length overflow.
749 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
750 (report_overlay_modification):
751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
752 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
753 Omit pointer cast, which isn't needed anyway, and doesn't work
754 after the EMACS_INT -> ptrdiff_t change.
02481186 755 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
756 * buffer.h: Adjust decls to match defn changes elsewhere.
757 (struct buffer_text, struct buffer):
758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
759 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
760 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
761 not int, to avoid needless 32-bit limit on 64-bit hosts.
762 (exec_byte_code): Use tighter memory-full test, one that checks
763 for alloca overflow. Don't compute the address of the object just
764 before an array, as that's not portable. Use EMACS_INT, not
765 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
766 * callint.c (Fcall_interactively):
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 * callproc.c (call_process_kill, Fcall_process):
769 Don't assume pid_t fits into an Emacs fixnum.
770 (call_process_cleanup, Fcall_process, child_setup):
771 Don't assume pid_t fits into int.
772 (call_process_cleanup, Fcall_process, delete_temp_file)
773 (Fcall_process_region):
774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
775 (Fcall_process): Simplify handling of volatile integers.
776 Use int, not EMACS_INT, where int will do.
777 * casefiddle.c (casify_object, casify_region, operate_on_word)
778 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
780 (casify_object): Avoid integer overflow when overallocating buffer.
781 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 782 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
783 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
784 * category.h (CATEGORYP): Don't assume arg is nonnegative.
785 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
786 integers are now checked earlier. All uses replaced with XINT.
787 (ccl_driver):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
790 (ccl_driver, Fregister_code_conversion_map):
791 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
792 (resolve_symbol_ccl_program): Check that vector header is in range.
793 Always copy the vector, so that we can check its contents reliably
794 now rather than having to recheck each instruction as it's being
795 executed. Check that vector words fit in 'int'.
796 (ccl_get_compiled_code, Fregister_ccl_program)
797 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
798 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
799 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
800 contents are in range.
801 (Fccl_execute_on_string): Check that status is in range.
802 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
803 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
804 Accept and return EMACS_INT, not int, because callers can pass values
805 out of 'int' range.
806 (c_string_width, strwidth, lisp_string_width, chars_in_text)
807 (multibyte_chars_in_text, parse_str_as_multibyte)
808 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
809 (str_as_unibyte, str_to_unibyte, string_count_byte8)
810 (string_escape_byte8, Fget_byte):
811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 812 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
813 avoid mishandling large integers.
814 * character.h: Adjust decls to match defn changes elsewhere.
815 * charset.c (load_charset_map_from_file, find_charsets_in_text)
816 (Ffind_charset_region):
817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
818 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
819 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 820 Don't assume fixnum fits in int.
d311d28c
PE
821 (load_charset_map_from_vector, Fmap_charset_chars):
822 Remove now-unnecessary CHECK_NATNUMs.
823 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
824 Don't rely on undefined behavior with signed left shift overflow.
825 Don't assume unsigned int fits into fixnum, or that fixnum fits
826 into unsigned int. Don't require max_code to be a valid fixnum;
827 that's not true for gb10830 4-byte on a 32-bit host. Allow
828 invalid_code to be a cons, for the same reason. Require code_offset
829 to be a character. Avoid int overflow if max_char is close
830 to INT_MAX.
831 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
832 this is intended anyway and avoids some undefined behavior.
833 (load_charset_map): Pass unsigned, not int, as 2nd arg of
834 INDEX_TO_CODE_POINT, as that's what it expects.
835 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
836 * charset.h (DECODE_CHAR): Return int, not unsigned;
837 this is what was intended anyway, and it avoids undefined behavior.
838 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
839 integer-overflow issues.
840 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
841 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
842 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
843 * chartab.c (Fmake_char_table, Fset_char_table_range)
844 (uniprop_get_decoder, uniprop_get_encoder):
845 Don't assume fixnum fits in int.
846 * cmds.c (move_point): New function, that does the gist of
847 Fforward_char and Fbackward_char, but does so while checking
848 for integer overflow more accurately.
c96e5d6a 849 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
850 (Fforward_line, Fend_of_line, internal_self_insert)
851 (internal_self_insert):
852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
853 Fix a FIXME, by checking for integer overflow when calculating
854 target_clm and actual_clm.
855 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 856 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
857 (ASSURE_DESTINATION, coding_alloc_by_realloc)
858 (coding_alloc_by_making_gap, alloc_destination)
859 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
860 (encode_coding_utf_16, detect_coding_emacs_mule)
861 (decode_coding_emacs_mule, encode_coding_emacs_mule)
862 (detect_coding_iso_2022, decode_coding_iso_2022)
863 (encode_invocation_designation, encode_designation_at_bol)
864 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
865 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
866 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
867 (encode_coding_ccl, encode_coding_raw_text)
868 (detect_coding_charset, decode_coding_charset)
869 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
870 (produce_composition, produce_charset, produce_annotation)
871 (decode_coding, handle_composition_annotation)
872 (handle_charset_annotation, consume_chars, decode_coding_gap)
873 (decode_coding_object, encode_coding_object, detect_coding_system)
874 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
875 (code_convert_region, code_convert_string)
8f50130c
PE
876 (Fdefine_coding_system_internal)
877 (coding_set_source, coding_set_destination):
d311d28c
PE
878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
879 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
880 (Fdefine_coding_system_internal):
881 Don't assume fixnums fit in int.
882 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 883 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
884 (Funencodable_char_position, Fcheck_coding_systems_region)
885 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 887 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 888 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 889 Don't access memory outside of the args array.
d311d28c 890 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
891 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
892 result of ENCODE_CHAR.
d311d28c
PE
893 * coding.h: Adjust decls to match defn changes elsewhere.
894 (struct coding_system):
895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
896 * composite.c (get_composition_id, find_composition)
897 (run_composition_function, update_compositions)
898 (compose_text, composition_gstring_put_cache)
899 (composition_gstring_p, composition_gstring_width)
900 (fill_gstring_header, fill_gstring_body, autocmp_chars)
901 (composition_compute_stop_pos, composition_reseat_it)
902 (composition_update_it, struct position_record)
903 (find_automatic_composition, composition_adjust_point)
904 (Fcomposition_get_gstring, Ffind_composition_internal):
905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
906 (update_compositions):
907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
908 * composite.h: Adjust decls to match defn changes elsewhere.
909 (struct composition):
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
912 Do not attempt to compute the address of the object just before a
913 buffer; this is not portable.
914 (Faref, Faset):
915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
916 (Faset): Use int, not EMACS_INT, where int is wide enough.
917 (Fstring_to_number): Don't assume fixnums fit in int.
918 (Frem): Don't assume arg is nonnegative.
919 * dbusbind.c (xd_append_arg): Check for integers out of range.
920 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 921 (extract_signed, extract_unsigned): New functions.
243e0530
PE
922 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
923 (xd_get_connection_references): Return ptrdiff_t, not int.
924 All uses changed.
925 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
926 (xd_read_message_1):
927 Use int, not unsigned, where the dbus API uses int.
928 (Fdbus_message_internal): Don't overflow mtype.
929 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
930 * dired.c (directory_files_internal, file_name_completion, scmp)
931 (file_name_completion_stat):
932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
933 (file_name_completion): Don't overflow matchcount.
934 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
935 * dispextern.h: Adjust decls to match defn changes elsewhere.
936 (struct text_pos, struct glyph, struct bidi_saved_info)
937 (struct bidi_string_data, struct bidi_it, struct composition_it)
938 (struct it):
939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
940 (struct display_pos, struct composition_it, struct it):
941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
942 * dispnew.c (increment_matrix_positions)
943 (increment_row_positions, mode_line_string)
944 (marginal_area_string):
945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 946 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
948 (duration_to_sec_usec): New function, to check for overflow better.
949 (Fsleep_for, sit_for): Use it.
950 * doc.c (get_doc_string, store_function_docstring):
951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
952 (get_doc_string, Fsnarf_documentation):
953 Use int, not EMACS_INT, where int is wide enough.
954 (get_doc_string):
955 Use SAFE_ALLOCA, not alloca.
956 Check for overflow when converting EMACS_INT to off_t.
957 * doprnt.c (doprnt):
958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
959 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
960 Don't assume uid_t fits into fixnum.
961 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
962 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
963 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
964 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
965 (general_insert_function)
966 (Finsert_char, make_buffer_string, make_buffer_string_both)
967 (update_buffer_properties, Fbuffer_substring)
968 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
969 (Fsubst_char_in_region, check_translation)
970 (Ftranslate_region_internal, save_restriction_restore, Fformat)
971 (transpose_markers, Ftranspose_regions):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
973 (clip_to_bounds): Move to lisp.h as an inline function).
974 (Fconstrain_to_field): Don't assume integers are nonnegative.
975 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
976 (Fsubst_char_in_region, Fsave_restriction):
977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
978 (Femacs_pid): Don't assume pid_t fits into fixnum.
979 (lo_time): Use int, not EMACS_INT, when int suffices.
980 (lisp_time_argument): Check for usec out of range.
981 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
982 (Fuser_login_name, Fuser_full_name): Signal an error
983 if a uid argument is out of range, rather than relying on
984 undefined behavior.
c8d5c857
PE
985 (Fformat_time_string): Remove now-unnecessary check.
986 lisp_time_argument checks for out-of-range usec now.
243e0530 987 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
988 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
989 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
990 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
991 (init_cmdargs, Fdump_emacs):
992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
993 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
994 the bottom (typically) 32 bits of the fixnum.
995 * eval.c (specpdl_size, call_debugger):
996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
997 (when_entered_debugger, Fbacktrace_debug):
998 Don't assume fixnum can fit in int.
999 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1000 the object just before a buffer; this is not portable.
1001 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1002 (grow_specpdl, unbind_to):
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1004 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1005 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1006 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1007 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1008 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1010 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1011 (a_write, e_write):
1012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1013 (Fcopy_file, non_regular_nbytes, read_non_regular)
1014 (Finsert_file_contents):
1015 Use int, not EMACS_INT, where int is wide enough.
1016 (READ_BUF_SIZE): Verify that it fits in int.
1017 (Finsert_file_contents): Check that counts are in proper range,
1018 rather than assuming fixnums fit into ptrdiff_t etc.
1019 Don't assume fixnums fit into int.
125b3835 1020 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1021 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1022 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1023 (string_char_to_byte, string_byte_to_char)
1024 (string_make_multibyte, string_to_multibyte)
1025 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1026 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1027 (substring_both, Fdelete, internal_equal, Ffillarray)
1028 (Fclear_string, mapcar1)
1029 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1030 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1031 (larger_vector, make_hash_table, maybe_resize_hash_table)
1032 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1033 (Fmaphash, secure_hash):
1034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1035 (concat): Check for string index and length overflow.
1036 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1037 (Frequire):
1038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1039 (larger_vector): New API (vec, incr_min, size_max) replaces old
1040 one (vec, new_size, init). This catches size overflow.
1041 INIT was removed because it was always Qnil.
1042 All callers changed.
1043 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1044 the upper bound on a hash table index size.
1045 (make_hash_table, maybe_resize_hash_table): Use it.
1046 (secure_hash): Computer start_byte and end_byte only after
1047 they're known to be in ptrdiff_t range.
1048 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1049 (Ffont_get_glyphs, Ffont_at):
1050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1051 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1052 (Flist_fonts, Fopen_font):
1053 Don't assume fixnum can fit in int.
1054 (check_gstring): Don't assume index can fit in int.
1055 (font_match_p): Check that fixnum is a character, not a nonnegative
1056 fixnum, since the later code needs to stuff it into an int.
1057 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1058 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1059 conversion overflow issues.
1060 (Fopen_font): Check for integer out of range.
1061 (Ffont_get_glyphs): Don't assume index can fit in int.
1062 * font.h: Adjust decls to match defn changes elsewhere.
1063 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1064 integer overflow.
1065 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1066 printmax_t, where ptrdiff_t is wide enough.
1067 (Finternal_char_font):
1068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1069 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1070 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1071 (Fset_frame_position, x_set_frame_parameters)
1072 (x_set_line_spacing, x_set_border_width)
1073 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1074 Check that fixnums are in proper range for system types.
1075 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1077 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1078 Use SAFE_ALLOCA_LISP, not alloca.
1079 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1080 intptr_t is wide enough.
1081 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1082 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1083 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1084 Check for fixnum out of range.
1085 * ftfont.c (ftfont_list): Don't assume index fits in int.
1086 Check that fixnums are in proper range for system types.
1087 (ftfont_shape_by_flt):
1088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1089 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1091 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1092 Check that fixnums are in proper range for system types.
1093 * gnutls.h: Adjust decls to match defn changes elsewhere.
1094 * gtkutil.c (xg_dialog_run):
1095 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1096 (update_frame_tool_bar):
1097 Check that fixnums are in proper range for system types.
1098 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1099 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1100 * indent.c (last_known_column, last_known_column_point):
1101 (current_column_bol_cache):
1102 (skip_invisible, current_column, check_display_width):
1103 (check_display_width, scan_for_column, current_column_1)
1104 (Findent_to, Fcurrent_indentation, position_indentation)
1105 (indented_beyond_p, Fmove_to_column, compute_motion):
1106 (Fcompute_motion, Fvertical_motion):
1107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1108 (last_known_column_modified): Use EMACS_INT, not int.
1109 (check_display_width):
1110 (Fcompute_motion):
1111 Check that fixnums and floats are in proper range for system types.
1112 (compute_motion): Don't assume index or fixnum fits in int.
1113 (compute_motion, Fcompute_motion):
1114 Use int, not EMACS_INT, when it is wide enough.
1115 (vmotion): Omit local var start_hpos that is always 0; that way
1116 we don't need to worry about overflow in expressions involving it.
1117 * indent.h: Adjust decls to match defn changes elsewhere.
1118 (struct position):
1119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1120 Use int, not EMACS_INT, where int is wide enough.
1121 Remove unused members ovstring_chars_done and tab_offset;
1122 all uses removed.
1123 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1124 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1125 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1126 (make_gap, copy_text, insert, insert_and_inherit)
1127 (insert_before_markers, insert_before_markers_and_inherit)
1128 (insert_1, count_combining_before, count_combining_after)
1129 (insert_1_both, insert_from_string)
1130 (insert_from_string_before_markers, insert_from_string_1)
1131 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1132 (adjust_after_replace, adjust_after_insert, replace_range)
1133 (replace_range_2, del_range, del_range_1, del_range_byte)
1134 (del_range_both, del_range_2, modify_region)
1135 (prepare_to_modify_buffer, signal_before_change)
1136 (signal_after_change, Fcombine_after_change_execute):
1137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1138 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1139 (balance_an_interval, split_interval_right, split_interval_left)
1140 (find_interval, next_interval, update_interval)
1141 (adjust_intervals_for_insertion, delete_node, delete_interval)
1142 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1143 (static_offset_intervals, offset_intervals)
1144 (merge_interval_right, merge_interval_left, make_new_interval)
1145 (graft_intervals_into_buffer, temp_set_point_both)
1146 (temp_set_point, set_point, adjust_for_invis_intang)
1147 (set_point_both, move_if_not_intangible, get_property_and_range)
1148 (get_local_map, copy_intervals, copy_intervals_to_string)
1149 (compare_string_intervals, set_intervals_multibyte_1):
1150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1151 * intervals.h: Adjust decls to match defn changes elsewhere.
1152 (struct interval):
1153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1154 * keyboard.c (this_command_key_count, this_single_command_key_start)
1155 (before_command_key_count, before_command_echo_length, echo_now)
1156 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1157 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1158 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1159 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1161 (last_non_minibuf_size, last_point_position, echo_truncate)
1162 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1163 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1164 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1165 (stuff_buffered_input):
1166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1167 (last_auto_save, command_loop_1, read_char):
1168 Use EMACS_INT, not int, to avoid integer overflow.
1169 (record_char): Avoid overflow in total_keys computation.
1170 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1171 * keyboard.h: Adjust decls to match defn changes elsewhere.
1172 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1173 (Fkey_description, Fdescribe_vector, Flookup_key):
1174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1175 (click_position): New function, to check that positions are in range.
1176 (Fcurrent_active_maps):
1177 (describe_command):
1178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1179 (Faccessible_keymaps, Fkey_description):
1180 (preferred_sequence_p):
1181 Don't assume fixnum can fit into int.
1182 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1183 Check for integer overflow in size calculations.
1184 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1185 avoid mishandling large integers.
1186 * lisp.h: Adjust decls to match defn changes elsewhere.
1187 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1188 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1189 (struct Lisp_Marker):
1190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1191 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1192 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1193 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1194 All callers changed.
1195 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1196 Assume the arg has valid form, since it always does.
1197 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1198 unsigned integer system type.
1199 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1200 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1201 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1202 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1203 (duration_to_sec_usec): New decl.
1204 * lread.c (read_from_string_index, read_from_string_index_byte)
1205 (read_from_string_limit, readchar, unreadchar, openp)
1206 (read_internal_start, read1, oblookup):
1207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1208 (Fload, readevalloop, Feval_buffer, Feval_region):
1209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1210 (openp): Check for out-of-range argument to 'access'.
1211 (read1): Use int, not EMACS_INT, where int is wide enough.
1212 Don't assume fixnum fits into int.
6efdadfd 1213 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1214 (read_filtered_event): Use duration_to_sec_usec
1215 to do proper overflow checking on durations.
d311d28c
PE
1216 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1217 in size calculation.
1218 (Fexecute_kbd_macro):
1219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1220 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1221 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1222 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1223 (set_marker_both, set_marker_restricted_both, marker_position)
1224 (marker_byte_position, Fbuffer_has_markers_at):
1225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1226 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1227 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1228 It now merely ensures that the menu is large enough, without
1229 necessarily growing it, as this avoids some integer overflow issues.
1230 All callers changed.
1231 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1233 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1234 Use SAFE_ALLOCA_LISP, not alloca.
1235 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1236 to EMACS_INT. Check that fixnums are in proper range for system types.
1237 * minibuf.c (minibuf_prompt_width, string_to_object)
1238 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1239 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1241 (get_minibuffer, read_minibuf_unwind):
1242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1243 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1244 this simplifies overflow checking. All callers changed.
1245 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1246 (Ftest_completion):
1247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1248 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1249 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1250 Check that fixnums are in proper range for system types.
1251 (Fx_create_frame, Fx_show_tip):
1252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1253 * nsfont.m (ns_findfonts, nsfont_list_family):
1254 Don't assume fixnum fits in long.
1255 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1257 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1258 wide enough.
17fdb222 1259 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1261 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1262 (PRINTDECLARE, PRINTPREPARE):
1263 (strout, print_string):
1264 (print, print_preprocess, print_check_string_charset_prop)
1265 (print_object):
1266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1267 (PRINTDECLARE):
1268 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1270 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1271 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1272 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1273 (print_error_message): Use SAFE_ALLOCA, not alloca.
1274 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1275 (print_depth, new_backquote_output, print_number_index):
1276 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1277 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1278 (Fset_process_window_size, Fformat_network_address)
1279 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1280 (sigchld_handler):
d311d28c 1281 Check that fixnums are in proper range for system types.
d44287d4 1282 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1283 Check for process-ids out of pid_t range rather than relying on
1284 undefined behavior.
e4d81efc 1285 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1286 (Fformat_network_address, read_process_output, send_process)
1287 (Fprocess_send_region, status_notify):
1288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1289 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1290 (wait_reading_process_output, read_process_output, exec_sentinel):
1291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1292 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1293 (Faccept_process_output): Use duration_to_sec_usec to do proper
1294 overflow checking on durations.
dde14581
PE
1295 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1296 Don't assume pid_t fits in int.
02481186
PE
1297 * process.h (struct Lisp_Process): Members tick and update_tick
1298 are now of type EMACS_INT, not int.
b62b53e8
PE
1299 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1300 configured --with-wide-int.
d311d28c
PE
1301 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1302 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1303 * search.c (looking_at_1, string_match_1):
1304 (fast_string_match, fast_c_string_match_ignore_case)
1305 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1306 (scan_newline, find_before_next_newline, search_command)
1307 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1308 (set_search_regs, wordify):
1309 (Freplace_match):
1310 (Fmatch_data):
1311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1312 (string_match_1, search_buffer, set_search_regs):
1313 (Fmatch_data):
1314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1315 (wordify): Check for overflow in size calculation.
1316 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1317 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1318 Check that fixnums are in proper range for system types.
1319 * sound.c (struct sound_device)
1320 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1322 (Fplay_sound_internal):
1323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1324 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1325 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1326 (Fparse_partial_sexp):
1327 Don't assume fixnums can fit in int.
1328 (struct lisp_parse_state, find_start_pos, find_start_value)
1329 (find_start_value_byte, find_start_begv)
1330 (update_syntax_table, char_quoted, dec_bytepos)
1331 (find_defun_start, prev_char_comend_first, back_comment):
1332 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1333 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1335 (Finternal_describe_syntax_value): Check that match_lisp is a
1336 character, not an integer, since the code stuffs it into int.
1337 (scan_words, scan_sexps_forward):
1338 Check that fixnums are in proper range for system types.
1339 (Fforward_word):
1340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1341 (scan_sexps_forward):
1342 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1343 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1344 * syntax.h: Adjust decls to match defn changes elsewhere.
1345 (struct gl_state_s):
1346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1347 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1348 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1349 * sysdep.c (wait_for_termination_1, wait_for_termination)
1350 (interruptible_wait_for_termination, mkdir):
1351 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1352 (emacs_read, emacs_write):
1353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1354 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1355 and double all fit in int.
d311d28c
PE
1356 * term.c (set_tty_color_mode):
1357 Check that fixnums are in proper range for system types.
1358 * termhooks.h (struct input_event):
1359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1360 * textprop.c (validate_interval_range, interval_of)
1361 (Fadd_text_properties, set_text_properties_1)
1362 (Fremove_text_properties, Fremove_list_of_text_properties)
1363 (Ftext_property_any, Ftext_property_not_all)
1364 (copy_text_properties, text_property_list, extend_property_ranges)
1365 (verify_interval_modification):
1366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1367 (Fnext_single_char_property_change)
1368 (Fprevious_single_char_property_change):
1369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1370 (copy_text_properties):
1371 Check for integer overflow in index calculation.
d311d28c
PE
1372 * undo.c (last_boundary_position, record_point, record_insert)
1373 (record_delete, record_marker_adjustment, record_change)
1374 (record_property_change):
1375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1376 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1378 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1379 (Fx_hide_tip, Fx_file_dialog):
1380 * w32menu.c (set_frame_menubar):
1381 Use ptrdiff_t, not int, for consistency with rest of code.
1382 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1383 (select_window, Fdelete_other_windows_internal)
1384 (window_scroll_pixel_based, window_scroll_line_based)
1385 (Frecenter, Fset_window_configuration):
1386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1387 (Fset_window_hscroll, run_window_configuration_change_hook)
1388 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1389 (Fscroll_other_window, Frecenter):
d311d28c
PE
1390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1391 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1392 Don't assume fixnum fits in int.
1393 (Fset_window_scroll_bars):
1394 Check that fixnums are in proper range for system types.
1395 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1396 (string_pos, c_string_pos, number_of_chars, init_iterator)
1397 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1398 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1399 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1400 (face_before_or_after_it_pos, handle_invisible_prop)
1401 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1402 (display_prop_intangible_p, string_buffer_position_lim)
1403 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1404 (get_overlay_strings_1, get_overlay_strings)
1405 (iterate_out_of_display_property, forward_to_next_line_start)
1406 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1407 (get_next_display_element, set_iterator_to_next)
1408 (get_visually_first_element, compute_stop_pos_backwards)
1409 (handle_stop_backwards, next_element_from_buffer)
1410 (move_it_in_display_line_to, move_it_in_display_line)
1411 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1412 (add_to_log, message_dolog, message_log_check_duplicate)
1413 (message2, message2_nolog, message3, message3_nolog
1414 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1415 (current_message_1, truncate_echo_area, truncate_message_1)
1416 (set_message, set_message_1, store_mode_line_noprop)
1417 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1418 (text_outside_line_unchanged_p, check_point_in_composition)
1419 (reconsider_clip_changes)
1420 (redisplay_internal, set_cursor_from_row, try_scrolling)
1421 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1422 (redisplay_window, find_last_unchanged_at_beg_row)
1423 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1424 (trailing_whitespace_p, find_row_edges, display_line)
1425 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1426 (display_mode_element, store_mode_line_string)
1427 (pint2str, pint2hrstr, decode_mode_spec)
1428 (display_count_lines, display_string, draw_glyphs)
1429 (x_produce_glyphs, x_insert_glyphs)
1430 (rows_from_pos_range, mouse_face_from_buffer_pos)
1431 (fast_find_string_pos, mouse_face_from_string_pos)
1432 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1434 (safe_call, init_from_display_pos, handle_fontified_prop)
1435 (handle_single_display_spec, load_overlay_strings)
1436 (with_echo_area_buffer, setup_echo_area_for_printing)
1437 (display_echo_area, echo_area_display)
1438 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1439 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1440 (redisplay_window, dump_glyph_row, display_mode_line)
1441 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1442 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1444 (handle_single_display_spec, build_desired_tool_bar_string)
1445 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1446 (get_specified_cursor_type):
1447 Check that fixnums are in proper range for system types.
1448 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1449 (Flookup_image_map):
1450 Don't assume fixnums fit in int.
1451 (compare_overlay_entries):
1452 Avoid mishandling comparisons due to subtraction overflow.
1453 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1454 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1455 (handle_tool_bar_click):
1456 Use int, not unsigned, since we prefer signed and the signedness
1457 doesn't matter here.
1458 (get_next_display_element, next_element_from_display_vector):
1459 Use int, not EMACS_INT, when int is wide enough.
1460 (start_hourglass): Use duration_to_sec_usec to do proper
1461 overflow checking on durations.
1462 * xfaces.c (Fbitmap_spec_p):
1463 Check that fixnums are in proper range for system types.
1464 (compare_fonts_by_sort_order):
1465 Avoid mishandling comparisons due to subtraction overflow.
1466 (Fx_family_fonts, realize_basic_faces):
1467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1468 (Fx_family_fonts):
1469 Don't assume fixnum fits in int.
1470 Use SAFE_ALLOCA_LISP, not alloca.
1471 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1472 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1473 (face_at_buffer_position, face_for_overlay_string)
1474 (face_at_string_position):
1475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1476 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1477 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1478 (Fx_show_tip):
1479 Check that fixnums are in proper range for system types.
1480 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1481 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1483 (Fx_change_window_property): Don't assume fixnums fit in int.
1484 * xfont.c (xfont_chars_supported):
1485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1486 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1487 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1489 * xml.c (parse_region):
1490 * xrdb.c (magic_file_p):
1491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1492 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1493 (x_get_local_selection, x_reply_selection_request)
1494 (x_handle_selection_request, wait_for_property_change):
1495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1496 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1497 short is wide enough.
1498 (x_send_client_event): Don't assume fixnum fits in int.
1499 * xterm.c (x_x_to_emacs_modifiers):
1500 Don't assume EMACS_INT overflows nicely into int.
1501 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1502 may come from Lisp.
1503 (handle_one_xevent): NATNUMP can eval its arg twice.
1504 (x_connection_closed):
1505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1506 * xterm.h: Adjust decls to match defn changes elsewhere.
1507 (struct scroll_bar): Use struct vectorlike_header
1508 rather than rolling our own approximation.
1509 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1510
c6574eb5
GM
15112012-05-25 Glenn Morris <rgm@gnu.org>
1512
1513 * lisp.mk (lisp): Update for more files being compiled now.
1514
e8d32c7e
SM
15152012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1516
48def666
SM
1517 * lread.c: Remove `read_pure' which makes no difference.
1518 (read_pure): Remove var.
1519 (unreadpure): Remove function.
1520 (readevalloop): Don't call read_list with -1 flag.
1521 (read1, read_vector): Don't test read_pure any more.
1522 (read_list): Simplify.
1523
e8d32c7e
SM
1524 * fileio.c, character.h: Minor style tweaks.
1525
4b2addb7
DA
15262012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1527
1528 * window.h (clip_changed): Remove useless declaration.
1529
584461b2
JB
15302012-05-22 Juanma Barranquero <lekktu@gmail.com>
1531
1532 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1533 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1534
34374650
PE
15352012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1536
1537 Remove src/m/*.
1538 This directory predates autoconf and is no longer needed nowadays.
1539 Move its few remaining bits of functionality to where they're needed.
1540 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1541 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1542 * m/template.h: Remove.
1543 * Makefile.in (M_FILE): Remove. All uses removed.
1544 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1545 * lisp.h (USE_LSB_TAG):
1546 * mem-limits.h (EXCEEDS_LISP_PTR):
1547 Use VAL_MAX, not VALBITS, in #if.
1548 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1549 (EMACS_UINT): Define unconditionally now.
1550 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1551 (BITS_PER_EMACS_INT): New constants, replacing
1552 what used to be in config.h, but not useful in #if.
1553 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1554 define them any more.
1555 (VAL_MAX): New macro.
1556 (VALMASK): Use it.
1557 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1558 BITS_PER_EMACS_INT, in #if.
1559 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1560 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1561 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1562 * s/ms-w32.h (DATA_START):
1563 Move here from removed file m/intel386.h.
1564 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1565 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1566
261cb4bb
PE
15672012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 Assume C89 or later.
1570 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1571 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1572 (xrealloc):
1573 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1574 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1575 * textprop.c, tparam.c (NULL): Remove.
1576 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1577 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1578 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1579 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1580 * xterm.c (input_signal_count): Assume volatile works.
1581
ff23cd9f
KB
15822012-05-21 Ken Brown <kbrown@cornell.edu>
1583
1584 * xgselect.c (xg_select): Fix first argument in call to 'select'
1585 (bug#11508).
1586
1b170bc6
KB
15872012-05-20 Ken Brown <kbrown@cornell.edu>
1588
1589 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1590 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1591
b2f4d39f
KB
15922012-05-19 Ken Brown <kbrown@cornell.edu>
1593
1594 * xfns.c (x_in_use): Remove `static' qualifier.
1595 * xterm.h (x_in_use): Declare.
1596 * xgselect.c: Include xterm.h.
1597 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1598 and `display_arg' (bug#9754).
1599
003fdae2
PE
16002012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1601
9232a6d9
PE
1602 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1603
003fdae2
PE
1604 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1605 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1606
784b56e2
EZ
16072012-05-18 Eli Zaretskii <eliz@gnu.org>
1608
1609 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1610
1611 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1612 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1613
1614 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1615 reference to image_cache->refcount.
1616 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1617
a0a79cde
JL
16182012-05-17 Juri Linkov <juri@jurta.org>
1619
1620 * search.c (Fword_search_regexp, Fword_search_backward)
1621 (Fword_search_forward, Fword_search_backward_lax)
1622 (Fword_search_forward_lax): Move functions to isearch.el
1623 (bug#10145, bug#11381).
1624
b0572523
PE
16252012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1628
9660f5fc
SM
16292012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1630
1631 * lread.c (init_obarray): Declare Qt and Qnil as special.
1632
4374de83
GM
16332012-05-14 Glenn Morris <rgm@gnu.org>
1634
1635 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1636 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1637
dc44c39a
PE
16382012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1639
078c97cb
PE
1640 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1641
dc44c39a
PE
1642 * unexaix.c: Port to more-recent AIX compilers.
1643 (report_error, report_error_1, make_hdr, copy_sym)
1644 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1645 Make arguments const char *, not char *, to avoid violations of C
1646 standard and to fix some AIX warnings reported by Gilles Pion.
1647
e18afed7 16482012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1649
1650 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1651 already have overlays loaded.
1652 (handle_single_display_spec): Before returning without displaying
1653 fringe bitmap, synchronize the bidi iterator with the main display
1654 iterator, by calling iterate_out_of_display_property.
1655 (iterate_out_of_display_property): Detect buffer iteration by
1656 testing that it->string is a Lisp string.
1657 (get_next_display_element): When the current object is exhausted,
1658 and there's something on it->stack, call set_iterator_to_next to
1659 proceed with what's on the stack, instead of returning zero.
1660 (set_iterator_to_next): If called at the end of a Lisp string,
1661 proceed to consider_string_end without incrementing string
1662 position. Don't increment display vector index past the end of
1663 the display vector. (Bug#11417)
c8fb9dc6
EZ
1664 (pos_visible_p): Don't report a position visible when move_it_to
1665 stopped at the last line of window, which happens to be scanned
1666 backwards by the bidi iteration. (Bug#11464)
ac268e67 1667
e18afed7 16682012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1669
1670 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1671 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1672 are on a TTY, and thus unable to display on the fringes.
1673 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1674 so we need to signal to the caller that this is a "replacing"
1675 display spec. This fixes display when the spec is invalid or we
1676 are on a TTY.
1677
e18afed7 16782012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1679
1680 * unexaix.c (make_hdr): Fix typo in prototype.
1681 This bug broke the build on AIX. Problem reported by Gilles Pion.
1682
9d0a235a
MA
16832012-05-14 Michael Albinus <michael.albinus@gmx.de>
1684
1685 * keyboard.c (kbd_buffer_get_event): Read special events also in
1686 batch mode. (Bug#11415)
1687
9e6b06ed
GM
16882012-05-12 Glenn Morris <rgm@gnu.org>
1689
1690 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1691
c1a1d7a3
EZ
16922012-05-12 Eli Zaretskii <eliz@gnu.org>
1693
1694 * lisp.mk (lisp): Add newcomment.elc.
1695
3fe7cdc8
GM
16962012-05-12 Glenn Morris <rgm@gnu.org>
1697
1698 * Makefile.in (MKDIR_P): New, set by configure.
1699 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1700
53f7d2c0
PE
17012012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 Remove unused function hourglass_started.
1704 * dispextern.h (hourglass_started):
1705 * w32fns.c (hourglass_started):
1706 * xdisp.c (hourglass_started): Remove.
1707
75aafb17
JB
17082012-05-10 Juanma Barranquero <lekktu@gmail.com>
1709
1710 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1711 Update dependencies.
1712
12959e8e
PE
17132012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1714
97107e2e
PE
1715 * xgselect.c (xg_select): Put maxfds+1 into a var.
1716 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1717
12959e8e
PE
1718 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1719
836d29b3
DA
17202012-05-10 Dave Abrahams <dave@boostpro.com>
1721
1722 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1723 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1724
5cb67954
MA
17252012-05-09 Michael Albinus <michael.albinus@gmx.de>
1726
1727 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1728 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1729 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1730 Initialize xd_registered_buses.
1731
3478ec45
PE
17322012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1733
b263a6b0
PE
1734 Untag more efficiently if USE_LSB_TAG.
1735 This is based on a proposal by YAMAMOTO Mitsuharu in
1736 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1737 For an admittedly artificial (nth 8000 longlist) benchmark on
1738 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1739 Emacs's overall text size by 1%.
1740 * lisp.h (XUNTAG): New macro.
1741 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1742 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1743 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1744 * eval.c (Fautoload):
1745 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1746 * frame.h (XFRAME): Use XUNTAG.
1747
3478ec45
PE
1748 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1749 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1750 Remove unportable assumptions about print widths of types like
1751 dbus_uint32_t.
1752 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1753 intptr_t when converting between pointer and integer, to avoid GCC
1754 warnings about wrong width.
1755
666b903b 17562012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1757
1758 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1759 stack for each reader_thread, instead of defaulting to 8MB
1760 determined by the linker. This avoids failures in creating
1761 subprocesses on Windows 7, see the discussion in this thread:
1762 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1763
b120cc17
JC
17642012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1765
1766 Fix up display of the *Minibuf-0* buffer in the mini window.
1767 * keyboard.c (read_char): Don't clear the echo area if there's no
1768 message to clear.
1769 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1770 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1771
9a4b36f8
MA
17722012-05-07 Michael Albinus <michael.albinus@gmx.de>
1773
1774 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1775 batch mode.
1776
e5f9458f
CY
17772012-05-06 Chong Yidong <cyd@gnu.org>
1778
1779 * lisp.mk (lisp): Update.
1780
eceeb5fc 17812012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1782
1783 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1784
71873e2b
SM
17852012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1786
1787 * data.c (PUT_ERROR): New macro.
1788 (syms_of_data): Use it. Add new error type `user-error'.
1789 * undo.c (user_error): New function.
1790 (Fprimitive_undo): Use it.
1791 * print.c (print_error_message): Adjust print style for `user-error'.
1792 * keyboard.c (user_error): New function.
1793 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1794
ab0fa4e4
PE
17952012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 Do not limit current-time-string to years 1000..9999.
1798 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1799 (Fcurrent_time_string): Support any year that is supported by the
1800 underlying localtime representation. Don't use asctime, as it
1801 has undefined behavior for years outside the range -999..9999.
1802
7ed806a7
PE
18032012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1804
1805 Fix race conditions involving setenv, gmtime, localtime, asctime.
1806 Without this fix, interrupts could mess up code that uses these
1807 nonreentrant functions, since setting TZ invalidates existing
1808 tm_zone or tzname values, and since most of these functions return
1809 pointers to static storage.
1810 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1811 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1812 Grow the critical sections to include not just invoking
1813 localtime/gmtime, but also accessing these functions' results
1814 including their tm_zone values if any, and any related TZ setting.
1815 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1816 so that the struct tm is saved in the critical section.
1817 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1818 motivated by the fact that memory allocation needs to be outside
1819 the critical section.
1820
0c16dfed
DA
18212012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1822
1823 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1824 with RESET_INTERVAL.
1825
1826 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1827 Remove duplicated buffer name initialization.
1828
3f83ace8
JM
18292012-05-02 Jim Meyering <jim@meyering.net>
1830
1831 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1832
c7b8541e
JM
1833 * xfns.c (x_window): Use xstrdup (Bug#11375).
1834
90207a15 18352012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1836
1837 * xdisp.c (pos_visible_p): If already at a newline from the
1838 display string before the 'while' loop, don't walk back the glyphs
1839 from it3.glyph_row. Solves assertion violation when the display
1840 string begins with a newline (egg.el). (Bug#11367)
1841
b593d6a9
AH
18422012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1843
1844 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1845 Move to simple.el.
1846
4737362e
GM
18472012-05-01 Glenn Morris <rgm@gnu.org>
1848
99cf43f9
GM
1849 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1850 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1851 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1852 All were removed before 23.1.
1853
9311dcff
GM
1854 * dispnew.c: Remove HAVE_LIBNCURSES test;
1855 it is always true on relevant platforms.
1856
4d5c6349
GM
1857 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1858 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1859
4737362e
GM
1860 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1861
74dd3a6b
AS
18622012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1863
1864 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1865 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1866 Remove.
1867
13c379ee
PE
18682012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 Do not avoid creating empty evaporating overlays (Bug#9642).
1871 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1872 That is, do not delete an evaporating overlay if it becomes
1873 empty after its bounds are adjusted to fit within its buffer.
1874 This fix caused other problems, and I'm reverting it until we get
1875 to the bottom of them.
1876
a8e7d6d7 18772012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1878
1879 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1880
a8e7d6d7 18812012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1882
1883 * xdisp.c (pos_visible_p): If the window start position is beyond
1884 ZV, start the display from buffer beginning. Prevents assertion
1885 violation in init_iterator when the minibuffer window is scrolled
1886 via the scroll bar.
1887
1888 * window.c (window_scroll_pixel_based): Likewise.
1889
a8e7d6d7 18902012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1891
1892 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1893
a8e7d6d7 18942012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1895
1896 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1897 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1898
a8e7d6d7 18992012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1900
b593d6a9
AH
1901 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1902 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1903
1c6900d9
EZ
19042012-04-26 Eli Zaretskii <eliz@gnu.org>
1905
4c3fa1d9
EZ
1906 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1907 display element, check also the underlying string or buffer
1908 character. (Bug#11341)
1909
1c6900d9
EZ
1910 * w32menu.c: Include w32heap.h.
1911 (add_menu_item): If the call to AppendMenuW (via
1912 unicode_append_menu) fails, disable Unicode menus only if we are
1913 running on Windows 9X/Me.
1914
42bf8205
AS
19152012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1916
1917 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1918 (xgetint): Add missing shift for LSB tags.
1919
b1bac16e
MR
19202012-04-24 Martin Rudalics <rudalics@gmx.at>
1921
1922 * keyboard.c (read_char): Don't wipe echo area for select window
1923 events: These might get delayed via `mouse-autoselect-window'
1924 (Bug#11304).
1925
d69621cc
JB
19262012-04-24 Juanma Barranquero <lekktu@gmail.com>
1927
1928 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1929 manipulation of :loaded-from data.
1930
02fd101b
JB
19312012-04-23 Juanma Barranquero <lekktu@gmail.com>
1932
1933 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1934 now a cons (bug#11311).
1935
888bec30
PE
19362012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1937
89a438bd
PE
1938 Do not create empty overlays with the evaporate property (Bug#9642).
1939 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1940 if it becomes empty after its bounds are adjusted to fit within
1941 its buffer. Without this fix, in a nonempty buffer (let ((o
1942 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1943 yields an empty overlay that has the evaporate property, which is
1944 not supposed to happen.
1945
1068fe4d
PE
1946 Fix minor GTK3 problems found by static checking.
1947 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1948 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1949 (struct _EmacsFixedClass, emacs_fixed_get_type):
1950 Move decls here from emacsgtkfixed.h, since they needn't be public.
1951 (emacs_fixed_get_type): Now static.
1952 (emacs_fixed_class_init): Omit unused local.
1953 (emacs_fixed_child_type): Remove; unused.
1954 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1955 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1956 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1957 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1958 (EMACS_FIXED_GET_CLASS): Remove; unused.
1959 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1960
888bec30
PE
1961 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1962 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1963
de85e130
PE
19642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1965
d0baac98 1966 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1967 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1968 (__malloc_size_t, __malloc_ptrdiff_t):
1969 Remove. All uses removed, replaced by the definiens if needed,
1970 since we can assume C89 or better now.
1971 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1972 (protect_malloc_state, align, get_contiguous_space)
1973 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1974 (malloc_atfork_handler_child, malloc_enable_thread)
1975 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1976 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1977 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1978 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1979 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1980 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1981 Define using prototypes, not old style.
1982 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1983 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1984 (align): Don't assume that signed integer overflow wraps around.
1985 Omit unused local var.
1986 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1987 (_free_internal_nolock, memalign, mallochook, reallochook):
1988 Omit no-longer-needed casts.
1989 (valloc): Use getpagesize, not __getpagesize.
1990 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1991 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1992
de85e130
PE
1993 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1994
dcbf5805
MA
19952012-04-22 Michael Albinus <michael.albinus@gmx.de>
1996
1997 Move functions from C to Lisp. Make non-blocking method calls
1998 the default. Implement further D-Bus standard interfaces.
1999
2000 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2001 (QCdbus_request_name_allow_replacement)
2002 (QCdbus_request_name_replace_existing)
2003 (QCdbus_request_name_do_not_queue)
2004 (QCdbus_request_name_reply_primary_owner)
2005 (QCdbus_request_name_reply_in_queue)
2006 (QCdbus_request_name_reply_exists)
2007 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2008 (QCdbus_registered_serial, QCdbus_registered_method)
2009 (QCdbus_registered_signal): New Lisp objects.
2010 (XD_DEBUG_MESSAGE): Use sizeof.
2011 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2012 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2013 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2014 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2015 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2016 (xd_signature, xd_append_arg): Allow float for integer types.
2017 (xd_get_connection_references): New function.
b593d6a9
AH
2018 (xd_get_connection_address): Rename from xd_initialize.
2019 Return cached address.
dcbf5805
MA
2020 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2021 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2022 level.
2023 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2024 Return number of refcounts.
dcbf5805
MA
2025 (Fdbus_get_unique_name): Make stronger parameter check.
2026 (Fdbus_message_internal): New defun.
2027 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2028 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2029 (Fdbus_send_signal, Fdbus_register_service)
2030 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2031 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2032 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2033 (Vdbus_compiled_version, Vdbus_runtime_version)
2034 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2035 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2036 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2037 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2038 Adapt docstring.
dcbf5805 2039
52828e02
PE
20402012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2041
da05bc4c
PE
2042 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2043 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2044 Do not assume ptrdiff_t is the same width as 'int'.
2045
52828e02
PE
2046 * alloc.c: Handle unusual debugging option combinations.
2047 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2048 since the two debugging options are incompatible.
2049 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2050 is defined.
2051 (mem_init, mem_insert, mem_insert_fixup):
2052 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2053 (NEED_MEM_INSERT): Remove; no longer needed.
2054
f01769f9
LL
20552012-04-22 Leo Liu <sdl.web@gmail.com>
2056
2057 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2058
5790543d
PE
20592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2060
2061 * sysdep.c [__FreeBSD__]: Minor cleanups.
2062 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2063 Use Emacs indenting style more consistently. Avoid some casts.
2064 Use 'double' consistently rather than mixing 'float' and 'double'.
2065
b91b7e4d
EW
20662012-04-21 Eduard Wiebe <usenet@pusto.de>
2067
b593d6a9
AH
2068 * sysdep.c (list_system_processes, system_process_attributes):
2069 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2070
6114eb15
AS
20712012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2072
2073 * lisp.mk (lisp): Update.
2074
2f38dff7
PE
20752012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2078 It is never used otherwise.
2079
4ae29f89
SM
20802012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2081
2082 * print.c (print_preprocess): Only check print_depth if print-circle
2083 is nil.
2084 (print_object): Check for cycles even when print-circle is nil and
2085 print-gensym is t, but only check print_depth if print-circle is nil.
2086
f30d612a
CY
20872012-04-20 Chong Yidong <cyd@gnu.org>
2088
2089 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2090 set the status to "failed" and ensure that sentinel is run.
2091
c07a4c0b 20922012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2093
2094 * process.c (Fset_process_inherit_coding_system_flag)
2095 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2096 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2097
c07a4c0b 20982012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2099
2100 * xdisp.c (string_buffer_position_lim): Limit starting position to
2101 BEGV.
2102 (set_cursor_from_row): If called for a mode-line or header-line
2103 row, return zero immediately.
2104 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2105 farther than the first row after the header line, if any.
2106 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2107 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2108
c07a4c0b 21092012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2110
4ae29f89
SM
2111 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2112 (bug#11238).
ad3a2b41 2113
c07a4c0b 21142012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 21152012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2116
2117 configure: new option --enable-gcc-warnings (Bug#11207)
2118 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2119 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2120 (ALL_CFLAGS): Use new macros rather than old.
2121 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2122 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2123 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2124 -Wunused-result, -Wunused-variable. This should go away once
2125 the Emacs and Gnulib regex code is merged.
2126 (xmalloc, xrealloc): Now static.
2127
aba027e8
PE
21282012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2129
2130 * dired.c (Fsystem_groups): Remove unused local.
2131
e5a36063
GM
21322012-04-17 Glenn Morris <rgm@gnu.org>
2133
2134 * dired.c (Fsystem_users): Doc fix.
2135
316411f0
DA
21362012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2139 (syms_of_dired): Add them.
2140
9426aba4
PE
21412012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2142
b62a57be
PE
2143 Fix minor alloc.c problems found by static checking.
2144 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2145 New extern decls, to avoid calling undeclared functions.
2146 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2147 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2148 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2149 (NEED_MEM_INSERT): New macro.
2150 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2151 Remove one incorrect comment and fix another.
b62a57be 2152
3539f31f
PE
2153 Fix minor ralloc.c problems found by static checking.
2154 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2155 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2156 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2157 (r_alloc_sbrk): Now static.
2158
a041960a
PE
2159 Improve ralloc.c interface checking.
2160 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2161 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2162 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2163 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2164 [REL_ALLOC]: ... to here, to check interface.
2165 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2166 Remove decls. This fixes an "It stinks!".
2167
9426aba4
PE
2168 * alloc.c (which_symbols): Fix alignment issue / type clash.
2169
d55c12ed
AS
21702012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2171
2172 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2173 (struct Lisp_Misc_Any): Likewise.
2174 (struct Lisp_Free): Likewise.
2175 * alloc.c (union aligned_Lisp_Symbol): Define.
2176 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2177 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2178 (union aligned_Lisp_Misc): Define.
2179 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2180 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2181 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2182
b948ce8b
PE
21832012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2184
2185 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2186 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2187 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2188 * s/netbsd.h, s/sol2-6.h:
2189 Remove definition of GC_MARK_STACK, since the default now works.
2190 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2191 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2192 no longer the default.
2193 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2194
35dc09a1 21952012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2196
35dc09a1
GM
2197 * lread.c (lisp_file_lexically_bound_p):
2198 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2199
35dc09a1
GM
22002012-04-14 Eli Zaretskii <eliz@gnu.org>
2201
2202 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2203 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2204
22052012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2206
2207 * nsterm.m (constrainFrameRect): Always constrain when there is only
2208 one screen (Bug#10962).
2209
bcd86815
KB
22102012-04-13 Ken Brown <kbrown@cornell.edu>
2211
2212 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2213
c25df26e
RT
22142012-04-13 Reuben Thomas <rrt@sc3d.org>
2215
2216 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2217
0fc59f1e
DC
22182012-04-11 Daniel Colascione <dancol@dancol.org>
2219
2220 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2221 against is gone. It's better to use vfork now so that when Cygwin
2222 gains a new, working vfork, we use it automatically (bug#10398).
2223
de8c03dc
SM
22242012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2225
2226 * window.c (save_window_save): Obey window-point-insertion-type.
2227
2f097256
GM
22282012-04-11 Glenn Morris <rgm@gnu.org>
2229
2230 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2231
453b951e
SM
22322012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2233
2234 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2235
75f1671a 22362012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2237
2238 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2239 (force_quit_count): New var.
2240 (handle_interrupt): Use it.
2241
2a8ce227
JB
22422012-04-10 Juanma Barranquero <lekktu@gmail.com>
2243
2244 * w32.c (w32_delayed_load): Record the full path of the library
2245 being loaded (bug#10424).
2246
935396c0
GM
22472012-04-09 Glenn Morris <rgm@gnu.org>
2248
05920a43
GM
2249 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2250 not just in the obarray, before snarfing them. (Bug#11036)
2251
935396c0
GM
2252 * Makefile.in ($(leimdir)/leim-list.el):
2253 Pass EMACS rather than BUILT_EMACS.
2254
a18ecafa
TZ
22552012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2256
2257 * process.c (make_process):
2258 * process.h: Add integer `gnutls_handshakes_tried' member to
2259 process struct.
2260
6bbef4e5
JC
2261 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2262 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2263
2264 * gnutls.c (gnutls_log_function2i): Convenience log function.
2265 (emacs_gnutls_read): Use new log functions,
2266 `gnutls_handshakes_tried' process member, and
2267 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2268 attempts per process (connection).
2269
b4d3bc10
CY
22702012-04-09 Chong Yidong <cyd@gnu.org>
2271
2272 * eval.c (Fuser_variable_p, user_variable_p_eh)
2273 (lisp_indirect_variable): Functions deleted.
2274 (Fdefvar): Caller changed.
2275
2276 * callint.c (Finteractive, Fcall_interactively):
2277 * minibuf.c (Fread_variable): Callers changed.
2278
70f4d973
EZ
22792012-04-09 Eli Zaretskii <eliz@gnu.org>
2280
2281 * xdisp.c (set_cursor_from_row): If the display string appears in
2282 the buffer at position that is closer to point than the position
2283 after the display string, display the cursor on the first glyph of
2284 the display string. Fixes cursor display when a 'display' text
2285 property immediately follows invisible text. (Bug#11094)
2286
cb3c2e3e
PE
22872012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 composite.c: use 'double' consistently
2290 * composite.c (get_composition_id): Use 'double' consistently
2291 instead of converting 'float' to 'double' and vice versa; this is
2292 easier to understand and avoids a GCC warning.
2293
fd06db5d
GM
22942012-04-09 Glenn Morris <rgm@gnu.org>
2295
50fe702a
GM
2296 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2297 preparation for dumping it with emacs. (Bug#4789)
2298 (leimdir): New variable.
2299 ($(leimdir)/leim-list.el): New rule.
2300 (emacs$(EXEEXT)): Depend on leim-list.el.
2301
fd06db5d
GM
2302 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2303 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2304 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2305
55c131ee
AS
23062012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2307
2308 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2309 proper alignment.
2310
9209588f
JB
23112012-04-07 Juanma Barranquero <lekktu@gmail.com>
2312
2313 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2314 Remove unused local variable.
2315
e3fb2efb
PE
23162012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2319 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2320 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2321 objects, as mark_maybe_pointer will catch them otherwise.
2322 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2323 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2324
b5385551
PE
23252012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2326
2327 Fix typo that broke non-Windows builds.
2328 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2329
9078ead6
EZ
23302012-04-07 Eli Zaretskii <eliz@gnu.org>
2331
2332 Support building on MS-Windows with libxml2.
2333
2334 * makefile.w32-in (OBJ2): Add xml.$(O).
2335 (GLOBAL_SOURCES): Add xml.c.
2336 ($(BLD)/xml.$(O)): New dependency list.
2337
2338 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2339 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2340 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2341 [!WINDOWSNT]: New macros.
2342 (init_libxml2_functions, libxml2_loaded_p): New functions.
2343 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2344 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2345 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2346 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2347 linked in).
6bbef4e5
JC
2348 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2349 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2350 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2351
2352 * emacs.c: Don't include libxml/parser.h.
2353 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2354 xmlCleanupParser directly.
2355
2356 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2357
3811fdf3
EZ
23582012-04-07 Eli Zaretskii <eliz@gnu.org>
2359
2360 * indent.c (Fvertical_motion): If there is a display string at
2361 point, use it.vpos to compute how many lines to backtrack after
2362 move_it_to point. (Bug#11133)
2363
2f8e16b2
EZ
23642012-04-06 Eli Zaretskii <eliz@gnu.org>
2365
2366 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2367 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2368 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2369 macros related to unification of CJK characters. For the details,
2370 see the discussion following the message here:
2371 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2372
3d439cd1
CY
23732012-04-04 Chong Yidong <cyd@gnu.org>
2374
2375 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2376
8bc53d00
EZ
23772012-04-01 Eli Zaretskii <eliz@gnu.org>
2378
2379 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2380 instead of alloca. (Bug#11138)
2381
3b0512a3
AS
23822012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2383
2384 * w32menu.c (is_simple_dialog): Properly check lisp types.
2385 (Bug#11141)
2386
8427ddd2
EZ
23872012-03-31 Eli Zaretskii <eliz@gnu.org>
2388
979022ef
EZ
2389 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2390 position we get to after a call to move_it_to fails the
2391 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2392 only if we wind up in a string from display property. (Bug#11063)
2393
a6b1c7cc
EZ
2394 * window.c (Fdelete_other_windows_internal): Invalidate the row
2395 and column information about mouse highlight, so that redisplay
2396 restores it after reallocating the glyph matrices. (Bug#7464)
2397
8427ddd2
EZ
2398 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2399 string comes from a `display' text property, use the buffer
2400 position of that property as if we actually saw that position in
2401 the row's glyphs.
697ba24b
EZ
2402 (move_it_by_lines): Remove the assertion that
2403 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2404 violated when there's a before-string at the beginning of a line.
2405 (Bug#11063)
8427ddd2 2406
65a0a738
EZ
24072012-03-30 Eli Zaretskii <eliz@gnu.org>
2408
2409 * xdisp.c (append_space_for_newline): If the default face was
2410 remapped, use the remapped face for the appended newline.
2411 (extend_face_to_end_of_line): Use the remapped default face for
2412 extending the face to the end of the line.
2413 (display_line): Call extend_face_to_end_of_line when the default
2414 face was remapped. (Bug#11068)
2415
581355cc
EZ
24162012-03-29 Eli Zaretskii <eliz@gnu.org>
2417
2418 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2419
e8fc049f
SM
24202012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2421
2422 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2423
4fb9a543
GM
24242012-03-27 Glenn Morris <rgm@gnu.org>
2425
2426 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2427 Doc fixes.
2428
679910f1
KH
24292012-03-26 Kenichi Handa <handa@m17n.org>
2430
2431 * dispextern.h (struct glyph): Fix previous change. Change the
2432 bit length of glyphless.ch to 25 (Bug#11082).
2433
90d49b7f
CY
24342012-03-26 Chong Yidong <cyd@gnu.org>
2435
2436 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2437 (command_loop_1): Use it; inhibit selection update for
2438 handle-select-window too (Bug#8996).
2439
f514f6f0
FP
24402012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2441
e8fc049f 2442 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2443
bf43fa51
KH
24442012-03-25 Kenichi Handa <handa@m17n.org>
2445
2446 * dispextern.h (struct glyph): Change the bit length of
2447 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2448
8a0c01dd
EZ
24492012-03-24 Eli Zaretskii <eliz@gnu.org>
2450
2451 * s/ms-w32.h (tzname): Include time.h before redirecting to
2452 _tzname. Fixes the MSVC build. (Bug#9960)
2453
7d1c3a76
AS
24542012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2455
8ed79523
AS
2456 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2457 characters.
2458
7d1c3a76
AS
2459 * xterm.c (XTread_socket): Only modify handling_signal if
2460 !SYNC_INPUT. (Bug#11080)
2461
e99a9b8b
EZ
24622012-03-23 Eli Zaretskii <eliz@gnu.org>
2463
2464 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2465 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2466 when fetching a multibyte character consumes more bytes than
2467 CHAR_BYTES returns, due to unification of CJK characters in
2468 string_char. (Bug#11073)
2469
5063c0e1
TN
24702012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2471
2472 * process.c (wait_reading_process_output): Handle pty disconnect
2473 by refraining from sending oneself a SIGCHLD (bug#10933).
2474
9f851fbd
CY
24752012-03-22 Chong Yidong <cyd@gnu.org>
2476
2477 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2478
5063c0e1 2479 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2480 Mark string as coming from a prefix property.
2481 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2482 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2483
fb5b8aca
CY
24842012-03-21 Chong Yidong <cyd@gnu.org>
2485
2486 * xfaces.c (Vface_remapping_alist): Doc fix.
2487
62356a1b
EZ
24882012-03-20 Eli Zaretskii <eliz@gnu.org>
2489
2490 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2491 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2492 Doc fixes.
62356a1b 2493
025de85b
CY
24942012-03-20 Chong Yidong <cyd@gnu.org>
2495
2496 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2497 to reflect default non-nil value of redisplay-dont-pause.
2498
4827f94e
KH
24992012-03-19 Kenichi Handa <handa@m17n.org>
2500
2501 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2502 it fit in a valid range (Bug#11003).
2503
e50a24a2
EZ
25042012-03-18 Eli Zaretskii <eliz@gnu.org>
2505
2506 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2507 that is not from display property, accept the row as a "cursor
2508 row" if one of the string's character has a non-nil `cursor'
2509 property. Fixes cursor positioning when there are newlines in
2510 overlay strings, e.g. in icomplete.el. (Bug#11035)
2511
9af5ed87
PE
25122012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2513
2514 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2515
d1f55f16
CY
25162012-03-12 Chong Yidong <cyd@gnu.org>
2517
2518 * eval.c (inhibit_lisp_code): Rename from
2519 inhibit_window_configuration_change_hook; move from window.c.
2520
2521 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2522 * window.c (run_window_configuration_change_hook)
2523 (syms_of_window): Callers changed.
2524
66c5eebd
CY
25252012-03-11 Chong Yidong <cyd@gnu.org>
2526
413df973
CY
2527 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2528
66c5eebd
CY
2529 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2530
1de11f56
CY
25312012-03-10 Chong Yidong <cyd@gnu.org>
2532
2533 * frame.c (other_visible_frames): Don't assume the selected frame
2534 is visible (Bug#10955).
2535
cae07000
SM
25362012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2537
2538 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2539
89c94350
JD
25402012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2541
2542 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2543 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2544 zero (Bug#10954).
2545
999dd333
GM
25462012-03-03 Glenn Morris <rgm@gnu.org>
2547
01a6dcc8 2548 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2549
de0100f2
EZ
25502012-03-02 Eli Zaretskii <eliz@gnu.org>
2551
2552 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2553 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2554 (redisplay_window, next_element_from_string): Fix typos in
2555 comments.
3e441275
EZ
2556 (redisplay_window): Pass to move_it_vertically the margin in
2557 pixels, not in screen lines.
de0100f2 2558
96a72ee9
GM
25592012-03-02 Glenn Morris <rgm@gnu.org>
2560
2561 * buffer.c (buffer-list-update-hook): Doc fix.
2562
312508d7
EZ
25632012-02-29 Eli Zaretskii <eliz@gnu.org>
2564
2565 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2566 push_it before setting up the iterator for the first overlay
2567 string, even if we have an empty string loaded.
2568 (next_overlay_string): If there's an empty string on the iterator
2569 stack, pop the stack. (Bug#10903)
2570
27f3c637
PE
25712012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2572
2573 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2574 Suggested by Stefan Monnier in
2575 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2576 * alloc.c (widen_to_Lisp_Object): New static function.
2577 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2578 and widening them to Lisp_Objects. This would work even if
2579 USE_LSB_TAG is defined and wide integers are used, which might
2580 happen in a future version of Emacs.
2581
3c9dfce6
CY
25822012-02-25 Chong Yidong <cyd@gnu.org>
2583
fa74b241
CY
2584 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2585 Doc fix.
2586
3c9dfce6
CY
2587 * xselect.c (Fx_selection_exists_p): Doc fix.
2588 (x_clipboard_manager_save_all): Print an informative message
2589 before saving to clipboard manager.
2590
9486df08
CY
25912012-02-24 Chong Yidong <cyd@gnu.org>
2592
2593 * keyboard.c (process_special_events): Handle all X selection
2594 requests in kbd_buffer, not just the next one (Bug#8869).
2595
f01d3321
CY
25962012-02-23 Chong Yidong <cyd@gnu.org>
2597
2598 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2599 call when setting menu-bar-lines and tool-bar-lines parameters.
2600 (unwind_create_frame_1): New helper function.
2601
2602 * window.c (inhibit_window_configuration_change_hook): New var.
2603 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2604 (syms_of_window): Initialize it.
f01d3321 2605
86b847b6
CY
26062012-02-22 Chong Yidong <cyd@gnu.org>
2607
2608 * xterm.c (x_draw_image_relief): Add missing type check for
2609 Vtool_bar_button_margin (Bug#10743).
2610
a59225b1
CY
26112012-02-21 Chong Yidong <cyd@gnu.org>
2612
2613 * fileio.c (Vfile_name_handler_alist): Doc fix.
2614
2615 * buffer.c (Fget_file_buffer): Protect against invalid file
2616 handler return value.
2617
310f5bd4
PE
26182012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2619
cb3a28cc
PE
2620 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2621 when computing $valmask.
2622
310f5bd4
PE
2623 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2624 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2625 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2626 It's useless in that case, and it can cause problems on hosts
2627 that allocate halves of EMACS_INT values separately.
2628 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2629 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2630 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2631 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2632 it avoids undefined behavior on hosts where shifting right by more
2633 than the word width has undefined behavior.
2634
2375c96a
CY
26352012-02-19 Chong Yidong <cyd@gnu.org>
2636
2637 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2638 (Funhandled_file_name_directory, Ffile_name_as_directory)
2639 (Fdirectory_file_name, Fexpand_file_name)
2640 (Fsubstitute_in_file_name): Protect against invalid file handler
2641 return values (Bug#10845).
2642
3eb49e71
EZ
26432012-02-18 Eli Zaretskii <eliz@gnu.org>
2644
2645 * .gdbinit (pitx): Fix incorrect references to fields of the
2646 iterator stack.
2647
7b926f3f
CY
26482012-02-17 Chong Yidong <cyd@gnu.org>
2649
2650 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2651
11273115
PE
26522012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2653
2654 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2655 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2656
c3a70e2b
CY
26572012-02-15 Chong Yidong <cyd@gnu.org>
2658
2659 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2660 marked as special. Also, starting docstrings with * is obsolete.
2661
0ca43699
AS
26622012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2663
2664 * gnutls.c (emacs_gnutls_write): Fix last change.
2665
2e8f3c56
LI
26662012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2667
2668 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2669 send_process.
2670
af70074f
SM
26712012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2672
2673 * keymap.c (Fsingle_key_description): Handle char ranges.
2674
95986d52
CY
26752012-02-12 Chong Yidong <cyd@gnu.org>
2676
afd83bd1
CY
2677 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2678 as that creates a dangerous corner case.
2679
95986d52
CY
2680 * window.c (Fdelete_window_internal): Invalidate the mouse
2681 highlight (Bug#9904).
2682
bd7da63e
GM
26832012-02-12 Glenn Morris <rgm@gnu.org>
2684
2685 * xselect.c (Fx_own_selection_internal)
2686 (Fx_get_selection_internal, Fx_disown_selection_internal)
2687 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2688 * nsselect.m (Fx_own_selection_internal)
2689 (Fx_disown_selection_internal, Fx_selection_exists_p)
2690 (Fx_selection_owner_p, Fx_get_selection_internal):
2691 Sync docs and argument specs with the xselect.c versions.
2692
77abcbc2
LI
26932012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2694
2695 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2696
90b671e2
EZ
26972012-02-11 Eli Zaretskii <eliz@gnu.org>
2698
1c0ca0b7
EZ
2699 * w32select.c (Fx_selection_exists_p): Sync doc string and
2700 argument list with xselect.c. (Bug#10783)
2701
2702 * w16select.c (Fx_selection_exists_p): Sync doc string and
2703 argument list with xselect.c. (Bug#10783)
90b671e2 2704
49241268
GM
27052012-02-10 Glenn Morris <rgm@gnu.org>
2706
2707 * fns.c (Fsecure_hash): Doc fix.
2708
f998bbe7 27092012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2710
2711 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2712
0992bd9c
CY
27132012-02-07 Chong Yidong <cyd@gnu.org>
2714
2715 * buffer.c (Fbuffer_local_variables)
2716 (buffer_lisp_local_variables): Handle unbound vars correctly;
2717 don't let Qunbound leak into Lisp.
2718
af008560
GM
27192012-02-07 Glenn Morris <rgm@gnu.org>
2720
dd605cc4
GM
2721 * image.c (Fimagemagick_types): Doc fix.
2722
af008560
GM
2723 * image.c (imagemagick-render-type): Change it from a lisp object
2724 to an integer. Move the doc here from the lisp manual.
2725 Treat all values not equal to 0 the same.
2726
1449fa1d
CY
27272012-02-06 Chong Yidong <cyd@gnu.org>
2728
2729 * doc.c (store_function_docstring): Avoid applying docstring of
2730 alias to base function (Bug#2603).
2731
3723ec07
AS
27322012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2733
2734 * .gdbinit (pp1, pv1): Remove redundant defines.
2735 (pr): Use pp.
2736
79c1cc1e
CY
27372012-02-04 Chong Yidong <cyd@gnu.org>
2738
2739 * nsterm.m: Declare a global (Bug#10694).
2740
d7f29f8e
EZ
27412012-02-04 Eli Zaretskii <eliz@gnu.org>
2742
cae07000
SM
2743 * w32.c (get_emacs_configuration_options):
2744 Include --enable-checking, if specified, in the return value.
d7f29f8e 2745
3b95a6f9
MR
27462012-02-04 Martin Rudalics <rudalics@gmx.at>
2747
2748 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2749 after rounding frame sizes. (Bug#9723)
2750
d6fa96a6
EZ
27512012-02-04 Eli Zaretskii <eliz@gnu.org>
2752
2753 * keyboard.c (adjust_point_for_property): Don't position point
2754 before BEGV. (Bug#10696)
2755
df0b2940
PE
27562012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2757
2758 Handle overflow when computing char display width (Bug#9496).
2759 * character.c (char_width): Return EMACS_INT, not int.
2760 (char_width, c_string_width): Check for overflow when
2761 computing the width; this is possible now that individual
2762 characters can have unbounded width. Problem introduced
2763 by merge from Emacs 23 on 2012-01-19.
2764
6bee44d6
MA
27652012-02-02 Michael Albinus <michael.albinus@gmx.de>
2766
2767 * dbusbind.c (Fdbus_register_method): Mention the return value
2768 :ignore in the docstring.
2769
44f92739
GM
27702012-02-02 Glenn Morris <rgm@gnu.org>
2771
1b9f60cc
GM
2772 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2773
44f92739
GM
2774 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2775 Unconditionally set to t. (Bug#10673)
2776 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2777 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2778 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2779
c5d3843c
KH
27802012-02-02 Kenichi Handa <handa@m17n.org>
2781
2782 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2783 0, do not call append_composite_glyph.
2784
159462d4 27852012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2786
2787 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2788 NULL (Bug#6988).
2789 (x_produce_glyphs): If the component of a composition is a null
2790 string, set it->pixel_width to 1 to avoid zero-width glyph.
2791
78cef877
EZ
27922012-02-01 Eli Zaretskii <eliz@gnu.org>
2793
2794 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2795 first 2 arguments are identical. This makes inserting large
2796 output from a subprocess an order of magnitude faster on
2797 MS-Windows, where all sbrk'ed memory is always contiguous.
2798
97897668
GM
27992012-01-31 Glenn Morris <rgm@gnu.org>
2800
2801 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2802 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2803 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2804
31fd3586
GM
28052012-01-29 Glenn Morris <rgm@gnu.org>
2806
2807 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2808
0e24a8b2
CY
28092012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2810
2811 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2812
cc0adcb0
CY
28132012-01-28 Chong Yidong <cyd@gnu.org>
2814
2815 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2816
acc28cb9
CY
28172012-01-26 Chong Yidong <cyd@gnu.org>
2818
9c69cfb7
CY
2819 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2820
acc28cb9
CY
2821 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2822 repeat counts (Bug#10507).
2823
48da7392
GM
28242012-01-26 Glenn Morris <rgm@gnu.org>
2825
2826 * lread.c (syms_of_lread): Doc fix.
2827
14af5f7f
CY
28282012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2829
2830 * coding.c (encode_designation_at_bol): Change return value to
2831 EMACS_INT.
2832
0b21c100
CY
28332012-01-25 Chong Yidong <cyd@gnu.org>
2834
2835 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2836
3c2907f7
CY
28372012-01-21 Chong Yidong <cyd@gnu.org>
2838
2839 * floatfns.c (Fcopysign): Make the second argument non-optional,
2840 since nil is not allowed anyway.
2841
959ad23f
AS
28422012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2843
2844 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2845 (send_process): Likewise.
2846
34a02f46
MR
28472012-01-19 Martin Rudalics <rudalics@gmx.at>
2848
2849 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2850 (Vwindow_persistent_parameters): Do not use Qstate.
2851 Rewrite doc-strings.
34a02f46 2852
1259009a 28532012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2854
2855 * character.c (char_width): New function.
70d4fdf6
GM
2856 (Fchar_width, c_string_width, lisp_string_width):
2857 Use char_width (Bug#9496).
25ed9e61 2858
6a6ee00d
MR
28592012-01-16 Martin Rudalics <rudalics@gmx.at>
2860
2861 * window.c (Vwindow_persistent_parameters): New variable.
2862 (Fset_window_configuration, save_window_save): Handle persistent
2863 window parameters.
2864
c85efaf7
EZ
28652012-01-14 Eli Zaretskii <eliz@gnu.org>
2866
2867 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2868 thrashing the stack of the thread. (Bug#9087)
2869
5944709e
PE
28702012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2871
2872 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2873
e71f5d99
EZ
28742012-01-11 Eli Zaretskii <eliz@gnu.org>
2875
2876 * xdisp.c (rows_from_pos_range): Handle the case where the
2877 highlight ends on a newline. (Bug#10464)
2878 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2879 he end column for display of highlight that ends on a newline
2880 before a R2L line.
2881
ce316182
GM
28822012-01-11 Glenn Morris <rgm@gnu.org>
2883
2884 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2885 from load-path also when installation-directory is nil. (Bug#10208)
2886
5b43da69
GM
28872012-01-10 Glenn Morris <rgm@gnu.org>
2888
74cc8ff9
GM
2889 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2890
7d8d6e4e
GM
2891 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2892 Update template values to be closer to their typical values these days.
5b43da69 2893
a0db8d43
EZ
28942012-01-09 Eli Zaretskii <eliz@gnu.org>
2895
2896 * xdisp.c (rows_from_pos_range): Accept additional argument
2897 DISP_STRING, and accept any glyph in a row whose object is that
2898 string as eligible for mouse highlight. Fixes mouse highlight of
2899 display strings from overlays. (Bug#10464)
2900
9a0115ab 29012012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2902
b9110d6a 2903 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2904 * fileio.c (auto_saving_dir_umask): New static var.
2905 (Fmake_directory_internal): Use it.
2906 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2907 creating the directory. The old code temporarily assigns
2908 too-generous permissions to the directory.
2909 (do_auto_save_eh): Clear it.
b9110d6a 2910 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2911 that the var is always cleared.
2912
6c1bd3f3
EZ
29132012-01-07 Eli Zaretskii <eliz@gnu.org>
2914
2915 * search.c (scan_buffer): Pass character positions to
2916 know_region_cache, not byte positions. (Bug#6540)
2917
069d2b50
L
29182012-01-07 LynX <_LynX@bk.ru> (tiny change)
2919
2920 * w32.c (sys_rename): Report EXDEV when rename of a directory
2921 fails because the target is on another logical disk. (Bug#10284)
2922
75bf0d33
DB
29232012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2924
2925 * xterm.c (x_embed_request_focus): New function.
2926
2927 * xterm.h: Add prototype.
2928
2929 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2930
1c6e5a32
GM
29312012-01-05 Glenn Morris <rgm@gnu.org>
2932
2933 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2934
651e947e
EZ
29352012-01-01 Eli Zaretskii <eliz@gnu.org>
2936
2937 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2938 Load gnutls_transport_set_lowat only if GnuTLS version is below
2939 2.11.1.
2940 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2941 GnuTLS versions below 2.11.1.
2942
3778cdd8
AL
29432011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2944
2945 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2946 to the doc string advising against its use for altering the way
2947 windows are scrolled.
2948
0e5317f7
KH
29492011-12-28 Kenichi Handa <handa@m17n.org>
2950
2951 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2952 coding-system ASCII compatible only when it does not produce BOM
2953 on encoding (Bug#10383).
2954
93d5ca1f
JD
29552011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2956
2957 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2958 can scroll.
2959 (create_and_show_popup_menu): Always use menu_position_func for
2960 Gtk3 (Bug#10361).
2961
ca22b785
AS
29622011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2963
2964 * callint.c (Fcall_interactively): Don't truncate prompt string.
2965
d048e1e6
EZ
29662011-12-23 Eli Zaretskii <eliz@gnu.org>
2967
2968 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2969 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2970 resumed from there (after widening). (Bug#10360)
d048e1e6 2971
5ccaba1f
JD
29722011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2973
2974 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2975
204ee57f
JD
29762011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2977
b81d40f0
JB
2978 * nsterm.m (x_free_frame_resources):
2979 Release f->output_data.ns->miniimage.
204ee57f
JD
2980 (ns_index_color): Fix indentation. Do not retain
2981 color_table->colors[i].
2982
2983 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2984 before returning.
2985
2986 * nsfns.m (x_set_background_color): Assign return value from
2987 ns_index_color to face-background instead of NSColor*.
2988 (ns_implicitly_set_icon_type): Fix indentation.
2989 Change assignment in for loop to comparison.
2990
2991 * emacs.c (ns_pool): New variable.
2992 (main): Assign ns_pool.
2993 (Fkill_emacs): Call ns_release_autorelease_pool.
2994
2995 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2996 autorelease fdesc, release fdAttrs and tdict.
2997 (ns_get_covering_families): Release charset.
2998 (ns_findfonts): Release NSFontDescriptor created with new.
2999 (ns_uni_to_glyphs): Fix indentation.
3000 (setString): Release attrStr before assigning new value.
3001
c803b2b7
JD
30022011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3003
678f4426
JD
3004 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3005 and NS_IMPL_COCOA.
3006 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3007 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3008
cd394be1 30092011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3010
5fecd5fc
JD
3011 * nsterm.m (ns_term_init): Subscribe for notifications
3012 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3013 to method trackingNotification in EmacsMenu.
3014
3015 * nsmenu.m (trackingMenu): New variable.
3771cb17 3016 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3017 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3018 from Aquamacs (Bug#7030).
678f4426
JD
3019
30202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3021
c803b2b7
JD
3022 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3023 (symbol_to_nsstring): Fix indentation.
3024 (ns_symbol_to_pb): New function.
cae07000
SM
3025 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3026 (Fns_rotate_cut_buffers_internal): Remove.
3027 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3028 Fns_store_cut_buffer_internal.
3029 (ns_get_foreign_selection, Fx_own_selection_internal)
3030 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3031 (Fns_get_selection_internal, Fns_store_selection_internal):
3032 Use ns_symbol_to_pb and check if return value is nil.
3033 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3034 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3035 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3036 renamed to Sns_store_selection_internal.
3037 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3038 and remove this function.
3039 (ns_handle_selection_clear): Remove, never used.
3040 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3041 here.
3042
e1b01a3a
KB
30432011-12-17 Ken Brown <kbrown@cornell.edu>
3044
3045 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3046 GID is unknown (Bug#10257).
3047
2adb6e85
PE
30482011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3049
3050 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3051 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3052 which caused a build failure on GNU/Linux IA-64. This problem was
3053 introduced by my 2011-10-07 patch.
3054
d1d7b339
JL
30552011-12-15 Juri Linkov <juri@jurta.org>
3056
3057 * image.c (imagemagick_error): New function. (Bug#10112)
3058 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3059 Use `imagemagick_error' where ImageMagick functions return
3060 `MagickFalse'.
3061 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3062 proper order.
3063
100d5755
KH
30642011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3065
3066 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3067 fill background (Bug#8992).
3068
454592a6
MR
30692011-12-13 Martin Rudalics <rudalics@gmx.at>
3070
3071 * window.c (Vwindow_combination_resize)
3072 (Vwindow_combination_limit): Use t instead of non-nil in
3073 doc-strings.
61d4b438
MR
3074 (Vrecenter_redisplay): Add first sentence of doc-string on
3075 separate line.
53524d93 3076 (Frecenter): Fix doc-string typo.
454592a6 3077
3633e3aa
KH
30782011-12-11 Kenichi Handa <handa@m17n.org>
3079
3080 * coding.c (Funencodable_char_position): Pay attention to the
3081 buffer text relocation (Bug#9389).
3082
7b9d523a 30832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3084
7b9d523a
JD
3085 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3086 gtk_init (Bug#10100).
3087
b73189c6
EZ
30882011-12-10 Eli Zaretskii <eliz@gnu.org>
3089
3090 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3091 IT->string is nil. (Bug#10263)
3092
f7dfe5d6
JD
30932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3094
83faebb4
JD
3095 * nsterm.h (x_free_frame_resources): Declare.
3096
f7dfe5d6
JD
3097 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3098 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3099
3100 * nsterm.h (ns_get_defaults_value): Declare.
3101
3102 * nsterm.m (ns_default): Call ns_get_defaults_value.
3103
7cd4e72c
EZ
31042011-12-09 Eli Zaretskii <eliz@gnu.org>
3105
3106 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3107 (Bug#10170)
3108
b34d7317
YM
31092011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3110
3111 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3112 that where the value of an _OBJC_* symbol points to is in the .bss
3113 section (Bug#10240).
3114
76470ad1
KH
31152011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3116
3117 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3118 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3119
745fff94
KH
31202011-12-08 Kenichi Handa <handa@m17n.org>
3121
3122 * ftfont.c (get_adstyle_property): Fix previous change
3123 (Bug#10233).
3124
6e44397c
JB
31252011-12-07 Juanma Barranquero <lekktu@gmail.com>
3126
3127 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3128 dirs from the default value of EMACSLOADPATH (bug#10208).
3129
7efa6272
GM
31302011-12-07 Glenn Morris <rgm@gnu.org>
3131
3132 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3133 installation and source directories as well. (Bug#10208)
3134
f6fc4d87
CY
31352011-12-06 Chong Yidong <cyd@gnu.org>
3136
3137 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3138
2bf26180
GM
31392011-12-06 Glenn Morris <rgm@gnu.org>
3140
3141 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3142 as an error, not just -1. (Bug#10217)
3143
3a6ad4f0
CY
31442011-12-05 Chong Yidong <cyd@gnu.org>
3145
3146 * keyboard.c (process_special_events): New function.
3147 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3148
75a3b399
PE
31492011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3150
3151 * coding.c (encode_designation_at_bol): Don't use uninitialized
3152 local variable (Bug#9318).
3153
c3c9e25e
KH
31542011-12-05 Kenichi Handa <handa@m17n.org>
3155
3156 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3157 return Qnil (Bug#8046, Bug#10193).
3158
5eb05ea3
KH
31592011-12-05 Kenichi Handa <handa@m17n.org>
3160
3161 * coding.c (encode_designation_at_bol): New args charbuf_end and
3162 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3163 (coding_set_source): Return how many bytes coding->source was
3164 relocated.
3165 (coding_set_destination): Return how many bytes
3166 coding->destination was relocated.
3167 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3168 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3169
31702011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3171
3172 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3173 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3174 macro (Bug#9318).
3175
31762011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3177
3178 The following changes are to fix Bug#9318.
3179
a79703f5 3180 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3181 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3182 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3183 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3184
7dbda6df
JB
31852011-12-05 Juanma Barranquero <lekktu@gmail.com>
3186
3187 * lisp.h (process_quit_flag): Fix external declaration.
3188
6d5eb5b0
SM
31892011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3190
3191 Don't macro-inline non-performance-critical code.
3192 * eval.c (process_quit_flag): New function.
3193 * lisp.h (QUIT): Use it.
3194
a0c3fad0
JD
31952011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3196
3197 * nsfns.m (get_geometry_from_preferences): New function.
3198 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3199
6c07aac2
AS
32002011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3201
3202 * emacs.c (Qkill_emacs): Define.
3203 (syms_of_emacs): Initialize it.
3204 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3205 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3206 (quit_throw_to_read_char): Add parameter `from_signal'.
3207 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3208 * lisp.h (QUIT): Call Fkill_emacs if requested.
3209
c052ead4
JD
32102011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3211
3212 * widget.c (update_wm_hints): Return if wmshell is null.
3213 (widget_update_wm_size_hints): New function.
3214
3215 * widget.h (widget_update_wm_size_hints): Declare.
3216
3217 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3218 widget_update_wm_size_hints (Bug#10104).
3219
9e49252b
EZ
32202011-12-03 Eli Zaretskii <eliz@gnu.org>
3221
3222 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3223 before a newline, prepare the bidi iterator for consuming the
3224 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3225 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3226
02b16839
JL
32272011-12-02 Juri Linkov <juri@jurta.org>
3228
3229 * search.c (Fword_search_regexp): New Lisp function created from
3230 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3231 (Fword_search_backward, Fword_search_forward)
3232 (Fword_search_backward_lax, Fword_search_forward_lax):
3233 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3234 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3235
0068070e
SM
32362011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3237
3238 * fileio.c (Finsert_file_contents): Move after-change-function call
3239 to before the "handled:" label, since all "goto handled" appear in
3240 cases where the *-change-functions have already been properly called
3241 (bug#10117).
3242
3360a3fc
AS
32432011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3244
3245 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3246 waiting for input. (Bug#10169)
3247
73d6c093
EZ
32482011-11-30 Eli Zaretskii <eliz@gnu.org>
3249
3250 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3251 verifies glyph row's hash code--we have just reallocated the
3252 glyphs, so their contents can be complete garbage. (Bug#10164)
3253
febe6bea
JB
32542011-11-30 Juanma Barranquero <lekktu@gmail.com>
3255
3256 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3257
801a4313
EZ
32582011-11-30 Eli Zaretskii <eliz@gnu.org>
3259
3260 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3261 attributes are tested _before_ calling verify_row_hash, to protect
3262 against GCC re-ordering of the tests. (Bug#10164)
3263
2b56b87e
JD
32642011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3265
3266 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3267
3268 * xterm.c (handle_one_xevent): Only set async_visible and friends
3269 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3270 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3271 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3272
dbf31225
PE
32732011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3276 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3277 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3278 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3279 All uses changed to use GCPRO1 etc.
3280 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3281 Revert to old implementation (i.e., before 2011-03-11).
3282
1305621b
YM
32832011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3284
3285 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3286 of scroll runs so as to avoid assigning disabled bogus rows and
3287 unnecessary graphics copy operations.
3288
8c9afb46
EZ
32892011-11-27 Eli Zaretskii <eliz@gnu.org>
3290
3291 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3292 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3293 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3294 (malloc, free, realloc, calloc): Redirect to e_* only when
3295 compiling Emacs.
3296
3297 * lisp.h (GCTYPEBITS): Move before first use.
3298 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3299 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3300 this macro definition.
3301
3302 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3303 _MSC_VER.
3304
54e9e3bf
JD
33052011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3306
6d5eb5b0
SM
3307 * gtkutil.c (xg_create_frame_widgets):
3308 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3309 present with Gtk+ 2.0.
3310
83aca1cb
PE
33112011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3312
3313 * fileio.c (Finsert_file_contents): Undo previous change; see
3314 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3315
5b76caa4
PE
33162011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3317
3318 Rename locals to avoid shadowing.
3319 * fileio.c (Finsert_file_contents):
3320 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3321 * process.c (wait_reading_process_output):
3322 Rename inner 'proc' to 'p' to avoid shadowing.
3323 Indent for consistency with usual Emacs style.
3324
8c535114
EZ
33252011-11-25 Eli Zaretskii <eliz@gnu.org>
3326
3327 * xdisp.c (redisplay_window): If cursor row is not fully visible
3328 after recentering, and scroll-conservatively is set to a large
3329 number, scroll window by a few more lines to make the cursor fully
3330 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3331 (start_display): Don't move to the next line if the display should
3332 start at a newline that is part of a display vector or an overlay
3333 string. (Bug#10119)
8c535114 3334
fa4fdb5c
JL
33352011-11-24 Juri Linkov <juri@jurta.org>
3336
3337 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3338 after the `MagickPingImage' call. (Bug#10112)
3339
90ec88df
CY
33402011-11-23 Chong Yidong <cyd@gnu.org>
3341
3342 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3343
56e2e794
MR
33442011-11-23 Martin Rudalics <rudalics@gmx.at>
3345
3346 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3347 making another buffer current. (Bug#10114)
3348
b6e64c41
GM
33492011-11-23 Glenn Morris <rgm@gnu.org>
3350
3351 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3352
6b21de18
CY
33532011-11-23 Chong Yidong <cyd@gnu.org>
3354
3355 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3356 using it (Bug#5984).
3357
b12cd789
EZ
33582011-11-22 Eli Zaretskii <eliz@gnu.org>
3359
3360 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3361 and header-lines, as they don't have one computed for them.
3362 (Bug#10098)
3363
3364 * .gdbinit (prow): Make displayed values more self-explaining.
3365 Add row's hash code.
3366
261b6fd4
LMI
33672011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3368
3369 * process.c (wait_reading_process_output): Fix asynchrounous
3370 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3371 (wait_reading_process_output): Add comment and URL.
261b6fd4 3372
e7cfd277
JD
33732011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3374
3375 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3376
a9b9b7f5
CY
33772011-11-21 Chong Yidong <cyd@gnu.org>
3378
3379 * window.c (Fnext_window, Fprevious_window): Doc fix.
3380
b0d15b4f
SM
33812011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3382
3383 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3384
fe7a3057
JB
33852011-11-20 Juanma Barranquero <lekktu@gmail.com>
3386
3387 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3388
d2999b1a
MR
33892011-11-20 Martin Rudalics <rudalics@gmx.at>
3390
3391 * window.c (Fset_window_combination_limit): Rename argument
3392 STATUS to LIMIT.
3393 (Vwindow_combination_limit): Remove "status" from doc-string.
3394
d5ff9cd0
AS
33952011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3396
3397 * m/ibms390.h: Remove.
3398 * m/ibms390x.h: Don't include "ibms390.h".
3399
a5bb9bd3
SM
34002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3401
3402 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3403 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3404
cd1181db
JB
34052011-11-20 Juanma Barranquero <lekktu@gmail.com>
3406
3407 * casetab.c (Fset_case_table):
3408 * charset.c (Fcharset_after): Fix typos.
3409
615a3b8d 34102011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3411
17e845af
PE
3412 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3413 Otherwise, valgrind does not work on some platforms.
3414 Problem reported by Andreas Schwab in
6a0bf43d
PE
3415 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3416 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3417 is set, removing the need for VIRT_ADDRESS_VARIES.
3418 (PURE_P): Use a more-efficient implementation that needs just one
3419 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3420 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3421 to 4 (xorl, subq, cmpq, setbe).
3422 * alloc.c (pure): Always extern now, since that's the
3423 VIRT_ADDR_VARIES behavior.
3424 (PURE_POINTER_P): Use a single comparison, not two, for
3425 consistency with the new puresize.h.
3426 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3427 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3428 Remove VIRT_ADDR_VARIES no longer needed.
3429
f8fe6f96
EZ
34302011-11-19 Eli Zaretskii <eliz@gnu.org>
3431
3432 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3433 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3434 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3435 behave as if the cursor position were at the window margin.
3436
3437 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3438 and the cursor position is out of bounds, behave as if the cursor
3439 position were at the window margin. (Bug#10075)
3440
df05a53c
CY
34412011-11-18 Chong Yidong <cyd@gnu.org>
3442
3443 * window.c (Fwindow_combination_limit): Make first argument
3444 non-optional, since it is meaningless for live windows like the
3445 selected window.
61ccba97 3446
2071918e
DA
34472011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3448
3449 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3450
b50a28de
SM
34512011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3452
3453 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3454 (graft_intervals_into_buffer): Simplify.
3455
015137db
EZ
34562011-11-18 Eli Zaretskii <eliz@gnu.org>
3457
3458 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3459 hash values of the two rows.
3460 (copy_row_except_pointers): Preserve the used[] arrays and the
3461 hash values of the two rows. (Bug#10035)
68c95424 3462 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3463
3464 * xdisp.c (row_hash): New function, body extracted from
3465 compute_line_metrics.
3466 (compute_line_metrics): Call row_hash, instead of computing the
3467 hash code inline.
3468
3469 * dispnew.c (verify_row_hash): Call row_hash for computing the
3470 hash code of a row, instead of duplicating code from xdisp.c.
3471
3472 * dispextern.h (row_hash): Add prototype.
3473
a2addb04
TH
34742011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3475
3476 * frame.c (delete_frame): Don't delete the terminal when the last
3477 X frame is closed if emacs is built with GTK toolkit.
3478
df85d315
JB
34792011-11-17 Juanma Barranquero <lekktu@gmail.com>
3480
3481 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3482
a0c2d0ae
MR
34832011-11-17 Martin Rudalics <rudalics@gmx.at>
3484
3485 * window.c (Vwindow_splits): Rename to
3486 Vwindow_combination_resize. Suggested by Juri Linkov.
3487 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3488 of Vwindow_splits.
3489
58179cce
JB
34902011-11-16 Juanma Barranquero <lekktu@gmail.com>
3491
7877f373
JB
3492 * nsfns.m (Fns_font_name):
3493 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3494
b6f67890
MR
34952011-11-16 Martin Rudalics <rudalics@gmx.at>
3496
3497 * window.h (window): Rename slot "nest" to "combination_limit".
3498 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3499 (Fset_window_nest): Rename to Fset_window_combination_limit.
3500 (Vwindow_nest): Rename to Vwindow_combination_limit.
3501 (recombine_windows, make_parent_window, make_window)
3502 (Fsplit_window_internal, saved_window)
3503 (Fset_window_configuration, save_window_save): Rename all
3504 occurrences of window_nest to window_combination_limit.
3505
c7015153
JB
35062011-11-15 Juanma Barranquero <lekktu@gmail.com>
3507
3508 * image.c (imagemagick_load_image): Fix typo.
3509
322ad6ec
EZ
35102011-11-14 Eli Zaretskii <eliz@gnu.org>
3511
3512 * xdisp.c (display_line): Move the call to
3513 highlight_trailing_whitespace before the call to
3514 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3515 faces of all the glyphs to compute ROW's hash value.
3516 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3517
f067b8ec
JB
35182011-11-14 Juanma Barranquero <lekktu@gmail.com>
3519
3520 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3521 just return (bug#10044).
3522
1e5b2111
EZ
35232011-11-12 Eli Zaretskii <eliz@gnu.org>
3524
7ef3cbd5
EZ
3525 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3526 with user-defined heap size. Bump the default size of the temacs
3527 heap to 27MB, to avoid memory warning when running temacs.
3528 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3529
1e5b2111
EZ
3530 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3531 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3532 (verify_row_hash) [XASSERTS]: New function.
3533 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3534 that the hash value of glyph rows is correct.
1e5b2111 3535
89d61221
MR
35362011-11-12 Martin Rudalics <rudalics@gmx.at>
3537
3538 * window.h (window): Remove splits slot.
3539 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3540 (Fdelete_other_windows_internal, make_parent_window)
3541 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3542 (Fset_window_configuration, save_window_save): Don't deal with
3543 split status of windows.
3544 (saved_window): Remove splits slot.
3545 (Vwindow_splits): Rewrite doc-string.
3546
97f18cc8
JD
35472011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3548
3549 * xfns.c (unwind_create_frame):
3550 * nsfns.m (unwind_create_frame):
3551 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3552 Vframe_list (Bug#9999).
3553
22a648b4
DA
35542011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3555
0b381c7e 3556 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3557
659afede
KH
35582011-11-11 Kenichi Handa <handa@m17n.org>
3559
3560 * callproc.c (Fcall_process): Set the member dst_multibyte of
3561 process_coding.
3562
9ac0394b
KH
35632011-11-11 Johan Bockgård <bojohan@gnu.org>
3564
3565 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3566 avoid a crash (bug#9496).
3567
2fbdc249
CY
35682011-11-09 Chong Yidong <cyd@gnu.org>
3569
3570 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3571 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3572
ac6b1f81
PE
35732011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3576
09db192c
PE
35772011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3578
3579 Avoid some portability problems by eschewing 'extern inline' functions.
3580 The trivial performance wins aren't worth the portability hassles; see
3581 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3582 et seq.
3583 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3584 (window_box_width, window_box_left, window_box_left_offset)
3585 (window_box_right, window_box_right_offset): Undo previous change,
3586 by removing the "extern"s.
3587 * intervals.c (adjust_intervals_for_insertion)
3588 (adjust_intervals_for_deletion): Undo previous change,
3589 making these static again.
3590 (offset_intervals, temp_set_point_both, temp_set_point)
3591 (copy_intervals_to_string): No longer inline.
3592 * xdisp.c (window_text_bottom_y, window_box_width)
3593 (window_box_height, window_box_left_offset)
3594 (window_box_right_offset, window_box_left, window_box_right)
3595 (window_box): No longer inline.
3596
105216ed
CY
35972011-11-08 Chong Yidong <cyd@gnu.org>
3598
3599 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3600 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3601 Signal an error if not a live window.
105216ed
CY
3602 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3603 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3604
ae9e237f
JB
36052011-11-07 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * lisp.h (syms_of_abbrev): Remove declaration.
3608 Reported by CHENG Gao <chenggao@royau.me>.
3609
c7aa8333
EZ
36102011-11-07 Eli Zaretskii <eliz@gnu.org>
3611
3612 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3613 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3614 of temacs in GUI mode.
3615
be7f5545
MR
36162011-11-07 Martin Rudalics <rudalics@gmx.at>
3617
3618 * window.h: Declare delete_all_child_windows instead of
3619 delete_all_subwindows.
3620 * window.c (Fwindow_nest, Fset_window_nest)
3621 (Fset_window_new_total, Fset_window_new_normal)
3622 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3623 (delete_all_subwindows): Rename to delete_all_child_windows.
3624 (Fdelete_other_windows_internal, Fset_window_configuration):
3625 Call delete_all_child_windows instead of delete_all_subwindows.
3626 * frame.c (delete_frame): Call delete_all_child_windows instead
3627 of delete_all_subwindows.
3628
ca78dc43
PE
36292011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3630
3631 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3632 This is also needed for porting to any host where GC_MARK_STACK is
3633 not GC_MAKE_GCPROS_NOOPS.
3634 (which_symbols): Use it.
3635
a0241d01
KH
36362011-11-07 Kenichi Handa <handa@m17n.org>
3637
3638 * coding.c (coding_set_destination): Check coding->src_pos only
3639 when coding->src_object is a buffer (bug#9910).
3640
3641 * process.c (send_process): Set the member src_multibyte of coding
3642 to 0 (bug#9911) when sending a unibyte text.
3643
3644 * callproc.c (Fcall_process): Set the member src_multibyte of
3645 process_coding to 0 (bug#9912).
3646
a64bfdfa 36472011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3648
3649 * xmenu.c (cleanup_widget_value_tree): New function.
3650 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3651 calling free_menubar_widget_value_tree directly (Bug#9830).
3652
cb41b32a
PE
36532011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3654
3655 Fix some portability problems with 'inline'.
3656 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3657 (window_box_width, window_box_left, window_box_left_offset)
3658 (window_box_right, window_box_right_offset): Declare extern.
3659 Otherwise, these inline functions do not conform to C99 and
3660 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3661 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3662 * intervals.c (adjust_intervals_for_insertion)
3663 (adjust_intervals_for_deletion): Now extern, because otherwise the
3664 extern inline functions 'offset_intervals' couldn't refer to it.
3665 (static_offset_intervals): Remove.
3666 (offset_intervals): Rewrite using the old contents of
3667 static_offset_intervals. The old version didn't conform to C99
3668 because an extern inline function contained a reference to an
3669 identifier with static linkage.
3670
b7041366
AS
36712011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3672
3673 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3674 GC.
3675
88a37c4d
EZ
36762011-11-06 Eli Zaretskii <eliz@gnu.org>
3677
3678 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3679 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3680 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3681 return Qleft_to_right.
3682
49745b39
CY
36832011-11-06 Chong Yidong <cyd@gnu.org>
3684
3685 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3686 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3687 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3688 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3689 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3690 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3691 (Fwindow_vscroll): Doc fix.
3692 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3693 argument, since it makes no sense to pass a live window and for
3694 consistency with window-child.
3695
1f05cd82
CS
36962011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3697
3698 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3699 support MSVC.
3700
22610910
JR
37012011-11-05 Jason Rumney <jasonr@gnu.org>
3702
3703 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3704 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3705 fonts (Bug#6029).
3706 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3707 bitwise arithmetic preventing use of unicode-sip and non-truetype
3708 opentype fonts.
3709
a06776b2
EZ
37102011-11-05 Eli Zaretskii <eliz@gnu.org>
3711
3ad924ba
EZ
3712 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3713 "emacs"-only part.
3714
a06776b2
EZ
3715 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3716 initialization code to keep similarity to xfns.c after changes
3717 from 2011-11-05.
3718
c9e7db78
JD
37192011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3720
a97f8f3f
JD
3721 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3722 (unwind_create_frame): New function (Bug#9943).
3723 (Fx_create_frame): Restructure code to be more similar to the one in
3724 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3725 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3726 Move terminal->reference_count++ just before making the frame official
3727 (Bug#9943).
3728
3729 * nsterm.m (x_free_frame_resources): New function.
3730 (x_destroy_window): Move code to x_free_frame_resources.
3731
c9e7db78 3732 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3733 (Fx_create_frame, x_create_tip_frame):
3734 Move terminal->reference_count++ just before making the frame
75f1671a 3735 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3736 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3737
a6fc3b5c
EZ
37382011-11-05 Eli Zaretskii <eliz@gnu.org>
3739
3740 Support MSVC build with newer versions of Visual Studio.
3741 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3742 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3743 nt/gmake.defs.
3744
3745 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3746 which are not supported by MSVC.
3747 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3748 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3749 bitfields.
3750 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3751 types in bitfields.
3752 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3753
3754 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3755
58179cce 37562011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3757
3758 Support MSVC build with newer versions of Visual Studio.
3759 * w32.c: Don't include w32api.h for MSVC.
3760 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3761
3762 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3763 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3764 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3765 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3766 e_* cousins.
3767 (alloca) [_MSC_VER]: Define to _alloca.
3768
3769 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3770
3771 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3772
a58c13ed
EZ
37732011-11-04 Eli Zaretskii <eliz@gnu.org>
3774
3775 * xdisp.c (note_mouse_highlight): If either of
3776 previous/next-single-property-change returns nil, treat that as
3777 the beginning or the end of the buffer. (Bug#9955)
3778
fe0b6370
JD
37792011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3780
a58c13ed 3781 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3782 label is not null (Bug#9951).
3783 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3784 may be NULL.
3785
89bd5ee1
EZ
37862011-11-04 Eli Zaretskii <eliz@gnu.org>
3787
3788 * window.c (Fwindow_body_size): Mention in the doc string that the
3789 return value is in frame's canonical units. (Bug#9949)
3790
84c3edb9
EZ
37912011-11-03 Eli Zaretskii <eliz@gnu.org>
3792
4e2fb5c7
EZ
3793 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3794
84c3edb9 3795 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3796 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3797 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3798
bc17a887
EZ
37992011-11-01 Eli Zaretskii <eliz@gnu.org>
3800
3801 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3802 Don't stop backward scan on the continuation glyph, even though
3803 its CHARPOS is positive.
6d5eb5b0
SM
3804 (mouse_face_from_buffer_pos, note_mouse_highlight):
3805 Rename cover_string to disp_string.
bc17a887 3806
4ee88440
MR
38072011-11-01 Martin Rudalics <rudalics@gmx.at>
3808
3809 * window.c (temp_output_buffer_show): Don't use
3810 Vtemp_buffer_show_specifiers.
3811 (Vtemp_buffer_show_specifiers): Remove unused variable.
3812
c2ff3c02
EZ
38132011-10-30 Eli Zaretskii <eliz@gnu.org>
3814
3815 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3816 past the beginning of the current glyph matrix.
3817
58179cce 38182011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3819
3820 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3821 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3822 HAVE_GTK3 (Bug#9869).
b77a6a7f 3823
3b574623
JD
3824 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3825 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3826
b77a6a7f
JD
3827 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3828
3829 * xterm.c: Declare x_handle_net_wm_state to return int.
3830 (handle_one_xevent): Check if we are iconified but don't have
3831 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3832 (get_current_wm_state): Return non-zero if not hidden,
3833 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3834 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3835 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3836 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3837
196e41e4
PE
38382011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3839
3840 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3841 so that this new function doesn't get optimized away by a
3842 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3843
021f2e1a
AS
38442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3845
3846 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3847
8b058d44
EZ
38482011-10-29 Eli Zaretskii <eliz@gnu.org>
3849
3850 Fix the `xbytecode' command.
3851 * .gdbinit (xprintbytestr): New command.
b50a28de 3852 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3853 (xbytecode): Print the byte-code string as well.
3854
4452fb80
EZ
38552011-10-29 Kim Storm <storm@cua.dk>
3856
8b058d44
EZ
3857 * alloc.c (which_symbols): New function.
3858
21b72067
AS
38592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3860
3861 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3862 line. (Bug#9903)
3863
83ed7b5c
GM
38642011-10-29 Glenn Morris <rgm@gnu.org>
3865
3866 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3867 Not clear what it was for, and it causes various bugs. (Bug#9839)
3868
5a7a728b
EZ
38692011-10-28 Eli Zaretskii <eliz@gnu.org>
3870
3871 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3872 possible random value that matches one of those tested as
3873 condition to clear the mouse face.
3874
d3d0842f
CY
38752011-10-28 Chong Yidong <cyd@gnu.org>
3876
3877 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3878
31b39d13
DN
38792011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3880
3881 * window.c (make_window): Initialize phys_cursor_on_p.
3882
9aba6043
SM
38832011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3884
3885 * lisp.h (struct Lisp_Symbol): Update comments.
3886
c20992f4
JB
38872011-10-28 Juanma Barranquero <lekktu@gmail.com>
3888
3889 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3890
db4f02f2
EZ
38912011-10-28 Eli Zaretskii <eliz@gnu.org>
3892
3893 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3894 <oslsachem@gmail.com> for helping to debug this.
3895
3896 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3897 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3898 (g_b_init_get_glyph_outline_w): New static variables.
3899 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3900 (GetGlyphOutlineW_Proc): New typedefs.
3901 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3902 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3903 New functions.
3904 (w32font_open_internal, compute_metrics):
3905 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3906 instead of calling the "wide" APIs directly.
3907
3908 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3909
3910 * w32.h (syms_of_w32font): Add prototype.
3911
87e68db4
JB
39122011-10-27 Juanma Barranquero <lekktu@gmail.com>
3913
3914 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3915 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3916 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3917 (Fmove_to_window_line): Doc fix.
3918
435c1d67
CY
39192011-10-27 Chong Yidong <cyd@gnu.org>
3920
3921 * process.c (make_process): Set gnutls_state to NULL.
3922
3923 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3924 non-NULL, regardless of GNUTLS_INITSTAGE.
3925 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3926 an error. Set process slots as soon as we allocate them.
3927
3928 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3929
9c6c6f49
CY
39302011-10-27 Chong Yidong <cyd@gnu.org>
3931
9aba6043
SM
3932 * gnutls.c (emacs_gnutls_deinit): New function.
3933 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3934 (Fgnutls_deinit, Fgnutls_boot): Use it.
3935
3936 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3937 (deactivate_process): Call emacs_gnutls_deinit.
3938
657d08d3
JB
39392011-10-27 Juanma Barranquero <lekktu@gmail.com>
3940
3941 * image.c (x_create_x_image_and_pixmap):
3942 * w32.c (sys_rename, w32_delayed_load):
3943 * w32font.c (fill_in_logfont):
3944 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3945
5430d399
JB
39462011-10-26 Juanma Barranquero <lekktu@gmail.com>
3947
3948 * w32fns.c (w32_default_color_map): New function,
3949 extracted from Fw32_default_color_map.
a7ef684b 3950 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3951
fe0055fa
PE
39522011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3955
e6346438
SM
39562011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3957
3958 * keyboard.c (test_undefined): New function (bug#9751).
3959 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3960
e112cc37
ET
39612011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3962
3963 * sysdep.c (init_sys_modes): Fix the check for the controlling
3964 terminal (Bug#6649).
3965
7b5d6677
EZ
39662011-10-20 Eli Zaretskii <eliz@gnu.org>
3967
3968 * dispextern.h (struct bidi_it): New member next_en_type.
3969
3970 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3971 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3972 current character, check also for next_en_type being WEAK_EN.
3973 (bidi_resolve_weak): Don't enter the expensive loop if the current
3974 position is before next_en_pos. Record the bidi type of the first
3975 non-ET, non-BN character we find, in addition to its position.
3976 (bidi_level_of_next_char): Invalidate next_en_type when
3977 next_en_pos is over-stepped.
3978
7da0b018
PE
39792011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3980
3981 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3982 * editfns.c: Rewrite current-time-zone so that it invokes
3983 the equivalent of (format-time-string "%Z") to get the time zone name.
3984 This fixes a bug when the time zone name contains characters that
3985 need converting from the system time locale to Emacs internal format.
3986 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3987 that patch fixed format-time-string to do the conversion, but
3988 I forgot to fix current-time-zone.
3989 (format_time_string): New function, containing most of
3990 what Fformat_time_string used to contain.
3991 (Fformat_time_string): Rewrite in terms of format_time_string.
3992 This doesn't change this function's behavior.
3993 (current-time-zone): Rewrite to use format_time_string.
3994 This fixes the bug reported by Michael Schierl in
3995 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3996 Jason Rumney's 2007-06-07 change worked around this bug, but
3997 didn't fix it.
3998 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3999
8547b010
EZ
40002011-10-19 Eli Zaretskii <eliz@gnu.org>
4001
4002 * xdisp.c (start_display): If the character at POS is displayed
4003 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4004 (try_window_reusing_current_matrix): If a line ends in a display
4005 vector or the next line starts in a display vector, continue
4006 redrawing the window even though the character position of
4007 start_row was reached.
8547b010
EZ
4008 (Bug#9771, part 2)
4009
4e948d15
CY
40102011-10-18 Chong Yidong <cyd@gnu.org>
4011
4012 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4013 with nobreak-char-display too.
4014
4787455f
EZ
40152011-10-18 Eli Zaretskii <eliz@gnu.org>
4016
4017 Fix part 3 of bug#9771.
4018 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4019 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4020 non-neutral characters if the current character is a paragraph
4021 separator (a.k.a. Newline). This avoids running the same
4022 expensive loop twice, once when we consume the preceding newline
4023 and the other time when the line actually needs to be displayed.
4024 Avoid the loop when we see neutrals on the base embedding level
4025 following a character whose directionality is the same as the
4026 paragraph's. This avoids running the expensive loop when a line
4027 ends in a long sequence of neutrals, like control characters.
4028 Add assertion against STRONG_AL type. Slightly rearrange code
4029 that determines the type of a neutral given the first non-neutral
4030 that follows it.
4031 (bidi_level_of_next_char): Set next_en_pos to zero when
4032 invalidating its info.
4033
2c91f553
EZ
40342011-10-17 Eli Zaretskii <eliz@gnu.org>
4035
4036 * xdisp.c (push_display_prop): Determine whether to record string
4037 or buffer position by IT->string, not by IT->method. Allow
4038 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4039 (move_it_vertically_backward): Don't look for character position
4040 immediately after the newline when in a continuation line.
4041 (Bug#9771, part 1)
2c91f553 4042
c7b08b0d
MR
40432011-10-15 Martin Rudalics <rudalics@gmx.at>
4044
4045 * window.c (coordinates_in_window): Rewrite and delabelize
4046 vertical border check. (Bug#5357) (Bug#9618)
4047
6b02f655
SM
40482011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4049
4050 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4051 errors in XSetWindowBorder (bug#9310).
4052
81d40c92
DA
40532011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4054
4055 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4056 avoid crash when xmalloc overrun checking is enabled.
4057
d4172c3b
EZ
40582011-10-13 Eli Zaretskii <eliz@gnu.org>
4059
4060 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4061 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4062 cursor motion with <left> and <right> arrow keys.
4063
4064 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4065 some callers set that themselves.
4066
b00eea75
EZ
40672011-10-12 Eli Zaretskii <eliz@gnu.org>
4068
4069 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4070 display string and the previous row comes from the same string and
4071 is empty. (Bug#9739) (Bug#9738)
4072
8fe012c4
SM
40732011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4074
4075 * doc.c (get_doc_string): Encode file name (bug#9735).
4076
0074aef2
EZ
40772011-10-12 Eli Zaretskii <eliz@gnu.org>
4078
79beb178
EZ
4079 * bidi.c (bidi_level_of_next_char):
4080 * xdisp.c (get_visually_first_element): Remove old incorrect
4081 comments regarding the Unicode Line Separator character.
4082
0074aef2
EZ
4083 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4084
6e4b3fbe
DA
40852011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4086
4087 * alloc.c (Fgc_status): Do not access beyond zombies array
4088 boundary if nzombies > MAX_ZOMBIES.
4089 * alloc.c (dump_zombies): Add missing format specifier.
4090
0324f3af
PE
40912011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4092
b5525cac
PE
4093 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4094 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4095
0324f3af
PE
4096 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4097 Some packages use them to denote characters with modifiers.
4098
e9b5f888
AS
40992011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4100
4101 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4102 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4103 matching a pp-number. Rename parameter var to var1.
4104
127827c0
SM
41052011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4106
4107 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4108
c8fd3bd0
GM
41092011-10-08 Glenn Morris <rgm@gnu.org>
4110
4111 * callint.c (Fcall_interactively): Give a more explicit error for the
4112 'c' case with a non-character input. (Bug#8479)
4113
352ec8ff
EZ
41142011-10-08 Eli Zaretskii <eliz@gnu.org>
4115
03669ccb
EZ
4116 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4117 lines.
7061c986
EZ
4118 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4119 lines that are hscrolled on the left.
03669ccb 4120
352ec8ff
EZ
4121 * dispnew.c (buffer_posn_from_coords): Account for a possible
4122 presence of header-line. (Bug#4426)
4123
a66cfb1c
SM
41242011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4125
6b02f655
SM
4126 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4127 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4128
7c5ee88e
PE
41292011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4132 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4133 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4134 this makes Emacs dump core during garbage collection on rare
4135 occasions. sizeof is obviously inferior to offsetof here, so
4136 stick with offsetof.
4137 (GC_POINTER_ALIGNMENT): New macro.
4138 (mark_memory): Omit 3rd (offset) arg; caller changed.
4139 Don't assume EMACS_INT alignment is the same as pointer alignment.
4140
df1bbe5b
SM
41412011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4142
4143 * keyboard.c (read_key_sequence_remapped): New var.
4144 (read_key_sequence): Compute remapping in the right buffer.
4145 (command_loop_1): Use read_key_sequence's remapping directly.
4146
51553db6
SM
41472011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4148
32c1fffd
SM
4149 * dired.c (file_name_completion): Don't expand file name.
4150 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4151 before checking file name handler.
4152
51553db6
SM
4153 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4154 they've been requested explicitly (bug#9591).
4155
b6bd1599 41562011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4157
4158 * keymap.c (Fsingle_key_description): Use make_specified_string
4159 instead of build_string to build string from push_key_description.
4160 (Bug#5193)
4161
f701dc2a
PE
41622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4163
4222c55d
PE
4164 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4165 This fixes a Y2038 bug on 64-bit hosts.
4166 * buffer.c (reset_buffer):
4167 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4168 (Fclear_buffer_auto_save_failure):
4169 Use 0, not -1, to represent an unset failure time, since time_t
4170 might not be signed.
4171
f701dc2a
PE
4172 Remove dependency on glibc malloc internals.
4173 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4174 Move back here from lisp.h, but with their new implementations.
4175 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4176 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4177 * charset.c (charset_table_init): New static var.
4178 (syms_of_charset): Use it instead of xmalloc. This removes a
4179 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4180 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4181 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4182 Move back to alloc.c.
4183 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4184 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4185
9ceebf39
JD
41862011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4187
4188 * nsterm.m (windowDidResize): Call x_set_window_size only when
4189 ns_in_resize is true. Otherwise set pixelwidth/height and
4190 call change_frame_size (Bug#9628).
4191
cb993c58
PE
41922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4193
3930c88b
PE
4194 Port --enable-checking=all to Fedora 14 x86-64.
4195 * charset.c (syms_of_charset): Also account for glibc malloc's
4196 internal overhead when calculating the initial malloc maximum.
4197
cb993c58
PE
4198 Port --enable-checking=all to Fedora 14 x86.
4199 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4200 Move to lisp.h.
4201 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4202 (overrun_check_realloc, overrun_check_free):
4203 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4204 That way, xmalloc returns a properly-aligned pointer even if
4205 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4206 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4207 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4208 into account when calculating the initial malloc maximum.
4209 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4210 Move here from alloc.c, so that charset.c can use it too.
4211 Properly align; the old code wasn't right for common 32-bit hosts
4212 when configured with --enable-checking=all.
4213 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4214 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4215
31bed486
EZ
42162011-09-29 Eli Zaretskii <eliz@gnu.org>
4217
04c70788 4218 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4219 use EDOM.
4220
fbcaa2f3
EZ
42212011-09-28 Eli Zaretskii <eliz@gnu.org>
4222
4223 * xdisp.c (compute_display_string_end): If there's no display
4224 string at CHARPOS, return -1.
4225
4226 * bidi.c (bidi_fetch_char): When compute_display_string_end
4227 returns a negative value, treat the character as a normal
4228 character not covered by a display string. (Bug#9624)
4229
a239d4e9
JB
42302011-09-28 Juanma Barranquero <lekktu@gmail.com>
4231
4232 * lread.c (Fread_from_string): Fix typo in docstring.
4233
88652fd5
EZ
42342011-09-27 Eli Zaretskii <eliz@gnu.org>
4235
4236 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4237 newline, reseat the iterator instead of bidi-iterating there one
4238 character at a time. (Bug#9610)
32c1fffd
SM
4239 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4240 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4241
ed497dd4
AS
42422011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4243
4244 * lread.c (readevalloop): Use correct code for NBSP.
4245 (read1): Likewise. (Bug#9608)
4246
b2bf61aa
MA
42472011-09-25 Michael Albinus <michael.albinus@gmx.de>
4248
4249 * dbusbind.c (Fdbus_register_signal): When service is not
4250 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4251
32bbb17c
GM
42522011-09-25 Glenn Morris <rgm@gnu.org>
4253
4254 * buffer.c (truncate-lines): Doc fix.
4255
94e0933e
CY
42562011-09-24 Chong Yidong <cyd@stupidchicken.com>
4257
4258 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4259 (Fset_window_next_buffers): Doc fix.
4260
cddde921
GM
42612011-09-24 Glenn Morris <rgm@gnu.org>
4262
4263 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4264
1260aef1
PE
42652011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4266
25b4bfa0
PE
4267 Fix minor problems found by static checking.
4268 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4269 * indent.c (Fvertical_motion): Fix == vs = typo.
4270
e3cbd34b
EZ
42712011-09-24 Eli Zaretskii <eliz@gnu.org>
4272
a66cfb1c
SM
4273 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4274 Default value is now t. Doc fix.
6bf7006f 4275
e3cbd34b 4276 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4277 logic when moving up, not only when moving down. Fix the
e3cbd34b 4278 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4279 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4280
4281 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4282 CHARPOS is covered by a display string which includes newlines.
4283 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4284 is covered by a display string with embedded newlines.
4285
a3de0cbd
MA
42862011-09-24 Michael Albinus <michael.albinus@gmx.de>
4287
4288 * dbusbind.c (Fdbus_register_signal): Add match rule to
4289 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4290 (Fdbus_register_method, Vdbus_registered_objects_table):
4291 Fix docstring.
a3de0cbd 4292
b260039d
JM
42932011-09-24 Jim Meyering <meyering@redhat.com>
4294
32c1fffd 4295 do not ignore write error for any output size
b260039d
JM
4296 The previous change was incomplete.
4297 While it makes emacs --batch detect the vast majority of stdout
4298 write failures, errors were still ignored whenever the output size is
4299 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4300 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4301 && echo FAIL: ignored write error
4302 FAIL: ignored write error
4303 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4304 && echo FAIL: ignored write error
4305 FAIL: ignored write error
4306 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4307
8eca8a7c
AS
43082011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4309
4310 * emacs.c (Fkill_emacs): In noninteractive mode exit
4311 non-successfully if a write error occurred on stdout. (Bug#9574)
4312
3341db62
EZ
43132011-09-21 Eli Zaretskii <eliz@gnu.org>
4314
4315 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4316 the xassert test.
4317
4318 * dispextern.h (struct it): Update the comment documenting what
4319 can it->OBJECT be.
4320
8c203dbf
EZ
43212011-09-20 Eli Zaretskii <eliz@gnu.org>
4322
4323 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4324 a display string, extend search for cursor position to end of row.
4325 (find_row_edges): If the row ends in a newline from a display
4326 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4327 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4328 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4329 non-empty line. Fixes confusing cursor motion with arrow keys at
4330 the beginning of a line that starts with whitespace.
8c203dbf 4331
a4824228
LMI
43322011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4333
4334 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4335 (bug#9493).
4336
33ed493b
CY
43372011-09-18 Chong Yidong <cyd@stupidchicken.com>
4338
4339 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4340 boolean (Bug#9154).
4341
56cd55c8
EZ
43422011-09-18 Eli Zaretskii <eliz@gnu.org>
4343
4344 * xdisp.c (display_line): Record maximum and minimum buffer
4345 positions even if no glyphs were produced (e.g., by a zero-width
4346 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4347 buffer positions that will be removed from the glyph row because
4348 they don't fit.
c02dcedf
EZ
4349 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4350 column is beyond frame width: don't subtract 1 "pixel" when
4351 computing width of the stretch.
3e62b7e0
EZ
4352 (reseat_at_next_visible_line_start): Undo the change made on
4353 2011-09-17 that saved paragraph information and restored it after
4354 the call to `reseat'. (Bug#9545)
56cd55c8 4355
5ed99d36 43562011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4357
4358 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4359 and turn window cursor on if cleared (Bug#9415).
4360
5ed99d36 43612011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4362
4363 * search.c (boyer_moore): Take unibyte characters from pattern
4364 literally. (Bug#9458)
4365
9bade7b2
EZ
43662011-09-18 Eli Zaretskii <eliz@gnu.org>
4367
4368 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4369
e5e9d610
PE
43702011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4371
87e4427a
PE
4372 Fix minor problem found by static checking.
4373 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4374 initialized, to pacify gcc -Wuninitialized.
4375
e5e9d610
PE
4376 * fileio.c: Report proper errno when syscall falls.
4377 (Finsert_file_contents): Save and restore errno,
4378 so that report_file_error outputs the correct diagnostic.
4379 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4380
a1674f0b
EZ
43812011-09-18 Eli Zaretskii <eliz@gnu.org>
4382
4383 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4384
fbfb6dd4
EZ
43852011-09-17 Eli Zaretskii <eliz@gnu.org>
4386
4387 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4388 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4389
bb187662
EZ
43902011-09-17 Eli Zaretskii <eliz@gnu.org>
4391
1137e8b8 4392 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4393 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4394
4395 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4396 (bidi_find_paragraph_start): Search back for paragraph beginning
4397 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4398 (bidi_move_to_visually_next): Only trigger paragraph-related
4399 computations when the last character is a newline or at EOB, not
4400 just any NEUTRAL_B. (Bug#9470)
4401
bb187662
EZ
4402 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4403 truncated lines if point is covered by a display string. (Bug#9524)
4404
2e621251
PE
44052011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4406
4407 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4408 (cons_to_x_long): New function.
4409 (lisp_data_to_selection_data): Use it. Correct the test for
4410 short-versus-long data; it was negated. Break out of vector
4411 loop, for efficiency, when a long datum is discovered.
4412
91a15bc6
SM
44132011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4414
4415 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4416
b41c3a35
EZ
44172011-09-16 Eli Zaretskii <eliz@gnu.org>
4418
4419 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4420 GCC PR/17406) by declaring this function with external scope.
4421
7812ba2d
PE
44222011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4425 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4426
cf7edc2a
AS
44272011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4428
4429 * editfns.c (Fformat): Correctly handle text properties on "%%".
4430
bd01620e
EZ
44312011-09-15 Eli Zaretskii <eliz@gnu.org>
4432
4433 * xterm.c (x_draw_composite_glyph_string_foreground):
4434 * w32term.c (x_draw_composite_glyph_string_foreground):
4435 * term.c (encode_terminal_code):
4436 * composite.c (composition_update_it, get_composition_id):
4437 * xdisp.c (get_next_display_element)
4438 (fill_composite_glyph_string): Add comments about special meaning
4439 of TAB characters in a composition.
4440
a02719a3
PE
44412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4442
4443 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4444 This occurs when processing a multibyte format.
4445 Problem reported by Wolfgang Jenker.
a02719a3 4446
72589a3c
JB
44472011-09-15 Johan Bockgård <bojohan@gnu.org>
4448
4449 * xdisp.c (try_cursor_movement): Only check for exact match if
4450 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4451
1c14176c
PE
44522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4453
4454 Remove unused external symbols.
4455 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4456 * xdisp.c (calc_pixel_width_or_height): Now static.
4457 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4458 * indent.c (check_display_width):
4459 * w32term.c: Fix comment to match code.
4460 * xterm.c, xterm.h (x_catching_errors): Remove.
4461
d2eea5b5
PE
44622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 * xselect.c: Use signed conversions more consistently (Bug#9498).
4465 (selection_data_to_lisp_data): Assume incoming selection data are
4466 signed integers, not unsigned. This is to be consistent with
4467 outgoing selection data, which was modified to use signed integers
4468 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4469 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4470 expects long, not unsigned long.
4471
46888499
EZ
44722011-09-14 Eli Zaretskii <eliz@gnu.org>
4473
4474 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4475 computation of loop end. Reported by Johan Bockgård
4476 <bojohan@gnu.org>.
4477
ef8ef9fb
CY
44782011-09-13 Chong Yidong <cyd@stupidchicken.com>
4479
4480 * frame.c (Fother_visible_frames_p): Function deleted.
4481
fa819fed
EZ
44822011-09-12 Eli Zaretskii <eliz@gnu.org>
4483
4484 * indent.c (compute_motion): Process display vector front to back
4485 rather than the other way around. (Bug#2496)
4486
2ba8e008
SM
44872011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4488
4489 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4490
20f53c69
CY
44912011-09-11 Chong Yidong <cyd@stupidchicken.com>
4492
4493 * minibuf.c (Fread_from_minibuffer): Doc fix.
4494
d562d7a4
EZ
44952011-09-11 Eli Zaretskii <eliz@gnu.org>
4496
4497 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4498 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4499
1c4d7f3d
LMI
45002011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4501
4502 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4503 value for non-existent files.
4504
b885bf36
EZ
45052011-09-11 Eli Zaretskii <eliz@gnu.org>
4506
4507 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4508 set its "size" to -1. This will set the modtime_size field of
4509 the corresponding buffer to -1, which is what
4510 verify-visited-file-modtime expects for files that do not exist.
4511 (Bug#9139)
4512
6612f0bf
PE
45132011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4516 here ...
4517 * lisp.h: ... from here. push_key_description is no longer
4518 defined in keyboard.c, so its declaration should not be in
4519 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4520 logically belongs with push_key_description.
4521
dfb3f755
PE
45222011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4523
4524 * buffer.h: Include <sys/types.h> instead of <time.h>.
4525 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4526 Problem reported by Herbert J. Skuhra.
4527
3134906c
LMI
45282011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4529
4530 * xml.c (parse_region): Make the parsing work for
4531 non-comment-starting XML files again (bug#9144).
4532
8d903f4e
AS
45332011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4534
4535 * image.c (gif_load): Fix calculation of bottom and right corner.
4536 (Bug#9468)
4537
80ad64f4
EZ
45382011-09-10 Eli Zaretskii <eliz@gnu.org>
4539
4540 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4541 redisplay in small windows.
4542
208a048d
EZ
45432011-09-09 Eli Zaretskii <eliz@gnu.org>
4544
4545 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4546
9b1c252e
MR
45472011-09-08 Martin Rudalics <rudalics@gmx.at>
4548
4549 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4550 Operate on live windows only.
4551
2949f33b
JB
45522011-09-08 Juanma Barranquero <lekktu@gmail.com>
4553
4554 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4555
e08dcafd
EZ
45562011-09-07 Eli Zaretskii <eliz@gnu.org>
4557
4558 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4559 only under bidi iteration.
4560
115b96bd
JD
45612011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4562
4563 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4564
c8199d0f
PE
45652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4566
4567 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4568 Without this fix, the command to link temacs failed due to an
4569 undefined symbol __builtin_isnan. This is because
4570 /usr/include/iso/math_c99.h #defines isnan(x) to
4571 __builtin_isnan(x), but the bundled gcc, which identifies itself
4572 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4573 a __builtin_isnan.
4574 * floatfns.c (isnan): #undef, and then #define to a clone of
4575 what's in data.c.
4576 (Fisnan): Always define, since it's always available now.
4577 (syms_of_floatfns): Always define isnan at the Lisp level.
4578
e39b275c 45792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4580
4581 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4582
b2db44d9 45832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4584
f4af5137 4585 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4586 The previous code assumed that file offsets (off_t values) fit in
4587 EMACS_INT variables, which is not true on typical 32-bit hosts.
4588 The code messed up by falsely reporting buffer overflow in cases
4589 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4590 when "big" contains more than 2**29 bytes, even though this
4591 inserts just one byte and does not overflow the buffer.
4592 (Finsert_file_contents): Store file offsets as off_t
4593 values, not as EMACS_INT values. Check for overflow when
4594 converting between EMACS_INT and off_t. When checking for
4595 buffer overflow or for overlap, take the offsets into account.
4596 Don't use EMACS_INT for small values where int suffices.
4597 When checking for overlap, fix a typo: ZV was used where
4598 ZV_BYTE was intended.
4599 (Fwrite_region): Don't assume off_t fits into 'long'.
4600 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4601
ecfc0a49
MA
46022011-09-05 Michael Albinus <michael.albinus@gmx.de>
4603
4604 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4605
6511acf2 46062011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4607
0999621a 4608 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4609
4610 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4611 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4612 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4613 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4614 (modify_event_symbol): Do not assume that the length of
4615 name_alist_or_stem is safe to alloca and fits in int.
4616 (Fexecute_extended_command): Likewise for function name and binding.
4617 (Frecursion_depth): Wrap around reliably on integer overflow.
4618 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4619 since some callers pass EMACS_INT values.
4620 (Fsingle_key_description): Don't crash if symbol name contains more
4621 than MAX_ALLOCA bytes.
4622 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4623 (get_minibuffer): Arg is now EMACS_INT, not int.
4624 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4625 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4626 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4627
2be7d702
PE
4628 * dbusbind.c (signature_cat): New function.
4629 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4630 Do not overrun buffer; instead, report string overflow.
4631
9d1df220
PE
4632 * dispnew.c (add_window_display_history): Don't overrun buffer.
4633 Truncate instead; this is OK since it's just a log.
4634
33ef5c64
PE
4635 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4636 even if the time zone offset is outlandishly large.
4637 Don't mishandle offset == INT_MIN.
4638
66c6fdd5
PE
4639 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4640 when creating daemon; the previous buffer-overflow check was incorrect.
4641
d749b01b
PE
4642 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4643 which has the guts of the old verror function.
4644
b5cd1905
PE
4645 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4646 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4647
6e1a67fb
PE
4648 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4649 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4650 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4651 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4652 length of string rather than counting it via multiple sprintfs;
4653 that's simpler and more reliable.
c21721cc
PE
4654 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4655 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4656 sprintf, in case result does not fit in int.
4657
c57b67fc
PE
4658 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4659 (fontset_from_font): Print it.
4660
8a401434
PE
4661 * frame.c (tty_frame_count): Now printmax_t, not int.
4662 (make_terminal_frame, set_term_frame_name): Print it.
4663 (x_report_frame_params): In X, window IDs are unsigned long,
4664 not signed long, so print them as unsigned.
4665 (validate_x_resource_name): Check for implausibly long names,
4666 and don't assume name length fits in 'int'.
4667 (x_get_resource_string): Don't blindly alloca invocation name;
4668 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4669 not fit in int.
4670
6e1a67fb
PE
4671 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4672 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4673 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4674
0df02bf3
PE
4675 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4676 Use esprintf, not sprintf, in case result does not fit in int.
4677
48e30793
PE
4678 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4679 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4680 it as a large positive number.
4681 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4682 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4683
a66ff6d8
PE
4684 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4685 in case result does not fit in int.
4686
aca216ff
PE
4687 * print.c (float_to_string): Detect width overflow more reliably.
4688 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4689 buffer overrun. Don't assume list length fits in 'int'. Treat
4690 print length of 0 as 0, not as infinity; to be consistent with other
4691 uses of print length in this function. Don't overflow print length
4692 index. Don't assume hash table size fits in 'long', or that
4693 vectorlike size fits in 'unsigned long'.
4694
31c286f7
PE
4695 * process.c (make_process): Use printmax_t, not int, to format
4696 process-name gensyms.
4697
55e5faa1
PE
4698 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4699
80f2e268
PE
4700 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4701 to avoid potential buffer overrun.
4702
670741ab
PE
4703 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4704 if X resource line is longer than 512 bytes.
4705
b7163a50
PE
4706 * xfns.c (x_window): Make sprintf buffer a bit bigger
4707 to avoid potential buffer overrun.
4708
ae58ff1f
PE
4709 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4710
c43c8a6a
PE
4711 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4712
3f8236f4
PE
47132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4714
53e9fe90 4715 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4716 Without these, Emacs silently mishandles large integers sometimes.
4717 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4718 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4719
6511acf2
PE
4720 * xdisp.c (try_window_id): Check Emacs fixnum range before
4721 converting to 'int'.
806add1d 4722
6511acf2 4723 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4724 Check that an Emacs fixnum is in range before assigning it to 'int'.
4725 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4726 values converted from Emacs fixnums.
4727 (Frecenter): Don't wrap around a line count if it is out of 'int'
4728 range; instead, treat it as an extreme value.
4729 (Fset_window_configuration, compare_window_configurations):
4730 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4731
6511acf2
PE
4732 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4733 that can exceed INT_MAX. Check that EMACS_INT value is in range
4734 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4735 (match_limit): Don't assume that a fixnum can fit in 'int'.
4736
6511acf2 4737 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4738 exceed INT_MAX.
4739
6511acf2 4740 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4741 (Fvertical_motion): Don't wrap around LINES values that don't fit
4742 in 'int'. Instead, treat them as extreme values. This is good
4743 enough for windows, which can't have more than INT_MAX lines anyway.
4744
fcb901a7
LMI
47452011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4746
0f2f6b6d
LMI
4747 * Require libxml/parser.h to avoid compilation warning.
4748
fcb901a7
LMI
4749 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4750
4751 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4752 since this reportedly can destroy thread storage.
4753
6e20a0d4
CY
47542011-08-30 Chong Yidong <cyd@stupidchicken.com>
4755
4756 * syntax.c (find_defun_start): Update all cache variables if
4757 exiting early (Bug#9401).
4758
148ae00e
EZ
47592011-08-30 Eli Zaretskii <eliz@gnu.org>
4760
f6cfbd8f
EZ
4761 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4762
148ae00e
EZ
4763 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4764 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4765 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4766
4767 * term.c (tty_append_glyph): New function.
4768 (produce_stretch_glyph): Static function and its prototype deleted.
4769
a66cfb1c
SM
4770 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4771 Add prototypes.
148ae00e 4772
c4a07a4c
PE
47732011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4774
4775 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4776 when checking :margin (Bug#9390).
4777 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4778 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4779 so that the name doesn't mislead. All uses changed.
4780
6bc8cd65
JB
47812011-08-28 Johan Bockgård <bojohan@gnu.org>
4782
4783 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4784 set_tty_hooks.
4785
dca4927e
EZ
47862011-08-27 Eli Zaretskii <eliz@gnu.org>
4787
4788 * xdisp.c (move_it_to): Don't bail out early when reaching
4789 position beyond to_charpos, if we are scanning backwards.
4790 (move_it_vertically_backward): When DY == 0, make sure we get to
4791 the first character in the line after the newline.
4792
f2cad773
PE
47932011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4794
4795 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4796 (ccl_driver): Do not generate an out-of-range pointer.
4797 (Fccl_execute_on_string): Remove unnecessary check for
4798 integer overflow, noted by Stefan Monnier in
4799 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4800 Remove a FIXME that didn't need fixing.
4801 Simplify the newly-introduced buffer reallocation code.
4802
0cae2cdb
JB
48032011-08-27 Juanma Barranquero <lekktu@gmail.com>
4804
4805 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4806
5fc295a4 48072011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4808
70c60eb2 4809 Integer and memory overflow issues (Bug#9196).
726e0ab1 4810
d31850da
PE
4811 * doc.c (get_doc_string): Rework so that
4812 get_doc_string_buffer_size is the actual buffer size, rather than
4813 being 1 less than the actual buffer size; this makes xpalloc more
4814 convenient.
4815
a69fbedb
PE
4816 * image.c (x_allocate_bitmap_record, cache_image):
4817 * xselect.c (Fx_register_dnd_atom):
4818 Simplify previous changes by using xpalloc.
4819
fe5c5d37
PE
4820 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4821 since either will do and ptrdiff_t is convenient with xpalloc.
4822
0065d054
PE
4823 * charset.c (charset_table_size)
4824 (struct charset_sort_data.priority): Now ptrdiff_t.
4825 (charset_compare): Don't overflow if priorities differ greatly.
4826 (Fsort_charsets): Don't assume list length fits in int.
4827 Check for size-calculation overflow when allocating sort data.
4828 (syms_of_charset): Allocate an initial charset table that is
4829 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4830
4831 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4832
4833 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4834 The actual value is always <= INT_MAX, and leaving it unsigned made
4835 overflow checking harder.
4836
4837 * dispextern.h (struct glyph_matrix.rows_allocated)
4838 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4839 with xpalloc. The values are still always <= INT_MAX.
4840
4841 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4842
4843 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4844 (SAFE_NALLOCA): New macro.
4845
4846 * region-cache.c (struct boundary.pos, find_cache_boundary)
4847 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4848 (set_cache_region, invalidate_region_cache)
4849 (revalidate_region_cache, know_region_cache, region_cache_forward)
4850 (region_cache_backward, pp_cache):
4851 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4852 so that ptrdiff_t * can be passed to xpalloc.
4853 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4854 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4855 (pp_cache): Don't assume cache_len fits in int.
4856 * region-cache.h: Adjust extern decls to match.
4857
4858 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4859 EMACS_INT, since either will do, for xpalloc.
4860
4861 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4862 (xnmalloc, xnrealloc, xpalloc): New functions.
4863
726e0ab1
PE
4864 * bidi.c (bidi_shelve_header_size): New constant.
4865 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4866 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4867
51f30bc5 4868 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4869 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4870 (overlay_strings):
4871 Don't update size of array until after memory allocation succeeds,
4872 because xmalloc/xrealloc may not return.
0065d054
PE
4873 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4874 now that we have proper integer overflow checking.
4875 (record_overlay_string, overlay_strings): Catch overflows when
4876 calculating size of overlay_str_buf.
726e0ab1 4877
0065d054
PE
4878 * callproc.c (Fcall_process): Check for size overflow when
4879 calculating size of args2.
4880 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4881 Normally we prefer signed values, but sticking with ptrdiff_t would
4882 require adding more-complicated checks.
726e0ab1
PE
4883
4884 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4885 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4886 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4887 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4888
4889 * character.c (Fstring): Check for size-calculation overflow.
4890
4891 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4892 unnecessary integer overflow. Check for size overflow.
4893 (encode_coding_object): Don't update size until xmalloc succeeds.
4894
4895 * composite.c (get_composition_id): Check for overflow in glyph
4896 length calculations.
4897
4898 Integer and memory overflow fixes for display code.
4899 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4900 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4901 (scrolling_window): Check for overflow in size calculations.
4902 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4903 Don't assume glyph table len fits in int.
4904 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4905 (row_table_size): Now ptrdiff_t, not int.
4906 (scrolling_window): Avoid overflow in size calculations.
4907 Don't update size until allocation succeeds.
4908 * fns.c (concat): Check for overflow in size calculations.
4909 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4910 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4911 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4912
4913 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4914 (get_doc_string): Check for size calculation overflow.
4915 Don't update size until allocation succeeds.
4916 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4917 EMACS_INT, where ptrdiff_t will do.
4918 (Fsubstitute_command_keys): Check for string overflow.
4919
4920 * editfns.c (set_time_zone_rule): Don't assume environment length
4921 fits in int.
4922 (message_length): Now ptrdiff_t, not int.
4923 (Fmessage_box): Don't update size until allocation succeeds.
4924 Don't assume message length fits in int.
4925 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4926
0065d054
PE
4927 * emacs.c (main): Do not reallocate argv, since there is a null at
4928 the end that can be overwritten, and this way there's no need to
4929 worry about size-calculation overflow.
4930 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4931
4932 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4933 alloc succeeds.
4934 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4935
4936 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4937 (x_set_scroll_bar_width, x_figure_window_size):
4938 Check for integer overflow.
4939 (x_set_alpha): Do not assume XINT fits in int.
4940
4941 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4942 This is for the members text_lines, text_cols, total_lines, total_cols,
4943 where the system imposes an 'int' limit.
4944
4945 * fringe.c (Fdefine_fringe_bitmap):
4946 Don't update size until alloc works.
4947
4948 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4949 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4950
4951 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4952 Check for size-calculation overflow.
4953 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4954 do, as we prefer signed integers.
4955 (id_to_widget.max_size, id_to_widget.used)
4956 (xg_store_widget_in_map, xg_remove_widget_from_map)
4957 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4958 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4959 Use and return ptrdiff_t, not int.
4960 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4961 * gtkutil.h: Change prototypes to match the above.
4962
4963 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4964 are duplicate now that they've been promoted to lisp.h.
4965 (x_allocate_bitmap_record, x_alloc_image_color)
4966 (make_image_cache, cache_image, xpm_load):
4967 Don't update size until alloc is done.
4968 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4969 (x_detect_edges):
3256efce 4970 Check for size calculation overflow.
726e0ab1
PE
4971 (ct_colors_allocated_max): New constant.
4972 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4973 overflow.
3256efce 4974
726e0ab1
PE
4975 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4976 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4977 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4978 Use ptrdiff_t, not int, to count maps.
4979 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4980 calculations. Don't update size until allocation succeeds.
4981 Redo calculations to avoid overflow.
726e0ab1
PE
4982 * keyboard.h: Change prototypes to match the above.
4983
4984 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4985 to count maps.
4986 (current_minor_maps): Check for size calculation overflow.
4987 * keymap.h: Change prototypes to match the above.
4988
4989 * lread.c (read1, init_obarray): Don't update size until alloc done.
4990
4991 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4992 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4993
726e0ab1
PE
4994 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4995 Now ptrdiff_t, not int.
4996 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4997 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4998
4999 * process.c (Fnetwork_interface_list): Check for overflow
5000 in size calculation.
5001
5002 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5003
5004 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5005 overflow. Don't bother calling xmalloc when xrealloc will do.
5006
5007 * search.c (Freplace_match): Check for size calculation overflow.
5008 (Fset_match_data): Don't assume list lengths fit in 'int'.
5009
5010 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5011 for command line length. Do not attempt to address one before the
5012 beginning of an array, as that's not portable.
5013
5014 * term.c (max_frame_lines): Remove; unused.
5015 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5016 not int.
5017 (encode_terminal_code, calculate_costs): Check for size
5018 calculation overflow.
5019 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5020 table lengths and related sizes. Don't update size until alloc
5021 done. Redo calculations to avoid overflow.
5022 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5023
5024 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5025 subtracting pointers.
5026 (gobble_line): Check for overflow more carefully. Don't update size
5027 until alloc done.
5028
5029 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5030 Don't update size until alloc done.
5031 Redo size calculations to avoid overflow.
5032 Check for size calculation overflow.
0065d054 5033 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5034
5035 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5036 Use ptrdiff_t, not int, for sizes.
5037 (store_mode_line_noprop_char): Don't update size until alloc done.
5038
0065d054
PE
5039 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5040 Use ptrdiff_t, not int, for sizes.
5041 (Finternal_make_lisp_face, cache_face):
5042 Check for size calculation overflow.
5043 (cache_face): Treat size calculation overflows as if they were
5044 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5045
5046 * xfns.c (x_encode_text, x_set_name_internal)
5047 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5048 sizes, since they can exceed INT_MAX in size. Check for size
5049 calculation overflow.
5050
0065d054
PE
5051 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5052 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5053 Don't update size until alloc done.
5054
0065d054 5055 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5056 as sprintf is limited to int lengths.
1d526e2f 5057
252c5ee1
PE
5058 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5059 (X_LONG_MIN): New macros.
864d7ce7
PE
5060 Use them to make the following changes clearer.
5061 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5062 This change doesn't affect the value now, but it may help remind
5063 future maintainers not to raise the value too much later.
5064 (SELECTION_QUANTUM): Remove, replacing with ...
5065 (selection_quantum): ... new function, which avoids overflow.
5066 All uses changed.
5067 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5068 assumption that selection length fits in 'int'.
5069 (x_reply_selection_request, x_handle_selection_request)
5070 (x_get_window_property, receive_incremental_selection)
5071 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5072 (lisp_data_to_selection_data, clean_local_selection_data):
5073 Use ptrdiff_t, not int, to record length of selection.
5074 (x_reply_selection_request, x_get_window_property)
5075 (receive_incremental_selection, x_property_data_to_lisp):
5076 Redo calculations to avoid overflow.
5077 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5078 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5079 something.
5080 (x_get_window_property, receive_incremental_selection)
5081 (lisp_data_to_selection_data, x_property_data_to_lisp):
5082 Check for size-calculation overflow.
5083 (x_get_window_property, receive_incremental_selection)
5084 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5085 Don't store size until memory allocation succeeds.
5086 (x_get_window_property): Plug memory leak on memory exhaustion.
5087 Don't double-block input; malloc is safe here. Don't assume 2**34
5088 - 4 fits in unsigned long. Add an xassert to check
5089 XGetWindowProperty overflow. Be more careful about overflow
5090 calculations, and distinguish size from memory overflow better.
5091 (receive_incremental_selection): When tracing, don't assume
5092 unsigned int is less than INT_MAX.
5093 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5094 harmful) conversions of unsigned short to int.
5095 (lisp_data_to_selection_data): Don't assume that integers
5096 in the range -65535 through -1 fit in an X unsigned short.
5097 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5098 result parameters unless successful. Rely on cons_to_unsigned
5099 to report problems with elements; the old code wasn't right anyway.
5100 (x_check_property_data): Check for int overflow; we cannot use
5101 a wider type due to X limits.
5102 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5103
726e0ab1 5104 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5105
0065d054
PE
5106 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5107 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5108 (x_color_cells): Don't store size until memory allocation succeeds.
5109 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5110 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5111 (x_term_init): Don't assume length fits in int (sprintf is limited
5112 to int size).
bc18e09d 5113
ebfa62c0
PE
5114 Use ptrdiff_t for composition IDs.
5115 * character.c (lisp_string_width):
5116 * composite.c (composition_table_size, n_compositions)
5117 (get_composition_id, composition_gstring_from_id):
5118 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5119 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5120 * window.c (Frecenter):
5121 Use ptrdiff_t, not int, for composition IDs.
5122 * composite.c (get_composition_id): Check for integer overflow.
5123 * composite.h: Adjust prototypes to match the above changes.
5124
d3411f89
PE
5125 Use ptrdiff_t for hash table indexes.
5126 * category.c (hash_get_category_set):
5127 * ccl.c (ccl_driver):
5128 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5129 * coding.c (coding_system_charset_list, detect_coding_system):
5130 * coding.h (struct coding_system.id):
5131 * composite.c (get_composition_id, gstring_lookup_cache):
5132 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5133 * image.c (xpm_get_color_table_h):
5134 * lisp.h (hash_lookup, hash_put):
5135 * minibuf.c (Ftest_completion):
5136 Use ptrdiff_t for hash table indexes, not int (which is too
5137 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5138 32-bit --with-wide-int hosts).
5139
e097a6fa
PE
5140 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5141 Add a FIXME comment about memory leaks.
5142 (syms_of_charset): Don't assume xmalloc returns.
5143
5637687f
PE
5144 Don't assume that stated character widths fit in int.
5145 * character.c (Fchar_width, c_string_width, lisp_string_width):
5146 * character.h (CHAR_WIDTH):
5147 * indent.c (MULTIBYTE_BYTES_WIDTH):
5148 Use sanitize_char_width to avoid undefined and/or bad behavior
5149 with outlandish widths.
a66cfb1c 5150 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5151 now that we have two such functions. All uses changed.
5152 (sanitize_char_width): New inline function.
5153
a2271ba2
PE
5154 Don't assume that tab-width fits in int.
5155 * character.h (sanitize_width): New inline function.
5156 (SANE_TAB_WIDTH): New macro.
5157 (ASCII_CHAR_WIDTH): Use it.
5158 * indent.c (sane_tab_width): Remove. All uses replaced by
5159 SANE_TAB_WIDTH (current_buffer).
5160 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5161
18c52557
PE
5162 * fileio.c: Integer overflow issues with file modes.
5163 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5164
caeeedc1
PE
5165 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5166 Remove unreachable code.
5167 (read_hex, load_charset_map_from_file): Check for integer overflow.
5168
6df6ae42 5169 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5170 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5171 (x_send_scroll_bar_event): Likewise. Check that the size does not
5172 exceed limits imposed by XClientMessageEvent, as well as the usual
5173 ptrdiff_t and size_t limits.
5174
b13995db
PE
5175 * keyboard.c: Overflow, signedness and related fixes.
5176 (make_lispy_movement): Use same integer type in forward decl
5177 that is used in the definition.
5178 (read_key_sequence, keyremap_step):
5179 Change bufsize argument back to int, undoing my 2011-03-30 change.
5180 We prefer signed types, and int is wide enough here.
5181 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5182 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5183 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5184 length, not size_t. Use ptrdiff_t for index, not int.
5185 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5186 possibility of integer overflow.
5187
13464394
PE
5188 Overflow, signedness and related fixes for images.
5189
5190 * dispextern.h (struct it.stack[0].u.image.image_id)
5191 (struct_it.image_id, struct image.id, struct image_cache.size)
5192 (struct image_cache.used, struct image_cache.ref_count):
5193 * gtkutil.c (update_frame_tool_bar):
5194 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5195 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5196 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5197 * nsmenu.m (update_frame_tool_bar):
5198 * xdisp.c (calc_pixel_width_or_height):
5199 * xfns.c (image_cache_refcount):
5200 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5201 on typical 64-bit hosts.
5202
5203 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5204 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5205 Omit unnecessary casts to int.
5206 (parse_image_spec): Check that integers fall into 'int' range
5207 when the callers expect that.
5208 (image_ascent): Redo ascent calculation to avoid int overflow.
5209 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5210 (lookup_image): Remove unnecessary tests.
5211 (xbm_image_p): Locals are now of int, not EMACS_INT,
5212 since parse_image_check makes sure they fit into int.
5213 (png_load, gif_load, svg_load_image):
5214 Prefer int to unsigned where either will do.
5215 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5216 old tiff_error_handler and tiff_warning_handler.
5217 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5218 stack buffer overflows. It uses only the features of vsnprintf
5219 that are common to both POSIX and native Microsoft.
5220 (tiff_error_handler, tiff_warning_handler): Use it.
5221 (tiff_load, gif_load, imagemagick_load_image):
5222 Don't assume :index value fits in 'int'.
5223 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5224 (imagemagick_load_image): Check that crop parameters fit into
5225 the integer types that MagickCropImage accepts. Don't assume
5226 Vimagemagick_render_type has a nonnegative value. Don't assume
5227 size_t fits in 'long'.
5228 (gs_load): Use printmax_t to print the widest integers possible.
5229 Check for integer overflow when computing image height and width.
5230
c11821d4
EZ
52312011-08-26 Eli Zaretskii <eliz@gnu.org>
5232
5233 * xdisp.c (redisplay_window): Don't force window start if point
5234 will be invisible in the resulting window. (Bug#9324)
5235
0c95fcf7
EZ
52362011-08-25 Eli Zaretskii <eliz@gnu.org>
5237
5238 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5239 the display spec is of the form `(space ...)'.
5240 (handle_display_spec): Return the value returned by
5241 handle_single_display_spec, not just 1 or zero.
5242 (handle_single_display_spec): If the display spec is of the form
5243 `(space ...)', and specifies display in the text area, return 2
5244 rather than 1.
fee65a97 5245 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5246 accurately, and prefer exact match for point under bidi.
5247 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5248
5249 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5250 into disp_prop; all users changed.
5251
5252 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5253 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5254 for the text covered by the display property.
5255
e4ed06f1
CY
52562011-08-25 Chong Yidong <cyd@stupidchicken.com>
5257
5258 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5259 Change return value to nil.
5260 (Frecord_buffer): Delete unused function.
5261
f67cdd7f
EZ
52622011-08-24 Eli Zaretskii <eliz@gnu.org>
5263
5980d4c6
EZ
5264 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5265 buffers, return left-to-right.
8610fe8b
EZ
5266 (set_cursor_from_row): Consider candidate row a win if its glyph
5267 represents a newline and point is on that newline. Fixes cursor
5268 positioning on the newline at EOL of R2L text within L2R
5269 paragraph, and vice versa.
5270 (try_cursor_movement): Check continued rows, in addition to
5271 continuation rows. Fixes unwarranted scroll when point enters a
5272 continued line of R2L text within an L2R paragraph, or vice versa.
5273 (cursor_row_p): Consider the case of point being equal to
5274 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5275 from the end of a short line to the beginning of a continued line
5276 of R2L text within L2R paragraph.
5277 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5278 composed characters.
5980d4c6 5279
f67cdd7f
EZ
5280 * bidi.c (bidi_check_type): Use xassert.
5281 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5282 members.
5283
bca633fb
EZ
52842011-08-23 Eli Zaretskii <eliz@gnu.org>
5285
5286 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5287 a character.
5288
4a5885a7
CY
52892011-08-23 Chong Yidong <cyd@stupidchicken.com>
5290
5291 * nsfont.m (ns_otf_to_script): Fix typo.
5292
0902a04e
KH
52932011-08-22 Kenichi Handa <handa@m17n.org>
5294
5295 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5296 extra slot even if the purpose is char-code-property-table.
5297
1a2e6670
EZ
52982011-08-23 Eli Zaretskii <eliz@gnu.org>
5299
8ddde651
EZ
5300 * xdisp.c (redisplay_window): When computing centering_position,
5301 account for the height of the header line. (Bug#8874)
5302
425cc014
EZ
5303 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5304 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5305 candidate is selected by the mouse, and that candidate has a
5306 composed character under the mouse.
5307
1a2e6670
EZ
5308 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5309 coordinates reported by pos-visible-in-window-p for a composed
5310 character in column zero.
5311
8b76d6f8
SM
53122011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5313
5314 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5315
dac347dd
EZ
53162011-08-22 Eli Zaretskii <eliz@gnu.org>
5317
5318 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5319 consider it a hit if to_charpos is anywhere in the range of the
5320 composed buffer positions.
5321
e013fb34
CY
53222011-08-22 Chong Yidong <cyd@stupidchicken.com>
5323
5324 * image.c (gif_load): Don't assume that each subimage has the same
5325 dimensions as the base image. Handle disposal method that is
5326 "undefined" by the gif spec (Bug#9335).
5327
bd1ba3e8
CY
53282011-08-20 Chong Yidong <cyd@stupidchicken.com>
5329
5330 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5331 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5332
54a1215b
EZ
53332011-08-19 Eli Zaretskii <eliz@gnu.org>
5334
823564e5
EZ
5335 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5336 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5337 from an Org mode buffer to a Speedbar frame.
5338
54a1215b
EZ
5339 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5340 a composition, take its buffer position from IT->cmp_it.charpos.
5341 Fixes cursor positioning at the beginning of a line that begins
5342 with a composed character.
5343
9778ebcc
EZ
53442011-08-18 Eli Zaretskii <eliz@gnu.org>
5345
0be6ee06
EZ
5346 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5347 character bidirectional type, use STRONG_L instead. Fixes crashes
5348 in a buffer produced by `describe-categories'.
5349
9778ebcc
EZ
5350 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5351 members before the level stack, so they would be saved and
5352 restored when copying iterator state. Fixes incorrect reordering
5353 around TABs covered by display properties.
5354
156bffbe
AS
53552011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5356
6b02f655 5357 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5358
72ad093b
CY
53592011-08-17 Chong Yidong <cyd@stupidchicken.com>
5360
5361 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5362 (internal_condition_case_2, internal_condition_case_n):
5363 Remove unnecessary aborts (Bug#9081).
72ad093b 5364
35774242
EZ
53652011-08-17 Eli Zaretskii <eliz@gnu.org>
5366
5367 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5368 has no `load' handler, try opening the file locally. (Bug#9311)
5369
db76dd85
KB
53702011-08-16 Ken Brown <kbrown@cornell.edu>
5371
5372 * gmalloc.c: Expand comment.
5373
b215eee5
EZ
53742011-08-16 Eli Zaretskii <eliz@gnu.org>
5375
5376 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5377 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5378
a4579d33
KB
53792011-08-16 Ken Brown <kbrown@cornell.edu>
5380
5381 Fix memory allocation problems in Cygwin build (Bug#9273).
5382
5383 * unexcw.c ( __malloc_initialized): Declare external variable.
5384 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5385
8b76d6f8
SM
5386 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5387 New variables.
a4579d33
KB
5388 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5389 dumped emacs.
5390 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5391 in the static heap.
5392 [CYGWIN] (special_realloc): New function.
5393 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5394 requests to realloc storage in the static heap.
5395
3ebec551
PE
53962011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5397
5398 * bidi.c (bidi_initialize): Remove unused local.
5399
9fd8be00
EZ
54002011-08-15 Eli Zaretskii <eliz@gnu.org>
5401
6b02f655
SM
5402 * bidimirror.h:
5403 * biditype.h: Remove file.
5404 * makefile.w32-in ($(BLD)/bidi.$(O)):
5405 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5406
5407 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5408
5409 * chartab.c: Improve commentary for the uniprop_table API.
5410
32413314
EZ
5411 * bidi.c (bidi_paragraph_init): Support zero value of
5412 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5413 (bidi_initialize): Use uniprop_table instead of including
5414 biditype.h and bidimirror.h.
32413314 5415
9fd8be00
EZ
5416 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5417 coordinates of the iterator when restoring from ppos_it.
5418 (Bug#9296)
5419
5cf2b69b
KH
54202011-08-14 Kenichi Handa <handa@m17n.org>
5421
5422 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5423 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5424
daf17d00
EZ
54252011-08-14 Eli Zaretskii <eliz@gnu.org>
5426
5427 * xdisp.c (move_it_in_display_line_to): Don't invoke
5428 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5429 ppos_it. Fixes vertical cursor motion when line beginning is
5430 covered by an image. (Bug#9296)
5431
08e3161a
JD
54322011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5433
5434 * nsterm.h (ns_run_ascript): Declare.
5435 (NSAPP_DATA2_RUNASSCRIPT): Define.
5436
5437 * nsfns.m (as_script, as_result, as_status): New static variables.
5438 (ns_run_ascript): New function.
5e617bc2 5439 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5440 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5441 the event loop. Get status from as_status (Bug#7276).
5442
5443 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5444 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5445 the event loop (Bug#7276).
5446
a3720aa2
AS
54472011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5448
5449 * gnutls.c (QCgnutls_bootprop_priority)
5450 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5451 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5452 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5453 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5454 (QCgnutls_bootprop_verify_hostname_error)
5455 (QCgnutls_bootprop_callbacks_verify): Rename from
5456 Qgnutls_bootprop_..., all uses changed.
5457
5458 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5459 uses changed.
5460
0a0d27fb
PE
54612011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5462
19d5c50c
PE
5463 * xfaces.c (Qframe_set_background_mode): Now static.
5464 * dispextern.h (Qframe_set_background_mode): Remove decl.
5465
0a0d27fb
PE
5466 * process.c (Fnetwork_interface_info): Declare local only if needed.
5467
377538cb
JD
54682011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5469
5470 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5471 (Fnetwork_interface_list): Allocate in increments of bytes instead
5472 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5473 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5474 sockaddr.
5475 (struct ifflag_def): notrailers is smart on OSX.
5476 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5477 Get hardware address with getifaddrs if available.
5478
08fff70c
EZ
54792011-08-12 Eli Zaretskii <eliz@gnu.org>
5480
5481 * xdisp.c (iterate_out_of_display_property): xassert that
5482 IT->position is set to within IT->object's boundaries. Break from
5483 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5484 when IT->position is set up wrongly due to some bug.
5485 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5486 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5487 entry. Force push_it to save on the stack the current
5488 buffer/string position, to be restored by pop_it. Fix flags in
5489 the iterator structure wrt the object coming from a display
5490 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5491 properties. (Bug#9284)
5492
7be1c708 54932011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5494
7be1c708
CY
5495 * fontset.c (fontset_get_font_group): Add proper type checks.
5496 (Bug#9172)
aac0c6e3 5497
7be1c708 54982011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5499
7be1c708
CY
5500 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5501 and LC_VERSION_MIN_MACOSX.
5502 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5503 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5504
97bb72a6
EZ
55052011-08-08 Eli Zaretskii <eliz@gnu.org>
5506
5507 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5508 no-display-properties-and-no-overlays under bidi display.
5509 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5510 properties and overlays.
97bb72a6 5511
d5617611
CY
55122011-08-08 Chong Yidong <cyd@stupidchicken.com>
5513
37e11a63
CY
5514 * editfns.c (Fset_time_zone_rule): Document relationship with the
5515 setenv function.
5516
d5617611
CY
5517 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5518 the font entity extracted from the cache (Bug#8109).
5519
58872834
CY
55202011-08-07 Chong Yidong <cyd@stupidchicken.com>
5521
5522 * composite.c (autocmp_chars): Don't reset point. That is done by
5523 restore_point_unwind (Bug#5984).
5524
75bfc667
JL
55252011-08-07 Juri Linkov <juri@jurta.org>
5526
5527 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5528 to show the arg `TIME' instead of `TIMEVAL'.
5529
d1410150
EZ
55302011-08-06 Eli Zaretskii <eliz@gnu.org>
5531
5532 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5533 display property strides EOL and includes a newline, as in
5534 longlines-mode. (Bug#9254)
75b771e4
EZ
5535 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5536 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5537
5538 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5539 is non-zero, even if the data buffer is NULL. Fixes a crash in
5540 vertical-motion with longlines-mode. (Bug#9254)
5541
35928349
EZ
55422011-08-05 Eli Zaretskii <eliz@gnu.org>
5543
ec7cc85b
EZ
5544 * bidi.c <bidi_cache_total_alloc>: Now static.
5545 (bidi_initialize): Initialize bidi_cache_total_alloc.
5546
8b76d6f8 5547 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5548 cache. (Bug#9221)
5549
5550 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5551 amount allocated this far in `bidi_cache_total_alloc'.
5552 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5553 non-zero, only free the data buffer without restoring the cache
5554 contents. All callers changed.
5555
5556 * dispextern.h (bidi_unshelve_cache): Update prototype.
5557
5558 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5559 (move_it_in_display_line, move_it_to)
5560 (move_it_vertically_backward, move_it_by_lines): Replace the call
5561 to xfree to an equivalent call to bidi_unshelve_cache.
5562 (move_it_in_display_line_to): Fix logic of returning
412b6358 5563 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5564
e2e2423b
EZ
55652011-08-05 Eli Zaretskii <eliz@gnu.org>
5566
5567 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5568 came from a string character with a `cursor' property. (Bug#9229)
5569
ae9e757a
JD
55702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5571
5572 * Makefile.in (LIB_PTHREAD): New variable.
5573 (LIBES): Add LIB_PTHREAD (Bug#9216).
5574
5575 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5576 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5577
213bd7f2
AS
55782011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5579
6b02f655 5580 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5581
99aaf75f
JD
55822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5583
5584 * xterm.c (x_find_topmost_parent): New function.
5585 (x_set_frame_alpha): Find topmost parent window with
5586 x_find_topmost_parent and set the property there also (bug#9181).
5587 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5588
c74e9d86
PE
55892011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5590
5591 * callproc.c (Fcall_process): Avoid vfork clobbering
5592 the local vars buffer, coding_systems, current_dir.
5593
640c8776
SM
55942011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5595
5596 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5597
f26d0e4c
PE
55982011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5599
8a10d76c
PE
5600 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5601 so that it is not optimized away.
5602
f26d0e4c
PE
5603 * xdisp.c (compute_display_string_pos): Remove unused local.
5604
55439c61
EZ
56052011-08-02 Eli Zaretskii <eliz@gnu.org>
5606
5607 Fix slow cursor motion and scrolling in large buffers with
5608 selective display, like Org Mode buffers. (Bug#9218)
5609
5610 * dispextern.h (struct bidi_it): New member disp_prop_p.
5611
5612 * xdisp.c: Remove one-slot cache of display string positions.
5613 (compute_display_string_pos): Accept an additional argument
5e617bc2 5614 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5615 for a display string or property. If found, set DISP_PROP_P
5616 non-zero.
5617
5618 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5619 DISP_PROP_P, and pass it to compute_display_string_pos.
5620 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5621 non-zero. All callers of bidi_fetch_char changed.
5622
fb33fa43
SM
56232011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5624
5625 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5626
b099e063
DM
56272010-12-03 Don March <don@ohspite.net>
5628
5629 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5630 last character M-[char] is translated to ESC [char] (bug#7541).
5631
5cc7f7af
KH
56322011-08-02 Kenichi Handa <handa@m17n.org>
5633
d0fffa3f 5634 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5635
5636 * chartab.c (uniprop_table): Make it non-static.
5637
525d5e6e
EZ
56382011-08-01 Eli Zaretskii <eliz@gnu.org>
5639
5640 * xdisp.c (forward_to_next_line_start): Accept additional argument
5641 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5642 on the newline.
5643 (reseat_at_next_visible_line_start): Use the bidi iterator state
5644 returned by forward_to_next_line_start to restore the state of
5645 it->bidi_it after backing up to previous newline. (Bug#9212)
5646
31011111
AS
56472011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5648
5649 * regex.c (re_comp): Protoize.
5650 (re_exec): Fix return type.
5651 (regexec): Fix type of `ret'. (Bug#9203)
5652
476371c4
PE
56532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5654
e5d76069
PE
5655 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5656 This is needed if max-image-size is a floating-point number.
5657
9a79b20c
AS
56582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5659
5660 * print.c (print_object): Print empty symbol as ##.
5661
5662 * lread.c (read1): Read ## as empty symbol.
5663
d8c2fa78
AA
56642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5665
5666 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5667 setting frame foreground color (Bug#9175).
5668 (x_set_background_color): Likewise.
5669
ffe57a7a
AA
5670 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5671 contents (Bug#9176).
5672 (EmacsTooltip -init): Remove bezels and add shadows to
5673 tooltip windows.
5674
bf3492a5
AA
5675 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5676 or scroll bar (Bug#8470).
5677
d55e9c53
AA
5678 * nsfont.m (nsfont_open): Remove assignment to voffset and
5679 unnecessary vars hshink, expand, hd, full_height, min_height.
5680 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5681
5682 * nsterm.h (nsfont_info): Remove voffset field.
5683
d8c2fa78 56842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5685
5686 Implement strike-through and overline on NextStep (Bug#8863).
5687
5688 * nsfont.m (nsfont_open): Use underline position provided by font,
5689 instead of hard-coded value of 2.
5690 (nsfont_draw): Call ns_draw_text_decoration instead.
5691
5692 * nsterm.h: Add declaration for ns_draw_text_decoration.
5693
5694 * nsterm.m (ns_draw_text_decoration): New function for drawing
5695 underline, overline, and strike-through.
5696 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5697 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5698 accommodate underlining, etc.
4843aac3 5699
4cc60b9b
EZ
57002011-07-28 Eli Zaretskii <eliz@gnu.org>
5701
bc7ece87
EZ
5702 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5703 default.
4cc60b9b 5704
476371c4
PE
57052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5706
66606eea
PE
5707 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5708 Without this fix, if a signal arrives just after memory fills up,
5709 'malloc' might be invoked reentrantly.
5710
476371c4
PE
5711 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5712 In other words, assume that every image size is allowed, on non-X
5713 hosts. This assumption is probably wrong, but it lets Emacs compile.
5714
f3fcc40d
AS
57152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5716
5717 * regex.c (re_iswctype): Convert return values to boolean.
5718
350c992f
EZ
57192011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5720
5721 * xdisp.c (compute_display_string_pos): Don't use cached display
5722 string position if the buffer had its restriction changed.
5723 (Bug#9184)
5724
5266b4bb
PE
57252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5726
5727 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5728
2573a837 57292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5730
41f55ccd 5731 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5732
39e378da
PE
5733 * bidi.c: Integer size and overflow fixes.
5734 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5735 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5736 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5737 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5738 (bidi_find_other_level_edge):
5739 Use ptrdiff_t instead of EMACS_INT where either will do.
5740 This works better on 32-bit hosts configured --with-wide-int.
5741 (bidi_cache_ensure_space): Check for size-calculation overflow.
5742 Use % rather than repeated addition, for better worst-case speed.
5743 Don't set bidi_cache_size until after xrealloc returns, because it
5744 might not return.
5745 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5746 (bidi_cache_ensure_space): Also check that the bidi cache size
5747 does not exceed that of the largest Lisp string or buffer. See Eli
5748 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5749
5e927815
PE
5750 * alloc.c (__malloc_size_t): Remove.
5751 All uses replaced by size_t. See Andreas Schwab's note
5752 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5753
ca4aa935
PE
5754 * image.c: Improve checking for integer overflow.
5755 (check_image_size): Assume that f is nonnull, since
5756 it is always nonnull in practice. This is one less thing to
5757 worry about when checking for integer overflow later.
5758 (x_check_image_size): New function, which checks for integer
5759 overflow issues inside X.
5760 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5761 This removes the need for a memory_full check.
5762 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5763 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5764 (xbm_read_bitmap_data): Change locals back to 'int', since
5765 their values must fit in 'int'.
5766 (xpm_load_image, png_load, tiff_load):
5767 Invoke x_create_x_image_and_pixmap earlier,
5768 to avoid much needless work if the image is too large.
5769 (tiff_load): Treat overly large images as if
5770 x_create_x_image_and_pixmap failed, not as malloc failures.
5771 (gs_load): Use x_check_image_size.
5772
5f8f9cc2
PE
5773 * gtkutil.c: Omit integer casts.
5774 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5775 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5776
5adf60bc
PE
5777 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5778
c8907a93
PE
5779 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5780 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5781 would wrongly return t on a 64-bit host.
5782
e3c25c68
PE
5783 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5784 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5785 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5786 and therefore cause GCC to emit a bogus diagnostic in some cases.
5787
3f791afe
PE
5788 * image.c: Integer signedness and overflow and related fixes.
5789 This is not an exhaustive set of fixes, but it's time to
5790 record what I've got.
5791 (lookup_pixel_color, check_image_size): Remove redundant decls.
5792 (check_image_size): Don't assume that arbitrary EMACS_INT values
5793 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5794 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5795 (tiff_load, imagemagick_load_image):
5796 Check for overflow in size calculations.
5797 (x_create_x_image_and_pixmap): Remove unnecessary test for
5798 xmalloc returning NULL; that can't happen.
5799 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5800 (xpm_color_bucket): Use better integer hashing function.
5801 (xpm_cache_color): Don't possibly over-allocate memory.
5802 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5803 (gif_memory_source):
5804 Use ptrdiff_t, not int or size_t, to record sizes.
5805 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5806 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5807 either works, as we prefer signed integers.
5808 (tiff_read_from_memory, tiff_write_from_memory):
5809 Return tsize_t, not size_t, since that's what the TIFF API wants.
5810 (tiff_read_from_memory): Don't fail simply because the read would
5811 go past EOF; instead, return a short read.
5812 (tiff_load): Omit no-longer-needed casts.
5813 (Fimagemagick_types): Don't assume size fits into 'int'.
5814
3cc5a532
PE
5815 Improve hashing quality when configured --with-wide-int.
5816 * fns.c (hash_string): New function, taken from sxhash_string.
5817 Do not discard information about ASCII character case; this
5818 discarding is no longer needed.
5819 (sxhash-string): Use it. Change sig to match it. Caller changed.
5820 * lisp.h: Declare it.
5821 * lread.c (hash_string): Remove, since we now use fns.c's version.
5822 The fns.c version returns a wider integer if --with-wide-int is
5823 specified, so this should help the quality of the hashing a bit.
5824
b312a492
PE
5825 * emacs.c: Integer overflow minor fix.
5826 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5827 Define only if GNU_LINUX.
5828 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5829
dfd153ae
PE
5830 * dispnew.c: Integer signedness and overflow fixes.
5831 Remove unnecessary forward decls, that were a maintenance hassle.
5832 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5833 All uses changed.
5834 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5835 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5836 (prepare_desired_row, line_draw_cost):
5837 Use int, not unsigned, where either works.
5838 (save_current_matrix, restore_current_matrix):
5839 Use ptrdiff_t, not size_t, where either works.
5840 (init_display): Check for overflow more accurately, and without
5841 relying on undefined behavior.
5842
a81d11a3
PE
5843 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5844 Remove, replacing with the new symbols in lisp.h. All uses changed.
5845 * fileio.c (make_temp_name):
5846 * filelock.c (lock_file_1, lock_file):
5847 * xdisp.c (message_dolog):
5848 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5849 Use pMd etc. instead.
5850 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5851 replacing the pWIDE etc. symbols removed from editfns.c.
5852
3300e6fd
PE
5853 * keyboard.h (num_input_events): Now uintmax_t.
5854 This is (very slightly) less likely to mess up due to wraparound.
5855 All uses changed.
5856
fd05c7e9
PE
5857 * buffer.c: Integer signedness fixes.
5858 (alloc_buffer_text, enlarge_buffer_text):
5859 Use ptrdiff_t rather than size_t when either will do, as we prefer
5860 signed integers.
5861
903fe15d
PE
5862 * alloc.c: Integer signedness and overflow fixes.
5863 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5864 (__malloc_size_t): Default to size_t, not to int.
5865 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5866 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5867 Prefer ptrdiff_t to size_t when either would do, as we prefer
5868 signed integers.
5869 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5870 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5871 Now const. Initialize with values that are in range even if char
5872 is signed.
5873 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5874 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5875 These functions do the right thing with sizes > 2**32.
5876 (check_depth): Now ptrdiff_t, not int.
5877 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5878 Adjust to new way of storing sizes. Check for size overflow bugs
5879 in rest of code.
5880 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5881 slightly wrong anyway, as it missed one instance of
5882 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5883 (refill_memory_reserve): Omit needless cast to size_t.
5884 (mark_object_loop_halt): Mark as externally visible.
5885
ac82cc6a
PE
5886 * xselect.c: Integer signedness and overflow fixes.
5887 (Fx_register_dnd_atom, x_handle_dnd_message):
5888 Use ptrdiff_t, not size_t, since we prefer signed.
5889 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5890 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5891 x_dnd_atoms_size and x_dnd_atoms_length.
5892
c2d1e36d
PE
5893 * doprnt.c: Prefer signed to unsigned when either works.
5894 * eval.c (verror):
5895 * doprnt.c (doprnt):
5896 * lisp.h (doprnt):
5897 * xdisp.c (vmessage):
5898 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5899 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5900 prefer signed arithmetic to avoid comparison confusion.
5901 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5902 but is a bit tricky.
5903
0e926e56
PE
5904 Assume freestanding C89 headers, string.h, stdlib.h.
5905 * data.c, doprnt.c, floatfns.c, print.c:
5906 Include float.h unconditionally.
5907 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5908 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5909 * regex.c: Likewise for stddef.h, string.h.
5910 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5911 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5912 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5913 (STDC_HEADERS): Remove obsolete defines.
5914 * sysdep.c: Include limits.h unconditionally.
5915
9cfdb3ec
PE
5916 Assume support for memcmp, memcpy, memmove, memset.
5917 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5918 * regex.c (memcmp, memcpy):
5919 Remove; we assume C89 now.
5920
5921 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5922 (__malloc_safe_bcopy): Remove; no longer needed.
5923
cf950e6b 5924 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5925 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5926 well either way, and we prefer signed to unsigned.
5927
dbf38e02
LMI
59282011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5929
5930 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5931 closes the connection while we're reading (bug#9182).
5932
d6f0886c 59332011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5934
d6f0886c
JD
5935 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5936 are specified (Bug#9168).
24e0f6b1 5937
2eb1f9e6
PE
59382011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5939
5940 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5941 Found by GCC static checking and --with-wide-int on a 32-bit host.
5942
22381272 59432011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5944
5945 * xdisp.c (compute_display_string_pos): Fix logic of caching
5946 previous display string position. Initialize cached_prev_pos to
5947 -1. Fixes slow-down at the beginning of a buffer.
5948
f25e39b4
EZ
59492011-07-24 Eli Zaretskii <eliz@gnu.org>
5950
5951 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5952 for attrs[LFACE_FONTSET_INDEX].
5953
04c4b52e
PE
59542011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5955
5956 * xml.c (parse_region): Remove unused local
5957 that was recently introduced.
5958
c1734fbd
EZ
59592011-07-23 Eli Zaretskii <eliz@gnu.org>
5960
be18c5a5
EZ
5961 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5962 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5963
c1734fbd
EZ
5964 * xdisp.c (move_it_in_display_line_to): Record the best matching
5965 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5966 exit if none of the characters scanned was an exact match.
5967 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5968 when exact match is impossible due to invisible text, and the
5969 lines are truncated.
5970
a258d627
JD
59712011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5972
5973 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5974 for OSX >= 10.7.
5975
b6d5a689
EZ
59762011-07-22 Eli Zaretskii <eliz@gnu.org>
5977
0f74f785
EZ
5978 Fix a significant slow-down of cursor motion with C-n, C-p,
5979 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5980 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5981 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5982 (next_element_from_buffer): Call compute_stop_pos_backwards to
5983 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5984 base_level_stop.
5985 (reseat): Don't look for prev_stop, as that could mean a very long
5986 run.
5987 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5988 <cached_disp_overlay_modiff>: Cache for last found display string
5989 position.
551918c1 5990 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5991 about the same buffer in the same area of character positions, and
5992 the buffer wasn't changed since the time the display string
5993 position was cached.
551918c1 5994
b2d0c91a
EZ
59952011-07-22 Eli Zaretskii <eliz@gnu.org>
5996
5997 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5998 is an integer, which is important for empty lines. (Bug#9149)
5999
043604ee
CY
60002011-07-22 Chong Yidong <cyd@stupidchicken.com>
6001
6002 * frame.c (Fmodify_frame_parameters): In tty case, update the
6003 default face if necessary (Bug#4238).
6004
da4adb04
CY
60052011-07-21 Chong Yidong <cyd@stupidchicken.com>
6006
6007 * editfns.c (Fstring_to_char): No need to explain what a character
6008 is in the docstring (Bug#6576).
6009
9abd0532
LMI
60102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6011
6012 * xml.c (parse_region): Make sure we always return a tree.
6013
36881d16
HK
60142011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6015
6016 * xml.c (parse_region): If a document contains only comments,
6017 return that, too.
6018
1e98674d
LMI
60192011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6020
6021 * xml.c (make_dom): Return comments, too.
6022
590bd467
PE
60232011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6024
6025 Port to OpenBSD.
6026 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6027 and the surrounding thread.
6028 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6029 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6030 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6031 timer goes off.
6032 * s/openbsd.h (BROKEN_SIGIO): Define.
6033 * unexelf.c (unexec) [__OpenBSD__]:
6034 Don't update the .mdebug section of the Alpha COFF symbol table.
6035
f41628b2
LMI
60362011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6037
6038 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6039 (bug#8460).
6040
b59b67c5
PE
60412011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6042
15e3a074
PE
6043 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6044 This fixes some race conditions on the permissions of any newly
6045 created file.
6046
41bed37d
PE
6047 * alloc.c (valid_pointer_p): Use pipe, not open.
6048 This fixes some permissions issues when debugging.
6049
b59b67c5
PE
6050 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6051 If fchown fails to set both uid and gid, try to set just gid,
6052 as that is sometimes allowed. Adjust the file's mode to eliminate
6053 setuid or setgid bits that are inappropriate if fchown fails.
6054
925a6be7
SM
60552011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6056
6057 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6058 to compare Lisp_Objects.
6059 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6060 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6061 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6062
52968808
AS
60632011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6064
0a6a104b
AS
6065 * lread.c (read_integer): Unread even EOF character.
6066 (read1): Likewise. Properly record start position of symbol.
6067
52968808
AS
6068 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6069 symbol character follows.
6070
9e381cdd
PE
60712011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6072
6073 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6074 This works around a problem with the previous change to Fcopy_file.
6075 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6076 and without this change, GCC might complain about discarding
6077 fchown's return value.
6078
b5641435
JB
60792011-07-16 Juanma Barranquero <lekktu@gmail.com>
6080
6081 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6082
a8031457
PE
60832011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6084
6085 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6086
dd889327
LMI
60872011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6088
750c33f7
LMI
6089 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6090 it's used from the C level.
6091
dd889327
LMI
6092 * process.c: Use the same condition for POLL_FOR_INPUT in both
6093 keyboard.c and process.c (bug#1858).
6094
87e86684
LM
60952011-07-09 Lawrence Mitchell <wence@gmx.li>
6096
6097 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6098 (Fgnutls_boot): Use it.
6099
64348f40
AS
61002011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6101
6102 * doc.c (Fsubstitute_command_keys): Revert last change.
6103
1d698799
LMI
61042011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6105
f863868c
LMI
6106 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6107 quotes the next character, and doesn't affect other longer
6108 sequences (bug#8935).
6109
1d698799
LMI
6110 * lread.c (syms_of_lread): Clarify that is isn't only
6111 `eval-buffer' and `eval-defun' that's affected by
6112 `lexical-binding' (bug#8460).
6113
aa4b6df6
EZ
61142011-07-15 Eli Zaretskii <eliz@gnu.org>
6115
6116 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6117 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6118
5d856da6
PE
61192011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6120
ad6042bb
PE
6121 Fix minor problems found by static checking.
6122 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6123 (elsz): Now a signed constant, not a size_t var. We prefer signed
6124 types to unsigned, to avoid integer comparison confusion. Without
6125 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6126 "cannot optimize loop, the loop counter may overflow", a symptom
6127 of the confusion.
f00bbb22 6128 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6129 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6130
6468f31c
LMI
61312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6132
49080b10
LMI
6133 * search.c (Fre_search_backward): Mention `case-fold-search' in
6134 all the re_search_* functions (bug#8138).
6135
6468f31c
LMI
6136 * keyboard.c (Fopen_dribble_file): Document when the file is
6137 closed (bug#8056).
6138
c965adc5
EZ
61392011-07-14 Eli Zaretskii <eliz@gnu.org>
6140
df9733bf
EZ
6141 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6142 bidi_cache_idx.
6143
0bb23927
EZ
6144 Support bidi reordering of display and overlay strings.
6145 * xdisp.c (compute_display_string_pos)
6146 (compute_display_string_end): Accept additional argument STRING.
6147 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6148 (reseat_to_string): Initialize bidi_it->string.s and
6149 bidi_it->string.schars.
6150 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6151 NULL (avoids a crash in bidi_paragraph_init).
6152 Initialize itb.string.lstring.
0bb23927
EZ
6153 (init_iterator): Call bidi_init_it only of a valid
6154 buffer position was specified. Initialize paragraph_embedding to
6155 L2R.
6156 (reseat_to_string): Initialize the bidi iterator.
6157 (display_string): If we need to ignore text properties of
6158 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6159 original value of -1 will not work with bidi.)
6160 (compute_display_string_pos): First arg is now struct
6161 `text_pos *'; all callers changed. Support display properties on
6162 Lisp strings.
6163 (compute_display_string_end): Support display properties on Lisp
6164 strings.
6165 (init_iterator, reseat_1, reseat_to_string): Initialize the
6166 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6167 when iterating on a string not from display properties).
640c8776
SM
6168 (compute_display_string_pos, compute_display_string_end):
6169 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6170 arrow keys.
6171 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6172 base_level_stop; instead, set base_level_stop to BEGV.
6173 Fixes crashes in vertical-motion.
0bb23927
EZ
6174 (next_element_from_buffer): Improve commentary for when
6175 the iterator is before prev_stop.
6176 (init_iterator): Initialize bidi_p from the default value of
6177 bidi-display-reordering, not from buffer-local value. Use the
6178 buffer-local value only if initializing for buffer iteration.
6179 (handle_invisible_prop): Support invisible properties on strings
6180 that are being bidi-reordered.
6181 (set_iterator_to_next): Support bidi reordering of C strings and
6182 Lisp strings.
6183 (next_element_from_string): Support bidi reordering of Lisp
6184 strings.
6185 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6186 (display_string): Support display of R2L glyph rows.
6187 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6188 (init_iterator): Don't initialize it->bidi_p for strings
6189 here.
6190 (reseat_to_string): Initialize it->bidi_p for strings here.
6191 (next_element_from_string, next_element_from_c_string)
6192 (next_element_from_buffer): Add xassert's for correspondence
6193 between IT's object being iterated and it->bidi_it.string
6194 structure.
6195 (face_before_or_after_it_pos): Support bidi iteration.
6196 (next_element_from_c_string): Handle the case of the first string
6197 character that is not the first one in the visual order.
6198 (get_visually_first_element): New function, refactored from common
6199 parts of next_element_from_buffer, next_element_from_string, and
6200 next_element_from_c_string.
6201 (tool_bar_lines_needed, redisplay_tool_bar)
6202 (display_menu_bar): Force left-to-right direction. Add a FIXME
6203 comment for making that be controlled by a user option.
6204 (push_it, pop_it): Save and restore the state of the
6205 bidi iterator. Save and restore the bidi_p flag.
6206 (pop_it): Iterate out of display property for string iteration as
6207 well.
6208 (iterate_out_of_display_property): Support iteration over strings.
6209 (handle_single_display_spec): Set up it->bidi_it for iteration
6210 over a display string, and call bidi_init_it.
6211 (handle_single_display_spec, next_overlay_string)
6212 (get_overlay_strings_1, push_display_prop): Set up the bidi
6213 iterator for displaying display or overlay strings.
6214 (forward_to_next_line_start): Don't use the shortcut if
6215 bidi-iterating.
6216 (back_to_previous_visible_line_start): If handle_display_prop
6217 pushed the iterator stack, restore the internal state of the bidi
6218 iterator by calling bidi_pop_it same number of times.
6219 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6220 and we are bidi-iterating, don't decrement the iterator position;
6221 instead, set the first_elt flag in the bidi iterator, to produce
6222 the same effect.
6223 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6224 (push_display_prop): xassert that we are iterating a buffer.
6225 (push_it, pop_it): Save and restore paragraph_embedding member.
6226 (handle_single_display_spec, next_overlay_string)
6227 (get_overlay_strings_1, reseat_1, reseat_to_string)
6228 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6229 correctly. Don't assume unibyte strings are not bidi-reordered.
6230 (compute_display_string_pos)
6231 (compute_display_string_end): Fix handling the case of C string.
6232 (push_it, pop_it): Save and restore from_disp_prop_p.
6233 (handle_single_display_spec, push_display_prop): Set the
6234 from_disp_prop_p flag.
6235 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6236 (pop_it): Call iterate_out_of_display_property only if we are
6237 popping after iteration over a string that came from a display
6238 property. Fix a typo in popping stretch info. Add an assertion
6239 for verifying that the iterator position is in sync with the bidi
6240 iterator.
6241 (handle_single_display_spec, get_overlay_strings_1)
6242 (push_display_prop): Fix initialization of paragraph direction for
6243 string when that of the parent object is not yet determined.
6244 (reseat_1): Call bidi_init_it to resync the bidi
6245 iterator with IT's position. (Bug#7616)
6246 (find_row_edges): If ROW->start.pos gives position
6247 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6248 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6249 Reset the from_disp_prop_p flag.
6250 (SAVE_IT, RESTORE_IT): New macros.
6251 (pos_visible_p, face_before_or_after_it_pos)
6252 (back_to_previous_visible_line_start)
6253 (move_it_in_display_line_to, move_it_in_display_line)
6254 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6255 (try_scrolling, redisplay_window, display_line): Use them when
6256 saving a temporary copy of the iterator and restoring it back.
6257 (back_to_previous_visible_line_start, reseat_1)
6258 (init_iterator): Empty the bidi cache "stack".
6259 (move_it_in_display_line_to): If iterator ended up at
6260 EOL, but we never saw any buffer positions smaller than
6261 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6262 motion in bidi-reordered lines.
6263 (move_it_in_display_line_to): Record prev_method and prev_pos
6264 immediately before the call to set_iterator_to_next. Fixes cursor
6265 motion in bidi-reordered lines with stretch glyphs and strings
6266 displayed in margins. (Bug#8133) (Bug#8867)
6267 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6268 TO_CHARPOS.
640c8776
SM
6269 (pos_visible_p): Support positions in bidi-reordered lines.
6270 Save and restore bidi cache.
0bb23927
EZ
6271
6272 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6273 (bidi_paragraph_info): Delete unused struct.
6274 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6275 (bidi_cache_start): New variable.
6276 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6277 to zero.
6278 (bidi_cache_fetch_state, bidi_cache_search)
6279 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6280 (bidi_cache_find, bidi_peek_at_next_level)
6281 (bidi_level_of_next_char, bidi_find_other_level_edge)
6282 (bidi_move_to_visually_next): Compare cache index with
6283 bidi_cache_start rather than with zero.
6284 (bidi_fetch_char): Accept new argument STRING; all callers
6285 changed. Support iteration over a string. Support strings with
6286 display properties. Support unibyte strings. Fix the type of
6287 `len' according to what STRING_CHAR_AND_LENGTH expects.
6288 (bidi_paragraph_init, bidi_resolve_explicit_1)
6289 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6290 (bidi_level_of_next_char, bidi_move_to_visually_next):
6291 Support iteration over a string.
0bb23927
EZ
6292 (bidi_set_sor_type, bidi_resolve_explicit_1)
6293 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6294 can now be zero (for strings); special values 0 and -1 were
6295 changed to -1 and -2, respectively.
6296 (bidi_char_at_pos): New function.
6297 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6298 Call it instead of FETCH_MULTIBYTE_CHAR.
6299 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6300 initialized to valid values.
6301 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6302 values.
6303 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6304 the test for valid cached positions. Fix the logic for looking up
6305 the sentinel state in the cache. GCPRO the Lisp string we are
6306 iterating.
6307 (bidi_push_it, bidi_pop_it): New functions.
6308 (bidi_initialize): Initialize the bidi cache start stack pointer.
6309 (bidi_cache_ensure_space): New function, refactored from part of
6310 bidi_cache_iterator_state. Don't assume the required size is just
6311 one BIDI_CACHE_CHUNK away.
6312 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6313 (bidi_count_bytes, bidi_char_at_pos): New functions.
6314 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6315 always valid if bidi_cache_idx is valid.
6316 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6317 is valid if it's going to be used.
6318 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6319 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6320 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6321 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6322 (bidi_find_other_level_edge, bidi_cache_start_stack):
6323 All variables related to cache indices are now EMACS_INT.
c965adc5 6324
0bb23927
EZ
6325 * dispextern.h (struct bidi_string_data): New structure.
6326 (struct bidi_it): New member `string'. Make flag members be 1-bit
6327 fields, and put them last in the struct.
640c8776
SM
6328 (compute_display_string_pos, compute_display_string_end):
6329 Update prototypes.
0bb23927
EZ
6330 (bidi_push_it, bidi_pop_it): Add prototypes.
6331 (struct iterator_stack_entry): New members bidi_p,
6332 paragraph_embedding, and from_disp_prop_p.
6333 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6334 (bidi_shelve_cache, bidi_unshelve_cache):
6335 Declare prototypes.
0bb23927
EZ
6336
6337 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6338 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6339 and vector-like objects.
6340
6341 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6342 cache around display iteration.
6343
6344 * window.c (Fwindow_end, window_scroll_pixel_based)
6345 (displayed_window_lines, Frecenter): Save and restore the bidi
6346 cache around display iteration.
6347
3bbd2265
LMI
63482011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6349
6350 * editfns.c (Fdelete_region): Clarify the use of the named
6351 parameters (bug#6788).
6352
adc47434
MR
63532011-07-14 Martin Rudalics <rudalics@gmx.at>
6354
6355 * indent.c (Fvertical_motion): Set and restore w->pointm when
6356 saving and restoring the window's buffer (Bug#9006).
6357
837c31f8
LMI
63582011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6359
6360 * editfns.c (Fstring_to_char): Clarify just what is returned
6361 (bug#6576). Text by Eli Zaretskii.
6362
ac389d0c
JB
63632011-07-13 Juanma Barranquero <lekktu@gmail.com>
6364
6365 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6366
0be0ce47
EZ
63672011-07-13 Eli Zaretskii <eliz@gnu.org>
6368
6369 * buffer.c (mmap_find): Fix a typo.
6370
cd18e7e3
JB
63712011-07-13 Johan Bockgård <bojohan@gnu.org>
6372
6373 Fix execution of x selection hooks.
6374 * xselect.c (Qx_lost_selection_functions)
6375 (Qx_sent_selection_functions): New vars.
6376 (syms_of_xselect): DEFSYM them.
6377 (x_handle_selection_request): Pass Qx_sent_selection_functions
6378 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6379 (x_handle_selection_clear,x_clear_frame_selections):
6380 Pass Qx_lost_selection_functions rather than
6381 Vx_lost_selection_functions to Frun_hook_with_args.
6382
47ea7f44
PE
63832011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6384
ac389d0c 6385 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6386 The old code sometimes used this field without initializing it.
6387
47ea7f44
PE
6388 * alloc.c (gc_sweep): Don't read past end of array.
6389 In theory, the old code could also have corrupted Emacs internals,
6390 though it'd be very unlikely.
6391
bc985c87
AS
63922011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6393
6394 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6395 argument. (Bug#4026)
bc985c87 6396
0cf34688
LMI
63972011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6398
b3dadd76
LMI
6399 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6400 key" (bug#4257).
6401
0cf34688
LMI
6402 * window.c (Fset_window_start): Doc fix (bug#4199).
6403 (Fset_window_hscroll): Ditto.
6404
270768cd
PE
64052011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6406
077e3dda 6407 Fix minor new problems caught by GCC 4.6.1.
270768cd 6408 * term.c (init_tty): Remove unused local.
490011a6 6409 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6410 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6411 not used otherwise.
270768cd 6412
b1f58454
CY
64132011-07-12 Chong Yidong <cyd@stupidchicken.com>
6414
6415 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6416
22b9578d
LMI
64172011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6418
6e70ab07
LMI
6419 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6420 are the mini-buffer and the echo area (bug#3320).
6421
22b9578d
LMI
6422 * term.c (init_tty): Remove support for supdup, c10 and perq
6423 terminals, which are no longer supported (bug#1482).
6424
8974cc9f
JB
64252011-07-10 Johan Bockgård <bojohan@gnu.org>
6426
6427 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6428
a560d974
JD
64292011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6430
6431 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6432 for non-popups (Bug#3642).
6433
1dae0f0a
AS
64342011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6435
268c2c36 6436 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6437 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6438 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6439 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6440 * data.c (fmod): Likewise.
6441 * dispnew.c (swap_glyphs_in_rows): Likewise.
6442 * emacs.c (memory_warning_signal): Likewise.
6443 * floatfns.c (float_error): Likewise.
6444 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6445 (otf_open, font_otf_capability, generate_otf_features)
6446 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6447 Likewise.
6448 * image.c (pbm_read_file): Likewise.
6449 * indent.c (string_display_width): Likewise.
6450 * intervals.c (check_for_interval, search_for_interval)
6451 (inc_interval_count, count_intervals, root_interval)
6452 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6453 * lread.c (defalias): Likewise.
268c2c36 6454 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6455 * regex.c (set_image_of_range_1, set_image_of_range)
6456 (regex_grow_registers): Likewise.
6457 * sysdep.c (strerror): Likewise.
6458 * termcap.c (valid_filename_p, tprint, main): Likewise.
6459 * tparam.c (main): Likewise.
6460 * unexhp9k800.c (run_time_remap, save_data_space)
6461 (update_file_ptrs, read_header, write_header, calculate_checksum)
6462 (copy_file, copy_rest, display_header): Likewise.
6463 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6464 Likewise.
6465 * xdisp.c (check_it): Likewise.
6466 * xfaces.c (register_color, unregister_color, unregister_colors):
6467 Likewise.
6468 * xfns.c (print_fontset_result): Likewise.
6469 * xrdb.c (member, fatal, main): Likewise.
6470
99033785
PE
64712011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6472
6473 Fix minor problems found by static checking (Bug#9031).
6474 * chartab.c (char_table_set_range, map_sub_char_table):
6475 Remove unused locals.
6476 (uniprop_table): Now static.
6477 * composite.c (_work_char): Remove unused static var.
6478
9cb2ac56
JB
64792011-07-09 Juanma Barranquero <lekktu@gmail.com>
6480
6481 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6482
f25661f0
JD
64832011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6484
6485 * gtkutil.c (qttip_cb): Remove code without function.
6486
8278c4fe
EZ
64872011-07-09 Eli Zaretskii <eliz@gnu.org>
6488
6489 * w32.c (pthread_sigmask): New stub.
6490
1692ae2d 64912011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6492
8a6ebd58 6493 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6494 sigprocmask is portable only for single-threaded applications, and
6495 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6496 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6497 (LIBES): Use it.
6498 * callproc.c (Fcall_process):
6499 * process.c (create_process):
6500 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6501 Use pthread_sigmask, not sigprocmask.
123403e4 6502
1b854618
JD
65032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6504
6505 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6506 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6507 wrong (Bug#8591).
6508
3fe4b549
JD
65092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6510
0ce7e563
JD
6511 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6512 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6513 (xg_hide_tooltip): Fix comment.
6514
3fe4b549
JD
6515 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6516 in registerServicesMenuSendTypes.
6517 (validRequestorForSendType): Don't check ns_return_types.
6518
6519 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6520 ns_return_type.
6521
5df75e47
JR
65222011-07-08 Jason Rumney <jasonr@gnu.org>
6523
22610910
JR
6524 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6525 SH_SHOW for hidden windows (Bug#5482).
6526
5df75e47
JR
6527 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6528 frame struct members of non-existent frames (Bug#6284).
6529
699c10bd
JD
65302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6531
4393663b
JD
6532 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6533 variable firstTime not needed on OSX >= 10.6.
6534 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6535 >= 10.5. Use setKnobProportion, setDoubleValue.
6536
6537 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6538 (MAC_OS_X_VERSION_10_5): Define if not defined.
6539 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6540 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6541 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6542
6543 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6544 cString and lossyCString on OSX >= 10.4
6545
58179cce 6546 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6547 sizeToFit on OSX >= 10.2.
6548
6549 * nsimage.m (allocInitFromFile): Don't use deprecated method
6550 bestRepresentationForDevice on OSX >= 10.6.
6551
6552 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6553 to avoid warning.
6554
6555 * emacs.c: Declare unexec_init_emacs_zone.
6556
a63e0781
JD
6557 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6558
699c10bd
JD
6559 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6560
6561 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6562 on svcsMenu (Bug#8842).
6563
6564 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6565 ns_return_types.
6566 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6567
6568 * nsterm.m (QUTF8_STRING): Declare.
6569 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6570 (validRequestorForSendType): Return type is (id).
6571 Change indexOfObjectIdenticalTo to indexOfObject.
6572 Check if we have local selection before returning self (Bug#8842).
6573 (writeSelectionToPasteboard): Put local selection into paste board
6574 if we have a local selection (Bug#8842).
6575 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6576
6577 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6578 (ns_get_local_selection): Declare.
6579
54e10184
LMI
65802011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6581
9888ff71
LMI
6582 * keymap.c (describe_map_tree): Don't insert a double newline at
6583 the end of the buffer (bug#1169) and return whether we inserted
6584 something.
6585
54e10184
LMI
6586 * callint.c (Fcall_interactively): Change "reading args" to
6587 "providing args" to try to clarify what it does (bug#1010).
6588
15fa4783
KH
65892011-07-07 Kenichi Handa <handa@m17n.org>
6590
6591 * composite.c (composition_compute_stop_pos): Ignore a static
6592 composition starting before CHARPOS (Bug#8915).
6593
6594 * xdisp.c (handle_composition_prop): Likewise.
6595
a8815b00
EZ
65962011-07-07 Eli Zaretskii <eliz@gnu.org>
6597
6598 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6599 (Bug#9015)
6600
ef7b981d 66012011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6602
6603 * character.h (unicode_category_t): New enum type.
6604
6605 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6606 (Qchar_code_property_table): New variable.
6607 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6608 (UNIPROP_COMPRESSED_FORM_P): New macros.
6609 (char_table_ascii): Uncompress the compressed values.
6610 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6611 Uncompress the compressed values.
ac389d0c 6612 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6613 (char_table_ref_and_range): Uncompress the compressed values.
6614 (sub_char_table_set): New arg is_uniprop. Callers changed.
6615 Uncompress the compressed values.
6616 (sub_char_table_set_range): Args changed. Callers changed.
6617 (char_table_set_range): Adjuted for the above change.
6618 (map_sub_char_table): Delete args default_val and parent. Add arg
6619 top. Give decoded values to a Lisp function.
640c8776 6620 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6621 values to a Lisp function. Gcpro more variables.
6622 (uniprop_table_uncompress)
6623 (uniprop_decode_value_run_length): New functions.
6624 (uniprop_decoder, uniprop_decoder_count): New variables.
6625 (uniprop_get_decoder, uniprop_encode_value_character)
6626 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6627 New functions.
6628 (uniprop_encoder, uniprop_encoder_count): New variables.
6629 (uniprop_get_encoder, uniprop_table)
6630 (Funicode_property_table_internal, Fget_unicode_property_internal)
6631 (Fput_unicode_property_internal): New functions.
6632 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6633 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6634 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6635 char-code-property-alist.
6636
640c8776 6637 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6638 Vunicode_category_table.
6639
640c8776 6640 * font.c (font_range): Adjust for the change of
c805dec0
KH
6641 Vunicode_category_table.
6642
76b397fb
DN
66432011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6644
6645 * m/iris4d.h: Remove file, move contents ...
6646 * s/irix6-5.h: ... here.
6647
22b4128e
PE
66482011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6649
6650 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6651 * alloc.c (mark_buffer):
6652 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6653 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6654 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6655 This isn't true in general, and it's particularly not true
6656 if Emacs is configured with --with-wide-int.
6657 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6658 New macros, used in the buffer.c change.
6659
869795d6
JD
66602011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6661
6662 * xsettings.c: Use both GConf and GSettings if both are available.
6663 (store_config_changed_event): Add comment.
6664 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6665 (store_tool_bar_style_changed): New functions.
5e617bc2 6666 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6667 (struct xsettings): Move font inside HAVE_XFT.
6668 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6669 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6670 Move inside HAVE_XFT.
640c8776 6671 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6672 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6673 also.
6674 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6675 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6676 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6677 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6678 (parse_settings): Move check for font inside HAVE_XFT.
6679 (read_settings, apply_xft_settings): Add comment.
6680 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6681 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6682 call store_font_name_changed.
6683 (xft_settings_event): Add comment.
6684 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6685 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6686 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6687 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6688 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6689 (xsettings_get_system_font, xsettings_get_system_normal_font):
6690 Add comment.
869795d6 6691
d8ed26bd
PE
66922011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6693
6694 Random fixes. E.g., (random) never returned negative values.
6695 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6696 subseconds part to the entropy, as that's a bit more random.
6697 Prefer signed to unsigned, since the signedness doesn't matter and
6698 in general we prefer signed. When given a limit, use a
6699 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6700 latter isn't right if USE_2_TAGS_FOR_INTS.
6701 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6702 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6703
cabf1cac
SM
67042011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6705
6706 * textprop.c (text_property_stickiness):
6707 Obey Vtext_property_default_nonsticky.
6708 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6709 * w32fns.c (syms_of_w32fns):
6710 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6711
6e9b2be9
PE
67122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6713
6714 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6715 This is more efficient than Ffile_directory_p and avoids a minor race.
6716
90186c68
LMI
67172011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6718
7c301272
LMI
6719 * buffer.c (Foverlay_put): Say what the return value is
6720 (bug#7835).
6721
c4f2d8d4
LMI
6722 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6723 is a directory before asking whether to use the file name
6724 (bug#7564).
ad637907
LMI
6725 (barf_or_query_if_file_exists): Make the "File is a directory"
6726 error be more correct.
c4f2d8d4 6727
90186c68
LMI
6728 * fns.c (Frequire): Remove the mention of the .gz files, since
6729 that's installation-specific, but keep the mention of
6730 `get-load-suffixes'.
6731
da64016e
PE
67322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6733
6734 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6735 Report string overflow if the output is too long.
6736
7d47b580
JB
67372011-07-04 Juanma Barranquero <lekktu@gmail.com>
6738
a555cb87
JB
6739 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6740 (syms_of_gnutls): Remove duplicate DEFSYM for
6741 Qgnutls_bootprop_verify_hostname_error, an error for
6742 Qgnutls_bootprop_verify_error (which is no longer used).
6743
7d47b580
JB
6744 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6745 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6746 Also (re)move comments that are misplaced or no longer relevant.
6747
1e49bfab
LMI
67482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6749
6750 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6751
1485f4c0
CY
67522011-07-03 Chong Yidong <cyd@stupidchicken.com>
6753
6754 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6755 and background color parameters if they have been changed.
6756
a9ab721e
LMI
67572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6758
6759 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6760
cf7cff57
PE
67612011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6762
2e13213d
PE
6763 * xsettings.c (SYSTEM_FONT): Define only when used.
6764 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6765
cf7cff57
PE
6766 * keymap.c (access_keymap_1): Now static.
6767
7a8e04f7
CY
67682011-07-02 Chong Yidong <cyd@stupidchicken.com>
6769
6770 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6771 leave any prefix arg for the up event (Bug#1586).
6772
61352f62
LMI
67732011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6774
69bb1ef7
LMI
6775 * lread.c (syms_of_lread): Mention single symbols defined by
6776 `defvar' or `defconst' (bug#7154).
6777
61352f62 6778 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6779 (Frequire): Mention get-load-suffixes.
61352f62 6780
28545e04
MR
67812011-07-02 Martin Rudalics <rudalics@gmx.at>
6782
6783 * window.h (window): Remove clone_number slot.
6784 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6785 Remove.
6786 (make_parent_window, make_window, saved_window)
6787 (Fset_window_configuration, save_window_save): Don't deal with
6788 clone numbers.
6789 * buffer.c (Qclone_number): Remove declaration.
6790 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6791
3349e122
SM
67922011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6793
6794 Add multiple inheritance to keymaps.
6795 * keymap.c (Fmake_composed_keymap): New function.
6796 (Fset_keymap_parent): Simplify.
6797 (fix_submap_inheritance): Remove.
6798 (access_keymap_1): New function extracted from access_keymap to handle
6799 embedded parents and handle lists of maps.
6800 (access_keymap): Use it.
6801 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6802 (Fcopy_keymap): Handle embedded parents.
6803 (Fcommand_remapping, define_as_prefix): Simplify.
6804 (Fkey_binding): Simplify.
6805 (syms_of_keymap): Move minibuffer-local-completion-map,
6806 minibuffer-local-filename-completion-map,
6807 minibuffer-local-must-match-map, and
6808 minibuffer-local-filename-must-match-map to Elisp.
6809 (syms_of_keymap): Defsubr make-composed-keymap.
6810 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6811 (parse_menu_item): Trivial simplification.
6812
3279eb87
GM
68132011-07-01 Glenn Morris <rgm@gnu.org>
6814
6815 * Makefile.in (SETTINGS_LIBS): Fix typo.
6816
4550efdf
KI
68172011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6818
6819 * coding.c (Fencode_coding_string): Record the last coding system
6820 used, as the function doc string says (bug#8738).
6821
0949d2b6
JD
68222011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6823
6824 * xsettings.c (store_monospaced_changed): Take new font as arg and
6825 check for change against current_mono_font.
6826 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6827 (emacs_settings_constructor, emacs_settings_get_property)
6828 (emacs_settings_set_property, emacs_settings_class_init)
6829 (emacs_settings_init, gsettings_obj): Remove.
6830 (something_changedCB): New function for HAVE_GSETTINGS.
6831 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6832 with value as argument.
6833 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6834 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6835 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6836 "changed".
6837
6838 * xgselect.c: Add defined (HAVE_GSETTINGS).
6839 (xgselect_initialize): Ditto.
6840
6841 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6842 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6843 xg_select.
6844
bbc6b304
PE
68452011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6846
6847 * eval.c (struct backtrace): Simplify and port the data structure.
6848 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6849 signed bit field, as this assumption is not portable and it makes
6850 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6851 "char debug_on_exit : 1" as this is not portable either; instead,
6852 use the portable "unsigned int debug_on_exit : 1". Remove unused
6853 member evalargs. Remove obsolete comments about cc bombing out.
6854
9851bfc5
JD
68552011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6856
51bb811f 6857 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6858 Let HAVE_GSETTINGS override HAVE_GCONF.
6859 (store_monospaced_changed): New function.
6860 (EMACS_SETTINGS): A new type derived from GObject to handle
6861 GSettings notifications.
6862 (emacs_settings_constructor, emacs_settings_get_property)
6863 (emacs_settings_set_property, emacs_settings_class_init):
6864 New functions.
6865 (gsettings_client, gsettings_obj): New variables.
6866 (GSETTINGS_SCHEMA): New define.
6867 (something_changedCB): Call store_monospaced_changed.
6868 (init_gsettings): New function.
6869 (xsettings_initialize): Call init_gsettings.
6870 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6871 to NULL.
6872
640c8776 6873 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6874 GCONF_CFLAGS/LIBS.
6875
5386012d
MR
68762011-06-29 Martin Rudalics <rudalics@gmx.at>
6877
6878 * window.c (resize_root_window, grow_mini_window)
6879 (shrink_mini_window): Rename Qresize_root_window to
6880 Qwindow_resize_root_window and Qresize_root_window_vertically to
6881 Qwindow_resize_root_window_vertically.
6882
f13e0b08
PE
68832011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6884
6885 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6886
94515237
JB
68872011-06-27 Juanma Barranquero <lekktu@gmail.com>
6888
6889 * makefile.w32-in: Redesign dependencies so they reflect more
6890 clearly which files are directly included by each source file,
6891 and not through other includes.
6892
e43b6e43
MR
68932011-06-27 Martin Rudalics <rudalics@gmx.at>
6894
6895 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6896 (sort_overlays, overlay_strings): When an overlay's clone number
6897 matches the window's clone number process the overlay even if
6898 the overlay's window property doesn't match the current window.
6899
d68443dc
MR
6900 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6901 (Fwindow_hchild): Rename to Fwindow_left_child.
6902 (Fwindow_next): Rename to Fwindow_next_sibling.
6903 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6904 (resize_window_check): Rename to window_resize_check.
6905 (resize_window_apply): Rename to window_resize_apply.
6906 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6907 (Fdelete_other_windows_internal, resize_frame_windows)
6908 (Fsplit_window_internal, Fdelete_window_internal)
6909 (grow_mini_window, shrink_mini_window)
6910 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6911
c7e73be5
JD
69122011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6913
6914 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6915 (emacs_fixed_set_min_size): Remove.
6916 (emacs_fixed_new): Take frame as argument.
6917
6918 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6919 (_EmacsFixedPrivate): Remove minwidth/height.
6920 Add struct frame *f.
6921 (emacs_fixed_init): Initialize priv->f.
6922 (get_parent_class, emacs_fixed_set_min_size): Remove.
6923 (emacs_fixed_new): Set priv->f to argument.
6924 (emacs_fixed_get_preferred_width)
6925 (emacs_fixed_get_preferred_height): Use min_width/height from
6926 frames size_hint to set minimum and natural (Bug#8919).
6927 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6928 and use min_width/height from frames size_hint to set
6929 min_width/height (Bug#8919).
6930
6931 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6932 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6933 Fix indentation.
c7e73be5 6934
cf99dcf8
EZ
69352011-06-26 Eli Zaretskii <eliz@gnu.org>
6936
6937 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6938 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6939 called at ZV.
6940
029529ac
CY
69412011-06-26 Chong Yidong <cyd@stupidchicken.com>
6942
6943 * process.c (wait_reading_process_output): Bypass select if
6944 waiting for a cell while ignoring keyboard input, and input is
6945 pending. Suggested by Jan Djärv (Bug#8869).
6946
7a7ef429
PE
69472011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6948
6949 Use gnulib's dup2 module instead of rolling our own.
6950 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6951
11fdef7d 69522011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6953
6954 * dispnew.c (scrolling_window): Before scrolling, turn off a
6955 mouse-highlight in the window being scrolled.
6956
cd3520a4
JB
69572011-06-24 Juanma Barranquero <lekktu@gmail.com>
6958
6959 Move DEFSYM to lisp.h and use everywhere.
6960
6961 * character.h (DEFSYM): Move declaration...
6962 * lisp.h (DEFSYM): ...here.
6963
6964 * gnutls.c:
6965 * minibuf.c:
6966 * w32menu.c:
6967 * w32proc.c:
6968 * w32select.c: Don't include character.h.
6969
6970 * alloc.c (syms_of_alloc):
6971 * buffer.c (syms_of_buffer):
6972 * bytecode.c (syms_of_bytecode):
6973 * callint.c (syms_of_callint):
6974 * casefiddle.c (syms_of_casefiddle):
6975 * casetab.c (init_casetab_once):
6976 * category.c (init_category_once, syms_of_category):
6977 * ccl.c (syms_of_ccl):
6978 * cmds.c (syms_of_cmds):
6979 * composite.c (syms_of_composite):
6980 * dbusbind.c (syms_of_dbusbind):
6981 * dired.c (syms_of_dired):
6982 * dispnew.c (syms_of_display):
6983 * doc.c (syms_of_doc):
6984 * editfns.c (syms_of_editfns):
6985 * emacs.c (syms_of_emacs):
6986 * eval.c (syms_of_eval):
6987 * fileio.c (syms_of_fileio):
6988 * fns.c (syms_of_fns):
6989 * frame.c (syms_of_frame):
6990 * fringe.c (syms_of_fringe):
6991 * insdel.c (syms_of_insdel):
6992 * keymap.c (syms_of_keymap):
6993 * lread.c (init_obarray, syms_of_lread):
6994 * macros.c (syms_of_macros):
6995 * msdos.c (syms_of_msdos):
6996 * print.c (syms_of_print):
6997 * process.c (syms_of_process):
6998 * search.c (syms_of_search):
6999 * sound.c (syms_of_sound):
7000 * syntax.c (init_syntax_once, syms_of_syntax):
7001 * terminal.c (syms_of_terminal):
7002 * textprop.c (syms_of_textprop):
7003 * undo.c (syms_of_undo):
7004 * w32.c (globals_of_w32):
7005 * window.c (syms_of_window):
7006 * xdisp.c (syms_of_xdisp):
7007 * xfaces.c (syms_of_xfaces):
7008 * xfns.c (syms_of_xfns):
7009 * xmenu.c (syms_of_xmenu):
7010 * xsettings.c (syms_of_xsettings):
7011 * xterm.c (syms_of_xterm): Use DEFSYM.
7012
4228cf16
TZ
70132011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7014
cd3520a4 7015 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7016
7fcccf1e
PE
70172011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7018
7efb4e0e
PE
7019 Integer and buffer overflow fixes (Bug#8873).
7020
ff5844ad
PE
7021 * print.c (printchar, strout): Check for string overflow.
7022 (PRINTPREPARE, printchar, strout):
7023 Don't set size unless allocation succeeds.
7024
90532f02
PE
7025 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7026 for sizes. Check for string overflow more accurately.
7027 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7028
6d84508d
PE
7029 * macros.c: Integer and buffer overflow fixes.
7030 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7031 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7032 Use ptrdiff_t, not int, for sizes.
7033 Don't increment bufsize until after realloc succeeds.
7034 Check for size-calculation overflow.
7035 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7036
437b2cb4
PE
7037 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7038
8b9ac8b4
PE
7039 * lread.c: Integer overflow fixes.
7040 (read_integer): Radix is now EMACS_INT, not int,
7041 to improve quality of diagnostics for out-of-range radices.
7042 Calculate buffer size correctly for out-of-range radices.
7043 (read1): Check for integer overflow in radices, and in
7044 read-circle numbers.
82cb60d3
PE
7045 (read_escape): Avoid int overflow.
7046 (Fload, openp, read_buffer_size, read1)
7047 (substitute_object_recurse, read_vector, read_list, map_obarray):
7048 Use ptrdiff_t, not int, for sizes.
7049 (read1): Use EMACS_INT, not int, for sizes.
20270765 7050 Check for size overflow.
8b9ac8b4 7051
7fcccf1e
PE
7052 * image.c (cache_image): Check for size arithmetic overflow.
7053
bfbbd7e7
PE
7054 * lread.c: Integer overflow issues.
7055 (saved_doc_string_size, saved_doc_string_length)
7056 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7057 Now ptrdiff_t, not int.
7058 (read1): Don't assume doc string length fits in int. Check for
7059 out-of-range doc string lengths.
7060 (read_list): Don't assume file position fits in int.
39019e54 7061 (read_escape): Check for hex character overflow.
bfbbd7e7 7062
4e323265
LL
70632011-06-22 Leo Liu <sdl.web@gmail.com>
7064
7065 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7066 Move to minibuffer.el.
7067
85fece3e
PE
70682011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7069
20b84ce9 7070 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7071 The following patches are for when GLYPH_DEBUG && !XASSERT.
7072 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7073 * dispnew.c (flush_stdout):
7074 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7075 Mark as externally visible.
7076 * dispnew.c (check_window_matrix_pointers): Now static.
7077 * dispnew.c (window_to_frame_vpos):
7078 * xfns.c (unwind_create_frame):
7079 * xterm.c (x_check_font): Remove unused local.
7080 * scroll.c (CHECK_BOUNDS):
7081 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7082 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7083 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7084 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7085 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7086 Now static.
7087 (debug_method_add): Use va_list and vsprintf rather than relying
7088 on undefined behavior with wrong number of arguments.
7089 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7090 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7091 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7092 since we're not interested in debugging glyphs with old libraries.
7093 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7094 GCC 4.6.0's static checking.
7095
0766b489
PE
70962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7097
31fd4b32
PE
7098 Integer overflow and signedness fixes (Bug#8873).
7099 A few related buffer overrun fixes, too.
7100
b79e8648
PE
7101 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7102
0766b489
PE
7103 * dispextern.h (struct face.stipple):
7104 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7105 (x_bitmap_mask, x_allocate_bitmap_record)
7106 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7107 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7108 (x_create_bitmap_from_xpm_data):
7109 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7110 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7111 (.bitmaps_last):
7112 * xfaces.c (load_pixmap):
7113 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7114 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7115 (.bitmaps_last, struct x_output.icon_bitmap):
7116 Use ptrdiff_t, not int, for bitmap indexes.
7117 (x_allocate_bitmap_record): Check for size overflow.
7118 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7119
b081724f
PE
7120 Use ptrdiff_t, not int, for overlay counts.
7121 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7122 * editfns.c (overlays_around, get_pos_property):
7123 * textprop.c (get_char_property_and_overlay):
7124 * xdisp.c (next_overlay_change, note_mouse_highlight):
7125 * xfaces.c (face_at_buffer_position):
21514da7
PE
7126 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7127 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7128 (Fnext_overlay_change, Fprevious_overlay_change)
7129 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7130 Use ptrdiff_t, not int, for sizes.
21514da7 7131 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7132
3de73e5e
PE
7133 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7134
2606c57b
PE
7135 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7136 (x_session_initialize): Do not assume string length fits in int.
7137
aaafe47a
PE
7138 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7139 This is unlikely, but can occur if DPI is outlandish.
7140
2674ddc8 7141 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7142 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7143
28154962
PE
7144 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7145 * xrdb.c (magic_file_p, search_magic_path):
7146 Omit last arg SUFFIX; it was always 0. All callers changed.
7147 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7148
7de51af5
PE
7149 * xfont.c (xfont_match): Avoid need for strlen.
7150
25ed6cc3
PE
7151 * xfns.c: Don't assume strlen fits in int.
7152 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7153
4eab31dd
PE
7154 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7155 not unsigned long, as we prefer signed integers. All callers changed.
7156 Detect integer overflow in repeat count.
7157 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7158 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7159
171e2a58
PE
7160 * termcap.c: Don't assume sizes fit in int and never overflow.
7161 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7162 (gobble_line): Check for size-calculation overflow.
7163
ad39faca 7164 * minibuf.c (Fread_buffer):
6e5bb2dc 7165 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7166 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7167 Don't assume string length fits in int.
7168
52c61c22 7169 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7170 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7171
b5b8c9e5
PE
7172 * font.c: Don't assume string length fits in int.
7173 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7174 Use ptrdiff_t, not int.
ccd6111c
PE
7175 (font_intern_prop): Don't assume string length fits in int.
7176 Don't assume integer property fits in fixnum.
7177 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7178
882f0d81 7179 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7180 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7181 Reformulate so as not to need the command string.
7182 Invoke gzip -cd rather than gunzip, as it's more portable.
7183 (lock_info_type, lock_file_1, lock_file):
7184 Don't assume pid_t and time_t fit in unsigned long.
7185 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7186 (current_lock_owner): Prefer signed type for sizes.
7187 Use memcpy, not strncpy, where memcpy is what is really wanted.
7188 Don't assume (via atoi) that time_t and pid_t fit in int.
7189 Check for time_t and/or pid_t out of range, e.g., via a network share.
7190 Don't alloca where an auto var works fine.
7191
93f4cf88
PE
7192 * fileio.c: Fix some integer overflow issues.
7193 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7194 Don't assume string length fits in int.
7195 (directory_file_name): Don't assume string length fits in long.
7196 (make_temp_name): Don't assume pid fits in int, or that its print
7197 length is less than 20.
7198
f3e92b69
PE
7199 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7200
1bfdaf10
PE
7201 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7202
35016e9a
PE
7203 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7204
3d1e65a1
PE
7205 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7206 We prefer signed integers, even for size calculations.
7207
0b963a93
PE
7208 * emacs.c: Don't assume string length fits in 'int'.
7209 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7210 (main): Don't invoke strlen when not needed.
7211
573f4b54
PE
7212 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7213 (XD_DEBUG_MESSAGE): Don't waste a byte.
7214
989f33ba
PE
7215 * callproc.c (getenv_internal_1, getenv_internal)
7216 (Fgetenv_internal):
965d34eb
PE
7217 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7218
e4d29b33
PE
7219 * lread.c (invalid_syntax): Omit length argument.
7220 All uses changed. This doesn't fix a bug, but it simplifies the
7221 code away from its former Hollerith-constant appearance, and it's
7222 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7223 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7224
eb49b136
PE
7225 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7226 This didn't break anything, but it didn't help either.
7227 It's confusing to put a bogus integer in a place where the actual
7228 value does not matter.
9f62aeb1 7229 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7230 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7231
15375a22
PE
7232 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7233 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7234 implementation.
b61cc01c
PE
7235 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7236 We prefer signed types, and the value cannot exceed the EMACS_INT
7237 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7238 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7239 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7240 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7241
53b2623d
PE
7242 * indent.c (sane_tab_width): New function.
7243 (current_column, scan_for_column, Findent_to, position_indentation)
7244 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7245 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7246
51cab52b 7247 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7248
f2ed8a70
PE
7249 * lisp.h (lint_assume): New macro.
7250 * composite.c (composition_gstring_put_cache):
7251 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7252
abe80cc6
PE
7253 * editfns.c, insdel.c:
7254 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7255
b02c740e
PE
7256 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7257
ebc96716
PE
7258 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7259
b4e50fa0 7260 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7261 Use much-faster test for byte-length change.
311d5d7c 7262 Don't assume string byte-length fits in 'int'.
a4cf38e4 7263 Check that character arg fits in 'int'.
85461888 7264 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7265
c0c1ee9f
PE
7266 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7267
a498d7f4
PE
7268 * fns.c (concat): Catch string overflow earlier.
7269 Do not rely on integer wraparound.
7270
51cab52b
PE
7271 * dispextern.h (struct it.overlay_strings_charpos)
7272 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7273 * xdisp.c (forward_to_next_line_start)
7274 (back_to_previous_visible_line_start)
7275 (reseat_at_next_visible_line_start, next_element_from_buffer):
7276 Don't arbitrarily truncate the value of 'selective' to int.
7277
76031fad
PE
7278 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7279
5eb55db9
PE
7280 * composite.c: Don't truncate sizes to 'int'.
7281 (composition_gstring_p, composition_reseat_it)
7282 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7283 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7284 not EMACS_UINT, for indexes.
5eb55db9 7285
0703a717
PE
7286 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7287
d6202519
PE
7288 * buffer.c: Include <verify.h>.
7289 (struct sortvec.priority, struct sortstr.priority):
8961a454 7290 Now EMACS_INT, not int.
c20998a7 7291 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7292 (struct sortstr.size, record_overlay_string)
7293 (struct sortstrlist.size, struct sortlist.used):
7294 Don't truncate size to int.
7295 (record_overlay_string): Check for size-calculation overflow.
d6202519 7296 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7297
d5a19415
JM
72982011-06-22 Jim Meyering <meyering@redhat.com>
7299
029529ac 7300 Don't leak an XBM-image-sized buffer
d5a19415
JM
7301 * image.c (xbm_load): Free the image buffer after using it.
7302
a9041e6c
PE
73032011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7304
7305 Port to Sun C.
7306 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7307 that Sun C diagnosed.
7308 * fns.c (secure_hash): Fix pointer signedness issue.
7309 * intervals.c (static_offset_intervals): New function.
7310 (offset_intervals): Use it.
7311
7f3f739f
LL
73122011-06-21 Leo Liu <sdl.web@gmail.com>
7313
7314 * deps.mk (fns.o):
7315 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7316 sha512.h.
7317
7318 * fns.c (secure_hash): Rename from crypto_hash_function and change
7319 the first arg to accept symbols.
5b66d427 7320 (Fsecure_hash): New primitive.
7f3f739f
LL
7321 (syms_of_fns): New symbols.
7322
76147d94
DD
73232011-06-20 Deniz Dogan <deniz@dogan.se>
7324
7325 * process.c (Fset_process_buffer): Clarify return value in
7326 docstring.
7327
7d7d0045
CY
73282011-06-18 Chong Yidong <cyd@stupidchicken.com>
7329
7330 * dispnew.c (add_window_display_history): Use BVAR.
7331
7332 * xdisp.c (debug_method_add): Use BVAR.
7333 (check_window_end, dump_glyph_matrix, dump_glyph)
7334 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7335
7336 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7337 Likewise.
7338
7339 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7340 check till after the cache is created in init_frame_faces.
7341
ff2bc410
SM
73422011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7343
7344 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7345
28177add
PE
73462011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7347
dd3482fe
PE
7348 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7349 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7350 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7351
393d71f3 7352 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7353 * fileio.c (Finsert_file_contents):
7354 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7355 Remove the old (too-loose) buffer overflow checks.
7356 They weren't needed, since make_gap checks for buffer overflow.
7357 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7358 The old code merely checked for Emacs fixnum overflow, and relied
7359 on undefined (wraparound) behavior. The new code avoids undefined
7360 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7361
2e6813b0 7362 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7363 Tune. Don't use wider integers than needed. Don't use alloca.
7364 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7365
599a9e4f
PE
7366 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7367
99561444
PE
7368 * insdel.c, lisp.h (buffer_overflow): New function.
7369 (insert_from_buffer_1, replace_range, replace_range_2):
7370 * insdel.c (make_gap_larger):
7371 * editfns.c (Finsert_char):
7372 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7373
28177add
PE
7374 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7375
e69dafad
PE
73762011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7377
4baa020d 7378 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7379
b1c46f02
PE
7380 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7381 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7382
e69dafad
PE
7383 * fileio.c: Don't assume EMACS_INT fits in off_t.
7384 (emacs_lseek): New static function.
7385 (Finsert_file_contents, Fwrite_region): Use it.
7386 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7387
566684ea
PE
7388 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7389
e6966cd6
PE
7390 * fns.c: Don't overflow int when computing a list length.
7391 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7392 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7393 truncation on 64-bit hosts. Check for QUIT every
7394 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7395 faster and is responsive enough.
7396 (Flength): Report an error instead of overflowing an integer.
7397 (Fsafe_length): Return a float if the value is not representable
7398 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7399 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7400 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7401
dd0b0efb
PE
7402 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7403 (header_size, word_size): New constants.
7404 (allocate_vectorlike): Don't check size overflow here.
7405 (allocate_vector): Check it here instead, since this is the only
7406 caller of allocate_vectorlike that could cause overflow.
7407 Check that the new vector's length is representable as a fixnum.
7408
86fe5cfe
PE
7409 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7410 The previous code was bogus. For example, next_almost_prime (32)
7411 returned 39, which is undesirable as it is a multiple of 3; and
7412 next_almost_prime (24) returned 25, which is a multiple of 5 so
7413 why was the code bothering to check for multiples of 7?
7414
80e88859
PE
7415 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7416
4a2f0ad6
PE
7417 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7418
f66c7cf8
PE
7419 Variadic C functions now count arguments with ptrdiff_t.
7420 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7421 Back then I didn't know that the Emacs coding style prefers signed int.
7422 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7423 were being counted with int, which may truncate counts on 64-bit
7424 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7425 * lisp.h (struct Lisp_Subr.function.aMANY)
7426 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7427 Arg counts are now ptrdiff_t, not size_t.
7428 All variadic functions and their callers changed accordingly.
7429 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7430 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7431 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7432 * callint.c (Fcall_interactively): Check arg count for overflow,
7433 to avoid potential buffer overrun. Use signed char, not 'int',
7434 for 'varies' array, so that we needn't bother to check its size
7435 calculation for overflow.
7436 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7437 * eval.c (apply_lambda):
7438 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7439 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7440 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7441
a1759b76
PE
7442 * callint.c (Fcall_interactively): Don't use index var as event count.
7443
d96be9fc
PE
7444 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7445 * mem-limits.h (SIZE): Remove; no longer used.
7446
a690a978 7447 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7448
578c21e6
PE
7449 Remove unnecessary casts.
7450 * xterm.c (x_term_init):
7451 * xfns.c (x_set_border_pixel):
7452 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7453 These aren't needed now that we assume ANSI C.
7454
96f53c6c
PE
7455 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7456 It's more likely to cause problems (due to unsigned overflow)
7457 than to cure them.
7458
83c77d31
PE
7459 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7460
ee2079f1
PE
7461 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7462
6da65536
PE
7463 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7464
7147c4a4
PE
7465 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7466
193e32d9
PE
7467 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7468
e5533da6
PE
7469 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7470
9910e595
PE
7471 GLYPH_CODE_FACE returns EMACS_INT, not int.
7472 * dispextern.h (merge_faces):
7473 * xfaces.c (merge_faces):
01103c44
PE
7474 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7475 Don't assume EMACS_INT fits in int.
9910e595 7476
2638320e
PE
7477 * character.h (CHAR_VALID_P): Remove unused parameter.
7478 * fontset.c, lisp.h, xdisp.c: All uses changed.
7479
045eb8d9
PE
7480 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7481
c1f134b5
PE
7482 * fns.c (concat): Minor tuning based on overflow analysis.
7483 This doesn't fix any bugs. Use int to hold character, instead
7484 of constantly refetching from Emacs object. Use XFASTINT, not
7485 XINT, for value known to be a character. Don't bother comparing
7486 a single byte to 0400, as it's always less.
7487
395fcb93 7488 * floatfns.c (Fexpt):
327eeec8
PE
7489 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7490
abbd3d23
PE
7491 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7492 for characters.
7493
684a03ef
PE
7494 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7495
0fed43f3
PE
7496 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7497 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7498 incorrectly succeed when S was a string, because 4294967386 was
7499 truncated before it was used.
7500
8fd02eb7
PE
7501 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7502 Otherwise, an out-of-range integer could cause undefined behavior
7503 on a 64-bit host.
7504
f8c86b69
PE
7505 * composite.c: Use int, not EMACS_INT, for characters.
7506 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7507 EMACS_INT, for values that are known to be in character range.
7508 This doesn't fix any bugs but is the usual style inside Emacs and
7509 may generate better code on 32-bit machines.
7510
34206dd2
PE
7511 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7512 This is for reasons similar to the recent CHAR_STRING fix.
7513 * charset.c (Fencode_char): Check that character arg is actually
7514 a character. Pass an int to ENCODE_CHAR.
7515 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7516 wider than 'int', as a compile-time check to prevent future regressions
7517 in this area.
7518
c5958d4c 7519 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7520
7521 Make sure a 64-bit char is never passed to CHAR_STRING.
7522 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7523 by silently ignoring the top 32 bits, allowing some values
7524 that were far too large to be valid characters.
7525 * character.h: Include <verify.h>.
7526 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7527 arguments are no wider than unsigned, as a compile-time check
7528 to prevent future regressions in this area.
7529 * data.c (Faset):
01103c44 7530 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7531 (Fsubst_char_in_region):
7532 * fns.c (concat):
7533 * xdisp.c (decode_mode_spec_coding):
7534 Adjust to CHAR_STRING's new requirement.
7535 * editfns.c (Finsert_char, Fsubst_char_in_region):
7536 * fns.c (concat): Check that character args are actually
7537 characters. Without this test, these functions did the wrong
7538 thing with wildly out-of-range values on 64-bit hosts.
7539
d37ca623
PE
7540 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7541 These casts should not be needed on 32-bit hosts, either.
7542 * keyboard.c (read_char):
7543 * lread.c (Fload): Remove casts to unsigned.
7544
ea204efb
PE
7545 * lisp.h (UNSIGNED_CMP): New macro.
7546 This fixes comparison bugs on 64-bit hosts.
7547 (ASCII_CHAR_P): Use it.
7548 * casefiddle.c (casify_object):
01103c44 7549 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7550 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7551 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7552 * dispextern.h (FACE_FROM_ID):
7553 * keyboard.c (read_char): Use UNSIGNED_CMP.
7554
41cb286c
PE
7555 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7556 not to EMACS_INT, to avoid GCC warning.
7557
4a1b9832
PE
7558 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7559
55daad71
PE
7560 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7561 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7562 isn't needed on 32-bit machines.
8f95c75c 7563
01103c44
PE
7564 * buffer.c (Fgenerate_new_buffer_name):
7565 Use EMACS_INT for count, not int.
0ceccced 7566 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7567
7568 * data.c (Qcompiled_function): Now static.
7569
c6f072e7
PE
7570 * window.c (window_body_lines): Now static.
7571
20ce5912
PE
7572 * image.c (gif_load): Rename local to avoid shadowing.
7573
9c4c5f81
PE
7574 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7575 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7576 * alloc.c (make_save_value): Integer argument is now of type
7577 ptrdiff_t, not int.
7578 (mark_object): Use ptrdiff_t, not int.
7579 * lisp.h (pD): New macro.
7580 * print.c (print_object): Use it.
7581
c0c5c8ae
PE
7582 * alloc.c: Use EMACS_INT, not int, to count objects.
7583 (total_conses, total_markers, total_symbols, total_vector_size)
7584 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7585 (total_free_floats, total_floats, total_free_intervals)
7586 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7587 Now EMACS_INT, not int. All uses changed.
7588 (Fgarbage_collect): Compute overall total using a double, so that
7589 integer overflow is less likely to be a problem. Check for overflow
7590 when converting back to an integer.
5a25e253
PE
7591 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7592 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7593 These were 'int' variables that could overflow on 64-bit hosts;
7594 they were never used, so remove them instead of repairing them.
211a0b2a 7595 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7596 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7597 Previously, this ceilinged at INT_MAX, but that doesn't work on
7598 64-bit machines.
e46bb31a 7599 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7600
c78baabf 7601 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7602 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7603 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7604 when a (possibly-narrower) signed value would do just as well.
7605 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7606
c9d624c6
PE
7607 * alloc.c: Catch some string size overflows that we were missing.
7608 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7609 for convenience in STRING_BYTES_MAX.
7610 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7611 The definition here is exact; the one in lisp.h was approximate.
7612 (allocate_string_data): Check for string overflow. This catches
7613 some instances we weren't catching before. Also, it catches
7614 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7615 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7616 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7617
c9d624c6
PE
7618 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7619 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7620 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7621
353032ce
PE
7622 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7623
2bccce07
PE
7624 * alloc.c (Fmake_string): Check for out-of-range init.
7625
0ac30604
SM
76262011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7627
7628 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7629
c195f2de
JD
76302011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7631
7632 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7633 xg_get_default_scrollbar_width.
7634
7635 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7636 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7637 (style_changed_cb): Call update_theme_scrollbar_width and call
7638 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7639 all frames (Bug#8505).
7640 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7641 Call gtk_window_set_resizable if HAVE_GTK3.
7642 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7643 and height if HAVE_GTK3 (Bug#8505).
7644 (scroll_bar_width_for_theme): New variable.
7645 (update_theme_scrollbar_width): New function.
7646 (xg_get_default_scrollbar_width): Move code to
7647 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7648 (xg_initialize): Call update_theme_scrollbar_width.
7649
7650 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7651
7652 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7653
e10ac9f1
MR
76542011-06-12 Martin Rudalics <rudalics@gmx.at>
7655
7656 * frame.c (make_frame): Call other_buffer_safely instead of
7657 other_buffer.
7658
7659 * window.c (temp_output_buffer_show): Call display_buffer with
7660 second argument Vtemp_buffer_show_specifiers and reset latter
7661 immediately after the call.
7662 (Vtemp_buffer_show_specifiers): New variable.
7663 (auto_window_vscroll_p, next_screen_context_lines)
7664 (Vscroll_preserve_screen_position): Remove leading asterisks from
7665 doc-strings.
7666
2d3c217e 76672011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7668
7b7f97e8 7669 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7670 * buffer.c (Qclone_number): Remove for now, as it's unused.
7671 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7672 (record_buffer): Remove unused local.
7673 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7674 (set_frame_buffer_list): Remove; unused.
7675 * frame.h (other_visible_frames): Remove decl.
7676 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7677 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7678 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7679 if HAVE_GPM.
7680 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7681 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7682 Define only if HAVE_GPM.
7683 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7684 (update_hints_inhibit): Remove; never set. All uses removed.
7685 * widgetprv.h (emacsFrameClassRec): Remove decl.
7686 * window.c (delete_deletable_window): Now returns void, since it
7687 wasn't returning anything.
7688 (compare_window_configurations): Remove unused locals.
7689 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7690 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7691 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7692 the same widths as pointers. This follows up on the 2011-05-06 patch.
7693 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7694 * xterm.h: Likewise.
7695 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7696
1384b89e
JB
76972011-06-12 Juanma Barranquero <lekktu@gmail.com>
7698
7699 * makefile.w32-in: Update dependencies.
7700 (LISP_H): Add lib/intprops.h.
7701
1100a63c
CY
77022011-06-11 Chong Yidong <cyd@stupidchicken.com>
7703
7704 * image.c (gif_load): Add animation frame delay to the metadata.
7705 (syms_of_image): Use DEFSYM. New symbol `delay'.
7706
6198ccd0
MR
77072011-06-11 Martin Rudalics <rudalics@gmx.at>
7708
7709 * window.c (delete_deletable_window): Re-add.
7710 (Fset_window_configuration): Rewrite to handle dead buffers and
7711 consequently deletable windows.
7712 (window_tree, Fwindow_tree): Remove. Supply functionality in
7713 window.el.
7714 (compare_window_configurations): Simplify code.
7715
b6e3633c
AS
77162011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7717
1ab0dee5
AS
7718 * image.c (imagemagick_load_image): Fix type mismatch.
7719 (Fimagemagick_types): Likewise.
7720
b6e3633c
AS
7721 * window.h (replace_buffer_in_windows): Declare.
7722
9397e56f
MR
77232011-06-11 Martin Rudalics <rudalics@gmx.at>
7724
7725 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7726 Qclone_number. Remove external declaration of Qdelete_window.
7727 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7728 code.
640c8776
SM
7729 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7730 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7731 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7732 buffer list implementation.
7733 (other_buffer_safely): New function.
7734 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7735 calls to replace_buffer_in_windows and
7736 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7737 if allowed.
7738 (record_buffer): Inhibit quitting and rewrite using quittable
7739 functions. Run Qbuffer_list_update_hook if allowed.
7740 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7741 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7742 Move switch-to-buffer to window.el.
9397e56f
MR
7743 (bury-buffer): Move to window.el.
7744 (Vbuffer_list_update_hook): New variable.
7745
7746 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7747 section.
7748
7749 * window.h (resize_frame_windows): Move up in code.
7750 (Fwindow_frame): Remove EXFUN.
7751 (replace_buffer_in_all_windows): Remove prototype.
7752 (replace_buffer_in_windows_safely): Add prototype.
7753
7754 * window.c: Declare Qdelete_window static again. Move down
7755 declaration of select_count.
7756 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7757 (Fother_window): Move to window.el.
7758 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7759 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7760 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7761 window.el.
7762 (replace_buffer_in_windows): Implement by calling
7763 Qreplace_buffer_in_windows.
7764 (replace_buffer_in_all_windows): Remove with some functionality
7765 moved into replace_buffer_in_windows_safely.
7766 (replace_buffer_in_windows_safely): New function.
7767 (select_window_norecord, select_frame_norecord): Move in front
7768 of run_window_configuration_change_hook. Remove now obsolete
7769 declarations.
640c8776
SM
7770 (Fset_window_buffer): Rewrite doc-string.
7771 Call Qrecord_window_buffer.
9397e56f
MR
7772 (keys_of_window): Move binding for other-window to window.el.
7773
b50691aa
CY
77742011-06-11 Chong Yidong <cyd@stupidchicken.com>
7775
7776 * dispextern.h (struct image): Replace data member, whose int_val
7777 and ptr_val fields were not used by anything, with a single
7778 lisp_val object.
7779
7780 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7781 (gif_clear_image, gif_load, imagemagick_load_image)
7782 (gs_clear_image, gs_load): Callers changed.
7783
3f754b86
PE
77842011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7785
cca69397
PE
7786 * buffer.h: Include <time.h>, for time_t.
7787 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7788
109e28d0
PE
7789 Fix minor problems found by static checking.
7790
60737f02
PE
7791 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7792
4b66faf3
PE
7793 Make identifiers static if they are not used in other modules.
7794 * data.c (Qcompiled_function, Qframe, Qvector):
7795 * image.c (QimageMagick, Qsvg):
7796 * minibuf.c (Qmetadata):
7797 * window.c (resize_window_check, resize_root_window): Now static.
7798 * window.h (resize_window_check, resize_root_window): Remove decls.
7799
109e28d0
PE
7800 * window.c (window_deletion_count, delete_deletable_window):
7801 Remove; unused.
46a4ce9e
PE
7802 (window_body_lines): Now static.
7803 (Fdelete_other_windows_internal): Mark vars as initialized.
7804 Make sure 'resize_failed' is initialized.
7805 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7806 (resize_window_apply): Remove unused local.
7807 * window.h (delete_deletable_window): Remove decl.
7808
109e28d0 7809 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7810 (imagemagick_load_image): Fix pointer signedness problem by changing
7811 last arg from unsigned char * to char *. All uses changed.
7812 Also, fix a local for similar reasons.
7813 Remove unused locals. Remove locals to avoid shadowing.
7814 (fn_rsvg_handle_free): Remove; unused.
7815 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7816 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7817
3f754b86
PE
7818 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7819
2547adb1
CY
78202011-06-10 Chong Yidong <cyd@stupidchicken.com>
7821
7822 * image.c (gif_load): Fix omitted cast error introduced by
7823 2011-06-06 change.
7824
2c8e37d4
MR
78252011-06-10 Martin Rudalics <rudalics@gmx.at>
7826
7827 * window.h (resize_proportionally, orig_total_lines)
7828 (orig_top_line): Remove from window structure.
7829 (set_window_height, set_window_width, change_window_heights)
7830 (Fdelete_window): Remove prototypes.
7831 (resize_frame_windows): Remove duplicate declaration.
7832
440a42e3
EZ
78332011-06-10 Eli Zaretskii <eliz@gnu.org>
7834
7835 * window.h (resize_frame_windows, resize_window_check)
7836 (delete_deletable_window, resize_root_window)
7837 (resize_frame_windows): Declare prototypes.
7838
7839 * window.c (resize_window_apply): Make definition be "static" to
7840 match the prototype.
7841
562dd5e9
MR
78422011-06-10 Martin Rudalics <rudalics@gmx.at>
7843
7844 * window.c: Remove declarations of Qwindow_size_fixed,
7845 window_min_size_1, window_min_size_2, window_min_size,
7846 size_window, window_fixed_size_p, enlarge_window, delete_window.
7847 Remove static from declaration of Qdelete_window, it's
7848 temporarily needed by Fbury_buffer.
7849 (replace_window): Don't assign orig_top_line and
7850 orig_total_lines.
7851 (Fdelete_window, delete_window): Remove. Window deletion is
7852 handled by window.el.
640c8776
SM
7853 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7854 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7855 (Fdelete_other_windows): Remove. Deleting other windows is
7856 handled by window.el.
7857 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7858 handled in window.el.
7859 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7860 Window minimum sizes are handled in window.el.
7861 (shrink_windows, size_window, set_window_height)
7862 (set_window_width, change_window_heights, window_height)
7863 (window_width, CURBEG, CURSIZE, enlarge_window)
7864 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7865 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7866 handled in window.el.
7867 (make_dummy_parent): Rename to make_parent_window and give it a
7868 second argument horflag.
7869 (make_window): Don't set resize_proportionally any more.
7870 (Fsplit_window): Remove. Windows are split in window.el.
7871 (save_restore_action, save_restore_orig_size)
7872 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7873 Resize mini windows in window.el.
7874 (grow_mini_window, shrink_mini_window): Implement by calling
7875 Qresize_root_window_vertically, resize_window_check and
7876 resize_window_apply.
640c8776
SM
7877 (saved_window, Fset_window_configuration, save_window_save):
7878 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7879 resize_proportionally.
7880 (window_min_height, window_min_width): Move to window.el.
7881 (keys_of_window): Move bindings for delete-other-windows,
7882 split-window, delete-window and enlarge-window to window.el.
7883
7884 * buffer.c: Temporarily extern Qdelete_window.
7885 (Fbury_buffer): Temporarily call Qdelete_window instead of
7886 Fdelete_window (Fbury_buffer will move to window.el soon).
7887
7888 * frame.c (set_menu_bar_lines_1): Remove code handling
7889 orig_top_line and orig_total_lines.
7890
7891 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7892 set_window_height but set heights directly.
7893 (change_frame_size_1): Use resize_frame_windows.
7894
7895 * xdisp.c (init_xdisp): Don't use set_window_height but set
7896 heights directly.
7897
640c8776
SM
7898 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7899 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7900 run_window_configuration_change_hook.
7901
7902 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7903 instead of change_window_heights and run
7904 run_window_configuration_change_hook.
7905
1a13852e
MR
79062011-06-09 Martin Rudalics <rudalics@gmx.at>
7907
7908 * window.c (replace_window): Rename second argument REPLACEMENT to
7909 NEW. New third argument SETFLAG. Rewrite.
7910 (delete_window, make_dummy_parent): Call replace_window with
7911 third argument 1.
7912 (window_list_1): Move down in code.
7913 (run_window_configuration_change_hook): Move set_buffer part
7914 before select_frame_norecord part in order to unwind correctly.
7915 Rename count1 to count.
7916 (recombine_windows, delete_deletable_window, resize_root_window)
7917 (Fdelete_other_windows_internal)
7918 (Frun_window_configuration_change_hook, make_parent_window)
7919 (resize_window_check, resize_window_apply, Fresize_window_apply)
7920 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7921 (Fdelete_window_internal, Fresize_mini_window_internal):
7922 New functions.
1a13852e
MR
7923 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7924
f3d1777e
MR
79252011-06-08 Martin Rudalics <rudalics@gmx.at>
7926
496e208e
MR
7927 * window.h (window): Add some new members to window structure -
7928 normal_lines, normal_cols, new_total, new_normal, clone_number,
7929 splits, nest, prev_buffers, next_buffers.
7930 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7931 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7932
f3d1777e
MR
7933 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7934 Remove.
496e208e
MR
7935 (make_dummy_parent): Set new members of windows structure.
7936 (make_window): Move down in code. Handle new members of window
7937 structure.
7938 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7939 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7940 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7941 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7942 (Fset_window_next_buffers, Fset_window_clone_number):
7943 New functions.
496e208e
MR
7944 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7945 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7946 Doc-string fixes.
7947 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7948 Argument WINDOW can be now internal window too.
7949 (Fwindow_use_time): Move up in code.
7950 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7951 Rewrite doc-string.
7952 (Fset_window_configuration, saved_window)
7953 (Fcurrent_window_configuration, save_window_save): Handle new
7954 members of window structure.
b9e809c2
MR
7955 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7956 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7957 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7958 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7959 Qget_mru_window, Qresize_root_window,
7960 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7961 Qauto_buffer_name; staticpro them.
f3d1777e 7962
abde8f8c
MR
79632011-06-07 Martin Rudalics <rudalics@gmx.at>
7964
7965 * window.c (Fwindow_total_size, Fwindow_left_column)
7966 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7967 (Fwindow_list_1): New functions.
7968 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7969 (Fwindow_width, Fscroll_left, Fscroll_right):
7970 Use window_body_cols instead of window_box_text_cols.
7971 (delete_window, Fset_window_configuration):
7972 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7973 (delete_all_subwindows): Take a window as argument and not a
7974 structure. Rewrite.
190b47e6
MR
7975 (window_loop): Remove handling of GET_LRU_WINDOW and
7976 GET_LARGEST_WINDOW.
7977 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7978
7979 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7980 window_box_text_cols. delete_all_subwindows now takes a
7981 Lisp_Object as argument.
abde8f8c 7982
640c8776
SM
7983 * indent.c (compute_motion, Fcompute_motion):
7984 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7985
fa8a67e6
MR
7986 * frame.c (delete_frame): Call delete_all_subwindows with root
7987 window as argument.
7988
a54e3482
DC
79892011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7990
7991 * fns.c (Fputhash): Document return value.
7992
60002bf5
CY
79932011-06-06 Chong Yidong <cyd@stupidchicken.com>
7994
7995 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7996
0c671da6 79972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7998
b862a52a 7999 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8000
be44ca6c
PE
8001 Check for overflow when converting integer to cons and back.
8002 * charset.c (Fdefine_charset_internal, Fdecode_char):
8003 Use cons_to_unsigned to catch overflow.
8004 (Fencode_char): Use INTEGER_TO_CONS.
8005 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8006 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8007 * data.c (long_to_cons, cons_to_long): Remove.
8008 (cons_to_unsigned, cons_to_signed): New functions.
8009 These signal an error for invalid or out-of-range values.
8010 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8011 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8012 * font.c (Ffont_variation_glyphs):
8013 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8014 * lisp.h: Include <intprops.h>.
8015 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8016 (cons_to_signed, cons_to_unsigned): New decls.
8017 (long_to_cons, cons_to_long): Remove decls.
8018 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8019 (Fprimitive_undo): Use CONS_TO_INTEGER.
8020 * xfns.c (Fx_window_property): Likewise.
8021 * xselect.c: Include <limits.h>.
8022 (x_own_selection, selection_data_to_lisp_data):
8023 Use INTEGER_TO_CONS.
8024 (x_handle_selection_request, x_handle_selection_clear)
8025 (x_get_foreign_selection, Fx_disown_selection_internal)
8026 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8027 (lisp_data_to_selection_data): Use cons_to_unsigned.
8028 (x_fill_property_data): Use cons_to_signed.
8029 Report values out of range.
8030
d1f3d2af
PE
8031 Check for buffer and string overflow more precisely.
8032 * buffer.h (BUF_BYTES_MAX): New macro.
8033 * lisp.h (STRING_BYTES_MAX): New macro.
8034 * alloc.c (Fmake_string):
8035 * character.c (string_escape_byte8):
8036 * coding.c (coding_alloc_by_realloc):
8037 * doprnt.c (doprnt):
8038 * editfns.c (Fformat):
8039 * eval.c (verror):
8040 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8041 since they may not be the same number.
8042 * editfns.c (Finsert_char):
8043 * fileio.c (Finsert_file_contents):
8044 Likewise for BUF_BYTES_MAX.
8045
dd52fcea
PE
8046 * image.c: Use ptrdiff_t, not int, for sizes.
8047 (slurp_file): Switch from int to ptrdiff_t.
8048 All uses changed.
8049 (slurp_file): Check that file size fits in both size_t (for
8050 malloc) and ptrdiff_t (for sanity and safety).
8051
7f9bbdbb
PE
8052 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8053 if b->modtime has its maximal value.
8054
dfe18f82
PE
8055 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8056
84acfcf0
PE
8057 Don't assume time_t can fit into int.
8058 * buffer.h (struct buffer.modtime): Now time_t, not int.
8059 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8060 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8061
ccd9a01a
PE
8062 Minor fixes for signed vs unsigned integers.
8063 * character.h (MAYBE_UNIFY_CHAR):
8064 * charset.c (maybe_unify_char):
8065 * keyboard.c (read_char, reorder_modifiers):
8066 XINT -> XFASTINT, since the integer must be nonnegative.
8067 * ftfont.c (ftfont_spec_pattern):
8068 * keymap.c (access_keymap, silly_event_symbol_error):
8069 XUINT -> XFASTINT, since the integer must be nonnegative.
8070 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8071 since it makes no difference and we prefer signed.
8072 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8073 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8074 nonnegative.
8075
d6d100dd
SM
80762011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8077
8078 * window.h (Fwindow_frame): Declare.
8079
2b6148e4
PE
80802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8081
8082 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8083 (SPARE_MEMORY): Always define.
8084 (LARGE_REQUEST): Remove.
8085 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8086
f230ecc9
MR
80872011-06-06 Martin Rudalics <rudalics@gmx.at>
8088
727e958e
MR
8089 * lisp.h: Move EXFUNS for Fframe_root_window,
8090 Fframe_first_window and Fset_frame_selected_window to window.h.
8091
8092 * window.h: Move EXFUNS for Fframe_root_window,
8093 Fframe_first_window and Fset_frame_selected_window here from
8094 lisp.h.
8095
8096 * frame.c (Fwindow_frame, Fframe_first_window)
8097 (Fframe_root_window, Fframe_selected_window)
8098 (Fset_frame_selected_window): Move to window.c.
8099 (Factive_minibuffer_window): Move to minibuf.c.
8100 (Fother_visible_frames_p): New function.
8101
8102 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8103
f230ecc9
MR
8104 * window.c (decode_window, decode_any_window): Move up in code.
8105 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8106 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8107 (Fwindow_buffer): Move up and rewrite doc-string.
8108 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8109 (Fwindow_prev): New functions.
727e958e
MR
8110 (Fwindow_frame): Move here from frame.c. Accept any window as
8111 argument.
8112 (Fframe_root_window, Fframe_first_window)
8113 (Fframe_selected_window): Move here from frame.c. Accept frame
8114 or arbitrary window as argument. Update doc-strings.
8115 (Fminibuffer_window): Move up in code.
8116 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8117 (Fset_frame_selected_window): Move here from frame.c.
8118 Marginal rewrite.
727e958e
MR
8119 (Fselected_window, select_window, Fselect_window): Move up in
8120 code. Minor doc-string fixes.
f230ecc9 8121
4d09bcf6
PE
81222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8123
8124 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8125 Do not assume that spare memory exists; that assumption is valid
8126 only if SYSTEM_MALLOC.
8127 (LARGE_REQUEST): New macro, so that the issue of large requests
8128 is separated from the issue of spare memory.
8129
810928a2
AS
81302011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8131
172418ad
AS
8132 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8133 format. (Bug#8806)
8134
43f862f7
AS
8135 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8136
810928a2
AS
8137 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8138 before statements.
8139
a059fe24
JD
81402011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8141
8142 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8143
8144 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8145
8146 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8147 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8148
989bf368
JB
81492011-06-05 Juanma Barranquero <lekktu@gmail.com>
8150
8151 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8152
4b80f674
CY
81532011-06-04 Chong Yidong <cyd@stupidchicken.com>
8154
8155 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8156 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8157 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8158 New error handlers.
4b80f674
CY
8159 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8160 Obey Vx_select_enable_clipboard_manager. Catch errors in
8161 x_clipboard_manager_save (Bug#8779).
8162 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8163 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8164
99a33b77 81652011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8166
8167 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8168
99a33b77 81692011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8170
8171 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8172 in the current matrix if keep_current_p is non-zero.
8173
8264569d
EZ
81742011-06-04 Eli Zaretskii <eliz@gnu.org>
8175
8176 * bidi.c (bidi_level_of_next_char): Fix last change.
8177
57f97249
EZ
81782011-06-03 Eli Zaretskii <eliz@gnu.org>
8179
fec2107c 8180 Support bidi reordering of text covered by display properties.
57f97249 8181
fec2107c
EZ
8182 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8183 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8184 (bidi_cache_search, bidi_cache_iterator_state)
8185 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8186 (bidi_level_of_next_char, bidi_move_to_visually_next):
8187 Support character positions inside a run of characters covered by a
fec2107c
EZ
8188 display string.
8189 (bidi_paragraph_init, bidi_resolve_explicit_1)
8190 (bidi_level_of_next_char): Call bidi_fetch_char and
8191 bidi_fetch_char_advance instead of FETCH_CHAR and
8192 FETCH_CHAR_ADVANCE.
8193 (bidi_init_it): Initialize new members.
8194 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8195 definitions.
8196 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8197 instead of using explicit *_CHAR codes.
d6d100dd
SM
8198 (bidi_resolve_explicit, bidi_resolve_weak):
8199 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8200 bidirectional text is supported only in multibyte buffers.
8201 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8202 it to initialize the frame_window_p member of struct bidi_it.
8203 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8204 (bidi_resolve_explicit, bidi_resolve_weak)
8205 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8206 bidi_it->nchars is non-positive.
8207 (bidi_level_of_next_char): Don't try to lookup the cache for the
8208 next/previous character if nothing is cached there yet, or if we
8209 were just reseat()'ed to a new position.
c40e2fb2 8210
0e14fe90
EZ
8211 * xdisp.c (set_cursor_from_row): Set start and stop points
8212 according to the row's direction when priming the loop that looks
8213 for the glyph on which to display cursor.
8214 (single_display_spec_intangible_p): Function deleted.
8215 (display_prop_intangible_p): Reimplement to call
8216 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8217 Accept 3 additional arguments needed by handle_display_spec.
8218 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8219 values: lists, `(when COND...)' forms, etc.
8220 (single_display_spec_string_p): Support property values that are
8221 lists with the argument STRING its top-level element.
8222 (display_prop_string_p): Fix the condition for processing a
8223 property that is a list to be consistent with handle_display_spec.
fec2107c 8224 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8225 last portion of handle_display_prop.
8226 (compute_display_string_pos): Accept additional argument
8227 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8228 value of a `display' property is a "replacing spec".
8229 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8230 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8231 the display property, but just return a value indicating whether
8232 the display property will replace the characters it covers.
8233 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8234 frame_window_p members of struct bidi_it.
d6d100dd
SM
8235 (compute_display_string_pos, compute_display_string_end):
8236 New functions.
fec2107c
EZ
8237 (push_it): Accept second argument POSITION, where pop_it should
8238 jump to continue iteration.
8239 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8240
fec2107c
EZ
8241 * keyboard.c (adjust_point_for_property): Adjust the call to
8242 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8243
8244 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8245 (bidi_init_it): Update prototypes.
8246 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8247 (compute_display_string_pos, compute_display_string_end):
8248 Declare prototypes.
fec2107c
EZ
8249 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8250 EMACS_INT.
fc6f18ce 8251
40087514 82522011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8253
57f53182
PE
8254 Malloc failure behavior now depends on size of allocation.
8255 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8256 * lisp.h: Change signatures accordingly.
8257 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8258 All callers changed. (Bug#8762)
8259
8260 * gnutls.c: Use Emacs's memory allocators.
8261 Without this change, the gnutls library would invoke malloc etc.
8262 directly, which causes problems on non-SYNC_INPUT hosts, and which
8263 runs afoul of improving memory_full behavior. (Bug#8761)
8264 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8265 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8266 xfree instead of the default malloc, realloc, free.
8267 (Fgnutls_boot): No need to check for memory allocation failure,
8268 since xmalloc does that for us.
8269
ac32cd99 8270 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8271 * category.c (hash_get_category_set):
8272 * ccl.c (ccl_driver):
8273 * charset.c (Fdefine_charset_internal):
8274 * charset.h (struct charset.hash_index):
8275 * composite.c (get_composition_id, gstring_lookup_cache)
8276 (composition_gstring_put_cache):
8277 * composite.h (struct composition.hash_index):
8278 * dispextern.h (struct image.hash):
8279 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8280 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8281 (hashfn_equal, hashfn_user_defined, make_hash_table)
8282 (maybe_resize_hash_table, hash_lookup, hash_put)
8283 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8284 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8285 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8286 * image.c (make_image, search_image_cache, lookup_image)
8287 (xpm_put_color_table_h):
8288 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8289 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8290 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8291 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8292 * alloc.c (allocate_vectorlike):
8293 Check for overflow in vector size calculations.
8294 * ccl.c (ccl_driver):
8295 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8296 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8297 need to be updated by these changes.
40087514
PE
8298 * fns.c (make_hash_table, maybe_resize_hash_table):
8299 Check for integer overflow with large hash tables.
0de4bb68
PE
8300 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8301 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8302 (SXHASH_REDUCE): New macro.
8303 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8304 Use it instead of discarding useful hash info with large hash values.
8305 (sxhash_float): New function.
8306 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8307 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8308 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8309 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8310 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8311 Adjust signatures to match updated version of code.
8312 (consing_since_gc): Now EMACS_INT, since a single hash table can
8313 use more than INT_MAX bytes.
8314
698d32e2
DN
83152011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8316
8317 Make it possible to build with GCC-4.6+ -O2 -flto.
8318
8319 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8320
fd6fa53f
SM
83212011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8322
8323 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8324 Call minibuffer-inactive-mode.
8325
864db017
JB
83262011-05-31 Juanma Barranquero <lekktu@gmail.com>
8327
8328 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8329 Update dependencies.
8330
2ad0baf4
DN
83312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8332
8333 * data.c (init_data): Remove code for UTS, this system is not
8334 supported anymore.
8335
4fcc2638
DN
83362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8337
8338 Don't force ./temacs to start in terminal mode.
8339
8340 * frame.c (make_initial_frame): Initialize faces in all cases, not
8341 only when CANNOT_DUMP is defined.
8342 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8343
c56e0fd5
DN
83442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8345
8346 * dispnew.c (add_window_display_history): Use const for the string
8347 pointer. Remove declaration, not needed.
8348
333d54da 83492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8350
55d4c1b2 8351 Use 'inline', not 'INLINE'.
333d54da 8352 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8353 * alloc.c, fontset.c (INLINE): Remove.
8354 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8355 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8356 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8357 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8358 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8359
738db178
DN
83602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8361
8362 Make it possible to run ./temacs.
8363
8364 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8365 syms_of_callproc does the same thing. Remove test for
8366 "initialized", do it in the caller.
8367 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8368
620c53a6
SM
83692011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8370
8371 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8372 (read_minibuf): Use get_minibuffer.
8373 (syms_of_minibuf): Use DEFSYM.
8374 (Qmetadata): New var.
8375 * data.c (Qbuffer): Don't make it static.
8376 (syms_of_data): Use DEFSYM.
8377
e003a292
PE
83782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8379
8380 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8381 (CCL_CODE_MIN): New macro.
8382
ed008a6d
PE
83832011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8384
3687c2ef
PE
8385 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8386
ed008a6d
PE
8387 * eval.c (Qdebug): Now static.
8388 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8389 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8390 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8391
d66c4c7c
CY
83922011-05-29 Chong Yidong <cyd@stupidchicken.com>
8393
8394 * image.c: Various fixes to ImageMagick code comments.
8395 (Fimagemagick_types): Doc fix.
8396
5fbc2025
PE
83972011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8398
0196f88a
PE
8399 Minor fixes prompted by GCC 4.6.0 warnings.
8400
8401 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8402
5fbc2025
PE
8403 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8404 (x_clipboard_manager_save_all): Move extern decl to ...
8405 * xterm.h: ... here, so that it can be checked for consistency.
8406
1dd3c2d9
CY
84072011-05-29 Chong Yidong <cyd@stupidchicken.com>
8408
8409 * xselect.c (x_clipboard_manager_save_frame)
8410 (x_clipboard_manager_save_all): New functions.
8411 (Fx_clipboard_manager_save): Lisp function deleted.
8412
8413 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8414 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8415
8416 * xterm.h: Update prototype.
8417
5ba6571d
WX
84182011-05-28 William Xu <william.xwl@gmail.com>
8419
8420 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8421 exiting (Bug#8239).
8422
3eaff834
JM
84232011-05-28 Jim Meyering <meyering@redhat.com>
8424
e1900994 8425 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8426 * fns.c (to_uchar): Define.
8427 (crypto_hash_function): Use it to convert some newly-signed
8428 variables to unsigned, to avoid sign-extension bugs. For example,
8429 without this change, (md5 "truc") would evaluate to
8430 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8431 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8432 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8433
0f6990a7
PE
84342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8435
8436 Integer overflow fixes.
c8a9ca5a 8437
08686060
PE
8438 * dbusbind.c: Serial number integer overflow fixes.
8439 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8440 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8441 to hold a serial number that is too large for a fixnum.
8442 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8443 Check for serial numbers out of range. Decode any serial number
59568bf0 8444 that was so large that it became a float. (Bug#8722)
08686060 8445
2d1fc3c7
PE
8446 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8447 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8448 Use XFASTINT rather than XUINT when numbers are nonnegative.
8449 (xd_append_arg, Fdbus_method_return_internal):
8450 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8451 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8452 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8453 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8454 (Bug#8722)
2d1fc3c7 8455
c8a9ca5a
PE
8456 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8457
519e1d69
PE
8458 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8459
6df6ae42 8460 ccl: Add integer overflow checks.
30569699
PE
8461 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8462 (IN_INT_RANGE): New macros.
8463 (ccl_driver): Use them to check for integer overflow when
8464 decoding a CCL program. Many of the new checks are whether XINT (x)
8465 fits in int; it doesn't always, on 64-bit hosts. The new version
8466 doesn't catch all possible integer overflows, but it's an
847044ea 8467 improvement. (Bug#8719)
30569699 8468
c11285dc
PE
8469 * alloc.c (make_event_array): Use XINT, not XUINT.
8470 There's no need for unsigned here.
8471
fdccd48e
PE
8472 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8473 This follows up to the 2011-05-06 change that substituted uintptr_t
8474 for EMACS_INT. This case wasn't caught back then.
8475
37910ab2
PE
8476 Rework Fformat to avoid integer overflow issues.
8477 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8478 now (part of C89). Include <verify.h>.
8479 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8480 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8481 (Fformat): Avoid the prepass trying to compute sizes; it was only
8482 approximate and thus did not catch overflow reliably. Instead, walk
8483 through the format just once, formatting and computing sizes as we go,
8484 checking for integer overflow at every step, and allocating a larger
8485 buffer as needed. Keep track separately whether the format is
8486 multibyte. Keep only the most-recently calculated precision, rather
8487 than them all. Record whether each argument has been converted to
8488 string. Use EMACS_INT, not int, for byte and char and arg counts.
8489 Support field widths and precisions larger than INT_MAX. Avoid
8490 sprintf's undefined behavior with conversion specifications such as %#d
8491 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8492 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8493 formatting out-of-range floating point numbers with int
9173deec 8494 formats. (Bug#8668)
37910ab2 8495
2e6578fb
PE
8496 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8497
0ae6bdee
PE
8498 * data.c: Avoid integer truncation in expressions involving floats.
8499 * data.c: Include <intprops.h>.
8500 (arith_driver): When there's an integer overflow in an expression
8501 involving floating point, convert the integers to floating point
8502 so that the resulting value does not suffer from catastrophic
8503 integer truncation. For example, on a 64-bit host (* 4
8504 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8505 Do not rely on undefined behavior after integer overflow.
8506
de883a70
PE
8507 merge count_size_as_multibyte, parse_str_to_multibyte
8508 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8509 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8510 Check for integer overflow.
8511 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8512 since it's now a duplicate of the other. This is more of
8513 a character than a buffer op, so better that it's in character.c.
8514 * fns.c, print.c: Adjust to above changes.
8515
2ff916cb
PE
85162011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8517
8518 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8519
f1b54466
PE
85202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8521
fb1ac845
PE
8522 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8523 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8524 (x_clipboard_manager_save): Now static.
8525 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8526
f1b54466
PE
8527 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8528 (crypto_hash_function): Now static.
8529 Fix pointer signedness problems. Avoid unnecessary initializations.
8530
a9f737ee
CY
85312011-05-27 Chong Yidong <cyd@stupidchicken.com>
8532
8533 * termhooks.h (Vselection_alist): Make it terminal-local.
8534
8535 * terminal.c (create_terminal): Initialize it.
8536
8537 * xselect.c: Support for clipboard managers.
8538 (Vselection_alist): Move to termhooks.h as terminal-local var.
8539 (LOCAL_SELECTION): New macro.
8540 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8541 (symbol_to_x_atom): Remove gratuitous arg.
8542 (x_handle_selection_request, lisp_data_to_selection_data)
8543 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8544 (x_own_selection, x_get_local_selection, x_convert_selection):
8545 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8546 (some_frame_on_display): Delete unused function.
8547 (Fx_own_selection_internal, Fx_get_selection_internal)
8548 (Fx_disown_selection_internal, Fx_selection_owner_p)
8549 (Fx_selection_exists_p): New optional frame arg.
8550 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8551 (x_handle_selection_clear): Don't treat other terminals with the
8552 same keyboard specially. Use the terminal-local Vselection_alist.
8553 (x_clear_frame_selections): Use Frun_hook_with_args.
8554
8555 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8556
8557 * xterm.h: Add support for those atoms.
8558
e067f0c1
CY
85592011-05-26 Chong Yidong <cyd@stupidchicken.com>
8560
8561 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8562 (converted_selections, conversion_fail_tag): New global variables.
8563 (x_selection_request_lisp_error): Free the above.
8564 (x_get_local_selection): Remove unnecessary code.
8565 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8566 of converted selections stored in converted_selections.
8567 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8568 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8569 (x_convert_selection): New function.
8570 (x_handle_selection_event): Simplify.
8571 (x_get_foreign_selection): Don't ignore incoming requests while
8572 waiting for an answer; this will fail when we implement
8573 SAVE_TARGETS, and seems unnecessary anyway.
8574 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8575 (Vx_sent_selection_functions): Doc fix.
8576
0f4aebc0
LL
85772011-05-26 Leo Liu <sdl.web@gmail.com>
8578
8579 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8580
e61124cd
YM
85812011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8582
8583 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8584
8585 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8586 for fringe update if it has periodic bitmap.
ac389d0c 8587 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8588 and fringe_bitmap_periodic_p.
8589
8590 * fringe.c (get_fringe_bitmap_data): New function.
8591 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8592 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8593 row. Mark glyph row for fringe update if periodicity changed.
8594
8595 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8596 for fringe update unless it has periodic bitmap.
8597
f16d9837
KH
85982011-05-25 Kenichi Handa <handa@m17n.org>
8599
8600 * xdisp.c (get_next_display_element): Set correct it->face_id for
8601 a static composition.
8602
e1b90ef6
LL
86032011-05-24 Leo Liu <sdl.web@gmail.com>
8604
8605 * deps.mk (fns.o):
8606 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8607
8608 * fns.c (crypto_hash_function, Fsha1): New function.
8609 (Fmd5): Use crypto_hash_function.
8610 (syms_of_fns): Add Ssha1.
8611
7400048f
PE
86122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8613
8614 * gnutls.c: Remove unused macros.
8615 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8616 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8617 Remove macros that are defined and never used.
8618 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8619
abb71cf4
CY
86202011-05-22 Chong Yidong <cyd@stupidchicken.com>
8621
8622 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8623 (Fx_get_selection_internal): Minor cleanup.
8624 (Fx_own_selection_internal): Rename arguments for consistency with
8625 select.el.
8626
6307db39
PE
86272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8628
8629 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8630
f3d4e0a4
CY
86312011-05-22 Chong Yidong <cyd@stupidchicken.com>
8632
8633 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8634
4d8ade89
YM
86352011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8636
8637 * dispnew.c (scrolling_window): Don't exclude the case that the
8638 last enabled row in the desired matrix touches the bottom boundary.
8639
32078c8d
GM
86402011-05-21 Glenn Morris <rgm@gnu.org>
8641
8642 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8643 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8644 and add some more files.
32078c8d 8645
7285dc67
EZ
86462011-05-20 Eli Zaretskii <eliz@gnu.org>
8647
8648 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8649 report_file_error introduced by the change from 2011-05-07.
8650
89d1bd22
PE
86512011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8652
8653 * systime.h (Time): Define only if emacs is defined.
8654 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8655 where the include path doesn't have X11/X.h by default. See
8656 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8657
cd394be1 86582011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8659
8660 * composite.c (find_automatic_composition): Fix previous change.
8661
b9704ad9
GM
86622011-05-20 Glenn Morris <rgm@gnu.org>
8663
8664 * lisp.mk: New file, split from Makefile.in.
8665 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8666 (shortlisp): Remove.
8667 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8668
4a720484
GM
86692011-05-19 Glenn Morris <rgm@gnu.org>
8670
8671 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8672 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8673 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8674 (lisp): Set the order to that of loadup.el.
8675 (shortlisp): Make it a copy of $lisp.
8676 (SOME_MACHINE_LISP): Remove.
8677 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8678 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8679
a28d4396
KH
86802011-05-18 Kenichi Handa <handa@m17n.org>
8681
8682 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8683 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8684 (find_automatic_composition): Mostly rewrite for efficiency.
8685
a2b1fa8e
JB
86862011-05-18 Juanma Barranquero <lekktu@gmail.com>
8687
8688 * makefile.w32-in: Update dependencies.
8689
8e1f5610
CS
86902011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8691
8692 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8693 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8694
7025ee00 86952011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8696
cdfa6eab
PE
8697 Fix some integer overflow issues, such as string length overflow.
8698
06d6db33
PE
8699 * insdel.c (count_size_as_multibyte): Check for string overflow.
8700
2b4560a8
PE
8701 * character.c (lisp_string_width): Check for string overflow.
8702 Use EMACS_INT, not int, for string indexes and lengths; in
8703 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8704 the resulting string length overflows an EMACS_INT; instead,
8705 report a string overflow if no precision given. When checking for
8706 precision exhaustion, use a check that cannot possibly have
8707 integer overflow. (Bug#8675)
8708 * character.h (lisp_string_width): Adjust to new signature.
8709
cb93f9be
PE
8710 * alloc.c (string_overflow): New function.
8711 (Fmake_string): Use it. This doesn't change behavior, but saves
8712 a few bytes and will simplify future changes.
8713 * character.c (string_escape_byte8): Likewise.
8714 * lisp.h (string_overflow): New decl.
8715
1a1f3366
PE
8716 Fixups, following up to the user-interface timestamp change.
8717 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8718 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8719 * msdos.c (mouse_get_pos): Likewise.
8720 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8721 * w32gui.h (Time): Define by including "systime.h" rather than by
8722 declaring it ourselves. (Bug#8664)
8723
d4e3e4d3
PE
8724 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8725 * image.c (clear_image_cache): Likewise.
8726
f6a24d19
PE
8727 * term.c (term_mouse_position): Don't assume time_t wraparound.
8728
08dc5ae6
PE
8729 Be more systematic about user-interface timestamps.
8730 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8731 and sometimes 'EMACS_UINT', to represent these timestamps.
8732 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8733 This makes the code easier to follow, and makes it easier to catch
8734 integer overflow bugs such as Bug#8664.
8735 * frame.c (Fmouse_position, Fmouse_pixel_position):
8736 Use Time, not unsigned long, for user-interface timestamps.
8737 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8738 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8739 * keyboard.h (last_event_timestamp): Likewise.
8740 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8741 * menu.h (xmenu_show): Likewise.
8742 * term.c (term_mouse_position): Likewise.
8743 * termhooks.h (struct input_event.timestamp): Likewise.
8744 (struct terminal.mouse_position_hook): Likewise.
8745 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8746 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8747 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8748 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8749 what it was before.
8750 * menu.h, termhooks.h: Include "systime.h", for Time.
8751
8e55734a
PE
8752 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8753 Don't assume that the difference between two unsigned long values
8754 can fit into an integer. At this point, we know button_down_time
8755 <= event->timestamp, so the difference must be nonnegative, so
8756 there's no need to cast the result if double-click-time is
8757 nonnegative, as it should be; check that it's nonnegative, just in
8758 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8759 apart (about 25 days). (Bug#8664)
8e55734a 8760
841f1b75 8761 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8762 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8763
3e26f69c
PE
8764 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8765 that always fit in int. Use a sentinel instead of a counter, to
8766 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8767 * frame.h (struct frame): Use int for menu_bar_items_used
8768 instead of EMACS_INT, since it always fits in int.
3e26f69c 8769
5cc152c0
PE
8770 * menu.c (grow_menu_items): Check for int overflow.
8771
d89eb65e
PE
8772 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8773
5235bd3e
PE
8774 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8775 Before, the code was not consistent. These values cannot exceed
8776 2**31 - 1 so there's no need to make them unsigned.
8777 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8778 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8779 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8780 as modifiers.
8781 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8782
bc827e23
PE
8783 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8784 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8785 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8786 presumably because the widths might not match.
8787
78eb494e
PE
8788 * window.c (size_window): Avoid needless test at loop start.
8789
04f2d78b
CB
87902011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8791
8792 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8793
d2fc7e3d 87942011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8795
8796 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8797
d2fc7e3d 87982011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8799
8800 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8801 `width' to `bar_area_x' and `bar_area_width', respectively.
8802 (x_scroll_run): Take account of fringe background extension.
8803
04f2d78b
CB
8804 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8805 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8806 `bar_area_width', respectively.
8807 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8808 background extension.
8809
79b70037
GM
88102011-05-10 Jim Meyering <meyering@redhat.com>
8811
8812 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8813
2f142cc5
JB
88142011-05-10 Juanma Barranquero <lekktu@gmail.com>
8815
8816 * image.c (Finit_image_library): Return t for built-in image types,
8817 like pbm and xbm. (Bug#8640)
8818
57679c86
AS
88192011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8820
8821 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8822
888c9e86
EZ
88232011-05-07 Eli Zaretskii <eliz@gnu.org>
8824
b0512a1d
EZ
8825 * w32console.c (Fset_screen_color): Doc fix.
8826 (Fget_screen_color): New function.
8827 (syms_of_ntterm): Defsubr it.
8828
7285dc67
EZ
8829 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8830 unlink the temporary file if Fcall_process didn't create it in the
8831 first place.
8832 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8833 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8834 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8835 cue to call_process_cleanup not to close that handle.
8836
4d3fcc8e
BK
88372011-05-07 Ben Key <bkey76@gmail.com>
8838
8839 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8840 one of two shell specific rules, either bootstrap-temacs-CMD or
8841 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8842 to the previous implementation of the bootstrap-temacs rule.
8843 The bootstrap-temacs-CMD rule is similar to the previous
8844 implementation of the bootstrap-temacs rule except that it
8845 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8846 variable.
8847
8848 These changes, along with some changes to nt/configure.bat,
8849 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8850 earlier fix to add support for --cflags and --ldflags options
8851 that include quotes so that it works whether make uses cmd or
8852 sh as the shell.
8853
b4289b64
MA
88542011-05-06 Michael Albinus <michael.albinus@gmx.de>
8855
8856 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8857 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8858 is a constant.
8859 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8860 a string. Handle both cases.
8861 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8862 (Fdbus_register_method): Use Qinvalid_function.
8863
af4c0e28
JB
88642011-05-06 Juanma Barranquero <lekktu@gmail.com>
8865
8866 * makefile.w32-in: Update dependencies.
8867 (LISP_H): Add inttypes.h and stdin.h.
8868 (PROCESS_H): Add unistd.h.
8869
c51453d9
EZ
88702011-05-06 Eli Zaretskii <eliz@gnu.org>
8871
8872 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8873 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8874
8ff0ac3c 88752011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8876
4c4b566b
PE
8877 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8878
aab2b9b5
PE
8879 * term.c (vfatal): Remove stray call to va_end.
8880 It's not needed and the C Standard doesn't allow it here anyway.
8881
c378da0b
PE
8882 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8883 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8884
288b08c7
PE
8885 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8886 bytes.
8887
e3601888
PE
8888 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8889
db6c0e74
PE
8890 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8891
dd5963ea
PE
8892 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8893
88c9450f
PE
8894 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8895
2f9442b8
PE
8896 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8897
c032b5f8
PE
8898 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8899 * charset.c (Fdefine_charset_internal): Don't initialize
8900 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8901 32-bit int (Bug#8600).
a108c10b
PE
8902
8903 * lread.c (read_integer): Be more consistent with string-to-number.
8904 Use string_to_number to do the actual conversion; this avoids
8905 rounding errors and fixes some other screwups. Without this fix,
8906 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8907 (digit_to_number): Move earlier, for benefit of read_integer.
8908 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8909 not a digit in any supported base. (Bug#8602)
a108c10b 8910
ad5f9eea
PE
8911 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8912
aec1708a
PE
8913 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8914 to match comment at start of function. This also removes a
8915 GCC warning about overflow in a 32+64-bit port.
8916
47be4ab5
PE
8917 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8918
371cac43
PE
8919 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8920 Reported by Stefan Monnier in
8921 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8922 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8923 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8924
d01a7826
PE
8925 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8926 (EMACS_UINTPTR): Likewise, with uintptr_t.
8927
7fd47d5c
PE
8928 * lisp.h: Prefer 64-bit EMACS_INT if available.
8929 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8930 on 32-bit hosts that have 64-bit int, so that they can access
8931 large files.
122b0c86
PE
8932 However, temporarily disable this change unless the temporary
8933 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8934
8727937b
PE
8935 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8936
8ac068ac
PE
8937 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8938 This removes an assumption that EMACS_INT and long are the same
8939 width as pointers. The assumption is true for Emacs porting targets
8940 now, but we want to make other targets possible.
8941 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8942 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8943 In the rest of the code, change types of integers that hold casted
8944 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8945 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8946 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8947 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8948 No need to cast type when ORing.
8949 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8950 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8951 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8952 assume EMACS_INT is the same width as char *.
8953 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8954 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8955 Remove no-longer-needed casts.
8956 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8957 (xg_tool_bar_help_callback, xg_make_tool_item):
8958 Use EMACS_INTPTR to hold an integer
8959 that will be cast to void *; this can avoid a GCC warning
8960 if EMACS_INT is not the same width as void *.
8961 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8962 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8963 (current_message_1, set_message_1):
8964 Use a local to convert to proper width without a cast.
8965 * xmenu.c (dialog_selection_callback): Likewise.
8966
ede49d71
PE
8967 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8968 Also, don't assume VALBITS / RAND_BITS is less than 5,
8969 and don't rely on undefined behavior when shifting a 1 left into
8970 the sign bit.
8971 * lisp.h (get_random): Change signature to match.
8972
2f30ecd0
PE
8973 * lread.c (hash_string): Use size_t, not int, for hash computation.
8974 Normally we prefer signed values; but hashing is special, because
8975 it's better to use unsigned division on hash table sizes so that
8976 the remainder is nonnegative. Also, size_t is the natural width
8977 for hashing into memory. The previous code used 'int', which doesn't
8978 retain enough info to hash well into very large tables.
8979 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8980
2a866e7b
PE
8981 * dbusbind.c: Don't possibly lose pointer info when converting.
8982 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8983 Use XPNTR rather than XHASH, so that the high-order bits of
8984 the pointer aren't lost when converting through void *.
8985
51639eac
PE
8986 * eval.c (Fautoload): Don't double-shift a pointer.
8987
92394119
PE
8988 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8989
dbdb9a7c
JB
89902011-05-06 Juanma Barranquero <lekktu@gmail.com>
8991
8992 * gnutls.c (DEF_GNUTLS_FN):
8993 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8994
db7a0b4f
AS
89952011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8996
8997 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8998 marker. (Bug#8610)
8999
cd394be1 90002011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9001
9002 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9003 New version that can reserve upto 2GB of heap space.
9004
f7ff1b0f 90052011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9006
9007 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9008
639c109b
TZ
90092011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9010
9011 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9012 `gnutls_certificate_set_x509_key_file'.
9013
d2127135
JB
90142011-05-05 Juanma Barranquero <lekktu@gmail.com>
9015
9016 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9017 Update dependencies.
9018
e968f4f3
JB
90192011-05-04 Juanma Barranquero <lekktu@gmail.com>
9020
9021 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9022 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9023 Remove unused parameter `fildes'.
9024 * process.c (read_process_output, send_process): Don't pass it.
9025
84d358f0
JB
90262011-05-04 Juanma Barranquero <lekktu@gmail.com>
9027
9028 Fix previous change: the library cache is defined in w32.c.
9029 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9030 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9031
0898ca10
JB
90322011-05-04 Juanma Barranquero <lekktu@gmail.com>
9033
9034 Implement dynamic loading of GnuTLS on Windows.
9035
9036 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9037 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9038 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9039 Declare.
9040
9041 * gnutls.c (Qgnutls_dll): Define.
9042 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9043 (gnutls_*): Declare function pointers.
9044 (init_gnutls_functions): New function to initialize function pointers.
9045 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9046 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9047 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9048 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9049 (emacs_gnutls_write, emacs_gnutls_read)
9050 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9051 (Fgnutls_available_p): New function.
9052 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9053 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9054 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9055
9056 * image.c: Include w32.h.
9057 (Vimage_type_cache): Delete.
9058 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9059 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9060 (w32_delayed_load): Move to w32.c.
9061
9062 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9063
9064 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9065 (w32_delayed_load): Move from image.c. When loading a library, record
9066 its filename in the :loaded-from property of the library id.
9067 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9068 Initialize and staticpro them.
9069 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9070
9071 * process.c: Include lisp.h before w32.h, not after.
9072 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9073 instead of gnutls_record_check_pending.
9074
9075 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9076
ff4de4aa
TZ
90772011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9078
9079 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9080 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9081 as passed in.
9082
abe95abb
JD
90832011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9084
9085 * xterm.c (x_set_frame_alpha): Do not set property on anything
9086 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9087
e16e55d4
JB
90882011-05-02 Juanma Barranquero <lekktu@gmail.com>
9089
9090 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9091
bafcf6a5
JB
90922011-05-02 Juanma Barranquero <lekktu@gmail.com>
9093
9094 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9095 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9096 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9097 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9098 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9099 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9100 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9101 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9102 (Qgnutls_bootprop_callbacks_verify): Make static.
9103
e7a6747f
AS
91042011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9105
19ed11ba
AS
9106 * callproc.c: Indentation fixup.
9107
e7a6747f 9108 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9109 (wait_for_termination, interruptible_wait_for_termination):
9110 Move after wait_for_termination_1.
e7a6747f 9111
1ef14cb4
LMI
91122011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9113
9114 * sysdep.c (interruptible_wait_for_termination): New function
9115 which is like wait_for_termination, but allows keyboard
9116 interruptions.
9117
9118 * callproc.c (Fcall_process): Add (:file "file") as an option for
9119 the STDOUT buffer.
9120 (Fcall_process_region): Ditto.
9121
330d880c
EZ
91222011-04-30 Eli Zaretskii <eliz@gnu.org>
9123
8db90b73
EZ
9124 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9125 rather than `XVECTOR (FOO)->size'.
9126
330d880c
EZ
9127 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9128 inttypes.h, as a gnulib replacement is used if it not available in
9129 system headers.
9130
15cbd324
EZ
91312011-04-21 Eli Zaretskii <eliz@gnu.org>
9132
9133 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9134 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9135 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9136
9137 * coding.c (coding_alloc_by_realloc): Error out if destination
9138 will grow beyond MOST_POSITIVE_FIXNUM.
9139 (decode_coding_emacs_mule): Abort if there isn't enough place in
9140 charbuf for the composition carryover bytes. Reserve an extra
9141 space for up to 2 characters produced in a loop.
9142 (decode_coding_iso_2022): Abort if there isn't enough place in
9143 charbuf for the composition carryover bytes.
9144
91452011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9146
ae940cca
EZ
9147 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9148 aborting when %lld or %lll format is passed.
9149 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9150 %llo or %llx format is passed. (Bug#8545)
9151
03ab8921
EZ
9152 * window.c (window_scroll_line_based): Use a marker instead of
9153 simple variables to record original value of point. (Bug#7952)
9154
afda1437
EZ
9155 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9156 produced by %s or %c overflows available buffer space. (Bug#8545)
9157
f76dee0c
PE
91582011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9159
9160 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9161 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9162
fdc5744d
JB
91632011-04-28 Juanma Barranquero <lekktu@gmail.com>
9164
9165 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9166
638f053a
JB
91672011-04-28 Juanma Barranquero <lekktu@gmail.com>
9168
9169 * keyboard.c (Qdelayed_warnings_hook): Define.
9170 (command_loop_1): Run `delayed-warnings-hook'
9171 if Vdelayed_warnings_list is non-nil.
9172 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9173 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9174
d178f871
EZ
91752011-04-28 Eli Zaretskii <eliz@gnu.org>
9176
9177 * doprnt.c (doprnt): Don't return value smaller than the buffer
9178 size if the message was truncated. (Bug#8545).
9179
b124fd93
JB
91802011-04-28 Juanma Barranquero <lekktu@gmail.com>
9181
9182 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9183 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9184
e810457d
PE
91852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9186
9187 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9188
ea51cceb
JB
91892011-04-27 Juanma Barranquero <lekktu@gmail.com>
9190
9191 * makefile.w32-in: Update dependencies.
9192
94dcfacf
EZ
91932011-04-27 Eli Zaretskii <eliz@gnu.org>
9194
9195 Improve `doprnt' and its usage. (Bug#8545)
9196 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9197 `format_end'. Remove support for %l as a conversion specifier.
9198 Don't use xrealloc. Improve diagnostics when the %l size modifier
9199 is used. Update the commentary.
9200
9201 * eval.c (verror): Simplify calculation of size_t.
9202
9203 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9204 messages.
9205
f61f41d7
PE
92062011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9207
9208 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9209 change.
9210
96fb4434
PE
92112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9212
9213 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9214 This makes this file independent of the recent pseudovector change.
9215
671875da 92162011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9217
69e9b5a3
PE
9218 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9219
b5f869a7 9220 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9221 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9222 Remove unused local.
c8926152 9223 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9224
841a1577 9225 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9226 GCC 4.6.0 optimizes based on type-based alias analysis.
9227 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9228 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9229 != &v->size, and therefore "v->size = 1; b->size = 2; return
9230 v->size;" must therefore return 1. This assumption is incorrect
9231 for Emacs, since it type-puns struct Lisp_Vector * with many other
9232 types. To fix this problem, this patch adds a new type struct
f904488f 9233 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9234 and pseudovectors, and helps optimizing compilers not get fooled
9235 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9236 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9237 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9238 the size member.
eab3844f
PE
9239 (XSETPVECTYPE): Rewrite in terms of new macro.
9240 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9241 This is a bit clearer, and further avoids the possibility of
9242 undesirable aliasing.
9243 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9244 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9245 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9246 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9247 (ASIZE): Now uses header.size rather than size.
9248 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9249 to avoid the hassle of writing XVECTOR (foo)->header.size.
9250 (struct vectorlike_header): New type.
eab3844f
PE
9251 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9252 object, to help avoid aliasing.
9253 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9254 (SUBRP): Likewise, since Lisp_Subr is a special case.
9255 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9256 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9257 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9258 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9259 changed to be "header.size" and "header.next".
9260 * buffer.h (struct buffer): Likewise.
9261 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9262 * frame.h (struct frame): Likewise.
9263 * process.h (struct Lisp_Process): Likewise.
9264 * termhooks.h (struct terminal): Likewise.
9265 * window.c (struct save_window_data, struct saved_window): Likewise.
9266 * window.h (struct window): Likewise.
9267 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9268 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9269 * buffer.c (init_buffer_once): Likewise.
9270 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9271 special case.
9272 * process.c (Fformat_network_address): Use local var for size,
9273 for brevity.
9274
0df1eac5
PE
9275 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9276
847ab9d1 9277 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9278 * data.c (atof): Remove decl; no longer used or needed.
9279 (digit_to_number): Move to lread.c.
9280 (Fstring_to_number): Use new string_to_number function, to be
9281 consistent with how the Lisp reader treats infinities and NaNs.
9282 Do not assume that floating-point numbers represent EMACS_INT
9283 without losing information; this is not true on most 64-bit hosts.
9284 Avoid double-rounding errors, by insisting on integers when
9285 parsing non-base-10 numbers, as the documentation specifies.
9286 * lisp.h (string_to_number): New decl, replacing ...
9287 (isfloat_string): Remove.
bc0a5c13 9288 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9289 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9290 appears to have been a coding error. Similarly, do not accept
9291 strings like +-1e0 as floating point numbers. Do not report
9292 overflow for integer overflows unless the base is not 10 which
9293 means we have no simple and reliable way to continue.
9294 Break out the floating-point parsing into a new
9295 function string_to_number, so that Fstring_to_number parses
9296 floating point numbers consistently with the Lisp reader.
04f2d78b 9297 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9298 (E_CHAR, EXP_INT): Remove, replacing with ...
9299 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9300 (string_to_number): New function, replacing isfloat_string.
9301 This function checks for valid syntax and produces the resulting
9302 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9303 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9304 so that overflow for non-base-10 numbers is reported only when
9305 there's no portable and simple way to convert to floating point.
452f4150 9306
67769ffc
PE
9307 * textprop.c (set_text_properties_1): Rewrite for clarity,
9308 and to avoid GCC warning about integer overflow.
9309
c20db43f
PE
9310 * intervals.h (struct interval): Use EMACS_INT for members
9311 where EMACS_UINT might cause problems. See
9312 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9313 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9314 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9315 All uses changed.
37aa2f85
PE
9316 (offset_intervals): Tell GCC not to worry about length overflow
9317 when negating a negative length.
c20db43f 9318
2538aa2f
PE
9319 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9320 (overrun_check_free): Likewise.
9321
f2d3008d
PE
9322 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9323 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9324 word size.
9325
ec8df744
PE
9326 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9327 (gnutls_make_error): Rename local to avoid shadowing.
9328 (gnutls_emacs_global_deinit): ifdef out; not used.
9329 (Fgnutls_boot): Use const for pointer to readonly storage.
9330 Comment out unused local. Fix pointer signedness problems.
9331
640ee02d
PE
9332 * lread.c (openp): Don't stuff size_t into an 'int'.
9333 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9334 about possible signed overflow.
9335
6048fb2a
PE
9336 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9337 (GDK_KEY_g): Don't define if already defined.
9338 (xg_prepare_tooltip): Avoid pointer signedness problem.
9339 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9340
fa3c87e1
PE
9341 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9342 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9343
2172544b
PE
9344 * xfns.c (Fx_window_property): Simplify a bit,
9345 to make a bit faster and to avoid GCC 4.6.0 warning.
9346 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9347
9b821a21
PE
9348 * fns.c (internal_equal): Don't assume size_t fits in int.
9349
3c616cfa
PE
9350 * alloc.c (compact_small_strings): Tighten assertion a little.
9351
c2982e87
PE
9352 Replace pEd with more-general pI, and fix some printf arg casts.
9353 * lisp.h (pI): New macro, generalizing old pEd macro to other
9354 conversion specifiers. For example, use "...%"pI"d..." rather
9355 than "...%"pEd"...".
9356 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9357 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9358 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9359 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9360 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9361 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9362 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9363 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9364 64-bit hosts.
9365 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9366 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9367 * print.c (safe_debug_print, print_object): Likewise.
9368 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9369 to int.
6f04d126
PE
9370 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9371 avoiding the 0 flag, which is not portable.
c2982e87
PE
9372 * process.c (Fmake_network_process): Use pI to avoid cast.
9373 * region-cache.c (pp_cache): Likewise.
9374 * xdisp.c (decode_mode_spec): Likewise.
9375 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9376 behavior on 64-bit hosts with printf arg.
6f04d126 9377 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9378 (x_stop_queuing_selection_requests): Likewise.
9379 (x_get_window_property): Don't truncate byte count to an 'int'
9380 when tracing.
0b432f21 9381
5e073ec7
PE
9382 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9383 here, since it parses constructs like leading '-' and spaces,
9384 which are not wanted; and it overflows with large numbers.
9385 Instead, simply match F[0-9]+, which is what is wanted anyway.
9386
36372bf9
PE
9387 * alloc.c: Remove unportable assumptions about struct layout.
9388 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9389 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9390 (allocate_vectorlike, make_pure_vector): Use the new macros,
9391 plus offsetof, to remove unportable assumptions about struct layout.
9392 These assumptions hold on all porting targets that I know of, but
9393 they are not guaranteed, they're easy to remove, and removing them
9394 makes further changes easier.
9395
0b432f21
PE
9396 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9397 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9398 (string_overrun_cookie): Now const. Use initializers that
9399 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9400 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9401 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9402 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9403 multiple of sizeof (EMACS_INT); it need not be, if
9404 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9405 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9406
895009e1
JB
94072011-04-26 Juanma Barranquero <lekktu@gmail.com>
9408
9409 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9410
6a7a1b0b
TZ
94112011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9412
9413 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9414 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9415 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9416
841a1577 94172011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9418
9419 * lisp.h (Qdebug): List symbol.
895009e1 9420 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9421 * keyboard.c (debug-on-event): New variable.
9422 (handle_user_signal): Break into debugger when debug-on-event
9423 matches the current signal symbol.
9424
f2d3ba6f
DN
94252011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9426
9427 * alloc.c (check_sblock, check_string_bytes)
9428 (check_string_free_list): Convert to standard C.
9429
42ce4c63
TZ
94302011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9431
9432 * w32.c (emacs_gnutls_push): Fix typo.
9433
825cd63c
EZ
94342011-04-25 Eli Zaretskii <eliz@gnu.org>
9435
fb11d64d
EZ
9436 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9437 "cast to pointer from integer of different size".
9438
825cd63c
EZ
9439 Improve doprnt and its use in verror. (Bug#8545)
9440 * doprnt.c (doprnt): Document the set of format control sequences
9441 supported by the function. Use SAFE_ALLOCA instead of always
9442 using `alloca'.
9443
9444 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9445 is one byte too soon. Don't use xrealloc; instead xfree and
9446 xmalloc anew.
9447
e061a11b
TZ
94482011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9449
9450 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9451 callbacks stage.
9452
9453 * gnutls.c: Renamed global_initialized to
9454 gnutls_global_initialized. Added internals for the
9455 :verify-hostname-error, :verify-error, and :verify-flags
9456 parameters of `gnutls-boot' and documented those parameters in the
9457 docstring. Start callback support.
9173deec
JB
9458 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9459 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9460 on error. Return error code.
e061a11b
TZ
9461 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9462 (emacs_gnutls_read): Likewise.
9463 (Fgnutls_boot): Return handshake error code.
9464 (emacs_gnutls_handle_error): New function.
9465 (wsaerror_to_errno): Likewise.
9466
9467 * w32.h (emacs_gnutls_pull): Add prototype.
9468 (emacs_gnutls_push): Likewise.
9469
9470 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9471 (emacs_gnutls_push): Likewise.
9472
94732011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9474
9475 * process.c (wait_reading_process_output): Check if GnuTLS
9476 buffered some data internally if no FDs are set for TLS
9477 connections.
9478
9479 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9480 (LIBS): Link to USER_LIBS.
9481 ($(BLD)/gnutls.$(0)): New target.
9482
fa6996bc
EZ
94832011-04-24 Eli Zaretskii <eliz@gnu.org>
9484
eb35682e
EZ
9485 * xdisp.c (handle_single_display_spec): Rename the
9486 display_replaced_before_p argument into display_replaced_p, to
9487 make it consistent with the commentary. Fix typos in the
9488 commentary.
9489
e2ad650c
EZ
9490 * textprop.c (syms_of_textprop): Remove dead code.
9491 (copy_text_properties): Delete obsolete commentary about an
9492 interface that was deleted long ago. Fix typos in the description
9493 of arguments.
9494
1b2de274
EZ
9495 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9496 to changes in oldXMenu/XMenu.h from 2011-04-16.
9497 <menu_help_message, prev_menu_help_message>: Constify.
9498 (IT_menu_make_room): menu->help_text is now `const char **';
9499 adjust.
9500
9501 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9502 to changes in oldXMenu/XMenu.h from 2011-04-16.
9503 (struct XMenu): Declare `help_text' `const char **'.
9504
9505 * xfaces.c <Qunspecified>: Make extern again.
9506
9507 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9508 required by POSIX.
1b2de274 9509
762b15be
EZ
9510 * doc.c (get_doc_string): Improve the format passed to `error'.
9511
9512 * doprnt.c (doprnt): Improve commentary.
9513
9514 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9515
9516 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9517 them with etags.
9518
f1052e5d
EZ
9519 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9520 changes in globals.h immediately force recompilation.
762b15be
EZ
9521 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9522 $(CURDIR)/s/ms-w32.h.
9523 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9524
fa6996bc
EZ
9525 * character.c (Fchar_direction): Function deleted.
9526 (syms_of_character): Don't defsubr it.
9527 <char-direction-table>: Deleted.
9528
e6c3da20
EZ
95292011-04-23 Eli Zaretskii <eliz@gnu.org>
9530
9531 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9532 * doprnt.c: Include limits.h.
9533 (SIZE_MAX): New macro.
04f2d78b
CB
9534 (doprnt): Return a size_t value. 2nd arg is now size_t.
9535 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9536 Improve overflow protection. Support `l' modifier for integer
9537 conversions. Support %l conversion. Don't assume an EMACS_INT
9538 argument for integer conversions and for %c.
9539
9540 * lisp.h (doprnt): Restore prototype.
9541
9542 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9543 $(SRC)/character.h.
9544
9545 * Makefile.in (base_obj): Add back doprnt.o.
9546
9547 * deps.mk (doprnt.o): Add back prerequisites.
9548 (callint.o): Depend on character.h.
9549
9550 * eval.c (internal_lisp_condition_case): Include the handler
9551 representation in the error message.
9552 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9553 when breaking from the loop.
9554
9555 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9556
9557 * callint.c (Fcall_interactively): When displaying error message
9558 about invalid control letter, pass the character's codepoint, not
9559 a pointer to its multibyte form. Improve display of the character
9560 in octal and display also its hex code.
9561
9562 * character.c (char_string): Use %x to display the (unsigned)
9563 codepoint of an invalid character, to avoid displaying a bogus
9564 negative value.
9565
9566 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9567 `error', not SYMBOL_NAME itself.
9568
9569 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9570 character arguments to `error'.
9571
9572 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9573 to `error' in error message about FINAL_CHAR argument. Make sure
9574 FINAL_CHAR is a character, and use %c when it is passed as
9575 argument to `error'.
9576
4ffd0d6b 95772011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9578
9579 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9580
9581 * w32.c: Include <time.h>.
9582 (sys_localtime): New function.
9583
4ffd0d6b 95842011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9585
9586 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9587
4ffd0d6b 9588 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9589
4ffd0d6b 95902011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9591
4ffd0d6b
GM
9592 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9593 zombies (Bug#8467).
aac0c6e3 9594
04c56954
EZ
95952011-04-19 Eli Zaretskii <eliz@gnu.org>
9596
9597 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9598 gl_state.e_property when gl_state.object is Qt.
9599
9600 * insdel.c (make_gap_larger): Remove limitation of buffer size
9601 to <= INT_MAX.
9602
16a43933
CY
96032011-04-18 Chong Yidong <cyd@stupidchicken.com>
9604
9605 * xdisp.c (lookup_glyphless_char_display)
9606 (produce_glyphless_glyph): Handle cons cell entry in
9607 glyphless-char-display.
9608 (Vglyphless_char_display): Document it.
9609
9610 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9611 glyphless-char-display.
9612
4581706e
CY
96132011-04-17 Chong Yidong <cyd@stupidchicken.com>
9614
9615 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9616
9617 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9618
9619 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9620 definition for no-X builds.
9621
4887c6e2 96222011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9623
fd35b6f9
PE
9624 Static checks with GCC 4.6.0 and non-default toolkits.
9625
5c1ccb01
PE
9626 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9627
006c5daa
PE
9628 * process.c (keyboard_bit_set): Define only if SIGIO.
9629 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9630 (send_process): Repair possible setjmp clobbering.
9631
efc736d3
PE
9632 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9633
4e2fe2e6
PE
9634 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9635
f97334a2
PE
9636 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9637
4e75f29d
PE
9638 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9639 Define only if needed.
9640
90efadd1
PE
9641 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9642 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9643 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9644
3c647824
PE
9645 * dispextern.h (struct redisplay_interface): Rename param
9646 to avoid shadowing.
e264f262 9647 * termhooks.h (struct terminal): Likewise.
761383f4 9648 * xterm.c (xembed_send_message): Likewise.
3c647824 9649
b58c5c4a
PE
9650 * insdel.c (make_gap_smaller): Define only if
9651 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9652
cad59032
PE
9653 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9654 it.
9655
c339dc2e
PE
9656 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9657 so that we aren't warned about unused symbols.
9658
91a3e27b
PE
9659 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9660
399c71d3 9661 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9662
8ffc96f5
PE
9663 * xfns.c (x_real_positions): Mark locals as initialized.
9664
eef9bc79
PE
9665 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9666
098db9dd
PE
9667 * xterm.c: Fix problems found by static analysis with other toolkits.
9668 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9669 (x_dispatch_event): Declare static if USE_GTK, and
9670 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9671 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9672 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9673 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9674 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9675
eb18f6cc
PE
9676 * xmenu.c (menu_help_callback): Pointer type fixes.
9677 Use const pointers when pointing at readonly data. Avoid pointer
9678 signedness clashes.
9679 (FALSE): Remove unused macro.
9680 (update_frame_menubar): Remove unused decl.
9681
1fe72bf8
PE
9682 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9683
60d9e1db
PE
9684 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9685 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9686 (single_menu_item): Rename local to avoid shadowing.
9687
39261c26
PE
9688 * keyboard.c (make_lispy_event): Remove unused local var.
9689
018c5e19
PE
9690 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9691 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9692
63d2b86e
PE
9693 * bitmaps: Change bitmaps from unsigned char back to the X11
9694 compatible char. Avoid the old compiler warnings about
9695 out-of-range initializers by using, for example, '\xab' rather
9696 than 0xab.
9697
aefd87e1
PE
9698 * xgselect.c (xgselect_initialize): Check vs interface
9699 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9700
bf501fb9
PE
9701 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9702
e9829fdf
PE
9703 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9704 to read-only memory.
9705
1086c095
PE
9706 * fns.c (vector): Remove; this old hack is no longer needed.
9707
2baccd04 9708 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9709 Remove unused var.
dde42981 9710 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9711
72391843 9712 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9713
436c16df 9714 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9715 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9716 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9717
92bb796d 9718 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9719 (x_term_init): Remove local to avoid shadowing.
92bb796d 9720
764430a3 9721 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9722
9723 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9724 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9725
d1dfb56c
EZ
97262011-04-16 Eli Zaretskii <eliz@gnu.org>
9727
c4354cb4
EZ
9728 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9729
d1dfb56c
EZ
9730 Fix regex.c, syntax.c and friends for buffers > 2GB.
9731 * syntax.h (struct gl_state_s): Declare character position members
9732 EMACS_INT.
9733
9734 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9735
04f2d78b
CB
9736 * textprop.c (verify_interval_modification, interval_of):
9737 Declare arguments EMACS_INT.
d1dfb56c
EZ
9738
9739 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9740 EMACS_INT.
9741
9742 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9743
9744 * indent.c (Fvertical_motion): Local variable it_start is now
9745 EMACS_INT.
9746
9747 * regex.c (re_match, re_match_2, re_match_2_internal)
9748 (bcmp_translate, regcomp, regexec, print_double_string)
9749 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9750 (re_compile_pattern, re_exec): Declare arguments and local
9751 variables `size_t' and `ssize_t' and return values `regoff_t', as
9752 appropriate.
9753 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9754 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9755 <compile_stack_type>: `size' and `avail' are now `size_t'.
9756
9757 * regex.h <regoff_t>: Use ssize_t, not int.
9758 (re_search, re_search_2, re_match, re_match_2): Arguments that
9759 specify buffer/string position and length are now ssize_t and
9760 size_t. Return type is regoff_t.
9761
613052cd
BK
97622011-04-16 Ben Key <bkey76@gmail.com>
9763
9764 * nsfont.m: Fixed bugs in ns_get_family and
9765 ns_descriptor_to_entity that were caused by using free to
9766 deallocate memory blocks that were allocated by xmalloc (via
9767 xstrdup). This caused Emacs to crash when compiled with
9768 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9769 --enable-checking=xmallocoverrun). xfree is now used to
9770 deallocate these memory blocks.
9771
4170f62f 97722011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9773
71b41406
PE
9774 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9775
9587a89d
PE
9776 emacs_write: Accept and return EMACS_INT for sizes.
9777 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9778 et seq.
9779 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9780 Accept and return EMACS_INT.
9781 (emacs_gnutls_write): Return the number of bytes written on
9782 partial writes.
9783 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9784 (emacs_read, emacs_write): Remove check for negative size, as the
9785 Emacs source code has been audited now.
9587a89d
PE
9786 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9787 (emacs_read, emacs_write): Use it.
273a5f82
PE
9788 * process.c (send_process): Adjust to the new signatures of
9789 emacs_write and emacs_gnutls_write. Do not attempt to store
9790 a byte offset into an 'int'; it might overflow.
9587a89d 9791 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9792
3e047f51
PE
9793 * sound.c: Don't assume sizes fit in 'int'.
9794 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9795 Return EMACS_INT, not int.
3e047f51 9796 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9797 Accept EMACS_INT, not int.
9798 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9799 record read return values.
9800
cc39a9db
BK
98012011-04-15 Ben Key <bkey76@gmail.com>
9802
c9d0ec6d
JB
9803 * keyboard.c (Qundefined): Don't declare static since it is used
9804 in nsfns.m.
9805 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9806 static since they are used in nsfont.m.
cc39a9db 9807
6c60eb9f
SM
98082011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9809
9810 * process.c (Qprocessp): Don't declare static.
9811 * lisp.h (Qprocessp): Declare again.
9812
7990b61a
JB
98132011-04-15 Juanma Barranquero <lekktu@gmail.com>
9814
9815 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9816
5d4cb038
PE
98172011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9818
8bd7b830 9819 Improve C-level modularity by making more things 'static'.
cd64ea1d 9820
e3b27b31
PE
9821 Don't publish debugger-only interfaces to other modules.
9822 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9823 (verify_bytepos, count_markers): Move decls to the only modules
9824 that need them.
9825 * region-cache.h (pp_cache): Likewise.
9826 * window.h (check_all_windows): Likewise.
9827 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9828
5d4cb038
PE
9829 * sysdep.c (croak): Now static, if
9830 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9831 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9832
9833 * alloc.c (refill_memory_reserve): Now static if
9834 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9835 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9836
e87b6180
PE
9837 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9838 Define only if USE_LUCID.
9839
ac64929e
PE
9840 * xrdb.c (x_customization_string, x_rm_string): Now static.
9841
6f37259d
PE
9842 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9843 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9844
1683e3ab
PE
9845 * xdisp.c (draw_row_with_mouse_face): Now static.
9846 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9847
de9c2632
PE
9848 * window.h (check_all_windows): Mark externally visible.
9849
2b96acb7
PE
9850 * window.c (window_deletion_count): Now static.
9851
9852 * undo.c: Make symbols static if they're not exported.
9853 (last_undo_buffer, last_boundary_position, pending_boundary):
9854 Now static.
9855
50436f33
PE
9856 * textprop.c (interval_insert_behind_hooks): Now static.
9857 (interval_insert_in_front_hooks): Likewise.
9858
64520e5c
PE
9859 * term.c: Make symbols static if they're not exported.
9860 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9861 (max_frame_lines, tty_set_terminal_modes):
9862 (tty_reset_terminal_modes, tty_turn_off_highlight):
9863 (get_tty_terminal): Now static.
9864 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9865 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9866 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9867 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9868 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9869
1fa53021
PE
9870 * sysdep.c: Make symbols static if they're not exported.
9871 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9872 Now static.
9873 (sigprocmask_set, full_mask): Remove; unused.
9874 (wait_debugging): Mark as visible.
9875 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9876 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9877
d4b43b22
PE
9878 * syntax.c (syntax_temp): Define only if !__GNUC__.
9879
b7c513d0
PE
9880 * sound.c (current_sound_device, current_sound): Now static.
9881
989b29ad
PE
9882 * search.c (searchbufs, searchbuf_head): Now static.
9883
13a55a78
PE
9884 * scroll.c (scroll_cost): Remove; unused.
9885 * dispextern.h (scroll_cost): Remove decl.
9886
de68a1fc
PE
9887 * region-cache.h (pp_cache): Mark as externally visible.
9888
40ccffa6
PE
9889 * process.c: Make symbols static if they're not exported.
9890 (process_tick, update_tick, create_process, chan_process):
9891 (Vprocess_alist, proc_buffered_char, datagram_access):
9892 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9893 (deactivate_process): Mark defn as static, as well as decl.
9894 * lisp.h (create_process): Remove decl.
9895 * process.h (chan_process, Vprocess_alist): Remove decls.
9896
ad64fc97
PE
9897 * print.c: Make symbols static if they're not exported.
9898 (print_depth, new_backquote_output, being_printed, print_buffer):
9899 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9900 (print_interval, print_number_index, initial_stderr_stream):
9901 Now static.
9902 * lisp.h (Fprinc): Remove decl.
9903 (debug_output_compilation_hack): Mark as externally visible.
9904
adddb265
PE
9905 * sysdep.c (croak): Move decl from here to syssignal.h.
9906 * syssignal.h (croak): Put it here, so the API can be checked when
9907 'croak' is called from dissociate_if_controlling_tty.
9908
1717ede2
PE
9909 * minibuf.c: Make symbols static if they're not exported.
9910 (minibuf_save_list, choose_minibuf_frame): Now static.
9911 * lisp.h (choose_minibuf_frame): Remove decl.
9912
fa5fb2bc
PE
9913 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9914
1e3890d1
PE
9915 * lread.c: Make symbols static if they're not exported.
9916 (read_objects, initial_obarray, oblookup_last_bucket_number):
9917 Now static.
9918 (make_symbol): Remove; unused.
9919 * lisp.h (initial_obarray, make_symbol): Remove decls.
9920
8a1414fa
PE
9921 * keyboard.c: Make symbols static if they're not exported.
9922 (single_kboard, recent_keys_index, total_keys, recent_keys):
9923 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9924 (this_single_command_key_start, echoing, last_auto_save):
9925 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9926 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9927 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9928 (Vlispy_mouse_stem, double_click_count):
9929 Now static.
9930 (force_auto_save_soon): Define only if SIGDANGER.
9931 (ignore_mouse_drag_p): Now static if
9932 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9933 (print_help): Remove; unused.
9934 (stop_character, last_timer_event): Mark as externally visible.
9935 * keyboard.h (ignore_mouse_drag_p): Declare only if
9936 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9937 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9938 * lisp.h (echoing): Remove decl.
9939 (force_auto_save_soon): Declare only if SIGDANGER.
9940 * xdisp.c (redisplay_window): Simplify code, to make it more
9941 obvious that ignore_mouse_drag_p is not accessed if !defined
9942 USE_GTK && !defined HAVE_NS.
9943
93ea6e8f
PE
9944 * intervals.c: Make symbols static if they're not exported.
9945 (merge_properties_sticky, merge_interval_right, delete_interval):
9946 Now static.
9947 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9948
77382fcc
PE
9949 * insdel.c: Make symbols static if they're not exported.
9950 However, leave prepare_to_modify_buffer alone. It's never
9951 called from outside this function, but that appears to be a bug.
9952 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9953 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9954 (adjust_after_replace_noundo): Remove; unused.
9955 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9956 (signal_before_change): Remove decls.
77382fcc 9957
9306c32e
PE
9958 * indent.c (val_compute_motion, val_vmotion): Now static.
9959
cd44d2eb
PE
9960 * image.c: Make symbols static if they're not exported.
9961 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9962 if USE_GTK.
9963 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9964 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9965
ad9a7a06
PE
9966 * fringe.c (standard_bitmaps): Now static.
9967 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9968
81626931
PE
9969 * frame.c: Make symbols static if they're not exported.
9970 (x_report_frame_params, make_terminal_frame): Now static.
9971 (get_frame_param): Now static, unless HAVE_NS.
9972 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9973 (x_get_resource_string): Remove; not used.
9974 * frame.h (make_terminal_frame, x_report_frame_params):
9975 (x_get_resource_string); Remove decls.
9976 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9977 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9978
239f9db9
PE
9979 * font.c, fontset.c: Make symbols static if they're not exported.
9980 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9981 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9982 * font.c (font_close_object): Now static.
9983 * font.h (font_close_object): Remove.
9984 * fontset.c (FONTSET_OBJLIST): Remove.
9985 (free_realized_fontset) #if-0 the body, which does nothing.
9986 (face_suitable_for_char_p): #if-0, as it's never called.
9987 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9988 * xfaces.c (face_at_string_position):
9989 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9990 since 0 is always ASCII.
9991
dfcf3579
PE
9992 * fns.c (weak_hash_tables): Now static.
9993
5045092b
PE
9994 * fileio.c: Make symbols static if they're not exported.
9995 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9996 (Vwrite_region_annotation_buffers): Now static.
9997
57a96f5c
PE
9998 * eval.c: Make symbols static if they're not exported.
9999 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10000 * lisp.h (backtrace_list): Remove decl.
10001
35f08c38
PE
10002 * emacs.c: Make symbols static if they're not exported.
10003 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10004 (fatal_error_code, fatal_error_signal_hook, standard_args):
10005 Now static.
10006 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10007 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10008 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10009 * lisp.h (fatal_error_signal_hook): Remove decl.
10010 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10011
f44bd759
PE
10012 * editfns.c: Move a (normally-unused) function to its only use.
10013 * editfns.c, lisp.h (get_operating_system_release): Remove.
10014 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10015 worth the hassle of breaking this out.
10016
b532497d
PE
10017 * xterm.c: Make symbols static if they're not exported.
10018 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10019 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10020 (x_destroy_window, x_delete_display):
10021 Now static.
10022 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10023 (x_mouse_leave): Remove; unused.
10024 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10025 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10026 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10027 Remove decls.
10028 (x_mouse_leave): Declare only if WINDOWSNT.
10029 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10030 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10031 USE_X_TOOLKIT.
10032
1675728f
PE
10033 * ftxfont.c: Make symbols static if they're not exported.
10034 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10035 HAVE_FREETYPE.
10036 * font.h (ftxfont_driver): Likewise.
10037
e4cebfca
PE
10038 * xfns.c: Make symbols static if they're not exported.
10039 (x_last_font_name, x_display_info_for_name):
10040 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10041 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10042 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10043 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10044 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10045 (last_show_tip_args): Now static.
10046 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10047 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10048 (x_screen_planes): Remove; unused.
10049 * dispextern.h (x_screen_planes): Remove decl.
10050
5bf46f05
PE
10051 * dispnew.c: Make symbols static if they're not exported.
10052 * dispextern.h (redraw_garbaged_frames, scrolling):
10053 (increment_row_positions): Remove.
10054 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10055 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10056 Now static.
10057 (redraw_garbaged_frames): Remove; unused.
10058
435f4c28
PE
10059 * xfaces.c: Make symbols static if they're not exported.
10060 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10061 Remove decls.
10062 * xterm.h (defined_color): Remove decls.
10063 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10064 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10065 (menu_face_changed_default, defined_color, free_realized_face):
10066 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10067 (ascii_face_of_lisp_face): Remove; unused.
10068
8524aef3
PE
10069 * xdisp.c: Make symbols static if they're not exported.
10070 * dispextern.h (scratch_glyph_row, window_box_edges):
10071 (glyph_to_pixel_coords, set_cursor_from_row):
10072 (get_next_display_element, set_iterator_to_next):
10073 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10074 (show_mouse_face): Remove decls
10075 * frame.h (message_buf_print): Likewise.
10076 * lisp.h (pop_message, set_message, check_point_in_composition):
10077 Likewise.
10078 * xterm.h (set_vertical_scroll_bar): Likewise.
10079 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10080 (message_buf_print, scratch_glyph_row, displayed_buffer):
10081 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10082 (get_next_display_element, show_mouse_face, window_box_edges):
10083 (frame_to_window_pixel_xy, check_point_in_composition):
10084 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10085 (glyph_to_pixel_coords): Remove; unused.
10086
16390cd2
PE
10087 * dired.c (file_name_completion): Now static.
10088
10089 * dbusbind.c (xd_in_read_queued_messages): Now static.
10090
a25f4dfa
PE
10091 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10092 * data.c (circular_list_error): Remove.
10093
14a9c8df
PE
10094 * commands.h (last_point_position, last_point_position_buffer):
10095 (last_point_position_window): Remove decls.
10096 * keyboard.c: Make these variables static.
10097
04f2d78b
CB
10098 * coding.h (coding, code_convert_region, encode_coding_gap):
10099 Remove decls.
74ab6df5
PE
10100 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10101 (iso_code_class, detect_coding, code_convert_region): Now static.
10102 (encode_coding_gap): Remove; unused.
10103
38dfbee1
PE
10104 * chartab.c (chartab_chars, chartab_bits): Now static.
10105
a2cb4e63
PE
10106 * charset.h (charset_iso_8859_1): Remove decl.
10107 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10108 Now static.
10109
127198fd
PE
10110 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10111 * ccl.c (Vccl_program_table): Now static.
10112 (check_ccl_update): Remove; unused.
10113
d85b608f
PE
10114 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10115 * category.h: ... from here.
10116 * category.c (check_category_table, set_category_set): Now static.
10117
31cd66f3
PE
10118 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10119 * lisp.h: Remove these decls.
10120
c358e587
PE
10121 * buffer.c (buffer_count): Remove unused var.
10122
e78aecca
PE
10123 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10124 so that it's not optimized away.
10125 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10126 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10127 exported only to the debugger.
10128
e192d7d3 10129 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10130 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10131
92470028
PE
10132 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10133 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10134 was inaccessible from Lisp.
10135 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10136 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10137
244ed907
PE
10138 alloc.c: Import and export fewer symbols, and remove unused items.
10139 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10140 is defined.
10141 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10142 it's not optimized away by whole-program optimization.
10143 (message_enable_multibyte, free_misc): Remove.
10144 (catchlist, handlerlist, mark_backtrace):
10145 Declare only if BYTE_MARK_STACK.
10146 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10147 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10148 (message_enable_multibyte): Remove decl.
10149 (free_misc, interval_free_list, float_block, float_block_index):
10150 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10151 (cons_free_list, last_marked_index):
10152 Now static.
10153 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10154 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10155 (mark_backtrace): Define only if BYTE_MARK_STACK.
10156 * xdisp.c (message_enable_multibyte): Now static.
10157
61c2b50e 10158 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10159 This makes it easier for human readers (and static analyzers)
10160 to see whether these variables are used from other modules.
10161 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10162 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10163 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10164 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10165 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10166 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10167 * xmenu.c, xselect.c:
10168 Declare Q* vars static if they are not used in other modules.
10169 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10170 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10171 Remove decls of unexported vars.
10172 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10173
95c82688
PE
10174 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10175
16a97296
PE
10176 Make Emacs functions such as Fatom 'static' by default.
10177 This makes it easier for human readers (and static analyzers)
10178 to see whether these functions can be called from other modules.
10179 DEFUN now defines a static function. To make the function external
10180 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10181 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10182 (Finit_image_library):
16a97296
PE
10183 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10184 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10185 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10186 Remove decls, since these functions are now static.
10187 (Funintern, Fget_internal_run_time): New decls, since these functions
10188 were already external.
95c82688 10189
16a97296
PE
10190 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10191 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10192 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10193 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10194 * keyboard.c, keymap.c, lread.c:
10195 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10196 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10197 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10198 Mark functions with DEFUE instead of DEFUN,
10199 if they are used in other modules.
10200 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10201 decls for now-static functions.
10202 * buffer.h (Fdelete_overlay): Remove decl.
10203 * callproc.c (Fgetenv_internal): Mark as internal.
10204 * composite.c (Fremove_list_of_text_properties): Remove decl.
10205 (Fcomposition_get_gstring): New forward static decl.
10206 * composite.h (Fcomposite_get_gstring): Remove decl.
10207 * dired.c (Ffile_attributes): New forward static decl.
10208 * doc.c (Fdocumntation_property): New forward static decl.
10209 * eval.c (Ffetch_bytecode): New forward static decl.
10210 (Funintern): Remove extern decl; now in .h file where it belongs.
10211 * fileio.c (Fmake_symbolic_link): New forward static decl.
10212 * image.c (Finit_image_library): New forward static decl.
10213 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10214 * intervals.h (Fprevious_property_change):
10215 (Fremove_list_of_text_properties): Remove decls.
10216 * keyboard.c (Fthis_command_keys): Remove decl.
10217 (Fcommand_execute): New forward static decl.
10218 * keymap.c (Flookup_key): New forward static decl.
10219 (Fcopy_keymap): Now static.
10220 * keymap.h (Flookup_key): Remove decl.
10221 * process.c (Fget_process): New forward static decl.
10222 (Fprocess_datagram_address): Mark as internal.
10223 * syntax.c (Fsyntax_table_p): New forward static decl.
10224 (skip_chars): Remove duplicate decl.
10225 * textprop.c (Fprevious_property_change): New forward static decl.
10226 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10227 Now internal.
10228 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10229 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10230
785bbd42
PE
10231 * editfns.c (Fformat): Remove unreachable code.
10232
8b913b57
AS
102332011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10234
10235 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10236 change. (Bug#8496)
10237
a6744a35
EZ
102382011-04-13 Eli Zaretskii <eliz@gnu.org>
10239
10240 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10241 when at ZV. (Bug#8487)
10242
e7974947
AS
102432011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10244
baad03f0
AS
10245 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10246 (Bug#8437)
10247 * keyboard.c (parse_tool_bar_item): Likewise.
10248 * sound.c (sound_cleanup, alsa_close): Likewise.
10249 * termcap.c (tgetent): Likewise.
10250 * xfns.c (x_default_font_parameter): Likewise.
10251 * xsettings.c (read_and_apply_settings): Likewise.
10252
e7974947
AS
10253 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10254 (overrun_check_free): Protoize.
10255
28272684
PE
102562011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10257
10258 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10259 since callers should never pass a negative size.
10260 Change the signature to match that of plain 'read' and 'write'; see
10261 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10262 * lisp.h: Update prototypes of emacs_write and emacs_read.
10263
11997c76
EZ
102642011-04-11 Eli Zaretskii <eliz@gnu.org>
10265
10266 * xdisp.c (redisplay_window): Don't try to determine the character
10267 position of the scroll margin if the window start point w->startp
e896f03c 10268 is outside the buffer's accessible region. (Bug#8468)
11997c76 10269
8a2cbd72
EZ
102702011-04-10 Eli Zaretskii <eliz@gnu.org>
10271
10272 Fix write-region and its subroutines for buffers > 2GB.
10273 * fileio.c (a_write, e_write): Modify declaration of arguments and
10274 local variables to support buffers larger than 2GB.
10275 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10276
10277 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10278 argument, local variables, and return value.
10279
10280 * lisp.h: Update prototypes of emacs_write and emacs_read.
10281
10282 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10283
4073e537 102842011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10285
1ebfdcb6
PE
10286 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10287
b2ded58d
PE
10288 Fix more problems found by GCC 4.6.0's static checks.
10289
7d66342c
PE
10290 * xdisp.c (vmessage): Use a better test for character truncation.
10291
bbf47d44
PE
10292 * charset.c (load_charset_map): <, not <=, for optimization,
10293 and to avoid potential problems with integer overflow.
9248994d 10294 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10295 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10296 * editfns.c (Fformat): Likewise.
1e69125e 10297 * syntax.c (skip_chars): Likewise.
3befa583 10298
e3019616
PE
10299 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10300 This also lets GCC 4.6.0 generate slightly better loop code.
10301
becfa255
PE
10302 * callint.c (Fcall_interactively): <, not <=, for optimization.
10303 (Fcall_interactively): Count the number of arguments produced,
10304 not the number of arguments given. This is simpler and lets GCC
10305 4.6.0 generate slightly better code.
10306
dae0cd48
PE
10307 * ftfont.c: Distingish more carefully between FcChar8 and char.
10308 The previous code passed unsigned char * to a functions like
10309 strlen and xstrcasecmp that expect char *, which does not
10310 conform to the C standard.
10311 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10312 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10313 char * when the C standard requires it.
10314
76032d70
PE
10315 * keyboard.c (read_char): Remove unused var.
10316
eb3f1cc8
PE
10317 * eval.c: Port to Windows vsnprintf (Bug#8435).
10318 Include <limits.h>.
10319 (SIZE_MAX): Define if the headers do not.
10320 (verror): Do not give up if vsnprintf returns a negative count.
10321 Instead, grow the buffer. This ports to Windows vsnprintf, which
10322 does not conform to C99. Problem reported by Eli Zaretskii.
10323 Also, simplify the allocation scheme, by avoiding the need for
10324 calling realloc, and removing the ALLOCATED variable.
10325
70476b54
PE
10326 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10327
12020a9e
PE
10328 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10329 But keep the doprint source code for now, as we might revamp it
10330 and use it again (Bug#8435).
ea6c7ae6
PE
10331 * lisp.h (doprnt): Remove.
10332 * Makefile.in (base_obj): Remove doprnt.o.
10333 * deps.mk (doprnt.o): Remove.
10334
5fdb398c
PE
10335 error: Print 32- and 64-bit integers portably (Bug#8435).
10336 Without this change, on typical 64-bit hosts error ("...%d...", N)
10337 was used to print both 32- and 64-bit integers N, which relied on
10338 undefined behavior.
61bdb816 10339 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10340 * lisp.h (error, verror): Mark as printf-like functions.
10341 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10342 Report overflow in size calculations when allocating printf buffer.
10343 Do not truncate output string at its first null byte.
10344 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10345 Truncate the output at a character boundary, since vsnprintf does not
10346 do that.
10347 * charset.c (check_iso_charset_parameter): Convert internal
10348 character to string before calling 'error', since %c now has the
10349 printf meaning.
10350 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10351 overflow when computing char to be passed to 'error'. Do not
10352 pass Lisp_Object to 'error'; pass the integer instead.
10353 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10354 formatted with plain %d.
10355
b189fa66
PE
10356 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10357
bff87ef0
PE
10358 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10359
7e2cac20
PE
10360 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10361
ce4d90b5
PE
10362 * xterm.c (x_catch_errors): Remove duplicate declaration.
10363
266c9547
PE
10364 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10365
79c49ad2
PE
10366 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10367
368f4090
JM
103682011-04-10 Jim Meyering <meyering@redhat.com>
10369
10370 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10371 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10372 return ssize_t not "int", and use size_t as the buffer length.
10373 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10374 * gnutls.h: Update declarations.
10375 * process.c (read_process_output): Use ssize_t, to match.
10376 (send_process): Likewise.
10377
a32d4040
CY
103782011-04-09 Chong Yidong <cyd@stupidchicken.com>
10379
10380 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10381
8546720e 103822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10383
04f2d78b
CB
10384 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10385 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10386
8546720e
GM
10387 * xterm.c (handle_one_xevent):
10388 * xmenu.c (create_and_show_popup_menu):
10389 * xselect.c (x_decline_selection_request)
10390 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10391
0a2f5c1a 103922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10393
10394 Fix some uses of `int' instead of EMACS_INT.
10395 * search.c (string_match_1, fast_string_match)
10396 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10397 (scan_buffer, find_next_newline_no_quit)
10398 (find_before_next_newline, search_command, Freplace_match)
10399 (Fmatch_data): Make some `int' variables be EMACS_INT.
10400
10401 * xdisp.c (display_count_lines): 3rd argument and return value now
10402 EMACS_INT. All callers changed.
10403 (pint2hrstr): Last argument is now EMACS_INT.
10404
10405 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10406 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10407 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10408 (decode_coding_utf_16, decode_coding_emacs_mule)
10409 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10410 (decode_coding_ccl, decode_coding_charset)
10411 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10412 (decode_coding_iso_2022, decode_coding_emacs_mule)
10413 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10414 <char_offset, last_offset>: Declare EMACS_INT.
10415 (encode_coding_utf_8, encode_coding_utf_16)
10416 (encode_coding_emacs_mule, encode_invocation_designation)
10417 (encode_designation_at_bol, encode_coding_iso_2022)
10418 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10419 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10420 Declare EMACS_INT.
10421 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10422 (encode_invocation_designation): Last argument P_NCHARS is now
10423 EMACS_INT.
10424 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10425 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10426
10427 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10428 All users changed.
10429
10430 * ccl.c (Fccl_execute_on_string): Declare some variables
10431 EMACS_INT.
10432
8546720e 104332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10434
10435 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10436
4e19a977
CS
104372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10438
10439 * process.c (Fformat_network_address): Doc fix.
10440
87302331
R
104412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10442
ee7683eb 10443 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10444
cbb59342
CY
104452011-04-08 Chong Yidong <cyd@stupidchicken.com>
10446
10447 * keyboard.c (read_char): Call Lisp function help-form-show,
10448 instead of using internal_with_output_to_temp_buffer.
10449 (Qhelp_form_show): New var.
e0d38eeb 10450 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10451
10452 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10453
10454 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10455
e67a13ab
CY
104562011-04-06 Chong Yidong <cyd@stupidchicken.com>
10457
04f2d78b
CB
10458 * process.c (Flist_processes): Remove to Lisp.
10459 (list_processes_1): Delete.
e67a13ab 10460
973f782d
EZ
104612011-04-06 Eli Zaretskii <eliz@gnu.org>
10462
7c106b1e
EZ
10463 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10464
973f782d
EZ
10465 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10466
41cf7d1a 104672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10468
ca23cc88
PE
10469 Fix more problems found by GCC 4.6.0's static checks.
10470
f390e2d5
PE
10471 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10472
42eea0d0
PE
10473 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10474
b69769da 10475 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10476
f9541e84
PE
10477 * xdisp.c (vmessage): Mark as a printf-like function.
10478
13841b55
PE
10479 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10480
c136c10f
PE
10481 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10482
5e2d4a30
PE
10483 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10484 printf-like functions.
10485 (tiff_load): Add casts to remove these marks before passing them
10486 to system-supplied API.
10487
583f48b9
PE
10488 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10489
b25d760e
PE
10490 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10491 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10492 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10493 directly, rather than having caller test rule sign. This avoids
10494 some unnecessary tests.
10495 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10496 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10497 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10498
bc7b6697 10499 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10500 (xfont_open): Avoid unnecessary tests.
bc7b6697 10501
27ccc379
PE
10502 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10503
dcd5c89a
PE
10504 * composite.h, composite.c (composition_gstring_put_cache):
10505 Use EMACS_INT, not int, for length.
10506
b13a45c6
PE
10507 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10508 breaking out part of COMPOSITION_DECODE_RULE.
10509 (COMPOSITION_DECODE_RULE): Use it.
10510 * composite.c (get_composition_id): Remove unused local vars,
10511 by using the new macro.
10512
1e792e4d
PE
10513 * textprop.c (set_text_properties_1): Change while to do-while,
10514 since the condition is always true at first.
10515
dc6c6455 10516 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10517 (interval_deletion_adjustment): Return unsigned value.
10518 All uses changed.
dc6c6455 10519
aba7731a
PE
10520 * process.c (list_processes_1, create_pty, read_process_output):
10521 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10522 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10523 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10524 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10525 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10526
fdfc4bf3
PE
10527 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10528
fca8fe46 10529 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10530 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10531
06a0259a 10532 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10533 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10534 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10535
e7b9e80f
PE
10536 * print.c (print_error_message): Avoid int overflow.
10537
56201685
PE
10538 * font.c (font_list_entities): Redo for clarity,
10539 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10540
78834453 10541 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10542 (font_score): Avoid potential overflow in diff calculation.
78834453 10543
0bc0b309 10544 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10545 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10546
e610eaca
PE
10547 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10548
b895abce
PE
10549 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10550 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10551 can always succeed if overflow has undefined behavior.
10552
1f1d9321 10553 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10554 (wordify): Omit three unnecessary tests.
1f1d9321 10555
c59478bc
PE
10556 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10557 All callers changed. This avoids the need for an unused var.
10558
79b73827
PE
10559 * casefiddle.c (casify_region): Remove var that is set but not used.
10560
a4db5dfe
PE
10561 * dired.c (file_name_completion): Remove var that is set but not used.
10562
43aae36e
PE
10563 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10564
2a47c44d 10565 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10566 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10567
a37c69bf
PE
10568 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10569 Check for integer overflow on size calculations.
10570
328ab8e7
PE
10571 * buffer.c (Fprevious_overlay_change): Remove var that is set
10572 but not used.
10573
e5a2a5cb
PE
10574 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10575 Remove vars that are set but not used.
8d84a6eb 10576 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10577 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10578
a60e5f68
PE
10579 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10580
f661cb61 10581 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10582 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10583
f0397f5a
PE
10584 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10585 that are set but not used.
10586
8664db06 10587 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10588 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10589
6abdaa4a
PE
10590 * xselect.c (x_get_local_selection, x_handle_property_notify):
10591 Remove vars that are set but not used.
10592
0ce7538d 10593 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10594 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10595
9ae848fc
PE
10596 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10597 Remove var that is set but not used.
0b918413
PE
10598 (scroll_bar_windows_size): Now size_t, not int.
10599 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10600 Check for overflow.
9ae848fc 10601
a5a62657
PE
10602 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10603 (map_tty_color) [!defined MSDOS]: Likewise.
10604
5c5cdd39
PE
10605 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10606
66ebf983
PE
10607 * coding.c: Remove vars that are set but not used.
10608 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10609 All callers changed.
10610 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10611 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10612 (decode_coding_charset): Remove vars that are set but not used.
10613
1be4d761
PE
10614 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10615 that is set but not used.
10616
47553fa8
PE
10617 * print.c (print_object): Remove var that is set but not used.
10618
1f7196bf 10619 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10620 The gnulib version avoids calling malloc in the usual case,
10621 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10622 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10623 * filelock.c (current_lock_owner): Likewise.
10624 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10625 * sysdep.c: Include allocator.h, careadlinkat.h.
10626 (emacs_no_realloc_allocator): New static constant.
10627 (emacs_readlink): New function.
fdb61804
PE
10628 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10629 ../lib/careadlinkat.h.
d1fdcab7 10630
f84c17c7
SM
106312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10632
10633 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10634 first non-nil return value).
10635
ef3862ad
JD
106362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10637
10638 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10639 if not defined (Bug#8403).
10640
376a7006
JB
106412011-04-02 Juanma Barranquero <lekktu@gmail.com>
10642
10643 * xdisp.c (display_count_lines): Remove parameter `start',
10644 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10645 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10646 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10647 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10648 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10649 and thereabouts. All callers changed.
10650 (get_per_char_metric): Remove parameter `f', unused since
10651 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10652
6ca3801d
JM
106532011-04-02 Jim Meyering <meyering@redhat.com>
10654
10655 do not dereference NULL upon failed strdup
10656 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10657 (ns_get_family): Likewise.
10658
d8e2b5ba
JB
106592011-04-02 Juanma Barranquero <lekktu@gmail.com>
10660
10661 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10662
8c74fcbd
JD
106632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10664
10665 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10666 later (Bug#8403).
10667
7200d79c
SM
106682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10669
03408648 10670 Add lexical binding.
7200d79c 10671
03408648
SM
10672 * window.c (Ftemp_output_buffer_show): New fun.
10673 (Fsave_window_excursion):
10674 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10675
10676 * lread.c (lisp_file_lexically_bound_p): New function.
10677 (Fload): Bind Qlexical_binding.
10678 (readevalloop): Remove `evalfun' arg.
10679 Bind Qinternal_interpreter_environment.
10680 (Feval_buffer): Bind Qlexical_binding.
10681 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10682 Mark as dynamic.
10683 (syms_of_lread): Declare `lexical-binding'.
10684
10685 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10686
10687 * keyboard.c (eval_dyn): New fun.
10688 (menu_item_eval_property): Use it.
ca105506
SM
10689
10690 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10691
03408648
SM
10692 * fns.c (concat, mapcar1): Accept byte-code-functions.
10693
10694 * eval.c (Fsetq): Handle lexical vars.
10695 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10696 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10697 (FletX, Flet): Obey lexical binding.
10698 (Fcommandp): Handle closures.
10699 (Feval): New `lexical' arg.
10700 (eval_sub): New function extracted from Feval. Use it almost
10701 everywhere where Feval was used. Look up vars in lexical env.
10702 Handle closures.
10703 (Ffunctionp): Move from subr.el.
10704 (Ffuncall): Handle closures.
10705 (apply_lambda): Remove `eval_flags'.
10706 (funcall_lambda): Handle closures and new byte-code-functions.
10707 (Fspecial_variable_p): New function.
10708 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10709 but without exporting it to Lisp.
23aba0ea 10710
23aba0ea 10711 * doc.c (Fdocumentation, store_function_docstring):
03408648 10712 * data.c (Finteractive_form): Handle closures.
23aba0ea 10713
03408648
SM
10714 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10715 interactive spec.
ba83908c 10716
04f2d78b
CB
10717 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10718 New byte-codes.
03408648
SM
10719 (exec_byte_code): New function extracted from Fbyte_code to handle new
10720 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10721
03408648 10722 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10723
03408648 10724 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10725
e2abce01
JB
107262011-03-31 Juanma Barranquero <lekktu@gmail.com>
10727
10728 * xdisp.c (redisplay_internal): Fix prototype.
10729
63696a73 107302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10731
63696a73 10732 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10733 (try_scrolling): Use it when setting scroll_limit.
10734 Limit scrolling to 100 screen lines.
63696a73
EZ
10735 (redisplay_window): Even when falling back on "recentering",
10736 position point in the window according to scroll-conservatively,
10737 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10738
10739 (try_scrolling): When point is above the window, allow searching
10740 as far as scroll_max, or one screenful, to compute vertical
10741 distance from PT to the scroll margin position. This prevents
10742 try_scrolling from unnecessarily failing when
10743 scroll-conservatively is set to a value slightly larger than the
10744 window height. Clean up the case of PT below the margin at bottom
10745 of window: scroll_max can no longer be INT_MAX. When aggressive
10746 scrolling is in use, don't let point enter the opposite scroll
10747 margin as result of the scroll.
10748 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10749 threshold of 100 lines for never-recentering scrolling.
10750
e4cc2dfc
JB
107512011-03-31 Juanma Barranquero <lekktu@gmail.com>
10752
10753 * dispextern.h (move_it_by_lines):
10754 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10755 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10756 (message_log_check_duplicate): Remove parameters `prev_bol' and
10757 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10758 (redisplay_internal): Remove parameter `preserve_echo_area',
10759 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10760
10761 * indent.c (Fvertical_motion):
10762 * window.c (window_scroll_pixel_based, Frecenter):
10763 Don't pass `need_y_p' to `move_it_by_lines'.
10764
1c470562
SM
107652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10766
44f230aa
SM
10767 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10768 steal a few bits to be more compact.
10769 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10770 Remove unneeded casts.
10771
1c470562
SM
10772 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10773
888adce9
ZK
107742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10775
10776 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10777 binding" message (bug#7967).
10778
f838ed7b
PE
107792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10780
77861b95
PE
10781 Fix more problems found by GCC 4.6.0's static checks.
10782
de6dbc14
PE
10783 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10784 Remove unused local var.
10785
f838ed7b
PE
10786 * editfns.c (Fmessage_box): Remove unused local var.
10787
792c7b2b
PE
10788 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10789 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10790 Omit unused local vars.
c499e557 10791 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10792 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10793 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10794 Omit unused local var.
10795
ba0165e1
PE
10796 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10797 Don't assume string length fits in int.
32ad8845 10798 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10799 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10800
3c59b4c9
PE
10801 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10802 instead of alloca (Bug#8344).
10803
a3eed478 10804 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10805 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10806
eb4d412d
PE
10807 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10808
1658b401
PE
10809 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10810 concerns.
10811
10812 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10813
10814 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10815
9a2c6e05
PE
10816 * keyboard.c (syms_of_keyboard): Use the same style as later
10817 in this function when indexing through an array. This also
10818 works around GCC bug 48267.
10819
03d0a109
PE
10820 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10821
44f730c8
PE
10822 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10823
fe75f926
PE
10824 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10825 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10826
ffa8c828
PE
10827 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10828 This avoids undefined behavior on integer overflow, and is a bit
10829 more convenient anyway since it is compared to a size_t variable.
10830
c5101a77
PE
10831 Variadic C functions now count arguments with size_t, not int.
10832 This avoids an unnecessary limitation on 64-bit machines, which
10833 caused (substring ...) to crash on large vectors (Bug#8344).
10834 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10835 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10836 All variadic functions and their callers changed accordingly.
c5101a77
PE
10837 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10838 * data.c (arith_driver, float_arith_driver): Likewise.
10839 * editfns.c (general_insert_function): Likewise.
10840 * eval.c (struct backtrace.nargs, interactive_p)
10841 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10842 (funcall_lambda, mark_backtrace): Likewise.
10843 * fns.c (concat): Likewise.
10844 * frame.c (x_set_frame_parameters): Likewise.
10845 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10846 0 if not found, not -1. All callers changed.
10847
dd3f25f7
PE
10848 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10849 (stack_copy_size): Now size_t, not int.
10850 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10851
461c2ab9
JB
108522011-03-28 Juanma Barranquero <lekktu@gmail.com>
10853
10854 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10855 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10856 All callers changed.
10857
10858 * lisp.h (multibyte_char_to_unibyte):
10859 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10860 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10861 * character.h (CHAR_TO_BYTE8):
10862 * cmds.c (internal_self_insert):
10863 * editfns.c (general_insert_function):
10864 * keymap.c (push_key_description):
10865 * search.c (Freplace_match):
10866 * xdisp.c (message_dolog, set_message_1): All callers changed.
10867
f6d62986
SM
108682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10869
10870 * keyboard.c (safe_run_hook_funcall): New function.
10871 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10872 don't set the hook to nil, but remove the offending function instead.
10873 (Qcommand_hook_internal): Remove, unused.
10874 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10875 Vcommand_hook_internal.
10876
10877 * eval.c (enum run_hooks_condition): Remove.
10878 (funcall_nil, funcall_not): New functions.
10879 (run_hook_with_args): Call each function through a `funcall' argument.
10880 Remove `cond' argument, now redundant.
10881 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10882 (Frun_hook_with_args_until_failure): Adjust accordingly.
10883 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10884
1db5b1ad
JB
108852011-03-28 Juanma Barranquero <lekktu@gmail.com>
10886
10887 * dispextern.h (string_buffer_position): Remove declaration.
10888
10889 * print.c (strout): Remove parameter `multibyte', unused since
10890 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10891
10892 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10893 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10894 All callers changed.
10895
10896 * w32.c (_wsa_errlist): Use braces for struct initializers.
10897
10898 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10899 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10900 All callers changed.
10901 (string_buffer_position): Likewise. Also, make static (it's never
10902 used outside xdisp.c).
10903 (cursor_row_p): Remove parameter `w', unused since
10904 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10905 (decode_mode_spec): Remove parameter `precision', introduced during
10906 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10907 All callers changed.
10908
5ffb62aa
JD
109092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10910
10911 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10912
461c2ab9 109132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10914
10915 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10916 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10917 (ns_update_auto_hide_menu_bar): New functions.
10918 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10919 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10920 ns_constrain_all_frames.
10921 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10922 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10923
5c380ffb
JD
109242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10925
10926 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10927
9af30bdf
GM
109282011-03-27 Glenn Morris <rgm@gnu.org>
10929
10930 * syssignal.h: Replace RETSIGTYPE with void.
10931 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10932 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10933 Replace SIGTYPE with void everywhere.
10934 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10935 * s/template.h (SIGTYPE): Remove commented out definition.
10936
e2abce01
JB
109372011-03-26 Eli Zaretskii <eliz@gnu.org>
10938
10939 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10940 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10941
f868cd8a
JB
109422011-03-26 Juanma Barranquero <lekktu@gmail.com>
10943
59eb0929
JB
10944 * w32.c (read_unc_volume): Use parameter `henum', instead of
10945 global variable `wget_enum_handle'.
10946
10947 * keymap.c (describe_vector): Remove parameters `indices' and
10948 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10949 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10950
f868cd8a
JB
10951 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10952
10953 * keyboard.c (timer_check): Remove parameter `do_it_now',
10954 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10955 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10956 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10957
10958 * keyboard.c (read_char):
10959 * w32menu.c (w32_menu_display_help):
10960 * xmenu.c (show_help_event, menu_help_callback):
10961 Adjust calls to `show_help_echo'.
10962
10963 * gtkutil.c (xg_maybe_add_timer):
10964 * keyboard.c (readable_events):
10965 * process.c (wait_reading_process_output):
10966 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10967
10968 * insdel.c (adjust_markers_gap_motion):
10969 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10970 (gap_left, gap_right): Don't call it.
10971
2ecf6fdb
CY
109722011-03-25 Chong Yidong <cyd@stupidchicken.com>
10973
10974 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10975 incurred during fontification.
10976
6b1f9ba4
JB
109772011-03-25 Juanma Barranquero <lekktu@gmail.com>
10978
10979 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10980 (DEFVAR_PER_BUFFER): Don't pass it.
10981
10982 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10983 (scrolling_window): Don't pass it.
10984
0f4a96b5
JB
109852011-03-25 Juanma Barranquero <lekktu@gmail.com>
10986
10987 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10988
10989 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10990 and `suffix'.
10991 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10992 of variables specific to SELinux and computation of `encoded_absname'.
10993
10994 * image.c (XPutPixel): Remove unused variable `height'.
10995
10996 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10997
10998 * unexw32.c (get_section_info): Remove unused variable `section'.
10999
11000 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11001 (system_process_attributes): Remove unused variable `sess'.
11002 (sys_read): Remove unused variable `err'.
11003
11004 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11005 (w32_wnd_proc): Remove unused variable `isdead'.
11006 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11007 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11008 (x_create_tip_frame): Remove unused variable `tem'.
11009
11010 * w32inevt.c (w32_console_read_socket):
11011 Remove unused variable `no_events'.
11012
11013 * w32term.c (x_draw_composite_glyph_string_foreground):
11014 Remove unused variable `width'.
11015
1149507c
JB
110162011-03-24 Juanma Barranquero <lekktu@gmail.com>
11017
11018 * w32term.c (x_set_glyph_string_clipping):
11019 Don't pass uninitialized region to CombineRgn.
11020
9c88f339
JB
110212011-03-23 Juanma Barranquero <lekktu@gmail.com>
11022
11023 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11024 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11025 (Fx_close_connection): Remove unused variable `i'.
11026
11027 * w32font.c (w32font_draw): Return number of glyphs.
11028 (w32font_open_internal): Remove unused variable `i'.
11029 (w32font_driver): Add missing initializer.
11030
11031 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11032 (fill_in_menu): Remove unused variable `items_added'.
11033
11034 * w32term.c (last_mouse_press_frame): Remove static global variable.
11035 (w32_clip_to_row): Remove unused variable `f'.
11036 (x_delete_terminal): Remove unused variable `i'.
11037
11038 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11039 (NOTHING): Remove unused static global variable.
11040 (uniscribe_check_otf): Remove unused variable `table'.
11041 (uniscribe_font_driver): Add missing initializers.
11042
dee091a3
JD
110432011-03-23 Julien Danjou <julien@danjou.info>
11044
11045 * term.c (Fsuspend_tty, Fresume_tty):
11046 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11047 * window.c (temp_output_buffer_show):
11048 * insdel.c (signal_before_change):
11049 * frame.c (Fhandle_switch_frame):
11050 * fileio.c (Fdo_auto_save):
11051 * emacs.c (Fkill_emacs):
11052 * editfns.c (save_excursion_restore):
11053 * cmds.c (internal_self_insert):
11054 * callint.c (Fcall_interactively):
11055 * buffer.c (Fkill_all_local_variables):
11056 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11057 Use Frun_hooks.
0f4a96b5 11058 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11059 unconditionally since it does the check itself.
dee091a3 11060
2c520ab5 110612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11062
c9c49752
PE
11063 Fix more problems found by GCC 4.5.2's static checks.
11064
8abc3f12
PE
11065 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11066 the first time through the loop, since we know p0 < p1 then.
11067 This also avoids a gcc -Wstrict-overflow warning.
11068
a2d26660
PE
11069 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11070 leading to a memory leak, possible in functions like
11071 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11072 of objects (Bug#8318).
a2d26660 11073
916c72e9
PE
11074 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11075 that could (at least in theory) be that large.
11076
19ab8a18
PE
11077 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11078 This is less likely to overflow, and avoids undefined behavior if
11079 overflow does occur. All callers changed. Use strtoul to scan
11080 for the unsigned long integer.
b7cbbd6f
PE
11081 (pint2hrstr): Simplify and tune code slightly.
11082 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11083
f0641eff
PE
11084 * scroll.c (do_scrolling): Work around GCC bug 48228.
11085 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11086
7f650bb9
PE
11087 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11088 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11089 (validate_x_resource_name): Simplify count usage.
11090 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11091
37dd57d1
PE
11092 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11093 fail (Bug#8306).
81e56e61 11094
699979fc 11095 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11096
401bf9b4
PE
11097 * process.c (Fmake_network_process): Use socklen_t, not int,
11098 where POSIX says socklen_t is required in portable programs.
11099 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11100 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11101 (Fmake_network_process, server_accept_connection):
11102 (wait_reading_process_output, read_process_output):
11103 Likewise.
11104
b93aacde
PE
11105 * process.c: Rename or move locals to avoid shadowing.
11106 (list_processes_1, Fmake_network_process):
11107 (read_process_output_error_handler, exec_sentinel_error_handler):
11108 Rename or move locals.
4dc343ee 11109 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11110 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11111 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11112 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11113 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11114
af8a867c 11115 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11116 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11117 Include tparam.h instead, since it declares them.
af8a867c
PE
11118 * cm.h (PC): Remove extern decl; tparam.h now does this.
11119 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11120 * terminfo.c: Include tparam.h, to check interfaces.
11121 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11122 (tparam): Adjust signature to match interface in tparam.h;
11123 this removes some undefined behavior. Check that outstring and len
11124 are zero, which they always are with Emacs.
11125 * tparam.h (PC, BC, UP): New extern decls.
11126
0248044d 11127 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11128 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11129
8ff096c1 11130 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11131 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11132 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11133 (ftfont_list): Remove unused local.
49eaafba
PE
11134 (get_adstyle_property, ftfont_pattern_entity):
11135 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11136 Rename locals to avoid shadowing.
8ff096c1 11137
e2be39f6
PE
11138 * xfont.c (xfont_list_family): Mark var as initialized.
11139
c9735e30
PE
11140 * xml.c (make_dom): Now static.
11141
8f5201ae
PE
11142 * composite.c (composition_compute_stop_pos): Rename local to
11143 avoid shadowing.
b246f932
PE
11144 (composition_reseat_it): Remove unused locals.
11145 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11146 (composition_update_it): Mark var as initialized.
11b61122
PE
11147 (find_automatic_composition): Mark vars as initialized,
11148 with a FIXME (Bug#8290).
8f5201ae 11149
760fbc2c
PE
11150 character.h: Rename locals to avoid shadowing.
11151 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11152 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11153 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11154 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11155 to avoid shadowing.
11156
ff08eb85
PE
11157 * textprop.c (property_change_between_p): Remove; unused.
11158
fc7bf025
PE
11159 * intervals.c (interval_start_pos): Now static.
11160
235d7abc
PE
11161 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11162
44f230aa
SM
11163 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11164 Rename locals to avoid shadowing.
3e7d6594 11165
50060332
PE
11166 * sound.c (wav_play, au_play, Fplay_sound_internal):
11167 Fix pointer signedness.
d01f234b 11168 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11169 (wav_play): Initialize a variable to 0, to prevent undefined
11170 behavior (Bug#8278).
50060332 11171
c4fc4e30
PE
11172 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11173
918436ed
PE
11174 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11175
c939f91b
PE
11176 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11177 clobbering (Bug#8298).
b9c7f648
PE
11178 * sysdep.c (sys_subshell): Likewise.
11179 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11180
6bd8c144
PE
11181 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11182 This should get cleaned up, so that child_setup has the
11183 same signature on all platforms.
11184
7710357c 11185 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11186 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11187
c59da222
CY
111882011-03-22 Chong Yidong <cyd@stupidchicken.com>
11189
11190 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11191 not to be necessary, and produces flickering.
11192
66b87493
GM
111932011-03-20 Glenn Morris <rgm@gnu.org>
11194
11195 * config.in: Remove file.
11196
45b6f6d5
JB
111972011-03-20 Juanma Barranquero <lekktu@gmail.com>
11198
11199 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11200 are now in src/globals.h.
11201 (syms_of_minibuf): Remove spurious & from previous change.
11202
cd394be1 112032011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11204
11205 * minibuf.c (completing-read-function): New variable.
11206 (completing-read-default): Rename from completing-read.
11207 (completing-read): Call completing-read-function.
11208
b14e3e21
CY
112092011-03-19 Juanma Barranquero <lekktu@gmail.com>
11210
11211 * xfaces.c (Fx_load_color_file):
11212 Read color file from absolute filename (bug#8250).
11213
f2b726e6
JB
112142011-03-19 Juanma Barranquero <lekktu@gmail.com>
11215
11216 * makefile.w32-in: Update dependencies.
11217
09f6ff02
EZ
112182011-03-17 Eli Zaretskii <eliz@gnu.org>
11219
11220 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11221
29a6015a
PE
112222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11223
a3a6c54e
PE
11224 Fix more problems found by GCC 4.5.2's static checks.
11225
b766f867
PE
11226 * process.c (make_serial_process_unwind, send_process_trap):
11227 (sigchld_handler): Now static.
11228
be02381c
PE
11229 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11230 That way, the code declares only the vars that it needs.
11231 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11232 * s/cygwin.h (PTY_ITERATION): Likewise.
11233 * s/darwin.h (PTY_ITERATION): Likewise.
11234 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11235
57048744
PE
11236 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11237 * process.c (allocate_pty): Don't declare stb unless it's needed.
11238
7914961c 11239 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11240 (CONSTANTLIM): Remove; unused.
11241 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11242 Define only if needed.
7914961c 11243
b3967b18
PE
11244 * unexelf.c (unexec): Name an expression,
11245 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11246 Use a different way to cause a compilation error if anyone uses
11247 n rather than nn, a way that does not involve shadowing.
73366a00 11248 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11249
29a6015a
PE
11250 * deps.mk (unexalpha.o): Remove; unused.
11251
43cfc33e 11252 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11253 * unexec.h: New file.
ce701a33
PE
11254 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11255 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11256 Depend on unexec.h.
11257 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11258 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11259 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11260 Change as necessary to match prototype in unexec.h.
ce701a33 11261
01f44d5a
PE
11262 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11263 shadowing.
4f63c6bb 11264 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11265
a6670b0b
PE
11266 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11267 Rename locals to avoid shadowing.
11268
cef2010d 11269 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11270 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11271
d4d7173a
PE
11272 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11273
f08b802a
PE
11274 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11275 warning when compiling print.c.
11276
3ddb0639
PE
11277 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11278 instead of using an uninitialized var.
5ad03b97 11279 (font_sort_entities): Mark var as initialized.
3ddb0639 11280
170a2692
PE
11281 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11282
e663c700
PE
11283 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11284 pointers to constants.
89bc529a 11285 (font_parse_fcname): Remove unused vars.
7b81e2d0 11286 (font_delete_unmatched): Now static.
ea838e10 11287 (font_get_spec): Remove; unused.
13a547c6
PE
11288 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11289 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11290 Rename or move locals to avoid shadowing.
e663c700 11291
2a80c887 11292 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11293 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11294
1384fa33 11295 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11296 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11297
8b2c52e9
PE
11298 * alloc.c (mark_backtrace): Move decl from here ...
11299 * lisp.h: ... to here, so that it can be checked.
11300
475545b5 11301 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11302 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11303 (lisp_indirect_variable): Name an expression,
11304 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11305 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11306
b1349114 11307 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11308 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11309 Use const pointer when appropriate.
b1349114 11310
a2928364
PE
11311 * lisp.h (get_system_name, get_operating_system_release):
11312 Move decls here, to check interfaces.
11313 * process.c (get_operating_system_release): Move decl to lisp.h.
11314 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11315 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11316 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11317 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11318 (Fformat_time_string, Fencode_time, Finsert_char):
11319 (Ftranslate_region_internal, Fformat):
11320 Rename or remove local vars to avoid shadowing.
9710023e 11321 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11322
a415e694
PE
11323 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11324 avoid shadowing.
11325
8ef4622d
PE
11326 * lisp.h (eassert): Check that the argument compiles, even if
11327 ENABLE_CHECKING is not defined.
11328
946f9a5b
PE
11329 * data.c (Findirect_variable): Name an expression, to avoid
11330 gcc -Wbad-function-cast warning.
112396d6 11331 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11332 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11333 (Fmake_variable_buffer_local, Fmake_local_variable):
11334 Mark variables as initialized.
52746918 11335 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11336
e5aab7e7 11337 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11338 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11339 Rename locals to avoid shadowing.
dff45157
PE
11340 (mark_stack): Move local variables into the #ifdef region where
11341 they're used.
7bc26fdb
PE
11342 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11343 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11344 needed otherwise.
11345 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11346 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11347 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11348
e5aab7e7
PE
11349 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11350 avoids undefined behavior in theory.
11351
4da60324
PE
11352 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11353
88043301
PE
11354 Use functions, not macros, for up- and down-casing (Bug#8254).
11355 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11356 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11357 to use the following functions instead of these macros.
11358 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11359 EMACS_INT, since callers assume the returned value fits in int.
11360 (upcase1): Likewise, for UPCASE_TABLE.
11361 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11362 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11363 the race-condition problem in the old DOWNCASE.
88043301 11364
19ed5445
PE
11365 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11366 Rename locals to avoid shadowing.
11367 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11368 (regex_compile, re_search_2, re_match_2_internal):
11369 Remove unused local vars.
952db0d7
PE
11370 (FREE_VAR): Rewrite so as not to use empty "else",
11371 which gcc can warn about.
da053e48 11372 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11373 (RETALLOC_IF): Define only if needed.
11374 (WORDCHAR_P): Likewise. This one is never needed, but is used
11375 only in a comment talking about a compiler bug, so put inside
11376 the #if 0 of that comment.
11377 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11378 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11379 Remove; unused.
19ed5445 11380
1f3561e4 11381 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11382 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11383 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11384
ded6f8f7
PE
11385 * search.c (simple_search): Remove unused var.
11386
dbd37a95
PE
11387 * dired.c (compile_pattern): Move decl from here ...
11388 * lisp.h: ... to here, so that it can be checked.
11389 (struct re_registers): New forward decl.
11390
7e47afad
PE
11391 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11392
85f24f61
PE
11393 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11394 All uses changed.
11395 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11396 Rename locals to avoid shadowing.
5671df8f 11397 (Fvertical_motion): Mark locals as initialized.
85f24f61 11398
181aa2be 11399 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11400 (casify_region): Mark local as initialized.
181aa2be 11401
930d429c
PE
11402 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11403
7082eac6
PE
11404 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11405 New macros, so that the caller can use some names other than
11406 gcpro1, gcpro2, etc.
11407 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11408 of the new macros.
11409 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11410 argument, for consistency with GCPRO2_VAR, etc: it is now the
11411 prefix of the variable, not the variable itself. All uses
11412 changed.
38b2c076
PE
11413 * dired.c (directory_files_internal, file_name_completion):
11414 Rename locals to avoid shadowing.
11415
15206ed9
PE
11416 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11417 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11418 dired.c's scmp function, had undefined behavior.
11419 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11420 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11421 * buffer.h: ... to here, because these macros use current_buffer,
11422 and the new implementation with inline functions needs to have
11423 current_buffer in scope now, rather than later when the macros
11424 are used.
11425 (downcase, upcase1): New static inline functions.
11426 (DOWNCASE, UPCASE1): Reimplement using these functions.
11427 This avoids undefined behavior in expressions like
11428 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11429 from race conditions in accessing the global variables
11430 case_temp1 and case_temp2.
11431 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11432 * lisp.h (case_temp1, case_temp2): Remove their decls.
11433 * character.h (ASCII_CHAR_P): Move from here ...
11434 * lisp.h: ... to here, so that the inline functions mentioned
11435 above can use them.
11436
4a6bea26
PE
11437 * dired.c (directory_files_internal_unwind): Now static.
11438
f14b7e14
PE
11439 * fileio.c (file_name_as_directory, directory_file_name):
11440 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11441 Now static.
2893f146
PE
11442 (file_name_as_directory): Use const pointers when appropriate.
11443 (Fexpand_file_name): Likewise. In particular, newdir might
11444 point at constant storage, so make it a const pointer.
fd4ead52 11445 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11446 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11447 signedness issues.
f839df0c
PE
11448 (Fset_file_times, Finsert_file_contents, auto_save_error):
11449 Rename locals to avoid shadowing.
f14b7e14 11450
5716756e 11451 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11452 (Ftry_completion, Fall_completions): Rename or remove locals
11453 to avoid shadowing.
5716756e 11454
b4c3046a
PE
11455 * marker.c (bytepos_to_charpos): Remove; unused.
11456
b45db522
PE
11457 * lisp.h (verify_bytepos, count_markers): New decls,
11458 so that gcc does not warn that these functions aren't declared.
11459
85876d07
PE
11460 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11461 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11462 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11463 (copy_text): Remove unused local var.
85876d07 11464
03d78a21 11465 * filelock.c (within_one_second): Now static.
b3dd38ab 11466 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11467
5df8f01b
PE
11468 * buffer.c (fix_overlays_before): Mark locals as initialized.
11469 (fix_start_end_in_overlays): Likewise. This function should be
11470 simplified by using pointers-to-pointers, but that's a different
11471 matter.
b1d876f1 11472 (switch_to_buffer_1): Now static.
8f54f30a
PE
11473 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11474 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11475
a70072c9 11476 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11477 Fix pointer signedness issue.
edced198
PE
11478 (sys_subshell): Mark local as volatile if checking for lint,
11479 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11480 (MAXPATHLEN): Define only if needed.
a70072c9 11481
a0977c44
PE
11482 * process.c (serial_open, serial_configure): Move decls from here ...
11483 * systty.h: ... to here, so that they can be checked.
11484
a884fdcc
PE
11485 * fns.c (get_random, seed_random): Move extern decls from here ...
11486 * lisp.h: ... to here, so that they can be checked.
11487
604efe86 11488 * sysdep.c (reset_io): Now static.
b8950c94 11489 (wait_for_termination_signal): Remove; unused.
604efe86 11490
38fc62d9
PE
11491 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11492 (copy_keymap_item, append_key, push_text_char_description):
11493 Now static.
1004a21a 11494 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11495 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11496 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11497 (describe_map_tree):
11498 Rename locals to avoid shadowing.
38fc62d9 11499
2f2650da
PE
11500 * keyboard.c: Declare functions static if they are not used elsewhere.
11501 (echo_char, echo_dash, cmd_error, top_level_2):
11502 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11503 (read_char, kbd_buffer_get_event, make_lispy_position):
11504 (make_lispy_event, make_lispy_movement, apply_modifiers):
11505 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11506 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11507 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11508 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11509 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11510
a053e86c 11511 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11512 (mark_kboards): Move decl here ...
11513 * alloc.c (mark_kboards): ... from here.
a053e86c 11514
4752793e
PE
11515 * lisp.h (force_auto_save_soon): New decl.
11516
74f10ca7 11517 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11518 (DEFINE_DUMMY_FUNCTION): New macro.
11519 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11520 Use it.
c03cd23f
PE
11521 (main): Add casts to avoid warnings
11522 if GCC considers string literals to be constants.
74f10ca7 11523
022e70d4
PE
11524 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11525
59d6fe83
PE
11526 * dbusbind.c: Pointer signedness fixes.
11527 (xd_signature, xd_append_arg, xd_initialize):
11528 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11529 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11530 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11531 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11532
78320123
PE
11533 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11534 if GCC considers string literals to be constants.
49cebcca 11535 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11536
35ac2a97
SM
115372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11538
fb103ca9
SM
11539 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11540 (print_preprocess, print_object): New macro to fix last change.
11541
35ac2a97
SM
11542 * print.c (print_preprocess): Don't forget font objects.
11543
62973b41
JB
115442011-03-16 Juanma Barranquero <lekktu@gmail.com>
11545
11546 * emacs.c (USAGE3): Doc fixes.
11547
0e48bb22
AS
115482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11549
11550 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11551 structure.
11552
7684e57b
JB
115532011-03-14 Juanma Barranquero <lekktu@gmail.com>
11554
11555 * lisp.h (VWindow_system, Qfile_name_history):
11556 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11557 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11558 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11559
11560 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11561 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11562
11563 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11564 * w32console.c (detect_input_pending, read_input_pending)
11565 (encode_terminal_code):
11566 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11567 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11568 (w32_system_caret_y, Qfile_name_history):
11569 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11570 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11571 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11572 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11573 * w32proc.c (Qlocal, report_file_error):
11574 * w32term.c (Vwindow_system, updating_frame):
11575 * w32uniscribe.c (initialized, uniscribe_font_driver):
11576 Remove unneeded extern declarations.
11577
2aa46d6c
CY
115782011-03-14 Chong Yidong <cyd@stupidchicken.com>
11579
c96bbc66 11580 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11581
cffc6f3b
CY
115822011-03-13 Chong Yidong <cyd@stupidchicken.com>
11583
11584 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11585 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11586 These macros can no longer be used for assignment.
11587
44f230aa
SM
11588 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11589 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11590 (record_buffer_markers, fetch_buffer_markers): New functions for
11591 recording and fetching special buffer markers.
11592 (set_buffer_internal_1, set_buffer_temp): Use them.
11593
11594 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11595
11596 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11597
11598 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11599 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11600
11601 * xdisp.c (hscroll_window_tree):
11602 (reconsider_clip_changes): Use PT instead of BUF_PT.
11603
d251f04b
EZ
116042011-03-13 Eli Zaretskii <eliz@gnu.org>
11605
11606 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11607 $(EMACS_ROOT)/lib/intprops.h.
11608
f0c77cd1
PE
116092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11610
3eca4629
PE
11611 Fix more problems found by GCC 4.5.2's static checks.
11612
7c86ee98
PE
11613 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11614 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11615 (xg_free_frame_widgets): Make it clear that a local variable is
11616 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11617 (gdk_window_get_screen): Make it clear that this macro is needed
11618 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11619 (int_gtk_range_get_value): New function, which avoids a diagnostic
11620 from gcc -Wbad-function-cast.
11621 (xg_set_toolkit_scroll_bar_thumb): Use it.
11622 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11623 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11624 (get_utf8_string, xg_get_file_with_chooser):
11625 Rename locals to avoid shadowing.
11626 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11627
41729b81
PE
11628 * xgselect.c (xg_select): Remove unused var.
11629
f0c77cd1
PE
11630 * image.c (four_corners_best): Mark locals as initialized.
11631 (gif_load): Initialize transparent_p to zero (Bug#8238).
11632 Mark another local as initialized.
ec6cf4c6 11633 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11634
ce0ad53d 11635 * image.c (clear_image_cache): Now static.
d5d5a617 11636 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11637 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11638 (x_edge_detection): Remove unnecessary cast that
11639 gcc -Wbad-function-cast diagnoses.
2037898d 11640 (gif_load): Fix pointer signedness.
6ae141d6
PE
11641 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11642 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11643
33383987 116442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11645
d32df629
PE
11646 Improve quality of tests for time stamp overflow.
11647 For example, without this patch (encode-time 0 0 0 1 1
11648 1152921504606846976) returns the obviously-bogus value (-948597
11649 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11650 reports time overflow. See
11651 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11652 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11653 * editfns.c: Include limits.h and intprops.h.
11654 (TIME_T_MIN, TIME_T_MAX): New macros.
11655 (time_overflow): Move earlier, to before first use.
11656 (hi_time, lo_time): New functions, for an accurate test for
11657 out-of-range times.
11658 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11659 (Fget_internal_run_time): Don't assume time_t fits in int.
11660 (make_time): Use list2 instead of Fcons twice.
11661 (Fdecode_time): More accurate test for out-of-range times.
11662 (check_tm_member): New function.
11663 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11664 (lisp_time_argument): Don't rely on undefined left-shift and
11665 right-shift behavior when checking for time stamp overflow.
8be6f318 11666
fe31d94c
PE
11667 * editfns.c (time_overflow): New function, refactoring common code.
11668 (Fformat_time_string, Fdecode_time, Fencode_time):
11669 (Fcurrent_time_string): Use it.
11670
8be6f318
PE
11671 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11672 * dired.c (make_time): Move to ...
11673 * editfns.c (make_time): ... here.
11674 * systime.h: Note the move.
11675
09d9db2c 116762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11677
126bc0dc
YM
11678 * fringe.c (update_window_fringes): Remove unused variables.
11679
c47cbdfd
YM
11680 * unexmacosx.c (copy_data_segment): Also copy __got section.
11681 (Bug#8223)
11682
7ac80be9
EZ
116832011-03-12 Eli Zaretskii <eliz@gnu.org>
11684
c96bbc66 11685 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11686 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11687 Constify `char *' arguments and their references according to
11688 prototypes in tparam.h.
11689
ecb0f94d 11690 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11691
7ac80be9
EZ
11692 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11693 Adapt all references accordingly.
11694
11695 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11696
ef1fd07e
TT
116972011-03-11 Tom Tromey <tromey@redhat.com>
11698
11699 * buffer.c (syms_of_buffer): Remove obsolete comment.
11700
7ef4b50c
EZ
117012011-03-11 Eli Zaretskii <eliz@gnu.org>
11702
11703 * termhooks.h (encode_terminal_code): Declare prototype.
11704
11705 * msdos.c (encode_terminal_code): Don't declare prototype.
11706
11707 * term.c (encode_terminal_code): Now external again, used by
11708 w32console.c and msdos.c.
11709
44f230aa
SM
11710 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11711 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11712
4b1ec863 117132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11714
1714f52b 11715 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11716
4b1ec863
PE
11717 * fringe.c (update_window_fringes): Mark locals as initialized
11718 (Bug#8227).
11719 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11720
524c7aa6
PE
11721 * alloc.c (mark_fringe_data): Move decl from here ...
11722 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11723 to check its interface.
11724 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11725
a5c0af81 11726 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11727 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11728 (fontset_font): Mark local as initialized.
a9a06e0b 11729 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11730
b4716021
PE
11731 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11732
811e9bac 11733 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11734 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11735 (x_own_selection, Fx_disown_selection_internal): Rename locals
11736 to avoid shadowing.
11737 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11738
7e3ab302
PE
11739 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11740 so that the caller can use some name other than gcpro1.
11741 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11742 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11743 (Fx_backspace_delete_keys_p):
11744 Use them to avoid shadowing, and rename vars to avoid shadowing.
11745 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11746 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11747 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11748 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11749 Remove unused locals.
7e3ab302
PE
11750 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11751 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11752 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11753 macros.
f78faa98 11754
e2b13473
PE
11755 * xterm.h (x_mouse_leave): New decl.
11756
77f23912
PE
11757 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11758 Remove unused functions.
cdf4ba58
PE
11759 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11760 (x_calc_absolute_position): Now static.
7411c686 11761 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11762 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11763 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11764 unless they are used.
38d0b34a
PE
11765 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11766 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11767 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11768 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11769 (x_error_catcher, x_connection_closed, x_error_handler):
11770 (x_error_quitter, xembed_send_message, x_iconify_frame):
11771 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11772 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11773 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11774
44f230aa
SM
11775 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11776 Rename or move locals to avoid shadowing.
6b463e58 11777 (tty_defined_color, merge_face_heights): Now static.
5967d051 11778 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11779 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11780 does not deduce is never used uninitialized.
73719eba
PE
11781 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11782 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11783
426994c3 11784 * terminal.c (store_terminal_param): Now static.
5489860b 11785
032f1620 11786 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11787 (set_frame_menubar): Remove unused local.
d4323972 11788 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11789 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11790 since they might point to immutable storage.
281585b0
PE
11791 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11792 since it's unused otherwise.
032f1620 11793
367c19e5 11794 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11795 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11796 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11797 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11798 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11799 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11800 does not deduce are never used uninitialized.
70739cbe 11801
07b48fa9
PE
11802 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11803
8868a238 11804 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11805 * window.c (window_loop, size_window):
11806 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11807
7e5cf297 11808 * window.c (display_buffer): Now static.
d6550a9f
PE
11809 (size_window): Mark variables that gcc -Wuninitialized
11810 does not deduce are never used uninitialized.
a586633d
PE
11811 * window.h (check_all_windows): New decl, to forestall
11812 gcc -Wmissing-prototypes diagnostic.
5b555da1 11813 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11814
f6095868
PE
11815 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11816 shadowing.
11817 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11818 Include <limits.h>.
11819 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11820 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11821 (load_charset_map): Mark variables that gcc -Wuninitialized
11822 does not deduce are never used uninitialized.
53df7c11 11823 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11824
f38b440c
PE
11825 * coding.c (coding_set_source, coding_set_destination):
11826 Use "else { /* comment */ }" rather than "else /* comment */;"
11827 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11828 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11829 a block, when the outer 'i' will do.
11830 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11831 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11832 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11833 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11834 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11835 Rename locals to avoid shadowing.
11836 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11837 * coding.c (emacs_mule_char, encode_invocation_designation):
11838 Now static, since they're not used elsewhere.
413bb2db 11839 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11840 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11841 (decode_coding_emacs_mule): Mark variables that gcc
11842 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11843 (detect_coding_iso_2022): Initialize a local variable that might
11844 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11845 this initialization is needed. (Bug#8211)
5f58e762
PE
11846 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11847 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11848 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11849 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11850 Remove unused macros.
f38b440c 11851
232b38b9 11852 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11853 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11854 * character.c (string_count_byte8): Likewise.
232b38b9 11855
fb90da1b
PE
11856 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11857 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11858
fb93dbc2
PE
11859 * chartab.c (copy_sub_char_table): Now static, since it's not used
11860 elsewhere.
5c156ace
PE
11861 (sub_char_table_ref_and_range, char_table_ref_and_range):
11862 Rename locals to avoid shadowing.
bbcd0949 11863 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11864
7d3b3862 11865 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11866 (BIDI_BOB): Remove unused macro.
7d3b3862 11867
6be7d3da
PE
11868 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11869 deduce are never used uninitialized.
c2ed9c8b 11870 * term.c (encode_terminal_code): Likewise.
6be7d3da 11871
75f8807f 11872 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11873
50938595
PE
11874 * tparam.h: New file.
11875 * term.c, tparam.h: Include it.
11876 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11877 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11878 Move these decls to tparam.h, and make them agree with what
11879 is actually in tparam.c. The previous trick of using incompatible
11880 decls in different modules does not conform to the C standard.
11881 All callers of tparam changed to use tparam's actual API.
11882 * tparam.c (tparam1, tparam, tgoto):
11883 Use const pointers where appropriate.
11884
fbceeba2
PE
11885 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11886 * cm.h (struct cm): Likewise.
11887 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11888 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11889 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11890 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11891 (turn_on_face, init_tty): Likewise.
11892 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11893
7f3f1250
PE
11894 * term.c (term_mouse_position): Rename local to avoid shadowing.
11895
e6ca6543
PE
11896 * alloc.c (mark_ttys): Move decl from here ...
11897 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11898
c40f8d15
AS
118992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11900
11901 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11902
cfe0661d
JB
119032011-03-09 Juanma Barranquero <lekktu@gmail.com>
11904
11905 * search.c (compile_pattern_1): Remove argument regp, unused since
11906 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11907 (compile_pattern): Don't pass it.
11908
0afb4571
J
119092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11910
11911 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11912 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11913 for ! HAVE_GTK3.
11914 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11915
11916 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11917
11918 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11919 gdk_window_get_screen, gdk_window_get_geometry,
11920 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11921 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11922 (xg_get_pixbuf_from_pixmap): New function.
11923 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11924 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11925 Call xg_get_pixbuf_from_pixmap instead of
11926 gdk_pixbuf_get_from_drawable.
11927 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11928 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11929 (xg_check_special_colors): Use GtkStyleContext and its functions
11930 for HAVE_GTK3.
11931 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11932 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11933 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11934 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11935 Call gtk_widget_get_preferred_size.
0afb4571
J
11936 (xg_frame_resized): gdk_window_get_geometry only takes 5
11937 parameters.
44f230aa
SM
11938 (xg_win_to_widget, xg_event_is_for_menubar):
11939 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11940 (xg_set_widget_bg): New function.
11941 (delete_cb): New function.
895009e1 11942 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11943 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11944 (xg_set_background_color): Call xg_set_widget_bg.
11945 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11946 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11947 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11948 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11949 if ! HAVE_GTK3.
11950 (update_frame_tool_bar): Call gtk_widget_hide.
11951 (xg_initialize): Use GDK_KEY_g.
11952
11953 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11954 if ! HAVE_GTK3
11955 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11956
11957 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11958 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11959 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11960
1c2cc4ef
JB
119612011-03-08 Juanma Barranquero <lekktu@gmail.com>
11962
11963 * w32xfns.c (select_palette): Check success of RealizePalette against
11964 GDI_ERROR, not zero.
11965
33383987 11966See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11967
11968;; Local Variables:
11969;; coding: utf-8
aac0c6e3
MR
11970;; End:
11971
2f097256 11972 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11973
11974 This file is part of GNU Emacs.
11975
11976 GNU Emacs is free software: you can redistribute it and/or modify
11977 it under the terms of the GNU General Public License as published by
11978 the Free Software Foundation, either version 3 of the License, or
11979 (at your option) any later version.
11980
11981 GNU Emacs is distributed in the hope that it will be useful,
11982 but WITHOUT ANY WARRANTY; without even the implied warranty of
11983 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11984 GNU General Public License for more details.
11985
11986 You should have received a copy of the GNU General Public License
11987 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.