Fix MS-Windows build with MSVC compiler.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8c9afb46
EZ
12011-11-27 Eli Zaretskii <eliz@gnu.org>
2
3 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6 (malloc, free, realloc, calloc): Redirect to e_* only when
7 compiling Emacs.
8
9 * lisp.h (GCTYPEBITS): Move before first use.
10 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
11 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
12 this macro definition.
13
14 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
15 _MSC_VER.
16
54e9e3bf
JD
172011-11-27 Jan Djärv <jan.h.d@swipnet.se>
18
19 * gtkutil.c (xg_create_frame_widgets): Call
20 gtk_window_set_has_resize_grip (FALSE) if that function is
21 present with Gtk+ 2.0.
22
83aca1cb
PE
232011-11-26 Paul Eggert <eggert@cs.ucla.edu>
24
25 * fileio.c (Finsert_file_contents): Undo previous change; see
26 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
27
5b76caa4
PE
282011-11-26 Paul Eggert <eggert@cs.ucla.edu>
29
30 Rename locals to avoid shadowing.
31 * fileio.c (Finsert_file_contents):
32 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
33 * process.c (wait_reading_process_output):
34 Rename inner 'proc' to 'p' to avoid shadowing.
35 Indent for consistency with usual Emacs style.
36
8c535114
EZ
372011-11-25 Eli Zaretskii <eliz@gnu.org>
38
39 * xdisp.c (redisplay_window): If cursor row is not fully visible
40 after recentering, and scroll-conservatively is set to a large
41 number, scroll window by a few more lines to make the cursor fully
42 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
43 (start_display): Don't move to the next line if the display should
44 start at a newline that is part of a display vector or an overlay
45 string. (Bug#10119)
8c535114 46
fa4fdb5c
JL
472011-11-24 Juri Linkov <juri@jurta.org>
48
49 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
50 after the `MagickPingImage' call. (Bug#10112)
51
90ec88df
CY
522011-11-23 Chong Yidong <cyd@gnu.org>
53
54 * window.c (Fcoordinates_in_window_p): Accept only live windows.
55
56e2e794
MR
562011-11-23 Martin Rudalics <rudalics@gmx.at>
57
58 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
59 making another buffer current. (Bug#10114)
60
b6e64c41
GM
612011-11-23 Glenn Morris <rgm@gnu.org>
62
63 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
64
6b21de18
CY
652011-11-23 Chong Yidong <cyd@gnu.org>
66
67 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
68 using it (Bug#5984).
69
b12cd789
EZ
702011-11-22 Eli Zaretskii <eliz@gnu.org>
71
72 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
73 and header-lines, as they don't have one computed for them.
74 (Bug#10098)
75
76 * .gdbinit (prow): Make displayed values more self-explaining.
77 Add row's hash code.
78
261b6fd4
LMI
792011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
80
81 * process.c (wait_reading_process_output): Fix asynchrounous
82 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 83 (wait_reading_process_output): Add comment and URL.
261b6fd4 84
e7cfd277
JD
852011-11-21 Jan Djärv <jan.h.d@swipnet.se>
86
87 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
88
a9b9b7f5
CY
892011-11-21 Chong Yidong <cyd@gnu.org>
90
91 * window.c (Fnext_window, Fprevious_window): Doc fix.
92
b0d15b4f
SM
932011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
94
95 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
96
fe7a3057
JB
972011-11-20 Juanma Barranquero <lekktu@gmail.com>
98
99 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
100
d2999b1a
MR
1012011-11-20 Martin Rudalics <rudalics@gmx.at>
102
103 * window.c (Fset_window_combination_limit): Rename argument
104 STATUS to LIMIT.
105 (Vwindow_combination_limit): Remove "status" from doc-string.
106
d5ff9cd0
AS
1072011-11-20 Andreas Schwab <schwab@linux-m68k.org>
108
109 * m/ibms390.h: Remove.
110 * m/ibms390x.h: Don't include "ibms390.h".
111
a5bb9bd3
SM
1122011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
113
114 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
115 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
116
cd1181db
JB
1172011-11-20 Juanma Barranquero <lekktu@gmail.com>
118
119 * casetab.c (Fset_case_table):
120 * charset.c (Fcharset_after): Fix typos.
121
615a3b8d 1222011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 123
17e845af
PE
124 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
125 Otherwise, valgrind does not work on some platforms.
126 Problem reported by Andreas Schwab in
6a0bf43d
PE
127 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
128 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
129 is set, removing the need for VIRT_ADDRESS_VARIES.
130 (PURE_P): Use a more-efficient implementation that needs just one
131 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
132 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
133 to 4 (xorl, subq, cmpq, setbe).
134 * alloc.c (pure): Always extern now, since that's the
135 VIRT_ADDR_VARIES behavior.
136 (PURE_POINTER_P): Use a single comparison, not two, for
137 consistency with the new puresize.h.
138 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
139 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
140 Remove VIRT_ADDR_VARIES no longer needed.
141
f8fe6f96
EZ
1422011-11-19 Eli Zaretskii <eliz@gnu.org>
143
144 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
145 (erase_phys_cursor, update_window_cursor, show_mouse_face)
146 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
147 behave as if the cursor position were at the window margin.
148
149 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
150 and the cursor position is out of bounds, behave as if the cursor
151 position were at the window margin. (Bug#10075)
152
df05a53c
CY
1532011-11-18 Chong Yidong <cyd@gnu.org>
154
155 * window.c (Fwindow_combination_limit): Make first argument
156 non-optional, since it is meaningless for live windows like the
157 selected window.
158
2071918e
DA
1592011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
160
161 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
162
b50a28de
SM
1632011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
164
165 * intervals.c: Fix grafting over the whole buffer (bug#10071).
166 (graft_intervals_into_buffer): Simplify.
167
015137db
EZ
1682011-11-18 Eli Zaretskii <eliz@gnu.org>
169
170 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
171 hash values of the two rows.
172 (copy_row_except_pointers): Preserve the used[] arrays and the
173 hash values of the two rows. (Bug#10035)
68c95424 174 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
175
176 * xdisp.c (row_hash): New function, body extracted from
177 compute_line_metrics.
178 (compute_line_metrics): Call row_hash, instead of computing the
179 hash code inline.
180
181 * dispnew.c (verify_row_hash): Call row_hash for computing the
182 hash code of a row, instead of duplicating code from xdisp.c.
183
184 * dispextern.h (row_hash): Add prototype.
185
a2addb04
TH
1862011-11-18 Tassilo Horn <tassilo@member.fsf.org>
187
188 * frame.c (delete_frame): Don't delete the terminal when the last
189 X frame is closed if emacs is built with GTK toolkit.
190
df85d315
JB
1912011-11-17 Juanma Barranquero <lekktu@gmail.com>
192
193 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
194
a0c2d0ae
MR
1952011-11-17 Martin Rudalics <rudalics@gmx.at>
196
197 * window.c (Vwindow_splits): Rename to
198 Vwindow_combination_resize. Suggested by Juri Linkov.
199 (Fsplit_window_internal): Use Vwindow_combination_resize instead
200 of Vwindow_splits.
201
58179cce
JB
2022011-11-16 Juanma Barranquero <lekktu@gmail.com>
203
7877f373
JB
204 * nsfns.m (Fns_font_name):
205 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 206
b6f67890
MR
2072011-11-16 Martin Rudalics <rudalics@gmx.at>
208
209 * window.h (window): Rename slot "nest" to "combination_limit".
210 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
211 (Fset_window_nest): Rename to Fset_window_combination_limit.
212 (Vwindow_nest): Rename to Vwindow_combination_limit.
213 (recombine_windows, make_parent_window, make_window)
214 (Fsplit_window_internal, saved_window)
215 (Fset_window_configuration, save_window_save): Rename all
216 occurrences of window_nest to window_combination_limit.
217
c7015153
JB
2182011-11-15 Juanma Barranquero <lekktu@gmail.com>
219
220 * image.c (imagemagick_load_image): Fix typo.
221
322ad6ec
EZ
2222011-11-14 Eli Zaretskii <eliz@gnu.org>
223
224 * xdisp.c (display_line): Move the call to
225 highlight_trailing_whitespace before the call to
226 compute_line_metrics, since the latter needs to see the final
227 faces of all the glyphs to compute ROW's hash value. Fixes
228 assertion violations in row_equal_p. (Bug#10035)
229
f067b8ec
JB
2302011-11-14 Juanma Barranquero <lekktu@gmail.com>
231
232 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
233 just return (bug#10044).
234
1e5b2111
EZ
2352011-11-12 Eli Zaretskii <eliz@gnu.org>
236
7ef3cbd5
EZ
237 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
238 with user-defined heap size. Bump the default size of the temacs
239 heap to 27MB, to avoid memory warning when running temacs.
240 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
241
1e5b2111
EZ
242 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
243 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
244 (verify_row_hash) [XASSERTS]: New function.
245 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
246 that the hash value of glyph rows is correct.
1e5b2111 247
89d61221
MR
2482011-11-12 Martin Rudalics <rudalics@gmx.at>
249
250 * window.h (window): Remove splits slot.
251 * window.c (Fwindow_splits, Fset_window_splits): Remove.
252 (Fdelete_other_windows_internal, make_parent_window)
253 (make_window, Fsplit_window_internal, Fdelete_window_internal)
254 (Fset_window_configuration, save_window_save): Don't deal with
255 split status of windows.
256 (saved_window): Remove splits slot.
257 (Vwindow_splits): Rewrite doc-string.
258
97f18cc8
JD
2592011-11-11 Jan Djärv <jan.h.d@swipnet.se>
260
261 * xfns.c (unwind_create_frame):
262 * nsfns.m (unwind_create_frame):
263 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
264 Vframe_list (Bug#9999).
265
22a648b4
DA
2662011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
267
0b381c7e 268 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 269
659afede
KH
2702011-11-11 Kenichi Handa <handa@m17n.org>
271
272 * callproc.c (Fcall_process): Set the member dst_multibyte of
273 process_coding.
274
9ac0394b
KH
2752011-11-11 Johan Bockgård <bojohan@gnu.org>
276
277 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
278 avoid a crash (bug#9496).
279
2fbdc249
CY
2802011-11-09 Chong Yidong <cyd@gnu.org>
281
282 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
283 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
284
ac6b1f81
PE
2852011-11-08 Paul Eggert <eggert@cs.ucla.edu>
286
287 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
288
09db192c
PE
2892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
290
291 Avoid some portability problems by eschewing 'extern inline' functions.
292 The trivial performance wins aren't worth the portability hassles; see
293 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
294 et seq.
295 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
296 (window_box_width, window_box_left, window_box_left_offset)
297 (window_box_right, window_box_right_offset): Undo previous change,
298 by removing the "extern"s.
299 * intervals.c (adjust_intervals_for_insertion)
300 (adjust_intervals_for_deletion): Undo previous change,
301 making these static again.
302 (offset_intervals, temp_set_point_both, temp_set_point)
303 (copy_intervals_to_string): No longer inline.
304 * xdisp.c (window_text_bottom_y, window_box_width)
305 (window_box_height, window_box_left_offset)
306 (window_box_right_offset, window_box_left, window_box_right)
307 (window_box): No longer inline.
308
105216ed
CY
3092011-11-08 Chong Yidong <cyd@gnu.org>
310
311 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
312 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
313 an error if not a live window.
314 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
315 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
316
ae9e237f
JB
3172011-11-07 Juanma Barranquero <lekktu@gmail.com>
318
319 * lisp.h (syms_of_abbrev): Remove declaration.
320 Reported by CHENG Gao <chenggao@royau.me>.
321
c7aa8333
EZ
3222011-11-07 Eli Zaretskii <eliz@gnu.org>
323
324 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
325 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
326 of temacs in GUI mode.
327
be7f5545
MR
3282011-11-07 Martin Rudalics <rudalics@gmx.at>
329
330 * window.h: Declare delete_all_child_windows instead of
331 delete_all_subwindows.
332 * window.c (Fwindow_nest, Fset_window_nest)
333 (Fset_window_new_total, Fset_window_new_normal)
334 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
335 (delete_all_subwindows): Rename to delete_all_child_windows.
336 (Fdelete_other_windows_internal, Fset_window_configuration):
337 Call delete_all_child_windows instead of delete_all_subwindows.
338 * frame.c (delete_frame): Call delete_all_child_windows instead
339 of delete_all_subwindows.
340
ca78dc43
PE
3412011-11-07 Paul Eggert <eggert@cs.ucla.edu>
342
343 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
344 This is also needed for porting to any host where GC_MARK_STACK is
345 not GC_MAKE_GCPROS_NOOPS.
346 (which_symbols): Use it.
347
a0241d01
KH
3482011-11-07 Kenichi Handa <handa@m17n.org>
349
350 * coding.c (coding_set_destination): Check coding->src_pos only
351 when coding->src_object is a buffer (bug#9910).
352
353 * process.c (send_process): Set the member src_multibyte of coding
354 to 0 (bug#9911) when sending a unibyte text.
355
356 * callproc.c (Fcall_process): Set the member src_multibyte of
357 process_coding to 0 (bug#9912).
358
a64bfdfa 3592011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
360
361 * xmenu.c (cleanup_widget_value_tree): New function.
362 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
363 calling free_menubar_widget_value_tree directly (Bug#9830).
364
cb41b32a
PE
3652011-11-06 Paul Eggert <eggert@cs.ucla.edu>
366
367 Fix some portability problems with 'inline'.
368 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
369 (window_box_width, window_box_left, window_box_left_offset)
370 (window_box_right, window_box_right_offset): Declare extern.
371 Otherwise, these inline functions do not conform to C99 and
372 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
373 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
374 * intervals.c (adjust_intervals_for_insertion)
375 (adjust_intervals_for_deletion): Now extern, because otherwise the
376 extern inline functions 'offset_intervals' couldn't refer to it.
377 (static_offset_intervals): Remove.
378 (offset_intervals): Rewrite using the old contents of
379 static_offset_intervals. The old version didn't conform to C99
380 because an extern inline function contained a reference to an
381 identifier with static linkage.
382
b7041366
AS
3832011-11-06 Andreas Schwab <schwab@linux-m68k.org>
384
385 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
386 GC.
387
88a37c4d
EZ
3882011-11-06 Eli Zaretskii <eliz@gnu.org>
389
390 * xdisp.c (init_iterator, reseat_to_string): Don't set the
391 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
392 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
393 return Qleft_to_right.
394
49745b39
CY
3952011-11-06 Chong Yidong <cyd@gnu.org>
396
397 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
398 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
399 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
400 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
401 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
402 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
403 (Fwindow_vscroll): Doc fix.
404 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
405 argument, since it makes no sense to pass a live window and for
406 consistency with window-child.
407
1f05cd82
CS
4082011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
409
410 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
411 support MSVC.
412
22610910
JR
4132011-11-05 Jason Rumney <jasonr@gnu.org>
414
415 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
416 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
417 fonts (Bug#6029).
418 (add_font_entity_to_list): Fix logic errors in mixed boolean and
419 bitwise arithmetic preventing use of unicode-sip and non-truetype
420 opentype fonts.
421
a06776b2
EZ
4222011-11-05 Eli Zaretskii <eliz@gnu.org>
423
3ad924ba
EZ
424 * s/ms-w32.h (fstat, stat, utime): Move redirections to
425 "emacs"-only part.
426
a06776b2
EZ
427 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
428 initialization code to keep similarity to xfns.c after changes
429 from 2011-11-05.
430
c9e7db78
JD
4312011-11-05 Jan Djärv <jan.h.d@swipnet.se>
432
a97f8f3f
JD
433 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
434 (unwind_create_frame): New function (Bug#9943).
435 (Fx_create_frame): Restructure code to be more similar to the one in
436 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
437 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
438 Move terminal->reference_count++ just before making the frame official
439 (Bug#9943).
440
441 * nsterm.m (x_free_frame_resources): New function.
442 (x_destroy_window): Move code to x_free_frame_resources.
443
c9e7db78
JD
444 * xfns.c (unwind_create_frame): Fix comment.
445 (Fx_create_frame, x_create_tip_frame): Move
446 terminal->reference_count++ just before making the frame
447 official. Move initialization of image_cache_refcount and
448 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
449
a6fc3b5c
EZ
4502011-11-05 Eli Zaretskii <eliz@gnu.org>
451
452 Support MSVC build with newer versions of Visual Studio.
453 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
454 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
455 nt/gmake.defs.
456
457 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
458 which are not supported by MSVC.
459 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
460 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
461 bitfields.
462 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
463 types in bitfields.
464 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
465
466 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
467
58179cce 4682011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
469
470 Support MSVC build with newer versions of Visual Studio.
471 * w32.c: Don't include w32api.h for MSVC.
472 (init_environment) [_MSC_VER]: Call sys_access, not _access.
473
474 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
475 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
476 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
477 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
478 e_* cousins.
479 (alloca) [_MSC_VER]: Define to _alloca.
480
481 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
482
483 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
484
a58c13ed
EZ
4852011-11-04 Eli Zaretskii <eliz@gnu.org>
486
487 * xdisp.c (note_mouse_highlight): If either of
488 previous/next-single-property-change returns nil, treat that as
489 the beginning or the end of the buffer. (Bug#9955)
490
fe0b6370
JD
4912011-11-04 Jan Djärv <jan.h.d@swipnet.se>
492
a58c13ed 493 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
494 label is not null (Bug#9951).
495 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
496 may be NULL.
497
89bd5ee1
EZ
4982011-11-04 Eli Zaretskii <eliz@gnu.org>
499
500 * window.c (Fwindow_body_size): Mention in the doc string that the
501 return value is in frame's canonical units. (Bug#9949)
502
84c3edb9
EZ
5032011-11-03 Eli Zaretskii <eliz@gnu.org>
504
4e2fb5c7
EZ
505 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
506
84c3edb9 507 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 508 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 509 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 510
bc17a887
EZ
5112011-11-01 Eli Zaretskii <eliz@gnu.org>
512
513 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
514 Don't stop backward scan on the continuation glyph, even though
515 its CHARPOS is positive.
26b46e51
EZ
516 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
517 cover_string to disp_string.
bc17a887 518
4ee88440
MR
5192011-11-01 Martin Rudalics <rudalics@gmx.at>
520
521 * window.c (temp_output_buffer_show): Don't use
522 Vtemp_buffer_show_specifiers.
523 (Vtemp_buffer_show_specifiers): Remove unused variable.
524
c2ff3c02
EZ
5252011-10-30 Eli Zaretskii <eliz@gnu.org>
526
527 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
528 past the beginning of the current glyph matrix.
529
58179cce 5302011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
531
532 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
533 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
534 HAVE_GTK3 (Bug#9869).
b77a6a7f 535
3b574623
JD
536 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
537 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
538
b77a6a7f
JD
539 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
540
541 * xterm.c: Declare x_handle_net_wm_state to return int.
542 (handle_one_xevent): Check if we are iconified but don't have
543 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
544 (get_current_wm_state): Return non-zero if not hidden,
545 check for _NET_WM_STATE_HIDDEN (Bug#9893).
546 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
547 (x_handle_net_wm_state): Return what get_current_wm_state returns.
548 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
549
196e41e4
PE
5502011-10-29 Paul Eggert <eggert@cs.ucla.edu>
551
552 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
553 so that this new function doesn't get optimized away by a
554 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
555
021f2e1a
AS
5562011-10-29 Andreas Schwab <schwab@linux-m68k.org>
557
558 * frame.h (MOUSE_HL_INFO): Remove excess parens.
559
8b058d44
EZ
5602011-10-29 Eli Zaretskii <eliz@gnu.org>
561
562 Fix the `xbytecode' command.
563 * .gdbinit (xprintbytestr): New command.
b50a28de 564 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
565 (xbytecode): Print the byte-code string as well.
566
4452fb80
EZ
5672011-10-29 Kim Storm <storm@cua.dk>
568
8b058d44
EZ
569 * alloc.c (which_symbols): New function.
570
21b72067
AS
5712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
572
573 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
574 line. (Bug#9903)
575
83ed7b5c
GM
5762011-10-29 Glenn Morris <rgm@gnu.org>
577
578 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
579 Not clear what it was for, and it causes various bugs. (Bug#9839)
580
5a7a728b
EZ
5812011-10-28 Eli Zaretskii <eliz@gnu.org>
582
583 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
584 possible random value that matches one of those tested as
585 condition to clear the mouse face.
586
d3d0842f
CY
5872011-10-28 Chong Yidong <cyd@gnu.org>
588
589 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
590
31b39d13
DN
5912011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
592
593 * window.c (make_window): Initialize phys_cursor_on_p.
594
9aba6043
SM
5952011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
596
597 * lisp.h (struct Lisp_Symbol): Update comments.
598
c20992f4
JB
5992011-10-28 Juanma Barranquero <lekktu@gmail.com>
600
601 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
602
db4f02f2
EZ
6032011-10-28 Eli Zaretskii <eliz@gnu.org>
604
605 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
606 <oslsachem@gmail.com> for helping to debug this.
607
608 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
609 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
610 (g_b_init_get_glyph_outline_w): New static variables.
611 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
612 (GetGlyphOutlineW_Proc): New typedefs.
613 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
614 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
615 New functions.
616 (w32font_open_internal, compute_metrics):
617 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
618 instead of calling the "wide" APIs directly.
619
620 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
621
622 * w32.h (syms_of_w32font): Add prototype.
623
87e68db4
JB
6242011-10-27 Juanma Barranquero <lekktu@gmail.com>
625
626 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
627 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
628 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
629 (Fmove_to_window_line): Doc fix.
630
435c1d67
CY
6312011-10-27 Chong Yidong <cyd@gnu.org>
632
633 * process.c (make_process): Set gnutls_state to NULL.
634
635 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
636 non-NULL, regardless of GNUTLS_INITSTAGE.
637 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
638 an error. Set process slots as soon as we allocate them.
639
640 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
641
9c6c6f49
CY
6422011-10-27 Chong Yidong <cyd@gnu.org>
643
9aba6043
SM
644 * gnutls.c (emacs_gnutls_deinit): New function.
645 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
646 (Fgnutls_deinit, Fgnutls_boot): Use it.
647
648 * process.c (make_process): Initialize GnuTLS credentials to NULL.
649 (deactivate_process): Call emacs_gnutls_deinit.
650
657d08d3
JB
6512011-10-27 Juanma Barranquero <lekktu@gmail.com>
652
653 * image.c (x_create_x_image_and_pixmap):
654 * w32.c (sys_rename, w32_delayed_load):
655 * w32font.c (fill_in_logfont):
656 * w32reg.c (x_get_string_resource): Silence compiler warnings.
657
5430d399
JB
6582011-10-26 Juanma Barranquero <lekktu@gmail.com>
659
660 * w32fns.c (w32_default_color_map): New function,
661 extracted from Fw32_default_color_map.
a7ef684b 662 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 663
fe0055fa
PE
6642011-10-25 Paul Eggert <eggert@cs.ucla.edu>
665
666 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
667
e6346438
SM
6682011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
669
670 * keyboard.c (test_undefined): New function (bug#9751).
671 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
672
e112cc37
ET
6732011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
674
675 * sysdep.c (init_sys_modes): Fix the check for the controlling
676 terminal (Bug#6649).
677
7b5d6677
EZ
6782011-10-20 Eli Zaretskii <eliz@gnu.org>
679
680 * dispextern.h (struct bidi_it): New member next_en_type.
681
682 * bidi.c (bidi_line_init): Initialize the next_en_type member.
683 (bidi_resolve_explicit_1): When next_en_pos is valid for the
684 current character, check also for next_en_type being WEAK_EN.
685 (bidi_resolve_weak): Don't enter the expensive loop if the current
686 position is before next_en_pos. Record the bidi type of the first
687 non-ET, non-BN character we find, in addition to its position.
688 (bidi_level_of_next_char): Invalidate next_en_type when
689 next_en_pos is over-stepped.
690
7da0b018
PE
6912011-10-20 Paul Eggert <eggert@cs.ucla.edu>
692
693 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
694 * editfns.c: Rewrite current-time-zone so that it invokes
695 the equivalent of (format-time-string "%Z") to get the time zone name.
696 This fixes a bug when the time zone name contains characters that
697 need converting from the system time locale to Emacs internal format.
698 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
699 that patch fixed format-time-string to do the conversion, but
700 I forgot to fix current-time-zone.
701 (format_time_string): New function, containing most of
702 what Fformat_time_string used to contain.
703 (Fformat_time_string): Rewrite in terms of format_time_string.
704 This doesn't change this function's behavior.
705 (current-time-zone): Rewrite to use format_time_string.
706 This fixes the bug reported by Michael Schierl in
707 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
708 Jason Rumney's 2007-06-07 change worked around this bug, but
709 didn't fix it.
710 * systime.h (tzname, timezone): Remove no-longer-used declarations.
711
8547b010
EZ
7122011-10-19 Eli Zaretskii <eliz@gnu.org>
713
714 * xdisp.c (start_display): If the character at POS is displayed
715 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
716 (try_window_reusing_current_matrix): If a line ends in a display
717 vector or the next line starts in a display vector, continue
718 redrawing the window even though the character position of
719 start_row was reached.
8547b010
EZ
720 (Bug#9771, part 2)
721
4e948d15
CY
7222011-10-18 Chong Yidong <cyd@gnu.org>
723
724 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
725 with nobreak-char-display too.
726
4787455f
EZ
7272011-10-18 Eli Zaretskii <eliz@gnu.org>
728
729 Fix part 3 of bug#9771.
730 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
731 (bidi_resolve_neutral): Don't enter the expensive loop looking for
732 non-neutral characters if the current character is a paragraph
733 separator (a.k.a. Newline). This avoids running the same
734 expensive loop twice, once when we consume the preceding newline
735 and the other time when the line actually needs to be displayed.
736 Avoid the loop when we see neutrals on the base embedding level
737 following a character whose directionality is the same as the
738 paragraph's. This avoids running the expensive loop when a line
739 ends in a long sequence of neutrals, like control characters.
740 Add assertion against STRONG_AL type. Slightly rearrange code
741 that determines the type of a neutral given the first non-neutral
742 that follows it.
743 (bidi_level_of_next_char): Set next_en_pos to zero when
744 invalidating its info.
745
2c91f553
EZ
7462011-10-17 Eli Zaretskii <eliz@gnu.org>
747
748 * xdisp.c (push_display_prop): Determine whether to record string
749 or buffer position by IT->string, not by IT->method. Allow
750 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
751 (move_it_vertically_backward): Don't look for character position
752 immediately after the newline when in a continuation line.
753 (Bug#9771, part 1)
2c91f553 754
c7b08b0d
MR
7552011-10-15 Martin Rudalics <rudalics@gmx.at>
756
757 * window.c (coordinates_in_window): Rewrite and delabelize
758 vertical border check. (Bug#5357) (Bug#9618)
759
6b02f655
SM
7602011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
761
762 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
763 errors in XSetWindowBorder (bug#9310).
764
81d40c92
DA
7652011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
766
767 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
768 avoid crash when xmalloc overrun checking is enabled.
769
d4172c3b
EZ
7702011-10-13 Eli Zaretskii <eliz@gnu.org>
771
772 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
773 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
774 cursor motion with <left> and <right> arrow keys.
775
776 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
777 some callers set that themselves.
778
b00eea75
EZ
7792011-10-12 Eli Zaretskii <eliz@gnu.org>
780
781 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
782 display string and the previous row comes from the same string and
783 is empty. (Bug#9739) (Bug#9738)
784
8fe012c4
SM
7852011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
786
787 * doc.c (get_doc_string): Encode file name (bug#9735).
788
0074aef2
EZ
7892011-10-12 Eli Zaretskii <eliz@gnu.org>
790
79beb178
EZ
791 * bidi.c (bidi_level_of_next_char):
792 * xdisp.c (get_visually_first_element): Remove old incorrect
793 comments regarding the Unicode Line Separator character.
794
0074aef2
EZ
795 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
796
6e4b3fbe
DA
7972011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
798
799 * alloc.c (Fgc_status): Do not access beyond zombies array
800 boundary if nzombies > MAX_ZOMBIES.
801 * alloc.c (dump_zombies): Add missing format specifier.
802
0324f3af
PE
8032011-10-12 Paul Eggert <eggert@cs.ucla.edu>
804
b5525cac
PE
805 * xdisp.c (set_cursor_from_row): Simplify conditionals,
806 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
807
0324f3af
PE
808 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
809 Some packages use them to denote characters with modifiers.
810
e9b5f888
AS
8112011-10-11 Andreas Schwab <schwab@linux-m68k.org>
812
813 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
814 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
815 matching a pp-number. Rename parameter var to var1.
816
127827c0
SM
8172011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
820
c8fd3bd0
GM
8212011-10-08 Glenn Morris <rgm@gnu.org>
822
823 * callint.c (Fcall_interactively): Give a more explicit error for the
824 'c' case with a non-character input. (Bug#8479)
825
352ec8ff
EZ
8262011-10-08 Eli Zaretskii <eliz@gnu.org>
827
03669ccb
EZ
828 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
829 lines.
7061c986
EZ
830 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
831 lines that are hscrolled on the left.
03669ccb 832
352ec8ff
EZ
833 * dispnew.c (buffer_posn_from_coords): Account for a possible
834 presence of header-line. (Bug#4426)
835
a66cfb1c
SM
8362011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
837
6b02f655
SM
838 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
839 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 840
7c5ee88e
PE
8412011-10-07 Paul Eggert <eggert@cs.ucla.edu>
842
843 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
844 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
845 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
846 this makes Emacs dump core during garbage collection on rare
847 occasions. sizeof is obviously inferior to offsetof here, so
848 stick with offsetof.
849 (GC_POINTER_ALIGNMENT): New macro.
850 (mark_memory): Omit 3rd (offset) arg; caller changed.
851 Don't assume EMACS_INT alignment is the same as pointer alignment.
852
df1bbe5b
SM
8532011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
854
855 * keyboard.c (read_key_sequence_remapped): New var.
856 (read_key_sequence): Compute remapping in the right buffer.
857 (command_loop_1): Use read_key_sequence's remapping directly.
858
51553db6
SM
8592011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
860
32c1fffd
SM
861 * dired.c (file_name_completion): Don't expand file name.
862 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
863 before checking file name handler.
864
51553db6
SM
865 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
866 they've been requested explicitly (bug#9591).
867
b6bd1599 8682011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
869
870 * keymap.c (Fsingle_key_description): Use make_specified_string
871 instead of build_string to build string from push_key_description.
872 (Bug#5193)
873
f701dc2a
PE
8742011-09-30 Paul Eggert <eggert@cs.ucla.edu>
875
4222c55d
PE
876 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
877 This fixes a Y2038 bug on 64-bit hosts.
878 * buffer.c (reset_buffer):
879 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
880 (Fclear_buffer_auto_save_failure):
881 Use 0, not -1, to represent an unset failure time, since time_t
882 might not be signed.
883
f701dc2a
PE
884 Remove dependency on glibc malloc internals.
885 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
886 Move back here from lisp.h, but with their new implementations.
887 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
888 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
889 * charset.c (charset_table_init): New static var.
890 (syms_of_charset): Use it instead of xmalloc. This removes a
891 dependency on glibc malloc internals. See Eli Zaretskii's comment in
892 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
893 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
894 Move back to alloc.c.
895 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
896 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
897
9ceebf39
JD
8982011-09-30 Jan Djärv <jan.h.d@swipnet.se>
899
900 * nsterm.m (windowDidResize): Call x_set_window_size only when
901 ns_in_resize is true. Otherwise set pixelwidth/height and
902 call change_frame_size (Bug#9628).
903
cb993c58
PE
9042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
905
3930c88b
PE
906 Port --enable-checking=all to Fedora 14 x86-64.
907 * charset.c (syms_of_charset): Also account for glibc malloc's
908 internal overhead when calculating the initial malloc maximum.
909
cb993c58
PE
910 Port --enable-checking=all to Fedora 14 x86.
911 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
912 Move to lisp.h.
913 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
914 (overrun_check_realloc, overrun_check_free):
915 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
916 That way, xmalloc returns a properly-aligned pointer even if
917 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
918 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
919 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
920 into account when calculating the initial malloc maximum.
921 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
922 Move here from alloc.c, so that charset.c can use it too.
923 Properly align; the old code wasn't right for common 32-bit hosts
924 when configured with --enable-checking=all.
925 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
926 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
927
31bed486
EZ
9282011-09-29 Eli Zaretskii <eliz@gnu.org>
929
04c70788 930 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
931 use EDOM.
932
fbcaa2f3
EZ
9332011-09-28 Eli Zaretskii <eliz@gnu.org>
934
935 * xdisp.c (compute_display_string_end): If there's no display
936 string at CHARPOS, return -1.
937
938 * bidi.c (bidi_fetch_char): When compute_display_string_end
939 returns a negative value, treat the character as a normal
940 character not covered by a display string. (Bug#9624)
941
a239d4e9
JB
9422011-09-28 Juanma Barranquero <lekktu@gmail.com>
943
944 * lread.c (Fread_from_string): Fix typo in docstring.
945
88652fd5
EZ
9462011-09-27 Eli Zaretskii <eliz@gnu.org>
947
948 * xdisp.c (handle_invisible_prop): If invisible text ends on a
949 newline, reseat the iterator instead of bidi-iterating there one
950 character at a time. (Bug#9610)
32c1fffd
SM
951 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
952 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 953
ed497dd4
AS
9542011-09-27 Andreas Schwab <schwab@linux-m68k.org>
955
956 * lread.c (readevalloop): Use correct code for NBSP.
957 (read1): Likewise. (Bug#9608)
958
b2bf61aa
MA
9592011-09-25 Michael Albinus <michael.albinus@gmx.de>
960
961 * dbusbind.c (Fdbus_register_signal): When service is not
962 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
963
32bbb17c
GM
9642011-09-25 Glenn Morris <rgm@gnu.org>
965
966 * buffer.c (truncate-lines): Doc fix.
967
94e0933e
CY
9682011-09-24 Chong Yidong <cyd@stupidchicken.com>
969
970 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
971 (Fset_window_next_buffers): Doc fix.
972
cddde921
GM
9732011-09-24 Glenn Morris <rgm@gnu.org>
974
975 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
976
1260aef1
PE
9772011-09-24 Paul Eggert <eggert@cs.ucla.edu>
978
25b4bfa0
PE
979 Fix minor problems found by static checking.
980 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
981 * indent.c (Fvertical_motion): Fix == vs = typo.
982
e3cbd34b
EZ
9832011-09-24 Eli Zaretskii <eliz@gnu.org>
984
a66cfb1c
SM
985 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
986 Default value is now t. Doc fix.
6bf7006f 987
e3cbd34b 988 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 989 logic when moving up, not only when moving down. Fix the
e3cbd34b 990 confusing name and values of the it_overshoot_expected variable;
32c1fffd 991 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
992
993 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
994 CHARPOS is covered by a display string which includes newlines.
995 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
996 is covered by a display string with embedded newlines.
997
a3de0cbd
MA
9982011-09-24 Michael Albinus <michael.albinus@gmx.de>
999
1000 * dbusbind.c (Fdbus_register_signal): Add match rule to
1001 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1002 (Fdbus_register_method, Vdbus_registered_objects_table):
1003 Fix docstring.
a3de0cbd 1004
b260039d
JM
10052011-09-24 Jim Meyering <meyering@redhat.com>
1006
32c1fffd 1007 do not ignore write error for any output size
b260039d
JM
1008 The previous change was incomplete.
1009 While it makes emacs --batch detect the vast majority of stdout
1010 write failures, errors were still ignored whenever the output size is
1011 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1012 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1013 && echo FAIL: ignored write error
1014 FAIL: ignored write error
1015 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1016 && echo FAIL: ignored write error
1017 FAIL: ignored write error
1018 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1019
8eca8a7c
AS
10202011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1021
1022 * emacs.c (Fkill_emacs): In noninteractive mode exit
1023 non-successfully if a write error occurred on stdout. (Bug#9574)
1024
3341db62
EZ
10252011-09-21 Eli Zaretskii <eliz@gnu.org>
1026
1027 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1028 the xassert test.
1029
1030 * dispextern.h (struct it): Update the comment documenting what
1031 can it->OBJECT be.
1032
8c203dbf
EZ
10332011-09-20 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1036 a display string, extend search for cursor position to end of row.
1037 (find_row_edges): If the row ends in a newline from a display
1038 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1039 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1040 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1041 non-empty line. Fixes confusing cursor motion with arrow keys at
1042 the beginning of a line that starts with whitespace.
8c203dbf 1043
a4824228
LMI
10442011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1045
1046 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1047 (bug#9493).
1048
33ed493b
CY
10492011-09-18 Chong Yidong <cyd@stupidchicken.com>
1050
1051 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1052 boolean (Bug#9154).
1053
56cd55c8
EZ
10542011-09-18 Eli Zaretskii <eliz@gnu.org>
1055
1056 * xdisp.c (display_line): Record maximum and minimum buffer
1057 positions even if no glyphs were produced (e.g., by a zero-width
1058 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1059 buffer positions that will be removed from the glyph row because
1060 they don't fit.
c02dcedf
EZ
1061 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1062 column is beyond frame width: don't subtract 1 "pixel" when
1063 computing width of the stretch.
3e62b7e0
EZ
1064 (reseat_at_next_visible_line_start): Undo the change made on
1065 2011-09-17 that saved paragraph information and restored it after
1066 the call to `reseat'. (Bug#9545)
56cd55c8 1067
5ed99d36 10682011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1069
1070 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1071 and turn window cursor on if cleared (Bug#9415).
1072
5ed99d36 10732011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1074
1075 * search.c (boyer_moore): Take unibyte characters from pattern
1076 literally. (Bug#9458)
1077
9bade7b2
EZ
10782011-09-18 Eli Zaretskii <eliz@gnu.org>
1079
1080 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1081
e5e9d610
PE
10822011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1083
87e4427a
PE
1084 Fix minor problem found by static checking.
1085 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1086 initialized, to pacify gcc -Wuninitialized.
1087
e5e9d610
PE
1088 * fileio.c: Report proper errno when syscall falls.
1089 (Finsert_file_contents): Save and restore errno,
1090 so that report_file_error outputs the correct diagnostic.
1091 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1092
a1674f0b
EZ
10932011-09-18 Eli Zaretskii <eliz@gnu.org>
1094
1095 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1096
fbfb6dd4
EZ
10972011-09-17 Eli Zaretskii <eliz@gnu.org>
1098
1099 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1100 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1101
bb187662
EZ
11022011-09-17 Eli Zaretskii <eliz@gnu.org>
1103
1137e8b8 1104 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1105 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1106
1107 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1108 (bidi_find_paragraph_start): Search back for paragraph beginning
1109 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1110 (bidi_move_to_visually_next): Only trigger paragraph-related
1111 computations when the last character is a newline or at EOB, not
1112 just any NEUTRAL_B. (Bug#9470)
1113
bb187662
EZ
1114 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1115 truncated lines if point is covered by a display string. (Bug#9524)
1116
2e621251
PE
11172011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1118
1119 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1120 (cons_to_x_long): New function.
1121 (lisp_data_to_selection_data): Use it. Correct the test for
1122 short-versus-long data; it was negated. Break out of vector
1123 loop, for efficiency, when a long datum is discovered.
1124
91a15bc6
SM
11252011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1126
1127 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1128
b41c3a35
EZ
11292011-09-16 Eli Zaretskii <eliz@gnu.org>
1130
1131 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1132 GCC PR/17406) by declaring this function with external scope.
1133
7812ba2d
PE
11342011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1137 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1138
cf7edc2a
AS
11392011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1140
1141 * editfns.c (Fformat): Correctly handle text properties on "%%".
1142
bd01620e
EZ
11432011-09-15 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xterm.c (x_draw_composite_glyph_string_foreground):
1146 * w32term.c (x_draw_composite_glyph_string_foreground):
1147 * term.c (encode_terminal_code):
1148 * composite.c (composition_update_it, get_composition_id):
1149 * xdisp.c (get_next_display_element)
1150 (fill_composite_glyph_string): Add comments about special meaning
1151 of TAB characters in a composition.
1152
a02719a3
PE
11532011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1154
1155 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1156 This occurs when processing a multibyte format.
1157 Problem reported by Wolfgang Jenker.
a02719a3 1158
72589a3c
JB
11592011-09-15 Johan Bockgård <bojohan@gnu.org>
1160
1161 * xdisp.c (try_cursor_movement): Only check for exact match if
1162 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1163
1c14176c
PE
11642011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1165
1166 Remove unused external symbols.
1167 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1168 * xdisp.c (calc_pixel_width_or_height): Now static.
1169 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1170 * indent.c (check_display_width):
1171 * w32term.c: Fix comment to match code.
1172 * xterm.c, xterm.h (x_catching_errors): Remove.
1173
d2eea5b5
PE
11742011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 * xselect.c: Use signed conversions more consistently (Bug#9498).
1177 (selection_data_to_lisp_data): Assume incoming selection data are
1178 signed integers, not unsigned. This is to be consistent with
1179 outgoing selection data, which was modified to use signed integers
1180 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1181 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1182 expects long, not unsigned long.
1183
46888499
EZ
11842011-09-14 Eli Zaretskii <eliz@gnu.org>
1185
1186 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1187 computation of loop end. Reported by Johan Bockgård
1188 <bojohan@gnu.org>.
1189
ef8ef9fb
CY
11902011-09-13 Chong Yidong <cyd@stupidchicken.com>
1191
1192 * frame.c (Fother_visible_frames_p): Function deleted.
1193
fa819fed
EZ
11942011-09-12 Eli Zaretskii <eliz@gnu.org>
1195
1196 * indent.c (compute_motion): Process display vector front to back
1197 rather than the other way around. (Bug#2496)
1198
2ba8e008
SM
11992011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1200
1201 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1202
20f53c69
CY
12032011-09-11 Chong Yidong <cyd@stupidchicken.com>
1204
1205 * minibuf.c (Fread_from_minibuffer): Doc fix.
1206
d562d7a4
EZ
12072011-09-11 Eli Zaretskii <eliz@gnu.org>
1208
1209 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1210 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1211
1c4d7f3d
LMI
12122011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1213
1214 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1215 value for non-existent files.
1216
b885bf36
EZ
12172011-09-11 Eli Zaretskii <eliz@gnu.org>
1218
1219 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1220 set its "size" to -1. This will set the modtime_size field of
1221 the corresponding buffer to -1, which is what
1222 verify-visited-file-modtime expects for files that do not exist.
1223 (Bug#9139)
1224
6612f0bf
PE
12252011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1228 here ...
1229 * lisp.h: ... from here. push_key_description is no longer
1230 defined in keyboard.c, so its declaration should not be in
1231 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1232 logically belongs with push_key_description.
1233
dfb3f755
PE
12342011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 * buffer.h: Include <sys/types.h> instead of <time.h>.
1237 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1238 Problem reported by Herbert J. Skuhra.
1239
3134906c
LMI
12402011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1241
1242 * xml.c (parse_region): Make the parsing work for
1243 non-comment-starting XML files again (bug#9144).
1244
8d903f4e
AS
12452011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1246
1247 * image.c (gif_load): Fix calculation of bottom and right corner.
1248 (Bug#9468)
1249
80ad64f4
EZ
12502011-09-10 Eli Zaretskii <eliz@gnu.org>
1251
1252 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1253 redisplay in small windows.
1254
208a048d
EZ
12552011-09-09 Eli Zaretskii <eliz@gnu.org>
1256
1257 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1258
9b1c252e
MR
12592011-09-08 Martin Rudalics <rudalics@gmx.at>
1260
1261 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1262 Operate on live windows only.
1263
2949f33b
JB
12642011-09-08 Juanma Barranquero <lekktu@gmail.com>
1265
1266 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1267
e08dcafd
EZ
12682011-09-07 Eli Zaretskii <eliz@gnu.org>
1269
1270 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1271 only under bidi iteration.
1272
115b96bd
JD
12732011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1274
1275 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1276
c8199d0f
PE
12772011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1278
1279 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1280 Without this fix, the command to link temacs failed due to an
1281 undefined symbol __builtin_isnan. This is because
1282 /usr/include/iso/math_c99.h #defines isnan(x) to
1283 __builtin_isnan(x), but the bundled gcc, which identifies itself
1284 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1285 a __builtin_isnan.
1286 * floatfns.c (isnan): #undef, and then #define to a clone of
1287 what's in data.c.
1288 (Fisnan): Always define, since it's always available now.
1289 (syms_of_floatfns): Always define isnan at the Lisp level.
1290
e39b275c 12912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1292
1293 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1294
b2db44d9 12952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1296
f4af5137 1297 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1298 The previous code assumed that file offsets (off_t values) fit in
1299 EMACS_INT variables, which is not true on typical 32-bit hosts.
1300 The code messed up by falsely reporting buffer overflow in cases
1301 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1302 when "big" contains more than 2**29 bytes, even though this
1303 inserts just one byte and does not overflow the buffer.
1304 (Finsert_file_contents): Store file offsets as off_t
1305 values, not as EMACS_INT values. Check for overflow when
1306 converting between EMACS_INT and off_t. When checking for
1307 buffer overflow or for overlap, take the offsets into account.
1308 Don't use EMACS_INT for small values where int suffices.
1309 When checking for overlap, fix a typo: ZV was used where
1310 ZV_BYTE was intended.
1311 (Fwrite_region): Don't assume off_t fits into 'long'.
1312 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1313
ecfc0a49
MA
13142011-09-05 Michael Albinus <michael.albinus@gmx.de>
1315
1316 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1317
6511acf2 13182011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1319
0999621a 1320 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1321
1322 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1323 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1324 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1325 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1326 (modify_event_symbol): Do not assume that the length of
1327 name_alist_or_stem is safe to alloca and fits in int.
1328 (Fexecute_extended_command): Likewise for function name and binding.
1329 (Frecursion_depth): Wrap around reliably on integer overflow.
1330 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1331 since some callers pass EMACS_INT values.
1332 (Fsingle_key_description): Don't crash if symbol name contains more
1333 than MAX_ALLOCA bytes.
1334 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1335 (get_minibuffer): Arg is now EMACS_INT, not int.
1336 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1337 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1338 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1339
2be7d702
PE
1340 * dbusbind.c (signature_cat): New function.
1341 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1342 Do not overrun buffer; instead, report string overflow.
1343
9d1df220
PE
1344 * dispnew.c (add_window_display_history): Don't overrun buffer.
1345 Truncate instead; this is OK since it's just a log.
1346
33ef5c64
PE
1347 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1348 even if the time zone offset is outlandishly large.
1349 Don't mishandle offset == INT_MIN.
1350
66c6fdd5
PE
1351 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1352 when creating daemon; the previous buffer-overflow check was incorrect.
1353
d749b01b
PE
1354 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1355 which has the guts of the old verror function.
1356
b5cd1905
PE
1357 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1358 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1359
6e1a67fb
PE
1360 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1361 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1362 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1363 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1364 length of string rather than counting it via multiple sprintfs;
1365 that's simpler and more reliable.
c21721cc
PE
1366 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1367 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1368 sprintf, in case result does not fit in int.
1369
c57b67fc
PE
1370 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1371 (fontset_from_font): Print it.
1372
8a401434
PE
1373 * frame.c (tty_frame_count): Now printmax_t, not int.
1374 (make_terminal_frame, set_term_frame_name): Print it.
1375 (x_report_frame_params): In X, window IDs are unsigned long,
1376 not signed long, so print them as unsigned.
1377 (validate_x_resource_name): Check for implausibly long names,
1378 and don't assume name length fits in 'int'.
1379 (x_get_resource_string): Don't blindly alloca invocation name;
1380 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1381 not fit in int.
1382
6e1a67fb
PE
1383 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1384 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1385 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1386
0df02bf3
PE
1387 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1388 Use esprintf, not sprintf, in case result does not fit in int.
1389
48e30793
PE
1390 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1391 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1392 it as a large positive number.
1393 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1394 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1395
a66ff6d8
PE
1396 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1397 in case result does not fit in int.
1398
aca216ff
PE
1399 * print.c (float_to_string): Detect width overflow more reliably.
1400 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1401 buffer overrun. Don't assume list length fits in 'int'. Treat
1402 print length of 0 as 0, not as infinity; to be consistent with other
1403 uses of print length in this function. Don't overflow print length
1404 index. Don't assume hash table size fits in 'long', or that
1405 vectorlike size fits in 'unsigned long'.
1406
31c286f7
PE
1407 * process.c (make_process): Use printmax_t, not int, to format
1408 process-name gensyms.
1409
55e5faa1
PE
1410 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1411
80f2e268
PE
1412 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1413 to avoid potential buffer overrun.
1414
670741ab
PE
1415 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1416 if X resource line is longer than 512 bytes.
1417
b7163a50
PE
1418 * xfns.c (x_window): Make sprintf buffer a bit bigger
1419 to avoid potential buffer overrun.
1420
ae58ff1f
PE
1421 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1422
c43c8a6a
PE
1423 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1424
3f8236f4
PE
14252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1426
53e9fe90 1427 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1428 Without these, Emacs silently mishandles large integers sometimes.
1429 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1430 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1431
6511acf2
PE
1432 * xdisp.c (try_window_id): Check Emacs fixnum range before
1433 converting to 'int'.
806add1d 1434
6511acf2 1435 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1436 Check that an Emacs fixnum is in range before assigning it to 'int'.
1437 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1438 values converted from Emacs fixnums.
1439 (Frecenter): Don't wrap around a line count if it is out of 'int'
1440 range; instead, treat it as an extreme value.
1441 (Fset_window_configuration, compare_window_configurations):
1442 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1443
6511acf2
PE
1444 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1445 that can exceed INT_MAX. Check that EMACS_INT value is in range
1446 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1447 (match_limit): Don't assume that a fixnum can fit in 'int'.
1448
6511acf2 1449 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1450 exceed INT_MAX.
1451
6511acf2 1452 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1453 (Fvertical_motion): Don't wrap around LINES values that don't fit
1454 in 'int'. Instead, treat them as extreme values. This is good
1455 enough for windows, which can't have more than INT_MAX lines anyway.
1456
fcb901a7
LMI
14572011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1458
0f2f6b6d
LMI
1459 * Require libxml/parser.h to avoid compilation warning.
1460
fcb901a7
LMI
1461 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1462
1463 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1464 since this reportedly can destroy thread storage.
1465
6e20a0d4
CY
14662011-08-30 Chong Yidong <cyd@stupidchicken.com>
1467
1468 * syntax.c (find_defun_start): Update all cache variables if
1469 exiting early (Bug#9401).
1470
148ae00e
EZ
14712011-08-30 Eli Zaretskii <eliz@gnu.org>
1472
f6cfbd8f
EZ
1473 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1474
148ae00e
EZ
1475 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1476 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1477 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1478
1479 * term.c (tty_append_glyph): New function.
1480 (produce_stretch_glyph): Static function and its prototype deleted.
1481
a66cfb1c
SM
1482 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1483 Add prototypes.
148ae00e 1484
c4a07a4c
PE
14852011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1488 when checking :margin (Bug#9390).
1489 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1490 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1491 so that the name doesn't mislead. All uses changed.
1492
6bc8cd65
JB
14932011-08-28 Johan Bockgård <bojohan@gnu.org>
1494
1495 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1496 set_tty_hooks.
1497
dca4927e
EZ
14982011-08-27 Eli Zaretskii <eliz@gnu.org>
1499
1500 * xdisp.c (move_it_to): Don't bail out early when reaching
1501 position beyond to_charpos, if we are scanning backwards.
1502 (move_it_vertically_backward): When DY == 0, make sure we get to
1503 the first character in the line after the newline.
1504
f2cad773
PE
15052011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1506
1507 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1508 (ccl_driver): Do not generate an out-of-range pointer.
1509 (Fccl_execute_on_string): Remove unnecessary check for
1510 integer overflow, noted by Stefan Monnier in
1511 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1512 Remove a FIXME that didn't need fixing.
1513 Simplify the newly-introduced buffer reallocation code.
1514
0cae2cdb
JB
15152011-08-27 Juanma Barranquero <lekktu@gmail.com>
1516
1517 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1518
5fc295a4 15192011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1520
70c60eb2 1521 Integer and memory overflow issues (Bug#9196).
726e0ab1 1522
d31850da
PE
1523 * doc.c (get_doc_string): Rework so that
1524 get_doc_string_buffer_size is the actual buffer size, rather than
1525 being 1 less than the actual buffer size; this makes xpalloc more
1526 convenient.
1527
a69fbedb
PE
1528 * image.c (x_allocate_bitmap_record, cache_image):
1529 * xselect.c (Fx_register_dnd_atom):
1530 Simplify previous changes by using xpalloc.
1531
fe5c5d37
PE
1532 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1533 since either will do and ptrdiff_t is convenient with xpalloc.
1534
0065d054
PE
1535 * charset.c (charset_table_size)
1536 (struct charset_sort_data.priority): Now ptrdiff_t.
1537 (charset_compare): Don't overflow if priorities differ greatly.
1538 (Fsort_charsets): Don't assume list length fits in int.
1539 Check for size-calculation overflow when allocating sort data.
1540 (syms_of_charset): Allocate an initial charset table that is
1541 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1542
1543 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1544
1545 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1546 The actual value is always <= INT_MAX, and leaving it unsigned made
1547 overflow checking harder.
1548
1549 * dispextern.h (struct glyph_matrix.rows_allocated)
1550 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1551 with xpalloc. The values are still always <= INT_MAX.
1552
1553 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1554
1555 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1556 (SAFE_NALLOCA): New macro.
1557
1558 * region-cache.c (struct boundary.pos, find_cache_boundary)
1559 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1560 (set_cache_region, invalidate_region_cache)
1561 (revalidate_region_cache, know_region_cache, region_cache_forward)
1562 (region_cache_backward, pp_cache):
1563 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1564 so that ptrdiff_t * can be passed to xpalloc.
1565 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1566 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1567 (pp_cache): Don't assume cache_len fits in int.
1568 * region-cache.h: Adjust extern decls to match.
1569
1570 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1571 EMACS_INT, since either will do, for xpalloc.
1572
1573 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1574 (xnmalloc, xnrealloc, xpalloc): New functions.
1575
726e0ab1
PE
1576 * bidi.c (bidi_shelve_header_size): New constant.
1577 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1578 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1579
51f30bc5 1580 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1581 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1582 (overlay_strings):
1583 Don't update size of array until after memory allocation succeeds,
1584 because xmalloc/xrealloc may not return.
0065d054
PE
1585 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1586 now that we have proper integer overflow checking.
1587 (record_overlay_string, overlay_strings): Catch overflows when
1588 calculating size of overlay_str_buf.
726e0ab1 1589
0065d054
PE
1590 * callproc.c (Fcall_process): Check for size overflow when
1591 calculating size of args2.
1592 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1593 Normally we prefer signed values, but sticking with ptrdiff_t would
1594 require adding more-complicated checks.
726e0ab1
PE
1595
1596 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1597 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1598 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1599 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1600
1601 * character.c (Fstring): Check for size-calculation overflow.
1602
1603 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1604 unnecessary integer overflow. Check for size overflow.
1605 (encode_coding_object): Don't update size until xmalloc succeeds.
1606
1607 * composite.c (get_composition_id): Check for overflow in glyph
1608 length calculations.
1609
1610 Integer and memory overflow fixes for display code.
1611 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1612 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1613 (scrolling_window): Check for overflow in size calculations.
1614 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1615 Don't assume glyph table len fits in int.
1616 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1617 (row_table_size): Now ptrdiff_t, not int.
1618 (scrolling_window): Avoid overflow in size calculations.
1619 Don't update size until allocation succeeds.
1620 * fns.c (concat): Check for overflow in size calculations.
1621 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1622 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1623 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1624
1625 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1626 (get_doc_string): Check for size calculation overflow.
1627 Don't update size until allocation succeeds.
1628 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1629 EMACS_INT, where ptrdiff_t will do.
1630 (Fsubstitute_command_keys): Check for string overflow.
1631
1632 * editfns.c (set_time_zone_rule): Don't assume environment length
1633 fits in int.
1634 (message_length): Now ptrdiff_t, not int.
1635 (Fmessage_box): Don't update size until allocation succeeds.
1636 Don't assume message length fits in int.
1637 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1638
0065d054
PE
1639 * emacs.c (main): Do not reallocate argv, since there is a null at
1640 the end that can be overwritten, and this way there's no need to
1641 worry about size-calculation overflow.
1642 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1643
1644 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1645 alloc succeeds.
1646 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1647
1648 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1649 (x_set_scroll_bar_width, x_figure_window_size):
1650 Check for integer overflow.
1651 (x_set_alpha): Do not assume XINT fits in int.
1652
1653 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1654 This is for the members text_lines, text_cols, total_lines, total_cols,
1655 where the system imposes an 'int' limit.
1656
1657 * fringe.c (Fdefine_fringe_bitmap):
1658 Don't update size until alloc works.
1659
1660 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1661 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1662
1663 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1664 Check for size-calculation overflow.
1665 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1666 do, as we prefer signed integers.
1667 (id_to_widget.max_size, id_to_widget.used)
1668 (xg_store_widget_in_map, xg_remove_widget_from_map)
1669 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1670 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1671 Use and return ptrdiff_t, not int.
1672 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1673 * gtkutil.h: Change prototypes to match the above.
1674
1675 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1676 are duplicate now that they've been promoted to lisp.h.
1677 (x_allocate_bitmap_record, x_alloc_image_color)
1678 (make_image_cache, cache_image, xpm_load):
1679 Don't update size until alloc is done.
1680 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1681 (x_detect_edges):
3256efce 1682 Check for size calculation overflow.
726e0ab1
PE
1683 (ct_colors_allocated_max): New constant.
1684 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1685 overflow.
3256efce 1686
726e0ab1
PE
1687 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1688 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1689 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1690 Use ptrdiff_t, not int, to count maps.
1691 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1692 calculations. Don't update size until allocation succeeds.
1693 Redo calculations to avoid overflow.
726e0ab1
PE
1694 * keyboard.h: Change prototypes to match the above.
1695
1696 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1697 to count maps.
1698 (current_minor_maps): Check for size calculation overflow.
1699 * keymap.h: Change prototypes to match the above.
1700
1701 * lread.c (read1, init_obarray): Don't update size until alloc done.
1702
1703 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1704 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1705
726e0ab1
PE
1706 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1707 Now ptrdiff_t, not int.
1708 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1709 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1710
1711 * process.c (Fnetwork_interface_list): Check for overflow
1712 in size calculation.
1713
1714 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1715
1716 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1717 overflow. Don't bother calling xmalloc when xrealloc will do.
1718
1719 * search.c (Freplace_match): Check for size calculation overflow.
1720 (Fset_match_data): Don't assume list lengths fit in 'int'.
1721
1722 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1723 for command line length. Do not attempt to address one before the
1724 beginning of an array, as that's not portable.
1725
1726 * term.c (max_frame_lines): Remove; unused.
1727 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1728 not int.
1729 (encode_terminal_code, calculate_costs): Check for size
1730 calculation overflow.
1731 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1732 table lengths and related sizes. Don't update size until alloc
1733 done. Redo calculations to avoid overflow.
1734 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1735
1736 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1737 subtracting pointers.
1738 (gobble_line): Check for overflow more carefully. Don't update size
1739 until alloc done.
1740
1741 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1742 Don't update size until alloc done.
1743 Redo size calculations to avoid overflow.
1744 Check for size calculation overflow.
0065d054 1745 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1746
1747 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1748 Use ptrdiff_t, not int, for sizes.
1749 (store_mode_line_noprop_char): Don't update size until alloc done.
1750
0065d054
PE
1751 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1752 Use ptrdiff_t, not int, for sizes.
1753 (Finternal_make_lisp_face, cache_face):
1754 Check for size calculation overflow.
1755 (cache_face): Treat size calculation overflows as if they were
1756 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1757
1758 * xfns.c (x_encode_text, x_set_name_internal)
1759 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1760 sizes, since they can exceed INT_MAX in size. Check for size
1761 calculation overflow.
1762
0065d054
PE
1763 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1764 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1765 Don't update size until alloc done.
1766
0065d054 1767 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1768 as sprintf is limited to int lengths.
1d526e2f 1769
252c5ee1
PE
1770 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1771 (X_LONG_MIN): New macros.
864d7ce7
PE
1772 Use them to make the following changes clearer.
1773 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1774 This change doesn't affect the value now, but it may help remind
1775 future maintainers not to raise the value too much later.
1776 (SELECTION_QUANTUM): Remove, replacing with ...
1777 (selection_quantum): ... new function, which avoids overflow.
1778 All uses changed.
1779 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1780 assumption that selection length fits in 'int'.
1781 (x_reply_selection_request, x_handle_selection_request)
1782 (x_get_window_property, receive_incremental_selection)
1783 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1784 (lisp_data_to_selection_data, clean_local_selection_data):
1785 Use ptrdiff_t, not int, to record length of selection.
1786 (x_reply_selection_request, x_get_window_property)
1787 (receive_incremental_selection, x_property_data_to_lisp):
1788 Redo calculations to avoid overflow.
1789 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1790 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1791 something.
1792 (x_get_window_property, receive_incremental_selection)
1793 (lisp_data_to_selection_data, x_property_data_to_lisp):
1794 Check for size-calculation overflow.
1795 (x_get_window_property, receive_incremental_selection)
1796 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1797 Don't store size until memory allocation succeeds.
1798 (x_get_window_property): Plug memory leak on memory exhaustion.
1799 Don't double-block input; malloc is safe here. Don't assume 2**34
1800 - 4 fits in unsigned long. Add an xassert to check
1801 XGetWindowProperty overflow. Be more careful about overflow
1802 calculations, and distinguish size from memory overflow better.
1803 (receive_incremental_selection): When tracing, don't assume
1804 unsigned int is less than INT_MAX.
1805 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1806 harmful) conversions of unsigned short to int.
1807 (lisp_data_to_selection_data): Don't assume that integers
1808 in the range -65535 through -1 fit in an X unsigned short.
1809 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1810 result parameters unless successful. Rely on cons_to_unsigned
1811 to report problems with elements; the old code wasn't right anyway.
1812 (x_check_property_data): Check for int overflow; we cannot use
1813 a wider type due to X limits.
1814 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1815
726e0ab1 1816 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1817
0065d054
PE
1818 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1819 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1820 (x_color_cells): Don't store size until memory allocation succeeds.
1821 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1822 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1823 (x_term_init): Don't assume length fits in int (sprintf is limited
1824 to int size).
bc18e09d 1825
ebfa62c0
PE
1826 Use ptrdiff_t for composition IDs.
1827 * character.c (lisp_string_width):
1828 * composite.c (composition_table_size, n_compositions)
1829 (get_composition_id, composition_gstring_from_id):
1830 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1831 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1832 * window.c (Frecenter):
1833 Use ptrdiff_t, not int, for composition IDs.
1834 * composite.c (get_composition_id): Check for integer overflow.
1835 * composite.h: Adjust prototypes to match the above changes.
1836
d3411f89
PE
1837 Use ptrdiff_t for hash table indexes.
1838 * category.c (hash_get_category_set):
1839 * ccl.c (ccl_driver):
1840 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1841 * coding.c (coding_system_charset_list, detect_coding_system):
1842 * coding.h (struct coding_system.id):
1843 * composite.c (get_composition_id, gstring_lookup_cache):
1844 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1845 * image.c (xpm_get_color_table_h):
1846 * lisp.h (hash_lookup, hash_put):
1847 * minibuf.c (Ftest_completion):
1848 Use ptrdiff_t for hash table indexes, not int (which is too
1849 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1850 32-bit --with-wide-int hosts).
1851
e097a6fa
PE
1852 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1853 Add a FIXME comment about memory leaks.
1854 (syms_of_charset): Don't assume xmalloc returns.
1855
5637687f
PE
1856 Don't assume that stated character widths fit in int.
1857 * character.c (Fchar_width, c_string_width, lisp_string_width):
1858 * character.h (CHAR_WIDTH):
1859 * indent.c (MULTIBYTE_BYTES_WIDTH):
1860 Use sanitize_char_width to avoid undefined and/or bad behavior
1861 with outlandish widths.
a66cfb1c 1862 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1863 now that we have two such functions. All uses changed.
1864 (sanitize_char_width): New inline function.
1865
a2271ba2
PE
1866 Don't assume that tab-width fits in int.
1867 * character.h (sanitize_width): New inline function.
1868 (SANE_TAB_WIDTH): New macro.
1869 (ASCII_CHAR_WIDTH): Use it.
1870 * indent.c (sane_tab_width): Remove. All uses replaced by
1871 SANE_TAB_WIDTH (current_buffer).
1872 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1873
18c52557
PE
1874 * fileio.c: Integer overflow issues with file modes.
1875 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1876
caeeedc1
PE
1877 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1878 Remove unreachable code.
1879 (read_hex, load_charset_map_from_file): Check for integer overflow.
1880
50849c52
PE
1881 * xterm.c: don't go over XClientMessageEvent limit
1882 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1883 (x_send_scroll_bar_event): Likewise. Check that the size does not
1884 exceed limits imposed by XClientMessageEvent, as well as the usual
1885 ptrdiff_t and size_t limits.
1886
b13995db
PE
1887 * keyboard.c: Overflow, signedness and related fixes.
1888 (make_lispy_movement): Use same integer type in forward decl
1889 that is used in the definition.
1890 (read_key_sequence, keyremap_step):
1891 Change bufsize argument back to int, undoing my 2011-03-30 change.
1892 We prefer signed types, and int is wide enough here.
1893 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1894 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1895 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1896 length, not size_t. Use ptrdiff_t for index, not int.
1897 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1898 possibility of integer overflow.
1899
13464394
PE
1900 Overflow, signedness and related fixes for images.
1901
1902 * dispextern.h (struct it.stack[0].u.image.image_id)
1903 (struct_it.image_id, struct image.id, struct image_cache.size)
1904 (struct image_cache.used, struct image_cache.ref_count):
1905 * gtkutil.c (update_frame_tool_bar):
1906 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1907 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1908 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1909 * nsmenu.m (update_frame_tool_bar):
1910 * xdisp.c (calc_pixel_width_or_height):
1911 * xfns.c (image_cache_refcount):
1912 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1913 on typical 64-bit hosts.
1914
1915 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1916 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1917 Omit unnecessary casts to int.
1918 (parse_image_spec): Check that integers fall into 'int' range
1919 when the callers expect that.
1920 (image_ascent): Redo ascent calculation to avoid int overflow.
1921 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1922 (lookup_image): Remove unnecessary tests.
1923 (xbm_image_p): Locals are now of int, not EMACS_INT,
1924 since parse_image_check makes sure they fit into int.
1925 (png_load, gif_load, svg_load_image):
1926 Prefer int to unsigned where either will do.
1927 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1928 old tiff_error_handler and tiff_warning_handler.
1929 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1930 stack buffer overflows. It uses only the features of vsnprintf
1931 that are common to both POSIX and native Microsoft.
1932 (tiff_error_handler, tiff_warning_handler): Use it.
1933 (tiff_load, gif_load, imagemagick_load_image):
1934 Don't assume :index value fits in 'int'.
1935 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1936 (imagemagick_load_image): Check that crop parameters fit into
1937 the integer types that MagickCropImage accepts. Don't assume
1938 Vimagemagick_render_type has a nonnegative value. Don't assume
1939 size_t fits in 'long'.
1940 (gs_load): Use printmax_t to print the widest integers possible.
1941 Check for integer overflow when computing image height and width.
1942
c11821d4
EZ
19432011-08-26 Eli Zaretskii <eliz@gnu.org>
1944
1945 * xdisp.c (redisplay_window): Don't force window start if point
1946 will be invisible in the resulting window. (Bug#9324)
1947
0c95fcf7
EZ
19482011-08-25 Eli Zaretskii <eliz@gnu.org>
1949
1950 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1951 the display spec is of the form `(space ...)'.
1952 (handle_display_spec): Return the value returned by
1953 handle_single_display_spec, not just 1 or zero.
1954 (handle_single_display_spec): If the display spec is of the form
1955 `(space ...)', and specifies display in the text area, return 2
1956 rather than 1.
fee65a97 1957 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1958 accurately, and prefer exact match for point under bidi.
1959 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1960
1961 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1962 into disp_prop; all users changed.
1963
1964 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1965 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1966 for the text covered by the display property.
1967
e4ed06f1
CY
19682011-08-25 Chong Yidong <cyd@stupidchicken.com>
1969
1970 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1971 Change return value to nil.
1972 (Frecord_buffer): Delete unused function.
1973
f67cdd7f
EZ
19742011-08-24 Eli Zaretskii <eliz@gnu.org>
1975
5980d4c6
EZ
1976 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1977 buffers, return left-to-right.
8610fe8b
EZ
1978 (set_cursor_from_row): Consider candidate row a win if its glyph
1979 represents a newline and point is on that newline. Fixes cursor
1980 positioning on the newline at EOL of R2L text within L2R
1981 paragraph, and vice versa.
1982 (try_cursor_movement): Check continued rows, in addition to
1983 continuation rows. Fixes unwarranted scroll when point enters a
1984 continued line of R2L text within an L2R paragraph, or vice versa.
1985 (cursor_row_p): Consider the case of point being equal to
1986 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1987 from the end of a short line to the beginning of a continued line
1988 of R2L text within L2R paragraph.
1989 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1990 composed characters.
5980d4c6 1991
f67cdd7f
EZ
1992 * bidi.c (bidi_check_type): Use xassert.
1993 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1994 members.
1995
bca633fb
EZ
19962011-08-23 Eli Zaretskii <eliz@gnu.org>
1997
1998 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1999 a character.
2000
4a5885a7
CY
20012011-08-23 Chong Yidong <cyd@stupidchicken.com>
2002
2003 * nsfont.m (ns_otf_to_script): Fix typo.
2004
0902a04e
KH
20052011-08-22 Kenichi Handa <handa@m17n.org>
2006
2007 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2008 extra slot even if the purpose is char-code-property-table.
2009
1a2e6670
EZ
20102011-08-23 Eli Zaretskii <eliz@gnu.org>
2011
8ddde651
EZ
2012 * xdisp.c (redisplay_window): When computing centering_position,
2013 account for the height of the header line. (Bug#8874)
2014
425cc014
EZ
2015 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2016 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2017 candidate is selected by the mouse, and that candidate has a
2018 composed character under the mouse.
2019
1a2e6670
EZ
2020 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2021 coordinates reported by pos-visible-in-window-p for a composed
2022 character in column zero.
2023
8b76d6f8
SM
20242011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2025
2026 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2027
dac347dd
EZ
20282011-08-22 Eli Zaretskii <eliz@gnu.org>
2029
2030 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2031 consider it a hit if to_charpos is anywhere in the range of the
2032 composed buffer positions.
2033
e013fb34
CY
20342011-08-22 Chong Yidong <cyd@stupidchicken.com>
2035
2036 * image.c (gif_load): Don't assume that each subimage has the same
2037 dimensions as the base image. Handle disposal method that is
2038 "undefined" by the gif spec (Bug#9335).
2039
bd1ba3e8
CY
20402011-08-20 Chong Yidong <cyd@stupidchicken.com>
2041
2042 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2043 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2044
54a1215b
EZ
20452011-08-19 Eli Zaretskii <eliz@gnu.org>
2046
823564e5
EZ
2047 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2048 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2049 from an Org mode buffer to a Speedbar frame.
2050
54a1215b
EZ
2051 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2052 a composition, take its buffer position from IT->cmp_it.charpos.
2053 Fixes cursor positioning at the beginning of a line that begins
2054 with a composed character.
2055
9778ebcc
EZ
20562011-08-18 Eli Zaretskii <eliz@gnu.org>
2057
0be6ee06
EZ
2058 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2059 character bidirectional type, use STRONG_L instead. Fixes crashes
2060 in a buffer produced by `describe-categories'.
2061
9778ebcc
EZ
2062 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2063 members before the level stack, so they would be saved and
2064 restored when copying iterator state. Fixes incorrect reordering
2065 around TABs covered by display properties.
2066
156bffbe
AS
20672011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2068
6b02f655 2069 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2070
72ad093b
CY
20712011-08-17 Chong Yidong <cyd@stupidchicken.com>
2072
2073 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2074 (internal_condition_case_2, internal_condition_case_n):
2075 Remove unnecessary aborts (Bug#9081).
72ad093b 2076
35774242
EZ
20772011-08-17 Eli Zaretskii <eliz@gnu.org>
2078
2079 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2080 has no `load' handler, try opening the file locally. (Bug#9311)
2081
db76dd85
KB
20822011-08-16 Ken Brown <kbrown@cornell.edu>
2083
2084 * gmalloc.c: Expand comment.
2085
b215eee5
EZ
20862011-08-16 Eli Zaretskii <eliz@gnu.org>
2087
2088 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2089 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2090
a4579d33
KB
20912011-08-16 Ken Brown <kbrown@cornell.edu>
2092
2093 Fix memory allocation problems in Cygwin build (Bug#9273).
2094
2095 * unexcw.c ( __malloc_initialized): Declare external variable.
2096 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2097
8b76d6f8
SM
2098 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2099 New variables.
a4579d33
KB
2100 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2101 dumped emacs.
2102 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2103 in the static heap.
2104 [CYGWIN] (special_realloc): New function.
2105 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2106 requests to realloc storage in the static heap.
2107
3ebec551
PE
21082011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 * bidi.c (bidi_initialize): Remove unused local.
2111
9fd8be00
EZ
21122011-08-15 Eli Zaretskii <eliz@gnu.org>
2113
6b02f655
SM
2114 * bidimirror.h:
2115 * biditype.h: Remove file.
2116 * makefile.w32-in ($(BLD)/bidi.$(O)):
2117 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2118
2119 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2120
2121 * chartab.c: Improve commentary for the uniprop_table API.
2122
32413314
EZ
2123 * bidi.c (bidi_paragraph_init): Support zero value of
2124 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2125 (bidi_initialize): Use uniprop_table instead of including
2126 biditype.h and bidimirror.h.
32413314 2127
9fd8be00
EZ
2128 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2129 coordinates of the iterator when restoring from ppos_it.
2130 (Bug#9296)
2131
5cf2b69b
KH
21322011-08-14 Kenichi Handa <handa@m17n.org>
2133
2134 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2135 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2136
daf17d00
EZ
21372011-08-14 Eli Zaretskii <eliz@gnu.org>
2138
2139 * xdisp.c (move_it_in_display_line_to): Don't invoke
2140 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2141 ppos_it. Fixes vertical cursor motion when line beginning is
2142 covered by an image. (Bug#9296)
2143
08e3161a
JD
21442011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2145
2146 * nsterm.h (ns_run_ascript): Declare.
2147 (NSAPP_DATA2_RUNASSCRIPT): Define.
2148
2149 * nsfns.m (as_script, as_result, as_status): New static variables.
2150 (ns_run_ascript): New function.
5e617bc2 2151 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2152 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2153 the event loop. Get status from as_status (Bug#7276).
2154
2155 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2156 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2157 the event loop (Bug#7276).
2158
a3720aa2
AS
21592011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2160
2161 * gnutls.c (QCgnutls_bootprop_priority)
2162 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2163 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2164 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2165 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2166 (QCgnutls_bootprop_verify_hostname_error)
2167 (QCgnutls_bootprop_callbacks_verify): Rename from
2168 Qgnutls_bootprop_..., all uses changed.
2169
2170 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2171 uses changed.
2172
0a0d27fb
PE
21732011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2174
19d5c50c
PE
2175 * xfaces.c (Qframe_set_background_mode): Now static.
2176 * dispextern.h (Qframe_set_background_mode): Remove decl.
2177
0a0d27fb
PE
2178 * process.c (Fnetwork_interface_info): Declare local only if needed.
2179
377538cb
JD
21802011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2181
2182 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2183 (Fnetwork_interface_list): Allocate in increments of bytes instead
2184 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2185 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2186 sockaddr.
2187 (struct ifflag_def): notrailers is smart on OSX.
2188 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2189 Get hardware address with getifaddrs if available.
2190
08fff70c
EZ
21912011-08-12 Eli Zaretskii <eliz@gnu.org>
2192
2193 * xdisp.c (iterate_out_of_display_property): xassert that
2194 IT->position is set to within IT->object's boundaries. Break from
2195 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2196 when IT->position is set up wrongly due to some bug.
2197 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2198 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2199 entry. Force push_it to save on the stack the current
2200 buffer/string position, to be restored by pop_it. Fix flags in
2201 the iterator structure wrt the object coming from a display
2202 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2203 properties. (Bug#9284)
2204
7be1c708 22052011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2206
7be1c708
CY
2207 * fontset.c (fontset_get_font_group): Add proper type checks.
2208 (Bug#9172)
aac0c6e3 2209
7be1c708 22102011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2211
7be1c708
CY
2212 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2213 and LC_VERSION_MIN_MACOSX.
2214 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2215 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2216
97bb72a6
EZ
22172011-08-08 Eli Zaretskii <eliz@gnu.org>
2218
2219 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2220 no-display-properties-and-no-overlays under bidi display.
2221 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2222 properties and overlays.
97bb72a6 2223
d5617611
CY
22242011-08-08 Chong Yidong <cyd@stupidchicken.com>
2225
37e11a63
CY
2226 * editfns.c (Fset_time_zone_rule): Document relationship with the
2227 setenv function.
2228
d5617611
CY
2229 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2230 the font entity extracted from the cache (Bug#8109).
2231
58872834
CY
22322011-08-07 Chong Yidong <cyd@stupidchicken.com>
2233
2234 * composite.c (autocmp_chars): Don't reset point. That is done by
2235 restore_point_unwind (Bug#5984).
2236
75bfc667
JL
22372011-08-07 Juri Linkov <juri@jurta.org>
2238
2239 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2240 to show the arg `TIME' instead of `TIMEVAL'.
2241
d1410150
EZ
22422011-08-06 Eli Zaretskii <eliz@gnu.org>
2243
2244 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2245 display property strides EOL and includes a newline, as in
2246 longlines-mode. (Bug#9254)
75b771e4
EZ
2247 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2248 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2249
2250 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2251 is non-zero, even if the data buffer is NULL. Fixes a crash in
2252 vertical-motion with longlines-mode. (Bug#9254)
2253
35928349
EZ
22542011-08-05 Eli Zaretskii <eliz@gnu.org>
2255
ec7cc85b
EZ
2256 * bidi.c <bidi_cache_total_alloc>: Now static.
2257 (bidi_initialize): Initialize bidi_cache_total_alloc.
2258
8b76d6f8 2259 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2260 cache. (Bug#9221)
2261
2262 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2263 amount allocated this far in `bidi_cache_total_alloc'.
2264 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2265 non-zero, only free the data buffer without restoring the cache
2266 contents. All callers changed.
2267
2268 * dispextern.h (bidi_unshelve_cache): Update prototype.
2269
2270 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2271 (move_it_in_display_line, move_it_to)
2272 (move_it_vertically_backward, move_it_by_lines): Replace the call
2273 to xfree to an equivalent call to bidi_unshelve_cache.
2274 (move_it_in_display_line_to): Fix logic of returning
412b6358 2275 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2276
e2e2423b
EZ
22772011-08-05 Eli Zaretskii <eliz@gnu.org>
2278
2279 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2280 came from a string character with a `cursor' property. (Bug#9229)
2281
ae9e757a
JD
22822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2283
2284 * Makefile.in (LIB_PTHREAD): New variable.
2285 (LIBES): Add LIB_PTHREAD (Bug#9216).
2286
2287 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2288 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2289
213bd7f2
AS
22902011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2291
6b02f655 2292 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2293
99aaf75f
JD
22942011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2295
2296 * xterm.c (x_find_topmost_parent): New function.
2297 (x_set_frame_alpha): Find topmost parent window with
2298 x_find_topmost_parent and set the property there also (bug#9181).
2299 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2300
c74e9d86
PE
23012011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * callproc.c (Fcall_process): Avoid vfork clobbering
2304 the local vars buffer, coding_systems, current_dir.
2305
640c8776
SM
23062011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2307
2308 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2309
f26d0e4c
PE
23102011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2311
8a10d76c
PE
2312 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2313 so that it is not optimized away.
2314
f26d0e4c
PE
2315 * xdisp.c (compute_display_string_pos): Remove unused local.
2316
55439c61
EZ
23172011-08-02 Eli Zaretskii <eliz@gnu.org>
2318
2319 Fix slow cursor motion and scrolling in large buffers with
2320 selective display, like Org Mode buffers. (Bug#9218)
2321
2322 * dispextern.h (struct bidi_it): New member disp_prop_p.
2323
2324 * xdisp.c: Remove one-slot cache of display string positions.
2325 (compute_display_string_pos): Accept an additional argument
5e617bc2 2326 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2327 for a display string or property. If found, set DISP_PROP_P
2328 non-zero.
2329
2330 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2331 DISP_PROP_P, and pass it to compute_display_string_pos.
2332 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2333 non-zero. All callers of bidi_fetch_char changed.
2334
fb33fa43
SM
23352011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2336
2337 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2338
b099e063
DM
23392010-12-03 Don March <don@ohspite.net>
2340
2341 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2342 last character M-[char] is translated to ESC [char] (bug#7541).
2343
5cc7f7af
KH
23442011-08-02 Kenichi Handa <handa@m17n.org>
2345
d0fffa3f 2346 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2347
2348 * chartab.c (uniprop_table): Make it non-static.
2349
525d5e6e
EZ
23502011-08-01 Eli Zaretskii <eliz@gnu.org>
2351
2352 * xdisp.c (forward_to_next_line_start): Accept additional argument
2353 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2354 on the newline.
2355 (reseat_at_next_visible_line_start): Use the bidi iterator state
2356 returned by forward_to_next_line_start to restore the state of
2357 it->bidi_it after backing up to previous newline. (Bug#9212)
2358
31011111
AS
23592011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2360
2361 * regex.c (re_comp): Protoize.
2362 (re_exec): Fix return type.
2363 (regexec): Fix type of `ret'. (Bug#9203)
2364
476371c4
PE
23652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2366
e5d76069
PE
2367 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2368 This is needed if max-image-size is a floating-point number.
2369
9a79b20c
AS
23702011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2371
2372 * print.c (print_object): Print empty symbol as ##.
2373
2374 * lread.c (read1): Read ## as empty symbol.
2375
d8c2fa78
AA
23762011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2377
2378 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2379 setting frame foreground color (Bug#9175).
2380 (x_set_background_color): Likewise.
2381
ffe57a7a
AA
2382 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2383 contents (Bug#9176).
2384 (EmacsTooltip -init): Remove bezels and add shadows to
2385 tooltip windows.
2386
bf3492a5
AA
2387 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2388 or scroll bar (Bug#8470).
2389
d55e9c53
AA
2390 * nsfont.m (nsfont_open): Remove assignment to voffset and
2391 unnecessary vars hshink, expand, hd, full_height, min_height.
2392 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2393
2394 * nsterm.h (nsfont_info): Remove voffset field.
2395
d8c2fa78 23962011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2397
2398 Implement strike-through and overline on NextStep (Bug#8863).
2399
2400 * nsfont.m (nsfont_open): Use underline position provided by font,
2401 instead of hard-coded value of 2.
2402 (nsfont_draw): Call ns_draw_text_decoration instead.
2403
2404 * nsterm.h: Add declaration for ns_draw_text_decoration.
2405
2406 * nsterm.m (ns_draw_text_decoration): New function for drawing
2407 underline, overline, and strike-through.
2408 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2409 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2410 accommodate underlining, etc.
4843aac3 2411
4cc60b9b
EZ
24122011-07-28 Eli Zaretskii <eliz@gnu.org>
2413
bc7ece87
EZ
2414 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2415 default.
4cc60b9b 2416
476371c4
PE
24172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2418
66606eea
PE
2419 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2420 Without this fix, if a signal arrives just after memory fills up,
2421 'malloc' might be invoked reentrantly.
2422
476371c4
PE
2423 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2424 In other words, assume that every image size is allowed, on non-X
2425 hosts. This assumption is probably wrong, but it lets Emacs compile.
2426
f3fcc40d
AS
24272011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2428
2429 * regex.c (re_iswctype): Convert return values to boolean.
2430
350c992f
EZ
24312011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2432
2433 * xdisp.c (compute_display_string_pos): Don't use cached display
2434 string position if the buffer had its restriction changed.
2435 (Bug#9184)
2436
5266b4bb
PE
24372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2440
2573a837 24412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2442
41f55ccd 2443 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2444
39e378da
PE
2445 * bidi.c: Integer size and overflow fixes.
2446 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2447 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2448 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2449 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2450 (bidi_find_other_level_edge):
2451 Use ptrdiff_t instead of EMACS_INT where either will do.
2452 This works better on 32-bit hosts configured --with-wide-int.
2453 (bidi_cache_ensure_space): Check for size-calculation overflow.
2454 Use % rather than repeated addition, for better worst-case speed.
2455 Don't set bidi_cache_size until after xrealloc returns, because it
2456 might not return.
2457 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2458 (bidi_cache_ensure_space): Also check that the bidi cache size
2459 does not exceed that of the largest Lisp string or buffer. See Eli
2460 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2461
5e927815
PE
2462 * alloc.c (__malloc_size_t): Remove.
2463 All uses replaced by size_t. See Andreas Schwab's note
2464 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2465
ca4aa935
PE
2466 * image.c: Improve checking for integer overflow.
2467 (check_image_size): Assume that f is nonnull, since
2468 it is always nonnull in practice. This is one less thing to
2469 worry about when checking for integer overflow later.
2470 (x_check_image_size): New function, which checks for integer
2471 overflow issues inside X.
2472 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2473 This removes the need for a memory_full check.
2474 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2475 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2476 (xbm_read_bitmap_data): Change locals back to 'int', since
2477 their values must fit in 'int'.
2478 (xpm_load_image, png_load, tiff_load):
2479 Invoke x_create_x_image_and_pixmap earlier,
2480 to avoid much needless work if the image is too large.
2481 (tiff_load): Treat overly large images as if
2482 x_create_x_image_and_pixmap failed, not as malloc failures.
2483 (gs_load): Use x_check_image_size.
2484
5f8f9cc2
PE
2485 * gtkutil.c: Omit integer casts.
2486 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2487 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2488
5adf60bc
PE
2489 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2490
c8907a93
PE
2491 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2492 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2493 would wrongly return t on a 64-bit host.
2494
e3c25c68
PE
2495 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2496 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2497 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2498 and therefore cause GCC to emit a bogus diagnostic in some cases.
2499
3f791afe
PE
2500 * image.c: Integer signedness and overflow and related fixes.
2501 This is not an exhaustive set of fixes, but it's time to
2502 record what I've got.
2503 (lookup_pixel_color, check_image_size): Remove redundant decls.
2504 (check_image_size): Don't assume that arbitrary EMACS_INT values
2505 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2506 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2507 (tiff_load, imagemagick_load_image):
2508 Check for overflow in size calculations.
2509 (x_create_x_image_and_pixmap): Remove unnecessary test for
2510 xmalloc returning NULL; that can't happen.
2511 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2512 (xpm_color_bucket): Use better integer hashing function.
2513 (xpm_cache_color): Don't possibly over-allocate memory.
2514 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2515 (gif_memory_source):
2516 Use ptrdiff_t, not int or size_t, to record sizes.
2517 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2518 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2519 either works, as we prefer signed integers.
2520 (tiff_read_from_memory, tiff_write_from_memory):
2521 Return tsize_t, not size_t, since that's what the TIFF API wants.
2522 (tiff_read_from_memory): Don't fail simply because the read would
2523 go past EOF; instead, return a short read.
2524 (tiff_load): Omit no-longer-needed casts.
2525 (Fimagemagick_types): Don't assume size fits into 'int'.
2526
3cc5a532
PE
2527 Improve hashing quality when configured --with-wide-int.
2528 * fns.c (hash_string): New function, taken from sxhash_string.
2529 Do not discard information about ASCII character case; this
2530 discarding is no longer needed.
2531 (sxhash-string): Use it. Change sig to match it. Caller changed.
2532 * lisp.h: Declare it.
2533 * lread.c (hash_string): Remove, since we now use fns.c's version.
2534 The fns.c version returns a wider integer if --with-wide-int is
2535 specified, so this should help the quality of the hashing a bit.
2536
b312a492
PE
2537 * emacs.c: Integer overflow minor fix.
2538 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2539 Define only if GNU_LINUX.
2540 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2541
dfd153ae
PE
2542 * dispnew.c: Integer signedness and overflow fixes.
2543 Remove unnecessary forward decls, that were a maintenance hassle.
2544 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2545 All uses changed.
2546 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2547 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2548 (prepare_desired_row, line_draw_cost):
2549 Use int, not unsigned, where either works.
2550 (save_current_matrix, restore_current_matrix):
2551 Use ptrdiff_t, not size_t, where either works.
2552 (init_display): Check for overflow more accurately, and without
2553 relying on undefined behavior.
2554
a81d11a3
PE
2555 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2556 Remove, replacing with the new symbols in lisp.h. All uses changed.
2557 * fileio.c (make_temp_name):
2558 * filelock.c (lock_file_1, lock_file):
2559 * xdisp.c (message_dolog):
2560 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2561 Use pMd etc. instead.
2562 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2563 replacing the pWIDE etc. symbols removed from editfns.c.
2564
3300e6fd
PE
2565 * keyboard.h (num_input_events): Now uintmax_t.
2566 This is (very slightly) less likely to mess up due to wraparound.
2567 All uses changed.
2568
fd05c7e9
PE
2569 * buffer.c: Integer signedness fixes.
2570 (alloc_buffer_text, enlarge_buffer_text):
2571 Use ptrdiff_t rather than size_t when either will do, as we prefer
2572 signed integers.
2573
903fe15d
PE
2574 * alloc.c: Integer signedness and overflow fixes.
2575 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2576 (__malloc_size_t): Default to size_t, not to int.
2577 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2578 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2579 Prefer ptrdiff_t to size_t when either would do, as we prefer
2580 signed integers.
2581 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2582 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2583 Now const. Initialize with values that are in range even if char
2584 is signed.
2585 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2586 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2587 These functions do the right thing with sizes > 2**32.
2588 (check_depth): Now ptrdiff_t, not int.
2589 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2590 Adjust to new way of storing sizes. Check for size overflow bugs
2591 in rest of code.
2592 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2593 slightly wrong anyway, as it missed one instance of
2594 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2595 (refill_memory_reserve): Omit needless cast to size_t.
2596 (mark_object_loop_halt): Mark as externally visible.
2597
ac82cc6a
PE
2598 * xselect.c: Integer signedness and overflow fixes.
2599 (Fx_register_dnd_atom, x_handle_dnd_message):
2600 Use ptrdiff_t, not size_t, since we prefer signed.
2601 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2602 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2603 x_dnd_atoms_size and x_dnd_atoms_length.
2604
c2d1e36d
PE
2605 * doprnt.c: Prefer signed to unsigned when either works.
2606 * eval.c (verror):
2607 * doprnt.c (doprnt):
2608 * lisp.h (doprnt):
2609 * xdisp.c (vmessage):
2610 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2611 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2612 prefer signed arithmetic to avoid comparison confusion.
2613 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2614 but is a bit tricky.
2615
0e926e56
PE
2616 Assume freestanding C89 headers, string.h, stdlib.h.
2617 * data.c, doprnt.c, floatfns.c, print.c:
2618 Include float.h unconditionally.
2619 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2620 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2621 * regex.c: Likewise for stddef.h, string.h.
2622 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2623 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2624 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2625 (STDC_HEADERS): Remove obsolete defines.
2626 * sysdep.c: Include limits.h unconditionally.
2627
9cfdb3ec
PE
2628 Assume support for memcmp, memcpy, memmove, memset.
2629 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2630 * regex.c (memcmp, memcpy):
2631 Remove; we assume C89 now.
2632
2633 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2634 (__malloc_safe_bcopy): Remove; no longer needed.
2635
cf950e6b 2636 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2637 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2638 well either way, and we prefer signed to unsigned.
2639
dbf38e02
LMI
26402011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2641
2642 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2643 closes the connection while we're reading (bug#9182).
2644
d6f0886c 26452011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2646
d6f0886c
JD
2647 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2648 are specified (Bug#9168).
24e0f6b1 2649
2eb1f9e6
PE
26502011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2651
2652 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2653 Found by GCC static checking and --with-wide-int on a 32-bit host.
2654
22381272 26552011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2656
2657 * xdisp.c (compute_display_string_pos): Fix logic of caching
2658 previous display string position. Initialize cached_prev_pos to
2659 -1. Fixes slow-down at the beginning of a buffer.
2660
f25e39b4
EZ
26612011-07-24 Eli Zaretskii <eliz@gnu.org>
2662
2663 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2664 for attrs[LFACE_FONTSET_INDEX].
2665
04c4b52e
PE
26662011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 * xml.c (parse_region): Remove unused local
2669 that was recently introduced.
2670
c1734fbd
EZ
26712011-07-23 Eli Zaretskii <eliz@gnu.org>
2672
be18c5a5
EZ
2673 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2674 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2675
c1734fbd
EZ
2676 * xdisp.c (move_it_in_display_line_to): Record the best matching
2677 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2678 exit if none of the characters scanned was an exact match.
2679 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2680 when exact match is impossible due to invisible text, and the
2681 lines are truncated.
2682
a258d627
JD
26832011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2684
2685 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2686 for OSX >= 10.7.
2687
b6d5a689
EZ
26882011-07-22 Eli Zaretskii <eliz@gnu.org>
2689
0f74f785
EZ
2690 Fix a significant slow-down of cursor motion with C-n, C-p,
2691 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2692 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2693 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2694 (next_element_from_buffer): Call compute_stop_pos_backwards to
2695 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2696 base_level_stop.
2697 (reseat): Don't look for prev_stop, as that could mean a very long
2698 run.
2699 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2700 <cached_disp_overlay_modiff>: Cache for last found display string
2701 position.
551918c1 2702 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2703 about the same buffer in the same area of character positions, and
2704 the buffer wasn't changed since the time the display string
2705 position was cached.
551918c1 2706
b2d0c91a
EZ
27072011-07-22 Eli Zaretskii <eliz@gnu.org>
2708
2709 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2710 is an integer, which is important for empty lines. (Bug#9149)
2711
043604ee
CY
27122011-07-22 Chong Yidong <cyd@stupidchicken.com>
2713
2714 * frame.c (Fmodify_frame_parameters): In tty case, update the
2715 default face if necessary (Bug#4238).
2716
da4adb04
CY
27172011-07-21 Chong Yidong <cyd@stupidchicken.com>
2718
2719 * editfns.c (Fstring_to_char): No need to explain what a character
2720 is in the docstring (Bug#6576).
2721
9abd0532
LMI
27222011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2723
2724 * xml.c (parse_region): Make sure we always return a tree.
2725
36881d16
HK
27262011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2727
2728 * xml.c (parse_region): If a document contains only comments,
2729 return that, too.
2730
1e98674d
LMI
27312011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2732
2733 * xml.c (make_dom): Return comments, too.
2734
590bd467
PE
27352011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 Port to OpenBSD.
2738 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2739 and the surrounding thread.
2740 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2741 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2742 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2743 timer goes off.
2744 * s/openbsd.h (BROKEN_SIGIO): Define.
2745 * unexelf.c (unexec) [__OpenBSD__]:
2746 Don't update the .mdebug section of the Alpha COFF symbol table.
2747
f41628b2
LMI
27482011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2749
2750 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2751 (bug#8460).
2752
b59b67c5
PE
27532011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2754
15e3a074
PE
2755 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2756 This fixes some race conditions on the permissions of any newly
2757 created file.
2758
41bed37d
PE
2759 * alloc.c (valid_pointer_p): Use pipe, not open.
2760 This fixes some permissions issues when debugging.
2761
b59b67c5
PE
2762 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2763 If fchown fails to set both uid and gid, try to set just gid,
2764 as that is sometimes allowed. Adjust the file's mode to eliminate
2765 setuid or setgid bits that are inappropriate if fchown fails.
2766
925a6be7
SM
27672011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2768
2769 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2770 to compare Lisp_Objects.
2771 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2772 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2773 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2774
52968808
AS
27752011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2776
0a6a104b
AS
2777 * lread.c (read_integer): Unread even EOF character.
2778 (read1): Likewise. Properly record start position of symbol.
2779
52968808
AS
2780 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2781 symbol character follows.
2782
9e381cdd
PE
27832011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2784
2785 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2786 This works around a problem with the previous change to Fcopy_file.
2787 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2788 and without this change, GCC might complain about discarding
2789 fchown's return value.
2790
b5641435
JB
27912011-07-16 Juanma Barranquero <lekktu@gmail.com>
2792
2793 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2794
a8031457
PE
27952011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2796
2797 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2798
dd889327
LMI
27992011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2800
750c33f7
LMI
2801 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2802 it's used from the C level.
2803
dd889327
LMI
2804 * process.c: Use the same condition for POLL_FOR_INPUT in both
2805 keyboard.c and process.c (bug#1858).
2806
87e86684
LM
28072011-07-09 Lawrence Mitchell <wence@gmx.li>
2808
2809 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2810 (Fgnutls_boot): Use it.
2811
64348f40
AS
28122011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2813
2814 * doc.c (Fsubstitute_command_keys): Revert last change.
2815
1d698799
LMI
28162011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2817
f863868c
LMI
2818 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2819 quotes the next character, and doesn't affect other longer
2820 sequences (bug#8935).
2821
1d698799
LMI
2822 * lread.c (syms_of_lread): Clarify that is isn't only
2823 `eval-buffer' and `eval-defun' that's affected by
2824 `lexical-binding' (bug#8460).
2825
aa4b6df6
EZ
28262011-07-15 Eli Zaretskii <eliz@gnu.org>
2827
2828 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2829 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2830
5d856da6
PE
28312011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2832
ad6042bb
PE
2833 Fix minor problems found by static checking.
2834 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2835 (elsz): Now a signed constant, not a size_t var. We prefer signed
2836 types to unsigned, to avoid integer comparison confusion. Without
2837 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2838 "cannot optimize loop, the loop counter may overflow", a symptom
2839 of the confusion.
f00bbb22 2840 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2841 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2842
6468f31c
LMI
28432011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2844
49080b10
LMI
2845 * search.c (Fre_search_backward): Mention `case-fold-search' in
2846 all the re_search_* functions (bug#8138).
2847
6468f31c
LMI
2848 * keyboard.c (Fopen_dribble_file): Document when the file is
2849 closed (bug#8056).
2850
c965adc5
EZ
28512011-07-14 Eli Zaretskii <eliz@gnu.org>
2852
df9733bf
EZ
2853 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2854 bidi_cache_idx.
2855
0bb23927
EZ
2856 Support bidi reordering of display and overlay strings.
2857 * xdisp.c (compute_display_string_pos)
2858 (compute_display_string_end): Accept additional argument STRING.
2859 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2860 (reseat_to_string): Initialize bidi_it->string.s and
2861 bidi_it->string.schars.
2862 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2863 NULL (avoids a crash in bidi_paragraph_init).
2864 Initialize itb.string.lstring.
0bb23927
EZ
2865 (init_iterator): Call bidi_init_it only of a valid
2866 buffer position was specified. Initialize paragraph_embedding to
2867 L2R.
2868 (reseat_to_string): Initialize the bidi iterator.
2869 (display_string): If we need to ignore text properties of
2870 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2871 original value of -1 will not work with bidi.)
2872 (compute_display_string_pos): First arg is now struct
2873 `text_pos *'; all callers changed. Support display properties on
2874 Lisp strings.
2875 (compute_display_string_end): Support display properties on Lisp
2876 strings.
2877 (init_iterator, reseat_1, reseat_to_string): Initialize the
2878 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2879 when iterating on a string not from display properties).
640c8776
SM
2880 (compute_display_string_pos, compute_display_string_end):
2881 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2882 arrow keys.
2883 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2884 base_level_stop; instead, set base_level_stop to BEGV.
2885 Fixes crashes in vertical-motion.
0bb23927
EZ
2886 (next_element_from_buffer): Improve commentary for when
2887 the iterator is before prev_stop.
2888 (init_iterator): Initialize bidi_p from the default value of
2889 bidi-display-reordering, not from buffer-local value. Use the
2890 buffer-local value only if initializing for buffer iteration.
2891 (handle_invisible_prop): Support invisible properties on strings
2892 that are being bidi-reordered.
2893 (set_iterator_to_next): Support bidi reordering of C strings and
2894 Lisp strings.
2895 (next_element_from_string): Support bidi reordering of Lisp
2896 strings.
2897 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2898 (display_string): Support display of R2L glyph rows.
2899 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2900 (init_iterator): Don't initialize it->bidi_p for strings
2901 here.
2902 (reseat_to_string): Initialize it->bidi_p for strings here.
2903 (next_element_from_string, next_element_from_c_string)
2904 (next_element_from_buffer): Add xassert's for correspondence
2905 between IT's object being iterated and it->bidi_it.string
2906 structure.
2907 (face_before_or_after_it_pos): Support bidi iteration.
2908 (next_element_from_c_string): Handle the case of the first string
2909 character that is not the first one in the visual order.
2910 (get_visually_first_element): New function, refactored from common
2911 parts of next_element_from_buffer, next_element_from_string, and
2912 next_element_from_c_string.
2913 (tool_bar_lines_needed, redisplay_tool_bar)
2914 (display_menu_bar): Force left-to-right direction. Add a FIXME
2915 comment for making that be controlled by a user option.
2916 (push_it, pop_it): Save and restore the state of the
2917 bidi iterator. Save and restore the bidi_p flag.
2918 (pop_it): Iterate out of display property for string iteration as
2919 well.
2920 (iterate_out_of_display_property): Support iteration over strings.
2921 (handle_single_display_spec): Set up it->bidi_it for iteration
2922 over a display string, and call bidi_init_it.
2923 (handle_single_display_spec, next_overlay_string)
2924 (get_overlay_strings_1, push_display_prop): Set up the bidi
2925 iterator for displaying display or overlay strings.
2926 (forward_to_next_line_start): Don't use the shortcut if
2927 bidi-iterating.
2928 (back_to_previous_visible_line_start): If handle_display_prop
2929 pushed the iterator stack, restore the internal state of the bidi
2930 iterator by calling bidi_pop_it same number of times.
2931 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2932 and we are bidi-iterating, don't decrement the iterator position;
2933 instead, set the first_elt flag in the bidi iterator, to produce
2934 the same effect.
2935 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2936 (push_display_prop): xassert that we are iterating a buffer.
2937 (push_it, pop_it): Save and restore paragraph_embedding member.
2938 (handle_single_display_spec, next_overlay_string)
2939 (get_overlay_strings_1, reseat_1, reseat_to_string)
2940 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2941 correctly. Don't assume unibyte strings are not bidi-reordered.
2942 (compute_display_string_pos)
2943 (compute_display_string_end): Fix handling the case of C string.
2944 (push_it, pop_it): Save and restore from_disp_prop_p.
2945 (handle_single_display_spec, push_display_prop): Set the
2946 from_disp_prop_p flag.
2947 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2948 (pop_it): Call iterate_out_of_display_property only if we are
2949 popping after iteration over a string that came from a display
2950 property. Fix a typo in popping stretch info. Add an assertion
2951 for verifying that the iterator position is in sync with the bidi
2952 iterator.
2953 (handle_single_display_spec, get_overlay_strings_1)
2954 (push_display_prop): Fix initialization of paragraph direction for
2955 string when that of the parent object is not yet determined.
2956 (reseat_1): Call bidi_init_it to resync the bidi
2957 iterator with IT's position. (Bug#7616)
2958 (find_row_edges): If ROW->start.pos gives position
2959 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2960 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2961 Reset the from_disp_prop_p flag.
2962 (SAVE_IT, RESTORE_IT): New macros.
2963 (pos_visible_p, face_before_or_after_it_pos)
2964 (back_to_previous_visible_line_start)
2965 (move_it_in_display_line_to, move_it_in_display_line)
2966 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2967 (try_scrolling, redisplay_window, display_line): Use them when
2968 saving a temporary copy of the iterator and restoring it back.
2969 (back_to_previous_visible_line_start, reseat_1)
2970 (init_iterator): Empty the bidi cache "stack".
2971 (move_it_in_display_line_to): If iterator ended up at
2972 EOL, but we never saw any buffer positions smaller than
2973 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2974 motion in bidi-reordered lines.
2975 (move_it_in_display_line_to): Record prev_method and prev_pos
2976 immediately before the call to set_iterator_to_next. Fixes cursor
2977 motion in bidi-reordered lines with stretch glyphs and strings
2978 displayed in margins. (Bug#8133) (Bug#8867)
2979 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2980 TO_CHARPOS.
640c8776
SM
2981 (pos_visible_p): Support positions in bidi-reordered lines.
2982 Save and restore bidi cache.
0bb23927
EZ
2983
2984 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2985 (bidi_paragraph_info): Delete unused struct.
2986 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2987 (bidi_cache_start): New variable.
2988 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2989 to zero.
2990 (bidi_cache_fetch_state, bidi_cache_search)
2991 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2992 (bidi_cache_find, bidi_peek_at_next_level)
2993 (bidi_level_of_next_char, bidi_find_other_level_edge)
2994 (bidi_move_to_visually_next): Compare cache index with
2995 bidi_cache_start rather than with zero.
2996 (bidi_fetch_char): Accept new argument STRING; all callers
2997 changed. Support iteration over a string. Support strings with
2998 display properties. Support unibyte strings. Fix the type of
2999 `len' according to what STRING_CHAR_AND_LENGTH expects.
3000 (bidi_paragraph_init, bidi_resolve_explicit_1)
3001 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3002 (bidi_level_of_next_char, bidi_move_to_visually_next):
3003 Support iteration over a string.
0bb23927
EZ
3004 (bidi_set_sor_type, bidi_resolve_explicit_1)
3005 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3006 can now be zero (for strings); special values 0 and -1 were
3007 changed to -1 and -2, respectively.
3008 (bidi_char_at_pos): New function.
3009 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3010 Call it instead of FETCH_MULTIBYTE_CHAR.
3011 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3012 initialized to valid values.
3013 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3014 values.
3015 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3016 the test for valid cached positions. Fix the logic for looking up
3017 the sentinel state in the cache. GCPRO the Lisp string we are
3018 iterating.
3019 (bidi_push_it, bidi_pop_it): New functions.
3020 (bidi_initialize): Initialize the bidi cache start stack pointer.
3021 (bidi_cache_ensure_space): New function, refactored from part of
3022 bidi_cache_iterator_state. Don't assume the required size is just
3023 one BIDI_CACHE_CHUNK away.
3024 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3025 (bidi_count_bytes, bidi_char_at_pos): New functions.
3026 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3027 always valid if bidi_cache_idx is valid.
3028 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3029 is valid if it's going to be used.
3030 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3031 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3032 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3033 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3034 (bidi_find_other_level_edge, bidi_cache_start_stack):
3035 All variables related to cache indices are now EMACS_INT.
c965adc5 3036
0bb23927
EZ
3037 * dispextern.h (struct bidi_string_data): New structure.
3038 (struct bidi_it): New member `string'. Make flag members be 1-bit
3039 fields, and put them last in the struct.
640c8776
SM
3040 (compute_display_string_pos, compute_display_string_end):
3041 Update prototypes.
0bb23927
EZ
3042 (bidi_push_it, bidi_pop_it): Add prototypes.
3043 (struct iterator_stack_entry): New members bidi_p,
3044 paragraph_embedding, and from_disp_prop_p.
3045 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3046 (bidi_shelve_cache, bidi_unshelve_cache):
3047 Declare prototypes.
0bb23927
EZ
3048
3049 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3050 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3051 and vector-like objects.
3052
3053 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3054 cache around display iteration.
3055
3056 * window.c (Fwindow_end, window_scroll_pixel_based)
3057 (displayed_window_lines, Frecenter): Save and restore the bidi
3058 cache around display iteration.
3059
3bbd2265
LMI
30602011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3061
3062 * editfns.c (Fdelete_region): Clarify the use of the named
3063 parameters (bug#6788).
3064
adc47434
MR
30652011-07-14 Martin Rudalics <rudalics@gmx.at>
3066
3067 * indent.c (Fvertical_motion): Set and restore w->pointm when
3068 saving and restoring the window's buffer (Bug#9006).
3069
837c31f8
LMI
30702011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3071
3072 * editfns.c (Fstring_to_char): Clarify just what is returned
3073 (bug#6576). Text by Eli Zaretskii.
3074
ac389d0c
JB
30752011-07-13 Juanma Barranquero <lekktu@gmail.com>
3076
3077 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3078
0be0ce47
EZ
30792011-07-13 Eli Zaretskii <eliz@gnu.org>
3080
3081 * buffer.c (mmap_find): Fix a typo.
3082
cd18e7e3
JB
30832011-07-13 Johan Bockgård <bojohan@gnu.org>
3084
3085 Fix execution of x selection hooks.
3086 * xselect.c (Qx_lost_selection_functions)
3087 (Qx_sent_selection_functions): New vars.
3088 (syms_of_xselect): DEFSYM them.
3089 (x_handle_selection_request): Pass Qx_sent_selection_functions
3090 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3091 (x_handle_selection_clear,x_clear_frame_selections):
3092 Pass Qx_lost_selection_functions rather than
3093 Vx_lost_selection_functions to Frun_hook_with_args.
3094
47ea7f44
PE
30952011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3096
ac389d0c 3097 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3098 The old code sometimes used this field without initializing it.
3099
47ea7f44
PE
3100 * alloc.c (gc_sweep): Don't read past end of array.
3101 In theory, the old code could also have corrupted Emacs internals,
3102 though it'd be very unlikely.
3103
bc985c87
AS
31042011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3105
3106 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3107 argument. (Bug#4026)
bc985c87 3108
0cf34688
LMI
31092011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3110
b3dadd76
LMI
3111 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3112 key" (bug#4257).
3113
0cf34688
LMI
3114 * window.c (Fset_window_start): Doc fix (bug#4199).
3115 (Fset_window_hscroll): Ditto.
3116
270768cd
PE
31172011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3118
077e3dda 3119 Fix minor new problems caught by GCC 4.6.1.
270768cd 3120 * term.c (init_tty): Remove unused local.
490011a6 3121 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3122 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3123 not used otherwise.
270768cd 3124
b1f58454
CY
31252011-07-12 Chong Yidong <cyd@stupidchicken.com>
3126
3127 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3128
22b9578d
LMI
31292011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3130
6e70ab07
LMI
3131 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3132 are the mini-buffer and the echo area (bug#3320).
3133
22b9578d
LMI
3134 * term.c (init_tty): Remove support for supdup, c10 and perq
3135 terminals, which are no longer supported (bug#1482).
3136
8974cc9f
JB
31372011-07-10 Johan Bockgård <bojohan@gnu.org>
3138
3139 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3140
a560d974
JD
31412011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3142
3143 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3144 for non-popups (Bug#3642).
3145
1dae0f0a
AS
31462011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3147
268c2c36 3148 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3149 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3150 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3151 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3152 * data.c (fmod): Likewise.
3153 * dispnew.c (swap_glyphs_in_rows): Likewise.
3154 * emacs.c (memory_warning_signal): Likewise.
3155 * floatfns.c (float_error): Likewise.
3156 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3157 (otf_open, font_otf_capability, generate_otf_features)
3158 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3159 Likewise.
3160 * image.c (pbm_read_file): Likewise.
3161 * indent.c (string_display_width): Likewise.
3162 * intervals.c (check_for_interval, search_for_interval)
3163 (inc_interval_count, count_intervals, root_interval)
3164 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3165 * lread.c (defalias): Likewise.
268c2c36 3166 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3167 * regex.c (set_image_of_range_1, set_image_of_range)
3168 (regex_grow_registers): Likewise.
3169 * sysdep.c (strerror): Likewise.
3170 * termcap.c (valid_filename_p, tprint, main): Likewise.
3171 * tparam.c (main): Likewise.
3172 * unexhp9k800.c (run_time_remap, save_data_space)
3173 (update_file_ptrs, read_header, write_header, calculate_checksum)
3174 (copy_file, copy_rest, display_header): Likewise.
3175 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3176 Likewise.
3177 * xdisp.c (check_it): Likewise.
3178 * xfaces.c (register_color, unregister_color, unregister_colors):
3179 Likewise.
3180 * xfns.c (print_fontset_result): Likewise.
3181 * xrdb.c (member, fatal, main): Likewise.
3182
99033785
PE
31832011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 Fix minor problems found by static checking (Bug#9031).
3186 * chartab.c (char_table_set_range, map_sub_char_table):
3187 Remove unused locals.
3188 (uniprop_table): Now static.
3189 * composite.c (_work_char): Remove unused static var.
3190
9cb2ac56
JB
31912011-07-09 Juanma Barranquero <lekktu@gmail.com>
3192
3193 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3194
f25661f0
JD
31952011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3196
3197 * gtkutil.c (qttip_cb): Remove code without function.
3198
8278c4fe
EZ
31992011-07-09 Eli Zaretskii <eliz@gnu.org>
3200
3201 * w32.c (pthread_sigmask): New stub.
3202
1692ae2d 32032011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3204
8a6ebd58 3205 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3206 sigprocmask is portable only for single-threaded applications, and
3207 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3208 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3209 (LIBES): Use it.
3210 * callproc.c (Fcall_process):
3211 * process.c (create_process):
3212 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3213 Use pthread_sigmask, not sigprocmask.
123403e4 3214
1b854618
JD
32152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3216
3217 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3218 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3219 wrong (Bug#8591).
3220
3fe4b549
JD
32212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3222
0ce7e563
JD
3223 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3224 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3225 (xg_hide_tooltip): Fix comment.
3226
3fe4b549
JD
3227 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3228 in registerServicesMenuSendTypes.
3229 (validRequestorForSendType): Don't check ns_return_types.
3230
3231 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3232 ns_return_type.
3233
5df75e47
JR
32342011-07-08 Jason Rumney <jasonr@gnu.org>
3235
22610910
JR
3236 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3237 SH_SHOW for hidden windows (Bug#5482).
3238
5df75e47
JR
3239 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3240 frame struct members of non-existent frames (Bug#6284).
3241
699c10bd
JD
32422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3243
4393663b
JD
3244 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3245 variable firstTime not needed on OSX >= 10.6.
3246 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3247 >= 10.5. Use setKnobProportion, setDoubleValue.
3248
3249 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3250 (MAC_OS_X_VERSION_10_5): Define if not defined.
3251 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3252 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3253 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3254
3255 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3256 cString and lossyCString on OSX >= 10.4
3257
58179cce 3258 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3259 sizeToFit on OSX >= 10.2.
3260
3261 * nsimage.m (allocInitFromFile): Don't use deprecated method
3262 bestRepresentationForDevice on OSX >= 10.6.
3263
3264 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3265 to avoid warning.
3266
3267 * emacs.c: Declare unexec_init_emacs_zone.
3268
a63e0781
JD
3269 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3270
699c10bd
JD
3271 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3272
3273 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3274 on svcsMenu (Bug#8842).
3275
3276 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3277 ns_return_types.
3278 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3279
3280 * nsterm.m (QUTF8_STRING): Declare.
3281 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3282 (validRequestorForSendType): Return type is (id).
3283 Change indexOfObjectIdenticalTo to indexOfObject.
3284 Check if we have local selection before returning self (Bug#8842).
3285 (writeSelectionToPasteboard): Put local selection into paste board
3286 if we have a local selection (Bug#8842).
3287 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3288
3289 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3290 (ns_get_local_selection): Declare.
3291
54e10184
LMI
32922011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3293
9888ff71
LMI
3294 * keymap.c (describe_map_tree): Don't insert a double newline at
3295 the end of the buffer (bug#1169) and return whether we inserted
3296 something.
3297
54e10184
LMI
3298 * callint.c (Fcall_interactively): Change "reading args" to
3299 "providing args" to try to clarify what it does (bug#1010).
3300
15fa4783
KH
33012011-07-07 Kenichi Handa <handa@m17n.org>
3302
3303 * composite.c (composition_compute_stop_pos): Ignore a static
3304 composition starting before CHARPOS (Bug#8915).
3305
3306 * xdisp.c (handle_composition_prop): Likewise.
3307
a8815b00
EZ
33082011-07-07 Eli Zaretskii <eliz@gnu.org>
3309
3310 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3311 (Bug#9015)
3312
ef7b981d 33132011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3314
3315 * character.h (unicode_category_t): New enum type.
3316
3317 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3318 (Qchar_code_property_table): New variable.
3319 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3320 (UNIPROP_COMPRESSED_FORM_P): New macros.
3321 (char_table_ascii): Uncompress the compressed values.
3322 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3323 Uncompress the compressed values.
ac389d0c 3324 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3325 (char_table_ref_and_range): Uncompress the compressed values.
3326 (sub_char_table_set): New arg is_uniprop. Callers changed.
3327 Uncompress the compressed values.
3328 (sub_char_table_set_range): Args changed. Callers changed.
3329 (char_table_set_range): Adjuted for the above change.
3330 (map_sub_char_table): Delete args default_val and parent. Add arg
3331 top. Give decoded values to a Lisp function.
640c8776 3332 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3333 values to a Lisp function. Gcpro more variables.
3334 (uniprop_table_uncompress)
3335 (uniprop_decode_value_run_length): New functions.
3336 (uniprop_decoder, uniprop_decoder_count): New variables.
3337 (uniprop_get_decoder, uniprop_encode_value_character)
3338 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3339 New functions.
3340 (uniprop_encoder, uniprop_encoder_count): New variables.
3341 (uniprop_get_encoder, uniprop_table)
3342 (Funicode_property_table_internal, Fget_unicode_property_internal)
3343 (Fput_unicode_property_internal): New functions.
3344 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3345 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3346 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3347 char-code-property-alist.
3348
640c8776 3349 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3350 Vunicode_category_table.
3351
640c8776 3352 * font.c (font_range): Adjust for the change of
c805dec0
KH
3353 Vunicode_category_table.
3354
76b397fb
DN
33552011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3356
3357 * m/iris4d.h: Remove file, move contents ...
3358 * s/irix6-5.h: ... here.
3359
22b4128e
PE
33602011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3361
3362 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3363 * alloc.c (mark_buffer):
3364 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3365 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3366 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3367 This isn't true in general, and it's particularly not true
3368 if Emacs is configured with --with-wide-int.
3369 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3370 New macros, used in the buffer.c change.
3371
869795d6
JD
33722011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3373
3374 * xsettings.c: Use both GConf and GSettings if both are available.
3375 (store_config_changed_event): Add comment.
3376 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3377 (store_tool_bar_style_changed): New functions.
5e617bc2 3378 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3379 (struct xsettings): Move font inside HAVE_XFT.
3380 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3381 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3382 Move inside HAVE_XFT.
640c8776 3383 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3384 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3385 also.
3386 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3387 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3388 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3389 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3390 (parse_settings): Move check for font inside HAVE_XFT.
3391 (read_settings, apply_xft_settings): Add comment.
3392 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3393 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3394 call store_font_name_changed.
3395 (xft_settings_event): Add comment.
3396 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3397 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3398 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3399 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3400 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3401 (xsettings_get_system_font, xsettings_get_system_normal_font):
3402 Add comment.
869795d6 3403
d8ed26bd
PE
34042011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3405
3406 Random fixes. E.g., (random) never returned negative values.
3407 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3408 subseconds part to the entropy, as that's a bit more random.
3409 Prefer signed to unsigned, since the signedness doesn't matter and
3410 in general we prefer signed. When given a limit, use a
3411 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3412 latter isn't right if USE_2_TAGS_FOR_INTS.
3413 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3414 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3415
cabf1cac
SM
34162011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3417
3418 * textprop.c (text_property_stickiness):
3419 Obey Vtext_property_default_nonsticky.
3420 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3421 * w32fns.c (syms_of_w32fns):
3422 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3423
6e9b2be9
PE
34242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3427 This is more efficient than Ffile_directory_p and avoids a minor race.
3428
90186c68
LMI
34292011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3430
7c301272
LMI
3431 * buffer.c (Foverlay_put): Say what the return value is
3432 (bug#7835).
3433
c4f2d8d4
LMI
3434 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3435 is a directory before asking whether to use the file name
3436 (bug#7564).
ad637907
LMI
3437 (barf_or_query_if_file_exists): Make the "File is a directory"
3438 error be more correct.
c4f2d8d4 3439
90186c68
LMI
3440 * fns.c (Frequire): Remove the mention of the .gz files, since
3441 that's installation-specific, but keep the mention of
3442 `get-load-suffixes'.
3443
da64016e
PE
34442011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3445
3446 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3447 Report string overflow if the output is too long.
3448
7d47b580
JB
34492011-07-04 Juanma Barranquero <lekktu@gmail.com>
3450
a555cb87
JB
3451 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3452 (syms_of_gnutls): Remove duplicate DEFSYM for
3453 Qgnutls_bootprop_verify_hostname_error, an error for
3454 Qgnutls_bootprop_verify_error (which is no longer used).
3455
7d47b580
JB
3456 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3457 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3458 Also (re)move comments that are misplaced or no longer relevant.
3459
1e49bfab
LMI
34602011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3461
3462 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3463
1485f4c0
CY
34642011-07-03 Chong Yidong <cyd@stupidchicken.com>
3465
3466 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3467 and background color parameters if they have been changed.
3468
a9ab721e
LMI
34692011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3470
3471 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3472
cf7cff57
PE
34732011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3474
2e13213d
PE
3475 * xsettings.c (SYSTEM_FONT): Define only when used.
3476 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3477
cf7cff57
PE
3478 * keymap.c (access_keymap_1): Now static.
3479
7a8e04f7
CY
34802011-07-02 Chong Yidong <cyd@stupidchicken.com>
3481
3482 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3483 leave any prefix arg for the up event (Bug#1586).
3484
61352f62
LMI
34852011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3486
69bb1ef7
LMI
3487 * lread.c (syms_of_lread): Mention single symbols defined by
3488 `defvar' or `defconst' (bug#7154).
3489
61352f62 3490 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3491 (Frequire): Mention get-load-suffixes.
61352f62 3492
28545e04
MR
34932011-07-02 Martin Rudalics <rudalics@gmx.at>
3494
3495 * window.h (window): Remove clone_number slot.
3496 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3497 Remove.
3498 (make_parent_window, make_window, saved_window)
3499 (Fset_window_configuration, save_window_save): Don't deal with
3500 clone numbers.
3501 * buffer.c (Qclone_number): Remove declaration.
3502 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3503
3349e122
SM
35042011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3505
3506 Add multiple inheritance to keymaps.
3507 * keymap.c (Fmake_composed_keymap): New function.
3508 (Fset_keymap_parent): Simplify.
3509 (fix_submap_inheritance): Remove.
3510 (access_keymap_1): New function extracted from access_keymap to handle
3511 embedded parents and handle lists of maps.
3512 (access_keymap): Use it.
3513 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3514 (Fcopy_keymap): Handle embedded parents.
3515 (Fcommand_remapping, define_as_prefix): Simplify.
3516 (Fkey_binding): Simplify.
3517 (syms_of_keymap): Move minibuffer-local-completion-map,
3518 minibuffer-local-filename-completion-map,
3519 minibuffer-local-must-match-map, and
3520 minibuffer-local-filename-must-match-map to Elisp.
3521 (syms_of_keymap): Defsubr make-composed-keymap.
3522 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3523 (parse_menu_item): Trivial simplification.
3524
3279eb87
GM
35252011-07-01 Glenn Morris <rgm@gnu.org>
3526
3527 * Makefile.in (SETTINGS_LIBS): Fix typo.
3528
4550efdf
KI
35292011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3530
3531 * coding.c (Fencode_coding_string): Record the last coding system
3532 used, as the function doc string says (bug#8738).
3533
0949d2b6
JD
35342011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3535
3536 * xsettings.c (store_monospaced_changed): Take new font as arg and
3537 check for change against current_mono_font.
3538 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3539 (emacs_settings_constructor, emacs_settings_get_property)
3540 (emacs_settings_set_property, emacs_settings_class_init)
3541 (emacs_settings_init, gsettings_obj): Remove.
3542 (something_changedCB): New function for HAVE_GSETTINGS.
3543 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3544 with value as argument.
3545 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3546 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3547 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3548 "changed".
3549
3550 * xgselect.c: Add defined (HAVE_GSETTINGS).
3551 (xgselect_initialize): Ditto.
3552
3553 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3554 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3555 xg_select.
3556
bbc6b304
PE
35572011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3558
3559 * eval.c (struct backtrace): Simplify and port the data structure.
3560 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3561 signed bit field, as this assumption is not portable and it makes
3562 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3563 "char debug_on_exit : 1" as this is not portable either; instead,
3564 use the portable "unsigned int debug_on_exit : 1". Remove unused
3565 member evalargs. Remove obsolete comments about cc bombing out.
3566
9851bfc5
JD
35672011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3568
51bb811f 3569 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3570 Let HAVE_GSETTINGS override HAVE_GCONF.
3571 (store_monospaced_changed): New function.
3572 (EMACS_SETTINGS): A new type derived from GObject to handle
3573 GSettings notifications.
3574 (emacs_settings_constructor, emacs_settings_get_property)
3575 (emacs_settings_set_property, emacs_settings_class_init):
3576 New functions.
3577 (gsettings_client, gsettings_obj): New variables.
3578 (GSETTINGS_SCHEMA): New define.
3579 (something_changedCB): Call store_monospaced_changed.
3580 (init_gsettings): New function.
3581 (xsettings_initialize): Call init_gsettings.
3582 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3583 to NULL.
3584
640c8776 3585 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3586 GCONF_CFLAGS/LIBS.
3587
5386012d
MR
35882011-06-29 Martin Rudalics <rudalics@gmx.at>
3589
3590 * window.c (resize_root_window, grow_mini_window)
3591 (shrink_mini_window): Rename Qresize_root_window to
3592 Qwindow_resize_root_window and Qresize_root_window_vertically to
3593 Qwindow_resize_root_window_vertically.
3594
f13e0b08
PE
35952011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3598
94515237
JB
35992011-06-27 Juanma Barranquero <lekktu@gmail.com>
3600
3601 * makefile.w32-in: Redesign dependencies so they reflect more
3602 clearly which files are directly included by each source file,
3603 and not through other includes.
3604
e43b6e43
MR
36052011-06-27 Martin Rudalics <rudalics@gmx.at>
3606
3607 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3608 (sort_overlays, overlay_strings): When an overlay's clone number
3609 matches the window's clone number process the overlay even if
3610 the overlay's window property doesn't match the current window.
3611
d68443dc
MR
3612 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3613 (Fwindow_hchild): Rename to Fwindow_left_child.
3614 (Fwindow_next): Rename to Fwindow_next_sibling.
3615 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3616 (resize_window_check): Rename to window_resize_check.
3617 (resize_window_apply): Rename to window_resize_apply.
3618 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3619 (Fdelete_other_windows_internal, resize_frame_windows)
3620 (Fsplit_window_internal, Fdelete_window_internal)
3621 (grow_mini_window, shrink_mini_window)
3622 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3623
c7e73be5
JD
36242011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3625
3626 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3627 (emacs_fixed_set_min_size): Remove.
3628 (emacs_fixed_new): Take frame as argument.
3629
3630 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3631 (_EmacsFixedPrivate): Remove minwidth/height.
3632 Add struct frame *f.
3633 (emacs_fixed_init): Initialize priv->f.
3634 (get_parent_class, emacs_fixed_set_min_size): Remove.
3635 (emacs_fixed_new): Set priv->f to argument.
3636 (emacs_fixed_get_preferred_width)
3637 (emacs_fixed_get_preferred_height): Use min_width/height from
3638 frames size_hint to set minimum and natural (Bug#8919).
3639 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3640 and use min_width/height from frames size_hint to set
3641 min_width/height (Bug#8919).
3642
3643 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3644 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3645 Fix indentation.
c7e73be5 3646
cf99dcf8
EZ
36472011-06-26 Eli Zaretskii <eliz@gnu.org>
3648
3649 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3650 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3651 called at ZV.
3652
029529ac
CY
36532011-06-26 Chong Yidong <cyd@stupidchicken.com>
3654
3655 * process.c (wait_reading_process_output): Bypass select if
3656 waiting for a cell while ignoring keyboard input, and input is
3657 pending. Suggested by Jan Djärv (Bug#8869).
3658
7a7ef429
PE
36592011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3660
3661 Use gnulib's dup2 module instead of rolling our own.
3662 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3663
11fdef7d 36642011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3665
3666 * dispnew.c (scrolling_window): Before scrolling, turn off a
3667 mouse-highlight in the window being scrolled.
3668
cd3520a4
JB
36692011-06-24 Juanma Barranquero <lekktu@gmail.com>
3670
3671 Move DEFSYM to lisp.h and use everywhere.
3672
3673 * character.h (DEFSYM): Move declaration...
3674 * lisp.h (DEFSYM): ...here.
3675
3676 * gnutls.c:
3677 * minibuf.c:
3678 * w32menu.c:
3679 * w32proc.c:
3680 * w32select.c: Don't include character.h.
3681
3682 * alloc.c (syms_of_alloc):
3683 * buffer.c (syms_of_buffer):
3684 * bytecode.c (syms_of_bytecode):
3685 * callint.c (syms_of_callint):
3686 * casefiddle.c (syms_of_casefiddle):
3687 * casetab.c (init_casetab_once):
3688 * category.c (init_category_once, syms_of_category):
3689 * ccl.c (syms_of_ccl):
3690 * cmds.c (syms_of_cmds):
3691 * composite.c (syms_of_composite):
3692 * dbusbind.c (syms_of_dbusbind):
3693 * dired.c (syms_of_dired):
3694 * dispnew.c (syms_of_display):
3695 * doc.c (syms_of_doc):
3696 * editfns.c (syms_of_editfns):
3697 * emacs.c (syms_of_emacs):
3698 * eval.c (syms_of_eval):
3699 * fileio.c (syms_of_fileio):
3700 * fns.c (syms_of_fns):
3701 * frame.c (syms_of_frame):
3702 * fringe.c (syms_of_fringe):
3703 * insdel.c (syms_of_insdel):
3704 * keymap.c (syms_of_keymap):
3705 * lread.c (init_obarray, syms_of_lread):
3706 * macros.c (syms_of_macros):
3707 * msdos.c (syms_of_msdos):
3708 * print.c (syms_of_print):
3709 * process.c (syms_of_process):
3710 * search.c (syms_of_search):
3711 * sound.c (syms_of_sound):
3712 * syntax.c (init_syntax_once, syms_of_syntax):
3713 * terminal.c (syms_of_terminal):
3714 * textprop.c (syms_of_textprop):
3715 * undo.c (syms_of_undo):
3716 * w32.c (globals_of_w32):
3717 * window.c (syms_of_window):
3718 * xdisp.c (syms_of_xdisp):
3719 * xfaces.c (syms_of_xfaces):
3720 * xfns.c (syms_of_xfns):
3721 * xmenu.c (syms_of_xmenu):
3722 * xsettings.c (syms_of_xsettings):
3723 * xterm.c (syms_of_xterm): Use DEFSYM.
3724
4228cf16
TZ
37252011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3726
cd3520a4 3727 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3728
7fcccf1e
PE
37292011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3730
7efb4e0e
PE
3731 Integer and buffer overflow fixes (Bug#8873).
3732
ff5844ad
PE
3733 * print.c (printchar, strout): Check for string overflow.
3734 (PRINTPREPARE, printchar, strout):
3735 Don't set size unless allocation succeeds.
3736
90532f02
PE
3737 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3738 for sizes. Check for string overflow more accurately.
3739 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3740
6d84508d
PE
3741 * macros.c: Integer and buffer overflow fixes.
3742 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3743 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3744 Use ptrdiff_t, not int, for sizes.
3745 Don't increment bufsize until after realloc succeeds.
3746 Check for size-calculation overflow.
3747 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3748
437b2cb4
PE
3749 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3750
8b9ac8b4
PE
3751 * lread.c: Integer overflow fixes.
3752 (read_integer): Radix is now EMACS_INT, not int,
3753 to improve quality of diagnostics for out-of-range radices.
3754 Calculate buffer size correctly for out-of-range radices.
3755 (read1): Check for integer overflow in radices, and in
3756 read-circle numbers.
82cb60d3
PE
3757 (read_escape): Avoid int overflow.
3758 (Fload, openp, read_buffer_size, read1)
3759 (substitute_object_recurse, read_vector, read_list, map_obarray):
3760 Use ptrdiff_t, not int, for sizes.
3761 (read1): Use EMACS_INT, not int, for sizes.
20270765 3762 Check for size overflow.
8b9ac8b4 3763
7fcccf1e
PE
3764 * image.c (cache_image): Check for size arithmetic overflow.
3765
bfbbd7e7
PE
3766 * lread.c: Integer overflow issues.
3767 (saved_doc_string_size, saved_doc_string_length)
3768 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3769 Now ptrdiff_t, not int.
3770 (read1): Don't assume doc string length fits in int. Check for
3771 out-of-range doc string lengths.
3772 (read_list): Don't assume file position fits in int.
39019e54 3773 (read_escape): Check for hex character overflow.
bfbbd7e7 3774
4e323265
LL
37752011-06-22 Leo Liu <sdl.web@gmail.com>
3776
3777 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3778 Move to minibuffer.el.
3779
85fece3e
PE
37802011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3781
20b84ce9 3782 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3783 The following patches are for when GLYPH_DEBUG && !XASSERT.
3784 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3785 * dispnew.c (flush_stdout):
3786 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3787 Mark as externally visible.
3788 * dispnew.c (check_window_matrix_pointers): Now static.
3789 * dispnew.c (window_to_frame_vpos):
3790 * xfns.c (unwind_create_frame):
3791 * xterm.c (x_check_font): Remove unused local.
3792 * scroll.c (CHECK_BOUNDS):
3793 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3794 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3795 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3796 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3797 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3798 Now static.
3799 (debug_method_add): Use va_list and vsprintf rather than relying
3800 on undefined behavior with wrong number of arguments.
3801 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3802 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3803 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3804 since we're not interested in debugging glyphs with old libraries.
3805 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3806 GCC 4.6.0's static checking.
3807
0766b489
PE
38082011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3809
31fd4b32
PE
3810 Integer overflow and signedness fixes (Bug#8873).
3811 A few related buffer overrun fixes, too.
3812
b79e8648
PE
3813 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3814
0766b489
PE
3815 * dispextern.h (struct face.stipple):
3816 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3817 (x_bitmap_mask, x_allocate_bitmap_record)
3818 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3819 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3820 (x_create_bitmap_from_xpm_data):
3821 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3822 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3823 (.bitmaps_last):
3824 * xfaces.c (load_pixmap):
3825 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3826 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3827 (.bitmaps_last, struct x_output.icon_bitmap):
3828 Use ptrdiff_t, not int, for bitmap indexes.
3829 (x_allocate_bitmap_record): Check for size overflow.
3830 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3831
b081724f
PE
3832 Use ptrdiff_t, not int, for overlay counts.
3833 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3834 * editfns.c (overlays_around, get_pos_property):
3835 * textprop.c (get_char_property_and_overlay):
3836 * xdisp.c (next_overlay_change, note_mouse_highlight):
3837 * xfaces.c (face_at_buffer_position):
21514da7
PE
3838 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3839 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3840 (Fnext_overlay_change, Fprevious_overlay_change)
3841 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3842 Use ptrdiff_t, not int, for sizes.
21514da7 3843 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3844
3de73e5e
PE
3845 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3846
2606c57b
PE
3847 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3848 (x_session_initialize): Do not assume string length fits in int.
3849
aaafe47a
PE
3850 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3851 This is unlikely, but can occur if DPI is outlandish.
3852
2674ddc8 3853 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3854 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3855
28154962
PE
3856 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3857 * xrdb.c (magic_file_p, search_magic_path):
3858 Omit last arg SUFFIX; it was always 0. All callers changed.
3859 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3860
7de51af5
PE
3861 * xfont.c (xfont_match): Avoid need for strlen.
3862
25ed6cc3
PE
3863 * xfns.c: Don't assume strlen fits in int.
3864 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3865
4eab31dd
PE
3866 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3867 not unsigned long, as we prefer signed integers. All callers changed.
3868 Detect integer overflow in repeat count.
3869 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3870 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3871
171e2a58
PE
3872 * termcap.c: Don't assume sizes fit in int and never overflow.
3873 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3874 (gobble_line): Check for size-calculation overflow.
3875
ad39faca 3876 * minibuf.c (Fread_buffer):
6e5bb2dc 3877 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3878 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3879 Don't assume string length fits in int.
3880
52c61c22 3881 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3882 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3883
b5b8c9e5
PE
3884 * font.c: Don't assume string length fits in int.
3885 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3886 Use ptrdiff_t, not int.
ccd6111c
PE
3887 (font_intern_prop): Don't assume string length fits in int.
3888 Don't assume integer property fits in fixnum.
3889 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3890
882f0d81 3891 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3892 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3893 Reformulate so as not to need the command string.
3894 Invoke gzip -cd rather than gunzip, as it's more portable.
3895 (lock_info_type, lock_file_1, lock_file):
3896 Don't assume pid_t and time_t fit in unsigned long.
3897 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3898 (current_lock_owner): Prefer signed type for sizes.
3899 Use memcpy, not strncpy, where memcpy is what is really wanted.
3900 Don't assume (via atoi) that time_t and pid_t fit in int.
3901 Check for time_t and/or pid_t out of range, e.g., via a network share.
3902 Don't alloca where an auto var works fine.
3903
93f4cf88
PE
3904 * fileio.c: Fix some integer overflow issues.
3905 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3906 Don't assume string length fits in int.
3907 (directory_file_name): Don't assume string length fits in long.
3908 (make_temp_name): Don't assume pid fits in int, or that its print
3909 length is less than 20.
3910
f3e92b69
PE
3911 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3912
1bfdaf10
PE
3913 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3914
35016e9a
PE
3915 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3916
3d1e65a1
PE
3917 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3918 We prefer signed integers, even for size calculations.
3919
0b963a93
PE
3920 * emacs.c: Don't assume string length fits in 'int'.
3921 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3922 (main): Don't invoke strlen when not needed.
3923
573f4b54
PE
3924 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3925 (XD_DEBUG_MESSAGE): Don't waste a byte.
3926
989f33ba
PE
3927 * callproc.c (getenv_internal_1, getenv_internal)
3928 (Fgetenv_internal):
965d34eb
PE
3929 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3930
e4d29b33
PE
3931 * lread.c (invalid_syntax): Omit length argument.
3932 All uses changed. This doesn't fix a bug, but it simplifies the
3933 code away from its former Hollerith-constant appearance, and it's
3934 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3935 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3936
eb49b136
PE
3937 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3938 This didn't break anything, but it didn't help either.
3939 It's confusing to put a bogus integer in a place where the actual
3940 value does not matter.
9f62aeb1 3941 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3942 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3943
15375a22
PE
3944 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3945 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3946 implementation.
b61cc01c
PE
3947 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3948 We prefer signed types, and the value cannot exceed the EMACS_INT
3949 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3950 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3951 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3952 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3953
53b2623d
PE
3954 * indent.c (sane_tab_width): New function.
3955 (current_column, scan_for_column, Findent_to, position_indentation)
3956 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3957 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3958
51cab52b 3959 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3960
f2ed8a70
PE
3961 * lisp.h (lint_assume): New macro.
3962 * composite.c (composition_gstring_put_cache):
3963 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3964
abe80cc6
PE
3965 * editfns.c, insdel.c:
3966 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3967
b02c740e
PE
3968 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3969
ebc96716
PE
3970 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3971
b4e50fa0 3972 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3973 Use much-faster test for byte-length change.
311d5d7c 3974 Don't assume string byte-length fits in 'int'.
a4cf38e4 3975 Check that character arg fits in 'int'.
85461888 3976 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3977
c0c1ee9f
PE
3978 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3979
a498d7f4
PE
3980 * fns.c (concat): Catch string overflow earlier.
3981 Do not rely on integer wraparound.
3982
51cab52b
PE
3983 * dispextern.h (struct it.overlay_strings_charpos)
3984 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3985 * xdisp.c (forward_to_next_line_start)
3986 (back_to_previous_visible_line_start)
3987 (reseat_at_next_visible_line_start, next_element_from_buffer):
3988 Don't arbitrarily truncate the value of 'selective' to int.
3989
76031fad
PE
3990 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3991
5eb55db9
PE
3992 * composite.c: Don't truncate sizes to 'int'.
3993 (composition_gstring_p, composition_reseat_it)
3994 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3995 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3996 not EMACS_UINT, for indexes.
5eb55db9 3997
0703a717
PE
3998 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3999
d6202519
PE
4000 * buffer.c: Include <verify.h>.
4001 (struct sortvec.priority, struct sortstr.priority):
8961a454 4002 Now EMACS_INT, not int.
c20998a7 4003 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4004 (struct sortstr.size, record_overlay_string)
4005 (struct sortstrlist.size, struct sortlist.used):
4006 Don't truncate size to int.
4007 (record_overlay_string): Check for size-calculation overflow.
d6202519 4008 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4009
d5a19415
JM
40102011-06-22 Jim Meyering <meyering@redhat.com>
4011
029529ac 4012 Don't leak an XBM-image-sized buffer
d5a19415
JM
4013 * image.c (xbm_load): Free the image buffer after using it.
4014
a9041e6c
PE
40152011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4016
4017 Port to Sun C.
4018 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4019 that Sun C diagnosed.
4020 * fns.c (secure_hash): Fix pointer signedness issue.
4021 * intervals.c (static_offset_intervals): New function.
4022 (offset_intervals): Use it.
4023
7f3f739f
LL
40242011-06-21 Leo Liu <sdl.web@gmail.com>
4025
4026 * deps.mk (fns.o):
4027 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4028 sha512.h.
4029
4030 * fns.c (secure_hash): Rename from crypto_hash_function and change
4031 the first arg to accept symbols.
5b66d427 4032 (Fsecure_hash): New primitive.
7f3f739f
LL
4033 (syms_of_fns): New symbols.
4034
76147d94
DD
40352011-06-20 Deniz Dogan <deniz@dogan.se>
4036
4037 * process.c (Fset_process_buffer): Clarify return value in
4038 docstring.
4039
7d7d0045
CY
40402011-06-18 Chong Yidong <cyd@stupidchicken.com>
4041
4042 * dispnew.c (add_window_display_history): Use BVAR.
4043
4044 * xdisp.c (debug_method_add): Use BVAR.
4045 (check_window_end, dump_glyph_matrix, dump_glyph)
4046 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4047
4048 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4049 Likewise.
4050
4051 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4052 check till after the cache is created in init_frame_faces.
4053
ff2bc410
SM
40542011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4055
4056 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4057
28177add
PE
40582011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4059
dd3482fe
PE
4060 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4061 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4062 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4063
393d71f3 4064 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4065 * fileio.c (Finsert_file_contents):
4066 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4067 Remove the old (too-loose) buffer overflow checks.
4068 They weren't needed, since make_gap checks for buffer overflow.
4069 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4070 The old code merely checked for Emacs fixnum overflow, and relied
4071 on undefined (wraparound) behavior. The new code avoids undefined
4072 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4073
2e6813b0 4074 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4075 Tune. Don't use wider integers than needed. Don't use alloca.
4076 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4077
599a9e4f
PE
4078 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4079
99561444
PE
4080 * insdel.c, lisp.h (buffer_overflow): New function.
4081 (insert_from_buffer_1, replace_range, replace_range_2):
4082 * insdel.c (make_gap_larger):
4083 * editfns.c (Finsert_char):
4084 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4085
28177add
PE
4086 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4087
e69dafad
PE
40882011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4089
a7af7fde 4090 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4091
b1c46f02
PE
4092 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4093 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4094
e69dafad
PE
4095 * fileio.c: Don't assume EMACS_INT fits in off_t.
4096 (emacs_lseek): New static function.
4097 (Finsert_file_contents, Fwrite_region): Use it.
4098 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4099
566684ea
PE
4100 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4101
e6966cd6
PE
4102 * fns.c: Don't overflow int when computing a list length.
4103 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4104 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4105 truncation on 64-bit hosts. Check for QUIT every
4106 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4107 faster and is responsive enough.
4108 (Flength): Report an error instead of overflowing an integer.
4109 (Fsafe_length): Return a float if the value is not representable
4110 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4111 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4112 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4113
dd0b0efb
PE
4114 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4115 (header_size, word_size): New constants.
4116 (allocate_vectorlike): Don't check size overflow here.
4117 (allocate_vector): Check it here instead, since this is the only
4118 caller of allocate_vectorlike that could cause overflow.
4119 Check that the new vector's length is representable as a fixnum.
4120
86fe5cfe
PE
4121 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4122 The previous code was bogus. For example, next_almost_prime (32)
4123 returned 39, which is undesirable as it is a multiple of 3; and
4124 next_almost_prime (24) returned 25, which is a multiple of 5 so
4125 why was the code bothering to check for multiples of 7?
4126
80e88859
PE
4127 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4128
4a2f0ad6
PE
4129 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4130
f66c7cf8
PE
4131 Variadic C functions now count arguments with ptrdiff_t.
4132 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4133 Back then I didn't know that the Emacs coding style prefers signed int.
4134 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4135 were being counted with int, which may truncate counts on 64-bit
4136 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4137 * lisp.h (struct Lisp_Subr.function.aMANY)
4138 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4139 Arg counts are now ptrdiff_t, not size_t.
4140 All variadic functions and their callers changed accordingly.
4141 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4142 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4143 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4144 * callint.c (Fcall_interactively): Check arg count for overflow,
4145 to avoid potential buffer overrun. Use signed char, not 'int',
4146 for 'varies' array, so that we needn't bother to check its size
4147 calculation for overflow.
4148 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4149 * eval.c (apply_lambda):
4150 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4151 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4152 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4153
a1759b76
PE
4154 * callint.c (Fcall_interactively): Don't use index var as event count.
4155
d96be9fc
PE
4156 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4157 * mem-limits.h (SIZE): Remove; no longer used.
4158
a690a978 4159 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4160
578c21e6
PE
4161 Remove unnecessary casts.
4162 * xterm.c (x_term_init):
4163 * xfns.c (x_set_border_pixel):
4164 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4165 These aren't needed now that we assume ANSI C.
4166
96f53c6c
PE
4167 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4168 It's more likely to cause problems (due to unsigned overflow)
4169 than to cure them.
4170
83c77d31
PE
4171 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4172
ee2079f1
PE
4173 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4174
6da65536
PE
4175 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4176
7147c4a4
PE
4177 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4178
193e32d9
PE
4179 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4180
e5533da6
PE
4181 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4182
9910e595
PE
4183 GLYPH_CODE_FACE returns EMACS_INT, not int.
4184 * dispextern.h (merge_faces):
4185 * xfaces.c (merge_faces):
01103c44
PE
4186 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4187 Don't assume EMACS_INT fits in int.
9910e595 4188
2638320e
PE
4189 * character.h (CHAR_VALID_P): Remove unused parameter.
4190 * fontset.c, lisp.h, xdisp.c: All uses changed.
4191
045eb8d9
PE
4192 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4193
c1f134b5
PE
4194 * fns.c (concat): Minor tuning based on overflow analysis.
4195 This doesn't fix any bugs. Use int to hold character, instead
4196 of constantly refetching from Emacs object. Use XFASTINT, not
4197 XINT, for value known to be a character. Don't bother comparing
4198 a single byte to 0400, as it's always less.
4199
395fcb93 4200 * floatfns.c (Fexpt):
327eeec8
PE
4201 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4202
abbd3d23
PE
4203 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4204 for characters.
4205
684a03ef
PE
4206 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4207
0fed43f3
PE
4208 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4209 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4210 incorrectly succeed when S was a string, because 4294967386 was
4211 truncated before it was used.
4212
8fd02eb7
PE
4213 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4214 Otherwise, an out-of-range integer could cause undefined behavior
4215 on a 64-bit host.
4216
f8c86b69
PE
4217 * composite.c: Use int, not EMACS_INT, for characters.
4218 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4219 EMACS_INT, for values that are known to be in character range.
4220 This doesn't fix any bugs but is the usual style inside Emacs and
4221 may generate better code on 32-bit machines.
4222
34206dd2
PE
4223 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4224 This is for reasons similar to the recent CHAR_STRING fix.
4225 * charset.c (Fencode_char): Check that character arg is actually
4226 a character. Pass an int to ENCODE_CHAR.
4227 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4228 wider than 'int', as a compile-time check to prevent future regressions
4229 in this area.
4230
c5958d4c 4231 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4232
4233 Make sure a 64-bit char is never passed to CHAR_STRING.
4234 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4235 by silently ignoring the top 32 bits, allowing some values
4236 that were far too large to be valid characters.
4237 * character.h: Include <verify.h>.
4238 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4239 arguments are no wider than unsigned, as a compile-time check
4240 to prevent future regressions in this area.
4241 * data.c (Faset):
01103c44 4242 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4243 (Fsubst_char_in_region):
4244 * fns.c (concat):
4245 * xdisp.c (decode_mode_spec_coding):
4246 Adjust to CHAR_STRING's new requirement.
4247 * editfns.c (Finsert_char, Fsubst_char_in_region):
4248 * fns.c (concat): Check that character args are actually
4249 characters. Without this test, these functions did the wrong
4250 thing with wildly out-of-range values on 64-bit hosts.
4251
d37ca623
PE
4252 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4253 These casts should not be needed on 32-bit hosts, either.
4254 * keyboard.c (read_char):
4255 * lread.c (Fload): Remove casts to unsigned.
4256
ea204efb
PE
4257 * lisp.h (UNSIGNED_CMP): New macro.
4258 This fixes comparison bugs on 64-bit hosts.
4259 (ASCII_CHAR_P): Use it.
4260 * casefiddle.c (casify_object):
01103c44 4261 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4262 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4263 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4264 * dispextern.h (FACE_FROM_ID):
4265 * keyboard.c (read_char): Use UNSIGNED_CMP.
4266
41cb286c
PE
4267 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4268 not to EMACS_INT, to avoid GCC warning.
4269
4a1b9832
PE
4270 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4271
55daad71
PE
4272 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4273 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4274 isn't needed on 32-bit machines.
8f95c75c 4275
01103c44
PE
4276 * buffer.c (Fgenerate_new_buffer_name):
4277 Use EMACS_INT for count, not int.
0ceccced 4278 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4279
4280 * data.c (Qcompiled_function): Now static.
4281
c6f072e7
PE
4282 * window.c (window_body_lines): Now static.
4283
20ce5912
PE
4284 * image.c (gif_load): Rename local to avoid shadowing.
4285
9c4c5f81
PE
4286 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4287 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4288 * alloc.c (make_save_value): Integer argument is now of type
4289 ptrdiff_t, not int.
4290 (mark_object): Use ptrdiff_t, not int.
4291 * lisp.h (pD): New macro.
4292 * print.c (print_object): Use it.
4293
c0c5c8ae
PE
4294 * alloc.c: Use EMACS_INT, not int, to count objects.
4295 (total_conses, total_markers, total_symbols, total_vector_size)
4296 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4297 (total_free_floats, total_floats, total_free_intervals)
4298 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4299 Now EMACS_INT, not int. All uses changed.
4300 (Fgarbage_collect): Compute overall total using a double, so that
4301 integer overflow is less likely to be a problem. Check for overflow
4302 when converting back to an integer.
5a25e253
PE
4303 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4304 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4305 These were 'int' variables that could overflow on 64-bit hosts;
4306 they were never used, so remove them instead of repairing them.
211a0b2a 4307 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4308 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4309 Previously, this ceilinged at INT_MAX, but that doesn't work on
4310 64-bit machines.
e46bb31a 4311 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4312
c78baabf 4313 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4314 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4315 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4316 when a (possibly-narrower) signed value would do just as well.
4317 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4318
c9d624c6
PE
4319 * alloc.c: Catch some string size overflows that we were missing.
4320 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4321 for convenience in STRING_BYTES_MAX.
4322 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4323 The definition here is exact; the one in lisp.h was approximate.
4324 (allocate_string_data): Check for string overflow. This catches
4325 some instances we weren't catching before. Also, it catches
4326 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4327 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4328 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4329
c9d624c6
PE
4330 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4331 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4332 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4333
353032ce
PE
4334 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4335
2bccce07
PE
4336 * alloc.c (Fmake_string): Check for out-of-range init.
4337
0ac30604
SM
43382011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4339
4340 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4341
c195f2de
JD
43422011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4343
4344 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4345 xg_get_default_scrollbar_width.
4346
4347 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4348 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4349 (style_changed_cb): Call update_theme_scrollbar_width and call
4350 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4351 all frames (Bug#8505).
4352 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4353 Call gtk_window_set_resizable if HAVE_GTK3.
4354 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4355 and height if HAVE_GTK3 (Bug#8505).
4356 (scroll_bar_width_for_theme): New variable.
4357 (update_theme_scrollbar_width): New function.
4358 (xg_get_default_scrollbar_width): Move code to
4359 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4360 (xg_initialize): Call update_theme_scrollbar_width.
4361
4362 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4363
4364 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4365
e10ac9f1
MR
43662011-06-12 Martin Rudalics <rudalics@gmx.at>
4367
4368 * frame.c (make_frame): Call other_buffer_safely instead of
4369 other_buffer.
4370
4371 * window.c (temp_output_buffer_show): Call display_buffer with
4372 second argument Vtemp_buffer_show_specifiers and reset latter
4373 immediately after the call.
4374 (Vtemp_buffer_show_specifiers): New variable.
4375 (auto_window_vscroll_p, next_screen_context_lines)
4376 (Vscroll_preserve_screen_position): Remove leading asterisks from
4377 doc-strings.
4378
2d3c217e 43792011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4380
7b7f97e8 4381 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4382 * buffer.c (Qclone_number): Remove for now, as it's unused.
4383 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4384 (record_buffer): Remove unused local.
4385 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4386 (set_frame_buffer_list): Remove; unused.
4387 * frame.h (other_visible_frames): Remove decl.
4388 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4389 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4390 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4391 if HAVE_GPM.
4392 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4393 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4394 Define only if HAVE_GPM.
4395 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4396 (update_hints_inhibit): Remove; never set. All uses removed.
4397 * widgetprv.h (emacsFrameClassRec): Remove decl.
4398 * window.c (delete_deletable_window): Now returns void, since it
4399 wasn't returning anything.
4400 (compare_window_configurations): Remove unused locals.
4401 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4402 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4403 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4404 the same widths as pointers. This follows up on the 2011-05-06 patch.
4405 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4406 * xterm.h: Likewise.
4407 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4408
1384b89e
JB
44092011-06-12 Juanma Barranquero <lekktu@gmail.com>
4410
4411 * makefile.w32-in: Update dependencies.
4412 (LISP_H): Add lib/intprops.h.
4413
1100a63c
CY
44142011-06-11 Chong Yidong <cyd@stupidchicken.com>
4415
4416 * image.c (gif_load): Add animation frame delay to the metadata.
4417 (syms_of_image): Use DEFSYM. New symbol `delay'.
4418
6198ccd0
MR
44192011-06-11 Martin Rudalics <rudalics@gmx.at>
4420
4421 * window.c (delete_deletable_window): Re-add.
4422 (Fset_window_configuration): Rewrite to handle dead buffers and
4423 consequently deletable windows.
4424 (window_tree, Fwindow_tree): Remove. Supply functionality in
4425 window.el.
4426 (compare_window_configurations): Simplify code.
4427
b6e3633c
AS
44282011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4429
1ab0dee5
AS
4430 * image.c (imagemagick_load_image): Fix type mismatch.
4431 (Fimagemagick_types): Likewise.
4432
b6e3633c
AS
4433 * window.h (replace_buffer_in_windows): Declare.
4434
9397e56f
MR
44352011-06-11 Martin Rudalics <rudalics@gmx.at>
4436
4437 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4438 Qclone_number. Remove external declaration of Qdelete_window.
4439 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4440 code.
640c8776
SM
4441 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4442 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4443 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4444 buffer list implementation.
4445 (other_buffer_safely): New function.
4446 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4447 calls to replace_buffer_in_windows and
4448 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4449 if allowed.
4450 (record_buffer): Inhibit quitting and rewrite using quittable
4451 functions. Run Qbuffer_list_update_hook if allowed.
4452 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4453 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4454 Move switch-to-buffer to window.el.
9397e56f
MR
4455 (bury-buffer): Move to window.el.
4456 (Vbuffer_list_update_hook): New variable.
4457
4458 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4459 section.
4460
4461 * window.h (resize_frame_windows): Move up in code.
4462 (Fwindow_frame): Remove EXFUN.
4463 (replace_buffer_in_all_windows): Remove prototype.
4464 (replace_buffer_in_windows_safely): Add prototype.
4465
4466 * window.c: Declare Qdelete_window static again. Move down
4467 declaration of select_count.
4468 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4469 (Fother_window): Move to window.el.
4470 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4471 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4472 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4473 window.el.
4474 (replace_buffer_in_windows): Implement by calling
4475 Qreplace_buffer_in_windows.
4476 (replace_buffer_in_all_windows): Remove with some functionality
4477 moved into replace_buffer_in_windows_safely.
4478 (replace_buffer_in_windows_safely): New function.
4479 (select_window_norecord, select_frame_norecord): Move in front
4480 of run_window_configuration_change_hook. Remove now obsolete
4481 declarations.
640c8776
SM
4482 (Fset_window_buffer): Rewrite doc-string.
4483 Call Qrecord_window_buffer.
9397e56f
MR
4484 (keys_of_window): Move binding for other-window to window.el.
4485
b50691aa
CY
44862011-06-11 Chong Yidong <cyd@stupidchicken.com>
4487
4488 * dispextern.h (struct image): Replace data member, whose int_val
4489 and ptr_val fields were not used by anything, with a single
4490 lisp_val object.
4491
4492 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4493 (gif_clear_image, gif_load, imagemagick_load_image)
4494 (gs_clear_image, gs_load): Callers changed.
4495
3f754b86
PE
44962011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4497
cca69397
PE
4498 * buffer.h: Include <time.h>, for time_t.
4499 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4500
109e28d0
PE
4501 Fix minor problems found by static checking.
4502
60737f02
PE
4503 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4504
4b66faf3
PE
4505 Make identifiers static if they are not used in other modules.
4506 * data.c (Qcompiled_function, Qframe, Qvector):
4507 * image.c (QimageMagick, Qsvg):
4508 * minibuf.c (Qmetadata):
4509 * window.c (resize_window_check, resize_root_window): Now static.
4510 * window.h (resize_window_check, resize_root_window): Remove decls.
4511
109e28d0
PE
4512 * window.c (window_deletion_count, delete_deletable_window):
4513 Remove; unused.
46a4ce9e
PE
4514 (window_body_lines): Now static.
4515 (Fdelete_other_windows_internal): Mark vars as initialized.
4516 Make sure 'resize_failed' is initialized.
4517 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4518 (resize_window_apply): Remove unused local.
4519 * window.h (delete_deletable_window): Remove decl.
4520
109e28d0 4521 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4522 (imagemagick_load_image): Fix pointer signedness problem by changing
4523 last arg from unsigned char * to char *. All uses changed.
4524 Also, fix a local for similar reasons.
4525 Remove unused locals. Remove locals to avoid shadowing.
4526 (fn_rsvg_handle_free): Remove; unused.
4527 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4528 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4529
3f754b86
PE
4530 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4531
2547adb1
CY
45322011-06-10 Chong Yidong <cyd@stupidchicken.com>
4533
4534 * image.c (gif_load): Fix omitted cast error introduced by
4535 2011-06-06 change.
4536
2c8e37d4
MR
45372011-06-10 Martin Rudalics <rudalics@gmx.at>
4538
4539 * window.h (resize_proportionally, orig_total_lines)
4540 (orig_top_line): Remove from window structure.
4541 (set_window_height, set_window_width, change_window_heights)
4542 (Fdelete_window): Remove prototypes.
4543 (resize_frame_windows): Remove duplicate declaration.
4544
440a42e3
EZ
45452011-06-10 Eli Zaretskii <eliz@gnu.org>
4546
4547 * window.h (resize_frame_windows, resize_window_check)
4548 (delete_deletable_window, resize_root_window)
4549 (resize_frame_windows): Declare prototypes.
4550
4551 * window.c (resize_window_apply): Make definition be "static" to
4552 match the prototype.
4553
562dd5e9
MR
45542011-06-10 Martin Rudalics <rudalics@gmx.at>
4555
4556 * window.c: Remove declarations of Qwindow_size_fixed,
4557 window_min_size_1, window_min_size_2, window_min_size,
4558 size_window, window_fixed_size_p, enlarge_window, delete_window.
4559 Remove static from declaration of Qdelete_window, it's
4560 temporarily needed by Fbury_buffer.
4561 (replace_window): Don't assign orig_top_line and
4562 orig_total_lines.
4563 (Fdelete_window, delete_window): Remove. Window deletion is
4564 handled by window.el.
640c8776
SM
4565 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4566 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4567 (Fdelete_other_windows): Remove. Deleting other windows is
4568 handled by window.el.
4569 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4570 handled in window.el.
4571 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4572 Window minimum sizes are handled in window.el.
4573 (shrink_windows, size_window, set_window_height)
4574 (set_window_width, change_window_heights, window_height)
4575 (window_width, CURBEG, CURSIZE, enlarge_window)
4576 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4577 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4578 handled in window.el.
4579 (make_dummy_parent): Rename to make_parent_window and give it a
4580 second argument horflag.
4581 (make_window): Don't set resize_proportionally any more.
4582 (Fsplit_window): Remove. Windows are split in window.el.
4583 (save_restore_action, save_restore_orig_size)
4584 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4585 Resize mini windows in window.el.
4586 (grow_mini_window, shrink_mini_window): Implement by calling
4587 Qresize_root_window_vertically, resize_window_check and
4588 resize_window_apply.
640c8776
SM
4589 (saved_window, Fset_window_configuration, save_window_save):
4590 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4591 resize_proportionally.
4592 (window_min_height, window_min_width): Move to window.el.
4593 (keys_of_window): Move bindings for delete-other-windows,
4594 split-window, delete-window and enlarge-window to window.el.
4595
4596 * buffer.c: Temporarily extern Qdelete_window.
4597 (Fbury_buffer): Temporarily call Qdelete_window instead of
4598 Fdelete_window (Fbury_buffer will move to window.el soon).
4599
4600 * frame.c (set_menu_bar_lines_1): Remove code handling
4601 orig_top_line and orig_total_lines.
4602
4603 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4604 set_window_height but set heights directly.
4605 (change_frame_size_1): Use resize_frame_windows.
4606
4607 * xdisp.c (init_xdisp): Don't use set_window_height but set
4608 heights directly.
4609
640c8776
SM
4610 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4611 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4612 run_window_configuration_change_hook.
4613
4614 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4615 instead of change_window_heights and run
4616 run_window_configuration_change_hook.
4617
1a13852e
MR
46182011-06-09 Martin Rudalics <rudalics@gmx.at>
4619
4620 * window.c (replace_window): Rename second argument REPLACEMENT to
4621 NEW. New third argument SETFLAG. Rewrite.
4622 (delete_window, make_dummy_parent): Call replace_window with
4623 third argument 1.
4624 (window_list_1): Move down in code.
4625 (run_window_configuration_change_hook): Move set_buffer part
4626 before select_frame_norecord part in order to unwind correctly.
4627 Rename count1 to count.
4628 (recombine_windows, delete_deletable_window, resize_root_window)
4629 (Fdelete_other_windows_internal)
4630 (Frun_window_configuration_change_hook, make_parent_window)
4631 (resize_window_check, resize_window_apply, Fresize_window_apply)
4632 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4633 (Fdelete_window_internal, Fresize_mini_window_internal):
4634 New functions.
1a13852e
MR
4635 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4636
f3d1777e
MR
46372011-06-08 Martin Rudalics <rudalics@gmx.at>
4638
496e208e
MR
4639 * window.h (window): Add some new members to window structure -
4640 normal_lines, normal_cols, new_total, new_normal, clone_number,
4641 splits, nest, prev_buffers, next_buffers.
4642 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4643 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4644
f3d1777e
MR
4645 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4646 Remove.
496e208e
MR
4647 (make_dummy_parent): Set new members of windows structure.
4648 (make_window): Move down in code. Handle new members of window
4649 structure.
4650 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4651 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4652 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4653 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4654 (Fset_window_next_buffers, Fset_window_clone_number):
4655 New functions.
496e208e
MR
4656 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4657 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4658 Doc-string fixes.
4659 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4660 Argument WINDOW can be now internal window too.
4661 (Fwindow_use_time): Move up in code.
4662 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4663 Rewrite doc-string.
4664 (Fset_window_configuration, saved_window)
4665 (Fcurrent_window_configuration, save_window_save): Handle new
4666 members of window structure.
b9e809c2
MR
4667 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4668 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4669 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4670 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4671 Qget_mru_window, Qresize_root_window,
4672 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4673 Qauto_buffer_name; staticpro them.
f3d1777e 4674
abde8f8c
MR
46752011-06-07 Martin Rudalics <rudalics@gmx.at>
4676
4677 * window.c (Fwindow_total_size, Fwindow_left_column)
4678 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4679 (Fwindow_list_1): New functions.
4680 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4681 (Fwindow_width, Fscroll_left, Fscroll_right):
4682 Use window_body_cols instead of window_box_text_cols.
4683 (delete_window, Fset_window_configuration):
4684 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4685 (delete_all_subwindows): Take a window as argument and not a
4686 structure. Rewrite.
190b47e6
MR
4687 (window_loop): Remove handling of GET_LRU_WINDOW and
4688 GET_LARGEST_WINDOW.
4689 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4690
4691 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4692 window_box_text_cols. delete_all_subwindows now takes a
4693 Lisp_Object as argument.
abde8f8c 4694
640c8776
SM
4695 * indent.c (compute_motion, Fcompute_motion):
4696 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4697
fa8a67e6
MR
4698 * frame.c (delete_frame): Call delete_all_subwindows with root
4699 window as argument.
4700
a54e3482
DC
47012011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4702
4703 * fns.c (Fputhash): Document return value.
4704
60002bf5
CY
47052011-06-06 Chong Yidong <cyd@stupidchicken.com>
4706
4707 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4708
0c671da6 47092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4710
b862a52a 4711 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4712
be44ca6c
PE
4713 Check for overflow when converting integer to cons and back.
4714 * charset.c (Fdefine_charset_internal, Fdecode_char):
4715 Use cons_to_unsigned to catch overflow.
4716 (Fencode_char): Use INTEGER_TO_CONS.
4717 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4718 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4719 * data.c (long_to_cons, cons_to_long): Remove.
4720 (cons_to_unsigned, cons_to_signed): New functions.
4721 These signal an error for invalid or out-of-range values.
4722 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4723 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4724 * font.c (Ffont_variation_glyphs):
4725 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4726 * lisp.h: Include <intprops.h>.
4727 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4728 (cons_to_signed, cons_to_unsigned): New decls.
4729 (long_to_cons, cons_to_long): Remove decls.
4730 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4731 (Fprimitive_undo): Use CONS_TO_INTEGER.
4732 * xfns.c (Fx_window_property): Likewise.
4733 * xselect.c: Include <limits.h>.
4734 (x_own_selection, selection_data_to_lisp_data):
4735 Use INTEGER_TO_CONS.
4736 (x_handle_selection_request, x_handle_selection_clear)
4737 (x_get_foreign_selection, Fx_disown_selection_internal)
4738 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4739 (lisp_data_to_selection_data): Use cons_to_unsigned.
4740 (x_fill_property_data): Use cons_to_signed.
4741 Report values out of range.
4742
d1f3d2af
PE
4743 Check for buffer and string overflow more precisely.
4744 * buffer.h (BUF_BYTES_MAX): New macro.
4745 * lisp.h (STRING_BYTES_MAX): New macro.
4746 * alloc.c (Fmake_string):
4747 * character.c (string_escape_byte8):
4748 * coding.c (coding_alloc_by_realloc):
4749 * doprnt.c (doprnt):
4750 * editfns.c (Fformat):
4751 * eval.c (verror):
4752 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4753 since they may not be the same number.
4754 * editfns.c (Finsert_char):
4755 * fileio.c (Finsert_file_contents):
4756 Likewise for BUF_BYTES_MAX.
4757
dd52fcea
PE
4758 * image.c: Use ptrdiff_t, not int, for sizes.
4759 (slurp_file): Switch from int to ptrdiff_t.
4760 All uses changed.
4761 (slurp_file): Check that file size fits in both size_t (for
4762 malloc) and ptrdiff_t (for sanity and safety).
4763
7f9bbdbb
PE
4764 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4765 if b->modtime has its maximal value.
4766
dfe18f82
PE
4767 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4768
84acfcf0
PE
4769 Don't assume time_t can fit into int.
4770 * buffer.h (struct buffer.modtime): Now time_t, not int.
4771 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4772 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4773
ccd9a01a
PE
4774 Minor fixes for signed vs unsigned integers.
4775 * character.h (MAYBE_UNIFY_CHAR):
4776 * charset.c (maybe_unify_char):
4777 * keyboard.c (read_char, reorder_modifiers):
4778 XINT -> XFASTINT, since the integer must be nonnegative.
4779 * ftfont.c (ftfont_spec_pattern):
4780 * keymap.c (access_keymap, silly_event_symbol_error):
4781 XUINT -> XFASTINT, since the integer must be nonnegative.
4782 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4783 since it makes no difference and we prefer signed.
4784 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4785 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4786 nonnegative.
4787
d6d100dd
SM
47882011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4789
4790 * window.h (Fwindow_frame): Declare.
4791
2b6148e4
PE
47922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4793
4794 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4795 (SPARE_MEMORY): Always define.
4796 (LARGE_REQUEST): Remove.
4797 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4798
f230ecc9
MR
47992011-06-06 Martin Rudalics <rudalics@gmx.at>
4800
727e958e
MR
4801 * lisp.h: Move EXFUNS for Fframe_root_window,
4802 Fframe_first_window and Fset_frame_selected_window to window.h.
4803
4804 * window.h: Move EXFUNS for Fframe_root_window,
4805 Fframe_first_window and Fset_frame_selected_window here from
4806 lisp.h.
4807
4808 * frame.c (Fwindow_frame, Fframe_first_window)
4809 (Fframe_root_window, Fframe_selected_window)
4810 (Fset_frame_selected_window): Move to window.c.
4811 (Factive_minibuffer_window): Move to minibuf.c.
4812 (Fother_visible_frames_p): New function.
4813
4814 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4815
f230ecc9
MR
4816 * window.c (decode_window, decode_any_window): Move up in code.
4817 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4818 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4819 (Fwindow_buffer): Move up and rewrite doc-string.
4820 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4821 (Fwindow_prev): New functions.
727e958e
MR
4822 (Fwindow_frame): Move here from frame.c. Accept any window as
4823 argument.
4824 (Fframe_root_window, Fframe_first_window)
4825 (Fframe_selected_window): Move here from frame.c. Accept frame
4826 or arbitrary window as argument. Update doc-strings.
4827 (Fminibuffer_window): Move up in code.
4828 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4829 (Fset_frame_selected_window): Move here from frame.c.
4830 Marginal rewrite.
727e958e
MR
4831 (Fselected_window, select_window, Fselect_window): Move up in
4832 code. Minor doc-string fixes.
f230ecc9 4833
4d09bcf6
PE
48342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4837 Do not assume that spare memory exists; that assumption is valid
4838 only if SYSTEM_MALLOC.
4839 (LARGE_REQUEST): New macro, so that the issue of large requests
4840 is separated from the issue of spare memory.
4841
810928a2
AS
48422011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4843
172418ad
AS
4844 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4845 format. (Bug#8806)
4846
43f862f7
AS
4847 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4848
810928a2
AS
4849 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4850 before statements.
4851
a059fe24
JD
48522011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4853
4854 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4855
4856 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4857
4858 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4859 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4860
989bf368
JB
48612011-06-05 Juanma Barranquero <lekktu@gmail.com>
4862
4863 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4864
4b80f674
CY
48652011-06-04 Chong Yidong <cyd@stupidchicken.com>
4866
4867 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4868 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4869 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4870 New error handlers.
4b80f674
CY
4871 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4872 Obey Vx_select_enable_clipboard_manager. Catch errors in
4873 x_clipboard_manager_save (Bug#8779).
4874 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4875 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4876
99a33b77 48772011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4878
4879 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4880
99a33b77 48812011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4882
4883 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4884 in the current matrix if keep_current_p is non-zero.
4885
8264569d
EZ
48862011-06-04 Eli Zaretskii <eliz@gnu.org>
4887
4888 * bidi.c (bidi_level_of_next_char): Fix last change.
4889
57f97249
EZ
48902011-06-03 Eli Zaretskii <eliz@gnu.org>
4891
fec2107c 4892 Support bidi reordering of text covered by display properties.
57f97249 4893
fec2107c
EZ
4894 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4895 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4896 (bidi_cache_search, bidi_cache_iterator_state)
4897 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4898 (bidi_level_of_next_char, bidi_move_to_visually_next):
4899 Support character positions inside a run of characters covered by a
fec2107c
EZ
4900 display string.
4901 (bidi_paragraph_init, bidi_resolve_explicit_1)
4902 (bidi_level_of_next_char): Call bidi_fetch_char and
4903 bidi_fetch_char_advance instead of FETCH_CHAR and
4904 FETCH_CHAR_ADVANCE.
4905 (bidi_init_it): Initialize new members.
4906 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4907 definitions.
4908 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4909 instead of using explicit *_CHAR codes.
d6d100dd
SM
4910 (bidi_resolve_explicit, bidi_resolve_weak):
4911 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4912 bidirectional text is supported only in multibyte buffers.
4913 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4914 it to initialize the frame_window_p member of struct bidi_it.
4915 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4916 (bidi_resolve_explicit, bidi_resolve_weak)
4917 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4918 bidi_it->nchars is non-positive.
4919 (bidi_level_of_next_char): Don't try to lookup the cache for the
4920 next/previous character if nothing is cached there yet, or if we
4921 were just reseat()'ed to a new position.
c40e2fb2 4922
0e14fe90
EZ
4923 * xdisp.c (set_cursor_from_row): Set start and stop points
4924 according to the row's direction when priming the loop that looks
4925 for the glyph on which to display cursor.
4926 (single_display_spec_intangible_p): Function deleted.
4927 (display_prop_intangible_p): Reimplement to call
4928 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4929 Accept 3 additional arguments needed by handle_display_spec.
4930 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4931 values: lists, `(when COND...)' forms, etc.
4932 (single_display_spec_string_p): Support property values that are
4933 lists with the argument STRING its top-level element.
4934 (display_prop_string_p): Fix the condition for processing a
4935 property that is a list to be consistent with handle_display_spec.
fec2107c 4936 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4937 last portion of handle_display_prop.
4938 (compute_display_string_pos): Accept additional argument
4939 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4940 value of a `display' property is a "replacing spec".
4941 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4942 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4943 the display property, but just return a value indicating whether
4944 the display property will replace the characters it covers.
4945 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4946 frame_window_p members of struct bidi_it.
d6d100dd
SM
4947 (compute_display_string_pos, compute_display_string_end):
4948 New functions.
fec2107c
EZ
4949 (push_it): Accept second argument POSITION, where pop_it should
4950 jump to continue iteration.
4951 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4952
fec2107c
EZ
4953 * keyboard.c (adjust_point_for_property): Adjust the call to
4954 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4955
4956 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4957 (bidi_init_it): Update prototypes.
4958 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4959 (compute_display_string_pos, compute_display_string_end):
4960 Declare prototypes.
fec2107c
EZ
4961 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4962 EMACS_INT.
fc6f18ce 4963
40087514 49642011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4965
57f53182
PE
4966 Malloc failure behavior now depends on size of allocation.
4967 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4968 * lisp.h: Change signatures accordingly.
4969 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4970 All callers changed. (Bug#8762)
4971
4972 * gnutls.c: Use Emacs's memory allocators.
4973 Without this change, the gnutls library would invoke malloc etc.
4974 directly, which causes problems on non-SYNC_INPUT hosts, and which
4975 runs afoul of improving memory_full behavior. (Bug#8761)
4976 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4977 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4978 xfree instead of the default malloc, realloc, free.
4979 (Fgnutls_boot): No need to check for memory allocation failure,
4980 since xmalloc does that for us.
4981
ac32cd99 4982 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4983 * category.c (hash_get_category_set):
4984 * ccl.c (ccl_driver):
4985 * charset.c (Fdefine_charset_internal):
4986 * charset.h (struct charset.hash_index):
4987 * composite.c (get_composition_id, gstring_lookup_cache)
4988 (composition_gstring_put_cache):
4989 * composite.h (struct composition.hash_index):
4990 * dispextern.h (struct image.hash):
4991 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4992 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4993 (hashfn_equal, hashfn_user_defined, make_hash_table)
4994 (maybe_resize_hash_table, hash_lookup, hash_put)
4995 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4996 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4997 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4998 * image.c (make_image, search_image_cache, lookup_image)
4999 (xpm_put_color_table_h):
5000 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5001 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5002 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5003 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5004 * alloc.c (allocate_vectorlike):
5005 Check for overflow in vector size calculations.
5006 * ccl.c (ccl_driver):
5007 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5008 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5009 need to be updated by these changes.
40087514
PE
5010 * fns.c (make_hash_table, maybe_resize_hash_table):
5011 Check for integer overflow with large hash tables.
0de4bb68
PE
5012 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5013 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5014 (SXHASH_REDUCE): New macro.
5015 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5016 Use it instead of discarding useful hash info with large hash values.
5017 (sxhash_float): New function.
5018 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5019 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5020 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5021 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5022 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5023 Adjust signatures to match updated version of code.
5024 (consing_since_gc): Now EMACS_INT, since a single hash table can
5025 use more than INT_MAX bytes.
5026
698d32e2
DN
50272011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5028
5029 Make it possible to build with GCC-4.6+ -O2 -flto.
5030
5031 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5032
fd6fa53f
SM
50332011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5034
5035 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5036 Call minibuffer-inactive-mode.
5037
864db017
JB
50382011-05-31 Juanma Barranquero <lekktu@gmail.com>
5039
5040 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5041 Update dependencies.
5042
2ad0baf4
DN
50432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5044
5045 * data.c (init_data): Remove code for UTS, this system is not
5046 supported anymore.
5047
4fcc2638
DN
50482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5049
5050 Don't force ./temacs to start in terminal mode.
5051
5052 * frame.c (make_initial_frame): Initialize faces in all cases, not
5053 only when CANNOT_DUMP is defined.
5054 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5055
c56e0fd5
DN
50562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5057
5058 * dispnew.c (add_window_display_history): Use const for the string
5059 pointer. Remove declaration, not needed.
5060
333d54da 50612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5062
55d4c1b2 5063 Use 'inline', not 'INLINE'.
333d54da 5064 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5065 * alloc.c, fontset.c (INLINE): Remove.
5066 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5067 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5068 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5069 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5070 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5071
738db178
DN
50722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5073
5074 Make it possible to run ./temacs.
5075
5076 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5077 syms_of_callproc does the same thing. Remove test for
5078 "initialized", do it in the caller.
5079 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5080
620c53a6
SM
50812011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5082
5083 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5084 (read_minibuf): Use get_minibuffer.
5085 (syms_of_minibuf): Use DEFSYM.
5086 (Qmetadata): New var.
5087 * data.c (Qbuffer): Don't make it static.
5088 (syms_of_data): Use DEFSYM.
5089
e003a292
PE
50902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5091
5092 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5093 (CCL_CODE_MIN): New macro.
5094
ed008a6d
PE
50952011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5096
3687c2ef
PE
5097 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5098
ed008a6d
PE
5099 * eval.c (Qdebug): Now static.
5100 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5101 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5102 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5103
d66c4c7c
CY
51042011-05-29 Chong Yidong <cyd@stupidchicken.com>
5105
5106 * image.c: Various fixes to ImageMagick code comments.
5107 (Fimagemagick_types): Doc fix.
5108
5fbc2025
PE
51092011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5110
0196f88a
PE
5111 Minor fixes prompted by GCC 4.6.0 warnings.
5112
5113 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5114
5fbc2025
PE
5115 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5116 (x_clipboard_manager_save_all): Move extern decl to ...
5117 * xterm.h: ... here, so that it can be checked for consistency.
5118
1dd3c2d9
CY
51192011-05-29 Chong Yidong <cyd@stupidchicken.com>
5120
5121 * xselect.c (x_clipboard_manager_save_frame)
5122 (x_clipboard_manager_save_all): New functions.
5123 (Fx_clipboard_manager_save): Lisp function deleted.
5124
5125 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5126 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5127
5128 * xterm.h: Update prototype.
5129
5ba6571d
WX
51302011-05-28 William Xu <william.xwl@gmail.com>
5131
5132 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5133 exiting (Bug#8239).
5134
3eaff834
JM
51352011-05-28 Jim Meyering <meyering@redhat.com>
5136
e1900994 5137 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5138 * fns.c (to_uchar): Define.
5139 (crypto_hash_function): Use it to convert some newly-signed
5140 variables to unsigned, to avoid sign-extension bugs. For example,
5141 without this change, (md5 "truc") would evaluate to
5142 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5143 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5144 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5145
0f6990a7
PE
51462011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 Integer overflow fixes.
c8a9ca5a 5149
08686060
PE
5150 * dbusbind.c: Serial number integer overflow fixes.
5151 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5152 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5153 to hold a serial number that is too large for a fixnum.
5154 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5155 Check for serial numbers out of range. Decode any serial number
59568bf0 5156 that was so large that it became a float. (Bug#8722)
08686060 5157
2d1fc3c7
PE
5158 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5159 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5160 Use XFASTINT rather than XUINT when numbers are nonnegative.
5161 (xd_append_arg, Fdbus_method_return_internal):
5162 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5163 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5164 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5165 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5166 (Bug#8722)
2d1fc3c7 5167
c8a9ca5a
PE
5168 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5169
519e1d69
PE
5170 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5171
30569699
PE
5172 ccl: add integer overflow checks
5173 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5174 (IN_INT_RANGE): New macros.
5175 (ccl_driver): Use them to check for integer overflow when
5176 decoding a CCL program. Many of the new checks are whether XINT (x)
5177 fits in int; it doesn't always, on 64-bit hosts. The new version
5178 doesn't catch all possible integer overflows, but it's an
847044ea 5179 improvement. (Bug#8719)
30569699 5180
c11285dc
PE
5181 * alloc.c (make_event_array): Use XINT, not XUINT.
5182 There's no need for unsigned here.
5183
fdccd48e
PE
5184 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5185 This follows up to the 2011-05-06 change that substituted uintptr_t
5186 for EMACS_INT. This case wasn't caught back then.
5187
37910ab2
PE
5188 Rework Fformat to avoid integer overflow issues.
5189 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5190 now (part of C89). Include <verify.h>.
5191 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5192 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5193 (Fformat): Avoid the prepass trying to compute sizes; it was only
5194 approximate and thus did not catch overflow reliably. Instead, walk
5195 through the format just once, formatting and computing sizes as we go,
5196 checking for integer overflow at every step, and allocating a larger
5197 buffer as needed. Keep track separately whether the format is
5198 multibyte. Keep only the most-recently calculated precision, rather
5199 than them all. Record whether each argument has been converted to
5200 string. Use EMACS_INT, not int, for byte and char and arg counts.
5201 Support field widths and precisions larger than INT_MAX. Avoid
5202 sprintf's undefined behavior with conversion specifications such as %#d
5203 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5204 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5205 formatting out-of-range floating point numbers with int
9173deec 5206 formats. (Bug#8668)
37910ab2 5207
2e6578fb
PE
5208 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5209
0ae6bdee
PE
5210 * data.c: Avoid integer truncation in expressions involving floats.
5211 * data.c: Include <intprops.h>.
5212 (arith_driver): When there's an integer overflow in an expression
5213 involving floating point, convert the integers to floating point
5214 so that the resulting value does not suffer from catastrophic
5215 integer truncation. For example, on a 64-bit host (* 4
5216 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5217 Do not rely on undefined behavior after integer overflow.
5218
de883a70
PE
5219 merge count_size_as_multibyte, parse_str_to_multibyte
5220 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5221 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5222 Check for integer overflow.
5223 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5224 since it's now a duplicate of the other. This is more of
5225 a character than a buffer op, so better that it's in character.c.
5226 * fns.c, print.c: Adjust to above changes.
5227
2ff916cb
PE
52282011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5229
5230 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5231
f1b54466
PE
52322011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5233
fb1ac845
PE
5234 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5235 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5236 (x_clipboard_manager_save): Now static.
5237 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5238
f1b54466
PE
5239 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5240 (crypto_hash_function): Now static.
5241 Fix pointer signedness problems. Avoid unnecessary initializations.
5242
a9f737ee
CY
52432011-05-27 Chong Yidong <cyd@stupidchicken.com>
5244
5245 * termhooks.h (Vselection_alist): Make it terminal-local.
5246
5247 * terminal.c (create_terminal): Initialize it.
5248
5249 * xselect.c: Support for clipboard managers.
5250 (Vselection_alist): Move to termhooks.h as terminal-local var.
5251 (LOCAL_SELECTION): New macro.
5252 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5253 (symbol_to_x_atom): Remove gratuitous arg.
5254 (x_handle_selection_request, lisp_data_to_selection_data)
5255 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5256 (x_own_selection, x_get_local_selection, x_convert_selection):
5257 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5258 (some_frame_on_display): Delete unused function.
5259 (Fx_own_selection_internal, Fx_get_selection_internal)
5260 (Fx_disown_selection_internal, Fx_selection_owner_p)
5261 (Fx_selection_exists_p): New optional frame arg.
5262 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5263 (x_handle_selection_clear): Don't treat other terminals with the
5264 same keyboard specially. Use the terminal-local Vselection_alist.
5265 (x_clear_frame_selections): Use Frun_hook_with_args.
5266
5267 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5268
5269 * xterm.h: Add support for those atoms.
5270
e067f0c1
CY
52712011-05-26 Chong Yidong <cyd@stupidchicken.com>
5272
5273 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5274 (converted_selections, conversion_fail_tag): New global variables.
5275 (x_selection_request_lisp_error): Free the above.
5276 (x_get_local_selection): Remove unnecessary code.
5277 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5278 of converted selections stored in converted_selections.
5279 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5280 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5281 (x_convert_selection): New function.
5282 (x_handle_selection_event): Simplify.
5283 (x_get_foreign_selection): Don't ignore incoming requests while
5284 waiting for an answer; this will fail when we implement
5285 SAVE_TARGETS, and seems unnecessary anyway.
5286 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5287 (Vx_sent_selection_functions): Doc fix.
5288
0f4aebc0
LL
52892011-05-26 Leo Liu <sdl.web@gmail.com>
5290
5291 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5292
e61124cd
YM
52932011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5294
5295 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5296
5297 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5298 for fringe update if it has periodic bitmap.
ac389d0c 5299 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5300 and fringe_bitmap_periodic_p.
5301
5302 * fringe.c (get_fringe_bitmap_data): New function.
5303 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5304 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5305 row. Mark glyph row for fringe update if periodicity changed.
5306
5307 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5308 for fringe update unless it has periodic bitmap.
5309
f16d9837
KH
53102011-05-25 Kenichi Handa <handa@m17n.org>
5311
5312 * xdisp.c (get_next_display_element): Set correct it->face_id for
5313 a static composition.
5314
e1b90ef6
LL
53152011-05-24 Leo Liu <sdl.web@gmail.com>
5316
5317 * deps.mk (fns.o):
5318 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5319
5320 * fns.c (crypto_hash_function, Fsha1): New function.
5321 (Fmd5): Use crypto_hash_function.
5322 (syms_of_fns): Add Ssha1.
5323
7400048f
PE
53242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5325
5326 * gnutls.c: Remove unused macros.
5327 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5328 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5329 Remove macros that are defined and never used.
5330 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5331
abb71cf4
CY
53322011-05-22 Chong Yidong <cyd@stupidchicken.com>
5333
5334 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5335 (Fx_get_selection_internal): Minor cleanup.
5336 (Fx_own_selection_internal): Rename arguments for consistency with
5337 select.el.
5338
6307db39
PE
53392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5340
5341 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5342
f3d4e0a4
CY
53432011-05-22 Chong Yidong <cyd@stupidchicken.com>
5344
5345 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5346
4d8ade89
YM
53472011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5348
5349 * dispnew.c (scrolling_window): Don't exclude the case that the
5350 last enabled row in the desired matrix touches the bottom boundary.
5351
32078c8d
GM
53522011-05-21 Glenn Morris <rgm@gnu.org>
5353
5354 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5355 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5356 and add some more files.
32078c8d 5357
7285dc67
EZ
53582011-05-20 Eli Zaretskii <eliz@gnu.org>
5359
5360 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5361 report_file_error introduced by the change from 2011-05-07.
5362
89d1bd22
PE
53632011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5364
5365 * systime.h (Time): Define only if emacs is defined.
5366 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5367 where the include path doesn't have X11/X.h by default. See
5368 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5369
e23640bb 53702011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5371
5372 * composite.c (find_automatic_composition): Fix previous change.
5373
b9704ad9
GM
53742011-05-20 Glenn Morris <rgm@gnu.org>
5375
5376 * lisp.mk: New file, split from Makefile.in.
5377 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5378 (shortlisp): Remove.
5379 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5380
4a720484
GM
53812011-05-19 Glenn Morris <rgm@gnu.org>
5382
5383 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5384 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5385 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5386 (lisp): Set the order to that of loadup.el.
5387 (shortlisp): Make it a copy of $lisp.
5388 (SOME_MACHINE_LISP): Remove.
5389 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5390 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5391
a28d4396
KH
53922011-05-18 Kenichi Handa <handa@m17n.org>
5393
5394 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5395 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5396 (find_automatic_composition): Mostly rewrite for efficiency.
5397
a2b1fa8e
JB
53982011-05-18 Juanma Barranquero <lekktu@gmail.com>
5399
5400 * makefile.w32-in: Update dependencies.
5401
8e1f5610
CS
54022011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5403
5404 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5405 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5406
7025ee00 54072011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5408
cdfa6eab
PE
5409 Fix some integer overflow issues, such as string length overflow.
5410
06d6db33
PE
5411 * insdel.c (count_size_as_multibyte): Check for string overflow.
5412
2b4560a8
PE
5413 * character.c (lisp_string_width): Check for string overflow.
5414 Use EMACS_INT, not int, for string indexes and lengths; in
5415 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5416 the resulting string length overflows an EMACS_INT; instead,
5417 report a string overflow if no precision given. When checking for
5418 precision exhaustion, use a check that cannot possibly have
5419 integer overflow. (Bug#8675)
5420 * character.h (lisp_string_width): Adjust to new signature.
5421
cb93f9be
PE
5422 * alloc.c (string_overflow): New function.
5423 (Fmake_string): Use it. This doesn't change behavior, but saves
5424 a few bytes and will simplify future changes.
5425 * character.c (string_escape_byte8): Likewise.
5426 * lisp.h (string_overflow): New decl.
5427
1a1f3366
PE
5428 Fixups, following up to the user-interface timestamp change.
5429 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5430 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5431 * msdos.c (mouse_get_pos): Likewise.
5432 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5433 * w32gui.h (Time): Define by including "systime.h" rather than by
5434 declaring it ourselves. (Bug#8664)
5435
d4e3e4d3
PE
5436 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5437 * image.c (clear_image_cache): Likewise.
5438
f6a24d19
PE
5439 * term.c (term_mouse_position): Don't assume time_t wraparound.
5440
08dc5ae6
PE
5441 Be more systematic about user-interface timestamps.
5442 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5443 and sometimes 'EMACS_UINT', to represent these timestamps.
5444 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5445 This makes the code easier to follow, and makes it easier to catch
5446 integer overflow bugs such as Bug#8664.
5447 * frame.c (Fmouse_position, Fmouse_pixel_position):
5448 Use Time, not unsigned long, for user-interface timestamps.
5449 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5450 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5451 * keyboard.h (last_event_timestamp): Likewise.
5452 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5453 * menu.h (xmenu_show): Likewise.
5454 * term.c (term_mouse_position): Likewise.
5455 * termhooks.h (struct input_event.timestamp): Likewise.
5456 (struct terminal.mouse_position_hook): Likewise.
5457 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5458 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5459 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5460 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5461 what it was before.
5462 * menu.h, termhooks.h: Include "systime.h", for Time.
5463
8e55734a
PE
5464 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5465 Don't assume that the difference between two unsigned long values
5466 can fit into an integer. At this point, we know button_down_time
5467 <= event->timestamp, so the difference must be nonnegative, so
5468 there's no need to cast the result if double-click-time is
5469 nonnegative, as it should be; check that it's nonnegative, just in
5470 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5471 apart (about 25 days). (Bug#8664)
8e55734a 5472
841f1b75 5473 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5474 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5475
3e26f69c
PE
5476 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5477 that always fit in int. Use a sentinel instead of a counter, to
5478 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5479 * frame.h (struct frame): Use int for menu_bar_items_used
5480 instead of EMACS_INT, since it always fits in int.
3e26f69c 5481
5cc152c0
PE
5482 * menu.c (grow_menu_items): Check for int overflow.
5483
d89eb65e
PE
5484 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5485
5235bd3e
PE
5486 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5487 Before, the code was not consistent. These values cannot exceed
5488 2**31 - 1 so there's no need to make them unsigned.
5489 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5490 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5491 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5492 as modifiers.
5493 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5494
bc827e23
PE
5495 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5496 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5497 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5498 presumably because the widths might not match.
5499
78eb494e
PE
5500 * window.c (size_window): Avoid needless test at loop start.
5501
04f2d78b
CB
55022011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5503
5504 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5505
d2fc7e3d 55062011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5507
5508 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5509
d2fc7e3d 55102011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5511
5512 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5513 `width' to `bar_area_x' and `bar_area_width', respectively.
5514 (x_scroll_run): Take account of fringe background extension.
5515
04f2d78b
CB
5516 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5517 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5518 `bar_area_width', respectively.
5519 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5520 background extension.
5521
79b70037
GM
55222011-05-10 Jim Meyering <meyering@redhat.com>
5523
5524 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5525
2f142cc5
JB
55262011-05-10 Juanma Barranquero <lekktu@gmail.com>
5527
5528 * image.c (Finit_image_library): Return t for built-in image types,
5529 like pbm and xbm. (Bug#8640)
5530
57679c86
AS
55312011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5532
5533 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5534
888c9e86
EZ
55352011-05-07 Eli Zaretskii <eliz@gnu.org>
5536
b0512a1d
EZ
5537 * w32console.c (Fset_screen_color): Doc fix.
5538 (Fget_screen_color): New function.
5539 (syms_of_ntterm): Defsubr it.
5540
7285dc67
EZ
5541 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5542 unlink the temporary file if Fcall_process didn't create it in the
5543 first place.
5544 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5545 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5546 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5547 cue to call_process_cleanup not to close that handle.
5548
4d3fcc8e
BK
55492011-05-07 Ben Key <bkey76@gmail.com>
5550
5551 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5552 one of two shell specific rules, either bootstrap-temacs-CMD or
5553 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5554 to the previous implementation of the bootstrap-temacs rule.
5555 The bootstrap-temacs-CMD rule is similar to the previous
5556 implementation of the bootstrap-temacs rule except that it
5557 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5558 variable.
5559
5560 These changes, along with some changes to nt/configure.bat,
5561 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5562 earlier fix to add support for --cflags and --ldflags options
5563 that include quotes so that it works whether make uses cmd or
5564 sh as the shell.
5565
b4289b64
MA
55662011-05-06 Michael Albinus <michael.albinus@gmx.de>
5567
5568 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5569 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5570 is a constant.
5571 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5572 a string. Handle both cases.
5573 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5574 (Fdbus_register_method): Use Qinvalid_function.
5575
af4c0e28
JB
55762011-05-06 Juanma Barranquero <lekktu@gmail.com>
5577
5578 * makefile.w32-in: Update dependencies.
5579 (LISP_H): Add inttypes.h and stdin.h.
5580 (PROCESS_H): Add unistd.h.
5581
c51453d9
EZ
55822011-05-06 Eli Zaretskii <eliz@gnu.org>
5583
5584 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5585 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5586
8ff0ac3c 55872011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5588
4c4b566b
PE
5589 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5590
aab2b9b5
PE
5591 * term.c (vfatal): Remove stray call to va_end.
5592 It's not needed and the C Standard doesn't allow it here anyway.
5593
c378da0b
PE
5594 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5595 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5596
288b08c7
PE
5597 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5598 bytes.
5599
e3601888
PE
5600 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5601
db6c0e74
PE
5602 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5603
dd5963ea
PE
5604 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5605
88c9450f
PE
5606 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5607
2f9442b8
PE
5608 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5609
c032b5f8
PE
5610 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5611 * charset.c (Fdefine_charset_internal): Don't initialize
5612 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5613 32-bit int (Bug#8600).
a108c10b
PE
5614
5615 * lread.c (read_integer): Be more consistent with string-to-number.
5616 Use string_to_number to do the actual conversion; this avoids
5617 rounding errors and fixes some other screwups. Without this fix,
5618 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5619 (digit_to_number): Move earlier, for benefit of read_integer.
5620 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5621 not a digit in any supported base. (Bug#8602)
a108c10b 5622
ad5f9eea
PE
5623 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5624
aec1708a
PE
5625 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5626 to match comment at start of function. This also removes a
5627 GCC warning about overflow in a 32+64-bit port.
5628
47be4ab5
PE
5629 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5630
371cac43
PE
5631 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5632 Reported by Stefan Monnier in
5633 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5634 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5635 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5636
d01a7826
PE
5637 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5638 (EMACS_UINTPTR): Likewise, with uintptr_t.
5639
7fd47d5c
PE
5640 * lisp.h: Prefer 64-bit EMACS_INT if available.
5641 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5642 on 32-bit hosts that have 64-bit int, so that they can access
5643 large files.
122b0c86
PE
5644 However, temporarily disable this change unless the temporary
5645 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5646
8727937b
PE
5647 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5648
8ac068ac
PE
5649 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5650 This removes an assumption that EMACS_INT and long are the same
5651 width as pointers. The assumption is true for Emacs porting targets
5652 now, but we want to make other targets possible.
5653 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5654 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5655 In the rest of the code, change types of integers that hold casted
5656 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5657 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5658 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5659 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5660 No need to cast type when ORing.
5661 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5662 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5663 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5664 assume EMACS_INT is the same width as char *.
5665 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5666 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5667 Remove no-longer-needed casts.
5668 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5669 (xg_tool_bar_help_callback, xg_make_tool_item):
5670 Use EMACS_INTPTR to hold an integer
5671 that will be cast to void *; this can avoid a GCC warning
5672 if EMACS_INT is not the same width as void *.
5673 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5674 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5675 (current_message_1, set_message_1):
5676 Use a local to convert to proper width without a cast.
5677 * xmenu.c (dialog_selection_callback): Likewise.
5678
ede49d71
PE
5679 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5680 Also, don't assume VALBITS / RAND_BITS is less than 5,
5681 and don't rely on undefined behavior when shifting a 1 left into
5682 the sign bit.
5683 * lisp.h (get_random): Change signature to match.
5684
2f30ecd0
PE
5685 * lread.c (hash_string): Use size_t, not int, for hash computation.
5686 Normally we prefer signed values; but hashing is special, because
5687 it's better to use unsigned division on hash table sizes so that
5688 the remainder is nonnegative. Also, size_t is the natural width
5689 for hashing into memory. The previous code used 'int', which doesn't
5690 retain enough info to hash well into very large tables.
5691 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5692
2a866e7b
PE
5693 * dbusbind.c: Don't possibly lose pointer info when converting.
5694 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5695 Use XPNTR rather than XHASH, so that the high-order bits of
5696 the pointer aren't lost when converting through void *.
5697
51639eac
PE
5698 * eval.c (Fautoload): Don't double-shift a pointer.
5699
92394119
PE
5700 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5701
dbdb9a7c
JB
57022011-05-06 Juanma Barranquero <lekktu@gmail.com>
5703
5704 * gnutls.c (DEF_GNUTLS_FN):
5705 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5706
db7a0b4f
AS
57072011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5708
5709 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5710 marker. (Bug#8610)
5711
f7ff1b0f 57122011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5713
5714 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5715 New version that can reserve upto 2GB of heap space.
5716
f7ff1b0f 57172011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5718
5719 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5720
639c109b
TZ
57212011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5722
5723 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5724 `gnutls_certificate_set_x509_key_file'.
5725
d2127135
JB
57262011-05-05 Juanma Barranquero <lekktu@gmail.com>
5727
5728 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5729 Update dependencies.
5730
e968f4f3
JB
57312011-05-04 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5734 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5735 Remove unused parameter `fildes'.
5736 * process.c (read_process_output, send_process): Don't pass it.
5737
84d358f0
JB
57382011-05-04 Juanma Barranquero <lekktu@gmail.com>
5739
5740 Fix previous change: the library cache is defined in w32.c.
5741 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5742 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5743
0898ca10
JB
57442011-05-04 Juanma Barranquero <lekktu@gmail.com>
5745
5746 Implement dynamic loading of GnuTLS on Windows.
5747
5748 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5749 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5750 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5751 Declare.
5752
5753 * gnutls.c (Qgnutls_dll): Define.
5754 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5755 (gnutls_*): Declare function pointers.
5756 (init_gnutls_functions): New function to initialize function pointers.
5757 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5758 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5759 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5760 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5761 (emacs_gnutls_write, emacs_gnutls_read)
5762 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5763 (Fgnutls_available_p): New function.
5764 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5765 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5766 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5767
5768 * image.c: Include w32.h.
5769 (Vimage_type_cache): Delete.
5770 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5771 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5772 (w32_delayed_load): Move to w32.c.
5773
5774 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5775
5776 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5777 (w32_delayed_load): Move from image.c. When loading a library, record
5778 its filename in the :loaded-from property of the library id.
5779 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5780 Initialize and staticpro them.
5781 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5782
5783 * process.c: Include lisp.h before w32.h, not after.
5784 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5785 instead of gnutls_record_check_pending.
5786
5787 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5788
ff4de4aa
TZ
57892011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5790
5791 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5792 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5793 as passed in.
5794
abe95abb
JD
57952011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5796
5797 * xterm.c (x_set_frame_alpha): Do not set property on anything
5798 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5799
e16e55d4
JB
58002011-05-02 Juanma Barranquero <lekktu@gmail.com>
5801
5802 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5803
bafcf6a5
JB
58042011-05-02 Juanma Barranquero <lekktu@gmail.com>
5805
5806 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5807 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5808 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5809 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5810 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5811 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5812 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5813 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5814 (Qgnutls_bootprop_callbacks_verify): Make static.
5815
e7a6747f
AS
58162011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5817
19ed11ba
AS
5818 * callproc.c: Indentation fixup.
5819
e7a6747f 5820 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5821 (wait_for_termination, interruptible_wait_for_termination):
5822 Move after wait_for_termination_1.
e7a6747f 5823
1ef14cb4
LMI
58242011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5825
5826 * sysdep.c (interruptible_wait_for_termination): New function
5827 which is like wait_for_termination, but allows keyboard
5828 interruptions.
5829
5830 * callproc.c (Fcall_process): Add (:file "file") as an option for
5831 the STDOUT buffer.
5832 (Fcall_process_region): Ditto.
5833
330d880c
EZ
58342011-04-30 Eli Zaretskii <eliz@gnu.org>
5835
8db90b73
EZ
5836 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5837 rather than `XVECTOR (FOO)->size'.
5838
330d880c
EZ
5839 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5840 inttypes.h, as a gnulib replacement is used if it not available in
5841 system headers.
5842
15cbd324
EZ
58432011-04-21 Eli Zaretskii <eliz@gnu.org>
5844
5845 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5846 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5847 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5848
5849 * coding.c (coding_alloc_by_realloc): Error out if destination
5850 will grow beyond MOST_POSITIVE_FIXNUM.
5851 (decode_coding_emacs_mule): Abort if there isn't enough place in
5852 charbuf for the composition carryover bytes. Reserve an extra
5853 space for up to 2 characters produced in a loop.
5854 (decode_coding_iso_2022): Abort if there isn't enough place in
5855 charbuf for the composition carryover bytes.
5856
58572011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5858
ae940cca
EZ
5859 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5860 aborting when %lld or %lll format is passed.
5861 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5862 %llo or %llx format is passed. (Bug#8545)
5863
03ab8921
EZ
5864 * window.c (window_scroll_line_based): Use a marker instead of
5865 simple variables to record original value of point. (Bug#7952)
5866
afda1437
EZ
5867 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5868 produced by %s or %c overflows available buffer space. (Bug#8545)
5869
f76dee0c
PE
58702011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5871
5872 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5873 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5874
fdc5744d
JB
58752011-04-28 Juanma Barranquero <lekktu@gmail.com>
5876
5877 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5878
638f053a
JB
58792011-04-28 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * keyboard.c (Qdelayed_warnings_hook): Define.
5882 (command_loop_1): Run `delayed-warnings-hook'
5883 if Vdelayed_warnings_list is non-nil.
5884 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5885 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5886
d178f871
EZ
58872011-04-28 Eli Zaretskii <eliz@gnu.org>
5888
5889 * doprnt.c (doprnt): Don't return value smaller than the buffer
5890 size if the message was truncated. (Bug#8545).
5891
b124fd93
JB
58922011-04-28 Juanma Barranquero <lekktu@gmail.com>
5893
5894 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5895 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5896
e810457d
PE
58972011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5898
5899 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5900
ea51cceb
JB
59012011-04-27 Juanma Barranquero <lekktu@gmail.com>
5902
5903 * makefile.w32-in: Update dependencies.
5904
94dcfacf
EZ
59052011-04-27 Eli Zaretskii <eliz@gnu.org>
5906
5907 Improve `doprnt' and its usage. (Bug#8545)
5908 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5909 `format_end'. Remove support for %l as a conversion specifier.
5910 Don't use xrealloc. Improve diagnostics when the %l size modifier
5911 is used. Update the commentary.
5912
5913 * eval.c (verror): Simplify calculation of size_t.
5914
5915 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5916 messages.
5917
f61f41d7
PE
59182011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5919
5920 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5921 change.
5922
96fb4434
PE
59232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5926 This makes this file independent of the recent pseudovector change.
5927
671875da 59282011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5929
69e9b5a3
PE
5930 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5931
b5f869a7 5932 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5933 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5934 Remove unused local.
c8926152 5935 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5936
841a1577 5937 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5938 GCC 4.6.0 optimizes based on type-based alias analysis.
5939 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5940 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5941 != &v->size, and therefore "v->size = 1; b->size = 2; return
5942 v->size;" must therefore return 1. This assumption is incorrect
5943 for Emacs, since it type-puns struct Lisp_Vector * with many other
5944 types. To fix this problem, this patch adds a new type struct
f904488f 5945 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5946 and pseudovectors, and helps optimizing compilers not get fooled
5947 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5948 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5949 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5950 the size member.
eab3844f
PE
5951 (XSETPVECTYPE): Rewrite in terms of new macro.
5952 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5953 This is a bit clearer, and further avoids the possibility of
5954 undesirable aliasing.
5955 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5956 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5957 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5958 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5959 (ASIZE): Now uses header.size rather than size.
5960 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5961 to avoid the hassle of writing XVECTOR (foo)->header.size.
5962 (struct vectorlike_header): New type.
eab3844f
PE
5963 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5964 object, to help avoid aliasing.
5965 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5966 (SUBRP): Likewise, since Lisp_Subr is a special case.
5967 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5968 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5969 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5970 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5971 changed to be "header.size" and "header.next".
5972 * buffer.h (struct buffer): Likewise.
5973 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5974 * frame.h (struct frame): Likewise.
5975 * process.h (struct Lisp_Process): Likewise.
5976 * termhooks.h (struct terminal): Likewise.
5977 * window.c (struct save_window_data, struct saved_window): Likewise.
5978 * window.h (struct window): Likewise.
5979 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5980 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5981 * buffer.c (init_buffer_once): Likewise.
5982 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5983 special case.
5984 * process.c (Fformat_network_address): Use local var for size,
5985 for brevity.
5986
0df1eac5
PE
5987 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5988
847ab9d1 5989 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5990 * data.c (atof): Remove decl; no longer used or needed.
5991 (digit_to_number): Move to lread.c.
5992 (Fstring_to_number): Use new string_to_number function, to be
5993 consistent with how the Lisp reader treats infinities and NaNs.
5994 Do not assume that floating-point numbers represent EMACS_INT
5995 without losing information; this is not true on most 64-bit hosts.
5996 Avoid double-rounding errors, by insisting on integers when
5997 parsing non-base-10 numbers, as the documentation specifies.
5998 * lisp.h (string_to_number): New decl, replacing ...
5999 (isfloat_string): Remove.
bc0a5c13 6000 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6001 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6002 appears to have been a coding error. Similarly, do not accept
6003 strings like +-1e0 as floating point numbers. Do not report
6004 overflow for integer overflows unless the base is not 10 which
6005 means we have no simple and reliable way to continue.
6006 Break out the floating-point parsing into a new
6007 function string_to_number, so that Fstring_to_number parses
6008 floating point numbers consistently with the Lisp reader.
04f2d78b 6009 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6010 (E_CHAR, EXP_INT): Remove, replacing with ...
6011 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6012 (string_to_number): New function, replacing isfloat_string.
6013 This function checks for valid syntax and produces the resulting
6014 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6015 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6016 so that overflow for non-base-10 numbers is reported only when
6017 there's no portable and simple way to convert to floating point.
452f4150 6018
67769ffc
PE
6019 * textprop.c (set_text_properties_1): Rewrite for clarity,
6020 and to avoid GCC warning about integer overflow.
6021
c20db43f
PE
6022 * intervals.h (struct interval): Use EMACS_INT for members
6023 where EMACS_UINT might cause problems. See
6024 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6025 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6026 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6027 All uses changed.
37aa2f85
PE
6028 (offset_intervals): Tell GCC not to worry about length overflow
6029 when negating a negative length.
c20db43f 6030
2538aa2f
PE
6031 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6032 (overrun_check_free): Likewise.
6033
f2d3008d
PE
6034 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6035 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6036 word size.
6037
ec8df744
PE
6038 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6039 (gnutls_make_error): Rename local to avoid shadowing.
6040 (gnutls_emacs_global_deinit): ifdef out; not used.
6041 (Fgnutls_boot): Use const for pointer to readonly storage.
6042 Comment out unused local. Fix pointer signedness problems.
6043
640ee02d
PE
6044 * lread.c (openp): Don't stuff size_t into an 'int'.
6045 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6046 about possible signed overflow.
6047
6048fb2a
PE
6048 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6049 (GDK_KEY_g): Don't define if already defined.
6050 (xg_prepare_tooltip): Avoid pointer signedness problem.
6051 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6052
fa3c87e1
PE
6053 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6054 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6055
2172544b
PE
6056 * xfns.c (Fx_window_property): Simplify a bit,
6057 to make a bit faster and to avoid GCC 4.6.0 warning.
6058 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6059
9b821a21
PE
6060 * fns.c (internal_equal): Don't assume size_t fits in int.
6061
3c616cfa
PE
6062 * alloc.c (compact_small_strings): Tighten assertion a little.
6063
c2982e87
PE
6064 Replace pEd with more-general pI, and fix some printf arg casts.
6065 * lisp.h (pI): New macro, generalizing old pEd macro to other
6066 conversion specifiers. For example, use "...%"pI"d..." rather
6067 than "...%"pEd"...".
6068 (pEd): Remove. All uses replaced with similar uses of pI.
6069 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6070 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6071 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6072 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6073 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6074 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6075 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6076 64-bit hosts.
6077 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6078 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6079 * print.c (safe_debug_print, print_object): Likewise.
6080 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6081 to int.
6f04d126
PE
6082 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6083 avoiding the 0 flag, which is not portable.
c2982e87
PE
6084 * process.c (Fmake_network_process): Use pI to avoid cast.
6085 * region-cache.c (pp_cache): Likewise.
6086 * xdisp.c (decode_mode_spec): Likewise.
6087 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6088 behavior on 64-bit hosts with printf arg.
6f04d126 6089 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6090 (x_stop_queuing_selection_requests): Likewise.
6091 (x_get_window_property): Don't truncate byte count to an 'int'
6092 when tracing.
0b432f21 6093
5e073ec7
PE
6094 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6095 here, since it parses constructs like leading '-' and spaces,
6096 which are not wanted; and it overflows with large numbers.
6097 Instead, simply match F[0-9]+, which is what is wanted anyway.
6098
36372bf9
PE
6099 * alloc.c: Remove unportable assumptions about struct layout.
6100 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6101 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6102 (allocate_vectorlike, make_pure_vector): Use the new macros,
6103 plus offsetof, to remove unportable assumptions about struct layout.
6104 These assumptions hold on all porting targets that I know of, but
6105 they are not guaranteed, they're easy to remove, and removing them
6106 makes further changes easier.
6107
0b432f21
PE
6108 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6109 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6110 (string_overrun_cookie): Now const. Use initializers that
6111 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6112 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6113 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6114 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6115 multiple of sizeof (EMACS_INT); it need not be, if
6116 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6117 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6118
895009e1
JB
61192011-04-26 Juanma Barranquero <lekktu@gmail.com>
6120
6121 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6122
6a7a1b0b
TZ
61232011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6124
6125 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6126 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6127 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6128
841a1577 61292011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6130
6131 * lisp.h (Qdebug): List symbol.
895009e1 6132 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6133 * keyboard.c (debug-on-event): New variable.
6134 (handle_user_signal): Break into debugger when debug-on-event
6135 matches the current signal symbol.
6136
f2d3ba6f
DN
61372011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6138
6139 * alloc.c (check_sblock, check_string_bytes)
6140 (check_string_free_list): Convert to standard C.
6141
42ce4c63
TZ
61422011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6143
6144 * w32.c (emacs_gnutls_push): Fix typo.
6145
825cd63c
EZ
61462011-04-25 Eli Zaretskii <eliz@gnu.org>
6147
fb11d64d
EZ
6148 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6149 "cast to pointer from integer of different size".
6150
825cd63c
EZ
6151 Improve doprnt and its use in verror. (Bug#8545)
6152 * doprnt.c (doprnt): Document the set of format control sequences
6153 supported by the function. Use SAFE_ALLOCA instead of always
6154 using `alloca'.
6155
6156 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6157 is one byte too soon. Don't use xrealloc; instead xfree and
6158 xmalloc anew.
6159
e061a11b
TZ
61602011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6161
6162 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6163 callbacks stage.
6164
6165 * gnutls.c: Renamed global_initialized to
6166 gnutls_global_initialized. Added internals for the
6167 :verify-hostname-error, :verify-error, and :verify-flags
6168 parameters of `gnutls-boot' and documented those parameters in the
6169 docstring. Start callback support.
9173deec
JB
6170 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6171 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6172 on error. Return error code.
e061a11b
TZ
6173 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6174 (emacs_gnutls_read): Likewise.
6175 (Fgnutls_boot): Return handshake error code.
6176 (emacs_gnutls_handle_error): New function.
6177 (wsaerror_to_errno): Likewise.
6178
6179 * w32.h (emacs_gnutls_pull): Add prototype.
6180 (emacs_gnutls_push): Likewise.
6181
6182 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6183 (emacs_gnutls_push): Likewise.
6184
61852011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6186
6187 * process.c (wait_reading_process_output): Check if GnuTLS
6188 buffered some data internally if no FDs are set for TLS
6189 connections.
6190
6191 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6192 (LIBS): Link to USER_LIBS.
6193 ($(BLD)/gnutls.$(0)): New target.
6194
fa6996bc
EZ
61952011-04-24 Eli Zaretskii <eliz@gnu.org>
6196
eb35682e
EZ
6197 * xdisp.c (handle_single_display_spec): Rename the
6198 display_replaced_before_p argument into display_replaced_p, to
6199 make it consistent with the commentary. Fix typos in the
6200 commentary.
6201
e2ad650c
EZ
6202 * textprop.c (syms_of_textprop): Remove dead code.
6203 (copy_text_properties): Delete obsolete commentary about an
6204 interface that was deleted long ago. Fix typos in the description
6205 of arguments.
6206
1b2de274
EZ
6207 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6208 to changes in oldXMenu/XMenu.h from 2011-04-16.
6209 <menu_help_message, prev_menu_help_message>: Constify.
6210 (IT_menu_make_room): menu->help_text is now `const char **';
6211 adjust.
6212
6213 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6214 to changes in oldXMenu/XMenu.h from 2011-04-16.
6215 (struct XMenu): Declare `help_text' `const char **'.
6216
6217 * xfaces.c <Qunspecified>: Make extern again.
6218
6219 * syntax.c: Include sys/types.h before including regex.h, as
6220 required by Posix.
6221
762b15be
EZ
6222 * doc.c (get_doc_string): Improve the format passed to `error'.
6223
6224 * doprnt.c (doprnt): Improve commentary.
6225
6226 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6227
6228 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6229 them with etags.
6230
f1052e5d
EZ
6231 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6232 changes in globals.h immediately force recompilation.
762b15be
EZ
6233 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6234 $(CURDIR)/s/ms-w32.h.
6235 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6236
fa6996bc
EZ
6237 * character.c (Fchar_direction): Function deleted.
6238 (syms_of_character): Don't defsubr it.
6239 <char-direction-table>: Deleted.
6240
e6c3da20
EZ
62412011-04-23 Eli Zaretskii <eliz@gnu.org>
6242
6243 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6244 * doprnt.c: Include limits.h.
6245 (SIZE_MAX): New macro.
04f2d78b
CB
6246 (doprnt): Return a size_t value. 2nd arg is now size_t.
6247 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6248 Improve overflow protection. Support `l' modifier for integer
6249 conversions. Support %l conversion. Don't assume an EMACS_INT
6250 argument for integer conversions and for %c.
6251
6252 * lisp.h (doprnt): Restore prototype.
6253
6254 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6255 $(SRC)/character.h.
6256
6257 * Makefile.in (base_obj): Add back doprnt.o.
6258
6259 * deps.mk (doprnt.o): Add back prerequisites.
6260 (callint.o): Depend on character.h.
6261
6262 * eval.c (internal_lisp_condition_case): Include the handler
6263 representation in the error message.
6264 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6265 when breaking from the loop.
6266
6267 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6268
6269 * callint.c (Fcall_interactively): When displaying error message
6270 about invalid control letter, pass the character's codepoint, not
6271 a pointer to its multibyte form. Improve display of the character
6272 in octal and display also its hex code.
6273
6274 * character.c (char_string): Use %x to display the (unsigned)
6275 codepoint of an invalid character, to avoid displaying a bogus
6276 negative value.
6277
6278 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6279 `error', not SYMBOL_NAME itself.
6280
6281 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6282 character arguments to `error'.
6283
6284 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6285 to `error' in error message about FINAL_CHAR argument. Make sure
6286 FINAL_CHAR is a character, and use %c when it is passed as
6287 argument to `error'.
6288
4ffd0d6b 62892011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6290
6291 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6292
6293 * w32.c: Include <time.h>.
6294 (sys_localtime): New function.
6295
4ffd0d6b 62962011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6297
6298 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6299
4ffd0d6b 6300 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6301
4ffd0d6b 63022011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6303
4ffd0d6b
GM
6304 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6305 zombies (Bug#8467).
aac0c6e3 6306
04c56954
EZ
63072011-04-19 Eli Zaretskii <eliz@gnu.org>
6308
6309 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6310 gl_state.e_property when gl_state.object is Qt.
6311
6312 * insdel.c (make_gap_larger): Remove limitation of buffer size
6313 to <= INT_MAX.
6314
16a43933
CY
63152011-04-18 Chong Yidong <cyd@stupidchicken.com>
6316
6317 * xdisp.c (lookup_glyphless_char_display)
6318 (produce_glyphless_glyph): Handle cons cell entry in
6319 glyphless-char-display.
6320 (Vglyphless_char_display): Document it.
6321
6322 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6323 glyphless-char-display.
6324
4581706e
CY
63252011-04-17 Chong Yidong <cyd@stupidchicken.com>
6326
6327 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6328
6329 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6330
6331 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6332 definition for no-X builds.
6333
4887c6e2 63342011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6335
fd35b6f9
PE
6336 Static checks with GCC 4.6.0 and non-default toolkits.
6337
5c1ccb01
PE
6338 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6339
006c5daa
PE
6340 * process.c (keyboard_bit_set): Define only if SIGIO.
6341 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6342 (send_process): Repair possible setjmp clobbering.
6343
efc736d3
PE
6344 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6345
4e2fe2e6
PE
6346 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6347
f97334a2
PE
6348 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6349
4e75f29d
PE
6350 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6351 Define only if needed.
6352
90efadd1
PE
6353 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6354 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6355 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6356
3c647824
PE
6357 * dispextern.h (struct redisplay_interface): Rename param
6358 to avoid shadowing.
e264f262 6359 * termhooks.h (struct terminal): Likewise.
761383f4 6360 * xterm.c (xembed_send_message): Likewise.
3c647824 6361
b58c5c4a
PE
6362 * insdel.c (make_gap_smaller): Define only if
6363 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6364
cad59032
PE
6365 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6366 it.
6367
c339dc2e
PE
6368 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6369 so that we aren't warned about unused symbols.
6370
91a3e27b
PE
6371 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6372
399c71d3 6373 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6374
8ffc96f5
PE
6375 * xfns.c (x_real_positions): Mark locals as initialized.
6376
eef9bc79
PE
6377 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6378
098db9dd
PE
6379 * xterm.c: Fix problems found by static analysis with other toolkits.
6380 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6381 (x_dispatch_event): Declare static if USE_GTK, and
6382 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6383 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6384 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6385 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6386 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6387
eb18f6cc
PE
6388 * xmenu.c (menu_help_callback): Pointer type fixes.
6389 Use const pointers when pointing at readonly data. Avoid pointer
6390 signedness clashes.
6391 (FALSE): Remove unused macro.
6392 (update_frame_menubar): Remove unused decl.
6393
1fe72bf8
PE
6394 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6395
60d9e1db
PE
6396 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6397 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6398 (single_menu_item): Rename local to avoid shadowing.
6399
39261c26
PE
6400 * keyboard.c (make_lispy_event): Remove unused local var.
6401
018c5e19
PE
6402 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6403 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6404
63d2b86e
PE
6405 * bitmaps: Change bitmaps from unsigned char back to the X11
6406 compatible char. Avoid the old compiler warnings about
6407 out-of-range initializers by using, for example, '\xab' rather
6408 than 0xab.
6409
aefd87e1
PE
6410 * xgselect.c (xgselect_initialize): Check vs interface
6411 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6412
bf501fb9
PE
6413 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6414
e9829fdf
PE
6415 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6416 to read-only memory.
6417
1086c095
PE
6418 * fns.c (vector): Remove; this old hack is no longer needed.
6419
2baccd04 6420 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6421 Remove unused var.
dde42981 6422 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6423
72391843 6424 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6425
436c16df 6426 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6427 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6428 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6429
92bb796d 6430 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6431 (x_term_init): Remove local to avoid shadowing.
92bb796d 6432
764430a3 6433 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6434
6435 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6436 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6437
d1dfb56c
EZ
64382011-04-16 Eli Zaretskii <eliz@gnu.org>
6439
c4354cb4
EZ
6440 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6441
d1dfb56c
EZ
6442 Fix regex.c, syntax.c and friends for buffers > 2GB.
6443 * syntax.h (struct gl_state_s): Declare character position members
6444 EMACS_INT.
6445
6446 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6447
04f2d78b
CB
6448 * textprop.c (verify_interval_modification, interval_of):
6449 Declare arguments EMACS_INT.
d1dfb56c
EZ
6450
6451 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6452 EMACS_INT.
6453
6454 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6455
6456 * indent.c (Fvertical_motion): Local variable it_start is now
6457 EMACS_INT.
6458
6459 * regex.c (re_match, re_match_2, re_match_2_internal)
6460 (bcmp_translate, regcomp, regexec, print_double_string)
6461 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6462 (re_compile_pattern, re_exec): Declare arguments and local
6463 variables `size_t' and `ssize_t' and return values `regoff_t', as
6464 appropriate.
6465 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6466 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6467 <compile_stack_type>: `size' and `avail' are now `size_t'.
6468
6469 * regex.h <regoff_t>: Use ssize_t, not int.
6470 (re_search, re_search_2, re_match, re_match_2): Arguments that
6471 specify buffer/string position and length are now ssize_t and
6472 size_t. Return type is regoff_t.
6473
613052cd
BK
64742011-04-16 Ben Key <bkey76@gmail.com>
6475
6476 * nsfont.m: Fixed bugs in ns_get_family and
6477 ns_descriptor_to_entity that were caused by using free to
6478 deallocate memory blocks that were allocated by xmalloc (via
6479 xstrdup). This caused Emacs to crash when compiled with
6480 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6481 --enable-checking=xmallocoverrun). xfree is now used to
6482 deallocate these memory blocks.
6483
4170f62f 64842011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6485
71b41406
PE
6486 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6487
9587a89d
PE
6488 emacs_write: Accept and return EMACS_INT for sizes.
6489 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6490 et seq.
6491 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6492 Accept and return EMACS_INT.
6493 (emacs_gnutls_write): Return the number of bytes written on
6494 partial writes.
6495 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6496 (emacs_read, emacs_write): Remove check for negative size, as the
6497 Emacs source code has been audited now.
9587a89d
PE
6498 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6499 (emacs_read, emacs_write): Use it.
273a5f82
PE
6500 * process.c (send_process): Adjust to the new signatures of
6501 emacs_write and emacs_gnutls_write. Do not attempt to store
6502 a byte offset into an 'int'; it might overflow.
9587a89d 6503 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6504
3e047f51
PE
6505 * sound.c: Don't assume sizes fit in 'int'.
6506 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6507 Return EMACS_INT, not int.
3e047f51 6508 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6509 Accept EMACS_INT, not int.
6510 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6511 record read return values.
6512
cc39a9db
BK
65132011-04-15 Ben Key <bkey76@gmail.com>
6514
c9d0ec6d
JB
6515 * keyboard.c (Qundefined): Don't declare static since it is used
6516 in nsfns.m.
6517 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6518 static since they are used in nsfont.m.
cc39a9db 6519
6c60eb9f
SM
65202011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6521
6522 * process.c (Qprocessp): Don't declare static.
6523 * lisp.h (Qprocessp): Declare again.
6524
7990b61a
JB
65252011-04-15 Juanma Barranquero <lekktu@gmail.com>
6526
6527 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6528
5d4cb038
PE
65292011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6530
8bd7b830 6531 Improve C-level modularity by making more things 'static'.
cd64ea1d 6532
e3b27b31
PE
6533 Don't publish debugger-only interfaces to other modules.
6534 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6535 (verify_bytepos, count_markers): Move decls to the only modules
6536 that need them.
6537 * region-cache.h (pp_cache): Likewise.
6538 * window.h (check_all_windows): Likewise.
6539 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6540
5d4cb038
PE
6541 * sysdep.c (croak): Now static, if
6542 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6543 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6544
6545 * alloc.c (refill_memory_reserve): Now static if
6546 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6547 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6548
e87b6180
PE
6549 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6550 Define only if USE_LUCID.
6551
ac64929e
PE
6552 * xrdb.c (x_customization_string, x_rm_string): Now static.
6553
6f37259d
PE
6554 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6555 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6556
1683e3ab
PE
6557 * xdisp.c (draw_row_with_mouse_face): Now static.
6558 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6559
de9c2632
PE
6560 * window.h (check_all_windows): Mark externally visible.
6561
2b96acb7
PE
6562 * window.c (window_deletion_count): Now static.
6563
6564 * undo.c: Make symbols static if they're not exported.
6565 (last_undo_buffer, last_boundary_position, pending_boundary):
6566 Now static.
6567
50436f33
PE
6568 * textprop.c (interval_insert_behind_hooks): Now static.
6569 (interval_insert_in_front_hooks): Likewise.
6570
64520e5c
PE
6571 * term.c: Make symbols static if they're not exported.
6572 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6573 (max_frame_lines, tty_set_terminal_modes):
6574 (tty_reset_terminal_modes, tty_turn_off_highlight):
6575 (get_tty_terminal): Now static.
6576 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6577 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6578 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6579 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6580 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6581
1fa53021
PE
6582 * sysdep.c: Make symbols static if they're not exported.
6583 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6584 Now static.
6585 (sigprocmask_set, full_mask): Remove; unused.
6586 (wait_debugging): Mark as visible.
6587 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6588 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6589
d4b43b22
PE
6590 * syntax.c (syntax_temp): Define only if !__GNUC__.
6591
b7c513d0
PE
6592 * sound.c (current_sound_device, current_sound): Now static.
6593
989b29ad
PE
6594 * search.c (searchbufs, searchbuf_head): Now static.
6595
13a55a78
PE
6596 * scroll.c (scroll_cost): Remove; unused.
6597 * dispextern.h (scroll_cost): Remove decl.
6598
de68a1fc
PE
6599 * region-cache.h (pp_cache): Mark as externally visible.
6600
40ccffa6
PE
6601 * process.c: Make symbols static if they're not exported.
6602 (process_tick, update_tick, create_process, chan_process):
6603 (Vprocess_alist, proc_buffered_char, datagram_access):
6604 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6605 (deactivate_process): Mark defn as static, as well as decl.
6606 * lisp.h (create_process): Remove decl.
6607 * process.h (chan_process, Vprocess_alist): Remove decls.
6608
ad64fc97
PE
6609 * print.c: Make symbols static if they're not exported.
6610 (print_depth, new_backquote_output, being_printed, print_buffer):
6611 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6612 (print_interval, print_number_index, initial_stderr_stream):
6613 Now static.
6614 * lisp.h (Fprinc): Remove decl.
6615 (debug_output_compilation_hack): Mark as externally visible.
6616
adddb265
PE
6617 * sysdep.c (croak): Move decl from here to syssignal.h.
6618 * syssignal.h (croak): Put it here, so the API can be checked when
6619 'croak' is called from dissociate_if_controlling_tty.
6620
1717ede2
PE
6621 * minibuf.c: Make symbols static if they're not exported.
6622 (minibuf_save_list, choose_minibuf_frame): Now static.
6623 * lisp.h (choose_minibuf_frame): Remove decl.
6624
fa5fb2bc
PE
6625 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6626
1e3890d1
PE
6627 * lread.c: Make symbols static if they're not exported.
6628 (read_objects, initial_obarray, oblookup_last_bucket_number):
6629 Now static.
6630 (make_symbol): Remove; unused.
6631 * lisp.h (initial_obarray, make_symbol): Remove decls.
6632
8a1414fa
PE
6633 * keyboard.c: Make symbols static if they're not exported.
6634 (single_kboard, recent_keys_index, total_keys, recent_keys):
6635 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6636 (this_single_command_key_start, echoing, last_auto_save):
6637 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6638 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6639 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6640 (Vlispy_mouse_stem, double_click_count):
6641 Now static.
6642 (force_auto_save_soon): Define only if SIGDANGER.
6643 (ignore_mouse_drag_p): Now static if
6644 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6645 (print_help): Remove; unused.
6646 (stop_character, last_timer_event): Mark as externally visible.
6647 * keyboard.h (ignore_mouse_drag_p): Declare only if
6648 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6649 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6650 * lisp.h (echoing): Remove decl.
6651 (force_auto_save_soon): Declare only if SIGDANGER.
6652 * xdisp.c (redisplay_window): Simplify code, to make it more
6653 obvious that ignore_mouse_drag_p is not accessed if !defined
6654 USE_GTK && !defined HAVE_NS.
6655
93ea6e8f
PE
6656 * intervals.c: Make symbols static if they're not exported.
6657 (merge_properties_sticky, merge_interval_right, delete_interval):
6658 Now static.
6659 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6660
77382fcc
PE
6661 * insdel.c: Make symbols static if they're not exported.
6662 However, leave prepare_to_modify_buffer alone. It's never
6663 called from outside this function, but that appears to be a bug.
6664 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6665 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6666 (adjust_after_replace_noundo): Remove; unused.
6667 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6668 (signal_before_change): Remove decls.
77382fcc 6669
9306c32e
PE
6670 * indent.c (val_compute_motion, val_vmotion): Now static.
6671
cd44d2eb
PE
6672 * image.c: Make symbols static if they're not exported.
6673 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6674 if USE_GTK.
6675 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6676 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6677
ad9a7a06
PE
6678 * fringe.c (standard_bitmaps): Now static.
6679 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6680
81626931
PE
6681 * frame.c: Make symbols static if they're not exported.
6682 (x_report_frame_params, make_terminal_frame): Now static.
6683 (get_frame_param): Now static, unless HAVE_NS.
6684 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6685 (x_get_resource_string): Remove; not used.
6686 * frame.h (make_terminal_frame, x_report_frame_params):
6687 (x_get_resource_string); Remove decls.
6688 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6689 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6690
239f9db9
PE
6691 * font.c, fontset.c: Make symbols static if they're not exported.
6692 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6693 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6694 * font.c (font_close_object): Now static.
6695 * font.h (font_close_object): Remove.
6696 * fontset.c (FONTSET_OBJLIST): Remove.
6697 (free_realized_fontset) #if-0 the body, which does nothing.
6698 (face_suitable_for_char_p): #if-0, as it's never called.
6699 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6700 * xfaces.c (face_at_string_position):
6701 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6702 since 0 is always ASCII.
6703
dfcf3579
PE
6704 * fns.c (weak_hash_tables): Now static.
6705
5045092b
PE
6706 * fileio.c: Make symbols static if they're not exported.
6707 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6708 (Vwrite_region_annotation_buffers): Now static.
6709
57a96f5c
PE
6710 * eval.c: Make symbols static if they're not exported.
6711 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6712 * lisp.h (backtrace_list): Remove decl.
6713
35f08c38
PE
6714 * emacs.c: Make symbols static if they're not exported.
6715 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6716 (fatal_error_code, fatal_error_signal_hook, standard_args):
6717 Now static.
6718 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6719 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6720 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6721 * lisp.h (fatal_error_signal_hook): Remove decl.
6722 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6723
f44bd759
PE
6724 * editfns.c: Move a (normally-unused) function to its only use.
6725 * editfns.c, lisp.h (get_operating_system_release): Remove.
6726 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6727 worth the hassle of breaking this out.
6728
b532497d
PE
6729 * xterm.c: Make symbols static if they're not exported.
6730 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6731 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6732 (x_destroy_window, x_delete_display):
6733 Now static.
6734 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6735 (x_mouse_leave): Remove; unused.
6736 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6737 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6738 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6739 Remove decls.
6740 (x_mouse_leave): Declare only if WINDOWSNT.
6741 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6742 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6743 USE_X_TOOLKIT.
6744
1675728f
PE
6745 * ftxfont.c: Make symbols static if they're not exported.
6746 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6747 HAVE_FREETYPE.
6748 * font.h (ftxfont_driver): Likewise.
6749
e4cebfca
PE
6750 * xfns.c: Make symbols static if they're not exported.
6751 (x_last_font_name, x_display_info_for_name):
6752 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6753 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6754 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6755 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6756 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6757 (last_show_tip_args): Now static.
6758 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6759 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6760 (x_screen_planes): Remove; unused.
6761 * dispextern.h (x_screen_planes): Remove decl.
6762
5bf46f05
PE
6763 * dispnew.c: Make symbols static if they're not exported.
6764 * dispextern.h (redraw_garbaged_frames, scrolling):
6765 (increment_row_positions): Remove.
6766 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6767 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6768 Now static.
6769 (redraw_garbaged_frames): Remove; unused.
6770
435f4c28
PE
6771 * xfaces.c: Make symbols static if they're not exported.
6772 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6773 Remove decls.
6774 * xterm.h (defined_color): Remove decls.
6775 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6776 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6777 (menu_face_changed_default, defined_color, free_realized_face):
6778 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6779 (ascii_face_of_lisp_face): Remove; unused.
6780
8524aef3
PE
6781 * xdisp.c: Make symbols static if they're not exported.
6782 * dispextern.h (scratch_glyph_row, window_box_edges):
6783 (glyph_to_pixel_coords, set_cursor_from_row):
6784 (get_next_display_element, set_iterator_to_next):
6785 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6786 (show_mouse_face): Remove decls
6787 * frame.h (message_buf_print): Likewise.
6788 * lisp.h (pop_message, set_message, check_point_in_composition):
6789 Likewise.
6790 * xterm.h (set_vertical_scroll_bar): Likewise.
6791 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6792 (message_buf_print, scratch_glyph_row, displayed_buffer):
6793 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6794 (get_next_display_element, show_mouse_face, window_box_edges):
6795 (frame_to_window_pixel_xy, check_point_in_composition):
6796 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6797 (glyph_to_pixel_coords): Remove; unused.
6798
16390cd2
PE
6799 * dired.c (file_name_completion): Now static.
6800
6801 * dbusbind.c (xd_in_read_queued_messages): Now static.
6802
a25f4dfa
PE
6803 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6804 * data.c (circular_list_error): Remove.
6805
14a9c8df
PE
6806 * commands.h (last_point_position, last_point_position_buffer):
6807 (last_point_position_window): Remove decls.
6808 * keyboard.c: Make these variables static.
6809
04f2d78b
CB
6810 * coding.h (coding, code_convert_region, encode_coding_gap):
6811 Remove decls.
74ab6df5
PE
6812 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6813 (iso_code_class, detect_coding, code_convert_region): Now static.
6814 (encode_coding_gap): Remove; unused.
6815
38dfbee1
PE
6816 * chartab.c (chartab_chars, chartab_bits): Now static.
6817
a2cb4e63
PE
6818 * charset.h (charset_iso_8859_1): Remove decl.
6819 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6820 Now static.
6821
127198fd
PE
6822 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6823 * ccl.c (Vccl_program_table): Now static.
6824 (check_ccl_update): Remove; unused.
6825
d85b608f
PE
6826 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6827 * category.h: ... from here.
6828 * category.c (check_category_table, set_category_set): Now static.
6829
31cd66f3
PE
6830 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6831 * lisp.h: Remove these decls.
6832
c358e587
PE
6833 * buffer.c (buffer_count): Remove unused var.
6834
e78aecca
PE
6835 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6836 so that it's not optimized away.
6837 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6838 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6839 exported only to the debugger.
6840
e192d7d3 6841 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6842 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6843
92470028
PE
6844 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6845 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6846 was inaccessible from Lisp.
6847 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6848 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6849
244ed907
PE
6850 alloc.c: Import and export fewer symbols, and remove unused items.
6851 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6852 is defined.
6853 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6854 it's not optimized away by whole-program optimization.
6855 (message_enable_multibyte, free_misc): Remove.
6856 (catchlist, handlerlist, mark_backtrace):
6857 Declare only if BYTE_MARK_STACK.
6858 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6859 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6860 (message_enable_multibyte): Remove decl.
6861 (free_misc, interval_free_list, float_block, float_block_index):
6862 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6863 (cons_free_list, last_marked_index):
6864 Now static.
6865 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6866 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6867 (mark_backtrace): Define only if BYTE_MARK_STACK.
6868 * xdisp.c (message_enable_multibyte): Now static.
6869
61c2b50e 6870 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6871 This makes it easier for human readers (and static analyzers)
6872 to see whether these variables are used from other modules.
6873 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6874 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6875 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6876 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6877 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6878 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6879 * xmenu.c, xselect.c:
6880 Declare Q* vars static if they are not used in other modules.
6881 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6882 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6883 Remove decls of unexported vars.
6884 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6885
95c82688
PE
6886 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6887
16a97296
PE
6888 Make Emacs functions such as Fatom 'static' by default.
6889 This makes it easier for human readers (and static analyzers)
6890 to see whether these functions can be called from other modules.
6891 DEFUN now defines a static function. To make the function external
6892 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6893 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6894 (Finit_image_library):
16a97296
PE
6895 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6896 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6897 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6898 Remove decls, since these functions are now static.
6899 (Funintern, Fget_internal_run_time): New decls, since these functions
6900 were already external.
95c82688 6901
16a97296
PE
6902 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6903 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6904 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6905 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6906 * keyboard.c, keymap.c, lread.c:
6907 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6908 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6909 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6910 Mark functions with DEFUE instead of DEFUN,
6911 if they are used in other modules.
6912 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6913 decls for now-static functions.
6914 * buffer.h (Fdelete_overlay): Remove decl.
6915 * callproc.c (Fgetenv_internal): Mark as internal.
6916 * composite.c (Fremove_list_of_text_properties): Remove decl.
6917 (Fcomposition_get_gstring): New forward static decl.
6918 * composite.h (Fcomposite_get_gstring): Remove decl.
6919 * dired.c (Ffile_attributes): New forward static decl.
6920 * doc.c (Fdocumntation_property): New forward static decl.
6921 * eval.c (Ffetch_bytecode): New forward static decl.
6922 (Funintern): Remove extern decl; now in .h file where it belongs.
6923 * fileio.c (Fmake_symbolic_link): New forward static decl.
6924 * image.c (Finit_image_library): New forward static decl.
6925 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6926 * intervals.h (Fprevious_property_change):
6927 (Fremove_list_of_text_properties): Remove decls.
6928 * keyboard.c (Fthis_command_keys): Remove decl.
6929 (Fcommand_execute): New forward static decl.
6930 * keymap.c (Flookup_key): New forward static decl.
6931 (Fcopy_keymap): Now static.
6932 * keymap.h (Flookup_key): Remove decl.
6933 * process.c (Fget_process): New forward static decl.
6934 (Fprocess_datagram_address): Mark as internal.
6935 * syntax.c (Fsyntax_table_p): New forward static decl.
6936 (skip_chars): Remove duplicate decl.
6937 * textprop.c (Fprevious_property_change): New forward static decl.
6938 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6939 Now internal.
6940 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6941 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6942
785bbd42
PE
6943 * editfns.c (Fformat): Remove unreachable code.
6944
8b913b57
AS
69452011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6946
6947 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6948 change. (Bug#8496)
6949
a6744a35
EZ
69502011-04-13 Eli Zaretskii <eliz@gnu.org>
6951
6952 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6953 when at ZV. (Bug#8487)
6954
e7974947
AS
69552011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6956
baad03f0
AS
6957 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6958 (Bug#8437)
6959 * keyboard.c (parse_tool_bar_item): Likewise.
6960 * sound.c (sound_cleanup, alsa_close): Likewise.
6961 * termcap.c (tgetent): Likewise.
6962 * xfns.c (x_default_font_parameter): Likewise.
6963 * xsettings.c (read_and_apply_settings): Likewise.
6964
e7974947
AS
6965 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6966 (overrun_check_free): Protoize.
6967
28272684
PE
69682011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6969
6970 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6971 since callers should never pass a negative size.
6972 Change the signature to match that of plain 'read' and 'write'; see
6973 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6974 * lisp.h: Update prototypes of emacs_write and emacs_read.
6975
11997c76
EZ
69762011-04-11 Eli Zaretskii <eliz@gnu.org>
6977
6978 * xdisp.c (redisplay_window): Don't try to determine the character
6979 position of the scroll margin if the window start point w->startp
e896f03c 6980 is outside the buffer's accessible region. (Bug#8468)
11997c76 6981
8a2cbd72
EZ
69822011-04-10 Eli Zaretskii <eliz@gnu.org>
6983
6984 Fix write-region and its subroutines for buffers > 2GB.
6985 * fileio.c (a_write, e_write): Modify declaration of arguments and
6986 local variables to support buffers larger than 2GB.
6987 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6988
6989 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6990 argument, local variables, and return value.
6991
6992 * lisp.h: Update prototypes of emacs_write and emacs_read.
6993
6994 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6995
4073e537 69962011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6997
1ebfdcb6
PE
6998 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6999
b2ded58d
PE
7000 Fix more problems found by GCC 4.6.0's static checks.
7001
7d66342c
PE
7002 * xdisp.c (vmessage): Use a better test for character truncation.
7003
bbf47d44
PE
7004 * charset.c (load_charset_map): <, not <=, for optimization,
7005 and to avoid potential problems with integer overflow.
9248994d 7006 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7007 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7008 * editfns.c (Fformat): Likewise.
1e69125e 7009 * syntax.c (skip_chars): Likewise.
3befa583 7010
e3019616
PE
7011 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7012 This also lets GCC 4.6.0 generate slightly better loop code.
7013
becfa255
PE
7014 * callint.c (Fcall_interactively): <, not <=, for optimization.
7015 (Fcall_interactively): Count the number of arguments produced,
7016 not the number of arguments given. This is simpler and lets GCC
7017 4.6.0 generate slightly better code.
7018
dae0cd48
PE
7019 * ftfont.c: Distingish more carefully between FcChar8 and char.
7020 The previous code passed unsigned char * to a functions like
7021 strlen and xstrcasecmp that expect char *, which does not
7022 conform to the C standard.
7023 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7024 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7025 char * when the C standard requires it.
7026
76032d70
PE
7027 * keyboard.c (read_char): Remove unused var.
7028
eb3f1cc8
PE
7029 * eval.c: Port to Windows vsnprintf (Bug#8435).
7030 Include <limits.h>.
7031 (SIZE_MAX): Define if the headers do not.
7032 (verror): Do not give up if vsnprintf returns a negative count.
7033 Instead, grow the buffer. This ports to Windows vsnprintf, which
7034 does not conform to C99. Problem reported by Eli Zaretskii.
7035 Also, simplify the allocation scheme, by avoiding the need for
7036 calling realloc, and removing the ALLOCATED variable.
7037
70476b54
PE
7038 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7039
12020a9e
PE
7040 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7041 But keep the doprint source code for now, as we might revamp it
7042 and use it again (Bug#8435).
ea6c7ae6
PE
7043 * lisp.h (doprnt): Remove.
7044 * Makefile.in (base_obj): Remove doprnt.o.
7045 * deps.mk (doprnt.o): Remove.
7046
5fdb398c
PE
7047 error: Print 32- and 64-bit integers portably (Bug#8435).
7048 Without this change, on typical 64-bit hosts error ("...%d...", N)
7049 was used to print both 32- and 64-bit integers N, which relied on
7050 undefined behavior.
7051 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7052 New macro.
7053 * lisp.h (error, verror): Mark as printf-like functions.
7054 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7055 Report overflow in size calculations when allocating printf buffer.
7056 Do not truncate output string at its first null byte.
7057 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7058 Truncate the output at a character boundary, since vsnprintf does not
7059 do that.
7060 * charset.c (check_iso_charset_parameter): Convert internal
7061 character to string before calling 'error', since %c now has the
7062 printf meaning.
7063 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7064 overflow when computing char to be passed to 'error'. Do not
7065 pass Lisp_Object to 'error'; pass the integer instead.
7066 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7067 formatted with plain %d.
7068
b189fa66
PE
7069 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7070
bff87ef0
PE
7071 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7072
7e2cac20
PE
7073 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7074
ce4d90b5
PE
7075 * xterm.c (x_catch_errors): Remove duplicate declaration.
7076
266c9547
PE
7077 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7078
79c49ad2
PE
7079 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7080
368f4090
JM
70812011-04-10 Jim Meyering <meyering@redhat.com>
7082
7083 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7084 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7085 return ssize_t not "int", and use size_t as the buffer length.
7086 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7087 * gnutls.h: Update declarations.
7088 * process.c (read_process_output): Use ssize_t, to match.
7089 (send_process): Likewise.
7090
a32d4040
CY
70912011-04-09 Chong Yidong <cyd@stupidchicken.com>
7092
7093 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7094
8546720e 70952011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7096
04f2d78b
CB
7097 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7098 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7099
8546720e
GM
7100 * xterm.c (handle_one_xevent):
7101 * xmenu.c (create_and_show_popup_menu):
7102 * xselect.c (x_decline_selection_request)
7103 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7104
0a2f5c1a 71052011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7106
7107 Fix some uses of `int' instead of EMACS_INT.
7108 * search.c (string_match_1, fast_string_match)
7109 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7110 (scan_buffer, find_next_newline_no_quit)
7111 (find_before_next_newline, search_command, Freplace_match)
7112 (Fmatch_data): Make some `int' variables be EMACS_INT.
7113
7114 * xdisp.c (display_count_lines): 3rd argument and return value now
7115 EMACS_INT. All callers changed.
7116 (pint2hrstr): Last argument is now EMACS_INT.
7117
7118 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7119 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7120 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7121 (decode_coding_utf_16, decode_coding_emacs_mule)
7122 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7123 (decode_coding_ccl, decode_coding_charset)
7124 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7125 (decode_coding_iso_2022, decode_coding_emacs_mule)
7126 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7127 <char_offset, last_offset>: Declare EMACS_INT.
7128 (encode_coding_utf_8, encode_coding_utf_16)
7129 (encode_coding_emacs_mule, encode_invocation_designation)
7130 (encode_designation_at_bol, encode_coding_iso_2022)
7131 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7132 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7133 Declare EMACS_INT.
7134 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7135 (encode_invocation_designation): Last argument P_NCHARS is now
7136 EMACS_INT.
7137 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7138 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7139
7140 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7141 All users changed.
7142
7143 * ccl.c (Fccl_execute_on_string): Declare some variables
7144 EMACS_INT.
7145
8546720e 71462011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7147
7148 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7149
4e19a977
CS
71502011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7151
7152 * process.c (Fformat_network_address): Doc fix.
7153
87302331
R
71542011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7155
ee7683eb 7156 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7157
cbb59342
CY
71582011-04-08 Chong Yidong <cyd@stupidchicken.com>
7159
7160 * keyboard.c (read_char): Call Lisp function help-form-show,
7161 instead of using internal_with_output_to_temp_buffer.
7162 (Qhelp_form_show): New var.
e0d38eeb 7163 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7164
7165 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7166
7167 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7168
e67a13ab
CY
71692011-04-06 Chong Yidong <cyd@stupidchicken.com>
7170
04f2d78b
CB
7171 * process.c (Flist_processes): Remove to Lisp.
7172 (list_processes_1): Delete.
e67a13ab 7173
973f782d
EZ
71742011-04-06 Eli Zaretskii <eliz@gnu.org>
7175
7c106b1e
EZ
7176 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7177
973f782d
EZ
7178 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7179
41cf7d1a 71802011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7181
ca23cc88
PE
7182 Fix more problems found by GCC 4.6.0's static checks.
7183
f390e2d5
PE
7184 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7185
42eea0d0
PE
7186 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7187
b69769da 7188 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7189
f9541e84
PE
7190 * xdisp.c (vmessage): Mark as a printf-like function.
7191
13841b55
PE
7192 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7193
c136c10f
PE
7194 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7195
5e2d4a30
PE
7196 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7197 printf-like functions.
7198 (tiff_load): Add casts to remove these marks before passing them
7199 to system-supplied API.
7200
583f48b9
PE
7201 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7202
b25d760e
PE
7203 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7204 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7205 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7206 directly, rather than having caller test rule sign. This avoids
7207 some unnecessary tests.
7208 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7209 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7210 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7211
bc7b6697 7212 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7213 (xfont_open): Avoid unnecessary tests.
bc7b6697 7214
27ccc379
PE
7215 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7216
dcd5c89a
PE
7217 * composite.h, composite.c (composition_gstring_put_cache):
7218 Use EMACS_INT, not int, for length.
7219
b13a45c6
PE
7220 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7221 breaking out part of COMPOSITION_DECODE_RULE.
7222 (COMPOSITION_DECODE_RULE): Use it.
7223 * composite.c (get_composition_id): Remove unused local vars,
7224 by using the new macro.
7225
1e792e4d
PE
7226 * textprop.c (set_text_properties_1): Change while to do-while,
7227 since the condition is always true at first.
7228
dc6c6455 7229 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7230 (interval_deletion_adjustment): Return unsigned value.
7231 All uses changed.
dc6c6455 7232
aba7731a
PE
7233 * process.c (list_processes_1, create_pty, read_process_output):
7234 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7235 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7236 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7237 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7238 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7239
fdfc4bf3
PE
7240 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7241
fca8fe46 7242 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7243 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7244
06a0259a 7245 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7246 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7247 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7248
e7b9e80f
PE
7249 * print.c (print_error_message): Avoid int overflow.
7250
56201685
PE
7251 * font.c (font_list_entities): Redo for clarity,
7252 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7253
78834453 7254 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7255 (font_score): Avoid potential overflow in diff calculation.
78834453 7256
0bc0b309 7257 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7258 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7259
e610eaca
PE
7260 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7261
b895abce
PE
7262 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7263 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7264 can always succeed if overflow has undefined behavior.
7265
1f1d9321 7266 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7267 (wordify): Omit three unnecessary tests.
1f1d9321 7268
c59478bc
PE
7269 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7270 All callers changed. This avoids the need for an unused var.
7271
79b73827
PE
7272 * casefiddle.c (casify_region): Remove var that is set but not used.
7273
a4db5dfe
PE
7274 * dired.c (file_name_completion): Remove var that is set but not used.
7275
43aae36e
PE
7276 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7277
2a47c44d 7278 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7279 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7280
a37c69bf
PE
7281 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7282 Check for integer overflow on size calculations.
7283
328ab8e7
PE
7284 * buffer.c (Fprevious_overlay_change): Remove var that is set
7285 but not used.
7286
e5a2a5cb
PE
7287 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7288 Remove vars that are set but not used.
8d84a6eb 7289 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7290 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7291
a60e5f68
PE
7292 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7293
f661cb61 7294 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7295 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7296
f0397f5a
PE
7297 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7298 that are set but not used.
7299
8664db06 7300 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7301 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7302
6abdaa4a
PE
7303 * xselect.c (x_get_local_selection, x_handle_property_notify):
7304 Remove vars that are set but not used.
7305
0ce7538d 7306 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7307 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7308
9ae848fc
PE
7309 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7310 Remove var that is set but not used.
0b918413
PE
7311 (scroll_bar_windows_size): Now size_t, not int.
7312 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7313 Check for overflow.
9ae848fc 7314
a5a62657
PE
7315 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7316 (map_tty_color) [!defined MSDOS]: Likewise.
7317
5c5cdd39
PE
7318 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7319
66ebf983
PE
7320 * coding.c: Remove vars that are set but not used.
7321 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7322 All callers changed.
7323 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7324 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7325 (decode_coding_charset): Remove vars that are set but not used.
7326
1be4d761
PE
7327 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7328 that is set but not used.
7329
47553fa8
PE
7330 * print.c (print_object): Remove var that is set but not used.
7331
1f7196bf 7332 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7333 The gnulib version avoids calling malloc in the usual case,
7334 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7335 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7336 * filelock.c (current_lock_owner): Likewise.
7337 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7338 * sysdep.c: Include allocator.h, careadlinkat.h.
7339 (emacs_no_realloc_allocator): New static constant.
7340 (emacs_readlink): New function.
fdb61804
PE
7341 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7342 ../lib/careadlinkat.h.
d1fdcab7 7343
f84c17c7
SM
73442011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7345
7346 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7347 first non-nil return value).
7348
ef3862ad
JD
73492011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7350
7351 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7352 if not defined (Bug#8403).
7353
376a7006
JB
73542011-04-02 Juanma Barranquero <lekktu@gmail.com>
7355
7356 * xdisp.c (display_count_lines): Remove parameter `start',
7357 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7358 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7359 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7360 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7361 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7362 and thereabouts. All callers changed.
7363 (get_per_char_metric): Remove parameter `f', unused since
7364 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7365
6ca3801d
JM
73662011-04-02 Jim Meyering <meyering@redhat.com>
7367
7368 do not dereference NULL upon failed strdup
7369 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7370 (ns_get_family): Likewise.
7371
d8e2b5ba
JB
73722011-04-02 Juanma Barranquero <lekktu@gmail.com>
7373
7374 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7375
8c74fcbd
JD
73762011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7377
7378 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7379 later (Bug#8403).
7380
7200d79c
SM
73812011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7382
03408648 7383 Add lexical binding.
7200d79c 7384
03408648
SM
7385 * window.c (Ftemp_output_buffer_show): New fun.
7386 (Fsave_window_excursion):
7387 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7388
7389 * lread.c (lisp_file_lexically_bound_p): New function.
7390 (Fload): Bind Qlexical_binding.
7391 (readevalloop): Remove `evalfun' arg.
7392 Bind Qinternal_interpreter_environment.
7393 (Feval_buffer): Bind Qlexical_binding.
7394 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7395 Mark as dynamic.
7396 (syms_of_lread): Declare `lexical-binding'.
7397
7398 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7399
7400 * keyboard.c (eval_dyn): New fun.
7401 (menu_item_eval_property): Use it.
ca105506
SM
7402
7403 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7404
03408648
SM
7405 * fns.c (concat, mapcar1): Accept byte-code-functions.
7406
7407 * eval.c (Fsetq): Handle lexical vars.
7408 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7409 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7410 (FletX, Flet): Obey lexical binding.
7411 (Fcommandp): Handle closures.
7412 (Feval): New `lexical' arg.
7413 (eval_sub): New function extracted from Feval. Use it almost
7414 everywhere where Feval was used. Look up vars in lexical env.
7415 Handle closures.
7416 (Ffunctionp): Move from subr.el.
7417 (Ffuncall): Handle closures.
7418 (apply_lambda): Remove `eval_flags'.
7419 (funcall_lambda): Handle closures and new byte-code-functions.
7420 (Fspecial_variable_p): New function.
7421 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7422 but without exporting it to Lisp.
23aba0ea 7423
23aba0ea 7424 * doc.c (Fdocumentation, store_function_docstring):
03408648 7425 * data.c (Finteractive_form): Handle closures.
23aba0ea 7426
03408648
SM
7427 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7428 interactive spec.
ba83908c 7429
04f2d78b
CB
7430 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7431 New byte-codes.
03408648
SM
7432 (exec_byte_code): New function extracted from Fbyte_code to handle new
7433 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7434
03408648 7435 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7436
03408648 7437 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7438
e2abce01
JB
74392011-03-31 Juanma Barranquero <lekktu@gmail.com>
7440
7441 * xdisp.c (redisplay_internal): Fix prototype.
7442
63696a73 74432011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7444
63696a73 7445 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7446 (try_scrolling): Use it when setting scroll_limit.
7447 Limit scrolling to 100 screen lines.
63696a73
EZ
7448 (redisplay_window): Even when falling back on "recentering",
7449 position point in the window according to scroll-conservatively,
7450 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7451
7452 (try_scrolling): When point is above the window, allow searching
7453 as far as scroll_max, or one screenful, to compute vertical
7454 distance from PT to the scroll margin position. This prevents
7455 try_scrolling from unnecessarily failing when
7456 scroll-conservatively is set to a value slightly larger than the
7457 window height. Clean up the case of PT below the margin at bottom
7458 of window: scroll_max can no longer be INT_MAX. When aggressive
7459 scrolling is in use, don't let point enter the opposite scroll
7460 margin as result of the scroll.
7461 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7462 threshold of 100 lines for never-recentering scrolling.
7463
e4cc2dfc
JB
74642011-03-31 Juanma Barranquero <lekktu@gmail.com>
7465
7466 * dispextern.h (move_it_by_lines):
7467 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7468 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7469 (message_log_check_duplicate): Remove parameters `prev_bol' and
7470 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7471 (redisplay_internal): Remove parameter `preserve_echo_area',
7472 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7473
7474 * indent.c (Fvertical_motion):
7475 * window.c (window_scroll_pixel_based, Frecenter):
7476 Don't pass `need_y_p' to `move_it_by_lines'.
7477
1c470562
SM
74782011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7479
44f230aa
SM
7480 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7481 steal a few bits to be more compact.
7482 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7483 Remove unneeded casts.
7484
1c470562
SM
7485 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7486
888adce9
ZK
74872011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7488
7489 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7490 binding" message (bug#7967).
7491
f838ed7b
PE
74922011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7493
77861b95
PE
7494 Fix more problems found by GCC 4.6.0's static checks.
7495
de6dbc14
PE
7496 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7497 Remove unused local var.
7498
f838ed7b
PE
7499 * editfns.c (Fmessage_box): Remove unused local var.
7500
792c7b2b
PE
7501 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7502 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7503 Omit unused local vars.
c499e557 7504 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7505 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7506 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7507 Omit unused local var.
7508
ba0165e1
PE
7509 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7510 Don't assume string length fits in int.
32ad8845 7511 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7512 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7513
3c59b4c9
PE
7514 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7515 instead of alloca (Bug#8344).
7516
a3eed478 7517 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7518 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7519
eb4d412d
PE
7520 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7521
1658b401
PE
7522 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7523 concerns.
7524
7525 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7526
7527 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7528
9a2c6e05
PE
7529 * keyboard.c (syms_of_keyboard): Use the same style as later
7530 in this function when indexing through an array. This also
7531 works around GCC bug 48267.
7532
03d0a109
PE
7533 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7534
44f730c8
PE
7535 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7536
fe75f926
PE
7537 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7538 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7539
ffa8c828
PE
7540 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7541 This avoids undefined behavior on integer overflow, and is a bit
7542 more convenient anyway since it is compared to a size_t variable.
7543
c5101a77
PE
7544 Variadic C functions now count arguments with size_t, not int.
7545 This avoids an unnecessary limitation on 64-bit machines, which
7546 caused (substring ...) to crash on large vectors (Bug#8344).
7547 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7548 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7549 All variadic functions and their callers changed accordingly.
c5101a77
PE
7550 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7551 * data.c (arith_driver, float_arith_driver): Likewise.
7552 * editfns.c (general_insert_function): Likewise.
7553 * eval.c (struct backtrace.nargs, interactive_p)
7554 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7555 (funcall_lambda, mark_backtrace): Likewise.
7556 * fns.c (concat): Likewise.
7557 * frame.c (x_set_frame_parameters): Likewise.
7558 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7559 0 if not found, not -1. All callers changed.
7560
dd3f25f7
PE
7561 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7562 (stack_copy_size): Now size_t, not int.
7563 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7564
461c2ab9
JB
75652011-03-28 Juanma Barranquero <lekktu@gmail.com>
7566
7567 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7568 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7569 All callers changed.
7570
7571 * lisp.h (multibyte_char_to_unibyte):
7572 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7573 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7574 * character.h (CHAR_TO_BYTE8):
7575 * cmds.c (internal_self_insert):
7576 * editfns.c (general_insert_function):
7577 * keymap.c (push_key_description):
7578 * search.c (Freplace_match):
7579 * xdisp.c (message_dolog, set_message_1): All callers changed.
7580
f6d62986
SM
75812011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7582
7583 * keyboard.c (safe_run_hook_funcall): New function.
7584 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7585 don't set the hook to nil, but remove the offending function instead.
7586 (Qcommand_hook_internal): Remove, unused.
7587 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7588 Vcommand_hook_internal.
7589
7590 * eval.c (enum run_hooks_condition): Remove.
7591 (funcall_nil, funcall_not): New functions.
7592 (run_hook_with_args): Call each function through a `funcall' argument.
7593 Remove `cond' argument, now redundant.
7594 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7595 (Frun_hook_with_args_until_failure): Adjust accordingly.
7596 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7597
1db5b1ad
JB
75982011-03-28 Juanma Barranquero <lekktu@gmail.com>
7599
7600 * dispextern.h (string_buffer_position): Remove declaration.
7601
7602 * print.c (strout): Remove parameter `multibyte', unused since
7603 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7604
7605 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7606 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7607 All callers changed.
7608
7609 * w32.c (_wsa_errlist): Use braces for struct initializers.
7610
7611 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7612 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7613 All callers changed.
7614 (string_buffer_position): Likewise. Also, make static (it's never
7615 used outside xdisp.c).
7616 (cursor_row_p): Remove parameter `w', unused since
7617 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7618 (decode_mode_spec): Remove parameter `precision', introduced during
7619 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7620 All callers changed.
7621
5ffb62aa
JD
76222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7623
7624 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7625
461c2ab9 76262011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7627
7628 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7629 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7630 (ns_update_auto_hide_menu_bar): New functions.
7631 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7632 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7633 ns_constrain_all_frames.
7634 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7635 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7636
5c380ffb
JD
76372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7638
7639 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7640
9af30bdf
GM
76412011-03-27 Glenn Morris <rgm@gnu.org>
7642
7643 * syssignal.h: Replace RETSIGTYPE with void.
7644 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7645 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7646 Replace SIGTYPE with void everywhere.
7647 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7648 * s/template.h (SIGTYPE): Remove commented out definition.
7649
e2abce01
JB
76502011-03-26 Eli Zaretskii <eliz@gnu.org>
7651
7652 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7653 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7654
f868cd8a
JB
76552011-03-26 Juanma Barranquero <lekktu@gmail.com>
7656
59eb0929
JB
7657 * w32.c (read_unc_volume): Use parameter `henum', instead of
7658 global variable `wget_enum_handle'.
7659
7660 * keymap.c (describe_vector): Remove parameters `indices' and
7661 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7662 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7663
f868cd8a
JB
7664 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7665
7666 * keyboard.c (timer_check): Remove parameter `do_it_now',
7667 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7668 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7669 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7670
7671 * keyboard.c (read_char):
7672 * w32menu.c (w32_menu_display_help):
7673 * xmenu.c (show_help_event, menu_help_callback):
7674 Adjust calls to `show_help_echo'.
7675
7676 * gtkutil.c (xg_maybe_add_timer):
7677 * keyboard.c (readable_events):
7678 * process.c (wait_reading_process_output):
7679 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7680
7681 * insdel.c (adjust_markers_gap_motion):
7682 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7683 (gap_left, gap_right): Don't call it.
7684
2ecf6fdb
CY
76852011-03-25 Chong Yidong <cyd@stupidchicken.com>
7686
7687 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7688 incurred during fontification.
7689
6b1f9ba4
JB
76902011-03-25 Juanma Barranquero <lekktu@gmail.com>
7691
7692 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7693 (DEFVAR_PER_BUFFER): Don't pass it.
7694
7695 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7696 (scrolling_window): Don't pass it.
7697
0f4a96b5
JB
76982011-03-25 Juanma Barranquero <lekktu@gmail.com>
7699
7700 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7701
7702 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7703 and `suffix'.
7704 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7705 of variables specific to SELinux and computation of `encoded_absname'.
7706
7707 * image.c (XPutPixel): Remove unused variable `height'.
7708
7709 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7710
7711 * unexw32.c (get_section_info): Remove unused variable `section'.
7712
7713 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7714 (system_process_attributes): Remove unused variable `sess'.
7715 (sys_read): Remove unused variable `err'.
7716
7717 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7718 (w32_wnd_proc): Remove unused variable `isdead'.
7719 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7720 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7721 (x_create_tip_frame): Remove unused variable `tem'.
7722
7723 * w32inevt.c (w32_console_read_socket):
7724 Remove unused variable `no_events'.
7725
7726 * w32term.c (x_draw_composite_glyph_string_foreground):
7727 Remove unused variable `width'.
7728
1149507c
JB
77292011-03-24 Juanma Barranquero <lekktu@gmail.com>
7730
7731 * w32term.c (x_set_glyph_string_clipping):
7732 Don't pass uninitialized region to CombineRgn.
7733
9c88f339
JB
77342011-03-23 Juanma Barranquero <lekktu@gmail.com>
7735
7736 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7737 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7738 (Fx_close_connection): Remove unused variable `i'.
7739
7740 * w32font.c (w32font_draw): Return number of glyphs.
7741 (w32font_open_internal): Remove unused variable `i'.
7742 (w32font_driver): Add missing initializer.
7743
7744 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7745 (fill_in_menu): Remove unused variable `items_added'.
7746
7747 * w32term.c (last_mouse_press_frame): Remove static global variable.
7748 (w32_clip_to_row): Remove unused variable `f'.
7749 (x_delete_terminal): Remove unused variable `i'.
7750
7751 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7752 (NOTHING): Remove unused static global variable.
7753 (uniscribe_check_otf): Remove unused variable `table'.
7754 (uniscribe_font_driver): Add missing initializers.
7755
dee091a3
JD
77562011-03-23 Julien Danjou <julien@danjou.info>
7757
7758 * term.c (Fsuspend_tty, Fresume_tty):
7759 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7760 * window.c (temp_output_buffer_show):
7761 * insdel.c (signal_before_change):
7762 * frame.c (Fhandle_switch_frame):
7763 * fileio.c (Fdo_auto_save):
7764 * emacs.c (Fkill_emacs):
7765 * editfns.c (save_excursion_restore):
7766 * cmds.c (internal_self_insert):
7767 * callint.c (Fcall_interactively):
7768 * buffer.c (Fkill_all_local_variables):
7769 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7770 Use Frun_hooks.
0f4a96b5 7771 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7772 unconditionally since it does the check itself.
dee091a3 7773
2c520ab5 77742011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7775
c9c49752
PE
7776 Fix more problems found by GCC 4.5.2's static checks.
7777
8abc3f12
PE
7778 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7779 the first time through the loop, since we know p0 < p1 then.
7780 This also avoids a gcc -Wstrict-overflow warning.
7781
a2d26660
PE
7782 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7783 leading to a memory leak, possible in functions like
7784 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7785 of objects (Bug#8318).
a2d26660 7786
916c72e9
PE
7787 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7788 that could (at least in theory) be that large.
7789
19ab8a18
PE
7790 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7791 This is less likely to overflow, and avoids undefined behavior if
7792 overflow does occur. All callers changed. Use strtoul to scan
7793 for the unsigned long integer.
b7cbbd6f
PE
7794 (pint2hrstr): Simplify and tune code slightly.
7795 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7796
f0641eff
PE
7797 * scroll.c (do_scrolling): Work around GCC bug 48228.
7798 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7799
7f650bb9
PE
7800 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7801 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7802 (validate_x_resource_name): Simplify count usage.
7803 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7804
37dd57d1
PE
7805 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7806 fail (Bug#8306).
81e56e61 7807
699979fc 7808 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7809
401bf9b4
PE
7810 * process.c (Fmake_network_process): Use socklen_t, not int,
7811 where POSIX says socklen_t is required in portable programs.
7812 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7813 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7814 (Fmake_network_process, server_accept_connection):
7815 (wait_reading_process_output, read_process_output):
7816 Likewise.
7817
b93aacde
PE
7818 * process.c: Rename or move locals to avoid shadowing.
7819 (list_processes_1, Fmake_network_process):
7820 (read_process_output_error_handler, exec_sentinel_error_handler):
7821 Rename or move locals.
4dc343ee 7822 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7823 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7824 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7825 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7826 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7827
af8a867c 7828 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7829 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7830 Include tparam.h instead, since it declares them.
af8a867c
PE
7831 * cm.h (PC): Remove extern decl; tparam.h now does this.
7832 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7833 * terminfo.c: Include tparam.h, to check interfaces.
7834 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7835 (tparam): Adjust signature to match interface in tparam.h;
7836 this removes some undefined behavior. Check that outstring and len
7837 are zero, which they always are with Emacs.
7838 * tparam.h (PC, BC, UP): New extern decls.
7839
0248044d 7840 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7841 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7842
8ff096c1 7843 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7844 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7845 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7846 (ftfont_list): Remove unused local.
49eaafba
PE
7847 (get_adstyle_property, ftfont_pattern_entity):
7848 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7849 Rename locals to avoid shadowing.
8ff096c1 7850
e2be39f6
PE
7851 * xfont.c (xfont_list_family): Mark var as initialized.
7852
c9735e30
PE
7853 * xml.c (make_dom): Now static.
7854
8f5201ae
PE
7855 * composite.c (composition_compute_stop_pos): Rename local to
7856 avoid shadowing.
b246f932
PE
7857 (composition_reseat_it): Remove unused locals.
7858 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7859 (composition_update_it): Mark var as initialized.
11b61122
PE
7860 (find_automatic_composition): Mark vars as initialized,
7861 with a FIXME (Bug#8290).
8f5201ae 7862
760fbc2c
PE
7863 character.h: Rename locals to avoid shadowing.
7864 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7865 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7866 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7867 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7868 to avoid shadowing.
7869
ff08eb85
PE
7870 * textprop.c (property_change_between_p): Remove; unused.
7871
fc7bf025
PE
7872 * intervals.c (interval_start_pos): Now static.
7873
235d7abc
PE
7874 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7875
44f230aa
SM
7876 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7877 Rename locals to avoid shadowing.
3e7d6594 7878
50060332
PE
7879 * sound.c (wav_play, au_play, Fplay_sound_internal):
7880 Fix pointer signedness.
d01f234b 7881 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7882 (wav_play): Initialize a variable to 0, to prevent undefined
7883 behavior (Bug#8278).
50060332 7884
c4fc4e30
PE
7885 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7886
918436ed
PE
7887 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7888
c939f91b
PE
7889 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7890 clobbering (Bug#8298).
b9c7f648
PE
7891 * sysdep.c (sys_subshell): Likewise.
7892 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7893
6bd8c144
PE
7894 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7895 This should get cleaned up, so that child_setup has the
7896 same signature on all platforms.
7897
7710357c 7898 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7899 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7900
c59da222
CY
79012011-03-22 Chong Yidong <cyd@stupidchicken.com>
7902
7903 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7904 not to be necessary, and produces flickering.
7905
66b87493
GM
79062011-03-20 Glenn Morris <rgm@gnu.org>
7907
7908 * config.in: Remove file.
7909
45b6f6d5
JB
79102011-03-20 Juanma Barranquero <lekktu@gmail.com>
7911
7912 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7913 are now in src/globals.h.
7914 (syms_of_minibuf): Remove spurious & from previous change.
7915
3ec03f7e
LL
79162011-03-20 Leo <sdl.web@gmail.com>
7917
7918 * minibuf.c (completing-read-function): New variable.
7919 (completing-read-default): Rename from completing-read.
7920 (completing-read): Call completing-read-function.
7921
b14e3e21
CY
79222011-03-19 Juanma Barranquero <lekktu@gmail.com>
7923
7924 * xfaces.c (Fx_load_color_file):
7925 Read color file from absolute filename (bug#8250).
7926
f2b726e6
JB
79272011-03-19 Juanma Barranquero <lekktu@gmail.com>
7928
7929 * makefile.w32-in: Update dependencies.
7930
09f6ff02
EZ
79312011-03-17 Eli Zaretskii <eliz@gnu.org>
7932
7933 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7934
29a6015a
PE
79352011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7936
a3a6c54e
PE
7937 Fix more problems found by GCC 4.5.2's static checks.
7938
b766f867
PE
7939 * process.c (make_serial_process_unwind, send_process_trap):
7940 (sigchld_handler): Now static.
7941
be02381c
PE
7942 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7943 That way, the code declares only the vars that it needs.
7944 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7945 * s/cygwin.h (PTY_ITERATION): Likewise.
7946 * s/darwin.h (PTY_ITERATION): Likewise.
7947 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7948
57048744
PE
7949 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7950 * process.c (allocate_pty): Don't declare stb unless it's needed.
7951
7914961c 7952 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7953 (CONSTANTLIM): Remove; unused.
7954 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7955 Define only if needed.
7914961c 7956
b3967b18
PE
7957 * unexelf.c (unexec): Name an expression,
7958 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7959 Use a different way to cause a compilation error if anyone uses
7960 n rather than nn, a way that does not involve shadowing.
73366a00 7961 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7962
29a6015a
PE
7963 * deps.mk (unexalpha.o): Remove; unused.
7964
43cfc33e 7965 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7966 * unexec.h: New file.
ce701a33
PE
7967 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7968 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7969 Depend on unexec.h.
7970 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7971 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7972 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7973 Change as necessary to match prototype in unexec.h.
ce701a33 7974
01f44d5a
PE
7975 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7976 shadowing.
4f63c6bb 7977 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7978
a6670b0b
PE
7979 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7980 Rename locals to avoid shadowing.
7981
cef2010d 7982 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7983 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7984
d4d7173a
PE
7985 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7986
f08b802a
PE
7987 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7988 warning when compiling print.c.
7989
3ddb0639
PE
7990 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7991 instead of using an uninitialized var.
5ad03b97 7992 (font_sort_entities): Mark var as initialized.
3ddb0639 7993
170a2692
PE
7994 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7995
e663c700
PE
7996 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7997 pointers to constants.
89bc529a 7998 (font_parse_fcname): Remove unused vars.
7b81e2d0 7999 (font_delete_unmatched): Now static.
ea838e10 8000 (font_get_spec): Remove; unused.
13a547c6
PE
8001 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8002 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8003 Rename or move locals to avoid shadowing.
e663c700 8004
2a80c887 8005 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8006 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8007
1384fa33 8008 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8009 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8010
8b2c52e9
PE
8011 * alloc.c (mark_backtrace): Move decl from here ...
8012 * lisp.h: ... to here, so that it can be checked.
8013
475545b5 8014 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8015 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8016 (lisp_indirect_variable): Name an expression,
8017 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8018 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8019
b1349114 8020 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8021 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8022 Use const pointer when appropriate.
b1349114 8023
a2928364
PE
8024 * lisp.h (get_system_name, get_operating_system_release):
8025 Move decls here, to check interfaces.
8026 * process.c (get_operating_system_release): Move decl to lisp.h.
8027 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8028 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8029 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8030 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8031 (Fformat_time_string, Fencode_time, Finsert_char):
8032 (Ftranslate_region_internal, Fformat):
8033 Rename or remove local vars to avoid shadowing.
9710023e 8034 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8035
a415e694
PE
8036 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8037 avoid shadowing.
8038
8ef4622d
PE
8039 * lisp.h (eassert): Check that the argument compiles, even if
8040 ENABLE_CHECKING is not defined.
8041
946f9a5b
PE
8042 * data.c (Findirect_variable): Name an expression, to avoid
8043 gcc -Wbad-function-cast warning.
112396d6 8044 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8045 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8046 (Fmake_variable_buffer_local, Fmake_local_variable):
8047 Mark variables as initialized.
52746918 8048 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8049
e5aab7e7 8050 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8051 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8052 Rename locals to avoid shadowing.
dff45157
PE
8053 (mark_stack): Move local variables into the #ifdef region where
8054 they're used.
7bc26fdb
PE
8055 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8056 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8057 needed otherwise.
8058 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8059 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8060 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8061
e5aab7e7
PE
8062 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8063 avoids undefined behavior in theory.
8064
4da60324
PE
8065 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8066
88043301
PE
8067 Use functions, not macros, for up- and down-casing (Bug#8254).
8068 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8069 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8070 to use the following functions instead of these macros.
8071 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8072 EMACS_INT, since callers assume the returned value fits in int.
8073 (upcase1): Likewise, for UPCASE_TABLE.
8074 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8075 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8076 the race-condition problem in the old DOWNCASE.
88043301 8077
19ed5445
PE
8078 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8079 Rename locals to avoid shadowing.
8080 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8081 (regex_compile, re_search_2, re_match_2_internal):
8082 Remove unused local vars.
952db0d7
PE
8083 (FREE_VAR): Rewrite so as not to use empty "else",
8084 which gcc can warn about.
da053e48 8085 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8086 (RETALLOC_IF): Define only if needed.
8087 (WORDCHAR_P): Likewise. This one is never needed, but is used
8088 only in a comment talking about a compiler bug, so put inside
8089 the #if 0 of that comment.
8090 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8091 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8092 Remove; unused.
19ed5445 8093
1f3561e4 8094 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8095 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8096 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8097
ded6f8f7
PE
8098 * search.c (simple_search): Remove unused var.
8099
dbd37a95
PE
8100 * dired.c (compile_pattern): Move decl from here ...
8101 * lisp.h: ... to here, so that it can be checked.
8102 (struct re_registers): New forward decl.
8103
7e47afad
PE
8104 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8105
85f24f61
PE
8106 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8107 All uses changed.
8108 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8109 Rename locals to avoid shadowing.
5671df8f 8110 (Fvertical_motion): Mark locals as initialized.
85f24f61 8111
181aa2be 8112 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8113 (casify_region): Mark local as initialized.
181aa2be 8114
930d429c
PE
8115 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8116
7082eac6
PE
8117 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8118 New macros, so that the caller can use some names other than
8119 gcpro1, gcpro2, etc.
8120 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8121 of the new macros.
8122 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8123 argument, for consistency with GCPRO2_VAR, etc: it is now the
8124 prefix of the variable, not the variable itself. All uses
8125 changed.
38b2c076
PE
8126 * dired.c (directory_files_internal, file_name_completion):
8127 Rename locals to avoid shadowing.
8128
15206ed9
PE
8129 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8130 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8131 dired.c's scmp function, had undefined behavior.
8132 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8133 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8134 * buffer.h: ... to here, because these macros use current_buffer,
8135 and the new implementation with inline functions needs to have
8136 current_buffer in scope now, rather than later when the macros
8137 are used.
8138 (downcase, upcase1): New static inline functions.
8139 (DOWNCASE, UPCASE1): Reimplement using these functions.
8140 This avoids undefined behavior in expressions like
8141 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8142 from race conditions in accessing the global variables
8143 case_temp1 and case_temp2.
8144 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8145 * lisp.h (case_temp1, case_temp2): Remove their decls.
8146 * character.h (ASCII_CHAR_P): Move from here ...
8147 * lisp.h: ... to here, so that the inline functions mentioned
8148 above can use them.
8149
4a6bea26
PE
8150 * dired.c (directory_files_internal_unwind): Now static.
8151
f14b7e14
PE
8152 * fileio.c (file_name_as_directory, directory_file_name):
8153 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8154 Now static.
2893f146
PE
8155 (file_name_as_directory): Use const pointers when appropriate.
8156 (Fexpand_file_name): Likewise. In particular, newdir might
8157 point at constant storage, so make it a const pointer.
fd4ead52 8158 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8159 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8160 signedness issues.
f839df0c
PE
8161 (Fset_file_times, Finsert_file_contents, auto_save_error):
8162 Rename locals to avoid shadowing.
f14b7e14 8163
5716756e 8164 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8165 (Ftry_completion, Fall_completions): Rename or remove locals
8166 to avoid shadowing.
5716756e 8167
b4c3046a
PE
8168 * marker.c (bytepos_to_charpos): Remove; unused.
8169
b45db522
PE
8170 * lisp.h (verify_bytepos, count_markers): New decls,
8171 so that gcc does not warn that these functions aren't declared.
8172
85876d07
PE
8173 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8174 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8175 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8176 (copy_text): Remove unused local var.
85876d07 8177
03d78a21 8178 * filelock.c (within_one_second): Now static.
b3dd38ab 8179 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8180
5df8f01b
PE
8181 * buffer.c (fix_overlays_before): Mark locals as initialized.
8182 (fix_start_end_in_overlays): Likewise. This function should be
8183 simplified by using pointers-to-pointers, but that's a different
8184 matter.
b1d876f1 8185 (switch_to_buffer_1): Now static.
8f54f30a
PE
8186 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8187 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8188
a70072c9 8189 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8190 Fix pointer signedness issue.
edced198
PE
8191 (sys_subshell): Mark local as volatile if checking for lint,
8192 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8193 (MAXPATHLEN): Define only if needed.
a70072c9 8194
a0977c44
PE
8195 * process.c (serial_open, serial_configure): Move decls from here ...
8196 * systty.h: ... to here, so that they can be checked.
8197
a884fdcc
PE
8198 * fns.c (get_random, seed_random): Move extern decls from here ...
8199 * lisp.h: ... to here, so that they can be checked.
8200
604efe86 8201 * sysdep.c (reset_io): Now static.
b8950c94 8202 (wait_for_termination_signal): Remove; unused.
604efe86 8203
38fc62d9
PE
8204 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8205 (copy_keymap_item, append_key, push_text_char_description):
8206 Now static.
1004a21a 8207 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8208 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8209 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8210 (describe_map_tree):
8211 Rename locals to avoid shadowing.
38fc62d9 8212
2f2650da
PE
8213 * keyboard.c: Declare functions static if they are not used elsewhere.
8214 (echo_char, echo_dash, cmd_error, top_level_2):
8215 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8216 (read_char, kbd_buffer_get_event, make_lispy_position):
8217 (make_lispy_event, make_lispy_movement, apply_modifiers):
8218 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8219 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8220 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8221 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8222 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8223
a053e86c 8224 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8225 (mark_kboards): Move decl here ...
8226 * alloc.c (mark_kboards): ... from here.
a053e86c 8227
4752793e
PE
8228 * lisp.h (force_auto_save_soon): New decl.
8229
74f10ca7 8230 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8231 (DEFINE_DUMMY_FUNCTION): New macro.
8232 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8233 Use it.
c03cd23f
PE
8234 (main): Add casts to avoid warnings
8235 if GCC considers string literals to be constants.
74f10ca7 8236
022e70d4
PE
8237 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8238
59d6fe83
PE
8239 * dbusbind.c: Pointer signedness fixes.
8240 (xd_signature, xd_append_arg, xd_initialize):
8241 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8242 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8243 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8244 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8245
78320123
PE
8246 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8247 if GCC considers string literals to be constants.
49cebcca 8248 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8249
35ac2a97
SM
82502011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8251
fb103ca9
SM
8252 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8253 (print_preprocess, print_object): New macro to fix last change.
8254
35ac2a97
SM
8255 * print.c (print_preprocess): Don't forget font objects.
8256
62973b41
JB
82572011-03-16 Juanma Barranquero <lekktu@gmail.com>
8258
8259 * emacs.c (USAGE3): Doc fixes.
8260
0e48bb22
AS
82612011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8262
8263 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8264 structure.
8265
7684e57b
JB
82662011-03-14 Juanma Barranquero <lekktu@gmail.com>
8267
8268 * lisp.h (VWindow_system, Qfile_name_history):
8269 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8270 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8271 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8272
8273 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8274 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8275
8276 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8277 * w32console.c (detect_input_pending, read_input_pending)
8278 (encode_terminal_code):
8279 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8280 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8281 (w32_system_caret_y, Qfile_name_history):
8282 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8283 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8284 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8285 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8286 * w32proc.c (Qlocal, report_file_error):
8287 * w32term.c (Vwindow_system, updating_frame):
8288 * w32uniscribe.c (initialized, uniscribe_font_driver):
8289 Remove unneeded extern declarations.
8290
2aa46d6c
CY
82912011-03-14 Chong Yidong <cyd@stupidchicken.com>
8292
c96bbc66 8293 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8294
cffc6f3b
CY
82952011-03-13 Chong Yidong <cyd@stupidchicken.com>
8296
8297 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8298 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8299 These macros can no longer be used for assignment.
8300
44f230aa
SM
8301 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8302 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8303 (record_buffer_markers, fetch_buffer_markers): New functions for
8304 recording and fetching special buffer markers.
8305 (set_buffer_internal_1, set_buffer_temp): Use them.
8306
8307 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8308
8309 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8310
8311 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8312 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8313
8314 * xdisp.c (hscroll_window_tree):
8315 (reconsider_clip_changes): Use PT instead of BUF_PT.
8316
d251f04b
EZ
83172011-03-13 Eli Zaretskii <eliz@gnu.org>
8318
8319 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8320 $(EMACS_ROOT)/lib/intprops.h.
8321
f0c77cd1
PE
83222011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8323
3eca4629
PE
8324 Fix more problems found by GCC 4.5.2's static checks.
8325
7c86ee98
PE
8326 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8327 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8328 (xg_free_frame_widgets): Make it clear that a local variable is
8329 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8330 (gdk_window_get_screen): Make it clear that this macro is needed
8331 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8332 (int_gtk_range_get_value): New function, which avoids a diagnostic
8333 from gcc -Wbad-function-cast.
8334 (xg_set_toolkit_scroll_bar_thumb): Use it.
8335 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8336 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8337 (get_utf8_string, xg_get_file_with_chooser):
8338 Rename locals to avoid shadowing.
8339 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8340
41729b81
PE
8341 * xgselect.c (xg_select): Remove unused var.
8342
f0c77cd1
PE
8343 * image.c (four_corners_best): Mark locals as initialized.
8344 (gif_load): Initialize transparent_p to zero (Bug#8238).
8345 Mark another local as initialized.
ec6cf4c6 8346 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8347
ce0ad53d 8348 * image.c (clear_image_cache): Now static.
d5d5a617 8349 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8350 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8351 (x_edge_detection): Remove unnecessary cast that
8352 gcc -Wbad-function-cast diagnoses.
2037898d 8353 (gif_load): Fix pointer signedness.
6ae141d6
PE
8354 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8355 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8356
33383987 83572011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8358
d32df629
PE
8359 Improve quality of tests for time stamp overflow.
8360 For example, without this patch (encode-time 0 0 0 1 1
8361 1152921504606846976) returns the obviously-bogus value (-948597
8362 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8363 reports time overflow. See
8364 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8365 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8366 * editfns.c: Include limits.h and intprops.h.
8367 (TIME_T_MIN, TIME_T_MAX): New macros.
8368 (time_overflow): Move earlier, to before first use.
8369 (hi_time, lo_time): New functions, for an accurate test for
8370 out-of-range times.
8371 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8372 (Fget_internal_run_time): Don't assume time_t fits in int.
8373 (make_time): Use list2 instead of Fcons twice.
8374 (Fdecode_time): More accurate test for out-of-range times.
8375 (check_tm_member): New function.
8376 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8377 (lisp_time_argument): Don't rely on undefined left-shift and
8378 right-shift behavior when checking for time stamp overflow.
8be6f318 8379
fe31d94c
PE
8380 * editfns.c (time_overflow): New function, refactoring common code.
8381 (Fformat_time_string, Fdecode_time, Fencode_time):
8382 (Fcurrent_time_string): Use it.
8383
8be6f318
PE
8384 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8385 * dired.c (make_time): Move to ...
8386 * editfns.c (make_time): ... here.
8387 * systime.h: Note the move.
8388
09d9db2c 83892011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8390
126bc0dc
YM
8391 * fringe.c (update_window_fringes): Remove unused variables.
8392
c47cbdfd
YM
8393 * unexmacosx.c (copy_data_segment): Also copy __got section.
8394 (Bug#8223)
8395
7ac80be9
EZ
83962011-03-12 Eli Zaretskii <eliz@gnu.org>
8397
c96bbc66 8398 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8399 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8400 Constify `char *' arguments and their references according to
8401 prototypes in tparam.h.
8402
ecb0f94d 8403 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8404
7ac80be9
EZ
8405 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8406 Adapt all references accordingly.
8407
8408 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8409
ef1fd07e
TT
84102011-03-11 Tom Tromey <tromey@redhat.com>
8411
8412 * buffer.c (syms_of_buffer): Remove obsolete comment.
8413
7ef4b50c
EZ
84142011-03-11 Eli Zaretskii <eliz@gnu.org>
8415
8416 * termhooks.h (encode_terminal_code): Declare prototype.
8417
8418 * msdos.c (encode_terminal_code): Don't declare prototype.
8419
8420 * term.c (encode_terminal_code): Now external again, used by
8421 w32console.c and msdos.c.
8422
44f230aa
SM
8423 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8424 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8425
4b1ec863 84262011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8427
1714f52b 8428 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8429
4b1ec863
PE
8430 * fringe.c (update_window_fringes): Mark locals as initialized
8431 (Bug#8227).
8432 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8433
524c7aa6
PE
8434 * alloc.c (mark_fringe_data): Move decl from here ...
8435 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8436 to check its interface.
8437 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8438
a5c0af81 8439 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8440 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8441 (fontset_font): Mark local as initialized.
a9a06e0b 8442 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8443
b4716021
PE
8444 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8445
811e9bac 8446 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8447 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8448 (x_own_selection, Fx_disown_selection_internal): Rename locals
8449 to avoid shadowing.
8450 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8451
7e3ab302
PE
8452 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8453 so that the caller can use some name other than gcpro1.
8454 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8455 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8456 (Fx_backspace_delete_keys_p):
8457 Use them to avoid shadowing, and rename vars to avoid shadowing.
8458 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8459 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8460 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8461 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8462 Remove unused locals.
7e3ab302
PE
8463 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8464 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8465 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8466 macros.
f78faa98 8467
e2b13473
PE
8468 * xterm.h (x_mouse_leave): New decl.
8469
77f23912
PE
8470 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8471 Remove unused functions.
cdf4ba58
PE
8472 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8473 (x_calc_absolute_position): Now static.
7411c686 8474 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8475 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8476 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8477 unless they are used.
38d0b34a
PE
8478 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8479 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8480 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8481 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8482 (x_error_catcher, x_connection_closed, x_error_handler):
8483 (x_error_quitter, xembed_send_message, x_iconify_frame):
8484 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8485 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8486 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8487
44f230aa
SM
8488 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8489 Rename or move locals to avoid shadowing.
6b463e58 8490 (tty_defined_color, merge_face_heights): Now static.
5967d051 8491 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8492 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8493 does not deduce is never used uninitialized.
73719eba
PE
8494 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8495 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8496
426994c3 8497 * terminal.c (store_terminal_param): Now static.
5489860b 8498
032f1620 8499 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8500 (set_frame_menubar): Remove unused local.
d4323972 8501 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8502 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8503 since they might point to immutable storage.
281585b0
PE
8504 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8505 since it's unused otherwise.
032f1620 8506
367c19e5 8507 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8508 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8509 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8510 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8511 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8512 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8513 does not deduce are never used uninitialized.
70739cbe 8514
07b48fa9
PE
8515 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8516
8868a238 8517 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8518 * window.c (window_loop, size_window):
8519 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8520
7e5cf297 8521 * window.c (display_buffer): Now static.
d6550a9f
PE
8522 (size_window): Mark variables that gcc -Wuninitialized
8523 does not deduce are never used uninitialized.
a586633d
PE
8524 * window.h (check_all_windows): New decl, to forestall
8525 gcc -Wmissing-prototypes diagnostic.
5b555da1 8526 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8527
f6095868
PE
8528 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8529 shadowing.
8530 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8531 Include <limits.h>.
8532 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8533 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8534 (load_charset_map): Mark variables that gcc -Wuninitialized
8535 does not deduce are never used uninitialized.
53df7c11 8536 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8537
f38b440c
PE
8538 * coding.c (coding_set_source, coding_set_destination):
8539 Use "else { /* comment */ }" rather than "else /* comment */;"
8540 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8541 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8542 a block, when the outer 'i' will do.
8543 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8544 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8545 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8546 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8547 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8548 Rename locals to avoid shadowing.
8549 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8550 * coding.c (emacs_mule_char, encode_invocation_designation):
8551 Now static, since they're not used elsewhere.
413bb2db 8552 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8553 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8554 (decode_coding_emacs_mule): Mark variables that gcc
8555 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8556 (detect_coding_iso_2022): Initialize a local variable that might
8557 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8558 this initialization is needed. (Bug#8211)
5f58e762
PE
8559 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8560 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8561 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8562 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8563 Remove unused macros.
f38b440c 8564
232b38b9 8565 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8566 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8567 * character.c (string_count_byte8): Likewise.
232b38b9 8568
fb90da1b
PE
8569 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8570 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8571
fb93dbc2
PE
8572 * chartab.c (copy_sub_char_table): Now static, since it's not used
8573 elsewhere.
5c156ace
PE
8574 (sub_char_table_ref_and_range, char_table_ref_and_range):
8575 Rename locals to avoid shadowing.
bbcd0949 8576 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8577
7d3b3862 8578 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8579 (BIDI_BOB): Remove unused macro.
7d3b3862 8580
6be7d3da
PE
8581 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8582 deduce are never used uninitialized.
c2ed9c8b 8583 * term.c (encode_terminal_code): Likewise.
6be7d3da 8584
75f8807f 8585 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8586
50938595
PE
8587 * tparam.h: New file.
8588 * term.c, tparam.h: Include it.
8589 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8590 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8591 Move these decls to tparam.h, and make them agree with what
8592 is actually in tparam.c. The previous trick of using incompatible
8593 decls in different modules does not conform to the C standard.
8594 All callers of tparam changed to use tparam's actual API.
8595 * tparam.c (tparam1, tparam, tgoto):
8596 Use const pointers where appropriate.
8597
fbceeba2
PE
8598 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8599 * cm.h (struct cm): Likewise.
8600 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8601 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8602 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8603 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8604 (turn_on_face, init_tty): Likewise.
8605 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8606
7f3f1250
PE
8607 * term.c (term_mouse_position): Rename local to avoid shadowing.
8608
e6ca6543
PE
8609 * alloc.c (mark_ttys): Move decl from here ...
8610 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8611
c40f8d15
AS
86122011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8613
8614 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8615
cfe0661d
JB
86162011-03-09 Juanma Barranquero <lekktu@gmail.com>
8617
8618 * search.c (compile_pattern_1): Remove argument regp, unused since
8619 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8620 (compile_pattern): Don't pass it.
8621
0afb4571
J
86222011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8623
8624 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8625 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8626 for ! HAVE_GTK3.
8627 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8628
8629 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8630
8631 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8632 gdk_window_get_screen, gdk_window_get_geometry,
8633 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8634 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8635 (xg_get_pixbuf_from_pixmap): New function.
8636 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8637 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8638 Call xg_get_pixbuf_from_pixmap instead of
8639 gdk_pixbuf_get_from_drawable.
8640 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8641 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8642 (xg_check_special_colors): Use GtkStyleContext and its functions
8643 for HAVE_GTK3.
8644 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8645 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8646 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8647 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8648 Call gtk_widget_get_preferred_size.
0afb4571
J
8649 (xg_frame_resized): gdk_window_get_geometry only takes 5
8650 parameters.
44f230aa
SM
8651 (xg_win_to_widget, xg_event_is_for_menubar):
8652 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8653 (xg_set_widget_bg): New function.
8654 (delete_cb): New function.
895009e1 8655 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8656 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8657 (xg_set_background_color): Call xg_set_widget_bg.
8658 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8659 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8660 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8661 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8662 if ! HAVE_GTK3.
8663 (update_frame_tool_bar): Call gtk_widget_hide.
8664 (xg_initialize): Use GDK_KEY_g.
8665
8666 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8667 if ! HAVE_GTK3
8668 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8669
8670 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8671 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8672 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8673
1c2cc4ef
JB
86742011-03-08 Juanma Barranquero <lekktu@gmail.com>
8675
8676 * w32xfns.c (select_palette): Check success of RealizePalette against
8677 GDI_ERROR, not zero.
8678
33383987 8679See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8680
8681;; Local Variables:
8682;; coding: utf-8
aac0c6e3
MR
8683;; End:
8684
33383987 8685 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8686
8687 This file is part of GNU Emacs.
8688
8689 GNU Emacs is free software: you can redistribute it and/or modify
8690 it under the terms of the GNU General Public License as published by
8691 the Free Software Foundation, either version 3 of the License, or
8692 (at your option) any later version.
8693
8694 GNU Emacs is distributed in the hope that it will be useful,
8695 but WITHOUT ANY WARRANTY; without even the implied warranty of
8696 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8697 GNU General Public License for more details.
8698
8699 You should have received a copy of the GNU General Public License
8700 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.