Avoid long futile looping on a TTY under huge values of hscroll.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6dd5a677
EZ
12012-07-05 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (display_line): Fix horizontal pixel coordinates when
4 hscroll is larger than the line width. Fixes long and futile
5 looping inside extend_face_to_end_of_line (on a TTY) producing
6 glyphs that are not needed and thrown away.
7
6b312f0f
DA
82012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
9
10 * marker.c (set_marker_restricted_both): Simplify by using
11 clip_to_bounds.
12
f520ef9b
PE
132012-07-05 Paul Eggert <eggert@cs.ucla.edu>
14
15 * editfns.c (region_limit): Simplify by using clip_to_bounds.
16
383b7c95
JD
172012-07-05 Jan Djärv <jan.h.d@swipnet.se>
18
19 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
20 not defined (Bug#11768).
21 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
22 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
23 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
24 followed by gtk_box_set_homogeneous (Bug#11768).
25 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
26 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
27 gtk_scrollbar_new (Bug#11768).
28 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
29 (is_box_type): New function (Bug#11768).
30 (xg_tool_item_stale_p): Call is_box_type.
31 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
32 with default display (Bug#11768).
33
d6e7bf45
EZ
342012-07-05 Eli Zaretskii <eliz@gnu.org>
35
36 * xdisp.c (window_hscroll_limited): New function.
37 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
38 coordinates when window's hscroll is set to insanely large
39 values. (Bug#11857)
40
431391ec
JB
412012-07-05 Juanma Barranquero <lekktu@gmail.com>
42
43 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
44 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
45
23f86fce
DA
462012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
47
48 Cleanup xmalloc.
49 * lisp.h (xzalloc): New prototype. Omit needless casts.
50 * alloc.c (xzalloc): New function. Omit needless casts.
51 * charset.c: Omit needless casts. Convert all calls to
52 xmalloc with following memset to xzalloc.
53 * dispnew.c: Likewise.
54 * fringe.c: Likewise.
55 * image.c: Likewise.
56 * sound.c: Likewise.
57 * term.c: Likewise.
58 * w32fns.c: Likewise.
59 * w32font.c: Likewise.
60 * w32term.c: Likewise.
61 * xfaces.c: Likewise.
62 * xfns.c: Likewise.
63 * xterm.c: Likewise.
64 * atimer.c: Omit needless casts.
65 * buffer.c: Likewise.
66 * callproc.c: Likewise.
67 * ccl.c: Likewise.
68 * coding.c: Likewise.
69 * composite.c: Likewise.
70 * doc.c: Likewise.
71 * doprnt.c: Likewise.
72 * editfns.c: Likewise.
73 * emacs.c: Likewise.
74 * eval.c: Likewise.
75 * filelock.c: Likewise.
76 * fns.c: Likewise.
77 * gtkutil.c: Likewise.
78 * keyboard.c: Likewise.
79 * lisp.h: Likewise.
80 * lread.c: Likewise.
81 * minibuf.c: Likewise.
82 * msdos.c: Likewise.
83 * print.c: Likewise.
84 * process.c: Likewise.
85 * region-cache.c: Likewise.
86 * search.c: Likewise.
87 * sysdep.c: Likewise.
88 * termcap.c: Likewise.
89 * terminal.c: Likewise.
90 * tparam.c: Likewise.
91 * w16select.c: Likewise.
92 * w32.c: Likewise.
93 * w32reg.c: Likewise.
94 * w32select.c: Likewise.
95 * w32uniscribe.c: Likewise.
96 * widget.c: Likewise.
97 * xdisp.c: Likewise.
98 * xmenu.c: Likewise.
99 * xrdb.c: Likewise.
100 * xselect.c: Likewise.
101
0497dc44
PE
1022012-07-05 Paul Eggert <eggert@cs.ucla.edu>
103
104 * fileio.c (time_error_value): Check the right error number.
105 Problem reported by Troels Nielsen in
106 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
107
356e7178
PE
1082012-07-04 Paul Eggert <eggert@cs.ucla.edu>
109
4e71fd89
PE
110 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
111 This should be fixed in a better way; see Eli Zaretskii in
112 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
113 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
114
f0941253
PE
115 * fileio.c (time_error_value): Rename from special_mtime.
116 The old name's problems were noted by Eli Zaretskii in
117 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
118
065c9eb4
PE
119 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
120 This variable's comment says Emacs needs at least one GDB-visible
121 symbol of type enum pvec_type, to work around GDB problems.
122 The symbol's value doesn't matter.
123
356e7178
PE
124 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
125 that causes compilation to fail on pre-C99 compilers.
126
95f61aa2
JB
1272012-07-04 Juanma Barranquero <lekktu@gmail.com>
128
129 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
130 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
131
3884d954
DA
1322012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
133
d209e2fb 134 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
135 headers for buffer_defaults and buffer_local_symbols.
136 Reported by Juanma Barranquero <lekktu@gmail.com>.
137
ee28be33
SM
1382012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
139
140 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
141 * lisp.h (enum pvec_type): Use fewer bits.
142 (PSEUDOVECTOR_SIZE_BITS): New constant.
143 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
144 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
145 change in pvec_type.
146 (PSEUDOVECTOR_TYPEP): New macro.
147 (TYPED_PSEUDOVECTORP): Use it.
148 * fns.c (internal_equal): Adapt code to extract pvectype.
149 * emacs.c (gdb_pvec_type): Update type.
150 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
151 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
152 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
153 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
154 (sweep_vectors): Use it. Use local var `total_bytes' instead of
155 abusing vector->header.next.nbytes.
156 (live_vector_p): Use PVEC_TYPE.
157 (mark_object): Adapt code to extract pvectype. Use switch.
158
c7f2cd7f
PE
1592012-07-04 Paul Eggert <eggert@cs.ucla.edu>
160
161 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
162 Tighten new eassert a bit.
163
8ce70ed2
DA
1642012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
165
166 Fix compilation with --enable-gcc-warnings and -O1
167 optimization level.
168 * doprnt.c (doprnt): Change type of tem to int, initialize
169 to avoid compiler warning. Add eassert.
170 * search.c (simple_search): Initialize match_byte to avoid
171 compiler warning. Add eassert.
172
dea7f1e5
PE
1732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
174
24a212eb
PE
175 Avoid weird behavior with large horizontal scrolls.
176 Without this change, for example, large hscroll values would
177 mess up Emacs's display on Fedora 15 x86, presumably due to
178 overflows in int calculations in the display code.
179 Also, if buffers had long lines, Emacs would freeze.
180 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
181 (set_window_hscroll): New function, containing the old guts of
182 Fset_window_hscroll. Return the clipped value.
183 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
184 This avoids the need to check against PTRDIFF_MAX.
185
dea7f1e5
PE
186 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
187
76046526
DA
1882012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
189
190 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
191
39adff0d
PE
1922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
193
63807d47
PE
194 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
195 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
196 since GCC 4.4.6 issues a bogus warning for them.
197
39adff0d
PE
198 Fix bugs in file timestamp newness comparisons.
199 * fileio.c (Ffile_newer_than_file_p):
200 * lread.c (Fload): Use full timestamp resolution of files,
201 not just the 1-second resolution, so that files that are only
202 slightly newer still count as newer.
203 * fileio.c (Ffile_newer_than_file_p): Don't assume file
204 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
205
dbeed9a6
PE
2062012-07-03 Paul Eggert <eggert@cs.ucla.edu>
207
208 * fileio.c: Improve handling of file time marker. (Bug#11852)
209 (special_mtime): New function.
210 (Finsert_file_contents, Fverify_visited_file_modtime):
211 Use it to set special mtime values consistently.
212
636334d6
AS
2132012-07-03 Andreas Schwab <schwab@linux-m68k.org>
214
215 * fileio.c (Finsert_file_contents): Properly handle st_mtime
216 marker for non-existing file. (Bug#11852)
217
e2017fe2
GM
2182012-07-03 Glenn Morris <rgm@gnu.org>
219
220 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
221 and did not make it into globals.h).
222
404dbd37
TT
2232012-07-03 Tom Tromey <tromey@redhat.com>
224
225 * window.c (Fset_window_margins, Fset_window_fringes)
226 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
227 * textprop.c (Fprevious_property_change): No longer static.
228 * syntax.c (Fsyntax_table_p): No longer static.
229 * process.c (Fget_process, Fprocess_datagram_address): No longer
230 static.
231 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
232 * keyboard.c (Fcommand_execute): No longer static.
233 Remove EXFUN.
234 * insdel.c (Fcombine_after_change_execute): No longer static.
235 * image.c (Finit_image_library): No longer static.
236 * fileio.c (Fmake_symbolic_link): No longer static.
237 * eval.c (Ffetch_bytecode): No longer static.
238 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
239 * doc.c (Fdocumentation_property, Fsnarf_documentation):
240 No longer static.
404dbd37
TT
241 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
242 static.
243 * dired.c (Ffile_attributes): No longer static.
244 * composite.c (Fcomposition_get_gstring): No longer static.
245 * callproc.c (Fgetenv_internal): No longer static.
246
247 * ccl.h: Remove EXFUNs.
248 * buffer.h: Remove EXFUNs.
249 * dispextern.h: Remove EXFUNs.
250 * intervals.h: Remove EXFUNs.
251 * fontset.h: Remove EXFUN.
252 * font.h: Remove EXFUNs.
253 * dosfns.c (system_process_attributes): Remove EXFUN.
254 * keymap.h: Remove EXFUNs.
255 * lisp.h: Remove EXFUNs.
256 * w32term.h: Remove EXFUNs.
257 * window.h: Remove EXFUNs.
258 * xsettings.h: Remove EXFUN.
259 * xterm.h: Remove EXFUN.
260
8e4fd1e1
GM
2612012-07-03 Glenn Morris <rgm@gnu.org>
262
263 * lisp.h (Frandom): Make it visible to C.
264 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
265 buffer for invisible buffers. (Bug#1229)
266
ca95b3eb
DA
2672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
268
269 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
270 values which aren't power of 2.
271 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
272 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
273 accordingly.
274
7555c33f
SM
2752012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
276
277 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
278
279 * alloc.c (mark_object): Revert part of last patch to use `switch'.
280
d12e8f5a
DA
2812012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
282
283 * alloc.c (allocate_vector_block): Remove redundant
284 calls to mallopt if DOUG_LEA_MALLOC is defined.
285 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
286 avoid calls to mallopt if zero_vector is returned.
287
296094c3
DA
2882012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
289
290 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
291 is enabled, avoid dereferencing NULL current_sblock if
292 running undumped.
293
36429c89
DA
2942012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
295
296 Cleanup basic buffer management.
297 * buffer.h (struct buffer): Change layout to use generic vector
298 marking code. Fix some comments. Change type of 'clip_changed'
299 to bitfield. Remove unused #ifndef old.
300 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
301 (GET_OVERLAYS_AT): Fix indentation.
302 (for_each_per_buffer_object_at): New macro.
303 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
304 (Fbuffer_local_variables): Use it.
305 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
306 * alloc.c (allocate_buffer): Adjust to match new layout of
307 struct buffer. Fix comment.
308 (mark_overlay): New function.
309 (mark_buffer): Use it. Use mark_vectorlike to mark normal
310 Lisp area of struct buffer.
311 (mark_object): Use it. Adjust marking of misc objects
312 and related comments.
313
3b3e4cac
PE
3142012-07-02 Paul Eggert <eggert@cs.ucla.edu>
315
316 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
317 wrapper that is not needed because the wrapped code is a no-op (zero
318 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
319 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
320
cf5c0175
DA
3212012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
322
323 * alloc.c (mark_buffer): Simplify. Remove prototype.
324 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 325 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
326 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
327 redundant calls to mark_vectorlike for bool vectors.
328
ca26824c
GM
3292012-06-30 Glenn Morris <rgm@gnu.org>
330
2e4c5312
GM
331 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
332
ca26824c
GM
333 * epaths.in (PATH_SITELOADSEARCH): New.
334 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
335 This is rather than relying on --enable-locallisppath elements
336 having "site-lisp" in their names. (Bug#10208#25, 11658)
337
0d23c240
EZ
3382012-06-30 Eli Zaretskii <eliz@gnu.org>
339
c9240d7a
EZ
340 * w32proc.c (sys_select): Accept and ignore one more argument.
341
342 * w32.c (emacs_gnutls_pull): Call select with one more argument.
343
0d23c240 344 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 345 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
346
347 * sysdep.c: Don't include dos.h and dosfns.h.
348
349 * process.c (sys_select):
350 * msdos.c (sys_select): Accept one more argument and ignore it.
351
352 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
353 adapt data types and code to that.
354
355 * dosfns.c:
356 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
357 which clashes with the gnulib function of the same name.
358
af5a5a98
AS
3592012-06-30 Andreas Schwab <schwab@linux-m68k.org>
360
c5e4379c
AS
361 * font.c (font_style_to_value, font_style_symbolic)
362 (font_prop_validate_style): Add type checks for values in
363 font_style_table.
364
af5a5a98
AS
365 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
366 argument.
367 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
368 uses.
369
8d38f461
EZ
3702012-06-29 Eli Zaretskii <eliz@gnu.org>
371
2e5a6631
EZ
372 * xdisp.c (try_window_id): Undo last change.
373
8d38f461
EZ
374 * w32.c (getwd): Adjust commentary about startup_dir.
375 (init_environment): Always call sys_access, even in non-MSVC
376 builds. Don't chdir to the directory of the Emacs executable.
377 This undoes code from 1997 which was justified by the need to
378 "avoid conflicts when removing and renaming directories". But its
379 downside was that every relative file name was being interpreted
380 relative to the directory of the Emacs executable, which can never
381 be TRT. In particular, it broke sys_access when called with
382 relative file names.
383 (sys_access): Map GetLastError to errno.
384
2af3565e
DA
3852012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
386
387 * window.h (struct window): Change type of 'fringes_outside_margins'
388 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 389 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
390 Adjust comment.
391 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
392 to ptrdiff_t.
393
c8d3a25c 3942012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 395
c8d3a25c
GM
396 * gnutls.c (emacs_gnutls_handshake):
397 Add QUIT to make the loop interruptible.
57570cd3 398
c8d3a25c 3992012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 400
c8d3a25c
GM
401 * charset.c (init_charset): Make lack of etc/charsets fatal.
402
3e984ee8
DA
4032012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
404
405 * editfns.c (region_limit): Fix type mismatch.
406
ef884f23
DA
4072012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
408
409 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
410 undefined. Convert from xassert to eassert.
411 * nsmenu.m: Convert from xassert to eassert.
412 * nsterm.m: Likewise.
413
7d7e0027
SM
4142012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
415
416 * editfns.c (region_limit): Clip to narrowing (bug#11770).
417
aa754e6a
PE
4182012-06-28 Paul Eggert <eggert@cs.ucla.edu>
419
420 Avoid integer overflow on scroll-left and scroll-right.
421 * window.c (HSCROLL_MAX): New macro.
422 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
423 overflow when requested scroll falls outside ptrdiff_t range.
424
80b00b08
DA
4252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
426
427 * window.h (struct window): Change type of 'hscroll',
428 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
429 'last_modified' and 'last_overlay_modified' to EMACS_INT.
430 Adjust users accordingly.
431 * xdisp.c (try_cursor_movement): Replace type check with eassert.
432 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
433 from EMACS_INT to ptrdiff_t.
434 (make_window): Omit redundant initialization.
435
62b2bcf6
JB
4362012-06-28 Juanma Barranquero <lekktu@gmail.com>
437
438 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
439
45942c7d
DA
4402012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
441
442 * window.h (struct window): Change type of 'use_time' and
443 'sequence_number' from Lisp_Object to int.
444 * frame.c (make_frame): Adjust users accordingly.
445 * print.c (print_object): Likewise.
446 * window.c (select_window, Fwindow_use_time, make_parent_window)
447 (make_window): Likewise.
448
e509cfa6
DA
4492012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
450
451 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
452 enabled with --enable-checking=[all,glyphs] configure option.
453 Fix GLYPH_DEBUG usage assuming that it may be undefined,
454 adjust comments accordingly.
455 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
456 undefined, adjust comments accordingly.
457 * image.c: Likewise.
458 * scroll.c: Likewise.
459 * w32fns.c: Likewise.
460 * w32term.c: Likewise.
461 * xdisp.c: Likewise.
462 * xfaces.c: Likewise.
463 * xfns.c: Likewise.
464 * xterm.c: Likewise.
465
a54e2c05
DA
4662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
467
468 Generalize run-time debugging checks.
469 * dispextern.h (XASSERTS): Remove.
470 * fontset.c (xassert): Remove.
471 Convert from xassert to eassert.
472 * alloc.c: Convert from xassert to eassert.
473 * bidi.c: Likewise.
474 * dispnew.c: Likewise.
475 * fns.c: Likewise.
476 * fringe.c: Likewise.
477 * ftfont.c: Likewise.
478 * gtkutil.c: Likewise.
479 * image.c: Likewise.
480 * keyboard.c: Likewise.
481 * menu.c: Likewise.
482 * process.c: Likewise.
483 * scroll.c: Likewise.
484 * sound.c: Likewise.
485 * term.c: Likewise.
486 * w32console.c: Likewise.
487 * w32fns.c: Likewise.
488 * w32term.c: Likewise.
489 * window.c: Likewise.
490 * xdisp.c: Likewise.
491 * xfaces.c: Likewise.
492 * xfns.c: Likewise.
493 * xselect.c: Likewise.
494 * xterm.c: Likewise.
495
1ec4b7b2
SM
4962012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
497
498 * fns.c (maybe_resize_hash_table): Output message when growing the
499 purify-hashtable.
500
2014308a
DA
5012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
502
503 * alloc.c (allocate_string_data): Remove dead code.
504 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
505 avoid GCC warning about unused macro.
506
246155eb
DA
5072012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
508
509 * alloc.c (allocate_string): Omit intervals initialization.
510 * alloc.c (make_uninit_multibyte_string): Initialize intervals
511 as in make_pure_string and make_pure_c_string.
512
43184b7b
DA
5132012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
514
d209e2fb 515 * alloc.c (allocate_string): Fix last change.
43184b7b 516
3fe6dd74
DA
5172012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
518
d209e2fb 519 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
520 to memset, add explicit initialization where appropriate.
521
1ba6038a
GM
5222012-06-27 Glenn Morris <rgm@gnu.org>
523
524 * lisp.mk (lisp): Remove paths.elc.
525
c89926a5
CY
5262012-06-27 Chong Yidong <cyd@gnu.org>
527
528 * doc.c (Fsubstitute_command_keys): Fix punctuation.
529
ed6b3510
JW
5302012-06-26 John Wiegley <johnw@newartisans.com>
531
1ec4b7b2 532 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
533 on Mac OS X Lion: __mod_init_func and __mod_term_func.
534
ed6b3510
JW
535 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
536 when building with Clang.
537
8edd4a2b
SM
5382012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
539
540 * eval.c (Fapply): Allow calling it with a single argument.
541
f6f62d1b
EZ
5422012-06-26 Eli Zaretskii <eliz@gnu.org>
543
544 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
545 _stricmp and _strnicmp.
546 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
547
62efea5e
DA
5482012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
549
550 * alloc.c (allocate_window): Zero out non-Lisp part of newly
551 allocated window.
552 (allocate_process): Likewise for new process.
8edd4a2b 553 (allocate_terminal): Change to use offsetof.
62efea5e
DA
554 (allocate_frame): Likewise.
555 * frame.c (make_frame): Omit redundant initialization.
556 * window.c (make_parent_window): Use memset.
557 (make_window): Omit redundant initialization.
558 * process.c (make_process): Omit redundant initialization.
559 * terminal.c (create_terminal): Likewise.
560
42997f4d
DA
5612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
562
563 * term.c (delete_tty): Remove redundant call to memset.
564
1130ecfc
DA
5652012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
566
567 * alloc.c: Remove build_string.
568 * lisp.h: Define build_string as static inline. This provides
569 a better opportunity to optimize away calls to strlen when the
570 function is called with compile-time constant argument.
571 * image.c (imagemagick_error): Convert to build_string.
572 * w32proc.c (sys_spawnve): Likewise.
573 * xterm.c (x_term_init): Likewise.
574
cf38a720
PE
5752012-06-26 Paul Eggert <eggert@cs.ucla.edu>
576
99027bdd
PE
577 Use sprintf return value instead of invoking strlen on result.
578 In the old days this wasn't portable, since some sprintf
579 implementations returned char *. But they died out years ago and
580 Emacs already assumes sprintf returns int.
581 Similarly for float_to_string.
582 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
583 * ccl.c (ccl_driver):
584 * character.c (string_escape_byte8):
585 * data.c (Fnumber_to_string):
586 * doprnt.c (doprnt):
587 * print.c (print_object):
588 * xdisp.c (message_dolog):
589 * xfns.c (syms_of_xfns):
590 Use sprintf or float_to_string result to avoid need to call strlen.
591 * data.c (Fnumber_to_string):
592 Use make_unibyte_string, since the string must be ASCII.
593 * lisp.h, print.c (float_to_string): Now returns int length.
594 * term.c (produce_glyphless_glyph):
595 Use sprintf result rather than recomputing it.
596
cf38a720
PE
597 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
598 * Makefile.in (ALL_CFLAGS):
599 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
600 * gmalloc.c, regex.c: Include <config.h> unconditionally.
601
3511c784
DA
6022012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
603
0a08eb21 604 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
605 strcasecmp if available.
606 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
607
fb7da12e
AS
6082012-06-25 Andreas Schwab <schwab@linux-m68k.org>
609
610 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
611 Avoid comma operator.
612 * menu.c (push_submenu_start, push_submenu_end)
613 (push_left_right_boundary, push_menu_pane): Likewise.
614 * msdos.c (dos_rawgetc): Likewise.
615
afa2ffd8
DA
6162012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
617
618 * xfns.c (xic_create_fontsetname): Remove redundant calls
619 to memset.
620
b3b4476b
PE
6212012-06-25 Paul Eggert <eggert@cs.ucla.edu>
622
4495ff38
PE
623 * gtkutil.c (get_utf8_string): Remove redundant assignment.
624 sprintf already null-terminates its output.
625
b3b4476b
PE
626 * xfns.c (x_window): Remove redundant cast.
627
b00876c9
DA
6282012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
629
630 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
631 `const char *' to `char *' to avoid compiler warning.
632
d188e26b
PE
6332012-06-24 Paul Eggert <eggert@cs.ucla.edu>
634
885d1d74
PE
635 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
636 instead of truncating it to 63 (admittedly a generous limit).
637
d188e26b
PE
638 * process.c: Fix spelling and caps in comments.
639
e2f560b1
DN
6402012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
641
e86db54b 642 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
643 * sysdep.c (setpgrp): Remove definition, not used in this file.
644
7583a3a1
JB
6452012-06-24 Juanma Barranquero <lekktu@gmail.com>
646
647 * makefile.w32-in: Update dependencies.
648
696056c2
EZ
6492012-06-24 Eli Zaretskii <eliz@gnu.org>
650
651 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
652 (SYSTIME_H): Add nt/inc/sys/time.h.
653
654 * systime.h [WINDOWSNT]: Include sys/time.h.
655
656 * s/ms-w32.h (struct timespec): Definition moved from
657 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
658
845ca893
PE
6592012-06-24 Paul Eggert <eggert@cs.ucla.edu>
660
661 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
662 * buffer.h (buffer_slot_type_mismatch):
663 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
664 * eval.c (unwind_to_catch):
665 * image.c (my_png_error, my_error_exit):
666 * keyboard.c (quit_throw_to_read_char, user_error)
667 (Fexit_recursive_edit, Fabort_recursive_edit):
668 * lisp.h (die, args_out_of_range, args_out_of_range_3)
669 (wrong_type_argument, buffer_overflow, __executable_start)
670 (memory_full, buffer_memory_full, string_overflow, Fthrow)
671 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
672 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
673 (fatal):
674 (child_setup) [!DOS_NT]:
675 * lread.c (end_of_file_error, invalid_syntax):
676 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
677 * puresize.h (pure_write_error):
678 * search.c (matcher_overflow):
679 * sound.c (sound_perror, alsa_sound_perror):
680 * sysdep.c, syssignal.h (croak):
681 * term.c (maybe_fatal, vfatal):
682 * textprop.c (text_read_only):
683 * undo.c (user_error):
684 * unexmacosx.c (unexec_error):
685 * xterm.c (x_ins_del_lines, x_delete_glyphs):
686 Use _Noreturn rather than NO_RETURN.
687 No need for separate decl merely because of _Noreturn.
688 * sound.c (sound_warning, parse_sound):
689 Remove unnecessary forward decls.
690
f1dd8073
PE
6912012-06-24 Paul Eggert <eggert@cs.ucla.edu>
692
693 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
694 * lisp.h (WAIT_READING_MAX): New macro.
695 * dispnew.c (Fsleep_for, sit_for):
696 * keyboard.c (kbd_buffer_get_event):
697 * process.c (Faccept_process_output):
698 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
699 This improves on the previous patch, which introduced a bug
700 when time_t is unsigned and as wide as intmax_t.
701 See <http://bugs.gnu.org/9000#51>.
702
b82c1755
EZ
7032012-06-23 Eli Zaretskii <eliz@gnu.org>
704
705 * dispnew.c (sit_for, Fsleep_for):
706 * keyboard.c (kbd_buffer_get_event):
707 * process.c (Faccept_process_output): Avoid compiler warnings when
708 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
709
ca300656
JB
7102012-06-23 Juanma Barranquero <lekktu@gmail.com>
711
049ec95b
JB
712 * makefile.w32-in: Update dependencies.
713
ca300656
JB
714 * w32.c (ltime): Add return type and declare static.
715 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
716
db7b8d06
PE
7172012-06-23 Paul Eggert <eggert@cs.ucla.edu>
718
719 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
720 Privately reported by Herbert J. Skuhra.
721 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
722 All uses changed.
723 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
724 not make_lisp_timeval, when the argument is of type EMACS_TIME.
725
0bd8297f
EZ
7262012-06-23 Eli Zaretskii <eliz@gnu.org>
727
96512555
EZ
728 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
729 last argument of make_unibyte_string.
730
0bd8297f
EZ
731 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
732 language ID in the event parameters.
733
734 * w32term.c (w32_read_socket): Put the new keyboard codepage into
735 event.code, not the obscure "character set ID".
736
63def6b6
CY
7372012-06-23 Chong Yidong <cyd@gnu.org>
738
739 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
740
e8a02204
EZ
7412012-06-23 Eli Zaretskii <eliz@gnu.org>
742
388cdec0
EZ
743 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
744 * w32.c (fdutimens): New function.
745
746 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
747
748 * s/ms-w32.h (pselect): Redirect to sys_select.
749
750 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
751
e8a02204
EZ
752 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
753 in the logic of incrementing and decrementing the value of
754 use_relocatable_buffers.
755
d054f3fb
PE
7562012-06-23 Paul Eggert <eggert@cs.ucla.edu>
757
758 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
759 Privately reported by Herbert J. Skuhra.
760 [__FreeBSD__]: Remove "*/" typo after "#include".
761 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
762 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
763 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
764 Don't assume EMACS_TIME and struct timeval are the same type.
765
d35af63c
PE
7662012-06-22 Paul Eggert <eggert@cs.ucla.edu>
767
768 Support higher-resolution time stamps (Bug#9000).
769 The time stamps are only nanosecond-resolution at the C level,
770 since that's the best that any real-world system supports now.
771 But they are picosecond-resolution at the Lisp level, as that's
772 easy, and leaves room for future OS improvements.
773
774 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
775 (LIBES): Use it.
776
777 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
778 Don't get current time unless it's needed.
779
780 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
781 now provides it if it's absent.
782 (start_atimer): Port to higher-res time stamps.
783 Check for time stamp overflow. Don't get current time more
784 often than is needed.
785
786 * buffer.h (struct buffer): Buffer modtime now has high resolution.
787 Include systime.h, not time.h.
788 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
789
790 * dired.c: Include stat-time.h.
791 (Ffile-attributes): File times now have higher resolution.
792
793 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
794 (struct image): Timestamp now has higher resolution.
795
796 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
797 has at least microseconds now. All uses removed.
798 (update_frame, update_single_window, update_window, update_frame_1)
799 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
800
801 * editfns.c (time_overflow): Now extern.
802 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
803 (float-time, Fformat_time_string, Fcurrent_time_string)
804 (Fcurrent_time_zone): Accept and generate higher-resolution
805 time stamps.
806 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
807 (decode_time_components, lisp_seconds_argument): New functions.
808 (make_time): Now static.
809 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
810 Report an error if the time is invalid, rather than having the caller
811 do that.
812
813 * fileio.c: Include <stat-time.h>
814 (Fcopy_file): Copy higher-resolution time stamps.
815 Prefer to set the time stamp via a file descriptor if that works.
816 (Fset_file_times, Finsert_file_contents, Fwrite_region)
817 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
818 (Fvisited_file_modtime, Fset_visited_file_modtime):
819 Support higher-resolution time stamps.
820
821 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
822
823 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
824
825 * image.c (prepare_image_for_display, clear_image_cache)
826 (lookup_image): Port to higer-resolution time stamps.
827
828 * keyboard.c (start_polling, bind_polling_period):
829 Check for time stamp overflow.
830 (read_char, kbd_buffer_get_event, timer_start_idle)
831 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
832 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
833 Port to higher-resolution time stamps. Do not assume time_t is signed.
834 (decode_timer): New function. Timers are now vectors of length 9,
835 not 8, to accommodate the picosecond component.
836 (timer_check_2): Use it.
837
838 * nsterm.m (select_timeout, timeval_subtract): Remove.
839 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
840 as they're a bit more accurate and handle overflow better.
841 (ns_select): Change prototype to be compatible with pselect.
842 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
843 * nsterm.h (ns_select): Adjust prototype.
844
845 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
846 us-resolution time stamps.
847 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
848
849 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
850
851 * lisp.h (time_overflow): New decl.
852 (wait_reading_process_output): First arg is now intmax_t, not int,
853 to accommodate larger waits.
854
855 * process.h (struct Lisp_Process.read_output_delay):
856 Now counts nanoseconds, not microseconds.
857 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
858 EMACS_HAS_USECS.
859 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
860 (wait_reading_process_output):
861 Port to ns-resolution time stamps.
862 (Faccept_process_output, wait_reading_process_output):
863 Check for time stamp overflow. Do not assume time_t is signed.
864 (select_wrapper): Remove; we now use pselect.
865 (Fprocess_attributes): Now generates ns-resolution time stamps.
866
867 * sysdep.c: Include utimens.h. Don't include utime.h
868 or worry about struct utimbuf; gnulib does that for us now.
869 (gettimeofday): Remove; gnulib provides a substitute.
870 (make_timeval): New function.
871 (set_file_times): Now sets ns-resolution time stamps.
872 New arg FD; all uses changed.
873 (time_from_jiffies, ltime_from_jiffies, get_up_time)
874 (system_process_attributes):
875 Now returns ns-resolution time stamp. All uses changed.
876 Check for time stamp overflow.
877
878 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
879 provides a substitute now.
880
881 * systime.h: Include timespec.h rather than sys/time.h and time.h,
882 since it guarantees struct timespec.
883 (EMACS_TIME): Now struct timespec, so that we can support
884 ns-resolution time stamps.
885 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
886 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
887 (EMACS_USECS): Remove.
888 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
889 so multiply the arg by 1000 before storing it.
890 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
891 New macros.
892 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
893 Port to ns-resolution time stamps.
894 (EMACS_TIME_NEG_P): Remove; replaced by....
895 (EMACS_TIME_SIGN): New macro.
896 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
897 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
898 (set_file_times, make_time, lisp_time_argument): Adjust signature.
899 (make_timeval, make_lisp_time, decode_time_components): New decls.
900 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
901 that it mishandled time_t overflow. You can't compare by subtracting!
902 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
903 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
904
905 * term.c: Include <sys/time.h>.
906 (timeval_to_Time): New function, for proper overflow wraparound.
907 (term_mouse_position, term_mouse_click): Use it.
908
909 * undo.c (record_first_change): Support higher-resolution time stamps
910 in the undo buffer.
911 (Fprimitive_undo): Use them when restoring time stamps.
912
913 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
914 (w32_get_internal_run_time):
915 Port to higher-resolution Emacs time stamps.
916 (ltime): Now accepts single 64-bit integer, as that's more convenient
917 for callers.
918
919 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
920
921 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
922 for compatibility with pselect. Support ns-resolution time stamps.
923
924 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
925
926 * xselect.c (wait_for_property_change, x_get_foreign_selection):
927 Check for time stamp overflow, and support ns-resolution time stamps.
928
929 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
930 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
931 (timeval_subtract): Remove; no longer needed.
932 (XTflash, XTring_bell, x_wait_for_event):
933 Port to ns-resolution time stamps. Don't assume time_t is signed.
934
b6a92dfe
CY
9352012-06-22 Chong Yidong <cyd@gnu.org>
936
937 * xdisp.c (x_consider_frame_title): Revert last change.
938
d251c37c
EZ
9392012-06-22 Eli Zaretskii <eliz@gnu.org>
940
941 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
942 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
943 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
944 staticidx goes up to 1597 out of 1600 = 0x640.)
945
f10deafb
PE
9462012-06-20 Paul Eggert <eggert@cs.ucla.edu>
947
948 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
949 Otherwise, the umask might be mistakenly 0 while handling input signals.
950
ec6de1e2
SM
9512012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
952
953 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
954
28be1ada
DA
9552012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
956
957 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
958 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
959 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
960 access to `contents' member of Lisp_Vector objects with AREF and ASET
961 where appropriate.
962
c6bf3022
CY
9632012-06-19 Chong Yidong <cyd@gnu.org>
964
965 * frame.c (delete_frame): When selecting a frame on a different
966 text terminal, do not alter the terminal's top-frame.
967
968 * xdisp.c (format_mode_line_unwind_data): Record the target
969 frame's selected window and its terminal's top-frame.
970 (unwind_format_mode_line): Restore them.
971 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
972 Callers changed.
973 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
974 since tty frames can be explicitly named.
975 (prepare_menu_bars): Likewise.
976
977 * term.c (Ftty_top_frame): New function.
978
defd4196
PE
9792012-06-18 Paul Eggert <eggert@cs.ucla.edu>
980
981 Port byte-code-meter to modern targets.
982 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
983 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 984 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
985 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
986 (METER_1, METER_2): Simplify.
987
1053a871
SM
9882012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
989
990 * data.c (Fdefalias): Return `symbol' (bug#11686).
991
b7e8d081
MR
9922012-06-18 Martin Rudalics <rudalics@gmx.at>
993
994 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
995 gets killed during executing of this function (Bug#11665).
996 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
997 (Vkill_buffer_query_functions): In doc-string say that functions
998 run by this hook should not change the current buffer.
999
7ea2b339
PE
10002012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1001
1002 Fix recently-introduced process.c problems found by static checking.
1003 * process.c (write_queue_push, write_queue_pop, send_process):
1004 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1005 (write_queue_pop): Fix pointer signedness problem.
1006 (send_process): Remove unused local.
1007
96a313a1
CY
10082012-06-17 Chong Yidong <cyd@gnu.org>
1009
1010 * xdisp.c (redisplay_internal): No need to redisplay terminal
1011 frames that are not on top.
1012
20ca2e94
TN
10132012-06-17 Troels Nielsen <bn.troels@gmail.com>
1014
1015 * process.c (make_process): Initialize write_queue.
1016 (write_queue_push, write_queue_pop): New functions.
1017 (send_process): Use them to maintain correct ordering of process
1018 writes (Bug#10815).
1019
9a900ca9
PE
10202012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1021
310fbfa8
PE
1022 * lisp.h (eassert): Assume C89 or later.
1023 This removes the need for CHECK.
1024 (CHECK): Remove. Its comments about always evaluating its
1025 argument were confusing, as 'eassert' typically does not evaluate
1026 its argument.
1027
27bb1ca4
PE
1028 * coding.c (produce_chars): Use ptrdiff_t, not int.
1029
9a900ca9
PE
1030 * xterm.c (x_draw_underwave): Check for integer overflow.
1031 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1032
41b7f8bc 10332012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1034
1035 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1036 referenced (Bug#11583).
1037
9b0e3eba
AA
10382012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1039
1040 Implement wave-style variant of underlining.
1041 * dispextern.h (face_underline_type): New enum.
1042 (face): Add field for underline type.
1043 * nsterm.m (ns_draw_underwave): New function.
1044 (ns_draw_text_decoration): Use it.
1045 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1046 New functions.
1047 (x_draw_glyph_string): Use them.
1048 * xfaces.c (Qline, Qwave): New Lisp objects.
1049 (check_lface_attrs, merge_face_ref)
1053a871
SM
1050 (Finternal_set_lisp_face_attribute, realize_x_face):
1051 Handle wave-style underline face attributes.
9b0e3eba
AA
1052 * xterm.c (x_draw_underwave): New function.
1053 (x_draw_glyph_string): Use it.
1054
0fb52f11
JB
10552012-06-16 Juanma Barranquero <lekktu@gmail.com>
1056
1057 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1058 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1059 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1060 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1061 ($(BLD)/w32select.$(O)): Update dependencies.
1062
e5560ff7
AS
10632012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1064
1065 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1066 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1067 * character.c (_fetch_multibyte_char_p): Remove.
1068 * alloc.c: Include "character.h" before "buffer.h".
1069 * bidi.c: Likewise.
1070 * buffer.c: Likewise.
1071 * bytecode.c: Likewise.
1072 * callint.c: Likewise.
1073 * callproc.c: Likewise.
1074 * casefiddle.c: Likewise.
1075 * casetab.c: Likewise.
1076 * category.c: Likewise.
1077 * cmds.c: Likewise.
1078 * coding.c: Likewise.
1079 * composite.c: Likewise.
1080 * dired.c: Likewise.
1081 * dispnew.c: Likewise.
1082 * doc.c: Likewise.
1083 * dosfns.c: Likewise.
1084 * editfns.c: Likewise.
1085 * emacs.c: Likewise.
1086 * fileio.c: Likewise.
1087 * filelock.c: Likewise.
1088 * font.c: Likewise.
1089 * fontset.c: Likewise.
1090 * fringe.c: Likewise.
1091 * indent.c: Likewise.
1092 * insdel.c: Likewise.
1093 * intervals.c: Likewise.
1094 * keyboard.c: Likewise.
1095 * keymap.c: Likewise.
1096 * lread.c: Likewise.
1097 * macros.c: Likewise.
1098 * marker.c: Likewise.
1099 * minibuf.c: Likewise.
1100 * nsfns.m: Likewise.
1101 * nsmenu.m: Likewise.
1102 * print.c: Likewise.
1103 * process.c: Likewise.
1104 * regex.c: Likewise.
1105 * region-cache.c: Likewise.
1106 * search.c: Likewise.
1107 * syntax.c: Likewise.
1108 * term.c: Likewise.
1109 * textprop.c: Likewise.
1110 * undo.c: Likewise.
1111 * unexsol.c: Likewise.
1112 * w16select.c: Likewise.
1113 * w32fns.c: Likewise.
1114 * w32menu.c: Likewise.
1115 * window.c: Likewise.
1116 * xdisp.c: Likewise.
1117 * xfns.c: Likewise.
1118 * xmenu.c: Likewise.
1119 * xml.c: Likewise.
1120 * xselect.c: Likewise.
1121
2f07e6af
EZ
11222012-06-16 Eli Zaretskii <eliz@gnu.org>
1123
1053a871
SM
1124 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1125 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1126 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1127 row.
1128 (handle_face_prop): Use chunk-relative overlay string index when
1129 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1130 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1131 the rightmost. (Bug#11720)
2f07e6af 1132
29b83cec
AS
11332012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1134
1135 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1136 (CATEGORY_MEMBER): Enforce 1/0 value.
1137 * category.c (_temp_category_set): Remove.
1138
4c5501e9
EZ
11392012-06-16 Eli Zaretskii <eliz@gnu.org>
1140
1141 * window.c (Fdelete_other_windows_internal)
1142 (Fdelete_window_internal): Don't access frame's mouse highlight
1143 info of the initial frame. (Bug#11677)
1144
2b570124
PE
11452012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1146
e93864f9
PE
1147 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1148 Assume USE_2_TAGS_FOR_INTS.
1149 (xreload): Adjust $tagmask width to match recent lisp.h change.
1150
2b570124
PE
1151 Simplify lisp.h in minor ways that should not affect code.
1152 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1153 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1154 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1155 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1156 (INTTYPEBITS): New macro, for clarity.
1157 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1158 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1159 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1160 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1161 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1162
81755f69
JB
11632012-06-13 Juanma Barranquero <lekktu@gmail.com>
1164
1165 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1166
16192a57
GM
11672012-06-13 Glenn Morris <rgm@gnu.org>
1168
1169 * s/bsd-common.h (BSD4_3):
1170 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1171
646b5f55
AS
11722012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1173
1174 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1175 instead of union.
1176 (XLI, XIL): Define.
1053a871
SM
1177 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1178 Use them.
1179 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1180 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1181 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1182 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1183 * frame.c (delete_frame): Remove outdated comment.
1184 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1185 USE_LISP_UNION_TYPE.
1186 (Fw32_unregister_hot_key): Likewise.
1187 (Fw32_toggle_lock_key): Likewise.
1188 * w32menu.c (add_menu_item): Likewise.
1189 (w32_menu_display_help): Use XIL instead of checking
1190 USE_LISP_UNION_TYPE.
1191 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1192 (init_heap): Likewise.
1193 * w32term.c (w32_read_socket): Update comment.
1194
1d3823c9
GM
11952012-06-13 Glenn Morris <rgm@gnu.org>
1196
c62ff706
GM
1197 * s/usg5-4-common.h, src/s/unixware.h:
1198 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1199
1d3823c9
GM
1200 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1201
bfe3e0a2
PE
12022012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1205 * alloc.c (make_number) [!defined make_number]:
1206 Remove, as lisp.h always defines this now.
1207 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1208 (roundup_size): Verify that it is a power of 2.
1209 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1210 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1211 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1212 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1213 USE_LSB_TAG now is always defined to be either 0 or 1.
1214 All uses changed.
1215 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1216 code works fine either way, and efficiency is not a concern here,
1217 as the union type is for debugging, not for production.
1218 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1219 Use an inline function on all platforms when using the union type,
1220 since this is simpler and 'static inline' can be used portably
1221 within Emacs now.
1222 (LISP_INITIALLY_ZERO): New macro.
1223 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1224 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1225
45fa9c0f
GM
12262012-06-12 Glenn Morris <rgm@gnu.org>
1227
b4492cba
GM
1228 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1229
1230 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1231
45fa9c0f
GM
1232 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1233 Move BROKEN_SIGIO to configure.
1234
1235 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1236 Move NO_TERMIO to configure.
1237
0e25d334
CY
12382012-06-12 Chong Yidong <cyd@gnu.org>
1239
1240 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1241 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1242 MagickExportImagePixels is undefined.
1243
43682bb6
PE
12442012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * image.c (imagemagick_load_image): Remove unused label.
1247
a9be7d2b
GM
12482012-06-11 Glenn Morris <rgm@gnu.org>
1249
1250 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1251 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1252 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1253 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1254
3017f87f
SM
12552012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1256
1257 * alloc.c (make_byte_code): New function.
1258 (Fmake_byte_code): Use it. Don't purify here.
1259 * lread.c (read1): Use it as well to avoid extra allocation.
1260
1b9b4cf4
CY
12612012-06-11 Chong Yidong <cyd@gnu.org>
1262
1263 * image.c (imagemagick_load_image): Implement transparency.
1264
95988fcf
AS
12652012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1266
1267 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1268 account for preceding backslashes. (Bug#11663)
1269
cd4eb164
CY
12702012-06-09 Chong Yidong <cyd@gnu.org>
1271
1272 * term.c: Support italics in capable terminals (Bug#9652).
1273 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1274 (turn_on_face): Output using TS_enter_italic_mode if available.
1275 Don't handle unused blinking and alt-charset cases.
1276 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1277 and tty_alt_charset_p cases.
1278 (tty_capable_p, init_tty): Support italics.
1279
1280 * termchar.h (struct tty_display_info): Add field for italics.
1281 Remove unused blink field.
1282
1283 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1284 Handle slant.
1285
1286 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1287 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1288 tty_alt_charset_p. Add tty_italic_p.
1289
ff88beb8
MA
12902012-06-09 Michael Albinus <michael.albinus@gmx.de>
1291
1292 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1293 dbus_type_is_basic if available.
1294 (xd_extract_signed, xd_extract_unsigned): Rename from
1295 extract_signed and extract_unsigned, respectively. Adapt callers.
1296
44286096
CY
12972012-06-09 Chong Yidong <cyd@gnu.org>
1298
1682701f
CY
1299 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1300
44286096
CY
1301 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1302 case (Bug#9752).
1303
d86feb17
PE
13042012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 * xdisp.c (vmessage): Treat frame message as multibyte.
1307 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1308 would generate the diagnostic "Making \302\247 buffer-local while
1309 let-bound!".
1310
d5c20fe8
EZ
13112012-06-08 Eli Zaretskii <eliz@gnu.org>
1312
1313 * dispnew.c (showing_window_margins_p): Undo last change, which
1314 was done due to an inadvertent commit.
1315 (adjust_frame_glyphs_for_frame_redisplay): Do call
1316 showing_window_margins_p.
1317
513749ee
SM
13182012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1319
1320 * eval.c (Fmake_var_non_special): New primitive.
1321 (syms_of_eval): Defsubr it.
1322 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1323
d4a8f5c1
JB
13242012-06-08 Juanma Barranquero <lekktu@gmail.com>
1325
1326 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1327 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1328
8bbbc977
EZ
13292012-06-08 Eli Zaretskii <eliz@gnu.org>
1330
1331 * alloc.c (allocate_vectorlike): Fix last change.
1332
f3372c87
DA
13332012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1334
1335 Block-based vector allocation of small vectors.
1336 * lisp.h (struct vectorlike_header): New field `nbytes',
1337 adjust comment accordingly.
1338 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1339 to denote vector blocks. Adjust users (live_vector_p,
1340 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1341 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1342 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1343 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1344 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1345 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1346 (roundup_size): New constant.
1347 (struct vector_block): New data type.
1348 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1349 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1350 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1351 (sweep_vectors): New functions.
1352 (allocate_vectorlike): Return `zero_vector' as the only vector of
1353 0 items. Allocate new vector from block if vector size is less than
1354 or equal to VBLOCK_BYTES_MAX.
1355 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1356 (init_alloc_once): Add call to init_vectors.
1357
4f18a4ed
SM
13582012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1359
1360 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1361
86f158bc
PE
13622012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * doprnt.c (doprnt): Truncate multibyte char correctly.
1365 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1366 would mishandle a string argument "Xc" if X was a multibyte
1367 character of length 2: it would truncate after X's first byte
1368 rather than including all of X.
1369
c5cfcbe0
CY
13702012-06-06 Chong Yidong <cyd@gnu.org>
1371
1372 * buffer.c (word_wrap): Doc fix.
1373
c05cf390
PE
13742012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1377
0c3461de
GM
13782012-06-03 Glenn Morris <rgm@gnu.org>
1379
1380 * xdisp.c (tool-bar-style): Doc fix.
1381
c71232db
UM
13822012-06-03 Ulrich Müller <ulm@gentoo.org>
1383
1384 * Makefile.in (PAXCTL): Define.
1385 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1386 binary via PaX flags if the paxctl utility is available.
1387 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1388 Restore PaX flags to their default. (Bug#11398)
1389
383f7350
CY
13902012-06-03 Chong Yidong <cyd@gnu.org>
1391
1392 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1393 buffer (Bug#11226).
1394
5f2c76c6
CY
13952012-06-03 Chong Yidong <cyd@gnu.org>
1396
1397 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1398 (note_mode_line_or_margin_highlight): If there is no help echo,
1399 use mode-line-default-help-echo. Handle the case where the mouse
1400 position is past the end of the mode line string.
1401
1402 * buffer.c (buffer_local_value_1): New function, split from
1403 Fbuffer_local_value; can return Qunbound.
1404 (Fbuffer_local_value): Use it.
1405 (Vmode_line_format): Docstring tweaks.
1406
773d47f6
PE
14072012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1408
1409 * sysdep.c (system_process_attributes): Improve comment.
1410
f2d6a3df
SM
14112012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1412
1413 * keyboard.c: Export real-this-command to Elisp.
1414 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1415 and DEFVAR it. Update all users.
1416
63810350
PE
14172012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1418
7bd5c1f4
PE
1419 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1420
63810350
PE
1421 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1422 Convert pctcpu and pctmem to Lisp float properly.
1423 Let the compiler fold better, as 100.0/0x8000 is exact.
1424
a2821611
AS
14252012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1426
1427 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1428 cons_block.
1429
5fceba1d
PE
14302012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1433
c98ff5dd
DA
14342012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 For a 'struct window', replace some Lisp_Object fields to
1437 bitfields where appropriate, remove unused fields.
1438 * window.h (struct window): Remove unused 'last_mark_x' and
1439 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1440 change it's type from Lisp_Object to bitfield.
1441 Change type of 'force_start', 'optional_new_start',
1442 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1443 fields from Lisp_Object to bitfield. Adjust users accordingly.
1444
ca34e0be
PE
14452012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 Pacify gcc -Wdouble-precision when using Xaw.
1448 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1449 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1450 Use 'float' consistently, rather than 'float' in most places
1451 and 'double' in a couple of places.
1452
efc00ab1 14532012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1454
1455 * xdisp.c (handle_stop): Detect whether we have overlay strings
1456 loaded by testing it->current.overlay_string_index to be
1457 non-negative, instead of checking whether n_overlay_strings is
1458 positive. (Bug#11587)
1459
efc00ab1 14602012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1461
1462 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1463
1464 * doc.c (Fsubstitute_command_keys): Doc fix.
1465
efc00ab1 14662012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1467
1468 * search.c (search_buffer): Remove calls to
1469 r_alloc_inhibit_buffer_relocation, as it is now called by
1470 maybe_unify_char, which was the cause of relocation of buffer text
1471 in bug#11519.
1472
efc00ab1 14732012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1474
1475 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1476 for the duration of call to load_charset, to avoid problems with
1477 callers of maybe_unify_char that access buffer text through C
1478 pointers.
1479
1480 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1481 decrement the inhibition flag, instead of just setting or
1482 resetting it.
1483
ba93a187
PE
14842012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1485
1486 Remove obsolete '#define static' cruft.
1487 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1488 This #undef was "temporary" in 2000; it is no longer needed
1489 now that '#define static' has gone away.
1490 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1491 (gray_bitmap_bits): Remove; no longer needed.
1492 All uses replaced with definiens.
1493 * xterm.c: Include "bitmaps/gray.xbm".
1494
9e4bf381
PE
14952012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1496
1497 Clean up __executable_start, monstartup when --enable-profiling.
1498 The following changes affect the code only when profiling.
1499 * dispnew.c (__executable_start): Rename from safe_bcopy.
1500 Define only on platforms that need it.
1501 * emacs.c: Include <sys/gmon.h> when profiling.
1502 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1503 (__executable_start): Remove decl, since lisp.h does it now.
1504 (safe_bcopy): Remove decl; no longer has that name.
1505 (main): Coalesce #if into single bit of code, for simplicity.
1506 Cast pointers to uintptr_t, since standard libraries want integers
1507 and not pointers.
1508 * lisp.h (__executable_start): New decl.
1509
32d72c2f
GM
15102012-05-31 Glenn Morris <rgm@gnu.org>
1511
1512 * image.c (Fimagemagick_types): Doc fix.
1513
baac5bc7
JM
15142012-05-30 Jim Meyering <meyering@redhat.com>
1515
1516 * callproc.c (Fcall_process_region): Include directory component
1517 in mkstemp error message (Bug#11586).
1518
72cb32cf
PE
15192012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1520
1521 * alloc.c, lisp.h (make_pure_vector): Now static.
1522
61b108cc
SM
15232012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1524
1525 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1526 Move to byte-run.el.
1527 (Fautoload): Do the hash-doc more carefully.
1528 * data.c (Fdefalias): Purify definition, except for keymaps.
1529 (Qdefun): Move from eval.c.
1530 * lisp.h (Qdefun): Remove.
1531 * lread.c (read1): Tiny simplification.
1532
471fe23d
TN
15332012-05-29 Troels Nielsen <bn.troels@gmail.com>
1534
934f3f58 1535 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1536 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1537 Bug#9642, but explicitly check that the buffer the overlay would
1538 be moved to is live and rearrange lines to make sure that errors
1539 will not put the overlay in an inconsistent state.
1540 (Fdelete_overlay): Cosmetics.
1541
85d0efd1
EZ
15422012-05-28 Eli Zaretskii <eliz@gnu.org>
1543
1544 * w32term.c (my_bring_window_to_top): New function.
1545 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1546 could be different from the original one.
1547 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1548 (Bug#11513)
1549
1550 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1551 by calling BringWindowToTop.
1552
1553 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1554 (WM_EMACS_END): Increase by one.
1555
da92a98c
PE
15562012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1559 This avoids undefined behavior that might cause the eassert
1560 to not catch an out-of-range value.
1561
74d1f848
JB
15622012-05-28 Juanma Barranquero <lekktu@gmail.com>
1563
1564 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1565 Update dependencies.
1566
9e1a06fc
EZ
15672012-05-27 Eli Zaretskii <eliz@gnu.org>
1568
1569 * bidi.c (bidi_mirror_char): Fix last change.
1570
f3dd7312
AS
15712012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1572
1573 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1574 when referring to sectname field in printf format.
1575
81899c91
PE
15762012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1577
57b81a9f
PE
1578 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1579 Only r_alloc_inhibit_buffer_relocation needed to be added;
1580 the others were already declared.
1581
81899c91
PE
1582 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1583 before checking whether it's out of range. Put the check inside
1584 eassert. See
1585 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1586
33017faf 15872012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1588
1589 * callproc.c (Fcall_process): Restore a line that was accidentally
1590 commented out in the 2011-02-13 change (bug#11547).
1591
33017faf 15922012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1593
1594 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1595 defined on ralloc.c.
1596
1597 * buffer.c [REL_ALLOC]: Remove prototypes of
1598 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1599 they are now on lisp.h.
1600
1601 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1602
1603 * search.c (search_buffer): Use it to inhibit relocation of buffer
1604 text while re_search_2 is doing its job, because re_search_2 is
1605 passed C pointers to buffer text. (Bug#11519)
1606
23415acf
EZ
1607 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1608 Update value to 24.
1609
44e27368
EZ
1610 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1611 state after an additional call to move_it_in_display_line_to, keep
1612 the values of it->max_ascent and it->max_descent found for the
1613 entire line.
1614 (pos_visible_p): Revert the comparison against bottom_y to what it
1615 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1616 (Bug#11464)
1617
c1892f11
PE
16182012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Fix coding-related core dumps with gcc -ftrapv.
1621 The code was computing A - B, where A and B are pointers, and B is
1622 random garbage. This can lead to core dumps on platforms that
1623 have special pointer registers, and it also leads to core dumps on
1624 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1625 A - B only when B is initialized properly.
1626 * coding.c (coding_set_source, coding_set_destination): Return void.
1627 (coding_change_source, coding_change_destinations): New functions,
1628 with the old behaviors of coding_set_source and coding_set_destination.
1629 All callers that need an offset changed to use these new functions.
1630
eb7afdad
GM
16312012-05-26 Glenn Morris <rgm@gnu.org>
1632
1633 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1634
f12fdf02
EZ
16352012-05-26 Eli Zaretskii <eliz@gnu.org>
1636
53a63be6 1637 Extend mouse support on W32 text-mode console.
61b108cc
SM
1638 * xdisp.c (draw_row_with_mouse_face):
1639 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1640
eb3f6f01 1641 * w32console.c: Include window.h.
61b108cc
SM
1642 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1643 New functions.
eb3f6f01
EZ
1644 (initialize_w32_display): Initialize mouse-highlight data.
1645
53a63be6
EZ
1646 * w32inevt.c: Include termchar.h and window.h.
1647 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1648 moves, call note_mouse_highlight. If help_echo changed, call
1649 gen_help_event to produce help-echo message in the echo area.
1650 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1651 highlight info.
1652
4cfd81f6
PE
16532012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * lread.c (read1): Simplify slightly to avoid an overflow warning
1656 with GCC 4.7.0 on x86-64.
1657
4446092a
EZ
16582012-05-26 Eli Zaretskii <eliz@gnu.org>
1659
1660 * bidi.c (bidi_mirror_char): Revert last change: an int is
1661 definitely wide enough here.
1662
42b2a986 16632012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1664
42b2a986 1665 Fix integer width and related bugs (Bug#9874).
eb106a49 1666 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1667 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1668 (string_bytes, check_sblock, allocate_string_data):
1669 (compact_small_strings, Fmake_bool_vector, make_string)
1670 (make_unibyte_string, make_multibyte_string)
1671 (make_string_from_bytes, make_specified_string)
1672 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1673 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1674 (mark_vectorlike):
1675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1676 (allocate_pseudovector):
1677 Use int, not EMACS_INT, where int is wide enough.
1678 (inhibit_garbage_collection, Fgarbage_collect):
1679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1680 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1681 int might not be wide enough.
1682 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1683 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1684 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1685 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1686 (bidi_level_of_next_char, bidi_move_to_visually_next):
1687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1688 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1689 (Fkill_buffer, Fset_buffer_major_mode)
1690 (advance_to_char_boundary, Fbuffer_swap_text)
1691 (Fset_buffer_multibyte, overlays_at, overlays_in)
1692 (overlay_touches_p, struct sortvec, record_overlay_string)
1693 (overlay_strings, recenter_overlay_lists)
1694 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1695 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1696 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1697 (Foverlay_recenter, last_overlay_modification_hooks_used)
1698 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1700 (validate_region): Omit unnecessary test for b <= e,
1701 since that's guaranteed by the previous test.
d311d28c
PE
1702 (adjust_overlays_for_delete): Avoid pos + length overflow.
1703 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1704 (report_overlay_modification):
1705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1706 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1707 Omit pointer cast, which isn't needed anyway, and doesn't work
1708 after the EMACS_INT -> ptrdiff_t change.
02481186 1709 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1710 * buffer.h: Adjust decls to match defn changes elsewhere.
1711 (struct buffer_text, struct buffer):
1712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1713 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1714 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1715 not int, to avoid needless 32-bit limit on 64-bit hosts.
1716 (exec_byte_code): Use tighter memory-full test, one that checks
1717 for alloca overflow. Don't compute the address of the object just
1718 before an array, as that's not portable. Use EMACS_INT, not
1719 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1720 * callint.c (Fcall_interactively):
1721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1722 * callproc.c (call_process_kill, Fcall_process):
1723 Don't assume pid_t fits into an Emacs fixnum.
1724 (call_process_cleanup, Fcall_process, child_setup):
1725 Don't assume pid_t fits into int.
1726 (call_process_cleanup, Fcall_process, delete_temp_file)
1727 (Fcall_process_region):
1728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1729 (Fcall_process): Simplify handling of volatile integers.
1730 Use int, not EMACS_INT, where int will do.
1731 * casefiddle.c (casify_object, casify_region, operate_on_word)
1732 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 (casify_object): Avoid integer overflow when overallocating buffer.
1735 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1736 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1737 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1738 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1739 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1740 integers are now checked earlier. All uses replaced with XINT.
1741 (ccl_driver):
1742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1743 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1744 (ccl_driver, Fregister_code_conversion_map):
1745 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1746 (resolve_symbol_ccl_program): Check that vector header is in range.
1747 Always copy the vector, so that we can check its contents reliably
1748 now rather than having to recheck each instruction as it's being
1749 executed. Check that vector words fit in 'int'.
1750 (ccl_get_compiled_code, Fregister_ccl_program)
1751 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1752 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1753 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1754 contents are in range.
1755 (Fccl_execute_on_string): Check that status is in range.
1756 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1757 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1758 Accept and return EMACS_INT, not int, because callers can pass values
1759 out of 'int' range.
1760 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1761 (multibyte_chars_in_text, parse_str_as_multibyte)
1762 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1763 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1764 (string_escape_byte8, Fget_byte):
1765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1766 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1767 avoid mishandling large integers.
1768 * character.h: Adjust decls to match defn changes elsewhere.
1769 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1770 (Ffind_charset_region):
1771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1772 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1773 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1774 Don't assume fixnum fits in int.
d311d28c
PE
1775 (load_charset_map_from_vector, Fmap_charset_chars):
1776 Remove now-unnecessary CHECK_NATNUMs.
1777 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1778 Don't rely on undefined behavior with signed left shift overflow.
1779 Don't assume unsigned int fits into fixnum, or that fixnum fits
1780 into unsigned int. Don't require max_code to be a valid fixnum;
1781 that's not true for gb10830 4-byte on a 32-bit host. Allow
1782 invalid_code to be a cons, for the same reason. Require code_offset
1783 to be a character. Avoid int overflow if max_char is close
1784 to INT_MAX.
1785 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1786 this is intended anyway and avoids some undefined behavior.
1787 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1788 INDEX_TO_CODE_POINT, as that's what it expects.
1789 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1790 * charset.h (DECODE_CHAR): Return int, not unsigned;
1791 this is what was intended anyway, and it avoids undefined behavior.
1792 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1793 integer-overflow issues.
1794 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1795 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1796 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1797 * chartab.c (Fmake_char_table, Fset_char_table_range)
1798 (uniprop_get_decoder, uniprop_get_encoder):
1799 Don't assume fixnum fits in int.
1800 * cmds.c (move_point): New function, that does the gist of
1801 Fforward_char and Fbackward_char, but does so while checking
1802 for integer overflow more accurately.
c96e5d6a 1803 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1804 (Fforward_line, Fend_of_line, internal_self_insert)
1805 (internal_self_insert):
1806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1807 Fix a FIXME, by checking for integer overflow when calculating
1808 target_clm and actual_clm.
1809 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1810 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1811 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1812 (coding_alloc_by_making_gap, alloc_destination)
1813 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1814 (encode_coding_utf_16, detect_coding_emacs_mule)
1815 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1816 (detect_coding_iso_2022, decode_coding_iso_2022)
1817 (encode_invocation_designation, encode_designation_at_bol)
1818 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1819 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1820 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1821 (encode_coding_ccl, encode_coding_raw_text)
1822 (detect_coding_charset, decode_coding_charset)
1823 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1824 (produce_composition, produce_charset, produce_annotation)
1825 (decode_coding, handle_composition_annotation)
1826 (handle_charset_annotation, consume_chars, decode_coding_gap)
1827 (decode_coding_object, encode_coding_object, detect_coding_system)
1828 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1829 (code_convert_region, code_convert_string)
8f50130c
PE
1830 (Fdefine_coding_system_internal)
1831 (coding_set_source, coding_set_destination):
d311d28c
PE
1832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1833 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1834 (Fdefine_coding_system_internal):
1835 Don't assume fixnums fit in int.
1836 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1837 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1838 (Funencodable_char_position, Fcheck_coding_systems_region)
1839 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1841 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1842 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1843 Don't access memory outside of the args array.
d311d28c 1844 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1845 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1846 result of ENCODE_CHAR.
d311d28c
PE
1847 * coding.h: Adjust decls to match defn changes elsewhere.
1848 (struct coding_system):
1849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1850 * composite.c (get_composition_id, find_composition)
1851 (run_composition_function, update_compositions)
1852 (compose_text, composition_gstring_put_cache)
1853 (composition_gstring_p, composition_gstring_width)
1854 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1855 (composition_compute_stop_pos, composition_reseat_it)
1856 (composition_update_it, struct position_record)
1857 (find_automatic_composition, composition_adjust_point)
1858 (Fcomposition_get_gstring, Ffind_composition_internal):
1859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1860 (update_compositions):
1861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1862 * composite.h: Adjust decls to match defn changes elsewhere.
1863 (struct composition):
1864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1865 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1866 Do not attempt to compute the address of the object just before a
1867 buffer; this is not portable.
1868 (Faref, Faset):
1869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1870 (Faset): Use int, not EMACS_INT, where int is wide enough.
1871 (Fstring_to_number): Don't assume fixnums fit in int.
1872 (Frem): Don't assume arg is nonnegative.
1873 * dbusbind.c (xd_append_arg): Check for integers out of range.
1874 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1875 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1876 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1877 (xd_get_connection_references): Return ptrdiff_t, not int.
1878 All uses changed.
1879 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1880 (xd_read_message_1):
1881 Use int, not unsigned, where the dbus API uses int.
1882 (Fdbus_message_internal): Don't overflow mtype.
1883 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1884 * dired.c (directory_files_internal, file_name_completion, scmp)
1885 (file_name_completion_stat):
1886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1887 (file_name_completion): Don't overflow matchcount.
1888 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1889 * dispextern.h: Adjust decls to match defn changes elsewhere.
1890 (struct text_pos, struct glyph, struct bidi_saved_info)
1891 (struct bidi_string_data, struct bidi_it, struct composition_it)
1892 (struct it):
1893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1894 (struct display_pos, struct composition_it, struct it):
1895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1896 * dispnew.c (increment_matrix_positions)
1897 (increment_row_positions, mode_line_string)
1898 (marginal_area_string):
1899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1900 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1902 (duration_to_sec_usec): New function, to check for overflow better.
1903 (Fsleep_for, sit_for): Use it.
1904 * doc.c (get_doc_string, store_function_docstring):
1905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1906 (get_doc_string, Fsnarf_documentation):
1907 Use int, not EMACS_INT, where int is wide enough.
1908 (get_doc_string):
1909 Use SAFE_ALLOCA, not alloca.
1910 Check for overflow when converting EMACS_INT to off_t.
1911 * doprnt.c (doprnt):
1912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1913 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1914 Don't assume uid_t fits into fixnum.
1915 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1916 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1917 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1918 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1919 (general_insert_function)
1920 (Finsert_char, make_buffer_string, make_buffer_string_both)
1921 (update_buffer_properties, Fbuffer_substring)
1922 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1923 (Fsubst_char_in_region, check_translation)
1924 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1925 (transpose_markers, Ftranspose_regions):
1926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1927 (clip_to_bounds): Move to lisp.h as an inline function).
1928 (Fconstrain_to_field): Don't assume integers are nonnegative.
1929 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1930 (Fsubst_char_in_region, Fsave_restriction):
1931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1932 (Femacs_pid): Don't assume pid_t fits into fixnum.
1933 (lo_time): Use int, not EMACS_INT, when int suffices.
1934 (lisp_time_argument): Check for usec out of range.
1935 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1936 (Fuser_login_name, Fuser_full_name): Signal an error
1937 if a uid argument is out of range, rather than relying on
1938 undefined behavior.
c8d5c857
PE
1939 (Fformat_time_string): Remove now-unnecessary check.
1940 lisp_time_argument checks for out-of-range usec now.
243e0530 1941 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1942 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1943 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1944 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1945 (init_cmdargs, Fdump_emacs):
1946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1947 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1948 the bottom (typically) 32 bits of the fixnum.
1949 * eval.c (specpdl_size, call_debugger):
1950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1951 (when_entered_debugger, Fbacktrace_debug):
1952 Don't assume fixnum can fit in int.
1953 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1954 the object just before a buffer; this is not portable.
1955 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1956 (grow_specpdl, unbind_to):
1957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1958 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1959 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1960 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1961 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1962 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1964 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1965 (a_write, e_write):
1966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1967 (Fcopy_file, non_regular_nbytes, read_non_regular)
1968 (Finsert_file_contents):
1969 Use int, not EMACS_INT, where int is wide enough.
1970 (READ_BUF_SIZE): Verify that it fits in int.
1971 (Finsert_file_contents): Check that counts are in proper range,
1972 rather than assuming fixnums fit into ptrdiff_t etc.
1973 Don't assume fixnums fit into int.
125b3835 1974 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1975 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1976 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1977 (string_char_to_byte, string_byte_to_char)
1978 (string_make_multibyte, string_to_multibyte)
1979 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1980 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1981 (substring_both, Fdelete, internal_equal, Ffillarray)
1982 (Fclear_string, mapcar1)
1983 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1984 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1985 (larger_vector, make_hash_table, maybe_resize_hash_table)
1986 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1987 (Fmaphash, secure_hash):
1988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1989 (concat): Check for string index and length overflow.
1990 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1991 (Frequire):
1992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1993 (larger_vector): New API (vec, incr_min, size_max) replaces old
1994 one (vec, new_size, init). This catches size overflow.
1995 INIT was removed because it was always Qnil.
1996 All callers changed.
1997 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1998 the upper bound on a hash table index size.
1999 (make_hash_table, maybe_resize_hash_table): Use it.
2000 (secure_hash): Computer start_byte and end_byte only after
2001 they're known to be in ptrdiff_t range.
2002 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2003 (Ffont_get_glyphs, Ffont_at):
2004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2005 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2006 (Flist_fonts, Fopen_font):
2007 Don't assume fixnum can fit in int.
2008 (check_gstring): Don't assume index can fit in int.
2009 (font_match_p): Check that fixnum is a character, not a nonnegative
2010 fixnum, since the later code needs to stuff it into an int.
2011 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2012 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2013 conversion overflow issues.
2014 (Fopen_font): Check for integer out of range.
2015 (Ffont_get_glyphs): Don't assume index can fit in int.
2016 * font.h: Adjust decls to match defn changes elsewhere.
2017 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2018 integer overflow.
2019 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2020 printmax_t, where ptrdiff_t is wide enough.
2021 (Finternal_char_font):
2022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2023 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2024 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2025 (Fset_frame_position, x_set_frame_parameters)
2026 (x_set_line_spacing, x_set_border_width)
2027 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2028 Check that fixnums are in proper range for system types.
2029 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2031 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2032 Use SAFE_ALLOCA_LISP, not alloca.
2033 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2034 intptr_t is wide enough.
2035 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2036 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2037 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2038 Check for fixnum out of range.
2039 * ftfont.c (ftfont_list): Don't assume index fits in int.
2040 Check that fixnums are in proper range for system types.
2041 (ftfont_shape_by_flt):
2042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2043 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2045 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2046 Check that fixnums are in proper range for system types.
2047 * gnutls.h: Adjust decls to match defn changes elsewhere.
2048 * gtkutil.c (xg_dialog_run):
2049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2050 (update_frame_tool_bar):
2051 Check that fixnums are in proper range for system types.
2052 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2053 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2054 * indent.c (last_known_column, last_known_column_point):
2055 (current_column_bol_cache):
2056 (skip_invisible, current_column, check_display_width):
2057 (check_display_width, scan_for_column, current_column_1)
2058 (Findent_to, Fcurrent_indentation, position_indentation)
2059 (indented_beyond_p, Fmove_to_column, compute_motion):
2060 (Fcompute_motion, Fvertical_motion):
2061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2062 (last_known_column_modified): Use EMACS_INT, not int.
2063 (check_display_width):
2064 (Fcompute_motion):
2065 Check that fixnums and floats are in proper range for system types.
2066 (compute_motion): Don't assume index or fixnum fits in int.
2067 (compute_motion, Fcompute_motion):
2068 Use int, not EMACS_INT, when it is wide enough.
2069 (vmotion): Omit local var start_hpos that is always 0; that way
2070 we don't need to worry about overflow in expressions involving it.
2071 * indent.h: Adjust decls to match defn changes elsewhere.
2072 (struct position):
2073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2074 Use int, not EMACS_INT, where int is wide enough.
2075 Remove unused members ovstring_chars_done and tab_offset;
2076 all uses removed.
2077 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2078 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2079 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2080 (make_gap, copy_text, insert, insert_and_inherit)
2081 (insert_before_markers, insert_before_markers_and_inherit)
2082 (insert_1, count_combining_before, count_combining_after)
2083 (insert_1_both, insert_from_string)
2084 (insert_from_string_before_markers, insert_from_string_1)
2085 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2086 (adjust_after_replace, adjust_after_insert, replace_range)
2087 (replace_range_2, del_range, del_range_1, del_range_byte)
2088 (del_range_both, del_range_2, modify_region)
2089 (prepare_to_modify_buffer, signal_before_change)
2090 (signal_after_change, Fcombine_after_change_execute):
2091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2092 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2093 (balance_an_interval, split_interval_right, split_interval_left)
2094 (find_interval, next_interval, update_interval)
2095 (adjust_intervals_for_insertion, delete_node, delete_interval)
2096 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2097 (static_offset_intervals, offset_intervals)
2098 (merge_interval_right, merge_interval_left, make_new_interval)
2099 (graft_intervals_into_buffer, temp_set_point_both)
2100 (temp_set_point, set_point, adjust_for_invis_intang)
2101 (set_point_both, move_if_not_intangible, get_property_and_range)
2102 (get_local_map, copy_intervals, copy_intervals_to_string)
2103 (compare_string_intervals, set_intervals_multibyte_1):
2104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2105 * intervals.h: Adjust decls to match defn changes elsewhere.
2106 (struct interval):
2107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2108 * keyboard.c (this_command_key_count, this_single_command_key_start)
2109 (before_command_key_count, before_command_echo_length, echo_now)
2110 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2111 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2112 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2113 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2115 (last_non_minibuf_size, last_point_position, echo_truncate)
2116 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2117 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2118 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2119 (stuff_buffered_input):
2120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2121 (last_auto_save, command_loop_1, read_char):
2122 Use EMACS_INT, not int, to avoid integer overflow.
2123 (record_char): Avoid overflow in total_keys computation.
2124 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2125 * keyboard.h: Adjust decls to match defn changes elsewhere.
2126 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2127 (Fkey_description, Fdescribe_vector, Flookup_key):
2128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2129 (click_position): New function, to check that positions are in range.
2130 (Fcurrent_active_maps):
2131 (describe_command):
2132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2133 (Faccessible_keymaps, Fkey_description):
2134 (preferred_sequence_p):
2135 Don't assume fixnum can fit into int.
2136 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2137 Check for integer overflow in size calculations.
2138 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2139 avoid mishandling large integers.
2140 * lisp.h: Adjust decls to match defn changes elsewhere.
2141 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2142 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2143 (struct Lisp_Marker):
2144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2145 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2146 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2147 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2148 All callers changed.
2149 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2150 Assume the arg has valid form, since it always does.
2151 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2152 unsigned integer system type.
2153 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2154 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2156 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2157 (duration_to_sec_usec): New decl.
2158 * lread.c (read_from_string_index, read_from_string_index_byte)
2159 (read_from_string_limit, readchar, unreadchar, openp)
2160 (read_internal_start, read1, oblookup):
2161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2162 (Fload, readevalloop, Feval_buffer, Feval_region):
2163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2164 (openp): Check for out-of-range argument to 'access'.
2165 (read1): Use int, not EMACS_INT, where int is wide enough.
2166 Don't assume fixnum fits into int.
6efdadfd 2167 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2168 (read_filtered_event): Use duration_to_sec_usec
2169 to do proper overflow checking on durations.
d311d28c
PE
2170 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2171 in size calculation.
2172 (Fexecute_kbd_macro):
2173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2174 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2175 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2176 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2177 (set_marker_both, set_marker_restricted_both, marker_position)
2178 (marker_byte_position, Fbuffer_has_markers_at):
2179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2180 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2181 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2182 It now merely ensures that the menu is large enough, without
2183 necessarily growing it, as this avoids some integer overflow issues.
2184 All callers changed.
2185 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2187 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2188 Use SAFE_ALLOCA_LISP, not alloca.
2189 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2190 to EMACS_INT. Check that fixnums are in proper range for system types.
2191 * minibuf.c (minibuf_prompt_width, string_to_object)
2192 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2193 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2195 (get_minibuffer, read_minibuf_unwind):
2196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2197 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2198 this simplifies overflow checking. All callers changed.
2199 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2200 (Ftest_completion):
2201 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2202 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2203 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2204 Check that fixnums are in proper range for system types.
2205 (Fx_create_frame, Fx_show_tip):
2206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2207 * nsfont.m (ns_findfonts, nsfont_list_family):
2208 Don't assume fixnum fits in long.
2209 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2211 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2212 wide enough.
17fdb222 2213 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2215 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2216 (PRINTDECLARE, PRINTPREPARE):
2217 (strout, print_string):
2218 (print, print_preprocess, print_check_string_charset_prop)
2219 (print_object):
2220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2221 (PRINTDECLARE):
2222 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2224 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2225 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2226 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2227 (print_error_message): Use SAFE_ALLOCA, not alloca.
2228 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2229 (print_depth, new_backquote_output, print_number_index):
2230 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2231 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2232 (Fset_process_window_size, Fformat_network_address)
2233 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2234 (sigchld_handler):
d311d28c 2235 Check that fixnums are in proper range for system types.
d44287d4 2236 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2237 Check for process-ids out of pid_t range rather than relying on
2238 undefined behavior.
e4d81efc 2239 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2240 (Fformat_network_address, read_process_output, send_process)
2241 (Fprocess_send_region, status_notify):
2242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2243 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2244 (wait_reading_process_output, read_process_output, exec_sentinel):
2245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2246 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2247 (Faccept_process_output): Use duration_to_sec_usec to do proper
2248 overflow checking on durations.
dde14581
PE
2249 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2250 Don't assume pid_t fits in int.
02481186
PE
2251 * process.h (struct Lisp_Process): Members tick and update_tick
2252 are now of type EMACS_INT, not int.
b62b53e8
PE
2253 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2254 configured --with-wide-int.
d311d28c
PE
2255 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2256 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2257 * search.c (looking_at_1, string_match_1):
2258 (fast_string_match, fast_c_string_match_ignore_case)
2259 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2260 (scan_newline, find_before_next_newline, search_command)
2261 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2262 (set_search_regs, wordify):
2263 (Freplace_match):
2264 (Fmatch_data):
2265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2266 (string_match_1, search_buffer, set_search_regs):
2267 (Fmatch_data):
2268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2269 (wordify): Check for overflow in size calculation.
2270 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2271 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2272 Check that fixnums are in proper range for system types.
2273 * sound.c (struct sound_device)
2274 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2276 (Fplay_sound_internal):
2277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2278 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2279 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2280 (Fparse_partial_sexp):
2281 Don't assume fixnums can fit in int.
2282 (struct lisp_parse_state, find_start_pos, find_start_value)
2283 (find_start_value_byte, find_start_begv)
2284 (update_syntax_table, char_quoted, dec_bytepos)
2285 (find_defun_start, prev_char_comend_first, back_comment):
2286 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2287 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2289 (Finternal_describe_syntax_value): Check that match_lisp is a
2290 character, not an integer, since the code stuffs it into int.
2291 (scan_words, scan_sexps_forward):
2292 Check that fixnums are in proper range for system types.
2293 (Fforward_word):
2294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2295 (scan_sexps_forward):
2296 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2297 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2298 * syntax.h: Adjust decls to match defn changes elsewhere.
2299 (struct gl_state_s):
2300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2301 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2302 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2303 * sysdep.c (wait_for_termination_1, wait_for_termination)
2304 (interruptible_wait_for_termination, mkdir):
2305 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2306 (emacs_read, emacs_write):
2307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2308 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2309 and double all fit in int.
d311d28c
PE
2310 * term.c (set_tty_color_mode):
2311 Check that fixnums are in proper range for system types.
2312 * termhooks.h (struct input_event):
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 * textprop.c (validate_interval_range, interval_of)
2315 (Fadd_text_properties, set_text_properties_1)
2316 (Fremove_text_properties, Fremove_list_of_text_properties)
2317 (Ftext_property_any, Ftext_property_not_all)
2318 (copy_text_properties, text_property_list, extend_property_ranges)
2319 (verify_interval_modification):
2320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2321 (Fnext_single_char_property_change)
2322 (Fprevious_single_char_property_change):
2323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2324 (copy_text_properties):
2325 Check for integer overflow in index calculation.
d311d28c
PE
2326 * undo.c (last_boundary_position, record_point, record_insert)
2327 (record_delete, record_marker_adjustment, record_change)
2328 (record_property_change):
2329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2330 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2332 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2333 (Fx_hide_tip, Fx_file_dialog):
2334 * w32menu.c (set_frame_menubar):
2335 Use ptrdiff_t, not int, for consistency with rest of code.
2336 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2337 (select_window, Fdelete_other_windows_internal)
2338 (window_scroll_pixel_based, window_scroll_line_based)
2339 (Frecenter, Fset_window_configuration):
2340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2341 (Fset_window_hscroll, run_window_configuration_change_hook)
2342 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2343 (Fscroll_other_window, Frecenter):
d311d28c
PE
2344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2345 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2346 Don't assume fixnum fits in int.
2347 (Fset_window_scroll_bars):
2348 Check that fixnums are in proper range for system types.
2349 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2350 (string_pos, c_string_pos, number_of_chars, init_iterator)
2351 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2352 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2353 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2354 (face_before_or_after_it_pos, handle_invisible_prop)
2355 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2356 (display_prop_intangible_p, string_buffer_position_lim)
2357 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2358 (get_overlay_strings_1, get_overlay_strings)
2359 (iterate_out_of_display_property, forward_to_next_line_start)
2360 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2361 (get_next_display_element, set_iterator_to_next)
2362 (get_visually_first_element, compute_stop_pos_backwards)
2363 (handle_stop_backwards, next_element_from_buffer)
2364 (move_it_in_display_line_to, move_it_in_display_line)
2365 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2366 (add_to_log, message_dolog, message_log_check_duplicate)
2367 (message2, message2_nolog, message3, message3_nolog
2368 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2369 (current_message_1, truncate_echo_area, truncate_message_1)
2370 (set_message, set_message_1, store_mode_line_noprop)
2371 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2372 (text_outside_line_unchanged_p, check_point_in_composition)
2373 (reconsider_clip_changes)
2374 (redisplay_internal, set_cursor_from_row, try_scrolling)
2375 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2376 (redisplay_window, find_last_unchanged_at_beg_row)
2377 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2378 (trailing_whitespace_p, find_row_edges, display_line)
2379 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2380 (display_mode_element, store_mode_line_string)
2381 (pint2str, pint2hrstr, decode_mode_spec)
2382 (display_count_lines, display_string, draw_glyphs)
2383 (x_produce_glyphs, x_insert_glyphs)
2384 (rows_from_pos_range, mouse_face_from_buffer_pos)
2385 (fast_find_string_pos, mouse_face_from_string_pos)
2386 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2388 (safe_call, init_from_display_pos, handle_fontified_prop)
2389 (handle_single_display_spec, load_overlay_strings)
2390 (with_echo_area_buffer, setup_echo_area_for_printing)
2391 (display_echo_area, echo_area_display)
2392 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2393 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2394 (redisplay_window, dump_glyph_row, display_mode_line)
2395 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2396 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2398 (handle_single_display_spec, build_desired_tool_bar_string)
2399 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2400 (get_specified_cursor_type):
2401 Check that fixnums are in proper range for system types.
2402 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2403 (Flookup_image_map):
2404 Don't assume fixnums fit in int.
2405 (compare_overlay_entries):
2406 Avoid mishandling comparisons due to subtraction overflow.
2407 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2408 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2409 (handle_tool_bar_click):
2410 Use int, not unsigned, since we prefer signed and the signedness
2411 doesn't matter here.
2412 (get_next_display_element, next_element_from_display_vector):
2413 Use int, not EMACS_INT, when int is wide enough.
2414 (start_hourglass): Use duration_to_sec_usec to do proper
2415 overflow checking on durations.
2416 * xfaces.c (Fbitmap_spec_p):
2417 Check that fixnums are in proper range for system types.
2418 (compare_fonts_by_sort_order):
2419 Avoid mishandling comparisons due to subtraction overflow.
2420 (Fx_family_fonts, realize_basic_faces):
2421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2422 (Fx_family_fonts):
2423 Don't assume fixnum fits in int.
2424 Use SAFE_ALLOCA_LISP, not alloca.
2425 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2426 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2427 (face_at_buffer_position, face_for_overlay_string)
2428 (face_at_string_position):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2430 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2431 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2432 (Fx_show_tip):
2433 Check that fixnums are in proper range for system types.
2434 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2435 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2437 (Fx_change_window_property): Don't assume fixnums fit in int.
2438 * xfont.c (xfont_chars_supported):
2439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2440 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2441 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2443 * xml.c (parse_region):
2444 * xrdb.c (magic_file_p):
2445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2446 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2447 (x_get_local_selection, x_reply_selection_request)
2448 (x_handle_selection_request, wait_for_property_change):
2449 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2450 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2451 short is wide enough.
2452 (x_send_client_event): Don't assume fixnum fits in int.
2453 * xterm.c (x_x_to_emacs_modifiers):
2454 Don't assume EMACS_INT overflows nicely into int.
2455 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2456 may come from Lisp.
2457 (handle_one_xevent): NATNUMP can eval its arg twice.
2458 (x_connection_closed):
2459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2460 * xterm.h: Adjust decls to match defn changes elsewhere.
2461 (struct scroll_bar): Use struct vectorlike_header
2462 rather than rolling our own approximation.
2463 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2464
c6574eb5
GM
24652012-05-25 Glenn Morris <rgm@gnu.org>
2466
2467 * lisp.mk (lisp): Update for more files being compiled now.
2468
e8d32c7e
SM
24692012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2470
48def666
SM
2471 * lread.c: Remove `read_pure' which makes no difference.
2472 (read_pure): Remove var.
2473 (unreadpure): Remove function.
2474 (readevalloop): Don't call read_list with -1 flag.
2475 (read1, read_vector): Don't test read_pure any more.
2476 (read_list): Simplify.
2477
e8d32c7e
SM
2478 * fileio.c, character.h: Minor style tweaks.
2479
4b2addb7
DA
24802012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2481
2482 * window.h (clip_changed): Remove useless declaration.
2483
584461b2
JB
24842012-05-22 Juanma Barranquero <lekktu@gmail.com>
2485
2486 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2487 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2488
34374650
PE
24892012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2490
2491 Remove src/m/*.
2492 This directory predates autoconf and is no longer needed nowadays.
2493 Move its few remaining bits of functionality to where they're needed.
2494 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2495 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2496 * m/template.h: Remove.
2497 * Makefile.in (M_FILE): Remove. All uses removed.
2498 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2499 * lisp.h (USE_LSB_TAG):
2500 * mem-limits.h (EXCEEDS_LISP_PTR):
2501 Use VAL_MAX, not VALBITS, in #if.
2502 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2503 (EMACS_UINT): Define unconditionally now.
2504 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2505 (BITS_PER_EMACS_INT): New constants, replacing
2506 what used to be in config.h, but not useful in #if.
2507 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2508 define them any more.
2509 (VAL_MAX): New macro.
2510 (VALMASK): Use it.
2511 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2512 BITS_PER_EMACS_INT, in #if.
2513 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2514 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2515 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2516 * s/ms-w32.h (DATA_START):
2517 Move here from removed file m/intel386.h.
2518 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2519 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2520
261cb4bb
PE
25212012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2522
2523 Assume C89 or later.
2524 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2525 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2526 (xrealloc):
2527 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2528 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2529 * textprop.c, tparam.c (NULL): Remove.
2530 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2531 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2532 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2533 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2534 * xterm.c (input_signal_count): Assume volatile works.
2535
ff23cd9f
KB
25362012-05-21 Ken Brown <kbrown@cornell.edu>
2537
2538 * xgselect.c (xg_select): Fix first argument in call to 'select'
2539 (bug#11508).
2540
1b170bc6
KB
25412012-05-20 Ken Brown <kbrown@cornell.edu>
2542
2543 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2544 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2545
b2f4d39f
KB
25462012-05-19 Ken Brown <kbrown@cornell.edu>
2547
2548 * xfns.c (x_in_use): Remove `static' qualifier.
2549 * xterm.h (x_in_use): Declare.
2550 * xgselect.c: Include xterm.h.
2551 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2552 and `display_arg' (bug#9754).
2553
003fdae2
PE
25542012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2555
9232a6d9
PE
2556 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2557
003fdae2
PE
2558 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2559 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2560
784b56e2
EZ
25612012-05-18 Eli Zaretskii <eliz@gnu.org>
2562
2563 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2564
2565 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2566 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2567
2568 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2569 reference to image_cache->refcount.
2570 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2571
a0a79cde
JL
25722012-05-17 Juri Linkov <juri@jurta.org>
2573
2574 * search.c (Fword_search_regexp, Fword_search_backward)
2575 (Fword_search_forward, Fword_search_backward_lax)
2576 (Fword_search_forward_lax): Move functions to isearch.el
2577 (bug#10145, bug#11381).
2578
b0572523
PE
25792012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2580
2581 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2582
9660f5fc
SM
25832012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2584
2585 * lread.c (init_obarray): Declare Qt and Qnil as special.
2586
4374de83
GM
25872012-05-14 Glenn Morris <rgm@gnu.org>
2588
2589 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2590 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2591
dc44c39a
PE
25922012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2593
078c97cb
PE
2594 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2595
dc44c39a
PE
2596 * unexaix.c: Port to more-recent AIX compilers.
2597 (report_error, report_error_1, make_hdr, copy_sym)
2598 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2599 Make arguments const char *, not char *, to avoid violations of C
2600 standard and to fix some AIX warnings reported by Gilles Pion.
2601
e18afed7 26022012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2603
2604 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2605 already have overlays loaded.
2606 (handle_single_display_spec): Before returning without displaying
2607 fringe bitmap, synchronize the bidi iterator with the main display
2608 iterator, by calling iterate_out_of_display_property.
2609 (iterate_out_of_display_property): Detect buffer iteration by
2610 testing that it->string is a Lisp string.
2611 (get_next_display_element): When the current object is exhausted,
2612 and there's something on it->stack, call set_iterator_to_next to
2613 proceed with what's on the stack, instead of returning zero.
2614 (set_iterator_to_next): If called at the end of a Lisp string,
2615 proceed to consider_string_end without incrementing string
2616 position. Don't increment display vector index past the end of
2617 the display vector. (Bug#11417)
c8fb9dc6
EZ
2618 (pos_visible_p): Don't report a position visible when move_it_to
2619 stopped at the last line of window, which happens to be scanned
2620 backwards by the bidi iteration. (Bug#11464)
ac268e67 2621
e18afed7 26222012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2623
2624 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2625 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2626 are on a TTY, and thus unable to display on the fringes.
2627 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2628 so we need to signal to the caller that this is a "replacing"
2629 display spec. This fixes display when the spec is invalid or we
2630 are on a TTY.
2631
e18afed7 26322012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2633
2634 * unexaix.c (make_hdr): Fix typo in prototype.
2635 This bug broke the build on AIX. Problem reported by Gilles Pion.
2636
9d0a235a
MA
26372012-05-14 Michael Albinus <michael.albinus@gmx.de>
2638
2639 * keyboard.c (kbd_buffer_get_event): Read special events also in
2640 batch mode. (Bug#11415)
2641
9e6b06ed
GM
26422012-05-12 Glenn Morris <rgm@gnu.org>
2643
2644 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2645
c1a1d7a3
EZ
26462012-05-12 Eli Zaretskii <eliz@gnu.org>
2647
2648 * lisp.mk (lisp): Add newcomment.elc.
2649
3fe7cdc8
GM
26502012-05-12 Glenn Morris <rgm@gnu.org>
2651
2652 * Makefile.in (MKDIR_P): New, set by configure.
2653 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2654
53f7d2c0
PE
26552012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 Remove unused function hourglass_started.
2658 * dispextern.h (hourglass_started):
2659 * w32fns.c (hourglass_started):
2660 * xdisp.c (hourglass_started): Remove.
2661
75aafb17
JB
26622012-05-10 Juanma Barranquero <lekktu@gmail.com>
2663
2664 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2665 Update dependencies.
2666
12959e8e
PE
26672012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2668
97107e2e
PE
2669 * xgselect.c (xg_select): Put maxfds+1 into a var.
2670 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2671
12959e8e
PE
2672 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2673
836d29b3
DA
26742012-05-10 Dave Abrahams <dave@boostpro.com>
2675
2676 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2677 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2678
5cb67954
MA
26792012-05-09 Michael Albinus <michael.albinus@gmx.de>
2680
2681 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2682 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2683 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2684 Initialize xd_registered_buses.
2685
3478ec45
PE
26862012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2687
b263a6b0
PE
2688 Untag more efficiently if USE_LSB_TAG.
2689 This is based on a proposal by YAMAMOTO Mitsuharu in
2690 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2691 For an admittedly artificial (nth 8000 longlist) benchmark on
2692 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2693 Emacs's overall text size by 1%.
2694 * lisp.h (XUNTAG): New macro.
2695 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2696 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2697 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2698 * eval.c (Fautoload):
2699 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2700 * frame.h (XFRAME): Use XUNTAG.
2701
3478ec45
PE
2702 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2703 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2704 Remove unportable assumptions about print widths of types like
2705 dbus_uint32_t.
2706 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2707 intptr_t when converting between pointer and integer, to avoid GCC
2708 warnings about wrong width.
2709
666b903b 27102012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2711
2712 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2713 stack for each reader_thread, instead of defaulting to 8MB
2714 determined by the linker. This avoids failures in creating
2715 subprocesses on Windows 7, see the discussion in this thread:
2716 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2717
b120cc17
JC
27182012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2719
2720 Fix up display of the *Minibuf-0* buffer in the mini window.
2721 * keyboard.c (read_char): Don't clear the echo area if there's no
2722 message to clear.
2723 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2724 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2725
9a4b36f8
MA
27262012-05-07 Michael Albinus <michael.albinus@gmx.de>
2727
2728 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2729 batch mode.
2730
e5f9458f
CY
27312012-05-06 Chong Yidong <cyd@gnu.org>
2732
2733 * lisp.mk (lisp): Update.
2734
eceeb5fc 27352012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2736
2737 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2738
71873e2b
SM
27392012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2740
2741 * data.c (PUT_ERROR): New macro.
2742 (syms_of_data): Use it. Add new error type `user-error'.
2743 * undo.c (user_error): New function.
2744 (Fprimitive_undo): Use it.
2745 * print.c (print_error_message): Adjust print style for `user-error'.
2746 * keyboard.c (user_error): New function.
2747 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2748
ab0fa4e4
PE
27492012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 Do not limit current-time-string to years 1000..9999.
2752 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2753 (Fcurrent_time_string): Support any year that is supported by the
2754 underlying localtime representation. Don't use asctime, as it
2755 has undefined behavior for years outside the range -999..9999.
2756
7ed806a7
PE
27572012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2758
2759 Fix race conditions involving setenv, gmtime, localtime, asctime.
2760 Without this fix, interrupts could mess up code that uses these
2761 nonreentrant functions, since setting TZ invalidates existing
2762 tm_zone or tzname values, and since most of these functions return
2763 pointers to static storage.
2764 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2765 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2766 Grow the critical sections to include not just invoking
2767 localtime/gmtime, but also accessing these functions' results
2768 including their tm_zone values if any, and any related TZ setting.
2769 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2770 so that the struct tm is saved in the critical section.
2771 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2772 motivated by the fact that memory allocation needs to be outside
2773 the critical section.
2774
0c16dfed
DA
27752012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2776
2777 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2778 with RESET_INTERVAL.
2779
2780 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2781 Remove duplicated buffer name initialization.
2782
3f83ace8
JM
27832012-05-02 Jim Meyering <jim@meyering.net>
2784
2785 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2786
c7b8541e
JM
2787 * xfns.c (x_window): Use xstrdup (Bug#11375).
2788
90207a15 27892012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2790
2791 * xdisp.c (pos_visible_p): If already at a newline from the
2792 display string before the 'while' loop, don't walk back the glyphs
2793 from it3.glyph_row. Solves assertion violation when the display
2794 string begins with a newline (egg.el). (Bug#11367)
2795
b593d6a9
AH
27962012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2797
2798 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2799 Move to simple.el.
2800
4737362e
GM
28012012-05-01 Glenn Morris <rgm@gnu.org>
2802
99cf43f9
GM
2803 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2804 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2805 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2806 All were removed before 23.1.
2807
9311dcff
GM
2808 * dispnew.c: Remove HAVE_LIBNCURSES test;
2809 it is always true on relevant platforms.
2810
4d5c6349
GM
2811 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2812 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2813
4737362e
GM
2814 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2815
74dd3a6b
AS
28162012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2817
2818 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2819 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2820 Remove.
2821
13c379ee
PE
28222012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2823
2824 Do not avoid creating empty evaporating overlays (Bug#9642).
2825 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2826 That is, do not delete an evaporating overlay if it becomes
2827 empty after its bounds are adjusted to fit within its buffer.
2828 This fix caused other problems, and I'm reverting it until we get
2829 to the bottom of them.
2830
a8e7d6d7 28312012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2832
2833 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2834
a8e7d6d7 28352012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2836
2837 * xdisp.c (pos_visible_p): If the window start position is beyond
2838 ZV, start the display from buffer beginning. Prevents assertion
2839 violation in init_iterator when the minibuffer window is scrolled
2840 via the scroll bar.
2841
2842 * window.c (window_scroll_pixel_based): Likewise.
2843
a8e7d6d7 28442012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2845
2846 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2847
a8e7d6d7 28482012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2849
2850 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2851 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2852
a8e7d6d7 28532012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2854
b593d6a9
AH
2855 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2856 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2857
1c6900d9
EZ
28582012-04-26 Eli Zaretskii <eliz@gnu.org>
2859
4c3fa1d9
EZ
2860 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2861 display element, check also the underlying string or buffer
2862 character. (Bug#11341)
2863
1c6900d9
EZ
2864 * w32menu.c: Include w32heap.h.
2865 (add_menu_item): If the call to AppendMenuW (via
2866 unicode_append_menu) fails, disable Unicode menus only if we are
2867 running on Windows 9X/Me.
2868
42bf8205
AS
28692012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2870
2871 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2872 (xgetint): Add missing shift for LSB tags.
2873
b1bac16e
MR
28742012-04-24 Martin Rudalics <rudalics@gmx.at>
2875
2876 * keyboard.c (read_char): Don't wipe echo area for select window
2877 events: These might get delayed via `mouse-autoselect-window'
2878 (Bug#11304).
2879
d69621cc
JB
28802012-04-24 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2883 manipulation of :loaded-from data.
2884
02fd101b
JB
28852012-04-23 Juanma Barranquero <lekktu@gmail.com>
2886
2887 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2888 now a cons (bug#11311).
2889
888bec30
PE
28902012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2891
89a438bd
PE
2892 Do not create empty overlays with the evaporate property (Bug#9642).
2893 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2894 if it becomes empty after its bounds are adjusted to fit within
2895 its buffer. Without this fix, in a nonempty buffer (let ((o
2896 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2897 yields an empty overlay that has the evaporate property, which is
2898 not supposed to happen.
2899
1068fe4d
PE
2900 Fix minor GTK3 problems found by static checking.
2901 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2902 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2903 (struct _EmacsFixedClass, emacs_fixed_get_type):
2904 Move decls here from emacsgtkfixed.h, since they needn't be public.
2905 (emacs_fixed_get_type): Now static.
2906 (emacs_fixed_class_init): Omit unused local.
2907 (emacs_fixed_child_type): Remove; unused.
2908 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2909 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2910 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2911 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2912 (EMACS_FIXED_GET_CLASS): Remove; unused.
2913 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2914
888bec30
PE
2915 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2916 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2917
de85e130
PE
29182012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2919
d0baac98 2920 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2921 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2922 (__malloc_size_t, __malloc_ptrdiff_t):
2923 Remove. All uses removed, replaced by the definiens if needed,
2924 since we can assume C89 or better now.
2925 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2926 (protect_malloc_state, align, get_contiguous_space)
2927 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2928 (malloc_atfork_handler_child, malloc_enable_thread)
2929 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2930 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2931 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2932 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2933 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2934 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2935 Define using prototypes, not old style.
2936 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2937 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2938 (align): Don't assume that signed integer overflow wraps around.
2939 Omit unused local var.
2940 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2941 (_free_internal_nolock, memalign, mallochook, reallochook):
2942 Omit no-longer-needed casts.
2943 (valloc): Use getpagesize, not __getpagesize.
2944 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2945 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2946
de85e130
PE
2947 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2948
dcbf5805
MA
29492012-04-22 Michael Albinus <michael.albinus@gmx.de>
2950
2951 Move functions from C to Lisp. Make non-blocking method calls
2952 the default. Implement further D-Bus standard interfaces.
2953
2954 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2955 (QCdbus_request_name_allow_replacement)
2956 (QCdbus_request_name_replace_existing)
2957 (QCdbus_request_name_do_not_queue)
2958 (QCdbus_request_name_reply_primary_owner)
2959 (QCdbus_request_name_reply_in_queue)
2960 (QCdbus_request_name_reply_exists)
2961 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2962 (QCdbus_registered_serial, QCdbus_registered_method)
2963 (QCdbus_registered_signal): New Lisp objects.
2964 (XD_DEBUG_MESSAGE): Use sizeof.
2965 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2966 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2967 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2968 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2969 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2970 (xd_signature, xd_append_arg): Allow float for integer types.
2971 (xd_get_connection_references): New function.
b593d6a9
AH
2972 (xd_get_connection_address): Rename from xd_initialize.
2973 Return cached address.
dcbf5805
MA
2974 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2975 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2976 level.
2977 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2978 Return number of refcounts.
dcbf5805
MA
2979 (Fdbus_get_unique_name): Make stronger parameter check.
2980 (Fdbus_message_internal): New defun.
2981 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2982 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2983 (Fdbus_send_signal, Fdbus_register_service)
2984 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2985 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2986 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2987 (Vdbus_compiled_version, Vdbus_runtime_version)
2988 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2989 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2990 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2991 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2992 Adapt docstring.
dcbf5805 2993
52828e02
PE
29942012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2995
da05bc4c
PE
2996 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2997 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2998 Do not assume ptrdiff_t is the same width as 'int'.
2999
52828e02
PE
3000 * alloc.c: Handle unusual debugging option combinations.
3001 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3002 since the two debugging options are incompatible.
3003 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3004 is defined.
3005 (mem_init, mem_insert, mem_insert_fixup):
3006 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3007 (NEED_MEM_INSERT): Remove; no longer needed.
3008
f01769f9
LL
30092012-04-22 Leo Liu <sdl.web@gmail.com>
3010
3011 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3012
5790543d
PE
30132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 * sysdep.c [__FreeBSD__]: Minor cleanups.
3016 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3017 Use Emacs indenting style more consistently. Avoid some casts.
3018 Use 'double' consistently rather than mixing 'float' and 'double'.
3019
b91b7e4d
EW
30202012-04-21 Eduard Wiebe <usenet@pusto.de>
3021
b593d6a9
AH
3022 * sysdep.c (list_system_processes, system_process_attributes):
3023 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3024
6114eb15
AS
30252012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3026
3027 * lisp.mk (lisp): Update.
3028
2f38dff7
PE
30292012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3030
3031 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3032 It is never used otherwise.
3033
4ae29f89
SM
30342012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3035
3036 * print.c (print_preprocess): Only check print_depth if print-circle
3037 is nil.
3038 (print_object): Check for cycles even when print-circle is nil and
3039 print-gensym is t, but only check print_depth if print-circle is nil.
3040
f30d612a
CY
30412012-04-20 Chong Yidong <cyd@gnu.org>
3042
3043 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3044 set the status to "failed" and ensure that sentinel is run.
3045
c07a4c0b 30462012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3047
3048 * process.c (Fset_process_inherit_coding_system_flag)
3049 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3050 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3051
c07a4c0b 30522012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3053
3054 * xdisp.c (string_buffer_position_lim): Limit starting position to
3055 BEGV.
3056 (set_cursor_from_row): If called for a mode-line or header-line
3057 row, return zero immediately.
3058 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3059 farther than the first row after the header line, if any.
3060 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3061 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3062
c07a4c0b 30632012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3064
4ae29f89
SM
3065 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3066 (bug#11238).
ad3a2b41 3067
c07a4c0b 30682012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 30692012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3070
3071 configure: new option --enable-gcc-warnings (Bug#11207)
3072 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3073 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3074 (ALL_CFLAGS): Use new macros rather than old.
3075 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3076 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3077 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3078 -Wunused-result, -Wunused-variable. This should go away once
3079 the Emacs and Gnulib regex code is merged.
3080 (xmalloc, xrealloc): Now static.
3081
aba027e8
PE
30822012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3083
3084 * dired.c (Fsystem_groups): Remove unused local.
3085
e5a36063
GM
30862012-04-17 Glenn Morris <rgm@gnu.org>
3087
3088 * dired.c (Fsystem_users): Doc fix.
3089
316411f0
DA
30902012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3091
3092 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3093 (syms_of_dired): Add them.
3094
9426aba4
PE
30952012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3096
b62a57be
PE
3097 Fix minor alloc.c problems found by static checking.
3098 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3099 New extern decls, to avoid calling undeclared functions.
3100 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3101 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3102 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3103 (NEED_MEM_INSERT): New macro.
3104 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3105 Remove one incorrect comment and fix another.
b62a57be 3106
3539f31f
PE
3107 Fix minor ralloc.c problems found by static checking.
3108 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3109 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3110 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3111 (r_alloc_sbrk): Now static.
3112
a041960a
PE
3113 Improve ralloc.c interface checking.
3114 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3115 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3116 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3117 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3118 [REL_ALLOC]: ... to here, to check interface.
3119 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3120 Remove decls. This fixes an "It stinks!".
3121
9426aba4
PE
3122 * alloc.c (which_symbols): Fix alignment issue / type clash.
3123
d55c12ed
AS
31242012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3125
3126 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3127 (struct Lisp_Misc_Any): Likewise.
3128 (struct Lisp_Free): Likewise.
3129 * alloc.c (union aligned_Lisp_Symbol): Define.
3130 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3131 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3132 (union aligned_Lisp_Misc): Define.
3133 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3134 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3135 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3136
b948ce8b
PE
31372012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3138
3139 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3140 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3141 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3142 * s/netbsd.h, s/sol2-6.h:
3143 Remove definition of GC_MARK_STACK, since the default now works.
3144 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3145 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3146 no longer the default.
3147 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3148
35dc09a1 31492012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3150
35dc09a1
GM
3151 * lread.c (lisp_file_lexically_bound_p):
3152 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3153
35dc09a1
GM
31542012-04-14 Eli Zaretskii <eliz@gnu.org>
3155
3156 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3157 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3158
31592012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3160
3161 * nsterm.m (constrainFrameRect): Always constrain when there is only
3162 one screen (Bug#10962).
3163
bcd86815
KB
31642012-04-13 Ken Brown <kbrown@cornell.edu>
3165
3166 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3167
c25df26e
RT
31682012-04-13 Reuben Thomas <rrt@sc3d.org>
3169
3170 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3171
0fc59f1e
DC
31722012-04-11 Daniel Colascione <dancol@dancol.org>
3173
3174 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3175 against is gone. It's better to use vfork now so that when Cygwin
3176 gains a new, working vfork, we use it automatically (bug#10398).
3177
de8c03dc
SM
31782012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3179
3180 * window.c (save_window_save): Obey window-point-insertion-type.
3181
2f097256
GM
31822012-04-11 Glenn Morris <rgm@gnu.org>
3183
3184 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3185
453b951e
SM
31862012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3187
3188 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3189
75f1671a 31902012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3191
3192 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3193 (force_quit_count): New var.
3194 (handle_interrupt): Use it.
3195
2a8ce227
JB
31962012-04-10 Juanma Barranquero <lekktu@gmail.com>
3197
3198 * w32.c (w32_delayed_load): Record the full path of the library
3199 being loaded (bug#10424).
3200
935396c0
GM
32012012-04-09 Glenn Morris <rgm@gnu.org>
3202
05920a43
GM
3203 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3204 not just in the obarray, before snarfing them. (Bug#11036)
3205
935396c0
GM
3206 * Makefile.in ($(leimdir)/leim-list.el):
3207 Pass EMACS rather than BUILT_EMACS.
3208
a18ecafa
TZ
32092012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3210
3211 * process.c (make_process):
3212 * process.h: Add integer `gnutls_handshakes_tried' member to
3213 process struct.
3214
6bbef4e5
JC
3215 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3216 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3217
3218 * gnutls.c (gnutls_log_function2i): Convenience log function.
3219 (emacs_gnutls_read): Use new log functions,
3220 `gnutls_handshakes_tried' process member, and
3221 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3222 attempts per process (connection).
3223
b4d3bc10
CY
32242012-04-09 Chong Yidong <cyd@gnu.org>
3225
3226 * eval.c (Fuser_variable_p, user_variable_p_eh)
3227 (lisp_indirect_variable): Functions deleted.
3228 (Fdefvar): Caller changed.
3229
3230 * callint.c (Finteractive, Fcall_interactively):
3231 * minibuf.c (Fread_variable): Callers changed.
3232
70f4d973
EZ
32332012-04-09 Eli Zaretskii <eliz@gnu.org>
3234
3235 * xdisp.c (set_cursor_from_row): If the display string appears in
3236 the buffer at position that is closer to point than the position
3237 after the display string, display the cursor on the first glyph of
3238 the display string. Fixes cursor display when a 'display' text
3239 property immediately follows invisible text. (Bug#11094)
3240
cb3c2e3e
PE
32412012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 composite.c: use 'double' consistently
3244 * composite.c (get_composition_id): Use 'double' consistently
3245 instead of converting 'float' to 'double' and vice versa; this is
3246 easier to understand and avoids a GCC warning.
3247
fd06db5d
GM
32482012-04-09 Glenn Morris <rgm@gnu.org>
3249
50fe702a
GM
3250 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3251 preparation for dumping it with emacs. (Bug#4789)
3252 (leimdir): New variable.
3253 ($(leimdir)/leim-list.el): New rule.
3254 (emacs$(EXEEXT)): Depend on leim-list.el.
3255
fd06db5d
GM
3256 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3257 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3258 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3259
55c131ee
AS
32602012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3261
3262 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3263 proper alignment.
3264
9209588f
JB
32652012-04-07 Juanma Barranquero <lekktu@gmail.com>
3266
3267 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3268 Remove unused local variable.
3269
e3fb2efb
PE
32702012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3271
3272 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3273 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3274 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3275 objects, as mark_maybe_pointer will catch them otherwise.
3276 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3277 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3278
b5385551
PE
32792012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 Fix typo that broke non-Windows builds.
3282 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3283
9078ead6
EZ
32842012-04-07 Eli Zaretskii <eliz@gnu.org>
3285
3286 Support building on MS-Windows with libxml2.
3287
3288 * makefile.w32-in (OBJ2): Add xml.$(O).
3289 (GLOBAL_SOURCES): Add xml.c.
3290 ($(BLD)/xml.$(O)): New dependency list.
3291
3292 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3293 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3294 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3295 [!WINDOWSNT]: New macros.
3296 (init_libxml2_functions, libxml2_loaded_p): New functions.
3297 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3298 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3299 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3300 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3301 linked in).
6bbef4e5
JC
3302 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3303 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3304 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3305
3306 * emacs.c: Don't include libxml/parser.h.
3307 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3308 xmlCleanupParser directly.
3309
3310 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3311
3811fdf3
EZ
33122012-04-07 Eli Zaretskii <eliz@gnu.org>
3313
3314 * indent.c (Fvertical_motion): If there is a display string at
3315 point, use it.vpos to compute how many lines to backtrack after
3316 move_it_to point. (Bug#11133)
3317
2f8e16b2
EZ
33182012-04-06 Eli Zaretskii <eliz@gnu.org>
3319
3320 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3321 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3322 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3323 macros related to unification of CJK characters. For the details,
3324 see the discussion following the message here:
3325 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3326
3d439cd1
CY
33272012-04-04 Chong Yidong <cyd@gnu.org>
3328
3329 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3330
8bc53d00
EZ
33312012-04-01 Eli Zaretskii <eliz@gnu.org>
3332
3333 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3334 instead of alloca. (Bug#11138)
3335
3b0512a3
AS
33362012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3337
3338 * w32menu.c (is_simple_dialog): Properly check lisp types.
3339 (Bug#11141)
3340
8427ddd2
EZ
33412012-03-31 Eli Zaretskii <eliz@gnu.org>
3342
979022ef
EZ
3343 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3344 position we get to after a call to move_it_to fails the
3345 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3346 only if we wind up in a string from display property. (Bug#11063)
3347
a6b1c7cc
EZ
3348 * window.c (Fdelete_other_windows_internal): Invalidate the row
3349 and column information about mouse highlight, so that redisplay
3350 restores it after reallocating the glyph matrices. (Bug#7464)
3351
8427ddd2
EZ
3352 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3353 string comes from a `display' text property, use the buffer
3354 position of that property as if we actually saw that position in
3355 the row's glyphs.
697ba24b
EZ
3356 (move_it_by_lines): Remove the assertion that
3357 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3358 violated when there's a before-string at the beginning of a line.
3359 (Bug#11063)
8427ddd2 3360
65a0a738
EZ
33612012-03-30 Eli Zaretskii <eliz@gnu.org>
3362
3363 * xdisp.c (append_space_for_newline): If the default face was
3364 remapped, use the remapped face for the appended newline.
3365 (extend_face_to_end_of_line): Use the remapped default face for
3366 extending the face to the end of the line.
3367 (display_line): Call extend_face_to_end_of_line when the default
3368 face was remapped. (Bug#11068)
3369
581355cc
EZ
33702012-03-29 Eli Zaretskii <eliz@gnu.org>
3371
3372 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3373
e8fc049f
SM
33742012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3375
3376 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3377
4fb9a543
GM
33782012-03-27 Glenn Morris <rgm@gnu.org>
3379
3380 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3381 Doc fixes.
3382
679910f1
KH
33832012-03-26 Kenichi Handa <handa@m17n.org>
3384
3385 * dispextern.h (struct glyph): Fix previous change. Change the
3386 bit length of glyphless.ch to 25 (Bug#11082).
3387
90d49b7f
CY
33882012-03-26 Chong Yidong <cyd@gnu.org>
3389
3390 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3391 (command_loop_1): Use it; inhibit selection update for
3392 handle-select-window too (Bug#8996).
3393
f514f6f0
FP
33942012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3395
e8fc049f 3396 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3397
bf43fa51
KH
33982012-03-25 Kenichi Handa <handa@m17n.org>
3399
3400 * dispextern.h (struct glyph): Change the bit length of
3401 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3402
8a0c01dd
EZ
34032012-03-24 Eli Zaretskii <eliz@gnu.org>
3404
3405 * s/ms-w32.h (tzname): Include time.h before redirecting to
3406 _tzname. Fixes the MSVC build. (Bug#9960)
3407
7d1c3a76
AS
34082012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3409
8ed79523
AS
3410 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3411 characters.
3412
7d1c3a76
AS
3413 * xterm.c (XTread_socket): Only modify handling_signal if
3414 !SYNC_INPUT. (Bug#11080)
3415
e99a9b8b
EZ
34162012-03-23 Eli Zaretskii <eliz@gnu.org>
3417
3418 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3419 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3420 when fetching a multibyte character consumes more bytes than
3421 CHAR_BYTES returns, due to unification of CJK characters in
3422 string_char. (Bug#11073)
3423
5063c0e1
TN
34242012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3425
3426 * process.c (wait_reading_process_output): Handle pty disconnect
3427 by refraining from sending oneself a SIGCHLD (bug#10933).
3428
9f851fbd
CY
34292012-03-22 Chong Yidong <cyd@gnu.org>
3430
3431 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3432
5063c0e1 3433 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3434 Mark string as coming from a prefix property.
3435 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3436 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3437
fb5b8aca
CY
34382012-03-21 Chong Yidong <cyd@gnu.org>
3439
3440 * xfaces.c (Vface_remapping_alist): Doc fix.
3441
62356a1b
EZ
34422012-03-20 Eli Zaretskii <eliz@gnu.org>
3443
3444 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3445 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3446 Doc fixes.
62356a1b 3447
025de85b
CY
34482012-03-20 Chong Yidong <cyd@gnu.org>
3449
3450 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3451 to reflect default non-nil value of redisplay-dont-pause.
3452
4827f94e
KH
34532012-03-19 Kenichi Handa <handa@m17n.org>
3454
3455 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3456 it fit in a valid range (Bug#11003).
3457
e50a24a2
EZ
34582012-03-18 Eli Zaretskii <eliz@gnu.org>
3459
3460 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3461 that is not from display property, accept the row as a "cursor
3462 row" if one of the string's character has a non-nil `cursor'
3463 property. Fixes cursor positioning when there are newlines in
3464 overlay strings, e.g. in icomplete.el. (Bug#11035)
3465
9af5ed87
PE
34662012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3469
d1f55f16
CY
34702012-03-12 Chong Yidong <cyd@gnu.org>
3471
3472 * eval.c (inhibit_lisp_code): Rename from
3473 inhibit_window_configuration_change_hook; move from window.c.
3474
3475 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3476 * window.c (run_window_configuration_change_hook)
3477 (syms_of_window): Callers changed.
3478
66c5eebd
CY
34792012-03-11 Chong Yidong <cyd@gnu.org>
3480
413df973
CY
3481 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3482
66c5eebd
CY
3483 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3484
1de11f56
CY
34852012-03-10 Chong Yidong <cyd@gnu.org>
3486
3487 * frame.c (other_visible_frames): Don't assume the selected frame
3488 is visible (Bug#10955).
3489
cae07000
SM
34902012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3491
3492 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3493
89c94350
JD
34942012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3495
3496 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3497 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3498 zero (Bug#10954).
3499
999dd333
GM
35002012-03-03 Glenn Morris <rgm@gnu.org>
3501
01a6dcc8 3502 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3503
de0100f2
EZ
35042012-03-02 Eli Zaretskii <eliz@gnu.org>
3505
3506 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3507 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3508 (redisplay_window, next_element_from_string): Fix typos in
3509 comments.
3e441275
EZ
3510 (redisplay_window): Pass to move_it_vertically the margin in
3511 pixels, not in screen lines.
de0100f2 3512
96a72ee9
GM
35132012-03-02 Glenn Morris <rgm@gnu.org>
3514
3515 * buffer.c (buffer-list-update-hook): Doc fix.
3516
312508d7
EZ
35172012-02-29 Eli Zaretskii <eliz@gnu.org>
3518
3519 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3520 push_it before setting up the iterator for the first overlay
3521 string, even if we have an empty string loaded.
3522 (next_overlay_string): If there's an empty string on the iterator
3523 stack, pop the stack. (Bug#10903)
3524
27f3c637
PE
35252012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3528 Suggested by Stefan Monnier in
3529 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3530 * alloc.c (widen_to_Lisp_Object): New static function.
3531 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3532 and widening them to Lisp_Objects. This would work even if
3533 USE_LSB_TAG is defined and wide integers are used, which might
3534 happen in a future version of Emacs.
3535
3c9dfce6
CY
35362012-02-25 Chong Yidong <cyd@gnu.org>
3537
fa74b241
CY
3538 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3539 Doc fix.
3540
3c9dfce6
CY
3541 * xselect.c (Fx_selection_exists_p): Doc fix.
3542 (x_clipboard_manager_save_all): Print an informative message
3543 before saving to clipboard manager.
3544
9486df08
CY
35452012-02-24 Chong Yidong <cyd@gnu.org>
3546
3547 * keyboard.c (process_special_events): Handle all X selection
3548 requests in kbd_buffer, not just the next one (Bug#8869).
3549
f01d3321
CY
35502012-02-23 Chong Yidong <cyd@gnu.org>
3551
3552 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3553 call when setting menu-bar-lines and tool-bar-lines parameters.
3554 (unwind_create_frame_1): New helper function.
3555
3556 * window.c (inhibit_window_configuration_change_hook): New var.
3557 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3558 (syms_of_window): Initialize it.
f01d3321 3559
86b847b6
CY
35602012-02-22 Chong Yidong <cyd@gnu.org>
3561
3562 * xterm.c (x_draw_image_relief): Add missing type check for
3563 Vtool_bar_button_margin (Bug#10743).
3564
a59225b1
CY
35652012-02-21 Chong Yidong <cyd@gnu.org>
3566
3567 * fileio.c (Vfile_name_handler_alist): Doc fix.
3568
3569 * buffer.c (Fget_file_buffer): Protect against invalid file
3570 handler return value.
3571
310f5bd4
PE
35722012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3573
cb3a28cc
PE
3574 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3575 when computing $valmask.
3576
310f5bd4
PE
3577 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3578 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3579 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3580 It's useless in that case, and it can cause problems on hosts
3581 that allocate halves of EMACS_INT values separately.
3582 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3583 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3584 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3585 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3586 it avoids undefined behavior on hosts where shifting right by more
3587 than the word width has undefined behavior.
3588
2375c96a
CY
35892012-02-19 Chong Yidong <cyd@gnu.org>
3590
3591 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3592 (Funhandled_file_name_directory, Ffile_name_as_directory)
3593 (Fdirectory_file_name, Fexpand_file_name)
3594 (Fsubstitute_in_file_name): Protect against invalid file handler
3595 return values (Bug#10845).
3596
3eb49e71
EZ
35972012-02-18 Eli Zaretskii <eliz@gnu.org>
3598
3599 * .gdbinit (pitx): Fix incorrect references to fields of the
3600 iterator stack.
3601
7b926f3f
CY
36022012-02-17 Chong Yidong <cyd@gnu.org>
3603
3604 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3605
11273115
PE
36062012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3609 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3610
c3a70e2b
CY
36112012-02-15 Chong Yidong <cyd@gnu.org>
3612
3613 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3614 marked as special. Also, starting docstrings with * is obsolete.
3615
0ca43699
AS
36162012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3617
3618 * gnutls.c (emacs_gnutls_write): Fix last change.
3619
2e8f3c56
LI
36202012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3621
3622 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3623 send_process.
3624
af70074f
SM
36252012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3626
3627 * keymap.c (Fsingle_key_description): Handle char ranges.
3628
95986d52
CY
36292012-02-12 Chong Yidong <cyd@gnu.org>
3630
afd83bd1
CY
3631 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3632 as that creates a dangerous corner case.
3633
95986d52
CY
3634 * window.c (Fdelete_window_internal): Invalidate the mouse
3635 highlight (Bug#9904).
3636
bd7da63e
GM
36372012-02-12 Glenn Morris <rgm@gnu.org>
3638
3639 * xselect.c (Fx_own_selection_internal)
3640 (Fx_get_selection_internal, Fx_disown_selection_internal)
3641 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3642 * nsselect.m (Fx_own_selection_internal)
3643 (Fx_disown_selection_internal, Fx_selection_exists_p)
3644 (Fx_selection_owner_p, Fx_get_selection_internal):
3645 Sync docs and argument specs with the xselect.c versions.
3646
77abcbc2
LI
36472012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3648
3649 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3650
90b671e2
EZ
36512012-02-11 Eli Zaretskii <eliz@gnu.org>
3652
1c0ca0b7
EZ
3653 * w32select.c (Fx_selection_exists_p): Sync doc string and
3654 argument list with xselect.c. (Bug#10783)
3655
3656 * w16select.c (Fx_selection_exists_p): Sync doc string and
3657 argument list with xselect.c. (Bug#10783)
90b671e2 3658
49241268
GM
36592012-02-10 Glenn Morris <rgm@gnu.org>
3660
3661 * fns.c (Fsecure_hash): Doc fix.
3662
f998bbe7 36632012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3664
3665 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3666
0992bd9c
CY
36672012-02-07 Chong Yidong <cyd@gnu.org>
3668
3669 * buffer.c (Fbuffer_local_variables)
3670 (buffer_lisp_local_variables): Handle unbound vars correctly;
3671 don't let Qunbound leak into Lisp.
3672
af008560
GM
36732012-02-07 Glenn Morris <rgm@gnu.org>
3674
dd605cc4
GM
3675 * image.c (Fimagemagick_types): Doc fix.
3676
af008560
GM
3677 * image.c (imagemagick-render-type): Change it from a lisp object
3678 to an integer. Move the doc here from the lisp manual.
3679 Treat all values not equal to 0 the same.
3680
1449fa1d
CY
36812012-02-06 Chong Yidong <cyd@gnu.org>
3682
3683 * doc.c (store_function_docstring): Avoid applying docstring of
3684 alias to base function (Bug#2603).
3685
3723ec07
AS
36862012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3687
3688 * .gdbinit (pp1, pv1): Remove redundant defines.
3689 (pr): Use pp.
3690
79c1cc1e
CY
36912012-02-04 Chong Yidong <cyd@gnu.org>
3692
3693 * nsterm.m: Declare a global (Bug#10694).
3694
d7f29f8e
EZ
36952012-02-04 Eli Zaretskii <eliz@gnu.org>
3696
cae07000
SM
3697 * w32.c (get_emacs_configuration_options):
3698 Include --enable-checking, if specified, in the return value.
d7f29f8e 3699
3b95a6f9
MR
37002012-02-04 Martin Rudalics <rudalics@gmx.at>
3701
3702 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3703 after rounding frame sizes. (Bug#9723)
3704
d6fa96a6
EZ
37052012-02-04 Eli Zaretskii <eliz@gnu.org>
3706
3707 * keyboard.c (adjust_point_for_property): Don't position point
3708 before BEGV. (Bug#10696)
3709
df0b2940
PE
37102012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 Handle overflow when computing char display width (Bug#9496).
3713 * character.c (char_width): Return EMACS_INT, not int.
3714 (char_width, c_string_width): Check for overflow when
3715 computing the width; this is possible now that individual
3716 characters can have unbounded width. Problem introduced
3717 by merge from Emacs 23 on 2012-01-19.
3718
6bee44d6
MA
37192012-02-02 Michael Albinus <michael.albinus@gmx.de>
3720
3721 * dbusbind.c (Fdbus_register_method): Mention the return value
3722 :ignore in the docstring.
3723
44f92739
GM
37242012-02-02 Glenn Morris <rgm@gnu.org>
3725
1b9f60cc
GM
3726 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3727
44f92739
GM
3728 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3729 Unconditionally set to t. (Bug#10673)
3730 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3731 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3732 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3733
c5d3843c
KH
37342012-02-02 Kenichi Handa <handa@m17n.org>
3735
3736 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3737 0, do not call append_composite_glyph.
3738
159462d4 37392012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3740
3741 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3742 NULL (Bug#6988).
3743 (x_produce_glyphs): If the component of a composition is a null
3744 string, set it->pixel_width to 1 to avoid zero-width glyph.
3745
78cef877
EZ
37462012-02-01 Eli Zaretskii <eliz@gnu.org>
3747
3748 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3749 first 2 arguments are identical. This makes inserting large
3750 output from a subprocess an order of magnitude faster on
3751 MS-Windows, where all sbrk'ed memory is always contiguous.
3752
97897668
GM
37532012-01-31 Glenn Morris <rgm@gnu.org>
3754
3755 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3756 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3757 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3758
31fd3586
GM
37592012-01-29 Glenn Morris <rgm@gnu.org>
3760
3761 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3762
0e24a8b2
CY
37632012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3764
3765 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3766
cc0adcb0
CY
37672012-01-28 Chong Yidong <cyd@gnu.org>
3768
3769 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3770
acc28cb9
CY
37712012-01-26 Chong Yidong <cyd@gnu.org>
3772
9c69cfb7
CY
3773 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3774
acc28cb9
CY
3775 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3776 repeat counts (Bug#10507).
3777
48da7392
GM
37782012-01-26 Glenn Morris <rgm@gnu.org>
3779
3780 * lread.c (syms_of_lread): Doc fix.
3781
14af5f7f
CY
37822012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3783
3784 * coding.c (encode_designation_at_bol): Change return value to
3785 EMACS_INT.
3786
0b21c100
CY
37872012-01-25 Chong Yidong <cyd@gnu.org>
3788
3789 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3790
3c2907f7
CY
37912012-01-21 Chong Yidong <cyd@gnu.org>
3792
3793 * floatfns.c (Fcopysign): Make the second argument non-optional,
3794 since nil is not allowed anyway.
3795
959ad23f
AS
37962012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3797
3798 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3799 (send_process): Likewise.
3800
34a02f46
MR
38012012-01-19 Martin Rudalics <rudalics@gmx.at>
3802
3803 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3804 (Vwindow_persistent_parameters): Do not use Qstate.
3805 Rewrite doc-strings.
34a02f46 3806
1259009a 38072012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3808
3809 * character.c (char_width): New function.
70d4fdf6
GM
3810 (Fchar_width, c_string_width, lisp_string_width):
3811 Use char_width (Bug#9496).
25ed9e61 3812
6a6ee00d
MR
38132012-01-16 Martin Rudalics <rudalics@gmx.at>
3814
3815 * window.c (Vwindow_persistent_parameters): New variable.
3816 (Fset_window_configuration, save_window_save): Handle persistent
3817 window parameters.
3818
c85efaf7
EZ
38192012-01-14 Eli Zaretskii <eliz@gnu.org>
3820
3821 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3822 thrashing the stack of the thread. (Bug#9087)
3823
5944709e
PE
38242012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3825
3826 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3827
e71f5d99
EZ
38282012-01-11 Eli Zaretskii <eliz@gnu.org>
3829
3830 * xdisp.c (rows_from_pos_range): Handle the case where the
3831 highlight ends on a newline. (Bug#10464)
3832 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3833 he end column for display of highlight that ends on a newline
3834 before a R2L line.
3835
ce316182
GM
38362012-01-11 Glenn Morris <rgm@gnu.org>
3837
3838 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3839 from load-path also when installation-directory is nil. (Bug#10208)
3840
5b43da69
GM
38412012-01-10 Glenn Morris <rgm@gnu.org>
3842
74cc8ff9
GM
3843 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3844
7d8d6e4e
GM
3845 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3846 Update template values to be closer to their typical values these days.
5b43da69 3847
a0db8d43
EZ
38482012-01-09 Eli Zaretskii <eliz@gnu.org>
3849
3850 * xdisp.c (rows_from_pos_range): Accept additional argument
3851 DISP_STRING, and accept any glyph in a row whose object is that
3852 string as eligible for mouse highlight. Fixes mouse highlight of
3853 display strings from overlays. (Bug#10464)
3854
9a0115ab 38552012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3856
b9110d6a 3857 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3858 * fileio.c (auto_saving_dir_umask): New static var.
3859 (Fmake_directory_internal): Use it.
3860 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3861 creating the directory. The old code temporarily assigns
3862 too-generous permissions to the directory.
3863 (do_auto_save_eh): Clear it.
b9110d6a 3864 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3865 that the var is always cleared.
3866
6c1bd3f3
EZ
38672012-01-07 Eli Zaretskii <eliz@gnu.org>
3868
3869 * search.c (scan_buffer): Pass character positions to
3870 know_region_cache, not byte positions. (Bug#6540)
3871
069d2b50
L
38722012-01-07 LynX <_LynX@bk.ru> (tiny change)
3873
3874 * w32.c (sys_rename): Report EXDEV when rename of a directory
3875 fails because the target is on another logical disk. (Bug#10284)
3876
75bf0d33
DB
38772012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3878
3879 * xterm.c (x_embed_request_focus): New function.
3880
3881 * xterm.h: Add prototype.
3882
3883 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3884
1c6e5a32
GM
38852012-01-05 Glenn Morris <rgm@gnu.org>
3886
3887 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3888
651e947e
EZ
38892012-01-01 Eli Zaretskii <eliz@gnu.org>
3890
3891 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3892 Load gnutls_transport_set_lowat only if GnuTLS version is below
3893 2.11.1.
3894 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3895 GnuTLS versions below 2.11.1.
3896
3778cdd8
AL
38972011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3898
3899 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3900 to the doc string advising against its use for altering the way
3901 windows are scrolled.
3902
0e5317f7
KH
39032011-12-28 Kenichi Handa <handa@m17n.org>
3904
3905 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3906 coding-system ASCII compatible only when it does not produce BOM
3907 on encoding (Bug#10383).
3908
93d5ca1f
JD
39092011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3910
3911 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3912 can scroll.
3913 (create_and_show_popup_menu): Always use menu_position_func for
3914 Gtk3 (Bug#10361).
3915
ca22b785
AS
39162011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3917
3918 * callint.c (Fcall_interactively): Don't truncate prompt string.
3919
d048e1e6
EZ
39202011-12-23 Eli Zaretskii <eliz@gnu.org>
3921
3922 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3923 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3924 resumed from there (after widening). (Bug#10360)
d048e1e6 3925
5ccaba1f
JD
39262011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3927
3928 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3929
204ee57f
JD
39302011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3931
b81d40f0
JB
3932 * nsterm.m (x_free_frame_resources):
3933 Release f->output_data.ns->miniimage.
204ee57f
JD
3934 (ns_index_color): Fix indentation. Do not retain
3935 color_table->colors[i].
3936
3937 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3938 before returning.
3939
3940 * nsfns.m (x_set_background_color): Assign return value from
3941 ns_index_color to face-background instead of NSColor*.
3942 (ns_implicitly_set_icon_type): Fix indentation.
3943 Change assignment in for loop to comparison.
3944
3945 * emacs.c (ns_pool): New variable.
3946 (main): Assign ns_pool.
3947 (Fkill_emacs): Call ns_release_autorelease_pool.
3948
3949 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3950 autorelease fdesc, release fdAttrs and tdict.
3951 (ns_get_covering_families): Release charset.
3952 (ns_findfonts): Release NSFontDescriptor created with new.
3953 (ns_uni_to_glyphs): Fix indentation.
3954 (setString): Release attrStr before assigning new value.
3955
c803b2b7
JD
39562011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3957
678f4426
JD
3958 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3959 and NS_IMPL_COCOA.
3960 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3961 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3962
cd394be1 39632011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3964
5fecd5fc
JD
3965 * nsterm.m (ns_term_init): Subscribe for notifications
3966 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3967 to method trackingNotification in EmacsMenu.
3968
3969 * nsmenu.m (trackingMenu): New variable.
3771cb17 3970 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3971 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3972 from Aquamacs (Bug#7030).
678f4426
JD
3973
39742011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3975
c803b2b7
JD
3976 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3977 (symbol_to_nsstring): Fix indentation.
3978 (ns_symbol_to_pb): New function.
cae07000
SM
3979 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3980 (Fns_rotate_cut_buffers_internal): Remove.
3981 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3982 Fns_store_cut_buffer_internal.
3983 (ns_get_foreign_selection, Fx_own_selection_internal)
3984 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3985 (Fns_get_selection_internal, Fns_store_selection_internal):
3986 Use ns_symbol_to_pb and check if return value is nil.
3987 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3988 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3989 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3990 renamed to Sns_store_selection_internal.
3991 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3992 and remove this function.
3993 (ns_handle_selection_clear): Remove, never used.
3994 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3995 here.
3996
e1b01a3a
KB
39972011-12-17 Ken Brown <kbrown@cornell.edu>
3998
3999 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4000 GID is unknown (Bug#10257).
4001
2adb6e85
PE
40022011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4003
4004 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4005 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4006 which caused a build failure on GNU/Linux IA-64. This problem was
4007 introduced by my 2011-10-07 patch.
4008
d1d7b339
JL
40092011-12-15 Juri Linkov <juri@jurta.org>
4010
4011 * image.c (imagemagick_error): New function. (Bug#10112)
4012 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4013 Use `imagemagick_error' where ImageMagick functions return
4014 `MagickFalse'.
4015 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4016 proper order.
4017
100d5755
KH
40182011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4019
4020 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4021 fill background (Bug#8992).
4022
454592a6
MR
40232011-12-13 Martin Rudalics <rudalics@gmx.at>
4024
4025 * window.c (Vwindow_combination_resize)
4026 (Vwindow_combination_limit): Use t instead of non-nil in
4027 doc-strings.
61d4b438
MR
4028 (Vrecenter_redisplay): Add first sentence of doc-string on
4029 separate line.
53524d93 4030 (Frecenter): Fix doc-string typo.
454592a6 4031
3633e3aa
KH
40322011-12-11 Kenichi Handa <handa@m17n.org>
4033
4034 * coding.c (Funencodable_char_position): Pay attention to the
4035 buffer text relocation (Bug#9389).
4036
7b9d523a 40372011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4038
7b9d523a
JD
4039 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4040 gtk_init (Bug#10100).
4041
b73189c6
EZ
40422011-12-10 Eli Zaretskii <eliz@gnu.org>
4043
4044 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4045 IT->string is nil. (Bug#10263)
4046
f7dfe5d6
JD
40472011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4048
83faebb4
JD
4049 * nsterm.h (x_free_frame_resources): Declare.
4050
f7dfe5d6
JD
4051 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4052 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4053
4054 * nsterm.h (ns_get_defaults_value): Declare.
4055
4056 * nsterm.m (ns_default): Call ns_get_defaults_value.
4057
7cd4e72c
EZ
40582011-12-09 Eli Zaretskii <eliz@gnu.org>
4059
4060 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4061 (Bug#10170)
4062
b34d7317
YM
40632011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4064
4065 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4066 that where the value of an _OBJC_* symbol points to is in the .bss
4067 section (Bug#10240).
4068
76470ad1
KH
40692011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4070
4071 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4072 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4073
745fff94
KH
40742011-12-08 Kenichi Handa <handa@m17n.org>
4075
4076 * ftfont.c (get_adstyle_property): Fix previous change
4077 (Bug#10233).
4078
6e44397c
JB
40792011-12-07 Juanma Barranquero <lekktu@gmail.com>
4080
4081 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4082 dirs from the default value of EMACSLOADPATH (bug#10208).
4083
7efa6272
GM
40842011-12-07 Glenn Morris <rgm@gnu.org>
4085
4086 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4087 installation and source directories as well. (Bug#10208)
4088
f6fc4d87
CY
40892011-12-06 Chong Yidong <cyd@gnu.org>
4090
4091 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4092
2bf26180
GM
40932011-12-06 Glenn Morris <rgm@gnu.org>
4094
4095 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4096 as an error, not just -1. (Bug#10217)
4097
3a6ad4f0
CY
40982011-12-05 Chong Yidong <cyd@gnu.org>
4099
4100 * keyboard.c (process_special_events): New function.
4101 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4102
75a3b399
PE
41032011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4104
4105 * coding.c (encode_designation_at_bol): Don't use uninitialized
4106 local variable (Bug#9318).
4107
c3c9e25e
KH
41082011-12-05 Kenichi Handa <handa@m17n.org>
4109
4110 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4111 return Qnil (Bug#8046, Bug#10193).
4112
5eb05ea3
KH
41132011-12-05 Kenichi Handa <handa@m17n.org>
4114
4115 * coding.c (encode_designation_at_bol): New args charbuf_end and
4116 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4117 (coding_set_source): Return how many bytes coding->source was
4118 relocated.
4119 (coding_set_destination): Return how many bytes
4120 coding->destination was relocated.
4121 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4122 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4123
41242011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4125
4126 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4127 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4128 macro (Bug#9318).
4129
41302011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4131
4132 The following changes are to fix Bug#9318.
4133
a79703f5 4134 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4135 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4136 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4137 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4138
7dbda6df
JB
41392011-12-05 Juanma Barranquero <lekktu@gmail.com>
4140
4141 * lisp.h (process_quit_flag): Fix external declaration.
4142
6d5eb5b0
SM
41432011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4144
4145 Don't macro-inline non-performance-critical code.
4146 * eval.c (process_quit_flag): New function.
4147 * lisp.h (QUIT): Use it.
4148
a0c3fad0
JD
41492011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4150
4151 * nsfns.m (get_geometry_from_preferences): New function.
4152 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4153
6c07aac2
AS
41542011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4155
4156 * emacs.c (Qkill_emacs): Define.
4157 (syms_of_emacs): Initialize it.
4158 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4159 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4160 (quit_throw_to_read_char): Add parameter `from_signal'.
4161 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4162 * lisp.h (QUIT): Call Fkill_emacs if requested.
4163
c052ead4
JD
41642011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4165
4166 * widget.c (update_wm_hints): Return if wmshell is null.
4167 (widget_update_wm_size_hints): New function.
4168
4169 * widget.h (widget_update_wm_size_hints): Declare.
4170
4171 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4172 widget_update_wm_size_hints (Bug#10104).
4173
9e49252b
EZ
41742011-12-03 Eli Zaretskii <eliz@gnu.org>
4175
4176 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4177 before a newline, prepare the bidi iterator for consuming the
4178 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4179 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4180
02b16839
JL
41812011-12-02 Juri Linkov <juri@jurta.org>
4182
4183 * search.c (Fword_search_regexp): New Lisp function created from
4184 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4185 (Fword_search_backward, Fword_search_forward)
4186 (Fword_search_backward_lax, Fword_search_forward_lax):
4187 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4188 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4189
0068070e
SM
41902011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4191
4192 * fileio.c (Finsert_file_contents): Move after-change-function call
4193 to before the "handled:" label, since all "goto handled" appear in
4194 cases where the *-change-functions have already been properly called
4195 (bug#10117).
4196
3360a3fc
AS
41972011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4198
4199 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4200 waiting for input. (Bug#10169)
4201
73d6c093
EZ
42022011-11-30 Eli Zaretskii <eliz@gnu.org>
4203
4204 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4205 verifies glyph row's hash code--we have just reallocated the
4206 glyphs, so their contents can be complete garbage. (Bug#10164)
4207
febe6bea
JB
42082011-11-30 Juanma Barranquero <lekktu@gmail.com>
4209
4210 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4211
801a4313
EZ
42122011-11-30 Eli Zaretskii <eliz@gnu.org>
4213
4214 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4215 attributes are tested _before_ calling verify_row_hash, to protect
4216 against GCC re-ordering of the tests. (Bug#10164)
4217
2b56b87e
JD
42182011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4219
4220 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4221
4222 * xterm.c (handle_one_xevent): Only set async_visible and friends
4223 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4224 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4225 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4226
dbf31225
PE
42272011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4228
4229 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4230 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4231 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4232 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4233 All uses changed to use GCPRO1 etc.
4234 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4235 Revert to old implementation (i.e., before 2011-03-11).
4236
1305621b
YM
42372011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4238
4239 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4240 of scroll runs so as to avoid assigning disabled bogus rows and
4241 unnecessary graphics copy operations.
4242
8c9afb46
EZ
42432011-11-27 Eli Zaretskii <eliz@gnu.org>
4244
4245 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4246 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4247 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4248 (malloc, free, realloc, calloc): Redirect to e_* only when
4249 compiling Emacs.
4250
4251 * lisp.h (GCTYPEBITS): Move before first use.
4252 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4253 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4254 this macro definition.
4255
4256 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4257 _MSC_VER.
4258
54e9e3bf
JD
42592011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4260
6d5eb5b0
SM
4261 * gtkutil.c (xg_create_frame_widgets):
4262 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4263 present with Gtk+ 2.0.
4264
83aca1cb
PE
42652011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4266
4267 * fileio.c (Finsert_file_contents): Undo previous change; see
4268 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4269
5b76caa4
PE
42702011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 Rename locals to avoid shadowing.
4273 * fileio.c (Finsert_file_contents):
4274 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4275 * process.c (wait_reading_process_output):
4276 Rename inner 'proc' to 'p' to avoid shadowing.
4277 Indent for consistency with usual Emacs style.
4278
8c535114
EZ
42792011-11-25 Eli Zaretskii <eliz@gnu.org>
4280
4281 * xdisp.c (redisplay_window): If cursor row is not fully visible
4282 after recentering, and scroll-conservatively is set to a large
4283 number, scroll window by a few more lines to make the cursor fully
4284 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4285 (start_display): Don't move to the next line if the display should
4286 start at a newline that is part of a display vector or an overlay
4287 string. (Bug#10119)
8c535114 4288
fa4fdb5c
JL
42892011-11-24 Juri Linkov <juri@jurta.org>
4290
4291 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4292 after the `MagickPingImage' call. (Bug#10112)
4293
90ec88df
CY
42942011-11-23 Chong Yidong <cyd@gnu.org>
4295
4296 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4297
56e2e794
MR
42982011-11-23 Martin Rudalics <rudalics@gmx.at>
4299
4300 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4301 making another buffer current. (Bug#10114)
4302
b6e64c41
GM
43032011-11-23 Glenn Morris <rgm@gnu.org>
4304
4305 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4306
6b21de18
CY
43072011-11-23 Chong Yidong <cyd@gnu.org>
4308
4309 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4310 using it (Bug#5984).
4311
b12cd789
EZ
43122011-11-22 Eli Zaretskii <eliz@gnu.org>
4313
4314 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4315 and header-lines, as they don't have one computed for them.
4316 (Bug#10098)
4317
4318 * .gdbinit (prow): Make displayed values more self-explaining.
4319 Add row's hash code.
4320
261b6fd4
LMI
43212011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4322
4323 * process.c (wait_reading_process_output): Fix asynchrounous
4324 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4325 (wait_reading_process_output): Add comment and URL.
261b6fd4 4326
e7cfd277
JD
43272011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4328
4329 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4330
a9b9b7f5
CY
43312011-11-21 Chong Yidong <cyd@gnu.org>
4332
4333 * window.c (Fnext_window, Fprevious_window): Doc fix.
4334
b0d15b4f
SM
43352011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4336
4337 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4338
fe7a3057
JB
43392011-11-20 Juanma Barranquero <lekktu@gmail.com>
4340
4341 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4342
d2999b1a
MR
43432011-11-20 Martin Rudalics <rudalics@gmx.at>
4344
4345 * window.c (Fset_window_combination_limit): Rename argument
4346 STATUS to LIMIT.
4347 (Vwindow_combination_limit): Remove "status" from doc-string.
4348
d5ff9cd0
AS
43492011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4350
4351 * m/ibms390.h: Remove.
4352 * m/ibms390x.h: Don't include "ibms390.h".
4353
a5bb9bd3
SM
43542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4355
4356 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4357 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4358
cd1181db
JB
43592011-11-20 Juanma Barranquero <lekktu@gmail.com>
4360
4361 * casetab.c (Fset_case_table):
4362 * charset.c (Fcharset_after): Fix typos.
4363
615a3b8d 43642011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4365
17e845af
PE
4366 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4367 Otherwise, valgrind does not work on some platforms.
4368 Problem reported by Andreas Schwab in
6a0bf43d
PE
4369 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4370 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4371 is set, removing the need for VIRT_ADDRESS_VARIES.
4372 (PURE_P): Use a more-efficient implementation that needs just one
4373 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4374 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4375 to 4 (xorl, subq, cmpq, setbe).
4376 * alloc.c (pure): Always extern now, since that's the
4377 VIRT_ADDR_VARIES behavior.
4378 (PURE_POINTER_P): Use a single comparison, not two, for
4379 consistency with the new puresize.h.
4380 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4381 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4382 Remove VIRT_ADDR_VARIES no longer needed.
4383
f8fe6f96
EZ
43842011-11-19 Eli Zaretskii <eliz@gnu.org>
4385
4386 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4387 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4388 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4389 behave as if the cursor position were at the window margin.
4390
4391 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4392 and the cursor position is out of bounds, behave as if the cursor
4393 position were at the window margin. (Bug#10075)
4394
df05a53c
CY
43952011-11-18 Chong Yidong <cyd@gnu.org>
4396
4397 * window.c (Fwindow_combination_limit): Make first argument
4398 non-optional, since it is meaningless for live windows like the
4399 selected window.
61ccba97 4400
2071918e
DA
44012011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4402
4403 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4404
b50a28de
SM
44052011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4406
4407 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4408 (graft_intervals_into_buffer): Simplify.
4409
015137db
EZ
44102011-11-18 Eli Zaretskii <eliz@gnu.org>
4411
4412 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4413 hash values of the two rows.
4414 (copy_row_except_pointers): Preserve the used[] arrays and the
4415 hash values of the two rows. (Bug#10035)
68c95424 4416 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4417
4418 * xdisp.c (row_hash): New function, body extracted from
4419 compute_line_metrics.
4420 (compute_line_metrics): Call row_hash, instead of computing the
4421 hash code inline.
4422
4423 * dispnew.c (verify_row_hash): Call row_hash for computing the
4424 hash code of a row, instead of duplicating code from xdisp.c.
4425
4426 * dispextern.h (row_hash): Add prototype.
4427
a2addb04
TH
44282011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4429
4430 * frame.c (delete_frame): Don't delete the terminal when the last
4431 X frame is closed if emacs is built with GTK toolkit.
4432
df85d315
JB
44332011-11-17 Juanma Barranquero <lekktu@gmail.com>
4434
4435 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4436
a0c2d0ae
MR
44372011-11-17 Martin Rudalics <rudalics@gmx.at>
4438
4439 * window.c (Vwindow_splits): Rename to
4440 Vwindow_combination_resize. Suggested by Juri Linkov.
4441 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4442 of Vwindow_splits.
4443
58179cce
JB
44442011-11-16 Juanma Barranquero <lekktu@gmail.com>
4445
7877f373
JB
4446 * nsfns.m (Fns_font_name):
4447 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4448
b6f67890
MR
44492011-11-16 Martin Rudalics <rudalics@gmx.at>
4450
4451 * window.h (window): Rename slot "nest" to "combination_limit".
4452 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4453 (Fset_window_nest): Rename to Fset_window_combination_limit.
4454 (Vwindow_nest): Rename to Vwindow_combination_limit.
4455 (recombine_windows, make_parent_window, make_window)
4456 (Fsplit_window_internal, saved_window)
4457 (Fset_window_configuration, save_window_save): Rename all
4458 occurrences of window_nest to window_combination_limit.
4459
c7015153
JB
44602011-11-15 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * image.c (imagemagick_load_image): Fix typo.
4463
322ad6ec
EZ
44642011-11-14 Eli Zaretskii <eliz@gnu.org>
4465
4466 * xdisp.c (display_line): Move the call to
4467 highlight_trailing_whitespace before the call to
4468 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4469 faces of all the glyphs to compute ROW's hash value.
4470 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4471
f067b8ec
JB
44722011-11-14 Juanma Barranquero <lekktu@gmail.com>
4473
4474 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4475 just return (bug#10044).
4476
1e5b2111
EZ
44772011-11-12 Eli Zaretskii <eliz@gnu.org>
4478
7ef3cbd5
EZ
4479 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4480 with user-defined heap size. Bump the default size of the temacs
4481 heap to 27MB, to avoid memory warning when running temacs.
4482 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4483
1e5b2111
EZ
4484 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4485 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4486 (verify_row_hash) [XASSERTS]: New function.
4487 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4488 that the hash value of glyph rows is correct.
1e5b2111 4489
89d61221
MR
44902011-11-12 Martin Rudalics <rudalics@gmx.at>
4491
4492 * window.h (window): Remove splits slot.
4493 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4494 (Fdelete_other_windows_internal, make_parent_window)
4495 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4496 (Fset_window_configuration, save_window_save): Don't deal with
4497 split status of windows.
4498 (saved_window): Remove splits slot.
4499 (Vwindow_splits): Rewrite doc-string.
4500
97f18cc8
JD
45012011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4502
4503 * xfns.c (unwind_create_frame):
4504 * nsfns.m (unwind_create_frame):
4505 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4506 Vframe_list (Bug#9999).
4507
22a648b4
DA
45082011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4509
0b381c7e 4510 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4511
659afede
KH
45122011-11-11 Kenichi Handa <handa@m17n.org>
4513
4514 * callproc.c (Fcall_process): Set the member dst_multibyte of
4515 process_coding.
4516
9ac0394b
KH
45172011-11-11 Johan Bockgård <bojohan@gnu.org>
4518
4519 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4520 avoid a crash (bug#9496).
4521
2fbdc249
CY
45222011-11-09 Chong Yidong <cyd@gnu.org>
4523
4524 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4525 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4526
ac6b1f81
PE
45272011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4528
4529 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4530
09db192c
PE
45312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4532
4533 Avoid some portability problems by eschewing 'extern inline' functions.
4534 The trivial performance wins aren't worth the portability hassles; see
4535 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4536 et seq.
4537 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4538 (window_box_width, window_box_left, window_box_left_offset)
4539 (window_box_right, window_box_right_offset): Undo previous change,
4540 by removing the "extern"s.
4541 * intervals.c (adjust_intervals_for_insertion)
4542 (adjust_intervals_for_deletion): Undo previous change,
4543 making these static again.
4544 (offset_intervals, temp_set_point_both, temp_set_point)
4545 (copy_intervals_to_string): No longer inline.
4546 * xdisp.c (window_text_bottom_y, window_box_width)
4547 (window_box_height, window_box_left_offset)
4548 (window_box_right_offset, window_box_left, window_box_right)
4549 (window_box): No longer inline.
4550
105216ed
CY
45512011-11-08 Chong Yidong <cyd@gnu.org>
4552
4553 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4554 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4555 Signal an error if not a live window.
105216ed
CY
4556 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4557 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4558
ae9e237f
JB
45592011-11-07 Juanma Barranquero <lekktu@gmail.com>
4560
4561 * lisp.h (syms_of_abbrev): Remove declaration.
4562 Reported by CHENG Gao <chenggao@royau.me>.
4563
c7aa8333
EZ
45642011-11-07 Eli Zaretskii <eliz@gnu.org>
4565
4566 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4567 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4568 of temacs in GUI mode.
4569
be7f5545
MR
45702011-11-07 Martin Rudalics <rudalics@gmx.at>
4571
4572 * window.h: Declare delete_all_child_windows instead of
4573 delete_all_subwindows.
4574 * window.c (Fwindow_nest, Fset_window_nest)
4575 (Fset_window_new_total, Fset_window_new_normal)
4576 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4577 (delete_all_subwindows): Rename to delete_all_child_windows.
4578 (Fdelete_other_windows_internal, Fset_window_configuration):
4579 Call delete_all_child_windows instead of delete_all_subwindows.
4580 * frame.c (delete_frame): Call delete_all_child_windows instead
4581 of delete_all_subwindows.
4582
ca78dc43
PE
45832011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4584
4585 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4586 This is also needed for porting to any host where GC_MARK_STACK is
4587 not GC_MAKE_GCPROS_NOOPS.
4588 (which_symbols): Use it.
4589
a0241d01
KH
45902011-11-07 Kenichi Handa <handa@m17n.org>
4591
4592 * coding.c (coding_set_destination): Check coding->src_pos only
4593 when coding->src_object is a buffer (bug#9910).
4594
4595 * process.c (send_process): Set the member src_multibyte of coding
4596 to 0 (bug#9911) when sending a unibyte text.
4597
4598 * callproc.c (Fcall_process): Set the member src_multibyte of
4599 process_coding to 0 (bug#9912).
4600
a64bfdfa 46012011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4602
4603 * xmenu.c (cleanup_widget_value_tree): New function.
4604 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4605 calling free_menubar_widget_value_tree directly (Bug#9830).
4606
cb41b32a
PE
46072011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4608
4609 Fix some portability problems with 'inline'.
4610 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4611 (window_box_width, window_box_left, window_box_left_offset)
4612 (window_box_right, window_box_right_offset): Declare extern.
4613 Otherwise, these inline functions do not conform to C99 and
4614 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4615 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4616 * intervals.c (adjust_intervals_for_insertion)
4617 (adjust_intervals_for_deletion): Now extern, because otherwise the
4618 extern inline functions 'offset_intervals' couldn't refer to it.
4619 (static_offset_intervals): Remove.
4620 (offset_intervals): Rewrite using the old contents of
4621 static_offset_intervals. The old version didn't conform to C99
4622 because an extern inline function contained a reference to an
4623 identifier with static linkage.
4624
b7041366
AS
46252011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4626
4627 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4628 GC.
4629
88a37c4d
EZ
46302011-11-06 Eli Zaretskii <eliz@gnu.org>
4631
4632 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4633 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4634 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4635 return Qleft_to_right.
4636
49745b39
CY
46372011-11-06 Chong Yidong <cyd@gnu.org>
4638
4639 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4640 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4641 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4642 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4643 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4644 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4645 (Fwindow_vscroll): Doc fix.
4646 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4647 argument, since it makes no sense to pass a live window and for
4648 consistency with window-child.
4649
1f05cd82
CS
46502011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4651
4652 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4653 support MSVC.
4654
22610910
JR
46552011-11-05 Jason Rumney <jasonr@gnu.org>
4656
4657 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4658 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4659 fonts (Bug#6029).
4660 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4661 bitwise arithmetic preventing use of unicode-sip and non-truetype
4662 opentype fonts.
4663
a06776b2
EZ
46642011-11-05 Eli Zaretskii <eliz@gnu.org>
4665
3ad924ba
EZ
4666 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4667 "emacs"-only part.
4668
a06776b2
EZ
4669 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4670 initialization code to keep similarity to xfns.c after changes
4671 from 2011-11-05.
4672
c9e7db78
JD
46732011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4674
a97f8f3f
JD
4675 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4676 (unwind_create_frame): New function (Bug#9943).
4677 (Fx_create_frame): Restructure code to be more similar to the one in
4678 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4679 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4680 Move terminal->reference_count++ just before making the frame official
4681 (Bug#9943).
4682
4683 * nsterm.m (x_free_frame_resources): New function.
4684 (x_destroy_window): Move code to x_free_frame_resources.
4685
c9e7db78 4686 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4687 (Fx_create_frame, x_create_tip_frame):
4688 Move terminal->reference_count++ just before making the frame
75f1671a 4689 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4690 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4691
a6fc3b5c
EZ
46922011-11-05 Eli Zaretskii <eliz@gnu.org>
4693
4694 Support MSVC build with newer versions of Visual Studio.
4695 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4696 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4697 nt/gmake.defs.
4698
4699 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4700 which are not supported by MSVC.
4701 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4702 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4703 bitfields.
4704 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4705 types in bitfields.
4706 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4707
4708 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4709
58179cce 47102011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4711
4712 Support MSVC build with newer versions of Visual Studio.
4713 * w32.c: Don't include w32api.h for MSVC.
4714 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4715
4716 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4717 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4718 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4719 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4720 e_* cousins.
4721 (alloca) [_MSC_VER]: Define to _alloca.
4722
4723 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4724
4725 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4726
a58c13ed
EZ
47272011-11-04 Eli Zaretskii <eliz@gnu.org>
4728
4729 * xdisp.c (note_mouse_highlight): If either of
4730 previous/next-single-property-change returns nil, treat that as
4731 the beginning or the end of the buffer. (Bug#9955)
4732
fe0b6370
JD
47332011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4734
a58c13ed 4735 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4736 label is not null (Bug#9951).
4737 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4738 may be NULL.
4739
89bd5ee1
EZ
47402011-11-04 Eli Zaretskii <eliz@gnu.org>
4741
4742 * window.c (Fwindow_body_size): Mention in the doc string that the
4743 return value is in frame's canonical units. (Bug#9949)
4744
84c3edb9
EZ
47452011-11-03 Eli Zaretskii <eliz@gnu.org>
4746
4e2fb5c7
EZ
4747 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4748
84c3edb9 4749 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4750 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4751 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4752
bc17a887
EZ
47532011-11-01 Eli Zaretskii <eliz@gnu.org>
4754
4755 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4756 Don't stop backward scan on the continuation glyph, even though
4757 its CHARPOS is positive.
6d5eb5b0
SM
4758 (mouse_face_from_buffer_pos, note_mouse_highlight):
4759 Rename cover_string to disp_string.
bc17a887 4760
4ee88440
MR
47612011-11-01 Martin Rudalics <rudalics@gmx.at>
4762
4763 * window.c (temp_output_buffer_show): Don't use
4764 Vtemp_buffer_show_specifiers.
4765 (Vtemp_buffer_show_specifiers): Remove unused variable.
4766
c2ff3c02
EZ
47672011-10-30 Eli Zaretskii <eliz@gnu.org>
4768
4769 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4770 past the beginning of the current glyph matrix.
4771
58179cce 47722011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4773
4774 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4775 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4776 HAVE_GTK3 (Bug#9869).
b77a6a7f 4777
3b574623
JD
4778 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4779 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4780
b77a6a7f
JD
4781 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4782
4783 * xterm.c: Declare x_handle_net_wm_state to return int.
4784 (handle_one_xevent): Check if we are iconified but don't have
4785 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4786 (get_current_wm_state): Return non-zero if not hidden,
4787 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4788 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4789 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4790 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4791
196e41e4
PE
47922011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4793
4794 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4795 so that this new function doesn't get optimized away by a
4796 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4797
021f2e1a
AS
47982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4799
4800 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4801
8b058d44
EZ
48022011-10-29 Eli Zaretskii <eliz@gnu.org>
4803
4804 Fix the `xbytecode' command.
4805 * .gdbinit (xprintbytestr): New command.
b50a28de 4806 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4807 (xbytecode): Print the byte-code string as well.
4808
4452fb80
EZ
48092011-10-29 Kim Storm <storm@cua.dk>
4810
8b058d44
EZ
4811 * alloc.c (which_symbols): New function.
4812
21b72067
AS
48132011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4814
4815 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4816 line. (Bug#9903)
4817
83ed7b5c
GM
48182011-10-29 Glenn Morris <rgm@gnu.org>
4819
4820 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4821 Not clear what it was for, and it causes various bugs. (Bug#9839)
4822
5a7a728b
EZ
48232011-10-28 Eli Zaretskii <eliz@gnu.org>
4824
4825 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4826 possible random value that matches one of those tested as
4827 condition to clear the mouse face.
4828
d3d0842f
CY
48292011-10-28 Chong Yidong <cyd@gnu.org>
4830
4831 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4832
31b39d13
DN
48332011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4834
4835 * window.c (make_window): Initialize phys_cursor_on_p.
4836
9aba6043
SM
48372011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4838
4839 * lisp.h (struct Lisp_Symbol): Update comments.
4840
c20992f4
JB
48412011-10-28 Juanma Barranquero <lekktu@gmail.com>
4842
4843 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4844
db4f02f2
EZ
48452011-10-28 Eli Zaretskii <eliz@gnu.org>
4846
4847 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4848 <oslsachem@gmail.com> for helping to debug this.
4849
4850 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4851 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4852 (g_b_init_get_glyph_outline_w): New static variables.
4853 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4854 (GetGlyphOutlineW_Proc): New typedefs.
4855 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4856 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4857 New functions.
4858 (w32font_open_internal, compute_metrics):
4859 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4860 instead of calling the "wide" APIs directly.
4861
4862 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4863
4864 * w32.h (syms_of_w32font): Add prototype.
4865
87e68db4
JB
48662011-10-27 Juanma Barranquero <lekktu@gmail.com>
4867
4868 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4869 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4870 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4871 (Fmove_to_window_line): Doc fix.
4872
435c1d67
CY
48732011-10-27 Chong Yidong <cyd@gnu.org>
4874
4875 * process.c (make_process): Set gnutls_state to NULL.
4876
4877 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4878 non-NULL, regardless of GNUTLS_INITSTAGE.
4879 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4880 an error. Set process slots as soon as we allocate them.
4881
4882 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4883
9c6c6f49
CY
48842011-10-27 Chong Yidong <cyd@gnu.org>
4885
9aba6043
SM
4886 * gnutls.c (emacs_gnutls_deinit): New function.
4887 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4888 (Fgnutls_deinit, Fgnutls_boot): Use it.
4889
4890 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4891 (deactivate_process): Call emacs_gnutls_deinit.
4892
657d08d3
JB
48932011-10-27 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * image.c (x_create_x_image_and_pixmap):
4896 * w32.c (sys_rename, w32_delayed_load):
4897 * w32font.c (fill_in_logfont):
4898 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4899
5430d399
JB
49002011-10-26 Juanma Barranquero <lekktu@gmail.com>
4901
4902 * w32fns.c (w32_default_color_map): New function,
4903 extracted from Fw32_default_color_map.
a7ef684b 4904 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4905
fe0055fa
PE
49062011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4907
4908 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4909
e6346438
SM
49102011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4911
4912 * keyboard.c (test_undefined): New function (bug#9751).
4913 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4914
e112cc37
ET
49152011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4916
4917 * sysdep.c (init_sys_modes): Fix the check for the controlling
4918 terminal (Bug#6649).
4919
7b5d6677
EZ
49202011-10-20 Eli Zaretskii <eliz@gnu.org>
4921
4922 * dispextern.h (struct bidi_it): New member next_en_type.
4923
4924 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4925 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4926 current character, check also for next_en_type being WEAK_EN.
4927 (bidi_resolve_weak): Don't enter the expensive loop if the current
4928 position is before next_en_pos. Record the bidi type of the first
4929 non-ET, non-BN character we find, in addition to its position.
4930 (bidi_level_of_next_char): Invalidate next_en_type when
4931 next_en_pos is over-stepped.
4932
7da0b018
PE
49332011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4934
4935 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4936 * editfns.c: Rewrite current-time-zone so that it invokes
4937 the equivalent of (format-time-string "%Z") to get the time zone name.
4938 This fixes a bug when the time zone name contains characters that
4939 need converting from the system time locale to Emacs internal format.
4940 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4941 that patch fixed format-time-string to do the conversion, but
4942 I forgot to fix current-time-zone.
4943 (format_time_string): New function, containing most of
4944 what Fformat_time_string used to contain.
4945 (Fformat_time_string): Rewrite in terms of format_time_string.
4946 This doesn't change this function's behavior.
4947 (current-time-zone): Rewrite to use format_time_string.
4948 This fixes the bug reported by Michael Schierl in
4949 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4950 Jason Rumney's 2007-06-07 change worked around this bug, but
4951 didn't fix it.
4952 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4953
8547b010
EZ
49542011-10-19 Eli Zaretskii <eliz@gnu.org>
4955
4956 * xdisp.c (start_display): If the character at POS is displayed
4957 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4958 (try_window_reusing_current_matrix): If a line ends in a display
4959 vector or the next line starts in a display vector, continue
4960 redrawing the window even though the character position of
4961 start_row was reached.
8547b010
EZ
4962 (Bug#9771, part 2)
4963
4e948d15
CY
49642011-10-18 Chong Yidong <cyd@gnu.org>
4965
4966 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4967 with nobreak-char-display too.
4968
4787455f
EZ
49692011-10-18 Eli Zaretskii <eliz@gnu.org>
4970
4971 Fix part 3 of bug#9771.
4972 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4973 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4974 non-neutral characters if the current character is a paragraph
4975 separator (a.k.a. Newline). This avoids running the same
4976 expensive loop twice, once when we consume the preceding newline
4977 and the other time when the line actually needs to be displayed.
4978 Avoid the loop when we see neutrals on the base embedding level
4979 following a character whose directionality is the same as the
4980 paragraph's. This avoids running the expensive loop when a line
4981 ends in a long sequence of neutrals, like control characters.
4982 Add assertion against STRONG_AL type. Slightly rearrange code
4983 that determines the type of a neutral given the first non-neutral
4984 that follows it.
4985 (bidi_level_of_next_char): Set next_en_pos to zero when
4986 invalidating its info.
4987
2c91f553
EZ
49882011-10-17 Eli Zaretskii <eliz@gnu.org>
4989
4990 * xdisp.c (push_display_prop): Determine whether to record string
4991 or buffer position by IT->string, not by IT->method. Allow
4992 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4993 (move_it_vertically_backward): Don't look for character position
4994 immediately after the newline when in a continuation line.
4995 (Bug#9771, part 1)
2c91f553 4996
c7b08b0d
MR
49972011-10-15 Martin Rudalics <rudalics@gmx.at>
4998
4999 * window.c (coordinates_in_window): Rewrite and delabelize
5000 vertical border check. (Bug#5357) (Bug#9618)
5001
6b02f655
SM
50022011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5003
5004 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5005 errors in XSetWindowBorder (bug#9310).
5006
81d40c92
DA
50072011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5008
5009 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5010 avoid crash when xmalloc overrun checking is enabled.
5011
d4172c3b
EZ
50122011-10-13 Eli Zaretskii <eliz@gnu.org>
5013
5014 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5015 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5016 cursor motion with <left> and <right> arrow keys.
5017
5018 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5019 some callers set that themselves.
5020
b00eea75
EZ
50212011-10-12 Eli Zaretskii <eliz@gnu.org>
5022
5023 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5024 display string and the previous row comes from the same string and
5025 is empty. (Bug#9739) (Bug#9738)
5026
8fe012c4
SM
50272011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5028
5029 * doc.c (get_doc_string): Encode file name (bug#9735).
5030
0074aef2
EZ
50312011-10-12 Eli Zaretskii <eliz@gnu.org>
5032
79beb178
EZ
5033 * bidi.c (bidi_level_of_next_char):
5034 * xdisp.c (get_visually_first_element): Remove old incorrect
5035 comments regarding the Unicode Line Separator character.
5036
0074aef2
EZ
5037 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5038
6e4b3fbe
DA
50392011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5040
5041 * alloc.c (Fgc_status): Do not access beyond zombies array
5042 boundary if nzombies > MAX_ZOMBIES.
5043 * alloc.c (dump_zombies): Add missing format specifier.
5044
0324f3af
PE
50452011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5046
b5525cac
PE
5047 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5048 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5049
0324f3af
PE
5050 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5051 Some packages use them to denote characters with modifiers.
5052
e9b5f888
AS
50532011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5054
5055 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5056 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5057 matching a pp-number. Rename parameter var to var1.
5058
127827c0
SM
50592011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5060
5061 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5062
c8fd3bd0
GM
50632011-10-08 Glenn Morris <rgm@gnu.org>
5064
5065 * callint.c (Fcall_interactively): Give a more explicit error for the
5066 'c' case with a non-character input. (Bug#8479)
5067
352ec8ff
EZ
50682011-10-08 Eli Zaretskii <eliz@gnu.org>
5069
03669ccb
EZ
5070 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5071 lines.
7061c986
EZ
5072 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5073 lines that are hscrolled on the left.
03669ccb 5074
352ec8ff
EZ
5075 * dispnew.c (buffer_posn_from_coords): Account for a possible
5076 presence of header-line. (Bug#4426)
5077
a66cfb1c
SM
50782011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5079
6b02f655
SM
5080 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5081 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5082
7c5ee88e
PE
50832011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5084
5085 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5086 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5087 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5088 this makes Emacs dump core during garbage collection on rare
5089 occasions. sizeof is obviously inferior to offsetof here, so
5090 stick with offsetof.
5091 (GC_POINTER_ALIGNMENT): New macro.
5092 (mark_memory): Omit 3rd (offset) arg; caller changed.
5093 Don't assume EMACS_INT alignment is the same as pointer alignment.
5094
df1bbe5b
SM
50952011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5096
5097 * keyboard.c (read_key_sequence_remapped): New var.
5098 (read_key_sequence): Compute remapping in the right buffer.
5099 (command_loop_1): Use read_key_sequence's remapping directly.
5100
51553db6
SM
51012011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5102
32c1fffd
SM
5103 * dired.c (file_name_completion): Don't expand file name.
5104 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5105 before checking file name handler.
5106
51553db6
SM
5107 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5108 they've been requested explicitly (bug#9591).
5109
b6bd1599 51102011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5111
5112 * keymap.c (Fsingle_key_description): Use make_specified_string
5113 instead of build_string to build string from push_key_description.
5114 (Bug#5193)
5115
f701dc2a
PE
51162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5117
4222c55d
PE
5118 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5119 This fixes a Y2038 bug on 64-bit hosts.
5120 * buffer.c (reset_buffer):
5121 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5122 (Fclear_buffer_auto_save_failure):
5123 Use 0, not -1, to represent an unset failure time, since time_t
5124 might not be signed.
5125
f701dc2a
PE
5126 Remove dependency on glibc malloc internals.
5127 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5128 Move back here from lisp.h, but with their new implementations.
5129 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5130 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5131 * charset.c (charset_table_init): New static var.
5132 (syms_of_charset): Use it instead of xmalloc. This removes a
5133 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5134 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5135 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5136 Move back to alloc.c.
5137 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5138 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5139
9ceebf39
JD
51402011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5141
5142 * nsterm.m (windowDidResize): Call x_set_window_size only when
5143 ns_in_resize is true. Otherwise set pixelwidth/height and
5144 call change_frame_size (Bug#9628).
5145
cb993c58
PE
51462011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5147
3930c88b
PE
5148 Port --enable-checking=all to Fedora 14 x86-64.
5149 * charset.c (syms_of_charset): Also account for glibc malloc's
5150 internal overhead when calculating the initial malloc maximum.
5151
cb993c58
PE
5152 Port --enable-checking=all to Fedora 14 x86.
5153 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5154 Move to lisp.h.
5155 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5156 (overrun_check_realloc, overrun_check_free):
5157 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5158 That way, xmalloc returns a properly-aligned pointer even if
5159 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5160 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5161 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5162 into account when calculating the initial malloc maximum.
5163 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5164 Move here from alloc.c, so that charset.c can use it too.
5165 Properly align; the old code wasn't right for common 32-bit hosts
5166 when configured with --enable-checking=all.
5167 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5168 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5169
31bed486
EZ
51702011-09-29 Eli Zaretskii <eliz@gnu.org>
5171
04c70788 5172 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5173 use EDOM.
5174
fbcaa2f3
EZ
51752011-09-28 Eli Zaretskii <eliz@gnu.org>
5176
5177 * xdisp.c (compute_display_string_end): If there's no display
5178 string at CHARPOS, return -1.
5179
5180 * bidi.c (bidi_fetch_char): When compute_display_string_end
5181 returns a negative value, treat the character as a normal
5182 character not covered by a display string. (Bug#9624)
5183
a239d4e9
JB
51842011-09-28 Juanma Barranquero <lekktu@gmail.com>
5185
5186 * lread.c (Fread_from_string): Fix typo in docstring.
5187
88652fd5
EZ
51882011-09-27 Eli Zaretskii <eliz@gnu.org>
5189
5190 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5191 newline, reseat the iterator instead of bidi-iterating there one
5192 character at a time. (Bug#9610)
32c1fffd
SM
5193 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5194 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5195
ed497dd4
AS
51962011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5197
5198 * lread.c (readevalloop): Use correct code for NBSP.
5199 (read1): Likewise. (Bug#9608)
5200
b2bf61aa
MA
52012011-09-25 Michael Albinus <michael.albinus@gmx.de>
5202
5203 * dbusbind.c (Fdbus_register_signal): When service is not
5204 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5205
32bbb17c
GM
52062011-09-25 Glenn Morris <rgm@gnu.org>
5207
5208 * buffer.c (truncate-lines): Doc fix.
5209
94e0933e
CY
52102011-09-24 Chong Yidong <cyd@stupidchicken.com>
5211
5212 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5213 (Fset_window_next_buffers): Doc fix.
5214
cddde921
GM
52152011-09-24 Glenn Morris <rgm@gnu.org>
5216
5217 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5218
1260aef1
PE
52192011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5220
25b4bfa0
PE
5221 Fix minor problems found by static checking.
5222 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5223 * indent.c (Fvertical_motion): Fix == vs = typo.
5224
e3cbd34b
EZ
52252011-09-24 Eli Zaretskii <eliz@gnu.org>
5226
a66cfb1c
SM
5227 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5228 Default value is now t. Doc fix.
6bf7006f 5229
e3cbd34b 5230 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5231 logic when moving up, not only when moving down. Fix the
e3cbd34b 5232 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5233 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5234
5235 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5236 CHARPOS is covered by a display string which includes newlines.
5237 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5238 is covered by a display string with embedded newlines.
5239
a3de0cbd
MA
52402011-09-24 Michael Albinus <michael.albinus@gmx.de>
5241
5242 * dbusbind.c (Fdbus_register_signal): Add match rule to
5243 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5244 (Fdbus_register_method, Vdbus_registered_objects_table):
5245 Fix docstring.
a3de0cbd 5246
b260039d
JM
52472011-09-24 Jim Meyering <meyering@redhat.com>
5248
32c1fffd 5249 do not ignore write error for any output size
b260039d
JM
5250 The previous change was incomplete.
5251 While it makes emacs --batch detect the vast majority of stdout
5252 write failures, errors were still ignored whenever the output size is
5253 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5254 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5255 && echo FAIL: ignored write error
5256 FAIL: ignored write error
5257 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5258 && echo FAIL: ignored write error
5259 FAIL: ignored write error
5260 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5261
8eca8a7c
AS
52622011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5263
5264 * emacs.c (Fkill_emacs): In noninteractive mode exit
5265 non-successfully if a write error occurred on stdout. (Bug#9574)
5266
3341db62
EZ
52672011-09-21 Eli Zaretskii <eliz@gnu.org>
5268
5269 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5270 the xassert test.
5271
5272 * dispextern.h (struct it): Update the comment documenting what
5273 can it->OBJECT be.
5274
8c203dbf
EZ
52752011-09-20 Eli Zaretskii <eliz@gnu.org>
5276
5277 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5278 a display string, extend search for cursor position to end of row.
5279 (find_row_edges): If the row ends in a newline from a display
5280 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5281 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5282 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5283 non-empty line. Fixes confusing cursor motion with arrow keys at
5284 the beginning of a line that starts with whitespace.
8c203dbf 5285
a4824228
LMI
52862011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5287
5288 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5289 (bug#9493).
5290
33ed493b
CY
52912011-09-18 Chong Yidong <cyd@stupidchicken.com>
5292
5293 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5294 boolean (Bug#9154).
5295
56cd55c8
EZ
52962011-09-18 Eli Zaretskii <eliz@gnu.org>
5297
5298 * xdisp.c (display_line): Record maximum and minimum buffer
5299 positions even if no glyphs were produced (e.g., by a zero-width
5300 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5301 buffer positions that will be removed from the glyph row because
5302 they don't fit.
c02dcedf
EZ
5303 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5304 column is beyond frame width: don't subtract 1 "pixel" when
5305 computing width of the stretch.
3e62b7e0
EZ
5306 (reseat_at_next_visible_line_start): Undo the change made on
5307 2011-09-17 that saved paragraph information and restored it after
5308 the call to `reseat'. (Bug#9545)
56cd55c8 5309
5ed99d36 53102011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5311
5312 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5313 and turn window cursor on if cleared (Bug#9415).
5314
5ed99d36 53152011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5316
5317 * search.c (boyer_moore): Take unibyte characters from pattern
5318 literally. (Bug#9458)
5319
9bade7b2
EZ
53202011-09-18 Eli Zaretskii <eliz@gnu.org>
5321
5322 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5323
e5e9d610
PE
53242011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5325
87e4427a
PE
5326 Fix minor problem found by static checking.
5327 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5328 initialized, to pacify gcc -Wuninitialized.
5329
e5e9d610
PE
5330 * fileio.c: Report proper errno when syscall falls.
5331 (Finsert_file_contents): Save and restore errno,
5332 so that report_file_error outputs the correct diagnostic.
5333 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5334
a1674f0b
EZ
53352011-09-18 Eli Zaretskii <eliz@gnu.org>
5336
5337 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5338
fbfb6dd4
EZ
53392011-09-17 Eli Zaretskii <eliz@gnu.org>
5340
5341 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5342 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5343
bb187662
EZ
53442011-09-17 Eli Zaretskii <eliz@gnu.org>
5345
1137e8b8 5346 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5347 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5348
5349 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5350 (bidi_find_paragraph_start): Search back for paragraph beginning
5351 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5352 (bidi_move_to_visually_next): Only trigger paragraph-related
5353 computations when the last character is a newline or at EOB, not
5354 just any NEUTRAL_B. (Bug#9470)
5355
bb187662
EZ
5356 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5357 truncated lines if point is covered by a display string. (Bug#9524)
5358
2e621251
PE
53592011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5360
5361 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5362 (cons_to_x_long): New function.
5363 (lisp_data_to_selection_data): Use it. Correct the test for
5364 short-versus-long data; it was negated. Break out of vector
5365 loop, for efficiency, when a long datum is discovered.
5366
91a15bc6
SM
53672011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5368
5369 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5370
b41c3a35
EZ
53712011-09-16 Eli Zaretskii <eliz@gnu.org>
5372
5373 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5374 GCC PR/17406) by declaring this function with external scope.
5375
7812ba2d
PE
53762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5377
5378 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5379 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5380
cf7edc2a
AS
53812011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5382
5383 * editfns.c (Fformat): Correctly handle text properties on "%%".
5384
bd01620e
EZ
53852011-09-15 Eli Zaretskii <eliz@gnu.org>
5386
5387 * xterm.c (x_draw_composite_glyph_string_foreground):
5388 * w32term.c (x_draw_composite_glyph_string_foreground):
5389 * term.c (encode_terminal_code):
5390 * composite.c (composition_update_it, get_composition_id):
5391 * xdisp.c (get_next_display_element)
5392 (fill_composite_glyph_string): Add comments about special meaning
5393 of TAB characters in a composition.
5394
a02719a3
PE
53952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5396
5397 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5398 This occurs when processing a multibyte format.
5399 Problem reported by Wolfgang Jenker.
a02719a3 5400
72589a3c
JB
54012011-09-15 Johan Bockgård <bojohan@gnu.org>
5402
5403 * xdisp.c (try_cursor_movement): Only check for exact match if
5404 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5405
1c14176c
PE
54062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5407
5408 Remove unused external symbols.
5409 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5410 * xdisp.c (calc_pixel_width_or_height): Now static.
5411 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5412 * indent.c (check_display_width):
5413 * w32term.c: Fix comment to match code.
5414 * xterm.c, xterm.h (x_catching_errors): Remove.
5415
d2eea5b5
PE
54162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5417
5418 * xselect.c: Use signed conversions more consistently (Bug#9498).
5419 (selection_data_to_lisp_data): Assume incoming selection data are
5420 signed integers, not unsigned. This is to be consistent with
5421 outgoing selection data, which was modified to use signed integers
5422 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5423 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5424 expects long, not unsigned long.
5425
46888499
EZ
54262011-09-14 Eli Zaretskii <eliz@gnu.org>
5427
5428 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5429 computation of loop end. Reported by Johan Bockgård
5430 <bojohan@gnu.org>.
5431
ef8ef9fb
CY
54322011-09-13 Chong Yidong <cyd@stupidchicken.com>
5433
5434 * frame.c (Fother_visible_frames_p): Function deleted.
5435
fa819fed
EZ
54362011-09-12 Eli Zaretskii <eliz@gnu.org>
5437
5438 * indent.c (compute_motion): Process display vector front to back
5439 rather than the other way around. (Bug#2496)
5440
2ba8e008
SM
54412011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5442
5443 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5444
20f53c69
CY
54452011-09-11 Chong Yidong <cyd@stupidchicken.com>
5446
5447 * minibuf.c (Fread_from_minibuffer): Doc fix.
5448
d562d7a4
EZ
54492011-09-11 Eli Zaretskii <eliz@gnu.org>
5450
5451 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5452 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5453
1c4d7f3d
LMI
54542011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5455
5456 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5457 value for non-existent files.
5458
b885bf36
EZ
54592011-09-11 Eli Zaretskii <eliz@gnu.org>
5460
5461 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5462 set its "size" to -1. This will set the modtime_size field of
5463 the corresponding buffer to -1, which is what
5464 verify-visited-file-modtime expects for files that do not exist.
5465 (Bug#9139)
5466
6612f0bf
PE
54672011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5468
5469 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5470 here ...
5471 * lisp.h: ... from here. push_key_description is no longer
5472 defined in keyboard.c, so its declaration should not be in
5473 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5474 logically belongs with push_key_description.
5475
dfb3f755
PE
54762011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5477
5478 * buffer.h: Include <sys/types.h> instead of <time.h>.
5479 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5480 Problem reported by Herbert J. Skuhra.
5481
3134906c
LMI
54822011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5483
5484 * xml.c (parse_region): Make the parsing work for
5485 non-comment-starting XML files again (bug#9144).
5486
8d903f4e
AS
54872011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5488
5489 * image.c (gif_load): Fix calculation of bottom and right corner.
5490 (Bug#9468)
5491
80ad64f4
EZ
54922011-09-10 Eli Zaretskii <eliz@gnu.org>
5493
5494 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5495 redisplay in small windows.
5496
208a048d
EZ
54972011-09-09 Eli Zaretskii <eliz@gnu.org>
5498
5499 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5500
9b1c252e
MR
55012011-09-08 Martin Rudalics <rudalics@gmx.at>
5502
5503 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5504 Operate on live windows only.
5505
2949f33b
JB
55062011-09-08 Juanma Barranquero <lekktu@gmail.com>
5507
5508 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5509
e08dcafd
EZ
55102011-09-07 Eli Zaretskii <eliz@gnu.org>
5511
5512 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5513 only under bidi iteration.
5514
115b96bd
JD
55152011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5516
5517 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5518
c8199d0f
PE
55192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5520
5521 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5522 Without this fix, the command to link temacs failed due to an
5523 undefined symbol __builtin_isnan. This is because
5524 /usr/include/iso/math_c99.h #defines isnan(x) to
5525 __builtin_isnan(x), but the bundled gcc, which identifies itself
5526 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5527 a __builtin_isnan.
5528 * floatfns.c (isnan): #undef, and then #define to a clone of
5529 what's in data.c.
5530 (Fisnan): Always define, since it's always available now.
5531 (syms_of_floatfns): Always define isnan at the Lisp level.
5532
e39b275c 55332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5534
5535 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5536
b2db44d9 55372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5538
f4af5137 5539 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5540 The previous code assumed that file offsets (off_t values) fit in
5541 EMACS_INT variables, which is not true on typical 32-bit hosts.
5542 The code messed up by falsely reporting buffer overflow in cases
5543 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5544 when "big" contains more than 2**29 bytes, even though this
5545 inserts just one byte and does not overflow the buffer.
5546 (Finsert_file_contents): Store file offsets as off_t
5547 values, not as EMACS_INT values. Check for overflow when
5548 converting between EMACS_INT and off_t. When checking for
5549 buffer overflow or for overlap, take the offsets into account.
5550 Don't use EMACS_INT for small values where int suffices.
5551 When checking for overlap, fix a typo: ZV was used where
5552 ZV_BYTE was intended.
5553 (Fwrite_region): Don't assume off_t fits into 'long'.
5554 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5555
ecfc0a49
MA
55562011-09-05 Michael Albinus <michael.albinus@gmx.de>
5557
5558 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5559
6511acf2 55602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5561
0999621a 5562 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5563
5564 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5565 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5566 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5567 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5568 (modify_event_symbol): Do not assume that the length of
5569 name_alist_or_stem is safe to alloca and fits in int.
5570 (Fexecute_extended_command): Likewise for function name and binding.
5571 (Frecursion_depth): Wrap around reliably on integer overflow.
5572 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5573 since some callers pass EMACS_INT values.
5574 (Fsingle_key_description): Don't crash if symbol name contains more
5575 than MAX_ALLOCA bytes.
5576 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5577 (get_minibuffer): Arg is now EMACS_INT, not int.
5578 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5579 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5580 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5581
2be7d702
PE
5582 * dbusbind.c (signature_cat): New function.
5583 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5584 Do not overrun buffer; instead, report string overflow.
5585
9d1df220
PE
5586 * dispnew.c (add_window_display_history): Don't overrun buffer.
5587 Truncate instead; this is OK since it's just a log.
5588
33ef5c64
PE
5589 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5590 even if the time zone offset is outlandishly large.
5591 Don't mishandle offset == INT_MIN.
5592
66c6fdd5
PE
5593 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5594 when creating daemon; the previous buffer-overflow check was incorrect.
5595
d749b01b
PE
5596 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5597 which has the guts of the old verror function.
5598
b5cd1905
PE
5599 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5600 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5601
6e1a67fb
PE
5602 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5603 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5604 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5605 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5606 length of string rather than counting it via multiple sprintfs;
5607 that's simpler and more reliable.
c21721cc
PE
5608 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5609 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5610 sprintf, in case result does not fit in int.
5611
c57b67fc
PE
5612 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5613 (fontset_from_font): Print it.
5614
8a401434
PE
5615 * frame.c (tty_frame_count): Now printmax_t, not int.
5616 (make_terminal_frame, set_term_frame_name): Print it.
5617 (x_report_frame_params): In X, window IDs are unsigned long,
5618 not signed long, so print them as unsigned.
5619 (validate_x_resource_name): Check for implausibly long names,
5620 and don't assume name length fits in 'int'.
5621 (x_get_resource_string): Don't blindly alloca invocation name;
5622 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5623 not fit in int.
5624
6e1a67fb
PE
5625 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5626 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5627 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5628
0df02bf3
PE
5629 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5630 Use esprintf, not sprintf, in case result does not fit in int.
5631
48e30793
PE
5632 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5633 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5634 it as a large positive number.
5635 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5636 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5637
a66ff6d8
PE
5638 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5639 in case result does not fit in int.
5640
aca216ff
PE
5641 * print.c (float_to_string): Detect width overflow more reliably.
5642 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5643 buffer overrun. Don't assume list length fits in 'int'. Treat
5644 print length of 0 as 0, not as infinity; to be consistent with other
5645 uses of print length in this function. Don't overflow print length
5646 index. Don't assume hash table size fits in 'long', or that
5647 vectorlike size fits in 'unsigned long'.
5648
31c286f7
PE
5649 * process.c (make_process): Use printmax_t, not int, to format
5650 process-name gensyms.
5651
55e5faa1
PE
5652 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5653
80f2e268
PE
5654 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5655 to avoid potential buffer overrun.
5656
670741ab
PE
5657 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5658 if X resource line is longer than 512 bytes.
5659
b7163a50
PE
5660 * xfns.c (x_window): Make sprintf buffer a bit bigger
5661 to avoid potential buffer overrun.
5662
ae58ff1f
PE
5663 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5664
c43c8a6a
PE
5665 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5666
3f8236f4
PE
56672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5668
53e9fe90 5669 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5670 Without these, Emacs silently mishandles large integers sometimes.
5671 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5672 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5673
6511acf2
PE
5674 * xdisp.c (try_window_id): Check Emacs fixnum range before
5675 converting to 'int'.
806add1d 5676
6511acf2 5677 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5678 Check that an Emacs fixnum is in range before assigning it to 'int'.
5679 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5680 values converted from Emacs fixnums.
5681 (Frecenter): Don't wrap around a line count if it is out of 'int'
5682 range; instead, treat it as an extreme value.
5683 (Fset_window_configuration, compare_window_configurations):
5684 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5685
6511acf2
PE
5686 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5687 that can exceed INT_MAX. Check that EMACS_INT value is in range
5688 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5689 (match_limit): Don't assume that a fixnum can fit in 'int'.
5690
6511acf2 5691 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5692 exceed INT_MAX.
5693
6511acf2 5694 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5695 (Fvertical_motion): Don't wrap around LINES values that don't fit
5696 in 'int'. Instead, treat them as extreme values. This is good
5697 enough for windows, which can't have more than INT_MAX lines anyway.
5698
fcb901a7
LMI
56992011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5700
0f2f6b6d
LMI
5701 * Require libxml/parser.h to avoid compilation warning.
5702
fcb901a7
LMI
5703 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5704
5705 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5706 since this reportedly can destroy thread storage.
5707
6e20a0d4
CY
57082011-08-30 Chong Yidong <cyd@stupidchicken.com>
5709
5710 * syntax.c (find_defun_start): Update all cache variables if
5711 exiting early (Bug#9401).
5712
148ae00e
EZ
57132011-08-30 Eli Zaretskii <eliz@gnu.org>
5714
f6cfbd8f
EZ
5715 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5716
148ae00e
EZ
5717 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5718 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5719 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5720
5721 * term.c (tty_append_glyph): New function.
5722 (produce_stretch_glyph): Static function and its prototype deleted.
5723
a66cfb1c
SM
5724 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5725 Add prototypes.
148ae00e 5726
c4a07a4c
PE
57272011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5730 when checking :margin (Bug#9390).
5731 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5732 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5733 so that the name doesn't mislead. All uses changed.
5734
6bc8cd65
JB
57352011-08-28 Johan Bockgård <bojohan@gnu.org>
5736
5737 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5738 set_tty_hooks.
5739
dca4927e
EZ
57402011-08-27 Eli Zaretskii <eliz@gnu.org>
5741
5742 * xdisp.c (move_it_to): Don't bail out early when reaching
5743 position beyond to_charpos, if we are scanning backwards.
5744 (move_it_vertically_backward): When DY == 0, make sure we get to
5745 the first character in the line after the newline.
5746
f2cad773
PE
57472011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5748
5749 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5750 (ccl_driver): Do not generate an out-of-range pointer.
5751 (Fccl_execute_on_string): Remove unnecessary check for
5752 integer overflow, noted by Stefan Monnier in
5753 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5754 Remove a FIXME that didn't need fixing.
5755 Simplify the newly-introduced buffer reallocation code.
5756
0cae2cdb
JB
57572011-08-27 Juanma Barranquero <lekktu@gmail.com>
5758
5759 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5760
5fc295a4 57612011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5762
70c60eb2 5763 Integer and memory overflow issues (Bug#9196).
726e0ab1 5764
d31850da
PE
5765 * doc.c (get_doc_string): Rework so that
5766 get_doc_string_buffer_size is the actual buffer size, rather than
5767 being 1 less than the actual buffer size; this makes xpalloc more
5768 convenient.
5769
a69fbedb
PE
5770 * image.c (x_allocate_bitmap_record, cache_image):
5771 * xselect.c (Fx_register_dnd_atom):
5772 Simplify previous changes by using xpalloc.
5773
fe5c5d37
PE
5774 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5775 since either will do and ptrdiff_t is convenient with xpalloc.
5776
0065d054
PE
5777 * charset.c (charset_table_size)
5778 (struct charset_sort_data.priority): Now ptrdiff_t.
5779 (charset_compare): Don't overflow if priorities differ greatly.
5780 (Fsort_charsets): Don't assume list length fits in int.
5781 Check for size-calculation overflow when allocating sort data.
5782 (syms_of_charset): Allocate an initial charset table that is
5783 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5784
5785 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5786
5787 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5788 The actual value is always <= INT_MAX, and leaving it unsigned made
5789 overflow checking harder.
5790
5791 * dispextern.h (struct glyph_matrix.rows_allocated)
5792 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5793 with xpalloc. The values are still always <= INT_MAX.
5794
5795 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5796
5797 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5798 (SAFE_NALLOCA): New macro.
5799
5800 * region-cache.c (struct boundary.pos, find_cache_boundary)
5801 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5802 (set_cache_region, invalidate_region_cache)
5803 (revalidate_region_cache, know_region_cache, region_cache_forward)
5804 (region_cache_backward, pp_cache):
5805 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5806 so that ptrdiff_t * can be passed to xpalloc.
5807 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5808 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5809 (pp_cache): Don't assume cache_len fits in int.
5810 * region-cache.h: Adjust extern decls to match.
5811
5812 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5813 EMACS_INT, since either will do, for xpalloc.
5814
5815 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5816 (xnmalloc, xnrealloc, xpalloc): New functions.
5817
726e0ab1
PE
5818 * bidi.c (bidi_shelve_header_size): New constant.
5819 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5820 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5821
51f30bc5 5822 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5823 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5824 (overlay_strings):
5825 Don't update size of array until after memory allocation succeeds,
5826 because xmalloc/xrealloc may not return.
0065d054
PE
5827 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5828 now that we have proper integer overflow checking.
5829 (record_overlay_string, overlay_strings): Catch overflows when
5830 calculating size of overlay_str_buf.
726e0ab1 5831
0065d054
PE
5832 * callproc.c (Fcall_process): Check for size overflow when
5833 calculating size of args2.
5834 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5835 Normally we prefer signed values, but sticking with ptrdiff_t would
5836 require adding more-complicated checks.
726e0ab1
PE
5837
5838 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5839 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5840 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5841 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5842
5843 * character.c (Fstring): Check for size-calculation overflow.
5844
5845 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5846 unnecessary integer overflow. Check for size overflow.
5847 (encode_coding_object): Don't update size until xmalloc succeeds.
5848
5849 * composite.c (get_composition_id): Check for overflow in glyph
5850 length calculations.
5851
5852 Integer and memory overflow fixes for display code.
5853 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5854 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5855 (scrolling_window): Check for overflow in size calculations.
5856 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5857 Don't assume glyph table len fits in int.
5858 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5859 (row_table_size): Now ptrdiff_t, not int.
5860 (scrolling_window): Avoid overflow in size calculations.
5861 Don't update size until allocation succeeds.
5862 * fns.c (concat): Check for overflow in size calculations.
5863 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5864 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5865 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5866
5867 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5868 (get_doc_string): Check for size calculation overflow.
5869 Don't update size until allocation succeeds.
5870 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5871 EMACS_INT, where ptrdiff_t will do.
5872 (Fsubstitute_command_keys): Check for string overflow.
5873
5874 * editfns.c (set_time_zone_rule): Don't assume environment length
5875 fits in int.
5876 (message_length): Now ptrdiff_t, not int.
5877 (Fmessage_box): Don't update size until allocation succeeds.
5878 Don't assume message length fits in int.
5879 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5880
0065d054
PE
5881 * emacs.c (main): Do not reallocate argv, since there is a null at
5882 the end that can be overwritten, and this way there's no need to
5883 worry about size-calculation overflow.
5884 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5885
5886 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5887 alloc succeeds.
5888 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5889
5890 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5891 (x_set_scroll_bar_width, x_figure_window_size):
5892 Check for integer overflow.
5893 (x_set_alpha): Do not assume XINT fits in int.
5894
5895 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5896 This is for the members text_lines, text_cols, total_lines, total_cols,
5897 where the system imposes an 'int' limit.
5898
5899 * fringe.c (Fdefine_fringe_bitmap):
5900 Don't update size until alloc works.
5901
5902 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5903 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5904
5905 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5906 Check for size-calculation overflow.
5907 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5908 do, as we prefer signed integers.
5909 (id_to_widget.max_size, id_to_widget.used)
5910 (xg_store_widget_in_map, xg_remove_widget_from_map)
5911 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5912 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5913 Use and return ptrdiff_t, not int.
5914 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5915 * gtkutil.h: Change prototypes to match the above.
5916
5917 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5918 are duplicate now that they've been promoted to lisp.h.
5919 (x_allocate_bitmap_record, x_alloc_image_color)
5920 (make_image_cache, cache_image, xpm_load):
5921 Don't update size until alloc is done.
5922 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5923 (x_detect_edges):
3256efce 5924 Check for size calculation overflow.
726e0ab1
PE
5925 (ct_colors_allocated_max): New constant.
5926 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5927 overflow.
3256efce 5928
726e0ab1
PE
5929 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5930 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5931 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5932 Use ptrdiff_t, not int, to count maps.
5933 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5934 calculations. Don't update size until allocation succeeds.
5935 Redo calculations to avoid overflow.
726e0ab1
PE
5936 * keyboard.h: Change prototypes to match the above.
5937
5938 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5939 to count maps.
5940 (current_minor_maps): Check for size calculation overflow.
5941 * keymap.h: Change prototypes to match the above.
5942
5943 * lread.c (read1, init_obarray): Don't update size until alloc done.
5944
5945 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5946 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5947
726e0ab1
PE
5948 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5949 Now ptrdiff_t, not int.
5950 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5951 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5952
5953 * process.c (Fnetwork_interface_list): Check for overflow
5954 in size calculation.
5955
5956 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5957
5958 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5959 overflow. Don't bother calling xmalloc when xrealloc will do.
5960
5961 * search.c (Freplace_match): Check for size calculation overflow.
5962 (Fset_match_data): Don't assume list lengths fit in 'int'.
5963
5964 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5965 for command line length. Do not attempt to address one before the
5966 beginning of an array, as that's not portable.
5967
5968 * term.c (max_frame_lines): Remove; unused.
5969 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5970 not int.
5971 (encode_terminal_code, calculate_costs): Check for size
5972 calculation overflow.
5973 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5974 table lengths and related sizes. Don't update size until alloc
5975 done. Redo calculations to avoid overflow.
5976 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5977
5978 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5979 subtracting pointers.
5980 (gobble_line): Check for overflow more carefully. Don't update size
5981 until alloc done.
5982
5983 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5984 Don't update size until alloc done.
5985 Redo size calculations to avoid overflow.
5986 Check for size calculation overflow.
0065d054 5987 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5988
5989 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5990 Use ptrdiff_t, not int, for sizes.
5991 (store_mode_line_noprop_char): Don't update size until alloc done.
5992
0065d054
PE
5993 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5994 Use ptrdiff_t, not int, for sizes.
5995 (Finternal_make_lisp_face, cache_face):
5996 Check for size calculation overflow.
5997 (cache_face): Treat size calculation overflows as if they were
5998 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5999
6000 * xfns.c (x_encode_text, x_set_name_internal)
6001 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6002 sizes, since they can exceed INT_MAX in size. Check for size
6003 calculation overflow.
6004
0065d054
PE
6005 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6006 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6007 Don't update size until alloc done.
6008
0065d054 6009 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6010 as sprintf is limited to int lengths.
1d526e2f 6011
252c5ee1
PE
6012 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6013 (X_LONG_MIN): New macros.
864d7ce7
PE
6014 Use them to make the following changes clearer.
6015 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6016 This change doesn't affect the value now, but it may help remind
6017 future maintainers not to raise the value too much later.
6018 (SELECTION_QUANTUM): Remove, replacing with ...
6019 (selection_quantum): ... new function, which avoids overflow.
6020 All uses changed.
6021 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6022 assumption that selection length fits in 'int'.
6023 (x_reply_selection_request, x_handle_selection_request)
6024 (x_get_window_property, receive_incremental_selection)
6025 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6026 (lisp_data_to_selection_data, clean_local_selection_data):
6027 Use ptrdiff_t, not int, to record length of selection.
6028 (x_reply_selection_request, x_get_window_property)
6029 (receive_incremental_selection, x_property_data_to_lisp):
6030 Redo calculations to avoid overflow.
6031 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6032 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6033 something.
6034 (x_get_window_property, receive_incremental_selection)
6035 (lisp_data_to_selection_data, x_property_data_to_lisp):
6036 Check for size-calculation overflow.
6037 (x_get_window_property, receive_incremental_selection)
6038 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6039 Don't store size until memory allocation succeeds.
6040 (x_get_window_property): Plug memory leak on memory exhaustion.
6041 Don't double-block input; malloc is safe here. Don't assume 2**34
6042 - 4 fits in unsigned long. Add an xassert to check
6043 XGetWindowProperty overflow. Be more careful about overflow
6044 calculations, and distinguish size from memory overflow better.
6045 (receive_incremental_selection): When tracing, don't assume
6046 unsigned int is less than INT_MAX.
6047 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6048 harmful) conversions of unsigned short to int.
6049 (lisp_data_to_selection_data): Don't assume that integers
6050 in the range -65535 through -1 fit in an X unsigned short.
6051 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6052 result parameters unless successful. Rely on cons_to_unsigned
6053 to report problems with elements; the old code wasn't right anyway.
6054 (x_check_property_data): Check for int overflow; we cannot use
6055 a wider type due to X limits.
6056 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6057
726e0ab1 6058 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6059
0065d054
PE
6060 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6061 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6062 (x_color_cells): Don't store size until memory allocation succeeds.
6063 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6064 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6065 (x_term_init): Don't assume length fits in int (sprintf is limited
6066 to int size).
bc18e09d 6067
ebfa62c0
PE
6068 Use ptrdiff_t for composition IDs.
6069 * character.c (lisp_string_width):
6070 * composite.c (composition_table_size, n_compositions)
6071 (get_composition_id, composition_gstring_from_id):
6072 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6073 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6074 * window.c (Frecenter):
6075 Use ptrdiff_t, not int, for composition IDs.
6076 * composite.c (get_composition_id): Check for integer overflow.
6077 * composite.h: Adjust prototypes to match the above changes.
6078
d3411f89
PE
6079 Use ptrdiff_t for hash table indexes.
6080 * category.c (hash_get_category_set):
6081 * ccl.c (ccl_driver):
6082 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6083 * coding.c (coding_system_charset_list, detect_coding_system):
6084 * coding.h (struct coding_system.id):
6085 * composite.c (get_composition_id, gstring_lookup_cache):
6086 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6087 * image.c (xpm_get_color_table_h):
6088 * lisp.h (hash_lookup, hash_put):
6089 * minibuf.c (Ftest_completion):
6090 Use ptrdiff_t for hash table indexes, not int (which is too
6091 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6092 32-bit --with-wide-int hosts).
6093
e097a6fa
PE
6094 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6095 Add a FIXME comment about memory leaks.
6096 (syms_of_charset): Don't assume xmalloc returns.
6097
5637687f
PE
6098 Don't assume that stated character widths fit in int.
6099 * character.c (Fchar_width, c_string_width, lisp_string_width):
6100 * character.h (CHAR_WIDTH):
6101 * indent.c (MULTIBYTE_BYTES_WIDTH):
6102 Use sanitize_char_width to avoid undefined and/or bad behavior
6103 with outlandish widths.
a66cfb1c 6104 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6105 now that we have two such functions. All uses changed.
6106 (sanitize_char_width): New inline function.
6107
a2271ba2
PE
6108 Don't assume that tab-width fits in int.
6109 * character.h (sanitize_width): New inline function.
6110 (SANE_TAB_WIDTH): New macro.
6111 (ASCII_CHAR_WIDTH): Use it.
6112 * indent.c (sane_tab_width): Remove. All uses replaced by
6113 SANE_TAB_WIDTH (current_buffer).
6114 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6115
18c52557
PE
6116 * fileio.c: Integer overflow issues with file modes.
6117 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6118
caeeedc1
PE
6119 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6120 Remove unreachable code.
6121 (read_hex, load_charset_map_from_file): Check for integer overflow.
6122
6df6ae42 6123 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6124 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6125 (x_send_scroll_bar_event): Likewise. Check that the size does not
6126 exceed limits imposed by XClientMessageEvent, as well as the usual
6127 ptrdiff_t and size_t limits.
6128
b13995db
PE
6129 * keyboard.c: Overflow, signedness and related fixes.
6130 (make_lispy_movement): Use same integer type in forward decl
6131 that is used in the definition.
6132 (read_key_sequence, keyremap_step):
6133 Change bufsize argument back to int, undoing my 2011-03-30 change.
6134 We prefer signed types, and int is wide enough here.
6135 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6136 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6137 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6138 length, not size_t. Use ptrdiff_t for index, not int.
6139 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6140 possibility of integer overflow.
6141
13464394
PE
6142 Overflow, signedness and related fixes for images.
6143
6144 * dispextern.h (struct it.stack[0].u.image.image_id)
6145 (struct_it.image_id, struct image.id, struct image_cache.size)
6146 (struct image_cache.used, struct image_cache.ref_count):
6147 * gtkutil.c (update_frame_tool_bar):
6148 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6149 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6150 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6151 * nsmenu.m (update_frame_tool_bar):
6152 * xdisp.c (calc_pixel_width_or_height):
6153 * xfns.c (image_cache_refcount):
6154 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6155 on typical 64-bit hosts.
6156
6157 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6158 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6159 Omit unnecessary casts to int.
6160 (parse_image_spec): Check that integers fall into 'int' range
6161 when the callers expect that.
6162 (image_ascent): Redo ascent calculation to avoid int overflow.
6163 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6164 (lookup_image): Remove unnecessary tests.
6165 (xbm_image_p): Locals are now of int, not EMACS_INT,
6166 since parse_image_check makes sure they fit into int.
6167 (png_load, gif_load, svg_load_image):
6168 Prefer int to unsigned where either will do.
6169 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6170 old tiff_error_handler and tiff_warning_handler.
6171 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6172 stack buffer overflows. It uses only the features of vsnprintf
6173 that are common to both POSIX and native Microsoft.
6174 (tiff_error_handler, tiff_warning_handler): Use it.
6175 (tiff_load, gif_load, imagemagick_load_image):
6176 Don't assume :index value fits in 'int'.
6177 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6178 (imagemagick_load_image): Check that crop parameters fit into
6179 the integer types that MagickCropImage accepts. Don't assume
6180 Vimagemagick_render_type has a nonnegative value. Don't assume
6181 size_t fits in 'long'.
6182 (gs_load): Use printmax_t to print the widest integers possible.
6183 Check for integer overflow when computing image height and width.
6184
c11821d4
EZ
61852011-08-26 Eli Zaretskii <eliz@gnu.org>
6186
6187 * xdisp.c (redisplay_window): Don't force window start if point
6188 will be invisible in the resulting window. (Bug#9324)
6189
0c95fcf7
EZ
61902011-08-25 Eli Zaretskii <eliz@gnu.org>
6191
6192 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6193 the display spec is of the form `(space ...)'.
6194 (handle_display_spec): Return the value returned by
6195 handle_single_display_spec, not just 1 or zero.
6196 (handle_single_display_spec): If the display spec is of the form
6197 `(space ...)', and specifies display in the text area, return 2
6198 rather than 1.
fee65a97 6199 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6200 accurately, and prefer exact match for point under bidi.
6201 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6202
6203 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6204 into disp_prop; all users changed.
6205
6206 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6207 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6208 for the text covered by the display property.
6209
e4ed06f1
CY
62102011-08-25 Chong Yidong <cyd@stupidchicken.com>
6211
6212 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6213 Change return value to nil.
6214 (Frecord_buffer): Delete unused function.
6215
f67cdd7f
EZ
62162011-08-24 Eli Zaretskii <eliz@gnu.org>
6217
5980d4c6
EZ
6218 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6219 buffers, return left-to-right.
8610fe8b
EZ
6220 (set_cursor_from_row): Consider candidate row a win if its glyph
6221 represents a newline and point is on that newline. Fixes cursor
6222 positioning on the newline at EOL of R2L text within L2R
6223 paragraph, and vice versa.
6224 (try_cursor_movement): Check continued rows, in addition to
6225 continuation rows. Fixes unwarranted scroll when point enters a
6226 continued line of R2L text within an L2R paragraph, or vice versa.
6227 (cursor_row_p): Consider the case of point being equal to
6228 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6229 from the end of a short line to the beginning of a continued line
6230 of R2L text within L2R paragraph.
6231 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6232 composed characters.
5980d4c6 6233
f67cdd7f
EZ
6234 * bidi.c (bidi_check_type): Use xassert.
6235 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6236 members.
6237
bca633fb
EZ
62382011-08-23 Eli Zaretskii <eliz@gnu.org>
6239
6240 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6241 a character.
6242
4a5885a7
CY
62432011-08-23 Chong Yidong <cyd@stupidchicken.com>
6244
6245 * nsfont.m (ns_otf_to_script): Fix typo.
6246
0902a04e
KH
62472011-08-22 Kenichi Handa <handa@m17n.org>
6248
6249 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6250 extra slot even if the purpose is char-code-property-table.
6251
1a2e6670
EZ
62522011-08-23 Eli Zaretskii <eliz@gnu.org>
6253
8ddde651
EZ
6254 * xdisp.c (redisplay_window): When computing centering_position,
6255 account for the height of the header line. (Bug#8874)
6256
425cc014
EZ
6257 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6258 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6259 candidate is selected by the mouse, and that candidate has a
6260 composed character under the mouse.
6261
1a2e6670
EZ
6262 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6263 coordinates reported by pos-visible-in-window-p for a composed
6264 character in column zero.
6265
8b76d6f8
SM
62662011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6267
6268 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6269
dac347dd
EZ
62702011-08-22 Eli Zaretskii <eliz@gnu.org>
6271
6272 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6273 consider it a hit if to_charpos is anywhere in the range of the
6274 composed buffer positions.
6275
e013fb34
CY
62762011-08-22 Chong Yidong <cyd@stupidchicken.com>
6277
6278 * image.c (gif_load): Don't assume that each subimage has the same
6279 dimensions as the base image. Handle disposal method that is
6280 "undefined" by the gif spec (Bug#9335).
6281
bd1ba3e8
CY
62822011-08-20 Chong Yidong <cyd@stupidchicken.com>
6283
6284 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6285 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6286
54a1215b
EZ
62872011-08-19 Eli Zaretskii <eliz@gnu.org>
6288
823564e5
EZ
6289 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6290 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6291 from an Org mode buffer to a Speedbar frame.
6292
54a1215b
EZ
6293 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6294 a composition, take its buffer position from IT->cmp_it.charpos.
6295 Fixes cursor positioning at the beginning of a line that begins
6296 with a composed character.
6297
9778ebcc
EZ
62982011-08-18 Eli Zaretskii <eliz@gnu.org>
6299
0be6ee06
EZ
6300 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6301 character bidirectional type, use STRONG_L instead. Fixes crashes
6302 in a buffer produced by `describe-categories'.
6303
9778ebcc
EZ
6304 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6305 members before the level stack, so they would be saved and
6306 restored when copying iterator state. Fixes incorrect reordering
6307 around TABs covered by display properties.
6308
156bffbe
AS
63092011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6310
6b02f655 6311 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6312
72ad093b
CY
63132011-08-17 Chong Yidong <cyd@stupidchicken.com>
6314
6315 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6316 (internal_condition_case_2, internal_condition_case_n):
6317 Remove unnecessary aborts (Bug#9081).
72ad093b 6318
35774242
EZ
63192011-08-17 Eli Zaretskii <eliz@gnu.org>
6320
6321 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6322 has no `load' handler, try opening the file locally. (Bug#9311)
6323
db76dd85
KB
63242011-08-16 Ken Brown <kbrown@cornell.edu>
6325
6326 * gmalloc.c: Expand comment.
6327
b215eee5
EZ
63282011-08-16 Eli Zaretskii <eliz@gnu.org>
6329
6330 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6331 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6332
a4579d33
KB
63332011-08-16 Ken Brown <kbrown@cornell.edu>
6334
6335 Fix memory allocation problems in Cygwin build (Bug#9273).
6336
6337 * unexcw.c ( __malloc_initialized): Declare external variable.
6338 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6339
8b76d6f8
SM
6340 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6341 New variables.
a4579d33
KB
6342 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6343 dumped emacs.
6344 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6345 in the static heap.
6346 [CYGWIN] (special_realloc): New function.
6347 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6348 requests to realloc storage in the static heap.
6349
3ebec551
PE
63502011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6351
6352 * bidi.c (bidi_initialize): Remove unused local.
6353
9fd8be00
EZ
63542011-08-15 Eli Zaretskii <eliz@gnu.org>
6355
6b02f655
SM
6356 * bidimirror.h:
6357 * biditype.h: Remove file.
6358 * makefile.w32-in ($(BLD)/bidi.$(O)):
6359 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6360
6361 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6362
6363 * chartab.c: Improve commentary for the uniprop_table API.
6364
32413314
EZ
6365 * bidi.c (bidi_paragraph_init): Support zero value of
6366 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6367 (bidi_initialize): Use uniprop_table instead of including
6368 biditype.h and bidimirror.h.
32413314 6369
9fd8be00
EZ
6370 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6371 coordinates of the iterator when restoring from ppos_it.
6372 (Bug#9296)
6373
5cf2b69b
KH
63742011-08-14 Kenichi Handa <handa@m17n.org>
6375
6376 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6377 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6378
daf17d00
EZ
63792011-08-14 Eli Zaretskii <eliz@gnu.org>
6380
6381 * xdisp.c (move_it_in_display_line_to): Don't invoke
6382 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6383 ppos_it. Fixes vertical cursor motion when line beginning is
6384 covered by an image. (Bug#9296)
6385
08e3161a
JD
63862011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6387
6388 * nsterm.h (ns_run_ascript): Declare.
6389 (NSAPP_DATA2_RUNASSCRIPT): Define.
6390
6391 * nsfns.m (as_script, as_result, as_status): New static variables.
6392 (ns_run_ascript): New function.
5e617bc2 6393 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6394 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6395 the event loop. Get status from as_status (Bug#7276).
6396
6397 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6398 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6399 the event loop (Bug#7276).
6400
a3720aa2
AS
64012011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6402
6403 * gnutls.c (QCgnutls_bootprop_priority)
6404 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6405 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6406 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6407 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6408 (QCgnutls_bootprop_verify_hostname_error)
6409 (QCgnutls_bootprop_callbacks_verify): Rename from
6410 Qgnutls_bootprop_..., all uses changed.
6411
6412 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6413 uses changed.
6414
0a0d27fb
PE
64152011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6416
19d5c50c
PE
6417 * xfaces.c (Qframe_set_background_mode): Now static.
6418 * dispextern.h (Qframe_set_background_mode): Remove decl.
6419
0a0d27fb
PE
6420 * process.c (Fnetwork_interface_info): Declare local only if needed.
6421
377538cb
JD
64222011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6423
6424 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6425 (Fnetwork_interface_list): Allocate in increments of bytes instead
6426 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6427 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6428 sockaddr.
6429 (struct ifflag_def): notrailers is smart on OSX.
6430 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6431 Get hardware address with getifaddrs if available.
6432
08fff70c
EZ
64332011-08-12 Eli Zaretskii <eliz@gnu.org>
6434
6435 * xdisp.c (iterate_out_of_display_property): xassert that
6436 IT->position is set to within IT->object's boundaries. Break from
6437 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6438 when IT->position is set up wrongly due to some bug.
6439 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6440 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6441 entry. Force push_it to save on the stack the current
6442 buffer/string position, to be restored by pop_it. Fix flags in
6443 the iterator structure wrt the object coming from a display
6444 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6445 properties. (Bug#9284)
6446
7be1c708 64472011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6448
7be1c708
CY
6449 * fontset.c (fontset_get_font_group): Add proper type checks.
6450 (Bug#9172)
aac0c6e3 6451
7be1c708 64522011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6453
7be1c708
CY
6454 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6455 and LC_VERSION_MIN_MACOSX.
6456 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6457 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6458
97bb72a6
EZ
64592011-08-08 Eli Zaretskii <eliz@gnu.org>
6460
6461 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6462 no-display-properties-and-no-overlays under bidi display.
6463 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6464 properties and overlays.
97bb72a6 6465
d5617611
CY
64662011-08-08 Chong Yidong <cyd@stupidchicken.com>
6467
37e11a63
CY
6468 * editfns.c (Fset_time_zone_rule): Document relationship with the
6469 setenv function.
6470
d5617611
CY
6471 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6472 the font entity extracted from the cache (Bug#8109).
6473
58872834
CY
64742011-08-07 Chong Yidong <cyd@stupidchicken.com>
6475
6476 * composite.c (autocmp_chars): Don't reset point. That is done by
6477 restore_point_unwind (Bug#5984).
6478
75bfc667
JL
64792011-08-07 Juri Linkov <juri@jurta.org>
6480
6481 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6482 to show the arg `TIME' instead of `TIMEVAL'.
6483
d1410150
EZ
64842011-08-06 Eli Zaretskii <eliz@gnu.org>
6485
6486 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6487 display property strides EOL and includes a newline, as in
6488 longlines-mode. (Bug#9254)
75b771e4
EZ
6489 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6490 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6491
6492 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6493 is non-zero, even if the data buffer is NULL. Fixes a crash in
6494 vertical-motion with longlines-mode. (Bug#9254)
6495
35928349
EZ
64962011-08-05 Eli Zaretskii <eliz@gnu.org>
6497
ec7cc85b
EZ
6498 * bidi.c <bidi_cache_total_alloc>: Now static.
6499 (bidi_initialize): Initialize bidi_cache_total_alloc.
6500
8b76d6f8 6501 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6502 cache. (Bug#9221)
6503
6504 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6505 amount allocated this far in `bidi_cache_total_alloc'.
6506 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6507 non-zero, only free the data buffer without restoring the cache
6508 contents. All callers changed.
6509
6510 * dispextern.h (bidi_unshelve_cache): Update prototype.
6511
6512 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6513 (move_it_in_display_line, move_it_to)
6514 (move_it_vertically_backward, move_it_by_lines): Replace the call
6515 to xfree to an equivalent call to bidi_unshelve_cache.
6516 (move_it_in_display_line_to): Fix logic of returning
412b6358 6517 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6518
e2e2423b
EZ
65192011-08-05 Eli Zaretskii <eliz@gnu.org>
6520
6521 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6522 came from a string character with a `cursor' property. (Bug#9229)
6523
ae9e757a
JD
65242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6525
6526 * Makefile.in (LIB_PTHREAD): New variable.
6527 (LIBES): Add LIB_PTHREAD (Bug#9216).
6528
6529 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6530 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6531
213bd7f2
AS
65322011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6533
6b02f655 6534 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6535
99aaf75f
JD
65362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6537
6538 * xterm.c (x_find_topmost_parent): New function.
6539 (x_set_frame_alpha): Find topmost parent window with
6540 x_find_topmost_parent and set the property there also (bug#9181).
6541 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6542
c74e9d86
PE
65432011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6544
6545 * callproc.c (Fcall_process): Avoid vfork clobbering
6546 the local vars buffer, coding_systems, current_dir.
6547
640c8776
SM
65482011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6549
6550 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6551
f26d0e4c
PE
65522011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6553
8a10d76c
PE
6554 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6555 so that it is not optimized away.
6556
f26d0e4c
PE
6557 * xdisp.c (compute_display_string_pos): Remove unused local.
6558
55439c61
EZ
65592011-08-02 Eli Zaretskii <eliz@gnu.org>
6560
6561 Fix slow cursor motion and scrolling in large buffers with
6562 selective display, like Org Mode buffers. (Bug#9218)
6563
6564 * dispextern.h (struct bidi_it): New member disp_prop_p.
6565
6566 * xdisp.c: Remove one-slot cache of display string positions.
6567 (compute_display_string_pos): Accept an additional argument
5e617bc2 6568 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6569 for a display string or property. If found, set DISP_PROP_P
6570 non-zero.
6571
6572 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6573 DISP_PROP_P, and pass it to compute_display_string_pos.
6574 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6575 non-zero. All callers of bidi_fetch_char changed.
6576
fb33fa43
SM
65772011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6578
6579 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6580
b099e063
DM
65812010-12-03 Don March <don@ohspite.net>
6582
6583 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6584 last character M-[char] is translated to ESC [char] (bug#7541).
6585
5cc7f7af
KH
65862011-08-02 Kenichi Handa <handa@m17n.org>
6587
d0fffa3f 6588 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6589
6590 * chartab.c (uniprop_table): Make it non-static.
6591
525d5e6e
EZ
65922011-08-01 Eli Zaretskii <eliz@gnu.org>
6593
6594 * xdisp.c (forward_to_next_line_start): Accept additional argument
6595 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6596 on the newline.
6597 (reseat_at_next_visible_line_start): Use the bidi iterator state
6598 returned by forward_to_next_line_start to restore the state of
6599 it->bidi_it after backing up to previous newline. (Bug#9212)
6600
31011111
AS
66012011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6602
6603 * regex.c (re_comp): Protoize.
6604 (re_exec): Fix return type.
6605 (regexec): Fix type of `ret'. (Bug#9203)
6606
476371c4
PE
66072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6608
e5d76069
PE
6609 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6610 This is needed if max-image-size is a floating-point number.
6611
9a79b20c
AS
66122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6613
6614 * print.c (print_object): Print empty symbol as ##.
6615
6616 * lread.c (read1): Read ## as empty symbol.
6617
d8c2fa78
AA
66182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6619
6620 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6621 setting frame foreground color (Bug#9175).
6622 (x_set_background_color): Likewise.
6623
ffe57a7a
AA
6624 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6625 contents (Bug#9176).
6626 (EmacsTooltip -init): Remove bezels and add shadows to
6627 tooltip windows.
6628
bf3492a5
AA
6629 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6630 or scroll bar (Bug#8470).
6631
d55e9c53
AA
6632 * nsfont.m (nsfont_open): Remove assignment to voffset and
6633 unnecessary vars hshink, expand, hd, full_height, min_height.
6634 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6635
6636 * nsterm.h (nsfont_info): Remove voffset field.
6637
d8c2fa78 66382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6639
6640 Implement strike-through and overline on NextStep (Bug#8863).
6641
6642 * nsfont.m (nsfont_open): Use underline position provided by font,
6643 instead of hard-coded value of 2.
6644 (nsfont_draw): Call ns_draw_text_decoration instead.
6645
6646 * nsterm.h: Add declaration for ns_draw_text_decoration.
6647
6648 * nsterm.m (ns_draw_text_decoration): New function for drawing
6649 underline, overline, and strike-through.
6650 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6651 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6652 accommodate underlining, etc.
4843aac3 6653
4cc60b9b
EZ
66542011-07-28 Eli Zaretskii <eliz@gnu.org>
6655
bc7ece87
EZ
6656 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6657 default.
4cc60b9b 6658
476371c4
PE
66592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6660
66606eea
PE
6661 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6662 Without this fix, if a signal arrives just after memory fills up,
6663 'malloc' might be invoked reentrantly.
6664
476371c4
PE
6665 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6666 In other words, assume that every image size is allowed, on non-X
6667 hosts. This assumption is probably wrong, but it lets Emacs compile.
6668
f3fcc40d
AS
66692011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6670
6671 * regex.c (re_iswctype): Convert return values to boolean.
6672
350c992f
EZ
66732011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6674
6675 * xdisp.c (compute_display_string_pos): Don't use cached display
6676 string position if the buffer had its restriction changed.
6677 (Bug#9184)
6678
5266b4bb
PE
66792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6680
6681 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6682
2573a837 66832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6684
41f55ccd 6685 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6686
39e378da
PE
6687 * bidi.c: Integer size and overflow fixes.
6688 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6689 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6690 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6691 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6692 (bidi_find_other_level_edge):
6693 Use ptrdiff_t instead of EMACS_INT where either will do.
6694 This works better on 32-bit hosts configured --with-wide-int.
6695 (bidi_cache_ensure_space): Check for size-calculation overflow.
6696 Use % rather than repeated addition, for better worst-case speed.
6697 Don't set bidi_cache_size until after xrealloc returns, because it
6698 might not return.
6699 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6700 (bidi_cache_ensure_space): Also check that the bidi cache size
6701 does not exceed that of the largest Lisp string or buffer. See Eli
6702 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6703
5e927815
PE
6704 * alloc.c (__malloc_size_t): Remove.
6705 All uses replaced by size_t. See Andreas Schwab's note
6706 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6707
ca4aa935
PE
6708 * image.c: Improve checking for integer overflow.
6709 (check_image_size): Assume that f is nonnull, since
6710 it is always nonnull in practice. This is one less thing to
6711 worry about when checking for integer overflow later.
6712 (x_check_image_size): New function, which checks for integer
6713 overflow issues inside X.
6714 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6715 This removes the need for a memory_full check.
6716 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6717 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6718 (xbm_read_bitmap_data): Change locals back to 'int', since
6719 their values must fit in 'int'.
6720 (xpm_load_image, png_load, tiff_load):
6721 Invoke x_create_x_image_and_pixmap earlier,
6722 to avoid much needless work if the image is too large.
6723 (tiff_load): Treat overly large images as if
6724 x_create_x_image_and_pixmap failed, not as malloc failures.
6725 (gs_load): Use x_check_image_size.
6726
5f8f9cc2
PE
6727 * gtkutil.c: Omit integer casts.
6728 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6729 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6730
5adf60bc
PE
6731 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6732
c8907a93
PE
6733 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6734 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6735 would wrongly return t on a 64-bit host.
6736
e3c25c68
PE
6737 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6738 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6739 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6740 and therefore cause GCC to emit a bogus diagnostic in some cases.
6741
3f791afe
PE
6742 * image.c: Integer signedness and overflow and related fixes.
6743 This is not an exhaustive set of fixes, but it's time to
6744 record what I've got.
6745 (lookup_pixel_color, check_image_size): Remove redundant decls.
6746 (check_image_size): Don't assume that arbitrary EMACS_INT values
6747 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6748 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6749 (tiff_load, imagemagick_load_image):
6750 Check for overflow in size calculations.
6751 (x_create_x_image_and_pixmap): Remove unnecessary test for
6752 xmalloc returning NULL; that can't happen.
6753 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6754 (xpm_color_bucket): Use better integer hashing function.
6755 (xpm_cache_color): Don't possibly over-allocate memory.
6756 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6757 (gif_memory_source):
6758 Use ptrdiff_t, not int or size_t, to record sizes.
6759 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6760 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6761 either works, as we prefer signed integers.
6762 (tiff_read_from_memory, tiff_write_from_memory):
6763 Return tsize_t, not size_t, since that's what the TIFF API wants.
6764 (tiff_read_from_memory): Don't fail simply because the read would
6765 go past EOF; instead, return a short read.
6766 (tiff_load): Omit no-longer-needed casts.
6767 (Fimagemagick_types): Don't assume size fits into 'int'.
6768
3cc5a532
PE
6769 Improve hashing quality when configured --with-wide-int.
6770 * fns.c (hash_string): New function, taken from sxhash_string.
6771 Do not discard information about ASCII character case; this
6772 discarding is no longer needed.
6773 (sxhash-string): Use it. Change sig to match it. Caller changed.
6774 * lisp.h: Declare it.
6775 * lread.c (hash_string): Remove, since we now use fns.c's version.
6776 The fns.c version returns a wider integer if --with-wide-int is
6777 specified, so this should help the quality of the hashing a bit.
6778
b312a492
PE
6779 * emacs.c: Integer overflow minor fix.
6780 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6781 Define only if GNU_LINUX.
6782 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6783
dfd153ae
PE
6784 * dispnew.c: Integer signedness and overflow fixes.
6785 Remove unnecessary forward decls, that were a maintenance hassle.
6786 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6787 All uses changed.
6788 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6789 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6790 (prepare_desired_row, line_draw_cost):
6791 Use int, not unsigned, where either works.
6792 (save_current_matrix, restore_current_matrix):
6793 Use ptrdiff_t, not size_t, where either works.
6794 (init_display): Check for overflow more accurately, and without
6795 relying on undefined behavior.
6796
a81d11a3
PE
6797 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6798 Remove, replacing with the new symbols in lisp.h. All uses changed.
6799 * fileio.c (make_temp_name):
6800 * filelock.c (lock_file_1, lock_file):
6801 * xdisp.c (message_dolog):
6802 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6803 Use pMd etc. instead.
6804 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6805 replacing the pWIDE etc. symbols removed from editfns.c.
6806
3300e6fd
PE
6807 * keyboard.h (num_input_events): Now uintmax_t.
6808 This is (very slightly) less likely to mess up due to wraparound.
6809 All uses changed.
6810
fd05c7e9
PE
6811 * buffer.c: Integer signedness fixes.
6812 (alloc_buffer_text, enlarge_buffer_text):
6813 Use ptrdiff_t rather than size_t when either will do, as we prefer
6814 signed integers.
6815
903fe15d
PE
6816 * alloc.c: Integer signedness and overflow fixes.
6817 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6818 (__malloc_size_t): Default to size_t, not to int.
6819 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6820 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6821 Prefer ptrdiff_t to size_t when either would do, as we prefer
6822 signed integers.
6823 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6824 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6825 Now const. Initialize with values that are in range even if char
6826 is signed.
6827 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6828 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6829 These functions do the right thing with sizes > 2**32.
6830 (check_depth): Now ptrdiff_t, not int.
6831 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6832 Adjust to new way of storing sizes. Check for size overflow bugs
6833 in rest of code.
6834 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6835 slightly wrong anyway, as it missed one instance of
6836 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6837 (refill_memory_reserve): Omit needless cast to size_t.
6838 (mark_object_loop_halt): Mark as externally visible.
6839
ac82cc6a
PE
6840 * xselect.c: Integer signedness and overflow fixes.
6841 (Fx_register_dnd_atom, x_handle_dnd_message):
6842 Use ptrdiff_t, not size_t, since we prefer signed.
6843 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6844 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6845 x_dnd_atoms_size and x_dnd_atoms_length.
6846
c2d1e36d
PE
6847 * doprnt.c: Prefer signed to unsigned when either works.
6848 * eval.c (verror):
6849 * doprnt.c (doprnt):
6850 * lisp.h (doprnt):
6851 * xdisp.c (vmessage):
6852 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6853 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6854 prefer signed arithmetic to avoid comparison confusion.
6855 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6856 but is a bit tricky.
6857
0e926e56
PE
6858 Assume freestanding C89 headers, string.h, stdlib.h.
6859 * data.c, doprnt.c, floatfns.c, print.c:
6860 Include float.h unconditionally.
6861 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6862 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6863 * regex.c: Likewise for stddef.h, string.h.
6864 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6865 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6866 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6867 (STDC_HEADERS): Remove obsolete defines.
6868 * sysdep.c: Include limits.h unconditionally.
6869
9cfdb3ec
PE
6870 Assume support for memcmp, memcpy, memmove, memset.
6871 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6872 * regex.c (memcmp, memcpy):
6873 Remove; we assume C89 now.
6874
6875 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6876 (__malloc_safe_bcopy): Remove; no longer needed.
6877
cf950e6b 6878 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6879 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6880 well either way, and we prefer signed to unsigned.
6881
dbf38e02
LMI
68822011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6883
6884 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6885 closes the connection while we're reading (bug#9182).
6886
d6f0886c 68872011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6888
d6f0886c
JD
6889 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6890 are specified (Bug#9168).
24e0f6b1 6891
2eb1f9e6
PE
68922011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6893
6894 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6895 Found by GCC static checking and --with-wide-int on a 32-bit host.
6896
22381272 68972011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6898
6899 * xdisp.c (compute_display_string_pos): Fix logic of caching
6900 previous display string position. Initialize cached_prev_pos to
6901 -1. Fixes slow-down at the beginning of a buffer.
6902
f25e39b4
EZ
69032011-07-24 Eli Zaretskii <eliz@gnu.org>
6904
6905 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6906 for attrs[LFACE_FONTSET_INDEX].
6907
04c4b52e
PE
69082011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6909
6910 * xml.c (parse_region): Remove unused local
6911 that was recently introduced.
6912
c1734fbd
EZ
69132011-07-23 Eli Zaretskii <eliz@gnu.org>
6914
be18c5a5
EZ
6915 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6916 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6917
c1734fbd
EZ
6918 * xdisp.c (move_it_in_display_line_to): Record the best matching
6919 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6920 exit if none of the characters scanned was an exact match.
6921 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6922 when exact match is impossible due to invisible text, and the
6923 lines are truncated.
6924
a258d627
JD
69252011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6926
6927 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6928 for OSX >= 10.7.
6929
b6d5a689
EZ
69302011-07-22 Eli Zaretskii <eliz@gnu.org>
6931
0f74f785
EZ
6932 Fix a significant slow-down of cursor motion with C-n, C-p,
6933 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6934 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6935 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6936 (next_element_from_buffer): Call compute_stop_pos_backwards to
6937 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6938 base_level_stop.
6939 (reseat): Don't look for prev_stop, as that could mean a very long
6940 run.
6941 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6942 <cached_disp_overlay_modiff>: Cache for last found display string
6943 position.
551918c1 6944 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6945 about the same buffer in the same area of character positions, and
6946 the buffer wasn't changed since the time the display string
6947 position was cached.
551918c1 6948
b2d0c91a
EZ
69492011-07-22 Eli Zaretskii <eliz@gnu.org>
6950
6951 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6952 is an integer, which is important for empty lines. (Bug#9149)
6953
043604ee
CY
69542011-07-22 Chong Yidong <cyd@stupidchicken.com>
6955
6956 * frame.c (Fmodify_frame_parameters): In tty case, update the
6957 default face if necessary (Bug#4238).
6958
da4adb04
CY
69592011-07-21 Chong Yidong <cyd@stupidchicken.com>
6960
6961 * editfns.c (Fstring_to_char): No need to explain what a character
6962 is in the docstring (Bug#6576).
6963
9abd0532
LMI
69642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6965
6966 * xml.c (parse_region): Make sure we always return a tree.
6967
36881d16
HK
69682011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6969
6970 * xml.c (parse_region): If a document contains only comments,
6971 return that, too.
6972
1e98674d
LMI
69732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6974
6975 * xml.c (make_dom): Return comments, too.
6976
590bd467
PE
69772011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6978
6979 Port to OpenBSD.
6980 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6981 and the surrounding thread.
6982 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6983 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6984 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6985 timer goes off.
6986 * s/openbsd.h (BROKEN_SIGIO): Define.
6987 * unexelf.c (unexec) [__OpenBSD__]:
6988 Don't update the .mdebug section of the Alpha COFF symbol table.
6989
f41628b2
LMI
69902011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6991
6992 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6993 (bug#8460).
6994
b59b67c5
PE
69952011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6996
15e3a074
PE
6997 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6998 This fixes some race conditions on the permissions of any newly
6999 created file.
7000
41bed37d
PE
7001 * alloc.c (valid_pointer_p): Use pipe, not open.
7002 This fixes some permissions issues when debugging.
7003
b59b67c5
PE
7004 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7005 If fchown fails to set both uid and gid, try to set just gid,
7006 as that is sometimes allowed. Adjust the file's mode to eliminate
7007 setuid or setgid bits that are inappropriate if fchown fails.
7008
925a6be7
SM
70092011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7010
7011 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7012 to compare Lisp_Objects.
7013 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7014 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7015 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7016
52968808
AS
70172011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7018
0a6a104b
AS
7019 * lread.c (read_integer): Unread even EOF character.
7020 (read1): Likewise. Properly record start position of symbol.
7021
52968808
AS
7022 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7023 symbol character follows.
7024
9e381cdd
PE
70252011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7026
7027 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7028 This works around a problem with the previous change to Fcopy_file.
7029 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7030 and without this change, GCC might complain about discarding
7031 fchown's return value.
7032
b5641435
JB
70332011-07-16 Juanma Barranquero <lekktu@gmail.com>
7034
7035 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7036
a8031457
PE
70372011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7038
7039 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7040
dd889327
LMI
70412011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7042
750c33f7
LMI
7043 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7044 it's used from the C level.
7045
dd889327
LMI
7046 * process.c: Use the same condition for POLL_FOR_INPUT in both
7047 keyboard.c and process.c (bug#1858).
7048
87e86684
LM
70492011-07-09 Lawrence Mitchell <wence@gmx.li>
7050
7051 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7052 (Fgnutls_boot): Use it.
7053
64348f40
AS
70542011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7055
7056 * doc.c (Fsubstitute_command_keys): Revert last change.
7057
1d698799
LMI
70582011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7059
f863868c
LMI
7060 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7061 quotes the next character, and doesn't affect other longer
7062 sequences (bug#8935).
7063
1d698799
LMI
7064 * lread.c (syms_of_lread): Clarify that is isn't only
7065 `eval-buffer' and `eval-defun' that's affected by
7066 `lexical-binding' (bug#8460).
7067
aa4b6df6
EZ
70682011-07-15 Eli Zaretskii <eliz@gnu.org>
7069
7070 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7071 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7072
5d856da6
PE
70732011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7074
ad6042bb
PE
7075 Fix minor problems found by static checking.
7076 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7077 (elsz): Now a signed constant, not a size_t var. We prefer signed
7078 types to unsigned, to avoid integer comparison confusion. Without
7079 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7080 "cannot optimize loop, the loop counter may overflow", a symptom
7081 of the confusion.
f00bbb22 7082 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7083 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7084
6468f31c
LMI
70852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7086
49080b10
LMI
7087 * search.c (Fre_search_backward): Mention `case-fold-search' in
7088 all the re_search_* functions (bug#8138).
7089
6468f31c
LMI
7090 * keyboard.c (Fopen_dribble_file): Document when the file is
7091 closed (bug#8056).
7092
c965adc5
EZ
70932011-07-14 Eli Zaretskii <eliz@gnu.org>
7094
df9733bf
EZ
7095 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7096 bidi_cache_idx.
7097
0bb23927
EZ
7098 Support bidi reordering of display and overlay strings.
7099 * xdisp.c (compute_display_string_pos)
7100 (compute_display_string_end): Accept additional argument STRING.
7101 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7102 (reseat_to_string): Initialize bidi_it->string.s and
7103 bidi_it->string.schars.
7104 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7105 NULL (avoids a crash in bidi_paragraph_init).
7106 Initialize itb.string.lstring.
0bb23927
EZ
7107 (init_iterator): Call bidi_init_it only of a valid
7108 buffer position was specified. Initialize paragraph_embedding to
7109 L2R.
7110 (reseat_to_string): Initialize the bidi iterator.
7111 (display_string): If we need to ignore text properties of
7112 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7113 original value of -1 will not work with bidi.)
7114 (compute_display_string_pos): First arg is now struct
7115 `text_pos *'; all callers changed. Support display properties on
7116 Lisp strings.
7117 (compute_display_string_end): Support display properties on Lisp
7118 strings.
7119 (init_iterator, reseat_1, reseat_to_string): Initialize the
7120 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7121 when iterating on a string not from display properties).
640c8776
SM
7122 (compute_display_string_pos, compute_display_string_end):
7123 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7124 arrow keys.
7125 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7126 base_level_stop; instead, set base_level_stop to BEGV.
7127 Fixes crashes in vertical-motion.
0bb23927
EZ
7128 (next_element_from_buffer): Improve commentary for when
7129 the iterator is before prev_stop.
7130 (init_iterator): Initialize bidi_p from the default value of
7131 bidi-display-reordering, not from buffer-local value. Use the
7132 buffer-local value only if initializing for buffer iteration.
7133 (handle_invisible_prop): Support invisible properties on strings
7134 that are being bidi-reordered.
7135 (set_iterator_to_next): Support bidi reordering of C strings and
7136 Lisp strings.
7137 (next_element_from_string): Support bidi reordering of Lisp
7138 strings.
7139 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7140 (display_string): Support display of R2L glyph rows.
7141 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7142 (init_iterator): Don't initialize it->bidi_p for strings
7143 here.
7144 (reseat_to_string): Initialize it->bidi_p for strings here.
7145 (next_element_from_string, next_element_from_c_string)
7146 (next_element_from_buffer): Add xassert's for correspondence
7147 between IT's object being iterated and it->bidi_it.string
7148 structure.
7149 (face_before_or_after_it_pos): Support bidi iteration.
7150 (next_element_from_c_string): Handle the case of the first string
7151 character that is not the first one in the visual order.
7152 (get_visually_first_element): New function, refactored from common
7153 parts of next_element_from_buffer, next_element_from_string, and
7154 next_element_from_c_string.
7155 (tool_bar_lines_needed, redisplay_tool_bar)
7156 (display_menu_bar): Force left-to-right direction. Add a FIXME
7157 comment for making that be controlled by a user option.
7158 (push_it, pop_it): Save and restore the state of the
7159 bidi iterator. Save and restore the bidi_p flag.
7160 (pop_it): Iterate out of display property for string iteration as
7161 well.
7162 (iterate_out_of_display_property): Support iteration over strings.
7163 (handle_single_display_spec): Set up it->bidi_it for iteration
7164 over a display string, and call bidi_init_it.
7165 (handle_single_display_spec, next_overlay_string)
7166 (get_overlay_strings_1, push_display_prop): Set up the bidi
7167 iterator for displaying display or overlay strings.
7168 (forward_to_next_line_start): Don't use the shortcut if
7169 bidi-iterating.
7170 (back_to_previous_visible_line_start): If handle_display_prop
7171 pushed the iterator stack, restore the internal state of the bidi
7172 iterator by calling bidi_pop_it same number of times.
7173 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7174 and we are bidi-iterating, don't decrement the iterator position;
7175 instead, set the first_elt flag in the bidi iterator, to produce
7176 the same effect.
7177 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7178 (push_display_prop): xassert that we are iterating a buffer.
7179 (push_it, pop_it): Save and restore paragraph_embedding member.
7180 (handle_single_display_spec, next_overlay_string)
7181 (get_overlay_strings_1, reseat_1, reseat_to_string)
7182 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7183 correctly. Don't assume unibyte strings are not bidi-reordered.
7184 (compute_display_string_pos)
7185 (compute_display_string_end): Fix handling the case of C string.
7186 (push_it, pop_it): Save and restore from_disp_prop_p.
7187 (handle_single_display_spec, push_display_prop): Set the
7188 from_disp_prop_p flag.
7189 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7190 (pop_it): Call iterate_out_of_display_property only if we are
7191 popping after iteration over a string that came from a display
7192 property. Fix a typo in popping stretch info. Add an assertion
7193 for verifying that the iterator position is in sync with the bidi
7194 iterator.
7195 (handle_single_display_spec, get_overlay_strings_1)
7196 (push_display_prop): Fix initialization of paragraph direction for
7197 string when that of the parent object is not yet determined.
7198 (reseat_1): Call bidi_init_it to resync the bidi
7199 iterator with IT's position. (Bug#7616)
7200 (find_row_edges): If ROW->start.pos gives position
7201 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7202 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7203 Reset the from_disp_prop_p flag.
7204 (SAVE_IT, RESTORE_IT): New macros.
7205 (pos_visible_p, face_before_or_after_it_pos)
7206 (back_to_previous_visible_line_start)
7207 (move_it_in_display_line_to, move_it_in_display_line)
7208 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7209 (try_scrolling, redisplay_window, display_line): Use them when
7210 saving a temporary copy of the iterator and restoring it back.
7211 (back_to_previous_visible_line_start, reseat_1)
7212 (init_iterator): Empty the bidi cache "stack".
7213 (move_it_in_display_line_to): If iterator ended up at
7214 EOL, but we never saw any buffer positions smaller than
7215 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7216 motion in bidi-reordered lines.
7217 (move_it_in_display_line_to): Record prev_method and prev_pos
7218 immediately before the call to set_iterator_to_next. Fixes cursor
7219 motion in bidi-reordered lines with stretch glyphs and strings
7220 displayed in margins. (Bug#8133) (Bug#8867)
7221 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7222 TO_CHARPOS.
640c8776
SM
7223 (pos_visible_p): Support positions in bidi-reordered lines.
7224 Save and restore bidi cache.
0bb23927
EZ
7225
7226 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7227 (bidi_paragraph_info): Delete unused struct.
7228 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7229 (bidi_cache_start): New variable.
7230 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7231 to zero.
7232 (bidi_cache_fetch_state, bidi_cache_search)
7233 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7234 (bidi_cache_find, bidi_peek_at_next_level)
7235 (bidi_level_of_next_char, bidi_find_other_level_edge)
7236 (bidi_move_to_visually_next): Compare cache index with
7237 bidi_cache_start rather than with zero.
7238 (bidi_fetch_char): Accept new argument STRING; all callers
7239 changed. Support iteration over a string. Support strings with
7240 display properties. Support unibyte strings. Fix the type of
7241 `len' according to what STRING_CHAR_AND_LENGTH expects.
7242 (bidi_paragraph_init, bidi_resolve_explicit_1)
7243 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7244 (bidi_level_of_next_char, bidi_move_to_visually_next):
7245 Support iteration over a string.
0bb23927
EZ
7246 (bidi_set_sor_type, bidi_resolve_explicit_1)
7247 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7248 can now be zero (for strings); special values 0 and -1 were
7249 changed to -1 and -2, respectively.
7250 (bidi_char_at_pos): New function.
7251 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7252 Call it instead of FETCH_MULTIBYTE_CHAR.
7253 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7254 initialized to valid values.
7255 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7256 values.
7257 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7258 the test for valid cached positions. Fix the logic for looking up
7259 the sentinel state in the cache. GCPRO the Lisp string we are
7260 iterating.
7261 (bidi_push_it, bidi_pop_it): New functions.
7262 (bidi_initialize): Initialize the bidi cache start stack pointer.
7263 (bidi_cache_ensure_space): New function, refactored from part of
7264 bidi_cache_iterator_state. Don't assume the required size is just
7265 one BIDI_CACHE_CHUNK away.
7266 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7267 (bidi_count_bytes, bidi_char_at_pos): New functions.
7268 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7269 always valid if bidi_cache_idx is valid.
7270 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7271 is valid if it's going to be used.
7272 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7273 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7274 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7275 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7276 (bidi_find_other_level_edge, bidi_cache_start_stack):
7277 All variables related to cache indices are now EMACS_INT.
c965adc5 7278
0bb23927
EZ
7279 * dispextern.h (struct bidi_string_data): New structure.
7280 (struct bidi_it): New member `string'. Make flag members be 1-bit
7281 fields, and put them last in the struct.
640c8776
SM
7282 (compute_display_string_pos, compute_display_string_end):
7283 Update prototypes.
0bb23927
EZ
7284 (bidi_push_it, bidi_pop_it): Add prototypes.
7285 (struct iterator_stack_entry): New members bidi_p,
7286 paragraph_embedding, and from_disp_prop_p.
7287 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7288 (bidi_shelve_cache, bidi_unshelve_cache):
7289 Declare prototypes.
0bb23927
EZ
7290
7291 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7292 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7293 and vector-like objects.
7294
7295 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7296 cache around display iteration.
7297
7298 * window.c (Fwindow_end, window_scroll_pixel_based)
7299 (displayed_window_lines, Frecenter): Save and restore the bidi
7300 cache around display iteration.
7301
3bbd2265
LMI
73022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7303
7304 * editfns.c (Fdelete_region): Clarify the use of the named
7305 parameters (bug#6788).
7306
adc47434
MR
73072011-07-14 Martin Rudalics <rudalics@gmx.at>
7308
7309 * indent.c (Fvertical_motion): Set and restore w->pointm when
7310 saving and restoring the window's buffer (Bug#9006).
7311
837c31f8
LMI
73122011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7313
7314 * editfns.c (Fstring_to_char): Clarify just what is returned
7315 (bug#6576). Text by Eli Zaretskii.
7316
ac389d0c
JB
73172011-07-13 Juanma Barranquero <lekktu@gmail.com>
7318
7319 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7320
0be0ce47
EZ
73212011-07-13 Eli Zaretskii <eliz@gnu.org>
7322
7323 * buffer.c (mmap_find): Fix a typo.
7324
cd18e7e3
JB
73252011-07-13 Johan Bockgård <bojohan@gnu.org>
7326
7327 Fix execution of x selection hooks.
7328 * xselect.c (Qx_lost_selection_functions)
7329 (Qx_sent_selection_functions): New vars.
7330 (syms_of_xselect): DEFSYM them.
7331 (x_handle_selection_request): Pass Qx_sent_selection_functions
7332 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7333 (x_handle_selection_clear,x_clear_frame_selections):
7334 Pass Qx_lost_selection_functions rather than
7335 Vx_lost_selection_functions to Frun_hook_with_args.
7336
47ea7f44
PE
73372011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7338
ac389d0c 7339 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7340 The old code sometimes used this field without initializing it.
7341
47ea7f44
PE
7342 * alloc.c (gc_sweep): Don't read past end of array.
7343 In theory, the old code could also have corrupted Emacs internals,
7344 though it'd be very unlikely.
7345
bc985c87
AS
73462011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7347
7348 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7349 argument. (Bug#4026)
bc985c87 7350
0cf34688
LMI
73512011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7352
b3dadd76
LMI
7353 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7354 key" (bug#4257).
7355
0cf34688
LMI
7356 * window.c (Fset_window_start): Doc fix (bug#4199).
7357 (Fset_window_hscroll): Ditto.
7358
270768cd
PE
73592011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7360
077e3dda 7361 Fix minor new problems caught by GCC 4.6.1.
270768cd 7362 * term.c (init_tty): Remove unused local.
490011a6 7363 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7364 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7365 not used otherwise.
270768cd 7366
b1f58454
CY
73672011-07-12 Chong Yidong <cyd@stupidchicken.com>
7368
7369 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7370
22b9578d
LMI
73712011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7372
6e70ab07
LMI
7373 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7374 are the mini-buffer and the echo area (bug#3320).
7375
22b9578d
LMI
7376 * term.c (init_tty): Remove support for supdup, c10 and perq
7377 terminals, which are no longer supported (bug#1482).
7378
8974cc9f
JB
73792011-07-10 Johan Bockgård <bojohan@gnu.org>
7380
7381 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7382
a560d974
JD
73832011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7384
7385 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7386 for non-popups (Bug#3642).
7387
1dae0f0a
AS
73882011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7389
268c2c36 7390 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7391 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7392 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7393 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7394 * data.c (fmod): Likewise.
7395 * dispnew.c (swap_glyphs_in_rows): Likewise.
7396 * emacs.c (memory_warning_signal): Likewise.
7397 * floatfns.c (float_error): Likewise.
7398 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7399 (otf_open, font_otf_capability, generate_otf_features)
7400 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7401 Likewise.
7402 * image.c (pbm_read_file): Likewise.
7403 * indent.c (string_display_width): Likewise.
7404 * intervals.c (check_for_interval, search_for_interval)
7405 (inc_interval_count, count_intervals, root_interval)
7406 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7407 * lread.c (defalias): Likewise.
268c2c36 7408 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7409 * regex.c (set_image_of_range_1, set_image_of_range)
7410 (regex_grow_registers): Likewise.
7411 * sysdep.c (strerror): Likewise.
7412 * termcap.c (valid_filename_p, tprint, main): Likewise.
7413 * tparam.c (main): Likewise.
7414 * unexhp9k800.c (run_time_remap, save_data_space)
7415 (update_file_ptrs, read_header, write_header, calculate_checksum)
7416 (copy_file, copy_rest, display_header): Likewise.
7417 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7418 Likewise.
7419 * xdisp.c (check_it): Likewise.
7420 * xfaces.c (register_color, unregister_color, unregister_colors):
7421 Likewise.
7422 * xfns.c (print_fontset_result): Likewise.
7423 * xrdb.c (member, fatal, main): Likewise.
7424
99033785
PE
74252011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7426
7427 Fix minor problems found by static checking (Bug#9031).
7428 * chartab.c (char_table_set_range, map_sub_char_table):
7429 Remove unused locals.
7430 (uniprop_table): Now static.
7431 * composite.c (_work_char): Remove unused static var.
7432
9cb2ac56
JB
74332011-07-09 Juanma Barranquero <lekktu@gmail.com>
7434
7435 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7436
f25661f0
JD
74372011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7438
7439 * gtkutil.c (qttip_cb): Remove code without function.
7440
8278c4fe
EZ
74412011-07-09 Eli Zaretskii <eliz@gnu.org>
7442
7443 * w32.c (pthread_sigmask): New stub.
7444
1692ae2d 74452011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7446
8a6ebd58 7447 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7448 sigprocmask is portable only for single-threaded applications, and
7449 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7450 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7451 (LIBES): Use it.
7452 * callproc.c (Fcall_process):
7453 * process.c (create_process):
7454 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7455 Use pthread_sigmask, not sigprocmask.
123403e4 7456
1b854618
JD
74572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7458
7459 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7460 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7461 wrong (Bug#8591).
7462
3fe4b549
JD
74632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7464
0ce7e563
JD
7465 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7466 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7467 (xg_hide_tooltip): Fix comment.
7468
3fe4b549
JD
7469 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7470 in registerServicesMenuSendTypes.
7471 (validRequestorForSendType): Don't check ns_return_types.
7472
7473 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7474 ns_return_type.
7475
5df75e47
JR
74762011-07-08 Jason Rumney <jasonr@gnu.org>
7477
22610910
JR
7478 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7479 SH_SHOW for hidden windows (Bug#5482).
7480
5df75e47
JR
7481 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7482 frame struct members of non-existent frames (Bug#6284).
7483
699c10bd
JD
74842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7485
4393663b
JD
7486 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7487 variable firstTime not needed on OSX >= 10.6.
7488 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7489 >= 10.5. Use setKnobProportion, setDoubleValue.
7490
7491 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7492 (MAC_OS_X_VERSION_10_5): Define if not defined.
7493 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7494 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7495 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7496
7497 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7498 cString and lossyCString on OSX >= 10.4
7499
58179cce 7500 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7501 sizeToFit on OSX >= 10.2.
7502
7503 * nsimage.m (allocInitFromFile): Don't use deprecated method
7504 bestRepresentationForDevice on OSX >= 10.6.
7505
7506 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7507 to avoid warning.
7508
7509 * emacs.c: Declare unexec_init_emacs_zone.
7510
a63e0781
JD
7511 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7512
699c10bd
JD
7513 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7514
7515 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7516 on svcsMenu (Bug#8842).
7517
7518 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7519 ns_return_types.
7520 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7521
7522 * nsterm.m (QUTF8_STRING): Declare.
7523 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7524 (validRequestorForSendType): Return type is (id).
7525 Change indexOfObjectIdenticalTo to indexOfObject.
7526 Check if we have local selection before returning self (Bug#8842).
7527 (writeSelectionToPasteboard): Put local selection into paste board
7528 if we have a local selection (Bug#8842).
7529 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7530
7531 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7532 (ns_get_local_selection): Declare.
7533
54e10184
LMI
75342011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7535
9888ff71
LMI
7536 * keymap.c (describe_map_tree): Don't insert a double newline at
7537 the end of the buffer (bug#1169) and return whether we inserted
7538 something.
7539
54e10184
LMI
7540 * callint.c (Fcall_interactively): Change "reading args" to
7541 "providing args" to try to clarify what it does (bug#1010).
7542
15fa4783
KH
75432011-07-07 Kenichi Handa <handa@m17n.org>
7544
7545 * composite.c (composition_compute_stop_pos): Ignore a static
7546 composition starting before CHARPOS (Bug#8915).
7547
7548 * xdisp.c (handle_composition_prop): Likewise.
7549
a8815b00
EZ
75502011-07-07 Eli Zaretskii <eliz@gnu.org>
7551
7552 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7553 (Bug#9015)
7554
ef7b981d 75552011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7556
7557 * character.h (unicode_category_t): New enum type.
7558
7559 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7560 (Qchar_code_property_table): New variable.
7561 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7562 (UNIPROP_COMPRESSED_FORM_P): New macros.
7563 (char_table_ascii): Uncompress the compressed values.
7564 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7565 Uncompress the compressed values.
ac389d0c 7566 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7567 (char_table_ref_and_range): Uncompress the compressed values.
7568 (sub_char_table_set): New arg is_uniprop. Callers changed.
7569 Uncompress the compressed values.
7570 (sub_char_table_set_range): Args changed. Callers changed.
7571 (char_table_set_range): Adjuted for the above change.
7572 (map_sub_char_table): Delete args default_val and parent. Add arg
7573 top. Give decoded values to a Lisp function.
640c8776 7574 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7575 values to a Lisp function. Gcpro more variables.
7576 (uniprop_table_uncompress)
7577 (uniprop_decode_value_run_length): New functions.
7578 (uniprop_decoder, uniprop_decoder_count): New variables.
7579 (uniprop_get_decoder, uniprop_encode_value_character)
7580 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7581 New functions.
7582 (uniprop_encoder, uniprop_encoder_count): New variables.
7583 (uniprop_get_encoder, uniprop_table)
7584 (Funicode_property_table_internal, Fget_unicode_property_internal)
7585 (Fput_unicode_property_internal): New functions.
7586 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7587 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7588 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7589 char-code-property-alist.
7590
640c8776 7591 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7592 Vunicode_category_table.
7593
640c8776 7594 * font.c (font_range): Adjust for the change of
c805dec0
KH
7595 Vunicode_category_table.
7596
76b397fb
DN
75972011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7598
7599 * m/iris4d.h: Remove file, move contents ...
7600 * s/irix6-5.h: ... here.
7601
22b4128e
PE
76022011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7603
7604 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7605 * alloc.c (mark_buffer):
7606 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7607 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7608 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7609 This isn't true in general, and it's particularly not true
7610 if Emacs is configured with --with-wide-int.
7611 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7612 New macros, used in the buffer.c change.
7613
869795d6
JD
76142011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7615
7616 * xsettings.c: Use both GConf and GSettings if both are available.
7617 (store_config_changed_event): Add comment.
7618 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7619 (store_tool_bar_style_changed): New functions.
5e617bc2 7620 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7621 (struct xsettings): Move font inside HAVE_XFT.
7622 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7623 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7624 Move inside HAVE_XFT.
640c8776 7625 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7626 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7627 also.
7628 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7629 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7630 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7631 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7632 (parse_settings): Move check for font inside HAVE_XFT.
7633 (read_settings, apply_xft_settings): Add comment.
7634 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7635 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7636 call store_font_name_changed.
7637 (xft_settings_event): Add comment.
7638 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7639 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7640 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7641 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7642 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7643 (xsettings_get_system_font, xsettings_get_system_normal_font):
7644 Add comment.
869795d6 7645
d8ed26bd
PE
76462011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7647
7648 Random fixes. E.g., (random) never returned negative values.
7649 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7650 subseconds part to the entropy, as that's a bit more random.
7651 Prefer signed to unsigned, since the signedness doesn't matter and
7652 in general we prefer signed. When given a limit, use a
7653 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7654 latter isn't right if USE_2_TAGS_FOR_INTS.
7655 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7656 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7657
cabf1cac
SM
76582011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7659
7660 * textprop.c (text_property_stickiness):
7661 Obey Vtext_property_default_nonsticky.
7662 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7663 * w32fns.c (syms_of_w32fns):
7664 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7665
6e9b2be9
PE
76662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7667
7668 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7669 This is more efficient than Ffile_directory_p and avoids a minor race.
7670
90186c68
LMI
76712011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7672
7c301272
LMI
7673 * buffer.c (Foverlay_put): Say what the return value is
7674 (bug#7835).
7675
c4f2d8d4
LMI
7676 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7677 is a directory before asking whether to use the file name
7678 (bug#7564).
ad637907
LMI
7679 (barf_or_query_if_file_exists): Make the "File is a directory"
7680 error be more correct.
c4f2d8d4 7681
90186c68
LMI
7682 * fns.c (Frequire): Remove the mention of the .gz files, since
7683 that's installation-specific, but keep the mention of
7684 `get-load-suffixes'.
7685
da64016e
PE
76862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7687
7688 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7689 Report string overflow if the output is too long.
7690
7d47b580
JB
76912011-07-04 Juanma Barranquero <lekktu@gmail.com>
7692
a555cb87
JB
7693 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7694 (syms_of_gnutls): Remove duplicate DEFSYM for
7695 Qgnutls_bootprop_verify_hostname_error, an error for
7696 Qgnutls_bootprop_verify_error (which is no longer used).
7697
7d47b580
JB
7698 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7699 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7700 Also (re)move comments that are misplaced or no longer relevant.
7701
1e49bfab
LMI
77022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7703
7704 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7705
1485f4c0
CY
77062011-07-03 Chong Yidong <cyd@stupidchicken.com>
7707
7708 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7709 and background color parameters if they have been changed.
7710
a9ab721e
LMI
77112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7712
7713 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7714
cf7cff57
PE
77152011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7716
2e13213d
PE
7717 * xsettings.c (SYSTEM_FONT): Define only when used.
7718 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7719
cf7cff57
PE
7720 * keymap.c (access_keymap_1): Now static.
7721
7a8e04f7
CY
77222011-07-02 Chong Yidong <cyd@stupidchicken.com>
7723
7724 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7725 leave any prefix arg for the up event (Bug#1586).
7726
61352f62
LMI
77272011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7728
69bb1ef7
LMI
7729 * lread.c (syms_of_lread): Mention single symbols defined by
7730 `defvar' or `defconst' (bug#7154).
7731
61352f62 7732 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7733 (Frequire): Mention get-load-suffixes.
61352f62 7734
28545e04
MR
77352011-07-02 Martin Rudalics <rudalics@gmx.at>
7736
7737 * window.h (window): Remove clone_number slot.
7738 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7739 Remove.
7740 (make_parent_window, make_window, saved_window)
7741 (Fset_window_configuration, save_window_save): Don't deal with
7742 clone numbers.
7743 * buffer.c (Qclone_number): Remove declaration.
7744 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7745
3349e122
SM
77462011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7747
7748 Add multiple inheritance to keymaps.
7749 * keymap.c (Fmake_composed_keymap): New function.
7750 (Fset_keymap_parent): Simplify.
7751 (fix_submap_inheritance): Remove.
7752 (access_keymap_1): New function extracted from access_keymap to handle
7753 embedded parents and handle lists of maps.
7754 (access_keymap): Use it.
7755 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7756 (Fcopy_keymap): Handle embedded parents.
7757 (Fcommand_remapping, define_as_prefix): Simplify.
7758 (Fkey_binding): Simplify.
7759 (syms_of_keymap): Move minibuffer-local-completion-map,
7760 minibuffer-local-filename-completion-map,
7761 minibuffer-local-must-match-map, and
7762 minibuffer-local-filename-must-match-map to Elisp.
7763 (syms_of_keymap): Defsubr make-composed-keymap.
7764 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7765 (parse_menu_item): Trivial simplification.
7766
3279eb87
GM
77672011-07-01 Glenn Morris <rgm@gnu.org>
7768
7769 * Makefile.in (SETTINGS_LIBS): Fix typo.
7770
4550efdf
KI
77712011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7772
7773 * coding.c (Fencode_coding_string): Record the last coding system
7774 used, as the function doc string says (bug#8738).
7775
0949d2b6
JD
77762011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7777
7778 * xsettings.c (store_monospaced_changed): Take new font as arg and
7779 check for change against current_mono_font.
7780 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7781 (emacs_settings_constructor, emacs_settings_get_property)
7782 (emacs_settings_set_property, emacs_settings_class_init)
7783 (emacs_settings_init, gsettings_obj): Remove.
7784 (something_changedCB): New function for HAVE_GSETTINGS.
7785 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7786 with value as argument.
7787 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7788 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7789 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7790 "changed".
7791
7792 * xgselect.c: Add defined (HAVE_GSETTINGS).
7793 (xgselect_initialize): Ditto.
7794
7795 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7796 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7797 xg_select.
7798
bbc6b304
PE
77992011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7800
7801 * eval.c (struct backtrace): Simplify and port the data structure.
7802 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7803 signed bit field, as this assumption is not portable and it makes
7804 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7805 "char debug_on_exit : 1" as this is not portable either; instead,
7806 use the portable "unsigned int debug_on_exit : 1". Remove unused
7807 member evalargs. Remove obsolete comments about cc bombing out.
7808
9851bfc5
JD
78092011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7810
51bb811f 7811 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7812 Let HAVE_GSETTINGS override HAVE_GCONF.
7813 (store_monospaced_changed): New function.
7814 (EMACS_SETTINGS): A new type derived from GObject to handle
7815 GSettings notifications.
7816 (emacs_settings_constructor, emacs_settings_get_property)
7817 (emacs_settings_set_property, emacs_settings_class_init):
7818 New functions.
7819 (gsettings_client, gsettings_obj): New variables.
7820 (GSETTINGS_SCHEMA): New define.
7821 (something_changedCB): Call store_monospaced_changed.
7822 (init_gsettings): New function.
7823 (xsettings_initialize): Call init_gsettings.
7824 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7825 to NULL.
7826
640c8776 7827 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7828 GCONF_CFLAGS/LIBS.
7829
5386012d
MR
78302011-06-29 Martin Rudalics <rudalics@gmx.at>
7831
7832 * window.c (resize_root_window, grow_mini_window)
7833 (shrink_mini_window): Rename Qresize_root_window to
7834 Qwindow_resize_root_window and Qresize_root_window_vertically to
7835 Qwindow_resize_root_window_vertically.
7836
f13e0b08
PE
78372011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7838
7839 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7840
94515237
JB
78412011-06-27 Juanma Barranquero <lekktu@gmail.com>
7842
7843 * makefile.w32-in: Redesign dependencies so they reflect more
7844 clearly which files are directly included by each source file,
7845 and not through other includes.
7846
e43b6e43
MR
78472011-06-27 Martin Rudalics <rudalics@gmx.at>
7848
7849 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7850 (sort_overlays, overlay_strings): When an overlay's clone number
7851 matches the window's clone number process the overlay even if
7852 the overlay's window property doesn't match the current window.
7853
d68443dc
MR
7854 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7855 (Fwindow_hchild): Rename to Fwindow_left_child.
7856 (Fwindow_next): Rename to Fwindow_next_sibling.
7857 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7858 (resize_window_check): Rename to window_resize_check.
7859 (resize_window_apply): Rename to window_resize_apply.
7860 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7861 (Fdelete_other_windows_internal, resize_frame_windows)
7862 (Fsplit_window_internal, Fdelete_window_internal)
7863 (grow_mini_window, shrink_mini_window)
7864 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7865
c7e73be5
JD
78662011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7867
7868 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7869 (emacs_fixed_set_min_size): Remove.
7870 (emacs_fixed_new): Take frame as argument.
7871
7872 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7873 (_EmacsFixedPrivate): Remove minwidth/height.
7874 Add struct frame *f.
7875 (emacs_fixed_init): Initialize priv->f.
7876 (get_parent_class, emacs_fixed_set_min_size): Remove.
7877 (emacs_fixed_new): Set priv->f to argument.
7878 (emacs_fixed_get_preferred_width)
7879 (emacs_fixed_get_preferred_height): Use min_width/height from
7880 frames size_hint to set minimum and natural (Bug#8919).
7881 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7882 and use min_width/height from frames size_hint to set
7883 min_width/height (Bug#8919).
7884
7885 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7886 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7887 Fix indentation.
c7e73be5 7888
cf99dcf8
EZ
78892011-06-26 Eli Zaretskii <eliz@gnu.org>
7890
7891 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7892 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7893 called at ZV.
7894
029529ac
CY
78952011-06-26 Chong Yidong <cyd@stupidchicken.com>
7896
7897 * process.c (wait_reading_process_output): Bypass select if
7898 waiting for a cell while ignoring keyboard input, and input is
7899 pending. Suggested by Jan Djärv (Bug#8869).
7900
7a7ef429
PE
79012011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7902
7903 Use gnulib's dup2 module instead of rolling our own.
7904 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7905
11fdef7d 79062011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7907
7908 * dispnew.c (scrolling_window): Before scrolling, turn off a
7909 mouse-highlight in the window being scrolled.
7910
cd3520a4
JB
79112011-06-24 Juanma Barranquero <lekktu@gmail.com>
7912
7913 Move DEFSYM to lisp.h and use everywhere.
7914
7915 * character.h (DEFSYM): Move declaration...
7916 * lisp.h (DEFSYM): ...here.
7917
7918 * gnutls.c:
7919 * minibuf.c:
7920 * w32menu.c:
7921 * w32proc.c:
7922 * w32select.c: Don't include character.h.
7923
7924 * alloc.c (syms_of_alloc):
7925 * buffer.c (syms_of_buffer):
7926 * bytecode.c (syms_of_bytecode):
7927 * callint.c (syms_of_callint):
7928 * casefiddle.c (syms_of_casefiddle):
7929 * casetab.c (init_casetab_once):
7930 * category.c (init_category_once, syms_of_category):
7931 * ccl.c (syms_of_ccl):
7932 * cmds.c (syms_of_cmds):
7933 * composite.c (syms_of_composite):
7934 * dbusbind.c (syms_of_dbusbind):
7935 * dired.c (syms_of_dired):
7936 * dispnew.c (syms_of_display):
7937 * doc.c (syms_of_doc):
7938 * editfns.c (syms_of_editfns):
7939 * emacs.c (syms_of_emacs):
7940 * eval.c (syms_of_eval):
7941 * fileio.c (syms_of_fileio):
7942 * fns.c (syms_of_fns):
7943 * frame.c (syms_of_frame):
7944 * fringe.c (syms_of_fringe):
7945 * insdel.c (syms_of_insdel):
7946 * keymap.c (syms_of_keymap):
7947 * lread.c (init_obarray, syms_of_lread):
7948 * macros.c (syms_of_macros):
7949 * msdos.c (syms_of_msdos):
7950 * print.c (syms_of_print):
7951 * process.c (syms_of_process):
7952 * search.c (syms_of_search):
7953 * sound.c (syms_of_sound):
7954 * syntax.c (init_syntax_once, syms_of_syntax):
7955 * terminal.c (syms_of_terminal):
7956 * textprop.c (syms_of_textprop):
7957 * undo.c (syms_of_undo):
7958 * w32.c (globals_of_w32):
7959 * window.c (syms_of_window):
7960 * xdisp.c (syms_of_xdisp):
7961 * xfaces.c (syms_of_xfaces):
7962 * xfns.c (syms_of_xfns):
7963 * xmenu.c (syms_of_xmenu):
7964 * xsettings.c (syms_of_xsettings):
7965 * xterm.c (syms_of_xterm): Use DEFSYM.
7966
4228cf16
TZ
79672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7968
cd3520a4 7969 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7970
7fcccf1e
PE
79712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7972
7efb4e0e
PE
7973 Integer and buffer overflow fixes (Bug#8873).
7974
ff5844ad
PE
7975 * print.c (printchar, strout): Check for string overflow.
7976 (PRINTPREPARE, printchar, strout):
7977 Don't set size unless allocation succeeds.
7978
90532f02
PE
7979 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7980 for sizes. Check for string overflow more accurately.
7981 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7982
6d84508d
PE
7983 * macros.c: Integer and buffer overflow fixes.
7984 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7985 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7986 Use ptrdiff_t, not int, for sizes.
7987 Don't increment bufsize until after realloc succeeds.
7988 Check for size-calculation overflow.
7989 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7990
437b2cb4
PE
7991 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7992
8b9ac8b4
PE
7993 * lread.c: Integer overflow fixes.
7994 (read_integer): Radix is now EMACS_INT, not int,
7995 to improve quality of diagnostics for out-of-range radices.
7996 Calculate buffer size correctly for out-of-range radices.
7997 (read1): Check for integer overflow in radices, and in
7998 read-circle numbers.
82cb60d3
PE
7999 (read_escape): Avoid int overflow.
8000 (Fload, openp, read_buffer_size, read1)
8001 (substitute_object_recurse, read_vector, read_list, map_obarray):
8002 Use ptrdiff_t, not int, for sizes.
8003 (read1): Use EMACS_INT, not int, for sizes.
20270765 8004 Check for size overflow.
8b9ac8b4 8005
7fcccf1e
PE
8006 * image.c (cache_image): Check for size arithmetic overflow.
8007
bfbbd7e7
PE
8008 * lread.c: Integer overflow issues.
8009 (saved_doc_string_size, saved_doc_string_length)
8010 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8011 Now ptrdiff_t, not int.
8012 (read1): Don't assume doc string length fits in int. Check for
8013 out-of-range doc string lengths.
8014 (read_list): Don't assume file position fits in int.
39019e54 8015 (read_escape): Check for hex character overflow.
bfbbd7e7 8016
4e323265
LL
80172011-06-22 Leo Liu <sdl.web@gmail.com>
8018
8019 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8020 Move to minibuffer.el.
8021
85fece3e
PE
80222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8023
20b84ce9 8024 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8025 The following patches are for when GLYPH_DEBUG && !XASSERT.
8026 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8027 * dispnew.c (flush_stdout):
8028 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8029 Mark as externally visible.
8030 * dispnew.c (check_window_matrix_pointers): Now static.
8031 * dispnew.c (window_to_frame_vpos):
8032 * xfns.c (unwind_create_frame):
8033 * xterm.c (x_check_font): Remove unused local.
8034 * scroll.c (CHECK_BOUNDS):
8035 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8036 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8037 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8038 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8039 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8040 Now static.
8041 (debug_method_add): Use va_list and vsprintf rather than relying
8042 on undefined behavior with wrong number of arguments.
8043 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8044 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8045 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8046 since we're not interested in debugging glyphs with old libraries.
8047 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8048 GCC 4.6.0's static checking.
8049
0766b489
PE
80502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8051
31fd4b32
PE
8052 Integer overflow and signedness fixes (Bug#8873).
8053 A few related buffer overrun fixes, too.
8054
b79e8648
PE
8055 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8056
0766b489
PE
8057 * dispextern.h (struct face.stipple):
8058 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8059 (x_bitmap_mask, x_allocate_bitmap_record)
8060 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8061 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8062 (x_create_bitmap_from_xpm_data):
8063 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8064 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8065 (.bitmaps_last):
8066 * xfaces.c (load_pixmap):
8067 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8068 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8069 (.bitmaps_last, struct x_output.icon_bitmap):
8070 Use ptrdiff_t, not int, for bitmap indexes.
8071 (x_allocate_bitmap_record): Check for size overflow.
8072 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8073
b081724f
PE
8074 Use ptrdiff_t, not int, for overlay counts.
8075 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8076 * editfns.c (overlays_around, get_pos_property):
8077 * textprop.c (get_char_property_and_overlay):
8078 * xdisp.c (next_overlay_change, note_mouse_highlight):
8079 * xfaces.c (face_at_buffer_position):
21514da7
PE
8080 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8081 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8082 (Fnext_overlay_change, Fprevious_overlay_change)
8083 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8084 Use ptrdiff_t, not int, for sizes.
21514da7 8085 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8086
3de73e5e
PE
8087 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8088
2606c57b
PE
8089 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8090 (x_session_initialize): Do not assume string length fits in int.
8091
aaafe47a
PE
8092 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8093 This is unlikely, but can occur if DPI is outlandish.
8094
2674ddc8 8095 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8096 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8097
28154962
PE
8098 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8099 * xrdb.c (magic_file_p, search_magic_path):
8100 Omit last arg SUFFIX; it was always 0. All callers changed.
8101 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8102
7de51af5
PE
8103 * xfont.c (xfont_match): Avoid need for strlen.
8104
25ed6cc3
PE
8105 * xfns.c: Don't assume strlen fits in int.
8106 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8107
4eab31dd
PE
8108 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8109 not unsigned long, as we prefer signed integers. All callers changed.
8110 Detect integer overflow in repeat count.
8111 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8112 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8113
171e2a58
PE
8114 * termcap.c: Don't assume sizes fit in int and never overflow.
8115 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8116 (gobble_line): Check for size-calculation overflow.
8117
ad39faca 8118 * minibuf.c (Fread_buffer):
6e5bb2dc 8119 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8120 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8121 Don't assume string length fits in int.
8122
52c61c22 8123 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8124 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8125
b5b8c9e5
PE
8126 * font.c: Don't assume string length fits in int.
8127 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8128 Use ptrdiff_t, not int.
ccd6111c
PE
8129 (font_intern_prop): Don't assume string length fits in int.
8130 Don't assume integer property fits in fixnum.
8131 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8132
882f0d81 8133 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8134 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8135 Reformulate so as not to need the command string.
8136 Invoke gzip -cd rather than gunzip, as it's more portable.
8137 (lock_info_type, lock_file_1, lock_file):
8138 Don't assume pid_t and time_t fit in unsigned long.
8139 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8140 (current_lock_owner): Prefer signed type for sizes.
8141 Use memcpy, not strncpy, where memcpy is what is really wanted.
8142 Don't assume (via atoi) that time_t and pid_t fit in int.
8143 Check for time_t and/or pid_t out of range, e.g., via a network share.
8144 Don't alloca where an auto var works fine.
8145
93f4cf88
PE
8146 * fileio.c: Fix some integer overflow issues.
8147 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8148 Don't assume string length fits in int.
8149 (directory_file_name): Don't assume string length fits in long.
8150 (make_temp_name): Don't assume pid fits in int, or that its print
8151 length is less than 20.
8152
f3e92b69
PE
8153 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8154
1bfdaf10
PE
8155 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8156
35016e9a
PE
8157 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8158
3d1e65a1
PE
8159 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8160 We prefer signed integers, even for size calculations.
8161
0b963a93
PE
8162 * emacs.c: Don't assume string length fits in 'int'.
8163 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8164 (main): Don't invoke strlen when not needed.
8165
573f4b54
PE
8166 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8167 (XD_DEBUG_MESSAGE): Don't waste a byte.
8168
989f33ba
PE
8169 * callproc.c (getenv_internal_1, getenv_internal)
8170 (Fgetenv_internal):
965d34eb
PE
8171 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8172
e4d29b33
PE
8173 * lread.c (invalid_syntax): Omit length argument.
8174 All uses changed. This doesn't fix a bug, but it simplifies the
8175 code away from its former Hollerith-constant appearance, and it's
8176 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8177 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8178
eb49b136
PE
8179 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8180 This didn't break anything, but it didn't help either.
8181 It's confusing to put a bogus integer in a place where the actual
8182 value does not matter.
9f62aeb1 8183 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8184 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8185
15375a22
PE
8186 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8187 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8188 implementation.
b61cc01c
PE
8189 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8190 We prefer signed types, and the value cannot exceed the EMACS_INT
8191 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8192 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8193 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8194 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8195
53b2623d
PE
8196 * indent.c (sane_tab_width): New function.
8197 (current_column, scan_for_column, Findent_to, position_indentation)
8198 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8199 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8200
51cab52b 8201 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8202
f2ed8a70
PE
8203 * lisp.h (lint_assume): New macro.
8204 * composite.c (composition_gstring_put_cache):
8205 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8206
abe80cc6
PE
8207 * editfns.c, insdel.c:
8208 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8209
b02c740e
PE
8210 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8211
ebc96716
PE
8212 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8213
b4e50fa0 8214 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8215 Use much-faster test for byte-length change.
311d5d7c 8216 Don't assume string byte-length fits in 'int'.
a4cf38e4 8217 Check that character arg fits in 'int'.
85461888 8218 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8219
c0c1ee9f
PE
8220 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8221
a498d7f4
PE
8222 * fns.c (concat): Catch string overflow earlier.
8223 Do not rely on integer wraparound.
8224
51cab52b
PE
8225 * dispextern.h (struct it.overlay_strings_charpos)
8226 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8227 * xdisp.c (forward_to_next_line_start)
8228 (back_to_previous_visible_line_start)
8229 (reseat_at_next_visible_line_start, next_element_from_buffer):
8230 Don't arbitrarily truncate the value of 'selective' to int.
8231
76031fad
PE
8232 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8233
5eb55db9
PE
8234 * composite.c: Don't truncate sizes to 'int'.
8235 (composition_gstring_p, composition_reseat_it)
8236 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8237 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8238 not EMACS_UINT, for indexes.
5eb55db9 8239
0703a717
PE
8240 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8241
d6202519
PE
8242 * buffer.c: Include <verify.h>.
8243 (struct sortvec.priority, struct sortstr.priority):
8961a454 8244 Now EMACS_INT, not int.
c20998a7 8245 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8246 (struct sortstr.size, record_overlay_string)
8247 (struct sortstrlist.size, struct sortlist.used):
8248 Don't truncate size to int.
8249 (record_overlay_string): Check for size-calculation overflow.
d6202519 8250 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8251
d5a19415
JM
82522011-06-22 Jim Meyering <meyering@redhat.com>
8253
029529ac 8254 Don't leak an XBM-image-sized buffer
d5a19415
JM
8255 * image.c (xbm_load): Free the image buffer after using it.
8256
a9041e6c
PE
82572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8258
8259 Port to Sun C.
8260 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8261 that Sun C diagnosed.
8262 * fns.c (secure_hash): Fix pointer signedness issue.
8263 * intervals.c (static_offset_intervals): New function.
8264 (offset_intervals): Use it.
8265
7f3f739f
LL
82662011-06-21 Leo Liu <sdl.web@gmail.com>
8267
8268 * deps.mk (fns.o):
8269 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8270 sha512.h.
8271
8272 * fns.c (secure_hash): Rename from crypto_hash_function and change
8273 the first arg to accept symbols.
5b66d427 8274 (Fsecure_hash): New primitive.
7f3f739f
LL
8275 (syms_of_fns): New symbols.
8276
76147d94
DD
82772011-06-20 Deniz Dogan <deniz@dogan.se>
8278
8279 * process.c (Fset_process_buffer): Clarify return value in
8280 docstring.
8281
7d7d0045
CY
82822011-06-18 Chong Yidong <cyd@stupidchicken.com>
8283
8284 * dispnew.c (add_window_display_history): Use BVAR.
8285
8286 * xdisp.c (debug_method_add): Use BVAR.
8287 (check_window_end, dump_glyph_matrix, dump_glyph)
8288 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8289
8290 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8291 Likewise.
8292
8293 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8294 check till after the cache is created in init_frame_faces.
8295
ff2bc410
SM
82962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8297
8298 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8299
28177add
PE
83002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8301
dd3482fe
PE
8302 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8303 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8304 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8305
393d71f3 8306 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8307 * fileio.c (Finsert_file_contents):
8308 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8309 Remove the old (too-loose) buffer overflow checks.
8310 They weren't needed, since make_gap checks for buffer overflow.
8311 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8312 The old code merely checked for Emacs fixnum overflow, and relied
8313 on undefined (wraparound) behavior. The new code avoids undefined
8314 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8315
2e6813b0 8316 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8317 Tune. Don't use wider integers than needed. Don't use alloca.
8318 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8319
599a9e4f
PE
8320 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8321
99561444
PE
8322 * insdel.c, lisp.h (buffer_overflow): New function.
8323 (insert_from_buffer_1, replace_range, replace_range_2):
8324 * insdel.c (make_gap_larger):
8325 * editfns.c (Finsert_char):
8326 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8327
28177add
PE
8328 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8329
e69dafad
PE
83302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8331
4baa020d 8332 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8333
b1c46f02
PE
8334 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8335 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8336
e69dafad
PE
8337 * fileio.c: Don't assume EMACS_INT fits in off_t.
8338 (emacs_lseek): New static function.
8339 (Finsert_file_contents, Fwrite_region): Use it.
8340 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8341
566684ea
PE
8342 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8343
e6966cd6
PE
8344 * fns.c: Don't overflow int when computing a list length.
8345 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8346 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8347 truncation on 64-bit hosts. Check for QUIT every
8348 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8349 faster and is responsive enough.
8350 (Flength): Report an error instead of overflowing an integer.
8351 (Fsafe_length): Return a float if the value is not representable
8352 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8353 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8354 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8355
dd0b0efb
PE
8356 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8357 (header_size, word_size): New constants.
8358 (allocate_vectorlike): Don't check size overflow here.
8359 (allocate_vector): Check it here instead, since this is the only
8360 caller of allocate_vectorlike that could cause overflow.
8361 Check that the new vector's length is representable as a fixnum.
8362
86fe5cfe
PE
8363 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8364 The previous code was bogus. For example, next_almost_prime (32)
8365 returned 39, which is undesirable as it is a multiple of 3; and
8366 next_almost_prime (24) returned 25, which is a multiple of 5 so
8367 why was the code bothering to check for multiples of 7?
8368
80e88859
PE
8369 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8370
4a2f0ad6
PE
8371 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8372
f66c7cf8
PE
8373 Variadic C functions now count arguments with ptrdiff_t.
8374 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8375 Back then I didn't know that the Emacs coding style prefers signed int.
8376 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8377 were being counted with int, which may truncate counts on 64-bit
8378 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8379 * lisp.h (struct Lisp_Subr.function.aMANY)
8380 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8381 Arg counts are now ptrdiff_t, not size_t.
8382 All variadic functions and their callers changed accordingly.
8383 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8384 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8385 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8386 * callint.c (Fcall_interactively): Check arg count for overflow,
8387 to avoid potential buffer overrun. Use signed char, not 'int',
8388 for 'varies' array, so that we needn't bother to check its size
8389 calculation for overflow.
8390 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8391 * eval.c (apply_lambda):
8392 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8393 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8394 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8395
a1759b76
PE
8396 * callint.c (Fcall_interactively): Don't use index var as event count.
8397
d96be9fc
PE
8398 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8399 * mem-limits.h (SIZE): Remove; no longer used.
8400
a690a978 8401 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8402
578c21e6
PE
8403 Remove unnecessary casts.
8404 * xterm.c (x_term_init):
8405 * xfns.c (x_set_border_pixel):
8406 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8407 These aren't needed now that we assume ANSI C.
8408
96f53c6c
PE
8409 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8410 It's more likely to cause problems (due to unsigned overflow)
8411 than to cure them.
8412
83c77d31
PE
8413 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8414
ee2079f1
PE
8415 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8416
6da65536
PE
8417 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8418
7147c4a4
PE
8419 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8420
193e32d9
PE
8421 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8422
e5533da6
PE
8423 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8424
9910e595
PE
8425 GLYPH_CODE_FACE returns EMACS_INT, not int.
8426 * dispextern.h (merge_faces):
8427 * xfaces.c (merge_faces):
01103c44
PE
8428 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8429 Don't assume EMACS_INT fits in int.
9910e595 8430
2638320e
PE
8431 * character.h (CHAR_VALID_P): Remove unused parameter.
8432 * fontset.c, lisp.h, xdisp.c: All uses changed.
8433
045eb8d9
PE
8434 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8435
c1f134b5
PE
8436 * fns.c (concat): Minor tuning based on overflow analysis.
8437 This doesn't fix any bugs. Use int to hold character, instead
8438 of constantly refetching from Emacs object. Use XFASTINT, not
8439 XINT, for value known to be a character. Don't bother comparing
8440 a single byte to 0400, as it's always less.
8441
395fcb93 8442 * floatfns.c (Fexpt):
327eeec8
PE
8443 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8444
abbd3d23
PE
8445 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8446 for characters.
8447
684a03ef
PE
8448 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8449
0fed43f3
PE
8450 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8451 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8452 incorrectly succeed when S was a string, because 4294967386 was
8453 truncated before it was used.
8454
8fd02eb7
PE
8455 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8456 Otherwise, an out-of-range integer could cause undefined behavior
8457 on a 64-bit host.
8458
f8c86b69
PE
8459 * composite.c: Use int, not EMACS_INT, for characters.
8460 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8461 EMACS_INT, for values that are known to be in character range.
8462 This doesn't fix any bugs but is the usual style inside Emacs and
8463 may generate better code on 32-bit machines.
8464
34206dd2
PE
8465 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8466 This is for reasons similar to the recent CHAR_STRING fix.
8467 * charset.c (Fencode_char): Check that character arg is actually
8468 a character. Pass an int to ENCODE_CHAR.
8469 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8470 wider than 'int', as a compile-time check to prevent future regressions
8471 in this area.
8472
c5958d4c 8473 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8474
8475 Make sure a 64-bit char is never passed to CHAR_STRING.
8476 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8477 by silently ignoring the top 32 bits, allowing some values
8478 that were far too large to be valid characters.
8479 * character.h: Include <verify.h>.
8480 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8481 arguments are no wider than unsigned, as a compile-time check
8482 to prevent future regressions in this area.
8483 * data.c (Faset):
01103c44 8484 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8485 (Fsubst_char_in_region):
8486 * fns.c (concat):
8487 * xdisp.c (decode_mode_spec_coding):
8488 Adjust to CHAR_STRING's new requirement.
8489 * editfns.c (Finsert_char, Fsubst_char_in_region):
8490 * fns.c (concat): Check that character args are actually
8491 characters. Without this test, these functions did the wrong
8492 thing with wildly out-of-range values on 64-bit hosts.
8493
d37ca623
PE
8494 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8495 These casts should not be needed on 32-bit hosts, either.
8496 * keyboard.c (read_char):
8497 * lread.c (Fload): Remove casts to unsigned.
8498
ea204efb
PE
8499 * lisp.h (UNSIGNED_CMP): New macro.
8500 This fixes comparison bugs on 64-bit hosts.
8501 (ASCII_CHAR_P): Use it.
8502 * casefiddle.c (casify_object):
01103c44 8503 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8504 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8505 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8506 * dispextern.h (FACE_FROM_ID):
8507 * keyboard.c (read_char): Use UNSIGNED_CMP.
8508
41cb286c
PE
8509 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8510 not to EMACS_INT, to avoid GCC warning.
8511
4a1b9832
PE
8512 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8513
55daad71
PE
8514 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8515 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8516 isn't needed on 32-bit machines.
8f95c75c 8517
01103c44
PE
8518 * buffer.c (Fgenerate_new_buffer_name):
8519 Use EMACS_INT for count, not int.
0ceccced 8520 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8521
8522 * data.c (Qcompiled_function): Now static.
8523
c6f072e7
PE
8524 * window.c (window_body_lines): Now static.
8525
20ce5912
PE
8526 * image.c (gif_load): Rename local to avoid shadowing.
8527
9c4c5f81
PE
8528 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8529 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8530 * alloc.c (make_save_value): Integer argument is now of type
8531 ptrdiff_t, not int.
8532 (mark_object): Use ptrdiff_t, not int.
8533 * lisp.h (pD): New macro.
8534 * print.c (print_object): Use it.
8535
c0c5c8ae
PE
8536 * alloc.c: Use EMACS_INT, not int, to count objects.
8537 (total_conses, total_markers, total_symbols, total_vector_size)
8538 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8539 (total_free_floats, total_floats, total_free_intervals)
8540 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8541 Now EMACS_INT, not int. All uses changed.
8542 (Fgarbage_collect): Compute overall total using a double, so that
8543 integer overflow is less likely to be a problem. Check for overflow
8544 when converting back to an integer.
5a25e253
PE
8545 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8546 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8547 These were 'int' variables that could overflow on 64-bit hosts;
8548 they were never used, so remove them instead of repairing them.
211a0b2a 8549 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8550 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8551 Previously, this ceilinged at INT_MAX, but that doesn't work on
8552 64-bit machines.
e46bb31a 8553 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8554
c78baabf 8555 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8556 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8557 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8558 when a (possibly-narrower) signed value would do just as well.
8559 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8560
c9d624c6
PE
8561 * alloc.c: Catch some string size overflows that we were missing.
8562 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8563 for convenience in STRING_BYTES_MAX.
8564 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8565 The definition here is exact; the one in lisp.h was approximate.
8566 (allocate_string_data): Check for string overflow. This catches
8567 some instances we weren't catching before. Also, it catches
8568 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8569 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8570 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8571
c9d624c6
PE
8572 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8573 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8574 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8575
353032ce
PE
8576 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8577
2bccce07
PE
8578 * alloc.c (Fmake_string): Check for out-of-range init.
8579
0ac30604
SM
85802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8581
8582 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8583
c195f2de
JD
85842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8585
8586 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8587 xg_get_default_scrollbar_width.
8588
8589 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8590 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8591 (style_changed_cb): Call update_theme_scrollbar_width and call
8592 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8593 all frames (Bug#8505).
8594 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8595 Call gtk_window_set_resizable if HAVE_GTK3.
8596 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8597 and height if HAVE_GTK3 (Bug#8505).
8598 (scroll_bar_width_for_theme): New variable.
8599 (update_theme_scrollbar_width): New function.
8600 (xg_get_default_scrollbar_width): Move code to
8601 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8602 (xg_initialize): Call update_theme_scrollbar_width.
8603
8604 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8605
8606 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8607
e10ac9f1
MR
86082011-06-12 Martin Rudalics <rudalics@gmx.at>
8609
8610 * frame.c (make_frame): Call other_buffer_safely instead of
8611 other_buffer.
8612
8613 * window.c (temp_output_buffer_show): Call display_buffer with
8614 second argument Vtemp_buffer_show_specifiers and reset latter
8615 immediately after the call.
8616 (Vtemp_buffer_show_specifiers): New variable.
8617 (auto_window_vscroll_p, next_screen_context_lines)
8618 (Vscroll_preserve_screen_position): Remove leading asterisks from
8619 doc-strings.
8620
2d3c217e 86212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8622
7b7f97e8 8623 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8624 * buffer.c (Qclone_number): Remove for now, as it's unused.
8625 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8626 (record_buffer): Remove unused local.
8627 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8628 (set_frame_buffer_list): Remove; unused.
8629 * frame.h (other_visible_frames): Remove decl.
8630 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8631 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8632 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8633 if HAVE_GPM.
8634 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8635 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8636 Define only if HAVE_GPM.
8637 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8638 (update_hints_inhibit): Remove; never set. All uses removed.
8639 * widgetprv.h (emacsFrameClassRec): Remove decl.
8640 * window.c (delete_deletable_window): Now returns void, since it
8641 wasn't returning anything.
8642 (compare_window_configurations): Remove unused locals.
8643 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8644 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8645 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8646 the same widths as pointers. This follows up on the 2011-05-06 patch.
8647 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8648 * xterm.h: Likewise.
8649 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8650
1384b89e
JB
86512011-06-12 Juanma Barranquero <lekktu@gmail.com>
8652
8653 * makefile.w32-in: Update dependencies.
8654 (LISP_H): Add lib/intprops.h.
8655
1100a63c
CY
86562011-06-11 Chong Yidong <cyd@stupidchicken.com>
8657
8658 * image.c (gif_load): Add animation frame delay to the metadata.
8659 (syms_of_image): Use DEFSYM. New symbol `delay'.
8660
6198ccd0
MR
86612011-06-11 Martin Rudalics <rudalics@gmx.at>
8662
8663 * window.c (delete_deletable_window): Re-add.
8664 (Fset_window_configuration): Rewrite to handle dead buffers and
8665 consequently deletable windows.
8666 (window_tree, Fwindow_tree): Remove. Supply functionality in
8667 window.el.
8668 (compare_window_configurations): Simplify code.
8669
b6e3633c
AS
86702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8671
1ab0dee5
AS
8672 * image.c (imagemagick_load_image): Fix type mismatch.
8673 (Fimagemagick_types): Likewise.
8674
b6e3633c
AS
8675 * window.h (replace_buffer_in_windows): Declare.
8676
9397e56f
MR
86772011-06-11 Martin Rudalics <rudalics@gmx.at>
8678
8679 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8680 Qclone_number. Remove external declaration of Qdelete_window.
8681 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8682 code.
640c8776
SM
8683 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8684 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8685 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8686 buffer list implementation.
8687 (other_buffer_safely): New function.
8688 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8689 calls to replace_buffer_in_windows and
8690 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8691 if allowed.
8692 (record_buffer): Inhibit quitting and rewrite using quittable
8693 functions. Run Qbuffer_list_update_hook if allowed.
8694 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8695 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8696 Move switch-to-buffer to window.el.
9397e56f
MR
8697 (bury-buffer): Move to window.el.
8698 (Vbuffer_list_update_hook): New variable.
8699
8700 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8701 section.
8702
8703 * window.h (resize_frame_windows): Move up in code.
8704 (Fwindow_frame): Remove EXFUN.
8705 (replace_buffer_in_all_windows): Remove prototype.
8706 (replace_buffer_in_windows_safely): Add prototype.
8707
8708 * window.c: Declare Qdelete_window static again. Move down
8709 declaration of select_count.
8710 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8711 (Fother_window): Move to window.el.
8712 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8713 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8714 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8715 window.el.
8716 (replace_buffer_in_windows): Implement by calling
8717 Qreplace_buffer_in_windows.
8718 (replace_buffer_in_all_windows): Remove with some functionality
8719 moved into replace_buffer_in_windows_safely.
8720 (replace_buffer_in_windows_safely): New function.
8721 (select_window_norecord, select_frame_norecord): Move in front
8722 of run_window_configuration_change_hook. Remove now obsolete
8723 declarations.
640c8776
SM
8724 (Fset_window_buffer): Rewrite doc-string.
8725 Call Qrecord_window_buffer.
9397e56f
MR
8726 (keys_of_window): Move binding for other-window to window.el.
8727
b50691aa
CY
87282011-06-11 Chong Yidong <cyd@stupidchicken.com>
8729
8730 * dispextern.h (struct image): Replace data member, whose int_val
8731 and ptr_val fields were not used by anything, with a single
8732 lisp_val object.
8733
8734 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8735 (gif_clear_image, gif_load, imagemagick_load_image)
8736 (gs_clear_image, gs_load): Callers changed.
8737
3f754b86
PE
87382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8739
cca69397
PE
8740 * buffer.h: Include <time.h>, for time_t.
8741 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8742
109e28d0
PE
8743 Fix minor problems found by static checking.
8744
60737f02
PE
8745 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8746
4b66faf3
PE
8747 Make identifiers static if they are not used in other modules.
8748 * data.c (Qcompiled_function, Qframe, Qvector):
8749 * image.c (QimageMagick, Qsvg):
8750 * minibuf.c (Qmetadata):
8751 * window.c (resize_window_check, resize_root_window): Now static.
8752 * window.h (resize_window_check, resize_root_window): Remove decls.
8753
109e28d0
PE
8754 * window.c (window_deletion_count, delete_deletable_window):
8755 Remove; unused.
46a4ce9e
PE
8756 (window_body_lines): Now static.
8757 (Fdelete_other_windows_internal): Mark vars as initialized.
8758 Make sure 'resize_failed' is initialized.
8759 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8760 (resize_window_apply): Remove unused local.
8761 * window.h (delete_deletable_window): Remove decl.
8762
109e28d0 8763 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8764 (imagemagick_load_image): Fix pointer signedness problem by changing
8765 last arg from unsigned char * to char *. All uses changed.
8766 Also, fix a local for similar reasons.
8767 Remove unused locals. Remove locals to avoid shadowing.
8768 (fn_rsvg_handle_free): Remove; unused.
8769 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8770 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8771
3f754b86
PE
8772 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8773
2547adb1
CY
87742011-06-10 Chong Yidong <cyd@stupidchicken.com>
8775
8776 * image.c (gif_load): Fix omitted cast error introduced by
8777 2011-06-06 change.
8778
2c8e37d4
MR
87792011-06-10 Martin Rudalics <rudalics@gmx.at>
8780
8781 * window.h (resize_proportionally, orig_total_lines)
8782 (orig_top_line): Remove from window structure.
8783 (set_window_height, set_window_width, change_window_heights)
8784 (Fdelete_window): Remove prototypes.
8785 (resize_frame_windows): Remove duplicate declaration.
8786
440a42e3
EZ
87872011-06-10 Eli Zaretskii <eliz@gnu.org>
8788
8789 * window.h (resize_frame_windows, resize_window_check)
8790 (delete_deletable_window, resize_root_window)
8791 (resize_frame_windows): Declare prototypes.
8792
8793 * window.c (resize_window_apply): Make definition be "static" to
8794 match the prototype.
8795
562dd5e9
MR
87962011-06-10 Martin Rudalics <rudalics@gmx.at>
8797
8798 * window.c: Remove declarations of Qwindow_size_fixed,
8799 window_min_size_1, window_min_size_2, window_min_size,
8800 size_window, window_fixed_size_p, enlarge_window, delete_window.
8801 Remove static from declaration of Qdelete_window, it's
8802 temporarily needed by Fbury_buffer.
8803 (replace_window): Don't assign orig_top_line and
8804 orig_total_lines.
8805 (Fdelete_window, delete_window): Remove. Window deletion is
8806 handled by window.el.
640c8776
SM
8807 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8808 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8809 (Fdelete_other_windows): Remove. Deleting other windows is
8810 handled by window.el.
8811 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8812 handled in window.el.
8813 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8814 Window minimum sizes are handled in window.el.
8815 (shrink_windows, size_window, set_window_height)
8816 (set_window_width, change_window_heights, window_height)
8817 (window_width, CURBEG, CURSIZE, enlarge_window)
8818 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8819 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8820 handled in window.el.
8821 (make_dummy_parent): Rename to make_parent_window and give it a
8822 second argument horflag.
8823 (make_window): Don't set resize_proportionally any more.
8824 (Fsplit_window): Remove. Windows are split in window.el.
8825 (save_restore_action, save_restore_orig_size)
8826 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8827 Resize mini windows in window.el.
8828 (grow_mini_window, shrink_mini_window): Implement by calling
8829 Qresize_root_window_vertically, resize_window_check and
8830 resize_window_apply.
640c8776
SM
8831 (saved_window, Fset_window_configuration, save_window_save):
8832 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8833 resize_proportionally.
8834 (window_min_height, window_min_width): Move to window.el.
8835 (keys_of_window): Move bindings for delete-other-windows,
8836 split-window, delete-window and enlarge-window to window.el.
8837
8838 * buffer.c: Temporarily extern Qdelete_window.
8839 (Fbury_buffer): Temporarily call Qdelete_window instead of
8840 Fdelete_window (Fbury_buffer will move to window.el soon).
8841
8842 * frame.c (set_menu_bar_lines_1): Remove code handling
8843 orig_top_line and orig_total_lines.
8844
8845 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8846 set_window_height but set heights directly.
8847 (change_frame_size_1): Use resize_frame_windows.
8848
8849 * xdisp.c (init_xdisp): Don't use set_window_height but set
8850 heights directly.
8851
640c8776
SM
8852 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8853 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8854 run_window_configuration_change_hook.
8855
8856 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8857 instead of change_window_heights and run
8858 run_window_configuration_change_hook.
8859
1a13852e
MR
88602011-06-09 Martin Rudalics <rudalics@gmx.at>
8861
8862 * window.c (replace_window): Rename second argument REPLACEMENT to
8863 NEW. New third argument SETFLAG. Rewrite.
8864 (delete_window, make_dummy_parent): Call replace_window with
8865 third argument 1.
8866 (window_list_1): Move down in code.
8867 (run_window_configuration_change_hook): Move set_buffer part
8868 before select_frame_norecord part in order to unwind correctly.
8869 Rename count1 to count.
8870 (recombine_windows, delete_deletable_window, resize_root_window)
8871 (Fdelete_other_windows_internal)
8872 (Frun_window_configuration_change_hook, make_parent_window)
8873 (resize_window_check, resize_window_apply, Fresize_window_apply)
8874 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8875 (Fdelete_window_internal, Fresize_mini_window_internal):
8876 New functions.
1a13852e
MR
8877 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8878
f3d1777e
MR
88792011-06-08 Martin Rudalics <rudalics@gmx.at>
8880
496e208e
MR
8881 * window.h (window): Add some new members to window structure -
8882 normal_lines, normal_cols, new_total, new_normal, clone_number,
8883 splits, nest, prev_buffers, next_buffers.
8884 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8885 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8886
f3d1777e
MR
8887 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8888 Remove.
496e208e
MR
8889 (make_dummy_parent): Set new members of windows structure.
8890 (make_window): Move down in code. Handle new members of window
8891 structure.
8892 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8893 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8894 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8895 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8896 (Fset_window_next_buffers, Fset_window_clone_number):
8897 New functions.
496e208e
MR
8898 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8899 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8900 Doc-string fixes.
8901 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8902 Argument WINDOW can be now internal window too.
8903 (Fwindow_use_time): Move up in code.
8904 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8905 Rewrite doc-string.
8906 (Fset_window_configuration, saved_window)
8907 (Fcurrent_window_configuration, save_window_save): Handle new
8908 members of window structure.
b9e809c2
MR
8909 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8910 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8911 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8912 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8913 Qget_mru_window, Qresize_root_window,
8914 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8915 Qauto_buffer_name; staticpro them.
f3d1777e 8916
abde8f8c
MR
89172011-06-07 Martin Rudalics <rudalics@gmx.at>
8918
8919 * window.c (Fwindow_total_size, Fwindow_left_column)
8920 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8921 (Fwindow_list_1): New functions.
8922 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8923 (Fwindow_width, Fscroll_left, Fscroll_right):
8924 Use window_body_cols instead of window_box_text_cols.
8925 (delete_window, Fset_window_configuration):
8926 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8927 (delete_all_subwindows): Take a window as argument and not a
8928 structure. Rewrite.
190b47e6
MR
8929 (window_loop): Remove handling of GET_LRU_WINDOW and
8930 GET_LARGEST_WINDOW.
8931 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8932
8933 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8934 window_box_text_cols. delete_all_subwindows now takes a
8935 Lisp_Object as argument.
abde8f8c 8936
640c8776
SM
8937 * indent.c (compute_motion, Fcompute_motion):
8938 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8939
fa8a67e6
MR
8940 * frame.c (delete_frame): Call delete_all_subwindows with root
8941 window as argument.
8942
a54e3482
DC
89432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8944
8945 * fns.c (Fputhash): Document return value.
8946
60002bf5
CY
89472011-06-06 Chong Yidong <cyd@stupidchicken.com>
8948
8949 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8950
0c671da6 89512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8952
b862a52a 8953 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8954
be44ca6c
PE
8955 Check for overflow when converting integer to cons and back.
8956 * charset.c (Fdefine_charset_internal, Fdecode_char):
8957 Use cons_to_unsigned to catch overflow.
8958 (Fencode_char): Use INTEGER_TO_CONS.
8959 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8960 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8961 * data.c (long_to_cons, cons_to_long): Remove.
8962 (cons_to_unsigned, cons_to_signed): New functions.
8963 These signal an error for invalid or out-of-range values.
8964 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8965 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8966 * font.c (Ffont_variation_glyphs):
8967 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8968 * lisp.h: Include <intprops.h>.
8969 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8970 (cons_to_signed, cons_to_unsigned): New decls.
8971 (long_to_cons, cons_to_long): Remove decls.
8972 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8973 (Fprimitive_undo): Use CONS_TO_INTEGER.
8974 * xfns.c (Fx_window_property): Likewise.
8975 * xselect.c: Include <limits.h>.
8976 (x_own_selection, selection_data_to_lisp_data):
8977 Use INTEGER_TO_CONS.
8978 (x_handle_selection_request, x_handle_selection_clear)
8979 (x_get_foreign_selection, Fx_disown_selection_internal)
8980 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8981 (lisp_data_to_selection_data): Use cons_to_unsigned.
8982 (x_fill_property_data): Use cons_to_signed.
8983 Report values out of range.
8984
d1f3d2af
PE
8985 Check for buffer and string overflow more precisely.
8986 * buffer.h (BUF_BYTES_MAX): New macro.
8987 * lisp.h (STRING_BYTES_MAX): New macro.
8988 * alloc.c (Fmake_string):
8989 * character.c (string_escape_byte8):
8990 * coding.c (coding_alloc_by_realloc):
8991 * doprnt.c (doprnt):
8992 * editfns.c (Fformat):
8993 * eval.c (verror):
8994 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8995 since they may not be the same number.
8996 * editfns.c (Finsert_char):
8997 * fileio.c (Finsert_file_contents):
8998 Likewise for BUF_BYTES_MAX.
8999
dd52fcea
PE
9000 * image.c: Use ptrdiff_t, not int, for sizes.
9001 (slurp_file): Switch from int to ptrdiff_t.
9002 All uses changed.
9003 (slurp_file): Check that file size fits in both size_t (for
9004 malloc) and ptrdiff_t (for sanity and safety).
9005
7f9bbdbb
PE
9006 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9007 if b->modtime has its maximal value.
9008
dfe18f82
PE
9009 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9010
84acfcf0
PE
9011 Don't assume time_t can fit into int.
9012 * buffer.h (struct buffer.modtime): Now time_t, not int.
9013 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9014 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9015
ccd9a01a
PE
9016 Minor fixes for signed vs unsigned integers.
9017 * character.h (MAYBE_UNIFY_CHAR):
9018 * charset.c (maybe_unify_char):
9019 * keyboard.c (read_char, reorder_modifiers):
9020 XINT -> XFASTINT, since the integer must be nonnegative.
9021 * ftfont.c (ftfont_spec_pattern):
9022 * keymap.c (access_keymap, silly_event_symbol_error):
9023 XUINT -> XFASTINT, since the integer must be nonnegative.
9024 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9025 since it makes no difference and we prefer signed.
9026 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9027 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9028 nonnegative.
9029
d6d100dd
SM
90302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9031
9032 * window.h (Fwindow_frame): Declare.
9033
2b6148e4
PE
90342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9035
9036 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9037 (SPARE_MEMORY): Always define.
9038 (LARGE_REQUEST): Remove.
9039 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9040
f230ecc9
MR
90412011-06-06 Martin Rudalics <rudalics@gmx.at>
9042
727e958e
MR
9043 * lisp.h: Move EXFUNS for Fframe_root_window,
9044 Fframe_first_window and Fset_frame_selected_window to window.h.
9045
9046 * window.h: Move EXFUNS for Fframe_root_window,
9047 Fframe_first_window and Fset_frame_selected_window here from
9048 lisp.h.
9049
9050 * frame.c (Fwindow_frame, Fframe_first_window)
9051 (Fframe_root_window, Fframe_selected_window)
9052 (Fset_frame_selected_window): Move to window.c.
9053 (Factive_minibuffer_window): Move to minibuf.c.
9054 (Fother_visible_frames_p): New function.
9055
9056 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9057
f230ecc9
MR
9058 * window.c (decode_window, decode_any_window): Move up in code.
9059 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9060 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9061 (Fwindow_buffer): Move up and rewrite doc-string.
9062 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9063 (Fwindow_prev): New functions.
727e958e
MR
9064 (Fwindow_frame): Move here from frame.c. Accept any window as
9065 argument.
9066 (Fframe_root_window, Fframe_first_window)
9067 (Fframe_selected_window): Move here from frame.c. Accept frame
9068 or arbitrary window as argument. Update doc-strings.
9069 (Fminibuffer_window): Move up in code.
9070 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9071 (Fset_frame_selected_window): Move here from frame.c.
9072 Marginal rewrite.
727e958e
MR
9073 (Fselected_window, select_window, Fselect_window): Move up in
9074 code. Minor doc-string fixes.
f230ecc9 9075
4d09bcf6
PE
90762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9077
9078 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9079 Do not assume that spare memory exists; that assumption is valid
9080 only if SYSTEM_MALLOC.
9081 (LARGE_REQUEST): New macro, so that the issue of large requests
9082 is separated from the issue of spare memory.
9083
810928a2
AS
90842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9085
172418ad
AS
9086 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9087 format. (Bug#8806)
9088
43f862f7
AS
9089 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9090
810928a2
AS
9091 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9092 before statements.
9093
a059fe24
JD
90942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9095
9096 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9097
9098 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9099
9100 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9101 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9102
989bf368
JB
91032011-06-05 Juanma Barranquero <lekktu@gmail.com>
9104
9105 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9106
4b80f674
CY
91072011-06-04 Chong Yidong <cyd@stupidchicken.com>
9108
9109 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9110 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9111 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9112 New error handlers.
4b80f674
CY
9113 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9114 Obey Vx_select_enable_clipboard_manager. Catch errors in
9115 x_clipboard_manager_save (Bug#8779).
9116 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9117 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9118
99a33b77 91192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9120
9121 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9122
99a33b77 91232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9124
9125 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9126 in the current matrix if keep_current_p is non-zero.
9127
8264569d
EZ
91282011-06-04 Eli Zaretskii <eliz@gnu.org>
9129
9130 * bidi.c (bidi_level_of_next_char): Fix last change.
9131
57f97249
EZ
91322011-06-03 Eli Zaretskii <eliz@gnu.org>
9133
fec2107c 9134 Support bidi reordering of text covered by display properties.
57f97249 9135
fec2107c
EZ
9136 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9137 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9138 (bidi_cache_search, bidi_cache_iterator_state)
9139 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9140 (bidi_level_of_next_char, bidi_move_to_visually_next):
9141 Support character positions inside a run of characters covered by a
fec2107c
EZ
9142 display string.
9143 (bidi_paragraph_init, bidi_resolve_explicit_1)
9144 (bidi_level_of_next_char): Call bidi_fetch_char and
9145 bidi_fetch_char_advance instead of FETCH_CHAR and
9146 FETCH_CHAR_ADVANCE.
9147 (bidi_init_it): Initialize new members.
9148 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9149 definitions.
9150 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9151 instead of using explicit *_CHAR codes.
d6d100dd
SM
9152 (bidi_resolve_explicit, bidi_resolve_weak):
9153 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9154 bidirectional text is supported only in multibyte buffers.
9155 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9156 it to initialize the frame_window_p member of struct bidi_it.
9157 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9158 (bidi_resolve_explicit, bidi_resolve_weak)
9159 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9160 bidi_it->nchars is non-positive.
9161 (bidi_level_of_next_char): Don't try to lookup the cache for the
9162 next/previous character if nothing is cached there yet, or if we
9163 were just reseat()'ed to a new position.
c40e2fb2 9164
0e14fe90
EZ
9165 * xdisp.c (set_cursor_from_row): Set start and stop points
9166 according to the row's direction when priming the loop that looks
9167 for the glyph on which to display cursor.
9168 (single_display_spec_intangible_p): Function deleted.
9169 (display_prop_intangible_p): Reimplement to call
9170 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9171 Accept 3 additional arguments needed by handle_display_spec.
9172 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9173 values: lists, `(when COND...)' forms, etc.
9174 (single_display_spec_string_p): Support property values that are
9175 lists with the argument STRING its top-level element.
9176 (display_prop_string_p): Fix the condition for processing a
9177 property that is a list to be consistent with handle_display_spec.
fec2107c 9178 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9179 last portion of handle_display_prop.
9180 (compute_display_string_pos): Accept additional argument
9181 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9182 value of a `display' property is a "replacing spec".
9183 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9184 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9185 the display property, but just return a value indicating whether
9186 the display property will replace the characters it covers.
9187 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9188 frame_window_p members of struct bidi_it.
d6d100dd
SM
9189 (compute_display_string_pos, compute_display_string_end):
9190 New functions.
fec2107c
EZ
9191 (push_it): Accept second argument POSITION, where pop_it should
9192 jump to continue iteration.
9193 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9194
fec2107c
EZ
9195 * keyboard.c (adjust_point_for_property): Adjust the call to
9196 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9197
9198 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9199 (bidi_init_it): Update prototypes.
9200 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9201 (compute_display_string_pos, compute_display_string_end):
9202 Declare prototypes.
fec2107c
EZ
9203 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9204 EMACS_INT.
fc6f18ce 9205
40087514 92062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9207
57f53182
PE
9208 Malloc failure behavior now depends on size of allocation.
9209 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9210 * lisp.h: Change signatures accordingly.
9211 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9212 All callers changed. (Bug#8762)
9213
9214 * gnutls.c: Use Emacs's memory allocators.
9215 Without this change, the gnutls library would invoke malloc etc.
9216 directly, which causes problems on non-SYNC_INPUT hosts, and which
9217 runs afoul of improving memory_full behavior. (Bug#8761)
9218 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9219 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9220 xfree instead of the default malloc, realloc, free.
9221 (Fgnutls_boot): No need to check for memory allocation failure,
9222 since xmalloc does that for us.
9223
ac32cd99 9224 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9225 * category.c (hash_get_category_set):
9226 * ccl.c (ccl_driver):
9227 * charset.c (Fdefine_charset_internal):
9228 * charset.h (struct charset.hash_index):
9229 * composite.c (get_composition_id, gstring_lookup_cache)
9230 (composition_gstring_put_cache):
9231 * composite.h (struct composition.hash_index):
9232 * dispextern.h (struct image.hash):
9233 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9234 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9235 (hashfn_equal, hashfn_user_defined, make_hash_table)
9236 (maybe_resize_hash_table, hash_lookup, hash_put)
9237 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9238 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9239 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9240 * image.c (make_image, search_image_cache, lookup_image)
9241 (xpm_put_color_table_h):
9242 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9243 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9244 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9245 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9246 * alloc.c (allocate_vectorlike):
9247 Check for overflow in vector size calculations.
9248 * ccl.c (ccl_driver):
9249 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9250 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9251 need to be updated by these changes.
40087514
PE
9252 * fns.c (make_hash_table, maybe_resize_hash_table):
9253 Check for integer overflow with large hash tables.
0de4bb68
PE
9254 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9255 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9256 (SXHASH_REDUCE): New macro.
9257 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9258 Use it instead of discarding useful hash info with large hash values.
9259 (sxhash_float): New function.
9260 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9261 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9262 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9263 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9264 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9265 Adjust signatures to match updated version of code.
9266 (consing_since_gc): Now EMACS_INT, since a single hash table can
9267 use more than INT_MAX bytes.
9268
698d32e2
DN
92692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9270
9271 Make it possible to build with GCC-4.6+ -O2 -flto.
9272
9273 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9274
fd6fa53f
SM
92752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9276
9277 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9278 Call minibuffer-inactive-mode.
9279
864db017
JB
92802011-05-31 Juanma Barranquero <lekktu@gmail.com>
9281
9282 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9283 Update dependencies.
9284
2ad0baf4
DN
92852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9286
9287 * data.c (init_data): Remove code for UTS, this system is not
9288 supported anymore.
9289
4fcc2638
DN
92902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9291
9292 Don't force ./temacs to start in terminal mode.
9293
9294 * frame.c (make_initial_frame): Initialize faces in all cases, not
9295 only when CANNOT_DUMP is defined.
9296 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9297
c56e0fd5
DN
92982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9299
9300 * dispnew.c (add_window_display_history): Use const for the string
9301 pointer. Remove declaration, not needed.
9302
333d54da 93032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9304
55d4c1b2 9305 Use 'inline', not 'INLINE'.
333d54da 9306 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9307 * alloc.c, fontset.c (INLINE): Remove.
9308 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9309 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9310 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9311 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9312 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9313
738db178
DN
93142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9315
9316 Make it possible to run ./temacs.
9317
9318 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9319 syms_of_callproc does the same thing. Remove test for
9320 "initialized", do it in the caller.
9321 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9322
620c53a6
SM
93232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9324
9325 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9326 (read_minibuf): Use get_minibuffer.
9327 (syms_of_minibuf): Use DEFSYM.
9328 (Qmetadata): New var.
9329 * data.c (Qbuffer): Don't make it static.
9330 (syms_of_data): Use DEFSYM.
9331
e003a292
PE
93322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9333
9334 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9335 (CCL_CODE_MIN): New macro.
9336
ed008a6d
PE
93372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9338
3687c2ef
PE
9339 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9340
ed008a6d
PE
9341 * eval.c (Qdebug): Now static.
9342 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9343 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9344 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9345
d66c4c7c
CY
93462011-05-29 Chong Yidong <cyd@stupidchicken.com>
9347
9348 * image.c: Various fixes to ImageMagick code comments.
9349 (Fimagemagick_types): Doc fix.
9350
5fbc2025
PE
93512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9352
0196f88a
PE
9353 Minor fixes prompted by GCC 4.6.0 warnings.
9354
9355 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9356
5fbc2025
PE
9357 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9358 (x_clipboard_manager_save_all): Move extern decl to ...
9359 * xterm.h: ... here, so that it can be checked for consistency.
9360
1dd3c2d9
CY
93612011-05-29 Chong Yidong <cyd@stupidchicken.com>
9362
9363 * xselect.c (x_clipboard_manager_save_frame)
9364 (x_clipboard_manager_save_all): New functions.
9365 (Fx_clipboard_manager_save): Lisp function deleted.
9366
9367 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9368 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9369
9370 * xterm.h: Update prototype.
9371
5ba6571d
WX
93722011-05-28 William Xu <william.xwl@gmail.com>
9373
9374 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9375 exiting (Bug#8239).
9376
3eaff834
JM
93772011-05-28 Jim Meyering <meyering@redhat.com>
9378
e1900994 9379 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9380 * fns.c (to_uchar): Define.
9381 (crypto_hash_function): Use it to convert some newly-signed
9382 variables to unsigned, to avoid sign-extension bugs. For example,
9383 without this change, (md5 "truc") would evaluate to
9384 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9385 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9386 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9387
0f6990a7
PE
93882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9389
9390 Integer overflow fixes.
c8a9ca5a 9391
08686060
PE
9392 * dbusbind.c: Serial number integer overflow fixes.
9393 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9394 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9395 to hold a serial number that is too large for a fixnum.
9396 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9397 Check for serial numbers out of range. Decode any serial number
59568bf0 9398 that was so large that it became a float. (Bug#8722)
08686060 9399
2d1fc3c7
PE
9400 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9401 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9402 Use XFASTINT rather than XUINT when numbers are nonnegative.
9403 (xd_append_arg, Fdbus_method_return_internal):
9404 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9405 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9406 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9407 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9408 (Bug#8722)
2d1fc3c7 9409
c8a9ca5a
PE
9410 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9411
519e1d69
PE
9412 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9413
6df6ae42 9414 ccl: Add integer overflow checks.
30569699
PE
9415 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9416 (IN_INT_RANGE): New macros.
9417 (ccl_driver): Use them to check for integer overflow when
9418 decoding a CCL program. Many of the new checks are whether XINT (x)
9419 fits in int; it doesn't always, on 64-bit hosts. The new version
9420 doesn't catch all possible integer overflows, but it's an
847044ea 9421 improvement. (Bug#8719)
30569699 9422
c11285dc
PE
9423 * alloc.c (make_event_array): Use XINT, not XUINT.
9424 There's no need for unsigned here.
9425
fdccd48e
PE
9426 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9427 This follows up to the 2011-05-06 change that substituted uintptr_t
9428 for EMACS_INT. This case wasn't caught back then.
9429
37910ab2
PE
9430 Rework Fformat to avoid integer overflow issues.
9431 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9432 now (part of C89). Include <verify.h>.
9433 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9434 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9435 (Fformat): Avoid the prepass trying to compute sizes; it was only
9436 approximate and thus did not catch overflow reliably. Instead, walk
9437 through the format just once, formatting and computing sizes as we go,
9438 checking for integer overflow at every step, and allocating a larger
9439 buffer as needed. Keep track separately whether the format is
9440 multibyte. Keep only the most-recently calculated precision, rather
9441 than them all. Record whether each argument has been converted to
9442 string. Use EMACS_INT, not int, for byte and char and arg counts.
9443 Support field widths and precisions larger than INT_MAX. Avoid
9444 sprintf's undefined behavior with conversion specifications such as %#d
9445 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9446 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9447 formatting out-of-range floating point numbers with int
9173deec 9448 formats. (Bug#8668)
37910ab2 9449
2e6578fb
PE
9450 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9451
0ae6bdee
PE
9452 * data.c: Avoid integer truncation in expressions involving floats.
9453 * data.c: Include <intprops.h>.
9454 (arith_driver): When there's an integer overflow in an expression
9455 involving floating point, convert the integers to floating point
9456 so that the resulting value does not suffer from catastrophic
9457 integer truncation. For example, on a 64-bit host (* 4
9458 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9459 Do not rely on undefined behavior after integer overflow.
9460
de883a70
PE
9461 merge count_size_as_multibyte, parse_str_to_multibyte
9462 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9463 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9464 Check for integer overflow.
9465 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9466 since it's now a duplicate of the other. This is more of
9467 a character than a buffer op, so better that it's in character.c.
9468 * fns.c, print.c: Adjust to above changes.
9469
2ff916cb
PE
94702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9471
9472 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9473
f1b54466
PE
94742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9475
fb1ac845
PE
9476 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9477 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9478 (x_clipboard_manager_save): Now static.
9479 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9480
f1b54466
PE
9481 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9482 (crypto_hash_function): Now static.
9483 Fix pointer signedness problems. Avoid unnecessary initializations.
9484
a9f737ee
CY
94852011-05-27 Chong Yidong <cyd@stupidchicken.com>
9486
9487 * termhooks.h (Vselection_alist): Make it terminal-local.
9488
9489 * terminal.c (create_terminal): Initialize it.
9490
9491 * xselect.c: Support for clipboard managers.
9492 (Vselection_alist): Move to termhooks.h as terminal-local var.
9493 (LOCAL_SELECTION): New macro.
9494 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9495 (symbol_to_x_atom): Remove gratuitous arg.
9496 (x_handle_selection_request, lisp_data_to_selection_data)
9497 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9498 (x_own_selection, x_get_local_selection, x_convert_selection):
9499 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9500 (some_frame_on_display): Delete unused function.
9501 (Fx_own_selection_internal, Fx_get_selection_internal)
9502 (Fx_disown_selection_internal, Fx_selection_owner_p)
9503 (Fx_selection_exists_p): New optional frame arg.
9504 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9505 (x_handle_selection_clear): Don't treat other terminals with the
9506 same keyboard specially. Use the terminal-local Vselection_alist.
9507 (x_clear_frame_selections): Use Frun_hook_with_args.
9508
9509 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9510
9511 * xterm.h: Add support for those atoms.
9512
e067f0c1
CY
95132011-05-26 Chong Yidong <cyd@stupidchicken.com>
9514
9515 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9516 (converted_selections, conversion_fail_tag): New global variables.
9517 (x_selection_request_lisp_error): Free the above.
9518 (x_get_local_selection): Remove unnecessary code.
9519 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9520 of converted selections stored in converted_selections.
9521 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9522 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9523 (x_convert_selection): New function.
9524 (x_handle_selection_event): Simplify.
9525 (x_get_foreign_selection): Don't ignore incoming requests while
9526 waiting for an answer; this will fail when we implement
9527 SAVE_TARGETS, and seems unnecessary anyway.
9528 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9529 (Vx_sent_selection_functions): Doc fix.
9530
0f4aebc0
LL
95312011-05-26 Leo Liu <sdl.web@gmail.com>
9532
9533 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9534
e61124cd
YM
95352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9536
9537 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9538
9539 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9540 for fringe update if it has periodic bitmap.
ac389d0c 9541 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9542 and fringe_bitmap_periodic_p.
9543
9544 * fringe.c (get_fringe_bitmap_data): New function.
9545 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9546 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9547 row. Mark glyph row for fringe update if periodicity changed.
9548
9549 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9550 for fringe update unless it has periodic bitmap.
9551
f16d9837
KH
95522011-05-25 Kenichi Handa <handa@m17n.org>
9553
9554 * xdisp.c (get_next_display_element): Set correct it->face_id for
9555 a static composition.
9556
e1b90ef6
LL
95572011-05-24 Leo Liu <sdl.web@gmail.com>
9558
9559 * deps.mk (fns.o):
9560 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9561
9562 * fns.c (crypto_hash_function, Fsha1): New function.
9563 (Fmd5): Use crypto_hash_function.
9564 (syms_of_fns): Add Ssha1.
9565
7400048f
PE
95662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9567
9568 * gnutls.c: Remove unused macros.
9569 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9570 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9571 Remove macros that are defined and never used.
9572 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9573
abb71cf4
CY
95742011-05-22 Chong Yidong <cyd@stupidchicken.com>
9575
9576 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9577 (Fx_get_selection_internal): Minor cleanup.
9578 (Fx_own_selection_internal): Rename arguments for consistency with
9579 select.el.
9580
6307db39
PE
95812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9582
9583 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9584
f3d4e0a4
CY
95852011-05-22 Chong Yidong <cyd@stupidchicken.com>
9586
9587 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9588
4d8ade89
YM
95892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9590
9591 * dispnew.c (scrolling_window): Don't exclude the case that the
9592 last enabled row in the desired matrix touches the bottom boundary.
9593
32078c8d
GM
95942011-05-21 Glenn Morris <rgm@gnu.org>
9595
9596 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9597 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9598 and add some more files.
32078c8d 9599
7285dc67
EZ
96002011-05-20 Eli Zaretskii <eliz@gnu.org>
9601
9602 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9603 report_file_error introduced by the change from 2011-05-07.
9604
89d1bd22
PE
96052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9606
9607 * systime.h (Time): Define only if emacs is defined.
9608 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9609 where the include path doesn't have X11/X.h by default. See
9610 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9611
cd394be1 96122011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9613
9614 * composite.c (find_automatic_composition): Fix previous change.
9615
b9704ad9
GM
96162011-05-20 Glenn Morris <rgm@gnu.org>
9617
9618 * lisp.mk: New file, split from Makefile.in.
9619 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9620 (shortlisp): Remove.
9621 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9622
4a720484
GM
96232011-05-19 Glenn Morris <rgm@gnu.org>
9624
9625 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9626 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9627 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9628 (lisp): Set the order to that of loadup.el.
9629 (shortlisp): Make it a copy of $lisp.
9630 (SOME_MACHINE_LISP): Remove.
9631 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9632 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9633
a28d4396
KH
96342011-05-18 Kenichi Handa <handa@m17n.org>
9635
9636 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9637 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9638 (find_automatic_composition): Mostly rewrite for efficiency.
9639
a2b1fa8e
JB
96402011-05-18 Juanma Barranquero <lekktu@gmail.com>
9641
9642 * makefile.w32-in: Update dependencies.
9643
8e1f5610
CS
96442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9645
9646 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9647 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9648
7025ee00 96492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9650
cdfa6eab
PE
9651 Fix some integer overflow issues, such as string length overflow.
9652
06d6db33
PE
9653 * insdel.c (count_size_as_multibyte): Check for string overflow.
9654
2b4560a8
PE
9655 * character.c (lisp_string_width): Check for string overflow.
9656 Use EMACS_INT, not int, for string indexes and lengths; in
9657 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9658 the resulting string length overflows an EMACS_INT; instead,
9659 report a string overflow if no precision given. When checking for
9660 precision exhaustion, use a check that cannot possibly have
9661 integer overflow. (Bug#8675)
9662 * character.h (lisp_string_width): Adjust to new signature.
9663
cb93f9be
PE
9664 * alloc.c (string_overflow): New function.
9665 (Fmake_string): Use it. This doesn't change behavior, but saves
9666 a few bytes and will simplify future changes.
9667 * character.c (string_escape_byte8): Likewise.
9668 * lisp.h (string_overflow): New decl.
9669
1a1f3366
PE
9670 Fixups, following up to the user-interface timestamp change.
9671 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9672 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9673 * msdos.c (mouse_get_pos): Likewise.
9674 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9675 * w32gui.h (Time): Define by including "systime.h" rather than by
9676 declaring it ourselves. (Bug#8664)
9677
d4e3e4d3
PE
9678 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9679 * image.c (clear_image_cache): Likewise.
9680
f6a24d19
PE
9681 * term.c (term_mouse_position): Don't assume time_t wraparound.
9682
08dc5ae6
PE
9683 Be more systematic about user-interface timestamps.
9684 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9685 and sometimes 'EMACS_UINT', to represent these timestamps.
9686 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9687 This makes the code easier to follow, and makes it easier to catch
9688 integer overflow bugs such as Bug#8664.
9689 * frame.c (Fmouse_position, Fmouse_pixel_position):
9690 Use Time, not unsigned long, for user-interface timestamps.
9691 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9692 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9693 * keyboard.h (last_event_timestamp): Likewise.
9694 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9695 * menu.h (xmenu_show): Likewise.
9696 * term.c (term_mouse_position): Likewise.
9697 * termhooks.h (struct input_event.timestamp): Likewise.
9698 (struct terminal.mouse_position_hook): Likewise.
9699 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9700 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9701 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9702 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9703 what it was before.
9704 * menu.h, termhooks.h: Include "systime.h", for Time.
9705
8e55734a
PE
9706 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9707 Don't assume that the difference between two unsigned long values
9708 can fit into an integer. At this point, we know button_down_time
9709 <= event->timestamp, so the difference must be nonnegative, so
9710 there's no need to cast the result if double-click-time is
9711 nonnegative, as it should be; check that it's nonnegative, just in
9712 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9713 apart (about 25 days). (Bug#8664)
8e55734a 9714
841f1b75 9715 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9716 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9717
3e26f69c
PE
9718 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9719 that always fit in int. Use a sentinel instead of a counter, to
9720 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9721 * frame.h (struct frame): Use int for menu_bar_items_used
9722 instead of EMACS_INT, since it always fits in int.
3e26f69c 9723
5cc152c0
PE
9724 * menu.c (grow_menu_items): Check for int overflow.
9725
d89eb65e
PE
9726 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9727
5235bd3e
PE
9728 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9729 Before, the code was not consistent. These values cannot exceed
9730 2**31 - 1 so there's no need to make them unsigned.
9731 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9732 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9733 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9734 as modifiers.
9735 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9736
bc827e23
PE
9737 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9738 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9739 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9740 presumably because the widths might not match.
9741
78eb494e
PE
9742 * window.c (size_window): Avoid needless test at loop start.
9743
04f2d78b
CB
97442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9745
9746 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9747
d2fc7e3d 97482011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9749
9750 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9751
d2fc7e3d 97522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9753
9754 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9755 `width' to `bar_area_x' and `bar_area_width', respectively.
9756 (x_scroll_run): Take account of fringe background extension.
9757
04f2d78b
CB
9758 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9759 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9760 `bar_area_width', respectively.
9761 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9762 background extension.
9763
79b70037
GM
97642011-05-10 Jim Meyering <meyering@redhat.com>
9765
9766 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9767
2f142cc5
JB
97682011-05-10 Juanma Barranquero <lekktu@gmail.com>
9769
9770 * image.c (Finit_image_library): Return t for built-in image types,
9771 like pbm and xbm. (Bug#8640)
9772
57679c86
AS
97732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9774
9775 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9776
888c9e86
EZ
97772011-05-07 Eli Zaretskii <eliz@gnu.org>
9778
b0512a1d
EZ
9779 * w32console.c (Fset_screen_color): Doc fix.
9780 (Fget_screen_color): New function.
9781 (syms_of_ntterm): Defsubr it.
9782
7285dc67
EZ
9783 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9784 unlink the temporary file if Fcall_process didn't create it in the
9785 first place.
9786 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9787 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9788 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9789 cue to call_process_cleanup not to close that handle.
9790
4d3fcc8e
BK
97912011-05-07 Ben Key <bkey76@gmail.com>
9792
9793 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9794 one of two shell specific rules, either bootstrap-temacs-CMD or
9795 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9796 to the previous implementation of the bootstrap-temacs rule.
9797 The bootstrap-temacs-CMD rule is similar to the previous
9798 implementation of the bootstrap-temacs rule except that it
9799 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9800 variable.
9801
9802 These changes, along with some changes to nt/configure.bat,
9803 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9804 earlier fix to add support for --cflags and --ldflags options
9805 that include quotes so that it works whether make uses cmd or
9806 sh as the shell.
9807
b4289b64
MA
98082011-05-06 Michael Albinus <michael.albinus@gmx.de>
9809
9810 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9811 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9812 is a constant.
9813 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9814 a string. Handle both cases.
9815 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9816 (Fdbus_register_method): Use Qinvalid_function.
9817
af4c0e28
JB
98182011-05-06 Juanma Barranquero <lekktu@gmail.com>
9819
9820 * makefile.w32-in: Update dependencies.
9821 (LISP_H): Add inttypes.h and stdin.h.
9822 (PROCESS_H): Add unistd.h.
9823
c51453d9
EZ
98242011-05-06 Eli Zaretskii <eliz@gnu.org>
9825
9826 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9827 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9828
8ff0ac3c 98292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9830
4c4b566b
PE
9831 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9832
aab2b9b5
PE
9833 * term.c (vfatal): Remove stray call to va_end.
9834 It's not needed and the C Standard doesn't allow it here anyway.
9835
c378da0b
PE
9836 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9837 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9838
288b08c7
PE
9839 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9840 bytes.
9841
e3601888
PE
9842 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9843
db6c0e74
PE
9844 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9845
dd5963ea
PE
9846 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9847
88c9450f
PE
9848 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9849
2f9442b8
PE
9850 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9851
c032b5f8
PE
9852 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9853 * charset.c (Fdefine_charset_internal): Don't initialize
9854 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9855 32-bit int (Bug#8600).
a108c10b
PE
9856
9857 * lread.c (read_integer): Be more consistent with string-to-number.
9858 Use string_to_number to do the actual conversion; this avoids
9859 rounding errors and fixes some other screwups. Without this fix,
9860 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9861 (digit_to_number): Move earlier, for benefit of read_integer.
9862 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9863 not a digit in any supported base. (Bug#8602)
a108c10b 9864
ad5f9eea
PE
9865 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9866
aec1708a
PE
9867 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9868 to match comment at start of function. This also removes a
9869 GCC warning about overflow in a 32+64-bit port.
9870
47be4ab5
PE
9871 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9872
371cac43
PE
9873 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9874 Reported by Stefan Monnier in
9875 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9876 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9877 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9878
d01a7826
PE
9879 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9880 (EMACS_UINTPTR): Likewise, with uintptr_t.
9881
7fd47d5c
PE
9882 * lisp.h: Prefer 64-bit EMACS_INT if available.
9883 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9884 on 32-bit hosts that have 64-bit int, so that they can access
9885 large files.
122b0c86
PE
9886 However, temporarily disable this change unless the temporary
9887 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9888
8727937b
PE
9889 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9890
8ac068ac
PE
9891 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9892 This removes an assumption that EMACS_INT and long are the same
9893 width as pointers. The assumption is true for Emacs porting targets
9894 now, but we want to make other targets possible.
9895 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9896 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9897 In the rest of the code, change types of integers that hold casted
9898 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9899 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9900 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9901 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9902 No need to cast type when ORing.
9903 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9904 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9905 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9906 assume EMACS_INT is the same width as char *.
9907 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9908 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9909 Remove no-longer-needed casts.
9910 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9911 (xg_tool_bar_help_callback, xg_make_tool_item):
9912 Use EMACS_INTPTR to hold an integer
9913 that will be cast to void *; this can avoid a GCC warning
9914 if EMACS_INT is not the same width as void *.
9915 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9916 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9917 (current_message_1, set_message_1):
9918 Use a local to convert to proper width without a cast.
9919 * xmenu.c (dialog_selection_callback): Likewise.
9920
ede49d71
PE
9921 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9922 Also, don't assume VALBITS / RAND_BITS is less than 5,
9923 and don't rely on undefined behavior when shifting a 1 left into
9924 the sign bit.
9925 * lisp.h (get_random): Change signature to match.
9926
2f30ecd0
PE
9927 * lread.c (hash_string): Use size_t, not int, for hash computation.
9928 Normally we prefer signed values; but hashing is special, because
9929 it's better to use unsigned division on hash table sizes so that
9930 the remainder is nonnegative. Also, size_t is the natural width
9931 for hashing into memory. The previous code used 'int', which doesn't
9932 retain enough info to hash well into very large tables.
9933 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9934
2a866e7b
PE
9935 * dbusbind.c: Don't possibly lose pointer info when converting.
9936 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9937 Use XPNTR rather than XHASH, so that the high-order bits of
9938 the pointer aren't lost when converting through void *.
9939
51639eac
PE
9940 * eval.c (Fautoload): Don't double-shift a pointer.
9941
92394119
PE
9942 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9943
dbdb9a7c
JB
99442011-05-06 Juanma Barranquero <lekktu@gmail.com>
9945
9946 * gnutls.c (DEF_GNUTLS_FN):
9947 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9948
db7a0b4f
AS
99492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9950
9951 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9952 marker. (Bug#8610)
9953
cd394be1 99542011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9955
9956 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9957 New version that can reserve upto 2GB of heap space.
9958
f7ff1b0f 99592011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9960
9961 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9962
639c109b
TZ
99632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9964
9965 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9966 `gnutls_certificate_set_x509_key_file'.
9967
d2127135
JB
99682011-05-05 Juanma Barranquero <lekktu@gmail.com>
9969
9970 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9971 Update dependencies.
9972
e968f4f3
JB
99732011-05-04 Juanma Barranquero <lekktu@gmail.com>
9974
9975 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9976 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9977 Remove unused parameter `fildes'.
9978 * process.c (read_process_output, send_process): Don't pass it.
9979
84d358f0
JB
99802011-05-04 Juanma Barranquero <lekktu@gmail.com>
9981
9982 Fix previous change: the library cache is defined in w32.c.
9983 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9984 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9985
0898ca10
JB
99862011-05-04 Juanma Barranquero <lekktu@gmail.com>
9987
9988 Implement dynamic loading of GnuTLS on Windows.
9989
9990 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9991 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9992 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9993 Declare.
9994
9995 * gnutls.c (Qgnutls_dll): Define.
9996 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9997 (gnutls_*): Declare function pointers.
9998 (init_gnutls_functions): New function to initialize function pointers.
9999 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10000 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10001 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10002 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10003 (emacs_gnutls_write, emacs_gnutls_read)
10004 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10005 (Fgnutls_available_p): New function.
10006 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10007 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10008 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10009
10010 * image.c: Include w32.h.
10011 (Vimage_type_cache): Delete.
10012 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10013 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10014 (w32_delayed_load): Move to w32.c.
10015
10016 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10017
10018 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10019 (w32_delayed_load): Move from image.c. When loading a library, record
10020 its filename in the :loaded-from property of the library id.
10021 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10022 Initialize and staticpro them.
10023 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10024
10025 * process.c: Include lisp.h before w32.h, not after.
10026 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10027 instead of gnutls_record_check_pending.
10028
10029 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10030
ff4de4aa
TZ
100312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10032
10033 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10034 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10035 as passed in.
10036
abe95abb
JD
100372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10038
10039 * xterm.c (x_set_frame_alpha): Do not set property on anything
10040 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10041
e16e55d4
JB
100422011-05-02 Juanma Barranquero <lekktu@gmail.com>
10043
10044 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10045
bafcf6a5
JB
100462011-05-02 Juanma Barranquero <lekktu@gmail.com>
10047
10048 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10049 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10050 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10051 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10052 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10053 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10054 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10055 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10056 (Qgnutls_bootprop_callbacks_verify): Make static.
10057
e7a6747f
AS
100582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10059
19ed11ba
AS
10060 * callproc.c: Indentation fixup.
10061
e7a6747f 10062 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10063 (wait_for_termination, interruptible_wait_for_termination):
10064 Move after wait_for_termination_1.
e7a6747f 10065
1ef14cb4
LMI
100662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10067
10068 * sysdep.c (interruptible_wait_for_termination): New function
10069 which is like wait_for_termination, but allows keyboard
10070 interruptions.
10071
10072 * callproc.c (Fcall_process): Add (:file "file") as an option for
10073 the STDOUT buffer.
10074 (Fcall_process_region): Ditto.
10075
330d880c
EZ
100762011-04-30 Eli Zaretskii <eliz@gnu.org>
10077
8db90b73
EZ
10078 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10079 rather than `XVECTOR (FOO)->size'.
10080
330d880c
EZ
10081 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10082 inttypes.h, as a gnulib replacement is used if it not available in
10083 system headers.
10084
15cbd324
EZ
100852011-04-21 Eli Zaretskii <eliz@gnu.org>
10086
10087 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10088 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10089 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10090
10091 * coding.c (coding_alloc_by_realloc): Error out if destination
10092 will grow beyond MOST_POSITIVE_FIXNUM.
10093 (decode_coding_emacs_mule): Abort if there isn't enough place in
10094 charbuf for the composition carryover bytes. Reserve an extra
10095 space for up to 2 characters produced in a loop.
10096 (decode_coding_iso_2022): Abort if there isn't enough place in
10097 charbuf for the composition carryover bytes.
10098
100992011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10100
ae940cca
EZ
10101 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10102 aborting when %lld or %lll format is passed.
10103 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10104 %llo or %llx format is passed. (Bug#8545)
10105
03ab8921
EZ
10106 * window.c (window_scroll_line_based): Use a marker instead of
10107 simple variables to record original value of point. (Bug#7952)
10108
afda1437
EZ
10109 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10110 produced by %s or %c overflows available buffer space. (Bug#8545)
10111
f76dee0c
PE
101122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10113
10114 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10115 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10116
fdc5744d
JB
101172011-04-28 Juanma Barranquero <lekktu@gmail.com>
10118
10119 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10120
638f053a
JB
101212011-04-28 Juanma Barranquero <lekktu@gmail.com>
10122
10123 * keyboard.c (Qdelayed_warnings_hook): Define.
10124 (command_loop_1): Run `delayed-warnings-hook'
10125 if Vdelayed_warnings_list is non-nil.
10126 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10127 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10128
d178f871
EZ
101292011-04-28 Eli Zaretskii <eliz@gnu.org>
10130
10131 * doprnt.c (doprnt): Don't return value smaller than the buffer
10132 size if the message was truncated. (Bug#8545).
10133
b124fd93
JB
101342011-04-28 Juanma Barranquero <lekktu@gmail.com>
10135
10136 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10137 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10138
e810457d
PE
101392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10140
10141 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10142
ea51cceb
JB
101432011-04-27 Juanma Barranquero <lekktu@gmail.com>
10144
10145 * makefile.w32-in: Update dependencies.
10146
94dcfacf
EZ
101472011-04-27 Eli Zaretskii <eliz@gnu.org>
10148
10149 Improve `doprnt' and its usage. (Bug#8545)
10150 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10151 `format_end'. Remove support for %l as a conversion specifier.
10152 Don't use xrealloc. Improve diagnostics when the %l size modifier
10153 is used. Update the commentary.
10154
10155 * eval.c (verror): Simplify calculation of size_t.
10156
10157 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10158 messages.
10159
f61f41d7
PE
101602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10161
10162 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10163 change.
10164
96fb4434
PE
101652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10166
10167 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10168 This makes this file independent of the recent pseudovector change.
10169
671875da 101702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10171
69e9b5a3
PE
10172 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10173
b5f869a7 10174 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10175 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10176 Remove unused local.
c8926152 10177 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10178
841a1577 10179 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10180 GCC 4.6.0 optimizes based on type-based alias analysis.
10181 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10182 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10183 != &v->size, and therefore "v->size = 1; b->size = 2; return
10184 v->size;" must therefore return 1. This assumption is incorrect
10185 for Emacs, since it type-puns struct Lisp_Vector * with many other
10186 types. To fix this problem, this patch adds a new type struct
f904488f 10187 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10188 and pseudovectors, and helps optimizing compilers not get fooled
10189 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10190 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10191 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10192 the size member.
eab3844f
PE
10193 (XSETPVECTYPE): Rewrite in terms of new macro.
10194 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10195 This is a bit clearer, and further avoids the possibility of
10196 undesirable aliasing.
10197 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10198 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10199 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10200 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10201 (ASIZE): Now uses header.size rather than size.
10202 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10203 to avoid the hassle of writing XVECTOR (foo)->header.size.
10204 (struct vectorlike_header): New type.
eab3844f
PE
10205 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10206 object, to help avoid aliasing.
10207 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10208 (SUBRP): Likewise, since Lisp_Subr is a special case.
10209 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10210 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10211 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10212 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10213 changed to be "header.size" and "header.next".
10214 * buffer.h (struct buffer): Likewise.
10215 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10216 * frame.h (struct frame): Likewise.
10217 * process.h (struct Lisp_Process): Likewise.
10218 * termhooks.h (struct terminal): Likewise.
10219 * window.c (struct save_window_data, struct saved_window): Likewise.
10220 * window.h (struct window): Likewise.
10221 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10222 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10223 * buffer.c (init_buffer_once): Likewise.
10224 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10225 special case.
10226 * process.c (Fformat_network_address): Use local var for size,
10227 for brevity.
10228
0df1eac5
PE
10229 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10230
847ab9d1 10231 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10232 * data.c (atof): Remove decl; no longer used or needed.
10233 (digit_to_number): Move to lread.c.
10234 (Fstring_to_number): Use new string_to_number function, to be
10235 consistent with how the Lisp reader treats infinities and NaNs.
10236 Do not assume that floating-point numbers represent EMACS_INT
10237 without losing information; this is not true on most 64-bit hosts.
10238 Avoid double-rounding errors, by insisting on integers when
10239 parsing non-base-10 numbers, as the documentation specifies.
10240 * lisp.h (string_to_number): New decl, replacing ...
10241 (isfloat_string): Remove.
bc0a5c13 10242 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10243 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10244 appears to have been a coding error. Similarly, do not accept
10245 strings like +-1e0 as floating point numbers. Do not report
10246 overflow for integer overflows unless the base is not 10 which
10247 means we have no simple and reliable way to continue.
10248 Break out the floating-point parsing into a new
10249 function string_to_number, so that Fstring_to_number parses
10250 floating point numbers consistently with the Lisp reader.
04f2d78b 10251 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10252 (E_CHAR, EXP_INT): Remove, replacing with ...
10253 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10254 (string_to_number): New function, replacing isfloat_string.
10255 This function checks for valid syntax and produces the resulting
10256 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10257 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10258 so that overflow for non-base-10 numbers is reported only when
10259 there's no portable and simple way to convert to floating point.
452f4150 10260
67769ffc
PE
10261 * textprop.c (set_text_properties_1): Rewrite for clarity,
10262 and to avoid GCC warning about integer overflow.
10263
c20db43f
PE
10264 * intervals.h (struct interval): Use EMACS_INT for members
10265 where EMACS_UINT might cause problems. See
10266 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10267 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10268 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10269 All uses changed.
37aa2f85
PE
10270 (offset_intervals): Tell GCC not to worry about length overflow
10271 when negating a negative length.
c20db43f 10272
2538aa2f
PE
10273 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10274 (overrun_check_free): Likewise.
10275
f2d3008d
PE
10276 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10277 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10278 word size.
10279
ec8df744
PE
10280 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10281 (gnutls_make_error): Rename local to avoid shadowing.
10282 (gnutls_emacs_global_deinit): ifdef out; not used.
10283 (Fgnutls_boot): Use const for pointer to readonly storage.
10284 Comment out unused local. Fix pointer signedness problems.
10285
640ee02d
PE
10286 * lread.c (openp): Don't stuff size_t into an 'int'.
10287 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10288 about possible signed overflow.
10289
6048fb2a
PE
10290 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10291 (GDK_KEY_g): Don't define if already defined.
10292 (xg_prepare_tooltip): Avoid pointer signedness problem.
10293 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10294
fa3c87e1
PE
10295 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10296 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10297
2172544b
PE
10298 * xfns.c (Fx_window_property): Simplify a bit,
10299 to make a bit faster and to avoid GCC 4.6.0 warning.
10300 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10301
9b821a21
PE
10302 * fns.c (internal_equal): Don't assume size_t fits in int.
10303
3c616cfa
PE
10304 * alloc.c (compact_small_strings): Tighten assertion a little.
10305
c2982e87
PE
10306 Replace pEd with more-general pI, and fix some printf arg casts.
10307 * lisp.h (pI): New macro, generalizing old pEd macro to other
10308 conversion specifiers. For example, use "...%"pI"d..." rather
10309 than "...%"pEd"...".
10310 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10311 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10312 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10313 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10314 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10315 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10316 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10317 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10318 64-bit hosts.
10319 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10320 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10321 * print.c (safe_debug_print, print_object): Likewise.
10322 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10323 to int.
6f04d126
PE
10324 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10325 avoiding the 0 flag, which is not portable.
c2982e87
PE
10326 * process.c (Fmake_network_process): Use pI to avoid cast.
10327 * region-cache.c (pp_cache): Likewise.
10328 * xdisp.c (decode_mode_spec): Likewise.
10329 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10330 behavior on 64-bit hosts with printf arg.
6f04d126 10331 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10332 (x_stop_queuing_selection_requests): Likewise.
10333 (x_get_window_property): Don't truncate byte count to an 'int'
10334 when tracing.
0b432f21 10335
5e073ec7
PE
10336 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10337 here, since it parses constructs like leading '-' and spaces,
10338 which are not wanted; and it overflows with large numbers.
10339 Instead, simply match F[0-9]+, which is what is wanted anyway.
10340
36372bf9
PE
10341 * alloc.c: Remove unportable assumptions about struct layout.
10342 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10343 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10344 (allocate_vectorlike, make_pure_vector): Use the new macros,
10345 plus offsetof, to remove unportable assumptions about struct layout.
10346 These assumptions hold on all porting targets that I know of, but
10347 they are not guaranteed, they're easy to remove, and removing them
10348 makes further changes easier.
10349
0b432f21
PE
10350 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10351 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10352 (string_overrun_cookie): Now const. Use initializers that
10353 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10354 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10355 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10356 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10357 multiple of sizeof (EMACS_INT); it need not be, if
10358 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10359 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10360
895009e1
JB
103612011-04-26 Juanma Barranquero <lekktu@gmail.com>
10362
10363 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10364
6a7a1b0b
TZ
103652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10366
10367 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10368 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10369 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10370
841a1577 103712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10372
10373 * lisp.h (Qdebug): List symbol.
895009e1 10374 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10375 * keyboard.c (debug-on-event): New variable.
10376 (handle_user_signal): Break into debugger when debug-on-event
10377 matches the current signal symbol.
10378
f2d3ba6f
DN
103792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10380
10381 * alloc.c (check_sblock, check_string_bytes)
10382 (check_string_free_list): Convert to standard C.
10383
42ce4c63
TZ
103842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10385
10386 * w32.c (emacs_gnutls_push): Fix typo.
10387
825cd63c
EZ
103882011-04-25 Eli Zaretskii <eliz@gnu.org>
10389
fb11d64d
EZ
10390 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10391 "cast to pointer from integer of different size".
10392
825cd63c
EZ
10393 Improve doprnt and its use in verror. (Bug#8545)
10394 * doprnt.c (doprnt): Document the set of format control sequences
10395 supported by the function. Use SAFE_ALLOCA instead of always
10396 using `alloca'.
10397
10398 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10399 is one byte too soon. Don't use xrealloc; instead xfree and
10400 xmalloc anew.
10401
e061a11b
TZ
104022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10403
10404 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10405 callbacks stage.
10406
10407 * gnutls.c: Renamed global_initialized to
10408 gnutls_global_initialized. Added internals for the
10409 :verify-hostname-error, :verify-error, and :verify-flags
10410 parameters of `gnutls-boot' and documented those parameters in the
10411 docstring. Start callback support.
9173deec
JB
10412 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10413 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10414 on error. Return error code.
e061a11b
TZ
10415 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10416 (emacs_gnutls_read): Likewise.
10417 (Fgnutls_boot): Return handshake error code.
10418 (emacs_gnutls_handle_error): New function.
10419 (wsaerror_to_errno): Likewise.
10420
10421 * w32.h (emacs_gnutls_pull): Add prototype.
10422 (emacs_gnutls_push): Likewise.
10423
10424 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10425 (emacs_gnutls_push): Likewise.
10426
104272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10428
10429 * process.c (wait_reading_process_output): Check if GnuTLS
10430 buffered some data internally if no FDs are set for TLS
10431 connections.
10432
10433 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10434 (LIBS): Link to USER_LIBS.
10435 ($(BLD)/gnutls.$(0)): New target.
10436
fa6996bc
EZ
104372011-04-24 Eli Zaretskii <eliz@gnu.org>
10438
eb35682e
EZ
10439 * xdisp.c (handle_single_display_spec): Rename the
10440 display_replaced_before_p argument into display_replaced_p, to
10441 make it consistent with the commentary. Fix typos in the
10442 commentary.
10443
e2ad650c
EZ
10444 * textprop.c (syms_of_textprop): Remove dead code.
10445 (copy_text_properties): Delete obsolete commentary about an
10446 interface that was deleted long ago. Fix typos in the description
10447 of arguments.
10448
1b2de274
EZ
10449 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10450 to changes in oldXMenu/XMenu.h from 2011-04-16.
10451 <menu_help_message, prev_menu_help_message>: Constify.
10452 (IT_menu_make_room): menu->help_text is now `const char **';
10453 adjust.
10454
10455 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10456 to changes in oldXMenu/XMenu.h from 2011-04-16.
10457 (struct XMenu): Declare `help_text' `const char **'.
10458
10459 * xfaces.c <Qunspecified>: Make extern again.
10460
10461 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10462 required by POSIX.
1b2de274 10463
762b15be
EZ
10464 * doc.c (get_doc_string): Improve the format passed to `error'.
10465
10466 * doprnt.c (doprnt): Improve commentary.
10467
10468 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10469
10470 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10471 them with etags.
10472
f1052e5d
EZ
10473 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10474 changes in globals.h immediately force recompilation.
762b15be
EZ
10475 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10476 $(CURDIR)/s/ms-w32.h.
10477 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10478
fa6996bc
EZ
10479 * character.c (Fchar_direction): Function deleted.
10480 (syms_of_character): Don't defsubr it.
10481 <char-direction-table>: Deleted.
10482
e6c3da20
EZ
104832011-04-23 Eli Zaretskii <eliz@gnu.org>
10484
10485 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10486 * doprnt.c: Include limits.h.
10487 (SIZE_MAX): New macro.
04f2d78b
CB
10488 (doprnt): Return a size_t value. 2nd arg is now size_t.
10489 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10490 Improve overflow protection. Support `l' modifier for integer
10491 conversions. Support %l conversion. Don't assume an EMACS_INT
10492 argument for integer conversions and for %c.
10493
10494 * lisp.h (doprnt): Restore prototype.
10495
10496 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10497 $(SRC)/character.h.
10498
10499 * Makefile.in (base_obj): Add back doprnt.o.
10500
10501 * deps.mk (doprnt.o): Add back prerequisites.
10502 (callint.o): Depend on character.h.
10503
10504 * eval.c (internal_lisp_condition_case): Include the handler
10505 representation in the error message.
10506 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10507 when breaking from the loop.
10508
10509 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10510
10511 * callint.c (Fcall_interactively): When displaying error message
10512 about invalid control letter, pass the character's codepoint, not
10513 a pointer to its multibyte form. Improve display of the character
10514 in octal and display also its hex code.
10515
10516 * character.c (char_string): Use %x to display the (unsigned)
10517 codepoint of an invalid character, to avoid displaying a bogus
10518 negative value.
10519
10520 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10521 `error', not SYMBOL_NAME itself.
10522
10523 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10524 character arguments to `error'.
10525
10526 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10527 to `error' in error message about FINAL_CHAR argument. Make sure
10528 FINAL_CHAR is a character, and use %c when it is passed as
10529 argument to `error'.
10530
4ffd0d6b 105312011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10532
10533 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10534
10535 * w32.c: Include <time.h>.
10536 (sys_localtime): New function.
10537
4ffd0d6b 105382011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10539
10540 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10541
4ffd0d6b 10542 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10543
4ffd0d6b 105442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10545
4ffd0d6b
GM
10546 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10547 zombies (Bug#8467).
aac0c6e3 10548
04c56954
EZ
105492011-04-19 Eli Zaretskii <eliz@gnu.org>
10550
10551 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10552 gl_state.e_property when gl_state.object is Qt.
10553
10554 * insdel.c (make_gap_larger): Remove limitation of buffer size
10555 to <= INT_MAX.
10556
16a43933
CY
105572011-04-18 Chong Yidong <cyd@stupidchicken.com>
10558
10559 * xdisp.c (lookup_glyphless_char_display)
10560 (produce_glyphless_glyph): Handle cons cell entry in
10561 glyphless-char-display.
10562 (Vglyphless_char_display): Document it.
10563
10564 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10565 glyphless-char-display.
10566
4581706e
CY
105672011-04-17 Chong Yidong <cyd@stupidchicken.com>
10568
10569 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10570
10571 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10572
10573 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10574 definition for no-X builds.
10575
4887c6e2 105762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10577
fd35b6f9
PE
10578 Static checks with GCC 4.6.0 and non-default toolkits.
10579
5c1ccb01
PE
10580 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10581
006c5daa
PE
10582 * process.c (keyboard_bit_set): Define only if SIGIO.
10583 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10584 (send_process): Repair possible setjmp clobbering.
10585
efc736d3
PE
10586 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10587
4e2fe2e6
PE
10588 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10589
f97334a2
PE
10590 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10591
4e75f29d
PE
10592 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10593 Define only if needed.
10594
90efadd1
PE
10595 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10596 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10597 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10598
3c647824
PE
10599 * dispextern.h (struct redisplay_interface): Rename param
10600 to avoid shadowing.
e264f262 10601 * termhooks.h (struct terminal): Likewise.
761383f4 10602 * xterm.c (xembed_send_message): Likewise.
3c647824 10603
b58c5c4a
PE
10604 * insdel.c (make_gap_smaller): Define only if
10605 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10606
cad59032
PE
10607 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10608 it.
10609
c339dc2e
PE
10610 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10611 so that we aren't warned about unused symbols.
10612
91a3e27b
PE
10613 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10614
399c71d3 10615 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10616
8ffc96f5
PE
10617 * xfns.c (x_real_positions): Mark locals as initialized.
10618
eef9bc79
PE
10619 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10620
098db9dd
PE
10621 * xterm.c: Fix problems found by static analysis with other toolkits.
10622 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10623 (x_dispatch_event): Declare static if USE_GTK, and
10624 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10625 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10626 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10627 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10628 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10629
eb18f6cc
PE
10630 * xmenu.c (menu_help_callback): Pointer type fixes.
10631 Use const pointers when pointing at readonly data. Avoid pointer
10632 signedness clashes.
10633 (FALSE): Remove unused macro.
10634 (update_frame_menubar): Remove unused decl.
10635
1fe72bf8
PE
10636 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10637
60d9e1db
PE
10638 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10639 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10640 (single_menu_item): Rename local to avoid shadowing.
10641
39261c26
PE
10642 * keyboard.c (make_lispy_event): Remove unused local var.
10643
018c5e19
PE
10644 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10645 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10646
63d2b86e
PE
10647 * bitmaps: Change bitmaps from unsigned char back to the X11
10648 compatible char. Avoid the old compiler warnings about
10649 out-of-range initializers by using, for example, '\xab' rather
10650 than 0xab.
10651
aefd87e1
PE
10652 * xgselect.c (xgselect_initialize): Check vs interface
10653 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10654
bf501fb9
PE
10655 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10656
e9829fdf
PE
10657 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10658 to read-only memory.
10659
1086c095
PE
10660 * fns.c (vector): Remove; this old hack is no longer needed.
10661
2baccd04 10662 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10663 Remove unused var.
dde42981 10664 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10665
72391843 10666 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10667
436c16df 10668 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10669 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10670 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10671
92bb796d 10672 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10673 (x_term_init): Remove local to avoid shadowing.
92bb796d 10674
764430a3 10675 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10676
10677 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10678 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10679
d1dfb56c
EZ
106802011-04-16 Eli Zaretskii <eliz@gnu.org>
10681
c4354cb4
EZ
10682 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10683
d1dfb56c
EZ
10684 Fix regex.c, syntax.c and friends for buffers > 2GB.
10685 * syntax.h (struct gl_state_s): Declare character position members
10686 EMACS_INT.
10687
10688 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10689
04f2d78b
CB
10690 * textprop.c (verify_interval_modification, interval_of):
10691 Declare arguments EMACS_INT.
d1dfb56c
EZ
10692
10693 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10694 EMACS_INT.
10695
10696 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10697
10698 * indent.c (Fvertical_motion): Local variable it_start is now
10699 EMACS_INT.
10700
10701 * regex.c (re_match, re_match_2, re_match_2_internal)
10702 (bcmp_translate, regcomp, regexec, print_double_string)
10703 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10704 (re_compile_pattern, re_exec): Declare arguments and local
10705 variables `size_t' and `ssize_t' and return values `regoff_t', as
10706 appropriate.
10707 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10708 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10709 <compile_stack_type>: `size' and `avail' are now `size_t'.
10710
10711 * regex.h <regoff_t>: Use ssize_t, not int.
10712 (re_search, re_search_2, re_match, re_match_2): Arguments that
10713 specify buffer/string position and length are now ssize_t and
10714 size_t. Return type is regoff_t.
10715
613052cd
BK
107162011-04-16 Ben Key <bkey76@gmail.com>
10717
10718 * nsfont.m: Fixed bugs in ns_get_family and
10719 ns_descriptor_to_entity that were caused by using free to
10720 deallocate memory blocks that were allocated by xmalloc (via
10721 xstrdup). This caused Emacs to crash when compiled with
10722 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10723 --enable-checking=xmallocoverrun). xfree is now used to
10724 deallocate these memory blocks.
10725
4170f62f 107262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10727
71b41406
PE
10728 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10729
9587a89d
PE
10730 emacs_write: Accept and return EMACS_INT for sizes.
10731 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10732 et seq.
10733 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10734 Accept and return EMACS_INT.
10735 (emacs_gnutls_write): Return the number of bytes written on
10736 partial writes.
10737 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10738 (emacs_read, emacs_write): Remove check for negative size, as the
10739 Emacs source code has been audited now.
9587a89d
PE
10740 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10741 (emacs_read, emacs_write): Use it.
273a5f82
PE
10742 * process.c (send_process): Adjust to the new signatures of
10743 emacs_write and emacs_gnutls_write. Do not attempt to store
10744 a byte offset into an 'int'; it might overflow.
9587a89d 10745 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10746
3e047f51
PE
10747 * sound.c: Don't assume sizes fit in 'int'.
10748 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10749 Return EMACS_INT, not int.
3e047f51 10750 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10751 Accept EMACS_INT, not int.
10752 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10753 record read return values.
10754
cc39a9db
BK
107552011-04-15 Ben Key <bkey76@gmail.com>
10756
c9d0ec6d
JB
10757 * keyboard.c (Qundefined): Don't declare static since it is used
10758 in nsfns.m.
10759 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10760 static since they are used in nsfont.m.
cc39a9db 10761
6c60eb9f
SM
107622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10763
10764 * process.c (Qprocessp): Don't declare static.
10765 * lisp.h (Qprocessp): Declare again.
10766
7990b61a
JB
107672011-04-15 Juanma Barranquero <lekktu@gmail.com>
10768
10769 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10770
5d4cb038
PE
107712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10772
8bd7b830 10773 Improve C-level modularity by making more things 'static'.
cd64ea1d 10774
e3b27b31
PE
10775 Don't publish debugger-only interfaces to other modules.
10776 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10777 (verify_bytepos, count_markers): Move decls to the only modules
10778 that need them.
10779 * region-cache.h (pp_cache): Likewise.
10780 * window.h (check_all_windows): Likewise.
10781 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10782
5d4cb038
PE
10783 * sysdep.c (croak): Now static, if
10784 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10785 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10786
10787 * alloc.c (refill_memory_reserve): Now static if
10788 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10789 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10790
e87b6180
PE
10791 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10792 Define only if USE_LUCID.
10793
ac64929e
PE
10794 * xrdb.c (x_customization_string, x_rm_string): Now static.
10795
6f37259d
PE
10796 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10797 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10798
1683e3ab
PE
10799 * xdisp.c (draw_row_with_mouse_face): Now static.
10800 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10801
de9c2632
PE
10802 * window.h (check_all_windows): Mark externally visible.
10803
2b96acb7
PE
10804 * window.c (window_deletion_count): Now static.
10805
10806 * undo.c: Make symbols static if they're not exported.
10807 (last_undo_buffer, last_boundary_position, pending_boundary):
10808 Now static.
10809
50436f33
PE
10810 * textprop.c (interval_insert_behind_hooks): Now static.
10811 (interval_insert_in_front_hooks): Likewise.
10812
64520e5c
PE
10813 * term.c: Make symbols static if they're not exported.
10814 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10815 (max_frame_lines, tty_set_terminal_modes):
10816 (tty_reset_terminal_modes, tty_turn_off_highlight):
10817 (get_tty_terminal): Now static.
10818 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10819 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10820 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10821 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10822 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10823
1fa53021
PE
10824 * sysdep.c: Make symbols static if they're not exported.
10825 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10826 Now static.
10827 (sigprocmask_set, full_mask): Remove; unused.
10828 (wait_debugging): Mark as visible.
10829 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10830 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10831
d4b43b22
PE
10832 * syntax.c (syntax_temp): Define only if !__GNUC__.
10833
b7c513d0
PE
10834 * sound.c (current_sound_device, current_sound): Now static.
10835
989b29ad
PE
10836 * search.c (searchbufs, searchbuf_head): Now static.
10837
13a55a78
PE
10838 * scroll.c (scroll_cost): Remove; unused.
10839 * dispextern.h (scroll_cost): Remove decl.
10840
de68a1fc
PE
10841 * region-cache.h (pp_cache): Mark as externally visible.
10842
40ccffa6
PE
10843 * process.c: Make symbols static if they're not exported.
10844 (process_tick, update_tick, create_process, chan_process):
10845 (Vprocess_alist, proc_buffered_char, datagram_access):
10846 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10847 (deactivate_process): Mark defn as static, as well as decl.
10848 * lisp.h (create_process): Remove decl.
10849 * process.h (chan_process, Vprocess_alist): Remove decls.
10850
ad64fc97
PE
10851 * print.c: Make symbols static if they're not exported.
10852 (print_depth, new_backquote_output, being_printed, print_buffer):
10853 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10854 (print_interval, print_number_index, initial_stderr_stream):
10855 Now static.
10856 * lisp.h (Fprinc): Remove decl.
10857 (debug_output_compilation_hack): Mark as externally visible.
10858
adddb265
PE
10859 * sysdep.c (croak): Move decl from here to syssignal.h.
10860 * syssignal.h (croak): Put it here, so the API can be checked when
10861 'croak' is called from dissociate_if_controlling_tty.
10862
1717ede2
PE
10863 * minibuf.c: Make symbols static if they're not exported.
10864 (minibuf_save_list, choose_minibuf_frame): Now static.
10865 * lisp.h (choose_minibuf_frame): Remove decl.
10866
fa5fb2bc
PE
10867 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10868
1e3890d1
PE
10869 * lread.c: Make symbols static if they're not exported.
10870 (read_objects, initial_obarray, oblookup_last_bucket_number):
10871 Now static.
10872 (make_symbol): Remove; unused.
10873 * lisp.h (initial_obarray, make_symbol): Remove decls.
10874
8a1414fa
PE
10875 * keyboard.c: Make symbols static if they're not exported.
10876 (single_kboard, recent_keys_index, total_keys, recent_keys):
10877 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10878 (this_single_command_key_start, echoing, last_auto_save):
10879 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10880 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10881 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10882 (Vlispy_mouse_stem, double_click_count):
10883 Now static.
10884 (force_auto_save_soon): Define only if SIGDANGER.
10885 (ignore_mouse_drag_p): Now static if
10886 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10887 (print_help): Remove; unused.
10888 (stop_character, last_timer_event): Mark as externally visible.
10889 * keyboard.h (ignore_mouse_drag_p): Declare only if
10890 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10891 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10892 * lisp.h (echoing): Remove decl.
10893 (force_auto_save_soon): Declare only if SIGDANGER.
10894 * xdisp.c (redisplay_window): Simplify code, to make it more
10895 obvious that ignore_mouse_drag_p is not accessed if !defined
10896 USE_GTK && !defined HAVE_NS.
10897
93ea6e8f
PE
10898 * intervals.c: Make symbols static if they're not exported.
10899 (merge_properties_sticky, merge_interval_right, delete_interval):
10900 Now static.
10901 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10902
77382fcc
PE
10903 * insdel.c: Make symbols static if they're not exported.
10904 However, leave prepare_to_modify_buffer alone. It's never
10905 called from outside this function, but that appears to be a bug.
10906 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10907 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10908 (adjust_after_replace_noundo): Remove; unused.
10909 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10910 (signal_before_change): Remove decls.
77382fcc 10911
9306c32e
PE
10912 * indent.c (val_compute_motion, val_vmotion): Now static.
10913
cd44d2eb
PE
10914 * image.c: Make symbols static if they're not exported.
10915 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10916 if USE_GTK.
10917 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10918 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10919
ad9a7a06
PE
10920 * fringe.c (standard_bitmaps): Now static.
10921 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10922
81626931
PE
10923 * frame.c: Make symbols static if they're not exported.
10924 (x_report_frame_params, make_terminal_frame): Now static.
10925 (get_frame_param): Now static, unless HAVE_NS.
10926 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10927 (x_get_resource_string): Remove; not used.
10928 * frame.h (make_terminal_frame, x_report_frame_params):
10929 (x_get_resource_string); Remove decls.
10930 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10931 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10932
239f9db9
PE
10933 * font.c, fontset.c: Make symbols static if they're not exported.
10934 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10935 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10936 * font.c (font_close_object): Now static.
10937 * font.h (font_close_object): Remove.
10938 * fontset.c (FONTSET_OBJLIST): Remove.
10939 (free_realized_fontset) #if-0 the body, which does nothing.
10940 (face_suitable_for_char_p): #if-0, as it's never called.
10941 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10942 * xfaces.c (face_at_string_position):
10943 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10944 since 0 is always ASCII.
10945
dfcf3579
PE
10946 * fns.c (weak_hash_tables): Now static.
10947
5045092b
PE
10948 * fileio.c: Make symbols static if they're not exported.
10949 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10950 (Vwrite_region_annotation_buffers): Now static.
10951
57a96f5c
PE
10952 * eval.c: Make symbols static if they're not exported.
10953 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10954 * lisp.h (backtrace_list): Remove decl.
10955
35f08c38
PE
10956 * emacs.c: Make symbols static if they're not exported.
10957 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10958 (fatal_error_code, fatal_error_signal_hook, standard_args):
10959 Now static.
10960 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10961 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10962 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10963 * lisp.h (fatal_error_signal_hook): Remove decl.
10964 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10965
f44bd759
PE
10966 * editfns.c: Move a (normally-unused) function to its only use.
10967 * editfns.c, lisp.h (get_operating_system_release): Remove.
10968 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10969 worth the hassle of breaking this out.
10970
b532497d
PE
10971 * xterm.c: Make symbols static if they're not exported.
10972 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10973 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10974 (x_destroy_window, x_delete_display):
10975 Now static.
10976 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10977 (x_mouse_leave): Remove; unused.
10978 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10979 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10980 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10981 Remove decls.
10982 (x_mouse_leave): Declare only if WINDOWSNT.
10983 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10984 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10985 USE_X_TOOLKIT.
10986
1675728f
PE
10987 * ftxfont.c: Make symbols static if they're not exported.
10988 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10989 HAVE_FREETYPE.
10990 * font.h (ftxfont_driver): Likewise.
10991
e4cebfca
PE
10992 * xfns.c: Make symbols static if they're not exported.
10993 (x_last_font_name, x_display_info_for_name):
10994 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10995 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10996 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10997 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10998 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10999 (last_show_tip_args): Now static.
11000 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11001 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11002 (x_screen_planes): Remove; unused.
11003 * dispextern.h (x_screen_planes): Remove decl.
11004
5bf46f05
PE
11005 * dispnew.c: Make symbols static if they're not exported.
11006 * dispextern.h (redraw_garbaged_frames, scrolling):
11007 (increment_row_positions): Remove.
11008 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11009 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11010 Now static.
11011 (redraw_garbaged_frames): Remove; unused.
11012
435f4c28
PE
11013 * xfaces.c: Make symbols static if they're not exported.
11014 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11015 Remove decls.
11016 * xterm.h (defined_color): Remove decls.
11017 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11018 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11019 (menu_face_changed_default, defined_color, free_realized_face):
11020 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11021 (ascii_face_of_lisp_face): Remove; unused.
11022
8524aef3
PE
11023 * xdisp.c: Make symbols static if they're not exported.
11024 * dispextern.h (scratch_glyph_row, window_box_edges):
11025 (glyph_to_pixel_coords, set_cursor_from_row):
11026 (get_next_display_element, set_iterator_to_next):
11027 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11028 (show_mouse_face): Remove decls
11029 * frame.h (message_buf_print): Likewise.
11030 * lisp.h (pop_message, set_message, check_point_in_composition):
11031 Likewise.
11032 * xterm.h (set_vertical_scroll_bar): Likewise.
11033 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11034 (message_buf_print, scratch_glyph_row, displayed_buffer):
11035 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11036 (get_next_display_element, show_mouse_face, window_box_edges):
11037 (frame_to_window_pixel_xy, check_point_in_composition):
11038 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11039 (glyph_to_pixel_coords): Remove; unused.
11040
16390cd2
PE
11041 * dired.c (file_name_completion): Now static.
11042
11043 * dbusbind.c (xd_in_read_queued_messages): Now static.
11044
a25f4dfa
PE
11045 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11046 * data.c (circular_list_error): Remove.
11047
14a9c8df
PE
11048 * commands.h (last_point_position, last_point_position_buffer):
11049 (last_point_position_window): Remove decls.
11050 * keyboard.c: Make these variables static.
11051
04f2d78b
CB
11052 * coding.h (coding, code_convert_region, encode_coding_gap):
11053 Remove decls.
74ab6df5
PE
11054 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11055 (iso_code_class, detect_coding, code_convert_region): Now static.
11056 (encode_coding_gap): Remove; unused.
11057
38dfbee1
PE
11058 * chartab.c (chartab_chars, chartab_bits): Now static.
11059
a2cb4e63
PE
11060 * charset.h (charset_iso_8859_1): Remove decl.
11061 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11062 Now static.
11063
127198fd
PE
11064 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11065 * ccl.c (Vccl_program_table): Now static.
11066 (check_ccl_update): Remove; unused.
11067
d85b608f
PE
11068 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11069 * category.h: ... from here.
11070 * category.c (check_category_table, set_category_set): Now static.
11071
31cd66f3
PE
11072 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11073 * lisp.h: Remove these decls.
11074
c358e587
PE
11075 * buffer.c (buffer_count): Remove unused var.
11076
e78aecca
PE
11077 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11078 so that it's not optimized away.
11079 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11080 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11081 exported only to the debugger.
11082
e192d7d3 11083 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11084 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11085
92470028
PE
11086 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11087 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11088 was inaccessible from Lisp.
11089 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11090 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11091
244ed907
PE
11092 alloc.c: Import and export fewer symbols, and remove unused items.
11093 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11094 is defined.
11095 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11096 it's not optimized away by whole-program optimization.
11097 (message_enable_multibyte, free_misc): Remove.
11098 (catchlist, handlerlist, mark_backtrace):
11099 Declare only if BYTE_MARK_STACK.
11100 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11101 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11102 (message_enable_multibyte): Remove decl.
11103 (free_misc, interval_free_list, float_block, float_block_index):
11104 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11105 (cons_free_list, last_marked_index):
11106 Now static.
11107 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11108 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11109 (mark_backtrace): Define only if BYTE_MARK_STACK.
11110 * xdisp.c (message_enable_multibyte): Now static.
11111
61c2b50e 11112 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11113 This makes it easier for human readers (and static analyzers)
11114 to see whether these variables are used from other modules.
11115 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11116 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11117 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11118 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11119 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11120 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11121 * xmenu.c, xselect.c:
11122 Declare Q* vars static if they are not used in other modules.
11123 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11124 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11125 Remove decls of unexported vars.
11126 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11127
95c82688
PE
11128 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11129
16a97296
PE
11130 Make Emacs functions such as Fatom 'static' by default.
11131 This makes it easier for human readers (and static analyzers)
11132 to see whether these functions can be called from other modules.
11133 DEFUN now defines a static function. To make the function external
11134 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11135 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11136 (Finit_image_library):
16a97296
PE
11137 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11138 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11139 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11140 Remove decls, since these functions are now static.
11141 (Funintern, Fget_internal_run_time): New decls, since these functions
11142 were already external.
95c82688 11143
16a97296
PE
11144 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11145 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11146 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11147 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11148 * keyboard.c, keymap.c, lread.c:
11149 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11150 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11151 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11152 Mark functions with DEFUE instead of DEFUN,
11153 if they are used in other modules.
11154 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11155 decls for now-static functions.
11156 * buffer.h (Fdelete_overlay): Remove decl.
11157 * callproc.c (Fgetenv_internal): Mark as internal.
11158 * composite.c (Fremove_list_of_text_properties): Remove decl.
11159 (Fcomposition_get_gstring): New forward static decl.
11160 * composite.h (Fcomposite_get_gstring): Remove decl.
11161 * dired.c (Ffile_attributes): New forward static decl.
11162 * doc.c (Fdocumntation_property): New forward static decl.
11163 * eval.c (Ffetch_bytecode): New forward static decl.
11164 (Funintern): Remove extern decl; now in .h file where it belongs.
11165 * fileio.c (Fmake_symbolic_link): New forward static decl.
11166 * image.c (Finit_image_library): New forward static decl.
11167 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11168 * intervals.h (Fprevious_property_change):
11169 (Fremove_list_of_text_properties): Remove decls.
11170 * keyboard.c (Fthis_command_keys): Remove decl.
11171 (Fcommand_execute): New forward static decl.
11172 * keymap.c (Flookup_key): New forward static decl.
11173 (Fcopy_keymap): Now static.
11174 * keymap.h (Flookup_key): Remove decl.
11175 * process.c (Fget_process): New forward static decl.
11176 (Fprocess_datagram_address): Mark as internal.
11177 * syntax.c (Fsyntax_table_p): New forward static decl.
11178 (skip_chars): Remove duplicate decl.
11179 * textprop.c (Fprevious_property_change): New forward static decl.
11180 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11181 Now internal.
11182 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11183 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11184
785bbd42
PE
11185 * editfns.c (Fformat): Remove unreachable code.
11186
8b913b57
AS
111872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11188
11189 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11190 change. (Bug#8496)
11191
a6744a35
EZ
111922011-04-13 Eli Zaretskii <eliz@gnu.org>
11193
11194 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11195 when at ZV. (Bug#8487)
11196
e7974947
AS
111972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11198
baad03f0
AS
11199 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11200 (Bug#8437)
11201 * keyboard.c (parse_tool_bar_item): Likewise.
11202 * sound.c (sound_cleanup, alsa_close): Likewise.
11203 * termcap.c (tgetent): Likewise.
11204 * xfns.c (x_default_font_parameter): Likewise.
11205 * xsettings.c (read_and_apply_settings): Likewise.
11206
e7974947
AS
11207 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11208 (overrun_check_free): Protoize.
11209
28272684
PE
112102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11211
11212 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11213 since callers should never pass a negative size.
11214 Change the signature to match that of plain 'read' and 'write'; see
11215 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11216 * lisp.h: Update prototypes of emacs_write and emacs_read.
11217
11997c76
EZ
112182011-04-11 Eli Zaretskii <eliz@gnu.org>
11219
11220 * xdisp.c (redisplay_window): Don't try to determine the character
11221 position of the scroll margin if the window start point w->startp
e896f03c 11222 is outside the buffer's accessible region. (Bug#8468)
11997c76 11223
8a2cbd72
EZ
112242011-04-10 Eli Zaretskii <eliz@gnu.org>
11225
11226 Fix write-region and its subroutines for buffers > 2GB.
11227 * fileio.c (a_write, e_write): Modify declaration of arguments and
11228 local variables to support buffers larger than 2GB.
11229 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11230
11231 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11232 argument, local variables, and return value.
11233
11234 * lisp.h: Update prototypes of emacs_write and emacs_read.
11235
11236 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11237
4073e537 112382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11239
1ebfdcb6
PE
11240 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11241
b2ded58d
PE
11242 Fix more problems found by GCC 4.6.0's static checks.
11243
7d66342c
PE
11244 * xdisp.c (vmessage): Use a better test for character truncation.
11245
bbf47d44
PE
11246 * charset.c (load_charset_map): <, not <=, for optimization,
11247 and to avoid potential problems with integer overflow.
9248994d 11248 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11249 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11250 * editfns.c (Fformat): Likewise.
1e69125e 11251 * syntax.c (skip_chars): Likewise.
3befa583 11252
e3019616
PE
11253 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11254 This also lets GCC 4.6.0 generate slightly better loop code.
11255
becfa255
PE
11256 * callint.c (Fcall_interactively): <, not <=, for optimization.
11257 (Fcall_interactively): Count the number of arguments produced,
11258 not the number of arguments given. This is simpler and lets GCC
11259 4.6.0 generate slightly better code.
11260
dae0cd48
PE
11261 * ftfont.c: Distingish more carefully between FcChar8 and char.
11262 The previous code passed unsigned char * to a functions like
11263 strlen and xstrcasecmp that expect char *, which does not
11264 conform to the C standard.
11265 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11266 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11267 char * when the C standard requires it.
11268
76032d70
PE
11269 * keyboard.c (read_char): Remove unused var.
11270
eb3f1cc8
PE
11271 * eval.c: Port to Windows vsnprintf (Bug#8435).
11272 Include <limits.h>.
11273 (SIZE_MAX): Define if the headers do not.
11274 (verror): Do not give up if vsnprintf returns a negative count.
11275 Instead, grow the buffer. This ports to Windows vsnprintf, which
11276 does not conform to C99. Problem reported by Eli Zaretskii.
11277 Also, simplify the allocation scheme, by avoiding the need for
11278 calling realloc, and removing the ALLOCATED variable.
11279
70476b54
PE
11280 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11281
12020a9e
PE
11282 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11283 But keep the doprint source code for now, as we might revamp it
11284 and use it again (Bug#8435).
ea6c7ae6
PE
11285 * lisp.h (doprnt): Remove.
11286 * Makefile.in (base_obj): Remove doprnt.o.
11287 * deps.mk (doprnt.o): Remove.
11288
5fdb398c
PE
11289 error: Print 32- and 64-bit integers portably (Bug#8435).
11290 Without this change, on typical 64-bit hosts error ("...%d...", N)
11291 was used to print both 32- and 64-bit integers N, which relied on
11292 undefined behavior.
61bdb816 11293 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11294 * lisp.h (error, verror): Mark as printf-like functions.
11295 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11296 Report overflow in size calculations when allocating printf buffer.
11297 Do not truncate output string at its first null byte.
11298 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11299 Truncate the output at a character boundary, since vsnprintf does not
11300 do that.
11301 * charset.c (check_iso_charset_parameter): Convert internal
11302 character to string before calling 'error', since %c now has the
11303 printf meaning.
11304 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11305 overflow when computing char to be passed to 'error'. Do not
11306 pass Lisp_Object to 'error'; pass the integer instead.
11307 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11308 formatted with plain %d.
11309
b189fa66
PE
11310 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11311
bff87ef0
PE
11312 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11313
7e2cac20
PE
11314 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11315
ce4d90b5
PE
11316 * xterm.c (x_catch_errors): Remove duplicate declaration.
11317
266c9547
PE
11318 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11319
79c49ad2
PE
11320 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11321
368f4090
JM
113222011-04-10 Jim Meyering <meyering@redhat.com>
11323
11324 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11325 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11326 return ssize_t not "int", and use size_t as the buffer length.
11327 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11328 * gnutls.h: Update declarations.
11329 * process.c (read_process_output): Use ssize_t, to match.
11330 (send_process): Likewise.
11331
a32d4040
CY
113322011-04-09 Chong Yidong <cyd@stupidchicken.com>
11333
11334 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11335
8546720e 113362011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11337
04f2d78b
CB
11338 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11339 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11340
8546720e
GM
11341 * xterm.c (handle_one_xevent):
11342 * xmenu.c (create_and_show_popup_menu):
11343 * xselect.c (x_decline_selection_request)
11344 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11345
0a2f5c1a 113462011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11347
11348 Fix some uses of `int' instead of EMACS_INT.
11349 * search.c (string_match_1, fast_string_match)
11350 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11351 (scan_buffer, find_next_newline_no_quit)
11352 (find_before_next_newline, search_command, Freplace_match)
11353 (Fmatch_data): Make some `int' variables be EMACS_INT.
11354
11355 * xdisp.c (display_count_lines): 3rd argument and return value now
11356 EMACS_INT. All callers changed.
11357 (pint2hrstr): Last argument is now EMACS_INT.
11358
11359 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11360 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11361 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11362 (decode_coding_utf_16, decode_coding_emacs_mule)
11363 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11364 (decode_coding_ccl, decode_coding_charset)
11365 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11366 (decode_coding_iso_2022, decode_coding_emacs_mule)
11367 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11368 <char_offset, last_offset>: Declare EMACS_INT.
11369 (encode_coding_utf_8, encode_coding_utf_16)
11370 (encode_coding_emacs_mule, encode_invocation_designation)
11371 (encode_designation_at_bol, encode_coding_iso_2022)
11372 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11373 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11374 Declare EMACS_INT.
11375 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11376 (encode_invocation_designation): Last argument P_NCHARS is now
11377 EMACS_INT.
11378 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11379 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11380
11381 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11382 All users changed.
11383
11384 * ccl.c (Fccl_execute_on_string): Declare some variables
11385 EMACS_INT.
11386
8546720e 113872011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11388
11389 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11390
4e19a977
CS
113912011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11392
11393 * process.c (Fformat_network_address): Doc fix.
11394
87302331
R
113952011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11396
ee7683eb 11397 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11398
cbb59342
CY
113992011-04-08 Chong Yidong <cyd@stupidchicken.com>
11400
11401 * keyboard.c (read_char): Call Lisp function help-form-show,
11402 instead of using internal_with_output_to_temp_buffer.
11403 (Qhelp_form_show): New var.
e0d38eeb 11404 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11405
11406 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11407
11408 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11409
e67a13ab
CY
114102011-04-06 Chong Yidong <cyd@stupidchicken.com>
11411
04f2d78b
CB
11412 * process.c (Flist_processes): Remove to Lisp.
11413 (list_processes_1): Delete.
e67a13ab 11414
973f782d
EZ
114152011-04-06 Eli Zaretskii <eliz@gnu.org>
11416
7c106b1e
EZ
11417 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11418
973f782d
EZ
11419 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11420
41cf7d1a 114212011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11422
ca23cc88
PE
11423 Fix more problems found by GCC 4.6.0's static checks.
11424
f390e2d5
PE
11425 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11426
42eea0d0
PE
11427 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11428
b69769da 11429 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11430
f9541e84
PE
11431 * xdisp.c (vmessage): Mark as a printf-like function.
11432
13841b55
PE
11433 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11434
c136c10f
PE
11435 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11436
5e2d4a30
PE
11437 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11438 printf-like functions.
11439 (tiff_load): Add casts to remove these marks before passing them
11440 to system-supplied API.
11441
583f48b9
PE
11442 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11443
b25d760e
PE
11444 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11445 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11446 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11447 directly, rather than having caller test rule sign. This avoids
11448 some unnecessary tests.
11449 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11450 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11451 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11452
bc7b6697 11453 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11454 (xfont_open): Avoid unnecessary tests.
bc7b6697 11455
27ccc379
PE
11456 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11457
dcd5c89a
PE
11458 * composite.h, composite.c (composition_gstring_put_cache):
11459 Use EMACS_INT, not int, for length.
11460
b13a45c6
PE
11461 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11462 breaking out part of COMPOSITION_DECODE_RULE.
11463 (COMPOSITION_DECODE_RULE): Use it.
11464 * composite.c (get_composition_id): Remove unused local vars,
11465 by using the new macro.
11466
1e792e4d
PE
11467 * textprop.c (set_text_properties_1): Change while to do-while,
11468 since the condition is always true at first.
11469
dc6c6455 11470 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11471 (interval_deletion_adjustment): Return unsigned value.
11472 All uses changed.
dc6c6455 11473
aba7731a
PE
11474 * process.c (list_processes_1, create_pty, read_process_output):
11475 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11476 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11477 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11478 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11479 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11480
fdfc4bf3
PE
11481 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11482
fca8fe46 11483 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11484 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11485
06a0259a 11486 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11487 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11488 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11489
e7b9e80f
PE
11490 * print.c (print_error_message): Avoid int overflow.
11491
56201685
PE
11492 * font.c (font_list_entities): Redo for clarity,
11493 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11494
78834453 11495 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11496 (font_score): Avoid potential overflow in diff calculation.
78834453 11497
0bc0b309 11498 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11499 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11500
e610eaca
PE
11501 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11502
b895abce
PE
11503 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11504 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11505 can always succeed if overflow has undefined behavior.
11506
1f1d9321 11507 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11508 (wordify): Omit three unnecessary tests.
1f1d9321 11509
c59478bc
PE
11510 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11511 All callers changed. This avoids the need for an unused var.
11512
79b73827
PE
11513 * casefiddle.c (casify_region): Remove var that is set but not used.
11514
a4db5dfe
PE
11515 * dired.c (file_name_completion): Remove var that is set but not used.
11516
43aae36e
PE
11517 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11518
2a47c44d 11519 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11520 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11521
a37c69bf
PE
11522 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11523 Check for integer overflow on size calculations.
11524
328ab8e7
PE
11525 * buffer.c (Fprevious_overlay_change): Remove var that is set
11526 but not used.
11527
e5a2a5cb
PE
11528 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11529 Remove vars that are set but not used.
8d84a6eb 11530 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11531 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11532
a60e5f68
PE
11533 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11534
f661cb61 11535 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11536 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11537
f0397f5a
PE
11538 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11539 that are set but not used.
11540
8664db06 11541 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11542 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11543
6abdaa4a
PE
11544 * xselect.c (x_get_local_selection, x_handle_property_notify):
11545 Remove vars that are set but not used.
11546
0ce7538d 11547 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11548 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11549
9ae848fc
PE
11550 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11551 Remove var that is set but not used.
0b918413
PE
11552 (scroll_bar_windows_size): Now size_t, not int.
11553 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11554 Check for overflow.
9ae848fc 11555
a5a62657
PE
11556 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11557 (map_tty_color) [!defined MSDOS]: Likewise.
11558
5c5cdd39
PE
11559 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11560
66ebf983
PE
11561 * coding.c: Remove vars that are set but not used.
11562 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11563 All callers changed.
11564 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11565 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11566 (decode_coding_charset): Remove vars that are set but not used.
11567
1be4d761
PE
11568 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11569 that is set but not used.
11570
47553fa8
PE
11571 * print.c (print_object): Remove var that is set but not used.
11572
1f7196bf 11573 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11574 The gnulib version avoids calling malloc in the usual case,
11575 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11576 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11577 * filelock.c (current_lock_owner): Likewise.
11578 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11579 * sysdep.c: Include allocator.h, careadlinkat.h.
11580 (emacs_no_realloc_allocator): New static constant.
11581 (emacs_readlink): New function.
fdb61804
PE
11582 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11583 ../lib/careadlinkat.h.
d1fdcab7 11584
f84c17c7
SM
115852011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11586
11587 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11588 first non-nil return value).
11589
ef3862ad
JD
115902011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11591
11592 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11593 if not defined (Bug#8403).
11594
376a7006
JB
115952011-04-02 Juanma Barranquero <lekktu@gmail.com>
11596
11597 * xdisp.c (display_count_lines): Remove parameter `start',
11598 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11599 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11600 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11601 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11602 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11603 and thereabouts. All callers changed.
11604 (get_per_char_metric): Remove parameter `f', unused since
11605 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11606
6ca3801d
JM
116072011-04-02 Jim Meyering <meyering@redhat.com>
11608
11609 do not dereference NULL upon failed strdup
11610 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11611 (ns_get_family): Likewise.
11612
d8e2b5ba
JB
116132011-04-02 Juanma Barranquero <lekktu@gmail.com>
11614
11615 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11616
8c74fcbd
JD
116172011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11618
11619 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11620 later (Bug#8403).
11621
7200d79c
SM
116222011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11623
03408648 11624 Add lexical binding.
7200d79c 11625
03408648
SM
11626 * window.c (Ftemp_output_buffer_show): New fun.
11627 (Fsave_window_excursion):
11628 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11629
11630 * lread.c (lisp_file_lexically_bound_p): New function.
11631 (Fload): Bind Qlexical_binding.
11632 (readevalloop): Remove `evalfun' arg.
11633 Bind Qinternal_interpreter_environment.
11634 (Feval_buffer): Bind Qlexical_binding.
11635 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11636 Mark as dynamic.
11637 (syms_of_lread): Declare `lexical-binding'.
11638
11639 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11640
11641 * keyboard.c (eval_dyn): New fun.
11642 (menu_item_eval_property): Use it.
ca105506
SM
11643
11644 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11645
03408648
SM
11646 * fns.c (concat, mapcar1): Accept byte-code-functions.
11647
11648 * eval.c (Fsetq): Handle lexical vars.
11649 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11650 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11651 (FletX, Flet): Obey lexical binding.
11652 (Fcommandp): Handle closures.
11653 (Feval): New `lexical' arg.
11654 (eval_sub): New function extracted from Feval. Use it almost
11655 everywhere where Feval was used. Look up vars in lexical env.
11656 Handle closures.
11657 (Ffunctionp): Move from subr.el.
11658 (Ffuncall): Handle closures.
11659 (apply_lambda): Remove `eval_flags'.
11660 (funcall_lambda): Handle closures and new byte-code-functions.
11661 (Fspecial_variable_p): New function.
11662 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11663 but without exporting it to Lisp.
23aba0ea 11664
23aba0ea 11665 * doc.c (Fdocumentation, store_function_docstring):
03408648 11666 * data.c (Finteractive_form): Handle closures.
23aba0ea 11667
03408648
SM
11668 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11669 interactive spec.
ba83908c 11670
04f2d78b
CB
11671 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11672 New byte-codes.
03408648
SM
11673 (exec_byte_code): New function extracted from Fbyte_code to handle new
11674 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11675
03408648 11676 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11677
03408648 11678 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11679
e2abce01
JB
116802011-03-31 Juanma Barranquero <lekktu@gmail.com>
11681
11682 * xdisp.c (redisplay_internal): Fix prototype.
11683
63696a73 116842011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11685
63696a73 11686 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11687 (try_scrolling): Use it when setting scroll_limit.
11688 Limit scrolling to 100 screen lines.
63696a73
EZ
11689 (redisplay_window): Even when falling back on "recentering",
11690 position point in the window according to scroll-conservatively,
11691 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11692
11693 (try_scrolling): When point is above the window, allow searching
11694 as far as scroll_max, or one screenful, to compute vertical
11695 distance from PT to the scroll margin position. This prevents
11696 try_scrolling from unnecessarily failing when
11697 scroll-conservatively is set to a value slightly larger than the
11698 window height. Clean up the case of PT below the margin at bottom
11699 of window: scroll_max can no longer be INT_MAX. When aggressive
11700 scrolling is in use, don't let point enter the opposite scroll
11701 margin as result of the scroll.
11702 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11703 threshold of 100 lines for never-recentering scrolling.
11704
e4cc2dfc
JB
117052011-03-31 Juanma Barranquero <lekktu@gmail.com>
11706
11707 * dispextern.h (move_it_by_lines):
11708 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11709 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11710 (message_log_check_duplicate): Remove parameters `prev_bol' and
11711 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11712 (redisplay_internal): Remove parameter `preserve_echo_area',
11713 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11714
11715 * indent.c (Fvertical_motion):
11716 * window.c (window_scroll_pixel_based, Frecenter):
11717 Don't pass `need_y_p' to `move_it_by_lines'.
11718
1c470562
SM
117192011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11720
44f230aa
SM
11721 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11722 steal a few bits to be more compact.
11723 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11724 Remove unneeded casts.
11725
1c470562
SM
11726 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11727
888adce9
ZK
117282011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11729
11730 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11731 binding" message (bug#7967).
11732
f838ed7b
PE
117332011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11734
77861b95
PE
11735 Fix more problems found by GCC 4.6.0's static checks.
11736
de6dbc14
PE
11737 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11738 Remove unused local var.
11739
f838ed7b
PE
11740 * editfns.c (Fmessage_box): Remove unused local var.
11741
792c7b2b
PE
11742 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11743 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11744 Omit unused local vars.
c499e557 11745 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11746 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11747 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11748 Omit unused local var.
11749
ba0165e1
PE
11750 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11751 Don't assume string length fits in int.
32ad8845 11752 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11753 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11754
3c59b4c9
PE
11755 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11756 instead of alloca (Bug#8344).
11757
a3eed478 11758 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11759 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11760
eb4d412d
PE
11761 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11762
1658b401
PE
11763 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11764 concerns.
11765
11766 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11767
11768 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11769
9a2c6e05
PE
11770 * keyboard.c (syms_of_keyboard): Use the same style as later
11771 in this function when indexing through an array. This also
11772 works around GCC bug 48267.
11773
03d0a109
PE
11774 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11775
44f730c8
PE
11776 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11777
fe75f926
PE
11778 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11779 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11780
ffa8c828
PE
11781 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11782 This avoids undefined behavior on integer overflow, and is a bit
11783 more convenient anyway since it is compared to a size_t variable.
11784
c5101a77
PE
11785 Variadic C functions now count arguments with size_t, not int.
11786 This avoids an unnecessary limitation on 64-bit machines, which
11787 caused (substring ...) to crash on large vectors (Bug#8344).
11788 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11789 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11790 All variadic functions and their callers changed accordingly.
c5101a77
PE
11791 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11792 * data.c (arith_driver, float_arith_driver): Likewise.
11793 * editfns.c (general_insert_function): Likewise.
11794 * eval.c (struct backtrace.nargs, interactive_p)
11795 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11796 (funcall_lambda, mark_backtrace): Likewise.
11797 * fns.c (concat): Likewise.
11798 * frame.c (x_set_frame_parameters): Likewise.
11799 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11800 0 if not found, not -1. All callers changed.
11801
dd3f25f7
PE
11802 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11803 (stack_copy_size): Now size_t, not int.
11804 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11805
461c2ab9
JB
118062011-03-28 Juanma Barranquero <lekktu@gmail.com>
11807
11808 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11809 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11810 All callers changed.
11811
11812 * lisp.h (multibyte_char_to_unibyte):
11813 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11814 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11815 * character.h (CHAR_TO_BYTE8):
11816 * cmds.c (internal_self_insert):
11817 * editfns.c (general_insert_function):
11818 * keymap.c (push_key_description):
11819 * search.c (Freplace_match):
11820 * xdisp.c (message_dolog, set_message_1): All callers changed.
11821
f6d62986
SM
118222011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11823
11824 * keyboard.c (safe_run_hook_funcall): New function.
11825 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11826 don't set the hook to nil, but remove the offending function instead.
11827 (Qcommand_hook_internal): Remove, unused.
11828 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11829 Vcommand_hook_internal.
11830
11831 * eval.c (enum run_hooks_condition): Remove.
11832 (funcall_nil, funcall_not): New functions.
11833 (run_hook_with_args): Call each function through a `funcall' argument.
11834 Remove `cond' argument, now redundant.
11835 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11836 (Frun_hook_with_args_until_failure): Adjust accordingly.
11837 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11838
1db5b1ad
JB
118392011-03-28 Juanma Barranquero <lekktu@gmail.com>
11840
11841 * dispextern.h (string_buffer_position): Remove declaration.
11842
11843 * print.c (strout): Remove parameter `multibyte', unused since
11844 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11845
11846 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11847 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11848 All callers changed.
11849
11850 * w32.c (_wsa_errlist): Use braces for struct initializers.
11851
11852 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11853 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11854 All callers changed.
11855 (string_buffer_position): Likewise. Also, make static (it's never
11856 used outside xdisp.c).
11857 (cursor_row_p): Remove parameter `w', unused since
11858 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11859 (decode_mode_spec): Remove parameter `precision', introduced during
11860 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11861 All callers changed.
11862
5ffb62aa
JD
118632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11864
11865 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11866
461c2ab9 118672011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11868
11869 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11870 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11871 (ns_update_auto_hide_menu_bar): New functions.
11872 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11873 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11874 ns_constrain_all_frames.
11875 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11876 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11877
5c380ffb
JD
118782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11879
11880 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11881
9af30bdf
GM
118822011-03-27 Glenn Morris <rgm@gnu.org>
11883
11884 * syssignal.h: Replace RETSIGTYPE with void.
11885 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11886 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11887 Replace SIGTYPE with void everywhere.
11888 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11889 * s/template.h (SIGTYPE): Remove commented out definition.
11890
e2abce01
JB
118912011-03-26 Eli Zaretskii <eliz@gnu.org>
11892
11893 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11894 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11895
f868cd8a
JB
118962011-03-26 Juanma Barranquero <lekktu@gmail.com>
11897
59eb0929
JB
11898 * w32.c (read_unc_volume): Use parameter `henum', instead of
11899 global variable `wget_enum_handle'.
11900
11901 * keymap.c (describe_vector): Remove parameters `indices' and
11902 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11903 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11904
f868cd8a
JB
11905 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11906
11907 * keyboard.c (timer_check): Remove parameter `do_it_now',
11908 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11909 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11910 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11911
11912 * keyboard.c (read_char):
11913 * w32menu.c (w32_menu_display_help):
11914 * xmenu.c (show_help_event, menu_help_callback):
11915 Adjust calls to `show_help_echo'.
11916
11917 * gtkutil.c (xg_maybe_add_timer):
11918 * keyboard.c (readable_events):
11919 * process.c (wait_reading_process_output):
11920 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11921
11922 * insdel.c (adjust_markers_gap_motion):
11923 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11924 (gap_left, gap_right): Don't call it.
11925
2ecf6fdb
CY
119262011-03-25 Chong Yidong <cyd@stupidchicken.com>
11927
11928 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11929 incurred during fontification.
11930
6b1f9ba4
JB
119312011-03-25 Juanma Barranquero <lekktu@gmail.com>
11932
11933 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11934 (DEFVAR_PER_BUFFER): Don't pass it.
11935
11936 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11937 (scrolling_window): Don't pass it.
11938
0f4a96b5
JB
119392011-03-25 Juanma Barranquero <lekktu@gmail.com>
11940
11941 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11942
11943 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11944 and `suffix'.
11945 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11946 of variables specific to SELinux and computation of `encoded_absname'.
11947
11948 * image.c (XPutPixel): Remove unused variable `height'.
11949
11950 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11951
11952 * unexw32.c (get_section_info): Remove unused variable `section'.
11953
11954 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11955 (system_process_attributes): Remove unused variable `sess'.
11956 (sys_read): Remove unused variable `err'.
11957
11958 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11959 (w32_wnd_proc): Remove unused variable `isdead'.
11960 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11961 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11962 (x_create_tip_frame): Remove unused variable `tem'.
11963
11964 * w32inevt.c (w32_console_read_socket):
11965 Remove unused variable `no_events'.
11966
11967 * w32term.c (x_draw_composite_glyph_string_foreground):
11968 Remove unused variable `width'.
11969
1149507c
JB
119702011-03-24 Juanma Barranquero <lekktu@gmail.com>
11971
11972 * w32term.c (x_set_glyph_string_clipping):
11973 Don't pass uninitialized region to CombineRgn.
11974
9c88f339
JB
119752011-03-23 Juanma Barranquero <lekktu@gmail.com>
11976
11977 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11978 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11979 (Fx_close_connection): Remove unused variable `i'.
11980
11981 * w32font.c (w32font_draw): Return number of glyphs.
11982 (w32font_open_internal): Remove unused variable `i'.
11983 (w32font_driver): Add missing initializer.
11984
11985 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11986 (fill_in_menu): Remove unused variable `items_added'.
11987
11988 * w32term.c (last_mouse_press_frame): Remove static global variable.
11989 (w32_clip_to_row): Remove unused variable `f'.
11990 (x_delete_terminal): Remove unused variable `i'.
11991
11992 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11993 (NOTHING): Remove unused static global variable.
11994 (uniscribe_check_otf): Remove unused variable `table'.
11995 (uniscribe_font_driver): Add missing initializers.
11996
dee091a3
JD
119972011-03-23 Julien Danjou <julien@danjou.info>
11998
11999 * term.c (Fsuspend_tty, Fresume_tty):
12000 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12001 * window.c (temp_output_buffer_show):
12002 * insdel.c (signal_before_change):
12003 * frame.c (Fhandle_switch_frame):
12004 * fileio.c (Fdo_auto_save):
12005 * emacs.c (Fkill_emacs):
12006 * editfns.c (save_excursion_restore):
12007 * cmds.c (internal_self_insert):
12008 * callint.c (Fcall_interactively):
12009 * buffer.c (Fkill_all_local_variables):
12010 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12011 Use Frun_hooks.
0f4a96b5 12012 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12013 unconditionally since it does the check itself.
dee091a3 12014
2c520ab5 120152011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12016
c9c49752
PE
12017 Fix more problems found by GCC 4.5.2's static checks.
12018
8abc3f12
PE
12019 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12020 the first time through the loop, since we know p0 < p1 then.
12021 This also avoids a gcc -Wstrict-overflow warning.
12022
a2d26660
PE
12023 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12024 leading to a memory leak, possible in functions like
12025 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12026 of objects (Bug#8318).
a2d26660 12027
916c72e9
PE
12028 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12029 that could (at least in theory) be that large.
12030
19ab8a18
PE
12031 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12032 This is less likely to overflow, and avoids undefined behavior if
12033 overflow does occur. All callers changed. Use strtoul to scan
12034 for the unsigned long integer.
b7cbbd6f
PE
12035 (pint2hrstr): Simplify and tune code slightly.
12036 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12037
f0641eff
PE
12038 * scroll.c (do_scrolling): Work around GCC bug 48228.
12039 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12040
7f650bb9
PE
12041 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12042 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12043 (validate_x_resource_name): Simplify count usage.
12044 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12045
37dd57d1
PE
12046 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12047 fail (Bug#8306).
81e56e61 12048
699979fc 12049 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12050
401bf9b4
PE
12051 * process.c (Fmake_network_process): Use socklen_t, not int,
12052 where POSIX says socklen_t is required in portable programs.
12053 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12054 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12055 (Fmake_network_process, server_accept_connection):
12056 (wait_reading_process_output, read_process_output):
12057 Likewise.
12058
b93aacde
PE
12059 * process.c: Rename or move locals to avoid shadowing.
12060 (list_processes_1, Fmake_network_process):
12061 (read_process_output_error_handler, exec_sentinel_error_handler):
12062 Rename or move locals.
4dc343ee 12063 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12064 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12065 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12066 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12067 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12068
af8a867c 12069 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12070 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12071 Include tparam.h instead, since it declares them.
af8a867c
PE
12072 * cm.h (PC): Remove extern decl; tparam.h now does this.
12073 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12074 * terminfo.c: Include tparam.h, to check interfaces.
12075 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12076 (tparam): Adjust signature to match interface in tparam.h;
12077 this removes some undefined behavior. Check that outstring and len
12078 are zero, which they always are with Emacs.
12079 * tparam.h (PC, BC, UP): New extern decls.
12080
0248044d 12081 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12082 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12083
8ff096c1 12084 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12085 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12086 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12087 (ftfont_list): Remove unused local.
49eaafba
PE
12088 (get_adstyle_property, ftfont_pattern_entity):
12089 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12090 Rename locals to avoid shadowing.
8ff096c1 12091
e2be39f6
PE
12092 * xfont.c (xfont_list_family): Mark var as initialized.
12093
c9735e30
PE
12094 * xml.c (make_dom): Now static.
12095
8f5201ae
PE
12096 * composite.c (composition_compute_stop_pos): Rename local to
12097 avoid shadowing.
b246f932
PE
12098 (composition_reseat_it): Remove unused locals.
12099 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12100 (composition_update_it): Mark var as initialized.
11b61122
PE
12101 (find_automatic_composition): Mark vars as initialized,
12102 with a FIXME (Bug#8290).
8f5201ae 12103
760fbc2c
PE
12104 character.h: Rename locals to avoid shadowing.
12105 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12106 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12107 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12108 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12109 to avoid shadowing.
12110
ff08eb85
PE
12111 * textprop.c (property_change_between_p): Remove; unused.
12112
fc7bf025
PE
12113 * intervals.c (interval_start_pos): Now static.
12114
235d7abc
PE
12115 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12116
44f230aa
SM
12117 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12118 Rename locals to avoid shadowing.
3e7d6594 12119
50060332
PE
12120 * sound.c (wav_play, au_play, Fplay_sound_internal):
12121 Fix pointer signedness.
d01f234b 12122 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12123 (wav_play): Initialize a variable to 0, to prevent undefined
12124 behavior (Bug#8278).
50060332 12125
c4fc4e30
PE
12126 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12127
918436ed
PE
12128 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12129
c939f91b
PE
12130 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12131 clobbering (Bug#8298).
b9c7f648
PE
12132 * sysdep.c (sys_subshell): Likewise.
12133 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12134
6bd8c144
PE
12135 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12136 This should get cleaned up, so that child_setup has the
12137 same signature on all platforms.
12138
7710357c 12139 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12140 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12141
c59da222
CY
121422011-03-22 Chong Yidong <cyd@stupidchicken.com>
12143
12144 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12145 not to be necessary, and produces flickering.
12146
66b87493
GM
121472011-03-20 Glenn Morris <rgm@gnu.org>
12148
12149 * config.in: Remove file.
12150
45b6f6d5
JB
121512011-03-20 Juanma Barranquero <lekktu@gmail.com>
12152
12153 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12154 are now in src/globals.h.
12155 (syms_of_minibuf): Remove spurious & from previous change.
12156
cd394be1 121572011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12158
12159 * minibuf.c (completing-read-function): New variable.
12160 (completing-read-default): Rename from completing-read.
12161 (completing-read): Call completing-read-function.
12162
b14e3e21
CY
121632011-03-19 Juanma Barranquero <lekktu@gmail.com>
12164
12165 * xfaces.c (Fx_load_color_file):
12166 Read color file from absolute filename (bug#8250).
12167
f2b726e6
JB
121682011-03-19 Juanma Barranquero <lekktu@gmail.com>
12169
12170 * makefile.w32-in: Update dependencies.
12171
09f6ff02
EZ
121722011-03-17 Eli Zaretskii <eliz@gnu.org>
12173
12174 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12175
29a6015a
PE
121762011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12177
a3a6c54e
PE
12178 Fix more problems found by GCC 4.5.2's static checks.
12179
b766f867
PE
12180 * process.c (make_serial_process_unwind, send_process_trap):
12181 (sigchld_handler): Now static.
12182
be02381c
PE
12183 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12184 That way, the code declares only the vars that it needs.
12185 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12186 * s/cygwin.h (PTY_ITERATION): Likewise.
12187 * s/darwin.h (PTY_ITERATION): Likewise.
12188 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12189
57048744
PE
12190 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12191 * process.c (allocate_pty): Don't declare stb unless it's needed.
12192
7914961c 12193 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12194 (CONSTANTLIM): Remove; unused.
12195 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12196 Define only if needed.
7914961c 12197
b3967b18
PE
12198 * unexelf.c (unexec): Name an expression,
12199 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12200 Use a different way to cause a compilation error if anyone uses
12201 n rather than nn, a way that does not involve shadowing.
73366a00 12202 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12203
29a6015a
PE
12204 * deps.mk (unexalpha.o): Remove; unused.
12205
43cfc33e 12206 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12207 * unexec.h: New file.
ce701a33
PE
12208 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12209 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12210 Depend on unexec.h.
12211 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12212 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12213 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12214 Change as necessary to match prototype in unexec.h.
ce701a33 12215
01f44d5a
PE
12216 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12217 shadowing.
4f63c6bb 12218 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12219
a6670b0b
PE
12220 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12221 Rename locals to avoid shadowing.
12222
cef2010d 12223 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12224 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12225
d4d7173a
PE
12226 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12227
f08b802a
PE
12228 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12229 warning when compiling print.c.
12230
3ddb0639
PE
12231 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12232 instead of using an uninitialized var.
5ad03b97 12233 (font_sort_entities): Mark var as initialized.
3ddb0639 12234
170a2692
PE
12235 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12236
e663c700
PE
12237 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12238 pointers to constants.
89bc529a 12239 (font_parse_fcname): Remove unused vars.
7b81e2d0 12240 (font_delete_unmatched): Now static.
ea838e10 12241 (font_get_spec): Remove; unused.
13a547c6
PE
12242 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12243 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12244 Rename or move locals to avoid shadowing.
e663c700 12245
2a80c887 12246 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12247 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12248
1384fa33 12249 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12250 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12251
8b2c52e9
PE
12252 * alloc.c (mark_backtrace): Move decl from here ...
12253 * lisp.h: ... to here, so that it can be checked.
12254
475545b5 12255 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12256 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12257 (lisp_indirect_variable): Name an expression,
12258 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12259 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12260
b1349114 12261 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12262 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12263 Use const pointer when appropriate.
b1349114 12264
a2928364
PE
12265 * lisp.h (get_system_name, get_operating_system_release):
12266 Move decls here, to check interfaces.
12267 * process.c (get_operating_system_release): Move decl to lisp.h.
12268 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12269 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12270 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12271 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12272 (Fformat_time_string, Fencode_time, Finsert_char):
12273 (Ftranslate_region_internal, Fformat):
12274 Rename or remove local vars to avoid shadowing.
9710023e 12275 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12276
a415e694
PE
12277 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12278 avoid shadowing.
12279
8ef4622d
PE
12280 * lisp.h (eassert): Check that the argument compiles, even if
12281 ENABLE_CHECKING is not defined.
12282
946f9a5b
PE
12283 * data.c (Findirect_variable): Name an expression, to avoid
12284 gcc -Wbad-function-cast warning.
112396d6 12285 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12286 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12287 (Fmake_variable_buffer_local, Fmake_local_variable):
12288 Mark variables as initialized.
52746918 12289 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12290
e5aab7e7 12291 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12292 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12293 Rename locals to avoid shadowing.
dff45157
PE
12294 (mark_stack): Move local variables into the #ifdef region where
12295 they're used.
7bc26fdb
PE
12296 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12297 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12298 needed otherwise.
12299 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12300 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12301 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12302
e5aab7e7
PE
12303 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12304 avoids undefined behavior in theory.
12305
4da60324
PE
12306 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12307
88043301
PE
12308 Use functions, not macros, for up- and down-casing (Bug#8254).
12309 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12310 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12311 to use the following functions instead of these macros.
12312 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12313 EMACS_INT, since callers assume the returned value fits in int.
12314 (upcase1): Likewise, for UPCASE_TABLE.
12315 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12316 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12317 the race-condition problem in the old DOWNCASE.
88043301 12318
19ed5445
PE
12319 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12320 Rename locals to avoid shadowing.
12321 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12322 (regex_compile, re_search_2, re_match_2_internal):
12323 Remove unused local vars.
952db0d7
PE
12324 (FREE_VAR): Rewrite so as not to use empty "else",
12325 which gcc can warn about.
da053e48 12326 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12327 (RETALLOC_IF): Define only if needed.
12328 (WORDCHAR_P): Likewise. This one is never needed, but is used
12329 only in a comment talking about a compiler bug, so put inside
12330 the #if 0 of that comment.
12331 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12332 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12333 Remove; unused.
19ed5445 12334
1f3561e4 12335 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12336 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12337 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12338
ded6f8f7
PE
12339 * search.c (simple_search): Remove unused var.
12340
dbd37a95
PE
12341 * dired.c (compile_pattern): Move decl from here ...
12342 * lisp.h: ... to here, so that it can be checked.
12343 (struct re_registers): New forward decl.
12344
7e47afad
PE
12345 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12346
85f24f61
PE
12347 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12348 All uses changed.
12349 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12350 Rename locals to avoid shadowing.
5671df8f 12351 (Fvertical_motion): Mark locals as initialized.
85f24f61 12352
181aa2be 12353 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12354 (casify_region): Mark local as initialized.
181aa2be 12355
930d429c
PE
12356 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12357
7082eac6
PE
12358 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12359 New macros, so that the caller can use some names other than
12360 gcpro1, gcpro2, etc.
12361 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12362 of the new macros.
12363 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12364 argument, for consistency with GCPRO2_VAR, etc: it is now the
12365 prefix of the variable, not the variable itself. All uses
12366 changed.
38b2c076
PE
12367 * dired.c (directory_files_internal, file_name_completion):
12368 Rename locals to avoid shadowing.
12369
15206ed9
PE
12370 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12371 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12372 dired.c's scmp function, had undefined behavior.
12373 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12374 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12375 * buffer.h: ... to here, because these macros use current_buffer,
12376 and the new implementation with inline functions needs to have
12377 current_buffer in scope now, rather than later when the macros
12378 are used.
12379 (downcase, upcase1): New static inline functions.
12380 (DOWNCASE, UPCASE1): Reimplement using these functions.
12381 This avoids undefined behavior in expressions like
12382 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12383 from race conditions in accessing the global variables
12384 case_temp1 and case_temp2.
12385 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12386 * lisp.h (case_temp1, case_temp2): Remove their decls.
12387 * character.h (ASCII_CHAR_P): Move from here ...
12388 * lisp.h: ... to here, so that the inline functions mentioned
12389 above can use them.
12390
4a6bea26
PE
12391 * dired.c (directory_files_internal_unwind): Now static.
12392
f14b7e14
PE
12393 * fileio.c (file_name_as_directory, directory_file_name):
12394 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12395 Now static.
2893f146
PE
12396 (file_name_as_directory): Use const pointers when appropriate.
12397 (Fexpand_file_name): Likewise. In particular, newdir might
12398 point at constant storage, so make it a const pointer.
fd4ead52 12399 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12400 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12401 signedness issues.
f839df0c
PE
12402 (Fset_file_times, Finsert_file_contents, auto_save_error):
12403 Rename locals to avoid shadowing.
f14b7e14 12404
5716756e 12405 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12406 (Ftry_completion, Fall_completions): Rename or remove locals
12407 to avoid shadowing.
5716756e 12408
b4c3046a
PE
12409 * marker.c (bytepos_to_charpos): Remove; unused.
12410
b45db522
PE
12411 * lisp.h (verify_bytepos, count_markers): New decls,
12412 so that gcc does not warn that these functions aren't declared.
12413
85876d07
PE
12414 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12415 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12416 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12417 (copy_text): Remove unused local var.
85876d07 12418
03d78a21 12419 * filelock.c (within_one_second): Now static.
b3dd38ab 12420 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12421
5df8f01b
PE
12422 * buffer.c (fix_overlays_before): Mark locals as initialized.
12423 (fix_start_end_in_overlays): Likewise. This function should be
12424 simplified by using pointers-to-pointers, but that's a different
12425 matter.
b1d876f1 12426 (switch_to_buffer_1): Now static.
8f54f30a
PE
12427 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12428 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12429
a70072c9 12430 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12431 Fix pointer signedness issue.
edced198
PE
12432 (sys_subshell): Mark local as volatile if checking for lint,
12433 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12434 (MAXPATHLEN): Define only if needed.
a70072c9 12435
a0977c44
PE
12436 * process.c (serial_open, serial_configure): Move decls from here ...
12437 * systty.h: ... to here, so that they can be checked.
12438
a884fdcc
PE
12439 * fns.c (get_random, seed_random): Move extern decls from here ...
12440 * lisp.h: ... to here, so that they can be checked.
12441
604efe86 12442 * sysdep.c (reset_io): Now static.
b8950c94 12443 (wait_for_termination_signal): Remove; unused.
604efe86 12444
38fc62d9
PE
12445 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12446 (copy_keymap_item, append_key, push_text_char_description):
12447 Now static.
1004a21a 12448 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12449 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12450 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12451 (describe_map_tree):
12452 Rename locals to avoid shadowing.
38fc62d9 12453
2f2650da
PE
12454 * keyboard.c: Declare functions static if they are not used elsewhere.
12455 (echo_char, echo_dash, cmd_error, top_level_2):
12456 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12457 (read_char, kbd_buffer_get_event, make_lispy_position):
12458 (make_lispy_event, make_lispy_movement, apply_modifiers):
12459 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12460 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12461 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12462 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12463 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12464
a053e86c 12465 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12466 (mark_kboards): Move decl here ...
12467 * alloc.c (mark_kboards): ... from here.
a053e86c 12468
4752793e
PE
12469 * lisp.h (force_auto_save_soon): New decl.
12470
74f10ca7 12471 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12472 (DEFINE_DUMMY_FUNCTION): New macro.
12473 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12474 Use it.
c03cd23f
PE
12475 (main): Add casts to avoid warnings
12476 if GCC considers string literals to be constants.
74f10ca7 12477
022e70d4
PE
12478 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12479
59d6fe83
PE
12480 * dbusbind.c: Pointer signedness fixes.
12481 (xd_signature, xd_append_arg, xd_initialize):
12482 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12483 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12484 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12485 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12486
78320123
PE
12487 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12488 if GCC considers string literals to be constants.
49cebcca 12489 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12490
35ac2a97
SM
124912011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12492
fb103ca9
SM
12493 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12494 (print_preprocess, print_object): New macro to fix last change.
12495
35ac2a97
SM
12496 * print.c (print_preprocess): Don't forget font objects.
12497
62973b41
JB
124982011-03-16 Juanma Barranquero <lekktu@gmail.com>
12499
12500 * emacs.c (USAGE3): Doc fixes.
12501
0e48bb22
AS
125022011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12503
12504 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12505 structure.
12506
7684e57b
JB
125072011-03-14 Juanma Barranquero <lekktu@gmail.com>
12508
12509 * lisp.h (VWindow_system, Qfile_name_history):
12510 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12511 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12512 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12513
12514 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12515 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12516
12517 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12518 * w32console.c (detect_input_pending, read_input_pending)
12519 (encode_terminal_code):
12520 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12521 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12522 (w32_system_caret_y, Qfile_name_history):
12523 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12524 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12525 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12526 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12527 * w32proc.c (Qlocal, report_file_error):
12528 * w32term.c (Vwindow_system, updating_frame):
12529 * w32uniscribe.c (initialized, uniscribe_font_driver):
12530 Remove unneeded extern declarations.
12531
2aa46d6c
CY
125322011-03-14 Chong Yidong <cyd@stupidchicken.com>
12533
c96bbc66 12534 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12535
cffc6f3b
CY
125362011-03-13 Chong Yidong <cyd@stupidchicken.com>
12537
12538 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12539 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12540 These macros can no longer be used for assignment.
12541
44f230aa
SM
12542 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12543 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12544 (record_buffer_markers, fetch_buffer_markers): New functions for
12545 recording and fetching special buffer markers.
12546 (set_buffer_internal_1, set_buffer_temp): Use them.
12547
12548 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12549
12550 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12551
12552 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12553 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12554
12555 * xdisp.c (hscroll_window_tree):
12556 (reconsider_clip_changes): Use PT instead of BUF_PT.
12557
d251f04b
EZ
125582011-03-13 Eli Zaretskii <eliz@gnu.org>
12559
12560 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12561 $(EMACS_ROOT)/lib/intprops.h.
12562
f0c77cd1
PE
125632011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12564
3eca4629
PE
12565 Fix more problems found by GCC 4.5.2's static checks.
12566
7c86ee98
PE
12567 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12568 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12569 (xg_free_frame_widgets): Make it clear that a local variable is
12570 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12571 (gdk_window_get_screen): Make it clear that this macro is needed
12572 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12573 (int_gtk_range_get_value): New function, which avoids a diagnostic
12574 from gcc -Wbad-function-cast.
12575 (xg_set_toolkit_scroll_bar_thumb): Use it.
12576 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12577 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12578 (get_utf8_string, xg_get_file_with_chooser):
12579 Rename locals to avoid shadowing.
12580 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12581
41729b81
PE
12582 * xgselect.c (xg_select): Remove unused var.
12583
f0c77cd1
PE
12584 * image.c (four_corners_best): Mark locals as initialized.
12585 (gif_load): Initialize transparent_p to zero (Bug#8238).
12586 Mark another local as initialized.
ec6cf4c6 12587 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12588
ce0ad53d 12589 * image.c (clear_image_cache): Now static.
d5d5a617 12590 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12591 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12592 (x_edge_detection): Remove unnecessary cast that
12593 gcc -Wbad-function-cast diagnoses.
2037898d 12594 (gif_load): Fix pointer signedness.
6ae141d6
PE
12595 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12596 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12597
33383987 125982011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12599
d32df629
PE
12600 Improve quality of tests for time stamp overflow.
12601 For example, without this patch (encode-time 0 0 0 1 1
12602 1152921504606846976) returns the obviously-bogus value (-948597
12603 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12604 reports time overflow. See
12605 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12606 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12607 * editfns.c: Include limits.h and intprops.h.
12608 (TIME_T_MIN, TIME_T_MAX): New macros.
12609 (time_overflow): Move earlier, to before first use.
12610 (hi_time, lo_time): New functions, for an accurate test for
12611 out-of-range times.
12612 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12613 (Fget_internal_run_time): Don't assume time_t fits in int.
12614 (make_time): Use list2 instead of Fcons twice.
12615 (Fdecode_time): More accurate test for out-of-range times.
12616 (check_tm_member): New function.
12617 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12618 (lisp_time_argument): Don't rely on undefined left-shift and
12619 right-shift behavior when checking for time stamp overflow.
8be6f318 12620
fe31d94c
PE
12621 * editfns.c (time_overflow): New function, refactoring common code.
12622 (Fformat_time_string, Fdecode_time, Fencode_time):
12623 (Fcurrent_time_string): Use it.
12624
8be6f318
PE
12625 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12626 * dired.c (make_time): Move to ...
12627 * editfns.c (make_time): ... here.
12628 * systime.h: Note the move.
12629
09d9db2c 126302011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12631
126bc0dc
YM
12632 * fringe.c (update_window_fringes): Remove unused variables.
12633
c47cbdfd
YM
12634 * unexmacosx.c (copy_data_segment): Also copy __got section.
12635 (Bug#8223)
12636
7ac80be9
EZ
126372011-03-12 Eli Zaretskii <eliz@gnu.org>
12638
c96bbc66 12639 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12640 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12641 Constify `char *' arguments and their references according to
12642 prototypes in tparam.h.
12643
ecb0f94d 12644 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12645
7ac80be9
EZ
12646 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12647 Adapt all references accordingly.
12648
12649 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12650
ef1fd07e
TT
126512011-03-11 Tom Tromey <tromey@redhat.com>
12652
12653 * buffer.c (syms_of_buffer): Remove obsolete comment.
12654
7ef4b50c
EZ
126552011-03-11 Eli Zaretskii <eliz@gnu.org>
12656
12657 * termhooks.h (encode_terminal_code): Declare prototype.
12658
12659 * msdos.c (encode_terminal_code): Don't declare prototype.
12660
12661 * term.c (encode_terminal_code): Now external again, used by
12662 w32console.c and msdos.c.
12663
44f230aa
SM
12664 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12665 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12666
4b1ec863 126672011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12668
1714f52b 12669 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12670
4b1ec863
PE
12671 * fringe.c (update_window_fringes): Mark locals as initialized
12672 (Bug#8227).
12673 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12674
524c7aa6
PE
12675 * alloc.c (mark_fringe_data): Move decl from here ...
12676 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12677 to check its interface.
12678 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12679
a5c0af81 12680 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12681 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12682 (fontset_font): Mark local as initialized.
a9a06e0b 12683 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12684
b4716021
PE
12685 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12686
811e9bac 12687 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12688 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12689 (x_own_selection, Fx_disown_selection_internal): Rename locals
12690 to avoid shadowing.
12691 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12692
7e3ab302
PE
12693 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12694 so that the caller can use some name other than gcpro1.
12695 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12696 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12697 (Fx_backspace_delete_keys_p):
12698 Use them to avoid shadowing, and rename vars to avoid shadowing.
12699 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12700 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12701 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12702 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12703 Remove unused locals.
7e3ab302
PE
12704 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12705 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12706 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12707 macros.
f78faa98 12708
e2b13473
PE
12709 * xterm.h (x_mouse_leave): New decl.
12710
77f23912
PE
12711 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12712 Remove unused functions.
cdf4ba58
PE
12713 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12714 (x_calc_absolute_position): Now static.
7411c686 12715 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12716 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12717 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12718 unless they are used.
38d0b34a
PE
12719 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12720 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12721 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12722 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12723 (x_error_catcher, x_connection_closed, x_error_handler):
12724 (x_error_quitter, xembed_send_message, x_iconify_frame):
12725 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12726 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12727 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12728
44f230aa
SM
12729 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12730 Rename or move locals to avoid shadowing.
6b463e58 12731 (tty_defined_color, merge_face_heights): Now static.
5967d051 12732 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12733 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12734 does not deduce is never used uninitialized.
73719eba
PE
12735 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12736 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12737
426994c3 12738 * terminal.c (store_terminal_param): Now static.
5489860b 12739
032f1620 12740 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12741 (set_frame_menubar): Remove unused local.
d4323972 12742 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12743 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12744 since they might point to immutable storage.
281585b0
PE
12745 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12746 since it's unused otherwise.
032f1620 12747
367c19e5 12748 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12749 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12750 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12751 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12752 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12753 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12754 does not deduce are never used uninitialized.
70739cbe 12755
07b48fa9
PE
12756 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12757
8868a238 12758 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12759 * window.c (window_loop, size_window):
12760 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12761
7e5cf297 12762 * window.c (display_buffer): Now static.
d6550a9f
PE
12763 (size_window): Mark variables that gcc -Wuninitialized
12764 does not deduce are never used uninitialized.
a586633d
PE
12765 * window.h (check_all_windows): New decl, to forestall
12766 gcc -Wmissing-prototypes diagnostic.
5b555da1 12767 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12768
f6095868
PE
12769 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12770 shadowing.
12771 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12772 Include <limits.h>.
12773 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12774 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12775 (load_charset_map): Mark variables that gcc -Wuninitialized
12776 does not deduce are never used uninitialized.
53df7c11 12777 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12778
f38b440c
PE
12779 * coding.c (coding_set_source, coding_set_destination):
12780 Use "else { /* comment */ }" rather than "else /* comment */;"
12781 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12782 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12783 a block, when the outer 'i' will do.
12784 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12785 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12786 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12787 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12788 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12789 Rename locals to avoid shadowing.
12790 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12791 * coding.c (emacs_mule_char, encode_invocation_designation):
12792 Now static, since they're not used elsewhere.
413bb2db 12793 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12794 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12795 (decode_coding_emacs_mule): Mark variables that gcc
12796 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12797 (detect_coding_iso_2022): Initialize a local variable that might
12798 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12799 this initialization is needed. (Bug#8211)
5f58e762
PE
12800 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12801 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12802 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12803 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12804 Remove unused macros.
f38b440c 12805
232b38b9 12806 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12807 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12808 * character.c (string_count_byte8): Likewise.
232b38b9 12809
fb90da1b
PE
12810 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12811 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12812
fb93dbc2
PE
12813 * chartab.c (copy_sub_char_table): Now static, since it's not used
12814 elsewhere.
5c156ace
PE
12815 (sub_char_table_ref_and_range, char_table_ref_and_range):
12816 Rename locals to avoid shadowing.
bbcd0949 12817 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12818
7d3b3862 12819 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12820 (BIDI_BOB): Remove unused macro.
7d3b3862 12821
6be7d3da
PE
12822 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12823 deduce are never used uninitialized.
c2ed9c8b 12824 * term.c (encode_terminal_code): Likewise.
6be7d3da 12825
75f8807f 12826 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12827
50938595
PE
12828 * tparam.h: New file.
12829 * term.c, tparam.h: Include it.
12830 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12831 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12832 Move these decls to tparam.h, and make them agree with what
12833 is actually in tparam.c. The previous trick of using incompatible
12834 decls in different modules does not conform to the C standard.
12835 All callers of tparam changed to use tparam's actual API.
12836 * tparam.c (tparam1, tparam, tgoto):
12837 Use const pointers where appropriate.
12838
fbceeba2
PE
12839 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12840 * cm.h (struct cm): Likewise.
12841 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12842 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12843 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12844 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12845 (turn_on_face, init_tty): Likewise.
12846 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12847
7f3f1250
PE
12848 * term.c (term_mouse_position): Rename local to avoid shadowing.
12849
e6ca6543
PE
12850 * alloc.c (mark_ttys): Move decl from here ...
12851 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12852
c40f8d15
AS
128532011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12854
12855 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12856
cfe0661d
JB
128572011-03-09 Juanma Barranquero <lekktu@gmail.com>
12858
12859 * search.c (compile_pattern_1): Remove argument regp, unused since
12860 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12861 (compile_pattern): Don't pass it.
12862
0afb4571
J
128632011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12864
12865 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12866 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12867 for ! HAVE_GTK3.
12868 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12869
12870 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12871
12872 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12873 gdk_window_get_screen, gdk_window_get_geometry,
12874 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12875 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12876 (xg_get_pixbuf_from_pixmap): New function.
12877 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12878 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12879 Call xg_get_pixbuf_from_pixmap instead of
12880 gdk_pixbuf_get_from_drawable.
12881 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12882 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12883 (xg_check_special_colors): Use GtkStyleContext and its functions
12884 for HAVE_GTK3.
12885 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12886 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12887 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12888 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12889 Call gtk_widget_get_preferred_size.
0afb4571
J
12890 (xg_frame_resized): gdk_window_get_geometry only takes 5
12891 parameters.
44f230aa
SM
12892 (xg_win_to_widget, xg_event_is_for_menubar):
12893 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12894 (xg_set_widget_bg): New function.
12895 (delete_cb): New function.
895009e1 12896 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12897 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12898 (xg_set_background_color): Call xg_set_widget_bg.
12899 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12900 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12901 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12902 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12903 if ! HAVE_GTK3.
12904 (update_frame_tool_bar): Call gtk_widget_hide.
12905 (xg_initialize): Use GDK_KEY_g.
12906
12907 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12908 if ! HAVE_GTK3
12909 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12910
12911 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12912 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12913 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12914
1c2cc4ef
JB
129152011-03-08 Juanma Barranquero <lekktu@gmail.com>
12916
12917 * w32xfns.c (select_palette): Check success of RealizePalette against
12918 GDI_ERROR, not zero.
12919
33383987 12920See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12921
12922;; Local Variables:
12923;; coding: utf-8
aac0c6e3
MR
12924;; End:
12925
2f097256 12926 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12927
12928 This file is part of GNU Emacs.
12929
12930 GNU Emacs is free software: you can redistribute it and/or modify
12931 it under the terms of the GNU General Public License as published by
12932 the Free Software Foundation, either version 3 of the License, or
12933 (at your option) any later version.
12934
12935 GNU Emacs is distributed in the hope that it will be useful,
12936 but WITHOUT ANY WARRANTY; without even the implied warranty of
12937 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12938 GNU General Public License for more details.
12939
12940 You should have received a copy of the GNU General Public License
12941 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.