* fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f1b54466
PE
12011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2
3 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4 (crypto_hash_function): Now static.
5 Fix pointer signedness problems. Avoid unnecessary initializations.
6
a9f737ee
CY
72011-05-27 Chong Yidong <cyd@stupidchicken.com>
8
9 * termhooks.h (Vselection_alist): Make it terminal-local.
10
11 * terminal.c (create_terminal): Initialize it.
12
13 * xselect.c: Support for clipboard managers.
14 (Vselection_alist): Move to termhooks.h as terminal-local var.
15 (LOCAL_SELECTION): New macro.
16 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
17 (symbol_to_x_atom): Remove gratuitous arg.
18 (x_handle_selection_request, lisp_data_to_selection_data)
19 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
20 (x_own_selection, x_get_local_selection, x_convert_selection): New
21 arg, specifying work frame. Use terminal-local Vselection_alist.
22 (some_frame_on_display): Delete unused function.
23 (Fx_own_selection_internal, Fx_get_selection_internal)
24 (Fx_disown_selection_internal, Fx_selection_owner_p)
25 (Fx_selection_exists_p): New optional frame arg.
26 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
27 (x_handle_selection_clear): Don't treat other terminals with the
28 same keyboard specially. Use the terminal-local Vselection_alist.
29 (x_clear_frame_selections): Use Frun_hook_with_args.
30
31 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
32
33 * xterm.h: Add support for those atoms.
34
e067f0c1
CY
352011-05-26 Chong Yidong <cyd@stupidchicken.com>
36
37 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
38 (converted_selections, conversion_fail_tag): New global variables.
39 (x_selection_request_lisp_error): Free the above.
40 (x_get_local_selection): Remove unnecessary code.
41 (x_reply_selection_request): Args changed; handle arbitrary array
42 of converted selections stored in converted_selections. Separate
43 the XChangeProperty and SelectionNotify steps.
44 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
45 (x_convert_selection): New function.
46 (x_handle_selection_event): Simplify.
47 (x_get_foreign_selection): Don't ignore incoming requests while
48 waiting for an answer; this will fail when we implement
49 SAVE_TARGETS, and seems unnecessary anyway.
50 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
51 (Vx_sent_selection_functions): Doc fix.
52
0f4aebc0
LL
532011-05-26 Leo Liu <sdl.web@gmail.com>
54
55 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
56
e61124cd
YM
572011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
58
59 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
60
61 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
62 for fringe update if it has periodic bitmap.
63 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
64 and fringe_bitmap_periodic_p.
65
66 * fringe.c (get_fringe_bitmap_data): New function.
67 (draw_fringe_bitmap_1, update_window_fringes): Use it.
68 (update_window_fringes): Record periodicity of fringe bitmap in glyph
69 row. Mark glyph row for fringe update if periodicity changed.
70
71 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
72 for fringe update unless it has periodic bitmap.
73
f16d9837
KH
742011-05-25 Kenichi Handa <handa@m17n.org>
75
76 * xdisp.c (get_next_display_element): Set correct it->face_id for
77 a static composition.
78
e1b90ef6
LL
792011-05-24 Leo Liu <sdl.web@gmail.com>
80
81 * deps.mk (fns.o):
82 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
83
84 * fns.c (crypto_hash_function, Fsha1): New function.
85 (Fmd5): Use crypto_hash_function.
86 (syms_of_fns): Add Ssha1.
87
7400048f
PE
882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
89
90 * gnutls.c: Remove unused macros.
91 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
92 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
93 Remove macros that are defined and never used.
94 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
95
abb71cf4
CY
962011-05-22 Chong Yidong <cyd@stupidchicken.com>
97
98 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
99 (Fx_get_selection_internal): Minor cleanup.
100 (Fx_own_selection_internal): Rename arguments for consistency with
101 select.el.
102
6307db39
PE
1032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
104
105 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
106
f3d4e0a4
CY
1072011-05-22 Chong Yidong <cyd@stupidchicken.com>
108
109 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
110
4d8ade89
YM
1112011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
112
113 * dispnew.c (scrolling_window): Don't exclude the case that the
114 last enabled row in the desired matrix touches the bottom boundary.
115
32078c8d
GM
1162011-05-21 Glenn Morris <rgm@gnu.org>
117
118 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
119 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
120 and add some more files.
32078c8d 121
7285dc67
EZ
1222011-05-20 Eli Zaretskii <eliz@gnu.org>
123
124 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
125 report_file_error introduced by the change from 2011-05-07.
126
89d1bd22
PE
1272011-05-20 Paul Eggert <eggert@cs.ucla.edu>
128
129 * systime.h (Time): Define only if emacs is defined.
130 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
131 where the include path doesn't have X11/X.h by default. See
132 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
133
e23640bb 1342011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
135
136 * composite.c (find_automatic_composition): Fix previous change.
137
b9704ad9
GM
1382011-05-20 Glenn Morris <rgm@gnu.org>
139
140 * lisp.mk: New file, split from Makefile.in.
141 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
142 (shortlisp): Remove.
143 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
144
4a720484
GM
1452011-05-19 Glenn Morris <rgm@gnu.org>
146
147 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
148 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
149 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
150 (lisp): Set the order to that of loadup.el.
151 (shortlisp): Make it a copy of $lisp.
152 (SOME_MACHINE_LISP): Remove.
153 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
154 Use just $shortlisp, not $SOME_MACHINE_LISP too.
155
a28d4396
KH
1562011-05-18 Kenichi Handa <handa@m17n.org>
157
158 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
159 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
160 (find_automatic_composition): Mostly rewrite for efficiency.
161
a2b1fa8e
JB
1622011-05-18 Juanma Barranquero <lekktu@gmail.com>
163
164 * makefile.w32-in: Update dependencies.
165
8e1f5610
CS
1662011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
167
168 * menu.c: Include limits.h (fixes the MS-Windows build broken by
169 revision 104625).
170
7025ee00 1712011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 172
cdfa6eab
PE
173 Fix some integer overflow issues, such as string length overflow.
174
06d6db33
PE
175 * insdel.c (count_size_as_multibyte): Check for string overflow.
176
2b4560a8
PE
177 * character.c (lisp_string_width): Check for string overflow.
178 Use EMACS_INT, not int, for string indexes and lengths; in
179 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
180 the resulting string length overflows an EMACS_INT; instead,
181 report a string overflow if no precision given. When checking for
182 precision exhaustion, use a check that cannot possibly have
183 integer overflow. (Bug#8675)
184 * character.h (lisp_string_width): Adjust to new signature.
185
cb93f9be
PE
186 * alloc.c (string_overflow): New function.
187 (Fmake_string): Use it. This doesn't change behavior, but saves
188 a few bytes and will simplify future changes.
189 * character.c (string_escape_byte8): Likewise.
190 * lisp.h (string_overflow): New decl.
191
1a1f3366
PE
192 Fixups, following up to the user-interface timestamp change.
193 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
194 for UI timestamps, instead of unsigned long.
9fbd6841
PE
195 * msdos.c (mouse_get_pos): Likewise.
196 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
197 * w32gui.h (Time): Define by including "systime.h" rather than by
198 declaring it ourselves. (Bug#8664)
199
d4e3e4d3
PE
200 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
201 * image.c (clear_image_cache): Likewise.
202
f6a24d19
PE
203 * term.c (term_mouse_position): Don't assume time_t wraparound.
204
08dc5ae6
PE
205 Be more systematic about user-interface timestamps.
206 Before, the code sometimes used 'Time', sometimes 'unsigned long',
207 and sometimes 'EMACS_UINT', to represent these timestamps. This
208 change causes it to use 'Time' uniformly, as that's what X uses.
209 This makes the code easier to follow, and makes it easier to catch
210 integer overflow bugs such as Bug#8664.
211 * frame.c (Fmouse_position, Fmouse_pixel_position):
212 Use Time, not unsigned long, for user-interface timestamps.
213 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
214 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
215 * keyboard.h (last_event_timestamp): Likewise.
216 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
217 * menu.h (xmenu_show): Likewise.
218 * term.c (term_mouse_position): Likewise.
219 * termhooks.h (struct input_event.timestamp): Likewise.
220 (struct terminal.mouse_position_hook): Likewise.
221 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
222 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
223 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
224 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
225 what it was before.
226 * menu.h, termhooks.h: Include "systime.h", for Time.
227
8e55734a
PE
228 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
229 Don't assume that the difference between two unsigned long values
230 can fit into an integer. At this point, we know button_down_time
231 <= event->timestamp, so the difference must be nonnegative, so
232 there's no need to cast the result if double-click-time is
233 nonnegative, as it should be; check that it's nonnegative, just in
234 case. This bug is triggered when events are more than 2**31 ms
86db42d2 235 apart (about 25 days). (Bug#8664)
8e55734a 236
841f1b75 237 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 238 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 239
3e26f69c
PE
240 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
241 that always fit in int. Use a sentinel instead of a counter, to
242 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
243 * frame.h (struct frame): Use int for menu_bar_items_used
244 instead of EMACS_INT, since it always fits in int.
3e26f69c 245
5cc152c0
PE
246 * menu.c (grow_menu_items): Check for int overflow.
247
d89eb65e
PE
248 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
249
5235bd3e
PE
250 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
251 Before, the code was not consistent. These values cannot exceed
252 2**31 - 1 so there's no need to make them unsigned.
253 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
254 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
255 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
256 as modifiers.
257 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
258
bc827e23
PE
259 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
260 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
261 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
262 presumably because the widths might not match.
263
78eb494e
PE
264 * window.c (size_window): Avoid needless test at loop start.
265
04f2d78b
CB
2662011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
267
268 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
269
d2fc7e3d 2702011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
271
272 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
273
d2fc7e3d 2742011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
275
276 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
277 `width' to `bar_area_x' and `bar_area_width', respectively.
278 (x_scroll_run): Take account of fringe background extension.
279
04f2d78b
CB
280 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
281 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
282 `bar_area_width', respectively.
283 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
284 background extension.
285
79b70037
GM
2862011-05-10 Jim Meyering <meyering@redhat.com>
287
288 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
289
2f142cc5
JB
2902011-05-10 Juanma Barranquero <lekktu@gmail.com>
291
292 * image.c (Finit_image_library): Return t for built-in image types,
293 like pbm and xbm. (Bug#8640)
294
57679c86
AS
2952011-05-09 Andreas Schwab <schwab@linux-m68k.org>
296
297 * w32menu.c (set_frame_menubar): Fix submenu allocation.
298
888c9e86
EZ
2992011-05-07 Eli Zaretskii <eliz@gnu.org>
300
b0512a1d
EZ
301 * w32console.c (Fset_screen_color): Doc fix.
302 (Fget_screen_color): New function.
303 (syms_of_ntterm): Defsubr it.
304
7285dc67
EZ
305 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
306 unlink the temporary file if Fcall_process didn't create it in the
307 first place.
308 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
309 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
310 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
311 cue to call_process_cleanup not to close that handle.
312
4d3fcc8e
BK
3132011-05-07 Ben Key <bkey76@gmail.com>
314
315 * makefile.w32-in: The bootstrap-temacs rule now makes use of
316 one of two shell specific rules, either bootstrap-temacs-CMD or
317 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
318 to the previous implementation of the bootstrap-temacs rule.
319 The bootstrap-temacs-CMD rule is similar to the previous
320 implementation of the bootstrap-temacs rule except that it
321 makes use of the ESC_CFLAGS variable instead of the CFLAGS
322 variable.
323
324 These changes, along with some changes to nt/configure.bat,
325 nt/gmake.defs, and nt/nmake.defs, are required to extend my
326 earlier fix to add support for --cflags and --ldflags options
327 that include quotes so that it works whether make uses cmd or
328 sh as the shell.
329
b4289b64
MA
3302011-05-06 Michael Albinus <michael.albinus@gmx.de>
331
332 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
333 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
334 is a constant.
335 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
336 a string. Handle both cases.
337 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
338 (Fdbus_register_method): Use Qinvalid_function.
339
af4c0e28
JB
3402011-05-06 Juanma Barranquero <lekktu@gmail.com>
341
342 * makefile.w32-in: Update dependencies.
343 (LISP_H): Add inttypes.h and stdin.h.
344 (PROCESS_H): Add unistd.h.
345
c51453d9
EZ
3462011-05-06 Eli Zaretskii <eliz@gnu.org>
347
348 * lread.c: Include limits.h (fixes the MS-Windows build broken by
349 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
350
8ff0ac3c 3512011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 352
4c4b566b
PE
353 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
354
aab2b9b5
PE
355 * term.c (vfatal): Remove stray call to va_end.
356 It's not needed and the C Standard doesn't allow it here anyway.
357
c378da0b
PE
358 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
359 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
360
288b08c7
PE
361 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
362 bytes.
363
e3601888
PE
364 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
365
db6c0e74
PE
366 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
367
dd5963ea
PE
368 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
369
88c9450f
PE
370 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
371
2f9442b8
PE
372 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
373
c032b5f8
PE
374 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
375 * charset.c (Fdefine_charset_internal): Don't initialize
376 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 377 32-bit int (Bug#8600).
a108c10b
PE
378
379 * lread.c (read_integer): Be more consistent with string-to-number.
380 Use string_to_number to do the actual conversion; this avoids
381 rounding errors and fixes some other screwups. Without this fix,
382 for example, #x1fffffffffffffff was misread as -2305843009213693952.
383 (digit_to_number): Move earlier, for benefit of read_integer.
384 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 385 not a digit in any supported base. (Bug#8602)
a108c10b 386
ad5f9eea
PE
387 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
388
aec1708a
PE
389 * dispnew.c (scrolling_window): Return 1 if we scrolled,
390 to match comment at start of function. This also removes a
391 GCC warning about overflow in a 32+64-bit port.
392
47be4ab5
PE
393 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
394
371cac43
PE
395 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
396 Reported by Stefan Monnier in
397 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
398 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
399 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 400
d01a7826
PE
401 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
402 (EMACS_UINTPTR): Likewise, with uintptr_t.
403
7fd47d5c
PE
404 * lisp.h: Prefer 64-bit EMACS_INT if available.
405 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
406 on 32-bit hosts that have 64-bit int, so that they can access
407 large files.
122b0c86
PE
408 However, temporarily disable this change unless the temporary
409 symbol WIDE_EMACS_INT is defined.
7fd47d5c 410
8727937b
PE
411 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
412
8ac068ac
PE
413 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
414 This removes an assumption that EMACS_INT and long are the same
415 width as pointers. The assumption is true for Emacs porting targets
416 now, but we want to make other targets possible.
417 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
418 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
419 In the rest of the code, change types of integers that hold casted
420 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
421 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
422 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
423 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
424 No need to cast type when ORing.
425 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
426 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
427 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
428 assume EMACS_INT is the same width as char *.
429 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
430 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
431 Remove no-longer-needed casts.
432 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
433 (xg_tool_bar_help_callback, xg_make_tool_item):
434 Use EMACS_INTPTR to hold an integer
435 that will be cast to void *; this can avoid a GCC warning
436 if EMACS_INT is not the same width as void *.
437 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
438 * xdisp.c (display_echo_area_1, resize_mini_window_1):
439 (current_message_1, set_message_1):
440 Use a local to convert to proper width without a cast.
441 * xmenu.c (dialog_selection_callback): Likewise.
442
ede49d71
PE
443 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
444 Also, don't assume VALBITS / RAND_BITS is less than 5,
445 and don't rely on undefined behavior when shifting a 1 left into
446 the sign bit.
447 * lisp.h (get_random): Change signature to match.
448
2f30ecd0
PE
449 * lread.c (hash_string): Use size_t, not int, for hash computation.
450 Normally we prefer signed values; but hashing is special, because
451 it's better to use unsigned division on hash table sizes so that
452 the remainder is nonnegative. Also, size_t is the natural width
453 for hashing into memory. The previous code used 'int', which doesn't
454 retain enough info to hash well into very large tables.
455 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
456
2a866e7b
PE
457 * dbusbind.c: Don't possibly lose pointer info when converting.
458 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
459 Use XPNTR rather than XHASH, so that the high-order bits of
460 the pointer aren't lost when converting through void *.
461
51639eac
PE
462 * eval.c (Fautoload): Don't double-shift a pointer.
463
92394119
PE
464 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
465
dbdb9a7c
JB
4662011-05-06 Juanma Barranquero <lekktu@gmail.com>
467
468 * gnutls.c (DEF_GNUTLS_FN):
469 * image.c (DEF_IMGLIB_FN): Make function pointers static.
470
db7a0b4f
AS
4712011-05-05 Andreas Schwab <schwab@linux-m68k.org>
472
473 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
474 marker. (Bug#8610)
475
f7ff1b0f 4762011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
477
478 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
479 New version that can reserve upto 2GB of heap space.
480
f7ff1b0f 4812011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
482
483 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
484
639c109b
TZ
4852011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
486
487 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
488 `gnutls_certificate_set_x509_key_file'.
489
d2127135
JB
4902011-05-05 Juanma Barranquero <lekktu@gmail.com>
491
492 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
493 Update dependencies.
494
e968f4f3
JB
4952011-05-04 Juanma Barranquero <lekktu@gmail.com>
496
497 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
498 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
499 Remove unused parameter `fildes'.
500 * process.c (read_process_output, send_process): Don't pass it.
501
84d358f0
JB
5022011-05-04 Juanma Barranquero <lekktu@gmail.com>
503
504 Fix previous change: the library cache is defined in w32.c.
505 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
506 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
507
0898ca10
JB
5082011-05-04 Juanma Barranquero <lekktu@gmail.com>
509
510 Implement dynamic loading of GnuTLS on Windows.
511
512 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
513 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
514 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
515 Declare.
516
517 * gnutls.c (Qgnutls_dll): Define.
518 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
519 (gnutls_*): Declare function pointers.
520 (init_gnutls_functions): New function to initialize function pointers.
521 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
522 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
523 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
524 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
525 (emacs_gnutls_write, emacs_gnutls_read)
526 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
527 (Fgnutls_available_p): New function.
528 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
529 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
530 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
531
532 * image.c: Include w32.h.
533 (Vimage_type_cache): Delete.
534 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
535 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
536 (w32_delayed_load): Move to w32.c.
537
538 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
539
540 * w32.c (QCloaded_from, Vlibrary_cache): Define.
541 (w32_delayed_load): Move from image.c. When loading a library, record
542 its filename in the :loaded-from property of the library id.
543 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
544 Initialize and staticpro them.
545 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
546
547 * process.c: Include lisp.h before w32.h, not after.
548 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
549 instead of gnutls_record_check_pending.
550
551 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
552
ff4de4aa
TZ
5532011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
554
555 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
556 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
557 as passed in.
558
abe95abb
JD
5592011-05-03 Jan Djärv <jan.h.d@swipnet.se>
560
561 * xterm.c (x_set_frame_alpha): Do not set property on anything
562 else than FRAME_X_OUTER_WINDOW (Bug#8608).
563
e16e55d4
JB
5642011-05-02 Juanma Barranquero <lekktu@gmail.com>
565
566 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
567
bafcf6a5
JB
5682011-05-02 Juanma Barranquero <lekktu@gmail.com>
569
570 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
571 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
572 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
573 (gnutls_global_initialized, Qgnutls_bootprop_priority)
574 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
575 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
576 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
577 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
578 (Qgnutls_bootprop_callbacks_verify): Make static.
579
e7a6747f
AS
5802011-05-01 Andreas Schwab <schwab@linux-m68k.org>
581
19ed11ba
AS
582 * callproc.c: Indentation fixup.
583
e7a6747f 584 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
585 (wait_for_termination, interruptible_wait_for_termination):
586 Move after wait_for_termination_1.
e7a6747f 587
1ef14cb4
LMI
5882011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
589
590 * sysdep.c (interruptible_wait_for_termination): New function
591 which is like wait_for_termination, but allows keyboard
592 interruptions.
593
594 * callproc.c (Fcall_process): Add (:file "file") as an option for
595 the STDOUT buffer.
596 (Fcall_process_region): Ditto.
597
330d880c
EZ
5982011-04-30 Eli Zaretskii <eliz@gnu.org>
599
8db90b73
EZ
600 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
601 rather than `XVECTOR (FOO)->size'.
602
330d880c
EZ
603 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
604 inttypes.h, as a gnulib replacement is used if it not available in
605 system headers.
606
15cbd324
EZ
6072011-04-21 Eli Zaretskii <eliz@gnu.org>
608
609 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
610 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
611 of MOST_POSITIVE_FIXNUM. (Bug#8528)
612
613 * coding.c (coding_alloc_by_realloc): Error out if destination
614 will grow beyond MOST_POSITIVE_FIXNUM.
615 (decode_coding_emacs_mule): Abort if there isn't enough place in
616 charbuf for the composition carryover bytes. Reserve an extra
617 space for up to 2 characters produced in a loop.
618 (decode_coding_iso_2022): Abort if there isn't enough place in
619 charbuf for the composition carryover bytes.
620
6212011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 622
ae940cca
EZ
623 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
624 aborting when %lld or %lll format is passed.
625 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
626 %llo or %llx format is passed. (Bug#8545)
627
03ab8921
EZ
628 * window.c (window_scroll_line_based): Use a marker instead of
629 simple variables to record original value of point. (Bug#7952)
630
afda1437
EZ
631 * doprnt.c (doprnt): Fix the case where a multibyte sequence
632 produced by %s or %c overflows available buffer space. (Bug#8545)
633
f76dee0c
PE
6342011-04-28 Paul Eggert <eggert@cs.ucla.edu>
635
636 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 637 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 638
fdc5744d
JB
6392011-04-28 Juanma Barranquero <lekktu@gmail.com>
640
641 * w32.c (init_environment): Warn about defaulting HOME to C:\.
642
638f053a
JB
6432011-04-28 Juanma Barranquero <lekktu@gmail.com>
644
645 * keyboard.c (Qdelayed_warnings_hook): Define.
646 (command_loop_1): Run `delayed-warnings-hook'
647 if Vdelayed_warnings_list is non-nil.
648 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
649 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
650
d178f871
EZ
6512011-04-28 Eli Zaretskii <eliz@gnu.org>
652
653 * doprnt.c (doprnt): Don't return value smaller than the buffer
654 size if the message was truncated. (Bug#8545).
655
b124fd93
JB
6562011-04-28 Juanma Barranquero <lekktu@gmail.com>
657
658 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
659 (Fx_window_property): #if-0 the whole functions, not just the bodies.
660
e810457d
PE
6612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
662
663 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
664
ea51cceb
JB
6652011-04-27 Juanma Barranquero <lekktu@gmail.com>
666
667 * makefile.w32-in: Update dependencies.
668
94dcfacf
EZ
6692011-04-27 Eli Zaretskii <eliz@gnu.org>
670
671 Improve `doprnt' and its usage. (Bug#8545)
672 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
673 `format_end'. Remove support for %l as a conversion specifier.
674 Don't use xrealloc. Improve diagnostics when the %l size modifier
675 is used. Update the commentary.
676
677 * eval.c (verror): Simplify calculation of size_t.
678
679 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
680 messages.
681
f61f41d7
PE
6822011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
683
684 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
685 change.
686
96fb4434
PE
6872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
688
689 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
690 This makes this file independent of the recent pseudovector change.
691
671875da 6922011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 693
69e9b5a3
PE
694 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
695
b5f869a7 696 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 697 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 698 Remove unused local.
c8926152 699 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 700
841a1577 701 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
702 GCC 4.6.0 optimizes based on type-based alias analysis.
703 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
704 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
705 != &v->size, and therefore "v->size = 1; b->size = 2; return
706 v->size;" must therefore return 1. This assumption is incorrect
707 for Emacs, since it type-puns struct Lisp_Vector * with many other
708 types. To fix this problem, this patch adds a new type struct
f904488f 709 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
710 and pseudovectors, and helps optimizing compilers not get fooled
711 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
712 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
713 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
714 the size member.
eab3844f
PE
715 (XSETPVECTYPE): Rewrite in terms of new macro.
716 (XSETPVECTYPESIZE): New macro, specifying both type and size.
717 This is a bit clearer, and further avoids the possibility of
718 undesirable aliasing.
719 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 720 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
721 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
722 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
723 (ASIZE): Now uses header.size rather than size.
724 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
725 to avoid the hassle of writing XVECTOR (foo)->header.size.
726 (struct vectorlike_header): New type.
eab3844f
PE
727 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
728 object, to help avoid aliasing.
729 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
730 (SUBRP): Likewise, since Lisp_Subr is a special case.
731 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
732 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
733 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 734 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
735 changed to be "header.size" and "header.next".
736 * buffer.h (struct buffer): Likewise.
737 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
738 * frame.h (struct frame): Likewise.
739 * process.h (struct Lisp_Process): Likewise.
740 * termhooks.h (struct terminal): Likewise.
741 * window.c (struct save_window_data, struct saved_window): Likewise.
742 * window.h (struct window): Likewise.
743 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
744 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
745 * buffer.c (init_buffer_once): Likewise.
746 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
747 special case.
748 * process.c (Fformat_network_address): Use local var for size,
749 for brevity.
750
0df1eac5
PE
751 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
752
847ab9d1 753 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
754 * data.c (atof): Remove decl; no longer used or needed.
755 (digit_to_number): Move to lread.c.
756 (Fstring_to_number): Use new string_to_number function, to be
757 consistent with how the Lisp reader treats infinities and NaNs.
758 Do not assume that floating-point numbers represent EMACS_INT
759 without losing information; this is not true on most 64-bit hosts.
760 Avoid double-rounding errors, by insisting on integers when
761 parsing non-base-10 numbers, as the documentation specifies.
762 * lisp.h (string_to_number): New decl, replacing ...
763 (isfloat_string): Remove.
bc0a5c13 764 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 765 (read1): Do not accept +. and -. as integers; this
452f4150
PE
766 appears to have been a coding error. Similarly, do not accept
767 strings like +-1e0 as floating point numbers. Do not report
768 overflow for integer overflows unless the base is not 10 which
769 means we have no simple and reliable way to continue.
770 Break out the floating-point parsing into a new
771 function string_to_number, so that Fstring_to_number parses
772 floating point numbers consistently with the Lisp reader.
04f2d78b 773 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
774 (E_CHAR, EXP_INT): Remove, replacing with ...
775 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
776 (string_to_number): New function, replacing isfloat_string.
777 This function checks for valid syntax and produces the resulting
778 Lisp float number too. Rework it so that string-to-number
bc0a5c13 779 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
780 so that overflow for non-base-10 numbers is reported only when
781 there's no portable and simple way to convert to floating point.
452f4150 782
67769ffc
PE
783 * textprop.c (set_text_properties_1): Rewrite for clarity,
784 and to avoid GCC warning about integer overflow.
785
c20db43f
PE
786 * intervals.h (struct interval): Use EMACS_INT for members
787 where EMACS_UINT might cause problems. See
788 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
789 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
790 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
791 All uses changed.
37aa2f85
PE
792 (offset_intervals): Tell GCC not to worry about length overflow
793 when negating a negative length.
c20db43f 794
2538aa2f
PE
795 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
796 (overrun_check_free): Likewise.
797
f2d3008d
PE
798 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
799 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
800 word size.
801
ec8df744
PE
802 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
803 (gnutls_make_error): Rename local to avoid shadowing.
804 (gnutls_emacs_global_deinit): ifdef out; not used.
805 (Fgnutls_boot): Use const for pointer to readonly storage.
806 Comment out unused local. Fix pointer signedness problems.
807
640ee02d
PE
808 * lread.c (openp): Don't stuff size_t into an 'int'.
809 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
810 about possible signed overflow.
811
6048fb2a
PE
812 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
813 (GDK_KEY_g): Don't define if already defined.
814 (xg_prepare_tooltip): Avoid pointer signedness problem.
815 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
816
fa3c87e1
PE
817 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
818 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
819
2172544b
PE
820 * xfns.c (Fx_window_property): Simplify a bit,
821 to make a bit faster and to avoid GCC 4.6.0 warning.
822 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
823
9b821a21
PE
824 * fns.c (internal_equal): Don't assume size_t fits in int.
825
3c616cfa
PE
826 * alloc.c (compact_small_strings): Tighten assertion a little.
827
c2982e87
PE
828 Replace pEd with more-general pI, and fix some printf arg casts.
829 * lisp.h (pI): New macro, generalizing old pEd macro to other
830 conversion specifiers. For example, use "...%"pI"d..." rather
831 than "...%"pEd"...".
832 (pEd): Remove. All uses replaced with similar uses of pI.
833 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
834 * alloc.c (check_pure_size): Don't overflow by converting size to int.
835 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
836 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
837 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
838 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
839 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
840 64-bit hosts.
841 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
842 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
843 * print.c (safe_debug_print, print_object): Likewise.
844 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
845 to int.
6f04d126
PE
846 Use pI instead of if-then-else-abort. Use %p to avoid casts,
847 avoiding the 0 flag, which is not portable.
c2982e87
PE
848 * process.c (Fmake_network_process): Use pI to avoid cast.
849 * region-cache.c (pp_cache): Likewise.
850 * xdisp.c (decode_mode_spec): Likewise.
851 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
852 behavior on 64-bit hosts with printf arg.
6f04d126 853 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
854 (x_stop_queuing_selection_requests): Likewise.
855 (x_get_window_property): Don't truncate byte count to an 'int'
856 when tracing.
0b432f21 857
5e073ec7
PE
858 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
859 here, since it parses constructs like leading '-' and spaces,
860 which are not wanted; and it overflows with large numbers.
861 Instead, simply match F[0-9]+, which is what is wanted anyway.
862
36372bf9
PE
863 * alloc.c: Remove unportable assumptions about struct layout.
864 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
865 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
866 (allocate_vectorlike, make_pure_vector): Use the new macros,
867 plus offsetof, to remove unportable assumptions about struct layout.
868 These assumptions hold on all porting targets that I know of, but
869 they are not guaranteed, they're easy to remove, and removing them
870 makes further changes easier.
871
0b432f21
PE
872 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
873 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
874 (string_overrun_cookie): Now const. Use initializers that
875 don't formally overflow signed char, to avoid warnings.
000098c1
PE
876 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
877 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
878 (allocate_buffer): Don't assume sizeof (struct buffer) is a
879 multiple of sizeof (EMACS_INT); it need not be, if
880 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 881 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 882
895009e1
JB
8832011-04-26 Juanma Barranquero <lekktu@gmail.com>
884
885 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
886
6a7a1b0b
TZ
8872011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
888
889 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 890 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
891 Reported by Paul Eggert <eggert@cs.ucla.edu>.
892
841a1577 8932011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
894
895 * lisp.h (Qdebug): List symbol.
895009e1 896 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
897 * keyboard.c (debug-on-event): New variable.
898 (handle_user_signal): Break into debugger when debug-on-event
899 matches the current signal symbol.
900
f2d3ba6f
DN
9012011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
902
903 * alloc.c (check_sblock, check_string_bytes)
904 (check_string_free_list): Convert to standard C.
905
42ce4c63
TZ
9062011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
907
908 * w32.c (emacs_gnutls_push): Fix typo.
909
825cd63c
EZ
9102011-04-25 Eli Zaretskii <eliz@gnu.org>
911
fb11d64d
EZ
912 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
913 "cast to pointer from integer of different size".
914
825cd63c
EZ
915 Improve doprnt and its use in verror. (Bug#8545)
916 * doprnt.c (doprnt): Document the set of format control sequences
917 supported by the function. Use SAFE_ALLOCA instead of always
918 using `alloca'.
919
920 * eval.c (verror): Don't limit the buffer size at size_max-1, that
921 is one byte too soon. Don't use xrealloc; instead xfree and
922 xmalloc anew.
923
e061a11b
TZ
9242011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
925
926 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
927 callbacks stage.
928
929 * gnutls.c: Renamed global_initialized to
930 gnutls_global_initialized. Added internals for the
931 :verify-hostname-error, :verify-error, and :verify-flags
932 parameters of `gnutls-boot' and documented those parameters in the
933 docstring. Start callback support.
934 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
935 unless a fatal error occured. Call gnutls_alert_send_appropriate
936 on error. Return error code.
937 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
938 (emacs_gnutls_read): Likewise.
939 (Fgnutls_boot): Return handshake error code.
940 (emacs_gnutls_handle_error): New function.
941 (wsaerror_to_errno): Likewise.
942
943 * w32.h (emacs_gnutls_pull): Add prototype.
944 (emacs_gnutls_push): Likewise.
945
946 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
947 (emacs_gnutls_push): Likewise.
948
9492011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
950
951 * process.c (wait_reading_process_output): Check if GnuTLS
952 buffered some data internally if no FDs are set for TLS
953 connections.
954
955 * makefile.w32-in (OBJ2): Add gnutls.$(O).
956 (LIBS): Link to USER_LIBS.
957 ($(BLD)/gnutls.$(0)): New target.
958
fa6996bc
EZ
9592011-04-24 Eli Zaretskii <eliz@gnu.org>
960
eb35682e
EZ
961 * xdisp.c (handle_single_display_spec): Rename the
962 display_replaced_before_p argument into display_replaced_p, to
963 make it consistent with the commentary. Fix typos in the
964 commentary.
965
e2ad650c
EZ
966 * textprop.c (syms_of_textprop): Remove dead code.
967 (copy_text_properties): Delete obsolete commentary about an
968 interface that was deleted long ago. Fix typos in the description
969 of arguments.
970
1b2de274
EZ
971 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
972 to changes in oldXMenu/XMenu.h from 2011-04-16.
973 <menu_help_message, prev_menu_help_message>: Constify.
974 (IT_menu_make_room): menu->help_text is now `const char **';
975 adjust.
976
977 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
978 to changes in oldXMenu/XMenu.h from 2011-04-16.
979 (struct XMenu): Declare `help_text' `const char **'.
980
981 * xfaces.c <Qunspecified>: Make extern again.
982
983 * syntax.c: Include sys/types.h before including regex.h, as
984 required by Posix.
985
762b15be
EZ
986 * doc.c (get_doc_string): Improve the format passed to `error'.
987
988 * doprnt.c (doprnt): Improve commentary.
989
990 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
991
992 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
993 them with etags.
994
f1052e5d
EZ
995 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
996 changes in globals.h immediately force recompilation.
762b15be
EZ
997 (TAGS): Depend on $(CURDIR)/m/intel386.h and
998 $(CURDIR)/s/ms-w32.h.
999 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1000
fa6996bc
EZ
1001 * character.c (Fchar_direction): Function deleted.
1002 (syms_of_character): Don't defsubr it.
1003 <char-direction-table>: Deleted.
1004
e6c3da20
EZ
10052011-04-23 Eli Zaretskii <eliz@gnu.org>
1006
1007 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1008 * doprnt.c: Include limits.h.
1009 (SIZE_MAX): New macro.
04f2d78b
CB
1010 (doprnt): Return a size_t value. 2nd arg is now size_t.
1011 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1012 Improve overflow protection. Support `l' modifier for integer
1013 conversions. Support %l conversion. Don't assume an EMACS_INT
1014 argument for integer conversions and for %c.
1015
1016 * lisp.h (doprnt): Restore prototype.
1017
1018 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1019 $(SRC)/character.h.
1020
1021 * Makefile.in (base_obj): Add back doprnt.o.
1022
1023 * deps.mk (doprnt.o): Add back prerequisites.
1024 (callint.o): Depend on character.h.
1025
1026 * eval.c (internal_lisp_condition_case): Include the handler
1027 representation in the error message.
1028 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1029 when breaking from the loop.
1030
1031 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1032
1033 * callint.c (Fcall_interactively): When displaying error message
1034 about invalid control letter, pass the character's codepoint, not
1035 a pointer to its multibyte form. Improve display of the character
1036 in octal and display also its hex code.
1037
1038 * character.c (char_string): Use %x to display the (unsigned)
1039 codepoint of an invalid character, to avoid displaying a bogus
1040 negative value.
1041
1042 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1043 `error', not SYMBOL_NAME itself.
1044
1045 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1046 character arguments to `error'.
1047
1048 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1049 to `error' in error message about FINAL_CHAR argument. Make sure
1050 FINAL_CHAR is a character, and use %c when it is passed as
1051 argument to `error'.
1052
4ffd0d6b 10532011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1054
1055 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1056
1057 * w32.c: Include <time.h>.
1058 (sys_localtime): New function.
1059
4ffd0d6b 10602011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1061
1062 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1063
4ffd0d6b 1064 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1065
4ffd0d6b 10662011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1067
4ffd0d6b
GM
1068 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1069 zombies (Bug#8467).
aac0c6e3 1070
04c56954
EZ
10712011-04-19 Eli Zaretskii <eliz@gnu.org>
1072
1073 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1074 gl_state.e_property when gl_state.object is Qt.
1075
1076 * insdel.c (make_gap_larger): Remove limitation of buffer size
1077 to <= INT_MAX.
1078
16a43933
CY
10792011-04-18 Chong Yidong <cyd@stupidchicken.com>
1080
1081 * xdisp.c (lookup_glyphless_char_display)
1082 (produce_glyphless_glyph): Handle cons cell entry in
1083 glyphless-char-display.
1084 (Vglyphless_char_display): Document it.
1085
1086 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1087 glyphless-char-display.
1088
4581706e
CY
10892011-04-17 Chong Yidong <cyd@stupidchicken.com>
1090
1091 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1092
1093 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1094
1095 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1096 definition for no-X builds.
1097
4887c6e2 10982011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1099
fd35b6f9
PE
1100 Static checks with GCC 4.6.0 and non-default toolkits.
1101
5c1ccb01
PE
1102 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1103
006c5daa
PE
1104 * process.c (keyboard_bit_set): Define only if SIGIO.
1105 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1106 (send_process): Repair possible setjmp clobbering.
1107
efc736d3
PE
1108 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1109
4e2fe2e6
PE
1110 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1111
f97334a2
PE
1112 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1113
4e75f29d
PE
1114 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1115 Define only if needed.
1116
90efadd1
PE
1117 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1118 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1119 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1120
3c647824
PE
1121 * dispextern.h (struct redisplay_interface): Rename param
1122 to avoid shadowing.
e264f262 1123 * termhooks.h (struct terminal): Likewise.
761383f4 1124 * xterm.c (xembed_send_message): Likewise.
3c647824 1125
b58c5c4a
PE
1126 * insdel.c (make_gap_smaller): Define only if
1127 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1128
cad59032
PE
1129 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1130 it.
1131
c339dc2e
PE
1132 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1133 so that we aren't warned about unused symbols.
1134
91a3e27b
PE
1135 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1136
399c71d3 1137 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1138
8ffc96f5
PE
1139 * xfns.c (x_real_positions): Mark locals as initialized.
1140
eef9bc79
PE
1141 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1142
098db9dd
PE
1143 * xterm.c: Fix problems found by static analysis with other toolkits.
1144 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1145 (x_dispatch_event): Declare static if USE_GTK, and
1146 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1147 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1148 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1149 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1150 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1151
eb18f6cc
PE
1152 * xmenu.c (menu_help_callback): Pointer type fixes.
1153 Use const pointers when pointing at readonly data. Avoid pointer
1154 signedness clashes.
1155 (FALSE): Remove unused macro.
1156 (update_frame_menubar): Remove unused decl.
1157
1fe72bf8
PE
1158 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1159
60d9e1db
PE
1160 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1161 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1162 (single_menu_item): Rename local to avoid shadowing.
1163
39261c26
PE
1164 * keyboard.c (make_lispy_event): Remove unused local var.
1165
018c5e19
PE
1166 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1167 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1168
63d2b86e
PE
1169 * bitmaps: Change bitmaps from unsigned char back to the X11
1170 compatible char. Avoid the old compiler warnings about
1171 out-of-range initializers by using, for example, '\xab' rather
1172 than 0xab.
1173
aefd87e1
PE
1174 * xgselect.c (xgselect_initialize): Check vs interface
1175 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1176
bf501fb9
PE
1177 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1178
e9829fdf
PE
1179 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1180 to read-only memory.
1181
1086c095
PE
1182 * fns.c (vector): Remove; this old hack is no longer needed.
1183
2baccd04 1184 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1185 Remove unused var.
dde42981 1186 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1187
72391843 1188 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1189
436c16df 1190 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1191 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1192 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1193
92bb796d 1194 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1195 (x_term_init): Remove local to avoid shadowing.
92bb796d 1196
764430a3 1197 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1198
1199 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1200 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1201
d1dfb56c
EZ
12022011-04-16 Eli Zaretskii <eliz@gnu.org>
1203
c4354cb4
EZ
1204 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1205
d1dfb56c
EZ
1206 Fix regex.c, syntax.c and friends for buffers > 2GB.
1207 * syntax.h (struct gl_state_s): Declare character position members
1208 EMACS_INT.
1209
1210 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1211
04f2d78b
CB
1212 * textprop.c (verify_interval_modification, interval_of):
1213 Declare arguments EMACS_INT.
d1dfb56c
EZ
1214
1215 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1216 EMACS_INT.
1217
1218 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1219
1220 * indent.c (Fvertical_motion): Local variable it_start is now
1221 EMACS_INT.
1222
1223 * regex.c (re_match, re_match_2, re_match_2_internal)
1224 (bcmp_translate, regcomp, regexec, print_double_string)
1225 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1226 (re_compile_pattern, re_exec): Declare arguments and local
1227 variables `size_t' and `ssize_t' and return values `regoff_t', as
1228 appropriate.
1229 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1230 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1231 <compile_stack_type>: `size' and `avail' are now `size_t'.
1232
1233 * regex.h <regoff_t>: Use ssize_t, not int.
1234 (re_search, re_search_2, re_match, re_match_2): Arguments that
1235 specify buffer/string position and length are now ssize_t and
1236 size_t. Return type is regoff_t.
1237
613052cd
BK
12382011-04-16 Ben Key <bkey76@gmail.com>
1239
1240 * nsfont.m: Fixed bugs in ns_get_family and
1241 ns_descriptor_to_entity that were caused by using free to
1242 deallocate memory blocks that were allocated by xmalloc (via
1243 xstrdup). This caused Emacs to crash when compiled with
1244 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1245 --enable-checking=xmallocoverrun). xfree is now used to
1246 deallocate these memory blocks.
1247
4170f62f 12482011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1249
71b41406
PE
1250 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1251
9587a89d
PE
1252 emacs_write: Accept and return EMACS_INT for sizes.
1253 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1254 et seq.
1255 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1256 Accept and return EMACS_INT.
1257 (emacs_gnutls_write): Return the number of bytes written on
1258 partial writes.
1259 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1260 (emacs_read, emacs_write): Remove check for negative size, as the
1261 Emacs source code has been audited now.
9587a89d
PE
1262 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1263 (emacs_read, emacs_write): Use it.
273a5f82
PE
1264 * process.c (send_process): Adjust to the new signatures of
1265 emacs_write and emacs_gnutls_write. Do not attempt to store
1266 a byte offset into an 'int'; it might overflow.
9587a89d 1267 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1268
3e047f51
PE
1269 * sound.c: Don't assume sizes fit in 'int'.
1270 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1271 Return EMACS_INT, not int.
3e047f51 1272 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1273 Accept EMACS_INT, not int.
1274 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1275 record read return values.
1276
cc39a9db
BK
12772011-04-15 Ben Key <bkey76@gmail.com>
1278
c9d0ec6d
JB
1279 * keyboard.c (Qundefined): Don't declare static since it is used
1280 in nsfns.m.
1281 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1282 static since they are used in nsfont.m.
cc39a9db 1283
6c60eb9f
SM
12842011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1285
1286 * process.c (Qprocessp): Don't declare static.
1287 * lisp.h (Qprocessp): Declare again.
1288
7990b61a
JB
12892011-04-15 Juanma Barranquero <lekktu@gmail.com>
1290
1291 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1292
5d4cb038
PE
12932011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1294
8bd7b830 1295 Improve C-level modularity by making more things 'static'.
cd64ea1d 1296
e3b27b31
PE
1297 Don't publish debugger-only interfaces to other modules.
1298 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1299 (verify_bytepos, count_markers): Move decls to the only modules
1300 that need them.
1301 * region-cache.h (pp_cache): Likewise.
1302 * window.h (check_all_windows): Likewise.
1303 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1304
5d4cb038
PE
1305 * sysdep.c (croak): Now static, if
1306 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1307 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1308
1309 * alloc.c (refill_memory_reserve): Now static if
1310 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1311 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1312
e87b6180
PE
1313 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1314 Define only if USE_LUCID.
1315
ac64929e
PE
1316 * xrdb.c (x_customization_string, x_rm_string): Now static.
1317
6f37259d
PE
1318 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1319 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1320
1683e3ab
PE
1321 * xdisp.c (draw_row_with_mouse_face): Now static.
1322 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1323
de9c2632
PE
1324 * window.h (check_all_windows): Mark externally visible.
1325
2b96acb7
PE
1326 * window.c (window_deletion_count): Now static.
1327
1328 * undo.c: Make symbols static if they're not exported.
1329 (last_undo_buffer, last_boundary_position, pending_boundary):
1330 Now static.
1331
50436f33
PE
1332 * textprop.c (interval_insert_behind_hooks): Now static.
1333 (interval_insert_in_front_hooks): Likewise.
1334
64520e5c
PE
1335 * term.c: Make symbols static if they're not exported.
1336 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1337 (max_frame_lines, tty_set_terminal_modes):
1338 (tty_reset_terminal_modes, tty_turn_off_highlight):
1339 (get_tty_terminal): Now static.
1340 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1341 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1342 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1343 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1344 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1345
1fa53021
PE
1346 * sysdep.c: Make symbols static if they're not exported.
1347 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1348 Now static.
1349 (sigprocmask_set, full_mask): Remove; unused.
1350 (wait_debugging): Mark as visible.
1351 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1352 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1353
d4b43b22
PE
1354 * syntax.c (syntax_temp): Define only if !__GNUC__.
1355
b7c513d0
PE
1356 * sound.c (current_sound_device, current_sound): Now static.
1357
989b29ad
PE
1358 * search.c (searchbufs, searchbuf_head): Now static.
1359
13a55a78
PE
1360 * scroll.c (scroll_cost): Remove; unused.
1361 * dispextern.h (scroll_cost): Remove decl.
1362
de68a1fc
PE
1363 * region-cache.h (pp_cache): Mark as externally visible.
1364
40ccffa6
PE
1365 * process.c: Make symbols static if they're not exported.
1366 (process_tick, update_tick, create_process, chan_process):
1367 (Vprocess_alist, proc_buffered_char, datagram_access):
1368 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1369 (deactivate_process): Mark defn as static, as well as decl.
1370 * lisp.h (create_process): Remove decl.
1371 * process.h (chan_process, Vprocess_alist): Remove decls.
1372
ad64fc97
PE
1373 * print.c: Make symbols static if they're not exported.
1374 (print_depth, new_backquote_output, being_printed, print_buffer):
1375 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1376 (print_interval, print_number_index, initial_stderr_stream):
1377 Now static.
1378 * lisp.h (Fprinc): Remove decl.
1379 (debug_output_compilation_hack): Mark as externally visible.
1380
adddb265
PE
1381 * sysdep.c (croak): Move decl from here to syssignal.h.
1382 * syssignal.h (croak): Put it here, so the API can be checked when
1383 'croak' is called from dissociate_if_controlling_tty.
1384
1717ede2
PE
1385 * minibuf.c: Make symbols static if they're not exported.
1386 (minibuf_save_list, choose_minibuf_frame): Now static.
1387 * lisp.h (choose_minibuf_frame): Remove decl.
1388
fa5fb2bc
PE
1389 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1390
1e3890d1
PE
1391 * lread.c: Make symbols static if they're not exported.
1392 (read_objects, initial_obarray, oblookup_last_bucket_number):
1393 Now static.
1394 (make_symbol): Remove; unused.
1395 * lisp.h (initial_obarray, make_symbol): Remove decls.
1396
8a1414fa
PE
1397 * keyboard.c: Make symbols static if they're not exported.
1398 (single_kboard, recent_keys_index, total_keys, recent_keys):
1399 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1400 (this_single_command_key_start, echoing, last_auto_save):
1401 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1402 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1403 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1404 (Vlispy_mouse_stem, double_click_count):
1405 Now static.
1406 (force_auto_save_soon): Define only if SIGDANGER.
1407 (ignore_mouse_drag_p): Now static if
1408 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1409 (print_help): Remove; unused.
1410 (stop_character, last_timer_event): Mark as externally visible.
1411 * keyboard.h (ignore_mouse_drag_p): Declare only if
1412 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1413 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1414 * lisp.h (echoing): Remove decl.
1415 (force_auto_save_soon): Declare only if SIGDANGER.
1416 * xdisp.c (redisplay_window): Simplify code, to make it more
1417 obvious that ignore_mouse_drag_p is not accessed if !defined
1418 USE_GTK && !defined HAVE_NS.
1419
93ea6e8f
PE
1420 * intervals.c: Make symbols static if they're not exported.
1421 (merge_properties_sticky, merge_interval_right, delete_interval):
1422 Now static.
1423 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1424
77382fcc
PE
1425 * insdel.c: Make symbols static if they're not exported.
1426 However, leave prepare_to_modify_buffer alone. It's never
1427 called from outside this function, but that appears to be a bug.
1428 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1429 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1430 (adjust_after_replace_noundo): Remove; unused.
1431 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1432 (signal_before_change): Remove decls.
77382fcc 1433
9306c32e
PE
1434 * indent.c (val_compute_motion, val_vmotion): Now static.
1435
cd44d2eb
PE
1436 * image.c: Make symbols static if they're not exported.
1437 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1438 if USE_GTK.
1439 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1440 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1441
ad9a7a06
PE
1442 * fringe.c (standard_bitmaps): Now static.
1443 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1444
81626931
PE
1445 * frame.c: Make symbols static if they're not exported.
1446 (x_report_frame_params, make_terminal_frame): Now static.
1447 (get_frame_param): Now static, unless HAVE_NS.
1448 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1449 (x_get_resource_string): Remove; not used.
1450 * frame.h (make_terminal_frame, x_report_frame_params):
1451 (x_get_resource_string); Remove decls.
1452 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1453 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1454
239f9db9
PE
1455 * font.c, fontset.c: Make symbols static if they're not exported.
1456 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1457 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1458 * font.c (font_close_object): Now static.
1459 * font.h (font_close_object): Remove.
1460 * fontset.c (FONTSET_OBJLIST): Remove.
1461 (free_realized_fontset) #if-0 the body, which does nothing.
1462 (face_suitable_for_char_p): #if-0, as it's never called.
1463 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1464 * xfaces.c (face_at_string_position):
1465 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1466 since 0 is always ASCII.
1467
dfcf3579
PE
1468 * fns.c (weak_hash_tables): Now static.
1469
5045092b
PE
1470 * fileio.c: Make symbols static if they're not exported.
1471 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1472 (Vwrite_region_annotation_buffers): Now static.
1473
57a96f5c
PE
1474 * eval.c: Make symbols static if they're not exported.
1475 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1476 * lisp.h (backtrace_list): Remove decl.
1477
35f08c38
PE
1478 * emacs.c: Make symbols static if they're not exported.
1479 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1480 (fatal_error_code, fatal_error_signal_hook, standard_args):
1481 Now static.
1482 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1483 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1484 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1485 * lisp.h (fatal_error_signal_hook): Remove decl.
1486 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1487
f44bd759
PE
1488 * editfns.c: Move a (normally-unused) function to its only use.
1489 * editfns.c, lisp.h (get_operating_system_release): Remove.
1490 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1491 worth the hassle of breaking this out.
1492
b532497d
PE
1493 * xterm.c: Make symbols static if they're not exported.
1494 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1495 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1496 (x_destroy_window, x_delete_display):
1497 Now static.
1498 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1499 (x_mouse_leave): Remove; unused.
1500 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1501 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1502 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1503 Remove decls.
1504 (x_mouse_leave): Declare only if WINDOWSNT.
1505 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1506 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1507 USE_X_TOOLKIT.
1508
1675728f
PE
1509 * ftxfont.c: Make symbols static if they're not exported.
1510 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1511 HAVE_FREETYPE.
1512 * font.h (ftxfont_driver): Likewise.
1513
e4cebfca
PE
1514 * xfns.c: Make symbols static if they're not exported.
1515 (x_last_font_name, x_display_info_for_name):
1516 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1517 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1518 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1519 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1520 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1521 (last_show_tip_args): Now static.
1522 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1523 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1524 (x_screen_planes): Remove; unused.
1525 * dispextern.h (x_screen_planes): Remove decl.
1526
5bf46f05
PE
1527 * dispnew.c: Make symbols static if they're not exported.
1528 * dispextern.h (redraw_garbaged_frames, scrolling):
1529 (increment_row_positions): Remove.
1530 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1531 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1532 Now static.
1533 (redraw_garbaged_frames): Remove; unused.
1534
435f4c28
PE
1535 * xfaces.c: Make symbols static if they're not exported.
1536 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1537 Remove decls.
1538 * xterm.h (defined_color): Remove decls.
1539 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1540 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1541 (menu_face_changed_default, defined_color, free_realized_face):
1542 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1543 (ascii_face_of_lisp_face): Remove; unused.
1544
8524aef3
PE
1545 * xdisp.c: Make symbols static if they're not exported.
1546 * dispextern.h (scratch_glyph_row, window_box_edges):
1547 (glyph_to_pixel_coords, set_cursor_from_row):
1548 (get_next_display_element, set_iterator_to_next):
1549 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1550 (show_mouse_face): Remove decls
1551 * frame.h (message_buf_print): Likewise.
1552 * lisp.h (pop_message, set_message, check_point_in_composition):
1553 Likewise.
1554 * xterm.h (set_vertical_scroll_bar): Likewise.
1555 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1556 (message_buf_print, scratch_glyph_row, displayed_buffer):
1557 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1558 (get_next_display_element, show_mouse_face, window_box_edges):
1559 (frame_to_window_pixel_xy, check_point_in_composition):
1560 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1561 (glyph_to_pixel_coords): Remove; unused.
1562
16390cd2
PE
1563 * dired.c (file_name_completion): Now static.
1564
1565 * dbusbind.c (xd_in_read_queued_messages): Now static.
1566
a25f4dfa
PE
1567 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1568 * data.c (circular_list_error): Remove.
1569
14a9c8df
PE
1570 * commands.h (last_point_position, last_point_position_buffer):
1571 (last_point_position_window): Remove decls.
1572 * keyboard.c: Make these variables static.
1573
04f2d78b
CB
1574 * coding.h (coding, code_convert_region, encode_coding_gap):
1575 Remove decls.
74ab6df5
PE
1576 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1577 (iso_code_class, detect_coding, code_convert_region): Now static.
1578 (encode_coding_gap): Remove; unused.
1579
38dfbee1
PE
1580 * chartab.c (chartab_chars, chartab_bits): Now static.
1581
a2cb4e63
PE
1582 * charset.h (charset_iso_8859_1): Remove decl.
1583 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1584 Now static.
1585
127198fd
PE
1586 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1587 * ccl.c (Vccl_program_table): Now static.
1588 (check_ccl_update): Remove; unused.
1589
d85b608f
PE
1590 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1591 * category.h: ... from here.
1592 * category.c (check_category_table, set_category_set): Now static.
1593
31cd66f3
PE
1594 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1595 * lisp.h: Remove these decls.
1596
c358e587
PE
1597 * buffer.c (buffer_count): Remove unused var.
1598
e78aecca
PE
1599 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1600 so that it's not optimized away.
1601 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1602 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1603 exported only to the debugger.
1604
e192d7d3 1605 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1606 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1607
92470028
PE
1608 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1609 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1610 was inaccessible from Lisp.
1611 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1612 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1613
244ed907
PE
1614 alloc.c: Import and export fewer symbols, and remove unused items.
1615 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1616 is defined.
1617 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1618 it's not optimized away by whole-program optimization.
1619 (message_enable_multibyte, free_misc): Remove.
1620 (catchlist, handlerlist, mark_backtrace):
1621 Declare only if BYTE_MARK_STACK.
1622 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1623 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1624 (message_enable_multibyte): Remove decl.
1625 (free_misc, interval_free_list, float_block, float_block_index):
1626 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1627 (cons_free_list, last_marked_index):
1628 Now static.
1629 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1630 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1631 (mark_backtrace): Define only if BYTE_MARK_STACK.
1632 * xdisp.c (message_enable_multibyte): Now static.
1633
61c2b50e 1634 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1635 This makes it easier for human readers (and static analyzers)
1636 to see whether these variables are used from other modules.
1637 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1638 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1639 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1640 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1641 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1642 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1643 * xmenu.c, xselect.c:
1644 Declare Q* vars static if they are not used in other modules.
1645 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1646 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1647 Remove decls of unexported vars.
1648 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1649
95c82688
PE
1650 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1651
16a97296
PE
1652 Make Emacs functions such as Fatom 'static' by default.
1653 This makes it easier for human readers (and static analyzers)
1654 to see whether these functions can be called from other modules.
1655 DEFUN now defines a static function. To make the function external
1656 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1657 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1658 (Finit_image_library):
16a97296
PE
1659 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1660 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1661 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1662 Remove decls, since these functions are now static.
1663 (Funintern, Fget_internal_run_time): New decls, since these functions
1664 were already external.
95c82688 1665
16a97296
PE
1666 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1667 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1668 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1669 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1670 * keyboard.c, keymap.c, lread.c:
1671 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1672 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1673 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1674 Mark functions with DEFUE instead of DEFUN,
1675 if they are used in other modules.
1676 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1677 decls for now-static functions.
1678 * buffer.h (Fdelete_overlay): Remove decl.
1679 * callproc.c (Fgetenv_internal): Mark as internal.
1680 * composite.c (Fremove_list_of_text_properties): Remove decl.
1681 (Fcomposition_get_gstring): New forward static decl.
1682 * composite.h (Fcomposite_get_gstring): Remove decl.
1683 * dired.c (Ffile_attributes): New forward static decl.
1684 * doc.c (Fdocumntation_property): New forward static decl.
1685 * eval.c (Ffetch_bytecode): New forward static decl.
1686 (Funintern): Remove extern decl; now in .h file where it belongs.
1687 * fileio.c (Fmake_symbolic_link): New forward static decl.
1688 * image.c (Finit_image_library): New forward static decl.
1689 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1690 * intervals.h (Fprevious_property_change):
1691 (Fremove_list_of_text_properties): Remove decls.
1692 * keyboard.c (Fthis_command_keys): Remove decl.
1693 (Fcommand_execute): New forward static decl.
1694 * keymap.c (Flookup_key): New forward static decl.
1695 (Fcopy_keymap): Now static.
1696 * keymap.h (Flookup_key): Remove decl.
1697 * process.c (Fget_process): New forward static decl.
1698 (Fprocess_datagram_address): Mark as internal.
1699 * syntax.c (Fsyntax_table_p): New forward static decl.
1700 (skip_chars): Remove duplicate decl.
1701 * textprop.c (Fprevious_property_change): New forward static decl.
1702 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1703 Now internal.
1704 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1705 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1706
785bbd42
PE
1707 * editfns.c (Fformat): Remove unreachable code.
1708
8b913b57
AS
17092011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1710
1711 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1712 change. (Bug#8496)
1713
a6744a35
EZ
17142011-04-13 Eli Zaretskii <eliz@gnu.org>
1715
1716 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1717 when at ZV. (Bug#8487)
1718
e7974947
AS
17192011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1720
baad03f0
AS
1721 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1722 (Bug#8437)
1723 * keyboard.c (parse_tool_bar_item): Likewise.
1724 * sound.c (sound_cleanup, alsa_close): Likewise.
1725 * termcap.c (tgetent): Likewise.
1726 * xfns.c (x_default_font_parameter): Likewise.
1727 * xsettings.c (read_and_apply_settings): Likewise.
1728
e7974947
AS
1729 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1730 (overrun_check_free): Protoize.
1731
28272684
PE
17322011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1733
1734 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1735 since callers should never pass a negative size.
1736 Change the signature to match that of plain 'read' and 'write'; see
1737 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1738 * lisp.h: Update prototypes of emacs_write and emacs_read.
1739
11997c76
EZ
17402011-04-11 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (redisplay_window): Don't try to determine the character
1743 position of the scroll margin if the window start point w->startp
e896f03c 1744 is outside the buffer's accessible region. (Bug#8468)
11997c76 1745
8a2cbd72
EZ
17462011-04-10 Eli Zaretskii <eliz@gnu.org>
1747
1748 Fix write-region and its subroutines for buffers > 2GB.
1749 * fileio.c (a_write, e_write): Modify declaration of arguments and
1750 local variables to support buffers larger than 2GB.
1751 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1752
1753 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1754 argument, local variables, and return value.
1755
1756 * lisp.h: Update prototypes of emacs_write and emacs_read.
1757
1758 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1759
4073e537 17602011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1761
1ebfdcb6
PE
1762 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1763
b2ded58d
PE
1764 Fix more problems found by GCC 4.6.0's static checks.
1765
7d66342c
PE
1766 * xdisp.c (vmessage): Use a better test for character truncation.
1767
bbf47d44
PE
1768 * charset.c (load_charset_map): <, not <=, for optimization,
1769 and to avoid potential problems with integer overflow.
9248994d 1770 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1771 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1772 * editfns.c (Fformat): Likewise.
1e69125e 1773 * syntax.c (skip_chars): Likewise.
3befa583 1774
e3019616
PE
1775 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1776 This also lets GCC 4.6.0 generate slightly better loop code.
1777
becfa255
PE
1778 * callint.c (Fcall_interactively): <, not <=, for optimization.
1779 (Fcall_interactively): Count the number of arguments produced,
1780 not the number of arguments given. This is simpler and lets GCC
1781 4.6.0 generate slightly better code.
1782
dae0cd48
PE
1783 * ftfont.c: Distingish more carefully between FcChar8 and char.
1784 The previous code passed unsigned char * to a functions like
1785 strlen and xstrcasecmp that expect char *, which does not
1786 conform to the C standard.
1787 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1788 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1789 char * when the C standard requires it.
1790
76032d70
PE
1791 * keyboard.c (read_char): Remove unused var.
1792
eb3f1cc8
PE
1793 * eval.c: Port to Windows vsnprintf (Bug#8435).
1794 Include <limits.h>.
1795 (SIZE_MAX): Define if the headers do not.
1796 (verror): Do not give up if vsnprintf returns a negative count.
1797 Instead, grow the buffer. This ports to Windows vsnprintf, which
1798 does not conform to C99. Problem reported by Eli Zaretskii.
1799 Also, simplify the allocation scheme, by avoiding the need for
1800 calling realloc, and removing the ALLOCATED variable.
1801
70476b54
PE
1802 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1803
12020a9e
PE
1804 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1805 But keep the doprint source code for now, as we might revamp it
1806 and use it again (Bug#8435).
ea6c7ae6
PE
1807 * lisp.h (doprnt): Remove.
1808 * Makefile.in (base_obj): Remove doprnt.o.
1809 * deps.mk (doprnt.o): Remove.
1810
5fdb398c
PE
1811 error: Print 32- and 64-bit integers portably (Bug#8435).
1812 Without this change, on typical 64-bit hosts error ("...%d...", N)
1813 was used to print both 32- and 64-bit integers N, which relied on
1814 undefined behavior.
1815 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1816 New macro.
1817 * lisp.h (error, verror): Mark as printf-like functions.
1818 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1819 Report overflow in size calculations when allocating printf buffer.
1820 Do not truncate output string at its first null byte.
1821 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1822 Truncate the output at a character boundary, since vsnprintf does not
1823 do that.
1824 * charset.c (check_iso_charset_parameter): Convert internal
1825 character to string before calling 'error', since %c now has the
1826 printf meaning.
1827 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1828 overflow when computing char to be passed to 'error'. Do not
1829 pass Lisp_Object to 'error'; pass the integer instead.
1830 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1831 formatted with plain %d.
1832
b189fa66
PE
1833 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1834
bff87ef0
PE
1835 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1836
7e2cac20
PE
1837 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1838
ce4d90b5
PE
1839 * xterm.c (x_catch_errors): Remove duplicate declaration.
1840
266c9547
PE
1841 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1842
79c49ad2
PE
1843 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1844
368f4090
JM
18452011-04-10 Jim Meyering <meyering@redhat.com>
1846
1847 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1848 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1849 return ssize_t not "int", and use size_t as the buffer length.
1850 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1851 * gnutls.h: Update declarations.
1852 * process.c (read_process_output): Use ssize_t, to match.
1853 (send_process): Likewise.
1854
a32d4040
CY
18552011-04-09 Chong Yidong <cyd@stupidchicken.com>
1856
1857 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1858
8546720e 18592011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1860
04f2d78b
CB
1861 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1862 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1863
8546720e
GM
1864 * xterm.c (handle_one_xevent):
1865 * xmenu.c (create_and_show_popup_menu):
1866 * xselect.c (x_decline_selection_request)
1867 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1868
0a2f5c1a 18692011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1870
1871 Fix some uses of `int' instead of EMACS_INT.
1872 * search.c (string_match_1, fast_string_match)
1873 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1874 (scan_buffer, find_next_newline_no_quit)
1875 (find_before_next_newline, search_command, Freplace_match)
1876 (Fmatch_data): Make some `int' variables be EMACS_INT.
1877
1878 * xdisp.c (display_count_lines): 3rd argument and return value now
1879 EMACS_INT. All callers changed.
1880 (pint2hrstr): Last argument is now EMACS_INT.
1881
1882 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1883 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1884 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1885 (decode_coding_utf_16, decode_coding_emacs_mule)
1886 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1887 (decode_coding_ccl, decode_coding_charset)
1888 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1889 (decode_coding_iso_2022, decode_coding_emacs_mule)
1890 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1891 <char_offset, last_offset>: Declare EMACS_INT.
1892 (encode_coding_utf_8, encode_coding_utf_16)
1893 (encode_coding_emacs_mule, encode_invocation_designation)
1894 (encode_designation_at_bol, encode_coding_iso_2022)
1895 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1896 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1897 Declare EMACS_INT.
1898 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1899 (encode_invocation_designation): Last argument P_NCHARS is now
1900 EMACS_INT.
1901 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1902 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1903
1904 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1905 All users changed.
1906
1907 * ccl.c (Fccl_execute_on_string): Declare some variables
1908 EMACS_INT.
1909
8546720e 19102011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1911
1912 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1913
4e19a977
CS
19142011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1915
1916 * process.c (Fformat_network_address): Doc fix.
1917
87302331
R
19182011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1919
1920 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1921
cbb59342
CY
19222011-04-08 Chong Yidong <cyd@stupidchicken.com>
1923
1924 * keyboard.c (read_char): Call Lisp function help-form-show,
1925 instead of using internal_with_output_to_temp_buffer.
1926 (Qhelp_form_show): New var.
e0d38eeb 1927 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1928
1929 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1930
1931 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1932
e67a13ab
CY
19332011-04-06 Chong Yidong <cyd@stupidchicken.com>
1934
04f2d78b
CB
1935 * process.c (Flist_processes): Remove to Lisp.
1936 (list_processes_1): Delete.
e67a13ab 1937
973f782d
EZ
19382011-04-06 Eli Zaretskii <eliz@gnu.org>
1939
7c106b1e
EZ
1940 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1941
973f782d
EZ
1942 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1943
41cf7d1a 19442011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1945
ca23cc88
PE
1946 Fix more problems found by GCC 4.6.0's static checks.
1947
f390e2d5
PE
1948 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1949
42eea0d0
PE
1950 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1951
b69769da 1952 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1953
f9541e84
PE
1954 * xdisp.c (vmessage): Mark as a printf-like function.
1955
13841b55
PE
1956 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1957
c136c10f
PE
1958 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1959
5e2d4a30
PE
1960 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1961 printf-like functions.
1962 (tiff_load): Add casts to remove these marks before passing them
1963 to system-supplied API.
1964
583f48b9
PE
1965 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1966
b25d760e
PE
1967 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1968 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1969 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1970 directly, rather than having caller test rule sign. This avoids
1971 some unnecessary tests.
1972 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1973 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1974 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1975
bc7b6697 1976 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1977 (xfont_open): Avoid unnecessary tests.
bc7b6697 1978
27ccc379
PE
1979 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1980
dcd5c89a
PE
1981 * composite.h, composite.c (composition_gstring_put_cache):
1982 Use EMACS_INT, not int, for length.
1983
b13a45c6
PE
1984 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1985 breaking out part of COMPOSITION_DECODE_RULE.
1986 (COMPOSITION_DECODE_RULE): Use it.
1987 * composite.c (get_composition_id): Remove unused local vars,
1988 by using the new macro.
1989
1e792e4d
PE
1990 * textprop.c (set_text_properties_1): Change while to do-while,
1991 since the condition is always true at first.
1992
dc6c6455 1993 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1994 (interval_deletion_adjustment): Return unsigned value.
1995 All uses changed.
dc6c6455 1996
aba7731a
PE
1997 * process.c (list_processes_1, create_pty, read_process_output):
1998 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1999 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2000 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2001 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2002 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2003
fdfc4bf3
PE
2004 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2005
fca8fe46 2006 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2007 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2008
06a0259a 2009 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2010 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2011 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2012
e7b9e80f
PE
2013 * print.c (print_error_message): Avoid int overflow.
2014
56201685
PE
2015 * font.c (font_list_entities): Redo for clarity,
2016 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2017
78834453 2018 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2019 (font_score): Avoid potential overflow in diff calculation.
78834453 2020
0bc0b309 2021 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2022 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2023
e610eaca
PE
2024 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2025
b895abce
PE
2026 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2027 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2028 can always succeed if overflow has undefined behavior.
2029
1f1d9321 2030 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2031 (wordify): Omit three unnecessary tests.
1f1d9321 2032
c59478bc
PE
2033 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2034 All callers changed. This avoids the need for an unused var.
2035
79b73827
PE
2036 * casefiddle.c (casify_region): Remove var that is set but not used.
2037
a4db5dfe
PE
2038 * dired.c (file_name_completion): Remove var that is set but not used.
2039
43aae36e
PE
2040 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2041
2a47c44d 2042 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2043 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2044
a37c69bf
PE
2045 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2046 Check for integer overflow on size calculations.
2047
328ab8e7
PE
2048 * buffer.c (Fprevious_overlay_change): Remove var that is set
2049 but not used.
2050
e5a2a5cb
PE
2051 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2052 Remove vars that are set but not used.
8d84a6eb 2053 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2054 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2055
a60e5f68
PE
2056 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2057
f661cb61 2058 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2059 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2060
f0397f5a
PE
2061 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2062 that are set but not used.
2063
8664db06 2064 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2065 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2066
6abdaa4a
PE
2067 * xselect.c (x_get_local_selection, x_handle_property_notify):
2068 Remove vars that are set but not used.
2069
0ce7538d 2070 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2071 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2072
9ae848fc
PE
2073 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2074 Remove var that is set but not used.
0b918413
PE
2075 (scroll_bar_windows_size): Now size_t, not int.
2076 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2077 Check for overflow.
9ae848fc 2078
a5a62657
PE
2079 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2080 (map_tty_color) [!defined MSDOS]: Likewise.
2081
5c5cdd39
PE
2082 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2083
66ebf983
PE
2084 * coding.c: Remove vars that are set but not used.
2085 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2086 All callers changed.
2087 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2088 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2089 (decode_coding_charset): Remove vars that are set but not used.
2090
1be4d761
PE
2091 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2092 that is set but not used.
2093
47553fa8
PE
2094 * print.c (print_object): Remove var that is set but not used.
2095
1f7196bf 2096 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2097 The gnulib version avoids calling malloc in the usual case,
2098 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2099 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2100 * filelock.c (current_lock_owner): Likewise.
2101 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2102 * sysdep.c: Include allocator.h, careadlinkat.h.
2103 (emacs_no_realloc_allocator): New static constant.
2104 (emacs_readlink): New function.
fdb61804
PE
2105 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2106 ../lib/careadlinkat.h.
d1fdcab7 2107
f84c17c7
SM
21082011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2109
2110 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2111 first non-nil return value).
2112
ef3862ad
JD
21132011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2114
2115 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2116 if not defined (Bug#8403).
2117
376a7006
JB
21182011-04-02 Juanma Barranquero <lekktu@gmail.com>
2119
2120 * xdisp.c (display_count_lines): Remove parameter `start',
2121 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2122 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2123 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2124 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2125 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2126 and thereabouts. All callers changed.
2127 (get_per_char_metric): Remove parameter `f', unused since
2128 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2129
6ca3801d
JM
21302011-04-02 Jim Meyering <meyering@redhat.com>
2131
2132 do not dereference NULL upon failed strdup
2133 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2134 (ns_get_family): Likewise.
2135
d8e2b5ba
JB
21362011-04-02 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2139
8c74fcbd
JD
21402011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2141
2142 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2143 later (Bug#8403).
2144
7200d79c
SM
21452011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2146
03408648 2147 Add lexical binding.
7200d79c 2148
03408648
SM
2149 * window.c (Ftemp_output_buffer_show): New fun.
2150 (Fsave_window_excursion):
2151 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2152
2153 * lread.c (lisp_file_lexically_bound_p): New function.
2154 (Fload): Bind Qlexical_binding.
2155 (readevalloop): Remove `evalfun' arg.
2156 Bind Qinternal_interpreter_environment.
2157 (Feval_buffer): Bind Qlexical_binding.
2158 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2159 Mark as dynamic.
2160 (syms_of_lread): Declare `lexical-binding'.
2161
2162 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2163
2164 * keyboard.c (eval_dyn): New fun.
2165 (menu_item_eval_property): Use it.
ca105506
SM
2166
2167 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2168
03408648
SM
2169 * fns.c (concat, mapcar1): Accept byte-code-functions.
2170
2171 * eval.c (Fsetq): Handle lexical vars.
2172 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2173 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2174 (FletX, Flet): Obey lexical binding.
2175 (Fcommandp): Handle closures.
2176 (Feval): New `lexical' arg.
2177 (eval_sub): New function extracted from Feval. Use it almost
2178 everywhere where Feval was used. Look up vars in lexical env.
2179 Handle closures.
2180 (Ffunctionp): Move from subr.el.
2181 (Ffuncall): Handle closures.
2182 (apply_lambda): Remove `eval_flags'.
2183 (funcall_lambda): Handle closures and new byte-code-functions.
2184 (Fspecial_variable_p): New function.
2185 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2186 but without exporting it to Lisp.
23aba0ea 2187
23aba0ea 2188 * doc.c (Fdocumentation, store_function_docstring):
03408648 2189 * data.c (Finteractive_form): Handle closures.
23aba0ea 2190
03408648
SM
2191 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2192 interactive spec.
ba83908c 2193
04f2d78b
CB
2194 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2195 New byte-codes.
03408648
SM
2196 (exec_byte_code): New function extracted from Fbyte_code to handle new
2197 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2198
03408648 2199 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2200
03408648 2201 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2202
e2abce01
JB
22032011-03-31 Juanma Barranquero <lekktu@gmail.com>
2204
2205 * xdisp.c (redisplay_internal): Fix prototype.
2206
63696a73 22072011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2208
63696a73 2209 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2210 (try_scrolling): Use it when setting scroll_limit.
2211 Limit scrolling to 100 screen lines.
63696a73
EZ
2212 (redisplay_window): Even when falling back on "recentering",
2213 position point in the window according to scroll-conservatively,
2214 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2215
2216 (try_scrolling): When point is above the window, allow searching
2217 as far as scroll_max, or one screenful, to compute vertical
2218 distance from PT to the scroll margin position. This prevents
2219 try_scrolling from unnecessarily failing when
2220 scroll-conservatively is set to a value slightly larger than the
2221 window height. Clean up the case of PT below the margin at bottom
2222 of window: scroll_max can no longer be INT_MAX. When aggressive
2223 scrolling is in use, don't let point enter the opposite scroll
2224 margin as result of the scroll.
2225 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2226 threshold of 100 lines for never-recentering scrolling.
2227
e4cc2dfc
JB
22282011-03-31 Juanma Barranquero <lekktu@gmail.com>
2229
2230 * dispextern.h (move_it_by_lines):
2231 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2232 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2233 (message_log_check_duplicate): Remove parameters `prev_bol' and
2234 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2235 (redisplay_internal): Remove parameter `preserve_echo_area',
2236 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2237
2238 * indent.c (Fvertical_motion):
2239 * window.c (window_scroll_pixel_based, Frecenter):
2240 Don't pass `need_y_p' to `move_it_by_lines'.
2241
1c470562
SM
22422011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2243
44f230aa
SM
2244 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2245 steal a few bits to be more compact.
2246 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2247 Remove unneeded casts.
2248
1c470562
SM
2249 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2250
888adce9
ZK
22512011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2252
2253 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2254 binding" message (bug#7967).
2255
f838ed7b
PE
22562011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2257
77861b95
PE
2258 Fix more problems found by GCC 4.6.0's static checks.
2259
de6dbc14
PE
2260 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2261 Remove unused local var.
2262
f838ed7b
PE
2263 * editfns.c (Fmessage_box): Remove unused local var.
2264
792c7b2b
PE
2265 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2266 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2267 Omit unused local vars.
c499e557 2268 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2269 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2270 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2271 Omit unused local var.
2272
ba0165e1
PE
2273 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2274 Don't assume string length fits in int.
32ad8845 2275 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2276 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2277
3c59b4c9
PE
2278 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2279 instead of alloca (Bug#8344).
2280
a3eed478 2281 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2282 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2283
eb4d412d
PE
2284 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2285
1658b401
PE
2286 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2287 concerns.
2288
2289 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2290
2291 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2292
9a2c6e05
PE
2293 * keyboard.c (syms_of_keyboard): Use the same style as later
2294 in this function when indexing through an array. This also
2295 works around GCC bug 48267.
2296
03d0a109
PE
2297 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2298
44f730c8
PE
2299 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2300
fe75f926
PE
2301 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2302 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2303
ffa8c828
PE
2304 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2305 This avoids undefined behavior on integer overflow, and is a bit
2306 more convenient anyway since it is compared to a size_t variable.
2307
c5101a77
PE
2308 Variadic C functions now count arguments with size_t, not int.
2309 This avoids an unnecessary limitation on 64-bit machines, which
2310 caused (substring ...) to crash on large vectors (Bug#8344).
2311 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2312 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2313 All variadic functions and their callers changed accordingly.
c5101a77
PE
2314 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2315 * data.c (arith_driver, float_arith_driver): Likewise.
2316 * editfns.c (general_insert_function): Likewise.
2317 * eval.c (struct backtrace.nargs, interactive_p)
2318 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2319 (funcall_lambda, mark_backtrace): Likewise.
2320 * fns.c (concat): Likewise.
2321 * frame.c (x_set_frame_parameters): Likewise.
2322 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2323 0 if not found, not -1. All callers changed.
2324
dd3f25f7
PE
2325 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2326 (stack_copy_size): Now size_t, not int.
2327 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2328
461c2ab9
JB
23292011-03-28 Juanma Barranquero <lekktu@gmail.com>
2330
2331 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2332 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2333 All callers changed.
2334
2335 * lisp.h (multibyte_char_to_unibyte):
2336 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2337 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2338 * character.h (CHAR_TO_BYTE8):
2339 * cmds.c (internal_self_insert):
2340 * editfns.c (general_insert_function):
2341 * keymap.c (push_key_description):
2342 * search.c (Freplace_match):
2343 * xdisp.c (message_dolog, set_message_1): All callers changed.
2344
f6d62986
SM
23452011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2346
2347 * keyboard.c (safe_run_hook_funcall): New function.
2348 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2349 don't set the hook to nil, but remove the offending function instead.
2350 (Qcommand_hook_internal): Remove, unused.
2351 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2352 Vcommand_hook_internal.
2353
2354 * eval.c (enum run_hooks_condition): Remove.
2355 (funcall_nil, funcall_not): New functions.
2356 (run_hook_with_args): Call each function through a `funcall' argument.
2357 Remove `cond' argument, now redundant.
2358 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2359 (Frun_hook_with_args_until_failure): Adjust accordingly.
2360 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2361
1db5b1ad
JB
23622011-03-28 Juanma Barranquero <lekktu@gmail.com>
2363
2364 * dispextern.h (string_buffer_position): Remove declaration.
2365
2366 * print.c (strout): Remove parameter `multibyte', unused since
2367 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2368
2369 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2370 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2371 All callers changed.
2372
2373 * w32.c (_wsa_errlist): Use braces for struct initializers.
2374
2375 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2376 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2377 All callers changed.
2378 (string_buffer_position): Likewise. Also, make static (it's never
2379 used outside xdisp.c).
2380 (cursor_row_p): Remove parameter `w', unused since
2381 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2382 (decode_mode_spec): Remove parameter `precision', introduced during
2383 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2384 All callers changed.
2385
5ffb62aa
JD
23862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2387
2388 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2389
461c2ab9 23902011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2391
2392 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2393 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2394 (ns_update_auto_hide_menu_bar): New functions.
2395 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2396 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2397 ns_constrain_all_frames.
2398 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2399 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2400
5c380ffb
JD
24012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2402
2403 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2404
9af30bdf
GM
24052011-03-27 Glenn Morris <rgm@gnu.org>
2406
2407 * syssignal.h: Replace RETSIGTYPE with void.
2408 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2409 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2410 Replace SIGTYPE with void everywhere.
2411 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2412 * s/template.h (SIGTYPE): Remove commented out definition.
2413
e2abce01
JB
24142011-03-26 Eli Zaretskii <eliz@gnu.org>
2415
2416 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2417 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2418
f868cd8a
JB
24192011-03-26 Juanma Barranquero <lekktu@gmail.com>
2420
59eb0929
JB
2421 * w32.c (read_unc_volume): Use parameter `henum', instead of
2422 global variable `wget_enum_handle'.
2423
2424 * keymap.c (describe_vector): Remove parameters `indices' and
2425 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2426 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2427
f868cd8a
JB
2428 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2429
2430 * keyboard.c (timer_check): Remove parameter `do_it_now',
2431 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2432 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2433 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2434
2435 * keyboard.c (read_char):
2436 * w32menu.c (w32_menu_display_help):
2437 * xmenu.c (show_help_event, menu_help_callback):
2438 Adjust calls to `show_help_echo'.
2439
2440 * gtkutil.c (xg_maybe_add_timer):
2441 * keyboard.c (readable_events):
2442 * process.c (wait_reading_process_output):
2443 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2444
2445 * insdel.c (adjust_markers_gap_motion):
2446 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2447 (gap_left, gap_right): Don't call it.
2448
2ecf6fdb
CY
24492011-03-25 Chong Yidong <cyd@stupidchicken.com>
2450
2451 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2452 incurred during fontification.
2453
6b1f9ba4
JB
24542011-03-25 Juanma Barranquero <lekktu@gmail.com>
2455
2456 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2457 (DEFVAR_PER_BUFFER): Don't pass it.
2458
2459 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2460 (scrolling_window): Don't pass it.
2461
0f4a96b5
JB
24622011-03-25 Juanma Barranquero <lekktu@gmail.com>
2463
2464 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2465
2466 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2467 and `suffix'.
2468 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2469 of variables specific to SELinux and computation of `encoded_absname'.
2470
2471 * image.c (XPutPixel): Remove unused variable `height'.
2472
2473 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2474
2475 * unexw32.c (get_section_info): Remove unused variable `section'.
2476
2477 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2478 (system_process_attributes): Remove unused variable `sess'.
2479 (sys_read): Remove unused variable `err'.
2480
2481 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2482 (w32_wnd_proc): Remove unused variable `isdead'.
2483 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2484 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2485 (x_create_tip_frame): Remove unused variable `tem'.
2486
2487 * w32inevt.c (w32_console_read_socket):
2488 Remove unused variable `no_events'.
2489
2490 * w32term.c (x_draw_composite_glyph_string_foreground):
2491 Remove unused variable `width'.
2492
1149507c
JB
24932011-03-24 Juanma Barranquero <lekktu@gmail.com>
2494
2495 * w32term.c (x_set_glyph_string_clipping):
2496 Don't pass uninitialized region to CombineRgn.
2497
9c88f339
JB
24982011-03-23 Juanma Barranquero <lekktu@gmail.com>
2499
2500 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2501 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2502 (Fx_close_connection): Remove unused variable `i'.
2503
2504 * w32font.c (w32font_draw): Return number of glyphs.
2505 (w32font_open_internal): Remove unused variable `i'.
2506 (w32font_driver): Add missing initializer.
2507
2508 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2509 (fill_in_menu): Remove unused variable `items_added'.
2510
2511 * w32term.c (last_mouse_press_frame): Remove static global variable.
2512 (w32_clip_to_row): Remove unused variable `f'.
2513 (x_delete_terminal): Remove unused variable `i'.
2514
2515 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2516 (NOTHING): Remove unused static global variable.
2517 (uniscribe_check_otf): Remove unused variable `table'.
2518 (uniscribe_font_driver): Add missing initializers.
2519
dee091a3
JD
25202011-03-23 Julien Danjou <julien@danjou.info>
2521
2522 * term.c (Fsuspend_tty, Fresume_tty):
2523 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2524 * window.c (temp_output_buffer_show):
2525 * insdel.c (signal_before_change):
2526 * frame.c (Fhandle_switch_frame):
2527 * fileio.c (Fdo_auto_save):
2528 * emacs.c (Fkill_emacs):
2529 * editfns.c (save_excursion_restore):
2530 * cmds.c (internal_self_insert):
2531 * callint.c (Fcall_interactively):
2532 * buffer.c (Fkill_all_local_variables):
2533 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2534 Use Frun_hooks.
0f4a96b5 2535 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2536 unconditionnaly since it does the check itself.
2537
2c520ab5 25382011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2539
c9c49752
PE
2540 Fix more problems found by GCC 4.5.2's static checks.
2541
8abc3f12
PE
2542 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2543 the first time through the loop, since we know p0 < p1 then.
2544 This also avoids a gcc -Wstrict-overflow warning.
2545
a2d26660
PE
2546 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2547 leading to a memory leak, possible in functions like
2548 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2549 of objects (Bug#8318).
a2d26660 2550
916c72e9
PE
2551 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2552 that could (at least in theory) be that large.
2553
19ab8a18
PE
2554 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2555 This is less likely to overflow, and avoids undefined behavior if
2556 overflow does occur. All callers changed. Use strtoul to scan
2557 for the unsigned long integer.
b7cbbd6f
PE
2558 (pint2hrstr): Simplify and tune code slightly.
2559 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2560
f0641eff
PE
2561 * scroll.c (do_scrolling): Work around GCC bug 48228.
2562 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2563
7f650bb9
PE
2564 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2565 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2566 (validate_x_resource_name): Simplify count usage.
2567 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2568
37dd57d1
PE
2569 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2570 fail (Bug#8306).
81e56e61 2571
699979fc 2572 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2573
401bf9b4
PE
2574 * process.c (Fmake_network_process): Use socklen_t, not int,
2575 where POSIX says socklen_t is required in portable programs.
2576 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2577 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2578 (Fmake_network_process, server_accept_connection):
2579 (wait_reading_process_output, read_process_output):
2580 Likewise.
2581
b93aacde
PE
2582 * process.c: Rename or move locals to avoid shadowing.
2583 (list_processes_1, Fmake_network_process):
2584 (read_process_output_error_handler, exec_sentinel_error_handler):
2585 Rename or move locals.
4dc343ee 2586 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2587 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2588 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2589 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2590 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2591
af8a867c 2592 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2593 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2594 Include tparam.h instead, since it declares them.
af8a867c
PE
2595 * cm.h (PC): Remove extern decl; tparam.h now does this.
2596 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2597 * terminfo.c: Include tparam.h, to check interfaces.
2598 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2599 (tparam): Adjust signature to match interface in tparam.h;
2600 this removes some undefined behavior. Check that outstring and len
2601 are zero, which they always are with Emacs.
2602 * tparam.h (PC, BC, UP): New extern decls.
2603
0248044d 2604 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2605 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2606
8ff096c1 2607 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2608 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2609 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2610 (ftfont_list): Remove unused local.
49eaafba
PE
2611 (get_adstyle_property, ftfont_pattern_entity):
2612 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2613 Rename locals to avoid shadowing.
8ff096c1 2614
e2be39f6
PE
2615 * xfont.c (xfont_list_family): Mark var as initialized.
2616
c9735e30
PE
2617 * xml.c (make_dom): Now static.
2618
8f5201ae
PE
2619 * composite.c (composition_compute_stop_pos): Rename local to
2620 avoid shadowing.
b246f932
PE
2621 (composition_reseat_it): Remove unused locals.
2622 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2623 (composition_update_it): Mark var as initialized.
11b61122
PE
2624 (find_automatic_composition): Mark vars as initialized,
2625 with a FIXME (Bug#8290).
8f5201ae 2626
760fbc2c
PE
2627 character.h: Rename locals to avoid shadowing.
2628 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2629 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2630 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2631 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2632 to avoid shadowing.
2633
ff08eb85
PE
2634 * textprop.c (property_change_between_p): Remove; unused.
2635
fc7bf025
PE
2636 * intervals.c (interval_start_pos): Now static.
2637
235d7abc
PE
2638 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2639
44f230aa
SM
2640 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2641 Rename locals to avoid shadowing.
3e7d6594 2642
50060332
PE
2643 * sound.c (wav_play, au_play, Fplay_sound_internal):
2644 Fix pointer signedness.
d01f234b 2645 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2646 (wav_play): Initialize a variable to 0, to prevent undefined
2647 behavior (Bug#8278).
50060332 2648
c4fc4e30
PE
2649 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2650
918436ed
PE
2651 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2652
c939f91b
PE
2653 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2654 clobbering (Bug#8298).
b9c7f648
PE
2655 * sysdep.c (sys_subshell): Likewise.
2656 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2657
6bd8c144
PE
2658 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2659 This should get cleaned up, so that child_setup has the
2660 same signature on all platforms.
2661
7710357c 2662 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2663 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2664
c59da222
CY
26652011-03-22 Chong Yidong <cyd@stupidchicken.com>
2666
2667 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2668 not to be necessary, and produces flickering.
2669
66b87493
GM
26702011-03-20 Glenn Morris <rgm@gnu.org>
2671
2672 * config.in: Remove file.
2673
45b6f6d5
JB
26742011-03-20 Juanma Barranquero <lekktu@gmail.com>
2675
2676 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2677 are now in src/globals.h.
2678 (syms_of_minibuf): Remove spurious & from previous change.
2679
3ec03f7e
LL
26802011-03-20 Leo <sdl.web@gmail.com>
2681
2682 * minibuf.c (completing-read-function): New variable.
2683 (completing-read-default): Rename from completing-read.
2684 (completing-read): Call completing-read-function.
2685
b14e3e21
CY
26862011-03-19 Juanma Barranquero <lekktu@gmail.com>
2687
2688 * xfaces.c (Fx_load_color_file):
2689 Read color file from absolute filename (bug#8250).
2690
f2b726e6
JB
26912011-03-19 Juanma Barranquero <lekktu@gmail.com>
2692
2693 * makefile.w32-in: Update dependencies.
2694
09f6ff02
EZ
26952011-03-17 Eli Zaretskii <eliz@gnu.org>
2696
2697 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2698
29a6015a
PE
26992011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2700
a3a6c54e
PE
2701 Fix more problems found by GCC 4.5.2's static checks.
2702
b766f867
PE
2703 * process.c (make_serial_process_unwind, send_process_trap):
2704 (sigchld_handler): Now static.
2705
be02381c
PE
2706 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2707 That way, the code declares only the vars that it needs.
2708 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2709 * s/cygwin.h (PTY_ITERATION): Likewise.
2710 * s/darwin.h (PTY_ITERATION): Likewise.
2711 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2712
57048744
PE
2713 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2714 * process.c (allocate_pty): Don't declare stb unless it's needed.
2715
7914961c 2716 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2717 (CONSTANTLIM): Remove; unused.
2718 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2719 Define only if needed.
7914961c 2720
b3967b18
PE
2721 * unexelf.c (unexec): Name an expression,
2722 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2723 Use a different way to cause a compilation error if anyone uses
2724 n rather than nn, a way that does not involve shadowing.
73366a00 2725 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2726
29a6015a
PE
2727 * deps.mk (unexalpha.o): Remove; unused.
2728
43cfc33e 2729 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2730 * unexec.h: New file.
ce701a33
PE
2731 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2732 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2733 Depend on unexec.h.
2734 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2735 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2736 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2737 Change as necessary to match prototype in unexec.h.
ce701a33 2738
01f44d5a
PE
2739 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2740 shadowing.
4f63c6bb 2741 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2742
a6670b0b
PE
2743 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2744 Rename locals to avoid shadowing.
2745
cef2010d 2746 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2747 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2748
d4d7173a
PE
2749 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2750
f08b802a
PE
2751 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2752 warning when compiling print.c.
2753
3ddb0639
PE
2754 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2755 instead of using an uninitialized var.
5ad03b97 2756 (font_sort_entities): Mark var as initialized.
3ddb0639 2757
170a2692
PE
2758 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2759
e663c700
PE
2760 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2761 pointers to constants.
89bc529a 2762 (font_parse_fcname): Remove unused vars.
7b81e2d0 2763 (font_delete_unmatched): Now static.
ea838e10 2764 (font_get_spec): Remove; unused.
13a547c6
PE
2765 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2766 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2767 Rename or move locals to avoid shadowing.
e663c700 2768
2a80c887 2769 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2770 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2771
1384fa33 2772 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2773 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2774
8b2c52e9
PE
2775 * alloc.c (mark_backtrace): Move decl from here ...
2776 * lisp.h: ... to here, so that it can be checked.
2777
475545b5 2778 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2779 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2780 (lisp_indirect_variable): Name an expression,
2781 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2782 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2783
b1349114 2784 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2785 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2786 Use const pointer when appropriate.
b1349114 2787
a2928364
PE
2788 * lisp.h (get_system_name, get_operating_system_release):
2789 Move decls here, to check interfaces.
2790 * process.c (get_operating_system_release): Move decl to lisp.h.
2791 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2792 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2793 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2794 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2795 (Fformat_time_string, Fencode_time, Finsert_char):
2796 (Ftranslate_region_internal, Fformat):
2797 Rename or remove local vars to avoid shadowing.
9710023e 2798 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2799
a415e694
PE
2800 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2801 avoid shadowing.
2802
8ef4622d
PE
2803 * lisp.h (eassert): Check that the argument compiles, even if
2804 ENABLE_CHECKING is not defined.
2805
946f9a5b
PE
2806 * data.c (Findirect_variable): Name an expression, to avoid
2807 gcc -Wbad-function-cast warning.
112396d6 2808 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2809 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2810 (Fmake_variable_buffer_local, Fmake_local_variable):
2811 Mark variables as initialized.
52746918 2812 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2813
e5aab7e7 2814 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2815 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2816 Rename locals to avoid shadowing.
dff45157
PE
2817 (mark_stack): Move local variables into the #ifdef region where
2818 they're used.
7bc26fdb
PE
2819 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2820 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2821 needed otherwise.
2822 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2823 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2824 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2825
e5aab7e7
PE
2826 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2827 avoids undefined behavior in theory.
2828
4da60324
PE
2829 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2830
88043301
PE
2831 Use functions, not macros, for up- and down-casing (Bug#8254).
2832 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2833 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2834 to use the following functions instead of these macros.
2835 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2836 EMACS_INT, since callers assume the returned value fits in int.
2837 (upcase1): Likewise, for UPCASE_TABLE.
2838 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2839 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2840 the race-condition problem in the old DOWNCASE.
88043301 2841
19ed5445
PE
2842 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2843 Rename locals to avoid shadowing.
2844 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2845 (regex_compile, re_search_2, re_match_2_internal):
2846 Remove unused local vars.
952db0d7
PE
2847 (FREE_VAR): Rewrite so as not to use empty "else",
2848 which gcc can warn about.
da053e48 2849 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2850 (RETALLOC_IF): Define only if needed.
2851 (WORDCHAR_P): Likewise. This one is never needed, but is used
2852 only in a comment talking about a compiler bug, so put inside
2853 the #if 0 of that comment.
2854 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2855 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2856 Remove; unused.
19ed5445 2857
1f3561e4 2858 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2859 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2860 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2861
ded6f8f7
PE
2862 * search.c (simple_search): Remove unused var.
2863
dbd37a95
PE
2864 * dired.c (compile_pattern): Move decl from here ...
2865 * lisp.h: ... to here, so that it can be checked.
2866 (struct re_registers): New forward decl.
2867
7e47afad
PE
2868 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2869
85f24f61
PE
2870 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2871 All uses changed.
2872 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2873 Rename locals to avoid shadowing.
5671df8f 2874 (Fvertical_motion): Mark locals as initialized.
85f24f61 2875
181aa2be 2876 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2877 (casify_region): Mark local as initialized.
181aa2be 2878
930d429c
PE
2879 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2880
7082eac6
PE
2881 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2882 New macros, so that the caller can use some names other than
2883 gcpro1, gcpro2, etc.
2884 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2885 of the new macros.
2886 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2887 argument, for consistency with GCPRO2_VAR, etc: it is now the
2888 prefix of the variable, not the variable itself. All uses
2889 changed.
38b2c076
PE
2890 * dired.c (directory_files_internal, file_name_completion):
2891 Rename locals to avoid shadowing.
2892
15206ed9
PE
2893 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2894 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2895 dired.c's scmp function, had undefined behavior.
2896 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2897 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2898 * buffer.h: ... to here, because these macros use current_buffer,
2899 and the new implementation with inline functions needs to have
2900 current_buffer in scope now, rather than later when the macros
2901 are used.
2902 (downcase, upcase1): New static inline functions.
2903 (DOWNCASE, UPCASE1): Reimplement using these functions.
2904 This avoids undefined behavior in expressions like
2905 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2906 from race conditions in accessing the global variables
2907 case_temp1 and case_temp2.
2908 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2909 * lisp.h (case_temp1, case_temp2): Remove their decls.
2910 * character.h (ASCII_CHAR_P): Move from here ...
2911 * lisp.h: ... to here, so that the inline functions mentioned
2912 above can use them.
2913
4a6bea26
PE
2914 * dired.c (directory_files_internal_unwind): Now static.
2915
f14b7e14
PE
2916 * fileio.c (file_name_as_directory, directory_file_name):
2917 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2918 Now static.
2893f146
PE
2919 (file_name_as_directory): Use const pointers when appropriate.
2920 (Fexpand_file_name): Likewise. In particular, newdir might
2921 point at constant storage, so make it a const pointer.
fd4ead52 2922 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2923 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2924 signedness issues.
f839df0c
PE
2925 (Fset_file_times, Finsert_file_contents, auto_save_error):
2926 Rename locals to avoid shadowing.
f14b7e14 2927
5716756e 2928 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2929 (Ftry_completion, Fall_completions): Rename or remove locals
2930 to avoid shadowing.
5716756e 2931
b4c3046a
PE
2932 * marker.c (bytepos_to_charpos): Remove; unused.
2933
b45db522
PE
2934 * lisp.h (verify_bytepos, count_markers): New decls,
2935 so that gcc does not warn that these functions aren't declared.
2936
85876d07
PE
2937 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2938 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2939 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2940 (copy_text): Remove unused local var.
85876d07 2941
03d78a21 2942 * filelock.c (within_one_second): Now static.
b3dd38ab 2943 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2944
5df8f01b
PE
2945 * buffer.c (fix_overlays_before): Mark locals as initialized.
2946 (fix_start_end_in_overlays): Likewise. This function should be
2947 simplified by using pointers-to-pointers, but that's a different
2948 matter.
b1d876f1 2949 (switch_to_buffer_1): Now static.
8f54f30a
PE
2950 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2951 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2952
a70072c9 2953 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2954 Fix pointer signedness issue.
edced198
PE
2955 (sys_subshell): Mark local as volatile if checking for lint,
2956 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2957 (MAXPATHLEN): Define only if needed.
a70072c9 2958
a0977c44
PE
2959 * process.c (serial_open, serial_configure): Move decls from here ...
2960 * systty.h: ... to here, so that they can be checked.
2961
a884fdcc
PE
2962 * fns.c (get_random, seed_random): Move extern decls from here ...
2963 * lisp.h: ... to here, so that they can be checked.
2964
604efe86 2965 * sysdep.c (reset_io): Now static.
b8950c94 2966 (wait_for_termination_signal): Remove; unused.
604efe86 2967
38fc62d9
PE
2968 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2969 (copy_keymap_item, append_key, push_text_char_description):
2970 Now static.
1004a21a 2971 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2972 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2973 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2974 (describe_map_tree):
2975 Rename locals to avoid shadowing.
38fc62d9 2976
2f2650da
PE
2977 * keyboard.c: Declare functions static if they are not used elsewhere.
2978 (echo_char, echo_dash, cmd_error, top_level_2):
2979 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2980 (read_char, kbd_buffer_get_event, make_lispy_position):
2981 (make_lispy_event, make_lispy_movement, apply_modifiers):
2982 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2983 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2984 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2985 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2986 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2987
a053e86c 2988 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2989 (mark_kboards): Move decl here ...
2990 * alloc.c (mark_kboards): ... from here.
a053e86c 2991
4752793e
PE
2992 * lisp.h (force_auto_save_soon): New decl.
2993
74f10ca7 2994 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2995 (DEFINE_DUMMY_FUNCTION): New macro.
2996 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2997 Use it.
c03cd23f
PE
2998 (main): Add casts to avoid warnings
2999 if GCC considers string literals to be constants.
74f10ca7 3000
022e70d4
PE
3001 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3002
59d6fe83
PE
3003 * dbusbind.c: Pointer signedness fixes.
3004 (xd_signature, xd_append_arg, xd_initialize):
3005 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3006 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3007 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3008 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3009
78320123
PE
3010 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3011 if GCC considers string literals to be constants.
49cebcca 3012 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3013
35ac2a97
SM
30142011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3015
fb103ca9
SM
3016 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3017 (print_preprocess, print_object): New macro to fix last change.
3018
35ac2a97
SM
3019 * print.c (print_preprocess): Don't forget font objects.
3020
62973b41
JB
30212011-03-16 Juanma Barranquero <lekktu@gmail.com>
3022
3023 * emacs.c (USAGE3): Doc fixes.
3024
0e48bb22
AS
30252011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3026
3027 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3028 structure.
3029
7684e57b
JB
30302011-03-14 Juanma Barranquero <lekktu@gmail.com>
3031
3032 * lisp.h (VWindow_system, Qfile_name_history):
3033 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3034 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3035 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3036
3037 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3038 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3039
3040 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3041 * w32console.c (detect_input_pending, read_input_pending)
3042 (encode_terminal_code):
3043 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3044 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3045 (w32_system_caret_y, Qfile_name_history):
3046 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3047 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3048 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3049 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3050 * w32proc.c (Qlocal, report_file_error):
3051 * w32term.c (Vwindow_system, updating_frame):
3052 * w32uniscribe.c (initialized, uniscribe_font_driver):
3053 Remove unneeded extern declarations.
3054
2aa46d6c
CY
30552011-03-14 Chong Yidong <cyd@stupidchicken.com>
3056
c96bbc66 3057 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3058
cffc6f3b
CY
30592011-03-13 Chong Yidong <cyd@stupidchicken.com>
3060
3061 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3062 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3063 These macros can no longer be used for assignment.
3064
44f230aa
SM
3065 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3066 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3067 (record_buffer_markers, fetch_buffer_markers): New functions for
3068 recording and fetching special buffer markers.
3069 (set_buffer_internal_1, set_buffer_temp): Use them.
3070
3071 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3072
3073 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3074
3075 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3076 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3077
3078 * xdisp.c (hscroll_window_tree):
3079 (reconsider_clip_changes): Use PT instead of BUF_PT.
3080
d251f04b
EZ
30812011-03-13 Eli Zaretskii <eliz@gnu.org>
3082
3083 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3084 $(EMACS_ROOT)/lib/intprops.h.
3085
f0c77cd1
PE
30862011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3087
3eca4629
PE
3088 Fix more problems found by GCC 4.5.2's static checks.
3089
7c86ee98
PE
3090 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3091 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3092 (xg_free_frame_widgets): Make it clear that a local variable is
3093 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3094 (gdk_window_get_screen): Make it clear that this macro is needed
3095 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3096 (int_gtk_range_get_value): New function, which avoids a diagnostic
3097 from gcc -Wbad-function-cast.
3098 (xg_set_toolkit_scroll_bar_thumb): Use it.
3099 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3100 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3101 (get_utf8_string, xg_get_file_with_chooser):
3102 Rename locals to avoid shadowing.
3103 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3104
41729b81
PE
3105 * xgselect.c (xg_select): Remove unused var.
3106
f0c77cd1
PE
3107 * image.c (four_corners_best): Mark locals as initialized.
3108 (gif_load): Initialize transparent_p to zero (Bug#8238).
3109 Mark another local as initialized.
ec6cf4c6 3110 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3111
ce0ad53d 3112 * image.c (clear_image_cache): Now static.
d5d5a617 3113 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3114 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3115 (x_edge_detection): Remove unnecessary cast that
3116 gcc -Wbad-function-cast diagnoses.
2037898d 3117 (gif_load): Fix pointer signedness.
6ae141d6
PE
3118 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3119 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3120
33383987 31212011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3122
d32df629
PE
3123 Improve quality of tests for time stamp overflow.
3124 For example, without this patch (encode-time 0 0 0 1 1
3125 1152921504606846976) returns the obviously-bogus value (-948597
3126 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3127 reports time overflow. See
3128 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3129 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3130 * editfns.c: Include limits.h and intprops.h.
3131 (TIME_T_MIN, TIME_T_MAX): New macros.
3132 (time_overflow): Move earlier, to before first use.
3133 (hi_time, lo_time): New functions, for an accurate test for
3134 out-of-range times.
3135 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3136 (Fget_internal_run_time): Don't assume time_t fits in int.
3137 (make_time): Use list2 instead of Fcons twice.
3138 (Fdecode_time): More accurate test for out-of-range times.
3139 (check_tm_member): New function.
3140 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3141 (lisp_time_argument): Don't rely on undefined left-shift and
3142 right-shift behavior when checking for time stamp overflow.
8be6f318 3143
fe31d94c
PE
3144 * editfns.c (time_overflow): New function, refactoring common code.
3145 (Fformat_time_string, Fdecode_time, Fencode_time):
3146 (Fcurrent_time_string): Use it.
3147
8be6f318
PE
3148 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3149 * dired.c (make_time): Move to ...
3150 * editfns.c (make_time): ... here.
3151 * systime.h: Note the move.
3152
09d9db2c 31532011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3154
126bc0dc
YM
3155 * fringe.c (update_window_fringes): Remove unused variables.
3156
c47cbdfd
YM
3157 * unexmacosx.c (copy_data_segment): Also copy __got section.
3158 (Bug#8223)
3159
7ac80be9
EZ
31602011-03-12 Eli Zaretskii <eliz@gnu.org>
3161
c96bbc66 3162 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3163 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3164 Constify `char *' arguments and their references according to
3165 prototypes in tparam.h.
3166
ecb0f94d 3167 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3168
7ac80be9
EZ
3169 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3170 Adapt all references accordingly.
3171
3172 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3173
ef1fd07e
TT
31742011-03-11 Tom Tromey <tromey@redhat.com>
3175
3176 * buffer.c (syms_of_buffer): Remove obsolete comment.
3177
7ef4b50c
EZ
31782011-03-11 Eli Zaretskii <eliz@gnu.org>
3179
3180 * termhooks.h (encode_terminal_code): Declare prototype.
3181
3182 * msdos.c (encode_terminal_code): Don't declare prototype.
3183
3184 * term.c (encode_terminal_code): Now external again, used by
3185 w32console.c and msdos.c.
3186
44f230aa
SM
3187 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3188 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3189
4b1ec863 31902011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3191
1714f52b 3192 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3193
4b1ec863
PE
3194 * fringe.c (update_window_fringes): Mark locals as initialized
3195 (Bug#8227).
3196 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3197
524c7aa6
PE
3198 * alloc.c (mark_fringe_data): Move decl from here ...
3199 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3200 to check its interface.
3201 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3202
a5c0af81 3203 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3204 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3205 (fontset_font): Mark local as initialized.
a9a06e0b 3206 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3207
b4716021
PE
3208 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3209
811e9bac 3210 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3211 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3212 (x_own_selection, Fx_disown_selection_internal): Rename locals
3213 to avoid shadowing.
3214 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3215
7e3ab302
PE
3216 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3217 so that the caller can use some name other than gcpro1.
3218 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3219 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3220 (Fx_backspace_delete_keys_p):
3221 Use them to avoid shadowing, and rename vars to avoid shadowing.
3222 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3223 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3224 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3225 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3226 Remove unused locals.
7e3ab302
PE
3227 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3228 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3229 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3230 macros.
f78faa98 3231
e2b13473
PE
3232 * xterm.h (x_mouse_leave): New decl.
3233
77f23912
PE
3234 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3235 Remove unused functions.
cdf4ba58
PE
3236 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3237 (x_calc_absolute_position): Now static.
7411c686 3238 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3239 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3240 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3241 unless they are used.
38d0b34a
PE
3242 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3243 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3244 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3245 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3246 (x_error_catcher, x_connection_closed, x_error_handler):
3247 (x_error_quitter, xembed_send_message, x_iconify_frame):
3248 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3249 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3250 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3251
44f230aa
SM
3252 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3253 Rename or move locals to avoid shadowing.
6b463e58 3254 (tty_defined_color, merge_face_heights): Now static.
5967d051 3255 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3256 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3257 does not deduce is never used uninitialized.
73719eba
PE
3258 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3259 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3260
426994c3 3261 * terminal.c (store_terminal_param): Now static.
5489860b 3262
032f1620 3263 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3264 (set_frame_menubar): Remove unused local.
d4323972 3265 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3266 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3267 since they might point to immutable storage.
281585b0
PE
3268 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3269 since it's unused otherwise.
032f1620 3270
367c19e5 3271 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3272 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3273 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3274 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3275 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3276 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3277 does not deduce are never used uninitialized.
70739cbe 3278
07b48fa9
PE
3279 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3280
8868a238 3281 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3282 * window.c (window_loop, size_window):
3283 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3284
7e5cf297 3285 * window.c (display_buffer): Now static.
d6550a9f
PE
3286 (size_window): Mark variables that gcc -Wuninitialized
3287 does not deduce are never used uninitialized.
a586633d
PE
3288 * window.h (check_all_windows): New decl, to forestall
3289 gcc -Wmissing-prototypes diagnostic.
5b555da1 3290 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3291
f6095868
PE
3292 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3293 shadowing.
3294 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3295 Include <limits.h>.
3296 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3297 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3298 (load_charset_map): Mark variables that gcc -Wuninitialized
3299 does not deduce are never used uninitialized.
53df7c11 3300 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3301
f38b440c
PE
3302 * coding.c (coding_set_source, coding_set_destination):
3303 Use "else { /* comment */ }" rather than "else /* comment */;"
3304 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3305 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3306 a block, when the outer 'i' will do.
3307 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3308 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3309 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3310 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3311 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3312 Rename locals to avoid shadowing.
3313 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3314 * coding.c (emacs_mule_char, encode_invocation_designation):
3315 Now static, since they're not used elsewhere.
413bb2db 3316 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3317 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3318 (decode_coding_emacs_mule): Mark variables that gcc
3319 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3320 (detect_coding_iso_2022): Initialize a local variable that might
3321 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3322 this initialization is needed. (Bug#8211)
5f58e762
PE
3323 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3324 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3325 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3326 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3327 Remove unused macros.
f38b440c 3328
232b38b9 3329 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3330 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3331 * character.c (string_count_byte8): Likewise.
232b38b9 3332
fb90da1b
PE
3333 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3334 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3335
fb93dbc2
PE
3336 * chartab.c (copy_sub_char_table): Now static, since it's not used
3337 elsewhere.
5c156ace
PE
3338 (sub_char_table_ref_and_range, char_table_ref_and_range):
3339 Rename locals to avoid shadowing.
bbcd0949 3340 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3341
7d3b3862 3342 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3343 (BIDI_BOB): Remove unused macro.
7d3b3862 3344
6be7d3da
PE
3345 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3346 deduce are never used uninitialized.
c2ed9c8b 3347 * term.c (encode_terminal_code): Likewise.
6be7d3da 3348
75f8807f 3349 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3350
50938595
PE
3351 * tparam.h: New file.
3352 * term.c, tparam.h: Include it.
3353 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3354 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3355 Move these decls to tparam.h, and make them agree with what
3356 is actually in tparam.c. The previous trick of using incompatible
3357 decls in different modules does not conform to the C standard.
3358 All callers of tparam changed to use tparam's actual API.
3359 * tparam.c (tparam1, tparam, tgoto):
3360 Use const pointers where appropriate.
3361
fbceeba2
PE
3362 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3363 * cm.h (struct cm): Likewise.
3364 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3365 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3366 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3367 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3368 (turn_on_face, init_tty): Likewise.
3369 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3370
7f3f1250
PE
3371 * term.c (term_mouse_position): Rename local to avoid shadowing.
3372
e6ca6543
PE
3373 * alloc.c (mark_ttys): Move decl from here ...
3374 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3375
c40f8d15
AS
33762011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3377
3378 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3379
cfe0661d
JB
33802011-03-09 Juanma Barranquero <lekktu@gmail.com>
3381
3382 * search.c (compile_pattern_1): Remove argument regp, unused since
3383 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3384 (compile_pattern): Don't pass it.
3385
0afb4571
J
33862011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3387
3388 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3389 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3390 for ! HAVE_GTK3.
3391 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3392
3393 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3394
3395 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3396 gdk_window_get_screen, gdk_window_get_geometry,
3397 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3398 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3399 (xg_get_pixbuf_from_pixmap): New function.
3400 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3401 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3402 Call xg_get_pixbuf_from_pixmap instead of
3403 gdk_pixbuf_get_from_drawable.
3404 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3405 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3406 (xg_check_special_colors): Use GtkStyleContext and its functions
3407 for HAVE_GTK3.
3408 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3409 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3410 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3411 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3412 Call gtk_widget_get_preferred_size.
0afb4571
J
3413 (xg_frame_resized): gdk_window_get_geometry only takes 5
3414 parameters.
44f230aa
SM
3415 (xg_win_to_widget, xg_event_is_for_menubar):
3416 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3417 (xg_set_widget_bg): New function.
3418 (delete_cb): New function.
895009e1 3419 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3420 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3421 (xg_set_background_color): Call xg_set_widget_bg.
3422 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3423 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3424 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3425 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3426 if ! HAVE_GTK3.
3427 (update_frame_tool_bar): Call gtk_widget_hide.
3428 (xg_initialize): Use GDK_KEY_g.
3429
3430 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3431 if ! HAVE_GTK3
3432 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3433
3434 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3435 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3436 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3437
1c2cc4ef
JB
34382011-03-08 Juanma Barranquero <lekktu@gmail.com>
3439
3440 * w32xfns.c (select_palette): Check success of RealizePalette against
3441 GDI_ERROR, not zero.
3442
33383987 3443See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3444
3445;; Local Variables:
3446;; coding: utf-8
aac0c6e3
MR
3447;; End:
3448
33383987 3449 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3450
3451 This file is part of GNU Emacs.
3452
3453 GNU Emacs is free software: you can redistribute it and/or modify
3454 it under the terms of the GNU General Public License as published by
3455 the Free Software Foundation, either version 3 of the License, or
3456 (at your option) any later version.
3457
3458 GNU Emacs is distributed in the hope that it will be useful,
3459 but WITHOUT ANY WARRANTY; without even the implied warranty of
3460 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3461 GNU General Public License for more details.
3462
3463 You should have received a copy of the GNU General Public License
3464 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.