* lisp/minibuffer.el: Add metadata method to completion tables.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
620c53a6
SM
12011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4 (read_minibuf): Use get_minibuffer.
5 (syms_of_minibuf): Use DEFSYM.
6 (Qmetadata): New var.
7 * data.c (Qbuffer): Don't make it static.
8 (syms_of_data): Use DEFSYM.
9
e003a292
PE
102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11
12 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
13 (CCL_CODE_MIN): New macro.
14
ed008a6d
PE
152011-05-30 Paul Eggert <eggert@cs.ucla.edu>
16
3687c2ef
PE
17 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
18
ed008a6d
PE
19 * eval.c (Qdebug): Now static.
20 * lisp.h (Qdebug): Remove decl. This reverts a part of the
21 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
22 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
23
d66c4c7c
CY
242011-05-29 Chong Yidong <cyd@stupidchicken.com>
25
26 * image.c: Various fixes to ImageMagick code comments.
27 (Fimagemagick_types): Doc fix.
28
5fbc2025
PE
292011-05-29 Paul Eggert <eggert@cs.ucla.edu>
30
0196f88a
PE
31 Minor fixes prompted by GCC 4.6.0 warnings.
32
33 * xselect.c (converted_selections, conversion_fail_tag): Now static.
34
5fbc2025
PE
35 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
36 (x_clipboard_manager_save_all): Move extern decl to ...
37 * xterm.h: ... here, so that it can be checked for consistency.
38
1dd3c2d9
CY
392011-05-29 Chong Yidong <cyd@stupidchicken.com>
40
41 * xselect.c (x_clipboard_manager_save_frame)
42 (x_clipboard_manager_save_all): New functions.
43 (Fx_clipboard_manager_save): Lisp function deleted.
44
45 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
46 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
47
48 * xterm.h: Update prototype.
49
5ba6571d
WX
502011-05-28 William Xu <william.xwl@gmail.com>
51
52 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
53 exiting (Bug#8239).
54
3eaff834
JM
552011-05-28 Jim Meyering <meyering@redhat.com>
56
e1900994 57 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
58 * fns.c (to_uchar): Define.
59 (crypto_hash_function): Use it to convert some newly-signed
60 variables to unsigned, to avoid sign-extension bugs. For example,
61 without this change, (md5 "truc") would evaluate to
62 45723a2aff78ff4fff7fff1114760e62 rather than the expected
63 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 64 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 65
0f6990a7
PE
662011-05-27 Paul Eggert <eggert@cs.ucla.edu>
67
68 Integer overflow fixes.
c8a9ca5a 69
08686060
PE
70 * dbusbind.c: Serial number integer overflow fixes.
71 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
72 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
73 to hold a serial number that is too large for a fixnum.
74 (Fdbus_method_return_internal, Fdbus_method_error_internal):
75 Check for serial numbers out of range. Decode any serial number
59568bf0 76 that was so large that it became a float. (Bug#8722)
08686060 77
2d1fc3c7
PE
78 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
79 (Fdbus_call_method, Fdbus_call_method_asynchronously):
80 Use XFASTINT rather than XUINT when numbers are nonnegative.
81 (xd_append_arg, Fdbus_method_return_internal):
82 (Fdbus_method_error_internal): Likewise. Also, for unsigned
83 arguments, check that Lisp number is nonnegative, rather than
59568bf0 84 silently wrapping negative numbers around. (Bug#8722)
30217ff0 85 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 86 (Bug#8722)
2d1fc3c7 87
c8a9ca5a
PE
88 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
89
519e1d69
PE
90 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
91
30569699
PE
92 ccl: add integer overflow checks
93 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
94 (IN_INT_RANGE): New macros.
95 (ccl_driver): Use them to check for integer overflow when
96 decoding a CCL program. Many of the new checks are whether XINT (x)
97 fits in int; it doesn't always, on 64-bit hosts. The new version
98 doesn't catch all possible integer overflows, but it's an
847044ea 99 improvement. (Bug#8719)
30569699 100
c11285dc
PE
101 * alloc.c (make_event_array): Use XINT, not XUINT.
102 There's no need for unsigned here.
103
fdccd48e
PE
104 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
105 This follows up to the 2011-05-06 change that substituted uintptr_t
106 for EMACS_INT. This case wasn't caught back then.
107
37910ab2
PE
108 Rework Fformat to avoid integer overflow issues.
109 * editfns.c: Include <float.h> unconditionally, as it's everywhere
110 now (part of C89). Include <verify.h>.
111 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
112 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
113 (Fformat): Avoid the prepass trying to compute sizes; it was only
114 approximate and thus did not catch overflow reliably. Instead, walk
115 through the format just once, formatting and computing sizes as we go,
116 checking for integer overflow at every step, and allocating a larger
117 buffer as needed. Keep track separately whether the format is
118 multibyte. Keep only the most-recently calculated precision, rather
119 than them all. Record whether each argument has been converted to
120 string. Use EMACS_INT, not int, for byte and char and arg counts.
121 Support field widths and precisions larger than INT_MAX. Avoid
122 sprintf's undefined behavior with conversion specifications such as %#d
123 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
124 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
125 formatting out-of-range floating point numbers with int
126 formats. (Bug#8668)
127
2e6578fb
PE
128 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
129
0ae6bdee
PE
130 * data.c: Avoid integer truncation in expressions involving floats.
131 * data.c: Include <intprops.h>.
132 (arith_driver): When there's an integer overflow in an expression
133 involving floating point, convert the integers to floating point
134 so that the resulting value does not suffer from catastrophic
135 integer truncation. For example, on a 64-bit host (* 4
136 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
137 Do not rely on undefined behavior after integer overflow.
138
de883a70
PE
139 merge count_size_as_multibyte, parse_str_to_multibyte
140 * character.c, character.h (count_size_as_multibyte):
141 Renamed from parse_str_to_multibyte; all uses changed.
142 Check for integer overflow.
143 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
144 since it's now a duplicate of the other. This is more of
145 a character than a buffer op, so better that it's in character.c.
146 * fns.c, print.c: Adjust to above changes.
147
2ff916cb
PE
1482011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
149
150 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
151
f1b54466
PE
1522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
153
fb1ac845
PE
154 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
155 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
156 (x_clipboard_manager_save): Now static.
157 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
158
f1b54466
PE
159 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
160 (crypto_hash_function): Now static.
161 Fix pointer signedness problems. Avoid unnecessary initializations.
162
a9f737ee
CY
1632011-05-27 Chong Yidong <cyd@stupidchicken.com>
164
165 * termhooks.h (Vselection_alist): Make it terminal-local.
166
167 * terminal.c (create_terminal): Initialize it.
168
169 * xselect.c: Support for clipboard managers.
170 (Vselection_alist): Move to termhooks.h as terminal-local var.
171 (LOCAL_SELECTION): New macro.
172 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
173 (symbol_to_x_atom): Remove gratuitous arg.
174 (x_handle_selection_request, lisp_data_to_selection_data)
175 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
176 (x_own_selection, x_get_local_selection, x_convert_selection):
177 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
178 (some_frame_on_display): Delete unused function.
179 (Fx_own_selection_internal, Fx_get_selection_internal)
180 (Fx_disown_selection_internal, Fx_selection_owner_p)
181 (Fx_selection_exists_p): New optional frame arg.
182 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
183 (x_handle_selection_clear): Don't treat other terminals with the
184 same keyboard specially. Use the terminal-local Vselection_alist.
185 (x_clear_frame_selections): Use Frun_hook_with_args.
186
187 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
188
189 * xterm.h: Add support for those atoms.
190
e067f0c1
CY
1912011-05-26 Chong Yidong <cyd@stupidchicken.com>
192
193 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
194 (converted_selections, conversion_fail_tag): New global variables.
195 (x_selection_request_lisp_error): Free the above.
196 (x_get_local_selection): Remove unnecessary code.
197 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
198 of converted selections stored in converted_selections.
199 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
200 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
201 (x_convert_selection): New function.
202 (x_handle_selection_event): Simplify.
203 (x_get_foreign_selection): Don't ignore incoming requests while
204 waiting for an answer; this will fail when we implement
205 SAVE_TARGETS, and seems unnecessary anyway.
206 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
207 (Vx_sent_selection_functions): Doc fix.
208
0f4aebc0
LL
2092011-05-26 Leo Liu <sdl.web@gmail.com>
210
211 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
212
e61124cd
YM
2132011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
214
215 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
216
217 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
218 for fringe update if it has periodic bitmap.
219 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
220 and fringe_bitmap_periodic_p.
221
222 * fringe.c (get_fringe_bitmap_data): New function.
223 (draw_fringe_bitmap_1, update_window_fringes): Use it.
224 (update_window_fringes): Record periodicity of fringe bitmap in glyph
225 row. Mark glyph row for fringe update if periodicity changed.
226
227 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
228 for fringe update unless it has periodic bitmap.
229
f16d9837
KH
2302011-05-25 Kenichi Handa <handa@m17n.org>
231
232 * xdisp.c (get_next_display_element): Set correct it->face_id for
233 a static composition.
234
e1b90ef6
LL
2352011-05-24 Leo Liu <sdl.web@gmail.com>
236
237 * deps.mk (fns.o):
238 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
239
240 * fns.c (crypto_hash_function, Fsha1): New function.
241 (Fmd5): Use crypto_hash_function.
242 (syms_of_fns): Add Ssha1.
243
7400048f
PE
2442011-05-22 Paul Eggert <eggert@cs.ucla.edu>
245
246 * gnutls.c: Remove unused macros.
247 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
248 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
249 Remove macros that are defined and never used.
250 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
251
abb71cf4
CY
2522011-05-22 Chong Yidong <cyd@stupidchicken.com>
253
254 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
255 (Fx_get_selection_internal): Minor cleanup.
256 (Fx_own_selection_internal): Rename arguments for consistency with
257 select.el.
258
6307db39
PE
2592011-05-22 Paul Eggert <eggert@cs.ucla.edu>
260
261 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
262
f3d4e0a4
CY
2632011-05-22 Chong Yidong <cyd@stupidchicken.com>
264
265 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
266
4d8ade89
YM
2672011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
268
269 * dispnew.c (scrolling_window): Don't exclude the case that the
270 last enabled row in the desired matrix touches the bottom boundary.
271
32078c8d
GM
2722011-05-21 Glenn Morris <rgm@gnu.org>
273
274 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
275 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
276 and add some more files.
32078c8d 277
7285dc67
EZ
2782011-05-20 Eli Zaretskii <eliz@gnu.org>
279
280 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
281 report_file_error introduced by the change from 2011-05-07.
282
89d1bd22
PE
2832011-05-20 Paul Eggert <eggert@cs.ucla.edu>
284
285 * systime.h (Time): Define only if emacs is defined.
286 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
287 where the include path doesn't have X11/X.h by default. See
288 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
289
e23640bb 2902011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
291
292 * composite.c (find_automatic_composition): Fix previous change.
293
b9704ad9
GM
2942011-05-20 Glenn Morris <rgm@gnu.org>
295
296 * lisp.mk: New file, split from Makefile.in.
297 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
298 (shortlisp): Remove.
299 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
300
4a720484
GM
3012011-05-19 Glenn Morris <rgm@gnu.org>
302
303 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
304 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
305 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
306 (lisp): Set the order to that of loadup.el.
307 (shortlisp): Make it a copy of $lisp.
308 (SOME_MACHINE_LISP): Remove.
309 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
310 Use just $shortlisp, not $SOME_MACHINE_LISP too.
311
a28d4396
KH
3122011-05-18 Kenichi Handa <handa@m17n.org>
313
314 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
315 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
316 (find_automatic_composition): Mostly rewrite for efficiency.
317
a2b1fa8e
JB
3182011-05-18 Juanma Barranquero <lekktu@gmail.com>
319
320 * makefile.w32-in: Update dependencies.
321
8e1f5610
CS
3222011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
323
324 * menu.c: Include limits.h (fixes the MS-Windows build broken by
325 revision 104625).
326
7025ee00 3272011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 328
cdfa6eab
PE
329 Fix some integer overflow issues, such as string length overflow.
330
06d6db33
PE
331 * insdel.c (count_size_as_multibyte): Check for string overflow.
332
2b4560a8
PE
333 * character.c (lisp_string_width): Check for string overflow.
334 Use EMACS_INT, not int, for string indexes and lengths; in
335 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
336 the resulting string length overflows an EMACS_INT; instead,
337 report a string overflow if no precision given. When checking for
338 precision exhaustion, use a check that cannot possibly have
339 integer overflow. (Bug#8675)
340 * character.h (lisp_string_width): Adjust to new signature.
341
cb93f9be
PE
342 * alloc.c (string_overflow): New function.
343 (Fmake_string): Use it. This doesn't change behavior, but saves
344 a few bytes and will simplify future changes.
345 * character.c (string_escape_byte8): Likewise.
346 * lisp.h (string_overflow): New decl.
347
1a1f3366
PE
348 Fixups, following up to the user-interface timestamp change.
349 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
350 for UI timestamps, instead of unsigned long.
9fbd6841
PE
351 * msdos.c (mouse_get_pos): Likewise.
352 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
353 * w32gui.h (Time): Define by including "systime.h" rather than by
354 declaring it ourselves. (Bug#8664)
355
d4e3e4d3
PE
356 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
357 * image.c (clear_image_cache): Likewise.
358
f6a24d19
PE
359 * term.c (term_mouse_position): Don't assume time_t wraparound.
360
08dc5ae6
PE
361 Be more systematic about user-interface timestamps.
362 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
363 and sometimes 'EMACS_UINT', to represent these timestamps.
364 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
365 This makes the code easier to follow, and makes it easier to catch
366 integer overflow bugs such as Bug#8664.
367 * frame.c (Fmouse_position, Fmouse_pixel_position):
368 Use Time, not unsigned long, for user-interface timestamps.
369 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
370 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
371 * keyboard.h (last_event_timestamp): Likewise.
372 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
373 * menu.h (xmenu_show): Likewise.
374 * term.c (term_mouse_position): Likewise.
375 * termhooks.h (struct input_event.timestamp): Likewise.
376 (struct terminal.mouse_position_hook): Likewise.
377 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
378 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
379 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
380 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
381 what it was before.
382 * menu.h, termhooks.h: Include "systime.h", for Time.
383
8e55734a
PE
384 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
385 Don't assume that the difference between two unsigned long values
386 can fit into an integer. At this point, we know button_down_time
387 <= event->timestamp, so the difference must be nonnegative, so
388 there's no need to cast the result if double-click-time is
389 nonnegative, as it should be; check that it's nonnegative, just in
390 case. This bug is triggered when events are more than 2**31 ms
86db42d2 391 apart (about 25 days). (Bug#8664)
8e55734a 392
841f1b75 393 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 394 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 395
3e26f69c
PE
396 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
397 that always fit in int. Use a sentinel instead of a counter, to
398 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
399 * frame.h (struct frame): Use int for menu_bar_items_used
400 instead of EMACS_INT, since it always fits in int.
3e26f69c 401
5cc152c0
PE
402 * menu.c (grow_menu_items): Check for int overflow.
403
d89eb65e
PE
404 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
405
5235bd3e
PE
406 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
407 Before, the code was not consistent. These values cannot exceed
408 2**31 - 1 so there's no need to make them unsigned.
409 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
410 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
411 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
412 as modifiers.
413 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
414
bc827e23
PE
415 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
416 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
417 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
418 presumably because the widths might not match.
419
78eb494e
PE
420 * window.c (size_window): Avoid needless test at loop start.
421
04f2d78b
CB
4222011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
423
424 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
425
d2fc7e3d 4262011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
427
428 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
429
d2fc7e3d 4302011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
431
432 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
433 `width' to `bar_area_x' and `bar_area_width', respectively.
434 (x_scroll_run): Take account of fringe background extension.
435
04f2d78b
CB
436 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
437 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
438 `bar_area_width', respectively.
439 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
440 background extension.
441
79b70037
GM
4422011-05-10 Jim Meyering <meyering@redhat.com>
443
444 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
445
2f142cc5
JB
4462011-05-10 Juanma Barranquero <lekktu@gmail.com>
447
448 * image.c (Finit_image_library): Return t for built-in image types,
449 like pbm and xbm. (Bug#8640)
450
57679c86
AS
4512011-05-09 Andreas Schwab <schwab@linux-m68k.org>
452
453 * w32menu.c (set_frame_menubar): Fix submenu allocation.
454
888c9e86
EZ
4552011-05-07 Eli Zaretskii <eliz@gnu.org>
456
b0512a1d
EZ
457 * w32console.c (Fset_screen_color): Doc fix.
458 (Fget_screen_color): New function.
459 (syms_of_ntterm): Defsubr it.
460
7285dc67
EZ
461 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
462 unlink the temporary file if Fcall_process didn't create it in the
463 first place.
464 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
465 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
466 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
467 cue to call_process_cleanup not to close that handle.
468
4d3fcc8e
BK
4692011-05-07 Ben Key <bkey76@gmail.com>
470
471 * makefile.w32-in: The bootstrap-temacs rule now makes use of
472 one of two shell specific rules, either bootstrap-temacs-CMD or
473 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
474 to the previous implementation of the bootstrap-temacs rule.
475 The bootstrap-temacs-CMD rule is similar to the previous
476 implementation of the bootstrap-temacs rule except that it
477 makes use of the ESC_CFLAGS variable instead of the CFLAGS
478 variable.
479
480 These changes, along with some changes to nt/configure.bat,
481 nt/gmake.defs, and nt/nmake.defs, are required to extend my
482 earlier fix to add support for --cflags and --ldflags options
483 that include quotes so that it works whether make uses cmd or
484 sh as the shell.
485
b4289b64
MA
4862011-05-06 Michael Albinus <michael.albinus@gmx.de>
487
488 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
489 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
490 is a constant.
491 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
492 a string. Handle both cases.
493 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
494 (Fdbus_register_method): Use Qinvalid_function.
495
af4c0e28
JB
4962011-05-06 Juanma Barranquero <lekktu@gmail.com>
497
498 * makefile.w32-in: Update dependencies.
499 (LISP_H): Add inttypes.h and stdin.h.
500 (PROCESS_H): Add unistd.h.
501
c51453d9
EZ
5022011-05-06 Eli Zaretskii <eliz@gnu.org>
503
504 * lread.c: Include limits.h (fixes the MS-Windows build broken by
505 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
506
8ff0ac3c 5072011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 508
4c4b566b
PE
509 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
510
aab2b9b5
PE
511 * term.c (vfatal): Remove stray call to va_end.
512 It's not needed and the C Standard doesn't allow it here anyway.
513
c378da0b
PE
514 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
515 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
516
288b08c7
PE
517 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
518 bytes.
519
e3601888
PE
520 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
521
db6c0e74
PE
522 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
523
dd5963ea
PE
524 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
525
88c9450f
PE
526 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
527
2f9442b8
PE
528 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
529
c032b5f8
PE
530 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
531 * charset.c (Fdefine_charset_internal): Don't initialize
532 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 533 32-bit int (Bug#8600).
a108c10b
PE
534
535 * lread.c (read_integer): Be more consistent with string-to-number.
536 Use string_to_number to do the actual conversion; this avoids
537 rounding errors and fixes some other screwups. Without this fix,
538 for example, #x1fffffffffffffff was misread as -2305843009213693952.
539 (digit_to_number): Move earlier, for benefit of read_integer.
540 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 541 not a digit in any supported base. (Bug#8602)
a108c10b 542
ad5f9eea
PE
543 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
544
aec1708a
PE
545 * dispnew.c (scrolling_window): Return 1 if we scrolled,
546 to match comment at start of function. This also removes a
547 GCC warning about overflow in a 32+64-bit port.
548
47be4ab5
PE
549 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
550
371cac43
PE
551 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
552 Reported by Stefan Monnier in
553 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
554 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
555 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 556
d01a7826
PE
557 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
558 (EMACS_UINTPTR): Likewise, with uintptr_t.
559
7fd47d5c
PE
560 * lisp.h: Prefer 64-bit EMACS_INT if available.
561 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
562 on 32-bit hosts that have 64-bit int, so that they can access
563 large files.
122b0c86
PE
564 However, temporarily disable this change unless the temporary
565 symbol WIDE_EMACS_INT is defined.
7fd47d5c 566
8727937b
PE
567 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
568
8ac068ac
PE
569 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
570 This removes an assumption that EMACS_INT and long are the same
571 width as pointers. The assumption is true for Emacs porting targets
572 now, but we want to make other targets possible.
573 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
574 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
575 In the rest of the code, change types of integers that hold casted
576 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
577 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
578 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
579 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
580 No need to cast type when ORing.
581 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
582 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
583 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
584 assume EMACS_INT is the same width as char *.
585 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
586 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
587 Remove no-longer-needed casts.
588 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
589 (xg_tool_bar_help_callback, xg_make_tool_item):
590 Use EMACS_INTPTR to hold an integer
591 that will be cast to void *; this can avoid a GCC warning
592 if EMACS_INT is not the same width as void *.
593 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
594 * xdisp.c (display_echo_area_1, resize_mini_window_1):
595 (current_message_1, set_message_1):
596 Use a local to convert to proper width without a cast.
597 * xmenu.c (dialog_selection_callback): Likewise.
598
ede49d71
PE
599 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
600 Also, don't assume VALBITS / RAND_BITS is less than 5,
601 and don't rely on undefined behavior when shifting a 1 left into
602 the sign bit.
603 * lisp.h (get_random): Change signature to match.
604
2f30ecd0
PE
605 * lread.c (hash_string): Use size_t, not int, for hash computation.
606 Normally we prefer signed values; but hashing is special, because
607 it's better to use unsigned division on hash table sizes so that
608 the remainder is nonnegative. Also, size_t is the natural width
609 for hashing into memory. The previous code used 'int', which doesn't
610 retain enough info to hash well into very large tables.
611 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
612
2a866e7b
PE
613 * dbusbind.c: Don't possibly lose pointer info when converting.
614 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
615 Use XPNTR rather than XHASH, so that the high-order bits of
616 the pointer aren't lost when converting through void *.
617
51639eac
PE
618 * eval.c (Fautoload): Don't double-shift a pointer.
619
92394119
PE
620 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
621
dbdb9a7c
JB
6222011-05-06 Juanma Barranquero <lekktu@gmail.com>
623
624 * gnutls.c (DEF_GNUTLS_FN):
625 * image.c (DEF_IMGLIB_FN): Make function pointers static.
626
db7a0b4f
AS
6272011-05-05 Andreas Schwab <schwab@linux-m68k.org>
628
629 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
630 marker. (Bug#8610)
631
f7ff1b0f 6322011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
633
634 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
635 New version that can reserve upto 2GB of heap space.
636
f7ff1b0f 6372011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
638
639 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
640
639c109b
TZ
6412011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
642
643 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
644 `gnutls_certificate_set_x509_key_file'.
645
d2127135
JB
6462011-05-05 Juanma Barranquero <lekktu@gmail.com>
647
648 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
649 Update dependencies.
650
e968f4f3
JB
6512011-05-04 Juanma Barranquero <lekktu@gmail.com>
652
653 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
654 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
655 Remove unused parameter `fildes'.
656 * process.c (read_process_output, send_process): Don't pass it.
657
84d358f0
JB
6582011-05-04 Juanma Barranquero <lekktu@gmail.com>
659
660 Fix previous change: the library cache is defined in w32.c.
661 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
662 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
663
0898ca10
JB
6642011-05-04 Juanma Barranquero <lekktu@gmail.com>
665
666 Implement dynamic loading of GnuTLS on Windows.
667
668 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
669 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
670 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
671 Declare.
672
673 * gnutls.c (Qgnutls_dll): Define.
674 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
675 (gnutls_*): Declare function pointers.
676 (init_gnutls_functions): New function to initialize function pointers.
677 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
678 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
679 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
680 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
681 (emacs_gnutls_write, emacs_gnutls_read)
682 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
683 (Fgnutls_available_p): New function.
684 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
685 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
686 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
687
688 * image.c: Include w32.h.
689 (Vimage_type_cache): Delete.
690 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
691 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
692 (w32_delayed_load): Move to w32.c.
693
694 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
695
696 * w32.c (QCloaded_from, Vlibrary_cache): Define.
697 (w32_delayed_load): Move from image.c. When loading a library, record
698 its filename in the :loaded-from property of the library id.
699 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
700 Initialize and staticpro them.
701 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
702
703 * process.c: Include lisp.h before w32.h, not after.
704 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
705 instead of gnutls_record_check_pending.
706
707 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
708
ff4de4aa
TZ
7092011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
710
711 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
712 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
713 as passed in.
714
abe95abb
JD
7152011-05-03 Jan Djärv <jan.h.d@swipnet.se>
716
717 * xterm.c (x_set_frame_alpha): Do not set property on anything
718 else than FRAME_X_OUTER_WINDOW (Bug#8608).
719
e16e55d4
JB
7202011-05-02 Juanma Barranquero <lekktu@gmail.com>
721
722 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
723
bafcf6a5
JB
7242011-05-02 Juanma Barranquero <lekktu@gmail.com>
725
726 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
727 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
728 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
729 (gnutls_global_initialized, Qgnutls_bootprop_priority)
730 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
731 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
732 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
733 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
734 (Qgnutls_bootprop_callbacks_verify): Make static.
735
e7a6747f
AS
7362011-05-01 Andreas Schwab <schwab@linux-m68k.org>
737
19ed11ba
AS
738 * callproc.c: Indentation fixup.
739
e7a6747f 740 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
741 (wait_for_termination, interruptible_wait_for_termination):
742 Move after wait_for_termination_1.
e7a6747f 743
1ef14cb4
LMI
7442011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
745
746 * sysdep.c (interruptible_wait_for_termination): New function
747 which is like wait_for_termination, but allows keyboard
748 interruptions.
749
750 * callproc.c (Fcall_process): Add (:file "file") as an option for
751 the STDOUT buffer.
752 (Fcall_process_region): Ditto.
753
330d880c
EZ
7542011-04-30 Eli Zaretskii <eliz@gnu.org>
755
8db90b73
EZ
756 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
757 rather than `XVECTOR (FOO)->size'.
758
330d880c
EZ
759 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
760 inttypes.h, as a gnulib replacement is used if it not available in
761 system headers.
762
15cbd324
EZ
7632011-04-21 Eli Zaretskii <eliz@gnu.org>
764
765 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
766 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
767 of MOST_POSITIVE_FIXNUM. (Bug#8528)
768
769 * coding.c (coding_alloc_by_realloc): Error out if destination
770 will grow beyond MOST_POSITIVE_FIXNUM.
771 (decode_coding_emacs_mule): Abort if there isn't enough place in
772 charbuf for the composition carryover bytes. Reserve an extra
773 space for up to 2 characters produced in a loop.
774 (decode_coding_iso_2022): Abort if there isn't enough place in
775 charbuf for the composition carryover bytes.
776
7772011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 778
ae940cca
EZ
779 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
780 aborting when %lld or %lll format is passed.
781 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
782 %llo or %llx format is passed. (Bug#8545)
783
03ab8921
EZ
784 * window.c (window_scroll_line_based): Use a marker instead of
785 simple variables to record original value of point. (Bug#7952)
786
afda1437
EZ
787 * doprnt.c (doprnt): Fix the case where a multibyte sequence
788 produced by %s or %c overflows available buffer space. (Bug#8545)
789
f76dee0c
PE
7902011-04-28 Paul Eggert <eggert@cs.ucla.edu>
791
792 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 793 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 794
fdc5744d
JB
7952011-04-28 Juanma Barranquero <lekktu@gmail.com>
796
797 * w32.c (init_environment): Warn about defaulting HOME to C:\.
798
638f053a
JB
7992011-04-28 Juanma Barranquero <lekktu@gmail.com>
800
801 * keyboard.c (Qdelayed_warnings_hook): Define.
802 (command_loop_1): Run `delayed-warnings-hook'
803 if Vdelayed_warnings_list is non-nil.
804 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
805 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
806
d178f871
EZ
8072011-04-28 Eli Zaretskii <eliz@gnu.org>
808
809 * doprnt.c (doprnt): Don't return value smaller than the buffer
810 size if the message was truncated. (Bug#8545).
811
b124fd93
JB
8122011-04-28 Juanma Barranquero <lekktu@gmail.com>
813
814 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
815 (Fx_window_property): #if-0 the whole functions, not just the bodies.
816
e810457d
PE
8172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
818
819 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
820
ea51cceb
JB
8212011-04-27 Juanma Barranquero <lekktu@gmail.com>
822
823 * makefile.w32-in: Update dependencies.
824
94dcfacf
EZ
8252011-04-27 Eli Zaretskii <eliz@gnu.org>
826
827 Improve `doprnt' and its usage. (Bug#8545)
828 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
829 `format_end'. Remove support for %l as a conversion specifier.
830 Don't use xrealloc. Improve diagnostics when the %l size modifier
831 is used. Update the commentary.
832
833 * eval.c (verror): Simplify calculation of size_t.
834
835 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
836 messages.
837
f61f41d7
PE
8382011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
839
840 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
841 change.
842
96fb4434
PE
8432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
844
845 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
846 This makes this file independent of the recent pseudovector change.
847
671875da 8482011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 849
69e9b5a3
PE
850 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
851
b5f869a7 852 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 853 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 854 Remove unused local.
c8926152 855 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 856
841a1577 857 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
858 GCC 4.6.0 optimizes based on type-based alias analysis.
859 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
860 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
861 != &v->size, and therefore "v->size = 1; b->size = 2; return
862 v->size;" must therefore return 1. This assumption is incorrect
863 for Emacs, since it type-puns struct Lisp_Vector * with many other
864 types. To fix this problem, this patch adds a new type struct
f904488f 865 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
866 and pseudovectors, and helps optimizing compilers not get fooled
867 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
868 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
869 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
870 the size member.
eab3844f
PE
871 (XSETPVECTYPE): Rewrite in terms of new macro.
872 (XSETPVECTYPESIZE): New macro, specifying both type and size.
873 This is a bit clearer, and further avoids the possibility of
874 undesirable aliasing.
875 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 876 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
877 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
878 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
879 (ASIZE): Now uses header.size rather than size.
880 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
881 to avoid the hassle of writing XVECTOR (foo)->header.size.
882 (struct vectorlike_header): New type.
eab3844f
PE
883 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
884 object, to help avoid aliasing.
885 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
886 (SUBRP): Likewise, since Lisp_Subr is a special case.
887 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
888 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
889 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 890 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
891 changed to be "header.size" and "header.next".
892 * buffer.h (struct buffer): Likewise.
893 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
894 * frame.h (struct frame): Likewise.
895 * process.h (struct Lisp_Process): Likewise.
896 * termhooks.h (struct terminal): Likewise.
897 * window.c (struct save_window_data, struct saved_window): Likewise.
898 * window.h (struct window): Likewise.
899 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
900 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
901 * buffer.c (init_buffer_once): Likewise.
902 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
903 special case.
904 * process.c (Fformat_network_address): Use local var for size,
905 for brevity.
906
0df1eac5
PE
907 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
908
847ab9d1 909 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
910 * data.c (atof): Remove decl; no longer used or needed.
911 (digit_to_number): Move to lread.c.
912 (Fstring_to_number): Use new string_to_number function, to be
913 consistent with how the Lisp reader treats infinities and NaNs.
914 Do not assume that floating-point numbers represent EMACS_INT
915 without losing information; this is not true on most 64-bit hosts.
916 Avoid double-rounding errors, by insisting on integers when
917 parsing non-base-10 numbers, as the documentation specifies.
918 * lisp.h (string_to_number): New decl, replacing ...
919 (isfloat_string): Remove.
bc0a5c13 920 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 921 (read1): Do not accept +. and -. as integers; this
452f4150
PE
922 appears to have been a coding error. Similarly, do not accept
923 strings like +-1e0 as floating point numbers. Do not report
924 overflow for integer overflows unless the base is not 10 which
925 means we have no simple and reliable way to continue.
926 Break out the floating-point parsing into a new
927 function string_to_number, so that Fstring_to_number parses
928 floating point numbers consistently with the Lisp reader.
04f2d78b 929 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
930 (E_CHAR, EXP_INT): Remove, replacing with ...
931 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
932 (string_to_number): New function, replacing isfloat_string.
933 This function checks for valid syntax and produces the resulting
934 Lisp float number too. Rework it so that string-to-number
bc0a5c13 935 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
936 so that overflow for non-base-10 numbers is reported only when
937 there's no portable and simple way to convert to floating point.
452f4150 938
67769ffc
PE
939 * textprop.c (set_text_properties_1): Rewrite for clarity,
940 and to avoid GCC warning about integer overflow.
941
c20db43f
PE
942 * intervals.h (struct interval): Use EMACS_INT for members
943 where EMACS_UINT might cause problems. See
944 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
945 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
946 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
947 All uses changed.
37aa2f85
PE
948 (offset_intervals): Tell GCC not to worry about length overflow
949 when negating a negative length.
c20db43f 950
2538aa2f
PE
951 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
952 (overrun_check_free): Likewise.
953
f2d3008d
PE
954 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
955 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
956 word size.
957
ec8df744
PE
958 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
959 (gnutls_make_error): Rename local to avoid shadowing.
960 (gnutls_emacs_global_deinit): ifdef out; not used.
961 (Fgnutls_boot): Use const for pointer to readonly storage.
962 Comment out unused local. Fix pointer signedness problems.
963
640ee02d
PE
964 * lread.c (openp): Don't stuff size_t into an 'int'.
965 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
966 about possible signed overflow.
967
6048fb2a
PE
968 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
969 (GDK_KEY_g): Don't define if already defined.
970 (xg_prepare_tooltip): Avoid pointer signedness problem.
971 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
972
fa3c87e1
PE
973 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
974 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
975
2172544b
PE
976 * xfns.c (Fx_window_property): Simplify a bit,
977 to make a bit faster and to avoid GCC 4.6.0 warning.
978 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
979
9b821a21
PE
980 * fns.c (internal_equal): Don't assume size_t fits in int.
981
3c616cfa
PE
982 * alloc.c (compact_small_strings): Tighten assertion a little.
983
c2982e87
PE
984 Replace pEd with more-general pI, and fix some printf arg casts.
985 * lisp.h (pI): New macro, generalizing old pEd macro to other
986 conversion specifiers. For example, use "...%"pI"d..." rather
987 than "...%"pEd"...".
988 (pEd): Remove. All uses replaced with similar uses of pI.
989 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
990 * alloc.c (check_pure_size): Don't overflow by converting size to int.
991 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
992 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
993 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
994 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
995 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
996 64-bit hosts.
997 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
998 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
999 * print.c (safe_debug_print, print_object): Likewise.
1000 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1001 to int.
6f04d126
PE
1002 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1003 avoiding the 0 flag, which is not portable.
c2982e87
PE
1004 * process.c (Fmake_network_process): Use pI to avoid cast.
1005 * region-cache.c (pp_cache): Likewise.
1006 * xdisp.c (decode_mode_spec): Likewise.
1007 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1008 behavior on 64-bit hosts with printf arg.
6f04d126 1009 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1010 (x_stop_queuing_selection_requests): Likewise.
1011 (x_get_window_property): Don't truncate byte count to an 'int'
1012 when tracing.
0b432f21 1013
5e073ec7
PE
1014 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1015 here, since it parses constructs like leading '-' and spaces,
1016 which are not wanted; and it overflows with large numbers.
1017 Instead, simply match F[0-9]+, which is what is wanted anyway.
1018
36372bf9
PE
1019 * alloc.c: Remove unportable assumptions about struct layout.
1020 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1021 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1022 (allocate_vectorlike, make_pure_vector): Use the new macros,
1023 plus offsetof, to remove unportable assumptions about struct layout.
1024 These assumptions hold on all porting targets that I know of, but
1025 they are not guaranteed, they're easy to remove, and removing them
1026 makes further changes easier.
1027
0b432f21
PE
1028 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1029 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1030 (string_overrun_cookie): Now const. Use initializers that
1031 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1032 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1033 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1034 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1035 multiple of sizeof (EMACS_INT); it need not be, if
1036 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1037 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1038
895009e1
JB
10392011-04-26 Juanma Barranquero <lekktu@gmail.com>
1040
1041 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1042
6a7a1b0b
TZ
10432011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1044
1045 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1046 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1047 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1048
841a1577 10492011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1050
1051 * lisp.h (Qdebug): List symbol.
895009e1 1052 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1053 * keyboard.c (debug-on-event): New variable.
1054 (handle_user_signal): Break into debugger when debug-on-event
1055 matches the current signal symbol.
1056
f2d3ba6f
DN
10572011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1058
1059 * alloc.c (check_sblock, check_string_bytes)
1060 (check_string_free_list): Convert to standard C.
1061
42ce4c63
TZ
10622011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1063
1064 * w32.c (emacs_gnutls_push): Fix typo.
1065
825cd63c
EZ
10662011-04-25 Eli Zaretskii <eliz@gnu.org>
1067
fb11d64d
EZ
1068 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1069 "cast to pointer from integer of different size".
1070
825cd63c
EZ
1071 Improve doprnt and its use in verror. (Bug#8545)
1072 * doprnt.c (doprnt): Document the set of format control sequences
1073 supported by the function. Use SAFE_ALLOCA instead of always
1074 using `alloca'.
1075
1076 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1077 is one byte too soon. Don't use xrealloc; instead xfree and
1078 xmalloc anew.
1079
e061a11b
TZ
10802011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1081
1082 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1083 callbacks stage.
1084
1085 * gnutls.c: Renamed global_initialized to
1086 gnutls_global_initialized. Added internals for the
1087 :verify-hostname-error, :verify-error, and :verify-flags
1088 parameters of `gnutls-boot' and documented those parameters in the
1089 docstring. Start callback support.
1090 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1091 unless a fatal error occured. Call gnutls_alert_send_appropriate
1092 on error. Return error code.
1093 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1094 (emacs_gnutls_read): Likewise.
1095 (Fgnutls_boot): Return handshake error code.
1096 (emacs_gnutls_handle_error): New function.
1097 (wsaerror_to_errno): Likewise.
1098
1099 * w32.h (emacs_gnutls_pull): Add prototype.
1100 (emacs_gnutls_push): Likewise.
1101
1102 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1103 (emacs_gnutls_push): Likewise.
1104
11052011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1106
1107 * process.c (wait_reading_process_output): Check if GnuTLS
1108 buffered some data internally if no FDs are set for TLS
1109 connections.
1110
1111 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1112 (LIBS): Link to USER_LIBS.
1113 ($(BLD)/gnutls.$(0)): New target.
1114
fa6996bc
EZ
11152011-04-24 Eli Zaretskii <eliz@gnu.org>
1116
eb35682e
EZ
1117 * xdisp.c (handle_single_display_spec): Rename the
1118 display_replaced_before_p argument into display_replaced_p, to
1119 make it consistent with the commentary. Fix typos in the
1120 commentary.
1121
e2ad650c
EZ
1122 * textprop.c (syms_of_textprop): Remove dead code.
1123 (copy_text_properties): Delete obsolete commentary about an
1124 interface that was deleted long ago. Fix typos in the description
1125 of arguments.
1126
1b2de274
EZ
1127 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1128 to changes in oldXMenu/XMenu.h from 2011-04-16.
1129 <menu_help_message, prev_menu_help_message>: Constify.
1130 (IT_menu_make_room): menu->help_text is now `const char **';
1131 adjust.
1132
1133 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1134 to changes in oldXMenu/XMenu.h from 2011-04-16.
1135 (struct XMenu): Declare `help_text' `const char **'.
1136
1137 * xfaces.c <Qunspecified>: Make extern again.
1138
1139 * syntax.c: Include sys/types.h before including regex.h, as
1140 required by Posix.
1141
762b15be
EZ
1142 * doc.c (get_doc_string): Improve the format passed to `error'.
1143
1144 * doprnt.c (doprnt): Improve commentary.
1145
1146 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1147
1148 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1149 them with etags.
1150
f1052e5d
EZ
1151 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1152 changes in globals.h immediately force recompilation.
762b15be
EZ
1153 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1154 $(CURDIR)/s/ms-w32.h.
1155 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1156
fa6996bc
EZ
1157 * character.c (Fchar_direction): Function deleted.
1158 (syms_of_character): Don't defsubr it.
1159 <char-direction-table>: Deleted.
1160
e6c3da20
EZ
11612011-04-23 Eli Zaretskii <eliz@gnu.org>
1162
1163 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1164 * doprnt.c: Include limits.h.
1165 (SIZE_MAX): New macro.
04f2d78b
CB
1166 (doprnt): Return a size_t value. 2nd arg is now size_t.
1167 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1168 Improve overflow protection. Support `l' modifier for integer
1169 conversions. Support %l conversion. Don't assume an EMACS_INT
1170 argument for integer conversions and for %c.
1171
1172 * lisp.h (doprnt): Restore prototype.
1173
1174 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1175 $(SRC)/character.h.
1176
1177 * Makefile.in (base_obj): Add back doprnt.o.
1178
1179 * deps.mk (doprnt.o): Add back prerequisites.
1180 (callint.o): Depend on character.h.
1181
1182 * eval.c (internal_lisp_condition_case): Include the handler
1183 representation in the error message.
1184 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1185 when breaking from the loop.
1186
1187 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1188
1189 * callint.c (Fcall_interactively): When displaying error message
1190 about invalid control letter, pass the character's codepoint, not
1191 a pointer to its multibyte form. Improve display of the character
1192 in octal and display also its hex code.
1193
1194 * character.c (char_string): Use %x to display the (unsigned)
1195 codepoint of an invalid character, to avoid displaying a bogus
1196 negative value.
1197
1198 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1199 `error', not SYMBOL_NAME itself.
1200
1201 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1202 character arguments to `error'.
1203
1204 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1205 to `error' in error message about FINAL_CHAR argument. Make sure
1206 FINAL_CHAR is a character, and use %c when it is passed as
1207 argument to `error'.
1208
4ffd0d6b 12092011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1210
1211 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1212
1213 * w32.c: Include <time.h>.
1214 (sys_localtime): New function.
1215
4ffd0d6b 12162011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1217
1218 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1219
4ffd0d6b 1220 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1221
4ffd0d6b 12222011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1223
4ffd0d6b
GM
1224 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1225 zombies (Bug#8467).
aac0c6e3 1226
04c56954
EZ
12272011-04-19 Eli Zaretskii <eliz@gnu.org>
1228
1229 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1230 gl_state.e_property when gl_state.object is Qt.
1231
1232 * insdel.c (make_gap_larger): Remove limitation of buffer size
1233 to <= INT_MAX.
1234
16a43933
CY
12352011-04-18 Chong Yidong <cyd@stupidchicken.com>
1236
1237 * xdisp.c (lookup_glyphless_char_display)
1238 (produce_glyphless_glyph): Handle cons cell entry in
1239 glyphless-char-display.
1240 (Vglyphless_char_display): Document it.
1241
1242 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1243 glyphless-char-display.
1244
4581706e
CY
12452011-04-17 Chong Yidong <cyd@stupidchicken.com>
1246
1247 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1248
1249 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1250
1251 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1252 definition for no-X builds.
1253
4887c6e2 12542011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1255
fd35b6f9
PE
1256 Static checks with GCC 4.6.0 and non-default toolkits.
1257
5c1ccb01
PE
1258 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1259
006c5daa
PE
1260 * process.c (keyboard_bit_set): Define only if SIGIO.
1261 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1262 (send_process): Repair possible setjmp clobbering.
1263
efc736d3
PE
1264 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1265
4e2fe2e6
PE
1266 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1267
f97334a2
PE
1268 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1269
4e75f29d
PE
1270 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1271 Define only if needed.
1272
90efadd1
PE
1273 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1274 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1275 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1276
3c647824
PE
1277 * dispextern.h (struct redisplay_interface): Rename param
1278 to avoid shadowing.
e264f262 1279 * termhooks.h (struct terminal): Likewise.
761383f4 1280 * xterm.c (xembed_send_message): Likewise.
3c647824 1281
b58c5c4a
PE
1282 * insdel.c (make_gap_smaller): Define only if
1283 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1284
cad59032
PE
1285 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1286 it.
1287
c339dc2e
PE
1288 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1289 so that we aren't warned about unused symbols.
1290
91a3e27b
PE
1291 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1292
399c71d3 1293 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1294
8ffc96f5
PE
1295 * xfns.c (x_real_positions): Mark locals as initialized.
1296
eef9bc79
PE
1297 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1298
098db9dd
PE
1299 * xterm.c: Fix problems found by static analysis with other toolkits.
1300 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1301 (x_dispatch_event): Declare static if USE_GTK, and
1302 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1303 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1304 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1305 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1306 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1307
eb18f6cc
PE
1308 * xmenu.c (menu_help_callback): Pointer type fixes.
1309 Use const pointers when pointing at readonly data. Avoid pointer
1310 signedness clashes.
1311 (FALSE): Remove unused macro.
1312 (update_frame_menubar): Remove unused decl.
1313
1fe72bf8
PE
1314 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1315
60d9e1db
PE
1316 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1317 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1318 (single_menu_item): Rename local to avoid shadowing.
1319
39261c26
PE
1320 * keyboard.c (make_lispy_event): Remove unused local var.
1321
018c5e19
PE
1322 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1323 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1324
63d2b86e
PE
1325 * bitmaps: Change bitmaps from unsigned char back to the X11
1326 compatible char. Avoid the old compiler warnings about
1327 out-of-range initializers by using, for example, '\xab' rather
1328 than 0xab.
1329
aefd87e1
PE
1330 * xgselect.c (xgselect_initialize): Check vs interface
1331 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1332
bf501fb9
PE
1333 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1334
e9829fdf
PE
1335 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1336 to read-only memory.
1337
1086c095
PE
1338 * fns.c (vector): Remove; this old hack is no longer needed.
1339
2baccd04 1340 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1341 Remove unused var.
dde42981 1342 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1343
72391843 1344 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1345
436c16df 1346 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1347 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1348 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1349
92bb796d 1350 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1351 (x_term_init): Remove local to avoid shadowing.
92bb796d 1352
764430a3 1353 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1354
1355 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1356 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1357
d1dfb56c
EZ
13582011-04-16 Eli Zaretskii <eliz@gnu.org>
1359
c4354cb4
EZ
1360 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1361
d1dfb56c
EZ
1362 Fix regex.c, syntax.c and friends for buffers > 2GB.
1363 * syntax.h (struct gl_state_s): Declare character position members
1364 EMACS_INT.
1365
1366 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1367
04f2d78b
CB
1368 * textprop.c (verify_interval_modification, interval_of):
1369 Declare arguments EMACS_INT.
d1dfb56c
EZ
1370
1371 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1372 EMACS_INT.
1373
1374 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1375
1376 * indent.c (Fvertical_motion): Local variable it_start is now
1377 EMACS_INT.
1378
1379 * regex.c (re_match, re_match_2, re_match_2_internal)
1380 (bcmp_translate, regcomp, regexec, print_double_string)
1381 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1382 (re_compile_pattern, re_exec): Declare arguments and local
1383 variables `size_t' and `ssize_t' and return values `regoff_t', as
1384 appropriate.
1385 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1386 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1387 <compile_stack_type>: `size' and `avail' are now `size_t'.
1388
1389 * regex.h <regoff_t>: Use ssize_t, not int.
1390 (re_search, re_search_2, re_match, re_match_2): Arguments that
1391 specify buffer/string position and length are now ssize_t and
1392 size_t. Return type is regoff_t.
1393
613052cd
BK
13942011-04-16 Ben Key <bkey76@gmail.com>
1395
1396 * nsfont.m: Fixed bugs in ns_get_family and
1397 ns_descriptor_to_entity that were caused by using free to
1398 deallocate memory blocks that were allocated by xmalloc (via
1399 xstrdup). This caused Emacs to crash when compiled with
1400 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1401 --enable-checking=xmallocoverrun). xfree is now used to
1402 deallocate these memory blocks.
1403
4170f62f 14042011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1405
71b41406
PE
1406 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1407
9587a89d
PE
1408 emacs_write: Accept and return EMACS_INT for sizes.
1409 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1410 et seq.
1411 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1412 Accept and return EMACS_INT.
1413 (emacs_gnutls_write): Return the number of bytes written on
1414 partial writes.
1415 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1416 (emacs_read, emacs_write): Remove check for negative size, as the
1417 Emacs source code has been audited now.
9587a89d
PE
1418 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1419 (emacs_read, emacs_write): Use it.
273a5f82
PE
1420 * process.c (send_process): Adjust to the new signatures of
1421 emacs_write and emacs_gnutls_write. Do not attempt to store
1422 a byte offset into an 'int'; it might overflow.
9587a89d 1423 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1424
3e047f51
PE
1425 * sound.c: Don't assume sizes fit in 'int'.
1426 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1427 Return EMACS_INT, not int.
3e047f51 1428 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1429 Accept EMACS_INT, not int.
1430 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1431 record read return values.
1432
cc39a9db
BK
14332011-04-15 Ben Key <bkey76@gmail.com>
1434
c9d0ec6d
JB
1435 * keyboard.c (Qundefined): Don't declare static since it is used
1436 in nsfns.m.
1437 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1438 static since they are used in nsfont.m.
cc39a9db 1439
6c60eb9f
SM
14402011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1441
1442 * process.c (Qprocessp): Don't declare static.
1443 * lisp.h (Qprocessp): Declare again.
1444
7990b61a
JB
14452011-04-15 Juanma Barranquero <lekktu@gmail.com>
1446
1447 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1448
5d4cb038
PE
14492011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1450
8bd7b830 1451 Improve C-level modularity by making more things 'static'.
cd64ea1d 1452
e3b27b31
PE
1453 Don't publish debugger-only interfaces to other modules.
1454 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1455 (verify_bytepos, count_markers): Move decls to the only modules
1456 that need them.
1457 * region-cache.h (pp_cache): Likewise.
1458 * window.h (check_all_windows): Likewise.
1459 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1460
5d4cb038
PE
1461 * sysdep.c (croak): Now static, if
1462 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1463 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1464
1465 * alloc.c (refill_memory_reserve): Now static if
1466 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1467 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1468
e87b6180
PE
1469 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1470 Define only if USE_LUCID.
1471
ac64929e
PE
1472 * xrdb.c (x_customization_string, x_rm_string): Now static.
1473
6f37259d
PE
1474 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1475 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1476
1683e3ab
PE
1477 * xdisp.c (draw_row_with_mouse_face): Now static.
1478 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1479
de9c2632
PE
1480 * window.h (check_all_windows): Mark externally visible.
1481
2b96acb7
PE
1482 * window.c (window_deletion_count): Now static.
1483
1484 * undo.c: Make symbols static if they're not exported.
1485 (last_undo_buffer, last_boundary_position, pending_boundary):
1486 Now static.
1487
50436f33
PE
1488 * textprop.c (interval_insert_behind_hooks): Now static.
1489 (interval_insert_in_front_hooks): Likewise.
1490
64520e5c
PE
1491 * term.c: Make symbols static if they're not exported.
1492 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1493 (max_frame_lines, tty_set_terminal_modes):
1494 (tty_reset_terminal_modes, tty_turn_off_highlight):
1495 (get_tty_terminal): Now static.
1496 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1497 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1498 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1499 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1500 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1501
1fa53021
PE
1502 * sysdep.c: Make symbols static if they're not exported.
1503 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1504 Now static.
1505 (sigprocmask_set, full_mask): Remove; unused.
1506 (wait_debugging): Mark as visible.
1507 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1508 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1509
d4b43b22
PE
1510 * syntax.c (syntax_temp): Define only if !__GNUC__.
1511
b7c513d0
PE
1512 * sound.c (current_sound_device, current_sound): Now static.
1513
989b29ad
PE
1514 * search.c (searchbufs, searchbuf_head): Now static.
1515
13a55a78
PE
1516 * scroll.c (scroll_cost): Remove; unused.
1517 * dispextern.h (scroll_cost): Remove decl.
1518
de68a1fc
PE
1519 * region-cache.h (pp_cache): Mark as externally visible.
1520
40ccffa6
PE
1521 * process.c: Make symbols static if they're not exported.
1522 (process_tick, update_tick, create_process, chan_process):
1523 (Vprocess_alist, proc_buffered_char, datagram_access):
1524 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1525 (deactivate_process): Mark defn as static, as well as decl.
1526 * lisp.h (create_process): Remove decl.
1527 * process.h (chan_process, Vprocess_alist): Remove decls.
1528
ad64fc97
PE
1529 * print.c: Make symbols static if they're not exported.
1530 (print_depth, new_backquote_output, being_printed, print_buffer):
1531 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1532 (print_interval, print_number_index, initial_stderr_stream):
1533 Now static.
1534 * lisp.h (Fprinc): Remove decl.
1535 (debug_output_compilation_hack): Mark as externally visible.
1536
adddb265
PE
1537 * sysdep.c (croak): Move decl from here to syssignal.h.
1538 * syssignal.h (croak): Put it here, so the API can be checked when
1539 'croak' is called from dissociate_if_controlling_tty.
1540
1717ede2
PE
1541 * minibuf.c: Make symbols static if they're not exported.
1542 (minibuf_save_list, choose_minibuf_frame): Now static.
1543 * lisp.h (choose_minibuf_frame): Remove decl.
1544
fa5fb2bc
PE
1545 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1546
1e3890d1
PE
1547 * lread.c: Make symbols static if they're not exported.
1548 (read_objects, initial_obarray, oblookup_last_bucket_number):
1549 Now static.
1550 (make_symbol): Remove; unused.
1551 * lisp.h (initial_obarray, make_symbol): Remove decls.
1552
8a1414fa
PE
1553 * keyboard.c: Make symbols static if they're not exported.
1554 (single_kboard, recent_keys_index, total_keys, recent_keys):
1555 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1556 (this_single_command_key_start, echoing, last_auto_save):
1557 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1558 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1559 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1560 (Vlispy_mouse_stem, double_click_count):
1561 Now static.
1562 (force_auto_save_soon): Define only if SIGDANGER.
1563 (ignore_mouse_drag_p): Now static if
1564 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1565 (print_help): Remove; unused.
1566 (stop_character, last_timer_event): Mark as externally visible.
1567 * keyboard.h (ignore_mouse_drag_p): Declare only if
1568 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1569 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1570 * lisp.h (echoing): Remove decl.
1571 (force_auto_save_soon): Declare only if SIGDANGER.
1572 * xdisp.c (redisplay_window): Simplify code, to make it more
1573 obvious that ignore_mouse_drag_p is not accessed if !defined
1574 USE_GTK && !defined HAVE_NS.
1575
93ea6e8f
PE
1576 * intervals.c: Make symbols static if they're not exported.
1577 (merge_properties_sticky, merge_interval_right, delete_interval):
1578 Now static.
1579 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1580
77382fcc
PE
1581 * insdel.c: Make symbols static if they're not exported.
1582 However, leave prepare_to_modify_buffer alone. It's never
1583 called from outside this function, but that appears to be a bug.
1584 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1585 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1586 (adjust_after_replace_noundo): Remove; unused.
1587 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1588 (signal_before_change): Remove decls.
77382fcc 1589
9306c32e
PE
1590 * indent.c (val_compute_motion, val_vmotion): Now static.
1591
cd44d2eb
PE
1592 * image.c: Make symbols static if they're not exported.
1593 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1594 if USE_GTK.
1595 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1596 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1597
ad9a7a06
PE
1598 * fringe.c (standard_bitmaps): Now static.
1599 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1600
81626931
PE
1601 * frame.c: Make symbols static if they're not exported.
1602 (x_report_frame_params, make_terminal_frame): Now static.
1603 (get_frame_param): Now static, unless HAVE_NS.
1604 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1605 (x_get_resource_string): Remove; not used.
1606 * frame.h (make_terminal_frame, x_report_frame_params):
1607 (x_get_resource_string); Remove decls.
1608 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1609 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1610
239f9db9
PE
1611 * font.c, fontset.c: Make symbols static if they're not exported.
1612 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1613 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1614 * font.c (font_close_object): Now static.
1615 * font.h (font_close_object): Remove.
1616 * fontset.c (FONTSET_OBJLIST): Remove.
1617 (free_realized_fontset) #if-0 the body, which does nothing.
1618 (face_suitable_for_char_p): #if-0, as it's never called.
1619 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1620 * xfaces.c (face_at_string_position):
1621 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1622 since 0 is always ASCII.
1623
dfcf3579
PE
1624 * fns.c (weak_hash_tables): Now static.
1625
5045092b
PE
1626 * fileio.c: Make symbols static if they're not exported.
1627 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1628 (Vwrite_region_annotation_buffers): Now static.
1629
57a96f5c
PE
1630 * eval.c: Make symbols static if they're not exported.
1631 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1632 * lisp.h (backtrace_list): Remove decl.
1633
35f08c38
PE
1634 * emacs.c: Make symbols static if they're not exported.
1635 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1636 (fatal_error_code, fatal_error_signal_hook, standard_args):
1637 Now static.
1638 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1639 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1640 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1641 * lisp.h (fatal_error_signal_hook): Remove decl.
1642 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1643
f44bd759
PE
1644 * editfns.c: Move a (normally-unused) function to its only use.
1645 * editfns.c, lisp.h (get_operating_system_release): Remove.
1646 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1647 worth the hassle of breaking this out.
1648
b532497d
PE
1649 * xterm.c: Make symbols static if they're not exported.
1650 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1651 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1652 (x_destroy_window, x_delete_display):
1653 Now static.
1654 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1655 (x_mouse_leave): Remove; unused.
1656 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1657 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1658 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1659 Remove decls.
1660 (x_mouse_leave): Declare only if WINDOWSNT.
1661 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1662 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1663 USE_X_TOOLKIT.
1664
1675728f
PE
1665 * ftxfont.c: Make symbols static if they're not exported.
1666 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1667 HAVE_FREETYPE.
1668 * font.h (ftxfont_driver): Likewise.
1669
e4cebfca
PE
1670 * xfns.c: Make symbols static if they're not exported.
1671 (x_last_font_name, x_display_info_for_name):
1672 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1673 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1674 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1675 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1676 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1677 (last_show_tip_args): Now static.
1678 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1679 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1680 (x_screen_planes): Remove; unused.
1681 * dispextern.h (x_screen_planes): Remove decl.
1682
5bf46f05
PE
1683 * dispnew.c: Make symbols static if they're not exported.
1684 * dispextern.h (redraw_garbaged_frames, scrolling):
1685 (increment_row_positions): Remove.
1686 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1687 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1688 Now static.
1689 (redraw_garbaged_frames): Remove; unused.
1690
435f4c28
PE
1691 * xfaces.c: Make symbols static if they're not exported.
1692 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1693 Remove decls.
1694 * xterm.h (defined_color): Remove decls.
1695 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1696 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1697 (menu_face_changed_default, defined_color, free_realized_face):
1698 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1699 (ascii_face_of_lisp_face): Remove; unused.
1700
8524aef3
PE
1701 * xdisp.c: Make symbols static if they're not exported.
1702 * dispextern.h (scratch_glyph_row, window_box_edges):
1703 (glyph_to_pixel_coords, set_cursor_from_row):
1704 (get_next_display_element, set_iterator_to_next):
1705 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1706 (show_mouse_face): Remove decls
1707 * frame.h (message_buf_print): Likewise.
1708 * lisp.h (pop_message, set_message, check_point_in_composition):
1709 Likewise.
1710 * xterm.h (set_vertical_scroll_bar): Likewise.
1711 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1712 (message_buf_print, scratch_glyph_row, displayed_buffer):
1713 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1714 (get_next_display_element, show_mouse_face, window_box_edges):
1715 (frame_to_window_pixel_xy, check_point_in_composition):
1716 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1717 (glyph_to_pixel_coords): Remove; unused.
1718
16390cd2
PE
1719 * dired.c (file_name_completion): Now static.
1720
1721 * dbusbind.c (xd_in_read_queued_messages): Now static.
1722
a25f4dfa
PE
1723 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1724 * data.c (circular_list_error): Remove.
1725
14a9c8df
PE
1726 * commands.h (last_point_position, last_point_position_buffer):
1727 (last_point_position_window): Remove decls.
1728 * keyboard.c: Make these variables static.
1729
04f2d78b
CB
1730 * coding.h (coding, code_convert_region, encode_coding_gap):
1731 Remove decls.
74ab6df5
PE
1732 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1733 (iso_code_class, detect_coding, code_convert_region): Now static.
1734 (encode_coding_gap): Remove; unused.
1735
38dfbee1
PE
1736 * chartab.c (chartab_chars, chartab_bits): Now static.
1737
a2cb4e63
PE
1738 * charset.h (charset_iso_8859_1): Remove decl.
1739 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1740 Now static.
1741
127198fd
PE
1742 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1743 * ccl.c (Vccl_program_table): Now static.
1744 (check_ccl_update): Remove; unused.
1745
d85b608f
PE
1746 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1747 * category.h: ... from here.
1748 * category.c (check_category_table, set_category_set): Now static.
1749
31cd66f3
PE
1750 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1751 * lisp.h: Remove these decls.
1752
c358e587
PE
1753 * buffer.c (buffer_count): Remove unused var.
1754
e78aecca
PE
1755 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1756 so that it's not optimized away.
1757 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1758 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1759 exported only to the debugger.
1760
e192d7d3 1761 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1762 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1763
92470028
PE
1764 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1765 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1766 was inaccessible from Lisp.
1767 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1768 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1769
244ed907
PE
1770 alloc.c: Import and export fewer symbols, and remove unused items.
1771 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1772 is defined.
1773 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1774 it's not optimized away by whole-program optimization.
1775 (message_enable_multibyte, free_misc): Remove.
1776 (catchlist, handlerlist, mark_backtrace):
1777 Declare only if BYTE_MARK_STACK.
1778 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1779 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1780 (message_enable_multibyte): Remove decl.
1781 (free_misc, interval_free_list, float_block, float_block_index):
1782 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1783 (cons_free_list, last_marked_index):
1784 Now static.
1785 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1786 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1787 (mark_backtrace): Define only if BYTE_MARK_STACK.
1788 * xdisp.c (message_enable_multibyte): Now static.
1789
61c2b50e 1790 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1791 This makes it easier for human readers (and static analyzers)
1792 to see whether these variables are used from other modules.
1793 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1794 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1795 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1796 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1797 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1798 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1799 * xmenu.c, xselect.c:
1800 Declare Q* vars static if they are not used in other modules.
1801 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1802 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1803 Remove decls of unexported vars.
1804 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1805
95c82688
PE
1806 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1807
16a97296
PE
1808 Make Emacs functions such as Fatom 'static' by default.
1809 This makes it easier for human readers (and static analyzers)
1810 to see whether these functions can be called from other modules.
1811 DEFUN now defines a static function. To make the function external
1812 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1813 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1814 (Finit_image_library):
16a97296
PE
1815 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1816 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1817 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1818 Remove decls, since these functions are now static.
1819 (Funintern, Fget_internal_run_time): New decls, since these functions
1820 were already external.
95c82688 1821
16a97296
PE
1822 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1823 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1824 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1825 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1826 * keyboard.c, keymap.c, lread.c:
1827 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1828 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1829 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1830 Mark functions with DEFUE instead of DEFUN,
1831 if they are used in other modules.
1832 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1833 decls for now-static functions.
1834 * buffer.h (Fdelete_overlay): Remove decl.
1835 * callproc.c (Fgetenv_internal): Mark as internal.
1836 * composite.c (Fremove_list_of_text_properties): Remove decl.
1837 (Fcomposition_get_gstring): New forward static decl.
1838 * composite.h (Fcomposite_get_gstring): Remove decl.
1839 * dired.c (Ffile_attributes): New forward static decl.
1840 * doc.c (Fdocumntation_property): New forward static decl.
1841 * eval.c (Ffetch_bytecode): New forward static decl.
1842 (Funintern): Remove extern decl; now in .h file where it belongs.
1843 * fileio.c (Fmake_symbolic_link): New forward static decl.
1844 * image.c (Finit_image_library): New forward static decl.
1845 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1846 * intervals.h (Fprevious_property_change):
1847 (Fremove_list_of_text_properties): Remove decls.
1848 * keyboard.c (Fthis_command_keys): Remove decl.
1849 (Fcommand_execute): New forward static decl.
1850 * keymap.c (Flookup_key): New forward static decl.
1851 (Fcopy_keymap): Now static.
1852 * keymap.h (Flookup_key): Remove decl.
1853 * process.c (Fget_process): New forward static decl.
1854 (Fprocess_datagram_address): Mark as internal.
1855 * syntax.c (Fsyntax_table_p): New forward static decl.
1856 (skip_chars): Remove duplicate decl.
1857 * textprop.c (Fprevious_property_change): New forward static decl.
1858 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1859 Now internal.
1860 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1861 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1862
785bbd42
PE
1863 * editfns.c (Fformat): Remove unreachable code.
1864
8b913b57
AS
18652011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1866
1867 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1868 change. (Bug#8496)
1869
a6744a35
EZ
18702011-04-13 Eli Zaretskii <eliz@gnu.org>
1871
1872 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1873 when at ZV. (Bug#8487)
1874
e7974947
AS
18752011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1876
baad03f0
AS
1877 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1878 (Bug#8437)
1879 * keyboard.c (parse_tool_bar_item): Likewise.
1880 * sound.c (sound_cleanup, alsa_close): Likewise.
1881 * termcap.c (tgetent): Likewise.
1882 * xfns.c (x_default_font_parameter): Likewise.
1883 * xsettings.c (read_and_apply_settings): Likewise.
1884
e7974947
AS
1885 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1886 (overrun_check_free): Protoize.
1887
28272684
PE
18882011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1891 since callers should never pass a negative size.
1892 Change the signature to match that of plain 'read' and 'write'; see
1893 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1894 * lisp.h: Update prototypes of emacs_write and emacs_read.
1895
11997c76
EZ
18962011-04-11 Eli Zaretskii <eliz@gnu.org>
1897
1898 * xdisp.c (redisplay_window): Don't try to determine the character
1899 position of the scroll margin if the window start point w->startp
e896f03c 1900 is outside the buffer's accessible region. (Bug#8468)
11997c76 1901
8a2cbd72
EZ
19022011-04-10 Eli Zaretskii <eliz@gnu.org>
1903
1904 Fix write-region and its subroutines for buffers > 2GB.
1905 * fileio.c (a_write, e_write): Modify declaration of arguments and
1906 local variables to support buffers larger than 2GB.
1907 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1908
1909 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1910 argument, local variables, and return value.
1911
1912 * lisp.h: Update prototypes of emacs_write and emacs_read.
1913
1914 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1915
4073e537 19162011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1917
1ebfdcb6
PE
1918 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1919
b2ded58d
PE
1920 Fix more problems found by GCC 4.6.0's static checks.
1921
7d66342c
PE
1922 * xdisp.c (vmessage): Use a better test for character truncation.
1923
bbf47d44
PE
1924 * charset.c (load_charset_map): <, not <=, for optimization,
1925 and to avoid potential problems with integer overflow.
9248994d 1926 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1927 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1928 * editfns.c (Fformat): Likewise.
1e69125e 1929 * syntax.c (skip_chars): Likewise.
3befa583 1930
e3019616
PE
1931 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1932 This also lets GCC 4.6.0 generate slightly better loop code.
1933
becfa255
PE
1934 * callint.c (Fcall_interactively): <, not <=, for optimization.
1935 (Fcall_interactively): Count the number of arguments produced,
1936 not the number of arguments given. This is simpler and lets GCC
1937 4.6.0 generate slightly better code.
1938
dae0cd48
PE
1939 * ftfont.c: Distingish more carefully between FcChar8 and char.
1940 The previous code passed unsigned char * to a functions like
1941 strlen and xstrcasecmp that expect char *, which does not
1942 conform to the C standard.
1943 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1944 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1945 char * when the C standard requires it.
1946
76032d70
PE
1947 * keyboard.c (read_char): Remove unused var.
1948
eb3f1cc8
PE
1949 * eval.c: Port to Windows vsnprintf (Bug#8435).
1950 Include <limits.h>.
1951 (SIZE_MAX): Define if the headers do not.
1952 (verror): Do not give up if vsnprintf returns a negative count.
1953 Instead, grow the buffer. This ports to Windows vsnprintf, which
1954 does not conform to C99. Problem reported by Eli Zaretskii.
1955 Also, simplify the allocation scheme, by avoiding the need for
1956 calling realloc, and removing the ALLOCATED variable.
1957
70476b54
PE
1958 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1959
12020a9e
PE
1960 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1961 But keep the doprint source code for now, as we might revamp it
1962 and use it again (Bug#8435).
ea6c7ae6
PE
1963 * lisp.h (doprnt): Remove.
1964 * Makefile.in (base_obj): Remove doprnt.o.
1965 * deps.mk (doprnt.o): Remove.
1966
5fdb398c
PE
1967 error: Print 32- and 64-bit integers portably (Bug#8435).
1968 Without this change, on typical 64-bit hosts error ("...%d...", N)
1969 was used to print both 32- and 64-bit integers N, which relied on
1970 undefined behavior.
1971 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1972 New macro.
1973 * lisp.h (error, verror): Mark as printf-like functions.
1974 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1975 Report overflow in size calculations when allocating printf buffer.
1976 Do not truncate output string at its first null byte.
1977 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1978 Truncate the output at a character boundary, since vsnprintf does not
1979 do that.
1980 * charset.c (check_iso_charset_parameter): Convert internal
1981 character to string before calling 'error', since %c now has the
1982 printf meaning.
1983 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1984 overflow when computing char to be passed to 'error'. Do not
1985 pass Lisp_Object to 'error'; pass the integer instead.
1986 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1987 formatted with plain %d.
1988
b189fa66
PE
1989 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1990
bff87ef0
PE
1991 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1992
7e2cac20
PE
1993 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1994
ce4d90b5
PE
1995 * xterm.c (x_catch_errors): Remove duplicate declaration.
1996
266c9547
PE
1997 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1998
79c49ad2
PE
1999 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2000
368f4090
JM
20012011-04-10 Jim Meyering <meyering@redhat.com>
2002
2003 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2004 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2005 return ssize_t not "int", and use size_t as the buffer length.
2006 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2007 * gnutls.h: Update declarations.
2008 * process.c (read_process_output): Use ssize_t, to match.
2009 (send_process): Likewise.
2010
a32d4040
CY
20112011-04-09 Chong Yidong <cyd@stupidchicken.com>
2012
2013 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2014
8546720e 20152011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2016
04f2d78b
CB
2017 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2018 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2019
8546720e
GM
2020 * xterm.c (handle_one_xevent):
2021 * xmenu.c (create_and_show_popup_menu):
2022 * xselect.c (x_decline_selection_request)
2023 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2024
0a2f5c1a 20252011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2026
2027 Fix some uses of `int' instead of EMACS_INT.
2028 * search.c (string_match_1, fast_string_match)
2029 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2030 (scan_buffer, find_next_newline_no_quit)
2031 (find_before_next_newline, search_command, Freplace_match)
2032 (Fmatch_data): Make some `int' variables be EMACS_INT.
2033
2034 * xdisp.c (display_count_lines): 3rd argument and return value now
2035 EMACS_INT. All callers changed.
2036 (pint2hrstr): Last argument is now EMACS_INT.
2037
2038 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2039 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2040 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2041 (decode_coding_utf_16, decode_coding_emacs_mule)
2042 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2043 (decode_coding_ccl, decode_coding_charset)
2044 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2045 (decode_coding_iso_2022, decode_coding_emacs_mule)
2046 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2047 <char_offset, last_offset>: Declare EMACS_INT.
2048 (encode_coding_utf_8, encode_coding_utf_16)
2049 (encode_coding_emacs_mule, encode_invocation_designation)
2050 (encode_designation_at_bol, encode_coding_iso_2022)
2051 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2052 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2053 Declare EMACS_INT.
2054 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2055 (encode_invocation_designation): Last argument P_NCHARS is now
2056 EMACS_INT.
2057 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2058 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2059
2060 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2061 All users changed.
2062
2063 * ccl.c (Fccl_execute_on_string): Declare some variables
2064 EMACS_INT.
2065
8546720e 20662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2067
2068 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2069
4e19a977
CS
20702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2071
2072 * process.c (Fformat_network_address): Doc fix.
2073
87302331
R
20742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2075
2076 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2077
cbb59342
CY
20782011-04-08 Chong Yidong <cyd@stupidchicken.com>
2079
2080 * keyboard.c (read_char): Call Lisp function help-form-show,
2081 instead of using internal_with_output_to_temp_buffer.
2082 (Qhelp_form_show): New var.
e0d38eeb 2083 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2084
2085 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2086
2087 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2088
e67a13ab
CY
20892011-04-06 Chong Yidong <cyd@stupidchicken.com>
2090
04f2d78b
CB
2091 * process.c (Flist_processes): Remove to Lisp.
2092 (list_processes_1): Delete.
e67a13ab 2093
973f782d
EZ
20942011-04-06 Eli Zaretskii <eliz@gnu.org>
2095
7c106b1e
EZ
2096 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2097
973f782d
EZ
2098 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2099
41cf7d1a 21002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2101
ca23cc88
PE
2102 Fix more problems found by GCC 4.6.0's static checks.
2103
f390e2d5
PE
2104 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2105
42eea0d0
PE
2106 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2107
b69769da 2108 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2109
f9541e84
PE
2110 * xdisp.c (vmessage): Mark as a printf-like function.
2111
13841b55
PE
2112 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2113
c136c10f
PE
2114 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2115
5e2d4a30
PE
2116 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2117 printf-like functions.
2118 (tiff_load): Add casts to remove these marks before passing them
2119 to system-supplied API.
2120
583f48b9
PE
2121 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2122
b25d760e
PE
2123 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2124 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2125 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2126 directly, rather than having caller test rule sign. This avoids
2127 some unnecessary tests.
2128 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2129 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2130 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2131
bc7b6697 2132 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2133 (xfont_open): Avoid unnecessary tests.
bc7b6697 2134
27ccc379
PE
2135 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2136
dcd5c89a
PE
2137 * composite.h, composite.c (composition_gstring_put_cache):
2138 Use EMACS_INT, not int, for length.
2139
b13a45c6
PE
2140 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2141 breaking out part of COMPOSITION_DECODE_RULE.
2142 (COMPOSITION_DECODE_RULE): Use it.
2143 * composite.c (get_composition_id): Remove unused local vars,
2144 by using the new macro.
2145
1e792e4d
PE
2146 * textprop.c (set_text_properties_1): Change while to do-while,
2147 since the condition is always true at first.
2148
dc6c6455 2149 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2150 (interval_deletion_adjustment): Return unsigned value.
2151 All uses changed.
dc6c6455 2152
aba7731a
PE
2153 * process.c (list_processes_1, create_pty, read_process_output):
2154 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2155 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2156 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2157 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2158 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2159
fdfc4bf3
PE
2160 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2161
fca8fe46 2162 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2163 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2164
06a0259a 2165 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2166 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2167 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2168
e7b9e80f
PE
2169 * print.c (print_error_message): Avoid int overflow.
2170
56201685
PE
2171 * font.c (font_list_entities): Redo for clarity,
2172 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2173
78834453 2174 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2175 (font_score): Avoid potential overflow in diff calculation.
78834453 2176
0bc0b309 2177 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2178 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2179
e610eaca
PE
2180 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2181
b895abce
PE
2182 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2183 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2184 can always succeed if overflow has undefined behavior.
2185
1f1d9321 2186 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2187 (wordify): Omit three unnecessary tests.
1f1d9321 2188
c59478bc
PE
2189 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2190 All callers changed. This avoids the need for an unused var.
2191
79b73827
PE
2192 * casefiddle.c (casify_region): Remove var that is set but not used.
2193
a4db5dfe
PE
2194 * dired.c (file_name_completion): Remove var that is set but not used.
2195
43aae36e
PE
2196 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2197
2a47c44d 2198 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2199 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2200
a37c69bf
PE
2201 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2202 Check for integer overflow on size calculations.
2203
328ab8e7
PE
2204 * buffer.c (Fprevious_overlay_change): Remove var that is set
2205 but not used.
2206
e5a2a5cb
PE
2207 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2208 Remove vars that are set but not used.
8d84a6eb 2209 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2210 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2211
a60e5f68
PE
2212 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2213
f661cb61 2214 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2215 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2216
f0397f5a
PE
2217 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2218 that are set but not used.
2219
8664db06 2220 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2221 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2222
6abdaa4a
PE
2223 * xselect.c (x_get_local_selection, x_handle_property_notify):
2224 Remove vars that are set but not used.
2225
0ce7538d 2226 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2227 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2228
9ae848fc
PE
2229 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2230 Remove var that is set but not used.
0b918413
PE
2231 (scroll_bar_windows_size): Now size_t, not int.
2232 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2233 Check for overflow.
9ae848fc 2234
a5a62657
PE
2235 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2236 (map_tty_color) [!defined MSDOS]: Likewise.
2237
5c5cdd39
PE
2238 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2239
66ebf983
PE
2240 * coding.c: Remove vars that are set but not used.
2241 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2242 All callers changed.
2243 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2244 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2245 (decode_coding_charset): Remove vars that are set but not used.
2246
1be4d761
PE
2247 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2248 that is set but not used.
2249
47553fa8
PE
2250 * print.c (print_object): Remove var that is set but not used.
2251
1f7196bf 2252 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2253 The gnulib version avoids calling malloc in the usual case,
2254 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2255 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2256 * filelock.c (current_lock_owner): Likewise.
2257 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2258 * sysdep.c: Include allocator.h, careadlinkat.h.
2259 (emacs_no_realloc_allocator): New static constant.
2260 (emacs_readlink): New function.
fdb61804
PE
2261 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2262 ../lib/careadlinkat.h.
d1fdcab7 2263
f84c17c7
SM
22642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2265
2266 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2267 first non-nil return value).
2268
ef3862ad
JD
22692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2270
2271 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2272 if not defined (Bug#8403).
2273
376a7006
JB
22742011-04-02 Juanma Barranquero <lekktu@gmail.com>
2275
2276 * xdisp.c (display_count_lines): Remove parameter `start',
2277 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2278 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2279 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2280 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2281 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2282 and thereabouts. All callers changed.
2283 (get_per_char_metric): Remove parameter `f', unused since
2284 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2285
6ca3801d
JM
22862011-04-02 Jim Meyering <meyering@redhat.com>
2287
2288 do not dereference NULL upon failed strdup
2289 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2290 (ns_get_family): Likewise.
2291
d8e2b5ba
JB
22922011-04-02 Juanma Barranquero <lekktu@gmail.com>
2293
2294 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2295
8c74fcbd
JD
22962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2297
2298 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2299 later (Bug#8403).
2300
7200d79c
SM
23012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2302
03408648 2303 Add lexical binding.
7200d79c 2304
03408648
SM
2305 * window.c (Ftemp_output_buffer_show): New fun.
2306 (Fsave_window_excursion):
2307 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2308
2309 * lread.c (lisp_file_lexically_bound_p): New function.
2310 (Fload): Bind Qlexical_binding.
2311 (readevalloop): Remove `evalfun' arg.
2312 Bind Qinternal_interpreter_environment.
2313 (Feval_buffer): Bind Qlexical_binding.
2314 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2315 Mark as dynamic.
2316 (syms_of_lread): Declare `lexical-binding'.
2317
2318 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2319
2320 * keyboard.c (eval_dyn): New fun.
2321 (menu_item_eval_property): Use it.
ca105506
SM
2322
2323 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2324
03408648
SM
2325 * fns.c (concat, mapcar1): Accept byte-code-functions.
2326
2327 * eval.c (Fsetq): Handle lexical vars.
2328 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2329 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2330 (FletX, Flet): Obey lexical binding.
2331 (Fcommandp): Handle closures.
2332 (Feval): New `lexical' arg.
2333 (eval_sub): New function extracted from Feval. Use it almost
2334 everywhere where Feval was used. Look up vars in lexical env.
2335 Handle closures.
2336 (Ffunctionp): Move from subr.el.
2337 (Ffuncall): Handle closures.
2338 (apply_lambda): Remove `eval_flags'.
2339 (funcall_lambda): Handle closures and new byte-code-functions.
2340 (Fspecial_variable_p): New function.
2341 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2342 but without exporting it to Lisp.
23aba0ea 2343
23aba0ea 2344 * doc.c (Fdocumentation, store_function_docstring):
03408648 2345 * data.c (Finteractive_form): Handle closures.
23aba0ea 2346
03408648
SM
2347 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2348 interactive spec.
ba83908c 2349
04f2d78b
CB
2350 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2351 New byte-codes.
03408648
SM
2352 (exec_byte_code): New function extracted from Fbyte_code to handle new
2353 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2354
03408648 2355 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2356
03408648 2357 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2358
e2abce01
JB
23592011-03-31 Juanma Barranquero <lekktu@gmail.com>
2360
2361 * xdisp.c (redisplay_internal): Fix prototype.
2362
63696a73 23632011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2364
63696a73 2365 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2366 (try_scrolling): Use it when setting scroll_limit.
2367 Limit scrolling to 100 screen lines.
63696a73
EZ
2368 (redisplay_window): Even when falling back on "recentering",
2369 position point in the window according to scroll-conservatively,
2370 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2371
2372 (try_scrolling): When point is above the window, allow searching
2373 as far as scroll_max, or one screenful, to compute vertical
2374 distance from PT to the scroll margin position. This prevents
2375 try_scrolling from unnecessarily failing when
2376 scroll-conservatively is set to a value slightly larger than the
2377 window height. Clean up the case of PT below the margin at bottom
2378 of window: scroll_max can no longer be INT_MAX. When aggressive
2379 scrolling is in use, don't let point enter the opposite scroll
2380 margin as result of the scroll.
2381 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2382 threshold of 100 lines for never-recentering scrolling.
2383
e4cc2dfc
JB
23842011-03-31 Juanma Barranquero <lekktu@gmail.com>
2385
2386 * dispextern.h (move_it_by_lines):
2387 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2388 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2389 (message_log_check_duplicate): Remove parameters `prev_bol' and
2390 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2391 (redisplay_internal): Remove parameter `preserve_echo_area',
2392 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2393
2394 * indent.c (Fvertical_motion):
2395 * window.c (window_scroll_pixel_based, Frecenter):
2396 Don't pass `need_y_p' to `move_it_by_lines'.
2397
1c470562
SM
23982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2399
44f230aa
SM
2400 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2401 steal a few bits to be more compact.
2402 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2403 Remove unneeded casts.
2404
1c470562
SM
2405 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2406
888adce9
ZK
24072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2408
2409 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2410 binding" message (bug#7967).
2411
f838ed7b
PE
24122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2413
77861b95
PE
2414 Fix more problems found by GCC 4.6.0's static checks.
2415
de6dbc14
PE
2416 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2417 Remove unused local var.
2418
f838ed7b
PE
2419 * editfns.c (Fmessage_box): Remove unused local var.
2420
792c7b2b
PE
2421 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2422 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2423 Omit unused local vars.
c499e557 2424 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2425 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2426 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2427 Omit unused local var.
2428
ba0165e1
PE
2429 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2430 Don't assume string length fits in int.
32ad8845 2431 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2432 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2433
3c59b4c9
PE
2434 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2435 instead of alloca (Bug#8344).
2436
a3eed478 2437 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2438 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2439
eb4d412d
PE
2440 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2441
1658b401
PE
2442 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2443 concerns.
2444
2445 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2446
2447 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2448
9a2c6e05
PE
2449 * keyboard.c (syms_of_keyboard): Use the same style as later
2450 in this function when indexing through an array. This also
2451 works around GCC bug 48267.
2452
03d0a109
PE
2453 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2454
44f730c8
PE
2455 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2456
fe75f926
PE
2457 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2458 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2459
ffa8c828
PE
2460 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2461 This avoids undefined behavior on integer overflow, and is a bit
2462 more convenient anyway since it is compared to a size_t variable.
2463
c5101a77
PE
2464 Variadic C functions now count arguments with size_t, not int.
2465 This avoids an unnecessary limitation on 64-bit machines, which
2466 caused (substring ...) to crash on large vectors (Bug#8344).
2467 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2468 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2469 All variadic functions and their callers changed accordingly.
c5101a77
PE
2470 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2471 * data.c (arith_driver, float_arith_driver): Likewise.
2472 * editfns.c (general_insert_function): Likewise.
2473 * eval.c (struct backtrace.nargs, interactive_p)
2474 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2475 (funcall_lambda, mark_backtrace): Likewise.
2476 * fns.c (concat): Likewise.
2477 * frame.c (x_set_frame_parameters): Likewise.
2478 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2479 0 if not found, not -1. All callers changed.
2480
dd3f25f7
PE
2481 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2482 (stack_copy_size): Now size_t, not int.
2483 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2484
461c2ab9
JB
24852011-03-28 Juanma Barranquero <lekktu@gmail.com>
2486
2487 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2488 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2489 All callers changed.
2490
2491 * lisp.h (multibyte_char_to_unibyte):
2492 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2493 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2494 * character.h (CHAR_TO_BYTE8):
2495 * cmds.c (internal_self_insert):
2496 * editfns.c (general_insert_function):
2497 * keymap.c (push_key_description):
2498 * search.c (Freplace_match):
2499 * xdisp.c (message_dolog, set_message_1): All callers changed.
2500
f6d62986
SM
25012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2502
2503 * keyboard.c (safe_run_hook_funcall): New function.
2504 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2505 don't set the hook to nil, but remove the offending function instead.
2506 (Qcommand_hook_internal): Remove, unused.
2507 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2508 Vcommand_hook_internal.
2509
2510 * eval.c (enum run_hooks_condition): Remove.
2511 (funcall_nil, funcall_not): New functions.
2512 (run_hook_with_args): Call each function through a `funcall' argument.
2513 Remove `cond' argument, now redundant.
2514 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2515 (Frun_hook_with_args_until_failure): Adjust accordingly.
2516 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2517
1db5b1ad
JB
25182011-03-28 Juanma Barranquero <lekktu@gmail.com>
2519
2520 * dispextern.h (string_buffer_position): Remove declaration.
2521
2522 * print.c (strout): Remove parameter `multibyte', unused since
2523 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2524
2525 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2526 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2527 All callers changed.
2528
2529 * w32.c (_wsa_errlist): Use braces for struct initializers.
2530
2531 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2532 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2533 All callers changed.
2534 (string_buffer_position): Likewise. Also, make static (it's never
2535 used outside xdisp.c).
2536 (cursor_row_p): Remove parameter `w', unused since
2537 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2538 (decode_mode_spec): Remove parameter `precision', introduced during
2539 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2540 All callers changed.
2541
5ffb62aa
JD
25422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2543
2544 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2545
461c2ab9 25462011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2547
2548 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2549 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2550 (ns_update_auto_hide_menu_bar): New functions.
2551 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2552 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2553 ns_constrain_all_frames.
2554 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2555 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2556
5c380ffb
JD
25572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2558
2559 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2560
9af30bdf
GM
25612011-03-27 Glenn Morris <rgm@gnu.org>
2562
2563 * syssignal.h: Replace RETSIGTYPE with void.
2564 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2565 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2566 Replace SIGTYPE with void everywhere.
2567 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2568 * s/template.h (SIGTYPE): Remove commented out definition.
2569
e2abce01
JB
25702011-03-26 Eli Zaretskii <eliz@gnu.org>
2571
2572 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2573 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2574
f868cd8a
JB
25752011-03-26 Juanma Barranquero <lekktu@gmail.com>
2576
59eb0929
JB
2577 * w32.c (read_unc_volume): Use parameter `henum', instead of
2578 global variable `wget_enum_handle'.
2579
2580 * keymap.c (describe_vector): Remove parameters `indices' and
2581 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2582 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2583
f868cd8a
JB
2584 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2585
2586 * keyboard.c (timer_check): Remove parameter `do_it_now',
2587 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2588 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2589 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2590
2591 * keyboard.c (read_char):
2592 * w32menu.c (w32_menu_display_help):
2593 * xmenu.c (show_help_event, menu_help_callback):
2594 Adjust calls to `show_help_echo'.
2595
2596 * gtkutil.c (xg_maybe_add_timer):
2597 * keyboard.c (readable_events):
2598 * process.c (wait_reading_process_output):
2599 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2600
2601 * insdel.c (adjust_markers_gap_motion):
2602 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2603 (gap_left, gap_right): Don't call it.
2604
2ecf6fdb
CY
26052011-03-25 Chong Yidong <cyd@stupidchicken.com>
2606
2607 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2608 incurred during fontification.
2609
6b1f9ba4
JB
26102011-03-25 Juanma Barranquero <lekktu@gmail.com>
2611
2612 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2613 (DEFVAR_PER_BUFFER): Don't pass it.
2614
2615 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2616 (scrolling_window): Don't pass it.
2617
0f4a96b5
JB
26182011-03-25 Juanma Barranquero <lekktu@gmail.com>
2619
2620 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2621
2622 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2623 and `suffix'.
2624 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2625 of variables specific to SELinux and computation of `encoded_absname'.
2626
2627 * image.c (XPutPixel): Remove unused variable `height'.
2628
2629 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2630
2631 * unexw32.c (get_section_info): Remove unused variable `section'.
2632
2633 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2634 (system_process_attributes): Remove unused variable `sess'.
2635 (sys_read): Remove unused variable `err'.
2636
2637 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2638 (w32_wnd_proc): Remove unused variable `isdead'.
2639 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2640 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2641 (x_create_tip_frame): Remove unused variable `tem'.
2642
2643 * w32inevt.c (w32_console_read_socket):
2644 Remove unused variable `no_events'.
2645
2646 * w32term.c (x_draw_composite_glyph_string_foreground):
2647 Remove unused variable `width'.
2648
1149507c
JB
26492011-03-24 Juanma Barranquero <lekktu@gmail.com>
2650
2651 * w32term.c (x_set_glyph_string_clipping):
2652 Don't pass uninitialized region to CombineRgn.
2653
9c88f339
JB
26542011-03-23 Juanma Barranquero <lekktu@gmail.com>
2655
2656 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2657 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2658 (Fx_close_connection): Remove unused variable `i'.
2659
2660 * w32font.c (w32font_draw): Return number of glyphs.
2661 (w32font_open_internal): Remove unused variable `i'.
2662 (w32font_driver): Add missing initializer.
2663
2664 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2665 (fill_in_menu): Remove unused variable `items_added'.
2666
2667 * w32term.c (last_mouse_press_frame): Remove static global variable.
2668 (w32_clip_to_row): Remove unused variable `f'.
2669 (x_delete_terminal): Remove unused variable `i'.
2670
2671 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2672 (NOTHING): Remove unused static global variable.
2673 (uniscribe_check_otf): Remove unused variable `table'.
2674 (uniscribe_font_driver): Add missing initializers.
2675
dee091a3
JD
26762011-03-23 Julien Danjou <julien@danjou.info>
2677
2678 * term.c (Fsuspend_tty, Fresume_tty):
2679 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2680 * window.c (temp_output_buffer_show):
2681 * insdel.c (signal_before_change):
2682 * frame.c (Fhandle_switch_frame):
2683 * fileio.c (Fdo_auto_save):
2684 * emacs.c (Fkill_emacs):
2685 * editfns.c (save_excursion_restore):
2686 * cmds.c (internal_self_insert):
2687 * callint.c (Fcall_interactively):
2688 * buffer.c (Fkill_all_local_variables):
2689 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2690 Use Frun_hooks.
0f4a96b5 2691 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2692 unconditionnaly since it does the check itself.
2693
2c520ab5 26942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2695
c9c49752
PE
2696 Fix more problems found by GCC 4.5.2's static checks.
2697
8abc3f12
PE
2698 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2699 the first time through the loop, since we know p0 < p1 then.
2700 This also avoids a gcc -Wstrict-overflow warning.
2701
a2d26660
PE
2702 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2703 leading to a memory leak, possible in functions like
2704 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2705 of objects (Bug#8318).
a2d26660 2706
916c72e9
PE
2707 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2708 that could (at least in theory) be that large.
2709
19ab8a18
PE
2710 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2711 This is less likely to overflow, and avoids undefined behavior if
2712 overflow does occur. All callers changed. Use strtoul to scan
2713 for the unsigned long integer.
b7cbbd6f
PE
2714 (pint2hrstr): Simplify and tune code slightly.
2715 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2716
f0641eff
PE
2717 * scroll.c (do_scrolling): Work around GCC bug 48228.
2718 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2719
7f650bb9
PE
2720 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2721 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2722 (validate_x_resource_name): Simplify count usage.
2723 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2724
37dd57d1
PE
2725 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2726 fail (Bug#8306).
81e56e61 2727
699979fc 2728 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2729
401bf9b4
PE
2730 * process.c (Fmake_network_process): Use socklen_t, not int,
2731 where POSIX says socklen_t is required in portable programs.
2732 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2733 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2734 (Fmake_network_process, server_accept_connection):
2735 (wait_reading_process_output, read_process_output):
2736 Likewise.
2737
b93aacde
PE
2738 * process.c: Rename or move locals to avoid shadowing.
2739 (list_processes_1, Fmake_network_process):
2740 (read_process_output_error_handler, exec_sentinel_error_handler):
2741 Rename or move locals.
4dc343ee 2742 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2743 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2744 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2745 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2746 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2747
af8a867c 2748 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2749 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2750 Include tparam.h instead, since it declares them.
af8a867c
PE
2751 * cm.h (PC): Remove extern decl; tparam.h now does this.
2752 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2753 * terminfo.c: Include tparam.h, to check interfaces.
2754 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2755 (tparam): Adjust signature to match interface in tparam.h;
2756 this removes some undefined behavior. Check that outstring and len
2757 are zero, which they always are with Emacs.
2758 * tparam.h (PC, BC, UP): New extern decls.
2759
0248044d 2760 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2761 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2762
8ff096c1 2763 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2764 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2765 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2766 (ftfont_list): Remove unused local.
49eaafba
PE
2767 (get_adstyle_property, ftfont_pattern_entity):
2768 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2769 Rename locals to avoid shadowing.
8ff096c1 2770
e2be39f6
PE
2771 * xfont.c (xfont_list_family): Mark var as initialized.
2772
c9735e30
PE
2773 * xml.c (make_dom): Now static.
2774
8f5201ae
PE
2775 * composite.c (composition_compute_stop_pos): Rename local to
2776 avoid shadowing.
b246f932
PE
2777 (composition_reseat_it): Remove unused locals.
2778 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2779 (composition_update_it): Mark var as initialized.
11b61122
PE
2780 (find_automatic_composition): Mark vars as initialized,
2781 with a FIXME (Bug#8290).
8f5201ae 2782
760fbc2c
PE
2783 character.h: Rename locals to avoid shadowing.
2784 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2785 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2786 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2787 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2788 to avoid shadowing.
2789
ff08eb85
PE
2790 * textprop.c (property_change_between_p): Remove; unused.
2791
fc7bf025
PE
2792 * intervals.c (interval_start_pos): Now static.
2793
235d7abc
PE
2794 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2795
44f230aa
SM
2796 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2797 Rename locals to avoid shadowing.
3e7d6594 2798
50060332
PE
2799 * sound.c (wav_play, au_play, Fplay_sound_internal):
2800 Fix pointer signedness.
d01f234b 2801 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2802 (wav_play): Initialize a variable to 0, to prevent undefined
2803 behavior (Bug#8278).
50060332 2804
c4fc4e30
PE
2805 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2806
918436ed
PE
2807 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2808
c939f91b
PE
2809 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2810 clobbering (Bug#8298).
b9c7f648
PE
2811 * sysdep.c (sys_subshell): Likewise.
2812 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2813
6bd8c144
PE
2814 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2815 This should get cleaned up, so that child_setup has the
2816 same signature on all platforms.
2817
7710357c 2818 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2819 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2820
c59da222
CY
28212011-03-22 Chong Yidong <cyd@stupidchicken.com>
2822
2823 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2824 not to be necessary, and produces flickering.
2825
66b87493
GM
28262011-03-20 Glenn Morris <rgm@gnu.org>
2827
2828 * config.in: Remove file.
2829
45b6f6d5
JB
28302011-03-20 Juanma Barranquero <lekktu@gmail.com>
2831
2832 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2833 are now in src/globals.h.
2834 (syms_of_minibuf): Remove spurious & from previous change.
2835
3ec03f7e
LL
28362011-03-20 Leo <sdl.web@gmail.com>
2837
2838 * minibuf.c (completing-read-function): New variable.
2839 (completing-read-default): Rename from completing-read.
2840 (completing-read): Call completing-read-function.
2841
b14e3e21
CY
28422011-03-19 Juanma Barranquero <lekktu@gmail.com>
2843
2844 * xfaces.c (Fx_load_color_file):
2845 Read color file from absolute filename (bug#8250).
2846
f2b726e6
JB
28472011-03-19 Juanma Barranquero <lekktu@gmail.com>
2848
2849 * makefile.w32-in: Update dependencies.
2850
09f6ff02
EZ
28512011-03-17 Eli Zaretskii <eliz@gnu.org>
2852
2853 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2854
29a6015a
PE
28552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2856
a3a6c54e
PE
2857 Fix more problems found by GCC 4.5.2's static checks.
2858
b766f867
PE
2859 * process.c (make_serial_process_unwind, send_process_trap):
2860 (sigchld_handler): Now static.
2861
be02381c
PE
2862 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2863 That way, the code declares only the vars that it needs.
2864 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2865 * s/cygwin.h (PTY_ITERATION): Likewise.
2866 * s/darwin.h (PTY_ITERATION): Likewise.
2867 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2868
57048744
PE
2869 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2870 * process.c (allocate_pty): Don't declare stb unless it's needed.
2871
7914961c 2872 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2873 (CONSTANTLIM): Remove; unused.
2874 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2875 Define only if needed.
7914961c 2876
b3967b18
PE
2877 * unexelf.c (unexec): Name an expression,
2878 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2879 Use a different way to cause a compilation error if anyone uses
2880 n rather than nn, a way that does not involve shadowing.
73366a00 2881 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2882
29a6015a
PE
2883 * deps.mk (unexalpha.o): Remove; unused.
2884
43cfc33e 2885 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2886 * unexec.h: New file.
ce701a33
PE
2887 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2888 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2889 Depend on unexec.h.
2890 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2891 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2892 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2893 Change as necessary to match prototype in unexec.h.
ce701a33 2894
01f44d5a
PE
2895 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2896 shadowing.
4f63c6bb 2897 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2898
a6670b0b
PE
2899 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2900 Rename locals to avoid shadowing.
2901
cef2010d 2902 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2903 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2904
d4d7173a
PE
2905 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2906
f08b802a
PE
2907 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2908 warning when compiling print.c.
2909
3ddb0639
PE
2910 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2911 instead of using an uninitialized var.
5ad03b97 2912 (font_sort_entities): Mark var as initialized.
3ddb0639 2913
170a2692
PE
2914 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2915
e663c700
PE
2916 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2917 pointers to constants.
89bc529a 2918 (font_parse_fcname): Remove unused vars.
7b81e2d0 2919 (font_delete_unmatched): Now static.
ea838e10 2920 (font_get_spec): Remove; unused.
13a547c6
PE
2921 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2922 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2923 Rename or move locals to avoid shadowing.
e663c700 2924
2a80c887 2925 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2926 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2927
1384fa33 2928 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2929 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2930
8b2c52e9
PE
2931 * alloc.c (mark_backtrace): Move decl from here ...
2932 * lisp.h: ... to here, so that it can be checked.
2933
475545b5 2934 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2935 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2936 (lisp_indirect_variable): Name an expression,
2937 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2938 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2939
b1349114 2940 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2941 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2942 Use const pointer when appropriate.
b1349114 2943
a2928364
PE
2944 * lisp.h (get_system_name, get_operating_system_release):
2945 Move decls here, to check interfaces.
2946 * process.c (get_operating_system_release): Move decl to lisp.h.
2947 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2948 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2949 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2950 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2951 (Fformat_time_string, Fencode_time, Finsert_char):
2952 (Ftranslate_region_internal, Fformat):
2953 Rename or remove local vars to avoid shadowing.
9710023e 2954 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2955
a415e694
PE
2956 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2957 avoid shadowing.
2958
8ef4622d
PE
2959 * lisp.h (eassert): Check that the argument compiles, even if
2960 ENABLE_CHECKING is not defined.
2961
946f9a5b
PE
2962 * data.c (Findirect_variable): Name an expression, to avoid
2963 gcc -Wbad-function-cast warning.
112396d6 2964 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2965 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2966 (Fmake_variable_buffer_local, Fmake_local_variable):
2967 Mark variables as initialized.
52746918 2968 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2969
e5aab7e7 2970 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2971 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2972 Rename locals to avoid shadowing.
dff45157
PE
2973 (mark_stack): Move local variables into the #ifdef region where
2974 they're used.
7bc26fdb
PE
2975 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2976 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2977 needed otherwise.
2978 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2979 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2980 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2981
e5aab7e7
PE
2982 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2983 avoids undefined behavior in theory.
2984
4da60324
PE
2985 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2986
88043301
PE
2987 Use functions, not macros, for up- and down-casing (Bug#8254).
2988 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2989 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2990 to use the following functions instead of these macros.
2991 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2992 EMACS_INT, since callers assume the returned value fits in int.
2993 (upcase1): Likewise, for UPCASE_TABLE.
2994 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2995 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2996 the race-condition problem in the old DOWNCASE.
88043301 2997
19ed5445
PE
2998 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2999 Rename locals to avoid shadowing.
3000 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3001 (regex_compile, re_search_2, re_match_2_internal):
3002 Remove unused local vars.
952db0d7
PE
3003 (FREE_VAR): Rewrite so as not to use empty "else",
3004 which gcc can warn about.
da053e48 3005 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3006 (RETALLOC_IF): Define only if needed.
3007 (WORDCHAR_P): Likewise. This one is never needed, but is used
3008 only in a comment talking about a compiler bug, so put inside
3009 the #if 0 of that comment.
3010 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3011 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3012 Remove; unused.
19ed5445 3013
1f3561e4 3014 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3015 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3016 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3017
ded6f8f7
PE
3018 * search.c (simple_search): Remove unused var.
3019
dbd37a95
PE
3020 * dired.c (compile_pattern): Move decl from here ...
3021 * lisp.h: ... to here, so that it can be checked.
3022 (struct re_registers): New forward decl.
3023
7e47afad
PE
3024 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3025
85f24f61
PE
3026 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3027 All uses changed.
3028 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3029 Rename locals to avoid shadowing.
5671df8f 3030 (Fvertical_motion): Mark locals as initialized.
85f24f61 3031
181aa2be 3032 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3033 (casify_region): Mark local as initialized.
181aa2be 3034
930d429c
PE
3035 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3036
7082eac6
PE
3037 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3038 New macros, so that the caller can use some names other than
3039 gcpro1, gcpro2, etc.
3040 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3041 of the new macros.
3042 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3043 argument, for consistency with GCPRO2_VAR, etc: it is now the
3044 prefix of the variable, not the variable itself. All uses
3045 changed.
38b2c076
PE
3046 * dired.c (directory_files_internal, file_name_completion):
3047 Rename locals to avoid shadowing.
3048
15206ed9
PE
3049 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3050 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3051 dired.c's scmp function, had undefined behavior.
3052 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3053 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3054 * buffer.h: ... to here, because these macros use current_buffer,
3055 and the new implementation with inline functions needs to have
3056 current_buffer in scope now, rather than later when the macros
3057 are used.
3058 (downcase, upcase1): New static inline functions.
3059 (DOWNCASE, UPCASE1): Reimplement using these functions.
3060 This avoids undefined behavior in expressions like
3061 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3062 from race conditions in accessing the global variables
3063 case_temp1 and case_temp2.
3064 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3065 * lisp.h (case_temp1, case_temp2): Remove their decls.
3066 * character.h (ASCII_CHAR_P): Move from here ...
3067 * lisp.h: ... to here, so that the inline functions mentioned
3068 above can use them.
3069
4a6bea26
PE
3070 * dired.c (directory_files_internal_unwind): Now static.
3071
f14b7e14
PE
3072 * fileio.c (file_name_as_directory, directory_file_name):
3073 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3074 Now static.
2893f146
PE
3075 (file_name_as_directory): Use const pointers when appropriate.
3076 (Fexpand_file_name): Likewise. In particular, newdir might
3077 point at constant storage, so make it a const pointer.
fd4ead52 3078 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3079 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3080 signedness issues.
f839df0c
PE
3081 (Fset_file_times, Finsert_file_contents, auto_save_error):
3082 Rename locals to avoid shadowing.
f14b7e14 3083
5716756e 3084 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3085 (Ftry_completion, Fall_completions): Rename or remove locals
3086 to avoid shadowing.
5716756e 3087
b4c3046a
PE
3088 * marker.c (bytepos_to_charpos): Remove; unused.
3089
b45db522
PE
3090 * lisp.h (verify_bytepos, count_markers): New decls,
3091 so that gcc does not warn that these functions aren't declared.
3092
85876d07
PE
3093 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3094 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3095 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3096 (copy_text): Remove unused local var.
85876d07 3097
03d78a21 3098 * filelock.c (within_one_second): Now static.
b3dd38ab 3099 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3100
5df8f01b
PE
3101 * buffer.c (fix_overlays_before): Mark locals as initialized.
3102 (fix_start_end_in_overlays): Likewise. This function should be
3103 simplified by using pointers-to-pointers, but that's a different
3104 matter.
b1d876f1 3105 (switch_to_buffer_1): Now static.
8f54f30a
PE
3106 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3107 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3108
a70072c9 3109 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3110 Fix pointer signedness issue.
edced198
PE
3111 (sys_subshell): Mark local as volatile if checking for lint,
3112 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3113 (MAXPATHLEN): Define only if needed.
a70072c9 3114
a0977c44
PE
3115 * process.c (serial_open, serial_configure): Move decls from here ...
3116 * systty.h: ... to here, so that they can be checked.
3117
a884fdcc
PE
3118 * fns.c (get_random, seed_random): Move extern decls from here ...
3119 * lisp.h: ... to here, so that they can be checked.
3120
604efe86 3121 * sysdep.c (reset_io): Now static.
b8950c94 3122 (wait_for_termination_signal): Remove; unused.
604efe86 3123
38fc62d9
PE
3124 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3125 (copy_keymap_item, append_key, push_text_char_description):
3126 Now static.
1004a21a 3127 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3128 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3129 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3130 (describe_map_tree):
3131 Rename locals to avoid shadowing.
38fc62d9 3132
2f2650da
PE
3133 * keyboard.c: Declare functions static if they are not used elsewhere.
3134 (echo_char, echo_dash, cmd_error, top_level_2):
3135 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3136 (read_char, kbd_buffer_get_event, make_lispy_position):
3137 (make_lispy_event, make_lispy_movement, apply_modifiers):
3138 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3139 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3140 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3141 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3142 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3143
a053e86c 3144 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3145 (mark_kboards): Move decl here ...
3146 * alloc.c (mark_kboards): ... from here.
a053e86c 3147
4752793e
PE
3148 * lisp.h (force_auto_save_soon): New decl.
3149
74f10ca7 3150 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3151 (DEFINE_DUMMY_FUNCTION): New macro.
3152 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3153 Use it.
c03cd23f
PE
3154 (main): Add casts to avoid warnings
3155 if GCC considers string literals to be constants.
74f10ca7 3156
022e70d4
PE
3157 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3158
59d6fe83
PE
3159 * dbusbind.c: Pointer signedness fixes.
3160 (xd_signature, xd_append_arg, xd_initialize):
3161 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3162 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3163 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3164 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3165
78320123
PE
3166 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3167 if GCC considers string literals to be constants.
49cebcca 3168 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3169
35ac2a97
SM
31702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3171
fb103ca9
SM
3172 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3173 (print_preprocess, print_object): New macro to fix last change.
3174
35ac2a97
SM
3175 * print.c (print_preprocess): Don't forget font objects.
3176
62973b41
JB
31772011-03-16 Juanma Barranquero <lekktu@gmail.com>
3178
3179 * emacs.c (USAGE3): Doc fixes.
3180
0e48bb22
AS
31812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3182
3183 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3184 structure.
3185
7684e57b
JB
31862011-03-14 Juanma Barranquero <lekktu@gmail.com>
3187
3188 * lisp.h (VWindow_system, Qfile_name_history):
3189 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3190 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3191 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3192
3193 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3194 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3195
3196 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3197 * w32console.c (detect_input_pending, read_input_pending)
3198 (encode_terminal_code):
3199 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3200 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3201 (w32_system_caret_y, Qfile_name_history):
3202 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3203 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3204 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3205 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3206 * w32proc.c (Qlocal, report_file_error):
3207 * w32term.c (Vwindow_system, updating_frame):
3208 * w32uniscribe.c (initialized, uniscribe_font_driver):
3209 Remove unneeded extern declarations.
3210
2aa46d6c
CY
32112011-03-14 Chong Yidong <cyd@stupidchicken.com>
3212
c96bbc66 3213 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3214
cffc6f3b
CY
32152011-03-13 Chong Yidong <cyd@stupidchicken.com>
3216
3217 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3218 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3219 These macros can no longer be used for assignment.
3220
44f230aa
SM
3221 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3222 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3223 (record_buffer_markers, fetch_buffer_markers): New functions for
3224 recording and fetching special buffer markers.
3225 (set_buffer_internal_1, set_buffer_temp): Use them.
3226
3227 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3228
3229 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3230
3231 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3232 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3233
3234 * xdisp.c (hscroll_window_tree):
3235 (reconsider_clip_changes): Use PT instead of BUF_PT.
3236
d251f04b
EZ
32372011-03-13 Eli Zaretskii <eliz@gnu.org>
3238
3239 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3240 $(EMACS_ROOT)/lib/intprops.h.
3241
f0c77cd1
PE
32422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3243
3eca4629
PE
3244 Fix more problems found by GCC 4.5.2's static checks.
3245
7c86ee98
PE
3246 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3247 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3248 (xg_free_frame_widgets): Make it clear that a local variable is
3249 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3250 (gdk_window_get_screen): Make it clear that this macro is needed
3251 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3252 (int_gtk_range_get_value): New function, which avoids a diagnostic
3253 from gcc -Wbad-function-cast.
3254 (xg_set_toolkit_scroll_bar_thumb): Use it.
3255 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3256 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3257 (get_utf8_string, xg_get_file_with_chooser):
3258 Rename locals to avoid shadowing.
3259 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3260
41729b81
PE
3261 * xgselect.c (xg_select): Remove unused var.
3262
f0c77cd1
PE
3263 * image.c (four_corners_best): Mark locals as initialized.
3264 (gif_load): Initialize transparent_p to zero (Bug#8238).
3265 Mark another local as initialized.
ec6cf4c6 3266 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3267
ce0ad53d 3268 * image.c (clear_image_cache): Now static.
d5d5a617 3269 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3270 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3271 (x_edge_detection): Remove unnecessary cast that
3272 gcc -Wbad-function-cast diagnoses.
2037898d 3273 (gif_load): Fix pointer signedness.
6ae141d6
PE
3274 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3275 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3276
33383987 32772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3278
d32df629
PE
3279 Improve quality of tests for time stamp overflow.
3280 For example, without this patch (encode-time 0 0 0 1 1
3281 1152921504606846976) returns the obviously-bogus value (-948597
3282 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3283 reports time overflow. See
3284 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3285 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3286 * editfns.c: Include limits.h and intprops.h.
3287 (TIME_T_MIN, TIME_T_MAX): New macros.
3288 (time_overflow): Move earlier, to before first use.
3289 (hi_time, lo_time): New functions, for an accurate test for
3290 out-of-range times.
3291 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3292 (Fget_internal_run_time): Don't assume time_t fits in int.
3293 (make_time): Use list2 instead of Fcons twice.
3294 (Fdecode_time): More accurate test for out-of-range times.
3295 (check_tm_member): New function.
3296 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3297 (lisp_time_argument): Don't rely on undefined left-shift and
3298 right-shift behavior when checking for time stamp overflow.
8be6f318 3299
fe31d94c
PE
3300 * editfns.c (time_overflow): New function, refactoring common code.
3301 (Fformat_time_string, Fdecode_time, Fencode_time):
3302 (Fcurrent_time_string): Use it.
3303
8be6f318
PE
3304 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3305 * dired.c (make_time): Move to ...
3306 * editfns.c (make_time): ... here.
3307 * systime.h: Note the move.
3308
09d9db2c 33092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3310
126bc0dc
YM
3311 * fringe.c (update_window_fringes): Remove unused variables.
3312
c47cbdfd
YM
3313 * unexmacosx.c (copy_data_segment): Also copy __got section.
3314 (Bug#8223)
3315
7ac80be9
EZ
33162011-03-12 Eli Zaretskii <eliz@gnu.org>
3317
c96bbc66 3318 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3319 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3320 Constify `char *' arguments and their references according to
3321 prototypes in tparam.h.
3322
ecb0f94d 3323 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3324
7ac80be9
EZ
3325 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3326 Adapt all references accordingly.
3327
3328 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3329
ef1fd07e
TT
33302011-03-11 Tom Tromey <tromey@redhat.com>
3331
3332 * buffer.c (syms_of_buffer): Remove obsolete comment.
3333
7ef4b50c
EZ
33342011-03-11 Eli Zaretskii <eliz@gnu.org>
3335
3336 * termhooks.h (encode_terminal_code): Declare prototype.
3337
3338 * msdos.c (encode_terminal_code): Don't declare prototype.
3339
3340 * term.c (encode_terminal_code): Now external again, used by
3341 w32console.c and msdos.c.
3342
44f230aa
SM
3343 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3344 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3345
4b1ec863 33462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3347
1714f52b 3348 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3349
4b1ec863
PE
3350 * fringe.c (update_window_fringes): Mark locals as initialized
3351 (Bug#8227).
3352 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3353
524c7aa6
PE
3354 * alloc.c (mark_fringe_data): Move decl from here ...
3355 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3356 to check its interface.
3357 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3358
a5c0af81 3359 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3360 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3361 (fontset_font): Mark local as initialized.
a9a06e0b 3362 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3363
b4716021
PE
3364 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3365
811e9bac 3366 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3367 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3368 (x_own_selection, Fx_disown_selection_internal): Rename locals
3369 to avoid shadowing.
3370 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3371
7e3ab302
PE
3372 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3373 so that the caller can use some name other than gcpro1.
3374 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3375 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3376 (Fx_backspace_delete_keys_p):
3377 Use them to avoid shadowing, and rename vars to avoid shadowing.
3378 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3379 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3380 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3381 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3382 Remove unused locals.
7e3ab302
PE
3383 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3384 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3385 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3386 macros.
f78faa98 3387
e2b13473
PE
3388 * xterm.h (x_mouse_leave): New decl.
3389
77f23912
PE
3390 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3391 Remove unused functions.
cdf4ba58
PE
3392 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3393 (x_calc_absolute_position): Now static.
7411c686 3394 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3395 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3396 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3397 unless they are used.
38d0b34a
PE
3398 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3399 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3400 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3401 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3402 (x_error_catcher, x_connection_closed, x_error_handler):
3403 (x_error_quitter, xembed_send_message, x_iconify_frame):
3404 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3405 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3406 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3407
44f230aa
SM
3408 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3409 Rename or move locals to avoid shadowing.
6b463e58 3410 (tty_defined_color, merge_face_heights): Now static.
5967d051 3411 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3412 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3413 does not deduce is never used uninitialized.
73719eba
PE
3414 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3415 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3416
426994c3 3417 * terminal.c (store_terminal_param): Now static.
5489860b 3418
032f1620 3419 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3420 (set_frame_menubar): Remove unused local.
d4323972 3421 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3422 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3423 since they might point to immutable storage.
281585b0
PE
3424 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3425 since it's unused otherwise.
032f1620 3426
367c19e5 3427 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3428 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3429 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3430 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3431 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3432 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3433 does not deduce are never used uninitialized.
70739cbe 3434
07b48fa9
PE
3435 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3436
8868a238 3437 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3438 * window.c (window_loop, size_window):
3439 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3440
7e5cf297 3441 * window.c (display_buffer): Now static.
d6550a9f
PE
3442 (size_window): Mark variables that gcc -Wuninitialized
3443 does not deduce are never used uninitialized.
a586633d
PE
3444 * window.h (check_all_windows): New decl, to forestall
3445 gcc -Wmissing-prototypes diagnostic.
5b555da1 3446 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3447
f6095868
PE
3448 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3449 shadowing.
3450 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3451 Include <limits.h>.
3452 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3453 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3454 (load_charset_map): Mark variables that gcc -Wuninitialized
3455 does not deduce are never used uninitialized.
53df7c11 3456 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3457
f38b440c
PE
3458 * coding.c (coding_set_source, coding_set_destination):
3459 Use "else { /* comment */ }" rather than "else /* comment */;"
3460 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3461 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3462 a block, when the outer 'i' will do.
3463 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3464 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3465 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3466 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3467 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3468 Rename locals to avoid shadowing.
3469 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3470 * coding.c (emacs_mule_char, encode_invocation_designation):
3471 Now static, since they're not used elsewhere.
413bb2db 3472 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3473 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3474 (decode_coding_emacs_mule): Mark variables that gcc
3475 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3476 (detect_coding_iso_2022): Initialize a local variable that might
3477 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3478 this initialization is needed. (Bug#8211)
5f58e762
PE
3479 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3480 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3481 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3482 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3483 Remove unused macros.
f38b440c 3484
232b38b9 3485 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3486 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3487 * character.c (string_count_byte8): Likewise.
232b38b9 3488
fb90da1b
PE
3489 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3490 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3491
fb93dbc2
PE
3492 * chartab.c (copy_sub_char_table): Now static, since it's not used
3493 elsewhere.
5c156ace
PE
3494 (sub_char_table_ref_and_range, char_table_ref_and_range):
3495 Rename locals to avoid shadowing.
bbcd0949 3496 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3497
7d3b3862 3498 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3499 (BIDI_BOB): Remove unused macro.
7d3b3862 3500
6be7d3da
PE
3501 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3502 deduce are never used uninitialized.
c2ed9c8b 3503 * term.c (encode_terminal_code): Likewise.
6be7d3da 3504
75f8807f 3505 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3506
50938595
PE
3507 * tparam.h: New file.
3508 * term.c, tparam.h: Include it.
3509 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3510 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3511 Move these decls to tparam.h, and make them agree with what
3512 is actually in tparam.c. The previous trick of using incompatible
3513 decls in different modules does not conform to the C standard.
3514 All callers of tparam changed to use tparam's actual API.
3515 * tparam.c (tparam1, tparam, tgoto):
3516 Use const pointers where appropriate.
3517
fbceeba2
PE
3518 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3519 * cm.h (struct cm): Likewise.
3520 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3521 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3522 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3523 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3524 (turn_on_face, init_tty): Likewise.
3525 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3526
7f3f1250
PE
3527 * term.c (term_mouse_position): Rename local to avoid shadowing.
3528
e6ca6543
PE
3529 * alloc.c (mark_ttys): Move decl from here ...
3530 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3531
c40f8d15
AS
35322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3533
3534 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3535
cfe0661d
JB
35362011-03-09 Juanma Barranquero <lekktu@gmail.com>
3537
3538 * search.c (compile_pattern_1): Remove argument regp, unused since
3539 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3540 (compile_pattern): Don't pass it.
3541
0afb4571
J
35422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3543
3544 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3545 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3546 for ! HAVE_GTK3.
3547 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3548
3549 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3550
3551 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3552 gdk_window_get_screen, gdk_window_get_geometry,
3553 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3554 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3555 (xg_get_pixbuf_from_pixmap): New function.
3556 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3557 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3558 Call xg_get_pixbuf_from_pixmap instead of
3559 gdk_pixbuf_get_from_drawable.
3560 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3561 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3562 (xg_check_special_colors): Use GtkStyleContext and its functions
3563 for HAVE_GTK3.
3564 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3565 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3566 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3567 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3568 Call gtk_widget_get_preferred_size.
0afb4571
J
3569 (xg_frame_resized): gdk_window_get_geometry only takes 5
3570 parameters.
44f230aa
SM
3571 (xg_win_to_widget, xg_event_is_for_menubar):
3572 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3573 (xg_set_widget_bg): New function.
3574 (delete_cb): New function.
895009e1 3575 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3576 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3577 (xg_set_background_color): Call xg_set_widget_bg.
3578 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3579 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3580 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3581 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3582 if ! HAVE_GTK3.
3583 (update_frame_tool_bar): Call gtk_widget_hide.
3584 (xg_initialize): Use GDK_KEY_g.
3585
3586 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3587 if ! HAVE_GTK3
3588 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3589
3590 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3591 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3592 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3593
1c2cc4ef
JB
35942011-03-08 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * w32xfns.c (select_palette): Check success of RealizePalette against
3597 GDI_ERROR, not zero.
3598
33383987 3599See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3600
3601;; Local Variables:
3602;; coding: utf-8
aac0c6e3
MR
3603;; End:
3604
33383987 3605 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3606
3607 This file is part of GNU Emacs.
3608
3609 GNU Emacs is free software: you can redistribute it and/or modify
3610 it under the terms of the GNU General Public License as published by
3611 the Free Software Foundation, either version 3 of the License, or
3612 (at your option) any later version.
3613
3614 GNU Emacs is distributed in the hope that it will be useful,
3615 but WITHOUT ANY WARRANTY; without even the implied warranty of
3616 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3617 GNU General Public License for more details.
3618
3619 You should have received a copy of the GNU General Public License
3620 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.