lisp/server.el: Catch quit and close the connection (bug#8942).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cabf1cac
SM
12011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * textprop.c (text_property_stickiness):
4 Obey Vtext_property_default_nonsticky.
5 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6 * w32fns.c (syms_of_w32fns):
7 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8
6e9b2be9
PE
92011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10
11 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
12 This is more efficient than Ffile_directory_p and avoids a minor race.
13
90186c68
LMI
142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
15
7c301272
LMI
16 * buffer.c (Foverlay_put): Say what the return value is
17 (bug#7835).
18
c4f2d8d4
LMI
19 * fileio.c (barf_or_query_if_file_exists): Check first if the file
20 is a directory before asking whether to use the file name
21 (bug#7564).
ad637907
LMI
22 (barf_or_query_if_file_exists): Make the "File is a directory"
23 error be more correct.
c4f2d8d4 24
90186c68
LMI
25 * fns.c (Frequire): Remove the mention of the .gz files, since
26 that's installation-specific, but keep the mention of
27 `get-load-suffixes'.
28
da64016e
PE
292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
30
31 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
32 Report string overflow if the output is too long.
33
7d47b580
JB
342011-07-04 Juanma Barranquero <lekktu@gmail.com>
35
a555cb87
JB
36 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
37 (syms_of_gnutls): Remove duplicate DEFSYM for
38 Qgnutls_bootprop_verify_hostname_error, an error for
39 Qgnutls_bootprop_verify_error (which is no longer used).
40
7d47b580
JB
41 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
42 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
43 Also (re)move comments that are misplaced or no longer relevant.
44
1e49bfab
LMI
452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
46
47 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
48
1485f4c0
CY
492011-07-03 Chong Yidong <cyd@stupidchicken.com>
50
51 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
52 and background color parameters if they have been changed.
53
a9ab721e
LMI
542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
55
56 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
57
cf7cff57
PE
582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
59
2e13213d
PE
60 * xsettings.c (SYSTEM_FONT): Define only when used.
61 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
62
cf7cff57
PE
63 * keymap.c (access_keymap_1): Now static.
64
7a8e04f7
CY
652011-07-02 Chong Yidong <cyd@stupidchicken.com>
66
67 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
68 leave any prefix arg for the up event (Bug#1586).
69
61352f62
LMI
702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
71
69bb1ef7
LMI
72 * lread.c (syms_of_lread): Mention single symbols defined by
73 `defvar' or `defconst' (bug#7154).
74
61352f62 75 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 76 (Frequire): Mention get-load-suffixes.
61352f62 77
28545e04
MR
782011-07-02 Martin Rudalics <rudalics@gmx.at>
79
80 * window.h (window): Remove clone_number slot.
81 * window.c (Fwindow_clone_number, Fset_window_clone_number):
82 Remove.
83 (make_parent_window, make_window, saved_window)
84 (Fset_window_configuration, save_window_save): Don't deal with
85 clone numbers.
86 * buffer.c (Qclone_number): Remove declaration.
87 (sort_overlays, overlay_strings): Don't deal with clone numbers.
88
3349e122
SM
892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
90
91 Add multiple inheritance to keymaps.
92 * keymap.c (Fmake_composed_keymap): New function.
93 (Fset_keymap_parent): Simplify.
94 (fix_submap_inheritance): Remove.
95 (access_keymap_1): New function extracted from access_keymap to handle
96 embedded parents and handle lists of maps.
97 (access_keymap): Use it.
98 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
99 (Fcopy_keymap): Handle embedded parents.
100 (Fcommand_remapping, define_as_prefix): Simplify.
101 (Fkey_binding): Simplify.
102 (syms_of_keymap): Move minibuffer-local-completion-map,
103 minibuffer-local-filename-completion-map,
104 minibuffer-local-must-match-map, and
105 minibuffer-local-filename-must-match-map to Elisp.
106 (syms_of_keymap): Defsubr make-composed-keymap.
107 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
108 (parse_menu_item): Trivial simplification.
109
3279eb87
GM
1102011-07-01 Glenn Morris <rgm@gnu.org>
111
112 * Makefile.in (SETTINGS_LIBS): Fix typo.
113
4550efdf
KI
1142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
115
116 * coding.c (Fencode_coding_string): Record the last coding system
117 used, as the function doc string says (bug#8738).
118
0949d2b6
JD
1192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
120
121 * xsettings.c (store_monospaced_changed): Take new font as arg and
122 check for change against current_mono_font.
123 (EMACS_TYPE_SETTINGS): Remove this and related defines.
124 (emacs_settings_constructor, emacs_settings_get_property)
125 (emacs_settings_set_property, emacs_settings_class_init)
126 (emacs_settings_init, gsettings_obj): Remove.
127 (something_changedCB): New function for HAVE_GSETTINGS.
128 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
129 with value as argument.
130 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
131 g_settings_new (Bug#8967). Do not create gsettings_obj.
132 Remove calls to g_settings_bind. Connect something_changedCB to
133 "changed".
134
135 * xgselect.c: Add defined (HAVE_GSETTINGS).
136 (xgselect_initialize): Ditto.
137
138 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
139 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
140 xg_select.
141
bbc6b304
PE
1422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
143
144 * eval.c (struct backtrace): Simplify and port the data structure.
145 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
146 signed bit field, as this assumption is not portable and it makes
147 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
148 "char debug_on_exit : 1" as this is not portable either; instead,
149 use the portable "unsigned int debug_on_exit : 1". Remove unused
150 member evalargs. Remove obsolete comments about cc bombing out.
151
9851bfc5
JD
1522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
153
51bb811f 154 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
155 Let HAVE_GSETTINGS override HAVE_GCONF.
156 (store_monospaced_changed): New function.
157 (EMACS_SETTINGS): A new type derived from GObject to handle
158 GSettings notifications.
159 (emacs_settings_constructor, emacs_settings_get_property)
160 (emacs_settings_set_property, emacs_settings_class_init):
161 New functions.
162 (gsettings_client, gsettings_obj): New variables.
163 (GSETTINGS_SCHEMA): New define.
164 (something_changedCB): Call store_monospaced_changed.
165 (init_gsettings): New function.
166 (xsettings_initialize): Call init_gsettings.
167 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
168 to NULL.
169
170 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
171 GCONF_CFLAGS/LIBS.
172
5386012d
MR
1732011-06-29 Martin Rudalics <rudalics@gmx.at>
174
175 * window.c (resize_root_window, grow_mini_window)
176 (shrink_mini_window): Rename Qresize_root_window to
177 Qwindow_resize_root_window and Qresize_root_window_vertically to
178 Qwindow_resize_root_window_vertically.
179
f13e0b08
PE
1802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
181
182 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
183
94515237
JB
1842011-06-27 Juanma Barranquero <lekktu@gmail.com>
185
186 * makefile.w32-in: Redesign dependencies so they reflect more
187 clearly which files are directly included by each source file,
188 and not through other includes.
189
e43b6e43
MR
1902011-06-27 Martin Rudalics <rudalics@gmx.at>
191
192 * buffer.c (Qclone_number): Declare static and DEFSYM it.
193 (sort_overlays, overlay_strings): When an overlay's clone number
194 matches the window's clone number process the overlay even if
195 the overlay's window property doesn't match the current window.
196
d68443dc
MR
197 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
198 (Fwindow_hchild): Rename to Fwindow_left_child.
199 (Fwindow_next): Rename to Fwindow_next_sibling.
200 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
201 (resize_window_check): Rename to window_resize_check.
202 (resize_window_apply): Rename to window_resize_apply.
203 (Fresize_window_apply): Rename to Fwindow_resize_apply.
204 (Fdelete_other_windows_internal, resize_frame_windows)
205 (Fsplit_window_internal, Fdelete_window_internal)
206 (grow_mini_window, shrink_mini_window)
207 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 208
c7e73be5
JD
2092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
210
211 * emacsgtkfixed.h: State that this is only used with Gtk+3.
212 (emacs_fixed_set_min_size): Remove.
213 (emacs_fixed_new): Take frame as argument.
214
215 * emacsgtkfixed.c: State that this is only used with Gtk+3.
216 (_EmacsFixedPrivate): Remove minwidth/height.
217 Add struct frame *f.
218 (emacs_fixed_init): Initialize priv->f.
219 (get_parent_class, emacs_fixed_set_min_size): Remove.
220 (emacs_fixed_new): Set priv->f to argument.
221 (emacs_fixed_get_preferred_width)
222 (emacs_fixed_get_preferred_height): Use min_width/height from
223 frames size_hint to set minimum and natural (Bug#8919).
224 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
225 and use min_width/height from frames size_hint to set
226 min_width/height (Bug#8919).
227
228 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
229 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
230 indentation.
231
cf99dcf8
EZ
2322011-06-26 Eli Zaretskii <eliz@gnu.org>
233
234 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
235 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
236 called at ZV.
237
029529ac
CY
2382011-06-26 Chong Yidong <cyd@stupidchicken.com>
239
240 * process.c (wait_reading_process_output): Bypass select if
241 waiting for a cell while ignoring keyboard input, and input is
242 pending. Suggested by Jan Djärv (Bug#8869).
243
7a7ef429
PE
2442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
245
246 Use gnulib's dup2 module instead of rolling our own.
247 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
248
11fdef7d 2492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
250
251 * dispnew.c (scrolling_window): Before scrolling, turn off a
252 mouse-highlight in the window being scrolled.
253
cd3520a4
JB
2542011-06-24 Juanma Barranquero <lekktu@gmail.com>
255
256 Move DEFSYM to lisp.h and use everywhere.
257
258 * character.h (DEFSYM): Move declaration...
259 * lisp.h (DEFSYM): ...here.
260
261 * gnutls.c:
262 * minibuf.c:
263 * w32menu.c:
264 * w32proc.c:
265 * w32select.c: Don't include character.h.
266
267 * alloc.c (syms_of_alloc):
268 * buffer.c (syms_of_buffer):
269 * bytecode.c (syms_of_bytecode):
270 * callint.c (syms_of_callint):
271 * casefiddle.c (syms_of_casefiddle):
272 * casetab.c (init_casetab_once):
273 * category.c (init_category_once, syms_of_category):
274 * ccl.c (syms_of_ccl):
275 * cmds.c (syms_of_cmds):
276 * composite.c (syms_of_composite):
277 * dbusbind.c (syms_of_dbusbind):
278 * dired.c (syms_of_dired):
279 * dispnew.c (syms_of_display):
280 * doc.c (syms_of_doc):
281 * editfns.c (syms_of_editfns):
282 * emacs.c (syms_of_emacs):
283 * eval.c (syms_of_eval):
284 * fileio.c (syms_of_fileio):
285 * fns.c (syms_of_fns):
286 * frame.c (syms_of_frame):
287 * fringe.c (syms_of_fringe):
288 * insdel.c (syms_of_insdel):
289 * keymap.c (syms_of_keymap):
290 * lread.c (init_obarray, syms_of_lread):
291 * macros.c (syms_of_macros):
292 * msdos.c (syms_of_msdos):
293 * print.c (syms_of_print):
294 * process.c (syms_of_process):
295 * search.c (syms_of_search):
296 * sound.c (syms_of_sound):
297 * syntax.c (init_syntax_once, syms_of_syntax):
298 * terminal.c (syms_of_terminal):
299 * textprop.c (syms_of_textprop):
300 * undo.c (syms_of_undo):
301 * w32.c (globals_of_w32):
302 * window.c (syms_of_window):
303 * xdisp.c (syms_of_xdisp):
304 * xfaces.c (syms_of_xfaces):
305 * xfns.c (syms_of_xfns):
306 * xmenu.c (syms_of_xmenu):
307 * xsettings.c (syms_of_xsettings):
308 * xterm.c (syms_of_xterm): Use DEFSYM.
309
4228cf16
TZ
3102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
311
cd3520a4 312 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 313
7fcccf1e
PE
3142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
315
7efb4e0e
PE
316 Integer and buffer overflow fixes (Bug#8873).
317
ff5844ad
PE
318 * print.c (printchar, strout): Check for string overflow.
319 (PRINTPREPARE, printchar, strout):
320 Don't set size unless allocation succeeds.
321
90532f02
PE
322 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
323 for sizes. Check for string overflow more accurately.
324 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
325
6d84508d
PE
326 * macros.c: Integer and buffer overflow fixes.
327 * keyboard.h (struct keyboard.kbd_macro_bufsize):
328 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
329 Use ptrdiff_t, not int, for sizes.
330 Don't increment bufsize until after realloc succeeds.
331 Check for size-calculation overflow.
332 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
333
437b2cb4
PE
334 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
335
8b9ac8b4
PE
336 * lread.c: Integer overflow fixes.
337 (read_integer): Radix is now EMACS_INT, not int,
338 to improve quality of diagnostics for out-of-range radices.
339 Calculate buffer size correctly for out-of-range radices.
340 (read1): Check for integer overflow in radices, and in
341 read-circle numbers.
82cb60d3
PE
342 (read_escape): Avoid int overflow.
343 (Fload, openp, read_buffer_size, read1)
344 (substitute_object_recurse, read_vector, read_list, map_obarray):
345 Use ptrdiff_t, not int, for sizes.
346 (read1): Use EMACS_INT, not int, for sizes.
20270765 347 Check for size overflow.
8b9ac8b4 348
7fcccf1e
PE
349 * image.c (cache_image): Check for size arithmetic overflow.
350
bfbbd7e7
PE
351 * lread.c: Integer overflow issues.
352 (saved_doc_string_size, saved_doc_string_length)
353 (prev_saved_doc_string_size, prev_saved_doc_string_length):
354 Now ptrdiff_t, not int.
355 (read1): Don't assume doc string length fits in int. Check for
356 out-of-range doc string lengths.
357 (read_list): Don't assume file position fits in int.
39019e54 358 (read_escape): Check for hex character overflow.
bfbbd7e7 359
4e323265
LL
3602011-06-22 Leo Liu <sdl.web@gmail.com>
361
362 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
363 Move to minibuffer.el.
364
85fece3e
PE
3652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
366
20b84ce9 367 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
368 The following patches are for when GLYPH_DEBUG && !XASSERT.
369 * dispextern.h (trace_redisplay_p, dump_glyph_string):
370 * dispnew.c (flush_stdout):
371 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
372 Mark as externally visible.
373 * dispnew.c (check_window_matrix_pointers): Now static.
374 * dispnew.c (window_to_frame_vpos):
375 * xfns.c (unwind_create_frame):
376 * xterm.c (x_check_font): Remove unused local.
377 * scroll.c (CHECK_BOUNDS):
378 * xfaces.c (cache_fache): Rename local to avoid shadowing.
379 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
380 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
381 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
382 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
383 Now static.
384 (debug_method_add): Use va_list and vsprintf rather than relying
385 on undefined behavior with wrong number of arguments.
386 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
387 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
388 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
389 since we're not interested in debugging glyphs with old libraries.
390 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
391 GCC 4.6.0's static checking.
392
0766b489
PE
3932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
394
31fd4b32
PE
395 Integer overflow and signedness fixes (Bug#8873).
396 A few related buffer overrun fixes, too.
397
b79e8648
PE
398 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
399
0766b489
PE
400 * dispextern.h (struct face.stipple):
401 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
402 (x_bitmap_mask, x_allocate_bitmap_record)
403 (x_create_bitmap_from_data, x_create_bitmap_from_file)
404 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
405 (x_create_bitmap_from_xpm_data):
406 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
407 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
408 (.bitmaps_last):
409 * xfaces.c (load_pixmap):
410 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
411 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
412 (.bitmaps_last, struct x_output.icon_bitmap):
413 Use ptrdiff_t, not int, for bitmap indexes.
414 (x_allocate_bitmap_record): Check for size overflow.
415 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
416
b081724f
PE
417 Use ptrdiff_t, not int, for overlay counts.
418 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
419 * editfns.c (overlays_around, get_pos_property):
420 * textprop.c (get_char_property_and_overlay):
421 * xdisp.c (next_overlay_change, note_mouse_highlight):
422 * xfaces.c (face_at_buffer_position):
21514da7
PE
423 * buffer.c (OVERLAY_COUNT_MAX): New macro.
424 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
425 (Fnext_overlay_change, Fprevious_overlay_change)
426 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 427 Use ptrdiff_t, not int, for sizes.
21514da7 428 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 429
3de73e5e
PE
430 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
431
2606c57b
PE
432 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
433 (x_session_initialize): Do not assume string length fits in int.
434
aaafe47a
PE
435 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
436 This is unlikely, but can occur if DPI is outlandish.
437
2674ddc8 438 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
439 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
440
28154962
PE
441 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
442 * xrdb.c (magic_file_p, search_magic_path):
443 Omit last arg SUFFIX; it was always 0. All callers changed.
444 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
445
7de51af5
PE
446 * xfont.c (xfont_match): Avoid need for strlen.
447
25ed6cc3
PE
448 * xfns.c: Don't assume strlen fits in int.
449 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
450
4eab31dd
PE
451 * xdisp.c (message_log_check_duplicate): Return intmax_t,
452 not unsigned long, as we prefer signed integers. All callers changed.
453 Detect integer overflow in repeat count.
454 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 455 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 456
171e2a58
PE
457 * termcap.c: Don't assume sizes fit in int and never overflow.
458 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
459 (gobble_line): Check for size-calculation overflow.
460
ad39faca 461 * minibuf.c (Fread_buffer):
6e5bb2dc 462 * lread.c (intern, intern_c_string):
74ca2eb3
PE
463 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
464 Don't assume string length fits in int.
465
52c61c22 466 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
467 * gtkutil.c (style_changed_cb): Avoid need for strlen.
468
b5b8c9e5
PE
469 * font.c: Don't assume string length fits in int.
470 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
471 Use ptrdiff_t, not int.
ccd6111c
PE
472 (font_intern_prop): Don't assume string length fits in int.
473 Don't assume integer property fits in fixnum.
474 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 475
882f0d81 476 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 477 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
478 Reformulate so as not to need the command string.
479 Invoke gzip -cd rather than gunzip, as it's more portable.
480 (lock_info_type, lock_file_1, lock_file):
481 Don't assume pid_t and time_t fit in unsigned long.
482 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
483 (current_lock_owner): Prefer signed type for sizes.
484 Use memcpy, not strncpy, where memcpy is what is really wanted.
485 Don't assume (via atoi) that time_t and pid_t fit in int.
486 Check for time_t and/or pid_t out of range, e.g., via a network share.
487 Don't alloca where an auto var works fine.
488
93f4cf88
PE
489 * fileio.c: Fix some integer overflow issues.
490 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
491 Don't assume string length fits in int.
492 (directory_file_name): Don't assume string length fits in long.
493 (make_temp_name): Don't assume pid fits in int, or that its print
494 length is less than 20.
495
f3e92b69
PE
496 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
497
1bfdaf10
PE
498 * coding.c (make_subsidiaries): Don't assume string length fits in int.
499
35016e9a
PE
500 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
501
3d1e65a1
PE
502 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
503 We prefer signed integers, even for size calculations.
504
0b963a93
PE
505 * emacs.c: Don't assume string length fits in 'int'.
506 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
507 (main): Don't invoke strlen when not needed.
508
573f4b54
PE
509 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
510 (XD_DEBUG_MESSAGE): Don't waste a byte.
511
989f33ba
PE
512 * callproc.c (getenv_internal_1, getenv_internal)
513 (Fgetenv_internal):
965d34eb
PE
514 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
515
e4d29b33
PE
516 * lread.c (invalid_syntax): Omit length argument.
517 All uses changed. This doesn't fix a bug, but it simplifies the
518 code away from its former Hollerith-constant appearance, and it's
519 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 520 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 521
eb49b136
PE
522 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
523 This didn't break anything, but it didn't help either.
524 It's confusing to put a bogus integer in a place where the actual
525 value does not matter.
9f62aeb1 526 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 527 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 528
15375a22
PE
529 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
530 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
531 implementation.
b61cc01c
PE
532 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
533 We prefer signed types, and the value cannot exceed the EMACS_INT
534 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
535 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
536 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
537 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 538
53b2623d
PE
539 * indent.c (sane_tab_width): New function.
540 (current_column, scan_for_column, Findent_to, position_indentation)
541 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 542 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 543
51cab52b 544 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 545
f2ed8a70
PE
546 * lisp.h (lint_assume): New macro.
547 * composite.c (composition_gstring_put_cache):
548 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
549
abe80cc6
PE
550 * editfns.c, insdel.c:
551 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 552
b02c740e
PE
553 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
554
ebc96716
PE
555 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
556
b4e50fa0 557 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 558 Use much-faster test for byte-length change.
311d5d7c 559 Don't assume string byte-length fits in 'int'.
a4cf38e4 560 Check that character arg fits in 'int'.
85461888 561 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 562
c0c1ee9f
PE
563 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
564
a498d7f4
PE
565 * fns.c (concat): Catch string overflow earlier.
566 Do not rely on integer wraparound.
567
51cab52b
PE
568 * dispextern.h (struct it.overlay_strings_charpos)
569 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
570 * xdisp.c (forward_to_next_line_start)
571 (back_to_previous_visible_line_start)
572 (reseat_at_next_visible_line_start, next_element_from_buffer):
573 Don't arbitrarily truncate the value of 'selective' to int.
574
76031fad
PE
575 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
576
5eb55db9
PE
577 * composite.c: Don't truncate sizes to 'int'.
578 (composition_gstring_p, composition_reseat_it)
579 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
580 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
581 not EMACS_UINT, for indexes.
5eb55db9 582
0703a717
PE
583 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
584
d6202519
PE
585 * buffer.c: Include <verify.h>.
586 (struct sortvec.priority, struct sortstr.priority):
8961a454 587 Now EMACS_INT, not int.
c20998a7 588 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
589 (struct sortstr.size, record_overlay_string)
590 (struct sortstrlist.size, struct sortlist.used):
591 Don't truncate size to int.
592 (record_overlay_string): Check for size-calculation overflow.
d6202519 593 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 594
d5a19415
JM
5952011-06-22 Jim Meyering <meyering@redhat.com>
596
029529ac 597 Don't leak an XBM-image-sized buffer
d5a19415
JM
598 * image.c (xbm_load): Free the image buffer after using it.
599
a9041e6c
PE
6002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
601
602 Port to Sun C.
603 * composite.c (find_automatic_composition): Omit needless 'return 0;'
604 that Sun C diagnosed.
605 * fns.c (secure_hash): Fix pointer signedness issue.
606 * intervals.c (static_offset_intervals): New function.
607 (offset_intervals): Use it.
608
7f3f739f
LL
6092011-06-21 Leo Liu <sdl.web@gmail.com>
610
611 * deps.mk (fns.o):
612 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
613 sha512.h.
614
615 * fns.c (secure_hash): Rename from crypto_hash_function and change
616 the first arg to accept symbols.
5b66d427 617 (Fsecure_hash): New primitive.
7f3f739f
LL
618 (syms_of_fns): New symbols.
619
76147d94
DD
6202011-06-20 Deniz Dogan <deniz@dogan.se>
621
622 * process.c (Fset_process_buffer): Clarify return value in
623 docstring.
624
7d7d0045
CY
6252011-06-18 Chong Yidong <cyd@stupidchicken.com>
626
627 * dispnew.c (add_window_display_history): Use BVAR.
628
629 * xdisp.c (debug_method_add): Use BVAR.
630 (check_window_end, dump_glyph_matrix, dump_glyph)
631 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
632
633 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
634 Likewise.
635
636 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
637 check till after the cache is created in init_frame_faces.
638
ff2bc410
SM
6392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
640
641 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
642
28177add
PE
6432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
644
dd3482fe
PE
645 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
646 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
647 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
648
393d71f3 649 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
650 * fileio.c (Finsert_file_contents):
651 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
652 Remove the old (too-loose) buffer overflow checks.
653 They weren't needed, since make_gap checks for buffer overflow.
654 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
655 The old code merely checked for Emacs fixnum overflow, and relied
656 on undefined (wraparound) behavior. The new code avoids undefined
657 behavior, and also checks for ptrdiff_t and/or size_t overflow.
658
2e6813b0 659 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
660 Tune. Don't use wider integers than needed. Don't use alloca.
661 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 662
599a9e4f
PE
663 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
664
99561444
PE
665 * insdel.c, lisp.h (buffer_overflow): New function.
666 (insert_from_buffer_1, replace_range, replace_range_2):
667 * insdel.c (make_gap_larger):
668 * editfns.c (Finsert_char):
669 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
670
28177add
PE
671 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
672
e69dafad
PE
6732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
674
a7af7fde 675 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 676
b1c46f02
PE
677 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
678 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
679
e69dafad
PE
680 * fileio.c: Don't assume EMACS_INT fits in off_t.
681 (emacs_lseek): New static function.
682 (Finsert_file_contents, Fwrite_region): Use it.
683 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
684
566684ea
PE
685 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
686
e6966cd6
PE
687 * fns.c: Don't overflow int when computing a list length.
688 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
689 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
690 truncation on 64-bit hosts. Check for QUIT every
691 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
692 faster and is responsive enough.
693 (Flength): Report an error instead of overflowing an integer.
694 (Fsafe_length): Return a float if the value is not representable
695 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 696 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 697 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 698
dd0b0efb
PE
699 * alloc.c: Check that resized vectors' lengths fit in fixnums.
700 (header_size, word_size): New constants.
701 (allocate_vectorlike): Don't check size overflow here.
702 (allocate_vector): Check it here instead, since this is the only
703 caller of allocate_vectorlike that could cause overflow.
704 Check that the new vector's length is representable as a fixnum.
705
86fe5cfe
PE
706 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
707 The previous code was bogus. For example, next_almost_prime (32)
708 returned 39, which is undesirable as it is a multiple of 3; and
709 next_almost_prime (24) returned 25, which is a multiple of 5 so
710 why was the code bothering to check for multiples of 7?
711
80e88859
PE
712 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
713
4a2f0ad6
PE
714 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
715
f66c7cf8
PE
716 Variadic C functions now count arguments with ptrdiff_t.
717 This partly undoes my 2011-03-30 change, which replaced int with size_t.
718 Back then I didn't know that the Emacs coding style prefers signed int.
719 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
720 were being counted with int, which may truncate counts on 64-bit
721 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
722 * lisp.h (struct Lisp_Subr.function.aMANY)
723 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
724 Arg counts are now ptrdiff_t, not size_t.
725 All variadic functions and their callers changed accordingly.
726 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
727 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
728 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
729 * callint.c (Fcall_interactively): Check arg count for overflow,
730 to avoid potential buffer overrun. Use signed char, not 'int',
731 for 'varies' array, so that we needn't bother to check its size
732 calculation for overflow.
733 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
734 * eval.c (apply_lambda):
735 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
736 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
737 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
738
a1759b76
PE
739 * callint.c (Fcall_interactively): Don't use index var as event count.
740
d96be9fc
PE
741 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
742 * mem-limits.h (SIZE): Remove; no longer used.
743
a690a978 744 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 745
578c21e6
PE
746 Remove unnecessary casts.
747 * xterm.c (x_term_init):
748 * xfns.c (x_set_border_pixel):
749 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
750 These aren't needed now that we assume ANSI C.
751
96f53c6c
PE
752 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
753 It's more likely to cause problems (due to unsigned overflow)
754 than to cure them.
755
83c77d31
PE
756 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
757
ee2079f1
PE
758 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
759
6da65536
PE
760 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
761
7147c4a4
PE
762 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
763
193e32d9
PE
764 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
765
e5533da6
PE
766 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
767
9910e595
PE
768 GLYPH_CODE_FACE returns EMACS_INT, not int.
769 * dispextern.h (merge_faces):
770 * xfaces.c (merge_faces):
01103c44
PE
771 * xdisp.c (get_next_display_element, next_element_from_display_vector):
772 Don't assume EMACS_INT fits in int.
9910e595 773
2638320e
PE
774 * character.h (CHAR_VALID_P): Remove unused parameter.
775 * fontset.c, lisp.h, xdisp.c: All uses changed.
776
045eb8d9
PE
777 * editfns.c (Ftranslate_region_internal): Omit redundant test.
778
c1f134b5
PE
779 * fns.c (concat): Minor tuning based on overflow analysis.
780 This doesn't fix any bugs. Use int to hold character, instead
781 of constantly refetching from Emacs object. Use XFASTINT, not
782 XINT, for value known to be a character. Don't bother comparing
783 a single byte to 0400, as it's always less.
784
395fcb93 785 * floatfns.c (Fexpt):
327eeec8
PE
786 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
787
abbd3d23
PE
788 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
789 for characters.
790
684a03ef
PE
791 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
792
0fed43f3
PE
793 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
794 Without this fix, on a 64-bit host (aset S 0 4294967386) would
795 incorrectly succeed when S was a string, because 4294967386 was
796 truncated before it was used.
797
8fd02eb7
PE
798 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
799 Otherwise, an out-of-range integer could cause undefined behavior
800 on a 64-bit host.
801
f8c86b69
PE
802 * composite.c: Use int, not EMACS_INT, for characters.
803 (fill_gstring_body, composition_compute_stop_pos): Use int, not
804 EMACS_INT, for values that are known to be in character range.
805 This doesn't fix any bugs but is the usual style inside Emacs and
806 may generate better code on 32-bit machines.
807
34206dd2
PE
808 Make sure a 64-bit char is never passed to ENCODE_CHAR.
809 This is for reasons similar to the recent CHAR_STRING fix.
810 * charset.c (Fencode_char): Check that character arg is actually
811 a character. Pass an int to ENCODE_CHAR.
812 * charset.h (ENCODE_CHAR): Verify that the character argument is no
813 wider than 'int', as a compile-time check to prevent future regressions
814 in this area.
815
c5958d4c 816 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
817
818 Make sure a 64-bit char is never passed to CHAR_STRING.
819 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
820 by silently ignoring the top 32 bits, allowing some values
821 that were far too large to be valid characters.
822 * character.h: Include <verify.h>.
823 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
824 arguments are no wider than unsigned, as a compile-time check
825 to prevent future regressions in this area.
826 * data.c (Faset):
01103c44 827 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
828 (Fsubst_char_in_region):
829 * fns.c (concat):
830 * xdisp.c (decode_mode_spec_coding):
831 Adjust to CHAR_STRING's new requirement.
832 * editfns.c (Finsert_char, Fsubst_char_in_region):
833 * fns.c (concat): Check that character args are actually
834 characters. Without this test, these functions did the wrong
835 thing with wildly out-of-range values on 64-bit hosts.
836
d37ca623
PE
837 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
838 These casts should not be needed on 32-bit hosts, either.
839 * keyboard.c (read_char):
840 * lread.c (Fload): Remove casts to unsigned.
841
ea204efb
PE
842 * lisp.h (UNSIGNED_CMP): New macro.
843 This fixes comparison bugs on 64-bit hosts.
844 (ASCII_CHAR_P): Use it.
845 * casefiddle.c (casify_object):
01103c44 846 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
847 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
848 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
849 * dispextern.h (FACE_FROM_ID):
850 * keyboard.c (read_char): Use UNSIGNED_CMP.
851
41cb286c
PE
852 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
853 not to EMACS_INT, to avoid GCC warning.
854
4a1b9832
PE
855 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
856
55daad71
PE
857 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
858 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
859 isn't needed on 32-bit machines.
8f95c75c 860
01103c44
PE
861 * buffer.c (Fgenerate_new_buffer_name):
862 Use EMACS_INT for count, not int.
0ceccced 863 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
864
865 * data.c (Qcompiled_function): Now static.
866
c6f072e7
PE
867 * window.c (window_body_lines): Now static.
868
20ce5912
PE
869 * image.c (gif_load): Rename local to avoid shadowing.
870
9c4c5f81
PE
871 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
872 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
873 * alloc.c (make_save_value): Integer argument is now of type
874 ptrdiff_t, not int.
875 (mark_object): Use ptrdiff_t, not int.
876 * lisp.h (pD): New macro.
877 * print.c (print_object): Use it.
878
c0c5c8ae
PE
879 * alloc.c: Use EMACS_INT, not int, to count objects.
880 (total_conses, total_markers, total_symbols, total_vector_size)
881 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
882 (total_free_floats, total_floats, total_free_intervals)
883 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
884 Now EMACS_INT, not int. All uses changed.
885 (Fgarbage_collect): Compute overall total using a double, so that
886 integer overflow is less likely to be a problem. Check for overflow
887 when converting back to an integer.
5a25e253
PE
888 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
889 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
890 These were 'int' variables that could overflow on 64-bit hosts;
891 they were never used, so remove them instead of repairing them.
211a0b2a 892 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
893 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
894 Previously, this ceilinged at INT_MAX, but that doesn't work on
895 64-bit machines.
e46bb31a 896 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 897
c78baabf 898 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 899 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
900 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
901 when a (possibly-narrower) signed value would do just as well.
902 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 903
c9d624c6
PE
904 * alloc.c: Catch some string size overflows that we were missing.
905 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
906 for convenience in STRING_BYTES_MAX.
907 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
908 The definition here is exact; the one in lisp.h was approximate.
909 (allocate_string_data): Check for string overflow. This catches
910 some instances we weren't catching before. Also, it catches
911 size_t overflow on (unusual) hosts where SIZE_MAX <= min
912 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
913 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 914
c9d624c6
PE
915 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
916 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
917 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
918
353032ce
PE
919 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
920
2bccce07
PE
921 * alloc.c (Fmake_string): Check for out-of-range init.
922
0ac30604
SM
9232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
924
925 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
926
c195f2de
JD
9272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
928
929 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
930 xg_get_default_scrollbar_width.
931
932 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
933 (int_gtk_range_get_value): Move to the scroll bar part of the file.
934 (style_changed_cb): Call update_theme_scrollbar_width and call
935 x_set_scroll_bar_default_width and xg_frame_set_char_size for
936 all frames (Bug#8505).
937 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
938 Call gtk_window_set_resizable if HAVE_GTK3.
939 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
940 and height if HAVE_GTK3 (Bug#8505).
941 (scroll_bar_width_for_theme): New variable.
942 (update_theme_scrollbar_width): New function.
943 (xg_get_default_scrollbar_width): Move code to
944 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
945 (xg_initialize): Call update_theme_scrollbar_width.
946
947 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
948
949 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
950
e10ac9f1
MR
9512011-06-12 Martin Rudalics <rudalics@gmx.at>
952
953 * frame.c (make_frame): Call other_buffer_safely instead of
954 other_buffer.
955
956 * window.c (temp_output_buffer_show): Call display_buffer with
957 second argument Vtemp_buffer_show_specifiers and reset latter
958 immediately after the call.
959 (Vtemp_buffer_show_specifiers): New variable.
960 (auto_window_vscroll_p, next_screen_context_lines)
961 (Vscroll_preserve_screen_position): Remove leading asterisks from
962 doc-strings.
963
2d3c217e 9642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 965
7b7f97e8 966 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
967 * buffer.c (Qclone_number): Remove for now, as it's unused.
968 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
969 (record_buffer): Remove unused local.
970 * frame.c (other_visible_frames, frame_buffer_list): Now static.
971 (set_frame_buffer_list): Remove; unused.
972 * frame.h (other_visible_frames): Remove decl.
973 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
974 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
975 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
976 if HAVE_GPM.
977 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
978 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
979 Define only if HAVE_GPM.
980 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
981 (update_hints_inhibit): Remove; never set. All uses removed.
982 * widgetprv.h (emacsFrameClassRec): Remove decl.
983 * window.c (delete_deletable_window): Now returns void, since it
984 wasn't returning anything.
985 (compare_window_configurations): Remove unused locals.
986 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
987 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
988 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
989 the same widths as pointers. This follows up on the 2011-05-06 patch.
990 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
991 * xterm.h: Likewise.
992 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
993
1384b89e
JB
9942011-06-12 Juanma Barranquero <lekktu@gmail.com>
995
996 * makefile.w32-in: Update dependencies.
997 (LISP_H): Add lib/intprops.h.
998
1100a63c
CY
9992011-06-11 Chong Yidong <cyd@stupidchicken.com>
1000
1001 * image.c (gif_load): Add animation frame delay to the metadata.
1002 (syms_of_image): Use DEFSYM. New symbol `delay'.
1003
6198ccd0
MR
10042011-06-11 Martin Rudalics <rudalics@gmx.at>
1005
1006 * window.c (delete_deletable_window): Re-add.
1007 (Fset_window_configuration): Rewrite to handle dead buffers and
1008 consequently deletable windows.
1009 (window_tree, Fwindow_tree): Remove. Supply functionality in
1010 window.el.
1011 (compare_window_configurations): Simplify code.
1012
b6e3633c
AS
10132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1014
1ab0dee5
AS
1015 * image.c (imagemagick_load_image): Fix type mismatch.
1016 (Fimagemagick_types): Likewise.
1017
b6e3633c
AS
1018 * window.h (replace_buffer_in_windows): Declare.
1019
9397e56f
MR
10202011-06-11 Martin Rudalics <rudalics@gmx.at>
1021
1022 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1023 Qclone_number. Remove external declaration of Qdelete_window.
1024 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1025 code.
1026 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1027 Qbuffer_list_update_hook if allowed.
1028 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1029 buffer list implementation.
1030 (other_buffer_safely): New function.
1031 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1032 calls to replace_buffer_in_windows and
1033 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1034 if allowed.
1035 (record_buffer): Inhibit quitting and rewrite using quittable
1036 functions. Run Qbuffer_list_update_hook if allowed.
1037 (Frecord_buffer, Funrecord_buffer): New functions.
1038 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1039 switch-to-buffer to window.el.
1040 (bury-buffer): Move to window.el.
1041 (Vbuffer_list_update_hook): New variable.
1042
1043 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1044 section.
1045
1046 * window.h (resize_frame_windows): Move up in code.
1047 (Fwindow_frame): Remove EXFUN.
1048 (replace_buffer_in_all_windows): Remove prototype.
1049 (replace_buffer_in_windows_safely): Add prototype.
1050
1051 * window.c: Declare Qdelete_window static again. Move down
1052 declaration of select_count.
1053 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1054 (Fother_window): Move to window.el.
1055 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1056 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1057 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1058 window.el.
1059 (replace_buffer_in_windows): Implement by calling
1060 Qreplace_buffer_in_windows.
1061 (replace_buffer_in_all_windows): Remove with some functionality
1062 moved into replace_buffer_in_windows_safely.
1063 (replace_buffer_in_windows_safely): New function.
1064 (select_window_norecord, select_frame_norecord): Move in front
1065 of run_window_configuration_change_hook. Remove now obsolete
1066 declarations.
1067 (Fset_window_buffer): Rewrite doc-string. Call
1068 Qrecord_window_buffer.
1069 (keys_of_window): Move binding for other-window to window.el.
1070
b50691aa
CY
10712011-06-11 Chong Yidong <cyd@stupidchicken.com>
1072
1073 * dispextern.h (struct image): Replace data member, whose int_val
1074 and ptr_val fields were not used by anything, with a single
1075 lisp_val object.
1076
1077 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1078 (gif_clear_image, gif_load, imagemagick_load_image)
1079 (gs_clear_image, gs_load): Callers changed.
1080
3f754b86
PE
10812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1082
cca69397
PE
1083 * buffer.h: Include <time.h>, for time_t.
1084 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1085
109e28d0
PE
1086 Fix minor problems found by static checking.
1087
60737f02
PE
1088 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1089
4b66faf3
PE
1090 Make identifiers static if they are not used in other modules.
1091 * data.c (Qcompiled_function, Qframe, Qvector):
1092 * image.c (QimageMagick, Qsvg):
1093 * minibuf.c (Qmetadata):
1094 * window.c (resize_window_check, resize_root_window): Now static.
1095 * window.h (resize_window_check, resize_root_window): Remove decls.
1096
109e28d0
PE
1097 * window.c (window_deletion_count, delete_deletable_window):
1098 Remove; unused.
46a4ce9e
PE
1099 (window_body_lines): Now static.
1100 (Fdelete_other_windows_internal): Mark vars as initialized.
1101 Make sure 'resize_failed' is initialized.
1102 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1103 (resize_window_apply): Remove unused local.
1104 * window.h (delete_deletable_window): Remove decl.
1105
109e28d0 1106 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1107 (imagemagick_load_image): Fix pointer signedness problem by changing
1108 last arg from unsigned char * to char *. All uses changed.
1109 Also, fix a local for similar reasons.
1110 Remove unused locals. Remove locals to avoid shadowing.
1111 (fn_rsvg_handle_free): Remove; unused.
1112 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1113 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1114
3f754b86
PE
1115 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1116
2547adb1
CY
11172011-06-10 Chong Yidong <cyd@stupidchicken.com>
1118
1119 * image.c (gif_load): Fix omitted cast error introduced by
1120 2011-06-06 change.
1121
2c8e37d4
MR
11222011-06-10 Martin Rudalics <rudalics@gmx.at>
1123
1124 * window.h (resize_proportionally, orig_total_lines)
1125 (orig_top_line): Remove from window structure.
1126 (set_window_height, set_window_width, change_window_heights)
1127 (Fdelete_window): Remove prototypes.
1128 (resize_frame_windows): Remove duplicate declaration.
1129
440a42e3
EZ
11302011-06-10 Eli Zaretskii <eliz@gnu.org>
1131
1132 * window.h (resize_frame_windows, resize_window_check)
1133 (delete_deletable_window, resize_root_window)
1134 (resize_frame_windows): Declare prototypes.
1135
1136 * window.c (resize_window_apply): Make definition be "static" to
1137 match the prototype.
1138
562dd5e9
MR
11392011-06-10 Martin Rudalics <rudalics@gmx.at>
1140
1141 * window.c: Remove declarations of Qwindow_size_fixed,
1142 window_min_size_1, window_min_size_2, window_min_size,
1143 size_window, window_fixed_size_p, enlarge_window, delete_window.
1144 Remove static from declaration of Qdelete_window, it's
1145 temporarily needed by Fbury_buffer.
1146 (replace_window): Don't assign orig_top_line and
1147 orig_total_lines.
1148 (Fdelete_window, delete_window): Remove. Window deletion is
1149 handled by window.el.
1150 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1151 Fdelete_window calls with calls to Qdelete_window.
1152 (Fdelete_other_windows): Remove. Deleting other windows is
1153 handled by window.el.
1154 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1155 handled in window.el.
1156 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1157 Window minimum sizes are handled in window.el.
1158 (shrink_windows, size_window, set_window_height)
1159 (set_window_width, change_window_heights, window_height)
1160 (window_width, CURBEG, CURSIZE, enlarge_window)
1161 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1162 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1163 handled in window.el.
1164 (make_dummy_parent): Rename to make_parent_window and give it a
1165 second argument horflag.
1166 (make_window): Don't set resize_proportionally any more.
1167 (Fsplit_window): Remove. Windows are split in window.el.
1168 (save_restore_action, save_restore_orig_size)
1169 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1170 Resize mini windows in window.el.
1171 (grow_mini_window, shrink_mini_window): Implement by calling
1172 Qresize_root_window_vertically, resize_window_check and
1173 resize_window_apply.
1174 (saved_window, Fset_window_configuration, save_window_save): Do
1175 not handle orig_top_line, orig_total_lines, and
1176 resize_proportionally.
1177 (window_min_height, window_min_width): Move to window.el.
1178 (keys_of_window): Move bindings for delete-other-windows,
1179 split-window, delete-window and enlarge-window to window.el.
1180
1181 * buffer.c: Temporarily extern Qdelete_window.
1182 (Fbury_buffer): Temporarily call Qdelete_window instead of
1183 Fdelete_window (Fbury_buffer will move to window.el soon).
1184
1185 * frame.c (set_menu_bar_lines_1): Remove code handling
1186 orig_top_line and orig_total_lines.
1187
1188 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1189 set_window_height but set heights directly.
1190 (change_frame_size_1): Use resize_frame_windows.
1191
1192 * xdisp.c (init_xdisp): Don't use set_window_height but set
1193 heights directly.
1194
1195 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1196 resize_frame_windows instead of change_window_heights and run
1197 run_window_configuration_change_hook.
1198
1199 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1200 instead of change_window_heights and run
1201 run_window_configuration_change_hook.
1202
1a13852e
MR
12032011-06-09 Martin Rudalics <rudalics@gmx.at>
1204
1205 * window.c (replace_window): Rename second argument REPLACEMENT to
1206 NEW. New third argument SETFLAG. Rewrite.
1207 (delete_window, make_dummy_parent): Call replace_window with
1208 third argument 1.
1209 (window_list_1): Move down in code.
1210 (run_window_configuration_change_hook): Move set_buffer part
1211 before select_frame_norecord part in order to unwind correctly.
1212 Rename count1 to count.
1213 (recombine_windows, delete_deletable_window, resize_root_window)
1214 (Fdelete_other_windows_internal)
1215 (Frun_window_configuration_change_hook, make_parent_window)
1216 (resize_window_check, resize_window_apply, Fresize_window_apply)
1217 (resize_frame_windows, Fsplit_window_internal)
1218 (Fdelete_window_internal, Fresize_mini_window_internal): New
1219 functions.
1220 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1221
f3d1777e
MR
12222011-06-08 Martin Rudalics <rudalics@gmx.at>
1223
496e208e
MR
1224 * window.h (window): Add some new members to window structure -
1225 normal_lines, normal_cols, new_total, new_normal, clone_number,
1226 splits, nest, prev_buffers, next_buffers.
1227 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1228 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1229
f3d1777e
MR
1230 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1231 Remove.
496e208e
MR
1232 (make_dummy_parent): Set new members of windows structure.
1233 (make_window): Move down in code. Handle new members of window
1234 structure.
1235 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1236 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1237 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1238 (Fset_window_prev_buffers, Fwindow_next_buffers)
1239 (Fset_window_next_buffers, Fset_window_clone_number): New
1240 functions.
1241 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1242 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1243 Doc-string fixes.
1244 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1245 Argument WINDOW can be now internal window too.
1246 (Fwindow_use_time): Move up in code.
1247 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1248 Rewrite doc-string.
1249 (Fset_window_configuration, saved_window)
1250 (Fcurrent_window_configuration, save_window_save): Handle new
1251 members of window structure.
b9e809c2
MR
1252 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1253 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1254 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1255 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1256 Qget_mru_window, Qresize_root_window,
1257 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1258 Qauto_buffer_name; staticpro them.
f3d1777e 1259
abde8f8c
MR
12602011-06-07 Martin Rudalics <rudalics@gmx.at>
1261
1262 * window.c (Fwindow_total_size, Fwindow_left_column)
1263 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1264 (Fwindow_list_1): New functions.
1265 (window_box_text_cols): Replace with window_body_cols.
1266 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1267 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1268 (delete_window, Fset_window_configuration): Call
1269 delete_all_subwindows with window as argument.
1270 (delete_all_subwindows): Take a window as argument and not a
1271 structure. Rewrite.
190b47e6
MR
1272 (window_loop): Remove handling of GET_LRU_WINDOW and
1273 GET_LARGEST_WINDOW.
1274 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1275
1276 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1277 window_box_text_cols. delete_all_subwindows now takes a
1278 Lisp_Object as argument.
abde8f8c
MR
1279
1280 * indent.c (compute_motion, Fcompute_motion): Use
1281 window_body_cols instead of window_box_text_cols.
1282
fa8a67e6
MR
1283 * frame.c (delete_frame): Call delete_all_subwindows with root
1284 window as argument.
1285
a54e3482
DC
12862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1287
1288 * fns.c (Fputhash): Document return value.
1289
60002bf5
CY
12902011-06-06 Chong Yidong <cyd@stupidchicken.com>
1291
1292 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1293
0c671da6 12942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1295
b862a52a 1296 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1297
be44ca6c
PE
1298 Check for overflow when converting integer to cons and back.
1299 * charset.c (Fdefine_charset_internal, Fdecode_char):
1300 Use cons_to_unsigned to catch overflow.
1301 (Fencode_char): Use INTEGER_TO_CONS.
1302 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1303 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1304 * data.c (long_to_cons, cons_to_long): Remove.
1305 (cons_to_unsigned, cons_to_signed): New functions.
1306 These signal an error for invalid or out-of-range values.
1307 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1308 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1309 * font.c (Ffont_variation_glyphs):
1310 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1311 * lisp.h: Include <intprops.h>.
1312 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1313 (cons_to_signed, cons_to_unsigned): New decls.
1314 (long_to_cons, cons_to_long): Remove decls.
1315 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1316 (Fprimitive_undo): Use CONS_TO_INTEGER.
1317 * xfns.c (Fx_window_property): Likewise.
1318 * xselect.c: Include <limits.h>.
1319 (x_own_selection, selection_data_to_lisp_data):
1320 Use INTEGER_TO_CONS.
1321 (x_handle_selection_request, x_handle_selection_clear)
1322 (x_get_foreign_selection, Fx_disown_selection_internal)
1323 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1324 (lisp_data_to_selection_data): Use cons_to_unsigned.
1325 (x_fill_property_data): Use cons_to_signed.
1326 Report values out of range.
1327
d1f3d2af
PE
1328 Check for buffer and string overflow more precisely.
1329 * buffer.h (BUF_BYTES_MAX): New macro.
1330 * lisp.h (STRING_BYTES_MAX): New macro.
1331 * alloc.c (Fmake_string):
1332 * character.c (string_escape_byte8):
1333 * coding.c (coding_alloc_by_realloc):
1334 * doprnt.c (doprnt):
1335 * editfns.c (Fformat):
1336 * eval.c (verror):
1337 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1338 since they may not be the same number.
1339 * editfns.c (Finsert_char):
1340 * fileio.c (Finsert_file_contents):
1341 Likewise for BUF_BYTES_MAX.
1342
dd52fcea
PE
1343 * image.c: Use ptrdiff_t, not int, for sizes.
1344 (slurp_file): Switch from int to ptrdiff_t.
1345 All uses changed.
1346 (slurp_file): Check that file size fits in both size_t (for
1347 malloc) and ptrdiff_t (for sanity and safety).
1348
7f9bbdbb
PE
1349 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1350 if b->modtime has its maximal value.
1351
dfe18f82
PE
1352 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1353
84acfcf0
PE
1354 Don't assume time_t can fit into int.
1355 * buffer.h (struct buffer.modtime): Now time_t, not int.
1356 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1357 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1358
ccd9a01a
PE
1359 Minor fixes for signed vs unsigned integers.
1360 * character.h (MAYBE_UNIFY_CHAR):
1361 * charset.c (maybe_unify_char):
1362 * keyboard.c (read_char, reorder_modifiers):
1363 XINT -> XFASTINT, since the integer must be nonnegative.
1364 * ftfont.c (ftfont_spec_pattern):
1365 * keymap.c (access_keymap, silly_event_symbol_error):
1366 XUINT -> XFASTINT, since the integer must be nonnegative.
1367 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1368 since it makes no difference and we prefer signed.
1369 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1370 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1371 nonnegative.
1372
d6d100dd
SM
13732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1374
1375 * window.h (Fwindow_frame): Declare.
1376
2b6148e4
PE
13772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1380 (SPARE_MEMORY): Always define.
1381 (LARGE_REQUEST): Remove.
1382 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1383
f230ecc9
MR
13842011-06-06 Martin Rudalics <rudalics@gmx.at>
1385
727e958e
MR
1386 * lisp.h: Move EXFUNS for Fframe_root_window,
1387 Fframe_first_window and Fset_frame_selected_window to window.h.
1388
1389 * window.h: Move EXFUNS for Fframe_root_window,
1390 Fframe_first_window and Fset_frame_selected_window here from
1391 lisp.h.
1392
1393 * frame.c (Fwindow_frame, Fframe_first_window)
1394 (Fframe_root_window, Fframe_selected_window)
1395 (Fset_frame_selected_window): Move to window.c.
1396 (Factive_minibuffer_window): Move to minibuf.c.
1397 (Fother_visible_frames_p): New function.
1398
1399 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1400
f230ecc9
MR
1401 * window.c (decode_window, decode_any_window): Move up in code.
1402 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1403 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1404 (Fwindow_buffer): Move up and rewrite doc-string.
1405 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1406 (Fwindow_prev): New functions.
727e958e
MR
1407 (Fwindow_frame): Move here from frame.c. Accept any window as
1408 argument.
1409 (Fframe_root_window, Fframe_first_window)
1410 (Fframe_selected_window): Move here from frame.c. Accept frame
1411 or arbitrary window as argument. Update doc-strings.
1412 (Fminibuffer_window): Move up in code.
1413 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1414 (Fset_frame_selected_window): Move here from frame.c.
1415 Marginal rewrite.
727e958e
MR
1416 (Fselected_window, select_window, Fselect_window): Move up in
1417 code. Minor doc-string fixes.
f230ecc9 1418
4d09bcf6
PE
14192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1422 Do not assume that spare memory exists; that assumption is valid
1423 only if SYSTEM_MALLOC.
1424 (LARGE_REQUEST): New macro, so that the issue of large requests
1425 is separated from the issue of spare memory.
1426
810928a2
AS
14272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1428
172418ad
AS
1429 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1430 format. (Bug#8806)
1431
43f862f7
AS
1432 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1433
810928a2
AS
1434 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1435 before statements.
1436
a059fe24
JD
14372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1438
1439 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1440
1441 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1442
1443 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1444 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1445
989bf368
JB
14462011-06-05 Juanma Barranquero <lekktu@gmail.com>
1447
1448 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1449
4b80f674
CY
14502011-06-04 Chong Yidong <cyd@stupidchicken.com>
1451
1452 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1453 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1454 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1455 New error handlers.
4b80f674
CY
1456 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1457 Obey Vx_select_enable_clipboard_manager. Catch errors in
1458 x_clipboard_manager_save (Bug#8779).
1459 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1460 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1461
99a33b77 14622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1463
1464 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1465
99a33b77 14662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1467
1468 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1469 in the current matrix if keep_current_p is non-zero.
1470
8264569d
EZ
14712011-06-04 Eli Zaretskii <eliz@gnu.org>
1472
1473 * bidi.c (bidi_level_of_next_char): Fix last change.
1474
57f97249
EZ
14752011-06-03 Eli Zaretskii <eliz@gnu.org>
1476
fec2107c 1477 Support bidi reordering of text covered by display properties.
57f97249 1478
fec2107c
EZ
1479 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1480 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1481 (bidi_cache_search, bidi_cache_iterator_state)
1482 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1483 (bidi_level_of_next_char, bidi_move_to_visually_next):
1484 Support character positions inside a run of characters covered by a
fec2107c
EZ
1485 display string.
1486 (bidi_paragraph_init, bidi_resolve_explicit_1)
1487 (bidi_level_of_next_char): Call bidi_fetch_char and
1488 bidi_fetch_char_advance instead of FETCH_CHAR and
1489 FETCH_CHAR_ADVANCE.
1490 (bidi_init_it): Initialize new members.
1491 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1492 definitions.
1493 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1494 instead of using explicit *_CHAR codes.
d6d100dd
SM
1495 (bidi_resolve_explicit, bidi_resolve_weak):
1496 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1497 bidirectional text is supported only in multibyte buffers.
1498 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1499 it to initialize the frame_window_p member of struct bidi_it.
1500 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1501 (bidi_resolve_explicit, bidi_resolve_weak)
1502 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1503 bidi_it->nchars is non-positive.
1504 (bidi_level_of_next_char): Don't try to lookup the cache for the
1505 next/previous character if nothing is cached there yet, or if we
1506 were just reseat()'ed to a new position.
c40e2fb2 1507
0e14fe90
EZ
1508 * xdisp.c (set_cursor_from_row): Set start and stop points
1509 according to the row's direction when priming the loop that looks
1510 for the glyph on which to display cursor.
1511 (single_display_spec_intangible_p): Function deleted.
1512 (display_prop_intangible_p): Reimplement to call
1513 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1514 Accept 3 additional arguments needed by handle_display_spec.
1515 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1516 values: lists, `(when COND...)' forms, etc.
1517 (single_display_spec_string_p): Support property values that are
1518 lists with the argument STRING its top-level element.
1519 (display_prop_string_p): Fix the condition for processing a
1520 property that is a list to be consistent with handle_display_spec.
fec2107c 1521 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1522 last portion of handle_display_prop.
1523 (compute_display_string_pos): Accept additional argument
1524 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1525 value of a `display' property is a "replacing spec".
1526 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1527 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1528 the display property, but just return a value indicating whether
1529 the display property will replace the characters it covers.
1530 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1531 frame_window_p members of struct bidi_it.
d6d100dd
SM
1532 (compute_display_string_pos, compute_display_string_end):
1533 New functions.
fec2107c
EZ
1534 (push_it): Accept second argument POSITION, where pop_it should
1535 jump to continue iteration.
1536 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1537
fec2107c
EZ
1538 * keyboard.c (adjust_point_for_property): Adjust the call to
1539 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1540
1541 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1542 (bidi_init_it): Update prototypes.
1543 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1544 (compute_display_string_pos, compute_display_string_end):
1545 Declare prototypes.
fec2107c
EZ
1546 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1547 EMACS_INT.
fc6f18ce 1548
40087514 15492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1550
57f53182
PE
1551 Malloc failure behavior now depends on size of allocation.
1552 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1553 * lisp.h: Change signatures accordingly.
1554 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1555 All callers changed. (Bug#8762)
1556
1557 * gnutls.c: Use Emacs's memory allocators.
1558 Without this change, the gnutls library would invoke malloc etc.
1559 directly, which causes problems on non-SYNC_INPUT hosts, and which
1560 runs afoul of improving memory_full behavior. (Bug#8761)
1561 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1562 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1563 xfree instead of the default malloc, realloc, free.
1564 (Fgnutls_boot): No need to check for memory allocation failure,
1565 since xmalloc does that for us.
1566
ac32cd99 1567 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1568 * category.c (hash_get_category_set):
1569 * ccl.c (ccl_driver):
1570 * charset.c (Fdefine_charset_internal):
1571 * charset.h (struct charset.hash_index):
1572 * composite.c (get_composition_id, gstring_lookup_cache)
1573 (composition_gstring_put_cache):
1574 * composite.h (struct composition.hash_index):
1575 * dispextern.h (struct image.hash):
1576 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1577 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1578 (hashfn_equal, hashfn_user_defined, make_hash_table)
1579 (maybe_resize_hash_table, hash_lookup, hash_put)
1580 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1581 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1582 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1583 * image.c (make_image, search_image_cache, lookup_image)
1584 (xpm_put_color_table_h):
1585 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1586 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1587 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1588 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1589 * alloc.c (allocate_vectorlike):
1590 Check for overflow in vector size calculations.
1591 * ccl.c (ccl_driver):
1592 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1593 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1594 need to be updated by these changes.
40087514
PE
1595 * fns.c (make_hash_table, maybe_resize_hash_table):
1596 Check for integer overflow with large hash tables.
0de4bb68
PE
1597 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1598 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1599 (SXHASH_REDUCE): New macro.
1600 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1601 Use it instead of discarding useful hash info with large hash values.
1602 (sxhash_float): New function.
1603 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1604 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1605 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1606 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1607 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1608 Adjust signatures to match updated version of code.
1609 (consing_since_gc): Now EMACS_INT, since a single hash table can
1610 use more than INT_MAX bytes.
1611
698d32e2
DN
16122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1613
1614 Make it possible to build with GCC-4.6+ -O2 -flto.
1615
1616 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1617
fd6fa53f
SM
16182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1619
1620 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1621 Call minibuffer-inactive-mode.
1622
864db017
JB
16232011-05-31 Juanma Barranquero <lekktu@gmail.com>
1624
1625 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1626 Update dependencies.
1627
2ad0baf4
DN
16282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1629
1630 * data.c (init_data): Remove code for UTS, this system is not
1631 supported anymore.
1632
4fcc2638
DN
16332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1634
1635 Don't force ./temacs to start in terminal mode.
1636
1637 * frame.c (make_initial_frame): Initialize faces in all cases, not
1638 only when CANNOT_DUMP is defined.
1639 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1640
c56e0fd5
DN
16412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1642
1643 * dispnew.c (add_window_display_history): Use const for the string
1644 pointer. Remove declaration, not needed.
1645
333d54da 16462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1647
55d4c1b2 1648 Use 'inline', not 'INLINE'.
333d54da 1649 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1650 * alloc.c, fontset.c (INLINE): Remove.
1651 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1652 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1653 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1654 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1655 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1656
738db178
DN
16572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1658
1659 Make it possible to run ./temacs.
1660
1661 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1662 syms_of_callproc does the same thing. Remove test for
1663 "initialized", do it in the caller.
1664 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1665
620c53a6
SM
16662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1667
1668 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1669 (read_minibuf): Use get_minibuffer.
1670 (syms_of_minibuf): Use DEFSYM.
1671 (Qmetadata): New var.
1672 * data.c (Qbuffer): Don't make it static.
1673 (syms_of_data): Use DEFSYM.
1674
e003a292
PE
16752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1678 (CCL_CODE_MIN): New macro.
1679
ed008a6d
PE
16802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1681
3687c2ef
PE
1682 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1683
ed008a6d
PE
1684 * eval.c (Qdebug): Now static.
1685 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1686 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1687 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1688
d66c4c7c
CY
16892011-05-29 Chong Yidong <cyd@stupidchicken.com>
1690
1691 * image.c: Various fixes to ImageMagick code comments.
1692 (Fimagemagick_types): Doc fix.
1693
5fbc2025
PE
16942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1695
0196f88a
PE
1696 Minor fixes prompted by GCC 4.6.0 warnings.
1697
1698 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1699
5fbc2025
PE
1700 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1701 (x_clipboard_manager_save_all): Move extern decl to ...
1702 * xterm.h: ... here, so that it can be checked for consistency.
1703
1dd3c2d9
CY
17042011-05-29 Chong Yidong <cyd@stupidchicken.com>
1705
1706 * xselect.c (x_clipboard_manager_save_frame)
1707 (x_clipboard_manager_save_all): New functions.
1708 (Fx_clipboard_manager_save): Lisp function deleted.
1709
1710 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1711 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1712
1713 * xterm.h: Update prototype.
1714
5ba6571d
WX
17152011-05-28 William Xu <william.xwl@gmail.com>
1716
1717 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1718 exiting (Bug#8239).
1719
3eaff834
JM
17202011-05-28 Jim Meyering <meyering@redhat.com>
1721
e1900994 1722 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1723 * fns.c (to_uchar): Define.
1724 (crypto_hash_function): Use it to convert some newly-signed
1725 variables to unsigned, to avoid sign-extension bugs. For example,
1726 without this change, (md5 "truc") would evaluate to
1727 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1728 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1729 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1730
0f6990a7
PE
17312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 Integer overflow fixes.
c8a9ca5a 1734
08686060
PE
1735 * dbusbind.c: Serial number integer overflow fixes.
1736 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1737 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1738 to hold a serial number that is too large for a fixnum.
1739 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1740 Check for serial numbers out of range. Decode any serial number
59568bf0 1741 that was so large that it became a float. (Bug#8722)
08686060 1742
2d1fc3c7
PE
1743 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1744 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1745 Use XFASTINT rather than XUINT when numbers are nonnegative.
1746 (xd_append_arg, Fdbus_method_return_internal):
1747 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1748 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1749 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1750 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1751 (Bug#8722)
2d1fc3c7 1752
c8a9ca5a
PE
1753 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1754
519e1d69
PE
1755 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1756
30569699
PE
1757 ccl: add integer overflow checks
1758 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1759 (IN_INT_RANGE): New macros.
1760 (ccl_driver): Use them to check for integer overflow when
1761 decoding a CCL program. Many of the new checks are whether XINT (x)
1762 fits in int; it doesn't always, on 64-bit hosts. The new version
1763 doesn't catch all possible integer overflows, but it's an
847044ea 1764 improvement. (Bug#8719)
30569699 1765
c11285dc
PE
1766 * alloc.c (make_event_array): Use XINT, not XUINT.
1767 There's no need for unsigned here.
1768
fdccd48e
PE
1769 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1770 This follows up to the 2011-05-06 change that substituted uintptr_t
1771 for EMACS_INT. This case wasn't caught back then.
1772
37910ab2
PE
1773 Rework Fformat to avoid integer overflow issues.
1774 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1775 now (part of C89). Include <verify.h>.
1776 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1777 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1778 (Fformat): Avoid the prepass trying to compute sizes; it was only
1779 approximate and thus did not catch overflow reliably. Instead, walk
1780 through the format just once, formatting and computing sizes as we go,
1781 checking for integer overflow at every step, and allocating a larger
1782 buffer as needed. Keep track separately whether the format is
1783 multibyte. Keep only the most-recently calculated precision, rather
1784 than them all. Record whether each argument has been converted to
1785 string. Use EMACS_INT, not int, for byte and char and arg counts.
1786 Support field widths and precisions larger than INT_MAX. Avoid
1787 sprintf's undefined behavior with conversion specifications such as %#d
1788 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1789 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1790 formatting out-of-range floating point numbers with int
1791 formats. (Bug#8668)
1792
2e6578fb
PE
1793 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1794
0ae6bdee
PE
1795 * data.c: Avoid integer truncation in expressions involving floats.
1796 * data.c: Include <intprops.h>.
1797 (arith_driver): When there's an integer overflow in an expression
1798 involving floating point, convert the integers to floating point
1799 so that the resulting value does not suffer from catastrophic
1800 integer truncation. For example, on a 64-bit host (* 4
1801 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1802 Do not rely on undefined behavior after integer overflow.
1803
de883a70
PE
1804 merge count_size_as_multibyte, parse_str_to_multibyte
1805 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1806 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1807 Check for integer overflow.
1808 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1809 since it's now a duplicate of the other. This is more of
1810 a character than a buffer op, so better that it's in character.c.
1811 * fns.c, print.c: Adjust to above changes.
1812
2ff916cb
PE
18132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1814
1815 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1816
f1b54466
PE
18172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1818
fb1ac845
PE
1819 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1820 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1821 (x_clipboard_manager_save): Now static.
1822 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1823
f1b54466
PE
1824 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1825 (crypto_hash_function): Now static.
1826 Fix pointer signedness problems. Avoid unnecessary initializations.
1827
a9f737ee
CY
18282011-05-27 Chong Yidong <cyd@stupidchicken.com>
1829
1830 * termhooks.h (Vselection_alist): Make it terminal-local.
1831
1832 * terminal.c (create_terminal): Initialize it.
1833
1834 * xselect.c: Support for clipboard managers.
1835 (Vselection_alist): Move to termhooks.h as terminal-local var.
1836 (LOCAL_SELECTION): New macro.
1837 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1838 (symbol_to_x_atom): Remove gratuitous arg.
1839 (x_handle_selection_request, lisp_data_to_selection_data)
1840 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1841 (x_own_selection, x_get_local_selection, x_convert_selection):
1842 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1843 (some_frame_on_display): Delete unused function.
1844 (Fx_own_selection_internal, Fx_get_selection_internal)
1845 (Fx_disown_selection_internal, Fx_selection_owner_p)
1846 (Fx_selection_exists_p): New optional frame arg.
1847 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1848 (x_handle_selection_clear): Don't treat other terminals with the
1849 same keyboard specially. Use the terminal-local Vselection_alist.
1850 (x_clear_frame_selections): Use Frun_hook_with_args.
1851
1852 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1853
1854 * xterm.h: Add support for those atoms.
1855
e067f0c1
CY
18562011-05-26 Chong Yidong <cyd@stupidchicken.com>
1857
1858 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1859 (converted_selections, conversion_fail_tag): New global variables.
1860 (x_selection_request_lisp_error): Free the above.
1861 (x_get_local_selection): Remove unnecessary code.
1862 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1863 of converted selections stored in converted_selections.
1864 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1865 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1866 (x_convert_selection): New function.
1867 (x_handle_selection_event): Simplify.
1868 (x_get_foreign_selection): Don't ignore incoming requests while
1869 waiting for an answer; this will fail when we implement
1870 SAVE_TARGETS, and seems unnecessary anyway.
1871 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1872 (Vx_sent_selection_functions): Doc fix.
1873
0f4aebc0
LL
18742011-05-26 Leo Liu <sdl.web@gmail.com>
1875
1876 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1877
e61124cd
YM
18782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1879
1880 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1881
1882 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1883 for fringe update if it has periodic bitmap.
1884 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1885 and fringe_bitmap_periodic_p.
1886
1887 * fringe.c (get_fringe_bitmap_data): New function.
1888 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1889 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1890 row. Mark glyph row for fringe update if periodicity changed.
1891
1892 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1893 for fringe update unless it has periodic bitmap.
1894
f16d9837
KH
18952011-05-25 Kenichi Handa <handa@m17n.org>
1896
1897 * xdisp.c (get_next_display_element): Set correct it->face_id for
1898 a static composition.
1899
e1b90ef6
LL
19002011-05-24 Leo Liu <sdl.web@gmail.com>
1901
1902 * deps.mk (fns.o):
1903 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1904
1905 * fns.c (crypto_hash_function, Fsha1): New function.
1906 (Fmd5): Use crypto_hash_function.
1907 (syms_of_fns): Add Ssha1.
1908
7400048f
PE
19092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 * gnutls.c: Remove unused macros.
1912 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1913 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1914 Remove macros that are defined and never used.
1915 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1916
abb71cf4
CY
19172011-05-22 Chong Yidong <cyd@stupidchicken.com>
1918
1919 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1920 (Fx_get_selection_internal): Minor cleanup.
1921 (Fx_own_selection_internal): Rename arguments for consistency with
1922 select.el.
1923
6307db39
PE
19242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1925
1926 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1927
f3d4e0a4
CY
19282011-05-22 Chong Yidong <cyd@stupidchicken.com>
1929
1930 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1931
4d8ade89
YM
19322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1933
1934 * dispnew.c (scrolling_window): Don't exclude the case that the
1935 last enabled row in the desired matrix touches the bottom boundary.
1936
32078c8d
GM
19372011-05-21 Glenn Morris <rgm@gnu.org>
1938
1939 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1940 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1941 and add some more files.
32078c8d 1942
7285dc67
EZ
19432011-05-20 Eli Zaretskii <eliz@gnu.org>
1944
1945 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1946 report_file_error introduced by the change from 2011-05-07.
1947
89d1bd22
PE
19482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 * systime.h (Time): Define only if emacs is defined.
1951 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1952 where the include path doesn't have X11/X.h by default. See
1953 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1954
e23640bb 19552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1956
1957 * composite.c (find_automatic_composition): Fix previous change.
1958
b9704ad9
GM
19592011-05-20 Glenn Morris <rgm@gnu.org>
1960
1961 * lisp.mk: New file, split from Makefile.in.
1962 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1963 (shortlisp): Remove.
1964 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1965
4a720484
GM
19662011-05-19 Glenn Morris <rgm@gnu.org>
1967
1968 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1969 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1970 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1971 (lisp): Set the order to that of loadup.el.
1972 (shortlisp): Make it a copy of $lisp.
1973 (SOME_MACHINE_LISP): Remove.
1974 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1975 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1976
a28d4396
KH
19772011-05-18 Kenichi Handa <handa@m17n.org>
1978
1979 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1980 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1981 (find_automatic_composition): Mostly rewrite for efficiency.
1982
a2b1fa8e
JB
19832011-05-18 Juanma Barranquero <lekktu@gmail.com>
1984
1985 * makefile.w32-in: Update dependencies.
1986
8e1f5610
CS
19872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1988
1989 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1990 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1991
7025ee00 19922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1993
cdfa6eab
PE
1994 Fix some integer overflow issues, such as string length overflow.
1995
06d6db33
PE
1996 * insdel.c (count_size_as_multibyte): Check for string overflow.
1997
2b4560a8
PE
1998 * character.c (lisp_string_width): Check for string overflow.
1999 Use EMACS_INT, not int, for string indexes and lengths; in
2000 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2001 the resulting string length overflows an EMACS_INT; instead,
2002 report a string overflow if no precision given. When checking for
2003 precision exhaustion, use a check that cannot possibly have
2004 integer overflow. (Bug#8675)
2005 * character.h (lisp_string_width): Adjust to new signature.
2006
cb93f9be
PE
2007 * alloc.c (string_overflow): New function.
2008 (Fmake_string): Use it. This doesn't change behavior, but saves
2009 a few bytes and will simplify future changes.
2010 * character.c (string_escape_byte8): Likewise.
2011 * lisp.h (string_overflow): New decl.
2012
1a1f3366
PE
2013 Fixups, following up to the user-interface timestamp change.
2014 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2015 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2016 * msdos.c (mouse_get_pos): Likewise.
2017 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2018 * w32gui.h (Time): Define by including "systime.h" rather than by
2019 declaring it ourselves. (Bug#8664)
2020
d4e3e4d3
PE
2021 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2022 * image.c (clear_image_cache): Likewise.
2023
f6a24d19
PE
2024 * term.c (term_mouse_position): Don't assume time_t wraparound.
2025
08dc5ae6
PE
2026 Be more systematic about user-interface timestamps.
2027 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2028 and sometimes 'EMACS_UINT', to represent these timestamps.
2029 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2030 This makes the code easier to follow, and makes it easier to catch
2031 integer overflow bugs such as Bug#8664.
2032 * frame.c (Fmouse_position, Fmouse_pixel_position):
2033 Use Time, not unsigned long, for user-interface timestamps.
2034 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2035 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2036 * keyboard.h (last_event_timestamp): Likewise.
2037 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2038 * menu.h (xmenu_show): Likewise.
2039 * term.c (term_mouse_position): Likewise.
2040 * termhooks.h (struct input_event.timestamp): Likewise.
2041 (struct terminal.mouse_position_hook): Likewise.
2042 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2043 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2044 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2045 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2046 what it was before.
2047 * menu.h, termhooks.h: Include "systime.h", for Time.
2048
8e55734a
PE
2049 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2050 Don't assume that the difference between two unsigned long values
2051 can fit into an integer. At this point, we know button_down_time
2052 <= event->timestamp, so the difference must be nonnegative, so
2053 there's no need to cast the result if double-click-time is
2054 nonnegative, as it should be; check that it's nonnegative, just in
2055 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2056 apart (about 25 days). (Bug#8664)
8e55734a 2057
841f1b75 2058 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2059 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2060
3e26f69c
PE
2061 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2062 that always fit in int. Use a sentinel instead of a counter, to
2063 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2064 * frame.h (struct frame): Use int for menu_bar_items_used
2065 instead of EMACS_INT, since it always fits in int.
3e26f69c 2066
5cc152c0
PE
2067 * menu.c (grow_menu_items): Check for int overflow.
2068
d89eb65e
PE
2069 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2070
5235bd3e
PE
2071 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2072 Before, the code was not consistent. These values cannot exceed
2073 2**31 - 1 so there's no need to make them unsigned.
2074 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2075 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2076 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2077 as modifiers.
2078 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2079
bc827e23
PE
2080 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2081 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2082 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2083 presumably because the widths might not match.
2084
78eb494e
PE
2085 * window.c (size_window): Avoid needless test at loop start.
2086
04f2d78b
CB
20872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2088
2089 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2090
d2fc7e3d 20912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2092
2093 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2094
d2fc7e3d 20952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2096
2097 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2098 `width' to `bar_area_x' and `bar_area_width', respectively.
2099 (x_scroll_run): Take account of fringe background extension.
2100
04f2d78b
CB
2101 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2102 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2103 `bar_area_width', respectively.
2104 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2105 background extension.
2106
79b70037
GM
21072011-05-10 Jim Meyering <meyering@redhat.com>
2108
2109 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2110
2f142cc5
JB
21112011-05-10 Juanma Barranquero <lekktu@gmail.com>
2112
2113 * image.c (Finit_image_library): Return t for built-in image types,
2114 like pbm and xbm. (Bug#8640)
2115
57679c86
AS
21162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2117
2118 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2119
888c9e86
EZ
21202011-05-07 Eli Zaretskii <eliz@gnu.org>
2121
b0512a1d
EZ
2122 * w32console.c (Fset_screen_color): Doc fix.
2123 (Fget_screen_color): New function.
2124 (syms_of_ntterm): Defsubr it.
2125
7285dc67
EZ
2126 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2127 unlink the temporary file if Fcall_process didn't create it in the
2128 first place.
2129 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2130 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2131 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2132 cue to call_process_cleanup not to close that handle.
2133
4d3fcc8e
BK
21342011-05-07 Ben Key <bkey76@gmail.com>
2135
2136 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2137 one of two shell specific rules, either bootstrap-temacs-CMD or
2138 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2139 to the previous implementation of the bootstrap-temacs rule.
2140 The bootstrap-temacs-CMD rule is similar to the previous
2141 implementation of the bootstrap-temacs rule except that it
2142 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2143 variable.
2144
2145 These changes, along with some changes to nt/configure.bat,
2146 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2147 earlier fix to add support for --cflags and --ldflags options
2148 that include quotes so that it works whether make uses cmd or
2149 sh as the shell.
2150
b4289b64
MA
21512011-05-06 Michael Albinus <michael.albinus@gmx.de>
2152
2153 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2154 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2155 is a constant.
2156 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2157 a string. Handle both cases.
2158 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2159 (Fdbus_register_method): Use Qinvalid_function.
2160
af4c0e28
JB
21612011-05-06 Juanma Barranquero <lekktu@gmail.com>
2162
2163 * makefile.w32-in: Update dependencies.
2164 (LISP_H): Add inttypes.h and stdin.h.
2165 (PROCESS_H): Add unistd.h.
2166
c51453d9
EZ
21672011-05-06 Eli Zaretskii <eliz@gnu.org>
2168
2169 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2170 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2171
8ff0ac3c 21722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2173
4c4b566b
PE
2174 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2175
aab2b9b5
PE
2176 * term.c (vfatal): Remove stray call to va_end.
2177 It's not needed and the C Standard doesn't allow it here anyway.
2178
c378da0b
PE
2179 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2180 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2181
288b08c7
PE
2182 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2183 bytes.
2184
e3601888
PE
2185 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2186
db6c0e74
PE
2187 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2188
dd5963ea
PE
2189 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2190
88c9450f
PE
2191 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2192
2f9442b8
PE
2193 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2194
c032b5f8
PE
2195 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2196 * charset.c (Fdefine_charset_internal): Don't initialize
2197 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2198 32-bit int (Bug#8600).
a108c10b
PE
2199
2200 * lread.c (read_integer): Be more consistent with string-to-number.
2201 Use string_to_number to do the actual conversion; this avoids
2202 rounding errors and fixes some other screwups. Without this fix,
2203 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2204 (digit_to_number): Move earlier, for benefit of read_integer.
2205 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2206 not a digit in any supported base. (Bug#8602)
a108c10b 2207
ad5f9eea
PE
2208 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2209
aec1708a
PE
2210 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2211 to match comment at start of function. This also removes a
2212 GCC warning about overflow in a 32+64-bit port.
2213
47be4ab5
PE
2214 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2215
371cac43
PE
2216 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2217 Reported by Stefan Monnier in
2218 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2219 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2220 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2221
d01a7826
PE
2222 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2223 (EMACS_UINTPTR): Likewise, with uintptr_t.
2224
7fd47d5c
PE
2225 * lisp.h: Prefer 64-bit EMACS_INT if available.
2226 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2227 on 32-bit hosts that have 64-bit int, so that they can access
2228 large files.
122b0c86
PE
2229 However, temporarily disable this change unless the temporary
2230 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2231
8727937b
PE
2232 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2233
8ac068ac
PE
2234 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2235 This removes an assumption that EMACS_INT and long are the same
2236 width as pointers. The assumption is true for Emacs porting targets
2237 now, but we want to make other targets possible.
2238 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2239 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2240 In the rest of the code, change types of integers that hold casted
2241 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2242 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2243 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2244 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2245 No need to cast type when ORing.
2246 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2247 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2248 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2249 assume EMACS_INT is the same width as char *.
2250 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2251 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2252 Remove no-longer-needed casts.
2253 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2254 (xg_tool_bar_help_callback, xg_make_tool_item):
2255 Use EMACS_INTPTR to hold an integer
2256 that will be cast to void *; this can avoid a GCC warning
2257 if EMACS_INT is not the same width as void *.
2258 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2259 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2260 (current_message_1, set_message_1):
2261 Use a local to convert to proper width without a cast.
2262 * xmenu.c (dialog_selection_callback): Likewise.
2263
ede49d71
PE
2264 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2265 Also, don't assume VALBITS / RAND_BITS is less than 5,
2266 and don't rely on undefined behavior when shifting a 1 left into
2267 the sign bit.
2268 * lisp.h (get_random): Change signature to match.
2269
2f30ecd0
PE
2270 * lread.c (hash_string): Use size_t, not int, for hash computation.
2271 Normally we prefer signed values; but hashing is special, because
2272 it's better to use unsigned division on hash table sizes so that
2273 the remainder is nonnegative. Also, size_t is the natural width
2274 for hashing into memory. The previous code used 'int', which doesn't
2275 retain enough info to hash well into very large tables.
2276 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2277
2a866e7b
PE
2278 * dbusbind.c: Don't possibly lose pointer info when converting.
2279 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2280 Use XPNTR rather than XHASH, so that the high-order bits of
2281 the pointer aren't lost when converting through void *.
2282
51639eac
PE
2283 * eval.c (Fautoload): Don't double-shift a pointer.
2284
92394119
PE
2285 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2286
dbdb9a7c
JB
22872011-05-06 Juanma Barranquero <lekktu@gmail.com>
2288
2289 * gnutls.c (DEF_GNUTLS_FN):
2290 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2291
db7a0b4f
AS
22922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2293
2294 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2295 marker. (Bug#8610)
2296
f7ff1b0f 22972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2298
2299 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2300 New version that can reserve upto 2GB of heap space.
2301
f7ff1b0f 23022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2303
2304 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2305
639c109b
TZ
23062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2307
2308 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2309 `gnutls_certificate_set_x509_key_file'.
2310
d2127135
JB
23112011-05-05 Juanma Barranquero <lekktu@gmail.com>
2312
2313 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2314 Update dependencies.
2315
e968f4f3
JB
23162011-05-04 Juanma Barranquero <lekktu@gmail.com>
2317
2318 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2319 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2320 Remove unused parameter `fildes'.
2321 * process.c (read_process_output, send_process): Don't pass it.
2322
84d358f0
JB
23232011-05-04 Juanma Barranquero <lekktu@gmail.com>
2324
2325 Fix previous change: the library cache is defined in w32.c.
2326 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2327 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2328
0898ca10
JB
23292011-05-04 Juanma Barranquero <lekktu@gmail.com>
2330
2331 Implement dynamic loading of GnuTLS on Windows.
2332
2333 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2334 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2335 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2336 Declare.
2337
2338 * gnutls.c (Qgnutls_dll): Define.
2339 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2340 (gnutls_*): Declare function pointers.
2341 (init_gnutls_functions): New function to initialize function pointers.
2342 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2343 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2344 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2345 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2346 (emacs_gnutls_write, emacs_gnutls_read)
2347 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2348 (Fgnutls_available_p): New function.
2349 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2350 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2351 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2352
2353 * image.c: Include w32.h.
2354 (Vimage_type_cache): Delete.
2355 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2356 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2357 (w32_delayed_load): Move to w32.c.
2358
2359 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2360
2361 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2362 (w32_delayed_load): Move from image.c. When loading a library, record
2363 its filename in the :loaded-from property of the library id.
2364 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2365 Initialize and staticpro them.
2366 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2367
2368 * process.c: Include lisp.h before w32.h, not after.
2369 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2370 instead of gnutls_record_check_pending.
2371
2372 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2373
ff4de4aa
TZ
23742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2375
2376 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2377 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2378 as passed in.
2379
abe95abb
JD
23802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2381
2382 * xterm.c (x_set_frame_alpha): Do not set property on anything
2383 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2384
e16e55d4
JB
23852011-05-02 Juanma Barranquero <lekktu@gmail.com>
2386
2387 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2388
bafcf6a5
JB
23892011-05-02 Juanma Barranquero <lekktu@gmail.com>
2390
2391 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2392 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2393 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2394 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2395 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2396 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2397 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2398 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2399 (Qgnutls_bootprop_callbacks_verify): Make static.
2400
e7a6747f
AS
24012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2402
19ed11ba
AS
2403 * callproc.c: Indentation fixup.
2404
e7a6747f 2405 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2406 (wait_for_termination, interruptible_wait_for_termination):
2407 Move after wait_for_termination_1.
e7a6747f 2408
1ef14cb4
LMI
24092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2410
2411 * sysdep.c (interruptible_wait_for_termination): New function
2412 which is like wait_for_termination, but allows keyboard
2413 interruptions.
2414
2415 * callproc.c (Fcall_process): Add (:file "file") as an option for
2416 the STDOUT buffer.
2417 (Fcall_process_region): Ditto.
2418
330d880c
EZ
24192011-04-30 Eli Zaretskii <eliz@gnu.org>
2420
8db90b73
EZ
2421 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2422 rather than `XVECTOR (FOO)->size'.
2423
330d880c
EZ
2424 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2425 inttypes.h, as a gnulib replacement is used if it not available in
2426 system headers.
2427
15cbd324
EZ
24282011-04-21 Eli Zaretskii <eliz@gnu.org>
2429
2430 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2431 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2432 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2433
2434 * coding.c (coding_alloc_by_realloc): Error out if destination
2435 will grow beyond MOST_POSITIVE_FIXNUM.
2436 (decode_coding_emacs_mule): Abort if there isn't enough place in
2437 charbuf for the composition carryover bytes. Reserve an extra
2438 space for up to 2 characters produced in a loop.
2439 (decode_coding_iso_2022): Abort if there isn't enough place in
2440 charbuf for the composition carryover bytes.
2441
24422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2443
ae940cca
EZ
2444 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2445 aborting when %lld or %lll format is passed.
2446 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2447 %llo or %llx format is passed. (Bug#8545)
2448
03ab8921
EZ
2449 * window.c (window_scroll_line_based): Use a marker instead of
2450 simple variables to record original value of point. (Bug#7952)
2451
afda1437
EZ
2452 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2453 produced by %s or %c overflows available buffer space. (Bug#8545)
2454
f76dee0c
PE
24552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2458 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2459
fdc5744d
JB
24602011-04-28 Juanma Barranquero <lekktu@gmail.com>
2461
2462 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2463
638f053a
JB
24642011-04-28 Juanma Barranquero <lekktu@gmail.com>
2465
2466 * keyboard.c (Qdelayed_warnings_hook): Define.
2467 (command_loop_1): Run `delayed-warnings-hook'
2468 if Vdelayed_warnings_list is non-nil.
2469 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2470 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2471
d178f871
EZ
24722011-04-28 Eli Zaretskii <eliz@gnu.org>
2473
2474 * doprnt.c (doprnt): Don't return value smaller than the buffer
2475 size if the message was truncated. (Bug#8545).
2476
b124fd93
JB
24772011-04-28 Juanma Barranquero <lekktu@gmail.com>
2478
2479 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2480 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2481
e810457d
PE
24822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2485
ea51cceb
JB
24862011-04-27 Juanma Barranquero <lekktu@gmail.com>
2487
2488 * makefile.w32-in: Update dependencies.
2489
94dcfacf
EZ
24902011-04-27 Eli Zaretskii <eliz@gnu.org>
2491
2492 Improve `doprnt' and its usage. (Bug#8545)
2493 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2494 `format_end'. Remove support for %l as a conversion specifier.
2495 Don't use xrealloc. Improve diagnostics when the %l size modifier
2496 is used. Update the commentary.
2497
2498 * eval.c (verror): Simplify calculation of size_t.
2499
2500 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2501 messages.
2502
f61f41d7
PE
25032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2504
2505 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2506 change.
2507
96fb4434
PE
25082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2509
2510 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2511 This makes this file independent of the recent pseudovector change.
2512
671875da 25132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2514
69e9b5a3
PE
2515 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2516
b5f869a7 2517 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2518 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2519 Remove unused local.
c8926152 2520 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2521
841a1577 2522 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2523 GCC 4.6.0 optimizes based on type-based alias analysis.
2524 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2525 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2526 != &v->size, and therefore "v->size = 1; b->size = 2; return
2527 v->size;" must therefore return 1. This assumption is incorrect
2528 for Emacs, since it type-puns struct Lisp_Vector * with many other
2529 types. To fix this problem, this patch adds a new type struct
f904488f 2530 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2531 and pseudovectors, and helps optimizing compilers not get fooled
2532 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2533 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2534 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2535 the size member.
eab3844f
PE
2536 (XSETPVECTYPE): Rewrite in terms of new macro.
2537 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2538 This is a bit clearer, and further avoids the possibility of
2539 undesirable aliasing.
2540 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2541 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2542 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2543 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2544 (ASIZE): Now uses header.size rather than size.
2545 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2546 to avoid the hassle of writing XVECTOR (foo)->header.size.
2547 (struct vectorlike_header): New type.
eab3844f
PE
2548 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2549 object, to help avoid aliasing.
2550 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2551 (SUBRP): Likewise, since Lisp_Subr is a special case.
2552 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2553 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2554 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2555 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2556 changed to be "header.size" and "header.next".
2557 * buffer.h (struct buffer): Likewise.
2558 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2559 * frame.h (struct frame): Likewise.
2560 * process.h (struct Lisp_Process): Likewise.
2561 * termhooks.h (struct terminal): Likewise.
2562 * window.c (struct save_window_data, struct saved_window): Likewise.
2563 * window.h (struct window): Likewise.
2564 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2565 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2566 * buffer.c (init_buffer_once): Likewise.
2567 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2568 special case.
2569 * process.c (Fformat_network_address): Use local var for size,
2570 for brevity.
2571
0df1eac5
PE
2572 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2573
847ab9d1 2574 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2575 * data.c (atof): Remove decl; no longer used or needed.
2576 (digit_to_number): Move to lread.c.
2577 (Fstring_to_number): Use new string_to_number function, to be
2578 consistent with how the Lisp reader treats infinities and NaNs.
2579 Do not assume that floating-point numbers represent EMACS_INT
2580 without losing information; this is not true on most 64-bit hosts.
2581 Avoid double-rounding errors, by insisting on integers when
2582 parsing non-base-10 numbers, as the documentation specifies.
2583 * lisp.h (string_to_number): New decl, replacing ...
2584 (isfloat_string): Remove.
bc0a5c13 2585 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2586 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2587 appears to have been a coding error. Similarly, do not accept
2588 strings like +-1e0 as floating point numbers. Do not report
2589 overflow for integer overflows unless the base is not 10 which
2590 means we have no simple and reliable way to continue.
2591 Break out the floating-point parsing into a new
2592 function string_to_number, so that Fstring_to_number parses
2593 floating point numbers consistently with the Lisp reader.
04f2d78b 2594 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2595 (E_CHAR, EXP_INT): Remove, replacing with ...
2596 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2597 (string_to_number): New function, replacing isfloat_string.
2598 This function checks for valid syntax and produces the resulting
2599 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2600 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2601 so that overflow for non-base-10 numbers is reported only when
2602 there's no portable and simple way to convert to floating point.
452f4150 2603
67769ffc
PE
2604 * textprop.c (set_text_properties_1): Rewrite for clarity,
2605 and to avoid GCC warning about integer overflow.
2606
c20db43f
PE
2607 * intervals.h (struct interval): Use EMACS_INT for members
2608 where EMACS_UINT might cause problems. See
2609 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2610 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2611 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2612 All uses changed.
37aa2f85
PE
2613 (offset_intervals): Tell GCC not to worry about length overflow
2614 when negating a negative length.
c20db43f 2615
2538aa2f
PE
2616 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2617 (overrun_check_free): Likewise.
2618
f2d3008d
PE
2619 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2620 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2621 word size.
2622
ec8df744
PE
2623 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2624 (gnutls_make_error): Rename local to avoid shadowing.
2625 (gnutls_emacs_global_deinit): ifdef out; not used.
2626 (Fgnutls_boot): Use const for pointer to readonly storage.
2627 Comment out unused local. Fix pointer signedness problems.
2628
640ee02d
PE
2629 * lread.c (openp): Don't stuff size_t into an 'int'.
2630 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2631 about possible signed overflow.
2632
6048fb2a
PE
2633 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2634 (GDK_KEY_g): Don't define if already defined.
2635 (xg_prepare_tooltip): Avoid pointer signedness problem.
2636 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2637
fa3c87e1
PE
2638 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2639 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2640
2172544b
PE
2641 * xfns.c (Fx_window_property): Simplify a bit,
2642 to make a bit faster and to avoid GCC 4.6.0 warning.
2643 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2644
9b821a21
PE
2645 * fns.c (internal_equal): Don't assume size_t fits in int.
2646
3c616cfa
PE
2647 * alloc.c (compact_small_strings): Tighten assertion a little.
2648
c2982e87
PE
2649 Replace pEd with more-general pI, and fix some printf arg casts.
2650 * lisp.h (pI): New macro, generalizing old pEd macro to other
2651 conversion specifiers. For example, use "...%"pI"d..." rather
2652 than "...%"pEd"...".
2653 (pEd): Remove. All uses replaced with similar uses of pI.
2654 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2655 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2656 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2657 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2658 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2659 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2660 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2661 64-bit hosts.
2662 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2663 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2664 * print.c (safe_debug_print, print_object): Likewise.
2665 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2666 to int.
6f04d126
PE
2667 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2668 avoiding the 0 flag, which is not portable.
c2982e87
PE
2669 * process.c (Fmake_network_process): Use pI to avoid cast.
2670 * region-cache.c (pp_cache): Likewise.
2671 * xdisp.c (decode_mode_spec): Likewise.
2672 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2673 behavior on 64-bit hosts with printf arg.
6f04d126 2674 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2675 (x_stop_queuing_selection_requests): Likewise.
2676 (x_get_window_property): Don't truncate byte count to an 'int'
2677 when tracing.
0b432f21 2678
5e073ec7
PE
2679 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2680 here, since it parses constructs like leading '-' and spaces,
2681 which are not wanted; and it overflows with large numbers.
2682 Instead, simply match F[0-9]+, which is what is wanted anyway.
2683
36372bf9
PE
2684 * alloc.c: Remove unportable assumptions about struct layout.
2685 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2686 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2687 (allocate_vectorlike, make_pure_vector): Use the new macros,
2688 plus offsetof, to remove unportable assumptions about struct layout.
2689 These assumptions hold on all porting targets that I know of, but
2690 they are not guaranteed, they're easy to remove, and removing them
2691 makes further changes easier.
2692
0b432f21
PE
2693 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2694 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2695 (string_overrun_cookie): Now const. Use initializers that
2696 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2697 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2698 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2699 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2700 multiple of sizeof (EMACS_INT); it need not be, if
2701 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2702 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2703
895009e1
JB
27042011-04-26 Juanma Barranquero <lekktu@gmail.com>
2705
2706 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2707
6a7a1b0b
TZ
27082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2709
2710 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2711 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2712 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2713
841a1577 27142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2715
2716 * lisp.h (Qdebug): List symbol.
895009e1 2717 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2718 * keyboard.c (debug-on-event): New variable.
2719 (handle_user_signal): Break into debugger when debug-on-event
2720 matches the current signal symbol.
2721
f2d3ba6f
DN
27222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2723
2724 * alloc.c (check_sblock, check_string_bytes)
2725 (check_string_free_list): Convert to standard C.
2726
42ce4c63
TZ
27272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2728
2729 * w32.c (emacs_gnutls_push): Fix typo.
2730
825cd63c
EZ
27312011-04-25 Eli Zaretskii <eliz@gnu.org>
2732
fb11d64d
EZ
2733 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2734 "cast to pointer from integer of different size".
2735
825cd63c
EZ
2736 Improve doprnt and its use in verror. (Bug#8545)
2737 * doprnt.c (doprnt): Document the set of format control sequences
2738 supported by the function. Use SAFE_ALLOCA instead of always
2739 using `alloca'.
2740
2741 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2742 is one byte too soon. Don't use xrealloc; instead xfree and
2743 xmalloc anew.
2744
e061a11b
TZ
27452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2746
2747 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2748 callbacks stage.
2749
2750 * gnutls.c: Renamed global_initialized to
2751 gnutls_global_initialized. Added internals for the
2752 :verify-hostname-error, :verify-error, and :verify-flags
2753 parameters of `gnutls-boot' and documented those parameters in the
2754 docstring. Start callback support.
2755 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2756 unless a fatal error occured. Call gnutls_alert_send_appropriate
2757 on error. Return error code.
2758 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2759 (emacs_gnutls_read): Likewise.
2760 (Fgnutls_boot): Return handshake error code.
2761 (emacs_gnutls_handle_error): New function.
2762 (wsaerror_to_errno): Likewise.
2763
2764 * w32.h (emacs_gnutls_pull): Add prototype.
2765 (emacs_gnutls_push): Likewise.
2766
2767 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2768 (emacs_gnutls_push): Likewise.
2769
27702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2771
2772 * process.c (wait_reading_process_output): Check if GnuTLS
2773 buffered some data internally if no FDs are set for TLS
2774 connections.
2775
2776 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2777 (LIBS): Link to USER_LIBS.
2778 ($(BLD)/gnutls.$(0)): New target.
2779
fa6996bc
EZ
27802011-04-24 Eli Zaretskii <eliz@gnu.org>
2781
eb35682e
EZ
2782 * xdisp.c (handle_single_display_spec): Rename the
2783 display_replaced_before_p argument into display_replaced_p, to
2784 make it consistent with the commentary. Fix typos in the
2785 commentary.
2786
e2ad650c
EZ
2787 * textprop.c (syms_of_textprop): Remove dead code.
2788 (copy_text_properties): Delete obsolete commentary about an
2789 interface that was deleted long ago. Fix typos in the description
2790 of arguments.
2791
1b2de274
EZ
2792 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2793 to changes in oldXMenu/XMenu.h from 2011-04-16.
2794 <menu_help_message, prev_menu_help_message>: Constify.
2795 (IT_menu_make_room): menu->help_text is now `const char **';
2796 adjust.
2797
2798 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2799 to changes in oldXMenu/XMenu.h from 2011-04-16.
2800 (struct XMenu): Declare `help_text' `const char **'.
2801
2802 * xfaces.c <Qunspecified>: Make extern again.
2803
2804 * syntax.c: Include sys/types.h before including regex.h, as
2805 required by Posix.
2806
762b15be
EZ
2807 * doc.c (get_doc_string): Improve the format passed to `error'.
2808
2809 * doprnt.c (doprnt): Improve commentary.
2810
2811 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2812
2813 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2814 them with etags.
2815
f1052e5d
EZ
2816 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2817 changes in globals.h immediately force recompilation.
762b15be
EZ
2818 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2819 $(CURDIR)/s/ms-w32.h.
2820 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2821
fa6996bc
EZ
2822 * character.c (Fchar_direction): Function deleted.
2823 (syms_of_character): Don't defsubr it.
2824 <char-direction-table>: Deleted.
2825
e6c3da20
EZ
28262011-04-23 Eli Zaretskii <eliz@gnu.org>
2827
2828 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2829 * doprnt.c: Include limits.h.
2830 (SIZE_MAX): New macro.
04f2d78b
CB
2831 (doprnt): Return a size_t value. 2nd arg is now size_t.
2832 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2833 Improve overflow protection. Support `l' modifier for integer
2834 conversions. Support %l conversion. Don't assume an EMACS_INT
2835 argument for integer conversions and for %c.
2836
2837 * lisp.h (doprnt): Restore prototype.
2838
2839 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2840 $(SRC)/character.h.
2841
2842 * Makefile.in (base_obj): Add back doprnt.o.
2843
2844 * deps.mk (doprnt.o): Add back prerequisites.
2845 (callint.o): Depend on character.h.
2846
2847 * eval.c (internal_lisp_condition_case): Include the handler
2848 representation in the error message.
2849 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2850 when breaking from the loop.
2851
2852 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2853
2854 * callint.c (Fcall_interactively): When displaying error message
2855 about invalid control letter, pass the character's codepoint, not
2856 a pointer to its multibyte form. Improve display of the character
2857 in octal and display also its hex code.
2858
2859 * character.c (char_string): Use %x to display the (unsigned)
2860 codepoint of an invalid character, to avoid displaying a bogus
2861 negative value.
2862
2863 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2864 `error', not SYMBOL_NAME itself.
2865
2866 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2867 character arguments to `error'.
2868
2869 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2870 to `error' in error message about FINAL_CHAR argument. Make sure
2871 FINAL_CHAR is a character, and use %c when it is passed as
2872 argument to `error'.
2873
4ffd0d6b 28742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2875
2876 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2877
2878 * w32.c: Include <time.h>.
2879 (sys_localtime): New function.
2880
4ffd0d6b 28812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2882
2883 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2884
4ffd0d6b 2885 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2886
4ffd0d6b 28872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2888
4ffd0d6b
GM
2889 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2890 zombies (Bug#8467).
aac0c6e3 2891
04c56954
EZ
28922011-04-19 Eli Zaretskii <eliz@gnu.org>
2893
2894 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2895 gl_state.e_property when gl_state.object is Qt.
2896
2897 * insdel.c (make_gap_larger): Remove limitation of buffer size
2898 to <= INT_MAX.
2899
16a43933
CY
29002011-04-18 Chong Yidong <cyd@stupidchicken.com>
2901
2902 * xdisp.c (lookup_glyphless_char_display)
2903 (produce_glyphless_glyph): Handle cons cell entry in
2904 glyphless-char-display.
2905 (Vglyphless_char_display): Document it.
2906
2907 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2908 glyphless-char-display.
2909
4581706e
CY
29102011-04-17 Chong Yidong <cyd@stupidchicken.com>
2911
2912 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2913
2914 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2915
2916 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2917 definition for no-X builds.
2918
4887c6e2 29192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2920
fd35b6f9
PE
2921 Static checks with GCC 4.6.0 and non-default toolkits.
2922
5c1ccb01
PE
2923 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2924
006c5daa
PE
2925 * process.c (keyboard_bit_set): Define only if SIGIO.
2926 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2927 (send_process): Repair possible setjmp clobbering.
2928
efc736d3
PE
2929 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2930
4e2fe2e6
PE
2931 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2932
f97334a2
PE
2933 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2934
4e75f29d
PE
2935 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2936 Define only if needed.
2937
90efadd1
PE
2938 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2939 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2940 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2941
3c647824
PE
2942 * dispextern.h (struct redisplay_interface): Rename param
2943 to avoid shadowing.
e264f262 2944 * termhooks.h (struct terminal): Likewise.
761383f4 2945 * xterm.c (xembed_send_message): Likewise.
3c647824 2946
b58c5c4a
PE
2947 * insdel.c (make_gap_smaller): Define only if
2948 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2949
cad59032
PE
2950 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2951 it.
2952
c339dc2e
PE
2953 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2954 so that we aren't warned about unused symbols.
2955
91a3e27b
PE
2956 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2957
399c71d3 2958 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2959
8ffc96f5
PE
2960 * xfns.c (x_real_positions): Mark locals as initialized.
2961
eef9bc79
PE
2962 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2963
098db9dd
PE
2964 * xterm.c: Fix problems found by static analysis with other toolkits.
2965 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2966 (x_dispatch_event): Declare static if USE_GTK, and
2967 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2968 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2969 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2970 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2971 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2972
eb18f6cc
PE
2973 * xmenu.c (menu_help_callback): Pointer type fixes.
2974 Use const pointers when pointing at readonly data. Avoid pointer
2975 signedness clashes.
2976 (FALSE): Remove unused macro.
2977 (update_frame_menubar): Remove unused decl.
2978
1fe72bf8
PE
2979 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2980
60d9e1db
PE
2981 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2982 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2983 (single_menu_item): Rename local to avoid shadowing.
2984
39261c26
PE
2985 * keyboard.c (make_lispy_event): Remove unused local var.
2986
018c5e19
PE
2987 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2988 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2989
63d2b86e
PE
2990 * bitmaps: Change bitmaps from unsigned char back to the X11
2991 compatible char. Avoid the old compiler warnings about
2992 out-of-range initializers by using, for example, '\xab' rather
2993 than 0xab.
2994
aefd87e1
PE
2995 * xgselect.c (xgselect_initialize): Check vs interface
2996 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2997
bf501fb9
PE
2998 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2999
e9829fdf
PE
3000 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3001 to read-only memory.
3002
1086c095
PE
3003 * fns.c (vector): Remove; this old hack is no longer needed.
3004
2baccd04 3005 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3006 Remove unused var.
dde42981 3007 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3008
72391843 3009 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3010
436c16df 3011 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3012 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3013 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3014
92bb796d 3015 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3016 (x_term_init): Remove local to avoid shadowing.
92bb796d 3017
764430a3 3018 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3019
3020 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3021 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3022
d1dfb56c
EZ
30232011-04-16 Eli Zaretskii <eliz@gnu.org>
3024
c4354cb4
EZ
3025 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3026
d1dfb56c
EZ
3027 Fix regex.c, syntax.c and friends for buffers > 2GB.
3028 * syntax.h (struct gl_state_s): Declare character position members
3029 EMACS_INT.
3030
3031 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3032
04f2d78b
CB
3033 * textprop.c (verify_interval_modification, interval_of):
3034 Declare arguments EMACS_INT.
d1dfb56c
EZ
3035
3036 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3037 EMACS_INT.
3038
3039 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3040
3041 * indent.c (Fvertical_motion): Local variable it_start is now
3042 EMACS_INT.
3043
3044 * regex.c (re_match, re_match_2, re_match_2_internal)
3045 (bcmp_translate, regcomp, regexec, print_double_string)
3046 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3047 (re_compile_pattern, re_exec): Declare arguments and local
3048 variables `size_t' and `ssize_t' and return values `regoff_t', as
3049 appropriate.
3050 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3051 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3052 <compile_stack_type>: `size' and `avail' are now `size_t'.
3053
3054 * regex.h <regoff_t>: Use ssize_t, not int.
3055 (re_search, re_search_2, re_match, re_match_2): Arguments that
3056 specify buffer/string position and length are now ssize_t and
3057 size_t. Return type is regoff_t.
3058
613052cd
BK
30592011-04-16 Ben Key <bkey76@gmail.com>
3060
3061 * nsfont.m: Fixed bugs in ns_get_family and
3062 ns_descriptor_to_entity that were caused by using free to
3063 deallocate memory blocks that were allocated by xmalloc (via
3064 xstrdup). This caused Emacs to crash when compiled with
3065 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3066 --enable-checking=xmallocoverrun). xfree is now used to
3067 deallocate these memory blocks.
3068
4170f62f 30692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3070
71b41406
PE
3071 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3072
9587a89d
PE
3073 emacs_write: Accept and return EMACS_INT for sizes.
3074 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3075 et seq.
3076 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3077 Accept and return EMACS_INT.
3078 (emacs_gnutls_write): Return the number of bytes written on
3079 partial writes.
3080 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3081 (emacs_read, emacs_write): Remove check for negative size, as the
3082 Emacs source code has been audited now.
9587a89d
PE
3083 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3084 (emacs_read, emacs_write): Use it.
273a5f82
PE
3085 * process.c (send_process): Adjust to the new signatures of
3086 emacs_write and emacs_gnutls_write. Do not attempt to store
3087 a byte offset into an 'int'; it might overflow.
9587a89d 3088 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3089
3e047f51
PE
3090 * sound.c: Don't assume sizes fit in 'int'.
3091 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3092 Return EMACS_INT, not int.
3e047f51 3093 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3094 Accept EMACS_INT, not int.
3095 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3096 record read return values.
3097
cc39a9db
BK
30982011-04-15 Ben Key <bkey76@gmail.com>
3099
c9d0ec6d
JB
3100 * keyboard.c (Qundefined): Don't declare static since it is used
3101 in nsfns.m.
3102 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3103 static since they are used in nsfont.m.
cc39a9db 3104
6c60eb9f
SM
31052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3106
3107 * process.c (Qprocessp): Don't declare static.
3108 * lisp.h (Qprocessp): Declare again.
3109
7990b61a
JB
31102011-04-15 Juanma Barranquero <lekktu@gmail.com>
3111
3112 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3113
5d4cb038
PE
31142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3115
8bd7b830 3116 Improve C-level modularity by making more things 'static'.
cd64ea1d 3117
e3b27b31
PE
3118 Don't publish debugger-only interfaces to other modules.
3119 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3120 (verify_bytepos, count_markers): Move decls to the only modules
3121 that need them.
3122 * region-cache.h (pp_cache): Likewise.
3123 * window.h (check_all_windows): Likewise.
3124 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3125
5d4cb038
PE
3126 * sysdep.c (croak): Now static, if
3127 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3128 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3129
3130 * alloc.c (refill_memory_reserve): Now static if
3131 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3132 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3133
e87b6180
PE
3134 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3135 Define only if USE_LUCID.
3136
ac64929e
PE
3137 * xrdb.c (x_customization_string, x_rm_string): Now static.
3138
6f37259d
PE
3139 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3140 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3141
1683e3ab
PE
3142 * xdisp.c (draw_row_with_mouse_face): Now static.
3143 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3144
de9c2632
PE
3145 * window.h (check_all_windows): Mark externally visible.
3146
2b96acb7
PE
3147 * window.c (window_deletion_count): Now static.
3148
3149 * undo.c: Make symbols static if they're not exported.
3150 (last_undo_buffer, last_boundary_position, pending_boundary):
3151 Now static.
3152
50436f33
PE
3153 * textprop.c (interval_insert_behind_hooks): Now static.
3154 (interval_insert_in_front_hooks): Likewise.
3155
64520e5c
PE
3156 * term.c: Make symbols static if they're not exported.
3157 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3158 (max_frame_lines, tty_set_terminal_modes):
3159 (tty_reset_terminal_modes, tty_turn_off_highlight):
3160 (get_tty_terminal): Now static.
3161 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3162 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3163 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3164 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3165 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3166
1fa53021
PE
3167 * sysdep.c: Make symbols static if they're not exported.
3168 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3169 Now static.
3170 (sigprocmask_set, full_mask): Remove; unused.
3171 (wait_debugging): Mark as visible.
3172 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3173 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3174
d4b43b22
PE
3175 * syntax.c (syntax_temp): Define only if !__GNUC__.
3176
b7c513d0
PE
3177 * sound.c (current_sound_device, current_sound): Now static.
3178
989b29ad
PE
3179 * search.c (searchbufs, searchbuf_head): Now static.
3180
13a55a78
PE
3181 * scroll.c (scroll_cost): Remove; unused.
3182 * dispextern.h (scroll_cost): Remove decl.
3183
de68a1fc
PE
3184 * region-cache.h (pp_cache): Mark as externally visible.
3185
40ccffa6
PE
3186 * process.c: Make symbols static if they're not exported.
3187 (process_tick, update_tick, create_process, chan_process):
3188 (Vprocess_alist, proc_buffered_char, datagram_access):
3189 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3190 (deactivate_process): Mark defn as static, as well as decl.
3191 * lisp.h (create_process): Remove decl.
3192 * process.h (chan_process, Vprocess_alist): Remove decls.
3193
ad64fc97
PE
3194 * print.c: Make symbols static if they're not exported.
3195 (print_depth, new_backquote_output, being_printed, print_buffer):
3196 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3197 (print_interval, print_number_index, initial_stderr_stream):
3198 Now static.
3199 * lisp.h (Fprinc): Remove decl.
3200 (debug_output_compilation_hack): Mark as externally visible.
3201
adddb265
PE
3202 * sysdep.c (croak): Move decl from here to syssignal.h.
3203 * syssignal.h (croak): Put it here, so the API can be checked when
3204 'croak' is called from dissociate_if_controlling_tty.
3205
1717ede2
PE
3206 * minibuf.c: Make symbols static if they're not exported.
3207 (minibuf_save_list, choose_minibuf_frame): Now static.
3208 * lisp.h (choose_minibuf_frame): Remove decl.
3209
fa5fb2bc
PE
3210 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3211
1e3890d1
PE
3212 * lread.c: Make symbols static if they're not exported.
3213 (read_objects, initial_obarray, oblookup_last_bucket_number):
3214 Now static.
3215 (make_symbol): Remove; unused.
3216 * lisp.h (initial_obarray, make_symbol): Remove decls.
3217
8a1414fa
PE
3218 * keyboard.c: Make symbols static if they're not exported.
3219 (single_kboard, recent_keys_index, total_keys, recent_keys):
3220 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3221 (this_single_command_key_start, echoing, last_auto_save):
3222 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3223 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3224 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3225 (Vlispy_mouse_stem, double_click_count):
3226 Now static.
3227 (force_auto_save_soon): Define only if SIGDANGER.
3228 (ignore_mouse_drag_p): Now static if
3229 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3230 (print_help): Remove; unused.
3231 (stop_character, last_timer_event): Mark as externally visible.
3232 * keyboard.h (ignore_mouse_drag_p): Declare only if
3233 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3234 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3235 * lisp.h (echoing): Remove decl.
3236 (force_auto_save_soon): Declare only if SIGDANGER.
3237 * xdisp.c (redisplay_window): Simplify code, to make it more
3238 obvious that ignore_mouse_drag_p is not accessed if !defined
3239 USE_GTK && !defined HAVE_NS.
3240
93ea6e8f
PE
3241 * intervals.c: Make symbols static if they're not exported.
3242 (merge_properties_sticky, merge_interval_right, delete_interval):
3243 Now static.
3244 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3245
77382fcc
PE
3246 * insdel.c: Make symbols static if they're not exported.
3247 However, leave prepare_to_modify_buffer alone. It's never
3248 called from outside this function, but that appears to be a bug.
3249 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3250 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3251 (adjust_after_replace_noundo): Remove; unused.
3252 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3253 (signal_before_change): Remove decls.
77382fcc 3254
9306c32e
PE
3255 * indent.c (val_compute_motion, val_vmotion): Now static.
3256
cd44d2eb
PE
3257 * image.c: Make symbols static if they're not exported.
3258 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3259 if USE_GTK.
3260 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3261 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3262
ad9a7a06
PE
3263 * fringe.c (standard_bitmaps): Now static.
3264 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3265
81626931
PE
3266 * frame.c: Make symbols static if they're not exported.
3267 (x_report_frame_params, make_terminal_frame): Now static.
3268 (get_frame_param): Now static, unless HAVE_NS.
3269 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3270 (x_get_resource_string): Remove; not used.
3271 * frame.h (make_terminal_frame, x_report_frame_params):
3272 (x_get_resource_string); Remove decls.
3273 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3274 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3275
239f9db9
PE
3276 * font.c, fontset.c: Make symbols static if they're not exported.
3277 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3278 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3279 * font.c (font_close_object): Now static.
3280 * font.h (font_close_object): Remove.
3281 * fontset.c (FONTSET_OBJLIST): Remove.
3282 (free_realized_fontset) #if-0 the body, which does nothing.
3283 (face_suitable_for_char_p): #if-0, as it's never called.
3284 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3285 * xfaces.c (face_at_string_position):
3286 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3287 since 0 is always ASCII.
3288
dfcf3579
PE
3289 * fns.c (weak_hash_tables): Now static.
3290
5045092b
PE
3291 * fileio.c: Make symbols static if they're not exported.
3292 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3293 (Vwrite_region_annotation_buffers): Now static.
3294
57a96f5c
PE
3295 * eval.c: Make symbols static if they're not exported.
3296 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3297 * lisp.h (backtrace_list): Remove decl.
3298
35f08c38
PE
3299 * emacs.c: Make symbols static if they're not exported.
3300 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3301 (fatal_error_code, fatal_error_signal_hook, standard_args):
3302 Now static.
3303 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3304 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3305 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3306 * lisp.h (fatal_error_signal_hook): Remove decl.
3307 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3308
f44bd759
PE
3309 * editfns.c: Move a (normally-unused) function to its only use.
3310 * editfns.c, lisp.h (get_operating_system_release): Remove.
3311 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3312 worth the hassle of breaking this out.
3313
b532497d
PE
3314 * xterm.c: Make symbols static if they're not exported.
3315 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3316 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3317 (x_destroy_window, x_delete_display):
3318 Now static.
3319 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3320 (x_mouse_leave): Remove; unused.
3321 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3322 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3323 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3324 Remove decls.
3325 (x_mouse_leave): Declare only if WINDOWSNT.
3326 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3327 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3328 USE_X_TOOLKIT.
3329
1675728f
PE
3330 * ftxfont.c: Make symbols static if they're not exported.
3331 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3332 HAVE_FREETYPE.
3333 * font.h (ftxfont_driver): Likewise.
3334
e4cebfca
PE
3335 * xfns.c: Make symbols static if they're not exported.
3336 (x_last_font_name, x_display_info_for_name):
3337 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3338 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3339 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3340 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3341 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3342 (last_show_tip_args): Now static.
3343 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3344 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3345 (x_screen_planes): Remove; unused.
3346 * dispextern.h (x_screen_planes): Remove decl.
3347
5bf46f05
PE
3348 * dispnew.c: Make symbols static if they're not exported.
3349 * dispextern.h (redraw_garbaged_frames, scrolling):
3350 (increment_row_positions): Remove.
3351 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3352 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3353 Now static.
3354 (redraw_garbaged_frames): Remove; unused.
3355
435f4c28
PE
3356 * xfaces.c: Make symbols static if they're not exported.
3357 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3358 Remove decls.
3359 * xterm.h (defined_color): Remove decls.
3360 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3361 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3362 (menu_face_changed_default, defined_color, free_realized_face):
3363 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3364 (ascii_face_of_lisp_face): Remove; unused.
3365
8524aef3
PE
3366 * xdisp.c: Make symbols static if they're not exported.
3367 * dispextern.h (scratch_glyph_row, window_box_edges):
3368 (glyph_to_pixel_coords, set_cursor_from_row):
3369 (get_next_display_element, set_iterator_to_next):
3370 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3371 (show_mouse_face): Remove decls
3372 * frame.h (message_buf_print): Likewise.
3373 * lisp.h (pop_message, set_message, check_point_in_composition):
3374 Likewise.
3375 * xterm.h (set_vertical_scroll_bar): Likewise.
3376 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3377 (message_buf_print, scratch_glyph_row, displayed_buffer):
3378 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3379 (get_next_display_element, show_mouse_face, window_box_edges):
3380 (frame_to_window_pixel_xy, check_point_in_composition):
3381 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3382 (glyph_to_pixel_coords): Remove; unused.
3383
16390cd2
PE
3384 * dired.c (file_name_completion): Now static.
3385
3386 * dbusbind.c (xd_in_read_queued_messages): Now static.
3387
a25f4dfa
PE
3388 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3389 * data.c (circular_list_error): Remove.
3390
14a9c8df
PE
3391 * commands.h (last_point_position, last_point_position_buffer):
3392 (last_point_position_window): Remove decls.
3393 * keyboard.c: Make these variables static.
3394
04f2d78b
CB
3395 * coding.h (coding, code_convert_region, encode_coding_gap):
3396 Remove decls.
74ab6df5
PE
3397 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3398 (iso_code_class, detect_coding, code_convert_region): Now static.
3399 (encode_coding_gap): Remove; unused.
3400
38dfbee1
PE
3401 * chartab.c (chartab_chars, chartab_bits): Now static.
3402
a2cb4e63
PE
3403 * charset.h (charset_iso_8859_1): Remove decl.
3404 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3405 Now static.
3406
127198fd
PE
3407 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3408 * ccl.c (Vccl_program_table): Now static.
3409 (check_ccl_update): Remove; unused.
3410
d85b608f
PE
3411 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3412 * category.h: ... from here.
3413 * category.c (check_category_table, set_category_set): Now static.
3414
31cd66f3
PE
3415 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3416 * lisp.h: Remove these decls.
3417
c358e587
PE
3418 * buffer.c (buffer_count): Remove unused var.
3419
e78aecca
PE
3420 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3421 so that it's not optimized away.
3422 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3423 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3424 exported only to the debugger.
3425
e192d7d3 3426 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3427 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3428
92470028
PE
3429 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3430 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3431 was inaccessible from Lisp.
3432 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3433 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3434
244ed907
PE
3435 alloc.c: Import and export fewer symbols, and remove unused items.
3436 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3437 is defined.
3438 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3439 it's not optimized away by whole-program optimization.
3440 (message_enable_multibyte, free_misc): Remove.
3441 (catchlist, handlerlist, mark_backtrace):
3442 Declare only if BYTE_MARK_STACK.
3443 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3444 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3445 (message_enable_multibyte): Remove decl.
3446 (free_misc, interval_free_list, float_block, float_block_index):
3447 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3448 (cons_free_list, last_marked_index):
3449 Now static.
3450 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3451 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3452 (mark_backtrace): Define only if BYTE_MARK_STACK.
3453 * xdisp.c (message_enable_multibyte): Now static.
3454
61c2b50e 3455 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3456 This makes it easier for human readers (and static analyzers)
3457 to see whether these variables are used from other modules.
3458 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3459 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3460 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3461 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3462 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3463 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3464 * xmenu.c, xselect.c:
3465 Declare Q* vars static if they are not used in other modules.
3466 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3467 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3468 Remove decls of unexported vars.
3469 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3470
95c82688
PE
3471 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3472
16a97296
PE
3473 Make Emacs functions such as Fatom 'static' by default.
3474 This makes it easier for human readers (and static analyzers)
3475 to see whether these functions can be called from other modules.
3476 DEFUN now defines a static function. To make the function external
3477 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3478 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3479 (Finit_image_library):
16a97296
PE
3480 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3481 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3482 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3483 Remove decls, since these functions are now static.
3484 (Funintern, Fget_internal_run_time): New decls, since these functions
3485 were already external.
95c82688 3486
16a97296
PE
3487 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3488 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3489 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3490 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3491 * keyboard.c, keymap.c, lread.c:
3492 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3493 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3494 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3495 Mark functions with DEFUE instead of DEFUN,
3496 if they are used in other modules.
3497 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3498 decls for now-static functions.
3499 * buffer.h (Fdelete_overlay): Remove decl.
3500 * callproc.c (Fgetenv_internal): Mark as internal.
3501 * composite.c (Fremove_list_of_text_properties): Remove decl.
3502 (Fcomposition_get_gstring): New forward static decl.
3503 * composite.h (Fcomposite_get_gstring): Remove decl.
3504 * dired.c (Ffile_attributes): New forward static decl.
3505 * doc.c (Fdocumntation_property): New forward static decl.
3506 * eval.c (Ffetch_bytecode): New forward static decl.
3507 (Funintern): Remove extern decl; now in .h file where it belongs.
3508 * fileio.c (Fmake_symbolic_link): New forward static decl.
3509 * image.c (Finit_image_library): New forward static decl.
3510 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3511 * intervals.h (Fprevious_property_change):
3512 (Fremove_list_of_text_properties): Remove decls.
3513 * keyboard.c (Fthis_command_keys): Remove decl.
3514 (Fcommand_execute): New forward static decl.
3515 * keymap.c (Flookup_key): New forward static decl.
3516 (Fcopy_keymap): Now static.
3517 * keymap.h (Flookup_key): Remove decl.
3518 * process.c (Fget_process): New forward static decl.
3519 (Fprocess_datagram_address): Mark as internal.
3520 * syntax.c (Fsyntax_table_p): New forward static decl.
3521 (skip_chars): Remove duplicate decl.
3522 * textprop.c (Fprevious_property_change): New forward static decl.
3523 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3524 Now internal.
3525 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3526 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3527
785bbd42
PE
3528 * editfns.c (Fformat): Remove unreachable code.
3529
8b913b57
AS
35302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3531
3532 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3533 change. (Bug#8496)
3534
a6744a35
EZ
35352011-04-13 Eli Zaretskii <eliz@gnu.org>
3536
3537 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3538 when at ZV. (Bug#8487)
3539
e7974947
AS
35402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3541
baad03f0
AS
3542 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3543 (Bug#8437)
3544 * keyboard.c (parse_tool_bar_item): Likewise.
3545 * sound.c (sound_cleanup, alsa_close): Likewise.
3546 * termcap.c (tgetent): Likewise.
3547 * xfns.c (x_default_font_parameter): Likewise.
3548 * xsettings.c (read_and_apply_settings): Likewise.
3549
e7974947
AS
3550 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3551 (overrun_check_free): Protoize.
3552
28272684
PE
35532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3556 since callers should never pass a negative size.
3557 Change the signature to match that of plain 'read' and 'write'; see
3558 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3559 * lisp.h: Update prototypes of emacs_write and emacs_read.
3560
11997c76
EZ
35612011-04-11 Eli Zaretskii <eliz@gnu.org>
3562
3563 * xdisp.c (redisplay_window): Don't try to determine the character
3564 position of the scroll margin if the window start point w->startp
e896f03c 3565 is outside the buffer's accessible region. (Bug#8468)
11997c76 3566
8a2cbd72
EZ
35672011-04-10 Eli Zaretskii <eliz@gnu.org>
3568
3569 Fix write-region and its subroutines for buffers > 2GB.
3570 * fileio.c (a_write, e_write): Modify declaration of arguments and
3571 local variables to support buffers larger than 2GB.
3572 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3573
3574 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3575 argument, local variables, and return value.
3576
3577 * lisp.h: Update prototypes of emacs_write and emacs_read.
3578
3579 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3580
4073e537 35812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3582
1ebfdcb6
PE
3583 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3584
b2ded58d
PE
3585 Fix more problems found by GCC 4.6.0's static checks.
3586
7d66342c
PE
3587 * xdisp.c (vmessage): Use a better test for character truncation.
3588
bbf47d44
PE
3589 * charset.c (load_charset_map): <, not <=, for optimization,
3590 and to avoid potential problems with integer overflow.
9248994d 3591 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3592 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3593 * editfns.c (Fformat): Likewise.
1e69125e 3594 * syntax.c (skip_chars): Likewise.
3befa583 3595
e3019616
PE
3596 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3597 This also lets GCC 4.6.0 generate slightly better loop code.
3598
becfa255
PE
3599 * callint.c (Fcall_interactively): <, not <=, for optimization.
3600 (Fcall_interactively): Count the number of arguments produced,
3601 not the number of arguments given. This is simpler and lets GCC
3602 4.6.0 generate slightly better code.
3603
dae0cd48
PE
3604 * ftfont.c: Distingish more carefully between FcChar8 and char.
3605 The previous code passed unsigned char * to a functions like
3606 strlen and xstrcasecmp that expect char *, which does not
3607 conform to the C standard.
3608 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3609 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3610 char * when the C standard requires it.
3611
76032d70
PE
3612 * keyboard.c (read_char): Remove unused var.
3613
eb3f1cc8
PE
3614 * eval.c: Port to Windows vsnprintf (Bug#8435).
3615 Include <limits.h>.
3616 (SIZE_MAX): Define if the headers do not.
3617 (verror): Do not give up if vsnprintf returns a negative count.
3618 Instead, grow the buffer. This ports to Windows vsnprintf, which
3619 does not conform to C99. Problem reported by Eli Zaretskii.
3620 Also, simplify the allocation scheme, by avoiding the need for
3621 calling realloc, and removing the ALLOCATED variable.
3622
70476b54
PE
3623 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3624
12020a9e
PE
3625 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3626 But keep the doprint source code for now, as we might revamp it
3627 and use it again (Bug#8435).
ea6c7ae6
PE
3628 * lisp.h (doprnt): Remove.
3629 * Makefile.in (base_obj): Remove doprnt.o.
3630 * deps.mk (doprnt.o): Remove.
3631
5fdb398c
PE
3632 error: Print 32- and 64-bit integers portably (Bug#8435).
3633 Without this change, on typical 64-bit hosts error ("...%d...", N)
3634 was used to print both 32- and 64-bit integers N, which relied on
3635 undefined behavior.
3636 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3637 New macro.
3638 * lisp.h (error, verror): Mark as printf-like functions.
3639 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3640 Report overflow in size calculations when allocating printf buffer.
3641 Do not truncate output string at its first null byte.
3642 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3643 Truncate the output at a character boundary, since vsnprintf does not
3644 do that.
3645 * charset.c (check_iso_charset_parameter): Convert internal
3646 character to string before calling 'error', since %c now has the
3647 printf meaning.
3648 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3649 overflow when computing char to be passed to 'error'. Do not
3650 pass Lisp_Object to 'error'; pass the integer instead.
3651 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3652 formatted with plain %d.
3653
b189fa66
PE
3654 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3655
bff87ef0
PE
3656 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3657
7e2cac20
PE
3658 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3659
ce4d90b5
PE
3660 * xterm.c (x_catch_errors): Remove duplicate declaration.
3661
266c9547
PE
3662 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3663
79c49ad2
PE
3664 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3665
368f4090
JM
36662011-04-10 Jim Meyering <meyering@redhat.com>
3667
3668 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3669 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3670 return ssize_t not "int", and use size_t as the buffer length.
3671 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3672 * gnutls.h: Update declarations.
3673 * process.c (read_process_output): Use ssize_t, to match.
3674 (send_process): Likewise.
3675
a32d4040
CY
36762011-04-09 Chong Yidong <cyd@stupidchicken.com>
3677
3678 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3679
8546720e 36802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3681
04f2d78b
CB
3682 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3683 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3684
8546720e
GM
3685 * xterm.c (handle_one_xevent):
3686 * xmenu.c (create_and_show_popup_menu):
3687 * xselect.c (x_decline_selection_request)
3688 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3689
0a2f5c1a 36902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3691
3692 Fix some uses of `int' instead of EMACS_INT.
3693 * search.c (string_match_1, fast_string_match)
3694 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3695 (scan_buffer, find_next_newline_no_quit)
3696 (find_before_next_newline, search_command, Freplace_match)
3697 (Fmatch_data): Make some `int' variables be EMACS_INT.
3698
3699 * xdisp.c (display_count_lines): 3rd argument and return value now
3700 EMACS_INT. All callers changed.
3701 (pint2hrstr): Last argument is now EMACS_INT.
3702
3703 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3704 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3705 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3706 (decode_coding_utf_16, decode_coding_emacs_mule)
3707 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3708 (decode_coding_ccl, decode_coding_charset)
3709 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3710 (decode_coding_iso_2022, decode_coding_emacs_mule)
3711 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3712 <char_offset, last_offset>: Declare EMACS_INT.
3713 (encode_coding_utf_8, encode_coding_utf_16)
3714 (encode_coding_emacs_mule, encode_invocation_designation)
3715 (encode_designation_at_bol, encode_coding_iso_2022)
3716 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3717 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3718 Declare EMACS_INT.
3719 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3720 (encode_invocation_designation): Last argument P_NCHARS is now
3721 EMACS_INT.
3722 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3723 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3724
3725 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3726 All users changed.
3727
3728 * ccl.c (Fccl_execute_on_string): Declare some variables
3729 EMACS_INT.
3730
8546720e 37312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3732
3733 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3734
4e19a977
CS
37352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3736
3737 * process.c (Fformat_network_address): Doc fix.
3738
87302331
R
37392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3740
3741 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3742
cbb59342
CY
37432011-04-08 Chong Yidong <cyd@stupidchicken.com>
3744
3745 * keyboard.c (read_char): Call Lisp function help-form-show,
3746 instead of using internal_with_output_to_temp_buffer.
3747 (Qhelp_form_show): New var.
e0d38eeb 3748 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3749
3750 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3751
3752 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3753
e67a13ab
CY
37542011-04-06 Chong Yidong <cyd@stupidchicken.com>
3755
04f2d78b
CB
3756 * process.c (Flist_processes): Remove to Lisp.
3757 (list_processes_1): Delete.
e67a13ab 3758
973f782d
EZ
37592011-04-06 Eli Zaretskii <eliz@gnu.org>
3760
7c106b1e
EZ
3761 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3762
973f782d
EZ
3763 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3764
41cf7d1a 37652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3766
ca23cc88
PE
3767 Fix more problems found by GCC 4.6.0's static checks.
3768
f390e2d5
PE
3769 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3770
42eea0d0
PE
3771 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3772
b69769da 3773 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3774
f9541e84
PE
3775 * xdisp.c (vmessage): Mark as a printf-like function.
3776
13841b55
PE
3777 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3778
c136c10f
PE
3779 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3780
5e2d4a30
PE
3781 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3782 printf-like functions.
3783 (tiff_load): Add casts to remove these marks before passing them
3784 to system-supplied API.
3785
583f48b9
PE
3786 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3787
b25d760e
PE
3788 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3789 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3790 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3791 directly, rather than having caller test rule sign. This avoids
3792 some unnecessary tests.
3793 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3794 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3795 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3796
bc7b6697 3797 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3798 (xfont_open): Avoid unnecessary tests.
bc7b6697 3799
27ccc379
PE
3800 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3801
dcd5c89a
PE
3802 * composite.h, composite.c (composition_gstring_put_cache):
3803 Use EMACS_INT, not int, for length.
3804
b13a45c6
PE
3805 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3806 breaking out part of COMPOSITION_DECODE_RULE.
3807 (COMPOSITION_DECODE_RULE): Use it.
3808 * composite.c (get_composition_id): Remove unused local vars,
3809 by using the new macro.
3810
1e792e4d
PE
3811 * textprop.c (set_text_properties_1): Change while to do-while,
3812 since the condition is always true at first.
3813
dc6c6455 3814 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3815 (interval_deletion_adjustment): Return unsigned value.
3816 All uses changed.
dc6c6455 3817
aba7731a
PE
3818 * process.c (list_processes_1, create_pty, read_process_output):
3819 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3820 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3821 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3822 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3823 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3824
fdfc4bf3
PE
3825 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3826
fca8fe46 3827 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3828 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3829
06a0259a 3830 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3831 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3832 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3833
e7b9e80f
PE
3834 * print.c (print_error_message): Avoid int overflow.
3835
56201685
PE
3836 * font.c (font_list_entities): Redo for clarity,
3837 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3838
78834453 3839 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3840 (font_score): Avoid potential overflow in diff calculation.
78834453 3841
0bc0b309 3842 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3843 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3844
e610eaca
PE
3845 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3846
b895abce
PE
3847 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3848 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3849 can always succeed if overflow has undefined behavior.
3850
1f1d9321 3851 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3852 (wordify): Omit three unnecessary tests.
1f1d9321 3853
c59478bc
PE
3854 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3855 All callers changed. This avoids the need for an unused var.
3856
79b73827
PE
3857 * casefiddle.c (casify_region): Remove var that is set but not used.
3858
a4db5dfe
PE
3859 * dired.c (file_name_completion): Remove var that is set but not used.
3860
43aae36e
PE
3861 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3862
2a47c44d 3863 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3864 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3865
a37c69bf
PE
3866 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3867 Check for integer overflow on size calculations.
3868
328ab8e7
PE
3869 * buffer.c (Fprevious_overlay_change): Remove var that is set
3870 but not used.
3871
e5a2a5cb
PE
3872 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3873 Remove vars that are set but not used.
8d84a6eb 3874 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3875 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3876
a60e5f68
PE
3877 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3878
f661cb61 3879 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3880 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3881
f0397f5a
PE
3882 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3883 that are set but not used.
3884
8664db06 3885 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3886 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3887
6abdaa4a
PE
3888 * xselect.c (x_get_local_selection, x_handle_property_notify):
3889 Remove vars that are set but not used.
3890
0ce7538d 3891 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3892 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3893
9ae848fc
PE
3894 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3895 Remove var that is set but not used.
0b918413
PE
3896 (scroll_bar_windows_size): Now size_t, not int.
3897 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3898 Check for overflow.
9ae848fc 3899
a5a62657
PE
3900 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3901 (map_tty_color) [!defined MSDOS]: Likewise.
3902
5c5cdd39
PE
3903 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3904
66ebf983
PE
3905 * coding.c: Remove vars that are set but not used.
3906 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3907 All callers changed.
3908 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3909 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3910 (decode_coding_charset): Remove vars that are set but not used.
3911
1be4d761
PE
3912 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3913 that is set but not used.
3914
47553fa8
PE
3915 * print.c (print_object): Remove var that is set but not used.
3916
1f7196bf 3917 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3918 The gnulib version avoids calling malloc in the usual case,
3919 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3920 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3921 * filelock.c (current_lock_owner): Likewise.
3922 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3923 * sysdep.c: Include allocator.h, careadlinkat.h.
3924 (emacs_no_realloc_allocator): New static constant.
3925 (emacs_readlink): New function.
fdb61804
PE
3926 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3927 ../lib/careadlinkat.h.
d1fdcab7 3928
f84c17c7
SM
39292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3930
3931 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3932 first non-nil return value).
3933
ef3862ad
JD
39342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3935
3936 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3937 if not defined (Bug#8403).
3938
376a7006
JB
39392011-04-02 Juanma Barranquero <lekktu@gmail.com>
3940
3941 * xdisp.c (display_count_lines): Remove parameter `start',
3942 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3943 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3944 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3945 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3946 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3947 and thereabouts. All callers changed.
3948 (get_per_char_metric): Remove parameter `f', unused since
3949 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3950
6ca3801d
JM
39512011-04-02 Jim Meyering <meyering@redhat.com>
3952
3953 do not dereference NULL upon failed strdup
3954 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3955 (ns_get_family): Likewise.
3956
d8e2b5ba
JB
39572011-04-02 Juanma Barranquero <lekktu@gmail.com>
3958
3959 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3960
8c74fcbd
JD
39612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3962
3963 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3964 later (Bug#8403).
3965
7200d79c
SM
39662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3967
03408648 3968 Add lexical binding.
7200d79c 3969
03408648
SM
3970 * window.c (Ftemp_output_buffer_show): New fun.
3971 (Fsave_window_excursion):
3972 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3973
3974 * lread.c (lisp_file_lexically_bound_p): New function.
3975 (Fload): Bind Qlexical_binding.
3976 (readevalloop): Remove `evalfun' arg.
3977 Bind Qinternal_interpreter_environment.
3978 (Feval_buffer): Bind Qlexical_binding.
3979 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3980 Mark as dynamic.
3981 (syms_of_lread): Declare `lexical-binding'.
3982
3983 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3984
3985 * keyboard.c (eval_dyn): New fun.
3986 (menu_item_eval_property): Use it.
ca105506
SM
3987
3988 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3989
03408648
SM
3990 * fns.c (concat, mapcar1): Accept byte-code-functions.
3991
3992 * eval.c (Fsetq): Handle lexical vars.
3993 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3994 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3995 (FletX, Flet): Obey lexical binding.
3996 (Fcommandp): Handle closures.
3997 (Feval): New `lexical' arg.
3998 (eval_sub): New function extracted from Feval. Use it almost
3999 everywhere where Feval was used. Look up vars in lexical env.
4000 Handle closures.
4001 (Ffunctionp): Move from subr.el.
4002 (Ffuncall): Handle closures.
4003 (apply_lambda): Remove `eval_flags'.
4004 (funcall_lambda): Handle closures and new byte-code-functions.
4005 (Fspecial_variable_p): New function.
4006 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4007 but without exporting it to Lisp.
23aba0ea 4008
23aba0ea 4009 * doc.c (Fdocumentation, store_function_docstring):
03408648 4010 * data.c (Finteractive_form): Handle closures.
23aba0ea 4011
03408648
SM
4012 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4013 interactive spec.
ba83908c 4014
04f2d78b
CB
4015 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4016 New byte-codes.
03408648
SM
4017 (exec_byte_code): New function extracted from Fbyte_code to handle new
4018 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4019
03408648 4020 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4021
03408648 4022 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4023
e2abce01
JB
40242011-03-31 Juanma Barranquero <lekktu@gmail.com>
4025
4026 * xdisp.c (redisplay_internal): Fix prototype.
4027
63696a73 40282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4029
63696a73 4030 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4031 (try_scrolling): Use it when setting scroll_limit.
4032 Limit scrolling to 100 screen lines.
63696a73
EZ
4033 (redisplay_window): Even when falling back on "recentering",
4034 position point in the window according to scroll-conservatively,
4035 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4036
4037 (try_scrolling): When point is above the window, allow searching
4038 as far as scroll_max, or one screenful, to compute vertical
4039 distance from PT to the scroll margin position. This prevents
4040 try_scrolling from unnecessarily failing when
4041 scroll-conservatively is set to a value slightly larger than the
4042 window height. Clean up the case of PT below the margin at bottom
4043 of window: scroll_max can no longer be INT_MAX. When aggressive
4044 scrolling is in use, don't let point enter the opposite scroll
4045 margin as result of the scroll.
4046 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4047 threshold of 100 lines for never-recentering scrolling.
4048
e4cc2dfc
JB
40492011-03-31 Juanma Barranquero <lekktu@gmail.com>
4050
4051 * dispextern.h (move_it_by_lines):
4052 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4053 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4054 (message_log_check_duplicate): Remove parameters `prev_bol' and
4055 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4056 (redisplay_internal): Remove parameter `preserve_echo_area',
4057 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4058
4059 * indent.c (Fvertical_motion):
4060 * window.c (window_scroll_pixel_based, Frecenter):
4061 Don't pass `need_y_p' to `move_it_by_lines'.
4062
1c470562
SM
40632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4064
44f230aa
SM
4065 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4066 steal a few bits to be more compact.
4067 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4068 Remove unneeded casts.
4069
1c470562
SM
4070 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4071
888adce9
ZK
40722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4073
4074 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4075 binding" message (bug#7967).
4076
f838ed7b
PE
40772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4078
77861b95
PE
4079 Fix more problems found by GCC 4.6.0's static checks.
4080
de6dbc14
PE
4081 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4082 Remove unused local var.
4083
f838ed7b
PE
4084 * editfns.c (Fmessage_box): Remove unused local var.
4085
792c7b2b
PE
4086 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4087 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4088 Omit unused local vars.
c499e557 4089 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4090 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4091 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4092 Omit unused local var.
4093
ba0165e1
PE
4094 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4095 Don't assume string length fits in int.
32ad8845 4096 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4097 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4098
3c59b4c9
PE
4099 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4100 instead of alloca (Bug#8344).
4101
a3eed478 4102 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4103 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4104
eb4d412d
PE
4105 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4106
1658b401
PE
4107 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4108 concerns.
4109
4110 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4111
4112 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4113
9a2c6e05
PE
4114 * keyboard.c (syms_of_keyboard): Use the same style as later
4115 in this function when indexing through an array. This also
4116 works around GCC bug 48267.
4117
03d0a109
PE
4118 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4119
44f730c8
PE
4120 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4121
fe75f926
PE
4122 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4123 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4124
ffa8c828
PE
4125 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4126 This avoids undefined behavior on integer overflow, and is a bit
4127 more convenient anyway since it is compared to a size_t variable.
4128
c5101a77
PE
4129 Variadic C functions now count arguments with size_t, not int.
4130 This avoids an unnecessary limitation on 64-bit machines, which
4131 caused (substring ...) to crash on large vectors (Bug#8344).
4132 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4133 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4134 All variadic functions and their callers changed accordingly.
c5101a77
PE
4135 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4136 * data.c (arith_driver, float_arith_driver): Likewise.
4137 * editfns.c (general_insert_function): Likewise.
4138 * eval.c (struct backtrace.nargs, interactive_p)
4139 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4140 (funcall_lambda, mark_backtrace): Likewise.
4141 * fns.c (concat): Likewise.
4142 * frame.c (x_set_frame_parameters): Likewise.
4143 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4144 0 if not found, not -1. All callers changed.
4145
dd3f25f7
PE
4146 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4147 (stack_copy_size): Now size_t, not int.
4148 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4149
461c2ab9
JB
41502011-03-28 Juanma Barranquero <lekktu@gmail.com>
4151
4152 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4153 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4154 All callers changed.
4155
4156 * lisp.h (multibyte_char_to_unibyte):
4157 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4158 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4159 * character.h (CHAR_TO_BYTE8):
4160 * cmds.c (internal_self_insert):
4161 * editfns.c (general_insert_function):
4162 * keymap.c (push_key_description):
4163 * search.c (Freplace_match):
4164 * xdisp.c (message_dolog, set_message_1): All callers changed.
4165
f6d62986
SM
41662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4167
4168 * keyboard.c (safe_run_hook_funcall): New function.
4169 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4170 don't set the hook to nil, but remove the offending function instead.
4171 (Qcommand_hook_internal): Remove, unused.
4172 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4173 Vcommand_hook_internal.
4174
4175 * eval.c (enum run_hooks_condition): Remove.
4176 (funcall_nil, funcall_not): New functions.
4177 (run_hook_with_args): Call each function through a `funcall' argument.
4178 Remove `cond' argument, now redundant.
4179 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4180 (Frun_hook_with_args_until_failure): Adjust accordingly.
4181 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4182
1db5b1ad
JB
41832011-03-28 Juanma Barranquero <lekktu@gmail.com>
4184
4185 * dispextern.h (string_buffer_position): Remove declaration.
4186
4187 * print.c (strout): Remove parameter `multibyte', unused since
4188 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4189
4190 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4191 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4192 All callers changed.
4193
4194 * w32.c (_wsa_errlist): Use braces for struct initializers.
4195
4196 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4197 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4198 All callers changed.
4199 (string_buffer_position): Likewise. Also, make static (it's never
4200 used outside xdisp.c).
4201 (cursor_row_p): Remove parameter `w', unused since
4202 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4203 (decode_mode_spec): Remove parameter `precision', introduced during
4204 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4205 All callers changed.
4206
5ffb62aa
JD
42072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4208
4209 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4210
461c2ab9 42112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4212
4213 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4214 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4215 (ns_update_auto_hide_menu_bar): New functions.
4216 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4217 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4218 ns_constrain_all_frames.
4219 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4220 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4221
5c380ffb
JD
42222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4223
4224 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4225
9af30bdf
GM
42262011-03-27 Glenn Morris <rgm@gnu.org>
4227
4228 * syssignal.h: Replace RETSIGTYPE with void.
4229 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4230 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4231 Replace SIGTYPE with void everywhere.
4232 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4233 * s/template.h (SIGTYPE): Remove commented out definition.
4234
e2abce01
JB
42352011-03-26 Eli Zaretskii <eliz@gnu.org>
4236
4237 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4238 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4239
f868cd8a
JB
42402011-03-26 Juanma Barranquero <lekktu@gmail.com>
4241
59eb0929
JB
4242 * w32.c (read_unc_volume): Use parameter `henum', instead of
4243 global variable `wget_enum_handle'.
4244
4245 * keymap.c (describe_vector): Remove parameters `indices' and
4246 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4247 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4248
f868cd8a
JB
4249 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4250
4251 * keyboard.c (timer_check): Remove parameter `do_it_now',
4252 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4253 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4254 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4255
4256 * keyboard.c (read_char):
4257 * w32menu.c (w32_menu_display_help):
4258 * xmenu.c (show_help_event, menu_help_callback):
4259 Adjust calls to `show_help_echo'.
4260
4261 * gtkutil.c (xg_maybe_add_timer):
4262 * keyboard.c (readable_events):
4263 * process.c (wait_reading_process_output):
4264 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4265
4266 * insdel.c (adjust_markers_gap_motion):
4267 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4268 (gap_left, gap_right): Don't call it.
4269
2ecf6fdb
CY
42702011-03-25 Chong Yidong <cyd@stupidchicken.com>
4271
4272 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4273 incurred during fontification.
4274
6b1f9ba4
JB
42752011-03-25 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4278 (DEFVAR_PER_BUFFER): Don't pass it.
4279
4280 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4281 (scrolling_window): Don't pass it.
4282
0f4a96b5
JB
42832011-03-25 Juanma Barranquero <lekktu@gmail.com>
4284
4285 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4286
4287 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4288 and `suffix'.
4289 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4290 of variables specific to SELinux and computation of `encoded_absname'.
4291
4292 * image.c (XPutPixel): Remove unused variable `height'.
4293
4294 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4295
4296 * unexw32.c (get_section_info): Remove unused variable `section'.
4297
4298 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4299 (system_process_attributes): Remove unused variable `sess'.
4300 (sys_read): Remove unused variable `err'.
4301
4302 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4303 (w32_wnd_proc): Remove unused variable `isdead'.
4304 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4305 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4306 (x_create_tip_frame): Remove unused variable `tem'.
4307
4308 * w32inevt.c (w32_console_read_socket):
4309 Remove unused variable `no_events'.
4310
4311 * w32term.c (x_draw_composite_glyph_string_foreground):
4312 Remove unused variable `width'.
4313
1149507c
JB
43142011-03-24 Juanma Barranquero <lekktu@gmail.com>
4315
4316 * w32term.c (x_set_glyph_string_clipping):
4317 Don't pass uninitialized region to CombineRgn.
4318
9c88f339
JB
43192011-03-23 Juanma Barranquero <lekktu@gmail.com>
4320
4321 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4322 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4323 (Fx_close_connection): Remove unused variable `i'.
4324
4325 * w32font.c (w32font_draw): Return number of glyphs.
4326 (w32font_open_internal): Remove unused variable `i'.
4327 (w32font_driver): Add missing initializer.
4328
4329 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4330 (fill_in_menu): Remove unused variable `items_added'.
4331
4332 * w32term.c (last_mouse_press_frame): Remove static global variable.
4333 (w32_clip_to_row): Remove unused variable `f'.
4334 (x_delete_terminal): Remove unused variable `i'.
4335
4336 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4337 (NOTHING): Remove unused static global variable.
4338 (uniscribe_check_otf): Remove unused variable `table'.
4339 (uniscribe_font_driver): Add missing initializers.
4340
dee091a3
JD
43412011-03-23 Julien Danjou <julien@danjou.info>
4342
4343 * term.c (Fsuspend_tty, Fresume_tty):
4344 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4345 * window.c (temp_output_buffer_show):
4346 * insdel.c (signal_before_change):
4347 * frame.c (Fhandle_switch_frame):
4348 * fileio.c (Fdo_auto_save):
4349 * emacs.c (Fkill_emacs):
4350 * editfns.c (save_excursion_restore):
4351 * cmds.c (internal_self_insert):
4352 * callint.c (Fcall_interactively):
4353 * buffer.c (Fkill_all_local_variables):
4354 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4355 Use Frun_hooks.
0f4a96b5 4356 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4357 unconditionnaly since it does the check itself.
4358
2c520ab5 43592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4360
c9c49752
PE
4361 Fix more problems found by GCC 4.5.2's static checks.
4362
8abc3f12
PE
4363 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4364 the first time through the loop, since we know p0 < p1 then.
4365 This also avoids a gcc -Wstrict-overflow warning.
4366
a2d26660
PE
4367 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4368 leading to a memory leak, possible in functions like
4369 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4370 of objects (Bug#8318).
a2d26660 4371
916c72e9
PE
4372 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4373 that could (at least in theory) be that large.
4374
19ab8a18
PE
4375 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4376 This is less likely to overflow, and avoids undefined behavior if
4377 overflow does occur. All callers changed. Use strtoul to scan
4378 for the unsigned long integer.
b7cbbd6f
PE
4379 (pint2hrstr): Simplify and tune code slightly.
4380 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4381
f0641eff
PE
4382 * scroll.c (do_scrolling): Work around GCC bug 48228.
4383 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4384
7f650bb9
PE
4385 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4386 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4387 (validate_x_resource_name): Simplify count usage.
4388 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4389
37dd57d1
PE
4390 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4391 fail (Bug#8306).
81e56e61 4392
699979fc 4393 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4394
401bf9b4
PE
4395 * process.c (Fmake_network_process): Use socklen_t, not int,
4396 where POSIX says socklen_t is required in portable programs.
4397 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4398 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4399 (Fmake_network_process, server_accept_connection):
4400 (wait_reading_process_output, read_process_output):
4401 Likewise.
4402
b93aacde
PE
4403 * process.c: Rename or move locals to avoid shadowing.
4404 (list_processes_1, Fmake_network_process):
4405 (read_process_output_error_handler, exec_sentinel_error_handler):
4406 Rename or move locals.
4dc343ee 4407 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4408 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4409 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4410 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4411 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4412
af8a867c 4413 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4414 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4415 Include tparam.h instead, since it declares them.
af8a867c
PE
4416 * cm.h (PC): Remove extern decl; tparam.h now does this.
4417 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4418 * terminfo.c: Include tparam.h, to check interfaces.
4419 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4420 (tparam): Adjust signature to match interface in tparam.h;
4421 this removes some undefined behavior. Check that outstring and len
4422 are zero, which they always are with Emacs.
4423 * tparam.h (PC, BC, UP): New extern decls.
4424
0248044d 4425 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4426 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4427
8ff096c1 4428 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4429 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4430 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4431 (ftfont_list): Remove unused local.
49eaafba
PE
4432 (get_adstyle_property, ftfont_pattern_entity):
4433 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4434 Rename locals to avoid shadowing.
8ff096c1 4435
e2be39f6
PE
4436 * xfont.c (xfont_list_family): Mark var as initialized.
4437
c9735e30
PE
4438 * xml.c (make_dom): Now static.
4439
8f5201ae
PE
4440 * composite.c (composition_compute_stop_pos): Rename local to
4441 avoid shadowing.
b246f932
PE
4442 (composition_reseat_it): Remove unused locals.
4443 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4444 (composition_update_it): Mark var as initialized.
11b61122
PE
4445 (find_automatic_composition): Mark vars as initialized,
4446 with a FIXME (Bug#8290).
8f5201ae 4447
760fbc2c
PE
4448 character.h: Rename locals to avoid shadowing.
4449 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4450 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4451 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4452 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4453 to avoid shadowing.
4454
ff08eb85
PE
4455 * textprop.c (property_change_between_p): Remove; unused.
4456
fc7bf025
PE
4457 * intervals.c (interval_start_pos): Now static.
4458
235d7abc
PE
4459 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4460
44f230aa
SM
4461 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4462 Rename locals to avoid shadowing.
3e7d6594 4463
50060332
PE
4464 * sound.c (wav_play, au_play, Fplay_sound_internal):
4465 Fix pointer signedness.
d01f234b 4466 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4467 (wav_play): Initialize a variable to 0, to prevent undefined
4468 behavior (Bug#8278).
50060332 4469
c4fc4e30
PE
4470 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4471
918436ed
PE
4472 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4473
c939f91b
PE
4474 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4475 clobbering (Bug#8298).
b9c7f648
PE
4476 * sysdep.c (sys_subshell): Likewise.
4477 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4478
6bd8c144
PE
4479 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4480 This should get cleaned up, so that child_setup has the
4481 same signature on all platforms.
4482
7710357c 4483 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4484 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4485
c59da222
CY
44862011-03-22 Chong Yidong <cyd@stupidchicken.com>
4487
4488 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4489 not to be necessary, and produces flickering.
4490
66b87493
GM
44912011-03-20 Glenn Morris <rgm@gnu.org>
4492
4493 * config.in: Remove file.
4494
45b6f6d5
JB
44952011-03-20 Juanma Barranquero <lekktu@gmail.com>
4496
4497 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4498 are now in src/globals.h.
4499 (syms_of_minibuf): Remove spurious & from previous change.
4500
3ec03f7e
LL
45012011-03-20 Leo <sdl.web@gmail.com>
4502
4503 * minibuf.c (completing-read-function): New variable.
4504 (completing-read-default): Rename from completing-read.
4505 (completing-read): Call completing-read-function.
4506
b14e3e21
CY
45072011-03-19 Juanma Barranquero <lekktu@gmail.com>
4508
4509 * xfaces.c (Fx_load_color_file):
4510 Read color file from absolute filename (bug#8250).
4511
f2b726e6
JB
45122011-03-19 Juanma Barranquero <lekktu@gmail.com>
4513
4514 * makefile.w32-in: Update dependencies.
4515
09f6ff02
EZ
45162011-03-17 Eli Zaretskii <eliz@gnu.org>
4517
4518 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4519
29a6015a
PE
45202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4521
a3a6c54e
PE
4522 Fix more problems found by GCC 4.5.2's static checks.
4523
b766f867
PE
4524 * process.c (make_serial_process_unwind, send_process_trap):
4525 (sigchld_handler): Now static.
4526
be02381c
PE
4527 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4528 That way, the code declares only the vars that it needs.
4529 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4530 * s/cygwin.h (PTY_ITERATION): Likewise.
4531 * s/darwin.h (PTY_ITERATION): Likewise.
4532 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4533
57048744
PE
4534 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4535 * process.c (allocate_pty): Don't declare stb unless it's needed.
4536
7914961c 4537 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4538 (CONSTANTLIM): Remove; unused.
4539 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4540 Define only if needed.
7914961c 4541
b3967b18
PE
4542 * unexelf.c (unexec): Name an expression,
4543 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4544 Use a different way to cause a compilation error if anyone uses
4545 n rather than nn, a way that does not involve shadowing.
73366a00 4546 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4547
29a6015a
PE
4548 * deps.mk (unexalpha.o): Remove; unused.
4549
43cfc33e 4550 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4551 * unexec.h: New file.
ce701a33
PE
4552 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4553 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4554 Depend on unexec.h.
4555 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4556 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4557 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4558 Change as necessary to match prototype in unexec.h.
ce701a33 4559
01f44d5a
PE
4560 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4561 shadowing.
4f63c6bb 4562 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4563
a6670b0b
PE
4564 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4565 Rename locals to avoid shadowing.
4566
cef2010d 4567 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4568 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4569
d4d7173a
PE
4570 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4571
f08b802a
PE
4572 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4573 warning when compiling print.c.
4574
3ddb0639
PE
4575 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4576 instead of using an uninitialized var.
5ad03b97 4577 (font_sort_entities): Mark var as initialized.
3ddb0639 4578
170a2692
PE
4579 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4580
e663c700
PE
4581 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4582 pointers to constants.
89bc529a 4583 (font_parse_fcname): Remove unused vars.
7b81e2d0 4584 (font_delete_unmatched): Now static.
ea838e10 4585 (font_get_spec): Remove; unused.
13a547c6
PE
4586 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4587 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4588 Rename or move locals to avoid shadowing.
e663c700 4589
2a80c887 4590 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4591 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4592
1384fa33 4593 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4594 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4595
8b2c52e9
PE
4596 * alloc.c (mark_backtrace): Move decl from here ...
4597 * lisp.h: ... to here, so that it can be checked.
4598
475545b5 4599 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4600 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4601 (lisp_indirect_variable): Name an expression,
4602 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4603 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4604
b1349114 4605 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4606 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4607 Use const pointer when appropriate.
b1349114 4608
a2928364
PE
4609 * lisp.h (get_system_name, get_operating_system_release):
4610 Move decls here, to check interfaces.
4611 * process.c (get_operating_system_release): Move decl to lisp.h.
4612 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4613 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4614 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4615 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4616 (Fformat_time_string, Fencode_time, Finsert_char):
4617 (Ftranslate_region_internal, Fformat):
4618 Rename or remove local vars to avoid shadowing.
9710023e 4619 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4620
a415e694
PE
4621 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4622 avoid shadowing.
4623
8ef4622d
PE
4624 * lisp.h (eassert): Check that the argument compiles, even if
4625 ENABLE_CHECKING is not defined.
4626
946f9a5b
PE
4627 * data.c (Findirect_variable): Name an expression, to avoid
4628 gcc -Wbad-function-cast warning.
112396d6 4629 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4630 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4631 (Fmake_variable_buffer_local, Fmake_local_variable):
4632 Mark variables as initialized.
52746918 4633 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4634
e5aab7e7 4635 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4636 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4637 Rename locals to avoid shadowing.
dff45157
PE
4638 (mark_stack): Move local variables into the #ifdef region where
4639 they're used.
7bc26fdb
PE
4640 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4641 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4642 needed otherwise.
4643 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4644 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4645 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4646
e5aab7e7
PE
4647 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4648 avoids undefined behavior in theory.
4649
4da60324
PE
4650 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4651
88043301
PE
4652 Use functions, not macros, for up- and down-casing (Bug#8254).
4653 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4654 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4655 to use the following functions instead of these macros.
4656 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4657 EMACS_INT, since callers assume the returned value fits in int.
4658 (upcase1): Likewise, for UPCASE_TABLE.
4659 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4660 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4661 the race-condition problem in the old DOWNCASE.
88043301 4662
19ed5445
PE
4663 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4664 Rename locals to avoid shadowing.
4665 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4666 (regex_compile, re_search_2, re_match_2_internal):
4667 Remove unused local vars.
952db0d7
PE
4668 (FREE_VAR): Rewrite so as not to use empty "else",
4669 which gcc can warn about.
da053e48 4670 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4671 (RETALLOC_IF): Define only if needed.
4672 (WORDCHAR_P): Likewise. This one is never needed, but is used
4673 only in a comment talking about a compiler bug, so put inside
4674 the #if 0 of that comment.
4675 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4676 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4677 Remove; unused.
19ed5445 4678
1f3561e4 4679 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4680 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4681 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4682
ded6f8f7
PE
4683 * search.c (simple_search): Remove unused var.
4684
dbd37a95
PE
4685 * dired.c (compile_pattern): Move decl from here ...
4686 * lisp.h: ... to here, so that it can be checked.
4687 (struct re_registers): New forward decl.
4688
7e47afad
PE
4689 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4690
85f24f61
PE
4691 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4692 All uses changed.
4693 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4694 Rename locals to avoid shadowing.
5671df8f 4695 (Fvertical_motion): Mark locals as initialized.
85f24f61 4696
181aa2be 4697 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4698 (casify_region): Mark local as initialized.
181aa2be 4699
930d429c
PE
4700 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4701
7082eac6
PE
4702 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4703 New macros, so that the caller can use some names other than
4704 gcpro1, gcpro2, etc.
4705 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4706 of the new macros.
4707 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4708 argument, for consistency with GCPRO2_VAR, etc: it is now the
4709 prefix of the variable, not the variable itself. All uses
4710 changed.
38b2c076
PE
4711 * dired.c (directory_files_internal, file_name_completion):
4712 Rename locals to avoid shadowing.
4713
15206ed9
PE
4714 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4715 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4716 dired.c's scmp function, had undefined behavior.
4717 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4718 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4719 * buffer.h: ... to here, because these macros use current_buffer,
4720 and the new implementation with inline functions needs to have
4721 current_buffer in scope now, rather than later when the macros
4722 are used.
4723 (downcase, upcase1): New static inline functions.
4724 (DOWNCASE, UPCASE1): Reimplement using these functions.
4725 This avoids undefined behavior in expressions like
4726 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4727 from race conditions in accessing the global variables
4728 case_temp1 and case_temp2.
4729 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4730 * lisp.h (case_temp1, case_temp2): Remove their decls.
4731 * character.h (ASCII_CHAR_P): Move from here ...
4732 * lisp.h: ... to here, so that the inline functions mentioned
4733 above can use them.
4734
4a6bea26
PE
4735 * dired.c (directory_files_internal_unwind): Now static.
4736
f14b7e14
PE
4737 * fileio.c (file_name_as_directory, directory_file_name):
4738 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4739 Now static.
2893f146
PE
4740 (file_name_as_directory): Use const pointers when appropriate.
4741 (Fexpand_file_name): Likewise. In particular, newdir might
4742 point at constant storage, so make it a const pointer.
fd4ead52 4743 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4744 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4745 signedness issues.
f839df0c
PE
4746 (Fset_file_times, Finsert_file_contents, auto_save_error):
4747 Rename locals to avoid shadowing.
f14b7e14 4748
5716756e 4749 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4750 (Ftry_completion, Fall_completions): Rename or remove locals
4751 to avoid shadowing.
5716756e 4752
b4c3046a
PE
4753 * marker.c (bytepos_to_charpos): Remove; unused.
4754
b45db522
PE
4755 * lisp.h (verify_bytepos, count_markers): New decls,
4756 so that gcc does not warn that these functions aren't declared.
4757
85876d07
PE
4758 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4759 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4760 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4761 (copy_text): Remove unused local var.
85876d07 4762
03d78a21 4763 * filelock.c (within_one_second): Now static.
b3dd38ab 4764 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4765
5df8f01b
PE
4766 * buffer.c (fix_overlays_before): Mark locals as initialized.
4767 (fix_start_end_in_overlays): Likewise. This function should be
4768 simplified by using pointers-to-pointers, but that's a different
4769 matter.
b1d876f1 4770 (switch_to_buffer_1): Now static.
8f54f30a
PE
4771 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4772 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4773
a70072c9 4774 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4775 Fix pointer signedness issue.
edced198
PE
4776 (sys_subshell): Mark local as volatile if checking for lint,
4777 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4778 (MAXPATHLEN): Define only if needed.
a70072c9 4779
a0977c44
PE
4780 * process.c (serial_open, serial_configure): Move decls from here ...
4781 * systty.h: ... to here, so that they can be checked.
4782
a884fdcc
PE
4783 * fns.c (get_random, seed_random): Move extern decls from here ...
4784 * lisp.h: ... to here, so that they can be checked.
4785
604efe86 4786 * sysdep.c (reset_io): Now static.
b8950c94 4787 (wait_for_termination_signal): Remove; unused.
604efe86 4788
38fc62d9
PE
4789 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4790 (copy_keymap_item, append_key, push_text_char_description):
4791 Now static.
1004a21a 4792 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4793 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4794 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4795 (describe_map_tree):
4796 Rename locals to avoid shadowing.
38fc62d9 4797
2f2650da
PE
4798 * keyboard.c: Declare functions static if they are not used elsewhere.
4799 (echo_char, echo_dash, cmd_error, top_level_2):
4800 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4801 (read_char, kbd_buffer_get_event, make_lispy_position):
4802 (make_lispy_event, make_lispy_movement, apply_modifiers):
4803 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4804 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4805 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4806 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4807 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4808
a053e86c 4809 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4810 (mark_kboards): Move decl here ...
4811 * alloc.c (mark_kboards): ... from here.
a053e86c 4812
4752793e
PE
4813 * lisp.h (force_auto_save_soon): New decl.
4814
74f10ca7 4815 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4816 (DEFINE_DUMMY_FUNCTION): New macro.
4817 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4818 Use it.
c03cd23f
PE
4819 (main): Add casts to avoid warnings
4820 if GCC considers string literals to be constants.
74f10ca7 4821
022e70d4
PE
4822 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4823
59d6fe83
PE
4824 * dbusbind.c: Pointer signedness fixes.
4825 (xd_signature, xd_append_arg, xd_initialize):
4826 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4827 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4828 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4829 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4830
78320123
PE
4831 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4832 if GCC considers string literals to be constants.
49cebcca 4833 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4834
35ac2a97
SM
48352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4836
fb103ca9
SM
4837 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4838 (print_preprocess, print_object): New macro to fix last change.
4839
35ac2a97
SM
4840 * print.c (print_preprocess): Don't forget font objects.
4841
62973b41
JB
48422011-03-16 Juanma Barranquero <lekktu@gmail.com>
4843
4844 * emacs.c (USAGE3): Doc fixes.
4845
0e48bb22
AS
48462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4847
4848 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4849 structure.
4850
7684e57b
JB
48512011-03-14 Juanma Barranquero <lekktu@gmail.com>
4852
4853 * lisp.h (VWindow_system, Qfile_name_history):
4854 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4855 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4856 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4857
4858 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4859 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4860
4861 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4862 * w32console.c (detect_input_pending, read_input_pending)
4863 (encode_terminal_code):
4864 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4865 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4866 (w32_system_caret_y, Qfile_name_history):
4867 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4868 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4869 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4870 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4871 * w32proc.c (Qlocal, report_file_error):
4872 * w32term.c (Vwindow_system, updating_frame):
4873 * w32uniscribe.c (initialized, uniscribe_font_driver):
4874 Remove unneeded extern declarations.
4875
2aa46d6c
CY
48762011-03-14 Chong Yidong <cyd@stupidchicken.com>
4877
c96bbc66 4878 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4879
cffc6f3b
CY
48802011-03-13 Chong Yidong <cyd@stupidchicken.com>
4881
4882 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4883 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4884 These macros can no longer be used for assignment.
4885
44f230aa
SM
4886 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4887 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4888 (record_buffer_markers, fetch_buffer_markers): New functions for
4889 recording and fetching special buffer markers.
4890 (set_buffer_internal_1, set_buffer_temp): Use them.
4891
4892 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4893
4894 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4895
4896 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4897 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4898
4899 * xdisp.c (hscroll_window_tree):
4900 (reconsider_clip_changes): Use PT instead of BUF_PT.
4901
d251f04b
EZ
49022011-03-13 Eli Zaretskii <eliz@gnu.org>
4903
4904 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4905 $(EMACS_ROOT)/lib/intprops.h.
4906
f0c77cd1
PE
49072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4908
3eca4629
PE
4909 Fix more problems found by GCC 4.5.2's static checks.
4910
7c86ee98
PE
4911 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4912 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4913 (xg_free_frame_widgets): Make it clear that a local variable is
4914 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4915 (gdk_window_get_screen): Make it clear that this macro is needed
4916 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4917 (int_gtk_range_get_value): New function, which avoids a diagnostic
4918 from gcc -Wbad-function-cast.
4919 (xg_set_toolkit_scroll_bar_thumb): Use it.
4920 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4921 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4922 (get_utf8_string, xg_get_file_with_chooser):
4923 Rename locals to avoid shadowing.
4924 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4925
41729b81
PE
4926 * xgselect.c (xg_select): Remove unused var.
4927
f0c77cd1
PE
4928 * image.c (four_corners_best): Mark locals as initialized.
4929 (gif_load): Initialize transparent_p to zero (Bug#8238).
4930 Mark another local as initialized.
ec6cf4c6 4931 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4932
ce0ad53d 4933 * image.c (clear_image_cache): Now static.
d5d5a617 4934 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4935 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4936 (x_edge_detection): Remove unnecessary cast that
4937 gcc -Wbad-function-cast diagnoses.
2037898d 4938 (gif_load): Fix pointer signedness.
6ae141d6
PE
4939 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4940 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4941
33383987 49422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4943
d32df629
PE
4944 Improve quality of tests for time stamp overflow.
4945 For example, without this patch (encode-time 0 0 0 1 1
4946 1152921504606846976) returns the obviously-bogus value (-948597
4947 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4948 reports time overflow. See
4949 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4950 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4951 * editfns.c: Include limits.h and intprops.h.
4952 (TIME_T_MIN, TIME_T_MAX): New macros.
4953 (time_overflow): Move earlier, to before first use.
4954 (hi_time, lo_time): New functions, for an accurate test for
4955 out-of-range times.
4956 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4957 (Fget_internal_run_time): Don't assume time_t fits in int.
4958 (make_time): Use list2 instead of Fcons twice.
4959 (Fdecode_time): More accurate test for out-of-range times.
4960 (check_tm_member): New function.
4961 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4962 (lisp_time_argument): Don't rely on undefined left-shift and
4963 right-shift behavior when checking for time stamp overflow.
8be6f318 4964
fe31d94c
PE
4965 * editfns.c (time_overflow): New function, refactoring common code.
4966 (Fformat_time_string, Fdecode_time, Fencode_time):
4967 (Fcurrent_time_string): Use it.
4968
8be6f318
PE
4969 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4970 * dired.c (make_time): Move to ...
4971 * editfns.c (make_time): ... here.
4972 * systime.h: Note the move.
4973
09d9db2c 49742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4975
126bc0dc
YM
4976 * fringe.c (update_window_fringes): Remove unused variables.
4977
c47cbdfd
YM
4978 * unexmacosx.c (copy_data_segment): Also copy __got section.
4979 (Bug#8223)
4980
7ac80be9
EZ
49812011-03-12 Eli Zaretskii <eliz@gnu.org>
4982
c96bbc66 4983 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4984 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4985 Constify `char *' arguments and their references according to
4986 prototypes in tparam.h.
4987
ecb0f94d 4988 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4989
7ac80be9
EZ
4990 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4991 Adapt all references accordingly.
4992
4993 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4994
ef1fd07e
TT
49952011-03-11 Tom Tromey <tromey@redhat.com>
4996
4997 * buffer.c (syms_of_buffer): Remove obsolete comment.
4998
7ef4b50c
EZ
49992011-03-11 Eli Zaretskii <eliz@gnu.org>
5000
5001 * termhooks.h (encode_terminal_code): Declare prototype.
5002
5003 * msdos.c (encode_terminal_code): Don't declare prototype.
5004
5005 * term.c (encode_terminal_code): Now external again, used by
5006 w32console.c and msdos.c.
5007
44f230aa
SM
5008 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5009 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5010
4b1ec863 50112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5012
1714f52b 5013 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5014
4b1ec863
PE
5015 * fringe.c (update_window_fringes): Mark locals as initialized
5016 (Bug#8227).
5017 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5018
524c7aa6
PE
5019 * alloc.c (mark_fringe_data): Move decl from here ...
5020 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5021 to check its interface.
5022 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5023
a5c0af81 5024 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5025 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5026 (fontset_font): Mark local as initialized.
a9a06e0b 5027 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5028
b4716021
PE
5029 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5030
811e9bac 5031 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5032 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5033 (x_own_selection, Fx_disown_selection_internal): Rename locals
5034 to avoid shadowing.
5035 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5036
7e3ab302
PE
5037 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5038 so that the caller can use some name other than gcpro1.
5039 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5040 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5041 (Fx_backspace_delete_keys_p):
5042 Use them to avoid shadowing, and rename vars to avoid shadowing.
5043 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5044 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5045 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5046 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5047 Remove unused locals.
7e3ab302
PE
5048 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5049 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5050 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5051 macros.
f78faa98 5052
e2b13473
PE
5053 * xterm.h (x_mouse_leave): New decl.
5054
77f23912
PE
5055 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5056 Remove unused functions.
cdf4ba58
PE
5057 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5058 (x_calc_absolute_position): Now static.
7411c686 5059 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5060 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5061 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5062 unless they are used.
38d0b34a
PE
5063 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5064 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5065 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5066 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5067 (x_error_catcher, x_connection_closed, x_error_handler):
5068 (x_error_quitter, xembed_send_message, x_iconify_frame):
5069 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5070 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5071 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5072
44f230aa
SM
5073 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5074 Rename or move locals to avoid shadowing.
6b463e58 5075 (tty_defined_color, merge_face_heights): Now static.
5967d051 5076 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5077 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5078 does not deduce is never used uninitialized.
73719eba
PE
5079 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5080 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5081
426994c3 5082 * terminal.c (store_terminal_param): Now static.
5489860b 5083
032f1620 5084 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5085 (set_frame_menubar): Remove unused local.
d4323972 5086 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5087 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5088 since they might point to immutable storage.
281585b0
PE
5089 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5090 since it's unused otherwise.
032f1620 5091
367c19e5 5092 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5093 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5094 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5095 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5096 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5097 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5098 does not deduce are never used uninitialized.
70739cbe 5099
07b48fa9
PE
5100 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5101
8868a238 5102 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5103 * window.c (window_loop, size_window):
5104 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5105
7e5cf297 5106 * window.c (display_buffer): Now static.
d6550a9f
PE
5107 (size_window): Mark variables that gcc -Wuninitialized
5108 does not deduce are never used uninitialized.
a586633d
PE
5109 * window.h (check_all_windows): New decl, to forestall
5110 gcc -Wmissing-prototypes diagnostic.
5b555da1 5111 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5112
f6095868
PE
5113 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5114 shadowing.
5115 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5116 Include <limits.h>.
5117 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5118 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5119 (load_charset_map): Mark variables that gcc -Wuninitialized
5120 does not deduce are never used uninitialized.
53df7c11 5121 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5122
f38b440c
PE
5123 * coding.c (coding_set_source, coding_set_destination):
5124 Use "else { /* comment */ }" rather than "else /* comment */;"
5125 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5126 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5127 a block, when the outer 'i' will do.
5128 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5129 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5130 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5131 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5132 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5133 Rename locals to avoid shadowing.
5134 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5135 * coding.c (emacs_mule_char, encode_invocation_designation):
5136 Now static, since they're not used elsewhere.
413bb2db 5137 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5138 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5139 (decode_coding_emacs_mule): Mark variables that gcc
5140 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5141 (detect_coding_iso_2022): Initialize a local variable that might
5142 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5143 this initialization is needed. (Bug#8211)
5f58e762
PE
5144 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5145 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5146 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5147 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5148 Remove unused macros.
f38b440c 5149
232b38b9 5150 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5151 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5152 * character.c (string_count_byte8): Likewise.
232b38b9 5153
fb90da1b
PE
5154 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5155 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5156
fb93dbc2
PE
5157 * chartab.c (copy_sub_char_table): Now static, since it's not used
5158 elsewhere.
5c156ace
PE
5159 (sub_char_table_ref_and_range, char_table_ref_and_range):
5160 Rename locals to avoid shadowing.
bbcd0949 5161 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5162
7d3b3862 5163 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5164 (BIDI_BOB): Remove unused macro.
7d3b3862 5165
6be7d3da
PE
5166 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5167 deduce are never used uninitialized.
c2ed9c8b 5168 * term.c (encode_terminal_code): Likewise.
6be7d3da 5169
75f8807f 5170 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5171
50938595
PE
5172 * tparam.h: New file.
5173 * term.c, tparam.h: Include it.
5174 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5175 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5176 Move these decls to tparam.h, and make them agree with what
5177 is actually in tparam.c. The previous trick of using incompatible
5178 decls in different modules does not conform to the C standard.
5179 All callers of tparam changed to use tparam's actual API.
5180 * tparam.c (tparam1, tparam, tgoto):
5181 Use const pointers where appropriate.
5182
fbceeba2
PE
5183 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5184 * cm.h (struct cm): Likewise.
5185 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5186 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5187 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5188 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5189 (turn_on_face, init_tty): Likewise.
5190 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5191
7f3f1250
PE
5192 * term.c (term_mouse_position): Rename local to avoid shadowing.
5193
e6ca6543
PE
5194 * alloc.c (mark_ttys): Move decl from here ...
5195 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5196
c40f8d15
AS
51972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5198
5199 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5200
cfe0661d
JB
52012011-03-09 Juanma Barranquero <lekktu@gmail.com>
5202
5203 * search.c (compile_pattern_1): Remove argument regp, unused since
5204 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5205 (compile_pattern): Don't pass it.
5206
0afb4571
J
52072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5208
5209 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5210 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5211 for ! HAVE_GTK3.
5212 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5213
5214 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5215
5216 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5217 gdk_window_get_screen, gdk_window_get_geometry,
5218 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5219 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5220 (xg_get_pixbuf_from_pixmap): New function.
5221 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5222 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5223 Call xg_get_pixbuf_from_pixmap instead of
5224 gdk_pixbuf_get_from_drawable.
5225 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5226 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5227 (xg_check_special_colors): Use GtkStyleContext and its functions
5228 for HAVE_GTK3.
5229 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5230 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5231 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5232 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5233 Call gtk_widget_get_preferred_size.
0afb4571
J
5234 (xg_frame_resized): gdk_window_get_geometry only takes 5
5235 parameters.
44f230aa
SM
5236 (xg_win_to_widget, xg_event_is_for_menubar):
5237 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5238 (xg_set_widget_bg): New function.
5239 (delete_cb): New function.
895009e1 5240 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5241 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5242 (xg_set_background_color): Call xg_set_widget_bg.
5243 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5244 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5245 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5246 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5247 if ! HAVE_GTK3.
5248 (update_frame_tool_bar): Call gtk_widget_hide.
5249 (xg_initialize): Use GDK_KEY_g.
5250
5251 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5252 if ! HAVE_GTK3
5253 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5254
5255 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5256 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5257 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5258
1c2cc4ef
JB
52592011-03-08 Juanma Barranquero <lekktu@gmail.com>
5260
5261 * w32xfns.c (select_palette): Check success of RealizePalette against
5262 GDI_ERROR, not zero.
5263
33383987 5264See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5265
5266;; Local Variables:
5267;; coding: utf-8
aac0c6e3
MR
5268;; End:
5269
33383987 5270 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5271
5272 This file is part of GNU Emacs.
5273
5274 GNU Emacs is free software: you can redistribute it and/or modify
5275 it under the terms of the GNU General Public License as published by
5276 the Free Software Foundation, either version 3 of the License, or
5277 (at your option) any later version.
5278
5279 GNU Emacs is distributed in the hope that it will be useful,
5280 but WITHOUT ANY WARRANTY; without even the implied warranty of
5281 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5282 GNU General Public License for more details.
5283
5284 You should have received a copy of the GNU General Public License
5285 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.