Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1dc4aa6d 12011-09-05 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2
f4af5137 3 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4 The previous code assumed that file offsets (off_t values) fit in
5 EMACS_INT variables, which is not true on typical 32-bit hosts.
6 The code messed up by falsely reporting buffer overflow in cases
7 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8 when "big" contains more than 2**29 bytes, even though this
9 inserts just one byte and does not overflow the buffer.
10 (Finsert_file_contents): Store file offsets as off_t
11 values, not as EMACS_INT values. Check for overflow when
12 converting between EMACS_INT and off_t. When checking for
13 buffer overflow or for overlap, take the offsets into account.
14 Don't use EMACS_INT for small values where int suffices.
15 When checking for overlap, fix a typo: ZV was used where
16 ZV_BYTE was intended.
17 (Fwrite_region): Don't assume off_t fits into 'long'.
18 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
19
ecfc0a49
MA
202011-09-05 Michael Albinus <michael.albinus@gmx.de>
21
22 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
23
6511acf2 242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 25
0999621a 26 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
27
28 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 29 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
30 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
31 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
32 (modify_event_symbol): Do not assume that the length of
33 name_alist_or_stem is safe to alloca and fits in int.
34 (Fexecute_extended_command): Likewise for function name and binding.
35 (Frecursion_depth): Wrap around reliably on integer overflow.
36 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
37 since some callers pass EMACS_INT values.
38 (Fsingle_key_description): Don't crash if symbol name contains more
39 than MAX_ALLOCA bytes.
40 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
41 (get_minibuffer): Arg is now EMACS_INT, not int.
42 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 43 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
44 * window.h (command_loop_level, minibuf_level): Reflect API changes.
45
2be7d702
PE
46 * dbusbind.c (signature_cat): New function.
47 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
48 Do not overrun buffer; instead, report string overflow.
49
9d1df220
PE
50 * dispnew.c (add_window_display_history): Don't overrun buffer.
51 Truncate instead; this is OK since it's just a log.
52
33ef5c64
PE
53 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
54 even if the time zone offset is outlandishly large.
55 Don't mishandle offset == INT_MIN.
56
66c6fdd5
PE
57 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
58 when creating daemon; the previous buffer-overflow check was incorrect.
59
d749b01b
PE
60 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
61 which has the guts of the old verror function.
62
b5cd1905
PE
63 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
64 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
65
6e1a67fb
PE
66 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
67 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 68 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 69 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
70 length of string rather than counting it via multiple sprintfs;
71 that's simpler and more reliable.
c21721cc
PE
72 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
73 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
74 sprintf, in case result does not fit in int.
75
c57b67fc
PE
76 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
77 (fontset_from_font): Print it.
78
8a401434
PE
79 * frame.c (tty_frame_count): Now printmax_t, not int.
80 (make_terminal_frame, set_term_frame_name): Print it.
81 (x_report_frame_params): In X, window IDs are unsigned long,
82 not signed long, so print them as unsigned.
83 (validate_x_resource_name): Check for implausibly long names,
84 and don't assume name length fits in 'int'.
85 (x_get_resource_string): Don't blindly alloca invocation name;
86 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
87 not fit in int.
88
6e1a67fb
PE
89 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
90 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
91 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
92
0df02bf3
PE
93 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
94 Use esprintf, not sprintf, in case result does not fit in int.
95
48e30793
PE
96 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
97 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
98 it as a large positive number.
99 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
100 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
101
a66ff6d8
PE
102 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
103 in case result does not fit in int.
104
aca216ff
PE
105 * print.c (float_to_string): Detect width overflow more reliably.
106 (print_object): Make sprintf buffer a bit bigger, to avoid potential
107 buffer overrun. Don't assume list length fits in 'int'. Treat
108 print length of 0 as 0, not as infinity; to be consistent with other
109 uses of print length in this function. Don't overflow print length
110 index. Don't assume hash table size fits in 'long', or that
111 vectorlike size fits in 'unsigned long'.
112
31c286f7
PE
113 * process.c (make_process): Use printmax_t, not int, to format
114 process-name gensyms.
115
55e5faa1
PE
116 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
117
80f2e268
PE
118 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
119 to avoid potential buffer overrun.
120
670741ab
PE
121 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
122 if X resource line is longer than 512 bytes.
123
b7163a50
PE
124 * xfns.c (x_window): Make sprintf buffer a bit bigger
125 to avoid potential buffer overrun.
126
ae58ff1f
PE
127 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
128
c43c8a6a
PE
129 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
130
3f8236f4
PE
1312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
132
53e9fe90 133 Integer overflow fixes for scrolling, etc.
6511acf2
PE
134 Without these, Emacs silently mishandles large integers sometimes.
135 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
136 it were "C-u 1 M-x recenter" on a typical 64-bit host.
137
6511acf2
PE
138 * xdisp.c (try_window_id): Check Emacs fixnum range before
139 converting to 'int'.
806add1d 140
6511acf2 141 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
142 Check that an Emacs fixnum is in range before assigning it to 'int'.
143 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
144 values converted from Emacs fixnums.
145 (Frecenter): Don't wrap around a line count if it is out of 'int'
146 range; instead, treat it as an extreme value.
147 (Fset_window_configuration, compare_window_configurations):
148 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
149
6511acf2
PE
150 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
151 that can exceed INT_MAX. Check that EMACS_INT value is in range
152 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
153 (match_limit): Don't assume that a fixnum can fit in 'int'.
154
6511acf2 155 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
156 exceed INT_MAX.
157
6511acf2 158 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
159 (Fvertical_motion): Don't wrap around LINES values that don't fit
160 in 'int'. Instead, treat them as extreme values. This is good
161 enough for windows, which can't have more than INT_MAX lines anyway.
162
fcb901a7
LMI
1632011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
164
0f2f6b6d
LMI
165 * Require libxml/parser.h to avoid compilation warning.
166
fcb901a7
LMI
167 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
168
169 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
170 since this reportedly can destroy thread storage.
171
6e20a0d4
CY
1722011-08-30 Chong Yidong <cyd@stupidchicken.com>
173
174 * syntax.c (find_defun_start): Update all cache variables if
175 exiting early (Bug#9401).
176
148ae00e
EZ
1772011-08-30 Eli Zaretskii <eliz@gnu.org>
178
f6cfbd8f
EZ
179 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
180
148ae00e
EZ
181 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
182 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
183 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
184
185 * term.c (tty_append_glyph): New function.
186 (produce_stretch_glyph): Static function and its prototype deleted.
187
188 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
189 prototypes.
190
c4a07a4c
PE
1912011-08-29 Paul Eggert <eggert@cs.ucla.edu>
192
193 * image.c (parse_image_spec): Check for nonnegative, not for positive,
194 when checking :margin (Bug#9390).
195 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
196 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
197 so that the name doesn't mislead. All uses changed.
198
6bc8cd65
JB
1992011-08-28 Johan Bockgård <bojohan@gnu.org>
200
201 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
202 set_tty_hooks.
203
dca4927e
EZ
2042011-08-27 Eli Zaretskii <eliz@gnu.org>
205
206 * xdisp.c (move_it_to): Don't bail out early when reaching
207 position beyond to_charpos, if we are scanning backwards.
208 (move_it_vertically_backward): When DY == 0, make sure we get to
209 the first character in the line after the newline.
210
f2cad773
PE
2112011-08-27 Paul Eggert <eggert@cs.ucla.edu>
212
213 * ccl.c: Improve and simplify overflow checking (Bug#9196).
214 (ccl_driver): Do not generate an out-of-range pointer.
215 (Fccl_execute_on_string): Remove unnecessary check for
216 integer overflow, noted by Stefan Monnier in
217 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
218 Remove a FIXME that didn't need fixing.
219 Simplify the newly-introduced buffer reallocation code.
220
0cae2cdb
JB
2212011-08-27 Juanma Barranquero <lekktu@gmail.com>
222
223 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
224
5fc295a4 2252011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 226
70c60eb2 227 Integer and memory overflow issues (Bug#9196).
726e0ab1 228
d31850da
PE
229 * doc.c (get_doc_string): Rework so that
230 get_doc_string_buffer_size is the actual buffer size, rather than
231 being 1 less than the actual buffer size; this makes xpalloc more
232 convenient.
233
a69fbedb
PE
234 * image.c (x_allocate_bitmap_record, cache_image):
235 * xselect.c (Fx_register_dnd_atom):
236 Simplify previous changes by using xpalloc.
237
fe5c5d37
PE
238 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
239 since either will do and ptrdiff_t is convenient with xpalloc.
240
0065d054
PE
241 * charset.c (charset_table_size)
242 (struct charset_sort_data.priority): Now ptrdiff_t.
243 (charset_compare): Don't overflow if priorities differ greatly.
244 (Fsort_charsets): Don't assume list length fits in int.
245 Check for size-calculation overflow when allocating sort data.
246 (syms_of_charset): Allocate an initial charset table that is
247 just under 64 KiB, to avoid problems with glibc malloc and mmap.
248
249 * cmds.c (internal_self_insert): Check for size-calculation overflow.
250
251 * composite.h (struct composition.glyph_len): Now int, not unsigned.
252 The actual value is always <= INT_MAX, and leaving it unsigned made
253 overflow checking harder.
254
255 * dispextern.h (struct glyph_matrix.rows_allocated)
256 (struct face_cache.size): Now ptrdiff_t, for convenience in use
257 with xpalloc. The values are still always <= INT_MAX.
258
259 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
260
261 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
262 (SAFE_NALLOCA): New macro.
263
264 * region-cache.c (struct boundary.pos, find_cache_boundary)
265 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
266 (set_cache_region, invalidate_region_cache)
267 (revalidate_region_cache, know_region_cache, region_cache_forward)
268 (region_cache_backward, pp_cache):
269 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
270 so that ptrdiff_t * can be passed to xpalloc.
271 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
272 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
273 (pp_cache): Don't assume cache_len fits in int.
274 * region-cache.h: Adjust extern decls to match.
275
276 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
277 EMACS_INT, since either will do, for xpalloc.
278
279 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
280 (xnmalloc, xnrealloc, xpalloc): New functions.
281
726e0ab1
PE
282 * bidi.c (bidi_shelve_header_size): New constant.
283 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
284 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
285
51f30bc5 286 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
287 * buffer.c (overlays_at, overlays_in, record_overlay_string)
288 (overlay_strings):
289 Don't update size of array until after memory allocation succeeds,
290 because xmalloc/xrealloc may not return.
0065d054
PE
291 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
292 now that we have proper integer overflow checking.
293 (record_overlay_string, overlay_strings): Catch overflows when
294 calculating size of overlay_str_buf.
726e0ab1 295
0065d054
PE
296 * callproc.c (Fcall_process): Check for size overflow when
297 calculating size of args2.
298 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
299 Normally we prefer signed values, but sticking with ptrdiff_t would
300 require adding more-complicated checks.
726e0ab1
PE
301
302 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
303 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
304 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 305 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
306
307 * character.c (Fstring): Check for size-calculation overflow.
308
309 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
310 unnecessary integer overflow. Check for size overflow.
311 (encode_coding_object): Don't update size until xmalloc succeeds.
312
313 * composite.c (get_composition_id): Check for overflow in glyph
314 length calculations.
315
316 Integer and memory overflow fixes for display code.
317 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
318 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
319 (scrolling_window): Check for overflow in size calculations.
320 (line_draw_cost, realloc_glyph_pool, add_row_entry):
321 Don't assume glyph table len fits in int.
322 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
323 (row_table_size): Now ptrdiff_t, not int.
324 (scrolling_window): Avoid overflow in size calculations.
325 Don't update size until allocation succeeds.
326 * fns.c (concat): Check for overflow in size calculations.
327 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
328 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
329 (NEXT_ALMOST_PRIME_LIMIT): New constant.
330
331 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
332 (get_doc_string): Check for size calculation overflow.
333 Don't update size until allocation succeeds.
334 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
335 EMACS_INT, where ptrdiff_t will do.
336 (Fsubstitute_command_keys): Check for string overflow.
337
338 * editfns.c (set_time_zone_rule): Don't assume environment length
339 fits in int.
340 (message_length): Now ptrdiff_t, not int.
341 (Fmessage_box): Don't update size until allocation succeeds.
342 Don't assume message length fits in int.
343 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
344
0065d054
PE
345 * emacs.c (main): Do not reallocate argv, since there is a null at
346 the end that can be overwritten, and this way there's no need to
347 worry about size-calculation overflow.
348 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
349
350 * eval.c (init_eval_once, grow_specpdl): Don't update size until
351 alloc succeeds.
352 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
353
354 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
355 (x_set_scroll_bar_width, x_figure_window_size):
356 Check for integer overflow.
357 (x_set_alpha): Do not assume XINT fits in int.
358
359 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
360 This is for the members text_lines, text_cols, total_lines, total_cols,
361 where the system imposes an 'int' limit.
362
363 * fringe.c (Fdefine_fringe_bitmap):
364 Don't update size until alloc works.
365
366 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
367 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
368
369 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
370 Check for size-calculation overflow.
371 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
372 do, as we prefer signed integers.
373 (id_to_widget.max_size, id_to_widget.used)
374 (xg_store_widget_in_map, xg_remove_widget_from_map)
375 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
376 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
377 Use and return ptrdiff_t, not int.
378 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
379 * gtkutil.h: Change prototypes to match the above.
380
381 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
382 are duplicate now that they've been promoted to lisp.h.
383 (x_allocate_bitmap_record, x_alloc_image_color)
384 (make_image_cache, cache_image, xpm_load):
385 Don't update size until alloc is done.
386 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
387 (x_detect_edges):
3256efce 388 Check for size calculation overflow.
726e0ab1
PE
389 (ct_colors_allocated_max): New constant.
390 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
391 overflow.
3256efce 392
726e0ab1
PE
393 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
394 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
395 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
396 Use ptrdiff_t, not int, to count maps.
397 (read_char_minibuf_menu_prompt): Check for overflow in size
398 calculations. Don't update size until allocation succeeds. Redo
399 calculations to avoid overflow.
400 * keyboard.h: Change prototypes to match the above.
401
402 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
403 to count maps.
404 (current_minor_maps): Check for size calculation overflow.
405 * keymap.h: Change prototypes to match the above.
406
407 * lread.c (read1, init_obarray): Don't update size until alloc done.
408
409 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
410 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
411
726e0ab1
PE
412 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
413 Now ptrdiff_t, not int.
414 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
415 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
416
417 * process.c (Fnetwork_interface_list): Check for overflow
418 in size calculation.
419
420 * region-cache.c (move_cache_gap): Check for size calculation overflow.
421
422 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
423 overflow. Don't bother calling xmalloc when xrealloc will do.
424
425 * search.c (Freplace_match): Check for size calculation overflow.
426 (Fset_match_data): Don't assume list lengths fit in 'int'.
427
428 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
429 for command line length. Do not attempt to address one before the
430 beginning of an array, as that's not portable.
431
432 * term.c (max_frame_lines): Remove; unused.
433 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
434 not int.
435 (encode_terminal_code, calculate_costs): Check for size
436 calculation overflow.
437 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
438 table lengths and related sizes. Don't update size until alloc
439 done. Redo calculations to avoid overflow.
440 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
441
442 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
443 subtracting pointers.
444 (gobble_line): Check for overflow more carefully. Don't update size
445 until alloc done.
446
447 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
448 Don't update size until alloc done.
449 Redo size calculations to avoid overflow.
450 Check for size calculation overflow.
0065d054 451 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
452
453 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
454 Use ptrdiff_t, not int, for sizes.
455 (store_mode_line_noprop_char): Don't update size until alloc done.
456
0065d054
PE
457 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
458 Use ptrdiff_t, not int, for sizes.
459 (Finternal_make_lisp_face, cache_face):
460 Check for size calculation overflow.
461 (cache_face): Treat size calculation overflows as if they were
462 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
463
464 * xfns.c (x_encode_text, x_set_name_internal)
465 (Fx_change_window_property): Use ptrdiff_t, not int, to count
466 sizes, since they can exceed INT_MAX in size. Check for size
467 calculation overflow.
468
0065d054
PE
469 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
470 (xg_select): Check for size calculation overflow.
726e0ab1
PE
471 Don't update size until alloc done.
472
0065d054 473 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 474 as sprintf is limited to int lengths.
1d526e2f 475
252c5ee1
PE
476 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
477 (X_LONG_MIN): New macros.
864d7ce7
PE
478 Use them to make the following changes clearer.
479 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
480 This change doesn't affect the value now, but it may help remind
481 future maintainers not to raise the value too much later.
482 (SELECTION_QUANTUM): Remove, replacing with ...
483 (selection_quantum): ... new function, which avoids overflow.
484 All uses changed.
485 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
486 assumption that selection length fits in 'int'.
487 (x_reply_selection_request, x_handle_selection_request)
488 (x_get_window_property, receive_incremental_selection)
489 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
490 (lisp_data_to_selection_data, clean_local_selection_data):
491 Use ptrdiff_t, not int, to record length of selection.
492 (x_reply_selection_request, x_get_window_property)
493 (receive_incremental_selection, x_property_data_to_lisp):
494 Redo calculations to avoid overflow.
495 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 496 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
497 something.
498 (x_get_window_property, receive_incremental_selection)
499 (lisp_data_to_selection_data, x_property_data_to_lisp):
500 Check for size-calculation overflow.
501 (x_get_window_property, receive_incremental_selection)
502 (lisp_data_to_selection_data, Fx_register_dnd_atom):
503 Don't store size until memory allocation succeeds.
504 (x_get_window_property): Plug memory leak on memory exhaustion.
505 Don't double-block input; malloc is safe here. Don't assume 2**34
506 - 4 fits in unsigned long. Add an xassert to check
507 XGetWindowProperty overflow. Be more careful about overflow
508 calculations, and distinguish size from memory overflow better.
509 (receive_incremental_selection): When tracing, don't assume
510 unsigned int is less than INT_MAX.
511 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
512 harmful) conversions of unsigned short to int.
513 (lisp_data_to_selection_data): Don't assume that integers
514 in the range -65535 through -1 fit in an X unsigned short.
515 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
516 result parameters unless successful. Rely on cons_to_unsigned
517 to report problems with elements; the old code wasn't right anyway.
518 (x_check_property_data): Check for int overflow; we cannot use
519 a wider type due to X limits.
520 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
521
726e0ab1 522 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 523
0065d054
PE
524 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
525 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
526 (x_color_cells): Don't store size until memory allocation succeeds.
527 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 528 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
529 (x_term_init): Don't assume length fits in int (sprintf is limited
530 to int size).
bc18e09d 531
ebfa62c0
PE
532 Use ptrdiff_t for composition IDs.
533 * character.c (lisp_string_width):
534 * composite.c (composition_table_size, n_compositions)
535 (get_composition_id, composition_gstring_from_id):
536 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
537 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
538 * window.c (Frecenter):
539 Use ptrdiff_t, not int, for composition IDs.
540 * composite.c (get_composition_id): Check for integer overflow.
541 * composite.h: Adjust prototypes to match the above changes.
542
d3411f89
PE
543 Use ptrdiff_t for hash table indexes.
544 * category.c (hash_get_category_set):
545 * ccl.c (ccl_driver):
546 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
547 * coding.c (coding_system_charset_list, detect_coding_system):
548 * coding.h (struct coding_system.id):
549 * composite.c (get_composition_id, gstring_lookup_cache):
550 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
551 * image.c (xpm_get_color_table_h):
552 * lisp.h (hash_lookup, hash_put):
553 * minibuf.c (Ftest_completion):
554 Use ptrdiff_t for hash table indexes, not int (which is too
555 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
556 32-bit --with-wide-int hosts).
557
e097a6fa
PE
558 * charset.c (Fdefine_charset_internal): Check for integer overflow.
559 Add a FIXME comment about memory leaks.
560 (syms_of_charset): Don't assume xmalloc returns.
561
5637687f
PE
562 Don't assume that stated character widths fit in int.
563 * character.c (Fchar_width, c_string_width, lisp_string_width):
564 * character.h (CHAR_WIDTH):
565 * indent.c (MULTIBYTE_BYTES_WIDTH):
566 Use sanitize_char_width to avoid undefined and/or bad behavior
567 with outlandish widths.
568 * character.h (sanitize_tab_width): Renamed from sanitize_width,
569 now that we have two such functions. All uses changed.
570 (sanitize_char_width): New inline function.
571
a2271ba2
PE
572 Don't assume that tab-width fits in int.
573 * character.h (sanitize_width): New inline function.
574 (SANE_TAB_WIDTH): New macro.
575 (ASCII_CHAR_WIDTH): Use it.
576 * indent.c (sane_tab_width): Remove. All uses replaced by
577 SANE_TAB_WIDTH (current_buffer).
578 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
579
18c52557
PE
580 * fileio.c: Integer overflow issues with file modes.
581 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
582
caeeedc1
PE
583 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
584 Remove unreachable code.
585 (read_hex, load_charset_map_from_file): Check for integer overflow.
586
50849c52
PE
587 * xterm.c: don't go over XClientMessageEvent limit
588 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
589 (x_send_scroll_bar_event): Likewise. Check that the size does not
590 exceed limits imposed by XClientMessageEvent, as well as the usual
591 ptrdiff_t and size_t limits.
592
b13995db
PE
593 * keyboard.c: Overflow, signedness and related fixes.
594 (make_lispy_movement): Use same integer type in forward decl
595 that is used in the definition.
596 (read_key_sequence, keyremap_step):
597 Change bufsize argument back to int, undoing my 2011-03-30 change.
598 We prefer signed types, and int is wide enough here.
599 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
600 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
601 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
602 length, not size_t. Use ptrdiff_t for index, not int.
603 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
604 possibility of integer overflow.
605
13464394
PE
606 Overflow, signedness and related fixes for images.
607
608 * dispextern.h (struct it.stack[0].u.image.image_id)
609 (struct_it.image_id, struct image.id, struct image_cache.size)
610 (struct image_cache.used, struct image_cache.ref_count):
611 * gtkutil.c (update_frame_tool_bar):
612 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
613 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
614 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
615 * nsmenu.m (update_frame_tool_bar):
616 * xdisp.c (calc_pixel_width_or_height):
617 * xfns.c (image_cache_refcount):
618 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
619 on typical 64-bit hosts.
620
621 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
622 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
623 Omit unnecessary casts to int.
624 (parse_image_spec): Check that integers fall into 'int' range
625 when the callers expect that.
626 (image_ascent): Redo ascent calculation to avoid int overflow.
627 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
628 (lookup_image): Remove unnecessary tests.
629 (xbm_image_p): Locals are now of int, not EMACS_INT,
630 since parse_image_check makes sure they fit into int.
631 (png_load, gif_load, svg_load_image):
632 Prefer int to unsigned where either will do.
633 (tiff_handler): New function, combining the cores of the
634 old tiff_error_handler and tiff_warning_handler. This
635 function is rewritten to use vsnprintf and thereby avoid
636 stack buffer overflows. It uses only the features of vsnprintf
637 that are common to both POSIX and native Microsoft.
638 (tiff_error_handler, tiff_warning_handler): Use it.
639 (tiff_load, gif_load, imagemagick_load_image):
640 Don't assume :index value fits in 'int'.
641 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
642 (imagemagick_load_image): Check that crop parameters fit into
643 the integer types that MagickCropImage accepts. Don't assume
644 Vimagemagick_render_type has a nonnegative value. Don't assume
645 size_t fits in 'long'.
646 (gs_load): Use printmax_t to print the widest integers possible.
647 Check for integer overflow when computing image height and width.
648
c11821d4
EZ
6492011-08-26 Eli Zaretskii <eliz@gnu.org>
650
651 * xdisp.c (redisplay_window): Don't force window start if point
652 will be invisible in the resulting window. (Bug#9324)
653
0c95fcf7
EZ
6542011-08-25 Eli Zaretskii <eliz@gnu.org>
655
656 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
657 the display spec is of the form `(space ...)'.
658 (handle_display_spec): Return the value returned by
659 handle_single_display_spec, not just 1 or zero.
660 (handle_single_display_spec): If the display spec is of the form
661 `(space ...)', and specifies display in the text area, return 2
662 rather than 1.
fee65a97 663 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
664 accurately, and prefer exact match for point under bidi. Don't
665 advance `row' beyond the last row of the window.
0c95fcf7
EZ
666
667 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
668 into disp_prop; all users changed.
669
670 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
671 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
672 for the text covered by the display property.
673
e4ed06f1
CY
6742011-08-25 Chong Yidong <cyd@stupidchicken.com>
675
676 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
677 Change return value to nil.
678 (Frecord_buffer): Delete unused function.
679
f67cdd7f
EZ
6802011-08-24 Eli Zaretskii <eliz@gnu.org>
681
5980d4c6
EZ
682 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
683 buffers, return left-to-right.
8610fe8b
EZ
684 (set_cursor_from_row): Consider candidate row a win if its glyph
685 represents a newline and point is on that newline. Fixes cursor
686 positioning on the newline at EOL of R2L text within L2R
687 paragraph, and vice versa.
688 (try_cursor_movement): Check continued rows, in addition to
689 continuation rows. Fixes unwarranted scroll when point enters a
690 continued line of R2L text within an L2R paragraph, or vice versa.
691 (cursor_row_p): Consider the case of point being equal to
692 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
693 from the end of a short line to the beginning of a continued line
694 of R2L text within L2R paragraph.
695 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
696 composed characters.
5980d4c6 697
f67cdd7f
EZ
698 * bidi.c (bidi_check_type): Use xassert.
699 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
700 members.
701
bca633fb
EZ
7022011-08-23 Eli Zaretskii <eliz@gnu.org>
703
704 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
705 a character.
706
4a5885a7
CY
7072011-08-23 Chong Yidong <cyd@stupidchicken.com>
708
709 * nsfont.m (ns_otf_to_script): Fix typo.
710
0902a04e
KH
7112011-08-22 Kenichi Handa <handa@m17n.org>
712
713 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
714 extra slot even if the purpose is char-code-property-table.
715
1a2e6670
EZ
7162011-08-23 Eli Zaretskii <eliz@gnu.org>
717
8ddde651
EZ
718 * xdisp.c (redisplay_window): When computing centering_position,
719 account for the height of the header line. (Bug#8874)
720
425cc014
EZ
721 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
722 instead of CHAR_TO_BYTE. Fixes a crash when a completion
723 candidate is selected by the mouse, and that candidate has a
724 composed character under the mouse.
725
1a2e6670
EZ
726 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
727 coordinates reported by pos-visible-in-window-p for a composed
728 character in column zero.
729
8b76d6f8
SM
7302011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
731
732 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
733
dac347dd
EZ
7342011-08-22 Eli Zaretskii <eliz@gnu.org>
735
736 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
737 consider it a hit if to_charpos is anywhere in the range of the
738 composed buffer positions.
739
e013fb34
CY
7402011-08-22 Chong Yidong <cyd@stupidchicken.com>
741
742 * image.c (gif_load): Don't assume that each subimage has the same
743 dimensions as the base image. Handle disposal method that is
744 "undefined" by the gif spec (Bug#9335).
745
bd1ba3e8
CY
7462011-08-20 Chong Yidong <cyd@stupidchicken.com>
747
748 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 749 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 750
54a1215b
EZ
7512011-08-19 Eli Zaretskii <eliz@gnu.org>
752
823564e5
EZ
753 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
754 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
755 from an Org mode buffer to a Speedbar frame.
756
54a1215b
EZ
757 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
758 a composition, take its buffer position from IT->cmp_it.charpos.
759 Fixes cursor positioning at the beginning of a line that begins
760 with a composed character.
761
9778ebcc
EZ
7622011-08-18 Eli Zaretskii <eliz@gnu.org>
763
0be6ee06
EZ
764 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
765 character bidirectional type, use STRONG_L instead. Fixes crashes
766 in a buffer produced by `describe-categories'.
767
9778ebcc
EZ
768 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
769 members before the level stack, so they would be saved and
770 restored when copying iterator state. Fixes incorrect reordering
771 around TABs covered by display properties.
772
156bffbe
AS
7732011-08-18 Andreas Schwab <schwab@linux-m68k.org>
774
775 * process.c (Fnetwork_interface_list): Correctly determine buffer
776 size.
777
72ad093b
CY
7782011-08-17 Chong Yidong <cyd@stupidchicken.com>
779
780 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
781 (internal_condition_case_2, internal_condition_case_n):
782 Remove unnecessary aborts (Bug#9081).
72ad093b 783
35774242
EZ
7842011-08-17 Eli Zaretskii <eliz@gnu.org>
785
786 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
787 has no `load' handler, try opening the file locally. (Bug#9311)
788
db76dd85
KB
7892011-08-16 Ken Brown <kbrown@cornell.edu>
790
791 * gmalloc.c: Expand comment.
792
b215eee5
EZ
7932011-08-16 Eli Zaretskii <eliz@gnu.org>
794
795 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
796 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
797
a4579d33
KB
7982011-08-16 Ken Brown <kbrown@cornell.edu>
799
800 Fix memory allocation problems in Cygwin build (Bug#9273).
801
802 * unexcw.c ( __malloc_initialized): Declare external variable.
803 (fixup_executable): Force the dumped emacs to reinitialize malloc.
804
8b76d6f8
SM
805 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
806 New variables.
a4579d33
KB
807 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
808 dumped emacs.
809 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
810 in the static heap.
811 [CYGWIN] (special_realloc): New function.
812 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
813 requests to realloc storage in the static heap.
814
3ebec551
PE
8152011-08-15 Paul Eggert <eggert@cs.ucla.edu>
816
817 * bidi.c (bidi_initialize): Remove unused local.
818
9fd8be00
EZ
8192011-08-15 Eli Zaretskii <eliz@gnu.org>
820
474a8465
EZ
821 * biditype.h: File removed.
822
823 * bidimirror.h: File removed.
824
825 * deps.mk (bidi.o): Remove biditype.h and
826 bidimirror.h.
827
828 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
829 bidimirror.h.
830
831 * dispextern.h: Fix a typo in the comment to bidi_type_t.
832
833 * chartab.c: Improve commentary for the uniprop_table API.
834
32413314
EZ
835 * bidi.c (bidi_paragraph_init): Support zero value of
836 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
837 (bidi_initialize): Use uniprop_table instead of including
838 biditype.h and bidimirror.h.
32413314 839
9fd8be00
EZ
840 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
841 coordinates of the iterator when restoring from ppos_it.
842 (Bug#9296)
843
5cf2b69b
KH
8442011-08-14 Kenichi Handa <handa@m17n.org>
845
846 * process.c (create_process): Call setup_process_coding_systems
72ad093b 847 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 848
daf17d00
EZ
8492011-08-14 Eli Zaretskii <eliz@gnu.org>
850
851 * xdisp.c (move_it_in_display_line_to): Don't invoke
852 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
853 ppos_it. Fixes vertical cursor motion when line beginning is
854 covered by an image. (Bug#9296)
855
08e3161a
JD
8562011-08-14 Jan Djärv <jan.h.d@swipnet.se>
857
858 * nsterm.h (ns_run_ascript): Declare.
859 (NSAPP_DATA2_RUNASSCRIPT): Define.
860
861 * nsfns.m (as_script, as_result, as_status): New static variables.
862 (ns_run_ascript): New function.
863 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
864 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
865 the event loop. Get status from as_status (Bug#7276).
866
867 * nsterm.m (sendEvent): If event is NSApplicationDefined and
868 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
869 the event loop (Bug#7276).
870
a3720aa2
AS
8712011-08-14 Andreas Schwab <schwab@linux-m68k.org>
872
873 * gnutls.c (QCgnutls_bootprop_priority)
874 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
875 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
876 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
877 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
878 (QCgnutls_bootprop_verify_hostname_error)
879 (QCgnutls_bootprop_callbacks_verify): Rename from
880 Qgnutls_bootprop_..., all uses changed.
881
882 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
883 uses changed.
884
0a0d27fb
PE
8852011-08-14 Paul Eggert <eggert@cs.ucla.edu>
886
19d5c50c
PE
887 * xfaces.c (Qframe_set_background_mode): Now static.
888 * dispextern.h (Qframe_set_background_mode): Remove decl.
889
0a0d27fb
PE
890 * process.c (Fnetwork_interface_info): Declare local only if needed.
891
377538cb
JD
8922011-08-13 Jan Djärv <jan.h.d@swipnet.se>
893
894 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
895 (Fnetwork_interface_list): Allocate in increments of bytes instead
896 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
897 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
898 sockaddr.
899 (struct ifflag_def): notrailers is smart on OSX.
900 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
901 Get hardware address with getifaddrs if available.
902
08fff70c
EZ
9032011-08-12 Eli Zaretskii <eliz@gnu.org>
904
905 * xdisp.c (iterate_out_of_display_property): xassert that
906 IT->position is set to within IT->object's boundaries. Break from
907 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
908 when IT->position is set up wrongly due to some bug.
909 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
910 (push_display_prop): Allow GET_FROM_STRING as IT->method on
911 entry. Force push_it to save on the stack the current
912 buffer/string position, to be restored by pop_it. Fix flags in
913 the iterator structure wrt the object coming from a display
914 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
915 properties. (Bug#9284)
916
7be1c708 9172011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 918
7be1c708
CY
919 * fontset.c (fontset_get_font_group): Add proper type checks.
920 (Bug#9172)
aac0c6e3 921
7be1c708 9222011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 923
7be1c708
CY
924 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
925 and LC_VERSION_MIN_MACOSX.
926 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
927 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 928
97bb72a6
EZ
9292011-08-08 Eli Zaretskii <eliz@gnu.org>
930
931 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
932 no-display-properties-and-no-overlays under bidi display.
933 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 934 properties and overlays.
97bb72a6 935
d5617611
CY
9362011-08-08 Chong Yidong <cyd@stupidchicken.com>
937
37e11a63
CY
938 * editfns.c (Fset_time_zone_rule): Document relationship with the
939 setenv function.
940
d5617611
CY
941 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
942 the font entity extracted from the cache (Bug#8109).
943
58872834
CY
9442011-08-07 Chong Yidong <cyd@stupidchicken.com>
945
946 * composite.c (autocmp_chars): Don't reset point. That is done by
947 restore_point_unwind (Bug#5984).
948
75bfc667
JL
9492011-08-07 Juri Linkov <juri@jurta.org>
950
951 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
952 to show the arg `TIME' instead of `TIMEVAL'.
953
d1410150
EZ
9542011-08-06 Eli Zaretskii <eliz@gnu.org>
955
956 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
957 display property strides EOL and includes a newline, as in
958 longlines-mode. (Bug#9254)
75b771e4
EZ
959 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
960 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
961
962 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
963 is non-zero, even if the data buffer is NULL. Fixes a crash in
964 vertical-motion with longlines-mode. (Bug#9254)
965
35928349
EZ
9662011-08-05 Eli Zaretskii <eliz@gnu.org>
967
ec7cc85b
EZ
968 * bidi.c <bidi_cache_total_alloc>: Now static.
969 (bidi_initialize): Initialize bidi_cache_total_alloc.
970
8b76d6f8 971 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
972 cache. (Bug#9221)
973
974 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
975 amount allocated this far in `bidi_cache_total_alloc'.
976 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
977 non-zero, only free the data buffer without restoring the cache
978 contents. All callers changed.
979
980 * dispextern.h (bidi_unshelve_cache): Update prototype.
981
982 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
983 (move_it_in_display_line, move_it_to)
984 (move_it_vertically_backward, move_it_by_lines): Replace the call
985 to xfree to an equivalent call to bidi_unshelve_cache.
986 (move_it_in_display_line_to): Fix logic of returning
412b6358 987 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 988
e2e2423b
EZ
9892011-08-05 Eli Zaretskii <eliz@gnu.org>
990
991 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
992 came from a string character with a `cursor' property. (Bug#9229)
993
ae9e757a
JD
9942011-08-04 Jan Djärv <jan.h.d@swipnet.se>
995
996 * Makefile.in (LIB_PTHREAD): New variable.
997 (LIBES): Add LIB_PTHREAD (Bug#9216).
998
999 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1000 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1001
213bd7f2
AS
10022011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1003
1004 * regex.c (re_iswctype): Remove some redundant boolean
1005 conversions.
1006
99aaf75f
JD
10072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1008
1009 * xterm.c (x_find_topmost_parent): New function.
1010 (x_set_frame_alpha): Find topmost parent window with
1011 x_find_topmost_parent and set the property there also (bug#9181).
1012 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1013
c74e9d86
PE
10142011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1015
1016 * callproc.c (Fcall_process): Avoid vfork clobbering
1017 the local vars buffer, coding_systems, current_dir.
1018
640c8776
SM
10192011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1020
1021 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1022
f26d0e4c
PE
10232011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1024
8a10d76c
PE
1025 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1026 so that it is not optimized away.
1027
f26d0e4c
PE
1028 * xdisp.c (compute_display_string_pos): Remove unused local.
1029
55439c61
EZ
10302011-08-02 Eli Zaretskii <eliz@gnu.org>
1031
1032 Fix slow cursor motion and scrolling in large buffers with
1033 selective display, like Org Mode buffers. (Bug#9218)
1034
1035 * dispextern.h (struct bidi_it): New member disp_prop_p.
1036
1037 * xdisp.c: Remove one-slot cache of display string positions.
1038 (compute_display_string_pos): Accept an additional argument
1039 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1040 for a display string or property. If found, set DISP_PROP_P
1041 non-zero.
1042
1043 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1044 DISP_PROP_P, and pass it to compute_display_string_pos.
1045 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1046 non-zero. All callers of bidi_fetch_char changed.
1047
fb33fa43
SM
10482011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1049
1050 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1051
b099e063
DM
10522010-12-03 Don March <don@ohspite.net>
1053
1054 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1055 last character M-[char] is translated to ESC [char] (bug#7541).
1056
5cc7f7af
KH
10572011-08-02 Kenichi Handa <handa@m17n.org>
1058
d0fffa3f 1059 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1060
1061 * chartab.c (uniprop_table): Make it non-static.
1062
525d5e6e
EZ
10632011-08-01 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (forward_to_next_line_start): Accept additional argument
1066 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1067 on the newline.
1068 (reseat_at_next_visible_line_start): Use the bidi iterator state
1069 returned by forward_to_next_line_start to restore the state of
1070 it->bidi_it after backing up to previous newline. (Bug#9212)
1071
31011111
AS
10722011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1073
1074 * regex.c (re_comp): Protoize.
1075 (re_exec): Fix return type.
1076 (regexec): Fix type of `ret'. (Bug#9203)
1077
e5d76069
PE
10782011-07-29 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1081 This is needed if max-image-size is a floating-point number.
1082
9a79b20c
AS
10832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1084
1085 * print.c (print_object): Print empty symbol as ##.
1086
1087 * lread.c (read1): Read ## as empty symbol.
1088
d8c2fa78
AA
10892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1090
1091 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1092 setting frame foreground color (Bug#9175).
1093 (x_set_background_color): Likewise.
1094
ffe57a7a
AA
1095 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1096 contents (Bug#9176).
1097 (EmacsTooltip -init): Remove bezels and add shadows to
1098 tooltip windows.
1099
bf3492a5
AA
1100 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1101 or scroll bar (Bug#8470).
1102
d55e9c53
AA
1103 * nsfont.m (nsfont_open): Remove assignment to voffset and
1104 unnecessary vars hshink, expand, hd, full_height, min_height.
1105 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1106
1107 * nsterm.h (nsfont_info): Remove voffset field.
1108
d8c2fa78 11092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1110
1111 Implement strike-through and overline on NextStep (Bug#8863).
1112
1113 * nsfont.m (nsfont_open): Use underline position provided by font,
1114 instead of hard-coded value of 2.
1115 (nsfont_draw): Call ns_draw_text_decoration instead.
1116
1117 * nsterm.h: Add declaration for ns_draw_text_decoration.
1118
1119 * nsterm.m (ns_draw_text_decoration): New function for drawing
1120 underline, overline, and strike-through.
1121 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1122 ns_draw_text_decoration. Change treatment of cursor drawing to
1123 accomodate underlining, etc.
1124
4cc60b9b
EZ
11252011-07-28 Eli Zaretskii <eliz@gnu.org>
1126
bc7ece87
EZ
1127 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1128 default.
4cc60b9b 1129
476371c4
PE
11302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1131
66606eea
PE
1132 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1133 Without this fix, if a signal arrives just after memory fills up,
1134 'malloc' might be invoked reentrantly.
1135
476371c4
PE
1136 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1137 In other words, assume that every image size is allowed, on non-X
1138 hosts. This assumption is probably wrong, but it lets Emacs compile.
1139
f3fcc40d
AS
11402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1141
1142 * regex.c (re_iswctype): Convert return values to boolean.
1143
350c992f
EZ
11442011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1145
1146 * xdisp.c (compute_display_string_pos): Don't use cached display
1147 string position if the buffer had its restriction changed.
1148 (Bug#9184)
1149
5266b4bb
PE
11502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1153
2573a837 11542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1155
41f55ccd 1156 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1157
39e378da
PE
1158 * bidi.c: Integer size and overflow fixes.
1159 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1160 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1161 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1162 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1163 (bidi_find_other_level_edge):
1164 Use ptrdiff_t instead of EMACS_INT where either will do.
1165 This works better on 32-bit hosts configured --with-wide-int.
1166 (bidi_cache_ensure_space): Check for size-calculation overflow.
1167 Use % rather than repeated addition, for better worst-case speed.
1168 Don't set bidi_cache_size until after xrealloc returns, because it
1169 might not return.
1170 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1171 (bidi_cache_ensure_space): Also check that the bidi cache size
1172 does not exceed that of the largest Lisp string or buffer. See Eli
1173 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1174
5e927815
PE
1175 * alloc.c (__malloc_size_t): Remove.
1176 All uses replaced by size_t. See Andreas Schwab's note
1177 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1178
ca4aa935
PE
1179 * image.c: Improve checking for integer overflow.
1180 (check_image_size): Assume that f is nonnull, since
1181 it is always nonnull in practice. This is one less thing to
1182 worry about when checking for integer overflow later.
1183 (x_check_image_size): New function, which checks for integer
1184 overflow issues inside X.
1185 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1186 This removes the need for a memory_full check.
1187 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1188 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1189 (xbm_read_bitmap_data): Change locals back to 'int', since
1190 their values must fit in 'int'.
1191 (xpm_load_image, png_load, tiff_load):
1192 Invoke x_create_x_image_and_pixmap earlier,
1193 to avoid much needless work if the image is too large.
1194 (tiff_load): Treat overly large images as if
1195 x_create_x_image_and_pixmap failed, not as malloc failures.
1196 (gs_load): Use x_check_image_size.
1197
5f8f9cc2
PE
1198 * gtkutil.c: Omit integer casts.
1199 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1200 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1201
5adf60bc
PE
1202 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1203
c8907a93
PE
1204 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1205 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1206 would wrongly return t on a 64-bit host.
1207
e3c25c68
PE
1208 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1209 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1210 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1211 and therefore cause GCC to emit a bogus diagnostic in some cases.
1212
3f791afe
PE
1213 * image.c: Integer signedness and overflow and related fixes.
1214 This is not an exhaustive set of fixes, but it's time to
1215 record what I've got.
1216 (lookup_pixel_color, check_image_size): Remove redundant decls.
1217 (check_image_size): Don't assume that arbitrary EMACS_INT values
1218 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1219 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1220 (tiff_load, imagemagick_load_image):
1221 Check for overflow in size calculations.
1222 (x_create_x_image_and_pixmap): Remove unnecessary test for
1223 xmalloc returning NULL; that can't happen.
1224 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1225 (xpm_color_bucket): Use better integer hashing function.
1226 (xpm_cache_color): Don't possibly over-allocate memory.
1227 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1228 (gif_memory_source):
1229 Use ptrdiff_t, not int or size_t, to record sizes.
1230 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1231 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1232 either works, as we prefer signed integers.
1233 (tiff_read_from_memory, tiff_write_from_memory):
1234 Return tsize_t, not size_t, since that's what the TIFF API wants.
1235 (tiff_read_from_memory): Don't fail simply because the read would
1236 go past EOF; instead, return a short read.
1237 (tiff_load): Omit no-longer-needed casts.
1238 (Fimagemagick_types): Don't assume size fits into 'int'.
1239
3cc5a532
PE
1240 Improve hashing quality when configured --with-wide-int.
1241 * fns.c (hash_string): New function, taken from sxhash_string.
1242 Do not discard information about ASCII character case; this
1243 discarding is no longer needed.
1244 (sxhash-string): Use it. Change sig to match it. Caller changed.
1245 * lisp.h: Declare it.
1246 * lread.c (hash_string): Remove, since we now use fns.c's version.
1247 The fns.c version returns a wider integer if --with-wide-int is
1248 specified, so this should help the quality of the hashing a bit.
1249
b312a492
PE
1250 * emacs.c: Integer overflow minor fix.
1251 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1252 Define only if GNU_LINUX.
1253 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1254
dfd153ae
PE
1255 * dispnew.c: Integer signedness and overflow fixes.
1256 Remove unnecessary forward decls, that were a maintenance hassle.
1257 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1258 All uses changed.
1259 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1260 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1261 (prepare_desired_row, line_draw_cost):
1262 Use int, not unsigned, where either works.
1263 (save_current_matrix, restore_current_matrix):
1264 Use ptrdiff_t, not size_t, where either works.
1265 (init_display): Check for overflow more accurately, and without
1266 relying on undefined behavior.
1267
a81d11a3
PE
1268 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1269 Remove, replacing with the new symbols in lisp.h. All uses changed.
1270 * fileio.c (make_temp_name):
1271 * filelock.c (lock_file_1, lock_file):
1272 * xdisp.c (message_dolog):
1273 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1274 Use pMd etc. instead.
1275 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1276 replacing the pWIDE etc. symbols removed from editfns.c.
1277
3300e6fd
PE
1278 * keyboard.h (num_input_events): Now uintmax_t.
1279 This is (very slightly) less likely to mess up due to wraparound.
1280 All uses changed.
1281
fd05c7e9
PE
1282 * buffer.c: Integer signedness fixes.
1283 (alloc_buffer_text, enlarge_buffer_text):
1284 Use ptrdiff_t rather than size_t when either will do, as we prefer
1285 signed integers.
1286
903fe15d
PE
1287 * alloc.c: Integer signedness and overflow fixes.
1288 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1289 (__malloc_size_t): Default to size_t, not to int.
1290 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1291 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1292 Prefer ptrdiff_t to size_t when either would do, as we prefer
1293 signed integers.
1294 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1295 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1296 Now const. Initialize with values that are in range even if char
1297 is signed.
1298 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1299 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1300 These functions do the right thing with sizes > 2**32.
1301 (check_depth): Now ptrdiff_t, not int.
1302 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1303 Adjust to new way of storing sizes. Check for size overflow bugs
1304 in rest of code.
1305 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1306 slightly wrong anyway, as it missed one instance of
1307 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1308 (refill_memory_reserve): Omit needless cast to size_t.
1309 (mark_object_loop_halt): Mark as externally visible.
1310
ac82cc6a
PE
1311 * xselect.c: Integer signedness and overflow fixes.
1312 (Fx_register_dnd_atom, x_handle_dnd_message):
1313 Use ptrdiff_t, not size_t, since we prefer signed.
1314 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1315 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1316 x_dnd_atoms_size and x_dnd_atoms_length.
1317
c2d1e36d
PE
1318 * doprnt.c: Prefer signed to unsigned when either works.
1319 * eval.c (verror):
1320 * doprnt.c (doprnt):
1321 * lisp.h (doprnt):
1322 * xdisp.c (vmessage):
1323 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1324 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1325 prefer signed arithmetic to avoid comparison confusion.
1326 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1327 but is a bit tricky.
1328
0e926e56
PE
1329 Assume freestanding C89 headers, string.h, stdlib.h.
1330 * data.c, doprnt.c, floatfns.c, print.c:
1331 Include float.h unconditionally.
1332 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1333 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1334 * regex.c: Likewise for stddef.h, string.h.
1335 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1336 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1337 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1338 (STDC_HEADERS): Remove obsolete defines.
1339 * sysdep.c: Include limits.h unconditionally.
1340
9cfdb3ec
PE
1341 Assume support for memcmp, memcpy, memmove, memset.
1342 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1343 * regex.c (memcmp, memcpy):
1344 Remove; we assume C89 now.
1345
1346 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1347 (__malloc_safe_bcopy): Remove; no longer needed.
1348
cf950e6b 1349 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1350 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1351 well either way, and we prefer signed to unsigned.
1352
dbf38e02
LMI
13532011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1354
1355 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1356 closes the connection while we're reading (bug#9182).
1357
d6f0886c
JD
13582011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1359
1360 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1361 are specified (Bug#9168).
1362
2eb1f9e6
PE
13632011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1366 Found by GCC static checking and --with-wide-int on a 32-bit host.
1367
22381272 13682011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1369
1370 * xdisp.c (compute_display_string_pos): Fix logic of caching
1371 previous display string position. Initialize cached_prev_pos to
1372 -1. Fixes slow-down at the beginning of a buffer.
1373
f25e39b4
EZ
13742011-07-24 Eli Zaretskii <eliz@gnu.org>
1375
1376 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1377 for attrs[LFACE_FONTSET_INDEX].
1378
04c4b52e
PE
13792011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * xml.c (parse_region): Remove unused local
1382 that was recently introduced.
1383
c1734fbd
EZ
13842011-07-23 Eli Zaretskii <eliz@gnu.org>
1385
be18c5a5
EZ
1386 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1387 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1388
c1734fbd
EZ
1389 * xdisp.c (move_it_in_display_line_to): Record the best matching
1390 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1391 exit if none of the characters scanned was an exact match.
1392 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1393 when exact match is impossible due to invisible text, and the
1394 lines are truncated.
1395
a258d627
JD
13962011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1397
1398 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1399 for OSX >= 10.7.
1400
b6d5a689
EZ
14012011-07-22 Eli Zaretskii <eliz@gnu.org>
1402
0f74f785
EZ
1403 Fix a significant slow-down of cursor motion with C-n, C-p,
1404 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1405 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1406 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1407 (next_element_from_buffer): Call compute_stop_pos_backwards to
1408 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1409 base_level_stop.
1410 (reseat): Don't look for prev_stop, as that could mean a very long
1411 run.
1412 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1413 <cached_disp_overlay_modiff>: Cache for last found display string
1414 position.
551918c1 1415 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1416 about the same buffer in the same area of character positions, and
1417 the buffer wasn't changed since the time the display string
1418 position was cached.
551918c1 1419
b2d0c91a
EZ
14202011-07-22 Eli Zaretskii <eliz@gnu.org>
1421
1422 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1423 is an integer, which is important for empty lines. (Bug#9149)
1424
043604ee
CY
14252011-07-22 Chong Yidong <cyd@stupidchicken.com>
1426
1427 * frame.c (Fmodify_frame_parameters): In tty case, update the
1428 default face if necessary (Bug#4238).
1429
da4adb04
CY
14302011-07-21 Chong Yidong <cyd@stupidchicken.com>
1431
1432 * editfns.c (Fstring_to_char): No need to explain what a character
1433 is in the docstring (Bug#6576).
1434
9abd0532
LMI
14352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1436
1437 * xml.c (parse_region): Make sure we always return a tree.
1438
36881d16
HK
14392011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1440
1441 * xml.c (parse_region): If a document contains only comments,
1442 return that, too.
1443
1e98674d
LMI
14442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1445
1446 * xml.c (make_dom): Return comments, too.
1447
590bd467
PE
14482011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1449
1450 Port to OpenBSD.
1451 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1452 and the surrounding thread.
1453 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1454 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1455 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1456 timer goes off.
1457 * s/openbsd.h (BROKEN_SIGIO): Define.
1458 * unexelf.c (unexec) [__OpenBSD__]:
1459 Don't update the .mdebug section of the Alpha COFF symbol table.
1460
f41628b2
LMI
14612011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1462
1463 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1464 (bug#8460).
1465
b59b67c5
PE
14662011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1467
15e3a074
PE
1468 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1469 This fixes some race conditions on the permissions of any newly
1470 created file.
1471
41bed37d
PE
1472 * alloc.c (valid_pointer_p): Use pipe, not open.
1473 This fixes some permissions issues when debugging.
1474
b59b67c5
PE
1475 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1476 If fchown fails to set both uid and gid, try to set just gid,
1477 as that is sometimes allowed. Adjust the file's mode to eliminate
1478 setuid or setgid bits that are inappropriate if fchown fails.
1479
925a6be7
SM
14802011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1481
1482 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1483 to compare Lisp_Objects.
1484 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1485 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1486 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1487
52968808
AS
14882011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1489
0a6a104b
AS
1490 * lread.c (read_integer): Unread even EOF character.
1491 (read1): Likewise. Properly record start position of symbol.
1492
52968808
AS
1493 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1494 symbol character follows.
1495
9e381cdd
PE
14962011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1499 This works around a problem with the previous change to Fcopy_file.
1500 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1501 and without this change, GCC might complain about discarding
1502 fchown's return value.
1503
b5641435
JB
15042011-07-16 Juanma Barranquero <lekktu@gmail.com>
1505
1506 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1507
a8031457
PE
15082011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1509
1510 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1511
dd889327
LMI
15122011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1513
750c33f7
LMI
1514 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1515 it's used from the C level.
1516
dd889327
LMI
1517 * process.c: Use the same condition for POLL_FOR_INPUT in both
1518 keyboard.c and process.c (bug#1858).
1519
87e86684
LM
15202011-07-09 Lawrence Mitchell <wence@gmx.li>
1521
1522 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1523 (Fgnutls_boot): Use it.
1524
64348f40
AS
15252011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1526
1527 * doc.c (Fsubstitute_command_keys): Revert last change.
1528
1d698799
LMI
15292011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1530
f863868c
LMI
1531 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1532 quotes the next character, and doesn't affect other longer
1533 sequences (bug#8935).
1534
1d698799
LMI
1535 * lread.c (syms_of_lread): Clarify that is isn't only
1536 `eval-buffer' and `eval-defun' that's affected by
1537 `lexical-binding' (bug#8460).
1538
aa4b6df6
EZ
15392011-07-15 Eli Zaretskii <eliz@gnu.org>
1540
1541 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1542 bidi redisplay when a line includes both an image and is
1543 truncated.
1544
5d856da6
PE
15452011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1546
ad6042bb
PE
1547 Fix minor problems found by static checking.
1548 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1549 (elsz): Now a signed constant, not a size_t var. We prefer signed
1550 types to unsigned, to avoid integer comparison confusion. Without
1551 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1552 "cannot optimize loop, the loop counter may overflow", a symptom
1553 of the confusion.
f00bbb22 1554 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1555 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1556
6468f31c
LMI
15572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1558
49080b10
LMI
1559 * search.c (Fre_search_backward): Mention `case-fold-search' in
1560 all the re_search_* functions (bug#8138).
1561
6468f31c
LMI
1562 * keyboard.c (Fopen_dribble_file): Document when the file is
1563 closed (bug#8056).
1564
c965adc5
EZ
15652011-07-14 Eli Zaretskii <eliz@gnu.org>
1566
df9733bf
EZ
1567 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1568 bidi_cache_idx.
1569
0bb23927
EZ
1570 Support bidi reordering of display and overlay strings.
1571 * xdisp.c (compute_display_string_pos)
1572 (compute_display_string_end): Accept additional argument STRING.
1573 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1574 (reseat_to_string): Initialize bidi_it->string.s and
1575 bidi_it->string.schars.
1576 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1577 NULL (avoids a crash in bidi_paragraph_init).
1578 Initialize itb.string.lstring.
0bb23927
EZ
1579 (init_iterator): Call bidi_init_it only of a valid
1580 buffer position was specified. Initialize paragraph_embedding to
1581 L2R.
1582 (reseat_to_string): Initialize the bidi iterator.
1583 (display_string): If we need to ignore text properties of
1584 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1585 original value of -1 will not work with bidi.)
1586 (compute_display_string_pos): First arg is now struct
1587 `text_pos *'; all callers changed. Support display properties on
1588 Lisp strings.
1589 (compute_display_string_end): Support display properties on Lisp
1590 strings.
1591 (init_iterator, reseat_1, reseat_to_string): Initialize the
1592 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1593 when iterating on a string not from display properties).
640c8776
SM
1594 (compute_display_string_pos, compute_display_string_end):
1595 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1596 arrow keys.
1597 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1598 base_level_stop; instead, set base_level_stop to BEGV.
1599 Fixes crashes in vertical-motion.
0bb23927
EZ
1600 (next_element_from_buffer): Improve commentary for when
1601 the iterator is before prev_stop.
1602 (init_iterator): Initialize bidi_p from the default value of
1603 bidi-display-reordering, not from buffer-local value. Use the
1604 buffer-local value only if initializing for buffer iteration.
1605 (handle_invisible_prop): Support invisible properties on strings
1606 that are being bidi-reordered.
1607 (set_iterator_to_next): Support bidi reordering of C strings and
1608 Lisp strings.
1609 (next_element_from_string): Support bidi reordering of Lisp
1610 strings.
1611 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1612 (display_string): Support display of R2L glyph rows.
1613 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1614 (init_iterator): Don't initialize it->bidi_p for strings
1615 here.
1616 (reseat_to_string): Initialize it->bidi_p for strings here.
1617 (next_element_from_string, next_element_from_c_string)
1618 (next_element_from_buffer): Add xassert's for correspondence
1619 between IT's object being iterated and it->bidi_it.string
1620 structure.
1621 (face_before_or_after_it_pos): Support bidi iteration.
1622 (next_element_from_c_string): Handle the case of the first string
1623 character that is not the first one in the visual order.
1624 (get_visually_first_element): New function, refactored from common
1625 parts of next_element_from_buffer, next_element_from_string, and
1626 next_element_from_c_string.
1627 (tool_bar_lines_needed, redisplay_tool_bar)
1628 (display_menu_bar): Force left-to-right direction. Add a FIXME
1629 comment for making that be controlled by a user option.
1630 (push_it, pop_it): Save and restore the state of the
1631 bidi iterator. Save and restore the bidi_p flag.
1632 (pop_it): Iterate out of display property for string iteration as
1633 well.
1634 (iterate_out_of_display_property): Support iteration over strings.
1635 (handle_single_display_spec): Set up it->bidi_it for iteration
1636 over a display string, and call bidi_init_it.
1637 (handle_single_display_spec, next_overlay_string)
1638 (get_overlay_strings_1, push_display_prop): Set up the bidi
1639 iterator for displaying display or overlay strings.
1640 (forward_to_next_line_start): Don't use the shortcut if
1641 bidi-iterating.
1642 (back_to_previous_visible_line_start): If handle_display_prop
1643 pushed the iterator stack, restore the internal state of the bidi
1644 iterator by calling bidi_pop_it same number of times.
1645 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1646 and we are bidi-iterating, don't decrement the iterator position;
1647 instead, set the first_elt flag in the bidi iterator, to produce
1648 the same effect.
1649 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1650 (push_display_prop): xassert that we are iterating a buffer.
1651 (push_it, pop_it): Save and restore paragraph_embedding member.
1652 (handle_single_display_spec, next_overlay_string)
1653 (get_overlay_strings_1, reseat_1, reseat_to_string)
1654 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1655 correctly. Don't assume unibyte strings are not bidi-reordered.
1656 (compute_display_string_pos)
1657 (compute_display_string_end): Fix handling the case of C string.
1658 (push_it, pop_it): Save and restore from_disp_prop_p.
1659 (handle_single_display_spec, push_display_prop): Set the
1660 from_disp_prop_p flag.
1661 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1662 (pop_it): Call iterate_out_of_display_property only if we are
1663 popping after iteration over a string that came from a display
1664 property. Fix a typo in popping stretch info. Add an assertion
1665 for verifying that the iterator position is in sync with the bidi
1666 iterator.
1667 (handle_single_display_spec, get_overlay_strings_1)
1668 (push_display_prop): Fix initialization of paragraph direction for
1669 string when that of the parent object is not yet determined.
1670 (reseat_1): Call bidi_init_it to resync the bidi
1671 iterator with IT's position. (Bug#7616)
1672 (find_row_edges): If ROW->start.pos gives position
1673 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1674 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1675 Reset the from_disp_prop_p flag.
1676 (SAVE_IT, RESTORE_IT): New macros.
1677 (pos_visible_p, face_before_or_after_it_pos)
1678 (back_to_previous_visible_line_start)
1679 (move_it_in_display_line_to, move_it_in_display_line)
1680 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1681 (try_scrolling, redisplay_window, display_line): Use them when
1682 saving a temporary copy of the iterator and restoring it back.
1683 (back_to_previous_visible_line_start, reseat_1)
1684 (init_iterator): Empty the bidi cache "stack".
1685 (move_it_in_display_line_to): If iterator ended up at
1686 EOL, but we never saw any buffer positions smaller than
1687 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1688 motion in bidi-reordered lines.
1689 (move_it_in_display_line_to): Record prev_method and prev_pos
1690 immediately before the call to set_iterator_to_next. Fixes cursor
1691 motion in bidi-reordered lines with stretch glyphs and strings
1692 displayed in margins. (Bug#8133) (Bug#8867)
1693 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1694 TO_CHARPOS.
640c8776
SM
1695 (pos_visible_p): Support positions in bidi-reordered lines.
1696 Save and restore bidi cache.
0bb23927
EZ
1697
1698 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1699 (bidi_paragraph_info): Delete unused struct.
1700 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1701 (bidi_cache_start): New variable.
1702 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1703 to zero.
1704 (bidi_cache_fetch_state, bidi_cache_search)
1705 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1706 (bidi_cache_find, bidi_peek_at_next_level)
1707 (bidi_level_of_next_char, bidi_find_other_level_edge)
1708 (bidi_move_to_visually_next): Compare cache index with
1709 bidi_cache_start rather than with zero.
1710 (bidi_fetch_char): Accept new argument STRING; all callers
1711 changed. Support iteration over a string. Support strings with
1712 display properties. Support unibyte strings. Fix the type of
1713 `len' according to what STRING_CHAR_AND_LENGTH expects.
1714 (bidi_paragraph_init, bidi_resolve_explicit_1)
1715 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1716 (bidi_level_of_next_char, bidi_move_to_visually_next):
1717 Support iteration over a string.
0bb23927
EZ
1718 (bidi_set_sor_type, bidi_resolve_explicit_1)
1719 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1720 can now be zero (for strings); special values 0 and -1 were
1721 changed to -1 and -2, respectively.
1722 (bidi_char_at_pos): New function.
1723 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1724 Call it instead of FETCH_MULTIBYTE_CHAR.
1725 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1726 initialized to valid values.
1727 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1728 values.
1729 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1730 the test for valid cached positions. Fix the logic for looking up
1731 the sentinel state in the cache. GCPRO the Lisp string we are
1732 iterating.
1733 (bidi_push_it, bidi_pop_it): New functions.
1734 (bidi_initialize): Initialize the bidi cache start stack pointer.
1735 (bidi_cache_ensure_space): New function, refactored from part of
1736 bidi_cache_iterator_state. Don't assume the required size is just
1737 one BIDI_CACHE_CHUNK away.
1738 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1739 (bidi_count_bytes, bidi_char_at_pos): New functions.
1740 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1741 always valid if bidi_cache_idx is valid.
1742 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1743 is valid if it's going to be used.
1744 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1745 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1746 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1747 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1748 (bidi_find_other_level_edge, bidi_cache_start_stack):
1749 All variables related to cache indices are now EMACS_INT.
c965adc5 1750
0bb23927
EZ
1751 * dispextern.h (struct bidi_string_data): New structure.
1752 (struct bidi_it): New member `string'. Make flag members be 1-bit
1753 fields, and put them last in the struct.
640c8776
SM
1754 (compute_display_string_pos, compute_display_string_end):
1755 Update prototypes.
0bb23927
EZ
1756 (bidi_push_it, bidi_pop_it): Add prototypes.
1757 (struct iterator_stack_entry): New members bidi_p,
1758 paragraph_embedding, and from_disp_prop_p.
1759 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1760 (bidi_shelve_cache, bidi_unshelve_cache):
1761 Declare prototypes.
0bb23927
EZ
1762
1763 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1764 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1765 and vector-like objects.
1766
1767 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1768 cache around display iteration.
1769
1770 * window.c (Fwindow_end, window_scroll_pixel_based)
1771 (displayed_window_lines, Frecenter): Save and restore the bidi
1772 cache around display iteration.
1773
3bbd2265
LMI
17742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1775
1776 * editfns.c (Fdelete_region): Clarify the use of the named
1777 parameters (bug#6788).
1778
adc47434
MR
17792011-07-14 Martin Rudalics <rudalics@gmx.at>
1780
1781 * indent.c (Fvertical_motion): Set and restore w->pointm when
1782 saving and restoring the window's buffer (Bug#9006).
1783
837c31f8
LMI
17842011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1785
1786 * editfns.c (Fstring_to_char): Clarify just what is returned
1787 (bug#6576). Text by Eli Zaretskii.
1788
ac389d0c
JB
17892011-07-13 Juanma Barranquero <lekktu@gmail.com>
1790
1791 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1792
0be0ce47
EZ
17932011-07-13 Eli Zaretskii <eliz@gnu.org>
1794
1795 * buffer.c (mmap_find): Fix a typo.
1796
cd18e7e3
JB
17972011-07-13 Johan Bockgård <bojohan@gnu.org>
1798
1799 Fix execution of x selection hooks.
1800 * xselect.c (Qx_lost_selection_functions)
1801 (Qx_sent_selection_functions): New vars.
1802 (syms_of_xselect): DEFSYM them.
1803 (x_handle_selection_request): Pass Qx_sent_selection_functions
1804 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1805 (x_handle_selection_clear,x_clear_frame_selections):
1806 Pass Qx_lost_selection_functions rather than
1807 Vx_lost_selection_functions to Frun_hook_with_args.
1808
47ea7f44
PE
18092011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1810
ac389d0c 1811 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1812 The old code sometimes used this field without initializing it.
1813
47ea7f44
PE
1814 * alloc.c (gc_sweep): Don't read past end of array.
1815 In theory, the old code could also have corrupted Emacs internals,
1816 though it'd be very unlikely.
1817
bc985c87
AS
18182011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1819
1820 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1821 argument. (Bug#4026)
bc985c87 1822
0cf34688
LMI
18232011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1824
b3dadd76
LMI
1825 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1826 key" (bug#4257).
1827
0cf34688
LMI
1828 * window.c (Fset_window_start): Doc fix (bug#4199).
1829 (Fset_window_hscroll): Ditto.
1830
270768cd
PE
18312011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1832
077e3dda 1833 Fix minor new problems caught by GCC 4.6.1.
270768cd 1834 * term.c (init_tty): Remove unused local.
490011a6 1835 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1836 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1837 not used otherwise.
270768cd 1838
b1f58454
CY
18392011-07-12 Chong Yidong <cyd@stupidchicken.com>
1840
1841 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1842
22b9578d
LMI
18432011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1844
6e70ab07
LMI
1845 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1846 are the mini-buffer and the echo area (bug#3320).
1847
22b9578d
LMI
1848 * term.c (init_tty): Remove support for supdup, c10 and perq
1849 terminals, which are no longer supported (bug#1482).
1850
8974cc9f
JB
18512011-07-10 Johan Bockgård <bojohan@gnu.org>
1852
1853 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1854
a560d974
JD
18552011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1856
1857 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1858 for non-popups (Bug#3642).
1859
1dae0f0a
AS
18602011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1861
268c2c36 1862 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1863 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1864 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1865 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1866 * data.c (fmod): Likewise.
1867 * dispnew.c (swap_glyphs_in_rows): Likewise.
1868 * emacs.c (memory_warning_signal): Likewise.
1869 * floatfns.c (float_error): Likewise.
1870 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1871 (otf_open, font_otf_capability, generate_otf_features)
1872 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1873 Likewise.
1874 * image.c (pbm_read_file): Likewise.
1875 * indent.c (string_display_width): Likewise.
1876 * intervals.c (check_for_interval, search_for_interval)
1877 (inc_interval_count, count_intervals, root_interval)
1878 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1879 * lread.c (defalias): Likewise.
268c2c36 1880 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1881 * regex.c (set_image_of_range_1, set_image_of_range)
1882 (regex_grow_registers): Likewise.
1883 * sysdep.c (strerror): Likewise.
1884 * termcap.c (valid_filename_p, tprint, main): Likewise.
1885 * tparam.c (main): Likewise.
1886 * unexhp9k800.c (run_time_remap, save_data_space)
1887 (update_file_ptrs, read_header, write_header, calculate_checksum)
1888 (copy_file, copy_rest, display_header): Likewise.
1889 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1890 Likewise.
1891 * xdisp.c (check_it): Likewise.
1892 * xfaces.c (register_color, unregister_color, unregister_colors):
1893 Likewise.
1894 * xfns.c (print_fontset_result): Likewise.
1895 * xrdb.c (member, fatal, main): Likewise.
1896
99033785
PE
18972011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1898
1899 Fix minor problems found by static checking (Bug#9031).
1900 * chartab.c (char_table_set_range, map_sub_char_table):
1901 Remove unused locals.
1902 (uniprop_table): Now static.
1903 * composite.c (_work_char): Remove unused static var.
1904
9cb2ac56
JB
19052011-07-09 Juanma Barranquero <lekktu@gmail.com>
1906
1907 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1908
f25661f0
JD
19092011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1910
1911 * gtkutil.c (qttip_cb): Remove code without function.
1912
8278c4fe
EZ
19132011-07-09 Eli Zaretskii <eliz@gnu.org>
1914
1915 * w32.c (pthread_sigmask): New stub.
1916
1692ae2d 19172011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1918
8a6ebd58 1919 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1920 sigprocmask is portable only for single-threaded applications, and
1921 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1922 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1923 (LIBES): Use it.
1924 * callproc.c (Fcall_process):
1925 * process.c (create_process):
1926 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1927 Use pthread_sigmask, not sigprocmask.
123403e4 1928
1b854618
JD
19292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1930
1931 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1932 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1933 wrong (Bug#8591).
1934
3fe4b549
JD
19352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1936
0ce7e563
JD
1937 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1938 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1939 (xg_hide_tooltip): Fix comment.
1940
3fe4b549
JD
1941 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1942 in registerServicesMenuSendTypes.
1943 (validRequestorForSendType): Don't check ns_return_types.
1944
1945 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1946 ns_return_type.
1947
5df75e47
JR
19482011-07-08 Jason Rumney <jasonr@gnu.org>
1949
1950 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1951 frame struct members of non-existent frames (Bug#6284).
1952
699c10bd
JD
19532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1954
4393663b
JD
1955 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1956 variable firstTime not needed on OSX >= 10.6.
1957 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1958 >= 10.5. Use setKnobProportion, setDoubleValue.
1959
1960 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1961 (MAC_OS_X_VERSION_10_5): Define if not defined.
1962 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1963 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1964 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1965
1966 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1967 cString and lossyCString on OSX >= 10.4
1968
1969 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1970 sizeToFit on OSX >= 10.2.
1971
1972 * nsimage.m (allocInitFromFile): Don't use deprecated method
1973 bestRepresentationForDevice on OSX >= 10.6.
1974
1975 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1976 to avoid warning.
1977
1978 * emacs.c: Declare unexec_init_emacs_zone.
1979
a63e0781
JD
1980 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1981
699c10bd
JD
1982 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1983
1984 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1985 on svcsMenu (Bug#8842).
1986
1987 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1988 ns_return_types.
1989 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1990
1991 * nsterm.m (QUTF8_STRING): Declare.
1992 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1993 (validRequestorForSendType): Return type is (id).
1994 Change indexOfObjectIdenticalTo to indexOfObject.
1995 Check if we have local selection before returning self (Bug#8842).
1996 (writeSelectionToPasteboard): Put local selection into paste board
1997 if we have a local selection (Bug#8842).
1998 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1999
2000 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2001 (ns_get_local_selection): Declare.
2002
54e10184
LMI
20032011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2004
9888ff71
LMI
2005 * keymap.c (describe_map_tree): Don't insert a double newline at
2006 the end of the buffer (bug#1169) and return whether we inserted
2007 something.
2008
54e10184
LMI
2009 * callint.c (Fcall_interactively): Change "reading args" to
2010 "providing args" to try to clarify what it does (bug#1010).
2011
15fa4783
KH
20122011-07-07 Kenichi Handa <handa@m17n.org>
2013
2014 * composite.c (composition_compute_stop_pos): Ignore a static
2015 composition starting before CHARPOS (Bug#8915).
2016
2017 * xdisp.c (handle_composition_prop): Likewise.
2018
a8815b00
EZ
20192011-07-07 Eli Zaretskii <eliz@gnu.org>
2020
2021 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2022 (Bug#9015)
2023
ef7b981d 20242011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2025
2026 * character.h (unicode_category_t): New enum type.
2027
2028 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2029 (Qchar_code_property_table): New variable.
2030 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2031 (UNIPROP_COMPRESSED_FORM_P): New macros.
2032 (char_table_ascii): Uncompress the compressed values.
2033 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2034 Uncompress the compressed values.
ac389d0c 2035 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2036 (char_table_ref_and_range): Uncompress the compressed values.
2037 (sub_char_table_set): New arg is_uniprop. Callers changed.
2038 Uncompress the compressed values.
2039 (sub_char_table_set_range): Args changed. Callers changed.
2040 (char_table_set_range): Adjuted for the above change.
2041 (map_sub_char_table): Delete args default_val and parent. Add arg
2042 top. Give decoded values to a Lisp function.
640c8776 2043 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2044 values to a Lisp function. Gcpro more variables.
2045 (uniprop_table_uncompress)
2046 (uniprop_decode_value_run_length): New functions.
2047 (uniprop_decoder, uniprop_decoder_count): New variables.
2048 (uniprop_get_decoder, uniprop_encode_value_character)
2049 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2050 New functions.
2051 (uniprop_encoder, uniprop_encoder_count): New variables.
2052 (uniprop_get_encoder, uniprop_table)
2053 (Funicode_property_table_internal, Fget_unicode_property_internal)
2054 (Fput_unicode_property_internal): New functions.
2055 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2056 Sunicode_property_table_internal, Sget_unicode_property_internal,
2057 and Sput_unicode_property_internal. Defvar_lisp
2058 char-code-property-alist.
2059
640c8776 2060 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2061 Vunicode_category_table.
2062
640c8776 2063 * font.c (font_range): Adjust for the change of
c805dec0
KH
2064 Vunicode_category_table.
2065
76b397fb
DN
20662011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2067
2068 * m/iris4d.h: Remove file, move contents ...
2069 * s/irix6-5.h: ... here.
2070
22b4128e
PE
20712011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2074 * alloc.c (mark_buffer):
2075 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2076 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2077 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2078 This isn't true in general, and it's particularly not true
2079 if Emacs is configured with --with-wide-int.
2080 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2081 New macros, used in the buffer.c change.
2082
869795d6
JD
20832011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2084
2085 * xsettings.c: Use both GConf and GSettings if both are available.
2086 (store_config_changed_event): Add comment.
2087 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2088 (store_tool_bar_style_changed): New functions.
2089 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2090 (struct xsettings): Move font inside HAVE_XFT.
2091 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2092 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2093 Move inside HAVE_XFT.
640c8776 2094 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2095 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2096 also.
2097 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
2098 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2099 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2100 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2101 (parse_settings): Move check for font inside HAVE_XFT.
2102 (read_settings, apply_xft_settings): Add comment.
2103 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2104 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2105 call store_font_name_changed.
2106 (xft_settings_event): Add comment.
2107 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2108 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2109 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2110 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2111 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2112 (xsettings_get_system_font, xsettings_get_system_normal_font):
2113 Add comment.
869795d6 2114
d8ed26bd
PE
21152011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2116
2117 Random fixes. E.g., (random) never returned negative values.
2118 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2119 subseconds part to the entropy, as that's a bit more random.
2120 Prefer signed to unsigned, since the signedness doesn't matter and
2121 in general we prefer signed. When given a limit, use a
2122 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2123 latter isn't right if USE_2_TAGS_FOR_INTS.
2124 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2125 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2126
cabf1cac
SM
21272011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2128
2129 * textprop.c (text_property_stickiness):
2130 Obey Vtext_property_default_nonsticky.
2131 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2132 * w32fns.c (syms_of_w32fns):
2133 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2134
6e9b2be9
PE
21352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2138 This is more efficient than Ffile_directory_p and avoids a minor race.
2139
90186c68
LMI
21402011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2141
7c301272
LMI
2142 * buffer.c (Foverlay_put): Say what the return value is
2143 (bug#7835).
2144
c4f2d8d4
LMI
2145 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2146 is a directory before asking whether to use the file name
2147 (bug#7564).
ad637907
LMI
2148 (barf_or_query_if_file_exists): Make the "File is a directory"
2149 error be more correct.
c4f2d8d4 2150
90186c68
LMI
2151 * fns.c (Frequire): Remove the mention of the .gz files, since
2152 that's installation-specific, but keep the mention of
2153 `get-load-suffixes'.
2154
da64016e
PE
21552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2158 Report string overflow if the output is too long.
2159
7d47b580
JB
21602011-07-04 Juanma Barranquero <lekktu@gmail.com>
2161
a555cb87
JB
2162 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2163 (syms_of_gnutls): Remove duplicate DEFSYM for
2164 Qgnutls_bootprop_verify_hostname_error, an error for
2165 Qgnutls_bootprop_verify_error (which is no longer used).
2166
7d47b580
JB
2167 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2168 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2169 Also (re)move comments that are misplaced or no longer relevant.
2170
1e49bfab
LMI
21712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2172
2173 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2174
1485f4c0
CY
21752011-07-03 Chong Yidong <cyd@stupidchicken.com>
2176
2177 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2178 and background color parameters if they have been changed.
2179
a9ab721e
LMI
21802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2181
2182 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2183
cf7cff57
PE
21842011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2185
2e13213d
PE
2186 * xsettings.c (SYSTEM_FONT): Define only when used.
2187 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2188
cf7cff57
PE
2189 * keymap.c (access_keymap_1): Now static.
2190
7a8e04f7
CY
21912011-07-02 Chong Yidong <cyd@stupidchicken.com>
2192
2193 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2194 leave any prefix arg for the up event (Bug#1586).
2195
61352f62
LMI
21962011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2197
69bb1ef7
LMI
2198 * lread.c (syms_of_lread): Mention single symbols defined by
2199 `defvar' or `defconst' (bug#7154).
2200
61352f62 2201 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2202 (Frequire): Mention get-load-suffixes.
61352f62 2203
28545e04
MR
22042011-07-02 Martin Rudalics <rudalics@gmx.at>
2205
2206 * window.h (window): Remove clone_number slot.
2207 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2208 Remove.
2209 (make_parent_window, make_window, saved_window)
2210 (Fset_window_configuration, save_window_save): Don't deal with
2211 clone numbers.
2212 * buffer.c (Qclone_number): Remove declaration.
2213 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2214
3349e122
SM
22152011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2216
2217 Add multiple inheritance to keymaps.
2218 * keymap.c (Fmake_composed_keymap): New function.
2219 (Fset_keymap_parent): Simplify.
2220 (fix_submap_inheritance): Remove.
2221 (access_keymap_1): New function extracted from access_keymap to handle
2222 embedded parents and handle lists of maps.
2223 (access_keymap): Use it.
2224 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2225 (Fcopy_keymap): Handle embedded parents.
2226 (Fcommand_remapping, define_as_prefix): Simplify.
2227 (Fkey_binding): Simplify.
2228 (syms_of_keymap): Move minibuffer-local-completion-map,
2229 minibuffer-local-filename-completion-map,
2230 minibuffer-local-must-match-map, and
2231 minibuffer-local-filename-must-match-map to Elisp.
2232 (syms_of_keymap): Defsubr make-composed-keymap.
2233 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2234 (parse_menu_item): Trivial simplification.
2235
3279eb87
GM
22362011-07-01 Glenn Morris <rgm@gnu.org>
2237
2238 * Makefile.in (SETTINGS_LIBS): Fix typo.
2239
4550efdf
KI
22402011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2241
2242 * coding.c (Fencode_coding_string): Record the last coding system
2243 used, as the function doc string says (bug#8738).
2244
0949d2b6
JD
22452011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2246
2247 * xsettings.c (store_monospaced_changed): Take new font as arg and
2248 check for change against current_mono_font.
2249 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2250 (emacs_settings_constructor, emacs_settings_get_property)
2251 (emacs_settings_set_property, emacs_settings_class_init)
2252 (emacs_settings_init, gsettings_obj): Remove.
2253 (something_changedCB): New function for HAVE_GSETTINGS.
2254 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2255 with value as argument.
2256 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2257 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2258 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2259 "changed".
2260
2261 * xgselect.c: Add defined (HAVE_GSETTINGS).
2262 (xgselect_initialize): Ditto.
2263
2264 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2265 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2266 xg_select.
2267
bbc6b304
PE
22682011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2269
2270 * eval.c (struct backtrace): Simplify and port the data structure.
2271 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2272 signed bit field, as this assumption is not portable and it makes
2273 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2274 "char debug_on_exit : 1" as this is not portable either; instead,
2275 use the portable "unsigned int debug_on_exit : 1". Remove unused
2276 member evalargs. Remove obsolete comments about cc bombing out.
2277
9851bfc5
JD
22782011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2279
51bb811f 2280 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2281 Let HAVE_GSETTINGS override HAVE_GCONF.
2282 (store_monospaced_changed): New function.
2283 (EMACS_SETTINGS): A new type derived from GObject to handle
2284 GSettings notifications.
2285 (emacs_settings_constructor, emacs_settings_get_property)
2286 (emacs_settings_set_property, emacs_settings_class_init):
2287 New functions.
2288 (gsettings_client, gsettings_obj): New variables.
2289 (GSETTINGS_SCHEMA): New define.
2290 (something_changedCB): Call store_monospaced_changed.
2291 (init_gsettings): New function.
2292 (xsettings_initialize): Call init_gsettings.
2293 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2294 to NULL.
2295
640c8776 2296 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2297 GCONF_CFLAGS/LIBS.
2298
5386012d
MR
22992011-06-29 Martin Rudalics <rudalics@gmx.at>
2300
2301 * window.c (resize_root_window, grow_mini_window)
2302 (shrink_mini_window): Rename Qresize_root_window to
2303 Qwindow_resize_root_window and Qresize_root_window_vertically to
2304 Qwindow_resize_root_window_vertically.
2305
f13e0b08
PE
23062011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2307
2308 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2309
94515237
JB
23102011-06-27 Juanma Barranquero <lekktu@gmail.com>
2311
2312 * makefile.w32-in: Redesign dependencies so they reflect more
2313 clearly which files are directly included by each source file,
2314 and not through other includes.
2315
e43b6e43
MR
23162011-06-27 Martin Rudalics <rudalics@gmx.at>
2317
2318 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2319 (sort_overlays, overlay_strings): When an overlay's clone number
2320 matches the window's clone number process the overlay even if
2321 the overlay's window property doesn't match the current window.
2322
d68443dc
MR
2323 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2324 (Fwindow_hchild): Rename to Fwindow_left_child.
2325 (Fwindow_next): Rename to Fwindow_next_sibling.
2326 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2327 (resize_window_check): Rename to window_resize_check.
2328 (resize_window_apply): Rename to window_resize_apply.
2329 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2330 (Fdelete_other_windows_internal, resize_frame_windows)
2331 (Fsplit_window_internal, Fdelete_window_internal)
2332 (grow_mini_window, shrink_mini_window)
2333 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2334
c7e73be5
JD
23352011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2336
2337 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2338 (emacs_fixed_set_min_size): Remove.
2339 (emacs_fixed_new): Take frame as argument.
2340
2341 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2342 (_EmacsFixedPrivate): Remove minwidth/height.
2343 Add struct frame *f.
2344 (emacs_fixed_init): Initialize priv->f.
2345 (get_parent_class, emacs_fixed_set_min_size): Remove.
2346 (emacs_fixed_new): Set priv->f to argument.
2347 (emacs_fixed_get_preferred_width)
2348 (emacs_fixed_get_preferred_height): Use min_width/height from
2349 frames size_hint to set minimum and natural (Bug#8919).
2350 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2351 and use min_width/height from frames size_hint to set
2352 min_width/height (Bug#8919).
2353
2354 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2355 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2356 Fix indentation.
c7e73be5 2357
cf99dcf8
EZ
23582011-06-26 Eli Zaretskii <eliz@gnu.org>
2359
2360 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2361 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2362 called at ZV.
2363
029529ac
CY
23642011-06-26 Chong Yidong <cyd@stupidchicken.com>
2365
2366 * process.c (wait_reading_process_output): Bypass select if
2367 waiting for a cell while ignoring keyboard input, and input is
2368 pending. Suggested by Jan Djärv (Bug#8869).
2369
7a7ef429
PE
23702011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2371
2372 Use gnulib's dup2 module instead of rolling our own.
2373 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2374
11fdef7d 23752011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2376
2377 * dispnew.c (scrolling_window): Before scrolling, turn off a
2378 mouse-highlight in the window being scrolled.
2379
cd3520a4
JB
23802011-06-24 Juanma Barranquero <lekktu@gmail.com>
2381
2382 Move DEFSYM to lisp.h and use everywhere.
2383
2384 * character.h (DEFSYM): Move declaration...
2385 * lisp.h (DEFSYM): ...here.
2386
2387 * gnutls.c:
2388 * minibuf.c:
2389 * w32menu.c:
2390 * w32proc.c:
2391 * w32select.c: Don't include character.h.
2392
2393 * alloc.c (syms_of_alloc):
2394 * buffer.c (syms_of_buffer):
2395 * bytecode.c (syms_of_bytecode):
2396 * callint.c (syms_of_callint):
2397 * casefiddle.c (syms_of_casefiddle):
2398 * casetab.c (init_casetab_once):
2399 * category.c (init_category_once, syms_of_category):
2400 * ccl.c (syms_of_ccl):
2401 * cmds.c (syms_of_cmds):
2402 * composite.c (syms_of_composite):
2403 * dbusbind.c (syms_of_dbusbind):
2404 * dired.c (syms_of_dired):
2405 * dispnew.c (syms_of_display):
2406 * doc.c (syms_of_doc):
2407 * editfns.c (syms_of_editfns):
2408 * emacs.c (syms_of_emacs):
2409 * eval.c (syms_of_eval):
2410 * fileio.c (syms_of_fileio):
2411 * fns.c (syms_of_fns):
2412 * frame.c (syms_of_frame):
2413 * fringe.c (syms_of_fringe):
2414 * insdel.c (syms_of_insdel):
2415 * keymap.c (syms_of_keymap):
2416 * lread.c (init_obarray, syms_of_lread):
2417 * macros.c (syms_of_macros):
2418 * msdos.c (syms_of_msdos):
2419 * print.c (syms_of_print):
2420 * process.c (syms_of_process):
2421 * search.c (syms_of_search):
2422 * sound.c (syms_of_sound):
2423 * syntax.c (init_syntax_once, syms_of_syntax):
2424 * terminal.c (syms_of_terminal):
2425 * textprop.c (syms_of_textprop):
2426 * undo.c (syms_of_undo):
2427 * w32.c (globals_of_w32):
2428 * window.c (syms_of_window):
2429 * xdisp.c (syms_of_xdisp):
2430 * xfaces.c (syms_of_xfaces):
2431 * xfns.c (syms_of_xfns):
2432 * xmenu.c (syms_of_xmenu):
2433 * xsettings.c (syms_of_xsettings):
2434 * xterm.c (syms_of_xterm): Use DEFSYM.
2435
4228cf16
TZ
24362011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2437
cd3520a4 2438 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2439
7fcccf1e
PE
24402011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2441
7efb4e0e
PE
2442 Integer and buffer overflow fixes (Bug#8873).
2443
ff5844ad
PE
2444 * print.c (printchar, strout): Check for string overflow.
2445 (PRINTPREPARE, printchar, strout):
2446 Don't set size unless allocation succeeds.
2447
90532f02
PE
2448 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2449 for sizes. Check for string overflow more accurately.
2450 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2451
6d84508d
PE
2452 * macros.c: Integer and buffer overflow fixes.
2453 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2454 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2455 Use ptrdiff_t, not int, for sizes.
2456 Don't increment bufsize until after realloc succeeds.
2457 Check for size-calculation overflow.
2458 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2459
437b2cb4
PE
2460 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2461
8b9ac8b4
PE
2462 * lread.c: Integer overflow fixes.
2463 (read_integer): Radix is now EMACS_INT, not int,
2464 to improve quality of diagnostics for out-of-range radices.
2465 Calculate buffer size correctly for out-of-range radices.
2466 (read1): Check for integer overflow in radices, and in
2467 read-circle numbers.
82cb60d3
PE
2468 (read_escape): Avoid int overflow.
2469 (Fload, openp, read_buffer_size, read1)
2470 (substitute_object_recurse, read_vector, read_list, map_obarray):
2471 Use ptrdiff_t, not int, for sizes.
2472 (read1): Use EMACS_INT, not int, for sizes.
20270765 2473 Check for size overflow.
8b9ac8b4 2474
7fcccf1e
PE
2475 * image.c (cache_image): Check for size arithmetic overflow.
2476
bfbbd7e7
PE
2477 * lread.c: Integer overflow issues.
2478 (saved_doc_string_size, saved_doc_string_length)
2479 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2480 Now ptrdiff_t, not int.
2481 (read1): Don't assume doc string length fits in int. Check for
2482 out-of-range doc string lengths.
2483 (read_list): Don't assume file position fits in int.
39019e54 2484 (read_escape): Check for hex character overflow.
bfbbd7e7 2485
4e323265
LL
24862011-06-22 Leo Liu <sdl.web@gmail.com>
2487
2488 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2489 Move to minibuffer.el.
2490
85fece3e
PE
24912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2492
20b84ce9 2493 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2494 The following patches are for when GLYPH_DEBUG && !XASSERT.
2495 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2496 * dispnew.c (flush_stdout):
2497 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2498 Mark as externally visible.
2499 * dispnew.c (check_window_matrix_pointers): Now static.
2500 * dispnew.c (window_to_frame_vpos):
2501 * xfns.c (unwind_create_frame):
2502 * xterm.c (x_check_font): Remove unused local.
2503 * scroll.c (CHECK_BOUNDS):
2504 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2505 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2506 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2507 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2508 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2509 Now static.
2510 (debug_method_add): Use va_list and vsprintf rather than relying
2511 on undefined behavior with wrong number of arguments.
2512 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2513 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2514 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2515 since we're not interested in debugging glyphs with old libraries.
2516 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2517 GCC 4.6.0's static checking.
2518
0766b489
PE
25192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2520
31fd4b32
PE
2521 Integer overflow and signedness fixes (Bug#8873).
2522 A few related buffer overrun fixes, too.
2523
b79e8648
PE
2524 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2525
0766b489
PE
2526 * dispextern.h (struct face.stipple):
2527 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2528 (x_bitmap_mask, x_allocate_bitmap_record)
2529 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2530 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2531 (x_create_bitmap_from_xpm_data):
2532 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2533 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2534 (.bitmaps_last):
2535 * xfaces.c (load_pixmap):
2536 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2537 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2538 (.bitmaps_last, struct x_output.icon_bitmap):
2539 Use ptrdiff_t, not int, for bitmap indexes.
2540 (x_allocate_bitmap_record): Check for size overflow.
2541 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2542
b081724f
PE
2543 Use ptrdiff_t, not int, for overlay counts.
2544 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2545 * editfns.c (overlays_around, get_pos_property):
2546 * textprop.c (get_char_property_and_overlay):
2547 * xdisp.c (next_overlay_change, note_mouse_highlight):
2548 * xfaces.c (face_at_buffer_position):
21514da7
PE
2549 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2550 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2551 (Fnext_overlay_change, Fprevious_overlay_change)
2552 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2553 Use ptrdiff_t, not int, for sizes.
21514da7 2554 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2555
3de73e5e
PE
2556 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2557
2606c57b
PE
2558 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2559 (x_session_initialize): Do not assume string length fits in int.
2560
aaafe47a
PE
2561 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2562 This is unlikely, but can occur if DPI is outlandish.
2563
2674ddc8 2564 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2565 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2566
28154962
PE
2567 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2568 * xrdb.c (magic_file_p, search_magic_path):
2569 Omit last arg SUFFIX; it was always 0. All callers changed.
2570 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2571
7de51af5
PE
2572 * xfont.c (xfont_match): Avoid need for strlen.
2573
25ed6cc3
PE
2574 * xfns.c: Don't assume strlen fits in int.
2575 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2576
4eab31dd
PE
2577 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2578 not unsigned long, as we prefer signed integers. All callers changed.
2579 Detect integer overflow in repeat count.
2580 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2581 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2582
171e2a58
PE
2583 * termcap.c: Don't assume sizes fit in int and never overflow.
2584 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2585 (gobble_line): Check for size-calculation overflow.
2586
ad39faca 2587 * minibuf.c (Fread_buffer):
6e5bb2dc 2588 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2589 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2590 Don't assume string length fits in int.
2591
52c61c22 2592 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2593 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2594
b5b8c9e5
PE
2595 * font.c: Don't assume string length fits in int.
2596 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2597 Use ptrdiff_t, not int.
ccd6111c
PE
2598 (font_intern_prop): Don't assume string length fits in int.
2599 Don't assume integer property fits in fixnum.
2600 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2601
882f0d81 2602 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2603 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2604 Reformulate so as not to need the command string.
2605 Invoke gzip -cd rather than gunzip, as it's more portable.
2606 (lock_info_type, lock_file_1, lock_file):
2607 Don't assume pid_t and time_t fit in unsigned long.
2608 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2609 (current_lock_owner): Prefer signed type for sizes.
2610 Use memcpy, not strncpy, where memcpy is what is really wanted.
2611 Don't assume (via atoi) that time_t and pid_t fit in int.
2612 Check for time_t and/or pid_t out of range, e.g., via a network share.
2613 Don't alloca where an auto var works fine.
2614
93f4cf88
PE
2615 * fileio.c: Fix some integer overflow issues.
2616 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2617 Don't assume string length fits in int.
2618 (directory_file_name): Don't assume string length fits in long.
2619 (make_temp_name): Don't assume pid fits in int, or that its print
2620 length is less than 20.
2621
f3e92b69
PE
2622 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2623
1bfdaf10
PE
2624 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2625
35016e9a
PE
2626 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2627
3d1e65a1
PE
2628 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2629 We prefer signed integers, even for size calculations.
2630
0b963a93
PE
2631 * emacs.c: Don't assume string length fits in 'int'.
2632 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2633 (main): Don't invoke strlen when not needed.
2634
573f4b54
PE
2635 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2636 (XD_DEBUG_MESSAGE): Don't waste a byte.
2637
989f33ba
PE
2638 * callproc.c (getenv_internal_1, getenv_internal)
2639 (Fgetenv_internal):
965d34eb
PE
2640 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2641
e4d29b33
PE
2642 * lread.c (invalid_syntax): Omit length argument.
2643 All uses changed. This doesn't fix a bug, but it simplifies the
2644 code away from its former Hollerith-constant appearance, and it's
2645 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2646 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2647
eb49b136
PE
2648 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2649 This didn't break anything, but it didn't help either.
2650 It's confusing to put a bogus integer in a place where the actual
2651 value does not matter.
9f62aeb1 2652 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2653 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2654
15375a22
PE
2655 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2656 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2657 implementation.
b61cc01c
PE
2658 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2659 We prefer signed types, and the value cannot exceed the EMACS_INT
2660 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2661 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2662 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2663 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2664
53b2623d
PE
2665 * indent.c (sane_tab_width): New function.
2666 (current_column, scan_for_column, Findent_to, position_indentation)
2667 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2668 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2669
51cab52b 2670 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2671
f2ed8a70
PE
2672 * lisp.h (lint_assume): New macro.
2673 * composite.c (composition_gstring_put_cache):
2674 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2675
abe80cc6
PE
2676 * editfns.c, insdel.c:
2677 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2678
b02c740e
PE
2679 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2680
ebc96716
PE
2681 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2682
b4e50fa0 2683 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2684 Use much-faster test for byte-length change.
311d5d7c 2685 Don't assume string byte-length fits in 'int'.
a4cf38e4 2686 Check that character arg fits in 'int'.
85461888 2687 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2688
c0c1ee9f
PE
2689 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2690
a498d7f4
PE
2691 * fns.c (concat): Catch string overflow earlier.
2692 Do not rely on integer wraparound.
2693
51cab52b
PE
2694 * dispextern.h (struct it.overlay_strings_charpos)
2695 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2696 * xdisp.c (forward_to_next_line_start)
2697 (back_to_previous_visible_line_start)
2698 (reseat_at_next_visible_line_start, next_element_from_buffer):
2699 Don't arbitrarily truncate the value of 'selective' to int.
2700
76031fad
PE
2701 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2702
5eb55db9
PE
2703 * composite.c: Don't truncate sizes to 'int'.
2704 (composition_gstring_p, composition_reseat_it)
2705 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2706 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2707 not EMACS_UINT, for indexes.
5eb55db9 2708
0703a717
PE
2709 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2710
d6202519
PE
2711 * buffer.c: Include <verify.h>.
2712 (struct sortvec.priority, struct sortstr.priority):
8961a454 2713 Now EMACS_INT, not int.
c20998a7 2714 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2715 (struct sortstr.size, record_overlay_string)
2716 (struct sortstrlist.size, struct sortlist.used):
2717 Don't truncate size to int.
2718 (record_overlay_string): Check for size-calculation overflow.
d6202519 2719 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2720
d5a19415
JM
27212011-06-22 Jim Meyering <meyering@redhat.com>
2722
029529ac 2723 Don't leak an XBM-image-sized buffer
d5a19415
JM
2724 * image.c (xbm_load): Free the image buffer after using it.
2725
a9041e6c
PE
27262011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2727
2728 Port to Sun C.
2729 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2730 that Sun C diagnosed.
2731 * fns.c (secure_hash): Fix pointer signedness issue.
2732 * intervals.c (static_offset_intervals): New function.
2733 (offset_intervals): Use it.
2734
7f3f739f
LL
27352011-06-21 Leo Liu <sdl.web@gmail.com>
2736
2737 * deps.mk (fns.o):
2738 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2739 sha512.h.
2740
2741 * fns.c (secure_hash): Rename from crypto_hash_function and change
2742 the first arg to accept symbols.
5b66d427 2743 (Fsecure_hash): New primitive.
7f3f739f
LL
2744 (syms_of_fns): New symbols.
2745
76147d94
DD
27462011-06-20 Deniz Dogan <deniz@dogan.se>
2747
2748 * process.c (Fset_process_buffer): Clarify return value in
2749 docstring.
2750
7d7d0045
CY
27512011-06-18 Chong Yidong <cyd@stupidchicken.com>
2752
2753 * dispnew.c (add_window_display_history): Use BVAR.
2754
2755 * xdisp.c (debug_method_add): Use BVAR.
2756 (check_window_end, dump_glyph_matrix, dump_glyph)
2757 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2758
2759 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2760 Likewise.
2761
2762 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2763 check till after the cache is created in init_frame_faces.
2764
ff2bc410
SM
27652011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2766
2767 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2768
28177add
PE
27692011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2770
dd3482fe
PE
2771 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2772 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2773 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2774
393d71f3 2775 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2776 * fileio.c (Finsert_file_contents):
2777 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2778 Remove the old (too-loose) buffer overflow checks.
2779 They weren't needed, since make_gap checks for buffer overflow.
2780 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2781 The old code merely checked for Emacs fixnum overflow, and relied
2782 on undefined (wraparound) behavior. The new code avoids undefined
2783 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2784
2e6813b0 2785 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2786 Tune. Don't use wider integers than needed. Don't use alloca.
2787 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2788
599a9e4f
PE
2789 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2790
99561444
PE
2791 * insdel.c, lisp.h (buffer_overflow): New function.
2792 (insert_from_buffer_1, replace_range, replace_range_2):
2793 * insdel.c (make_gap_larger):
2794 * editfns.c (Finsert_char):
2795 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2796
28177add
PE
2797 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2798
e69dafad
PE
27992011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2800
a7af7fde 2801 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2802
b1c46f02
PE
2803 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2804 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2805
e69dafad
PE
2806 * fileio.c: Don't assume EMACS_INT fits in off_t.
2807 (emacs_lseek): New static function.
2808 (Finsert_file_contents, Fwrite_region): Use it.
2809 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2810
566684ea
PE
2811 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2812
e6966cd6
PE
2813 * fns.c: Don't overflow int when computing a list length.
2814 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2815 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2816 truncation on 64-bit hosts. Check for QUIT every
2817 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2818 faster and is responsive enough.
2819 (Flength): Report an error instead of overflowing an integer.
2820 (Fsafe_length): Return a float if the value is not representable
2821 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2822 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2823 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2824
dd0b0efb
PE
2825 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2826 (header_size, word_size): New constants.
2827 (allocate_vectorlike): Don't check size overflow here.
2828 (allocate_vector): Check it here instead, since this is the only
2829 caller of allocate_vectorlike that could cause overflow.
2830 Check that the new vector's length is representable as a fixnum.
2831
86fe5cfe
PE
2832 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2833 The previous code was bogus. For example, next_almost_prime (32)
2834 returned 39, which is undesirable as it is a multiple of 3; and
2835 next_almost_prime (24) returned 25, which is a multiple of 5 so
2836 why was the code bothering to check for multiples of 7?
2837
80e88859
PE
2838 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2839
4a2f0ad6
PE
2840 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2841
f66c7cf8
PE
2842 Variadic C functions now count arguments with ptrdiff_t.
2843 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2844 Back then I didn't know that the Emacs coding style prefers signed int.
2845 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2846 were being counted with int, which may truncate counts on 64-bit
2847 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2848 * lisp.h (struct Lisp_Subr.function.aMANY)
2849 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2850 Arg counts are now ptrdiff_t, not size_t.
2851 All variadic functions and their callers changed accordingly.
2852 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2853 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2854 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2855 * callint.c (Fcall_interactively): Check arg count for overflow,
2856 to avoid potential buffer overrun. Use signed char, not 'int',
2857 for 'varies' array, so that we needn't bother to check its size
2858 calculation for overflow.
2859 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2860 * eval.c (apply_lambda):
2861 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2862 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2863 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2864
a1759b76
PE
2865 * callint.c (Fcall_interactively): Don't use index var as event count.
2866
d96be9fc
PE
2867 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2868 * mem-limits.h (SIZE): Remove; no longer used.
2869
a690a978 2870 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2871
578c21e6
PE
2872 Remove unnecessary casts.
2873 * xterm.c (x_term_init):
2874 * xfns.c (x_set_border_pixel):
2875 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2876 These aren't needed now that we assume ANSI C.
2877
96f53c6c
PE
2878 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2879 It's more likely to cause problems (due to unsigned overflow)
2880 than to cure them.
2881
83c77d31
PE
2882 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2883
ee2079f1
PE
2884 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2885
6da65536
PE
2886 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2887
7147c4a4
PE
2888 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2889
193e32d9
PE
2890 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2891
e5533da6
PE
2892 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2893
9910e595
PE
2894 GLYPH_CODE_FACE returns EMACS_INT, not int.
2895 * dispextern.h (merge_faces):
2896 * xfaces.c (merge_faces):
01103c44
PE
2897 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2898 Don't assume EMACS_INT fits in int.
9910e595 2899
2638320e
PE
2900 * character.h (CHAR_VALID_P): Remove unused parameter.
2901 * fontset.c, lisp.h, xdisp.c: All uses changed.
2902
045eb8d9
PE
2903 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2904
c1f134b5
PE
2905 * fns.c (concat): Minor tuning based on overflow analysis.
2906 This doesn't fix any bugs. Use int to hold character, instead
2907 of constantly refetching from Emacs object. Use XFASTINT, not
2908 XINT, for value known to be a character. Don't bother comparing
2909 a single byte to 0400, as it's always less.
2910
395fcb93 2911 * floatfns.c (Fexpt):
327eeec8
PE
2912 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2913
abbd3d23
PE
2914 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2915 for characters.
2916
684a03ef
PE
2917 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2918
0fed43f3
PE
2919 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2920 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2921 incorrectly succeed when S was a string, because 4294967386 was
2922 truncated before it was used.
2923
8fd02eb7
PE
2924 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2925 Otherwise, an out-of-range integer could cause undefined behavior
2926 on a 64-bit host.
2927
f8c86b69
PE
2928 * composite.c: Use int, not EMACS_INT, for characters.
2929 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2930 EMACS_INT, for values that are known to be in character range.
2931 This doesn't fix any bugs but is the usual style inside Emacs and
2932 may generate better code on 32-bit machines.
2933
34206dd2
PE
2934 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2935 This is for reasons similar to the recent CHAR_STRING fix.
2936 * charset.c (Fencode_char): Check that character arg is actually
2937 a character. Pass an int to ENCODE_CHAR.
2938 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2939 wider than 'int', as a compile-time check to prevent future regressions
2940 in this area.
2941
c5958d4c 2942 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2943
2944 Make sure a 64-bit char is never passed to CHAR_STRING.
2945 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2946 by silently ignoring the top 32 bits, allowing some values
2947 that were far too large to be valid characters.
2948 * character.h: Include <verify.h>.
2949 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2950 arguments are no wider than unsigned, as a compile-time check
2951 to prevent future regressions in this area.
2952 * data.c (Faset):
01103c44 2953 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2954 (Fsubst_char_in_region):
2955 * fns.c (concat):
2956 * xdisp.c (decode_mode_spec_coding):
2957 Adjust to CHAR_STRING's new requirement.
2958 * editfns.c (Finsert_char, Fsubst_char_in_region):
2959 * fns.c (concat): Check that character args are actually
2960 characters. Without this test, these functions did the wrong
2961 thing with wildly out-of-range values on 64-bit hosts.
2962
d37ca623
PE
2963 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2964 These casts should not be needed on 32-bit hosts, either.
2965 * keyboard.c (read_char):
2966 * lread.c (Fload): Remove casts to unsigned.
2967
ea204efb
PE
2968 * lisp.h (UNSIGNED_CMP): New macro.
2969 This fixes comparison bugs on 64-bit hosts.
2970 (ASCII_CHAR_P): Use it.
2971 * casefiddle.c (casify_object):
01103c44 2972 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2973 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2974 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2975 * dispextern.h (FACE_FROM_ID):
2976 * keyboard.c (read_char): Use UNSIGNED_CMP.
2977
41cb286c
PE
2978 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2979 not to EMACS_INT, to avoid GCC warning.
2980
4a1b9832
PE
2981 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2982
55daad71
PE
2983 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2984 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2985 isn't needed on 32-bit machines.
8f95c75c 2986
01103c44
PE
2987 * buffer.c (Fgenerate_new_buffer_name):
2988 Use EMACS_INT for count, not int.
0ceccced 2989 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2990
2991 * data.c (Qcompiled_function): Now static.
2992
c6f072e7
PE
2993 * window.c (window_body_lines): Now static.
2994
20ce5912
PE
2995 * image.c (gif_load): Rename local to avoid shadowing.
2996
9c4c5f81
PE
2997 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2998 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2999 * alloc.c (make_save_value): Integer argument is now of type
3000 ptrdiff_t, not int.
3001 (mark_object): Use ptrdiff_t, not int.
3002 * lisp.h (pD): New macro.
3003 * print.c (print_object): Use it.
3004
c0c5c8ae
PE
3005 * alloc.c: Use EMACS_INT, not int, to count objects.
3006 (total_conses, total_markers, total_symbols, total_vector_size)
3007 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3008 (total_free_floats, total_floats, total_free_intervals)
3009 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3010 Now EMACS_INT, not int. All uses changed.
3011 (Fgarbage_collect): Compute overall total using a double, so that
3012 integer overflow is less likely to be a problem. Check for overflow
3013 when converting back to an integer.
5a25e253
PE
3014 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3015 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3016 These were 'int' variables that could overflow on 64-bit hosts;
3017 they were never used, so remove them instead of repairing them.
211a0b2a 3018 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3019 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3020 Previously, this ceilinged at INT_MAX, but that doesn't work on
3021 64-bit machines.
e46bb31a 3022 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3023
c78baabf 3024 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3025 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3026 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3027 when a (possibly-narrower) signed value would do just as well.
3028 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3029
c9d624c6
PE
3030 * alloc.c: Catch some string size overflows that we were missing.
3031 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3032 for convenience in STRING_BYTES_MAX.
3033 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3034 The definition here is exact; the one in lisp.h was approximate.
3035 (allocate_string_data): Check for string overflow. This catches
3036 some instances we weren't catching before. Also, it catches
3037 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3038 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3039 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3040
c9d624c6
PE
3041 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3042 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3043 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3044
353032ce
PE
3045 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3046
2bccce07
PE
3047 * alloc.c (Fmake_string): Check for out-of-range init.
3048
0ac30604
SM
30492011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3050
3051 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3052
c195f2de
JD
30532011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3054
3055 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3056 xg_get_default_scrollbar_width.
3057
3058 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3059 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3060 (style_changed_cb): Call update_theme_scrollbar_width and call
3061 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3062 all frames (Bug#8505).
3063 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3064 Call gtk_window_set_resizable if HAVE_GTK3.
3065 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3066 and height if HAVE_GTK3 (Bug#8505).
3067 (scroll_bar_width_for_theme): New variable.
3068 (update_theme_scrollbar_width): New function.
3069 (xg_get_default_scrollbar_width): Move code to
3070 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3071 (xg_initialize): Call update_theme_scrollbar_width.
3072
3073 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3074
3075 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3076
e10ac9f1
MR
30772011-06-12 Martin Rudalics <rudalics@gmx.at>
3078
3079 * frame.c (make_frame): Call other_buffer_safely instead of
3080 other_buffer.
3081
3082 * window.c (temp_output_buffer_show): Call display_buffer with
3083 second argument Vtemp_buffer_show_specifiers and reset latter
3084 immediately after the call.
3085 (Vtemp_buffer_show_specifiers): New variable.
3086 (auto_window_vscroll_p, next_screen_context_lines)
3087 (Vscroll_preserve_screen_position): Remove leading asterisks from
3088 doc-strings.
3089
2d3c217e 30902011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3091
7b7f97e8 3092 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3093 * buffer.c (Qclone_number): Remove for now, as it's unused.
3094 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3095 (record_buffer): Remove unused local.
3096 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3097 (set_frame_buffer_list): Remove; unused.
3098 * frame.h (other_visible_frames): Remove decl.
3099 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3100 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3101 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3102 if HAVE_GPM.
3103 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3104 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3105 Define only if HAVE_GPM.
3106 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3107 (update_hints_inhibit): Remove; never set. All uses removed.
3108 * widgetprv.h (emacsFrameClassRec): Remove decl.
3109 * window.c (delete_deletable_window): Now returns void, since it
3110 wasn't returning anything.
3111 (compare_window_configurations): Remove unused locals.
3112 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3113 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3114 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3115 the same widths as pointers. This follows up on the 2011-05-06 patch.
3116 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3117 * xterm.h: Likewise.
3118 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3119
1384b89e
JB
31202011-06-12 Juanma Barranquero <lekktu@gmail.com>
3121
3122 * makefile.w32-in: Update dependencies.
3123 (LISP_H): Add lib/intprops.h.
3124
1100a63c
CY
31252011-06-11 Chong Yidong <cyd@stupidchicken.com>
3126
3127 * image.c (gif_load): Add animation frame delay to the metadata.
3128 (syms_of_image): Use DEFSYM. New symbol `delay'.
3129
6198ccd0
MR
31302011-06-11 Martin Rudalics <rudalics@gmx.at>
3131
3132 * window.c (delete_deletable_window): Re-add.
3133 (Fset_window_configuration): Rewrite to handle dead buffers and
3134 consequently deletable windows.
3135 (window_tree, Fwindow_tree): Remove. Supply functionality in
3136 window.el.
3137 (compare_window_configurations): Simplify code.
3138
b6e3633c
AS
31392011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3140
1ab0dee5
AS
3141 * image.c (imagemagick_load_image): Fix type mismatch.
3142 (Fimagemagick_types): Likewise.
3143
b6e3633c
AS
3144 * window.h (replace_buffer_in_windows): Declare.
3145
9397e56f
MR
31462011-06-11 Martin Rudalics <rudalics@gmx.at>
3147
3148 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3149 Qclone_number. Remove external declaration of Qdelete_window.
3150 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3151 code.
640c8776
SM
3152 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3153 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3154 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3155 buffer list implementation.
3156 (other_buffer_safely): New function.
3157 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3158 calls to replace_buffer_in_windows and
3159 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3160 if allowed.
3161 (record_buffer): Inhibit quitting and rewrite using quittable
3162 functions. Run Qbuffer_list_update_hook if allowed.
3163 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3164 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3165 Move switch-to-buffer to window.el.
9397e56f
MR
3166 (bury-buffer): Move to window.el.
3167 (Vbuffer_list_update_hook): New variable.
3168
3169 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3170 section.
3171
3172 * window.h (resize_frame_windows): Move up in code.
3173 (Fwindow_frame): Remove EXFUN.
3174 (replace_buffer_in_all_windows): Remove prototype.
3175 (replace_buffer_in_windows_safely): Add prototype.
3176
3177 * window.c: Declare Qdelete_window static again. Move down
3178 declaration of select_count.
3179 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3180 (Fother_window): Move to window.el.
3181 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3182 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3183 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3184 window.el.
3185 (replace_buffer_in_windows): Implement by calling
3186 Qreplace_buffer_in_windows.
3187 (replace_buffer_in_all_windows): Remove with some functionality
3188 moved into replace_buffer_in_windows_safely.
3189 (replace_buffer_in_windows_safely): New function.
3190 (select_window_norecord, select_frame_norecord): Move in front
3191 of run_window_configuration_change_hook. Remove now obsolete
3192 declarations.
640c8776
SM
3193 (Fset_window_buffer): Rewrite doc-string.
3194 Call Qrecord_window_buffer.
9397e56f
MR
3195 (keys_of_window): Move binding for other-window to window.el.
3196
b50691aa
CY
31972011-06-11 Chong Yidong <cyd@stupidchicken.com>
3198
3199 * dispextern.h (struct image): Replace data member, whose int_val
3200 and ptr_val fields were not used by anything, with a single
3201 lisp_val object.
3202
3203 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3204 (gif_clear_image, gif_load, imagemagick_load_image)
3205 (gs_clear_image, gs_load): Callers changed.
3206
3f754b86
PE
32072011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3208
cca69397
PE
3209 * buffer.h: Include <time.h>, for time_t.
3210 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3211
109e28d0
PE
3212 Fix minor problems found by static checking.
3213
60737f02
PE
3214 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3215
4b66faf3
PE
3216 Make identifiers static if they are not used in other modules.
3217 * data.c (Qcompiled_function, Qframe, Qvector):
3218 * image.c (QimageMagick, Qsvg):
3219 * minibuf.c (Qmetadata):
3220 * window.c (resize_window_check, resize_root_window): Now static.
3221 * window.h (resize_window_check, resize_root_window): Remove decls.
3222
109e28d0
PE
3223 * window.c (window_deletion_count, delete_deletable_window):
3224 Remove; unused.
46a4ce9e
PE
3225 (window_body_lines): Now static.
3226 (Fdelete_other_windows_internal): Mark vars as initialized.
3227 Make sure 'resize_failed' is initialized.
3228 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3229 (resize_window_apply): Remove unused local.
3230 * window.h (delete_deletable_window): Remove decl.
3231
109e28d0 3232 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3233 (imagemagick_load_image): Fix pointer signedness problem by changing
3234 last arg from unsigned char * to char *. All uses changed.
3235 Also, fix a local for similar reasons.
3236 Remove unused locals. Remove locals to avoid shadowing.
3237 (fn_rsvg_handle_free): Remove; unused.
3238 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3239 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3240
3f754b86
PE
3241 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3242
2547adb1
CY
32432011-06-10 Chong Yidong <cyd@stupidchicken.com>
3244
3245 * image.c (gif_load): Fix omitted cast error introduced by
3246 2011-06-06 change.
3247
2c8e37d4
MR
32482011-06-10 Martin Rudalics <rudalics@gmx.at>
3249
3250 * window.h (resize_proportionally, orig_total_lines)
3251 (orig_top_line): Remove from window structure.
3252 (set_window_height, set_window_width, change_window_heights)
3253 (Fdelete_window): Remove prototypes.
3254 (resize_frame_windows): Remove duplicate declaration.
3255
440a42e3
EZ
32562011-06-10 Eli Zaretskii <eliz@gnu.org>
3257
3258 * window.h (resize_frame_windows, resize_window_check)
3259 (delete_deletable_window, resize_root_window)
3260 (resize_frame_windows): Declare prototypes.
3261
3262 * window.c (resize_window_apply): Make definition be "static" to
3263 match the prototype.
3264
562dd5e9
MR
32652011-06-10 Martin Rudalics <rudalics@gmx.at>
3266
3267 * window.c: Remove declarations of Qwindow_size_fixed,
3268 window_min_size_1, window_min_size_2, window_min_size,
3269 size_window, window_fixed_size_p, enlarge_window, delete_window.
3270 Remove static from declaration of Qdelete_window, it's
3271 temporarily needed by Fbury_buffer.
3272 (replace_window): Don't assign orig_top_line and
3273 orig_total_lines.
3274 (Fdelete_window, delete_window): Remove. Window deletion is
3275 handled by window.el.
640c8776
SM
3276 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3277 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3278 (Fdelete_other_windows): Remove. Deleting other windows is
3279 handled by window.el.
3280 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3281 handled in window.el.
3282 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3283 Window minimum sizes are handled in window.el.
3284 (shrink_windows, size_window, set_window_height)
3285 (set_window_width, change_window_heights, window_height)
3286 (window_width, CURBEG, CURSIZE, enlarge_window)
3287 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3288 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3289 handled in window.el.
3290 (make_dummy_parent): Rename to make_parent_window and give it a
3291 second argument horflag.
3292 (make_window): Don't set resize_proportionally any more.
3293 (Fsplit_window): Remove. Windows are split in window.el.
3294 (save_restore_action, save_restore_orig_size)
3295 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3296 Resize mini windows in window.el.
3297 (grow_mini_window, shrink_mini_window): Implement by calling
3298 Qresize_root_window_vertically, resize_window_check and
3299 resize_window_apply.
640c8776
SM
3300 (saved_window, Fset_window_configuration, save_window_save):
3301 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3302 resize_proportionally.
3303 (window_min_height, window_min_width): Move to window.el.
3304 (keys_of_window): Move bindings for delete-other-windows,
3305 split-window, delete-window and enlarge-window to window.el.
3306
3307 * buffer.c: Temporarily extern Qdelete_window.
3308 (Fbury_buffer): Temporarily call Qdelete_window instead of
3309 Fdelete_window (Fbury_buffer will move to window.el soon).
3310
3311 * frame.c (set_menu_bar_lines_1): Remove code handling
3312 orig_top_line and orig_total_lines.
3313
3314 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3315 set_window_height but set heights directly.
3316 (change_frame_size_1): Use resize_frame_windows.
3317
3318 * xdisp.c (init_xdisp): Don't use set_window_height but set
3319 heights directly.
3320
640c8776
SM
3321 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3322 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3323 run_window_configuration_change_hook.
3324
3325 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3326 instead of change_window_heights and run
3327 run_window_configuration_change_hook.
3328
1a13852e
MR
33292011-06-09 Martin Rudalics <rudalics@gmx.at>
3330
3331 * window.c (replace_window): Rename second argument REPLACEMENT to
3332 NEW. New third argument SETFLAG. Rewrite.
3333 (delete_window, make_dummy_parent): Call replace_window with
3334 third argument 1.
3335 (window_list_1): Move down in code.
3336 (run_window_configuration_change_hook): Move set_buffer part
3337 before select_frame_norecord part in order to unwind correctly.
3338 Rename count1 to count.
3339 (recombine_windows, delete_deletable_window, resize_root_window)
3340 (Fdelete_other_windows_internal)
3341 (Frun_window_configuration_change_hook, make_parent_window)
3342 (resize_window_check, resize_window_apply, Fresize_window_apply)
3343 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3344 (Fdelete_window_internal, Fresize_mini_window_internal):
3345 New functions.
1a13852e
MR
3346 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3347
f3d1777e
MR
33482011-06-08 Martin Rudalics <rudalics@gmx.at>
3349
496e208e
MR
3350 * window.h (window): Add some new members to window structure -
3351 normal_lines, normal_cols, new_total, new_normal, clone_number,
3352 splits, nest, prev_buffers, next_buffers.
3353 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3354 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3355
f3d1777e
MR
3356 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3357 Remove.
496e208e
MR
3358 (make_dummy_parent): Set new members of windows structure.
3359 (make_window): Move down in code. Handle new members of window
3360 structure.
3361 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3362 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3363 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3364 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3365 (Fset_window_next_buffers, Fset_window_clone_number):
3366 New functions.
496e208e
MR
3367 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3368 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3369 Doc-string fixes.
3370 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3371 Argument WINDOW can be now internal window too.
3372 (Fwindow_use_time): Move up in code.
3373 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3374 Rewrite doc-string.
3375 (Fset_window_configuration, saved_window)
3376 (Fcurrent_window_configuration, save_window_save): Handle new
3377 members of window structure.
b9e809c2
MR
3378 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3379 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3380 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3381 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3382 Qget_mru_window, Qresize_root_window,
3383 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3384 Qauto_buffer_name; staticpro them.
f3d1777e 3385
abde8f8c
MR
33862011-06-07 Martin Rudalics <rudalics@gmx.at>
3387
3388 * window.c (Fwindow_total_size, Fwindow_left_column)
3389 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3390 (Fwindow_list_1): New functions.
3391 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3392 (Fwindow_width, Fscroll_left, Fscroll_right):
3393 Use window_body_cols instead of window_box_text_cols.
3394 (delete_window, Fset_window_configuration):
3395 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3396 (delete_all_subwindows): Take a window as argument and not a
3397 structure. Rewrite.
190b47e6
MR
3398 (window_loop): Remove handling of GET_LRU_WINDOW and
3399 GET_LARGEST_WINDOW.
3400 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3401
3402 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3403 window_box_text_cols. delete_all_subwindows now takes a
3404 Lisp_Object as argument.
abde8f8c 3405
640c8776
SM
3406 * indent.c (compute_motion, Fcompute_motion):
3407 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3408
fa8a67e6
MR
3409 * frame.c (delete_frame): Call delete_all_subwindows with root
3410 window as argument.
3411
a54e3482
DC
34122011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3413
3414 * fns.c (Fputhash): Document return value.
3415
60002bf5
CY
34162011-06-06 Chong Yidong <cyd@stupidchicken.com>
3417
3418 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3419
0c671da6 34202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3421
b862a52a 3422 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3423
be44ca6c
PE
3424 Check for overflow when converting integer to cons and back.
3425 * charset.c (Fdefine_charset_internal, Fdecode_char):
3426 Use cons_to_unsigned to catch overflow.
3427 (Fencode_char): Use INTEGER_TO_CONS.
3428 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3429 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3430 * data.c (long_to_cons, cons_to_long): Remove.
3431 (cons_to_unsigned, cons_to_signed): New functions.
3432 These signal an error for invalid or out-of-range values.
3433 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3434 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3435 * font.c (Ffont_variation_glyphs):
3436 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3437 * lisp.h: Include <intprops.h>.
3438 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3439 (cons_to_signed, cons_to_unsigned): New decls.
3440 (long_to_cons, cons_to_long): Remove decls.
3441 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3442 (Fprimitive_undo): Use CONS_TO_INTEGER.
3443 * xfns.c (Fx_window_property): Likewise.
3444 * xselect.c: Include <limits.h>.
3445 (x_own_selection, selection_data_to_lisp_data):
3446 Use INTEGER_TO_CONS.
3447 (x_handle_selection_request, x_handle_selection_clear)
3448 (x_get_foreign_selection, Fx_disown_selection_internal)
3449 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3450 (lisp_data_to_selection_data): Use cons_to_unsigned.
3451 (x_fill_property_data): Use cons_to_signed.
3452 Report values out of range.
3453
d1f3d2af
PE
3454 Check for buffer and string overflow more precisely.
3455 * buffer.h (BUF_BYTES_MAX): New macro.
3456 * lisp.h (STRING_BYTES_MAX): New macro.
3457 * alloc.c (Fmake_string):
3458 * character.c (string_escape_byte8):
3459 * coding.c (coding_alloc_by_realloc):
3460 * doprnt.c (doprnt):
3461 * editfns.c (Fformat):
3462 * eval.c (verror):
3463 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3464 since they may not be the same number.
3465 * editfns.c (Finsert_char):
3466 * fileio.c (Finsert_file_contents):
3467 Likewise for BUF_BYTES_MAX.
3468
dd52fcea
PE
3469 * image.c: Use ptrdiff_t, not int, for sizes.
3470 (slurp_file): Switch from int to ptrdiff_t.
3471 All uses changed.
3472 (slurp_file): Check that file size fits in both size_t (for
3473 malloc) and ptrdiff_t (for sanity and safety).
3474
7f9bbdbb
PE
3475 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3476 if b->modtime has its maximal value.
3477
dfe18f82
PE
3478 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3479
84acfcf0
PE
3480 Don't assume time_t can fit into int.
3481 * buffer.h (struct buffer.modtime): Now time_t, not int.
3482 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3483 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3484
ccd9a01a
PE
3485 Minor fixes for signed vs unsigned integers.
3486 * character.h (MAYBE_UNIFY_CHAR):
3487 * charset.c (maybe_unify_char):
3488 * keyboard.c (read_char, reorder_modifiers):
3489 XINT -> XFASTINT, since the integer must be nonnegative.
3490 * ftfont.c (ftfont_spec_pattern):
3491 * keymap.c (access_keymap, silly_event_symbol_error):
3492 XUINT -> XFASTINT, since the integer must be nonnegative.
3493 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3494 since it makes no difference and we prefer signed.
3495 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3496 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3497 nonnegative.
3498
d6d100dd
SM
34992011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3500
3501 * window.h (Fwindow_frame): Declare.
3502
2b6148e4
PE
35032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3504
3505 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3506 (SPARE_MEMORY): Always define.
3507 (LARGE_REQUEST): Remove.
3508 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3509
f230ecc9
MR
35102011-06-06 Martin Rudalics <rudalics@gmx.at>
3511
727e958e
MR
3512 * lisp.h: Move EXFUNS for Fframe_root_window,
3513 Fframe_first_window and Fset_frame_selected_window to window.h.
3514
3515 * window.h: Move EXFUNS for Fframe_root_window,
3516 Fframe_first_window and Fset_frame_selected_window here from
3517 lisp.h.
3518
3519 * frame.c (Fwindow_frame, Fframe_first_window)
3520 (Fframe_root_window, Fframe_selected_window)
3521 (Fset_frame_selected_window): Move to window.c.
3522 (Factive_minibuffer_window): Move to minibuf.c.
3523 (Fother_visible_frames_p): New function.
3524
3525 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3526
f230ecc9
MR
3527 * window.c (decode_window, decode_any_window): Move up in code.
3528 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3529 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3530 (Fwindow_buffer): Move up and rewrite doc-string.
3531 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3532 (Fwindow_prev): New functions.
727e958e
MR
3533 (Fwindow_frame): Move here from frame.c. Accept any window as
3534 argument.
3535 (Fframe_root_window, Fframe_first_window)
3536 (Fframe_selected_window): Move here from frame.c. Accept frame
3537 or arbitrary window as argument. Update doc-strings.
3538 (Fminibuffer_window): Move up in code.
3539 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3540 (Fset_frame_selected_window): Move here from frame.c.
3541 Marginal rewrite.
727e958e
MR
3542 (Fselected_window, select_window, Fselect_window): Move up in
3543 code. Minor doc-string fixes.
f230ecc9 3544
4d09bcf6
PE
35452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3548 Do not assume that spare memory exists; that assumption is valid
3549 only if SYSTEM_MALLOC.
3550 (LARGE_REQUEST): New macro, so that the issue of large requests
3551 is separated from the issue of spare memory.
3552
810928a2
AS
35532011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3554
172418ad
AS
3555 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3556 format. (Bug#8806)
3557
43f862f7
AS
3558 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3559
810928a2
AS
3560 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3561 before statements.
3562
a059fe24
JD
35632011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3564
3565 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3566
3567 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3568
3569 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3570 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3571
989bf368
JB
35722011-06-05 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3575
4b80f674
CY
35762011-06-04 Chong Yidong <cyd@stupidchicken.com>
3577
3578 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3579 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3580 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3581 New error handlers.
4b80f674
CY
3582 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3583 Obey Vx_select_enable_clipboard_manager. Catch errors in
3584 x_clipboard_manager_save (Bug#8779).
3585 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3586 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3587
99a33b77 35882011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3589
3590 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3591
99a33b77 35922011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3593
3594 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3595 in the current matrix if keep_current_p is non-zero.
3596
8264569d
EZ
35972011-06-04 Eli Zaretskii <eliz@gnu.org>
3598
3599 * bidi.c (bidi_level_of_next_char): Fix last change.
3600
57f97249
EZ
36012011-06-03 Eli Zaretskii <eliz@gnu.org>
3602
fec2107c 3603 Support bidi reordering of text covered by display properties.
57f97249 3604
fec2107c
EZ
3605 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3606 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3607 (bidi_cache_search, bidi_cache_iterator_state)
3608 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3609 (bidi_level_of_next_char, bidi_move_to_visually_next):
3610 Support character positions inside a run of characters covered by a
fec2107c
EZ
3611 display string.
3612 (bidi_paragraph_init, bidi_resolve_explicit_1)
3613 (bidi_level_of_next_char): Call bidi_fetch_char and
3614 bidi_fetch_char_advance instead of FETCH_CHAR and
3615 FETCH_CHAR_ADVANCE.
3616 (bidi_init_it): Initialize new members.
3617 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3618 definitions.
3619 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3620 instead of using explicit *_CHAR codes.
d6d100dd
SM
3621 (bidi_resolve_explicit, bidi_resolve_weak):
3622 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3623 bidirectional text is supported only in multibyte buffers.
3624 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3625 it to initialize the frame_window_p member of struct bidi_it.
3626 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3627 (bidi_resolve_explicit, bidi_resolve_weak)
3628 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3629 bidi_it->nchars is non-positive.
3630 (bidi_level_of_next_char): Don't try to lookup the cache for the
3631 next/previous character if nothing is cached there yet, or if we
3632 were just reseat()'ed to a new position.
c40e2fb2 3633
0e14fe90
EZ
3634 * xdisp.c (set_cursor_from_row): Set start and stop points
3635 according to the row's direction when priming the loop that looks
3636 for the glyph on which to display cursor.
3637 (single_display_spec_intangible_p): Function deleted.
3638 (display_prop_intangible_p): Reimplement to call
3639 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3640 Accept 3 additional arguments needed by handle_display_spec.
3641 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3642 values: lists, `(when COND...)' forms, etc.
3643 (single_display_spec_string_p): Support property values that are
3644 lists with the argument STRING its top-level element.
3645 (display_prop_string_p): Fix the condition for processing a
3646 property that is a list to be consistent with handle_display_spec.
fec2107c 3647 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3648 last portion of handle_display_prop.
3649 (compute_display_string_pos): Accept additional argument
3650 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3651 value of a `display' property is a "replacing spec".
3652 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3653 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3654 the display property, but just return a value indicating whether
3655 the display property will replace the characters it covers.
3656 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3657 frame_window_p members of struct bidi_it.
d6d100dd
SM
3658 (compute_display_string_pos, compute_display_string_end):
3659 New functions.
fec2107c
EZ
3660 (push_it): Accept second argument POSITION, where pop_it should
3661 jump to continue iteration.
3662 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3663
fec2107c
EZ
3664 * keyboard.c (adjust_point_for_property): Adjust the call to
3665 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3666
3667 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3668 (bidi_init_it): Update prototypes.
3669 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3670 (compute_display_string_pos, compute_display_string_end):
3671 Declare prototypes.
fec2107c
EZ
3672 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3673 EMACS_INT.
fc6f18ce 3674
40087514 36752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3676
57f53182
PE
3677 Malloc failure behavior now depends on size of allocation.
3678 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3679 * lisp.h: Change signatures accordingly.
3680 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3681 All callers changed. (Bug#8762)
3682
3683 * gnutls.c: Use Emacs's memory allocators.
3684 Without this change, the gnutls library would invoke malloc etc.
3685 directly, which causes problems on non-SYNC_INPUT hosts, and which
3686 runs afoul of improving memory_full behavior. (Bug#8761)
3687 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3688 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3689 xfree instead of the default malloc, realloc, free.
3690 (Fgnutls_boot): No need to check for memory allocation failure,
3691 since xmalloc does that for us.
3692
ac32cd99 3693 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3694 * category.c (hash_get_category_set):
3695 * ccl.c (ccl_driver):
3696 * charset.c (Fdefine_charset_internal):
3697 * charset.h (struct charset.hash_index):
3698 * composite.c (get_composition_id, gstring_lookup_cache)
3699 (composition_gstring_put_cache):
3700 * composite.h (struct composition.hash_index):
3701 * dispextern.h (struct image.hash):
3702 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3703 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3704 (hashfn_equal, hashfn_user_defined, make_hash_table)
3705 (maybe_resize_hash_table, hash_lookup, hash_put)
3706 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3707 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3708 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3709 * image.c (make_image, search_image_cache, lookup_image)
3710 (xpm_put_color_table_h):
3711 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3712 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3713 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3714 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3715 * alloc.c (allocate_vectorlike):
3716 Check for overflow in vector size calculations.
3717 * ccl.c (ccl_driver):
3718 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3719 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3720 need to be updated by these changes.
40087514
PE
3721 * fns.c (make_hash_table, maybe_resize_hash_table):
3722 Check for integer overflow with large hash tables.
0de4bb68
PE
3723 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3724 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3725 (SXHASH_REDUCE): New macro.
3726 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3727 Use it instead of discarding useful hash info with large hash values.
3728 (sxhash_float): New function.
3729 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3730 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3731 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3732 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3733 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3734 Adjust signatures to match updated version of code.
3735 (consing_since_gc): Now EMACS_INT, since a single hash table can
3736 use more than INT_MAX bytes.
3737
698d32e2
DN
37382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3739
3740 Make it possible to build with GCC-4.6+ -O2 -flto.
3741
3742 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3743
fd6fa53f
SM
37442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3745
3746 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3747 Call minibuffer-inactive-mode.
3748
864db017
JB
37492011-05-31 Juanma Barranquero <lekktu@gmail.com>
3750
3751 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3752 Update dependencies.
3753
2ad0baf4
DN
37542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3755
3756 * data.c (init_data): Remove code for UTS, this system is not
3757 supported anymore.
3758
4fcc2638
DN
37592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3760
3761 Don't force ./temacs to start in terminal mode.
3762
3763 * frame.c (make_initial_frame): Initialize faces in all cases, not
3764 only when CANNOT_DUMP is defined.
3765 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3766
c56e0fd5
DN
37672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3768
3769 * dispnew.c (add_window_display_history): Use const for the string
3770 pointer. Remove declaration, not needed.
3771
333d54da 37722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3773
55d4c1b2 3774 Use 'inline', not 'INLINE'.
333d54da 3775 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3776 * alloc.c, fontset.c (INLINE): Remove.
3777 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3778 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3779 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3780 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3781 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3782
738db178
DN
37832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3784
3785 Make it possible to run ./temacs.
3786
3787 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3788 syms_of_callproc does the same thing. Remove test for
3789 "initialized", do it in the caller.
3790 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3791
620c53a6
SM
37922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3793
3794 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3795 (read_minibuf): Use get_minibuffer.
3796 (syms_of_minibuf): Use DEFSYM.
3797 (Qmetadata): New var.
3798 * data.c (Qbuffer): Don't make it static.
3799 (syms_of_data): Use DEFSYM.
3800
e003a292
PE
38012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3802
3803 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3804 (CCL_CODE_MIN): New macro.
3805
ed008a6d
PE
38062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3807
3687c2ef
PE
3808 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3809
ed008a6d
PE
3810 * eval.c (Qdebug): Now static.
3811 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3812 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3813 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3814
d66c4c7c
CY
38152011-05-29 Chong Yidong <cyd@stupidchicken.com>
3816
3817 * image.c: Various fixes to ImageMagick code comments.
3818 (Fimagemagick_types): Doc fix.
3819
5fbc2025
PE
38202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3821
0196f88a
PE
3822 Minor fixes prompted by GCC 4.6.0 warnings.
3823
3824 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3825
5fbc2025
PE
3826 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3827 (x_clipboard_manager_save_all): Move extern decl to ...
3828 * xterm.h: ... here, so that it can be checked for consistency.
3829
1dd3c2d9
CY
38302011-05-29 Chong Yidong <cyd@stupidchicken.com>
3831
3832 * xselect.c (x_clipboard_manager_save_frame)
3833 (x_clipboard_manager_save_all): New functions.
3834 (Fx_clipboard_manager_save): Lisp function deleted.
3835
3836 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3837 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3838
3839 * xterm.h: Update prototype.
3840
5ba6571d
WX
38412011-05-28 William Xu <william.xwl@gmail.com>
3842
3843 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3844 exiting (Bug#8239).
3845
3eaff834
JM
38462011-05-28 Jim Meyering <meyering@redhat.com>
3847
e1900994 3848 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3849 * fns.c (to_uchar): Define.
3850 (crypto_hash_function): Use it to convert some newly-signed
3851 variables to unsigned, to avoid sign-extension bugs. For example,
3852 without this change, (md5 "truc") would evaluate to
3853 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3854 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3855 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3856
0f6990a7
PE
38572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3858
3859 Integer overflow fixes.
c8a9ca5a 3860
08686060
PE
3861 * dbusbind.c: Serial number integer overflow fixes.
3862 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3863 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3864 to hold a serial number that is too large for a fixnum.
3865 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3866 Check for serial numbers out of range. Decode any serial number
59568bf0 3867 that was so large that it became a float. (Bug#8722)
08686060 3868
2d1fc3c7
PE
3869 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3870 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3871 Use XFASTINT rather than XUINT when numbers are nonnegative.
3872 (xd_append_arg, Fdbus_method_return_internal):
3873 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3874 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3875 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3876 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3877 (Bug#8722)
2d1fc3c7 3878
c8a9ca5a
PE
3879 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3880
519e1d69
PE
3881 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3882
30569699
PE
3883 ccl: add integer overflow checks
3884 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3885 (IN_INT_RANGE): New macros.
3886 (ccl_driver): Use them to check for integer overflow when
3887 decoding a CCL program. Many of the new checks are whether XINT (x)
3888 fits in int; it doesn't always, on 64-bit hosts. The new version
3889 doesn't catch all possible integer overflows, but it's an
847044ea 3890 improvement. (Bug#8719)
30569699 3891
c11285dc
PE
3892 * alloc.c (make_event_array): Use XINT, not XUINT.
3893 There's no need for unsigned here.
3894
fdccd48e
PE
3895 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3896 This follows up to the 2011-05-06 change that substituted uintptr_t
3897 for EMACS_INT. This case wasn't caught back then.
3898
37910ab2
PE
3899 Rework Fformat to avoid integer overflow issues.
3900 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3901 now (part of C89). Include <verify.h>.
3902 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3903 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3904 (Fformat): Avoid the prepass trying to compute sizes; it was only
3905 approximate and thus did not catch overflow reliably. Instead, walk
3906 through the format just once, formatting and computing sizes as we go,
3907 checking for integer overflow at every step, and allocating a larger
3908 buffer as needed. Keep track separately whether the format is
3909 multibyte. Keep only the most-recently calculated precision, rather
3910 than them all. Record whether each argument has been converted to
3911 string. Use EMACS_INT, not int, for byte and char and arg counts.
3912 Support field widths and precisions larger than INT_MAX. Avoid
3913 sprintf's undefined behavior with conversion specifications such as %#d
3914 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3915 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3916 formatting out-of-range floating point numbers with int
9173deec 3917 formats. (Bug#8668)
37910ab2 3918
2e6578fb
PE
3919 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3920
0ae6bdee
PE
3921 * data.c: Avoid integer truncation in expressions involving floats.
3922 * data.c: Include <intprops.h>.
3923 (arith_driver): When there's an integer overflow in an expression
3924 involving floating point, convert the integers to floating point
3925 so that the resulting value does not suffer from catastrophic
3926 integer truncation. For example, on a 64-bit host (* 4
3927 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3928 Do not rely on undefined behavior after integer overflow.
3929
de883a70
PE
3930 merge count_size_as_multibyte, parse_str_to_multibyte
3931 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3932 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3933 Check for integer overflow.
3934 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3935 since it's now a duplicate of the other. This is more of
3936 a character than a buffer op, so better that it's in character.c.
3937 * fns.c, print.c: Adjust to above changes.
3938
2ff916cb
PE
39392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3940
3941 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3942
f1b54466
PE
39432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3944
fb1ac845
PE
3945 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3946 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3947 (x_clipboard_manager_save): Now static.
3948 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3949
f1b54466
PE
3950 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3951 (crypto_hash_function): Now static.
3952 Fix pointer signedness problems. Avoid unnecessary initializations.
3953
a9f737ee
CY
39542011-05-27 Chong Yidong <cyd@stupidchicken.com>
3955
3956 * termhooks.h (Vselection_alist): Make it terminal-local.
3957
3958 * terminal.c (create_terminal): Initialize it.
3959
3960 * xselect.c: Support for clipboard managers.
3961 (Vselection_alist): Move to termhooks.h as terminal-local var.
3962 (LOCAL_SELECTION): New macro.
3963 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3964 (symbol_to_x_atom): Remove gratuitous arg.
3965 (x_handle_selection_request, lisp_data_to_selection_data)
3966 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3967 (x_own_selection, x_get_local_selection, x_convert_selection):
3968 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3969 (some_frame_on_display): Delete unused function.
3970 (Fx_own_selection_internal, Fx_get_selection_internal)
3971 (Fx_disown_selection_internal, Fx_selection_owner_p)
3972 (Fx_selection_exists_p): New optional frame arg.
3973 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3974 (x_handle_selection_clear): Don't treat other terminals with the
3975 same keyboard specially. Use the terminal-local Vselection_alist.
3976 (x_clear_frame_selections): Use Frun_hook_with_args.
3977
3978 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3979
3980 * xterm.h: Add support for those atoms.
3981
e067f0c1
CY
39822011-05-26 Chong Yidong <cyd@stupidchicken.com>
3983
3984 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3985 (converted_selections, conversion_fail_tag): New global variables.
3986 (x_selection_request_lisp_error): Free the above.
3987 (x_get_local_selection): Remove unnecessary code.
3988 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3989 of converted selections stored in converted_selections.
3990 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3991 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3992 (x_convert_selection): New function.
3993 (x_handle_selection_event): Simplify.
3994 (x_get_foreign_selection): Don't ignore incoming requests while
3995 waiting for an answer; this will fail when we implement
3996 SAVE_TARGETS, and seems unnecessary anyway.
3997 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3998 (Vx_sent_selection_functions): Doc fix.
3999
0f4aebc0
LL
40002011-05-26 Leo Liu <sdl.web@gmail.com>
4001
4002 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4003
e61124cd
YM
40042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4005
4006 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4007
4008 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4009 for fringe update if it has periodic bitmap.
ac389d0c 4010 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4011 and fringe_bitmap_periodic_p.
4012
4013 * fringe.c (get_fringe_bitmap_data): New function.
4014 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4015 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4016 row. Mark glyph row for fringe update if periodicity changed.
4017
4018 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4019 for fringe update unless it has periodic bitmap.
4020
f16d9837
KH
40212011-05-25 Kenichi Handa <handa@m17n.org>
4022
4023 * xdisp.c (get_next_display_element): Set correct it->face_id for
4024 a static composition.
4025
e1b90ef6
LL
40262011-05-24 Leo Liu <sdl.web@gmail.com>
4027
4028 * deps.mk (fns.o):
4029 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4030
4031 * fns.c (crypto_hash_function, Fsha1): New function.
4032 (Fmd5): Use crypto_hash_function.
4033 (syms_of_fns): Add Ssha1.
4034
7400048f
PE
40352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 * gnutls.c: Remove unused macros.
4038 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4039 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4040 Remove macros that are defined and never used.
4041 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4042
abb71cf4
CY
40432011-05-22 Chong Yidong <cyd@stupidchicken.com>
4044
4045 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4046 (Fx_get_selection_internal): Minor cleanup.
4047 (Fx_own_selection_internal): Rename arguments for consistency with
4048 select.el.
4049
6307db39
PE
40502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4051
4052 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4053
f3d4e0a4
CY
40542011-05-22 Chong Yidong <cyd@stupidchicken.com>
4055
4056 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4057
4d8ade89
YM
40582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4059
4060 * dispnew.c (scrolling_window): Don't exclude the case that the
4061 last enabled row in the desired matrix touches the bottom boundary.
4062
32078c8d
GM
40632011-05-21 Glenn Morris <rgm@gnu.org>
4064
4065 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4066 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4067 and add some more files.
32078c8d 4068
7285dc67
EZ
40692011-05-20 Eli Zaretskii <eliz@gnu.org>
4070
4071 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4072 report_file_error introduced by the change from 2011-05-07.
4073
89d1bd22
PE
40742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4075
4076 * systime.h (Time): Define only if emacs is defined.
4077 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4078 where the include path doesn't have X11/X.h by default. See
4079 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4080
e23640bb 40812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4082
4083 * composite.c (find_automatic_composition): Fix previous change.
4084
b9704ad9
GM
40852011-05-20 Glenn Morris <rgm@gnu.org>
4086
4087 * lisp.mk: New file, split from Makefile.in.
4088 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4089 (shortlisp): Remove.
4090 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4091
4a720484
GM
40922011-05-19 Glenn Morris <rgm@gnu.org>
4093
4094 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4095 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4096 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4097 (lisp): Set the order to that of loadup.el.
4098 (shortlisp): Make it a copy of $lisp.
4099 (SOME_MACHINE_LISP): Remove.
4100 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4101 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4102
a28d4396
KH
41032011-05-18 Kenichi Handa <handa@m17n.org>
4104
4105 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4106 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4107 (find_automatic_composition): Mostly rewrite for efficiency.
4108
a2b1fa8e
JB
41092011-05-18 Juanma Barranquero <lekktu@gmail.com>
4110
4111 * makefile.w32-in: Update dependencies.
4112
8e1f5610
CS
41132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4114
4115 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4116 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4117
7025ee00 41182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4119
cdfa6eab
PE
4120 Fix some integer overflow issues, such as string length overflow.
4121
06d6db33
PE
4122 * insdel.c (count_size_as_multibyte): Check for string overflow.
4123
2b4560a8
PE
4124 * character.c (lisp_string_width): Check for string overflow.
4125 Use EMACS_INT, not int, for string indexes and lengths; in
4126 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4127 the resulting string length overflows an EMACS_INT; instead,
4128 report a string overflow if no precision given. When checking for
4129 precision exhaustion, use a check that cannot possibly have
4130 integer overflow. (Bug#8675)
4131 * character.h (lisp_string_width): Adjust to new signature.
4132
cb93f9be
PE
4133 * alloc.c (string_overflow): New function.
4134 (Fmake_string): Use it. This doesn't change behavior, but saves
4135 a few bytes and will simplify future changes.
4136 * character.c (string_escape_byte8): Likewise.
4137 * lisp.h (string_overflow): New decl.
4138
1a1f3366
PE
4139 Fixups, following up to the user-interface timestamp change.
4140 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4141 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4142 * msdos.c (mouse_get_pos): Likewise.
4143 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4144 * w32gui.h (Time): Define by including "systime.h" rather than by
4145 declaring it ourselves. (Bug#8664)
4146
d4e3e4d3
PE
4147 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4148 * image.c (clear_image_cache): Likewise.
4149
f6a24d19
PE
4150 * term.c (term_mouse_position): Don't assume time_t wraparound.
4151
08dc5ae6
PE
4152 Be more systematic about user-interface timestamps.
4153 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4154 and sometimes 'EMACS_UINT', to represent these timestamps.
4155 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4156 This makes the code easier to follow, and makes it easier to catch
4157 integer overflow bugs such as Bug#8664.
4158 * frame.c (Fmouse_position, Fmouse_pixel_position):
4159 Use Time, not unsigned long, for user-interface timestamps.
4160 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4161 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4162 * keyboard.h (last_event_timestamp): Likewise.
4163 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4164 * menu.h (xmenu_show): Likewise.
4165 * term.c (term_mouse_position): Likewise.
4166 * termhooks.h (struct input_event.timestamp): Likewise.
4167 (struct terminal.mouse_position_hook): Likewise.
4168 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4169 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4170 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4171 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4172 what it was before.
4173 * menu.h, termhooks.h: Include "systime.h", for Time.
4174
8e55734a
PE
4175 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4176 Don't assume that the difference between two unsigned long values
4177 can fit into an integer. At this point, we know button_down_time
4178 <= event->timestamp, so the difference must be nonnegative, so
4179 there's no need to cast the result if double-click-time is
4180 nonnegative, as it should be; check that it's nonnegative, just in
4181 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4182 apart (about 25 days). (Bug#8664)
8e55734a 4183
841f1b75 4184 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4185 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4186
3e26f69c
PE
4187 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4188 that always fit in int. Use a sentinel instead of a counter, to
4189 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4190 * frame.h (struct frame): Use int for menu_bar_items_used
4191 instead of EMACS_INT, since it always fits in int.
3e26f69c 4192
5cc152c0
PE
4193 * menu.c (grow_menu_items): Check for int overflow.
4194
d89eb65e
PE
4195 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4196
5235bd3e
PE
4197 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4198 Before, the code was not consistent. These values cannot exceed
4199 2**31 - 1 so there's no need to make them unsigned.
4200 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4201 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4202 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4203 as modifiers.
4204 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4205
bc827e23
PE
4206 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4207 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4208 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4209 presumably because the widths might not match.
4210
78eb494e
PE
4211 * window.c (size_window): Avoid needless test at loop start.
4212
04f2d78b
CB
42132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4214
4215 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4216
d2fc7e3d 42172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4218
4219 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4220
d2fc7e3d 42212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4222
4223 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4224 `width' to `bar_area_x' and `bar_area_width', respectively.
4225 (x_scroll_run): Take account of fringe background extension.
4226
04f2d78b
CB
4227 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4228 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4229 `bar_area_width', respectively.
4230 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4231 background extension.
4232
79b70037
GM
42332011-05-10 Jim Meyering <meyering@redhat.com>
4234
4235 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4236
2f142cc5
JB
42372011-05-10 Juanma Barranquero <lekktu@gmail.com>
4238
4239 * image.c (Finit_image_library): Return t for built-in image types,
4240 like pbm and xbm. (Bug#8640)
4241
57679c86
AS
42422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4243
4244 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4245
888c9e86
EZ
42462011-05-07 Eli Zaretskii <eliz@gnu.org>
4247
b0512a1d
EZ
4248 * w32console.c (Fset_screen_color): Doc fix.
4249 (Fget_screen_color): New function.
4250 (syms_of_ntterm): Defsubr it.
4251
7285dc67
EZ
4252 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4253 unlink the temporary file if Fcall_process didn't create it in the
4254 first place.
4255 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4256 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4257 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4258 cue to call_process_cleanup not to close that handle.
4259
4d3fcc8e
BK
42602011-05-07 Ben Key <bkey76@gmail.com>
4261
4262 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4263 one of two shell specific rules, either bootstrap-temacs-CMD or
4264 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4265 to the previous implementation of the bootstrap-temacs rule.
4266 The bootstrap-temacs-CMD rule is similar to the previous
4267 implementation of the bootstrap-temacs rule except that it
4268 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4269 variable.
4270
4271 These changes, along with some changes to nt/configure.bat,
4272 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4273 earlier fix to add support for --cflags and --ldflags options
4274 that include quotes so that it works whether make uses cmd or
4275 sh as the shell.
4276
b4289b64
MA
42772011-05-06 Michael Albinus <michael.albinus@gmx.de>
4278
4279 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4280 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4281 is a constant.
4282 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4283 a string. Handle both cases.
4284 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4285 (Fdbus_register_method): Use Qinvalid_function.
4286
af4c0e28
JB
42872011-05-06 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * makefile.w32-in: Update dependencies.
4290 (LISP_H): Add inttypes.h and stdin.h.
4291 (PROCESS_H): Add unistd.h.
4292
c51453d9
EZ
42932011-05-06 Eli Zaretskii <eliz@gnu.org>
4294
4295 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4296 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4297
8ff0ac3c 42982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4299
4c4b566b
PE
4300 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4301
aab2b9b5
PE
4302 * term.c (vfatal): Remove stray call to va_end.
4303 It's not needed and the C Standard doesn't allow it here anyway.
4304
c378da0b
PE
4305 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4306 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4307
288b08c7
PE
4308 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4309 bytes.
4310
e3601888
PE
4311 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4312
db6c0e74
PE
4313 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4314
dd5963ea
PE
4315 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4316
88c9450f
PE
4317 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4318
2f9442b8
PE
4319 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4320
c032b5f8
PE
4321 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4322 * charset.c (Fdefine_charset_internal): Don't initialize
4323 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4324 32-bit int (Bug#8600).
a108c10b
PE
4325
4326 * lread.c (read_integer): Be more consistent with string-to-number.
4327 Use string_to_number to do the actual conversion; this avoids
4328 rounding errors and fixes some other screwups. Without this fix,
4329 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4330 (digit_to_number): Move earlier, for benefit of read_integer.
4331 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4332 not a digit in any supported base. (Bug#8602)
a108c10b 4333
ad5f9eea
PE
4334 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4335
aec1708a
PE
4336 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4337 to match comment at start of function. This also removes a
4338 GCC warning about overflow in a 32+64-bit port.
4339
47be4ab5
PE
4340 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4341
371cac43
PE
4342 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4343 Reported by Stefan Monnier in
4344 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4345 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4346 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4347
d01a7826
PE
4348 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4349 (EMACS_UINTPTR): Likewise, with uintptr_t.
4350
7fd47d5c
PE
4351 * lisp.h: Prefer 64-bit EMACS_INT if available.
4352 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4353 on 32-bit hosts that have 64-bit int, so that they can access
4354 large files.
122b0c86
PE
4355 However, temporarily disable this change unless the temporary
4356 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4357
8727937b
PE
4358 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4359
8ac068ac
PE
4360 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4361 This removes an assumption that EMACS_INT and long are the same
4362 width as pointers. The assumption is true for Emacs porting targets
4363 now, but we want to make other targets possible.
4364 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4365 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4366 In the rest of the code, change types of integers that hold casted
4367 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4368 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4369 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4370 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4371 No need to cast type when ORing.
4372 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4373 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4374 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4375 assume EMACS_INT is the same width as char *.
4376 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4377 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4378 Remove no-longer-needed casts.
4379 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4380 (xg_tool_bar_help_callback, xg_make_tool_item):
4381 Use EMACS_INTPTR to hold an integer
4382 that will be cast to void *; this can avoid a GCC warning
4383 if EMACS_INT is not the same width as void *.
4384 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4385 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4386 (current_message_1, set_message_1):
4387 Use a local to convert to proper width without a cast.
4388 * xmenu.c (dialog_selection_callback): Likewise.
4389
ede49d71
PE
4390 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4391 Also, don't assume VALBITS / RAND_BITS is less than 5,
4392 and don't rely on undefined behavior when shifting a 1 left into
4393 the sign bit.
4394 * lisp.h (get_random): Change signature to match.
4395
2f30ecd0
PE
4396 * lread.c (hash_string): Use size_t, not int, for hash computation.
4397 Normally we prefer signed values; but hashing is special, because
4398 it's better to use unsigned division on hash table sizes so that
4399 the remainder is nonnegative. Also, size_t is the natural width
4400 for hashing into memory. The previous code used 'int', which doesn't
4401 retain enough info to hash well into very large tables.
4402 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4403
2a866e7b
PE
4404 * dbusbind.c: Don't possibly lose pointer info when converting.
4405 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4406 Use XPNTR rather than XHASH, so that the high-order bits of
4407 the pointer aren't lost when converting through void *.
4408
51639eac
PE
4409 * eval.c (Fautoload): Don't double-shift a pointer.
4410
92394119
PE
4411 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4412
dbdb9a7c
JB
44132011-05-06 Juanma Barranquero <lekktu@gmail.com>
4414
4415 * gnutls.c (DEF_GNUTLS_FN):
4416 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4417
db7a0b4f
AS
44182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4419
4420 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4421 marker. (Bug#8610)
4422
f7ff1b0f 44232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4424
4425 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4426 New version that can reserve upto 2GB of heap space.
4427
f7ff1b0f 44282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4429
4430 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4431
639c109b
TZ
44322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4433
4434 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4435 `gnutls_certificate_set_x509_key_file'.
4436
d2127135
JB
44372011-05-05 Juanma Barranquero <lekktu@gmail.com>
4438
4439 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4440 Update dependencies.
4441
e968f4f3
JB
44422011-05-04 Juanma Barranquero <lekktu@gmail.com>
4443
4444 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4445 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4446 Remove unused parameter `fildes'.
4447 * process.c (read_process_output, send_process): Don't pass it.
4448
84d358f0
JB
44492011-05-04 Juanma Barranquero <lekktu@gmail.com>
4450
4451 Fix previous change: the library cache is defined in w32.c.
4452 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4453 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4454
0898ca10
JB
44552011-05-04 Juanma Barranquero <lekktu@gmail.com>
4456
4457 Implement dynamic loading of GnuTLS on Windows.
4458
4459 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4460 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4461 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4462 Declare.
4463
4464 * gnutls.c (Qgnutls_dll): Define.
4465 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4466 (gnutls_*): Declare function pointers.
4467 (init_gnutls_functions): New function to initialize function pointers.
4468 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4469 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4470 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4471 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4472 (emacs_gnutls_write, emacs_gnutls_read)
4473 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4474 (Fgnutls_available_p): New function.
4475 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4476 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4477 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4478
4479 * image.c: Include w32.h.
4480 (Vimage_type_cache): Delete.
4481 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4482 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4483 (w32_delayed_load): Move to w32.c.
4484
4485 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4486
4487 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4488 (w32_delayed_load): Move from image.c. When loading a library, record
4489 its filename in the :loaded-from property of the library id.
4490 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4491 Initialize and staticpro them.
4492 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4493
4494 * process.c: Include lisp.h before w32.h, not after.
4495 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4496 instead of gnutls_record_check_pending.
4497
4498 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4499
ff4de4aa
TZ
45002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4501
4502 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4503 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4504 as passed in.
4505
abe95abb
JD
45062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4507
4508 * xterm.c (x_set_frame_alpha): Do not set property on anything
4509 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4510
e16e55d4
JB
45112011-05-02 Juanma Barranquero <lekktu@gmail.com>
4512
4513 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4514
bafcf6a5
JB
45152011-05-02 Juanma Barranquero <lekktu@gmail.com>
4516
4517 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4518 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4519 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4520 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4521 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4522 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4523 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4524 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4525 (Qgnutls_bootprop_callbacks_verify): Make static.
4526
e7a6747f
AS
45272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4528
19ed11ba
AS
4529 * callproc.c: Indentation fixup.
4530
e7a6747f 4531 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4532 (wait_for_termination, interruptible_wait_for_termination):
4533 Move after wait_for_termination_1.
e7a6747f 4534
1ef14cb4
LMI
45352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4536
4537 * sysdep.c (interruptible_wait_for_termination): New function
4538 which is like wait_for_termination, but allows keyboard
4539 interruptions.
4540
4541 * callproc.c (Fcall_process): Add (:file "file") as an option for
4542 the STDOUT buffer.
4543 (Fcall_process_region): Ditto.
4544
330d880c
EZ
45452011-04-30 Eli Zaretskii <eliz@gnu.org>
4546
8db90b73
EZ
4547 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4548 rather than `XVECTOR (FOO)->size'.
4549
330d880c
EZ
4550 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4551 inttypes.h, as a gnulib replacement is used if it not available in
4552 system headers.
4553
15cbd324
EZ
45542011-04-21 Eli Zaretskii <eliz@gnu.org>
4555
4556 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4557 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4558 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4559
4560 * coding.c (coding_alloc_by_realloc): Error out if destination
4561 will grow beyond MOST_POSITIVE_FIXNUM.
4562 (decode_coding_emacs_mule): Abort if there isn't enough place in
4563 charbuf for the composition carryover bytes. Reserve an extra
4564 space for up to 2 characters produced in a loop.
4565 (decode_coding_iso_2022): Abort if there isn't enough place in
4566 charbuf for the composition carryover bytes.
4567
45682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4569
ae940cca
EZ
4570 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4571 aborting when %lld or %lll format is passed.
4572 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4573 %llo or %llx format is passed. (Bug#8545)
4574
03ab8921
EZ
4575 * window.c (window_scroll_line_based): Use a marker instead of
4576 simple variables to record original value of point. (Bug#7952)
4577
afda1437
EZ
4578 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4579 produced by %s or %c overflows available buffer space. (Bug#8545)
4580
f76dee0c
PE
45812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4582
4583 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4584 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4585
fdc5744d
JB
45862011-04-28 Juanma Barranquero <lekktu@gmail.com>
4587
4588 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4589
638f053a
JB
45902011-04-28 Juanma Barranquero <lekktu@gmail.com>
4591
4592 * keyboard.c (Qdelayed_warnings_hook): Define.
4593 (command_loop_1): Run `delayed-warnings-hook'
4594 if Vdelayed_warnings_list is non-nil.
4595 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4596 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4597
d178f871
EZ
45982011-04-28 Eli Zaretskii <eliz@gnu.org>
4599
4600 * doprnt.c (doprnt): Don't return value smaller than the buffer
4601 size if the message was truncated. (Bug#8545).
4602
b124fd93
JB
46032011-04-28 Juanma Barranquero <lekktu@gmail.com>
4604
4605 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4606 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4607
e810457d
PE
46082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4609
4610 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4611
ea51cceb
JB
46122011-04-27 Juanma Barranquero <lekktu@gmail.com>
4613
4614 * makefile.w32-in: Update dependencies.
4615
94dcfacf
EZ
46162011-04-27 Eli Zaretskii <eliz@gnu.org>
4617
4618 Improve `doprnt' and its usage. (Bug#8545)
4619 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4620 `format_end'. Remove support for %l as a conversion specifier.
4621 Don't use xrealloc. Improve diagnostics when the %l size modifier
4622 is used. Update the commentary.
4623
4624 * eval.c (verror): Simplify calculation of size_t.
4625
4626 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4627 messages.
4628
f61f41d7
PE
46292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4630
4631 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4632 change.
4633
96fb4434
PE
46342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4635
4636 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4637 This makes this file independent of the recent pseudovector change.
4638
671875da 46392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4640
69e9b5a3
PE
4641 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4642
b5f869a7 4643 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4644 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4645 Remove unused local.
c8926152 4646 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4647
841a1577 4648 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4649 GCC 4.6.0 optimizes based on type-based alias analysis.
4650 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4651 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4652 != &v->size, and therefore "v->size = 1; b->size = 2; return
4653 v->size;" must therefore return 1. This assumption is incorrect
4654 for Emacs, since it type-puns struct Lisp_Vector * with many other
4655 types. To fix this problem, this patch adds a new type struct
f904488f 4656 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4657 and pseudovectors, and helps optimizing compilers not get fooled
4658 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4659 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4660 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4661 the size member.
eab3844f
PE
4662 (XSETPVECTYPE): Rewrite in terms of new macro.
4663 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4664 This is a bit clearer, and further avoids the possibility of
4665 undesirable aliasing.
4666 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4667 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4668 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4669 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4670 (ASIZE): Now uses header.size rather than size.
4671 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4672 to avoid the hassle of writing XVECTOR (foo)->header.size.
4673 (struct vectorlike_header): New type.
eab3844f
PE
4674 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4675 object, to help avoid aliasing.
4676 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4677 (SUBRP): Likewise, since Lisp_Subr is a special case.
4678 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4679 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4680 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4681 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4682 changed to be "header.size" and "header.next".
4683 * buffer.h (struct buffer): Likewise.
4684 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4685 * frame.h (struct frame): Likewise.
4686 * process.h (struct Lisp_Process): Likewise.
4687 * termhooks.h (struct terminal): Likewise.
4688 * window.c (struct save_window_data, struct saved_window): Likewise.
4689 * window.h (struct window): Likewise.
4690 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4691 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4692 * buffer.c (init_buffer_once): Likewise.
4693 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4694 special case.
4695 * process.c (Fformat_network_address): Use local var for size,
4696 for brevity.
4697
0df1eac5
PE
4698 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4699
847ab9d1 4700 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4701 * data.c (atof): Remove decl; no longer used or needed.
4702 (digit_to_number): Move to lread.c.
4703 (Fstring_to_number): Use new string_to_number function, to be
4704 consistent with how the Lisp reader treats infinities and NaNs.
4705 Do not assume that floating-point numbers represent EMACS_INT
4706 without losing information; this is not true on most 64-bit hosts.
4707 Avoid double-rounding errors, by insisting on integers when
4708 parsing non-base-10 numbers, as the documentation specifies.
4709 * lisp.h (string_to_number): New decl, replacing ...
4710 (isfloat_string): Remove.
bc0a5c13 4711 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4712 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4713 appears to have been a coding error. Similarly, do not accept
4714 strings like +-1e0 as floating point numbers. Do not report
4715 overflow for integer overflows unless the base is not 10 which
4716 means we have no simple and reliable way to continue.
4717 Break out the floating-point parsing into a new
4718 function string_to_number, so that Fstring_to_number parses
4719 floating point numbers consistently with the Lisp reader.
04f2d78b 4720 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4721 (E_CHAR, EXP_INT): Remove, replacing with ...
4722 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4723 (string_to_number): New function, replacing isfloat_string.
4724 This function checks for valid syntax and produces the resulting
4725 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4726 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4727 so that overflow for non-base-10 numbers is reported only when
4728 there's no portable and simple way to convert to floating point.
452f4150 4729
67769ffc
PE
4730 * textprop.c (set_text_properties_1): Rewrite for clarity,
4731 and to avoid GCC warning about integer overflow.
4732
c20db43f
PE
4733 * intervals.h (struct interval): Use EMACS_INT for members
4734 where EMACS_UINT might cause problems. See
4735 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4736 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4737 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4738 All uses changed.
37aa2f85
PE
4739 (offset_intervals): Tell GCC not to worry about length overflow
4740 when negating a negative length.
c20db43f 4741
2538aa2f
PE
4742 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4743 (overrun_check_free): Likewise.
4744
f2d3008d
PE
4745 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4746 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4747 word size.
4748
ec8df744
PE
4749 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4750 (gnutls_make_error): Rename local to avoid shadowing.
4751 (gnutls_emacs_global_deinit): ifdef out; not used.
4752 (Fgnutls_boot): Use const for pointer to readonly storage.
4753 Comment out unused local. Fix pointer signedness problems.
4754
640ee02d
PE
4755 * lread.c (openp): Don't stuff size_t into an 'int'.
4756 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4757 about possible signed overflow.
4758
6048fb2a
PE
4759 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4760 (GDK_KEY_g): Don't define if already defined.
4761 (xg_prepare_tooltip): Avoid pointer signedness problem.
4762 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4763
fa3c87e1
PE
4764 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4765 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4766
2172544b
PE
4767 * xfns.c (Fx_window_property): Simplify a bit,
4768 to make a bit faster and to avoid GCC 4.6.0 warning.
4769 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4770
9b821a21
PE
4771 * fns.c (internal_equal): Don't assume size_t fits in int.
4772
3c616cfa
PE
4773 * alloc.c (compact_small_strings): Tighten assertion a little.
4774
c2982e87
PE
4775 Replace pEd with more-general pI, and fix some printf arg casts.
4776 * lisp.h (pI): New macro, generalizing old pEd macro to other
4777 conversion specifiers. For example, use "...%"pI"d..." rather
4778 than "...%"pEd"...".
4779 (pEd): Remove. All uses replaced with similar uses of pI.
4780 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4781 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4782 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4783 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4784 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4785 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4786 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4787 64-bit hosts.
4788 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4789 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4790 * print.c (safe_debug_print, print_object): Likewise.
4791 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4792 to int.
6f04d126
PE
4793 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4794 avoiding the 0 flag, which is not portable.
c2982e87
PE
4795 * process.c (Fmake_network_process): Use pI to avoid cast.
4796 * region-cache.c (pp_cache): Likewise.
4797 * xdisp.c (decode_mode_spec): Likewise.
4798 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4799 behavior on 64-bit hosts with printf arg.
6f04d126 4800 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4801 (x_stop_queuing_selection_requests): Likewise.
4802 (x_get_window_property): Don't truncate byte count to an 'int'
4803 when tracing.
0b432f21 4804
5e073ec7
PE
4805 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4806 here, since it parses constructs like leading '-' and spaces,
4807 which are not wanted; and it overflows with large numbers.
4808 Instead, simply match F[0-9]+, which is what is wanted anyway.
4809
36372bf9
PE
4810 * alloc.c: Remove unportable assumptions about struct layout.
4811 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4812 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4813 (allocate_vectorlike, make_pure_vector): Use the new macros,
4814 plus offsetof, to remove unportable assumptions about struct layout.
4815 These assumptions hold on all porting targets that I know of, but
4816 they are not guaranteed, they're easy to remove, and removing them
4817 makes further changes easier.
4818
0b432f21
PE
4819 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4820 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4821 (string_overrun_cookie): Now const. Use initializers that
4822 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4823 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4824 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4825 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4826 multiple of sizeof (EMACS_INT); it need not be, if
4827 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4828 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4829
895009e1
JB
48302011-04-26 Juanma Barranquero <lekktu@gmail.com>
4831
4832 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4833
6a7a1b0b
TZ
48342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4835
4836 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4837 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4838 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4839
841a1577 48402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4841
4842 * lisp.h (Qdebug): List symbol.
895009e1 4843 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4844 * keyboard.c (debug-on-event): New variable.
4845 (handle_user_signal): Break into debugger when debug-on-event
4846 matches the current signal symbol.
4847
f2d3ba6f
DN
48482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4849
4850 * alloc.c (check_sblock, check_string_bytes)
4851 (check_string_free_list): Convert to standard C.
4852
42ce4c63
TZ
48532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4854
4855 * w32.c (emacs_gnutls_push): Fix typo.
4856
825cd63c
EZ
48572011-04-25 Eli Zaretskii <eliz@gnu.org>
4858
fb11d64d
EZ
4859 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4860 "cast to pointer from integer of different size".
4861
825cd63c
EZ
4862 Improve doprnt and its use in verror. (Bug#8545)
4863 * doprnt.c (doprnt): Document the set of format control sequences
4864 supported by the function. Use SAFE_ALLOCA instead of always
4865 using `alloca'.
4866
4867 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4868 is one byte too soon. Don't use xrealloc; instead xfree and
4869 xmalloc anew.
4870
e061a11b
TZ
48712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4872
4873 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4874 callbacks stage.
4875
4876 * gnutls.c: Renamed global_initialized to
4877 gnutls_global_initialized. Added internals for the
4878 :verify-hostname-error, :verify-error, and :verify-flags
4879 parameters of `gnutls-boot' and documented those parameters in the
4880 docstring. Start callback support.
9173deec
JB
4881 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4882 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4883 on error. Return error code.
e061a11b
TZ
4884 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4885 (emacs_gnutls_read): Likewise.
4886 (Fgnutls_boot): Return handshake error code.
4887 (emacs_gnutls_handle_error): New function.
4888 (wsaerror_to_errno): Likewise.
4889
4890 * w32.h (emacs_gnutls_pull): Add prototype.
4891 (emacs_gnutls_push): Likewise.
4892
4893 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4894 (emacs_gnutls_push): Likewise.
4895
48962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4897
4898 * process.c (wait_reading_process_output): Check if GnuTLS
4899 buffered some data internally if no FDs are set for TLS
4900 connections.
4901
4902 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4903 (LIBS): Link to USER_LIBS.
4904 ($(BLD)/gnutls.$(0)): New target.
4905
fa6996bc
EZ
49062011-04-24 Eli Zaretskii <eliz@gnu.org>
4907
eb35682e
EZ
4908 * xdisp.c (handle_single_display_spec): Rename the
4909 display_replaced_before_p argument into display_replaced_p, to
4910 make it consistent with the commentary. Fix typos in the
4911 commentary.
4912
e2ad650c
EZ
4913 * textprop.c (syms_of_textprop): Remove dead code.
4914 (copy_text_properties): Delete obsolete commentary about an
4915 interface that was deleted long ago. Fix typos in the description
4916 of arguments.
4917
1b2de274
EZ
4918 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4919 to changes in oldXMenu/XMenu.h from 2011-04-16.
4920 <menu_help_message, prev_menu_help_message>: Constify.
4921 (IT_menu_make_room): menu->help_text is now `const char **';
4922 adjust.
4923
4924 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4925 to changes in oldXMenu/XMenu.h from 2011-04-16.
4926 (struct XMenu): Declare `help_text' `const char **'.
4927
4928 * xfaces.c <Qunspecified>: Make extern again.
4929
4930 * syntax.c: Include sys/types.h before including regex.h, as
4931 required by Posix.
4932
762b15be
EZ
4933 * doc.c (get_doc_string): Improve the format passed to `error'.
4934
4935 * doprnt.c (doprnt): Improve commentary.
4936
4937 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4938
4939 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4940 them with etags.
4941
f1052e5d
EZ
4942 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4943 changes in globals.h immediately force recompilation.
762b15be
EZ
4944 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4945 $(CURDIR)/s/ms-w32.h.
4946 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4947
fa6996bc
EZ
4948 * character.c (Fchar_direction): Function deleted.
4949 (syms_of_character): Don't defsubr it.
4950 <char-direction-table>: Deleted.
4951
e6c3da20
EZ
49522011-04-23 Eli Zaretskii <eliz@gnu.org>
4953
4954 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4955 * doprnt.c: Include limits.h.
4956 (SIZE_MAX): New macro.
04f2d78b
CB
4957 (doprnt): Return a size_t value. 2nd arg is now size_t.
4958 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4959 Improve overflow protection. Support `l' modifier for integer
4960 conversions. Support %l conversion. Don't assume an EMACS_INT
4961 argument for integer conversions and for %c.
4962
4963 * lisp.h (doprnt): Restore prototype.
4964
4965 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4966 $(SRC)/character.h.
4967
4968 * Makefile.in (base_obj): Add back doprnt.o.
4969
4970 * deps.mk (doprnt.o): Add back prerequisites.
4971 (callint.o): Depend on character.h.
4972
4973 * eval.c (internal_lisp_condition_case): Include the handler
4974 representation in the error message.
4975 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4976 when breaking from the loop.
4977
4978 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4979
4980 * callint.c (Fcall_interactively): When displaying error message
4981 about invalid control letter, pass the character's codepoint, not
4982 a pointer to its multibyte form. Improve display of the character
4983 in octal and display also its hex code.
4984
4985 * character.c (char_string): Use %x to display the (unsigned)
4986 codepoint of an invalid character, to avoid displaying a bogus
4987 negative value.
4988
4989 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4990 `error', not SYMBOL_NAME itself.
4991
4992 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4993 character arguments to `error'.
4994
4995 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4996 to `error' in error message about FINAL_CHAR argument. Make sure
4997 FINAL_CHAR is a character, and use %c when it is passed as
4998 argument to `error'.
4999
4ffd0d6b 50002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5001
5002 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5003
5004 * w32.c: Include <time.h>.
5005 (sys_localtime): New function.
5006
4ffd0d6b 50072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5008
5009 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5010
4ffd0d6b 5011 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5012
4ffd0d6b 50132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5014
4ffd0d6b
GM
5015 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5016 zombies (Bug#8467).
aac0c6e3 5017
04c56954
EZ
50182011-04-19 Eli Zaretskii <eliz@gnu.org>
5019
5020 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5021 gl_state.e_property when gl_state.object is Qt.
5022
5023 * insdel.c (make_gap_larger): Remove limitation of buffer size
5024 to <= INT_MAX.
5025
16a43933
CY
50262011-04-18 Chong Yidong <cyd@stupidchicken.com>
5027
5028 * xdisp.c (lookup_glyphless_char_display)
5029 (produce_glyphless_glyph): Handle cons cell entry in
5030 glyphless-char-display.
5031 (Vglyphless_char_display): Document it.
5032
5033 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5034 glyphless-char-display.
5035
4581706e
CY
50362011-04-17 Chong Yidong <cyd@stupidchicken.com>
5037
5038 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5039
5040 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5041
5042 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5043 definition for no-X builds.
5044
4887c6e2 50452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5046
fd35b6f9
PE
5047 Static checks with GCC 4.6.0 and non-default toolkits.
5048
5c1ccb01
PE
5049 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5050
006c5daa
PE
5051 * process.c (keyboard_bit_set): Define only if SIGIO.
5052 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5053 (send_process): Repair possible setjmp clobbering.
5054
efc736d3
PE
5055 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5056
4e2fe2e6
PE
5057 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5058
f97334a2
PE
5059 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5060
4e75f29d
PE
5061 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5062 Define only if needed.
5063
90efadd1
PE
5064 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5065 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5066 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5067
3c647824
PE
5068 * dispextern.h (struct redisplay_interface): Rename param
5069 to avoid shadowing.
e264f262 5070 * termhooks.h (struct terminal): Likewise.
761383f4 5071 * xterm.c (xembed_send_message): Likewise.
3c647824 5072
b58c5c4a
PE
5073 * insdel.c (make_gap_smaller): Define only if
5074 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5075
cad59032
PE
5076 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5077 it.
5078
c339dc2e
PE
5079 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5080 so that we aren't warned about unused symbols.
5081
91a3e27b
PE
5082 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5083
399c71d3 5084 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5085
8ffc96f5
PE
5086 * xfns.c (x_real_positions): Mark locals as initialized.
5087
eef9bc79
PE
5088 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5089
098db9dd
PE
5090 * xterm.c: Fix problems found by static analysis with other toolkits.
5091 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5092 (x_dispatch_event): Declare static if USE_GTK, and
5093 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5094 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5095 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5096 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5097 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5098
eb18f6cc
PE
5099 * xmenu.c (menu_help_callback): Pointer type fixes.
5100 Use const pointers when pointing at readonly data. Avoid pointer
5101 signedness clashes.
5102 (FALSE): Remove unused macro.
5103 (update_frame_menubar): Remove unused decl.
5104
1fe72bf8
PE
5105 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5106
60d9e1db
PE
5107 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5108 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5109 (single_menu_item): Rename local to avoid shadowing.
5110
39261c26
PE
5111 * keyboard.c (make_lispy_event): Remove unused local var.
5112
018c5e19
PE
5113 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5114 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5115
63d2b86e
PE
5116 * bitmaps: Change bitmaps from unsigned char back to the X11
5117 compatible char. Avoid the old compiler warnings about
5118 out-of-range initializers by using, for example, '\xab' rather
5119 than 0xab.
5120
aefd87e1
PE
5121 * xgselect.c (xgselect_initialize): Check vs interface
5122 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5123
bf501fb9
PE
5124 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5125
e9829fdf
PE
5126 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5127 to read-only memory.
5128
1086c095
PE
5129 * fns.c (vector): Remove; this old hack is no longer needed.
5130
2baccd04 5131 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5132 Remove unused var.
dde42981 5133 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5134
72391843 5135 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5136
436c16df 5137 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5138 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5139 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5140
92bb796d 5141 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5142 (x_term_init): Remove local to avoid shadowing.
92bb796d 5143
764430a3 5144 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5145
5146 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5147 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5148
d1dfb56c
EZ
51492011-04-16 Eli Zaretskii <eliz@gnu.org>
5150
c4354cb4
EZ
5151 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5152
d1dfb56c
EZ
5153 Fix regex.c, syntax.c and friends for buffers > 2GB.
5154 * syntax.h (struct gl_state_s): Declare character position members
5155 EMACS_INT.
5156
5157 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5158
04f2d78b
CB
5159 * textprop.c (verify_interval_modification, interval_of):
5160 Declare arguments EMACS_INT.
d1dfb56c
EZ
5161
5162 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5163 EMACS_INT.
5164
5165 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5166
5167 * indent.c (Fvertical_motion): Local variable it_start is now
5168 EMACS_INT.
5169
5170 * regex.c (re_match, re_match_2, re_match_2_internal)
5171 (bcmp_translate, regcomp, regexec, print_double_string)
5172 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5173 (re_compile_pattern, re_exec): Declare arguments and local
5174 variables `size_t' and `ssize_t' and return values `regoff_t', as
5175 appropriate.
5176 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5177 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5178 <compile_stack_type>: `size' and `avail' are now `size_t'.
5179
5180 * regex.h <regoff_t>: Use ssize_t, not int.
5181 (re_search, re_search_2, re_match, re_match_2): Arguments that
5182 specify buffer/string position and length are now ssize_t and
5183 size_t. Return type is regoff_t.
5184
613052cd
BK
51852011-04-16 Ben Key <bkey76@gmail.com>
5186
5187 * nsfont.m: Fixed bugs in ns_get_family and
5188 ns_descriptor_to_entity that were caused by using free to
5189 deallocate memory blocks that were allocated by xmalloc (via
5190 xstrdup). This caused Emacs to crash when compiled with
5191 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5192 --enable-checking=xmallocoverrun). xfree is now used to
5193 deallocate these memory blocks.
5194
4170f62f 51952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5196
71b41406
PE
5197 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5198
9587a89d
PE
5199 emacs_write: Accept and return EMACS_INT for sizes.
5200 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5201 et seq.
5202 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5203 Accept and return EMACS_INT.
5204 (emacs_gnutls_write): Return the number of bytes written on
5205 partial writes.
5206 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5207 (emacs_read, emacs_write): Remove check for negative size, as the
5208 Emacs source code has been audited now.
9587a89d
PE
5209 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5210 (emacs_read, emacs_write): Use it.
273a5f82
PE
5211 * process.c (send_process): Adjust to the new signatures of
5212 emacs_write and emacs_gnutls_write. Do not attempt to store
5213 a byte offset into an 'int'; it might overflow.
9587a89d 5214 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5215
3e047f51
PE
5216 * sound.c: Don't assume sizes fit in 'int'.
5217 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5218 Return EMACS_INT, not int.
3e047f51 5219 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5220 Accept EMACS_INT, not int.
5221 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5222 record read return values.
5223
cc39a9db
BK
52242011-04-15 Ben Key <bkey76@gmail.com>
5225
c9d0ec6d
JB
5226 * keyboard.c (Qundefined): Don't declare static since it is used
5227 in nsfns.m.
5228 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5229 static since they are used in nsfont.m.
cc39a9db 5230
6c60eb9f
SM
52312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5232
5233 * process.c (Qprocessp): Don't declare static.
5234 * lisp.h (Qprocessp): Declare again.
5235
7990b61a
JB
52362011-04-15 Juanma Barranquero <lekktu@gmail.com>
5237
5238 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5239
5d4cb038
PE
52402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5241
8bd7b830 5242 Improve C-level modularity by making more things 'static'.
cd64ea1d 5243
e3b27b31
PE
5244 Don't publish debugger-only interfaces to other modules.
5245 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5246 (verify_bytepos, count_markers): Move decls to the only modules
5247 that need them.
5248 * region-cache.h (pp_cache): Likewise.
5249 * window.h (check_all_windows): Likewise.
5250 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5251
5d4cb038
PE
5252 * sysdep.c (croak): Now static, if
5253 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5254 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5255
5256 * alloc.c (refill_memory_reserve): Now static if
5257 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5258 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5259
e87b6180
PE
5260 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5261 Define only if USE_LUCID.
5262
ac64929e
PE
5263 * xrdb.c (x_customization_string, x_rm_string): Now static.
5264
6f37259d
PE
5265 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5266 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5267
1683e3ab
PE
5268 * xdisp.c (draw_row_with_mouse_face): Now static.
5269 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5270
de9c2632
PE
5271 * window.h (check_all_windows): Mark externally visible.
5272
2b96acb7
PE
5273 * window.c (window_deletion_count): Now static.
5274
5275 * undo.c: Make symbols static if they're not exported.
5276 (last_undo_buffer, last_boundary_position, pending_boundary):
5277 Now static.
5278
50436f33
PE
5279 * textprop.c (interval_insert_behind_hooks): Now static.
5280 (interval_insert_in_front_hooks): Likewise.
5281
64520e5c
PE
5282 * term.c: Make symbols static if they're not exported.
5283 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5284 (max_frame_lines, tty_set_terminal_modes):
5285 (tty_reset_terminal_modes, tty_turn_off_highlight):
5286 (get_tty_terminal): Now static.
5287 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5288 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5289 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5290 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5291 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5292
1fa53021
PE
5293 * sysdep.c: Make symbols static if they're not exported.
5294 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5295 Now static.
5296 (sigprocmask_set, full_mask): Remove; unused.
5297 (wait_debugging): Mark as visible.
5298 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5299 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5300
d4b43b22
PE
5301 * syntax.c (syntax_temp): Define only if !__GNUC__.
5302
b7c513d0
PE
5303 * sound.c (current_sound_device, current_sound): Now static.
5304
989b29ad
PE
5305 * search.c (searchbufs, searchbuf_head): Now static.
5306
13a55a78
PE
5307 * scroll.c (scroll_cost): Remove; unused.
5308 * dispextern.h (scroll_cost): Remove decl.
5309
de68a1fc
PE
5310 * region-cache.h (pp_cache): Mark as externally visible.
5311
40ccffa6
PE
5312 * process.c: Make symbols static if they're not exported.
5313 (process_tick, update_tick, create_process, chan_process):
5314 (Vprocess_alist, proc_buffered_char, datagram_access):
5315 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5316 (deactivate_process): Mark defn as static, as well as decl.
5317 * lisp.h (create_process): Remove decl.
5318 * process.h (chan_process, Vprocess_alist): Remove decls.
5319
ad64fc97
PE
5320 * print.c: Make symbols static if they're not exported.
5321 (print_depth, new_backquote_output, being_printed, print_buffer):
5322 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5323 (print_interval, print_number_index, initial_stderr_stream):
5324 Now static.
5325 * lisp.h (Fprinc): Remove decl.
5326 (debug_output_compilation_hack): Mark as externally visible.
5327
adddb265
PE
5328 * sysdep.c (croak): Move decl from here to syssignal.h.
5329 * syssignal.h (croak): Put it here, so the API can be checked when
5330 'croak' is called from dissociate_if_controlling_tty.
5331
1717ede2
PE
5332 * minibuf.c: Make symbols static if they're not exported.
5333 (minibuf_save_list, choose_minibuf_frame): Now static.
5334 * lisp.h (choose_minibuf_frame): Remove decl.
5335
fa5fb2bc
PE
5336 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5337
1e3890d1
PE
5338 * lread.c: Make symbols static if they're not exported.
5339 (read_objects, initial_obarray, oblookup_last_bucket_number):
5340 Now static.
5341 (make_symbol): Remove; unused.
5342 * lisp.h (initial_obarray, make_symbol): Remove decls.
5343
8a1414fa
PE
5344 * keyboard.c: Make symbols static if they're not exported.
5345 (single_kboard, recent_keys_index, total_keys, recent_keys):
5346 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5347 (this_single_command_key_start, echoing, last_auto_save):
5348 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5349 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5350 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5351 (Vlispy_mouse_stem, double_click_count):
5352 Now static.
5353 (force_auto_save_soon): Define only if SIGDANGER.
5354 (ignore_mouse_drag_p): Now static if
5355 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5356 (print_help): Remove; unused.
5357 (stop_character, last_timer_event): Mark as externally visible.
5358 * keyboard.h (ignore_mouse_drag_p): Declare only if
5359 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5360 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5361 * lisp.h (echoing): Remove decl.
5362 (force_auto_save_soon): Declare only if SIGDANGER.
5363 * xdisp.c (redisplay_window): Simplify code, to make it more
5364 obvious that ignore_mouse_drag_p is not accessed if !defined
5365 USE_GTK && !defined HAVE_NS.
5366
93ea6e8f
PE
5367 * intervals.c: Make symbols static if they're not exported.
5368 (merge_properties_sticky, merge_interval_right, delete_interval):
5369 Now static.
5370 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5371
77382fcc
PE
5372 * insdel.c: Make symbols static if they're not exported.
5373 However, leave prepare_to_modify_buffer alone. It's never
5374 called from outside this function, but that appears to be a bug.
5375 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5376 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5377 (adjust_after_replace_noundo): Remove; unused.
5378 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5379 (signal_before_change): Remove decls.
77382fcc 5380
9306c32e
PE
5381 * indent.c (val_compute_motion, val_vmotion): Now static.
5382
cd44d2eb
PE
5383 * image.c: Make symbols static if they're not exported.
5384 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5385 if USE_GTK.
5386 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5387 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5388
ad9a7a06
PE
5389 * fringe.c (standard_bitmaps): Now static.
5390 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5391
81626931
PE
5392 * frame.c: Make symbols static if they're not exported.
5393 (x_report_frame_params, make_terminal_frame): Now static.
5394 (get_frame_param): Now static, unless HAVE_NS.
5395 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5396 (x_get_resource_string): Remove; not used.
5397 * frame.h (make_terminal_frame, x_report_frame_params):
5398 (x_get_resource_string); Remove decls.
5399 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5400 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5401
239f9db9
PE
5402 * font.c, fontset.c: Make symbols static if they're not exported.
5403 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5404 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5405 * font.c (font_close_object): Now static.
5406 * font.h (font_close_object): Remove.
5407 * fontset.c (FONTSET_OBJLIST): Remove.
5408 (free_realized_fontset) #if-0 the body, which does nothing.
5409 (face_suitable_for_char_p): #if-0, as it's never called.
5410 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5411 * xfaces.c (face_at_string_position):
5412 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5413 since 0 is always ASCII.
5414
dfcf3579
PE
5415 * fns.c (weak_hash_tables): Now static.
5416
5045092b
PE
5417 * fileio.c: Make symbols static if they're not exported.
5418 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5419 (Vwrite_region_annotation_buffers): Now static.
5420
57a96f5c
PE
5421 * eval.c: Make symbols static if they're not exported.
5422 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5423 * lisp.h (backtrace_list): Remove decl.
5424
35f08c38
PE
5425 * emacs.c: Make symbols static if they're not exported.
5426 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5427 (fatal_error_code, fatal_error_signal_hook, standard_args):
5428 Now static.
5429 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5430 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5431 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5432 * lisp.h (fatal_error_signal_hook): Remove decl.
5433 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5434
f44bd759
PE
5435 * editfns.c: Move a (normally-unused) function to its only use.
5436 * editfns.c, lisp.h (get_operating_system_release): Remove.
5437 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5438 worth the hassle of breaking this out.
5439
b532497d
PE
5440 * xterm.c: Make symbols static if they're not exported.
5441 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5442 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5443 (x_destroy_window, x_delete_display):
5444 Now static.
5445 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5446 (x_mouse_leave): Remove; unused.
5447 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5448 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5449 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5450 Remove decls.
5451 (x_mouse_leave): Declare only if WINDOWSNT.
5452 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5453 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5454 USE_X_TOOLKIT.
5455
1675728f
PE
5456 * ftxfont.c: Make symbols static if they're not exported.
5457 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5458 HAVE_FREETYPE.
5459 * font.h (ftxfont_driver): Likewise.
5460
e4cebfca
PE
5461 * xfns.c: Make symbols static if they're not exported.
5462 (x_last_font_name, x_display_info_for_name):
5463 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5464 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5465 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5466 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5467 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5468 (last_show_tip_args): Now static.
5469 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5470 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5471 (x_screen_planes): Remove; unused.
5472 * dispextern.h (x_screen_planes): Remove decl.
5473
5bf46f05
PE
5474 * dispnew.c: Make symbols static if they're not exported.
5475 * dispextern.h (redraw_garbaged_frames, scrolling):
5476 (increment_row_positions): Remove.
5477 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5478 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5479 Now static.
5480 (redraw_garbaged_frames): Remove; unused.
5481
435f4c28
PE
5482 * xfaces.c: Make symbols static if they're not exported.
5483 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5484 Remove decls.
5485 * xterm.h (defined_color): Remove decls.
5486 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5487 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5488 (menu_face_changed_default, defined_color, free_realized_face):
5489 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5490 (ascii_face_of_lisp_face): Remove; unused.
5491
8524aef3
PE
5492 * xdisp.c: Make symbols static if they're not exported.
5493 * dispextern.h (scratch_glyph_row, window_box_edges):
5494 (glyph_to_pixel_coords, set_cursor_from_row):
5495 (get_next_display_element, set_iterator_to_next):
5496 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5497 (show_mouse_face): Remove decls
5498 * frame.h (message_buf_print): Likewise.
5499 * lisp.h (pop_message, set_message, check_point_in_composition):
5500 Likewise.
5501 * xterm.h (set_vertical_scroll_bar): Likewise.
5502 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5503 (message_buf_print, scratch_glyph_row, displayed_buffer):
5504 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5505 (get_next_display_element, show_mouse_face, window_box_edges):
5506 (frame_to_window_pixel_xy, check_point_in_composition):
5507 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5508 (glyph_to_pixel_coords): Remove; unused.
5509
16390cd2
PE
5510 * dired.c (file_name_completion): Now static.
5511
5512 * dbusbind.c (xd_in_read_queued_messages): Now static.
5513
a25f4dfa
PE
5514 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5515 * data.c (circular_list_error): Remove.
5516
14a9c8df
PE
5517 * commands.h (last_point_position, last_point_position_buffer):
5518 (last_point_position_window): Remove decls.
5519 * keyboard.c: Make these variables static.
5520
04f2d78b
CB
5521 * coding.h (coding, code_convert_region, encode_coding_gap):
5522 Remove decls.
74ab6df5
PE
5523 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5524 (iso_code_class, detect_coding, code_convert_region): Now static.
5525 (encode_coding_gap): Remove; unused.
5526
38dfbee1
PE
5527 * chartab.c (chartab_chars, chartab_bits): Now static.
5528
a2cb4e63
PE
5529 * charset.h (charset_iso_8859_1): Remove decl.
5530 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5531 Now static.
5532
127198fd
PE
5533 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5534 * ccl.c (Vccl_program_table): Now static.
5535 (check_ccl_update): Remove; unused.
5536
d85b608f
PE
5537 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5538 * category.h: ... from here.
5539 * category.c (check_category_table, set_category_set): Now static.
5540
31cd66f3
PE
5541 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5542 * lisp.h: Remove these decls.
5543
c358e587
PE
5544 * buffer.c (buffer_count): Remove unused var.
5545
e78aecca
PE
5546 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5547 so that it's not optimized away.
5548 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5549 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5550 exported only to the debugger.
5551
e192d7d3 5552 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5553 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5554
92470028
PE
5555 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5556 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5557 was inaccessible from Lisp.
5558 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5559 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5560
244ed907
PE
5561 alloc.c: Import and export fewer symbols, and remove unused items.
5562 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5563 is defined.
5564 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5565 it's not optimized away by whole-program optimization.
5566 (message_enable_multibyte, free_misc): Remove.
5567 (catchlist, handlerlist, mark_backtrace):
5568 Declare only if BYTE_MARK_STACK.
5569 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5570 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5571 (message_enable_multibyte): Remove decl.
5572 (free_misc, interval_free_list, float_block, float_block_index):
5573 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5574 (cons_free_list, last_marked_index):
5575 Now static.
5576 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5577 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5578 (mark_backtrace): Define only if BYTE_MARK_STACK.
5579 * xdisp.c (message_enable_multibyte): Now static.
5580
61c2b50e 5581 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5582 This makes it easier for human readers (and static analyzers)
5583 to see whether these variables are used from other modules.
5584 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5585 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5586 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5587 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5588 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5589 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5590 * xmenu.c, xselect.c:
5591 Declare Q* vars static if they are not used in other modules.
5592 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5593 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5594 Remove decls of unexported vars.
5595 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5596
95c82688
PE
5597 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5598
16a97296
PE
5599 Make Emacs functions such as Fatom 'static' by default.
5600 This makes it easier for human readers (and static analyzers)
5601 to see whether these functions can be called from other modules.
5602 DEFUN now defines a static function. To make the function external
5603 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5604 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5605 (Finit_image_library):
16a97296
PE
5606 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5607 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5608 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5609 Remove decls, since these functions are now static.
5610 (Funintern, Fget_internal_run_time): New decls, since these functions
5611 were already external.
95c82688 5612
16a97296
PE
5613 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5614 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5615 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5616 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5617 * keyboard.c, keymap.c, lread.c:
5618 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5619 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5620 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5621 Mark functions with DEFUE instead of DEFUN,
5622 if they are used in other modules.
5623 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5624 decls for now-static functions.
5625 * buffer.h (Fdelete_overlay): Remove decl.
5626 * callproc.c (Fgetenv_internal): Mark as internal.
5627 * composite.c (Fremove_list_of_text_properties): Remove decl.
5628 (Fcomposition_get_gstring): New forward static decl.
5629 * composite.h (Fcomposite_get_gstring): Remove decl.
5630 * dired.c (Ffile_attributes): New forward static decl.
5631 * doc.c (Fdocumntation_property): New forward static decl.
5632 * eval.c (Ffetch_bytecode): New forward static decl.
5633 (Funintern): Remove extern decl; now in .h file where it belongs.
5634 * fileio.c (Fmake_symbolic_link): New forward static decl.
5635 * image.c (Finit_image_library): New forward static decl.
5636 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5637 * intervals.h (Fprevious_property_change):
5638 (Fremove_list_of_text_properties): Remove decls.
5639 * keyboard.c (Fthis_command_keys): Remove decl.
5640 (Fcommand_execute): New forward static decl.
5641 * keymap.c (Flookup_key): New forward static decl.
5642 (Fcopy_keymap): Now static.
5643 * keymap.h (Flookup_key): Remove decl.
5644 * process.c (Fget_process): New forward static decl.
5645 (Fprocess_datagram_address): Mark as internal.
5646 * syntax.c (Fsyntax_table_p): New forward static decl.
5647 (skip_chars): Remove duplicate decl.
5648 * textprop.c (Fprevious_property_change): New forward static decl.
5649 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5650 Now internal.
5651 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5652 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5653
785bbd42
PE
5654 * editfns.c (Fformat): Remove unreachable code.
5655
8b913b57
AS
56562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5657
5658 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5659 change. (Bug#8496)
5660
a6744a35
EZ
56612011-04-13 Eli Zaretskii <eliz@gnu.org>
5662
5663 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5664 when at ZV. (Bug#8487)
5665
e7974947
AS
56662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5667
baad03f0
AS
5668 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5669 (Bug#8437)
5670 * keyboard.c (parse_tool_bar_item): Likewise.
5671 * sound.c (sound_cleanup, alsa_close): Likewise.
5672 * termcap.c (tgetent): Likewise.
5673 * xfns.c (x_default_font_parameter): Likewise.
5674 * xsettings.c (read_and_apply_settings): Likewise.
5675
e7974947
AS
5676 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5677 (overrun_check_free): Protoize.
5678
28272684
PE
56792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5680
5681 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5682 since callers should never pass a negative size.
5683 Change the signature to match that of plain 'read' and 'write'; see
5684 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5685 * lisp.h: Update prototypes of emacs_write and emacs_read.
5686
11997c76
EZ
56872011-04-11 Eli Zaretskii <eliz@gnu.org>
5688
5689 * xdisp.c (redisplay_window): Don't try to determine the character
5690 position of the scroll margin if the window start point w->startp
e896f03c 5691 is outside the buffer's accessible region. (Bug#8468)
11997c76 5692
8a2cbd72
EZ
56932011-04-10 Eli Zaretskii <eliz@gnu.org>
5694
5695 Fix write-region and its subroutines for buffers > 2GB.
5696 * fileio.c (a_write, e_write): Modify declaration of arguments and
5697 local variables to support buffers larger than 2GB.
5698 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5699
5700 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5701 argument, local variables, and return value.
5702
5703 * lisp.h: Update prototypes of emacs_write and emacs_read.
5704
5705 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5706
4073e537 57072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5708
1ebfdcb6
PE
5709 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5710
b2ded58d
PE
5711 Fix more problems found by GCC 4.6.0's static checks.
5712
7d66342c
PE
5713 * xdisp.c (vmessage): Use a better test for character truncation.
5714
bbf47d44
PE
5715 * charset.c (load_charset_map): <, not <=, for optimization,
5716 and to avoid potential problems with integer overflow.
9248994d 5717 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5718 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5719 * editfns.c (Fformat): Likewise.
1e69125e 5720 * syntax.c (skip_chars): Likewise.
3befa583 5721
e3019616
PE
5722 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5723 This also lets GCC 4.6.0 generate slightly better loop code.
5724
becfa255
PE
5725 * callint.c (Fcall_interactively): <, not <=, for optimization.
5726 (Fcall_interactively): Count the number of arguments produced,
5727 not the number of arguments given. This is simpler and lets GCC
5728 4.6.0 generate slightly better code.
5729
dae0cd48
PE
5730 * ftfont.c: Distingish more carefully between FcChar8 and char.
5731 The previous code passed unsigned char * to a functions like
5732 strlen and xstrcasecmp that expect char *, which does not
5733 conform to the C standard.
5734 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5735 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5736 char * when the C standard requires it.
5737
76032d70
PE
5738 * keyboard.c (read_char): Remove unused var.
5739
eb3f1cc8
PE
5740 * eval.c: Port to Windows vsnprintf (Bug#8435).
5741 Include <limits.h>.
5742 (SIZE_MAX): Define if the headers do not.
5743 (verror): Do not give up if vsnprintf returns a negative count.
5744 Instead, grow the buffer. This ports to Windows vsnprintf, which
5745 does not conform to C99. Problem reported by Eli Zaretskii.
5746 Also, simplify the allocation scheme, by avoiding the need for
5747 calling realloc, and removing the ALLOCATED variable.
5748
70476b54
PE
5749 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5750
12020a9e
PE
5751 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5752 But keep the doprint source code for now, as we might revamp it
5753 and use it again (Bug#8435).
ea6c7ae6
PE
5754 * lisp.h (doprnt): Remove.
5755 * Makefile.in (base_obj): Remove doprnt.o.
5756 * deps.mk (doprnt.o): Remove.
5757
5fdb398c
PE
5758 error: Print 32- and 64-bit integers portably (Bug#8435).
5759 Without this change, on typical 64-bit hosts error ("...%d...", N)
5760 was used to print both 32- and 64-bit integers N, which relied on
5761 undefined behavior.
5762 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5763 New macro.
5764 * lisp.h (error, verror): Mark as printf-like functions.
5765 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5766 Report overflow in size calculations when allocating printf buffer.
5767 Do not truncate output string at its first null byte.
5768 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5769 Truncate the output at a character boundary, since vsnprintf does not
5770 do that.
5771 * charset.c (check_iso_charset_parameter): Convert internal
5772 character to string before calling 'error', since %c now has the
5773 printf meaning.
5774 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5775 overflow when computing char to be passed to 'error'. Do not
5776 pass Lisp_Object to 'error'; pass the integer instead.
5777 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5778 formatted with plain %d.
5779
b189fa66
PE
5780 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5781
bff87ef0
PE
5782 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5783
7e2cac20
PE
5784 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5785
ce4d90b5
PE
5786 * xterm.c (x_catch_errors): Remove duplicate declaration.
5787
266c9547
PE
5788 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5789
79c49ad2
PE
5790 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5791
368f4090
JM
57922011-04-10 Jim Meyering <meyering@redhat.com>
5793
5794 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5795 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5796 return ssize_t not "int", and use size_t as the buffer length.
5797 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5798 * gnutls.h: Update declarations.
5799 * process.c (read_process_output): Use ssize_t, to match.
5800 (send_process): Likewise.
5801
a32d4040
CY
58022011-04-09 Chong Yidong <cyd@stupidchicken.com>
5803
5804 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5805
8546720e 58062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5807
04f2d78b
CB
5808 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5809 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5810
8546720e
GM
5811 * xterm.c (handle_one_xevent):
5812 * xmenu.c (create_and_show_popup_menu):
5813 * xselect.c (x_decline_selection_request)
5814 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5815
0a2f5c1a 58162011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5817
5818 Fix some uses of `int' instead of EMACS_INT.
5819 * search.c (string_match_1, fast_string_match)
5820 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5821 (scan_buffer, find_next_newline_no_quit)
5822 (find_before_next_newline, search_command, Freplace_match)
5823 (Fmatch_data): Make some `int' variables be EMACS_INT.
5824
5825 * xdisp.c (display_count_lines): 3rd argument and return value now
5826 EMACS_INT. All callers changed.
5827 (pint2hrstr): Last argument is now EMACS_INT.
5828
5829 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5830 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5831 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5832 (decode_coding_utf_16, decode_coding_emacs_mule)
5833 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5834 (decode_coding_ccl, decode_coding_charset)
5835 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5836 (decode_coding_iso_2022, decode_coding_emacs_mule)
5837 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5838 <char_offset, last_offset>: Declare EMACS_INT.
5839 (encode_coding_utf_8, encode_coding_utf_16)
5840 (encode_coding_emacs_mule, encode_invocation_designation)
5841 (encode_designation_at_bol, encode_coding_iso_2022)
5842 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5843 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5844 Declare EMACS_INT.
5845 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5846 (encode_invocation_designation): Last argument P_NCHARS is now
5847 EMACS_INT.
5848 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5849 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5850
5851 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5852 All users changed.
5853
5854 * ccl.c (Fccl_execute_on_string): Declare some variables
5855 EMACS_INT.
5856
8546720e 58572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5858
5859 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5860
4e19a977
CS
58612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5862
5863 * process.c (Fformat_network_address): Doc fix.
5864
87302331
R
58652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5866
5867 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5868
cbb59342
CY
58692011-04-08 Chong Yidong <cyd@stupidchicken.com>
5870
5871 * keyboard.c (read_char): Call Lisp function help-form-show,
5872 instead of using internal_with_output_to_temp_buffer.
5873 (Qhelp_form_show): New var.
e0d38eeb 5874 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5875
5876 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5877
5878 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5879
e67a13ab
CY
58802011-04-06 Chong Yidong <cyd@stupidchicken.com>
5881
04f2d78b
CB
5882 * process.c (Flist_processes): Remove to Lisp.
5883 (list_processes_1): Delete.
e67a13ab 5884
973f782d
EZ
58852011-04-06 Eli Zaretskii <eliz@gnu.org>
5886
7c106b1e
EZ
5887 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5888
973f782d
EZ
5889 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5890
41cf7d1a 58912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5892
ca23cc88
PE
5893 Fix more problems found by GCC 4.6.0's static checks.
5894
f390e2d5
PE
5895 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5896
42eea0d0
PE
5897 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5898
b69769da 5899 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5900
f9541e84
PE
5901 * xdisp.c (vmessage): Mark as a printf-like function.
5902
13841b55
PE
5903 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5904
c136c10f
PE
5905 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5906
5e2d4a30
PE
5907 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5908 printf-like functions.
5909 (tiff_load): Add casts to remove these marks before passing them
5910 to system-supplied API.
5911
583f48b9
PE
5912 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5913
b25d760e
PE
5914 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5915 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5916 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5917 directly, rather than having caller test rule sign. This avoids
5918 some unnecessary tests.
5919 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5920 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5921 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5922
bc7b6697 5923 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5924 (xfont_open): Avoid unnecessary tests.
bc7b6697 5925
27ccc379
PE
5926 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5927
dcd5c89a
PE
5928 * composite.h, composite.c (composition_gstring_put_cache):
5929 Use EMACS_INT, not int, for length.
5930
b13a45c6
PE
5931 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5932 breaking out part of COMPOSITION_DECODE_RULE.
5933 (COMPOSITION_DECODE_RULE): Use it.
5934 * composite.c (get_composition_id): Remove unused local vars,
5935 by using the new macro.
5936
1e792e4d
PE
5937 * textprop.c (set_text_properties_1): Change while to do-while,
5938 since the condition is always true at first.
5939
dc6c6455 5940 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5941 (interval_deletion_adjustment): Return unsigned value.
5942 All uses changed.
dc6c6455 5943
aba7731a
PE
5944 * process.c (list_processes_1, create_pty, read_process_output):
5945 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5946 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5947 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5948 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5949 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5950
fdfc4bf3
PE
5951 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5952
fca8fe46 5953 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5954 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5955
06a0259a 5956 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5957 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5958 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5959
e7b9e80f
PE
5960 * print.c (print_error_message): Avoid int overflow.
5961
56201685
PE
5962 * font.c (font_list_entities): Redo for clarity,
5963 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5964
78834453 5965 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5966 (font_score): Avoid potential overflow in diff calculation.
78834453 5967
0bc0b309 5968 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5969 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5970
e610eaca
PE
5971 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5972
b895abce
PE
5973 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5974 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5975 can always succeed if overflow has undefined behavior.
5976
1f1d9321 5977 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5978 (wordify): Omit three unnecessary tests.
1f1d9321 5979
c59478bc
PE
5980 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5981 All callers changed. This avoids the need for an unused var.
5982
79b73827
PE
5983 * casefiddle.c (casify_region): Remove var that is set but not used.
5984
a4db5dfe
PE
5985 * dired.c (file_name_completion): Remove var that is set but not used.
5986
43aae36e
PE
5987 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5988
2a47c44d 5989 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5990 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5991
a37c69bf
PE
5992 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5993 Check for integer overflow on size calculations.
5994
328ab8e7
PE
5995 * buffer.c (Fprevious_overlay_change): Remove var that is set
5996 but not used.
5997
e5a2a5cb
PE
5998 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5999 Remove vars that are set but not used.
8d84a6eb 6000 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6001 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6002
a60e5f68
PE
6003 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6004
f661cb61 6005 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6006 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6007
f0397f5a
PE
6008 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6009 that are set but not used.
6010
8664db06 6011 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6012 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6013
6abdaa4a
PE
6014 * xselect.c (x_get_local_selection, x_handle_property_notify):
6015 Remove vars that are set but not used.
6016
0ce7538d 6017 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6018 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6019
9ae848fc
PE
6020 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6021 Remove var that is set but not used.
0b918413
PE
6022 (scroll_bar_windows_size): Now size_t, not int.
6023 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6024 Check for overflow.
9ae848fc 6025
a5a62657
PE
6026 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6027 (map_tty_color) [!defined MSDOS]: Likewise.
6028
5c5cdd39
PE
6029 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6030
66ebf983
PE
6031 * coding.c: Remove vars that are set but not used.
6032 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6033 All callers changed.
6034 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6035 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6036 (decode_coding_charset): Remove vars that are set but not used.
6037
1be4d761
PE
6038 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6039 that is set but not used.
6040
47553fa8
PE
6041 * print.c (print_object): Remove var that is set but not used.
6042
1f7196bf 6043 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6044 The gnulib version avoids calling malloc in the usual case,
6045 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6046 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6047 * filelock.c (current_lock_owner): Likewise.
6048 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6049 * sysdep.c: Include allocator.h, careadlinkat.h.
6050 (emacs_no_realloc_allocator): New static constant.
6051 (emacs_readlink): New function.
fdb61804
PE
6052 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6053 ../lib/careadlinkat.h.
d1fdcab7 6054
f84c17c7
SM
60552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6056
6057 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6058 first non-nil return value).
6059
ef3862ad
JD
60602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6061
6062 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6063 if not defined (Bug#8403).
6064
376a7006
JB
60652011-04-02 Juanma Barranquero <lekktu@gmail.com>
6066
6067 * xdisp.c (display_count_lines): Remove parameter `start',
6068 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6069 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6070 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6071 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6072 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6073 and thereabouts. All callers changed.
6074 (get_per_char_metric): Remove parameter `f', unused since
6075 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6076
6ca3801d
JM
60772011-04-02 Jim Meyering <meyering@redhat.com>
6078
6079 do not dereference NULL upon failed strdup
6080 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6081 (ns_get_family): Likewise.
6082
d8e2b5ba
JB
60832011-04-02 Juanma Barranquero <lekktu@gmail.com>
6084
6085 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6086
8c74fcbd
JD
60872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6088
6089 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6090 later (Bug#8403).
6091
7200d79c
SM
60922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6093
03408648 6094 Add lexical binding.
7200d79c 6095
03408648
SM
6096 * window.c (Ftemp_output_buffer_show): New fun.
6097 (Fsave_window_excursion):
6098 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6099
6100 * lread.c (lisp_file_lexically_bound_p): New function.
6101 (Fload): Bind Qlexical_binding.
6102 (readevalloop): Remove `evalfun' arg.
6103 Bind Qinternal_interpreter_environment.
6104 (Feval_buffer): Bind Qlexical_binding.
6105 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6106 Mark as dynamic.
6107 (syms_of_lread): Declare `lexical-binding'.
6108
6109 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6110
6111 * keyboard.c (eval_dyn): New fun.
6112 (menu_item_eval_property): Use it.
ca105506
SM
6113
6114 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6115
03408648
SM
6116 * fns.c (concat, mapcar1): Accept byte-code-functions.
6117
6118 * eval.c (Fsetq): Handle lexical vars.
6119 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6120 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6121 (FletX, Flet): Obey lexical binding.
6122 (Fcommandp): Handle closures.
6123 (Feval): New `lexical' arg.
6124 (eval_sub): New function extracted from Feval. Use it almost
6125 everywhere where Feval was used. Look up vars in lexical env.
6126 Handle closures.
6127 (Ffunctionp): Move from subr.el.
6128 (Ffuncall): Handle closures.
6129 (apply_lambda): Remove `eval_flags'.
6130 (funcall_lambda): Handle closures and new byte-code-functions.
6131 (Fspecial_variable_p): New function.
6132 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6133 but without exporting it to Lisp.
23aba0ea 6134
23aba0ea 6135 * doc.c (Fdocumentation, store_function_docstring):
03408648 6136 * data.c (Finteractive_form): Handle closures.
23aba0ea 6137
03408648
SM
6138 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6139 interactive spec.
ba83908c 6140
04f2d78b
CB
6141 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6142 New byte-codes.
03408648
SM
6143 (exec_byte_code): New function extracted from Fbyte_code to handle new
6144 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6145
03408648 6146 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6147
03408648 6148 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6149
e2abce01
JB
61502011-03-31 Juanma Barranquero <lekktu@gmail.com>
6151
6152 * xdisp.c (redisplay_internal): Fix prototype.
6153
63696a73 61542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6155
63696a73 6156 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6157 (try_scrolling): Use it when setting scroll_limit.
6158 Limit scrolling to 100 screen lines.
63696a73
EZ
6159 (redisplay_window): Even when falling back on "recentering",
6160 position point in the window according to scroll-conservatively,
6161 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6162
6163 (try_scrolling): When point is above the window, allow searching
6164 as far as scroll_max, or one screenful, to compute vertical
6165 distance from PT to the scroll margin position. This prevents
6166 try_scrolling from unnecessarily failing when
6167 scroll-conservatively is set to a value slightly larger than the
6168 window height. Clean up the case of PT below the margin at bottom
6169 of window: scroll_max can no longer be INT_MAX. When aggressive
6170 scrolling is in use, don't let point enter the opposite scroll
6171 margin as result of the scroll.
6172 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6173 threshold of 100 lines for never-recentering scrolling.
6174
e4cc2dfc
JB
61752011-03-31 Juanma Barranquero <lekktu@gmail.com>
6176
6177 * dispextern.h (move_it_by_lines):
6178 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6179 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6180 (message_log_check_duplicate): Remove parameters `prev_bol' and
6181 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6182 (redisplay_internal): Remove parameter `preserve_echo_area',
6183 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6184
6185 * indent.c (Fvertical_motion):
6186 * window.c (window_scroll_pixel_based, Frecenter):
6187 Don't pass `need_y_p' to `move_it_by_lines'.
6188
1c470562
SM
61892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6190
44f230aa
SM
6191 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6192 steal a few bits to be more compact.
6193 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6194 Remove unneeded casts.
6195
1c470562
SM
6196 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6197
888adce9
ZK
61982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6199
6200 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6201 binding" message (bug#7967).
6202
f838ed7b
PE
62032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6204
77861b95
PE
6205 Fix more problems found by GCC 4.6.0's static checks.
6206
de6dbc14
PE
6207 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6208 Remove unused local var.
6209
f838ed7b
PE
6210 * editfns.c (Fmessage_box): Remove unused local var.
6211
792c7b2b
PE
6212 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6213 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6214 Omit unused local vars.
c499e557 6215 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6216 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6217 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6218 Omit unused local var.
6219
ba0165e1
PE
6220 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6221 Don't assume string length fits in int.
32ad8845 6222 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6223 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6224
3c59b4c9
PE
6225 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6226 instead of alloca (Bug#8344).
6227
a3eed478 6228 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6229 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6230
eb4d412d
PE
6231 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6232
1658b401
PE
6233 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6234 concerns.
6235
6236 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6237
6238 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6239
9a2c6e05
PE
6240 * keyboard.c (syms_of_keyboard): Use the same style as later
6241 in this function when indexing through an array. This also
6242 works around GCC bug 48267.
6243
03d0a109
PE
6244 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6245
44f730c8
PE
6246 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6247
fe75f926
PE
6248 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6249 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6250
ffa8c828
PE
6251 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6252 This avoids undefined behavior on integer overflow, and is a bit
6253 more convenient anyway since it is compared to a size_t variable.
6254
c5101a77
PE
6255 Variadic C functions now count arguments with size_t, not int.
6256 This avoids an unnecessary limitation on 64-bit machines, which
6257 caused (substring ...) to crash on large vectors (Bug#8344).
6258 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6259 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6260 All variadic functions and their callers changed accordingly.
c5101a77
PE
6261 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6262 * data.c (arith_driver, float_arith_driver): Likewise.
6263 * editfns.c (general_insert_function): Likewise.
6264 * eval.c (struct backtrace.nargs, interactive_p)
6265 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6266 (funcall_lambda, mark_backtrace): Likewise.
6267 * fns.c (concat): Likewise.
6268 * frame.c (x_set_frame_parameters): Likewise.
6269 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6270 0 if not found, not -1. All callers changed.
6271
dd3f25f7
PE
6272 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6273 (stack_copy_size): Now size_t, not int.
6274 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6275
461c2ab9
JB
62762011-03-28 Juanma Barranquero <lekktu@gmail.com>
6277
6278 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6279 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6280 All callers changed.
6281
6282 * lisp.h (multibyte_char_to_unibyte):
6283 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6284 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6285 * character.h (CHAR_TO_BYTE8):
6286 * cmds.c (internal_self_insert):
6287 * editfns.c (general_insert_function):
6288 * keymap.c (push_key_description):
6289 * search.c (Freplace_match):
6290 * xdisp.c (message_dolog, set_message_1): All callers changed.
6291
f6d62986
SM
62922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6293
6294 * keyboard.c (safe_run_hook_funcall): New function.
6295 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6296 don't set the hook to nil, but remove the offending function instead.
6297 (Qcommand_hook_internal): Remove, unused.
6298 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6299 Vcommand_hook_internal.
6300
6301 * eval.c (enum run_hooks_condition): Remove.
6302 (funcall_nil, funcall_not): New functions.
6303 (run_hook_with_args): Call each function through a `funcall' argument.
6304 Remove `cond' argument, now redundant.
6305 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6306 (Frun_hook_with_args_until_failure): Adjust accordingly.
6307 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6308
1db5b1ad
JB
63092011-03-28 Juanma Barranquero <lekktu@gmail.com>
6310
6311 * dispextern.h (string_buffer_position): Remove declaration.
6312
6313 * print.c (strout): Remove parameter `multibyte', unused since
6314 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6315
6316 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6317 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6318 All callers changed.
6319
6320 * w32.c (_wsa_errlist): Use braces for struct initializers.
6321
6322 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6323 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6324 All callers changed.
6325 (string_buffer_position): Likewise. Also, make static (it's never
6326 used outside xdisp.c).
6327 (cursor_row_p): Remove parameter `w', unused since
6328 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6329 (decode_mode_spec): Remove parameter `precision', introduced during
6330 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6331 All callers changed.
6332
5ffb62aa
JD
63332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6334
6335 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6336
461c2ab9 63372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6338
6339 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6340 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6341 (ns_update_auto_hide_menu_bar): New functions.
6342 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6343 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6344 ns_constrain_all_frames.
6345 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6346 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6347
5c380ffb
JD
63482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6349
6350 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6351
9af30bdf
GM
63522011-03-27 Glenn Morris <rgm@gnu.org>
6353
6354 * syssignal.h: Replace RETSIGTYPE with void.
6355 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6356 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6357 Replace SIGTYPE with void everywhere.
6358 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6359 * s/template.h (SIGTYPE): Remove commented out definition.
6360
e2abce01
JB
63612011-03-26 Eli Zaretskii <eliz@gnu.org>
6362
6363 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6364 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6365
f868cd8a
JB
63662011-03-26 Juanma Barranquero <lekktu@gmail.com>
6367
59eb0929
JB
6368 * w32.c (read_unc_volume): Use parameter `henum', instead of
6369 global variable `wget_enum_handle'.
6370
6371 * keymap.c (describe_vector): Remove parameters `indices' and
6372 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6373 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6374
f868cd8a
JB
6375 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6376
6377 * keyboard.c (timer_check): Remove parameter `do_it_now',
6378 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6379 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6380 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6381
6382 * keyboard.c (read_char):
6383 * w32menu.c (w32_menu_display_help):
6384 * xmenu.c (show_help_event, menu_help_callback):
6385 Adjust calls to `show_help_echo'.
6386
6387 * gtkutil.c (xg_maybe_add_timer):
6388 * keyboard.c (readable_events):
6389 * process.c (wait_reading_process_output):
6390 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6391
6392 * insdel.c (adjust_markers_gap_motion):
6393 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6394 (gap_left, gap_right): Don't call it.
6395
2ecf6fdb
CY
63962011-03-25 Chong Yidong <cyd@stupidchicken.com>
6397
6398 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6399 incurred during fontification.
6400
6b1f9ba4
JB
64012011-03-25 Juanma Barranquero <lekktu@gmail.com>
6402
6403 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6404 (DEFVAR_PER_BUFFER): Don't pass it.
6405
6406 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6407 (scrolling_window): Don't pass it.
6408
0f4a96b5
JB
64092011-03-25 Juanma Barranquero <lekktu@gmail.com>
6410
6411 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6412
6413 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6414 and `suffix'.
6415 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6416 of variables specific to SELinux and computation of `encoded_absname'.
6417
6418 * image.c (XPutPixel): Remove unused variable `height'.
6419
6420 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6421
6422 * unexw32.c (get_section_info): Remove unused variable `section'.
6423
6424 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6425 (system_process_attributes): Remove unused variable `sess'.
6426 (sys_read): Remove unused variable `err'.
6427
6428 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6429 (w32_wnd_proc): Remove unused variable `isdead'.
6430 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6431 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6432 (x_create_tip_frame): Remove unused variable `tem'.
6433
6434 * w32inevt.c (w32_console_read_socket):
6435 Remove unused variable `no_events'.
6436
6437 * w32term.c (x_draw_composite_glyph_string_foreground):
6438 Remove unused variable `width'.
6439
1149507c
JB
64402011-03-24 Juanma Barranquero <lekktu@gmail.com>
6441
6442 * w32term.c (x_set_glyph_string_clipping):
6443 Don't pass uninitialized region to CombineRgn.
6444
9c88f339
JB
64452011-03-23 Juanma Barranquero <lekktu@gmail.com>
6446
6447 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6448 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6449 (Fx_close_connection): Remove unused variable `i'.
6450
6451 * w32font.c (w32font_draw): Return number of glyphs.
6452 (w32font_open_internal): Remove unused variable `i'.
6453 (w32font_driver): Add missing initializer.
6454
6455 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6456 (fill_in_menu): Remove unused variable `items_added'.
6457
6458 * w32term.c (last_mouse_press_frame): Remove static global variable.
6459 (w32_clip_to_row): Remove unused variable `f'.
6460 (x_delete_terminal): Remove unused variable `i'.
6461
6462 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6463 (NOTHING): Remove unused static global variable.
6464 (uniscribe_check_otf): Remove unused variable `table'.
6465 (uniscribe_font_driver): Add missing initializers.
6466
dee091a3
JD
64672011-03-23 Julien Danjou <julien@danjou.info>
6468
6469 * term.c (Fsuspend_tty, Fresume_tty):
6470 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6471 * window.c (temp_output_buffer_show):
6472 * insdel.c (signal_before_change):
6473 * frame.c (Fhandle_switch_frame):
6474 * fileio.c (Fdo_auto_save):
6475 * emacs.c (Fkill_emacs):
6476 * editfns.c (save_excursion_restore):
6477 * cmds.c (internal_self_insert):
6478 * callint.c (Fcall_interactively):
6479 * buffer.c (Fkill_all_local_variables):
6480 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6481 Use Frun_hooks.
0f4a96b5 6482 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6483 unconditionnaly since it does the check itself.
6484
2c520ab5 64852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6486
c9c49752
PE
6487 Fix more problems found by GCC 4.5.2's static checks.
6488
8abc3f12
PE
6489 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6490 the first time through the loop, since we know p0 < p1 then.
6491 This also avoids a gcc -Wstrict-overflow warning.
6492
a2d26660
PE
6493 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6494 leading to a memory leak, possible in functions like
6495 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6496 of objects (Bug#8318).
a2d26660 6497
916c72e9
PE
6498 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6499 that could (at least in theory) be that large.
6500
19ab8a18
PE
6501 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6502 This is less likely to overflow, and avoids undefined behavior if
6503 overflow does occur. All callers changed. Use strtoul to scan
6504 for the unsigned long integer.
b7cbbd6f
PE
6505 (pint2hrstr): Simplify and tune code slightly.
6506 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6507
f0641eff
PE
6508 * scroll.c (do_scrolling): Work around GCC bug 48228.
6509 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6510
7f650bb9
PE
6511 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6512 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6513 (validate_x_resource_name): Simplify count usage.
6514 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6515
37dd57d1
PE
6516 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6517 fail (Bug#8306).
81e56e61 6518
699979fc 6519 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6520
401bf9b4
PE
6521 * process.c (Fmake_network_process): Use socklen_t, not int,
6522 where POSIX says socklen_t is required in portable programs.
6523 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6524 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6525 (Fmake_network_process, server_accept_connection):
6526 (wait_reading_process_output, read_process_output):
6527 Likewise.
6528
b93aacde
PE
6529 * process.c: Rename or move locals to avoid shadowing.
6530 (list_processes_1, Fmake_network_process):
6531 (read_process_output_error_handler, exec_sentinel_error_handler):
6532 Rename or move locals.
4dc343ee 6533 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6534 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6535 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6536 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6537 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6538
af8a867c 6539 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6540 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6541 Include tparam.h instead, since it declares them.
af8a867c
PE
6542 * cm.h (PC): Remove extern decl; tparam.h now does this.
6543 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6544 * terminfo.c: Include tparam.h, to check interfaces.
6545 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6546 (tparam): Adjust signature to match interface in tparam.h;
6547 this removes some undefined behavior. Check that outstring and len
6548 are zero, which they always are with Emacs.
6549 * tparam.h (PC, BC, UP): New extern decls.
6550
0248044d 6551 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6552 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6553
8ff096c1 6554 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6555 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6556 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6557 (ftfont_list): Remove unused local.
49eaafba
PE
6558 (get_adstyle_property, ftfont_pattern_entity):
6559 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6560 Rename locals to avoid shadowing.
8ff096c1 6561
e2be39f6
PE
6562 * xfont.c (xfont_list_family): Mark var as initialized.
6563
c9735e30
PE
6564 * xml.c (make_dom): Now static.
6565
8f5201ae
PE
6566 * composite.c (composition_compute_stop_pos): Rename local to
6567 avoid shadowing.
b246f932
PE
6568 (composition_reseat_it): Remove unused locals.
6569 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6570 (composition_update_it): Mark var as initialized.
11b61122
PE
6571 (find_automatic_composition): Mark vars as initialized,
6572 with a FIXME (Bug#8290).
8f5201ae 6573
760fbc2c
PE
6574 character.h: Rename locals to avoid shadowing.
6575 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6576 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6577 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6578 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6579 to avoid shadowing.
6580
ff08eb85
PE
6581 * textprop.c (property_change_between_p): Remove; unused.
6582
fc7bf025
PE
6583 * intervals.c (interval_start_pos): Now static.
6584
235d7abc
PE
6585 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6586
44f230aa
SM
6587 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6588 Rename locals to avoid shadowing.
3e7d6594 6589
50060332
PE
6590 * sound.c (wav_play, au_play, Fplay_sound_internal):
6591 Fix pointer signedness.
d01f234b 6592 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6593 (wav_play): Initialize a variable to 0, to prevent undefined
6594 behavior (Bug#8278).
50060332 6595
c4fc4e30
PE
6596 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6597
918436ed
PE
6598 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6599
c939f91b
PE
6600 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6601 clobbering (Bug#8298).
b9c7f648
PE
6602 * sysdep.c (sys_subshell): Likewise.
6603 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6604
6bd8c144
PE
6605 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6606 This should get cleaned up, so that child_setup has the
6607 same signature on all platforms.
6608
7710357c 6609 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6610 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6611
c59da222
CY
66122011-03-22 Chong Yidong <cyd@stupidchicken.com>
6613
6614 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6615 not to be necessary, and produces flickering.
6616
66b87493
GM
66172011-03-20 Glenn Morris <rgm@gnu.org>
6618
6619 * config.in: Remove file.
6620
45b6f6d5
JB
66212011-03-20 Juanma Barranquero <lekktu@gmail.com>
6622
6623 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6624 are now in src/globals.h.
6625 (syms_of_minibuf): Remove spurious & from previous change.
6626
3ec03f7e
LL
66272011-03-20 Leo <sdl.web@gmail.com>
6628
6629 * minibuf.c (completing-read-function): New variable.
6630 (completing-read-default): Rename from completing-read.
6631 (completing-read): Call completing-read-function.
6632
b14e3e21
CY
66332011-03-19 Juanma Barranquero <lekktu@gmail.com>
6634
6635 * xfaces.c (Fx_load_color_file):
6636 Read color file from absolute filename (bug#8250).
6637
f2b726e6
JB
66382011-03-19 Juanma Barranquero <lekktu@gmail.com>
6639
6640 * makefile.w32-in: Update dependencies.
6641
09f6ff02
EZ
66422011-03-17 Eli Zaretskii <eliz@gnu.org>
6643
6644 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6645
29a6015a
PE
66462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6647
a3a6c54e
PE
6648 Fix more problems found by GCC 4.5.2's static checks.
6649
b766f867
PE
6650 * process.c (make_serial_process_unwind, send_process_trap):
6651 (sigchld_handler): Now static.
6652
be02381c
PE
6653 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6654 That way, the code declares only the vars that it needs.
6655 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6656 * s/cygwin.h (PTY_ITERATION): Likewise.
6657 * s/darwin.h (PTY_ITERATION): Likewise.
6658 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6659
57048744
PE
6660 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6661 * process.c (allocate_pty): Don't declare stb unless it's needed.
6662
7914961c 6663 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6664 (CONSTANTLIM): Remove; unused.
6665 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6666 Define only if needed.
7914961c 6667
b3967b18
PE
6668 * unexelf.c (unexec): Name an expression,
6669 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6670 Use a different way to cause a compilation error if anyone uses
6671 n rather than nn, a way that does not involve shadowing.
73366a00 6672 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6673
29a6015a
PE
6674 * deps.mk (unexalpha.o): Remove; unused.
6675
43cfc33e 6676 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6677 * unexec.h: New file.
ce701a33
PE
6678 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6679 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6680 Depend on unexec.h.
6681 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6682 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6683 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6684 Change as necessary to match prototype in unexec.h.
ce701a33 6685
01f44d5a
PE
6686 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6687 shadowing.
4f63c6bb 6688 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6689
a6670b0b
PE
6690 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6691 Rename locals to avoid shadowing.
6692
cef2010d 6693 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6694 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6695
d4d7173a
PE
6696 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6697
f08b802a
PE
6698 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6699 warning when compiling print.c.
6700
3ddb0639
PE
6701 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6702 instead of using an uninitialized var.
5ad03b97 6703 (font_sort_entities): Mark var as initialized.
3ddb0639 6704
170a2692
PE
6705 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6706
e663c700
PE
6707 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6708 pointers to constants.
89bc529a 6709 (font_parse_fcname): Remove unused vars.
7b81e2d0 6710 (font_delete_unmatched): Now static.
ea838e10 6711 (font_get_spec): Remove; unused.
13a547c6
PE
6712 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6713 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6714 Rename or move locals to avoid shadowing.
e663c700 6715
2a80c887 6716 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6717 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6718
1384fa33 6719 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6720 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6721
8b2c52e9
PE
6722 * alloc.c (mark_backtrace): Move decl from here ...
6723 * lisp.h: ... to here, so that it can be checked.
6724
475545b5 6725 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6726 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6727 (lisp_indirect_variable): Name an expression,
6728 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6729 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6730
b1349114 6731 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6732 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6733 Use const pointer when appropriate.
b1349114 6734
a2928364
PE
6735 * lisp.h (get_system_name, get_operating_system_release):
6736 Move decls here, to check interfaces.
6737 * process.c (get_operating_system_release): Move decl to lisp.h.
6738 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6739 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6740 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6741 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6742 (Fformat_time_string, Fencode_time, Finsert_char):
6743 (Ftranslate_region_internal, Fformat):
6744 Rename or remove local vars to avoid shadowing.
9710023e 6745 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6746
a415e694
PE
6747 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6748 avoid shadowing.
6749
8ef4622d
PE
6750 * lisp.h (eassert): Check that the argument compiles, even if
6751 ENABLE_CHECKING is not defined.
6752
946f9a5b
PE
6753 * data.c (Findirect_variable): Name an expression, to avoid
6754 gcc -Wbad-function-cast warning.
112396d6 6755 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6756 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6757 (Fmake_variable_buffer_local, Fmake_local_variable):
6758 Mark variables as initialized.
52746918 6759 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6760
e5aab7e7 6761 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6762 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6763 Rename locals to avoid shadowing.
dff45157
PE
6764 (mark_stack): Move local variables into the #ifdef region where
6765 they're used.
7bc26fdb
PE
6766 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6767 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6768 needed otherwise.
6769 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6770 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6771 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6772
e5aab7e7
PE
6773 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6774 avoids undefined behavior in theory.
6775
4da60324
PE
6776 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6777
88043301
PE
6778 Use functions, not macros, for up- and down-casing (Bug#8254).
6779 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6780 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6781 to use the following functions instead of these macros.
6782 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6783 EMACS_INT, since callers assume the returned value fits in int.
6784 (upcase1): Likewise, for UPCASE_TABLE.
6785 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6786 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6787 the race-condition problem in the old DOWNCASE.
88043301 6788
19ed5445
PE
6789 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6790 Rename locals to avoid shadowing.
6791 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6792 (regex_compile, re_search_2, re_match_2_internal):
6793 Remove unused local vars.
952db0d7
PE
6794 (FREE_VAR): Rewrite so as not to use empty "else",
6795 which gcc can warn about.
da053e48 6796 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6797 (RETALLOC_IF): Define only if needed.
6798 (WORDCHAR_P): Likewise. This one is never needed, but is used
6799 only in a comment talking about a compiler bug, so put inside
6800 the #if 0 of that comment.
6801 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6802 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6803 Remove; unused.
19ed5445 6804
1f3561e4 6805 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6806 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6807 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6808
ded6f8f7
PE
6809 * search.c (simple_search): Remove unused var.
6810
dbd37a95
PE
6811 * dired.c (compile_pattern): Move decl from here ...
6812 * lisp.h: ... to here, so that it can be checked.
6813 (struct re_registers): New forward decl.
6814
7e47afad
PE
6815 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6816
85f24f61
PE
6817 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6818 All uses changed.
6819 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6820 Rename locals to avoid shadowing.
5671df8f 6821 (Fvertical_motion): Mark locals as initialized.
85f24f61 6822
181aa2be 6823 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6824 (casify_region): Mark local as initialized.
181aa2be 6825
930d429c
PE
6826 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6827
7082eac6
PE
6828 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6829 New macros, so that the caller can use some names other than
6830 gcpro1, gcpro2, etc.
6831 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6832 of the new macros.
6833 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6834 argument, for consistency with GCPRO2_VAR, etc: it is now the
6835 prefix of the variable, not the variable itself. All uses
6836 changed.
38b2c076
PE
6837 * dired.c (directory_files_internal, file_name_completion):
6838 Rename locals to avoid shadowing.
6839
15206ed9
PE
6840 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6841 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6842 dired.c's scmp function, had undefined behavior.
6843 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6844 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6845 * buffer.h: ... to here, because these macros use current_buffer,
6846 and the new implementation with inline functions needs to have
6847 current_buffer in scope now, rather than later when the macros
6848 are used.
6849 (downcase, upcase1): New static inline functions.
6850 (DOWNCASE, UPCASE1): Reimplement using these functions.
6851 This avoids undefined behavior in expressions like
6852 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6853 from race conditions in accessing the global variables
6854 case_temp1 and case_temp2.
6855 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6856 * lisp.h (case_temp1, case_temp2): Remove their decls.
6857 * character.h (ASCII_CHAR_P): Move from here ...
6858 * lisp.h: ... to here, so that the inline functions mentioned
6859 above can use them.
6860
4a6bea26
PE
6861 * dired.c (directory_files_internal_unwind): Now static.
6862
f14b7e14
PE
6863 * fileio.c (file_name_as_directory, directory_file_name):
6864 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6865 Now static.
2893f146
PE
6866 (file_name_as_directory): Use const pointers when appropriate.
6867 (Fexpand_file_name): Likewise. In particular, newdir might
6868 point at constant storage, so make it a const pointer.
fd4ead52 6869 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6870 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6871 signedness issues.
f839df0c
PE
6872 (Fset_file_times, Finsert_file_contents, auto_save_error):
6873 Rename locals to avoid shadowing.
f14b7e14 6874
5716756e 6875 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6876 (Ftry_completion, Fall_completions): Rename or remove locals
6877 to avoid shadowing.
5716756e 6878
b4c3046a
PE
6879 * marker.c (bytepos_to_charpos): Remove; unused.
6880
b45db522
PE
6881 * lisp.h (verify_bytepos, count_markers): New decls,
6882 so that gcc does not warn that these functions aren't declared.
6883
85876d07
PE
6884 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6885 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6886 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6887 (copy_text): Remove unused local var.
85876d07 6888
03d78a21 6889 * filelock.c (within_one_second): Now static.
b3dd38ab 6890 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6891
5df8f01b
PE
6892 * buffer.c (fix_overlays_before): Mark locals as initialized.
6893 (fix_start_end_in_overlays): Likewise. This function should be
6894 simplified by using pointers-to-pointers, but that's a different
6895 matter.
b1d876f1 6896 (switch_to_buffer_1): Now static.
8f54f30a
PE
6897 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6898 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6899
a70072c9 6900 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6901 Fix pointer signedness issue.
edced198
PE
6902 (sys_subshell): Mark local as volatile if checking for lint,
6903 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6904 (MAXPATHLEN): Define only if needed.
a70072c9 6905
a0977c44
PE
6906 * process.c (serial_open, serial_configure): Move decls from here ...
6907 * systty.h: ... to here, so that they can be checked.
6908
a884fdcc
PE
6909 * fns.c (get_random, seed_random): Move extern decls from here ...
6910 * lisp.h: ... to here, so that they can be checked.
6911
604efe86 6912 * sysdep.c (reset_io): Now static.
b8950c94 6913 (wait_for_termination_signal): Remove; unused.
604efe86 6914
38fc62d9
PE
6915 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6916 (copy_keymap_item, append_key, push_text_char_description):
6917 Now static.
1004a21a 6918 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6919 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6920 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6921 (describe_map_tree):
6922 Rename locals to avoid shadowing.
38fc62d9 6923
2f2650da
PE
6924 * keyboard.c: Declare functions static if they are not used elsewhere.
6925 (echo_char, echo_dash, cmd_error, top_level_2):
6926 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6927 (read_char, kbd_buffer_get_event, make_lispy_position):
6928 (make_lispy_event, make_lispy_movement, apply_modifiers):
6929 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6930 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6931 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6932 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6933 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6934
a053e86c 6935 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6936 (mark_kboards): Move decl here ...
6937 * alloc.c (mark_kboards): ... from here.
a053e86c 6938
4752793e
PE
6939 * lisp.h (force_auto_save_soon): New decl.
6940
74f10ca7 6941 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6942 (DEFINE_DUMMY_FUNCTION): New macro.
6943 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6944 Use it.
c03cd23f
PE
6945 (main): Add casts to avoid warnings
6946 if GCC considers string literals to be constants.
74f10ca7 6947
022e70d4
PE
6948 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6949
59d6fe83
PE
6950 * dbusbind.c: Pointer signedness fixes.
6951 (xd_signature, xd_append_arg, xd_initialize):
6952 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6953 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6954 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6955 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6956
78320123
PE
6957 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6958 if GCC considers string literals to be constants.
49cebcca 6959 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6960
35ac2a97
SM
69612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6962
fb103ca9
SM
6963 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6964 (print_preprocess, print_object): New macro to fix last change.
6965
35ac2a97
SM
6966 * print.c (print_preprocess): Don't forget font objects.
6967
62973b41
JB
69682011-03-16 Juanma Barranquero <lekktu@gmail.com>
6969
6970 * emacs.c (USAGE3): Doc fixes.
6971
0e48bb22
AS
69722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6973
6974 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6975 structure.
6976
7684e57b
JB
69772011-03-14 Juanma Barranquero <lekktu@gmail.com>
6978
6979 * lisp.h (VWindow_system, Qfile_name_history):
6980 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6981 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6982 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6983
6984 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6985 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6986
6987 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6988 * w32console.c (detect_input_pending, read_input_pending)
6989 (encode_terminal_code):
6990 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6991 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6992 (w32_system_caret_y, Qfile_name_history):
6993 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6994 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6995 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6996 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6997 * w32proc.c (Qlocal, report_file_error):
6998 * w32term.c (Vwindow_system, updating_frame):
6999 * w32uniscribe.c (initialized, uniscribe_font_driver):
7000 Remove unneeded extern declarations.
7001
2aa46d6c
CY
70022011-03-14 Chong Yidong <cyd@stupidchicken.com>
7003
c96bbc66 7004 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7005
cffc6f3b
CY
70062011-03-13 Chong Yidong <cyd@stupidchicken.com>
7007
7008 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7009 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7010 These macros can no longer be used for assignment.
7011
44f230aa
SM
7012 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7013 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7014 (record_buffer_markers, fetch_buffer_markers): New functions for
7015 recording and fetching special buffer markers.
7016 (set_buffer_internal_1, set_buffer_temp): Use them.
7017
7018 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7019
7020 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7021
7022 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7023 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7024
7025 * xdisp.c (hscroll_window_tree):
7026 (reconsider_clip_changes): Use PT instead of BUF_PT.
7027
d251f04b
EZ
70282011-03-13 Eli Zaretskii <eliz@gnu.org>
7029
7030 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7031 $(EMACS_ROOT)/lib/intprops.h.
7032
f0c77cd1
PE
70332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7034
3eca4629
PE
7035 Fix more problems found by GCC 4.5.2's static checks.
7036
7c86ee98
PE
7037 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7038 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7039 (xg_free_frame_widgets): Make it clear that a local variable is
7040 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7041 (gdk_window_get_screen): Make it clear that this macro is needed
7042 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7043 (int_gtk_range_get_value): New function, which avoids a diagnostic
7044 from gcc -Wbad-function-cast.
7045 (xg_set_toolkit_scroll_bar_thumb): Use it.
7046 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7047 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7048 (get_utf8_string, xg_get_file_with_chooser):
7049 Rename locals to avoid shadowing.
7050 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7051
41729b81
PE
7052 * xgselect.c (xg_select): Remove unused var.
7053
f0c77cd1
PE
7054 * image.c (four_corners_best): Mark locals as initialized.
7055 (gif_load): Initialize transparent_p to zero (Bug#8238).
7056 Mark another local as initialized.
ec6cf4c6 7057 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7058
ce0ad53d 7059 * image.c (clear_image_cache): Now static.
d5d5a617 7060 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7061 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7062 (x_edge_detection): Remove unnecessary cast that
7063 gcc -Wbad-function-cast diagnoses.
2037898d 7064 (gif_load): Fix pointer signedness.
6ae141d6
PE
7065 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7066 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7067
33383987 70682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7069
d32df629
PE
7070 Improve quality of tests for time stamp overflow.
7071 For example, without this patch (encode-time 0 0 0 1 1
7072 1152921504606846976) returns the obviously-bogus value (-948597
7073 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7074 reports time overflow. See
7075 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7076 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7077 * editfns.c: Include limits.h and intprops.h.
7078 (TIME_T_MIN, TIME_T_MAX): New macros.
7079 (time_overflow): Move earlier, to before first use.
7080 (hi_time, lo_time): New functions, for an accurate test for
7081 out-of-range times.
7082 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7083 (Fget_internal_run_time): Don't assume time_t fits in int.
7084 (make_time): Use list2 instead of Fcons twice.
7085 (Fdecode_time): More accurate test for out-of-range times.
7086 (check_tm_member): New function.
7087 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7088 (lisp_time_argument): Don't rely on undefined left-shift and
7089 right-shift behavior when checking for time stamp overflow.
8be6f318 7090
fe31d94c
PE
7091 * editfns.c (time_overflow): New function, refactoring common code.
7092 (Fformat_time_string, Fdecode_time, Fencode_time):
7093 (Fcurrent_time_string): Use it.
7094
8be6f318
PE
7095 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7096 * dired.c (make_time): Move to ...
7097 * editfns.c (make_time): ... here.
7098 * systime.h: Note the move.
7099
09d9db2c 71002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7101
126bc0dc
YM
7102 * fringe.c (update_window_fringes): Remove unused variables.
7103
c47cbdfd
YM
7104 * unexmacosx.c (copy_data_segment): Also copy __got section.
7105 (Bug#8223)
7106
7ac80be9
EZ
71072011-03-12 Eli Zaretskii <eliz@gnu.org>
7108
c96bbc66 7109 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7110 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7111 Constify `char *' arguments and their references according to
7112 prototypes in tparam.h.
7113
ecb0f94d 7114 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7115
7ac80be9
EZ
7116 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7117 Adapt all references accordingly.
7118
7119 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7120
ef1fd07e
TT
71212011-03-11 Tom Tromey <tromey@redhat.com>
7122
7123 * buffer.c (syms_of_buffer): Remove obsolete comment.
7124
7ef4b50c
EZ
71252011-03-11 Eli Zaretskii <eliz@gnu.org>
7126
7127 * termhooks.h (encode_terminal_code): Declare prototype.
7128
7129 * msdos.c (encode_terminal_code): Don't declare prototype.
7130
7131 * term.c (encode_terminal_code): Now external again, used by
7132 w32console.c and msdos.c.
7133
44f230aa
SM
7134 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7135 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7136
4b1ec863 71372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7138
1714f52b 7139 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7140
4b1ec863
PE
7141 * fringe.c (update_window_fringes): Mark locals as initialized
7142 (Bug#8227).
7143 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7144
524c7aa6
PE
7145 * alloc.c (mark_fringe_data): Move decl from here ...
7146 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7147 to check its interface.
7148 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7149
a5c0af81 7150 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7151 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7152 (fontset_font): Mark local as initialized.
a9a06e0b 7153 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7154
b4716021
PE
7155 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7156
811e9bac 7157 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7158 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7159 (x_own_selection, Fx_disown_selection_internal): Rename locals
7160 to avoid shadowing.
7161 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7162
7e3ab302
PE
7163 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7164 so that the caller can use some name other than gcpro1.
7165 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7166 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7167 (Fx_backspace_delete_keys_p):
7168 Use them to avoid shadowing, and rename vars to avoid shadowing.
7169 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7170 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7171 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7172 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7173 Remove unused locals.
7e3ab302
PE
7174 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7175 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7176 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7177 macros.
f78faa98 7178
e2b13473
PE
7179 * xterm.h (x_mouse_leave): New decl.
7180
77f23912
PE
7181 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7182 Remove unused functions.
cdf4ba58
PE
7183 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7184 (x_calc_absolute_position): Now static.
7411c686 7185 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7186 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7187 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7188 unless they are used.
38d0b34a
PE
7189 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7190 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7191 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7192 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7193 (x_error_catcher, x_connection_closed, x_error_handler):
7194 (x_error_quitter, xembed_send_message, x_iconify_frame):
7195 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7196 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7197 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7198
44f230aa
SM
7199 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7200 Rename or move locals to avoid shadowing.
6b463e58 7201 (tty_defined_color, merge_face_heights): Now static.
5967d051 7202 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7203 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7204 does not deduce is never used uninitialized.
73719eba
PE
7205 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7206 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7207
426994c3 7208 * terminal.c (store_terminal_param): Now static.
5489860b 7209
032f1620 7210 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7211 (set_frame_menubar): Remove unused local.
d4323972 7212 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7213 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7214 since they might point to immutable storage.
281585b0
PE
7215 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7216 since it's unused otherwise.
032f1620 7217
367c19e5 7218 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7219 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7220 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7221 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7222 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7223 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7224 does not deduce are never used uninitialized.
70739cbe 7225
07b48fa9
PE
7226 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7227
8868a238 7228 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7229 * window.c (window_loop, size_window):
7230 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7231
7e5cf297 7232 * window.c (display_buffer): Now static.
d6550a9f
PE
7233 (size_window): Mark variables that gcc -Wuninitialized
7234 does not deduce are never used uninitialized.
a586633d
PE
7235 * window.h (check_all_windows): New decl, to forestall
7236 gcc -Wmissing-prototypes diagnostic.
5b555da1 7237 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7238
f6095868
PE
7239 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7240 shadowing.
7241 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7242 Include <limits.h>.
7243 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7244 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7245 (load_charset_map): Mark variables that gcc -Wuninitialized
7246 does not deduce are never used uninitialized.
53df7c11 7247 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7248
f38b440c
PE
7249 * coding.c (coding_set_source, coding_set_destination):
7250 Use "else { /* comment */ }" rather than "else /* comment */;"
7251 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7252 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7253 a block, when the outer 'i' will do.
7254 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7255 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7256 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7257 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7258 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7259 Rename locals to avoid shadowing.
7260 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7261 * coding.c (emacs_mule_char, encode_invocation_designation):
7262 Now static, since they're not used elsewhere.
413bb2db 7263 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7264 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7265 (decode_coding_emacs_mule): Mark variables that gcc
7266 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7267 (detect_coding_iso_2022): Initialize a local variable that might
7268 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7269 this initialization is needed. (Bug#8211)
5f58e762
PE
7270 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7271 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7272 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7273 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7274 Remove unused macros.
f38b440c 7275
232b38b9 7276 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7277 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7278 * character.c (string_count_byte8): Likewise.
232b38b9 7279
fb90da1b
PE
7280 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7281 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7282
fb93dbc2
PE
7283 * chartab.c (copy_sub_char_table): Now static, since it's not used
7284 elsewhere.
5c156ace
PE
7285 (sub_char_table_ref_and_range, char_table_ref_and_range):
7286 Rename locals to avoid shadowing.
bbcd0949 7287 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7288
7d3b3862 7289 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7290 (BIDI_BOB): Remove unused macro.
7d3b3862 7291
6be7d3da
PE
7292 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7293 deduce are never used uninitialized.
c2ed9c8b 7294 * term.c (encode_terminal_code): Likewise.
6be7d3da 7295
75f8807f 7296 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7297
50938595
PE
7298 * tparam.h: New file.
7299 * term.c, tparam.h: Include it.
7300 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7301 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7302 Move these decls to tparam.h, and make them agree with what
7303 is actually in tparam.c. The previous trick of using incompatible
7304 decls in different modules does not conform to the C standard.
7305 All callers of tparam changed to use tparam's actual API.
7306 * tparam.c (tparam1, tparam, tgoto):
7307 Use const pointers where appropriate.
7308
fbceeba2
PE
7309 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7310 * cm.h (struct cm): Likewise.
7311 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7312 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7313 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7314 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7315 (turn_on_face, init_tty): Likewise.
7316 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7317
7f3f1250
PE
7318 * term.c (term_mouse_position): Rename local to avoid shadowing.
7319
e6ca6543
PE
7320 * alloc.c (mark_ttys): Move decl from here ...
7321 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7322
c40f8d15
AS
73232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7324
7325 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7326
cfe0661d
JB
73272011-03-09 Juanma Barranquero <lekktu@gmail.com>
7328
7329 * search.c (compile_pattern_1): Remove argument regp, unused since
7330 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7331 (compile_pattern): Don't pass it.
7332
0afb4571
J
73332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7334
7335 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7336 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7337 for ! HAVE_GTK3.
7338 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7339
7340 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7341
7342 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7343 gdk_window_get_screen, gdk_window_get_geometry,
7344 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7345 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7346 (xg_get_pixbuf_from_pixmap): New function.
7347 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7348 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7349 Call xg_get_pixbuf_from_pixmap instead of
7350 gdk_pixbuf_get_from_drawable.
7351 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7352 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7353 (xg_check_special_colors): Use GtkStyleContext and its functions
7354 for HAVE_GTK3.
7355 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7356 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7357 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7358 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7359 Call gtk_widget_get_preferred_size.
0afb4571
J
7360 (xg_frame_resized): gdk_window_get_geometry only takes 5
7361 parameters.
44f230aa
SM
7362 (xg_win_to_widget, xg_event_is_for_menubar):
7363 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7364 (xg_set_widget_bg): New function.
7365 (delete_cb): New function.
895009e1 7366 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7367 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7368 (xg_set_background_color): Call xg_set_widget_bg.
7369 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7370 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7371 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7372 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7373 if ! HAVE_GTK3.
7374 (update_frame_tool_bar): Call gtk_widget_hide.
7375 (xg_initialize): Use GDK_KEY_g.
7376
7377 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7378 if ! HAVE_GTK3
7379 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7380
7381 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7382 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7383 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7384
1c2cc4ef
JB
73852011-03-08 Juanma Barranquero <lekktu@gmail.com>
7386
7387 * w32xfns.c (select_palette): Check success of RealizePalette against
7388 GDI_ERROR, not zero.
7389
33383987 7390See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7391
7392;; Local Variables:
7393;; coding: utf-8
aac0c6e3
MR
7394;; End:
7395
33383987 7396 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7397
7398 This file is part of GNU Emacs.
7399
7400 GNU Emacs is free software: you can redistribute it and/or modify
7401 it under the terms of the GNU General Public License as published by
7402 the Free Software Foundation, either version 3 of the License, or
7403 (at your option) any later version.
7404
7405 GNU Emacs is distributed in the hope that it will be useful,
7406 but WITHOUT ANY WARRANTY; without even the implied warranty of
7407 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7408 GNU General Public License for more details.
7409
7410 You should have received a copy of the GNU General Public License
7411 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.