* fns.c (Fload_average): Don't assume 100 * load average fits in int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d96be9fc
PE
12011-06-14 Paul Eggert <eggert@cs.ucla.edu>
2
566684ea
PE
3 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4
e6966cd6
PE
5 * fns.c: Don't overflow int when computing a list length.
6 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8 truncation on 64-bit hosts. Check for QUIT every
9 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10 faster and is responsive enough.
11 (Flength): Report an error instead of overflowing an integer.
12 (Fsafe_length): Return a float if the value is not representable
13 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 14 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 15 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 16
dd0b0efb
PE
17 * alloc.c: Check that resized vectors' lengths fit in fixnums.
18 (header_size, word_size): New constants.
19 (allocate_vectorlike): Don't check size overflow here.
20 (allocate_vector): Check it here instead, since this is the only
21 caller of allocate_vectorlike that could cause overflow.
22 Check that the new vector's length is representable as a fixnum.
23
86fe5cfe
PE
24 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
25 The previous code was bogus. For example, next_almost_prime (32)
26 returned 39, which is undesirable as it is a multiple of 3; and
27 next_almost_prime (24) returned 25, which is a multiple of 5 so
28 why was the code bothering to check for multiples of 7?
29
80e88859
PE
30 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
31
4a2f0ad6
PE
32 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
33
f66c7cf8
PE
34 Variadic C functions now count arguments with ptrdiff_t.
35 This partly undoes my 2011-03-30 change, which replaced int with size_t.
36 Back then I didn't know that the Emacs coding style prefers signed int.
37 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
38 were being counted with int, which may truncate counts on 64-bit
39 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
40 * lisp.h (struct Lisp_Subr.function.aMANY)
41 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
42 Arg counts are now ptrdiff_t, not size_t.
43 All variadic functions and their callers changed accordingly.
44 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
45 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
46 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
47 * callint.c (Fcall_interactively): Check arg count for overflow,
48 to avoid potential buffer overrun. Use signed char, not 'int',
49 for 'varies' array, so that we needn't bother to check its size
50 calculation for overflow.
51 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
52 * eval.c (apply_lambda):
53 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
54 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
55 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
56
a1759b76
PE
57 * callint.c (Fcall_interactively): Don't use index var as event count.
58
d96be9fc
PE
59 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
60 * mem-limits.h (SIZE): Remove; no longer used.
61
13bdea59
PE
622011-06-13 Paul Eggert <eggert@cs.ucla.edu>
63
a690a978 64 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 65
578c21e6
PE
66 Remove unnecessary casts.
67 * xterm.c (x_term_init):
68 * xfns.c (x_set_border_pixel):
69 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
70 These aren't needed now that we assume ANSI C.
71
96f53c6c
PE
72 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
73 It's more likely to cause problems (due to unsigned overflow)
74 than to cure them.
75
83c77d31
PE
76 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
77
ee2079f1
PE
78 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
79
6da65536
PE
80 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
81
7147c4a4
PE
82 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
83
193e32d9
PE
84 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
85
e5533da6
PE
86 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
87
9910e595
PE
88 GLYPH_CODE_FACE returns EMACS_INT, not int.
89 * dispextern.h (merge_faces):
90 * xfaces.c (merge_faces):
01103c44
PE
91 * xdisp.c (get_next_display_element, next_element_from_display_vector):
92 Don't assume EMACS_INT fits in int.
9910e595 93
2638320e
PE
94 * character.h (CHAR_VALID_P): Remove unused parameter.
95 * fontset.c, lisp.h, xdisp.c: All uses changed.
96
045eb8d9
PE
97 * editfns.c (Ftranslate_region_internal): Omit redundant test.
98
c1f134b5
PE
99 * fns.c (concat): Minor tuning based on overflow analysis.
100 This doesn't fix any bugs. Use int to hold character, instead
101 of constantly refetching from Emacs object. Use XFASTINT, not
102 XINT, for value known to be a character. Don't bother comparing
103 a single byte to 0400, as it's always less.
104
395fcb93 105 * floatfns.c (Fexpt):
327eeec8
PE
106 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
107
abbd3d23
PE
108 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
109 for characters.
110
684a03ef
PE
111 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
112
0fed43f3
PE
113 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
114 Without this fix, on a 64-bit host (aset S 0 4294967386) would
115 incorrectly succeed when S was a string, because 4294967386 was
116 truncated before it was used.
117
8fd02eb7
PE
118 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
119 Otherwise, an out-of-range integer could cause undefined behavior
120 on a 64-bit host.
121
f8c86b69
PE
122 * composite.c: Use int, not EMACS_INT, for characters.
123 (fill_gstring_body, composition_compute_stop_pos): Use int, not
124 EMACS_INT, for values that are known to be in character range.
125 This doesn't fix any bugs but is the usual style inside Emacs and
126 may generate better code on 32-bit machines.
127
34206dd2
PE
128 Make sure a 64-bit char is never passed to ENCODE_CHAR.
129 This is for reasons similar to the recent CHAR_STRING fix.
130 * charset.c (Fencode_char): Check that character arg is actually
131 a character. Pass an int to ENCODE_CHAR.
132 * charset.h (ENCODE_CHAR): Verify that the character argument is no
133 wider than 'int', as a compile-time check to prevent future regressions
134 in this area.
135
c5958d4c 136 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
137
138 Make sure a 64-bit char is never passed to CHAR_STRING.
139 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
140 by silently ignoring the top 32 bits, allowing some values
141 that were far too large to be valid characters.
142 * character.h: Include <verify.h>.
143 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
144 arguments are no wider than unsigned, as a compile-time check
145 to prevent future regressions in this area.
146 * data.c (Faset):
01103c44 147 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
148 (Fsubst_char_in_region):
149 * fns.c (concat):
150 * xdisp.c (decode_mode_spec_coding):
151 Adjust to CHAR_STRING's new requirement.
152 * editfns.c (Finsert_char, Fsubst_char_in_region):
153 * fns.c (concat): Check that character args are actually
154 characters. Without this test, these functions did the wrong
155 thing with wildly out-of-range values on 64-bit hosts.
156
d37ca623
PE
157 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
158 These casts should not be needed on 32-bit hosts, either.
159 * keyboard.c (read_char):
160 * lread.c (Fload): Remove casts to unsigned.
161
ea204efb
PE
162 * lisp.h (UNSIGNED_CMP): New macro.
163 This fixes comparison bugs on 64-bit hosts.
164 (ASCII_CHAR_P): Use it.
165 * casefiddle.c (casify_object):
01103c44 166 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
167 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
168 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
169 * dispextern.h (FACE_FROM_ID):
170 * keyboard.c (read_char): Use UNSIGNED_CMP.
171
41cb286c
PE
172 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
173 not to EMACS_INT, to avoid GCC warning.
174
4a1b9832
PE
175 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
176
55daad71
PE
177 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
178 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
179 isn't needed on 32-bit machines.
8f95c75c 180
01103c44
PE
181 * buffer.c (Fgenerate_new_buffer_name):
182 Use EMACS_INT for count, not int.
0ceccced 183 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
184
185 * data.c (Qcompiled_function): Now static.
186
c6f072e7
PE
187 * window.c (window_body_lines): Now static.
188
20ce5912
PE
189 * image.c (gif_load): Rename local to avoid shadowing.
190
9c4c5f81
PE
191 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
192 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
193 * alloc.c (make_save_value): Integer argument is now of type
194 ptrdiff_t, not int.
195 (mark_object): Use ptrdiff_t, not int.
196 * lisp.h (pD): New macro.
197 * print.c (print_object): Use it.
198
c0c5c8ae
PE
199 * alloc.c: Use EMACS_INT, not int, to count objects.
200 (total_conses, total_markers, total_symbols, total_vector_size)
201 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
202 (total_free_floats, total_floats, total_free_intervals)
203 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
204 Now EMACS_INT, not int. All uses changed.
205 (Fgarbage_collect): Compute overall total using a double, so that
206 integer overflow is less likely to be a problem. Check for overflow
207 when converting back to an integer.
5a25e253
PE
208 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
209 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
210 These were 'int' variables that could overflow on 64-bit hosts;
211 they were never used, so remove them instead of repairing them.
211a0b2a 212 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
213 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
214 Previously, this ceilinged at INT_MAX, but that doesn't work on
215 64-bit machines.
e46bb31a 216 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 217
c78baabf 218 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 219 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
220 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
221 when a (possibly-narrower) signed value would do just as well.
222 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 223
c9d624c6
PE
224 * alloc.c: Catch some string size overflows that we were missing.
225 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
226 for convenience in STRING_BYTES_MAX.
227 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
228 The definition here is exact; the one in lisp.h was approximate.
229 (allocate_string_data): Check for string overflow. This catches
230 some instances we weren't catching before. Also, it catches
231 size_t overflow on (unusual) hosts where SIZE_MAX <= min
232 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
233 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 234
c9d624c6
PE
235 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
236 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
237 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
238
353032ce
PE
239 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
240
2bccce07
PE
241 * alloc.c (Fmake_string): Check for out-of-range init.
242
e10ac9f1
MR
2432011-06-12 Martin Rudalics <rudalics@gmx.at>
244
245 * frame.c (make_frame): Call other_buffer_safely instead of
246 other_buffer.
247
248 * window.c (temp_output_buffer_show): Call display_buffer with
249 second argument Vtemp_buffer_show_specifiers and reset latter
250 immediately after the call.
251 (Vtemp_buffer_show_specifiers): New variable.
252 (auto_window_vscroll_p, next_screen_context_lines)
253 (Vscroll_preserve_screen_position): Remove leading asterisks from
254 doc-strings.
255
2d3c217e 2562011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 257
7b7f97e8 258 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
259 * buffer.c (Qclone_number): Remove for now, as it's unused.
260 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
261 (record_buffer): Remove unused local.
262 * frame.c (other_visible_frames, frame_buffer_list): Now static.
263 (set_frame_buffer_list): Remove; unused.
264 * frame.h (other_visible_frames): Remove decl.
265 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
266 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
267 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
268 if HAVE_GPM.
269 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
270 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
271 Define only if HAVE_GPM.
272 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
273 (update_hints_inhibit): Remove; never set. All uses removed.
274 * widgetprv.h (emacsFrameClassRec): Remove decl.
275 * window.c (delete_deletable_window): Now returns void, since it
276 wasn't returning anything.
277 (compare_window_configurations): Remove unused locals.
278 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
279 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
280 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
281 the same widths as pointers. This follows up on the 2011-05-06 patch.
282 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
283 * xterm.h: Likewise.
284 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
285
1384b89e
JB
2862011-06-12 Juanma Barranquero <lekktu@gmail.com>
287
288 * makefile.w32-in: Update dependencies.
289 (LISP_H): Add lib/intprops.h.
290
1100a63c
CY
2912011-06-11 Chong Yidong <cyd@stupidchicken.com>
292
293 * image.c (gif_load): Add animation frame delay to the metadata.
294 (syms_of_image): Use DEFSYM. New symbol `delay'.
295
6198ccd0
MR
2962011-06-11 Martin Rudalics <rudalics@gmx.at>
297
298 * window.c (delete_deletable_window): Re-add.
299 (Fset_window_configuration): Rewrite to handle dead buffers and
300 consequently deletable windows.
301 (window_tree, Fwindow_tree): Remove. Supply functionality in
302 window.el.
303 (compare_window_configurations): Simplify code.
304
b6e3633c
AS
3052011-06-11 Andreas Schwab <schwab@linux-m68k.org>
306
1ab0dee5
AS
307 * image.c (imagemagick_load_image): Fix type mismatch.
308 (Fimagemagick_types): Likewise.
309
b6e3633c
AS
310 * window.h (replace_buffer_in_windows): Declare.
311
9397e56f
MR
3122011-06-11 Martin Rudalics <rudalics@gmx.at>
313
314 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
315 Qclone_number. Remove external declaration of Qdelete_window.
316 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
317 code.
318 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
319 Qbuffer_list_update_hook if allowed.
320 (Fother_buffer): Rewrite doc-string. Major rewrite for new
321 buffer list implementation.
322 (other_buffer_safely): New function.
323 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
324 calls to replace_buffer_in_windows and
325 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
326 if allowed.
327 (record_buffer): Inhibit quitting and rewrite using quittable
328 functions. Run Qbuffer_list_update_hook if allowed.
329 (Frecord_buffer, Funrecord_buffer): New functions.
330 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
331 switch-to-buffer to window.el.
332 (bury-buffer): Move to window.el.
333 (Vbuffer_list_update_hook): New variable.
334
335 * lisp.h (other_buffer_safely): Add prototype in buffer.c
336 section.
337
338 * window.h (resize_frame_windows): Move up in code.
339 (Fwindow_frame): Remove EXFUN.
340 (replace_buffer_in_all_windows): Remove prototype.
341 (replace_buffer_in_windows_safely): Add prototype.
342
343 * window.c: Declare Qdelete_window static again. Move down
344 declaration of select_count.
345 (Fnext_window, Fprevious_window): Rewrite doc-strings.
346 (Fother_window): Move to window.el.
347 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
348 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
349 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
350 window.el.
351 (replace_buffer_in_windows): Implement by calling
352 Qreplace_buffer_in_windows.
353 (replace_buffer_in_all_windows): Remove with some functionality
354 moved into replace_buffer_in_windows_safely.
355 (replace_buffer_in_windows_safely): New function.
356 (select_window_norecord, select_frame_norecord): Move in front
357 of run_window_configuration_change_hook. Remove now obsolete
358 declarations.
359 (Fset_window_buffer): Rewrite doc-string. Call
360 Qrecord_window_buffer.
361 (keys_of_window): Move binding for other-window to window.el.
362
b50691aa
CY
3632011-06-11 Chong Yidong <cyd@stupidchicken.com>
364
365 * dispextern.h (struct image): Replace data member, whose int_val
366 and ptr_val fields were not used by anything, with a single
367 lisp_val object.
368
369 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
370 (gif_clear_image, gif_load, imagemagick_load_image)
371 (gs_clear_image, gs_load): Callers changed.
372
3f754b86
PE
3732011-06-10 Paul Eggert <eggert@cs.ucla.edu>
374
cca69397
PE
375 * buffer.h: Include <time.h>, for time_t.
376 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
377
109e28d0
PE
378 Fix minor problems found by static checking.
379
60737f02
PE
380 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
381
4b66faf3
PE
382 Make identifiers static if they are not used in other modules.
383 * data.c (Qcompiled_function, Qframe, Qvector):
384 * image.c (QimageMagick, Qsvg):
385 * minibuf.c (Qmetadata):
386 * window.c (resize_window_check, resize_root_window): Now static.
387 * window.h (resize_window_check, resize_root_window): Remove decls.
388
109e28d0
PE
389 * window.c (window_deletion_count, delete_deletable_window):
390 Remove; unused.
46a4ce9e
PE
391 (window_body_lines): Now static.
392 (Fdelete_other_windows_internal): Mark vars as initialized.
393 Make sure 'resize_failed' is initialized.
394 (run_window_configuration_change_hook): Rename local to avoid shadowing.
395 (resize_window_apply): Remove unused local.
396 * window.h (delete_deletable_window): Remove decl.
397
109e28d0 398 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
399 (imagemagick_load_image): Fix pointer signedness problem by changing
400 last arg from unsigned char * to char *. All uses changed.
401 Also, fix a local for similar reasons.
402 Remove unused locals. Remove locals to avoid shadowing.
403 (fn_rsvg_handle_free): Remove; unused.
404 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 405 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 406
3f754b86
PE
407 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
408
2547adb1
CY
4092011-06-10 Chong Yidong <cyd@stupidchicken.com>
410
411 * image.c (gif_load): Fix omitted cast error introduced by
412 2011-06-06 change.
413
2c8e37d4
MR
4142011-06-10 Martin Rudalics <rudalics@gmx.at>
415
416 * window.h (resize_proportionally, orig_total_lines)
417 (orig_top_line): Remove from window structure.
418 (set_window_height, set_window_width, change_window_heights)
419 (Fdelete_window): Remove prototypes.
420 (resize_frame_windows): Remove duplicate declaration.
421
440a42e3
EZ
4222011-06-10 Eli Zaretskii <eliz@gnu.org>
423
424 * window.h (resize_frame_windows, resize_window_check)
425 (delete_deletable_window, resize_root_window)
426 (resize_frame_windows): Declare prototypes.
427
428 * window.c (resize_window_apply): Make definition be "static" to
429 match the prototype.
430
562dd5e9
MR
4312011-06-10 Martin Rudalics <rudalics@gmx.at>
432
433 * window.c: Remove declarations of Qwindow_size_fixed,
434 window_min_size_1, window_min_size_2, window_min_size,
435 size_window, window_fixed_size_p, enlarge_window, delete_window.
436 Remove static from declaration of Qdelete_window, it's
437 temporarily needed by Fbury_buffer.
438 (replace_window): Don't assign orig_top_line and
439 orig_total_lines.
440 (Fdelete_window, delete_window): Remove. Window deletion is
441 handled by window.el.
442 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
443 Fdelete_window calls with calls to Qdelete_window.
444 (Fdelete_other_windows): Remove. Deleting other windows is
445 handled by window.el.
446 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
447 handled in window.el.
448 (window_min_size_2, window_min_size_1, window_min_size): Remove.
449 Window minimum sizes are handled in window.el.
450 (shrink_windows, size_window, set_window_height)
451 (set_window_width, change_window_heights, window_height)
452 (window_width, CURBEG, CURSIZE, enlarge_window)
453 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
454 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
455 handled in window.el.
456 (make_dummy_parent): Rename to make_parent_window and give it a
457 second argument horflag.
458 (make_window): Don't set resize_proportionally any more.
459 (Fsplit_window): Remove. Windows are split in window.el.
460 (save_restore_action, save_restore_orig_size)
461 (shrink_window_lowest_first, save_restore_orig_size): Remove.
462 Resize mini windows in window.el.
463 (grow_mini_window, shrink_mini_window): Implement by calling
464 Qresize_root_window_vertically, resize_window_check and
465 resize_window_apply.
466 (saved_window, Fset_window_configuration, save_window_save): Do
467 not handle orig_top_line, orig_total_lines, and
468 resize_proportionally.
469 (window_min_height, window_min_width): Move to window.el.
470 (keys_of_window): Move bindings for delete-other-windows,
471 split-window, delete-window and enlarge-window to window.el.
472
473 * buffer.c: Temporarily extern Qdelete_window.
474 (Fbury_buffer): Temporarily call Qdelete_window instead of
475 Fdelete_window (Fbury_buffer will move to window.el soon).
476
477 * frame.c (set_menu_bar_lines_1): Remove code handling
478 orig_top_line and orig_total_lines.
479
480 * dispnew.c (adjust_frame_glyphs_initially): Don't use
481 set_window_height but set heights directly.
482 (change_frame_size_1): Use resize_frame_windows.
483
484 * xdisp.c (init_xdisp): Don't use set_window_height but set
485 heights directly.
486
487 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
488 resize_frame_windows instead of change_window_heights and run
489 run_window_configuration_change_hook.
490
491 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
492 instead of change_window_heights and run
493 run_window_configuration_change_hook.
494
1a13852e
MR
4952011-06-09 Martin Rudalics <rudalics@gmx.at>
496
497 * window.c (replace_window): Rename second argument REPLACEMENT to
498 NEW. New third argument SETFLAG. Rewrite.
499 (delete_window, make_dummy_parent): Call replace_window with
500 third argument 1.
501 (window_list_1): Move down in code.
502 (run_window_configuration_change_hook): Move set_buffer part
503 before select_frame_norecord part in order to unwind correctly.
504 Rename count1 to count.
505 (recombine_windows, delete_deletable_window, resize_root_window)
506 (Fdelete_other_windows_internal)
507 (Frun_window_configuration_change_hook, make_parent_window)
508 (resize_window_check, resize_window_apply, Fresize_window_apply)
509 (resize_frame_windows, Fsplit_window_internal)
510 (Fdelete_window_internal, Fresize_mini_window_internal): New
511 functions.
512 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
513
f3d1777e
MR
5142011-06-08 Martin Rudalics <rudalics@gmx.at>
515
496e208e
MR
516 * window.h (window): Add some new members to window structure -
517 normal_lines, normal_cols, new_total, new_normal, clone_number,
518 splits, nest, prev_buffers, next_buffers.
519 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 520 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 521
f3d1777e
MR
522 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
523 Remove.
496e208e
MR
524 (make_dummy_parent): Set new members of windows structure.
525 (make_window): Move down in code. Handle new members of window
526 structure.
527 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
528 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
529 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
530 (Fset_window_prev_buffers, Fwindow_next_buffers)
531 (Fset_window_next_buffers, Fset_window_clone_number): New
532 functions.
533 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
534 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
535 Doc-string fixes.
536 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
537 Argument WINDOW can be now internal window too.
538 (Fwindow_use_time): Move up in code.
539 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
540 Rewrite doc-string.
541 (Fset_window_configuration, saved_window)
542 (Fcurrent_window_configuration, save_window_save): Handle new
543 members of window structure.
b9e809c2
MR
544 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
545 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
546 (syms_of_window): New Lisp objects Qrecord_window_buffer,
547 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
548 Qget_mru_window, Qresize_root_window,
549 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
550 Qauto_buffer_name; staticpro them.
f3d1777e 551
abde8f8c
MR
5522011-06-07 Martin Rudalics <rudalics@gmx.at>
553
554 * window.c (Fwindow_total_size, Fwindow_left_column)
555 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
556 (Fwindow_list_1): New functions.
557 (window_box_text_cols): Replace with window_body_cols.
558 (Fwindow_width, Fscroll_left, Fscroll_right): Use
559 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
560 (delete_window, Fset_window_configuration): Call
561 delete_all_subwindows with window as argument.
562 (delete_all_subwindows): Take a window as argument and not a
563 structure. Rewrite.
190b47e6
MR
564 (window_loop): Remove handling of GET_LRU_WINDOW and
565 GET_LARGEST_WINDOW.
566 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
567
568 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
569 window_box_text_cols. delete_all_subwindows now takes a
570 Lisp_Object as argument.
abde8f8c
MR
571
572 * indent.c (compute_motion, Fcompute_motion): Use
573 window_body_cols instead of window_box_text_cols.
574
fa8a67e6
MR
575 * frame.c (delete_frame): Call delete_all_subwindows with root
576 window as argument.
577
a54e3482
DC
5782011-06-07 Daniel Colascione <dan.colascione@gmail.com>
579
580 * fns.c (Fputhash): Document return value.
581
60002bf5
CY
5822011-06-06 Chong Yidong <cyd@stupidchicken.com>
583
584 * image.c (gif_load): Implement gif89a spec "no disposal" method.
585
0c671da6 5862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 587
b862a52a 588 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 589
be44ca6c
PE
590 Check for overflow when converting integer to cons and back.
591 * charset.c (Fdefine_charset_internal, Fdecode_char):
592 Use cons_to_unsigned to catch overflow.
593 (Fencode_char): Use INTEGER_TO_CONS.
594 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
595 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
596 * data.c (long_to_cons, cons_to_long): Remove.
597 (cons_to_unsigned, cons_to_signed): New functions.
598 These signal an error for invalid or out-of-range values.
599 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
600 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
601 * font.c (Ffont_variation_glyphs):
602 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
603 * lisp.h: Include <intprops.h>.
604 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
605 (cons_to_signed, cons_to_unsigned): New decls.
606 (long_to_cons, cons_to_long): Remove decls.
607 * undo.c (record_first_change): Use INTEGER_TO_CONS.
608 (Fprimitive_undo): Use CONS_TO_INTEGER.
609 * xfns.c (Fx_window_property): Likewise.
610 * xselect.c: Include <limits.h>.
611 (x_own_selection, selection_data_to_lisp_data):
612 Use INTEGER_TO_CONS.
613 (x_handle_selection_request, x_handle_selection_clear)
614 (x_get_foreign_selection, Fx_disown_selection_internal)
615 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
616 (lisp_data_to_selection_data): Use cons_to_unsigned.
617 (x_fill_property_data): Use cons_to_signed.
618 Report values out of range.
619
d1f3d2af
PE
620 Check for buffer and string overflow more precisely.
621 * buffer.h (BUF_BYTES_MAX): New macro.
622 * lisp.h (STRING_BYTES_MAX): New macro.
623 * alloc.c (Fmake_string):
624 * character.c (string_escape_byte8):
625 * coding.c (coding_alloc_by_realloc):
626 * doprnt.c (doprnt):
627 * editfns.c (Fformat):
628 * eval.c (verror):
629 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
630 since they may not be the same number.
631 * editfns.c (Finsert_char):
632 * fileio.c (Finsert_file_contents):
633 Likewise for BUF_BYTES_MAX.
634
dd52fcea
PE
635 * image.c: Use ptrdiff_t, not int, for sizes.
636 (slurp_file): Switch from int to ptrdiff_t.
637 All uses changed.
638 (slurp_file): Check that file size fits in both size_t (for
639 malloc) and ptrdiff_t (for sanity and safety).
640
7f9bbdbb
PE
641 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
642 if b->modtime has its maximal value.
643
dfe18f82
PE
644 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
645
84acfcf0
PE
646 Don't assume time_t can fit into int.
647 * buffer.h (struct buffer.modtime): Now time_t, not int.
648 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
649 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
650
ccd9a01a
PE
651 Minor fixes for signed vs unsigned integers.
652 * character.h (MAYBE_UNIFY_CHAR):
653 * charset.c (maybe_unify_char):
654 * keyboard.c (read_char, reorder_modifiers):
655 XINT -> XFASTINT, since the integer must be nonnegative.
656 * ftfont.c (ftfont_spec_pattern):
657 * keymap.c (access_keymap, silly_event_symbol_error):
658 XUINT -> XFASTINT, since the integer must be nonnegative.
659 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
660 since it makes no difference and we prefer signed.
661 * keyboard.c (record_char): Use XUINT when all the neighbors do.
662 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
663 nonnegative.
664
d6d100dd
SM
6652011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
666
667 * window.h (Fwindow_frame): Declare.
668
2b6148e4
PE
6692011-06-06 Paul Eggert <eggert@cs.ucla.edu>
670
671 * alloc.c: Simplify handling of large-request failures (Bug#8800).
672 (SPARE_MEMORY): Always define.
673 (LARGE_REQUEST): Remove.
674 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
675
f230ecc9
MR
6762011-06-06 Martin Rudalics <rudalics@gmx.at>
677
727e958e
MR
678 * lisp.h: Move EXFUNS for Fframe_root_window,
679 Fframe_first_window and Fset_frame_selected_window to window.h.
680
681 * window.h: Move EXFUNS for Fframe_root_window,
682 Fframe_first_window and Fset_frame_selected_window here from
683 lisp.h.
684
685 * frame.c (Fwindow_frame, Fframe_first_window)
686 (Fframe_root_window, Fframe_selected_window)
687 (Fset_frame_selected_window): Move to window.c.
688 (Factive_minibuffer_window): Move to minibuf.c.
689 (Fother_visible_frames_p): New function.
690
691 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
692
f230ecc9
MR
693 * window.c (decode_window, decode_any_window): Move up in code.
694 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
695 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
696 (Fwindow_buffer): Move up and rewrite doc-string.
697 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
698 (Fwindow_prev): New functions.
727e958e
MR
699 (Fwindow_frame): Move here from frame.c. Accept any window as
700 argument.
701 (Fframe_root_window, Fframe_first_window)
702 (Fframe_selected_window): Move here from frame.c. Accept frame
703 or arbitrary window as argument. Update doc-strings.
704 (Fminibuffer_window): Move up in code.
705 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
706 (Fset_frame_selected_window): Move here from frame.c.
707 Marginal rewrite.
727e958e
MR
708 (Fselected_window, select_window, Fselect_window): Move up in
709 code. Minor doc-string fixes.
f230ecc9 710
4d09bcf6
PE
7112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
712
713 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
714 Do not assume that spare memory exists; that assumption is valid
715 only if SYSTEM_MALLOC.
716 (LARGE_REQUEST): New macro, so that the issue of large requests
717 is separated from the issue of spare memory.
718
810928a2
AS
7192011-06-05 Andreas Schwab <schwab@linux-m68k.org>
720
172418ad
AS
721 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
722 format. (Bug#8806)
723
43f862f7
AS
724 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
725
810928a2
AS
726 * xfns.c (x_set_scroll_bar_default_width): Move declarations
727 before statements.
728
a059fe24
JD
7292011-06-05 Jan Djärv <jan.h.d@swipnet.se>
730
731 * gtkutil.c (xg_get_default_scrollbar_width): New function.
732
733 * gtkutil.h: Declare xg_get_default_scrollbar_width.
734
735 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
736 min width by calling x_set_scroll_bar_default_width (Bug#8505).
737
989bf368
JB
7382011-06-05 Juanma Barranquero <lekktu@gmail.com>
739
740 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
741
4b80f674
CY
7422011-06-04 Chong Yidong <cyd@stupidchicken.com>
743
744 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
745 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
746 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
747 New error handlers.
4b80f674
CY
748 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
749 Obey Vx_select_enable_clipboard_manager. Catch errors in
750 x_clipboard_manager_save (Bug#8779).
751 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 752 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 753
99a33b77 7542011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
755
756 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
757
99a33b77 7582011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
759
760 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
761 in the current matrix if keep_current_p is non-zero.
762
8264569d
EZ
7632011-06-04 Eli Zaretskii <eliz@gnu.org>
764
765 * bidi.c (bidi_level_of_next_char): Fix last change.
766
57f97249
EZ
7672011-06-03 Eli Zaretskii <eliz@gnu.org>
768
fec2107c 769 Support bidi reordering of text covered by display properties.
57f97249 770
fec2107c
EZ
771 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
772 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
773 (bidi_cache_search, bidi_cache_iterator_state)
774 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
775 (bidi_level_of_next_char, bidi_move_to_visually_next):
776 Support character positions inside a run of characters covered by a
fec2107c
EZ
777 display string.
778 (bidi_paragraph_init, bidi_resolve_explicit_1)
779 (bidi_level_of_next_char): Call bidi_fetch_char and
780 bidi_fetch_char_advance instead of FETCH_CHAR and
781 FETCH_CHAR_ADVANCE.
782 (bidi_init_it): Initialize new members.
783 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
784 definitions.
785 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
786 instead of using explicit *_CHAR codes.
d6d100dd
SM
787 (bidi_resolve_explicit, bidi_resolve_weak):
788 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
789 bidirectional text is supported only in multibyte buffers.
790 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
791 it to initialize the frame_window_p member of struct bidi_it.
792 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
793 (bidi_resolve_explicit, bidi_resolve_weak)
794 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
795 bidi_it->nchars is non-positive.
796 (bidi_level_of_next_char): Don't try to lookup the cache for the
797 next/previous character if nothing is cached there yet, or if we
798 were just reseat()'ed to a new position.
c40e2fb2 799
0e14fe90
EZ
800 * xdisp.c (set_cursor_from_row): Set start and stop points
801 according to the row's direction when priming the loop that looks
802 for the glyph on which to display cursor.
803 (single_display_spec_intangible_p): Function deleted.
804 (display_prop_intangible_p): Reimplement to call
805 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
806 Accept 3 additional arguments needed by handle_display_spec.
807 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
808 values: lists, `(when COND...)' forms, etc.
809 (single_display_spec_string_p): Support property values that are
810 lists with the argument STRING its top-level element.
811 (display_prop_string_p): Fix the condition for processing a
812 property that is a list to be consistent with handle_display_spec.
fec2107c 813 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
814 last portion of handle_display_prop.
815 (compute_display_string_pos): Accept additional argument
816 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
817 value of a `display' property is a "replacing spec".
818 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
819 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
820 the display property, but just return a value indicating whether
821 the display property will replace the characters it covers.
822 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
823 frame_window_p members of struct bidi_it.
d6d100dd
SM
824 (compute_display_string_pos, compute_display_string_end):
825 New functions.
fec2107c
EZ
826 (push_it): Accept second argument POSITION, where pop_it should
827 jump to continue iteration.
828 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 829
fec2107c
EZ
830 * keyboard.c (adjust_point_for_property): Adjust the call to
831 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
832
833 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
834 (bidi_init_it): Update prototypes.
835 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
836 (compute_display_string_pos, compute_display_string_end):
837 Declare prototypes.
fec2107c
EZ
838 (struct bidi_it): New members nchars and disp_pos. ch_len is now
839 EMACS_INT.
fc6f18ce 840
40087514 8412011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 842
57f53182
PE
843 Malloc failure behavior now depends on size of allocation.
844 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
845 * lisp.h: Change signatures accordingly.
846 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
847 All callers changed. (Bug#8762)
848
849 * gnutls.c: Use Emacs's memory allocators.
850 Without this change, the gnutls library would invoke malloc etc.
851 directly, which causes problems on non-SYNC_INPUT hosts, and which
852 runs afoul of improving memory_full behavior. (Bug#8761)
853 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
854 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
855 xfree instead of the default malloc, realloc, free.
856 (Fgnutls_boot): No need to check for memory allocation failure,
857 since xmalloc does that for us.
858
ac32cd99 859 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
860 * category.c (hash_get_category_set):
861 * ccl.c (ccl_driver):
862 * charset.c (Fdefine_charset_internal):
863 * charset.h (struct charset.hash_index):
864 * composite.c (get_composition_id, gstring_lookup_cache)
865 (composition_gstring_put_cache):
866 * composite.h (struct composition.hash_index):
867 * dispextern.h (struct image.hash):
868 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
869 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
870 (hashfn_equal, hashfn_user_defined, make_hash_table)
871 (maybe_resize_hash_table, hash_lookup, hash_put)
872 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
873 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
874 (Fsxhash, Fgethash, Fputhash, Fmaphash):
875 * image.c (make_image, search_image_cache, lookup_image)
876 (xpm_put_color_table_h):
877 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 878 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
879 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
880 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
881 * alloc.c (allocate_vectorlike):
882 Check for overflow in vector size calculations.
883 * ccl.c (ccl_driver):
884 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
885 * fns.c, image.c: Remove unnecessary static decls that would otherwise
886 need to be updated by these changes.
40087514
PE
887 * fns.c (make_hash_table, maybe_resize_hash_table):
888 Check for integer overflow with large hash tables.
0de4bb68
PE
889 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
890 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
891 (SXHASH_REDUCE): New macro.
892 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
893 Use it instead of discarding useful hash info with large hash values.
894 (sxhash_float): New function.
895 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
896 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
897 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
898 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
899 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
900 Adjust signatures to match updated version of code.
901 (consing_since_gc): Now EMACS_INT, since a single hash table can
902 use more than INT_MAX bytes.
903
698d32e2
DN
9042011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
905
906 Make it possible to build with GCC-4.6+ -O2 -flto.
907
908 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
909
fd6fa53f
SM
9102011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
911
912 * minibuf.c (get_minibuffer, read_minibuf_unwind):
913 Call minibuffer-inactive-mode.
914
864db017
JB
9152011-05-31 Juanma Barranquero <lekktu@gmail.com>
916
917 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
918 Update dependencies.
919
2ad0baf4
DN
9202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
921
922 * data.c (init_data): Remove code for UTS, this system is not
923 supported anymore.
924
4fcc2638
DN
9252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
926
927 Don't force ./temacs to start in terminal mode.
928
929 * frame.c (make_initial_frame): Initialize faces in all cases, not
930 only when CANNOT_DUMP is defined.
931 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
932
c56e0fd5
DN
9332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
934
935 * dispnew.c (add_window_display_history): Use const for the string
936 pointer. Remove declaration, not needed.
937
333d54da 9382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 939
55d4c1b2 940 Use 'inline', not 'INLINE'.
333d54da 941 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
942 * alloc.c, fontset.c (INLINE): Remove.
943 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
944 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
945 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
946 * gmalloc.c (register_heapinfo): Use inline unconditionally.
947 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
948
738db178
DN
9492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
950
951 Make it possible to run ./temacs.
952
953 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
954 syms_of_callproc does the same thing. Remove test for
955 "initialized", do it in the caller.
956 * emacs.c (main): Avoid calling set_initial_environment when dumping.
957
620c53a6
SM
9582011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
959
960 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
961 (read_minibuf): Use get_minibuffer.
962 (syms_of_minibuf): Use DEFSYM.
963 (Qmetadata): New var.
964 * data.c (Qbuffer): Don't make it static.
965 (syms_of_data): Use DEFSYM.
966
e003a292
PE
9672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
968
969 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
970 (CCL_CODE_MIN): New macro.
971
ed008a6d
PE
9722011-05-30 Paul Eggert <eggert@cs.ucla.edu>
973
3687c2ef
PE
974 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
975
ed008a6d
PE
976 * eval.c (Qdebug): Now static.
977 * lisp.h (Qdebug): Remove decl. This reverts a part of the
978 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
979 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
980
d66c4c7c
CY
9812011-05-29 Chong Yidong <cyd@stupidchicken.com>
982
983 * image.c: Various fixes to ImageMagick code comments.
984 (Fimagemagick_types): Doc fix.
985
5fbc2025
PE
9862011-05-29 Paul Eggert <eggert@cs.ucla.edu>
987
0196f88a
PE
988 Minor fixes prompted by GCC 4.6.0 warnings.
989
990 * xselect.c (converted_selections, conversion_fail_tag): Now static.
991
5fbc2025
PE
992 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
993 (x_clipboard_manager_save_all): Move extern decl to ...
994 * xterm.h: ... here, so that it can be checked for consistency.
995
1dd3c2d9
CY
9962011-05-29 Chong Yidong <cyd@stupidchicken.com>
997
998 * xselect.c (x_clipboard_manager_save_frame)
999 (x_clipboard_manager_save_all): New functions.
1000 (Fx_clipboard_manager_save): Lisp function deleted.
1001
1002 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1003 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1004
1005 * xterm.h: Update prototype.
1006
5ba6571d
WX
10072011-05-28 William Xu <william.xwl@gmail.com>
1008
1009 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1010 exiting (Bug#8239).
1011
3eaff834
JM
10122011-05-28 Jim Meyering <meyering@redhat.com>
1013
e1900994 1014 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1015 * fns.c (to_uchar): Define.
1016 (crypto_hash_function): Use it to convert some newly-signed
1017 variables to unsigned, to avoid sign-extension bugs. For example,
1018 without this change, (md5 "truc") would evaluate to
1019 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1020 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1021 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1022
0f6990a7
PE
10232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1024
1025 Integer overflow fixes.
c8a9ca5a 1026
08686060
PE
1027 * dbusbind.c: Serial number integer overflow fixes.
1028 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1029 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1030 to hold a serial number that is too large for a fixnum.
1031 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1032 Check for serial numbers out of range. Decode any serial number
59568bf0 1033 that was so large that it became a float. (Bug#8722)
08686060 1034
2d1fc3c7
PE
1035 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1036 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1037 Use XFASTINT rather than XUINT when numbers are nonnegative.
1038 (xd_append_arg, Fdbus_method_return_internal):
1039 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1040 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1041 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1042 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1043 (Bug#8722)
2d1fc3c7 1044
c8a9ca5a
PE
1045 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1046
519e1d69
PE
1047 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1048
30569699
PE
1049 ccl: add integer overflow checks
1050 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1051 (IN_INT_RANGE): New macros.
1052 (ccl_driver): Use them to check for integer overflow when
1053 decoding a CCL program. Many of the new checks are whether XINT (x)
1054 fits in int; it doesn't always, on 64-bit hosts. The new version
1055 doesn't catch all possible integer overflows, but it's an
847044ea 1056 improvement. (Bug#8719)
30569699 1057
c11285dc
PE
1058 * alloc.c (make_event_array): Use XINT, not XUINT.
1059 There's no need for unsigned here.
1060
fdccd48e
PE
1061 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1062 This follows up to the 2011-05-06 change that substituted uintptr_t
1063 for EMACS_INT. This case wasn't caught back then.
1064
37910ab2
PE
1065 Rework Fformat to avoid integer overflow issues.
1066 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1067 now (part of C89). Include <verify.h>.
1068 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1069 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1070 (Fformat): Avoid the prepass trying to compute sizes; it was only
1071 approximate and thus did not catch overflow reliably. Instead, walk
1072 through the format just once, formatting and computing sizes as we go,
1073 checking for integer overflow at every step, and allocating a larger
1074 buffer as needed. Keep track separately whether the format is
1075 multibyte. Keep only the most-recently calculated precision, rather
1076 than them all. Record whether each argument has been converted to
1077 string. Use EMACS_INT, not int, for byte and char and arg counts.
1078 Support field widths and precisions larger than INT_MAX. Avoid
1079 sprintf's undefined behavior with conversion specifications such as %#d
1080 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1081 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1082 formatting out-of-range floating point numbers with int
1083 formats. (Bug#8668)
1084
2e6578fb
PE
1085 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1086
0ae6bdee
PE
1087 * data.c: Avoid integer truncation in expressions involving floats.
1088 * data.c: Include <intprops.h>.
1089 (arith_driver): When there's an integer overflow in an expression
1090 involving floating point, convert the integers to floating point
1091 so that the resulting value does not suffer from catastrophic
1092 integer truncation. For example, on a 64-bit host (* 4
1093 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1094 Do not rely on undefined behavior after integer overflow.
1095
de883a70
PE
1096 merge count_size_as_multibyte, parse_str_to_multibyte
1097 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1098 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1099 Check for integer overflow.
1100 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1101 since it's now a duplicate of the other. This is more of
1102 a character than a buffer op, so better that it's in character.c.
1103 * fns.c, print.c: Adjust to above changes.
1104
2ff916cb
PE
11052011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1106
1107 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1108
f1b54466
PE
11092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1110
fb1ac845
PE
1111 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1112 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1113 (x_clipboard_manager_save): Now static.
1114 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1115
f1b54466
PE
1116 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1117 (crypto_hash_function): Now static.
1118 Fix pointer signedness problems. Avoid unnecessary initializations.
1119
a9f737ee
CY
11202011-05-27 Chong Yidong <cyd@stupidchicken.com>
1121
1122 * termhooks.h (Vselection_alist): Make it terminal-local.
1123
1124 * terminal.c (create_terminal): Initialize it.
1125
1126 * xselect.c: Support for clipboard managers.
1127 (Vselection_alist): Move to termhooks.h as terminal-local var.
1128 (LOCAL_SELECTION): New macro.
1129 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1130 (symbol_to_x_atom): Remove gratuitous arg.
1131 (x_handle_selection_request, lisp_data_to_selection_data)
1132 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1133 (x_own_selection, x_get_local_selection, x_convert_selection):
1134 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1135 (some_frame_on_display): Delete unused function.
1136 (Fx_own_selection_internal, Fx_get_selection_internal)
1137 (Fx_disown_selection_internal, Fx_selection_owner_p)
1138 (Fx_selection_exists_p): New optional frame arg.
1139 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1140 (x_handle_selection_clear): Don't treat other terminals with the
1141 same keyboard specially. Use the terminal-local Vselection_alist.
1142 (x_clear_frame_selections): Use Frun_hook_with_args.
1143
1144 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1145
1146 * xterm.h: Add support for those atoms.
1147
e067f0c1
CY
11482011-05-26 Chong Yidong <cyd@stupidchicken.com>
1149
1150 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1151 (converted_selections, conversion_fail_tag): New global variables.
1152 (x_selection_request_lisp_error): Free the above.
1153 (x_get_local_selection): Remove unnecessary code.
1154 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1155 of converted selections stored in converted_selections.
1156 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1157 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1158 (x_convert_selection): New function.
1159 (x_handle_selection_event): Simplify.
1160 (x_get_foreign_selection): Don't ignore incoming requests while
1161 waiting for an answer; this will fail when we implement
1162 SAVE_TARGETS, and seems unnecessary anyway.
1163 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1164 (Vx_sent_selection_functions): Doc fix.
1165
0f4aebc0
LL
11662011-05-26 Leo Liu <sdl.web@gmail.com>
1167
1168 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1169
e61124cd
YM
11702011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1171
1172 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1173
1174 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1175 for fringe update if it has periodic bitmap.
1176 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1177 and fringe_bitmap_periodic_p.
1178
1179 * fringe.c (get_fringe_bitmap_data): New function.
1180 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1181 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1182 row. Mark glyph row for fringe update if periodicity changed.
1183
1184 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1185 for fringe update unless it has periodic bitmap.
1186
f16d9837
KH
11872011-05-25 Kenichi Handa <handa@m17n.org>
1188
1189 * xdisp.c (get_next_display_element): Set correct it->face_id for
1190 a static composition.
1191
e1b90ef6
LL
11922011-05-24 Leo Liu <sdl.web@gmail.com>
1193
1194 * deps.mk (fns.o):
1195 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1196
1197 * fns.c (crypto_hash_function, Fsha1): New function.
1198 (Fmd5): Use crypto_hash_function.
1199 (syms_of_fns): Add Ssha1.
1200
7400048f
PE
12012011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1202
1203 * gnutls.c: Remove unused macros.
1204 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1205 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1206 Remove macros that are defined and never used.
1207 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1208
abb71cf4
CY
12092011-05-22 Chong Yidong <cyd@stupidchicken.com>
1210
1211 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1212 (Fx_get_selection_internal): Minor cleanup.
1213 (Fx_own_selection_internal): Rename arguments for consistency with
1214 select.el.
1215
6307db39
PE
12162011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1217
1218 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1219
f3d4e0a4
CY
12202011-05-22 Chong Yidong <cyd@stupidchicken.com>
1221
1222 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1223
4d8ade89
YM
12242011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1225
1226 * dispnew.c (scrolling_window): Don't exclude the case that the
1227 last enabled row in the desired matrix touches the bottom boundary.
1228
32078c8d
GM
12292011-05-21 Glenn Morris <rgm@gnu.org>
1230
1231 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1232 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1233 and add some more files.
32078c8d 1234
7285dc67
EZ
12352011-05-20 Eli Zaretskii <eliz@gnu.org>
1236
1237 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1238 report_file_error introduced by the change from 2011-05-07.
1239
89d1bd22
PE
12402011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1241
1242 * systime.h (Time): Define only if emacs is defined.
1243 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1244 where the include path doesn't have X11/X.h by default. See
1245 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1246
e23640bb 12472011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1248
1249 * composite.c (find_automatic_composition): Fix previous change.
1250
b9704ad9
GM
12512011-05-20 Glenn Morris <rgm@gnu.org>
1252
1253 * lisp.mk: New file, split from Makefile.in.
1254 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1255 (shortlisp): Remove.
1256 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1257
4a720484
GM
12582011-05-19 Glenn Morris <rgm@gnu.org>
1259
1260 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1261 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1262 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1263 (lisp): Set the order to that of loadup.el.
1264 (shortlisp): Make it a copy of $lisp.
1265 (SOME_MACHINE_LISP): Remove.
1266 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1267 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1268
a28d4396
KH
12692011-05-18 Kenichi Handa <handa@m17n.org>
1270
1271 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1272 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1273 (find_automatic_composition): Mostly rewrite for efficiency.
1274
a2b1fa8e
JB
12752011-05-18 Juanma Barranquero <lekktu@gmail.com>
1276
1277 * makefile.w32-in: Update dependencies.
1278
8e1f5610
CS
12792011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1280
1281 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1282 revision 104625).
1283
7025ee00 12842011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1285
cdfa6eab
PE
1286 Fix some integer overflow issues, such as string length overflow.
1287
06d6db33
PE
1288 * insdel.c (count_size_as_multibyte): Check for string overflow.
1289
2b4560a8
PE
1290 * character.c (lisp_string_width): Check for string overflow.
1291 Use EMACS_INT, not int, for string indexes and lengths; in
1292 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1293 the resulting string length overflows an EMACS_INT; instead,
1294 report a string overflow if no precision given. When checking for
1295 precision exhaustion, use a check that cannot possibly have
1296 integer overflow. (Bug#8675)
1297 * character.h (lisp_string_width): Adjust to new signature.
1298
cb93f9be
PE
1299 * alloc.c (string_overflow): New function.
1300 (Fmake_string): Use it. This doesn't change behavior, but saves
1301 a few bytes and will simplify future changes.
1302 * character.c (string_escape_byte8): Likewise.
1303 * lisp.h (string_overflow): New decl.
1304
1a1f3366
PE
1305 Fixups, following up to the user-interface timestamp change.
1306 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1307 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1308 * msdos.c (mouse_get_pos): Likewise.
1309 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1310 * w32gui.h (Time): Define by including "systime.h" rather than by
1311 declaring it ourselves. (Bug#8664)
1312
d4e3e4d3
PE
1313 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1314 * image.c (clear_image_cache): Likewise.
1315
f6a24d19
PE
1316 * term.c (term_mouse_position): Don't assume time_t wraparound.
1317
08dc5ae6
PE
1318 Be more systematic about user-interface timestamps.
1319 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1320 and sometimes 'EMACS_UINT', to represent these timestamps.
1321 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1322 This makes the code easier to follow, and makes it easier to catch
1323 integer overflow bugs such as Bug#8664.
1324 * frame.c (Fmouse_position, Fmouse_pixel_position):
1325 Use Time, not unsigned long, for user-interface timestamps.
1326 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1327 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1328 * keyboard.h (last_event_timestamp): Likewise.
1329 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1330 * menu.h (xmenu_show): Likewise.
1331 * term.c (term_mouse_position): Likewise.
1332 * termhooks.h (struct input_event.timestamp): Likewise.
1333 (struct terminal.mouse_position_hook): Likewise.
1334 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1335 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1336 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1337 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1338 what it was before.
1339 * menu.h, termhooks.h: Include "systime.h", for Time.
1340
8e55734a
PE
1341 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1342 Don't assume that the difference between two unsigned long values
1343 can fit into an integer. At this point, we know button_down_time
1344 <= event->timestamp, so the difference must be nonnegative, so
1345 there's no need to cast the result if double-click-time is
1346 nonnegative, as it should be; check that it's nonnegative, just in
1347 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1348 apart (about 25 days). (Bug#8664)
8e55734a 1349
841f1b75 1350 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1351 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1352
3e26f69c
PE
1353 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1354 that always fit in int. Use a sentinel instead of a counter, to
1355 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1356 * frame.h (struct frame): Use int for menu_bar_items_used
1357 instead of EMACS_INT, since it always fits in int.
3e26f69c 1358
5cc152c0
PE
1359 * menu.c (grow_menu_items): Check for int overflow.
1360
d89eb65e
PE
1361 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1362
5235bd3e
PE
1363 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1364 Before, the code was not consistent. These values cannot exceed
1365 2**31 - 1 so there's no need to make them unsigned.
1366 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1367 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1368 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1369 as modifiers.
1370 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1371
bc827e23
PE
1372 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1373 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1374 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1375 presumably because the widths might not match.
1376
78eb494e
PE
1377 * window.c (size_window): Avoid needless test at loop start.
1378
04f2d78b
CB
13792011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1380
1381 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1382
d2fc7e3d 13832011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1384
1385 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1386
d2fc7e3d 13872011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1388
1389 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1390 `width' to `bar_area_x' and `bar_area_width', respectively.
1391 (x_scroll_run): Take account of fringe background extension.
1392
04f2d78b
CB
1393 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1394 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1395 `bar_area_width', respectively.
1396 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1397 background extension.
1398
79b70037
GM
13992011-05-10 Jim Meyering <meyering@redhat.com>
1400
1401 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1402
2f142cc5
JB
14032011-05-10 Juanma Barranquero <lekktu@gmail.com>
1404
1405 * image.c (Finit_image_library): Return t for built-in image types,
1406 like pbm and xbm. (Bug#8640)
1407
57679c86
AS
14082011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1409
1410 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1411
888c9e86
EZ
14122011-05-07 Eli Zaretskii <eliz@gnu.org>
1413
b0512a1d
EZ
1414 * w32console.c (Fset_screen_color): Doc fix.
1415 (Fget_screen_color): New function.
1416 (syms_of_ntterm): Defsubr it.
1417
7285dc67
EZ
1418 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1419 unlink the temporary file if Fcall_process didn't create it in the
1420 first place.
1421 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1422 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1423 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1424 cue to call_process_cleanup not to close that handle.
1425
4d3fcc8e
BK
14262011-05-07 Ben Key <bkey76@gmail.com>
1427
1428 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1429 one of two shell specific rules, either bootstrap-temacs-CMD or
1430 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1431 to the previous implementation of the bootstrap-temacs rule.
1432 The bootstrap-temacs-CMD rule is similar to the previous
1433 implementation of the bootstrap-temacs rule except that it
1434 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1435 variable.
1436
1437 These changes, along with some changes to nt/configure.bat,
1438 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1439 earlier fix to add support for --cflags and --ldflags options
1440 that include quotes so that it works whether make uses cmd or
1441 sh as the shell.
1442
b4289b64
MA
14432011-05-06 Michael Albinus <michael.albinus@gmx.de>
1444
1445 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1446 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1447 is a constant.
1448 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1449 a string. Handle both cases.
1450 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1451 (Fdbus_register_method): Use Qinvalid_function.
1452
af4c0e28
JB
14532011-05-06 Juanma Barranquero <lekktu@gmail.com>
1454
1455 * makefile.w32-in: Update dependencies.
1456 (LISP_H): Add inttypes.h and stdin.h.
1457 (PROCESS_H): Add unistd.h.
1458
c51453d9
EZ
14592011-05-06 Eli Zaretskii <eliz@gnu.org>
1460
1461 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1462 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1463
8ff0ac3c 14642011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1465
4c4b566b
PE
1466 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1467
aab2b9b5
PE
1468 * term.c (vfatal): Remove stray call to va_end.
1469 It's not needed and the C Standard doesn't allow it here anyway.
1470
c378da0b
PE
1471 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1472 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1473
288b08c7
PE
1474 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1475 bytes.
1476
e3601888
PE
1477 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1478
db6c0e74
PE
1479 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1480
dd5963ea
PE
1481 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1482
88c9450f
PE
1483 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1484
2f9442b8
PE
1485 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1486
c032b5f8
PE
1487 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1488 * charset.c (Fdefine_charset_internal): Don't initialize
1489 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1490 32-bit int (Bug#8600).
a108c10b
PE
1491
1492 * lread.c (read_integer): Be more consistent with string-to-number.
1493 Use string_to_number to do the actual conversion; this avoids
1494 rounding errors and fixes some other screwups. Without this fix,
1495 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1496 (digit_to_number): Move earlier, for benefit of read_integer.
1497 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1498 not a digit in any supported base. (Bug#8602)
a108c10b 1499
ad5f9eea
PE
1500 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1501
aec1708a
PE
1502 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1503 to match comment at start of function. This also removes a
1504 GCC warning about overflow in a 32+64-bit port.
1505
47be4ab5
PE
1506 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1507
371cac43
PE
1508 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1509 Reported by Stefan Monnier in
1510 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1511 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1512 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1513
d01a7826
PE
1514 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1515 (EMACS_UINTPTR): Likewise, with uintptr_t.
1516
7fd47d5c
PE
1517 * lisp.h: Prefer 64-bit EMACS_INT if available.
1518 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1519 on 32-bit hosts that have 64-bit int, so that they can access
1520 large files.
122b0c86
PE
1521 However, temporarily disable this change unless the temporary
1522 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1523
8727937b
PE
1524 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1525
8ac068ac
PE
1526 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1527 This removes an assumption that EMACS_INT and long are the same
1528 width as pointers. The assumption is true for Emacs porting targets
1529 now, but we want to make other targets possible.
1530 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1531 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1532 In the rest of the code, change types of integers that hold casted
1533 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1534 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1535 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1536 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1537 No need to cast type when ORing.
1538 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1539 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1540 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1541 assume EMACS_INT is the same width as char *.
1542 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1543 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1544 Remove no-longer-needed casts.
1545 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1546 (xg_tool_bar_help_callback, xg_make_tool_item):
1547 Use EMACS_INTPTR to hold an integer
1548 that will be cast to void *; this can avoid a GCC warning
1549 if EMACS_INT is not the same width as void *.
1550 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1551 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1552 (current_message_1, set_message_1):
1553 Use a local to convert to proper width without a cast.
1554 * xmenu.c (dialog_selection_callback): Likewise.
1555
ede49d71
PE
1556 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1557 Also, don't assume VALBITS / RAND_BITS is less than 5,
1558 and don't rely on undefined behavior when shifting a 1 left into
1559 the sign bit.
1560 * lisp.h (get_random): Change signature to match.
1561
2f30ecd0
PE
1562 * lread.c (hash_string): Use size_t, not int, for hash computation.
1563 Normally we prefer signed values; but hashing is special, because
1564 it's better to use unsigned division on hash table sizes so that
1565 the remainder is nonnegative. Also, size_t is the natural width
1566 for hashing into memory. The previous code used 'int', which doesn't
1567 retain enough info to hash well into very large tables.
1568 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1569
2a866e7b
PE
1570 * dbusbind.c: Don't possibly lose pointer info when converting.
1571 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1572 Use XPNTR rather than XHASH, so that the high-order bits of
1573 the pointer aren't lost when converting through void *.
1574
51639eac
PE
1575 * eval.c (Fautoload): Don't double-shift a pointer.
1576
92394119
PE
1577 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1578
dbdb9a7c
JB
15792011-05-06 Juanma Barranquero <lekktu@gmail.com>
1580
1581 * gnutls.c (DEF_GNUTLS_FN):
1582 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1583
db7a0b4f
AS
15842011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1585
1586 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1587 marker. (Bug#8610)
1588
f7ff1b0f 15892011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1590
1591 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1592 New version that can reserve upto 2GB of heap space.
1593
f7ff1b0f 15942011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1595
1596 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1597
639c109b
TZ
15982011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1599
1600 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1601 `gnutls_certificate_set_x509_key_file'.
1602
d2127135
JB
16032011-05-05 Juanma Barranquero <lekktu@gmail.com>
1604
1605 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1606 Update dependencies.
1607
e968f4f3
JB
16082011-05-04 Juanma Barranquero <lekktu@gmail.com>
1609
1610 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1611 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1612 Remove unused parameter `fildes'.
1613 * process.c (read_process_output, send_process): Don't pass it.
1614
84d358f0
JB
16152011-05-04 Juanma Barranquero <lekktu@gmail.com>
1616
1617 Fix previous change: the library cache is defined in w32.c.
1618 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1619 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1620
0898ca10
JB
16212011-05-04 Juanma Barranquero <lekktu@gmail.com>
1622
1623 Implement dynamic loading of GnuTLS on Windows.
1624
1625 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1626 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1627 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1628 Declare.
1629
1630 * gnutls.c (Qgnutls_dll): Define.
1631 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1632 (gnutls_*): Declare function pointers.
1633 (init_gnutls_functions): New function to initialize function pointers.
1634 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1635 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1636 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1637 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1638 (emacs_gnutls_write, emacs_gnutls_read)
1639 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1640 (Fgnutls_available_p): New function.
1641 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1642 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1643 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1644
1645 * image.c: Include w32.h.
1646 (Vimage_type_cache): Delete.
1647 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1648 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1649 (w32_delayed_load): Move to w32.c.
1650
1651 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1652
1653 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1654 (w32_delayed_load): Move from image.c. When loading a library, record
1655 its filename in the :loaded-from property of the library id.
1656 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1657 Initialize and staticpro them.
1658 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1659
1660 * process.c: Include lisp.h before w32.h, not after.
1661 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1662 instead of gnutls_record_check_pending.
1663
1664 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1665
ff4de4aa
TZ
16662011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1667
1668 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1669 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1670 as passed in.
1671
abe95abb
JD
16722011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1673
1674 * xterm.c (x_set_frame_alpha): Do not set property on anything
1675 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1676
e16e55d4
JB
16772011-05-02 Juanma Barranquero <lekktu@gmail.com>
1678
1679 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1680
bafcf6a5
JB
16812011-05-02 Juanma Barranquero <lekktu@gmail.com>
1682
1683 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1684 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1685 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1686 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1687 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1688 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1689 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1690 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1691 (Qgnutls_bootprop_callbacks_verify): Make static.
1692
e7a6747f
AS
16932011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1694
19ed11ba
AS
1695 * callproc.c: Indentation fixup.
1696
e7a6747f 1697 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1698 (wait_for_termination, interruptible_wait_for_termination):
1699 Move after wait_for_termination_1.
e7a6747f 1700
1ef14cb4
LMI
17012011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1702
1703 * sysdep.c (interruptible_wait_for_termination): New function
1704 which is like wait_for_termination, but allows keyboard
1705 interruptions.
1706
1707 * callproc.c (Fcall_process): Add (:file "file") as an option for
1708 the STDOUT buffer.
1709 (Fcall_process_region): Ditto.
1710
330d880c
EZ
17112011-04-30 Eli Zaretskii <eliz@gnu.org>
1712
8db90b73
EZ
1713 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1714 rather than `XVECTOR (FOO)->size'.
1715
330d880c
EZ
1716 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1717 inttypes.h, as a gnulib replacement is used if it not available in
1718 system headers.
1719
15cbd324
EZ
17202011-04-21 Eli Zaretskii <eliz@gnu.org>
1721
1722 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1723 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1724 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1725
1726 * coding.c (coding_alloc_by_realloc): Error out if destination
1727 will grow beyond MOST_POSITIVE_FIXNUM.
1728 (decode_coding_emacs_mule): Abort if there isn't enough place in
1729 charbuf for the composition carryover bytes. Reserve an extra
1730 space for up to 2 characters produced in a loop.
1731 (decode_coding_iso_2022): Abort if there isn't enough place in
1732 charbuf for the composition carryover bytes.
1733
17342011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1735
ae940cca
EZ
1736 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1737 aborting when %lld or %lll format is passed.
1738 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1739 %llo or %llx format is passed. (Bug#8545)
1740
03ab8921
EZ
1741 * window.c (window_scroll_line_based): Use a marker instead of
1742 simple variables to record original value of point. (Bug#7952)
1743
afda1437
EZ
1744 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1745 produced by %s or %c overflows available buffer space. (Bug#8545)
1746
f76dee0c
PE
17472011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1750 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1751
fdc5744d
JB
17522011-04-28 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1755
638f053a
JB
17562011-04-28 Juanma Barranquero <lekktu@gmail.com>
1757
1758 * keyboard.c (Qdelayed_warnings_hook): Define.
1759 (command_loop_1): Run `delayed-warnings-hook'
1760 if Vdelayed_warnings_list is non-nil.
1761 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1762 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1763
d178f871
EZ
17642011-04-28 Eli Zaretskii <eliz@gnu.org>
1765
1766 * doprnt.c (doprnt): Don't return value smaller than the buffer
1767 size if the message was truncated. (Bug#8545).
1768
b124fd93
JB
17692011-04-28 Juanma Barranquero <lekktu@gmail.com>
1770
1771 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1772 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1773
e810457d
PE
17742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1775
1776 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1777
ea51cceb
JB
17782011-04-27 Juanma Barranquero <lekktu@gmail.com>
1779
1780 * makefile.w32-in: Update dependencies.
1781
94dcfacf
EZ
17822011-04-27 Eli Zaretskii <eliz@gnu.org>
1783
1784 Improve `doprnt' and its usage. (Bug#8545)
1785 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1786 `format_end'. Remove support for %l as a conversion specifier.
1787 Don't use xrealloc. Improve diagnostics when the %l size modifier
1788 is used. Update the commentary.
1789
1790 * eval.c (verror): Simplify calculation of size_t.
1791
1792 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1793 messages.
1794
f61f41d7
PE
17952011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1796
1797 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1798 change.
1799
96fb4434
PE
18002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1803 This makes this file independent of the recent pseudovector change.
1804
671875da 18052011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1806
69e9b5a3
PE
1807 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1808
b5f869a7 1809 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1810 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1811 Remove unused local.
c8926152 1812 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1813
841a1577 1814 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1815 GCC 4.6.0 optimizes based on type-based alias analysis.
1816 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1817 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1818 != &v->size, and therefore "v->size = 1; b->size = 2; return
1819 v->size;" must therefore return 1. This assumption is incorrect
1820 for Emacs, since it type-puns struct Lisp_Vector * with many other
1821 types. To fix this problem, this patch adds a new type struct
f904488f 1822 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1823 and pseudovectors, and helps optimizing compilers not get fooled
1824 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1825 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1826 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1827 the size member.
eab3844f
PE
1828 (XSETPVECTYPE): Rewrite in terms of new macro.
1829 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1830 This is a bit clearer, and further avoids the possibility of
1831 undesirable aliasing.
1832 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1833 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1834 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1835 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1836 (ASIZE): Now uses header.size rather than size.
1837 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1838 to avoid the hassle of writing XVECTOR (foo)->header.size.
1839 (struct vectorlike_header): New type.
eab3844f
PE
1840 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1841 object, to help avoid aliasing.
1842 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1843 (SUBRP): Likewise, since Lisp_Subr is a special case.
1844 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1845 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1846 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1847 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1848 changed to be "header.size" and "header.next".
1849 * buffer.h (struct buffer): Likewise.
1850 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1851 * frame.h (struct frame): Likewise.
1852 * process.h (struct Lisp_Process): Likewise.
1853 * termhooks.h (struct terminal): Likewise.
1854 * window.c (struct save_window_data, struct saved_window): Likewise.
1855 * window.h (struct window): Likewise.
1856 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1857 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1858 * buffer.c (init_buffer_once): Likewise.
1859 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1860 special case.
1861 * process.c (Fformat_network_address): Use local var for size,
1862 for brevity.
1863
0df1eac5
PE
1864 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1865
847ab9d1 1866 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1867 * data.c (atof): Remove decl; no longer used or needed.
1868 (digit_to_number): Move to lread.c.
1869 (Fstring_to_number): Use new string_to_number function, to be
1870 consistent with how the Lisp reader treats infinities and NaNs.
1871 Do not assume that floating-point numbers represent EMACS_INT
1872 without losing information; this is not true on most 64-bit hosts.
1873 Avoid double-rounding errors, by insisting on integers when
1874 parsing non-base-10 numbers, as the documentation specifies.
1875 * lisp.h (string_to_number): New decl, replacing ...
1876 (isfloat_string): Remove.
bc0a5c13 1877 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1878 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1879 appears to have been a coding error. Similarly, do not accept
1880 strings like +-1e0 as floating point numbers. Do not report
1881 overflow for integer overflows unless the base is not 10 which
1882 means we have no simple and reliable way to continue.
1883 Break out the floating-point parsing into a new
1884 function string_to_number, so that Fstring_to_number parses
1885 floating point numbers consistently with the Lisp reader.
04f2d78b 1886 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1887 (E_CHAR, EXP_INT): Remove, replacing with ...
1888 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1889 (string_to_number): New function, replacing isfloat_string.
1890 This function checks for valid syntax and produces the resulting
1891 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1892 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1893 so that overflow for non-base-10 numbers is reported only when
1894 there's no portable and simple way to convert to floating point.
452f4150 1895
67769ffc
PE
1896 * textprop.c (set_text_properties_1): Rewrite for clarity,
1897 and to avoid GCC warning about integer overflow.
1898
c20db43f
PE
1899 * intervals.h (struct interval): Use EMACS_INT for members
1900 where EMACS_UINT might cause problems. See
1901 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1902 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1903 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1904 All uses changed.
37aa2f85
PE
1905 (offset_intervals): Tell GCC not to worry about length overflow
1906 when negating a negative length.
c20db43f 1907
2538aa2f
PE
1908 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1909 (overrun_check_free): Likewise.
1910
f2d3008d
PE
1911 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1912 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1913 word size.
1914
ec8df744
PE
1915 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1916 (gnutls_make_error): Rename local to avoid shadowing.
1917 (gnutls_emacs_global_deinit): ifdef out; not used.
1918 (Fgnutls_boot): Use const for pointer to readonly storage.
1919 Comment out unused local. Fix pointer signedness problems.
1920
640ee02d
PE
1921 * lread.c (openp): Don't stuff size_t into an 'int'.
1922 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1923 about possible signed overflow.
1924
6048fb2a
PE
1925 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1926 (GDK_KEY_g): Don't define if already defined.
1927 (xg_prepare_tooltip): Avoid pointer signedness problem.
1928 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1929
fa3c87e1
PE
1930 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1931 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1932
2172544b
PE
1933 * xfns.c (Fx_window_property): Simplify a bit,
1934 to make a bit faster and to avoid GCC 4.6.0 warning.
1935 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1936
9b821a21
PE
1937 * fns.c (internal_equal): Don't assume size_t fits in int.
1938
3c616cfa
PE
1939 * alloc.c (compact_small_strings): Tighten assertion a little.
1940
c2982e87
PE
1941 Replace pEd with more-general pI, and fix some printf arg casts.
1942 * lisp.h (pI): New macro, generalizing old pEd macro to other
1943 conversion specifiers. For example, use "...%"pI"d..." rather
1944 than "...%"pEd"...".
1945 (pEd): Remove. All uses replaced with similar uses of pI.
1946 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1947 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1948 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1949 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1950 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1951 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1952 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1953 64-bit hosts.
1954 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1955 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1956 * print.c (safe_debug_print, print_object): Likewise.
1957 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1958 to int.
6f04d126
PE
1959 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1960 avoiding the 0 flag, which is not portable.
c2982e87
PE
1961 * process.c (Fmake_network_process): Use pI to avoid cast.
1962 * region-cache.c (pp_cache): Likewise.
1963 * xdisp.c (decode_mode_spec): Likewise.
1964 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1965 behavior on 64-bit hosts with printf arg.
6f04d126 1966 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1967 (x_stop_queuing_selection_requests): Likewise.
1968 (x_get_window_property): Don't truncate byte count to an 'int'
1969 when tracing.
0b432f21 1970
5e073ec7
PE
1971 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1972 here, since it parses constructs like leading '-' and spaces,
1973 which are not wanted; and it overflows with large numbers.
1974 Instead, simply match F[0-9]+, which is what is wanted anyway.
1975
36372bf9
PE
1976 * alloc.c: Remove unportable assumptions about struct layout.
1977 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1978 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1979 (allocate_vectorlike, make_pure_vector): Use the new macros,
1980 plus offsetof, to remove unportable assumptions about struct layout.
1981 These assumptions hold on all porting targets that I know of, but
1982 they are not guaranteed, they're easy to remove, and removing them
1983 makes further changes easier.
1984
0b432f21
PE
1985 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1986 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1987 (string_overrun_cookie): Now const. Use initializers that
1988 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1989 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1990 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1991 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1992 multiple of sizeof (EMACS_INT); it need not be, if
1993 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1994 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1995
895009e1
JB
19962011-04-26 Juanma Barranquero <lekktu@gmail.com>
1997
1998 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1999
6a7a1b0b
TZ
20002011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2001
2002 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2003 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2004 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2005
841a1577 20062011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2007
2008 * lisp.h (Qdebug): List symbol.
895009e1 2009 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2010 * keyboard.c (debug-on-event): New variable.
2011 (handle_user_signal): Break into debugger when debug-on-event
2012 matches the current signal symbol.
2013
f2d3ba6f
DN
20142011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2015
2016 * alloc.c (check_sblock, check_string_bytes)
2017 (check_string_free_list): Convert to standard C.
2018
42ce4c63
TZ
20192011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2020
2021 * w32.c (emacs_gnutls_push): Fix typo.
2022
825cd63c
EZ
20232011-04-25 Eli Zaretskii <eliz@gnu.org>
2024
fb11d64d
EZ
2025 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2026 "cast to pointer from integer of different size".
2027
825cd63c
EZ
2028 Improve doprnt and its use in verror. (Bug#8545)
2029 * doprnt.c (doprnt): Document the set of format control sequences
2030 supported by the function. Use SAFE_ALLOCA instead of always
2031 using `alloca'.
2032
2033 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2034 is one byte too soon. Don't use xrealloc; instead xfree and
2035 xmalloc anew.
2036
e061a11b
TZ
20372011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2038
2039 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2040 callbacks stage.
2041
2042 * gnutls.c: Renamed global_initialized to
2043 gnutls_global_initialized. Added internals for the
2044 :verify-hostname-error, :verify-error, and :verify-flags
2045 parameters of `gnutls-boot' and documented those parameters in the
2046 docstring. Start callback support.
2047 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2048 unless a fatal error occured. Call gnutls_alert_send_appropriate
2049 on error. Return error code.
2050 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2051 (emacs_gnutls_read): Likewise.
2052 (Fgnutls_boot): Return handshake error code.
2053 (emacs_gnutls_handle_error): New function.
2054 (wsaerror_to_errno): Likewise.
2055
2056 * w32.h (emacs_gnutls_pull): Add prototype.
2057 (emacs_gnutls_push): Likewise.
2058
2059 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2060 (emacs_gnutls_push): Likewise.
2061
20622011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2063
2064 * process.c (wait_reading_process_output): Check if GnuTLS
2065 buffered some data internally if no FDs are set for TLS
2066 connections.
2067
2068 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2069 (LIBS): Link to USER_LIBS.
2070 ($(BLD)/gnutls.$(0)): New target.
2071
fa6996bc
EZ
20722011-04-24 Eli Zaretskii <eliz@gnu.org>
2073
eb35682e
EZ
2074 * xdisp.c (handle_single_display_spec): Rename the
2075 display_replaced_before_p argument into display_replaced_p, to
2076 make it consistent with the commentary. Fix typos in the
2077 commentary.
2078
e2ad650c
EZ
2079 * textprop.c (syms_of_textprop): Remove dead code.
2080 (copy_text_properties): Delete obsolete commentary about an
2081 interface that was deleted long ago. Fix typos in the description
2082 of arguments.
2083
1b2de274
EZ
2084 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2085 to changes in oldXMenu/XMenu.h from 2011-04-16.
2086 <menu_help_message, prev_menu_help_message>: Constify.
2087 (IT_menu_make_room): menu->help_text is now `const char **';
2088 adjust.
2089
2090 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2091 to changes in oldXMenu/XMenu.h from 2011-04-16.
2092 (struct XMenu): Declare `help_text' `const char **'.
2093
2094 * xfaces.c <Qunspecified>: Make extern again.
2095
2096 * syntax.c: Include sys/types.h before including regex.h, as
2097 required by Posix.
2098
762b15be
EZ
2099 * doc.c (get_doc_string): Improve the format passed to `error'.
2100
2101 * doprnt.c (doprnt): Improve commentary.
2102
2103 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2104
2105 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2106 them with etags.
2107
f1052e5d
EZ
2108 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2109 changes in globals.h immediately force recompilation.
762b15be
EZ
2110 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2111 $(CURDIR)/s/ms-w32.h.
2112 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2113
fa6996bc
EZ
2114 * character.c (Fchar_direction): Function deleted.
2115 (syms_of_character): Don't defsubr it.
2116 <char-direction-table>: Deleted.
2117
e6c3da20
EZ
21182011-04-23 Eli Zaretskii <eliz@gnu.org>
2119
2120 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2121 * doprnt.c: Include limits.h.
2122 (SIZE_MAX): New macro.
04f2d78b
CB
2123 (doprnt): Return a size_t value. 2nd arg is now size_t.
2124 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2125 Improve overflow protection. Support `l' modifier for integer
2126 conversions. Support %l conversion. Don't assume an EMACS_INT
2127 argument for integer conversions and for %c.
2128
2129 * lisp.h (doprnt): Restore prototype.
2130
2131 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2132 $(SRC)/character.h.
2133
2134 * Makefile.in (base_obj): Add back doprnt.o.
2135
2136 * deps.mk (doprnt.o): Add back prerequisites.
2137 (callint.o): Depend on character.h.
2138
2139 * eval.c (internal_lisp_condition_case): Include the handler
2140 representation in the error message.
2141 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2142 when breaking from the loop.
2143
2144 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2145
2146 * callint.c (Fcall_interactively): When displaying error message
2147 about invalid control letter, pass the character's codepoint, not
2148 a pointer to its multibyte form. Improve display of the character
2149 in octal and display also its hex code.
2150
2151 * character.c (char_string): Use %x to display the (unsigned)
2152 codepoint of an invalid character, to avoid displaying a bogus
2153 negative value.
2154
2155 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2156 `error', not SYMBOL_NAME itself.
2157
2158 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2159 character arguments to `error'.
2160
2161 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2162 to `error' in error message about FINAL_CHAR argument. Make sure
2163 FINAL_CHAR is a character, and use %c when it is passed as
2164 argument to `error'.
2165
4ffd0d6b 21662011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2167
2168 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2169
2170 * w32.c: Include <time.h>.
2171 (sys_localtime): New function.
2172
4ffd0d6b 21732011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2174
2175 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2176
4ffd0d6b 2177 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2178
4ffd0d6b 21792011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2180
4ffd0d6b
GM
2181 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2182 zombies (Bug#8467).
aac0c6e3 2183
04c56954
EZ
21842011-04-19 Eli Zaretskii <eliz@gnu.org>
2185
2186 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2187 gl_state.e_property when gl_state.object is Qt.
2188
2189 * insdel.c (make_gap_larger): Remove limitation of buffer size
2190 to <= INT_MAX.
2191
16a43933
CY
21922011-04-18 Chong Yidong <cyd@stupidchicken.com>
2193
2194 * xdisp.c (lookup_glyphless_char_display)
2195 (produce_glyphless_glyph): Handle cons cell entry in
2196 glyphless-char-display.
2197 (Vglyphless_char_display): Document it.
2198
2199 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2200 glyphless-char-display.
2201
4581706e
CY
22022011-04-17 Chong Yidong <cyd@stupidchicken.com>
2203
2204 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2205
2206 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2207
2208 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2209 definition for no-X builds.
2210
4887c6e2 22112011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2212
fd35b6f9
PE
2213 Static checks with GCC 4.6.0 and non-default toolkits.
2214
5c1ccb01
PE
2215 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2216
006c5daa
PE
2217 * process.c (keyboard_bit_set): Define only if SIGIO.
2218 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2219 (send_process): Repair possible setjmp clobbering.
2220
efc736d3
PE
2221 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2222
4e2fe2e6
PE
2223 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2224
f97334a2
PE
2225 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2226
4e75f29d
PE
2227 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2228 Define only if needed.
2229
90efadd1
PE
2230 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2231 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2232 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2233
3c647824
PE
2234 * dispextern.h (struct redisplay_interface): Rename param
2235 to avoid shadowing.
e264f262 2236 * termhooks.h (struct terminal): Likewise.
761383f4 2237 * xterm.c (xembed_send_message): Likewise.
3c647824 2238
b58c5c4a
PE
2239 * insdel.c (make_gap_smaller): Define only if
2240 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2241
cad59032
PE
2242 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2243 it.
2244
c339dc2e
PE
2245 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2246 so that we aren't warned about unused symbols.
2247
91a3e27b
PE
2248 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2249
399c71d3 2250 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2251
8ffc96f5
PE
2252 * xfns.c (x_real_positions): Mark locals as initialized.
2253
eef9bc79
PE
2254 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2255
098db9dd
PE
2256 * xterm.c: Fix problems found by static analysis with other toolkits.
2257 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2258 (x_dispatch_event): Declare static if USE_GTK, and
2259 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2260 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2261 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2262 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2263 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2264
eb18f6cc
PE
2265 * xmenu.c (menu_help_callback): Pointer type fixes.
2266 Use const pointers when pointing at readonly data. Avoid pointer
2267 signedness clashes.
2268 (FALSE): Remove unused macro.
2269 (update_frame_menubar): Remove unused decl.
2270
1fe72bf8
PE
2271 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2272
60d9e1db
PE
2273 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2274 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2275 (single_menu_item): Rename local to avoid shadowing.
2276
39261c26
PE
2277 * keyboard.c (make_lispy_event): Remove unused local var.
2278
018c5e19
PE
2279 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2280 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2281
63d2b86e
PE
2282 * bitmaps: Change bitmaps from unsigned char back to the X11
2283 compatible char. Avoid the old compiler warnings about
2284 out-of-range initializers by using, for example, '\xab' rather
2285 than 0xab.
2286
aefd87e1
PE
2287 * xgselect.c (xgselect_initialize): Check vs interface
2288 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2289
bf501fb9
PE
2290 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2291
e9829fdf
PE
2292 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2293 to read-only memory.
2294
1086c095
PE
2295 * fns.c (vector): Remove; this old hack is no longer needed.
2296
2baccd04 2297 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2298 Remove unused var.
dde42981 2299 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2300
72391843 2301 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2302
436c16df 2303 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2304 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2305 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2306
92bb796d 2307 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2308 (x_term_init): Remove local to avoid shadowing.
92bb796d 2309
764430a3 2310 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2311
2312 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2313 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2314
d1dfb56c
EZ
23152011-04-16 Eli Zaretskii <eliz@gnu.org>
2316
c4354cb4
EZ
2317 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2318
d1dfb56c
EZ
2319 Fix regex.c, syntax.c and friends for buffers > 2GB.
2320 * syntax.h (struct gl_state_s): Declare character position members
2321 EMACS_INT.
2322
2323 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2324
04f2d78b
CB
2325 * textprop.c (verify_interval_modification, interval_of):
2326 Declare arguments EMACS_INT.
d1dfb56c
EZ
2327
2328 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2329 EMACS_INT.
2330
2331 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2332
2333 * indent.c (Fvertical_motion): Local variable it_start is now
2334 EMACS_INT.
2335
2336 * regex.c (re_match, re_match_2, re_match_2_internal)
2337 (bcmp_translate, regcomp, regexec, print_double_string)
2338 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2339 (re_compile_pattern, re_exec): Declare arguments and local
2340 variables `size_t' and `ssize_t' and return values `regoff_t', as
2341 appropriate.
2342 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2343 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2344 <compile_stack_type>: `size' and `avail' are now `size_t'.
2345
2346 * regex.h <regoff_t>: Use ssize_t, not int.
2347 (re_search, re_search_2, re_match, re_match_2): Arguments that
2348 specify buffer/string position and length are now ssize_t and
2349 size_t. Return type is regoff_t.
2350
613052cd
BK
23512011-04-16 Ben Key <bkey76@gmail.com>
2352
2353 * nsfont.m: Fixed bugs in ns_get_family and
2354 ns_descriptor_to_entity that were caused by using free to
2355 deallocate memory blocks that were allocated by xmalloc (via
2356 xstrdup). This caused Emacs to crash when compiled with
2357 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2358 --enable-checking=xmallocoverrun). xfree is now used to
2359 deallocate these memory blocks.
2360
4170f62f 23612011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2362
71b41406
PE
2363 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2364
9587a89d
PE
2365 emacs_write: Accept and return EMACS_INT for sizes.
2366 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2367 et seq.
2368 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2369 Accept and return EMACS_INT.
2370 (emacs_gnutls_write): Return the number of bytes written on
2371 partial writes.
2372 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2373 (emacs_read, emacs_write): Remove check for negative size, as the
2374 Emacs source code has been audited now.
9587a89d
PE
2375 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2376 (emacs_read, emacs_write): Use it.
273a5f82
PE
2377 * process.c (send_process): Adjust to the new signatures of
2378 emacs_write and emacs_gnutls_write. Do not attempt to store
2379 a byte offset into an 'int'; it might overflow.
9587a89d 2380 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2381
3e047f51
PE
2382 * sound.c: Don't assume sizes fit in 'int'.
2383 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2384 Return EMACS_INT, not int.
3e047f51 2385 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2386 Accept EMACS_INT, not int.
2387 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2388 record read return values.
2389
cc39a9db
BK
23902011-04-15 Ben Key <bkey76@gmail.com>
2391
c9d0ec6d
JB
2392 * keyboard.c (Qundefined): Don't declare static since it is used
2393 in nsfns.m.
2394 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2395 static since they are used in nsfont.m.
cc39a9db 2396
6c60eb9f
SM
23972011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2398
2399 * process.c (Qprocessp): Don't declare static.
2400 * lisp.h (Qprocessp): Declare again.
2401
7990b61a
JB
24022011-04-15 Juanma Barranquero <lekktu@gmail.com>
2403
2404 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2405
5d4cb038
PE
24062011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2407
8bd7b830 2408 Improve C-level modularity by making more things 'static'.
cd64ea1d 2409
e3b27b31
PE
2410 Don't publish debugger-only interfaces to other modules.
2411 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2412 (verify_bytepos, count_markers): Move decls to the only modules
2413 that need them.
2414 * region-cache.h (pp_cache): Likewise.
2415 * window.h (check_all_windows): Likewise.
2416 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2417
5d4cb038
PE
2418 * sysdep.c (croak): Now static, if
2419 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2420 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2421
2422 * alloc.c (refill_memory_reserve): Now static if
2423 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2424 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2425
e87b6180
PE
2426 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2427 Define only if USE_LUCID.
2428
ac64929e
PE
2429 * xrdb.c (x_customization_string, x_rm_string): Now static.
2430
6f37259d
PE
2431 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2432 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2433
1683e3ab
PE
2434 * xdisp.c (draw_row_with_mouse_face): Now static.
2435 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2436
de9c2632
PE
2437 * window.h (check_all_windows): Mark externally visible.
2438
2b96acb7
PE
2439 * window.c (window_deletion_count): Now static.
2440
2441 * undo.c: Make symbols static if they're not exported.
2442 (last_undo_buffer, last_boundary_position, pending_boundary):
2443 Now static.
2444
50436f33
PE
2445 * textprop.c (interval_insert_behind_hooks): Now static.
2446 (interval_insert_in_front_hooks): Likewise.
2447
64520e5c
PE
2448 * term.c: Make symbols static if they're not exported.
2449 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2450 (max_frame_lines, tty_set_terminal_modes):
2451 (tty_reset_terminal_modes, tty_turn_off_highlight):
2452 (get_tty_terminal): Now static.
2453 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2454 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2455 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2456 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2457 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2458
1fa53021
PE
2459 * sysdep.c: Make symbols static if they're not exported.
2460 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2461 Now static.
2462 (sigprocmask_set, full_mask): Remove; unused.
2463 (wait_debugging): Mark as visible.
2464 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2465 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2466
d4b43b22
PE
2467 * syntax.c (syntax_temp): Define only if !__GNUC__.
2468
b7c513d0
PE
2469 * sound.c (current_sound_device, current_sound): Now static.
2470
989b29ad
PE
2471 * search.c (searchbufs, searchbuf_head): Now static.
2472
13a55a78
PE
2473 * scroll.c (scroll_cost): Remove; unused.
2474 * dispextern.h (scroll_cost): Remove decl.
2475
de68a1fc
PE
2476 * region-cache.h (pp_cache): Mark as externally visible.
2477
40ccffa6
PE
2478 * process.c: Make symbols static if they're not exported.
2479 (process_tick, update_tick, create_process, chan_process):
2480 (Vprocess_alist, proc_buffered_char, datagram_access):
2481 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2482 (deactivate_process): Mark defn as static, as well as decl.
2483 * lisp.h (create_process): Remove decl.
2484 * process.h (chan_process, Vprocess_alist): Remove decls.
2485
ad64fc97
PE
2486 * print.c: Make symbols static if they're not exported.
2487 (print_depth, new_backquote_output, being_printed, print_buffer):
2488 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2489 (print_interval, print_number_index, initial_stderr_stream):
2490 Now static.
2491 * lisp.h (Fprinc): Remove decl.
2492 (debug_output_compilation_hack): Mark as externally visible.
2493
adddb265
PE
2494 * sysdep.c (croak): Move decl from here to syssignal.h.
2495 * syssignal.h (croak): Put it here, so the API can be checked when
2496 'croak' is called from dissociate_if_controlling_tty.
2497
1717ede2
PE
2498 * minibuf.c: Make symbols static if they're not exported.
2499 (minibuf_save_list, choose_minibuf_frame): Now static.
2500 * lisp.h (choose_minibuf_frame): Remove decl.
2501
fa5fb2bc
PE
2502 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2503
1e3890d1
PE
2504 * lread.c: Make symbols static if they're not exported.
2505 (read_objects, initial_obarray, oblookup_last_bucket_number):
2506 Now static.
2507 (make_symbol): Remove; unused.
2508 * lisp.h (initial_obarray, make_symbol): Remove decls.
2509
8a1414fa
PE
2510 * keyboard.c: Make symbols static if they're not exported.
2511 (single_kboard, recent_keys_index, total_keys, recent_keys):
2512 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2513 (this_single_command_key_start, echoing, last_auto_save):
2514 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2515 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2516 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2517 (Vlispy_mouse_stem, double_click_count):
2518 Now static.
2519 (force_auto_save_soon): Define only if SIGDANGER.
2520 (ignore_mouse_drag_p): Now static if
2521 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2522 (print_help): Remove; unused.
2523 (stop_character, last_timer_event): Mark as externally visible.
2524 * keyboard.h (ignore_mouse_drag_p): Declare only if
2525 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2526 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2527 * lisp.h (echoing): Remove decl.
2528 (force_auto_save_soon): Declare only if SIGDANGER.
2529 * xdisp.c (redisplay_window): Simplify code, to make it more
2530 obvious that ignore_mouse_drag_p is not accessed if !defined
2531 USE_GTK && !defined HAVE_NS.
2532
93ea6e8f
PE
2533 * intervals.c: Make symbols static if they're not exported.
2534 (merge_properties_sticky, merge_interval_right, delete_interval):
2535 Now static.
2536 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2537
77382fcc
PE
2538 * insdel.c: Make symbols static if they're not exported.
2539 However, leave prepare_to_modify_buffer alone. It's never
2540 called from outside this function, but that appears to be a bug.
2541 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2542 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2543 (adjust_after_replace_noundo): Remove; unused.
2544 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2545 (signal_before_change): Remove decls.
77382fcc 2546
9306c32e
PE
2547 * indent.c (val_compute_motion, val_vmotion): Now static.
2548
cd44d2eb
PE
2549 * image.c: Make symbols static if they're not exported.
2550 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2551 if USE_GTK.
2552 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2553 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2554
ad9a7a06
PE
2555 * fringe.c (standard_bitmaps): Now static.
2556 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2557
81626931
PE
2558 * frame.c: Make symbols static if they're not exported.
2559 (x_report_frame_params, make_terminal_frame): Now static.
2560 (get_frame_param): Now static, unless HAVE_NS.
2561 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2562 (x_get_resource_string): Remove; not used.
2563 * frame.h (make_terminal_frame, x_report_frame_params):
2564 (x_get_resource_string); Remove decls.
2565 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2566 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2567
239f9db9
PE
2568 * font.c, fontset.c: Make symbols static if they're not exported.
2569 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2570 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2571 * font.c (font_close_object): Now static.
2572 * font.h (font_close_object): Remove.
2573 * fontset.c (FONTSET_OBJLIST): Remove.
2574 (free_realized_fontset) #if-0 the body, which does nothing.
2575 (face_suitable_for_char_p): #if-0, as it's never called.
2576 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2577 * xfaces.c (face_at_string_position):
2578 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2579 since 0 is always ASCII.
2580
dfcf3579
PE
2581 * fns.c (weak_hash_tables): Now static.
2582
5045092b
PE
2583 * fileio.c: Make symbols static if they're not exported.
2584 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2585 (Vwrite_region_annotation_buffers): Now static.
2586
57a96f5c
PE
2587 * eval.c: Make symbols static if they're not exported.
2588 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2589 * lisp.h (backtrace_list): Remove decl.
2590
35f08c38
PE
2591 * emacs.c: Make symbols static if they're not exported.
2592 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2593 (fatal_error_code, fatal_error_signal_hook, standard_args):
2594 Now static.
2595 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2596 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2597 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2598 * lisp.h (fatal_error_signal_hook): Remove decl.
2599 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2600
f44bd759
PE
2601 * editfns.c: Move a (normally-unused) function to its only use.
2602 * editfns.c, lisp.h (get_operating_system_release): Remove.
2603 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2604 worth the hassle of breaking this out.
2605
b532497d
PE
2606 * xterm.c: Make symbols static if they're not exported.
2607 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2608 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2609 (x_destroy_window, x_delete_display):
2610 Now static.
2611 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2612 (x_mouse_leave): Remove; unused.
2613 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2614 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2615 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2616 Remove decls.
2617 (x_mouse_leave): Declare only if WINDOWSNT.
2618 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2619 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2620 USE_X_TOOLKIT.
2621
1675728f
PE
2622 * ftxfont.c: Make symbols static if they're not exported.
2623 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2624 HAVE_FREETYPE.
2625 * font.h (ftxfont_driver): Likewise.
2626
e4cebfca
PE
2627 * xfns.c: Make symbols static if they're not exported.
2628 (x_last_font_name, x_display_info_for_name):
2629 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2630 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2631 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2632 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2633 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2634 (last_show_tip_args): Now static.
2635 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2636 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2637 (x_screen_planes): Remove; unused.
2638 * dispextern.h (x_screen_planes): Remove decl.
2639
5bf46f05
PE
2640 * dispnew.c: Make symbols static if they're not exported.
2641 * dispextern.h (redraw_garbaged_frames, scrolling):
2642 (increment_row_positions): Remove.
2643 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2644 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2645 Now static.
2646 (redraw_garbaged_frames): Remove; unused.
2647
435f4c28
PE
2648 * xfaces.c: Make symbols static if they're not exported.
2649 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2650 Remove decls.
2651 * xterm.h (defined_color): Remove decls.
2652 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2653 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2654 (menu_face_changed_default, defined_color, free_realized_face):
2655 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2656 (ascii_face_of_lisp_face): Remove; unused.
2657
8524aef3
PE
2658 * xdisp.c: Make symbols static if they're not exported.
2659 * dispextern.h (scratch_glyph_row, window_box_edges):
2660 (glyph_to_pixel_coords, set_cursor_from_row):
2661 (get_next_display_element, set_iterator_to_next):
2662 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2663 (show_mouse_face): Remove decls
2664 * frame.h (message_buf_print): Likewise.
2665 * lisp.h (pop_message, set_message, check_point_in_composition):
2666 Likewise.
2667 * xterm.h (set_vertical_scroll_bar): Likewise.
2668 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2669 (message_buf_print, scratch_glyph_row, displayed_buffer):
2670 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2671 (get_next_display_element, show_mouse_face, window_box_edges):
2672 (frame_to_window_pixel_xy, check_point_in_composition):
2673 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2674 (glyph_to_pixel_coords): Remove; unused.
2675
16390cd2
PE
2676 * dired.c (file_name_completion): Now static.
2677
2678 * dbusbind.c (xd_in_read_queued_messages): Now static.
2679
a25f4dfa
PE
2680 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2681 * data.c (circular_list_error): Remove.
2682
14a9c8df
PE
2683 * commands.h (last_point_position, last_point_position_buffer):
2684 (last_point_position_window): Remove decls.
2685 * keyboard.c: Make these variables static.
2686
04f2d78b
CB
2687 * coding.h (coding, code_convert_region, encode_coding_gap):
2688 Remove decls.
74ab6df5
PE
2689 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2690 (iso_code_class, detect_coding, code_convert_region): Now static.
2691 (encode_coding_gap): Remove; unused.
2692
38dfbee1
PE
2693 * chartab.c (chartab_chars, chartab_bits): Now static.
2694
a2cb4e63
PE
2695 * charset.h (charset_iso_8859_1): Remove decl.
2696 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2697 Now static.
2698
127198fd
PE
2699 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2700 * ccl.c (Vccl_program_table): Now static.
2701 (check_ccl_update): Remove; unused.
2702
d85b608f
PE
2703 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2704 * category.h: ... from here.
2705 * category.c (check_category_table, set_category_set): Now static.
2706
31cd66f3
PE
2707 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2708 * lisp.h: Remove these decls.
2709
c358e587
PE
2710 * buffer.c (buffer_count): Remove unused var.
2711
e78aecca
PE
2712 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2713 so that it's not optimized away.
2714 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2715 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2716 exported only to the debugger.
2717
e192d7d3 2718 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2719 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2720
92470028
PE
2721 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2722 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2723 was inaccessible from Lisp.
2724 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2725 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2726
244ed907
PE
2727 alloc.c: Import and export fewer symbols, and remove unused items.
2728 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2729 is defined.
2730 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2731 it's not optimized away by whole-program optimization.
2732 (message_enable_multibyte, free_misc): Remove.
2733 (catchlist, handlerlist, mark_backtrace):
2734 Declare only if BYTE_MARK_STACK.
2735 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2736 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2737 (message_enable_multibyte): Remove decl.
2738 (free_misc, interval_free_list, float_block, float_block_index):
2739 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2740 (cons_free_list, last_marked_index):
2741 Now static.
2742 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2743 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2744 (mark_backtrace): Define only if BYTE_MARK_STACK.
2745 * xdisp.c (message_enable_multibyte): Now static.
2746
61c2b50e 2747 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2748 This makes it easier for human readers (and static analyzers)
2749 to see whether these variables are used from other modules.
2750 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2751 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2752 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2753 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2754 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2755 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2756 * xmenu.c, xselect.c:
2757 Declare Q* vars static if they are not used in other modules.
2758 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2759 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2760 Remove decls of unexported vars.
2761 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2762
95c82688
PE
2763 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2764
16a97296
PE
2765 Make Emacs functions such as Fatom 'static' by default.
2766 This makes it easier for human readers (and static analyzers)
2767 to see whether these functions can be called from other modules.
2768 DEFUN now defines a static function. To make the function external
2769 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2770 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2771 (Finit_image_library):
16a97296
PE
2772 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2773 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2774 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2775 Remove decls, since these functions are now static.
2776 (Funintern, Fget_internal_run_time): New decls, since these functions
2777 were already external.
95c82688 2778
16a97296
PE
2779 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2780 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2781 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2782 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2783 * keyboard.c, keymap.c, lread.c:
2784 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2785 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2786 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2787 Mark functions with DEFUE instead of DEFUN,
2788 if they are used in other modules.
2789 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2790 decls for now-static functions.
2791 * buffer.h (Fdelete_overlay): Remove decl.
2792 * callproc.c (Fgetenv_internal): Mark as internal.
2793 * composite.c (Fremove_list_of_text_properties): Remove decl.
2794 (Fcomposition_get_gstring): New forward static decl.
2795 * composite.h (Fcomposite_get_gstring): Remove decl.
2796 * dired.c (Ffile_attributes): New forward static decl.
2797 * doc.c (Fdocumntation_property): New forward static decl.
2798 * eval.c (Ffetch_bytecode): New forward static decl.
2799 (Funintern): Remove extern decl; now in .h file where it belongs.
2800 * fileio.c (Fmake_symbolic_link): New forward static decl.
2801 * image.c (Finit_image_library): New forward static decl.
2802 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2803 * intervals.h (Fprevious_property_change):
2804 (Fremove_list_of_text_properties): Remove decls.
2805 * keyboard.c (Fthis_command_keys): Remove decl.
2806 (Fcommand_execute): New forward static decl.
2807 * keymap.c (Flookup_key): New forward static decl.
2808 (Fcopy_keymap): Now static.
2809 * keymap.h (Flookup_key): Remove decl.
2810 * process.c (Fget_process): New forward static decl.
2811 (Fprocess_datagram_address): Mark as internal.
2812 * syntax.c (Fsyntax_table_p): New forward static decl.
2813 (skip_chars): Remove duplicate decl.
2814 * textprop.c (Fprevious_property_change): New forward static decl.
2815 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2816 Now internal.
2817 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2818 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2819
785bbd42
PE
2820 * editfns.c (Fformat): Remove unreachable code.
2821
8b913b57
AS
28222011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2823
2824 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2825 change. (Bug#8496)
2826
a6744a35
EZ
28272011-04-13 Eli Zaretskii <eliz@gnu.org>
2828
2829 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2830 when at ZV. (Bug#8487)
2831
e7974947
AS
28322011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2833
baad03f0
AS
2834 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2835 (Bug#8437)
2836 * keyboard.c (parse_tool_bar_item): Likewise.
2837 * sound.c (sound_cleanup, alsa_close): Likewise.
2838 * termcap.c (tgetent): Likewise.
2839 * xfns.c (x_default_font_parameter): Likewise.
2840 * xsettings.c (read_and_apply_settings): Likewise.
2841
e7974947
AS
2842 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2843 (overrun_check_free): Protoize.
2844
28272684
PE
28452011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2848 since callers should never pass a negative size.
2849 Change the signature to match that of plain 'read' and 'write'; see
2850 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2851 * lisp.h: Update prototypes of emacs_write and emacs_read.
2852
11997c76
EZ
28532011-04-11 Eli Zaretskii <eliz@gnu.org>
2854
2855 * xdisp.c (redisplay_window): Don't try to determine the character
2856 position of the scroll margin if the window start point w->startp
e896f03c 2857 is outside the buffer's accessible region. (Bug#8468)
11997c76 2858
8a2cbd72
EZ
28592011-04-10 Eli Zaretskii <eliz@gnu.org>
2860
2861 Fix write-region and its subroutines for buffers > 2GB.
2862 * fileio.c (a_write, e_write): Modify declaration of arguments and
2863 local variables to support buffers larger than 2GB.
2864 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2865
2866 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2867 argument, local variables, and return value.
2868
2869 * lisp.h: Update prototypes of emacs_write and emacs_read.
2870
2871 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2872
4073e537 28732011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2874
1ebfdcb6
PE
2875 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2876
b2ded58d
PE
2877 Fix more problems found by GCC 4.6.0's static checks.
2878
7d66342c
PE
2879 * xdisp.c (vmessage): Use a better test for character truncation.
2880
bbf47d44
PE
2881 * charset.c (load_charset_map): <, not <=, for optimization,
2882 and to avoid potential problems with integer overflow.
9248994d 2883 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2884 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2885 * editfns.c (Fformat): Likewise.
1e69125e 2886 * syntax.c (skip_chars): Likewise.
3befa583 2887
e3019616
PE
2888 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2889 This also lets GCC 4.6.0 generate slightly better loop code.
2890
becfa255
PE
2891 * callint.c (Fcall_interactively): <, not <=, for optimization.
2892 (Fcall_interactively): Count the number of arguments produced,
2893 not the number of arguments given. This is simpler and lets GCC
2894 4.6.0 generate slightly better code.
2895
dae0cd48
PE
2896 * ftfont.c: Distingish more carefully between FcChar8 and char.
2897 The previous code passed unsigned char * to a functions like
2898 strlen and xstrcasecmp that expect char *, which does not
2899 conform to the C standard.
2900 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2901 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2902 char * when the C standard requires it.
2903
76032d70
PE
2904 * keyboard.c (read_char): Remove unused var.
2905
eb3f1cc8
PE
2906 * eval.c: Port to Windows vsnprintf (Bug#8435).
2907 Include <limits.h>.
2908 (SIZE_MAX): Define if the headers do not.
2909 (verror): Do not give up if vsnprintf returns a negative count.
2910 Instead, grow the buffer. This ports to Windows vsnprintf, which
2911 does not conform to C99. Problem reported by Eli Zaretskii.
2912 Also, simplify the allocation scheme, by avoiding the need for
2913 calling realloc, and removing the ALLOCATED variable.
2914
70476b54
PE
2915 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2916
12020a9e
PE
2917 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2918 But keep the doprint source code for now, as we might revamp it
2919 and use it again (Bug#8435).
ea6c7ae6
PE
2920 * lisp.h (doprnt): Remove.
2921 * Makefile.in (base_obj): Remove doprnt.o.
2922 * deps.mk (doprnt.o): Remove.
2923
5fdb398c
PE
2924 error: Print 32- and 64-bit integers portably (Bug#8435).
2925 Without this change, on typical 64-bit hosts error ("...%d...", N)
2926 was used to print both 32- and 64-bit integers N, which relied on
2927 undefined behavior.
2928 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2929 New macro.
2930 * lisp.h (error, verror): Mark as printf-like functions.
2931 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2932 Report overflow in size calculations when allocating printf buffer.
2933 Do not truncate output string at its first null byte.
2934 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2935 Truncate the output at a character boundary, since vsnprintf does not
2936 do that.
2937 * charset.c (check_iso_charset_parameter): Convert internal
2938 character to string before calling 'error', since %c now has the
2939 printf meaning.
2940 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2941 overflow when computing char to be passed to 'error'. Do not
2942 pass Lisp_Object to 'error'; pass the integer instead.
2943 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2944 formatted with plain %d.
2945
b189fa66
PE
2946 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2947
bff87ef0
PE
2948 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2949
7e2cac20
PE
2950 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2951
ce4d90b5
PE
2952 * xterm.c (x_catch_errors): Remove duplicate declaration.
2953
266c9547
PE
2954 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2955
79c49ad2
PE
2956 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2957
368f4090
JM
29582011-04-10 Jim Meyering <meyering@redhat.com>
2959
2960 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2961 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2962 return ssize_t not "int", and use size_t as the buffer length.
2963 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2964 * gnutls.h: Update declarations.
2965 * process.c (read_process_output): Use ssize_t, to match.
2966 (send_process): Likewise.
2967
a32d4040
CY
29682011-04-09 Chong Yidong <cyd@stupidchicken.com>
2969
2970 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2971
8546720e 29722011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2973
04f2d78b
CB
2974 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2975 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2976
8546720e
GM
2977 * xterm.c (handle_one_xevent):
2978 * xmenu.c (create_and_show_popup_menu):
2979 * xselect.c (x_decline_selection_request)
2980 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2981
0a2f5c1a 29822011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2983
2984 Fix some uses of `int' instead of EMACS_INT.
2985 * search.c (string_match_1, fast_string_match)
2986 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2987 (scan_buffer, find_next_newline_no_quit)
2988 (find_before_next_newline, search_command, Freplace_match)
2989 (Fmatch_data): Make some `int' variables be EMACS_INT.
2990
2991 * xdisp.c (display_count_lines): 3rd argument and return value now
2992 EMACS_INT. All callers changed.
2993 (pint2hrstr): Last argument is now EMACS_INT.
2994
2995 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2996 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2997 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2998 (decode_coding_utf_16, decode_coding_emacs_mule)
2999 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3000 (decode_coding_ccl, decode_coding_charset)
3001 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3002 (decode_coding_iso_2022, decode_coding_emacs_mule)
3003 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3004 <char_offset, last_offset>: Declare EMACS_INT.
3005 (encode_coding_utf_8, encode_coding_utf_16)
3006 (encode_coding_emacs_mule, encode_invocation_designation)
3007 (encode_designation_at_bol, encode_coding_iso_2022)
3008 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3009 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3010 Declare EMACS_INT.
3011 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3012 (encode_invocation_designation): Last argument P_NCHARS is now
3013 EMACS_INT.
3014 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3015 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3016
3017 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3018 All users changed.
3019
3020 * ccl.c (Fccl_execute_on_string): Declare some variables
3021 EMACS_INT.
3022
8546720e 30232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3024
3025 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3026
4e19a977
CS
30272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3028
3029 * process.c (Fformat_network_address): Doc fix.
3030
87302331
R
30312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3032
3033 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3034
cbb59342
CY
30352011-04-08 Chong Yidong <cyd@stupidchicken.com>
3036
3037 * keyboard.c (read_char): Call Lisp function help-form-show,
3038 instead of using internal_with_output_to_temp_buffer.
3039 (Qhelp_form_show): New var.
e0d38eeb 3040 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3041
3042 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3043
3044 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3045
e67a13ab
CY
30462011-04-06 Chong Yidong <cyd@stupidchicken.com>
3047
04f2d78b
CB
3048 * process.c (Flist_processes): Remove to Lisp.
3049 (list_processes_1): Delete.
e67a13ab 3050
973f782d
EZ
30512011-04-06 Eli Zaretskii <eliz@gnu.org>
3052
7c106b1e
EZ
3053 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3054
973f782d
EZ
3055 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3056
41cf7d1a 30572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3058
ca23cc88
PE
3059 Fix more problems found by GCC 4.6.0's static checks.
3060
f390e2d5
PE
3061 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3062
42eea0d0
PE
3063 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3064
b69769da 3065 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3066
f9541e84
PE
3067 * xdisp.c (vmessage): Mark as a printf-like function.
3068
13841b55
PE
3069 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3070
c136c10f
PE
3071 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3072
5e2d4a30
PE
3073 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3074 printf-like functions.
3075 (tiff_load): Add casts to remove these marks before passing them
3076 to system-supplied API.
3077
583f48b9
PE
3078 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3079
b25d760e
PE
3080 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3081 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3082 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3083 directly, rather than having caller test rule sign. This avoids
3084 some unnecessary tests.
3085 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3086 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3087 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3088
bc7b6697 3089 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3090 (xfont_open): Avoid unnecessary tests.
bc7b6697 3091
27ccc379
PE
3092 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3093
dcd5c89a
PE
3094 * composite.h, composite.c (composition_gstring_put_cache):
3095 Use EMACS_INT, not int, for length.
3096
b13a45c6
PE
3097 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3098 breaking out part of COMPOSITION_DECODE_RULE.
3099 (COMPOSITION_DECODE_RULE): Use it.
3100 * composite.c (get_composition_id): Remove unused local vars,
3101 by using the new macro.
3102
1e792e4d
PE
3103 * textprop.c (set_text_properties_1): Change while to do-while,
3104 since the condition is always true at first.
3105
dc6c6455 3106 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3107 (interval_deletion_adjustment): Return unsigned value.
3108 All uses changed.
dc6c6455 3109
aba7731a
PE
3110 * process.c (list_processes_1, create_pty, read_process_output):
3111 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3112 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3113 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3114 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3115 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3116
fdfc4bf3
PE
3117 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3118
fca8fe46 3119 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3120 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3121
06a0259a 3122 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3123 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3124 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3125
e7b9e80f
PE
3126 * print.c (print_error_message): Avoid int overflow.
3127
56201685
PE
3128 * font.c (font_list_entities): Redo for clarity,
3129 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3130
78834453 3131 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3132 (font_score): Avoid potential overflow in diff calculation.
78834453 3133
0bc0b309 3134 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3135 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3136
e610eaca
PE
3137 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3138
b895abce
PE
3139 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3140 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3141 can always succeed if overflow has undefined behavior.
3142
1f1d9321 3143 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3144 (wordify): Omit three unnecessary tests.
1f1d9321 3145
c59478bc
PE
3146 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3147 All callers changed. This avoids the need for an unused var.
3148
79b73827
PE
3149 * casefiddle.c (casify_region): Remove var that is set but not used.
3150
a4db5dfe
PE
3151 * dired.c (file_name_completion): Remove var that is set but not used.
3152
43aae36e
PE
3153 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3154
2a47c44d 3155 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3156 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3157
a37c69bf
PE
3158 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3159 Check for integer overflow on size calculations.
3160
328ab8e7
PE
3161 * buffer.c (Fprevious_overlay_change): Remove var that is set
3162 but not used.
3163
e5a2a5cb
PE
3164 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3165 Remove vars that are set but not used.
8d84a6eb 3166 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3167 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3168
a60e5f68
PE
3169 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3170
f661cb61 3171 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3172 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3173
f0397f5a
PE
3174 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3175 that are set but not used.
3176
8664db06 3177 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3178 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3179
6abdaa4a
PE
3180 * xselect.c (x_get_local_selection, x_handle_property_notify):
3181 Remove vars that are set but not used.
3182
0ce7538d 3183 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3184 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3185
9ae848fc
PE
3186 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3187 Remove var that is set but not used.
0b918413
PE
3188 (scroll_bar_windows_size): Now size_t, not int.
3189 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3190 Check for overflow.
9ae848fc 3191
a5a62657
PE
3192 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3193 (map_tty_color) [!defined MSDOS]: Likewise.
3194
5c5cdd39
PE
3195 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3196
66ebf983
PE
3197 * coding.c: Remove vars that are set but not used.
3198 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3199 All callers changed.
3200 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3201 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3202 (decode_coding_charset): Remove vars that are set but not used.
3203
1be4d761
PE
3204 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3205 that is set but not used.
3206
47553fa8
PE
3207 * print.c (print_object): Remove var that is set but not used.
3208
1f7196bf 3209 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3210 The gnulib version avoids calling malloc in the usual case,
3211 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3212 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3213 * filelock.c (current_lock_owner): Likewise.
3214 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3215 * sysdep.c: Include allocator.h, careadlinkat.h.
3216 (emacs_no_realloc_allocator): New static constant.
3217 (emacs_readlink): New function.
fdb61804
PE
3218 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3219 ../lib/careadlinkat.h.
d1fdcab7 3220
f84c17c7
SM
32212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3222
3223 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3224 first non-nil return value).
3225
ef3862ad
JD
32262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3227
3228 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3229 if not defined (Bug#8403).
3230
376a7006
JB
32312011-04-02 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * xdisp.c (display_count_lines): Remove parameter `start',
3234 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3235 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3236 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3237 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3238 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3239 and thereabouts. All callers changed.
3240 (get_per_char_metric): Remove parameter `f', unused since
3241 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3242
6ca3801d
JM
32432011-04-02 Jim Meyering <meyering@redhat.com>
3244
3245 do not dereference NULL upon failed strdup
3246 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3247 (ns_get_family): Likewise.
3248
d8e2b5ba
JB
32492011-04-02 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3252
8c74fcbd
JD
32532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3254
3255 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3256 later (Bug#8403).
3257
7200d79c
SM
32582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3259
03408648 3260 Add lexical binding.
7200d79c 3261
03408648
SM
3262 * window.c (Ftemp_output_buffer_show): New fun.
3263 (Fsave_window_excursion):
3264 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3265
3266 * lread.c (lisp_file_lexically_bound_p): New function.
3267 (Fload): Bind Qlexical_binding.
3268 (readevalloop): Remove `evalfun' arg.
3269 Bind Qinternal_interpreter_environment.
3270 (Feval_buffer): Bind Qlexical_binding.
3271 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3272 Mark as dynamic.
3273 (syms_of_lread): Declare `lexical-binding'.
3274
3275 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3276
3277 * keyboard.c (eval_dyn): New fun.
3278 (menu_item_eval_property): Use it.
ca105506
SM
3279
3280 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3281
03408648
SM
3282 * fns.c (concat, mapcar1): Accept byte-code-functions.
3283
3284 * eval.c (Fsetq): Handle lexical vars.
3285 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3286 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3287 (FletX, Flet): Obey lexical binding.
3288 (Fcommandp): Handle closures.
3289 (Feval): New `lexical' arg.
3290 (eval_sub): New function extracted from Feval. Use it almost
3291 everywhere where Feval was used. Look up vars in lexical env.
3292 Handle closures.
3293 (Ffunctionp): Move from subr.el.
3294 (Ffuncall): Handle closures.
3295 (apply_lambda): Remove `eval_flags'.
3296 (funcall_lambda): Handle closures and new byte-code-functions.
3297 (Fspecial_variable_p): New function.
3298 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3299 but without exporting it to Lisp.
23aba0ea 3300
23aba0ea 3301 * doc.c (Fdocumentation, store_function_docstring):
03408648 3302 * data.c (Finteractive_form): Handle closures.
23aba0ea 3303
03408648
SM
3304 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3305 interactive spec.
ba83908c 3306
04f2d78b
CB
3307 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3308 New byte-codes.
03408648
SM
3309 (exec_byte_code): New function extracted from Fbyte_code to handle new
3310 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3311
03408648 3312 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3313
03408648 3314 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3315
e2abce01
JB
33162011-03-31 Juanma Barranquero <lekktu@gmail.com>
3317
3318 * xdisp.c (redisplay_internal): Fix prototype.
3319
63696a73 33202011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3321
63696a73 3322 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3323 (try_scrolling): Use it when setting scroll_limit.
3324 Limit scrolling to 100 screen lines.
63696a73
EZ
3325 (redisplay_window): Even when falling back on "recentering",
3326 position point in the window according to scroll-conservatively,
3327 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3328
3329 (try_scrolling): When point is above the window, allow searching
3330 as far as scroll_max, or one screenful, to compute vertical
3331 distance from PT to the scroll margin position. This prevents
3332 try_scrolling from unnecessarily failing when
3333 scroll-conservatively is set to a value slightly larger than the
3334 window height. Clean up the case of PT below the margin at bottom
3335 of window: scroll_max can no longer be INT_MAX. When aggressive
3336 scrolling is in use, don't let point enter the opposite scroll
3337 margin as result of the scroll.
3338 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3339 threshold of 100 lines for never-recentering scrolling.
3340
e4cc2dfc
JB
33412011-03-31 Juanma Barranquero <lekktu@gmail.com>
3342
3343 * dispextern.h (move_it_by_lines):
3344 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3345 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3346 (message_log_check_duplicate): Remove parameters `prev_bol' and
3347 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3348 (redisplay_internal): Remove parameter `preserve_echo_area',
3349 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3350
3351 * indent.c (Fvertical_motion):
3352 * window.c (window_scroll_pixel_based, Frecenter):
3353 Don't pass `need_y_p' to `move_it_by_lines'.
3354
1c470562
SM
33552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3356
44f230aa
SM
3357 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3358 steal a few bits to be more compact.
3359 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3360 Remove unneeded casts.
3361
1c470562
SM
3362 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3363
888adce9
ZK
33642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3365
3366 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3367 binding" message (bug#7967).
3368
f838ed7b
PE
33692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3370
77861b95
PE
3371 Fix more problems found by GCC 4.6.0's static checks.
3372
de6dbc14
PE
3373 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3374 Remove unused local var.
3375
f838ed7b
PE
3376 * editfns.c (Fmessage_box): Remove unused local var.
3377
792c7b2b
PE
3378 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3379 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3380 Omit unused local vars.
c499e557 3381 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3382 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3383 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3384 Omit unused local var.
3385
ba0165e1
PE
3386 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3387 Don't assume string length fits in int.
32ad8845 3388 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3389 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3390
3c59b4c9
PE
3391 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3392 instead of alloca (Bug#8344).
3393
a3eed478 3394 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3395 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3396
eb4d412d
PE
3397 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3398
1658b401
PE
3399 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3400 concerns.
3401
3402 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3403
3404 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3405
9a2c6e05
PE
3406 * keyboard.c (syms_of_keyboard): Use the same style as later
3407 in this function when indexing through an array. This also
3408 works around GCC bug 48267.
3409
03d0a109
PE
3410 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3411
44f730c8
PE
3412 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3413
fe75f926
PE
3414 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3415 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3416
ffa8c828
PE
3417 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3418 This avoids undefined behavior on integer overflow, and is a bit
3419 more convenient anyway since it is compared to a size_t variable.
3420
c5101a77
PE
3421 Variadic C functions now count arguments with size_t, not int.
3422 This avoids an unnecessary limitation on 64-bit machines, which
3423 caused (substring ...) to crash on large vectors (Bug#8344).
3424 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3425 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3426 All variadic functions and their callers changed accordingly.
c5101a77
PE
3427 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3428 * data.c (arith_driver, float_arith_driver): Likewise.
3429 * editfns.c (general_insert_function): Likewise.
3430 * eval.c (struct backtrace.nargs, interactive_p)
3431 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3432 (funcall_lambda, mark_backtrace): Likewise.
3433 * fns.c (concat): Likewise.
3434 * frame.c (x_set_frame_parameters): Likewise.
3435 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3436 0 if not found, not -1. All callers changed.
3437
dd3f25f7
PE
3438 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3439 (stack_copy_size): Now size_t, not int.
3440 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3441
461c2ab9
JB
34422011-03-28 Juanma Barranquero <lekktu@gmail.com>
3443
3444 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3445 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3446 All callers changed.
3447
3448 * lisp.h (multibyte_char_to_unibyte):
3449 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3450 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3451 * character.h (CHAR_TO_BYTE8):
3452 * cmds.c (internal_self_insert):
3453 * editfns.c (general_insert_function):
3454 * keymap.c (push_key_description):
3455 * search.c (Freplace_match):
3456 * xdisp.c (message_dolog, set_message_1): All callers changed.
3457
f6d62986
SM
34582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3459
3460 * keyboard.c (safe_run_hook_funcall): New function.
3461 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3462 don't set the hook to nil, but remove the offending function instead.
3463 (Qcommand_hook_internal): Remove, unused.
3464 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3465 Vcommand_hook_internal.
3466
3467 * eval.c (enum run_hooks_condition): Remove.
3468 (funcall_nil, funcall_not): New functions.
3469 (run_hook_with_args): Call each function through a `funcall' argument.
3470 Remove `cond' argument, now redundant.
3471 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3472 (Frun_hook_with_args_until_failure): Adjust accordingly.
3473 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3474
1db5b1ad
JB
34752011-03-28 Juanma Barranquero <lekktu@gmail.com>
3476
3477 * dispextern.h (string_buffer_position): Remove declaration.
3478
3479 * print.c (strout): Remove parameter `multibyte', unused since
3480 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3481
3482 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3483 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3484 All callers changed.
3485
3486 * w32.c (_wsa_errlist): Use braces for struct initializers.
3487
3488 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3489 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3490 All callers changed.
3491 (string_buffer_position): Likewise. Also, make static (it's never
3492 used outside xdisp.c).
3493 (cursor_row_p): Remove parameter `w', unused since
3494 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3495 (decode_mode_spec): Remove parameter `precision', introduced during
3496 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3497 All callers changed.
3498
5ffb62aa
JD
34992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3500
3501 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3502
461c2ab9 35032011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3504
3505 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3506 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3507 (ns_update_auto_hide_menu_bar): New functions.
3508 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3509 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3510 ns_constrain_all_frames.
3511 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3512 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3513
5c380ffb
JD
35142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3515
3516 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3517
9af30bdf
GM
35182011-03-27 Glenn Morris <rgm@gnu.org>
3519
3520 * syssignal.h: Replace RETSIGTYPE with void.
3521 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3522 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3523 Replace SIGTYPE with void everywhere.
3524 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3525 * s/template.h (SIGTYPE): Remove commented out definition.
3526
e2abce01
JB
35272011-03-26 Eli Zaretskii <eliz@gnu.org>
3528
3529 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3530 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3531
f868cd8a
JB
35322011-03-26 Juanma Barranquero <lekktu@gmail.com>
3533
59eb0929
JB
3534 * w32.c (read_unc_volume): Use parameter `henum', instead of
3535 global variable `wget_enum_handle'.
3536
3537 * keymap.c (describe_vector): Remove parameters `indices' and
3538 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3539 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3540
f868cd8a
JB
3541 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3542
3543 * keyboard.c (timer_check): Remove parameter `do_it_now',
3544 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3545 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3546 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3547
3548 * keyboard.c (read_char):
3549 * w32menu.c (w32_menu_display_help):
3550 * xmenu.c (show_help_event, menu_help_callback):
3551 Adjust calls to `show_help_echo'.
3552
3553 * gtkutil.c (xg_maybe_add_timer):
3554 * keyboard.c (readable_events):
3555 * process.c (wait_reading_process_output):
3556 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3557
3558 * insdel.c (adjust_markers_gap_motion):
3559 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3560 (gap_left, gap_right): Don't call it.
3561
2ecf6fdb
CY
35622011-03-25 Chong Yidong <cyd@stupidchicken.com>
3563
3564 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3565 incurred during fontification.
3566
6b1f9ba4
JB
35672011-03-25 Juanma Barranquero <lekktu@gmail.com>
3568
3569 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3570 (DEFVAR_PER_BUFFER): Don't pass it.
3571
3572 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3573 (scrolling_window): Don't pass it.
3574
0f4a96b5
JB
35752011-03-25 Juanma Barranquero <lekktu@gmail.com>
3576
3577 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3578
3579 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3580 and `suffix'.
3581 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3582 of variables specific to SELinux and computation of `encoded_absname'.
3583
3584 * image.c (XPutPixel): Remove unused variable `height'.
3585
3586 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3587
3588 * unexw32.c (get_section_info): Remove unused variable `section'.
3589
3590 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3591 (system_process_attributes): Remove unused variable `sess'.
3592 (sys_read): Remove unused variable `err'.
3593
3594 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3595 (w32_wnd_proc): Remove unused variable `isdead'.
3596 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3597 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3598 (x_create_tip_frame): Remove unused variable `tem'.
3599
3600 * w32inevt.c (w32_console_read_socket):
3601 Remove unused variable `no_events'.
3602
3603 * w32term.c (x_draw_composite_glyph_string_foreground):
3604 Remove unused variable `width'.
3605
1149507c
JB
36062011-03-24 Juanma Barranquero <lekktu@gmail.com>
3607
3608 * w32term.c (x_set_glyph_string_clipping):
3609 Don't pass uninitialized region to CombineRgn.
3610
9c88f339
JB
36112011-03-23 Juanma Barranquero <lekktu@gmail.com>
3612
3613 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3614 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3615 (Fx_close_connection): Remove unused variable `i'.
3616
3617 * w32font.c (w32font_draw): Return number of glyphs.
3618 (w32font_open_internal): Remove unused variable `i'.
3619 (w32font_driver): Add missing initializer.
3620
3621 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3622 (fill_in_menu): Remove unused variable `items_added'.
3623
3624 * w32term.c (last_mouse_press_frame): Remove static global variable.
3625 (w32_clip_to_row): Remove unused variable `f'.
3626 (x_delete_terminal): Remove unused variable `i'.
3627
3628 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3629 (NOTHING): Remove unused static global variable.
3630 (uniscribe_check_otf): Remove unused variable `table'.
3631 (uniscribe_font_driver): Add missing initializers.
3632
dee091a3
JD
36332011-03-23 Julien Danjou <julien@danjou.info>
3634
3635 * term.c (Fsuspend_tty, Fresume_tty):
3636 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3637 * window.c (temp_output_buffer_show):
3638 * insdel.c (signal_before_change):
3639 * frame.c (Fhandle_switch_frame):
3640 * fileio.c (Fdo_auto_save):
3641 * emacs.c (Fkill_emacs):
3642 * editfns.c (save_excursion_restore):
3643 * cmds.c (internal_self_insert):
3644 * callint.c (Fcall_interactively):
3645 * buffer.c (Fkill_all_local_variables):
3646 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3647 Use Frun_hooks.
0f4a96b5 3648 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3649 unconditionnaly since it does the check itself.
3650
2c520ab5 36512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3652
c9c49752
PE
3653 Fix more problems found by GCC 4.5.2's static checks.
3654
8abc3f12
PE
3655 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3656 the first time through the loop, since we know p0 < p1 then.
3657 This also avoids a gcc -Wstrict-overflow warning.
3658
a2d26660
PE
3659 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3660 leading to a memory leak, possible in functions like
3661 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3662 of objects (Bug#8318).
a2d26660 3663
916c72e9
PE
3664 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3665 that could (at least in theory) be that large.
3666
19ab8a18
PE
3667 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3668 This is less likely to overflow, and avoids undefined behavior if
3669 overflow does occur. All callers changed. Use strtoul to scan
3670 for the unsigned long integer.
b7cbbd6f
PE
3671 (pint2hrstr): Simplify and tune code slightly.
3672 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3673
f0641eff
PE
3674 * scroll.c (do_scrolling): Work around GCC bug 48228.
3675 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3676
7f650bb9
PE
3677 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3678 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3679 (validate_x_resource_name): Simplify count usage.
3680 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3681
37dd57d1
PE
3682 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3683 fail (Bug#8306).
81e56e61 3684
699979fc 3685 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3686
401bf9b4
PE
3687 * process.c (Fmake_network_process): Use socklen_t, not int,
3688 where POSIX says socklen_t is required in portable programs.
3689 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3690 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3691 (Fmake_network_process, server_accept_connection):
3692 (wait_reading_process_output, read_process_output):
3693 Likewise.
3694
b93aacde
PE
3695 * process.c: Rename or move locals to avoid shadowing.
3696 (list_processes_1, Fmake_network_process):
3697 (read_process_output_error_handler, exec_sentinel_error_handler):
3698 Rename or move locals.
4dc343ee 3699 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3700 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3701 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3702 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3703 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3704
af8a867c 3705 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3706 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3707 Include tparam.h instead, since it declares them.
af8a867c
PE
3708 * cm.h (PC): Remove extern decl; tparam.h now does this.
3709 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3710 * terminfo.c: Include tparam.h, to check interfaces.
3711 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3712 (tparam): Adjust signature to match interface in tparam.h;
3713 this removes some undefined behavior. Check that outstring and len
3714 are zero, which they always are with Emacs.
3715 * tparam.h (PC, BC, UP): New extern decls.
3716
0248044d 3717 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3718 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3719
8ff096c1 3720 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3721 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3722 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3723 (ftfont_list): Remove unused local.
49eaafba
PE
3724 (get_adstyle_property, ftfont_pattern_entity):
3725 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3726 Rename locals to avoid shadowing.
8ff096c1 3727
e2be39f6
PE
3728 * xfont.c (xfont_list_family): Mark var as initialized.
3729
c9735e30
PE
3730 * xml.c (make_dom): Now static.
3731
8f5201ae
PE
3732 * composite.c (composition_compute_stop_pos): Rename local to
3733 avoid shadowing.
b246f932
PE
3734 (composition_reseat_it): Remove unused locals.
3735 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3736 (composition_update_it): Mark var as initialized.
11b61122
PE
3737 (find_automatic_composition): Mark vars as initialized,
3738 with a FIXME (Bug#8290).
8f5201ae 3739
760fbc2c
PE
3740 character.h: Rename locals to avoid shadowing.
3741 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3742 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3743 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3744 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3745 to avoid shadowing.
3746
ff08eb85
PE
3747 * textprop.c (property_change_between_p): Remove; unused.
3748
fc7bf025
PE
3749 * intervals.c (interval_start_pos): Now static.
3750
235d7abc
PE
3751 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3752
44f230aa
SM
3753 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3754 Rename locals to avoid shadowing.
3e7d6594 3755
50060332
PE
3756 * sound.c (wav_play, au_play, Fplay_sound_internal):
3757 Fix pointer signedness.
d01f234b 3758 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3759 (wav_play): Initialize a variable to 0, to prevent undefined
3760 behavior (Bug#8278).
50060332 3761
c4fc4e30
PE
3762 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3763
918436ed
PE
3764 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3765
c939f91b
PE
3766 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3767 clobbering (Bug#8298).
b9c7f648
PE
3768 * sysdep.c (sys_subshell): Likewise.
3769 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3770
6bd8c144
PE
3771 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3772 This should get cleaned up, so that child_setup has the
3773 same signature on all platforms.
3774
7710357c 3775 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3776 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3777
c59da222
CY
37782011-03-22 Chong Yidong <cyd@stupidchicken.com>
3779
3780 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3781 not to be necessary, and produces flickering.
3782
66b87493
GM
37832011-03-20 Glenn Morris <rgm@gnu.org>
3784
3785 * config.in: Remove file.
3786
45b6f6d5
JB
37872011-03-20 Juanma Barranquero <lekktu@gmail.com>
3788
3789 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3790 are now in src/globals.h.
3791 (syms_of_minibuf): Remove spurious & from previous change.
3792
3ec03f7e
LL
37932011-03-20 Leo <sdl.web@gmail.com>
3794
3795 * minibuf.c (completing-read-function): New variable.
3796 (completing-read-default): Rename from completing-read.
3797 (completing-read): Call completing-read-function.
3798
b14e3e21
CY
37992011-03-19 Juanma Barranquero <lekktu@gmail.com>
3800
3801 * xfaces.c (Fx_load_color_file):
3802 Read color file from absolute filename (bug#8250).
3803
f2b726e6
JB
38042011-03-19 Juanma Barranquero <lekktu@gmail.com>
3805
3806 * makefile.w32-in: Update dependencies.
3807
09f6ff02
EZ
38082011-03-17 Eli Zaretskii <eliz@gnu.org>
3809
3810 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3811
29a6015a
PE
38122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3813
a3a6c54e
PE
3814 Fix more problems found by GCC 4.5.2's static checks.
3815
b766f867
PE
3816 * process.c (make_serial_process_unwind, send_process_trap):
3817 (sigchld_handler): Now static.
3818
be02381c
PE
3819 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3820 That way, the code declares only the vars that it needs.
3821 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3822 * s/cygwin.h (PTY_ITERATION): Likewise.
3823 * s/darwin.h (PTY_ITERATION): Likewise.
3824 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3825
57048744
PE
3826 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3827 * process.c (allocate_pty): Don't declare stb unless it's needed.
3828
7914961c 3829 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3830 (CONSTANTLIM): Remove; unused.
3831 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3832 Define only if needed.
7914961c 3833
b3967b18
PE
3834 * unexelf.c (unexec): Name an expression,
3835 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3836 Use a different way to cause a compilation error if anyone uses
3837 n rather than nn, a way that does not involve shadowing.
73366a00 3838 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3839
29a6015a
PE
3840 * deps.mk (unexalpha.o): Remove; unused.
3841
43cfc33e 3842 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3843 * unexec.h: New file.
ce701a33
PE
3844 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3845 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3846 Depend on unexec.h.
3847 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3848 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3849 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3850 Change as necessary to match prototype in unexec.h.
ce701a33 3851
01f44d5a
PE
3852 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3853 shadowing.
4f63c6bb 3854 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3855
a6670b0b
PE
3856 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3857 Rename locals to avoid shadowing.
3858
cef2010d 3859 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3860 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3861
d4d7173a
PE
3862 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3863
f08b802a
PE
3864 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3865 warning when compiling print.c.
3866
3ddb0639
PE
3867 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3868 instead of using an uninitialized var.
5ad03b97 3869 (font_sort_entities): Mark var as initialized.
3ddb0639 3870
170a2692
PE
3871 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3872
e663c700
PE
3873 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3874 pointers to constants.
89bc529a 3875 (font_parse_fcname): Remove unused vars.
7b81e2d0 3876 (font_delete_unmatched): Now static.
ea838e10 3877 (font_get_spec): Remove; unused.
13a547c6
PE
3878 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3879 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3880 Rename or move locals to avoid shadowing.
e663c700 3881
2a80c887 3882 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3883 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3884
1384fa33 3885 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3886 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3887
8b2c52e9
PE
3888 * alloc.c (mark_backtrace): Move decl from here ...
3889 * lisp.h: ... to here, so that it can be checked.
3890
475545b5 3891 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3892 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3893 (lisp_indirect_variable): Name an expression,
3894 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3895 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3896
b1349114 3897 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3898 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3899 Use const pointer when appropriate.
b1349114 3900
a2928364
PE
3901 * lisp.h (get_system_name, get_operating_system_release):
3902 Move decls here, to check interfaces.
3903 * process.c (get_operating_system_release): Move decl to lisp.h.
3904 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3905 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3906 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3907 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3908 (Fformat_time_string, Fencode_time, Finsert_char):
3909 (Ftranslate_region_internal, Fformat):
3910 Rename or remove local vars to avoid shadowing.
9710023e 3911 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3912
a415e694
PE
3913 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3914 avoid shadowing.
3915
8ef4622d
PE
3916 * lisp.h (eassert): Check that the argument compiles, even if
3917 ENABLE_CHECKING is not defined.
3918
946f9a5b
PE
3919 * data.c (Findirect_variable): Name an expression, to avoid
3920 gcc -Wbad-function-cast warning.
112396d6 3921 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3922 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3923 (Fmake_variable_buffer_local, Fmake_local_variable):
3924 Mark variables as initialized.
52746918 3925 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3926
e5aab7e7 3927 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3928 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3929 Rename locals to avoid shadowing.
dff45157
PE
3930 (mark_stack): Move local variables into the #ifdef region where
3931 they're used.
7bc26fdb
PE
3932 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3933 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3934 needed otherwise.
3935 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3936 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3937 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3938
e5aab7e7
PE
3939 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3940 avoids undefined behavior in theory.
3941
4da60324
PE
3942 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3943
88043301
PE
3944 Use functions, not macros, for up- and down-casing (Bug#8254).
3945 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3946 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3947 to use the following functions instead of these macros.
3948 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3949 EMACS_INT, since callers assume the returned value fits in int.
3950 (upcase1): Likewise, for UPCASE_TABLE.
3951 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3952 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3953 the race-condition problem in the old DOWNCASE.
88043301 3954
19ed5445
PE
3955 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3956 Rename locals to avoid shadowing.
3957 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3958 (regex_compile, re_search_2, re_match_2_internal):
3959 Remove unused local vars.
952db0d7
PE
3960 (FREE_VAR): Rewrite so as not to use empty "else",
3961 which gcc can warn about.
da053e48 3962 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3963 (RETALLOC_IF): Define only if needed.
3964 (WORDCHAR_P): Likewise. This one is never needed, but is used
3965 only in a comment talking about a compiler bug, so put inside
3966 the #if 0 of that comment.
3967 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3968 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3969 Remove; unused.
19ed5445 3970
1f3561e4 3971 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3972 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3973 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3974
ded6f8f7
PE
3975 * search.c (simple_search): Remove unused var.
3976
dbd37a95
PE
3977 * dired.c (compile_pattern): Move decl from here ...
3978 * lisp.h: ... to here, so that it can be checked.
3979 (struct re_registers): New forward decl.
3980
7e47afad
PE
3981 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3982
85f24f61
PE
3983 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3984 All uses changed.
3985 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3986 Rename locals to avoid shadowing.
5671df8f 3987 (Fvertical_motion): Mark locals as initialized.
85f24f61 3988
181aa2be 3989 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3990 (casify_region): Mark local as initialized.
181aa2be 3991
930d429c
PE
3992 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3993
7082eac6
PE
3994 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3995 New macros, so that the caller can use some names other than
3996 gcpro1, gcpro2, etc.
3997 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3998 of the new macros.
3999 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4000 argument, for consistency with GCPRO2_VAR, etc: it is now the
4001 prefix of the variable, not the variable itself. All uses
4002 changed.
38b2c076
PE
4003 * dired.c (directory_files_internal, file_name_completion):
4004 Rename locals to avoid shadowing.
4005
15206ed9
PE
4006 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4007 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4008 dired.c's scmp function, had undefined behavior.
4009 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4010 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4011 * buffer.h: ... to here, because these macros use current_buffer,
4012 and the new implementation with inline functions needs to have
4013 current_buffer in scope now, rather than later when the macros
4014 are used.
4015 (downcase, upcase1): New static inline functions.
4016 (DOWNCASE, UPCASE1): Reimplement using these functions.
4017 This avoids undefined behavior in expressions like
4018 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4019 from race conditions in accessing the global variables
4020 case_temp1 and case_temp2.
4021 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4022 * lisp.h (case_temp1, case_temp2): Remove their decls.
4023 * character.h (ASCII_CHAR_P): Move from here ...
4024 * lisp.h: ... to here, so that the inline functions mentioned
4025 above can use them.
4026
4a6bea26
PE
4027 * dired.c (directory_files_internal_unwind): Now static.
4028
f14b7e14
PE
4029 * fileio.c (file_name_as_directory, directory_file_name):
4030 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4031 Now static.
2893f146
PE
4032 (file_name_as_directory): Use const pointers when appropriate.
4033 (Fexpand_file_name): Likewise. In particular, newdir might
4034 point at constant storage, so make it a const pointer.
fd4ead52 4035 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4036 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4037 signedness issues.
f839df0c
PE
4038 (Fset_file_times, Finsert_file_contents, auto_save_error):
4039 Rename locals to avoid shadowing.
f14b7e14 4040
5716756e 4041 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4042 (Ftry_completion, Fall_completions): Rename or remove locals
4043 to avoid shadowing.
5716756e 4044
b4c3046a
PE
4045 * marker.c (bytepos_to_charpos): Remove; unused.
4046
b45db522
PE
4047 * lisp.h (verify_bytepos, count_markers): New decls,
4048 so that gcc does not warn that these functions aren't declared.
4049
85876d07
PE
4050 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4051 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4052 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4053 (copy_text): Remove unused local var.
85876d07 4054
03d78a21 4055 * filelock.c (within_one_second): Now static.
b3dd38ab 4056 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4057
5df8f01b
PE
4058 * buffer.c (fix_overlays_before): Mark locals as initialized.
4059 (fix_start_end_in_overlays): Likewise. This function should be
4060 simplified by using pointers-to-pointers, but that's a different
4061 matter.
b1d876f1 4062 (switch_to_buffer_1): Now static.
8f54f30a
PE
4063 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4064 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4065
a70072c9 4066 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4067 Fix pointer signedness issue.
edced198
PE
4068 (sys_subshell): Mark local as volatile if checking for lint,
4069 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4070 (MAXPATHLEN): Define only if needed.
a70072c9 4071
a0977c44
PE
4072 * process.c (serial_open, serial_configure): Move decls from here ...
4073 * systty.h: ... to here, so that they can be checked.
4074
a884fdcc
PE
4075 * fns.c (get_random, seed_random): Move extern decls from here ...
4076 * lisp.h: ... to here, so that they can be checked.
4077
604efe86 4078 * sysdep.c (reset_io): Now static.
b8950c94 4079 (wait_for_termination_signal): Remove; unused.
604efe86 4080
38fc62d9
PE
4081 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4082 (copy_keymap_item, append_key, push_text_char_description):
4083 Now static.
1004a21a 4084 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4085 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4086 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4087 (describe_map_tree):
4088 Rename locals to avoid shadowing.
38fc62d9 4089
2f2650da
PE
4090 * keyboard.c: Declare functions static if they are not used elsewhere.
4091 (echo_char, echo_dash, cmd_error, top_level_2):
4092 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4093 (read_char, kbd_buffer_get_event, make_lispy_position):
4094 (make_lispy_event, make_lispy_movement, apply_modifiers):
4095 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4096 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4097 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4098 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4099 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4100
a053e86c 4101 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4102 (mark_kboards): Move decl here ...
4103 * alloc.c (mark_kboards): ... from here.
a053e86c 4104
4752793e
PE
4105 * lisp.h (force_auto_save_soon): New decl.
4106
74f10ca7 4107 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4108 (DEFINE_DUMMY_FUNCTION): New macro.
4109 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4110 Use it.
c03cd23f
PE
4111 (main): Add casts to avoid warnings
4112 if GCC considers string literals to be constants.
74f10ca7 4113
022e70d4
PE
4114 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4115
59d6fe83
PE
4116 * dbusbind.c: Pointer signedness fixes.
4117 (xd_signature, xd_append_arg, xd_initialize):
4118 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4119 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4120 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4121 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4122
78320123
PE
4123 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4124 if GCC considers string literals to be constants.
49cebcca 4125 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4126
35ac2a97
SM
41272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4128
fb103ca9
SM
4129 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4130 (print_preprocess, print_object): New macro to fix last change.
4131
35ac2a97
SM
4132 * print.c (print_preprocess): Don't forget font objects.
4133
62973b41
JB
41342011-03-16 Juanma Barranquero <lekktu@gmail.com>
4135
4136 * emacs.c (USAGE3): Doc fixes.
4137
0e48bb22
AS
41382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4139
4140 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4141 structure.
4142
7684e57b
JB
41432011-03-14 Juanma Barranquero <lekktu@gmail.com>
4144
4145 * lisp.h (VWindow_system, Qfile_name_history):
4146 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4147 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4148 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4149
4150 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4151 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4152
4153 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4154 * w32console.c (detect_input_pending, read_input_pending)
4155 (encode_terminal_code):
4156 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4157 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4158 (w32_system_caret_y, Qfile_name_history):
4159 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4160 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4161 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4162 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4163 * w32proc.c (Qlocal, report_file_error):
4164 * w32term.c (Vwindow_system, updating_frame):
4165 * w32uniscribe.c (initialized, uniscribe_font_driver):
4166 Remove unneeded extern declarations.
4167
2aa46d6c
CY
41682011-03-14 Chong Yidong <cyd@stupidchicken.com>
4169
c96bbc66 4170 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4171
cffc6f3b
CY
41722011-03-13 Chong Yidong <cyd@stupidchicken.com>
4173
4174 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4175 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4176 These macros can no longer be used for assignment.
4177
44f230aa
SM
4178 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4179 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4180 (record_buffer_markers, fetch_buffer_markers): New functions for
4181 recording and fetching special buffer markers.
4182 (set_buffer_internal_1, set_buffer_temp): Use them.
4183
4184 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4185
4186 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4187
4188 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4189 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4190
4191 * xdisp.c (hscroll_window_tree):
4192 (reconsider_clip_changes): Use PT instead of BUF_PT.
4193
d251f04b
EZ
41942011-03-13 Eli Zaretskii <eliz@gnu.org>
4195
4196 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4197 $(EMACS_ROOT)/lib/intprops.h.
4198
f0c77cd1
PE
41992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4200
3eca4629
PE
4201 Fix more problems found by GCC 4.5.2's static checks.
4202
7c86ee98
PE
4203 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4204 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4205 (xg_free_frame_widgets): Make it clear that a local variable is
4206 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4207 (gdk_window_get_screen): Make it clear that this macro is needed
4208 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4209 (int_gtk_range_get_value): New function, which avoids a diagnostic
4210 from gcc -Wbad-function-cast.
4211 (xg_set_toolkit_scroll_bar_thumb): Use it.
4212 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4213 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4214 (get_utf8_string, xg_get_file_with_chooser):
4215 Rename locals to avoid shadowing.
4216 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4217
41729b81
PE
4218 * xgselect.c (xg_select): Remove unused var.
4219
f0c77cd1
PE
4220 * image.c (four_corners_best): Mark locals as initialized.
4221 (gif_load): Initialize transparent_p to zero (Bug#8238).
4222 Mark another local as initialized.
ec6cf4c6 4223 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4224
ce0ad53d 4225 * image.c (clear_image_cache): Now static.
d5d5a617 4226 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4227 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4228 (x_edge_detection): Remove unnecessary cast that
4229 gcc -Wbad-function-cast diagnoses.
2037898d 4230 (gif_load): Fix pointer signedness.
6ae141d6
PE
4231 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4232 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4233
33383987 42342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4235
d32df629
PE
4236 Improve quality of tests for time stamp overflow.
4237 For example, without this patch (encode-time 0 0 0 1 1
4238 1152921504606846976) returns the obviously-bogus value (-948597
4239 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4240 reports time overflow. See
4241 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4242 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4243 * editfns.c: Include limits.h and intprops.h.
4244 (TIME_T_MIN, TIME_T_MAX): New macros.
4245 (time_overflow): Move earlier, to before first use.
4246 (hi_time, lo_time): New functions, for an accurate test for
4247 out-of-range times.
4248 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4249 (Fget_internal_run_time): Don't assume time_t fits in int.
4250 (make_time): Use list2 instead of Fcons twice.
4251 (Fdecode_time): More accurate test for out-of-range times.
4252 (check_tm_member): New function.
4253 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4254 (lisp_time_argument): Don't rely on undefined left-shift and
4255 right-shift behavior when checking for time stamp overflow.
8be6f318 4256
fe31d94c
PE
4257 * editfns.c (time_overflow): New function, refactoring common code.
4258 (Fformat_time_string, Fdecode_time, Fencode_time):
4259 (Fcurrent_time_string): Use it.
4260
8be6f318
PE
4261 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4262 * dired.c (make_time): Move to ...
4263 * editfns.c (make_time): ... here.
4264 * systime.h: Note the move.
4265
09d9db2c 42662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4267
126bc0dc
YM
4268 * fringe.c (update_window_fringes): Remove unused variables.
4269
c47cbdfd
YM
4270 * unexmacosx.c (copy_data_segment): Also copy __got section.
4271 (Bug#8223)
4272
7ac80be9
EZ
42732011-03-12 Eli Zaretskii <eliz@gnu.org>
4274
c96bbc66 4275 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4276 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4277 Constify `char *' arguments and their references according to
4278 prototypes in tparam.h.
4279
ecb0f94d 4280 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4281
7ac80be9
EZ
4282 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4283 Adapt all references accordingly.
4284
4285 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4286
ef1fd07e
TT
42872011-03-11 Tom Tromey <tromey@redhat.com>
4288
4289 * buffer.c (syms_of_buffer): Remove obsolete comment.
4290
7ef4b50c
EZ
42912011-03-11 Eli Zaretskii <eliz@gnu.org>
4292
4293 * termhooks.h (encode_terminal_code): Declare prototype.
4294
4295 * msdos.c (encode_terminal_code): Don't declare prototype.
4296
4297 * term.c (encode_terminal_code): Now external again, used by
4298 w32console.c and msdos.c.
4299
44f230aa
SM
4300 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4301 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4302
4b1ec863 43032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4304
1714f52b 4305 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4306
4b1ec863
PE
4307 * fringe.c (update_window_fringes): Mark locals as initialized
4308 (Bug#8227).
4309 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4310
524c7aa6
PE
4311 * alloc.c (mark_fringe_data): Move decl from here ...
4312 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4313 to check its interface.
4314 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4315
a5c0af81 4316 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4317 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4318 (fontset_font): Mark local as initialized.
a9a06e0b 4319 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4320
b4716021
PE
4321 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4322
811e9bac 4323 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4324 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4325 (x_own_selection, Fx_disown_selection_internal): Rename locals
4326 to avoid shadowing.
4327 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4328
7e3ab302
PE
4329 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4330 so that the caller can use some name other than gcpro1.
4331 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4332 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4333 (Fx_backspace_delete_keys_p):
4334 Use them to avoid shadowing, and rename vars to avoid shadowing.
4335 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4336 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4337 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4338 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4339 Remove unused locals.
7e3ab302
PE
4340 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4341 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4342 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4343 macros.
f78faa98 4344
e2b13473
PE
4345 * xterm.h (x_mouse_leave): New decl.
4346
77f23912
PE
4347 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4348 Remove unused functions.
cdf4ba58
PE
4349 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4350 (x_calc_absolute_position): Now static.
7411c686 4351 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4352 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4353 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4354 unless they are used.
38d0b34a
PE
4355 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4356 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4357 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4358 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4359 (x_error_catcher, x_connection_closed, x_error_handler):
4360 (x_error_quitter, xembed_send_message, x_iconify_frame):
4361 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4362 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4363 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4364
44f230aa
SM
4365 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4366 Rename or move locals to avoid shadowing.
6b463e58 4367 (tty_defined_color, merge_face_heights): Now static.
5967d051 4368 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4369 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4370 does not deduce is never used uninitialized.
73719eba
PE
4371 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4372 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4373
426994c3 4374 * terminal.c (store_terminal_param): Now static.
5489860b 4375
032f1620 4376 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4377 (set_frame_menubar): Remove unused local.
d4323972 4378 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4379 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4380 since they might point to immutable storage.
281585b0
PE
4381 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4382 since it's unused otherwise.
032f1620 4383
367c19e5 4384 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4385 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4386 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4387 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4388 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4389 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4390 does not deduce are never used uninitialized.
70739cbe 4391
07b48fa9
PE
4392 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4393
8868a238 4394 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4395 * window.c (window_loop, size_window):
4396 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4397
7e5cf297 4398 * window.c (display_buffer): Now static.
d6550a9f
PE
4399 (size_window): Mark variables that gcc -Wuninitialized
4400 does not deduce are never used uninitialized.
a586633d
PE
4401 * window.h (check_all_windows): New decl, to forestall
4402 gcc -Wmissing-prototypes diagnostic.
5b555da1 4403 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4404
f6095868
PE
4405 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4406 shadowing.
4407 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4408 Include <limits.h>.
4409 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4410 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4411 (load_charset_map): Mark variables that gcc -Wuninitialized
4412 does not deduce are never used uninitialized.
53df7c11 4413 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4414
f38b440c
PE
4415 * coding.c (coding_set_source, coding_set_destination):
4416 Use "else { /* comment */ }" rather than "else /* comment */;"
4417 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4418 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4419 a block, when the outer 'i' will do.
4420 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4421 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4422 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4423 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4424 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4425 Rename locals to avoid shadowing.
4426 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4427 * coding.c (emacs_mule_char, encode_invocation_designation):
4428 Now static, since they're not used elsewhere.
413bb2db 4429 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4430 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4431 (decode_coding_emacs_mule): Mark variables that gcc
4432 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4433 (detect_coding_iso_2022): Initialize a local variable that might
4434 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4435 this initialization is needed. (Bug#8211)
5f58e762
PE
4436 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4437 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4438 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4439 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4440 Remove unused macros.
f38b440c 4441
232b38b9 4442 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4443 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4444 * character.c (string_count_byte8): Likewise.
232b38b9 4445
fb90da1b
PE
4446 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4447 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4448
fb93dbc2
PE
4449 * chartab.c (copy_sub_char_table): Now static, since it's not used
4450 elsewhere.
5c156ace
PE
4451 (sub_char_table_ref_and_range, char_table_ref_and_range):
4452 Rename locals to avoid shadowing.
bbcd0949 4453 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4454
7d3b3862 4455 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4456 (BIDI_BOB): Remove unused macro.
7d3b3862 4457
6be7d3da
PE
4458 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4459 deduce are never used uninitialized.
c2ed9c8b 4460 * term.c (encode_terminal_code): Likewise.
6be7d3da 4461
75f8807f 4462 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4463
50938595
PE
4464 * tparam.h: New file.
4465 * term.c, tparam.h: Include it.
4466 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4467 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4468 Move these decls to tparam.h, and make them agree with what
4469 is actually in tparam.c. The previous trick of using incompatible
4470 decls in different modules does not conform to the C standard.
4471 All callers of tparam changed to use tparam's actual API.
4472 * tparam.c (tparam1, tparam, tgoto):
4473 Use const pointers where appropriate.
4474
fbceeba2
PE
4475 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4476 * cm.h (struct cm): Likewise.
4477 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4478 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4479 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4480 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4481 (turn_on_face, init_tty): Likewise.
4482 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4483
7f3f1250
PE
4484 * term.c (term_mouse_position): Rename local to avoid shadowing.
4485
e6ca6543
PE
4486 * alloc.c (mark_ttys): Move decl from here ...
4487 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4488
c40f8d15
AS
44892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4490
4491 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4492
cfe0661d
JB
44932011-03-09 Juanma Barranquero <lekktu@gmail.com>
4494
4495 * search.c (compile_pattern_1): Remove argument regp, unused since
4496 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4497 (compile_pattern): Don't pass it.
4498
0afb4571
J
44992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4500
4501 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4502 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4503 for ! HAVE_GTK3.
4504 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4505
4506 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4507
4508 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4509 gdk_window_get_screen, gdk_window_get_geometry,
4510 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4511 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4512 (xg_get_pixbuf_from_pixmap): New function.
4513 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4514 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4515 Call xg_get_pixbuf_from_pixmap instead of
4516 gdk_pixbuf_get_from_drawable.
4517 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4518 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4519 (xg_check_special_colors): Use GtkStyleContext and its functions
4520 for HAVE_GTK3.
4521 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4522 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4523 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4524 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4525 Call gtk_widget_get_preferred_size.
0afb4571
J
4526 (xg_frame_resized): gdk_window_get_geometry only takes 5
4527 parameters.
44f230aa
SM
4528 (xg_win_to_widget, xg_event_is_for_menubar):
4529 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4530 (xg_set_widget_bg): New function.
4531 (delete_cb): New function.
895009e1 4532 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4533 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4534 (xg_set_background_color): Call xg_set_widget_bg.
4535 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4536 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4537 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4538 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4539 if ! HAVE_GTK3.
4540 (update_frame_tool_bar): Call gtk_widget_hide.
4541 (xg_initialize): Use GDK_KEY_g.
4542
4543 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4544 if ! HAVE_GTK3
4545 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4546
4547 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4548 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4549 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4550
1c2cc4ef
JB
45512011-03-08 Juanma Barranquero <lekktu@gmail.com>
4552
4553 * w32xfns.c (select_palette): Check success of RealizePalette against
4554 GDI_ERROR, not zero.
4555
33383987 4556See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4557
4558;; Local Variables:
4559;; coding: utf-8
aac0c6e3
MR
4560;; End:
4561
33383987 4562 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4563
4564 This file is part of GNU Emacs.
4565
4566 GNU Emacs is free software: you can redistribute it and/or modify
4567 it under the terms of the GNU General Public License as published by
4568 the Free Software Foundation, either version 3 of the License, or
4569 (at your option) any later version.
4570
4571 GNU Emacs is distributed in the hope that it will be useful,
4572 but WITHOUT ANY WARRANTY; without even the implied warranty of
4573 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4574 GNU General Public License for more details.
4575
4576 You should have received a copy of the GNU General Public License
4577 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.