* lisp/progmodes/flymake.el (flymake-mode): Beware read-only dirs.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6bbef4e5
JC
12012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
2
3 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4 (force_quit_count): New var.
5 (handle_interrupt): Use it.
6
2a8ce227
JB
72012-04-10 Juanma Barranquero <lekktu@gmail.com>
8
9 * w32.c (w32_delayed_load): Record the full path of the library
10 being loaded (bug#10424).
11
935396c0
GM
122012-04-09 Glenn Morris <rgm@gnu.org>
13
05920a43
GM
14 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
15 not just in the obarray, before snarfing them. (Bug#11036)
16
935396c0
GM
17 * Makefile.in ($(leimdir)/leim-list.el):
18 Pass EMACS rather than BUILT_EMACS.
19
a18ecafa
TZ
202012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
21
22 * process.c (make_process):
23 * process.h: Add integer `gnutls_handshakes_tried' member to
24 process struct.
25
6bbef4e5
JC
26 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
27 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
28
29 * gnutls.c (gnutls_log_function2i): Convenience log function.
30 (emacs_gnutls_read): Use new log functions,
31 `gnutls_handshakes_tried' process member, and
32 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
33 attempts per process (connection).
34
b4d3bc10
CY
352012-04-09 Chong Yidong <cyd@gnu.org>
36
37 * eval.c (Fuser_variable_p, user_variable_p_eh)
38 (lisp_indirect_variable): Functions deleted.
39 (Fdefvar): Caller changed.
40
41 * callint.c (Finteractive, Fcall_interactively):
42 * minibuf.c (Fread_variable): Callers changed.
43
70f4d973
EZ
442012-04-09 Eli Zaretskii <eliz@gnu.org>
45
46 * xdisp.c (set_cursor_from_row): If the display string appears in
47 the buffer at position that is closer to point than the position
48 after the display string, display the cursor on the first glyph of
49 the display string. Fixes cursor display when a 'display' text
50 property immediately follows invisible text. (Bug#11094)
51
cb3c2e3e
PE
522012-04-09 Paul Eggert <eggert@cs.ucla.edu>
53
54 composite.c: use 'double' consistently
55 * composite.c (get_composition_id): Use 'double' consistently
56 instead of converting 'float' to 'double' and vice versa; this is
57 easier to understand and avoids a GCC warning.
58
fd06db5d
GM
592012-04-09 Glenn Morris <rgm@gnu.org>
60
50fe702a
GM
61 * Makefile.in: Generate leim-list with bootstrap-emacs, in
62 preparation for dumping it with emacs. (Bug#4789)
63 (leimdir): New variable.
64 ($(leimdir)/leim-list.el): New rule.
65 (emacs$(EXEEXT)): Depend on leim-list.el.
66
fd06db5d
GM
67 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
68 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
69 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
70
55c131ee
AS
712012-04-08 Andreas Schwab <schwab@linux-m68k.org>
72
73 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
74 proper alignment.
75
9209588f
JB
762012-04-07 Juanma Barranquero <lekktu@gmail.com>
77
78 * xml.c (init_libxml2_functions) [WINDOWSNT]:
79 Remove unused local variable.
80
e3fb2efb
PE
812012-04-07 Paul Eggert <eggert@cs.ucla.edu>
82
83 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
84 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
85 (mark_memory): Mark Lisp_Objects only if pointers might hide in
86 objects, as mark_maybe_pointer will catch them otherwise.
87 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
88 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
89
b5385551
PE
902012-04-07 Paul Eggert <eggert@cs.ucla.edu>
91
92 Fix typo that broke non-Windows builds.
93 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
94
9078ead6
EZ
952012-04-07 Eli Zaretskii <eliz@gnu.org>
96
97 Support building on MS-Windows with libxml2.
98
99 * makefile.w32-in (OBJ2): Add xml.$(O).
100 (GLOBAL_SOURCES): Add xml.c.
101 ($(BLD)/xml.$(O)): New dependency list.
102
103 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
104 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
105 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
106 [!WINDOWSNT]: New macros.
107 (init_libxml2_functions, libxml2_loaded_p): New functions.
108 (parse_region): Call fn_xmlCheckVersion instead of using the macro
109 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
110 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
111 Calls xmlCleanupParser only if libxml2 was loaded (or statically
112 linked in).
6bbef4e5
JC
113 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
114 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
115 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
116
117 * emacs.c: Don't include libxml/parser.h.
118 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
119 xmlCleanupParser directly.
120
121 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
122
3811fdf3
EZ
1232012-04-07 Eli Zaretskii <eliz@gnu.org>
124
125 * indent.c (Fvertical_motion): If there is a display string at
126 point, use it.vpos to compute how many lines to backtrack after
127 move_it_to point. (Bug#11133)
128
2f8e16b2
EZ
1292012-04-06 Eli Zaretskii <eliz@gnu.org>
130
131 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
132 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
133 about subtle differences between FETCH_CHAR* and STRING_CHAR*
134 macros related to unification of CJK characters. For the details,
135 see the discussion following the message here:
136 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
137
3d439cd1
CY
1382012-04-04 Chong Yidong <cyd@gnu.org>
139
140 * keyboard.c (Vdelayed_warnings_list): Doc fix.
141
8bc53d00
EZ
1422012-04-01 Eli Zaretskii <eliz@gnu.org>
143
144 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
145 instead of alloca. (Bug#11138)
146
3b0512a3
AS
1472012-04-01 Andreas Schwab <schwab@linux-m68k.org>
148
149 * w32menu.c (is_simple_dialog): Properly check lisp types.
150 (Bug#11141)
151
8427ddd2
EZ
1522012-03-31 Eli Zaretskii <eliz@gnu.org>
153
979022ef
EZ
154 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
155 position we get to after a call to move_it_to fails the
156 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
157 only if we wind up in a string from display property. (Bug#11063)
158
a6b1c7cc
EZ
159 * window.c (Fdelete_other_windows_internal): Invalidate the row
160 and column information about mouse highlight, so that redisplay
161 restores it after reallocating the glyph matrices. (Bug#7464)
162
8427ddd2
EZ
163 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
164 string comes from a `display' text property, use the buffer
165 position of that property as if we actually saw that position in
166 the row's glyphs.
697ba24b
EZ
167 (move_it_by_lines): Remove the assertion that
168 "it->current_x == 0 && it->hpos == 0" which can be legitimately
169 violated when there's a before-string at the beginning of a line.
170 (Bug#11063)
8427ddd2 171
65a0a738
EZ
1722012-03-30 Eli Zaretskii <eliz@gnu.org>
173
174 * xdisp.c (append_space_for_newline): If the default face was
175 remapped, use the remapped face for the appended newline.
176 (extend_face_to_end_of_line): Use the remapped default face for
177 extending the face to the end of the line.
178 (display_line): Call extend_face_to_end_of_line when the default
179 face was remapped. (Bug#11068)
180
581355cc
EZ
1812012-03-29 Eli Zaretskii <eliz@gnu.org>
182
183 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
184
e8fc049f
SM
1852012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
186
187 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
188
4fb9a543
GM
1892012-03-27 Glenn Morris <rgm@gnu.org>
190
191 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
192 Doc fixes.
193
679910f1
KH
1942012-03-26 Kenichi Handa <handa@m17n.org>
195
196 * dispextern.h (struct glyph): Fix previous change. Change the
197 bit length of glyphless.ch to 25 (Bug#11082).
198
90d49b7f
CY
1992012-03-26 Chong Yidong <cyd@gnu.org>
200
201 * keyboard.c (Vselection_inhibit_update_commands): New variable.
202 (command_loop_1): Use it; inhibit selection update for
203 handle-select-window too (Bug#8996).
204
f514f6f0
FP
2052012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
206
e8fc049f 207 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 208
bf43fa51
KH
2092012-03-25 Kenichi Handa <handa@m17n.org>
210
211 * dispextern.h (struct glyph): Change the bit length of
212 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
213
8a0c01dd
EZ
2142012-03-24 Eli Zaretskii <eliz@gnu.org>
215
216 * s/ms-w32.h (tzname): Include time.h before redirecting to
217 _tzname. Fixes the MSVC build. (Bug#9960)
218
7d1c3a76
AS
2192012-03-24 Andreas Schwab <schwab@linux-m68k.org>
220
8ed79523
AS
221 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
222 characters.
223
7d1c3a76
AS
224 * xterm.c (XTread_socket): Only modify handling_signal if
225 !SYNC_INPUT. (Bug#11080)
226
e99a9b8b
EZ
2272012-03-23 Eli Zaretskii <eliz@gnu.org>
228
229 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
230 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
231 when fetching a multibyte character consumes more bytes than
232 CHAR_BYTES returns, due to unification of CJK characters in
233 string_char. (Bug#11073)
234
5063c0e1
TN
2352012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
236
237 * process.c (wait_reading_process_output): Handle pty disconnect
238 by refraining from sending oneself a SIGCHLD (bug#10933).
239
9f851fbd
CY
2402012-03-22 Chong Yidong <cyd@gnu.org>
241
242 * dispextern.h (struct it): New member string_from_prefix_prop_p.
243
5063c0e1 244 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
245 Mark string as coming from a prefix property.
246 (handle_face_prop): Use default face for prefix strings (Bug#4281).
247 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
248
fb5b8aca
CY
2492012-03-21 Chong Yidong <cyd@gnu.org>
250
251 * xfaces.c (Vface_remapping_alist): Doc fix.
252
62356a1b
EZ
2532012-03-20 Eli Zaretskii <eliz@gnu.org>
254
255 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
256 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
257 Doc fixes.
62356a1b 258
025de85b
CY
2592012-03-20 Chong Yidong <cyd@gnu.org>
260
261 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
262 to reflect default non-nil value of redisplay-dont-pause.
263
4827f94e
KH
2642012-03-19 Kenichi Handa <handa@m17n.org>
265
266 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
267 it fit in a valid range (Bug#11003).
268
e50a24a2
EZ
2692012-03-18 Eli Zaretskii <eliz@gnu.org>
270
271 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
272 that is not from display property, accept the row as a "cursor
273 row" if one of the string's character has a non-nil `cursor'
274 property. Fixes cursor positioning when there are newlines in
275 overlay strings, e.g. in icomplete.el. (Bug#11035)
276
9af5ed87
PE
2772012-03-12 Paul Eggert <eggert@cs.ucla.edu>
278
279 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
280
d1f55f16
CY
2812012-03-12 Chong Yidong <cyd@gnu.org>
282
283 * eval.c (inhibit_lisp_code): Rename from
284 inhibit_window_configuration_change_hook; move from window.c.
285
286 * xfns.c (unwind_create_frame_1, Fx_create_frame):
287 * window.c (run_window_configuration_change_hook)
288 (syms_of_window): Callers changed.
289
66c5eebd
CY
2902012-03-11 Chong Yidong <cyd@gnu.org>
291
413df973
CY
292 * keymap.c (Fkey_description): Doc fix (Bug#9700).
293
66c5eebd
CY
294 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
295
1de11f56
CY
2962012-03-10 Chong Yidong <cyd@gnu.org>
297
298 * frame.c (other_visible_frames): Don't assume the selected frame
299 is visible (Bug#10955).
300
cae07000
SM
3012012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
302
303 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
304
89c94350
JD
3052012-03-08 Jan Djärv <jan.h.d@swipnet.se>
306
307 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
308 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
309 zero (Bug#10954).
310
999dd333
GM
3112012-03-03 Glenn Morris <rgm@gnu.org>
312
01a6dcc8 313 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 314
de0100f2
EZ
3152012-03-02 Eli Zaretskii <eliz@gnu.org>
316
317 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
318 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
319 (redisplay_window, next_element_from_string): Fix typos in
320 comments.
3e441275
EZ
321 (redisplay_window): Pass to move_it_vertically the margin in
322 pixels, not in screen lines.
de0100f2 323
96a72ee9
GM
3242012-03-02 Glenn Morris <rgm@gnu.org>
325
326 * buffer.c (buffer-list-update-hook): Doc fix.
327
312508d7
EZ
3282012-02-29 Eli Zaretskii <eliz@gnu.org>
329
330 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
331 push_it before setting up the iterator for the first overlay
332 string, even if we have an empty string loaded.
333 (next_overlay_string): If there's an empty string on the iterator
334 stack, pop the stack. (Bug#10903)
335
27f3c637
PE
3362012-02-25 Paul Eggert <eggert@cs.ucla.edu>
337
338 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
339 Suggested by Stefan Monnier in
340 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
341 * alloc.c (widen_to_Lisp_Object): New static function.
342 (mark_memory): Also mark Lisp_Objects by fetching pointer words
343 and widening them to Lisp_Objects. This would work even if
344 USE_LSB_TAG is defined and wide integers are used, which might
345 happen in a future version of Emacs.
346
3c9dfce6
CY
3472012-02-25 Chong Yidong <cyd@gnu.org>
348
fa74b241
CY
349 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
350 Doc fix.
351
3c9dfce6
CY
352 * xselect.c (Fx_selection_exists_p): Doc fix.
353 (x_clipboard_manager_save_all): Print an informative message
354 before saving to clipboard manager.
355
9486df08
CY
3562012-02-24 Chong Yidong <cyd@gnu.org>
357
358 * keyboard.c (process_special_events): Handle all X selection
359 requests in kbd_buffer, not just the next one (Bug#8869).
360
f01d3321
CY
3612012-02-23 Chong Yidong <cyd@gnu.org>
362
363 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
364 call when setting menu-bar-lines and tool-bar-lines parameters.
365 (unwind_create_frame_1): New helper function.
366
367 * window.c (inhibit_window_configuration_change_hook): New var.
368 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 369 (syms_of_window): Initialize it.
f01d3321 370
86b847b6
CY
3712012-02-22 Chong Yidong <cyd@gnu.org>
372
373 * xterm.c (x_draw_image_relief): Add missing type check for
374 Vtool_bar_button_margin (Bug#10743).
375
a59225b1
CY
3762012-02-21 Chong Yidong <cyd@gnu.org>
377
378 * fileio.c (Vfile_name_handler_alist): Doc fix.
379
380 * buffer.c (Fget_file_buffer): Protect against invalid file
381 handler return value.
382
310f5bd4
PE
3832012-02-20 Paul Eggert <eggert@cs.ucla.edu>
384
cb3a28cc
PE
385 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
386 when computing $valmask.
387
310f5bd4
PE
388 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
389 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
390 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
391 It's useless in that case, and it can cause problems on hosts
392 that allocate halves of EMACS_INT values separately.
393 Reported by Dan Horák. Diagnosed by Andreas Schwab in
394 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
395 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
396 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
397 it avoids undefined behavior on hosts where shifting right by more
398 than the word width has undefined behavior.
399
2375c96a
CY
4002012-02-19 Chong Yidong <cyd@gnu.org>
401
402 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
403 (Funhandled_file_name_directory, Ffile_name_as_directory)
404 (Fdirectory_file_name, Fexpand_file_name)
405 (Fsubstitute_in_file_name): Protect against invalid file handler
406 return values (Bug#10845).
407
3eb49e71
EZ
4082012-02-18 Eli Zaretskii <eliz@gnu.org>
409
410 * .gdbinit (pitx): Fix incorrect references to fields of the
411 iterator stack.
412
7b926f3f
CY
4132012-02-17 Chong Yidong <cyd@gnu.org>
414
415 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
416
11273115
PE
4172012-02-15 Paul Eggert <eggert@cs.ucla.edu>
418
419 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
420 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
421
c3a70e2b
CY
4222012-02-15 Chong Yidong <cyd@gnu.org>
423
424 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
425 marked as special. Also, starting docstrings with * is obsolete.
426
0ca43699
AS
4272012-02-13 Andreas Schwab <schwab@linux-m68k.org>
428
429 * gnutls.c (emacs_gnutls_write): Fix last change.
430
2e8f3c56
LI
4312012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
432
433 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
434 send_process.
435
af70074f
SM
4362012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
437
438 * keymap.c (Fsingle_key_description): Handle char ranges.
439
95986d52
CY
4402012-02-12 Chong Yidong <cyd@gnu.org>
441
afd83bd1
CY
442 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
443 as that creates a dangerous corner case.
444
95986d52
CY
445 * window.c (Fdelete_window_internal): Invalidate the mouse
446 highlight (Bug#9904).
447
bd7da63e
GM
4482012-02-12 Glenn Morris <rgm@gnu.org>
449
450 * xselect.c (Fx_own_selection_internal)
451 (Fx_get_selection_internal, Fx_disown_selection_internal)
452 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
453 * nsselect.m (Fx_own_selection_internal)
454 (Fx_disown_selection_internal, Fx_selection_exists_p)
455 (Fx_selection_owner_p, Fx_get_selection_internal):
456 Sync docs and argument specs with the xselect.c versions.
457
77abcbc2
LI
4582012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
459
460 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
461
90b671e2
EZ
4622012-02-11 Eli Zaretskii <eliz@gnu.org>
463
1c0ca0b7
EZ
464 * w32select.c (Fx_selection_exists_p): Sync doc string and
465 argument list with xselect.c. (Bug#10783)
466
467 * w16select.c (Fx_selection_exists_p): Sync doc string and
468 argument list with xselect.c. (Bug#10783)
90b671e2 469
49241268
GM
4702012-02-10 Glenn Morris <rgm@gnu.org>
471
472 * fns.c (Fsecure_hash): Doc fix.
473
f998bbe7 4742012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
475
476 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
477
0992bd9c
CY
4782012-02-07 Chong Yidong <cyd@gnu.org>
479
480 * buffer.c (Fbuffer_local_variables)
481 (buffer_lisp_local_variables): Handle unbound vars correctly;
482 don't let Qunbound leak into Lisp.
483
af008560
GM
4842012-02-07 Glenn Morris <rgm@gnu.org>
485
dd605cc4
GM
486 * image.c (Fimagemagick_types): Doc fix.
487
af008560
GM
488 * image.c (imagemagick-render-type): Change it from a lisp object
489 to an integer. Move the doc here from the lisp manual.
490 Treat all values not equal to 0 the same.
491
1449fa1d
CY
4922012-02-06 Chong Yidong <cyd@gnu.org>
493
494 * doc.c (store_function_docstring): Avoid applying docstring of
495 alias to base function (Bug#2603).
496
3723ec07
AS
4972012-02-04 Andreas Schwab <schwab@linux-m68k.org>
498
499 * .gdbinit (pp1, pv1): Remove redundant defines.
500 (pr): Use pp.
501
79c1cc1e
CY
5022012-02-04 Chong Yidong <cyd@gnu.org>
503
504 * nsterm.m: Declare a global (Bug#10694).
505
d7f29f8e
EZ
5062012-02-04 Eli Zaretskii <eliz@gnu.org>
507
cae07000
SM
508 * w32.c (get_emacs_configuration_options):
509 Include --enable-checking, if specified, in the return value.
d7f29f8e 510
3b95a6f9
MR
5112012-02-04 Martin Rudalics <rudalics@gmx.at>
512
513 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
514 after rounding frame sizes. (Bug#9723)
515
d6fa96a6
EZ
5162012-02-04 Eli Zaretskii <eliz@gnu.org>
517
518 * keyboard.c (adjust_point_for_property): Don't position point
519 before BEGV. (Bug#10696)
520
df0b2940
PE
5212012-02-03 Paul Eggert <eggert@cs.ucla.edu>
522
523 Handle overflow when computing char display width (Bug#9496).
524 * character.c (char_width): Return EMACS_INT, not int.
525 (char_width, c_string_width): Check for overflow when
526 computing the width; this is possible now that individual
527 characters can have unbounded width. Problem introduced
528 by merge from Emacs 23 on 2012-01-19.
529
6bee44d6
MA
5302012-02-02 Michael Albinus <michael.albinus@gmx.de>
531
532 * dbusbind.c (Fdbus_register_method): Mention the return value
533 :ignore in the docstring.
534
44f92739
GM
5352012-02-02 Glenn Morris <rgm@gnu.org>
536
1b9f60cc
GM
537 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
538
44f92739
GM
539 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
540 Unconditionally set to t. (Bug#10673)
541 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
542 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
543 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
544
c5d3843c
KH
5452012-02-02 Kenichi Handa <handa@m17n.org>
546
547 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
548 0, do not call append_composite_glyph.
549
159462d4 5502012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
551
552 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
553 NULL (Bug#6988).
554 (x_produce_glyphs): If the component of a composition is a null
555 string, set it->pixel_width to 1 to avoid zero-width glyph.
556
78cef877
EZ
5572012-02-01 Eli Zaretskii <eliz@gnu.org>
558
559 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
560 first 2 arguments are identical. This makes inserting large
561 output from a subprocess an order of magnitude faster on
562 MS-Windows, where all sbrk'ed memory is always contiguous.
563
97897668
GM
5642012-01-31 Glenn Morris <rgm@gnu.org>
565
566 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 567 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
568 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
569
31fd3586
GM
5702012-01-29 Glenn Morris <rgm@gnu.org>
571
572 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
573
0e24a8b2
CY
5742012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
575
576 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
577
cc0adcb0
CY
5782012-01-28 Chong Yidong <cyd@gnu.org>
579
580 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
581
acc28cb9
CY
5822012-01-26 Chong Yidong <cyd@gnu.org>
583
9c69cfb7
CY
584 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
585
acc28cb9
CY
586 * search.c (Fsearch_forward, Fsearch_backward): Document negative
587 repeat counts (Bug#10507).
588
48da7392
GM
5892012-01-26 Glenn Morris <rgm@gnu.org>
590
591 * lread.c (syms_of_lread): Doc fix.
592
14af5f7f
CY
5932012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
594
595 * coding.c (encode_designation_at_bol): Change return value to
596 EMACS_INT.
597
0b21c100
CY
5982012-01-25 Chong Yidong <cyd@gnu.org>
599
600 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
601
3c2907f7
CY
6022012-01-21 Chong Yidong <cyd@gnu.org>
603
604 * floatfns.c (Fcopysign): Make the second argument non-optional,
605 since nil is not allowed anyway.
606
959ad23f
AS
6072012-01-21 Andreas Schwab <schwab@linux-m68k.org>
608
609 * process.c (read_process_output): Use p instead of XPROCESS (proc).
610 (send_process): Likewise.
611
34a02f46
MR
6122012-01-19 Martin Rudalics <rudalics@gmx.at>
613
614 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
615 (Vwindow_persistent_parameters): Do not use Qstate.
616 Rewrite doc-strings.
34a02f46 617
1259009a 6182012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
619
620 * character.c (char_width): New function.
70d4fdf6
GM
621 (Fchar_width, c_string_width, lisp_string_width):
622 Use char_width (Bug#9496).
25ed9e61 623
6a6ee00d
MR
6242012-01-16 Martin Rudalics <rudalics@gmx.at>
625
626 * window.c (Vwindow_persistent_parameters): New variable.
627 (Fset_window_configuration, save_window_save): Handle persistent
628 window parameters.
629
c85efaf7
EZ
6302012-01-14 Eli Zaretskii <eliz@gnu.org>
631
632 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
633 thrashing the stack of the thread. (Bug#9087)
634
5944709e
PE
6352012-01-12 Paul Eggert <eggert@cs.ucla.edu>
636
637 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
638
e71f5d99
EZ
6392012-01-11 Eli Zaretskii <eliz@gnu.org>
640
641 * xdisp.c (rows_from_pos_range): Handle the case where the
642 highlight ends on a newline. (Bug#10464)
643 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
644 he end column for display of highlight that ends on a newline
645 before a R2L line.
646
ce316182
GM
6472012-01-11 Glenn Morris <rgm@gnu.org>
648
649 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
650 from load-path also when installation-directory is nil. (Bug#10208)
651
5b43da69
GM
6522012-01-10 Glenn Morris <rgm@gnu.org>
653
74cc8ff9
GM
654 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
655
7d8d6e4e
GM
656 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
657 Update template values to be closer to their typical values these days.
5b43da69 658
a0db8d43
EZ
6592012-01-09 Eli Zaretskii <eliz@gnu.org>
660
661 * xdisp.c (rows_from_pos_range): Accept additional argument
662 DISP_STRING, and accept any glyph in a row whose object is that
663 string as eligible for mouse highlight. Fixes mouse highlight of
664 display strings from overlays. (Bug#10464)
665
9a0115ab 6662012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 667
b9110d6a 668 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
669 * fileio.c (auto_saving_dir_umask): New static var.
670 (Fmake_directory_internal): Use it.
671 (do_auto_save_make_dir): Set it, instead of invoking chmod after
672 creating the directory. The old code temporarily assigns
673 too-generous permissions to the directory.
674 (do_auto_save_eh): Clear it.
b9110d6a 675 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
676 that the var is always cleared.
677
6c1bd3f3
EZ
6782012-01-07 Eli Zaretskii <eliz@gnu.org>
679
680 * search.c (scan_buffer): Pass character positions to
681 know_region_cache, not byte positions. (Bug#6540)
682
069d2b50
L
6832012-01-07 LynX <_LynX@bk.ru> (tiny change)
684
685 * w32.c (sys_rename): Report EXDEV when rename of a directory
686 fails because the target is on another logical disk. (Bug#10284)
687
75bf0d33
DB
6882012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
689
690 * xterm.c (x_embed_request_focus): New function.
691
692 * xterm.h: Add prototype.
693
694 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
695
1c6e5a32
GM
6962012-01-05 Glenn Morris <rgm@gnu.org>
697
698 * emacs.c (emacs_copyright): Update short copyright year to 2012.
699
651e947e
EZ
7002012-01-01 Eli Zaretskii <eliz@gnu.org>
701
702 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
703 Load gnutls_transport_set_lowat only if GnuTLS version is below
704 2.11.1.
705 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
706 GnuTLS versions below 2.11.1.
707
3778cdd8
AL
7082011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
709
710 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
711 to the doc string advising against its use for altering the way
712 windows are scrolled.
713
0e5317f7
KH
7142011-12-28 Kenichi Handa <handa@m17n.org>
715
716 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
717 coding-system ASCII compatible only when it does not produce BOM
718 on encoding (Bug#10383).
719
93d5ca1f
JD
7202011-12-26 Jan Djärv <jan.h.d@swipnet.se>
721
722 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
723 can scroll.
724 (create_and_show_popup_menu): Always use menu_position_func for
725 Gtk3 (Bug#10361).
726
ca22b785
AS
7272011-12-24 Andreas Schwab <schwab@linux-m68k.org>
728
729 * callint.c (Fcall_interactively): Don't truncate prompt string.
730
d048e1e6
EZ
7312011-12-23 Eli Zaretskii <eliz@gnu.org>
732
733 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
734 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 735 resumed from there (after widening). (Bug#10360)
d048e1e6 736
5ccaba1f
JD
7372011-12-22 Jan Djärv <jan.h.d@swipnet.se>
738
739 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
740
204ee57f
JD
7412011-12-21 Jan Djärv <jan.h.d@swipnet.se>
742
b81d40f0
JB
743 * nsterm.m (x_free_frame_resources):
744 Release f->output_data.ns->miniimage.
204ee57f
JD
745 (ns_index_color): Fix indentation. Do not retain
746 color_table->colors[i].
747
748 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
749 before returning.
750
751 * nsfns.m (x_set_background_color): Assign return value from
752 ns_index_color to face-background instead of NSColor*.
753 (ns_implicitly_set_icon_type): Fix indentation.
754 Change assignment in for loop to comparison.
755
756 * emacs.c (ns_pool): New variable.
757 (main): Assign ns_pool.
758 (Fkill_emacs): Call ns_release_autorelease_pool.
759
760 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
761 autorelease fdesc, release fdAttrs and tdict.
762 (ns_get_covering_families): Release charset.
763 (ns_findfonts): Release NSFontDescriptor created with new.
764 (ns_uni_to_glyphs): Fix indentation.
765 (setString): Release attrStr before assigning new value.
766
c803b2b7
JD
7672011-12-18 Jan Djärv <jan.h.d@swipnet.se>
768
678f4426
JD
769 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
770 and NS_IMPL_COCOA.
771 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
772 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
773
cd394be1 7742011-12-18 David Reitter <reitter@cmu.edu>
678f4426 775
5fecd5fc
JD
776 * nsterm.m (ns_term_init): Subscribe for notifications
777 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
778 to method trackingNotification in EmacsMenu.
779
780 * nsmenu.m (trackingMenu): New variable.
3771cb17 781 (trackingNotification): New method (from Aquamacs).
5fecd5fc 782 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 783 from Aquamacs (Bug#7030).
678f4426
JD
784
7852011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 786
c803b2b7
JD
787 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
788 (symbol_to_nsstring): Fix indentation.
789 (ns_symbol_to_pb): New function.
cae07000
SM
790 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
791 (Fns_rotate_cut_buffers_internal): Remove.
792 (Fns_store_selection_internal): Rename from
c803b2b7
JD
793 Fns_store_cut_buffer_internal.
794 (ns_get_foreign_selection, Fx_own_selection_internal)
795 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
796 (Fns_get_selection_internal, Fns_store_selection_internal):
797 Use ns_symbol_to_pb and check if return value is nil.
798 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
799 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
800 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
801 renamed to Sns_store_selection_internal.
802 (ns_handle_selection_request): Move code to Fx_own_selection_internal
803 and remove this function.
804 (ns_handle_selection_clear): Remove, never used.
805 (Fx_own_selection_internal): Move code from ns_handle_selection_request
806 here.
807
e1b01a3a
KB
8082011-12-17 Ken Brown <kbrown@cornell.edu>
809
810 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
811 GID is unknown (Bug#10257).
812
2adb6e85
PE
8132011-12-17 Paul Eggert <eggert@cs.ucla.edu>
814
815 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
816 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
817 which caused a build failure on GNU/Linux IA-64. This problem was
818 introduced by my 2011-10-07 patch.
819
d1d7b339
JL
8202011-12-15 Juri Linkov <juri@jurta.org>
821
822 * image.c (imagemagick_error): New function. (Bug#10112)
823 (imagemagick_load_image): Comment out `MagickSetResolution' call.
824 Use `imagemagick_error' where ImageMagick functions return
825 `MagickFalse'.
826 (Fimagemagick_types): Add `Fnreverse' to return the list in the
827 proper order.
828
100d5755
KH
8292011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
830
831 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
832 fill background (Bug#8992).
833
454592a6
MR
8342011-12-13 Martin Rudalics <rudalics@gmx.at>
835
836 * window.c (Vwindow_combination_resize)
837 (Vwindow_combination_limit): Use t instead of non-nil in
838 doc-strings.
61d4b438
MR
839 (Vrecenter_redisplay): Add first sentence of doc-string on
840 separate line.
53524d93 841 (Frecenter): Fix doc-string typo.
454592a6 842
3633e3aa
KH
8432011-12-11 Kenichi Handa <handa@m17n.org>
844
845 * coding.c (Funencodable_char_position): Pay attention to the
846 buffer text relocation (Bug#9389).
847
7b9d523a
JD
8482011-12-10 Jan Djärv <jan.h.d@swipnet.se>
849
850 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
851 gtk_init (Bug#10100).
852
b73189c6
EZ
8532011-12-10 Eli Zaretskii <eliz@gnu.org>
854
855 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
856 IT->string is nil. (Bug#10263)
857
f7dfe5d6
JD
8582011-12-10 Jan Djärv <jan.h.d@swipnet.se>
859
83faebb4
JD
860 * nsterm.h (x_free_frame_resources): Declare.
861
f7dfe5d6
JD
862 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
863 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
864
865 * nsterm.h (ns_get_defaults_value): Declare.
866
867 * nsterm.m (ns_default): Call ns_get_defaults_value.
868
7cd4e72c
EZ
8692011-12-09 Eli Zaretskii <eliz@gnu.org>
870
871 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
872 (Bug#10170)
873
b34d7317
YM
8742011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
875
876 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
877 that where the value of an _OBJC_* symbol points to is in the .bss
878 section (Bug#10240).
879
76470ad1
KH
8802011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
881
882 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 883 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 884
745fff94
KH
8852011-12-08 Kenichi Handa <handa@m17n.org>
886
887 * ftfont.c (get_adstyle_property): Fix previous change
888 (Bug#10233).
889
6e44397c
JB
8902011-12-07 Juanma Barranquero <lekktu@gmail.com>
891
892 * w32.c (init_environment): If no_site_lisp, remove site-lisp
893 dirs from the default value of EMACSLOADPATH (bug#10208).
894
7efa6272
GM
8952011-12-07 Glenn Morris <rgm@gnu.org>
896
897 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
898 installation and source directories as well. (Bug#10208)
899
f6fc4d87
CY
9002011-12-06 Chong Yidong <cyd@gnu.org>
901
902 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
903
2bf26180
GM
9042011-12-06 Glenn Morris <rgm@gnu.org>
905
906 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
907 as an error, not just -1. (Bug#10217)
908
3a6ad4f0
CY
9092011-12-05 Chong Yidong <cyd@gnu.org>
910
911 * keyboard.c (process_special_events): New function.
912 (swallow_events, Finput_pending_p): Use it (Bug#10195).
913
75a3b399
PE
9142011-12-05 Paul Eggert <eggert@cs.ucla.edu>
915
916 * coding.c (encode_designation_at_bol): Don't use uninitialized
917 local variable (Bug#9318).
918
c3c9e25e
KH
9192011-12-05 Kenichi Handa <handa@m17n.org>
920
921 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
922 return Qnil (Bug#8046, Bug#10193).
923
5eb05ea3
KH
9242011-12-05 Kenichi Handa <handa@m17n.org>
925
926 * coding.c (encode_designation_at_bol): New args charbuf_end and
927 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
928 (coding_set_source): Return how many bytes coding->source was
929 relocated.
930 (coding_set_destination): Return how many bytes
931 coding->destination was relocated.
932 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 933 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
934
9352011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
936
937 * coding.c (CODING_CHAR_CHARSET_P): New macro.
938 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
939 macro (Bug#9318).
940
9412011-12-05 Andreas Schwab <schwab@linux-m68k.org>
942
943 The following changes are to fix Bug#9318.
944
a79703f5 945 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
946 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
947 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 948 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 949
7dbda6df
JB
9502011-12-05 Juanma Barranquero <lekktu@gmail.com>
951
952 * lisp.h (process_quit_flag): Fix external declaration.
953
6d5eb5b0
SM
9542011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
955
956 Don't macro-inline non-performance-critical code.
957 * eval.c (process_quit_flag): New function.
958 * lisp.h (QUIT): Use it.
959
a0c3fad0
JD
9602011-12-04 Jan Djärv <jan.h.d@swipnet.se>
961
962 * nsfns.m (get_geometry_from_preferences): New function.
963 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
964
6c07aac2
AS
9652011-12-04 Andreas Schwab <schwab@linux-m68k.org>
966
967 * emacs.c (Qkill_emacs): Define.
968 (syms_of_emacs): Initialize it.
969 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
970 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
971 (quit_throw_to_read_char): Add parameter `from_signal'.
972 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
973 * lisp.h (QUIT): Call Fkill_emacs if requested.
974
c052ead4
JD
9752011-12-03 Jan Djärv <jan.h.d@swipnet.se>
976
977 * widget.c (update_wm_hints): Return if wmshell is null.
978 (widget_update_wm_size_hints): New function.
979
980 * widget.h (widget_update_wm_size_hints): Declare.
981
982 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
983 widget_update_wm_size_hints (Bug#10104).
984
9e49252b
EZ
9852011-12-03 Eli Zaretskii <eliz@gnu.org>
986
987 * xdisp.c (handle_invisible_prop): If the invisible text ends just
988 before a newline, prepare the bidi iterator for consuming the
989 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 990 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 991
02b16839
JL
9922011-12-02 Juri Linkov <juri@jurta.org>
993
994 * search.c (Fword_search_regexp): New Lisp function created from
995 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
996 (Fword_search_backward, Fword_search_forward)
997 (Fword_search_backward_lax, Fword_search_forward_lax):
998 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
999 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1000
0068070e
SM
10012011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1002
1003 * fileio.c (Finsert_file_contents): Move after-change-function call
1004 to before the "handled:" label, since all "goto handled" appear in
1005 cases where the *-change-functions have already been properly called
1006 (bug#10117).
1007
3360a3fc
AS
10082011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1009
1010 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1011 waiting for input. (Bug#10169)
1012
73d6c093
EZ
10132011-11-30 Eli Zaretskii <eliz@gnu.org>
1014
1015 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1016 verifies glyph row's hash code--we have just reallocated the
1017 glyphs, so their contents can be complete garbage. (Bug#10164)
1018
febe6bea
JB
10192011-11-30 Juanma Barranquero <lekktu@gmail.com>
1020
1021 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1022
801a4313
EZ
10232011-11-30 Eli Zaretskii <eliz@gnu.org>
1024
1025 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1026 attributes are tested _before_ calling verify_row_hash, to protect
1027 against GCC re-ordering of the tests. (Bug#10164)
1028
2b56b87e
JD
10292011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1030
1031 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1032
1033 * xterm.c (handle_one_xevent): Only set async_visible and friends
1034 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1035 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1036 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1037
dbf31225
PE
10382011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1039
1040 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1041 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1042 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1043 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1044 All uses changed to use GCPRO1 etc.
1045 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1046 Revert to old implementation (i.e., before 2011-03-11).
1047
1305621b
YM
10482011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1049
1050 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1051 of scroll runs so as to avoid assigning disabled bogus rows and
1052 unnecessary graphics copy operations.
1053
8c9afb46
EZ
10542011-11-27 Eli Zaretskii <eliz@gnu.org>
1055
1056 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1057 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1058 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1059 (malloc, free, realloc, calloc): Redirect to e_* only when
1060 compiling Emacs.
1061
1062 * lisp.h (GCTYPEBITS): Move before first use.
1063 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1064 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1065 this macro definition.
1066
1067 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1068 _MSC_VER.
1069
54e9e3bf
JD
10702011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1071
6d5eb5b0
SM
1072 * gtkutil.c (xg_create_frame_widgets):
1073 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1074 present with Gtk+ 2.0.
1075
83aca1cb
PE
10762011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 * fileio.c (Finsert_file_contents): Undo previous change; see
1079 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1080
5b76caa4
PE
10812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 Rename locals to avoid shadowing.
1084 * fileio.c (Finsert_file_contents):
1085 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1086 * process.c (wait_reading_process_output):
1087 Rename inner 'proc' to 'p' to avoid shadowing.
1088 Indent for consistency with usual Emacs style.
1089
8c535114
EZ
10902011-11-25 Eli Zaretskii <eliz@gnu.org>
1091
1092 * xdisp.c (redisplay_window): If cursor row is not fully visible
1093 after recentering, and scroll-conservatively is set to a large
1094 number, scroll window by a few more lines to make the cursor fully
1095 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1096 (start_display): Don't move to the next line if the display should
1097 start at a newline that is part of a display vector or an overlay
1098 string. (Bug#10119)
8c535114 1099
fa4fdb5c
JL
11002011-11-24 Juri Linkov <juri@jurta.org>
1101
1102 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1103 after the `MagickPingImage' call. (Bug#10112)
1104
90ec88df
CY
11052011-11-23 Chong Yidong <cyd@gnu.org>
1106
1107 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1108
56e2e794
MR
11092011-11-23 Martin Rudalics <rudalics@gmx.at>
1110
1111 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1112 making another buffer current. (Bug#10114)
1113
b6e64c41
GM
11142011-11-23 Glenn Morris <rgm@gnu.org>
1115
1116 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1117
6b21de18
CY
11182011-11-23 Chong Yidong <cyd@gnu.org>
1119
1120 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1121 using it (Bug#5984).
1122
b12cd789
EZ
11232011-11-22 Eli Zaretskii <eliz@gnu.org>
1124
1125 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1126 and header-lines, as they don't have one computed for them.
1127 (Bug#10098)
1128
1129 * .gdbinit (prow): Make displayed values more self-explaining.
1130 Add row's hash code.
1131
261b6fd4
LMI
11322011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1133
1134 * process.c (wait_reading_process_output): Fix asynchrounous
1135 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1136 (wait_reading_process_output): Add comment and URL.
261b6fd4 1137
e7cfd277
JD
11382011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1139
1140 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1141
a9b9b7f5
CY
11422011-11-21 Chong Yidong <cyd@gnu.org>
1143
1144 * window.c (Fnext_window, Fprevious_window): Doc fix.
1145
b0d15b4f
SM
11462011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1147
1148 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1149
fe7a3057
JB
11502011-11-20 Juanma Barranquero <lekktu@gmail.com>
1151
1152 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1153
d2999b1a
MR
11542011-11-20 Martin Rudalics <rudalics@gmx.at>
1155
1156 * window.c (Fset_window_combination_limit): Rename argument
1157 STATUS to LIMIT.
1158 (Vwindow_combination_limit): Remove "status" from doc-string.
1159
d5ff9cd0
AS
11602011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1161
1162 * m/ibms390.h: Remove.
1163 * m/ibms390x.h: Don't include "ibms390.h".
1164
a5bb9bd3
SM
11652011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1166
1167 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1168 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1169
cd1181db
JB
11702011-11-20 Juanma Barranquero <lekktu@gmail.com>
1171
1172 * casetab.c (Fset_case_table):
1173 * charset.c (Fcharset_after): Fix typos.
1174
615a3b8d 11752011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1176
17e845af
PE
1177 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1178 Otherwise, valgrind does not work on some platforms.
1179 Problem reported by Andreas Schwab in
6a0bf43d
PE
1180 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1181 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1182 is set, removing the need for VIRT_ADDRESS_VARIES.
1183 (PURE_P): Use a more-efficient implementation that needs just one
1184 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1185 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1186 to 4 (xorl, subq, cmpq, setbe).
1187 * alloc.c (pure): Always extern now, since that's the
1188 VIRT_ADDR_VARIES behavior.
1189 (PURE_POINTER_P): Use a single comparison, not two, for
1190 consistency with the new puresize.h.
1191 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1192 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1193 Remove VIRT_ADDR_VARIES no longer needed.
1194
f8fe6f96
EZ
11952011-11-19 Eli Zaretskii <eliz@gnu.org>
1196
1197 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1198 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1199 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1200 behave as if the cursor position were at the window margin.
1201
1202 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1203 and the cursor position is out of bounds, behave as if the cursor
1204 position were at the window margin. (Bug#10075)
1205
df05a53c
CY
12062011-11-18 Chong Yidong <cyd@gnu.org>
1207
1208 * window.c (Fwindow_combination_limit): Make first argument
1209 non-optional, since it is meaningless for live windows like the
1210 selected window.
1211
2071918e
DA
12122011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1215
b50a28de
SM
12162011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1217
1218 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1219 (graft_intervals_into_buffer): Simplify.
1220
015137db
EZ
12212011-11-18 Eli Zaretskii <eliz@gnu.org>
1222
1223 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1224 hash values of the two rows.
1225 (copy_row_except_pointers): Preserve the used[] arrays and the
1226 hash values of the two rows. (Bug#10035)
68c95424 1227 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1228
1229 * xdisp.c (row_hash): New function, body extracted from
1230 compute_line_metrics.
1231 (compute_line_metrics): Call row_hash, instead of computing the
1232 hash code inline.
1233
1234 * dispnew.c (verify_row_hash): Call row_hash for computing the
1235 hash code of a row, instead of duplicating code from xdisp.c.
1236
1237 * dispextern.h (row_hash): Add prototype.
1238
a2addb04
TH
12392011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1240
1241 * frame.c (delete_frame): Don't delete the terminal when the last
1242 X frame is closed if emacs is built with GTK toolkit.
1243
df85d315
JB
12442011-11-17 Juanma Barranquero <lekktu@gmail.com>
1245
1246 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1247
a0c2d0ae
MR
12482011-11-17 Martin Rudalics <rudalics@gmx.at>
1249
1250 * window.c (Vwindow_splits): Rename to
1251 Vwindow_combination_resize. Suggested by Juri Linkov.
1252 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1253 of Vwindow_splits.
1254
58179cce
JB
12552011-11-16 Juanma Barranquero <lekktu@gmail.com>
1256
7877f373
JB
1257 * nsfns.m (Fns_font_name):
1258 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1259
b6f67890
MR
12602011-11-16 Martin Rudalics <rudalics@gmx.at>
1261
1262 * window.h (window): Rename slot "nest" to "combination_limit".
1263 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1264 (Fset_window_nest): Rename to Fset_window_combination_limit.
1265 (Vwindow_nest): Rename to Vwindow_combination_limit.
1266 (recombine_windows, make_parent_window, make_window)
1267 (Fsplit_window_internal, saved_window)
1268 (Fset_window_configuration, save_window_save): Rename all
1269 occurrences of window_nest to window_combination_limit.
1270
c7015153
JB
12712011-11-15 Juanma Barranquero <lekktu@gmail.com>
1272
1273 * image.c (imagemagick_load_image): Fix typo.
1274
322ad6ec
EZ
12752011-11-14 Eli Zaretskii <eliz@gnu.org>
1276
1277 * xdisp.c (display_line): Move the call to
1278 highlight_trailing_whitespace before the call to
1279 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1280 faces of all the glyphs to compute ROW's hash value.
1281 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1282
f067b8ec
JB
12832011-11-14 Juanma Barranquero <lekktu@gmail.com>
1284
1285 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1286 just return (bug#10044).
1287
1e5b2111
EZ
12882011-11-12 Eli Zaretskii <eliz@gnu.org>
1289
7ef3cbd5
EZ
1290 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1291 with user-defined heap size. Bump the default size of the temacs
1292 heap to 27MB, to avoid memory warning when running temacs.
1293 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1294
1e5b2111
EZ
1295 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1296 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1297 (verify_row_hash) [XASSERTS]: New function.
1298 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1299 that the hash value of glyph rows is correct.
1e5b2111 1300
89d61221
MR
13012011-11-12 Martin Rudalics <rudalics@gmx.at>
1302
1303 * window.h (window): Remove splits slot.
1304 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1305 (Fdelete_other_windows_internal, make_parent_window)
1306 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1307 (Fset_window_configuration, save_window_save): Don't deal with
1308 split status of windows.
1309 (saved_window): Remove splits slot.
1310 (Vwindow_splits): Rewrite doc-string.
1311
97f18cc8
JD
13122011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1313
1314 * xfns.c (unwind_create_frame):
1315 * nsfns.m (unwind_create_frame):
1316 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1317 Vframe_list (Bug#9999).
1318
22a648b4
DA
13192011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1320
0b381c7e 1321 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1322
659afede
KH
13232011-11-11 Kenichi Handa <handa@m17n.org>
1324
1325 * callproc.c (Fcall_process): Set the member dst_multibyte of
1326 process_coding.
1327
9ac0394b
KH
13282011-11-11 Johan Bockgård <bojohan@gnu.org>
1329
1330 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1331 avoid a crash (bug#9496).
1332
2fbdc249
CY
13332011-11-09 Chong Yidong <cyd@gnu.org>
1334
1335 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1336 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1337
ac6b1f81
PE
13382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1341
09db192c
PE
13422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 Avoid some portability problems by eschewing 'extern inline' functions.
1345 The trivial performance wins aren't worth the portability hassles; see
1346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1347 et seq.
1348 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1349 (window_box_width, window_box_left, window_box_left_offset)
1350 (window_box_right, window_box_right_offset): Undo previous change,
1351 by removing the "extern"s.
1352 * intervals.c (adjust_intervals_for_insertion)
1353 (adjust_intervals_for_deletion): Undo previous change,
1354 making these static again.
1355 (offset_intervals, temp_set_point_both, temp_set_point)
1356 (copy_intervals_to_string): No longer inline.
1357 * xdisp.c (window_text_bottom_y, window_box_width)
1358 (window_box_height, window_box_left_offset)
1359 (window_box_right_offset, window_box_left, window_box_right)
1360 (window_box): No longer inline.
1361
105216ed
CY
13622011-11-08 Chong Yidong <cyd@gnu.org>
1363
1364 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1365 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1366 Signal an error if not a live window.
105216ed
CY
1367 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1368 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1369
ae9e237f
JB
13702011-11-07 Juanma Barranquero <lekktu@gmail.com>
1371
1372 * lisp.h (syms_of_abbrev): Remove declaration.
1373 Reported by CHENG Gao <chenggao@royau.me>.
1374
c7aa8333
EZ
13752011-11-07 Eli Zaretskii <eliz@gnu.org>
1376
1377 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1378 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1379 of temacs in GUI mode.
1380
be7f5545
MR
13812011-11-07 Martin Rudalics <rudalics@gmx.at>
1382
1383 * window.h: Declare delete_all_child_windows instead of
1384 delete_all_subwindows.
1385 * window.c (Fwindow_nest, Fset_window_nest)
1386 (Fset_window_new_total, Fset_window_new_normal)
1387 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1388 (delete_all_subwindows): Rename to delete_all_child_windows.
1389 (Fdelete_other_windows_internal, Fset_window_configuration):
1390 Call delete_all_child_windows instead of delete_all_subwindows.
1391 * frame.c (delete_frame): Call delete_all_child_windows instead
1392 of delete_all_subwindows.
1393
ca78dc43
PE
13942011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1395
1396 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1397 This is also needed for porting to any host where GC_MARK_STACK is
1398 not GC_MAKE_GCPROS_NOOPS.
1399 (which_symbols): Use it.
1400
a0241d01
KH
14012011-11-07 Kenichi Handa <handa@m17n.org>
1402
1403 * coding.c (coding_set_destination): Check coding->src_pos only
1404 when coding->src_object is a buffer (bug#9910).
1405
1406 * process.c (send_process): Set the member src_multibyte of coding
1407 to 0 (bug#9911) when sending a unibyte text.
1408
1409 * callproc.c (Fcall_process): Set the member src_multibyte of
1410 process_coding to 0 (bug#9912).
1411
a64bfdfa 14122011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1413
1414 * xmenu.c (cleanup_widget_value_tree): New function.
1415 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1416 calling free_menubar_widget_value_tree directly (Bug#9830).
1417
cb41b32a
PE
14182011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 Fix some portability problems with 'inline'.
1421 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1422 (window_box_width, window_box_left, window_box_left_offset)
1423 (window_box_right, window_box_right_offset): Declare extern.
1424 Otherwise, these inline functions do not conform to C99 and
1425 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1426 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1427 * intervals.c (adjust_intervals_for_insertion)
1428 (adjust_intervals_for_deletion): Now extern, because otherwise the
1429 extern inline functions 'offset_intervals' couldn't refer to it.
1430 (static_offset_intervals): Remove.
1431 (offset_intervals): Rewrite using the old contents of
1432 static_offset_intervals. The old version didn't conform to C99
1433 because an extern inline function contained a reference to an
1434 identifier with static linkage.
1435
b7041366
AS
14362011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1437
1438 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1439 GC.
1440
88a37c4d
EZ
14412011-11-06 Eli Zaretskii <eliz@gnu.org>
1442
1443 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1444 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1445 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1446 return Qleft_to_right.
1447
49745b39
CY
14482011-11-06 Chong Yidong <cyd@gnu.org>
1449
1450 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1451 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1452 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1453 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1454 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1455 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1456 (Fwindow_vscroll): Doc fix.
1457 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1458 argument, since it makes no sense to pass a live window and for
1459 consistency with window-child.
1460
1f05cd82
CS
14612011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1462
1463 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1464 support MSVC.
1465
22610910
JR
14662011-11-05 Jason Rumney <jasonr@gnu.org>
1467
1468 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1469 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1470 fonts (Bug#6029).
1471 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1472 bitwise arithmetic preventing use of unicode-sip and non-truetype
1473 opentype fonts.
1474
a06776b2
EZ
14752011-11-05 Eli Zaretskii <eliz@gnu.org>
1476
3ad924ba
EZ
1477 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1478 "emacs"-only part.
1479
a06776b2
EZ
1480 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1481 initialization code to keep similarity to xfns.c after changes
1482 from 2011-11-05.
1483
c9e7db78
JD
14842011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1485
a97f8f3f
JD
1486 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1487 (unwind_create_frame): New function (Bug#9943).
1488 (Fx_create_frame): Restructure code to be more similar to the one in
1489 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1490 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1491 Move terminal->reference_count++ just before making the frame official
1492 (Bug#9943).
1493
1494 * nsterm.m (x_free_frame_resources): New function.
1495 (x_destroy_window): Move code to x_free_frame_resources.
1496
c9e7db78 1497 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1498 (Fx_create_frame, x_create_tip_frame):
1499 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1500 official. Move initialization of image_cache_refcount and
1501 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1502
a6fc3b5c
EZ
15032011-11-05 Eli Zaretskii <eliz@gnu.org>
1504
1505 Support MSVC build with newer versions of Visual Studio.
1506 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1507 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1508 nt/gmake.defs.
1509
1510 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1511 which are not supported by MSVC.
1512 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1513 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1514 bitfields.
1515 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1516 types in bitfields.
1517 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1518
1519 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1520
58179cce 15212011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1522
1523 Support MSVC build with newer versions of Visual Studio.
1524 * w32.c: Don't include w32api.h for MSVC.
1525 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1526
1527 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1528 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1529 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1530 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1531 e_* cousins.
1532 (alloca) [_MSC_VER]: Define to _alloca.
1533
1534 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1535
1536 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1537
a58c13ed
EZ
15382011-11-04 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (note_mouse_highlight): If either of
1541 previous/next-single-property-change returns nil, treat that as
1542 the beginning or the end of the buffer. (Bug#9955)
1543
fe0b6370
JD
15442011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1545
a58c13ed 1546 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1547 label is not null (Bug#9951).
1548 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1549 may be NULL.
1550
89bd5ee1
EZ
15512011-11-04 Eli Zaretskii <eliz@gnu.org>
1552
1553 * window.c (Fwindow_body_size): Mention in the doc string that the
1554 return value is in frame's canonical units. (Bug#9949)
1555
84c3edb9
EZ
15562011-11-03 Eli Zaretskii <eliz@gnu.org>
1557
4e2fb5c7
EZ
1558 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1559
84c3edb9 1560 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1561 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1562 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1563
bc17a887
EZ
15642011-11-01 Eli Zaretskii <eliz@gnu.org>
1565
1566 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1567 Don't stop backward scan on the continuation glyph, even though
1568 its CHARPOS is positive.
6d5eb5b0
SM
1569 (mouse_face_from_buffer_pos, note_mouse_highlight):
1570 Rename cover_string to disp_string.
bc17a887 1571
4ee88440
MR
15722011-11-01 Martin Rudalics <rudalics@gmx.at>
1573
1574 * window.c (temp_output_buffer_show): Don't use
1575 Vtemp_buffer_show_specifiers.
1576 (Vtemp_buffer_show_specifiers): Remove unused variable.
1577
c2ff3c02
EZ
15782011-10-30 Eli Zaretskii <eliz@gnu.org>
1579
1580 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1581 past the beginning of the current glyph matrix.
1582
58179cce 15832011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1584
1585 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1586 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1587 HAVE_GTK3 (Bug#9869).
b77a6a7f 1588
3b574623
JD
1589 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1590 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1591
b77a6a7f
JD
1592 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1593
1594 * xterm.c: Declare x_handle_net_wm_state to return int.
1595 (handle_one_xevent): Check if we are iconified but don't have
1596 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1597 (get_current_wm_state): Return non-zero if not hidden,
1598 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1599 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1600 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1601 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1602
196e41e4
PE
16032011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1604
1605 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1606 so that this new function doesn't get optimized away by a
1607 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1608
021f2e1a
AS
16092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1610
1611 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1612
8b058d44
EZ
16132011-10-29 Eli Zaretskii <eliz@gnu.org>
1614
1615 Fix the `xbytecode' command.
1616 * .gdbinit (xprintbytestr): New command.
b50a28de 1617 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1618 (xbytecode): Print the byte-code string as well.
1619
4452fb80
EZ
16202011-10-29 Kim Storm <storm@cua.dk>
1621
8b058d44
EZ
1622 * alloc.c (which_symbols): New function.
1623
21b72067
AS
16242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1625
1626 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1627 line. (Bug#9903)
1628
83ed7b5c
GM
16292011-10-29 Glenn Morris <rgm@gnu.org>
1630
1631 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1632 Not clear what it was for, and it causes various bugs. (Bug#9839)
1633
5a7a728b
EZ
16342011-10-28 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1637 possible random value that matches one of those tested as
1638 condition to clear the mouse face.
1639
d3d0842f
CY
16402011-10-28 Chong Yidong <cyd@gnu.org>
1641
1642 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1643
31b39d13
DN
16442011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1645
1646 * window.c (make_window): Initialize phys_cursor_on_p.
1647
9aba6043
SM
16482011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1649
1650 * lisp.h (struct Lisp_Symbol): Update comments.
1651
c20992f4
JB
16522011-10-28 Juanma Barranquero <lekktu@gmail.com>
1653
1654 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1655
db4f02f2
EZ
16562011-10-28 Eli Zaretskii <eliz@gnu.org>
1657
1658 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1659 <oslsachem@gmail.com> for helping to debug this.
1660
1661 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1662 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1663 (g_b_init_get_glyph_outline_w): New static variables.
1664 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1665 (GetGlyphOutlineW_Proc): New typedefs.
1666 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1667 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1668 New functions.
1669 (w32font_open_internal, compute_metrics):
1670 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1671 instead of calling the "wide" APIs directly.
1672
1673 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1674
1675 * w32.h (syms_of_w32font): Add prototype.
1676
87e68db4
JB
16772011-10-27 Juanma Barranquero <lekktu@gmail.com>
1678
1679 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1680 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1681 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1682 (Fmove_to_window_line): Doc fix.
1683
435c1d67
CY
16842011-10-27 Chong Yidong <cyd@gnu.org>
1685
1686 * process.c (make_process): Set gnutls_state to NULL.
1687
1688 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1689 non-NULL, regardless of GNUTLS_INITSTAGE.
1690 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1691 an error. Set process slots as soon as we allocate them.
1692
1693 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1694
9c6c6f49
CY
16952011-10-27 Chong Yidong <cyd@gnu.org>
1696
9aba6043
SM
1697 * gnutls.c (emacs_gnutls_deinit): New function.
1698 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1699 (Fgnutls_deinit, Fgnutls_boot): Use it.
1700
1701 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1702 (deactivate_process): Call emacs_gnutls_deinit.
1703
657d08d3
JB
17042011-10-27 Juanma Barranquero <lekktu@gmail.com>
1705
1706 * image.c (x_create_x_image_and_pixmap):
1707 * w32.c (sys_rename, w32_delayed_load):
1708 * w32font.c (fill_in_logfont):
1709 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1710
5430d399
JB
17112011-10-26 Juanma Barranquero <lekktu@gmail.com>
1712
1713 * w32fns.c (w32_default_color_map): New function,
1714 extracted from Fw32_default_color_map.
a7ef684b 1715 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1716
fe0055fa
PE
17172011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1718
1719 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1720
e6346438
SM
17212011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1722
1723 * keyboard.c (test_undefined): New function (bug#9751).
1724 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1725
e112cc37
ET
17262011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1727
1728 * sysdep.c (init_sys_modes): Fix the check for the controlling
1729 terminal (Bug#6649).
1730
7b5d6677
EZ
17312011-10-20 Eli Zaretskii <eliz@gnu.org>
1732
1733 * dispextern.h (struct bidi_it): New member next_en_type.
1734
1735 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1736 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1737 current character, check also for next_en_type being WEAK_EN.
1738 (bidi_resolve_weak): Don't enter the expensive loop if the current
1739 position is before next_en_pos. Record the bidi type of the first
1740 non-ET, non-BN character we find, in addition to its position.
1741 (bidi_level_of_next_char): Invalidate next_en_type when
1742 next_en_pos is over-stepped.
1743
7da0b018
PE
17442011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1747 * editfns.c: Rewrite current-time-zone so that it invokes
1748 the equivalent of (format-time-string "%Z") to get the time zone name.
1749 This fixes a bug when the time zone name contains characters that
1750 need converting from the system time locale to Emacs internal format.
1751 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1752 that patch fixed format-time-string to do the conversion, but
1753 I forgot to fix current-time-zone.
1754 (format_time_string): New function, containing most of
1755 what Fformat_time_string used to contain.
1756 (Fformat_time_string): Rewrite in terms of format_time_string.
1757 This doesn't change this function's behavior.
1758 (current-time-zone): Rewrite to use format_time_string.
1759 This fixes the bug reported by Michael Schierl in
1760 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1761 Jason Rumney's 2007-06-07 change worked around this bug, but
1762 didn't fix it.
1763 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1764
8547b010
EZ
17652011-10-19 Eli Zaretskii <eliz@gnu.org>
1766
1767 * xdisp.c (start_display): If the character at POS is displayed
1768 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1769 (try_window_reusing_current_matrix): If a line ends in a display
1770 vector or the next line starts in a display vector, continue
1771 redrawing the window even though the character position of
1772 start_row was reached.
8547b010
EZ
1773 (Bug#9771, part 2)
1774
4e948d15
CY
17752011-10-18 Chong Yidong <cyd@gnu.org>
1776
1777 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1778 with nobreak-char-display too.
1779
4787455f
EZ
17802011-10-18 Eli Zaretskii <eliz@gnu.org>
1781
1782 Fix part 3 of bug#9771.
1783 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1784 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1785 non-neutral characters if the current character is a paragraph
1786 separator (a.k.a. Newline). This avoids running the same
1787 expensive loop twice, once when we consume the preceding newline
1788 and the other time when the line actually needs to be displayed.
1789 Avoid the loop when we see neutrals on the base embedding level
1790 following a character whose directionality is the same as the
1791 paragraph's. This avoids running the expensive loop when a line
1792 ends in a long sequence of neutrals, like control characters.
1793 Add assertion against STRONG_AL type. Slightly rearrange code
1794 that determines the type of a neutral given the first non-neutral
1795 that follows it.
1796 (bidi_level_of_next_char): Set next_en_pos to zero when
1797 invalidating its info.
1798
2c91f553
EZ
17992011-10-17 Eli Zaretskii <eliz@gnu.org>
1800
1801 * xdisp.c (push_display_prop): Determine whether to record string
1802 or buffer position by IT->string, not by IT->method. Allow
1803 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1804 (move_it_vertically_backward): Don't look for character position
1805 immediately after the newline when in a continuation line.
1806 (Bug#9771, part 1)
2c91f553 1807
c7b08b0d
MR
18082011-10-15 Martin Rudalics <rudalics@gmx.at>
1809
1810 * window.c (coordinates_in_window): Rewrite and delabelize
1811 vertical border check. (Bug#5357) (Bug#9618)
1812
6b02f655
SM
18132011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1814
1815 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1816 errors in XSetWindowBorder (bug#9310).
1817
81d40c92
DA
18182011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1819
1820 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1821 avoid crash when xmalloc overrun checking is enabled.
1822
d4172c3b
EZ
18232011-10-13 Eli Zaretskii <eliz@gnu.org>
1824
1825 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1826 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1827 cursor motion with <left> and <right> arrow keys.
1828
1829 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1830 some callers set that themselves.
1831
b00eea75
EZ
18322011-10-12 Eli Zaretskii <eliz@gnu.org>
1833
1834 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1835 display string and the previous row comes from the same string and
1836 is empty. (Bug#9739) (Bug#9738)
1837
8fe012c4
SM
18382011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1839
1840 * doc.c (get_doc_string): Encode file name (bug#9735).
1841
0074aef2
EZ
18422011-10-12 Eli Zaretskii <eliz@gnu.org>
1843
79beb178
EZ
1844 * bidi.c (bidi_level_of_next_char):
1845 * xdisp.c (get_visually_first_element): Remove old incorrect
1846 comments regarding the Unicode Line Separator character.
1847
0074aef2
EZ
1848 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1849
6e4b3fbe
DA
18502011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1851
1852 * alloc.c (Fgc_status): Do not access beyond zombies array
1853 boundary if nzombies > MAX_ZOMBIES.
1854 * alloc.c (dump_zombies): Add missing format specifier.
1855
0324f3af
PE
18562011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1857
b5525cac
PE
1858 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1859 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1860
0324f3af
PE
1861 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1862 Some packages use them to denote characters with modifiers.
1863
e9b5f888
AS
18642011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1865
1866 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1867 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1868 matching a pp-number. Rename parameter var to var1.
1869
127827c0
SM
18702011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1871
1872 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1873
c8fd3bd0
GM
18742011-10-08 Glenn Morris <rgm@gnu.org>
1875
1876 * callint.c (Fcall_interactively): Give a more explicit error for the
1877 'c' case with a non-character input. (Bug#8479)
1878
352ec8ff
EZ
18792011-10-08 Eli Zaretskii <eliz@gnu.org>
1880
03669ccb
EZ
1881 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1882 lines.
7061c986
EZ
1883 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1884 lines that are hscrolled on the left.
03669ccb 1885
352ec8ff
EZ
1886 * dispnew.c (buffer_posn_from_coords): Account for a possible
1887 presence of header-line. (Bug#4426)
1888
a66cfb1c
SM
18892011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1890
6b02f655
SM
1891 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1892 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1893
7c5ee88e
PE
18942011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1895
1896 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1897 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1898 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1899 this makes Emacs dump core during garbage collection on rare
1900 occasions. sizeof is obviously inferior to offsetof here, so
1901 stick with offsetof.
1902 (GC_POINTER_ALIGNMENT): New macro.
1903 (mark_memory): Omit 3rd (offset) arg; caller changed.
1904 Don't assume EMACS_INT alignment is the same as pointer alignment.
1905
df1bbe5b
SM
19062011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1907
1908 * keyboard.c (read_key_sequence_remapped): New var.
1909 (read_key_sequence): Compute remapping in the right buffer.
1910 (command_loop_1): Use read_key_sequence's remapping directly.
1911
51553db6
SM
19122011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1913
32c1fffd
SM
1914 * dired.c (file_name_completion): Don't expand file name.
1915 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1916 before checking file name handler.
1917
51553db6
SM
1918 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1919 they've been requested explicitly (bug#9591).
1920
b6bd1599 19212011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1922
1923 * keymap.c (Fsingle_key_description): Use make_specified_string
1924 instead of build_string to build string from push_key_description.
1925 (Bug#5193)
1926
f701dc2a
PE
19272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1928
4222c55d
PE
1929 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1930 This fixes a Y2038 bug on 64-bit hosts.
1931 * buffer.c (reset_buffer):
1932 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1933 (Fclear_buffer_auto_save_failure):
1934 Use 0, not -1, to represent an unset failure time, since time_t
1935 might not be signed.
1936
f701dc2a
PE
1937 Remove dependency on glibc malloc internals.
1938 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1939 Move back here from lisp.h, but with their new implementations.
1940 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1941 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1942 * charset.c (charset_table_init): New static var.
1943 (syms_of_charset): Use it instead of xmalloc. This removes a
1944 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1945 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1946 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1947 Move back to alloc.c.
1948 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1949 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1950
9ceebf39
JD
19512011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1952
1953 * nsterm.m (windowDidResize): Call x_set_window_size only when
1954 ns_in_resize is true. Otherwise set pixelwidth/height and
1955 call change_frame_size (Bug#9628).
1956
cb993c58
PE
19572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1958
3930c88b
PE
1959 Port --enable-checking=all to Fedora 14 x86-64.
1960 * charset.c (syms_of_charset): Also account for glibc malloc's
1961 internal overhead when calculating the initial malloc maximum.
1962
cb993c58
PE
1963 Port --enable-checking=all to Fedora 14 x86.
1964 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1965 Move to lisp.h.
1966 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1967 (overrun_check_realloc, overrun_check_free):
1968 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1969 That way, xmalloc returns a properly-aligned pointer even if
1970 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1971 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1972 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1973 into account when calculating the initial malloc maximum.
1974 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1975 Move here from alloc.c, so that charset.c can use it too.
1976 Properly align; the old code wasn't right for common 32-bit hosts
1977 when configured with --enable-checking=all.
1978 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1979 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1980
31bed486
EZ
19812011-09-29 Eli Zaretskii <eliz@gnu.org>
1982
04c70788 1983 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1984 use EDOM.
1985
fbcaa2f3
EZ
19862011-09-28 Eli Zaretskii <eliz@gnu.org>
1987
1988 * xdisp.c (compute_display_string_end): If there's no display
1989 string at CHARPOS, return -1.
1990
1991 * bidi.c (bidi_fetch_char): When compute_display_string_end
1992 returns a negative value, treat the character as a normal
1993 character not covered by a display string. (Bug#9624)
1994
a239d4e9
JB
19952011-09-28 Juanma Barranquero <lekktu@gmail.com>
1996
1997 * lread.c (Fread_from_string): Fix typo in docstring.
1998
88652fd5
EZ
19992011-09-27 Eli Zaretskii <eliz@gnu.org>
2000
2001 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2002 newline, reseat the iterator instead of bidi-iterating there one
2003 character at a time. (Bug#9610)
32c1fffd
SM
2004 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2005 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2006
ed497dd4
AS
20072011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2008
2009 * lread.c (readevalloop): Use correct code for NBSP.
2010 (read1): Likewise. (Bug#9608)
2011
b2bf61aa
MA
20122011-09-25 Michael Albinus <michael.albinus@gmx.de>
2013
2014 * dbusbind.c (Fdbus_register_signal): When service is not
2015 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2016
32bbb17c
GM
20172011-09-25 Glenn Morris <rgm@gnu.org>
2018
2019 * buffer.c (truncate-lines): Doc fix.
2020
94e0933e
CY
20212011-09-24 Chong Yidong <cyd@stupidchicken.com>
2022
2023 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2024 (Fset_window_next_buffers): Doc fix.
2025
cddde921
GM
20262011-09-24 Glenn Morris <rgm@gnu.org>
2027
2028 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2029
1260aef1
PE
20302011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2031
25b4bfa0
PE
2032 Fix minor problems found by static checking.
2033 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2034 * indent.c (Fvertical_motion): Fix == vs = typo.
2035
e3cbd34b
EZ
20362011-09-24 Eli Zaretskii <eliz@gnu.org>
2037
a66cfb1c
SM
2038 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2039 Default value is now t. Doc fix.
6bf7006f 2040
e3cbd34b 2041 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2042 logic when moving up, not only when moving down. Fix the
e3cbd34b 2043 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2044 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2045
2046 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2047 CHARPOS is covered by a display string which includes newlines.
2048 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2049 is covered by a display string with embedded newlines.
2050
a3de0cbd
MA
20512011-09-24 Michael Albinus <michael.albinus@gmx.de>
2052
2053 * dbusbind.c (Fdbus_register_signal): Add match rule to
2054 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2055 (Fdbus_register_method, Vdbus_registered_objects_table):
2056 Fix docstring.
a3de0cbd 2057
b260039d
JM
20582011-09-24 Jim Meyering <meyering@redhat.com>
2059
32c1fffd 2060 do not ignore write error for any output size
b260039d
JM
2061 The previous change was incomplete.
2062 While it makes emacs --batch detect the vast majority of stdout
2063 write failures, errors were still ignored whenever the output size is
2064 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2065 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2066 && echo FAIL: ignored write error
2067 FAIL: ignored write error
2068 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2069 && echo FAIL: ignored write error
2070 FAIL: ignored write error
2071 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2072
8eca8a7c
AS
20732011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2074
2075 * emacs.c (Fkill_emacs): In noninteractive mode exit
2076 non-successfully if a write error occurred on stdout. (Bug#9574)
2077
3341db62
EZ
20782011-09-21 Eli Zaretskii <eliz@gnu.org>
2079
2080 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2081 the xassert test.
2082
2083 * dispextern.h (struct it): Update the comment documenting what
2084 can it->OBJECT be.
2085
8c203dbf
EZ
20862011-09-20 Eli Zaretskii <eliz@gnu.org>
2087
2088 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2089 a display string, extend search for cursor position to end of row.
2090 (find_row_edges): If the row ends in a newline from a display
2091 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2092 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2093 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2094 non-empty line. Fixes confusing cursor motion with arrow keys at
2095 the beginning of a line that starts with whitespace.
8c203dbf 2096
a4824228
LMI
20972011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2098
2099 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2100 (bug#9493).
2101
33ed493b
CY
21022011-09-18 Chong Yidong <cyd@stupidchicken.com>
2103
2104 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2105 boolean (Bug#9154).
2106
56cd55c8
EZ
21072011-09-18 Eli Zaretskii <eliz@gnu.org>
2108
2109 * xdisp.c (display_line): Record maximum and minimum buffer
2110 positions even if no glyphs were produced (e.g., by a zero-width
2111 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2112 buffer positions that will be removed from the glyph row because
2113 they don't fit.
c02dcedf
EZ
2114 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2115 column is beyond frame width: don't subtract 1 "pixel" when
2116 computing width of the stretch.
3e62b7e0
EZ
2117 (reseat_at_next_visible_line_start): Undo the change made on
2118 2011-09-17 that saved paragraph information and restored it after
2119 the call to `reseat'. (Bug#9545)
56cd55c8 2120
5ed99d36 21212011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2122
2123 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2124 and turn window cursor on if cleared (Bug#9415).
2125
5ed99d36 21262011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2127
2128 * search.c (boyer_moore): Take unibyte characters from pattern
2129 literally. (Bug#9458)
2130
9bade7b2
EZ
21312011-09-18 Eli Zaretskii <eliz@gnu.org>
2132
2133 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2134
e5e9d610
PE
21352011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2136
87e4427a
PE
2137 Fix minor problem found by static checking.
2138 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2139 initialized, to pacify gcc -Wuninitialized.
2140
e5e9d610
PE
2141 * fileio.c: Report proper errno when syscall falls.
2142 (Finsert_file_contents): Save and restore errno,
2143 so that report_file_error outputs the correct diagnostic.
2144 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2145
a1674f0b
EZ
21462011-09-18 Eli Zaretskii <eliz@gnu.org>
2147
2148 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2149
fbfb6dd4
EZ
21502011-09-17 Eli Zaretskii <eliz@gnu.org>
2151
2152 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2153 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2154
bb187662
EZ
21552011-09-17 Eli Zaretskii <eliz@gnu.org>
2156
1137e8b8 2157 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2158 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2159
2160 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2161 (bidi_find_paragraph_start): Search back for paragraph beginning
2162 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2163 (bidi_move_to_visually_next): Only trigger paragraph-related
2164 computations when the last character is a newline or at EOB, not
2165 just any NEUTRAL_B. (Bug#9470)
2166
bb187662
EZ
2167 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2168 truncated lines if point is covered by a display string. (Bug#9524)
2169
2e621251
PE
21702011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2171
2172 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2173 (cons_to_x_long): New function.
2174 (lisp_data_to_selection_data): Use it. Correct the test for
2175 short-versus-long data; it was negated. Break out of vector
2176 loop, for efficiency, when a long datum is discovered.
2177
91a15bc6
SM
21782011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2179
2180 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2181
b41c3a35
EZ
21822011-09-16 Eli Zaretskii <eliz@gnu.org>
2183
2184 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2185 GCC PR/17406) by declaring this function with external scope.
2186
7812ba2d
PE
21872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2190 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2191
cf7edc2a
AS
21922011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2193
2194 * editfns.c (Fformat): Correctly handle text properties on "%%".
2195
bd01620e
EZ
21962011-09-15 Eli Zaretskii <eliz@gnu.org>
2197
2198 * xterm.c (x_draw_composite_glyph_string_foreground):
2199 * w32term.c (x_draw_composite_glyph_string_foreground):
2200 * term.c (encode_terminal_code):
2201 * composite.c (composition_update_it, get_composition_id):
2202 * xdisp.c (get_next_display_element)
2203 (fill_composite_glyph_string): Add comments about special meaning
2204 of TAB characters in a composition.
2205
a02719a3
PE
22062011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2207
2208 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2209 This occurs when processing a multibyte format.
2210 Problem reported by Wolfgang Jenker.
a02719a3 2211
72589a3c
JB
22122011-09-15 Johan Bockgård <bojohan@gnu.org>
2213
2214 * xdisp.c (try_cursor_movement): Only check for exact match if
2215 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2216
1c14176c
PE
22172011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 Remove unused external symbols.
2220 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2221 * xdisp.c (calc_pixel_width_or_height): Now static.
2222 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2223 * indent.c (check_display_width):
2224 * w32term.c: Fix comment to match code.
2225 * xterm.c, xterm.h (x_catching_errors): Remove.
2226
d2eea5b5
PE
22272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2228
2229 * xselect.c: Use signed conversions more consistently (Bug#9498).
2230 (selection_data_to_lisp_data): Assume incoming selection data are
2231 signed integers, not unsigned. This is to be consistent with
2232 outgoing selection data, which was modified to use signed integers
2233 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2234 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2235 expects long, not unsigned long.
2236
46888499
EZ
22372011-09-14 Eli Zaretskii <eliz@gnu.org>
2238
2239 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2240 computation of loop end. Reported by Johan Bockgård
2241 <bojohan@gnu.org>.
2242
ef8ef9fb
CY
22432011-09-13 Chong Yidong <cyd@stupidchicken.com>
2244
2245 * frame.c (Fother_visible_frames_p): Function deleted.
2246
fa819fed
EZ
22472011-09-12 Eli Zaretskii <eliz@gnu.org>
2248
2249 * indent.c (compute_motion): Process display vector front to back
2250 rather than the other way around. (Bug#2496)
2251
2ba8e008
SM
22522011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2253
2254 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2255
20f53c69
CY
22562011-09-11 Chong Yidong <cyd@stupidchicken.com>
2257
2258 * minibuf.c (Fread_from_minibuffer): Doc fix.
2259
d562d7a4
EZ
22602011-09-11 Eli Zaretskii <eliz@gnu.org>
2261
2262 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2263 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2264
1c4d7f3d
LMI
22652011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2266
2267 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2268 value for non-existent files.
2269
b885bf36
EZ
22702011-09-11 Eli Zaretskii <eliz@gnu.org>
2271
2272 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2273 set its "size" to -1. This will set the modtime_size field of
2274 the corresponding buffer to -1, which is what
2275 verify-visited-file-modtime expects for files that do not exist.
2276 (Bug#9139)
2277
6612f0bf
PE
22782011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2281 here ...
2282 * lisp.h: ... from here. push_key_description is no longer
2283 defined in keyboard.c, so its declaration should not be in
2284 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2285 logically belongs with push_key_description.
2286
dfb3f755
PE
22872011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 * buffer.h: Include <sys/types.h> instead of <time.h>.
2290 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2291 Problem reported by Herbert J. Skuhra.
2292
3134906c
LMI
22932011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2294
2295 * xml.c (parse_region): Make the parsing work for
2296 non-comment-starting XML files again (bug#9144).
2297
8d903f4e
AS
22982011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2299
2300 * image.c (gif_load): Fix calculation of bottom and right corner.
2301 (Bug#9468)
2302
80ad64f4
EZ
23032011-09-10 Eli Zaretskii <eliz@gnu.org>
2304
2305 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2306 redisplay in small windows.
2307
208a048d
EZ
23082011-09-09 Eli Zaretskii <eliz@gnu.org>
2309
2310 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2311
9b1c252e
MR
23122011-09-08 Martin Rudalics <rudalics@gmx.at>
2313
2314 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2315 Operate on live windows only.
2316
2949f33b
JB
23172011-09-08 Juanma Barranquero <lekktu@gmail.com>
2318
2319 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2320
e08dcafd
EZ
23212011-09-07 Eli Zaretskii <eliz@gnu.org>
2322
2323 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2324 only under bidi iteration.
2325
115b96bd
JD
23262011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2327
2328 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2329
c8199d0f
PE
23302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2331
2332 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2333 Without this fix, the command to link temacs failed due to an
2334 undefined symbol __builtin_isnan. This is because
2335 /usr/include/iso/math_c99.h #defines isnan(x) to
2336 __builtin_isnan(x), but the bundled gcc, which identifies itself
2337 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2338 a __builtin_isnan.
2339 * floatfns.c (isnan): #undef, and then #define to a clone of
2340 what's in data.c.
2341 (Fisnan): Always define, since it's always available now.
2342 (syms_of_floatfns): Always define isnan at the Lisp level.
2343
e39b275c 23442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2345
2346 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2347
b2db44d9 23482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2349
f4af5137 2350 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2351 The previous code assumed that file offsets (off_t values) fit in
2352 EMACS_INT variables, which is not true on typical 32-bit hosts.
2353 The code messed up by falsely reporting buffer overflow in cases
2354 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2355 when "big" contains more than 2**29 bytes, even though this
2356 inserts just one byte and does not overflow the buffer.
2357 (Finsert_file_contents): Store file offsets as off_t
2358 values, not as EMACS_INT values. Check for overflow when
2359 converting between EMACS_INT and off_t. When checking for
2360 buffer overflow or for overlap, take the offsets into account.
2361 Don't use EMACS_INT for small values where int suffices.
2362 When checking for overlap, fix a typo: ZV was used where
2363 ZV_BYTE was intended.
2364 (Fwrite_region): Don't assume off_t fits into 'long'.
2365 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2366
ecfc0a49
MA
23672011-09-05 Michael Albinus <michael.albinus@gmx.de>
2368
2369 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2370
6511acf2 23712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2372
0999621a 2373 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2374
2375 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2376 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2377 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2378 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2379 (modify_event_symbol): Do not assume that the length of
2380 name_alist_or_stem is safe to alloca and fits in int.
2381 (Fexecute_extended_command): Likewise for function name and binding.
2382 (Frecursion_depth): Wrap around reliably on integer overflow.
2383 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2384 since some callers pass EMACS_INT values.
2385 (Fsingle_key_description): Don't crash if symbol name contains more
2386 than MAX_ALLOCA bytes.
2387 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2388 (get_minibuffer): Arg is now EMACS_INT, not int.
2389 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2390 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2391 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2392
2be7d702
PE
2393 * dbusbind.c (signature_cat): New function.
2394 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2395 Do not overrun buffer; instead, report string overflow.
2396
9d1df220
PE
2397 * dispnew.c (add_window_display_history): Don't overrun buffer.
2398 Truncate instead; this is OK since it's just a log.
2399
33ef5c64
PE
2400 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2401 even if the time zone offset is outlandishly large.
2402 Don't mishandle offset == INT_MIN.
2403
66c6fdd5
PE
2404 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2405 when creating daemon; the previous buffer-overflow check was incorrect.
2406
d749b01b
PE
2407 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2408 which has the guts of the old verror function.
2409
b5cd1905
PE
2410 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2411 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2412
6e1a67fb
PE
2413 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2414 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2415 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2416 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2417 length of string rather than counting it via multiple sprintfs;
2418 that's simpler and more reliable.
c21721cc
PE
2419 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2420 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2421 sprintf, in case result does not fit in int.
2422
c57b67fc
PE
2423 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2424 (fontset_from_font): Print it.
2425
8a401434
PE
2426 * frame.c (tty_frame_count): Now printmax_t, not int.
2427 (make_terminal_frame, set_term_frame_name): Print it.
2428 (x_report_frame_params): In X, window IDs are unsigned long,
2429 not signed long, so print them as unsigned.
2430 (validate_x_resource_name): Check for implausibly long names,
2431 and don't assume name length fits in 'int'.
2432 (x_get_resource_string): Don't blindly alloca invocation name;
2433 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2434 not fit in int.
2435
6e1a67fb
PE
2436 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2437 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2438 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2439
0df02bf3
PE
2440 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2441 Use esprintf, not sprintf, in case result does not fit in int.
2442
48e30793
PE
2443 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2444 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2445 it as a large positive number.
2446 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2447 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2448
a66ff6d8
PE
2449 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2450 in case result does not fit in int.
2451
aca216ff
PE
2452 * print.c (float_to_string): Detect width overflow more reliably.
2453 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2454 buffer overrun. Don't assume list length fits in 'int'. Treat
2455 print length of 0 as 0, not as infinity; to be consistent with other
2456 uses of print length in this function. Don't overflow print length
2457 index. Don't assume hash table size fits in 'long', or that
2458 vectorlike size fits in 'unsigned long'.
2459
31c286f7
PE
2460 * process.c (make_process): Use printmax_t, not int, to format
2461 process-name gensyms.
2462
55e5faa1
PE
2463 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2464
80f2e268
PE
2465 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2466 to avoid potential buffer overrun.
2467
670741ab
PE
2468 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2469 if X resource line is longer than 512 bytes.
2470
b7163a50
PE
2471 * xfns.c (x_window): Make sprintf buffer a bit bigger
2472 to avoid potential buffer overrun.
2473
ae58ff1f
PE
2474 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2475
c43c8a6a
PE
2476 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2477
3f8236f4
PE
24782011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2479
53e9fe90 2480 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2481 Without these, Emacs silently mishandles large integers sometimes.
2482 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2483 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2484
6511acf2
PE
2485 * xdisp.c (try_window_id): Check Emacs fixnum range before
2486 converting to 'int'.
806add1d 2487
6511acf2 2488 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2489 Check that an Emacs fixnum is in range before assigning it to 'int'.
2490 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2491 values converted from Emacs fixnums.
2492 (Frecenter): Don't wrap around a line count if it is out of 'int'
2493 range; instead, treat it as an extreme value.
2494 (Fset_window_configuration, compare_window_configurations):
2495 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2496
6511acf2
PE
2497 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2498 that can exceed INT_MAX. Check that EMACS_INT value is in range
2499 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2500 (match_limit): Don't assume that a fixnum can fit in 'int'.
2501
6511acf2 2502 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2503 exceed INT_MAX.
2504
6511acf2 2505 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2506 (Fvertical_motion): Don't wrap around LINES values that don't fit
2507 in 'int'. Instead, treat them as extreme values. This is good
2508 enough for windows, which can't have more than INT_MAX lines anyway.
2509
fcb901a7
LMI
25102011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2511
0f2f6b6d
LMI
2512 * Require libxml/parser.h to avoid compilation warning.
2513
fcb901a7
LMI
2514 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2515
2516 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2517 since this reportedly can destroy thread storage.
2518
6e20a0d4
CY
25192011-08-30 Chong Yidong <cyd@stupidchicken.com>
2520
2521 * syntax.c (find_defun_start): Update all cache variables if
2522 exiting early (Bug#9401).
2523
148ae00e
EZ
25242011-08-30 Eli Zaretskii <eliz@gnu.org>
2525
f6cfbd8f
EZ
2526 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2527
148ae00e
EZ
2528 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2529 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2530 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2531
2532 * term.c (tty_append_glyph): New function.
2533 (produce_stretch_glyph): Static function and its prototype deleted.
2534
a66cfb1c
SM
2535 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2536 Add prototypes.
148ae00e 2537
c4a07a4c
PE
25382011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2539
2540 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2541 when checking :margin (Bug#9390).
2542 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2543 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2544 so that the name doesn't mislead. All uses changed.
2545
6bc8cd65
JB
25462011-08-28 Johan Bockgård <bojohan@gnu.org>
2547
2548 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2549 set_tty_hooks.
2550
dca4927e
EZ
25512011-08-27 Eli Zaretskii <eliz@gnu.org>
2552
2553 * xdisp.c (move_it_to): Don't bail out early when reaching
2554 position beyond to_charpos, if we are scanning backwards.
2555 (move_it_vertically_backward): When DY == 0, make sure we get to
2556 the first character in the line after the newline.
2557
f2cad773
PE
25582011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2559
2560 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2561 (ccl_driver): Do not generate an out-of-range pointer.
2562 (Fccl_execute_on_string): Remove unnecessary check for
2563 integer overflow, noted by Stefan Monnier in
2564 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2565 Remove a FIXME that didn't need fixing.
2566 Simplify the newly-introduced buffer reallocation code.
2567
0cae2cdb
JB
25682011-08-27 Juanma Barranquero <lekktu@gmail.com>
2569
2570 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2571
5fc295a4 25722011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2573
70c60eb2 2574 Integer and memory overflow issues (Bug#9196).
726e0ab1 2575
d31850da
PE
2576 * doc.c (get_doc_string): Rework so that
2577 get_doc_string_buffer_size is the actual buffer size, rather than
2578 being 1 less than the actual buffer size; this makes xpalloc more
2579 convenient.
2580
a69fbedb
PE
2581 * image.c (x_allocate_bitmap_record, cache_image):
2582 * xselect.c (Fx_register_dnd_atom):
2583 Simplify previous changes by using xpalloc.
2584
fe5c5d37
PE
2585 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2586 since either will do and ptrdiff_t is convenient with xpalloc.
2587
0065d054
PE
2588 * charset.c (charset_table_size)
2589 (struct charset_sort_data.priority): Now ptrdiff_t.
2590 (charset_compare): Don't overflow if priorities differ greatly.
2591 (Fsort_charsets): Don't assume list length fits in int.
2592 Check for size-calculation overflow when allocating sort data.
2593 (syms_of_charset): Allocate an initial charset table that is
2594 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2595
2596 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2597
2598 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2599 The actual value is always <= INT_MAX, and leaving it unsigned made
2600 overflow checking harder.
2601
2602 * dispextern.h (struct glyph_matrix.rows_allocated)
2603 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2604 with xpalloc. The values are still always <= INT_MAX.
2605
2606 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2607
2608 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2609 (SAFE_NALLOCA): New macro.
2610
2611 * region-cache.c (struct boundary.pos, find_cache_boundary)
2612 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2613 (set_cache_region, invalidate_region_cache)
2614 (revalidate_region_cache, know_region_cache, region_cache_forward)
2615 (region_cache_backward, pp_cache):
2616 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2617 so that ptrdiff_t * can be passed to xpalloc.
2618 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2619 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2620 (pp_cache): Don't assume cache_len fits in int.
2621 * region-cache.h: Adjust extern decls to match.
2622
2623 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2624 EMACS_INT, since either will do, for xpalloc.
2625
2626 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2627 (xnmalloc, xnrealloc, xpalloc): New functions.
2628
726e0ab1
PE
2629 * bidi.c (bidi_shelve_header_size): New constant.
2630 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2631 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2632
51f30bc5 2633 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2634 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2635 (overlay_strings):
2636 Don't update size of array until after memory allocation succeeds,
2637 because xmalloc/xrealloc may not return.
0065d054
PE
2638 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2639 now that we have proper integer overflow checking.
2640 (record_overlay_string, overlay_strings): Catch overflows when
2641 calculating size of overlay_str_buf.
726e0ab1 2642
0065d054
PE
2643 * callproc.c (Fcall_process): Check for size overflow when
2644 calculating size of args2.
2645 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2646 Normally we prefer signed values, but sticking with ptrdiff_t would
2647 require adding more-complicated checks.
726e0ab1
PE
2648
2649 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2650 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2651 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2652 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2653
2654 * character.c (Fstring): Check for size-calculation overflow.
2655
2656 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2657 unnecessary integer overflow. Check for size overflow.
2658 (encode_coding_object): Don't update size until xmalloc succeeds.
2659
2660 * composite.c (get_composition_id): Check for overflow in glyph
2661 length calculations.
2662
2663 Integer and memory overflow fixes for display code.
2664 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2665 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2666 (scrolling_window): Check for overflow in size calculations.
2667 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2668 Don't assume glyph table len fits in int.
2669 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2670 (row_table_size): Now ptrdiff_t, not int.
2671 (scrolling_window): Avoid overflow in size calculations.
2672 Don't update size until allocation succeeds.
2673 * fns.c (concat): Check for overflow in size calculations.
2674 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2675 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2676 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2677
2678 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2679 (get_doc_string): Check for size calculation overflow.
2680 Don't update size until allocation succeeds.
2681 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2682 EMACS_INT, where ptrdiff_t will do.
2683 (Fsubstitute_command_keys): Check for string overflow.
2684
2685 * editfns.c (set_time_zone_rule): Don't assume environment length
2686 fits in int.
2687 (message_length): Now ptrdiff_t, not int.
2688 (Fmessage_box): Don't update size until allocation succeeds.
2689 Don't assume message length fits in int.
2690 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2691
0065d054
PE
2692 * emacs.c (main): Do not reallocate argv, since there is a null at
2693 the end that can be overwritten, and this way there's no need to
2694 worry about size-calculation overflow.
2695 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2696
2697 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2698 alloc succeeds.
2699 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2700
2701 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2702 (x_set_scroll_bar_width, x_figure_window_size):
2703 Check for integer overflow.
2704 (x_set_alpha): Do not assume XINT fits in int.
2705
2706 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2707 This is for the members text_lines, text_cols, total_lines, total_cols,
2708 where the system imposes an 'int' limit.
2709
2710 * fringe.c (Fdefine_fringe_bitmap):
2711 Don't update size until alloc works.
2712
2713 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2714 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2715
2716 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2717 Check for size-calculation overflow.
2718 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2719 do, as we prefer signed integers.
2720 (id_to_widget.max_size, id_to_widget.used)
2721 (xg_store_widget_in_map, xg_remove_widget_from_map)
2722 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2723 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2724 Use and return ptrdiff_t, not int.
2725 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2726 * gtkutil.h: Change prototypes to match the above.
2727
2728 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2729 are duplicate now that they've been promoted to lisp.h.
2730 (x_allocate_bitmap_record, x_alloc_image_color)
2731 (make_image_cache, cache_image, xpm_load):
2732 Don't update size until alloc is done.
2733 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2734 (x_detect_edges):
3256efce 2735 Check for size calculation overflow.
726e0ab1
PE
2736 (ct_colors_allocated_max): New constant.
2737 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2738 overflow.
3256efce 2739
726e0ab1
PE
2740 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2741 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2742 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2743 Use ptrdiff_t, not int, to count maps.
2744 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2745 calculations. Don't update size until allocation succeeds.
2746 Redo calculations to avoid overflow.
726e0ab1
PE
2747 * keyboard.h: Change prototypes to match the above.
2748
2749 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2750 to count maps.
2751 (current_minor_maps): Check for size calculation overflow.
2752 * keymap.h: Change prototypes to match the above.
2753
2754 * lread.c (read1, init_obarray): Don't update size until alloc done.
2755
2756 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2757 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2758
726e0ab1
PE
2759 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2760 Now ptrdiff_t, not int.
2761 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2762 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2763
2764 * process.c (Fnetwork_interface_list): Check for overflow
2765 in size calculation.
2766
2767 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2768
2769 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2770 overflow. Don't bother calling xmalloc when xrealloc will do.
2771
2772 * search.c (Freplace_match): Check for size calculation overflow.
2773 (Fset_match_data): Don't assume list lengths fit in 'int'.
2774
2775 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2776 for command line length. Do not attempt to address one before the
2777 beginning of an array, as that's not portable.
2778
2779 * term.c (max_frame_lines): Remove; unused.
2780 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2781 not int.
2782 (encode_terminal_code, calculate_costs): Check for size
2783 calculation overflow.
2784 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2785 table lengths and related sizes. Don't update size until alloc
2786 done. Redo calculations to avoid overflow.
2787 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2788
2789 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2790 subtracting pointers.
2791 (gobble_line): Check for overflow more carefully. Don't update size
2792 until alloc done.
2793
2794 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2795 Don't update size until alloc done.
2796 Redo size calculations to avoid overflow.
2797 Check for size calculation overflow.
0065d054 2798 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2799
2800 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2801 Use ptrdiff_t, not int, for sizes.
2802 (store_mode_line_noprop_char): Don't update size until alloc done.
2803
0065d054
PE
2804 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2805 Use ptrdiff_t, not int, for sizes.
2806 (Finternal_make_lisp_face, cache_face):
2807 Check for size calculation overflow.
2808 (cache_face): Treat size calculation overflows as if they were
2809 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2810
2811 * xfns.c (x_encode_text, x_set_name_internal)
2812 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2813 sizes, since they can exceed INT_MAX in size. Check for size
2814 calculation overflow.
2815
0065d054
PE
2816 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2817 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2818 Don't update size until alloc done.
2819
0065d054 2820 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2821 as sprintf is limited to int lengths.
1d526e2f 2822
252c5ee1
PE
2823 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2824 (X_LONG_MIN): New macros.
864d7ce7
PE
2825 Use them to make the following changes clearer.
2826 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2827 This change doesn't affect the value now, but it may help remind
2828 future maintainers not to raise the value too much later.
2829 (SELECTION_QUANTUM): Remove, replacing with ...
2830 (selection_quantum): ... new function, which avoids overflow.
2831 All uses changed.
2832 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2833 assumption that selection length fits in 'int'.
2834 (x_reply_selection_request, x_handle_selection_request)
2835 (x_get_window_property, receive_incremental_selection)
2836 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2837 (lisp_data_to_selection_data, clean_local_selection_data):
2838 Use ptrdiff_t, not int, to record length of selection.
2839 (x_reply_selection_request, x_get_window_property)
2840 (receive_incremental_selection, x_property_data_to_lisp):
2841 Redo calculations to avoid overflow.
2842 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2843 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2844 something.
2845 (x_get_window_property, receive_incremental_selection)
2846 (lisp_data_to_selection_data, x_property_data_to_lisp):
2847 Check for size-calculation overflow.
2848 (x_get_window_property, receive_incremental_selection)
2849 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2850 Don't store size until memory allocation succeeds.
2851 (x_get_window_property): Plug memory leak on memory exhaustion.
2852 Don't double-block input; malloc is safe here. Don't assume 2**34
2853 - 4 fits in unsigned long. Add an xassert to check
2854 XGetWindowProperty overflow. Be more careful about overflow
2855 calculations, and distinguish size from memory overflow better.
2856 (receive_incremental_selection): When tracing, don't assume
2857 unsigned int is less than INT_MAX.
2858 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2859 harmful) conversions of unsigned short to int.
2860 (lisp_data_to_selection_data): Don't assume that integers
2861 in the range -65535 through -1 fit in an X unsigned short.
2862 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2863 result parameters unless successful. Rely on cons_to_unsigned
2864 to report problems with elements; the old code wasn't right anyway.
2865 (x_check_property_data): Check for int overflow; we cannot use
2866 a wider type due to X limits.
2867 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2868
726e0ab1 2869 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2870
0065d054
PE
2871 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2872 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2873 (x_color_cells): Don't store size until memory allocation succeeds.
2874 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2875 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2876 (x_term_init): Don't assume length fits in int (sprintf is limited
2877 to int size).
bc18e09d 2878
ebfa62c0
PE
2879 Use ptrdiff_t for composition IDs.
2880 * character.c (lisp_string_width):
2881 * composite.c (composition_table_size, n_compositions)
2882 (get_composition_id, composition_gstring_from_id):
2883 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2884 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2885 * window.c (Frecenter):
2886 Use ptrdiff_t, not int, for composition IDs.
2887 * composite.c (get_composition_id): Check for integer overflow.
2888 * composite.h: Adjust prototypes to match the above changes.
2889
d3411f89
PE
2890 Use ptrdiff_t for hash table indexes.
2891 * category.c (hash_get_category_set):
2892 * ccl.c (ccl_driver):
2893 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2894 * coding.c (coding_system_charset_list, detect_coding_system):
2895 * coding.h (struct coding_system.id):
2896 * composite.c (get_composition_id, gstring_lookup_cache):
2897 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2898 * image.c (xpm_get_color_table_h):
2899 * lisp.h (hash_lookup, hash_put):
2900 * minibuf.c (Ftest_completion):
2901 Use ptrdiff_t for hash table indexes, not int (which is too
2902 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2903 32-bit --with-wide-int hosts).
2904
e097a6fa
PE
2905 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2906 Add a FIXME comment about memory leaks.
2907 (syms_of_charset): Don't assume xmalloc returns.
2908
5637687f
PE
2909 Don't assume that stated character widths fit in int.
2910 * character.c (Fchar_width, c_string_width, lisp_string_width):
2911 * character.h (CHAR_WIDTH):
2912 * indent.c (MULTIBYTE_BYTES_WIDTH):
2913 Use sanitize_char_width to avoid undefined and/or bad behavior
2914 with outlandish widths.
a66cfb1c 2915 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2916 now that we have two such functions. All uses changed.
2917 (sanitize_char_width): New inline function.
2918
a2271ba2
PE
2919 Don't assume that tab-width fits in int.
2920 * character.h (sanitize_width): New inline function.
2921 (SANE_TAB_WIDTH): New macro.
2922 (ASCII_CHAR_WIDTH): Use it.
2923 * indent.c (sane_tab_width): Remove. All uses replaced by
2924 SANE_TAB_WIDTH (current_buffer).
2925 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2926
18c52557
PE
2927 * fileio.c: Integer overflow issues with file modes.
2928 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2929
caeeedc1
PE
2930 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2931 Remove unreachable code.
2932 (read_hex, load_charset_map_from_file): Check for integer overflow.
2933
6df6ae42 2934 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2935 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2936 (x_send_scroll_bar_event): Likewise. Check that the size does not
2937 exceed limits imposed by XClientMessageEvent, as well as the usual
2938 ptrdiff_t and size_t limits.
2939
b13995db
PE
2940 * keyboard.c: Overflow, signedness and related fixes.
2941 (make_lispy_movement): Use same integer type in forward decl
2942 that is used in the definition.
2943 (read_key_sequence, keyremap_step):
2944 Change bufsize argument back to int, undoing my 2011-03-30 change.
2945 We prefer signed types, and int is wide enough here.
2946 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2947 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2948 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2949 length, not size_t. Use ptrdiff_t for index, not int.
2950 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2951 possibility of integer overflow.
2952
13464394
PE
2953 Overflow, signedness and related fixes for images.
2954
2955 * dispextern.h (struct it.stack[0].u.image.image_id)
2956 (struct_it.image_id, struct image.id, struct image_cache.size)
2957 (struct image_cache.used, struct image_cache.ref_count):
2958 * gtkutil.c (update_frame_tool_bar):
2959 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2960 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2961 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2962 * nsmenu.m (update_frame_tool_bar):
2963 * xdisp.c (calc_pixel_width_or_height):
2964 * xfns.c (image_cache_refcount):
2965 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2966 on typical 64-bit hosts.
2967
2968 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2969 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2970 Omit unnecessary casts to int.
2971 (parse_image_spec): Check that integers fall into 'int' range
2972 when the callers expect that.
2973 (image_ascent): Redo ascent calculation to avoid int overflow.
2974 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2975 (lookup_image): Remove unnecessary tests.
2976 (xbm_image_p): Locals are now of int, not EMACS_INT,
2977 since parse_image_check makes sure they fit into int.
2978 (png_load, gif_load, svg_load_image):
2979 Prefer int to unsigned where either will do.
2980 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2981 old tiff_error_handler and tiff_warning_handler.
2982 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2983 stack buffer overflows. It uses only the features of vsnprintf
2984 that are common to both POSIX and native Microsoft.
2985 (tiff_error_handler, tiff_warning_handler): Use it.
2986 (tiff_load, gif_load, imagemagick_load_image):
2987 Don't assume :index value fits in 'int'.
2988 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2989 (imagemagick_load_image): Check that crop parameters fit into
2990 the integer types that MagickCropImage accepts. Don't assume
2991 Vimagemagick_render_type has a nonnegative value. Don't assume
2992 size_t fits in 'long'.
2993 (gs_load): Use printmax_t to print the widest integers possible.
2994 Check for integer overflow when computing image height and width.
2995
c11821d4
EZ
29962011-08-26 Eli Zaretskii <eliz@gnu.org>
2997
2998 * xdisp.c (redisplay_window): Don't force window start if point
2999 will be invisible in the resulting window. (Bug#9324)
3000
0c95fcf7
EZ
30012011-08-25 Eli Zaretskii <eliz@gnu.org>
3002
3003 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3004 the display spec is of the form `(space ...)'.
3005 (handle_display_spec): Return the value returned by
3006 handle_single_display_spec, not just 1 or zero.
3007 (handle_single_display_spec): If the display spec is of the form
3008 `(space ...)', and specifies display in the text area, return 2
3009 rather than 1.
fee65a97 3010 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3011 accurately, and prefer exact match for point under bidi.
3012 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3013
3014 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3015 into disp_prop; all users changed.
3016
3017 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3018 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3019 for the text covered by the display property.
3020
e4ed06f1
CY
30212011-08-25 Chong Yidong <cyd@stupidchicken.com>
3022
3023 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3024 Change return value to nil.
3025 (Frecord_buffer): Delete unused function.
3026
f67cdd7f
EZ
30272011-08-24 Eli Zaretskii <eliz@gnu.org>
3028
5980d4c6
EZ
3029 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3030 buffers, return left-to-right.
8610fe8b
EZ
3031 (set_cursor_from_row): Consider candidate row a win if its glyph
3032 represents a newline and point is on that newline. Fixes cursor
3033 positioning on the newline at EOL of R2L text within L2R
3034 paragraph, and vice versa.
3035 (try_cursor_movement): Check continued rows, in addition to
3036 continuation rows. Fixes unwarranted scroll when point enters a
3037 continued line of R2L text within an L2R paragraph, or vice versa.
3038 (cursor_row_p): Consider the case of point being equal to
3039 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3040 from the end of a short line to the beginning of a continued line
3041 of R2L text within L2R paragraph.
3042 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3043 composed characters.
5980d4c6 3044
f67cdd7f
EZ
3045 * bidi.c (bidi_check_type): Use xassert.
3046 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3047 members.
3048
bca633fb
EZ
30492011-08-23 Eli Zaretskii <eliz@gnu.org>
3050
3051 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3052 a character.
3053
4a5885a7
CY
30542011-08-23 Chong Yidong <cyd@stupidchicken.com>
3055
3056 * nsfont.m (ns_otf_to_script): Fix typo.
3057
0902a04e
KH
30582011-08-22 Kenichi Handa <handa@m17n.org>
3059
3060 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3061 extra slot even if the purpose is char-code-property-table.
3062
1a2e6670
EZ
30632011-08-23 Eli Zaretskii <eliz@gnu.org>
3064
8ddde651
EZ
3065 * xdisp.c (redisplay_window): When computing centering_position,
3066 account for the height of the header line. (Bug#8874)
3067
425cc014
EZ
3068 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3069 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3070 candidate is selected by the mouse, and that candidate has a
3071 composed character under the mouse.
3072
1a2e6670
EZ
3073 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3074 coordinates reported by pos-visible-in-window-p for a composed
3075 character in column zero.
3076
8b76d6f8
SM
30772011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3078
3079 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3080
dac347dd
EZ
30812011-08-22 Eli Zaretskii <eliz@gnu.org>
3082
3083 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3084 consider it a hit if to_charpos is anywhere in the range of the
3085 composed buffer positions.
3086
e013fb34
CY
30872011-08-22 Chong Yidong <cyd@stupidchicken.com>
3088
3089 * image.c (gif_load): Don't assume that each subimage has the same
3090 dimensions as the base image. Handle disposal method that is
3091 "undefined" by the gif spec (Bug#9335).
3092
bd1ba3e8
CY
30932011-08-20 Chong Yidong <cyd@stupidchicken.com>
3094
3095 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3096 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3097
54a1215b
EZ
30982011-08-19 Eli Zaretskii <eliz@gnu.org>
3099
823564e5
EZ
3100 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3101 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3102 from an Org mode buffer to a Speedbar frame.
3103
54a1215b
EZ
3104 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3105 a composition, take its buffer position from IT->cmp_it.charpos.
3106 Fixes cursor positioning at the beginning of a line that begins
3107 with a composed character.
3108
9778ebcc
EZ
31092011-08-18 Eli Zaretskii <eliz@gnu.org>
3110
0be6ee06
EZ
3111 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3112 character bidirectional type, use STRONG_L instead. Fixes crashes
3113 in a buffer produced by `describe-categories'.
3114
9778ebcc
EZ
3115 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3116 members before the level stack, so they would be saved and
3117 restored when copying iterator state. Fixes incorrect reordering
3118 around TABs covered by display properties.
3119
156bffbe
AS
31202011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3121
6b02f655 3122 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3123
72ad093b
CY
31242011-08-17 Chong Yidong <cyd@stupidchicken.com>
3125
3126 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3127 (internal_condition_case_2, internal_condition_case_n):
3128 Remove unnecessary aborts (Bug#9081).
72ad093b 3129
35774242
EZ
31302011-08-17 Eli Zaretskii <eliz@gnu.org>
3131
3132 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3133 has no `load' handler, try opening the file locally. (Bug#9311)
3134
db76dd85
KB
31352011-08-16 Ken Brown <kbrown@cornell.edu>
3136
3137 * gmalloc.c: Expand comment.
3138
b215eee5
EZ
31392011-08-16 Eli Zaretskii <eliz@gnu.org>
3140
3141 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3142 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3143
a4579d33
KB
31442011-08-16 Ken Brown <kbrown@cornell.edu>
3145
3146 Fix memory allocation problems in Cygwin build (Bug#9273).
3147
3148 * unexcw.c ( __malloc_initialized): Declare external variable.
3149 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3150
8b76d6f8
SM
3151 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3152 New variables.
a4579d33
KB
3153 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3154 dumped emacs.
3155 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3156 in the static heap.
3157 [CYGWIN] (special_realloc): New function.
3158 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3159 requests to realloc storage in the static heap.
3160
3ebec551
PE
31612011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3162
3163 * bidi.c (bidi_initialize): Remove unused local.
3164
9fd8be00
EZ
31652011-08-15 Eli Zaretskii <eliz@gnu.org>
3166
6b02f655
SM
3167 * bidimirror.h:
3168 * biditype.h: Remove file.
3169 * makefile.w32-in ($(BLD)/bidi.$(O)):
3170 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3171
3172 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3173
3174 * chartab.c: Improve commentary for the uniprop_table API.
3175
32413314
EZ
3176 * bidi.c (bidi_paragraph_init): Support zero value of
3177 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3178 (bidi_initialize): Use uniprop_table instead of including
3179 biditype.h and bidimirror.h.
32413314 3180
9fd8be00
EZ
3181 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3182 coordinates of the iterator when restoring from ppos_it.
3183 (Bug#9296)
3184
5cf2b69b
KH
31852011-08-14 Kenichi Handa <handa@m17n.org>
3186
3187 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3188 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3189
daf17d00
EZ
31902011-08-14 Eli Zaretskii <eliz@gnu.org>
3191
3192 * xdisp.c (move_it_in_display_line_to): Don't invoke
3193 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3194 ppos_it. Fixes vertical cursor motion when line beginning is
3195 covered by an image. (Bug#9296)
3196
08e3161a
JD
31972011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3198
3199 * nsterm.h (ns_run_ascript): Declare.
3200 (NSAPP_DATA2_RUNASSCRIPT): Define.
3201
3202 * nsfns.m (as_script, as_result, as_status): New static variables.
3203 (ns_run_ascript): New function.
5e617bc2 3204 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3205 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3206 the event loop. Get status from as_status (Bug#7276).
3207
3208 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3209 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3210 the event loop (Bug#7276).
3211
a3720aa2
AS
32122011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3213
3214 * gnutls.c (QCgnutls_bootprop_priority)
3215 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3216 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3217 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3218 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3219 (QCgnutls_bootprop_verify_hostname_error)
3220 (QCgnutls_bootprop_callbacks_verify): Rename from
3221 Qgnutls_bootprop_..., all uses changed.
3222
3223 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3224 uses changed.
3225
0a0d27fb
PE
32262011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3227
19d5c50c
PE
3228 * xfaces.c (Qframe_set_background_mode): Now static.
3229 * dispextern.h (Qframe_set_background_mode): Remove decl.
3230
0a0d27fb
PE
3231 * process.c (Fnetwork_interface_info): Declare local only if needed.
3232
377538cb
JD
32332011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3234
3235 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3236 (Fnetwork_interface_list): Allocate in increments of bytes instead
3237 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3238 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3239 sockaddr.
3240 (struct ifflag_def): notrailers is smart on OSX.
3241 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3242 Get hardware address with getifaddrs if available.
3243
08fff70c
EZ
32442011-08-12 Eli Zaretskii <eliz@gnu.org>
3245
3246 * xdisp.c (iterate_out_of_display_property): xassert that
3247 IT->position is set to within IT->object's boundaries. Break from
3248 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3249 when IT->position is set up wrongly due to some bug.
3250 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3251 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3252 entry. Force push_it to save on the stack the current
3253 buffer/string position, to be restored by pop_it. Fix flags in
3254 the iterator structure wrt the object coming from a display
3255 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3256 properties. (Bug#9284)
3257
7be1c708 32582011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3259
7be1c708
CY
3260 * fontset.c (fontset_get_font_group): Add proper type checks.
3261 (Bug#9172)
aac0c6e3 3262
7be1c708 32632011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3264
7be1c708
CY
3265 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3266 and LC_VERSION_MIN_MACOSX.
3267 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3268 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3269
97bb72a6
EZ
32702011-08-08 Eli Zaretskii <eliz@gnu.org>
3271
3272 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3273 no-display-properties-and-no-overlays under bidi display.
3274 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3275 properties and overlays.
97bb72a6 3276
d5617611
CY
32772011-08-08 Chong Yidong <cyd@stupidchicken.com>
3278
37e11a63
CY
3279 * editfns.c (Fset_time_zone_rule): Document relationship with the
3280 setenv function.
3281
d5617611
CY
3282 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3283 the font entity extracted from the cache (Bug#8109).
3284
58872834
CY
32852011-08-07 Chong Yidong <cyd@stupidchicken.com>
3286
3287 * composite.c (autocmp_chars): Don't reset point. That is done by
3288 restore_point_unwind (Bug#5984).
3289
75bfc667
JL
32902011-08-07 Juri Linkov <juri@jurta.org>
3291
3292 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3293 to show the arg `TIME' instead of `TIMEVAL'.
3294
d1410150
EZ
32952011-08-06 Eli Zaretskii <eliz@gnu.org>
3296
3297 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3298 display property strides EOL and includes a newline, as in
3299 longlines-mode. (Bug#9254)
75b771e4
EZ
3300 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3301 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3302
3303 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3304 is non-zero, even if the data buffer is NULL. Fixes a crash in
3305 vertical-motion with longlines-mode. (Bug#9254)
3306
35928349
EZ
33072011-08-05 Eli Zaretskii <eliz@gnu.org>
3308
ec7cc85b
EZ
3309 * bidi.c <bidi_cache_total_alloc>: Now static.
3310 (bidi_initialize): Initialize bidi_cache_total_alloc.
3311
8b76d6f8 3312 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3313 cache. (Bug#9221)
3314
3315 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3316 amount allocated this far in `bidi_cache_total_alloc'.
3317 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3318 non-zero, only free the data buffer without restoring the cache
3319 contents. All callers changed.
3320
3321 * dispextern.h (bidi_unshelve_cache): Update prototype.
3322
3323 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3324 (move_it_in_display_line, move_it_to)
3325 (move_it_vertically_backward, move_it_by_lines): Replace the call
3326 to xfree to an equivalent call to bidi_unshelve_cache.
3327 (move_it_in_display_line_to): Fix logic of returning
412b6358 3328 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3329
e2e2423b
EZ
33302011-08-05 Eli Zaretskii <eliz@gnu.org>
3331
3332 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3333 came from a string character with a `cursor' property. (Bug#9229)
3334
ae9e757a
JD
33352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3336
3337 * Makefile.in (LIB_PTHREAD): New variable.
3338 (LIBES): Add LIB_PTHREAD (Bug#9216).
3339
3340 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3341 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3342
213bd7f2
AS
33432011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3344
6b02f655 3345 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3346
99aaf75f
JD
33472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3348
3349 * xterm.c (x_find_topmost_parent): New function.
3350 (x_set_frame_alpha): Find topmost parent window with
3351 x_find_topmost_parent and set the property there also (bug#9181).
3352 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3353
c74e9d86
PE
33542011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3355
3356 * callproc.c (Fcall_process): Avoid vfork clobbering
3357 the local vars buffer, coding_systems, current_dir.
3358
640c8776
SM
33592011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3360
3361 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3362
f26d0e4c
PE
33632011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3364
8a10d76c
PE
3365 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3366 so that it is not optimized away.
3367
f26d0e4c
PE
3368 * xdisp.c (compute_display_string_pos): Remove unused local.
3369
55439c61
EZ
33702011-08-02 Eli Zaretskii <eliz@gnu.org>
3371
3372 Fix slow cursor motion and scrolling in large buffers with
3373 selective display, like Org Mode buffers. (Bug#9218)
3374
3375 * dispextern.h (struct bidi_it): New member disp_prop_p.
3376
3377 * xdisp.c: Remove one-slot cache of display string positions.
3378 (compute_display_string_pos): Accept an additional argument
5e617bc2 3379 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3380 for a display string or property. If found, set DISP_PROP_P
3381 non-zero.
3382
3383 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3384 DISP_PROP_P, and pass it to compute_display_string_pos.
3385 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3386 non-zero. All callers of bidi_fetch_char changed.
3387
fb33fa43
SM
33882011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3389
3390 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3391
b099e063
DM
33922010-12-03 Don March <don@ohspite.net>
3393
3394 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3395 last character M-[char] is translated to ESC [char] (bug#7541).
3396
5cc7f7af
KH
33972011-08-02 Kenichi Handa <handa@m17n.org>
3398
d0fffa3f 3399 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3400
3401 * chartab.c (uniprop_table): Make it non-static.
3402
525d5e6e
EZ
34032011-08-01 Eli Zaretskii <eliz@gnu.org>
3404
3405 * xdisp.c (forward_to_next_line_start): Accept additional argument
3406 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3407 on the newline.
3408 (reseat_at_next_visible_line_start): Use the bidi iterator state
3409 returned by forward_to_next_line_start to restore the state of
3410 it->bidi_it after backing up to previous newline. (Bug#9212)
3411
31011111
AS
34122011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3413
3414 * regex.c (re_comp): Protoize.
3415 (re_exec): Fix return type.
3416 (regexec): Fix type of `ret'. (Bug#9203)
3417
476371c4
PE
34182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3419
e5d76069
PE
3420 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3421 This is needed if max-image-size is a floating-point number.
3422
9a79b20c
AS
34232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3424
3425 * print.c (print_object): Print empty symbol as ##.
3426
3427 * lread.c (read1): Read ## as empty symbol.
3428
d8c2fa78
AA
34292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3430
3431 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3432 setting frame foreground color (Bug#9175).
3433 (x_set_background_color): Likewise.
3434
ffe57a7a
AA
3435 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3436 contents (Bug#9176).
3437 (EmacsTooltip -init): Remove bezels and add shadows to
3438 tooltip windows.
3439
bf3492a5
AA
3440 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3441 or scroll bar (Bug#8470).
3442
d55e9c53
AA
3443 * nsfont.m (nsfont_open): Remove assignment to voffset and
3444 unnecessary vars hshink, expand, hd, full_height, min_height.
3445 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3446
3447 * nsterm.h (nsfont_info): Remove voffset field.
3448
d8c2fa78 34492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3450
3451 Implement strike-through and overline on NextStep (Bug#8863).
3452
3453 * nsfont.m (nsfont_open): Use underline position provided by font,
3454 instead of hard-coded value of 2.
3455 (nsfont_draw): Call ns_draw_text_decoration instead.
3456
3457 * nsterm.h: Add declaration for ns_draw_text_decoration.
3458
3459 * nsterm.m (ns_draw_text_decoration): New function for drawing
3460 underline, overline, and strike-through.
3461 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3462 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3463 accommodate underlining, etc.
4843aac3 3464
4cc60b9b
EZ
34652011-07-28 Eli Zaretskii <eliz@gnu.org>
3466
bc7ece87
EZ
3467 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3468 default.
4cc60b9b 3469
476371c4
PE
34702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3471
66606eea
PE
3472 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3473 Without this fix, if a signal arrives just after memory fills up,
3474 'malloc' might be invoked reentrantly.
3475
476371c4
PE
3476 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3477 In other words, assume that every image size is allowed, on non-X
3478 hosts. This assumption is probably wrong, but it lets Emacs compile.
3479
f3fcc40d
AS
34802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3481
3482 * regex.c (re_iswctype): Convert return values to boolean.
3483
350c992f
EZ
34842011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3485
3486 * xdisp.c (compute_display_string_pos): Don't use cached display
3487 string position if the buffer had its restriction changed.
3488 (Bug#9184)
3489
5266b4bb
PE
34902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3493
2573a837 34942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3495
41f55ccd 3496 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3497
39e378da
PE
3498 * bidi.c: Integer size and overflow fixes.
3499 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3500 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3501 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3502 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3503 (bidi_find_other_level_edge):
3504 Use ptrdiff_t instead of EMACS_INT where either will do.
3505 This works better on 32-bit hosts configured --with-wide-int.
3506 (bidi_cache_ensure_space): Check for size-calculation overflow.
3507 Use % rather than repeated addition, for better worst-case speed.
3508 Don't set bidi_cache_size until after xrealloc returns, because it
3509 might not return.
3510 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3511 (bidi_cache_ensure_space): Also check that the bidi cache size
3512 does not exceed that of the largest Lisp string or buffer. See Eli
3513 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3514
5e927815
PE
3515 * alloc.c (__malloc_size_t): Remove.
3516 All uses replaced by size_t. See Andreas Schwab's note
3517 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3518
ca4aa935
PE
3519 * image.c: Improve checking for integer overflow.
3520 (check_image_size): Assume that f is nonnull, since
3521 it is always nonnull in practice. This is one less thing to
3522 worry about when checking for integer overflow later.
3523 (x_check_image_size): New function, which checks for integer
3524 overflow issues inside X.
3525 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3526 This removes the need for a memory_full check.
3527 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3528 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3529 (xbm_read_bitmap_data): Change locals back to 'int', since
3530 their values must fit in 'int'.
3531 (xpm_load_image, png_load, tiff_load):
3532 Invoke x_create_x_image_and_pixmap earlier,
3533 to avoid much needless work if the image is too large.
3534 (tiff_load): Treat overly large images as if
3535 x_create_x_image_and_pixmap failed, not as malloc failures.
3536 (gs_load): Use x_check_image_size.
3537
5f8f9cc2
PE
3538 * gtkutil.c: Omit integer casts.
3539 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3540 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3541
5adf60bc
PE
3542 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3543
c8907a93
PE
3544 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3545 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3546 would wrongly return t on a 64-bit host.
3547
e3c25c68
PE
3548 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3549 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3550 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3551 and therefore cause GCC to emit a bogus diagnostic in some cases.
3552
3f791afe
PE
3553 * image.c: Integer signedness and overflow and related fixes.
3554 This is not an exhaustive set of fixes, but it's time to
3555 record what I've got.
3556 (lookup_pixel_color, check_image_size): Remove redundant decls.
3557 (check_image_size): Don't assume that arbitrary EMACS_INT values
3558 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3559 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3560 (tiff_load, imagemagick_load_image):
3561 Check for overflow in size calculations.
3562 (x_create_x_image_and_pixmap): Remove unnecessary test for
3563 xmalloc returning NULL; that can't happen.
3564 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3565 (xpm_color_bucket): Use better integer hashing function.
3566 (xpm_cache_color): Don't possibly over-allocate memory.
3567 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3568 (gif_memory_source):
3569 Use ptrdiff_t, not int or size_t, to record sizes.
3570 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3571 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3572 either works, as we prefer signed integers.
3573 (tiff_read_from_memory, tiff_write_from_memory):
3574 Return tsize_t, not size_t, since that's what the TIFF API wants.
3575 (tiff_read_from_memory): Don't fail simply because the read would
3576 go past EOF; instead, return a short read.
3577 (tiff_load): Omit no-longer-needed casts.
3578 (Fimagemagick_types): Don't assume size fits into 'int'.
3579
3cc5a532
PE
3580 Improve hashing quality when configured --with-wide-int.
3581 * fns.c (hash_string): New function, taken from sxhash_string.
3582 Do not discard information about ASCII character case; this
3583 discarding is no longer needed.
3584 (sxhash-string): Use it. Change sig to match it. Caller changed.
3585 * lisp.h: Declare it.
3586 * lread.c (hash_string): Remove, since we now use fns.c's version.
3587 The fns.c version returns a wider integer if --with-wide-int is
3588 specified, so this should help the quality of the hashing a bit.
3589
b312a492
PE
3590 * emacs.c: Integer overflow minor fix.
3591 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3592 Define only if GNU_LINUX.
3593 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3594
dfd153ae
PE
3595 * dispnew.c: Integer signedness and overflow fixes.
3596 Remove unnecessary forward decls, that were a maintenance hassle.
3597 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3598 All uses changed.
3599 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3600 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3601 (prepare_desired_row, line_draw_cost):
3602 Use int, not unsigned, where either works.
3603 (save_current_matrix, restore_current_matrix):
3604 Use ptrdiff_t, not size_t, where either works.
3605 (init_display): Check for overflow more accurately, and without
3606 relying on undefined behavior.
3607
a81d11a3
PE
3608 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3609 Remove, replacing with the new symbols in lisp.h. All uses changed.
3610 * fileio.c (make_temp_name):
3611 * filelock.c (lock_file_1, lock_file):
3612 * xdisp.c (message_dolog):
3613 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3614 Use pMd etc. instead.
3615 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3616 replacing the pWIDE etc. symbols removed from editfns.c.
3617
3300e6fd
PE
3618 * keyboard.h (num_input_events): Now uintmax_t.
3619 This is (very slightly) less likely to mess up due to wraparound.
3620 All uses changed.
3621
fd05c7e9
PE
3622 * buffer.c: Integer signedness fixes.
3623 (alloc_buffer_text, enlarge_buffer_text):
3624 Use ptrdiff_t rather than size_t when either will do, as we prefer
3625 signed integers.
3626
903fe15d
PE
3627 * alloc.c: Integer signedness and overflow fixes.
3628 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3629 (__malloc_size_t): Default to size_t, not to int.
3630 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3631 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3632 Prefer ptrdiff_t to size_t when either would do, as we prefer
3633 signed integers.
3634 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3635 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3636 Now const. Initialize with values that are in range even if char
3637 is signed.
3638 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3639 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3640 These functions do the right thing with sizes > 2**32.
3641 (check_depth): Now ptrdiff_t, not int.
3642 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3643 Adjust to new way of storing sizes. Check for size overflow bugs
3644 in rest of code.
3645 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3646 slightly wrong anyway, as it missed one instance of
3647 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3648 (refill_memory_reserve): Omit needless cast to size_t.
3649 (mark_object_loop_halt): Mark as externally visible.
3650
ac82cc6a
PE
3651 * xselect.c: Integer signedness and overflow fixes.
3652 (Fx_register_dnd_atom, x_handle_dnd_message):
3653 Use ptrdiff_t, not size_t, since we prefer signed.
3654 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3655 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3656 x_dnd_atoms_size and x_dnd_atoms_length.
3657
c2d1e36d
PE
3658 * doprnt.c: Prefer signed to unsigned when either works.
3659 * eval.c (verror):
3660 * doprnt.c (doprnt):
3661 * lisp.h (doprnt):
3662 * xdisp.c (vmessage):
3663 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3664 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3665 prefer signed arithmetic to avoid comparison confusion.
3666 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3667 but is a bit tricky.
3668
0e926e56
PE
3669 Assume freestanding C89 headers, string.h, stdlib.h.
3670 * data.c, doprnt.c, floatfns.c, print.c:
3671 Include float.h unconditionally.
3672 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3673 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3674 * regex.c: Likewise for stddef.h, string.h.
3675 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3676 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3677 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3678 (STDC_HEADERS): Remove obsolete defines.
3679 * sysdep.c: Include limits.h unconditionally.
3680
9cfdb3ec
PE
3681 Assume support for memcmp, memcpy, memmove, memset.
3682 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3683 * regex.c (memcmp, memcpy):
3684 Remove; we assume C89 now.
3685
3686 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3687 (__malloc_safe_bcopy): Remove; no longer needed.
3688
cf950e6b 3689 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3690 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3691 well either way, and we prefer signed to unsigned.
3692
dbf38e02
LMI
36932011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3694
3695 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3696 closes the connection while we're reading (bug#9182).
3697
d6f0886c 36982011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3699
d6f0886c
JD
3700 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3701 are specified (Bug#9168).
24e0f6b1 3702
2eb1f9e6
PE
37032011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3704
3705 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3706 Found by GCC static checking and --with-wide-int on a 32-bit host.
3707
22381272 37082011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3709
3710 * xdisp.c (compute_display_string_pos): Fix logic of caching
3711 previous display string position. Initialize cached_prev_pos to
3712 -1. Fixes slow-down at the beginning of a buffer.
3713
f25e39b4
EZ
37142011-07-24 Eli Zaretskii <eliz@gnu.org>
3715
3716 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3717 for attrs[LFACE_FONTSET_INDEX].
3718
04c4b52e
PE
37192011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3720
3721 * xml.c (parse_region): Remove unused local
3722 that was recently introduced.
3723
c1734fbd
EZ
37242011-07-23 Eli Zaretskii <eliz@gnu.org>
3725
be18c5a5
EZ
3726 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3727 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3728
c1734fbd
EZ
3729 * xdisp.c (move_it_in_display_line_to): Record the best matching
3730 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3731 exit if none of the characters scanned was an exact match.
3732 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3733 when exact match is impossible due to invisible text, and the
3734 lines are truncated.
3735
a258d627
JD
37362011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3737
3738 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3739 for OSX >= 10.7.
3740
b6d5a689
EZ
37412011-07-22 Eli Zaretskii <eliz@gnu.org>
3742
0f74f785
EZ
3743 Fix a significant slow-down of cursor motion with C-n, C-p,
3744 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3745 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3746 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3747 (next_element_from_buffer): Call compute_stop_pos_backwards to
3748 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3749 base_level_stop.
3750 (reseat): Don't look for prev_stop, as that could mean a very long
3751 run.
3752 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3753 <cached_disp_overlay_modiff>: Cache for last found display string
3754 position.
551918c1 3755 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3756 about the same buffer in the same area of character positions, and
3757 the buffer wasn't changed since the time the display string
3758 position was cached.
551918c1 3759
b2d0c91a
EZ
37602011-07-22 Eli Zaretskii <eliz@gnu.org>
3761
3762 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3763 is an integer, which is important for empty lines. (Bug#9149)
3764
043604ee
CY
37652011-07-22 Chong Yidong <cyd@stupidchicken.com>
3766
3767 * frame.c (Fmodify_frame_parameters): In tty case, update the
3768 default face if necessary (Bug#4238).
3769
da4adb04
CY
37702011-07-21 Chong Yidong <cyd@stupidchicken.com>
3771
3772 * editfns.c (Fstring_to_char): No need to explain what a character
3773 is in the docstring (Bug#6576).
3774
9abd0532
LMI
37752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3776
3777 * xml.c (parse_region): Make sure we always return a tree.
3778
36881d16
HK
37792011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3780
3781 * xml.c (parse_region): If a document contains only comments,
3782 return that, too.
3783
1e98674d
LMI
37842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3785
3786 * xml.c (make_dom): Return comments, too.
3787
590bd467
PE
37882011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3789
3790 Port to OpenBSD.
3791 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3792 and the surrounding thread.
3793 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3794 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3795 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3796 timer goes off.
3797 * s/openbsd.h (BROKEN_SIGIO): Define.
3798 * unexelf.c (unexec) [__OpenBSD__]:
3799 Don't update the .mdebug section of the Alpha COFF symbol table.
3800
f41628b2
LMI
38012011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3802
3803 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3804 (bug#8460).
3805
b59b67c5
PE
38062011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3807
15e3a074
PE
3808 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3809 This fixes some race conditions on the permissions of any newly
3810 created file.
3811
41bed37d
PE
3812 * alloc.c (valid_pointer_p): Use pipe, not open.
3813 This fixes some permissions issues when debugging.
3814
b59b67c5
PE
3815 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3816 If fchown fails to set both uid and gid, try to set just gid,
3817 as that is sometimes allowed. Adjust the file's mode to eliminate
3818 setuid or setgid bits that are inappropriate if fchown fails.
3819
925a6be7
SM
38202011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3821
3822 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3823 to compare Lisp_Objects.
3824 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3825 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3826 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3827
52968808
AS
38282011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3829
0a6a104b
AS
3830 * lread.c (read_integer): Unread even EOF character.
3831 (read1): Likewise. Properly record start position of symbol.
3832
52968808
AS
3833 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3834 symbol character follows.
3835
9e381cdd
PE
38362011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3837
3838 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3839 This works around a problem with the previous change to Fcopy_file.
3840 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3841 and without this change, GCC might complain about discarding
3842 fchown's return value.
3843
b5641435
JB
38442011-07-16 Juanma Barranquero <lekktu@gmail.com>
3845
3846 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3847
a8031457
PE
38482011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3851
dd889327
LMI
38522011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3853
750c33f7
LMI
3854 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3855 it's used from the C level.
3856
dd889327
LMI
3857 * process.c: Use the same condition for POLL_FOR_INPUT in both
3858 keyboard.c and process.c (bug#1858).
3859
87e86684
LM
38602011-07-09 Lawrence Mitchell <wence@gmx.li>
3861
3862 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3863 (Fgnutls_boot): Use it.
3864
64348f40
AS
38652011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3866
3867 * doc.c (Fsubstitute_command_keys): Revert last change.
3868
1d698799
LMI
38692011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3870
f863868c
LMI
3871 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3872 quotes the next character, and doesn't affect other longer
3873 sequences (bug#8935).
3874
1d698799
LMI
3875 * lread.c (syms_of_lread): Clarify that is isn't only
3876 `eval-buffer' and `eval-defun' that's affected by
3877 `lexical-binding' (bug#8460).
3878
aa4b6df6
EZ
38792011-07-15 Eli Zaretskii <eliz@gnu.org>
3880
3881 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3882 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3883
5d856da6
PE
38842011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3885
ad6042bb
PE
3886 Fix minor problems found by static checking.
3887 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3888 (elsz): Now a signed constant, not a size_t var. We prefer signed
3889 types to unsigned, to avoid integer comparison confusion. Without
3890 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3891 "cannot optimize loop, the loop counter may overflow", a symptom
3892 of the confusion.
f00bbb22 3893 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3894 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3895
6468f31c
LMI
38962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3897
49080b10
LMI
3898 * search.c (Fre_search_backward): Mention `case-fold-search' in
3899 all the re_search_* functions (bug#8138).
3900
6468f31c
LMI
3901 * keyboard.c (Fopen_dribble_file): Document when the file is
3902 closed (bug#8056).
3903
c965adc5
EZ
39042011-07-14 Eli Zaretskii <eliz@gnu.org>
3905
df9733bf
EZ
3906 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3907 bidi_cache_idx.
3908
0bb23927
EZ
3909 Support bidi reordering of display and overlay strings.
3910 * xdisp.c (compute_display_string_pos)
3911 (compute_display_string_end): Accept additional argument STRING.
3912 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3913 (reseat_to_string): Initialize bidi_it->string.s and
3914 bidi_it->string.schars.
3915 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3916 NULL (avoids a crash in bidi_paragraph_init).
3917 Initialize itb.string.lstring.
0bb23927
EZ
3918 (init_iterator): Call bidi_init_it only of a valid
3919 buffer position was specified. Initialize paragraph_embedding to
3920 L2R.
3921 (reseat_to_string): Initialize the bidi iterator.
3922 (display_string): If we need to ignore text properties of
3923 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3924 original value of -1 will not work with bidi.)
3925 (compute_display_string_pos): First arg is now struct
3926 `text_pos *'; all callers changed. Support display properties on
3927 Lisp strings.
3928 (compute_display_string_end): Support display properties on Lisp
3929 strings.
3930 (init_iterator, reseat_1, reseat_to_string): Initialize the
3931 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3932 when iterating on a string not from display properties).
640c8776
SM
3933 (compute_display_string_pos, compute_display_string_end):
3934 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3935 arrow keys.
3936 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3937 base_level_stop; instead, set base_level_stop to BEGV.
3938 Fixes crashes in vertical-motion.
0bb23927
EZ
3939 (next_element_from_buffer): Improve commentary for when
3940 the iterator is before prev_stop.
3941 (init_iterator): Initialize bidi_p from the default value of
3942 bidi-display-reordering, not from buffer-local value. Use the
3943 buffer-local value only if initializing for buffer iteration.
3944 (handle_invisible_prop): Support invisible properties on strings
3945 that are being bidi-reordered.
3946 (set_iterator_to_next): Support bidi reordering of C strings and
3947 Lisp strings.
3948 (next_element_from_string): Support bidi reordering of Lisp
3949 strings.
3950 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3951 (display_string): Support display of R2L glyph rows.
3952 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3953 (init_iterator): Don't initialize it->bidi_p for strings
3954 here.
3955 (reseat_to_string): Initialize it->bidi_p for strings here.
3956 (next_element_from_string, next_element_from_c_string)
3957 (next_element_from_buffer): Add xassert's for correspondence
3958 between IT's object being iterated and it->bidi_it.string
3959 structure.
3960 (face_before_or_after_it_pos): Support bidi iteration.
3961 (next_element_from_c_string): Handle the case of the first string
3962 character that is not the first one in the visual order.
3963 (get_visually_first_element): New function, refactored from common
3964 parts of next_element_from_buffer, next_element_from_string, and
3965 next_element_from_c_string.
3966 (tool_bar_lines_needed, redisplay_tool_bar)
3967 (display_menu_bar): Force left-to-right direction. Add a FIXME
3968 comment for making that be controlled by a user option.
3969 (push_it, pop_it): Save and restore the state of the
3970 bidi iterator. Save and restore the bidi_p flag.
3971 (pop_it): Iterate out of display property for string iteration as
3972 well.
3973 (iterate_out_of_display_property): Support iteration over strings.
3974 (handle_single_display_spec): Set up it->bidi_it for iteration
3975 over a display string, and call bidi_init_it.
3976 (handle_single_display_spec, next_overlay_string)
3977 (get_overlay_strings_1, push_display_prop): Set up the bidi
3978 iterator for displaying display or overlay strings.
3979 (forward_to_next_line_start): Don't use the shortcut if
3980 bidi-iterating.
3981 (back_to_previous_visible_line_start): If handle_display_prop
3982 pushed the iterator stack, restore the internal state of the bidi
3983 iterator by calling bidi_pop_it same number of times.
3984 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3985 and we are bidi-iterating, don't decrement the iterator position;
3986 instead, set the first_elt flag in the bidi iterator, to produce
3987 the same effect.
3988 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3989 (push_display_prop): xassert that we are iterating a buffer.
3990 (push_it, pop_it): Save and restore paragraph_embedding member.
3991 (handle_single_display_spec, next_overlay_string)
3992 (get_overlay_strings_1, reseat_1, reseat_to_string)
3993 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3994 correctly. Don't assume unibyte strings are not bidi-reordered.
3995 (compute_display_string_pos)
3996 (compute_display_string_end): Fix handling the case of C string.
3997 (push_it, pop_it): Save and restore from_disp_prop_p.
3998 (handle_single_display_spec, push_display_prop): Set the
3999 from_disp_prop_p flag.
4000 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4001 (pop_it): Call iterate_out_of_display_property only if we are
4002 popping after iteration over a string that came from a display
4003 property. Fix a typo in popping stretch info. Add an assertion
4004 for verifying that the iterator position is in sync with the bidi
4005 iterator.
4006 (handle_single_display_spec, get_overlay_strings_1)
4007 (push_display_prop): Fix initialization of paragraph direction for
4008 string when that of the parent object is not yet determined.
4009 (reseat_1): Call bidi_init_it to resync the bidi
4010 iterator with IT's position. (Bug#7616)
4011 (find_row_edges): If ROW->start.pos gives position
4012 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4013 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4014 Reset the from_disp_prop_p flag.
4015 (SAVE_IT, RESTORE_IT): New macros.
4016 (pos_visible_p, face_before_or_after_it_pos)
4017 (back_to_previous_visible_line_start)
4018 (move_it_in_display_line_to, move_it_in_display_line)
4019 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4020 (try_scrolling, redisplay_window, display_line): Use them when
4021 saving a temporary copy of the iterator and restoring it back.
4022 (back_to_previous_visible_line_start, reseat_1)
4023 (init_iterator): Empty the bidi cache "stack".
4024 (move_it_in_display_line_to): If iterator ended up at
4025 EOL, but we never saw any buffer positions smaller than
4026 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4027 motion in bidi-reordered lines.
4028 (move_it_in_display_line_to): Record prev_method and prev_pos
4029 immediately before the call to set_iterator_to_next. Fixes cursor
4030 motion in bidi-reordered lines with stretch glyphs and strings
4031 displayed in margins. (Bug#8133) (Bug#8867)
4032 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4033 TO_CHARPOS.
640c8776
SM
4034 (pos_visible_p): Support positions in bidi-reordered lines.
4035 Save and restore bidi cache.
0bb23927
EZ
4036
4037 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4038 (bidi_paragraph_info): Delete unused struct.
4039 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4040 (bidi_cache_start): New variable.
4041 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4042 to zero.
4043 (bidi_cache_fetch_state, bidi_cache_search)
4044 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4045 (bidi_cache_find, bidi_peek_at_next_level)
4046 (bidi_level_of_next_char, bidi_find_other_level_edge)
4047 (bidi_move_to_visually_next): Compare cache index with
4048 bidi_cache_start rather than with zero.
4049 (bidi_fetch_char): Accept new argument STRING; all callers
4050 changed. Support iteration over a string. Support strings with
4051 display properties. Support unibyte strings. Fix the type of
4052 `len' according to what STRING_CHAR_AND_LENGTH expects.
4053 (bidi_paragraph_init, bidi_resolve_explicit_1)
4054 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4055 (bidi_level_of_next_char, bidi_move_to_visually_next):
4056 Support iteration over a string.
0bb23927
EZ
4057 (bidi_set_sor_type, bidi_resolve_explicit_1)
4058 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4059 can now be zero (for strings); special values 0 and -1 were
4060 changed to -1 and -2, respectively.
4061 (bidi_char_at_pos): New function.
4062 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4063 Call it instead of FETCH_MULTIBYTE_CHAR.
4064 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4065 initialized to valid values.
4066 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4067 values.
4068 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4069 the test for valid cached positions. Fix the logic for looking up
4070 the sentinel state in the cache. GCPRO the Lisp string we are
4071 iterating.
4072 (bidi_push_it, bidi_pop_it): New functions.
4073 (bidi_initialize): Initialize the bidi cache start stack pointer.
4074 (bidi_cache_ensure_space): New function, refactored from part of
4075 bidi_cache_iterator_state. Don't assume the required size is just
4076 one BIDI_CACHE_CHUNK away.
4077 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4078 (bidi_count_bytes, bidi_char_at_pos): New functions.
4079 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4080 always valid if bidi_cache_idx is valid.
4081 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4082 is valid if it's going to be used.
4083 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4084 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4085 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4086 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4087 (bidi_find_other_level_edge, bidi_cache_start_stack):
4088 All variables related to cache indices are now EMACS_INT.
c965adc5 4089
0bb23927
EZ
4090 * dispextern.h (struct bidi_string_data): New structure.
4091 (struct bidi_it): New member `string'. Make flag members be 1-bit
4092 fields, and put them last in the struct.
640c8776
SM
4093 (compute_display_string_pos, compute_display_string_end):
4094 Update prototypes.
0bb23927
EZ
4095 (bidi_push_it, bidi_pop_it): Add prototypes.
4096 (struct iterator_stack_entry): New members bidi_p,
4097 paragraph_embedding, and from_disp_prop_p.
4098 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4099 (bidi_shelve_cache, bidi_unshelve_cache):
4100 Declare prototypes.
0bb23927
EZ
4101
4102 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4103 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4104 and vector-like objects.
4105
4106 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4107 cache around display iteration.
4108
4109 * window.c (Fwindow_end, window_scroll_pixel_based)
4110 (displayed_window_lines, Frecenter): Save and restore the bidi
4111 cache around display iteration.
4112
3bbd2265
LMI
41132011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4114
4115 * editfns.c (Fdelete_region): Clarify the use of the named
4116 parameters (bug#6788).
4117
adc47434
MR
41182011-07-14 Martin Rudalics <rudalics@gmx.at>
4119
4120 * indent.c (Fvertical_motion): Set and restore w->pointm when
4121 saving and restoring the window's buffer (Bug#9006).
4122
837c31f8
LMI
41232011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4124
4125 * editfns.c (Fstring_to_char): Clarify just what is returned
4126 (bug#6576). Text by Eli Zaretskii.
4127
ac389d0c
JB
41282011-07-13 Juanma Barranquero <lekktu@gmail.com>
4129
4130 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4131
0be0ce47
EZ
41322011-07-13 Eli Zaretskii <eliz@gnu.org>
4133
4134 * buffer.c (mmap_find): Fix a typo.
4135
cd18e7e3
JB
41362011-07-13 Johan Bockgård <bojohan@gnu.org>
4137
4138 Fix execution of x selection hooks.
4139 * xselect.c (Qx_lost_selection_functions)
4140 (Qx_sent_selection_functions): New vars.
4141 (syms_of_xselect): DEFSYM them.
4142 (x_handle_selection_request): Pass Qx_sent_selection_functions
4143 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4144 (x_handle_selection_clear,x_clear_frame_selections):
4145 Pass Qx_lost_selection_functions rather than
4146 Vx_lost_selection_functions to Frun_hook_with_args.
4147
47ea7f44
PE
41482011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4149
ac389d0c 4150 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4151 The old code sometimes used this field without initializing it.
4152
47ea7f44
PE
4153 * alloc.c (gc_sweep): Don't read past end of array.
4154 In theory, the old code could also have corrupted Emacs internals,
4155 though it'd be very unlikely.
4156
bc985c87
AS
41572011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4158
4159 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4160 argument. (Bug#4026)
bc985c87 4161
0cf34688
LMI
41622011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4163
b3dadd76
LMI
4164 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4165 key" (bug#4257).
4166
0cf34688
LMI
4167 * window.c (Fset_window_start): Doc fix (bug#4199).
4168 (Fset_window_hscroll): Ditto.
4169
270768cd
PE
41702011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4171
077e3dda 4172 Fix minor new problems caught by GCC 4.6.1.
270768cd 4173 * term.c (init_tty): Remove unused local.
490011a6 4174 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4175 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4176 not used otherwise.
270768cd 4177
b1f58454
CY
41782011-07-12 Chong Yidong <cyd@stupidchicken.com>
4179
4180 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4181
22b9578d
LMI
41822011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4183
6e70ab07
LMI
4184 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4185 are the mini-buffer and the echo area (bug#3320).
4186
22b9578d
LMI
4187 * term.c (init_tty): Remove support for supdup, c10 and perq
4188 terminals, which are no longer supported (bug#1482).
4189
8974cc9f
JB
41902011-07-10 Johan Bockgård <bojohan@gnu.org>
4191
4192 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4193
a560d974
JD
41942011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4195
4196 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4197 for non-popups (Bug#3642).
4198
1dae0f0a
AS
41992011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4200
268c2c36 4201 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4202 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4203 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4204 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4205 * data.c (fmod): Likewise.
4206 * dispnew.c (swap_glyphs_in_rows): Likewise.
4207 * emacs.c (memory_warning_signal): Likewise.
4208 * floatfns.c (float_error): Likewise.
4209 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4210 (otf_open, font_otf_capability, generate_otf_features)
4211 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4212 Likewise.
4213 * image.c (pbm_read_file): Likewise.
4214 * indent.c (string_display_width): Likewise.
4215 * intervals.c (check_for_interval, search_for_interval)
4216 (inc_interval_count, count_intervals, root_interval)
4217 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4218 * lread.c (defalias): Likewise.
268c2c36 4219 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4220 * regex.c (set_image_of_range_1, set_image_of_range)
4221 (regex_grow_registers): Likewise.
4222 * sysdep.c (strerror): Likewise.
4223 * termcap.c (valid_filename_p, tprint, main): Likewise.
4224 * tparam.c (main): Likewise.
4225 * unexhp9k800.c (run_time_remap, save_data_space)
4226 (update_file_ptrs, read_header, write_header, calculate_checksum)
4227 (copy_file, copy_rest, display_header): Likewise.
4228 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4229 Likewise.
4230 * xdisp.c (check_it): Likewise.
4231 * xfaces.c (register_color, unregister_color, unregister_colors):
4232 Likewise.
4233 * xfns.c (print_fontset_result): Likewise.
4234 * xrdb.c (member, fatal, main): Likewise.
4235
99033785
PE
42362011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4237
4238 Fix minor problems found by static checking (Bug#9031).
4239 * chartab.c (char_table_set_range, map_sub_char_table):
4240 Remove unused locals.
4241 (uniprop_table): Now static.
4242 * composite.c (_work_char): Remove unused static var.
4243
9cb2ac56
JB
42442011-07-09 Juanma Barranquero <lekktu@gmail.com>
4245
4246 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4247
f25661f0
JD
42482011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4249
4250 * gtkutil.c (qttip_cb): Remove code without function.
4251
8278c4fe
EZ
42522011-07-09 Eli Zaretskii <eliz@gnu.org>
4253
4254 * w32.c (pthread_sigmask): New stub.
4255
1692ae2d 42562011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4257
8a6ebd58 4258 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4259 sigprocmask is portable only for single-threaded applications, and
4260 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4261 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4262 (LIBES): Use it.
4263 * callproc.c (Fcall_process):
4264 * process.c (create_process):
4265 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4266 Use pthread_sigmask, not sigprocmask.
123403e4 4267
1b854618
JD
42682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4269
4270 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4271 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4272 wrong (Bug#8591).
4273
3fe4b549
JD
42742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4275
0ce7e563
JD
4276 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4277 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4278 (xg_hide_tooltip): Fix comment.
4279
3fe4b549
JD
4280 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4281 in registerServicesMenuSendTypes.
4282 (validRequestorForSendType): Don't check ns_return_types.
4283
4284 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4285 ns_return_type.
4286
5df75e47
JR
42872011-07-08 Jason Rumney <jasonr@gnu.org>
4288
22610910
JR
4289 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4290 SH_SHOW for hidden windows (Bug#5482).
4291
5df75e47
JR
4292 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4293 frame struct members of non-existent frames (Bug#6284).
4294
699c10bd
JD
42952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4296
4393663b
JD
4297 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4298 variable firstTime not needed on OSX >= 10.6.
4299 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4300 >= 10.5. Use setKnobProportion, setDoubleValue.
4301
4302 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4303 (MAC_OS_X_VERSION_10_5): Define if not defined.
4304 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4305 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4306 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4307
4308 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4309 cString and lossyCString on OSX >= 10.4
4310
58179cce 4311 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4312 sizeToFit on OSX >= 10.2.
4313
4314 * nsimage.m (allocInitFromFile): Don't use deprecated method
4315 bestRepresentationForDevice on OSX >= 10.6.
4316
4317 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4318 to avoid warning.
4319
4320 * emacs.c: Declare unexec_init_emacs_zone.
4321
a63e0781
JD
4322 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4323
699c10bd
JD
4324 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4325
4326 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4327 on svcsMenu (Bug#8842).
4328
4329 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4330 ns_return_types.
4331 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4332
4333 * nsterm.m (QUTF8_STRING): Declare.
4334 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4335 (validRequestorForSendType): Return type is (id).
4336 Change indexOfObjectIdenticalTo to indexOfObject.
4337 Check if we have local selection before returning self (Bug#8842).
4338 (writeSelectionToPasteboard): Put local selection into paste board
4339 if we have a local selection (Bug#8842).
4340 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4341
4342 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4343 (ns_get_local_selection): Declare.
4344
54e10184
LMI
43452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4346
9888ff71
LMI
4347 * keymap.c (describe_map_tree): Don't insert a double newline at
4348 the end of the buffer (bug#1169) and return whether we inserted
4349 something.
4350
54e10184
LMI
4351 * callint.c (Fcall_interactively): Change "reading args" to
4352 "providing args" to try to clarify what it does (bug#1010).
4353
15fa4783
KH
43542011-07-07 Kenichi Handa <handa@m17n.org>
4355
4356 * composite.c (composition_compute_stop_pos): Ignore a static
4357 composition starting before CHARPOS (Bug#8915).
4358
4359 * xdisp.c (handle_composition_prop): Likewise.
4360
a8815b00
EZ
43612011-07-07 Eli Zaretskii <eliz@gnu.org>
4362
4363 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4364 (Bug#9015)
4365
ef7b981d 43662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4367
4368 * character.h (unicode_category_t): New enum type.
4369
4370 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4371 (Qchar_code_property_table): New variable.
4372 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4373 (UNIPROP_COMPRESSED_FORM_P): New macros.
4374 (char_table_ascii): Uncompress the compressed values.
4375 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4376 Uncompress the compressed values.
ac389d0c 4377 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4378 (char_table_ref_and_range): Uncompress the compressed values.
4379 (sub_char_table_set): New arg is_uniprop. Callers changed.
4380 Uncompress the compressed values.
4381 (sub_char_table_set_range): Args changed. Callers changed.
4382 (char_table_set_range): Adjuted for the above change.
4383 (map_sub_char_table): Delete args default_val and parent. Add arg
4384 top. Give decoded values to a Lisp function.
640c8776 4385 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4386 values to a Lisp function. Gcpro more variables.
4387 (uniprop_table_uncompress)
4388 (uniprop_decode_value_run_length): New functions.
4389 (uniprop_decoder, uniprop_decoder_count): New variables.
4390 (uniprop_get_decoder, uniprop_encode_value_character)
4391 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4392 New functions.
4393 (uniprop_encoder, uniprop_encoder_count): New variables.
4394 (uniprop_get_encoder, uniprop_table)
4395 (Funicode_property_table_internal, Fget_unicode_property_internal)
4396 (Fput_unicode_property_internal): New functions.
4397 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4398 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4399 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4400 char-code-property-alist.
4401
640c8776 4402 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4403 Vunicode_category_table.
4404
640c8776 4405 * font.c (font_range): Adjust for the change of
c805dec0
KH
4406 Vunicode_category_table.
4407
76b397fb
DN
44082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4409
4410 * m/iris4d.h: Remove file, move contents ...
4411 * s/irix6-5.h: ... here.
4412
22b4128e
PE
44132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4414
4415 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4416 * alloc.c (mark_buffer):
4417 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4418 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4419 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4420 This isn't true in general, and it's particularly not true
4421 if Emacs is configured with --with-wide-int.
4422 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4423 New macros, used in the buffer.c change.
4424
869795d6
JD
44252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4426
4427 * xsettings.c: Use both GConf and GSettings if both are available.
4428 (store_config_changed_event): Add comment.
4429 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4430 (store_tool_bar_style_changed): New functions.
5e617bc2 4431 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4432 (struct xsettings): Move font inside HAVE_XFT.
4433 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4434 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4435 Move inside HAVE_XFT.
640c8776 4436 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4437 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4438 also.
4439 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4440 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4441 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4442 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4443 (parse_settings): Move check for font inside HAVE_XFT.
4444 (read_settings, apply_xft_settings): Add comment.
4445 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4446 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4447 call store_font_name_changed.
4448 (xft_settings_event): Add comment.
4449 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4450 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4451 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4452 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4453 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4454 (xsettings_get_system_font, xsettings_get_system_normal_font):
4455 Add comment.
869795d6 4456
d8ed26bd
PE
44572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 Random fixes. E.g., (random) never returned negative values.
4460 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4461 subseconds part to the entropy, as that's a bit more random.
4462 Prefer signed to unsigned, since the signedness doesn't matter and
4463 in general we prefer signed. When given a limit, use a
4464 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4465 latter isn't right if USE_2_TAGS_FOR_INTS.
4466 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4467 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4468
cabf1cac
SM
44692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4470
4471 * textprop.c (text_property_stickiness):
4472 Obey Vtext_property_default_nonsticky.
4473 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4474 * w32fns.c (syms_of_w32fns):
4475 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4476
6e9b2be9
PE
44772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4478
4479 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4480 This is more efficient than Ffile_directory_p and avoids a minor race.
4481
90186c68
LMI
44822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4483
7c301272
LMI
4484 * buffer.c (Foverlay_put): Say what the return value is
4485 (bug#7835).
4486
c4f2d8d4
LMI
4487 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4488 is a directory before asking whether to use the file name
4489 (bug#7564).
ad637907
LMI
4490 (barf_or_query_if_file_exists): Make the "File is a directory"
4491 error be more correct.
c4f2d8d4 4492
90186c68
LMI
4493 * fns.c (Frequire): Remove the mention of the .gz files, since
4494 that's installation-specific, but keep the mention of
4495 `get-load-suffixes'.
4496
da64016e
PE
44972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4500 Report string overflow if the output is too long.
4501
7d47b580
JB
45022011-07-04 Juanma Barranquero <lekktu@gmail.com>
4503
a555cb87
JB
4504 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4505 (syms_of_gnutls): Remove duplicate DEFSYM for
4506 Qgnutls_bootprop_verify_hostname_error, an error for
4507 Qgnutls_bootprop_verify_error (which is no longer used).
4508
7d47b580
JB
4509 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4510 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4511 Also (re)move comments that are misplaced or no longer relevant.
4512
1e49bfab
LMI
45132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4514
4515 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4516
1485f4c0
CY
45172011-07-03 Chong Yidong <cyd@stupidchicken.com>
4518
4519 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4520 and background color parameters if they have been changed.
4521
a9ab721e
LMI
45222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4523
4524 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4525
cf7cff57
PE
45262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4527
2e13213d
PE
4528 * xsettings.c (SYSTEM_FONT): Define only when used.
4529 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4530
cf7cff57
PE
4531 * keymap.c (access_keymap_1): Now static.
4532
7a8e04f7
CY
45332011-07-02 Chong Yidong <cyd@stupidchicken.com>
4534
4535 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4536 leave any prefix arg for the up event (Bug#1586).
4537
61352f62
LMI
45382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4539
69bb1ef7
LMI
4540 * lread.c (syms_of_lread): Mention single symbols defined by
4541 `defvar' or `defconst' (bug#7154).
4542
61352f62 4543 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4544 (Frequire): Mention get-load-suffixes.
61352f62 4545
28545e04
MR
45462011-07-02 Martin Rudalics <rudalics@gmx.at>
4547
4548 * window.h (window): Remove clone_number slot.
4549 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4550 Remove.
4551 (make_parent_window, make_window, saved_window)
4552 (Fset_window_configuration, save_window_save): Don't deal with
4553 clone numbers.
4554 * buffer.c (Qclone_number): Remove declaration.
4555 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4556
3349e122
SM
45572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4558
4559 Add multiple inheritance to keymaps.
4560 * keymap.c (Fmake_composed_keymap): New function.
4561 (Fset_keymap_parent): Simplify.
4562 (fix_submap_inheritance): Remove.
4563 (access_keymap_1): New function extracted from access_keymap to handle
4564 embedded parents and handle lists of maps.
4565 (access_keymap): Use it.
4566 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4567 (Fcopy_keymap): Handle embedded parents.
4568 (Fcommand_remapping, define_as_prefix): Simplify.
4569 (Fkey_binding): Simplify.
4570 (syms_of_keymap): Move minibuffer-local-completion-map,
4571 minibuffer-local-filename-completion-map,
4572 minibuffer-local-must-match-map, and
4573 minibuffer-local-filename-must-match-map to Elisp.
4574 (syms_of_keymap): Defsubr make-composed-keymap.
4575 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4576 (parse_menu_item): Trivial simplification.
4577
3279eb87
GM
45782011-07-01 Glenn Morris <rgm@gnu.org>
4579
4580 * Makefile.in (SETTINGS_LIBS): Fix typo.
4581
4550efdf
KI
45822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4583
4584 * coding.c (Fencode_coding_string): Record the last coding system
4585 used, as the function doc string says (bug#8738).
4586
0949d2b6
JD
45872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4588
4589 * xsettings.c (store_monospaced_changed): Take new font as arg and
4590 check for change against current_mono_font.
4591 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4592 (emacs_settings_constructor, emacs_settings_get_property)
4593 (emacs_settings_set_property, emacs_settings_class_init)
4594 (emacs_settings_init, gsettings_obj): Remove.
4595 (something_changedCB): New function for HAVE_GSETTINGS.
4596 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4597 with value as argument.
4598 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4599 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4600 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4601 "changed".
4602
4603 * xgselect.c: Add defined (HAVE_GSETTINGS).
4604 (xgselect_initialize): Ditto.
4605
4606 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4607 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4608 xg_select.
4609
bbc6b304
PE
46102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4611
4612 * eval.c (struct backtrace): Simplify and port the data structure.
4613 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4614 signed bit field, as this assumption is not portable and it makes
4615 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4616 "char debug_on_exit : 1" as this is not portable either; instead,
4617 use the portable "unsigned int debug_on_exit : 1". Remove unused
4618 member evalargs. Remove obsolete comments about cc bombing out.
4619
9851bfc5
JD
46202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4621
51bb811f 4622 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4623 Let HAVE_GSETTINGS override HAVE_GCONF.
4624 (store_monospaced_changed): New function.
4625 (EMACS_SETTINGS): A new type derived from GObject to handle
4626 GSettings notifications.
4627 (emacs_settings_constructor, emacs_settings_get_property)
4628 (emacs_settings_set_property, emacs_settings_class_init):
4629 New functions.
4630 (gsettings_client, gsettings_obj): New variables.
4631 (GSETTINGS_SCHEMA): New define.
4632 (something_changedCB): Call store_monospaced_changed.
4633 (init_gsettings): New function.
4634 (xsettings_initialize): Call init_gsettings.
4635 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4636 to NULL.
4637
640c8776 4638 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4639 GCONF_CFLAGS/LIBS.
4640
5386012d
MR
46412011-06-29 Martin Rudalics <rudalics@gmx.at>
4642
4643 * window.c (resize_root_window, grow_mini_window)
4644 (shrink_mini_window): Rename Qresize_root_window to
4645 Qwindow_resize_root_window and Qresize_root_window_vertically to
4646 Qwindow_resize_root_window_vertically.
4647
f13e0b08
PE
46482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4649
4650 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4651
94515237
JB
46522011-06-27 Juanma Barranquero <lekktu@gmail.com>
4653
4654 * makefile.w32-in: Redesign dependencies so they reflect more
4655 clearly which files are directly included by each source file,
4656 and not through other includes.
4657
e43b6e43
MR
46582011-06-27 Martin Rudalics <rudalics@gmx.at>
4659
4660 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4661 (sort_overlays, overlay_strings): When an overlay's clone number
4662 matches the window's clone number process the overlay even if
4663 the overlay's window property doesn't match the current window.
4664
d68443dc
MR
4665 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4666 (Fwindow_hchild): Rename to Fwindow_left_child.
4667 (Fwindow_next): Rename to Fwindow_next_sibling.
4668 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4669 (resize_window_check): Rename to window_resize_check.
4670 (resize_window_apply): Rename to window_resize_apply.
4671 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4672 (Fdelete_other_windows_internal, resize_frame_windows)
4673 (Fsplit_window_internal, Fdelete_window_internal)
4674 (grow_mini_window, shrink_mini_window)
4675 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4676
c7e73be5
JD
46772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4678
4679 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4680 (emacs_fixed_set_min_size): Remove.
4681 (emacs_fixed_new): Take frame as argument.
4682
4683 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4684 (_EmacsFixedPrivate): Remove minwidth/height.
4685 Add struct frame *f.
4686 (emacs_fixed_init): Initialize priv->f.
4687 (get_parent_class, emacs_fixed_set_min_size): Remove.
4688 (emacs_fixed_new): Set priv->f to argument.
4689 (emacs_fixed_get_preferred_width)
4690 (emacs_fixed_get_preferred_height): Use min_width/height from
4691 frames size_hint to set minimum and natural (Bug#8919).
4692 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4693 and use min_width/height from frames size_hint to set
4694 min_width/height (Bug#8919).
4695
4696 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4697 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4698 Fix indentation.
c7e73be5 4699
cf99dcf8
EZ
47002011-06-26 Eli Zaretskii <eliz@gnu.org>
4701
4702 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4703 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4704 called at ZV.
4705
029529ac
CY
47062011-06-26 Chong Yidong <cyd@stupidchicken.com>
4707
4708 * process.c (wait_reading_process_output): Bypass select if
4709 waiting for a cell while ignoring keyboard input, and input is
4710 pending. Suggested by Jan Djärv (Bug#8869).
4711
7a7ef429
PE
47122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4713
4714 Use gnulib's dup2 module instead of rolling our own.
4715 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4716
11fdef7d 47172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4718
4719 * dispnew.c (scrolling_window): Before scrolling, turn off a
4720 mouse-highlight in the window being scrolled.
4721
cd3520a4
JB
47222011-06-24 Juanma Barranquero <lekktu@gmail.com>
4723
4724 Move DEFSYM to lisp.h and use everywhere.
4725
4726 * character.h (DEFSYM): Move declaration...
4727 * lisp.h (DEFSYM): ...here.
4728
4729 * gnutls.c:
4730 * minibuf.c:
4731 * w32menu.c:
4732 * w32proc.c:
4733 * w32select.c: Don't include character.h.
4734
4735 * alloc.c (syms_of_alloc):
4736 * buffer.c (syms_of_buffer):
4737 * bytecode.c (syms_of_bytecode):
4738 * callint.c (syms_of_callint):
4739 * casefiddle.c (syms_of_casefiddle):
4740 * casetab.c (init_casetab_once):
4741 * category.c (init_category_once, syms_of_category):
4742 * ccl.c (syms_of_ccl):
4743 * cmds.c (syms_of_cmds):
4744 * composite.c (syms_of_composite):
4745 * dbusbind.c (syms_of_dbusbind):
4746 * dired.c (syms_of_dired):
4747 * dispnew.c (syms_of_display):
4748 * doc.c (syms_of_doc):
4749 * editfns.c (syms_of_editfns):
4750 * emacs.c (syms_of_emacs):
4751 * eval.c (syms_of_eval):
4752 * fileio.c (syms_of_fileio):
4753 * fns.c (syms_of_fns):
4754 * frame.c (syms_of_frame):
4755 * fringe.c (syms_of_fringe):
4756 * insdel.c (syms_of_insdel):
4757 * keymap.c (syms_of_keymap):
4758 * lread.c (init_obarray, syms_of_lread):
4759 * macros.c (syms_of_macros):
4760 * msdos.c (syms_of_msdos):
4761 * print.c (syms_of_print):
4762 * process.c (syms_of_process):
4763 * search.c (syms_of_search):
4764 * sound.c (syms_of_sound):
4765 * syntax.c (init_syntax_once, syms_of_syntax):
4766 * terminal.c (syms_of_terminal):
4767 * textprop.c (syms_of_textprop):
4768 * undo.c (syms_of_undo):
4769 * w32.c (globals_of_w32):
4770 * window.c (syms_of_window):
4771 * xdisp.c (syms_of_xdisp):
4772 * xfaces.c (syms_of_xfaces):
4773 * xfns.c (syms_of_xfns):
4774 * xmenu.c (syms_of_xmenu):
4775 * xsettings.c (syms_of_xsettings):
4776 * xterm.c (syms_of_xterm): Use DEFSYM.
4777
4228cf16
TZ
47782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4779
cd3520a4 4780 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4781
7fcccf1e
PE
47822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4783
7efb4e0e
PE
4784 Integer and buffer overflow fixes (Bug#8873).
4785
ff5844ad
PE
4786 * print.c (printchar, strout): Check for string overflow.
4787 (PRINTPREPARE, printchar, strout):
4788 Don't set size unless allocation succeeds.
4789
90532f02
PE
4790 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4791 for sizes. Check for string overflow more accurately.
4792 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4793
6d84508d
PE
4794 * macros.c: Integer and buffer overflow fixes.
4795 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4796 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4797 Use ptrdiff_t, not int, for sizes.
4798 Don't increment bufsize until after realloc succeeds.
4799 Check for size-calculation overflow.
4800 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4801
437b2cb4
PE
4802 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4803
8b9ac8b4
PE
4804 * lread.c: Integer overflow fixes.
4805 (read_integer): Radix is now EMACS_INT, not int,
4806 to improve quality of diagnostics for out-of-range radices.
4807 Calculate buffer size correctly for out-of-range radices.
4808 (read1): Check for integer overflow in radices, and in
4809 read-circle numbers.
82cb60d3
PE
4810 (read_escape): Avoid int overflow.
4811 (Fload, openp, read_buffer_size, read1)
4812 (substitute_object_recurse, read_vector, read_list, map_obarray):
4813 Use ptrdiff_t, not int, for sizes.
4814 (read1): Use EMACS_INT, not int, for sizes.
20270765 4815 Check for size overflow.
8b9ac8b4 4816
7fcccf1e
PE
4817 * image.c (cache_image): Check for size arithmetic overflow.
4818
bfbbd7e7
PE
4819 * lread.c: Integer overflow issues.
4820 (saved_doc_string_size, saved_doc_string_length)
4821 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4822 Now ptrdiff_t, not int.
4823 (read1): Don't assume doc string length fits in int. Check for
4824 out-of-range doc string lengths.
4825 (read_list): Don't assume file position fits in int.
39019e54 4826 (read_escape): Check for hex character overflow.
bfbbd7e7 4827
4e323265
LL
48282011-06-22 Leo Liu <sdl.web@gmail.com>
4829
4830 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4831 Move to minibuffer.el.
4832
85fece3e
PE
48332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4834
20b84ce9 4835 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4836 The following patches are for when GLYPH_DEBUG && !XASSERT.
4837 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4838 * dispnew.c (flush_stdout):
4839 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4840 Mark as externally visible.
4841 * dispnew.c (check_window_matrix_pointers): Now static.
4842 * dispnew.c (window_to_frame_vpos):
4843 * xfns.c (unwind_create_frame):
4844 * xterm.c (x_check_font): Remove unused local.
4845 * scroll.c (CHECK_BOUNDS):
4846 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4847 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4848 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4849 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4850 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4851 Now static.
4852 (debug_method_add): Use va_list and vsprintf rather than relying
4853 on undefined behavior with wrong number of arguments.
4854 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4855 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4856 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4857 since we're not interested in debugging glyphs with old libraries.
4858 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4859 GCC 4.6.0's static checking.
4860
0766b489
PE
48612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4862
31fd4b32
PE
4863 Integer overflow and signedness fixes (Bug#8873).
4864 A few related buffer overrun fixes, too.
4865
b79e8648
PE
4866 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4867
0766b489
PE
4868 * dispextern.h (struct face.stipple):
4869 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4870 (x_bitmap_mask, x_allocate_bitmap_record)
4871 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4872 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4873 (x_create_bitmap_from_xpm_data):
4874 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4875 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4876 (.bitmaps_last):
4877 * xfaces.c (load_pixmap):
4878 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4879 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4880 (.bitmaps_last, struct x_output.icon_bitmap):
4881 Use ptrdiff_t, not int, for bitmap indexes.
4882 (x_allocate_bitmap_record): Check for size overflow.
4883 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4884
b081724f
PE
4885 Use ptrdiff_t, not int, for overlay counts.
4886 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4887 * editfns.c (overlays_around, get_pos_property):
4888 * textprop.c (get_char_property_and_overlay):
4889 * xdisp.c (next_overlay_change, note_mouse_highlight):
4890 * xfaces.c (face_at_buffer_position):
21514da7
PE
4891 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4892 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4893 (Fnext_overlay_change, Fprevious_overlay_change)
4894 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4895 Use ptrdiff_t, not int, for sizes.
21514da7 4896 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4897
3de73e5e
PE
4898 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4899
2606c57b
PE
4900 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4901 (x_session_initialize): Do not assume string length fits in int.
4902
aaafe47a
PE
4903 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4904 This is unlikely, but can occur if DPI is outlandish.
4905
2674ddc8 4906 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4907 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4908
28154962
PE
4909 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4910 * xrdb.c (magic_file_p, search_magic_path):
4911 Omit last arg SUFFIX; it was always 0. All callers changed.
4912 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4913
7de51af5
PE
4914 * xfont.c (xfont_match): Avoid need for strlen.
4915
25ed6cc3
PE
4916 * xfns.c: Don't assume strlen fits in int.
4917 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4918
4eab31dd
PE
4919 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4920 not unsigned long, as we prefer signed integers. All callers changed.
4921 Detect integer overflow in repeat count.
4922 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4923 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4924
171e2a58
PE
4925 * termcap.c: Don't assume sizes fit in int and never overflow.
4926 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4927 (gobble_line): Check for size-calculation overflow.
4928
ad39faca 4929 * minibuf.c (Fread_buffer):
6e5bb2dc 4930 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4931 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4932 Don't assume string length fits in int.
4933
52c61c22 4934 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4935 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4936
b5b8c9e5
PE
4937 * font.c: Don't assume string length fits in int.
4938 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4939 Use ptrdiff_t, not int.
ccd6111c
PE
4940 (font_intern_prop): Don't assume string length fits in int.
4941 Don't assume integer property fits in fixnum.
4942 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4943
882f0d81 4944 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4945 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4946 Reformulate so as not to need the command string.
4947 Invoke gzip -cd rather than gunzip, as it's more portable.
4948 (lock_info_type, lock_file_1, lock_file):
4949 Don't assume pid_t and time_t fit in unsigned long.
4950 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4951 (current_lock_owner): Prefer signed type for sizes.
4952 Use memcpy, not strncpy, where memcpy is what is really wanted.
4953 Don't assume (via atoi) that time_t and pid_t fit in int.
4954 Check for time_t and/or pid_t out of range, e.g., via a network share.
4955 Don't alloca where an auto var works fine.
4956
93f4cf88
PE
4957 * fileio.c: Fix some integer overflow issues.
4958 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4959 Don't assume string length fits in int.
4960 (directory_file_name): Don't assume string length fits in long.
4961 (make_temp_name): Don't assume pid fits in int, or that its print
4962 length is less than 20.
4963
f3e92b69
PE
4964 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4965
1bfdaf10
PE
4966 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4967
35016e9a
PE
4968 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4969
3d1e65a1
PE
4970 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4971 We prefer signed integers, even for size calculations.
4972
0b963a93
PE
4973 * emacs.c: Don't assume string length fits in 'int'.
4974 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4975 (main): Don't invoke strlen when not needed.
4976
573f4b54
PE
4977 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4978 (XD_DEBUG_MESSAGE): Don't waste a byte.
4979
989f33ba
PE
4980 * callproc.c (getenv_internal_1, getenv_internal)
4981 (Fgetenv_internal):
965d34eb
PE
4982 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4983
e4d29b33
PE
4984 * lread.c (invalid_syntax): Omit length argument.
4985 All uses changed. This doesn't fix a bug, but it simplifies the
4986 code away from its former Hollerith-constant appearance, and it's
4987 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4988 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4989
eb49b136
PE
4990 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4991 This didn't break anything, but it didn't help either.
4992 It's confusing to put a bogus integer in a place where the actual
4993 value does not matter.
9f62aeb1 4994 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4995 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4996
15375a22
PE
4997 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4998 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4999 implementation.
b61cc01c
PE
5000 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5001 We prefer signed types, and the value cannot exceed the EMACS_INT
5002 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5003 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5004 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5005 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5006
53b2623d
PE
5007 * indent.c (sane_tab_width): New function.
5008 (current_column, scan_for_column, Findent_to, position_indentation)
5009 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5010 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5011
51cab52b 5012 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5013
f2ed8a70
PE
5014 * lisp.h (lint_assume): New macro.
5015 * composite.c (composition_gstring_put_cache):
5016 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5017
abe80cc6
PE
5018 * editfns.c, insdel.c:
5019 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5020
b02c740e
PE
5021 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5022
ebc96716
PE
5023 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5024
b4e50fa0 5025 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5026 Use much-faster test for byte-length change.
311d5d7c 5027 Don't assume string byte-length fits in 'int'.
a4cf38e4 5028 Check that character arg fits in 'int'.
85461888 5029 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5030
c0c1ee9f
PE
5031 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5032
a498d7f4
PE
5033 * fns.c (concat): Catch string overflow earlier.
5034 Do not rely on integer wraparound.
5035
51cab52b
PE
5036 * dispextern.h (struct it.overlay_strings_charpos)
5037 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5038 * xdisp.c (forward_to_next_line_start)
5039 (back_to_previous_visible_line_start)
5040 (reseat_at_next_visible_line_start, next_element_from_buffer):
5041 Don't arbitrarily truncate the value of 'selective' to int.
5042
76031fad
PE
5043 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5044
5eb55db9
PE
5045 * composite.c: Don't truncate sizes to 'int'.
5046 (composition_gstring_p, composition_reseat_it)
5047 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5048 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5049 not EMACS_UINT, for indexes.
5eb55db9 5050
0703a717
PE
5051 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5052
d6202519
PE
5053 * buffer.c: Include <verify.h>.
5054 (struct sortvec.priority, struct sortstr.priority):
8961a454 5055 Now EMACS_INT, not int.
c20998a7 5056 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5057 (struct sortstr.size, record_overlay_string)
5058 (struct sortstrlist.size, struct sortlist.used):
5059 Don't truncate size to int.
5060 (record_overlay_string): Check for size-calculation overflow.
d6202519 5061 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5062
d5a19415
JM
50632011-06-22 Jim Meyering <meyering@redhat.com>
5064
029529ac 5065 Don't leak an XBM-image-sized buffer
d5a19415
JM
5066 * image.c (xbm_load): Free the image buffer after using it.
5067
a9041e6c
PE
50682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5069
5070 Port to Sun C.
5071 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5072 that Sun C diagnosed.
5073 * fns.c (secure_hash): Fix pointer signedness issue.
5074 * intervals.c (static_offset_intervals): New function.
5075 (offset_intervals): Use it.
5076
7f3f739f
LL
50772011-06-21 Leo Liu <sdl.web@gmail.com>
5078
5079 * deps.mk (fns.o):
5080 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5081 sha512.h.
5082
5083 * fns.c (secure_hash): Rename from crypto_hash_function and change
5084 the first arg to accept symbols.
5b66d427 5085 (Fsecure_hash): New primitive.
7f3f739f
LL
5086 (syms_of_fns): New symbols.
5087
76147d94
DD
50882011-06-20 Deniz Dogan <deniz@dogan.se>
5089
5090 * process.c (Fset_process_buffer): Clarify return value in
5091 docstring.
5092
7d7d0045
CY
50932011-06-18 Chong Yidong <cyd@stupidchicken.com>
5094
5095 * dispnew.c (add_window_display_history): Use BVAR.
5096
5097 * xdisp.c (debug_method_add): Use BVAR.
5098 (check_window_end, dump_glyph_matrix, dump_glyph)
5099 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5100
5101 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5102 Likewise.
5103
5104 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5105 check till after the cache is created in init_frame_faces.
5106
ff2bc410
SM
51072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5108
5109 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5110
28177add
PE
51112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5112
dd3482fe
PE
5113 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5114 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5115 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5116
393d71f3 5117 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5118 * fileio.c (Finsert_file_contents):
5119 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5120 Remove the old (too-loose) buffer overflow checks.
5121 They weren't needed, since make_gap checks for buffer overflow.
5122 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5123 The old code merely checked for Emacs fixnum overflow, and relied
5124 on undefined (wraparound) behavior. The new code avoids undefined
5125 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5126
2e6813b0 5127 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5128 Tune. Don't use wider integers than needed. Don't use alloca.
5129 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5130
599a9e4f
PE
5131 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5132
99561444
PE
5133 * insdel.c, lisp.h (buffer_overflow): New function.
5134 (insert_from_buffer_1, replace_range, replace_range_2):
5135 * insdel.c (make_gap_larger):
5136 * editfns.c (Finsert_char):
5137 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5138
28177add
PE
5139 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5140
e69dafad
PE
51412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5142
4baa020d 5143 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5144
b1c46f02
PE
5145 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5146 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5147
e69dafad
PE
5148 * fileio.c: Don't assume EMACS_INT fits in off_t.
5149 (emacs_lseek): New static function.
5150 (Finsert_file_contents, Fwrite_region): Use it.
5151 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5152
566684ea
PE
5153 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5154
e6966cd6
PE
5155 * fns.c: Don't overflow int when computing a list length.
5156 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5157 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5158 truncation on 64-bit hosts. Check for QUIT every
5159 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5160 faster and is responsive enough.
5161 (Flength): Report an error instead of overflowing an integer.
5162 (Fsafe_length): Return a float if the value is not representable
5163 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5164 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5165 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5166
dd0b0efb
PE
5167 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5168 (header_size, word_size): New constants.
5169 (allocate_vectorlike): Don't check size overflow here.
5170 (allocate_vector): Check it here instead, since this is the only
5171 caller of allocate_vectorlike that could cause overflow.
5172 Check that the new vector's length is representable as a fixnum.
5173
86fe5cfe
PE
5174 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5175 The previous code was bogus. For example, next_almost_prime (32)
5176 returned 39, which is undesirable as it is a multiple of 3; and
5177 next_almost_prime (24) returned 25, which is a multiple of 5 so
5178 why was the code bothering to check for multiples of 7?
5179
80e88859
PE
5180 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5181
4a2f0ad6
PE
5182 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5183
f66c7cf8
PE
5184 Variadic C functions now count arguments with ptrdiff_t.
5185 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5186 Back then I didn't know that the Emacs coding style prefers signed int.
5187 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5188 were being counted with int, which may truncate counts on 64-bit
5189 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5190 * lisp.h (struct Lisp_Subr.function.aMANY)
5191 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5192 Arg counts are now ptrdiff_t, not size_t.
5193 All variadic functions and their callers changed accordingly.
5194 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5195 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5196 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5197 * callint.c (Fcall_interactively): Check arg count for overflow,
5198 to avoid potential buffer overrun. Use signed char, not 'int',
5199 for 'varies' array, so that we needn't bother to check its size
5200 calculation for overflow.
5201 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5202 * eval.c (apply_lambda):
5203 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5204 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5205 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5206
a1759b76
PE
5207 * callint.c (Fcall_interactively): Don't use index var as event count.
5208
d96be9fc
PE
5209 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5210 * mem-limits.h (SIZE): Remove; no longer used.
5211
a690a978 5212 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5213
578c21e6
PE
5214 Remove unnecessary casts.
5215 * xterm.c (x_term_init):
5216 * xfns.c (x_set_border_pixel):
5217 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5218 These aren't needed now that we assume ANSI C.
5219
96f53c6c
PE
5220 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5221 It's more likely to cause problems (due to unsigned overflow)
5222 than to cure them.
5223
83c77d31
PE
5224 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5225
ee2079f1
PE
5226 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5227
6da65536
PE
5228 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5229
7147c4a4
PE
5230 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5231
193e32d9
PE
5232 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5233
e5533da6
PE
5234 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5235
9910e595
PE
5236 GLYPH_CODE_FACE returns EMACS_INT, not int.
5237 * dispextern.h (merge_faces):
5238 * xfaces.c (merge_faces):
01103c44
PE
5239 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5240 Don't assume EMACS_INT fits in int.
9910e595 5241
2638320e
PE
5242 * character.h (CHAR_VALID_P): Remove unused parameter.
5243 * fontset.c, lisp.h, xdisp.c: All uses changed.
5244
045eb8d9
PE
5245 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5246
c1f134b5
PE
5247 * fns.c (concat): Minor tuning based on overflow analysis.
5248 This doesn't fix any bugs. Use int to hold character, instead
5249 of constantly refetching from Emacs object. Use XFASTINT, not
5250 XINT, for value known to be a character. Don't bother comparing
5251 a single byte to 0400, as it's always less.
5252
395fcb93 5253 * floatfns.c (Fexpt):
327eeec8
PE
5254 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5255
abbd3d23
PE
5256 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5257 for characters.
5258
684a03ef
PE
5259 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5260
0fed43f3
PE
5261 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5262 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5263 incorrectly succeed when S was a string, because 4294967386 was
5264 truncated before it was used.
5265
8fd02eb7
PE
5266 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5267 Otherwise, an out-of-range integer could cause undefined behavior
5268 on a 64-bit host.
5269
f8c86b69
PE
5270 * composite.c: Use int, not EMACS_INT, for characters.
5271 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5272 EMACS_INT, for values that are known to be in character range.
5273 This doesn't fix any bugs but is the usual style inside Emacs and
5274 may generate better code on 32-bit machines.
5275
34206dd2
PE
5276 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5277 This is for reasons similar to the recent CHAR_STRING fix.
5278 * charset.c (Fencode_char): Check that character arg is actually
5279 a character. Pass an int to ENCODE_CHAR.
5280 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5281 wider than 'int', as a compile-time check to prevent future regressions
5282 in this area.
5283
c5958d4c 5284 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5285
5286 Make sure a 64-bit char is never passed to CHAR_STRING.
5287 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5288 by silently ignoring the top 32 bits, allowing some values
5289 that were far too large to be valid characters.
5290 * character.h: Include <verify.h>.
5291 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5292 arguments are no wider than unsigned, as a compile-time check
5293 to prevent future regressions in this area.
5294 * data.c (Faset):
01103c44 5295 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5296 (Fsubst_char_in_region):
5297 * fns.c (concat):
5298 * xdisp.c (decode_mode_spec_coding):
5299 Adjust to CHAR_STRING's new requirement.
5300 * editfns.c (Finsert_char, Fsubst_char_in_region):
5301 * fns.c (concat): Check that character args are actually
5302 characters. Without this test, these functions did the wrong
5303 thing with wildly out-of-range values on 64-bit hosts.
5304
d37ca623
PE
5305 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5306 These casts should not be needed on 32-bit hosts, either.
5307 * keyboard.c (read_char):
5308 * lread.c (Fload): Remove casts to unsigned.
5309
ea204efb
PE
5310 * lisp.h (UNSIGNED_CMP): New macro.
5311 This fixes comparison bugs on 64-bit hosts.
5312 (ASCII_CHAR_P): Use it.
5313 * casefiddle.c (casify_object):
01103c44 5314 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5315 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5316 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5317 * dispextern.h (FACE_FROM_ID):
5318 * keyboard.c (read_char): Use UNSIGNED_CMP.
5319
41cb286c
PE
5320 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5321 not to EMACS_INT, to avoid GCC warning.
5322
4a1b9832
PE
5323 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5324
55daad71
PE
5325 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5326 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5327 isn't needed on 32-bit machines.
8f95c75c 5328
01103c44
PE
5329 * buffer.c (Fgenerate_new_buffer_name):
5330 Use EMACS_INT for count, not int.
0ceccced 5331 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5332
5333 * data.c (Qcompiled_function): Now static.
5334
c6f072e7
PE
5335 * window.c (window_body_lines): Now static.
5336
20ce5912
PE
5337 * image.c (gif_load): Rename local to avoid shadowing.
5338
9c4c5f81
PE
5339 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5340 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5341 * alloc.c (make_save_value): Integer argument is now of type
5342 ptrdiff_t, not int.
5343 (mark_object): Use ptrdiff_t, not int.
5344 * lisp.h (pD): New macro.
5345 * print.c (print_object): Use it.
5346
c0c5c8ae
PE
5347 * alloc.c: Use EMACS_INT, not int, to count objects.
5348 (total_conses, total_markers, total_symbols, total_vector_size)
5349 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5350 (total_free_floats, total_floats, total_free_intervals)
5351 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5352 Now EMACS_INT, not int. All uses changed.
5353 (Fgarbage_collect): Compute overall total using a double, so that
5354 integer overflow is less likely to be a problem. Check for overflow
5355 when converting back to an integer.
5a25e253
PE
5356 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5357 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5358 These were 'int' variables that could overflow on 64-bit hosts;
5359 they were never used, so remove them instead of repairing them.
211a0b2a 5360 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5361 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5362 Previously, this ceilinged at INT_MAX, but that doesn't work on
5363 64-bit machines.
e46bb31a 5364 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5365
c78baabf 5366 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5367 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5368 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5369 when a (possibly-narrower) signed value would do just as well.
5370 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5371
c9d624c6
PE
5372 * alloc.c: Catch some string size overflows that we were missing.
5373 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5374 for convenience in STRING_BYTES_MAX.
5375 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5376 The definition here is exact; the one in lisp.h was approximate.
5377 (allocate_string_data): Check for string overflow. This catches
5378 some instances we weren't catching before. Also, it catches
5379 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5380 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5381 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5382
c9d624c6
PE
5383 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5384 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5385 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5386
353032ce
PE
5387 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5388
2bccce07
PE
5389 * alloc.c (Fmake_string): Check for out-of-range init.
5390
0ac30604
SM
53912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5392
5393 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5394
c195f2de
JD
53952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5396
5397 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5398 xg_get_default_scrollbar_width.
5399
5400 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5401 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5402 (style_changed_cb): Call update_theme_scrollbar_width and call
5403 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5404 all frames (Bug#8505).
5405 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5406 Call gtk_window_set_resizable if HAVE_GTK3.
5407 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5408 and height if HAVE_GTK3 (Bug#8505).
5409 (scroll_bar_width_for_theme): New variable.
5410 (update_theme_scrollbar_width): New function.
5411 (xg_get_default_scrollbar_width): Move code to
5412 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5413 (xg_initialize): Call update_theme_scrollbar_width.
5414
5415 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5416
5417 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5418
e10ac9f1
MR
54192011-06-12 Martin Rudalics <rudalics@gmx.at>
5420
5421 * frame.c (make_frame): Call other_buffer_safely instead of
5422 other_buffer.
5423
5424 * window.c (temp_output_buffer_show): Call display_buffer with
5425 second argument Vtemp_buffer_show_specifiers and reset latter
5426 immediately after the call.
5427 (Vtemp_buffer_show_specifiers): New variable.
5428 (auto_window_vscroll_p, next_screen_context_lines)
5429 (Vscroll_preserve_screen_position): Remove leading asterisks from
5430 doc-strings.
5431
2d3c217e 54322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5433
7b7f97e8 5434 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5435 * buffer.c (Qclone_number): Remove for now, as it's unused.
5436 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5437 (record_buffer): Remove unused local.
5438 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5439 (set_frame_buffer_list): Remove; unused.
5440 * frame.h (other_visible_frames): Remove decl.
5441 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5442 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5443 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5444 if HAVE_GPM.
5445 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5446 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5447 Define only if HAVE_GPM.
5448 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5449 (update_hints_inhibit): Remove; never set. All uses removed.
5450 * widgetprv.h (emacsFrameClassRec): Remove decl.
5451 * window.c (delete_deletable_window): Now returns void, since it
5452 wasn't returning anything.
5453 (compare_window_configurations): Remove unused locals.
5454 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5455 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5456 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5457 the same widths as pointers. This follows up on the 2011-05-06 patch.
5458 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5459 * xterm.h: Likewise.
5460 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5461
1384b89e
JB
54622011-06-12 Juanma Barranquero <lekktu@gmail.com>
5463
5464 * makefile.w32-in: Update dependencies.
5465 (LISP_H): Add lib/intprops.h.
5466
1100a63c
CY
54672011-06-11 Chong Yidong <cyd@stupidchicken.com>
5468
5469 * image.c (gif_load): Add animation frame delay to the metadata.
5470 (syms_of_image): Use DEFSYM. New symbol `delay'.
5471
6198ccd0
MR
54722011-06-11 Martin Rudalics <rudalics@gmx.at>
5473
5474 * window.c (delete_deletable_window): Re-add.
5475 (Fset_window_configuration): Rewrite to handle dead buffers and
5476 consequently deletable windows.
5477 (window_tree, Fwindow_tree): Remove. Supply functionality in
5478 window.el.
5479 (compare_window_configurations): Simplify code.
5480
b6e3633c
AS
54812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5482
1ab0dee5
AS
5483 * image.c (imagemagick_load_image): Fix type mismatch.
5484 (Fimagemagick_types): Likewise.
5485
b6e3633c
AS
5486 * window.h (replace_buffer_in_windows): Declare.
5487
9397e56f
MR
54882011-06-11 Martin Rudalics <rudalics@gmx.at>
5489
5490 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5491 Qclone_number. Remove external declaration of Qdelete_window.
5492 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5493 code.
640c8776
SM
5494 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5495 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5496 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5497 buffer list implementation.
5498 (other_buffer_safely): New function.
5499 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5500 calls to replace_buffer_in_windows and
5501 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5502 if allowed.
5503 (record_buffer): Inhibit quitting and rewrite using quittable
5504 functions. Run Qbuffer_list_update_hook if allowed.
5505 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5506 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5507 Move switch-to-buffer to window.el.
9397e56f
MR
5508 (bury-buffer): Move to window.el.
5509 (Vbuffer_list_update_hook): New variable.
5510
5511 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5512 section.
5513
5514 * window.h (resize_frame_windows): Move up in code.
5515 (Fwindow_frame): Remove EXFUN.
5516 (replace_buffer_in_all_windows): Remove prototype.
5517 (replace_buffer_in_windows_safely): Add prototype.
5518
5519 * window.c: Declare Qdelete_window static again. Move down
5520 declaration of select_count.
5521 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5522 (Fother_window): Move to window.el.
5523 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5524 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5525 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5526 window.el.
5527 (replace_buffer_in_windows): Implement by calling
5528 Qreplace_buffer_in_windows.
5529 (replace_buffer_in_all_windows): Remove with some functionality
5530 moved into replace_buffer_in_windows_safely.
5531 (replace_buffer_in_windows_safely): New function.
5532 (select_window_norecord, select_frame_norecord): Move in front
5533 of run_window_configuration_change_hook. Remove now obsolete
5534 declarations.
640c8776
SM
5535 (Fset_window_buffer): Rewrite doc-string.
5536 Call Qrecord_window_buffer.
9397e56f
MR
5537 (keys_of_window): Move binding for other-window to window.el.
5538
b50691aa
CY
55392011-06-11 Chong Yidong <cyd@stupidchicken.com>
5540
5541 * dispextern.h (struct image): Replace data member, whose int_val
5542 and ptr_val fields were not used by anything, with a single
5543 lisp_val object.
5544
5545 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5546 (gif_clear_image, gif_load, imagemagick_load_image)
5547 (gs_clear_image, gs_load): Callers changed.
5548
3f754b86
PE
55492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5550
cca69397
PE
5551 * buffer.h: Include <time.h>, for time_t.
5552 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5553
109e28d0
PE
5554 Fix minor problems found by static checking.
5555
60737f02
PE
5556 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5557
4b66faf3
PE
5558 Make identifiers static if they are not used in other modules.
5559 * data.c (Qcompiled_function, Qframe, Qvector):
5560 * image.c (QimageMagick, Qsvg):
5561 * minibuf.c (Qmetadata):
5562 * window.c (resize_window_check, resize_root_window): Now static.
5563 * window.h (resize_window_check, resize_root_window): Remove decls.
5564
109e28d0
PE
5565 * window.c (window_deletion_count, delete_deletable_window):
5566 Remove; unused.
46a4ce9e
PE
5567 (window_body_lines): Now static.
5568 (Fdelete_other_windows_internal): Mark vars as initialized.
5569 Make sure 'resize_failed' is initialized.
5570 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5571 (resize_window_apply): Remove unused local.
5572 * window.h (delete_deletable_window): Remove decl.
5573
109e28d0 5574 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5575 (imagemagick_load_image): Fix pointer signedness problem by changing
5576 last arg from unsigned char * to char *. All uses changed.
5577 Also, fix a local for similar reasons.
5578 Remove unused locals. Remove locals to avoid shadowing.
5579 (fn_rsvg_handle_free): Remove; unused.
5580 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5581 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5582
3f754b86
PE
5583 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5584
2547adb1
CY
55852011-06-10 Chong Yidong <cyd@stupidchicken.com>
5586
5587 * image.c (gif_load): Fix omitted cast error introduced by
5588 2011-06-06 change.
5589
2c8e37d4
MR
55902011-06-10 Martin Rudalics <rudalics@gmx.at>
5591
5592 * window.h (resize_proportionally, orig_total_lines)
5593 (orig_top_line): Remove from window structure.
5594 (set_window_height, set_window_width, change_window_heights)
5595 (Fdelete_window): Remove prototypes.
5596 (resize_frame_windows): Remove duplicate declaration.
5597
440a42e3
EZ
55982011-06-10 Eli Zaretskii <eliz@gnu.org>
5599
5600 * window.h (resize_frame_windows, resize_window_check)
5601 (delete_deletable_window, resize_root_window)
5602 (resize_frame_windows): Declare prototypes.
5603
5604 * window.c (resize_window_apply): Make definition be "static" to
5605 match the prototype.
5606
562dd5e9
MR
56072011-06-10 Martin Rudalics <rudalics@gmx.at>
5608
5609 * window.c: Remove declarations of Qwindow_size_fixed,
5610 window_min_size_1, window_min_size_2, window_min_size,
5611 size_window, window_fixed_size_p, enlarge_window, delete_window.
5612 Remove static from declaration of Qdelete_window, it's
5613 temporarily needed by Fbury_buffer.
5614 (replace_window): Don't assign orig_top_line and
5615 orig_total_lines.
5616 (Fdelete_window, delete_window): Remove. Window deletion is
5617 handled by window.el.
640c8776
SM
5618 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5619 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5620 (Fdelete_other_windows): Remove. Deleting other windows is
5621 handled by window.el.
5622 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5623 handled in window.el.
5624 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5625 Window minimum sizes are handled in window.el.
5626 (shrink_windows, size_window, set_window_height)
5627 (set_window_width, change_window_heights, window_height)
5628 (window_width, CURBEG, CURSIZE, enlarge_window)
5629 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5630 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5631 handled in window.el.
5632 (make_dummy_parent): Rename to make_parent_window and give it a
5633 second argument horflag.
5634 (make_window): Don't set resize_proportionally any more.
5635 (Fsplit_window): Remove. Windows are split in window.el.
5636 (save_restore_action, save_restore_orig_size)
5637 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5638 Resize mini windows in window.el.
5639 (grow_mini_window, shrink_mini_window): Implement by calling
5640 Qresize_root_window_vertically, resize_window_check and
5641 resize_window_apply.
640c8776
SM
5642 (saved_window, Fset_window_configuration, save_window_save):
5643 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5644 resize_proportionally.
5645 (window_min_height, window_min_width): Move to window.el.
5646 (keys_of_window): Move bindings for delete-other-windows,
5647 split-window, delete-window and enlarge-window to window.el.
5648
5649 * buffer.c: Temporarily extern Qdelete_window.
5650 (Fbury_buffer): Temporarily call Qdelete_window instead of
5651 Fdelete_window (Fbury_buffer will move to window.el soon).
5652
5653 * frame.c (set_menu_bar_lines_1): Remove code handling
5654 orig_top_line and orig_total_lines.
5655
5656 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5657 set_window_height but set heights directly.
5658 (change_frame_size_1): Use resize_frame_windows.
5659
5660 * xdisp.c (init_xdisp): Don't use set_window_height but set
5661 heights directly.
5662
640c8776
SM
5663 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5664 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5665 run_window_configuration_change_hook.
5666
5667 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5668 instead of change_window_heights and run
5669 run_window_configuration_change_hook.
5670
1a13852e
MR
56712011-06-09 Martin Rudalics <rudalics@gmx.at>
5672
5673 * window.c (replace_window): Rename second argument REPLACEMENT to
5674 NEW. New third argument SETFLAG. Rewrite.
5675 (delete_window, make_dummy_parent): Call replace_window with
5676 third argument 1.
5677 (window_list_1): Move down in code.
5678 (run_window_configuration_change_hook): Move set_buffer part
5679 before select_frame_norecord part in order to unwind correctly.
5680 Rename count1 to count.
5681 (recombine_windows, delete_deletable_window, resize_root_window)
5682 (Fdelete_other_windows_internal)
5683 (Frun_window_configuration_change_hook, make_parent_window)
5684 (resize_window_check, resize_window_apply, Fresize_window_apply)
5685 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5686 (Fdelete_window_internal, Fresize_mini_window_internal):
5687 New functions.
1a13852e
MR
5688 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5689
f3d1777e
MR
56902011-06-08 Martin Rudalics <rudalics@gmx.at>
5691
496e208e
MR
5692 * window.h (window): Add some new members to window structure -
5693 normal_lines, normal_cols, new_total, new_normal, clone_number,
5694 splits, nest, prev_buffers, next_buffers.
5695 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5696 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5697
f3d1777e
MR
5698 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5699 Remove.
496e208e
MR
5700 (make_dummy_parent): Set new members of windows structure.
5701 (make_window): Move down in code. Handle new members of window
5702 structure.
5703 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5704 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5705 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5706 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5707 (Fset_window_next_buffers, Fset_window_clone_number):
5708 New functions.
496e208e
MR
5709 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5710 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5711 Doc-string fixes.
5712 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5713 Argument WINDOW can be now internal window too.
5714 (Fwindow_use_time): Move up in code.
5715 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5716 Rewrite doc-string.
5717 (Fset_window_configuration, saved_window)
5718 (Fcurrent_window_configuration, save_window_save): Handle new
5719 members of window structure.
b9e809c2
MR
5720 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5721 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5722 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5723 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5724 Qget_mru_window, Qresize_root_window,
5725 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5726 Qauto_buffer_name; staticpro them.
f3d1777e 5727
abde8f8c
MR
57282011-06-07 Martin Rudalics <rudalics@gmx.at>
5729
5730 * window.c (Fwindow_total_size, Fwindow_left_column)
5731 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5732 (Fwindow_list_1): New functions.
5733 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5734 (Fwindow_width, Fscroll_left, Fscroll_right):
5735 Use window_body_cols instead of window_box_text_cols.
5736 (delete_window, Fset_window_configuration):
5737 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5738 (delete_all_subwindows): Take a window as argument and not a
5739 structure. Rewrite.
190b47e6
MR
5740 (window_loop): Remove handling of GET_LRU_WINDOW and
5741 GET_LARGEST_WINDOW.
5742 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5743
5744 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5745 window_box_text_cols. delete_all_subwindows now takes a
5746 Lisp_Object as argument.
abde8f8c 5747
640c8776
SM
5748 * indent.c (compute_motion, Fcompute_motion):
5749 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5750
fa8a67e6
MR
5751 * frame.c (delete_frame): Call delete_all_subwindows with root
5752 window as argument.
5753
a54e3482
DC
57542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5755
5756 * fns.c (Fputhash): Document return value.
5757
60002bf5
CY
57582011-06-06 Chong Yidong <cyd@stupidchicken.com>
5759
5760 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5761
0c671da6 57622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5763
b862a52a 5764 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5765
be44ca6c
PE
5766 Check for overflow when converting integer to cons and back.
5767 * charset.c (Fdefine_charset_internal, Fdecode_char):
5768 Use cons_to_unsigned to catch overflow.
5769 (Fencode_char): Use INTEGER_TO_CONS.
5770 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5771 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5772 * data.c (long_to_cons, cons_to_long): Remove.
5773 (cons_to_unsigned, cons_to_signed): New functions.
5774 These signal an error for invalid or out-of-range values.
5775 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5776 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5777 * font.c (Ffont_variation_glyphs):
5778 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5779 * lisp.h: Include <intprops.h>.
5780 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5781 (cons_to_signed, cons_to_unsigned): New decls.
5782 (long_to_cons, cons_to_long): Remove decls.
5783 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5784 (Fprimitive_undo): Use CONS_TO_INTEGER.
5785 * xfns.c (Fx_window_property): Likewise.
5786 * xselect.c: Include <limits.h>.
5787 (x_own_selection, selection_data_to_lisp_data):
5788 Use INTEGER_TO_CONS.
5789 (x_handle_selection_request, x_handle_selection_clear)
5790 (x_get_foreign_selection, Fx_disown_selection_internal)
5791 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5792 (lisp_data_to_selection_data): Use cons_to_unsigned.
5793 (x_fill_property_data): Use cons_to_signed.
5794 Report values out of range.
5795
d1f3d2af
PE
5796 Check for buffer and string overflow more precisely.
5797 * buffer.h (BUF_BYTES_MAX): New macro.
5798 * lisp.h (STRING_BYTES_MAX): New macro.
5799 * alloc.c (Fmake_string):
5800 * character.c (string_escape_byte8):
5801 * coding.c (coding_alloc_by_realloc):
5802 * doprnt.c (doprnt):
5803 * editfns.c (Fformat):
5804 * eval.c (verror):
5805 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5806 since they may not be the same number.
5807 * editfns.c (Finsert_char):
5808 * fileio.c (Finsert_file_contents):
5809 Likewise for BUF_BYTES_MAX.
5810
dd52fcea
PE
5811 * image.c: Use ptrdiff_t, not int, for sizes.
5812 (slurp_file): Switch from int to ptrdiff_t.
5813 All uses changed.
5814 (slurp_file): Check that file size fits in both size_t (for
5815 malloc) and ptrdiff_t (for sanity and safety).
5816
7f9bbdbb
PE
5817 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5818 if b->modtime has its maximal value.
5819
dfe18f82
PE
5820 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5821
84acfcf0
PE
5822 Don't assume time_t can fit into int.
5823 * buffer.h (struct buffer.modtime): Now time_t, not int.
5824 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5825 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5826
ccd9a01a
PE
5827 Minor fixes for signed vs unsigned integers.
5828 * character.h (MAYBE_UNIFY_CHAR):
5829 * charset.c (maybe_unify_char):
5830 * keyboard.c (read_char, reorder_modifiers):
5831 XINT -> XFASTINT, since the integer must be nonnegative.
5832 * ftfont.c (ftfont_spec_pattern):
5833 * keymap.c (access_keymap, silly_event_symbol_error):
5834 XUINT -> XFASTINT, since the integer must be nonnegative.
5835 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5836 since it makes no difference and we prefer signed.
5837 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5838 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5839 nonnegative.
5840
d6d100dd
SM
58412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5842
5843 * window.h (Fwindow_frame): Declare.
5844
2b6148e4
PE
58452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5846
5847 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5848 (SPARE_MEMORY): Always define.
5849 (LARGE_REQUEST): Remove.
5850 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5851
f230ecc9
MR
58522011-06-06 Martin Rudalics <rudalics@gmx.at>
5853
727e958e
MR
5854 * lisp.h: Move EXFUNS for Fframe_root_window,
5855 Fframe_first_window and Fset_frame_selected_window to window.h.
5856
5857 * window.h: Move EXFUNS for Fframe_root_window,
5858 Fframe_first_window and Fset_frame_selected_window here from
5859 lisp.h.
5860
5861 * frame.c (Fwindow_frame, Fframe_first_window)
5862 (Fframe_root_window, Fframe_selected_window)
5863 (Fset_frame_selected_window): Move to window.c.
5864 (Factive_minibuffer_window): Move to minibuf.c.
5865 (Fother_visible_frames_p): New function.
5866
5867 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5868
f230ecc9
MR
5869 * window.c (decode_window, decode_any_window): Move up in code.
5870 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5871 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5872 (Fwindow_buffer): Move up and rewrite doc-string.
5873 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5874 (Fwindow_prev): New functions.
727e958e
MR
5875 (Fwindow_frame): Move here from frame.c. Accept any window as
5876 argument.
5877 (Fframe_root_window, Fframe_first_window)
5878 (Fframe_selected_window): Move here from frame.c. Accept frame
5879 or arbitrary window as argument. Update doc-strings.
5880 (Fminibuffer_window): Move up in code.
5881 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5882 (Fset_frame_selected_window): Move here from frame.c.
5883 Marginal rewrite.
727e958e
MR
5884 (Fselected_window, select_window, Fselect_window): Move up in
5885 code. Minor doc-string fixes.
f230ecc9 5886
4d09bcf6
PE
58872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5888
5889 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5890 Do not assume that spare memory exists; that assumption is valid
5891 only if SYSTEM_MALLOC.
5892 (LARGE_REQUEST): New macro, so that the issue of large requests
5893 is separated from the issue of spare memory.
5894
810928a2
AS
58952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5896
172418ad
AS
5897 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5898 format. (Bug#8806)
5899
43f862f7
AS
5900 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5901
810928a2
AS
5902 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5903 before statements.
5904
a059fe24
JD
59052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5906
5907 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5908
5909 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5910
5911 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5912 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5913
989bf368
JB
59142011-06-05 Juanma Barranquero <lekktu@gmail.com>
5915
5916 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5917
4b80f674
CY
59182011-06-04 Chong Yidong <cyd@stupidchicken.com>
5919
5920 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5921 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5922 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5923 New error handlers.
4b80f674
CY
5924 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5925 Obey Vx_select_enable_clipboard_manager. Catch errors in
5926 x_clipboard_manager_save (Bug#8779).
5927 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5928 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5929
99a33b77 59302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5931
5932 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5933
99a33b77 59342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5935
5936 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5937 in the current matrix if keep_current_p is non-zero.
5938
8264569d
EZ
59392011-06-04 Eli Zaretskii <eliz@gnu.org>
5940
5941 * bidi.c (bidi_level_of_next_char): Fix last change.
5942
57f97249
EZ
59432011-06-03 Eli Zaretskii <eliz@gnu.org>
5944
fec2107c 5945 Support bidi reordering of text covered by display properties.
57f97249 5946
fec2107c
EZ
5947 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5948 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5949 (bidi_cache_search, bidi_cache_iterator_state)
5950 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5951 (bidi_level_of_next_char, bidi_move_to_visually_next):
5952 Support character positions inside a run of characters covered by a
fec2107c
EZ
5953 display string.
5954 (bidi_paragraph_init, bidi_resolve_explicit_1)
5955 (bidi_level_of_next_char): Call bidi_fetch_char and
5956 bidi_fetch_char_advance instead of FETCH_CHAR and
5957 FETCH_CHAR_ADVANCE.
5958 (bidi_init_it): Initialize new members.
5959 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5960 definitions.
5961 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5962 instead of using explicit *_CHAR codes.
d6d100dd
SM
5963 (bidi_resolve_explicit, bidi_resolve_weak):
5964 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5965 bidirectional text is supported only in multibyte buffers.
5966 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5967 it to initialize the frame_window_p member of struct bidi_it.
5968 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5969 (bidi_resolve_explicit, bidi_resolve_weak)
5970 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5971 bidi_it->nchars is non-positive.
5972 (bidi_level_of_next_char): Don't try to lookup the cache for the
5973 next/previous character if nothing is cached there yet, or if we
5974 were just reseat()'ed to a new position.
c40e2fb2 5975
0e14fe90
EZ
5976 * xdisp.c (set_cursor_from_row): Set start and stop points
5977 according to the row's direction when priming the loop that looks
5978 for the glyph on which to display cursor.
5979 (single_display_spec_intangible_p): Function deleted.
5980 (display_prop_intangible_p): Reimplement to call
5981 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5982 Accept 3 additional arguments needed by handle_display_spec.
5983 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5984 values: lists, `(when COND...)' forms, etc.
5985 (single_display_spec_string_p): Support property values that are
5986 lists with the argument STRING its top-level element.
5987 (display_prop_string_p): Fix the condition for processing a
5988 property that is a list to be consistent with handle_display_spec.
fec2107c 5989 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5990 last portion of handle_display_prop.
5991 (compute_display_string_pos): Accept additional argument
5992 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5993 value of a `display' property is a "replacing spec".
5994 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5995 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5996 the display property, but just return a value indicating whether
5997 the display property will replace the characters it covers.
5998 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5999 frame_window_p members of struct bidi_it.
d6d100dd
SM
6000 (compute_display_string_pos, compute_display_string_end):
6001 New functions.
fec2107c
EZ
6002 (push_it): Accept second argument POSITION, where pop_it should
6003 jump to continue iteration.
6004 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6005
fec2107c
EZ
6006 * keyboard.c (adjust_point_for_property): Adjust the call to
6007 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6008
6009 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6010 (bidi_init_it): Update prototypes.
6011 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6012 (compute_display_string_pos, compute_display_string_end):
6013 Declare prototypes.
fec2107c
EZ
6014 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6015 EMACS_INT.
fc6f18ce 6016
40087514 60172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6018
57f53182
PE
6019 Malloc failure behavior now depends on size of allocation.
6020 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6021 * lisp.h: Change signatures accordingly.
6022 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6023 All callers changed. (Bug#8762)
6024
6025 * gnutls.c: Use Emacs's memory allocators.
6026 Without this change, the gnutls library would invoke malloc etc.
6027 directly, which causes problems on non-SYNC_INPUT hosts, and which
6028 runs afoul of improving memory_full behavior. (Bug#8761)
6029 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6030 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6031 xfree instead of the default malloc, realloc, free.
6032 (Fgnutls_boot): No need to check for memory allocation failure,
6033 since xmalloc does that for us.
6034
ac32cd99 6035 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6036 * category.c (hash_get_category_set):
6037 * ccl.c (ccl_driver):
6038 * charset.c (Fdefine_charset_internal):
6039 * charset.h (struct charset.hash_index):
6040 * composite.c (get_composition_id, gstring_lookup_cache)
6041 (composition_gstring_put_cache):
6042 * composite.h (struct composition.hash_index):
6043 * dispextern.h (struct image.hash):
6044 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6045 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6046 (hashfn_equal, hashfn_user_defined, make_hash_table)
6047 (maybe_resize_hash_table, hash_lookup, hash_put)
6048 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6049 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6050 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6051 * image.c (make_image, search_image_cache, lookup_image)
6052 (xpm_put_color_table_h):
6053 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6054 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6055 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6056 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6057 * alloc.c (allocate_vectorlike):
6058 Check for overflow in vector size calculations.
6059 * ccl.c (ccl_driver):
6060 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6061 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6062 need to be updated by these changes.
40087514
PE
6063 * fns.c (make_hash_table, maybe_resize_hash_table):
6064 Check for integer overflow with large hash tables.
0de4bb68
PE
6065 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6066 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6067 (SXHASH_REDUCE): New macro.
6068 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6069 Use it instead of discarding useful hash info with large hash values.
6070 (sxhash_float): New function.
6071 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6072 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6073 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6074 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6075 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6076 Adjust signatures to match updated version of code.
6077 (consing_since_gc): Now EMACS_INT, since a single hash table can
6078 use more than INT_MAX bytes.
6079
698d32e2
DN
60802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6081
6082 Make it possible to build with GCC-4.6+ -O2 -flto.
6083
6084 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6085
fd6fa53f
SM
60862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6087
6088 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6089 Call minibuffer-inactive-mode.
6090
864db017
JB
60912011-05-31 Juanma Barranquero <lekktu@gmail.com>
6092
6093 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6094 Update dependencies.
6095
2ad0baf4
DN
60962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6097
6098 * data.c (init_data): Remove code for UTS, this system is not
6099 supported anymore.
6100
4fcc2638
DN
61012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6102
6103 Don't force ./temacs to start in terminal mode.
6104
6105 * frame.c (make_initial_frame): Initialize faces in all cases, not
6106 only when CANNOT_DUMP is defined.
6107 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6108
c56e0fd5
DN
61092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6110
6111 * dispnew.c (add_window_display_history): Use const for the string
6112 pointer. Remove declaration, not needed.
6113
333d54da 61142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6115
55d4c1b2 6116 Use 'inline', not 'INLINE'.
333d54da 6117 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6118 * alloc.c, fontset.c (INLINE): Remove.
6119 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6120 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6121 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6122 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6123 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6124
738db178
DN
61252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6126
6127 Make it possible to run ./temacs.
6128
6129 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6130 syms_of_callproc does the same thing. Remove test for
6131 "initialized", do it in the caller.
6132 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6133
620c53a6
SM
61342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6135
6136 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6137 (read_minibuf): Use get_minibuffer.
6138 (syms_of_minibuf): Use DEFSYM.
6139 (Qmetadata): New var.
6140 * data.c (Qbuffer): Don't make it static.
6141 (syms_of_data): Use DEFSYM.
6142
e003a292
PE
61432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6144
6145 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6146 (CCL_CODE_MIN): New macro.
6147
ed008a6d
PE
61482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6149
3687c2ef
PE
6150 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6151
ed008a6d
PE
6152 * eval.c (Qdebug): Now static.
6153 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6154 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6155 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6156
d66c4c7c
CY
61572011-05-29 Chong Yidong <cyd@stupidchicken.com>
6158
6159 * image.c: Various fixes to ImageMagick code comments.
6160 (Fimagemagick_types): Doc fix.
6161
5fbc2025
PE
61622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6163
0196f88a
PE
6164 Minor fixes prompted by GCC 4.6.0 warnings.
6165
6166 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6167
5fbc2025
PE
6168 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6169 (x_clipboard_manager_save_all): Move extern decl to ...
6170 * xterm.h: ... here, so that it can be checked for consistency.
6171
1dd3c2d9
CY
61722011-05-29 Chong Yidong <cyd@stupidchicken.com>
6173
6174 * xselect.c (x_clipboard_manager_save_frame)
6175 (x_clipboard_manager_save_all): New functions.
6176 (Fx_clipboard_manager_save): Lisp function deleted.
6177
6178 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6179 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6180
6181 * xterm.h: Update prototype.
6182
5ba6571d
WX
61832011-05-28 William Xu <william.xwl@gmail.com>
6184
6185 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6186 exiting (Bug#8239).
6187
3eaff834
JM
61882011-05-28 Jim Meyering <meyering@redhat.com>
6189
e1900994 6190 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6191 * fns.c (to_uchar): Define.
6192 (crypto_hash_function): Use it to convert some newly-signed
6193 variables to unsigned, to avoid sign-extension bugs. For example,
6194 without this change, (md5 "truc") would evaluate to
6195 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6196 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6197 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6198
0f6990a7
PE
61992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6200
6201 Integer overflow fixes.
c8a9ca5a 6202
08686060
PE
6203 * dbusbind.c: Serial number integer overflow fixes.
6204 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6205 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6206 to hold a serial number that is too large for a fixnum.
6207 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6208 Check for serial numbers out of range. Decode any serial number
59568bf0 6209 that was so large that it became a float. (Bug#8722)
08686060 6210
2d1fc3c7
PE
6211 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6212 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6213 Use XFASTINT rather than XUINT when numbers are nonnegative.
6214 (xd_append_arg, Fdbus_method_return_internal):
6215 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6216 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6217 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6218 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6219 (Bug#8722)
2d1fc3c7 6220
c8a9ca5a
PE
6221 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6222
519e1d69
PE
6223 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6224
6df6ae42 6225 ccl: Add integer overflow checks.
30569699
PE
6226 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6227 (IN_INT_RANGE): New macros.
6228 (ccl_driver): Use them to check for integer overflow when
6229 decoding a CCL program. Many of the new checks are whether XINT (x)
6230 fits in int; it doesn't always, on 64-bit hosts. The new version
6231 doesn't catch all possible integer overflows, but it's an
847044ea 6232 improvement. (Bug#8719)
30569699 6233
c11285dc
PE
6234 * alloc.c (make_event_array): Use XINT, not XUINT.
6235 There's no need for unsigned here.
6236
fdccd48e
PE
6237 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6238 This follows up to the 2011-05-06 change that substituted uintptr_t
6239 for EMACS_INT. This case wasn't caught back then.
6240
37910ab2
PE
6241 Rework Fformat to avoid integer overflow issues.
6242 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6243 now (part of C89). Include <verify.h>.
6244 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6245 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6246 (Fformat): Avoid the prepass trying to compute sizes; it was only
6247 approximate and thus did not catch overflow reliably. Instead, walk
6248 through the format just once, formatting and computing sizes as we go,
6249 checking for integer overflow at every step, and allocating a larger
6250 buffer as needed. Keep track separately whether the format is
6251 multibyte. Keep only the most-recently calculated precision, rather
6252 than them all. Record whether each argument has been converted to
6253 string. Use EMACS_INT, not int, for byte and char and arg counts.
6254 Support field widths and precisions larger than INT_MAX. Avoid
6255 sprintf's undefined behavior with conversion specifications such as %#d
6256 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6257 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6258 formatting out-of-range floating point numbers with int
9173deec 6259 formats. (Bug#8668)
37910ab2 6260
2e6578fb
PE
6261 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6262
0ae6bdee
PE
6263 * data.c: Avoid integer truncation in expressions involving floats.
6264 * data.c: Include <intprops.h>.
6265 (arith_driver): When there's an integer overflow in an expression
6266 involving floating point, convert the integers to floating point
6267 so that the resulting value does not suffer from catastrophic
6268 integer truncation. For example, on a 64-bit host (* 4
6269 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6270 Do not rely on undefined behavior after integer overflow.
6271
de883a70
PE
6272 merge count_size_as_multibyte, parse_str_to_multibyte
6273 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6274 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6275 Check for integer overflow.
6276 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6277 since it's now a duplicate of the other. This is more of
6278 a character than a buffer op, so better that it's in character.c.
6279 * fns.c, print.c: Adjust to above changes.
6280
2ff916cb
PE
62812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6282
6283 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6284
f1b54466
PE
62852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6286
fb1ac845
PE
6287 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6288 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6289 (x_clipboard_manager_save): Now static.
6290 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6291
f1b54466
PE
6292 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6293 (crypto_hash_function): Now static.
6294 Fix pointer signedness problems. Avoid unnecessary initializations.
6295
a9f737ee
CY
62962011-05-27 Chong Yidong <cyd@stupidchicken.com>
6297
6298 * termhooks.h (Vselection_alist): Make it terminal-local.
6299
6300 * terminal.c (create_terminal): Initialize it.
6301
6302 * xselect.c: Support for clipboard managers.
6303 (Vselection_alist): Move to termhooks.h as terminal-local var.
6304 (LOCAL_SELECTION): New macro.
6305 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6306 (symbol_to_x_atom): Remove gratuitous arg.
6307 (x_handle_selection_request, lisp_data_to_selection_data)
6308 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6309 (x_own_selection, x_get_local_selection, x_convert_selection):
6310 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6311 (some_frame_on_display): Delete unused function.
6312 (Fx_own_selection_internal, Fx_get_selection_internal)
6313 (Fx_disown_selection_internal, Fx_selection_owner_p)
6314 (Fx_selection_exists_p): New optional frame arg.
6315 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6316 (x_handle_selection_clear): Don't treat other terminals with the
6317 same keyboard specially. Use the terminal-local Vselection_alist.
6318 (x_clear_frame_selections): Use Frun_hook_with_args.
6319
6320 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6321
6322 * xterm.h: Add support for those atoms.
6323
e067f0c1
CY
63242011-05-26 Chong Yidong <cyd@stupidchicken.com>
6325
6326 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6327 (converted_selections, conversion_fail_tag): New global variables.
6328 (x_selection_request_lisp_error): Free the above.
6329 (x_get_local_selection): Remove unnecessary code.
6330 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6331 of converted selections stored in converted_selections.
6332 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6333 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6334 (x_convert_selection): New function.
6335 (x_handle_selection_event): Simplify.
6336 (x_get_foreign_selection): Don't ignore incoming requests while
6337 waiting for an answer; this will fail when we implement
6338 SAVE_TARGETS, and seems unnecessary anyway.
6339 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6340 (Vx_sent_selection_functions): Doc fix.
6341
0f4aebc0
LL
63422011-05-26 Leo Liu <sdl.web@gmail.com>
6343
6344 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6345
e61124cd
YM
63462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6347
6348 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6349
6350 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6351 for fringe update if it has periodic bitmap.
ac389d0c 6352 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6353 and fringe_bitmap_periodic_p.
6354
6355 * fringe.c (get_fringe_bitmap_data): New function.
6356 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6357 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6358 row. Mark glyph row for fringe update if periodicity changed.
6359
6360 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6361 for fringe update unless it has periodic bitmap.
6362
f16d9837
KH
63632011-05-25 Kenichi Handa <handa@m17n.org>
6364
6365 * xdisp.c (get_next_display_element): Set correct it->face_id for
6366 a static composition.
6367
e1b90ef6
LL
63682011-05-24 Leo Liu <sdl.web@gmail.com>
6369
6370 * deps.mk (fns.o):
6371 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6372
6373 * fns.c (crypto_hash_function, Fsha1): New function.
6374 (Fmd5): Use crypto_hash_function.
6375 (syms_of_fns): Add Ssha1.
6376
7400048f
PE
63772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6378
6379 * gnutls.c: Remove unused macros.
6380 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6381 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6382 Remove macros that are defined and never used.
6383 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6384
abb71cf4
CY
63852011-05-22 Chong Yidong <cyd@stupidchicken.com>
6386
6387 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6388 (Fx_get_selection_internal): Minor cleanup.
6389 (Fx_own_selection_internal): Rename arguments for consistency with
6390 select.el.
6391
6307db39
PE
63922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6393
6394 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6395
f3d4e0a4
CY
63962011-05-22 Chong Yidong <cyd@stupidchicken.com>
6397
6398 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6399
4d8ade89
YM
64002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6401
6402 * dispnew.c (scrolling_window): Don't exclude the case that the
6403 last enabled row in the desired matrix touches the bottom boundary.
6404
32078c8d
GM
64052011-05-21 Glenn Morris <rgm@gnu.org>
6406
6407 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6408 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6409 and add some more files.
32078c8d 6410
7285dc67
EZ
64112011-05-20 Eli Zaretskii <eliz@gnu.org>
6412
6413 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6414 report_file_error introduced by the change from 2011-05-07.
6415
89d1bd22
PE
64162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6417
6418 * systime.h (Time): Define only if emacs is defined.
6419 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6420 where the include path doesn't have X11/X.h by default. See
6421 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6422
cd394be1 64232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6424
6425 * composite.c (find_automatic_composition): Fix previous change.
6426
b9704ad9
GM
64272011-05-20 Glenn Morris <rgm@gnu.org>
6428
6429 * lisp.mk: New file, split from Makefile.in.
6430 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6431 (shortlisp): Remove.
6432 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6433
4a720484
GM
64342011-05-19 Glenn Morris <rgm@gnu.org>
6435
6436 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6437 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6438 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6439 (lisp): Set the order to that of loadup.el.
6440 (shortlisp): Make it a copy of $lisp.
6441 (SOME_MACHINE_LISP): Remove.
6442 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6443 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6444
a28d4396
KH
64452011-05-18 Kenichi Handa <handa@m17n.org>
6446
6447 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6448 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6449 (find_automatic_composition): Mostly rewrite for efficiency.
6450
a2b1fa8e
JB
64512011-05-18 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * makefile.w32-in: Update dependencies.
6454
8e1f5610
CS
64552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6456
6457 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6458 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6459
7025ee00 64602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6461
cdfa6eab
PE
6462 Fix some integer overflow issues, such as string length overflow.
6463
06d6db33
PE
6464 * insdel.c (count_size_as_multibyte): Check for string overflow.
6465
2b4560a8
PE
6466 * character.c (lisp_string_width): Check for string overflow.
6467 Use EMACS_INT, not int, for string indexes and lengths; in
6468 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6469 the resulting string length overflows an EMACS_INT; instead,
6470 report a string overflow if no precision given. When checking for
6471 precision exhaustion, use a check that cannot possibly have
6472 integer overflow. (Bug#8675)
6473 * character.h (lisp_string_width): Adjust to new signature.
6474
cb93f9be
PE
6475 * alloc.c (string_overflow): New function.
6476 (Fmake_string): Use it. This doesn't change behavior, but saves
6477 a few bytes and will simplify future changes.
6478 * character.c (string_escape_byte8): Likewise.
6479 * lisp.h (string_overflow): New decl.
6480
1a1f3366
PE
6481 Fixups, following up to the user-interface timestamp change.
6482 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6483 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6484 * msdos.c (mouse_get_pos): Likewise.
6485 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6486 * w32gui.h (Time): Define by including "systime.h" rather than by
6487 declaring it ourselves. (Bug#8664)
6488
d4e3e4d3
PE
6489 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6490 * image.c (clear_image_cache): Likewise.
6491
f6a24d19
PE
6492 * term.c (term_mouse_position): Don't assume time_t wraparound.
6493
08dc5ae6
PE
6494 Be more systematic about user-interface timestamps.
6495 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6496 and sometimes 'EMACS_UINT', to represent these timestamps.
6497 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6498 This makes the code easier to follow, and makes it easier to catch
6499 integer overflow bugs such as Bug#8664.
6500 * frame.c (Fmouse_position, Fmouse_pixel_position):
6501 Use Time, not unsigned long, for user-interface timestamps.
6502 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6503 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6504 * keyboard.h (last_event_timestamp): Likewise.
6505 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6506 * menu.h (xmenu_show): Likewise.
6507 * term.c (term_mouse_position): Likewise.
6508 * termhooks.h (struct input_event.timestamp): Likewise.
6509 (struct terminal.mouse_position_hook): Likewise.
6510 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6511 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6512 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6513 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6514 what it was before.
6515 * menu.h, termhooks.h: Include "systime.h", for Time.
6516
8e55734a
PE
6517 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6518 Don't assume that the difference between two unsigned long values
6519 can fit into an integer. At this point, we know button_down_time
6520 <= event->timestamp, so the difference must be nonnegative, so
6521 there's no need to cast the result if double-click-time is
6522 nonnegative, as it should be; check that it's nonnegative, just in
6523 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6524 apart (about 25 days). (Bug#8664)
8e55734a 6525
841f1b75 6526 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6527 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6528
3e26f69c
PE
6529 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6530 that always fit in int. Use a sentinel instead of a counter, to
6531 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6532 * frame.h (struct frame): Use int for menu_bar_items_used
6533 instead of EMACS_INT, since it always fits in int.
3e26f69c 6534
5cc152c0
PE
6535 * menu.c (grow_menu_items): Check for int overflow.
6536
d89eb65e
PE
6537 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6538
5235bd3e
PE
6539 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6540 Before, the code was not consistent. These values cannot exceed
6541 2**31 - 1 so there's no need to make them unsigned.
6542 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6543 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6544 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6545 as modifiers.
6546 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6547
bc827e23
PE
6548 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6549 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6550 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6551 presumably because the widths might not match.
6552
78eb494e
PE
6553 * window.c (size_window): Avoid needless test at loop start.
6554
04f2d78b
CB
65552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6556
6557 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6558
d2fc7e3d 65592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6560
6561 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6562
d2fc7e3d 65632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6564
6565 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6566 `width' to `bar_area_x' and `bar_area_width', respectively.
6567 (x_scroll_run): Take account of fringe background extension.
6568
04f2d78b
CB
6569 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6570 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6571 `bar_area_width', respectively.
6572 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6573 background extension.
6574
79b70037
GM
65752011-05-10 Jim Meyering <meyering@redhat.com>
6576
6577 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6578
2f142cc5
JB
65792011-05-10 Juanma Barranquero <lekktu@gmail.com>
6580
6581 * image.c (Finit_image_library): Return t for built-in image types,
6582 like pbm and xbm. (Bug#8640)
6583
57679c86
AS
65842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6585
6586 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6587
888c9e86
EZ
65882011-05-07 Eli Zaretskii <eliz@gnu.org>
6589
b0512a1d
EZ
6590 * w32console.c (Fset_screen_color): Doc fix.
6591 (Fget_screen_color): New function.
6592 (syms_of_ntterm): Defsubr it.
6593
7285dc67
EZ
6594 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6595 unlink the temporary file if Fcall_process didn't create it in the
6596 first place.
6597 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6598 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6599 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6600 cue to call_process_cleanup not to close that handle.
6601
4d3fcc8e
BK
66022011-05-07 Ben Key <bkey76@gmail.com>
6603
6604 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6605 one of two shell specific rules, either bootstrap-temacs-CMD or
6606 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6607 to the previous implementation of the bootstrap-temacs rule.
6608 The bootstrap-temacs-CMD rule is similar to the previous
6609 implementation of the bootstrap-temacs rule except that it
6610 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6611 variable.
6612
6613 These changes, along with some changes to nt/configure.bat,
6614 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6615 earlier fix to add support for --cflags and --ldflags options
6616 that include quotes so that it works whether make uses cmd or
6617 sh as the shell.
6618
b4289b64
MA
66192011-05-06 Michael Albinus <michael.albinus@gmx.de>
6620
6621 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6622 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6623 is a constant.
6624 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6625 a string. Handle both cases.
6626 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6627 (Fdbus_register_method): Use Qinvalid_function.
6628
af4c0e28
JB
66292011-05-06 Juanma Barranquero <lekktu@gmail.com>
6630
6631 * makefile.w32-in: Update dependencies.
6632 (LISP_H): Add inttypes.h and stdin.h.
6633 (PROCESS_H): Add unistd.h.
6634
c51453d9
EZ
66352011-05-06 Eli Zaretskii <eliz@gnu.org>
6636
6637 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6638 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6639
8ff0ac3c 66402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6641
4c4b566b
PE
6642 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6643
aab2b9b5
PE
6644 * term.c (vfatal): Remove stray call to va_end.
6645 It's not needed and the C Standard doesn't allow it here anyway.
6646
c378da0b
PE
6647 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6648 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6649
288b08c7
PE
6650 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6651 bytes.
6652
e3601888
PE
6653 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6654
db6c0e74
PE
6655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6656
dd5963ea
PE
6657 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6658
88c9450f
PE
6659 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6660
2f9442b8
PE
6661 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6662
c032b5f8
PE
6663 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6664 * charset.c (Fdefine_charset_internal): Don't initialize
6665 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6666 32-bit int (Bug#8600).
a108c10b
PE
6667
6668 * lread.c (read_integer): Be more consistent with string-to-number.
6669 Use string_to_number to do the actual conversion; this avoids
6670 rounding errors and fixes some other screwups. Without this fix,
6671 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6672 (digit_to_number): Move earlier, for benefit of read_integer.
6673 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6674 not a digit in any supported base. (Bug#8602)
a108c10b 6675
ad5f9eea
PE
6676 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6677
aec1708a
PE
6678 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6679 to match comment at start of function. This also removes a
6680 GCC warning about overflow in a 32+64-bit port.
6681
47be4ab5
PE
6682 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6683
371cac43
PE
6684 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6685 Reported by Stefan Monnier in
6686 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6687 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6688 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6689
d01a7826
PE
6690 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6691 (EMACS_UINTPTR): Likewise, with uintptr_t.
6692
7fd47d5c
PE
6693 * lisp.h: Prefer 64-bit EMACS_INT if available.
6694 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6695 on 32-bit hosts that have 64-bit int, so that they can access
6696 large files.
122b0c86
PE
6697 However, temporarily disable this change unless the temporary
6698 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6699
8727937b
PE
6700 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6701
8ac068ac
PE
6702 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6703 This removes an assumption that EMACS_INT and long are the same
6704 width as pointers. The assumption is true for Emacs porting targets
6705 now, but we want to make other targets possible.
6706 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6707 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6708 In the rest of the code, change types of integers that hold casted
6709 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6710 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6711 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6712 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6713 No need to cast type when ORing.
6714 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6715 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6716 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6717 assume EMACS_INT is the same width as char *.
6718 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6719 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6720 Remove no-longer-needed casts.
6721 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6722 (xg_tool_bar_help_callback, xg_make_tool_item):
6723 Use EMACS_INTPTR to hold an integer
6724 that will be cast to void *; this can avoid a GCC warning
6725 if EMACS_INT is not the same width as void *.
6726 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6727 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6728 (current_message_1, set_message_1):
6729 Use a local to convert to proper width without a cast.
6730 * xmenu.c (dialog_selection_callback): Likewise.
6731
ede49d71
PE
6732 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6733 Also, don't assume VALBITS / RAND_BITS is less than 5,
6734 and don't rely on undefined behavior when shifting a 1 left into
6735 the sign bit.
6736 * lisp.h (get_random): Change signature to match.
6737
2f30ecd0
PE
6738 * lread.c (hash_string): Use size_t, not int, for hash computation.
6739 Normally we prefer signed values; but hashing is special, because
6740 it's better to use unsigned division on hash table sizes so that
6741 the remainder is nonnegative. Also, size_t is the natural width
6742 for hashing into memory. The previous code used 'int', which doesn't
6743 retain enough info to hash well into very large tables.
6744 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6745
2a866e7b
PE
6746 * dbusbind.c: Don't possibly lose pointer info when converting.
6747 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6748 Use XPNTR rather than XHASH, so that the high-order bits of
6749 the pointer aren't lost when converting through void *.
6750
51639eac
PE
6751 * eval.c (Fautoload): Don't double-shift a pointer.
6752
92394119
PE
6753 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6754
dbdb9a7c
JB
67552011-05-06 Juanma Barranquero <lekktu@gmail.com>
6756
6757 * gnutls.c (DEF_GNUTLS_FN):
6758 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6759
db7a0b4f
AS
67602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6761
6762 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6763 marker. (Bug#8610)
6764
cd394be1 67652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6766
6767 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6768 New version that can reserve upto 2GB of heap space.
6769
f7ff1b0f 67702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6771
6772 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6773
639c109b
TZ
67742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6775
6776 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6777 `gnutls_certificate_set_x509_key_file'.
6778
d2127135
JB
67792011-05-05 Juanma Barranquero <lekktu@gmail.com>
6780
6781 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6782 Update dependencies.
6783
e968f4f3
JB
67842011-05-04 Juanma Barranquero <lekktu@gmail.com>
6785
6786 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6787 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6788 Remove unused parameter `fildes'.
6789 * process.c (read_process_output, send_process): Don't pass it.
6790
84d358f0
JB
67912011-05-04 Juanma Barranquero <lekktu@gmail.com>
6792
6793 Fix previous change: the library cache is defined in w32.c.
6794 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6795 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6796
0898ca10
JB
67972011-05-04 Juanma Barranquero <lekktu@gmail.com>
6798
6799 Implement dynamic loading of GnuTLS on Windows.
6800
6801 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6802 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6803 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6804 Declare.
6805
6806 * gnutls.c (Qgnutls_dll): Define.
6807 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6808 (gnutls_*): Declare function pointers.
6809 (init_gnutls_functions): New function to initialize function pointers.
6810 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6811 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6812 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6813 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6814 (emacs_gnutls_write, emacs_gnutls_read)
6815 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6816 (Fgnutls_available_p): New function.
6817 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6818 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6819 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6820
6821 * image.c: Include w32.h.
6822 (Vimage_type_cache): Delete.
6823 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6824 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6825 (w32_delayed_load): Move to w32.c.
6826
6827 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6828
6829 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6830 (w32_delayed_load): Move from image.c. When loading a library, record
6831 its filename in the :loaded-from property of the library id.
6832 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6833 Initialize and staticpro them.
6834 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6835
6836 * process.c: Include lisp.h before w32.h, not after.
6837 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6838 instead of gnutls_record_check_pending.
6839
6840 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6841
ff4de4aa
TZ
68422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6843
6844 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6845 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6846 as passed in.
6847
abe95abb
JD
68482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6849
6850 * xterm.c (x_set_frame_alpha): Do not set property on anything
6851 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6852
e16e55d4
JB
68532011-05-02 Juanma Barranquero <lekktu@gmail.com>
6854
6855 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6856
bafcf6a5
JB
68572011-05-02 Juanma Barranquero <lekktu@gmail.com>
6858
6859 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6860 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6861 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6862 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6863 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6864 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6865 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6866 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6867 (Qgnutls_bootprop_callbacks_verify): Make static.
6868
e7a6747f
AS
68692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6870
19ed11ba
AS
6871 * callproc.c: Indentation fixup.
6872
e7a6747f 6873 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6874 (wait_for_termination, interruptible_wait_for_termination):
6875 Move after wait_for_termination_1.
e7a6747f 6876
1ef14cb4
LMI
68772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6878
6879 * sysdep.c (interruptible_wait_for_termination): New function
6880 which is like wait_for_termination, but allows keyboard
6881 interruptions.
6882
6883 * callproc.c (Fcall_process): Add (:file "file") as an option for
6884 the STDOUT buffer.
6885 (Fcall_process_region): Ditto.
6886
330d880c
EZ
68872011-04-30 Eli Zaretskii <eliz@gnu.org>
6888
8db90b73
EZ
6889 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6890 rather than `XVECTOR (FOO)->size'.
6891
330d880c
EZ
6892 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6893 inttypes.h, as a gnulib replacement is used if it not available in
6894 system headers.
6895
15cbd324
EZ
68962011-04-21 Eli Zaretskii <eliz@gnu.org>
6897
6898 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6899 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6900 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6901
6902 * coding.c (coding_alloc_by_realloc): Error out if destination
6903 will grow beyond MOST_POSITIVE_FIXNUM.
6904 (decode_coding_emacs_mule): Abort if there isn't enough place in
6905 charbuf for the composition carryover bytes. Reserve an extra
6906 space for up to 2 characters produced in a loop.
6907 (decode_coding_iso_2022): Abort if there isn't enough place in
6908 charbuf for the composition carryover bytes.
6909
69102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6911
ae940cca
EZ
6912 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6913 aborting when %lld or %lll format is passed.
6914 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6915 %llo or %llx format is passed. (Bug#8545)
6916
03ab8921
EZ
6917 * window.c (window_scroll_line_based): Use a marker instead of
6918 simple variables to record original value of point. (Bug#7952)
6919
afda1437
EZ
6920 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6921 produced by %s or %c overflows available buffer space. (Bug#8545)
6922
f76dee0c
PE
69232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6924
6925 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6926 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6927
fdc5744d
JB
69282011-04-28 Juanma Barranquero <lekktu@gmail.com>
6929
6930 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6931
638f053a
JB
69322011-04-28 Juanma Barranquero <lekktu@gmail.com>
6933
6934 * keyboard.c (Qdelayed_warnings_hook): Define.
6935 (command_loop_1): Run `delayed-warnings-hook'
6936 if Vdelayed_warnings_list is non-nil.
6937 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6938 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6939
d178f871
EZ
69402011-04-28 Eli Zaretskii <eliz@gnu.org>
6941
6942 * doprnt.c (doprnt): Don't return value smaller than the buffer
6943 size if the message was truncated. (Bug#8545).
6944
b124fd93
JB
69452011-04-28 Juanma Barranquero <lekktu@gmail.com>
6946
6947 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6948 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6949
e810457d
PE
69502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6951
6952 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6953
ea51cceb
JB
69542011-04-27 Juanma Barranquero <lekktu@gmail.com>
6955
6956 * makefile.w32-in: Update dependencies.
6957
94dcfacf
EZ
69582011-04-27 Eli Zaretskii <eliz@gnu.org>
6959
6960 Improve `doprnt' and its usage. (Bug#8545)
6961 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6962 `format_end'. Remove support for %l as a conversion specifier.
6963 Don't use xrealloc. Improve diagnostics when the %l size modifier
6964 is used. Update the commentary.
6965
6966 * eval.c (verror): Simplify calculation of size_t.
6967
6968 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6969 messages.
6970
f61f41d7
PE
69712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6972
6973 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6974 change.
6975
96fb4434
PE
69762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6977
6978 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6979 This makes this file independent of the recent pseudovector change.
6980
671875da 69812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6982
69e9b5a3
PE
6983 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6984
b5f869a7 6985 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6986 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6987 Remove unused local.
c8926152 6988 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6989
841a1577 6990 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6991 GCC 4.6.0 optimizes based on type-based alias analysis.
6992 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6993 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6994 != &v->size, and therefore "v->size = 1; b->size = 2; return
6995 v->size;" must therefore return 1. This assumption is incorrect
6996 for Emacs, since it type-puns struct Lisp_Vector * with many other
6997 types. To fix this problem, this patch adds a new type struct
f904488f 6998 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6999 and pseudovectors, and helps optimizing compilers not get fooled
7000 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7001 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7002 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7003 the size member.
eab3844f
PE
7004 (XSETPVECTYPE): Rewrite in terms of new macro.
7005 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7006 This is a bit clearer, and further avoids the possibility of
7007 undesirable aliasing.
7008 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7009 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7010 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7011 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7012 (ASIZE): Now uses header.size rather than size.
7013 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7014 to avoid the hassle of writing XVECTOR (foo)->header.size.
7015 (struct vectorlike_header): New type.
eab3844f
PE
7016 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7017 object, to help avoid aliasing.
7018 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7019 (SUBRP): Likewise, since Lisp_Subr is a special case.
7020 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7021 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7022 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7023 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7024 changed to be "header.size" and "header.next".
7025 * buffer.h (struct buffer): Likewise.
7026 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7027 * frame.h (struct frame): Likewise.
7028 * process.h (struct Lisp_Process): Likewise.
7029 * termhooks.h (struct terminal): Likewise.
7030 * window.c (struct save_window_data, struct saved_window): Likewise.
7031 * window.h (struct window): Likewise.
7032 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7033 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7034 * buffer.c (init_buffer_once): Likewise.
7035 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7036 special case.
7037 * process.c (Fformat_network_address): Use local var for size,
7038 for brevity.
7039
0df1eac5
PE
7040 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7041
847ab9d1 7042 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7043 * data.c (atof): Remove decl; no longer used or needed.
7044 (digit_to_number): Move to lread.c.
7045 (Fstring_to_number): Use new string_to_number function, to be
7046 consistent with how the Lisp reader treats infinities and NaNs.
7047 Do not assume that floating-point numbers represent EMACS_INT
7048 without losing information; this is not true on most 64-bit hosts.
7049 Avoid double-rounding errors, by insisting on integers when
7050 parsing non-base-10 numbers, as the documentation specifies.
7051 * lisp.h (string_to_number): New decl, replacing ...
7052 (isfloat_string): Remove.
bc0a5c13 7053 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7054 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7055 appears to have been a coding error. Similarly, do not accept
7056 strings like +-1e0 as floating point numbers. Do not report
7057 overflow for integer overflows unless the base is not 10 which
7058 means we have no simple and reliable way to continue.
7059 Break out the floating-point parsing into a new
7060 function string_to_number, so that Fstring_to_number parses
7061 floating point numbers consistently with the Lisp reader.
04f2d78b 7062 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7063 (E_CHAR, EXP_INT): Remove, replacing with ...
7064 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7065 (string_to_number): New function, replacing isfloat_string.
7066 This function checks for valid syntax and produces the resulting
7067 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7068 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7069 so that overflow for non-base-10 numbers is reported only when
7070 there's no portable and simple way to convert to floating point.
452f4150 7071
67769ffc
PE
7072 * textprop.c (set_text_properties_1): Rewrite for clarity,
7073 and to avoid GCC warning about integer overflow.
7074
c20db43f
PE
7075 * intervals.h (struct interval): Use EMACS_INT for members
7076 where EMACS_UINT might cause problems. See
7077 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7078 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7079 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7080 All uses changed.
37aa2f85
PE
7081 (offset_intervals): Tell GCC not to worry about length overflow
7082 when negating a negative length.
c20db43f 7083
2538aa2f
PE
7084 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7085 (overrun_check_free): Likewise.
7086
f2d3008d
PE
7087 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7088 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7089 word size.
7090
ec8df744
PE
7091 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7092 (gnutls_make_error): Rename local to avoid shadowing.
7093 (gnutls_emacs_global_deinit): ifdef out; not used.
7094 (Fgnutls_boot): Use const for pointer to readonly storage.
7095 Comment out unused local. Fix pointer signedness problems.
7096
640ee02d
PE
7097 * lread.c (openp): Don't stuff size_t into an 'int'.
7098 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7099 about possible signed overflow.
7100
6048fb2a
PE
7101 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7102 (GDK_KEY_g): Don't define if already defined.
7103 (xg_prepare_tooltip): Avoid pointer signedness problem.
7104 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7105
fa3c87e1
PE
7106 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7107 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7108
2172544b
PE
7109 * xfns.c (Fx_window_property): Simplify a bit,
7110 to make a bit faster and to avoid GCC 4.6.0 warning.
7111 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7112
9b821a21
PE
7113 * fns.c (internal_equal): Don't assume size_t fits in int.
7114
3c616cfa
PE
7115 * alloc.c (compact_small_strings): Tighten assertion a little.
7116
c2982e87
PE
7117 Replace pEd with more-general pI, and fix some printf arg casts.
7118 * lisp.h (pI): New macro, generalizing old pEd macro to other
7119 conversion specifiers. For example, use "...%"pI"d..." rather
7120 than "...%"pEd"...".
7121 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7122 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7123 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7124 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7125 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7126 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7127 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7128 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7129 64-bit hosts.
7130 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7131 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7132 * print.c (safe_debug_print, print_object): Likewise.
7133 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7134 to int.
6f04d126
PE
7135 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7136 avoiding the 0 flag, which is not portable.
c2982e87
PE
7137 * process.c (Fmake_network_process): Use pI to avoid cast.
7138 * region-cache.c (pp_cache): Likewise.
7139 * xdisp.c (decode_mode_spec): Likewise.
7140 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7141 behavior on 64-bit hosts with printf arg.
6f04d126 7142 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7143 (x_stop_queuing_selection_requests): Likewise.
7144 (x_get_window_property): Don't truncate byte count to an 'int'
7145 when tracing.
0b432f21 7146
5e073ec7
PE
7147 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7148 here, since it parses constructs like leading '-' and spaces,
7149 which are not wanted; and it overflows with large numbers.
7150 Instead, simply match F[0-9]+, which is what is wanted anyway.
7151
36372bf9
PE
7152 * alloc.c: Remove unportable assumptions about struct layout.
7153 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7154 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7155 (allocate_vectorlike, make_pure_vector): Use the new macros,
7156 plus offsetof, to remove unportable assumptions about struct layout.
7157 These assumptions hold on all porting targets that I know of, but
7158 they are not guaranteed, they're easy to remove, and removing them
7159 makes further changes easier.
7160
0b432f21
PE
7161 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7162 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7163 (string_overrun_cookie): Now const. Use initializers that
7164 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7165 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7166 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7167 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7168 multiple of sizeof (EMACS_INT); it need not be, if
7169 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7170 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7171
895009e1
JB
71722011-04-26 Juanma Barranquero <lekktu@gmail.com>
7173
7174 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7175
6a7a1b0b
TZ
71762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7177
7178 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7179 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7180 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7181
841a1577 71822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7183
7184 * lisp.h (Qdebug): List symbol.
895009e1 7185 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7186 * keyboard.c (debug-on-event): New variable.
7187 (handle_user_signal): Break into debugger when debug-on-event
7188 matches the current signal symbol.
7189
f2d3ba6f
DN
71902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7191
7192 * alloc.c (check_sblock, check_string_bytes)
7193 (check_string_free_list): Convert to standard C.
7194
42ce4c63
TZ
71952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7196
7197 * w32.c (emacs_gnutls_push): Fix typo.
7198
825cd63c
EZ
71992011-04-25 Eli Zaretskii <eliz@gnu.org>
7200
fb11d64d
EZ
7201 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7202 "cast to pointer from integer of different size".
7203
825cd63c
EZ
7204 Improve doprnt and its use in verror. (Bug#8545)
7205 * doprnt.c (doprnt): Document the set of format control sequences
7206 supported by the function. Use SAFE_ALLOCA instead of always
7207 using `alloca'.
7208
7209 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7210 is one byte too soon. Don't use xrealloc; instead xfree and
7211 xmalloc anew.
7212
e061a11b
TZ
72132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7214
7215 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7216 callbacks stage.
7217
7218 * gnutls.c: Renamed global_initialized to
7219 gnutls_global_initialized. Added internals for the
7220 :verify-hostname-error, :verify-error, and :verify-flags
7221 parameters of `gnutls-boot' and documented those parameters in the
7222 docstring. Start callback support.
9173deec
JB
7223 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7224 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7225 on error. Return error code.
e061a11b
TZ
7226 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7227 (emacs_gnutls_read): Likewise.
7228 (Fgnutls_boot): Return handshake error code.
7229 (emacs_gnutls_handle_error): New function.
7230 (wsaerror_to_errno): Likewise.
7231
7232 * w32.h (emacs_gnutls_pull): Add prototype.
7233 (emacs_gnutls_push): Likewise.
7234
7235 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7236 (emacs_gnutls_push): Likewise.
7237
72382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7239
7240 * process.c (wait_reading_process_output): Check if GnuTLS
7241 buffered some data internally if no FDs are set for TLS
7242 connections.
7243
7244 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7245 (LIBS): Link to USER_LIBS.
7246 ($(BLD)/gnutls.$(0)): New target.
7247
fa6996bc
EZ
72482011-04-24 Eli Zaretskii <eliz@gnu.org>
7249
eb35682e
EZ
7250 * xdisp.c (handle_single_display_spec): Rename the
7251 display_replaced_before_p argument into display_replaced_p, to
7252 make it consistent with the commentary. Fix typos in the
7253 commentary.
7254
e2ad650c
EZ
7255 * textprop.c (syms_of_textprop): Remove dead code.
7256 (copy_text_properties): Delete obsolete commentary about an
7257 interface that was deleted long ago. Fix typos in the description
7258 of arguments.
7259
1b2de274
EZ
7260 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7261 to changes in oldXMenu/XMenu.h from 2011-04-16.
7262 <menu_help_message, prev_menu_help_message>: Constify.
7263 (IT_menu_make_room): menu->help_text is now `const char **';
7264 adjust.
7265
7266 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7267 to changes in oldXMenu/XMenu.h from 2011-04-16.
7268 (struct XMenu): Declare `help_text' `const char **'.
7269
7270 * xfaces.c <Qunspecified>: Make extern again.
7271
7272 * syntax.c: Include sys/types.h before including regex.h, as
7273 required by Posix.
7274
762b15be
EZ
7275 * doc.c (get_doc_string): Improve the format passed to `error'.
7276
7277 * doprnt.c (doprnt): Improve commentary.
7278
7279 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7280
7281 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7282 them with etags.
7283
f1052e5d
EZ
7284 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7285 changes in globals.h immediately force recompilation.
762b15be
EZ
7286 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7287 $(CURDIR)/s/ms-w32.h.
7288 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7289
fa6996bc
EZ
7290 * character.c (Fchar_direction): Function deleted.
7291 (syms_of_character): Don't defsubr it.
7292 <char-direction-table>: Deleted.
7293
e6c3da20
EZ
72942011-04-23 Eli Zaretskii <eliz@gnu.org>
7295
7296 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7297 * doprnt.c: Include limits.h.
7298 (SIZE_MAX): New macro.
04f2d78b
CB
7299 (doprnt): Return a size_t value. 2nd arg is now size_t.
7300 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7301 Improve overflow protection. Support `l' modifier for integer
7302 conversions. Support %l conversion. Don't assume an EMACS_INT
7303 argument for integer conversions and for %c.
7304
7305 * lisp.h (doprnt): Restore prototype.
7306
7307 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7308 $(SRC)/character.h.
7309
7310 * Makefile.in (base_obj): Add back doprnt.o.
7311
7312 * deps.mk (doprnt.o): Add back prerequisites.
7313 (callint.o): Depend on character.h.
7314
7315 * eval.c (internal_lisp_condition_case): Include the handler
7316 representation in the error message.
7317 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7318 when breaking from the loop.
7319
7320 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7321
7322 * callint.c (Fcall_interactively): When displaying error message
7323 about invalid control letter, pass the character's codepoint, not
7324 a pointer to its multibyte form. Improve display of the character
7325 in octal and display also its hex code.
7326
7327 * character.c (char_string): Use %x to display the (unsigned)
7328 codepoint of an invalid character, to avoid displaying a bogus
7329 negative value.
7330
7331 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7332 `error', not SYMBOL_NAME itself.
7333
7334 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7335 character arguments to `error'.
7336
7337 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7338 to `error' in error message about FINAL_CHAR argument. Make sure
7339 FINAL_CHAR is a character, and use %c when it is passed as
7340 argument to `error'.
7341
4ffd0d6b 73422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7343
7344 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7345
7346 * w32.c: Include <time.h>.
7347 (sys_localtime): New function.
7348
4ffd0d6b 73492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7350
7351 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7352
4ffd0d6b 7353 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7354
4ffd0d6b 73552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7356
4ffd0d6b
GM
7357 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7358 zombies (Bug#8467).
aac0c6e3 7359
04c56954
EZ
73602011-04-19 Eli Zaretskii <eliz@gnu.org>
7361
7362 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7363 gl_state.e_property when gl_state.object is Qt.
7364
7365 * insdel.c (make_gap_larger): Remove limitation of buffer size
7366 to <= INT_MAX.
7367
16a43933
CY
73682011-04-18 Chong Yidong <cyd@stupidchicken.com>
7369
7370 * xdisp.c (lookup_glyphless_char_display)
7371 (produce_glyphless_glyph): Handle cons cell entry in
7372 glyphless-char-display.
7373 (Vglyphless_char_display): Document it.
7374
7375 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7376 glyphless-char-display.
7377
4581706e
CY
73782011-04-17 Chong Yidong <cyd@stupidchicken.com>
7379
7380 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7381
7382 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7383
7384 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7385 definition for no-X builds.
7386
4887c6e2 73872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7388
fd35b6f9
PE
7389 Static checks with GCC 4.6.0 and non-default toolkits.
7390
5c1ccb01
PE
7391 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7392
006c5daa
PE
7393 * process.c (keyboard_bit_set): Define only if SIGIO.
7394 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7395 (send_process): Repair possible setjmp clobbering.
7396
efc736d3
PE
7397 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7398
4e2fe2e6
PE
7399 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7400
f97334a2
PE
7401 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7402
4e75f29d
PE
7403 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7404 Define only if needed.
7405
90efadd1
PE
7406 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7407 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7408 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7409
3c647824
PE
7410 * dispextern.h (struct redisplay_interface): Rename param
7411 to avoid shadowing.
e264f262 7412 * termhooks.h (struct terminal): Likewise.
761383f4 7413 * xterm.c (xembed_send_message): Likewise.
3c647824 7414
b58c5c4a
PE
7415 * insdel.c (make_gap_smaller): Define only if
7416 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7417
cad59032
PE
7418 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7419 it.
7420
c339dc2e
PE
7421 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7422 so that we aren't warned about unused symbols.
7423
91a3e27b
PE
7424 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7425
399c71d3 7426 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7427
8ffc96f5
PE
7428 * xfns.c (x_real_positions): Mark locals as initialized.
7429
eef9bc79
PE
7430 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7431
098db9dd
PE
7432 * xterm.c: Fix problems found by static analysis with other toolkits.
7433 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7434 (x_dispatch_event): Declare static if USE_GTK, and
7435 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7436 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7437 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7438 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7439 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7440
eb18f6cc
PE
7441 * xmenu.c (menu_help_callback): Pointer type fixes.
7442 Use const pointers when pointing at readonly data. Avoid pointer
7443 signedness clashes.
7444 (FALSE): Remove unused macro.
7445 (update_frame_menubar): Remove unused decl.
7446
1fe72bf8
PE
7447 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7448
60d9e1db
PE
7449 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7450 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7451 (single_menu_item): Rename local to avoid shadowing.
7452
39261c26
PE
7453 * keyboard.c (make_lispy_event): Remove unused local var.
7454
018c5e19
PE
7455 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7456 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7457
63d2b86e
PE
7458 * bitmaps: Change bitmaps from unsigned char back to the X11
7459 compatible char. Avoid the old compiler warnings about
7460 out-of-range initializers by using, for example, '\xab' rather
7461 than 0xab.
7462
aefd87e1
PE
7463 * xgselect.c (xgselect_initialize): Check vs interface
7464 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7465
bf501fb9
PE
7466 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7467
e9829fdf
PE
7468 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7469 to read-only memory.
7470
1086c095
PE
7471 * fns.c (vector): Remove; this old hack is no longer needed.
7472
2baccd04 7473 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7474 Remove unused var.
dde42981 7475 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7476
72391843 7477 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7478
436c16df 7479 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7480 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7481 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7482
92bb796d 7483 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7484 (x_term_init): Remove local to avoid shadowing.
92bb796d 7485
764430a3 7486 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7487
7488 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7489 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7490
d1dfb56c
EZ
74912011-04-16 Eli Zaretskii <eliz@gnu.org>
7492
c4354cb4
EZ
7493 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7494
d1dfb56c
EZ
7495 Fix regex.c, syntax.c and friends for buffers > 2GB.
7496 * syntax.h (struct gl_state_s): Declare character position members
7497 EMACS_INT.
7498
7499 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7500
04f2d78b
CB
7501 * textprop.c (verify_interval_modification, interval_of):
7502 Declare arguments EMACS_INT.
d1dfb56c
EZ
7503
7504 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7505 EMACS_INT.
7506
7507 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7508
7509 * indent.c (Fvertical_motion): Local variable it_start is now
7510 EMACS_INT.
7511
7512 * regex.c (re_match, re_match_2, re_match_2_internal)
7513 (bcmp_translate, regcomp, regexec, print_double_string)
7514 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7515 (re_compile_pattern, re_exec): Declare arguments and local
7516 variables `size_t' and `ssize_t' and return values `regoff_t', as
7517 appropriate.
7518 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7519 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7520 <compile_stack_type>: `size' and `avail' are now `size_t'.
7521
7522 * regex.h <regoff_t>: Use ssize_t, not int.
7523 (re_search, re_search_2, re_match, re_match_2): Arguments that
7524 specify buffer/string position and length are now ssize_t and
7525 size_t. Return type is regoff_t.
7526
613052cd
BK
75272011-04-16 Ben Key <bkey76@gmail.com>
7528
7529 * nsfont.m: Fixed bugs in ns_get_family and
7530 ns_descriptor_to_entity that were caused by using free to
7531 deallocate memory blocks that were allocated by xmalloc (via
7532 xstrdup). This caused Emacs to crash when compiled with
7533 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7534 --enable-checking=xmallocoverrun). xfree is now used to
7535 deallocate these memory blocks.
7536
4170f62f 75372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7538
71b41406
PE
7539 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7540
9587a89d
PE
7541 emacs_write: Accept and return EMACS_INT for sizes.
7542 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7543 et seq.
7544 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7545 Accept and return EMACS_INT.
7546 (emacs_gnutls_write): Return the number of bytes written on
7547 partial writes.
7548 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7549 (emacs_read, emacs_write): Remove check for negative size, as the
7550 Emacs source code has been audited now.
9587a89d
PE
7551 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7552 (emacs_read, emacs_write): Use it.
273a5f82
PE
7553 * process.c (send_process): Adjust to the new signatures of
7554 emacs_write and emacs_gnutls_write. Do not attempt to store
7555 a byte offset into an 'int'; it might overflow.
9587a89d 7556 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7557
3e047f51
PE
7558 * sound.c: Don't assume sizes fit in 'int'.
7559 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7560 Return EMACS_INT, not int.
3e047f51 7561 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7562 Accept EMACS_INT, not int.
7563 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7564 record read return values.
7565
cc39a9db
BK
75662011-04-15 Ben Key <bkey76@gmail.com>
7567
c9d0ec6d
JB
7568 * keyboard.c (Qundefined): Don't declare static since it is used
7569 in nsfns.m.
7570 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7571 static since they are used in nsfont.m.
cc39a9db 7572
6c60eb9f
SM
75732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7574
7575 * process.c (Qprocessp): Don't declare static.
7576 * lisp.h (Qprocessp): Declare again.
7577
7990b61a
JB
75782011-04-15 Juanma Barranquero <lekktu@gmail.com>
7579
7580 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7581
5d4cb038
PE
75822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7583
8bd7b830 7584 Improve C-level modularity by making more things 'static'.
cd64ea1d 7585
e3b27b31
PE
7586 Don't publish debugger-only interfaces to other modules.
7587 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7588 (verify_bytepos, count_markers): Move decls to the only modules
7589 that need them.
7590 * region-cache.h (pp_cache): Likewise.
7591 * window.h (check_all_windows): Likewise.
7592 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7593
5d4cb038
PE
7594 * sysdep.c (croak): Now static, if
7595 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7596 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7597
7598 * alloc.c (refill_memory_reserve): Now static if
7599 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7600 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7601
e87b6180
PE
7602 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7603 Define only if USE_LUCID.
7604
ac64929e
PE
7605 * xrdb.c (x_customization_string, x_rm_string): Now static.
7606
6f37259d
PE
7607 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7608 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7609
1683e3ab
PE
7610 * xdisp.c (draw_row_with_mouse_face): Now static.
7611 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7612
de9c2632
PE
7613 * window.h (check_all_windows): Mark externally visible.
7614
2b96acb7
PE
7615 * window.c (window_deletion_count): Now static.
7616
7617 * undo.c: Make symbols static if they're not exported.
7618 (last_undo_buffer, last_boundary_position, pending_boundary):
7619 Now static.
7620
50436f33
PE
7621 * textprop.c (interval_insert_behind_hooks): Now static.
7622 (interval_insert_in_front_hooks): Likewise.
7623
64520e5c
PE
7624 * term.c: Make symbols static if they're not exported.
7625 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7626 (max_frame_lines, tty_set_terminal_modes):
7627 (tty_reset_terminal_modes, tty_turn_off_highlight):
7628 (get_tty_terminal): Now static.
7629 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7630 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7631 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7632 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7633 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7634
1fa53021
PE
7635 * sysdep.c: Make symbols static if they're not exported.
7636 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7637 Now static.
7638 (sigprocmask_set, full_mask): Remove; unused.
7639 (wait_debugging): Mark as visible.
7640 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7641 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7642
d4b43b22
PE
7643 * syntax.c (syntax_temp): Define only if !__GNUC__.
7644
b7c513d0
PE
7645 * sound.c (current_sound_device, current_sound): Now static.
7646
989b29ad
PE
7647 * search.c (searchbufs, searchbuf_head): Now static.
7648
13a55a78
PE
7649 * scroll.c (scroll_cost): Remove; unused.
7650 * dispextern.h (scroll_cost): Remove decl.
7651
de68a1fc
PE
7652 * region-cache.h (pp_cache): Mark as externally visible.
7653
40ccffa6
PE
7654 * process.c: Make symbols static if they're not exported.
7655 (process_tick, update_tick, create_process, chan_process):
7656 (Vprocess_alist, proc_buffered_char, datagram_access):
7657 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7658 (deactivate_process): Mark defn as static, as well as decl.
7659 * lisp.h (create_process): Remove decl.
7660 * process.h (chan_process, Vprocess_alist): Remove decls.
7661
ad64fc97
PE
7662 * print.c: Make symbols static if they're not exported.
7663 (print_depth, new_backquote_output, being_printed, print_buffer):
7664 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7665 (print_interval, print_number_index, initial_stderr_stream):
7666 Now static.
7667 * lisp.h (Fprinc): Remove decl.
7668 (debug_output_compilation_hack): Mark as externally visible.
7669
adddb265
PE
7670 * sysdep.c (croak): Move decl from here to syssignal.h.
7671 * syssignal.h (croak): Put it here, so the API can be checked when
7672 'croak' is called from dissociate_if_controlling_tty.
7673
1717ede2
PE
7674 * minibuf.c: Make symbols static if they're not exported.
7675 (minibuf_save_list, choose_minibuf_frame): Now static.
7676 * lisp.h (choose_minibuf_frame): Remove decl.
7677
fa5fb2bc
PE
7678 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7679
1e3890d1
PE
7680 * lread.c: Make symbols static if they're not exported.
7681 (read_objects, initial_obarray, oblookup_last_bucket_number):
7682 Now static.
7683 (make_symbol): Remove; unused.
7684 * lisp.h (initial_obarray, make_symbol): Remove decls.
7685
8a1414fa
PE
7686 * keyboard.c: Make symbols static if they're not exported.
7687 (single_kboard, recent_keys_index, total_keys, recent_keys):
7688 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7689 (this_single_command_key_start, echoing, last_auto_save):
7690 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7691 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7692 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7693 (Vlispy_mouse_stem, double_click_count):
7694 Now static.
7695 (force_auto_save_soon): Define only if SIGDANGER.
7696 (ignore_mouse_drag_p): Now static if
7697 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7698 (print_help): Remove; unused.
7699 (stop_character, last_timer_event): Mark as externally visible.
7700 * keyboard.h (ignore_mouse_drag_p): Declare only if
7701 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7702 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7703 * lisp.h (echoing): Remove decl.
7704 (force_auto_save_soon): Declare only if SIGDANGER.
7705 * xdisp.c (redisplay_window): Simplify code, to make it more
7706 obvious that ignore_mouse_drag_p is not accessed if !defined
7707 USE_GTK && !defined HAVE_NS.
7708
93ea6e8f
PE
7709 * intervals.c: Make symbols static if they're not exported.
7710 (merge_properties_sticky, merge_interval_right, delete_interval):
7711 Now static.
7712 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7713
77382fcc
PE
7714 * insdel.c: Make symbols static if they're not exported.
7715 However, leave prepare_to_modify_buffer alone. It's never
7716 called from outside this function, but that appears to be a bug.
7717 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7718 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7719 (adjust_after_replace_noundo): Remove; unused.
7720 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7721 (signal_before_change): Remove decls.
77382fcc 7722
9306c32e
PE
7723 * indent.c (val_compute_motion, val_vmotion): Now static.
7724
cd44d2eb
PE
7725 * image.c: Make symbols static if they're not exported.
7726 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7727 if USE_GTK.
7728 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7729 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7730
ad9a7a06
PE
7731 * fringe.c (standard_bitmaps): Now static.
7732 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7733
81626931
PE
7734 * frame.c: Make symbols static if they're not exported.
7735 (x_report_frame_params, make_terminal_frame): Now static.
7736 (get_frame_param): Now static, unless HAVE_NS.
7737 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7738 (x_get_resource_string): Remove; not used.
7739 * frame.h (make_terminal_frame, x_report_frame_params):
7740 (x_get_resource_string); Remove decls.
7741 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7742 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7743
239f9db9
PE
7744 * font.c, fontset.c: Make symbols static if they're not exported.
7745 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7746 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7747 * font.c (font_close_object): Now static.
7748 * font.h (font_close_object): Remove.
7749 * fontset.c (FONTSET_OBJLIST): Remove.
7750 (free_realized_fontset) #if-0 the body, which does nothing.
7751 (face_suitable_for_char_p): #if-0, as it's never called.
7752 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7753 * xfaces.c (face_at_string_position):
7754 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7755 since 0 is always ASCII.
7756
dfcf3579
PE
7757 * fns.c (weak_hash_tables): Now static.
7758
5045092b
PE
7759 * fileio.c: Make symbols static if they're not exported.
7760 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7761 (Vwrite_region_annotation_buffers): Now static.
7762
57a96f5c
PE
7763 * eval.c: Make symbols static if they're not exported.
7764 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7765 * lisp.h (backtrace_list): Remove decl.
7766
35f08c38
PE
7767 * emacs.c: Make symbols static if they're not exported.
7768 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7769 (fatal_error_code, fatal_error_signal_hook, standard_args):
7770 Now static.
7771 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7772 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7773 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7774 * lisp.h (fatal_error_signal_hook): Remove decl.
7775 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7776
f44bd759
PE
7777 * editfns.c: Move a (normally-unused) function to its only use.
7778 * editfns.c, lisp.h (get_operating_system_release): Remove.
7779 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7780 worth the hassle of breaking this out.
7781
b532497d
PE
7782 * xterm.c: Make symbols static if they're not exported.
7783 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7784 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7785 (x_destroy_window, x_delete_display):
7786 Now static.
7787 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7788 (x_mouse_leave): Remove; unused.
7789 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7790 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7791 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7792 Remove decls.
7793 (x_mouse_leave): Declare only if WINDOWSNT.
7794 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7795 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7796 USE_X_TOOLKIT.
7797
1675728f
PE
7798 * ftxfont.c: Make symbols static if they're not exported.
7799 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7800 HAVE_FREETYPE.
7801 * font.h (ftxfont_driver): Likewise.
7802
e4cebfca
PE
7803 * xfns.c: Make symbols static if they're not exported.
7804 (x_last_font_name, x_display_info_for_name):
7805 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7806 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7807 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7808 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7809 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7810 (last_show_tip_args): Now static.
7811 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7812 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7813 (x_screen_planes): Remove; unused.
7814 * dispextern.h (x_screen_planes): Remove decl.
7815
5bf46f05
PE
7816 * dispnew.c: Make symbols static if they're not exported.
7817 * dispextern.h (redraw_garbaged_frames, scrolling):
7818 (increment_row_positions): Remove.
7819 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7820 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7821 Now static.
7822 (redraw_garbaged_frames): Remove; unused.
7823
435f4c28
PE
7824 * xfaces.c: Make symbols static if they're not exported.
7825 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7826 Remove decls.
7827 * xterm.h (defined_color): Remove decls.
7828 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7829 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7830 (menu_face_changed_default, defined_color, free_realized_face):
7831 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7832 (ascii_face_of_lisp_face): Remove; unused.
7833
8524aef3
PE
7834 * xdisp.c: Make symbols static if they're not exported.
7835 * dispextern.h (scratch_glyph_row, window_box_edges):
7836 (glyph_to_pixel_coords, set_cursor_from_row):
7837 (get_next_display_element, set_iterator_to_next):
7838 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7839 (show_mouse_face): Remove decls
7840 * frame.h (message_buf_print): Likewise.
7841 * lisp.h (pop_message, set_message, check_point_in_composition):
7842 Likewise.
7843 * xterm.h (set_vertical_scroll_bar): Likewise.
7844 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7845 (message_buf_print, scratch_glyph_row, displayed_buffer):
7846 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7847 (get_next_display_element, show_mouse_face, window_box_edges):
7848 (frame_to_window_pixel_xy, check_point_in_composition):
7849 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7850 (glyph_to_pixel_coords): Remove; unused.
7851
16390cd2
PE
7852 * dired.c (file_name_completion): Now static.
7853
7854 * dbusbind.c (xd_in_read_queued_messages): Now static.
7855
a25f4dfa
PE
7856 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7857 * data.c (circular_list_error): Remove.
7858
14a9c8df
PE
7859 * commands.h (last_point_position, last_point_position_buffer):
7860 (last_point_position_window): Remove decls.
7861 * keyboard.c: Make these variables static.
7862
04f2d78b
CB
7863 * coding.h (coding, code_convert_region, encode_coding_gap):
7864 Remove decls.
74ab6df5
PE
7865 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7866 (iso_code_class, detect_coding, code_convert_region): Now static.
7867 (encode_coding_gap): Remove; unused.
7868
38dfbee1
PE
7869 * chartab.c (chartab_chars, chartab_bits): Now static.
7870
a2cb4e63
PE
7871 * charset.h (charset_iso_8859_1): Remove decl.
7872 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7873 Now static.
7874
127198fd
PE
7875 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7876 * ccl.c (Vccl_program_table): Now static.
7877 (check_ccl_update): Remove; unused.
7878
d85b608f
PE
7879 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7880 * category.h: ... from here.
7881 * category.c (check_category_table, set_category_set): Now static.
7882
31cd66f3
PE
7883 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7884 * lisp.h: Remove these decls.
7885
c358e587
PE
7886 * buffer.c (buffer_count): Remove unused var.
7887
e78aecca
PE
7888 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7889 so that it's not optimized away.
7890 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7891 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7892 exported only to the debugger.
7893
e192d7d3 7894 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7895 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7896
92470028
PE
7897 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7898 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7899 was inaccessible from Lisp.
7900 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7901 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7902
244ed907
PE
7903 alloc.c: Import and export fewer symbols, and remove unused items.
7904 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7905 is defined.
7906 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7907 it's not optimized away by whole-program optimization.
7908 (message_enable_multibyte, free_misc): Remove.
7909 (catchlist, handlerlist, mark_backtrace):
7910 Declare only if BYTE_MARK_STACK.
7911 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7912 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7913 (message_enable_multibyte): Remove decl.
7914 (free_misc, interval_free_list, float_block, float_block_index):
7915 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7916 (cons_free_list, last_marked_index):
7917 Now static.
7918 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7919 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7920 (mark_backtrace): Define only if BYTE_MARK_STACK.
7921 * xdisp.c (message_enable_multibyte): Now static.
7922
61c2b50e 7923 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7924 This makes it easier for human readers (and static analyzers)
7925 to see whether these variables are used from other modules.
7926 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7927 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7928 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7929 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7930 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7931 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7932 * xmenu.c, xselect.c:
7933 Declare Q* vars static if they are not used in other modules.
7934 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7935 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7936 Remove decls of unexported vars.
7937 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7938
95c82688
PE
7939 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7940
16a97296
PE
7941 Make Emacs functions such as Fatom 'static' by default.
7942 This makes it easier for human readers (and static analyzers)
7943 to see whether these functions can be called from other modules.
7944 DEFUN now defines a static function. To make the function external
7945 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7946 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7947 (Finit_image_library):
16a97296
PE
7948 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7949 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7950 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7951 Remove decls, since these functions are now static.
7952 (Funintern, Fget_internal_run_time): New decls, since these functions
7953 were already external.
95c82688 7954
16a97296
PE
7955 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7956 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7957 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7958 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7959 * keyboard.c, keymap.c, lread.c:
7960 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7961 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7962 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7963 Mark functions with DEFUE instead of DEFUN,
7964 if they are used in other modules.
7965 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7966 decls for now-static functions.
7967 * buffer.h (Fdelete_overlay): Remove decl.
7968 * callproc.c (Fgetenv_internal): Mark as internal.
7969 * composite.c (Fremove_list_of_text_properties): Remove decl.
7970 (Fcomposition_get_gstring): New forward static decl.
7971 * composite.h (Fcomposite_get_gstring): Remove decl.
7972 * dired.c (Ffile_attributes): New forward static decl.
7973 * doc.c (Fdocumntation_property): New forward static decl.
7974 * eval.c (Ffetch_bytecode): New forward static decl.
7975 (Funintern): Remove extern decl; now in .h file where it belongs.
7976 * fileio.c (Fmake_symbolic_link): New forward static decl.
7977 * image.c (Finit_image_library): New forward static decl.
7978 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7979 * intervals.h (Fprevious_property_change):
7980 (Fremove_list_of_text_properties): Remove decls.
7981 * keyboard.c (Fthis_command_keys): Remove decl.
7982 (Fcommand_execute): New forward static decl.
7983 * keymap.c (Flookup_key): New forward static decl.
7984 (Fcopy_keymap): Now static.
7985 * keymap.h (Flookup_key): Remove decl.
7986 * process.c (Fget_process): New forward static decl.
7987 (Fprocess_datagram_address): Mark as internal.
7988 * syntax.c (Fsyntax_table_p): New forward static decl.
7989 (skip_chars): Remove duplicate decl.
7990 * textprop.c (Fprevious_property_change): New forward static decl.
7991 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7992 Now internal.
7993 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7994 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7995
785bbd42
PE
7996 * editfns.c (Fformat): Remove unreachable code.
7997
8b913b57
AS
79982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7999
8000 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8001 change. (Bug#8496)
8002
a6744a35
EZ
80032011-04-13 Eli Zaretskii <eliz@gnu.org>
8004
8005 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8006 when at ZV. (Bug#8487)
8007
e7974947
AS
80082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8009
baad03f0
AS
8010 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8011 (Bug#8437)
8012 * keyboard.c (parse_tool_bar_item): Likewise.
8013 * sound.c (sound_cleanup, alsa_close): Likewise.
8014 * termcap.c (tgetent): Likewise.
8015 * xfns.c (x_default_font_parameter): Likewise.
8016 * xsettings.c (read_and_apply_settings): Likewise.
8017
e7974947
AS
8018 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8019 (overrun_check_free): Protoize.
8020
28272684
PE
80212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8022
8023 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8024 since callers should never pass a negative size.
8025 Change the signature to match that of plain 'read' and 'write'; see
8026 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8027 * lisp.h: Update prototypes of emacs_write and emacs_read.
8028
11997c76
EZ
80292011-04-11 Eli Zaretskii <eliz@gnu.org>
8030
8031 * xdisp.c (redisplay_window): Don't try to determine the character
8032 position of the scroll margin if the window start point w->startp
e896f03c 8033 is outside the buffer's accessible region. (Bug#8468)
11997c76 8034
8a2cbd72
EZ
80352011-04-10 Eli Zaretskii <eliz@gnu.org>
8036
8037 Fix write-region and its subroutines for buffers > 2GB.
8038 * fileio.c (a_write, e_write): Modify declaration of arguments and
8039 local variables to support buffers larger than 2GB.
8040 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8041
8042 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8043 argument, local variables, and return value.
8044
8045 * lisp.h: Update prototypes of emacs_write and emacs_read.
8046
8047 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8048
4073e537 80492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8050
1ebfdcb6
PE
8051 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8052
b2ded58d
PE
8053 Fix more problems found by GCC 4.6.0's static checks.
8054
7d66342c
PE
8055 * xdisp.c (vmessage): Use a better test for character truncation.
8056
bbf47d44
PE
8057 * charset.c (load_charset_map): <, not <=, for optimization,
8058 and to avoid potential problems with integer overflow.
9248994d 8059 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8060 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8061 * editfns.c (Fformat): Likewise.
1e69125e 8062 * syntax.c (skip_chars): Likewise.
3befa583 8063
e3019616
PE
8064 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8065 This also lets GCC 4.6.0 generate slightly better loop code.
8066
becfa255
PE
8067 * callint.c (Fcall_interactively): <, not <=, for optimization.
8068 (Fcall_interactively): Count the number of arguments produced,
8069 not the number of arguments given. This is simpler and lets GCC
8070 4.6.0 generate slightly better code.
8071
dae0cd48
PE
8072 * ftfont.c: Distingish more carefully between FcChar8 and char.
8073 The previous code passed unsigned char * to a functions like
8074 strlen and xstrcasecmp that expect char *, which does not
8075 conform to the C standard.
8076 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8077 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8078 char * when the C standard requires it.
8079
76032d70
PE
8080 * keyboard.c (read_char): Remove unused var.
8081
eb3f1cc8
PE
8082 * eval.c: Port to Windows vsnprintf (Bug#8435).
8083 Include <limits.h>.
8084 (SIZE_MAX): Define if the headers do not.
8085 (verror): Do not give up if vsnprintf returns a negative count.
8086 Instead, grow the buffer. This ports to Windows vsnprintf, which
8087 does not conform to C99. Problem reported by Eli Zaretskii.
8088 Also, simplify the allocation scheme, by avoiding the need for
8089 calling realloc, and removing the ALLOCATED variable.
8090
70476b54
PE
8091 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8092
12020a9e
PE
8093 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8094 But keep the doprint source code for now, as we might revamp it
8095 and use it again (Bug#8435).
ea6c7ae6
PE
8096 * lisp.h (doprnt): Remove.
8097 * Makefile.in (base_obj): Remove doprnt.o.
8098 * deps.mk (doprnt.o): Remove.
8099
5fdb398c
PE
8100 error: Print 32- and 64-bit integers portably (Bug#8435).
8101 Without this change, on typical 64-bit hosts error ("...%d...", N)
8102 was used to print both 32- and 64-bit integers N, which relied on
8103 undefined behavior.
61bdb816 8104 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8105 * lisp.h (error, verror): Mark as printf-like functions.
8106 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8107 Report overflow in size calculations when allocating printf buffer.
8108 Do not truncate output string at its first null byte.
8109 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8110 Truncate the output at a character boundary, since vsnprintf does not
8111 do that.
8112 * charset.c (check_iso_charset_parameter): Convert internal
8113 character to string before calling 'error', since %c now has the
8114 printf meaning.
8115 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8116 overflow when computing char to be passed to 'error'. Do not
8117 pass Lisp_Object to 'error'; pass the integer instead.
8118 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8119 formatted with plain %d.
8120
b189fa66
PE
8121 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8122
bff87ef0
PE
8123 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8124
7e2cac20
PE
8125 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8126
ce4d90b5
PE
8127 * xterm.c (x_catch_errors): Remove duplicate declaration.
8128
266c9547
PE
8129 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8130
79c49ad2
PE
8131 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8132
368f4090
JM
81332011-04-10 Jim Meyering <meyering@redhat.com>
8134
8135 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8136 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8137 return ssize_t not "int", and use size_t as the buffer length.
8138 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8139 * gnutls.h: Update declarations.
8140 * process.c (read_process_output): Use ssize_t, to match.
8141 (send_process): Likewise.
8142
a32d4040
CY
81432011-04-09 Chong Yidong <cyd@stupidchicken.com>
8144
8145 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8146
8546720e 81472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8148
04f2d78b
CB
8149 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8150 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8151
8546720e
GM
8152 * xterm.c (handle_one_xevent):
8153 * xmenu.c (create_and_show_popup_menu):
8154 * xselect.c (x_decline_selection_request)
8155 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8156
0a2f5c1a 81572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8158
8159 Fix some uses of `int' instead of EMACS_INT.
8160 * search.c (string_match_1, fast_string_match)
8161 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8162 (scan_buffer, find_next_newline_no_quit)
8163 (find_before_next_newline, search_command, Freplace_match)
8164 (Fmatch_data): Make some `int' variables be EMACS_INT.
8165
8166 * xdisp.c (display_count_lines): 3rd argument and return value now
8167 EMACS_INT. All callers changed.
8168 (pint2hrstr): Last argument is now EMACS_INT.
8169
8170 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8171 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8172 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8173 (decode_coding_utf_16, decode_coding_emacs_mule)
8174 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8175 (decode_coding_ccl, decode_coding_charset)
8176 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8177 (decode_coding_iso_2022, decode_coding_emacs_mule)
8178 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8179 <char_offset, last_offset>: Declare EMACS_INT.
8180 (encode_coding_utf_8, encode_coding_utf_16)
8181 (encode_coding_emacs_mule, encode_invocation_designation)
8182 (encode_designation_at_bol, encode_coding_iso_2022)
8183 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8184 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8185 Declare EMACS_INT.
8186 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8187 (encode_invocation_designation): Last argument P_NCHARS is now
8188 EMACS_INT.
8189 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8190 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8191
8192 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8193 All users changed.
8194
8195 * ccl.c (Fccl_execute_on_string): Declare some variables
8196 EMACS_INT.
8197
8546720e 81982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8199
8200 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8201
4e19a977
CS
82022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8203
8204 * process.c (Fformat_network_address): Doc fix.
8205
87302331
R
82062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8207
ee7683eb 8208 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8209
cbb59342
CY
82102011-04-08 Chong Yidong <cyd@stupidchicken.com>
8211
8212 * keyboard.c (read_char): Call Lisp function help-form-show,
8213 instead of using internal_with_output_to_temp_buffer.
8214 (Qhelp_form_show): New var.
e0d38eeb 8215 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8216
8217 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8218
8219 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8220
e67a13ab
CY
82212011-04-06 Chong Yidong <cyd@stupidchicken.com>
8222
04f2d78b
CB
8223 * process.c (Flist_processes): Remove to Lisp.
8224 (list_processes_1): Delete.
e67a13ab 8225
973f782d
EZ
82262011-04-06 Eli Zaretskii <eliz@gnu.org>
8227
7c106b1e
EZ
8228 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8229
973f782d
EZ
8230 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8231
41cf7d1a 82322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8233
ca23cc88
PE
8234 Fix more problems found by GCC 4.6.0's static checks.
8235
f390e2d5
PE
8236 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8237
42eea0d0
PE
8238 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8239
b69769da 8240 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8241
f9541e84
PE
8242 * xdisp.c (vmessage): Mark as a printf-like function.
8243
13841b55
PE
8244 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8245
c136c10f
PE
8246 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8247
5e2d4a30
PE
8248 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8249 printf-like functions.
8250 (tiff_load): Add casts to remove these marks before passing them
8251 to system-supplied API.
8252
583f48b9
PE
8253 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8254
b25d760e
PE
8255 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8256 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8257 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8258 directly, rather than having caller test rule sign. This avoids
8259 some unnecessary tests.
8260 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8261 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8262 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8263
bc7b6697 8264 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8265 (xfont_open): Avoid unnecessary tests.
bc7b6697 8266
27ccc379
PE
8267 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8268
dcd5c89a
PE
8269 * composite.h, composite.c (composition_gstring_put_cache):
8270 Use EMACS_INT, not int, for length.
8271
b13a45c6
PE
8272 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8273 breaking out part of COMPOSITION_DECODE_RULE.
8274 (COMPOSITION_DECODE_RULE): Use it.
8275 * composite.c (get_composition_id): Remove unused local vars,
8276 by using the new macro.
8277
1e792e4d
PE
8278 * textprop.c (set_text_properties_1): Change while to do-while,
8279 since the condition is always true at first.
8280
dc6c6455 8281 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8282 (interval_deletion_adjustment): Return unsigned value.
8283 All uses changed.
dc6c6455 8284
aba7731a
PE
8285 * process.c (list_processes_1, create_pty, read_process_output):
8286 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8287 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8288 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8289 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8290 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8291
fdfc4bf3
PE
8292 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8293
fca8fe46 8294 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8295 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8296
06a0259a 8297 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8298 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8299 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8300
e7b9e80f
PE
8301 * print.c (print_error_message): Avoid int overflow.
8302
56201685
PE
8303 * font.c (font_list_entities): Redo for clarity,
8304 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8305
78834453 8306 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8307 (font_score): Avoid potential overflow in diff calculation.
78834453 8308
0bc0b309 8309 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8310 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8311
e610eaca
PE
8312 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8313
b895abce
PE
8314 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8315 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8316 can always succeed if overflow has undefined behavior.
8317
1f1d9321 8318 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8319 (wordify): Omit three unnecessary tests.
1f1d9321 8320
c59478bc
PE
8321 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8322 All callers changed. This avoids the need for an unused var.
8323
79b73827
PE
8324 * casefiddle.c (casify_region): Remove var that is set but not used.
8325
a4db5dfe
PE
8326 * dired.c (file_name_completion): Remove var that is set but not used.
8327
43aae36e
PE
8328 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8329
2a47c44d 8330 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8331 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8332
a37c69bf
PE
8333 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8334 Check for integer overflow on size calculations.
8335
328ab8e7
PE
8336 * buffer.c (Fprevious_overlay_change): Remove var that is set
8337 but not used.
8338
e5a2a5cb
PE
8339 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8340 Remove vars that are set but not used.
8d84a6eb 8341 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8342 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8343
a60e5f68
PE
8344 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8345
f661cb61 8346 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8347 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8348
f0397f5a
PE
8349 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8350 that are set but not used.
8351
8664db06 8352 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8353 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8354
6abdaa4a
PE
8355 * xselect.c (x_get_local_selection, x_handle_property_notify):
8356 Remove vars that are set but not used.
8357
0ce7538d 8358 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8359 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8360
9ae848fc
PE
8361 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8362 Remove var that is set but not used.
0b918413
PE
8363 (scroll_bar_windows_size): Now size_t, not int.
8364 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8365 Check for overflow.
9ae848fc 8366
a5a62657
PE
8367 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8368 (map_tty_color) [!defined MSDOS]: Likewise.
8369
5c5cdd39
PE
8370 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8371
66ebf983
PE
8372 * coding.c: Remove vars that are set but not used.
8373 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8374 All callers changed.
8375 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8376 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8377 (decode_coding_charset): Remove vars that are set but not used.
8378
1be4d761
PE
8379 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8380 that is set but not used.
8381
47553fa8
PE
8382 * print.c (print_object): Remove var that is set but not used.
8383
1f7196bf 8384 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8385 The gnulib version avoids calling malloc in the usual case,
8386 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8387 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8388 * filelock.c (current_lock_owner): Likewise.
8389 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8390 * sysdep.c: Include allocator.h, careadlinkat.h.
8391 (emacs_no_realloc_allocator): New static constant.
8392 (emacs_readlink): New function.
fdb61804
PE
8393 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8394 ../lib/careadlinkat.h.
d1fdcab7 8395
f84c17c7
SM
83962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8397
8398 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8399 first non-nil return value).
8400
ef3862ad
JD
84012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8402
8403 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8404 if not defined (Bug#8403).
8405
376a7006
JB
84062011-04-02 Juanma Barranquero <lekktu@gmail.com>
8407
8408 * xdisp.c (display_count_lines): Remove parameter `start',
8409 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8410 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8411 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8412 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8413 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8414 and thereabouts. All callers changed.
8415 (get_per_char_metric): Remove parameter `f', unused since
8416 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8417
6ca3801d
JM
84182011-04-02 Jim Meyering <meyering@redhat.com>
8419
8420 do not dereference NULL upon failed strdup
8421 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8422 (ns_get_family): Likewise.
8423
d8e2b5ba
JB
84242011-04-02 Juanma Barranquero <lekktu@gmail.com>
8425
8426 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8427
8c74fcbd
JD
84282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8429
8430 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8431 later (Bug#8403).
8432
7200d79c
SM
84332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8434
03408648 8435 Add lexical binding.
7200d79c 8436
03408648
SM
8437 * window.c (Ftemp_output_buffer_show): New fun.
8438 (Fsave_window_excursion):
8439 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8440
8441 * lread.c (lisp_file_lexically_bound_p): New function.
8442 (Fload): Bind Qlexical_binding.
8443 (readevalloop): Remove `evalfun' arg.
8444 Bind Qinternal_interpreter_environment.
8445 (Feval_buffer): Bind Qlexical_binding.
8446 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8447 Mark as dynamic.
8448 (syms_of_lread): Declare `lexical-binding'.
8449
8450 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8451
8452 * keyboard.c (eval_dyn): New fun.
8453 (menu_item_eval_property): Use it.
ca105506
SM
8454
8455 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8456
03408648
SM
8457 * fns.c (concat, mapcar1): Accept byte-code-functions.
8458
8459 * eval.c (Fsetq): Handle lexical vars.
8460 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8461 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8462 (FletX, Flet): Obey lexical binding.
8463 (Fcommandp): Handle closures.
8464 (Feval): New `lexical' arg.
8465 (eval_sub): New function extracted from Feval. Use it almost
8466 everywhere where Feval was used. Look up vars in lexical env.
8467 Handle closures.
8468 (Ffunctionp): Move from subr.el.
8469 (Ffuncall): Handle closures.
8470 (apply_lambda): Remove `eval_flags'.
8471 (funcall_lambda): Handle closures and new byte-code-functions.
8472 (Fspecial_variable_p): New function.
8473 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8474 but without exporting it to Lisp.
23aba0ea 8475
23aba0ea 8476 * doc.c (Fdocumentation, store_function_docstring):
03408648 8477 * data.c (Finteractive_form): Handle closures.
23aba0ea 8478
03408648
SM
8479 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8480 interactive spec.
ba83908c 8481
04f2d78b
CB
8482 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8483 New byte-codes.
03408648
SM
8484 (exec_byte_code): New function extracted from Fbyte_code to handle new
8485 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8486
03408648 8487 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8488
03408648 8489 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8490
e2abce01
JB
84912011-03-31 Juanma Barranquero <lekktu@gmail.com>
8492
8493 * xdisp.c (redisplay_internal): Fix prototype.
8494
63696a73 84952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8496
63696a73 8497 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8498 (try_scrolling): Use it when setting scroll_limit.
8499 Limit scrolling to 100 screen lines.
63696a73
EZ
8500 (redisplay_window): Even when falling back on "recentering",
8501 position point in the window according to scroll-conservatively,
8502 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8503
8504 (try_scrolling): When point is above the window, allow searching
8505 as far as scroll_max, or one screenful, to compute vertical
8506 distance from PT to the scroll margin position. This prevents
8507 try_scrolling from unnecessarily failing when
8508 scroll-conservatively is set to a value slightly larger than the
8509 window height. Clean up the case of PT below the margin at bottom
8510 of window: scroll_max can no longer be INT_MAX. When aggressive
8511 scrolling is in use, don't let point enter the opposite scroll
8512 margin as result of the scroll.
8513 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8514 threshold of 100 lines for never-recentering scrolling.
8515
e4cc2dfc
JB
85162011-03-31 Juanma Barranquero <lekktu@gmail.com>
8517
8518 * dispextern.h (move_it_by_lines):
8519 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8520 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8521 (message_log_check_duplicate): Remove parameters `prev_bol' and
8522 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8523 (redisplay_internal): Remove parameter `preserve_echo_area',
8524 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8525
8526 * indent.c (Fvertical_motion):
8527 * window.c (window_scroll_pixel_based, Frecenter):
8528 Don't pass `need_y_p' to `move_it_by_lines'.
8529
1c470562
SM
85302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8531
44f230aa
SM
8532 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8533 steal a few bits to be more compact.
8534 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8535 Remove unneeded casts.
8536
1c470562
SM
8537 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8538
888adce9
ZK
85392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8540
8541 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8542 binding" message (bug#7967).
8543
f838ed7b
PE
85442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8545
77861b95
PE
8546 Fix more problems found by GCC 4.6.0's static checks.
8547
de6dbc14
PE
8548 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8549 Remove unused local var.
8550
f838ed7b
PE
8551 * editfns.c (Fmessage_box): Remove unused local var.
8552
792c7b2b
PE
8553 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8554 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8555 Omit unused local vars.
c499e557 8556 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8557 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8558 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8559 Omit unused local var.
8560
ba0165e1
PE
8561 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8562 Don't assume string length fits in int.
32ad8845 8563 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8564 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8565
3c59b4c9
PE
8566 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8567 instead of alloca (Bug#8344).
8568
a3eed478 8569 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8570 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8571
eb4d412d
PE
8572 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8573
1658b401
PE
8574 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8575 concerns.
8576
8577 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8578
8579 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8580
9a2c6e05
PE
8581 * keyboard.c (syms_of_keyboard): Use the same style as later
8582 in this function when indexing through an array. This also
8583 works around GCC bug 48267.
8584
03d0a109
PE
8585 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8586
44f730c8
PE
8587 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8588
fe75f926
PE
8589 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8590 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8591
ffa8c828
PE
8592 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8593 This avoids undefined behavior on integer overflow, and is a bit
8594 more convenient anyway since it is compared to a size_t variable.
8595
c5101a77
PE
8596 Variadic C functions now count arguments with size_t, not int.
8597 This avoids an unnecessary limitation on 64-bit machines, which
8598 caused (substring ...) to crash on large vectors (Bug#8344).
8599 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8600 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8601 All variadic functions and their callers changed accordingly.
c5101a77
PE
8602 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8603 * data.c (arith_driver, float_arith_driver): Likewise.
8604 * editfns.c (general_insert_function): Likewise.
8605 * eval.c (struct backtrace.nargs, interactive_p)
8606 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8607 (funcall_lambda, mark_backtrace): Likewise.
8608 * fns.c (concat): Likewise.
8609 * frame.c (x_set_frame_parameters): Likewise.
8610 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8611 0 if not found, not -1. All callers changed.
8612
dd3f25f7
PE
8613 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8614 (stack_copy_size): Now size_t, not int.
8615 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8616
461c2ab9
JB
86172011-03-28 Juanma Barranquero <lekktu@gmail.com>
8618
8619 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8620 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8621 All callers changed.
8622
8623 * lisp.h (multibyte_char_to_unibyte):
8624 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8625 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8626 * character.h (CHAR_TO_BYTE8):
8627 * cmds.c (internal_self_insert):
8628 * editfns.c (general_insert_function):
8629 * keymap.c (push_key_description):
8630 * search.c (Freplace_match):
8631 * xdisp.c (message_dolog, set_message_1): All callers changed.
8632
f6d62986
SM
86332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8634
8635 * keyboard.c (safe_run_hook_funcall): New function.
8636 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8637 don't set the hook to nil, but remove the offending function instead.
8638 (Qcommand_hook_internal): Remove, unused.
8639 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8640 Vcommand_hook_internal.
8641
8642 * eval.c (enum run_hooks_condition): Remove.
8643 (funcall_nil, funcall_not): New functions.
8644 (run_hook_with_args): Call each function through a `funcall' argument.
8645 Remove `cond' argument, now redundant.
8646 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8647 (Frun_hook_with_args_until_failure): Adjust accordingly.
8648 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8649
1db5b1ad
JB
86502011-03-28 Juanma Barranquero <lekktu@gmail.com>
8651
8652 * dispextern.h (string_buffer_position): Remove declaration.
8653
8654 * print.c (strout): Remove parameter `multibyte', unused since
8655 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8656
8657 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8658 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8659 All callers changed.
8660
8661 * w32.c (_wsa_errlist): Use braces for struct initializers.
8662
8663 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8664 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8665 All callers changed.
8666 (string_buffer_position): Likewise. Also, make static (it's never
8667 used outside xdisp.c).
8668 (cursor_row_p): Remove parameter `w', unused since
8669 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8670 (decode_mode_spec): Remove parameter `precision', introduced during
8671 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8672 All callers changed.
8673
5ffb62aa
JD
86742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8675
8676 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8677
461c2ab9 86782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8679
8680 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8681 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8682 (ns_update_auto_hide_menu_bar): New functions.
8683 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8684 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8685 ns_constrain_all_frames.
8686 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8687 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8688
5c380ffb
JD
86892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8690
8691 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8692
9af30bdf
GM
86932011-03-27 Glenn Morris <rgm@gnu.org>
8694
8695 * syssignal.h: Replace RETSIGTYPE with void.
8696 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8697 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8698 Replace SIGTYPE with void everywhere.
8699 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8700 * s/template.h (SIGTYPE): Remove commented out definition.
8701
e2abce01
JB
87022011-03-26 Eli Zaretskii <eliz@gnu.org>
8703
8704 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8705 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8706
f868cd8a
JB
87072011-03-26 Juanma Barranquero <lekktu@gmail.com>
8708
59eb0929
JB
8709 * w32.c (read_unc_volume): Use parameter `henum', instead of
8710 global variable `wget_enum_handle'.
8711
8712 * keymap.c (describe_vector): Remove parameters `indices' and
8713 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8714 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8715
f868cd8a
JB
8716 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8717
8718 * keyboard.c (timer_check): Remove parameter `do_it_now',
8719 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8720 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8721 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8722
8723 * keyboard.c (read_char):
8724 * w32menu.c (w32_menu_display_help):
8725 * xmenu.c (show_help_event, menu_help_callback):
8726 Adjust calls to `show_help_echo'.
8727
8728 * gtkutil.c (xg_maybe_add_timer):
8729 * keyboard.c (readable_events):
8730 * process.c (wait_reading_process_output):
8731 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8732
8733 * insdel.c (adjust_markers_gap_motion):
8734 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8735 (gap_left, gap_right): Don't call it.
8736
2ecf6fdb
CY
87372011-03-25 Chong Yidong <cyd@stupidchicken.com>
8738
8739 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8740 incurred during fontification.
8741
6b1f9ba4
JB
87422011-03-25 Juanma Barranquero <lekktu@gmail.com>
8743
8744 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8745 (DEFVAR_PER_BUFFER): Don't pass it.
8746
8747 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8748 (scrolling_window): Don't pass it.
8749
0f4a96b5
JB
87502011-03-25 Juanma Barranquero <lekktu@gmail.com>
8751
8752 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8753
8754 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8755 and `suffix'.
8756 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8757 of variables specific to SELinux and computation of `encoded_absname'.
8758
8759 * image.c (XPutPixel): Remove unused variable `height'.
8760
8761 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8762
8763 * unexw32.c (get_section_info): Remove unused variable `section'.
8764
8765 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8766 (system_process_attributes): Remove unused variable `sess'.
8767 (sys_read): Remove unused variable `err'.
8768
8769 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8770 (w32_wnd_proc): Remove unused variable `isdead'.
8771 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8772 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8773 (x_create_tip_frame): Remove unused variable `tem'.
8774
8775 * w32inevt.c (w32_console_read_socket):
8776 Remove unused variable `no_events'.
8777
8778 * w32term.c (x_draw_composite_glyph_string_foreground):
8779 Remove unused variable `width'.
8780
1149507c
JB
87812011-03-24 Juanma Barranquero <lekktu@gmail.com>
8782
8783 * w32term.c (x_set_glyph_string_clipping):
8784 Don't pass uninitialized region to CombineRgn.
8785
9c88f339
JB
87862011-03-23 Juanma Barranquero <lekktu@gmail.com>
8787
8788 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8789 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8790 (Fx_close_connection): Remove unused variable `i'.
8791
8792 * w32font.c (w32font_draw): Return number of glyphs.
8793 (w32font_open_internal): Remove unused variable `i'.
8794 (w32font_driver): Add missing initializer.
8795
8796 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8797 (fill_in_menu): Remove unused variable `items_added'.
8798
8799 * w32term.c (last_mouse_press_frame): Remove static global variable.
8800 (w32_clip_to_row): Remove unused variable `f'.
8801 (x_delete_terminal): Remove unused variable `i'.
8802
8803 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8804 (NOTHING): Remove unused static global variable.
8805 (uniscribe_check_otf): Remove unused variable `table'.
8806 (uniscribe_font_driver): Add missing initializers.
8807
dee091a3
JD
88082011-03-23 Julien Danjou <julien@danjou.info>
8809
8810 * term.c (Fsuspend_tty, Fresume_tty):
8811 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8812 * window.c (temp_output_buffer_show):
8813 * insdel.c (signal_before_change):
8814 * frame.c (Fhandle_switch_frame):
8815 * fileio.c (Fdo_auto_save):
8816 * emacs.c (Fkill_emacs):
8817 * editfns.c (save_excursion_restore):
8818 * cmds.c (internal_self_insert):
8819 * callint.c (Fcall_interactively):
8820 * buffer.c (Fkill_all_local_variables):
8821 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8822 Use Frun_hooks.
0f4a96b5 8823 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8824 unconditionally since it does the check itself.
dee091a3 8825
2c520ab5 88262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8827
c9c49752
PE
8828 Fix more problems found by GCC 4.5.2's static checks.
8829
8abc3f12
PE
8830 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8831 the first time through the loop, since we know p0 < p1 then.
8832 This also avoids a gcc -Wstrict-overflow warning.
8833
a2d26660
PE
8834 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8835 leading to a memory leak, possible in functions like
8836 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8837 of objects (Bug#8318).
a2d26660 8838
916c72e9
PE
8839 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8840 that could (at least in theory) be that large.
8841
19ab8a18
PE
8842 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8843 This is less likely to overflow, and avoids undefined behavior if
8844 overflow does occur. All callers changed. Use strtoul to scan
8845 for the unsigned long integer.
b7cbbd6f
PE
8846 (pint2hrstr): Simplify and tune code slightly.
8847 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8848
f0641eff
PE
8849 * scroll.c (do_scrolling): Work around GCC bug 48228.
8850 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8851
7f650bb9
PE
8852 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8853 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8854 (validate_x_resource_name): Simplify count usage.
8855 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8856
37dd57d1
PE
8857 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8858 fail (Bug#8306).
81e56e61 8859
699979fc 8860 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8861
401bf9b4
PE
8862 * process.c (Fmake_network_process): Use socklen_t, not int,
8863 where POSIX says socklen_t is required in portable programs.
8864 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8865 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8866 (Fmake_network_process, server_accept_connection):
8867 (wait_reading_process_output, read_process_output):
8868 Likewise.
8869
b93aacde
PE
8870 * process.c: Rename or move locals to avoid shadowing.
8871 (list_processes_1, Fmake_network_process):
8872 (read_process_output_error_handler, exec_sentinel_error_handler):
8873 Rename or move locals.
4dc343ee 8874 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8875 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8876 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8877 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8878 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8879
af8a867c 8880 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8881 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8882 Include tparam.h instead, since it declares them.
af8a867c
PE
8883 * cm.h (PC): Remove extern decl; tparam.h now does this.
8884 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8885 * terminfo.c: Include tparam.h, to check interfaces.
8886 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8887 (tparam): Adjust signature to match interface in tparam.h;
8888 this removes some undefined behavior. Check that outstring and len
8889 are zero, which they always are with Emacs.
8890 * tparam.h (PC, BC, UP): New extern decls.
8891
0248044d 8892 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8893 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8894
8ff096c1 8895 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8896 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8897 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8898 (ftfont_list): Remove unused local.
49eaafba
PE
8899 (get_adstyle_property, ftfont_pattern_entity):
8900 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8901 Rename locals to avoid shadowing.
8ff096c1 8902
e2be39f6
PE
8903 * xfont.c (xfont_list_family): Mark var as initialized.
8904
c9735e30
PE
8905 * xml.c (make_dom): Now static.
8906
8f5201ae
PE
8907 * composite.c (composition_compute_stop_pos): Rename local to
8908 avoid shadowing.
b246f932
PE
8909 (composition_reseat_it): Remove unused locals.
8910 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8911 (composition_update_it): Mark var as initialized.
11b61122
PE
8912 (find_automatic_composition): Mark vars as initialized,
8913 with a FIXME (Bug#8290).
8f5201ae 8914
760fbc2c
PE
8915 character.h: Rename locals to avoid shadowing.
8916 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8917 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8918 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8919 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8920 to avoid shadowing.
8921
ff08eb85
PE
8922 * textprop.c (property_change_between_p): Remove; unused.
8923
fc7bf025
PE
8924 * intervals.c (interval_start_pos): Now static.
8925
235d7abc
PE
8926 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8927
44f230aa
SM
8928 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8929 Rename locals to avoid shadowing.
3e7d6594 8930
50060332
PE
8931 * sound.c (wav_play, au_play, Fplay_sound_internal):
8932 Fix pointer signedness.
d01f234b 8933 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8934 (wav_play): Initialize a variable to 0, to prevent undefined
8935 behavior (Bug#8278).
50060332 8936
c4fc4e30
PE
8937 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8938
918436ed
PE
8939 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8940
c939f91b
PE
8941 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8942 clobbering (Bug#8298).
b9c7f648
PE
8943 * sysdep.c (sys_subshell): Likewise.
8944 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8945
6bd8c144
PE
8946 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8947 This should get cleaned up, so that child_setup has the
8948 same signature on all platforms.
8949
7710357c 8950 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8951 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8952
c59da222
CY
89532011-03-22 Chong Yidong <cyd@stupidchicken.com>
8954
8955 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8956 not to be necessary, and produces flickering.
8957
66b87493
GM
89582011-03-20 Glenn Morris <rgm@gnu.org>
8959
8960 * config.in: Remove file.
8961
45b6f6d5
JB
89622011-03-20 Juanma Barranquero <lekktu@gmail.com>
8963
8964 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8965 are now in src/globals.h.
8966 (syms_of_minibuf): Remove spurious & from previous change.
8967
cd394be1 89682011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8969
8970 * minibuf.c (completing-read-function): New variable.
8971 (completing-read-default): Rename from completing-read.
8972 (completing-read): Call completing-read-function.
8973
b14e3e21
CY
89742011-03-19 Juanma Barranquero <lekktu@gmail.com>
8975
8976 * xfaces.c (Fx_load_color_file):
8977 Read color file from absolute filename (bug#8250).
8978
f2b726e6
JB
89792011-03-19 Juanma Barranquero <lekktu@gmail.com>
8980
8981 * makefile.w32-in: Update dependencies.
8982
09f6ff02
EZ
89832011-03-17 Eli Zaretskii <eliz@gnu.org>
8984
8985 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8986
29a6015a
PE
89872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8988
a3a6c54e
PE
8989 Fix more problems found by GCC 4.5.2's static checks.
8990
b766f867
PE
8991 * process.c (make_serial_process_unwind, send_process_trap):
8992 (sigchld_handler): Now static.
8993
be02381c
PE
8994 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8995 That way, the code declares only the vars that it needs.
8996 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8997 * s/cygwin.h (PTY_ITERATION): Likewise.
8998 * s/darwin.h (PTY_ITERATION): Likewise.
8999 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9000
57048744
PE
9001 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9002 * process.c (allocate_pty): Don't declare stb unless it's needed.
9003
7914961c 9004 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9005 (CONSTANTLIM): Remove; unused.
9006 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9007 Define only if needed.
7914961c 9008
b3967b18
PE
9009 * unexelf.c (unexec): Name an expression,
9010 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9011 Use a different way to cause a compilation error if anyone uses
9012 n rather than nn, a way that does not involve shadowing.
73366a00 9013 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9014
29a6015a
PE
9015 * deps.mk (unexalpha.o): Remove; unused.
9016
43cfc33e 9017 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9018 * unexec.h: New file.
ce701a33
PE
9019 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9020 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9021 Depend on unexec.h.
9022 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9023 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9024 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9025 Change as necessary to match prototype in unexec.h.
ce701a33 9026
01f44d5a
PE
9027 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9028 shadowing.
4f63c6bb 9029 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9030
a6670b0b
PE
9031 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9032 Rename locals to avoid shadowing.
9033
cef2010d 9034 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9035 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9036
d4d7173a
PE
9037 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9038
f08b802a
PE
9039 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9040 warning when compiling print.c.
9041
3ddb0639
PE
9042 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9043 instead of using an uninitialized var.
5ad03b97 9044 (font_sort_entities): Mark var as initialized.
3ddb0639 9045
170a2692
PE
9046 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9047
e663c700
PE
9048 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9049 pointers to constants.
89bc529a 9050 (font_parse_fcname): Remove unused vars.
7b81e2d0 9051 (font_delete_unmatched): Now static.
ea838e10 9052 (font_get_spec): Remove; unused.
13a547c6
PE
9053 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9054 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9055 Rename or move locals to avoid shadowing.
e663c700 9056
2a80c887 9057 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9058 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9059
1384fa33 9060 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9061 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9062
8b2c52e9
PE
9063 * alloc.c (mark_backtrace): Move decl from here ...
9064 * lisp.h: ... to here, so that it can be checked.
9065
475545b5 9066 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9067 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9068 (lisp_indirect_variable): Name an expression,
9069 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9070 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9071
b1349114 9072 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9073 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9074 Use const pointer when appropriate.
b1349114 9075
a2928364
PE
9076 * lisp.h (get_system_name, get_operating_system_release):
9077 Move decls here, to check interfaces.
9078 * process.c (get_operating_system_release): Move decl to lisp.h.
9079 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9080 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9081 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9082 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9083 (Fformat_time_string, Fencode_time, Finsert_char):
9084 (Ftranslate_region_internal, Fformat):
9085 Rename or remove local vars to avoid shadowing.
9710023e 9086 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9087
a415e694
PE
9088 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9089 avoid shadowing.
9090
8ef4622d
PE
9091 * lisp.h (eassert): Check that the argument compiles, even if
9092 ENABLE_CHECKING is not defined.
9093
946f9a5b
PE
9094 * data.c (Findirect_variable): Name an expression, to avoid
9095 gcc -Wbad-function-cast warning.
112396d6 9096 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9097 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9098 (Fmake_variable_buffer_local, Fmake_local_variable):
9099 Mark variables as initialized.
52746918 9100 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9101
e5aab7e7 9102 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9103 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9104 Rename locals to avoid shadowing.
dff45157
PE
9105 (mark_stack): Move local variables into the #ifdef region where
9106 they're used.
7bc26fdb
PE
9107 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9108 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9109 needed otherwise.
9110 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9111 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9112 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9113
e5aab7e7
PE
9114 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9115 avoids undefined behavior in theory.
9116
4da60324
PE
9117 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9118
88043301
PE
9119 Use functions, not macros, for up- and down-casing (Bug#8254).
9120 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9121 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9122 to use the following functions instead of these macros.
9123 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9124 EMACS_INT, since callers assume the returned value fits in int.
9125 (upcase1): Likewise, for UPCASE_TABLE.
9126 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9127 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9128 the race-condition problem in the old DOWNCASE.
88043301 9129
19ed5445
PE
9130 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9131 Rename locals to avoid shadowing.
9132 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9133 (regex_compile, re_search_2, re_match_2_internal):
9134 Remove unused local vars.
952db0d7
PE
9135 (FREE_VAR): Rewrite so as not to use empty "else",
9136 which gcc can warn about.
da053e48 9137 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9138 (RETALLOC_IF): Define only if needed.
9139 (WORDCHAR_P): Likewise. This one is never needed, but is used
9140 only in a comment talking about a compiler bug, so put inside
9141 the #if 0 of that comment.
9142 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9143 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9144 Remove; unused.
19ed5445 9145
1f3561e4 9146 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9147 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9148 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9149
ded6f8f7
PE
9150 * search.c (simple_search): Remove unused var.
9151
dbd37a95
PE
9152 * dired.c (compile_pattern): Move decl from here ...
9153 * lisp.h: ... to here, so that it can be checked.
9154 (struct re_registers): New forward decl.
9155
7e47afad
PE
9156 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9157
85f24f61
PE
9158 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9159 All uses changed.
9160 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9161 Rename locals to avoid shadowing.
5671df8f 9162 (Fvertical_motion): Mark locals as initialized.
85f24f61 9163
181aa2be 9164 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9165 (casify_region): Mark local as initialized.
181aa2be 9166
930d429c
PE
9167 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9168
7082eac6
PE
9169 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9170 New macros, so that the caller can use some names other than
9171 gcpro1, gcpro2, etc.
9172 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9173 of the new macros.
9174 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9175 argument, for consistency with GCPRO2_VAR, etc: it is now the
9176 prefix of the variable, not the variable itself. All uses
9177 changed.
38b2c076
PE
9178 * dired.c (directory_files_internal, file_name_completion):
9179 Rename locals to avoid shadowing.
9180
15206ed9
PE
9181 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9182 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9183 dired.c's scmp function, had undefined behavior.
9184 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9185 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9186 * buffer.h: ... to here, because these macros use current_buffer,
9187 and the new implementation with inline functions needs to have
9188 current_buffer in scope now, rather than later when the macros
9189 are used.
9190 (downcase, upcase1): New static inline functions.
9191 (DOWNCASE, UPCASE1): Reimplement using these functions.
9192 This avoids undefined behavior in expressions like
9193 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9194 from race conditions in accessing the global variables
9195 case_temp1 and case_temp2.
9196 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9197 * lisp.h (case_temp1, case_temp2): Remove their decls.
9198 * character.h (ASCII_CHAR_P): Move from here ...
9199 * lisp.h: ... to here, so that the inline functions mentioned
9200 above can use them.
9201
4a6bea26
PE
9202 * dired.c (directory_files_internal_unwind): Now static.
9203
f14b7e14
PE
9204 * fileio.c (file_name_as_directory, directory_file_name):
9205 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9206 Now static.
2893f146
PE
9207 (file_name_as_directory): Use const pointers when appropriate.
9208 (Fexpand_file_name): Likewise. In particular, newdir might
9209 point at constant storage, so make it a const pointer.
fd4ead52 9210 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9211 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9212 signedness issues.
f839df0c
PE
9213 (Fset_file_times, Finsert_file_contents, auto_save_error):
9214 Rename locals to avoid shadowing.
f14b7e14 9215
5716756e 9216 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9217 (Ftry_completion, Fall_completions): Rename or remove locals
9218 to avoid shadowing.
5716756e 9219
b4c3046a
PE
9220 * marker.c (bytepos_to_charpos): Remove; unused.
9221
b45db522
PE
9222 * lisp.h (verify_bytepos, count_markers): New decls,
9223 so that gcc does not warn that these functions aren't declared.
9224
85876d07
PE
9225 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9226 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9227 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9228 (copy_text): Remove unused local var.
85876d07 9229
03d78a21 9230 * filelock.c (within_one_second): Now static.
b3dd38ab 9231 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9232
5df8f01b
PE
9233 * buffer.c (fix_overlays_before): Mark locals as initialized.
9234 (fix_start_end_in_overlays): Likewise. This function should be
9235 simplified by using pointers-to-pointers, but that's a different
9236 matter.
b1d876f1 9237 (switch_to_buffer_1): Now static.
8f54f30a
PE
9238 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9239 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9240
a70072c9 9241 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9242 Fix pointer signedness issue.
edced198
PE
9243 (sys_subshell): Mark local as volatile if checking for lint,
9244 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9245 (MAXPATHLEN): Define only if needed.
a70072c9 9246
a0977c44
PE
9247 * process.c (serial_open, serial_configure): Move decls from here ...
9248 * systty.h: ... to here, so that they can be checked.
9249
a884fdcc
PE
9250 * fns.c (get_random, seed_random): Move extern decls from here ...
9251 * lisp.h: ... to here, so that they can be checked.
9252
604efe86 9253 * sysdep.c (reset_io): Now static.
b8950c94 9254 (wait_for_termination_signal): Remove; unused.
604efe86 9255
38fc62d9
PE
9256 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9257 (copy_keymap_item, append_key, push_text_char_description):
9258 Now static.
1004a21a 9259 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9260 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9261 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9262 (describe_map_tree):
9263 Rename locals to avoid shadowing.
38fc62d9 9264
2f2650da
PE
9265 * keyboard.c: Declare functions static if they are not used elsewhere.
9266 (echo_char, echo_dash, cmd_error, top_level_2):
9267 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9268 (read_char, kbd_buffer_get_event, make_lispy_position):
9269 (make_lispy_event, make_lispy_movement, apply_modifiers):
9270 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9271 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9272 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9273 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9274 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9275
a053e86c 9276 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9277 (mark_kboards): Move decl here ...
9278 * alloc.c (mark_kboards): ... from here.
a053e86c 9279
4752793e
PE
9280 * lisp.h (force_auto_save_soon): New decl.
9281
74f10ca7 9282 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9283 (DEFINE_DUMMY_FUNCTION): New macro.
9284 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9285 Use it.
c03cd23f
PE
9286 (main): Add casts to avoid warnings
9287 if GCC considers string literals to be constants.
74f10ca7 9288
022e70d4
PE
9289 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9290
59d6fe83
PE
9291 * dbusbind.c: Pointer signedness fixes.
9292 (xd_signature, xd_append_arg, xd_initialize):
9293 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9294 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9295 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9296 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9297
78320123
PE
9298 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9299 if GCC considers string literals to be constants.
49cebcca 9300 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9301
35ac2a97
SM
93022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9303
fb103ca9
SM
9304 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9305 (print_preprocess, print_object): New macro to fix last change.
9306
35ac2a97
SM
9307 * print.c (print_preprocess): Don't forget font objects.
9308
62973b41
JB
93092011-03-16 Juanma Barranquero <lekktu@gmail.com>
9310
9311 * emacs.c (USAGE3): Doc fixes.
9312
0e48bb22
AS
93132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9314
9315 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9316 structure.
9317
7684e57b
JB
93182011-03-14 Juanma Barranquero <lekktu@gmail.com>
9319
9320 * lisp.h (VWindow_system, Qfile_name_history):
9321 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9322 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9323 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9324
9325 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9326 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9327
9328 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9329 * w32console.c (detect_input_pending, read_input_pending)
9330 (encode_terminal_code):
9331 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9332 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9333 (w32_system_caret_y, Qfile_name_history):
9334 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9335 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9336 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9337 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9338 * w32proc.c (Qlocal, report_file_error):
9339 * w32term.c (Vwindow_system, updating_frame):
9340 * w32uniscribe.c (initialized, uniscribe_font_driver):
9341 Remove unneeded extern declarations.
9342
2aa46d6c
CY
93432011-03-14 Chong Yidong <cyd@stupidchicken.com>
9344
c96bbc66 9345 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9346
cffc6f3b
CY
93472011-03-13 Chong Yidong <cyd@stupidchicken.com>
9348
9349 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9350 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9351 These macros can no longer be used for assignment.
9352
44f230aa
SM
9353 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9354 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9355 (record_buffer_markers, fetch_buffer_markers): New functions for
9356 recording and fetching special buffer markers.
9357 (set_buffer_internal_1, set_buffer_temp): Use them.
9358
9359 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9360
9361 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9362
9363 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9364 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9365
9366 * xdisp.c (hscroll_window_tree):
9367 (reconsider_clip_changes): Use PT instead of BUF_PT.
9368
d251f04b
EZ
93692011-03-13 Eli Zaretskii <eliz@gnu.org>
9370
9371 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9372 $(EMACS_ROOT)/lib/intprops.h.
9373
f0c77cd1
PE
93742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9375
3eca4629
PE
9376 Fix more problems found by GCC 4.5.2's static checks.
9377
7c86ee98
PE
9378 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9379 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9380 (xg_free_frame_widgets): Make it clear that a local variable is
9381 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9382 (gdk_window_get_screen): Make it clear that this macro is needed
9383 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9384 (int_gtk_range_get_value): New function, which avoids a diagnostic
9385 from gcc -Wbad-function-cast.
9386 (xg_set_toolkit_scroll_bar_thumb): Use it.
9387 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9388 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9389 (get_utf8_string, xg_get_file_with_chooser):
9390 Rename locals to avoid shadowing.
9391 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9392
41729b81
PE
9393 * xgselect.c (xg_select): Remove unused var.
9394
f0c77cd1
PE
9395 * image.c (four_corners_best): Mark locals as initialized.
9396 (gif_load): Initialize transparent_p to zero (Bug#8238).
9397 Mark another local as initialized.
ec6cf4c6 9398 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9399
ce0ad53d 9400 * image.c (clear_image_cache): Now static.
d5d5a617 9401 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9402 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9403 (x_edge_detection): Remove unnecessary cast that
9404 gcc -Wbad-function-cast diagnoses.
2037898d 9405 (gif_load): Fix pointer signedness.
6ae141d6
PE
9406 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9407 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9408
33383987 94092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9410
d32df629
PE
9411 Improve quality of tests for time stamp overflow.
9412 For example, without this patch (encode-time 0 0 0 1 1
9413 1152921504606846976) returns the obviously-bogus value (-948597
9414 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9415 reports time overflow. See
9416 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9417 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9418 * editfns.c: Include limits.h and intprops.h.
9419 (TIME_T_MIN, TIME_T_MAX): New macros.
9420 (time_overflow): Move earlier, to before first use.
9421 (hi_time, lo_time): New functions, for an accurate test for
9422 out-of-range times.
9423 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9424 (Fget_internal_run_time): Don't assume time_t fits in int.
9425 (make_time): Use list2 instead of Fcons twice.
9426 (Fdecode_time): More accurate test for out-of-range times.
9427 (check_tm_member): New function.
9428 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9429 (lisp_time_argument): Don't rely on undefined left-shift and
9430 right-shift behavior when checking for time stamp overflow.
8be6f318 9431
fe31d94c
PE
9432 * editfns.c (time_overflow): New function, refactoring common code.
9433 (Fformat_time_string, Fdecode_time, Fencode_time):
9434 (Fcurrent_time_string): Use it.
9435
8be6f318
PE
9436 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9437 * dired.c (make_time): Move to ...
9438 * editfns.c (make_time): ... here.
9439 * systime.h: Note the move.
9440
09d9db2c 94412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9442
126bc0dc
YM
9443 * fringe.c (update_window_fringes): Remove unused variables.
9444
c47cbdfd
YM
9445 * unexmacosx.c (copy_data_segment): Also copy __got section.
9446 (Bug#8223)
9447
7ac80be9
EZ
94482011-03-12 Eli Zaretskii <eliz@gnu.org>
9449
c96bbc66 9450 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9451 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9452 Constify `char *' arguments and their references according to
9453 prototypes in tparam.h.
9454
ecb0f94d 9455 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9456
7ac80be9
EZ
9457 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9458 Adapt all references accordingly.
9459
9460 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9461
ef1fd07e
TT
94622011-03-11 Tom Tromey <tromey@redhat.com>
9463
9464 * buffer.c (syms_of_buffer): Remove obsolete comment.
9465
7ef4b50c
EZ
94662011-03-11 Eli Zaretskii <eliz@gnu.org>
9467
9468 * termhooks.h (encode_terminal_code): Declare prototype.
9469
9470 * msdos.c (encode_terminal_code): Don't declare prototype.
9471
9472 * term.c (encode_terminal_code): Now external again, used by
9473 w32console.c and msdos.c.
9474
44f230aa
SM
9475 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9476 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9477
4b1ec863 94782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9479
1714f52b 9480 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9481
4b1ec863
PE
9482 * fringe.c (update_window_fringes): Mark locals as initialized
9483 (Bug#8227).
9484 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9485
524c7aa6
PE
9486 * alloc.c (mark_fringe_data): Move decl from here ...
9487 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9488 to check its interface.
9489 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9490
a5c0af81 9491 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9492 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9493 (fontset_font): Mark local as initialized.
a9a06e0b 9494 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9495
b4716021
PE
9496 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9497
811e9bac 9498 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9499 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9500 (x_own_selection, Fx_disown_selection_internal): Rename locals
9501 to avoid shadowing.
9502 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9503
7e3ab302
PE
9504 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9505 so that the caller can use some name other than gcpro1.
9506 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9507 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9508 (Fx_backspace_delete_keys_p):
9509 Use them to avoid shadowing, and rename vars to avoid shadowing.
9510 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9511 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9512 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9513 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9514 Remove unused locals.
7e3ab302
PE
9515 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9516 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9517 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9518 macros.
f78faa98 9519
e2b13473
PE
9520 * xterm.h (x_mouse_leave): New decl.
9521
77f23912
PE
9522 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9523 Remove unused functions.
cdf4ba58
PE
9524 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9525 (x_calc_absolute_position): Now static.
7411c686 9526 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9527 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9528 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9529 unless they are used.
38d0b34a
PE
9530 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9531 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9532 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9533 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9534 (x_error_catcher, x_connection_closed, x_error_handler):
9535 (x_error_quitter, xembed_send_message, x_iconify_frame):
9536 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9537 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9538 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9539
44f230aa
SM
9540 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9541 Rename or move locals to avoid shadowing.
6b463e58 9542 (tty_defined_color, merge_face_heights): Now static.
5967d051 9543 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9544 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9545 does not deduce is never used uninitialized.
73719eba
PE
9546 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9547 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9548
426994c3 9549 * terminal.c (store_terminal_param): Now static.
5489860b 9550
032f1620 9551 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9552 (set_frame_menubar): Remove unused local.
d4323972 9553 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9554 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9555 since they might point to immutable storage.
281585b0
PE
9556 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9557 since it's unused otherwise.
032f1620 9558
367c19e5 9559 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9560 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9561 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9562 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9563 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9564 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9565 does not deduce are never used uninitialized.
70739cbe 9566
07b48fa9
PE
9567 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9568
8868a238 9569 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9570 * window.c (window_loop, size_window):
9571 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9572
7e5cf297 9573 * window.c (display_buffer): Now static.
d6550a9f
PE
9574 (size_window): Mark variables that gcc -Wuninitialized
9575 does not deduce are never used uninitialized.
a586633d
PE
9576 * window.h (check_all_windows): New decl, to forestall
9577 gcc -Wmissing-prototypes diagnostic.
5b555da1 9578 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9579
f6095868
PE
9580 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9581 shadowing.
9582 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9583 Include <limits.h>.
9584 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9585 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9586 (load_charset_map): Mark variables that gcc -Wuninitialized
9587 does not deduce are never used uninitialized.
53df7c11 9588 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9589
f38b440c
PE
9590 * coding.c (coding_set_source, coding_set_destination):
9591 Use "else { /* comment */ }" rather than "else /* comment */;"
9592 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9593 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9594 a block, when the outer 'i' will do.
9595 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9596 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9597 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9598 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9599 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9600 Rename locals to avoid shadowing.
9601 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9602 * coding.c (emacs_mule_char, encode_invocation_designation):
9603 Now static, since they're not used elsewhere.
413bb2db 9604 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9605 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9606 (decode_coding_emacs_mule): Mark variables that gcc
9607 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9608 (detect_coding_iso_2022): Initialize a local variable that might
9609 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9610 this initialization is needed. (Bug#8211)
5f58e762
PE
9611 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9612 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9613 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9614 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9615 Remove unused macros.
f38b440c 9616
232b38b9 9617 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9618 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9619 * character.c (string_count_byte8): Likewise.
232b38b9 9620
fb90da1b
PE
9621 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9622 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9623
fb93dbc2
PE
9624 * chartab.c (copy_sub_char_table): Now static, since it's not used
9625 elsewhere.
5c156ace
PE
9626 (sub_char_table_ref_and_range, char_table_ref_and_range):
9627 Rename locals to avoid shadowing.
bbcd0949 9628 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9629
7d3b3862 9630 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9631 (BIDI_BOB): Remove unused macro.
7d3b3862 9632
6be7d3da
PE
9633 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9634 deduce are never used uninitialized.
c2ed9c8b 9635 * term.c (encode_terminal_code): Likewise.
6be7d3da 9636
75f8807f 9637 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9638
50938595
PE
9639 * tparam.h: New file.
9640 * term.c, tparam.h: Include it.
9641 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9642 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9643 Move these decls to tparam.h, and make them agree with what
9644 is actually in tparam.c. The previous trick of using incompatible
9645 decls in different modules does not conform to the C standard.
9646 All callers of tparam changed to use tparam's actual API.
9647 * tparam.c (tparam1, tparam, tgoto):
9648 Use const pointers where appropriate.
9649
fbceeba2
PE
9650 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9651 * cm.h (struct cm): Likewise.
9652 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9653 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9654 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9655 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9656 (turn_on_face, init_tty): Likewise.
9657 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9658
7f3f1250
PE
9659 * term.c (term_mouse_position): Rename local to avoid shadowing.
9660
e6ca6543
PE
9661 * alloc.c (mark_ttys): Move decl from here ...
9662 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9663
c40f8d15
AS
96642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9665
9666 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9667
cfe0661d
JB
96682011-03-09 Juanma Barranquero <lekktu@gmail.com>
9669
9670 * search.c (compile_pattern_1): Remove argument regp, unused since
9671 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9672 (compile_pattern): Don't pass it.
9673
0afb4571
J
96742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9675
9676 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9677 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9678 for ! HAVE_GTK3.
9679 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9680
9681 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9682
9683 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9684 gdk_window_get_screen, gdk_window_get_geometry,
9685 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9686 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9687 (xg_get_pixbuf_from_pixmap): New function.
9688 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9689 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9690 Call xg_get_pixbuf_from_pixmap instead of
9691 gdk_pixbuf_get_from_drawable.
9692 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9693 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9694 (xg_check_special_colors): Use GtkStyleContext and its functions
9695 for HAVE_GTK3.
9696 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9697 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9698 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9699 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9700 Call gtk_widget_get_preferred_size.
0afb4571
J
9701 (xg_frame_resized): gdk_window_get_geometry only takes 5
9702 parameters.
44f230aa
SM
9703 (xg_win_to_widget, xg_event_is_for_menubar):
9704 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9705 (xg_set_widget_bg): New function.
9706 (delete_cb): New function.
895009e1 9707 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9708 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9709 (xg_set_background_color): Call xg_set_widget_bg.
9710 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9711 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9712 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9713 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9714 if ! HAVE_GTK3.
9715 (update_frame_tool_bar): Call gtk_widget_hide.
9716 (xg_initialize): Use GDK_KEY_g.
9717
9718 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9719 if ! HAVE_GTK3
9720 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9721
9722 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9723 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9724 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9725
1c2cc4ef
JB
97262011-03-08 Juanma Barranquero <lekktu@gmail.com>
9727
9728 * w32xfns.c (select_palette): Check success of RealizePalette against
9729 GDI_ERROR, not zero.
9730
33383987 9731See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9732
9733;; Local Variables:
9734;; coding: utf-8
aac0c6e3
MR
9735;; End:
9736
acaf905b 9737 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9738
9739 This file is part of GNU Emacs.
9740
9741 GNU Emacs is free software: you can redistribute it and/or modify
9742 it under the terms of the GNU General Public License as published by
9743 the Free Software Foundation, either version 3 of the License, or
9744 (at your option) any later version.
9745
9746 GNU Emacs is distributed in the hope that it will be useful,
9747 but WITHOUT ANY WARRANTY; without even the implied warranty of
9748 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9749 GNU General Public License for more details.
9750
9751 You should have received a copy of the GNU General Public License
9752 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.