* lisp/progmodes/f90.el (f90-looking-at-critical): Doc fix.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7a7ef429
PE
12011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2
3 Use gnulib's dup2 module instead of rolling our own.
4 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5
11fdef7d 62011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7
8 * dispnew.c (scrolling_window): Before scrolling, turn off a
9 mouse-highlight in the window being scrolled.
10
cd3520a4
JB
112011-06-24 Juanma Barranquero <lekktu@gmail.com>
12
13 Move DEFSYM to lisp.h and use everywhere.
14
15 * character.h (DEFSYM): Move declaration...
16 * lisp.h (DEFSYM): ...here.
17
18 * gnutls.c:
19 * minibuf.c:
20 * w32menu.c:
21 * w32proc.c:
22 * w32select.c: Don't include character.h.
23
24 * alloc.c (syms_of_alloc):
25 * buffer.c (syms_of_buffer):
26 * bytecode.c (syms_of_bytecode):
27 * callint.c (syms_of_callint):
28 * casefiddle.c (syms_of_casefiddle):
29 * casetab.c (init_casetab_once):
30 * category.c (init_category_once, syms_of_category):
31 * ccl.c (syms_of_ccl):
32 * cmds.c (syms_of_cmds):
33 * composite.c (syms_of_composite):
34 * dbusbind.c (syms_of_dbusbind):
35 * dired.c (syms_of_dired):
36 * dispnew.c (syms_of_display):
37 * doc.c (syms_of_doc):
38 * editfns.c (syms_of_editfns):
39 * emacs.c (syms_of_emacs):
40 * eval.c (syms_of_eval):
41 * fileio.c (syms_of_fileio):
42 * fns.c (syms_of_fns):
43 * frame.c (syms_of_frame):
44 * fringe.c (syms_of_fringe):
45 * insdel.c (syms_of_insdel):
46 * keymap.c (syms_of_keymap):
47 * lread.c (init_obarray, syms_of_lread):
48 * macros.c (syms_of_macros):
49 * msdos.c (syms_of_msdos):
50 * print.c (syms_of_print):
51 * process.c (syms_of_process):
52 * search.c (syms_of_search):
53 * sound.c (syms_of_sound):
54 * syntax.c (init_syntax_once, syms_of_syntax):
55 * terminal.c (syms_of_terminal):
56 * textprop.c (syms_of_textprop):
57 * undo.c (syms_of_undo):
58 * w32.c (globals_of_w32):
59 * window.c (syms_of_window):
60 * xdisp.c (syms_of_xdisp):
61 * xfaces.c (syms_of_xfaces):
62 * xfns.c (syms_of_xfns):
63 * xmenu.c (syms_of_xmenu):
64 * xsettings.c (syms_of_xsettings):
65 * xterm.c (syms_of_xterm): Use DEFSYM.
66
4228cf16
TZ
672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
68
cd3520a4 69 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 70
7fcccf1e
PE
712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
72
7efb4e0e
PE
73 Integer and buffer overflow fixes (Bug#8873).
74
ff5844ad
PE
75 * print.c (printchar, strout): Check for string overflow.
76 (PRINTPREPARE, printchar, strout):
77 Don't set size unless allocation succeeds.
78
90532f02
PE
79 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
80 for sizes. Check for string overflow more accurately.
81 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
82
6d84508d
PE
83 * macros.c: Integer and buffer overflow fixes.
84 * keyboard.h (struct keyboard.kbd_macro_bufsize):
85 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
86 Use ptrdiff_t, not int, for sizes.
87 Don't increment bufsize until after realloc succeeds.
88 Check for size-calculation overflow.
89 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
90
437b2cb4
PE
91 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
92
8b9ac8b4
PE
93 * lread.c: Integer overflow fixes.
94 (read_integer): Radix is now EMACS_INT, not int,
95 to improve quality of diagnostics for out-of-range radices.
96 Calculate buffer size correctly for out-of-range radices.
97 (read1): Check for integer overflow in radices, and in
98 read-circle numbers.
82cb60d3
PE
99 (read_escape): Avoid int overflow.
100 (Fload, openp, read_buffer_size, read1)
101 (substitute_object_recurse, read_vector, read_list, map_obarray):
102 Use ptrdiff_t, not int, for sizes.
103 (read1): Use EMACS_INT, not int, for sizes.
20270765 104 Check for size overflow.
8b9ac8b4 105
7fcccf1e
PE
106 * image.c (cache_image): Check for size arithmetic overflow.
107
bfbbd7e7
PE
108 * lread.c: Integer overflow issues.
109 (saved_doc_string_size, saved_doc_string_length)
110 (prev_saved_doc_string_size, prev_saved_doc_string_length):
111 Now ptrdiff_t, not int.
112 (read1): Don't assume doc string length fits in int. Check for
113 out-of-range doc string lengths.
114 (read_list): Don't assume file position fits in int.
39019e54 115 (read_escape): Check for hex character overflow.
bfbbd7e7 116
4e323265
LL
1172011-06-22 Leo Liu <sdl.web@gmail.com>
118
119 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
120 Move to minibuffer.el.
121
85fece3e
PE
1222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
123
20b84ce9 124 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
125 The following patches are for when GLYPH_DEBUG && !XASSERT.
126 * dispextern.h (trace_redisplay_p, dump_glyph_string):
127 * dispnew.c (flush_stdout):
128 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
129 Mark as externally visible.
130 * dispnew.c (check_window_matrix_pointers): Now static.
131 * dispnew.c (window_to_frame_vpos):
132 * xfns.c (unwind_create_frame):
133 * xterm.c (x_check_font): Remove unused local.
134 * scroll.c (CHECK_BOUNDS):
135 * xfaces.c (cache_fache): Rename local to avoid shadowing.
136 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
137 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
138 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
139 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
140 Now static.
141 (debug_method_add): Use va_list and vsprintf rather than relying
142 on undefined behavior with wrong number of arguments.
143 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
144 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
145 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
146 since we're not interested in debugging glyphs with old libraries.
147 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
148 GCC 4.6.0's static checking.
149
0766b489
PE
1502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
151
31fd4b32
PE
152 Integer overflow and signedness fixes (Bug#8873).
153 A few related buffer overrun fixes, too.
154
b79e8648
PE
155 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
156
0766b489
PE
157 * dispextern.h (struct face.stipple):
158 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
159 (x_bitmap_mask, x_allocate_bitmap_record)
160 (x_create_bitmap_from_data, x_create_bitmap_from_file)
161 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
162 (x_create_bitmap_from_xpm_data):
163 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
164 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
165 (.bitmaps_last):
166 * xfaces.c (load_pixmap):
167 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
168 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
169 (.bitmaps_last, struct x_output.icon_bitmap):
170 Use ptrdiff_t, not int, for bitmap indexes.
171 (x_allocate_bitmap_record): Check for size overflow.
172 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
173
b081724f
PE
174 Use ptrdiff_t, not int, for overlay counts.
175 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
176 * editfns.c (overlays_around, get_pos_property):
177 * textprop.c (get_char_property_and_overlay):
178 * xdisp.c (next_overlay_change, note_mouse_highlight):
179 * xfaces.c (face_at_buffer_position):
21514da7
PE
180 * buffer.c (OVERLAY_COUNT_MAX): New macro.
181 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
182 (Fnext_overlay_change, Fprevious_overlay_change)
183 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 184 Use ptrdiff_t, not int, for sizes.
21514da7 185 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 186
3de73e5e
PE
187 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
188
2606c57b
PE
189 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
190 (x_session_initialize): Do not assume string length fits in int.
191
aaafe47a
PE
192 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
193 This is unlikely, but can occur if DPI is outlandish.
194
2674ddc8 195 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
196 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
197
28154962
PE
198 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
199 * xrdb.c (magic_file_p, search_magic_path):
200 Omit last arg SUFFIX; it was always 0. All callers changed.
201 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
202
7de51af5
PE
203 * xfont.c (xfont_match): Avoid need for strlen.
204
25ed6cc3
PE
205 * xfns.c: Don't assume strlen fits in int.
206 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
207
4eab31dd
PE
208 * xdisp.c (message_log_check_duplicate): Return intmax_t,
209 not unsigned long, as we prefer signed integers. All callers changed.
210 Detect integer overflow in repeat count.
211 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 212 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 213
171e2a58
PE
214 * termcap.c: Don't assume sizes fit in int and never overflow.
215 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
216 (gobble_line): Check for size-calculation overflow.
217
ad39faca 218 * minibuf.c (Fread_buffer):
6e5bb2dc 219 * lread.c (intern, intern_c_string):
74ca2eb3
PE
220 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
221 Don't assume string length fits in int.
222
52c61c22 223 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
224 * gtkutil.c (style_changed_cb): Avoid need for strlen.
225
b5b8c9e5
PE
226 * font.c: Don't assume string length fits in int.
227 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
228 Use ptrdiff_t, not int.
ccd6111c
PE
229 (font_intern_prop): Don't assume string length fits in int.
230 Don't assume integer property fits in fixnum.
231 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 232
882f0d81 233 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 234 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
235 Reformulate so as not to need the command string.
236 Invoke gzip -cd rather than gunzip, as it's more portable.
237 (lock_info_type, lock_file_1, lock_file):
238 Don't assume pid_t and time_t fit in unsigned long.
239 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
240 (current_lock_owner): Prefer signed type for sizes.
241 Use memcpy, not strncpy, where memcpy is what is really wanted.
242 Don't assume (via atoi) that time_t and pid_t fit in int.
243 Check for time_t and/or pid_t out of range, e.g., via a network share.
244 Don't alloca where an auto var works fine.
245
93f4cf88
PE
246 * fileio.c: Fix some integer overflow issues.
247 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
248 Don't assume string length fits in int.
249 (directory_file_name): Don't assume string length fits in long.
250 (make_temp_name): Don't assume pid fits in int, or that its print
251 length is less than 20.
252
f3e92b69
PE
253 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
254
1bfdaf10
PE
255 * coding.c (make_subsidiaries): Don't assume string length fits in int.
256
35016e9a
PE
257 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
258
3d1e65a1
PE
259 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
260 We prefer signed integers, even for size calculations.
261
0b963a93
PE
262 * emacs.c: Don't assume string length fits in 'int'.
263 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
264 (main): Don't invoke strlen when not needed.
265
573f4b54
PE
266 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
267 (XD_DEBUG_MESSAGE): Don't waste a byte.
268
989f33ba
PE
269 * callproc.c (getenv_internal_1, getenv_internal)
270 (Fgetenv_internal):
965d34eb
PE
271 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
272
e4d29b33
PE
273 * lread.c (invalid_syntax): Omit length argument.
274 All uses changed. This doesn't fix a bug, but it simplifies the
275 code away from its former Hollerith-constant appearance, and it's
276 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 277 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 278
eb49b136
PE
279 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
280 This didn't break anything, but it didn't help either.
281 It's confusing to put a bogus integer in a place where the actual
282 value does not matter.
9f62aeb1 283 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 284 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 285
15375a22
PE
286 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
287 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
288 implementation.
b61cc01c
PE
289 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
290 We prefer signed types, and the value cannot exceed the EMACS_INT
291 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
292 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
293 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
294 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 295
53b2623d
PE
296 * indent.c (sane_tab_width): New function.
297 (current_column, scan_for_column, Findent_to, position_indentation)
298 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 299 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 300
51cab52b 301 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 302
f2ed8a70
PE
303 * lisp.h (lint_assume): New macro.
304 * composite.c (composition_gstring_put_cache):
305 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
306
abe80cc6
PE
307 * editfns.c, insdel.c:
308 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 309
b02c740e
PE
310 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
311
ebc96716
PE
312 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
313
b4e50fa0 314 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 315 Use much-faster test for byte-length change.
311d5d7c 316 Don't assume string byte-length fits in 'int'.
a4cf38e4 317 Check that character arg fits in 'int'.
85461888 318 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 319
c0c1ee9f
PE
320 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
321
a498d7f4
PE
322 * fns.c (concat): Catch string overflow earlier.
323 Do not rely on integer wraparound.
324
51cab52b
PE
325 * dispextern.h (struct it.overlay_strings_charpos)
326 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
327 * xdisp.c (forward_to_next_line_start)
328 (back_to_previous_visible_line_start)
329 (reseat_at_next_visible_line_start, next_element_from_buffer):
330 Don't arbitrarily truncate the value of 'selective' to int.
331
76031fad
PE
332 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
333
5eb55db9
PE
334 * composite.c: Don't truncate sizes to 'int'.
335 (composition_gstring_p, composition_reseat_it)
336 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
337 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
338 not EMACS_UINT, for indexes.
5eb55db9 339
0703a717
PE
340 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
341
d6202519
PE
342 * buffer.c: Include <verify.h>.
343 (struct sortvec.priority, struct sortstr.priority):
8961a454 344 Now EMACS_INT, not int.
c20998a7 345 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
346 (struct sortstr.size, record_overlay_string)
347 (struct sortstrlist.size, struct sortlist.used):
348 Don't truncate size to int.
349 (record_overlay_string): Check for size-calculation overflow.
d6202519 350 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 351
d5a19415
JM
3522011-06-22 Jim Meyering <meyering@redhat.com>
353
354 don't leak an XBM-image-sized buffer
355 * image.c (xbm_load): Free the image buffer after using it.
356
a9041e6c
PE
3572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
358
359 Port to Sun C.
360 * composite.c (find_automatic_composition): Omit needless 'return 0;'
361 that Sun C diagnosed.
362 * fns.c (secure_hash): Fix pointer signedness issue.
363 * intervals.c (static_offset_intervals): New function.
364 (offset_intervals): Use it.
365
7f3f739f
LL
3662011-06-21 Leo Liu <sdl.web@gmail.com>
367
368 * deps.mk (fns.o):
369 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
370 sha512.h.
371
372 * fns.c (secure_hash): Rename from crypto_hash_function and change
373 the first arg to accept symbols.
5b66d427 374 (Fsecure_hash): New primitive.
7f3f739f
LL
375 (syms_of_fns): New symbols.
376
76147d94
DD
3772011-06-20 Deniz Dogan <deniz@dogan.se>
378
379 * process.c (Fset_process_buffer): Clarify return value in
380 docstring.
381
7d7d0045
CY
3822011-06-18 Chong Yidong <cyd@stupidchicken.com>
383
384 * dispnew.c (add_window_display_history): Use BVAR.
385
386 * xdisp.c (debug_method_add): Use BVAR.
387 (check_window_end, dump_glyph_matrix, dump_glyph)
388 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
389
390 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
391 Likewise.
392
393 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
394 check till after the cache is created in init_frame_faces.
395
ff2bc410
SM
3962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
397
398 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
399
28177add
PE
4002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
401
dd3482fe
PE
402 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
403 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
404 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
405
393d71f3 406 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
407 * fileio.c (Finsert_file_contents):
408 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
409 Remove the old (too-loose) buffer overflow checks.
410 They weren't needed, since make_gap checks for buffer overflow.
411 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
412 The old code merely checked for Emacs fixnum overflow, and relied
413 on undefined (wraparound) behavior. The new code avoids undefined
414 behavior, and also checks for ptrdiff_t and/or size_t overflow.
415
2e6813b0 416 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
417 Tune. Don't use wider integers than needed. Don't use alloca.
418 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 419
599a9e4f
PE
420 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
421
99561444
PE
422 * insdel.c, lisp.h (buffer_overflow): New function.
423 (insert_from_buffer_1, replace_range, replace_range_2):
424 * insdel.c (make_gap_larger):
425 * editfns.c (Finsert_char):
426 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
427
28177add
PE
428 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
429
e69dafad
PE
4302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
431
a7af7fde 432 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 433
b1c46f02
PE
434 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
435 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
436
e69dafad
PE
437 * fileio.c: Don't assume EMACS_INT fits in off_t.
438 (emacs_lseek): New static function.
439 (Finsert_file_contents, Fwrite_region): Use it.
440 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
441
566684ea
PE
442 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
443
e6966cd6
PE
444 * fns.c: Don't overflow int when computing a list length.
445 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
446 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
447 truncation on 64-bit hosts. Check for QUIT every
448 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
449 faster and is responsive enough.
450 (Flength): Report an error instead of overflowing an integer.
451 (Fsafe_length): Return a float if the value is not representable
452 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 453 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 454 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 455
dd0b0efb
PE
456 * alloc.c: Check that resized vectors' lengths fit in fixnums.
457 (header_size, word_size): New constants.
458 (allocate_vectorlike): Don't check size overflow here.
459 (allocate_vector): Check it here instead, since this is the only
460 caller of allocate_vectorlike that could cause overflow.
461 Check that the new vector's length is representable as a fixnum.
462
86fe5cfe
PE
463 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
464 The previous code was bogus. For example, next_almost_prime (32)
465 returned 39, which is undesirable as it is a multiple of 3; and
466 next_almost_prime (24) returned 25, which is a multiple of 5 so
467 why was the code bothering to check for multiples of 7?
468
80e88859
PE
469 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
470
4a2f0ad6
PE
471 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
472
f66c7cf8
PE
473 Variadic C functions now count arguments with ptrdiff_t.
474 This partly undoes my 2011-03-30 change, which replaced int with size_t.
475 Back then I didn't know that the Emacs coding style prefers signed int.
476 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
477 were being counted with int, which may truncate counts on 64-bit
478 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
479 * lisp.h (struct Lisp_Subr.function.aMANY)
480 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
481 Arg counts are now ptrdiff_t, not size_t.
482 All variadic functions and their callers changed accordingly.
483 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
484 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
485 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
486 * callint.c (Fcall_interactively): Check arg count for overflow,
487 to avoid potential buffer overrun. Use signed char, not 'int',
488 for 'varies' array, so that we needn't bother to check its size
489 calculation for overflow.
490 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
491 * eval.c (apply_lambda):
492 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
493 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
494 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
495
a1759b76
PE
496 * callint.c (Fcall_interactively): Don't use index var as event count.
497
d96be9fc
PE
498 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
499 * mem-limits.h (SIZE): Remove; no longer used.
500
a690a978 501 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 502
578c21e6
PE
503 Remove unnecessary casts.
504 * xterm.c (x_term_init):
505 * xfns.c (x_set_border_pixel):
506 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
507 These aren't needed now that we assume ANSI C.
508
96f53c6c
PE
509 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
510 It's more likely to cause problems (due to unsigned overflow)
511 than to cure them.
512
83c77d31
PE
513 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
514
ee2079f1
PE
515 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
516
6da65536
PE
517 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
518
7147c4a4
PE
519 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
520
193e32d9
PE
521 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
522
e5533da6
PE
523 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
524
9910e595
PE
525 GLYPH_CODE_FACE returns EMACS_INT, not int.
526 * dispextern.h (merge_faces):
527 * xfaces.c (merge_faces):
01103c44
PE
528 * xdisp.c (get_next_display_element, next_element_from_display_vector):
529 Don't assume EMACS_INT fits in int.
9910e595 530
2638320e
PE
531 * character.h (CHAR_VALID_P): Remove unused parameter.
532 * fontset.c, lisp.h, xdisp.c: All uses changed.
533
045eb8d9
PE
534 * editfns.c (Ftranslate_region_internal): Omit redundant test.
535
c1f134b5
PE
536 * fns.c (concat): Minor tuning based on overflow analysis.
537 This doesn't fix any bugs. Use int to hold character, instead
538 of constantly refetching from Emacs object. Use XFASTINT, not
539 XINT, for value known to be a character. Don't bother comparing
540 a single byte to 0400, as it's always less.
541
395fcb93 542 * floatfns.c (Fexpt):
327eeec8
PE
543 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
544
abbd3d23
PE
545 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
546 for characters.
547
684a03ef
PE
548 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
549
0fed43f3
PE
550 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
551 Without this fix, on a 64-bit host (aset S 0 4294967386) would
552 incorrectly succeed when S was a string, because 4294967386 was
553 truncated before it was used.
554
8fd02eb7
PE
555 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
556 Otherwise, an out-of-range integer could cause undefined behavior
557 on a 64-bit host.
558
f8c86b69
PE
559 * composite.c: Use int, not EMACS_INT, for characters.
560 (fill_gstring_body, composition_compute_stop_pos): Use int, not
561 EMACS_INT, for values that are known to be in character range.
562 This doesn't fix any bugs but is the usual style inside Emacs and
563 may generate better code on 32-bit machines.
564
34206dd2
PE
565 Make sure a 64-bit char is never passed to ENCODE_CHAR.
566 This is for reasons similar to the recent CHAR_STRING fix.
567 * charset.c (Fencode_char): Check that character arg is actually
568 a character. Pass an int to ENCODE_CHAR.
569 * charset.h (ENCODE_CHAR): Verify that the character argument is no
570 wider than 'int', as a compile-time check to prevent future regressions
571 in this area.
572
c5958d4c 573 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
574
575 Make sure a 64-bit char is never passed to CHAR_STRING.
576 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
577 by silently ignoring the top 32 bits, allowing some values
578 that were far too large to be valid characters.
579 * character.h: Include <verify.h>.
580 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
581 arguments are no wider than unsigned, as a compile-time check
582 to prevent future regressions in this area.
583 * data.c (Faset):
01103c44 584 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
585 (Fsubst_char_in_region):
586 * fns.c (concat):
587 * xdisp.c (decode_mode_spec_coding):
588 Adjust to CHAR_STRING's new requirement.
589 * editfns.c (Finsert_char, Fsubst_char_in_region):
590 * fns.c (concat): Check that character args are actually
591 characters. Without this test, these functions did the wrong
592 thing with wildly out-of-range values on 64-bit hosts.
593
d37ca623
PE
594 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
595 These casts should not be needed on 32-bit hosts, either.
596 * keyboard.c (read_char):
597 * lread.c (Fload): Remove casts to unsigned.
598
ea204efb
PE
599 * lisp.h (UNSIGNED_CMP): New macro.
600 This fixes comparison bugs on 64-bit hosts.
601 (ASCII_CHAR_P): Use it.
602 * casefiddle.c (casify_object):
01103c44 603 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
604 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
605 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
606 * dispextern.h (FACE_FROM_ID):
607 * keyboard.c (read_char): Use UNSIGNED_CMP.
608
41cb286c
PE
609 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
610 not to EMACS_INT, to avoid GCC warning.
611
4a1b9832
PE
612 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
613
55daad71
PE
614 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
615 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
616 isn't needed on 32-bit machines.
8f95c75c 617
01103c44
PE
618 * buffer.c (Fgenerate_new_buffer_name):
619 Use EMACS_INT for count, not int.
0ceccced 620 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
621
622 * data.c (Qcompiled_function): Now static.
623
c6f072e7
PE
624 * window.c (window_body_lines): Now static.
625
20ce5912
PE
626 * image.c (gif_load): Rename local to avoid shadowing.
627
9c4c5f81
PE
628 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
629 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
630 * alloc.c (make_save_value): Integer argument is now of type
631 ptrdiff_t, not int.
632 (mark_object): Use ptrdiff_t, not int.
633 * lisp.h (pD): New macro.
634 * print.c (print_object): Use it.
635
c0c5c8ae
PE
636 * alloc.c: Use EMACS_INT, not int, to count objects.
637 (total_conses, total_markers, total_symbols, total_vector_size)
638 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
639 (total_free_floats, total_floats, total_free_intervals)
640 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
641 Now EMACS_INT, not int. All uses changed.
642 (Fgarbage_collect): Compute overall total using a double, so that
643 integer overflow is less likely to be a problem. Check for overflow
644 when converting back to an integer.
5a25e253
PE
645 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
646 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
647 These were 'int' variables that could overflow on 64-bit hosts;
648 they were never used, so remove them instead of repairing them.
211a0b2a 649 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
650 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
651 Previously, this ceilinged at INT_MAX, but that doesn't work on
652 64-bit machines.
e46bb31a 653 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 654
c78baabf 655 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 656 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
657 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
658 when a (possibly-narrower) signed value would do just as well.
659 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 660
c9d624c6
PE
661 * alloc.c: Catch some string size overflows that we were missing.
662 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
663 for convenience in STRING_BYTES_MAX.
664 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
665 The definition here is exact; the one in lisp.h was approximate.
666 (allocate_string_data): Check for string overflow. This catches
667 some instances we weren't catching before. Also, it catches
668 size_t overflow on (unusual) hosts where SIZE_MAX <= min
669 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
670 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 671
c9d624c6
PE
672 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
673 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
674 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
675
353032ce
PE
676 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
677
2bccce07
PE
678 * alloc.c (Fmake_string): Check for out-of-range init.
679
0ac30604
SM
6802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
681
682 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
683
c195f2de
JD
6842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
685
686 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
687 xg_get_default_scrollbar_width.
688
689 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
690 (int_gtk_range_get_value): Move to the scroll bar part of the file.
691 (style_changed_cb): Call update_theme_scrollbar_width and call
692 x_set_scroll_bar_default_width and xg_frame_set_char_size for
693 all frames (Bug#8505).
694 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
695 Call gtk_window_set_resizable if HAVE_GTK3.
696 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
697 and height if HAVE_GTK3 (Bug#8505).
698 (scroll_bar_width_for_theme): New variable.
699 (update_theme_scrollbar_width): New function.
700 (xg_get_default_scrollbar_width): Move code to
701 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
702 (xg_initialize): Call update_theme_scrollbar_width.
703
704 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
705
706 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
707
e10ac9f1
MR
7082011-06-12 Martin Rudalics <rudalics@gmx.at>
709
710 * frame.c (make_frame): Call other_buffer_safely instead of
711 other_buffer.
712
713 * window.c (temp_output_buffer_show): Call display_buffer with
714 second argument Vtemp_buffer_show_specifiers and reset latter
715 immediately after the call.
716 (Vtemp_buffer_show_specifiers): New variable.
717 (auto_window_vscroll_p, next_screen_context_lines)
718 (Vscroll_preserve_screen_position): Remove leading asterisks from
719 doc-strings.
720
2d3c217e 7212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 722
7b7f97e8 723 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
724 * buffer.c (Qclone_number): Remove for now, as it's unused.
725 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
726 (record_buffer): Remove unused local.
727 * frame.c (other_visible_frames, frame_buffer_list): Now static.
728 (set_frame_buffer_list): Remove; unused.
729 * frame.h (other_visible_frames): Remove decl.
730 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
731 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
732 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
733 if HAVE_GPM.
734 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
735 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
736 Define only if HAVE_GPM.
737 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
738 (update_hints_inhibit): Remove; never set. All uses removed.
739 * widgetprv.h (emacsFrameClassRec): Remove decl.
740 * window.c (delete_deletable_window): Now returns void, since it
741 wasn't returning anything.
742 (compare_window_configurations): Remove unused locals.
743 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
744 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
745 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
746 the same widths as pointers. This follows up on the 2011-05-06 patch.
747 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
748 * xterm.h: Likewise.
749 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
750
1384b89e
JB
7512011-06-12 Juanma Barranquero <lekktu@gmail.com>
752
753 * makefile.w32-in: Update dependencies.
754 (LISP_H): Add lib/intprops.h.
755
1100a63c
CY
7562011-06-11 Chong Yidong <cyd@stupidchicken.com>
757
758 * image.c (gif_load): Add animation frame delay to the metadata.
759 (syms_of_image): Use DEFSYM. New symbol `delay'.
760
6198ccd0
MR
7612011-06-11 Martin Rudalics <rudalics@gmx.at>
762
763 * window.c (delete_deletable_window): Re-add.
764 (Fset_window_configuration): Rewrite to handle dead buffers and
765 consequently deletable windows.
766 (window_tree, Fwindow_tree): Remove. Supply functionality in
767 window.el.
768 (compare_window_configurations): Simplify code.
769
b6e3633c
AS
7702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
771
1ab0dee5
AS
772 * image.c (imagemagick_load_image): Fix type mismatch.
773 (Fimagemagick_types): Likewise.
774
b6e3633c
AS
775 * window.h (replace_buffer_in_windows): Declare.
776
9397e56f
MR
7772011-06-11 Martin Rudalics <rudalics@gmx.at>
778
779 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
780 Qclone_number. Remove external declaration of Qdelete_window.
781 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
782 code.
783 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
784 Qbuffer_list_update_hook if allowed.
785 (Fother_buffer): Rewrite doc-string. Major rewrite for new
786 buffer list implementation.
787 (other_buffer_safely): New function.
788 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
789 calls to replace_buffer_in_windows and
790 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
791 if allowed.
792 (record_buffer): Inhibit quitting and rewrite using quittable
793 functions. Run Qbuffer_list_update_hook if allowed.
794 (Frecord_buffer, Funrecord_buffer): New functions.
795 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
796 switch-to-buffer to window.el.
797 (bury-buffer): Move to window.el.
798 (Vbuffer_list_update_hook): New variable.
799
800 * lisp.h (other_buffer_safely): Add prototype in buffer.c
801 section.
802
803 * window.h (resize_frame_windows): Move up in code.
804 (Fwindow_frame): Remove EXFUN.
805 (replace_buffer_in_all_windows): Remove prototype.
806 (replace_buffer_in_windows_safely): Add prototype.
807
808 * window.c: Declare Qdelete_window static again. Move down
809 declaration of select_count.
810 (Fnext_window, Fprevious_window): Rewrite doc-strings.
811 (Fother_window): Move to window.el.
812 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
813 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
814 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
815 window.el.
816 (replace_buffer_in_windows): Implement by calling
817 Qreplace_buffer_in_windows.
818 (replace_buffer_in_all_windows): Remove with some functionality
819 moved into replace_buffer_in_windows_safely.
820 (replace_buffer_in_windows_safely): New function.
821 (select_window_norecord, select_frame_norecord): Move in front
822 of run_window_configuration_change_hook. Remove now obsolete
823 declarations.
824 (Fset_window_buffer): Rewrite doc-string. Call
825 Qrecord_window_buffer.
826 (keys_of_window): Move binding for other-window to window.el.
827
b50691aa
CY
8282011-06-11 Chong Yidong <cyd@stupidchicken.com>
829
830 * dispextern.h (struct image): Replace data member, whose int_val
831 and ptr_val fields were not used by anything, with a single
832 lisp_val object.
833
834 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
835 (gif_clear_image, gif_load, imagemagick_load_image)
836 (gs_clear_image, gs_load): Callers changed.
837
3f754b86
PE
8382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
839
cca69397
PE
840 * buffer.h: Include <time.h>, for time_t.
841 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
842
109e28d0
PE
843 Fix minor problems found by static checking.
844
60737f02
PE
845 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
846
4b66faf3
PE
847 Make identifiers static if they are not used in other modules.
848 * data.c (Qcompiled_function, Qframe, Qvector):
849 * image.c (QimageMagick, Qsvg):
850 * minibuf.c (Qmetadata):
851 * window.c (resize_window_check, resize_root_window): Now static.
852 * window.h (resize_window_check, resize_root_window): Remove decls.
853
109e28d0
PE
854 * window.c (window_deletion_count, delete_deletable_window):
855 Remove; unused.
46a4ce9e
PE
856 (window_body_lines): Now static.
857 (Fdelete_other_windows_internal): Mark vars as initialized.
858 Make sure 'resize_failed' is initialized.
859 (run_window_configuration_change_hook): Rename local to avoid shadowing.
860 (resize_window_apply): Remove unused local.
861 * window.h (delete_deletable_window): Remove decl.
862
109e28d0 863 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
864 (imagemagick_load_image): Fix pointer signedness problem by changing
865 last arg from unsigned char * to char *. All uses changed.
866 Also, fix a local for similar reasons.
867 Remove unused locals. Remove locals to avoid shadowing.
868 (fn_rsvg_handle_free): Remove; unused.
869 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 870 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 871
3f754b86
PE
872 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
873
2547adb1
CY
8742011-06-10 Chong Yidong <cyd@stupidchicken.com>
875
876 * image.c (gif_load): Fix omitted cast error introduced by
877 2011-06-06 change.
878
2c8e37d4
MR
8792011-06-10 Martin Rudalics <rudalics@gmx.at>
880
881 * window.h (resize_proportionally, orig_total_lines)
882 (orig_top_line): Remove from window structure.
883 (set_window_height, set_window_width, change_window_heights)
884 (Fdelete_window): Remove prototypes.
885 (resize_frame_windows): Remove duplicate declaration.
886
440a42e3
EZ
8872011-06-10 Eli Zaretskii <eliz@gnu.org>
888
889 * window.h (resize_frame_windows, resize_window_check)
890 (delete_deletable_window, resize_root_window)
891 (resize_frame_windows): Declare prototypes.
892
893 * window.c (resize_window_apply): Make definition be "static" to
894 match the prototype.
895
562dd5e9
MR
8962011-06-10 Martin Rudalics <rudalics@gmx.at>
897
898 * window.c: Remove declarations of Qwindow_size_fixed,
899 window_min_size_1, window_min_size_2, window_min_size,
900 size_window, window_fixed_size_p, enlarge_window, delete_window.
901 Remove static from declaration of Qdelete_window, it's
902 temporarily needed by Fbury_buffer.
903 (replace_window): Don't assign orig_top_line and
904 orig_total_lines.
905 (Fdelete_window, delete_window): Remove. Window deletion is
906 handled by window.el.
907 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
908 Fdelete_window calls with calls to Qdelete_window.
909 (Fdelete_other_windows): Remove. Deleting other windows is
910 handled by window.el.
911 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
912 handled in window.el.
913 (window_min_size_2, window_min_size_1, window_min_size): Remove.
914 Window minimum sizes are handled in window.el.
915 (shrink_windows, size_window, set_window_height)
916 (set_window_width, change_window_heights, window_height)
917 (window_width, CURBEG, CURSIZE, enlarge_window)
918 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
919 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
920 handled in window.el.
921 (make_dummy_parent): Rename to make_parent_window and give it a
922 second argument horflag.
923 (make_window): Don't set resize_proportionally any more.
924 (Fsplit_window): Remove. Windows are split in window.el.
925 (save_restore_action, save_restore_orig_size)
926 (shrink_window_lowest_first, save_restore_orig_size): Remove.
927 Resize mini windows in window.el.
928 (grow_mini_window, shrink_mini_window): Implement by calling
929 Qresize_root_window_vertically, resize_window_check and
930 resize_window_apply.
931 (saved_window, Fset_window_configuration, save_window_save): Do
932 not handle orig_top_line, orig_total_lines, and
933 resize_proportionally.
934 (window_min_height, window_min_width): Move to window.el.
935 (keys_of_window): Move bindings for delete-other-windows,
936 split-window, delete-window and enlarge-window to window.el.
937
938 * buffer.c: Temporarily extern Qdelete_window.
939 (Fbury_buffer): Temporarily call Qdelete_window instead of
940 Fdelete_window (Fbury_buffer will move to window.el soon).
941
942 * frame.c (set_menu_bar_lines_1): Remove code handling
943 orig_top_line and orig_total_lines.
944
945 * dispnew.c (adjust_frame_glyphs_initially): Don't use
946 set_window_height but set heights directly.
947 (change_frame_size_1): Use resize_frame_windows.
948
949 * xdisp.c (init_xdisp): Don't use set_window_height but set
950 heights directly.
951
952 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
953 resize_frame_windows instead of change_window_heights and run
954 run_window_configuration_change_hook.
955
956 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
957 instead of change_window_heights and run
958 run_window_configuration_change_hook.
959
1a13852e
MR
9602011-06-09 Martin Rudalics <rudalics@gmx.at>
961
962 * window.c (replace_window): Rename second argument REPLACEMENT to
963 NEW. New third argument SETFLAG. Rewrite.
964 (delete_window, make_dummy_parent): Call replace_window with
965 third argument 1.
966 (window_list_1): Move down in code.
967 (run_window_configuration_change_hook): Move set_buffer part
968 before select_frame_norecord part in order to unwind correctly.
969 Rename count1 to count.
970 (recombine_windows, delete_deletable_window, resize_root_window)
971 (Fdelete_other_windows_internal)
972 (Frun_window_configuration_change_hook, make_parent_window)
973 (resize_window_check, resize_window_apply, Fresize_window_apply)
974 (resize_frame_windows, Fsplit_window_internal)
975 (Fdelete_window_internal, Fresize_mini_window_internal): New
976 functions.
977 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
978
f3d1777e
MR
9792011-06-08 Martin Rudalics <rudalics@gmx.at>
980
496e208e
MR
981 * window.h (window): Add some new members to window structure -
982 normal_lines, normal_cols, new_total, new_normal, clone_number,
983 splits, nest, prev_buffers, next_buffers.
984 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 985 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 986
f3d1777e
MR
987 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
988 Remove.
496e208e
MR
989 (make_dummy_parent): Set new members of windows structure.
990 (make_window): Move down in code. Handle new members of window
991 structure.
992 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
993 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
994 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
995 (Fset_window_prev_buffers, Fwindow_next_buffers)
996 (Fset_window_next_buffers, Fset_window_clone_number): New
997 functions.
998 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
999 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1000 Doc-string fixes.
1001 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1002 Argument WINDOW can be now internal window too.
1003 (Fwindow_use_time): Move up in code.
1004 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1005 Rewrite doc-string.
1006 (Fset_window_configuration, saved_window)
1007 (Fcurrent_window_configuration, save_window_save): Handle new
1008 members of window structure.
b9e809c2
MR
1009 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1010 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1011 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1012 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1013 Qget_mru_window, Qresize_root_window,
1014 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1015 Qauto_buffer_name; staticpro them.
f3d1777e 1016
abde8f8c
MR
10172011-06-07 Martin Rudalics <rudalics@gmx.at>
1018
1019 * window.c (Fwindow_total_size, Fwindow_left_column)
1020 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1021 (Fwindow_list_1): New functions.
1022 (window_box_text_cols): Replace with window_body_cols.
1023 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1024 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1025 (delete_window, Fset_window_configuration): Call
1026 delete_all_subwindows with window as argument.
1027 (delete_all_subwindows): Take a window as argument and not a
1028 structure. Rewrite.
190b47e6
MR
1029 (window_loop): Remove handling of GET_LRU_WINDOW and
1030 GET_LARGEST_WINDOW.
1031 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1032
1033 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1034 window_box_text_cols. delete_all_subwindows now takes a
1035 Lisp_Object as argument.
abde8f8c
MR
1036
1037 * indent.c (compute_motion, Fcompute_motion): Use
1038 window_body_cols instead of window_box_text_cols.
1039
fa8a67e6
MR
1040 * frame.c (delete_frame): Call delete_all_subwindows with root
1041 window as argument.
1042
a54e3482
DC
10432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1044
1045 * fns.c (Fputhash): Document return value.
1046
60002bf5
CY
10472011-06-06 Chong Yidong <cyd@stupidchicken.com>
1048
1049 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1050
0c671da6 10512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1052
b862a52a 1053 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1054
be44ca6c
PE
1055 Check for overflow when converting integer to cons and back.
1056 * charset.c (Fdefine_charset_internal, Fdecode_char):
1057 Use cons_to_unsigned to catch overflow.
1058 (Fencode_char): Use INTEGER_TO_CONS.
1059 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1060 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1061 * data.c (long_to_cons, cons_to_long): Remove.
1062 (cons_to_unsigned, cons_to_signed): New functions.
1063 These signal an error for invalid or out-of-range values.
1064 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1065 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1066 * font.c (Ffont_variation_glyphs):
1067 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1068 * lisp.h: Include <intprops.h>.
1069 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1070 (cons_to_signed, cons_to_unsigned): New decls.
1071 (long_to_cons, cons_to_long): Remove decls.
1072 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1073 (Fprimitive_undo): Use CONS_TO_INTEGER.
1074 * xfns.c (Fx_window_property): Likewise.
1075 * xselect.c: Include <limits.h>.
1076 (x_own_selection, selection_data_to_lisp_data):
1077 Use INTEGER_TO_CONS.
1078 (x_handle_selection_request, x_handle_selection_clear)
1079 (x_get_foreign_selection, Fx_disown_selection_internal)
1080 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1081 (lisp_data_to_selection_data): Use cons_to_unsigned.
1082 (x_fill_property_data): Use cons_to_signed.
1083 Report values out of range.
1084
d1f3d2af
PE
1085 Check for buffer and string overflow more precisely.
1086 * buffer.h (BUF_BYTES_MAX): New macro.
1087 * lisp.h (STRING_BYTES_MAX): New macro.
1088 * alloc.c (Fmake_string):
1089 * character.c (string_escape_byte8):
1090 * coding.c (coding_alloc_by_realloc):
1091 * doprnt.c (doprnt):
1092 * editfns.c (Fformat):
1093 * eval.c (verror):
1094 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1095 since they may not be the same number.
1096 * editfns.c (Finsert_char):
1097 * fileio.c (Finsert_file_contents):
1098 Likewise for BUF_BYTES_MAX.
1099
dd52fcea
PE
1100 * image.c: Use ptrdiff_t, not int, for sizes.
1101 (slurp_file): Switch from int to ptrdiff_t.
1102 All uses changed.
1103 (slurp_file): Check that file size fits in both size_t (for
1104 malloc) and ptrdiff_t (for sanity and safety).
1105
7f9bbdbb
PE
1106 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1107 if b->modtime has its maximal value.
1108
dfe18f82
PE
1109 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1110
84acfcf0
PE
1111 Don't assume time_t can fit into int.
1112 * buffer.h (struct buffer.modtime): Now time_t, not int.
1113 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1114 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1115
ccd9a01a
PE
1116 Minor fixes for signed vs unsigned integers.
1117 * character.h (MAYBE_UNIFY_CHAR):
1118 * charset.c (maybe_unify_char):
1119 * keyboard.c (read_char, reorder_modifiers):
1120 XINT -> XFASTINT, since the integer must be nonnegative.
1121 * ftfont.c (ftfont_spec_pattern):
1122 * keymap.c (access_keymap, silly_event_symbol_error):
1123 XUINT -> XFASTINT, since the integer must be nonnegative.
1124 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1125 since it makes no difference and we prefer signed.
1126 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1127 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1128 nonnegative.
1129
d6d100dd
SM
11302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1131
1132 * window.h (Fwindow_frame): Declare.
1133
2b6148e4
PE
11342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1137 (SPARE_MEMORY): Always define.
1138 (LARGE_REQUEST): Remove.
1139 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1140
f230ecc9
MR
11412011-06-06 Martin Rudalics <rudalics@gmx.at>
1142
727e958e
MR
1143 * lisp.h: Move EXFUNS for Fframe_root_window,
1144 Fframe_first_window and Fset_frame_selected_window to window.h.
1145
1146 * window.h: Move EXFUNS for Fframe_root_window,
1147 Fframe_first_window and Fset_frame_selected_window here from
1148 lisp.h.
1149
1150 * frame.c (Fwindow_frame, Fframe_first_window)
1151 (Fframe_root_window, Fframe_selected_window)
1152 (Fset_frame_selected_window): Move to window.c.
1153 (Factive_minibuffer_window): Move to minibuf.c.
1154 (Fother_visible_frames_p): New function.
1155
1156 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1157
f230ecc9
MR
1158 * window.c (decode_window, decode_any_window): Move up in code.
1159 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1160 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1161 (Fwindow_buffer): Move up and rewrite doc-string.
1162 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1163 (Fwindow_prev): New functions.
727e958e
MR
1164 (Fwindow_frame): Move here from frame.c. Accept any window as
1165 argument.
1166 (Fframe_root_window, Fframe_first_window)
1167 (Fframe_selected_window): Move here from frame.c. Accept frame
1168 or arbitrary window as argument. Update doc-strings.
1169 (Fminibuffer_window): Move up in code.
1170 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1171 (Fset_frame_selected_window): Move here from frame.c.
1172 Marginal rewrite.
727e958e
MR
1173 (Fselected_window, select_window, Fselect_window): Move up in
1174 code. Minor doc-string fixes.
f230ecc9 1175
4d09bcf6
PE
11762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1179 Do not assume that spare memory exists; that assumption is valid
1180 only if SYSTEM_MALLOC.
1181 (LARGE_REQUEST): New macro, so that the issue of large requests
1182 is separated from the issue of spare memory.
1183
810928a2
AS
11842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1185
172418ad
AS
1186 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1187 format. (Bug#8806)
1188
43f862f7
AS
1189 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1190
810928a2
AS
1191 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1192 before statements.
1193
a059fe24
JD
11942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1195
1196 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1197
1198 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1199
1200 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1201 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1202
989bf368
JB
12032011-06-05 Juanma Barranquero <lekktu@gmail.com>
1204
1205 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1206
4b80f674
CY
12072011-06-04 Chong Yidong <cyd@stupidchicken.com>
1208
1209 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1210 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1211 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1212 New error handlers.
4b80f674
CY
1213 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1214 Obey Vx_select_enable_clipboard_manager. Catch errors in
1215 x_clipboard_manager_save (Bug#8779).
1216 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1217 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1218
99a33b77 12192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1220
1221 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1222
99a33b77 12232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1224
1225 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1226 in the current matrix if keep_current_p is non-zero.
1227
8264569d
EZ
12282011-06-04 Eli Zaretskii <eliz@gnu.org>
1229
1230 * bidi.c (bidi_level_of_next_char): Fix last change.
1231
57f97249
EZ
12322011-06-03 Eli Zaretskii <eliz@gnu.org>
1233
fec2107c 1234 Support bidi reordering of text covered by display properties.
57f97249 1235
fec2107c
EZ
1236 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1237 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1238 (bidi_cache_search, bidi_cache_iterator_state)
1239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1240 (bidi_level_of_next_char, bidi_move_to_visually_next):
1241 Support character positions inside a run of characters covered by a
fec2107c
EZ
1242 display string.
1243 (bidi_paragraph_init, bidi_resolve_explicit_1)
1244 (bidi_level_of_next_char): Call bidi_fetch_char and
1245 bidi_fetch_char_advance instead of FETCH_CHAR and
1246 FETCH_CHAR_ADVANCE.
1247 (bidi_init_it): Initialize new members.
1248 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1249 definitions.
1250 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1251 instead of using explicit *_CHAR codes.
d6d100dd
SM
1252 (bidi_resolve_explicit, bidi_resolve_weak):
1253 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1254 bidirectional text is supported only in multibyte buffers.
1255 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1256 it to initialize the frame_window_p member of struct bidi_it.
1257 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1258 (bidi_resolve_explicit, bidi_resolve_weak)
1259 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1260 bidi_it->nchars is non-positive.
1261 (bidi_level_of_next_char): Don't try to lookup the cache for the
1262 next/previous character if nothing is cached there yet, or if we
1263 were just reseat()'ed to a new position.
c40e2fb2 1264
0e14fe90
EZ
1265 * xdisp.c (set_cursor_from_row): Set start and stop points
1266 according to the row's direction when priming the loop that looks
1267 for the glyph on which to display cursor.
1268 (single_display_spec_intangible_p): Function deleted.
1269 (display_prop_intangible_p): Reimplement to call
1270 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1271 Accept 3 additional arguments needed by handle_display_spec.
1272 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1273 values: lists, `(when COND...)' forms, etc.
1274 (single_display_spec_string_p): Support property values that are
1275 lists with the argument STRING its top-level element.
1276 (display_prop_string_p): Fix the condition for processing a
1277 property that is a list to be consistent with handle_display_spec.
fec2107c 1278 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1279 last portion of handle_display_prop.
1280 (compute_display_string_pos): Accept additional argument
1281 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1282 value of a `display' property is a "replacing spec".
1283 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1284 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1285 the display property, but just return a value indicating whether
1286 the display property will replace the characters it covers.
1287 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1288 frame_window_p members of struct bidi_it.
d6d100dd
SM
1289 (compute_display_string_pos, compute_display_string_end):
1290 New functions.
fec2107c
EZ
1291 (push_it): Accept second argument POSITION, where pop_it should
1292 jump to continue iteration.
1293 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1294
fec2107c
EZ
1295 * keyboard.c (adjust_point_for_property): Adjust the call to
1296 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1297
1298 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1299 (bidi_init_it): Update prototypes.
1300 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1301 (compute_display_string_pos, compute_display_string_end):
1302 Declare prototypes.
fec2107c
EZ
1303 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1304 EMACS_INT.
fc6f18ce 1305
40087514 13062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1307
57f53182
PE
1308 Malloc failure behavior now depends on size of allocation.
1309 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1310 * lisp.h: Change signatures accordingly.
1311 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1312 All callers changed. (Bug#8762)
1313
1314 * gnutls.c: Use Emacs's memory allocators.
1315 Without this change, the gnutls library would invoke malloc etc.
1316 directly, which causes problems on non-SYNC_INPUT hosts, and which
1317 runs afoul of improving memory_full behavior. (Bug#8761)
1318 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1319 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1320 xfree instead of the default malloc, realloc, free.
1321 (Fgnutls_boot): No need to check for memory allocation failure,
1322 since xmalloc does that for us.
1323
ac32cd99 1324 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1325 * category.c (hash_get_category_set):
1326 * ccl.c (ccl_driver):
1327 * charset.c (Fdefine_charset_internal):
1328 * charset.h (struct charset.hash_index):
1329 * composite.c (get_composition_id, gstring_lookup_cache)
1330 (composition_gstring_put_cache):
1331 * composite.h (struct composition.hash_index):
1332 * dispextern.h (struct image.hash):
1333 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1334 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1335 (hashfn_equal, hashfn_user_defined, make_hash_table)
1336 (maybe_resize_hash_table, hash_lookup, hash_put)
1337 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1338 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1339 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1340 * image.c (make_image, search_image_cache, lookup_image)
1341 (xpm_put_color_table_h):
1342 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1343 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1344 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1345 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1346 * alloc.c (allocate_vectorlike):
1347 Check for overflow in vector size calculations.
1348 * ccl.c (ccl_driver):
1349 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1350 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1351 need to be updated by these changes.
40087514
PE
1352 * fns.c (make_hash_table, maybe_resize_hash_table):
1353 Check for integer overflow with large hash tables.
0de4bb68
PE
1354 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1355 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1356 (SXHASH_REDUCE): New macro.
1357 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1358 Use it instead of discarding useful hash info with large hash values.
1359 (sxhash_float): New function.
1360 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1361 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1362 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1363 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1364 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1365 Adjust signatures to match updated version of code.
1366 (consing_since_gc): Now EMACS_INT, since a single hash table can
1367 use more than INT_MAX bytes.
1368
698d32e2
DN
13692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1370
1371 Make it possible to build with GCC-4.6+ -O2 -flto.
1372
1373 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1374
fd6fa53f
SM
13752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1376
1377 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1378 Call minibuffer-inactive-mode.
1379
864db017
JB
13802011-05-31 Juanma Barranquero <lekktu@gmail.com>
1381
1382 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1383 Update dependencies.
1384
2ad0baf4
DN
13852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1386
1387 * data.c (init_data): Remove code for UTS, this system is not
1388 supported anymore.
1389
4fcc2638
DN
13902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1391
1392 Don't force ./temacs to start in terminal mode.
1393
1394 * frame.c (make_initial_frame): Initialize faces in all cases, not
1395 only when CANNOT_DUMP is defined.
1396 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1397
c56e0fd5
DN
13982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1399
1400 * dispnew.c (add_window_display_history): Use const for the string
1401 pointer. Remove declaration, not needed.
1402
333d54da 14032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1404
55d4c1b2 1405 Use 'inline', not 'INLINE'.
333d54da 1406 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1407 * alloc.c, fontset.c (INLINE): Remove.
1408 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1409 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1410 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1411 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1412 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1413
738db178
DN
14142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1415
1416 Make it possible to run ./temacs.
1417
1418 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1419 syms_of_callproc does the same thing. Remove test for
1420 "initialized", do it in the caller.
1421 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1422
620c53a6
SM
14232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1424
1425 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1426 (read_minibuf): Use get_minibuffer.
1427 (syms_of_minibuf): Use DEFSYM.
1428 (Qmetadata): New var.
1429 * data.c (Qbuffer): Don't make it static.
1430 (syms_of_data): Use DEFSYM.
1431
e003a292
PE
14322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1435 (CCL_CODE_MIN): New macro.
1436
ed008a6d
PE
14372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1438
3687c2ef
PE
1439 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1440
ed008a6d
PE
1441 * eval.c (Qdebug): Now static.
1442 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1443 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1444 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1445
d66c4c7c
CY
14462011-05-29 Chong Yidong <cyd@stupidchicken.com>
1447
1448 * image.c: Various fixes to ImageMagick code comments.
1449 (Fimagemagick_types): Doc fix.
1450
5fbc2025
PE
14512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1452
0196f88a
PE
1453 Minor fixes prompted by GCC 4.6.0 warnings.
1454
1455 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1456
5fbc2025
PE
1457 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1458 (x_clipboard_manager_save_all): Move extern decl to ...
1459 * xterm.h: ... here, so that it can be checked for consistency.
1460
1dd3c2d9
CY
14612011-05-29 Chong Yidong <cyd@stupidchicken.com>
1462
1463 * xselect.c (x_clipboard_manager_save_frame)
1464 (x_clipboard_manager_save_all): New functions.
1465 (Fx_clipboard_manager_save): Lisp function deleted.
1466
1467 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1468 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1469
1470 * xterm.h: Update prototype.
1471
5ba6571d
WX
14722011-05-28 William Xu <william.xwl@gmail.com>
1473
1474 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1475 exiting (Bug#8239).
1476
3eaff834
JM
14772011-05-28 Jim Meyering <meyering@redhat.com>
1478
e1900994 1479 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1480 * fns.c (to_uchar): Define.
1481 (crypto_hash_function): Use it to convert some newly-signed
1482 variables to unsigned, to avoid sign-extension bugs. For example,
1483 without this change, (md5 "truc") would evaluate to
1484 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1485 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1486 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1487
0f6990a7
PE
14882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 Integer overflow fixes.
c8a9ca5a 1491
08686060
PE
1492 * dbusbind.c: Serial number integer overflow fixes.
1493 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1494 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1495 to hold a serial number that is too large for a fixnum.
1496 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1497 Check for serial numbers out of range. Decode any serial number
59568bf0 1498 that was so large that it became a float. (Bug#8722)
08686060 1499
2d1fc3c7
PE
1500 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1501 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1502 Use XFASTINT rather than XUINT when numbers are nonnegative.
1503 (xd_append_arg, Fdbus_method_return_internal):
1504 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1505 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1506 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1507 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1508 (Bug#8722)
2d1fc3c7 1509
c8a9ca5a
PE
1510 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1511
519e1d69
PE
1512 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1513
30569699
PE
1514 ccl: add integer overflow checks
1515 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1516 (IN_INT_RANGE): New macros.
1517 (ccl_driver): Use them to check for integer overflow when
1518 decoding a CCL program. Many of the new checks are whether XINT (x)
1519 fits in int; it doesn't always, on 64-bit hosts. The new version
1520 doesn't catch all possible integer overflows, but it's an
847044ea 1521 improvement. (Bug#8719)
30569699 1522
c11285dc
PE
1523 * alloc.c (make_event_array): Use XINT, not XUINT.
1524 There's no need for unsigned here.
1525
fdccd48e
PE
1526 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1527 This follows up to the 2011-05-06 change that substituted uintptr_t
1528 for EMACS_INT. This case wasn't caught back then.
1529
37910ab2
PE
1530 Rework Fformat to avoid integer overflow issues.
1531 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1532 now (part of C89). Include <verify.h>.
1533 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1534 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1535 (Fformat): Avoid the prepass trying to compute sizes; it was only
1536 approximate and thus did not catch overflow reliably. Instead, walk
1537 through the format just once, formatting and computing sizes as we go,
1538 checking for integer overflow at every step, and allocating a larger
1539 buffer as needed. Keep track separately whether the format is
1540 multibyte. Keep only the most-recently calculated precision, rather
1541 than them all. Record whether each argument has been converted to
1542 string. Use EMACS_INT, not int, for byte and char and arg counts.
1543 Support field widths and precisions larger than INT_MAX. Avoid
1544 sprintf's undefined behavior with conversion specifications such as %#d
1545 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1546 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1547 formatting out-of-range floating point numbers with int
1548 formats. (Bug#8668)
1549
2e6578fb
PE
1550 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1551
0ae6bdee
PE
1552 * data.c: Avoid integer truncation in expressions involving floats.
1553 * data.c: Include <intprops.h>.
1554 (arith_driver): When there's an integer overflow in an expression
1555 involving floating point, convert the integers to floating point
1556 so that the resulting value does not suffer from catastrophic
1557 integer truncation. For example, on a 64-bit host (* 4
1558 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1559 Do not rely on undefined behavior after integer overflow.
1560
de883a70
PE
1561 merge count_size_as_multibyte, parse_str_to_multibyte
1562 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1563 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1564 Check for integer overflow.
1565 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1566 since it's now a duplicate of the other. This is more of
1567 a character than a buffer op, so better that it's in character.c.
1568 * fns.c, print.c: Adjust to above changes.
1569
2ff916cb
PE
15702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1571
1572 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1573
f1b54466
PE
15742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1575
fb1ac845
PE
1576 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1577 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1578 (x_clipboard_manager_save): Now static.
1579 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1580
f1b54466
PE
1581 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1582 (crypto_hash_function): Now static.
1583 Fix pointer signedness problems. Avoid unnecessary initializations.
1584
a9f737ee
CY
15852011-05-27 Chong Yidong <cyd@stupidchicken.com>
1586
1587 * termhooks.h (Vselection_alist): Make it terminal-local.
1588
1589 * terminal.c (create_terminal): Initialize it.
1590
1591 * xselect.c: Support for clipboard managers.
1592 (Vselection_alist): Move to termhooks.h as terminal-local var.
1593 (LOCAL_SELECTION): New macro.
1594 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1595 (symbol_to_x_atom): Remove gratuitous arg.
1596 (x_handle_selection_request, lisp_data_to_selection_data)
1597 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1598 (x_own_selection, x_get_local_selection, x_convert_selection):
1599 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1600 (some_frame_on_display): Delete unused function.
1601 (Fx_own_selection_internal, Fx_get_selection_internal)
1602 (Fx_disown_selection_internal, Fx_selection_owner_p)
1603 (Fx_selection_exists_p): New optional frame arg.
1604 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1605 (x_handle_selection_clear): Don't treat other terminals with the
1606 same keyboard specially. Use the terminal-local Vselection_alist.
1607 (x_clear_frame_selections): Use Frun_hook_with_args.
1608
1609 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1610
1611 * xterm.h: Add support for those atoms.
1612
e067f0c1
CY
16132011-05-26 Chong Yidong <cyd@stupidchicken.com>
1614
1615 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1616 (converted_selections, conversion_fail_tag): New global variables.
1617 (x_selection_request_lisp_error): Free the above.
1618 (x_get_local_selection): Remove unnecessary code.
1619 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1620 of converted selections stored in converted_selections.
1621 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1622 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1623 (x_convert_selection): New function.
1624 (x_handle_selection_event): Simplify.
1625 (x_get_foreign_selection): Don't ignore incoming requests while
1626 waiting for an answer; this will fail when we implement
1627 SAVE_TARGETS, and seems unnecessary anyway.
1628 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1629 (Vx_sent_selection_functions): Doc fix.
1630
0f4aebc0
LL
16312011-05-26 Leo Liu <sdl.web@gmail.com>
1632
1633 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1634
e61124cd
YM
16352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1636
1637 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1638
1639 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1640 for fringe update if it has periodic bitmap.
1641 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1642 and fringe_bitmap_periodic_p.
1643
1644 * fringe.c (get_fringe_bitmap_data): New function.
1645 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1646 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1647 row. Mark glyph row for fringe update if periodicity changed.
1648
1649 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1650 for fringe update unless it has periodic bitmap.
1651
f16d9837
KH
16522011-05-25 Kenichi Handa <handa@m17n.org>
1653
1654 * xdisp.c (get_next_display_element): Set correct it->face_id for
1655 a static composition.
1656
e1b90ef6
LL
16572011-05-24 Leo Liu <sdl.web@gmail.com>
1658
1659 * deps.mk (fns.o):
1660 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1661
1662 * fns.c (crypto_hash_function, Fsha1): New function.
1663 (Fmd5): Use crypto_hash_function.
1664 (syms_of_fns): Add Ssha1.
1665
7400048f
PE
16662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1667
1668 * gnutls.c: Remove unused macros.
1669 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1670 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1671 Remove macros that are defined and never used.
1672 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1673
abb71cf4
CY
16742011-05-22 Chong Yidong <cyd@stupidchicken.com>
1675
1676 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1677 (Fx_get_selection_internal): Minor cleanup.
1678 (Fx_own_selection_internal): Rename arguments for consistency with
1679 select.el.
1680
6307db39
PE
16812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1684
f3d4e0a4
CY
16852011-05-22 Chong Yidong <cyd@stupidchicken.com>
1686
1687 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1688
4d8ade89
YM
16892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1690
1691 * dispnew.c (scrolling_window): Don't exclude the case that the
1692 last enabled row in the desired matrix touches the bottom boundary.
1693
32078c8d
GM
16942011-05-21 Glenn Morris <rgm@gnu.org>
1695
1696 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1697 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1698 and add some more files.
32078c8d 1699
7285dc67
EZ
17002011-05-20 Eli Zaretskii <eliz@gnu.org>
1701
1702 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1703 report_file_error introduced by the change from 2011-05-07.
1704
89d1bd22
PE
17052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 * systime.h (Time): Define only if emacs is defined.
1708 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1709 where the include path doesn't have X11/X.h by default. See
1710 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1711
e23640bb 17122011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1713
1714 * composite.c (find_automatic_composition): Fix previous change.
1715
b9704ad9
GM
17162011-05-20 Glenn Morris <rgm@gnu.org>
1717
1718 * lisp.mk: New file, split from Makefile.in.
1719 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1720 (shortlisp): Remove.
1721 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1722
4a720484
GM
17232011-05-19 Glenn Morris <rgm@gnu.org>
1724
1725 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1726 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1727 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1728 (lisp): Set the order to that of loadup.el.
1729 (shortlisp): Make it a copy of $lisp.
1730 (SOME_MACHINE_LISP): Remove.
1731 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1732 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1733
a28d4396
KH
17342011-05-18 Kenichi Handa <handa@m17n.org>
1735
1736 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1737 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1738 (find_automatic_composition): Mostly rewrite for efficiency.
1739
a2b1fa8e
JB
17402011-05-18 Juanma Barranquero <lekktu@gmail.com>
1741
1742 * makefile.w32-in: Update dependencies.
1743
8e1f5610
CS
17442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1745
1746 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1747 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1748
7025ee00 17492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1750
cdfa6eab
PE
1751 Fix some integer overflow issues, such as string length overflow.
1752
06d6db33
PE
1753 * insdel.c (count_size_as_multibyte): Check for string overflow.
1754
2b4560a8
PE
1755 * character.c (lisp_string_width): Check for string overflow.
1756 Use EMACS_INT, not int, for string indexes and lengths; in
1757 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1758 the resulting string length overflows an EMACS_INT; instead,
1759 report a string overflow if no precision given. When checking for
1760 precision exhaustion, use a check that cannot possibly have
1761 integer overflow. (Bug#8675)
1762 * character.h (lisp_string_width): Adjust to new signature.
1763
cb93f9be
PE
1764 * alloc.c (string_overflow): New function.
1765 (Fmake_string): Use it. This doesn't change behavior, but saves
1766 a few bytes and will simplify future changes.
1767 * character.c (string_escape_byte8): Likewise.
1768 * lisp.h (string_overflow): New decl.
1769
1a1f3366
PE
1770 Fixups, following up to the user-interface timestamp change.
1771 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1772 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1773 * msdos.c (mouse_get_pos): Likewise.
1774 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1775 * w32gui.h (Time): Define by including "systime.h" rather than by
1776 declaring it ourselves. (Bug#8664)
1777
d4e3e4d3
PE
1778 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1779 * image.c (clear_image_cache): Likewise.
1780
f6a24d19
PE
1781 * term.c (term_mouse_position): Don't assume time_t wraparound.
1782
08dc5ae6
PE
1783 Be more systematic about user-interface timestamps.
1784 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1785 and sometimes 'EMACS_UINT', to represent these timestamps.
1786 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1787 This makes the code easier to follow, and makes it easier to catch
1788 integer overflow bugs such as Bug#8664.
1789 * frame.c (Fmouse_position, Fmouse_pixel_position):
1790 Use Time, not unsigned long, for user-interface timestamps.
1791 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1792 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1793 * keyboard.h (last_event_timestamp): Likewise.
1794 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1795 * menu.h (xmenu_show): Likewise.
1796 * term.c (term_mouse_position): Likewise.
1797 * termhooks.h (struct input_event.timestamp): Likewise.
1798 (struct terminal.mouse_position_hook): Likewise.
1799 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1800 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1801 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1802 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1803 what it was before.
1804 * menu.h, termhooks.h: Include "systime.h", for Time.
1805
8e55734a
PE
1806 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1807 Don't assume that the difference between two unsigned long values
1808 can fit into an integer. At this point, we know button_down_time
1809 <= event->timestamp, so the difference must be nonnegative, so
1810 there's no need to cast the result if double-click-time is
1811 nonnegative, as it should be; check that it's nonnegative, just in
1812 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1813 apart (about 25 days). (Bug#8664)
8e55734a 1814
841f1b75 1815 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1816 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1817
3e26f69c
PE
1818 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1819 that always fit in int. Use a sentinel instead of a counter, to
1820 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1821 * frame.h (struct frame): Use int for menu_bar_items_used
1822 instead of EMACS_INT, since it always fits in int.
3e26f69c 1823
5cc152c0
PE
1824 * menu.c (grow_menu_items): Check for int overflow.
1825
d89eb65e
PE
1826 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1827
5235bd3e
PE
1828 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1829 Before, the code was not consistent. These values cannot exceed
1830 2**31 - 1 so there's no need to make them unsigned.
1831 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1832 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1833 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1834 as modifiers.
1835 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1836
bc827e23
PE
1837 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1838 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1839 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1840 presumably because the widths might not match.
1841
78eb494e
PE
1842 * window.c (size_window): Avoid needless test at loop start.
1843
04f2d78b
CB
18442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1845
1846 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1847
d2fc7e3d 18482011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1849
1850 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1851
d2fc7e3d 18522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1853
1854 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1855 `width' to `bar_area_x' and `bar_area_width', respectively.
1856 (x_scroll_run): Take account of fringe background extension.
1857
04f2d78b
CB
1858 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1859 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1860 `bar_area_width', respectively.
1861 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1862 background extension.
1863
79b70037
GM
18642011-05-10 Jim Meyering <meyering@redhat.com>
1865
1866 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1867
2f142cc5
JB
18682011-05-10 Juanma Barranquero <lekktu@gmail.com>
1869
1870 * image.c (Finit_image_library): Return t for built-in image types,
1871 like pbm and xbm. (Bug#8640)
1872
57679c86
AS
18732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1874
1875 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1876
888c9e86
EZ
18772011-05-07 Eli Zaretskii <eliz@gnu.org>
1878
b0512a1d
EZ
1879 * w32console.c (Fset_screen_color): Doc fix.
1880 (Fget_screen_color): New function.
1881 (syms_of_ntterm): Defsubr it.
1882
7285dc67
EZ
1883 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1884 unlink the temporary file if Fcall_process didn't create it in the
1885 first place.
1886 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1887 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1888 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1889 cue to call_process_cleanup not to close that handle.
1890
4d3fcc8e
BK
18912011-05-07 Ben Key <bkey76@gmail.com>
1892
1893 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1894 one of two shell specific rules, either bootstrap-temacs-CMD or
1895 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1896 to the previous implementation of the bootstrap-temacs rule.
1897 The bootstrap-temacs-CMD rule is similar to the previous
1898 implementation of the bootstrap-temacs rule except that it
1899 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1900 variable.
1901
1902 These changes, along with some changes to nt/configure.bat,
1903 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1904 earlier fix to add support for --cflags and --ldflags options
1905 that include quotes so that it works whether make uses cmd or
1906 sh as the shell.
1907
b4289b64
MA
19082011-05-06 Michael Albinus <michael.albinus@gmx.de>
1909
1910 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1911 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1912 is a constant.
1913 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1914 a string. Handle both cases.
1915 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1916 (Fdbus_register_method): Use Qinvalid_function.
1917
af4c0e28
JB
19182011-05-06 Juanma Barranquero <lekktu@gmail.com>
1919
1920 * makefile.w32-in: Update dependencies.
1921 (LISP_H): Add inttypes.h and stdin.h.
1922 (PROCESS_H): Add unistd.h.
1923
c51453d9
EZ
19242011-05-06 Eli Zaretskii <eliz@gnu.org>
1925
1926 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1927 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1928
8ff0ac3c 19292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1930
4c4b566b
PE
1931 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1932
aab2b9b5
PE
1933 * term.c (vfatal): Remove stray call to va_end.
1934 It's not needed and the C Standard doesn't allow it here anyway.
1935
c378da0b
PE
1936 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1937 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1938
288b08c7
PE
1939 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1940 bytes.
1941
e3601888
PE
1942 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1943
db6c0e74
PE
1944 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1945
dd5963ea
PE
1946 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1947
88c9450f
PE
1948 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1949
2f9442b8
PE
1950 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1951
c032b5f8
PE
1952 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1953 * charset.c (Fdefine_charset_internal): Don't initialize
1954 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1955 32-bit int (Bug#8600).
a108c10b
PE
1956
1957 * lread.c (read_integer): Be more consistent with string-to-number.
1958 Use string_to_number to do the actual conversion; this avoids
1959 rounding errors and fixes some other screwups. Without this fix,
1960 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1961 (digit_to_number): Move earlier, for benefit of read_integer.
1962 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1963 not a digit in any supported base. (Bug#8602)
a108c10b 1964
ad5f9eea
PE
1965 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1966
aec1708a
PE
1967 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1968 to match comment at start of function. This also removes a
1969 GCC warning about overflow in a 32+64-bit port.
1970
47be4ab5
PE
1971 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1972
371cac43
PE
1973 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1974 Reported by Stefan Monnier in
1975 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1976 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1977 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1978
d01a7826
PE
1979 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1980 (EMACS_UINTPTR): Likewise, with uintptr_t.
1981
7fd47d5c
PE
1982 * lisp.h: Prefer 64-bit EMACS_INT if available.
1983 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1984 on 32-bit hosts that have 64-bit int, so that they can access
1985 large files.
122b0c86
PE
1986 However, temporarily disable this change unless the temporary
1987 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1988
8727937b
PE
1989 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1990
8ac068ac
PE
1991 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1992 This removes an assumption that EMACS_INT and long are the same
1993 width as pointers. The assumption is true for Emacs porting targets
1994 now, but we want to make other targets possible.
1995 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1996 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1997 In the rest of the code, change types of integers that hold casted
1998 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1999 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2000 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2001 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2002 No need to cast type when ORing.
2003 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2004 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2005 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2006 assume EMACS_INT is the same width as char *.
2007 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2008 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2009 Remove no-longer-needed casts.
2010 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2011 (xg_tool_bar_help_callback, xg_make_tool_item):
2012 Use EMACS_INTPTR to hold an integer
2013 that will be cast to void *; this can avoid a GCC warning
2014 if EMACS_INT is not the same width as void *.
2015 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2016 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2017 (current_message_1, set_message_1):
2018 Use a local to convert to proper width without a cast.
2019 * xmenu.c (dialog_selection_callback): Likewise.
2020
ede49d71
PE
2021 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2022 Also, don't assume VALBITS / RAND_BITS is less than 5,
2023 and don't rely on undefined behavior when shifting a 1 left into
2024 the sign bit.
2025 * lisp.h (get_random): Change signature to match.
2026
2f30ecd0
PE
2027 * lread.c (hash_string): Use size_t, not int, for hash computation.
2028 Normally we prefer signed values; but hashing is special, because
2029 it's better to use unsigned division on hash table sizes so that
2030 the remainder is nonnegative. Also, size_t is the natural width
2031 for hashing into memory. The previous code used 'int', which doesn't
2032 retain enough info to hash well into very large tables.
2033 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2034
2a866e7b
PE
2035 * dbusbind.c: Don't possibly lose pointer info when converting.
2036 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2037 Use XPNTR rather than XHASH, so that the high-order bits of
2038 the pointer aren't lost when converting through void *.
2039
51639eac
PE
2040 * eval.c (Fautoload): Don't double-shift a pointer.
2041
92394119
PE
2042 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2043
dbdb9a7c
JB
20442011-05-06 Juanma Barranquero <lekktu@gmail.com>
2045
2046 * gnutls.c (DEF_GNUTLS_FN):
2047 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2048
db7a0b4f
AS
20492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2050
2051 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2052 marker. (Bug#8610)
2053
f7ff1b0f 20542011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2055
2056 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2057 New version that can reserve upto 2GB of heap space.
2058
f7ff1b0f 20592011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2060
2061 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2062
639c109b
TZ
20632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2064
2065 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2066 `gnutls_certificate_set_x509_key_file'.
2067
d2127135
JB
20682011-05-05 Juanma Barranquero <lekktu@gmail.com>
2069
2070 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2071 Update dependencies.
2072
e968f4f3
JB
20732011-05-04 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2076 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2077 Remove unused parameter `fildes'.
2078 * process.c (read_process_output, send_process): Don't pass it.
2079
84d358f0
JB
20802011-05-04 Juanma Barranquero <lekktu@gmail.com>
2081
2082 Fix previous change: the library cache is defined in w32.c.
2083 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2084 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2085
0898ca10
JB
20862011-05-04 Juanma Barranquero <lekktu@gmail.com>
2087
2088 Implement dynamic loading of GnuTLS on Windows.
2089
2090 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2091 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2092 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2093 Declare.
2094
2095 * gnutls.c (Qgnutls_dll): Define.
2096 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2097 (gnutls_*): Declare function pointers.
2098 (init_gnutls_functions): New function to initialize function pointers.
2099 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2100 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2101 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2102 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2103 (emacs_gnutls_write, emacs_gnutls_read)
2104 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2105 (Fgnutls_available_p): New function.
2106 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2107 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2108 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2109
2110 * image.c: Include w32.h.
2111 (Vimage_type_cache): Delete.
2112 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2113 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2114 (w32_delayed_load): Move to w32.c.
2115
2116 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2117
2118 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2119 (w32_delayed_load): Move from image.c. When loading a library, record
2120 its filename in the :loaded-from property of the library id.
2121 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2122 Initialize and staticpro them.
2123 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2124
2125 * process.c: Include lisp.h before w32.h, not after.
2126 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2127 instead of gnutls_record_check_pending.
2128
2129 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2130
ff4de4aa
TZ
21312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2132
2133 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2134 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2135 as passed in.
2136
abe95abb
JD
21372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2138
2139 * xterm.c (x_set_frame_alpha): Do not set property on anything
2140 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2141
e16e55d4
JB
21422011-05-02 Juanma Barranquero <lekktu@gmail.com>
2143
2144 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2145
bafcf6a5
JB
21462011-05-02 Juanma Barranquero <lekktu@gmail.com>
2147
2148 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2149 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2150 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2151 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2152 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2153 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2154 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2155 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2156 (Qgnutls_bootprop_callbacks_verify): Make static.
2157
e7a6747f
AS
21582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2159
19ed11ba
AS
2160 * callproc.c: Indentation fixup.
2161
e7a6747f 2162 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2163 (wait_for_termination, interruptible_wait_for_termination):
2164 Move after wait_for_termination_1.
e7a6747f 2165
1ef14cb4
LMI
21662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2167
2168 * sysdep.c (interruptible_wait_for_termination): New function
2169 which is like wait_for_termination, but allows keyboard
2170 interruptions.
2171
2172 * callproc.c (Fcall_process): Add (:file "file") as an option for
2173 the STDOUT buffer.
2174 (Fcall_process_region): Ditto.
2175
330d880c
EZ
21762011-04-30 Eli Zaretskii <eliz@gnu.org>
2177
8db90b73
EZ
2178 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2179 rather than `XVECTOR (FOO)->size'.
2180
330d880c
EZ
2181 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2182 inttypes.h, as a gnulib replacement is used if it not available in
2183 system headers.
2184
15cbd324
EZ
21852011-04-21 Eli Zaretskii <eliz@gnu.org>
2186
2187 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2188 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2189 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2190
2191 * coding.c (coding_alloc_by_realloc): Error out if destination
2192 will grow beyond MOST_POSITIVE_FIXNUM.
2193 (decode_coding_emacs_mule): Abort if there isn't enough place in
2194 charbuf for the composition carryover bytes. Reserve an extra
2195 space for up to 2 characters produced in a loop.
2196 (decode_coding_iso_2022): Abort if there isn't enough place in
2197 charbuf for the composition carryover bytes.
2198
21992011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2200
ae940cca
EZ
2201 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2202 aborting when %lld or %lll format is passed.
2203 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2204 %llo or %llx format is passed. (Bug#8545)
2205
03ab8921
EZ
2206 * window.c (window_scroll_line_based): Use a marker instead of
2207 simple variables to record original value of point. (Bug#7952)
2208
afda1437
EZ
2209 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2210 produced by %s or %c overflows available buffer space. (Bug#8545)
2211
f76dee0c
PE
22122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2215 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2216
fdc5744d
JB
22172011-04-28 Juanma Barranquero <lekktu@gmail.com>
2218
2219 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2220
638f053a
JB
22212011-04-28 Juanma Barranquero <lekktu@gmail.com>
2222
2223 * keyboard.c (Qdelayed_warnings_hook): Define.
2224 (command_loop_1): Run `delayed-warnings-hook'
2225 if Vdelayed_warnings_list is non-nil.
2226 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2227 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2228
d178f871
EZ
22292011-04-28 Eli Zaretskii <eliz@gnu.org>
2230
2231 * doprnt.c (doprnt): Don't return value smaller than the buffer
2232 size if the message was truncated. (Bug#8545).
2233
b124fd93
JB
22342011-04-28 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2237 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2238
e810457d
PE
22392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2242
ea51cceb
JB
22432011-04-27 Juanma Barranquero <lekktu@gmail.com>
2244
2245 * makefile.w32-in: Update dependencies.
2246
94dcfacf
EZ
22472011-04-27 Eli Zaretskii <eliz@gnu.org>
2248
2249 Improve `doprnt' and its usage. (Bug#8545)
2250 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2251 `format_end'. Remove support for %l as a conversion specifier.
2252 Don't use xrealloc. Improve diagnostics when the %l size modifier
2253 is used. Update the commentary.
2254
2255 * eval.c (verror): Simplify calculation of size_t.
2256
2257 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2258 messages.
2259
f61f41d7
PE
22602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2261
2262 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2263 change.
2264
96fb4434
PE
22652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2266
2267 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2268 This makes this file independent of the recent pseudovector change.
2269
671875da 22702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2271
69e9b5a3
PE
2272 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2273
b5f869a7 2274 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2275 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2276 Remove unused local.
c8926152 2277 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2278
841a1577 2279 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2280 GCC 4.6.0 optimizes based on type-based alias analysis.
2281 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2282 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2283 != &v->size, and therefore "v->size = 1; b->size = 2; return
2284 v->size;" must therefore return 1. This assumption is incorrect
2285 for Emacs, since it type-puns struct Lisp_Vector * with many other
2286 types. To fix this problem, this patch adds a new type struct
f904488f 2287 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2288 and pseudovectors, and helps optimizing compilers not get fooled
2289 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2290 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2291 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2292 the size member.
eab3844f
PE
2293 (XSETPVECTYPE): Rewrite in terms of new macro.
2294 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2295 This is a bit clearer, and further avoids the possibility of
2296 undesirable aliasing.
2297 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2298 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2299 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2300 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2301 (ASIZE): Now uses header.size rather than size.
2302 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2303 to avoid the hassle of writing XVECTOR (foo)->header.size.
2304 (struct vectorlike_header): New type.
eab3844f
PE
2305 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2306 object, to help avoid aliasing.
2307 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2308 (SUBRP): Likewise, since Lisp_Subr is a special case.
2309 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2310 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2311 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2312 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2313 changed to be "header.size" and "header.next".
2314 * buffer.h (struct buffer): Likewise.
2315 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2316 * frame.h (struct frame): Likewise.
2317 * process.h (struct Lisp_Process): Likewise.
2318 * termhooks.h (struct terminal): Likewise.
2319 * window.c (struct save_window_data, struct saved_window): Likewise.
2320 * window.h (struct window): Likewise.
2321 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2322 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2323 * buffer.c (init_buffer_once): Likewise.
2324 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2325 special case.
2326 * process.c (Fformat_network_address): Use local var for size,
2327 for brevity.
2328
0df1eac5
PE
2329 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2330
847ab9d1 2331 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2332 * data.c (atof): Remove decl; no longer used or needed.
2333 (digit_to_number): Move to lread.c.
2334 (Fstring_to_number): Use new string_to_number function, to be
2335 consistent with how the Lisp reader treats infinities and NaNs.
2336 Do not assume that floating-point numbers represent EMACS_INT
2337 without losing information; this is not true on most 64-bit hosts.
2338 Avoid double-rounding errors, by insisting on integers when
2339 parsing non-base-10 numbers, as the documentation specifies.
2340 * lisp.h (string_to_number): New decl, replacing ...
2341 (isfloat_string): Remove.
bc0a5c13 2342 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2343 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2344 appears to have been a coding error. Similarly, do not accept
2345 strings like +-1e0 as floating point numbers. Do not report
2346 overflow for integer overflows unless the base is not 10 which
2347 means we have no simple and reliable way to continue.
2348 Break out the floating-point parsing into a new
2349 function string_to_number, so that Fstring_to_number parses
2350 floating point numbers consistently with the Lisp reader.
04f2d78b 2351 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2352 (E_CHAR, EXP_INT): Remove, replacing with ...
2353 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2354 (string_to_number): New function, replacing isfloat_string.
2355 This function checks for valid syntax and produces the resulting
2356 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2357 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2358 so that overflow for non-base-10 numbers is reported only when
2359 there's no portable and simple way to convert to floating point.
452f4150 2360
67769ffc
PE
2361 * textprop.c (set_text_properties_1): Rewrite for clarity,
2362 and to avoid GCC warning about integer overflow.
2363
c20db43f
PE
2364 * intervals.h (struct interval): Use EMACS_INT for members
2365 where EMACS_UINT might cause problems. See
2366 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2367 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2368 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2369 All uses changed.
37aa2f85
PE
2370 (offset_intervals): Tell GCC not to worry about length overflow
2371 when negating a negative length.
c20db43f 2372
2538aa2f
PE
2373 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2374 (overrun_check_free): Likewise.
2375
f2d3008d
PE
2376 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2377 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2378 word size.
2379
ec8df744
PE
2380 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2381 (gnutls_make_error): Rename local to avoid shadowing.
2382 (gnutls_emacs_global_deinit): ifdef out; not used.
2383 (Fgnutls_boot): Use const for pointer to readonly storage.
2384 Comment out unused local. Fix pointer signedness problems.
2385
640ee02d
PE
2386 * lread.c (openp): Don't stuff size_t into an 'int'.
2387 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2388 about possible signed overflow.
2389
6048fb2a
PE
2390 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2391 (GDK_KEY_g): Don't define if already defined.
2392 (xg_prepare_tooltip): Avoid pointer signedness problem.
2393 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2394
fa3c87e1
PE
2395 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2396 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2397
2172544b
PE
2398 * xfns.c (Fx_window_property): Simplify a bit,
2399 to make a bit faster and to avoid GCC 4.6.0 warning.
2400 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2401
9b821a21
PE
2402 * fns.c (internal_equal): Don't assume size_t fits in int.
2403
3c616cfa
PE
2404 * alloc.c (compact_small_strings): Tighten assertion a little.
2405
c2982e87
PE
2406 Replace pEd with more-general pI, and fix some printf arg casts.
2407 * lisp.h (pI): New macro, generalizing old pEd macro to other
2408 conversion specifiers. For example, use "...%"pI"d..." rather
2409 than "...%"pEd"...".
2410 (pEd): Remove. All uses replaced with similar uses of pI.
2411 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2412 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2413 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2414 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2415 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2416 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2417 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2418 64-bit hosts.
2419 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2420 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2421 * print.c (safe_debug_print, print_object): Likewise.
2422 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2423 to int.
6f04d126
PE
2424 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2425 avoiding the 0 flag, which is not portable.
c2982e87
PE
2426 * process.c (Fmake_network_process): Use pI to avoid cast.
2427 * region-cache.c (pp_cache): Likewise.
2428 * xdisp.c (decode_mode_spec): Likewise.
2429 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2430 behavior on 64-bit hosts with printf arg.
6f04d126 2431 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2432 (x_stop_queuing_selection_requests): Likewise.
2433 (x_get_window_property): Don't truncate byte count to an 'int'
2434 when tracing.
0b432f21 2435
5e073ec7
PE
2436 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2437 here, since it parses constructs like leading '-' and spaces,
2438 which are not wanted; and it overflows with large numbers.
2439 Instead, simply match F[0-9]+, which is what is wanted anyway.
2440
36372bf9
PE
2441 * alloc.c: Remove unportable assumptions about struct layout.
2442 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2443 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2444 (allocate_vectorlike, make_pure_vector): Use the new macros,
2445 plus offsetof, to remove unportable assumptions about struct layout.
2446 These assumptions hold on all porting targets that I know of, but
2447 they are not guaranteed, they're easy to remove, and removing them
2448 makes further changes easier.
2449
0b432f21
PE
2450 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2451 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2452 (string_overrun_cookie): Now const. Use initializers that
2453 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2454 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2455 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2456 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2457 multiple of sizeof (EMACS_INT); it need not be, if
2458 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2459 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2460
895009e1
JB
24612011-04-26 Juanma Barranquero <lekktu@gmail.com>
2462
2463 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2464
6a7a1b0b
TZ
24652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2466
2467 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2468 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2469 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2470
841a1577 24712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2472
2473 * lisp.h (Qdebug): List symbol.
895009e1 2474 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2475 * keyboard.c (debug-on-event): New variable.
2476 (handle_user_signal): Break into debugger when debug-on-event
2477 matches the current signal symbol.
2478
f2d3ba6f
DN
24792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2480
2481 * alloc.c (check_sblock, check_string_bytes)
2482 (check_string_free_list): Convert to standard C.
2483
42ce4c63
TZ
24842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2485
2486 * w32.c (emacs_gnutls_push): Fix typo.
2487
825cd63c
EZ
24882011-04-25 Eli Zaretskii <eliz@gnu.org>
2489
fb11d64d
EZ
2490 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2491 "cast to pointer from integer of different size".
2492
825cd63c
EZ
2493 Improve doprnt and its use in verror. (Bug#8545)
2494 * doprnt.c (doprnt): Document the set of format control sequences
2495 supported by the function. Use SAFE_ALLOCA instead of always
2496 using `alloca'.
2497
2498 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2499 is one byte too soon. Don't use xrealloc; instead xfree and
2500 xmalloc anew.
2501
e061a11b
TZ
25022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2503
2504 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2505 callbacks stage.
2506
2507 * gnutls.c: Renamed global_initialized to
2508 gnutls_global_initialized. Added internals for the
2509 :verify-hostname-error, :verify-error, and :verify-flags
2510 parameters of `gnutls-boot' and documented those parameters in the
2511 docstring. Start callback support.
2512 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2513 unless a fatal error occured. Call gnutls_alert_send_appropriate
2514 on error. Return error code.
2515 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2516 (emacs_gnutls_read): Likewise.
2517 (Fgnutls_boot): Return handshake error code.
2518 (emacs_gnutls_handle_error): New function.
2519 (wsaerror_to_errno): Likewise.
2520
2521 * w32.h (emacs_gnutls_pull): Add prototype.
2522 (emacs_gnutls_push): Likewise.
2523
2524 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2525 (emacs_gnutls_push): Likewise.
2526
25272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2528
2529 * process.c (wait_reading_process_output): Check if GnuTLS
2530 buffered some data internally if no FDs are set for TLS
2531 connections.
2532
2533 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2534 (LIBS): Link to USER_LIBS.
2535 ($(BLD)/gnutls.$(0)): New target.
2536
fa6996bc
EZ
25372011-04-24 Eli Zaretskii <eliz@gnu.org>
2538
eb35682e
EZ
2539 * xdisp.c (handle_single_display_spec): Rename the
2540 display_replaced_before_p argument into display_replaced_p, to
2541 make it consistent with the commentary. Fix typos in the
2542 commentary.
2543
e2ad650c
EZ
2544 * textprop.c (syms_of_textprop): Remove dead code.
2545 (copy_text_properties): Delete obsolete commentary about an
2546 interface that was deleted long ago. Fix typos in the description
2547 of arguments.
2548
1b2de274
EZ
2549 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2550 to changes in oldXMenu/XMenu.h from 2011-04-16.
2551 <menu_help_message, prev_menu_help_message>: Constify.
2552 (IT_menu_make_room): menu->help_text is now `const char **';
2553 adjust.
2554
2555 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2556 to changes in oldXMenu/XMenu.h from 2011-04-16.
2557 (struct XMenu): Declare `help_text' `const char **'.
2558
2559 * xfaces.c <Qunspecified>: Make extern again.
2560
2561 * syntax.c: Include sys/types.h before including regex.h, as
2562 required by Posix.
2563
762b15be
EZ
2564 * doc.c (get_doc_string): Improve the format passed to `error'.
2565
2566 * doprnt.c (doprnt): Improve commentary.
2567
2568 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2569
2570 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2571 them with etags.
2572
f1052e5d
EZ
2573 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2574 changes in globals.h immediately force recompilation.
762b15be
EZ
2575 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2576 $(CURDIR)/s/ms-w32.h.
2577 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2578
fa6996bc
EZ
2579 * character.c (Fchar_direction): Function deleted.
2580 (syms_of_character): Don't defsubr it.
2581 <char-direction-table>: Deleted.
2582
e6c3da20
EZ
25832011-04-23 Eli Zaretskii <eliz@gnu.org>
2584
2585 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2586 * doprnt.c: Include limits.h.
2587 (SIZE_MAX): New macro.
04f2d78b
CB
2588 (doprnt): Return a size_t value. 2nd arg is now size_t.
2589 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2590 Improve overflow protection. Support `l' modifier for integer
2591 conversions. Support %l conversion. Don't assume an EMACS_INT
2592 argument for integer conversions and for %c.
2593
2594 * lisp.h (doprnt): Restore prototype.
2595
2596 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2597 $(SRC)/character.h.
2598
2599 * Makefile.in (base_obj): Add back doprnt.o.
2600
2601 * deps.mk (doprnt.o): Add back prerequisites.
2602 (callint.o): Depend on character.h.
2603
2604 * eval.c (internal_lisp_condition_case): Include the handler
2605 representation in the error message.
2606 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2607 when breaking from the loop.
2608
2609 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2610
2611 * callint.c (Fcall_interactively): When displaying error message
2612 about invalid control letter, pass the character's codepoint, not
2613 a pointer to its multibyte form. Improve display of the character
2614 in octal and display also its hex code.
2615
2616 * character.c (char_string): Use %x to display the (unsigned)
2617 codepoint of an invalid character, to avoid displaying a bogus
2618 negative value.
2619
2620 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2621 `error', not SYMBOL_NAME itself.
2622
2623 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2624 character arguments to `error'.
2625
2626 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2627 to `error' in error message about FINAL_CHAR argument. Make sure
2628 FINAL_CHAR is a character, and use %c when it is passed as
2629 argument to `error'.
2630
4ffd0d6b 26312011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2632
2633 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2634
2635 * w32.c: Include <time.h>.
2636 (sys_localtime): New function.
2637
4ffd0d6b 26382011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2639
2640 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2641
4ffd0d6b 2642 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2643
4ffd0d6b 26442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2645
4ffd0d6b
GM
2646 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2647 zombies (Bug#8467).
aac0c6e3 2648
04c56954
EZ
26492011-04-19 Eli Zaretskii <eliz@gnu.org>
2650
2651 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2652 gl_state.e_property when gl_state.object is Qt.
2653
2654 * insdel.c (make_gap_larger): Remove limitation of buffer size
2655 to <= INT_MAX.
2656
16a43933
CY
26572011-04-18 Chong Yidong <cyd@stupidchicken.com>
2658
2659 * xdisp.c (lookup_glyphless_char_display)
2660 (produce_glyphless_glyph): Handle cons cell entry in
2661 glyphless-char-display.
2662 (Vglyphless_char_display): Document it.
2663
2664 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2665 glyphless-char-display.
2666
4581706e
CY
26672011-04-17 Chong Yidong <cyd@stupidchicken.com>
2668
2669 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2670
2671 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2672
2673 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2674 definition for no-X builds.
2675
4887c6e2 26762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2677
fd35b6f9
PE
2678 Static checks with GCC 4.6.0 and non-default toolkits.
2679
5c1ccb01
PE
2680 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2681
006c5daa
PE
2682 * process.c (keyboard_bit_set): Define only if SIGIO.
2683 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2684 (send_process): Repair possible setjmp clobbering.
2685
efc736d3
PE
2686 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2687
4e2fe2e6
PE
2688 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2689
f97334a2
PE
2690 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2691
4e75f29d
PE
2692 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2693 Define only if needed.
2694
90efadd1
PE
2695 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2696 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2697 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2698
3c647824
PE
2699 * dispextern.h (struct redisplay_interface): Rename param
2700 to avoid shadowing.
e264f262 2701 * termhooks.h (struct terminal): Likewise.
761383f4 2702 * xterm.c (xembed_send_message): Likewise.
3c647824 2703
b58c5c4a
PE
2704 * insdel.c (make_gap_smaller): Define only if
2705 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2706
cad59032
PE
2707 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2708 it.
2709
c339dc2e
PE
2710 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2711 so that we aren't warned about unused symbols.
2712
91a3e27b
PE
2713 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2714
399c71d3 2715 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2716
8ffc96f5
PE
2717 * xfns.c (x_real_positions): Mark locals as initialized.
2718
eef9bc79
PE
2719 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2720
098db9dd
PE
2721 * xterm.c: Fix problems found by static analysis with other toolkits.
2722 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2723 (x_dispatch_event): Declare static if USE_GTK, and
2724 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2725 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2726 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2727 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2728 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2729
eb18f6cc
PE
2730 * xmenu.c (menu_help_callback): Pointer type fixes.
2731 Use const pointers when pointing at readonly data. Avoid pointer
2732 signedness clashes.
2733 (FALSE): Remove unused macro.
2734 (update_frame_menubar): Remove unused decl.
2735
1fe72bf8
PE
2736 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2737
60d9e1db
PE
2738 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2739 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2740 (single_menu_item): Rename local to avoid shadowing.
2741
39261c26
PE
2742 * keyboard.c (make_lispy_event): Remove unused local var.
2743
018c5e19
PE
2744 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2745 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2746
63d2b86e
PE
2747 * bitmaps: Change bitmaps from unsigned char back to the X11
2748 compatible char. Avoid the old compiler warnings about
2749 out-of-range initializers by using, for example, '\xab' rather
2750 than 0xab.
2751
aefd87e1
PE
2752 * xgselect.c (xgselect_initialize): Check vs interface
2753 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2754
bf501fb9
PE
2755 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2756
e9829fdf
PE
2757 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2758 to read-only memory.
2759
1086c095
PE
2760 * fns.c (vector): Remove; this old hack is no longer needed.
2761
2baccd04 2762 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2763 Remove unused var.
dde42981 2764 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2765
72391843 2766 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2767
436c16df 2768 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2769 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2770 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2771
92bb796d 2772 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2773 (x_term_init): Remove local to avoid shadowing.
92bb796d 2774
764430a3 2775 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2776
2777 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2778 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2779
d1dfb56c
EZ
27802011-04-16 Eli Zaretskii <eliz@gnu.org>
2781
c4354cb4
EZ
2782 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2783
d1dfb56c
EZ
2784 Fix regex.c, syntax.c and friends for buffers > 2GB.
2785 * syntax.h (struct gl_state_s): Declare character position members
2786 EMACS_INT.
2787
2788 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2789
04f2d78b
CB
2790 * textprop.c (verify_interval_modification, interval_of):
2791 Declare arguments EMACS_INT.
d1dfb56c
EZ
2792
2793 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2794 EMACS_INT.
2795
2796 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2797
2798 * indent.c (Fvertical_motion): Local variable it_start is now
2799 EMACS_INT.
2800
2801 * regex.c (re_match, re_match_2, re_match_2_internal)
2802 (bcmp_translate, regcomp, regexec, print_double_string)
2803 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2804 (re_compile_pattern, re_exec): Declare arguments and local
2805 variables `size_t' and `ssize_t' and return values `regoff_t', as
2806 appropriate.
2807 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2808 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2809 <compile_stack_type>: `size' and `avail' are now `size_t'.
2810
2811 * regex.h <regoff_t>: Use ssize_t, not int.
2812 (re_search, re_search_2, re_match, re_match_2): Arguments that
2813 specify buffer/string position and length are now ssize_t and
2814 size_t. Return type is regoff_t.
2815
613052cd
BK
28162011-04-16 Ben Key <bkey76@gmail.com>
2817
2818 * nsfont.m: Fixed bugs in ns_get_family and
2819 ns_descriptor_to_entity that were caused by using free to
2820 deallocate memory blocks that were allocated by xmalloc (via
2821 xstrdup). This caused Emacs to crash when compiled with
2822 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2823 --enable-checking=xmallocoverrun). xfree is now used to
2824 deallocate these memory blocks.
2825
4170f62f 28262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2827
71b41406
PE
2828 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2829
9587a89d
PE
2830 emacs_write: Accept and return EMACS_INT for sizes.
2831 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2832 et seq.
2833 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2834 Accept and return EMACS_INT.
2835 (emacs_gnutls_write): Return the number of bytes written on
2836 partial writes.
2837 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2838 (emacs_read, emacs_write): Remove check for negative size, as the
2839 Emacs source code has been audited now.
9587a89d
PE
2840 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2841 (emacs_read, emacs_write): Use it.
273a5f82
PE
2842 * process.c (send_process): Adjust to the new signatures of
2843 emacs_write and emacs_gnutls_write. Do not attempt to store
2844 a byte offset into an 'int'; it might overflow.
9587a89d 2845 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2846
3e047f51
PE
2847 * sound.c: Don't assume sizes fit in 'int'.
2848 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2849 Return EMACS_INT, not int.
3e047f51 2850 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2851 Accept EMACS_INT, not int.
2852 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2853 record read return values.
2854
cc39a9db
BK
28552011-04-15 Ben Key <bkey76@gmail.com>
2856
c9d0ec6d
JB
2857 * keyboard.c (Qundefined): Don't declare static since it is used
2858 in nsfns.m.
2859 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2860 static since they are used in nsfont.m.
cc39a9db 2861
6c60eb9f
SM
28622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2863
2864 * process.c (Qprocessp): Don't declare static.
2865 * lisp.h (Qprocessp): Declare again.
2866
7990b61a
JB
28672011-04-15 Juanma Barranquero <lekktu@gmail.com>
2868
2869 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2870
5d4cb038
PE
28712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2872
8bd7b830 2873 Improve C-level modularity by making more things 'static'.
cd64ea1d 2874
e3b27b31
PE
2875 Don't publish debugger-only interfaces to other modules.
2876 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2877 (verify_bytepos, count_markers): Move decls to the only modules
2878 that need them.
2879 * region-cache.h (pp_cache): Likewise.
2880 * window.h (check_all_windows): Likewise.
2881 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2882
5d4cb038
PE
2883 * sysdep.c (croak): Now static, if
2884 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2885 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2886
2887 * alloc.c (refill_memory_reserve): Now static if
2888 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2889 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2890
e87b6180
PE
2891 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2892 Define only if USE_LUCID.
2893
ac64929e
PE
2894 * xrdb.c (x_customization_string, x_rm_string): Now static.
2895
6f37259d
PE
2896 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2897 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2898
1683e3ab
PE
2899 * xdisp.c (draw_row_with_mouse_face): Now static.
2900 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2901
de9c2632
PE
2902 * window.h (check_all_windows): Mark externally visible.
2903
2b96acb7
PE
2904 * window.c (window_deletion_count): Now static.
2905
2906 * undo.c: Make symbols static if they're not exported.
2907 (last_undo_buffer, last_boundary_position, pending_boundary):
2908 Now static.
2909
50436f33
PE
2910 * textprop.c (interval_insert_behind_hooks): Now static.
2911 (interval_insert_in_front_hooks): Likewise.
2912
64520e5c
PE
2913 * term.c: Make symbols static if they're not exported.
2914 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2915 (max_frame_lines, tty_set_terminal_modes):
2916 (tty_reset_terminal_modes, tty_turn_off_highlight):
2917 (get_tty_terminal): Now static.
2918 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2919 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2920 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2921 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2922 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2923
1fa53021
PE
2924 * sysdep.c: Make symbols static if they're not exported.
2925 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2926 Now static.
2927 (sigprocmask_set, full_mask): Remove; unused.
2928 (wait_debugging): Mark as visible.
2929 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2930 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2931
d4b43b22
PE
2932 * syntax.c (syntax_temp): Define only if !__GNUC__.
2933
b7c513d0
PE
2934 * sound.c (current_sound_device, current_sound): Now static.
2935
989b29ad
PE
2936 * search.c (searchbufs, searchbuf_head): Now static.
2937
13a55a78
PE
2938 * scroll.c (scroll_cost): Remove; unused.
2939 * dispextern.h (scroll_cost): Remove decl.
2940
de68a1fc
PE
2941 * region-cache.h (pp_cache): Mark as externally visible.
2942
40ccffa6
PE
2943 * process.c: Make symbols static if they're not exported.
2944 (process_tick, update_tick, create_process, chan_process):
2945 (Vprocess_alist, proc_buffered_char, datagram_access):
2946 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2947 (deactivate_process): Mark defn as static, as well as decl.
2948 * lisp.h (create_process): Remove decl.
2949 * process.h (chan_process, Vprocess_alist): Remove decls.
2950
ad64fc97
PE
2951 * print.c: Make symbols static if they're not exported.
2952 (print_depth, new_backquote_output, being_printed, print_buffer):
2953 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2954 (print_interval, print_number_index, initial_stderr_stream):
2955 Now static.
2956 * lisp.h (Fprinc): Remove decl.
2957 (debug_output_compilation_hack): Mark as externally visible.
2958
adddb265
PE
2959 * sysdep.c (croak): Move decl from here to syssignal.h.
2960 * syssignal.h (croak): Put it here, so the API can be checked when
2961 'croak' is called from dissociate_if_controlling_tty.
2962
1717ede2
PE
2963 * minibuf.c: Make symbols static if they're not exported.
2964 (minibuf_save_list, choose_minibuf_frame): Now static.
2965 * lisp.h (choose_minibuf_frame): Remove decl.
2966
fa5fb2bc
PE
2967 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2968
1e3890d1
PE
2969 * lread.c: Make symbols static if they're not exported.
2970 (read_objects, initial_obarray, oblookup_last_bucket_number):
2971 Now static.
2972 (make_symbol): Remove; unused.
2973 * lisp.h (initial_obarray, make_symbol): Remove decls.
2974
8a1414fa
PE
2975 * keyboard.c: Make symbols static if they're not exported.
2976 (single_kboard, recent_keys_index, total_keys, recent_keys):
2977 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2978 (this_single_command_key_start, echoing, last_auto_save):
2979 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2980 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2981 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2982 (Vlispy_mouse_stem, double_click_count):
2983 Now static.
2984 (force_auto_save_soon): Define only if SIGDANGER.
2985 (ignore_mouse_drag_p): Now static if
2986 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2987 (print_help): Remove; unused.
2988 (stop_character, last_timer_event): Mark as externally visible.
2989 * keyboard.h (ignore_mouse_drag_p): Declare only if
2990 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2991 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2992 * lisp.h (echoing): Remove decl.
2993 (force_auto_save_soon): Declare only if SIGDANGER.
2994 * xdisp.c (redisplay_window): Simplify code, to make it more
2995 obvious that ignore_mouse_drag_p is not accessed if !defined
2996 USE_GTK && !defined HAVE_NS.
2997
93ea6e8f
PE
2998 * intervals.c: Make symbols static if they're not exported.
2999 (merge_properties_sticky, merge_interval_right, delete_interval):
3000 Now static.
3001 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3002
77382fcc
PE
3003 * insdel.c: Make symbols static if they're not exported.
3004 However, leave prepare_to_modify_buffer alone. It's never
3005 called from outside this function, but that appears to be a bug.
3006 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3007 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3008 (adjust_after_replace_noundo): Remove; unused.
3009 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3010 (signal_before_change): Remove decls.
77382fcc 3011
9306c32e
PE
3012 * indent.c (val_compute_motion, val_vmotion): Now static.
3013
cd44d2eb
PE
3014 * image.c: Make symbols static if they're not exported.
3015 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3016 if USE_GTK.
3017 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3018 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3019
ad9a7a06
PE
3020 * fringe.c (standard_bitmaps): Now static.
3021 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3022
81626931
PE
3023 * frame.c: Make symbols static if they're not exported.
3024 (x_report_frame_params, make_terminal_frame): Now static.
3025 (get_frame_param): Now static, unless HAVE_NS.
3026 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3027 (x_get_resource_string): Remove; not used.
3028 * frame.h (make_terminal_frame, x_report_frame_params):
3029 (x_get_resource_string); Remove decls.
3030 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3031 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3032
239f9db9
PE
3033 * font.c, fontset.c: Make symbols static if they're not exported.
3034 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3035 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3036 * font.c (font_close_object): Now static.
3037 * font.h (font_close_object): Remove.
3038 * fontset.c (FONTSET_OBJLIST): Remove.
3039 (free_realized_fontset) #if-0 the body, which does nothing.
3040 (face_suitable_for_char_p): #if-0, as it's never called.
3041 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3042 * xfaces.c (face_at_string_position):
3043 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3044 since 0 is always ASCII.
3045
dfcf3579
PE
3046 * fns.c (weak_hash_tables): Now static.
3047
5045092b
PE
3048 * fileio.c: Make symbols static if they're not exported.
3049 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3050 (Vwrite_region_annotation_buffers): Now static.
3051
57a96f5c
PE
3052 * eval.c: Make symbols static if they're not exported.
3053 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3054 * lisp.h (backtrace_list): Remove decl.
3055
35f08c38
PE
3056 * emacs.c: Make symbols static if they're not exported.
3057 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3058 (fatal_error_code, fatal_error_signal_hook, standard_args):
3059 Now static.
3060 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3061 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3062 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3063 * lisp.h (fatal_error_signal_hook): Remove decl.
3064 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3065
f44bd759
PE
3066 * editfns.c: Move a (normally-unused) function to its only use.
3067 * editfns.c, lisp.h (get_operating_system_release): Remove.
3068 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3069 worth the hassle of breaking this out.
3070
b532497d
PE
3071 * xterm.c: Make symbols static if they're not exported.
3072 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3073 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3074 (x_destroy_window, x_delete_display):
3075 Now static.
3076 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3077 (x_mouse_leave): Remove; unused.
3078 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3079 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3080 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3081 Remove decls.
3082 (x_mouse_leave): Declare only if WINDOWSNT.
3083 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3084 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3085 USE_X_TOOLKIT.
3086
1675728f
PE
3087 * ftxfont.c: Make symbols static if they're not exported.
3088 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3089 HAVE_FREETYPE.
3090 * font.h (ftxfont_driver): Likewise.
3091
e4cebfca
PE
3092 * xfns.c: Make symbols static if they're not exported.
3093 (x_last_font_name, x_display_info_for_name):
3094 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3095 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3096 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3097 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3098 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3099 (last_show_tip_args): Now static.
3100 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3101 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3102 (x_screen_planes): Remove; unused.
3103 * dispextern.h (x_screen_planes): Remove decl.
3104
5bf46f05
PE
3105 * dispnew.c: Make symbols static if they're not exported.
3106 * dispextern.h (redraw_garbaged_frames, scrolling):
3107 (increment_row_positions): Remove.
3108 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3109 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3110 Now static.
3111 (redraw_garbaged_frames): Remove; unused.
3112
435f4c28
PE
3113 * xfaces.c: Make symbols static if they're not exported.
3114 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3115 Remove decls.
3116 * xterm.h (defined_color): Remove decls.
3117 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3118 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3119 (menu_face_changed_default, defined_color, free_realized_face):
3120 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3121 (ascii_face_of_lisp_face): Remove; unused.
3122
8524aef3
PE
3123 * xdisp.c: Make symbols static if they're not exported.
3124 * dispextern.h (scratch_glyph_row, window_box_edges):
3125 (glyph_to_pixel_coords, set_cursor_from_row):
3126 (get_next_display_element, set_iterator_to_next):
3127 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3128 (show_mouse_face): Remove decls
3129 * frame.h (message_buf_print): Likewise.
3130 * lisp.h (pop_message, set_message, check_point_in_composition):
3131 Likewise.
3132 * xterm.h (set_vertical_scroll_bar): Likewise.
3133 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3134 (message_buf_print, scratch_glyph_row, displayed_buffer):
3135 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3136 (get_next_display_element, show_mouse_face, window_box_edges):
3137 (frame_to_window_pixel_xy, check_point_in_composition):
3138 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3139 (glyph_to_pixel_coords): Remove; unused.
3140
16390cd2
PE
3141 * dired.c (file_name_completion): Now static.
3142
3143 * dbusbind.c (xd_in_read_queued_messages): Now static.
3144
a25f4dfa
PE
3145 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3146 * data.c (circular_list_error): Remove.
3147
14a9c8df
PE
3148 * commands.h (last_point_position, last_point_position_buffer):
3149 (last_point_position_window): Remove decls.
3150 * keyboard.c: Make these variables static.
3151
04f2d78b
CB
3152 * coding.h (coding, code_convert_region, encode_coding_gap):
3153 Remove decls.
74ab6df5
PE
3154 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3155 (iso_code_class, detect_coding, code_convert_region): Now static.
3156 (encode_coding_gap): Remove; unused.
3157
38dfbee1
PE
3158 * chartab.c (chartab_chars, chartab_bits): Now static.
3159
a2cb4e63
PE
3160 * charset.h (charset_iso_8859_1): Remove decl.
3161 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3162 Now static.
3163
127198fd
PE
3164 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3165 * ccl.c (Vccl_program_table): Now static.
3166 (check_ccl_update): Remove; unused.
3167
d85b608f
PE
3168 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3169 * category.h: ... from here.
3170 * category.c (check_category_table, set_category_set): Now static.
3171
31cd66f3
PE
3172 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3173 * lisp.h: Remove these decls.
3174
c358e587
PE
3175 * buffer.c (buffer_count): Remove unused var.
3176
e78aecca
PE
3177 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3178 so that it's not optimized away.
3179 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3180 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3181 exported only to the debugger.
3182
e192d7d3 3183 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3184 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3185
92470028
PE
3186 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3187 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3188 was inaccessible from Lisp.
3189 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3190 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3191
244ed907
PE
3192 alloc.c: Import and export fewer symbols, and remove unused items.
3193 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3194 is defined.
3195 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3196 it's not optimized away by whole-program optimization.
3197 (message_enable_multibyte, free_misc): Remove.
3198 (catchlist, handlerlist, mark_backtrace):
3199 Declare only if BYTE_MARK_STACK.
3200 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3201 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3202 (message_enable_multibyte): Remove decl.
3203 (free_misc, interval_free_list, float_block, float_block_index):
3204 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3205 (cons_free_list, last_marked_index):
3206 Now static.
3207 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3208 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3209 (mark_backtrace): Define only if BYTE_MARK_STACK.
3210 * xdisp.c (message_enable_multibyte): Now static.
3211
61c2b50e 3212 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3213 This makes it easier for human readers (and static analyzers)
3214 to see whether these variables are used from other modules.
3215 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3216 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3217 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3218 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3219 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3220 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3221 * xmenu.c, xselect.c:
3222 Declare Q* vars static if they are not used in other modules.
3223 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3224 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3225 Remove decls of unexported vars.
3226 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3227
95c82688
PE
3228 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3229
16a97296
PE
3230 Make Emacs functions such as Fatom 'static' by default.
3231 This makes it easier for human readers (and static analyzers)
3232 to see whether these functions can be called from other modules.
3233 DEFUN now defines a static function. To make the function external
3234 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3235 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3236 (Finit_image_library):
16a97296
PE
3237 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3238 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3239 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3240 Remove decls, since these functions are now static.
3241 (Funintern, Fget_internal_run_time): New decls, since these functions
3242 were already external.
95c82688 3243
16a97296
PE
3244 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3245 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3246 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3247 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3248 * keyboard.c, keymap.c, lread.c:
3249 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3250 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3251 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3252 Mark functions with DEFUE instead of DEFUN,
3253 if they are used in other modules.
3254 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3255 decls for now-static functions.
3256 * buffer.h (Fdelete_overlay): Remove decl.
3257 * callproc.c (Fgetenv_internal): Mark as internal.
3258 * composite.c (Fremove_list_of_text_properties): Remove decl.
3259 (Fcomposition_get_gstring): New forward static decl.
3260 * composite.h (Fcomposite_get_gstring): Remove decl.
3261 * dired.c (Ffile_attributes): New forward static decl.
3262 * doc.c (Fdocumntation_property): New forward static decl.
3263 * eval.c (Ffetch_bytecode): New forward static decl.
3264 (Funintern): Remove extern decl; now in .h file where it belongs.
3265 * fileio.c (Fmake_symbolic_link): New forward static decl.
3266 * image.c (Finit_image_library): New forward static decl.
3267 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3268 * intervals.h (Fprevious_property_change):
3269 (Fremove_list_of_text_properties): Remove decls.
3270 * keyboard.c (Fthis_command_keys): Remove decl.
3271 (Fcommand_execute): New forward static decl.
3272 * keymap.c (Flookup_key): New forward static decl.
3273 (Fcopy_keymap): Now static.
3274 * keymap.h (Flookup_key): Remove decl.
3275 * process.c (Fget_process): New forward static decl.
3276 (Fprocess_datagram_address): Mark as internal.
3277 * syntax.c (Fsyntax_table_p): New forward static decl.
3278 (skip_chars): Remove duplicate decl.
3279 * textprop.c (Fprevious_property_change): New forward static decl.
3280 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3281 Now internal.
3282 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3283 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3284
785bbd42
PE
3285 * editfns.c (Fformat): Remove unreachable code.
3286
8b913b57
AS
32872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3288
3289 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3290 change. (Bug#8496)
3291
a6744a35
EZ
32922011-04-13 Eli Zaretskii <eliz@gnu.org>
3293
3294 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3295 when at ZV. (Bug#8487)
3296
e7974947
AS
32972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3298
baad03f0
AS
3299 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3300 (Bug#8437)
3301 * keyboard.c (parse_tool_bar_item): Likewise.
3302 * sound.c (sound_cleanup, alsa_close): Likewise.
3303 * termcap.c (tgetent): Likewise.
3304 * xfns.c (x_default_font_parameter): Likewise.
3305 * xsettings.c (read_and_apply_settings): Likewise.
3306
e7974947
AS
3307 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3308 (overrun_check_free): Protoize.
3309
28272684
PE
33102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3313 since callers should never pass a negative size.
3314 Change the signature to match that of plain 'read' and 'write'; see
3315 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3316 * lisp.h: Update prototypes of emacs_write and emacs_read.
3317
11997c76
EZ
33182011-04-11 Eli Zaretskii <eliz@gnu.org>
3319
3320 * xdisp.c (redisplay_window): Don't try to determine the character
3321 position of the scroll margin if the window start point w->startp
e896f03c 3322 is outside the buffer's accessible region. (Bug#8468)
11997c76 3323
8a2cbd72
EZ
33242011-04-10 Eli Zaretskii <eliz@gnu.org>
3325
3326 Fix write-region and its subroutines for buffers > 2GB.
3327 * fileio.c (a_write, e_write): Modify declaration of arguments and
3328 local variables to support buffers larger than 2GB.
3329 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3330
3331 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3332 argument, local variables, and return value.
3333
3334 * lisp.h: Update prototypes of emacs_write and emacs_read.
3335
3336 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3337
4073e537 33382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3339
1ebfdcb6
PE
3340 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3341
b2ded58d
PE
3342 Fix more problems found by GCC 4.6.0's static checks.
3343
7d66342c
PE
3344 * xdisp.c (vmessage): Use a better test for character truncation.
3345
bbf47d44
PE
3346 * charset.c (load_charset_map): <, not <=, for optimization,
3347 and to avoid potential problems with integer overflow.
9248994d 3348 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3349 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3350 * editfns.c (Fformat): Likewise.
1e69125e 3351 * syntax.c (skip_chars): Likewise.
3befa583 3352
e3019616
PE
3353 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3354 This also lets GCC 4.6.0 generate slightly better loop code.
3355
becfa255
PE
3356 * callint.c (Fcall_interactively): <, not <=, for optimization.
3357 (Fcall_interactively): Count the number of arguments produced,
3358 not the number of arguments given. This is simpler and lets GCC
3359 4.6.0 generate slightly better code.
3360
dae0cd48
PE
3361 * ftfont.c: Distingish more carefully between FcChar8 and char.
3362 The previous code passed unsigned char * to a functions like
3363 strlen and xstrcasecmp that expect char *, which does not
3364 conform to the C standard.
3365 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3366 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3367 char * when the C standard requires it.
3368
76032d70
PE
3369 * keyboard.c (read_char): Remove unused var.
3370
eb3f1cc8
PE
3371 * eval.c: Port to Windows vsnprintf (Bug#8435).
3372 Include <limits.h>.
3373 (SIZE_MAX): Define if the headers do not.
3374 (verror): Do not give up if vsnprintf returns a negative count.
3375 Instead, grow the buffer. This ports to Windows vsnprintf, which
3376 does not conform to C99. Problem reported by Eli Zaretskii.
3377 Also, simplify the allocation scheme, by avoiding the need for
3378 calling realloc, and removing the ALLOCATED variable.
3379
70476b54
PE
3380 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3381
12020a9e
PE
3382 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3383 But keep the doprint source code for now, as we might revamp it
3384 and use it again (Bug#8435).
ea6c7ae6
PE
3385 * lisp.h (doprnt): Remove.
3386 * Makefile.in (base_obj): Remove doprnt.o.
3387 * deps.mk (doprnt.o): Remove.
3388
5fdb398c
PE
3389 error: Print 32- and 64-bit integers portably (Bug#8435).
3390 Without this change, on typical 64-bit hosts error ("...%d...", N)
3391 was used to print both 32- and 64-bit integers N, which relied on
3392 undefined behavior.
3393 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3394 New macro.
3395 * lisp.h (error, verror): Mark as printf-like functions.
3396 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3397 Report overflow in size calculations when allocating printf buffer.
3398 Do not truncate output string at its first null byte.
3399 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3400 Truncate the output at a character boundary, since vsnprintf does not
3401 do that.
3402 * charset.c (check_iso_charset_parameter): Convert internal
3403 character to string before calling 'error', since %c now has the
3404 printf meaning.
3405 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3406 overflow when computing char to be passed to 'error'. Do not
3407 pass Lisp_Object to 'error'; pass the integer instead.
3408 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3409 formatted with plain %d.
3410
b189fa66
PE
3411 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3412
bff87ef0
PE
3413 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3414
7e2cac20
PE
3415 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3416
ce4d90b5
PE
3417 * xterm.c (x_catch_errors): Remove duplicate declaration.
3418
266c9547
PE
3419 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3420
79c49ad2
PE
3421 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3422
368f4090
JM
34232011-04-10 Jim Meyering <meyering@redhat.com>
3424
3425 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3426 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3427 return ssize_t not "int", and use size_t as the buffer length.
3428 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3429 * gnutls.h: Update declarations.
3430 * process.c (read_process_output): Use ssize_t, to match.
3431 (send_process): Likewise.
3432
a32d4040
CY
34332011-04-09 Chong Yidong <cyd@stupidchicken.com>
3434
3435 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3436
8546720e 34372011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3438
04f2d78b
CB
3439 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3440 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3441
8546720e
GM
3442 * xterm.c (handle_one_xevent):
3443 * xmenu.c (create_and_show_popup_menu):
3444 * xselect.c (x_decline_selection_request)
3445 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3446
0a2f5c1a 34472011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3448
3449 Fix some uses of `int' instead of EMACS_INT.
3450 * search.c (string_match_1, fast_string_match)
3451 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3452 (scan_buffer, find_next_newline_no_quit)
3453 (find_before_next_newline, search_command, Freplace_match)
3454 (Fmatch_data): Make some `int' variables be EMACS_INT.
3455
3456 * xdisp.c (display_count_lines): 3rd argument and return value now
3457 EMACS_INT. All callers changed.
3458 (pint2hrstr): Last argument is now EMACS_INT.
3459
3460 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3461 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3462 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3463 (decode_coding_utf_16, decode_coding_emacs_mule)
3464 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3465 (decode_coding_ccl, decode_coding_charset)
3466 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3467 (decode_coding_iso_2022, decode_coding_emacs_mule)
3468 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3469 <char_offset, last_offset>: Declare EMACS_INT.
3470 (encode_coding_utf_8, encode_coding_utf_16)
3471 (encode_coding_emacs_mule, encode_invocation_designation)
3472 (encode_designation_at_bol, encode_coding_iso_2022)
3473 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3474 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3475 Declare EMACS_INT.
3476 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3477 (encode_invocation_designation): Last argument P_NCHARS is now
3478 EMACS_INT.
3479 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3480 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3481
3482 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3483 All users changed.
3484
3485 * ccl.c (Fccl_execute_on_string): Declare some variables
3486 EMACS_INT.
3487
8546720e 34882011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3489
3490 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3491
4e19a977
CS
34922011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3493
3494 * process.c (Fformat_network_address): Doc fix.
3495
87302331
R
34962011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3497
3498 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3499
cbb59342
CY
35002011-04-08 Chong Yidong <cyd@stupidchicken.com>
3501
3502 * keyboard.c (read_char): Call Lisp function help-form-show,
3503 instead of using internal_with_output_to_temp_buffer.
3504 (Qhelp_form_show): New var.
e0d38eeb 3505 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3506
3507 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3508
3509 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3510
e67a13ab
CY
35112011-04-06 Chong Yidong <cyd@stupidchicken.com>
3512
04f2d78b
CB
3513 * process.c (Flist_processes): Remove to Lisp.
3514 (list_processes_1): Delete.
e67a13ab 3515
973f782d
EZ
35162011-04-06 Eli Zaretskii <eliz@gnu.org>
3517
7c106b1e
EZ
3518 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3519
973f782d
EZ
3520 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3521
41cf7d1a 35222011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3523
ca23cc88
PE
3524 Fix more problems found by GCC 4.6.0's static checks.
3525
f390e2d5
PE
3526 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3527
42eea0d0
PE
3528 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3529
b69769da 3530 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3531
f9541e84
PE
3532 * xdisp.c (vmessage): Mark as a printf-like function.
3533
13841b55
PE
3534 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3535
c136c10f
PE
3536 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3537
5e2d4a30
PE
3538 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3539 printf-like functions.
3540 (tiff_load): Add casts to remove these marks before passing them
3541 to system-supplied API.
3542
583f48b9
PE
3543 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3544
b25d760e
PE
3545 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3546 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3547 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3548 directly, rather than having caller test rule sign. This avoids
3549 some unnecessary tests.
3550 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3551 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3552 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3553
bc7b6697 3554 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3555 (xfont_open): Avoid unnecessary tests.
bc7b6697 3556
27ccc379
PE
3557 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3558
dcd5c89a
PE
3559 * composite.h, composite.c (composition_gstring_put_cache):
3560 Use EMACS_INT, not int, for length.
3561
b13a45c6
PE
3562 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3563 breaking out part of COMPOSITION_DECODE_RULE.
3564 (COMPOSITION_DECODE_RULE): Use it.
3565 * composite.c (get_composition_id): Remove unused local vars,
3566 by using the new macro.
3567
1e792e4d
PE
3568 * textprop.c (set_text_properties_1): Change while to do-while,
3569 since the condition is always true at first.
3570
dc6c6455 3571 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3572 (interval_deletion_adjustment): Return unsigned value.
3573 All uses changed.
dc6c6455 3574
aba7731a
PE
3575 * process.c (list_processes_1, create_pty, read_process_output):
3576 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3577 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3578 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3579 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3580 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3581
fdfc4bf3
PE
3582 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3583
fca8fe46 3584 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3585 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3586
06a0259a 3587 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3588 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3589 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3590
e7b9e80f
PE
3591 * print.c (print_error_message): Avoid int overflow.
3592
56201685
PE
3593 * font.c (font_list_entities): Redo for clarity,
3594 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3595
78834453 3596 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3597 (font_score): Avoid potential overflow in diff calculation.
78834453 3598
0bc0b309 3599 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3600 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3601
e610eaca
PE
3602 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3603
b895abce
PE
3604 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3605 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3606 can always succeed if overflow has undefined behavior.
3607
1f1d9321 3608 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3609 (wordify): Omit three unnecessary tests.
1f1d9321 3610
c59478bc
PE
3611 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3612 All callers changed. This avoids the need for an unused var.
3613
79b73827
PE
3614 * casefiddle.c (casify_region): Remove var that is set but not used.
3615
a4db5dfe
PE
3616 * dired.c (file_name_completion): Remove var that is set but not used.
3617
43aae36e
PE
3618 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3619
2a47c44d 3620 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3621 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3622
a37c69bf
PE
3623 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3624 Check for integer overflow on size calculations.
3625
328ab8e7
PE
3626 * buffer.c (Fprevious_overlay_change): Remove var that is set
3627 but not used.
3628
e5a2a5cb
PE
3629 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3630 Remove vars that are set but not used.
8d84a6eb 3631 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3632 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3633
a60e5f68
PE
3634 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3635
f661cb61 3636 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3637 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3638
f0397f5a
PE
3639 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3640 that are set but not used.
3641
8664db06 3642 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3643 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3644
6abdaa4a
PE
3645 * xselect.c (x_get_local_selection, x_handle_property_notify):
3646 Remove vars that are set but not used.
3647
0ce7538d 3648 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3649 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3650
9ae848fc
PE
3651 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3652 Remove var that is set but not used.
0b918413
PE
3653 (scroll_bar_windows_size): Now size_t, not int.
3654 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3655 Check for overflow.
9ae848fc 3656
a5a62657
PE
3657 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3658 (map_tty_color) [!defined MSDOS]: Likewise.
3659
5c5cdd39
PE
3660 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3661
66ebf983
PE
3662 * coding.c: Remove vars that are set but not used.
3663 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3664 All callers changed.
3665 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3666 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3667 (decode_coding_charset): Remove vars that are set but not used.
3668
1be4d761
PE
3669 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3670 that is set but not used.
3671
47553fa8
PE
3672 * print.c (print_object): Remove var that is set but not used.
3673
1f7196bf 3674 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3675 The gnulib version avoids calling malloc in the usual case,
3676 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3677 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3678 * filelock.c (current_lock_owner): Likewise.
3679 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3680 * sysdep.c: Include allocator.h, careadlinkat.h.
3681 (emacs_no_realloc_allocator): New static constant.
3682 (emacs_readlink): New function.
fdb61804
PE
3683 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3684 ../lib/careadlinkat.h.
d1fdcab7 3685
f84c17c7
SM
36862011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3687
3688 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3689 first non-nil return value).
3690
ef3862ad
JD
36912011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3692
3693 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3694 if not defined (Bug#8403).
3695
376a7006
JB
36962011-04-02 Juanma Barranquero <lekktu@gmail.com>
3697
3698 * xdisp.c (display_count_lines): Remove parameter `start',
3699 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3700 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3701 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3702 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3703 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3704 and thereabouts. All callers changed.
3705 (get_per_char_metric): Remove parameter `f', unused since
3706 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3707
6ca3801d
JM
37082011-04-02 Jim Meyering <meyering@redhat.com>
3709
3710 do not dereference NULL upon failed strdup
3711 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3712 (ns_get_family): Likewise.
3713
d8e2b5ba
JB
37142011-04-02 Juanma Barranquero <lekktu@gmail.com>
3715
3716 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3717
8c74fcbd
JD
37182011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3719
3720 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3721 later (Bug#8403).
3722
7200d79c
SM
37232011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3724
03408648 3725 Add lexical binding.
7200d79c 3726
03408648
SM
3727 * window.c (Ftemp_output_buffer_show): New fun.
3728 (Fsave_window_excursion):
3729 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3730
3731 * lread.c (lisp_file_lexically_bound_p): New function.
3732 (Fload): Bind Qlexical_binding.
3733 (readevalloop): Remove `evalfun' arg.
3734 Bind Qinternal_interpreter_environment.
3735 (Feval_buffer): Bind Qlexical_binding.
3736 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3737 Mark as dynamic.
3738 (syms_of_lread): Declare `lexical-binding'.
3739
3740 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3741
3742 * keyboard.c (eval_dyn): New fun.
3743 (menu_item_eval_property): Use it.
ca105506
SM
3744
3745 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3746
03408648
SM
3747 * fns.c (concat, mapcar1): Accept byte-code-functions.
3748
3749 * eval.c (Fsetq): Handle lexical vars.
3750 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3751 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3752 (FletX, Flet): Obey lexical binding.
3753 (Fcommandp): Handle closures.
3754 (Feval): New `lexical' arg.
3755 (eval_sub): New function extracted from Feval. Use it almost
3756 everywhere where Feval was used. Look up vars in lexical env.
3757 Handle closures.
3758 (Ffunctionp): Move from subr.el.
3759 (Ffuncall): Handle closures.
3760 (apply_lambda): Remove `eval_flags'.
3761 (funcall_lambda): Handle closures and new byte-code-functions.
3762 (Fspecial_variable_p): New function.
3763 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3764 but without exporting it to Lisp.
23aba0ea 3765
23aba0ea 3766 * doc.c (Fdocumentation, store_function_docstring):
03408648 3767 * data.c (Finteractive_form): Handle closures.
23aba0ea 3768
03408648
SM
3769 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3770 interactive spec.
ba83908c 3771
04f2d78b
CB
3772 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3773 New byte-codes.
03408648
SM
3774 (exec_byte_code): New function extracted from Fbyte_code to handle new
3775 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3776
03408648 3777 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3778
03408648 3779 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3780
e2abce01
JB
37812011-03-31 Juanma Barranquero <lekktu@gmail.com>
3782
3783 * xdisp.c (redisplay_internal): Fix prototype.
3784
63696a73 37852011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3786
63696a73 3787 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3788 (try_scrolling): Use it when setting scroll_limit.
3789 Limit scrolling to 100 screen lines.
63696a73
EZ
3790 (redisplay_window): Even when falling back on "recentering",
3791 position point in the window according to scroll-conservatively,
3792 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3793
3794 (try_scrolling): When point is above the window, allow searching
3795 as far as scroll_max, or one screenful, to compute vertical
3796 distance from PT to the scroll margin position. This prevents
3797 try_scrolling from unnecessarily failing when
3798 scroll-conservatively is set to a value slightly larger than the
3799 window height. Clean up the case of PT below the margin at bottom
3800 of window: scroll_max can no longer be INT_MAX. When aggressive
3801 scrolling is in use, don't let point enter the opposite scroll
3802 margin as result of the scroll.
3803 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3804 threshold of 100 lines for never-recentering scrolling.
3805
e4cc2dfc
JB
38062011-03-31 Juanma Barranquero <lekktu@gmail.com>
3807
3808 * dispextern.h (move_it_by_lines):
3809 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3810 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3811 (message_log_check_duplicate): Remove parameters `prev_bol' and
3812 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3813 (redisplay_internal): Remove parameter `preserve_echo_area',
3814 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3815
3816 * indent.c (Fvertical_motion):
3817 * window.c (window_scroll_pixel_based, Frecenter):
3818 Don't pass `need_y_p' to `move_it_by_lines'.
3819
1c470562
SM
38202011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3821
44f230aa
SM
3822 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3823 steal a few bits to be more compact.
3824 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3825 Remove unneeded casts.
3826
1c470562
SM
3827 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3828
888adce9
ZK
38292011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3830
3831 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3832 binding" message (bug#7967).
3833
f838ed7b
PE
38342011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3835
77861b95
PE
3836 Fix more problems found by GCC 4.6.0's static checks.
3837
de6dbc14
PE
3838 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3839 Remove unused local var.
3840
f838ed7b
PE
3841 * editfns.c (Fmessage_box): Remove unused local var.
3842
792c7b2b
PE
3843 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3844 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3845 Omit unused local vars.
c499e557 3846 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3847 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3848 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3849 Omit unused local var.
3850
ba0165e1
PE
3851 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3852 Don't assume string length fits in int.
32ad8845 3853 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3854 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3855
3c59b4c9
PE
3856 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3857 instead of alloca (Bug#8344).
3858
a3eed478 3859 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3860 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3861
eb4d412d
PE
3862 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3863
1658b401
PE
3864 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3865 concerns.
3866
3867 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3868
3869 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3870
9a2c6e05
PE
3871 * keyboard.c (syms_of_keyboard): Use the same style as later
3872 in this function when indexing through an array. This also
3873 works around GCC bug 48267.
3874
03d0a109
PE
3875 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3876
44f730c8
PE
3877 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3878
fe75f926
PE
3879 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3880 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3881
ffa8c828
PE
3882 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3883 This avoids undefined behavior on integer overflow, and is a bit
3884 more convenient anyway since it is compared to a size_t variable.
3885
c5101a77
PE
3886 Variadic C functions now count arguments with size_t, not int.
3887 This avoids an unnecessary limitation on 64-bit machines, which
3888 caused (substring ...) to crash on large vectors (Bug#8344).
3889 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3890 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3891 All variadic functions and their callers changed accordingly.
c5101a77
PE
3892 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3893 * data.c (arith_driver, float_arith_driver): Likewise.
3894 * editfns.c (general_insert_function): Likewise.
3895 * eval.c (struct backtrace.nargs, interactive_p)
3896 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3897 (funcall_lambda, mark_backtrace): Likewise.
3898 * fns.c (concat): Likewise.
3899 * frame.c (x_set_frame_parameters): Likewise.
3900 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3901 0 if not found, not -1. All callers changed.
3902
dd3f25f7
PE
3903 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3904 (stack_copy_size): Now size_t, not int.
3905 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3906
461c2ab9
JB
39072011-03-28 Juanma Barranquero <lekktu@gmail.com>
3908
3909 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3910 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3911 All callers changed.
3912
3913 * lisp.h (multibyte_char_to_unibyte):
3914 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3915 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3916 * character.h (CHAR_TO_BYTE8):
3917 * cmds.c (internal_self_insert):
3918 * editfns.c (general_insert_function):
3919 * keymap.c (push_key_description):
3920 * search.c (Freplace_match):
3921 * xdisp.c (message_dolog, set_message_1): All callers changed.
3922
f6d62986
SM
39232011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3924
3925 * keyboard.c (safe_run_hook_funcall): New function.
3926 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3927 don't set the hook to nil, but remove the offending function instead.
3928 (Qcommand_hook_internal): Remove, unused.
3929 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3930 Vcommand_hook_internal.
3931
3932 * eval.c (enum run_hooks_condition): Remove.
3933 (funcall_nil, funcall_not): New functions.
3934 (run_hook_with_args): Call each function through a `funcall' argument.
3935 Remove `cond' argument, now redundant.
3936 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3937 (Frun_hook_with_args_until_failure): Adjust accordingly.
3938 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3939
1db5b1ad
JB
39402011-03-28 Juanma Barranquero <lekktu@gmail.com>
3941
3942 * dispextern.h (string_buffer_position): Remove declaration.
3943
3944 * print.c (strout): Remove parameter `multibyte', unused since
3945 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3946
3947 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3948 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3949 All callers changed.
3950
3951 * w32.c (_wsa_errlist): Use braces for struct initializers.
3952
3953 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3954 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3955 All callers changed.
3956 (string_buffer_position): Likewise. Also, make static (it's never
3957 used outside xdisp.c).
3958 (cursor_row_p): Remove parameter `w', unused since
3959 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3960 (decode_mode_spec): Remove parameter `precision', introduced during
3961 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3962 All callers changed.
3963
5ffb62aa
JD
39642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3965
3966 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3967
461c2ab9 39682011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3969
3970 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3971 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3972 (ns_update_auto_hide_menu_bar): New functions.
3973 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3974 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3975 ns_constrain_all_frames.
3976 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3977 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3978
5c380ffb
JD
39792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3980
3981 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3982
9af30bdf
GM
39832011-03-27 Glenn Morris <rgm@gnu.org>
3984
3985 * syssignal.h: Replace RETSIGTYPE with void.
3986 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3987 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3988 Replace SIGTYPE with void everywhere.
3989 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3990 * s/template.h (SIGTYPE): Remove commented out definition.
3991
e2abce01
JB
39922011-03-26 Eli Zaretskii <eliz@gnu.org>
3993
3994 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3995 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3996
f868cd8a
JB
39972011-03-26 Juanma Barranquero <lekktu@gmail.com>
3998
59eb0929
JB
3999 * w32.c (read_unc_volume): Use parameter `henum', instead of
4000 global variable `wget_enum_handle'.
4001
4002 * keymap.c (describe_vector): Remove parameters `indices' and
4003 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4004 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4005
f868cd8a
JB
4006 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4007
4008 * keyboard.c (timer_check): Remove parameter `do_it_now',
4009 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4010 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4011 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4012
4013 * keyboard.c (read_char):
4014 * w32menu.c (w32_menu_display_help):
4015 * xmenu.c (show_help_event, menu_help_callback):
4016 Adjust calls to `show_help_echo'.
4017
4018 * gtkutil.c (xg_maybe_add_timer):
4019 * keyboard.c (readable_events):
4020 * process.c (wait_reading_process_output):
4021 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4022
4023 * insdel.c (adjust_markers_gap_motion):
4024 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4025 (gap_left, gap_right): Don't call it.
4026
2ecf6fdb
CY
40272011-03-25 Chong Yidong <cyd@stupidchicken.com>
4028
4029 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4030 incurred during fontification.
4031
6b1f9ba4
JB
40322011-03-25 Juanma Barranquero <lekktu@gmail.com>
4033
4034 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4035 (DEFVAR_PER_BUFFER): Don't pass it.
4036
4037 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4038 (scrolling_window): Don't pass it.
4039
0f4a96b5
JB
40402011-03-25 Juanma Barranquero <lekktu@gmail.com>
4041
4042 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4043
4044 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4045 and `suffix'.
4046 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4047 of variables specific to SELinux and computation of `encoded_absname'.
4048
4049 * image.c (XPutPixel): Remove unused variable `height'.
4050
4051 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4052
4053 * unexw32.c (get_section_info): Remove unused variable `section'.
4054
4055 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4056 (system_process_attributes): Remove unused variable `sess'.
4057 (sys_read): Remove unused variable `err'.
4058
4059 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4060 (w32_wnd_proc): Remove unused variable `isdead'.
4061 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4062 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4063 (x_create_tip_frame): Remove unused variable `tem'.
4064
4065 * w32inevt.c (w32_console_read_socket):
4066 Remove unused variable `no_events'.
4067
4068 * w32term.c (x_draw_composite_glyph_string_foreground):
4069 Remove unused variable `width'.
4070
1149507c
JB
40712011-03-24 Juanma Barranquero <lekktu@gmail.com>
4072
4073 * w32term.c (x_set_glyph_string_clipping):
4074 Don't pass uninitialized region to CombineRgn.
4075
9c88f339
JB
40762011-03-23 Juanma Barranquero <lekktu@gmail.com>
4077
4078 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4079 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4080 (Fx_close_connection): Remove unused variable `i'.
4081
4082 * w32font.c (w32font_draw): Return number of glyphs.
4083 (w32font_open_internal): Remove unused variable `i'.
4084 (w32font_driver): Add missing initializer.
4085
4086 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4087 (fill_in_menu): Remove unused variable `items_added'.
4088
4089 * w32term.c (last_mouse_press_frame): Remove static global variable.
4090 (w32_clip_to_row): Remove unused variable `f'.
4091 (x_delete_terminal): Remove unused variable `i'.
4092
4093 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4094 (NOTHING): Remove unused static global variable.
4095 (uniscribe_check_otf): Remove unused variable `table'.
4096 (uniscribe_font_driver): Add missing initializers.
4097
dee091a3
JD
40982011-03-23 Julien Danjou <julien@danjou.info>
4099
4100 * term.c (Fsuspend_tty, Fresume_tty):
4101 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4102 * window.c (temp_output_buffer_show):
4103 * insdel.c (signal_before_change):
4104 * frame.c (Fhandle_switch_frame):
4105 * fileio.c (Fdo_auto_save):
4106 * emacs.c (Fkill_emacs):
4107 * editfns.c (save_excursion_restore):
4108 * cmds.c (internal_self_insert):
4109 * callint.c (Fcall_interactively):
4110 * buffer.c (Fkill_all_local_variables):
4111 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4112 Use Frun_hooks.
0f4a96b5 4113 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4114 unconditionnaly since it does the check itself.
4115
2c520ab5 41162011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4117
c9c49752
PE
4118 Fix more problems found by GCC 4.5.2's static checks.
4119
8abc3f12
PE
4120 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4121 the first time through the loop, since we know p0 < p1 then.
4122 This also avoids a gcc -Wstrict-overflow warning.
4123
a2d26660
PE
4124 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4125 leading to a memory leak, possible in functions like
4126 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4127 of objects (Bug#8318).
a2d26660 4128
916c72e9
PE
4129 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4130 that could (at least in theory) be that large.
4131
19ab8a18
PE
4132 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4133 This is less likely to overflow, and avoids undefined behavior if
4134 overflow does occur. All callers changed. Use strtoul to scan
4135 for the unsigned long integer.
b7cbbd6f
PE
4136 (pint2hrstr): Simplify and tune code slightly.
4137 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4138
f0641eff
PE
4139 * scroll.c (do_scrolling): Work around GCC bug 48228.
4140 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4141
7f650bb9
PE
4142 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4143 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4144 (validate_x_resource_name): Simplify count usage.
4145 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4146
37dd57d1
PE
4147 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4148 fail (Bug#8306).
81e56e61 4149
699979fc 4150 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4151
401bf9b4
PE
4152 * process.c (Fmake_network_process): Use socklen_t, not int,
4153 where POSIX says socklen_t is required in portable programs.
4154 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4155 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4156 (Fmake_network_process, server_accept_connection):
4157 (wait_reading_process_output, read_process_output):
4158 Likewise.
4159
b93aacde
PE
4160 * process.c: Rename or move locals to avoid shadowing.
4161 (list_processes_1, Fmake_network_process):
4162 (read_process_output_error_handler, exec_sentinel_error_handler):
4163 Rename or move locals.
4dc343ee 4164 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4165 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4166 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4167 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4168 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4169
af8a867c 4170 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4171 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4172 Include tparam.h instead, since it declares them.
af8a867c
PE
4173 * cm.h (PC): Remove extern decl; tparam.h now does this.
4174 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4175 * terminfo.c: Include tparam.h, to check interfaces.
4176 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4177 (tparam): Adjust signature to match interface in tparam.h;
4178 this removes some undefined behavior. Check that outstring and len
4179 are zero, which they always are with Emacs.
4180 * tparam.h (PC, BC, UP): New extern decls.
4181
0248044d 4182 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4183 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4184
8ff096c1 4185 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4186 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4187 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4188 (ftfont_list): Remove unused local.
49eaafba
PE
4189 (get_adstyle_property, ftfont_pattern_entity):
4190 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4191 Rename locals to avoid shadowing.
8ff096c1 4192
e2be39f6
PE
4193 * xfont.c (xfont_list_family): Mark var as initialized.
4194
c9735e30
PE
4195 * xml.c (make_dom): Now static.
4196
8f5201ae
PE
4197 * composite.c (composition_compute_stop_pos): Rename local to
4198 avoid shadowing.
b246f932
PE
4199 (composition_reseat_it): Remove unused locals.
4200 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4201 (composition_update_it): Mark var as initialized.
11b61122
PE
4202 (find_automatic_composition): Mark vars as initialized,
4203 with a FIXME (Bug#8290).
8f5201ae 4204
760fbc2c
PE
4205 character.h: Rename locals to avoid shadowing.
4206 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4207 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4208 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4209 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4210 to avoid shadowing.
4211
ff08eb85
PE
4212 * textprop.c (property_change_between_p): Remove; unused.
4213
fc7bf025
PE
4214 * intervals.c (interval_start_pos): Now static.
4215
235d7abc
PE
4216 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4217
44f230aa
SM
4218 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4219 Rename locals to avoid shadowing.
3e7d6594 4220
50060332
PE
4221 * sound.c (wav_play, au_play, Fplay_sound_internal):
4222 Fix pointer signedness.
d01f234b 4223 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4224 (wav_play): Initialize a variable to 0, to prevent undefined
4225 behavior (Bug#8278).
50060332 4226
c4fc4e30
PE
4227 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4228
918436ed
PE
4229 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4230
c939f91b
PE
4231 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4232 clobbering (Bug#8298).
b9c7f648
PE
4233 * sysdep.c (sys_subshell): Likewise.
4234 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4235
6bd8c144
PE
4236 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4237 This should get cleaned up, so that child_setup has the
4238 same signature on all platforms.
4239
7710357c 4240 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4241 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4242
c59da222
CY
42432011-03-22 Chong Yidong <cyd@stupidchicken.com>
4244
4245 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4246 not to be necessary, and produces flickering.
4247
66b87493
GM
42482011-03-20 Glenn Morris <rgm@gnu.org>
4249
4250 * config.in: Remove file.
4251
45b6f6d5
JB
42522011-03-20 Juanma Barranquero <lekktu@gmail.com>
4253
4254 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4255 are now in src/globals.h.
4256 (syms_of_minibuf): Remove spurious & from previous change.
4257
3ec03f7e
LL
42582011-03-20 Leo <sdl.web@gmail.com>
4259
4260 * minibuf.c (completing-read-function): New variable.
4261 (completing-read-default): Rename from completing-read.
4262 (completing-read): Call completing-read-function.
4263
b14e3e21
CY
42642011-03-19 Juanma Barranquero <lekktu@gmail.com>
4265
4266 * xfaces.c (Fx_load_color_file):
4267 Read color file from absolute filename (bug#8250).
4268
f2b726e6
JB
42692011-03-19 Juanma Barranquero <lekktu@gmail.com>
4270
4271 * makefile.w32-in: Update dependencies.
4272
09f6ff02
EZ
42732011-03-17 Eli Zaretskii <eliz@gnu.org>
4274
4275 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4276
29a6015a
PE
42772011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4278
a3a6c54e
PE
4279 Fix more problems found by GCC 4.5.2's static checks.
4280
b766f867
PE
4281 * process.c (make_serial_process_unwind, send_process_trap):
4282 (sigchld_handler): Now static.
4283
be02381c
PE
4284 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4285 That way, the code declares only the vars that it needs.
4286 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4287 * s/cygwin.h (PTY_ITERATION): Likewise.
4288 * s/darwin.h (PTY_ITERATION): Likewise.
4289 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4290
57048744
PE
4291 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4292 * process.c (allocate_pty): Don't declare stb unless it's needed.
4293
7914961c 4294 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4295 (CONSTANTLIM): Remove; unused.
4296 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4297 Define only if needed.
7914961c 4298
b3967b18
PE
4299 * unexelf.c (unexec): Name an expression,
4300 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4301 Use a different way to cause a compilation error if anyone uses
4302 n rather than nn, a way that does not involve shadowing.
73366a00 4303 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4304
29a6015a
PE
4305 * deps.mk (unexalpha.o): Remove; unused.
4306
43cfc33e 4307 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4308 * unexec.h: New file.
ce701a33
PE
4309 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4310 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4311 Depend on unexec.h.
4312 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4313 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4314 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4315 Change as necessary to match prototype in unexec.h.
ce701a33 4316
01f44d5a
PE
4317 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4318 shadowing.
4f63c6bb 4319 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4320
a6670b0b
PE
4321 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4322 Rename locals to avoid shadowing.
4323
cef2010d 4324 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4325 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4326
d4d7173a
PE
4327 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4328
f08b802a
PE
4329 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4330 warning when compiling print.c.
4331
3ddb0639
PE
4332 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4333 instead of using an uninitialized var.
5ad03b97 4334 (font_sort_entities): Mark var as initialized.
3ddb0639 4335
170a2692
PE
4336 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4337
e663c700
PE
4338 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4339 pointers to constants.
89bc529a 4340 (font_parse_fcname): Remove unused vars.
7b81e2d0 4341 (font_delete_unmatched): Now static.
ea838e10 4342 (font_get_spec): Remove; unused.
13a547c6
PE
4343 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4344 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4345 Rename or move locals to avoid shadowing.
e663c700 4346
2a80c887 4347 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4348 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4349
1384fa33 4350 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4351 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4352
8b2c52e9
PE
4353 * alloc.c (mark_backtrace): Move decl from here ...
4354 * lisp.h: ... to here, so that it can be checked.
4355
475545b5 4356 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4357 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4358 (lisp_indirect_variable): Name an expression,
4359 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4360 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4361
b1349114 4362 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4363 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4364 Use const pointer when appropriate.
b1349114 4365
a2928364
PE
4366 * lisp.h (get_system_name, get_operating_system_release):
4367 Move decls here, to check interfaces.
4368 * process.c (get_operating_system_release): Move decl to lisp.h.
4369 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4370 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4371 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4372 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4373 (Fformat_time_string, Fencode_time, Finsert_char):
4374 (Ftranslate_region_internal, Fformat):
4375 Rename or remove local vars to avoid shadowing.
9710023e 4376 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4377
a415e694
PE
4378 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4379 avoid shadowing.
4380
8ef4622d
PE
4381 * lisp.h (eassert): Check that the argument compiles, even if
4382 ENABLE_CHECKING is not defined.
4383
946f9a5b
PE
4384 * data.c (Findirect_variable): Name an expression, to avoid
4385 gcc -Wbad-function-cast warning.
112396d6 4386 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4387 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4388 (Fmake_variable_buffer_local, Fmake_local_variable):
4389 Mark variables as initialized.
52746918 4390 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4391
e5aab7e7 4392 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4393 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4394 Rename locals to avoid shadowing.
dff45157
PE
4395 (mark_stack): Move local variables into the #ifdef region where
4396 they're used.
7bc26fdb
PE
4397 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4398 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4399 needed otherwise.
4400 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4401 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4402 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4403
e5aab7e7
PE
4404 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4405 avoids undefined behavior in theory.
4406
4da60324
PE
4407 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4408
88043301
PE
4409 Use functions, not macros, for up- and down-casing (Bug#8254).
4410 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4411 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4412 to use the following functions instead of these macros.
4413 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4414 EMACS_INT, since callers assume the returned value fits in int.
4415 (upcase1): Likewise, for UPCASE_TABLE.
4416 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4417 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4418 the race-condition problem in the old DOWNCASE.
88043301 4419
19ed5445
PE
4420 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4421 Rename locals to avoid shadowing.
4422 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4423 (regex_compile, re_search_2, re_match_2_internal):
4424 Remove unused local vars.
952db0d7
PE
4425 (FREE_VAR): Rewrite so as not to use empty "else",
4426 which gcc can warn about.
da053e48 4427 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4428 (RETALLOC_IF): Define only if needed.
4429 (WORDCHAR_P): Likewise. This one is never needed, but is used
4430 only in a comment talking about a compiler bug, so put inside
4431 the #if 0 of that comment.
4432 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4433 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4434 Remove; unused.
19ed5445 4435
1f3561e4 4436 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4437 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4438 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4439
ded6f8f7
PE
4440 * search.c (simple_search): Remove unused var.
4441
dbd37a95
PE
4442 * dired.c (compile_pattern): Move decl from here ...
4443 * lisp.h: ... to here, so that it can be checked.
4444 (struct re_registers): New forward decl.
4445
7e47afad
PE
4446 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4447
85f24f61
PE
4448 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4449 All uses changed.
4450 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4451 Rename locals to avoid shadowing.
5671df8f 4452 (Fvertical_motion): Mark locals as initialized.
85f24f61 4453
181aa2be 4454 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4455 (casify_region): Mark local as initialized.
181aa2be 4456
930d429c
PE
4457 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4458
7082eac6
PE
4459 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4460 New macros, so that the caller can use some names other than
4461 gcpro1, gcpro2, etc.
4462 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4463 of the new macros.
4464 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4465 argument, for consistency with GCPRO2_VAR, etc: it is now the
4466 prefix of the variable, not the variable itself. All uses
4467 changed.
38b2c076
PE
4468 * dired.c (directory_files_internal, file_name_completion):
4469 Rename locals to avoid shadowing.
4470
15206ed9
PE
4471 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4472 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4473 dired.c's scmp function, had undefined behavior.
4474 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4475 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4476 * buffer.h: ... to here, because these macros use current_buffer,
4477 and the new implementation with inline functions needs to have
4478 current_buffer in scope now, rather than later when the macros
4479 are used.
4480 (downcase, upcase1): New static inline functions.
4481 (DOWNCASE, UPCASE1): Reimplement using these functions.
4482 This avoids undefined behavior in expressions like
4483 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4484 from race conditions in accessing the global variables
4485 case_temp1 and case_temp2.
4486 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4487 * lisp.h (case_temp1, case_temp2): Remove their decls.
4488 * character.h (ASCII_CHAR_P): Move from here ...
4489 * lisp.h: ... to here, so that the inline functions mentioned
4490 above can use them.
4491
4a6bea26
PE
4492 * dired.c (directory_files_internal_unwind): Now static.
4493
f14b7e14
PE
4494 * fileio.c (file_name_as_directory, directory_file_name):
4495 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4496 Now static.
2893f146
PE
4497 (file_name_as_directory): Use const pointers when appropriate.
4498 (Fexpand_file_name): Likewise. In particular, newdir might
4499 point at constant storage, so make it a const pointer.
fd4ead52 4500 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4501 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4502 signedness issues.
f839df0c
PE
4503 (Fset_file_times, Finsert_file_contents, auto_save_error):
4504 Rename locals to avoid shadowing.
f14b7e14 4505
5716756e 4506 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4507 (Ftry_completion, Fall_completions): Rename or remove locals
4508 to avoid shadowing.
5716756e 4509
b4c3046a
PE
4510 * marker.c (bytepos_to_charpos): Remove; unused.
4511
b45db522
PE
4512 * lisp.h (verify_bytepos, count_markers): New decls,
4513 so that gcc does not warn that these functions aren't declared.
4514
85876d07
PE
4515 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4516 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4517 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4518 (copy_text): Remove unused local var.
85876d07 4519
03d78a21 4520 * filelock.c (within_one_second): Now static.
b3dd38ab 4521 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4522
5df8f01b
PE
4523 * buffer.c (fix_overlays_before): Mark locals as initialized.
4524 (fix_start_end_in_overlays): Likewise. This function should be
4525 simplified by using pointers-to-pointers, but that's a different
4526 matter.
b1d876f1 4527 (switch_to_buffer_1): Now static.
8f54f30a
PE
4528 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4529 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4530
a70072c9 4531 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4532 Fix pointer signedness issue.
edced198
PE
4533 (sys_subshell): Mark local as volatile if checking for lint,
4534 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4535 (MAXPATHLEN): Define only if needed.
a70072c9 4536
a0977c44
PE
4537 * process.c (serial_open, serial_configure): Move decls from here ...
4538 * systty.h: ... to here, so that they can be checked.
4539
a884fdcc
PE
4540 * fns.c (get_random, seed_random): Move extern decls from here ...
4541 * lisp.h: ... to here, so that they can be checked.
4542
604efe86 4543 * sysdep.c (reset_io): Now static.
b8950c94 4544 (wait_for_termination_signal): Remove; unused.
604efe86 4545
38fc62d9
PE
4546 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4547 (copy_keymap_item, append_key, push_text_char_description):
4548 Now static.
1004a21a 4549 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4550 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4551 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4552 (describe_map_tree):
4553 Rename locals to avoid shadowing.
38fc62d9 4554
2f2650da
PE
4555 * keyboard.c: Declare functions static if they are not used elsewhere.
4556 (echo_char, echo_dash, cmd_error, top_level_2):
4557 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4558 (read_char, kbd_buffer_get_event, make_lispy_position):
4559 (make_lispy_event, make_lispy_movement, apply_modifiers):
4560 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4561 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4562 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4563 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4564 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4565
a053e86c 4566 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4567 (mark_kboards): Move decl here ...
4568 * alloc.c (mark_kboards): ... from here.
a053e86c 4569
4752793e
PE
4570 * lisp.h (force_auto_save_soon): New decl.
4571
74f10ca7 4572 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4573 (DEFINE_DUMMY_FUNCTION): New macro.
4574 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4575 Use it.
c03cd23f
PE
4576 (main): Add casts to avoid warnings
4577 if GCC considers string literals to be constants.
74f10ca7 4578
022e70d4
PE
4579 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4580
59d6fe83
PE
4581 * dbusbind.c: Pointer signedness fixes.
4582 (xd_signature, xd_append_arg, xd_initialize):
4583 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4584 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4585 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4586 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4587
78320123
PE
4588 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4589 if GCC considers string literals to be constants.
49cebcca 4590 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4591
35ac2a97
SM
45922011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4593
fb103ca9
SM
4594 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4595 (print_preprocess, print_object): New macro to fix last change.
4596
35ac2a97
SM
4597 * print.c (print_preprocess): Don't forget font objects.
4598
62973b41
JB
45992011-03-16 Juanma Barranquero <lekktu@gmail.com>
4600
4601 * emacs.c (USAGE3): Doc fixes.
4602
0e48bb22
AS
46032011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4604
4605 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4606 structure.
4607
7684e57b
JB
46082011-03-14 Juanma Barranquero <lekktu@gmail.com>
4609
4610 * lisp.h (VWindow_system, Qfile_name_history):
4611 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4612 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4613 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4614
4615 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4616 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4617
4618 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4619 * w32console.c (detect_input_pending, read_input_pending)
4620 (encode_terminal_code):
4621 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4622 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4623 (w32_system_caret_y, Qfile_name_history):
4624 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4625 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4626 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4627 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4628 * w32proc.c (Qlocal, report_file_error):
4629 * w32term.c (Vwindow_system, updating_frame):
4630 * w32uniscribe.c (initialized, uniscribe_font_driver):
4631 Remove unneeded extern declarations.
4632
2aa46d6c
CY
46332011-03-14 Chong Yidong <cyd@stupidchicken.com>
4634
c96bbc66 4635 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4636
cffc6f3b
CY
46372011-03-13 Chong Yidong <cyd@stupidchicken.com>
4638
4639 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4640 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4641 These macros can no longer be used for assignment.
4642
44f230aa
SM
4643 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4644 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4645 (record_buffer_markers, fetch_buffer_markers): New functions for
4646 recording and fetching special buffer markers.
4647 (set_buffer_internal_1, set_buffer_temp): Use them.
4648
4649 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4650
4651 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4652
4653 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4654 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4655
4656 * xdisp.c (hscroll_window_tree):
4657 (reconsider_clip_changes): Use PT instead of BUF_PT.
4658
d251f04b
EZ
46592011-03-13 Eli Zaretskii <eliz@gnu.org>
4660
4661 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4662 $(EMACS_ROOT)/lib/intprops.h.
4663
f0c77cd1
PE
46642011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4665
3eca4629
PE
4666 Fix more problems found by GCC 4.5.2's static checks.
4667
7c86ee98
PE
4668 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4669 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4670 (xg_free_frame_widgets): Make it clear that a local variable is
4671 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4672 (gdk_window_get_screen): Make it clear that this macro is needed
4673 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4674 (int_gtk_range_get_value): New function, which avoids a diagnostic
4675 from gcc -Wbad-function-cast.
4676 (xg_set_toolkit_scroll_bar_thumb): Use it.
4677 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4678 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4679 (get_utf8_string, xg_get_file_with_chooser):
4680 Rename locals to avoid shadowing.
4681 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4682
41729b81
PE
4683 * xgselect.c (xg_select): Remove unused var.
4684
f0c77cd1
PE
4685 * image.c (four_corners_best): Mark locals as initialized.
4686 (gif_load): Initialize transparent_p to zero (Bug#8238).
4687 Mark another local as initialized.
ec6cf4c6 4688 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4689
ce0ad53d 4690 * image.c (clear_image_cache): Now static.
d5d5a617 4691 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4692 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4693 (x_edge_detection): Remove unnecessary cast that
4694 gcc -Wbad-function-cast diagnoses.
2037898d 4695 (gif_load): Fix pointer signedness.
6ae141d6
PE
4696 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4697 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4698
33383987 46992011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4700
d32df629
PE
4701 Improve quality of tests for time stamp overflow.
4702 For example, without this patch (encode-time 0 0 0 1 1
4703 1152921504606846976) returns the obviously-bogus value (-948597
4704 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4705 reports time overflow. See
4706 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4707 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4708 * editfns.c: Include limits.h and intprops.h.
4709 (TIME_T_MIN, TIME_T_MAX): New macros.
4710 (time_overflow): Move earlier, to before first use.
4711 (hi_time, lo_time): New functions, for an accurate test for
4712 out-of-range times.
4713 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4714 (Fget_internal_run_time): Don't assume time_t fits in int.
4715 (make_time): Use list2 instead of Fcons twice.
4716 (Fdecode_time): More accurate test for out-of-range times.
4717 (check_tm_member): New function.
4718 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4719 (lisp_time_argument): Don't rely on undefined left-shift and
4720 right-shift behavior when checking for time stamp overflow.
8be6f318 4721
fe31d94c
PE
4722 * editfns.c (time_overflow): New function, refactoring common code.
4723 (Fformat_time_string, Fdecode_time, Fencode_time):
4724 (Fcurrent_time_string): Use it.
4725
8be6f318
PE
4726 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4727 * dired.c (make_time): Move to ...
4728 * editfns.c (make_time): ... here.
4729 * systime.h: Note the move.
4730
09d9db2c 47312011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4732
126bc0dc
YM
4733 * fringe.c (update_window_fringes): Remove unused variables.
4734
c47cbdfd
YM
4735 * unexmacosx.c (copy_data_segment): Also copy __got section.
4736 (Bug#8223)
4737
7ac80be9
EZ
47382011-03-12 Eli Zaretskii <eliz@gnu.org>
4739
c96bbc66 4740 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4741 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4742 Constify `char *' arguments and their references according to
4743 prototypes in tparam.h.
4744
ecb0f94d 4745 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4746
7ac80be9
EZ
4747 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4748 Adapt all references accordingly.
4749
4750 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4751
ef1fd07e
TT
47522011-03-11 Tom Tromey <tromey@redhat.com>
4753
4754 * buffer.c (syms_of_buffer): Remove obsolete comment.
4755
7ef4b50c
EZ
47562011-03-11 Eli Zaretskii <eliz@gnu.org>
4757
4758 * termhooks.h (encode_terminal_code): Declare prototype.
4759
4760 * msdos.c (encode_terminal_code): Don't declare prototype.
4761
4762 * term.c (encode_terminal_code): Now external again, used by
4763 w32console.c and msdos.c.
4764
44f230aa
SM
4765 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4766 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4767
4b1ec863 47682011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4769
1714f52b 4770 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4771
4b1ec863
PE
4772 * fringe.c (update_window_fringes): Mark locals as initialized
4773 (Bug#8227).
4774 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4775
524c7aa6
PE
4776 * alloc.c (mark_fringe_data): Move decl from here ...
4777 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4778 to check its interface.
4779 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4780
a5c0af81 4781 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4782 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4783 (fontset_font): Mark local as initialized.
a9a06e0b 4784 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4785
b4716021
PE
4786 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4787
811e9bac 4788 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4789 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4790 (x_own_selection, Fx_disown_selection_internal): Rename locals
4791 to avoid shadowing.
4792 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4793
7e3ab302
PE
4794 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4795 so that the caller can use some name other than gcpro1.
4796 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4797 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4798 (Fx_backspace_delete_keys_p):
4799 Use them to avoid shadowing, and rename vars to avoid shadowing.
4800 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4801 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4802 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4803 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4804 Remove unused locals.
7e3ab302
PE
4805 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4806 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4807 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4808 macros.
f78faa98 4809
e2b13473
PE
4810 * xterm.h (x_mouse_leave): New decl.
4811
77f23912
PE
4812 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4813 Remove unused functions.
cdf4ba58
PE
4814 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4815 (x_calc_absolute_position): Now static.
7411c686 4816 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4817 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4818 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4819 unless they are used.
38d0b34a
PE
4820 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4821 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4822 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4823 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4824 (x_error_catcher, x_connection_closed, x_error_handler):
4825 (x_error_quitter, xembed_send_message, x_iconify_frame):
4826 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4827 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4828 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4829
44f230aa
SM
4830 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4831 Rename or move locals to avoid shadowing.
6b463e58 4832 (tty_defined_color, merge_face_heights): Now static.
5967d051 4833 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4834 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4835 does not deduce is never used uninitialized.
73719eba
PE
4836 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4837 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4838
426994c3 4839 * terminal.c (store_terminal_param): Now static.
5489860b 4840
032f1620 4841 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4842 (set_frame_menubar): Remove unused local.
d4323972 4843 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4844 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4845 since they might point to immutable storage.
281585b0
PE
4846 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4847 since it's unused otherwise.
032f1620 4848
367c19e5 4849 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4850 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4851 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4852 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4853 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4854 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4855 does not deduce are never used uninitialized.
70739cbe 4856
07b48fa9
PE
4857 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4858
8868a238 4859 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4860 * window.c (window_loop, size_window):
4861 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4862
7e5cf297 4863 * window.c (display_buffer): Now static.
d6550a9f
PE
4864 (size_window): Mark variables that gcc -Wuninitialized
4865 does not deduce are never used uninitialized.
a586633d
PE
4866 * window.h (check_all_windows): New decl, to forestall
4867 gcc -Wmissing-prototypes diagnostic.
5b555da1 4868 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4869
f6095868
PE
4870 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4871 shadowing.
4872 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4873 Include <limits.h>.
4874 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4875 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4876 (load_charset_map): Mark variables that gcc -Wuninitialized
4877 does not deduce are never used uninitialized.
53df7c11 4878 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4879
f38b440c
PE
4880 * coding.c (coding_set_source, coding_set_destination):
4881 Use "else { /* comment */ }" rather than "else /* comment */;"
4882 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4883 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4884 a block, when the outer 'i' will do.
4885 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4886 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4887 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4888 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4889 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4890 Rename locals to avoid shadowing.
4891 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4892 * coding.c (emacs_mule_char, encode_invocation_designation):
4893 Now static, since they're not used elsewhere.
413bb2db 4894 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4895 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4896 (decode_coding_emacs_mule): Mark variables that gcc
4897 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4898 (detect_coding_iso_2022): Initialize a local variable that might
4899 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4900 this initialization is needed. (Bug#8211)
5f58e762
PE
4901 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4902 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4903 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4904 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4905 Remove unused macros.
f38b440c 4906
232b38b9 4907 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4908 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4909 * character.c (string_count_byte8): Likewise.
232b38b9 4910
fb90da1b
PE
4911 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4912 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4913
fb93dbc2
PE
4914 * chartab.c (copy_sub_char_table): Now static, since it's not used
4915 elsewhere.
5c156ace
PE
4916 (sub_char_table_ref_and_range, char_table_ref_and_range):
4917 Rename locals to avoid shadowing.
bbcd0949 4918 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4919
7d3b3862 4920 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4921 (BIDI_BOB): Remove unused macro.
7d3b3862 4922
6be7d3da
PE
4923 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4924 deduce are never used uninitialized.
c2ed9c8b 4925 * term.c (encode_terminal_code): Likewise.
6be7d3da 4926
75f8807f 4927 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4928
50938595
PE
4929 * tparam.h: New file.
4930 * term.c, tparam.h: Include it.
4931 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4932 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4933 Move these decls to tparam.h, and make them agree with what
4934 is actually in tparam.c. The previous trick of using incompatible
4935 decls in different modules does not conform to the C standard.
4936 All callers of tparam changed to use tparam's actual API.
4937 * tparam.c (tparam1, tparam, tgoto):
4938 Use const pointers where appropriate.
4939
fbceeba2
PE
4940 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4941 * cm.h (struct cm): Likewise.
4942 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4943 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4944 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4945 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4946 (turn_on_face, init_tty): Likewise.
4947 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4948
7f3f1250
PE
4949 * term.c (term_mouse_position): Rename local to avoid shadowing.
4950
e6ca6543
PE
4951 * alloc.c (mark_ttys): Move decl from here ...
4952 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4953
c40f8d15
AS
49542011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4955
4956 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4957
cfe0661d
JB
49582011-03-09 Juanma Barranquero <lekktu@gmail.com>
4959
4960 * search.c (compile_pattern_1): Remove argument regp, unused since
4961 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4962 (compile_pattern): Don't pass it.
4963
0afb4571
J
49642011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4965
4966 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4967 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4968 for ! HAVE_GTK3.
4969 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4970
4971 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4972
4973 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4974 gdk_window_get_screen, gdk_window_get_geometry,
4975 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4976 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4977 (xg_get_pixbuf_from_pixmap): New function.
4978 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4979 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4980 Call xg_get_pixbuf_from_pixmap instead of
4981 gdk_pixbuf_get_from_drawable.
4982 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4983 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4984 (xg_check_special_colors): Use GtkStyleContext and its functions
4985 for HAVE_GTK3.
4986 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4987 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4988 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4989 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4990 Call gtk_widget_get_preferred_size.
0afb4571
J
4991 (xg_frame_resized): gdk_window_get_geometry only takes 5
4992 parameters.
44f230aa
SM
4993 (xg_win_to_widget, xg_event_is_for_menubar):
4994 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4995 (xg_set_widget_bg): New function.
4996 (delete_cb): New function.
895009e1 4997 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4998 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4999 (xg_set_background_color): Call xg_set_widget_bg.
5000 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5001 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5002 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5003 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5004 if ! HAVE_GTK3.
5005 (update_frame_tool_bar): Call gtk_widget_hide.
5006 (xg_initialize): Use GDK_KEY_g.
5007
5008 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5009 if ! HAVE_GTK3
5010 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5011
5012 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5013 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5014 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5015
1c2cc4ef
JB
50162011-03-08 Juanma Barranquero <lekktu@gmail.com>
5017
5018 * w32xfns.c (select_palette): Check success of RealizePalette against
5019 GDI_ERROR, not zero.
5020
33383987 5021See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5022
5023;; Local Variables:
5024;; coding: utf-8
aac0c6e3
MR
5025;; End:
5026
33383987 5027 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5028
5029 This file is part of GNU Emacs.
5030
5031 GNU Emacs is free software: you can redistribute it and/or modify
5032 it under the terms of the GNU General Public License as published by
5033 the Free Software Foundation, either version 3 of the License, or
5034 (at your option) any later version.
5035
5036 GNU Emacs is distributed in the hope that it will be useful,
5037 but WITHOUT ANY WARRANTY; without even the implied warranty of
5038 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5039 GNU General Public License for more details.
5040
5041 You should have received a copy of the GNU General Public License
5042 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.