* alloc.c (mark_buffer): Simplify. Remove prototype.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cf5c0175
DA
12012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * alloc.c (mark_buffer): Simplify. Remove prototype.
4 (mark_object): Add comment. Reorganize marking of vector-like
5 objects. Use CHECK_LIVE for all vector-like ojects except buffers
6 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
7 redundant calls to mark_vectorlike for bool vectors.
8
ca26824c
GM
92012-06-30 Glenn Morris <rgm@gnu.org>
10
2e4c5312
GM
11 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
12
ca26824c
GM
13 * epaths.in (PATH_SITELOADSEARCH): New.
14 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
15 This is rather than relying on --enable-locallisppath elements
16 having "site-lisp" in their names. (Bug#10208#25, 11658)
17
0d23c240
EZ
182012-06-30 Eli Zaretskii <eliz@gnu.org>
19
c9240d7a
EZ
20 * w32proc.c (sys_select): Accept and ignore one more argument.
21
22 * w32.c (emacs_gnutls_pull): Call select with one more argument.
23
0d23c240 24 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 25 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
26
27 * sysdep.c: Don't include dos.h and dosfns.h.
28
29 * process.c (sys_select):
30 * msdos.c (sys_select): Accept one more argument and ignore it.
31
32 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
33 adapt data types and code to that.
34
35 * dosfns.c:
36 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
37 which clashes with the gnulib function of the same name.
38
af5a5a98
AS
392012-06-30 Andreas Schwab <schwab@linux-m68k.org>
40
c5e4379c
AS
41 * font.c (font_style_to_value, font_style_symbolic)
42 (font_prop_validate_style): Add type checks for values in
43 font_style_table.
44
af5a5a98
AS
45 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
46 argument.
47 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
48 uses.
49
8d38f461
EZ
502012-06-29 Eli Zaretskii <eliz@gnu.org>
51
2e5a6631
EZ
52 * xdisp.c (try_window_id): Undo last change.
53
8d38f461
EZ
54 * w32.c (getwd): Adjust commentary about startup_dir.
55 (init_environment): Always call sys_access, even in non-MSVC
56 builds. Don't chdir to the directory of the Emacs executable.
57 This undoes code from 1997 which was justified by the need to
58 "avoid conflicts when removing and renaming directories". But its
59 downside was that every relative file name was being interpreted
60 relative to the directory of the Emacs executable, which can never
61 be TRT. In particular, it broke sys_access when called with
62 relative file names.
63 (sys_access): Map GetLastError to errno.
64
2af3565e
DA
652012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
66
67 * window.h (struct window): Change type of 'fringes_outside_margins'
68 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 69 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
70 Adjust comment.
71 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
72 to ptrdiff_t.
73
c8d3a25c 742012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 75
c8d3a25c
GM
76 * gnutls.c (emacs_gnutls_handshake):
77 Add QUIT to make the loop interruptible.
57570cd3 78
c8d3a25c 792012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 80
c8d3a25c
GM
81 * charset.c (init_charset): Make lack of etc/charsets fatal.
82
3e984ee8
DA
832012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
84
85 * editfns.c (region_limit): Fix type mismatch.
86
ef884f23
DA
872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
88
89 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
90 undefined. Convert from xassert to eassert.
91 * nsmenu.m: Convert from xassert to eassert.
92 * nsterm.m: Likewise.
93
7d7e0027
SM
942012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
95
96 * editfns.c (region_limit): Clip to narrowing (bug#11770).
97
aa754e6a
PE
982012-06-28 Paul Eggert <eggert@cs.ucla.edu>
99
100 Avoid integer overflow on scroll-left and scroll-right.
101 * window.c (HSCROLL_MAX): New macro.
102 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
103 overflow when requested scroll falls outside ptrdiff_t range.
104
80b00b08
DA
1052012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
106
107 * window.h (struct window): Change type of 'hscroll',
108 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
109 'last_modified' and 'last_overlay_modified' to EMACS_INT.
110 Adjust users accordingly.
111 * xdisp.c (try_cursor_movement): Replace type check with eassert.
112 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
113 from EMACS_INT to ptrdiff_t.
114 (make_window): Omit redundant initialization.
115
62b2bcf6
JB
1162012-06-28 Juanma Barranquero <lekktu@gmail.com>
117
118 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
119
45942c7d
DA
1202012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
121
122 * window.h (struct window): Change type of 'use_time' and
123 'sequence_number' from Lisp_Object to int.
124 * frame.c (make_frame): Adjust users accordingly.
125 * print.c (print_object): Likewise.
126 * window.c (select_window, Fwindow_use_time, make_parent_window)
127 (make_window): Likewise.
128
e509cfa6
DA
1292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
130
131 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
132 enabled with --enable-checking=[all,glyphs] configure option.
133 Fix GLYPH_DEBUG usage assuming that it may be undefined,
134 adjust comments accordingly.
135 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
136 undefined, adjust comments accordingly.
137 * image.c: Likewise.
138 * scroll.c: Likewise.
139 * w32fns.c: Likewise.
140 * w32term.c: Likewise.
141 * xdisp.c: Likewise.
142 * xfaces.c: Likewise.
143 * xfns.c: Likewise.
144 * xterm.c: Likewise.
145
a54e2c05
DA
1462012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
147
148 Generalize run-time debugging checks.
149 * dispextern.h (XASSERTS): Remove.
150 * fontset.c (xassert): Remove.
151 Convert from xassert to eassert.
152 * alloc.c: Convert from xassert to eassert.
153 * bidi.c: Likewise.
154 * dispnew.c: Likewise.
155 * fns.c: Likewise.
156 * fringe.c: Likewise.
157 * ftfont.c: Likewise.
158 * gtkutil.c: Likewise.
159 * image.c: Likewise.
160 * keyboard.c: Likewise.
161 * menu.c: Likewise.
162 * process.c: Likewise.
163 * scroll.c: Likewise.
164 * sound.c: Likewise.
165 * term.c: Likewise.
166 * w32console.c: Likewise.
167 * w32fns.c: Likewise.
168 * w32term.c: Likewise.
169 * window.c: Likewise.
170 * xdisp.c: Likewise.
171 * xfaces.c: Likewise.
172 * xfns.c: Likewise.
173 * xselect.c: Likewise.
174 * xterm.c: Likewise.
175
1ec4b7b2
SM
1762012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
177
178 * fns.c (maybe_resize_hash_table): Output message when growing the
179 purify-hashtable.
180
2014308a
DA
1812012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
182
183 * alloc.c (allocate_string_data): Remove dead code.
184 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
185 avoid GCC warning about unused macro.
186
246155eb
DA
1872012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
188
189 * alloc.c (allocate_string): Omit intervals initialization.
190 * alloc.c (make_uninit_multibyte_string): Initialize intervals
191 as in make_pure_string and make_pure_c_string.
192
43184b7b
DA
1932012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
194
195 * alloc.c (allocate_string): Fix last change.
196
3fe6dd74
DA
1972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
198
199 * alloc.c (allocate_string): Remove two redundant calls
200 to memset, add explicit initialization where appropriate.
201
1ba6038a
GM
2022012-06-27 Glenn Morris <rgm@gnu.org>
203
204 * lisp.mk (lisp): Remove paths.elc.
205
c89926a5
CY
2062012-06-27 Chong Yidong <cyd@gnu.org>
207
208 * doc.c (Fsubstitute_command_keys): Fix punctuation.
209
ed6b3510
JW
2102012-06-26 John Wiegley <johnw@newartisans.com>
211
1ec4b7b2 212 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
213 on Mac OS X Lion: __mod_init_func and __mod_term_func.
214
ed6b3510
JW
215 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
216 when building with Clang.
217
8edd4a2b
SM
2182012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
219
220 * eval.c (Fapply): Allow calling it with a single argument.
221
f6f62d1b
EZ
2222012-06-26 Eli Zaretskii <eliz@gnu.org>
223
224 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
225 _stricmp and _strnicmp.
226 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
227
62efea5e
DA
2282012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
229
230 * alloc.c (allocate_window): Zero out non-Lisp part of newly
231 allocated window.
232 (allocate_process): Likewise for new process.
8edd4a2b 233 (allocate_terminal): Change to use offsetof.
62efea5e
DA
234 (allocate_frame): Likewise.
235 * frame.c (make_frame): Omit redundant initialization.
236 * window.c (make_parent_window): Use memset.
237 (make_window): Omit redundant initialization.
238 * process.c (make_process): Omit redundant initialization.
239 * terminal.c (create_terminal): Likewise.
240
42997f4d
DA
2412012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
242
243 * term.c (delete_tty): Remove redundant call to memset.
244
1130ecfc
DA
2452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
246
247 * alloc.c: Remove build_string.
248 * lisp.h: Define build_string as static inline. This provides
249 a better opportunity to optimize away calls to strlen when the
250 function is called with compile-time constant argument.
251 * image.c (imagemagick_error): Convert to build_string.
252 * w32proc.c (sys_spawnve): Likewise.
253 * xterm.c (x_term_init): Likewise.
254
cf38a720
PE
2552012-06-26 Paul Eggert <eggert@cs.ucla.edu>
256
99027bdd
PE
257 Use sprintf return value instead of invoking strlen on result.
258 In the old days this wasn't portable, since some sprintf
259 implementations returned char *. But they died out years ago and
260 Emacs already assumes sprintf returns int.
261 Similarly for float_to_string.
262 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
263 * ccl.c (ccl_driver):
264 * character.c (string_escape_byte8):
265 * data.c (Fnumber_to_string):
266 * doprnt.c (doprnt):
267 * print.c (print_object):
268 * xdisp.c (message_dolog):
269 * xfns.c (syms_of_xfns):
270 Use sprintf or float_to_string result to avoid need to call strlen.
271 * data.c (Fnumber_to_string):
272 Use make_unibyte_string, since the string must be ASCII.
273 * lisp.h, print.c (float_to_string): Now returns int length.
274 * term.c (produce_glyphless_glyph):
275 Use sprintf result rather than recomputing it.
276
cf38a720
PE
277 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
278 * Makefile.in (ALL_CFLAGS):
279 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
280 * gmalloc.c, regex.c: Include <config.h> unconditionally.
281
3511c784
DA
2822012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
283
0a08eb21 284 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
285 strcasecmp if available.
286 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
287
fb7da12e
AS
2882012-06-25 Andreas Schwab <schwab@linux-m68k.org>
289
290 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
291 Avoid comma operator.
292 * menu.c (push_submenu_start, push_submenu_end)
293 (push_left_right_boundary, push_menu_pane): Likewise.
294 * msdos.c (dos_rawgetc): Likewise.
295
afa2ffd8
DA
2962012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
297
298 * xfns.c (xic_create_fontsetname): Remove redundant calls
299 to memset.
300
b3b4476b
PE
3012012-06-25 Paul Eggert <eggert@cs.ucla.edu>
302
4495ff38
PE
303 * gtkutil.c (get_utf8_string): Remove redundant assignment.
304 sprintf already null-terminates its output.
305
b3b4476b
PE
306 * xfns.c (x_window): Remove redundant cast.
307
b00876c9
DA
3082012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
309
310 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
311 `const char *' to `char *' to avoid compiler warning.
312
d188e26b
PE
3132012-06-24 Paul Eggert <eggert@cs.ucla.edu>
314
885d1d74
PE
315 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
316 instead of truncating it to 63 (admittedly a generous limit).
317
d188e26b
PE
318 * process.c: Fix spelling and caps in comments.
319
e2f560b1
DN
3202012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
321
e86db54b 322 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
323 * sysdep.c (setpgrp): Remove definition, not used in this file.
324
7583a3a1
JB
3252012-06-24 Juanma Barranquero <lekktu@gmail.com>
326
327 * makefile.w32-in: Update dependencies.
328
696056c2
EZ
3292012-06-24 Eli Zaretskii <eliz@gnu.org>
330
331 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
332 (SYSTIME_H): Add nt/inc/sys/time.h.
333
334 * systime.h [WINDOWSNT]: Include sys/time.h.
335
336 * s/ms-w32.h (struct timespec): Definition moved from
337 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
338
845ca893
PE
3392012-06-24 Paul Eggert <eggert@cs.ucla.edu>
340
341 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
342 * buffer.h (buffer_slot_type_mismatch):
343 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
344 * eval.c (unwind_to_catch):
345 * image.c (my_png_error, my_error_exit):
346 * keyboard.c (quit_throw_to_read_char, user_error)
347 (Fexit_recursive_edit, Fabort_recursive_edit):
348 * lisp.h (die, args_out_of_range, args_out_of_range_3)
349 (wrong_type_argument, buffer_overflow, __executable_start)
350 (memory_full, buffer_memory_full, string_overflow, Fthrow)
351 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
352 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
353 (fatal):
354 (child_setup) [!DOS_NT]:
355 * lread.c (end_of_file_error, invalid_syntax):
356 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
357 * puresize.h (pure_write_error):
358 * search.c (matcher_overflow):
359 * sound.c (sound_perror, alsa_sound_perror):
360 * sysdep.c, syssignal.h (croak):
361 * term.c (maybe_fatal, vfatal):
362 * textprop.c (text_read_only):
363 * undo.c (user_error):
364 * unexmacosx.c (unexec_error):
365 * xterm.c (x_ins_del_lines, x_delete_glyphs):
366 Use _Noreturn rather than NO_RETURN.
367 No need for separate decl merely because of _Noreturn.
368 * sound.c (sound_warning, parse_sound):
369 Remove unnecessary forward decls.
370
f1dd8073
PE
3712012-06-24 Paul Eggert <eggert@cs.ucla.edu>
372
373 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
374 * lisp.h (WAIT_READING_MAX): New macro.
375 * dispnew.c (Fsleep_for, sit_for):
376 * keyboard.c (kbd_buffer_get_event):
377 * process.c (Faccept_process_output):
378 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
379 This improves on the previous patch, which introduced a bug
380 when time_t is unsigned and as wide as intmax_t.
381 See <http://bugs.gnu.org/9000#51>.
382
b82c1755
EZ
3832012-06-23 Eli Zaretskii <eliz@gnu.org>
384
385 * dispnew.c (sit_for, Fsleep_for):
386 * keyboard.c (kbd_buffer_get_event):
387 * process.c (Faccept_process_output): Avoid compiler warnings when
388 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
389
ca300656
JB
3902012-06-23 Juanma Barranquero <lekktu@gmail.com>
391
049ec95b
JB
392 * makefile.w32-in: Update dependencies.
393
ca300656
JB
394 * w32.c (ltime): Add return type and declare static.
395 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
396
db7b8d06
PE
3972012-06-23 Paul Eggert <eggert@cs.ucla.edu>
398
399 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
400 Privately reported by Herbert J. Skuhra.
401 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
402 All uses changed.
403 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
404 not make_lisp_timeval, when the argument is of type EMACS_TIME.
405
0bd8297f
EZ
4062012-06-23 Eli Zaretskii <eliz@gnu.org>
407
96512555
EZ
408 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
409 last argument of make_unibyte_string.
410
0bd8297f
EZ
411 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
412 language ID in the event parameters.
413
414 * w32term.c (w32_read_socket): Put the new keyboard codepage into
415 event.code, not the obscure "character set ID".
416
63def6b6
CY
4172012-06-23 Chong Yidong <cyd@gnu.org>
418
419 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
420
e8a02204
EZ
4212012-06-23 Eli Zaretskii <eliz@gnu.org>
422
388cdec0
EZ
423 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
424 * w32.c (fdutimens): New function.
425
426 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
427
428 * s/ms-w32.h (pselect): Redirect to sys_select.
429
430 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
431
e8a02204
EZ
432 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
433 in the logic of incrementing and decrementing the value of
434 use_relocatable_buffers.
435
d054f3fb
PE
4362012-06-23 Paul Eggert <eggert@cs.ucla.edu>
437
438 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
439 Privately reported by Herbert J. Skuhra.
440 [__FreeBSD__]: Remove "*/" typo after "#include".
441 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
442 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
443 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
444 Don't assume EMACS_TIME and struct timeval are the same type.
445
d35af63c
PE
4462012-06-22 Paul Eggert <eggert@cs.ucla.edu>
447
448 Support higher-resolution time stamps (Bug#9000).
449 The time stamps are only nanosecond-resolution at the C level,
450 since that's the best that any real-world system supports now.
451 But they are picosecond-resolution at the Lisp level, as that's
452 easy, and leaves room for future OS improvements.
453
454 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
455 (LIBES): Use it.
456
457 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
458 Don't get current time unless it's needed.
459
460 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
461 now provides it if it's absent.
462 (start_atimer): Port to higher-res time stamps.
463 Check for time stamp overflow. Don't get current time more
464 often than is needed.
465
466 * buffer.h (struct buffer): Buffer modtime now has high resolution.
467 Include systime.h, not time.h.
468 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
469
470 * dired.c: Include stat-time.h.
471 (Ffile-attributes): File times now have higher resolution.
472
473 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
474 (struct image): Timestamp now has higher resolution.
475
476 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
477 has at least microseconds now. All uses removed.
478 (update_frame, update_single_window, update_window, update_frame_1)
479 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
480
481 * editfns.c (time_overflow): Now extern.
482 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
483 (float-time, Fformat_time_string, Fcurrent_time_string)
484 (Fcurrent_time_zone): Accept and generate higher-resolution
485 time stamps.
486 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
487 (decode_time_components, lisp_seconds_argument): New functions.
488 (make_time): Now static.
489 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
490 Report an error if the time is invalid, rather than having the caller
491 do that.
492
493 * fileio.c: Include <stat-time.h>
494 (Fcopy_file): Copy higher-resolution time stamps.
495 Prefer to set the time stamp via a file descriptor if that works.
496 (Fset_file_times, Finsert_file_contents, Fwrite_region)
497 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
498 (Fvisited_file_modtime, Fset_visited_file_modtime):
499 Support higher-resolution time stamps.
500
501 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
502
503 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
504
505 * image.c (prepare_image_for_display, clear_image_cache)
506 (lookup_image): Port to higer-resolution time stamps.
507
508 * keyboard.c (start_polling, bind_polling_period):
509 Check for time stamp overflow.
510 (read_char, kbd_buffer_get_event, timer_start_idle)
511 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
512 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
513 Port to higher-resolution time stamps. Do not assume time_t is signed.
514 (decode_timer): New function. Timers are now vectors of length 9,
515 not 8, to accommodate the picosecond component.
516 (timer_check_2): Use it.
517
518 * nsterm.m (select_timeout, timeval_subtract): Remove.
519 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
520 as they're a bit more accurate and handle overflow better.
521 (ns_select): Change prototype to be compatible with pselect.
522 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
523 * nsterm.h (ns_select): Adjust prototype.
524
525 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
526 us-resolution time stamps.
527 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
528
529 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
530
531 * lisp.h (time_overflow): New decl.
532 (wait_reading_process_output): First arg is now intmax_t, not int,
533 to accommodate larger waits.
534
535 * process.h (struct Lisp_Process.read_output_delay):
536 Now counts nanoseconds, not microseconds.
537 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
538 EMACS_HAS_USECS.
539 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
540 (wait_reading_process_output):
541 Port to ns-resolution time stamps.
542 (Faccept_process_output, wait_reading_process_output):
543 Check for time stamp overflow. Do not assume time_t is signed.
544 (select_wrapper): Remove; we now use pselect.
545 (Fprocess_attributes): Now generates ns-resolution time stamps.
546
547 * sysdep.c: Include utimens.h. Don't include utime.h
548 or worry about struct utimbuf; gnulib does that for us now.
549 (gettimeofday): Remove; gnulib provides a substitute.
550 (make_timeval): New function.
551 (set_file_times): Now sets ns-resolution time stamps.
552 New arg FD; all uses changed.
553 (time_from_jiffies, ltime_from_jiffies, get_up_time)
554 (system_process_attributes):
555 Now returns ns-resolution time stamp. All uses changed.
556 Check for time stamp overflow.
557
558 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
559 provides a substitute now.
560
561 * systime.h: Include timespec.h rather than sys/time.h and time.h,
562 since it guarantees struct timespec.
563 (EMACS_TIME): Now struct timespec, so that we can support
564 ns-resolution time stamps.
565 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
566 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
567 (EMACS_USECS): Remove.
568 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
569 so multiply the arg by 1000 before storing it.
570 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
571 New macros.
572 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
573 Port to ns-resolution time stamps.
574 (EMACS_TIME_NEG_P): Remove; replaced by....
575 (EMACS_TIME_SIGN): New macro.
576 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
577 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
578 (set_file_times, make_time, lisp_time_argument): Adjust signature.
579 (make_timeval, make_lisp_time, decode_time_components): New decls.
580 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
581 that it mishandled time_t overflow. You can't compare by subtracting!
582 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
583 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
584
585 * term.c: Include <sys/time.h>.
586 (timeval_to_Time): New function, for proper overflow wraparound.
587 (term_mouse_position, term_mouse_click): Use it.
588
589 * undo.c (record_first_change): Support higher-resolution time stamps
590 in the undo buffer.
591 (Fprimitive_undo): Use them when restoring time stamps.
592
593 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
594 (w32_get_internal_run_time):
595 Port to higher-resolution Emacs time stamps.
596 (ltime): Now accepts single 64-bit integer, as that's more convenient
597 for callers.
598
599 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
600
601 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
602 for compatibility with pselect. Support ns-resolution time stamps.
603
604 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
605
606 * xselect.c (wait_for_property_change, x_get_foreign_selection):
607 Check for time stamp overflow, and support ns-resolution time stamps.
608
609 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
610 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
611 (timeval_subtract): Remove; no longer needed.
612 (XTflash, XTring_bell, x_wait_for_event):
613 Port to ns-resolution time stamps. Don't assume time_t is signed.
614
b6a92dfe
CY
6152012-06-22 Chong Yidong <cyd@gnu.org>
616
617 * xdisp.c (x_consider_frame_title): Revert last change.
618
d251c37c
EZ
6192012-06-22 Eli Zaretskii <eliz@gnu.org>
620
621 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
622 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
623 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
624 staticidx goes up to 1597 out of 1600 = 0x640.)
625
f10deafb
PE
6262012-06-20 Paul Eggert <eggert@cs.ucla.edu>
627
628 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
629 Otherwise, the umask might be mistakenly 0 while handling input signals.
630
ec6de1e2
SM
6312012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
632
633 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
634
28be1ada
DA
6352012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
636
637 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
638 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
639 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
640 access to `contents' member of Lisp_Vector objects with AREF and ASET
641 where appropriate.
642
c6bf3022
CY
6432012-06-19 Chong Yidong <cyd@gnu.org>
644
645 * frame.c (delete_frame): When selecting a frame on a different
646 text terminal, do not alter the terminal's top-frame.
647
648 * xdisp.c (format_mode_line_unwind_data): Record the target
649 frame's selected window and its terminal's top-frame.
650 (unwind_format_mode_line): Restore them.
651 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
652 Callers changed.
653 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
654 since tty frames can be explicitly named.
655 (prepare_menu_bars): Likewise.
656
657 * term.c (Ftty_top_frame): New function.
658
defd4196
PE
6592012-06-18 Paul Eggert <eggert@cs.ucla.edu>
660
661 Port byte-code-meter to modern targets.
662 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
663 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 664 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
665 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
666 (METER_1, METER_2): Simplify.
667
1053a871
SM
6682012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
669
670 * data.c (Fdefalias): Return `symbol' (bug#11686).
671
b7e8d081
MR
6722012-06-18 Martin Rudalics <rudalics@gmx.at>
673
674 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
675 gets killed during executing of this function (Bug#11665).
676 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
677 (Vkill_buffer_query_functions): In doc-string say that functions
678 run by this hook should not change the current buffer.
679
7ea2b339
PE
6802012-06-18 Paul Eggert <eggert@cs.ucla.edu>
681
682 Fix recently-introduced process.c problems found by static checking.
683 * process.c (write_queue_push, write_queue_pop, send_process):
684 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
685 (write_queue_pop): Fix pointer signedness problem.
686 (send_process): Remove unused local.
687
96a313a1
CY
6882012-06-17 Chong Yidong <cyd@gnu.org>
689
690 * xdisp.c (redisplay_internal): No need to redisplay terminal
691 frames that are not on top.
692
20ca2e94
TN
6932012-06-17 Troels Nielsen <bn.troels@gmail.com>
694
695 * process.c (make_process): Initialize write_queue.
696 (write_queue_push, write_queue_pop): New functions.
697 (send_process): Use them to maintain correct ordering of process
698 writes (Bug#10815).
699
9a900ca9
PE
7002012-06-17 Paul Eggert <eggert@cs.ucla.edu>
701
310fbfa8
PE
702 * lisp.h (eassert): Assume C89 or later.
703 This removes the need for CHECK.
704 (CHECK): Remove. Its comments about always evaluating its
705 argument were confusing, as 'eassert' typically does not evaluate
706 its argument.
707
27bb1ca4
PE
708 * coding.c (produce_chars): Use ptrdiff_t, not int.
709
9a900ca9
PE
710 * xterm.c (x_draw_underwave): Check for integer overflow.
711 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
712
41b7f8bc 7132012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
714
715 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
716 referenced (Bug#11583).
717
9b0e3eba
AA
7182012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
719
720 Implement wave-style variant of underlining.
721 * dispextern.h (face_underline_type): New enum.
722 (face): Add field for underline type.
723 * nsterm.m (ns_draw_underwave): New function.
724 (ns_draw_text_decoration): Use it.
725 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
726 New functions.
727 (x_draw_glyph_string): Use them.
728 * xfaces.c (Qline, Qwave): New Lisp objects.
729 (check_lface_attrs, merge_face_ref)
1053a871
SM
730 (Finternal_set_lisp_face_attribute, realize_x_face):
731 Handle wave-style underline face attributes.
9b0e3eba
AA
732 * xterm.c (x_draw_underwave): New function.
733 (x_draw_glyph_string): Use it.
734
0fb52f11
JB
7352012-06-16 Juanma Barranquero <lekktu@gmail.com>
736
737 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
738 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
739 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
740 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
741 ($(BLD)/w32select.$(O)): Update dependencies.
742
e5560ff7
AS
7432012-06-16 Andreas Schwab <schwab@linux-m68k.org>
744
745 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
746 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
747 * character.c (_fetch_multibyte_char_p): Remove.
748 * alloc.c: Include "character.h" before "buffer.h".
749 * bidi.c: Likewise.
750 * buffer.c: Likewise.
751 * bytecode.c: Likewise.
752 * callint.c: Likewise.
753 * callproc.c: Likewise.
754 * casefiddle.c: Likewise.
755 * casetab.c: Likewise.
756 * category.c: Likewise.
757 * cmds.c: Likewise.
758 * coding.c: Likewise.
759 * composite.c: Likewise.
760 * dired.c: Likewise.
761 * dispnew.c: Likewise.
762 * doc.c: Likewise.
763 * dosfns.c: Likewise.
764 * editfns.c: Likewise.
765 * emacs.c: Likewise.
766 * fileio.c: Likewise.
767 * filelock.c: Likewise.
768 * font.c: Likewise.
769 * fontset.c: Likewise.
770 * fringe.c: Likewise.
771 * indent.c: Likewise.
772 * insdel.c: Likewise.
773 * intervals.c: Likewise.
774 * keyboard.c: Likewise.
775 * keymap.c: Likewise.
776 * lread.c: Likewise.
777 * macros.c: Likewise.
778 * marker.c: Likewise.
779 * minibuf.c: Likewise.
780 * nsfns.m: Likewise.
781 * nsmenu.m: Likewise.
782 * print.c: Likewise.
783 * process.c: Likewise.
784 * regex.c: Likewise.
785 * region-cache.c: Likewise.
786 * search.c: Likewise.
787 * syntax.c: Likewise.
788 * term.c: Likewise.
789 * textprop.c: Likewise.
790 * undo.c: Likewise.
791 * unexsol.c: Likewise.
792 * w16select.c: Likewise.
793 * w32fns.c: Likewise.
794 * w32menu.c: Likewise.
795 * window.c: Likewise.
796 * xdisp.c: Likewise.
797 * xfns.c: Likewise.
798 * xmenu.c: Likewise.
799 * xml.c: Likewise.
800 * xselect.c: Likewise.
801
2f07e6af
EZ
8022012-06-16 Eli Zaretskii <eliz@gnu.org>
803
1053a871
SM
804 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
805 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 806 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
807 row.
808 (handle_face_prop): Use chunk-relative overlay string index when
809 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
810 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
811 the rightmost. (Bug#11720)
2f07e6af 812
29b83cec
AS
8132012-06-16 Andreas Schwab <schwab@linux-m68k.org>
814
815 * category.h (CHAR_HAS_CATEGORY): Define as inline.
816 (CATEGORY_MEMBER): Enforce 1/0 value.
817 * category.c (_temp_category_set): Remove.
818
4c5501e9
EZ
8192012-06-16 Eli Zaretskii <eliz@gnu.org>
820
821 * window.c (Fdelete_other_windows_internal)
822 (Fdelete_window_internal): Don't access frame's mouse highlight
823 info of the initial frame. (Bug#11677)
824
2b570124
PE
8252012-06-14 Paul Eggert <eggert@cs.ucla.edu>
826
e93864f9
PE
827 * .gdbinit (xgetint): Fix recently-introduced paren typo.
828 Assume USE_2_TAGS_FOR_INTS.
829 (xreload): Adjust $tagmask width to match recent lisp.h change.
830
2b570124
PE
831 Simplify lisp.h in minor ways that should not affect code.
832 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
833 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
834 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
835 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
836 (INTTYPEBITS): New macro, for clarity.
837 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
838 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
839 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
840 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
841 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
842
81755f69
JB
8432012-06-13 Juanma Barranquero <lekktu@gmail.com>
844
845 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
846
16192a57
GM
8472012-06-13 Glenn Morris <rgm@gnu.org>
848
849 * s/bsd-common.h (BSD4_3):
850 * s/usg5-4-common.h (USG5_4): No longer define; unused.
851
646b5f55
AS
8522012-06-13 Andreas Schwab <schwab@linux-m68k.org>
853
854 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
855 instead of union.
856 (XLI, XIL): Define.
1053a871
SM
857 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
858 Use them.
859 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 860 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 861 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
862 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
863 * frame.c (delete_frame): Remove outdated comment.
864 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
865 USE_LISP_UNION_TYPE.
866 (Fw32_unregister_hot_key): Likewise.
867 (Fw32_toggle_lock_key): Likewise.
868 * w32menu.c (add_menu_item): Likewise.
869 (w32_menu_display_help): Use XIL instead of checking
870 USE_LISP_UNION_TYPE.
871 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
872 (init_heap): Likewise.
873 * w32term.c (w32_read_socket): Update comment.
874
1d3823c9
GM
8752012-06-13 Glenn Morris <rgm@gnu.org>
876
c62ff706
GM
877 * s/usg5-4-common.h, src/s/unixware.h:
878 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
879
1d3823c9
GM
880 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
881
bfe3e0a2
PE
8822012-06-13 Paul Eggert <eggert@cs.ucla.edu>
883
884 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
885 * alloc.c (make_number) [!defined make_number]:
886 Remove, as lisp.h always defines this now.
887 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
888 (roundup_size): Verify that it is a power of 2.
889 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
890 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
891 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
892 -DUSE_LSB_TAG=0, to override the automatically-selected default.
893 USE_LSB_TAG now is always defined to be either 0 or 1.
894 All uses changed.
895 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
896 code works fine either way, and efficiency is not a concern here,
897 as the union type is for debugging, not for production.
898 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
899 Use an inline function on all platforms when using the union type,
900 since this is simpler and 'static inline' can be used portably
901 within Emacs now.
902 (LISP_INITIALLY_ZERO): New macro.
903 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
904 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
905
45fa9c0f
GM
9062012-06-12 Glenn Morris <rgm@gnu.org>
907
b4492cba
GM
908 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
909
910 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 911
45fa9c0f
GM
912 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
913 Move BROKEN_SIGIO to configure.
914
915 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
916 Move NO_TERMIO to configure.
917
0e25d334
CY
9182012-06-12 Chong Yidong <cyd@gnu.org>
919
920 * image.c (imagemagick_load_image): Use MagickFlattenImage if
921 MagickMergeImageLayers is undefined. Use pixel pusher loop if
922 MagickExportImagePixels is undefined.
923
43682bb6
PE
9242012-06-12 Paul Eggert <eggert@cs.ucla.edu>
925
926 * image.c (imagemagick_load_image): Remove unused label.
927
a9be7d2b
GM
9282012-06-11 Glenn Morris <rgm@gnu.org>
929
930 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
931 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
932 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
933 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
934
3017f87f
SM
9352012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 * alloc.c (make_byte_code): New function.
938 (Fmake_byte_code): Use it. Don't purify here.
939 * lread.c (read1): Use it as well to avoid extra allocation.
940
1b9b4cf4
CY
9412012-06-11 Chong Yidong <cyd@gnu.org>
942
943 * image.c (imagemagick_load_image): Implement transparency.
944
95988fcf
AS
9452012-06-10 Andreas Schwab <schwab@linux-m68k.org>
946
947 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
948 account for preceding backslashes. (Bug#11663)
949
cd4eb164
CY
9502012-06-09 Chong Yidong <cyd@gnu.org>
951
952 * term.c: Support italics in capable terminals (Bug#9652).
953 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
954 (turn_on_face): Output using TS_enter_italic_mode if available.
955 Don't handle unused blinking and alt-charset cases.
956 (turn_off_face): Handle italic case; discard unused tty_blinking_p
957 and tty_alt_charset_p cases.
958 (tty_capable_p, init_tty): Support italics.
959
960 * termchar.h (struct tty_display_info): Add field for italics.
961 Remove unused blink field.
962
963 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
964 Handle slant.
965
966 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
967 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
968 tty_alt_charset_p. Add tty_italic_p.
969
ff88beb8
MA
9702012-06-09 Michael Albinus <michael.albinus@gmx.de>
971
972 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
973 dbus_type_is_basic if available.
974 (xd_extract_signed, xd_extract_unsigned): Rename from
975 extract_signed and extract_unsigned, respectively. Adapt callers.
976
44286096
CY
9772012-06-09 Chong Yidong <cyd@gnu.org>
978
1682701f
CY
979 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
980
44286096
CY
981 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
982 case (Bug#9752).
983
d86feb17
PE
9842012-06-08 Paul Eggert <eggert@cs.ucla.edu>
985
986 * xdisp.c (vmessage): Treat frame message as multibyte.
987 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
988 would generate the diagnostic "Making \302\247 buffer-local while
989 let-bound!".
990
d5c20fe8
EZ
9912012-06-08 Eli Zaretskii <eliz@gnu.org>
992
993 * dispnew.c (showing_window_margins_p): Undo last change, which
994 was done due to an inadvertent commit.
995 (adjust_frame_glyphs_for_frame_redisplay): Do call
996 showing_window_margins_p.
997
513749ee
SM
9982012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
999
1000 * eval.c (Fmake_var_non_special): New primitive.
1001 (syms_of_eval): Defsubr it.
1002 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1003
d4a8f5c1
JB
10042012-06-08 Juanma Barranquero <lekktu@gmail.com>
1005
1006 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1007 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1008
8bbbc977
EZ
10092012-06-08 Eli Zaretskii <eliz@gnu.org>
1010
1011 * alloc.c (allocate_vectorlike): Fix last change.
1012
f3372c87
DA
10132012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1014
1015 Block-based vector allocation of small vectors.
1016 * lisp.h (struct vectorlike_header): New field `nbytes',
1017 adjust comment accordingly.
1018 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1019 to denote vector blocks. Adjust users (live_vector_p,
1020 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1021 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1022 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1023 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1024 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1025 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1026 (roundup_size): New constant.
1027 (struct vector_block): New data type.
1028 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1029 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1030 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1031 (sweep_vectors): New functions.
1032 (allocate_vectorlike): Return `zero_vector' as the only vector of
1033 0 items. Allocate new vector from block if vector size is less than
1034 or equal to VBLOCK_BYTES_MAX.
1035 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1036 (init_alloc_once): Add call to init_vectors.
1037
4f18a4ed
SM
10382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1039
1040 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1041
86f158bc
PE
10422012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1043
1044 * doprnt.c (doprnt): Truncate multibyte char correctly.
1045 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1046 would mishandle a string argument "Xc" if X was a multibyte
1047 character of length 2: it would truncate after X's first byte
1048 rather than including all of X.
1049
c5cfcbe0
CY
10502012-06-06 Chong Yidong <cyd@gnu.org>
1051
1052 * buffer.c (word_wrap): Doc fix.
1053
c05cf390
PE
10542012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1057
0c3461de
GM
10582012-06-03 Glenn Morris <rgm@gnu.org>
1059
1060 * xdisp.c (tool-bar-style): Doc fix.
1061
c71232db
UM
10622012-06-03 Ulrich Müller <ulm@gentoo.org>
1063
1064 * Makefile.in (PAXCTL): Define.
1065 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1066 binary via PaX flags if the paxctl utility is available.
1067 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1068 Restore PaX flags to their default. (Bug#11398)
1069
383f7350
CY
10702012-06-03 Chong Yidong <cyd@gnu.org>
1071
1072 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1073 buffer (Bug#11226).
1074
5f2c76c6
CY
10752012-06-03 Chong Yidong <cyd@gnu.org>
1076
1077 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1078 (note_mode_line_or_margin_highlight): If there is no help echo,
1079 use mode-line-default-help-echo. Handle the case where the mouse
1080 position is past the end of the mode line string.
1081
1082 * buffer.c (buffer_local_value_1): New function, split from
1083 Fbuffer_local_value; can return Qunbound.
1084 (Fbuffer_local_value): Use it.
1085 (Vmode_line_format): Docstring tweaks.
1086
773d47f6
PE
10872012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 * sysdep.c (system_process_attributes): Improve comment.
1090
f2d6a3df
SM
10912012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1092
1093 * keyboard.c: Export real-this-command to Elisp.
1094 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1095 and DEFVAR it. Update all users.
1096
63810350
PE
10972012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1098
7bd5c1f4
PE
1099 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1100
63810350
PE
1101 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1102 Convert pctcpu and pctmem to Lisp float properly.
1103 Let the compiler fold better, as 100.0/0x8000 is exact.
1104
a2821611
AS
11052012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1106
1107 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1108 cons_block.
1109
5fceba1d
PE
11102012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1111
1112 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1113
c98ff5dd
DA
11142012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1115
1116 For a 'struct window', replace some Lisp_Object fields to
1117 bitfields where appropriate, remove unused fields.
1118 * window.h (struct window): Remove unused 'last_mark_x' and
1119 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1120 change it's type from Lisp_Object to bitfield.
1121 Change type of 'force_start', 'optional_new_start',
1122 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1123 fields from Lisp_Object to bitfield. Adjust users accordingly.
1124
ca34e0be
PE
11252012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 Pacify gcc -Wdouble-precision when using Xaw.
1128 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1129 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1130 Use 'float' consistently, rather than 'float' in most places
1131 and 'double' in a couple of places.
1132
efc00ab1 11332012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1134
1135 * xdisp.c (handle_stop): Detect whether we have overlay strings
1136 loaded by testing it->current.overlay_string_index to be
1137 non-negative, instead of checking whether n_overlay_strings is
1138 positive. (Bug#11587)
1139
efc00ab1 11402012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1141
1142 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1143
1144 * doc.c (Fsubstitute_command_keys): Doc fix.
1145
efc00ab1 11462012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1147
1148 * search.c (search_buffer): Remove calls to
1149 r_alloc_inhibit_buffer_relocation, as it is now called by
1150 maybe_unify_char, which was the cause of relocation of buffer text
1151 in bug#11519.
1152
efc00ab1 11532012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1154
1155 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1156 for the duration of call to load_charset, to avoid problems with
1157 callers of maybe_unify_char that access buffer text through C
1158 pointers.
1159
1160 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1161 decrement the inhibition flag, instead of just setting or
1162 resetting it.
1163
ba93a187
PE
11642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1165
1166 Remove obsolete '#define static' cruft.
1167 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1168 This #undef was "temporary" in 2000; it is no longer needed
1169 now that '#define static' has gone away.
1170 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1171 (gray_bitmap_bits): Remove; no longer needed.
1172 All uses replaced with definiens.
1173 * xterm.c: Include "bitmaps/gray.xbm".
1174
9e4bf381
PE
11752012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 Clean up __executable_start, monstartup when --enable-profiling.
1178 The following changes affect the code only when profiling.
1179 * dispnew.c (__executable_start): Rename from safe_bcopy.
1180 Define only on platforms that need it.
1181 * emacs.c: Include <sys/gmon.h> when profiling.
1182 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1183 (__executable_start): Remove decl, since lisp.h does it now.
1184 (safe_bcopy): Remove decl; no longer has that name.
1185 (main): Coalesce #if into single bit of code, for simplicity.
1186 Cast pointers to uintptr_t, since standard libraries want integers
1187 and not pointers.
1188 * lisp.h (__executable_start): New decl.
1189
32d72c2f
GM
11902012-05-31 Glenn Morris <rgm@gnu.org>
1191
1192 * image.c (Fimagemagick_types): Doc fix.
1193
baac5bc7
JM
11942012-05-30 Jim Meyering <meyering@redhat.com>
1195
1196 * callproc.c (Fcall_process_region): Include directory component
1197 in mkstemp error message (Bug#11586).
1198
72cb32cf
PE
11992012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * alloc.c, lisp.h (make_pure_vector): Now static.
1202
61b108cc
SM
12032012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1204
1205 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1206 Move to byte-run.el.
1207 (Fautoload): Do the hash-doc more carefully.
1208 * data.c (Fdefalias): Purify definition, except for keymaps.
1209 (Qdefun): Move from eval.c.
1210 * lisp.h (Qdefun): Remove.
1211 * lread.c (read1): Tiny simplification.
1212
471fe23d
TN
12132012-05-29 Troels Nielsen <bn.troels@gmail.com>
1214
934f3f58 1215 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1216 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1217 Bug#9642, but explicitly check that the buffer the overlay would
1218 be moved to is live and rearrange lines to make sure that errors
1219 will not put the overlay in an inconsistent state.
1220 (Fdelete_overlay): Cosmetics.
1221
85d0efd1
EZ
12222012-05-28 Eli Zaretskii <eliz@gnu.org>
1223
1224 * w32term.c (my_bring_window_to_top): New function.
1225 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1226 could be different from the original one.
1227 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1228 (Bug#11513)
1229
1230 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1231 by calling BringWindowToTop.
1232
1233 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1234 (WM_EMACS_END): Increase by one.
1235
da92a98c
PE
12362012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1239 This avoids undefined behavior that might cause the eassert
1240 to not catch an out-of-range value.
1241
74d1f848
JB
12422012-05-28 Juanma Barranquero <lekktu@gmail.com>
1243
1244 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1245 Update dependencies.
1246
9e1a06fc
EZ
12472012-05-27 Eli Zaretskii <eliz@gnu.org>
1248
1249 * bidi.c (bidi_mirror_char): Fix last change.
1250
f3dd7312
AS
12512012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1252
1253 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1254 when referring to sectname field in printf format.
1255
81899c91
PE
12562012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1257
57b81a9f
PE
1258 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1259 Only r_alloc_inhibit_buffer_relocation needed to be added;
1260 the others were already declared.
1261
81899c91
PE
1262 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1263 before checking whether it's out of range. Put the check inside
1264 eassert. See
1265 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1266
33017faf 12672012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1268
1269 * callproc.c (Fcall_process): Restore a line that was accidentally
1270 commented out in the 2011-02-13 change (bug#11547).
1271
33017faf 12722012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1273
1274 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1275 defined on ralloc.c.
1276
1277 * buffer.c [REL_ALLOC]: Remove prototypes of
1278 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1279 they are now on lisp.h.
1280
1281 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1282
1283 * search.c (search_buffer): Use it to inhibit relocation of buffer
1284 text while re_search_2 is doing its job, because re_search_2 is
1285 passed C pointers to buffer text. (Bug#11519)
1286
23415acf
EZ
1287 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1288 Update value to 24.
1289
44e27368
EZ
1290 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1291 state after an additional call to move_it_in_display_line_to, keep
1292 the values of it->max_ascent and it->max_descent found for the
1293 entire line.
1294 (pos_visible_p): Revert the comparison against bottom_y to what it
1295 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1296 (Bug#11464)
1297
c1892f11
PE
12982012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 Fix coding-related core dumps with gcc -ftrapv.
1301 The code was computing A - B, where A and B are pointers, and B is
1302 random garbage. This can lead to core dumps on platforms that
1303 have special pointer registers, and it also leads to core dumps on
1304 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1305 A - B only when B is initialized properly.
1306 * coding.c (coding_set_source, coding_set_destination): Return void.
1307 (coding_change_source, coding_change_destinations): New functions,
1308 with the old behaviors of coding_set_source and coding_set_destination.
1309 All callers that need an offset changed to use these new functions.
1310
eb7afdad
GM
13112012-05-26 Glenn Morris <rgm@gnu.org>
1312
1313 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1314
f12fdf02
EZ
13152012-05-26 Eli Zaretskii <eliz@gnu.org>
1316
53a63be6 1317 Extend mouse support on W32 text-mode console.
61b108cc
SM
1318 * xdisp.c (draw_row_with_mouse_face):
1319 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1320
eb3f6f01 1321 * w32console.c: Include window.h.
61b108cc
SM
1322 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1323 New functions.
eb3f6f01
EZ
1324 (initialize_w32_display): Initialize mouse-highlight data.
1325
53a63be6
EZ
1326 * w32inevt.c: Include termchar.h and window.h.
1327 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1328 moves, call note_mouse_highlight. If help_echo changed, call
1329 gen_help_event to produce help-echo message in the echo area.
1330 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1331 highlight info.
1332
4cfd81f6
PE
13332012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1334
1335 * lread.c (read1): Simplify slightly to avoid an overflow warning
1336 with GCC 4.7.0 on x86-64.
1337
4446092a
EZ
13382012-05-26 Eli Zaretskii <eliz@gnu.org>
1339
1340 * bidi.c (bidi_mirror_char): Revert last change: an int is
1341 definitely wide enough here.
1342
42b2a986 13432012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1344
42b2a986 1345 Fix integer width and related bugs (Bug#9874).
eb106a49 1346 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1347 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1348 (string_bytes, check_sblock, allocate_string_data):
1349 (compact_small_strings, Fmake_bool_vector, make_string)
1350 (make_unibyte_string, make_multibyte_string)
1351 (make_string_from_bytes, make_specified_string)
1352 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1353 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1354 (mark_vectorlike):
1355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1356 (allocate_pseudovector):
1357 Use int, not EMACS_INT, where int is wide enough.
1358 (inhibit_garbage_collection, Fgarbage_collect):
1359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1360 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1361 int might not be wide enough.
1362 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1363 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1364 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1365 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1366 (bidi_level_of_next_char, bidi_move_to_visually_next):
1367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1368 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1369 (Fkill_buffer, Fset_buffer_major_mode)
1370 (advance_to_char_boundary, Fbuffer_swap_text)
1371 (Fset_buffer_multibyte, overlays_at, overlays_in)
1372 (overlay_touches_p, struct sortvec, record_overlay_string)
1373 (overlay_strings, recenter_overlay_lists)
1374 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1375 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1376 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1377 (Foverlay_recenter, last_overlay_modification_hooks_used)
1378 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1380 (validate_region): Omit unnecessary test for b <= e,
1381 since that's guaranteed by the previous test.
d311d28c
PE
1382 (adjust_overlays_for_delete): Avoid pos + length overflow.
1383 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1384 (report_overlay_modification):
1385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1386 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1387 Omit pointer cast, which isn't needed anyway, and doesn't work
1388 after the EMACS_INT -> ptrdiff_t change.
02481186 1389 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1390 * buffer.h: Adjust decls to match defn changes elsewhere.
1391 (struct buffer_text, struct buffer):
1392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1393 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1394 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1395 not int, to avoid needless 32-bit limit on 64-bit hosts.
1396 (exec_byte_code): Use tighter memory-full test, one that checks
1397 for alloca overflow. Don't compute the address of the object just
1398 before an array, as that's not portable. Use EMACS_INT, not
1399 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1400 * callint.c (Fcall_interactively):
1401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1402 * callproc.c (call_process_kill, Fcall_process):
1403 Don't assume pid_t fits into an Emacs fixnum.
1404 (call_process_cleanup, Fcall_process, child_setup):
1405 Don't assume pid_t fits into int.
1406 (call_process_cleanup, Fcall_process, delete_temp_file)
1407 (Fcall_process_region):
1408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1409 (Fcall_process): Simplify handling of volatile integers.
1410 Use int, not EMACS_INT, where int will do.
1411 * casefiddle.c (casify_object, casify_region, operate_on_word)
1412 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1414 (casify_object): Avoid integer overflow when overallocating buffer.
1415 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1416 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1417 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1418 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1419 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1420 integers are now checked earlier. All uses replaced with XINT.
1421 (ccl_driver):
1422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1423 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1424 (ccl_driver, Fregister_code_conversion_map):
1425 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1426 (resolve_symbol_ccl_program): Check that vector header is in range.
1427 Always copy the vector, so that we can check its contents reliably
1428 now rather than having to recheck each instruction as it's being
1429 executed. Check that vector words fit in 'int'.
1430 (ccl_get_compiled_code, Fregister_ccl_program)
1431 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1432 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1433 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1434 contents are in range.
1435 (Fccl_execute_on_string): Check that status is in range.
1436 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1437 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1438 Accept and return EMACS_INT, not int, because callers can pass values
1439 out of 'int' range.
1440 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1441 (multibyte_chars_in_text, parse_str_as_multibyte)
1442 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1443 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1444 (string_escape_byte8, Fget_byte):
1445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1446 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1447 avoid mishandling large integers.
1448 * character.h: Adjust decls to match defn changes elsewhere.
1449 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1450 (Ffind_charset_region):
1451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1452 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1453 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1454 Don't assume fixnum fits in int.
d311d28c
PE
1455 (load_charset_map_from_vector, Fmap_charset_chars):
1456 Remove now-unnecessary CHECK_NATNUMs.
1457 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1458 Don't rely on undefined behavior with signed left shift overflow.
1459 Don't assume unsigned int fits into fixnum, or that fixnum fits
1460 into unsigned int. Don't require max_code to be a valid fixnum;
1461 that's not true for gb10830 4-byte on a 32-bit host. Allow
1462 invalid_code to be a cons, for the same reason. Require code_offset
1463 to be a character. Avoid int overflow if max_char is close
1464 to INT_MAX.
1465 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1466 this is intended anyway and avoids some undefined behavior.
1467 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1468 INDEX_TO_CODE_POINT, as that's what it expects.
1469 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1470 * charset.h (DECODE_CHAR): Return int, not unsigned;
1471 this is what was intended anyway, and it avoids undefined behavior.
1472 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1473 integer-overflow issues.
1474 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1475 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1476 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1477 * chartab.c (Fmake_char_table, Fset_char_table_range)
1478 (uniprop_get_decoder, uniprop_get_encoder):
1479 Don't assume fixnum fits in int.
1480 * cmds.c (move_point): New function, that does the gist of
1481 Fforward_char and Fbackward_char, but does so while checking
1482 for integer overflow more accurately.
c96e5d6a 1483 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1484 (Fforward_line, Fend_of_line, internal_self_insert)
1485 (internal_self_insert):
1486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1487 Fix a FIXME, by checking for integer overflow when calculating
1488 target_clm and actual_clm.
1489 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1490 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1491 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1492 (coding_alloc_by_making_gap, alloc_destination)
1493 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1494 (encode_coding_utf_16, detect_coding_emacs_mule)
1495 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1496 (detect_coding_iso_2022, decode_coding_iso_2022)
1497 (encode_invocation_designation, encode_designation_at_bol)
1498 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1499 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1500 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1501 (encode_coding_ccl, encode_coding_raw_text)
1502 (detect_coding_charset, decode_coding_charset)
1503 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1504 (produce_composition, produce_charset, produce_annotation)
1505 (decode_coding, handle_composition_annotation)
1506 (handle_charset_annotation, consume_chars, decode_coding_gap)
1507 (decode_coding_object, encode_coding_object, detect_coding_system)
1508 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1509 (code_convert_region, code_convert_string)
8f50130c
PE
1510 (Fdefine_coding_system_internal)
1511 (coding_set_source, coding_set_destination):
d311d28c
PE
1512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1513 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1514 (Fdefine_coding_system_internal):
1515 Don't assume fixnums fit in int.
1516 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1517 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1518 (Funencodable_char_position, Fcheck_coding_systems_region)
1519 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1521 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1522 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1523 Don't access memory outside of the args array.
d311d28c 1524 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1525 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1526 result of ENCODE_CHAR.
d311d28c
PE
1527 * coding.h: Adjust decls to match defn changes elsewhere.
1528 (struct coding_system):
1529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1530 * composite.c (get_composition_id, find_composition)
1531 (run_composition_function, update_compositions)
1532 (compose_text, composition_gstring_put_cache)
1533 (composition_gstring_p, composition_gstring_width)
1534 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1535 (composition_compute_stop_pos, composition_reseat_it)
1536 (composition_update_it, struct position_record)
1537 (find_automatic_composition, composition_adjust_point)
1538 (Fcomposition_get_gstring, Ffind_composition_internal):
1539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1540 (update_compositions):
1541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1542 * composite.h: Adjust decls to match defn changes elsewhere.
1543 (struct composition):
1544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1545 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1546 Do not attempt to compute the address of the object just before a
1547 buffer; this is not portable.
1548 (Faref, Faset):
1549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1550 (Faset): Use int, not EMACS_INT, where int is wide enough.
1551 (Fstring_to_number): Don't assume fixnums fit in int.
1552 (Frem): Don't assume arg is nonnegative.
1553 * dbusbind.c (xd_append_arg): Check for integers out of range.
1554 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1555 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1556 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1557 (xd_get_connection_references): Return ptrdiff_t, not int.
1558 All uses changed.
1559 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1560 (xd_read_message_1):
1561 Use int, not unsigned, where the dbus API uses int.
1562 (Fdbus_message_internal): Don't overflow mtype.
1563 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1564 * dired.c (directory_files_internal, file_name_completion, scmp)
1565 (file_name_completion_stat):
1566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1567 (file_name_completion): Don't overflow matchcount.
1568 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1569 * dispextern.h: Adjust decls to match defn changes elsewhere.
1570 (struct text_pos, struct glyph, struct bidi_saved_info)
1571 (struct bidi_string_data, struct bidi_it, struct composition_it)
1572 (struct it):
1573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1574 (struct display_pos, struct composition_it, struct it):
1575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1576 * dispnew.c (increment_matrix_positions)
1577 (increment_row_positions, mode_line_string)
1578 (marginal_area_string):
1579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1580 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1582 (duration_to_sec_usec): New function, to check for overflow better.
1583 (Fsleep_for, sit_for): Use it.
1584 * doc.c (get_doc_string, store_function_docstring):
1585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1586 (get_doc_string, Fsnarf_documentation):
1587 Use int, not EMACS_INT, where int is wide enough.
1588 (get_doc_string):
1589 Use SAFE_ALLOCA, not alloca.
1590 Check for overflow when converting EMACS_INT to off_t.
1591 * doprnt.c (doprnt):
1592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1593 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1594 Don't assume uid_t fits into fixnum.
1595 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1596 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1597 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1598 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1599 (general_insert_function)
1600 (Finsert_char, make_buffer_string, make_buffer_string_both)
1601 (update_buffer_properties, Fbuffer_substring)
1602 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1603 (Fsubst_char_in_region, check_translation)
1604 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1605 (transpose_markers, Ftranspose_regions):
1606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1607 (clip_to_bounds): Move to lisp.h as an inline function).
1608 (Fconstrain_to_field): Don't assume integers are nonnegative.
1609 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1610 (Fsubst_char_in_region, Fsave_restriction):
1611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1612 (Femacs_pid): Don't assume pid_t fits into fixnum.
1613 (lo_time): Use int, not EMACS_INT, when int suffices.
1614 (lisp_time_argument): Check for usec out of range.
1615 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1616 (Fuser_login_name, Fuser_full_name): Signal an error
1617 if a uid argument is out of range, rather than relying on
1618 undefined behavior.
c8d5c857
PE
1619 (Fformat_time_string): Remove now-unnecessary check.
1620 lisp_time_argument checks for out-of-range usec now.
243e0530 1621 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1622 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1623 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1624 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1625 (init_cmdargs, Fdump_emacs):
1626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1627 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1628 the bottom (typically) 32 bits of the fixnum.
1629 * eval.c (specpdl_size, call_debugger):
1630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1631 (when_entered_debugger, Fbacktrace_debug):
1632 Don't assume fixnum can fit in int.
1633 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1634 the object just before a buffer; this is not portable.
1635 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1636 (grow_specpdl, unbind_to):
1637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1638 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1639 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1640 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1641 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1642 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1644 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1645 (a_write, e_write):
1646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1647 (Fcopy_file, non_regular_nbytes, read_non_regular)
1648 (Finsert_file_contents):
1649 Use int, not EMACS_INT, where int is wide enough.
1650 (READ_BUF_SIZE): Verify that it fits in int.
1651 (Finsert_file_contents): Check that counts are in proper range,
1652 rather than assuming fixnums fit into ptrdiff_t etc.
1653 Don't assume fixnums fit into int.
125b3835 1654 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1655 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1656 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1657 (string_char_to_byte, string_byte_to_char)
1658 (string_make_multibyte, string_to_multibyte)
1659 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1660 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1661 (substring_both, Fdelete, internal_equal, Ffillarray)
1662 (Fclear_string, mapcar1)
1663 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1664 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1665 (larger_vector, make_hash_table, maybe_resize_hash_table)
1666 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1667 (Fmaphash, secure_hash):
1668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1669 (concat): Check for string index and length overflow.
1670 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1671 (Frequire):
1672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1673 (larger_vector): New API (vec, incr_min, size_max) replaces old
1674 one (vec, new_size, init). This catches size overflow.
1675 INIT was removed because it was always Qnil.
1676 All callers changed.
1677 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1678 the upper bound on a hash table index size.
1679 (make_hash_table, maybe_resize_hash_table): Use it.
1680 (secure_hash): Computer start_byte and end_byte only after
1681 they're known to be in ptrdiff_t range.
1682 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1683 (Ffont_get_glyphs, Ffont_at):
1684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1685 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1686 (Flist_fonts, Fopen_font):
1687 Don't assume fixnum can fit in int.
1688 (check_gstring): Don't assume index can fit in int.
1689 (font_match_p): Check that fixnum is a character, not a nonnegative
1690 fixnum, since the later code needs to stuff it into an int.
1691 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1692 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1693 conversion overflow issues.
1694 (Fopen_font): Check for integer out of range.
1695 (Ffont_get_glyphs): Don't assume index can fit in int.
1696 * font.h: Adjust decls to match defn changes elsewhere.
1697 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1698 integer overflow.
1699 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1700 printmax_t, where ptrdiff_t is wide enough.
1701 (Finternal_char_font):
1702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1703 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1704 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1705 (Fset_frame_position, x_set_frame_parameters)
1706 (x_set_line_spacing, x_set_border_width)
1707 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1708 Check that fixnums are in proper range for system types.
1709 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1711 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1712 Use SAFE_ALLOCA_LISP, not alloca.
1713 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1714 intptr_t is wide enough.
1715 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1716 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1717 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1718 Check for fixnum out of range.
1719 * ftfont.c (ftfont_list): Don't assume index fits in int.
1720 Check that fixnums are in proper range for system types.
1721 (ftfont_shape_by_flt):
1722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1723 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1725 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1726 Check that fixnums are in proper range for system types.
1727 * gnutls.h: Adjust decls to match defn changes elsewhere.
1728 * gtkutil.c (xg_dialog_run):
1729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1730 (update_frame_tool_bar):
1731 Check that fixnums are in proper range for system types.
1732 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1733 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1734 * indent.c (last_known_column, last_known_column_point):
1735 (current_column_bol_cache):
1736 (skip_invisible, current_column, check_display_width):
1737 (check_display_width, scan_for_column, current_column_1)
1738 (Findent_to, Fcurrent_indentation, position_indentation)
1739 (indented_beyond_p, Fmove_to_column, compute_motion):
1740 (Fcompute_motion, Fvertical_motion):
1741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1742 (last_known_column_modified): Use EMACS_INT, not int.
1743 (check_display_width):
1744 (Fcompute_motion):
1745 Check that fixnums and floats are in proper range for system types.
1746 (compute_motion): Don't assume index or fixnum fits in int.
1747 (compute_motion, Fcompute_motion):
1748 Use int, not EMACS_INT, when it is wide enough.
1749 (vmotion): Omit local var start_hpos that is always 0; that way
1750 we don't need to worry about overflow in expressions involving it.
1751 * indent.h: Adjust decls to match defn changes elsewhere.
1752 (struct position):
1753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1754 Use int, not EMACS_INT, where int is wide enough.
1755 Remove unused members ovstring_chars_done and tab_offset;
1756 all uses removed.
1757 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1758 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1759 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1760 (make_gap, copy_text, insert, insert_and_inherit)
1761 (insert_before_markers, insert_before_markers_and_inherit)
1762 (insert_1, count_combining_before, count_combining_after)
1763 (insert_1_both, insert_from_string)
1764 (insert_from_string_before_markers, insert_from_string_1)
1765 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1766 (adjust_after_replace, adjust_after_insert, replace_range)
1767 (replace_range_2, del_range, del_range_1, del_range_byte)
1768 (del_range_both, del_range_2, modify_region)
1769 (prepare_to_modify_buffer, signal_before_change)
1770 (signal_after_change, Fcombine_after_change_execute):
1771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1772 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1773 (balance_an_interval, split_interval_right, split_interval_left)
1774 (find_interval, next_interval, update_interval)
1775 (adjust_intervals_for_insertion, delete_node, delete_interval)
1776 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1777 (static_offset_intervals, offset_intervals)
1778 (merge_interval_right, merge_interval_left, make_new_interval)
1779 (graft_intervals_into_buffer, temp_set_point_both)
1780 (temp_set_point, set_point, adjust_for_invis_intang)
1781 (set_point_both, move_if_not_intangible, get_property_and_range)
1782 (get_local_map, copy_intervals, copy_intervals_to_string)
1783 (compare_string_intervals, set_intervals_multibyte_1):
1784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1785 * intervals.h: Adjust decls to match defn changes elsewhere.
1786 (struct interval):
1787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1788 * keyboard.c (this_command_key_count, this_single_command_key_start)
1789 (before_command_key_count, before_command_echo_length, echo_now)
1790 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1791 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1792 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1793 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1795 (last_non_minibuf_size, last_point_position, echo_truncate)
1796 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1797 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1798 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1799 (stuff_buffered_input):
1800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1801 (last_auto_save, command_loop_1, read_char):
1802 Use EMACS_INT, not int, to avoid integer overflow.
1803 (record_char): Avoid overflow in total_keys computation.
1804 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1805 * keyboard.h: Adjust decls to match defn changes elsewhere.
1806 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1807 (Fkey_description, Fdescribe_vector, Flookup_key):
1808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1809 (click_position): New function, to check that positions are in range.
1810 (Fcurrent_active_maps):
1811 (describe_command):
1812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1813 (Faccessible_keymaps, Fkey_description):
1814 (preferred_sequence_p):
1815 Don't assume fixnum can fit into int.
1816 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1817 Check for integer overflow in size calculations.
1818 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1819 avoid mishandling large integers.
1820 * lisp.h: Adjust decls to match defn changes elsewhere.
1821 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1822 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1823 (struct Lisp_Marker):
1824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1825 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1826 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1827 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1828 All callers changed.
1829 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1830 Assume the arg has valid form, since it always does.
1831 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1832 unsigned integer system type.
1833 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1834 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1836 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1837 (duration_to_sec_usec): New decl.
1838 * lread.c (read_from_string_index, read_from_string_index_byte)
1839 (read_from_string_limit, readchar, unreadchar, openp)
1840 (read_internal_start, read1, oblookup):
1841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1842 (Fload, readevalloop, Feval_buffer, Feval_region):
1843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1844 (openp): Check for out-of-range argument to 'access'.
1845 (read1): Use int, not EMACS_INT, where int is wide enough.
1846 Don't assume fixnum fits into int.
6efdadfd 1847 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1848 (read_filtered_event): Use duration_to_sec_usec
1849 to do proper overflow checking on durations.
d311d28c
PE
1850 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1851 in size calculation.
1852 (Fexecute_kbd_macro):
1853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1854 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1855 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1856 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1857 (set_marker_both, set_marker_restricted_both, marker_position)
1858 (marker_byte_position, Fbuffer_has_markers_at):
1859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1860 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1861 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1862 It now merely ensures that the menu is large enough, without
1863 necessarily growing it, as this avoids some integer overflow issues.
1864 All callers changed.
1865 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1867 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1868 Use SAFE_ALLOCA_LISP, not alloca.
1869 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1870 to EMACS_INT. Check that fixnums are in proper range for system types.
1871 * minibuf.c (minibuf_prompt_width, string_to_object)
1872 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1873 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1875 (get_minibuffer, read_minibuf_unwind):
1876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1877 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1878 this simplifies overflow checking. All callers changed.
1879 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1880 (Ftest_completion):
1881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1882 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1883 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1884 Check that fixnums are in proper range for system types.
1885 (Fx_create_frame, Fx_show_tip):
1886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1887 * nsfont.m (ns_findfonts, nsfont_list_family):
1888 Don't assume fixnum fits in long.
1889 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1891 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1892 wide enough.
17fdb222 1893 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1895 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1896 (PRINTDECLARE, PRINTPREPARE):
1897 (strout, print_string):
1898 (print, print_preprocess, print_check_string_charset_prop)
1899 (print_object):
1900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1901 (PRINTDECLARE):
1902 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1904 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1905 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1906 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1907 (print_error_message): Use SAFE_ALLOCA, not alloca.
1908 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1909 (print_depth, new_backquote_output, print_number_index):
1910 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1911 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1912 (Fset_process_window_size, Fformat_network_address)
1913 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1914 (sigchld_handler):
d311d28c 1915 Check that fixnums are in proper range for system types.
d44287d4 1916 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1917 Check for process-ids out of pid_t range rather than relying on
1918 undefined behavior.
e4d81efc 1919 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1920 (Fformat_network_address, read_process_output, send_process)
1921 (Fprocess_send_region, status_notify):
1922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1923 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1924 (wait_reading_process_output, read_process_output, exec_sentinel):
1925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1926 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1927 (Faccept_process_output): Use duration_to_sec_usec to do proper
1928 overflow checking on durations.
dde14581
PE
1929 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1930 Don't assume pid_t fits in int.
02481186
PE
1931 * process.h (struct Lisp_Process): Members tick and update_tick
1932 are now of type EMACS_INT, not int.
b62b53e8
PE
1933 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1934 configured --with-wide-int.
d311d28c
PE
1935 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1936 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1937 * search.c (looking_at_1, string_match_1):
1938 (fast_string_match, fast_c_string_match_ignore_case)
1939 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1940 (scan_newline, find_before_next_newline, search_command)
1941 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1942 (set_search_regs, wordify):
1943 (Freplace_match):
1944 (Fmatch_data):
1945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1946 (string_match_1, search_buffer, set_search_regs):
1947 (Fmatch_data):
1948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1949 (wordify): Check for overflow in size calculation.
1950 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1951 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1952 Check that fixnums are in proper range for system types.
1953 * sound.c (struct sound_device)
1954 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1956 (Fplay_sound_internal):
1957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1958 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1959 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1960 (Fparse_partial_sexp):
1961 Don't assume fixnums can fit in int.
1962 (struct lisp_parse_state, find_start_pos, find_start_value)
1963 (find_start_value_byte, find_start_begv)
1964 (update_syntax_table, char_quoted, dec_bytepos)
1965 (find_defun_start, prev_char_comend_first, back_comment):
1966 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1967 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1969 (Finternal_describe_syntax_value): Check that match_lisp is a
1970 character, not an integer, since the code stuffs it into int.
1971 (scan_words, scan_sexps_forward):
1972 Check that fixnums are in proper range for system types.
1973 (Fforward_word):
1974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1975 (scan_sexps_forward):
1976 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1977 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1978 * syntax.h: Adjust decls to match defn changes elsewhere.
1979 (struct gl_state_s):
1980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1981 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1982 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1983 * sysdep.c (wait_for_termination_1, wait_for_termination)
1984 (interruptible_wait_for_termination, mkdir):
1985 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1986 (emacs_read, emacs_write):
1987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1988 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1989 and double all fit in int.
d311d28c
PE
1990 * term.c (set_tty_color_mode):
1991 Check that fixnums are in proper range for system types.
1992 * termhooks.h (struct input_event):
1993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1994 * textprop.c (validate_interval_range, interval_of)
1995 (Fadd_text_properties, set_text_properties_1)
1996 (Fremove_text_properties, Fremove_list_of_text_properties)
1997 (Ftext_property_any, Ftext_property_not_all)
1998 (copy_text_properties, text_property_list, extend_property_ranges)
1999 (verify_interval_modification):
2000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2001 (Fnext_single_char_property_change)
2002 (Fprevious_single_char_property_change):
2003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2004 (copy_text_properties):
2005 Check for integer overflow in index calculation.
d311d28c
PE
2006 * undo.c (last_boundary_position, record_point, record_insert)
2007 (record_delete, record_marker_adjustment, record_change)
2008 (record_property_change):
2009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2010 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2012 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2013 (Fx_hide_tip, Fx_file_dialog):
2014 * w32menu.c (set_frame_menubar):
2015 Use ptrdiff_t, not int, for consistency with rest of code.
2016 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2017 (select_window, Fdelete_other_windows_internal)
2018 (window_scroll_pixel_based, window_scroll_line_based)
2019 (Frecenter, Fset_window_configuration):
2020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2021 (Fset_window_hscroll, run_window_configuration_change_hook)
2022 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2023 (Fscroll_other_window, Frecenter):
d311d28c
PE
2024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2025 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2026 Don't assume fixnum fits in int.
2027 (Fset_window_scroll_bars):
2028 Check that fixnums are in proper range for system types.
2029 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2030 (string_pos, c_string_pos, number_of_chars, init_iterator)
2031 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2032 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2033 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2034 (face_before_or_after_it_pos, handle_invisible_prop)
2035 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2036 (display_prop_intangible_p, string_buffer_position_lim)
2037 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2038 (get_overlay_strings_1, get_overlay_strings)
2039 (iterate_out_of_display_property, forward_to_next_line_start)
2040 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2041 (get_next_display_element, set_iterator_to_next)
2042 (get_visually_first_element, compute_stop_pos_backwards)
2043 (handle_stop_backwards, next_element_from_buffer)
2044 (move_it_in_display_line_to, move_it_in_display_line)
2045 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2046 (add_to_log, message_dolog, message_log_check_duplicate)
2047 (message2, message2_nolog, message3, message3_nolog
2048 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2049 (current_message_1, truncate_echo_area, truncate_message_1)
2050 (set_message, set_message_1, store_mode_line_noprop)
2051 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2052 (text_outside_line_unchanged_p, check_point_in_composition)
2053 (reconsider_clip_changes)
2054 (redisplay_internal, set_cursor_from_row, try_scrolling)
2055 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2056 (redisplay_window, find_last_unchanged_at_beg_row)
2057 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2058 (trailing_whitespace_p, find_row_edges, display_line)
2059 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2060 (display_mode_element, store_mode_line_string)
2061 (pint2str, pint2hrstr, decode_mode_spec)
2062 (display_count_lines, display_string, draw_glyphs)
2063 (x_produce_glyphs, x_insert_glyphs)
2064 (rows_from_pos_range, mouse_face_from_buffer_pos)
2065 (fast_find_string_pos, mouse_face_from_string_pos)
2066 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2068 (safe_call, init_from_display_pos, handle_fontified_prop)
2069 (handle_single_display_spec, load_overlay_strings)
2070 (with_echo_area_buffer, setup_echo_area_for_printing)
2071 (display_echo_area, echo_area_display)
2072 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2073 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2074 (redisplay_window, dump_glyph_row, display_mode_line)
2075 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2076 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2078 (handle_single_display_spec, build_desired_tool_bar_string)
2079 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2080 (get_specified_cursor_type):
2081 Check that fixnums are in proper range for system types.
2082 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2083 (Flookup_image_map):
2084 Don't assume fixnums fit in int.
2085 (compare_overlay_entries):
2086 Avoid mishandling comparisons due to subtraction overflow.
2087 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2088 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2089 (handle_tool_bar_click):
2090 Use int, not unsigned, since we prefer signed and the signedness
2091 doesn't matter here.
2092 (get_next_display_element, next_element_from_display_vector):
2093 Use int, not EMACS_INT, when int is wide enough.
2094 (start_hourglass): Use duration_to_sec_usec to do proper
2095 overflow checking on durations.
2096 * xfaces.c (Fbitmap_spec_p):
2097 Check that fixnums are in proper range for system types.
2098 (compare_fonts_by_sort_order):
2099 Avoid mishandling comparisons due to subtraction overflow.
2100 (Fx_family_fonts, realize_basic_faces):
2101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2102 (Fx_family_fonts):
2103 Don't assume fixnum fits in int.
2104 Use SAFE_ALLOCA_LISP, not alloca.
2105 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2106 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2107 (face_at_buffer_position, face_for_overlay_string)
2108 (face_at_string_position):
2109 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2110 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2111 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2112 (Fx_show_tip):
2113 Check that fixnums are in proper range for system types.
2114 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2115 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2117 (Fx_change_window_property): Don't assume fixnums fit in int.
2118 * xfont.c (xfont_chars_supported):
2119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2120 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2121 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2123 * xml.c (parse_region):
2124 * xrdb.c (magic_file_p):
2125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2126 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2127 (x_get_local_selection, x_reply_selection_request)
2128 (x_handle_selection_request, wait_for_property_change):
2129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2130 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2131 short is wide enough.
2132 (x_send_client_event): Don't assume fixnum fits in int.
2133 * xterm.c (x_x_to_emacs_modifiers):
2134 Don't assume EMACS_INT overflows nicely into int.
2135 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2136 may come from Lisp.
2137 (handle_one_xevent): NATNUMP can eval its arg twice.
2138 (x_connection_closed):
2139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2140 * xterm.h: Adjust decls to match defn changes elsewhere.
2141 (struct scroll_bar): Use struct vectorlike_header
2142 rather than rolling our own approximation.
2143 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2144
c6574eb5
GM
21452012-05-25 Glenn Morris <rgm@gnu.org>
2146
2147 * lisp.mk (lisp): Update for more files being compiled now.
2148
e8d32c7e
SM
21492012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2150
48def666
SM
2151 * lread.c: Remove `read_pure' which makes no difference.
2152 (read_pure): Remove var.
2153 (unreadpure): Remove function.
2154 (readevalloop): Don't call read_list with -1 flag.
2155 (read1, read_vector): Don't test read_pure any more.
2156 (read_list): Simplify.
2157
e8d32c7e
SM
2158 * fileio.c, character.h: Minor style tweaks.
2159
4b2addb7
DA
21602012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2161
2162 * window.h (clip_changed): Remove useless declaration.
2163
584461b2
JB
21642012-05-22 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2167 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2168
34374650
PE
21692012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 Remove src/m/*.
2172 This directory predates autoconf and is no longer needed nowadays.
2173 Move its few remaining bits of functionality to where they're needed.
2174 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2175 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2176 * m/template.h: Remove.
2177 * Makefile.in (M_FILE): Remove. All uses removed.
2178 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2179 * lisp.h (USE_LSB_TAG):
2180 * mem-limits.h (EXCEEDS_LISP_PTR):
2181 Use VAL_MAX, not VALBITS, in #if.
2182 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2183 (EMACS_UINT): Define unconditionally now.
2184 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2185 (BITS_PER_EMACS_INT): New constants, replacing
2186 what used to be in config.h, but not useful in #if.
2187 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2188 define them any more.
2189 (VAL_MAX): New macro.
2190 (VALMASK): Use it.
2191 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2192 BITS_PER_EMACS_INT, in #if.
2193 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2194 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2195 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2196 * s/ms-w32.h (DATA_START):
2197 Move here from removed file m/intel386.h.
2198 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2199 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2200
261cb4bb
PE
22012012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2202
2203 Assume C89 or later.
2204 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2205 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2206 (xrealloc):
2207 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2208 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2209 * textprop.c, tparam.c (NULL): Remove.
2210 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2211 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2212 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2213 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2214 * xterm.c (input_signal_count): Assume volatile works.
2215
ff23cd9f
KB
22162012-05-21 Ken Brown <kbrown@cornell.edu>
2217
2218 * xgselect.c (xg_select): Fix first argument in call to 'select'
2219 (bug#11508).
2220
1b170bc6
KB
22212012-05-20 Ken Brown <kbrown@cornell.edu>
2222
2223 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2224 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2225
b2f4d39f
KB
22262012-05-19 Ken Brown <kbrown@cornell.edu>
2227
2228 * xfns.c (x_in_use): Remove `static' qualifier.
2229 * xterm.h (x_in_use): Declare.
2230 * xgselect.c: Include xterm.h.
2231 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2232 and `display_arg' (bug#9754).
2233
003fdae2
PE
22342012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2235
9232a6d9
PE
2236 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2237
003fdae2
PE
2238 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2239 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2240
784b56e2
EZ
22412012-05-18 Eli Zaretskii <eliz@gnu.org>
2242
2243 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2244
2245 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2246 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2247
2248 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2249 reference to image_cache->refcount.
2250 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2251
a0a79cde
JL
22522012-05-17 Juri Linkov <juri@jurta.org>
2253
2254 * search.c (Fword_search_regexp, Fword_search_backward)
2255 (Fword_search_forward, Fword_search_backward_lax)
2256 (Fword_search_forward_lax): Move functions to isearch.el
2257 (bug#10145, bug#11381).
2258
b0572523
PE
22592012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2260
2261 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2262
9660f5fc
SM
22632012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2264
2265 * lread.c (init_obarray): Declare Qt and Qnil as special.
2266
4374de83
GM
22672012-05-14 Glenn Morris <rgm@gnu.org>
2268
2269 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2270 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2271
dc44c39a
PE
22722012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2273
078c97cb
PE
2274 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2275
dc44c39a
PE
2276 * unexaix.c: Port to more-recent AIX compilers.
2277 (report_error, report_error_1, make_hdr, copy_sym)
2278 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2279 Make arguments const char *, not char *, to avoid violations of C
2280 standard and to fix some AIX warnings reported by Gilles Pion.
2281
e18afed7 22822012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2283
2284 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2285 already have overlays loaded.
2286 (handle_single_display_spec): Before returning without displaying
2287 fringe bitmap, synchronize the bidi iterator with the main display
2288 iterator, by calling iterate_out_of_display_property.
2289 (iterate_out_of_display_property): Detect buffer iteration by
2290 testing that it->string is a Lisp string.
2291 (get_next_display_element): When the current object is exhausted,
2292 and there's something on it->stack, call set_iterator_to_next to
2293 proceed with what's on the stack, instead of returning zero.
2294 (set_iterator_to_next): If called at the end of a Lisp string,
2295 proceed to consider_string_end without incrementing string
2296 position. Don't increment display vector index past the end of
2297 the display vector. (Bug#11417)
c8fb9dc6
EZ
2298 (pos_visible_p): Don't report a position visible when move_it_to
2299 stopped at the last line of window, which happens to be scanned
2300 backwards by the bidi iteration. (Bug#11464)
ac268e67 2301
e18afed7 23022012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2303
2304 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2305 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2306 are on a TTY, and thus unable to display on the fringes.
2307 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2308 so we need to signal to the caller that this is a "replacing"
2309 display spec. This fixes display when the spec is invalid or we
2310 are on a TTY.
2311
e18afed7 23122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2313
2314 * unexaix.c (make_hdr): Fix typo in prototype.
2315 This bug broke the build on AIX. Problem reported by Gilles Pion.
2316
9d0a235a
MA
23172012-05-14 Michael Albinus <michael.albinus@gmx.de>
2318
2319 * keyboard.c (kbd_buffer_get_event): Read special events also in
2320 batch mode. (Bug#11415)
2321
9e6b06ed
GM
23222012-05-12 Glenn Morris <rgm@gnu.org>
2323
2324 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2325
c1a1d7a3
EZ
23262012-05-12 Eli Zaretskii <eliz@gnu.org>
2327
2328 * lisp.mk (lisp): Add newcomment.elc.
2329
3fe7cdc8
GM
23302012-05-12 Glenn Morris <rgm@gnu.org>
2331
2332 * Makefile.in (MKDIR_P): New, set by configure.
2333 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2334
53f7d2c0
PE
23352012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2336
2337 Remove unused function hourglass_started.
2338 * dispextern.h (hourglass_started):
2339 * w32fns.c (hourglass_started):
2340 * xdisp.c (hourglass_started): Remove.
2341
75aafb17
JB
23422012-05-10 Juanma Barranquero <lekktu@gmail.com>
2343
2344 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2345 Update dependencies.
2346
12959e8e
PE
23472012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2348
97107e2e
PE
2349 * xgselect.c (xg_select): Put maxfds+1 into a var.
2350 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2351
12959e8e
PE
2352 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2353
836d29b3
DA
23542012-05-10 Dave Abrahams <dave@boostpro.com>
2355
2356 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2357 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2358
5cb67954
MA
23592012-05-09 Michael Albinus <michael.albinus@gmx.de>
2360
2361 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2362 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2363 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2364 Initialize xd_registered_buses.
2365
3478ec45
PE
23662012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2367
b263a6b0
PE
2368 Untag more efficiently if USE_LSB_TAG.
2369 This is based on a proposal by YAMAMOTO Mitsuharu in
2370 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2371 For an admittedly artificial (nth 8000 longlist) benchmark on
2372 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2373 Emacs's overall text size by 1%.
2374 * lisp.h (XUNTAG): New macro.
2375 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2376 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2377 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2378 * eval.c (Fautoload):
2379 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2380 * frame.h (XFRAME): Use XUNTAG.
2381
3478ec45
PE
2382 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2383 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2384 Remove unportable assumptions about print widths of types like
2385 dbus_uint32_t.
2386 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2387 intptr_t when converting between pointer and integer, to avoid GCC
2388 warnings about wrong width.
2389
666b903b 23902012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2391
2392 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2393 stack for each reader_thread, instead of defaulting to 8MB
2394 determined by the linker. This avoids failures in creating
2395 subprocesses on Windows 7, see the discussion in this thread:
2396 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2397
b120cc17
JC
23982012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2399
2400 Fix up display of the *Minibuf-0* buffer in the mini window.
2401 * keyboard.c (read_char): Don't clear the echo area if there's no
2402 message to clear.
2403 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2404 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2405
9a4b36f8
MA
24062012-05-07 Michael Albinus <michael.albinus@gmx.de>
2407
2408 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2409 batch mode.
2410
e5f9458f
CY
24112012-05-06 Chong Yidong <cyd@gnu.org>
2412
2413 * lisp.mk (lisp): Update.
2414
eceeb5fc 24152012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2416
2417 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2418
71873e2b
SM
24192012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2420
2421 * data.c (PUT_ERROR): New macro.
2422 (syms_of_data): Use it. Add new error type `user-error'.
2423 * undo.c (user_error): New function.
2424 (Fprimitive_undo): Use it.
2425 * print.c (print_error_message): Adjust print style for `user-error'.
2426 * keyboard.c (user_error): New function.
2427 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2428
ab0fa4e4
PE
24292012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 Do not limit current-time-string to years 1000..9999.
2432 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2433 (Fcurrent_time_string): Support any year that is supported by the
2434 underlying localtime representation. Don't use asctime, as it
2435 has undefined behavior for years outside the range -999..9999.
2436
7ed806a7
PE
24372012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 Fix race conditions involving setenv, gmtime, localtime, asctime.
2440 Without this fix, interrupts could mess up code that uses these
2441 nonreentrant functions, since setting TZ invalidates existing
2442 tm_zone or tzname values, and since most of these functions return
2443 pointers to static storage.
2444 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2445 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2446 Grow the critical sections to include not just invoking
2447 localtime/gmtime, but also accessing these functions' results
2448 including their tm_zone values if any, and any related TZ setting.
2449 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2450 so that the struct tm is saved in the critical section.
2451 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2452 motivated by the fact that memory allocation needs to be outside
2453 the critical section.
2454
0c16dfed
DA
24552012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2456
2457 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2458 with RESET_INTERVAL.
2459
2460 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2461 Remove duplicated buffer name initialization.
2462
3f83ace8
JM
24632012-05-02 Jim Meyering <jim@meyering.net>
2464
2465 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2466
c7b8541e
JM
2467 * xfns.c (x_window): Use xstrdup (Bug#11375).
2468
90207a15 24692012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2470
2471 * xdisp.c (pos_visible_p): If already at a newline from the
2472 display string before the 'while' loop, don't walk back the glyphs
2473 from it3.glyph_row. Solves assertion violation when the display
2474 string begins with a newline (egg.el). (Bug#11367)
2475
b593d6a9
AH
24762012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2477
2478 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2479 Move to simple.el.
2480
4737362e
GM
24812012-05-01 Glenn Morris <rgm@gnu.org>
2482
99cf43f9
GM
2483 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2484 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2485 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2486 All were removed before 23.1.
2487
9311dcff
GM
2488 * dispnew.c: Remove HAVE_LIBNCURSES test;
2489 it is always true on relevant platforms.
2490
4d5c6349
GM
2491 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2492 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2493
4737362e
GM
2494 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2495
74dd3a6b
AS
24962012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2497
2498 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2499 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2500 Remove.
2501
13c379ee
PE
25022012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2503
2504 Do not avoid creating empty evaporating overlays (Bug#9642).
2505 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2506 That is, do not delete an evaporating overlay if it becomes
2507 empty after its bounds are adjusted to fit within its buffer.
2508 This fix caused other problems, and I'm reverting it until we get
2509 to the bottom of them.
2510
a8e7d6d7 25112012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2512
2513 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2514
a8e7d6d7 25152012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2516
2517 * xdisp.c (pos_visible_p): If the window start position is beyond
2518 ZV, start the display from buffer beginning. Prevents assertion
2519 violation in init_iterator when the minibuffer window is scrolled
2520 via the scroll bar.
2521
2522 * window.c (window_scroll_pixel_based): Likewise.
2523
a8e7d6d7 25242012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2525
2526 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2527
a8e7d6d7 25282012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2529
2530 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2531 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2532
a8e7d6d7 25332012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2534
b593d6a9
AH
2535 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2536 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2537
1c6900d9
EZ
25382012-04-26 Eli Zaretskii <eliz@gnu.org>
2539
4c3fa1d9
EZ
2540 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2541 display element, check also the underlying string or buffer
2542 character. (Bug#11341)
2543
1c6900d9
EZ
2544 * w32menu.c: Include w32heap.h.
2545 (add_menu_item): If the call to AppendMenuW (via
2546 unicode_append_menu) fails, disable Unicode menus only if we are
2547 running on Windows 9X/Me.
2548
42bf8205
AS
25492012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2550
2551 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2552 (xgetint): Add missing shift for LSB tags.
2553
b1bac16e
MR
25542012-04-24 Martin Rudalics <rudalics@gmx.at>
2555
2556 * keyboard.c (read_char): Don't wipe echo area for select window
2557 events: These might get delayed via `mouse-autoselect-window'
2558 (Bug#11304).
2559
d69621cc
JB
25602012-04-24 Juanma Barranquero <lekktu@gmail.com>
2561
2562 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2563 manipulation of :loaded-from data.
2564
02fd101b
JB
25652012-04-23 Juanma Barranquero <lekktu@gmail.com>
2566
2567 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2568 now a cons (bug#11311).
2569
888bec30
PE
25702012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2571
89a438bd
PE
2572 Do not create empty overlays with the evaporate property (Bug#9642).
2573 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2574 if it becomes empty after its bounds are adjusted to fit within
2575 its buffer. Without this fix, in a nonempty buffer (let ((o
2576 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2577 yields an empty overlay that has the evaporate property, which is
2578 not supposed to happen.
2579
1068fe4d
PE
2580 Fix minor GTK3 problems found by static checking.
2581 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2582 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2583 (struct _EmacsFixedClass, emacs_fixed_get_type):
2584 Move decls here from emacsgtkfixed.h, since they needn't be public.
2585 (emacs_fixed_get_type): Now static.
2586 (emacs_fixed_class_init): Omit unused local.
2587 (emacs_fixed_child_type): Remove; unused.
2588 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2589 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2590 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2591 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2592 (EMACS_FIXED_GET_CLASS): Remove; unused.
2593 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2594
888bec30
PE
2595 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2596 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2597
de85e130
PE
25982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2599
d0baac98 2600 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2601 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2602 (__malloc_size_t, __malloc_ptrdiff_t):
2603 Remove. All uses removed, replaced by the definiens if needed,
2604 since we can assume C89 or better now.
2605 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2606 (protect_malloc_state, align, get_contiguous_space)
2607 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2608 (malloc_atfork_handler_child, malloc_enable_thread)
2609 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2610 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2611 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2612 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2613 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2614 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2615 Define using prototypes, not old style.
2616 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2617 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2618 (align): Don't assume that signed integer overflow wraps around.
2619 Omit unused local var.
2620 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2621 (_free_internal_nolock, memalign, mallochook, reallochook):
2622 Omit no-longer-needed casts.
2623 (valloc): Use getpagesize, not __getpagesize.
2624 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2625 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2626
de85e130
PE
2627 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2628
dcbf5805
MA
26292012-04-22 Michael Albinus <michael.albinus@gmx.de>
2630
2631 Move functions from C to Lisp. Make non-blocking method calls
2632 the default. Implement further D-Bus standard interfaces.
2633
2634 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2635 (QCdbus_request_name_allow_replacement)
2636 (QCdbus_request_name_replace_existing)
2637 (QCdbus_request_name_do_not_queue)
2638 (QCdbus_request_name_reply_primary_owner)
2639 (QCdbus_request_name_reply_in_queue)
2640 (QCdbus_request_name_reply_exists)
2641 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2642 (QCdbus_registered_serial, QCdbus_registered_method)
2643 (QCdbus_registered_signal): New Lisp objects.
2644 (XD_DEBUG_MESSAGE): Use sizeof.
2645 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2646 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2647 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2648 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2649 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2650 (xd_signature, xd_append_arg): Allow float for integer types.
2651 (xd_get_connection_references): New function.
b593d6a9
AH
2652 (xd_get_connection_address): Rename from xd_initialize.
2653 Return cached address.
dcbf5805
MA
2654 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2655 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2656 level.
2657 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2658 Return number of refcounts.
dcbf5805
MA
2659 (Fdbus_get_unique_name): Make stronger parameter check.
2660 (Fdbus_message_internal): New defun.
2661 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2662 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2663 (Fdbus_send_signal, Fdbus_register_service)
2664 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2665 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2666 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2667 (Vdbus_compiled_version, Vdbus_runtime_version)
2668 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2669 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2670 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2671 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2672 Adapt docstring.
dcbf5805 2673
52828e02
PE
26742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2675
da05bc4c
PE
2676 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2677 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2678 Do not assume ptrdiff_t is the same width as 'int'.
2679
52828e02
PE
2680 * alloc.c: Handle unusual debugging option combinations.
2681 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2682 since the two debugging options are incompatible.
2683 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2684 is defined.
2685 (mem_init, mem_insert, mem_insert_fixup):
2686 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2687 (NEED_MEM_INSERT): Remove; no longer needed.
2688
f01769f9
LL
26892012-04-22 Leo Liu <sdl.web@gmail.com>
2690
2691 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2692
5790543d
PE
26932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 * sysdep.c [__FreeBSD__]: Minor cleanups.
2696 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2697 Use Emacs indenting style more consistently. Avoid some casts.
2698 Use 'double' consistently rather than mixing 'float' and 'double'.
2699
b91b7e4d
EW
27002012-04-21 Eduard Wiebe <usenet@pusto.de>
2701
b593d6a9
AH
2702 * sysdep.c (list_system_processes, system_process_attributes):
2703 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2704
6114eb15
AS
27052012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2706
2707 * lisp.mk (lisp): Update.
2708
2f38dff7
PE
27092012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2712 It is never used otherwise.
2713
4ae29f89
SM
27142012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2715
2716 * print.c (print_preprocess): Only check print_depth if print-circle
2717 is nil.
2718 (print_object): Check for cycles even when print-circle is nil and
2719 print-gensym is t, but only check print_depth if print-circle is nil.
2720
f30d612a
CY
27212012-04-20 Chong Yidong <cyd@gnu.org>
2722
2723 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2724 set the status to "failed" and ensure that sentinel is run.
2725
c07a4c0b 27262012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2727
2728 * process.c (Fset_process_inherit_coding_system_flag)
2729 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2730 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2731
c07a4c0b 27322012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2733
2734 * xdisp.c (string_buffer_position_lim): Limit starting position to
2735 BEGV.
2736 (set_cursor_from_row): If called for a mode-line or header-line
2737 row, return zero immediately.
2738 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2739 farther than the first row after the header line, if any.
2740 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2741 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2742
c07a4c0b 27432012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2744
4ae29f89
SM
2745 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2746 (bug#11238).
ad3a2b41 2747
c07a4c0b 27482012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 27492012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2750
2751 configure: new option --enable-gcc-warnings (Bug#11207)
2752 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2753 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2754 (ALL_CFLAGS): Use new macros rather than old.
2755 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2756 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2757 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2758 -Wunused-result, -Wunused-variable. This should go away once
2759 the Emacs and Gnulib regex code is merged.
2760 (xmalloc, xrealloc): Now static.
2761
aba027e8
PE
27622012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 * dired.c (Fsystem_groups): Remove unused local.
2765
e5a36063
GM
27662012-04-17 Glenn Morris <rgm@gnu.org>
2767
2768 * dired.c (Fsystem_users): Doc fix.
2769
316411f0
DA
27702012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2771
2772 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2773 (syms_of_dired): Add them.
2774
9426aba4
PE
27752012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2776
b62a57be
PE
2777 Fix minor alloc.c problems found by static checking.
2778 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2779 New extern decls, to avoid calling undeclared functions.
2780 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2781 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2782 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2783 (NEED_MEM_INSERT): New macro.
2784 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2785 Remove one incorrect comment and fix another.
b62a57be 2786
3539f31f
PE
2787 Fix minor ralloc.c problems found by static checking.
2788 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2789 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2790 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2791 (r_alloc_sbrk): Now static.
2792
a041960a
PE
2793 Improve ralloc.c interface checking.
2794 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2795 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2796 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2797 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2798 [REL_ALLOC]: ... to here, to check interface.
2799 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2800 Remove decls. This fixes an "It stinks!".
2801
9426aba4
PE
2802 * alloc.c (which_symbols): Fix alignment issue / type clash.
2803
d55c12ed
AS
28042012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2805
2806 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2807 (struct Lisp_Misc_Any): Likewise.
2808 (struct Lisp_Free): Likewise.
2809 * alloc.c (union aligned_Lisp_Symbol): Define.
2810 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2811 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2812 (union aligned_Lisp_Misc): Define.
2813 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2814 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2815 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2816
b948ce8b
PE
28172012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2820 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2821 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2822 * s/netbsd.h, s/sol2-6.h:
2823 Remove definition of GC_MARK_STACK, since the default now works.
2824 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2825 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2826 no longer the default.
2827 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2828
35dc09a1 28292012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2830
35dc09a1
GM
2831 * lread.c (lisp_file_lexically_bound_p):
2832 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2833
35dc09a1
GM
28342012-04-14 Eli Zaretskii <eliz@gnu.org>
2835
2836 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2837 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2838
28392012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2840
2841 * nsterm.m (constrainFrameRect): Always constrain when there is only
2842 one screen (Bug#10962).
2843
bcd86815
KB
28442012-04-13 Ken Brown <kbrown@cornell.edu>
2845
2846 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2847
c25df26e
RT
28482012-04-13 Reuben Thomas <rrt@sc3d.org>
2849
2850 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2851
0fc59f1e
DC
28522012-04-11 Daniel Colascione <dancol@dancol.org>
2853
2854 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2855 against is gone. It's better to use vfork now so that when Cygwin
2856 gains a new, working vfork, we use it automatically (bug#10398).
2857
de8c03dc
SM
28582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * window.c (save_window_save): Obey window-point-insertion-type.
2861
2f097256
GM
28622012-04-11 Glenn Morris <rgm@gnu.org>
2863
2864 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2865
453b951e
SM
28662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2867
2868 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2869
75f1671a 28702012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2871
2872 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2873 (force_quit_count): New var.
2874 (handle_interrupt): Use it.
2875
2a8ce227
JB
28762012-04-10 Juanma Barranquero <lekktu@gmail.com>
2877
2878 * w32.c (w32_delayed_load): Record the full path of the library
2879 being loaded (bug#10424).
2880
935396c0
GM
28812012-04-09 Glenn Morris <rgm@gnu.org>
2882
05920a43
GM
2883 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2884 not just in the obarray, before snarfing them. (Bug#11036)
2885
935396c0
GM
2886 * Makefile.in ($(leimdir)/leim-list.el):
2887 Pass EMACS rather than BUILT_EMACS.
2888
a18ecafa
TZ
28892012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2890
2891 * process.c (make_process):
2892 * process.h: Add integer `gnutls_handshakes_tried' member to
2893 process struct.
2894
6bbef4e5
JC
2895 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2896 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2897
2898 * gnutls.c (gnutls_log_function2i): Convenience log function.
2899 (emacs_gnutls_read): Use new log functions,
2900 `gnutls_handshakes_tried' process member, and
2901 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2902 attempts per process (connection).
2903
b4d3bc10
CY
29042012-04-09 Chong Yidong <cyd@gnu.org>
2905
2906 * eval.c (Fuser_variable_p, user_variable_p_eh)
2907 (lisp_indirect_variable): Functions deleted.
2908 (Fdefvar): Caller changed.
2909
2910 * callint.c (Finteractive, Fcall_interactively):
2911 * minibuf.c (Fread_variable): Callers changed.
2912
70f4d973
EZ
29132012-04-09 Eli Zaretskii <eliz@gnu.org>
2914
2915 * xdisp.c (set_cursor_from_row): If the display string appears in
2916 the buffer at position that is closer to point than the position
2917 after the display string, display the cursor on the first glyph of
2918 the display string. Fixes cursor display when a 'display' text
2919 property immediately follows invisible text. (Bug#11094)
2920
cb3c2e3e
PE
29212012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2922
2923 composite.c: use 'double' consistently
2924 * composite.c (get_composition_id): Use 'double' consistently
2925 instead of converting 'float' to 'double' and vice versa; this is
2926 easier to understand and avoids a GCC warning.
2927
fd06db5d
GM
29282012-04-09 Glenn Morris <rgm@gnu.org>
2929
50fe702a
GM
2930 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2931 preparation for dumping it with emacs. (Bug#4789)
2932 (leimdir): New variable.
2933 ($(leimdir)/leim-list.el): New rule.
2934 (emacs$(EXEEXT)): Depend on leim-list.el.
2935
fd06db5d
GM
2936 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2937 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2938 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2939
55c131ee
AS
29402012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2941
2942 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2943 proper alignment.
2944
9209588f
JB
29452012-04-07 Juanma Barranquero <lekktu@gmail.com>
2946
2947 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2948 Remove unused local variable.
2949
e3fb2efb
PE
29502012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2953 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2954 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2955 objects, as mark_maybe_pointer will catch them otherwise.
2956 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2957 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2958
b5385551
PE
29592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 Fix typo that broke non-Windows builds.
2962 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2963
9078ead6
EZ
29642012-04-07 Eli Zaretskii <eliz@gnu.org>
2965
2966 Support building on MS-Windows with libxml2.
2967
2968 * makefile.w32-in (OBJ2): Add xml.$(O).
2969 (GLOBAL_SOURCES): Add xml.c.
2970 ($(BLD)/xml.$(O)): New dependency list.
2971
2972 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2973 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2974 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2975 [!WINDOWSNT]: New macros.
2976 (init_libxml2_functions, libxml2_loaded_p): New functions.
2977 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2978 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2979 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2980 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2981 linked in).
6bbef4e5
JC
2982 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2983 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2984 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2985
2986 * emacs.c: Don't include libxml/parser.h.
2987 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2988 xmlCleanupParser directly.
2989
2990 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2991
3811fdf3
EZ
29922012-04-07 Eli Zaretskii <eliz@gnu.org>
2993
2994 * indent.c (Fvertical_motion): If there is a display string at
2995 point, use it.vpos to compute how many lines to backtrack after
2996 move_it_to point. (Bug#11133)
2997
2f8e16b2
EZ
29982012-04-06 Eli Zaretskii <eliz@gnu.org>
2999
3000 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3001 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3002 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3003 macros related to unification of CJK characters. For the details,
3004 see the discussion following the message here:
3005 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3006
3d439cd1
CY
30072012-04-04 Chong Yidong <cyd@gnu.org>
3008
3009 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3010
8bc53d00
EZ
30112012-04-01 Eli Zaretskii <eliz@gnu.org>
3012
3013 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3014 instead of alloca. (Bug#11138)
3015
3b0512a3
AS
30162012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3017
3018 * w32menu.c (is_simple_dialog): Properly check lisp types.
3019 (Bug#11141)
3020
8427ddd2
EZ
30212012-03-31 Eli Zaretskii <eliz@gnu.org>
3022
979022ef
EZ
3023 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3024 position we get to after a call to move_it_to fails the
3025 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3026 only if we wind up in a string from display property. (Bug#11063)
3027
a6b1c7cc
EZ
3028 * window.c (Fdelete_other_windows_internal): Invalidate the row
3029 and column information about mouse highlight, so that redisplay
3030 restores it after reallocating the glyph matrices. (Bug#7464)
3031
8427ddd2
EZ
3032 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3033 string comes from a `display' text property, use the buffer
3034 position of that property as if we actually saw that position in
3035 the row's glyphs.
697ba24b
EZ
3036 (move_it_by_lines): Remove the assertion that
3037 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3038 violated when there's a before-string at the beginning of a line.
3039 (Bug#11063)
8427ddd2 3040
65a0a738
EZ
30412012-03-30 Eli Zaretskii <eliz@gnu.org>
3042
3043 * xdisp.c (append_space_for_newline): If the default face was
3044 remapped, use the remapped face for the appended newline.
3045 (extend_face_to_end_of_line): Use the remapped default face for
3046 extending the face to the end of the line.
3047 (display_line): Call extend_face_to_end_of_line when the default
3048 face was remapped. (Bug#11068)
3049
581355cc
EZ
30502012-03-29 Eli Zaretskii <eliz@gnu.org>
3051
3052 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3053
e8fc049f
SM
30542012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3055
3056 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3057
4fb9a543
GM
30582012-03-27 Glenn Morris <rgm@gnu.org>
3059
3060 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3061 Doc fixes.
3062
679910f1
KH
30632012-03-26 Kenichi Handa <handa@m17n.org>
3064
3065 * dispextern.h (struct glyph): Fix previous change. Change the
3066 bit length of glyphless.ch to 25 (Bug#11082).
3067
90d49b7f
CY
30682012-03-26 Chong Yidong <cyd@gnu.org>
3069
3070 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3071 (command_loop_1): Use it; inhibit selection update for
3072 handle-select-window too (Bug#8996).
3073
f514f6f0
FP
30742012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3075
e8fc049f 3076 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3077
bf43fa51
KH
30782012-03-25 Kenichi Handa <handa@m17n.org>
3079
3080 * dispextern.h (struct glyph): Change the bit length of
3081 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3082
8a0c01dd
EZ
30832012-03-24 Eli Zaretskii <eliz@gnu.org>
3084
3085 * s/ms-w32.h (tzname): Include time.h before redirecting to
3086 _tzname. Fixes the MSVC build. (Bug#9960)
3087
7d1c3a76
AS
30882012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3089
8ed79523
AS
3090 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3091 characters.
3092
7d1c3a76
AS
3093 * xterm.c (XTread_socket): Only modify handling_signal if
3094 !SYNC_INPUT. (Bug#11080)
3095
e99a9b8b
EZ
30962012-03-23 Eli Zaretskii <eliz@gnu.org>
3097
3098 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3099 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3100 when fetching a multibyte character consumes more bytes than
3101 CHAR_BYTES returns, due to unification of CJK characters in
3102 string_char. (Bug#11073)
3103
5063c0e1
TN
31042012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3105
3106 * process.c (wait_reading_process_output): Handle pty disconnect
3107 by refraining from sending oneself a SIGCHLD (bug#10933).
3108
9f851fbd
CY
31092012-03-22 Chong Yidong <cyd@gnu.org>
3110
3111 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3112
5063c0e1 3113 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3114 Mark string as coming from a prefix property.
3115 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3116 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3117
fb5b8aca
CY
31182012-03-21 Chong Yidong <cyd@gnu.org>
3119
3120 * xfaces.c (Vface_remapping_alist): Doc fix.
3121
62356a1b
EZ
31222012-03-20 Eli Zaretskii <eliz@gnu.org>
3123
3124 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3125 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3126 Doc fixes.
62356a1b 3127
025de85b
CY
31282012-03-20 Chong Yidong <cyd@gnu.org>
3129
3130 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3131 to reflect default non-nil value of redisplay-dont-pause.
3132
4827f94e
KH
31332012-03-19 Kenichi Handa <handa@m17n.org>
3134
3135 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3136 it fit in a valid range (Bug#11003).
3137
e50a24a2
EZ
31382012-03-18 Eli Zaretskii <eliz@gnu.org>
3139
3140 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3141 that is not from display property, accept the row as a "cursor
3142 row" if one of the string's character has a non-nil `cursor'
3143 property. Fixes cursor positioning when there are newlines in
3144 overlay strings, e.g. in icomplete.el. (Bug#11035)
3145
9af5ed87
PE
31462012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3147
3148 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3149
d1f55f16
CY
31502012-03-12 Chong Yidong <cyd@gnu.org>
3151
3152 * eval.c (inhibit_lisp_code): Rename from
3153 inhibit_window_configuration_change_hook; move from window.c.
3154
3155 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3156 * window.c (run_window_configuration_change_hook)
3157 (syms_of_window): Callers changed.
3158
66c5eebd
CY
31592012-03-11 Chong Yidong <cyd@gnu.org>
3160
413df973
CY
3161 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3162
66c5eebd
CY
3163 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3164
1de11f56
CY
31652012-03-10 Chong Yidong <cyd@gnu.org>
3166
3167 * frame.c (other_visible_frames): Don't assume the selected frame
3168 is visible (Bug#10955).
3169
cae07000
SM
31702012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3171
3172 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3173
89c94350
JD
31742012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3175
3176 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3177 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3178 zero (Bug#10954).
3179
999dd333
GM
31802012-03-03 Glenn Morris <rgm@gnu.org>
3181
01a6dcc8 3182 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3183
de0100f2
EZ
31842012-03-02 Eli Zaretskii <eliz@gnu.org>
3185
3186 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3187 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3188 (redisplay_window, next_element_from_string): Fix typos in
3189 comments.
3e441275
EZ
3190 (redisplay_window): Pass to move_it_vertically the margin in
3191 pixels, not in screen lines.
de0100f2 3192
96a72ee9
GM
31932012-03-02 Glenn Morris <rgm@gnu.org>
3194
3195 * buffer.c (buffer-list-update-hook): Doc fix.
3196
312508d7
EZ
31972012-02-29 Eli Zaretskii <eliz@gnu.org>
3198
3199 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3200 push_it before setting up the iterator for the first overlay
3201 string, even if we have an empty string loaded.
3202 (next_overlay_string): If there's an empty string on the iterator
3203 stack, pop the stack. (Bug#10903)
3204
27f3c637
PE
32052012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3206
3207 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3208 Suggested by Stefan Monnier in
3209 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3210 * alloc.c (widen_to_Lisp_Object): New static function.
3211 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3212 and widening them to Lisp_Objects. This would work even if
3213 USE_LSB_TAG is defined and wide integers are used, which might
3214 happen in a future version of Emacs.
3215
3c9dfce6
CY
32162012-02-25 Chong Yidong <cyd@gnu.org>
3217
fa74b241
CY
3218 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3219 Doc fix.
3220
3c9dfce6
CY
3221 * xselect.c (Fx_selection_exists_p): Doc fix.
3222 (x_clipboard_manager_save_all): Print an informative message
3223 before saving to clipboard manager.
3224
9486df08
CY
32252012-02-24 Chong Yidong <cyd@gnu.org>
3226
3227 * keyboard.c (process_special_events): Handle all X selection
3228 requests in kbd_buffer, not just the next one (Bug#8869).
3229
f01d3321
CY
32302012-02-23 Chong Yidong <cyd@gnu.org>
3231
3232 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3233 call when setting menu-bar-lines and tool-bar-lines parameters.
3234 (unwind_create_frame_1): New helper function.
3235
3236 * window.c (inhibit_window_configuration_change_hook): New var.
3237 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3238 (syms_of_window): Initialize it.
f01d3321 3239
86b847b6
CY
32402012-02-22 Chong Yidong <cyd@gnu.org>
3241
3242 * xterm.c (x_draw_image_relief): Add missing type check for
3243 Vtool_bar_button_margin (Bug#10743).
3244
a59225b1
CY
32452012-02-21 Chong Yidong <cyd@gnu.org>
3246
3247 * fileio.c (Vfile_name_handler_alist): Doc fix.
3248
3249 * buffer.c (Fget_file_buffer): Protect against invalid file
3250 handler return value.
3251
310f5bd4
PE
32522012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3253
cb3a28cc
PE
3254 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3255 when computing $valmask.
3256
310f5bd4
PE
3257 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3258 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3259 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3260 It's useless in that case, and it can cause problems on hosts
3261 that allocate halves of EMACS_INT values separately.
3262 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3263 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3264 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3265 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3266 it avoids undefined behavior on hosts where shifting right by more
3267 than the word width has undefined behavior.
3268
2375c96a
CY
32692012-02-19 Chong Yidong <cyd@gnu.org>
3270
3271 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3272 (Funhandled_file_name_directory, Ffile_name_as_directory)
3273 (Fdirectory_file_name, Fexpand_file_name)
3274 (Fsubstitute_in_file_name): Protect against invalid file handler
3275 return values (Bug#10845).
3276
3eb49e71
EZ
32772012-02-18 Eli Zaretskii <eliz@gnu.org>
3278
3279 * .gdbinit (pitx): Fix incorrect references to fields of the
3280 iterator stack.
3281
7b926f3f
CY
32822012-02-17 Chong Yidong <cyd@gnu.org>
3283
3284 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3285
11273115
PE
32862012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3289 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3290
c3a70e2b
CY
32912012-02-15 Chong Yidong <cyd@gnu.org>
3292
3293 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3294 marked as special. Also, starting docstrings with * is obsolete.
3295
0ca43699
AS
32962012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3297
3298 * gnutls.c (emacs_gnutls_write): Fix last change.
3299
2e8f3c56
LI
33002012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3301
3302 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3303 send_process.
3304
af70074f
SM
33052012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3306
3307 * keymap.c (Fsingle_key_description): Handle char ranges.
3308
95986d52
CY
33092012-02-12 Chong Yidong <cyd@gnu.org>
3310
afd83bd1
CY
3311 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3312 as that creates a dangerous corner case.
3313
95986d52
CY
3314 * window.c (Fdelete_window_internal): Invalidate the mouse
3315 highlight (Bug#9904).
3316
bd7da63e
GM
33172012-02-12 Glenn Morris <rgm@gnu.org>
3318
3319 * xselect.c (Fx_own_selection_internal)
3320 (Fx_get_selection_internal, Fx_disown_selection_internal)
3321 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3322 * nsselect.m (Fx_own_selection_internal)
3323 (Fx_disown_selection_internal, Fx_selection_exists_p)
3324 (Fx_selection_owner_p, Fx_get_selection_internal):
3325 Sync docs and argument specs with the xselect.c versions.
3326
77abcbc2
LI
33272012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3328
3329 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3330
90b671e2
EZ
33312012-02-11 Eli Zaretskii <eliz@gnu.org>
3332
1c0ca0b7
EZ
3333 * w32select.c (Fx_selection_exists_p): Sync doc string and
3334 argument list with xselect.c. (Bug#10783)
3335
3336 * w16select.c (Fx_selection_exists_p): Sync doc string and
3337 argument list with xselect.c. (Bug#10783)
90b671e2 3338
49241268
GM
33392012-02-10 Glenn Morris <rgm@gnu.org>
3340
3341 * fns.c (Fsecure_hash): Doc fix.
3342
f998bbe7 33432012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3344
3345 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3346
0992bd9c
CY
33472012-02-07 Chong Yidong <cyd@gnu.org>
3348
3349 * buffer.c (Fbuffer_local_variables)
3350 (buffer_lisp_local_variables): Handle unbound vars correctly;
3351 don't let Qunbound leak into Lisp.
3352
af008560
GM
33532012-02-07 Glenn Morris <rgm@gnu.org>
3354
dd605cc4
GM
3355 * image.c (Fimagemagick_types): Doc fix.
3356
af008560
GM
3357 * image.c (imagemagick-render-type): Change it from a lisp object
3358 to an integer. Move the doc here from the lisp manual.
3359 Treat all values not equal to 0 the same.
3360
1449fa1d
CY
33612012-02-06 Chong Yidong <cyd@gnu.org>
3362
3363 * doc.c (store_function_docstring): Avoid applying docstring of
3364 alias to base function (Bug#2603).
3365
3723ec07
AS
33662012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3367
3368 * .gdbinit (pp1, pv1): Remove redundant defines.
3369 (pr): Use pp.
3370
79c1cc1e
CY
33712012-02-04 Chong Yidong <cyd@gnu.org>
3372
3373 * nsterm.m: Declare a global (Bug#10694).
3374
d7f29f8e
EZ
33752012-02-04 Eli Zaretskii <eliz@gnu.org>
3376
cae07000
SM
3377 * w32.c (get_emacs_configuration_options):
3378 Include --enable-checking, if specified, in the return value.
d7f29f8e 3379
3b95a6f9
MR
33802012-02-04 Martin Rudalics <rudalics@gmx.at>
3381
3382 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3383 after rounding frame sizes. (Bug#9723)
3384
d6fa96a6
EZ
33852012-02-04 Eli Zaretskii <eliz@gnu.org>
3386
3387 * keyboard.c (adjust_point_for_property): Don't position point
3388 before BEGV. (Bug#10696)
3389
df0b2940
PE
33902012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3391
3392 Handle overflow when computing char display width (Bug#9496).
3393 * character.c (char_width): Return EMACS_INT, not int.
3394 (char_width, c_string_width): Check for overflow when
3395 computing the width; this is possible now that individual
3396 characters can have unbounded width. Problem introduced
3397 by merge from Emacs 23 on 2012-01-19.
3398
6bee44d6
MA
33992012-02-02 Michael Albinus <michael.albinus@gmx.de>
3400
3401 * dbusbind.c (Fdbus_register_method): Mention the return value
3402 :ignore in the docstring.
3403
44f92739
GM
34042012-02-02 Glenn Morris <rgm@gnu.org>
3405
1b9f60cc
GM
3406 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3407
44f92739
GM
3408 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3409 Unconditionally set to t. (Bug#10673)
3410 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3411 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3412 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3413
c5d3843c
KH
34142012-02-02 Kenichi Handa <handa@m17n.org>
3415
3416 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3417 0, do not call append_composite_glyph.
3418
159462d4 34192012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3420
3421 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3422 NULL (Bug#6988).
3423 (x_produce_glyphs): If the component of a composition is a null
3424 string, set it->pixel_width to 1 to avoid zero-width glyph.
3425
78cef877
EZ
34262012-02-01 Eli Zaretskii <eliz@gnu.org>
3427
3428 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3429 first 2 arguments are identical. This makes inserting large
3430 output from a subprocess an order of magnitude faster on
3431 MS-Windows, where all sbrk'ed memory is always contiguous.
3432
97897668
GM
34332012-01-31 Glenn Morris <rgm@gnu.org>
3434
3435 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3436 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3437 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3438
31fd3586
GM
34392012-01-29 Glenn Morris <rgm@gnu.org>
3440
3441 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3442
0e24a8b2
CY
34432012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3444
3445 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3446
cc0adcb0
CY
34472012-01-28 Chong Yidong <cyd@gnu.org>
3448
3449 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3450
acc28cb9
CY
34512012-01-26 Chong Yidong <cyd@gnu.org>
3452
9c69cfb7
CY
3453 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3454
acc28cb9
CY
3455 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3456 repeat counts (Bug#10507).
3457
48da7392
GM
34582012-01-26 Glenn Morris <rgm@gnu.org>
3459
3460 * lread.c (syms_of_lread): Doc fix.
3461
14af5f7f
CY
34622012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3463
3464 * coding.c (encode_designation_at_bol): Change return value to
3465 EMACS_INT.
3466
0b21c100
CY
34672012-01-25 Chong Yidong <cyd@gnu.org>
3468
3469 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3470
3c2907f7
CY
34712012-01-21 Chong Yidong <cyd@gnu.org>
3472
3473 * floatfns.c (Fcopysign): Make the second argument non-optional,
3474 since nil is not allowed anyway.
3475
959ad23f
AS
34762012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3477
3478 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3479 (send_process): Likewise.
3480
34a02f46
MR
34812012-01-19 Martin Rudalics <rudalics@gmx.at>
3482
3483 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3484 (Vwindow_persistent_parameters): Do not use Qstate.
3485 Rewrite doc-strings.
34a02f46 3486
1259009a 34872012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3488
3489 * character.c (char_width): New function.
70d4fdf6
GM
3490 (Fchar_width, c_string_width, lisp_string_width):
3491 Use char_width (Bug#9496).
25ed9e61 3492
6a6ee00d
MR
34932012-01-16 Martin Rudalics <rudalics@gmx.at>
3494
3495 * window.c (Vwindow_persistent_parameters): New variable.
3496 (Fset_window_configuration, save_window_save): Handle persistent
3497 window parameters.
3498
c85efaf7
EZ
34992012-01-14 Eli Zaretskii <eliz@gnu.org>
3500
3501 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3502 thrashing the stack of the thread. (Bug#9087)
3503
5944709e
PE
35042012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3505
3506 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3507
e71f5d99
EZ
35082012-01-11 Eli Zaretskii <eliz@gnu.org>
3509
3510 * xdisp.c (rows_from_pos_range): Handle the case where the
3511 highlight ends on a newline. (Bug#10464)
3512 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3513 he end column for display of highlight that ends on a newline
3514 before a R2L line.
3515
ce316182
GM
35162012-01-11 Glenn Morris <rgm@gnu.org>
3517
3518 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3519 from load-path also when installation-directory is nil. (Bug#10208)
3520
5b43da69
GM
35212012-01-10 Glenn Morris <rgm@gnu.org>
3522
74cc8ff9
GM
3523 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3524
7d8d6e4e
GM
3525 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3526 Update template values to be closer to their typical values these days.
5b43da69 3527
a0db8d43
EZ
35282012-01-09 Eli Zaretskii <eliz@gnu.org>
3529
3530 * xdisp.c (rows_from_pos_range): Accept additional argument
3531 DISP_STRING, and accept any glyph in a row whose object is that
3532 string as eligible for mouse highlight. Fixes mouse highlight of
3533 display strings from overlays. (Bug#10464)
3534
9a0115ab 35352012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3536
b9110d6a 3537 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3538 * fileio.c (auto_saving_dir_umask): New static var.
3539 (Fmake_directory_internal): Use it.
3540 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3541 creating the directory. The old code temporarily assigns
3542 too-generous permissions to the directory.
3543 (do_auto_save_eh): Clear it.
b9110d6a 3544 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3545 that the var is always cleared.
3546
6c1bd3f3
EZ
35472012-01-07 Eli Zaretskii <eliz@gnu.org>
3548
3549 * search.c (scan_buffer): Pass character positions to
3550 know_region_cache, not byte positions. (Bug#6540)
3551
069d2b50
L
35522012-01-07 LynX <_LynX@bk.ru> (tiny change)
3553
3554 * w32.c (sys_rename): Report EXDEV when rename of a directory
3555 fails because the target is on another logical disk. (Bug#10284)
3556
75bf0d33
DB
35572012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3558
3559 * xterm.c (x_embed_request_focus): New function.
3560
3561 * xterm.h: Add prototype.
3562
3563 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3564
1c6e5a32
GM
35652012-01-05 Glenn Morris <rgm@gnu.org>
3566
3567 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3568
651e947e
EZ
35692012-01-01 Eli Zaretskii <eliz@gnu.org>
3570
3571 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3572 Load gnutls_transport_set_lowat only if GnuTLS version is below
3573 2.11.1.
3574 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3575 GnuTLS versions below 2.11.1.
3576
3778cdd8
AL
35772011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3578
3579 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3580 to the doc string advising against its use for altering the way
3581 windows are scrolled.
3582
0e5317f7
KH
35832011-12-28 Kenichi Handa <handa@m17n.org>
3584
3585 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3586 coding-system ASCII compatible only when it does not produce BOM
3587 on encoding (Bug#10383).
3588
93d5ca1f
JD
35892011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3590
3591 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3592 can scroll.
3593 (create_and_show_popup_menu): Always use menu_position_func for
3594 Gtk3 (Bug#10361).
3595
ca22b785
AS
35962011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3597
3598 * callint.c (Fcall_interactively): Don't truncate prompt string.
3599
d048e1e6
EZ
36002011-12-23 Eli Zaretskii <eliz@gnu.org>
3601
3602 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3603 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3604 resumed from there (after widening). (Bug#10360)
d048e1e6 3605
5ccaba1f
JD
36062011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3607
3608 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3609
204ee57f
JD
36102011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3611
b81d40f0
JB
3612 * nsterm.m (x_free_frame_resources):
3613 Release f->output_data.ns->miniimage.
204ee57f
JD
3614 (ns_index_color): Fix indentation. Do not retain
3615 color_table->colors[i].
3616
3617 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3618 before returning.
3619
3620 * nsfns.m (x_set_background_color): Assign return value from
3621 ns_index_color to face-background instead of NSColor*.
3622 (ns_implicitly_set_icon_type): Fix indentation.
3623 Change assignment in for loop to comparison.
3624
3625 * emacs.c (ns_pool): New variable.
3626 (main): Assign ns_pool.
3627 (Fkill_emacs): Call ns_release_autorelease_pool.
3628
3629 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3630 autorelease fdesc, release fdAttrs and tdict.
3631 (ns_get_covering_families): Release charset.
3632 (ns_findfonts): Release NSFontDescriptor created with new.
3633 (ns_uni_to_glyphs): Fix indentation.
3634 (setString): Release attrStr before assigning new value.
3635
c803b2b7
JD
36362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3637
678f4426
JD
3638 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3639 and NS_IMPL_COCOA.
3640 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3641 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3642
cd394be1 36432011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3644
5fecd5fc
JD
3645 * nsterm.m (ns_term_init): Subscribe for notifications
3646 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3647 to method trackingNotification in EmacsMenu.
3648
3649 * nsmenu.m (trackingMenu): New variable.
3771cb17 3650 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3651 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3652 from Aquamacs (Bug#7030).
678f4426
JD
3653
36542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3655
c803b2b7
JD
3656 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3657 (symbol_to_nsstring): Fix indentation.
3658 (ns_symbol_to_pb): New function.
cae07000
SM
3659 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3660 (Fns_rotate_cut_buffers_internal): Remove.
3661 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3662 Fns_store_cut_buffer_internal.
3663 (ns_get_foreign_selection, Fx_own_selection_internal)
3664 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3665 (Fns_get_selection_internal, Fns_store_selection_internal):
3666 Use ns_symbol_to_pb and check if return value is nil.
3667 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3668 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3669 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3670 renamed to Sns_store_selection_internal.
3671 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3672 and remove this function.
3673 (ns_handle_selection_clear): Remove, never used.
3674 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3675 here.
3676
e1b01a3a
KB
36772011-12-17 Ken Brown <kbrown@cornell.edu>
3678
3679 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3680 GID is unknown (Bug#10257).
3681
2adb6e85
PE
36822011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3683
3684 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3685 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3686 which caused a build failure on GNU/Linux IA-64. This problem was
3687 introduced by my 2011-10-07 patch.
3688
d1d7b339
JL
36892011-12-15 Juri Linkov <juri@jurta.org>
3690
3691 * image.c (imagemagick_error): New function. (Bug#10112)
3692 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3693 Use `imagemagick_error' where ImageMagick functions return
3694 `MagickFalse'.
3695 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3696 proper order.
3697
100d5755
KH
36982011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3699
3700 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3701 fill background (Bug#8992).
3702
454592a6
MR
37032011-12-13 Martin Rudalics <rudalics@gmx.at>
3704
3705 * window.c (Vwindow_combination_resize)
3706 (Vwindow_combination_limit): Use t instead of non-nil in
3707 doc-strings.
61d4b438
MR
3708 (Vrecenter_redisplay): Add first sentence of doc-string on
3709 separate line.
53524d93 3710 (Frecenter): Fix doc-string typo.
454592a6 3711
3633e3aa
KH
37122011-12-11 Kenichi Handa <handa@m17n.org>
3713
3714 * coding.c (Funencodable_char_position): Pay attention to the
3715 buffer text relocation (Bug#9389).
3716
7b9d523a 37172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3718
7b9d523a
JD
3719 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3720 gtk_init (Bug#10100).
3721
b73189c6
EZ
37222011-12-10 Eli Zaretskii <eliz@gnu.org>
3723
3724 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3725 IT->string is nil. (Bug#10263)
3726
f7dfe5d6
JD
37272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3728
83faebb4
JD
3729 * nsterm.h (x_free_frame_resources): Declare.
3730
f7dfe5d6
JD
3731 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3732 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3733
3734 * nsterm.h (ns_get_defaults_value): Declare.
3735
3736 * nsterm.m (ns_default): Call ns_get_defaults_value.
3737
7cd4e72c
EZ
37382011-12-09 Eli Zaretskii <eliz@gnu.org>
3739
3740 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3741 (Bug#10170)
3742
b34d7317
YM
37432011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3744
3745 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3746 that where the value of an _OBJC_* symbol points to is in the .bss
3747 section (Bug#10240).
3748
76470ad1
KH
37492011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3750
3751 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3752 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3753
745fff94
KH
37542011-12-08 Kenichi Handa <handa@m17n.org>
3755
3756 * ftfont.c (get_adstyle_property): Fix previous change
3757 (Bug#10233).
3758
6e44397c
JB
37592011-12-07 Juanma Barranquero <lekktu@gmail.com>
3760
3761 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3762 dirs from the default value of EMACSLOADPATH (bug#10208).
3763
7efa6272
GM
37642011-12-07 Glenn Morris <rgm@gnu.org>
3765
3766 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3767 installation and source directories as well. (Bug#10208)
3768
f6fc4d87
CY
37692011-12-06 Chong Yidong <cyd@gnu.org>
3770
3771 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3772
2bf26180
GM
37732011-12-06 Glenn Morris <rgm@gnu.org>
3774
3775 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3776 as an error, not just -1. (Bug#10217)
3777
3a6ad4f0
CY
37782011-12-05 Chong Yidong <cyd@gnu.org>
3779
3780 * keyboard.c (process_special_events): New function.
3781 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3782
75a3b399
PE
37832011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3784
3785 * coding.c (encode_designation_at_bol): Don't use uninitialized
3786 local variable (Bug#9318).
3787
c3c9e25e
KH
37882011-12-05 Kenichi Handa <handa@m17n.org>
3789
3790 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3791 return Qnil (Bug#8046, Bug#10193).
3792
5eb05ea3
KH
37932011-12-05 Kenichi Handa <handa@m17n.org>
3794
3795 * coding.c (encode_designation_at_bol): New args charbuf_end and
3796 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3797 (coding_set_source): Return how many bytes coding->source was
3798 relocated.
3799 (coding_set_destination): Return how many bytes
3800 coding->destination was relocated.
3801 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3802 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3803
38042011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3805
3806 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3807 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3808 macro (Bug#9318).
3809
38102011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3811
3812 The following changes are to fix Bug#9318.
3813
a79703f5 3814 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3815 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3816 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3817 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3818
7dbda6df
JB
38192011-12-05 Juanma Barranquero <lekktu@gmail.com>
3820
3821 * lisp.h (process_quit_flag): Fix external declaration.
3822
6d5eb5b0
SM
38232011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3824
3825 Don't macro-inline non-performance-critical code.
3826 * eval.c (process_quit_flag): New function.
3827 * lisp.h (QUIT): Use it.
3828
a0c3fad0
JD
38292011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3830
3831 * nsfns.m (get_geometry_from_preferences): New function.
3832 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3833
6c07aac2
AS
38342011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3835
3836 * emacs.c (Qkill_emacs): Define.
3837 (syms_of_emacs): Initialize it.
3838 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3839 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3840 (quit_throw_to_read_char): Add parameter `from_signal'.
3841 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3842 * lisp.h (QUIT): Call Fkill_emacs if requested.
3843
c052ead4
JD
38442011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3845
3846 * widget.c (update_wm_hints): Return if wmshell is null.
3847 (widget_update_wm_size_hints): New function.
3848
3849 * widget.h (widget_update_wm_size_hints): Declare.
3850
3851 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3852 widget_update_wm_size_hints (Bug#10104).
3853
9e49252b
EZ
38542011-12-03 Eli Zaretskii <eliz@gnu.org>
3855
3856 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3857 before a newline, prepare the bidi iterator for consuming the
3858 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3859 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3860
02b16839
JL
38612011-12-02 Juri Linkov <juri@jurta.org>
3862
3863 * search.c (Fword_search_regexp): New Lisp function created from
3864 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3865 (Fword_search_backward, Fword_search_forward)
3866 (Fword_search_backward_lax, Fword_search_forward_lax):
3867 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3868 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3869
0068070e
SM
38702011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3871
3872 * fileio.c (Finsert_file_contents): Move after-change-function call
3873 to before the "handled:" label, since all "goto handled" appear in
3874 cases where the *-change-functions have already been properly called
3875 (bug#10117).
3876
3360a3fc
AS
38772011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3878
3879 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3880 waiting for input. (Bug#10169)
3881
73d6c093
EZ
38822011-11-30 Eli Zaretskii <eliz@gnu.org>
3883
3884 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3885 verifies glyph row's hash code--we have just reallocated the
3886 glyphs, so their contents can be complete garbage. (Bug#10164)
3887
febe6bea
JB
38882011-11-30 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3891
801a4313
EZ
38922011-11-30 Eli Zaretskii <eliz@gnu.org>
3893
3894 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3895 attributes are tested _before_ calling verify_row_hash, to protect
3896 against GCC re-ordering of the tests. (Bug#10164)
3897
2b56b87e
JD
38982011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3899
3900 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3901
3902 * xterm.c (handle_one_xevent): Only set async_visible and friends
3903 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3904 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3905 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3906
dbf31225
PE
39072011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3910 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3911 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3912 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3913 All uses changed to use GCPRO1 etc.
3914 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3915 Revert to old implementation (i.e., before 2011-03-11).
3916
1305621b
YM
39172011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3918
3919 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3920 of scroll runs so as to avoid assigning disabled bogus rows and
3921 unnecessary graphics copy operations.
3922
8c9afb46
EZ
39232011-11-27 Eli Zaretskii <eliz@gnu.org>
3924
3925 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3926 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3927 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3928 (malloc, free, realloc, calloc): Redirect to e_* only when
3929 compiling Emacs.
3930
3931 * lisp.h (GCTYPEBITS): Move before first use.
3932 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3933 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3934 this macro definition.
3935
3936 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3937 _MSC_VER.
3938
54e9e3bf
JD
39392011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3940
6d5eb5b0
SM
3941 * gtkutil.c (xg_create_frame_widgets):
3942 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3943 present with Gtk+ 2.0.
3944
83aca1cb
PE
39452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3946
3947 * fileio.c (Finsert_file_contents): Undo previous change; see
3948 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3949
5b76caa4
PE
39502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3951
3952 Rename locals to avoid shadowing.
3953 * fileio.c (Finsert_file_contents):
3954 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3955 * process.c (wait_reading_process_output):
3956 Rename inner 'proc' to 'p' to avoid shadowing.
3957 Indent for consistency with usual Emacs style.
3958
8c535114
EZ
39592011-11-25 Eli Zaretskii <eliz@gnu.org>
3960
3961 * xdisp.c (redisplay_window): If cursor row is not fully visible
3962 after recentering, and scroll-conservatively is set to a large
3963 number, scroll window by a few more lines to make the cursor fully
3964 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3965 (start_display): Don't move to the next line if the display should
3966 start at a newline that is part of a display vector or an overlay
3967 string. (Bug#10119)
8c535114 3968
fa4fdb5c
JL
39692011-11-24 Juri Linkov <juri@jurta.org>
3970
3971 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3972 after the `MagickPingImage' call. (Bug#10112)
3973
90ec88df
CY
39742011-11-23 Chong Yidong <cyd@gnu.org>
3975
3976 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3977
56e2e794
MR
39782011-11-23 Martin Rudalics <rudalics@gmx.at>
3979
3980 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3981 making another buffer current. (Bug#10114)
3982
b6e64c41
GM
39832011-11-23 Glenn Morris <rgm@gnu.org>
3984
3985 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3986
6b21de18
CY
39872011-11-23 Chong Yidong <cyd@gnu.org>
3988
3989 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3990 using it (Bug#5984).
3991
b12cd789
EZ
39922011-11-22 Eli Zaretskii <eliz@gnu.org>
3993
3994 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3995 and header-lines, as they don't have one computed for them.
3996 (Bug#10098)
3997
3998 * .gdbinit (prow): Make displayed values more self-explaining.
3999 Add row's hash code.
4000
261b6fd4
LMI
40012011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4002
4003 * process.c (wait_reading_process_output): Fix asynchrounous
4004 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4005 (wait_reading_process_output): Add comment and URL.
261b6fd4 4006
e7cfd277
JD
40072011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4008
4009 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4010
a9b9b7f5
CY
40112011-11-21 Chong Yidong <cyd@gnu.org>
4012
4013 * window.c (Fnext_window, Fprevious_window): Doc fix.
4014
b0d15b4f
SM
40152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4016
4017 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4018
fe7a3057
JB
40192011-11-20 Juanma Barranquero <lekktu@gmail.com>
4020
4021 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4022
d2999b1a
MR
40232011-11-20 Martin Rudalics <rudalics@gmx.at>
4024
4025 * window.c (Fset_window_combination_limit): Rename argument
4026 STATUS to LIMIT.
4027 (Vwindow_combination_limit): Remove "status" from doc-string.
4028
d5ff9cd0
AS
40292011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4030
4031 * m/ibms390.h: Remove.
4032 * m/ibms390x.h: Don't include "ibms390.h".
4033
a5bb9bd3
SM
40342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4035
4036 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4037 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4038
cd1181db
JB
40392011-11-20 Juanma Barranquero <lekktu@gmail.com>
4040
4041 * casetab.c (Fset_case_table):
4042 * charset.c (Fcharset_after): Fix typos.
4043
615a3b8d 40442011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4045
17e845af
PE
4046 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4047 Otherwise, valgrind does not work on some platforms.
4048 Problem reported by Andreas Schwab in
6a0bf43d
PE
4049 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4050 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4051 is set, removing the need for VIRT_ADDRESS_VARIES.
4052 (PURE_P): Use a more-efficient implementation that needs just one
4053 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4054 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4055 to 4 (xorl, subq, cmpq, setbe).
4056 * alloc.c (pure): Always extern now, since that's the
4057 VIRT_ADDR_VARIES behavior.
4058 (PURE_POINTER_P): Use a single comparison, not two, for
4059 consistency with the new puresize.h.
4060 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4061 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4062 Remove VIRT_ADDR_VARIES no longer needed.
4063
f8fe6f96
EZ
40642011-11-19 Eli Zaretskii <eliz@gnu.org>
4065
4066 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4067 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4068 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4069 behave as if the cursor position were at the window margin.
4070
4071 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4072 and the cursor position is out of bounds, behave as if the cursor
4073 position were at the window margin. (Bug#10075)
4074
df05a53c
CY
40752011-11-18 Chong Yidong <cyd@gnu.org>
4076
4077 * window.c (Fwindow_combination_limit): Make first argument
4078 non-optional, since it is meaningless for live windows like the
4079 selected window.
61ccba97 4080
2071918e
DA
40812011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4082
4083 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4084
b50a28de
SM
40852011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4086
4087 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4088 (graft_intervals_into_buffer): Simplify.
4089
015137db
EZ
40902011-11-18 Eli Zaretskii <eliz@gnu.org>
4091
4092 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4093 hash values of the two rows.
4094 (copy_row_except_pointers): Preserve the used[] arrays and the
4095 hash values of the two rows. (Bug#10035)
68c95424 4096 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4097
4098 * xdisp.c (row_hash): New function, body extracted from
4099 compute_line_metrics.
4100 (compute_line_metrics): Call row_hash, instead of computing the
4101 hash code inline.
4102
4103 * dispnew.c (verify_row_hash): Call row_hash for computing the
4104 hash code of a row, instead of duplicating code from xdisp.c.
4105
4106 * dispextern.h (row_hash): Add prototype.
4107
a2addb04
TH
41082011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4109
4110 * frame.c (delete_frame): Don't delete the terminal when the last
4111 X frame is closed if emacs is built with GTK toolkit.
4112
df85d315
JB
41132011-11-17 Juanma Barranquero <lekktu@gmail.com>
4114
4115 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4116
a0c2d0ae
MR
41172011-11-17 Martin Rudalics <rudalics@gmx.at>
4118
4119 * window.c (Vwindow_splits): Rename to
4120 Vwindow_combination_resize. Suggested by Juri Linkov.
4121 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4122 of Vwindow_splits.
4123
58179cce
JB
41242011-11-16 Juanma Barranquero <lekktu@gmail.com>
4125
7877f373
JB
4126 * nsfns.m (Fns_font_name):
4127 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4128
b6f67890
MR
41292011-11-16 Martin Rudalics <rudalics@gmx.at>
4130
4131 * window.h (window): Rename slot "nest" to "combination_limit".
4132 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4133 (Fset_window_nest): Rename to Fset_window_combination_limit.
4134 (Vwindow_nest): Rename to Vwindow_combination_limit.
4135 (recombine_windows, make_parent_window, make_window)
4136 (Fsplit_window_internal, saved_window)
4137 (Fset_window_configuration, save_window_save): Rename all
4138 occurrences of window_nest to window_combination_limit.
4139
c7015153
JB
41402011-11-15 Juanma Barranquero <lekktu@gmail.com>
4141
4142 * image.c (imagemagick_load_image): Fix typo.
4143
322ad6ec
EZ
41442011-11-14 Eli Zaretskii <eliz@gnu.org>
4145
4146 * xdisp.c (display_line): Move the call to
4147 highlight_trailing_whitespace before the call to
4148 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4149 faces of all the glyphs to compute ROW's hash value.
4150 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4151
f067b8ec
JB
41522011-11-14 Juanma Barranquero <lekktu@gmail.com>
4153
4154 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4155 just return (bug#10044).
4156
1e5b2111
EZ
41572011-11-12 Eli Zaretskii <eliz@gnu.org>
4158
7ef3cbd5
EZ
4159 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4160 with user-defined heap size. Bump the default size of the temacs
4161 heap to 27MB, to avoid memory warning when running temacs.
4162 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4163
1e5b2111
EZ
4164 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4165 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4166 (verify_row_hash) [XASSERTS]: New function.
4167 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4168 that the hash value of glyph rows is correct.
1e5b2111 4169
89d61221
MR
41702011-11-12 Martin Rudalics <rudalics@gmx.at>
4171
4172 * window.h (window): Remove splits slot.
4173 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4174 (Fdelete_other_windows_internal, make_parent_window)
4175 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4176 (Fset_window_configuration, save_window_save): Don't deal with
4177 split status of windows.
4178 (saved_window): Remove splits slot.
4179 (Vwindow_splits): Rewrite doc-string.
4180
97f18cc8
JD
41812011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4182
4183 * xfns.c (unwind_create_frame):
4184 * nsfns.m (unwind_create_frame):
4185 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4186 Vframe_list (Bug#9999).
4187
22a648b4
DA
41882011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4189
0b381c7e 4190 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4191
659afede
KH
41922011-11-11 Kenichi Handa <handa@m17n.org>
4193
4194 * callproc.c (Fcall_process): Set the member dst_multibyte of
4195 process_coding.
4196
9ac0394b
KH
41972011-11-11 Johan Bockgård <bojohan@gnu.org>
4198
4199 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4200 avoid a crash (bug#9496).
4201
2fbdc249
CY
42022011-11-09 Chong Yidong <cyd@gnu.org>
4203
4204 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4205 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4206
ac6b1f81
PE
42072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4208
4209 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4210
09db192c
PE
42112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 Avoid some portability problems by eschewing 'extern inline' functions.
4214 The trivial performance wins aren't worth the portability hassles; see
4215 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4216 et seq.
4217 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4218 (window_box_width, window_box_left, window_box_left_offset)
4219 (window_box_right, window_box_right_offset): Undo previous change,
4220 by removing the "extern"s.
4221 * intervals.c (adjust_intervals_for_insertion)
4222 (adjust_intervals_for_deletion): Undo previous change,
4223 making these static again.
4224 (offset_intervals, temp_set_point_both, temp_set_point)
4225 (copy_intervals_to_string): No longer inline.
4226 * xdisp.c (window_text_bottom_y, window_box_width)
4227 (window_box_height, window_box_left_offset)
4228 (window_box_right_offset, window_box_left, window_box_right)
4229 (window_box): No longer inline.
4230
105216ed
CY
42312011-11-08 Chong Yidong <cyd@gnu.org>
4232
4233 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4234 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4235 Signal an error if not a live window.
105216ed
CY
4236 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4237 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4238
ae9e237f
JB
42392011-11-07 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * lisp.h (syms_of_abbrev): Remove declaration.
4242 Reported by CHENG Gao <chenggao@royau.me>.
4243
c7aa8333
EZ
42442011-11-07 Eli Zaretskii <eliz@gnu.org>
4245
4246 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4247 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4248 of temacs in GUI mode.
4249
be7f5545
MR
42502011-11-07 Martin Rudalics <rudalics@gmx.at>
4251
4252 * window.h: Declare delete_all_child_windows instead of
4253 delete_all_subwindows.
4254 * window.c (Fwindow_nest, Fset_window_nest)
4255 (Fset_window_new_total, Fset_window_new_normal)
4256 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4257 (delete_all_subwindows): Rename to delete_all_child_windows.
4258 (Fdelete_other_windows_internal, Fset_window_configuration):
4259 Call delete_all_child_windows instead of delete_all_subwindows.
4260 * frame.c (delete_frame): Call delete_all_child_windows instead
4261 of delete_all_subwindows.
4262
ca78dc43
PE
42632011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4264
4265 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4266 This is also needed for porting to any host where GC_MARK_STACK is
4267 not GC_MAKE_GCPROS_NOOPS.
4268 (which_symbols): Use it.
4269
a0241d01
KH
42702011-11-07 Kenichi Handa <handa@m17n.org>
4271
4272 * coding.c (coding_set_destination): Check coding->src_pos only
4273 when coding->src_object is a buffer (bug#9910).
4274
4275 * process.c (send_process): Set the member src_multibyte of coding
4276 to 0 (bug#9911) when sending a unibyte text.
4277
4278 * callproc.c (Fcall_process): Set the member src_multibyte of
4279 process_coding to 0 (bug#9912).
4280
a64bfdfa 42812011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4282
4283 * xmenu.c (cleanup_widget_value_tree): New function.
4284 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4285 calling free_menubar_widget_value_tree directly (Bug#9830).
4286
cb41b32a
PE
42872011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4288
4289 Fix some portability problems with 'inline'.
4290 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4291 (window_box_width, window_box_left, window_box_left_offset)
4292 (window_box_right, window_box_right_offset): Declare extern.
4293 Otherwise, these inline functions do not conform to C99 and
4294 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4295 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4296 * intervals.c (adjust_intervals_for_insertion)
4297 (adjust_intervals_for_deletion): Now extern, because otherwise the
4298 extern inline functions 'offset_intervals' couldn't refer to it.
4299 (static_offset_intervals): Remove.
4300 (offset_intervals): Rewrite using the old contents of
4301 static_offset_intervals. The old version didn't conform to C99
4302 because an extern inline function contained a reference to an
4303 identifier with static linkage.
4304
b7041366
AS
43052011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4306
4307 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4308 GC.
4309
88a37c4d
EZ
43102011-11-06 Eli Zaretskii <eliz@gnu.org>
4311
4312 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4313 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4314 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4315 return Qleft_to_right.
4316
49745b39
CY
43172011-11-06 Chong Yidong <cyd@gnu.org>
4318
4319 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4320 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4321 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4322 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4323 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4324 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4325 (Fwindow_vscroll): Doc fix.
4326 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4327 argument, since it makes no sense to pass a live window and for
4328 consistency with window-child.
4329
1f05cd82
CS
43302011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4331
4332 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4333 support MSVC.
4334
22610910
JR
43352011-11-05 Jason Rumney <jasonr@gnu.org>
4336
4337 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4338 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4339 fonts (Bug#6029).
4340 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4341 bitwise arithmetic preventing use of unicode-sip and non-truetype
4342 opentype fonts.
4343
a06776b2
EZ
43442011-11-05 Eli Zaretskii <eliz@gnu.org>
4345
3ad924ba
EZ
4346 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4347 "emacs"-only part.
4348
a06776b2
EZ
4349 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4350 initialization code to keep similarity to xfns.c after changes
4351 from 2011-11-05.
4352
c9e7db78
JD
43532011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4354
a97f8f3f
JD
4355 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4356 (unwind_create_frame): New function (Bug#9943).
4357 (Fx_create_frame): Restructure code to be more similar to the one in
4358 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4359 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4360 Move terminal->reference_count++ just before making the frame official
4361 (Bug#9943).
4362
4363 * nsterm.m (x_free_frame_resources): New function.
4364 (x_destroy_window): Move code to x_free_frame_resources.
4365
c9e7db78 4366 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4367 (Fx_create_frame, x_create_tip_frame):
4368 Move terminal->reference_count++ just before making the frame
75f1671a 4369 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4370 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4371
a6fc3b5c
EZ
43722011-11-05 Eli Zaretskii <eliz@gnu.org>
4373
4374 Support MSVC build with newer versions of Visual Studio.
4375 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4376 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4377 nt/gmake.defs.
4378
4379 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4380 which are not supported by MSVC.
4381 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4382 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4383 bitfields.
4384 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4385 types in bitfields.
4386 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4387
4388 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4389
58179cce 43902011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4391
4392 Support MSVC build with newer versions of Visual Studio.
4393 * w32.c: Don't include w32api.h for MSVC.
4394 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4395
4396 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4397 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4398 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4399 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4400 e_* cousins.
4401 (alloca) [_MSC_VER]: Define to _alloca.
4402
4403 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4404
4405 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4406
a58c13ed
EZ
44072011-11-04 Eli Zaretskii <eliz@gnu.org>
4408
4409 * xdisp.c (note_mouse_highlight): If either of
4410 previous/next-single-property-change returns nil, treat that as
4411 the beginning or the end of the buffer. (Bug#9955)
4412
fe0b6370
JD
44132011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4414
a58c13ed 4415 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4416 label is not null (Bug#9951).
4417 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4418 may be NULL.
4419
89bd5ee1
EZ
44202011-11-04 Eli Zaretskii <eliz@gnu.org>
4421
4422 * window.c (Fwindow_body_size): Mention in the doc string that the
4423 return value is in frame's canonical units. (Bug#9949)
4424
84c3edb9
EZ
44252011-11-03 Eli Zaretskii <eliz@gnu.org>
4426
4e2fb5c7
EZ
4427 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4428
84c3edb9 4429 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4430 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4431 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4432
bc17a887
EZ
44332011-11-01 Eli Zaretskii <eliz@gnu.org>
4434
4435 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4436 Don't stop backward scan on the continuation glyph, even though
4437 its CHARPOS is positive.
6d5eb5b0
SM
4438 (mouse_face_from_buffer_pos, note_mouse_highlight):
4439 Rename cover_string to disp_string.
bc17a887 4440
4ee88440
MR
44412011-11-01 Martin Rudalics <rudalics@gmx.at>
4442
4443 * window.c (temp_output_buffer_show): Don't use
4444 Vtemp_buffer_show_specifiers.
4445 (Vtemp_buffer_show_specifiers): Remove unused variable.
4446
c2ff3c02
EZ
44472011-10-30 Eli Zaretskii <eliz@gnu.org>
4448
4449 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4450 past the beginning of the current glyph matrix.
4451
58179cce 44522011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4453
4454 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4455 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4456 HAVE_GTK3 (Bug#9869).
b77a6a7f 4457
3b574623
JD
4458 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4459 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4460
b77a6a7f
JD
4461 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4462
4463 * xterm.c: Declare x_handle_net_wm_state to return int.
4464 (handle_one_xevent): Check if we are iconified but don't have
4465 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4466 (get_current_wm_state): Return non-zero if not hidden,
4467 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4468 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4469 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4470 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4471
196e41e4
PE
44722011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4475 so that this new function doesn't get optimized away by a
4476 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4477
021f2e1a
AS
44782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4479
4480 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4481
8b058d44
EZ
44822011-10-29 Eli Zaretskii <eliz@gnu.org>
4483
4484 Fix the `xbytecode' command.
4485 * .gdbinit (xprintbytestr): New command.
b50a28de 4486 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4487 (xbytecode): Print the byte-code string as well.
4488
4452fb80
EZ
44892011-10-29 Kim Storm <storm@cua.dk>
4490
8b058d44
EZ
4491 * alloc.c (which_symbols): New function.
4492
21b72067
AS
44932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4494
4495 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4496 line. (Bug#9903)
4497
83ed7b5c
GM
44982011-10-29 Glenn Morris <rgm@gnu.org>
4499
4500 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4501 Not clear what it was for, and it causes various bugs. (Bug#9839)
4502
5a7a728b
EZ
45032011-10-28 Eli Zaretskii <eliz@gnu.org>
4504
4505 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4506 possible random value that matches one of those tested as
4507 condition to clear the mouse face.
4508
d3d0842f
CY
45092011-10-28 Chong Yidong <cyd@gnu.org>
4510
4511 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4512
31b39d13
DN
45132011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4514
4515 * window.c (make_window): Initialize phys_cursor_on_p.
4516
9aba6043
SM
45172011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4518
4519 * lisp.h (struct Lisp_Symbol): Update comments.
4520
c20992f4
JB
45212011-10-28 Juanma Barranquero <lekktu@gmail.com>
4522
4523 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4524
db4f02f2
EZ
45252011-10-28 Eli Zaretskii <eliz@gnu.org>
4526
4527 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4528 <oslsachem@gmail.com> for helping to debug this.
4529
4530 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4531 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4532 (g_b_init_get_glyph_outline_w): New static variables.
4533 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4534 (GetGlyphOutlineW_Proc): New typedefs.
4535 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4536 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4537 New functions.
4538 (w32font_open_internal, compute_metrics):
4539 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4540 instead of calling the "wide" APIs directly.
4541
4542 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4543
4544 * w32.h (syms_of_w32font): Add prototype.
4545
87e68db4
JB
45462011-10-27 Juanma Barranquero <lekktu@gmail.com>
4547
4548 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4549 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4550 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4551 (Fmove_to_window_line): Doc fix.
4552
435c1d67
CY
45532011-10-27 Chong Yidong <cyd@gnu.org>
4554
4555 * process.c (make_process): Set gnutls_state to NULL.
4556
4557 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4558 non-NULL, regardless of GNUTLS_INITSTAGE.
4559 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4560 an error. Set process slots as soon as we allocate them.
4561
4562 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4563
9c6c6f49
CY
45642011-10-27 Chong Yidong <cyd@gnu.org>
4565
9aba6043
SM
4566 * gnutls.c (emacs_gnutls_deinit): New function.
4567 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4568 (Fgnutls_deinit, Fgnutls_boot): Use it.
4569
4570 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4571 (deactivate_process): Call emacs_gnutls_deinit.
4572
657d08d3
JB
45732011-10-27 Juanma Barranquero <lekktu@gmail.com>
4574
4575 * image.c (x_create_x_image_and_pixmap):
4576 * w32.c (sys_rename, w32_delayed_load):
4577 * w32font.c (fill_in_logfont):
4578 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4579
5430d399
JB
45802011-10-26 Juanma Barranquero <lekktu@gmail.com>
4581
4582 * w32fns.c (w32_default_color_map): New function,
4583 extracted from Fw32_default_color_map.
a7ef684b 4584 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4585
fe0055fa
PE
45862011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4587
4588 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4589
e6346438
SM
45902011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4591
4592 * keyboard.c (test_undefined): New function (bug#9751).
4593 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4594
e112cc37
ET
45952011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4596
4597 * sysdep.c (init_sys_modes): Fix the check for the controlling
4598 terminal (Bug#6649).
4599
7b5d6677
EZ
46002011-10-20 Eli Zaretskii <eliz@gnu.org>
4601
4602 * dispextern.h (struct bidi_it): New member next_en_type.
4603
4604 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4605 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4606 current character, check also for next_en_type being WEAK_EN.
4607 (bidi_resolve_weak): Don't enter the expensive loop if the current
4608 position is before next_en_pos. Record the bidi type of the first
4609 non-ET, non-BN character we find, in addition to its position.
4610 (bidi_level_of_next_char): Invalidate next_en_type when
4611 next_en_pos is over-stepped.
4612
7da0b018
PE
46132011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4614
4615 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4616 * editfns.c: Rewrite current-time-zone so that it invokes
4617 the equivalent of (format-time-string "%Z") to get the time zone name.
4618 This fixes a bug when the time zone name contains characters that
4619 need converting from the system time locale to Emacs internal format.
4620 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4621 that patch fixed format-time-string to do the conversion, but
4622 I forgot to fix current-time-zone.
4623 (format_time_string): New function, containing most of
4624 what Fformat_time_string used to contain.
4625 (Fformat_time_string): Rewrite in terms of format_time_string.
4626 This doesn't change this function's behavior.
4627 (current-time-zone): Rewrite to use format_time_string.
4628 This fixes the bug reported by Michael Schierl in
4629 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4630 Jason Rumney's 2007-06-07 change worked around this bug, but
4631 didn't fix it.
4632 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4633
8547b010
EZ
46342011-10-19 Eli Zaretskii <eliz@gnu.org>
4635
4636 * xdisp.c (start_display): If the character at POS is displayed
4637 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4638 (try_window_reusing_current_matrix): If a line ends in a display
4639 vector or the next line starts in a display vector, continue
4640 redrawing the window even though the character position of
4641 start_row was reached.
8547b010
EZ
4642 (Bug#9771, part 2)
4643
4e948d15
CY
46442011-10-18 Chong Yidong <cyd@gnu.org>
4645
4646 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4647 with nobreak-char-display too.
4648
4787455f
EZ
46492011-10-18 Eli Zaretskii <eliz@gnu.org>
4650
4651 Fix part 3 of bug#9771.
4652 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4653 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4654 non-neutral characters if the current character is a paragraph
4655 separator (a.k.a. Newline). This avoids running the same
4656 expensive loop twice, once when we consume the preceding newline
4657 and the other time when the line actually needs to be displayed.
4658 Avoid the loop when we see neutrals on the base embedding level
4659 following a character whose directionality is the same as the
4660 paragraph's. This avoids running the expensive loop when a line
4661 ends in a long sequence of neutrals, like control characters.
4662 Add assertion against STRONG_AL type. Slightly rearrange code
4663 that determines the type of a neutral given the first non-neutral
4664 that follows it.
4665 (bidi_level_of_next_char): Set next_en_pos to zero when
4666 invalidating its info.
4667
2c91f553
EZ
46682011-10-17 Eli Zaretskii <eliz@gnu.org>
4669
4670 * xdisp.c (push_display_prop): Determine whether to record string
4671 or buffer position by IT->string, not by IT->method. Allow
4672 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4673 (move_it_vertically_backward): Don't look for character position
4674 immediately after the newline when in a continuation line.
4675 (Bug#9771, part 1)
2c91f553 4676
c7b08b0d
MR
46772011-10-15 Martin Rudalics <rudalics@gmx.at>
4678
4679 * window.c (coordinates_in_window): Rewrite and delabelize
4680 vertical border check. (Bug#5357) (Bug#9618)
4681
6b02f655
SM
46822011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4683
4684 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4685 errors in XSetWindowBorder (bug#9310).
4686
81d40c92
DA
46872011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4688
4689 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4690 avoid crash when xmalloc overrun checking is enabled.
4691
d4172c3b
EZ
46922011-10-13 Eli Zaretskii <eliz@gnu.org>
4693
4694 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4695 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4696 cursor motion with <left> and <right> arrow keys.
4697
4698 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4699 some callers set that themselves.
4700
b00eea75
EZ
47012011-10-12 Eli Zaretskii <eliz@gnu.org>
4702
4703 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4704 display string and the previous row comes from the same string and
4705 is empty. (Bug#9739) (Bug#9738)
4706
8fe012c4
SM
47072011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4708
4709 * doc.c (get_doc_string): Encode file name (bug#9735).
4710
0074aef2
EZ
47112011-10-12 Eli Zaretskii <eliz@gnu.org>
4712
79beb178
EZ
4713 * bidi.c (bidi_level_of_next_char):
4714 * xdisp.c (get_visually_first_element): Remove old incorrect
4715 comments regarding the Unicode Line Separator character.
4716
0074aef2
EZ
4717 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4718
6e4b3fbe
DA
47192011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4720
4721 * alloc.c (Fgc_status): Do not access beyond zombies array
4722 boundary if nzombies > MAX_ZOMBIES.
4723 * alloc.c (dump_zombies): Add missing format specifier.
4724
0324f3af
PE
47252011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4726
b5525cac
PE
4727 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4728 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4729
0324f3af
PE
4730 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4731 Some packages use them to denote characters with modifiers.
4732
e9b5f888
AS
47332011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4734
4735 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4736 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4737 matching a pp-number. Rename parameter var to var1.
4738
127827c0
SM
47392011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4740
4741 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4742
c8fd3bd0
GM
47432011-10-08 Glenn Morris <rgm@gnu.org>
4744
4745 * callint.c (Fcall_interactively): Give a more explicit error for the
4746 'c' case with a non-character input. (Bug#8479)
4747
352ec8ff
EZ
47482011-10-08 Eli Zaretskii <eliz@gnu.org>
4749
03669ccb
EZ
4750 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4751 lines.
7061c986
EZ
4752 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4753 lines that are hscrolled on the left.
03669ccb 4754
352ec8ff
EZ
4755 * dispnew.c (buffer_posn_from_coords): Account for a possible
4756 presence of header-line. (Bug#4426)
4757
a66cfb1c
SM
47582011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4759
6b02f655
SM
4760 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4761 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4762
7c5ee88e
PE
47632011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4764
4765 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4766 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4767 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4768 this makes Emacs dump core during garbage collection on rare
4769 occasions. sizeof is obviously inferior to offsetof here, so
4770 stick with offsetof.
4771 (GC_POINTER_ALIGNMENT): New macro.
4772 (mark_memory): Omit 3rd (offset) arg; caller changed.
4773 Don't assume EMACS_INT alignment is the same as pointer alignment.
4774
df1bbe5b
SM
47752011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4776
4777 * keyboard.c (read_key_sequence_remapped): New var.
4778 (read_key_sequence): Compute remapping in the right buffer.
4779 (command_loop_1): Use read_key_sequence's remapping directly.
4780
51553db6
SM
47812011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4782
32c1fffd
SM
4783 * dired.c (file_name_completion): Don't expand file name.
4784 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4785 before checking file name handler.
4786
51553db6
SM
4787 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4788 they've been requested explicitly (bug#9591).
4789
b6bd1599 47902011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4791
4792 * keymap.c (Fsingle_key_description): Use make_specified_string
4793 instead of build_string to build string from push_key_description.
4794 (Bug#5193)
4795
f701dc2a
PE
47962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4797
4222c55d
PE
4798 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4799 This fixes a Y2038 bug on 64-bit hosts.
4800 * buffer.c (reset_buffer):
4801 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4802 (Fclear_buffer_auto_save_failure):
4803 Use 0, not -1, to represent an unset failure time, since time_t
4804 might not be signed.
4805
f701dc2a
PE
4806 Remove dependency on glibc malloc internals.
4807 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4808 Move back here from lisp.h, but with their new implementations.
4809 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4810 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4811 * charset.c (charset_table_init): New static var.
4812 (syms_of_charset): Use it instead of xmalloc. This removes a
4813 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4814 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4815 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4816 Move back to alloc.c.
4817 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4818 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4819
9ceebf39
JD
48202011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4821
4822 * nsterm.m (windowDidResize): Call x_set_window_size only when
4823 ns_in_resize is true. Otherwise set pixelwidth/height and
4824 call change_frame_size (Bug#9628).
4825
cb993c58
PE
48262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4827
3930c88b
PE
4828 Port --enable-checking=all to Fedora 14 x86-64.
4829 * charset.c (syms_of_charset): Also account for glibc malloc's
4830 internal overhead when calculating the initial malloc maximum.
4831
cb993c58
PE
4832 Port --enable-checking=all to Fedora 14 x86.
4833 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4834 Move to lisp.h.
4835 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4836 (overrun_check_realloc, overrun_check_free):
4837 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4838 That way, xmalloc returns a properly-aligned pointer even if
4839 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4840 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4841 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4842 into account when calculating the initial malloc maximum.
4843 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4844 Move here from alloc.c, so that charset.c can use it too.
4845 Properly align; the old code wasn't right for common 32-bit hosts
4846 when configured with --enable-checking=all.
4847 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4848 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4849
31bed486
EZ
48502011-09-29 Eli Zaretskii <eliz@gnu.org>
4851
04c70788 4852 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4853 use EDOM.
4854
fbcaa2f3
EZ
48552011-09-28 Eli Zaretskii <eliz@gnu.org>
4856
4857 * xdisp.c (compute_display_string_end): If there's no display
4858 string at CHARPOS, return -1.
4859
4860 * bidi.c (bidi_fetch_char): When compute_display_string_end
4861 returns a negative value, treat the character as a normal
4862 character not covered by a display string. (Bug#9624)
4863
a239d4e9
JB
48642011-09-28 Juanma Barranquero <lekktu@gmail.com>
4865
4866 * lread.c (Fread_from_string): Fix typo in docstring.
4867
88652fd5
EZ
48682011-09-27 Eli Zaretskii <eliz@gnu.org>
4869
4870 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4871 newline, reseat the iterator instead of bidi-iterating there one
4872 character at a time. (Bug#9610)
32c1fffd
SM
4873 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4874 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4875
ed497dd4
AS
48762011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4877
4878 * lread.c (readevalloop): Use correct code for NBSP.
4879 (read1): Likewise. (Bug#9608)
4880
b2bf61aa
MA
48812011-09-25 Michael Albinus <michael.albinus@gmx.de>
4882
4883 * dbusbind.c (Fdbus_register_signal): When service is not
4884 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4885
32bbb17c
GM
48862011-09-25 Glenn Morris <rgm@gnu.org>
4887
4888 * buffer.c (truncate-lines): Doc fix.
4889
94e0933e
CY
48902011-09-24 Chong Yidong <cyd@stupidchicken.com>
4891
4892 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4893 (Fset_window_next_buffers): Doc fix.
4894
cddde921
GM
48952011-09-24 Glenn Morris <rgm@gnu.org>
4896
4897 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4898
1260aef1
PE
48992011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4900
25b4bfa0
PE
4901 Fix minor problems found by static checking.
4902 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4903 * indent.c (Fvertical_motion): Fix == vs = typo.
4904
e3cbd34b
EZ
49052011-09-24 Eli Zaretskii <eliz@gnu.org>
4906
a66cfb1c
SM
4907 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4908 Default value is now t. Doc fix.
6bf7006f 4909
e3cbd34b 4910 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4911 logic when moving up, not only when moving down. Fix the
e3cbd34b 4912 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4913 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4914
4915 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4916 CHARPOS is covered by a display string which includes newlines.
4917 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4918 is covered by a display string with embedded newlines.
4919
a3de0cbd
MA
49202011-09-24 Michael Albinus <michael.albinus@gmx.de>
4921
4922 * dbusbind.c (Fdbus_register_signal): Add match rule to
4923 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4924 (Fdbus_register_method, Vdbus_registered_objects_table):
4925 Fix docstring.
a3de0cbd 4926
b260039d
JM
49272011-09-24 Jim Meyering <meyering@redhat.com>
4928
32c1fffd 4929 do not ignore write error for any output size
b260039d
JM
4930 The previous change was incomplete.
4931 While it makes emacs --batch detect the vast majority of stdout
4932 write failures, errors were still ignored whenever the output size is
4933 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4934 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4935 && echo FAIL: ignored write error
4936 FAIL: ignored write error
4937 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4938 && echo FAIL: ignored write error
4939 FAIL: ignored write error
4940 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4941
8eca8a7c
AS
49422011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4943
4944 * emacs.c (Fkill_emacs): In noninteractive mode exit
4945 non-successfully if a write error occurred on stdout. (Bug#9574)
4946
3341db62
EZ
49472011-09-21 Eli Zaretskii <eliz@gnu.org>
4948
4949 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4950 the xassert test.
4951
4952 * dispextern.h (struct it): Update the comment documenting what
4953 can it->OBJECT be.
4954
8c203dbf
EZ
49552011-09-20 Eli Zaretskii <eliz@gnu.org>
4956
4957 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4958 a display string, extend search for cursor position to end of row.
4959 (find_row_edges): If the row ends in a newline from a display
4960 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4961 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4962 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4963 non-empty line. Fixes confusing cursor motion with arrow keys at
4964 the beginning of a line that starts with whitespace.
8c203dbf 4965
a4824228
LMI
49662011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4967
4968 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4969 (bug#9493).
4970
33ed493b
CY
49712011-09-18 Chong Yidong <cyd@stupidchicken.com>
4972
4973 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4974 boolean (Bug#9154).
4975
56cd55c8
EZ
49762011-09-18 Eli Zaretskii <eliz@gnu.org>
4977
4978 * xdisp.c (display_line): Record maximum and minimum buffer
4979 positions even if no glyphs were produced (e.g., by a zero-width
4980 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4981 buffer positions that will be removed from the glyph row because
4982 they don't fit.
c02dcedf
EZ
4983 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4984 column is beyond frame width: don't subtract 1 "pixel" when
4985 computing width of the stretch.
3e62b7e0
EZ
4986 (reseat_at_next_visible_line_start): Undo the change made on
4987 2011-09-17 that saved paragraph information and restored it after
4988 the call to `reseat'. (Bug#9545)
56cd55c8 4989
5ed99d36 49902011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4991
4992 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4993 and turn window cursor on if cleared (Bug#9415).
4994
5ed99d36 49952011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4996
4997 * search.c (boyer_moore): Take unibyte characters from pattern
4998 literally. (Bug#9458)
4999
9bade7b2
EZ
50002011-09-18 Eli Zaretskii <eliz@gnu.org>
5001
5002 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5003
e5e9d610
PE
50042011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5005
87e4427a
PE
5006 Fix minor problem found by static checking.
5007 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5008 initialized, to pacify gcc -Wuninitialized.
5009
e5e9d610
PE
5010 * fileio.c: Report proper errno when syscall falls.
5011 (Finsert_file_contents): Save and restore errno,
5012 so that report_file_error outputs the correct diagnostic.
5013 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5014
a1674f0b
EZ
50152011-09-18 Eli Zaretskii <eliz@gnu.org>
5016
5017 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5018
fbfb6dd4
EZ
50192011-09-17 Eli Zaretskii <eliz@gnu.org>
5020
5021 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5022 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5023
bb187662
EZ
50242011-09-17 Eli Zaretskii <eliz@gnu.org>
5025
1137e8b8 5026 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5027 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5028
5029 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5030 (bidi_find_paragraph_start): Search back for paragraph beginning
5031 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5032 (bidi_move_to_visually_next): Only trigger paragraph-related
5033 computations when the last character is a newline or at EOB, not
5034 just any NEUTRAL_B. (Bug#9470)
5035
bb187662
EZ
5036 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5037 truncated lines if point is covered by a display string. (Bug#9524)
5038
2e621251
PE
50392011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5040
5041 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5042 (cons_to_x_long): New function.
5043 (lisp_data_to_selection_data): Use it. Correct the test for
5044 short-versus-long data; it was negated. Break out of vector
5045 loop, for efficiency, when a long datum is discovered.
5046
91a15bc6
SM
50472011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5048
5049 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5050
b41c3a35
EZ
50512011-09-16 Eli Zaretskii <eliz@gnu.org>
5052
5053 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5054 GCC PR/17406) by declaring this function with external scope.
5055
7812ba2d
PE
50562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5057
5058 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5059 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5060
cf7edc2a
AS
50612011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5062
5063 * editfns.c (Fformat): Correctly handle text properties on "%%".
5064
bd01620e
EZ
50652011-09-15 Eli Zaretskii <eliz@gnu.org>
5066
5067 * xterm.c (x_draw_composite_glyph_string_foreground):
5068 * w32term.c (x_draw_composite_glyph_string_foreground):
5069 * term.c (encode_terminal_code):
5070 * composite.c (composition_update_it, get_composition_id):
5071 * xdisp.c (get_next_display_element)
5072 (fill_composite_glyph_string): Add comments about special meaning
5073 of TAB characters in a composition.
5074
a02719a3
PE
50752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5076
5077 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5078 This occurs when processing a multibyte format.
5079 Problem reported by Wolfgang Jenker.
a02719a3 5080
72589a3c
JB
50812011-09-15 Johan Bockgård <bojohan@gnu.org>
5082
5083 * xdisp.c (try_cursor_movement): Only check for exact match if
5084 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5085
1c14176c
PE
50862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5087
5088 Remove unused external symbols.
5089 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5090 * xdisp.c (calc_pixel_width_or_height): Now static.
5091 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5092 * indent.c (check_display_width):
5093 * w32term.c: Fix comment to match code.
5094 * xterm.c, xterm.h (x_catching_errors): Remove.
5095
d2eea5b5
PE
50962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5097
5098 * xselect.c: Use signed conversions more consistently (Bug#9498).
5099 (selection_data_to_lisp_data): Assume incoming selection data are
5100 signed integers, not unsigned. This is to be consistent with
5101 outgoing selection data, which was modified to use signed integers
5102 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5103 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5104 expects long, not unsigned long.
5105
46888499
EZ
51062011-09-14 Eli Zaretskii <eliz@gnu.org>
5107
5108 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5109 computation of loop end. Reported by Johan Bockgård
5110 <bojohan@gnu.org>.
5111
ef8ef9fb
CY
51122011-09-13 Chong Yidong <cyd@stupidchicken.com>
5113
5114 * frame.c (Fother_visible_frames_p): Function deleted.
5115
fa819fed
EZ
51162011-09-12 Eli Zaretskii <eliz@gnu.org>
5117
5118 * indent.c (compute_motion): Process display vector front to back
5119 rather than the other way around. (Bug#2496)
5120
2ba8e008
SM
51212011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5122
5123 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5124
20f53c69
CY
51252011-09-11 Chong Yidong <cyd@stupidchicken.com>
5126
5127 * minibuf.c (Fread_from_minibuffer): Doc fix.
5128
d562d7a4
EZ
51292011-09-11 Eli Zaretskii <eliz@gnu.org>
5130
5131 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5132 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5133
1c4d7f3d
LMI
51342011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5135
5136 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5137 value for non-existent files.
5138
b885bf36
EZ
51392011-09-11 Eli Zaretskii <eliz@gnu.org>
5140
5141 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5142 set its "size" to -1. This will set the modtime_size field of
5143 the corresponding buffer to -1, which is what
5144 verify-visited-file-modtime expects for files that do not exist.
5145 (Bug#9139)
5146
6612f0bf
PE
51472011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5148
5149 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5150 here ...
5151 * lisp.h: ... from here. push_key_description is no longer
5152 defined in keyboard.c, so its declaration should not be in
5153 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5154 logically belongs with push_key_description.
5155
dfb3f755
PE
51562011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5157
5158 * buffer.h: Include <sys/types.h> instead of <time.h>.
5159 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5160 Problem reported by Herbert J. Skuhra.
5161
3134906c
LMI
51622011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5163
5164 * xml.c (parse_region): Make the parsing work for
5165 non-comment-starting XML files again (bug#9144).
5166
8d903f4e
AS
51672011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5168
5169 * image.c (gif_load): Fix calculation of bottom and right corner.
5170 (Bug#9468)
5171
80ad64f4
EZ
51722011-09-10 Eli Zaretskii <eliz@gnu.org>
5173
5174 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5175 redisplay in small windows.
5176
208a048d
EZ
51772011-09-09 Eli Zaretskii <eliz@gnu.org>
5178
5179 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5180
9b1c252e
MR
51812011-09-08 Martin Rudalics <rudalics@gmx.at>
5182
5183 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5184 Operate on live windows only.
5185
2949f33b
JB
51862011-09-08 Juanma Barranquero <lekktu@gmail.com>
5187
5188 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5189
e08dcafd
EZ
51902011-09-07 Eli Zaretskii <eliz@gnu.org>
5191
5192 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5193 only under bidi iteration.
5194
115b96bd
JD
51952011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5196
5197 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5198
c8199d0f
PE
51992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5200
5201 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5202 Without this fix, the command to link temacs failed due to an
5203 undefined symbol __builtin_isnan. This is because
5204 /usr/include/iso/math_c99.h #defines isnan(x) to
5205 __builtin_isnan(x), but the bundled gcc, which identifies itself
5206 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5207 a __builtin_isnan.
5208 * floatfns.c (isnan): #undef, and then #define to a clone of
5209 what's in data.c.
5210 (Fisnan): Always define, since it's always available now.
5211 (syms_of_floatfns): Always define isnan at the Lisp level.
5212
e39b275c 52132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5214
5215 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5216
b2db44d9 52172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5218
f4af5137 5219 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5220 The previous code assumed that file offsets (off_t values) fit in
5221 EMACS_INT variables, which is not true on typical 32-bit hosts.
5222 The code messed up by falsely reporting buffer overflow in cases
5223 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5224 when "big" contains more than 2**29 bytes, even though this
5225 inserts just one byte and does not overflow the buffer.
5226 (Finsert_file_contents): Store file offsets as off_t
5227 values, not as EMACS_INT values. Check for overflow when
5228 converting between EMACS_INT and off_t. When checking for
5229 buffer overflow or for overlap, take the offsets into account.
5230 Don't use EMACS_INT for small values where int suffices.
5231 When checking for overlap, fix a typo: ZV was used where
5232 ZV_BYTE was intended.
5233 (Fwrite_region): Don't assume off_t fits into 'long'.
5234 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5235
ecfc0a49
MA
52362011-09-05 Michael Albinus <michael.albinus@gmx.de>
5237
5238 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5239
6511acf2 52402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5241
0999621a 5242 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5243
5244 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5245 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5246 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5247 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5248 (modify_event_symbol): Do not assume that the length of
5249 name_alist_or_stem is safe to alloca and fits in int.
5250 (Fexecute_extended_command): Likewise for function name and binding.
5251 (Frecursion_depth): Wrap around reliably on integer overflow.
5252 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5253 since some callers pass EMACS_INT values.
5254 (Fsingle_key_description): Don't crash if symbol name contains more
5255 than MAX_ALLOCA bytes.
5256 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5257 (get_minibuffer): Arg is now EMACS_INT, not int.
5258 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5259 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5260 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5261
2be7d702
PE
5262 * dbusbind.c (signature_cat): New function.
5263 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5264 Do not overrun buffer; instead, report string overflow.
5265
9d1df220
PE
5266 * dispnew.c (add_window_display_history): Don't overrun buffer.
5267 Truncate instead; this is OK since it's just a log.
5268
33ef5c64
PE
5269 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5270 even if the time zone offset is outlandishly large.
5271 Don't mishandle offset == INT_MIN.
5272
66c6fdd5
PE
5273 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5274 when creating daemon; the previous buffer-overflow check was incorrect.
5275
d749b01b
PE
5276 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5277 which has the guts of the old verror function.
5278
b5cd1905
PE
5279 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5280 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5281
6e1a67fb
PE
5282 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5283 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5284 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5285 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5286 length of string rather than counting it via multiple sprintfs;
5287 that's simpler and more reliable.
c21721cc
PE
5288 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5289 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5290 sprintf, in case result does not fit in int.
5291
c57b67fc
PE
5292 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5293 (fontset_from_font): Print it.
5294
8a401434
PE
5295 * frame.c (tty_frame_count): Now printmax_t, not int.
5296 (make_terminal_frame, set_term_frame_name): Print it.
5297 (x_report_frame_params): In X, window IDs are unsigned long,
5298 not signed long, so print them as unsigned.
5299 (validate_x_resource_name): Check for implausibly long names,
5300 and don't assume name length fits in 'int'.
5301 (x_get_resource_string): Don't blindly alloca invocation name;
5302 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5303 not fit in int.
5304
6e1a67fb
PE
5305 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5306 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5307 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5308
0df02bf3
PE
5309 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5310 Use esprintf, not sprintf, in case result does not fit in int.
5311
48e30793
PE
5312 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5313 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5314 it as a large positive number.
5315 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5316 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5317
a66ff6d8
PE
5318 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5319 in case result does not fit in int.
5320
aca216ff
PE
5321 * print.c (float_to_string): Detect width overflow more reliably.
5322 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5323 buffer overrun. Don't assume list length fits in 'int'. Treat
5324 print length of 0 as 0, not as infinity; to be consistent with other
5325 uses of print length in this function. Don't overflow print length
5326 index. Don't assume hash table size fits in 'long', or that
5327 vectorlike size fits in 'unsigned long'.
5328
31c286f7
PE
5329 * process.c (make_process): Use printmax_t, not int, to format
5330 process-name gensyms.
5331
55e5faa1
PE
5332 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5333
80f2e268
PE
5334 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5335 to avoid potential buffer overrun.
5336
670741ab
PE
5337 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5338 if X resource line is longer than 512 bytes.
5339
b7163a50
PE
5340 * xfns.c (x_window): Make sprintf buffer a bit bigger
5341 to avoid potential buffer overrun.
5342
ae58ff1f
PE
5343 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5344
c43c8a6a
PE
5345 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5346
3f8236f4
PE
53472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5348
53e9fe90 5349 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5350 Without these, Emacs silently mishandles large integers sometimes.
5351 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5352 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5353
6511acf2
PE
5354 * xdisp.c (try_window_id): Check Emacs fixnum range before
5355 converting to 'int'.
806add1d 5356
6511acf2 5357 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5358 Check that an Emacs fixnum is in range before assigning it to 'int'.
5359 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5360 values converted from Emacs fixnums.
5361 (Frecenter): Don't wrap around a line count if it is out of 'int'
5362 range; instead, treat it as an extreme value.
5363 (Fset_window_configuration, compare_window_configurations):
5364 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5365
6511acf2
PE
5366 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5367 that can exceed INT_MAX. Check that EMACS_INT value is in range
5368 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5369 (match_limit): Don't assume that a fixnum can fit in 'int'.
5370
6511acf2 5371 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5372 exceed INT_MAX.
5373
6511acf2 5374 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5375 (Fvertical_motion): Don't wrap around LINES values that don't fit
5376 in 'int'. Instead, treat them as extreme values. This is good
5377 enough for windows, which can't have more than INT_MAX lines anyway.
5378
fcb901a7
LMI
53792011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5380
0f2f6b6d
LMI
5381 * Require libxml/parser.h to avoid compilation warning.
5382
fcb901a7
LMI
5383 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5384
5385 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5386 since this reportedly can destroy thread storage.
5387
6e20a0d4
CY
53882011-08-30 Chong Yidong <cyd@stupidchicken.com>
5389
5390 * syntax.c (find_defun_start): Update all cache variables if
5391 exiting early (Bug#9401).
5392
148ae00e
EZ
53932011-08-30 Eli Zaretskii <eliz@gnu.org>
5394
f6cfbd8f
EZ
5395 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5396
148ae00e
EZ
5397 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5398 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5399 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5400
5401 * term.c (tty_append_glyph): New function.
5402 (produce_stretch_glyph): Static function and its prototype deleted.
5403
a66cfb1c
SM
5404 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5405 Add prototypes.
148ae00e 5406
c4a07a4c
PE
54072011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5408
5409 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5410 when checking :margin (Bug#9390).
5411 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5412 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5413 so that the name doesn't mislead. All uses changed.
5414
6bc8cd65
JB
54152011-08-28 Johan Bockgård <bojohan@gnu.org>
5416
5417 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5418 set_tty_hooks.
5419
dca4927e
EZ
54202011-08-27 Eli Zaretskii <eliz@gnu.org>
5421
5422 * xdisp.c (move_it_to): Don't bail out early when reaching
5423 position beyond to_charpos, if we are scanning backwards.
5424 (move_it_vertically_backward): When DY == 0, make sure we get to
5425 the first character in the line after the newline.
5426
f2cad773
PE
54272011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5428
5429 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5430 (ccl_driver): Do not generate an out-of-range pointer.
5431 (Fccl_execute_on_string): Remove unnecessary check for
5432 integer overflow, noted by Stefan Monnier in
5433 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5434 Remove a FIXME that didn't need fixing.
5435 Simplify the newly-introduced buffer reallocation code.
5436
0cae2cdb
JB
54372011-08-27 Juanma Barranquero <lekktu@gmail.com>
5438
5439 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5440
5fc295a4 54412011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5442
70c60eb2 5443 Integer and memory overflow issues (Bug#9196).
726e0ab1 5444
d31850da
PE
5445 * doc.c (get_doc_string): Rework so that
5446 get_doc_string_buffer_size is the actual buffer size, rather than
5447 being 1 less than the actual buffer size; this makes xpalloc more
5448 convenient.
5449
a69fbedb
PE
5450 * image.c (x_allocate_bitmap_record, cache_image):
5451 * xselect.c (Fx_register_dnd_atom):
5452 Simplify previous changes by using xpalloc.
5453
fe5c5d37
PE
5454 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5455 since either will do and ptrdiff_t is convenient with xpalloc.
5456
0065d054
PE
5457 * charset.c (charset_table_size)
5458 (struct charset_sort_data.priority): Now ptrdiff_t.
5459 (charset_compare): Don't overflow if priorities differ greatly.
5460 (Fsort_charsets): Don't assume list length fits in int.
5461 Check for size-calculation overflow when allocating sort data.
5462 (syms_of_charset): Allocate an initial charset table that is
5463 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5464
5465 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5466
5467 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5468 The actual value is always <= INT_MAX, and leaving it unsigned made
5469 overflow checking harder.
5470
5471 * dispextern.h (struct glyph_matrix.rows_allocated)
5472 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5473 with xpalloc. The values are still always <= INT_MAX.
5474
5475 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5476
5477 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5478 (SAFE_NALLOCA): New macro.
5479
5480 * region-cache.c (struct boundary.pos, find_cache_boundary)
5481 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5482 (set_cache_region, invalidate_region_cache)
5483 (revalidate_region_cache, know_region_cache, region_cache_forward)
5484 (region_cache_backward, pp_cache):
5485 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5486 so that ptrdiff_t * can be passed to xpalloc.
5487 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5488 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5489 (pp_cache): Don't assume cache_len fits in int.
5490 * region-cache.h: Adjust extern decls to match.
5491
5492 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5493 EMACS_INT, since either will do, for xpalloc.
5494
5495 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5496 (xnmalloc, xnrealloc, xpalloc): New functions.
5497
726e0ab1
PE
5498 * bidi.c (bidi_shelve_header_size): New constant.
5499 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5500 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5501
51f30bc5 5502 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5503 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5504 (overlay_strings):
5505 Don't update size of array until after memory allocation succeeds,
5506 because xmalloc/xrealloc may not return.
0065d054
PE
5507 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5508 now that we have proper integer overflow checking.
5509 (record_overlay_string, overlay_strings): Catch overflows when
5510 calculating size of overlay_str_buf.
726e0ab1 5511
0065d054
PE
5512 * callproc.c (Fcall_process): Check for size overflow when
5513 calculating size of args2.
5514 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5515 Normally we prefer signed values, but sticking with ptrdiff_t would
5516 require adding more-complicated checks.
726e0ab1
PE
5517
5518 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5519 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5520 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5521 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5522
5523 * character.c (Fstring): Check for size-calculation overflow.
5524
5525 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5526 unnecessary integer overflow. Check for size overflow.
5527 (encode_coding_object): Don't update size until xmalloc succeeds.
5528
5529 * composite.c (get_composition_id): Check for overflow in glyph
5530 length calculations.
5531
5532 Integer and memory overflow fixes for display code.
5533 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5534 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5535 (scrolling_window): Check for overflow in size calculations.
5536 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5537 Don't assume glyph table len fits in int.
5538 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5539 (row_table_size): Now ptrdiff_t, not int.
5540 (scrolling_window): Avoid overflow in size calculations.
5541 Don't update size until allocation succeeds.
5542 * fns.c (concat): Check for overflow in size calculations.
5543 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5544 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5545 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5546
5547 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5548 (get_doc_string): Check for size calculation overflow.
5549 Don't update size until allocation succeeds.
5550 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5551 EMACS_INT, where ptrdiff_t will do.
5552 (Fsubstitute_command_keys): Check for string overflow.
5553
5554 * editfns.c (set_time_zone_rule): Don't assume environment length
5555 fits in int.
5556 (message_length): Now ptrdiff_t, not int.
5557 (Fmessage_box): Don't update size until allocation succeeds.
5558 Don't assume message length fits in int.
5559 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5560
0065d054
PE
5561 * emacs.c (main): Do not reallocate argv, since there is a null at
5562 the end that can be overwritten, and this way there's no need to
5563 worry about size-calculation overflow.
5564 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5565
5566 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5567 alloc succeeds.
5568 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5569
5570 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5571 (x_set_scroll_bar_width, x_figure_window_size):
5572 Check for integer overflow.
5573 (x_set_alpha): Do not assume XINT fits in int.
5574
5575 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5576 This is for the members text_lines, text_cols, total_lines, total_cols,
5577 where the system imposes an 'int' limit.
5578
5579 * fringe.c (Fdefine_fringe_bitmap):
5580 Don't update size until alloc works.
5581
5582 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5583 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5584
5585 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5586 Check for size-calculation overflow.
5587 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5588 do, as we prefer signed integers.
5589 (id_to_widget.max_size, id_to_widget.used)
5590 (xg_store_widget_in_map, xg_remove_widget_from_map)
5591 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5592 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5593 Use and return ptrdiff_t, not int.
5594 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5595 * gtkutil.h: Change prototypes to match the above.
5596
5597 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5598 are duplicate now that they've been promoted to lisp.h.
5599 (x_allocate_bitmap_record, x_alloc_image_color)
5600 (make_image_cache, cache_image, xpm_load):
5601 Don't update size until alloc is done.
5602 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5603 (x_detect_edges):
3256efce 5604 Check for size calculation overflow.
726e0ab1
PE
5605 (ct_colors_allocated_max): New constant.
5606 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5607 overflow.
3256efce 5608
726e0ab1
PE
5609 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5610 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5611 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5612 Use ptrdiff_t, not int, to count maps.
5613 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5614 calculations. Don't update size until allocation succeeds.
5615 Redo calculations to avoid overflow.
726e0ab1
PE
5616 * keyboard.h: Change prototypes to match the above.
5617
5618 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5619 to count maps.
5620 (current_minor_maps): Check for size calculation overflow.
5621 * keymap.h: Change prototypes to match the above.
5622
5623 * lread.c (read1, init_obarray): Don't update size until alloc done.
5624
5625 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5626 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5627
726e0ab1
PE
5628 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5629 Now ptrdiff_t, not int.
5630 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5631 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5632
5633 * process.c (Fnetwork_interface_list): Check for overflow
5634 in size calculation.
5635
5636 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5637
5638 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5639 overflow. Don't bother calling xmalloc when xrealloc will do.
5640
5641 * search.c (Freplace_match): Check for size calculation overflow.
5642 (Fset_match_data): Don't assume list lengths fit in 'int'.
5643
5644 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5645 for command line length. Do not attempt to address one before the
5646 beginning of an array, as that's not portable.
5647
5648 * term.c (max_frame_lines): Remove; unused.
5649 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5650 not int.
5651 (encode_terminal_code, calculate_costs): Check for size
5652 calculation overflow.
5653 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5654 table lengths and related sizes. Don't update size until alloc
5655 done. Redo calculations to avoid overflow.
5656 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5657
5658 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5659 subtracting pointers.
5660 (gobble_line): Check for overflow more carefully. Don't update size
5661 until alloc done.
5662
5663 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5664 Don't update size until alloc done.
5665 Redo size calculations to avoid overflow.
5666 Check for size calculation overflow.
0065d054 5667 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5668
5669 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5670 Use ptrdiff_t, not int, for sizes.
5671 (store_mode_line_noprop_char): Don't update size until alloc done.
5672
0065d054
PE
5673 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5674 Use ptrdiff_t, not int, for sizes.
5675 (Finternal_make_lisp_face, cache_face):
5676 Check for size calculation overflow.
5677 (cache_face): Treat size calculation overflows as if they were
5678 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5679
5680 * xfns.c (x_encode_text, x_set_name_internal)
5681 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5682 sizes, since they can exceed INT_MAX in size. Check for size
5683 calculation overflow.
5684
0065d054
PE
5685 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5686 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5687 Don't update size until alloc done.
5688
0065d054 5689 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5690 as sprintf is limited to int lengths.
1d526e2f 5691
252c5ee1
PE
5692 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5693 (X_LONG_MIN): New macros.
864d7ce7
PE
5694 Use them to make the following changes clearer.
5695 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5696 This change doesn't affect the value now, but it may help remind
5697 future maintainers not to raise the value too much later.
5698 (SELECTION_QUANTUM): Remove, replacing with ...
5699 (selection_quantum): ... new function, which avoids overflow.
5700 All uses changed.
5701 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5702 assumption that selection length fits in 'int'.
5703 (x_reply_selection_request, x_handle_selection_request)
5704 (x_get_window_property, receive_incremental_selection)
5705 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5706 (lisp_data_to_selection_data, clean_local_selection_data):
5707 Use ptrdiff_t, not int, to record length of selection.
5708 (x_reply_selection_request, x_get_window_property)
5709 (receive_incremental_selection, x_property_data_to_lisp):
5710 Redo calculations to avoid overflow.
5711 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5712 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5713 something.
5714 (x_get_window_property, receive_incremental_selection)
5715 (lisp_data_to_selection_data, x_property_data_to_lisp):
5716 Check for size-calculation overflow.
5717 (x_get_window_property, receive_incremental_selection)
5718 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5719 Don't store size until memory allocation succeeds.
5720 (x_get_window_property): Plug memory leak on memory exhaustion.
5721 Don't double-block input; malloc is safe here. Don't assume 2**34
5722 - 4 fits in unsigned long. Add an xassert to check
5723 XGetWindowProperty overflow. Be more careful about overflow
5724 calculations, and distinguish size from memory overflow better.
5725 (receive_incremental_selection): When tracing, don't assume
5726 unsigned int is less than INT_MAX.
5727 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5728 harmful) conversions of unsigned short to int.
5729 (lisp_data_to_selection_data): Don't assume that integers
5730 in the range -65535 through -1 fit in an X unsigned short.
5731 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5732 result parameters unless successful. Rely on cons_to_unsigned
5733 to report problems with elements; the old code wasn't right anyway.
5734 (x_check_property_data): Check for int overflow; we cannot use
5735 a wider type due to X limits.
5736 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5737
726e0ab1 5738 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5739
0065d054
PE
5740 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5741 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5742 (x_color_cells): Don't store size until memory allocation succeeds.
5743 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5744 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5745 (x_term_init): Don't assume length fits in int (sprintf is limited
5746 to int size).
bc18e09d 5747
ebfa62c0
PE
5748 Use ptrdiff_t for composition IDs.
5749 * character.c (lisp_string_width):
5750 * composite.c (composition_table_size, n_compositions)
5751 (get_composition_id, composition_gstring_from_id):
5752 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5753 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5754 * window.c (Frecenter):
5755 Use ptrdiff_t, not int, for composition IDs.
5756 * composite.c (get_composition_id): Check for integer overflow.
5757 * composite.h: Adjust prototypes to match the above changes.
5758
d3411f89
PE
5759 Use ptrdiff_t for hash table indexes.
5760 * category.c (hash_get_category_set):
5761 * ccl.c (ccl_driver):
5762 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5763 * coding.c (coding_system_charset_list, detect_coding_system):
5764 * coding.h (struct coding_system.id):
5765 * composite.c (get_composition_id, gstring_lookup_cache):
5766 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5767 * image.c (xpm_get_color_table_h):
5768 * lisp.h (hash_lookup, hash_put):
5769 * minibuf.c (Ftest_completion):
5770 Use ptrdiff_t for hash table indexes, not int (which is too
5771 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5772 32-bit --with-wide-int hosts).
5773
e097a6fa
PE
5774 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5775 Add a FIXME comment about memory leaks.
5776 (syms_of_charset): Don't assume xmalloc returns.
5777
5637687f
PE
5778 Don't assume that stated character widths fit in int.
5779 * character.c (Fchar_width, c_string_width, lisp_string_width):
5780 * character.h (CHAR_WIDTH):
5781 * indent.c (MULTIBYTE_BYTES_WIDTH):
5782 Use sanitize_char_width to avoid undefined and/or bad behavior
5783 with outlandish widths.
a66cfb1c 5784 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5785 now that we have two such functions. All uses changed.
5786 (sanitize_char_width): New inline function.
5787
a2271ba2
PE
5788 Don't assume that tab-width fits in int.
5789 * character.h (sanitize_width): New inline function.
5790 (SANE_TAB_WIDTH): New macro.
5791 (ASCII_CHAR_WIDTH): Use it.
5792 * indent.c (sane_tab_width): Remove. All uses replaced by
5793 SANE_TAB_WIDTH (current_buffer).
5794 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5795
18c52557
PE
5796 * fileio.c: Integer overflow issues with file modes.
5797 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5798
caeeedc1
PE
5799 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5800 Remove unreachable code.
5801 (read_hex, load_charset_map_from_file): Check for integer overflow.
5802
6df6ae42 5803 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5804 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5805 (x_send_scroll_bar_event): Likewise. Check that the size does not
5806 exceed limits imposed by XClientMessageEvent, as well as the usual
5807 ptrdiff_t and size_t limits.
5808
b13995db
PE
5809 * keyboard.c: Overflow, signedness and related fixes.
5810 (make_lispy_movement): Use same integer type in forward decl
5811 that is used in the definition.
5812 (read_key_sequence, keyremap_step):
5813 Change bufsize argument back to int, undoing my 2011-03-30 change.
5814 We prefer signed types, and int is wide enough here.
5815 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5816 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5817 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5818 length, not size_t. Use ptrdiff_t for index, not int.
5819 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5820 possibility of integer overflow.
5821
13464394
PE
5822 Overflow, signedness and related fixes for images.
5823
5824 * dispextern.h (struct it.stack[0].u.image.image_id)
5825 (struct_it.image_id, struct image.id, struct image_cache.size)
5826 (struct image_cache.used, struct image_cache.ref_count):
5827 * gtkutil.c (update_frame_tool_bar):
5828 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5829 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5830 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5831 * nsmenu.m (update_frame_tool_bar):
5832 * xdisp.c (calc_pixel_width_or_height):
5833 * xfns.c (image_cache_refcount):
5834 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5835 on typical 64-bit hosts.
5836
5837 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5838 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5839 Omit unnecessary casts to int.
5840 (parse_image_spec): Check that integers fall into 'int' range
5841 when the callers expect that.
5842 (image_ascent): Redo ascent calculation to avoid int overflow.
5843 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5844 (lookup_image): Remove unnecessary tests.
5845 (xbm_image_p): Locals are now of int, not EMACS_INT,
5846 since parse_image_check makes sure they fit into int.
5847 (png_load, gif_load, svg_load_image):
5848 Prefer int to unsigned where either will do.
5849 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5850 old tiff_error_handler and tiff_warning_handler.
5851 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5852 stack buffer overflows. It uses only the features of vsnprintf
5853 that are common to both POSIX and native Microsoft.
5854 (tiff_error_handler, tiff_warning_handler): Use it.
5855 (tiff_load, gif_load, imagemagick_load_image):
5856 Don't assume :index value fits in 'int'.
5857 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5858 (imagemagick_load_image): Check that crop parameters fit into
5859 the integer types that MagickCropImage accepts. Don't assume
5860 Vimagemagick_render_type has a nonnegative value. Don't assume
5861 size_t fits in 'long'.
5862 (gs_load): Use printmax_t to print the widest integers possible.
5863 Check for integer overflow when computing image height and width.
5864
c11821d4
EZ
58652011-08-26 Eli Zaretskii <eliz@gnu.org>
5866
5867 * xdisp.c (redisplay_window): Don't force window start if point
5868 will be invisible in the resulting window. (Bug#9324)
5869
0c95fcf7
EZ
58702011-08-25 Eli Zaretskii <eliz@gnu.org>
5871
5872 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5873 the display spec is of the form `(space ...)'.
5874 (handle_display_spec): Return the value returned by
5875 handle_single_display_spec, not just 1 or zero.
5876 (handle_single_display_spec): If the display spec is of the form
5877 `(space ...)', and specifies display in the text area, return 2
5878 rather than 1.
fee65a97 5879 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5880 accurately, and prefer exact match for point under bidi.
5881 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5882
5883 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5884 into disp_prop; all users changed.
5885
5886 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5887 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5888 for the text covered by the display property.
5889
e4ed06f1
CY
58902011-08-25 Chong Yidong <cyd@stupidchicken.com>
5891
5892 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5893 Change return value to nil.
5894 (Frecord_buffer): Delete unused function.
5895
f67cdd7f
EZ
58962011-08-24 Eli Zaretskii <eliz@gnu.org>
5897
5980d4c6
EZ
5898 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5899 buffers, return left-to-right.
8610fe8b
EZ
5900 (set_cursor_from_row): Consider candidate row a win if its glyph
5901 represents a newline and point is on that newline. Fixes cursor
5902 positioning on the newline at EOL of R2L text within L2R
5903 paragraph, and vice versa.
5904 (try_cursor_movement): Check continued rows, in addition to
5905 continuation rows. Fixes unwarranted scroll when point enters a
5906 continued line of R2L text within an L2R paragraph, or vice versa.
5907 (cursor_row_p): Consider the case of point being equal to
5908 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5909 from the end of a short line to the beginning of a continued line
5910 of R2L text within L2R paragraph.
5911 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5912 composed characters.
5980d4c6 5913
f67cdd7f
EZ
5914 * bidi.c (bidi_check_type): Use xassert.
5915 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5916 members.
5917
bca633fb
EZ
59182011-08-23 Eli Zaretskii <eliz@gnu.org>
5919
5920 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5921 a character.
5922
4a5885a7
CY
59232011-08-23 Chong Yidong <cyd@stupidchicken.com>
5924
5925 * nsfont.m (ns_otf_to_script): Fix typo.
5926
0902a04e
KH
59272011-08-22 Kenichi Handa <handa@m17n.org>
5928
5929 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5930 extra slot even if the purpose is char-code-property-table.
5931
1a2e6670
EZ
59322011-08-23 Eli Zaretskii <eliz@gnu.org>
5933
8ddde651
EZ
5934 * xdisp.c (redisplay_window): When computing centering_position,
5935 account for the height of the header line. (Bug#8874)
5936
425cc014
EZ
5937 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5938 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5939 candidate is selected by the mouse, and that candidate has a
5940 composed character under the mouse.
5941
1a2e6670
EZ
5942 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5943 coordinates reported by pos-visible-in-window-p for a composed
5944 character in column zero.
5945
8b76d6f8
SM
59462011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5947
5948 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5949
dac347dd
EZ
59502011-08-22 Eli Zaretskii <eliz@gnu.org>
5951
5952 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5953 consider it a hit if to_charpos is anywhere in the range of the
5954 composed buffer positions.
5955
e013fb34
CY
59562011-08-22 Chong Yidong <cyd@stupidchicken.com>
5957
5958 * image.c (gif_load): Don't assume that each subimage has the same
5959 dimensions as the base image. Handle disposal method that is
5960 "undefined" by the gif spec (Bug#9335).
5961
bd1ba3e8
CY
59622011-08-20 Chong Yidong <cyd@stupidchicken.com>
5963
5964 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5965 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5966
54a1215b
EZ
59672011-08-19 Eli Zaretskii <eliz@gnu.org>
5968
823564e5
EZ
5969 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5970 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5971 from an Org mode buffer to a Speedbar frame.
5972
54a1215b
EZ
5973 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5974 a composition, take its buffer position from IT->cmp_it.charpos.
5975 Fixes cursor positioning at the beginning of a line that begins
5976 with a composed character.
5977
9778ebcc
EZ
59782011-08-18 Eli Zaretskii <eliz@gnu.org>
5979
0be6ee06
EZ
5980 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5981 character bidirectional type, use STRONG_L instead. Fixes crashes
5982 in a buffer produced by `describe-categories'.
5983
9778ebcc
EZ
5984 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5985 members before the level stack, so they would be saved and
5986 restored when copying iterator state. Fixes incorrect reordering
5987 around TABs covered by display properties.
5988
156bffbe
AS
59892011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5990
6b02f655 5991 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5992
72ad093b
CY
59932011-08-17 Chong Yidong <cyd@stupidchicken.com>
5994
5995 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5996 (internal_condition_case_2, internal_condition_case_n):
5997 Remove unnecessary aborts (Bug#9081).
72ad093b 5998
35774242
EZ
59992011-08-17 Eli Zaretskii <eliz@gnu.org>
6000
6001 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6002 has no `load' handler, try opening the file locally. (Bug#9311)
6003
db76dd85
KB
60042011-08-16 Ken Brown <kbrown@cornell.edu>
6005
6006 * gmalloc.c: Expand comment.
6007
b215eee5
EZ
60082011-08-16 Eli Zaretskii <eliz@gnu.org>
6009
6010 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6011 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6012
a4579d33
KB
60132011-08-16 Ken Brown <kbrown@cornell.edu>
6014
6015 Fix memory allocation problems in Cygwin build (Bug#9273).
6016
6017 * unexcw.c ( __malloc_initialized): Declare external variable.
6018 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6019
8b76d6f8
SM
6020 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6021 New variables.
a4579d33
KB
6022 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6023 dumped emacs.
6024 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6025 in the static heap.
6026 [CYGWIN] (special_realloc): New function.
6027 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6028 requests to realloc storage in the static heap.
6029
3ebec551
PE
60302011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6031
6032 * bidi.c (bidi_initialize): Remove unused local.
6033
9fd8be00
EZ
60342011-08-15 Eli Zaretskii <eliz@gnu.org>
6035
6b02f655
SM
6036 * bidimirror.h:
6037 * biditype.h: Remove file.
6038 * makefile.w32-in ($(BLD)/bidi.$(O)):
6039 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6040
6041 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6042
6043 * chartab.c: Improve commentary for the uniprop_table API.
6044
32413314
EZ
6045 * bidi.c (bidi_paragraph_init): Support zero value of
6046 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6047 (bidi_initialize): Use uniprop_table instead of including
6048 biditype.h and bidimirror.h.
32413314 6049
9fd8be00
EZ
6050 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6051 coordinates of the iterator when restoring from ppos_it.
6052 (Bug#9296)
6053
5cf2b69b
KH
60542011-08-14 Kenichi Handa <handa@m17n.org>
6055
6056 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6057 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6058
daf17d00
EZ
60592011-08-14 Eli Zaretskii <eliz@gnu.org>
6060
6061 * xdisp.c (move_it_in_display_line_to): Don't invoke
6062 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6063 ppos_it. Fixes vertical cursor motion when line beginning is
6064 covered by an image. (Bug#9296)
6065
08e3161a
JD
60662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6067
6068 * nsterm.h (ns_run_ascript): Declare.
6069 (NSAPP_DATA2_RUNASSCRIPT): Define.
6070
6071 * nsfns.m (as_script, as_result, as_status): New static variables.
6072 (ns_run_ascript): New function.
5e617bc2 6073 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6074 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6075 the event loop. Get status from as_status (Bug#7276).
6076
6077 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6078 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6079 the event loop (Bug#7276).
6080
a3720aa2
AS
60812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6082
6083 * gnutls.c (QCgnutls_bootprop_priority)
6084 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6085 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6086 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6087 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6088 (QCgnutls_bootprop_verify_hostname_error)
6089 (QCgnutls_bootprop_callbacks_verify): Rename from
6090 Qgnutls_bootprop_..., all uses changed.
6091
6092 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6093 uses changed.
6094
0a0d27fb
PE
60952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6096
19d5c50c
PE
6097 * xfaces.c (Qframe_set_background_mode): Now static.
6098 * dispextern.h (Qframe_set_background_mode): Remove decl.
6099
0a0d27fb
PE
6100 * process.c (Fnetwork_interface_info): Declare local only if needed.
6101
377538cb
JD
61022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6103
6104 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6105 (Fnetwork_interface_list): Allocate in increments of bytes instead
6106 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6107 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6108 sockaddr.
6109 (struct ifflag_def): notrailers is smart on OSX.
6110 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6111 Get hardware address with getifaddrs if available.
6112
08fff70c
EZ
61132011-08-12 Eli Zaretskii <eliz@gnu.org>
6114
6115 * xdisp.c (iterate_out_of_display_property): xassert that
6116 IT->position is set to within IT->object's boundaries. Break from
6117 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6118 when IT->position is set up wrongly due to some bug.
6119 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6120 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6121 entry. Force push_it to save on the stack the current
6122 buffer/string position, to be restored by pop_it. Fix flags in
6123 the iterator structure wrt the object coming from a display
6124 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6125 properties. (Bug#9284)
6126
7be1c708 61272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6128
7be1c708
CY
6129 * fontset.c (fontset_get_font_group): Add proper type checks.
6130 (Bug#9172)
aac0c6e3 6131
7be1c708 61322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6133
7be1c708
CY
6134 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6135 and LC_VERSION_MIN_MACOSX.
6136 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6137 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6138
97bb72a6
EZ
61392011-08-08 Eli Zaretskii <eliz@gnu.org>
6140
6141 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6142 no-display-properties-and-no-overlays under bidi display.
6143 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6144 properties and overlays.
97bb72a6 6145
d5617611
CY
61462011-08-08 Chong Yidong <cyd@stupidchicken.com>
6147
37e11a63
CY
6148 * editfns.c (Fset_time_zone_rule): Document relationship with the
6149 setenv function.
6150
d5617611
CY
6151 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6152 the font entity extracted from the cache (Bug#8109).
6153
58872834
CY
61542011-08-07 Chong Yidong <cyd@stupidchicken.com>
6155
6156 * composite.c (autocmp_chars): Don't reset point. That is done by
6157 restore_point_unwind (Bug#5984).
6158
75bfc667
JL
61592011-08-07 Juri Linkov <juri@jurta.org>
6160
6161 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6162 to show the arg `TIME' instead of `TIMEVAL'.
6163
d1410150
EZ
61642011-08-06 Eli Zaretskii <eliz@gnu.org>
6165
6166 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6167 display property strides EOL and includes a newline, as in
6168 longlines-mode. (Bug#9254)
75b771e4
EZ
6169 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6170 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6171
6172 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6173 is non-zero, even if the data buffer is NULL. Fixes a crash in
6174 vertical-motion with longlines-mode. (Bug#9254)
6175
35928349
EZ
61762011-08-05 Eli Zaretskii <eliz@gnu.org>
6177
ec7cc85b
EZ
6178 * bidi.c <bidi_cache_total_alloc>: Now static.
6179 (bidi_initialize): Initialize bidi_cache_total_alloc.
6180
8b76d6f8 6181 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6182 cache. (Bug#9221)
6183
6184 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6185 amount allocated this far in `bidi_cache_total_alloc'.
6186 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6187 non-zero, only free the data buffer without restoring the cache
6188 contents. All callers changed.
6189
6190 * dispextern.h (bidi_unshelve_cache): Update prototype.
6191
6192 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6193 (move_it_in_display_line, move_it_to)
6194 (move_it_vertically_backward, move_it_by_lines): Replace the call
6195 to xfree to an equivalent call to bidi_unshelve_cache.
6196 (move_it_in_display_line_to): Fix logic of returning
412b6358 6197 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6198
e2e2423b
EZ
61992011-08-05 Eli Zaretskii <eliz@gnu.org>
6200
6201 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6202 came from a string character with a `cursor' property. (Bug#9229)
6203
ae9e757a
JD
62042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6205
6206 * Makefile.in (LIB_PTHREAD): New variable.
6207 (LIBES): Add LIB_PTHREAD (Bug#9216).
6208
6209 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6210 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6211
213bd7f2
AS
62122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6213
6b02f655 6214 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6215
99aaf75f
JD
62162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6217
6218 * xterm.c (x_find_topmost_parent): New function.
6219 (x_set_frame_alpha): Find topmost parent window with
6220 x_find_topmost_parent and set the property there also (bug#9181).
6221 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6222
c74e9d86
PE
62232011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6224
6225 * callproc.c (Fcall_process): Avoid vfork clobbering
6226 the local vars buffer, coding_systems, current_dir.
6227
640c8776
SM
62282011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6229
6230 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6231
f26d0e4c
PE
62322011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6233
8a10d76c
PE
6234 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6235 so that it is not optimized away.
6236
f26d0e4c
PE
6237 * xdisp.c (compute_display_string_pos): Remove unused local.
6238
55439c61
EZ
62392011-08-02 Eli Zaretskii <eliz@gnu.org>
6240
6241 Fix slow cursor motion and scrolling in large buffers with
6242 selective display, like Org Mode buffers. (Bug#9218)
6243
6244 * dispextern.h (struct bidi_it): New member disp_prop_p.
6245
6246 * xdisp.c: Remove one-slot cache of display string positions.
6247 (compute_display_string_pos): Accept an additional argument
5e617bc2 6248 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6249 for a display string or property. If found, set DISP_PROP_P
6250 non-zero.
6251
6252 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6253 DISP_PROP_P, and pass it to compute_display_string_pos.
6254 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6255 non-zero. All callers of bidi_fetch_char changed.
6256
fb33fa43
SM
62572011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6258
6259 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6260
b099e063
DM
62612010-12-03 Don March <don@ohspite.net>
6262
6263 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6264 last character M-[char] is translated to ESC [char] (bug#7541).
6265
5cc7f7af
KH
62662011-08-02 Kenichi Handa <handa@m17n.org>
6267
d0fffa3f 6268 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6269
6270 * chartab.c (uniprop_table): Make it non-static.
6271
525d5e6e
EZ
62722011-08-01 Eli Zaretskii <eliz@gnu.org>
6273
6274 * xdisp.c (forward_to_next_line_start): Accept additional argument
6275 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6276 on the newline.
6277 (reseat_at_next_visible_line_start): Use the bidi iterator state
6278 returned by forward_to_next_line_start to restore the state of
6279 it->bidi_it after backing up to previous newline. (Bug#9212)
6280
31011111
AS
62812011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6282
6283 * regex.c (re_comp): Protoize.
6284 (re_exec): Fix return type.
6285 (regexec): Fix type of `ret'. (Bug#9203)
6286
476371c4
PE
62872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6288
e5d76069
PE
6289 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6290 This is needed if max-image-size is a floating-point number.
6291
9a79b20c
AS
62922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6293
6294 * print.c (print_object): Print empty symbol as ##.
6295
6296 * lread.c (read1): Read ## as empty symbol.
6297
d8c2fa78
AA
62982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6299
6300 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6301 setting frame foreground color (Bug#9175).
6302 (x_set_background_color): Likewise.
6303
ffe57a7a
AA
6304 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6305 contents (Bug#9176).
6306 (EmacsTooltip -init): Remove bezels and add shadows to
6307 tooltip windows.
6308
bf3492a5
AA
6309 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6310 or scroll bar (Bug#8470).
6311
d55e9c53
AA
6312 * nsfont.m (nsfont_open): Remove assignment to voffset and
6313 unnecessary vars hshink, expand, hd, full_height, min_height.
6314 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6315
6316 * nsterm.h (nsfont_info): Remove voffset field.
6317
d8c2fa78 63182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6319
6320 Implement strike-through and overline on NextStep (Bug#8863).
6321
6322 * nsfont.m (nsfont_open): Use underline position provided by font,
6323 instead of hard-coded value of 2.
6324 (nsfont_draw): Call ns_draw_text_decoration instead.
6325
6326 * nsterm.h: Add declaration for ns_draw_text_decoration.
6327
6328 * nsterm.m (ns_draw_text_decoration): New function for drawing
6329 underline, overline, and strike-through.
6330 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6331 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6332 accommodate underlining, etc.
4843aac3 6333
4cc60b9b
EZ
63342011-07-28 Eli Zaretskii <eliz@gnu.org>
6335
bc7ece87
EZ
6336 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6337 default.
4cc60b9b 6338
476371c4
PE
63392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6340
66606eea
PE
6341 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6342 Without this fix, if a signal arrives just after memory fills up,
6343 'malloc' might be invoked reentrantly.
6344
476371c4
PE
6345 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6346 In other words, assume that every image size is allowed, on non-X
6347 hosts. This assumption is probably wrong, but it lets Emacs compile.
6348
f3fcc40d
AS
63492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6350
6351 * regex.c (re_iswctype): Convert return values to boolean.
6352
350c992f
EZ
63532011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6354
6355 * xdisp.c (compute_display_string_pos): Don't use cached display
6356 string position if the buffer had its restriction changed.
6357 (Bug#9184)
6358
5266b4bb
PE
63592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6360
6361 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6362
2573a837 63632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6364
41f55ccd 6365 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6366
39e378da
PE
6367 * bidi.c: Integer size and overflow fixes.
6368 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6369 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6370 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6371 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6372 (bidi_find_other_level_edge):
6373 Use ptrdiff_t instead of EMACS_INT where either will do.
6374 This works better on 32-bit hosts configured --with-wide-int.
6375 (bidi_cache_ensure_space): Check for size-calculation overflow.
6376 Use % rather than repeated addition, for better worst-case speed.
6377 Don't set bidi_cache_size until after xrealloc returns, because it
6378 might not return.
6379 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6380 (bidi_cache_ensure_space): Also check that the bidi cache size
6381 does not exceed that of the largest Lisp string or buffer. See Eli
6382 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6383
5e927815
PE
6384 * alloc.c (__malloc_size_t): Remove.
6385 All uses replaced by size_t. See Andreas Schwab's note
6386 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6387
ca4aa935
PE
6388 * image.c: Improve checking for integer overflow.
6389 (check_image_size): Assume that f is nonnull, since
6390 it is always nonnull in practice. This is one less thing to
6391 worry about when checking for integer overflow later.
6392 (x_check_image_size): New function, which checks for integer
6393 overflow issues inside X.
6394 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6395 This removes the need for a memory_full check.
6396 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6397 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6398 (xbm_read_bitmap_data): Change locals back to 'int', since
6399 their values must fit in 'int'.
6400 (xpm_load_image, png_load, tiff_load):
6401 Invoke x_create_x_image_and_pixmap earlier,
6402 to avoid much needless work if the image is too large.
6403 (tiff_load): Treat overly large images as if
6404 x_create_x_image_and_pixmap failed, not as malloc failures.
6405 (gs_load): Use x_check_image_size.
6406
5f8f9cc2
PE
6407 * gtkutil.c: Omit integer casts.
6408 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6409 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6410
5adf60bc
PE
6411 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6412
c8907a93
PE
6413 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6414 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6415 would wrongly return t on a 64-bit host.
6416
e3c25c68
PE
6417 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6418 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6419 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6420 and therefore cause GCC to emit a bogus diagnostic in some cases.
6421
3f791afe
PE
6422 * image.c: Integer signedness and overflow and related fixes.
6423 This is not an exhaustive set of fixes, but it's time to
6424 record what I've got.
6425 (lookup_pixel_color, check_image_size): Remove redundant decls.
6426 (check_image_size): Don't assume that arbitrary EMACS_INT values
6427 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6428 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6429 (tiff_load, imagemagick_load_image):
6430 Check for overflow in size calculations.
6431 (x_create_x_image_and_pixmap): Remove unnecessary test for
6432 xmalloc returning NULL; that can't happen.
6433 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6434 (xpm_color_bucket): Use better integer hashing function.
6435 (xpm_cache_color): Don't possibly over-allocate memory.
6436 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6437 (gif_memory_source):
6438 Use ptrdiff_t, not int or size_t, to record sizes.
6439 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6440 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6441 either works, as we prefer signed integers.
6442 (tiff_read_from_memory, tiff_write_from_memory):
6443 Return tsize_t, not size_t, since that's what the TIFF API wants.
6444 (tiff_read_from_memory): Don't fail simply because the read would
6445 go past EOF; instead, return a short read.
6446 (tiff_load): Omit no-longer-needed casts.
6447 (Fimagemagick_types): Don't assume size fits into 'int'.
6448
3cc5a532
PE
6449 Improve hashing quality when configured --with-wide-int.
6450 * fns.c (hash_string): New function, taken from sxhash_string.
6451 Do not discard information about ASCII character case; this
6452 discarding is no longer needed.
6453 (sxhash-string): Use it. Change sig to match it. Caller changed.
6454 * lisp.h: Declare it.
6455 * lread.c (hash_string): Remove, since we now use fns.c's version.
6456 The fns.c version returns a wider integer if --with-wide-int is
6457 specified, so this should help the quality of the hashing a bit.
6458
b312a492
PE
6459 * emacs.c: Integer overflow minor fix.
6460 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6461 Define only if GNU_LINUX.
6462 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6463
dfd153ae
PE
6464 * dispnew.c: Integer signedness and overflow fixes.
6465 Remove unnecessary forward decls, that were a maintenance hassle.
6466 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6467 All uses changed.
6468 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6469 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6470 (prepare_desired_row, line_draw_cost):
6471 Use int, not unsigned, where either works.
6472 (save_current_matrix, restore_current_matrix):
6473 Use ptrdiff_t, not size_t, where either works.
6474 (init_display): Check for overflow more accurately, and without
6475 relying on undefined behavior.
6476
a81d11a3
PE
6477 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6478 Remove, replacing with the new symbols in lisp.h. All uses changed.
6479 * fileio.c (make_temp_name):
6480 * filelock.c (lock_file_1, lock_file):
6481 * xdisp.c (message_dolog):
6482 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6483 Use pMd etc. instead.
6484 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6485 replacing the pWIDE etc. symbols removed from editfns.c.
6486
3300e6fd
PE
6487 * keyboard.h (num_input_events): Now uintmax_t.
6488 This is (very slightly) less likely to mess up due to wraparound.
6489 All uses changed.
6490
fd05c7e9
PE
6491 * buffer.c: Integer signedness fixes.
6492 (alloc_buffer_text, enlarge_buffer_text):
6493 Use ptrdiff_t rather than size_t when either will do, as we prefer
6494 signed integers.
6495
903fe15d
PE
6496 * alloc.c: Integer signedness and overflow fixes.
6497 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6498 (__malloc_size_t): Default to size_t, not to int.
6499 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6500 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6501 Prefer ptrdiff_t to size_t when either would do, as we prefer
6502 signed integers.
6503 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6504 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6505 Now const. Initialize with values that are in range even if char
6506 is signed.
6507 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6508 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6509 These functions do the right thing with sizes > 2**32.
6510 (check_depth): Now ptrdiff_t, not int.
6511 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6512 Adjust to new way of storing sizes. Check for size overflow bugs
6513 in rest of code.
6514 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6515 slightly wrong anyway, as it missed one instance of
6516 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6517 (refill_memory_reserve): Omit needless cast to size_t.
6518 (mark_object_loop_halt): Mark as externally visible.
6519
ac82cc6a
PE
6520 * xselect.c: Integer signedness and overflow fixes.
6521 (Fx_register_dnd_atom, x_handle_dnd_message):
6522 Use ptrdiff_t, not size_t, since we prefer signed.
6523 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6524 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6525 x_dnd_atoms_size and x_dnd_atoms_length.
6526
c2d1e36d
PE
6527 * doprnt.c: Prefer signed to unsigned when either works.
6528 * eval.c (verror):
6529 * doprnt.c (doprnt):
6530 * lisp.h (doprnt):
6531 * xdisp.c (vmessage):
6532 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6533 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6534 prefer signed arithmetic to avoid comparison confusion.
6535 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6536 but is a bit tricky.
6537
0e926e56
PE
6538 Assume freestanding C89 headers, string.h, stdlib.h.
6539 * data.c, doprnt.c, floatfns.c, print.c:
6540 Include float.h unconditionally.
6541 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6542 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6543 * regex.c: Likewise for stddef.h, string.h.
6544 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6545 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6546 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6547 (STDC_HEADERS): Remove obsolete defines.
6548 * sysdep.c: Include limits.h unconditionally.
6549
9cfdb3ec
PE
6550 Assume support for memcmp, memcpy, memmove, memset.
6551 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6552 * regex.c (memcmp, memcpy):
6553 Remove; we assume C89 now.
6554
6555 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6556 (__malloc_safe_bcopy): Remove; no longer needed.
6557
cf950e6b 6558 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6559 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6560 well either way, and we prefer signed to unsigned.
6561
dbf38e02
LMI
65622011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6563
6564 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6565 closes the connection while we're reading (bug#9182).
6566
d6f0886c 65672011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6568
d6f0886c
JD
6569 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6570 are specified (Bug#9168).
24e0f6b1 6571
2eb1f9e6
PE
65722011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6573
6574 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6575 Found by GCC static checking and --with-wide-int on a 32-bit host.
6576
22381272 65772011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6578
6579 * xdisp.c (compute_display_string_pos): Fix logic of caching
6580 previous display string position. Initialize cached_prev_pos to
6581 -1. Fixes slow-down at the beginning of a buffer.
6582
f25e39b4
EZ
65832011-07-24 Eli Zaretskii <eliz@gnu.org>
6584
6585 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6586 for attrs[LFACE_FONTSET_INDEX].
6587
04c4b52e
PE
65882011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6589
6590 * xml.c (parse_region): Remove unused local
6591 that was recently introduced.
6592
c1734fbd
EZ
65932011-07-23 Eli Zaretskii <eliz@gnu.org>
6594
be18c5a5
EZ
6595 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6596 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6597
c1734fbd
EZ
6598 * xdisp.c (move_it_in_display_line_to): Record the best matching
6599 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6600 exit if none of the characters scanned was an exact match.
6601 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6602 when exact match is impossible due to invisible text, and the
6603 lines are truncated.
6604
a258d627
JD
66052011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6606
6607 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6608 for OSX >= 10.7.
6609
b6d5a689
EZ
66102011-07-22 Eli Zaretskii <eliz@gnu.org>
6611
0f74f785
EZ
6612 Fix a significant slow-down of cursor motion with C-n, C-p,
6613 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6614 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6615 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6616 (next_element_from_buffer): Call compute_stop_pos_backwards to
6617 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6618 base_level_stop.
6619 (reseat): Don't look for prev_stop, as that could mean a very long
6620 run.
6621 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6622 <cached_disp_overlay_modiff>: Cache for last found display string
6623 position.
551918c1 6624 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6625 about the same buffer in the same area of character positions, and
6626 the buffer wasn't changed since the time the display string
6627 position was cached.
551918c1 6628
b2d0c91a
EZ
66292011-07-22 Eli Zaretskii <eliz@gnu.org>
6630
6631 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6632 is an integer, which is important for empty lines. (Bug#9149)
6633
043604ee
CY
66342011-07-22 Chong Yidong <cyd@stupidchicken.com>
6635
6636 * frame.c (Fmodify_frame_parameters): In tty case, update the
6637 default face if necessary (Bug#4238).
6638
da4adb04
CY
66392011-07-21 Chong Yidong <cyd@stupidchicken.com>
6640
6641 * editfns.c (Fstring_to_char): No need to explain what a character
6642 is in the docstring (Bug#6576).
6643
9abd0532
LMI
66442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6645
6646 * xml.c (parse_region): Make sure we always return a tree.
6647
36881d16
HK
66482011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6649
6650 * xml.c (parse_region): If a document contains only comments,
6651 return that, too.
6652
1e98674d
LMI
66532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6654
6655 * xml.c (make_dom): Return comments, too.
6656
590bd467
PE
66572011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6658
6659 Port to OpenBSD.
6660 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6661 and the surrounding thread.
6662 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6663 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6664 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6665 timer goes off.
6666 * s/openbsd.h (BROKEN_SIGIO): Define.
6667 * unexelf.c (unexec) [__OpenBSD__]:
6668 Don't update the .mdebug section of the Alpha COFF symbol table.
6669
f41628b2
LMI
66702011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6671
6672 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6673 (bug#8460).
6674
b59b67c5
PE
66752011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6676
15e3a074
PE
6677 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6678 This fixes some race conditions on the permissions of any newly
6679 created file.
6680
41bed37d
PE
6681 * alloc.c (valid_pointer_p): Use pipe, not open.
6682 This fixes some permissions issues when debugging.
6683
b59b67c5
PE
6684 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6685 If fchown fails to set both uid and gid, try to set just gid,
6686 as that is sometimes allowed. Adjust the file's mode to eliminate
6687 setuid or setgid bits that are inappropriate if fchown fails.
6688
925a6be7
SM
66892011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6690
6691 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6692 to compare Lisp_Objects.
6693 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6694 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6695 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6696
52968808
AS
66972011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6698
0a6a104b
AS
6699 * lread.c (read_integer): Unread even EOF character.
6700 (read1): Likewise. Properly record start position of symbol.
6701
52968808
AS
6702 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6703 symbol character follows.
6704
9e381cdd
PE
67052011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6706
6707 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6708 This works around a problem with the previous change to Fcopy_file.
6709 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6710 and without this change, GCC might complain about discarding
6711 fchown's return value.
6712
b5641435
JB
67132011-07-16 Juanma Barranquero <lekktu@gmail.com>
6714
6715 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6716
a8031457
PE
67172011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6718
6719 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6720
dd889327
LMI
67212011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6722
750c33f7
LMI
6723 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6724 it's used from the C level.
6725
dd889327
LMI
6726 * process.c: Use the same condition for POLL_FOR_INPUT in both
6727 keyboard.c and process.c (bug#1858).
6728
87e86684
LM
67292011-07-09 Lawrence Mitchell <wence@gmx.li>
6730
6731 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6732 (Fgnutls_boot): Use it.
6733
64348f40
AS
67342011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6735
6736 * doc.c (Fsubstitute_command_keys): Revert last change.
6737
1d698799
LMI
67382011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6739
f863868c
LMI
6740 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6741 quotes the next character, and doesn't affect other longer
6742 sequences (bug#8935).
6743
1d698799
LMI
6744 * lread.c (syms_of_lread): Clarify that is isn't only
6745 `eval-buffer' and `eval-defun' that's affected by
6746 `lexical-binding' (bug#8460).
6747
aa4b6df6
EZ
67482011-07-15 Eli Zaretskii <eliz@gnu.org>
6749
6750 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6751 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6752
5d856da6
PE
67532011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6754
ad6042bb
PE
6755 Fix minor problems found by static checking.
6756 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6757 (elsz): Now a signed constant, not a size_t var. We prefer signed
6758 types to unsigned, to avoid integer comparison confusion. Without
6759 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6760 "cannot optimize loop, the loop counter may overflow", a symptom
6761 of the confusion.
f00bbb22 6762 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6763 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6764
6468f31c
LMI
67652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6766
49080b10
LMI
6767 * search.c (Fre_search_backward): Mention `case-fold-search' in
6768 all the re_search_* functions (bug#8138).
6769
6468f31c
LMI
6770 * keyboard.c (Fopen_dribble_file): Document when the file is
6771 closed (bug#8056).
6772
c965adc5
EZ
67732011-07-14 Eli Zaretskii <eliz@gnu.org>
6774
df9733bf
EZ
6775 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6776 bidi_cache_idx.
6777
0bb23927
EZ
6778 Support bidi reordering of display and overlay strings.
6779 * xdisp.c (compute_display_string_pos)
6780 (compute_display_string_end): Accept additional argument STRING.
6781 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6782 (reseat_to_string): Initialize bidi_it->string.s and
6783 bidi_it->string.schars.
6784 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6785 NULL (avoids a crash in bidi_paragraph_init).
6786 Initialize itb.string.lstring.
0bb23927
EZ
6787 (init_iterator): Call bidi_init_it only of a valid
6788 buffer position was specified. Initialize paragraph_embedding to
6789 L2R.
6790 (reseat_to_string): Initialize the bidi iterator.
6791 (display_string): If we need to ignore text properties of
6792 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6793 original value of -1 will not work with bidi.)
6794 (compute_display_string_pos): First arg is now struct
6795 `text_pos *'; all callers changed. Support display properties on
6796 Lisp strings.
6797 (compute_display_string_end): Support display properties on Lisp
6798 strings.
6799 (init_iterator, reseat_1, reseat_to_string): Initialize the
6800 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6801 when iterating on a string not from display properties).
640c8776
SM
6802 (compute_display_string_pos, compute_display_string_end):
6803 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6804 arrow keys.
6805 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6806 base_level_stop; instead, set base_level_stop to BEGV.
6807 Fixes crashes in vertical-motion.
0bb23927
EZ
6808 (next_element_from_buffer): Improve commentary for when
6809 the iterator is before prev_stop.
6810 (init_iterator): Initialize bidi_p from the default value of
6811 bidi-display-reordering, not from buffer-local value. Use the
6812 buffer-local value only if initializing for buffer iteration.
6813 (handle_invisible_prop): Support invisible properties on strings
6814 that are being bidi-reordered.
6815 (set_iterator_to_next): Support bidi reordering of C strings and
6816 Lisp strings.
6817 (next_element_from_string): Support bidi reordering of Lisp
6818 strings.
6819 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6820 (display_string): Support display of R2L glyph rows.
6821 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6822 (init_iterator): Don't initialize it->bidi_p for strings
6823 here.
6824 (reseat_to_string): Initialize it->bidi_p for strings here.
6825 (next_element_from_string, next_element_from_c_string)
6826 (next_element_from_buffer): Add xassert's for correspondence
6827 between IT's object being iterated and it->bidi_it.string
6828 structure.
6829 (face_before_or_after_it_pos): Support bidi iteration.
6830 (next_element_from_c_string): Handle the case of the first string
6831 character that is not the first one in the visual order.
6832 (get_visually_first_element): New function, refactored from common
6833 parts of next_element_from_buffer, next_element_from_string, and
6834 next_element_from_c_string.
6835 (tool_bar_lines_needed, redisplay_tool_bar)
6836 (display_menu_bar): Force left-to-right direction. Add a FIXME
6837 comment for making that be controlled by a user option.
6838 (push_it, pop_it): Save and restore the state of the
6839 bidi iterator. Save and restore the bidi_p flag.
6840 (pop_it): Iterate out of display property for string iteration as
6841 well.
6842 (iterate_out_of_display_property): Support iteration over strings.
6843 (handle_single_display_spec): Set up it->bidi_it for iteration
6844 over a display string, and call bidi_init_it.
6845 (handle_single_display_spec, next_overlay_string)
6846 (get_overlay_strings_1, push_display_prop): Set up the bidi
6847 iterator for displaying display or overlay strings.
6848 (forward_to_next_line_start): Don't use the shortcut if
6849 bidi-iterating.
6850 (back_to_previous_visible_line_start): If handle_display_prop
6851 pushed the iterator stack, restore the internal state of the bidi
6852 iterator by calling bidi_pop_it same number of times.
6853 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6854 and we are bidi-iterating, don't decrement the iterator position;
6855 instead, set the first_elt flag in the bidi iterator, to produce
6856 the same effect.
6857 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6858 (push_display_prop): xassert that we are iterating a buffer.
6859 (push_it, pop_it): Save and restore paragraph_embedding member.
6860 (handle_single_display_spec, next_overlay_string)
6861 (get_overlay_strings_1, reseat_1, reseat_to_string)
6862 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6863 correctly. Don't assume unibyte strings are not bidi-reordered.
6864 (compute_display_string_pos)
6865 (compute_display_string_end): Fix handling the case of C string.
6866 (push_it, pop_it): Save and restore from_disp_prop_p.
6867 (handle_single_display_spec, push_display_prop): Set the
6868 from_disp_prop_p flag.
6869 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6870 (pop_it): Call iterate_out_of_display_property only if we are
6871 popping after iteration over a string that came from a display
6872 property. Fix a typo in popping stretch info. Add an assertion
6873 for verifying that the iterator position is in sync with the bidi
6874 iterator.
6875 (handle_single_display_spec, get_overlay_strings_1)
6876 (push_display_prop): Fix initialization of paragraph direction for
6877 string when that of the parent object is not yet determined.
6878 (reseat_1): Call bidi_init_it to resync the bidi
6879 iterator with IT's position. (Bug#7616)
6880 (find_row_edges): If ROW->start.pos gives position
6881 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6882 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6883 Reset the from_disp_prop_p flag.
6884 (SAVE_IT, RESTORE_IT): New macros.
6885 (pos_visible_p, face_before_or_after_it_pos)
6886 (back_to_previous_visible_line_start)
6887 (move_it_in_display_line_to, move_it_in_display_line)
6888 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6889 (try_scrolling, redisplay_window, display_line): Use them when
6890 saving a temporary copy of the iterator and restoring it back.
6891 (back_to_previous_visible_line_start, reseat_1)
6892 (init_iterator): Empty the bidi cache "stack".
6893 (move_it_in_display_line_to): If iterator ended up at
6894 EOL, but we never saw any buffer positions smaller than
6895 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6896 motion in bidi-reordered lines.
6897 (move_it_in_display_line_to): Record prev_method and prev_pos
6898 immediately before the call to set_iterator_to_next. Fixes cursor
6899 motion in bidi-reordered lines with stretch glyphs and strings
6900 displayed in margins. (Bug#8133) (Bug#8867)
6901 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6902 TO_CHARPOS.
640c8776
SM
6903 (pos_visible_p): Support positions in bidi-reordered lines.
6904 Save and restore bidi cache.
0bb23927
EZ
6905
6906 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6907 (bidi_paragraph_info): Delete unused struct.
6908 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6909 (bidi_cache_start): New variable.
6910 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6911 to zero.
6912 (bidi_cache_fetch_state, bidi_cache_search)
6913 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6914 (bidi_cache_find, bidi_peek_at_next_level)
6915 (bidi_level_of_next_char, bidi_find_other_level_edge)
6916 (bidi_move_to_visually_next): Compare cache index with
6917 bidi_cache_start rather than with zero.
6918 (bidi_fetch_char): Accept new argument STRING; all callers
6919 changed. Support iteration over a string. Support strings with
6920 display properties. Support unibyte strings. Fix the type of
6921 `len' according to what STRING_CHAR_AND_LENGTH expects.
6922 (bidi_paragraph_init, bidi_resolve_explicit_1)
6923 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6924 (bidi_level_of_next_char, bidi_move_to_visually_next):
6925 Support iteration over a string.
0bb23927
EZ
6926 (bidi_set_sor_type, bidi_resolve_explicit_1)
6927 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6928 can now be zero (for strings); special values 0 and -1 were
6929 changed to -1 and -2, respectively.
6930 (bidi_char_at_pos): New function.
6931 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6932 Call it instead of FETCH_MULTIBYTE_CHAR.
6933 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6934 initialized to valid values.
6935 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6936 values.
6937 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6938 the test for valid cached positions. Fix the logic for looking up
6939 the sentinel state in the cache. GCPRO the Lisp string we are
6940 iterating.
6941 (bidi_push_it, bidi_pop_it): New functions.
6942 (bidi_initialize): Initialize the bidi cache start stack pointer.
6943 (bidi_cache_ensure_space): New function, refactored from part of
6944 bidi_cache_iterator_state. Don't assume the required size is just
6945 one BIDI_CACHE_CHUNK away.
6946 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6947 (bidi_count_bytes, bidi_char_at_pos): New functions.
6948 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6949 always valid if bidi_cache_idx is valid.
6950 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6951 is valid if it's going to be used.
6952 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6953 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6954 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6955 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6956 (bidi_find_other_level_edge, bidi_cache_start_stack):
6957 All variables related to cache indices are now EMACS_INT.
c965adc5 6958
0bb23927
EZ
6959 * dispextern.h (struct bidi_string_data): New structure.
6960 (struct bidi_it): New member `string'. Make flag members be 1-bit
6961 fields, and put them last in the struct.
640c8776
SM
6962 (compute_display_string_pos, compute_display_string_end):
6963 Update prototypes.
0bb23927
EZ
6964 (bidi_push_it, bidi_pop_it): Add prototypes.
6965 (struct iterator_stack_entry): New members bidi_p,
6966 paragraph_embedding, and from_disp_prop_p.
6967 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6968 (bidi_shelve_cache, bidi_unshelve_cache):
6969 Declare prototypes.
0bb23927
EZ
6970
6971 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6972 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6973 and vector-like objects.
6974
6975 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6976 cache around display iteration.
6977
6978 * window.c (Fwindow_end, window_scroll_pixel_based)
6979 (displayed_window_lines, Frecenter): Save and restore the bidi
6980 cache around display iteration.
6981
3bbd2265
LMI
69822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6983
6984 * editfns.c (Fdelete_region): Clarify the use of the named
6985 parameters (bug#6788).
6986
adc47434
MR
69872011-07-14 Martin Rudalics <rudalics@gmx.at>
6988
6989 * indent.c (Fvertical_motion): Set and restore w->pointm when
6990 saving and restoring the window's buffer (Bug#9006).
6991
837c31f8
LMI
69922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6993
6994 * editfns.c (Fstring_to_char): Clarify just what is returned
6995 (bug#6576). Text by Eli Zaretskii.
6996
ac389d0c
JB
69972011-07-13 Juanma Barranquero <lekktu@gmail.com>
6998
6999 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7000
0be0ce47
EZ
70012011-07-13 Eli Zaretskii <eliz@gnu.org>
7002
7003 * buffer.c (mmap_find): Fix a typo.
7004
cd18e7e3
JB
70052011-07-13 Johan Bockgård <bojohan@gnu.org>
7006
7007 Fix execution of x selection hooks.
7008 * xselect.c (Qx_lost_selection_functions)
7009 (Qx_sent_selection_functions): New vars.
7010 (syms_of_xselect): DEFSYM them.
7011 (x_handle_selection_request): Pass Qx_sent_selection_functions
7012 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7013 (x_handle_selection_clear,x_clear_frame_selections):
7014 Pass Qx_lost_selection_functions rather than
7015 Vx_lost_selection_functions to Frun_hook_with_args.
7016
47ea7f44
PE
70172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7018
ac389d0c 7019 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7020 The old code sometimes used this field without initializing it.
7021
47ea7f44
PE
7022 * alloc.c (gc_sweep): Don't read past end of array.
7023 In theory, the old code could also have corrupted Emacs internals,
7024 though it'd be very unlikely.
7025
bc985c87
AS
70262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7027
7028 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7029 argument. (Bug#4026)
bc985c87 7030
0cf34688
LMI
70312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7032
b3dadd76
LMI
7033 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7034 key" (bug#4257).
7035
0cf34688
LMI
7036 * window.c (Fset_window_start): Doc fix (bug#4199).
7037 (Fset_window_hscroll): Ditto.
7038
270768cd
PE
70392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7040
077e3dda 7041 Fix minor new problems caught by GCC 4.6.1.
270768cd 7042 * term.c (init_tty): Remove unused local.
490011a6 7043 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7044 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7045 not used otherwise.
270768cd 7046
b1f58454
CY
70472011-07-12 Chong Yidong <cyd@stupidchicken.com>
7048
7049 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7050
22b9578d
LMI
70512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7052
6e70ab07
LMI
7053 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7054 are the mini-buffer and the echo area (bug#3320).
7055
22b9578d
LMI
7056 * term.c (init_tty): Remove support for supdup, c10 and perq
7057 terminals, which are no longer supported (bug#1482).
7058
8974cc9f
JB
70592011-07-10 Johan Bockgård <bojohan@gnu.org>
7060
7061 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7062
a560d974
JD
70632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7064
7065 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7066 for non-popups (Bug#3642).
7067
1dae0f0a
AS
70682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7069
268c2c36 7070 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7071 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7072 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7073 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7074 * data.c (fmod): Likewise.
7075 * dispnew.c (swap_glyphs_in_rows): Likewise.
7076 * emacs.c (memory_warning_signal): Likewise.
7077 * floatfns.c (float_error): Likewise.
7078 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7079 (otf_open, font_otf_capability, generate_otf_features)
7080 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7081 Likewise.
7082 * image.c (pbm_read_file): Likewise.
7083 * indent.c (string_display_width): Likewise.
7084 * intervals.c (check_for_interval, search_for_interval)
7085 (inc_interval_count, count_intervals, root_interval)
7086 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7087 * lread.c (defalias): Likewise.
268c2c36 7088 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7089 * regex.c (set_image_of_range_1, set_image_of_range)
7090 (regex_grow_registers): Likewise.
7091 * sysdep.c (strerror): Likewise.
7092 * termcap.c (valid_filename_p, tprint, main): Likewise.
7093 * tparam.c (main): Likewise.
7094 * unexhp9k800.c (run_time_remap, save_data_space)
7095 (update_file_ptrs, read_header, write_header, calculate_checksum)
7096 (copy_file, copy_rest, display_header): Likewise.
7097 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7098 Likewise.
7099 * xdisp.c (check_it): Likewise.
7100 * xfaces.c (register_color, unregister_color, unregister_colors):
7101 Likewise.
7102 * xfns.c (print_fontset_result): Likewise.
7103 * xrdb.c (member, fatal, main): Likewise.
7104
99033785
PE
71052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7106
7107 Fix minor problems found by static checking (Bug#9031).
7108 * chartab.c (char_table_set_range, map_sub_char_table):
7109 Remove unused locals.
7110 (uniprop_table): Now static.
7111 * composite.c (_work_char): Remove unused static var.
7112
9cb2ac56
JB
71132011-07-09 Juanma Barranquero <lekktu@gmail.com>
7114
7115 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7116
f25661f0
JD
71172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7118
7119 * gtkutil.c (qttip_cb): Remove code without function.
7120
8278c4fe
EZ
71212011-07-09 Eli Zaretskii <eliz@gnu.org>
7122
7123 * w32.c (pthread_sigmask): New stub.
7124
1692ae2d 71252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7126
8a6ebd58 7127 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7128 sigprocmask is portable only for single-threaded applications, and
7129 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7130 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7131 (LIBES): Use it.
7132 * callproc.c (Fcall_process):
7133 * process.c (create_process):
7134 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7135 Use pthread_sigmask, not sigprocmask.
123403e4 7136
1b854618
JD
71372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7138
7139 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7140 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7141 wrong (Bug#8591).
7142
3fe4b549
JD
71432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7144
0ce7e563
JD
7145 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7146 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7147 (xg_hide_tooltip): Fix comment.
7148
3fe4b549
JD
7149 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7150 in registerServicesMenuSendTypes.
7151 (validRequestorForSendType): Don't check ns_return_types.
7152
7153 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7154 ns_return_type.
7155
5df75e47
JR
71562011-07-08 Jason Rumney <jasonr@gnu.org>
7157
22610910
JR
7158 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7159 SH_SHOW for hidden windows (Bug#5482).
7160
5df75e47
JR
7161 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7162 frame struct members of non-existent frames (Bug#6284).
7163
699c10bd
JD
71642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7165
4393663b
JD
7166 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7167 variable firstTime not needed on OSX >= 10.6.
7168 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7169 >= 10.5. Use setKnobProportion, setDoubleValue.
7170
7171 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7172 (MAC_OS_X_VERSION_10_5): Define if not defined.
7173 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7174 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7175 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7176
7177 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7178 cString and lossyCString on OSX >= 10.4
7179
58179cce 7180 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7181 sizeToFit on OSX >= 10.2.
7182
7183 * nsimage.m (allocInitFromFile): Don't use deprecated method
7184 bestRepresentationForDevice on OSX >= 10.6.
7185
7186 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7187 to avoid warning.
7188
7189 * emacs.c: Declare unexec_init_emacs_zone.
7190
a63e0781
JD
7191 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7192
699c10bd
JD
7193 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7194
7195 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7196 on svcsMenu (Bug#8842).
7197
7198 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7199 ns_return_types.
7200 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7201
7202 * nsterm.m (QUTF8_STRING): Declare.
7203 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7204 (validRequestorForSendType): Return type is (id).
7205 Change indexOfObjectIdenticalTo to indexOfObject.
7206 Check if we have local selection before returning self (Bug#8842).
7207 (writeSelectionToPasteboard): Put local selection into paste board
7208 if we have a local selection (Bug#8842).
7209 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7210
7211 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7212 (ns_get_local_selection): Declare.
7213
54e10184
LMI
72142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7215
9888ff71
LMI
7216 * keymap.c (describe_map_tree): Don't insert a double newline at
7217 the end of the buffer (bug#1169) and return whether we inserted
7218 something.
7219
54e10184
LMI
7220 * callint.c (Fcall_interactively): Change "reading args" to
7221 "providing args" to try to clarify what it does (bug#1010).
7222
15fa4783
KH
72232011-07-07 Kenichi Handa <handa@m17n.org>
7224
7225 * composite.c (composition_compute_stop_pos): Ignore a static
7226 composition starting before CHARPOS (Bug#8915).
7227
7228 * xdisp.c (handle_composition_prop): Likewise.
7229
a8815b00
EZ
72302011-07-07 Eli Zaretskii <eliz@gnu.org>
7231
7232 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7233 (Bug#9015)
7234
ef7b981d 72352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7236
7237 * character.h (unicode_category_t): New enum type.
7238
7239 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7240 (Qchar_code_property_table): New variable.
7241 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7242 (UNIPROP_COMPRESSED_FORM_P): New macros.
7243 (char_table_ascii): Uncompress the compressed values.
7244 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7245 Uncompress the compressed values.
ac389d0c 7246 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7247 (char_table_ref_and_range): Uncompress the compressed values.
7248 (sub_char_table_set): New arg is_uniprop. Callers changed.
7249 Uncompress the compressed values.
7250 (sub_char_table_set_range): Args changed. Callers changed.
7251 (char_table_set_range): Adjuted for the above change.
7252 (map_sub_char_table): Delete args default_val and parent. Add arg
7253 top. Give decoded values to a Lisp function.
640c8776 7254 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7255 values to a Lisp function. Gcpro more variables.
7256 (uniprop_table_uncompress)
7257 (uniprop_decode_value_run_length): New functions.
7258 (uniprop_decoder, uniprop_decoder_count): New variables.
7259 (uniprop_get_decoder, uniprop_encode_value_character)
7260 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7261 New functions.
7262 (uniprop_encoder, uniprop_encoder_count): New variables.
7263 (uniprop_get_encoder, uniprop_table)
7264 (Funicode_property_table_internal, Fget_unicode_property_internal)
7265 (Fput_unicode_property_internal): New functions.
7266 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7267 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7268 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7269 char-code-property-alist.
7270
640c8776 7271 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7272 Vunicode_category_table.
7273
640c8776 7274 * font.c (font_range): Adjust for the change of
c805dec0
KH
7275 Vunicode_category_table.
7276
76b397fb
DN
72772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7278
7279 * m/iris4d.h: Remove file, move contents ...
7280 * s/irix6-5.h: ... here.
7281
22b4128e
PE
72822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7283
7284 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7285 * alloc.c (mark_buffer):
7286 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7287 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7288 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7289 This isn't true in general, and it's particularly not true
7290 if Emacs is configured with --with-wide-int.
7291 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7292 New macros, used in the buffer.c change.
7293
869795d6
JD
72942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7295
7296 * xsettings.c: Use both GConf and GSettings if both are available.
7297 (store_config_changed_event): Add comment.
7298 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7299 (store_tool_bar_style_changed): New functions.
5e617bc2 7300 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7301 (struct xsettings): Move font inside HAVE_XFT.
7302 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7303 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7304 Move inside HAVE_XFT.
640c8776 7305 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7306 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7307 also.
7308 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7309 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7310 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7311 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7312 (parse_settings): Move check for font inside HAVE_XFT.
7313 (read_settings, apply_xft_settings): Add comment.
7314 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7315 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7316 call store_font_name_changed.
7317 (xft_settings_event): Add comment.
7318 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7319 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7320 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7321 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7322 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7323 (xsettings_get_system_font, xsettings_get_system_normal_font):
7324 Add comment.
869795d6 7325
d8ed26bd
PE
73262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7327
7328 Random fixes. E.g., (random) never returned negative values.
7329 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7330 subseconds part to the entropy, as that's a bit more random.
7331 Prefer signed to unsigned, since the signedness doesn't matter and
7332 in general we prefer signed. When given a limit, use a
7333 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7334 latter isn't right if USE_2_TAGS_FOR_INTS.
7335 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7336 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7337
cabf1cac
SM
73382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7339
7340 * textprop.c (text_property_stickiness):
7341 Obey Vtext_property_default_nonsticky.
7342 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7343 * w32fns.c (syms_of_w32fns):
7344 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7345
6e9b2be9
PE
73462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7347
7348 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7349 This is more efficient than Ffile_directory_p and avoids a minor race.
7350
90186c68
LMI
73512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7352
7c301272
LMI
7353 * buffer.c (Foverlay_put): Say what the return value is
7354 (bug#7835).
7355
c4f2d8d4
LMI
7356 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7357 is a directory before asking whether to use the file name
7358 (bug#7564).
ad637907
LMI
7359 (barf_or_query_if_file_exists): Make the "File is a directory"
7360 error be more correct.
c4f2d8d4 7361
90186c68
LMI
7362 * fns.c (Frequire): Remove the mention of the .gz files, since
7363 that's installation-specific, but keep the mention of
7364 `get-load-suffixes'.
7365
da64016e
PE
73662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7367
7368 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7369 Report string overflow if the output is too long.
7370
7d47b580
JB
73712011-07-04 Juanma Barranquero <lekktu@gmail.com>
7372
a555cb87
JB
7373 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7374 (syms_of_gnutls): Remove duplicate DEFSYM for
7375 Qgnutls_bootprop_verify_hostname_error, an error for
7376 Qgnutls_bootprop_verify_error (which is no longer used).
7377
7d47b580
JB
7378 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7379 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7380 Also (re)move comments that are misplaced or no longer relevant.
7381
1e49bfab
LMI
73822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7383
7384 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7385
1485f4c0
CY
73862011-07-03 Chong Yidong <cyd@stupidchicken.com>
7387
7388 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7389 and background color parameters if they have been changed.
7390
a9ab721e
LMI
73912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7392
7393 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7394
cf7cff57
PE
73952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7396
2e13213d
PE
7397 * xsettings.c (SYSTEM_FONT): Define only when used.
7398 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7399
cf7cff57
PE
7400 * keymap.c (access_keymap_1): Now static.
7401
7a8e04f7
CY
74022011-07-02 Chong Yidong <cyd@stupidchicken.com>
7403
7404 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7405 leave any prefix arg for the up event (Bug#1586).
7406
61352f62
LMI
74072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7408
69bb1ef7
LMI
7409 * lread.c (syms_of_lread): Mention single symbols defined by
7410 `defvar' or `defconst' (bug#7154).
7411
61352f62 7412 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7413 (Frequire): Mention get-load-suffixes.
61352f62 7414
28545e04
MR
74152011-07-02 Martin Rudalics <rudalics@gmx.at>
7416
7417 * window.h (window): Remove clone_number slot.
7418 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7419 Remove.
7420 (make_parent_window, make_window, saved_window)
7421 (Fset_window_configuration, save_window_save): Don't deal with
7422 clone numbers.
7423 * buffer.c (Qclone_number): Remove declaration.
7424 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7425
3349e122
SM
74262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7427
7428 Add multiple inheritance to keymaps.
7429 * keymap.c (Fmake_composed_keymap): New function.
7430 (Fset_keymap_parent): Simplify.
7431 (fix_submap_inheritance): Remove.
7432 (access_keymap_1): New function extracted from access_keymap to handle
7433 embedded parents and handle lists of maps.
7434 (access_keymap): Use it.
7435 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7436 (Fcopy_keymap): Handle embedded parents.
7437 (Fcommand_remapping, define_as_prefix): Simplify.
7438 (Fkey_binding): Simplify.
7439 (syms_of_keymap): Move minibuffer-local-completion-map,
7440 minibuffer-local-filename-completion-map,
7441 minibuffer-local-must-match-map, and
7442 minibuffer-local-filename-must-match-map to Elisp.
7443 (syms_of_keymap): Defsubr make-composed-keymap.
7444 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7445 (parse_menu_item): Trivial simplification.
7446
3279eb87
GM
74472011-07-01 Glenn Morris <rgm@gnu.org>
7448
7449 * Makefile.in (SETTINGS_LIBS): Fix typo.
7450
4550efdf
KI
74512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7452
7453 * coding.c (Fencode_coding_string): Record the last coding system
7454 used, as the function doc string says (bug#8738).
7455
0949d2b6
JD
74562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7457
7458 * xsettings.c (store_monospaced_changed): Take new font as arg and
7459 check for change against current_mono_font.
7460 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7461 (emacs_settings_constructor, emacs_settings_get_property)
7462 (emacs_settings_set_property, emacs_settings_class_init)
7463 (emacs_settings_init, gsettings_obj): Remove.
7464 (something_changedCB): New function for HAVE_GSETTINGS.
7465 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7466 with value as argument.
7467 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7468 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7469 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7470 "changed".
7471
7472 * xgselect.c: Add defined (HAVE_GSETTINGS).
7473 (xgselect_initialize): Ditto.
7474
7475 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7476 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7477 xg_select.
7478
bbc6b304
PE
74792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7480
7481 * eval.c (struct backtrace): Simplify and port the data structure.
7482 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7483 signed bit field, as this assumption is not portable and it makes
7484 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7485 "char debug_on_exit : 1" as this is not portable either; instead,
7486 use the portable "unsigned int debug_on_exit : 1". Remove unused
7487 member evalargs. Remove obsolete comments about cc bombing out.
7488
9851bfc5
JD
74892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7490
51bb811f 7491 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7492 Let HAVE_GSETTINGS override HAVE_GCONF.
7493 (store_monospaced_changed): New function.
7494 (EMACS_SETTINGS): A new type derived from GObject to handle
7495 GSettings notifications.
7496 (emacs_settings_constructor, emacs_settings_get_property)
7497 (emacs_settings_set_property, emacs_settings_class_init):
7498 New functions.
7499 (gsettings_client, gsettings_obj): New variables.
7500 (GSETTINGS_SCHEMA): New define.
7501 (something_changedCB): Call store_monospaced_changed.
7502 (init_gsettings): New function.
7503 (xsettings_initialize): Call init_gsettings.
7504 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7505 to NULL.
7506
640c8776 7507 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7508 GCONF_CFLAGS/LIBS.
7509
5386012d
MR
75102011-06-29 Martin Rudalics <rudalics@gmx.at>
7511
7512 * window.c (resize_root_window, grow_mini_window)
7513 (shrink_mini_window): Rename Qresize_root_window to
7514 Qwindow_resize_root_window and Qresize_root_window_vertically to
7515 Qwindow_resize_root_window_vertically.
7516
f13e0b08
PE
75172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7518
7519 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7520
94515237
JB
75212011-06-27 Juanma Barranquero <lekktu@gmail.com>
7522
7523 * makefile.w32-in: Redesign dependencies so they reflect more
7524 clearly which files are directly included by each source file,
7525 and not through other includes.
7526
e43b6e43
MR
75272011-06-27 Martin Rudalics <rudalics@gmx.at>
7528
7529 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7530 (sort_overlays, overlay_strings): When an overlay's clone number
7531 matches the window's clone number process the overlay even if
7532 the overlay's window property doesn't match the current window.
7533
d68443dc
MR
7534 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7535 (Fwindow_hchild): Rename to Fwindow_left_child.
7536 (Fwindow_next): Rename to Fwindow_next_sibling.
7537 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7538 (resize_window_check): Rename to window_resize_check.
7539 (resize_window_apply): Rename to window_resize_apply.
7540 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7541 (Fdelete_other_windows_internal, resize_frame_windows)
7542 (Fsplit_window_internal, Fdelete_window_internal)
7543 (grow_mini_window, shrink_mini_window)
7544 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7545
c7e73be5
JD
75462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7547
7548 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7549 (emacs_fixed_set_min_size): Remove.
7550 (emacs_fixed_new): Take frame as argument.
7551
7552 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7553 (_EmacsFixedPrivate): Remove minwidth/height.
7554 Add struct frame *f.
7555 (emacs_fixed_init): Initialize priv->f.
7556 (get_parent_class, emacs_fixed_set_min_size): Remove.
7557 (emacs_fixed_new): Set priv->f to argument.
7558 (emacs_fixed_get_preferred_width)
7559 (emacs_fixed_get_preferred_height): Use min_width/height from
7560 frames size_hint to set minimum and natural (Bug#8919).
7561 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7562 and use min_width/height from frames size_hint to set
7563 min_width/height (Bug#8919).
7564
7565 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7566 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7567 Fix indentation.
c7e73be5 7568
cf99dcf8
EZ
75692011-06-26 Eli Zaretskii <eliz@gnu.org>
7570
7571 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7572 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7573 called at ZV.
7574
029529ac
CY
75752011-06-26 Chong Yidong <cyd@stupidchicken.com>
7576
7577 * process.c (wait_reading_process_output): Bypass select if
7578 waiting for a cell while ignoring keyboard input, and input is
7579 pending. Suggested by Jan Djärv (Bug#8869).
7580
7a7ef429
PE
75812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7582
7583 Use gnulib's dup2 module instead of rolling our own.
7584 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7585
11fdef7d 75862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7587
7588 * dispnew.c (scrolling_window): Before scrolling, turn off a
7589 mouse-highlight in the window being scrolled.
7590
cd3520a4
JB
75912011-06-24 Juanma Barranquero <lekktu@gmail.com>
7592
7593 Move DEFSYM to lisp.h and use everywhere.
7594
7595 * character.h (DEFSYM): Move declaration...
7596 * lisp.h (DEFSYM): ...here.
7597
7598 * gnutls.c:
7599 * minibuf.c:
7600 * w32menu.c:
7601 * w32proc.c:
7602 * w32select.c: Don't include character.h.
7603
7604 * alloc.c (syms_of_alloc):
7605 * buffer.c (syms_of_buffer):
7606 * bytecode.c (syms_of_bytecode):
7607 * callint.c (syms_of_callint):
7608 * casefiddle.c (syms_of_casefiddle):
7609 * casetab.c (init_casetab_once):
7610 * category.c (init_category_once, syms_of_category):
7611 * ccl.c (syms_of_ccl):
7612 * cmds.c (syms_of_cmds):
7613 * composite.c (syms_of_composite):
7614 * dbusbind.c (syms_of_dbusbind):
7615 * dired.c (syms_of_dired):
7616 * dispnew.c (syms_of_display):
7617 * doc.c (syms_of_doc):
7618 * editfns.c (syms_of_editfns):
7619 * emacs.c (syms_of_emacs):
7620 * eval.c (syms_of_eval):
7621 * fileio.c (syms_of_fileio):
7622 * fns.c (syms_of_fns):
7623 * frame.c (syms_of_frame):
7624 * fringe.c (syms_of_fringe):
7625 * insdel.c (syms_of_insdel):
7626 * keymap.c (syms_of_keymap):
7627 * lread.c (init_obarray, syms_of_lread):
7628 * macros.c (syms_of_macros):
7629 * msdos.c (syms_of_msdos):
7630 * print.c (syms_of_print):
7631 * process.c (syms_of_process):
7632 * search.c (syms_of_search):
7633 * sound.c (syms_of_sound):
7634 * syntax.c (init_syntax_once, syms_of_syntax):
7635 * terminal.c (syms_of_terminal):
7636 * textprop.c (syms_of_textprop):
7637 * undo.c (syms_of_undo):
7638 * w32.c (globals_of_w32):
7639 * window.c (syms_of_window):
7640 * xdisp.c (syms_of_xdisp):
7641 * xfaces.c (syms_of_xfaces):
7642 * xfns.c (syms_of_xfns):
7643 * xmenu.c (syms_of_xmenu):
7644 * xsettings.c (syms_of_xsettings):
7645 * xterm.c (syms_of_xterm): Use DEFSYM.
7646
4228cf16
TZ
76472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7648
cd3520a4 7649 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7650
7fcccf1e
PE
76512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7652
7efb4e0e
PE
7653 Integer and buffer overflow fixes (Bug#8873).
7654
ff5844ad
PE
7655 * print.c (printchar, strout): Check for string overflow.
7656 (PRINTPREPARE, printchar, strout):
7657 Don't set size unless allocation succeeds.
7658
90532f02
PE
7659 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7660 for sizes. Check for string overflow more accurately.
7661 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7662
6d84508d
PE
7663 * macros.c: Integer and buffer overflow fixes.
7664 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7665 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7666 Use ptrdiff_t, not int, for sizes.
7667 Don't increment bufsize until after realloc succeeds.
7668 Check for size-calculation overflow.
7669 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7670
437b2cb4
PE
7671 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7672
8b9ac8b4
PE
7673 * lread.c: Integer overflow fixes.
7674 (read_integer): Radix is now EMACS_INT, not int,
7675 to improve quality of diagnostics for out-of-range radices.
7676 Calculate buffer size correctly for out-of-range radices.
7677 (read1): Check for integer overflow in radices, and in
7678 read-circle numbers.
82cb60d3
PE
7679 (read_escape): Avoid int overflow.
7680 (Fload, openp, read_buffer_size, read1)
7681 (substitute_object_recurse, read_vector, read_list, map_obarray):
7682 Use ptrdiff_t, not int, for sizes.
7683 (read1): Use EMACS_INT, not int, for sizes.
20270765 7684 Check for size overflow.
8b9ac8b4 7685
7fcccf1e
PE
7686 * image.c (cache_image): Check for size arithmetic overflow.
7687
bfbbd7e7
PE
7688 * lread.c: Integer overflow issues.
7689 (saved_doc_string_size, saved_doc_string_length)
7690 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7691 Now ptrdiff_t, not int.
7692 (read1): Don't assume doc string length fits in int. Check for
7693 out-of-range doc string lengths.
7694 (read_list): Don't assume file position fits in int.
39019e54 7695 (read_escape): Check for hex character overflow.
bfbbd7e7 7696
4e323265
LL
76972011-06-22 Leo Liu <sdl.web@gmail.com>
7698
7699 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7700 Move to minibuffer.el.
7701
85fece3e
PE
77022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7703
20b84ce9 7704 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7705 The following patches are for when GLYPH_DEBUG && !XASSERT.
7706 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7707 * dispnew.c (flush_stdout):
7708 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7709 Mark as externally visible.
7710 * dispnew.c (check_window_matrix_pointers): Now static.
7711 * dispnew.c (window_to_frame_vpos):
7712 * xfns.c (unwind_create_frame):
7713 * xterm.c (x_check_font): Remove unused local.
7714 * scroll.c (CHECK_BOUNDS):
7715 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7716 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7717 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7718 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7719 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7720 Now static.
7721 (debug_method_add): Use va_list and vsprintf rather than relying
7722 on undefined behavior with wrong number of arguments.
7723 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7724 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7725 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7726 since we're not interested in debugging glyphs with old libraries.
7727 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7728 GCC 4.6.0's static checking.
7729
0766b489
PE
77302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7731
31fd4b32
PE
7732 Integer overflow and signedness fixes (Bug#8873).
7733 A few related buffer overrun fixes, too.
7734
b79e8648
PE
7735 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7736
0766b489
PE
7737 * dispextern.h (struct face.stipple):
7738 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7739 (x_bitmap_mask, x_allocate_bitmap_record)
7740 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7741 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7742 (x_create_bitmap_from_xpm_data):
7743 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7744 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7745 (.bitmaps_last):
7746 * xfaces.c (load_pixmap):
7747 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7748 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7749 (.bitmaps_last, struct x_output.icon_bitmap):
7750 Use ptrdiff_t, not int, for bitmap indexes.
7751 (x_allocate_bitmap_record): Check for size overflow.
7752 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7753
b081724f
PE
7754 Use ptrdiff_t, not int, for overlay counts.
7755 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7756 * editfns.c (overlays_around, get_pos_property):
7757 * textprop.c (get_char_property_and_overlay):
7758 * xdisp.c (next_overlay_change, note_mouse_highlight):
7759 * xfaces.c (face_at_buffer_position):
21514da7
PE
7760 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7761 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7762 (Fnext_overlay_change, Fprevious_overlay_change)
7763 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7764 Use ptrdiff_t, not int, for sizes.
21514da7 7765 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7766
3de73e5e
PE
7767 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7768
2606c57b
PE
7769 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7770 (x_session_initialize): Do not assume string length fits in int.
7771
aaafe47a
PE
7772 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7773 This is unlikely, but can occur if DPI is outlandish.
7774
2674ddc8 7775 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7776 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7777
28154962
PE
7778 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7779 * xrdb.c (magic_file_p, search_magic_path):
7780 Omit last arg SUFFIX; it was always 0. All callers changed.
7781 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7782
7de51af5
PE
7783 * xfont.c (xfont_match): Avoid need for strlen.
7784
25ed6cc3
PE
7785 * xfns.c: Don't assume strlen fits in int.
7786 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7787
4eab31dd
PE
7788 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7789 not unsigned long, as we prefer signed integers. All callers changed.
7790 Detect integer overflow in repeat count.
7791 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7792 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7793
171e2a58
PE
7794 * termcap.c: Don't assume sizes fit in int and never overflow.
7795 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7796 (gobble_line): Check for size-calculation overflow.
7797
ad39faca 7798 * minibuf.c (Fread_buffer):
6e5bb2dc 7799 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7800 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7801 Don't assume string length fits in int.
7802
52c61c22 7803 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7804 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7805
b5b8c9e5
PE
7806 * font.c: Don't assume string length fits in int.
7807 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7808 Use ptrdiff_t, not int.
ccd6111c
PE
7809 (font_intern_prop): Don't assume string length fits in int.
7810 Don't assume integer property fits in fixnum.
7811 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7812
882f0d81 7813 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7814 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7815 Reformulate so as not to need the command string.
7816 Invoke gzip -cd rather than gunzip, as it's more portable.
7817 (lock_info_type, lock_file_1, lock_file):
7818 Don't assume pid_t and time_t fit in unsigned long.
7819 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7820 (current_lock_owner): Prefer signed type for sizes.
7821 Use memcpy, not strncpy, where memcpy is what is really wanted.
7822 Don't assume (via atoi) that time_t and pid_t fit in int.
7823 Check for time_t and/or pid_t out of range, e.g., via a network share.
7824 Don't alloca where an auto var works fine.
7825
93f4cf88
PE
7826 * fileio.c: Fix some integer overflow issues.
7827 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7828 Don't assume string length fits in int.
7829 (directory_file_name): Don't assume string length fits in long.
7830 (make_temp_name): Don't assume pid fits in int, or that its print
7831 length is less than 20.
7832
f3e92b69
PE
7833 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7834
1bfdaf10
PE
7835 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7836
35016e9a
PE
7837 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7838
3d1e65a1
PE
7839 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7840 We prefer signed integers, even for size calculations.
7841
0b963a93
PE
7842 * emacs.c: Don't assume string length fits in 'int'.
7843 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7844 (main): Don't invoke strlen when not needed.
7845
573f4b54
PE
7846 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7847 (XD_DEBUG_MESSAGE): Don't waste a byte.
7848
989f33ba
PE
7849 * callproc.c (getenv_internal_1, getenv_internal)
7850 (Fgetenv_internal):
965d34eb
PE
7851 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7852
e4d29b33
PE
7853 * lread.c (invalid_syntax): Omit length argument.
7854 All uses changed. This doesn't fix a bug, but it simplifies the
7855 code away from its former Hollerith-constant appearance, and it's
7856 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7857 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7858
eb49b136
PE
7859 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7860 This didn't break anything, but it didn't help either.
7861 It's confusing to put a bogus integer in a place where the actual
7862 value does not matter.
9f62aeb1 7863 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7864 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7865
15375a22
PE
7866 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7867 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7868 implementation.
b61cc01c
PE
7869 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7870 We prefer signed types, and the value cannot exceed the EMACS_INT
7871 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7872 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7873 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7874 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7875
53b2623d
PE
7876 * indent.c (sane_tab_width): New function.
7877 (current_column, scan_for_column, Findent_to, position_indentation)
7878 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7879 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7880
51cab52b 7881 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7882
f2ed8a70
PE
7883 * lisp.h (lint_assume): New macro.
7884 * composite.c (composition_gstring_put_cache):
7885 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7886
abe80cc6
PE
7887 * editfns.c, insdel.c:
7888 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7889
b02c740e
PE
7890 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7891
ebc96716
PE
7892 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7893
b4e50fa0 7894 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7895 Use much-faster test for byte-length change.
311d5d7c 7896 Don't assume string byte-length fits in 'int'.
a4cf38e4 7897 Check that character arg fits in 'int'.
85461888 7898 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7899
c0c1ee9f
PE
7900 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7901
a498d7f4
PE
7902 * fns.c (concat): Catch string overflow earlier.
7903 Do not rely on integer wraparound.
7904
51cab52b
PE
7905 * dispextern.h (struct it.overlay_strings_charpos)
7906 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7907 * xdisp.c (forward_to_next_line_start)
7908 (back_to_previous_visible_line_start)
7909 (reseat_at_next_visible_line_start, next_element_from_buffer):
7910 Don't arbitrarily truncate the value of 'selective' to int.
7911
76031fad
PE
7912 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7913
5eb55db9
PE
7914 * composite.c: Don't truncate sizes to 'int'.
7915 (composition_gstring_p, composition_reseat_it)
7916 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7917 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7918 not EMACS_UINT, for indexes.
5eb55db9 7919
0703a717
PE
7920 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7921
d6202519
PE
7922 * buffer.c: Include <verify.h>.
7923 (struct sortvec.priority, struct sortstr.priority):
8961a454 7924 Now EMACS_INT, not int.
c20998a7 7925 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7926 (struct sortstr.size, record_overlay_string)
7927 (struct sortstrlist.size, struct sortlist.used):
7928 Don't truncate size to int.
7929 (record_overlay_string): Check for size-calculation overflow.
d6202519 7930 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7931
d5a19415
JM
79322011-06-22 Jim Meyering <meyering@redhat.com>
7933
029529ac 7934 Don't leak an XBM-image-sized buffer
d5a19415
JM
7935 * image.c (xbm_load): Free the image buffer after using it.
7936
a9041e6c
PE
79372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7938
7939 Port to Sun C.
7940 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7941 that Sun C diagnosed.
7942 * fns.c (secure_hash): Fix pointer signedness issue.
7943 * intervals.c (static_offset_intervals): New function.
7944 (offset_intervals): Use it.
7945
7f3f739f
LL
79462011-06-21 Leo Liu <sdl.web@gmail.com>
7947
7948 * deps.mk (fns.o):
7949 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7950 sha512.h.
7951
7952 * fns.c (secure_hash): Rename from crypto_hash_function and change
7953 the first arg to accept symbols.
5b66d427 7954 (Fsecure_hash): New primitive.
7f3f739f
LL
7955 (syms_of_fns): New symbols.
7956
76147d94
DD
79572011-06-20 Deniz Dogan <deniz@dogan.se>
7958
7959 * process.c (Fset_process_buffer): Clarify return value in
7960 docstring.
7961
7d7d0045
CY
79622011-06-18 Chong Yidong <cyd@stupidchicken.com>
7963
7964 * dispnew.c (add_window_display_history): Use BVAR.
7965
7966 * xdisp.c (debug_method_add): Use BVAR.
7967 (check_window_end, dump_glyph_matrix, dump_glyph)
7968 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7969
7970 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7971 Likewise.
7972
7973 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7974 check till after the cache is created in init_frame_faces.
7975
ff2bc410
SM
79762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7977
7978 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7979
28177add
PE
79802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7981
dd3482fe
PE
7982 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7983 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7984 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7985
393d71f3 7986 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7987 * fileio.c (Finsert_file_contents):
7988 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7989 Remove the old (too-loose) buffer overflow checks.
7990 They weren't needed, since make_gap checks for buffer overflow.
7991 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7992 The old code merely checked for Emacs fixnum overflow, and relied
7993 on undefined (wraparound) behavior. The new code avoids undefined
7994 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7995
2e6813b0 7996 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7997 Tune. Don't use wider integers than needed. Don't use alloca.
7998 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7999
599a9e4f
PE
8000 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8001
99561444
PE
8002 * insdel.c, lisp.h (buffer_overflow): New function.
8003 (insert_from_buffer_1, replace_range, replace_range_2):
8004 * insdel.c (make_gap_larger):
8005 * editfns.c (Finsert_char):
8006 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8007
28177add
PE
8008 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8009
e69dafad
PE
80102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8011
4baa020d 8012 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8013
b1c46f02
PE
8014 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8015 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8016
e69dafad
PE
8017 * fileio.c: Don't assume EMACS_INT fits in off_t.
8018 (emacs_lseek): New static function.
8019 (Finsert_file_contents, Fwrite_region): Use it.
8020 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8021
566684ea
PE
8022 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8023
e6966cd6
PE
8024 * fns.c: Don't overflow int when computing a list length.
8025 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8026 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8027 truncation on 64-bit hosts. Check for QUIT every
8028 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8029 faster and is responsive enough.
8030 (Flength): Report an error instead of overflowing an integer.
8031 (Fsafe_length): Return a float if the value is not representable
8032 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8033 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8034 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8035
dd0b0efb
PE
8036 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8037 (header_size, word_size): New constants.
8038 (allocate_vectorlike): Don't check size overflow here.
8039 (allocate_vector): Check it here instead, since this is the only
8040 caller of allocate_vectorlike that could cause overflow.
8041 Check that the new vector's length is representable as a fixnum.
8042
86fe5cfe
PE
8043 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8044 The previous code was bogus. For example, next_almost_prime (32)
8045 returned 39, which is undesirable as it is a multiple of 3; and
8046 next_almost_prime (24) returned 25, which is a multiple of 5 so
8047 why was the code bothering to check for multiples of 7?
8048
80e88859
PE
8049 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8050
4a2f0ad6
PE
8051 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8052
f66c7cf8
PE
8053 Variadic C functions now count arguments with ptrdiff_t.
8054 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8055 Back then I didn't know that the Emacs coding style prefers signed int.
8056 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8057 were being counted with int, which may truncate counts on 64-bit
8058 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8059 * lisp.h (struct Lisp_Subr.function.aMANY)
8060 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8061 Arg counts are now ptrdiff_t, not size_t.
8062 All variadic functions and their callers changed accordingly.
8063 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8064 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8065 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8066 * callint.c (Fcall_interactively): Check arg count for overflow,
8067 to avoid potential buffer overrun. Use signed char, not 'int',
8068 for 'varies' array, so that we needn't bother to check its size
8069 calculation for overflow.
8070 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8071 * eval.c (apply_lambda):
8072 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8073 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8074 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8075
a1759b76
PE
8076 * callint.c (Fcall_interactively): Don't use index var as event count.
8077
d96be9fc
PE
8078 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8079 * mem-limits.h (SIZE): Remove; no longer used.
8080
a690a978 8081 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8082
578c21e6
PE
8083 Remove unnecessary casts.
8084 * xterm.c (x_term_init):
8085 * xfns.c (x_set_border_pixel):
8086 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8087 These aren't needed now that we assume ANSI C.
8088
96f53c6c
PE
8089 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8090 It's more likely to cause problems (due to unsigned overflow)
8091 than to cure them.
8092
83c77d31
PE
8093 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8094
ee2079f1
PE
8095 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8096
6da65536
PE
8097 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8098
7147c4a4
PE
8099 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8100
193e32d9
PE
8101 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8102
e5533da6
PE
8103 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8104
9910e595
PE
8105 GLYPH_CODE_FACE returns EMACS_INT, not int.
8106 * dispextern.h (merge_faces):
8107 * xfaces.c (merge_faces):
01103c44
PE
8108 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8109 Don't assume EMACS_INT fits in int.
9910e595 8110
2638320e
PE
8111 * character.h (CHAR_VALID_P): Remove unused parameter.
8112 * fontset.c, lisp.h, xdisp.c: All uses changed.
8113
045eb8d9
PE
8114 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8115
c1f134b5
PE
8116 * fns.c (concat): Minor tuning based on overflow analysis.
8117 This doesn't fix any bugs. Use int to hold character, instead
8118 of constantly refetching from Emacs object. Use XFASTINT, not
8119 XINT, for value known to be a character. Don't bother comparing
8120 a single byte to 0400, as it's always less.
8121
395fcb93 8122 * floatfns.c (Fexpt):
327eeec8
PE
8123 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8124
abbd3d23
PE
8125 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8126 for characters.
8127
684a03ef
PE
8128 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8129
0fed43f3
PE
8130 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8131 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8132 incorrectly succeed when S was a string, because 4294967386 was
8133 truncated before it was used.
8134
8fd02eb7
PE
8135 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8136 Otherwise, an out-of-range integer could cause undefined behavior
8137 on a 64-bit host.
8138
f8c86b69
PE
8139 * composite.c: Use int, not EMACS_INT, for characters.
8140 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8141 EMACS_INT, for values that are known to be in character range.
8142 This doesn't fix any bugs but is the usual style inside Emacs and
8143 may generate better code on 32-bit machines.
8144
34206dd2
PE
8145 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8146 This is for reasons similar to the recent CHAR_STRING fix.
8147 * charset.c (Fencode_char): Check that character arg is actually
8148 a character. Pass an int to ENCODE_CHAR.
8149 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8150 wider than 'int', as a compile-time check to prevent future regressions
8151 in this area.
8152
c5958d4c 8153 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8154
8155 Make sure a 64-bit char is never passed to CHAR_STRING.
8156 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8157 by silently ignoring the top 32 bits, allowing some values
8158 that were far too large to be valid characters.
8159 * character.h: Include <verify.h>.
8160 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8161 arguments are no wider than unsigned, as a compile-time check
8162 to prevent future regressions in this area.
8163 * data.c (Faset):
01103c44 8164 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8165 (Fsubst_char_in_region):
8166 * fns.c (concat):
8167 * xdisp.c (decode_mode_spec_coding):
8168 Adjust to CHAR_STRING's new requirement.
8169 * editfns.c (Finsert_char, Fsubst_char_in_region):
8170 * fns.c (concat): Check that character args are actually
8171 characters. Without this test, these functions did the wrong
8172 thing with wildly out-of-range values on 64-bit hosts.
8173
d37ca623
PE
8174 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8175 These casts should not be needed on 32-bit hosts, either.
8176 * keyboard.c (read_char):
8177 * lread.c (Fload): Remove casts to unsigned.
8178
ea204efb
PE
8179 * lisp.h (UNSIGNED_CMP): New macro.
8180 This fixes comparison bugs on 64-bit hosts.
8181 (ASCII_CHAR_P): Use it.
8182 * casefiddle.c (casify_object):
01103c44 8183 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8184 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8185 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8186 * dispextern.h (FACE_FROM_ID):
8187 * keyboard.c (read_char): Use UNSIGNED_CMP.
8188
41cb286c
PE
8189 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8190 not to EMACS_INT, to avoid GCC warning.
8191
4a1b9832
PE
8192 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8193
55daad71
PE
8194 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8195 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8196 isn't needed on 32-bit machines.
8f95c75c 8197
01103c44
PE
8198 * buffer.c (Fgenerate_new_buffer_name):
8199 Use EMACS_INT for count, not int.
0ceccced 8200 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8201
8202 * data.c (Qcompiled_function): Now static.
8203
c6f072e7
PE
8204 * window.c (window_body_lines): Now static.
8205
20ce5912
PE
8206 * image.c (gif_load): Rename local to avoid shadowing.
8207
9c4c5f81
PE
8208 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8209 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8210 * alloc.c (make_save_value): Integer argument is now of type
8211 ptrdiff_t, not int.
8212 (mark_object): Use ptrdiff_t, not int.
8213 * lisp.h (pD): New macro.
8214 * print.c (print_object): Use it.
8215
c0c5c8ae
PE
8216 * alloc.c: Use EMACS_INT, not int, to count objects.
8217 (total_conses, total_markers, total_symbols, total_vector_size)
8218 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8219 (total_free_floats, total_floats, total_free_intervals)
8220 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8221 Now EMACS_INT, not int. All uses changed.
8222 (Fgarbage_collect): Compute overall total using a double, so that
8223 integer overflow is less likely to be a problem. Check for overflow
8224 when converting back to an integer.
5a25e253
PE
8225 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8226 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8227 These were 'int' variables that could overflow on 64-bit hosts;
8228 they were never used, so remove them instead of repairing them.
211a0b2a 8229 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8230 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8231 Previously, this ceilinged at INT_MAX, but that doesn't work on
8232 64-bit machines.
e46bb31a 8233 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8234
c78baabf 8235 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8236 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8237 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8238 when a (possibly-narrower) signed value would do just as well.
8239 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8240
c9d624c6
PE
8241 * alloc.c: Catch some string size overflows that we were missing.
8242 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8243 for convenience in STRING_BYTES_MAX.
8244 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8245 The definition here is exact; the one in lisp.h was approximate.
8246 (allocate_string_data): Check for string overflow. This catches
8247 some instances we weren't catching before. Also, it catches
8248 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8249 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8250 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8251
c9d624c6
PE
8252 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8253 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8254 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8255
353032ce
PE
8256 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8257
2bccce07
PE
8258 * alloc.c (Fmake_string): Check for out-of-range init.
8259
0ac30604
SM
82602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8261
8262 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8263
c195f2de
JD
82642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8265
8266 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8267 xg_get_default_scrollbar_width.
8268
8269 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8270 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8271 (style_changed_cb): Call update_theme_scrollbar_width and call
8272 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8273 all frames (Bug#8505).
8274 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8275 Call gtk_window_set_resizable if HAVE_GTK3.
8276 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8277 and height if HAVE_GTK3 (Bug#8505).
8278 (scroll_bar_width_for_theme): New variable.
8279 (update_theme_scrollbar_width): New function.
8280 (xg_get_default_scrollbar_width): Move code to
8281 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8282 (xg_initialize): Call update_theme_scrollbar_width.
8283
8284 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8285
8286 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8287
e10ac9f1
MR
82882011-06-12 Martin Rudalics <rudalics@gmx.at>
8289
8290 * frame.c (make_frame): Call other_buffer_safely instead of
8291 other_buffer.
8292
8293 * window.c (temp_output_buffer_show): Call display_buffer with
8294 second argument Vtemp_buffer_show_specifiers and reset latter
8295 immediately after the call.
8296 (Vtemp_buffer_show_specifiers): New variable.
8297 (auto_window_vscroll_p, next_screen_context_lines)
8298 (Vscroll_preserve_screen_position): Remove leading asterisks from
8299 doc-strings.
8300
2d3c217e 83012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8302
7b7f97e8 8303 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8304 * buffer.c (Qclone_number): Remove for now, as it's unused.
8305 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8306 (record_buffer): Remove unused local.
8307 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8308 (set_frame_buffer_list): Remove; unused.
8309 * frame.h (other_visible_frames): Remove decl.
8310 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8311 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8312 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8313 if HAVE_GPM.
8314 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8315 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8316 Define only if HAVE_GPM.
8317 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8318 (update_hints_inhibit): Remove; never set. All uses removed.
8319 * widgetprv.h (emacsFrameClassRec): Remove decl.
8320 * window.c (delete_deletable_window): Now returns void, since it
8321 wasn't returning anything.
8322 (compare_window_configurations): Remove unused locals.
8323 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8324 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8325 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8326 the same widths as pointers. This follows up on the 2011-05-06 patch.
8327 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8328 * xterm.h: Likewise.
8329 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8330
1384b89e
JB
83312011-06-12 Juanma Barranquero <lekktu@gmail.com>
8332
8333 * makefile.w32-in: Update dependencies.
8334 (LISP_H): Add lib/intprops.h.
8335
1100a63c
CY
83362011-06-11 Chong Yidong <cyd@stupidchicken.com>
8337
8338 * image.c (gif_load): Add animation frame delay to the metadata.
8339 (syms_of_image): Use DEFSYM. New symbol `delay'.
8340
6198ccd0
MR
83412011-06-11 Martin Rudalics <rudalics@gmx.at>
8342
8343 * window.c (delete_deletable_window): Re-add.
8344 (Fset_window_configuration): Rewrite to handle dead buffers and
8345 consequently deletable windows.
8346 (window_tree, Fwindow_tree): Remove. Supply functionality in
8347 window.el.
8348 (compare_window_configurations): Simplify code.
8349
b6e3633c
AS
83502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8351
1ab0dee5
AS
8352 * image.c (imagemagick_load_image): Fix type mismatch.
8353 (Fimagemagick_types): Likewise.
8354
b6e3633c
AS
8355 * window.h (replace_buffer_in_windows): Declare.
8356
9397e56f
MR
83572011-06-11 Martin Rudalics <rudalics@gmx.at>
8358
8359 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8360 Qclone_number. Remove external declaration of Qdelete_window.
8361 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8362 code.
640c8776
SM
8363 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8364 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8365 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8366 buffer list implementation.
8367 (other_buffer_safely): New function.
8368 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8369 calls to replace_buffer_in_windows and
8370 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8371 if allowed.
8372 (record_buffer): Inhibit quitting and rewrite using quittable
8373 functions. Run Qbuffer_list_update_hook if allowed.
8374 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8375 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8376 Move switch-to-buffer to window.el.
9397e56f
MR
8377 (bury-buffer): Move to window.el.
8378 (Vbuffer_list_update_hook): New variable.
8379
8380 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8381 section.
8382
8383 * window.h (resize_frame_windows): Move up in code.
8384 (Fwindow_frame): Remove EXFUN.
8385 (replace_buffer_in_all_windows): Remove prototype.
8386 (replace_buffer_in_windows_safely): Add prototype.
8387
8388 * window.c: Declare Qdelete_window static again. Move down
8389 declaration of select_count.
8390 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8391 (Fother_window): Move to window.el.
8392 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8393 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8394 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8395 window.el.
8396 (replace_buffer_in_windows): Implement by calling
8397 Qreplace_buffer_in_windows.
8398 (replace_buffer_in_all_windows): Remove with some functionality
8399 moved into replace_buffer_in_windows_safely.
8400 (replace_buffer_in_windows_safely): New function.
8401 (select_window_norecord, select_frame_norecord): Move in front
8402 of run_window_configuration_change_hook. Remove now obsolete
8403 declarations.
640c8776
SM
8404 (Fset_window_buffer): Rewrite doc-string.
8405 Call Qrecord_window_buffer.
9397e56f
MR
8406 (keys_of_window): Move binding for other-window to window.el.
8407
b50691aa
CY
84082011-06-11 Chong Yidong <cyd@stupidchicken.com>
8409
8410 * dispextern.h (struct image): Replace data member, whose int_val
8411 and ptr_val fields were not used by anything, with a single
8412 lisp_val object.
8413
8414 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8415 (gif_clear_image, gif_load, imagemagick_load_image)
8416 (gs_clear_image, gs_load): Callers changed.
8417
3f754b86
PE
84182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8419
cca69397
PE
8420 * buffer.h: Include <time.h>, for time_t.
8421 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8422
109e28d0
PE
8423 Fix minor problems found by static checking.
8424
60737f02
PE
8425 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8426
4b66faf3
PE
8427 Make identifiers static if they are not used in other modules.
8428 * data.c (Qcompiled_function, Qframe, Qvector):
8429 * image.c (QimageMagick, Qsvg):
8430 * minibuf.c (Qmetadata):
8431 * window.c (resize_window_check, resize_root_window): Now static.
8432 * window.h (resize_window_check, resize_root_window): Remove decls.
8433
109e28d0
PE
8434 * window.c (window_deletion_count, delete_deletable_window):
8435 Remove; unused.
46a4ce9e
PE
8436 (window_body_lines): Now static.
8437 (Fdelete_other_windows_internal): Mark vars as initialized.
8438 Make sure 'resize_failed' is initialized.
8439 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8440 (resize_window_apply): Remove unused local.
8441 * window.h (delete_deletable_window): Remove decl.
8442
109e28d0 8443 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8444 (imagemagick_load_image): Fix pointer signedness problem by changing
8445 last arg from unsigned char * to char *. All uses changed.
8446 Also, fix a local for similar reasons.
8447 Remove unused locals. Remove locals to avoid shadowing.
8448 (fn_rsvg_handle_free): Remove; unused.
8449 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8450 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8451
3f754b86
PE
8452 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8453
2547adb1
CY
84542011-06-10 Chong Yidong <cyd@stupidchicken.com>
8455
8456 * image.c (gif_load): Fix omitted cast error introduced by
8457 2011-06-06 change.
8458
2c8e37d4
MR
84592011-06-10 Martin Rudalics <rudalics@gmx.at>
8460
8461 * window.h (resize_proportionally, orig_total_lines)
8462 (orig_top_line): Remove from window structure.
8463 (set_window_height, set_window_width, change_window_heights)
8464 (Fdelete_window): Remove prototypes.
8465 (resize_frame_windows): Remove duplicate declaration.
8466
440a42e3
EZ
84672011-06-10 Eli Zaretskii <eliz@gnu.org>
8468
8469 * window.h (resize_frame_windows, resize_window_check)
8470 (delete_deletable_window, resize_root_window)
8471 (resize_frame_windows): Declare prototypes.
8472
8473 * window.c (resize_window_apply): Make definition be "static" to
8474 match the prototype.
8475
562dd5e9
MR
84762011-06-10 Martin Rudalics <rudalics@gmx.at>
8477
8478 * window.c: Remove declarations of Qwindow_size_fixed,
8479 window_min_size_1, window_min_size_2, window_min_size,
8480 size_window, window_fixed_size_p, enlarge_window, delete_window.
8481 Remove static from declaration of Qdelete_window, it's
8482 temporarily needed by Fbury_buffer.
8483 (replace_window): Don't assign orig_top_line and
8484 orig_total_lines.
8485 (Fdelete_window, delete_window): Remove. Window deletion is
8486 handled by window.el.
640c8776
SM
8487 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8488 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8489 (Fdelete_other_windows): Remove. Deleting other windows is
8490 handled by window.el.
8491 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8492 handled in window.el.
8493 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8494 Window minimum sizes are handled in window.el.
8495 (shrink_windows, size_window, set_window_height)
8496 (set_window_width, change_window_heights, window_height)
8497 (window_width, CURBEG, CURSIZE, enlarge_window)
8498 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8499 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8500 handled in window.el.
8501 (make_dummy_parent): Rename to make_parent_window and give it a
8502 second argument horflag.
8503 (make_window): Don't set resize_proportionally any more.
8504 (Fsplit_window): Remove. Windows are split in window.el.
8505 (save_restore_action, save_restore_orig_size)
8506 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8507 Resize mini windows in window.el.
8508 (grow_mini_window, shrink_mini_window): Implement by calling
8509 Qresize_root_window_vertically, resize_window_check and
8510 resize_window_apply.
640c8776
SM
8511 (saved_window, Fset_window_configuration, save_window_save):
8512 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8513 resize_proportionally.
8514 (window_min_height, window_min_width): Move to window.el.
8515 (keys_of_window): Move bindings for delete-other-windows,
8516 split-window, delete-window and enlarge-window to window.el.
8517
8518 * buffer.c: Temporarily extern Qdelete_window.
8519 (Fbury_buffer): Temporarily call Qdelete_window instead of
8520 Fdelete_window (Fbury_buffer will move to window.el soon).
8521
8522 * frame.c (set_menu_bar_lines_1): Remove code handling
8523 orig_top_line and orig_total_lines.
8524
8525 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8526 set_window_height but set heights directly.
8527 (change_frame_size_1): Use resize_frame_windows.
8528
8529 * xdisp.c (init_xdisp): Don't use set_window_height but set
8530 heights directly.
8531
640c8776
SM
8532 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8533 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8534 run_window_configuration_change_hook.
8535
8536 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8537 instead of change_window_heights and run
8538 run_window_configuration_change_hook.
8539
1a13852e
MR
85402011-06-09 Martin Rudalics <rudalics@gmx.at>
8541
8542 * window.c (replace_window): Rename second argument REPLACEMENT to
8543 NEW. New third argument SETFLAG. Rewrite.
8544 (delete_window, make_dummy_parent): Call replace_window with
8545 third argument 1.
8546 (window_list_1): Move down in code.
8547 (run_window_configuration_change_hook): Move set_buffer part
8548 before select_frame_norecord part in order to unwind correctly.
8549 Rename count1 to count.
8550 (recombine_windows, delete_deletable_window, resize_root_window)
8551 (Fdelete_other_windows_internal)
8552 (Frun_window_configuration_change_hook, make_parent_window)
8553 (resize_window_check, resize_window_apply, Fresize_window_apply)
8554 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8555 (Fdelete_window_internal, Fresize_mini_window_internal):
8556 New functions.
1a13852e
MR
8557 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8558
f3d1777e
MR
85592011-06-08 Martin Rudalics <rudalics@gmx.at>
8560
496e208e
MR
8561 * window.h (window): Add some new members to window structure -
8562 normal_lines, normal_cols, new_total, new_normal, clone_number,
8563 splits, nest, prev_buffers, next_buffers.
8564 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8565 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8566
f3d1777e
MR
8567 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8568 Remove.
496e208e
MR
8569 (make_dummy_parent): Set new members of windows structure.
8570 (make_window): Move down in code. Handle new members of window
8571 structure.
8572 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8573 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8574 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8575 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8576 (Fset_window_next_buffers, Fset_window_clone_number):
8577 New functions.
496e208e
MR
8578 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8579 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8580 Doc-string fixes.
8581 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8582 Argument WINDOW can be now internal window too.
8583 (Fwindow_use_time): Move up in code.
8584 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8585 Rewrite doc-string.
8586 (Fset_window_configuration, saved_window)
8587 (Fcurrent_window_configuration, save_window_save): Handle new
8588 members of window structure.
b9e809c2
MR
8589 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8590 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8591 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8592 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8593 Qget_mru_window, Qresize_root_window,
8594 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8595 Qauto_buffer_name; staticpro them.
f3d1777e 8596
abde8f8c
MR
85972011-06-07 Martin Rudalics <rudalics@gmx.at>
8598
8599 * window.c (Fwindow_total_size, Fwindow_left_column)
8600 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8601 (Fwindow_list_1): New functions.
8602 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8603 (Fwindow_width, Fscroll_left, Fscroll_right):
8604 Use window_body_cols instead of window_box_text_cols.
8605 (delete_window, Fset_window_configuration):
8606 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8607 (delete_all_subwindows): Take a window as argument and not a
8608 structure. Rewrite.
190b47e6
MR
8609 (window_loop): Remove handling of GET_LRU_WINDOW and
8610 GET_LARGEST_WINDOW.
8611 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8612
8613 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8614 window_box_text_cols. delete_all_subwindows now takes a
8615 Lisp_Object as argument.
abde8f8c 8616
640c8776
SM
8617 * indent.c (compute_motion, Fcompute_motion):
8618 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8619
fa8a67e6
MR
8620 * frame.c (delete_frame): Call delete_all_subwindows with root
8621 window as argument.
8622
a54e3482
DC
86232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8624
8625 * fns.c (Fputhash): Document return value.
8626
60002bf5
CY
86272011-06-06 Chong Yidong <cyd@stupidchicken.com>
8628
8629 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8630
0c671da6 86312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8632
b862a52a 8633 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8634
be44ca6c
PE
8635 Check for overflow when converting integer to cons and back.
8636 * charset.c (Fdefine_charset_internal, Fdecode_char):
8637 Use cons_to_unsigned to catch overflow.
8638 (Fencode_char): Use INTEGER_TO_CONS.
8639 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8640 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8641 * data.c (long_to_cons, cons_to_long): Remove.
8642 (cons_to_unsigned, cons_to_signed): New functions.
8643 These signal an error for invalid or out-of-range values.
8644 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8645 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8646 * font.c (Ffont_variation_glyphs):
8647 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8648 * lisp.h: Include <intprops.h>.
8649 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8650 (cons_to_signed, cons_to_unsigned): New decls.
8651 (long_to_cons, cons_to_long): Remove decls.
8652 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8653 (Fprimitive_undo): Use CONS_TO_INTEGER.
8654 * xfns.c (Fx_window_property): Likewise.
8655 * xselect.c: Include <limits.h>.
8656 (x_own_selection, selection_data_to_lisp_data):
8657 Use INTEGER_TO_CONS.
8658 (x_handle_selection_request, x_handle_selection_clear)
8659 (x_get_foreign_selection, Fx_disown_selection_internal)
8660 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8661 (lisp_data_to_selection_data): Use cons_to_unsigned.
8662 (x_fill_property_data): Use cons_to_signed.
8663 Report values out of range.
8664
d1f3d2af
PE
8665 Check for buffer and string overflow more precisely.
8666 * buffer.h (BUF_BYTES_MAX): New macro.
8667 * lisp.h (STRING_BYTES_MAX): New macro.
8668 * alloc.c (Fmake_string):
8669 * character.c (string_escape_byte8):
8670 * coding.c (coding_alloc_by_realloc):
8671 * doprnt.c (doprnt):
8672 * editfns.c (Fformat):
8673 * eval.c (verror):
8674 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8675 since they may not be the same number.
8676 * editfns.c (Finsert_char):
8677 * fileio.c (Finsert_file_contents):
8678 Likewise for BUF_BYTES_MAX.
8679
dd52fcea
PE
8680 * image.c: Use ptrdiff_t, not int, for sizes.
8681 (slurp_file): Switch from int to ptrdiff_t.
8682 All uses changed.
8683 (slurp_file): Check that file size fits in both size_t (for
8684 malloc) and ptrdiff_t (for sanity and safety).
8685
7f9bbdbb
PE
8686 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8687 if b->modtime has its maximal value.
8688
dfe18f82
PE
8689 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8690
84acfcf0
PE
8691 Don't assume time_t can fit into int.
8692 * buffer.h (struct buffer.modtime): Now time_t, not int.
8693 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8694 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8695
ccd9a01a
PE
8696 Minor fixes for signed vs unsigned integers.
8697 * character.h (MAYBE_UNIFY_CHAR):
8698 * charset.c (maybe_unify_char):
8699 * keyboard.c (read_char, reorder_modifiers):
8700 XINT -> XFASTINT, since the integer must be nonnegative.
8701 * ftfont.c (ftfont_spec_pattern):
8702 * keymap.c (access_keymap, silly_event_symbol_error):
8703 XUINT -> XFASTINT, since the integer must be nonnegative.
8704 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8705 since it makes no difference and we prefer signed.
8706 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8707 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8708 nonnegative.
8709
d6d100dd
SM
87102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8711
8712 * window.h (Fwindow_frame): Declare.
8713
2b6148e4
PE
87142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8715
8716 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8717 (SPARE_MEMORY): Always define.
8718 (LARGE_REQUEST): Remove.
8719 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8720
f230ecc9
MR
87212011-06-06 Martin Rudalics <rudalics@gmx.at>
8722
727e958e
MR
8723 * lisp.h: Move EXFUNS for Fframe_root_window,
8724 Fframe_first_window and Fset_frame_selected_window to window.h.
8725
8726 * window.h: Move EXFUNS for Fframe_root_window,
8727 Fframe_first_window and Fset_frame_selected_window here from
8728 lisp.h.
8729
8730 * frame.c (Fwindow_frame, Fframe_first_window)
8731 (Fframe_root_window, Fframe_selected_window)
8732 (Fset_frame_selected_window): Move to window.c.
8733 (Factive_minibuffer_window): Move to minibuf.c.
8734 (Fother_visible_frames_p): New function.
8735
8736 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8737
f230ecc9
MR
8738 * window.c (decode_window, decode_any_window): Move up in code.
8739 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8740 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8741 (Fwindow_buffer): Move up and rewrite doc-string.
8742 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8743 (Fwindow_prev): New functions.
727e958e
MR
8744 (Fwindow_frame): Move here from frame.c. Accept any window as
8745 argument.
8746 (Fframe_root_window, Fframe_first_window)
8747 (Fframe_selected_window): Move here from frame.c. Accept frame
8748 or arbitrary window as argument. Update doc-strings.
8749 (Fminibuffer_window): Move up in code.
8750 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8751 (Fset_frame_selected_window): Move here from frame.c.
8752 Marginal rewrite.
727e958e
MR
8753 (Fselected_window, select_window, Fselect_window): Move up in
8754 code. Minor doc-string fixes.
f230ecc9 8755
4d09bcf6
PE
87562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8757
8758 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8759 Do not assume that spare memory exists; that assumption is valid
8760 only if SYSTEM_MALLOC.
8761 (LARGE_REQUEST): New macro, so that the issue of large requests
8762 is separated from the issue of spare memory.
8763
810928a2
AS
87642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8765
172418ad
AS
8766 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8767 format. (Bug#8806)
8768
43f862f7
AS
8769 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8770
810928a2
AS
8771 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8772 before statements.
8773
a059fe24
JD
87742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8775
8776 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8777
8778 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8779
8780 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8781 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8782
989bf368
JB
87832011-06-05 Juanma Barranquero <lekktu@gmail.com>
8784
8785 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8786
4b80f674
CY
87872011-06-04 Chong Yidong <cyd@stupidchicken.com>
8788
8789 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8790 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8791 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8792 New error handlers.
4b80f674
CY
8793 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8794 Obey Vx_select_enable_clipboard_manager. Catch errors in
8795 x_clipboard_manager_save (Bug#8779).
8796 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8797 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8798
99a33b77 87992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8800
8801 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8802
99a33b77 88032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8804
8805 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8806 in the current matrix if keep_current_p is non-zero.
8807
8264569d
EZ
88082011-06-04 Eli Zaretskii <eliz@gnu.org>
8809
8810 * bidi.c (bidi_level_of_next_char): Fix last change.
8811
57f97249
EZ
88122011-06-03 Eli Zaretskii <eliz@gnu.org>
8813
fec2107c 8814 Support bidi reordering of text covered by display properties.
57f97249 8815
fec2107c
EZ
8816 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8817 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8818 (bidi_cache_search, bidi_cache_iterator_state)
8819 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8820 (bidi_level_of_next_char, bidi_move_to_visually_next):
8821 Support character positions inside a run of characters covered by a
fec2107c
EZ
8822 display string.
8823 (bidi_paragraph_init, bidi_resolve_explicit_1)
8824 (bidi_level_of_next_char): Call bidi_fetch_char and
8825 bidi_fetch_char_advance instead of FETCH_CHAR and
8826 FETCH_CHAR_ADVANCE.
8827 (bidi_init_it): Initialize new members.
8828 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8829 definitions.
8830 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8831 instead of using explicit *_CHAR codes.
d6d100dd
SM
8832 (bidi_resolve_explicit, bidi_resolve_weak):
8833 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8834 bidirectional text is supported only in multibyte buffers.
8835 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8836 it to initialize the frame_window_p member of struct bidi_it.
8837 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8838 (bidi_resolve_explicit, bidi_resolve_weak)
8839 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8840 bidi_it->nchars is non-positive.
8841 (bidi_level_of_next_char): Don't try to lookup the cache for the
8842 next/previous character if nothing is cached there yet, or if we
8843 were just reseat()'ed to a new position.
c40e2fb2 8844
0e14fe90
EZ
8845 * xdisp.c (set_cursor_from_row): Set start and stop points
8846 according to the row's direction when priming the loop that looks
8847 for the glyph on which to display cursor.
8848 (single_display_spec_intangible_p): Function deleted.
8849 (display_prop_intangible_p): Reimplement to call
8850 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8851 Accept 3 additional arguments needed by handle_display_spec.
8852 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8853 values: lists, `(when COND...)' forms, etc.
8854 (single_display_spec_string_p): Support property values that are
8855 lists with the argument STRING its top-level element.
8856 (display_prop_string_p): Fix the condition for processing a
8857 property that is a list to be consistent with handle_display_spec.
fec2107c 8858 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8859 last portion of handle_display_prop.
8860 (compute_display_string_pos): Accept additional argument
8861 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8862 value of a `display' property is a "replacing spec".
8863 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8864 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8865 the display property, but just return a value indicating whether
8866 the display property will replace the characters it covers.
8867 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8868 frame_window_p members of struct bidi_it.
d6d100dd
SM
8869 (compute_display_string_pos, compute_display_string_end):
8870 New functions.
fec2107c
EZ
8871 (push_it): Accept second argument POSITION, where pop_it should
8872 jump to continue iteration.
8873 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8874
fec2107c
EZ
8875 * keyboard.c (adjust_point_for_property): Adjust the call to
8876 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8877
8878 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8879 (bidi_init_it): Update prototypes.
8880 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8881 (compute_display_string_pos, compute_display_string_end):
8882 Declare prototypes.
fec2107c
EZ
8883 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8884 EMACS_INT.
fc6f18ce 8885
40087514 88862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8887
57f53182
PE
8888 Malloc failure behavior now depends on size of allocation.
8889 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8890 * lisp.h: Change signatures accordingly.
8891 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8892 All callers changed. (Bug#8762)
8893
8894 * gnutls.c: Use Emacs's memory allocators.
8895 Without this change, the gnutls library would invoke malloc etc.
8896 directly, which causes problems on non-SYNC_INPUT hosts, and which
8897 runs afoul of improving memory_full behavior. (Bug#8761)
8898 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8899 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8900 xfree instead of the default malloc, realloc, free.
8901 (Fgnutls_boot): No need to check for memory allocation failure,
8902 since xmalloc does that for us.
8903
ac32cd99 8904 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8905 * category.c (hash_get_category_set):
8906 * ccl.c (ccl_driver):
8907 * charset.c (Fdefine_charset_internal):
8908 * charset.h (struct charset.hash_index):
8909 * composite.c (get_composition_id, gstring_lookup_cache)
8910 (composition_gstring_put_cache):
8911 * composite.h (struct composition.hash_index):
8912 * dispextern.h (struct image.hash):
8913 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8914 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8915 (hashfn_equal, hashfn_user_defined, make_hash_table)
8916 (maybe_resize_hash_table, hash_lookup, hash_put)
8917 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8918 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8919 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8920 * image.c (make_image, search_image_cache, lookup_image)
8921 (xpm_put_color_table_h):
8922 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8923 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8924 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8925 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8926 * alloc.c (allocate_vectorlike):
8927 Check for overflow in vector size calculations.
8928 * ccl.c (ccl_driver):
8929 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8930 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8931 need to be updated by these changes.
40087514
PE
8932 * fns.c (make_hash_table, maybe_resize_hash_table):
8933 Check for integer overflow with large hash tables.
0de4bb68
PE
8934 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8935 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8936 (SXHASH_REDUCE): New macro.
8937 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8938 Use it instead of discarding useful hash info with large hash values.
8939 (sxhash_float): New function.
8940 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8941 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8942 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8943 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8944 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8945 Adjust signatures to match updated version of code.
8946 (consing_since_gc): Now EMACS_INT, since a single hash table can
8947 use more than INT_MAX bytes.
8948
698d32e2
DN
89492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8950
8951 Make it possible to build with GCC-4.6+ -O2 -flto.
8952
8953 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8954
fd6fa53f
SM
89552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8956
8957 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8958 Call minibuffer-inactive-mode.
8959
864db017
JB
89602011-05-31 Juanma Barranquero <lekktu@gmail.com>
8961
8962 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8963 Update dependencies.
8964
2ad0baf4
DN
89652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8966
8967 * data.c (init_data): Remove code for UTS, this system is not
8968 supported anymore.
8969
4fcc2638
DN
89702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8971
8972 Don't force ./temacs to start in terminal mode.
8973
8974 * frame.c (make_initial_frame): Initialize faces in all cases, not
8975 only when CANNOT_DUMP is defined.
8976 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8977
c56e0fd5
DN
89782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8979
8980 * dispnew.c (add_window_display_history): Use const for the string
8981 pointer. Remove declaration, not needed.
8982
333d54da 89832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8984
55d4c1b2 8985 Use 'inline', not 'INLINE'.
333d54da 8986 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8987 * alloc.c, fontset.c (INLINE): Remove.
8988 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8989 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8990 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8991 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8992 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8993
738db178
DN
89942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8995
8996 Make it possible to run ./temacs.
8997
8998 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8999 syms_of_callproc does the same thing. Remove test for
9000 "initialized", do it in the caller.
9001 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9002
620c53a6
SM
90032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9004
9005 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9006 (read_minibuf): Use get_minibuffer.
9007 (syms_of_minibuf): Use DEFSYM.
9008 (Qmetadata): New var.
9009 * data.c (Qbuffer): Don't make it static.
9010 (syms_of_data): Use DEFSYM.
9011
e003a292
PE
90122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9013
9014 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9015 (CCL_CODE_MIN): New macro.
9016
ed008a6d
PE
90172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9018
3687c2ef
PE
9019 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9020
ed008a6d
PE
9021 * eval.c (Qdebug): Now static.
9022 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9023 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9024 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9025
d66c4c7c
CY
90262011-05-29 Chong Yidong <cyd@stupidchicken.com>
9027
9028 * image.c: Various fixes to ImageMagick code comments.
9029 (Fimagemagick_types): Doc fix.
9030
5fbc2025
PE
90312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9032
0196f88a
PE
9033 Minor fixes prompted by GCC 4.6.0 warnings.
9034
9035 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9036
5fbc2025
PE
9037 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9038 (x_clipboard_manager_save_all): Move extern decl to ...
9039 * xterm.h: ... here, so that it can be checked for consistency.
9040
1dd3c2d9
CY
90412011-05-29 Chong Yidong <cyd@stupidchicken.com>
9042
9043 * xselect.c (x_clipboard_manager_save_frame)
9044 (x_clipboard_manager_save_all): New functions.
9045 (Fx_clipboard_manager_save): Lisp function deleted.
9046
9047 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9048 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9049
9050 * xterm.h: Update prototype.
9051
5ba6571d
WX
90522011-05-28 William Xu <william.xwl@gmail.com>
9053
9054 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9055 exiting (Bug#8239).
9056
3eaff834
JM
90572011-05-28 Jim Meyering <meyering@redhat.com>
9058
e1900994 9059 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9060 * fns.c (to_uchar): Define.
9061 (crypto_hash_function): Use it to convert some newly-signed
9062 variables to unsigned, to avoid sign-extension bugs. For example,
9063 without this change, (md5 "truc") would evaluate to
9064 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9065 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9066 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9067
0f6990a7
PE
90682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9069
9070 Integer overflow fixes.
c8a9ca5a 9071
08686060
PE
9072 * dbusbind.c: Serial number integer overflow fixes.
9073 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9074 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9075 to hold a serial number that is too large for a fixnum.
9076 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9077 Check for serial numbers out of range. Decode any serial number
59568bf0 9078 that was so large that it became a float. (Bug#8722)
08686060 9079
2d1fc3c7
PE
9080 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9081 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9082 Use XFASTINT rather than XUINT when numbers are nonnegative.
9083 (xd_append_arg, Fdbus_method_return_internal):
9084 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9085 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9086 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9087 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9088 (Bug#8722)
2d1fc3c7 9089
c8a9ca5a
PE
9090 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9091
519e1d69
PE
9092 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9093
6df6ae42 9094 ccl: Add integer overflow checks.
30569699
PE
9095 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9096 (IN_INT_RANGE): New macros.
9097 (ccl_driver): Use them to check for integer overflow when
9098 decoding a CCL program. Many of the new checks are whether XINT (x)
9099 fits in int; it doesn't always, on 64-bit hosts. The new version
9100 doesn't catch all possible integer overflows, but it's an
847044ea 9101 improvement. (Bug#8719)
30569699 9102
c11285dc
PE
9103 * alloc.c (make_event_array): Use XINT, not XUINT.
9104 There's no need for unsigned here.
9105
fdccd48e
PE
9106 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9107 This follows up to the 2011-05-06 change that substituted uintptr_t
9108 for EMACS_INT. This case wasn't caught back then.
9109
37910ab2
PE
9110 Rework Fformat to avoid integer overflow issues.
9111 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9112 now (part of C89). Include <verify.h>.
9113 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9114 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9115 (Fformat): Avoid the prepass trying to compute sizes; it was only
9116 approximate and thus did not catch overflow reliably. Instead, walk
9117 through the format just once, formatting and computing sizes as we go,
9118 checking for integer overflow at every step, and allocating a larger
9119 buffer as needed. Keep track separately whether the format is
9120 multibyte. Keep only the most-recently calculated precision, rather
9121 than them all. Record whether each argument has been converted to
9122 string. Use EMACS_INT, not int, for byte and char and arg counts.
9123 Support field widths and precisions larger than INT_MAX. Avoid
9124 sprintf's undefined behavior with conversion specifications such as %#d
9125 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9126 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9127 formatting out-of-range floating point numbers with int
9173deec 9128 formats. (Bug#8668)
37910ab2 9129
2e6578fb
PE
9130 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9131
0ae6bdee
PE
9132 * data.c: Avoid integer truncation in expressions involving floats.
9133 * data.c: Include <intprops.h>.
9134 (arith_driver): When there's an integer overflow in an expression
9135 involving floating point, convert the integers to floating point
9136 so that the resulting value does not suffer from catastrophic
9137 integer truncation. For example, on a 64-bit host (* 4
9138 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9139 Do not rely on undefined behavior after integer overflow.
9140
de883a70
PE
9141 merge count_size_as_multibyte, parse_str_to_multibyte
9142 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9143 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9144 Check for integer overflow.
9145 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9146 since it's now a duplicate of the other. This is more of
9147 a character than a buffer op, so better that it's in character.c.
9148 * fns.c, print.c: Adjust to above changes.
9149
2ff916cb
PE
91502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9151
9152 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9153
f1b54466
PE
91542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9155
fb1ac845
PE
9156 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9157 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9158 (x_clipboard_manager_save): Now static.
9159 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9160
f1b54466
PE
9161 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9162 (crypto_hash_function): Now static.
9163 Fix pointer signedness problems. Avoid unnecessary initializations.
9164
a9f737ee
CY
91652011-05-27 Chong Yidong <cyd@stupidchicken.com>
9166
9167 * termhooks.h (Vselection_alist): Make it terminal-local.
9168
9169 * terminal.c (create_terminal): Initialize it.
9170
9171 * xselect.c: Support for clipboard managers.
9172 (Vselection_alist): Move to termhooks.h as terminal-local var.
9173 (LOCAL_SELECTION): New macro.
9174 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9175 (symbol_to_x_atom): Remove gratuitous arg.
9176 (x_handle_selection_request, lisp_data_to_selection_data)
9177 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9178 (x_own_selection, x_get_local_selection, x_convert_selection):
9179 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9180 (some_frame_on_display): Delete unused function.
9181 (Fx_own_selection_internal, Fx_get_selection_internal)
9182 (Fx_disown_selection_internal, Fx_selection_owner_p)
9183 (Fx_selection_exists_p): New optional frame arg.
9184 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9185 (x_handle_selection_clear): Don't treat other terminals with the
9186 same keyboard specially. Use the terminal-local Vselection_alist.
9187 (x_clear_frame_selections): Use Frun_hook_with_args.
9188
9189 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9190
9191 * xterm.h: Add support for those atoms.
9192
e067f0c1
CY
91932011-05-26 Chong Yidong <cyd@stupidchicken.com>
9194
9195 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9196 (converted_selections, conversion_fail_tag): New global variables.
9197 (x_selection_request_lisp_error): Free the above.
9198 (x_get_local_selection): Remove unnecessary code.
9199 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9200 of converted selections stored in converted_selections.
9201 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9202 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9203 (x_convert_selection): New function.
9204 (x_handle_selection_event): Simplify.
9205 (x_get_foreign_selection): Don't ignore incoming requests while
9206 waiting for an answer; this will fail when we implement
9207 SAVE_TARGETS, and seems unnecessary anyway.
9208 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9209 (Vx_sent_selection_functions): Doc fix.
9210
0f4aebc0
LL
92112011-05-26 Leo Liu <sdl.web@gmail.com>
9212
9213 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9214
e61124cd
YM
92152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9216
9217 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9218
9219 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9220 for fringe update if it has periodic bitmap.
ac389d0c 9221 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9222 and fringe_bitmap_periodic_p.
9223
9224 * fringe.c (get_fringe_bitmap_data): New function.
9225 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9226 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9227 row. Mark glyph row for fringe update if periodicity changed.
9228
9229 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9230 for fringe update unless it has periodic bitmap.
9231
f16d9837
KH
92322011-05-25 Kenichi Handa <handa@m17n.org>
9233
9234 * xdisp.c (get_next_display_element): Set correct it->face_id for
9235 a static composition.
9236
e1b90ef6
LL
92372011-05-24 Leo Liu <sdl.web@gmail.com>
9238
9239 * deps.mk (fns.o):
9240 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9241
9242 * fns.c (crypto_hash_function, Fsha1): New function.
9243 (Fmd5): Use crypto_hash_function.
9244 (syms_of_fns): Add Ssha1.
9245
7400048f
PE
92462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9247
9248 * gnutls.c: Remove unused macros.
9249 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9250 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9251 Remove macros that are defined and never used.
9252 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9253
abb71cf4
CY
92542011-05-22 Chong Yidong <cyd@stupidchicken.com>
9255
9256 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9257 (Fx_get_selection_internal): Minor cleanup.
9258 (Fx_own_selection_internal): Rename arguments for consistency with
9259 select.el.
9260
6307db39
PE
92612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9262
9263 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9264
f3d4e0a4
CY
92652011-05-22 Chong Yidong <cyd@stupidchicken.com>
9266
9267 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9268
4d8ade89
YM
92692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9270
9271 * dispnew.c (scrolling_window): Don't exclude the case that the
9272 last enabled row in the desired matrix touches the bottom boundary.
9273
32078c8d
GM
92742011-05-21 Glenn Morris <rgm@gnu.org>
9275
9276 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9277 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9278 and add some more files.
32078c8d 9279
7285dc67
EZ
92802011-05-20 Eli Zaretskii <eliz@gnu.org>
9281
9282 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9283 report_file_error introduced by the change from 2011-05-07.
9284
89d1bd22
PE
92852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9286
9287 * systime.h (Time): Define only if emacs is defined.
9288 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9289 where the include path doesn't have X11/X.h by default. See
9290 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9291
cd394be1 92922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9293
9294 * composite.c (find_automatic_composition): Fix previous change.
9295
b9704ad9
GM
92962011-05-20 Glenn Morris <rgm@gnu.org>
9297
9298 * lisp.mk: New file, split from Makefile.in.
9299 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9300 (shortlisp): Remove.
9301 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9302
4a720484
GM
93032011-05-19 Glenn Morris <rgm@gnu.org>
9304
9305 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9306 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9307 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9308 (lisp): Set the order to that of loadup.el.
9309 (shortlisp): Make it a copy of $lisp.
9310 (SOME_MACHINE_LISP): Remove.
9311 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9312 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9313
a28d4396
KH
93142011-05-18 Kenichi Handa <handa@m17n.org>
9315
9316 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9317 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9318 (find_automatic_composition): Mostly rewrite for efficiency.
9319
a2b1fa8e
JB
93202011-05-18 Juanma Barranquero <lekktu@gmail.com>
9321
9322 * makefile.w32-in: Update dependencies.
9323
8e1f5610
CS
93242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9325
9326 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9327 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9328
7025ee00 93292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9330
cdfa6eab
PE
9331 Fix some integer overflow issues, such as string length overflow.
9332
06d6db33
PE
9333 * insdel.c (count_size_as_multibyte): Check for string overflow.
9334
2b4560a8
PE
9335 * character.c (lisp_string_width): Check for string overflow.
9336 Use EMACS_INT, not int, for string indexes and lengths; in
9337 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9338 the resulting string length overflows an EMACS_INT; instead,
9339 report a string overflow if no precision given. When checking for
9340 precision exhaustion, use a check that cannot possibly have
9341 integer overflow. (Bug#8675)
9342 * character.h (lisp_string_width): Adjust to new signature.
9343
cb93f9be
PE
9344 * alloc.c (string_overflow): New function.
9345 (Fmake_string): Use it. This doesn't change behavior, but saves
9346 a few bytes and will simplify future changes.
9347 * character.c (string_escape_byte8): Likewise.
9348 * lisp.h (string_overflow): New decl.
9349
1a1f3366
PE
9350 Fixups, following up to the user-interface timestamp change.
9351 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9352 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9353 * msdos.c (mouse_get_pos): Likewise.
9354 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9355 * w32gui.h (Time): Define by including "systime.h" rather than by
9356 declaring it ourselves. (Bug#8664)
9357
d4e3e4d3
PE
9358 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9359 * image.c (clear_image_cache): Likewise.
9360
f6a24d19
PE
9361 * term.c (term_mouse_position): Don't assume time_t wraparound.
9362
08dc5ae6
PE
9363 Be more systematic about user-interface timestamps.
9364 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9365 and sometimes 'EMACS_UINT', to represent these timestamps.
9366 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9367 This makes the code easier to follow, and makes it easier to catch
9368 integer overflow bugs such as Bug#8664.
9369 * frame.c (Fmouse_position, Fmouse_pixel_position):
9370 Use Time, not unsigned long, for user-interface timestamps.
9371 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9372 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9373 * keyboard.h (last_event_timestamp): Likewise.
9374 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9375 * menu.h (xmenu_show): Likewise.
9376 * term.c (term_mouse_position): Likewise.
9377 * termhooks.h (struct input_event.timestamp): Likewise.
9378 (struct terminal.mouse_position_hook): Likewise.
9379 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9380 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9381 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9382 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9383 what it was before.
9384 * menu.h, termhooks.h: Include "systime.h", for Time.
9385
8e55734a
PE
9386 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9387 Don't assume that the difference between two unsigned long values
9388 can fit into an integer. At this point, we know button_down_time
9389 <= event->timestamp, so the difference must be nonnegative, so
9390 there's no need to cast the result if double-click-time is
9391 nonnegative, as it should be; check that it's nonnegative, just in
9392 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9393 apart (about 25 days). (Bug#8664)
8e55734a 9394
841f1b75 9395 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9396 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9397
3e26f69c
PE
9398 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9399 that always fit in int. Use a sentinel instead of a counter, to
9400 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9401 * frame.h (struct frame): Use int for menu_bar_items_used
9402 instead of EMACS_INT, since it always fits in int.
3e26f69c 9403
5cc152c0
PE
9404 * menu.c (grow_menu_items): Check for int overflow.
9405
d89eb65e
PE
9406 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9407
5235bd3e
PE
9408 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9409 Before, the code was not consistent. These values cannot exceed
9410 2**31 - 1 so there's no need to make them unsigned.
9411 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9412 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9413 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9414 as modifiers.
9415 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9416
bc827e23
PE
9417 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9418 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9419 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9420 presumably because the widths might not match.
9421
78eb494e
PE
9422 * window.c (size_window): Avoid needless test at loop start.
9423
04f2d78b
CB
94242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9425
9426 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9427
d2fc7e3d 94282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9429
9430 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9431
d2fc7e3d 94322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9433
9434 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9435 `width' to `bar_area_x' and `bar_area_width', respectively.
9436 (x_scroll_run): Take account of fringe background extension.
9437
04f2d78b
CB
9438 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9439 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9440 `bar_area_width', respectively.
9441 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9442 background extension.
9443
79b70037
GM
94442011-05-10 Jim Meyering <meyering@redhat.com>
9445
9446 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9447
2f142cc5
JB
94482011-05-10 Juanma Barranquero <lekktu@gmail.com>
9449
9450 * image.c (Finit_image_library): Return t for built-in image types,
9451 like pbm and xbm. (Bug#8640)
9452
57679c86
AS
94532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9454
9455 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9456
888c9e86
EZ
94572011-05-07 Eli Zaretskii <eliz@gnu.org>
9458
b0512a1d
EZ
9459 * w32console.c (Fset_screen_color): Doc fix.
9460 (Fget_screen_color): New function.
9461 (syms_of_ntterm): Defsubr it.
9462
7285dc67
EZ
9463 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9464 unlink the temporary file if Fcall_process didn't create it in the
9465 first place.
9466 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9467 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9468 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9469 cue to call_process_cleanup not to close that handle.
9470
4d3fcc8e
BK
94712011-05-07 Ben Key <bkey76@gmail.com>
9472
9473 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9474 one of two shell specific rules, either bootstrap-temacs-CMD or
9475 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9476 to the previous implementation of the bootstrap-temacs rule.
9477 The bootstrap-temacs-CMD rule is similar to the previous
9478 implementation of the bootstrap-temacs rule except that it
9479 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9480 variable.
9481
9482 These changes, along with some changes to nt/configure.bat,
9483 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9484 earlier fix to add support for --cflags and --ldflags options
9485 that include quotes so that it works whether make uses cmd or
9486 sh as the shell.
9487
b4289b64
MA
94882011-05-06 Michael Albinus <michael.albinus@gmx.de>
9489
9490 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9491 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9492 is a constant.
9493 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9494 a string. Handle both cases.
9495 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9496 (Fdbus_register_method): Use Qinvalid_function.
9497
af4c0e28
JB
94982011-05-06 Juanma Barranquero <lekktu@gmail.com>
9499
9500 * makefile.w32-in: Update dependencies.
9501 (LISP_H): Add inttypes.h and stdin.h.
9502 (PROCESS_H): Add unistd.h.
9503
c51453d9
EZ
95042011-05-06 Eli Zaretskii <eliz@gnu.org>
9505
9506 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9507 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9508
8ff0ac3c 95092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9510
4c4b566b
PE
9511 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9512
aab2b9b5
PE
9513 * term.c (vfatal): Remove stray call to va_end.
9514 It's not needed and the C Standard doesn't allow it here anyway.
9515
c378da0b
PE
9516 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9517 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9518
288b08c7
PE
9519 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9520 bytes.
9521
e3601888
PE
9522 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9523
db6c0e74
PE
9524 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9525
dd5963ea
PE
9526 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9527
88c9450f
PE
9528 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9529
2f9442b8
PE
9530 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9531
c032b5f8
PE
9532 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9533 * charset.c (Fdefine_charset_internal): Don't initialize
9534 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9535 32-bit int (Bug#8600).
a108c10b
PE
9536
9537 * lread.c (read_integer): Be more consistent with string-to-number.
9538 Use string_to_number to do the actual conversion; this avoids
9539 rounding errors and fixes some other screwups. Without this fix,
9540 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9541 (digit_to_number): Move earlier, for benefit of read_integer.
9542 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9543 not a digit in any supported base. (Bug#8602)
a108c10b 9544
ad5f9eea
PE
9545 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9546
aec1708a
PE
9547 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9548 to match comment at start of function. This also removes a
9549 GCC warning about overflow in a 32+64-bit port.
9550
47be4ab5
PE
9551 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9552
371cac43
PE
9553 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9554 Reported by Stefan Monnier in
9555 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9556 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9557 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9558
d01a7826
PE
9559 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9560 (EMACS_UINTPTR): Likewise, with uintptr_t.
9561
7fd47d5c
PE
9562 * lisp.h: Prefer 64-bit EMACS_INT if available.
9563 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9564 on 32-bit hosts that have 64-bit int, so that they can access
9565 large files.
122b0c86
PE
9566 However, temporarily disable this change unless the temporary
9567 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9568
8727937b
PE
9569 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9570
8ac068ac
PE
9571 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9572 This removes an assumption that EMACS_INT and long are the same
9573 width as pointers. The assumption is true for Emacs porting targets
9574 now, but we want to make other targets possible.
9575 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9576 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9577 In the rest of the code, change types of integers that hold casted
9578 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9579 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9580 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9581 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9582 No need to cast type when ORing.
9583 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9584 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9585 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9586 assume EMACS_INT is the same width as char *.
9587 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9588 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9589 Remove no-longer-needed casts.
9590 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9591 (xg_tool_bar_help_callback, xg_make_tool_item):
9592 Use EMACS_INTPTR to hold an integer
9593 that will be cast to void *; this can avoid a GCC warning
9594 if EMACS_INT is not the same width as void *.
9595 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9596 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9597 (current_message_1, set_message_1):
9598 Use a local to convert to proper width without a cast.
9599 * xmenu.c (dialog_selection_callback): Likewise.
9600
ede49d71
PE
9601 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9602 Also, don't assume VALBITS / RAND_BITS is less than 5,
9603 and don't rely on undefined behavior when shifting a 1 left into
9604 the sign bit.
9605 * lisp.h (get_random): Change signature to match.
9606
2f30ecd0
PE
9607 * lread.c (hash_string): Use size_t, not int, for hash computation.
9608 Normally we prefer signed values; but hashing is special, because
9609 it's better to use unsigned division on hash table sizes so that
9610 the remainder is nonnegative. Also, size_t is the natural width
9611 for hashing into memory. The previous code used 'int', which doesn't
9612 retain enough info to hash well into very large tables.
9613 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9614
2a866e7b
PE
9615 * dbusbind.c: Don't possibly lose pointer info when converting.
9616 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9617 Use XPNTR rather than XHASH, so that the high-order bits of
9618 the pointer aren't lost when converting through void *.
9619
51639eac
PE
9620 * eval.c (Fautoload): Don't double-shift a pointer.
9621
92394119
PE
9622 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9623
dbdb9a7c
JB
96242011-05-06 Juanma Barranquero <lekktu@gmail.com>
9625
9626 * gnutls.c (DEF_GNUTLS_FN):
9627 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9628
db7a0b4f
AS
96292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9630
9631 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9632 marker. (Bug#8610)
9633
cd394be1 96342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9635
9636 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9637 New version that can reserve upto 2GB of heap space.
9638
f7ff1b0f 96392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9640
9641 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9642
639c109b
TZ
96432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9644
9645 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9646 `gnutls_certificate_set_x509_key_file'.
9647
d2127135
JB
96482011-05-05 Juanma Barranquero <lekktu@gmail.com>
9649
9650 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9651 Update dependencies.
9652
e968f4f3
JB
96532011-05-04 Juanma Barranquero <lekktu@gmail.com>
9654
9655 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9656 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9657 Remove unused parameter `fildes'.
9658 * process.c (read_process_output, send_process): Don't pass it.
9659
84d358f0
JB
96602011-05-04 Juanma Barranquero <lekktu@gmail.com>
9661
9662 Fix previous change: the library cache is defined in w32.c.
9663 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9664 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9665
0898ca10
JB
96662011-05-04 Juanma Barranquero <lekktu@gmail.com>
9667
9668 Implement dynamic loading of GnuTLS on Windows.
9669
9670 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9671 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9672 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9673 Declare.
9674
9675 * gnutls.c (Qgnutls_dll): Define.
9676 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9677 (gnutls_*): Declare function pointers.
9678 (init_gnutls_functions): New function to initialize function pointers.
9679 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9680 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9681 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9682 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9683 (emacs_gnutls_write, emacs_gnutls_read)
9684 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9685 (Fgnutls_available_p): New function.
9686 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9687 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9688 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9689
9690 * image.c: Include w32.h.
9691 (Vimage_type_cache): Delete.
9692 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9693 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9694 (w32_delayed_load): Move to w32.c.
9695
9696 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9697
9698 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9699 (w32_delayed_load): Move from image.c. When loading a library, record
9700 its filename in the :loaded-from property of the library id.
9701 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9702 Initialize and staticpro them.
9703 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9704
9705 * process.c: Include lisp.h before w32.h, not after.
9706 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9707 instead of gnutls_record_check_pending.
9708
9709 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9710
ff4de4aa
TZ
97112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9712
9713 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9714 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9715 as passed in.
9716
abe95abb
JD
97172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9718
9719 * xterm.c (x_set_frame_alpha): Do not set property on anything
9720 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9721
e16e55d4
JB
97222011-05-02 Juanma Barranquero <lekktu@gmail.com>
9723
9724 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9725
bafcf6a5
JB
97262011-05-02 Juanma Barranquero <lekktu@gmail.com>
9727
9728 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9729 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9730 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9731 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9732 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9733 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9734 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9735 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9736 (Qgnutls_bootprop_callbacks_verify): Make static.
9737
e7a6747f
AS
97382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9739
19ed11ba
AS
9740 * callproc.c: Indentation fixup.
9741
e7a6747f 9742 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9743 (wait_for_termination, interruptible_wait_for_termination):
9744 Move after wait_for_termination_1.
e7a6747f 9745
1ef14cb4
LMI
97462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9747
9748 * sysdep.c (interruptible_wait_for_termination): New function
9749 which is like wait_for_termination, but allows keyboard
9750 interruptions.
9751
9752 * callproc.c (Fcall_process): Add (:file "file") as an option for
9753 the STDOUT buffer.
9754 (Fcall_process_region): Ditto.
9755
330d880c
EZ
97562011-04-30 Eli Zaretskii <eliz@gnu.org>
9757
8db90b73
EZ
9758 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9759 rather than `XVECTOR (FOO)->size'.
9760
330d880c
EZ
9761 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9762 inttypes.h, as a gnulib replacement is used if it not available in
9763 system headers.
9764
15cbd324
EZ
97652011-04-21 Eli Zaretskii <eliz@gnu.org>
9766
9767 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9768 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9769 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9770
9771 * coding.c (coding_alloc_by_realloc): Error out if destination
9772 will grow beyond MOST_POSITIVE_FIXNUM.
9773 (decode_coding_emacs_mule): Abort if there isn't enough place in
9774 charbuf for the composition carryover bytes. Reserve an extra
9775 space for up to 2 characters produced in a loop.
9776 (decode_coding_iso_2022): Abort if there isn't enough place in
9777 charbuf for the composition carryover bytes.
9778
97792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9780
ae940cca
EZ
9781 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9782 aborting when %lld or %lll format is passed.
9783 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9784 %llo or %llx format is passed. (Bug#8545)
9785
03ab8921
EZ
9786 * window.c (window_scroll_line_based): Use a marker instead of
9787 simple variables to record original value of point. (Bug#7952)
9788
afda1437
EZ
9789 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9790 produced by %s or %c overflows available buffer space. (Bug#8545)
9791
f76dee0c
PE
97922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9793
9794 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9795 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9796
fdc5744d
JB
97972011-04-28 Juanma Barranquero <lekktu@gmail.com>
9798
9799 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9800
638f053a
JB
98012011-04-28 Juanma Barranquero <lekktu@gmail.com>
9802
9803 * keyboard.c (Qdelayed_warnings_hook): Define.
9804 (command_loop_1): Run `delayed-warnings-hook'
9805 if Vdelayed_warnings_list is non-nil.
9806 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9807 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9808
d178f871
EZ
98092011-04-28 Eli Zaretskii <eliz@gnu.org>
9810
9811 * doprnt.c (doprnt): Don't return value smaller than the buffer
9812 size if the message was truncated. (Bug#8545).
9813
b124fd93
JB
98142011-04-28 Juanma Barranquero <lekktu@gmail.com>
9815
9816 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9817 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9818
e810457d
PE
98192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9820
9821 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9822
ea51cceb
JB
98232011-04-27 Juanma Barranquero <lekktu@gmail.com>
9824
9825 * makefile.w32-in: Update dependencies.
9826
94dcfacf
EZ
98272011-04-27 Eli Zaretskii <eliz@gnu.org>
9828
9829 Improve `doprnt' and its usage. (Bug#8545)
9830 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9831 `format_end'. Remove support for %l as a conversion specifier.
9832 Don't use xrealloc. Improve diagnostics when the %l size modifier
9833 is used. Update the commentary.
9834
9835 * eval.c (verror): Simplify calculation of size_t.
9836
9837 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9838 messages.
9839
f61f41d7
PE
98402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9841
9842 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9843 change.
9844
96fb4434
PE
98452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9846
9847 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9848 This makes this file independent of the recent pseudovector change.
9849
671875da 98502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9851
69e9b5a3
PE
9852 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9853
b5f869a7 9854 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9855 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9856 Remove unused local.
c8926152 9857 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9858
841a1577 9859 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9860 GCC 4.6.0 optimizes based on type-based alias analysis.
9861 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9862 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9863 != &v->size, and therefore "v->size = 1; b->size = 2; return
9864 v->size;" must therefore return 1. This assumption is incorrect
9865 for Emacs, since it type-puns struct Lisp_Vector * with many other
9866 types. To fix this problem, this patch adds a new type struct
f904488f 9867 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9868 and pseudovectors, and helps optimizing compilers not get fooled
9869 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9870 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9871 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9872 the size member.
eab3844f
PE
9873 (XSETPVECTYPE): Rewrite in terms of new macro.
9874 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9875 This is a bit clearer, and further avoids the possibility of
9876 undesirable aliasing.
9877 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9878 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9879 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9880 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9881 (ASIZE): Now uses header.size rather than size.
9882 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9883 to avoid the hassle of writing XVECTOR (foo)->header.size.
9884 (struct vectorlike_header): New type.
eab3844f
PE
9885 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9886 object, to help avoid aliasing.
9887 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9888 (SUBRP): Likewise, since Lisp_Subr is a special case.
9889 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9890 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9891 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9892 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9893 changed to be "header.size" and "header.next".
9894 * buffer.h (struct buffer): Likewise.
9895 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9896 * frame.h (struct frame): Likewise.
9897 * process.h (struct Lisp_Process): Likewise.
9898 * termhooks.h (struct terminal): Likewise.
9899 * window.c (struct save_window_data, struct saved_window): Likewise.
9900 * window.h (struct window): Likewise.
9901 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9902 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9903 * buffer.c (init_buffer_once): Likewise.
9904 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9905 special case.
9906 * process.c (Fformat_network_address): Use local var for size,
9907 for brevity.
9908
0df1eac5
PE
9909 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9910
847ab9d1 9911 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9912 * data.c (atof): Remove decl; no longer used or needed.
9913 (digit_to_number): Move to lread.c.
9914 (Fstring_to_number): Use new string_to_number function, to be
9915 consistent with how the Lisp reader treats infinities and NaNs.
9916 Do not assume that floating-point numbers represent EMACS_INT
9917 without losing information; this is not true on most 64-bit hosts.
9918 Avoid double-rounding errors, by insisting on integers when
9919 parsing non-base-10 numbers, as the documentation specifies.
9920 * lisp.h (string_to_number): New decl, replacing ...
9921 (isfloat_string): Remove.
bc0a5c13 9922 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9923 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9924 appears to have been a coding error. Similarly, do not accept
9925 strings like +-1e0 as floating point numbers. Do not report
9926 overflow for integer overflows unless the base is not 10 which
9927 means we have no simple and reliable way to continue.
9928 Break out the floating-point parsing into a new
9929 function string_to_number, so that Fstring_to_number parses
9930 floating point numbers consistently with the Lisp reader.
04f2d78b 9931 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9932 (E_CHAR, EXP_INT): Remove, replacing with ...
9933 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9934 (string_to_number): New function, replacing isfloat_string.
9935 This function checks for valid syntax and produces the resulting
9936 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9937 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9938 so that overflow for non-base-10 numbers is reported only when
9939 there's no portable and simple way to convert to floating point.
452f4150 9940
67769ffc
PE
9941 * textprop.c (set_text_properties_1): Rewrite for clarity,
9942 and to avoid GCC warning about integer overflow.
9943
c20db43f
PE
9944 * intervals.h (struct interval): Use EMACS_INT for members
9945 where EMACS_UINT might cause problems. See
9946 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9947 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9948 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9949 All uses changed.
37aa2f85
PE
9950 (offset_intervals): Tell GCC not to worry about length overflow
9951 when negating a negative length.
c20db43f 9952
2538aa2f
PE
9953 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9954 (overrun_check_free): Likewise.
9955
f2d3008d
PE
9956 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9957 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9958 word size.
9959
ec8df744
PE
9960 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9961 (gnutls_make_error): Rename local to avoid shadowing.
9962 (gnutls_emacs_global_deinit): ifdef out; not used.
9963 (Fgnutls_boot): Use const for pointer to readonly storage.
9964 Comment out unused local. Fix pointer signedness problems.
9965
640ee02d
PE
9966 * lread.c (openp): Don't stuff size_t into an 'int'.
9967 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9968 about possible signed overflow.
9969
6048fb2a
PE
9970 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9971 (GDK_KEY_g): Don't define if already defined.
9972 (xg_prepare_tooltip): Avoid pointer signedness problem.
9973 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9974
fa3c87e1
PE
9975 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9976 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9977
2172544b
PE
9978 * xfns.c (Fx_window_property): Simplify a bit,
9979 to make a bit faster and to avoid GCC 4.6.0 warning.
9980 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9981
9b821a21
PE
9982 * fns.c (internal_equal): Don't assume size_t fits in int.
9983
3c616cfa
PE
9984 * alloc.c (compact_small_strings): Tighten assertion a little.
9985
c2982e87
PE
9986 Replace pEd with more-general pI, and fix some printf arg casts.
9987 * lisp.h (pI): New macro, generalizing old pEd macro to other
9988 conversion specifiers. For example, use "...%"pI"d..." rather
9989 than "...%"pEd"...".
9990 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9991 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9992 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9993 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9994 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9995 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9996 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9997 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9998 64-bit hosts.
9999 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10000 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10001 * print.c (safe_debug_print, print_object): Likewise.
10002 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10003 to int.
6f04d126
PE
10004 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10005 avoiding the 0 flag, which is not portable.
c2982e87
PE
10006 * process.c (Fmake_network_process): Use pI to avoid cast.
10007 * region-cache.c (pp_cache): Likewise.
10008 * xdisp.c (decode_mode_spec): Likewise.
10009 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10010 behavior on 64-bit hosts with printf arg.
6f04d126 10011 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10012 (x_stop_queuing_selection_requests): Likewise.
10013 (x_get_window_property): Don't truncate byte count to an 'int'
10014 when tracing.
0b432f21 10015
5e073ec7
PE
10016 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10017 here, since it parses constructs like leading '-' and spaces,
10018 which are not wanted; and it overflows with large numbers.
10019 Instead, simply match F[0-9]+, which is what is wanted anyway.
10020
36372bf9
PE
10021 * alloc.c: Remove unportable assumptions about struct layout.
10022 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10023 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10024 (allocate_vectorlike, make_pure_vector): Use the new macros,
10025 plus offsetof, to remove unportable assumptions about struct layout.
10026 These assumptions hold on all porting targets that I know of, but
10027 they are not guaranteed, they're easy to remove, and removing them
10028 makes further changes easier.
10029
0b432f21
PE
10030 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10031 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10032 (string_overrun_cookie): Now const. Use initializers that
10033 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10034 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10035 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10036 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10037 multiple of sizeof (EMACS_INT); it need not be, if
10038 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10039 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10040
895009e1
JB
100412011-04-26 Juanma Barranquero <lekktu@gmail.com>
10042
10043 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10044
6a7a1b0b
TZ
100452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10046
10047 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10048 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10049 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10050
841a1577 100512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10052
10053 * lisp.h (Qdebug): List symbol.
895009e1 10054 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10055 * keyboard.c (debug-on-event): New variable.
10056 (handle_user_signal): Break into debugger when debug-on-event
10057 matches the current signal symbol.
10058
f2d3ba6f
DN
100592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10060
10061 * alloc.c (check_sblock, check_string_bytes)
10062 (check_string_free_list): Convert to standard C.
10063
42ce4c63
TZ
100642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10065
10066 * w32.c (emacs_gnutls_push): Fix typo.
10067
825cd63c
EZ
100682011-04-25 Eli Zaretskii <eliz@gnu.org>
10069
fb11d64d
EZ
10070 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10071 "cast to pointer from integer of different size".
10072
825cd63c
EZ
10073 Improve doprnt and its use in verror. (Bug#8545)
10074 * doprnt.c (doprnt): Document the set of format control sequences
10075 supported by the function. Use SAFE_ALLOCA instead of always
10076 using `alloca'.
10077
10078 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10079 is one byte too soon. Don't use xrealloc; instead xfree and
10080 xmalloc anew.
10081
e061a11b
TZ
100822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10083
10084 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10085 callbacks stage.
10086
10087 * gnutls.c: Renamed global_initialized to
10088 gnutls_global_initialized. Added internals for the
10089 :verify-hostname-error, :verify-error, and :verify-flags
10090 parameters of `gnutls-boot' and documented those parameters in the
10091 docstring. Start callback support.
9173deec
JB
10092 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10093 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10094 on error. Return error code.
e061a11b
TZ
10095 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10096 (emacs_gnutls_read): Likewise.
10097 (Fgnutls_boot): Return handshake error code.
10098 (emacs_gnutls_handle_error): New function.
10099 (wsaerror_to_errno): Likewise.
10100
10101 * w32.h (emacs_gnutls_pull): Add prototype.
10102 (emacs_gnutls_push): Likewise.
10103
10104 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10105 (emacs_gnutls_push): Likewise.
10106
101072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10108
10109 * process.c (wait_reading_process_output): Check if GnuTLS
10110 buffered some data internally if no FDs are set for TLS
10111 connections.
10112
10113 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10114 (LIBS): Link to USER_LIBS.
10115 ($(BLD)/gnutls.$(0)): New target.
10116
fa6996bc
EZ
101172011-04-24 Eli Zaretskii <eliz@gnu.org>
10118
eb35682e
EZ
10119 * xdisp.c (handle_single_display_spec): Rename the
10120 display_replaced_before_p argument into display_replaced_p, to
10121 make it consistent with the commentary. Fix typos in the
10122 commentary.
10123
e2ad650c
EZ
10124 * textprop.c (syms_of_textprop): Remove dead code.
10125 (copy_text_properties): Delete obsolete commentary about an
10126 interface that was deleted long ago. Fix typos in the description
10127 of arguments.
10128
1b2de274
EZ
10129 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10130 to changes in oldXMenu/XMenu.h from 2011-04-16.
10131 <menu_help_message, prev_menu_help_message>: Constify.
10132 (IT_menu_make_room): menu->help_text is now `const char **';
10133 adjust.
10134
10135 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10136 to changes in oldXMenu/XMenu.h from 2011-04-16.
10137 (struct XMenu): Declare `help_text' `const char **'.
10138
10139 * xfaces.c <Qunspecified>: Make extern again.
10140
10141 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10142 required by POSIX.
1b2de274 10143
762b15be
EZ
10144 * doc.c (get_doc_string): Improve the format passed to `error'.
10145
10146 * doprnt.c (doprnt): Improve commentary.
10147
10148 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10149
10150 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10151 them with etags.
10152
f1052e5d
EZ
10153 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10154 changes in globals.h immediately force recompilation.
762b15be
EZ
10155 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10156 $(CURDIR)/s/ms-w32.h.
10157 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10158
fa6996bc
EZ
10159 * character.c (Fchar_direction): Function deleted.
10160 (syms_of_character): Don't defsubr it.
10161 <char-direction-table>: Deleted.
10162
e6c3da20
EZ
101632011-04-23 Eli Zaretskii <eliz@gnu.org>
10164
10165 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10166 * doprnt.c: Include limits.h.
10167 (SIZE_MAX): New macro.
04f2d78b
CB
10168 (doprnt): Return a size_t value. 2nd arg is now size_t.
10169 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10170 Improve overflow protection. Support `l' modifier for integer
10171 conversions. Support %l conversion. Don't assume an EMACS_INT
10172 argument for integer conversions and for %c.
10173
10174 * lisp.h (doprnt): Restore prototype.
10175
10176 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10177 $(SRC)/character.h.
10178
10179 * Makefile.in (base_obj): Add back doprnt.o.
10180
10181 * deps.mk (doprnt.o): Add back prerequisites.
10182 (callint.o): Depend on character.h.
10183
10184 * eval.c (internal_lisp_condition_case): Include the handler
10185 representation in the error message.
10186 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10187 when breaking from the loop.
10188
10189 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10190
10191 * callint.c (Fcall_interactively): When displaying error message
10192 about invalid control letter, pass the character's codepoint, not
10193 a pointer to its multibyte form. Improve display of the character
10194 in octal and display also its hex code.
10195
10196 * character.c (char_string): Use %x to display the (unsigned)
10197 codepoint of an invalid character, to avoid displaying a bogus
10198 negative value.
10199
10200 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10201 `error', not SYMBOL_NAME itself.
10202
10203 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10204 character arguments to `error'.
10205
10206 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10207 to `error' in error message about FINAL_CHAR argument. Make sure
10208 FINAL_CHAR is a character, and use %c when it is passed as
10209 argument to `error'.
10210
4ffd0d6b 102112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10212
10213 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10214
10215 * w32.c: Include <time.h>.
10216 (sys_localtime): New function.
10217
4ffd0d6b 102182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10219
10220 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10221
4ffd0d6b 10222 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10223
4ffd0d6b 102242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10225
4ffd0d6b
GM
10226 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10227 zombies (Bug#8467).
aac0c6e3 10228
04c56954
EZ
102292011-04-19 Eli Zaretskii <eliz@gnu.org>
10230
10231 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10232 gl_state.e_property when gl_state.object is Qt.
10233
10234 * insdel.c (make_gap_larger): Remove limitation of buffer size
10235 to <= INT_MAX.
10236
16a43933
CY
102372011-04-18 Chong Yidong <cyd@stupidchicken.com>
10238
10239 * xdisp.c (lookup_glyphless_char_display)
10240 (produce_glyphless_glyph): Handle cons cell entry in
10241 glyphless-char-display.
10242 (Vglyphless_char_display): Document it.
10243
10244 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10245 glyphless-char-display.
10246
4581706e
CY
102472011-04-17 Chong Yidong <cyd@stupidchicken.com>
10248
10249 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10250
10251 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10252
10253 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10254 definition for no-X builds.
10255
4887c6e2 102562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10257
fd35b6f9
PE
10258 Static checks with GCC 4.6.0 and non-default toolkits.
10259
5c1ccb01
PE
10260 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10261
006c5daa
PE
10262 * process.c (keyboard_bit_set): Define only if SIGIO.
10263 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10264 (send_process): Repair possible setjmp clobbering.
10265
efc736d3
PE
10266 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10267
4e2fe2e6
PE
10268 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10269
f97334a2
PE
10270 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10271
4e75f29d
PE
10272 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10273 Define only if needed.
10274
90efadd1
PE
10275 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10276 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10277 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10278
3c647824
PE
10279 * dispextern.h (struct redisplay_interface): Rename param
10280 to avoid shadowing.
e264f262 10281 * termhooks.h (struct terminal): Likewise.
761383f4 10282 * xterm.c (xembed_send_message): Likewise.
3c647824 10283
b58c5c4a
PE
10284 * insdel.c (make_gap_smaller): Define only if
10285 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10286
cad59032
PE
10287 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10288 it.
10289
c339dc2e
PE
10290 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10291 so that we aren't warned about unused symbols.
10292
91a3e27b
PE
10293 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10294
399c71d3 10295 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10296
8ffc96f5
PE
10297 * xfns.c (x_real_positions): Mark locals as initialized.
10298
eef9bc79
PE
10299 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10300
098db9dd
PE
10301 * xterm.c: Fix problems found by static analysis with other toolkits.
10302 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10303 (x_dispatch_event): Declare static if USE_GTK, and
10304 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10305 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10306 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10307 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10308 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10309
eb18f6cc
PE
10310 * xmenu.c (menu_help_callback): Pointer type fixes.
10311 Use const pointers when pointing at readonly data. Avoid pointer
10312 signedness clashes.
10313 (FALSE): Remove unused macro.
10314 (update_frame_menubar): Remove unused decl.
10315
1fe72bf8
PE
10316 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10317
60d9e1db
PE
10318 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10319 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10320 (single_menu_item): Rename local to avoid shadowing.
10321
39261c26
PE
10322 * keyboard.c (make_lispy_event): Remove unused local var.
10323
018c5e19
PE
10324 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10325 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10326
63d2b86e
PE
10327 * bitmaps: Change bitmaps from unsigned char back to the X11
10328 compatible char. Avoid the old compiler warnings about
10329 out-of-range initializers by using, for example, '\xab' rather
10330 than 0xab.
10331
aefd87e1
PE
10332 * xgselect.c (xgselect_initialize): Check vs interface
10333 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10334
bf501fb9
PE
10335 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10336
e9829fdf
PE
10337 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10338 to read-only memory.
10339
1086c095
PE
10340 * fns.c (vector): Remove; this old hack is no longer needed.
10341
2baccd04 10342 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10343 Remove unused var.
dde42981 10344 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10345
72391843 10346 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10347
436c16df 10348 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10349 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10350 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10351
92bb796d 10352 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10353 (x_term_init): Remove local to avoid shadowing.
92bb796d 10354
764430a3 10355 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10356
10357 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10358 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10359
d1dfb56c
EZ
103602011-04-16 Eli Zaretskii <eliz@gnu.org>
10361
c4354cb4
EZ
10362 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10363
d1dfb56c
EZ
10364 Fix regex.c, syntax.c and friends for buffers > 2GB.
10365 * syntax.h (struct gl_state_s): Declare character position members
10366 EMACS_INT.
10367
10368 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10369
04f2d78b
CB
10370 * textprop.c (verify_interval_modification, interval_of):
10371 Declare arguments EMACS_INT.
d1dfb56c
EZ
10372
10373 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10374 EMACS_INT.
10375
10376 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10377
10378 * indent.c (Fvertical_motion): Local variable it_start is now
10379 EMACS_INT.
10380
10381 * regex.c (re_match, re_match_2, re_match_2_internal)
10382 (bcmp_translate, regcomp, regexec, print_double_string)
10383 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10384 (re_compile_pattern, re_exec): Declare arguments and local
10385 variables `size_t' and `ssize_t' and return values `regoff_t', as
10386 appropriate.
10387 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10388 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10389 <compile_stack_type>: `size' and `avail' are now `size_t'.
10390
10391 * regex.h <regoff_t>: Use ssize_t, not int.
10392 (re_search, re_search_2, re_match, re_match_2): Arguments that
10393 specify buffer/string position and length are now ssize_t and
10394 size_t. Return type is regoff_t.
10395
613052cd
BK
103962011-04-16 Ben Key <bkey76@gmail.com>
10397
10398 * nsfont.m: Fixed bugs in ns_get_family and
10399 ns_descriptor_to_entity that were caused by using free to
10400 deallocate memory blocks that were allocated by xmalloc (via
10401 xstrdup). This caused Emacs to crash when compiled with
10402 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10403 --enable-checking=xmallocoverrun). xfree is now used to
10404 deallocate these memory blocks.
10405
4170f62f 104062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10407
71b41406
PE
10408 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10409
9587a89d
PE
10410 emacs_write: Accept and return EMACS_INT for sizes.
10411 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10412 et seq.
10413 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10414 Accept and return EMACS_INT.
10415 (emacs_gnutls_write): Return the number of bytes written on
10416 partial writes.
10417 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10418 (emacs_read, emacs_write): Remove check for negative size, as the
10419 Emacs source code has been audited now.
9587a89d
PE
10420 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10421 (emacs_read, emacs_write): Use it.
273a5f82
PE
10422 * process.c (send_process): Adjust to the new signatures of
10423 emacs_write and emacs_gnutls_write. Do not attempt to store
10424 a byte offset into an 'int'; it might overflow.
9587a89d 10425 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10426
3e047f51
PE
10427 * sound.c: Don't assume sizes fit in 'int'.
10428 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10429 Return EMACS_INT, not int.
3e047f51 10430 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10431 Accept EMACS_INT, not int.
10432 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10433 record read return values.
10434
cc39a9db
BK
104352011-04-15 Ben Key <bkey76@gmail.com>
10436
c9d0ec6d
JB
10437 * keyboard.c (Qundefined): Don't declare static since it is used
10438 in nsfns.m.
10439 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10440 static since they are used in nsfont.m.
cc39a9db 10441
6c60eb9f
SM
104422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10443
10444 * process.c (Qprocessp): Don't declare static.
10445 * lisp.h (Qprocessp): Declare again.
10446
7990b61a
JB
104472011-04-15 Juanma Barranquero <lekktu@gmail.com>
10448
10449 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10450
5d4cb038
PE
104512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10452
8bd7b830 10453 Improve C-level modularity by making more things 'static'.
cd64ea1d 10454
e3b27b31
PE
10455 Don't publish debugger-only interfaces to other modules.
10456 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10457 (verify_bytepos, count_markers): Move decls to the only modules
10458 that need them.
10459 * region-cache.h (pp_cache): Likewise.
10460 * window.h (check_all_windows): Likewise.
10461 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10462
5d4cb038
PE
10463 * sysdep.c (croak): Now static, if
10464 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10465 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10466
10467 * alloc.c (refill_memory_reserve): Now static if
10468 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10469 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10470
e87b6180
PE
10471 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10472 Define only if USE_LUCID.
10473
ac64929e
PE
10474 * xrdb.c (x_customization_string, x_rm_string): Now static.
10475
6f37259d
PE
10476 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10477 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10478
1683e3ab
PE
10479 * xdisp.c (draw_row_with_mouse_face): Now static.
10480 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10481
de9c2632
PE
10482 * window.h (check_all_windows): Mark externally visible.
10483
2b96acb7
PE
10484 * window.c (window_deletion_count): Now static.
10485
10486 * undo.c: Make symbols static if they're not exported.
10487 (last_undo_buffer, last_boundary_position, pending_boundary):
10488 Now static.
10489
50436f33
PE
10490 * textprop.c (interval_insert_behind_hooks): Now static.
10491 (interval_insert_in_front_hooks): Likewise.
10492
64520e5c
PE
10493 * term.c: Make symbols static if they're not exported.
10494 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10495 (max_frame_lines, tty_set_terminal_modes):
10496 (tty_reset_terminal_modes, tty_turn_off_highlight):
10497 (get_tty_terminal): Now static.
10498 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10499 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10500 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10501 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10502 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10503
1fa53021
PE
10504 * sysdep.c: Make symbols static if they're not exported.
10505 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10506 Now static.
10507 (sigprocmask_set, full_mask): Remove; unused.
10508 (wait_debugging): Mark as visible.
10509 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10510 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10511
d4b43b22
PE
10512 * syntax.c (syntax_temp): Define only if !__GNUC__.
10513
b7c513d0
PE
10514 * sound.c (current_sound_device, current_sound): Now static.
10515
989b29ad
PE
10516 * search.c (searchbufs, searchbuf_head): Now static.
10517
13a55a78
PE
10518 * scroll.c (scroll_cost): Remove; unused.
10519 * dispextern.h (scroll_cost): Remove decl.
10520
de68a1fc
PE
10521 * region-cache.h (pp_cache): Mark as externally visible.
10522
40ccffa6
PE
10523 * process.c: Make symbols static if they're not exported.
10524 (process_tick, update_tick, create_process, chan_process):
10525 (Vprocess_alist, proc_buffered_char, datagram_access):
10526 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10527 (deactivate_process): Mark defn as static, as well as decl.
10528 * lisp.h (create_process): Remove decl.
10529 * process.h (chan_process, Vprocess_alist): Remove decls.
10530
ad64fc97
PE
10531 * print.c: Make symbols static if they're not exported.
10532 (print_depth, new_backquote_output, being_printed, print_buffer):
10533 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10534 (print_interval, print_number_index, initial_stderr_stream):
10535 Now static.
10536 * lisp.h (Fprinc): Remove decl.
10537 (debug_output_compilation_hack): Mark as externally visible.
10538
adddb265
PE
10539 * sysdep.c (croak): Move decl from here to syssignal.h.
10540 * syssignal.h (croak): Put it here, so the API can be checked when
10541 'croak' is called from dissociate_if_controlling_tty.
10542
1717ede2
PE
10543 * minibuf.c: Make symbols static if they're not exported.
10544 (minibuf_save_list, choose_minibuf_frame): Now static.
10545 * lisp.h (choose_minibuf_frame): Remove decl.
10546
fa5fb2bc
PE
10547 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10548
1e3890d1
PE
10549 * lread.c: Make symbols static if they're not exported.
10550 (read_objects, initial_obarray, oblookup_last_bucket_number):
10551 Now static.
10552 (make_symbol): Remove; unused.
10553 * lisp.h (initial_obarray, make_symbol): Remove decls.
10554
8a1414fa
PE
10555 * keyboard.c: Make symbols static if they're not exported.
10556 (single_kboard, recent_keys_index, total_keys, recent_keys):
10557 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10558 (this_single_command_key_start, echoing, last_auto_save):
10559 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10560 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10561 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10562 (Vlispy_mouse_stem, double_click_count):
10563 Now static.
10564 (force_auto_save_soon): Define only if SIGDANGER.
10565 (ignore_mouse_drag_p): Now static if
10566 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10567 (print_help): Remove; unused.
10568 (stop_character, last_timer_event): Mark as externally visible.
10569 * keyboard.h (ignore_mouse_drag_p): Declare only if
10570 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10571 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10572 * lisp.h (echoing): Remove decl.
10573 (force_auto_save_soon): Declare only if SIGDANGER.
10574 * xdisp.c (redisplay_window): Simplify code, to make it more
10575 obvious that ignore_mouse_drag_p is not accessed if !defined
10576 USE_GTK && !defined HAVE_NS.
10577
93ea6e8f
PE
10578 * intervals.c: Make symbols static if they're not exported.
10579 (merge_properties_sticky, merge_interval_right, delete_interval):
10580 Now static.
10581 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10582
77382fcc
PE
10583 * insdel.c: Make symbols static if they're not exported.
10584 However, leave prepare_to_modify_buffer alone. It's never
10585 called from outside this function, but that appears to be a bug.
10586 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10587 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10588 (adjust_after_replace_noundo): Remove; unused.
10589 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10590 (signal_before_change): Remove decls.
77382fcc 10591
9306c32e
PE
10592 * indent.c (val_compute_motion, val_vmotion): Now static.
10593
cd44d2eb
PE
10594 * image.c: Make symbols static if they're not exported.
10595 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10596 if USE_GTK.
10597 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10598 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10599
ad9a7a06
PE
10600 * fringe.c (standard_bitmaps): Now static.
10601 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10602
81626931
PE
10603 * frame.c: Make symbols static if they're not exported.
10604 (x_report_frame_params, make_terminal_frame): Now static.
10605 (get_frame_param): Now static, unless HAVE_NS.
10606 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10607 (x_get_resource_string): Remove; not used.
10608 * frame.h (make_terminal_frame, x_report_frame_params):
10609 (x_get_resource_string); Remove decls.
10610 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10611 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10612
239f9db9
PE
10613 * font.c, fontset.c: Make symbols static if they're not exported.
10614 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10615 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10616 * font.c (font_close_object): Now static.
10617 * font.h (font_close_object): Remove.
10618 * fontset.c (FONTSET_OBJLIST): Remove.
10619 (free_realized_fontset) #if-0 the body, which does nothing.
10620 (face_suitable_for_char_p): #if-0, as it's never called.
10621 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10622 * xfaces.c (face_at_string_position):
10623 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10624 since 0 is always ASCII.
10625
dfcf3579
PE
10626 * fns.c (weak_hash_tables): Now static.
10627
5045092b
PE
10628 * fileio.c: Make symbols static if they're not exported.
10629 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10630 (Vwrite_region_annotation_buffers): Now static.
10631
57a96f5c
PE
10632 * eval.c: Make symbols static if they're not exported.
10633 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10634 * lisp.h (backtrace_list): Remove decl.
10635
35f08c38
PE
10636 * emacs.c: Make symbols static if they're not exported.
10637 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10638 (fatal_error_code, fatal_error_signal_hook, standard_args):
10639 Now static.
10640 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10641 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10642 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10643 * lisp.h (fatal_error_signal_hook): Remove decl.
10644 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10645
f44bd759
PE
10646 * editfns.c: Move a (normally-unused) function to its only use.
10647 * editfns.c, lisp.h (get_operating_system_release): Remove.
10648 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10649 worth the hassle of breaking this out.
10650
b532497d
PE
10651 * xterm.c: Make symbols static if they're not exported.
10652 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10653 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10654 (x_destroy_window, x_delete_display):
10655 Now static.
10656 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10657 (x_mouse_leave): Remove; unused.
10658 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10659 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10660 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10661 Remove decls.
10662 (x_mouse_leave): Declare only if WINDOWSNT.
10663 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10664 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10665 USE_X_TOOLKIT.
10666
1675728f
PE
10667 * ftxfont.c: Make symbols static if they're not exported.
10668 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10669 HAVE_FREETYPE.
10670 * font.h (ftxfont_driver): Likewise.
10671
e4cebfca
PE
10672 * xfns.c: Make symbols static if they're not exported.
10673 (x_last_font_name, x_display_info_for_name):
10674 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10675 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10676 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10677 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10678 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10679 (last_show_tip_args): Now static.
10680 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10681 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10682 (x_screen_planes): Remove; unused.
10683 * dispextern.h (x_screen_planes): Remove decl.
10684
5bf46f05
PE
10685 * dispnew.c: Make symbols static if they're not exported.
10686 * dispextern.h (redraw_garbaged_frames, scrolling):
10687 (increment_row_positions): Remove.
10688 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10689 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10690 Now static.
10691 (redraw_garbaged_frames): Remove; unused.
10692
435f4c28
PE
10693 * xfaces.c: Make symbols static if they're not exported.
10694 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10695 Remove decls.
10696 * xterm.h (defined_color): Remove decls.
10697 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10698 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10699 (menu_face_changed_default, defined_color, free_realized_face):
10700 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10701 (ascii_face_of_lisp_face): Remove; unused.
10702
8524aef3
PE
10703 * xdisp.c: Make symbols static if they're not exported.
10704 * dispextern.h (scratch_glyph_row, window_box_edges):
10705 (glyph_to_pixel_coords, set_cursor_from_row):
10706 (get_next_display_element, set_iterator_to_next):
10707 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10708 (show_mouse_face): Remove decls
10709 * frame.h (message_buf_print): Likewise.
10710 * lisp.h (pop_message, set_message, check_point_in_composition):
10711 Likewise.
10712 * xterm.h (set_vertical_scroll_bar): Likewise.
10713 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10714 (message_buf_print, scratch_glyph_row, displayed_buffer):
10715 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10716 (get_next_display_element, show_mouse_face, window_box_edges):
10717 (frame_to_window_pixel_xy, check_point_in_composition):
10718 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10719 (glyph_to_pixel_coords): Remove; unused.
10720
16390cd2
PE
10721 * dired.c (file_name_completion): Now static.
10722
10723 * dbusbind.c (xd_in_read_queued_messages): Now static.
10724
a25f4dfa
PE
10725 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10726 * data.c (circular_list_error): Remove.
10727
14a9c8df
PE
10728 * commands.h (last_point_position, last_point_position_buffer):
10729 (last_point_position_window): Remove decls.
10730 * keyboard.c: Make these variables static.
10731
04f2d78b
CB
10732 * coding.h (coding, code_convert_region, encode_coding_gap):
10733 Remove decls.
74ab6df5
PE
10734 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10735 (iso_code_class, detect_coding, code_convert_region): Now static.
10736 (encode_coding_gap): Remove; unused.
10737
38dfbee1
PE
10738 * chartab.c (chartab_chars, chartab_bits): Now static.
10739
a2cb4e63
PE
10740 * charset.h (charset_iso_8859_1): Remove decl.
10741 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10742 Now static.
10743
127198fd
PE
10744 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10745 * ccl.c (Vccl_program_table): Now static.
10746 (check_ccl_update): Remove; unused.
10747
d85b608f
PE
10748 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10749 * category.h: ... from here.
10750 * category.c (check_category_table, set_category_set): Now static.
10751
31cd66f3
PE
10752 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10753 * lisp.h: Remove these decls.
10754
c358e587
PE
10755 * buffer.c (buffer_count): Remove unused var.
10756
e78aecca
PE
10757 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10758 so that it's not optimized away.
10759 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10760 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10761 exported only to the debugger.
10762
e192d7d3 10763 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10764 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10765
92470028
PE
10766 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10767 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10768 was inaccessible from Lisp.
10769 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10770 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10771
244ed907
PE
10772 alloc.c: Import and export fewer symbols, and remove unused items.
10773 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10774 is defined.
10775 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10776 it's not optimized away by whole-program optimization.
10777 (message_enable_multibyte, free_misc): Remove.
10778 (catchlist, handlerlist, mark_backtrace):
10779 Declare only if BYTE_MARK_STACK.
10780 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10781 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10782 (message_enable_multibyte): Remove decl.
10783 (free_misc, interval_free_list, float_block, float_block_index):
10784 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10785 (cons_free_list, last_marked_index):
10786 Now static.
10787 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10788 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10789 (mark_backtrace): Define only if BYTE_MARK_STACK.
10790 * xdisp.c (message_enable_multibyte): Now static.
10791
61c2b50e 10792 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10793 This makes it easier for human readers (and static analyzers)
10794 to see whether these variables are used from other modules.
10795 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10796 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10797 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10798 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10799 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10800 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10801 * xmenu.c, xselect.c:
10802 Declare Q* vars static if they are not used in other modules.
10803 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10804 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10805 Remove decls of unexported vars.
10806 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10807
95c82688
PE
10808 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10809
16a97296
PE
10810 Make Emacs functions such as Fatom 'static' by default.
10811 This makes it easier for human readers (and static analyzers)
10812 to see whether these functions can be called from other modules.
10813 DEFUN now defines a static function. To make the function external
10814 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10815 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10816 (Finit_image_library):
16a97296
PE
10817 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10818 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10819 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10820 Remove decls, since these functions are now static.
10821 (Funintern, Fget_internal_run_time): New decls, since these functions
10822 were already external.
95c82688 10823
16a97296
PE
10824 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10825 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10826 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10827 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10828 * keyboard.c, keymap.c, lread.c:
10829 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10830 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10831 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10832 Mark functions with DEFUE instead of DEFUN,
10833 if they are used in other modules.
10834 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10835 decls for now-static functions.
10836 * buffer.h (Fdelete_overlay): Remove decl.
10837 * callproc.c (Fgetenv_internal): Mark as internal.
10838 * composite.c (Fremove_list_of_text_properties): Remove decl.
10839 (Fcomposition_get_gstring): New forward static decl.
10840 * composite.h (Fcomposite_get_gstring): Remove decl.
10841 * dired.c (Ffile_attributes): New forward static decl.
10842 * doc.c (Fdocumntation_property): New forward static decl.
10843 * eval.c (Ffetch_bytecode): New forward static decl.
10844 (Funintern): Remove extern decl; now in .h file where it belongs.
10845 * fileio.c (Fmake_symbolic_link): New forward static decl.
10846 * image.c (Finit_image_library): New forward static decl.
10847 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10848 * intervals.h (Fprevious_property_change):
10849 (Fremove_list_of_text_properties): Remove decls.
10850 * keyboard.c (Fthis_command_keys): Remove decl.
10851 (Fcommand_execute): New forward static decl.
10852 * keymap.c (Flookup_key): New forward static decl.
10853 (Fcopy_keymap): Now static.
10854 * keymap.h (Flookup_key): Remove decl.
10855 * process.c (Fget_process): New forward static decl.
10856 (Fprocess_datagram_address): Mark as internal.
10857 * syntax.c (Fsyntax_table_p): New forward static decl.
10858 (skip_chars): Remove duplicate decl.
10859 * textprop.c (Fprevious_property_change): New forward static decl.
10860 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10861 Now internal.
10862 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10863 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10864
785bbd42
PE
10865 * editfns.c (Fformat): Remove unreachable code.
10866
8b913b57
AS
108672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10868
10869 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10870 change. (Bug#8496)
10871
a6744a35
EZ
108722011-04-13 Eli Zaretskii <eliz@gnu.org>
10873
10874 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10875 when at ZV. (Bug#8487)
10876
e7974947
AS
108772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10878
baad03f0
AS
10879 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10880 (Bug#8437)
10881 * keyboard.c (parse_tool_bar_item): Likewise.
10882 * sound.c (sound_cleanup, alsa_close): Likewise.
10883 * termcap.c (tgetent): Likewise.
10884 * xfns.c (x_default_font_parameter): Likewise.
10885 * xsettings.c (read_and_apply_settings): Likewise.
10886
e7974947
AS
10887 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10888 (overrun_check_free): Protoize.
10889
28272684
PE
108902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10891
10892 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10893 since callers should never pass a negative size.
10894 Change the signature to match that of plain 'read' and 'write'; see
10895 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10896 * lisp.h: Update prototypes of emacs_write and emacs_read.
10897
11997c76
EZ
108982011-04-11 Eli Zaretskii <eliz@gnu.org>
10899
10900 * xdisp.c (redisplay_window): Don't try to determine the character
10901 position of the scroll margin if the window start point w->startp
e896f03c 10902 is outside the buffer's accessible region. (Bug#8468)
11997c76 10903
8a2cbd72
EZ
109042011-04-10 Eli Zaretskii <eliz@gnu.org>
10905
10906 Fix write-region and its subroutines for buffers > 2GB.
10907 * fileio.c (a_write, e_write): Modify declaration of arguments and
10908 local variables to support buffers larger than 2GB.
10909 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10910
10911 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10912 argument, local variables, and return value.
10913
10914 * lisp.h: Update prototypes of emacs_write and emacs_read.
10915
10916 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10917
4073e537 109182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10919
1ebfdcb6
PE
10920 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10921
b2ded58d
PE
10922 Fix more problems found by GCC 4.6.0's static checks.
10923
7d66342c
PE
10924 * xdisp.c (vmessage): Use a better test for character truncation.
10925
bbf47d44
PE
10926 * charset.c (load_charset_map): <, not <=, for optimization,
10927 and to avoid potential problems with integer overflow.
9248994d 10928 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10929 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10930 * editfns.c (Fformat): Likewise.
1e69125e 10931 * syntax.c (skip_chars): Likewise.
3befa583 10932
e3019616
PE
10933 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10934 This also lets GCC 4.6.0 generate slightly better loop code.
10935
becfa255
PE
10936 * callint.c (Fcall_interactively): <, not <=, for optimization.
10937 (Fcall_interactively): Count the number of arguments produced,
10938 not the number of arguments given. This is simpler and lets GCC
10939 4.6.0 generate slightly better code.
10940
dae0cd48
PE
10941 * ftfont.c: Distingish more carefully between FcChar8 and char.
10942 The previous code passed unsigned char * to a functions like
10943 strlen and xstrcasecmp that expect char *, which does not
10944 conform to the C standard.
10945 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10946 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10947 char * when the C standard requires it.
10948
76032d70
PE
10949 * keyboard.c (read_char): Remove unused var.
10950
eb3f1cc8
PE
10951 * eval.c: Port to Windows vsnprintf (Bug#8435).
10952 Include <limits.h>.
10953 (SIZE_MAX): Define if the headers do not.
10954 (verror): Do not give up if vsnprintf returns a negative count.
10955 Instead, grow the buffer. This ports to Windows vsnprintf, which
10956 does not conform to C99. Problem reported by Eli Zaretskii.
10957 Also, simplify the allocation scheme, by avoiding the need for
10958 calling realloc, and removing the ALLOCATED variable.
10959
70476b54
PE
10960 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10961
12020a9e
PE
10962 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10963 But keep the doprint source code for now, as we might revamp it
10964 and use it again (Bug#8435).
ea6c7ae6
PE
10965 * lisp.h (doprnt): Remove.
10966 * Makefile.in (base_obj): Remove doprnt.o.
10967 * deps.mk (doprnt.o): Remove.
10968
5fdb398c
PE
10969 error: Print 32- and 64-bit integers portably (Bug#8435).
10970 Without this change, on typical 64-bit hosts error ("...%d...", N)
10971 was used to print both 32- and 64-bit integers N, which relied on
10972 undefined behavior.
61bdb816 10973 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10974 * lisp.h (error, verror): Mark as printf-like functions.
10975 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10976 Report overflow in size calculations when allocating printf buffer.
10977 Do not truncate output string at its first null byte.
10978 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10979 Truncate the output at a character boundary, since vsnprintf does not
10980 do that.
10981 * charset.c (check_iso_charset_parameter): Convert internal
10982 character to string before calling 'error', since %c now has the
10983 printf meaning.
10984 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10985 overflow when computing char to be passed to 'error'. Do not
10986 pass Lisp_Object to 'error'; pass the integer instead.
10987 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10988 formatted with plain %d.
10989
b189fa66
PE
10990 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10991
bff87ef0
PE
10992 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10993
7e2cac20
PE
10994 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10995
ce4d90b5
PE
10996 * xterm.c (x_catch_errors): Remove duplicate declaration.
10997
266c9547
PE
10998 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10999
79c49ad2
PE
11000 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11001
368f4090
JM
110022011-04-10 Jim Meyering <meyering@redhat.com>
11003
11004 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11005 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11006 return ssize_t not "int", and use size_t as the buffer length.
11007 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11008 * gnutls.h: Update declarations.
11009 * process.c (read_process_output): Use ssize_t, to match.
11010 (send_process): Likewise.
11011
a32d4040
CY
110122011-04-09 Chong Yidong <cyd@stupidchicken.com>
11013
11014 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11015
8546720e 110162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11017
04f2d78b
CB
11018 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11019 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11020
8546720e
GM
11021 * xterm.c (handle_one_xevent):
11022 * xmenu.c (create_and_show_popup_menu):
11023 * xselect.c (x_decline_selection_request)
11024 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11025
0a2f5c1a 110262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11027
11028 Fix some uses of `int' instead of EMACS_INT.
11029 * search.c (string_match_1, fast_string_match)
11030 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11031 (scan_buffer, find_next_newline_no_quit)
11032 (find_before_next_newline, search_command, Freplace_match)
11033 (Fmatch_data): Make some `int' variables be EMACS_INT.
11034
11035 * xdisp.c (display_count_lines): 3rd argument and return value now
11036 EMACS_INT. All callers changed.
11037 (pint2hrstr): Last argument is now EMACS_INT.
11038
11039 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11040 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11041 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11042 (decode_coding_utf_16, decode_coding_emacs_mule)
11043 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11044 (decode_coding_ccl, decode_coding_charset)
11045 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11046 (decode_coding_iso_2022, decode_coding_emacs_mule)
11047 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11048 <char_offset, last_offset>: Declare EMACS_INT.
11049 (encode_coding_utf_8, encode_coding_utf_16)
11050 (encode_coding_emacs_mule, encode_invocation_designation)
11051 (encode_designation_at_bol, encode_coding_iso_2022)
11052 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11053 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11054 Declare EMACS_INT.
11055 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11056 (encode_invocation_designation): Last argument P_NCHARS is now
11057 EMACS_INT.
11058 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11059 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11060
11061 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11062 All users changed.
11063
11064 * ccl.c (Fccl_execute_on_string): Declare some variables
11065 EMACS_INT.
11066
8546720e 110672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11068
11069 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11070
4e19a977
CS
110712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11072
11073 * process.c (Fformat_network_address): Doc fix.
11074
87302331
R
110752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11076
ee7683eb 11077 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11078
cbb59342
CY
110792011-04-08 Chong Yidong <cyd@stupidchicken.com>
11080
11081 * keyboard.c (read_char): Call Lisp function help-form-show,
11082 instead of using internal_with_output_to_temp_buffer.
11083 (Qhelp_form_show): New var.
e0d38eeb 11084 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11085
11086 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11087
11088 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11089
e67a13ab
CY
110902011-04-06 Chong Yidong <cyd@stupidchicken.com>
11091
04f2d78b
CB
11092 * process.c (Flist_processes): Remove to Lisp.
11093 (list_processes_1): Delete.
e67a13ab 11094
973f782d
EZ
110952011-04-06 Eli Zaretskii <eliz@gnu.org>
11096
7c106b1e
EZ
11097 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11098
973f782d
EZ
11099 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11100
41cf7d1a 111012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11102
ca23cc88
PE
11103 Fix more problems found by GCC 4.6.0's static checks.
11104
f390e2d5
PE
11105 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11106
42eea0d0
PE
11107 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11108
b69769da 11109 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11110
f9541e84
PE
11111 * xdisp.c (vmessage): Mark as a printf-like function.
11112
13841b55
PE
11113 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11114
c136c10f
PE
11115 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11116
5e2d4a30
PE
11117 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11118 printf-like functions.
11119 (tiff_load): Add casts to remove these marks before passing them
11120 to system-supplied API.
11121
583f48b9
PE
11122 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11123
b25d760e
PE
11124 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11125 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11126 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11127 directly, rather than having caller test rule sign. This avoids
11128 some unnecessary tests.
11129 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11130 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11131 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11132
bc7b6697 11133 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11134 (xfont_open): Avoid unnecessary tests.
bc7b6697 11135
27ccc379
PE
11136 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11137
dcd5c89a
PE
11138 * composite.h, composite.c (composition_gstring_put_cache):
11139 Use EMACS_INT, not int, for length.
11140
b13a45c6
PE
11141 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11142 breaking out part of COMPOSITION_DECODE_RULE.
11143 (COMPOSITION_DECODE_RULE): Use it.
11144 * composite.c (get_composition_id): Remove unused local vars,
11145 by using the new macro.
11146
1e792e4d
PE
11147 * textprop.c (set_text_properties_1): Change while to do-while,
11148 since the condition is always true at first.
11149
dc6c6455 11150 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11151 (interval_deletion_adjustment): Return unsigned value.
11152 All uses changed.
dc6c6455 11153
aba7731a
PE
11154 * process.c (list_processes_1, create_pty, read_process_output):
11155 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11156 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11157 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11158 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11159 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11160
fdfc4bf3
PE
11161 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11162
fca8fe46 11163 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11164 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11165
06a0259a 11166 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11167 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11168 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11169
e7b9e80f
PE
11170 * print.c (print_error_message): Avoid int overflow.
11171
56201685
PE
11172 * font.c (font_list_entities): Redo for clarity,
11173 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11174
78834453 11175 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11176 (font_score): Avoid potential overflow in diff calculation.
78834453 11177
0bc0b309 11178 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11179 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11180
e610eaca
PE
11181 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11182
b895abce
PE
11183 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11184 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11185 can always succeed if overflow has undefined behavior.
11186
1f1d9321 11187 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11188 (wordify): Omit three unnecessary tests.
1f1d9321 11189
c59478bc
PE
11190 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11191 All callers changed. This avoids the need for an unused var.
11192
79b73827
PE
11193 * casefiddle.c (casify_region): Remove var that is set but not used.
11194
a4db5dfe
PE
11195 * dired.c (file_name_completion): Remove var that is set but not used.
11196
43aae36e
PE
11197 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11198
2a47c44d 11199 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11200 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11201
a37c69bf
PE
11202 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11203 Check for integer overflow on size calculations.
11204
328ab8e7
PE
11205 * buffer.c (Fprevious_overlay_change): Remove var that is set
11206 but not used.
11207
e5a2a5cb
PE
11208 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11209 Remove vars that are set but not used.
8d84a6eb 11210 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11211 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11212
a60e5f68
PE
11213 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11214
f661cb61 11215 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11216 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11217
f0397f5a
PE
11218 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11219 that are set but not used.
11220
8664db06 11221 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11222 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11223
6abdaa4a
PE
11224 * xselect.c (x_get_local_selection, x_handle_property_notify):
11225 Remove vars that are set but not used.
11226
0ce7538d 11227 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11228 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11229
9ae848fc
PE
11230 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11231 Remove var that is set but not used.
0b918413
PE
11232 (scroll_bar_windows_size): Now size_t, not int.
11233 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11234 Check for overflow.
9ae848fc 11235
a5a62657
PE
11236 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11237 (map_tty_color) [!defined MSDOS]: Likewise.
11238
5c5cdd39
PE
11239 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11240
66ebf983
PE
11241 * coding.c: Remove vars that are set but not used.
11242 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11243 All callers changed.
11244 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11245 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11246 (decode_coding_charset): Remove vars that are set but not used.
11247
1be4d761
PE
11248 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11249 that is set but not used.
11250
47553fa8
PE
11251 * print.c (print_object): Remove var that is set but not used.
11252
1f7196bf 11253 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11254 The gnulib version avoids calling malloc in the usual case,
11255 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11256 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11257 * filelock.c (current_lock_owner): Likewise.
11258 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11259 * sysdep.c: Include allocator.h, careadlinkat.h.
11260 (emacs_no_realloc_allocator): New static constant.
11261 (emacs_readlink): New function.
fdb61804
PE
11262 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11263 ../lib/careadlinkat.h.
d1fdcab7 11264
f84c17c7
SM
112652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11266
11267 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11268 first non-nil return value).
11269
ef3862ad
JD
112702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11271
11272 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11273 if not defined (Bug#8403).
11274
376a7006
JB
112752011-04-02 Juanma Barranquero <lekktu@gmail.com>
11276
11277 * xdisp.c (display_count_lines): Remove parameter `start',
11278 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11279 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11280 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11281 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11282 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11283 and thereabouts. All callers changed.
11284 (get_per_char_metric): Remove parameter `f', unused since
11285 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11286
6ca3801d
JM
112872011-04-02 Jim Meyering <meyering@redhat.com>
11288
11289 do not dereference NULL upon failed strdup
11290 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11291 (ns_get_family): Likewise.
11292
d8e2b5ba
JB
112932011-04-02 Juanma Barranquero <lekktu@gmail.com>
11294
11295 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11296
8c74fcbd
JD
112972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11298
11299 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11300 later (Bug#8403).
11301
7200d79c
SM
113022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11303
03408648 11304 Add lexical binding.
7200d79c 11305
03408648
SM
11306 * window.c (Ftemp_output_buffer_show): New fun.
11307 (Fsave_window_excursion):
11308 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11309
11310 * lread.c (lisp_file_lexically_bound_p): New function.
11311 (Fload): Bind Qlexical_binding.
11312 (readevalloop): Remove `evalfun' arg.
11313 Bind Qinternal_interpreter_environment.
11314 (Feval_buffer): Bind Qlexical_binding.
11315 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11316 Mark as dynamic.
11317 (syms_of_lread): Declare `lexical-binding'.
11318
11319 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11320
11321 * keyboard.c (eval_dyn): New fun.
11322 (menu_item_eval_property): Use it.
ca105506
SM
11323
11324 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11325
03408648
SM
11326 * fns.c (concat, mapcar1): Accept byte-code-functions.
11327
11328 * eval.c (Fsetq): Handle lexical vars.
11329 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11330 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11331 (FletX, Flet): Obey lexical binding.
11332 (Fcommandp): Handle closures.
11333 (Feval): New `lexical' arg.
11334 (eval_sub): New function extracted from Feval. Use it almost
11335 everywhere where Feval was used. Look up vars in lexical env.
11336 Handle closures.
11337 (Ffunctionp): Move from subr.el.
11338 (Ffuncall): Handle closures.
11339 (apply_lambda): Remove `eval_flags'.
11340 (funcall_lambda): Handle closures and new byte-code-functions.
11341 (Fspecial_variable_p): New function.
11342 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11343 but without exporting it to Lisp.
23aba0ea 11344
23aba0ea 11345 * doc.c (Fdocumentation, store_function_docstring):
03408648 11346 * data.c (Finteractive_form): Handle closures.
23aba0ea 11347
03408648
SM
11348 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11349 interactive spec.
ba83908c 11350
04f2d78b
CB
11351 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11352 New byte-codes.
03408648
SM
11353 (exec_byte_code): New function extracted from Fbyte_code to handle new
11354 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11355
03408648 11356 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11357
03408648 11358 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11359
e2abce01
JB
113602011-03-31 Juanma Barranquero <lekktu@gmail.com>
11361
11362 * xdisp.c (redisplay_internal): Fix prototype.
11363
63696a73 113642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11365
63696a73 11366 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11367 (try_scrolling): Use it when setting scroll_limit.
11368 Limit scrolling to 100 screen lines.
63696a73
EZ
11369 (redisplay_window): Even when falling back on "recentering",
11370 position point in the window according to scroll-conservatively,
11371 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11372
11373 (try_scrolling): When point is above the window, allow searching
11374 as far as scroll_max, or one screenful, to compute vertical
11375 distance from PT to the scroll margin position. This prevents
11376 try_scrolling from unnecessarily failing when
11377 scroll-conservatively is set to a value slightly larger than the
11378 window height. Clean up the case of PT below the margin at bottom
11379 of window: scroll_max can no longer be INT_MAX. When aggressive
11380 scrolling is in use, don't let point enter the opposite scroll
11381 margin as result of the scroll.
11382 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11383 threshold of 100 lines for never-recentering scrolling.
11384
e4cc2dfc
JB
113852011-03-31 Juanma Barranquero <lekktu@gmail.com>
11386
11387 * dispextern.h (move_it_by_lines):
11388 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11389 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11390 (message_log_check_duplicate): Remove parameters `prev_bol' and
11391 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11392 (redisplay_internal): Remove parameter `preserve_echo_area',
11393 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11394
11395 * indent.c (Fvertical_motion):
11396 * window.c (window_scroll_pixel_based, Frecenter):
11397 Don't pass `need_y_p' to `move_it_by_lines'.
11398
1c470562
SM
113992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11400
44f230aa
SM
11401 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11402 steal a few bits to be more compact.
11403 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11404 Remove unneeded casts.
11405
1c470562
SM
11406 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11407
888adce9
ZK
114082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11409
11410 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11411 binding" message (bug#7967).
11412
f838ed7b
PE
114132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11414
77861b95
PE
11415 Fix more problems found by GCC 4.6.0's static checks.
11416
de6dbc14
PE
11417 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11418 Remove unused local var.
11419
f838ed7b
PE
11420 * editfns.c (Fmessage_box): Remove unused local var.
11421
792c7b2b
PE
11422 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11423 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11424 Omit unused local vars.
c499e557 11425 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11426 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11427 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11428 Omit unused local var.
11429
ba0165e1
PE
11430 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11431 Don't assume string length fits in int.
32ad8845 11432 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11433 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11434
3c59b4c9
PE
11435 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11436 instead of alloca (Bug#8344).
11437
a3eed478 11438 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11439 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11440
eb4d412d
PE
11441 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11442
1658b401
PE
11443 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11444 concerns.
11445
11446 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11447
11448 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11449
9a2c6e05
PE
11450 * keyboard.c (syms_of_keyboard): Use the same style as later
11451 in this function when indexing through an array. This also
11452 works around GCC bug 48267.
11453
03d0a109
PE
11454 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11455
44f730c8
PE
11456 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11457
fe75f926
PE
11458 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11459 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11460
ffa8c828
PE
11461 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11462 This avoids undefined behavior on integer overflow, and is a bit
11463 more convenient anyway since it is compared to a size_t variable.
11464
c5101a77
PE
11465 Variadic C functions now count arguments with size_t, not int.
11466 This avoids an unnecessary limitation on 64-bit machines, which
11467 caused (substring ...) to crash on large vectors (Bug#8344).
11468 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11469 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11470 All variadic functions and their callers changed accordingly.
c5101a77
PE
11471 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11472 * data.c (arith_driver, float_arith_driver): Likewise.
11473 * editfns.c (general_insert_function): Likewise.
11474 * eval.c (struct backtrace.nargs, interactive_p)
11475 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11476 (funcall_lambda, mark_backtrace): Likewise.
11477 * fns.c (concat): Likewise.
11478 * frame.c (x_set_frame_parameters): Likewise.
11479 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11480 0 if not found, not -1. All callers changed.
11481
dd3f25f7
PE
11482 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11483 (stack_copy_size): Now size_t, not int.
11484 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11485
461c2ab9
JB
114862011-03-28 Juanma Barranquero <lekktu@gmail.com>
11487
11488 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11489 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11490 All callers changed.
11491
11492 * lisp.h (multibyte_char_to_unibyte):
11493 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11494 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11495 * character.h (CHAR_TO_BYTE8):
11496 * cmds.c (internal_self_insert):
11497 * editfns.c (general_insert_function):
11498 * keymap.c (push_key_description):
11499 * search.c (Freplace_match):
11500 * xdisp.c (message_dolog, set_message_1): All callers changed.
11501
f6d62986
SM
115022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11503
11504 * keyboard.c (safe_run_hook_funcall): New function.
11505 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11506 don't set the hook to nil, but remove the offending function instead.
11507 (Qcommand_hook_internal): Remove, unused.
11508 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11509 Vcommand_hook_internal.
11510
11511 * eval.c (enum run_hooks_condition): Remove.
11512 (funcall_nil, funcall_not): New functions.
11513 (run_hook_with_args): Call each function through a `funcall' argument.
11514 Remove `cond' argument, now redundant.
11515 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11516 (Frun_hook_with_args_until_failure): Adjust accordingly.
11517 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11518
1db5b1ad
JB
115192011-03-28 Juanma Barranquero <lekktu@gmail.com>
11520
11521 * dispextern.h (string_buffer_position): Remove declaration.
11522
11523 * print.c (strout): Remove parameter `multibyte', unused since
11524 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11525
11526 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11527 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11528 All callers changed.
11529
11530 * w32.c (_wsa_errlist): Use braces for struct initializers.
11531
11532 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11533 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11534 All callers changed.
11535 (string_buffer_position): Likewise. Also, make static (it's never
11536 used outside xdisp.c).
11537 (cursor_row_p): Remove parameter `w', unused since
11538 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11539 (decode_mode_spec): Remove parameter `precision', introduced during
11540 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11541 All callers changed.
11542
5ffb62aa
JD
115432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11544
11545 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11546
461c2ab9 115472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11548
11549 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11550 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11551 (ns_update_auto_hide_menu_bar): New functions.
11552 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11553 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11554 ns_constrain_all_frames.
11555 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11556 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11557
5c380ffb
JD
115582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11559
11560 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11561
9af30bdf
GM
115622011-03-27 Glenn Morris <rgm@gnu.org>
11563
11564 * syssignal.h: Replace RETSIGTYPE with void.
11565 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11566 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11567 Replace SIGTYPE with void everywhere.
11568 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11569 * s/template.h (SIGTYPE): Remove commented out definition.
11570
e2abce01
JB
115712011-03-26 Eli Zaretskii <eliz@gnu.org>
11572
11573 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11574 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11575
f868cd8a
JB
115762011-03-26 Juanma Barranquero <lekktu@gmail.com>
11577
59eb0929
JB
11578 * w32.c (read_unc_volume): Use parameter `henum', instead of
11579 global variable `wget_enum_handle'.
11580
11581 * keymap.c (describe_vector): Remove parameters `indices' and
11582 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11583 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11584
f868cd8a
JB
11585 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11586
11587 * keyboard.c (timer_check): Remove parameter `do_it_now',
11588 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11589 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11590 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11591
11592 * keyboard.c (read_char):
11593 * w32menu.c (w32_menu_display_help):
11594 * xmenu.c (show_help_event, menu_help_callback):
11595 Adjust calls to `show_help_echo'.
11596
11597 * gtkutil.c (xg_maybe_add_timer):
11598 * keyboard.c (readable_events):
11599 * process.c (wait_reading_process_output):
11600 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11601
11602 * insdel.c (adjust_markers_gap_motion):
11603 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11604 (gap_left, gap_right): Don't call it.
11605
2ecf6fdb
CY
116062011-03-25 Chong Yidong <cyd@stupidchicken.com>
11607
11608 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11609 incurred during fontification.
11610
6b1f9ba4
JB
116112011-03-25 Juanma Barranquero <lekktu@gmail.com>
11612
11613 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11614 (DEFVAR_PER_BUFFER): Don't pass it.
11615
11616 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11617 (scrolling_window): Don't pass it.
11618
0f4a96b5
JB
116192011-03-25 Juanma Barranquero <lekktu@gmail.com>
11620
11621 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11622
11623 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11624 and `suffix'.
11625 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11626 of variables specific to SELinux and computation of `encoded_absname'.
11627
11628 * image.c (XPutPixel): Remove unused variable `height'.
11629
11630 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11631
11632 * unexw32.c (get_section_info): Remove unused variable `section'.
11633
11634 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11635 (system_process_attributes): Remove unused variable `sess'.
11636 (sys_read): Remove unused variable `err'.
11637
11638 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11639 (w32_wnd_proc): Remove unused variable `isdead'.
11640 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11641 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11642 (x_create_tip_frame): Remove unused variable `tem'.
11643
11644 * w32inevt.c (w32_console_read_socket):
11645 Remove unused variable `no_events'.
11646
11647 * w32term.c (x_draw_composite_glyph_string_foreground):
11648 Remove unused variable `width'.
11649
1149507c
JB
116502011-03-24 Juanma Barranquero <lekktu@gmail.com>
11651
11652 * w32term.c (x_set_glyph_string_clipping):
11653 Don't pass uninitialized region to CombineRgn.
11654
9c88f339
JB
116552011-03-23 Juanma Barranquero <lekktu@gmail.com>
11656
11657 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11658 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11659 (Fx_close_connection): Remove unused variable `i'.
11660
11661 * w32font.c (w32font_draw): Return number of glyphs.
11662 (w32font_open_internal): Remove unused variable `i'.
11663 (w32font_driver): Add missing initializer.
11664
11665 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11666 (fill_in_menu): Remove unused variable `items_added'.
11667
11668 * w32term.c (last_mouse_press_frame): Remove static global variable.
11669 (w32_clip_to_row): Remove unused variable `f'.
11670 (x_delete_terminal): Remove unused variable `i'.
11671
11672 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11673 (NOTHING): Remove unused static global variable.
11674 (uniscribe_check_otf): Remove unused variable `table'.
11675 (uniscribe_font_driver): Add missing initializers.
11676
dee091a3
JD
116772011-03-23 Julien Danjou <julien@danjou.info>
11678
11679 * term.c (Fsuspend_tty, Fresume_tty):
11680 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11681 * window.c (temp_output_buffer_show):
11682 * insdel.c (signal_before_change):
11683 * frame.c (Fhandle_switch_frame):
11684 * fileio.c (Fdo_auto_save):
11685 * emacs.c (Fkill_emacs):
11686 * editfns.c (save_excursion_restore):
11687 * cmds.c (internal_self_insert):
11688 * callint.c (Fcall_interactively):
11689 * buffer.c (Fkill_all_local_variables):
11690 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11691 Use Frun_hooks.
0f4a96b5 11692 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11693 unconditionally since it does the check itself.
dee091a3 11694
2c520ab5 116952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11696
c9c49752
PE
11697 Fix more problems found by GCC 4.5.2's static checks.
11698
8abc3f12
PE
11699 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11700 the first time through the loop, since we know p0 < p1 then.
11701 This also avoids a gcc -Wstrict-overflow warning.
11702
a2d26660
PE
11703 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11704 leading to a memory leak, possible in functions like
11705 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11706 of objects (Bug#8318).
a2d26660 11707
916c72e9
PE
11708 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11709 that could (at least in theory) be that large.
11710
19ab8a18
PE
11711 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11712 This is less likely to overflow, and avoids undefined behavior if
11713 overflow does occur. All callers changed. Use strtoul to scan
11714 for the unsigned long integer.
b7cbbd6f
PE
11715 (pint2hrstr): Simplify and tune code slightly.
11716 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11717
f0641eff
PE
11718 * scroll.c (do_scrolling): Work around GCC bug 48228.
11719 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11720
7f650bb9
PE
11721 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11722 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11723 (validate_x_resource_name): Simplify count usage.
11724 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11725
37dd57d1
PE
11726 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11727 fail (Bug#8306).
81e56e61 11728
699979fc 11729 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11730
401bf9b4
PE
11731 * process.c (Fmake_network_process): Use socklen_t, not int,
11732 where POSIX says socklen_t is required in portable programs.
11733 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11734 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11735 (Fmake_network_process, server_accept_connection):
11736 (wait_reading_process_output, read_process_output):
11737 Likewise.
11738
b93aacde
PE
11739 * process.c: Rename or move locals to avoid shadowing.
11740 (list_processes_1, Fmake_network_process):
11741 (read_process_output_error_handler, exec_sentinel_error_handler):
11742 Rename or move locals.
4dc343ee 11743 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11744 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11745 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11746 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11747 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11748
af8a867c 11749 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11750 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11751 Include tparam.h instead, since it declares them.
af8a867c
PE
11752 * cm.h (PC): Remove extern decl; tparam.h now does this.
11753 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11754 * terminfo.c: Include tparam.h, to check interfaces.
11755 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11756 (tparam): Adjust signature to match interface in tparam.h;
11757 this removes some undefined behavior. Check that outstring and len
11758 are zero, which they always are with Emacs.
11759 * tparam.h (PC, BC, UP): New extern decls.
11760
0248044d 11761 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11762 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11763
8ff096c1 11764 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11765 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11766 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11767 (ftfont_list): Remove unused local.
49eaafba
PE
11768 (get_adstyle_property, ftfont_pattern_entity):
11769 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11770 Rename locals to avoid shadowing.
8ff096c1 11771
e2be39f6
PE
11772 * xfont.c (xfont_list_family): Mark var as initialized.
11773
c9735e30
PE
11774 * xml.c (make_dom): Now static.
11775
8f5201ae
PE
11776 * composite.c (composition_compute_stop_pos): Rename local to
11777 avoid shadowing.
b246f932
PE
11778 (composition_reseat_it): Remove unused locals.
11779 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11780 (composition_update_it): Mark var as initialized.
11b61122
PE
11781 (find_automatic_composition): Mark vars as initialized,
11782 with a FIXME (Bug#8290).
8f5201ae 11783
760fbc2c
PE
11784 character.h: Rename locals to avoid shadowing.
11785 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11786 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11787 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11788 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11789 to avoid shadowing.
11790
ff08eb85
PE
11791 * textprop.c (property_change_between_p): Remove; unused.
11792
fc7bf025
PE
11793 * intervals.c (interval_start_pos): Now static.
11794
235d7abc
PE
11795 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11796
44f230aa
SM
11797 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11798 Rename locals to avoid shadowing.
3e7d6594 11799
50060332
PE
11800 * sound.c (wav_play, au_play, Fplay_sound_internal):
11801 Fix pointer signedness.
d01f234b 11802 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11803 (wav_play): Initialize a variable to 0, to prevent undefined
11804 behavior (Bug#8278).
50060332 11805
c4fc4e30
PE
11806 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11807
918436ed
PE
11808 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11809
c939f91b
PE
11810 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11811 clobbering (Bug#8298).
b9c7f648
PE
11812 * sysdep.c (sys_subshell): Likewise.
11813 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11814
6bd8c144
PE
11815 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11816 This should get cleaned up, so that child_setup has the
11817 same signature on all platforms.
11818
7710357c 11819 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11820 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11821
c59da222
CY
118222011-03-22 Chong Yidong <cyd@stupidchicken.com>
11823
11824 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11825 not to be necessary, and produces flickering.
11826
66b87493
GM
118272011-03-20 Glenn Morris <rgm@gnu.org>
11828
11829 * config.in: Remove file.
11830
45b6f6d5
JB
118312011-03-20 Juanma Barranquero <lekktu@gmail.com>
11832
11833 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11834 are now in src/globals.h.
11835 (syms_of_minibuf): Remove spurious & from previous change.
11836
cd394be1 118372011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11838
11839 * minibuf.c (completing-read-function): New variable.
11840 (completing-read-default): Rename from completing-read.
11841 (completing-read): Call completing-read-function.
11842
b14e3e21
CY
118432011-03-19 Juanma Barranquero <lekktu@gmail.com>
11844
11845 * xfaces.c (Fx_load_color_file):
11846 Read color file from absolute filename (bug#8250).
11847
f2b726e6
JB
118482011-03-19 Juanma Barranquero <lekktu@gmail.com>
11849
11850 * makefile.w32-in: Update dependencies.
11851
09f6ff02
EZ
118522011-03-17 Eli Zaretskii <eliz@gnu.org>
11853
11854 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11855
29a6015a
PE
118562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11857
a3a6c54e
PE
11858 Fix more problems found by GCC 4.5.2's static checks.
11859
b766f867
PE
11860 * process.c (make_serial_process_unwind, send_process_trap):
11861 (sigchld_handler): Now static.
11862
be02381c
PE
11863 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11864 That way, the code declares only the vars that it needs.
11865 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11866 * s/cygwin.h (PTY_ITERATION): Likewise.
11867 * s/darwin.h (PTY_ITERATION): Likewise.
11868 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11869
57048744
PE
11870 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11871 * process.c (allocate_pty): Don't declare stb unless it's needed.
11872
7914961c 11873 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11874 (CONSTANTLIM): Remove; unused.
11875 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11876 Define only if needed.
7914961c 11877
b3967b18
PE
11878 * unexelf.c (unexec): Name an expression,
11879 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11880 Use a different way to cause a compilation error if anyone uses
11881 n rather than nn, a way that does not involve shadowing.
73366a00 11882 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11883
29a6015a
PE
11884 * deps.mk (unexalpha.o): Remove; unused.
11885
43cfc33e 11886 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11887 * unexec.h: New file.
ce701a33
PE
11888 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11889 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11890 Depend on unexec.h.
11891 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11892 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11893 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11894 Change as necessary to match prototype in unexec.h.
ce701a33 11895
01f44d5a
PE
11896 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11897 shadowing.
4f63c6bb 11898 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11899
a6670b0b
PE
11900 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11901 Rename locals to avoid shadowing.
11902
cef2010d 11903 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11904 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11905
d4d7173a
PE
11906 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11907
f08b802a
PE
11908 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11909 warning when compiling print.c.
11910
3ddb0639
PE
11911 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11912 instead of using an uninitialized var.
5ad03b97 11913 (font_sort_entities): Mark var as initialized.
3ddb0639 11914
170a2692
PE
11915 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11916
e663c700
PE
11917 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11918 pointers to constants.
89bc529a 11919 (font_parse_fcname): Remove unused vars.
7b81e2d0 11920 (font_delete_unmatched): Now static.
ea838e10 11921 (font_get_spec): Remove; unused.
13a547c6
PE
11922 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11923 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11924 Rename or move locals to avoid shadowing.
e663c700 11925
2a80c887 11926 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11927 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11928
1384fa33 11929 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11930 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11931
8b2c52e9
PE
11932 * alloc.c (mark_backtrace): Move decl from here ...
11933 * lisp.h: ... to here, so that it can be checked.
11934
475545b5 11935 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11936 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11937 (lisp_indirect_variable): Name an expression,
11938 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11939 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11940
b1349114 11941 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11942 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11943 Use const pointer when appropriate.
b1349114 11944
a2928364
PE
11945 * lisp.h (get_system_name, get_operating_system_release):
11946 Move decls here, to check interfaces.
11947 * process.c (get_operating_system_release): Move decl to lisp.h.
11948 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11949 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11950 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11951 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11952 (Fformat_time_string, Fencode_time, Finsert_char):
11953 (Ftranslate_region_internal, Fformat):
11954 Rename or remove local vars to avoid shadowing.
9710023e 11955 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11956
a415e694
PE
11957 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11958 avoid shadowing.
11959
8ef4622d
PE
11960 * lisp.h (eassert): Check that the argument compiles, even if
11961 ENABLE_CHECKING is not defined.
11962
946f9a5b
PE
11963 * data.c (Findirect_variable): Name an expression, to avoid
11964 gcc -Wbad-function-cast warning.
112396d6 11965 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11966 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11967 (Fmake_variable_buffer_local, Fmake_local_variable):
11968 Mark variables as initialized.
52746918 11969 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11970
e5aab7e7 11971 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11972 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11973 Rename locals to avoid shadowing.
dff45157
PE
11974 (mark_stack): Move local variables into the #ifdef region where
11975 they're used.
7bc26fdb
PE
11976 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11977 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11978 needed otherwise.
11979 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11980 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11981 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11982
e5aab7e7
PE
11983 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11984 avoids undefined behavior in theory.
11985
4da60324
PE
11986 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11987
88043301
PE
11988 Use functions, not macros, for up- and down-casing (Bug#8254).
11989 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11990 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11991 to use the following functions instead of these macros.
11992 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11993 EMACS_INT, since callers assume the returned value fits in int.
11994 (upcase1): Likewise, for UPCASE_TABLE.
11995 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11996 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11997 the race-condition problem in the old DOWNCASE.
88043301 11998
19ed5445
PE
11999 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12000 Rename locals to avoid shadowing.
12001 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12002 (regex_compile, re_search_2, re_match_2_internal):
12003 Remove unused local vars.
952db0d7
PE
12004 (FREE_VAR): Rewrite so as not to use empty "else",
12005 which gcc can warn about.
da053e48 12006 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12007 (RETALLOC_IF): Define only if needed.
12008 (WORDCHAR_P): Likewise. This one is never needed, but is used
12009 only in a comment talking about a compiler bug, so put inside
12010 the #if 0 of that comment.
12011 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12012 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12013 Remove; unused.
19ed5445 12014
1f3561e4 12015 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12016 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12017 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12018
ded6f8f7
PE
12019 * search.c (simple_search): Remove unused var.
12020
dbd37a95
PE
12021 * dired.c (compile_pattern): Move decl from here ...
12022 * lisp.h: ... to here, so that it can be checked.
12023 (struct re_registers): New forward decl.
12024
7e47afad
PE
12025 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12026
85f24f61
PE
12027 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12028 All uses changed.
12029 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12030 Rename locals to avoid shadowing.
5671df8f 12031 (Fvertical_motion): Mark locals as initialized.
85f24f61 12032
181aa2be 12033 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12034 (casify_region): Mark local as initialized.
181aa2be 12035
930d429c
PE
12036 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12037
7082eac6
PE
12038 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12039 New macros, so that the caller can use some names other than
12040 gcpro1, gcpro2, etc.
12041 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12042 of the new macros.
12043 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12044 argument, for consistency with GCPRO2_VAR, etc: it is now the
12045 prefix of the variable, not the variable itself. All uses
12046 changed.
38b2c076
PE
12047 * dired.c (directory_files_internal, file_name_completion):
12048 Rename locals to avoid shadowing.
12049
15206ed9
PE
12050 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12051 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12052 dired.c's scmp function, had undefined behavior.
12053 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12054 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12055 * buffer.h: ... to here, because these macros use current_buffer,
12056 and the new implementation with inline functions needs to have
12057 current_buffer in scope now, rather than later when the macros
12058 are used.
12059 (downcase, upcase1): New static inline functions.
12060 (DOWNCASE, UPCASE1): Reimplement using these functions.
12061 This avoids undefined behavior in expressions like
12062 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12063 from race conditions in accessing the global variables
12064 case_temp1 and case_temp2.
12065 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12066 * lisp.h (case_temp1, case_temp2): Remove their decls.
12067 * character.h (ASCII_CHAR_P): Move from here ...
12068 * lisp.h: ... to here, so that the inline functions mentioned
12069 above can use them.
12070
4a6bea26
PE
12071 * dired.c (directory_files_internal_unwind): Now static.
12072
f14b7e14
PE
12073 * fileio.c (file_name_as_directory, directory_file_name):
12074 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12075 Now static.
2893f146
PE
12076 (file_name_as_directory): Use const pointers when appropriate.
12077 (Fexpand_file_name): Likewise. In particular, newdir might
12078 point at constant storage, so make it a const pointer.
fd4ead52 12079 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12080 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12081 signedness issues.
f839df0c
PE
12082 (Fset_file_times, Finsert_file_contents, auto_save_error):
12083 Rename locals to avoid shadowing.
f14b7e14 12084
5716756e 12085 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12086 (Ftry_completion, Fall_completions): Rename or remove locals
12087 to avoid shadowing.
5716756e 12088
b4c3046a
PE
12089 * marker.c (bytepos_to_charpos): Remove; unused.
12090
b45db522
PE
12091 * lisp.h (verify_bytepos, count_markers): New decls,
12092 so that gcc does not warn that these functions aren't declared.
12093
85876d07
PE
12094 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12095 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12096 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12097 (copy_text): Remove unused local var.
85876d07 12098
03d78a21 12099 * filelock.c (within_one_second): Now static.
b3dd38ab 12100 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12101
5df8f01b
PE
12102 * buffer.c (fix_overlays_before): Mark locals as initialized.
12103 (fix_start_end_in_overlays): Likewise. This function should be
12104 simplified by using pointers-to-pointers, but that's a different
12105 matter.
b1d876f1 12106 (switch_to_buffer_1): Now static.
8f54f30a
PE
12107 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12108 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12109
a70072c9 12110 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12111 Fix pointer signedness issue.
edced198
PE
12112 (sys_subshell): Mark local as volatile if checking for lint,
12113 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12114 (MAXPATHLEN): Define only if needed.
a70072c9 12115
a0977c44
PE
12116 * process.c (serial_open, serial_configure): Move decls from here ...
12117 * systty.h: ... to here, so that they can be checked.
12118
a884fdcc
PE
12119 * fns.c (get_random, seed_random): Move extern decls from here ...
12120 * lisp.h: ... to here, so that they can be checked.
12121
604efe86 12122 * sysdep.c (reset_io): Now static.
b8950c94 12123 (wait_for_termination_signal): Remove; unused.
604efe86 12124
38fc62d9
PE
12125 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12126 (copy_keymap_item, append_key, push_text_char_description):
12127 Now static.
1004a21a 12128 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12129 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12130 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12131 (describe_map_tree):
12132 Rename locals to avoid shadowing.
38fc62d9 12133
2f2650da
PE
12134 * keyboard.c: Declare functions static if they are not used elsewhere.
12135 (echo_char, echo_dash, cmd_error, top_level_2):
12136 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12137 (read_char, kbd_buffer_get_event, make_lispy_position):
12138 (make_lispy_event, make_lispy_movement, apply_modifiers):
12139 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12140 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12141 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12142 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12143 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12144
a053e86c 12145 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12146 (mark_kboards): Move decl here ...
12147 * alloc.c (mark_kboards): ... from here.
a053e86c 12148
4752793e
PE
12149 * lisp.h (force_auto_save_soon): New decl.
12150
74f10ca7 12151 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12152 (DEFINE_DUMMY_FUNCTION): New macro.
12153 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12154 Use it.
c03cd23f
PE
12155 (main): Add casts to avoid warnings
12156 if GCC considers string literals to be constants.
74f10ca7 12157
022e70d4
PE
12158 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12159
59d6fe83
PE
12160 * dbusbind.c: Pointer signedness fixes.
12161 (xd_signature, xd_append_arg, xd_initialize):
12162 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12163 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12164 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12165 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12166
78320123
PE
12167 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12168 if GCC considers string literals to be constants.
49cebcca 12169 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12170
35ac2a97
SM
121712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12172
fb103ca9
SM
12173 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12174 (print_preprocess, print_object): New macro to fix last change.
12175
35ac2a97
SM
12176 * print.c (print_preprocess): Don't forget font objects.
12177
62973b41
JB
121782011-03-16 Juanma Barranquero <lekktu@gmail.com>
12179
12180 * emacs.c (USAGE3): Doc fixes.
12181
0e48bb22
AS
121822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12183
12184 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12185 structure.
12186
7684e57b
JB
121872011-03-14 Juanma Barranquero <lekktu@gmail.com>
12188
12189 * lisp.h (VWindow_system, Qfile_name_history):
12190 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12191 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12192 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12193
12194 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12195 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12196
12197 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12198 * w32console.c (detect_input_pending, read_input_pending)
12199 (encode_terminal_code):
12200 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12201 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12202 (w32_system_caret_y, Qfile_name_history):
12203 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12204 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12205 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12206 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12207 * w32proc.c (Qlocal, report_file_error):
12208 * w32term.c (Vwindow_system, updating_frame):
12209 * w32uniscribe.c (initialized, uniscribe_font_driver):
12210 Remove unneeded extern declarations.
12211
2aa46d6c
CY
122122011-03-14 Chong Yidong <cyd@stupidchicken.com>
12213
c96bbc66 12214 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12215
cffc6f3b
CY
122162011-03-13 Chong Yidong <cyd@stupidchicken.com>
12217
12218 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12219 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12220 These macros can no longer be used for assignment.
12221
44f230aa
SM
12222 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12223 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12224 (record_buffer_markers, fetch_buffer_markers): New functions for
12225 recording and fetching special buffer markers.
12226 (set_buffer_internal_1, set_buffer_temp): Use them.
12227
12228 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12229
12230 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12231
12232 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12233 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12234
12235 * xdisp.c (hscroll_window_tree):
12236 (reconsider_clip_changes): Use PT instead of BUF_PT.
12237
d251f04b
EZ
122382011-03-13 Eli Zaretskii <eliz@gnu.org>
12239
12240 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12241 $(EMACS_ROOT)/lib/intprops.h.
12242
f0c77cd1
PE
122432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12244
3eca4629
PE
12245 Fix more problems found by GCC 4.5.2's static checks.
12246
7c86ee98
PE
12247 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12248 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12249 (xg_free_frame_widgets): Make it clear that a local variable is
12250 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12251 (gdk_window_get_screen): Make it clear that this macro is needed
12252 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12253 (int_gtk_range_get_value): New function, which avoids a diagnostic
12254 from gcc -Wbad-function-cast.
12255 (xg_set_toolkit_scroll_bar_thumb): Use it.
12256 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12257 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12258 (get_utf8_string, xg_get_file_with_chooser):
12259 Rename locals to avoid shadowing.
12260 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12261
41729b81
PE
12262 * xgselect.c (xg_select): Remove unused var.
12263
f0c77cd1
PE
12264 * image.c (four_corners_best): Mark locals as initialized.
12265 (gif_load): Initialize transparent_p to zero (Bug#8238).
12266 Mark another local as initialized.
ec6cf4c6 12267 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12268
ce0ad53d 12269 * image.c (clear_image_cache): Now static.
d5d5a617 12270 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12271 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12272 (x_edge_detection): Remove unnecessary cast that
12273 gcc -Wbad-function-cast diagnoses.
2037898d 12274 (gif_load): Fix pointer signedness.
6ae141d6
PE
12275 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12276 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12277
33383987 122782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12279
d32df629
PE
12280 Improve quality of tests for time stamp overflow.
12281 For example, without this patch (encode-time 0 0 0 1 1
12282 1152921504606846976) returns the obviously-bogus value (-948597
12283 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12284 reports time overflow. See
12285 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12286 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12287 * editfns.c: Include limits.h and intprops.h.
12288 (TIME_T_MIN, TIME_T_MAX): New macros.
12289 (time_overflow): Move earlier, to before first use.
12290 (hi_time, lo_time): New functions, for an accurate test for
12291 out-of-range times.
12292 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12293 (Fget_internal_run_time): Don't assume time_t fits in int.
12294 (make_time): Use list2 instead of Fcons twice.
12295 (Fdecode_time): More accurate test for out-of-range times.
12296 (check_tm_member): New function.
12297 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12298 (lisp_time_argument): Don't rely on undefined left-shift and
12299 right-shift behavior when checking for time stamp overflow.
8be6f318 12300
fe31d94c
PE
12301 * editfns.c (time_overflow): New function, refactoring common code.
12302 (Fformat_time_string, Fdecode_time, Fencode_time):
12303 (Fcurrent_time_string): Use it.
12304
8be6f318
PE
12305 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12306 * dired.c (make_time): Move to ...
12307 * editfns.c (make_time): ... here.
12308 * systime.h: Note the move.
12309
09d9db2c 123102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12311
126bc0dc
YM
12312 * fringe.c (update_window_fringes): Remove unused variables.
12313
c47cbdfd
YM
12314 * unexmacosx.c (copy_data_segment): Also copy __got section.
12315 (Bug#8223)
12316
7ac80be9
EZ
123172011-03-12 Eli Zaretskii <eliz@gnu.org>
12318
c96bbc66 12319 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12320 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12321 Constify `char *' arguments and their references according to
12322 prototypes in tparam.h.
12323
ecb0f94d 12324 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12325
7ac80be9
EZ
12326 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12327 Adapt all references accordingly.
12328
12329 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12330
ef1fd07e
TT
123312011-03-11 Tom Tromey <tromey@redhat.com>
12332
12333 * buffer.c (syms_of_buffer): Remove obsolete comment.
12334
7ef4b50c
EZ
123352011-03-11 Eli Zaretskii <eliz@gnu.org>
12336
12337 * termhooks.h (encode_terminal_code): Declare prototype.
12338
12339 * msdos.c (encode_terminal_code): Don't declare prototype.
12340
12341 * term.c (encode_terminal_code): Now external again, used by
12342 w32console.c and msdos.c.
12343
44f230aa
SM
12344 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12345 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12346
4b1ec863 123472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12348
1714f52b 12349 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12350
4b1ec863
PE
12351 * fringe.c (update_window_fringes): Mark locals as initialized
12352 (Bug#8227).
12353 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12354
524c7aa6
PE
12355 * alloc.c (mark_fringe_data): Move decl from here ...
12356 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12357 to check its interface.
12358 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12359
a5c0af81 12360 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12361 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12362 (fontset_font): Mark local as initialized.
a9a06e0b 12363 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12364
b4716021
PE
12365 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12366
811e9bac 12367 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12368 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12369 (x_own_selection, Fx_disown_selection_internal): Rename locals
12370 to avoid shadowing.
12371 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12372
7e3ab302
PE
12373 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12374 so that the caller can use some name other than gcpro1.
12375 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12376 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12377 (Fx_backspace_delete_keys_p):
12378 Use them to avoid shadowing, and rename vars to avoid shadowing.
12379 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12380 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12381 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12382 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12383 Remove unused locals.
7e3ab302
PE
12384 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12385 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12386 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12387 macros.
f78faa98 12388
e2b13473
PE
12389 * xterm.h (x_mouse_leave): New decl.
12390
77f23912
PE
12391 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12392 Remove unused functions.
cdf4ba58
PE
12393 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12394 (x_calc_absolute_position): Now static.
7411c686 12395 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12396 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12397 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12398 unless they are used.
38d0b34a
PE
12399 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12400 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12401 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12402 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12403 (x_error_catcher, x_connection_closed, x_error_handler):
12404 (x_error_quitter, xembed_send_message, x_iconify_frame):
12405 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12406 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12407 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12408
44f230aa
SM
12409 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12410 Rename or move locals to avoid shadowing.
6b463e58 12411 (tty_defined_color, merge_face_heights): Now static.
5967d051 12412 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12413 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12414 does not deduce is never used uninitialized.
73719eba
PE
12415 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12416 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12417
426994c3 12418 * terminal.c (store_terminal_param): Now static.
5489860b 12419
032f1620 12420 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12421 (set_frame_menubar): Remove unused local.
d4323972 12422 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12423 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12424 since they might point to immutable storage.
281585b0
PE
12425 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12426 since it's unused otherwise.
032f1620 12427
367c19e5 12428 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12429 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12430 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12431 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12432 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12433 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12434 does not deduce are never used uninitialized.
70739cbe 12435
07b48fa9
PE
12436 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12437
8868a238 12438 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12439 * window.c (window_loop, size_window):
12440 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12441
7e5cf297 12442 * window.c (display_buffer): Now static.
d6550a9f
PE
12443 (size_window): Mark variables that gcc -Wuninitialized
12444 does not deduce are never used uninitialized.
a586633d
PE
12445 * window.h (check_all_windows): New decl, to forestall
12446 gcc -Wmissing-prototypes diagnostic.
5b555da1 12447 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12448
f6095868
PE
12449 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12450 shadowing.
12451 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12452 Include <limits.h>.
12453 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12454 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12455 (load_charset_map): Mark variables that gcc -Wuninitialized
12456 does not deduce are never used uninitialized.
53df7c11 12457 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12458
f38b440c
PE
12459 * coding.c (coding_set_source, coding_set_destination):
12460 Use "else { /* comment */ }" rather than "else /* comment */;"
12461 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12462 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12463 a block, when the outer 'i' will do.
12464 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12465 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12466 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12467 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12468 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12469 Rename locals to avoid shadowing.
12470 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12471 * coding.c (emacs_mule_char, encode_invocation_designation):
12472 Now static, since they're not used elsewhere.
413bb2db 12473 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12474 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12475 (decode_coding_emacs_mule): Mark variables that gcc
12476 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12477 (detect_coding_iso_2022): Initialize a local variable that might
12478 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12479 this initialization is needed. (Bug#8211)
5f58e762
PE
12480 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12481 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12482 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12483 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12484 Remove unused macros.
f38b440c 12485
232b38b9 12486 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12487 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12488 * character.c (string_count_byte8): Likewise.
232b38b9 12489
fb90da1b
PE
12490 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12491 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12492
fb93dbc2
PE
12493 * chartab.c (copy_sub_char_table): Now static, since it's not used
12494 elsewhere.
5c156ace
PE
12495 (sub_char_table_ref_and_range, char_table_ref_and_range):
12496 Rename locals to avoid shadowing.
bbcd0949 12497 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12498
7d3b3862 12499 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12500 (BIDI_BOB): Remove unused macro.
7d3b3862 12501
6be7d3da
PE
12502 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12503 deduce are never used uninitialized.
c2ed9c8b 12504 * term.c (encode_terminal_code): Likewise.
6be7d3da 12505
75f8807f 12506 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12507
50938595
PE
12508 * tparam.h: New file.
12509 * term.c, tparam.h: Include it.
12510 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12511 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12512 Move these decls to tparam.h, and make them agree with what
12513 is actually in tparam.c. The previous trick of using incompatible
12514 decls in different modules does not conform to the C standard.
12515 All callers of tparam changed to use tparam's actual API.
12516 * tparam.c (tparam1, tparam, tgoto):
12517 Use const pointers where appropriate.
12518
fbceeba2
PE
12519 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12520 * cm.h (struct cm): Likewise.
12521 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12522 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12523 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12524 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12525 (turn_on_face, init_tty): Likewise.
12526 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12527
7f3f1250
PE
12528 * term.c (term_mouse_position): Rename local to avoid shadowing.
12529
e6ca6543
PE
12530 * alloc.c (mark_ttys): Move decl from here ...
12531 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12532
c40f8d15
AS
125332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12534
12535 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12536
cfe0661d
JB
125372011-03-09 Juanma Barranquero <lekktu@gmail.com>
12538
12539 * search.c (compile_pattern_1): Remove argument regp, unused since
12540 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12541 (compile_pattern): Don't pass it.
12542
0afb4571
J
125432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12544
12545 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12546 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12547 for ! HAVE_GTK3.
12548 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12549
12550 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12551
12552 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12553 gdk_window_get_screen, gdk_window_get_geometry,
12554 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12555 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12556 (xg_get_pixbuf_from_pixmap): New function.
12557 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12558 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12559 Call xg_get_pixbuf_from_pixmap instead of
12560 gdk_pixbuf_get_from_drawable.
12561 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12562 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12563 (xg_check_special_colors): Use GtkStyleContext and its functions
12564 for HAVE_GTK3.
12565 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12566 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12567 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12568 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12569 Call gtk_widget_get_preferred_size.
0afb4571
J
12570 (xg_frame_resized): gdk_window_get_geometry only takes 5
12571 parameters.
44f230aa
SM
12572 (xg_win_to_widget, xg_event_is_for_menubar):
12573 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12574 (xg_set_widget_bg): New function.
12575 (delete_cb): New function.
895009e1 12576 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12577 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12578 (xg_set_background_color): Call xg_set_widget_bg.
12579 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12580 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12581 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12582 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12583 if ! HAVE_GTK3.
12584 (update_frame_tool_bar): Call gtk_widget_hide.
12585 (xg_initialize): Use GDK_KEY_g.
12586
12587 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12588 if ! HAVE_GTK3
12589 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12590
12591 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12592 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12593 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12594
1c2cc4ef
JB
125952011-03-08 Juanma Barranquero <lekktu@gmail.com>
12596
12597 * w32xfns.c (select_palette): Check success of RealizePalette against
12598 GDI_ERROR, not zero.
12599
33383987 12600See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12601
12602;; Local Variables:
12603;; coding: utf-8
aac0c6e3
MR
12604;; End:
12605
2f097256 12606 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12607
12608 This file is part of GNU Emacs.
12609
12610 GNU Emacs is free software: you can redistribute it and/or modify
12611 it under the terms of the GNU General Public License as published by
12612 the Free Software Foundation, either version 3 of the License, or
12613 (at your option) any later version.
12614
12615 GNU Emacs is distributed in the hope that it will be useful,
12616 but WITHOUT ANY WARRANTY; without even the implied warranty of
12617 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12618 GNU General Public License for more details.
12619
12620 You should have received a copy of the GNU General Public License
12621 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.