* leim/Makefile.in (TIT_BIG5): Renamed from TIT-BIG5.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2d3c217e 12011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2
7b7f97e8 3 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4 * buffer.c (Qclone_number): Remove for now, as it's unused.
5 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6 (record_buffer): Remove unused local.
7 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8 (set_frame_buffer_list): Remove; unused.
9 * frame.h (other_visible_frames): Remove decl.
10 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
13 if HAVE_GPM.
14 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
15 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
16 Define only if HAVE_GPM.
17 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
18 (update_hints_inhibit): Remove; never set. All uses removed.
19 * widgetprv.h (emacsFrameClassRec): Remove decl.
20 * window.c (delete_deletable_window): Now returns void, since it
21 wasn't returning anything.
22 (compare_window_configurations): Remove unused locals.
23 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
24 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
25 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
26 the same widths as pointers. This follows up on the 2011-05-06 patch.
27 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
28 * xterm.h: Likewise.
29 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
30
1384b89e
JB
312011-06-12 Juanma Barranquero <lekktu@gmail.com>
32
33 * makefile.w32-in: Update dependencies.
34 (LISP_H): Add lib/intprops.h.
35
1100a63c
CY
362011-06-11 Chong Yidong <cyd@stupidchicken.com>
37
38 * image.c (gif_load): Add animation frame delay to the metadata.
39 (syms_of_image): Use DEFSYM. New symbol `delay'.
40
6198ccd0
MR
412011-06-11 Martin Rudalics <rudalics@gmx.at>
42
43 * window.c (delete_deletable_window): Re-add.
44 (Fset_window_configuration): Rewrite to handle dead buffers and
45 consequently deletable windows.
46 (window_tree, Fwindow_tree): Remove. Supply functionality in
47 window.el.
48 (compare_window_configurations): Simplify code.
49
b6e3633c
AS
502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
51
1ab0dee5
AS
52 * image.c (imagemagick_load_image): Fix type mismatch.
53 (Fimagemagick_types): Likewise.
54
b6e3633c
AS
55 * window.h (replace_buffer_in_windows): Declare.
56
9397e56f
MR
572011-06-11 Martin Rudalics <rudalics@gmx.at>
58
59 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
60 Qclone_number. Remove external declaration of Qdelete_window.
61 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
62 code.
63 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
64 Qbuffer_list_update_hook if allowed.
65 (Fother_buffer): Rewrite doc-string. Major rewrite for new
66 buffer list implementation.
67 (other_buffer_safely): New function.
68 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
69 calls to replace_buffer_in_windows and
70 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
71 if allowed.
72 (record_buffer): Inhibit quitting and rewrite using quittable
73 functions. Run Qbuffer_list_update_hook if allowed.
74 (Frecord_buffer, Funrecord_buffer): New functions.
75 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
76 switch-to-buffer to window.el.
77 (bury-buffer): Move to window.el.
78 (Vbuffer_list_update_hook): New variable.
79
80 * lisp.h (other_buffer_safely): Add prototype in buffer.c
81 section.
82
83 * window.h (resize_frame_windows): Move up in code.
84 (Fwindow_frame): Remove EXFUN.
85 (replace_buffer_in_all_windows): Remove prototype.
86 (replace_buffer_in_windows_safely): Add prototype.
87
88 * window.c: Declare Qdelete_window static again. Move down
89 declaration of select_count.
90 (Fnext_window, Fprevious_window): Rewrite doc-strings.
91 (Fother_window): Move to window.el.
92 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
93 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
94 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
95 window.el.
96 (replace_buffer_in_windows): Implement by calling
97 Qreplace_buffer_in_windows.
98 (replace_buffer_in_all_windows): Remove with some functionality
99 moved into replace_buffer_in_windows_safely.
100 (replace_buffer_in_windows_safely): New function.
101 (select_window_norecord, select_frame_norecord): Move in front
102 of run_window_configuration_change_hook. Remove now obsolete
103 declarations.
104 (Fset_window_buffer): Rewrite doc-string. Call
105 Qrecord_window_buffer.
106 (keys_of_window): Move binding for other-window to window.el.
107
b50691aa
CY
1082011-06-11 Chong Yidong <cyd@stupidchicken.com>
109
110 * dispextern.h (struct image): Replace data member, whose int_val
111 and ptr_val fields were not used by anything, with a single
112 lisp_val object.
113
114 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
115 (gif_clear_image, gif_load, imagemagick_load_image)
116 (gs_clear_image, gs_load): Callers changed.
117
3f754b86
PE
1182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
119
cca69397
PE
120 * buffer.h: Include <time.h>, for time_t.
121 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
122
109e28d0
PE
123 Fix minor problems found by static checking.
124
60737f02
PE
125 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
126
4b66faf3
PE
127 Make identifiers static if they are not used in other modules.
128 * data.c (Qcompiled_function, Qframe, Qvector):
129 * image.c (QimageMagick, Qsvg):
130 * minibuf.c (Qmetadata):
131 * window.c (resize_window_check, resize_root_window): Now static.
132 * window.h (resize_window_check, resize_root_window): Remove decls.
133
109e28d0
PE
134 * window.c (window_deletion_count, delete_deletable_window):
135 Remove; unused.
46a4ce9e
PE
136 (window_body_lines): Now static.
137 (Fdelete_other_windows_internal): Mark vars as initialized.
138 Make sure 'resize_failed' is initialized.
139 (run_window_configuration_change_hook): Rename local to avoid shadowing.
140 (resize_window_apply): Remove unused local.
141 * window.h (delete_deletable_window): Remove decl.
142
109e28d0 143 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
144 (imagemagick_load_image): Fix pointer signedness problem by changing
145 last arg from unsigned char * to char *. All uses changed.
146 Also, fix a local for similar reasons.
147 Remove unused locals. Remove locals to avoid shadowing.
148 (fn_rsvg_handle_free): Remove; unused.
149 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 150 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 151
3f754b86
PE
152 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
153
2547adb1
CY
1542011-06-10 Chong Yidong <cyd@stupidchicken.com>
155
156 * image.c (gif_load): Fix omitted cast error introduced by
157 2011-06-06 change.
158
2c8e37d4
MR
1592011-06-10 Martin Rudalics <rudalics@gmx.at>
160
161 * window.h (resize_proportionally, orig_total_lines)
162 (orig_top_line): Remove from window structure.
163 (set_window_height, set_window_width, change_window_heights)
164 (Fdelete_window): Remove prototypes.
165 (resize_frame_windows): Remove duplicate declaration.
166
440a42e3
EZ
1672011-06-10 Eli Zaretskii <eliz@gnu.org>
168
169 * window.h (resize_frame_windows, resize_window_check)
170 (delete_deletable_window, resize_root_window)
171 (resize_frame_windows): Declare prototypes.
172
173 * window.c (resize_window_apply): Make definition be "static" to
174 match the prototype.
175
562dd5e9
MR
1762011-06-10 Martin Rudalics <rudalics@gmx.at>
177
178 * window.c: Remove declarations of Qwindow_size_fixed,
179 window_min_size_1, window_min_size_2, window_min_size,
180 size_window, window_fixed_size_p, enlarge_window, delete_window.
181 Remove static from declaration of Qdelete_window, it's
182 temporarily needed by Fbury_buffer.
183 (replace_window): Don't assign orig_top_line and
184 orig_total_lines.
185 (Fdelete_window, delete_window): Remove. Window deletion is
186 handled by window.el.
187 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
188 Fdelete_window calls with calls to Qdelete_window.
189 (Fdelete_other_windows): Remove. Deleting other windows is
190 handled by window.el.
191 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
192 handled in window.el.
193 (window_min_size_2, window_min_size_1, window_min_size): Remove.
194 Window minimum sizes are handled in window.el.
195 (shrink_windows, size_window, set_window_height)
196 (set_window_width, change_window_heights, window_height)
197 (window_width, CURBEG, CURSIZE, enlarge_window)
198 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
199 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
200 handled in window.el.
201 (make_dummy_parent): Rename to make_parent_window and give it a
202 second argument horflag.
203 (make_window): Don't set resize_proportionally any more.
204 (Fsplit_window): Remove. Windows are split in window.el.
205 (save_restore_action, save_restore_orig_size)
206 (shrink_window_lowest_first, save_restore_orig_size): Remove.
207 Resize mini windows in window.el.
208 (grow_mini_window, shrink_mini_window): Implement by calling
209 Qresize_root_window_vertically, resize_window_check and
210 resize_window_apply.
211 (saved_window, Fset_window_configuration, save_window_save): Do
212 not handle orig_top_line, orig_total_lines, and
213 resize_proportionally.
214 (window_min_height, window_min_width): Move to window.el.
215 (keys_of_window): Move bindings for delete-other-windows,
216 split-window, delete-window and enlarge-window to window.el.
217
218 * buffer.c: Temporarily extern Qdelete_window.
219 (Fbury_buffer): Temporarily call Qdelete_window instead of
220 Fdelete_window (Fbury_buffer will move to window.el soon).
221
222 * frame.c (set_menu_bar_lines_1): Remove code handling
223 orig_top_line and orig_total_lines.
224
225 * dispnew.c (adjust_frame_glyphs_initially): Don't use
226 set_window_height but set heights directly.
227 (change_frame_size_1): Use resize_frame_windows.
228
229 * xdisp.c (init_xdisp): Don't use set_window_height but set
230 heights directly.
231
232 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
233 resize_frame_windows instead of change_window_heights and run
234 run_window_configuration_change_hook.
235
236 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
237 instead of change_window_heights and run
238 run_window_configuration_change_hook.
239
1a13852e
MR
2402011-06-09 Martin Rudalics <rudalics@gmx.at>
241
242 * window.c (replace_window): Rename second argument REPLACEMENT to
243 NEW. New third argument SETFLAG. Rewrite.
244 (delete_window, make_dummy_parent): Call replace_window with
245 third argument 1.
246 (window_list_1): Move down in code.
247 (run_window_configuration_change_hook): Move set_buffer part
248 before select_frame_norecord part in order to unwind correctly.
249 Rename count1 to count.
250 (recombine_windows, delete_deletable_window, resize_root_window)
251 (Fdelete_other_windows_internal)
252 (Frun_window_configuration_change_hook, make_parent_window)
253 (resize_window_check, resize_window_apply, Fresize_window_apply)
254 (resize_frame_windows, Fsplit_window_internal)
255 (Fdelete_window_internal, Fresize_mini_window_internal): New
256 functions.
257 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
258
f3d1777e
MR
2592011-06-08 Martin Rudalics <rudalics@gmx.at>
260
496e208e
MR
261 * window.h (window): Add some new members to window structure -
262 normal_lines, normal_cols, new_total, new_normal, clone_number,
263 splits, nest, prev_buffers, next_buffers.
264 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 265 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 266
f3d1777e
MR
267 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
268 Remove.
496e208e
MR
269 (make_dummy_parent): Set new members of windows structure.
270 (make_window): Move down in code. Handle new members of window
271 structure.
272 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
273 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
274 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
275 (Fset_window_prev_buffers, Fwindow_next_buffers)
276 (Fset_window_next_buffers, Fset_window_clone_number): New
277 functions.
278 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
279 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
280 Doc-string fixes.
281 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
282 Argument WINDOW can be now internal window too.
283 (Fwindow_use_time): Move up in code.
284 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
285 Rewrite doc-string.
286 (Fset_window_configuration, saved_window)
287 (Fcurrent_window_configuration, save_window_save): Handle new
288 members of window structure.
b9e809c2
MR
289 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
290 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
291 (syms_of_window): New Lisp objects Qrecord_window_buffer,
292 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
293 Qget_mru_window, Qresize_root_window,
294 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
295 Qauto_buffer_name; staticpro them.
f3d1777e 296
abde8f8c
MR
2972011-06-07 Martin Rudalics <rudalics@gmx.at>
298
299 * window.c (Fwindow_total_size, Fwindow_left_column)
300 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
301 (Fwindow_list_1): New functions.
302 (window_box_text_cols): Replace with window_body_cols.
303 (Fwindow_width, Fscroll_left, Fscroll_right): Use
304 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
305 (delete_window, Fset_window_configuration): Call
306 delete_all_subwindows with window as argument.
307 (delete_all_subwindows): Take a window as argument and not a
308 structure. Rewrite.
190b47e6
MR
309 (window_loop): Remove handling of GET_LRU_WINDOW and
310 GET_LARGEST_WINDOW.
311 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
312
313 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
314 window_box_text_cols. delete_all_subwindows now takes a
315 Lisp_Object as argument.
abde8f8c
MR
316
317 * indent.c (compute_motion, Fcompute_motion): Use
318 window_body_cols instead of window_box_text_cols.
319
fa8a67e6
MR
320 * frame.c (delete_frame): Call delete_all_subwindows with root
321 window as argument.
322
a54e3482
DC
3232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
324
325 * fns.c (Fputhash): Document return value.
326
60002bf5
CY
3272011-06-06 Chong Yidong <cyd@stupidchicken.com>
328
329 * image.c (gif_load): Implement gif89a spec "no disposal" method.
330
0c671da6 3312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 332
b862a52a 333 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 334
be44ca6c
PE
335 Check for overflow when converting integer to cons and back.
336 * charset.c (Fdefine_charset_internal, Fdecode_char):
337 Use cons_to_unsigned to catch overflow.
338 (Fencode_char): Use INTEGER_TO_CONS.
339 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
340 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
341 * data.c (long_to_cons, cons_to_long): Remove.
342 (cons_to_unsigned, cons_to_signed): New functions.
343 These signal an error for invalid or out-of-range values.
344 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
345 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
346 * font.c (Ffont_variation_glyphs):
347 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
348 * lisp.h: Include <intprops.h>.
349 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
350 (cons_to_signed, cons_to_unsigned): New decls.
351 (long_to_cons, cons_to_long): Remove decls.
352 * undo.c (record_first_change): Use INTEGER_TO_CONS.
353 (Fprimitive_undo): Use CONS_TO_INTEGER.
354 * xfns.c (Fx_window_property): Likewise.
355 * xselect.c: Include <limits.h>.
356 (x_own_selection, selection_data_to_lisp_data):
357 Use INTEGER_TO_CONS.
358 (x_handle_selection_request, x_handle_selection_clear)
359 (x_get_foreign_selection, Fx_disown_selection_internal)
360 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
361 (lisp_data_to_selection_data): Use cons_to_unsigned.
362 (x_fill_property_data): Use cons_to_signed.
363 Report values out of range.
364
d1f3d2af
PE
365 Check for buffer and string overflow more precisely.
366 * buffer.h (BUF_BYTES_MAX): New macro.
367 * lisp.h (STRING_BYTES_MAX): New macro.
368 * alloc.c (Fmake_string):
369 * character.c (string_escape_byte8):
370 * coding.c (coding_alloc_by_realloc):
371 * doprnt.c (doprnt):
372 * editfns.c (Fformat):
373 * eval.c (verror):
374 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
375 since they may not be the same number.
376 * editfns.c (Finsert_char):
377 * fileio.c (Finsert_file_contents):
378 Likewise for BUF_BYTES_MAX.
379
dd52fcea
PE
380 * image.c: Use ptrdiff_t, not int, for sizes.
381 (slurp_file): Switch from int to ptrdiff_t.
382 All uses changed.
383 (slurp_file): Check that file size fits in both size_t (for
384 malloc) and ptrdiff_t (for sanity and safety).
385
7f9bbdbb
PE
386 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
387 if b->modtime has its maximal value.
388
dfe18f82
PE
389 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
390
84acfcf0
PE
391 Don't assume time_t can fit into int.
392 * buffer.h (struct buffer.modtime): Now time_t, not int.
393 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
394 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
395
ccd9a01a
PE
396 Minor fixes for signed vs unsigned integers.
397 * character.h (MAYBE_UNIFY_CHAR):
398 * charset.c (maybe_unify_char):
399 * keyboard.c (read_char, reorder_modifiers):
400 XINT -> XFASTINT, since the integer must be nonnegative.
401 * ftfont.c (ftfont_spec_pattern):
402 * keymap.c (access_keymap, silly_event_symbol_error):
403 XUINT -> XFASTINT, since the integer must be nonnegative.
404 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
405 since it makes no difference and we prefer signed.
406 * keyboard.c (record_char): Use XUINT when all the neighbors do.
407 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
408 nonnegative.
409
d6d100dd
SM
4102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
411
412 * window.h (Fwindow_frame): Declare.
413
2b6148e4
PE
4142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
415
416 * alloc.c: Simplify handling of large-request failures (Bug#8800).
417 (SPARE_MEMORY): Always define.
418 (LARGE_REQUEST): Remove.
419 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
420
f230ecc9
MR
4212011-06-06 Martin Rudalics <rudalics@gmx.at>
422
727e958e
MR
423 * lisp.h: Move EXFUNS for Fframe_root_window,
424 Fframe_first_window and Fset_frame_selected_window to window.h.
425
426 * window.h: Move EXFUNS for Fframe_root_window,
427 Fframe_first_window and Fset_frame_selected_window here from
428 lisp.h.
429
430 * frame.c (Fwindow_frame, Fframe_first_window)
431 (Fframe_root_window, Fframe_selected_window)
432 (Fset_frame_selected_window): Move to window.c.
433 (Factive_minibuffer_window): Move to minibuf.c.
434 (Fother_visible_frames_p): New function.
435
436 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
437
f230ecc9
MR
438 * window.c (decode_window, decode_any_window): Move up in code.
439 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
440 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
441 (Fwindow_buffer): Move up and rewrite doc-string.
442 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
443 (Fwindow_prev): New functions.
727e958e
MR
444 (Fwindow_frame): Move here from frame.c. Accept any window as
445 argument.
446 (Fframe_root_window, Fframe_first_window)
447 (Fframe_selected_window): Move here from frame.c. Accept frame
448 or arbitrary window as argument. Update doc-strings.
449 (Fminibuffer_window): Move up in code.
450 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
451 (Fset_frame_selected_window): Move here from frame.c.
452 Marginal rewrite.
727e958e
MR
453 (Fselected_window, select_window, Fselect_window): Move up in
454 code. Minor doc-string fixes.
f230ecc9 455
4d09bcf6
PE
4562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
457
458 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
459 Do not assume that spare memory exists; that assumption is valid
460 only if SYSTEM_MALLOC.
461 (LARGE_REQUEST): New macro, so that the issue of large requests
462 is separated from the issue of spare memory.
463
810928a2
AS
4642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
465
172418ad
AS
466 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
467 format. (Bug#8806)
468
43f862f7
AS
469 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
470
810928a2
AS
471 * xfns.c (x_set_scroll_bar_default_width): Move declarations
472 before statements.
473
a059fe24
JD
4742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
475
476 * gtkutil.c (xg_get_default_scrollbar_width): New function.
477
478 * gtkutil.h: Declare xg_get_default_scrollbar_width.
479
480 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
481 min width by calling x_set_scroll_bar_default_width (Bug#8505).
482
989bf368
JB
4832011-06-05 Juanma Barranquero <lekktu@gmail.com>
484
485 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
486
4b80f674
CY
4872011-06-04 Chong Yidong <cyd@stupidchicken.com>
488
489 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
490 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
491 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
492 New error handlers.
4b80f674
CY
493 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
494 Obey Vx_select_enable_clipboard_manager. Catch errors in
495 x_clipboard_manager_save (Bug#8779).
496 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 497 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 498
99a33b77 4992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
500
501 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
502
99a33b77 5032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
504
505 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
506 in the current matrix if keep_current_p is non-zero.
507
8264569d
EZ
5082011-06-04 Eli Zaretskii <eliz@gnu.org>
509
510 * bidi.c (bidi_level_of_next_char): Fix last change.
511
57f97249
EZ
5122011-06-03 Eli Zaretskii <eliz@gnu.org>
513
fec2107c 514 Support bidi reordering of text covered by display properties.
57f97249 515
fec2107c
EZ
516 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
517 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
518 (bidi_cache_search, bidi_cache_iterator_state)
519 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
520 (bidi_level_of_next_char, bidi_move_to_visually_next):
521 Support character positions inside a run of characters covered by a
fec2107c
EZ
522 display string.
523 (bidi_paragraph_init, bidi_resolve_explicit_1)
524 (bidi_level_of_next_char): Call bidi_fetch_char and
525 bidi_fetch_char_advance instead of FETCH_CHAR and
526 FETCH_CHAR_ADVANCE.
527 (bidi_init_it): Initialize new members.
528 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
529 definitions.
530 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
531 instead of using explicit *_CHAR codes.
d6d100dd
SM
532 (bidi_resolve_explicit, bidi_resolve_weak):
533 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
534 bidirectional text is supported only in multibyte buffers.
535 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
536 it to initialize the frame_window_p member of struct bidi_it.
537 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
538 (bidi_resolve_explicit, bidi_resolve_weak)
539 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
540 bidi_it->nchars is non-positive.
541 (bidi_level_of_next_char): Don't try to lookup the cache for the
542 next/previous character if nothing is cached there yet, or if we
543 were just reseat()'ed to a new position.
c40e2fb2 544
0e14fe90
EZ
545 * xdisp.c (set_cursor_from_row): Set start and stop points
546 according to the row's direction when priming the loop that looks
547 for the glyph on which to display cursor.
548 (single_display_spec_intangible_p): Function deleted.
549 (display_prop_intangible_p): Reimplement to call
550 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
551 Accept 3 additional arguments needed by handle_display_spec.
552 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
553 values: lists, `(when COND...)' forms, etc.
554 (single_display_spec_string_p): Support property values that are
555 lists with the argument STRING its top-level element.
556 (display_prop_string_p): Fix the condition for processing a
557 property that is a list to be consistent with handle_display_spec.
fec2107c 558 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
559 last portion of handle_display_prop.
560 (compute_display_string_pos): Accept additional argument
561 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
562 value of a `display' property is a "replacing spec".
563 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
564 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
565 the display property, but just return a value indicating whether
566 the display property will replace the characters it covers.
567 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
568 frame_window_p members of struct bidi_it.
d6d100dd
SM
569 (compute_display_string_pos, compute_display_string_end):
570 New functions.
fec2107c
EZ
571 (push_it): Accept second argument POSITION, where pop_it should
572 jump to continue iteration.
573 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 574
fec2107c
EZ
575 * keyboard.c (adjust_point_for_property): Adjust the call to
576 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
577
578 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
579 (bidi_init_it): Update prototypes.
580 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
581 (compute_display_string_pos, compute_display_string_end):
582 Declare prototypes.
fec2107c
EZ
583 (struct bidi_it): New members nchars and disp_pos. ch_len is now
584 EMACS_INT.
fc6f18ce 585
40087514 5862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 587
57f53182
PE
588 Malloc failure behavior now depends on size of allocation.
589 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
590 * lisp.h: Change signatures accordingly.
591 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
592 All callers changed. (Bug#8762)
593
594 * gnutls.c: Use Emacs's memory allocators.
595 Without this change, the gnutls library would invoke malloc etc.
596 directly, which causes problems on non-SYNC_INPUT hosts, and which
597 runs afoul of improving memory_full behavior. (Bug#8761)
598 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
599 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
600 xfree instead of the default malloc, realloc, free.
601 (Fgnutls_boot): No need to check for memory allocation failure,
602 since xmalloc does that for us.
603
ac32cd99 604 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
605 * category.c (hash_get_category_set):
606 * ccl.c (ccl_driver):
607 * charset.c (Fdefine_charset_internal):
608 * charset.h (struct charset.hash_index):
609 * composite.c (get_composition_id, gstring_lookup_cache)
610 (composition_gstring_put_cache):
611 * composite.h (struct composition.hash_index):
612 * dispextern.h (struct image.hash):
613 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
614 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
615 (hashfn_equal, hashfn_user_defined, make_hash_table)
616 (maybe_resize_hash_table, hash_lookup, hash_put)
617 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
618 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
619 (Fsxhash, Fgethash, Fputhash, Fmaphash):
620 * image.c (make_image, search_image_cache, lookup_image)
621 (xpm_put_color_table_h):
622 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 623 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
624 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
625 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
626 * alloc.c (allocate_vectorlike):
627 Check for overflow in vector size calculations.
628 * ccl.c (ccl_driver):
629 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
630 * fns.c, image.c: Remove unnecessary static decls that would otherwise
631 need to be updated by these changes.
40087514
PE
632 * fns.c (make_hash_table, maybe_resize_hash_table):
633 Check for integer overflow with large hash tables.
0de4bb68
PE
634 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
635 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
636 (SXHASH_REDUCE): New macro.
637 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
638 Use it instead of discarding useful hash info with large hash values.
639 (sxhash_float): New function.
640 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
641 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
642 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
643 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
644 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
645 Adjust signatures to match updated version of code.
646 (consing_since_gc): Now EMACS_INT, since a single hash table can
647 use more than INT_MAX bytes.
648
698d32e2
DN
6492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
650
651 Make it possible to build with GCC-4.6+ -O2 -flto.
652
653 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
654
fd6fa53f
SM
6552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
656
657 * minibuf.c (get_minibuffer, read_minibuf_unwind):
658 Call minibuffer-inactive-mode.
659
864db017
JB
6602011-05-31 Juanma Barranquero <lekktu@gmail.com>
661
662 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
663 Update dependencies.
664
2ad0baf4
DN
6652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
666
667 * data.c (init_data): Remove code for UTS, this system is not
668 supported anymore.
669
4fcc2638
DN
6702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
671
672 Don't force ./temacs to start in terminal mode.
673
674 * frame.c (make_initial_frame): Initialize faces in all cases, not
675 only when CANNOT_DUMP is defined.
676 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
677
c56e0fd5
DN
6782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
679
680 * dispnew.c (add_window_display_history): Use const for the string
681 pointer. Remove declaration, not needed.
682
333d54da 6832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 684
55d4c1b2 685 Use 'inline', not 'INLINE'.
333d54da 686 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
687 * alloc.c, fontset.c (INLINE): Remove.
688 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
689 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
690 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
691 * gmalloc.c (register_heapinfo): Use inline unconditionally.
692 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
693
738db178
DN
6942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
695
696 Make it possible to run ./temacs.
697
698 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
699 syms_of_callproc does the same thing. Remove test for
700 "initialized", do it in the caller.
701 * emacs.c (main): Avoid calling set_initial_environment when dumping.
702
620c53a6
SM
7032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
704
705 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
706 (read_minibuf): Use get_minibuffer.
707 (syms_of_minibuf): Use DEFSYM.
708 (Qmetadata): New var.
709 * data.c (Qbuffer): Don't make it static.
710 (syms_of_data): Use DEFSYM.
711
e003a292
PE
7122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
713
714 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
715 (CCL_CODE_MIN): New macro.
716
ed008a6d
PE
7172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
718
3687c2ef
PE
719 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
720
ed008a6d
PE
721 * eval.c (Qdebug): Now static.
722 * lisp.h (Qdebug): Remove decl. This reverts a part of the
723 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
724 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
725
d66c4c7c
CY
7262011-05-29 Chong Yidong <cyd@stupidchicken.com>
727
728 * image.c: Various fixes to ImageMagick code comments.
729 (Fimagemagick_types): Doc fix.
730
5fbc2025
PE
7312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
732
0196f88a
PE
733 Minor fixes prompted by GCC 4.6.0 warnings.
734
735 * xselect.c (converted_selections, conversion_fail_tag): Now static.
736
5fbc2025
PE
737 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
738 (x_clipboard_manager_save_all): Move extern decl to ...
739 * xterm.h: ... here, so that it can be checked for consistency.
740
1dd3c2d9
CY
7412011-05-29 Chong Yidong <cyd@stupidchicken.com>
742
743 * xselect.c (x_clipboard_manager_save_frame)
744 (x_clipboard_manager_save_all): New functions.
745 (Fx_clipboard_manager_save): Lisp function deleted.
746
747 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
748 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
749
750 * xterm.h: Update prototype.
751
5ba6571d
WX
7522011-05-28 William Xu <william.xwl@gmail.com>
753
754 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
755 exiting (Bug#8239).
756
3eaff834
JM
7572011-05-28 Jim Meyering <meyering@redhat.com>
758
e1900994 759 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
760 * fns.c (to_uchar): Define.
761 (crypto_hash_function): Use it to convert some newly-signed
762 variables to unsigned, to avoid sign-extension bugs. For example,
763 without this change, (md5 "truc") would evaluate to
764 45723a2aff78ff4fff7fff1114760e62 rather than the expected
765 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 766 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 767
0f6990a7
PE
7682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
769
770 Integer overflow fixes.
c8a9ca5a 771
08686060
PE
772 * dbusbind.c: Serial number integer overflow fixes.
773 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
774 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
775 to hold a serial number that is too large for a fixnum.
776 (Fdbus_method_return_internal, Fdbus_method_error_internal):
777 Check for serial numbers out of range. Decode any serial number
59568bf0 778 that was so large that it became a float. (Bug#8722)
08686060 779
2d1fc3c7
PE
780 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
781 (Fdbus_call_method, Fdbus_call_method_asynchronously):
782 Use XFASTINT rather than XUINT when numbers are nonnegative.
783 (xd_append_arg, Fdbus_method_return_internal):
784 (Fdbus_method_error_internal): Likewise. Also, for unsigned
785 arguments, check that Lisp number is nonnegative, rather than
59568bf0 786 silently wrapping negative numbers around. (Bug#8722)
30217ff0 787 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 788 (Bug#8722)
2d1fc3c7 789
c8a9ca5a
PE
790 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
791
519e1d69
PE
792 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
793
30569699
PE
794 ccl: add integer overflow checks
795 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
796 (IN_INT_RANGE): New macros.
797 (ccl_driver): Use them to check for integer overflow when
798 decoding a CCL program. Many of the new checks are whether XINT (x)
799 fits in int; it doesn't always, on 64-bit hosts. The new version
800 doesn't catch all possible integer overflows, but it's an
847044ea 801 improvement. (Bug#8719)
30569699 802
c11285dc
PE
803 * alloc.c (make_event_array): Use XINT, not XUINT.
804 There's no need for unsigned here.
805
fdccd48e
PE
806 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
807 This follows up to the 2011-05-06 change that substituted uintptr_t
808 for EMACS_INT. This case wasn't caught back then.
809
37910ab2
PE
810 Rework Fformat to avoid integer overflow issues.
811 * editfns.c: Include <float.h> unconditionally, as it's everywhere
812 now (part of C89). Include <verify.h>.
813 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
814 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
815 (Fformat): Avoid the prepass trying to compute sizes; it was only
816 approximate and thus did not catch overflow reliably. Instead, walk
817 through the format just once, formatting and computing sizes as we go,
818 checking for integer overflow at every step, and allocating a larger
819 buffer as needed. Keep track separately whether the format is
820 multibyte. Keep only the most-recently calculated precision, rather
821 than them all. Record whether each argument has been converted to
822 string. Use EMACS_INT, not int, for byte and char and arg counts.
823 Support field widths and precisions larger than INT_MAX. Avoid
824 sprintf's undefined behavior with conversion specifications such as %#d
825 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
826 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
827 formatting out-of-range floating point numbers with int
828 formats. (Bug#8668)
829
2e6578fb
PE
830 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
831
0ae6bdee
PE
832 * data.c: Avoid integer truncation in expressions involving floats.
833 * data.c: Include <intprops.h>.
834 (arith_driver): When there's an integer overflow in an expression
835 involving floating point, convert the integers to floating point
836 so that the resulting value does not suffer from catastrophic
837 integer truncation. For example, on a 64-bit host (* 4
838 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
839 Do not rely on undefined behavior after integer overflow.
840
de883a70
PE
841 merge count_size_as_multibyte, parse_str_to_multibyte
842 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 843 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
844 Check for integer overflow.
845 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
846 since it's now a duplicate of the other. This is more of
847 a character than a buffer op, so better that it's in character.c.
848 * fns.c, print.c: Adjust to above changes.
849
2ff916cb
PE
8502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
851
852 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
853
f1b54466
PE
8542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
855
fb1ac845
PE
856 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
857 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
858 (x_clipboard_manager_save): Now static.
859 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
860
f1b54466
PE
861 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
862 (crypto_hash_function): Now static.
863 Fix pointer signedness problems. Avoid unnecessary initializations.
864
a9f737ee
CY
8652011-05-27 Chong Yidong <cyd@stupidchicken.com>
866
867 * termhooks.h (Vselection_alist): Make it terminal-local.
868
869 * terminal.c (create_terminal): Initialize it.
870
871 * xselect.c: Support for clipboard managers.
872 (Vselection_alist): Move to termhooks.h as terminal-local var.
873 (LOCAL_SELECTION): New macro.
874 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
875 (symbol_to_x_atom): Remove gratuitous arg.
876 (x_handle_selection_request, lisp_data_to_selection_data)
877 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
878 (x_own_selection, x_get_local_selection, x_convert_selection):
879 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
880 (some_frame_on_display): Delete unused function.
881 (Fx_own_selection_internal, Fx_get_selection_internal)
882 (Fx_disown_selection_internal, Fx_selection_owner_p)
883 (Fx_selection_exists_p): New optional frame arg.
884 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
885 (x_handle_selection_clear): Don't treat other terminals with the
886 same keyboard specially. Use the terminal-local Vselection_alist.
887 (x_clear_frame_selections): Use Frun_hook_with_args.
888
889 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
890
891 * xterm.h: Add support for those atoms.
892
e067f0c1
CY
8932011-05-26 Chong Yidong <cyd@stupidchicken.com>
894
895 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
896 (converted_selections, conversion_fail_tag): New global variables.
897 (x_selection_request_lisp_error): Free the above.
898 (x_get_local_selection): Remove unnecessary code.
899 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
900 of converted selections stored in converted_selections.
901 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
902 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
903 (x_convert_selection): New function.
904 (x_handle_selection_event): Simplify.
905 (x_get_foreign_selection): Don't ignore incoming requests while
906 waiting for an answer; this will fail when we implement
907 SAVE_TARGETS, and seems unnecessary anyway.
908 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
909 (Vx_sent_selection_functions): Doc fix.
910
0f4aebc0
LL
9112011-05-26 Leo Liu <sdl.web@gmail.com>
912
913 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
914
e61124cd
YM
9152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
916
917 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
918
919 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
920 for fringe update if it has periodic bitmap.
921 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
922 and fringe_bitmap_periodic_p.
923
924 * fringe.c (get_fringe_bitmap_data): New function.
925 (draw_fringe_bitmap_1, update_window_fringes): Use it.
926 (update_window_fringes): Record periodicity of fringe bitmap in glyph
927 row. Mark glyph row for fringe update if periodicity changed.
928
929 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
930 for fringe update unless it has periodic bitmap.
931
f16d9837
KH
9322011-05-25 Kenichi Handa <handa@m17n.org>
933
934 * xdisp.c (get_next_display_element): Set correct it->face_id for
935 a static composition.
936
e1b90ef6
LL
9372011-05-24 Leo Liu <sdl.web@gmail.com>
938
939 * deps.mk (fns.o):
940 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
941
942 * fns.c (crypto_hash_function, Fsha1): New function.
943 (Fmd5): Use crypto_hash_function.
944 (syms_of_fns): Add Ssha1.
945
7400048f
PE
9462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
947
948 * gnutls.c: Remove unused macros.
949 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
950 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
951 Remove macros that are defined and never used.
952 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
953
abb71cf4
CY
9542011-05-22 Chong Yidong <cyd@stupidchicken.com>
955
956 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
957 (Fx_get_selection_internal): Minor cleanup.
958 (Fx_own_selection_internal): Rename arguments for consistency with
959 select.el.
960
6307db39
PE
9612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
962
963 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
964
f3d4e0a4
CY
9652011-05-22 Chong Yidong <cyd@stupidchicken.com>
966
967 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
968
4d8ade89
YM
9692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
970
971 * dispnew.c (scrolling_window): Don't exclude the case that the
972 last enabled row in the desired matrix touches the bottom boundary.
973
32078c8d
GM
9742011-05-21 Glenn Morris <rgm@gnu.org>
975
976 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
977 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
978 and add some more files.
32078c8d 979
7285dc67
EZ
9802011-05-20 Eli Zaretskii <eliz@gnu.org>
981
982 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
983 report_file_error introduced by the change from 2011-05-07.
984
89d1bd22
PE
9852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
986
987 * systime.h (Time): Define only if emacs is defined.
988 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
989 where the include path doesn't have X11/X.h by default. See
990 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
991
e23640bb 9922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
993
994 * composite.c (find_automatic_composition): Fix previous change.
995
b9704ad9
GM
9962011-05-20 Glenn Morris <rgm@gnu.org>
997
998 * lisp.mk: New file, split from Makefile.in.
999 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1000 (shortlisp): Remove.
1001 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1002
4a720484
GM
10032011-05-19 Glenn Morris <rgm@gnu.org>
1004
1005 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1006 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1007 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1008 (lisp): Set the order to that of loadup.el.
1009 (shortlisp): Make it a copy of $lisp.
1010 (SOME_MACHINE_LISP): Remove.
1011 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1012 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1013
a28d4396
KH
10142011-05-18 Kenichi Handa <handa@m17n.org>
1015
1016 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1017 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1018 (find_automatic_composition): Mostly rewrite for efficiency.
1019
a2b1fa8e
JB
10202011-05-18 Juanma Barranquero <lekktu@gmail.com>
1021
1022 * makefile.w32-in: Update dependencies.
1023
8e1f5610
CS
10242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1025
1026 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1027 revision 104625).
1028
7025ee00 10292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1030
cdfa6eab
PE
1031 Fix some integer overflow issues, such as string length overflow.
1032
06d6db33
PE
1033 * insdel.c (count_size_as_multibyte): Check for string overflow.
1034
2b4560a8
PE
1035 * character.c (lisp_string_width): Check for string overflow.
1036 Use EMACS_INT, not int, for string indexes and lengths; in
1037 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1038 the resulting string length overflows an EMACS_INT; instead,
1039 report a string overflow if no precision given. When checking for
1040 precision exhaustion, use a check that cannot possibly have
1041 integer overflow. (Bug#8675)
1042 * character.h (lisp_string_width): Adjust to new signature.
1043
cb93f9be
PE
1044 * alloc.c (string_overflow): New function.
1045 (Fmake_string): Use it. This doesn't change behavior, but saves
1046 a few bytes and will simplify future changes.
1047 * character.c (string_escape_byte8): Likewise.
1048 * lisp.h (string_overflow): New decl.
1049
1a1f3366
PE
1050 Fixups, following up to the user-interface timestamp change.
1051 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1052 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1053 * msdos.c (mouse_get_pos): Likewise.
1054 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1055 * w32gui.h (Time): Define by including "systime.h" rather than by
1056 declaring it ourselves. (Bug#8664)
1057
d4e3e4d3
PE
1058 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1059 * image.c (clear_image_cache): Likewise.
1060
f6a24d19
PE
1061 * term.c (term_mouse_position): Don't assume time_t wraparound.
1062
08dc5ae6
PE
1063 Be more systematic about user-interface timestamps.
1064 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1065 and sometimes 'EMACS_UINT', to represent these timestamps.
1066 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1067 This makes the code easier to follow, and makes it easier to catch
1068 integer overflow bugs such as Bug#8664.
1069 * frame.c (Fmouse_position, Fmouse_pixel_position):
1070 Use Time, not unsigned long, for user-interface timestamps.
1071 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1072 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1073 * keyboard.h (last_event_timestamp): Likewise.
1074 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1075 * menu.h (xmenu_show): Likewise.
1076 * term.c (term_mouse_position): Likewise.
1077 * termhooks.h (struct input_event.timestamp): Likewise.
1078 (struct terminal.mouse_position_hook): Likewise.
1079 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1080 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1081 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1082 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1083 what it was before.
1084 * menu.h, termhooks.h: Include "systime.h", for Time.
1085
8e55734a
PE
1086 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1087 Don't assume that the difference between two unsigned long values
1088 can fit into an integer. At this point, we know button_down_time
1089 <= event->timestamp, so the difference must be nonnegative, so
1090 there's no need to cast the result if double-click-time is
1091 nonnegative, as it should be; check that it's nonnegative, just in
1092 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1093 apart (about 25 days). (Bug#8664)
8e55734a 1094
841f1b75 1095 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1096 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1097
3e26f69c
PE
1098 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1099 that always fit in int. Use a sentinel instead of a counter, to
1100 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1101 * frame.h (struct frame): Use int for menu_bar_items_used
1102 instead of EMACS_INT, since it always fits in int.
3e26f69c 1103
5cc152c0
PE
1104 * menu.c (grow_menu_items): Check for int overflow.
1105
d89eb65e
PE
1106 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1107
5235bd3e
PE
1108 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1109 Before, the code was not consistent. These values cannot exceed
1110 2**31 - 1 so there's no need to make them unsigned.
1111 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1112 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1113 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1114 as modifiers.
1115 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1116
bc827e23
PE
1117 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1118 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1119 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1120 presumably because the widths might not match.
1121
78eb494e
PE
1122 * window.c (size_window): Avoid needless test at loop start.
1123
04f2d78b
CB
11242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1125
1126 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1127
d2fc7e3d 11282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1129
1130 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1131
d2fc7e3d 11322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1133
1134 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1135 `width' to `bar_area_x' and `bar_area_width', respectively.
1136 (x_scroll_run): Take account of fringe background extension.
1137
04f2d78b
CB
1138 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1139 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1140 `bar_area_width', respectively.
1141 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1142 background extension.
1143
79b70037
GM
11442011-05-10 Jim Meyering <meyering@redhat.com>
1145
1146 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1147
2f142cc5
JB
11482011-05-10 Juanma Barranquero <lekktu@gmail.com>
1149
1150 * image.c (Finit_image_library): Return t for built-in image types,
1151 like pbm and xbm. (Bug#8640)
1152
57679c86
AS
11532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1154
1155 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1156
888c9e86
EZ
11572011-05-07 Eli Zaretskii <eliz@gnu.org>
1158
b0512a1d
EZ
1159 * w32console.c (Fset_screen_color): Doc fix.
1160 (Fget_screen_color): New function.
1161 (syms_of_ntterm): Defsubr it.
1162
7285dc67
EZ
1163 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1164 unlink the temporary file if Fcall_process didn't create it in the
1165 first place.
1166 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1167 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1168 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1169 cue to call_process_cleanup not to close that handle.
1170
4d3fcc8e
BK
11712011-05-07 Ben Key <bkey76@gmail.com>
1172
1173 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1174 one of two shell specific rules, either bootstrap-temacs-CMD or
1175 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1176 to the previous implementation of the bootstrap-temacs rule.
1177 The bootstrap-temacs-CMD rule is similar to the previous
1178 implementation of the bootstrap-temacs rule except that it
1179 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1180 variable.
1181
1182 These changes, along with some changes to nt/configure.bat,
1183 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1184 earlier fix to add support for --cflags and --ldflags options
1185 that include quotes so that it works whether make uses cmd or
1186 sh as the shell.
1187
b4289b64
MA
11882011-05-06 Michael Albinus <michael.albinus@gmx.de>
1189
1190 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1191 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1192 is a constant.
1193 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1194 a string. Handle both cases.
1195 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1196 (Fdbus_register_method): Use Qinvalid_function.
1197
af4c0e28
JB
11982011-05-06 Juanma Barranquero <lekktu@gmail.com>
1199
1200 * makefile.w32-in: Update dependencies.
1201 (LISP_H): Add inttypes.h and stdin.h.
1202 (PROCESS_H): Add unistd.h.
1203
c51453d9
EZ
12042011-05-06 Eli Zaretskii <eliz@gnu.org>
1205
1206 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1207 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1208
8ff0ac3c 12092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1210
4c4b566b
PE
1211 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1212
aab2b9b5
PE
1213 * term.c (vfatal): Remove stray call to va_end.
1214 It's not needed and the C Standard doesn't allow it here anyway.
1215
c378da0b
PE
1216 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1217 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1218
288b08c7
PE
1219 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1220 bytes.
1221
e3601888
PE
1222 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1223
db6c0e74
PE
1224 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1225
dd5963ea
PE
1226 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1227
88c9450f
PE
1228 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1229
2f9442b8
PE
1230 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1231
c032b5f8
PE
1232 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1233 * charset.c (Fdefine_charset_internal): Don't initialize
1234 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1235 32-bit int (Bug#8600).
a108c10b
PE
1236
1237 * lread.c (read_integer): Be more consistent with string-to-number.
1238 Use string_to_number to do the actual conversion; this avoids
1239 rounding errors and fixes some other screwups. Without this fix,
1240 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1241 (digit_to_number): Move earlier, for benefit of read_integer.
1242 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1243 not a digit in any supported base. (Bug#8602)
a108c10b 1244
ad5f9eea
PE
1245 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1246
aec1708a
PE
1247 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1248 to match comment at start of function. This also removes a
1249 GCC warning about overflow in a 32+64-bit port.
1250
47be4ab5
PE
1251 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1252
371cac43
PE
1253 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1254 Reported by Stefan Monnier in
1255 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1256 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1257 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1258
d01a7826
PE
1259 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1260 (EMACS_UINTPTR): Likewise, with uintptr_t.
1261
7fd47d5c
PE
1262 * lisp.h: Prefer 64-bit EMACS_INT if available.
1263 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1264 on 32-bit hosts that have 64-bit int, so that they can access
1265 large files.
122b0c86
PE
1266 However, temporarily disable this change unless the temporary
1267 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1268
8727937b
PE
1269 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1270
8ac068ac
PE
1271 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1272 This removes an assumption that EMACS_INT and long are the same
1273 width as pointers. The assumption is true for Emacs porting targets
1274 now, but we want to make other targets possible.
1275 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1276 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1277 In the rest of the code, change types of integers that hold casted
1278 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1279 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1280 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1281 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1282 No need to cast type when ORing.
1283 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1284 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1285 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1286 assume EMACS_INT is the same width as char *.
1287 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1288 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1289 Remove no-longer-needed casts.
1290 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1291 (xg_tool_bar_help_callback, xg_make_tool_item):
1292 Use EMACS_INTPTR to hold an integer
1293 that will be cast to void *; this can avoid a GCC warning
1294 if EMACS_INT is not the same width as void *.
1295 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1296 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1297 (current_message_1, set_message_1):
1298 Use a local to convert to proper width without a cast.
1299 * xmenu.c (dialog_selection_callback): Likewise.
1300
ede49d71
PE
1301 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1302 Also, don't assume VALBITS / RAND_BITS is less than 5,
1303 and don't rely on undefined behavior when shifting a 1 left into
1304 the sign bit.
1305 * lisp.h (get_random): Change signature to match.
1306
2f30ecd0
PE
1307 * lread.c (hash_string): Use size_t, not int, for hash computation.
1308 Normally we prefer signed values; but hashing is special, because
1309 it's better to use unsigned division on hash table sizes so that
1310 the remainder is nonnegative. Also, size_t is the natural width
1311 for hashing into memory. The previous code used 'int', which doesn't
1312 retain enough info to hash well into very large tables.
1313 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1314
2a866e7b
PE
1315 * dbusbind.c: Don't possibly lose pointer info when converting.
1316 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1317 Use XPNTR rather than XHASH, so that the high-order bits of
1318 the pointer aren't lost when converting through void *.
1319
51639eac
PE
1320 * eval.c (Fautoload): Don't double-shift a pointer.
1321
92394119
PE
1322 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1323
dbdb9a7c
JB
13242011-05-06 Juanma Barranquero <lekktu@gmail.com>
1325
1326 * gnutls.c (DEF_GNUTLS_FN):
1327 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1328
db7a0b4f
AS
13292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1330
1331 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1332 marker. (Bug#8610)
1333
f7ff1b0f 13342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1335
1336 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1337 New version that can reserve upto 2GB of heap space.
1338
f7ff1b0f 13392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1340
1341 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1342
639c109b
TZ
13432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1344
1345 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1346 `gnutls_certificate_set_x509_key_file'.
1347
d2127135
JB
13482011-05-05 Juanma Barranquero <lekktu@gmail.com>
1349
1350 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1351 Update dependencies.
1352
e968f4f3
JB
13532011-05-04 Juanma Barranquero <lekktu@gmail.com>
1354
1355 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1356 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1357 Remove unused parameter `fildes'.
1358 * process.c (read_process_output, send_process): Don't pass it.
1359
84d358f0
JB
13602011-05-04 Juanma Barranquero <lekktu@gmail.com>
1361
1362 Fix previous change: the library cache is defined in w32.c.
1363 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1364 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1365
0898ca10
JB
13662011-05-04 Juanma Barranquero <lekktu@gmail.com>
1367
1368 Implement dynamic loading of GnuTLS on Windows.
1369
1370 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1371 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1372 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1373 Declare.
1374
1375 * gnutls.c (Qgnutls_dll): Define.
1376 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1377 (gnutls_*): Declare function pointers.
1378 (init_gnutls_functions): New function to initialize function pointers.
1379 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1380 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1381 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1382 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1383 (emacs_gnutls_write, emacs_gnutls_read)
1384 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1385 (Fgnutls_available_p): New function.
1386 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1387 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1388 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1389
1390 * image.c: Include w32.h.
1391 (Vimage_type_cache): Delete.
1392 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1393 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1394 (w32_delayed_load): Move to w32.c.
1395
1396 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1397
1398 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1399 (w32_delayed_load): Move from image.c. When loading a library, record
1400 its filename in the :loaded-from property of the library id.
1401 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1402 Initialize and staticpro them.
1403 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1404
1405 * process.c: Include lisp.h before w32.h, not after.
1406 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1407 instead of gnutls_record_check_pending.
1408
1409 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1410
ff4de4aa
TZ
14112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1412
1413 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1414 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1415 as passed in.
1416
abe95abb
JD
14172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1418
1419 * xterm.c (x_set_frame_alpha): Do not set property on anything
1420 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1421
e16e55d4
JB
14222011-05-02 Juanma Barranquero <lekktu@gmail.com>
1423
1424 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1425
bafcf6a5
JB
14262011-05-02 Juanma Barranquero <lekktu@gmail.com>
1427
1428 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1429 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1430 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1431 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1432 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1433 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1434 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1435 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1436 (Qgnutls_bootprop_callbacks_verify): Make static.
1437
e7a6747f
AS
14382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1439
19ed11ba
AS
1440 * callproc.c: Indentation fixup.
1441
e7a6747f 1442 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1443 (wait_for_termination, interruptible_wait_for_termination):
1444 Move after wait_for_termination_1.
e7a6747f 1445
1ef14cb4
LMI
14462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1447
1448 * sysdep.c (interruptible_wait_for_termination): New function
1449 which is like wait_for_termination, but allows keyboard
1450 interruptions.
1451
1452 * callproc.c (Fcall_process): Add (:file "file") as an option for
1453 the STDOUT buffer.
1454 (Fcall_process_region): Ditto.
1455
330d880c
EZ
14562011-04-30 Eli Zaretskii <eliz@gnu.org>
1457
8db90b73
EZ
1458 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1459 rather than `XVECTOR (FOO)->size'.
1460
330d880c
EZ
1461 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1462 inttypes.h, as a gnulib replacement is used if it not available in
1463 system headers.
1464
15cbd324
EZ
14652011-04-21 Eli Zaretskii <eliz@gnu.org>
1466
1467 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1468 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1469 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1470
1471 * coding.c (coding_alloc_by_realloc): Error out if destination
1472 will grow beyond MOST_POSITIVE_FIXNUM.
1473 (decode_coding_emacs_mule): Abort if there isn't enough place in
1474 charbuf for the composition carryover bytes. Reserve an extra
1475 space for up to 2 characters produced in a loop.
1476 (decode_coding_iso_2022): Abort if there isn't enough place in
1477 charbuf for the composition carryover bytes.
1478
14792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1480
ae940cca
EZ
1481 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1482 aborting when %lld or %lll format is passed.
1483 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1484 %llo or %llx format is passed. (Bug#8545)
1485
03ab8921
EZ
1486 * window.c (window_scroll_line_based): Use a marker instead of
1487 simple variables to record original value of point. (Bug#7952)
1488
afda1437
EZ
1489 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1490 produced by %s or %c overflows available buffer space. (Bug#8545)
1491
f76dee0c
PE
14922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1495 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1496
fdc5744d
JB
14972011-04-28 Juanma Barranquero <lekktu@gmail.com>
1498
1499 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1500
638f053a
JB
15012011-04-28 Juanma Barranquero <lekktu@gmail.com>
1502
1503 * keyboard.c (Qdelayed_warnings_hook): Define.
1504 (command_loop_1): Run `delayed-warnings-hook'
1505 if Vdelayed_warnings_list is non-nil.
1506 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1507 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1508
d178f871
EZ
15092011-04-28 Eli Zaretskii <eliz@gnu.org>
1510
1511 * doprnt.c (doprnt): Don't return value smaller than the buffer
1512 size if the message was truncated. (Bug#8545).
1513
b124fd93
JB
15142011-04-28 Juanma Barranquero <lekktu@gmail.com>
1515
1516 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1517 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1518
e810457d
PE
15192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1520
1521 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1522
ea51cceb
JB
15232011-04-27 Juanma Barranquero <lekktu@gmail.com>
1524
1525 * makefile.w32-in: Update dependencies.
1526
94dcfacf
EZ
15272011-04-27 Eli Zaretskii <eliz@gnu.org>
1528
1529 Improve `doprnt' and its usage. (Bug#8545)
1530 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1531 `format_end'. Remove support for %l as a conversion specifier.
1532 Don't use xrealloc. Improve diagnostics when the %l size modifier
1533 is used. Update the commentary.
1534
1535 * eval.c (verror): Simplify calculation of size_t.
1536
1537 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1538 messages.
1539
f61f41d7
PE
15402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1541
1542 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1543 change.
1544
96fb4434
PE
15452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1548 This makes this file independent of the recent pseudovector change.
1549
671875da 15502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1551
69e9b5a3
PE
1552 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1553
b5f869a7 1554 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1555 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1556 Remove unused local.
c8926152 1557 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1558
841a1577 1559 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1560 GCC 4.6.0 optimizes based on type-based alias analysis.
1561 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1562 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1563 != &v->size, and therefore "v->size = 1; b->size = 2; return
1564 v->size;" must therefore return 1. This assumption is incorrect
1565 for Emacs, since it type-puns struct Lisp_Vector * with many other
1566 types. To fix this problem, this patch adds a new type struct
f904488f 1567 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1568 and pseudovectors, and helps optimizing compilers not get fooled
1569 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1570 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1571 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1572 the size member.
eab3844f
PE
1573 (XSETPVECTYPE): Rewrite in terms of new macro.
1574 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1575 This is a bit clearer, and further avoids the possibility of
1576 undesirable aliasing.
1577 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1578 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1579 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1580 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1581 (ASIZE): Now uses header.size rather than size.
1582 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1583 to avoid the hassle of writing XVECTOR (foo)->header.size.
1584 (struct vectorlike_header): New type.
eab3844f
PE
1585 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1586 object, to help avoid aliasing.
1587 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1588 (SUBRP): Likewise, since Lisp_Subr is a special case.
1589 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1590 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1591 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1592 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1593 changed to be "header.size" and "header.next".
1594 * buffer.h (struct buffer): Likewise.
1595 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1596 * frame.h (struct frame): Likewise.
1597 * process.h (struct Lisp_Process): Likewise.
1598 * termhooks.h (struct terminal): Likewise.
1599 * window.c (struct save_window_data, struct saved_window): Likewise.
1600 * window.h (struct window): Likewise.
1601 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1602 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1603 * buffer.c (init_buffer_once): Likewise.
1604 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1605 special case.
1606 * process.c (Fformat_network_address): Use local var for size,
1607 for brevity.
1608
0df1eac5
PE
1609 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1610
847ab9d1 1611 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1612 * data.c (atof): Remove decl; no longer used or needed.
1613 (digit_to_number): Move to lread.c.
1614 (Fstring_to_number): Use new string_to_number function, to be
1615 consistent with how the Lisp reader treats infinities and NaNs.
1616 Do not assume that floating-point numbers represent EMACS_INT
1617 without losing information; this is not true on most 64-bit hosts.
1618 Avoid double-rounding errors, by insisting on integers when
1619 parsing non-base-10 numbers, as the documentation specifies.
1620 * lisp.h (string_to_number): New decl, replacing ...
1621 (isfloat_string): Remove.
bc0a5c13 1622 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1623 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1624 appears to have been a coding error. Similarly, do not accept
1625 strings like +-1e0 as floating point numbers. Do not report
1626 overflow for integer overflows unless the base is not 10 which
1627 means we have no simple and reliable way to continue.
1628 Break out the floating-point parsing into a new
1629 function string_to_number, so that Fstring_to_number parses
1630 floating point numbers consistently with the Lisp reader.
04f2d78b 1631 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1632 (E_CHAR, EXP_INT): Remove, replacing with ...
1633 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1634 (string_to_number): New function, replacing isfloat_string.
1635 This function checks for valid syntax and produces the resulting
1636 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1637 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1638 so that overflow for non-base-10 numbers is reported only when
1639 there's no portable and simple way to convert to floating point.
452f4150 1640
67769ffc
PE
1641 * textprop.c (set_text_properties_1): Rewrite for clarity,
1642 and to avoid GCC warning about integer overflow.
1643
c20db43f
PE
1644 * intervals.h (struct interval): Use EMACS_INT for members
1645 where EMACS_UINT might cause problems. See
1646 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1647 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1648 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1649 All uses changed.
37aa2f85
PE
1650 (offset_intervals): Tell GCC not to worry about length overflow
1651 when negating a negative length.
c20db43f 1652
2538aa2f
PE
1653 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1654 (overrun_check_free): Likewise.
1655
f2d3008d
PE
1656 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1657 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1658 word size.
1659
ec8df744
PE
1660 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1661 (gnutls_make_error): Rename local to avoid shadowing.
1662 (gnutls_emacs_global_deinit): ifdef out; not used.
1663 (Fgnutls_boot): Use const for pointer to readonly storage.
1664 Comment out unused local. Fix pointer signedness problems.
1665
640ee02d
PE
1666 * lread.c (openp): Don't stuff size_t into an 'int'.
1667 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1668 about possible signed overflow.
1669
6048fb2a
PE
1670 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1671 (GDK_KEY_g): Don't define if already defined.
1672 (xg_prepare_tooltip): Avoid pointer signedness problem.
1673 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1674
fa3c87e1
PE
1675 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1676 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1677
2172544b
PE
1678 * xfns.c (Fx_window_property): Simplify a bit,
1679 to make a bit faster and to avoid GCC 4.6.0 warning.
1680 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1681
9b821a21
PE
1682 * fns.c (internal_equal): Don't assume size_t fits in int.
1683
3c616cfa
PE
1684 * alloc.c (compact_small_strings): Tighten assertion a little.
1685
c2982e87
PE
1686 Replace pEd with more-general pI, and fix some printf arg casts.
1687 * lisp.h (pI): New macro, generalizing old pEd macro to other
1688 conversion specifiers. For example, use "...%"pI"d..." rather
1689 than "...%"pEd"...".
1690 (pEd): Remove. All uses replaced with similar uses of pI.
1691 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1692 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1693 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1694 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1695 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1696 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1697 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1698 64-bit hosts.
1699 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1700 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1701 * print.c (safe_debug_print, print_object): Likewise.
1702 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1703 to int.
6f04d126
PE
1704 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1705 avoiding the 0 flag, which is not portable.
c2982e87
PE
1706 * process.c (Fmake_network_process): Use pI to avoid cast.
1707 * region-cache.c (pp_cache): Likewise.
1708 * xdisp.c (decode_mode_spec): Likewise.
1709 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1710 behavior on 64-bit hosts with printf arg.
6f04d126 1711 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1712 (x_stop_queuing_selection_requests): Likewise.
1713 (x_get_window_property): Don't truncate byte count to an 'int'
1714 when tracing.
0b432f21 1715
5e073ec7
PE
1716 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1717 here, since it parses constructs like leading '-' and spaces,
1718 which are not wanted; and it overflows with large numbers.
1719 Instead, simply match F[0-9]+, which is what is wanted anyway.
1720
36372bf9
PE
1721 * alloc.c: Remove unportable assumptions about struct layout.
1722 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1723 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1724 (allocate_vectorlike, make_pure_vector): Use the new macros,
1725 plus offsetof, to remove unportable assumptions about struct layout.
1726 These assumptions hold on all porting targets that I know of, but
1727 they are not guaranteed, they're easy to remove, and removing them
1728 makes further changes easier.
1729
0b432f21
PE
1730 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1731 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1732 (string_overrun_cookie): Now const. Use initializers that
1733 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1734 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1735 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1736 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1737 multiple of sizeof (EMACS_INT); it need not be, if
1738 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1739 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1740
895009e1
JB
17412011-04-26 Juanma Barranquero <lekktu@gmail.com>
1742
1743 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1744
6a7a1b0b
TZ
17452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1746
1747 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1748 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1749 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1750
841a1577 17512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1752
1753 * lisp.h (Qdebug): List symbol.
895009e1 1754 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1755 * keyboard.c (debug-on-event): New variable.
1756 (handle_user_signal): Break into debugger when debug-on-event
1757 matches the current signal symbol.
1758
f2d3ba6f
DN
17592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1760
1761 * alloc.c (check_sblock, check_string_bytes)
1762 (check_string_free_list): Convert to standard C.
1763
42ce4c63
TZ
17642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1765
1766 * w32.c (emacs_gnutls_push): Fix typo.
1767
825cd63c
EZ
17682011-04-25 Eli Zaretskii <eliz@gnu.org>
1769
fb11d64d
EZ
1770 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1771 "cast to pointer from integer of different size".
1772
825cd63c
EZ
1773 Improve doprnt and its use in verror. (Bug#8545)
1774 * doprnt.c (doprnt): Document the set of format control sequences
1775 supported by the function. Use SAFE_ALLOCA instead of always
1776 using `alloca'.
1777
1778 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1779 is one byte too soon. Don't use xrealloc; instead xfree and
1780 xmalloc anew.
1781
e061a11b
TZ
17822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1783
1784 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1785 callbacks stage.
1786
1787 * gnutls.c: Renamed global_initialized to
1788 gnutls_global_initialized. Added internals for the
1789 :verify-hostname-error, :verify-error, and :verify-flags
1790 parameters of `gnutls-boot' and documented those parameters in the
1791 docstring. Start callback support.
1792 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1793 unless a fatal error occured. Call gnutls_alert_send_appropriate
1794 on error. Return error code.
1795 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1796 (emacs_gnutls_read): Likewise.
1797 (Fgnutls_boot): Return handshake error code.
1798 (emacs_gnutls_handle_error): New function.
1799 (wsaerror_to_errno): Likewise.
1800
1801 * w32.h (emacs_gnutls_pull): Add prototype.
1802 (emacs_gnutls_push): Likewise.
1803
1804 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1805 (emacs_gnutls_push): Likewise.
1806
18072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1808
1809 * process.c (wait_reading_process_output): Check if GnuTLS
1810 buffered some data internally if no FDs are set for TLS
1811 connections.
1812
1813 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1814 (LIBS): Link to USER_LIBS.
1815 ($(BLD)/gnutls.$(0)): New target.
1816
fa6996bc
EZ
18172011-04-24 Eli Zaretskii <eliz@gnu.org>
1818
eb35682e
EZ
1819 * xdisp.c (handle_single_display_spec): Rename the
1820 display_replaced_before_p argument into display_replaced_p, to
1821 make it consistent with the commentary. Fix typos in the
1822 commentary.
1823
e2ad650c
EZ
1824 * textprop.c (syms_of_textprop): Remove dead code.
1825 (copy_text_properties): Delete obsolete commentary about an
1826 interface that was deleted long ago. Fix typos in the description
1827 of arguments.
1828
1b2de274
EZ
1829 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1830 to changes in oldXMenu/XMenu.h from 2011-04-16.
1831 <menu_help_message, prev_menu_help_message>: Constify.
1832 (IT_menu_make_room): menu->help_text is now `const char **';
1833 adjust.
1834
1835 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1836 to changes in oldXMenu/XMenu.h from 2011-04-16.
1837 (struct XMenu): Declare `help_text' `const char **'.
1838
1839 * xfaces.c <Qunspecified>: Make extern again.
1840
1841 * syntax.c: Include sys/types.h before including regex.h, as
1842 required by Posix.
1843
762b15be
EZ
1844 * doc.c (get_doc_string): Improve the format passed to `error'.
1845
1846 * doprnt.c (doprnt): Improve commentary.
1847
1848 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1849
1850 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1851 them with etags.
1852
f1052e5d
EZ
1853 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1854 changes in globals.h immediately force recompilation.
762b15be
EZ
1855 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1856 $(CURDIR)/s/ms-w32.h.
1857 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1858
fa6996bc
EZ
1859 * character.c (Fchar_direction): Function deleted.
1860 (syms_of_character): Don't defsubr it.
1861 <char-direction-table>: Deleted.
1862
e6c3da20
EZ
18632011-04-23 Eli Zaretskii <eliz@gnu.org>
1864
1865 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1866 * doprnt.c: Include limits.h.
1867 (SIZE_MAX): New macro.
04f2d78b
CB
1868 (doprnt): Return a size_t value. 2nd arg is now size_t.
1869 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1870 Improve overflow protection. Support `l' modifier for integer
1871 conversions. Support %l conversion. Don't assume an EMACS_INT
1872 argument for integer conversions and for %c.
1873
1874 * lisp.h (doprnt): Restore prototype.
1875
1876 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1877 $(SRC)/character.h.
1878
1879 * Makefile.in (base_obj): Add back doprnt.o.
1880
1881 * deps.mk (doprnt.o): Add back prerequisites.
1882 (callint.o): Depend on character.h.
1883
1884 * eval.c (internal_lisp_condition_case): Include the handler
1885 representation in the error message.
1886 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1887 when breaking from the loop.
1888
1889 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1890
1891 * callint.c (Fcall_interactively): When displaying error message
1892 about invalid control letter, pass the character's codepoint, not
1893 a pointer to its multibyte form. Improve display of the character
1894 in octal and display also its hex code.
1895
1896 * character.c (char_string): Use %x to display the (unsigned)
1897 codepoint of an invalid character, to avoid displaying a bogus
1898 negative value.
1899
1900 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1901 `error', not SYMBOL_NAME itself.
1902
1903 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1904 character arguments to `error'.
1905
1906 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1907 to `error' in error message about FINAL_CHAR argument. Make sure
1908 FINAL_CHAR is a character, and use %c when it is passed as
1909 argument to `error'.
1910
4ffd0d6b 19112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1912
1913 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1914
1915 * w32.c: Include <time.h>.
1916 (sys_localtime): New function.
1917
4ffd0d6b 19182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1919
1920 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1921
4ffd0d6b 1922 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1923
4ffd0d6b 19242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1925
4ffd0d6b
GM
1926 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1927 zombies (Bug#8467).
aac0c6e3 1928
04c56954
EZ
19292011-04-19 Eli Zaretskii <eliz@gnu.org>
1930
1931 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1932 gl_state.e_property when gl_state.object is Qt.
1933
1934 * insdel.c (make_gap_larger): Remove limitation of buffer size
1935 to <= INT_MAX.
1936
16a43933
CY
19372011-04-18 Chong Yidong <cyd@stupidchicken.com>
1938
1939 * xdisp.c (lookup_glyphless_char_display)
1940 (produce_glyphless_glyph): Handle cons cell entry in
1941 glyphless-char-display.
1942 (Vglyphless_char_display): Document it.
1943
1944 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1945 glyphless-char-display.
1946
4581706e
CY
19472011-04-17 Chong Yidong <cyd@stupidchicken.com>
1948
1949 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1950
1951 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1952
1953 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1954 definition for no-X builds.
1955
4887c6e2 19562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1957
fd35b6f9
PE
1958 Static checks with GCC 4.6.0 and non-default toolkits.
1959
5c1ccb01
PE
1960 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1961
006c5daa
PE
1962 * process.c (keyboard_bit_set): Define only if SIGIO.
1963 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1964 (send_process): Repair possible setjmp clobbering.
1965
efc736d3
PE
1966 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1967
4e2fe2e6
PE
1968 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1969
f97334a2
PE
1970 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1971
4e75f29d
PE
1972 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1973 Define only if needed.
1974
90efadd1
PE
1975 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1976 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1977 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1978
3c647824
PE
1979 * dispextern.h (struct redisplay_interface): Rename param
1980 to avoid shadowing.
e264f262 1981 * termhooks.h (struct terminal): Likewise.
761383f4 1982 * xterm.c (xembed_send_message): Likewise.
3c647824 1983
b58c5c4a
PE
1984 * insdel.c (make_gap_smaller): Define only if
1985 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1986
cad59032
PE
1987 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1988 it.
1989
c339dc2e
PE
1990 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1991 so that we aren't warned about unused symbols.
1992
91a3e27b
PE
1993 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1994
399c71d3 1995 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1996
8ffc96f5
PE
1997 * xfns.c (x_real_positions): Mark locals as initialized.
1998
eef9bc79
PE
1999 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2000
098db9dd
PE
2001 * xterm.c: Fix problems found by static analysis with other toolkits.
2002 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2003 (x_dispatch_event): Declare static if USE_GTK, and
2004 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2005 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2006 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2007 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2008 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2009
eb18f6cc
PE
2010 * xmenu.c (menu_help_callback): Pointer type fixes.
2011 Use const pointers when pointing at readonly data. Avoid pointer
2012 signedness clashes.
2013 (FALSE): Remove unused macro.
2014 (update_frame_menubar): Remove unused decl.
2015
1fe72bf8
PE
2016 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2017
60d9e1db
PE
2018 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2019 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2020 (single_menu_item): Rename local to avoid shadowing.
2021
39261c26
PE
2022 * keyboard.c (make_lispy_event): Remove unused local var.
2023
018c5e19
PE
2024 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2025 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2026
63d2b86e
PE
2027 * bitmaps: Change bitmaps from unsigned char back to the X11
2028 compatible char. Avoid the old compiler warnings about
2029 out-of-range initializers by using, for example, '\xab' rather
2030 than 0xab.
2031
aefd87e1
PE
2032 * xgselect.c (xgselect_initialize): Check vs interface
2033 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2034
bf501fb9
PE
2035 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2036
e9829fdf
PE
2037 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2038 to read-only memory.
2039
1086c095
PE
2040 * fns.c (vector): Remove; this old hack is no longer needed.
2041
2baccd04 2042 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2043 Remove unused var.
dde42981 2044 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2045
72391843 2046 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2047
436c16df 2048 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2049 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2050 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2051
92bb796d 2052 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2053 (x_term_init): Remove local to avoid shadowing.
92bb796d 2054
764430a3 2055 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2056
2057 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2058 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2059
d1dfb56c
EZ
20602011-04-16 Eli Zaretskii <eliz@gnu.org>
2061
c4354cb4
EZ
2062 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2063
d1dfb56c
EZ
2064 Fix regex.c, syntax.c and friends for buffers > 2GB.
2065 * syntax.h (struct gl_state_s): Declare character position members
2066 EMACS_INT.
2067
2068 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2069
04f2d78b
CB
2070 * textprop.c (verify_interval_modification, interval_of):
2071 Declare arguments EMACS_INT.
d1dfb56c
EZ
2072
2073 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2074 EMACS_INT.
2075
2076 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2077
2078 * indent.c (Fvertical_motion): Local variable it_start is now
2079 EMACS_INT.
2080
2081 * regex.c (re_match, re_match_2, re_match_2_internal)
2082 (bcmp_translate, regcomp, regexec, print_double_string)
2083 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2084 (re_compile_pattern, re_exec): Declare arguments and local
2085 variables `size_t' and `ssize_t' and return values `regoff_t', as
2086 appropriate.
2087 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2088 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2089 <compile_stack_type>: `size' and `avail' are now `size_t'.
2090
2091 * regex.h <regoff_t>: Use ssize_t, not int.
2092 (re_search, re_search_2, re_match, re_match_2): Arguments that
2093 specify buffer/string position and length are now ssize_t and
2094 size_t. Return type is regoff_t.
2095
613052cd
BK
20962011-04-16 Ben Key <bkey76@gmail.com>
2097
2098 * nsfont.m: Fixed bugs in ns_get_family and
2099 ns_descriptor_to_entity that were caused by using free to
2100 deallocate memory blocks that were allocated by xmalloc (via
2101 xstrdup). This caused Emacs to crash when compiled with
2102 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2103 --enable-checking=xmallocoverrun). xfree is now used to
2104 deallocate these memory blocks.
2105
4170f62f 21062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2107
71b41406
PE
2108 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2109
9587a89d
PE
2110 emacs_write: Accept and return EMACS_INT for sizes.
2111 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2112 et seq.
2113 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2114 Accept and return EMACS_INT.
2115 (emacs_gnutls_write): Return the number of bytes written on
2116 partial writes.
2117 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2118 (emacs_read, emacs_write): Remove check for negative size, as the
2119 Emacs source code has been audited now.
9587a89d
PE
2120 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2121 (emacs_read, emacs_write): Use it.
273a5f82
PE
2122 * process.c (send_process): Adjust to the new signatures of
2123 emacs_write and emacs_gnutls_write. Do not attempt to store
2124 a byte offset into an 'int'; it might overflow.
9587a89d 2125 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2126
3e047f51
PE
2127 * sound.c: Don't assume sizes fit in 'int'.
2128 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2129 Return EMACS_INT, not int.
3e047f51 2130 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2131 Accept EMACS_INT, not int.
2132 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2133 record read return values.
2134
cc39a9db
BK
21352011-04-15 Ben Key <bkey76@gmail.com>
2136
c9d0ec6d
JB
2137 * keyboard.c (Qundefined): Don't declare static since it is used
2138 in nsfns.m.
2139 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2140 static since they are used in nsfont.m.
cc39a9db 2141
6c60eb9f
SM
21422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2143
2144 * process.c (Qprocessp): Don't declare static.
2145 * lisp.h (Qprocessp): Declare again.
2146
7990b61a
JB
21472011-04-15 Juanma Barranquero <lekktu@gmail.com>
2148
2149 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2150
5d4cb038
PE
21512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2152
8bd7b830 2153 Improve C-level modularity by making more things 'static'.
cd64ea1d 2154
e3b27b31
PE
2155 Don't publish debugger-only interfaces to other modules.
2156 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2157 (verify_bytepos, count_markers): Move decls to the only modules
2158 that need them.
2159 * region-cache.h (pp_cache): Likewise.
2160 * window.h (check_all_windows): Likewise.
2161 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2162
5d4cb038
PE
2163 * sysdep.c (croak): Now static, if
2164 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2165 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2166
2167 * alloc.c (refill_memory_reserve): Now static if
2168 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2169 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2170
e87b6180
PE
2171 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2172 Define only if USE_LUCID.
2173
ac64929e
PE
2174 * xrdb.c (x_customization_string, x_rm_string): Now static.
2175
6f37259d
PE
2176 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2177 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2178
1683e3ab
PE
2179 * xdisp.c (draw_row_with_mouse_face): Now static.
2180 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2181
de9c2632
PE
2182 * window.h (check_all_windows): Mark externally visible.
2183
2b96acb7
PE
2184 * window.c (window_deletion_count): Now static.
2185
2186 * undo.c: Make symbols static if they're not exported.
2187 (last_undo_buffer, last_boundary_position, pending_boundary):
2188 Now static.
2189
50436f33
PE
2190 * textprop.c (interval_insert_behind_hooks): Now static.
2191 (interval_insert_in_front_hooks): Likewise.
2192
64520e5c
PE
2193 * term.c: Make symbols static if they're not exported.
2194 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2195 (max_frame_lines, tty_set_terminal_modes):
2196 (tty_reset_terminal_modes, tty_turn_off_highlight):
2197 (get_tty_terminal): Now static.
2198 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2199 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2200 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2201 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2202 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2203
1fa53021
PE
2204 * sysdep.c: Make symbols static if they're not exported.
2205 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2206 Now static.
2207 (sigprocmask_set, full_mask): Remove; unused.
2208 (wait_debugging): Mark as visible.
2209 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2210 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2211
d4b43b22
PE
2212 * syntax.c (syntax_temp): Define only if !__GNUC__.
2213
b7c513d0
PE
2214 * sound.c (current_sound_device, current_sound): Now static.
2215
989b29ad
PE
2216 * search.c (searchbufs, searchbuf_head): Now static.
2217
13a55a78
PE
2218 * scroll.c (scroll_cost): Remove; unused.
2219 * dispextern.h (scroll_cost): Remove decl.
2220
de68a1fc
PE
2221 * region-cache.h (pp_cache): Mark as externally visible.
2222
40ccffa6
PE
2223 * process.c: Make symbols static if they're not exported.
2224 (process_tick, update_tick, create_process, chan_process):
2225 (Vprocess_alist, proc_buffered_char, datagram_access):
2226 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2227 (deactivate_process): Mark defn as static, as well as decl.
2228 * lisp.h (create_process): Remove decl.
2229 * process.h (chan_process, Vprocess_alist): Remove decls.
2230
ad64fc97
PE
2231 * print.c: Make symbols static if they're not exported.
2232 (print_depth, new_backquote_output, being_printed, print_buffer):
2233 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2234 (print_interval, print_number_index, initial_stderr_stream):
2235 Now static.
2236 * lisp.h (Fprinc): Remove decl.
2237 (debug_output_compilation_hack): Mark as externally visible.
2238
adddb265
PE
2239 * sysdep.c (croak): Move decl from here to syssignal.h.
2240 * syssignal.h (croak): Put it here, so the API can be checked when
2241 'croak' is called from dissociate_if_controlling_tty.
2242
1717ede2
PE
2243 * minibuf.c: Make symbols static if they're not exported.
2244 (minibuf_save_list, choose_minibuf_frame): Now static.
2245 * lisp.h (choose_minibuf_frame): Remove decl.
2246
fa5fb2bc
PE
2247 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2248
1e3890d1
PE
2249 * lread.c: Make symbols static if they're not exported.
2250 (read_objects, initial_obarray, oblookup_last_bucket_number):
2251 Now static.
2252 (make_symbol): Remove; unused.
2253 * lisp.h (initial_obarray, make_symbol): Remove decls.
2254
8a1414fa
PE
2255 * keyboard.c: Make symbols static if they're not exported.
2256 (single_kboard, recent_keys_index, total_keys, recent_keys):
2257 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2258 (this_single_command_key_start, echoing, last_auto_save):
2259 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2260 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2261 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2262 (Vlispy_mouse_stem, double_click_count):
2263 Now static.
2264 (force_auto_save_soon): Define only if SIGDANGER.
2265 (ignore_mouse_drag_p): Now static if
2266 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2267 (print_help): Remove; unused.
2268 (stop_character, last_timer_event): Mark as externally visible.
2269 * keyboard.h (ignore_mouse_drag_p): Declare only if
2270 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2271 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2272 * lisp.h (echoing): Remove decl.
2273 (force_auto_save_soon): Declare only if SIGDANGER.
2274 * xdisp.c (redisplay_window): Simplify code, to make it more
2275 obvious that ignore_mouse_drag_p is not accessed if !defined
2276 USE_GTK && !defined HAVE_NS.
2277
93ea6e8f
PE
2278 * intervals.c: Make symbols static if they're not exported.
2279 (merge_properties_sticky, merge_interval_right, delete_interval):
2280 Now static.
2281 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2282
77382fcc
PE
2283 * insdel.c: Make symbols static if they're not exported.
2284 However, leave prepare_to_modify_buffer alone. It's never
2285 called from outside this function, but that appears to be a bug.
2286 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2287 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2288 (adjust_after_replace_noundo): Remove; unused.
2289 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2290 (signal_before_change): Remove decls.
77382fcc 2291
9306c32e
PE
2292 * indent.c (val_compute_motion, val_vmotion): Now static.
2293
cd44d2eb
PE
2294 * image.c: Make symbols static if they're not exported.
2295 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2296 if USE_GTK.
2297 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2298 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2299
ad9a7a06
PE
2300 * fringe.c (standard_bitmaps): Now static.
2301 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2302
81626931
PE
2303 * frame.c: Make symbols static if they're not exported.
2304 (x_report_frame_params, make_terminal_frame): Now static.
2305 (get_frame_param): Now static, unless HAVE_NS.
2306 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2307 (x_get_resource_string): Remove; not used.
2308 * frame.h (make_terminal_frame, x_report_frame_params):
2309 (x_get_resource_string); Remove decls.
2310 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2311 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2312
239f9db9
PE
2313 * font.c, fontset.c: Make symbols static if they're not exported.
2314 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2315 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2316 * font.c (font_close_object): Now static.
2317 * font.h (font_close_object): Remove.
2318 * fontset.c (FONTSET_OBJLIST): Remove.
2319 (free_realized_fontset) #if-0 the body, which does nothing.
2320 (face_suitable_for_char_p): #if-0, as it's never called.
2321 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2322 * xfaces.c (face_at_string_position):
2323 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2324 since 0 is always ASCII.
2325
dfcf3579
PE
2326 * fns.c (weak_hash_tables): Now static.
2327
5045092b
PE
2328 * fileio.c: Make symbols static if they're not exported.
2329 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2330 (Vwrite_region_annotation_buffers): Now static.
2331
57a96f5c
PE
2332 * eval.c: Make symbols static if they're not exported.
2333 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2334 * lisp.h (backtrace_list): Remove decl.
2335
35f08c38
PE
2336 * emacs.c: Make symbols static if they're not exported.
2337 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2338 (fatal_error_code, fatal_error_signal_hook, standard_args):
2339 Now static.
2340 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2341 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2342 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2343 * lisp.h (fatal_error_signal_hook): Remove decl.
2344 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2345
f44bd759
PE
2346 * editfns.c: Move a (normally-unused) function to its only use.
2347 * editfns.c, lisp.h (get_operating_system_release): Remove.
2348 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2349 worth the hassle of breaking this out.
2350
b532497d
PE
2351 * xterm.c: Make symbols static if they're not exported.
2352 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2353 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2354 (x_destroy_window, x_delete_display):
2355 Now static.
2356 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2357 (x_mouse_leave): Remove; unused.
2358 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2359 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2360 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2361 Remove decls.
2362 (x_mouse_leave): Declare only if WINDOWSNT.
2363 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2364 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2365 USE_X_TOOLKIT.
2366
1675728f
PE
2367 * ftxfont.c: Make symbols static if they're not exported.
2368 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2369 HAVE_FREETYPE.
2370 * font.h (ftxfont_driver): Likewise.
2371
e4cebfca
PE
2372 * xfns.c: Make symbols static if they're not exported.
2373 (x_last_font_name, x_display_info_for_name):
2374 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2375 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2376 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2377 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2378 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2379 (last_show_tip_args): Now static.
2380 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2381 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2382 (x_screen_planes): Remove; unused.
2383 * dispextern.h (x_screen_planes): Remove decl.
2384
5bf46f05
PE
2385 * dispnew.c: Make symbols static if they're not exported.
2386 * dispextern.h (redraw_garbaged_frames, scrolling):
2387 (increment_row_positions): Remove.
2388 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2389 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2390 Now static.
2391 (redraw_garbaged_frames): Remove; unused.
2392
435f4c28
PE
2393 * xfaces.c: Make symbols static if they're not exported.
2394 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2395 Remove decls.
2396 * xterm.h (defined_color): Remove decls.
2397 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2398 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2399 (menu_face_changed_default, defined_color, free_realized_face):
2400 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2401 (ascii_face_of_lisp_face): Remove; unused.
2402
8524aef3
PE
2403 * xdisp.c: Make symbols static if they're not exported.
2404 * dispextern.h (scratch_glyph_row, window_box_edges):
2405 (glyph_to_pixel_coords, set_cursor_from_row):
2406 (get_next_display_element, set_iterator_to_next):
2407 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2408 (show_mouse_face): Remove decls
2409 * frame.h (message_buf_print): Likewise.
2410 * lisp.h (pop_message, set_message, check_point_in_composition):
2411 Likewise.
2412 * xterm.h (set_vertical_scroll_bar): Likewise.
2413 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2414 (message_buf_print, scratch_glyph_row, displayed_buffer):
2415 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2416 (get_next_display_element, show_mouse_face, window_box_edges):
2417 (frame_to_window_pixel_xy, check_point_in_composition):
2418 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2419 (glyph_to_pixel_coords): Remove; unused.
2420
16390cd2
PE
2421 * dired.c (file_name_completion): Now static.
2422
2423 * dbusbind.c (xd_in_read_queued_messages): Now static.
2424
a25f4dfa
PE
2425 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2426 * data.c (circular_list_error): Remove.
2427
14a9c8df
PE
2428 * commands.h (last_point_position, last_point_position_buffer):
2429 (last_point_position_window): Remove decls.
2430 * keyboard.c: Make these variables static.
2431
04f2d78b
CB
2432 * coding.h (coding, code_convert_region, encode_coding_gap):
2433 Remove decls.
74ab6df5
PE
2434 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2435 (iso_code_class, detect_coding, code_convert_region): Now static.
2436 (encode_coding_gap): Remove; unused.
2437
38dfbee1
PE
2438 * chartab.c (chartab_chars, chartab_bits): Now static.
2439
a2cb4e63
PE
2440 * charset.h (charset_iso_8859_1): Remove decl.
2441 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2442 Now static.
2443
127198fd
PE
2444 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2445 * ccl.c (Vccl_program_table): Now static.
2446 (check_ccl_update): Remove; unused.
2447
d85b608f
PE
2448 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2449 * category.h: ... from here.
2450 * category.c (check_category_table, set_category_set): Now static.
2451
31cd66f3
PE
2452 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2453 * lisp.h: Remove these decls.
2454
c358e587
PE
2455 * buffer.c (buffer_count): Remove unused var.
2456
e78aecca
PE
2457 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2458 so that it's not optimized away.
2459 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2460 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2461 exported only to the debugger.
2462
e192d7d3 2463 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2464 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2465
92470028
PE
2466 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2467 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2468 was inaccessible from Lisp.
2469 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2470 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2471
244ed907
PE
2472 alloc.c: Import and export fewer symbols, and remove unused items.
2473 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2474 is defined.
2475 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2476 it's not optimized away by whole-program optimization.
2477 (message_enable_multibyte, free_misc): Remove.
2478 (catchlist, handlerlist, mark_backtrace):
2479 Declare only if BYTE_MARK_STACK.
2480 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2481 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2482 (message_enable_multibyte): Remove decl.
2483 (free_misc, interval_free_list, float_block, float_block_index):
2484 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2485 (cons_free_list, last_marked_index):
2486 Now static.
2487 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2488 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2489 (mark_backtrace): Define only if BYTE_MARK_STACK.
2490 * xdisp.c (message_enable_multibyte): Now static.
2491
61c2b50e 2492 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2493 This makes it easier for human readers (and static analyzers)
2494 to see whether these variables are used from other modules.
2495 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2496 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2497 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2498 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2499 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2500 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2501 * xmenu.c, xselect.c:
2502 Declare Q* vars static if they are not used in other modules.
2503 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2504 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2505 Remove decls of unexported vars.
2506 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2507
95c82688
PE
2508 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2509
16a97296
PE
2510 Make Emacs functions such as Fatom 'static' by default.
2511 This makes it easier for human readers (and static analyzers)
2512 to see whether these functions can be called from other modules.
2513 DEFUN now defines a static function. To make the function external
2514 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2515 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2516 (Finit_image_library):
16a97296
PE
2517 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2518 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2519 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2520 Remove decls, since these functions are now static.
2521 (Funintern, Fget_internal_run_time): New decls, since these functions
2522 were already external.
95c82688 2523
16a97296
PE
2524 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2525 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2526 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2527 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2528 * keyboard.c, keymap.c, lread.c:
2529 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2530 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2531 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2532 Mark functions with DEFUE instead of DEFUN,
2533 if they are used in other modules.
2534 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2535 decls for now-static functions.
2536 * buffer.h (Fdelete_overlay): Remove decl.
2537 * callproc.c (Fgetenv_internal): Mark as internal.
2538 * composite.c (Fremove_list_of_text_properties): Remove decl.
2539 (Fcomposition_get_gstring): New forward static decl.
2540 * composite.h (Fcomposite_get_gstring): Remove decl.
2541 * dired.c (Ffile_attributes): New forward static decl.
2542 * doc.c (Fdocumntation_property): New forward static decl.
2543 * eval.c (Ffetch_bytecode): New forward static decl.
2544 (Funintern): Remove extern decl; now in .h file where it belongs.
2545 * fileio.c (Fmake_symbolic_link): New forward static decl.
2546 * image.c (Finit_image_library): New forward static decl.
2547 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2548 * intervals.h (Fprevious_property_change):
2549 (Fremove_list_of_text_properties): Remove decls.
2550 * keyboard.c (Fthis_command_keys): Remove decl.
2551 (Fcommand_execute): New forward static decl.
2552 * keymap.c (Flookup_key): New forward static decl.
2553 (Fcopy_keymap): Now static.
2554 * keymap.h (Flookup_key): Remove decl.
2555 * process.c (Fget_process): New forward static decl.
2556 (Fprocess_datagram_address): Mark as internal.
2557 * syntax.c (Fsyntax_table_p): New forward static decl.
2558 (skip_chars): Remove duplicate decl.
2559 * textprop.c (Fprevious_property_change): New forward static decl.
2560 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2561 Now internal.
2562 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2563 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2564
785bbd42
PE
2565 * editfns.c (Fformat): Remove unreachable code.
2566
8b913b57
AS
25672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2568
2569 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2570 change. (Bug#8496)
2571
a6744a35
EZ
25722011-04-13 Eli Zaretskii <eliz@gnu.org>
2573
2574 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2575 when at ZV. (Bug#8487)
2576
e7974947
AS
25772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2578
baad03f0
AS
2579 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2580 (Bug#8437)
2581 * keyboard.c (parse_tool_bar_item): Likewise.
2582 * sound.c (sound_cleanup, alsa_close): Likewise.
2583 * termcap.c (tgetent): Likewise.
2584 * xfns.c (x_default_font_parameter): Likewise.
2585 * xsettings.c (read_and_apply_settings): Likewise.
2586
e7974947
AS
2587 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2588 (overrun_check_free): Protoize.
2589
28272684
PE
25902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2593 since callers should never pass a negative size.
2594 Change the signature to match that of plain 'read' and 'write'; see
2595 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2596 * lisp.h: Update prototypes of emacs_write and emacs_read.
2597
11997c76
EZ
25982011-04-11 Eli Zaretskii <eliz@gnu.org>
2599
2600 * xdisp.c (redisplay_window): Don't try to determine the character
2601 position of the scroll margin if the window start point w->startp
e896f03c 2602 is outside the buffer's accessible region. (Bug#8468)
11997c76 2603
8a2cbd72
EZ
26042011-04-10 Eli Zaretskii <eliz@gnu.org>
2605
2606 Fix write-region and its subroutines for buffers > 2GB.
2607 * fileio.c (a_write, e_write): Modify declaration of arguments and
2608 local variables to support buffers larger than 2GB.
2609 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2610
2611 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2612 argument, local variables, and return value.
2613
2614 * lisp.h: Update prototypes of emacs_write and emacs_read.
2615
2616 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2617
4073e537 26182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2619
1ebfdcb6
PE
2620 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2621
b2ded58d
PE
2622 Fix more problems found by GCC 4.6.0's static checks.
2623
7d66342c
PE
2624 * xdisp.c (vmessage): Use a better test for character truncation.
2625
bbf47d44
PE
2626 * charset.c (load_charset_map): <, not <=, for optimization,
2627 and to avoid potential problems with integer overflow.
9248994d 2628 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2629 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2630 * editfns.c (Fformat): Likewise.
1e69125e 2631 * syntax.c (skip_chars): Likewise.
3befa583 2632
e3019616
PE
2633 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2634 This also lets GCC 4.6.0 generate slightly better loop code.
2635
becfa255
PE
2636 * callint.c (Fcall_interactively): <, not <=, for optimization.
2637 (Fcall_interactively): Count the number of arguments produced,
2638 not the number of arguments given. This is simpler and lets GCC
2639 4.6.0 generate slightly better code.
2640
dae0cd48
PE
2641 * ftfont.c: Distingish more carefully between FcChar8 and char.
2642 The previous code passed unsigned char * to a functions like
2643 strlen and xstrcasecmp that expect char *, which does not
2644 conform to the C standard.
2645 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2646 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2647 char * when the C standard requires it.
2648
76032d70
PE
2649 * keyboard.c (read_char): Remove unused var.
2650
eb3f1cc8
PE
2651 * eval.c: Port to Windows vsnprintf (Bug#8435).
2652 Include <limits.h>.
2653 (SIZE_MAX): Define if the headers do not.
2654 (verror): Do not give up if vsnprintf returns a negative count.
2655 Instead, grow the buffer. This ports to Windows vsnprintf, which
2656 does not conform to C99. Problem reported by Eli Zaretskii.
2657 Also, simplify the allocation scheme, by avoiding the need for
2658 calling realloc, and removing the ALLOCATED variable.
2659
70476b54
PE
2660 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2661
12020a9e
PE
2662 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2663 But keep the doprint source code for now, as we might revamp it
2664 and use it again (Bug#8435).
ea6c7ae6
PE
2665 * lisp.h (doprnt): Remove.
2666 * Makefile.in (base_obj): Remove doprnt.o.
2667 * deps.mk (doprnt.o): Remove.
2668
5fdb398c
PE
2669 error: Print 32- and 64-bit integers portably (Bug#8435).
2670 Without this change, on typical 64-bit hosts error ("...%d...", N)
2671 was used to print both 32- and 64-bit integers N, which relied on
2672 undefined behavior.
2673 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2674 New macro.
2675 * lisp.h (error, verror): Mark as printf-like functions.
2676 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2677 Report overflow in size calculations when allocating printf buffer.
2678 Do not truncate output string at its first null byte.
2679 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2680 Truncate the output at a character boundary, since vsnprintf does not
2681 do that.
2682 * charset.c (check_iso_charset_parameter): Convert internal
2683 character to string before calling 'error', since %c now has the
2684 printf meaning.
2685 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2686 overflow when computing char to be passed to 'error'. Do not
2687 pass Lisp_Object to 'error'; pass the integer instead.
2688 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2689 formatted with plain %d.
2690
b189fa66
PE
2691 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2692
bff87ef0
PE
2693 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2694
7e2cac20
PE
2695 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2696
ce4d90b5
PE
2697 * xterm.c (x_catch_errors): Remove duplicate declaration.
2698
266c9547
PE
2699 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2700
79c49ad2
PE
2701 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2702
368f4090
JM
27032011-04-10 Jim Meyering <meyering@redhat.com>
2704
2705 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2706 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2707 return ssize_t not "int", and use size_t as the buffer length.
2708 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2709 * gnutls.h: Update declarations.
2710 * process.c (read_process_output): Use ssize_t, to match.
2711 (send_process): Likewise.
2712
a32d4040
CY
27132011-04-09 Chong Yidong <cyd@stupidchicken.com>
2714
2715 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2716
8546720e 27172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2718
04f2d78b
CB
2719 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2720 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2721
8546720e
GM
2722 * xterm.c (handle_one_xevent):
2723 * xmenu.c (create_and_show_popup_menu):
2724 * xselect.c (x_decline_selection_request)
2725 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2726
0a2f5c1a 27272011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2728
2729 Fix some uses of `int' instead of EMACS_INT.
2730 * search.c (string_match_1, fast_string_match)
2731 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2732 (scan_buffer, find_next_newline_no_quit)
2733 (find_before_next_newline, search_command, Freplace_match)
2734 (Fmatch_data): Make some `int' variables be EMACS_INT.
2735
2736 * xdisp.c (display_count_lines): 3rd argument and return value now
2737 EMACS_INT. All callers changed.
2738 (pint2hrstr): Last argument is now EMACS_INT.
2739
2740 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2741 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2742 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2743 (decode_coding_utf_16, decode_coding_emacs_mule)
2744 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2745 (decode_coding_ccl, decode_coding_charset)
2746 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2747 (decode_coding_iso_2022, decode_coding_emacs_mule)
2748 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2749 <char_offset, last_offset>: Declare EMACS_INT.
2750 (encode_coding_utf_8, encode_coding_utf_16)
2751 (encode_coding_emacs_mule, encode_invocation_designation)
2752 (encode_designation_at_bol, encode_coding_iso_2022)
2753 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2754 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2755 Declare EMACS_INT.
2756 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2757 (encode_invocation_designation): Last argument P_NCHARS is now
2758 EMACS_INT.
2759 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2760 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2761
2762 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2763 All users changed.
2764
2765 * ccl.c (Fccl_execute_on_string): Declare some variables
2766 EMACS_INT.
2767
8546720e 27682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2769
2770 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2771
4e19a977
CS
27722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2773
2774 * process.c (Fformat_network_address): Doc fix.
2775
87302331
R
27762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2777
2778 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2779
cbb59342
CY
27802011-04-08 Chong Yidong <cyd@stupidchicken.com>
2781
2782 * keyboard.c (read_char): Call Lisp function help-form-show,
2783 instead of using internal_with_output_to_temp_buffer.
2784 (Qhelp_form_show): New var.
e0d38eeb 2785 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2786
2787 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2788
2789 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2790
e67a13ab
CY
27912011-04-06 Chong Yidong <cyd@stupidchicken.com>
2792
04f2d78b
CB
2793 * process.c (Flist_processes): Remove to Lisp.
2794 (list_processes_1): Delete.
e67a13ab 2795
973f782d
EZ
27962011-04-06 Eli Zaretskii <eliz@gnu.org>
2797
7c106b1e
EZ
2798 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2799
973f782d
EZ
2800 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2801
41cf7d1a 28022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2803
ca23cc88
PE
2804 Fix more problems found by GCC 4.6.0's static checks.
2805
f390e2d5
PE
2806 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2807
42eea0d0
PE
2808 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2809
b69769da 2810 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2811
f9541e84
PE
2812 * xdisp.c (vmessage): Mark as a printf-like function.
2813
13841b55
PE
2814 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2815
c136c10f
PE
2816 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2817
5e2d4a30
PE
2818 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2819 printf-like functions.
2820 (tiff_load): Add casts to remove these marks before passing them
2821 to system-supplied API.
2822
583f48b9
PE
2823 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2824
b25d760e
PE
2825 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2826 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2827 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2828 directly, rather than having caller test rule sign. This avoids
2829 some unnecessary tests.
2830 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2831 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2832 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2833
bc7b6697 2834 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2835 (xfont_open): Avoid unnecessary tests.
bc7b6697 2836
27ccc379
PE
2837 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2838
dcd5c89a
PE
2839 * composite.h, composite.c (composition_gstring_put_cache):
2840 Use EMACS_INT, not int, for length.
2841
b13a45c6
PE
2842 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2843 breaking out part of COMPOSITION_DECODE_RULE.
2844 (COMPOSITION_DECODE_RULE): Use it.
2845 * composite.c (get_composition_id): Remove unused local vars,
2846 by using the new macro.
2847
1e792e4d
PE
2848 * textprop.c (set_text_properties_1): Change while to do-while,
2849 since the condition is always true at first.
2850
dc6c6455 2851 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2852 (interval_deletion_adjustment): Return unsigned value.
2853 All uses changed.
dc6c6455 2854
aba7731a
PE
2855 * process.c (list_processes_1, create_pty, read_process_output):
2856 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2857 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2858 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2859 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2860 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2861
fdfc4bf3
PE
2862 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2863
fca8fe46 2864 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2865 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2866
06a0259a 2867 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2868 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2869 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2870
e7b9e80f
PE
2871 * print.c (print_error_message): Avoid int overflow.
2872
56201685
PE
2873 * font.c (font_list_entities): Redo for clarity,
2874 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2875
78834453 2876 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2877 (font_score): Avoid potential overflow in diff calculation.
78834453 2878
0bc0b309 2879 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2880 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2881
e610eaca
PE
2882 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2883
b895abce
PE
2884 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2885 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2886 can always succeed if overflow has undefined behavior.
2887
1f1d9321 2888 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2889 (wordify): Omit three unnecessary tests.
1f1d9321 2890
c59478bc
PE
2891 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2892 All callers changed. This avoids the need for an unused var.
2893
79b73827
PE
2894 * casefiddle.c (casify_region): Remove var that is set but not used.
2895
a4db5dfe
PE
2896 * dired.c (file_name_completion): Remove var that is set but not used.
2897
43aae36e
PE
2898 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2899
2a47c44d 2900 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2901 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2902
a37c69bf
PE
2903 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2904 Check for integer overflow on size calculations.
2905
328ab8e7
PE
2906 * buffer.c (Fprevious_overlay_change): Remove var that is set
2907 but not used.
2908
e5a2a5cb
PE
2909 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2910 Remove vars that are set but not used.
8d84a6eb 2911 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2912 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2913
a60e5f68
PE
2914 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2915
f661cb61 2916 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2917 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2918
f0397f5a
PE
2919 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2920 that are set but not used.
2921
8664db06 2922 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2923 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2924
6abdaa4a
PE
2925 * xselect.c (x_get_local_selection, x_handle_property_notify):
2926 Remove vars that are set but not used.
2927
0ce7538d 2928 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2929 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2930
9ae848fc
PE
2931 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2932 Remove var that is set but not used.
0b918413
PE
2933 (scroll_bar_windows_size): Now size_t, not int.
2934 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2935 Check for overflow.
9ae848fc 2936
a5a62657
PE
2937 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2938 (map_tty_color) [!defined MSDOS]: Likewise.
2939
5c5cdd39
PE
2940 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2941
66ebf983
PE
2942 * coding.c: Remove vars that are set but not used.
2943 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2944 All callers changed.
2945 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2946 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2947 (decode_coding_charset): Remove vars that are set but not used.
2948
1be4d761
PE
2949 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2950 that is set but not used.
2951
47553fa8
PE
2952 * print.c (print_object): Remove var that is set but not used.
2953
1f7196bf 2954 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2955 The gnulib version avoids calling malloc in the usual case,
2956 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2957 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2958 * filelock.c (current_lock_owner): Likewise.
2959 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2960 * sysdep.c: Include allocator.h, careadlinkat.h.
2961 (emacs_no_realloc_allocator): New static constant.
2962 (emacs_readlink): New function.
fdb61804
PE
2963 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2964 ../lib/careadlinkat.h.
d1fdcab7 2965
f84c17c7
SM
29662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2967
2968 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2969 first non-nil return value).
2970
ef3862ad
JD
29712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2972
2973 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2974 if not defined (Bug#8403).
2975
376a7006
JB
29762011-04-02 Juanma Barranquero <lekktu@gmail.com>
2977
2978 * xdisp.c (display_count_lines): Remove parameter `start',
2979 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2980 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2981 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2982 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2983 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2984 and thereabouts. All callers changed.
2985 (get_per_char_metric): Remove parameter `f', unused since
2986 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2987
6ca3801d
JM
29882011-04-02 Jim Meyering <meyering@redhat.com>
2989
2990 do not dereference NULL upon failed strdup
2991 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2992 (ns_get_family): Likewise.
2993
d8e2b5ba
JB
29942011-04-02 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2997
8c74fcbd
JD
29982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2999
3000 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3001 later (Bug#8403).
3002
7200d79c
SM
30032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3004
03408648 3005 Add lexical binding.
7200d79c 3006
03408648
SM
3007 * window.c (Ftemp_output_buffer_show): New fun.
3008 (Fsave_window_excursion):
3009 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3010
3011 * lread.c (lisp_file_lexically_bound_p): New function.
3012 (Fload): Bind Qlexical_binding.
3013 (readevalloop): Remove `evalfun' arg.
3014 Bind Qinternal_interpreter_environment.
3015 (Feval_buffer): Bind Qlexical_binding.
3016 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3017 Mark as dynamic.
3018 (syms_of_lread): Declare `lexical-binding'.
3019
3020 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3021
3022 * keyboard.c (eval_dyn): New fun.
3023 (menu_item_eval_property): Use it.
ca105506
SM
3024
3025 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3026
03408648
SM
3027 * fns.c (concat, mapcar1): Accept byte-code-functions.
3028
3029 * eval.c (Fsetq): Handle lexical vars.
3030 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3031 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3032 (FletX, Flet): Obey lexical binding.
3033 (Fcommandp): Handle closures.
3034 (Feval): New `lexical' arg.
3035 (eval_sub): New function extracted from Feval. Use it almost
3036 everywhere where Feval was used. Look up vars in lexical env.
3037 Handle closures.
3038 (Ffunctionp): Move from subr.el.
3039 (Ffuncall): Handle closures.
3040 (apply_lambda): Remove `eval_flags'.
3041 (funcall_lambda): Handle closures and new byte-code-functions.
3042 (Fspecial_variable_p): New function.
3043 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3044 but without exporting it to Lisp.
23aba0ea 3045
23aba0ea 3046 * doc.c (Fdocumentation, store_function_docstring):
03408648 3047 * data.c (Finteractive_form): Handle closures.
23aba0ea 3048
03408648
SM
3049 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3050 interactive spec.
ba83908c 3051
04f2d78b
CB
3052 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3053 New byte-codes.
03408648
SM
3054 (exec_byte_code): New function extracted from Fbyte_code to handle new
3055 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3056
03408648 3057 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3058
03408648 3059 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3060
e2abce01
JB
30612011-03-31 Juanma Barranquero <lekktu@gmail.com>
3062
3063 * xdisp.c (redisplay_internal): Fix prototype.
3064
63696a73 30652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3066
63696a73 3067 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3068 (try_scrolling): Use it when setting scroll_limit.
3069 Limit scrolling to 100 screen lines.
63696a73
EZ
3070 (redisplay_window): Even when falling back on "recentering",
3071 position point in the window according to scroll-conservatively,
3072 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3073
3074 (try_scrolling): When point is above the window, allow searching
3075 as far as scroll_max, or one screenful, to compute vertical
3076 distance from PT to the scroll margin position. This prevents
3077 try_scrolling from unnecessarily failing when
3078 scroll-conservatively is set to a value slightly larger than the
3079 window height. Clean up the case of PT below the margin at bottom
3080 of window: scroll_max can no longer be INT_MAX. When aggressive
3081 scrolling is in use, don't let point enter the opposite scroll
3082 margin as result of the scroll.
3083 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3084 threshold of 100 lines for never-recentering scrolling.
3085
e4cc2dfc
JB
30862011-03-31 Juanma Barranquero <lekktu@gmail.com>
3087
3088 * dispextern.h (move_it_by_lines):
3089 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3090 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3091 (message_log_check_duplicate): Remove parameters `prev_bol' and
3092 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3093 (redisplay_internal): Remove parameter `preserve_echo_area',
3094 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3095
3096 * indent.c (Fvertical_motion):
3097 * window.c (window_scroll_pixel_based, Frecenter):
3098 Don't pass `need_y_p' to `move_it_by_lines'.
3099
1c470562
SM
31002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3101
44f230aa
SM
3102 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3103 steal a few bits to be more compact.
3104 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3105 Remove unneeded casts.
3106
1c470562
SM
3107 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3108
888adce9
ZK
31092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3110
3111 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3112 binding" message (bug#7967).
3113
f838ed7b
PE
31142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3115
77861b95
PE
3116 Fix more problems found by GCC 4.6.0's static checks.
3117
de6dbc14
PE
3118 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3119 Remove unused local var.
3120
f838ed7b
PE
3121 * editfns.c (Fmessage_box): Remove unused local var.
3122
792c7b2b
PE
3123 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3124 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3125 Omit unused local vars.
c499e557 3126 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3127 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3128 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3129 Omit unused local var.
3130
ba0165e1
PE
3131 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3132 Don't assume string length fits in int.
32ad8845 3133 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3134 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3135
3c59b4c9
PE
3136 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3137 instead of alloca (Bug#8344).
3138
a3eed478 3139 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3140 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3141
eb4d412d
PE
3142 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3143
1658b401
PE
3144 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3145 concerns.
3146
3147 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3148
3149 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3150
9a2c6e05
PE
3151 * keyboard.c (syms_of_keyboard): Use the same style as later
3152 in this function when indexing through an array. This also
3153 works around GCC bug 48267.
3154
03d0a109
PE
3155 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3156
44f730c8
PE
3157 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3158
fe75f926
PE
3159 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3160 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3161
ffa8c828
PE
3162 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3163 This avoids undefined behavior on integer overflow, and is a bit
3164 more convenient anyway since it is compared to a size_t variable.
3165
c5101a77
PE
3166 Variadic C functions now count arguments with size_t, not int.
3167 This avoids an unnecessary limitation on 64-bit machines, which
3168 caused (substring ...) to crash on large vectors (Bug#8344).
3169 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3170 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3171 All variadic functions and their callers changed accordingly.
c5101a77
PE
3172 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3173 * data.c (arith_driver, float_arith_driver): Likewise.
3174 * editfns.c (general_insert_function): Likewise.
3175 * eval.c (struct backtrace.nargs, interactive_p)
3176 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3177 (funcall_lambda, mark_backtrace): Likewise.
3178 * fns.c (concat): Likewise.
3179 * frame.c (x_set_frame_parameters): Likewise.
3180 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3181 0 if not found, not -1. All callers changed.
3182
dd3f25f7
PE
3183 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3184 (stack_copy_size): Now size_t, not int.
3185 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3186
461c2ab9
JB
31872011-03-28 Juanma Barranquero <lekktu@gmail.com>
3188
3189 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3190 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3191 All callers changed.
3192
3193 * lisp.h (multibyte_char_to_unibyte):
3194 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3195 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3196 * character.h (CHAR_TO_BYTE8):
3197 * cmds.c (internal_self_insert):
3198 * editfns.c (general_insert_function):
3199 * keymap.c (push_key_description):
3200 * search.c (Freplace_match):
3201 * xdisp.c (message_dolog, set_message_1): All callers changed.
3202
f6d62986
SM
32032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3204
3205 * keyboard.c (safe_run_hook_funcall): New function.
3206 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3207 don't set the hook to nil, but remove the offending function instead.
3208 (Qcommand_hook_internal): Remove, unused.
3209 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3210 Vcommand_hook_internal.
3211
3212 * eval.c (enum run_hooks_condition): Remove.
3213 (funcall_nil, funcall_not): New functions.
3214 (run_hook_with_args): Call each function through a `funcall' argument.
3215 Remove `cond' argument, now redundant.
3216 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3217 (Frun_hook_with_args_until_failure): Adjust accordingly.
3218 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3219
1db5b1ad
JB
32202011-03-28 Juanma Barranquero <lekktu@gmail.com>
3221
3222 * dispextern.h (string_buffer_position): Remove declaration.
3223
3224 * print.c (strout): Remove parameter `multibyte', unused since
3225 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3226
3227 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3228 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3229 All callers changed.
3230
3231 * w32.c (_wsa_errlist): Use braces for struct initializers.
3232
3233 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3234 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3235 All callers changed.
3236 (string_buffer_position): Likewise. Also, make static (it's never
3237 used outside xdisp.c).
3238 (cursor_row_p): Remove parameter `w', unused since
3239 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3240 (decode_mode_spec): Remove parameter `precision', introduced during
3241 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3242 All callers changed.
3243
5ffb62aa
JD
32442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3245
3246 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3247
461c2ab9 32482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3249
3250 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3251 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3252 (ns_update_auto_hide_menu_bar): New functions.
3253 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3254 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3255 ns_constrain_all_frames.
3256 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3257 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3258
5c380ffb
JD
32592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3260
3261 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3262
9af30bdf
GM
32632011-03-27 Glenn Morris <rgm@gnu.org>
3264
3265 * syssignal.h: Replace RETSIGTYPE with void.
3266 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3267 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3268 Replace SIGTYPE with void everywhere.
3269 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3270 * s/template.h (SIGTYPE): Remove commented out definition.
3271
e2abce01
JB
32722011-03-26 Eli Zaretskii <eliz@gnu.org>
3273
3274 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3275 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3276
f868cd8a
JB
32772011-03-26 Juanma Barranquero <lekktu@gmail.com>
3278
59eb0929
JB
3279 * w32.c (read_unc_volume): Use parameter `henum', instead of
3280 global variable `wget_enum_handle'.
3281
3282 * keymap.c (describe_vector): Remove parameters `indices' and
3283 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3284 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3285
f868cd8a
JB
3286 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3287
3288 * keyboard.c (timer_check): Remove parameter `do_it_now',
3289 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3290 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3291 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3292
3293 * keyboard.c (read_char):
3294 * w32menu.c (w32_menu_display_help):
3295 * xmenu.c (show_help_event, menu_help_callback):
3296 Adjust calls to `show_help_echo'.
3297
3298 * gtkutil.c (xg_maybe_add_timer):
3299 * keyboard.c (readable_events):
3300 * process.c (wait_reading_process_output):
3301 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3302
3303 * insdel.c (adjust_markers_gap_motion):
3304 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3305 (gap_left, gap_right): Don't call it.
3306
2ecf6fdb
CY
33072011-03-25 Chong Yidong <cyd@stupidchicken.com>
3308
3309 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3310 incurred during fontification.
3311
6b1f9ba4
JB
33122011-03-25 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3315 (DEFVAR_PER_BUFFER): Don't pass it.
3316
3317 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3318 (scrolling_window): Don't pass it.
3319
0f4a96b5
JB
33202011-03-25 Juanma Barranquero <lekktu@gmail.com>
3321
3322 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3323
3324 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3325 and `suffix'.
3326 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3327 of variables specific to SELinux and computation of `encoded_absname'.
3328
3329 * image.c (XPutPixel): Remove unused variable `height'.
3330
3331 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3332
3333 * unexw32.c (get_section_info): Remove unused variable `section'.
3334
3335 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3336 (system_process_attributes): Remove unused variable `sess'.
3337 (sys_read): Remove unused variable `err'.
3338
3339 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3340 (w32_wnd_proc): Remove unused variable `isdead'.
3341 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3342 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3343 (x_create_tip_frame): Remove unused variable `tem'.
3344
3345 * w32inevt.c (w32_console_read_socket):
3346 Remove unused variable `no_events'.
3347
3348 * w32term.c (x_draw_composite_glyph_string_foreground):
3349 Remove unused variable `width'.
3350
1149507c
JB
33512011-03-24 Juanma Barranquero <lekktu@gmail.com>
3352
3353 * w32term.c (x_set_glyph_string_clipping):
3354 Don't pass uninitialized region to CombineRgn.
3355
9c88f339
JB
33562011-03-23 Juanma Barranquero <lekktu@gmail.com>
3357
3358 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3359 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3360 (Fx_close_connection): Remove unused variable `i'.
3361
3362 * w32font.c (w32font_draw): Return number of glyphs.
3363 (w32font_open_internal): Remove unused variable `i'.
3364 (w32font_driver): Add missing initializer.
3365
3366 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3367 (fill_in_menu): Remove unused variable `items_added'.
3368
3369 * w32term.c (last_mouse_press_frame): Remove static global variable.
3370 (w32_clip_to_row): Remove unused variable `f'.
3371 (x_delete_terminal): Remove unused variable `i'.
3372
3373 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3374 (NOTHING): Remove unused static global variable.
3375 (uniscribe_check_otf): Remove unused variable `table'.
3376 (uniscribe_font_driver): Add missing initializers.
3377
dee091a3
JD
33782011-03-23 Julien Danjou <julien@danjou.info>
3379
3380 * term.c (Fsuspend_tty, Fresume_tty):
3381 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3382 * window.c (temp_output_buffer_show):
3383 * insdel.c (signal_before_change):
3384 * frame.c (Fhandle_switch_frame):
3385 * fileio.c (Fdo_auto_save):
3386 * emacs.c (Fkill_emacs):
3387 * editfns.c (save_excursion_restore):
3388 * cmds.c (internal_self_insert):
3389 * callint.c (Fcall_interactively):
3390 * buffer.c (Fkill_all_local_variables):
3391 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3392 Use Frun_hooks.
0f4a96b5 3393 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3394 unconditionnaly since it does the check itself.
3395
2c520ab5 33962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3397
c9c49752
PE
3398 Fix more problems found by GCC 4.5.2's static checks.
3399
8abc3f12
PE
3400 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3401 the first time through the loop, since we know p0 < p1 then.
3402 This also avoids a gcc -Wstrict-overflow warning.
3403
a2d26660
PE
3404 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3405 leading to a memory leak, possible in functions like
3406 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3407 of objects (Bug#8318).
a2d26660 3408
916c72e9
PE
3409 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3410 that could (at least in theory) be that large.
3411
19ab8a18
PE
3412 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3413 This is less likely to overflow, and avoids undefined behavior if
3414 overflow does occur. All callers changed. Use strtoul to scan
3415 for the unsigned long integer.
b7cbbd6f
PE
3416 (pint2hrstr): Simplify and tune code slightly.
3417 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3418
f0641eff
PE
3419 * scroll.c (do_scrolling): Work around GCC bug 48228.
3420 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3421
7f650bb9
PE
3422 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3423 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3424 (validate_x_resource_name): Simplify count usage.
3425 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3426
37dd57d1
PE
3427 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3428 fail (Bug#8306).
81e56e61 3429
699979fc 3430 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3431
401bf9b4
PE
3432 * process.c (Fmake_network_process): Use socklen_t, not int,
3433 where POSIX says socklen_t is required in portable programs.
3434 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3435 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3436 (Fmake_network_process, server_accept_connection):
3437 (wait_reading_process_output, read_process_output):
3438 Likewise.
3439
b93aacde
PE
3440 * process.c: Rename or move locals to avoid shadowing.
3441 (list_processes_1, Fmake_network_process):
3442 (read_process_output_error_handler, exec_sentinel_error_handler):
3443 Rename or move locals.
4dc343ee 3444 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3445 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3446 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3447 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3448 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3449
af8a867c 3450 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3451 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3452 Include tparam.h instead, since it declares them.
af8a867c
PE
3453 * cm.h (PC): Remove extern decl; tparam.h now does this.
3454 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3455 * terminfo.c: Include tparam.h, to check interfaces.
3456 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3457 (tparam): Adjust signature to match interface in tparam.h;
3458 this removes some undefined behavior. Check that outstring and len
3459 are zero, which they always are with Emacs.
3460 * tparam.h (PC, BC, UP): New extern decls.
3461
0248044d 3462 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3463 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3464
8ff096c1 3465 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3466 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3467 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3468 (ftfont_list): Remove unused local.
49eaafba
PE
3469 (get_adstyle_property, ftfont_pattern_entity):
3470 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3471 Rename locals to avoid shadowing.
8ff096c1 3472
e2be39f6
PE
3473 * xfont.c (xfont_list_family): Mark var as initialized.
3474
c9735e30
PE
3475 * xml.c (make_dom): Now static.
3476
8f5201ae
PE
3477 * composite.c (composition_compute_stop_pos): Rename local to
3478 avoid shadowing.
b246f932
PE
3479 (composition_reseat_it): Remove unused locals.
3480 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3481 (composition_update_it): Mark var as initialized.
11b61122
PE
3482 (find_automatic_composition): Mark vars as initialized,
3483 with a FIXME (Bug#8290).
8f5201ae 3484
760fbc2c
PE
3485 character.h: Rename locals to avoid shadowing.
3486 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3487 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3488 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3489 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3490 to avoid shadowing.
3491
ff08eb85
PE
3492 * textprop.c (property_change_between_p): Remove; unused.
3493
fc7bf025
PE
3494 * intervals.c (interval_start_pos): Now static.
3495
235d7abc
PE
3496 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3497
44f230aa
SM
3498 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3499 Rename locals to avoid shadowing.
3e7d6594 3500
50060332
PE
3501 * sound.c (wav_play, au_play, Fplay_sound_internal):
3502 Fix pointer signedness.
d01f234b 3503 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3504 (wav_play): Initialize a variable to 0, to prevent undefined
3505 behavior (Bug#8278).
50060332 3506
c4fc4e30
PE
3507 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3508
918436ed
PE
3509 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3510
c939f91b
PE
3511 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3512 clobbering (Bug#8298).
b9c7f648
PE
3513 * sysdep.c (sys_subshell): Likewise.
3514 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3515
6bd8c144
PE
3516 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3517 This should get cleaned up, so that child_setup has the
3518 same signature on all platforms.
3519
7710357c 3520 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3521 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3522
c59da222
CY
35232011-03-22 Chong Yidong <cyd@stupidchicken.com>
3524
3525 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3526 not to be necessary, and produces flickering.
3527
66b87493
GM
35282011-03-20 Glenn Morris <rgm@gnu.org>
3529
3530 * config.in: Remove file.
3531
45b6f6d5
JB
35322011-03-20 Juanma Barranquero <lekktu@gmail.com>
3533
3534 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3535 are now in src/globals.h.
3536 (syms_of_minibuf): Remove spurious & from previous change.
3537
3ec03f7e
LL
35382011-03-20 Leo <sdl.web@gmail.com>
3539
3540 * minibuf.c (completing-read-function): New variable.
3541 (completing-read-default): Rename from completing-read.
3542 (completing-read): Call completing-read-function.
3543
b14e3e21
CY
35442011-03-19 Juanma Barranquero <lekktu@gmail.com>
3545
3546 * xfaces.c (Fx_load_color_file):
3547 Read color file from absolute filename (bug#8250).
3548
f2b726e6
JB
35492011-03-19 Juanma Barranquero <lekktu@gmail.com>
3550
3551 * makefile.w32-in: Update dependencies.
3552
09f6ff02
EZ
35532011-03-17 Eli Zaretskii <eliz@gnu.org>
3554
3555 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3556
29a6015a
PE
35572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3558
a3a6c54e
PE
3559 Fix more problems found by GCC 4.5.2's static checks.
3560
b766f867
PE
3561 * process.c (make_serial_process_unwind, send_process_trap):
3562 (sigchld_handler): Now static.
3563
be02381c
PE
3564 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3565 That way, the code declares only the vars that it needs.
3566 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3567 * s/cygwin.h (PTY_ITERATION): Likewise.
3568 * s/darwin.h (PTY_ITERATION): Likewise.
3569 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3570
57048744
PE
3571 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3572 * process.c (allocate_pty): Don't declare stb unless it's needed.
3573
7914961c 3574 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3575 (CONSTANTLIM): Remove; unused.
3576 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3577 Define only if needed.
7914961c 3578
b3967b18
PE
3579 * unexelf.c (unexec): Name an expression,
3580 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3581 Use a different way to cause a compilation error if anyone uses
3582 n rather than nn, a way that does not involve shadowing.
73366a00 3583 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3584
29a6015a
PE
3585 * deps.mk (unexalpha.o): Remove; unused.
3586
43cfc33e 3587 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3588 * unexec.h: New file.
ce701a33
PE
3589 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3590 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3591 Depend on unexec.h.
3592 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3593 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3594 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3595 Change as necessary to match prototype in unexec.h.
ce701a33 3596
01f44d5a
PE
3597 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3598 shadowing.
4f63c6bb 3599 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3600
a6670b0b
PE
3601 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3602 Rename locals to avoid shadowing.
3603
cef2010d 3604 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3605 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3606
d4d7173a
PE
3607 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3608
f08b802a
PE
3609 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3610 warning when compiling print.c.
3611
3ddb0639
PE
3612 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3613 instead of using an uninitialized var.
5ad03b97 3614 (font_sort_entities): Mark var as initialized.
3ddb0639 3615
170a2692
PE
3616 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3617
e663c700
PE
3618 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3619 pointers to constants.
89bc529a 3620 (font_parse_fcname): Remove unused vars.
7b81e2d0 3621 (font_delete_unmatched): Now static.
ea838e10 3622 (font_get_spec): Remove; unused.
13a547c6
PE
3623 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3624 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3625 Rename or move locals to avoid shadowing.
e663c700 3626
2a80c887 3627 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3628 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3629
1384fa33 3630 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3631 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3632
8b2c52e9
PE
3633 * alloc.c (mark_backtrace): Move decl from here ...
3634 * lisp.h: ... to here, so that it can be checked.
3635
475545b5 3636 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3637 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3638 (lisp_indirect_variable): Name an expression,
3639 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3640 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3641
b1349114 3642 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3643 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3644 Use const pointer when appropriate.
b1349114 3645
a2928364
PE
3646 * lisp.h (get_system_name, get_operating_system_release):
3647 Move decls here, to check interfaces.
3648 * process.c (get_operating_system_release): Move decl to lisp.h.
3649 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3650 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3651 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3652 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3653 (Fformat_time_string, Fencode_time, Finsert_char):
3654 (Ftranslate_region_internal, Fformat):
3655 Rename or remove local vars to avoid shadowing.
9710023e 3656 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3657
a415e694
PE
3658 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3659 avoid shadowing.
3660
8ef4622d
PE
3661 * lisp.h (eassert): Check that the argument compiles, even if
3662 ENABLE_CHECKING is not defined.
3663
946f9a5b
PE
3664 * data.c (Findirect_variable): Name an expression, to avoid
3665 gcc -Wbad-function-cast warning.
112396d6 3666 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3667 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3668 (Fmake_variable_buffer_local, Fmake_local_variable):
3669 Mark variables as initialized.
52746918 3670 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3671
e5aab7e7 3672 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3673 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3674 Rename locals to avoid shadowing.
dff45157
PE
3675 (mark_stack): Move local variables into the #ifdef region where
3676 they're used.
7bc26fdb
PE
3677 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3678 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3679 needed otherwise.
3680 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3681 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3682 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3683
e5aab7e7
PE
3684 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3685 avoids undefined behavior in theory.
3686
4da60324
PE
3687 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3688
88043301
PE
3689 Use functions, not macros, for up- and down-casing (Bug#8254).
3690 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3691 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3692 to use the following functions instead of these macros.
3693 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3694 EMACS_INT, since callers assume the returned value fits in int.
3695 (upcase1): Likewise, for UPCASE_TABLE.
3696 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3697 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3698 the race-condition problem in the old DOWNCASE.
88043301 3699
19ed5445
PE
3700 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3701 Rename locals to avoid shadowing.
3702 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3703 (regex_compile, re_search_2, re_match_2_internal):
3704 Remove unused local vars.
952db0d7
PE
3705 (FREE_VAR): Rewrite so as not to use empty "else",
3706 which gcc can warn about.
da053e48 3707 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3708 (RETALLOC_IF): Define only if needed.
3709 (WORDCHAR_P): Likewise. This one is never needed, but is used
3710 only in a comment talking about a compiler bug, so put inside
3711 the #if 0 of that comment.
3712 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3713 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3714 Remove; unused.
19ed5445 3715
1f3561e4 3716 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3717 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3718 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3719
ded6f8f7
PE
3720 * search.c (simple_search): Remove unused var.
3721
dbd37a95
PE
3722 * dired.c (compile_pattern): Move decl from here ...
3723 * lisp.h: ... to here, so that it can be checked.
3724 (struct re_registers): New forward decl.
3725
7e47afad
PE
3726 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3727
85f24f61
PE
3728 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3729 All uses changed.
3730 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3731 Rename locals to avoid shadowing.
5671df8f 3732 (Fvertical_motion): Mark locals as initialized.
85f24f61 3733
181aa2be 3734 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3735 (casify_region): Mark local as initialized.
181aa2be 3736
930d429c
PE
3737 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3738
7082eac6
PE
3739 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3740 New macros, so that the caller can use some names other than
3741 gcpro1, gcpro2, etc.
3742 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3743 of the new macros.
3744 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3745 argument, for consistency with GCPRO2_VAR, etc: it is now the
3746 prefix of the variable, not the variable itself. All uses
3747 changed.
38b2c076
PE
3748 * dired.c (directory_files_internal, file_name_completion):
3749 Rename locals to avoid shadowing.
3750
15206ed9
PE
3751 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3752 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3753 dired.c's scmp function, had undefined behavior.
3754 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3755 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3756 * buffer.h: ... to here, because these macros use current_buffer,
3757 and the new implementation with inline functions needs to have
3758 current_buffer in scope now, rather than later when the macros
3759 are used.
3760 (downcase, upcase1): New static inline functions.
3761 (DOWNCASE, UPCASE1): Reimplement using these functions.
3762 This avoids undefined behavior in expressions like
3763 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3764 from race conditions in accessing the global variables
3765 case_temp1 and case_temp2.
3766 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3767 * lisp.h (case_temp1, case_temp2): Remove their decls.
3768 * character.h (ASCII_CHAR_P): Move from here ...
3769 * lisp.h: ... to here, so that the inline functions mentioned
3770 above can use them.
3771
4a6bea26
PE
3772 * dired.c (directory_files_internal_unwind): Now static.
3773
f14b7e14
PE
3774 * fileio.c (file_name_as_directory, directory_file_name):
3775 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3776 Now static.
2893f146
PE
3777 (file_name_as_directory): Use const pointers when appropriate.
3778 (Fexpand_file_name): Likewise. In particular, newdir might
3779 point at constant storage, so make it a const pointer.
fd4ead52 3780 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3781 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3782 signedness issues.
f839df0c
PE
3783 (Fset_file_times, Finsert_file_contents, auto_save_error):
3784 Rename locals to avoid shadowing.
f14b7e14 3785
5716756e 3786 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3787 (Ftry_completion, Fall_completions): Rename or remove locals
3788 to avoid shadowing.
5716756e 3789
b4c3046a
PE
3790 * marker.c (bytepos_to_charpos): Remove; unused.
3791
b45db522
PE
3792 * lisp.h (verify_bytepos, count_markers): New decls,
3793 so that gcc does not warn that these functions aren't declared.
3794
85876d07
PE
3795 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3796 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3797 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3798 (copy_text): Remove unused local var.
85876d07 3799
03d78a21 3800 * filelock.c (within_one_second): Now static.
b3dd38ab 3801 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3802
5df8f01b
PE
3803 * buffer.c (fix_overlays_before): Mark locals as initialized.
3804 (fix_start_end_in_overlays): Likewise. This function should be
3805 simplified by using pointers-to-pointers, but that's a different
3806 matter.
b1d876f1 3807 (switch_to_buffer_1): Now static.
8f54f30a
PE
3808 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3809 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3810
a70072c9 3811 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3812 Fix pointer signedness issue.
edced198
PE
3813 (sys_subshell): Mark local as volatile if checking for lint,
3814 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3815 (MAXPATHLEN): Define only if needed.
a70072c9 3816
a0977c44
PE
3817 * process.c (serial_open, serial_configure): Move decls from here ...
3818 * systty.h: ... to here, so that they can be checked.
3819
a884fdcc
PE
3820 * fns.c (get_random, seed_random): Move extern decls from here ...
3821 * lisp.h: ... to here, so that they can be checked.
3822
604efe86 3823 * sysdep.c (reset_io): Now static.
b8950c94 3824 (wait_for_termination_signal): Remove; unused.
604efe86 3825
38fc62d9
PE
3826 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3827 (copy_keymap_item, append_key, push_text_char_description):
3828 Now static.
1004a21a 3829 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3830 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3831 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3832 (describe_map_tree):
3833 Rename locals to avoid shadowing.
38fc62d9 3834
2f2650da
PE
3835 * keyboard.c: Declare functions static if they are not used elsewhere.
3836 (echo_char, echo_dash, cmd_error, top_level_2):
3837 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3838 (read_char, kbd_buffer_get_event, make_lispy_position):
3839 (make_lispy_event, make_lispy_movement, apply_modifiers):
3840 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3841 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3842 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3843 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3844 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3845
a053e86c 3846 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3847 (mark_kboards): Move decl here ...
3848 * alloc.c (mark_kboards): ... from here.
a053e86c 3849
4752793e
PE
3850 * lisp.h (force_auto_save_soon): New decl.
3851
74f10ca7 3852 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3853 (DEFINE_DUMMY_FUNCTION): New macro.
3854 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3855 Use it.
c03cd23f
PE
3856 (main): Add casts to avoid warnings
3857 if GCC considers string literals to be constants.
74f10ca7 3858
022e70d4
PE
3859 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3860
59d6fe83
PE
3861 * dbusbind.c: Pointer signedness fixes.
3862 (xd_signature, xd_append_arg, xd_initialize):
3863 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3864 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3865 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3866 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3867
78320123
PE
3868 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3869 if GCC considers string literals to be constants.
49cebcca 3870 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3871
35ac2a97
SM
38722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3873
fb103ca9
SM
3874 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3875 (print_preprocess, print_object): New macro to fix last change.
3876
35ac2a97
SM
3877 * print.c (print_preprocess): Don't forget font objects.
3878
62973b41
JB
38792011-03-16 Juanma Barranquero <lekktu@gmail.com>
3880
3881 * emacs.c (USAGE3): Doc fixes.
3882
0e48bb22
AS
38832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3884
3885 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3886 structure.
3887
7684e57b
JB
38882011-03-14 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * lisp.h (VWindow_system, Qfile_name_history):
3891 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3892 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3893 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3894
3895 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3896 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3897
3898 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3899 * w32console.c (detect_input_pending, read_input_pending)
3900 (encode_terminal_code):
3901 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3902 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3903 (w32_system_caret_y, Qfile_name_history):
3904 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3905 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3906 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3907 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3908 * w32proc.c (Qlocal, report_file_error):
3909 * w32term.c (Vwindow_system, updating_frame):
3910 * w32uniscribe.c (initialized, uniscribe_font_driver):
3911 Remove unneeded extern declarations.
3912
2aa46d6c
CY
39132011-03-14 Chong Yidong <cyd@stupidchicken.com>
3914
c96bbc66 3915 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3916
cffc6f3b
CY
39172011-03-13 Chong Yidong <cyd@stupidchicken.com>
3918
3919 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3920 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3921 These macros can no longer be used for assignment.
3922
44f230aa
SM
3923 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3924 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3925 (record_buffer_markers, fetch_buffer_markers): New functions for
3926 recording and fetching special buffer markers.
3927 (set_buffer_internal_1, set_buffer_temp): Use them.
3928
3929 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3930
3931 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3932
3933 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3934 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3935
3936 * xdisp.c (hscroll_window_tree):
3937 (reconsider_clip_changes): Use PT instead of BUF_PT.
3938
d251f04b
EZ
39392011-03-13 Eli Zaretskii <eliz@gnu.org>
3940
3941 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3942 $(EMACS_ROOT)/lib/intprops.h.
3943
f0c77cd1
PE
39442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3945
3eca4629
PE
3946 Fix more problems found by GCC 4.5.2's static checks.
3947
7c86ee98
PE
3948 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3949 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3950 (xg_free_frame_widgets): Make it clear that a local variable is
3951 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3952 (gdk_window_get_screen): Make it clear that this macro is needed
3953 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3954 (int_gtk_range_get_value): New function, which avoids a diagnostic
3955 from gcc -Wbad-function-cast.
3956 (xg_set_toolkit_scroll_bar_thumb): Use it.
3957 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3958 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3959 (get_utf8_string, xg_get_file_with_chooser):
3960 Rename locals to avoid shadowing.
3961 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3962
41729b81
PE
3963 * xgselect.c (xg_select): Remove unused var.
3964
f0c77cd1
PE
3965 * image.c (four_corners_best): Mark locals as initialized.
3966 (gif_load): Initialize transparent_p to zero (Bug#8238).
3967 Mark another local as initialized.
ec6cf4c6 3968 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3969
ce0ad53d 3970 * image.c (clear_image_cache): Now static.
d5d5a617 3971 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3972 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3973 (x_edge_detection): Remove unnecessary cast that
3974 gcc -Wbad-function-cast diagnoses.
2037898d 3975 (gif_load): Fix pointer signedness.
6ae141d6
PE
3976 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3977 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3978
33383987 39792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3980
d32df629
PE
3981 Improve quality of tests for time stamp overflow.
3982 For example, without this patch (encode-time 0 0 0 1 1
3983 1152921504606846976) returns the obviously-bogus value (-948597
3984 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3985 reports time overflow. See
3986 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3987 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3988 * editfns.c: Include limits.h and intprops.h.
3989 (TIME_T_MIN, TIME_T_MAX): New macros.
3990 (time_overflow): Move earlier, to before first use.
3991 (hi_time, lo_time): New functions, for an accurate test for
3992 out-of-range times.
3993 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3994 (Fget_internal_run_time): Don't assume time_t fits in int.
3995 (make_time): Use list2 instead of Fcons twice.
3996 (Fdecode_time): More accurate test for out-of-range times.
3997 (check_tm_member): New function.
3998 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3999 (lisp_time_argument): Don't rely on undefined left-shift and
4000 right-shift behavior when checking for time stamp overflow.
8be6f318 4001
fe31d94c
PE
4002 * editfns.c (time_overflow): New function, refactoring common code.
4003 (Fformat_time_string, Fdecode_time, Fencode_time):
4004 (Fcurrent_time_string): Use it.
4005
8be6f318
PE
4006 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4007 * dired.c (make_time): Move to ...
4008 * editfns.c (make_time): ... here.
4009 * systime.h: Note the move.
4010
09d9db2c 40112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4012
126bc0dc
YM
4013 * fringe.c (update_window_fringes): Remove unused variables.
4014
c47cbdfd
YM
4015 * unexmacosx.c (copy_data_segment): Also copy __got section.
4016 (Bug#8223)
4017
7ac80be9
EZ
40182011-03-12 Eli Zaretskii <eliz@gnu.org>
4019
c96bbc66 4020 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4021 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4022 Constify `char *' arguments and their references according to
4023 prototypes in tparam.h.
4024
ecb0f94d 4025 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4026
7ac80be9
EZ
4027 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4028 Adapt all references accordingly.
4029
4030 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4031
ef1fd07e
TT
40322011-03-11 Tom Tromey <tromey@redhat.com>
4033
4034 * buffer.c (syms_of_buffer): Remove obsolete comment.
4035
7ef4b50c
EZ
40362011-03-11 Eli Zaretskii <eliz@gnu.org>
4037
4038 * termhooks.h (encode_terminal_code): Declare prototype.
4039
4040 * msdos.c (encode_terminal_code): Don't declare prototype.
4041
4042 * term.c (encode_terminal_code): Now external again, used by
4043 w32console.c and msdos.c.
4044
44f230aa
SM
4045 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4046 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4047
4b1ec863 40482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4049
1714f52b 4050 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4051
4b1ec863
PE
4052 * fringe.c (update_window_fringes): Mark locals as initialized
4053 (Bug#8227).
4054 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4055
524c7aa6
PE
4056 * alloc.c (mark_fringe_data): Move decl from here ...
4057 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4058 to check its interface.
4059 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4060
a5c0af81 4061 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4062 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4063 (fontset_font): Mark local as initialized.
a9a06e0b 4064 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4065
b4716021
PE
4066 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4067
811e9bac 4068 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4069 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4070 (x_own_selection, Fx_disown_selection_internal): Rename locals
4071 to avoid shadowing.
4072 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4073
7e3ab302
PE
4074 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4075 so that the caller can use some name other than gcpro1.
4076 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4077 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4078 (Fx_backspace_delete_keys_p):
4079 Use them to avoid shadowing, and rename vars to avoid shadowing.
4080 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4081 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4082 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4083 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4084 Remove unused locals.
7e3ab302
PE
4085 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4086 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4087 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4088 macros.
f78faa98 4089
e2b13473
PE
4090 * xterm.h (x_mouse_leave): New decl.
4091
77f23912
PE
4092 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4093 Remove unused functions.
cdf4ba58
PE
4094 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4095 (x_calc_absolute_position): Now static.
7411c686 4096 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4097 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4098 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4099 unless they are used.
38d0b34a
PE
4100 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4101 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4102 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4103 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4104 (x_error_catcher, x_connection_closed, x_error_handler):
4105 (x_error_quitter, xembed_send_message, x_iconify_frame):
4106 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4107 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4108 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4109
44f230aa
SM
4110 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4111 Rename or move locals to avoid shadowing.
6b463e58 4112 (tty_defined_color, merge_face_heights): Now static.
5967d051 4113 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4114 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4115 does not deduce is never used uninitialized.
73719eba
PE
4116 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4117 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4118
426994c3 4119 * terminal.c (store_terminal_param): Now static.
5489860b 4120
032f1620 4121 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4122 (set_frame_menubar): Remove unused local.
d4323972 4123 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4124 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4125 since they might point to immutable storage.
281585b0
PE
4126 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4127 since it's unused otherwise.
032f1620 4128
367c19e5 4129 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4130 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4131 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4132 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4133 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4134 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4135 does not deduce are never used uninitialized.
70739cbe 4136
07b48fa9
PE
4137 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4138
8868a238 4139 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4140 * window.c (window_loop, size_window):
4141 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4142
7e5cf297 4143 * window.c (display_buffer): Now static.
d6550a9f
PE
4144 (size_window): Mark variables that gcc -Wuninitialized
4145 does not deduce are never used uninitialized.
a586633d
PE
4146 * window.h (check_all_windows): New decl, to forestall
4147 gcc -Wmissing-prototypes diagnostic.
5b555da1 4148 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4149
f6095868
PE
4150 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4151 shadowing.
4152 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4153 Include <limits.h>.
4154 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4155 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4156 (load_charset_map): Mark variables that gcc -Wuninitialized
4157 does not deduce are never used uninitialized.
53df7c11 4158 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4159
f38b440c
PE
4160 * coding.c (coding_set_source, coding_set_destination):
4161 Use "else { /* comment */ }" rather than "else /* comment */;"
4162 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4163 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4164 a block, when the outer 'i' will do.
4165 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4166 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4167 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4168 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4169 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4170 Rename locals to avoid shadowing.
4171 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4172 * coding.c (emacs_mule_char, encode_invocation_designation):
4173 Now static, since they're not used elsewhere.
413bb2db 4174 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4175 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4176 (decode_coding_emacs_mule): Mark variables that gcc
4177 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4178 (detect_coding_iso_2022): Initialize a local variable that might
4179 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4180 this initialization is needed. (Bug#8211)
5f58e762
PE
4181 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4182 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4183 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4184 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4185 Remove unused macros.
f38b440c 4186
232b38b9 4187 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4188 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4189 * character.c (string_count_byte8): Likewise.
232b38b9 4190
fb90da1b
PE
4191 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4192 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4193
fb93dbc2
PE
4194 * chartab.c (copy_sub_char_table): Now static, since it's not used
4195 elsewhere.
5c156ace
PE
4196 (sub_char_table_ref_and_range, char_table_ref_and_range):
4197 Rename locals to avoid shadowing.
bbcd0949 4198 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4199
7d3b3862 4200 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4201 (BIDI_BOB): Remove unused macro.
7d3b3862 4202
6be7d3da
PE
4203 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4204 deduce are never used uninitialized.
c2ed9c8b 4205 * term.c (encode_terminal_code): Likewise.
6be7d3da 4206
75f8807f 4207 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4208
50938595
PE
4209 * tparam.h: New file.
4210 * term.c, tparam.h: Include it.
4211 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4212 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4213 Move these decls to tparam.h, and make them agree with what
4214 is actually in tparam.c. The previous trick of using incompatible
4215 decls in different modules does not conform to the C standard.
4216 All callers of tparam changed to use tparam's actual API.
4217 * tparam.c (tparam1, tparam, tgoto):
4218 Use const pointers where appropriate.
4219
fbceeba2
PE
4220 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4221 * cm.h (struct cm): Likewise.
4222 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4223 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4224 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4225 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4226 (turn_on_face, init_tty): Likewise.
4227 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4228
7f3f1250
PE
4229 * term.c (term_mouse_position): Rename local to avoid shadowing.
4230
e6ca6543
PE
4231 * alloc.c (mark_ttys): Move decl from here ...
4232 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4233
c40f8d15
AS
42342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4235
4236 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4237
cfe0661d
JB
42382011-03-09 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * search.c (compile_pattern_1): Remove argument regp, unused since
4241 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4242 (compile_pattern): Don't pass it.
4243
0afb4571
J
42442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4245
4246 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4247 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4248 for ! HAVE_GTK3.
4249 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4250
4251 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4252
4253 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4254 gdk_window_get_screen, gdk_window_get_geometry,
4255 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4256 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4257 (xg_get_pixbuf_from_pixmap): New function.
4258 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4259 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4260 Call xg_get_pixbuf_from_pixmap instead of
4261 gdk_pixbuf_get_from_drawable.
4262 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4263 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4264 (xg_check_special_colors): Use GtkStyleContext and its functions
4265 for HAVE_GTK3.
4266 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4267 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4268 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4269 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4270 Call gtk_widget_get_preferred_size.
0afb4571
J
4271 (xg_frame_resized): gdk_window_get_geometry only takes 5
4272 parameters.
44f230aa
SM
4273 (xg_win_to_widget, xg_event_is_for_menubar):
4274 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4275 (xg_set_widget_bg): New function.
4276 (delete_cb): New function.
895009e1 4277 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4278 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4279 (xg_set_background_color): Call xg_set_widget_bg.
4280 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4281 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4282 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4283 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4284 if ! HAVE_GTK3.
4285 (update_frame_tool_bar): Call gtk_widget_hide.
4286 (xg_initialize): Use GDK_KEY_g.
4287
4288 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4289 if ! HAVE_GTK3
4290 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4291
4292 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4293 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4294 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4295
1c2cc4ef
JB
42962011-03-08 Juanma Barranquero <lekktu@gmail.com>
4297
4298 * w32xfns.c (select_palette): Check success of RealizePalette against
4299 GDI_ERROR, not zero.
4300
33383987 4301See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4302
4303;; Local Variables:
4304;; coding: utf-8
aac0c6e3
MR
4305;; End:
4306
33383987 4307 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4308
4309 This file is part of GNU Emacs.
4310
4311 GNU Emacs is free software: you can redistribute it and/or modify
4312 it under the terms of the GNU General Public License as published by
4313 the Free Software Foundation, either version 3 of the License, or
4314 (at your option) any later version.
4315
4316 GNU Emacs is distributed in the hope that it will be useful,
4317 but WITHOUT ANY WARRANTY; without even the implied warranty of
4318 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4319 GNU General Public License for more details.
4320
4321 You should have received a copy of the GNU General Public License
4322 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.