Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
682432fc 12011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2
682432fc 3 Fix integer width and related bugs.
eb106a49 4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 (mark_vectorlike):
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
d311d28c
PE
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
79cce3f2
PE
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
d311d28c
PE
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 117 Don't assume fixnum fits in int.
d311d28c
PE
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
c96e5d6a 146 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 178 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 182 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 184 Don't access memory outside of the args array.
d311d28c 185 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
d311d28c
PE
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
209 (Faref, Faset):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
224 (struct it):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
240 (get_doc_string):
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
243 * doprnt.c (doprnt):
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
268 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
269 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
270 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
271 (init_cmdargs, Fdump_emacs):
272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
273 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
274 the bottom (typically) 32 bits of the fixnum.
275 * eval.c (specpdl_size, call_debugger):
276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
277 (when_entered_debugger, Fbacktrace_debug):
278 Don't assume fixnum can fit in int.
279 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
280 the object just before a buffer; this is not portable.
281 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
282 (grow_specpdl, unbind_to):
283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
284 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
285 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 286 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
287 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
288 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
290 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
291 (a_write, e_write):
292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
293 (Fcopy_file, non_regular_nbytes, read_non_regular)
294 (Finsert_file_contents):
295 Use int, not EMACS_INT, where int is wide enough.
296 (READ_BUF_SIZE): Verify that it fits in int.
297 (Finsert_file_contents): Check that counts are in proper range,
298 rather than assuming fixnums fit into ptrdiff_t etc.
299 Don't assume fixnums fit into int.
125b3835 300 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
301 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
302 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
303 (string_char_to_byte, string_byte_to_char)
304 (string_make_multibyte, string_to_multibyte)
305 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
306 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
307 (substring_both, Fdelete, internal_equal, Ffillarray)
308 (Fclear_string, mapcar1)
309 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
310 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
311 (larger_vector, make_hash_table, maybe_resize_hash_table)
312 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
313 (Fmaphash, secure_hash):
314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
315 (concat): Check for string index and length overflow.
316 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
317 (Frequire):
318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
319 (larger_vector): New API (vec, incr_min, size_max) replaces old
320 one (vec, new_size, init). This catches size overflow.
321 INIT was removed because it was always Qnil.
322 All callers changed.
323 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
324 the upper bound on a hash table index size.
325 (make_hash_table, maybe_resize_hash_table): Use it.
326 (secure_hash): Computer start_byte and end_byte only after
327 they're known to be in ptrdiff_t range.
328 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
329 (Ffont_get_glyphs, Ffont_at):
330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
331 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
332 (Flist_fonts, Fopen_font):
333 Don't assume fixnum can fit in int.
334 (check_gstring): Don't assume index can fit in int.
335 (font_match_p): Check that fixnum is a character, not a nonnegative
336 fixnum, since the later code needs to stuff it into an int.
337 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
338 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
339 conversion overflow issues.
340 (Fopen_font): Check for integer out of range.
341 (Ffont_get_glyphs): Don't assume index can fit in int.
342 * font.h: Adjust decls to match defn changes elsewhere.
343 * fontset.c (reorder_font_vector): Redo score calculation to avoid
344 integer overflow.
345 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
346 printmax_t, where ptrdiff_t is wide enough.
347 (Finternal_char_font):
348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
349 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
350 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
351 (Fset_frame_position, x_set_frame_parameters)
352 (x_set_line_spacing, x_set_border_width)
353 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
354 Check that fixnums are in proper range for system types.
355 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
357 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
358 Use SAFE_ALLOCA_LISP, not alloca.
359 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
360 intptr_t is wide enough.
361 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
362 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
363 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
364 Check for fixnum out of range.
365 * ftfont.c (ftfont_list): Don't assume index fits in int.
366 Check that fixnums are in proper range for system types.
367 (ftfont_shape_by_flt):
368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
369 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
371 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
372 Check that fixnums are in proper range for system types.
373 * gnutls.h: Adjust decls to match defn changes elsewhere.
374 * gtkutil.c (xg_dialog_run):
375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
376 (update_frame_tool_bar):
377 Check that fixnums are in proper range for system types.
378 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 379 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
380 * indent.c (last_known_column, last_known_column_point):
381 (current_column_bol_cache):
382 (skip_invisible, current_column, check_display_width):
383 (check_display_width, scan_for_column, current_column_1)
384 (Findent_to, Fcurrent_indentation, position_indentation)
385 (indented_beyond_p, Fmove_to_column, compute_motion):
386 (Fcompute_motion, Fvertical_motion):
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 (last_known_column_modified): Use EMACS_INT, not int.
389 (check_display_width):
390 (Fcompute_motion):
391 Check that fixnums and floats are in proper range for system types.
392 (compute_motion): Don't assume index or fixnum fits in int.
393 (compute_motion, Fcompute_motion):
394 Use int, not EMACS_INT, when it is wide enough.
395 (vmotion): Omit local var start_hpos that is always 0; that way
396 we don't need to worry about overflow in expressions involving it.
397 * indent.h: Adjust decls to match defn changes elsewhere.
398 (struct position):
399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
400 Use int, not EMACS_INT, where int is wide enough.
401 Remove unused members ovstring_chars_done and tab_offset;
402 all uses removed.
403 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
404 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
405 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
406 (make_gap, copy_text, insert, insert_and_inherit)
407 (insert_before_markers, insert_before_markers_and_inherit)
408 (insert_1, count_combining_before, count_combining_after)
409 (insert_1_both, insert_from_string)
410 (insert_from_string_before_markers, insert_from_string_1)
411 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
412 (adjust_after_replace, adjust_after_insert, replace_range)
413 (replace_range_2, del_range, del_range_1, del_range_byte)
414 (del_range_both, del_range_2, modify_region)
415 (prepare_to_modify_buffer, signal_before_change)
416 (signal_after_change, Fcombine_after_change_execute):
417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
418 * intervals.c (traverse_intervals, rotate_right, rotate_left)
419 (balance_an_interval, split_interval_right, split_interval_left)
420 (find_interval, next_interval, update_interval)
421 (adjust_intervals_for_insertion, delete_node, delete_interval)
422 (interval_deletion_adjustment, adjust_intervals_for_deletion)
423 (static_offset_intervals, offset_intervals)
424 (merge_interval_right, merge_interval_left, make_new_interval)
425 (graft_intervals_into_buffer, temp_set_point_both)
426 (temp_set_point, set_point, adjust_for_invis_intang)
427 (set_point_both, move_if_not_intangible, get_property_and_range)
428 (get_local_map, copy_intervals, copy_intervals_to_string)
429 (compare_string_intervals, set_intervals_multibyte_1):
430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
431 * intervals.h: Adjust decls to match defn changes elsewhere.
432 (struct interval):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 * keyboard.c (this_command_key_count, this_single_command_key_start)
435 (before_command_key_count, before_command_echo_length, echo_now)
436 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
437 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
438 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
439 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
441 (last_non_minibuf_size, last_point_position, echo_truncate)
442 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
443 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
444 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
445 (stuff_buffered_input):
446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
447 (last_auto_save, command_loop_1, read_char):
448 Use EMACS_INT, not int, to avoid integer overflow.
449 (record_char): Avoid overflow in total_keys computation.
450 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
451 * keyboard.h: Adjust decls to match defn changes elsewhere.
452 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
453 (Fkey_description, Fdescribe_vector, Flookup_key):
454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
455 (click_position): New function, to check that positions are in range.
456 (Fcurrent_active_maps):
457 (describe_command):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 (Faccessible_keymaps, Fkey_description):
460 (preferred_sequence_p):
461 Don't assume fixnum can fit into int.
462 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
463 Check for integer overflow in size calculations.
464 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
465 avoid mishandling large integers.
466 * lisp.h: Adjust decls to match defn changes elsewhere.
467 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
468 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
469 (struct Lisp_Marker):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
472 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
473 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
474 All callers changed.
475 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
476 Assume the arg has valid form, since it always does.
477 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
478 unsigned integer system type.
479 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
480 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
482 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
483 (duration_to_sec_usec): New decl.
484 * lread.c (read_from_string_index, read_from_string_index_byte)
485 (read_from_string_limit, readchar, unreadchar, openp)
486 (read_internal_start, read1, oblookup):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 (Fload, readevalloop, Feval_buffer, Feval_region):
489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
490 (openp): Check for out-of-range argument to 'access'.
491 (read1): Use int, not EMACS_INT, where int is wide enough.
492 Don't assume fixnum fits into int.
1ab7b8ac
PE
493 (read_filtered_event): Use duration_to_sec_usec
494 to do proper overflow checking on durations.
d311d28c
PE
495 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
496 in size calculation.
497 (Fexecute_kbd_macro):
498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
499 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
500 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
501 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
502 (set_marker_both, set_marker_restricted_both, marker_position)
503 (marker_byte_position, Fbuffer_has_markers_at):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
506 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
507 It now merely ensures that the menu is large enough, without
508 necessarily growing it, as this avoids some integer overflow issues.
509 All callers changed.
510 (keymap_panes, parse_single_submenu, Fx_popup_menu):
511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
512 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
513 Use SAFE_ALLOCA_LISP, not alloca.
514 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
515 to EMACS_INT. Check that fixnums are in proper range for system types.
516 * minibuf.c (minibuf_prompt_width, string_to_object)
517 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
518 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
520 (get_minibuffer, read_minibuf_unwind):
521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
522 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
523 this simplifies overflow checking. All callers changed.
524 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
525 (Ftest_completion):
526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
527 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
528 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
529 Check that fixnums are in proper range for system types.
530 (Fx_create_frame, Fx_show_tip):
531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
532 * nsfont.m (ns_findfonts, nsfont_list_family):
533 Don't assume fixnum fits in long.
534 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
536 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
537 wide enough.
17fdb222 538 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
541 (PRINTDECLARE, PRINTPREPARE):
542 (strout, print_string):
543 (print, print_preprocess, print_check_string_charset_prop)
544 (print_object):
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 (PRINTDECLARE):
547 (temp_output_buffer_setup, Fprin1_to_string, print_object):
548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
549 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
550 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
551 (printchar, strout): Use xpalloc to catch size calculation overflow.
552 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
553 to avoid mishandling large integers.
554 (print_error_message): Use SAFE_ALLOCA, not alloca.
555 (print_object): Use int, not EMACS_INT, where int is wide enough.
556 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
557 (Fset_process_window_size, Fformat_network_address)
558 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 559 (sigchld_handler):
d311d28c 560 Check that fixnums are in proper range for system types.
d44287d4
PE
561 (Fsignal_process): Simplify by avoiding a goto.
562 Treat out-of-range process numbers just like invalid numbers
563 that fit into the pid_t range, and return -1.
d311d28c
PE
564 (Fformat_network_address, read_process_output, send_process)
565 (Fprocess_send_region, status_notify):
566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
567 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
568 (wait_reading_process_output, read_process_output, exec_sentinel):
569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
570 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
571 (Faccept_process_output): Use duration_to_sec_usec to do proper
572 overflow checking on durations.
b62b53e8
PE
573 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
574 configured --with-wide-int.
d311d28c
PE
575 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
576 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
577 * search.c (looking_at_1, string_match_1):
578 (fast_string_match, fast_c_string_match_ignore_case)
579 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
580 (scan_newline, find_before_next_newline, search_command)
581 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
582 (set_search_regs, wordify):
583 (Freplace_match):
584 (Fmatch_data):
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 (string_match_1, search_buffer, set_search_regs):
587 (Fmatch_data):
588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
589 (wordify): Check for overflow in size calculation.
590 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
591 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
592 Check that fixnums are in proper range for system types.
593 * sound.c (struct sound_device)
594 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 (Fplay_sound_internal):
597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
598 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
599 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
600 for the respective integer ranges. This fixes a bug with
601 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
602 (struct lisp_parse_state, find_start_modiff)
603 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
604 (Fparse_partial_sexp):
605 Don't assume fixnums can fit in int.
606 (struct lisp_parse_state, find_start_pos, find_start_value)
607 (find_start_value_byte, find_start_begv)
608 (update_syntax_table, char_quoted, dec_bytepos)
609 (find_defun_start, prev_char_comend_first, back_comment):
610 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
611 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 (Finternal_describe_syntax_value): Check that match_lisp is a
614 character, not an integer, since the code stuffs it into int.
615 (scan_words, scan_sexps_forward):
616 Check that fixnums are in proper range for system types.
617 (Fforward_word):
618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
619 (scan_sexps_forward):
620 Use CHARACTERP, not INTEGERP, since the value must fit into int.
621 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
622 * syntax.h: Adjust decls to match defn changes elsewhere.
623 (struct gl_state_s):
624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
625 * sysdep.c (wait_for_termination_1, wait_for_termination)
626 (interruptible_wait_for_termination, mkdir):
627 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
628 (emacs_read, emacs_write):
629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
630 (system_process_attributes): Don't assume uid_t, gid_t, and
631 double all fit in int or even EMACS_INT.
632 * term.c (set_tty_color_mode):
633 Check that fixnums are in proper range for system types.
634 * termhooks.h (struct input_event):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 * textprop.c (validate_interval_range, interval_of)
637 (Fadd_text_properties, set_text_properties_1)
638 (Fremove_text_properties, Fremove_list_of_text_properties)
639 (Ftext_property_any, Ftext_property_not_all)
640 (copy_text_properties, text_property_list, extend_property_ranges)
641 (verify_interval_modification):
642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
643 (Fnext_single_char_property_change)
644 (Fprevious_single_char_property_change):
645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
646 (copy_text_properties):
647 Check for integer overflow in index calculation.
d311d28c
PE
648 * undo.c (last_boundary_position, record_point, record_insert)
649 (record_delete, record_marker_adjustment, record_change)
650 (record_property_change):
651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
652 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
654 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
655 (Fx_hide_tip, Fx_file_dialog):
656 * w32menu.c (set_frame_menubar):
657 Use ptrdiff_t, not int, for consistency with rest of code.
658 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
659 (select_window, Fdelete_other_windows_internal)
660 (window_scroll_pixel_based, window_scroll_line_based)
661 (Frecenter, Fset_window_configuration):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 (Fset_window_hscroll, run_window_configuration_change_hook)
664 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 665 (Fscroll_other_window, Frecenter):
d311d28c
PE
666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
667 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
668 Don't assume fixnum fits in int.
669 (Fset_window_scroll_bars):
670 Check that fixnums are in proper range for system types.
671 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
672 (string_pos, c_string_pos, number_of_chars, init_iterator)
673 (in_ellipses_for_invisible_text_p, init_from_display_pos)
674 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
675 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
676 (face_before_or_after_it_pos, handle_invisible_prop)
677 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
678 (display_prop_intangible_p, string_buffer_position_lim)
679 (string_buffer_position, handle_composition_prop, load_overlay_strings)
680 (get_overlay_strings_1, get_overlay_strings)
681 (iterate_out_of_display_property, forward_to_next_line_start)
682 (back_to_previous_visible_line_start, reseat, reseat_to_string)
683 (get_next_display_element, set_iterator_to_next)
684 (get_visually_first_element, compute_stop_pos_backwards)
685 (handle_stop_backwards, next_element_from_buffer)
686 (move_it_in_display_line_to, move_it_in_display_line)
687 (move_it_to, move_it_vertically_backward, move_it_by_lines)
688 (add_to_log, message_dolog, message_log_check_duplicate)
689 (message2, message2_nolog, message3, message3_nolog
690 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
691 (current_message_1, truncate_echo_area, truncate_message_1)
692 (set_message, set_message_1, store_mode_line_noprop)
693 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
694 (text_outside_line_unchanged_p, check_point_in_composition)
695 (reconsider_clip_changes)
696 (redisplay_internal, set_cursor_from_row, try_scrolling)
697 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
698 (redisplay_window, find_last_unchanged_at_beg_row)
699 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
700 (trailing_whitespace_p, find_row_edges, display_line)
701 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
702 (display_mode_element, store_mode_line_string)
703 (pint2str, pint2hrstr, decode_mode_spec)
704 (display_count_lines, display_string, draw_glyphs)
705 (x_produce_glyphs, x_insert_glyphs)
706 (rows_from_pos_range, mouse_face_from_buffer_pos)
707 (fast_find_string_pos, mouse_face_from_string_pos)
708 (note_mode_line_or_margin_highlight, note_mouse_highlight):
709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
710 (safe_call, init_from_display_pos, handle_fontified_prop)
711 (handle_single_display_spec, load_overlay_strings)
712 (with_echo_area_buffer, setup_echo_area_for_printing)
713 (display_echo_area, echo_area_display)
714 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
715 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
716 (redisplay_window, dump_glyph_row, display_mode_line)
717 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 718 (handle_display_spec, display_prop_string_p):
d311d28c
PE
719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
720 (handle_single_display_spec, build_desired_tool_bar_string)
721 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
722 (get_specified_cursor_type):
723 Check that fixnums are in proper range for system types.
724 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
725 (Flookup_image_map):
726 Don't assume fixnums fit in int.
727 (compare_overlay_entries):
728 Avoid mishandling comparisons due to subtraction overflow.
729 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
730 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
731 (handle_tool_bar_click):
732 Use int, not unsigned, since we prefer signed and the signedness
733 doesn't matter here.
734 (get_next_display_element, next_element_from_display_vector):
735 Use int, not EMACS_INT, when int is wide enough.
736 (start_hourglass): Use duration_to_sec_usec to do proper
737 overflow checking on durations.
738 * xfaces.c (Fbitmap_spec_p):
739 Check that fixnums are in proper range for system types.
740 (compare_fonts_by_sort_order):
741 Avoid mishandling comparisons due to subtraction overflow.
742 (Fx_family_fonts, realize_basic_faces):
743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
744 (Fx_family_fonts):
745 Don't assume fixnum fits in int.
746 Use SAFE_ALLOCA_LISP, not alloca.
747 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
748 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
749 (face_at_buffer_position, face_for_overlay_string)
750 (face_at_string_position):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
753 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
754 (Fx_show_tip):
755 Check that fixnums are in proper range for system types.
756 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
757 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
759 (Fx_change_window_property): Don't assume fixnums fit in int.
760 * xfont.c (xfont_chars_supported):
761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
762 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
763 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
765 * xml.c (parse_region):
766 * xrdb.c (magic_file_p):
767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
768 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
769 (x_get_local_selection, x_reply_selection_request)
770 (x_handle_selection_request, wait_for_property_change):
771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
772 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
773 short is wide enough.
774 (x_send_client_event): Don't assume fixnum fits in int.
775 * xterm.c (x_x_to_emacs_modifiers):
776 Don't assume EMACS_INT overflows nicely into int.
777 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
778 may come from Lisp.
779 (handle_one_xevent): NATNUMP can eval its arg twice.
780 (x_connection_closed):
781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
782 * xterm.h: Adjust decls to match defn changes elsewhere.
783 (struct scroll_bar): Use struct vectorlike_header
784 rather than rolling our own approximation.
785 (SCROLL_BAR_VEC_SIZE): Remove; not used.
786
0074aef2
EZ
7872011-10-12 Eli Zaretskii <eliz@gnu.org>
788
79beb178
EZ
789 * bidi.c (bidi_level_of_next_char):
790 * xdisp.c (get_visually_first_element): Remove old incorrect
791 comments regarding the Unicode Line Separator character.
792
0074aef2
EZ
793 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
794
6e4b3fbe
DA
7952011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
796
797 * alloc.c (Fgc_status): Do not access beyond zombies array
798 boundary if nzombies > MAX_ZOMBIES.
799 * alloc.c (dump_zombies): Add missing format specifier.
800
0324f3af
PE
8012011-10-12 Paul Eggert <eggert@cs.ucla.edu>
802
b5525cac
PE
803 * xdisp.c (set_cursor_from_row): Simplify conditionals,
804 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
805
0324f3af
PE
806 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
807 Some packages use them to denote characters with modifiers.
808
e9b5f888
AS
8092011-10-11 Andreas Schwab <schwab@linux-m68k.org>
810
811 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
812 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
813 matching a pp-number. Rename parameter var to var1.
814
127827c0
SM
8152011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
816
817 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
818
c8fd3bd0
GM
8192011-10-08 Glenn Morris <rgm@gnu.org>
820
821 * callint.c (Fcall_interactively): Give a more explicit error for the
822 'c' case with a non-character input. (Bug#8479)
823
352ec8ff
EZ
8242011-10-08 Eli Zaretskii <eliz@gnu.org>
825
03669ccb
EZ
826 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
827 lines.
7061c986
EZ
828 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
829 lines that are hscrolled on the left.
03669ccb 830
352ec8ff
EZ
831 * dispnew.c (buffer_posn_from_coords): Account for a possible
832 presence of header-line. (Bug#4426)
833
a66cfb1c
SM
8342011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
835
836 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
837 advertise functionality which we discourage or doesn't work.
838
7c5ee88e
PE
8392011-10-07 Paul Eggert <eggert@cs.ucla.edu>
840
841 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
842 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
843 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
844 this makes Emacs dump core during garbage collection on rare
845 occasions. sizeof is obviously inferior to offsetof here, so
846 stick with offsetof.
847 (GC_POINTER_ALIGNMENT): New macro.
848 (mark_memory): Omit 3rd (offset) arg; caller changed.
849 Don't assume EMACS_INT alignment is the same as pointer alignment.
850
df1bbe5b
SM
8512011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
852
853 * keyboard.c (read_key_sequence_remapped): New var.
854 (read_key_sequence): Compute remapping in the right buffer.
855 (command_loop_1): Use read_key_sequence's remapping directly.
856
51553db6
SM
8572011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
858
32c1fffd
SM
859 * dired.c (file_name_completion): Don't expand file name.
860 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
861 before checking file name handler.
862
51553db6
SM
863 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
864 they've been requested explicitly (bug#9591).
865
b6bd1599 8662011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
867
868 * keymap.c (Fsingle_key_description): Use make_specified_string
869 instead of build_string to build string from push_key_description.
870 (Bug#5193)
871
f701dc2a
PE
8722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
873
4222c55d
PE
874 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
875 This fixes a Y2038 bug on 64-bit hosts.
876 * buffer.c (reset_buffer):
877 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
878 (Fclear_buffer_auto_save_failure):
879 Use 0, not -1, to represent an unset failure time, since time_t
880 might not be signed.
881
f701dc2a
PE
882 Remove dependency on glibc malloc internals.
883 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
884 Move back here from lisp.h, but with their new implementations.
885 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
886 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
887 * charset.c (charset_table_init): New static var.
888 (syms_of_charset): Use it instead of xmalloc. This removes a
889 dependency on glibc malloc internals. See Eli Zaretskii's comment in
890 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
891 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
892 Move back to alloc.c.
893 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
894 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
895
9ceebf39
JD
8962011-09-30 Jan Djärv <jan.h.d@swipnet.se>
897
898 * nsterm.m (windowDidResize): Call x_set_window_size only when
899 ns_in_resize is true. Otherwise set pixelwidth/height and
900 call change_frame_size (Bug#9628).
901
cb993c58
PE
9022011-09-30 Paul Eggert <eggert@cs.ucla.edu>
903
3930c88b
PE
904 Port --enable-checking=all to Fedora 14 x86-64.
905 * charset.c (syms_of_charset): Also account for glibc malloc's
906 internal overhead when calculating the initial malloc maximum.
907
cb993c58
PE
908 Port --enable-checking=all to Fedora 14 x86.
909 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
910 Move to lisp.h.
911 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
912 (overrun_check_realloc, overrun_check_free):
913 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
914 That way, xmalloc returns a properly-aligned pointer even if
915 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
916 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
917 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
918 into account when calculating the initial malloc maximum.
919 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
920 Move here from alloc.c, so that charset.c can use it too.
921 Properly align; the old code wasn't right for common 32-bit hosts
922 when configured with --enable-checking=all.
923 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
924 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
925
31bed486
EZ
9262011-09-29 Eli Zaretskii <eliz@gnu.org>
927
04c70788 928 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
929 use EDOM.
930
fbcaa2f3
EZ
9312011-09-28 Eli Zaretskii <eliz@gnu.org>
932
933 * xdisp.c (compute_display_string_end): If there's no display
934 string at CHARPOS, return -1.
935
936 * bidi.c (bidi_fetch_char): When compute_display_string_end
937 returns a negative value, treat the character as a normal
938 character not covered by a display string. (Bug#9624)
939
a239d4e9
JB
9402011-09-28 Juanma Barranquero <lekktu@gmail.com>
941
942 * lread.c (Fread_from_string): Fix typo in docstring.
943
88652fd5
EZ
9442011-09-27 Eli Zaretskii <eliz@gnu.org>
945
946 * xdisp.c (handle_invisible_prop): If invisible text ends on a
947 newline, reseat the iterator instead of bidi-iterating there one
948 character at a time. (Bug#9610)
32c1fffd
SM
949 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
950 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 951
ed497dd4
AS
9522011-09-27 Andreas Schwab <schwab@linux-m68k.org>
953
954 * lread.c (readevalloop): Use correct code for NBSP.
955 (read1): Likewise. (Bug#9608)
956
b2bf61aa
MA
9572011-09-25 Michael Albinus <michael.albinus@gmx.de>
958
959 * dbusbind.c (Fdbus_register_signal): When service is not
960 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
961
32bbb17c
GM
9622011-09-25 Glenn Morris <rgm@gnu.org>
963
964 * buffer.c (truncate-lines): Doc fix.
965
94e0933e
CY
9662011-09-24 Chong Yidong <cyd@stupidchicken.com>
967
968 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
969 (Fset_window_next_buffers): Doc fix.
970
cddde921
GM
9712011-09-24 Glenn Morris <rgm@gnu.org>
972
973 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
974
1260aef1
PE
9752011-09-24 Paul Eggert <eggert@cs.ucla.edu>
976
25b4bfa0
PE
977 Fix minor problems found by static checking.
978 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
979 * indent.c (Fvertical_motion): Fix == vs = typo.
980
e3cbd34b
EZ
9812011-09-24 Eli Zaretskii <eliz@gnu.org>
982
a66cfb1c
SM
983 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
984 Default value is now t. Doc fix.
6bf7006f 985
e3cbd34b 986 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 987 logic when moving up, not only when moving down. Fix the
e3cbd34b 988 confusing name and values of the it_overshoot_expected variable;
32c1fffd 989 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
990
991 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
992 CHARPOS is covered by a display string which includes newlines.
993 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
994 is covered by a display string with embedded newlines.
995
a3de0cbd
MA
9962011-09-24 Michael Albinus <michael.albinus@gmx.de>
997
998 * dbusbind.c (Fdbus_register_signal): Add match rule to
999 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1000 (Fdbus_register_method, Vdbus_registered_objects_table):
1001 Fix docstring.
a3de0cbd 1002
b260039d
JM
10032011-09-24 Jim Meyering <meyering@redhat.com>
1004
32c1fffd 1005 do not ignore write error for any output size
b260039d
JM
1006 The previous change was incomplete.
1007 While it makes emacs --batch detect the vast majority of stdout
1008 write failures, errors were still ignored whenever the output size is
1009 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1010 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1011 && echo FAIL: ignored write error
1012 FAIL: ignored write error
1013 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1014 && echo FAIL: ignored write error
1015 FAIL: ignored write error
1016 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1017
8eca8a7c
AS
10182011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1019
1020 * emacs.c (Fkill_emacs): In noninteractive mode exit
1021 non-successfully if a write error occurred on stdout. (Bug#9574)
1022
3341db62
EZ
10232011-09-21 Eli Zaretskii <eliz@gnu.org>
1024
1025 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1026 the xassert test.
1027
1028 * dispextern.h (struct it): Update the comment documenting what
1029 can it->OBJECT be.
1030
8c203dbf
EZ
10312011-09-20 Eli Zaretskii <eliz@gnu.org>
1032
1033 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1034 a display string, extend search for cursor position to end of row.
1035 (find_row_edges): If the row ends in a newline from a display
1036 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1037 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1038 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1039 non-empty line. Fixes confusing cursor motion with arrow keys at
1040 the beginning of a line that starts with whitespace.
8c203dbf 1041
a4824228
LMI
10422011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1043
1044 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1045 (bug#9493).
1046
33ed493b
CY
10472011-09-18 Chong Yidong <cyd@stupidchicken.com>
1048
1049 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1050 boolean (Bug#9154).
1051
56cd55c8
EZ
10522011-09-18 Eli Zaretskii <eliz@gnu.org>
1053
1054 * xdisp.c (display_line): Record maximum and minimum buffer
1055 positions even if no glyphs were produced (e.g., by a zero-width
1056 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1057 buffer positions that will be removed from the glyph row because
1058 they don't fit.
c02dcedf
EZ
1059 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1060 column is beyond frame width: don't subtract 1 "pixel" when
1061 computing width of the stretch.
3e62b7e0
EZ
1062 (reseat_at_next_visible_line_start): Undo the change made on
1063 2011-09-17 that saved paragraph information and restored it after
1064 the call to `reseat'. (Bug#9545)
56cd55c8 1065
5ed99d36 10662011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1067
1068 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1069 and turn window cursor on if cleared (Bug#9415).
1070
5ed99d36 10712011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1072
1073 * search.c (boyer_moore): Take unibyte characters from pattern
1074 literally. (Bug#9458)
1075
9bade7b2
EZ
10762011-09-18 Eli Zaretskii <eliz@gnu.org>
1077
1078 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1079
e5e9d610
PE
10802011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1081
87e4427a
PE
1082 Fix minor problem found by static checking.
1083 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1084 initialized, to pacify gcc -Wuninitialized.
1085
e5e9d610
PE
1086 * fileio.c: Report proper errno when syscall falls.
1087 (Finsert_file_contents): Save and restore errno,
1088 so that report_file_error outputs the correct diagnostic.
1089 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1090
a1674f0b
EZ
10912011-09-18 Eli Zaretskii <eliz@gnu.org>
1092
1093 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1094
fbfb6dd4
EZ
10952011-09-17 Eli Zaretskii <eliz@gnu.org>
1096
1097 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1098 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1099
bb187662
EZ
11002011-09-17 Eli Zaretskii <eliz@gnu.org>
1101
1137e8b8
EZ
1102 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1103 about the current paragraph and restore it after the call to
1104 reseat.
1105
1106 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1107 (bidi_find_paragraph_start): Search back for paragraph beginning
1108 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1109 (bidi_move_to_visually_next): Only trigger paragraph-related
1110 computations when the last character is a newline or at EOB, not
1111 just any NEUTRAL_B. (Bug#9470)
1112
bb187662
EZ
1113 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1114 truncated lines if point is covered by a display string. (Bug#9524)
1115
2e621251
PE
11162011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1119 (cons_to_x_long): New function.
1120 (lisp_data_to_selection_data): Use it. Correct the test for
1121 short-versus-long data; it was negated. Break out of vector
1122 loop, for efficiency, when a long datum is discovered.
1123
91a15bc6
SM
11242011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1125
1126 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1127
b41c3a35
EZ
11282011-09-16 Eli Zaretskii <eliz@gnu.org>
1129
1130 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1131 GCC PR/17406) by declaring this function with external scope.
1132
7812ba2d
PE
11332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1134
1135 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1136 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1137
cf7edc2a
AS
11382011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1139
1140 * editfns.c (Fformat): Correctly handle text properties on "%%".
1141
bd01620e
EZ
11422011-09-15 Eli Zaretskii <eliz@gnu.org>
1143
1144 * xterm.c (x_draw_composite_glyph_string_foreground):
1145 * w32term.c (x_draw_composite_glyph_string_foreground):
1146 * term.c (encode_terminal_code):
1147 * composite.c (composition_update_it, get_composition_id):
1148 * xdisp.c (get_next_display_element)
1149 (fill_composite_glyph_string): Add comments about special meaning
1150 of TAB characters in a composition.
1151
a02719a3
PE
11522011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1153
1154 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1155 This occurs when processing a multibyte format.
1156 Problem reported by Wolfgang Jenker.
a02719a3 1157
72589a3c
JB
11582011-09-15 Johan Bockgård <bojohan@gnu.org>
1159
1160 * xdisp.c (try_cursor_movement): Only check for exact match if
1161 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1162
1c14176c
PE
11632011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1164
1165 Remove unused external symbols.
1166 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1167 * xdisp.c (calc_pixel_width_or_height): Now static.
1168 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1169 * indent.c (check_display_width):
1170 * w32term.c: Fix comment to match code.
1171 * xterm.c, xterm.h (x_catching_errors): Remove.
1172
d2eea5b5
PE
11732011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * xselect.c: Use signed conversions more consistently (Bug#9498).
1176 (selection_data_to_lisp_data): Assume incoming selection data are
1177 signed integers, not unsigned. This is to be consistent with
1178 outgoing selection data, which was modified to use signed integers
1179 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1180 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1181 expects long, not unsigned long.
1182
46888499
EZ
11832011-09-14 Eli Zaretskii <eliz@gnu.org>
1184
1185 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1186 computation of loop end. Reported by Johan Bockgård
1187 <bojohan@gnu.org>.
1188
ef8ef9fb
CY
11892011-09-13 Chong Yidong <cyd@stupidchicken.com>
1190
1191 * frame.c (Fother_visible_frames_p): Function deleted.
1192
fa819fed
EZ
11932011-09-12 Eli Zaretskii <eliz@gnu.org>
1194
1195 * indent.c (compute_motion): Process display vector front to back
1196 rather than the other way around. (Bug#2496)
1197
2ba8e008
SM
11982011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1199
1200 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1201
20f53c69
CY
12022011-09-11 Chong Yidong <cyd@stupidchicken.com>
1203
1204 * minibuf.c (Fread_from_minibuffer): Doc fix.
1205
d562d7a4
EZ
12062011-09-11 Eli Zaretskii <eliz@gnu.org>
1207
1208 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1209 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1210
1c4d7f3d
LMI
12112011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1212
1213 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1214 value for non-existent files.
1215
b885bf36
EZ
12162011-09-11 Eli Zaretskii <eliz@gnu.org>
1217
1218 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1219 set its "size" to -1. This will set the modtime_size field of
1220 the corresponding buffer to -1, which is what
1221 verify-visited-file-modtime expects for files that do not exist.
1222 (Bug#9139)
1223
6612f0bf
PE
12242011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1227 here ...
1228 * lisp.h: ... from here. push_key_description is no longer
1229 defined in keyboard.c, so its declaration should not be in
1230 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1231 logically belongs with push_key_description.
1232
dfb3f755
PE
12332011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1234
1235 * buffer.h: Include <sys/types.h> instead of <time.h>.
1236 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1237 Problem reported by Herbert J. Skuhra.
1238
3134906c
LMI
12392011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1240
1241 * xml.c (parse_region): Make the parsing work for
1242 non-comment-starting XML files again (bug#9144).
1243
8d903f4e
AS
12442011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1245
1246 * image.c (gif_load): Fix calculation of bottom and right corner.
1247 (Bug#9468)
1248
80ad64f4
EZ
12492011-09-10 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1252 redisplay in small windows.
1253
208a048d
EZ
12542011-09-09 Eli Zaretskii <eliz@gnu.org>
1255
1256 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1257
9b1c252e
MR
12582011-09-08 Martin Rudalics <rudalics@gmx.at>
1259
1260 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1261 Operate on live windows only.
1262
2949f33b
JB
12632011-09-08 Juanma Barranquero <lekktu@gmail.com>
1264
1265 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1266
e08dcafd
EZ
12672011-09-07 Eli Zaretskii <eliz@gnu.org>
1268
1269 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1270 only under bidi iteration.
1271
115b96bd
JD
12722011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1273
1274 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1275
c8199d0f
PE
12762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1279 Without this fix, the command to link temacs failed due to an
1280 undefined symbol __builtin_isnan. This is because
1281 /usr/include/iso/math_c99.h #defines isnan(x) to
1282 __builtin_isnan(x), but the bundled gcc, which identifies itself
1283 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1284 a __builtin_isnan.
1285 * floatfns.c (isnan): #undef, and then #define to a clone of
1286 what's in data.c.
1287 (Fisnan): Always define, since it's always available now.
1288 (syms_of_floatfns): Always define isnan at the Lisp level.
1289
e39b275c 12902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1291
1292 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1293
b2db44d9 12942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1295
f4af5137 1296 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1297 The previous code assumed that file offsets (off_t values) fit in
1298 EMACS_INT variables, which is not true on typical 32-bit hosts.
1299 The code messed up by falsely reporting buffer overflow in cases
1300 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1301 when "big" contains more than 2**29 bytes, even though this
1302 inserts just one byte and does not overflow the buffer.
1303 (Finsert_file_contents): Store file offsets as off_t
1304 values, not as EMACS_INT values. Check for overflow when
1305 converting between EMACS_INT and off_t. When checking for
1306 buffer overflow or for overlap, take the offsets into account.
1307 Don't use EMACS_INT for small values where int suffices.
1308 When checking for overlap, fix a typo: ZV was used where
1309 ZV_BYTE was intended.
1310 (Fwrite_region): Don't assume off_t fits into 'long'.
1311 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1312
ecfc0a49
MA
13132011-09-05 Michael Albinus <michael.albinus@gmx.de>
1314
1315 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1316
6511acf2 13172011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1318
0999621a 1319 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1320
1321 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1322 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1323 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1324 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1325 (modify_event_symbol): Do not assume that the length of
1326 name_alist_or_stem is safe to alloca and fits in int.
1327 (Fexecute_extended_command): Likewise for function name and binding.
1328 (Frecursion_depth): Wrap around reliably on integer overflow.
1329 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1330 since some callers pass EMACS_INT values.
1331 (Fsingle_key_description): Don't crash if symbol name contains more
1332 than MAX_ALLOCA bytes.
1333 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1334 (get_minibuffer): Arg is now EMACS_INT, not int.
1335 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1336 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1337 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1338
2be7d702
PE
1339 * dbusbind.c (signature_cat): New function.
1340 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1341 Do not overrun buffer; instead, report string overflow.
1342
9d1df220
PE
1343 * dispnew.c (add_window_display_history): Don't overrun buffer.
1344 Truncate instead; this is OK since it's just a log.
1345
33ef5c64
PE
1346 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1347 even if the time zone offset is outlandishly large.
1348 Don't mishandle offset == INT_MIN.
1349
66c6fdd5
PE
1350 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1351 when creating daemon; the previous buffer-overflow check was incorrect.
1352
d749b01b
PE
1353 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1354 which has the guts of the old verror function.
1355
b5cd1905
PE
1356 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1357 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1358
6e1a67fb
PE
1359 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1360 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1361 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1362 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1363 length of string rather than counting it via multiple sprintfs;
1364 that's simpler and more reliable.
c21721cc
PE
1365 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1366 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1367 sprintf, in case result does not fit in int.
1368
c57b67fc
PE
1369 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1370 (fontset_from_font): Print it.
1371
8a401434
PE
1372 * frame.c (tty_frame_count): Now printmax_t, not int.
1373 (make_terminal_frame, set_term_frame_name): Print it.
1374 (x_report_frame_params): In X, window IDs are unsigned long,
1375 not signed long, so print them as unsigned.
1376 (validate_x_resource_name): Check for implausibly long names,
1377 and don't assume name length fits in 'int'.
1378 (x_get_resource_string): Don't blindly alloca invocation name;
1379 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1380 not fit in int.
1381
6e1a67fb
PE
1382 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1383 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1384 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1385
0df02bf3
PE
1386 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1387 Use esprintf, not sprintf, in case result does not fit in int.
1388
48e30793
PE
1389 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1390 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1391 it as a large positive number.
1392 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1393 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1394
a66ff6d8
PE
1395 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1396 in case result does not fit in int.
1397
aca216ff
PE
1398 * print.c (float_to_string): Detect width overflow more reliably.
1399 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1400 buffer overrun. Don't assume list length fits in 'int'. Treat
1401 print length of 0 as 0, not as infinity; to be consistent with other
1402 uses of print length in this function. Don't overflow print length
1403 index. Don't assume hash table size fits in 'long', or that
1404 vectorlike size fits in 'unsigned long'.
1405
31c286f7
PE
1406 * process.c (make_process): Use printmax_t, not int, to format
1407 process-name gensyms.
1408
55e5faa1
PE
1409 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1410
80f2e268
PE
1411 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1412 to avoid potential buffer overrun.
1413
670741ab
PE
1414 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1415 if X resource line is longer than 512 bytes.
1416
b7163a50
PE
1417 * xfns.c (x_window): Make sprintf buffer a bit bigger
1418 to avoid potential buffer overrun.
1419
ae58ff1f
PE
1420 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1421
c43c8a6a
PE
1422 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1423
3f8236f4
PE
14242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1425
53e9fe90 1426 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1427 Without these, Emacs silently mishandles large integers sometimes.
1428 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1429 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1430
6511acf2
PE
1431 * xdisp.c (try_window_id): Check Emacs fixnum range before
1432 converting to 'int'.
806add1d 1433
6511acf2 1434 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1435 Check that an Emacs fixnum is in range before assigning it to 'int'.
1436 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1437 values converted from Emacs fixnums.
1438 (Frecenter): Don't wrap around a line count if it is out of 'int'
1439 range; instead, treat it as an extreme value.
1440 (Fset_window_configuration, compare_window_configurations):
1441 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1442
6511acf2
PE
1443 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1444 that can exceed INT_MAX. Check that EMACS_INT value is in range
1445 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1446 (match_limit): Don't assume that a fixnum can fit in 'int'.
1447
6511acf2 1448 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1449 exceed INT_MAX.
1450
6511acf2 1451 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1452 (Fvertical_motion): Don't wrap around LINES values that don't fit
1453 in 'int'. Instead, treat them as extreme values. This is good
1454 enough for windows, which can't have more than INT_MAX lines anyway.
1455
fcb901a7
LMI
14562011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1457
0f2f6b6d
LMI
1458 * Require libxml/parser.h to avoid compilation warning.
1459
fcb901a7
LMI
1460 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1461
1462 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1463 since this reportedly can destroy thread storage.
1464
6e20a0d4
CY
14652011-08-30 Chong Yidong <cyd@stupidchicken.com>
1466
1467 * syntax.c (find_defun_start): Update all cache variables if
1468 exiting early (Bug#9401).
1469
148ae00e
EZ
14702011-08-30 Eli Zaretskii <eliz@gnu.org>
1471
f6cfbd8f
EZ
1472 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1473
148ae00e
EZ
1474 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1475 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1476 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1477
1478 * term.c (tty_append_glyph): New function.
1479 (produce_stretch_glyph): Static function and its prototype deleted.
1480
a66cfb1c
SM
1481 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1482 Add prototypes.
148ae00e 1483
c4a07a4c
PE
14842011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1485
1486 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1487 when checking :margin (Bug#9390).
1488 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1489 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1490 so that the name doesn't mislead. All uses changed.
1491
6bc8cd65
JB
14922011-08-28 Johan Bockgård <bojohan@gnu.org>
1493
1494 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1495 set_tty_hooks.
1496
dca4927e
EZ
14972011-08-27 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (move_it_to): Don't bail out early when reaching
1500 position beyond to_charpos, if we are scanning backwards.
1501 (move_it_vertically_backward): When DY == 0, make sure we get to
1502 the first character in the line after the newline.
1503
f2cad773
PE
15042011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1507 (ccl_driver): Do not generate an out-of-range pointer.
1508 (Fccl_execute_on_string): Remove unnecessary check for
1509 integer overflow, noted by Stefan Monnier in
1510 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1511 Remove a FIXME that didn't need fixing.
1512 Simplify the newly-introduced buffer reallocation code.
1513
0cae2cdb
JB
15142011-08-27 Juanma Barranquero <lekktu@gmail.com>
1515
1516 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1517
5fc295a4 15182011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1519
70c60eb2 1520 Integer and memory overflow issues (Bug#9196).
726e0ab1 1521
d31850da
PE
1522 * doc.c (get_doc_string): Rework so that
1523 get_doc_string_buffer_size is the actual buffer size, rather than
1524 being 1 less than the actual buffer size; this makes xpalloc more
1525 convenient.
1526
a69fbedb
PE
1527 * image.c (x_allocate_bitmap_record, cache_image):
1528 * xselect.c (Fx_register_dnd_atom):
1529 Simplify previous changes by using xpalloc.
1530
fe5c5d37
PE
1531 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1532 since either will do and ptrdiff_t is convenient with xpalloc.
1533
0065d054
PE
1534 * charset.c (charset_table_size)
1535 (struct charset_sort_data.priority): Now ptrdiff_t.
1536 (charset_compare): Don't overflow if priorities differ greatly.
1537 (Fsort_charsets): Don't assume list length fits in int.
1538 Check for size-calculation overflow when allocating sort data.
1539 (syms_of_charset): Allocate an initial charset table that is
1540 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1541
1542 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1543
1544 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1545 The actual value is always <= INT_MAX, and leaving it unsigned made
1546 overflow checking harder.
1547
1548 * dispextern.h (struct glyph_matrix.rows_allocated)
1549 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1550 with xpalloc. The values are still always <= INT_MAX.
1551
1552 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1553
1554 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1555 (SAFE_NALLOCA): New macro.
1556
1557 * region-cache.c (struct boundary.pos, find_cache_boundary)
1558 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1559 (set_cache_region, invalidate_region_cache)
1560 (revalidate_region_cache, know_region_cache, region_cache_forward)
1561 (region_cache_backward, pp_cache):
1562 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1563 so that ptrdiff_t * can be passed to xpalloc.
1564 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1565 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1566 (pp_cache): Don't assume cache_len fits in int.
1567 * region-cache.h: Adjust extern decls to match.
1568
1569 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1570 EMACS_INT, since either will do, for xpalloc.
1571
1572 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1573 (xnmalloc, xnrealloc, xpalloc): New functions.
1574
726e0ab1
PE
1575 * bidi.c (bidi_shelve_header_size): New constant.
1576 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1577 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1578
51f30bc5 1579 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1580 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1581 (overlay_strings):
1582 Don't update size of array until after memory allocation succeeds,
1583 because xmalloc/xrealloc may not return.
0065d054
PE
1584 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1585 now that we have proper integer overflow checking.
1586 (record_overlay_string, overlay_strings): Catch overflows when
1587 calculating size of overlay_str_buf.
726e0ab1 1588
0065d054
PE
1589 * callproc.c (Fcall_process): Check for size overflow when
1590 calculating size of args2.
1591 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1592 Normally we prefer signed values, but sticking with ptrdiff_t would
1593 require adding more-complicated checks.
726e0ab1
PE
1594
1595 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1596 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1597 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1598 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1599
1600 * character.c (Fstring): Check for size-calculation overflow.
1601
1602 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1603 unnecessary integer overflow. Check for size overflow.
1604 (encode_coding_object): Don't update size until xmalloc succeeds.
1605
1606 * composite.c (get_composition_id): Check for overflow in glyph
1607 length calculations.
1608
1609 Integer and memory overflow fixes for display code.
1610 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1611 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1612 (scrolling_window): Check for overflow in size calculations.
1613 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1614 Don't assume glyph table len fits in int.
1615 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1616 (row_table_size): Now ptrdiff_t, not int.
1617 (scrolling_window): Avoid overflow in size calculations.
1618 Don't update size until allocation succeeds.
1619 * fns.c (concat): Check for overflow in size calculations.
1620 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1621 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1622 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1623
1624 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1625 (get_doc_string): Check for size calculation overflow.
1626 Don't update size until allocation succeeds.
1627 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1628 EMACS_INT, where ptrdiff_t will do.
1629 (Fsubstitute_command_keys): Check for string overflow.
1630
1631 * editfns.c (set_time_zone_rule): Don't assume environment length
1632 fits in int.
1633 (message_length): Now ptrdiff_t, not int.
1634 (Fmessage_box): Don't update size until allocation succeeds.
1635 Don't assume message length fits in int.
1636 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1637
0065d054
PE
1638 * emacs.c (main): Do not reallocate argv, since there is a null at
1639 the end that can be overwritten, and this way there's no need to
1640 worry about size-calculation overflow.
1641 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1642
1643 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1644 alloc succeeds.
1645 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1646
1647 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1648 (x_set_scroll_bar_width, x_figure_window_size):
1649 Check for integer overflow.
1650 (x_set_alpha): Do not assume XINT fits in int.
1651
1652 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1653 This is for the members text_lines, text_cols, total_lines, total_cols,
1654 where the system imposes an 'int' limit.
1655
1656 * fringe.c (Fdefine_fringe_bitmap):
1657 Don't update size until alloc works.
1658
1659 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1660 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1661
1662 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1663 Check for size-calculation overflow.
1664 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1665 do, as we prefer signed integers.
1666 (id_to_widget.max_size, id_to_widget.used)
1667 (xg_store_widget_in_map, xg_remove_widget_from_map)
1668 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1669 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1670 Use and return ptrdiff_t, not int.
1671 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1672 * gtkutil.h: Change prototypes to match the above.
1673
1674 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1675 are duplicate now that they've been promoted to lisp.h.
1676 (x_allocate_bitmap_record, x_alloc_image_color)
1677 (make_image_cache, cache_image, xpm_load):
1678 Don't update size until alloc is done.
1679 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1680 (x_detect_edges):
3256efce 1681 Check for size calculation overflow.
726e0ab1
PE
1682 (ct_colors_allocated_max): New constant.
1683 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1684 overflow.
3256efce 1685
726e0ab1
PE
1686 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1687 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1688 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1689 Use ptrdiff_t, not int, to count maps.
1690 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1691 calculations. Don't update size until allocation succeeds.
1692 Redo calculations to avoid overflow.
726e0ab1
PE
1693 * keyboard.h: Change prototypes to match the above.
1694
1695 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1696 to count maps.
1697 (current_minor_maps): Check for size calculation overflow.
1698 * keymap.h: Change prototypes to match the above.
1699
1700 * lread.c (read1, init_obarray): Don't update size until alloc done.
1701
1702 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1703 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1704
726e0ab1
PE
1705 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1706 Now ptrdiff_t, not int.
1707 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1708 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1709
1710 * process.c (Fnetwork_interface_list): Check for overflow
1711 in size calculation.
1712
1713 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1714
1715 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1716 overflow. Don't bother calling xmalloc when xrealloc will do.
1717
1718 * search.c (Freplace_match): Check for size calculation overflow.
1719 (Fset_match_data): Don't assume list lengths fit in 'int'.
1720
1721 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1722 for command line length. Do not attempt to address one before the
1723 beginning of an array, as that's not portable.
1724
1725 * term.c (max_frame_lines): Remove; unused.
1726 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1727 not int.
1728 (encode_terminal_code, calculate_costs): Check for size
1729 calculation overflow.
1730 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1731 table lengths and related sizes. Don't update size until alloc
1732 done. Redo calculations to avoid overflow.
1733 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1734
1735 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1736 subtracting pointers.
1737 (gobble_line): Check for overflow more carefully. Don't update size
1738 until alloc done.
1739
1740 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1741 Don't update size until alloc done.
1742 Redo size calculations to avoid overflow.
1743 Check for size calculation overflow.
0065d054 1744 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1745
1746 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1747 Use ptrdiff_t, not int, for sizes.
1748 (store_mode_line_noprop_char): Don't update size until alloc done.
1749
0065d054
PE
1750 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1751 Use ptrdiff_t, not int, for sizes.
1752 (Finternal_make_lisp_face, cache_face):
1753 Check for size calculation overflow.
1754 (cache_face): Treat size calculation overflows as if they were
1755 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1756
1757 * xfns.c (x_encode_text, x_set_name_internal)
1758 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1759 sizes, since they can exceed INT_MAX in size. Check for size
1760 calculation overflow.
1761
0065d054
PE
1762 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1763 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1764 Don't update size until alloc done.
1765
0065d054 1766 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1767 as sprintf is limited to int lengths.
1d526e2f 1768
252c5ee1
PE
1769 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1770 (X_LONG_MIN): New macros.
864d7ce7
PE
1771 Use them to make the following changes clearer.
1772 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1773 This change doesn't affect the value now, but it may help remind
1774 future maintainers not to raise the value too much later.
1775 (SELECTION_QUANTUM): Remove, replacing with ...
1776 (selection_quantum): ... new function, which avoids overflow.
1777 All uses changed.
1778 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1779 assumption that selection length fits in 'int'.
1780 (x_reply_selection_request, x_handle_selection_request)
1781 (x_get_window_property, receive_incremental_selection)
1782 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1783 (lisp_data_to_selection_data, clean_local_selection_data):
1784 Use ptrdiff_t, not int, to record length of selection.
1785 (x_reply_selection_request, x_get_window_property)
1786 (receive_incremental_selection, x_property_data_to_lisp):
1787 Redo calculations to avoid overflow.
1788 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1789 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1790 something.
1791 (x_get_window_property, receive_incremental_selection)
1792 (lisp_data_to_selection_data, x_property_data_to_lisp):
1793 Check for size-calculation overflow.
1794 (x_get_window_property, receive_incremental_selection)
1795 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1796 Don't store size until memory allocation succeeds.
1797 (x_get_window_property): Plug memory leak on memory exhaustion.
1798 Don't double-block input; malloc is safe here. Don't assume 2**34
1799 - 4 fits in unsigned long. Add an xassert to check
1800 XGetWindowProperty overflow. Be more careful about overflow
1801 calculations, and distinguish size from memory overflow better.
1802 (receive_incremental_selection): When tracing, don't assume
1803 unsigned int is less than INT_MAX.
1804 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1805 harmful) conversions of unsigned short to int.
1806 (lisp_data_to_selection_data): Don't assume that integers
1807 in the range -65535 through -1 fit in an X unsigned short.
1808 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1809 result parameters unless successful. Rely on cons_to_unsigned
1810 to report problems with elements; the old code wasn't right anyway.
1811 (x_check_property_data): Check for int overflow; we cannot use
1812 a wider type due to X limits.
1813 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1814
726e0ab1 1815 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1816
0065d054
PE
1817 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1818 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1819 (x_color_cells): Don't store size until memory allocation succeeds.
1820 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1821 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1822 (x_term_init): Don't assume length fits in int (sprintf is limited
1823 to int size).
bc18e09d 1824
ebfa62c0
PE
1825 Use ptrdiff_t for composition IDs.
1826 * character.c (lisp_string_width):
1827 * composite.c (composition_table_size, n_compositions)
1828 (get_composition_id, composition_gstring_from_id):
1829 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1830 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1831 * window.c (Frecenter):
1832 Use ptrdiff_t, not int, for composition IDs.
1833 * composite.c (get_composition_id): Check for integer overflow.
1834 * composite.h: Adjust prototypes to match the above changes.
1835
d3411f89
PE
1836 Use ptrdiff_t for hash table indexes.
1837 * category.c (hash_get_category_set):
1838 * ccl.c (ccl_driver):
1839 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1840 * coding.c (coding_system_charset_list, detect_coding_system):
1841 * coding.h (struct coding_system.id):
1842 * composite.c (get_composition_id, gstring_lookup_cache):
1843 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1844 * image.c (xpm_get_color_table_h):
1845 * lisp.h (hash_lookup, hash_put):
1846 * minibuf.c (Ftest_completion):
1847 Use ptrdiff_t for hash table indexes, not int (which is too
1848 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1849 32-bit --with-wide-int hosts).
1850
e097a6fa
PE
1851 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1852 Add a FIXME comment about memory leaks.
1853 (syms_of_charset): Don't assume xmalloc returns.
1854
5637687f
PE
1855 Don't assume that stated character widths fit in int.
1856 * character.c (Fchar_width, c_string_width, lisp_string_width):
1857 * character.h (CHAR_WIDTH):
1858 * indent.c (MULTIBYTE_BYTES_WIDTH):
1859 Use sanitize_char_width to avoid undefined and/or bad behavior
1860 with outlandish widths.
a66cfb1c 1861 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1862 now that we have two such functions. All uses changed.
1863 (sanitize_char_width): New inline function.
1864
a2271ba2
PE
1865 Don't assume that tab-width fits in int.
1866 * character.h (sanitize_width): New inline function.
1867 (SANE_TAB_WIDTH): New macro.
1868 (ASCII_CHAR_WIDTH): Use it.
1869 * indent.c (sane_tab_width): Remove. All uses replaced by
1870 SANE_TAB_WIDTH (current_buffer).
1871 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1872
18c52557
PE
1873 * fileio.c: Integer overflow issues with file modes.
1874 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1875
caeeedc1
PE
1876 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1877 Remove unreachable code.
1878 (read_hex, load_charset_map_from_file): Check for integer overflow.
1879
50849c52
PE
1880 * xterm.c: don't go over XClientMessageEvent limit
1881 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1882 (x_send_scroll_bar_event): Likewise. Check that the size does not
1883 exceed limits imposed by XClientMessageEvent, as well as the usual
1884 ptrdiff_t and size_t limits.
1885
b13995db
PE
1886 * keyboard.c: Overflow, signedness and related fixes.
1887 (make_lispy_movement): Use same integer type in forward decl
1888 that is used in the definition.
1889 (read_key_sequence, keyremap_step):
1890 Change bufsize argument back to int, undoing my 2011-03-30 change.
1891 We prefer signed types, and int is wide enough here.
1892 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1893 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1894 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1895 length, not size_t. Use ptrdiff_t for index, not int.
1896 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1897 possibility of integer overflow.
1898
13464394
PE
1899 Overflow, signedness and related fixes for images.
1900
1901 * dispextern.h (struct it.stack[0].u.image.image_id)
1902 (struct_it.image_id, struct image.id, struct image_cache.size)
1903 (struct image_cache.used, struct image_cache.ref_count):
1904 * gtkutil.c (update_frame_tool_bar):
1905 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1906 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1907 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1908 * nsmenu.m (update_frame_tool_bar):
1909 * xdisp.c (calc_pixel_width_or_height):
1910 * xfns.c (image_cache_refcount):
1911 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1912 on typical 64-bit hosts.
1913
1914 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1915 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1916 Omit unnecessary casts to int.
1917 (parse_image_spec): Check that integers fall into 'int' range
1918 when the callers expect that.
1919 (image_ascent): Redo ascent calculation to avoid int overflow.
1920 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1921 (lookup_image): Remove unnecessary tests.
1922 (xbm_image_p): Locals are now of int, not EMACS_INT,
1923 since parse_image_check makes sure they fit into int.
1924 (png_load, gif_load, svg_load_image):
1925 Prefer int to unsigned where either will do.
1926 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1927 old tiff_error_handler and tiff_warning_handler.
1928 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1929 stack buffer overflows. It uses only the features of vsnprintf
1930 that are common to both POSIX and native Microsoft.
1931 (tiff_error_handler, tiff_warning_handler): Use it.
1932 (tiff_load, gif_load, imagemagick_load_image):
1933 Don't assume :index value fits in 'int'.
1934 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1935 (imagemagick_load_image): Check that crop parameters fit into
1936 the integer types that MagickCropImage accepts. Don't assume
1937 Vimagemagick_render_type has a nonnegative value. Don't assume
1938 size_t fits in 'long'.
1939 (gs_load): Use printmax_t to print the widest integers possible.
1940 Check for integer overflow when computing image height and width.
1941
c11821d4
EZ
19422011-08-26 Eli Zaretskii <eliz@gnu.org>
1943
1944 * xdisp.c (redisplay_window): Don't force window start if point
1945 will be invisible in the resulting window. (Bug#9324)
1946
0c95fcf7
EZ
19472011-08-25 Eli Zaretskii <eliz@gnu.org>
1948
1949 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1950 the display spec is of the form `(space ...)'.
1951 (handle_display_spec): Return the value returned by
1952 handle_single_display_spec, not just 1 or zero.
1953 (handle_single_display_spec): If the display spec is of the form
1954 `(space ...)', and specifies display in the text area, return 2
1955 rather than 1.
fee65a97 1956 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1957 accurately, and prefer exact match for point under bidi.
1958 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1959
1960 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1961 into disp_prop; all users changed.
1962
1963 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1964 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1965 for the text covered by the display property.
1966
e4ed06f1
CY
19672011-08-25 Chong Yidong <cyd@stupidchicken.com>
1968
1969 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1970 Change return value to nil.
1971 (Frecord_buffer): Delete unused function.
1972
f67cdd7f
EZ
19732011-08-24 Eli Zaretskii <eliz@gnu.org>
1974
5980d4c6
EZ
1975 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1976 buffers, return left-to-right.
8610fe8b
EZ
1977 (set_cursor_from_row): Consider candidate row a win if its glyph
1978 represents a newline and point is on that newline. Fixes cursor
1979 positioning on the newline at EOL of R2L text within L2R
1980 paragraph, and vice versa.
1981 (try_cursor_movement): Check continued rows, in addition to
1982 continuation rows. Fixes unwarranted scroll when point enters a
1983 continued line of R2L text within an L2R paragraph, or vice versa.
1984 (cursor_row_p): Consider the case of point being equal to
1985 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1986 from the end of a short line to the beginning of a continued line
1987 of R2L text within L2R paragraph.
1988 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1989 composed characters.
5980d4c6 1990
f67cdd7f
EZ
1991 * bidi.c (bidi_check_type): Use xassert.
1992 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1993 members.
1994
bca633fb
EZ
19952011-08-23 Eli Zaretskii <eliz@gnu.org>
1996
1997 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1998 a character.
1999
4a5885a7
CY
20002011-08-23 Chong Yidong <cyd@stupidchicken.com>
2001
2002 * nsfont.m (ns_otf_to_script): Fix typo.
2003
0902a04e
KH
20042011-08-22 Kenichi Handa <handa@m17n.org>
2005
2006 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2007 extra slot even if the purpose is char-code-property-table.
2008
1a2e6670
EZ
20092011-08-23 Eli Zaretskii <eliz@gnu.org>
2010
8ddde651
EZ
2011 * xdisp.c (redisplay_window): When computing centering_position,
2012 account for the height of the header line. (Bug#8874)
2013
425cc014
EZ
2014 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2015 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2016 candidate is selected by the mouse, and that candidate has a
2017 composed character under the mouse.
2018
1a2e6670
EZ
2019 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2020 coordinates reported by pos-visible-in-window-p for a composed
2021 character in column zero.
2022
8b76d6f8
SM
20232011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2024
2025 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2026
dac347dd
EZ
20272011-08-22 Eli Zaretskii <eliz@gnu.org>
2028
2029 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2030 consider it a hit if to_charpos is anywhere in the range of the
2031 composed buffer positions.
2032
e013fb34
CY
20332011-08-22 Chong Yidong <cyd@stupidchicken.com>
2034
2035 * image.c (gif_load): Don't assume that each subimage has the same
2036 dimensions as the base image. Handle disposal method that is
2037 "undefined" by the gif spec (Bug#9335).
2038
bd1ba3e8
CY
20392011-08-20 Chong Yidong <cyd@stupidchicken.com>
2040
2041 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2042 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2043
54a1215b
EZ
20442011-08-19 Eli Zaretskii <eliz@gnu.org>
2045
823564e5
EZ
2046 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2047 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2048 from an Org mode buffer to a Speedbar frame.
2049
54a1215b
EZ
2050 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2051 a composition, take its buffer position from IT->cmp_it.charpos.
2052 Fixes cursor positioning at the beginning of a line that begins
2053 with a composed character.
2054
9778ebcc
EZ
20552011-08-18 Eli Zaretskii <eliz@gnu.org>
2056
0be6ee06
EZ
2057 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2058 character bidirectional type, use STRONG_L instead. Fixes crashes
2059 in a buffer produced by `describe-categories'.
2060
9778ebcc
EZ
2061 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2062 members before the level stack, so they would be saved and
2063 restored when copying iterator state. Fixes incorrect reordering
2064 around TABs covered by display properties.
2065
156bffbe
AS
20662011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2067
2068 * process.c (Fnetwork_interface_list): Correctly determine buffer
2069 size.
2070
72ad093b
CY
20712011-08-17 Chong Yidong <cyd@stupidchicken.com>
2072
2073 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2074 (internal_condition_case_2, internal_condition_case_n):
2075 Remove unnecessary aborts (Bug#9081).
72ad093b 2076
35774242
EZ
20772011-08-17 Eli Zaretskii <eliz@gnu.org>
2078
2079 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2080 has no `load' handler, try opening the file locally. (Bug#9311)
2081
db76dd85
KB
20822011-08-16 Ken Brown <kbrown@cornell.edu>
2083
2084 * gmalloc.c: Expand comment.
2085
b215eee5
EZ
20862011-08-16 Eli Zaretskii <eliz@gnu.org>
2087
2088 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2089 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2090
a4579d33
KB
20912011-08-16 Ken Brown <kbrown@cornell.edu>
2092
2093 Fix memory allocation problems in Cygwin build (Bug#9273).
2094
2095 * unexcw.c ( __malloc_initialized): Declare external variable.
2096 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2097
8b76d6f8
SM
2098 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2099 New variables.
a4579d33
KB
2100 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2101 dumped emacs.
2102 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2103 in the static heap.
2104 [CYGWIN] (special_realloc): New function.
2105 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2106 requests to realloc storage in the static heap.
2107
3ebec551
PE
21082011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 * bidi.c (bidi_initialize): Remove unused local.
2111
9fd8be00
EZ
21122011-08-15 Eli Zaretskii <eliz@gnu.org>
2113
474a8465
EZ
2114 * biditype.h: File removed.
2115
2116 * bidimirror.h: File removed.
2117
2118 * deps.mk (bidi.o): Remove biditype.h and
2119 bidimirror.h.
2120
2121 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
2122 bidimirror.h.
2123
2124 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2125
2126 * chartab.c: Improve commentary for the uniprop_table API.
2127
32413314
EZ
2128 * bidi.c (bidi_paragraph_init): Support zero value of
2129 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2130 (bidi_initialize): Use uniprop_table instead of including
2131 biditype.h and bidimirror.h.
32413314 2132
9fd8be00
EZ
2133 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2134 coordinates of the iterator when restoring from ppos_it.
2135 (Bug#9296)
2136
5cf2b69b
KH
21372011-08-14 Kenichi Handa <handa@m17n.org>
2138
2139 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2140 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2141
daf17d00
EZ
21422011-08-14 Eli Zaretskii <eliz@gnu.org>
2143
2144 * xdisp.c (move_it_in_display_line_to): Don't invoke
2145 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2146 ppos_it. Fixes vertical cursor motion when line beginning is
2147 covered by an image. (Bug#9296)
2148
08e3161a
JD
21492011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2150
2151 * nsterm.h (ns_run_ascript): Declare.
2152 (NSAPP_DATA2_RUNASSCRIPT): Define.
2153
2154 * nsfns.m (as_script, as_result, as_status): New static variables.
2155 (ns_run_ascript): New function.
5e617bc2 2156 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2157 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2158 the event loop. Get status from as_status (Bug#7276).
2159
2160 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2161 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2162 the event loop (Bug#7276).
2163
a3720aa2
AS
21642011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2165
2166 * gnutls.c (QCgnutls_bootprop_priority)
2167 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2168 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2169 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2170 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2171 (QCgnutls_bootprop_verify_hostname_error)
2172 (QCgnutls_bootprop_callbacks_verify): Rename from
2173 Qgnutls_bootprop_..., all uses changed.
2174
2175 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2176 uses changed.
2177
0a0d27fb
PE
21782011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2179
19d5c50c
PE
2180 * xfaces.c (Qframe_set_background_mode): Now static.
2181 * dispextern.h (Qframe_set_background_mode): Remove decl.
2182
0a0d27fb
PE
2183 * process.c (Fnetwork_interface_info): Declare local only if needed.
2184
377538cb
JD
21852011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2186
2187 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2188 (Fnetwork_interface_list): Allocate in increments of bytes instead
2189 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2190 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2191 sockaddr.
2192 (struct ifflag_def): notrailers is smart on OSX.
2193 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2194 Get hardware address with getifaddrs if available.
2195
08fff70c
EZ
21962011-08-12 Eli Zaretskii <eliz@gnu.org>
2197
2198 * xdisp.c (iterate_out_of_display_property): xassert that
2199 IT->position is set to within IT->object's boundaries. Break from
2200 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2201 when IT->position is set up wrongly due to some bug.
2202 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2203 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2204 entry. Force push_it to save on the stack the current
2205 buffer/string position, to be restored by pop_it. Fix flags in
2206 the iterator structure wrt the object coming from a display
2207 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2208 properties. (Bug#9284)
2209
7be1c708 22102011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2211
7be1c708
CY
2212 * fontset.c (fontset_get_font_group): Add proper type checks.
2213 (Bug#9172)
aac0c6e3 2214
7be1c708 22152011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2216
7be1c708
CY
2217 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2218 and LC_VERSION_MIN_MACOSX.
2219 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2220 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2221
97bb72a6
EZ
22222011-08-08 Eli Zaretskii <eliz@gnu.org>
2223
2224 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2225 no-display-properties-and-no-overlays under bidi display.
2226 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2227 properties and overlays.
97bb72a6 2228
d5617611
CY
22292011-08-08 Chong Yidong <cyd@stupidchicken.com>
2230
37e11a63
CY
2231 * editfns.c (Fset_time_zone_rule): Document relationship with the
2232 setenv function.
2233
d5617611
CY
2234 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2235 the font entity extracted from the cache (Bug#8109).
2236
58872834
CY
22372011-08-07 Chong Yidong <cyd@stupidchicken.com>
2238
2239 * composite.c (autocmp_chars): Don't reset point. That is done by
2240 restore_point_unwind (Bug#5984).
2241
75bfc667
JL
22422011-08-07 Juri Linkov <juri@jurta.org>
2243
2244 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2245 to show the arg `TIME' instead of `TIMEVAL'.
2246
d1410150
EZ
22472011-08-06 Eli Zaretskii <eliz@gnu.org>
2248
2249 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2250 display property strides EOL and includes a newline, as in
2251 longlines-mode. (Bug#9254)
75b771e4
EZ
2252 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2253 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2254
2255 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2256 is non-zero, even if the data buffer is NULL. Fixes a crash in
2257 vertical-motion with longlines-mode. (Bug#9254)
2258
35928349
EZ
22592011-08-05 Eli Zaretskii <eliz@gnu.org>
2260
ec7cc85b
EZ
2261 * bidi.c <bidi_cache_total_alloc>: Now static.
2262 (bidi_initialize): Initialize bidi_cache_total_alloc.
2263
8b76d6f8 2264 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2265 cache. (Bug#9221)
2266
2267 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2268 amount allocated this far in `bidi_cache_total_alloc'.
2269 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2270 non-zero, only free the data buffer without restoring the cache
2271 contents. All callers changed.
2272
2273 * dispextern.h (bidi_unshelve_cache): Update prototype.
2274
2275 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2276 (move_it_in_display_line, move_it_to)
2277 (move_it_vertically_backward, move_it_by_lines): Replace the call
2278 to xfree to an equivalent call to bidi_unshelve_cache.
2279 (move_it_in_display_line_to): Fix logic of returning
412b6358 2280 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2281
e2e2423b
EZ
22822011-08-05 Eli Zaretskii <eliz@gnu.org>
2283
2284 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2285 came from a string character with a `cursor' property. (Bug#9229)
2286
ae9e757a
JD
22872011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2288
2289 * Makefile.in (LIB_PTHREAD): New variable.
2290 (LIBES): Add LIB_PTHREAD (Bug#9216).
2291
2292 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2293 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2294
213bd7f2
AS
22952011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2296
2297 * regex.c (re_iswctype): Remove some redundant boolean
2298 conversions.
2299
99aaf75f
JD
23002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2301
2302 * xterm.c (x_find_topmost_parent): New function.
2303 (x_set_frame_alpha): Find topmost parent window with
2304 x_find_topmost_parent and set the property there also (bug#9181).
2305 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2306
c74e9d86
PE
23072011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 * callproc.c (Fcall_process): Avoid vfork clobbering
2310 the local vars buffer, coding_systems, current_dir.
2311
640c8776
SM
23122011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2313
2314 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2315
f26d0e4c
PE
23162011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2317
8a10d76c
PE
2318 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2319 so that it is not optimized away.
2320
f26d0e4c
PE
2321 * xdisp.c (compute_display_string_pos): Remove unused local.
2322
55439c61
EZ
23232011-08-02 Eli Zaretskii <eliz@gnu.org>
2324
2325 Fix slow cursor motion and scrolling in large buffers with
2326 selective display, like Org Mode buffers. (Bug#9218)
2327
2328 * dispextern.h (struct bidi_it): New member disp_prop_p.
2329
2330 * xdisp.c: Remove one-slot cache of display string positions.
2331 (compute_display_string_pos): Accept an additional argument
5e617bc2 2332 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2333 for a display string or property. If found, set DISP_PROP_P
2334 non-zero.
2335
2336 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2337 DISP_PROP_P, and pass it to compute_display_string_pos.
2338 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2339 non-zero. All callers of bidi_fetch_char changed.
2340
fb33fa43
SM
23412011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2342
2343 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2344
b099e063
DM
23452010-12-03 Don March <don@ohspite.net>
2346
2347 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2348 last character M-[char] is translated to ESC [char] (bug#7541).
2349
5cc7f7af
KH
23502011-08-02 Kenichi Handa <handa@m17n.org>
2351
d0fffa3f 2352 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2353
2354 * chartab.c (uniprop_table): Make it non-static.
2355
525d5e6e
EZ
23562011-08-01 Eli Zaretskii <eliz@gnu.org>
2357
2358 * xdisp.c (forward_to_next_line_start): Accept additional argument
2359 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2360 on the newline.
2361 (reseat_at_next_visible_line_start): Use the bidi iterator state
2362 returned by forward_to_next_line_start to restore the state of
2363 it->bidi_it after backing up to previous newline. (Bug#9212)
2364
31011111
AS
23652011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2366
2367 * regex.c (re_comp): Protoize.
2368 (re_exec): Fix return type.
2369 (regexec): Fix type of `ret'. (Bug#9203)
2370
476371c4
PE
23712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2372
e5d76069
PE
2373 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2374 This is needed if max-image-size is a floating-point number.
2375
9a79b20c
AS
23762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2377
2378 * print.c (print_object): Print empty symbol as ##.
2379
2380 * lread.c (read1): Read ## as empty symbol.
2381
d8c2fa78
AA
23822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2383
2384 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2385 setting frame foreground color (Bug#9175).
2386 (x_set_background_color): Likewise.
2387
ffe57a7a
AA
2388 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2389 contents (Bug#9176).
2390 (EmacsTooltip -init): Remove bezels and add shadows to
2391 tooltip windows.
2392
bf3492a5
AA
2393 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2394 or scroll bar (Bug#8470).
2395
d55e9c53
AA
2396 * nsfont.m (nsfont_open): Remove assignment to voffset and
2397 unnecessary vars hshink, expand, hd, full_height, min_height.
2398 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2399
2400 * nsterm.h (nsfont_info): Remove voffset field.
2401
d8c2fa78 24022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2403
2404 Implement strike-through and overline on NextStep (Bug#8863).
2405
2406 * nsfont.m (nsfont_open): Use underline position provided by font,
2407 instead of hard-coded value of 2.
2408 (nsfont_draw): Call ns_draw_text_decoration instead.
2409
2410 * nsterm.h: Add declaration for ns_draw_text_decoration.
2411
2412 * nsterm.m (ns_draw_text_decoration): New function for drawing
2413 underline, overline, and strike-through.
2414 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2415 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2416 accommodate underlining, etc.
4843aac3 2417
4cc60b9b
EZ
24182011-07-28 Eli Zaretskii <eliz@gnu.org>
2419
bc7ece87
EZ
2420 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2421 default.
4cc60b9b 2422
476371c4
PE
24232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2424
66606eea
PE
2425 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2426 Without this fix, if a signal arrives just after memory fills up,
2427 'malloc' might be invoked reentrantly.
2428
476371c4
PE
2429 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2430 In other words, assume that every image size is allowed, on non-X
2431 hosts. This assumption is probably wrong, but it lets Emacs compile.
2432
f3fcc40d
AS
24332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2434
2435 * regex.c (re_iswctype): Convert return values to boolean.
2436
350c992f
EZ
24372011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2438
2439 * xdisp.c (compute_display_string_pos): Don't use cached display
2440 string position if the buffer had its restriction changed.
2441 (Bug#9184)
2442
5266b4bb
PE
24432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2446
2573a837 24472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2448
41f55ccd 2449 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2450
39e378da
PE
2451 * bidi.c: Integer size and overflow fixes.
2452 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2453 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2454 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2455 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2456 (bidi_find_other_level_edge):
2457 Use ptrdiff_t instead of EMACS_INT where either will do.
2458 This works better on 32-bit hosts configured --with-wide-int.
2459 (bidi_cache_ensure_space): Check for size-calculation overflow.
2460 Use % rather than repeated addition, for better worst-case speed.
2461 Don't set bidi_cache_size until after xrealloc returns, because it
2462 might not return.
2463 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2464 (bidi_cache_ensure_space): Also check that the bidi cache size
2465 does not exceed that of the largest Lisp string or buffer. See Eli
2466 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2467
5e927815
PE
2468 * alloc.c (__malloc_size_t): Remove.
2469 All uses replaced by size_t. See Andreas Schwab's note
2470 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2471
ca4aa935
PE
2472 * image.c: Improve checking for integer overflow.
2473 (check_image_size): Assume that f is nonnull, since
2474 it is always nonnull in practice. This is one less thing to
2475 worry about when checking for integer overflow later.
2476 (x_check_image_size): New function, which checks for integer
2477 overflow issues inside X.
2478 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2479 This removes the need for a memory_full check.
2480 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2481 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2482 (xbm_read_bitmap_data): Change locals back to 'int', since
2483 their values must fit in 'int'.
2484 (xpm_load_image, png_load, tiff_load):
2485 Invoke x_create_x_image_and_pixmap earlier,
2486 to avoid much needless work if the image is too large.
2487 (tiff_load): Treat overly large images as if
2488 x_create_x_image_and_pixmap failed, not as malloc failures.
2489 (gs_load): Use x_check_image_size.
2490
5f8f9cc2
PE
2491 * gtkutil.c: Omit integer casts.
2492 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2493 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2494
5adf60bc
PE
2495 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2496
c8907a93
PE
2497 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2498 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2499 would wrongly return t on a 64-bit host.
2500
e3c25c68
PE
2501 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2502 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2503 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2504 and therefore cause GCC to emit a bogus diagnostic in some cases.
2505
3f791afe
PE
2506 * image.c: Integer signedness and overflow and related fixes.
2507 This is not an exhaustive set of fixes, but it's time to
2508 record what I've got.
2509 (lookup_pixel_color, check_image_size): Remove redundant decls.
2510 (check_image_size): Don't assume that arbitrary EMACS_INT values
2511 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2512 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2513 (tiff_load, imagemagick_load_image):
2514 Check for overflow in size calculations.
2515 (x_create_x_image_and_pixmap): Remove unnecessary test for
2516 xmalloc returning NULL; that can't happen.
2517 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2518 (xpm_color_bucket): Use better integer hashing function.
2519 (xpm_cache_color): Don't possibly over-allocate memory.
2520 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2521 (gif_memory_source):
2522 Use ptrdiff_t, not int or size_t, to record sizes.
2523 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2524 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2525 either works, as we prefer signed integers.
2526 (tiff_read_from_memory, tiff_write_from_memory):
2527 Return tsize_t, not size_t, since that's what the TIFF API wants.
2528 (tiff_read_from_memory): Don't fail simply because the read would
2529 go past EOF; instead, return a short read.
2530 (tiff_load): Omit no-longer-needed casts.
2531 (Fimagemagick_types): Don't assume size fits into 'int'.
2532
3cc5a532
PE
2533 Improve hashing quality when configured --with-wide-int.
2534 * fns.c (hash_string): New function, taken from sxhash_string.
2535 Do not discard information about ASCII character case; this
2536 discarding is no longer needed.
2537 (sxhash-string): Use it. Change sig to match it. Caller changed.
2538 * lisp.h: Declare it.
2539 * lread.c (hash_string): Remove, since we now use fns.c's version.
2540 The fns.c version returns a wider integer if --with-wide-int is
2541 specified, so this should help the quality of the hashing a bit.
2542
b312a492
PE
2543 * emacs.c: Integer overflow minor fix.
2544 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2545 Define only if GNU_LINUX.
2546 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2547
dfd153ae
PE
2548 * dispnew.c: Integer signedness and overflow fixes.
2549 Remove unnecessary forward decls, that were a maintenance hassle.
2550 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2551 All uses changed.
2552 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2553 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2554 (prepare_desired_row, line_draw_cost):
2555 Use int, not unsigned, where either works.
2556 (save_current_matrix, restore_current_matrix):
2557 Use ptrdiff_t, not size_t, where either works.
2558 (init_display): Check for overflow more accurately, and without
2559 relying on undefined behavior.
2560
a81d11a3
PE
2561 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2562 Remove, replacing with the new symbols in lisp.h. All uses changed.
2563 * fileio.c (make_temp_name):
2564 * filelock.c (lock_file_1, lock_file):
2565 * xdisp.c (message_dolog):
2566 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2567 Use pMd etc. instead.
2568 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2569 replacing the pWIDE etc. symbols removed from editfns.c.
2570
3300e6fd
PE
2571 * keyboard.h (num_input_events): Now uintmax_t.
2572 This is (very slightly) less likely to mess up due to wraparound.
2573 All uses changed.
2574
fd05c7e9
PE
2575 * buffer.c: Integer signedness fixes.
2576 (alloc_buffer_text, enlarge_buffer_text):
2577 Use ptrdiff_t rather than size_t when either will do, as we prefer
2578 signed integers.
2579
903fe15d
PE
2580 * alloc.c: Integer signedness and overflow fixes.
2581 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2582 (__malloc_size_t): Default to size_t, not to int.
2583 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2584 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2585 Prefer ptrdiff_t to size_t when either would do, as we prefer
2586 signed integers.
2587 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2588 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2589 Now const. Initialize with values that are in range even if char
2590 is signed.
2591 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2592 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2593 These functions do the right thing with sizes > 2**32.
2594 (check_depth): Now ptrdiff_t, not int.
2595 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2596 Adjust to new way of storing sizes. Check for size overflow bugs
2597 in rest of code.
2598 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2599 slightly wrong anyway, as it missed one instance of
2600 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2601 (refill_memory_reserve): Omit needless cast to size_t.
2602 (mark_object_loop_halt): Mark as externally visible.
2603
ac82cc6a
PE
2604 * xselect.c: Integer signedness and overflow fixes.
2605 (Fx_register_dnd_atom, x_handle_dnd_message):
2606 Use ptrdiff_t, not size_t, since we prefer signed.
2607 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2608 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2609 x_dnd_atoms_size and x_dnd_atoms_length.
2610
c2d1e36d
PE
2611 * doprnt.c: Prefer signed to unsigned when either works.
2612 * eval.c (verror):
2613 * doprnt.c (doprnt):
2614 * lisp.h (doprnt):
2615 * xdisp.c (vmessage):
2616 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2617 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2618 prefer signed arithmetic to avoid comparison confusion.
2619 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2620 but is a bit tricky.
2621
0e926e56
PE
2622 Assume freestanding C89 headers, string.h, stdlib.h.
2623 * data.c, doprnt.c, floatfns.c, print.c:
2624 Include float.h unconditionally.
2625 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2626 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2627 * regex.c: Likewise for stddef.h, string.h.
2628 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2629 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2630 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2631 (STDC_HEADERS): Remove obsolete defines.
2632 * sysdep.c: Include limits.h unconditionally.
2633
9cfdb3ec
PE
2634 Assume support for memcmp, memcpy, memmove, memset.
2635 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2636 * regex.c (memcmp, memcpy):
2637 Remove; we assume C89 now.
2638
2639 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2640 (__malloc_safe_bcopy): Remove; no longer needed.
2641
cf950e6b 2642 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2643 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2644 well either way, and we prefer signed to unsigned.
2645
dbf38e02
LMI
26462011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2647
2648 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2649 closes the connection while we're reading (bug#9182).
2650
d6f0886c 26512011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2652
d6f0886c
JD
2653 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2654 are specified (Bug#9168).
24e0f6b1 2655
2eb1f9e6
PE
26562011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2659 Found by GCC static checking and --with-wide-int on a 32-bit host.
2660
22381272 26612011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2662
2663 * xdisp.c (compute_display_string_pos): Fix logic of caching
2664 previous display string position. Initialize cached_prev_pos to
2665 -1. Fixes slow-down at the beginning of a buffer.
2666
f25e39b4
EZ
26672011-07-24 Eli Zaretskii <eliz@gnu.org>
2668
2669 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2670 for attrs[LFACE_FONTSET_INDEX].
2671
04c4b52e
PE
26722011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * xml.c (parse_region): Remove unused local
2675 that was recently introduced.
2676
c1734fbd
EZ
26772011-07-23 Eli Zaretskii <eliz@gnu.org>
2678
be18c5a5
EZ
2679 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2680 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2681
c1734fbd
EZ
2682 * xdisp.c (move_it_in_display_line_to): Record the best matching
2683 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2684 exit if none of the characters scanned was an exact match.
2685 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2686 when exact match is impossible due to invisible text, and the
2687 lines are truncated.
2688
a258d627
JD
26892011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2690
2691 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2692 for OSX >= 10.7.
2693
b6d5a689
EZ
26942011-07-22 Eli Zaretskii <eliz@gnu.org>
2695
0f74f785
EZ
2696 Fix a significant slow-down of cursor motion with C-n, C-p,
2697 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2698 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2699 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2700 (next_element_from_buffer): Call compute_stop_pos_backwards to
2701 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2702 base_level_stop.
2703 (reseat): Don't look for prev_stop, as that could mean a very long
2704 run.
2705 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2706 <cached_disp_overlay_modiff>: Cache for last found display string
2707 position.
551918c1 2708 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2709 about the same buffer in the same area of character positions, and
2710 the buffer wasn't changed since the time the display string
2711 position was cached.
551918c1 2712
b2d0c91a
EZ
27132011-07-22 Eli Zaretskii <eliz@gnu.org>
2714
2715 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2716 is an integer, which is important for empty lines. (Bug#9149)
2717
043604ee
CY
27182011-07-22 Chong Yidong <cyd@stupidchicken.com>
2719
2720 * frame.c (Fmodify_frame_parameters): In tty case, update the
2721 default face if necessary (Bug#4238).
2722
da4adb04
CY
27232011-07-21 Chong Yidong <cyd@stupidchicken.com>
2724
2725 * editfns.c (Fstring_to_char): No need to explain what a character
2726 is in the docstring (Bug#6576).
2727
9abd0532
LMI
27282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2729
2730 * xml.c (parse_region): Make sure we always return a tree.
2731
36881d16
HK
27322011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2733
2734 * xml.c (parse_region): If a document contains only comments,
2735 return that, too.
2736
1e98674d
LMI
27372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2738
2739 * xml.c (make_dom): Return comments, too.
2740
590bd467
PE
27412011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 Port to OpenBSD.
2744 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2745 and the surrounding thread.
2746 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2747 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2748 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2749 timer goes off.
2750 * s/openbsd.h (BROKEN_SIGIO): Define.
2751 * unexelf.c (unexec) [__OpenBSD__]:
2752 Don't update the .mdebug section of the Alpha COFF symbol table.
2753
f41628b2
LMI
27542011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2755
2756 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2757 (bug#8460).
2758
b59b67c5
PE
27592011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2760
15e3a074
PE
2761 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2762 This fixes some race conditions on the permissions of any newly
2763 created file.
2764
41bed37d
PE
2765 * alloc.c (valid_pointer_p): Use pipe, not open.
2766 This fixes some permissions issues when debugging.
2767
b59b67c5
PE
2768 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2769 If fchown fails to set both uid and gid, try to set just gid,
2770 as that is sometimes allowed. Adjust the file's mode to eliminate
2771 setuid or setgid bits that are inappropriate if fchown fails.
2772
925a6be7
SM
27732011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2774
2775 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2776 to compare Lisp_Objects.
2777 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2778 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2779 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2780
52968808
AS
27812011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2782
0a6a104b
AS
2783 * lread.c (read_integer): Unread even EOF character.
2784 (read1): Likewise. Properly record start position of symbol.
2785
52968808
AS
2786 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2787 symbol character follows.
2788
9e381cdd
PE
27892011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2792 This works around a problem with the previous change to Fcopy_file.
2793 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2794 and without this change, GCC might complain about discarding
2795 fchown's return value.
2796
b5641435
JB
27972011-07-16 Juanma Barranquero <lekktu@gmail.com>
2798
2799 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2800
a8031457
PE
28012011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2804
dd889327
LMI
28052011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2806
750c33f7
LMI
2807 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2808 it's used from the C level.
2809
dd889327
LMI
2810 * process.c: Use the same condition for POLL_FOR_INPUT in both
2811 keyboard.c and process.c (bug#1858).
2812
87e86684
LM
28132011-07-09 Lawrence Mitchell <wence@gmx.li>
2814
2815 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2816 (Fgnutls_boot): Use it.
2817
64348f40
AS
28182011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2819
2820 * doc.c (Fsubstitute_command_keys): Revert last change.
2821
1d698799
LMI
28222011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2823
f863868c
LMI
2824 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2825 quotes the next character, and doesn't affect other longer
2826 sequences (bug#8935).
2827
1d698799
LMI
2828 * lread.c (syms_of_lread): Clarify that is isn't only
2829 `eval-buffer' and `eval-defun' that's affected by
2830 `lexical-binding' (bug#8460).
2831
aa4b6df6
EZ
28322011-07-15 Eli Zaretskii <eliz@gnu.org>
2833
2834 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2835 bidi redisplay when a line includes both an image and is
2836 truncated.
2837
5d856da6
PE
28382011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2839
ad6042bb
PE
2840 Fix minor problems found by static checking.
2841 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2842 (elsz): Now a signed constant, not a size_t var. We prefer signed
2843 types to unsigned, to avoid integer comparison confusion. Without
2844 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2845 "cannot optimize loop, the loop counter may overflow", a symptom
2846 of the confusion.
f00bbb22 2847 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2848 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2849
6468f31c
LMI
28502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2851
49080b10
LMI
2852 * search.c (Fre_search_backward): Mention `case-fold-search' in
2853 all the re_search_* functions (bug#8138).
2854
6468f31c
LMI
2855 * keyboard.c (Fopen_dribble_file): Document when the file is
2856 closed (bug#8056).
2857
c965adc5
EZ
28582011-07-14 Eli Zaretskii <eliz@gnu.org>
2859
df9733bf
EZ
2860 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2861 bidi_cache_idx.
2862
0bb23927
EZ
2863 Support bidi reordering of display and overlay strings.
2864 * xdisp.c (compute_display_string_pos)
2865 (compute_display_string_end): Accept additional argument STRING.
2866 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2867 (reseat_to_string): Initialize bidi_it->string.s and
2868 bidi_it->string.schars.
2869 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2870 NULL (avoids a crash in bidi_paragraph_init).
2871 Initialize itb.string.lstring.
0bb23927
EZ
2872 (init_iterator): Call bidi_init_it only of a valid
2873 buffer position was specified. Initialize paragraph_embedding to
2874 L2R.
2875 (reseat_to_string): Initialize the bidi iterator.
2876 (display_string): If we need to ignore text properties of
2877 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2878 original value of -1 will not work with bidi.)
2879 (compute_display_string_pos): First arg is now struct
2880 `text_pos *'; all callers changed. Support display properties on
2881 Lisp strings.
2882 (compute_display_string_end): Support display properties on Lisp
2883 strings.
2884 (init_iterator, reseat_1, reseat_to_string): Initialize the
2885 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2886 when iterating on a string not from display properties).
640c8776
SM
2887 (compute_display_string_pos, compute_display_string_end):
2888 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2889 arrow keys.
2890 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2891 base_level_stop; instead, set base_level_stop to BEGV.
2892 Fixes crashes in vertical-motion.
0bb23927
EZ
2893 (next_element_from_buffer): Improve commentary for when
2894 the iterator is before prev_stop.
2895 (init_iterator): Initialize bidi_p from the default value of
2896 bidi-display-reordering, not from buffer-local value. Use the
2897 buffer-local value only if initializing for buffer iteration.
2898 (handle_invisible_prop): Support invisible properties on strings
2899 that are being bidi-reordered.
2900 (set_iterator_to_next): Support bidi reordering of C strings and
2901 Lisp strings.
2902 (next_element_from_string): Support bidi reordering of Lisp
2903 strings.
2904 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2905 (display_string): Support display of R2L glyph rows.
2906 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2907 (init_iterator): Don't initialize it->bidi_p for strings
2908 here.
2909 (reseat_to_string): Initialize it->bidi_p for strings here.
2910 (next_element_from_string, next_element_from_c_string)
2911 (next_element_from_buffer): Add xassert's for correspondence
2912 between IT's object being iterated and it->bidi_it.string
2913 structure.
2914 (face_before_or_after_it_pos): Support bidi iteration.
2915 (next_element_from_c_string): Handle the case of the first string
2916 character that is not the first one in the visual order.
2917 (get_visually_first_element): New function, refactored from common
2918 parts of next_element_from_buffer, next_element_from_string, and
2919 next_element_from_c_string.
2920 (tool_bar_lines_needed, redisplay_tool_bar)
2921 (display_menu_bar): Force left-to-right direction. Add a FIXME
2922 comment for making that be controlled by a user option.
2923 (push_it, pop_it): Save and restore the state of the
2924 bidi iterator. Save and restore the bidi_p flag.
2925 (pop_it): Iterate out of display property for string iteration as
2926 well.
2927 (iterate_out_of_display_property): Support iteration over strings.
2928 (handle_single_display_spec): Set up it->bidi_it for iteration
2929 over a display string, and call bidi_init_it.
2930 (handle_single_display_spec, next_overlay_string)
2931 (get_overlay_strings_1, push_display_prop): Set up the bidi
2932 iterator for displaying display or overlay strings.
2933 (forward_to_next_line_start): Don't use the shortcut if
2934 bidi-iterating.
2935 (back_to_previous_visible_line_start): If handle_display_prop
2936 pushed the iterator stack, restore the internal state of the bidi
2937 iterator by calling bidi_pop_it same number of times.
2938 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2939 and we are bidi-iterating, don't decrement the iterator position;
2940 instead, set the first_elt flag in the bidi iterator, to produce
2941 the same effect.
2942 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2943 (push_display_prop): xassert that we are iterating a buffer.
2944 (push_it, pop_it): Save and restore paragraph_embedding member.
2945 (handle_single_display_spec, next_overlay_string)
2946 (get_overlay_strings_1, reseat_1, reseat_to_string)
2947 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2948 correctly. Don't assume unibyte strings are not bidi-reordered.
2949 (compute_display_string_pos)
2950 (compute_display_string_end): Fix handling the case of C string.
2951 (push_it, pop_it): Save and restore from_disp_prop_p.
2952 (handle_single_display_spec, push_display_prop): Set the
2953 from_disp_prop_p flag.
2954 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2955 (pop_it): Call iterate_out_of_display_property only if we are
2956 popping after iteration over a string that came from a display
2957 property. Fix a typo in popping stretch info. Add an assertion
2958 for verifying that the iterator position is in sync with the bidi
2959 iterator.
2960 (handle_single_display_spec, get_overlay_strings_1)
2961 (push_display_prop): Fix initialization of paragraph direction for
2962 string when that of the parent object is not yet determined.
2963 (reseat_1): Call bidi_init_it to resync the bidi
2964 iterator with IT's position. (Bug#7616)
2965 (find_row_edges): If ROW->start.pos gives position
2966 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2967 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2968 Reset the from_disp_prop_p flag.
2969 (SAVE_IT, RESTORE_IT): New macros.
2970 (pos_visible_p, face_before_or_after_it_pos)
2971 (back_to_previous_visible_line_start)
2972 (move_it_in_display_line_to, move_it_in_display_line)
2973 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2974 (try_scrolling, redisplay_window, display_line): Use them when
2975 saving a temporary copy of the iterator and restoring it back.
2976 (back_to_previous_visible_line_start, reseat_1)
2977 (init_iterator): Empty the bidi cache "stack".
2978 (move_it_in_display_line_to): If iterator ended up at
2979 EOL, but we never saw any buffer positions smaller than
2980 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2981 motion in bidi-reordered lines.
2982 (move_it_in_display_line_to): Record prev_method and prev_pos
2983 immediately before the call to set_iterator_to_next. Fixes cursor
2984 motion in bidi-reordered lines with stretch glyphs and strings
2985 displayed in margins. (Bug#8133) (Bug#8867)
2986 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2987 TO_CHARPOS.
640c8776
SM
2988 (pos_visible_p): Support positions in bidi-reordered lines.
2989 Save and restore bidi cache.
0bb23927
EZ
2990
2991 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2992 (bidi_paragraph_info): Delete unused struct.
2993 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2994 (bidi_cache_start): New variable.
2995 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2996 to zero.
2997 (bidi_cache_fetch_state, bidi_cache_search)
2998 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2999 (bidi_cache_find, bidi_peek_at_next_level)
3000 (bidi_level_of_next_char, bidi_find_other_level_edge)
3001 (bidi_move_to_visually_next): Compare cache index with
3002 bidi_cache_start rather than with zero.
3003 (bidi_fetch_char): Accept new argument STRING; all callers
3004 changed. Support iteration over a string. Support strings with
3005 display properties. Support unibyte strings. Fix the type of
3006 `len' according to what STRING_CHAR_AND_LENGTH expects.
3007 (bidi_paragraph_init, bidi_resolve_explicit_1)
3008 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3009 (bidi_level_of_next_char, bidi_move_to_visually_next):
3010 Support iteration over a string.
0bb23927
EZ
3011 (bidi_set_sor_type, bidi_resolve_explicit_1)
3012 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3013 can now be zero (for strings); special values 0 and -1 were
3014 changed to -1 and -2, respectively.
3015 (bidi_char_at_pos): New function.
3016 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3017 Call it instead of FETCH_MULTIBYTE_CHAR.
3018 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3019 initialized to valid values.
3020 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3021 values.
3022 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3023 the test for valid cached positions. Fix the logic for looking up
3024 the sentinel state in the cache. GCPRO the Lisp string we are
3025 iterating.
3026 (bidi_push_it, bidi_pop_it): New functions.
3027 (bidi_initialize): Initialize the bidi cache start stack pointer.
3028 (bidi_cache_ensure_space): New function, refactored from part of
3029 bidi_cache_iterator_state. Don't assume the required size is just
3030 one BIDI_CACHE_CHUNK away.
3031 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3032 (bidi_count_bytes, bidi_char_at_pos): New functions.
3033 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3034 always valid if bidi_cache_idx is valid.
3035 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3036 is valid if it's going to be used.
3037 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3038 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3039 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3040 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3041 (bidi_find_other_level_edge, bidi_cache_start_stack):
3042 All variables related to cache indices are now EMACS_INT.
c965adc5 3043
0bb23927
EZ
3044 * dispextern.h (struct bidi_string_data): New structure.
3045 (struct bidi_it): New member `string'. Make flag members be 1-bit
3046 fields, and put them last in the struct.
640c8776
SM
3047 (compute_display_string_pos, compute_display_string_end):
3048 Update prototypes.
0bb23927
EZ
3049 (bidi_push_it, bidi_pop_it): Add prototypes.
3050 (struct iterator_stack_entry): New members bidi_p,
3051 paragraph_embedding, and from_disp_prop_p.
3052 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3053 (bidi_shelve_cache, bidi_unshelve_cache):
3054 Declare prototypes.
0bb23927
EZ
3055
3056 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3057 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3058 and vector-like objects.
3059
3060 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3061 cache around display iteration.
3062
3063 * window.c (Fwindow_end, window_scroll_pixel_based)
3064 (displayed_window_lines, Frecenter): Save and restore the bidi
3065 cache around display iteration.
3066
3bbd2265
LMI
30672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3068
3069 * editfns.c (Fdelete_region): Clarify the use of the named
3070 parameters (bug#6788).
3071
adc47434
MR
30722011-07-14 Martin Rudalics <rudalics@gmx.at>
3073
3074 * indent.c (Fvertical_motion): Set and restore w->pointm when
3075 saving and restoring the window's buffer (Bug#9006).
3076
837c31f8
LMI
30772011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3078
3079 * editfns.c (Fstring_to_char): Clarify just what is returned
3080 (bug#6576). Text by Eli Zaretskii.
3081
ac389d0c
JB
30822011-07-13 Juanma Barranquero <lekktu@gmail.com>
3083
3084 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3085
0be0ce47
EZ
30862011-07-13 Eli Zaretskii <eliz@gnu.org>
3087
3088 * buffer.c (mmap_find): Fix a typo.
3089
cd18e7e3
JB
30902011-07-13 Johan Bockgård <bojohan@gnu.org>
3091
3092 Fix execution of x selection hooks.
3093 * xselect.c (Qx_lost_selection_functions)
3094 (Qx_sent_selection_functions): New vars.
3095 (syms_of_xselect): DEFSYM them.
3096 (x_handle_selection_request): Pass Qx_sent_selection_functions
3097 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3098 (x_handle_selection_clear,x_clear_frame_selections):
3099 Pass Qx_lost_selection_functions rather than
3100 Vx_lost_selection_functions to Frun_hook_with_args.
3101
47ea7f44
PE
31022011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3103
ac389d0c 3104 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3105 The old code sometimes used this field without initializing it.
3106
47ea7f44
PE
3107 * alloc.c (gc_sweep): Don't read past end of array.
3108 In theory, the old code could also have corrupted Emacs internals,
3109 though it'd be very unlikely.
3110
bc985c87
AS
31112011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3112
3113 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3114 argument. (Bug#4026)
bc985c87 3115
0cf34688
LMI
31162011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3117
b3dadd76
LMI
3118 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3119 key" (bug#4257).
3120
0cf34688
LMI
3121 * window.c (Fset_window_start): Doc fix (bug#4199).
3122 (Fset_window_hscroll): Ditto.
3123
270768cd
PE
31242011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3125
077e3dda 3126 Fix minor new problems caught by GCC 4.6.1.
270768cd 3127 * term.c (init_tty): Remove unused local.
490011a6 3128 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3129 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3130 not used otherwise.
270768cd 3131
b1f58454
CY
31322011-07-12 Chong Yidong <cyd@stupidchicken.com>
3133
3134 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3135
22b9578d
LMI
31362011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3137
6e70ab07
LMI
3138 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3139 are the mini-buffer and the echo area (bug#3320).
3140
22b9578d
LMI
3141 * term.c (init_tty): Remove support for supdup, c10 and perq
3142 terminals, which are no longer supported (bug#1482).
3143
8974cc9f
JB
31442011-07-10 Johan Bockgård <bojohan@gnu.org>
3145
3146 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3147
a560d974
JD
31482011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3149
3150 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3151 for non-popups (Bug#3642).
3152
1dae0f0a
AS
31532011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3154
268c2c36 3155 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3156 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3157 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3158 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3159 * data.c (fmod): Likewise.
3160 * dispnew.c (swap_glyphs_in_rows): Likewise.
3161 * emacs.c (memory_warning_signal): Likewise.
3162 * floatfns.c (float_error): Likewise.
3163 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3164 (otf_open, font_otf_capability, generate_otf_features)
3165 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3166 Likewise.
3167 * image.c (pbm_read_file): Likewise.
3168 * indent.c (string_display_width): Likewise.
3169 * intervals.c (check_for_interval, search_for_interval)
3170 (inc_interval_count, count_intervals, root_interval)
3171 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3172 * lread.c (defalias): Likewise.
268c2c36 3173 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3174 * regex.c (set_image_of_range_1, set_image_of_range)
3175 (regex_grow_registers): Likewise.
3176 * sysdep.c (strerror): Likewise.
3177 * termcap.c (valid_filename_p, tprint, main): Likewise.
3178 * tparam.c (main): Likewise.
3179 * unexhp9k800.c (run_time_remap, save_data_space)
3180 (update_file_ptrs, read_header, write_header, calculate_checksum)
3181 (copy_file, copy_rest, display_header): Likewise.
3182 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3183 Likewise.
3184 * xdisp.c (check_it): Likewise.
3185 * xfaces.c (register_color, unregister_color, unregister_colors):
3186 Likewise.
3187 * xfns.c (print_fontset_result): Likewise.
3188 * xrdb.c (member, fatal, main): Likewise.
3189
99033785
PE
31902011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 Fix minor problems found by static checking (Bug#9031).
3193 * chartab.c (char_table_set_range, map_sub_char_table):
3194 Remove unused locals.
3195 (uniprop_table): Now static.
3196 * composite.c (_work_char): Remove unused static var.
3197
9cb2ac56
JB
31982011-07-09 Juanma Barranquero <lekktu@gmail.com>
3199
3200 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3201
f25661f0
JD
32022011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3203
3204 * gtkutil.c (qttip_cb): Remove code without function.
3205
8278c4fe
EZ
32062011-07-09 Eli Zaretskii <eliz@gnu.org>
3207
3208 * w32.c (pthread_sigmask): New stub.
3209
1692ae2d 32102011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3211
8a6ebd58 3212 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3213 sigprocmask is portable only for single-threaded applications, and
3214 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3215 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3216 (LIBES): Use it.
3217 * callproc.c (Fcall_process):
3218 * process.c (create_process):
3219 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3220 Use pthread_sigmask, not sigprocmask.
123403e4 3221
1b854618
JD
32222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3223
3224 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3225 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3226 wrong (Bug#8591).
3227
3fe4b549
JD
32282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3229
0ce7e563
JD
3230 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3231 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3232 (xg_hide_tooltip): Fix comment.
3233
3fe4b549
JD
3234 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3235 in registerServicesMenuSendTypes.
3236 (validRequestorForSendType): Don't check ns_return_types.
3237
3238 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3239 ns_return_type.
3240
5df75e47
JR
32412011-07-08 Jason Rumney <jasonr@gnu.org>
3242
3243 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3244 frame struct members of non-existent frames (Bug#6284).
3245
699c10bd
JD
32462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3247
4393663b
JD
3248 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3249 variable firstTime not needed on OSX >= 10.6.
3250 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3251 >= 10.5. Use setKnobProportion, setDoubleValue.
3252
3253 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3254 (MAC_OS_X_VERSION_10_5): Define if not defined.
3255 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3256 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3257 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3258
3259 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3260 cString and lossyCString on OSX >= 10.4
3261
3262 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3263 sizeToFit on OSX >= 10.2.
3264
3265 * nsimage.m (allocInitFromFile): Don't use deprecated method
3266 bestRepresentationForDevice on OSX >= 10.6.
3267
3268 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3269 to avoid warning.
3270
3271 * emacs.c: Declare unexec_init_emacs_zone.
3272
a63e0781
JD
3273 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3274
699c10bd
JD
3275 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3276
3277 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3278 on svcsMenu (Bug#8842).
3279
3280 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3281 ns_return_types.
3282 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3283
3284 * nsterm.m (QUTF8_STRING): Declare.
3285 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3286 (validRequestorForSendType): Return type is (id).
3287 Change indexOfObjectIdenticalTo to indexOfObject.
3288 Check if we have local selection before returning self (Bug#8842).
3289 (writeSelectionToPasteboard): Put local selection into paste board
3290 if we have a local selection (Bug#8842).
3291 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3292
3293 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3294 (ns_get_local_selection): Declare.
3295
54e10184
LMI
32962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3297
9888ff71
LMI
3298 * keymap.c (describe_map_tree): Don't insert a double newline at
3299 the end of the buffer (bug#1169) and return whether we inserted
3300 something.
3301
54e10184
LMI
3302 * callint.c (Fcall_interactively): Change "reading args" to
3303 "providing args" to try to clarify what it does (bug#1010).
3304
15fa4783
KH
33052011-07-07 Kenichi Handa <handa@m17n.org>
3306
3307 * composite.c (composition_compute_stop_pos): Ignore a static
3308 composition starting before CHARPOS (Bug#8915).
3309
3310 * xdisp.c (handle_composition_prop): Likewise.
3311
a8815b00
EZ
33122011-07-07 Eli Zaretskii <eliz@gnu.org>
3313
3314 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3315 (Bug#9015)
3316
ef7b981d 33172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3318
3319 * character.h (unicode_category_t): New enum type.
3320
3321 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3322 (Qchar_code_property_table): New variable.
3323 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3324 (UNIPROP_COMPRESSED_FORM_P): New macros.
3325 (char_table_ascii): Uncompress the compressed values.
3326 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3327 Uncompress the compressed values.
ac389d0c 3328 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3329 (char_table_ref_and_range): Uncompress the compressed values.
3330 (sub_char_table_set): New arg is_uniprop. Callers changed.
3331 Uncompress the compressed values.
3332 (sub_char_table_set_range): Args changed. Callers changed.
3333 (char_table_set_range): Adjuted for the above change.
3334 (map_sub_char_table): Delete args default_val and parent. Add arg
3335 top. Give decoded values to a Lisp function.
640c8776 3336 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3337 values to a Lisp function. Gcpro more variables.
3338 (uniprop_table_uncompress)
3339 (uniprop_decode_value_run_length): New functions.
3340 (uniprop_decoder, uniprop_decoder_count): New variables.
3341 (uniprop_get_decoder, uniprop_encode_value_character)
3342 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3343 New functions.
3344 (uniprop_encoder, uniprop_encoder_count): New variables.
3345 (uniprop_get_encoder, uniprop_table)
3346 (Funicode_property_table_internal, Fget_unicode_property_internal)
3347 (Fput_unicode_property_internal): New functions.
3348 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3349 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3350 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3351 char-code-property-alist.
3352
640c8776 3353 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3354 Vunicode_category_table.
3355
640c8776 3356 * font.c (font_range): Adjust for the change of
c805dec0
KH
3357 Vunicode_category_table.
3358
76b397fb
DN
33592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3360
3361 * m/iris4d.h: Remove file, move contents ...
3362 * s/irix6-5.h: ... here.
3363
22b4128e
PE
33642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3367 * alloc.c (mark_buffer):
3368 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3369 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3370 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3371 This isn't true in general, and it's particularly not true
3372 if Emacs is configured with --with-wide-int.
3373 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3374 New macros, used in the buffer.c change.
3375
869795d6
JD
33762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3377
3378 * xsettings.c: Use both GConf and GSettings if both are available.
3379 (store_config_changed_event): Add comment.
3380 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3381 (store_tool_bar_style_changed): New functions.
5e617bc2 3382 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3383 (struct xsettings): Move font inside HAVE_XFT.
3384 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3385 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3386 Move inside HAVE_XFT.
640c8776 3387 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3388 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3389 also.
3390 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3391 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3392 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3393 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3394 (parse_settings): Move check for font inside HAVE_XFT.
3395 (read_settings, apply_xft_settings): Add comment.
3396 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3397 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3398 call store_font_name_changed.
3399 (xft_settings_event): Add comment.
3400 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3401 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3402 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3403 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3404 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3405 (xsettings_get_system_font, xsettings_get_system_normal_font):
3406 Add comment.
869795d6 3407
d8ed26bd
PE
34082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 Random fixes. E.g., (random) never returned negative values.
3411 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3412 subseconds part to the entropy, as that's a bit more random.
3413 Prefer signed to unsigned, since the signedness doesn't matter and
3414 in general we prefer signed. When given a limit, use a
3415 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3416 latter isn't right if USE_2_TAGS_FOR_INTS.
3417 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3418 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3419
cabf1cac
SM
34202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3421
3422 * textprop.c (text_property_stickiness):
3423 Obey Vtext_property_default_nonsticky.
3424 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3425 * w32fns.c (syms_of_w32fns):
3426 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3427
6e9b2be9
PE
34282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3429
3430 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3431 This is more efficient than Ffile_directory_p and avoids a minor race.
3432
90186c68
LMI
34332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3434
7c301272
LMI
3435 * buffer.c (Foverlay_put): Say what the return value is
3436 (bug#7835).
3437
c4f2d8d4
LMI
3438 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3439 is a directory before asking whether to use the file name
3440 (bug#7564).
ad637907
LMI
3441 (barf_or_query_if_file_exists): Make the "File is a directory"
3442 error be more correct.
c4f2d8d4 3443
90186c68
LMI
3444 * fns.c (Frequire): Remove the mention of the .gz files, since
3445 that's installation-specific, but keep the mention of
3446 `get-load-suffixes'.
3447
da64016e
PE
34482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3449
3450 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3451 Report string overflow if the output is too long.
3452
7d47b580
JB
34532011-07-04 Juanma Barranquero <lekktu@gmail.com>
3454
a555cb87
JB
3455 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3456 (syms_of_gnutls): Remove duplicate DEFSYM for
3457 Qgnutls_bootprop_verify_hostname_error, an error for
3458 Qgnutls_bootprop_verify_error (which is no longer used).
3459
7d47b580
JB
3460 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3461 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3462 Also (re)move comments that are misplaced or no longer relevant.
3463
1e49bfab
LMI
34642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3465
3466 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3467
1485f4c0
CY
34682011-07-03 Chong Yidong <cyd@stupidchicken.com>
3469
3470 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3471 and background color parameters if they have been changed.
3472
a9ab721e
LMI
34732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3474
3475 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3476
cf7cff57
PE
34772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3478
2e13213d
PE
3479 * xsettings.c (SYSTEM_FONT): Define only when used.
3480 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3481
cf7cff57
PE
3482 * keymap.c (access_keymap_1): Now static.
3483
7a8e04f7
CY
34842011-07-02 Chong Yidong <cyd@stupidchicken.com>
3485
3486 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3487 leave any prefix arg for the up event (Bug#1586).
3488
61352f62
LMI
34892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3490
69bb1ef7
LMI
3491 * lread.c (syms_of_lread): Mention single symbols defined by
3492 `defvar' or `defconst' (bug#7154).
3493
61352f62 3494 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3495 (Frequire): Mention get-load-suffixes.
61352f62 3496
28545e04
MR
34972011-07-02 Martin Rudalics <rudalics@gmx.at>
3498
3499 * window.h (window): Remove clone_number slot.
3500 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3501 Remove.
3502 (make_parent_window, make_window, saved_window)
3503 (Fset_window_configuration, save_window_save): Don't deal with
3504 clone numbers.
3505 * buffer.c (Qclone_number): Remove declaration.
3506 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3507
3349e122
SM
35082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3509
3510 Add multiple inheritance to keymaps.
3511 * keymap.c (Fmake_composed_keymap): New function.
3512 (Fset_keymap_parent): Simplify.
3513 (fix_submap_inheritance): Remove.
3514 (access_keymap_1): New function extracted from access_keymap to handle
3515 embedded parents and handle lists of maps.
3516 (access_keymap): Use it.
3517 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3518 (Fcopy_keymap): Handle embedded parents.
3519 (Fcommand_remapping, define_as_prefix): Simplify.
3520 (Fkey_binding): Simplify.
3521 (syms_of_keymap): Move minibuffer-local-completion-map,
3522 minibuffer-local-filename-completion-map,
3523 minibuffer-local-must-match-map, and
3524 minibuffer-local-filename-must-match-map to Elisp.
3525 (syms_of_keymap): Defsubr make-composed-keymap.
3526 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3527 (parse_menu_item): Trivial simplification.
3528
3279eb87
GM
35292011-07-01 Glenn Morris <rgm@gnu.org>
3530
3531 * Makefile.in (SETTINGS_LIBS): Fix typo.
3532
4550efdf
KI
35332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3534
3535 * coding.c (Fencode_coding_string): Record the last coding system
3536 used, as the function doc string says (bug#8738).
3537
0949d2b6
JD
35382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3539
3540 * xsettings.c (store_monospaced_changed): Take new font as arg and
3541 check for change against current_mono_font.
3542 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3543 (emacs_settings_constructor, emacs_settings_get_property)
3544 (emacs_settings_set_property, emacs_settings_class_init)
3545 (emacs_settings_init, gsettings_obj): Remove.
3546 (something_changedCB): New function for HAVE_GSETTINGS.
3547 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3548 with value as argument.
3549 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3550 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3551 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3552 "changed".
3553
3554 * xgselect.c: Add defined (HAVE_GSETTINGS).
3555 (xgselect_initialize): Ditto.
3556
3557 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3558 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3559 xg_select.
3560
bbc6b304
PE
35612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3562
3563 * eval.c (struct backtrace): Simplify and port the data structure.
3564 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3565 signed bit field, as this assumption is not portable and it makes
3566 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3567 "char debug_on_exit : 1" as this is not portable either; instead,
3568 use the portable "unsigned int debug_on_exit : 1". Remove unused
3569 member evalargs. Remove obsolete comments about cc bombing out.
3570
9851bfc5
JD
35712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3572
51bb811f 3573 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3574 Let HAVE_GSETTINGS override HAVE_GCONF.
3575 (store_monospaced_changed): New function.
3576 (EMACS_SETTINGS): A new type derived from GObject to handle
3577 GSettings notifications.
3578 (emacs_settings_constructor, emacs_settings_get_property)
3579 (emacs_settings_set_property, emacs_settings_class_init):
3580 New functions.
3581 (gsettings_client, gsettings_obj): New variables.
3582 (GSETTINGS_SCHEMA): New define.
3583 (something_changedCB): Call store_monospaced_changed.
3584 (init_gsettings): New function.
3585 (xsettings_initialize): Call init_gsettings.
3586 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3587 to NULL.
3588
640c8776 3589 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3590 GCONF_CFLAGS/LIBS.
3591
5386012d
MR
35922011-06-29 Martin Rudalics <rudalics@gmx.at>
3593
3594 * window.c (resize_root_window, grow_mini_window)
3595 (shrink_mini_window): Rename Qresize_root_window to
3596 Qwindow_resize_root_window and Qresize_root_window_vertically to
3597 Qwindow_resize_root_window_vertically.
3598
f13e0b08
PE
35992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3600
3601 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3602
94515237
JB
36032011-06-27 Juanma Barranquero <lekktu@gmail.com>
3604
3605 * makefile.w32-in: Redesign dependencies so they reflect more
3606 clearly which files are directly included by each source file,
3607 and not through other includes.
3608
e43b6e43
MR
36092011-06-27 Martin Rudalics <rudalics@gmx.at>
3610
3611 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3612 (sort_overlays, overlay_strings): When an overlay's clone number
3613 matches the window's clone number process the overlay even if
3614 the overlay's window property doesn't match the current window.
3615
d68443dc
MR
3616 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3617 (Fwindow_hchild): Rename to Fwindow_left_child.
3618 (Fwindow_next): Rename to Fwindow_next_sibling.
3619 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3620 (resize_window_check): Rename to window_resize_check.
3621 (resize_window_apply): Rename to window_resize_apply.
3622 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3623 (Fdelete_other_windows_internal, resize_frame_windows)
3624 (Fsplit_window_internal, Fdelete_window_internal)
3625 (grow_mini_window, shrink_mini_window)
3626 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3627
c7e73be5
JD
36282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3629
3630 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3631 (emacs_fixed_set_min_size): Remove.
3632 (emacs_fixed_new): Take frame as argument.
3633
3634 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3635 (_EmacsFixedPrivate): Remove minwidth/height.
3636 Add struct frame *f.
3637 (emacs_fixed_init): Initialize priv->f.
3638 (get_parent_class, emacs_fixed_set_min_size): Remove.
3639 (emacs_fixed_new): Set priv->f to argument.
3640 (emacs_fixed_get_preferred_width)
3641 (emacs_fixed_get_preferred_height): Use min_width/height from
3642 frames size_hint to set minimum and natural (Bug#8919).
3643 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3644 and use min_width/height from frames size_hint to set
3645 min_width/height (Bug#8919).
3646
3647 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3648 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3649 Fix indentation.
c7e73be5 3650
cf99dcf8
EZ
36512011-06-26 Eli Zaretskii <eliz@gnu.org>
3652
3653 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3654 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3655 called at ZV.
3656
029529ac
CY
36572011-06-26 Chong Yidong <cyd@stupidchicken.com>
3658
3659 * process.c (wait_reading_process_output): Bypass select if
3660 waiting for a cell while ignoring keyboard input, and input is
3661 pending. Suggested by Jan Djärv (Bug#8869).
3662
7a7ef429
PE
36632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3664
3665 Use gnulib's dup2 module instead of rolling our own.
3666 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3667
11fdef7d 36682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3669
3670 * dispnew.c (scrolling_window): Before scrolling, turn off a
3671 mouse-highlight in the window being scrolled.
3672
cd3520a4
JB
36732011-06-24 Juanma Barranquero <lekktu@gmail.com>
3674
3675 Move DEFSYM to lisp.h and use everywhere.
3676
3677 * character.h (DEFSYM): Move declaration...
3678 * lisp.h (DEFSYM): ...here.
3679
3680 * gnutls.c:
3681 * minibuf.c:
3682 * w32menu.c:
3683 * w32proc.c:
3684 * w32select.c: Don't include character.h.
3685
3686 * alloc.c (syms_of_alloc):
3687 * buffer.c (syms_of_buffer):
3688 * bytecode.c (syms_of_bytecode):
3689 * callint.c (syms_of_callint):
3690 * casefiddle.c (syms_of_casefiddle):
3691 * casetab.c (init_casetab_once):
3692 * category.c (init_category_once, syms_of_category):
3693 * ccl.c (syms_of_ccl):
3694 * cmds.c (syms_of_cmds):
3695 * composite.c (syms_of_composite):
3696 * dbusbind.c (syms_of_dbusbind):
3697 * dired.c (syms_of_dired):
3698 * dispnew.c (syms_of_display):
3699 * doc.c (syms_of_doc):
3700 * editfns.c (syms_of_editfns):
3701 * emacs.c (syms_of_emacs):
3702 * eval.c (syms_of_eval):
3703 * fileio.c (syms_of_fileio):
3704 * fns.c (syms_of_fns):
3705 * frame.c (syms_of_frame):
3706 * fringe.c (syms_of_fringe):
3707 * insdel.c (syms_of_insdel):
3708 * keymap.c (syms_of_keymap):
3709 * lread.c (init_obarray, syms_of_lread):
3710 * macros.c (syms_of_macros):
3711 * msdos.c (syms_of_msdos):
3712 * print.c (syms_of_print):
3713 * process.c (syms_of_process):
3714 * search.c (syms_of_search):
3715 * sound.c (syms_of_sound):
3716 * syntax.c (init_syntax_once, syms_of_syntax):
3717 * terminal.c (syms_of_terminal):
3718 * textprop.c (syms_of_textprop):
3719 * undo.c (syms_of_undo):
3720 * w32.c (globals_of_w32):
3721 * window.c (syms_of_window):
3722 * xdisp.c (syms_of_xdisp):
3723 * xfaces.c (syms_of_xfaces):
3724 * xfns.c (syms_of_xfns):
3725 * xmenu.c (syms_of_xmenu):
3726 * xsettings.c (syms_of_xsettings):
3727 * xterm.c (syms_of_xterm): Use DEFSYM.
3728
4228cf16
TZ
37292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3730
cd3520a4 3731 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3732
7fcccf1e
PE
37332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3734
7efb4e0e
PE
3735 Integer and buffer overflow fixes (Bug#8873).
3736
ff5844ad
PE
3737 * print.c (printchar, strout): Check for string overflow.
3738 (PRINTPREPARE, printchar, strout):
3739 Don't set size unless allocation succeeds.
3740
90532f02
PE
3741 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3742 for sizes. Check for string overflow more accurately.
3743 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3744
6d84508d
PE
3745 * macros.c: Integer and buffer overflow fixes.
3746 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3747 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3748 Use ptrdiff_t, not int, for sizes.
3749 Don't increment bufsize until after realloc succeeds.
3750 Check for size-calculation overflow.
3751 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3752
437b2cb4
PE
3753 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3754
8b9ac8b4
PE
3755 * lread.c: Integer overflow fixes.
3756 (read_integer): Radix is now EMACS_INT, not int,
3757 to improve quality of diagnostics for out-of-range radices.
3758 Calculate buffer size correctly for out-of-range radices.
3759 (read1): Check for integer overflow in radices, and in
3760 read-circle numbers.
82cb60d3
PE
3761 (read_escape): Avoid int overflow.
3762 (Fload, openp, read_buffer_size, read1)
3763 (substitute_object_recurse, read_vector, read_list, map_obarray):
3764 Use ptrdiff_t, not int, for sizes.
3765 (read1): Use EMACS_INT, not int, for sizes.
20270765 3766 Check for size overflow.
8b9ac8b4 3767
7fcccf1e
PE
3768 * image.c (cache_image): Check for size arithmetic overflow.
3769
bfbbd7e7
PE
3770 * lread.c: Integer overflow issues.
3771 (saved_doc_string_size, saved_doc_string_length)
3772 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3773 Now ptrdiff_t, not int.
3774 (read1): Don't assume doc string length fits in int. Check for
3775 out-of-range doc string lengths.
3776 (read_list): Don't assume file position fits in int.
39019e54 3777 (read_escape): Check for hex character overflow.
bfbbd7e7 3778
4e323265
LL
37792011-06-22 Leo Liu <sdl.web@gmail.com>
3780
3781 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3782 Move to minibuffer.el.
3783
85fece3e
PE
37842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3785
20b84ce9 3786 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3787 The following patches are for when GLYPH_DEBUG && !XASSERT.
3788 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3789 * dispnew.c (flush_stdout):
3790 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3791 Mark as externally visible.
3792 * dispnew.c (check_window_matrix_pointers): Now static.
3793 * dispnew.c (window_to_frame_vpos):
3794 * xfns.c (unwind_create_frame):
3795 * xterm.c (x_check_font): Remove unused local.
3796 * scroll.c (CHECK_BOUNDS):
3797 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3798 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3799 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3800 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3801 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3802 Now static.
3803 (debug_method_add): Use va_list and vsprintf rather than relying
3804 on undefined behavior with wrong number of arguments.
3805 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3806 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3807 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3808 since we're not interested in debugging glyphs with old libraries.
3809 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3810 GCC 4.6.0's static checking.
3811
0766b489
PE
38122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3813
31fd4b32
PE
3814 Integer overflow and signedness fixes (Bug#8873).
3815 A few related buffer overrun fixes, too.
3816
b79e8648
PE
3817 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3818
0766b489
PE
3819 * dispextern.h (struct face.stipple):
3820 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3821 (x_bitmap_mask, x_allocate_bitmap_record)
3822 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3823 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3824 (x_create_bitmap_from_xpm_data):
3825 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3826 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3827 (.bitmaps_last):
3828 * xfaces.c (load_pixmap):
3829 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3830 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3831 (.bitmaps_last, struct x_output.icon_bitmap):
3832 Use ptrdiff_t, not int, for bitmap indexes.
3833 (x_allocate_bitmap_record): Check for size overflow.
3834 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3835
b081724f
PE
3836 Use ptrdiff_t, not int, for overlay counts.
3837 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3838 * editfns.c (overlays_around, get_pos_property):
3839 * textprop.c (get_char_property_and_overlay):
3840 * xdisp.c (next_overlay_change, note_mouse_highlight):
3841 * xfaces.c (face_at_buffer_position):
21514da7
PE
3842 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3843 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3844 (Fnext_overlay_change, Fprevious_overlay_change)
3845 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3846 Use ptrdiff_t, not int, for sizes.
21514da7 3847 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3848
3de73e5e
PE
3849 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3850
2606c57b
PE
3851 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3852 (x_session_initialize): Do not assume string length fits in int.
3853
aaafe47a
PE
3854 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3855 This is unlikely, but can occur if DPI is outlandish.
3856
2674ddc8 3857 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3858 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3859
28154962
PE
3860 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3861 * xrdb.c (magic_file_p, search_magic_path):
3862 Omit last arg SUFFIX; it was always 0. All callers changed.
3863 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3864
7de51af5
PE
3865 * xfont.c (xfont_match): Avoid need for strlen.
3866
25ed6cc3
PE
3867 * xfns.c: Don't assume strlen fits in int.
3868 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3869
4eab31dd
PE
3870 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3871 not unsigned long, as we prefer signed integers. All callers changed.
3872 Detect integer overflow in repeat count.
3873 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3874 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3875
171e2a58
PE
3876 * termcap.c: Don't assume sizes fit in int and never overflow.
3877 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3878 (gobble_line): Check for size-calculation overflow.
3879
ad39faca 3880 * minibuf.c (Fread_buffer):
6e5bb2dc 3881 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3882 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3883 Don't assume string length fits in int.
3884
52c61c22 3885 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3886 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3887
b5b8c9e5
PE
3888 * font.c: Don't assume string length fits in int.
3889 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3890 Use ptrdiff_t, not int.
ccd6111c
PE
3891 (font_intern_prop): Don't assume string length fits in int.
3892 Don't assume integer property fits in fixnum.
3893 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3894
882f0d81 3895 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3896 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3897 Reformulate so as not to need the command string.
3898 Invoke gzip -cd rather than gunzip, as it's more portable.
3899 (lock_info_type, lock_file_1, lock_file):
3900 Don't assume pid_t and time_t fit in unsigned long.
3901 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3902 (current_lock_owner): Prefer signed type for sizes.
3903 Use memcpy, not strncpy, where memcpy is what is really wanted.
3904 Don't assume (via atoi) that time_t and pid_t fit in int.
3905 Check for time_t and/or pid_t out of range, e.g., via a network share.
3906 Don't alloca where an auto var works fine.
3907
93f4cf88
PE
3908 * fileio.c: Fix some integer overflow issues.
3909 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3910 Don't assume string length fits in int.
3911 (directory_file_name): Don't assume string length fits in long.
3912 (make_temp_name): Don't assume pid fits in int, or that its print
3913 length is less than 20.
3914
f3e92b69
PE
3915 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3916
1bfdaf10
PE
3917 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3918
35016e9a
PE
3919 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3920
3d1e65a1
PE
3921 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3922 We prefer signed integers, even for size calculations.
3923
0b963a93
PE
3924 * emacs.c: Don't assume string length fits in 'int'.
3925 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3926 (main): Don't invoke strlen when not needed.
3927
573f4b54
PE
3928 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3929 (XD_DEBUG_MESSAGE): Don't waste a byte.
3930
989f33ba
PE
3931 * callproc.c (getenv_internal_1, getenv_internal)
3932 (Fgetenv_internal):
965d34eb
PE
3933 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3934
e4d29b33
PE
3935 * lread.c (invalid_syntax): Omit length argument.
3936 All uses changed. This doesn't fix a bug, but it simplifies the
3937 code away from its former Hollerith-constant appearance, and it's
3938 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3939 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3940
eb49b136
PE
3941 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3942 This didn't break anything, but it didn't help either.
3943 It's confusing to put a bogus integer in a place where the actual
3944 value does not matter.
9f62aeb1 3945 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3946 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3947
15375a22
PE
3948 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3949 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3950 implementation.
b61cc01c
PE
3951 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3952 We prefer signed types, and the value cannot exceed the EMACS_INT
3953 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3954 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3955 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3956 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3957
53b2623d
PE
3958 * indent.c (sane_tab_width): New function.
3959 (current_column, scan_for_column, Findent_to, position_indentation)
3960 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3961 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3962
51cab52b 3963 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3964
f2ed8a70
PE
3965 * lisp.h (lint_assume): New macro.
3966 * composite.c (composition_gstring_put_cache):
3967 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3968
abe80cc6
PE
3969 * editfns.c, insdel.c:
3970 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3971
b02c740e
PE
3972 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3973
ebc96716
PE
3974 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3975
b4e50fa0 3976 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3977 Use much-faster test for byte-length change.
311d5d7c 3978 Don't assume string byte-length fits in 'int'.
a4cf38e4 3979 Check that character arg fits in 'int'.
85461888 3980 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3981
c0c1ee9f
PE
3982 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3983
a498d7f4
PE
3984 * fns.c (concat): Catch string overflow earlier.
3985 Do not rely on integer wraparound.
3986
51cab52b
PE
3987 * dispextern.h (struct it.overlay_strings_charpos)
3988 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3989 * xdisp.c (forward_to_next_line_start)
3990 (back_to_previous_visible_line_start)
3991 (reseat_at_next_visible_line_start, next_element_from_buffer):
3992 Don't arbitrarily truncate the value of 'selective' to int.
3993
76031fad
PE
3994 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3995
5eb55db9
PE
3996 * composite.c: Don't truncate sizes to 'int'.
3997 (composition_gstring_p, composition_reseat_it)
3998 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3999 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4000 not EMACS_UINT, for indexes.
5eb55db9 4001
0703a717
PE
4002 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4003
d6202519
PE
4004 * buffer.c: Include <verify.h>.
4005 (struct sortvec.priority, struct sortstr.priority):
8961a454 4006 Now EMACS_INT, not int.
c20998a7 4007 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4008 (struct sortstr.size, record_overlay_string)
4009 (struct sortstrlist.size, struct sortlist.used):
4010 Don't truncate size to int.
4011 (record_overlay_string): Check for size-calculation overflow.
d6202519 4012 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4013
d5a19415
JM
40142011-06-22 Jim Meyering <meyering@redhat.com>
4015
029529ac 4016 Don't leak an XBM-image-sized buffer
d5a19415
JM
4017 * image.c (xbm_load): Free the image buffer after using it.
4018
a9041e6c
PE
40192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 Port to Sun C.
4022 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4023 that Sun C diagnosed.
4024 * fns.c (secure_hash): Fix pointer signedness issue.
4025 * intervals.c (static_offset_intervals): New function.
4026 (offset_intervals): Use it.
4027
7f3f739f
LL
40282011-06-21 Leo Liu <sdl.web@gmail.com>
4029
4030 * deps.mk (fns.o):
4031 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4032 sha512.h.
4033
4034 * fns.c (secure_hash): Rename from crypto_hash_function and change
4035 the first arg to accept symbols.
5b66d427 4036 (Fsecure_hash): New primitive.
7f3f739f
LL
4037 (syms_of_fns): New symbols.
4038
76147d94
DD
40392011-06-20 Deniz Dogan <deniz@dogan.se>
4040
4041 * process.c (Fset_process_buffer): Clarify return value in
4042 docstring.
4043
7d7d0045
CY
40442011-06-18 Chong Yidong <cyd@stupidchicken.com>
4045
4046 * dispnew.c (add_window_display_history): Use BVAR.
4047
4048 * xdisp.c (debug_method_add): Use BVAR.
4049 (check_window_end, dump_glyph_matrix, dump_glyph)
4050 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4051
4052 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4053 Likewise.
4054
4055 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4056 check till after the cache is created in init_frame_faces.
4057
ff2bc410
SM
40582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4059
4060 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4061
28177add
PE
40622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4063
dd3482fe
PE
4064 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4065 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4066 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4067
393d71f3 4068 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4069 * fileio.c (Finsert_file_contents):
4070 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4071 Remove the old (too-loose) buffer overflow checks.
4072 They weren't needed, since make_gap checks for buffer overflow.
4073 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4074 The old code merely checked for Emacs fixnum overflow, and relied
4075 on undefined (wraparound) behavior. The new code avoids undefined
4076 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4077
2e6813b0 4078 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4079 Tune. Don't use wider integers than needed. Don't use alloca.
4080 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4081
599a9e4f
PE
4082 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4083
99561444
PE
4084 * insdel.c, lisp.h (buffer_overflow): New function.
4085 (insert_from_buffer_1, replace_range, replace_range_2):
4086 * insdel.c (make_gap_larger):
4087 * editfns.c (Finsert_char):
4088 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4089
28177add
PE
4090 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4091
e69dafad
PE
40922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4093
a7af7fde 4094 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4095
b1c46f02
PE
4096 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4097 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4098
e69dafad
PE
4099 * fileio.c: Don't assume EMACS_INT fits in off_t.
4100 (emacs_lseek): New static function.
4101 (Finsert_file_contents, Fwrite_region): Use it.
4102 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4103
566684ea
PE
4104 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4105
e6966cd6
PE
4106 * fns.c: Don't overflow int when computing a list length.
4107 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4108 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4109 truncation on 64-bit hosts. Check for QUIT every
4110 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4111 faster and is responsive enough.
4112 (Flength): Report an error instead of overflowing an integer.
4113 (Fsafe_length): Return a float if the value is not representable
4114 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4115 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4116 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4117
dd0b0efb
PE
4118 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4119 (header_size, word_size): New constants.
4120 (allocate_vectorlike): Don't check size overflow here.
4121 (allocate_vector): Check it here instead, since this is the only
4122 caller of allocate_vectorlike that could cause overflow.
4123 Check that the new vector's length is representable as a fixnum.
4124
86fe5cfe
PE
4125 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4126 The previous code was bogus. For example, next_almost_prime (32)
4127 returned 39, which is undesirable as it is a multiple of 3; and
4128 next_almost_prime (24) returned 25, which is a multiple of 5 so
4129 why was the code bothering to check for multiples of 7?
4130
80e88859
PE
4131 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4132
4a2f0ad6
PE
4133 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4134
f66c7cf8
PE
4135 Variadic C functions now count arguments with ptrdiff_t.
4136 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4137 Back then I didn't know that the Emacs coding style prefers signed int.
4138 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4139 were being counted with int, which may truncate counts on 64-bit
4140 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4141 * lisp.h (struct Lisp_Subr.function.aMANY)
4142 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4143 Arg counts are now ptrdiff_t, not size_t.
4144 All variadic functions and their callers changed accordingly.
4145 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4146 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4147 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4148 * callint.c (Fcall_interactively): Check arg count for overflow,
4149 to avoid potential buffer overrun. Use signed char, not 'int',
4150 for 'varies' array, so that we needn't bother to check its size
4151 calculation for overflow.
4152 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4153 * eval.c (apply_lambda):
4154 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4155 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4156 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4157
a1759b76
PE
4158 * callint.c (Fcall_interactively): Don't use index var as event count.
4159
d96be9fc
PE
4160 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4161 * mem-limits.h (SIZE): Remove; no longer used.
4162
a690a978 4163 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4164
578c21e6
PE
4165 Remove unnecessary casts.
4166 * xterm.c (x_term_init):
4167 * xfns.c (x_set_border_pixel):
4168 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4169 These aren't needed now that we assume ANSI C.
4170
96f53c6c
PE
4171 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4172 It's more likely to cause problems (due to unsigned overflow)
4173 than to cure them.
4174
83c77d31
PE
4175 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4176
ee2079f1
PE
4177 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4178
6da65536
PE
4179 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4180
7147c4a4
PE
4181 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4182
193e32d9
PE
4183 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4184
e5533da6
PE
4185 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4186
9910e595
PE
4187 GLYPH_CODE_FACE returns EMACS_INT, not int.
4188 * dispextern.h (merge_faces):
4189 * xfaces.c (merge_faces):
01103c44
PE
4190 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4191 Don't assume EMACS_INT fits in int.
9910e595 4192
2638320e
PE
4193 * character.h (CHAR_VALID_P): Remove unused parameter.
4194 * fontset.c, lisp.h, xdisp.c: All uses changed.
4195
045eb8d9
PE
4196 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4197
c1f134b5
PE
4198 * fns.c (concat): Minor tuning based on overflow analysis.
4199 This doesn't fix any bugs. Use int to hold character, instead
4200 of constantly refetching from Emacs object. Use XFASTINT, not
4201 XINT, for value known to be a character. Don't bother comparing
4202 a single byte to 0400, as it's always less.
4203
395fcb93 4204 * floatfns.c (Fexpt):
327eeec8
PE
4205 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4206
abbd3d23
PE
4207 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4208 for characters.
4209
684a03ef
PE
4210 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4211
0fed43f3
PE
4212 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4213 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4214 incorrectly succeed when S was a string, because 4294967386 was
4215 truncated before it was used.
4216
8fd02eb7
PE
4217 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4218 Otherwise, an out-of-range integer could cause undefined behavior
4219 on a 64-bit host.
4220
f8c86b69
PE
4221 * composite.c: Use int, not EMACS_INT, for characters.
4222 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4223 EMACS_INT, for values that are known to be in character range.
4224 This doesn't fix any bugs but is the usual style inside Emacs and
4225 may generate better code on 32-bit machines.
4226
34206dd2
PE
4227 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4228 This is for reasons similar to the recent CHAR_STRING fix.
4229 * charset.c (Fencode_char): Check that character arg is actually
4230 a character. Pass an int to ENCODE_CHAR.
4231 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4232 wider than 'int', as a compile-time check to prevent future regressions
4233 in this area.
4234
c5958d4c 4235 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4236
4237 Make sure a 64-bit char is never passed to CHAR_STRING.
4238 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4239 by silently ignoring the top 32 bits, allowing some values
4240 that were far too large to be valid characters.
4241 * character.h: Include <verify.h>.
4242 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4243 arguments are no wider than unsigned, as a compile-time check
4244 to prevent future regressions in this area.
4245 * data.c (Faset):
01103c44 4246 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4247 (Fsubst_char_in_region):
4248 * fns.c (concat):
4249 * xdisp.c (decode_mode_spec_coding):
4250 Adjust to CHAR_STRING's new requirement.
4251 * editfns.c (Finsert_char, Fsubst_char_in_region):
4252 * fns.c (concat): Check that character args are actually
4253 characters. Without this test, these functions did the wrong
4254 thing with wildly out-of-range values on 64-bit hosts.
4255
d37ca623
PE
4256 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4257 These casts should not be needed on 32-bit hosts, either.
4258 * keyboard.c (read_char):
4259 * lread.c (Fload): Remove casts to unsigned.
4260
ea204efb
PE
4261 * lisp.h (UNSIGNED_CMP): New macro.
4262 This fixes comparison bugs on 64-bit hosts.
4263 (ASCII_CHAR_P): Use it.
4264 * casefiddle.c (casify_object):
01103c44 4265 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4266 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4267 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4268 * dispextern.h (FACE_FROM_ID):
4269 * keyboard.c (read_char): Use UNSIGNED_CMP.
4270
41cb286c
PE
4271 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4272 not to EMACS_INT, to avoid GCC warning.
4273
4a1b9832
PE
4274 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4275
55daad71
PE
4276 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4277 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4278 isn't needed on 32-bit machines.
8f95c75c 4279
01103c44
PE
4280 * buffer.c (Fgenerate_new_buffer_name):
4281 Use EMACS_INT for count, not int.
0ceccced 4282 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4283
4284 * data.c (Qcompiled_function): Now static.
4285
c6f072e7
PE
4286 * window.c (window_body_lines): Now static.
4287
20ce5912
PE
4288 * image.c (gif_load): Rename local to avoid shadowing.
4289
9c4c5f81
PE
4290 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4291 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4292 * alloc.c (make_save_value): Integer argument is now of type
4293 ptrdiff_t, not int.
4294 (mark_object): Use ptrdiff_t, not int.
4295 * lisp.h (pD): New macro.
4296 * print.c (print_object): Use it.
4297
c0c5c8ae
PE
4298 * alloc.c: Use EMACS_INT, not int, to count objects.
4299 (total_conses, total_markers, total_symbols, total_vector_size)
4300 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4301 (total_free_floats, total_floats, total_free_intervals)
4302 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4303 Now EMACS_INT, not int. All uses changed.
4304 (Fgarbage_collect): Compute overall total using a double, so that
4305 integer overflow is less likely to be a problem. Check for overflow
4306 when converting back to an integer.
5a25e253
PE
4307 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4308 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4309 These were 'int' variables that could overflow on 64-bit hosts;
4310 they were never used, so remove them instead of repairing them.
211a0b2a 4311 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4312 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4313 Previously, this ceilinged at INT_MAX, but that doesn't work on
4314 64-bit machines.
e46bb31a 4315 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4316
c78baabf 4317 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4318 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4319 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4320 when a (possibly-narrower) signed value would do just as well.
4321 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4322
c9d624c6
PE
4323 * alloc.c: Catch some string size overflows that we were missing.
4324 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4325 for convenience in STRING_BYTES_MAX.
4326 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4327 The definition here is exact; the one in lisp.h was approximate.
4328 (allocate_string_data): Check for string overflow. This catches
4329 some instances we weren't catching before. Also, it catches
4330 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4331 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4332 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4333
c9d624c6
PE
4334 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4335 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4336 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4337
353032ce
PE
4338 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4339
2bccce07
PE
4340 * alloc.c (Fmake_string): Check for out-of-range init.
4341
0ac30604
SM
43422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4343
4344 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4345
c195f2de
JD
43462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4347
4348 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4349 xg_get_default_scrollbar_width.
4350
4351 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4352 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4353 (style_changed_cb): Call update_theme_scrollbar_width and call
4354 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4355 all frames (Bug#8505).
4356 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4357 Call gtk_window_set_resizable if HAVE_GTK3.
4358 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4359 and height if HAVE_GTK3 (Bug#8505).
4360 (scroll_bar_width_for_theme): New variable.
4361 (update_theme_scrollbar_width): New function.
4362 (xg_get_default_scrollbar_width): Move code to
4363 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4364 (xg_initialize): Call update_theme_scrollbar_width.
4365
4366 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4367
4368 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4369
e10ac9f1
MR
43702011-06-12 Martin Rudalics <rudalics@gmx.at>
4371
4372 * frame.c (make_frame): Call other_buffer_safely instead of
4373 other_buffer.
4374
4375 * window.c (temp_output_buffer_show): Call display_buffer with
4376 second argument Vtemp_buffer_show_specifiers and reset latter
4377 immediately after the call.
4378 (Vtemp_buffer_show_specifiers): New variable.
4379 (auto_window_vscroll_p, next_screen_context_lines)
4380 (Vscroll_preserve_screen_position): Remove leading asterisks from
4381 doc-strings.
4382
2d3c217e 43832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4384
7b7f97e8 4385 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4386 * buffer.c (Qclone_number): Remove for now, as it's unused.
4387 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4388 (record_buffer): Remove unused local.
4389 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4390 (set_frame_buffer_list): Remove; unused.
4391 * frame.h (other_visible_frames): Remove decl.
4392 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4393 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4394 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4395 if HAVE_GPM.
4396 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4397 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4398 Define only if HAVE_GPM.
4399 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4400 (update_hints_inhibit): Remove; never set. All uses removed.
4401 * widgetprv.h (emacsFrameClassRec): Remove decl.
4402 * window.c (delete_deletable_window): Now returns void, since it
4403 wasn't returning anything.
4404 (compare_window_configurations): Remove unused locals.
4405 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4406 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4407 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4408 the same widths as pointers. This follows up on the 2011-05-06 patch.
4409 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4410 * xterm.h: Likewise.
4411 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4412
1384b89e
JB
44132011-06-12 Juanma Barranquero <lekktu@gmail.com>
4414
4415 * makefile.w32-in: Update dependencies.
4416 (LISP_H): Add lib/intprops.h.
4417
1100a63c
CY
44182011-06-11 Chong Yidong <cyd@stupidchicken.com>
4419
4420 * image.c (gif_load): Add animation frame delay to the metadata.
4421 (syms_of_image): Use DEFSYM. New symbol `delay'.
4422
6198ccd0
MR
44232011-06-11 Martin Rudalics <rudalics@gmx.at>
4424
4425 * window.c (delete_deletable_window): Re-add.
4426 (Fset_window_configuration): Rewrite to handle dead buffers and
4427 consequently deletable windows.
4428 (window_tree, Fwindow_tree): Remove. Supply functionality in
4429 window.el.
4430 (compare_window_configurations): Simplify code.
4431
b6e3633c
AS
44322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4433
1ab0dee5
AS
4434 * image.c (imagemagick_load_image): Fix type mismatch.
4435 (Fimagemagick_types): Likewise.
4436
b6e3633c
AS
4437 * window.h (replace_buffer_in_windows): Declare.
4438
9397e56f
MR
44392011-06-11 Martin Rudalics <rudalics@gmx.at>
4440
4441 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4442 Qclone_number. Remove external declaration of Qdelete_window.
4443 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4444 code.
640c8776
SM
4445 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4446 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4447 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4448 buffer list implementation.
4449 (other_buffer_safely): New function.
4450 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4451 calls to replace_buffer_in_windows and
4452 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4453 if allowed.
4454 (record_buffer): Inhibit quitting and rewrite using quittable
4455 functions. Run Qbuffer_list_update_hook if allowed.
4456 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4457 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4458 Move switch-to-buffer to window.el.
9397e56f
MR
4459 (bury-buffer): Move to window.el.
4460 (Vbuffer_list_update_hook): New variable.
4461
4462 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4463 section.
4464
4465 * window.h (resize_frame_windows): Move up in code.
4466 (Fwindow_frame): Remove EXFUN.
4467 (replace_buffer_in_all_windows): Remove prototype.
4468 (replace_buffer_in_windows_safely): Add prototype.
4469
4470 * window.c: Declare Qdelete_window static again. Move down
4471 declaration of select_count.
4472 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4473 (Fother_window): Move to window.el.
4474 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4475 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4476 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4477 window.el.
4478 (replace_buffer_in_windows): Implement by calling
4479 Qreplace_buffer_in_windows.
4480 (replace_buffer_in_all_windows): Remove with some functionality
4481 moved into replace_buffer_in_windows_safely.
4482 (replace_buffer_in_windows_safely): New function.
4483 (select_window_norecord, select_frame_norecord): Move in front
4484 of run_window_configuration_change_hook. Remove now obsolete
4485 declarations.
640c8776
SM
4486 (Fset_window_buffer): Rewrite doc-string.
4487 Call Qrecord_window_buffer.
9397e56f
MR
4488 (keys_of_window): Move binding for other-window to window.el.
4489
b50691aa
CY
44902011-06-11 Chong Yidong <cyd@stupidchicken.com>
4491
4492 * dispextern.h (struct image): Replace data member, whose int_val
4493 and ptr_val fields were not used by anything, with a single
4494 lisp_val object.
4495
4496 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4497 (gif_clear_image, gif_load, imagemagick_load_image)
4498 (gs_clear_image, gs_load): Callers changed.
4499
3f754b86
PE
45002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4501
cca69397
PE
4502 * buffer.h: Include <time.h>, for time_t.
4503 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4504
109e28d0
PE
4505 Fix minor problems found by static checking.
4506
60737f02
PE
4507 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4508
4b66faf3
PE
4509 Make identifiers static if they are not used in other modules.
4510 * data.c (Qcompiled_function, Qframe, Qvector):
4511 * image.c (QimageMagick, Qsvg):
4512 * minibuf.c (Qmetadata):
4513 * window.c (resize_window_check, resize_root_window): Now static.
4514 * window.h (resize_window_check, resize_root_window): Remove decls.
4515
109e28d0
PE
4516 * window.c (window_deletion_count, delete_deletable_window):
4517 Remove; unused.
46a4ce9e
PE
4518 (window_body_lines): Now static.
4519 (Fdelete_other_windows_internal): Mark vars as initialized.
4520 Make sure 'resize_failed' is initialized.
4521 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4522 (resize_window_apply): Remove unused local.
4523 * window.h (delete_deletable_window): Remove decl.
4524
109e28d0 4525 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4526 (imagemagick_load_image): Fix pointer signedness problem by changing
4527 last arg from unsigned char * to char *. All uses changed.
4528 Also, fix a local for similar reasons.
4529 Remove unused locals. Remove locals to avoid shadowing.
4530 (fn_rsvg_handle_free): Remove; unused.
4531 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4532 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4533
3f754b86
PE
4534 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4535
2547adb1
CY
45362011-06-10 Chong Yidong <cyd@stupidchicken.com>
4537
4538 * image.c (gif_load): Fix omitted cast error introduced by
4539 2011-06-06 change.
4540
2c8e37d4
MR
45412011-06-10 Martin Rudalics <rudalics@gmx.at>
4542
4543 * window.h (resize_proportionally, orig_total_lines)
4544 (orig_top_line): Remove from window structure.
4545 (set_window_height, set_window_width, change_window_heights)
4546 (Fdelete_window): Remove prototypes.
4547 (resize_frame_windows): Remove duplicate declaration.
4548
440a42e3
EZ
45492011-06-10 Eli Zaretskii <eliz@gnu.org>
4550
4551 * window.h (resize_frame_windows, resize_window_check)
4552 (delete_deletable_window, resize_root_window)
4553 (resize_frame_windows): Declare prototypes.
4554
4555 * window.c (resize_window_apply): Make definition be "static" to
4556 match the prototype.
4557
562dd5e9
MR
45582011-06-10 Martin Rudalics <rudalics@gmx.at>
4559
4560 * window.c: Remove declarations of Qwindow_size_fixed,
4561 window_min_size_1, window_min_size_2, window_min_size,
4562 size_window, window_fixed_size_p, enlarge_window, delete_window.
4563 Remove static from declaration of Qdelete_window, it's
4564 temporarily needed by Fbury_buffer.
4565 (replace_window): Don't assign orig_top_line and
4566 orig_total_lines.
4567 (Fdelete_window, delete_window): Remove. Window deletion is
4568 handled by window.el.
640c8776
SM
4569 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4570 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4571 (Fdelete_other_windows): Remove. Deleting other windows is
4572 handled by window.el.
4573 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4574 handled in window.el.
4575 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4576 Window minimum sizes are handled in window.el.
4577 (shrink_windows, size_window, set_window_height)
4578 (set_window_width, change_window_heights, window_height)
4579 (window_width, CURBEG, CURSIZE, enlarge_window)
4580 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4581 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4582 handled in window.el.
4583 (make_dummy_parent): Rename to make_parent_window and give it a
4584 second argument horflag.
4585 (make_window): Don't set resize_proportionally any more.
4586 (Fsplit_window): Remove. Windows are split in window.el.
4587 (save_restore_action, save_restore_orig_size)
4588 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4589 Resize mini windows in window.el.
4590 (grow_mini_window, shrink_mini_window): Implement by calling
4591 Qresize_root_window_vertically, resize_window_check and
4592 resize_window_apply.
640c8776
SM
4593 (saved_window, Fset_window_configuration, save_window_save):
4594 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4595 resize_proportionally.
4596 (window_min_height, window_min_width): Move to window.el.
4597 (keys_of_window): Move bindings for delete-other-windows,
4598 split-window, delete-window and enlarge-window to window.el.
4599
4600 * buffer.c: Temporarily extern Qdelete_window.
4601 (Fbury_buffer): Temporarily call Qdelete_window instead of
4602 Fdelete_window (Fbury_buffer will move to window.el soon).
4603
4604 * frame.c (set_menu_bar_lines_1): Remove code handling
4605 orig_top_line and orig_total_lines.
4606
4607 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4608 set_window_height but set heights directly.
4609 (change_frame_size_1): Use resize_frame_windows.
4610
4611 * xdisp.c (init_xdisp): Don't use set_window_height but set
4612 heights directly.
4613
640c8776
SM
4614 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4615 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4616 run_window_configuration_change_hook.
4617
4618 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4619 instead of change_window_heights and run
4620 run_window_configuration_change_hook.
4621
1a13852e
MR
46222011-06-09 Martin Rudalics <rudalics@gmx.at>
4623
4624 * window.c (replace_window): Rename second argument REPLACEMENT to
4625 NEW. New third argument SETFLAG. Rewrite.
4626 (delete_window, make_dummy_parent): Call replace_window with
4627 third argument 1.
4628 (window_list_1): Move down in code.
4629 (run_window_configuration_change_hook): Move set_buffer part
4630 before select_frame_norecord part in order to unwind correctly.
4631 Rename count1 to count.
4632 (recombine_windows, delete_deletable_window, resize_root_window)
4633 (Fdelete_other_windows_internal)
4634 (Frun_window_configuration_change_hook, make_parent_window)
4635 (resize_window_check, resize_window_apply, Fresize_window_apply)
4636 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4637 (Fdelete_window_internal, Fresize_mini_window_internal):
4638 New functions.
1a13852e
MR
4639 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4640
f3d1777e
MR
46412011-06-08 Martin Rudalics <rudalics@gmx.at>
4642
496e208e
MR
4643 * window.h (window): Add some new members to window structure -
4644 normal_lines, normal_cols, new_total, new_normal, clone_number,
4645 splits, nest, prev_buffers, next_buffers.
4646 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4647 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4648
f3d1777e
MR
4649 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4650 Remove.
496e208e
MR
4651 (make_dummy_parent): Set new members of windows structure.
4652 (make_window): Move down in code. Handle new members of window
4653 structure.
4654 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4655 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4656 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4657 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4658 (Fset_window_next_buffers, Fset_window_clone_number):
4659 New functions.
496e208e
MR
4660 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4661 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4662 Doc-string fixes.
4663 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4664 Argument WINDOW can be now internal window too.
4665 (Fwindow_use_time): Move up in code.
4666 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4667 Rewrite doc-string.
4668 (Fset_window_configuration, saved_window)
4669 (Fcurrent_window_configuration, save_window_save): Handle new
4670 members of window structure.
b9e809c2
MR
4671 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4672 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4673 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4674 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4675 Qget_mru_window, Qresize_root_window,
4676 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4677 Qauto_buffer_name; staticpro them.
f3d1777e 4678
abde8f8c
MR
46792011-06-07 Martin Rudalics <rudalics@gmx.at>
4680
4681 * window.c (Fwindow_total_size, Fwindow_left_column)
4682 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4683 (Fwindow_list_1): New functions.
4684 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4685 (Fwindow_width, Fscroll_left, Fscroll_right):
4686 Use window_body_cols instead of window_box_text_cols.
4687 (delete_window, Fset_window_configuration):
4688 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4689 (delete_all_subwindows): Take a window as argument and not a
4690 structure. Rewrite.
190b47e6
MR
4691 (window_loop): Remove handling of GET_LRU_WINDOW and
4692 GET_LARGEST_WINDOW.
4693 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4694
4695 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4696 window_box_text_cols. delete_all_subwindows now takes a
4697 Lisp_Object as argument.
abde8f8c 4698
640c8776
SM
4699 * indent.c (compute_motion, Fcompute_motion):
4700 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4701
fa8a67e6
MR
4702 * frame.c (delete_frame): Call delete_all_subwindows with root
4703 window as argument.
4704
a54e3482
DC
47052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4706
4707 * fns.c (Fputhash): Document return value.
4708
60002bf5
CY
47092011-06-06 Chong Yidong <cyd@stupidchicken.com>
4710
4711 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4712
0c671da6 47132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4714
b862a52a 4715 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4716
be44ca6c
PE
4717 Check for overflow when converting integer to cons and back.
4718 * charset.c (Fdefine_charset_internal, Fdecode_char):
4719 Use cons_to_unsigned to catch overflow.
4720 (Fencode_char): Use INTEGER_TO_CONS.
4721 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4722 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4723 * data.c (long_to_cons, cons_to_long): Remove.
4724 (cons_to_unsigned, cons_to_signed): New functions.
4725 These signal an error for invalid or out-of-range values.
4726 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4727 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4728 * font.c (Ffont_variation_glyphs):
4729 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4730 * lisp.h: Include <intprops.h>.
4731 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4732 (cons_to_signed, cons_to_unsigned): New decls.
4733 (long_to_cons, cons_to_long): Remove decls.
4734 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4735 (Fprimitive_undo): Use CONS_TO_INTEGER.
4736 * xfns.c (Fx_window_property): Likewise.
4737 * xselect.c: Include <limits.h>.
4738 (x_own_selection, selection_data_to_lisp_data):
4739 Use INTEGER_TO_CONS.
4740 (x_handle_selection_request, x_handle_selection_clear)
4741 (x_get_foreign_selection, Fx_disown_selection_internal)
4742 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4743 (lisp_data_to_selection_data): Use cons_to_unsigned.
4744 (x_fill_property_data): Use cons_to_signed.
4745 Report values out of range.
4746
d1f3d2af
PE
4747 Check for buffer and string overflow more precisely.
4748 * buffer.h (BUF_BYTES_MAX): New macro.
4749 * lisp.h (STRING_BYTES_MAX): New macro.
4750 * alloc.c (Fmake_string):
4751 * character.c (string_escape_byte8):
4752 * coding.c (coding_alloc_by_realloc):
4753 * doprnt.c (doprnt):
4754 * editfns.c (Fformat):
4755 * eval.c (verror):
4756 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4757 since they may not be the same number.
4758 * editfns.c (Finsert_char):
4759 * fileio.c (Finsert_file_contents):
4760 Likewise for BUF_BYTES_MAX.
4761
dd52fcea
PE
4762 * image.c: Use ptrdiff_t, not int, for sizes.
4763 (slurp_file): Switch from int to ptrdiff_t.
4764 All uses changed.
4765 (slurp_file): Check that file size fits in both size_t (for
4766 malloc) and ptrdiff_t (for sanity and safety).
4767
7f9bbdbb
PE
4768 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4769 if b->modtime has its maximal value.
4770
dfe18f82
PE
4771 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4772
84acfcf0
PE
4773 Don't assume time_t can fit into int.
4774 * buffer.h (struct buffer.modtime): Now time_t, not int.
4775 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4776 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4777
ccd9a01a
PE
4778 Minor fixes for signed vs unsigned integers.
4779 * character.h (MAYBE_UNIFY_CHAR):
4780 * charset.c (maybe_unify_char):
4781 * keyboard.c (read_char, reorder_modifiers):
4782 XINT -> XFASTINT, since the integer must be nonnegative.
4783 * ftfont.c (ftfont_spec_pattern):
4784 * keymap.c (access_keymap, silly_event_symbol_error):
4785 XUINT -> XFASTINT, since the integer must be nonnegative.
4786 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4787 since it makes no difference and we prefer signed.
4788 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4789 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4790 nonnegative.
4791
d6d100dd
SM
47922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4793
4794 * window.h (Fwindow_frame): Declare.
4795
2b6148e4
PE
47962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4797
4798 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4799 (SPARE_MEMORY): Always define.
4800 (LARGE_REQUEST): Remove.
4801 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4802
f230ecc9
MR
48032011-06-06 Martin Rudalics <rudalics@gmx.at>
4804
727e958e
MR
4805 * lisp.h: Move EXFUNS for Fframe_root_window,
4806 Fframe_first_window and Fset_frame_selected_window to window.h.
4807
4808 * window.h: Move EXFUNS for Fframe_root_window,
4809 Fframe_first_window and Fset_frame_selected_window here from
4810 lisp.h.
4811
4812 * frame.c (Fwindow_frame, Fframe_first_window)
4813 (Fframe_root_window, Fframe_selected_window)
4814 (Fset_frame_selected_window): Move to window.c.
4815 (Factive_minibuffer_window): Move to minibuf.c.
4816 (Fother_visible_frames_p): New function.
4817
4818 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4819
f230ecc9
MR
4820 * window.c (decode_window, decode_any_window): Move up in code.
4821 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4822 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4823 (Fwindow_buffer): Move up and rewrite doc-string.
4824 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4825 (Fwindow_prev): New functions.
727e958e
MR
4826 (Fwindow_frame): Move here from frame.c. Accept any window as
4827 argument.
4828 (Fframe_root_window, Fframe_first_window)
4829 (Fframe_selected_window): Move here from frame.c. Accept frame
4830 or arbitrary window as argument. Update doc-strings.
4831 (Fminibuffer_window): Move up in code.
4832 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4833 (Fset_frame_selected_window): Move here from frame.c.
4834 Marginal rewrite.
727e958e
MR
4835 (Fselected_window, select_window, Fselect_window): Move up in
4836 code. Minor doc-string fixes.
f230ecc9 4837
4d09bcf6
PE
48382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4839
4840 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4841 Do not assume that spare memory exists; that assumption is valid
4842 only if SYSTEM_MALLOC.
4843 (LARGE_REQUEST): New macro, so that the issue of large requests
4844 is separated from the issue of spare memory.
4845
810928a2
AS
48462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4847
172418ad
AS
4848 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4849 format. (Bug#8806)
4850
43f862f7
AS
4851 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4852
810928a2
AS
4853 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4854 before statements.
4855
a059fe24
JD
48562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4857
4858 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4859
4860 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4861
4862 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4863 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4864
989bf368
JB
48652011-06-05 Juanma Barranquero <lekktu@gmail.com>
4866
4867 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4868
4b80f674
CY
48692011-06-04 Chong Yidong <cyd@stupidchicken.com>
4870
4871 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4872 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4873 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4874 New error handlers.
4b80f674
CY
4875 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4876 Obey Vx_select_enable_clipboard_manager. Catch errors in
4877 x_clipboard_manager_save (Bug#8779).
4878 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4879 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4880
99a33b77 48812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4882
4883 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4884
99a33b77 48852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4886
4887 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4888 in the current matrix if keep_current_p is non-zero.
4889
8264569d
EZ
48902011-06-04 Eli Zaretskii <eliz@gnu.org>
4891
4892 * bidi.c (bidi_level_of_next_char): Fix last change.
4893
57f97249
EZ
48942011-06-03 Eli Zaretskii <eliz@gnu.org>
4895
fec2107c 4896 Support bidi reordering of text covered by display properties.
57f97249 4897
fec2107c
EZ
4898 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4899 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4900 (bidi_cache_search, bidi_cache_iterator_state)
4901 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4902 (bidi_level_of_next_char, bidi_move_to_visually_next):
4903 Support character positions inside a run of characters covered by a
fec2107c
EZ
4904 display string.
4905 (bidi_paragraph_init, bidi_resolve_explicit_1)
4906 (bidi_level_of_next_char): Call bidi_fetch_char and
4907 bidi_fetch_char_advance instead of FETCH_CHAR and
4908 FETCH_CHAR_ADVANCE.
4909 (bidi_init_it): Initialize new members.
4910 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4911 definitions.
4912 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4913 instead of using explicit *_CHAR codes.
d6d100dd
SM
4914 (bidi_resolve_explicit, bidi_resolve_weak):
4915 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4916 bidirectional text is supported only in multibyte buffers.
4917 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4918 it to initialize the frame_window_p member of struct bidi_it.
4919 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4920 (bidi_resolve_explicit, bidi_resolve_weak)
4921 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4922 bidi_it->nchars is non-positive.
4923 (bidi_level_of_next_char): Don't try to lookup the cache for the
4924 next/previous character if nothing is cached there yet, or if we
4925 were just reseat()'ed to a new position.
c40e2fb2 4926
0e14fe90
EZ
4927 * xdisp.c (set_cursor_from_row): Set start and stop points
4928 according to the row's direction when priming the loop that looks
4929 for the glyph on which to display cursor.
4930 (single_display_spec_intangible_p): Function deleted.
4931 (display_prop_intangible_p): Reimplement to call
4932 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4933 Accept 3 additional arguments needed by handle_display_spec.
4934 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4935 values: lists, `(when COND...)' forms, etc.
4936 (single_display_spec_string_p): Support property values that are
4937 lists with the argument STRING its top-level element.
4938 (display_prop_string_p): Fix the condition for processing a
4939 property that is a list to be consistent with handle_display_spec.
fec2107c 4940 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4941 last portion of handle_display_prop.
4942 (compute_display_string_pos): Accept additional argument
4943 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4944 value of a `display' property is a "replacing spec".
4945 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4946 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4947 the display property, but just return a value indicating whether
4948 the display property will replace the characters it covers.
4949 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4950 frame_window_p members of struct bidi_it.
d6d100dd
SM
4951 (compute_display_string_pos, compute_display_string_end):
4952 New functions.
fec2107c
EZ
4953 (push_it): Accept second argument POSITION, where pop_it should
4954 jump to continue iteration.
4955 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4956
fec2107c
EZ
4957 * keyboard.c (adjust_point_for_property): Adjust the call to
4958 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4959
4960 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4961 (bidi_init_it): Update prototypes.
4962 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4963 (compute_display_string_pos, compute_display_string_end):
4964 Declare prototypes.
fec2107c
EZ
4965 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4966 EMACS_INT.
fc6f18ce 4967
40087514 49682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4969
57f53182
PE
4970 Malloc failure behavior now depends on size of allocation.
4971 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4972 * lisp.h: Change signatures accordingly.
4973 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4974 All callers changed. (Bug#8762)
4975
4976 * gnutls.c: Use Emacs's memory allocators.
4977 Without this change, the gnutls library would invoke malloc etc.
4978 directly, which causes problems on non-SYNC_INPUT hosts, and which
4979 runs afoul of improving memory_full behavior. (Bug#8761)
4980 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4981 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4982 xfree instead of the default malloc, realloc, free.
4983 (Fgnutls_boot): No need to check for memory allocation failure,
4984 since xmalloc does that for us.
4985
ac32cd99 4986 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4987 * category.c (hash_get_category_set):
4988 * ccl.c (ccl_driver):
4989 * charset.c (Fdefine_charset_internal):
4990 * charset.h (struct charset.hash_index):
4991 * composite.c (get_composition_id, gstring_lookup_cache)
4992 (composition_gstring_put_cache):
4993 * composite.h (struct composition.hash_index):
4994 * dispextern.h (struct image.hash):
4995 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4996 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4997 (hashfn_equal, hashfn_user_defined, make_hash_table)
4998 (maybe_resize_hash_table, hash_lookup, hash_put)
4999 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5000 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5001 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5002 * image.c (make_image, search_image_cache, lookup_image)
5003 (xpm_put_color_table_h):
5004 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5005 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5006 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5007 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5008 * alloc.c (allocate_vectorlike):
5009 Check for overflow in vector size calculations.
5010 * ccl.c (ccl_driver):
5011 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5012 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5013 need to be updated by these changes.
40087514
PE
5014 * fns.c (make_hash_table, maybe_resize_hash_table):
5015 Check for integer overflow with large hash tables.
0de4bb68
PE
5016 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5017 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5018 (SXHASH_REDUCE): New macro.
5019 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5020 Use it instead of discarding useful hash info with large hash values.
5021 (sxhash_float): New function.
5022 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5023 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5024 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5025 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5026 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5027 Adjust signatures to match updated version of code.
5028 (consing_since_gc): Now EMACS_INT, since a single hash table can
5029 use more than INT_MAX bytes.
5030
698d32e2
DN
50312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5032
5033 Make it possible to build with GCC-4.6+ -O2 -flto.
5034
5035 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5036
fd6fa53f
SM
50372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5038
5039 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5040 Call minibuffer-inactive-mode.
5041
864db017
JB
50422011-05-31 Juanma Barranquero <lekktu@gmail.com>
5043
5044 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5045 Update dependencies.
5046
2ad0baf4
DN
50472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5048
5049 * data.c (init_data): Remove code for UTS, this system is not
5050 supported anymore.
5051
4fcc2638
DN
50522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5053
5054 Don't force ./temacs to start in terminal mode.
5055
5056 * frame.c (make_initial_frame): Initialize faces in all cases, not
5057 only when CANNOT_DUMP is defined.
5058 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5059
c56e0fd5
DN
50602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5061
5062 * dispnew.c (add_window_display_history): Use const for the string
5063 pointer. Remove declaration, not needed.
5064
333d54da 50652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5066
55d4c1b2 5067 Use 'inline', not 'INLINE'.
333d54da 5068 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5069 * alloc.c, fontset.c (INLINE): Remove.
5070 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5071 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5072 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5073 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5074 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5075
738db178
DN
50762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5077
5078 Make it possible to run ./temacs.
5079
5080 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5081 syms_of_callproc does the same thing. Remove test for
5082 "initialized", do it in the caller.
5083 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5084
620c53a6
SM
50852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5086
5087 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5088 (read_minibuf): Use get_minibuffer.
5089 (syms_of_minibuf): Use DEFSYM.
5090 (Qmetadata): New var.
5091 * data.c (Qbuffer): Don't make it static.
5092 (syms_of_data): Use DEFSYM.
5093
e003a292
PE
50942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5095
5096 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5097 (CCL_CODE_MIN): New macro.
5098
ed008a6d
PE
50992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5100
3687c2ef
PE
5101 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5102
ed008a6d
PE
5103 * eval.c (Qdebug): Now static.
5104 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5105 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5106 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5107
d66c4c7c
CY
51082011-05-29 Chong Yidong <cyd@stupidchicken.com>
5109
5110 * image.c: Various fixes to ImageMagick code comments.
5111 (Fimagemagick_types): Doc fix.
5112
5fbc2025
PE
51132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5114
0196f88a
PE
5115 Minor fixes prompted by GCC 4.6.0 warnings.
5116
5117 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5118
5fbc2025
PE
5119 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5120 (x_clipboard_manager_save_all): Move extern decl to ...
5121 * xterm.h: ... here, so that it can be checked for consistency.
5122
1dd3c2d9
CY
51232011-05-29 Chong Yidong <cyd@stupidchicken.com>
5124
5125 * xselect.c (x_clipboard_manager_save_frame)
5126 (x_clipboard_manager_save_all): New functions.
5127 (Fx_clipboard_manager_save): Lisp function deleted.
5128
5129 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5130 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5131
5132 * xterm.h: Update prototype.
5133
5ba6571d
WX
51342011-05-28 William Xu <william.xwl@gmail.com>
5135
5136 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5137 exiting (Bug#8239).
5138
3eaff834
JM
51392011-05-28 Jim Meyering <meyering@redhat.com>
5140
e1900994 5141 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5142 * fns.c (to_uchar): Define.
5143 (crypto_hash_function): Use it to convert some newly-signed
5144 variables to unsigned, to avoid sign-extension bugs. For example,
5145 without this change, (md5 "truc") would evaluate to
5146 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5147 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5148 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5149
0f6990a7
PE
51502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5151
5152 Integer overflow fixes.
c8a9ca5a 5153
08686060
PE
5154 * dbusbind.c: Serial number integer overflow fixes.
5155 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5156 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5157 to hold a serial number that is too large for a fixnum.
5158 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5159 Check for serial numbers out of range. Decode any serial number
59568bf0 5160 that was so large that it became a float. (Bug#8722)
08686060 5161
2d1fc3c7
PE
5162 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5163 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5164 Use XFASTINT rather than XUINT when numbers are nonnegative.
5165 (xd_append_arg, Fdbus_method_return_internal):
5166 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5167 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5168 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5169 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5170 (Bug#8722)
2d1fc3c7 5171
c8a9ca5a
PE
5172 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5173
519e1d69
PE
5174 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5175
30569699
PE
5176 ccl: add integer overflow checks
5177 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5178 (IN_INT_RANGE): New macros.
5179 (ccl_driver): Use them to check for integer overflow when
5180 decoding a CCL program. Many of the new checks are whether XINT (x)
5181 fits in int; it doesn't always, on 64-bit hosts. The new version
5182 doesn't catch all possible integer overflows, but it's an
847044ea 5183 improvement. (Bug#8719)
30569699 5184
c11285dc
PE
5185 * alloc.c (make_event_array): Use XINT, not XUINT.
5186 There's no need for unsigned here.
5187
fdccd48e
PE
5188 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5189 This follows up to the 2011-05-06 change that substituted uintptr_t
5190 for EMACS_INT. This case wasn't caught back then.
5191
37910ab2
PE
5192 Rework Fformat to avoid integer overflow issues.
5193 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5194 now (part of C89). Include <verify.h>.
5195 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5196 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5197 (Fformat): Avoid the prepass trying to compute sizes; it was only
5198 approximate and thus did not catch overflow reliably. Instead, walk
5199 through the format just once, formatting and computing sizes as we go,
5200 checking for integer overflow at every step, and allocating a larger
5201 buffer as needed. Keep track separately whether the format is
5202 multibyte. Keep only the most-recently calculated precision, rather
5203 than them all. Record whether each argument has been converted to
5204 string. Use EMACS_INT, not int, for byte and char and arg counts.
5205 Support field widths and precisions larger than INT_MAX. Avoid
5206 sprintf's undefined behavior with conversion specifications such as %#d
5207 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5208 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5209 formatting out-of-range floating point numbers with int
9173deec 5210 formats. (Bug#8668)
37910ab2 5211
2e6578fb
PE
5212 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5213
0ae6bdee
PE
5214 * data.c: Avoid integer truncation in expressions involving floats.
5215 * data.c: Include <intprops.h>.
5216 (arith_driver): When there's an integer overflow in an expression
5217 involving floating point, convert the integers to floating point
5218 so that the resulting value does not suffer from catastrophic
5219 integer truncation. For example, on a 64-bit host (* 4
5220 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5221 Do not rely on undefined behavior after integer overflow.
5222
de883a70
PE
5223 merge count_size_as_multibyte, parse_str_to_multibyte
5224 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5225 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5226 Check for integer overflow.
5227 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5228 since it's now a duplicate of the other. This is more of
5229 a character than a buffer op, so better that it's in character.c.
5230 * fns.c, print.c: Adjust to above changes.
5231
2ff916cb
PE
52322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5233
5234 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5235
f1b54466
PE
52362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5237
fb1ac845
PE
5238 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5239 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5240 (x_clipboard_manager_save): Now static.
5241 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5242
f1b54466
PE
5243 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5244 (crypto_hash_function): Now static.
5245 Fix pointer signedness problems. Avoid unnecessary initializations.
5246
a9f737ee
CY
52472011-05-27 Chong Yidong <cyd@stupidchicken.com>
5248
5249 * termhooks.h (Vselection_alist): Make it terminal-local.
5250
5251 * terminal.c (create_terminal): Initialize it.
5252
5253 * xselect.c: Support for clipboard managers.
5254 (Vselection_alist): Move to termhooks.h as terminal-local var.
5255 (LOCAL_SELECTION): New macro.
5256 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5257 (symbol_to_x_atom): Remove gratuitous arg.
5258 (x_handle_selection_request, lisp_data_to_selection_data)
5259 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5260 (x_own_selection, x_get_local_selection, x_convert_selection):
5261 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5262 (some_frame_on_display): Delete unused function.
5263 (Fx_own_selection_internal, Fx_get_selection_internal)
5264 (Fx_disown_selection_internal, Fx_selection_owner_p)
5265 (Fx_selection_exists_p): New optional frame arg.
5266 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5267 (x_handle_selection_clear): Don't treat other terminals with the
5268 same keyboard specially. Use the terminal-local Vselection_alist.
5269 (x_clear_frame_selections): Use Frun_hook_with_args.
5270
5271 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5272
5273 * xterm.h: Add support for those atoms.
5274
e067f0c1
CY
52752011-05-26 Chong Yidong <cyd@stupidchicken.com>
5276
5277 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5278 (converted_selections, conversion_fail_tag): New global variables.
5279 (x_selection_request_lisp_error): Free the above.
5280 (x_get_local_selection): Remove unnecessary code.
5281 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5282 of converted selections stored in converted_selections.
5283 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5284 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5285 (x_convert_selection): New function.
5286 (x_handle_selection_event): Simplify.
5287 (x_get_foreign_selection): Don't ignore incoming requests while
5288 waiting for an answer; this will fail when we implement
5289 SAVE_TARGETS, and seems unnecessary anyway.
5290 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5291 (Vx_sent_selection_functions): Doc fix.
5292
0f4aebc0
LL
52932011-05-26 Leo Liu <sdl.web@gmail.com>
5294
5295 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5296
e61124cd
YM
52972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5298
5299 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5300
5301 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5302 for fringe update if it has periodic bitmap.
ac389d0c 5303 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5304 and fringe_bitmap_periodic_p.
5305
5306 * fringe.c (get_fringe_bitmap_data): New function.
5307 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5308 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5309 row. Mark glyph row for fringe update if periodicity changed.
5310
5311 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5312 for fringe update unless it has periodic bitmap.
5313
f16d9837
KH
53142011-05-25 Kenichi Handa <handa@m17n.org>
5315
5316 * xdisp.c (get_next_display_element): Set correct it->face_id for
5317 a static composition.
5318
e1b90ef6
LL
53192011-05-24 Leo Liu <sdl.web@gmail.com>
5320
5321 * deps.mk (fns.o):
5322 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5323
5324 * fns.c (crypto_hash_function, Fsha1): New function.
5325 (Fmd5): Use crypto_hash_function.
5326 (syms_of_fns): Add Ssha1.
5327
7400048f
PE
53282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5329
5330 * gnutls.c: Remove unused macros.
5331 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5332 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5333 Remove macros that are defined and never used.
5334 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5335
abb71cf4
CY
53362011-05-22 Chong Yidong <cyd@stupidchicken.com>
5337
5338 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5339 (Fx_get_selection_internal): Minor cleanup.
5340 (Fx_own_selection_internal): Rename arguments for consistency with
5341 select.el.
5342
6307db39
PE
53432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5346
f3d4e0a4
CY
53472011-05-22 Chong Yidong <cyd@stupidchicken.com>
5348
5349 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5350
4d8ade89
YM
53512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5352
5353 * dispnew.c (scrolling_window): Don't exclude the case that the
5354 last enabled row in the desired matrix touches the bottom boundary.
5355
32078c8d
GM
53562011-05-21 Glenn Morris <rgm@gnu.org>
5357
5358 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5359 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5360 and add some more files.
32078c8d 5361
7285dc67
EZ
53622011-05-20 Eli Zaretskii <eliz@gnu.org>
5363
5364 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5365 report_file_error introduced by the change from 2011-05-07.
5366
89d1bd22
PE
53672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5368
5369 * systime.h (Time): Define only if emacs is defined.
5370 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5371 where the include path doesn't have X11/X.h by default. See
5372 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5373
e23640bb 53742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5375
5376 * composite.c (find_automatic_composition): Fix previous change.
5377
b9704ad9
GM
53782011-05-20 Glenn Morris <rgm@gnu.org>
5379
5380 * lisp.mk: New file, split from Makefile.in.
5381 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5382 (shortlisp): Remove.
5383 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5384
4a720484
GM
53852011-05-19 Glenn Morris <rgm@gnu.org>
5386
5387 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5388 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5389 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5390 (lisp): Set the order to that of loadup.el.
5391 (shortlisp): Make it a copy of $lisp.
5392 (SOME_MACHINE_LISP): Remove.
5393 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5394 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5395
a28d4396
KH
53962011-05-18 Kenichi Handa <handa@m17n.org>
5397
5398 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5399 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5400 (find_automatic_composition): Mostly rewrite for efficiency.
5401
a2b1fa8e
JB
54022011-05-18 Juanma Barranquero <lekktu@gmail.com>
5403
5404 * makefile.w32-in: Update dependencies.
5405
8e1f5610
CS
54062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5407
5408 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5409 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5410
7025ee00 54112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5412
cdfa6eab
PE
5413 Fix some integer overflow issues, such as string length overflow.
5414
06d6db33
PE
5415 * insdel.c (count_size_as_multibyte): Check for string overflow.
5416
2b4560a8
PE
5417 * character.c (lisp_string_width): Check for string overflow.
5418 Use EMACS_INT, not int, for string indexes and lengths; in
5419 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5420 the resulting string length overflows an EMACS_INT; instead,
5421 report a string overflow if no precision given. When checking for
5422 precision exhaustion, use a check that cannot possibly have
5423 integer overflow. (Bug#8675)
5424 * character.h (lisp_string_width): Adjust to new signature.
5425
cb93f9be
PE
5426 * alloc.c (string_overflow): New function.
5427 (Fmake_string): Use it. This doesn't change behavior, but saves
5428 a few bytes and will simplify future changes.
5429 * character.c (string_escape_byte8): Likewise.
5430 * lisp.h (string_overflow): New decl.
5431
1a1f3366
PE
5432 Fixups, following up to the user-interface timestamp change.
5433 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5434 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5435 * msdos.c (mouse_get_pos): Likewise.
5436 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5437 * w32gui.h (Time): Define by including "systime.h" rather than by
5438 declaring it ourselves. (Bug#8664)
5439
d4e3e4d3
PE
5440 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5441 * image.c (clear_image_cache): Likewise.
5442
f6a24d19
PE
5443 * term.c (term_mouse_position): Don't assume time_t wraparound.
5444
08dc5ae6
PE
5445 Be more systematic about user-interface timestamps.
5446 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5447 and sometimes 'EMACS_UINT', to represent these timestamps.
5448 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5449 This makes the code easier to follow, and makes it easier to catch
5450 integer overflow bugs such as Bug#8664.
5451 * frame.c (Fmouse_position, Fmouse_pixel_position):
5452 Use Time, not unsigned long, for user-interface timestamps.
5453 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5454 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5455 * keyboard.h (last_event_timestamp): Likewise.
5456 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5457 * menu.h (xmenu_show): Likewise.
5458 * term.c (term_mouse_position): Likewise.
5459 * termhooks.h (struct input_event.timestamp): Likewise.
5460 (struct terminal.mouse_position_hook): Likewise.
5461 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5462 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5463 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5464 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5465 what it was before.
5466 * menu.h, termhooks.h: Include "systime.h", for Time.
5467
8e55734a
PE
5468 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5469 Don't assume that the difference between two unsigned long values
5470 can fit into an integer. At this point, we know button_down_time
5471 <= event->timestamp, so the difference must be nonnegative, so
5472 there's no need to cast the result if double-click-time is
5473 nonnegative, as it should be; check that it's nonnegative, just in
5474 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5475 apart (about 25 days). (Bug#8664)
8e55734a 5476
841f1b75 5477 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5478 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5479
3e26f69c
PE
5480 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5481 that always fit in int. Use a sentinel instead of a counter, to
5482 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5483 * frame.h (struct frame): Use int for menu_bar_items_used
5484 instead of EMACS_INT, since it always fits in int.
3e26f69c 5485
5cc152c0
PE
5486 * menu.c (grow_menu_items): Check for int overflow.
5487
d89eb65e
PE
5488 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5489
5235bd3e
PE
5490 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5491 Before, the code was not consistent. These values cannot exceed
5492 2**31 - 1 so there's no need to make them unsigned.
5493 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5494 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5495 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5496 as modifiers.
5497 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5498
bc827e23
PE
5499 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5500 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5501 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5502 presumably because the widths might not match.
5503
78eb494e
PE
5504 * window.c (size_window): Avoid needless test at loop start.
5505
04f2d78b
CB
55062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5507
5508 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5509
d2fc7e3d 55102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5511
5512 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5513
d2fc7e3d 55142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5515
5516 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5517 `width' to `bar_area_x' and `bar_area_width', respectively.
5518 (x_scroll_run): Take account of fringe background extension.
5519
04f2d78b
CB
5520 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5521 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5522 `bar_area_width', respectively.
5523 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5524 background extension.
5525
79b70037
GM
55262011-05-10 Jim Meyering <meyering@redhat.com>
5527
5528 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5529
2f142cc5
JB
55302011-05-10 Juanma Barranquero <lekktu@gmail.com>
5531
5532 * image.c (Finit_image_library): Return t for built-in image types,
5533 like pbm and xbm. (Bug#8640)
5534
57679c86
AS
55352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5536
5537 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5538
888c9e86
EZ
55392011-05-07 Eli Zaretskii <eliz@gnu.org>
5540
b0512a1d
EZ
5541 * w32console.c (Fset_screen_color): Doc fix.
5542 (Fget_screen_color): New function.
5543 (syms_of_ntterm): Defsubr it.
5544
7285dc67
EZ
5545 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5546 unlink the temporary file if Fcall_process didn't create it in the
5547 first place.
5548 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5549 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5550 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5551 cue to call_process_cleanup not to close that handle.
5552
4d3fcc8e
BK
55532011-05-07 Ben Key <bkey76@gmail.com>
5554
5555 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5556 one of two shell specific rules, either bootstrap-temacs-CMD or
5557 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5558 to the previous implementation of the bootstrap-temacs rule.
5559 The bootstrap-temacs-CMD rule is similar to the previous
5560 implementation of the bootstrap-temacs rule except that it
5561 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5562 variable.
5563
5564 These changes, along with some changes to nt/configure.bat,
5565 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5566 earlier fix to add support for --cflags and --ldflags options
5567 that include quotes so that it works whether make uses cmd or
5568 sh as the shell.
5569
b4289b64
MA
55702011-05-06 Michael Albinus <michael.albinus@gmx.de>
5571
5572 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5573 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5574 is a constant.
5575 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5576 a string. Handle both cases.
5577 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5578 (Fdbus_register_method): Use Qinvalid_function.
5579
af4c0e28
JB
55802011-05-06 Juanma Barranquero <lekktu@gmail.com>
5581
5582 * makefile.w32-in: Update dependencies.
5583 (LISP_H): Add inttypes.h and stdin.h.
5584 (PROCESS_H): Add unistd.h.
5585
c51453d9
EZ
55862011-05-06 Eli Zaretskii <eliz@gnu.org>
5587
5588 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5589 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5590
8ff0ac3c 55912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5592
4c4b566b
PE
5593 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5594
aab2b9b5
PE
5595 * term.c (vfatal): Remove stray call to va_end.
5596 It's not needed and the C Standard doesn't allow it here anyway.
5597
c378da0b
PE
5598 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5599 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5600
288b08c7
PE
5601 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5602 bytes.
5603
e3601888
PE
5604 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5605
db6c0e74
PE
5606 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5607
dd5963ea
PE
5608 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5609
88c9450f
PE
5610 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5611
2f9442b8
PE
5612 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5613
c032b5f8
PE
5614 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5615 * charset.c (Fdefine_charset_internal): Don't initialize
5616 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5617 32-bit int (Bug#8600).
a108c10b
PE
5618
5619 * lread.c (read_integer): Be more consistent with string-to-number.
5620 Use string_to_number to do the actual conversion; this avoids
5621 rounding errors and fixes some other screwups. Without this fix,
5622 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5623 (digit_to_number): Move earlier, for benefit of read_integer.
5624 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5625 not a digit in any supported base. (Bug#8602)
a108c10b 5626
ad5f9eea
PE
5627 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5628
aec1708a
PE
5629 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5630 to match comment at start of function. This also removes a
5631 GCC warning about overflow in a 32+64-bit port.
5632
47be4ab5
PE
5633 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5634
371cac43
PE
5635 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5636 Reported by Stefan Monnier in
5637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5638 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5639 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5640
d01a7826
PE
5641 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5642 (EMACS_UINTPTR): Likewise, with uintptr_t.
5643
7fd47d5c
PE
5644 * lisp.h: Prefer 64-bit EMACS_INT if available.
5645 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5646 on 32-bit hosts that have 64-bit int, so that they can access
5647 large files.
122b0c86
PE
5648 However, temporarily disable this change unless the temporary
5649 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5650
8727937b
PE
5651 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5652
8ac068ac
PE
5653 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5654 This removes an assumption that EMACS_INT and long are the same
5655 width as pointers. The assumption is true for Emacs porting targets
5656 now, but we want to make other targets possible.
5657 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5658 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5659 In the rest of the code, change types of integers that hold casted
5660 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5661 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5662 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5663 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5664 No need to cast type when ORing.
5665 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5666 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5667 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5668 assume EMACS_INT is the same width as char *.
5669 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5670 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5671 Remove no-longer-needed casts.
5672 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5673 (xg_tool_bar_help_callback, xg_make_tool_item):
5674 Use EMACS_INTPTR to hold an integer
5675 that will be cast to void *; this can avoid a GCC warning
5676 if EMACS_INT is not the same width as void *.
5677 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5678 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5679 (current_message_1, set_message_1):
5680 Use a local to convert to proper width without a cast.
5681 * xmenu.c (dialog_selection_callback): Likewise.
5682
ede49d71
PE
5683 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5684 Also, don't assume VALBITS / RAND_BITS is less than 5,
5685 and don't rely on undefined behavior when shifting a 1 left into
5686 the sign bit.
5687 * lisp.h (get_random): Change signature to match.
5688
2f30ecd0
PE
5689 * lread.c (hash_string): Use size_t, not int, for hash computation.
5690 Normally we prefer signed values; but hashing is special, because
5691 it's better to use unsigned division on hash table sizes so that
5692 the remainder is nonnegative. Also, size_t is the natural width
5693 for hashing into memory. The previous code used 'int', which doesn't
5694 retain enough info to hash well into very large tables.
5695 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5696
2a866e7b
PE
5697 * dbusbind.c: Don't possibly lose pointer info when converting.
5698 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5699 Use XPNTR rather than XHASH, so that the high-order bits of
5700 the pointer aren't lost when converting through void *.
5701
51639eac
PE
5702 * eval.c (Fautoload): Don't double-shift a pointer.
5703
92394119
PE
5704 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5705
dbdb9a7c
JB
57062011-05-06 Juanma Barranquero <lekktu@gmail.com>
5707
5708 * gnutls.c (DEF_GNUTLS_FN):
5709 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5710
db7a0b4f
AS
57112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5712
5713 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5714 marker. (Bug#8610)
5715
f7ff1b0f 57162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5717
5718 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5719 New version that can reserve upto 2GB of heap space.
5720
f7ff1b0f 57212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5722
5723 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5724
639c109b
TZ
57252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5726
5727 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5728 `gnutls_certificate_set_x509_key_file'.
5729
d2127135
JB
57302011-05-05 Juanma Barranquero <lekktu@gmail.com>
5731
5732 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5733 Update dependencies.
5734
e968f4f3
JB
57352011-05-04 Juanma Barranquero <lekktu@gmail.com>
5736
5737 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5738 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5739 Remove unused parameter `fildes'.
5740 * process.c (read_process_output, send_process): Don't pass it.
5741
84d358f0
JB
57422011-05-04 Juanma Barranquero <lekktu@gmail.com>
5743
5744 Fix previous change: the library cache is defined in w32.c.
5745 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5746 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5747
0898ca10
JB
57482011-05-04 Juanma Barranquero <lekktu@gmail.com>
5749
5750 Implement dynamic loading of GnuTLS on Windows.
5751
5752 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5753 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5754 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5755 Declare.
5756
5757 * gnutls.c (Qgnutls_dll): Define.
5758 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5759 (gnutls_*): Declare function pointers.
5760 (init_gnutls_functions): New function to initialize function pointers.
5761 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5762 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5763 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5764 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5765 (emacs_gnutls_write, emacs_gnutls_read)
5766 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5767 (Fgnutls_available_p): New function.
5768 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5769 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5770 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5771
5772 * image.c: Include w32.h.
5773 (Vimage_type_cache): Delete.
5774 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5775 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5776 (w32_delayed_load): Move to w32.c.
5777
5778 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5779
5780 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5781 (w32_delayed_load): Move from image.c. When loading a library, record
5782 its filename in the :loaded-from property of the library id.
5783 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5784 Initialize and staticpro them.
5785 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5786
5787 * process.c: Include lisp.h before w32.h, not after.
5788 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5789 instead of gnutls_record_check_pending.
5790
5791 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5792
ff4de4aa
TZ
57932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5794
5795 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5796 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5797 as passed in.
5798
abe95abb
JD
57992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5800
5801 * xterm.c (x_set_frame_alpha): Do not set property on anything
5802 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5803
e16e55d4
JB
58042011-05-02 Juanma Barranquero <lekktu@gmail.com>
5805
5806 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5807
bafcf6a5
JB
58082011-05-02 Juanma Barranquero <lekktu@gmail.com>
5809
5810 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5811 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5812 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5813 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5814 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5815 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5816 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5817 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5818 (Qgnutls_bootprop_callbacks_verify): Make static.
5819
e7a6747f
AS
58202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5821
19ed11ba
AS
5822 * callproc.c: Indentation fixup.
5823
e7a6747f 5824 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5825 (wait_for_termination, interruptible_wait_for_termination):
5826 Move after wait_for_termination_1.
e7a6747f 5827
1ef14cb4
LMI
58282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5829
5830 * sysdep.c (interruptible_wait_for_termination): New function
5831 which is like wait_for_termination, but allows keyboard
5832 interruptions.
5833
5834 * callproc.c (Fcall_process): Add (:file "file") as an option for
5835 the STDOUT buffer.
5836 (Fcall_process_region): Ditto.
5837
330d880c
EZ
58382011-04-30 Eli Zaretskii <eliz@gnu.org>
5839
8db90b73
EZ
5840 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5841 rather than `XVECTOR (FOO)->size'.
5842
330d880c
EZ
5843 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5844 inttypes.h, as a gnulib replacement is used if it not available in
5845 system headers.
5846
15cbd324
EZ
58472011-04-21 Eli Zaretskii <eliz@gnu.org>
5848
5849 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5850 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5851 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5852
5853 * coding.c (coding_alloc_by_realloc): Error out if destination
5854 will grow beyond MOST_POSITIVE_FIXNUM.
5855 (decode_coding_emacs_mule): Abort if there isn't enough place in
5856 charbuf for the composition carryover bytes. Reserve an extra
5857 space for up to 2 characters produced in a loop.
5858 (decode_coding_iso_2022): Abort if there isn't enough place in
5859 charbuf for the composition carryover bytes.
5860
58612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5862
ae940cca
EZ
5863 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5864 aborting when %lld or %lll format is passed.
5865 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5866 %llo or %llx format is passed. (Bug#8545)
5867
03ab8921
EZ
5868 * window.c (window_scroll_line_based): Use a marker instead of
5869 simple variables to record original value of point. (Bug#7952)
5870
afda1437
EZ
5871 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5872 produced by %s or %c overflows available buffer space. (Bug#8545)
5873
f76dee0c
PE
58742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5875
5876 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5877 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5878
fdc5744d
JB
58792011-04-28 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5882
638f053a
JB
58832011-04-28 Juanma Barranquero <lekktu@gmail.com>
5884
5885 * keyboard.c (Qdelayed_warnings_hook): Define.
5886 (command_loop_1): Run `delayed-warnings-hook'
5887 if Vdelayed_warnings_list is non-nil.
5888 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5889 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5890
d178f871
EZ
58912011-04-28 Eli Zaretskii <eliz@gnu.org>
5892
5893 * doprnt.c (doprnt): Don't return value smaller than the buffer
5894 size if the message was truncated. (Bug#8545).
5895
b124fd93
JB
58962011-04-28 Juanma Barranquero <lekktu@gmail.com>
5897
5898 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5899 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5900
e810457d
PE
59012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5902
5903 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5904
ea51cceb
JB
59052011-04-27 Juanma Barranquero <lekktu@gmail.com>
5906
5907 * makefile.w32-in: Update dependencies.
5908
94dcfacf
EZ
59092011-04-27 Eli Zaretskii <eliz@gnu.org>
5910
5911 Improve `doprnt' and its usage. (Bug#8545)
5912 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5913 `format_end'. Remove support for %l as a conversion specifier.
5914 Don't use xrealloc. Improve diagnostics when the %l size modifier
5915 is used. Update the commentary.
5916
5917 * eval.c (verror): Simplify calculation of size_t.
5918
5919 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5920 messages.
5921
f61f41d7
PE
59222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5923
5924 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5925 change.
5926
96fb4434
PE
59272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5928
5929 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5930 This makes this file independent of the recent pseudovector change.
5931
671875da 59322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5933
69e9b5a3
PE
5934 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5935
b5f869a7 5936 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5937 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5938 Remove unused local.
c8926152 5939 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5940
841a1577 5941 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5942 GCC 4.6.0 optimizes based on type-based alias analysis.
5943 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5944 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5945 != &v->size, and therefore "v->size = 1; b->size = 2; return
5946 v->size;" must therefore return 1. This assumption is incorrect
5947 for Emacs, since it type-puns struct Lisp_Vector * with many other
5948 types. To fix this problem, this patch adds a new type struct
f904488f 5949 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5950 and pseudovectors, and helps optimizing compilers not get fooled
5951 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5952 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5953 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5954 the size member.
eab3844f
PE
5955 (XSETPVECTYPE): Rewrite in terms of new macro.
5956 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5957 This is a bit clearer, and further avoids the possibility of
5958 undesirable aliasing.
5959 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5960 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5961 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5962 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5963 (ASIZE): Now uses header.size rather than size.
5964 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5965 to avoid the hassle of writing XVECTOR (foo)->header.size.
5966 (struct vectorlike_header): New type.
eab3844f
PE
5967 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5968 object, to help avoid aliasing.
5969 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5970 (SUBRP): Likewise, since Lisp_Subr is a special case.
5971 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5972 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5973 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5974 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5975 changed to be "header.size" and "header.next".
5976 * buffer.h (struct buffer): Likewise.
5977 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5978 * frame.h (struct frame): Likewise.
5979 * process.h (struct Lisp_Process): Likewise.
5980 * termhooks.h (struct terminal): Likewise.
5981 * window.c (struct save_window_data, struct saved_window): Likewise.
5982 * window.h (struct window): Likewise.
5983 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5984 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5985 * buffer.c (init_buffer_once): Likewise.
5986 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5987 special case.
5988 * process.c (Fformat_network_address): Use local var for size,
5989 for brevity.
5990
0df1eac5
PE
5991 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5992
847ab9d1 5993 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5994 * data.c (atof): Remove decl; no longer used or needed.
5995 (digit_to_number): Move to lread.c.
5996 (Fstring_to_number): Use new string_to_number function, to be
5997 consistent with how the Lisp reader treats infinities and NaNs.
5998 Do not assume that floating-point numbers represent EMACS_INT
5999 without losing information; this is not true on most 64-bit hosts.
6000 Avoid double-rounding errors, by insisting on integers when
6001 parsing non-base-10 numbers, as the documentation specifies.
6002 * lisp.h (string_to_number): New decl, replacing ...
6003 (isfloat_string): Remove.
bc0a5c13 6004 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6005 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6006 appears to have been a coding error. Similarly, do not accept
6007 strings like +-1e0 as floating point numbers. Do not report
6008 overflow for integer overflows unless the base is not 10 which
6009 means we have no simple and reliable way to continue.
6010 Break out the floating-point parsing into a new
6011 function string_to_number, so that Fstring_to_number parses
6012 floating point numbers consistently with the Lisp reader.
04f2d78b 6013 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6014 (E_CHAR, EXP_INT): Remove, replacing with ...
6015 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6016 (string_to_number): New function, replacing isfloat_string.
6017 This function checks for valid syntax and produces the resulting
6018 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6019 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6020 so that overflow for non-base-10 numbers is reported only when
6021 there's no portable and simple way to convert to floating point.
452f4150 6022
67769ffc
PE
6023 * textprop.c (set_text_properties_1): Rewrite for clarity,
6024 and to avoid GCC warning about integer overflow.
6025
c20db43f
PE
6026 * intervals.h (struct interval): Use EMACS_INT for members
6027 where EMACS_UINT might cause problems. See
6028 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6029 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6030 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6031 All uses changed.
37aa2f85
PE
6032 (offset_intervals): Tell GCC not to worry about length overflow
6033 when negating a negative length.
c20db43f 6034
2538aa2f
PE
6035 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6036 (overrun_check_free): Likewise.
6037
f2d3008d
PE
6038 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6039 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6040 word size.
6041
ec8df744
PE
6042 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6043 (gnutls_make_error): Rename local to avoid shadowing.
6044 (gnutls_emacs_global_deinit): ifdef out; not used.
6045 (Fgnutls_boot): Use const for pointer to readonly storage.
6046 Comment out unused local. Fix pointer signedness problems.
6047
640ee02d
PE
6048 * lread.c (openp): Don't stuff size_t into an 'int'.
6049 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6050 about possible signed overflow.
6051
6048fb2a
PE
6052 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6053 (GDK_KEY_g): Don't define if already defined.
6054 (xg_prepare_tooltip): Avoid pointer signedness problem.
6055 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6056
fa3c87e1
PE
6057 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6058 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6059
2172544b
PE
6060 * xfns.c (Fx_window_property): Simplify a bit,
6061 to make a bit faster and to avoid GCC 4.6.0 warning.
6062 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6063
9b821a21
PE
6064 * fns.c (internal_equal): Don't assume size_t fits in int.
6065
3c616cfa
PE
6066 * alloc.c (compact_small_strings): Tighten assertion a little.
6067
c2982e87
PE
6068 Replace pEd with more-general pI, and fix some printf arg casts.
6069 * lisp.h (pI): New macro, generalizing old pEd macro to other
6070 conversion specifiers. For example, use "...%"pI"d..." rather
6071 than "...%"pEd"...".
6072 (pEd): Remove. All uses replaced with similar uses of pI.
6073 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6074 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6075 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6076 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6077 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6078 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6079 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6080 64-bit hosts.
6081 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6082 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6083 * print.c (safe_debug_print, print_object): Likewise.
6084 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6085 to int.
6f04d126
PE
6086 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6087 avoiding the 0 flag, which is not portable.
c2982e87
PE
6088 * process.c (Fmake_network_process): Use pI to avoid cast.
6089 * region-cache.c (pp_cache): Likewise.
6090 * xdisp.c (decode_mode_spec): Likewise.
6091 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6092 behavior on 64-bit hosts with printf arg.
6f04d126 6093 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6094 (x_stop_queuing_selection_requests): Likewise.
6095 (x_get_window_property): Don't truncate byte count to an 'int'
6096 when tracing.
0b432f21 6097
5e073ec7
PE
6098 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6099 here, since it parses constructs like leading '-' and spaces,
6100 which are not wanted; and it overflows with large numbers.
6101 Instead, simply match F[0-9]+, which is what is wanted anyway.
6102
36372bf9
PE
6103 * alloc.c: Remove unportable assumptions about struct layout.
6104 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6105 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6106 (allocate_vectorlike, make_pure_vector): Use the new macros,
6107 plus offsetof, to remove unportable assumptions about struct layout.
6108 These assumptions hold on all porting targets that I know of, but
6109 they are not guaranteed, they're easy to remove, and removing them
6110 makes further changes easier.
6111
0b432f21
PE
6112 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6113 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6114 (string_overrun_cookie): Now const. Use initializers that
6115 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6116 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6117 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6118 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6119 multiple of sizeof (EMACS_INT); it need not be, if
6120 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6121 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6122
895009e1
JB
61232011-04-26 Juanma Barranquero <lekktu@gmail.com>
6124
6125 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6126
6a7a1b0b
TZ
61272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6128
6129 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6130 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6131 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6132
841a1577 61332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6134
6135 * lisp.h (Qdebug): List symbol.
895009e1 6136 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6137 * keyboard.c (debug-on-event): New variable.
6138 (handle_user_signal): Break into debugger when debug-on-event
6139 matches the current signal symbol.
6140
f2d3ba6f
DN
61412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6142
6143 * alloc.c (check_sblock, check_string_bytes)
6144 (check_string_free_list): Convert to standard C.
6145
42ce4c63
TZ
61462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6147
6148 * w32.c (emacs_gnutls_push): Fix typo.
6149
825cd63c
EZ
61502011-04-25 Eli Zaretskii <eliz@gnu.org>
6151
fb11d64d
EZ
6152 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6153 "cast to pointer from integer of different size".
6154
825cd63c
EZ
6155 Improve doprnt and its use in verror. (Bug#8545)
6156 * doprnt.c (doprnt): Document the set of format control sequences
6157 supported by the function. Use SAFE_ALLOCA instead of always
6158 using `alloca'.
6159
6160 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6161 is one byte too soon. Don't use xrealloc; instead xfree and
6162 xmalloc anew.
6163
e061a11b
TZ
61642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6165
6166 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6167 callbacks stage.
6168
6169 * gnutls.c: Renamed global_initialized to
6170 gnutls_global_initialized. Added internals for the
6171 :verify-hostname-error, :verify-error, and :verify-flags
6172 parameters of `gnutls-boot' and documented those parameters in the
6173 docstring. Start callback support.
9173deec
JB
6174 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6175 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6176 on error. Return error code.
e061a11b
TZ
6177 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6178 (emacs_gnutls_read): Likewise.
6179 (Fgnutls_boot): Return handshake error code.
6180 (emacs_gnutls_handle_error): New function.
6181 (wsaerror_to_errno): Likewise.
6182
6183 * w32.h (emacs_gnutls_pull): Add prototype.
6184 (emacs_gnutls_push): Likewise.
6185
6186 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6187 (emacs_gnutls_push): Likewise.
6188
61892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6190
6191 * process.c (wait_reading_process_output): Check if GnuTLS
6192 buffered some data internally if no FDs are set for TLS
6193 connections.
6194
6195 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6196 (LIBS): Link to USER_LIBS.
6197 ($(BLD)/gnutls.$(0)): New target.
6198
fa6996bc
EZ
61992011-04-24 Eli Zaretskii <eliz@gnu.org>
6200
eb35682e
EZ
6201 * xdisp.c (handle_single_display_spec): Rename the
6202 display_replaced_before_p argument into display_replaced_p, to
6203 make it consistent with the commentary. Fix typos in the
6204 commentary.
6205
e2ad650c
EZ
6206 * textprop.c (syms_of_textprop): Remove dead code.
6207 (copy_text_properties): Delete obsolete commentary about an
6208 interface that was deleted long ago. Fix typos in the description
6209 of arguments.
6210
1b2de274
EZ
6211 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6212 to changes in oldXMenu/XMenu.h from 2011-04-16.
6213 <menu_help_message, prev_menu_help_message>: Constify.
6214 (IT_menu_make_room): menu->help_text is now `const char **';
6215 adjust.
6216
6217 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6218 to changes in oldXMenu/XMenu.h from 2011-04-16.
6219 (struct XMenu): Declare `help_text' `const char **'.
6220
6221 * xfaces.c <Qunspecified>: Make extern again.
6222
6223 * syntax.c: Include sys/types.h before including regex.h, as
6224 required by Posix.
6225
762b15be
EZ
6226 * doc.c (get_doc_string): Improve the format passed to `error'.
6227
6228 * doprnt.c (doprnt): Improve commentary.
6229
6230 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6231
6232 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6233 them with etags.
6234
f1052e5d
EZ
6235 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6236 changes in globals.h immediately force recompilation.
762b15be
EZ
6237 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6238 $(CURDIR)/s/ms-w32.h.
6239 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6240
fa6996bc
EZ
6241 * character.c (Fchar_direction): Function deleted.
6242 (syms_of_character): Don't defsubr it.
6243 <char-direction-table>: Deleted.
6244
e6c3da20
EZ
62452011-04-23 Eli Zaretskii <eliz@gnu.org>
6246
6247 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6248 * doprnt.c: Include limits.h.
6249 (SIZE_MAX): New macro.
04f2d78b
CB
6250 (doprnt): Return a size_t value. 2nd arg is now size_t.
6251 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6252 Improve overflow protection. Support `l' modifier for integer
6253 conversions. Support %l conversion. Don't assume an EMACS_INT
6254 argument for integer conversions and for %c.
6255
6256 * lisp.h (doprnt): Restore prototype.
6257
6258 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6259 $(SRC)/character.h.
6260
6261 * Makefile.in (base_obj): Add back doprnt.o.
6262
6263 * deps.mk (doprnt.o): Add back prerequisites.
6264 (callint.o): Depend on character.h.
6265
6266 * eval.c (internal_lisp_condition_case): Include the handler
6267 representation in the error message.
6268 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6269 when breaking from the loop.
6270
6271 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6272
6273 * callint.c (Fcall_interactively): When displaying error message
6274 about invalid control letter, pass the character's codepoint, not
6275 a pointer to its multibyte form. Improve display of the character
6276 in octal and display also its hex code.
6277
6278 * character.c (char_string): Use %x to display the (unsigned)
6279 codepoint of an invalid character, to avoid displaying a bogus
6280 negative value.
6281
6282 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6283 `error', not SYMBOL_NAME itself.
6284
6285 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6286 character arguments to `error'.
6287
6288 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6289 to `error' in error message about FINAL_CHAR argument. Make sure
6290 FINAL_CHAR is a character, and use %c when it is passed as
6291 argument to `error'.
6292
4ffd0d6b 62932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6294
6295 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6296
6297 * w32.c: Include <time.h>.
6298 (sys_localtime): New function.
6299
4ffd0d6b 63002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6301
6302 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6303
4ffd0d6b 6304 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6305
4ffd0d6b 63062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6307
4ffd0d6b
GM
6308 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6309 zombies (Bug#8467).
aac0c6e3 6310
04c56954
EZ
63112011-04-19 Eli Zaretskii <eliz@gnu.org>
6312
6313 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6314 gl_state.e_property when gl_state.object is Qt.
6315
6316 * insdel.c (make_gap_larger): Remove limitation of buffer size
6317 to <= INT_MAX.
6318
16a43933
CY
63192011-04-18 Chong Yidong <cyd@stupidchicken.com>
6320
6321 * xdisp.c (lookup_glyphless_char_display)
6322 (produce_glyphless_glyph): Handle cons cell entry in
6323 glyphless-char-display.
6324 (Vglyphless_char_display): Document it.
6325
6326 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6327 glyphless-char-display.
6328
4581706e
CY
63292011-04-17 Chong Yidong <cyd@stupidchicken.com>
6330
6331 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6332
6333 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6334
6335 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6336 definition for no-X builds.
6337
4887c6e2 63382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6339
fd35b6f9
PE
6340 Static checks with GCC 4.6.0 and non-default toolkits.
6341
5c1ccb01
PE
6342 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6343
006c5daa
PE
6344 * process.c (keyboard_bit_set): Define only if SIGIO.
6345 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6346 (send_process): Repair possible setjmp clobbering.
6347
efc736d3
PE
6348 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6349
4e2fe2e6
PE
6350 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6351
f97334a2
PE
6352 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6353
4e75f29d
PE
6354 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6355 Define only if needed.
6356
90efadd1
PE
6357 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6358 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6359 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6360
3c647824
PE
6361 * dispextern.h (struct redisplay_interface): Rename param
6362 to avoid shadowing.
e264f262 6363 * termhooks.h (struct terminal): Likewise.
761383f4 6364 * xterm.c (xembed_send_message): Likewise.
3c647824 6365
b58c5c4a
PE
6366 * insdel.c (make_gap_smaller): Define only if
6367 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6368
cad59032
PE
6369 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6370 it.
6371
c339dc2e
PE
6372 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6373 so that we aren't warned about unused symbols.
6374
91a3e27b
PE
6375 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6376
399c71d3 6377 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6378
8ffc96f5
PE
6379 * xfns.c (x_real_positions): Mark locals as initialized.
6380
eef9bc79
PE
6381 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6382
098db9dd
PE
6383 * xterm.c: Fix problems found by static analysis with other toolkits.
6384 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6385 (x_dispatch_event): Declare static if USE_GTK, and
6386 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6387 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6388 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6389 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6390 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6391
eb18f6cc
PE
6392 * xmenu.c (menu_help_callback): Pointer type fixes.
6393 Use const pointers when pointing at readonly data. Avoid pointer
6394 signedness clashes.
6395 (FALSE): Remove unused macro.
6396 (update_frame_menubar): Remove unused decl.
6397
1fe72bf8
PE
6398 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6399
60d9e1db
PE
6400 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6401 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6402 (single_menu_item): Rename local to avoid shadowing.
6403
39261c26
PE
6404 * keyboard.c (make_lispy_event): Remove unused local var.
6405
018c5e19
PE
6406 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6407 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6408
63d2b86e
PE
6409 * bitmaps: Change bitmaps from unsigned char back to the X11
6410 compatible char. Avoid the old compiler warnings about
6411 out-of-range initializers by using, for example, '\xab' rather
6412 than 0xab.
6413
aefd87e1
PE
6414 * xgselect.c (xgselect_initialize): Check vs interface
6415 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6416
bf501fb9
PE
6417 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6418
e9829fdf
PE
6419 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6420 to read-only memory.
6421
1086c095
PE
6422 * fns.c (vector): Remove; this old hack is no longer needed.
6423
2baccd04 6424 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6425 Remove unused var.
dde42981 6426 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6427
72391843 6428 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6429
436c16df 6430 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6431 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6432 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6433
92bb796d 6434 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6435 (x_term_init): Remove local to avoid shadowing.
92bb796d 6436
764430a3 6437 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6438
6439 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6440 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6441
d1dfb56c
EZ
64422011-04-16 Eli Zaretskii <eliz@gnu.org>
6443
c4354cb4
EZ
6444 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6445
d1dfb56c
EZ
6446 Fix regex.c, syntax.c and friends for buffers > 2GB.
6447 * syntax.h (struct gl_state_s): Declare character position members
6448 EMACS_INT.
6449
6450 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6451
04f2d78b
CB
6452 * textprop.c (verify_interval_modification, interval_of):
6453 Declare arguments EMACS_INT.
d1dfb56c
EZ
6454
6455 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6456 EMACS_INT.
6457
6458 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6459
6460 * indent.c (Fvertical_motion): Local variable it_start is now
6461 EMACS_INT.
6462
6463 * regex.c (re_match, re_match_2, re_match_2_internal)
6464 (bcmp_translate, regcomp, regexec, print_double_string)
6465 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6466 (re_compile_pattern, re_exec): Declare arguments and local
6467 variables `size_t' and `ssize_t' and return values `regoff_t', as
6468 appropriate.
6469 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6470 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6471 <compile_stack_type>: `size' and `avail' are now `size_t'.
6472
6473 * regex.h <regoff_t>: Use ssize_t, not int.
6474 (re_search, re_search_2, re_match, re_match_2): Arguments that
6475 specify buffer/string position and length are now ssize_t and
6476 size_t. Return type is regoff_t.
6477
613052cd
BK
64782011-04-16 Ben Key <bkey76@gmail.com>
6479
6480 * nsfont.m: Fixed bugs in ns_get_family and
6481 ns_descriptor_to_entity that were caused by using free to
6482 deallocate memory blocks that were allocated by xmalloc (via
6483 xstrdup). This caused Emacs to crash when compiled with
6484 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6485 --enable-checking=xmallocoverrun). xfree is now used to
6486 deallocate these memory blocks.
6487
4170f62f 64882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6489
71b41406
PE
6490 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6491
9587a89d
PE
6492 emacs_write: Accept and return EMACS_INT for sizes.
6493 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6494 et seq.
6495 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6496 Accept and return EMACS_INT.
6497 (emacs_gnutls_write): Return the number of bytes written on
6498 partial writes.
6499 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6500 (emacs_read, emacs_write): Remove check for negative size, as the
6501 Emacs source code has been audited now.
9587a89d
PE
6502 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6503 (emacs_read, emacs_write): Use it.
273a5f82
PE
6504 * process.c (send_process): Adjust to the new signatures of
6505 emacs_write and emacs_gnutls_write. Do not attempt to store
6506 a byte offset into an 'int'; it might overflow.
9587a89d 6507 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6508
3e047f51
PE
6509 * sound.c: Don't assume sizes fit in 'int'.
6510 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6511 Return EMACS_INT, not int.
3e047f51 6512 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6513 Accept EMACS_INT, not int.
6514 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6515 record read return values.
6516
cc39a9db
BK
65172011-04-15 Ben Key <bkey76@gmail.com>
6518
c9d0ec6d
JB
6519 * keyboard.c (Qundefined): Don't declare static since it is used
6520 in nsfns.m.
6521 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6522 static since they are used in nsfont.m.
cc39a9db 6523
6c60eb9f
SM
65242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6525
6526 * process.c (Qprocessp): Don't declare static.
6527 * lisp.h (Qprocessp): Declare again.
6528
7990b61a
JB
65292011-04-15 Juanma Barranquero <lekktu@gmail.com>
6530
6531 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6532
5d4cb038
PE
65332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6534
8bd7b830 6535 Improve C-level modularity by making more things 'static'.
cd64ea1d 6536
e3b27b31
PE
6537 Don't publish debugger-only interfaces to other modules.
6538 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6539 (verify_bytepos, count_markers): Move decls to the only modules
6540 that need them.
6541 * region-cache.h (pp_cache): Likewise.
6542 * window.h (check_all_windows): Likewise.
6543 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6544
5d4cb038
PE
6545 * sysdep.c (croak): Now static, if
6546 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6547 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6548
6549 * alloc.c (refill_memory_reserve): Now static if
6550 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6551 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6552
e87b6180
PE
6553 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6554 Define only if USE_LUCID.
6555
ac64929e
PE
6556 * xrdb.c (x_customization_string, x_rm_string): Now static.
6557
6f37259d
PE
6558 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6559 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6560
1683e3ab
PE
6561 * xdisp.c (draw_row_with_mouse_face): Now static.
6562 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6563
de9c2632
PE
6564 * window.h (check_all_windows): Mark externally visible.
6565
2b96acb7
PE
6566 * window.c (window_deletion_count): Now static.
6567
6568 * undo.c: Make symbols static if they're not exported.
6569 (last_undo_buffer, last_boundary_position, pending_boundary):
6570 Now static.
6571
50436f33
PE
6572 * textprop.c (interval_insert_behind_hooks): Now static.
6573 (interval_insert_in_front_hooks): Likewise.
6574
64520e5c
PE
6575 * term.c: Make symbols static if they're not exported.
6576 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6577 (max_frame_lines, tty_set_terminal_modes):
6578 (tty_reset_terminal_modes, tty_turn_off_highlight):
6579 (get_tty_terminal): Now static.
6580 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6581 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6582 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6583 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6584 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6585
1fa53021
PE
6586 * sysdep.c: Make symbols static if they're not exported.
6587 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6588 Now static.
6589 (sigprocmask_set, full_mask): Remove; unused.
6590 (wait_debugging): Mark as visible.
6591 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6592 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6593
d4b43b22
PE
6594 * syntax.c (syntax_temp): Define only if !__GNUC__.
6595
b7c513d0
PE
6596 * sound.c (current_sound_device, current_sound): Now static.
6597
989b29ad
PE
6598 * search.c (searchbufs, searchbuf_head): Now static.
6599
13a55a78
PE
6600 * scroll.c (scroll_cost): Remove; unused.
6601 * dispextern.h (scroll_cost): Remove decl.
6602
de68a1fc
PE
6603 * region-cache.h (pp_cache): Mark as externally visible.
6604
40ccffa6
PE
6605 * process.c: Make symbols static if they're not exported.
6606 (process_tick, update_tick, create_process, chan_process):
6607 (Vprocess_alist, proc_buffered_char, datagram_access):
6608 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6609 (deactivate_process): Mark defn as static, as well as decl.
6610 * lisp.h (create_process): Remove decl.
6611 * process.h (chan_process, Vprocess_alist): Remove decls.
6612
ad64fc97
PE
6613 * print.c: Make symbols static if they're not exported.
6614 (print_depth, new_backquote_output, being_printed, print_buffer):
6615 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6616 (print_interval, print_number_index, initial_stderr_stream):
6617 Now static.
6618 * lisp.h (Fprinc): Remove decl.
6619 (debug_output_compilation_hack): Mark as externally visible.
6620
adddb265
PE
6621 * sysdep.c (croak): Move decl from here to syssignal.h.
6622 * syssignal.h (croak): Put it here, so the API can be checked when
6623 'croak' is called from dissociate_if_controlling_tty.
6624
1717ede2
PE
6625 * minibuf.c: Make symbols static if they're not exported.
6626 (minibuf_save_list, choose_minibuf_frame): Now static.
6627 * lisp.h (choose_minibuf_frame): Remove decl.
6628
fa5fb2bc
PE
6629 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6630
1e3890d1
PE
6631 * lread.c: Make symbols static if they're not exported.
6632 (read_objects, initial_obarray, oblookup_last_bucket_number):
6633 Now static.
6634 (make_symbol): Remove; unused.
6635 * lisp.h (initial_obarray, make_symbol): Remove decls.
6636
8a1414fa
PE
6637 * keyboard.c: Make symbols static if they're not exported.
6638 (single_kboard, recent_keys_index, total_keys, recent_keys):
6639 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6640 (this_single_command_key_start, echoing, last_auto_save):
6641 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6642 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6643 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6644 (Vlispy_mouse_stem, double_click_count):
6645 Now static.
6646 (force_auto_save_soon): Define only if SIGDANGER.
6647 (ignore_mouse_drag_p): Now static if
6648 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6649 (print_help): Remove; unused.
6650 (stop_character, last_timer_event): Mark as externally visible.
6651 * keyboard.h (ignore_mouse_drag_p): Declare only if
6652 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6653 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6654 * lisp.h (echoing): Remove decl.
6655 (force_auto_save_soon): Declare only if SIGDANGER.
6656 * xdisp.c (redisplay_window): Simplify code, to make it more
6657 obvious that ignore_mouse_drag_p is not accessed if !defined
6658 USE_GTK && !defined HAVE_NS.
6659
93ea6e8f
PE
6660 * intervals.c: Make symbols static if they're not exported.
6661 (merge_properties_sticky, merge_interval_right, delete_interval):
6662 Now static.
6663 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6664
77382fcc
PE
6665 * insdel.c: Make symbols static if they're not exported.
6666 However, leave prepare_to_modify_buffer alone. It's never
6667 called from outside this function, but that appears to be a bug.
6668 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6669 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6670 (adjust_after_replace_noundo): Remove; unused.
6671 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6672 (signal_before_change): Remove decls.
77382fcc 6673
9306c32e
PE
6674 * indent.c (val_compute_motion, val_vmotion): Now static.
6675
cd44d2eb
PE
6676 * image.c: Make symbols static if they're not exported.
6677 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6678 if USE_GTK.
6679 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6680 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6681
ad9a7a06
PE
6682 * fringe.c (standard_bitmaps): Now static.
6683 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6684
81626931
PE
6685 * frame.c: Make symbols static if they're not exported.
6686 (x_report_frame_params, make_terminal_frame): Now static.
6687 (get_frame_param): Now static, unless HAVE_NS.
6688 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6689 (x_get_resource_string): Remove; not used.
6690 * frame.h (make_terminal_frame, x_report_frame_params):
6691 (x_get_resource_string); Remove decls.
6692 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6693 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6694
239f9db9
PE
6695 * font.c, fontset.c: Make symbols static if they're not exported.
6696 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6697 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6698 * font.c (font_close_object): Now static.
6699 * font.h (font_close_object): Remove.
6700 * fontset.c (FONTSET_OBJLIST): Remove.
6701 (free_realized_fontset) #if-0 the body, which does nothing.
6702 (face_suitable_for_char_p): #if-0, as it's never called.
6703 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6704 * xfaces.c (face_at_string_position):
6705 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6706 since 0 is always ASCII.
6707
dfcf3579
PE
6708 * fns.c (weak_hash_tables): Now static.
6709
5045092b
PE
6710 * fileio.c: Make symbols static if they're not exported.
6711 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6712 (Vwrite_region_annotation_buffers): Now static.
6713
57a96f5c
PE
6714 * eval.c: Make symbols static if they're not exported.
6715 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6716 * lisp.h (backtrace_list): Remove decl.
6717
35f08c38
PE
6718 * emacs.c: Make symbols static if they're not exported.
6719 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6720 (fatal_error_code, fatal_error_signal_hook, standard_args):
6721 Now static.
6722 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6723 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6724 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6725 * lisp.h (fatal_error_signal_hook): Remove decl.
6726 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6727
f44bd759
PE
6728 * editfns.c: Move a (normally-unused) function to its only use.
6729 * editfns.c, lisp.h (get_operating_system_release): Remove.
6730 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6731 worth the hassle of breaking this out.
6732
b532497d
PE
6733 * xterm.c: Make symbols static if they're not exported.
6734 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6735 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6736 (x_destroy_window, x_delete_display):
6737 Now static.
6738 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6739 (x_mouse_leave): Remove; unused.
6740 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6741 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6742 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6743 Remove decls.
6744 (x_mouse_leave): Declare only if WINDOWSNT.
6745 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6746 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6747 USE_X_TOOLKIT.
6748
1675728f
PE
6749 * ftxfont.c: Make symbols static if they're not exported.
6750 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6751 HAVE_FREETYPE.
6752 * font.h (ftxfont_driver): Likewise.
6753
e4cebfca
PE
6754 * xfns.c: Make symbols static if they're not exported.
6755 (x_last_font_name, x_display_info_for_name):
6756 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6757 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6758 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6759 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6760 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6761 (last_show_tip_args): Now static.
6762 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6763 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6764 (x_screen_planes): Remove; unused.
6765 * dispextern.h (x_screen_planes): Remove decl.
6766
5bf46f05
PE
6767 * dispnew.c: Make symbols static if they're not exported.
6768 * dispextern.h (redraw_garbaged_frames, scrolling):
6769 (increment_row_positions): Remove.
6770 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6771 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6772 Now static.
6773 (redraw_garbaged_frames): Remove; unused.
6774
435f4c28
PE
6775 * xfaces.c: Make symbols static if they're not exported.
6776 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6777 Remove decls.
6778 * xterm.h (defined_color): Remove decls.
6779 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6780 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6781 (menu_face_changed_default, defined_color, free_realized_face):
6782 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6783 (ascii_face_of_lisp_face): Remove; unused.
6784
8524aef3
PE
6785 * xdisp.c: Make symbols static if they're not exported.
6786 * dispextern.h (scratch_glyph_row, window_box_edges):
6787 (glyph_to_pixel_coords, set_cursor_from_row):
6788 (get_next_display_element, set_iterator_to_next):
6789 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6790 (show_mouse_face): Remove decls
6791 * frame.h (message_buf_print): Likewise.
6792 * lisp.h (pop_message, set_message, check_point_in_composition):
6793 Likewise.
6794 * xterm.h (set_vertical_scroll_bar): Likewise.
6795 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6796 (message_buf_print, scratch_glyph_row, displayed_buffer):
6797 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6798 (get_next_display_element, show_mouse_face, window_box_edges):
6799 (frame_to_window_pixel_xy, check_point_in_composition):
6800 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6801 (glyph_to_pixel_coords): Remove; unused.
6802
16390cd2
PE
6803 * dired.c (file_name_completion): Now static.
6804
6805 * dbusbind.c (xd_in_read_queued_messages): Now static.
6806
a25f4dfa
PE
6807 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6808 * data.c (circular_list_error): Remove.
6809
14a9c8df
PE
6810 * commands.h (last_point_position, last_point_position_buffer):
6811 (last_point_position_window): Remove decls.
6812 * keyboard.c: Make these variables static.
6813
04f2d78b
CB
6814 * coding.h (coding, code_convert_region, encode_coding_gap):
6815 Remove decls.
74ab6df5
PE
6816 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6817 (iso_code_class, detect_coding, code_convert_region): Now static.
6818 (encode_coding_gap): Remove; unused.
6819
38dfbee1
PE
6820 * chartab.c (chartab_chars, chartab_bits): Now static.
6821
a2cb4e63
PE
6822 * charset.h (charset_iso_8859_1): Remove decl.
6823 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6824 Now static.
6825
127198fd
PE
6826 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6827 * ccl.c (Vccl_program_table): Now static.
6828 (check_ccl_update): Remove; unused.
6829
d85b608f
PE
6830 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6831 * category.h: ... from here.
6832 * category.c (check_category_table, set_category_set): Now static.
6833
31cd66f3
PE
6834 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6835 * lisp.h: Remove these decls.
6836
c358e587
PE
6837 * buffer.c (buffer_count): Remove unused var.
6838
e78aecca
PE
6839 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6840 so that it's not optimized away.
6841 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6842 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6843 exported only to the debugger.
6844
e192d7d3 6845 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6846 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6847
92470028
PE
6848 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6849 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6850 was inaccessible from Lisp.
6851 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6852 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6853
244ed907
PE
6854 alloc.c: Import and export fewer symbols, and remove unused items.
6855 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6856 is defined.
6857 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6858 it's not optimized away by whole-program optimization.
6859 (message_enable_multibyte, free_misc): Remove.
6860 (catchlist, handlerlist, mark_backtrace):
6861 Declare only if BYTE_MARK_STACK.
6862 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6863 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6864 (message_enable_multibyte): Remove decl.
6865 (free_misc, interval_free_list, float_block, float_block_index):
6866 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6867 (cons_free_list, last_marked_index):
6868 Now static.
6869 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6870 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6871 (mark_backtrace): Define only if BYTE_MARK_STACK.
6872 * xdisp.c (message_enable_multibyte): Now static.
6873
61c2b50e 6874 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6875 This makes it easier for human readers (and static analyzers)
6876 to see whether these variables are used from other modules.
6877 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6878 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6879 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6880 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6881 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6882 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6883 * xmenu.c, xselect.c:
6884 Declare Q* vars static if they are not used in other modules.
6885 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6886 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6887 Remove decls of unexported vars.
6888 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6889
95c82688
PE
6890 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6891
16a97296
PE
6892 Make Emacs functions such as Fatom 'static' by default.
6893 This makes it easier for human readers (and static analyzers)
6894 to see whether these functions can be called from other modules.
6895 DEFUN now defines a static function. To make the function external
6896 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6897 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6898 (Finit_image_library):
16a97296
PE
6899 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6900 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6901 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6902 Remove decls, since these functions are now static.
6903 (Funintern, Fget_internal_run_time): New decls, since these functions
6904 were already external.
95c82688 6905
16a97296
PE
6906 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6907 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6908 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6909 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6910 * keyboard.c, keymap.c, lread.c:
6911 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6912 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6913 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6914 Mark functions with DEFUE instead of DEFUN,
6915 if they are used in other modules.
6916 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6917 decls for now-static functions.
6918 * buffer.h (Fdelete_overlay): Remove decl.
6919 * callproc.c (Fgetenv_internal): Mark as internal.
6920 * composite.c (Fremove_list_of_text_properties): Remove decl.
6921 (Fcomposition_get_gstring): New forward static decl.
6922 * composite.h (Fcomposite_get_gstring): Remove decl.
6923 * dired.c (Ffile_attributes): New forward static decl.
6924 * doc.c (Fdocumntation_property): New forward static decl.
6925 * eval.c (Ffetch_bytecode): New forward static decl.
6926 (Funintern): Remove extern decl; now in .h file where it belongs.
6927 * fileio.c (Fmake_symbolic_link): New forward static decl.
6928 * image.c (Finit_image_library): New forward static decl.
6929 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6930 * intervals.h (Fprevious_property_change):
6931 (Fremove_list_of_text_properties): Remove decls.
6932 * keyboard.c (Fthis_command_keys): Remove decl.
6933 (Fcommand_execute): New forward static decl.
6934 * keymap.c (Flookup_key): New forward static decl.
6935 (Fcopy_keymap): Now static.
6936 * keymap.h (Flookup_key): Remove decl.
6937 * process.c (Fget_process): New forward static decl.
6938 (Fprocess_datagram_address): Mark as internal.
6939 * syntax.c (Fsyntax_table_p): New forward static decl.
6940 (skip_chars): Remove duplicate decl.
6941 * textprop.c (Fprevious_property_change): New forward static decl.
6942 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6943 Now internal.
6944 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6945 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6946
785bbd42
PE
6947 * editfns.c (Fformat): Remove unreachable code.
6948
8b913b57
AS
69492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6950
6951 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6952 change. (Bug#8496)
6953
a6744a35
EZ
69542011-04-13 Eli Zaretskii <eliz@gnu.org>
6955
6956 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6957 when at ZV. (Bug#8487)
6958
e7974947
AS
69592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6960
baad03f0
AS
6961 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6962 (Bug#8437)
6963 * keyboard.c (parse_tool_bar_item): Likewise.
6964 * sound.c (sound_cleanup, alsa_close): Likewise.
6965 * termcap.c (tgetent): Likewise.
6966 * xfns.c (x_default_font_parameter): Likewise.
6967 * xsettings.c (read_and_apply_settings): Likewise.
6968
e7974947
AS
6969 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6970 (overrun_check_free): Protoize.
6971
28272684
PE
69722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6973
6974 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6975 since callers should never pass a negative size.
6976 Change the signature to match that of plain 'read' and 'write'; see
6977 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6978 * lisp.h: Update prototypes of emacs_write and emacs_read.
6979
11997c76
EZ
69802011-04-11 Eli Zaretskii <eliz@gnu.org>
6981
6982 * xdisp.c (redisplay_window): Don't try to determine the character
6983 position of the scroll margin if the window start point w->startp
e896f03c 6984 is outside the buffer's accessible region. (Bug#8468)
11997c76 6985
8a2cbd72
EZ
69862011-04-10 Eli Zaretskii <eliz@gnu.org>
6987
6988 Fix write-region and its subroutines for buffers > 2GB.
6989 * fileio.c (a_write, e_write): Modify declaration of arguments and
6990 local variables to support buffers larger than 2GB.
6991 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6992
6993 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6994 argument, local variables, and return value.
6995
6996 * lisp.h: Update prototypes of emacs_write and emacs_read.
6997
6998 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6999
4073e537 70002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7001
1ebfdcb6
PE
7002 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7003
b2ded58d
PE
7004 Fix more problems found by GCC 4.6.0's static checks.
7005
7d66342c
PE
7006 * xdisp.c (vmessage): Use a better test for character truncation.
7007
bbf47d44
PE
7008 * charset.c (load_charset_map): <, not <=, for optimization,
7009 and to avoid potential problems with integer overflow.
9248994d 7010 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7011 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7012 * editfns.c (Fformat): Likewise.
1e69125e 7013 * syntax.c (skip_chars): Likewise.
3befa583 7014
e3019616
PE
7015 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7016 This also lets GCC 4.6.0 generate slightly better loop code.
7017
becfa255
PE
7018 * callint.c (Fcall_interactively): <, not <=, for optimization.
7019 (Fcall_interactively): Count the number of arguments produced,
7020 not the number of arguments given. This is simpler and lets GCC
7021 4.6.0 generate slightly better code.
7022
dae0cd48
PE
7023 * ftfont.c: Distingish more carefully between FcChar8 and char.
7024 The previous code passed unsigned char * to a functions like
7025 strlen and xstrcasecmp that expect char *, which does not
7026 conform to the C standard.
7027 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7028 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7029 char * when the C standard requires it.
7030
76032d70
PE
7031 * keyboard.c (read_char): Remove unused var.
7032
eb3f1cc8
PE
7033 * eval.c: Port to Windows vsnprintf (Bug#8435).
7034 Include <limits.h>.
7035 (SIZE_MAX): Define if the headers do not.
7036 (verror): Do not give up if vsnprintf returns a negative count.
7037 Instead, grow the buffer. This ports to Windows vsnprintf, which
7038 does not conform to C99. Problem reported by Eli Zaretskii.
7039 Also, simplify the allocation scheme, by avoiding the need for
7040 calling realloc, and removing the ALLOCATED variable.
7041
70476b54
PE
7042 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7043
12020a9e
PE
7044 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7045 But keep the doprint source code for now, as we might revamp it
7046 and use it again (Bug#8435).
ea6c7ae6
PE
7047 * lisp.h (doprnt): Remove.
7048 * Makefile.in (base_obj): Remove doprnt.o.
7049 * deps.mk (doprnt.o): Remove.
7050
5fdb398c
PE
7051 error: Print 32- and 64-bit integers portably (Bug#8435).
7052 Without this change, on typical 64-bit hosts error ("...%d...", N)
7053 was used to print both 32- and 64-bit integers N, which relied on
7054 undefined behavior.
7055 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7056 New macro.
7057 * lisp.h (error, verror): Mark as printf-like functions.
7058 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7059 Report overflow in size calculations when allocating printf buffer.
7060 Do not truncate output string at its first null byte.
7061 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7062 Truncate the output at a character boundary, since vsnprintf does not
7063 do that.
7064 * charset.c (check_iso_charset_parameter): Convert internal
7065 character to string before calling 'error', since %c now has the
7066 printf meaning.
7067 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7068 overflow when computing char to be passed to 'error'. Do not
7069 pass Lisp_Object to 'error'; pass the integer instead.
7070 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7071 formatted with plain %d.
7072
b189fa66
PE
7073 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7074
bff87ef0
PE
7075 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7076
7e2cac20
PE
7077 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7078
ce4d90b5
PE
7079 * xterm.c (x_catch_errors): Remove duplicate declaration.
7080
266c9547
PE
7081 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7082
79c49ad2
PE
7083 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7084
368f4090
JM
70852011-04-10 Jim Meyering <meyering@redhat.com>
7086
7087 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7088 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7089 return ssize_t not "int", and use size_t as the buffer length.
7090 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7091 * gnutls.h: Update declarations.
7092 * process.c (read_process_output): Use ssize_t, to match.
7093 (send_process): Likewise.
7094
a32d4040
CY
70952011-04-09 Chong Yidong <cyd@stupidchicken.com>
7096
7097 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7098
8546720e 70992011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7100
04f2d78b
CB
7101 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7102 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7103
8546720e
GM
7104 * xterm.c (handle_one_xevent):
7105 * xmenu.c (create_and_show_popup_menu):
7106 * xselect.c (x_decline_selection_request)
7107 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7108
0a2f5c1a 71092011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7110
7111 Fix some uses of `int' instead of EMACS_INT.
7112 * search.c (string_match_1, fast_string_match)
7113 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7114 (scan_buffer, find_next_newline_no_quit)
7115 (find_before_next_newline, search_command, Freplace_match)
7116 (Fmatch_data): Make some `int' variables be EMACS_INT.
7117
7118 * xdisp.c (display_count_lines): 3rd argument and return value now
7119 EMACS_INT. All callers changed.
7120 (pint2hrstr): Last argument is now EMACS_INT.
7121
7122 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7123 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7124 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7125 (decode_coding_utf_16, decode_coding_emacs_mule)
7126 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7127 (decode_coding_ccl, decode_coding_charset)
7128 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7129 (decode_coding_iso_2022, decode_coding_emacs_mule)
7130 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7131 <char_offset, last_offset>: Declare EMACS_INT.
7132 (encode_coding_utf_8, encode_coding_utf_16)
7133 (encode_coding_emacs_mule, encode_invocation_designation)
7134 (encode_designation_at_bol, encode_coding_iso_2022)
7135 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7136 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7137 Declare EMACS_INT.
7138 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7139 (encode_invocation_designation): Last argument P_NCHARS is now
7140 EMACS_INT.
7141 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7142 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7143
7144 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7145 All users changed.
7146
7147 * ccl.c (Fccl_execute_on_string): Declare some variables
7148 EMACS_INT.
7149
8546720e 71502011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7151
7152 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7153
4e19a977
CS
71542011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7155
7156 * process.c (Fformat_network_address): Doc fix.
7157
87302331
R
71582011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7159
7160 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7161
cbb59342
CY
71622011-04-08 Chong Yidong <cyd@stupidchicken.com>
7163
7164 * keyboard.c (read_char): Call Lisp function help-form-show,
7165 instead of using internal_with_output_to_temp_buffer.
7166 (Qhelp_form_show): New var.
e0d38eeb 7167 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7168
7169 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7170
7171 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7172
e67a13ab
CY
71732011-04-06 Chong Yidong <cyd@stupidchicken.com>
7174
04f2d78b
CB
7175 * process.c (Flist_processes): Remove to Lisp.
7176 (list_processes_1): Delete.
e67a13ab 7177
973f782d
EZ
71782011-04-06 Eli Zaretskii <eliz@gnu.org>
7179
7c106b1e
EZ
7180 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7181
973f782d
EZ
7182 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7183
41cf7d1a 71842011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7185
ca23cc88
PE
7186 Fix more problems found by GCC 4.6.0's static checks.
7187
f390e2d5
PE
7188 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7189
42eea0d0
PE
7190 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7191
b69769da 7192 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7193
f9541e84
PE
7194 * xdisp.c (vmessage): Mark as a printf-like function.
7195
13841b55
PE
7196 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7197
c136c10f
PE
7198 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7199
5e2d4a30
PE
7200 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7201 printf-like functions.
7202 (tiff_load): Add casts to remove these marks before passing them
7203 to system-supplied API.
7204
583f48b9
PE
7205 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7206
b25d760e
PE
7207 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7208 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7209 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7210 directly, rather than having caller test rule sign. This avoids
7211 some unnecessary tests.
7212 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7213 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7214 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7215
bc7b6697 7216 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7217 (xfont_open): Avoid unnecessary tests.
bc7b6697 7218
27ccc379
PE
7219 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7220
dcd5c89a
PE
7221 * composite.h, composite.c (composition_gstring_put_cache):
7222 Use EMACS_INT, not int, for length.
7223
b13a45c6
PE
7224 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7225 breaking out part of COMPOSITION_DECODE_RULE.
7226 (COMPOSITION_DECODE_RULE): Use it.
7227 * composite.c (get_composition_id): Remove unused local vars,
7228 by using the new macro.
7229
1e792e4d
PE
7230 * textprop.c (set_text_properties_1): Change while to do-while,
7231 since the condition is always true at first.
7232
dc6c6455 7233 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7234 (interval_deletion_adjustment): Return unsigned value.
7235 All uses changed.
dc6c6455 7236
aba7731a
PE
7237 * process.c (list_processes_1, create_pty, read_process_output):
7238 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7239 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7240 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7241 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7242 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7243
fdfc4bf3
PE
7244 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7245
fca8fe46 7246 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7247 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7248
06a0259a 7249 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7250 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7251 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7252
e7b9e80f
PE
7253 * print.c (print_error_message): Avoid int overflow.
7254
56201685
PE
7255 * font.c (font_list_entities): Redo for clarity,
7256 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7257
78834453 7258 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7259 (font_score): Avoid potential overflow in diff calculation.
78834453 7260
0bc0b309 7261 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7262 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7263
e610eaca
PE
7264 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7265
b895abce
PE
7266 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7267 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7268 can always succeed if overflow has undefined behavior.
7269
1f1d9321 7270 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7271 (wordify): Omit three unnecessary tests.
1f1d9321 7272
c59478bc
PE
7273 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7274 All callers changed. This avoids the need for an unused var.
7275
79b73827
PE
7276 * casefiddle.c (casify_region): Remove var that is set but not used.
7277
a4db5dfe
PE
7278 * dired.c (file_name_completion): Remove var that is set but not used.
7279
43aae36e
PE
7280 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7281
2a47c44d 7282 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7283 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7284
a37c69bf
PE
7285 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7286 Check for integer overflow on size calculations.
7287
328ab8e7
PE
7288 * buffer.c (Fprevious_overlay_change): Remove var that is set
7289 but not used.
7290
e5a2a5cb
PE
7291 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7292 Remove vars that are set but not used.
8d84a6eb 7293 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7294 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7295
a60e5f68
PE
7296 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7297
f661cb61 7298 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7299 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7300
f0397f5a
PE
7301 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7302 that are set but not used.
7303
8664db06 7304 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7305 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7306
6abdaa4a
PE
7307 * xselect.c (x_get_local_selection, x_handle_property_notify):
7308 Remove vars that are set but not used.
7309
0ce7538d 7310 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7311 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7312
9ae848fc
PE
7313 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7314 Remove var that is set but not used.
0b918413
PE
7315 (scroll_bar_windows_size): Now size_t, not int.
7316 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7317 Check for overflow.
9ae848fc 7318
a5a62657
PE
7319 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7320 (map_tty_color) [!defined MSDOS]: Likewise.
7321
5c5cdd39
PE
7322 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7323
66ebf983
PE
7324 * coding.c: Remove vars that are set but not used.
7325 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7326 All callers changed.
7327 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7328 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7329 (decode_coding_charset): Remove vars that are set but not used.
7330
1be4d761
PE
7331 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7332 that is set but not used.
7333
47553fa8
PE
7334 * print.c (print_object): Remove var that is set but not used.
7335
1f7196bf 7336 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7337 The gnulib version avoids calling malloc in the usual case,
7338 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7339 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7340 * filelock.c (current_lock_owner): Likewise.
7341 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7342 * sysdep.c: Include allocator.h, careadlinkat.h.
7343 (emacs_no_realloc_allocator): New static constant.
7344 (emacs_readlink): New function.
fdb61804
PE
7345 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7346 ../lib/careadlinkat.h.
d1fdcab7 7347
f84c17c7
SM
73482011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7349
7350 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7351 first non-nil return value).
7352
ef3862ad
JD
73532011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7354
7355 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7356 if not defined (Bug#8403).
7357
376a7006
JB
73582011-04-02 Juanma Barranquero <lekktu@gmail.com>
7359
7360 * xdisp.c (display_count_lines): Remove parameter `start',
7361 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7362 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7363 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7364 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7365 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7366 and thereabouts. All callers changed.
7367 (get_per_char_metric): Remove parameter `f', unused since
7368 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7369
6ca3801d
JM
73702011-04-02 Jim Meyering <meyering@redhat.com>
7371
7372 do not dereference NULL upon failed strdup
7373 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7374 (ns_get_family): Likewise.
7375
d8e2b5ba
JB
73762011-04-02 Juanma Barranquero <lekktu@gmail.com>
7377
7378 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7379
8c74fcbd
JD
73802011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7381
7382 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7383 later (Bug#8403).
7384
7200d79c
SM
73852011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7386
03408648 7387 Add lexical binding.
7200d79c 7388
03408648
SM
7389 * window.c (Ftemp_output_buffer_show): New fun.
7390 (Fsave_window_excursion):
7391 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7392
7393 * lread.c (lisp_file_lexically_bound_p): New function.
7394 (Fload): Bind Qlexical_binding.
7395 (readevalloop): Remove `evalfun' arg.
7396 Bind Qinternal_interpreter_environment.
7397 (Feval_buffer): Bind Qlexical_binding.
7398 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7399 Mark as dynamic.
7400 (syms_of_lread): Declare `lexical-binding'.
7401
7402 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7403
7404 * keyboard.c (eval_dyn): New fun.
7405 (menu_item_eval_property): Use it.
ca105506
SM
7406
7407 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7408
03408648
SM
7409 * fns.c (concat, mapcar1): Accept byte-code-functions.
7410
7411 * eval.c (Fsetq): Handle lexical vars.
7412 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7413 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7414 (FletX, Flet): Obey lexical binding.
7415 (Fcommandp): Handle closures.
7416 (Feval): New `lexical' arg.
7417 (eval_sub): New function extracted from Feval. Use it almost
7418 everywhere where Feval was used. Look up vars in lexical env.
7419 Handle closures.
7420 (Ffunctionp): Move from subr.el.
7421 (Ffuncall): Handle closures.
7422 (apply_lambda): Remove `eval_flags'.
7423 (funcall_lambda): Handle closures and new byte-code-functions.
7424 (Fspecial_variable_p): New function.
7425 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7426 but without exporting it to Lisp.
23aba0ea 7427
23aba0ea 7428 * doc.c (Fdocumentation, store_function_docstring):
03408648 7429 * data.c (Finteractive_form): Handle closures.
23aba0ea 7430
03408648
SM
7431 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7432 interactive spec.
ba83908c 7433
04f2d78b
CB
7434 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7435 New byte-codes.
03408648
SM
7436 (exec_byte_code): New function extracted from Fbyte_code to handle new
7437 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7438
03408648 7439 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7440
03408648 7441 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7442
e2abce01
JB
74432011-03-31 Juanma Barranquero <lekktu@gmail.com>
7444
7445 * xdisp.c (redisplay_internal): Fix prototype.
7446
63696a73 74472011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7448
63696a73 7449 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7450 (try_scrolling): Use it when setting scroll_limit.
7451 Limit scrolling to 100 screen lines.
63696a73
EZ
7452 (redisplay_window): Even when falling back on "recentering",
7453 position point in the window according to scroll-conservatively,
7454 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7455
7456 (try_scrolling): When point is above the window, allow searching
7457 as far as scroll_max, or one screenful, to compute vertical
7458 distance from PT to the scroll margin position. This prevents
7459 try_scrolling from unnecessarily failing when
7460 scroll-conservatively is set to a value slightly larger than the
7461 window height. Clean up the case of PT below the margin at bottom
7462 of window: scroll_max can no longer be INT_MAX. When aggressive
7463 scrolling is in use, don't let point enter the opposite scroll
7464 margin as result of the scroll.
7465 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7466 threshold of 100 lines for never-recentering scrolling.
7467
e4cc2dfc
JB
74682011-03-31 Juanma Barranquero <lekktu@gmail.com>
7469
7470 * dispextern.h (move_it_by_lines):
7471 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7472 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7473 (message_log_check_duplicate): Remove parameters `prev_bol' and
7474 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7475 (redisplay_internal): Remove parameter `preserve_echo_area',
7476 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7477
7478 * indent.c (Fvertical_motion):
7479 * window.c (window_scroll_pixel_based, Frecenter):
7480 Don't pass `need_y_p' to `move_it_by_lines'.
7481
1c470562
SM
74822011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7483
44f230aa
SM
7484 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7485 steal a few bits to be more compact.
7486 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7487 Remove unneeded casts.
7488
1c470562
SM
7489 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7490
888adce9
ZK
74912011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7492
7493 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7494 binding" message (bug#7967).
7495
f838ed7b
PE
74962011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7497
77861b95
PE
7498 Fix more problems found by GCC 4.6.0's static checks.
7499
de6dbc14
PE
7500 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7501 Remove unused local var.
7502
f838ed7b
PE
7503 * editfns.c (Fmessage_box): Remove unused local var.
7504
792c7b2b
PE
7505 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7506 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7507 Omit unused local vars.
c499e557 7508 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7509 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7510 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7511 Omit unused local var.
7512
ba0165e1
PE
7513 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7514 Don't assume string length fits in int.
32ad8845 7515 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7516 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7517
3c59b4c9
PE
7518 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7519 instead of alloca (Bug#8344).
7520
a3eed478 7521 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7522 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7523
eb4d412d
PE
7524 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7525
1658b401
PE
7526 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7527 concerns.
7528
7529 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7530
7531 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7532
9a2c6e05
PE
7533 * keyboard.c (syms_of_keyboard): Use the same style as later
7534 in this function when indexing through an array. This also
7535 works around GCC bug 48267.
7536
03d0a109
PE
7537 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7538
44f730c8
PE
7539 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7540
fe75f926
PE
7541 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7542 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7543
ffa8c828
PE
7544 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7545 This avoids undefined behavior on integer overflow, and is a bit
7546 more convenient anyway since it is compared to a size_t variable.
7547
c5101a77
PE
7548 Variadic C functions now count arguments with size_t, not int.
7549 This avoids an unnecessary limitation on 64-bit machines, which
7550 caused (substring ...) to crash on large vectors (Bug#8344).
7551 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7552 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7553 All variadic functions and their callers changed accordingly.
c5101a77
PE
7554 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7555 * data.c (arith_driver, float_arith_driver): Likewise.
7556 * editfns.c (general_insert_function): Likewise.
7557 * eval.c (struct backtrace.nargs, interactive_p)
7558 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7559 (funcall_lambda, mark_backtrace): Likewise.
7560 * fns.c (concat): Likewise.
7561 * frame.c (x_set_frame_parameters): Likewise.
7562 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7563 0 if not found, not -1. All callers changed.
7564
dd3f25f7
PE
7565 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7566 (stack_copy_size): Now size_t, not int.
7567 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7568
461c2ab9
JB
75692011-03-28 Juanma Barranquero <lekktu@gmail.com>
7570
7571 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7572 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7573 All callers changed.
7574
7575 * lisp.h (multibyte_char_to_unibyte):
7576 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7577 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7578 * character.h (CHAR_TO_BYTE8):
7579 * cmds.c (internal_self_insert):
7580 * editfns.c (general_insert_function):
7581 * keymap.c (push_key_description):
7582 * search.c (Freplace_match):
7583 * xdisp.c (message_dolog, set_message_1): All callers changed.
7584
f6d62986
SM
75852011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7586
7587 * keyboard.c (safe_run_hook_funcall): New function.
7588 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7589 don't set the hook to nil, but remove the offending function instead.
7590 (Qcommand_hook_internal): Remove, unused.
7591 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7592 Vcommand_hook_internal.
7593
7594 * eval.c (enum run_hooks_condition): Remove.
7595 (funcall_nil, funcall_not): New functions.
7596 (run_hook_with_args): Call each function through a `funcall' argument.
7597 Remove `cond' argument, now redundant.
7598 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7599 (Frun_hook_with_args_until_failure): Adjust accordingly.
7600 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7601
1db5b1ad
JB
76022011-03-28 Juanma Barranquero <lekktu@gmail.com>
7603
7604 * dispextern.h (string_buffer_position): Remove declaration.
7605
7606 * print.c (strout): Remove parameter `multibyte', unused since
7607 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7608
7609 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7610 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7611 All callers changed.
7612
7613 * w32.c (_wsa_errlist): Use braces for struct initializers.
7614
7615 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7616 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7617 All callers changed.
7618 (string_buffer_position): Likewise. Also, make static (it's never
7619 used outside xdisp.c).
7620 (cursor_row_p): Remove parameter `w', unused since
7621 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7622 (decode_mode_spec): Remove parameter `precision', introduced during
7623 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7624 All callers changed.
7625
5ffb62aa
JD
76262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7627
7628 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7629
461c2ab9 76302011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7631
7632 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7633 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7634 (ns_update_auto_hide_menu_bar): New functions.
7635 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7636 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7637 ns_constrain_all_frames.
7638 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7639 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7640
5c380ffb
JD
76412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7642
7643 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7644
9af30bdf
GM
76452011-03-27 Glenn Morris <rgm@gnu.org>
7646
7647 * syssignal.h: Replace RETSIGTYPE with void.
7648 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7649 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7650 Replace SIGTYPE with void everywhere.
7651 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7652 * s/template.h (SIGTYPE): Remove commented out definition.
7653
e2abce01
JB
76542011-03-26 Eli Zaretskii <eliz@gnu.org>
7655
7656 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7657 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7658
f868cd8a
JB
76592011-03-26 Juanma Barranquero <lekktu@gmail.com>
7660
59eb0929
JB
7661 * w32.c (read_unc_volume): Use parameter `henum', instead of
7662 global variable `wget_enum_handle'.
7663
7664 * keymap.c (describe_vector): Remove parameters `indices' and
7665 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7666 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7667
f868cd8a
JB
7668 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7669
7670 * keyboard.c (timer_check): Remove parameter `do_it_now',
7671 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7672 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7673 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7674
7675 * keyboard.c (read_char):
7676 * w32menu.c (w32_menu_display_help):
7677 * xmenu.c (show_help_event, menu_help_callback):
7678 Adjust calls to `show_help_echo'.
7679
7680 * gtkutil.c (xg_maybe_add_timer):
7681 * keyboard.c (readable_events):
7682 * process.c (wait_reading_process_output):
7683 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7684
7685 * insdel.c (adjust_markers_gap_motion):
7686 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7687 (gap_left, gap_right): Don't call it.
7688
2ecf6fdb
CY
76892011-03-25 Chong Yidong <cyd@stupidchicken.com>
7690
7691 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7692 incurred during fontification.
7693
6b1f9ba4
JB
76942011-03-25 Juanma Barranquero <lekktu@gmail.com>
7695
7696 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7697 (DEFVAR_PER_BUFFER): Don't pass it.
7698
7699 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7700 (scrolling_window): Don't pass it.
7701
0f4a96b5
JB
77022011-03-25 Juanma Barranquero <lekktu@gmail.com>
7703
7704 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7705
7706 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7707 and `suffix'.
7708 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7709 of variables specific to SELinux and computation of `encoded_absname'.
7710
7711 * image.c (XPutPixel): Remove unused variable `height'.
7712
7713 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7714
7715 * unexw32.c (get_section_info): Remove unused variable `section'.
7716
7717 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7718 (system_process_attributes): Remove unused variable `sess'.
7719 (sys_read): Remove unused variable `err'.
7720
7721 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7722 (w32_wnd_proc): Remove unused variable `isdead'.
7723 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7724 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7725 (x_create_tip_frame): Remove unused variable `tem'.
7726
7727 * w32inevt.c (w32_console_read_socket):
7728 Remove unused variable `no_events'.
7729
7730 * w32term.c (x_draw_composite_glyph_string_foreground):
7731 Remove unused variable `width'.
7732
1149507c
JB
77332011-03-24 Juanma Barranquero <lekktu@gmail.com>
7734
7735 * w32term.c (x_set_glyph_string_clipping):
7736 Don't pass uninitialized region to CombineRgn.
7737
9c88f339
JB
77382011-03-23 Juanma Barranquero <lekktu@gmail.com>
7739
7740 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7741 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7742 (Fx_close_connection): Remove unused variable `i'.
7743
7744 * w32font.c (w32font_draw): Return number of glyphs.
7745 (w32font_open_internal): Remove unused variable `i'.
7746 (w32font_driver): Add missing initializer.
7747
7748 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7749 (fill_in_menu): Remove unused variable `items_added'.
7750
7751 * w32term.c (last_mouse_press_frame): Remove static global variable.
7752 (w32_clip_to_row): Remove unused variable `f'.
7753 (x_delete_terminal): Remove unused variable `i'.
7754
7755 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7756 (NOTHING): Remove unused static global variable.
7757 (uniscribe_check_otf): Remove unused variable `table'.
7758 (uniscribe_font_driver): Add missing initializers.
7759
dee091a3
JD
77602011-03-23 Julien Danjou <julien@danjou.info>
7761
7762 * term.c (Fsuspend_tty, Fresume_tty):
7763 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7764 * window.c (temp_output_buffer_show):
7765 * insdel.c (signal_before_change):
7766 * frame.c (Fhandle_switch_frame):
7767 * fileio.c (Fdo_auto_save):
7768 * emacs.c (Fkill_emacs):
7769 * editfns.c (save_excursion_restore):
7770 * cmds.c (internal_self_insert):
7771 * callint.c (Fcall_interactively):
7772 * buffer.c (Fkill_all_local_variables):
7773 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7774 Use Frun_hooks.
0f4a96b5 7775 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7776 unconditionnaly since it does the check itself.
7777
2c520ab5 77782011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7779
c9c49752
PE
7780 Fix more problems found by GCC 4.5.2's static checks.
7781
8abc3f12
PE
7782 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7783 the first time through the loop, since we know p0 < p1 then.
7784 This also avoids a gcc -Wstrict-overflow warning.
7785
a2d26660
PE
7786 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7787 leading to a memory leak, possible in functions like
7788 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7789 of objects (Bug#8318).
a2d26660 7790
916c72e9
PE
7791 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7792 that could (at least in theory) be that large.
7793
19ab8a18
PE
7794 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7795 This is less likely to overflow, and avoids undefined behavior if
7796 overflow does occur. All callers changed. Use strtoul to scan
7797 for the unsigned long integer.
b7cbbd6f
PE
7798 (pint2hrstr): Simplify and tune code slightly.
7799 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7800
f0641eff
PE
7801 * scroll.c (do_scrolling): Work around GCC bug 48228.
7802 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7803
7f650bb9
PE
7804 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7805 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7806 (validate_x_resource_name): Simplify count usage.
7807 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7808
37dd57d1
PE
7809 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7810 fail (Bug#8306).
81e56e61 7811
699979fc 7812 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7813
401bf9b4
PE
7814 * process.c (Fmake_network_process): Use socklen_t, not int,
7815 where POSIX says socklen_t is required in portable programs.
7816 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7817 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7818 (Fmake_network_process, server_accept_connection):
7819 (wait_reading_process_output, read_process_output):
7820 Likewise.
7821
b93aacde
PE
7822 * process.c: Rename or move locals to avoid shadowing.
7823 (list_processes_1, Fmake_network_process):
7824 (read_process_output_error_handler, exec_sentinel_error_handler):
7825 Rename or move locals.
4dc343ee 7826 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7827 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7828 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7829 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7830 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7831
af8a867c 7832 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7833 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7834 Include tparam.h instead, since it declares them.
af8a867c
PE
7835 * cm.h (PC): Remove extern decl; tparam.h now does this.
7836 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7837 * terminfo.c: Include tparam.h, to check interfaces.
7838 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7839 (tparam): Adjust signature to match interface in tparam.h;
7840 this removes some undefined behavior. Check that outstring and len
7841 are zero, which they always are with Emacs.
7842 * tparam.h (PC, BC, UP): New extern decls.
7843
0248044d 7844 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7845 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7846
8ff096c1 7847 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7848 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7849 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7850 (ftfont_list): Remove unused local.
49eaafba
PE
7851 (get_adstyle_property, ftfont_pattern_entity):
7852 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7853 Rename locals to avoid shadowing.
8ff096c1 7854
e2be39f6
PE
7855 * xfont.c (xfont_list_family): Mark var as initialized.
7856
c9735e30
PE
7857 * xml.c (make_dom): Now static.
7858
8f5201ae
PE
7859 * composite.c (composition_compute_stop_pos): Rename local to
7860 avoid shadowing.
b246f932
PE
7861 (composition_reseat_it): Remove unused locals.
7862 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7863 (composition_update_it): Mark var as initialized.
11b61122
PE
7864 (find_automatic_composition): Mark vars as initialized,
7865 with a FIXME (Bug#8290).
8f5201ae 7866
760fbc2c
PE
7867 character.h: Rename locals to avoid shadowing.
7868 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7869 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7870 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7871 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7872 to avoid shadowing.
7873
ff08eb85
PE
7874 * textprop.c (property_change_between_p): Remove; unused.
7875
fc7bf025
PE
7876 * intervals.c (interval_start_pos): Now static.
7877
235d7abc
PE
7878 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7879
44f230aa
SM
7880 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7881 Rename locals to avoid shadowing.
3e7d6594 7882
50060332
PE
7883 * sound.c (wav_play, au_play, Fplay_sound_internal):
7884 Fix pointer signedness.
d01f234b 7885 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7886 (wav_play): Initialize a variable to 0, to prevent undefined
7887 behavior (Bug#8278).
50060332 7888
c4fc4e30
PE
7889 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7890
918436ed
PE
7891 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7892
c939f91b
PE
7893 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7894 clobbering (Bug#8298).
b9c7f648
PE
7895 * sysdep.c (sys_subshell): Likewise.
7896 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7897
6bd8c144
PE
7898 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7899 This should get cleaned up, so that child_setup has the
7900 same signature on all platforms.
7901
7710357c 7902 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7903 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7904
c59da222
CY
79052011-03-22 Chong Yidong <cyd@stupidchicken.com>
7906
7907 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7908 not to be necessary, and produces flickering.
7909
66b87493
GM
79102011-03-20 Glenn Morris <rgm@gnu.org>
7911
7912 * config.in: Remove file.
7913
45b6f6d5
JB
79142011-03-20 Juanma Barranquero <lekktu@gmail.com>
7915
7916 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7917 are now in src/globals.h.
7918 (syms_of_minibuf): Remove spurious & from previous change.
7919
3ec03f7e
LL
79202011-03-20 Leo <sdl.web@gmail.com>
7921
7922 * minibuf.c (completing-read-function): New variable.
7923 (completing-read-default): Rename from completing-read.
7924 (completing-read): Call completing-read-function.
7925
b14e3e21
CY
79262011-03-19 Juanma Barranquero <lekktu@gmail.com>
7927
7928 * xfaces.c (Fx_load_color_file):
7929 Read color file from absolute filename (bug#8250).
7930
f2b726e6
JB
79312011-03-19 Juanma Barranquero <lekktu@gmail.com>
7932
7933 * makefile.w32-in: Update dependencies.
7934
09f6ff02
EZ
79352011-03-17 Eli Zaretskii <eliz@gnu.org>
7936
7937 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7938
29a6015a
PE
79392011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7940
a3a6c54e
PE
7941 Fix more problems found by GCC 4.5.2's static checks.
7942
b766f867
PE
7943 * process.c (make_serial_process_unwind, send_process_trap):
7944 (sigchld_handler): Now static.
7945
be02381c
PE
7946 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7947 That way, the code declares only the vars that it needs.
7948 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7949 * s/cygwin.h (PTY_ITERATION): Likewise.
7950 * s/darwin.h (PTY_ITERATION): Likewise.
7951 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7952
57048744
PE
7953 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7954 * process.c (allocate_pty): Don't declare stb unless it's needed.
7955
7914961c 7956 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7957 (CONSTANTLIM): Remove; unused.
7958 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7959 Define only if needed.
7914961c 7960
b3967b18
PE
7961 * unexelf.c (unexec): Name an expression,
7962 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7963 Use a different way to cause a compilation error if anyone uses
7964 n rather than nn, a way that does not involve shadowing.
73366a00 7965 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7966
29a6015a
PE
7967 * deps.mk (unexalpha.o): Remove; unused.
7968
43cfc33e 7969 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7970 * unexec.h: New file.
ce701a33
PE
7971 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7972 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7973 Depend on unexec.h.
7974 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7975 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7976 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7977 Change as necessary to match prototype in unexec.h.
ce701a33 7978
01f44d5a
PE
7979 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7980 shadowing.
4f63c6bb 7981 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7982
a6670b0b
PE
7983 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7984 Rename locals to avoid shadowing.
7985
cef2010d 7986 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7987 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7988
d4d7173a
PE
7989 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7990
f08b802a
PE
7991 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7992 warning when compiling print.c.
7993
3ddb0639
PE
7994 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7995 instead of using an uninitialized var.
5ad03b97 7996 (font_sort_entities): Mark var as initialized.
3ddb0639 7997
170a2692
PE
7998 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7999
e663c700
PE
8000 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8001 pointers to constants.
89bc529a 8002 (font_parse_fcname): Remove unused vars.
7b81e2d0 8003 (font_delete_unmatched): Now static.
ea838e10 8004 (font_get_spec): Remove; unused.
13a547c6
PE
8005 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8006 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8007 Rename or move locals to avoid shadowing.
e663c700 8008
2a80c887 8009 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8010 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8011
1384fa33 8012 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8013 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8014
8b2c52e9
PE
8015 * alloc.c (mark_backtrace): Move decl from here ...
8016 * lisp.h: ... to here, so that it can be checked.
8017
475545b5 8018 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8019 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8020 (lisp_indirect_variable): Name an expression,
8021 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8022 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8023
b1349114 8024 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8025 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8026 Use const pointer when appropriate.
b1349114 8027
a2928364
PE
8028 * lisp.h (get_system_name, get_operating_system_release):
8029 Move decls here, to check interfaces.
8030 * process.c (get_operating_system_release): Move decl to lisp.h.
8031 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8032 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8033 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8034 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8035 (Fformat_time_string, Fencode_time, Finsert_char):
8036 (Ftranslate_region_internal, Fformat):
8037 Rename or remove local vars to avoid shadowing.
9710023e 8038 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8039
a415e694
PE
8040 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8041 avoid shadowing.
8042
8ef4622d
PE
8043 * lisp.h (eassert): Check that the argument compiles, even if
8044 ENABLE_CHECKING is not defined.
8045
946f9a5b
PE
8046 * data.c (Findirect_variable): Name an expression, to avoid
8047 gcc -Wbad-function-cast warning.
112396d6 8048 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8049 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8050 (Fmake_variable_buffer_local, Fmake_local_variable):
8051 Mark variables as initialized.
52746918 8052 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8053
e5aab7e7 8054 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8055 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8056 Rename locals to avoid shadowing.
dff45157
PE
8057 (mark_stack): Move local variables into the #ifdef region where
8058 they're used.
7bc26fdb
PE
8059 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8060 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8061 needed otherwise.
8062 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8063 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8064 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8065
e5aab7e7
PE
8066 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8067 avoids undefined behavior in theory.
8068
4da60324
PE
8069 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8070
88043301
PE
8071 Use functions, not macros, for up- and down-casing (Bug#8254).
8072 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8073 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8074 to use the following functions instead of these macros.
8075 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8076 EMACS_INT, since callers assume the returned value fits in int.
8077 (upcase1): Likewise, for UPCASE_TABLE.
8078 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8079 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8080 the race-condition problem in the old DOWNCASE.
88043301 8081
19ed5445
PE
8082 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8083 Rename locals to avoid shadowing.
8084 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8085 (regex_compile, re_search_2, re_match_2_internal):
8086 Remove unused local vars.
952db0d7
PE
8087 (FREE_VAR): Rewrite so as not to use empty "else",
8088 which gcc can warn about.
da053e48 8089 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8090 (RETALLOC_IF): Define only if needed.
8091 (WORDCHAR_P): Likewise. This one is never needed, but is used
8092 only in a comment talking about a compiler bug, so put inside
8093 the #if 0 of that comment.
8094 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8095 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8096 Remove; unused.
19ed5445 8097
1f3561e4 8098 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8099 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8100 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8101
ded6f8f7
PE
8102 * search.c (simple_search): Remove unused var.
8103
dbd37a95
PE
8104 * dired.c (compile_pattern): Move decl from here ...
8105 * lisp.h: ... to here, so that it can be checked.
8106 (struct re_registers): New forward decl.
8107
7e47afad
PE
8108 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8109
85f24f61
PE
8110 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8111 All uses changed.
8112 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8113 Rename locals to avoid shadowing.
5671df8f 8114 (Fvertical_motion): Mark locals as initialized.
85f24f61 8115
181aa2be 8116 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8117 (casify_region): Mark local as initialized.
181aa2be 8118
930d429c
PE
8119 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8120
7082eac6
PE
8121 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8122 New macros, so that the caller can use some names other than
8123 gcpro1, gcpro2, etc.
8124 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8125 of the new macros.
8126 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8127 argument, for consistency with GCPRO2_VAR, etc: it is now the
8128 prefix of the variable, not the variable itself. All uses
8129 changed.
38b2c076
PE
8130 * dired.c (directory_files_internal, file_name_completion):
8131 Rename locals to avoid shadowing.
8132
15206ed9
PE
8133 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8134 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8135 dired.c's scmp function, had undefined behavior.
8136 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8137 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8138 * buffer.h: ... to here, because these macros use current_buffer,
8139 and the new implementation with inline functions needs to have
8140 current_buffer in scope now, rather than later when the macros
8141 are used.
8142 (downcase, upcase1): New static inline functions.
8143 (DOWNCASE, UPCASE1): Reimplement using these functions.
8144 This avoids undefined behavior in expressions like
8145 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8146 from race conditions in accessing the global variables
8147 case_temp1 and case_temp2.
8148 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8149 * lisp.h (case_temp1, case_temp2): Remove their decls.
8150 * character.h (ASCII_CHAR_P): Move from here ...
8151 * lisp.h: ... to here, so that the inline functions mentioned
8152 above can use them.
8153
4a6bea26
PE
8154 * dired.c (directory_files_internal_unwind): Now static.
8155
f14b7e14
PE
8156 * fileio.c (file_name_as_directory, directory_file_name):
8157 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8158 Now static.
2893f146
PE
8159 (file_name_as_directory): Use const pointers when appropriate.
8160 (Fexpand_file_name): Likewise. In particular, newdir might
8161 point at constant storage, so make it a const pointer.
fd4ead52 8162 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8163 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8164 signedness issues.
f839df0c
PE
8165 (Fset_file_times, Finsert_file_contents, auto_save_error):
8166 Rename locals to avoid shadowing.
f14b7e14 8167
5716756e 8168 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8169 (Ftry_completion, Fall_completions): Rename or remove locals
8170 to avoid shadowing.
5716756e 8171
b4c3046a
PE
8172 * marker.c (bytepos_to_charpos): Remove; unused.
8173
b45db522
PE
8174 * lisp.h (verify_bytepos, count_markers): New decls,
8175 so that gcc does not warn that these functions aren't declared.
8176
85876d07
PE
8177 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8178 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8179 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8180 (copy_text): Remove unused local var.
85876d07 8181
03d78a21 8182 * filelock.c (within_one_second): Now static.
b3dd38ab 8183 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8184
5df8f01b
PE
8185 * buffer.c (fix_overlays_before): Mark locals as initialized.
8186 (fix_start_end_in_overlays): Likewise. This function should be
8187 simplified by using pointers-to-pointers, but that's a different
8188 matter.
b1d876f1 8189 (switch_to_buffer_1): Now static.
8f54f30a
PE
8190 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8191 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8192
a70072c9 8193 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8194 Fix pointer signedness issue.
edced198
PE
8195 (sys_subshell): Mark local as volatile if checking for lint,
8196 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8197 (MAXPATHLEN): Define only if needed.
a70072c9 8198
a0977c44
PE
8199 * process.c (serial_open, serial_configure): Move decls from here ...
8200 * systty.h: ... to here, so that they can be checked.
8201
a884fdcc
PE
8202 * fns.c (get_random, seed_random): Move extern decls from here ...
8203 * lisp.h: ... to here, so that they can be checked.
8204
604efe86 8205 * sysdep.c (reset_io): Now static.
b8950c94 8206 (wait_for_termination_signal): Remove; unused.
604efe86 8207
38fc62d9
PE
8208 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8209 (copy_keymap_item, append_key, push_text_char_description):
8210 Now static.
1004a21a 8211 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8212 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8213 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8214 (describe_map_tree):
8215 Rename locals to avoid shadowing.
38fc62d9 8216
2f2650da
PE
8217 * keyboard.c: Declare functions static if they are not used elsewhere.
8218 (echo_char, echo_dash, cmd_error, top_level_2):
8219 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8220 (read_char, kbd_buffer_get_event, make_lispy_position):
8221 (make_lispy_event, make_lispy_movement, apply_modifiers):
8222 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8223 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8224 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8225 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8226 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8227
a053e86c 8228 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8229 (mark_kboards): Move decl here ...
8230 * alloc.c (mark_kboards): ... from here.
a053e86c 8231
4752793e
PE
8232 * lisp.h (force_auto_save_soon): New decl.
8233
74f10ca7 8234 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8235 (DEFINE_DUMMY_FUNCTION): New macro.
8236 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8237 Use it.
c03cd23f
PE
8238 (main): Add casts to avoid warnings
8239 if GCC considers string literals to be constants.
74f10ca7 8240
022e70d4
PE
8241 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8242
59d6fe83
PE
8243 * dbusbind.c: Pointer signedness fixes.
8244 (xd_signature, xd_append_arg, xd_initialize):
8245 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8246 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8247 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8248 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8249
78320123
PE
8250 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8251 if GCC considers string literals to be constants.
49cebcca 8252 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8253
35ac2a97
SM
82542011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8255
fb103ca9
SM
8256 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8257 (print_preprocess, print_object): New macro to fix last change.
8258
35ac2a97
SM
8259 * print.c (print_preprocess): Don't forget font objects.
8260
62973b41
JB
82612011-03-16 Juanma Barranquero <lekktu@gmail.com>
8262
8263 * emacs.c (USAGE3): Doc fixes.
8264
0e48bb22
AS
82652011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8266
8267 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8268 structure.
8269
7684e57b
JB
82702011-03-14 Juanma Barranquero <lekktu@gmail.com>
8271
8272 * lisp.h (VWindow_system, Qfile_name_history):
8273 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8274 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8275 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8276
8277 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8278 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8279
8280 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8281 * w32console.c (detect_input_pending, read_input_pending)
8282 (encode_terminal_code):
8283 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8284 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8285 (w32_system_caret_y, Qfile_name_history):
8286 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8287 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8288 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8289 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8290 * w32proc.c (Qlocal, report_file_error):
8291 * w32term.c (Vwindow_system, updating_frame):
8292 * w32uniscribe.c (initialized, uniscribe_font_driver):
8293 Remove unneeded extern declarations.
8294
2aa46d6c
CY
82952011-03-14 Chong Yidong <cyd@stupidchicken.com>
8296
c96bbc66 8297 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8298
cffc6f3b
CY
82992011-03-13 Chong Yidong <cyd@stupidchicken.com>
8300
8301 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8302 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8303 These macros can no longer be used for assignment.
8304
44f230aa
SM
8305 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8306 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8307 (record_buffer_markers, fetch_buffer_markers): New functions for
8308 recording and fetching special buffer markers.
8309 (set_buffer_internal_1, set_buffer_temp): Use them.
8310
8311 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8312
8313 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8314
8315 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8316 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8317
8318 * xdisp.c (hscroll_window_tree):
8319 (reconsider_clip_changes): Use PT instead of BUF_PT.
8320
d251f04b
EZ
83212011-03-13 Eli Zaretskii <eliz@gnu.org>
8322
8323 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8324 $(EMACS_ROOT)/lib/intprops.h.
8325
f0c77cd1
PE
83262011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8327
3eca4629
PE
8328 Fix more problems found by GCC 4.5.2's static checks.
8329
7c86ee98
PE
8330 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8331 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8332 (xg_free_frame_widgets): Make it clear that a local variable is
8333 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8334 (gdk_window_get_screen): Make it clear that this macro is needed
8335 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8336 (int_gtk_range_get_value): New function, which avoids a diagnostic
8337 from gcc -Wbad-function-cast.
8338 (xg_set_toolkit_scroll_bar_thumb): Use it.
8339 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8340 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8341 (get_utf8_string, xg_get_file_with_chooser):
8342 Rename locals to avoid shadowing.
8343 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8344
41729b81
PE
8345 * xgselect.c (xg_select): Remove unused var.
8346
f0c77cd1
PE
8347 * image.c (four_corners_best): Mark locals as initialized.
8348 (gif_load): Initialize transparent_p to zero (Bug#8238).
8349 Mark another local as initialized.
ec6cf4c6 8350 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8351
ce0ad53d 8352 * image.c (clear_image_cache): Now static.
d5d5a617 8353 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8354 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8355 (x_edge_detection): Remove unnecessary cast that
8356 gcc -Wbad-function-cast diagnoses.
2037898d 8357 (gif_load): Fix pointer signedness.
6ae141d6
PE
8358 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8359 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8360
33383987 83612011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8362
d32df629
PE
8363 Improve quality of tests for time stamp overflow.
8364 For example, without this patch (encode-time 0 0 0 1 1
8365 1152921504606846976) returns the obviously-bogus value (-948597
8366 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8367 reports time overflow. See
8368 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8369 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8370 * editfns.c: Include limits.h and intprops.h.
8371 (TIME_T_MIN, TIME_T_MAX): New macros.
8372 (time_overflow): Move earlier, to before first use.
8373 (hi_time, lo_time): New functions, for an accurate test for
8374 out-of-range times.
8375 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8376 (Fget_internal_run_time): Don't assume time_t fits in int.
8377 (make_time): Use list2 instead of Fcons twice.
8378 (Fdecode_time): More accurate test for out-of-range times.
8379 (check_tm_member): New function.
8380 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8381 (lisp_time_argument): Don't rely on undefined left-shift and
8382 right-shift behavior when checking for time stamp overflow.
8be6f318 8383
fe31d94c
PE
8384 * editfns.c (time_overflow): New function, refactoring common code.
8385 (Fformat_time_string, Fdecode_time, Fencode_time):
8386 (Fcurrent_time_string): Use it.
8387
8be6f318
PE
8388 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8389 * dired.c (make_time): Move to ...
8390 * editfns.c (make_time): ... here.
8391 * systime.h: Note the move.
8392
09d9db2c 83932011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8394
126bc0dc
YM
8395 * fringe.c (update_window_fringes): Remove unused variables.
8396
c47cbdfd
YM
8397 * unexmacosx.c (copy_data_segment): Also copy __got section.
8398 (Bug#8223)
8399
7ac80be9
EZ
84002011-03-12 Eli Zaretskii <eliz@gnu.org>
8401
c96bbc66 8402 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8403 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8404 Constify `char *' arguments and their references according to
8405 prototypes in tparam.h.
8406
ecb0f94d 8407 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8408
7ac80be9
EZ
8409 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8410 Adapt all references accordingly.
8411
8412 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8413
ef1fd07e
TT
84142011-03-11 Tom Tromey <tromey@redhat.com>
8415
8416 * buffer.c (syms_of_buffer): Remove obsolete comment.
8417
7ef4b50c
EZ
84182011-03-11 Eli Zaretskii <eliz@gnu.org>
8419
8420 * termhooks.h (encode_terminal_code): Declare prototype.
8421
8422 * msdos.c (encode_terminal_code): Don't declare prototype.
8423
8424 * term.c (encode_terminal_code): Now external again, used by
8425 w32console.c and msdos.c.
8426
44f230aa
SM
8427 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8428 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8429
4b1ec863 84302011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8431
1714f52b 8432 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8433
4b1ec863
PE
8434 * fringe.c (update_window_fringes): Mark locals as initialized
8435 (Bug#8227).
8436 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8437
524c7aa6
PE
8438 * alloc.c (mark_fringe_data): Move decl from here ...
8439 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8440 to check its interface.
8441 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8442
a5c0af81 8443 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8444 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8445 (fontset_font): Mark local as initialized.
a9a06e0b 8446 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8447
b4716021
PE
8448 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8449
811e9bac 8450 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8451 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8452 (x_own_selection, Fx_disown_selection_internal): Rename locals
8453 to avoid shadowing.
8454 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8455
7e3ab302
PE
8456 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8457 so that the caller can use some name other than gcpro1.
8458 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8459 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8460 (Fx_backspace_delete_keys_p):
8461 Use them to avoid shadowing, and rename vars to avoid shadowing.
8462 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8463 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8464 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8465 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8466 Remove unused locals.
7e3ab302
PE
8467 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8468 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8469 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8470 macros.
f78faa98 8471
e2b13473
PE
8472 * xterm.h (x_mouse_leave): New decl.
8473
77f23912
PE
8474 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8475 Remove unused functions.
cdf4ba58
PE
8476 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8477 (x_calc_absolute_position): Now static.
7411c686 8478 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8479 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8480 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8481 unless they are used.
38d0b34a
PE
8482 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8483 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8484 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8485 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8486 (x_error_catcher, x_connection_closed, x_error_handler):
8487 (x_error_quitter, xembed_send_message, x_iconify_frame):
8488 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8489 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8490 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8491
44f230aa
SM
8492 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8493 Rename or move locals to avoid shadowing.
6b463e58 8494 (tty_defined_color, merge_face_heights): Now static.
5967d051 8495 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8496 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8497 does not deduce is never used uninitialized.
73719eba
PE
8498 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8499 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8500
426994c3 8501 * terminal.c (store_terminal_param): Now static.
5489860b 8502
032f1620 8503 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8504 (set_frame_menubar): Remove unused local.
d4323972 8505 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8506 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8507 since they might point to immutable storage.
281585b0
PE
8508 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8509 since it's unused otherwise.
032f1620 8510
367c19e5 8511 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8512 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8513 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8514 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8515 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8516 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8517 does not deduce are never used uninitialized.
70739cbe 8518
07b48fa9
PE
8519 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8520
8868a238 8521 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8522 * window.c (window_loop, size_window):
8523 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8524
7e5cf297 8525 * window.c (display_buffer): Now static.
d6550a9f
PE
8526 (size_window): Mark variables that gcc -Wuninitialized
8527 does not deduce are never used uninitialized.
a586633d
PE
8528 * window.h (check_all_windows): New decl, to forestall
8529 gcc -Wmissing-prototypes diagnostic.
5b555da1 8530 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8531
f6095868
PE
8532 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8533 shadowing.
8534 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8535 Include <limits.h>.
8536 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8537 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8538 (load_charset_map): Mark variables that gcc -Wuninitialized
8539 does not deduce are never used uninitialized.
53df7c11 8540 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8541
f38b440c
PE
8542 * coding.c (coding_set_source, coding_set_destination):
8543 Use "else { /* comment */ }" rather than "else /* comment */;"
8544 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8545 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8546 a block, when the outer 'i' will do.
8547 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8548 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8549 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8550 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8551 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8552 Rename locals to avoid shadowing.
8553 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8554 * coding.c (emacs_mule_char, encode_invocation_designation):
8555 Now static, since they're not used elsewhere.
413bb2db 8556 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8557 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8558 (decode_coding_emacs_mule): Mark variables that gcc
8559 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8560 (detect_coding_iso_2022): Initialize a local variable that might
8561 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8562 this initialization is needed. (Bug#8211)
5f58e762
PE
8563 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8564 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8565 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8566 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8567 Remove unused macros.
f38b440c 8568
232b38b9 8569 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8570 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8571 * character.c (string_count_byte8): Likewise.
232b38b9 8572
fb90da1b
PE
8573 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8574 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8575
fb93dbc2
PE
8576 * chartab.c (copy_sub_char_table): Now static, since it's not used
8577 elsewhere.
5c156ace
PE
8578 (sub_char_table_ref_and_range, char_table_ref_and_range):
8579 Rename locals to avoid shadowing.
bbcd0949 8580 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8581
7d3b3862 8582 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8583 (BIDI_BOB): Remove unused macro.
7d3b3862 8584
6be7d3da
PE
8585 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8586 deduce are never used uninitialized.
c2ed9c8b 8587 * term.c (encode_terminal_code): Likewise.
6be7d3da 8588
75f8807f 8589 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8590
50938595
PE
8591 * tparam.h: New file.
8592 * term.c, tparam.h: Include it.
8593 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8594 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8595 Move these decls to tparam.h, and make them agree with what
8596 is actually in tparam.c. The previous trick of using incompatible
8597 decls in different modules does not conform to the C standard.
8598 All callers of tparam changed to use tparam's actual API.
8599 * tparam.c (tparam1, tparam, tgoto):
8600 Use const pointers where appropriate.
8601
fbceeba2
PE
8602 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8603 * cm.h (struct cm): Likewise.
8604 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8605 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8606 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8607 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8608 (turn_on_face, init_tty): Likewise.
8609 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8610
7f3f1250
PE
8611 * term.c (term_mouse_position): Rename local to avoid shadowing.
8612
e6ca6543
PE
8613 * alloc.c (mark_ttys): Move decl from here ...
8614 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8615
c40f8d15
AS
86162011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8617
8618 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8619
cfe0661d
JB
86202011-03-09 Juanma Barranquero <lekktu@gmail.com>
8621
8622 * search.c (compile_pattern_1): Remove argument regp, unused since
8623 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8624 (compile_pattern): Don't pass it.
8625
0afb4571
J
86262011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8627
8628 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8629 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8630 for ! HAVE_GTK3.
8631 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8632
8633 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8634
8635 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8636 gdk_window_get_screen, gdk_window_get_geometry,
8637 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8638 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8639 (xg_get_pixbuf_from_pixmap): New function.
8640 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8641 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8642 Call xg_get_pixbuf_from_pixmap instead of
8643 gdk_pixbuf_get_from_drawable.
8644 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8645 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8646 (xg_check_special_colors): Use GtkStyleContext and its functions
8647 for HAVE_GTK3.
8648 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8649 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8650 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8651 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8652 Call gtk_widget_get_preferred_size.
0afb4571
J
8653 (xg_frame_resized): gdk_window_get_geometry only takes 5
8654 parameters.
44f230aa
SM
8655 (xg_win_to_widget, xg_event_is_for_menubar):
8656 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8657 (xg_set_widget_bg): New function.
8658 (delete_cb): New function.
895009e1 8659 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8660 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8661 (xg_set_background_color): Call xg_set_widget_bg.
8662 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8663 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8664 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8665 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8666 if ! HAVE_GTK3.
8667 (update_frame_tool_bar): Call gtk_widget_hide.
8668 (xg_initialize): Use GDK_KEY_g.
8669
8670 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8671 if ! HAVE_GTK3
8672 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8673
8674 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8675 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8676 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8677
1c2cc4ef
JB
86782011-03-08 Juanma Barranquero <lekktu@gmail.com>
8679
8680 * w32xfns.c (select_palette): Check success of RealizePalette against
8681 GDI_ERROR, not zero.
8682
33383987 8683See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8684
8685;; Local Variables:
8686;; coding: utf-8
aac0c6e3
MR
8687;; End:
8688
33383987 8689 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8690
8691 This file is part of GNU Emacs.
8692
8693 GNU Emacs is free software: you can redistribute it and/or modify
8694 it under the terms of the GNU General Public License as published by
8695 the Free Software Foundation, either version 3 of the License, or
8696 (at your option) any later version.
8697
8698 GNU Emacs is distributed in the hope that it will be useful,
8699 but WITHOUT ANY WARRANTY; without even the implied warranty of
8700 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8701 GNU General Public License for more details.
8702
8703 You should have received a copy of the GNU General Public License
8704 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.